]> git.ipfire.org Git - thirdparty/xtables-addons.git/commitdiff
ipv4options: resolve cppcheck warnings
authorJan Engelhardt <jengelh@inai.de>
Wed, 19 Apr 2023 23:23:28 +0000 (01:23 +0200)
committerJan Engelhardt <jengelh@inai.de>
Wed, 19 Apr 2023 23:23:28 +0000 (01:23 +0200)
libxt_ipv4options.c:123:16: error: Signed integer overflow for expression
'1<<i'. [integerOverflow]
  if (tmp & (1 << i)) {

extensions/libxt_ipv4options.c

index 696911db4e5bfdb4152119a25c89d72045a42bd1..fc31d80355cb3adc30b17edbe3103fdadd7c966c 100644 (file)
@@ -120,14 +120,14 @@ static void ipv4options_print_flags(const struct xt_ipv4options_mtinfo1 *info,
        unsigned int i;
 
        for (i = 1; i < 32; ++i)
-               if (tmp & (1 << i)) {
-                       if (info->invert & (1 << i))
+               if (tmp & (1U << i)) {
+                       if (info->invert & (1U << i))
                                printf("!");
                        if (!numeric && v4opt_names[i] != NULL)
                                printf("%s", v4opt_names[i]);
                        else
                                printf("%u", i);
-                       tmp &= ~(1 << i);
+                       tmp &= ~(1U << i);
                        if (tmp)
                                printf(",");
                }