]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blame - gdb/ChangeLog
gdb/djgpp: Add Hygon Dhyana processor support
[thirdparty/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
3960cb7a
JF
12019-08-21 Jinke Fan <fanjinke51@yeah.net>
2
3 * go32-nat.c (go32_sysinfo): Add hygon_p.
4
04c72a68
TT
52019-08-20 Tom Tromey <tom@tromey.com>
6
7 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
8 line_from_reg_element_no, first_reg_element_no_inline,
9 display_all_data, delete_data_content_windows,
10 erase_data_content>: Now private.
11
072272ce
TT
122019-08-20 Tom Tromey <tom@tromey.com>
13
14 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
15 (tui_unhighlight_win, tui_highlight_win)
16 (tui_win_info::make_window): Update.
17 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
18
973961bd
TT
192019-08-20 Tom Tromey <tom@tromey.com>
20
21 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
22 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
23 (MAX_PID_WIDTH): Move to tui-stack.c.
24 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
25 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
26 (MAX_PID_WIDTH): Move from tui-data.h.
27
ab0e1f1a
TT
282019-08-20 Tom Tromey <tom@tromey.com>
29
30 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
31 * tui/tui-wingeneral.c (box_win): Change type of win_info.
32 (box_win): Update.
33 (tui_gen_win_info::make_window): Rename from tui_make_window.
34 (tui_win_info::make_window): New method.
35 (tui_gen_win_info::make_visible): Update.
36 * tui/tui-source.c (tui_source_window::set_contents): Update.
37 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
38 (tui_data_window::display_registers_from): Update.
39 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
40 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
41 Declare.
42 <can_box>: Remove.
43 <title>: Remove.
44 (struct tui_win_info) <make_window>: Declare.
45 <can_box>: Now virtual.
46 <title>: New member.
47 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
48 * tui/tui-command.c (tui_cmd_window::resize): Update.
49
100c2bf3
TT
502019-08-20 Tom Tromey <tom@tromey.com>
51
52 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
53 * tui/tui-regs.c (tui_data_window::show_registers): Update.
54 (tui_data_window::check_register_values): Update.
55
fa4dc567
TT
562019-08-20 Tom Tromey <tom@tromey.com>
57
58 * tui/tui-regs.h (struct tui_data_window): Use
59 DISABLE_COPY_AND_ASSIGN.
60 <regs_content>: Change type, removing unique_ptr.
61 <tui_data_window>: Add move constructor.
62 * tui/tui-regs.c (tui_data_window::show_registers)
63 (tui_data_window::show_register_group)
64 (tui_data_window::display_registers_from)
65 (tui_data_window::display_registers_from)
66 (tui_data_window::first_data_item_displayed)
67 (tui_data_window::delete_data_content_windows)
68 (tui_data_window::rerender, tui_data_window::refresh_window)
69 (tui_data_window::check_register_values): Update.
70
ca02d7c8
TT
712019-08-20 Tom Tromey <tom@tromey.com>
72
73 * tui/tui-regs.h (struct tui_data_window) <show_registers,
74 show_register_group>: Declare.
75 (tui_show_register_group): Don't declare.
76 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
77 tui_show_registers.
78 (tui_data_window::show_register_group): Rename from
79 tui_show_register_group.
80 (tui_data_window::check_register_values, tui_reg_command):
81 Update.
82 * tui/tui-layout.c (tui_set_layout): Update.
83
63356bfd
TT
842019-08-20 Tom Tromey <tom@tromey.com>
85
86 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
87 Declare.
88 (tui_check_register_values): Don't declare.
89 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
90 from tui_check_register_values.
91 * tui/tui-hooks.c (tui_register_changed): Update.
92
42cc14a7
TT
932019-08-20 Tom Tromey <tom@tromey.com>
94
95 * tui/tui-regs.c (tui_reg_layout): Move later.
96 (tui_show_registers): Don't enable TUI mode or change layout.
97
b9ad3686
TT
982019-08-20 Tom Tromey <tom@tromey.com>
99
100 * tui/tui-regs.h (struct tui_data_item_window)
101 <~tui_data_item_window>: Remove.
102 <content>: Now a unique_xmalloc_ptr.
103 * tui/tui-regs.c (tui_register_format): Return a
104 unique_xmalloc_ptr.
105 (tui_get_register): Update.
106 (~tui_data_item_window): Remove.
107 (tui_data_window::display_registers_from, tui_display_register):
108 Update.
109 * tui/tui-io.h (tui_expand_tabs): Update.
110 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
111 Remove "col" parameter.
112
8e114aab
TT
1132019-08-20 Tom Tromey <tom@tromey.com>
114
115 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
116 field.
117 * tui/tui-regs.c (~tui_data_item_window): Update.
118
1a4f81dd
TT
1192019-08-20 Tom Tromey <tom@tromey.com>
120
121 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
122 earlier.
123
0f8d8876
TT
1242019-08-20 Tom Tromey <tom@tromey.com>
125
126 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
127
605dc2c2
TT
1282019-08-20 Tom Tromey <tom@tromey.com>
129
130 * tui/tui-source.h (struct tui_source_window): Update.
131 * tui/tui-regs.c (tui_show_registers): Update.
132 * tui/tui-disasm.h (struct tui_disasm_window): Update.
133 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
134 (NO_REGS_STRING): Remove defines.
135
aedbe3bb
CM
1362019-08-20 Conrad Meyer <cem@FreeBSD.org>
137
138 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
139 unnecessary thread walk if remote doesn't support the packet.
140
7ce8f214
TT
1412019-08-19 Tom Tromey <tromey@adacore.com>
142
143 * python/py-value.c (value_has_field): Fix indentation.
144
f21c2bd7
TT
1452019-08-19 Tom Tromey <tromey@adacore.com>
146
147 * printcmd.c (do_one_display, info_display_command): Update.
148 * block.h (contained_in): Return bool. Add allow_nested
149 parameter.
150 * block.c (contained_in): Return bool. Add allow_nested
151 parameter.
152
d806ea2d
TT
1532019-08-19 Tom Tromey <tom@tromey.com>
154
155 * configure: Rebuild.
156 * configure.ac: Disallow the combination of -static-libstdc++ and
157 source highlight.
158 * source-cache.c (get_language_name): Handle rust.
159 (source_cache::get_source_lines): Ignore highlighting exceptions.
160
398fdd60
TT
1612019-08-16 Tom Tromey <tom@tromey.com>
162
163 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
164 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
165 (struct tui_source_window_base) <make_visible, refresh_window,
166 resize>: Remove methods.
167 <execution_info>: Remove field.
168 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
169 (tui_show_source_line, tui_source_window_base)
170 (~tui_source_window_base): Update.
171 (tui_source_window_base::resize)
172 (tui_source_window_base::make_visible)
173 (tui_source_window_base::refresh_window): Remove.
174 (tui_source_window_base::update_exec_info): Update.
175 * tui/tui-source.c (tui_source_window::set_contents): Update.
176 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
177
e699d331
TT
1782019-08-16 Tom Tromey <tom@tromey.com>
179
180 * tui/tui-hooks.c (tui_remove_hooks): Don't set
181 deprecated_query_hook.
182
bb01dbfc
TT
1832019-08-16 Tom Tromey <tom@tromey.com>
184
185 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
186 (tui_update_source_windows_with_line): Update.
187 * tui/tui-source.h (struct tui_source_window)
188 <show_symtab_source>: Declare.
189 (tui_show_symtab_source): Don't declare.
190 * tui/tui-source.c (tui_show_symtab_source): Rename from
191 tui_show_symtab_source.
192
81c82c4b
TT
1932019-08-16 Tom Tromey <tom@tromey.com>
194
195 * tui/tui-winsource.h (struct tui_source_window_base)
196 <set_contents>: Declare.
197 * tui/tui-winsource.c
198 (tui_source_window_base::update_source_window_as_is): Update.
199 * tui/tui-source.h (struct tui_source_window) <set_contents>:
200 Declare.
201 (tui_set_source_content): Don't declare.
202 * tui/tui-source.c (tui_source_window::set_contents): Rename from
203 tui_set_source_content.
204 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
205 Declare.
206 (tui_set_disassem_content): Don't declare.
207 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
208 tui_set_disassem_content.
209
2ddaf614
TT
2102019-08-16 Tom Tromey <tom@tromey.com>
211
212 * tui/tui-winsource.h (struct tui_source_window_base)
213 <update_breakpoint_info>: Declare.
214 (tui_update_breakpoint_info): Don't declare.
215 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
216 (tui_update_all_breakpoint_info): Update.
217 (tui_source_window_base::update_breakpoint_info): Rename from
218 tui_update_breakpoint_info.
219 (tui_source_window_base::update_exec_info): Update.
220
017f9828
TT
2212019-08-16 Tom Tromey <tom@tromey.com>
222
223 * tui/tui-winsource.h (struct tui_source_window_base)
224 <update_source_window>: Declare.
225 (tui_update_source_window): Don't declare.
226 * tui/tui-winsource.c
227 (tui_source_window_base::update_source_window): Rename from
228 tui_update_source_window.
229 (tui_source_window_base::rerender): Update.
230 * tui/tui-source.c (tui_source_window::maybe_update): Update.
231 * tui/tui-disasm.c (tui_show_disassem)
232 (tui_show_disassem_and_update_source)
233 (tui_disasm_window::maybe_update): Update.
234
ed8358e9
TT
2352019-08-16 Tom Tromey <tom@tromey.com>
236
237 * tui/tui-winsource.h (struct tui_source_window_base)
238 <update_source_window_as_is>: Declare.
239 (tui_update_source_window_as_is): Don't declare.
240 * tui/tui-winsource.c (tui_update_source_window): Update
241 (tui_source_window_base::update_source_window_as_is): Rename from
242 tui_update_source_window_as_is.
243 (tui_source_window_base::refill): Update.
244 * tui/tui-source.c (tui_show_symtab_source): Update.
245 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
246 Update.
247
20149b6b
TT
2482019-08-16 Tom Tromey <tom@tromey.com>
249
250 * tui/tui-winsource.h (tui_update_source_window)
251 (tui_update_source_window_as_is): Remove "noerror" parameter.
252 * tui/tui-winsource.c (tui_update_source_window)
253 (tui_update_source_window_as_is): Remove "noerror" parameter.
254 (tui_update_source_windows_with_addr)
255 (tui_update_source_windows_with_line)
256 (tui_source_window_base::rerender)
257 (tui_source_window_base::refill): Update.
258 * tui/tui-source.h (tui_set_source_content)
259 (tui_show_symtab_source): Remove "noerror" parameter.
260 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
261 parameter.
262 (tui_show_symtab_source): Likewise.
263 (tui_source_window::maybe_update): Update.
264 * tui/tui-disasm.c (tui_show_disassem)
265 (tui_show_disassem_and_update_source)
266 (tui_disasm_window::do_scroll_vertical)
267 (tui_disasm_window::maybe_update): Update.
268
2d83e710
TT
2692019-08-16 Tom Tromey <tom@tromey.com>
270
271 * tui/tui.c (tui_is_window_visible): Update.
272 * tui/tui-wingeneral.c (tui_make_window)
273 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
274 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
275 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
276 (tui_set_win_height_command, parse_scrolling_args): Update.
277 * tui/tui-source.c (tui_source_window::style_changed): Update.
278 * tui/tui-regs.c (tui_show_registers)
279 (tui_data_window::first_data_item_displayed)
280 (tui_data_window::delete_data_content_windows)
281 (tui_check_register_values, tui_reg_command): Update.
282 * tui/tui-disasm.c (tui_show_disassem): Update.
283 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
284 method.
285 <is_visible>: Remove field.
286 * tui/tui-data.c (tui_next_win, tui_prev_win)
287 (tui_delete_invisible_windows): Update.
288
d4ab829a
TT
2892019-08-16 Tom Tromey <tom@tromey.com>
290
291 * tui/tui-winsource.h (struct tui_source_window_base)
292 <m_has_locator>: Remove.
293 * tui/tui-layout.c (show_source_disasm_command, show_data)
294 (show_source_or_disasm_and_command): Update.
295
aa7ca1bb
AH
2962019-08-16 Alan Hayward <alan.hayward@arm.com>
297
298 * NEWS (Other MI changes): New subsection.
299 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
300 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
301 * arch-utils.c (default_get_pc_address_flags): New function.
302 * arch-utils.h (default_get_pc_address_flags): New declaration.
303 * gdbarch.sh: Add get_pc_address_flags.
304 * gdbarch.c: Regenerate.
305 * gdbarch.h: Likewise.
306 * stack.c (print_pc): New function.
307 (print_frame_info) (print_frame): Call print_pc.
308
6eac171f
TV
3092019-08-16 Tom de Vries <tdevries@suse.de>
310
311 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
312 print_objfile_section_info.
313
3df505f6
TT
3142019-08-15 Tom Tromey <tom@tromey.com>
315
316 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
317 calling update_cmdwin_start_line.
318 * tui/tui-winsource.h (struct tui_source_window_base)
319 <do_make_visible_with_new_height, set_new_height>: Don't declare.
320 <rerender>: Declare.
321 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
322 Call rerender.
323 (tui_source_window_base::set_new_height): Remove.
324 (tui_source_window_base::rerender): Rename from
325 do_make_visible_with_new_height.
326 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
327 resize method.
328 (tui_win_info::make_invisible_and_set_new_height)
329 (tui_win_info::make_visible_with_new_height): Remove.
330 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
331 Declare.
332 * tui/tui-stack.c (tui_locator_window::rerender): New method.
333 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
334 do_make_visible_with_new_height>: Don't declare.
335 <rerender>: Declare.
336 * tui/tui-regs.c (tui_data_window::rerender): Rename from
337 set_new_height.
338 (tui_data_window::do_make_visible_with_new_height): Remove.
339 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
340 call tui_show_locator_content.
341 (tui_gen_win_info::resize): Call rerender.
342 (show_source_or_disasm_and_command): Don't call
343 tui_show_locator_content.
344 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
345 method.
346 (struct tui_win_info) <rerender>: Declare.
347 <set_new_height, make_invisible_and_set_new_height,
348 make_visible_with_new_height>: Don't declare.
349 * tui/tui-data.c (tui_win_list::rerender): New method.
350 * tui/tui-command.h (struct tui_cmd_window)
351 <do_make_visible_with_new_height>: Don't declare.
352 * tui/tui-command.c
353 (tui_cmd_window::do_make_visible_with_new_height): Remove.
354
272560b5
TT
3552019-08-15 Tom Tromey <tromey@adacore.com>
356
357 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
358 * ada-lang.c (ada_enum_name): Likewise.
359
08235187
CB
3602019-08-15 Christian Biesinger <cbiesinger@google.com>
361
362 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
363 leading underscore.
364 (GdbOutputErrorFile): Likewise.
365 (global scope): Adjust constructor calls to GdbOutput{,Error}File
366 accordingly.
367 (execute_unwinders): Rename to have a leading underscore.
368 (auto_load_packages): Likewise.
369 (global scope): Adjust call to auto_load_packages accordingly.
370 (GdbSetPythonDirectory): Likewise.
371 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
372 instead of execute_unwinders.
373
db502012
TT
3742019-08-15 Tom Tromey <tom@tromey.com>
375
376 * tui/tui-layout.c (show_layout, show_source_disasm_command)
377 (show_data): Don't change window visibility.
378 (tui_gen_win_info::resize): Remove special case for command
379 window. Use wresize, when available.
380 (show_source_or_disasm_and_command): Don't change window
381 visibility.
382 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
383 <make_visible>: New method.
384 * tui/tui-command.c (tui_cmd_window::resize): New method.
385
3891b65e
TT
3862019-08-15 Tom Tromey <tom@tromey.com>
387
388 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
389 (struct tui_source_windows): New.
390 * tui/tui-winsource.c (tui_display_main): Update.
391 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
392 (new_height_ok, parse_scrolling_args): Update.
393 * tui/tui-layout.c (show_layout, show_data): Update.
394 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
395 (tui_add_to_source_windows): Don't declare.
396 * tui/tui-data.c (source_windows, tui_source_windows)
397 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
398
ee556432
TT
3992019-08-15 Tom Tromey <tom@tromey.com>
400
401 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
402 Rename from reset.
403 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
404 * tui/tui-layout.c (show_source_disasm_command, show_data):
405 Update.
406 (tui_gen_win_info::resize): Rename.
407 (show_source_or_disasm_and_command): Update.
408 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
409 reset.
410
46f438e3
TT
4112019-08-15 Tom Tromey <tom@tromey.com>
412
413 * tui/tui-stack.c (tui_initialize_static_data): Remove.
414 * tui/tui-interp.c (tui_interp::init): Don't call
415 tui_initialize_static_data.
416 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
417
f4ce562c
TT
4182019-08-15 Tom Tromey <tom@tromey.com>
419
420 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
421 examine tui_win_list.
422
c398c3d0
TT
4232019-08-15 Tom Tromey <tom@tromey.com>
424
425 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
426 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
427 tui_clear_source_content.
428 (tui_clear_source_content): Remove.
429 (tui_source_window_base::do_erase_source_content): Hoist call to
430 content.clear().
431 * tui/tui-stack.c (tui_show_frame_info): Don't call
432 tui_clear_source_content.
433
e25d2004
TT
4342019-08-15 Tom Tromey <tom@tromey.com>
435
436 * tui/tui-winsource.h (struct tui_source_window_base)
437 <do_erase_source_content>: New method.
438 <erase_source_content>: New method.
439 (tui_erase_source_content): Don't declare.
440 * tui/tui-winsource.c (tui_clear_source_content): Update.
441 (tui_source_window_base::do_erase_source_content): Rename from
442 tui_erase_source_content.
443 (tui_source_window_base::show_source_content): Update.
444 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
445 * tui/tui-source.h (struct tui_source_window)
446 <erase_source_content>: New method.
447 * tui/tui-disasm.h (struct tui_disasm_window)
448 <erase_source_content>: New method.
449
002f15c2
TT
4502019-08-15 Tom Tromey <tom@tromey.com>
451
452 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
453 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
454 constructor.
455 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
456 * tui/tui-source.c (tui_set_source_content): Update.
457 * tui/tui-disasm.c (tui_set_disassem_content): Update.
458
c9033fe8
TT
4592019-08-15 Tom Tromey <tom@tromey.com>
460
461 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
462 * tui/tui-winsource.c (tui_line_is_displayed): Move to
463 tui-source.c.
464 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
465 Declare.
466 * tui/tui-source.c (tui_source_window::line_is_displayed): New
467 method.
468 (tui_source_window::maybe_update): Update.
469
088f37dd
TT
4702019-08-15 Tom Tromey <tom@tromey.com>
471
472 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
473 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
474 tui-disasm.c.
475 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
476 Declare.
477 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
478 method.
479 (tui_disasm_window::maybe_update): Update.
480
a54700c6
TT
4812019-08-15 Tom Tromey <tom@tromey.com>
482
483 * tui/tui-winsource.h (struct tui_source_window_base)
484 <maybe_update>: Declare.
485 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
486 method.
487 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
488 Declare.
489 * tui/tui-source.c (tui_source_window::maybe_update): New method.
490 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
491 Declare.
492 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
493
e2a678a5
TT
4942019-08-15 Tom Tromey <tom@tromey.com>
495
496 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
497
f2dda477
TT
4982019-08-15 Tom Tromey <tom@tromey.com>
499
500 * tui/tui-wingeneral.c: Include tui-stack.h.
501 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
502 (struct tui_locator_window): Move from tui-data.h.
503 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
504 (tui_initialize_static_data): Move from tui-data.c.
505 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
506 (struct tui_locator_window): Move to tui-stack.c.
507 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
508 (tui_initialize_static_data): Move to tui-stack.c.
509
ed4a1084
TT
5102019-08-15 Tom Tromey <tom@tromey.com>
511
512 * tui/tui-layout.c (show_source_disasm_command)
513 (show_source_or_disasm_and_command): Use make_visible method, not
514 tui_make_window.
515 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
516 Remove.
517
65962b20
TT
5182019-08-15 Tom Tromey <tom@tromey.com>
519
520 * tui/tui-wingeneral.h (tui_make_window): Update.
521 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
522 parameter.
523 (tui_gen_win_info::make_visible): Update.
524 * tui/tui-regs.c (tui_data_window::display_registers_from):
525 Update.
526 * tui/tui-layout.c (show_source_disasm_command)
527 (show_source_or_disasm_and_command): Update.
528 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
529 (enum tui_box): Remove.
530 (struct tui_win_info) <can_box>: New method.
531 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
532 method.
533
2208ee91
TV
5342019-08-15 Tom de Vries <tdevries@suse.de>
535
536 * linux-nat-trad.c: Include gdbarch.h.
537
75faf5c4
AH
5382019-08-14 Alan Hayward <alan.hayward@arm.com>
539
540 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
541 register sizes.
542
b1c896b3
TT
5432019-08-14 Tom Tromey <tromey@adacore.com>
544
545 * darwin-nat.c: Include gdbarch.h.
546 * darwin-nat-info.c: Include gdbarch.h.
547
6405cd73
TT
5482019-08-13 Tom Tromey <tom@tromey.com>
549
550 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
551 Remove.
552 * tui/tui-data.c (tui_initialize_static_data): Update.
553
5216580d
TT
5542019-08-13 Tom Tromey <tom@tromey.com>
555
556 * tui/tui-winsource.h (struct tui_exec_info_window)
557 <~tui_exec_info_window, maybe_allocate_content, get_content,
558 m_content>: Remove.
559 (struct tui_source_window_base) <set_exec_info_content,
560 show_exec_info_content>: Don't declare.
561 * tui/tui-winsource.c
562 (tui_exec_info_window::maybe_allocate_content): Remove.
563 (tui_source_window_base::update_exec_info): Rename from
564 set_exec_info_content.
565 (tui_source_window_base::show_exec_info_content)
566 (tui_source_window_base::update_exec_info): Remove.
567
93858ad3
TT
5682019-08-13 Tom Tromey <tom@tromey.com>
569
570 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
571 declare.
572 * tui/tui-winsource.c (tui_update_source_window_as_is)
573 (tui_update_source_windows_with_addr, tui_erase_source_content):
574 Update.
575 (tui_clear_exec_info_content): Remove.
576
e321e7ce
TT
5772019-08-13 Tom Tromey <tom@tromey.com>
578
579 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
580 declare.
581 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
582 call tui_erase_exec_info_content.
583 (tui_clear_exec_info_content): Rename from
584 tui_erase_exec_info_content.
585 (tui_clear_exec_info_content): Delete.
586
8270ac62
TT
5872019-08-13 Tom Tromey <tom@tromey.com>
588
589 * tui/tui-winsource.h (struct tui_source_window_base)
590 <show_exec_info_content>: Declare.
591 (tui_show_exec_info_content): Don't declare.
592 * tui/tui-winsource.c
593 (tui_source_window_base::show_exec_info_content): Rename from
594 tui_show_exec_info_content.
595 (tui_source_window_base::update_exec_info): Update.
596
7b56485d
TT
5972019-08-13 Tom Tromey <tom@tromey.com>
598
599 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
600 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
601 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
602 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
603 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
604 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
605 ... here.
606
7ba913dc
TT
6072019-08-13 Tom Tromey <tom@tromey.com>
608
609 * tui/tui-winsource.h (struct tui_source_window_base)
610 <update_exec_info>: Declare.
611 (tui_update_exec_info): Don't declare.
612 * tui/tui-winsource.c (tui_update_source_window_as_is)
613 (tui_source_window_base::refresh_all)
614 (tui_update_all_breakpoint_info): Update.
615 (tui_source_window_base::update_exec_info): Rename from
616 tui_update_exec_info.
617 * tui/tui-stack.c (tui_show_frame_info): Update.
618
37a4a131
TT
6192019-08-13 Tom Tromey <tom@tromey.com>
620
621 * tui/tui-winsource.h (struct tui_source_window_base)
622 <set_exec_info_content>: Declare.
623 (tui_set_exec_info_content): Don't declare.
624 * tui/tui-winsource.c
625 (tui_source_window_base::set_exec_info_content): Rename from
626 tui_set_exec_info_content.
627 (tui_update_exec_info): Update.
628
0bd27e07
TT
6292019-08-13 Tom Tromey <tom@tromey.com>
630
631 * tui/tui-winsource.h (struct tui_source_window_base)
632 <show_source_content>: Declare.
633 (tui_show_source_content): Don't declare.
634 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
635 (tui_source_window_base::show_source_content): Rename from
636 tui_show_source_content.
637 (tui_source_window_base::refresh_all): Update.
638 * tui/tui-layout.c (show_source_disasm_command)
639 (show_source_or_disasm_and_command): Update.
640
b4ef5aeb
TT
6412019-08-13 Tom Tromey <tom@tromey.com>
642
643 * tui/tui-winsource.c (tui_erase_source_content)
644 (tui_show_source_content, tui_source_window_base::refresh_all):
645 Update.
646 * tui/tui-wingeneral.h
647 (tui_check_and_display_highlight_if_needed): Don't declare.
648 * tui/tui-wingeneral.c
649 (tui_win_info::check_and_display_highlight_if_needed): Rename from
650 check_and_display_highlight_if_needed.
651 * tui/tui-win.c (tui_rehighlight_all)
652 (tui_win_info::make_visible_with_new_height): Update.
653 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
654 (tui_data_window::erase_data_content)
655 (tui_data_window::display_all_data): Update.
656 * tui/tui-data.h (struct tui_win_info)
657 <check_and_display_highlight_if_needed>: Declare.
658
fede5273
TT
6592019-08-13 Tom Tromey <tom@tromey.com>
660
661 * tui/tui-win.c (tui_resize_all): Call
662 tui_delete_invisible_windows.
663 * tui/tui-layout.c (show_layout): Call
664 tui_delete_invisible_windows.
665 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
666 * tui/tui-data.c (tui_delete_invisible_windows): New function.
667
22c3f490
TT
6682019-08-13 Tom Tromey <tom@tromey.com>
669
670 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
671 tui_add_win_to_layout.
672
16cb7910
TT
6732019-08-13 Tom Tromey <tom@tromey.com>
674
675 * tui/tui-layout.h (tui_default_win_height): Don't declare.
676 * tui/tui-layout.c (tui_default_win_height): Now static.
677
cc0c3ffb
TT
6782019-08-13 Tom Tromey <tom@tromey.com>
679
680 * tui/tui-layout.c (show_layout): Unify all layout cases into a
681 single switch.
682 (show_source_disasm_command, show_source_or_disasm_and_command):
683 Don't check current layout.
684
3f3ffe54
TT
6852019-08-13 Tom Tromey <tom@tromey.com>
686
687 * tui/tui-wingeneral.c (make_all_visible): Remove.
688 (tui_make_all_invisible): Simplify.
689 * tui/tui-layout.c (tui_make_all_invisible): Move from
690 tui-wingeneral.c; simplify.
691 (show_layout): Hoist call to tui_make_all_invisible.
692 (show_data): Don't call tui_make_all_invisible.
693
69258091
TT
6942019-08-13 Tom Tromey <tom@tromey.com>
695
696 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
697 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
698
62cf57fe
TT
6992019-08-13 Tom Tromey <tom@tromey.com>
700
701 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
702 tui-data.c.
703 (show_source_disasm_command, show_data)
704 (show_source_or_disasm_and_command): Don't use
705 tui_set_current_layout_to.
706 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
707 * tui/tui-data.c (current_layout, tui_current_layout): Move to
708 tui-layout.c.
709 (tui_set_current_layout_to): Remove.
710
2afade5d
TT
7112019-08-13 Tom Tromey <tom@tromey.com>
712
713 * tui/tui-layout.c (tui_set_layout): Update.
714 * tui/tui-data.h (struct tui_layout_def): Remove.
715 (tui_layout_def): Don't declare.
716 * tui/tui-data.c (layout_def): Remove.
717 (tui_layout_def): Remove.
718
a3504e96
TT
7192019-08-13 Tom Tromey <tom@tromey.com>
720
721 * tui/tui-winsource.h (struct tui_source_window_base)
722 <clear_detail>: No longer "override".
723 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
724 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
725 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
726 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
727 Remove.
728 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
729
29c92911
TT
7302019-08-13 Tom Tromey <tromey@adacore.com>
731
732 * tracepoint.c: Don't include readline.h or history.h.
733
86c6b807
TT
7342019-08-12 Tom Tromey <tom@tromey.com>
735
736 * configure: Rebuild.
737 * configure.ac: Check for readline 7.
738 * NEWS: Mention readline 7 requirement.
739 * README: Update.
740
5db2718c
TT
7412019-08-12 Tom Tromey <tom@tromey.com>
742
743 * mingw-hdep.c (gdb_select): Remove readline hack.
744
dac36daf
PFC
7452019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
746
747 * blockframe.c (find_pc_partial_function): Set *block to nullptr
748 when the function fails.
749
1022c627
AA
7502019-08-09 Andreas Arnez <arnez@linux.ibm.com>
751
752 * s390-tdep.c (s390_type_align): New function.
753 (s390_gdbarch_init): Set it as type_align gdbarch method.
754
eba4caf2
TV
7552019-08-09 Tom de Vries <tdevries@suse.de>
756
757 PR gdb/24591
758 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
759 pc_low with relocation offset.
760
123cd851
TT
7612019-08-07 Tom Tromey <tromey@adacore.com>
762
763 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
764 (print_frame_args): Update.
765 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
766 Update.
767 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
768 * frame.h (struct frame_arg): Add initializers.
769 <error>: Now a unique_xmalloc_ptr.
770
3d31bc39
AH
7712019-08-07 Alan Hayward <alan.hayward@arm.com>
772
773 * NEWS: Expand the Pointer Authentication entry.
774 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
775 (aarch64_frame_unmask_lr): ... to this.
776 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
777 Call aarch64_frame_unmask_lr.
778 * frame.c (struct frame_info): Add "masked" variable.
779 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
780 (fprint_frame): Check for masked pc.
781 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
782 declarations.
783 * python/py-framefilter.c (py_print_frame): Check for masked pc.
784 * stack.c (print_frame): Check for masked pc.
785
0cf9feb9
TT
7862019-08-06 Tom Tromey <tom@tromey.com>
787
788 * stabsread.c (patch_block_stabs, read_one_struct_field)
789 (read_enum_type): Use obstack_strndup.
790 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
791 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
792 * dwarf2read.c (guess_full_die_structure_name)
793 (anonymous_struct_prefix): Use obstack_strndup.
794 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
795 * c-exp.y (yylex): Use obstack_strndup.
796 * ada-exp.y (write_object_renaming, write_ambiguous_var)
797 (write_var_or_type): Use obstack_strndup.
798
efba19b0
TT
7992019-08-06 Tom Tromey <tom@tromey.com>
800
801 * symfile.c (reread_symbols): Use obstack_strdup.
802 * stabsread.c (read_type): Use obstack_strdup.
803 * gdb_obstack.h (obstack_strdup): New overload.
804 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
805 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
806 (dwarf2_canonicalize_name): Use obstack_strdup.
807 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
808 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
809 Use obstack_strdup.
810
f25102f7
TT
8112019-08-06 Tom Tromey <tom@tromey.com>
812
813 * gdb_obstack.h (obstack_strdup): Define.
814 * gdb_obstack.c (obstack_strdup): Don't define.
815
021887d8
TT
8162019-08-06 Tom Tromey <tom@tromey.com>
817
818 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
819 obstack_strdup.
820 * typeprint.c (typedef_hash_table::find_global_typedef): Use
821 obstack_strdup.
822 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
823 * stabsread.c (common_block_start): Use obstack_strdup.
824 * objfiles.c (set_objfile_main_name, objfile): Use
825 obstack_strdup.
826 * namespace.c (add_using_directive): Use obstack_strdup.
827 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
828 * jit.c (finalize_symtab): Use obstack_strdup.
829 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
830 (guess_partial_die_structure_name, partial_die_info::fixup)
831 (dwarf2_name): Use obstack_strdup.
832 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
833 obstack_strdup.
834 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
835 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
836 obstack_strdup.
837 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
838
d2834edc
PW
8392019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
840
841 * unittests/help-doc-selftests.c: New file.
842 * Makefile.in: Add the new file.
843
590042fc
PW
8442019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
845
846 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
847 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
848 the full first line, except when FOR_VALUE_PREFIX. In this case,
849 the trailing '.' is not output, and the first character is uppercased.
850 (print_help_for_command): Update call to print_doc_line.
851 (print_doc_of_command): Likewise.
852 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
853 * cli/cli-option.c (append_indented_doc): Do not append newline.
854 (build_help_option): Append newline after first appended_indented_doc
855 only if a second call is done.
856 (build_help): Append 2 new lines before each option, except the first
857 one.
858 * compile/compile.c (_initialize_compile): Add new lines after
859 %OPTIONS%, when not at the end of the help.
860 Change help doc or code
861 producing the help doc to respect the invariants.
862 * maint-test-options.c (_initialize_maint_test_options): Likewise.
863 Also removed the new line after 'Options:', as all other commands
864 do not put an empty line between 'Options:' and the first option.
865 * printcmd.c (_initialize_printcmd): Likewise.
866 * stack.c (_initialize_stack): Likewise.
867 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
868 incorrectly telling COMMAND is optional.
869 * ada-lang.c (_initialize_ada_language): Change help doc or code
870 producing the help doc to respect the invariants.
871 * ada-tasks.c (_initialize_ada_tasks): Likewise.
872 * breakpoint.c (_initialize_breakpoint): Likewise.
873 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
874 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
875 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
876 * cli/cli-style.c (cli_style_option::add_setshow_commands,
877 _initialize_cli_style): Likewise.
878 * corelow.c (core_target_info): Likewise.
879 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
880 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
881 * filesystem.c (_initialize_filesystem): Likewise.
882 * frame.c (_initialize_frame): Likewise.
883 * gnu-nat.c (add_task_commands): Likewise.
884 * infcall.c (_initialize_infcall): Likewise.
885 * infcmd.c (_initialize_infcmd): Likewise.
886 * interps.c (_initialize_interpreter): Likewise.
887 * language.c (_initialize_language): Likewise.
888 * linux-fork.c (_initialize_linux_fork): Likewise.
889 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
890 * maint.c (_initialize_maint_cmds): Likewise.
891 * memattr.c (_initialize_mem): Likewise.
892 * printcmd.c (_initialize_printcmd): Likewise.
893 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
894 _RegEx): Likewise.
895 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
896 * record-btrace.c (_initialize_record_btrace): Likewise.
897 * record-full.c (_initialize_record_full): Likewise.
898 * record.c (_initialize_record): Likewise.
899 * regcache-dump.c (_initialize_regcache_dump): Likewise.
900 * regcache.c (_initialize_regcache): Likewise.
901 * remote.c (add_packet_config_cmd, init_remote_threadtests,
902 _initialize_remote): Likewise.
903 * ser-tcp.c (_initialize_ser_tcp): Likewise.
904 * serial.c (_initialize_serial): Likewise.
905 * skip.c (_initialize_step_skip): Likewise.
906 * source.c (_initialize_source): Likewise.
907 * stack.c (_initialize_stack): Likewise.
908 * symfile.c (_initialize_symfile): Likewise.
909 * symtab.c (_initialize_symtab): Likewise.
910 * target-descriptions.c (_initialize_target_descriptions): Likewise.
911 * top.c (init_main): Likewise.
912 * tracefile-tfile.c (tfile_target_info): Likewise.
913 * tracepoint.c (_initialize_tracepoint): Likewise.
914 * tui/tui-win.c (_initialize_tui_win): Likewise.
915 * utils.c (add_internal_problem_command): Likewise.
916 * valprint.c (value_print_option_defs): Likewise.
917
404f2902
FCE
9182019-08-06 Frank Ch. Eigler <fche@redhat.com>
919
920 PR build/24886
921 * configure.ac: Drop enable-libmcheck support.
922 * configure, config.in: Rebuild.
923 * libmcheck.m4: Remove.
924 * acinclude.m4: Don't include it.
925 * Makefile.in: Don't distribute it.
926 * top.c (print_gdb_configuration): Don't mention it.
927
046bebe1
TT
9282019-08-06 Tom Tromey <tom@tromey.com>
929
930 * utils.c (set_output_style): Sometimes pass stream to
931 emit_style_escape.
932 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
933 * record-btrace.c (btrace_insn_history): Update.
934 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
935 method.
936 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
937 Update initializers.
938 <m_uiout>: New field.
939 <m_di>: Move lower.
940 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
941 Remove "uiout" parameter.
942 (dump_insns): Update.
943 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
944 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
945
ddbcedf5
CB
9462019-08-06 Christian Biesinger <cbiesinger@google.com>
947
948 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
949 (error_in_psymtab_expansion): Likewise.
950 (lookup_symbol_via_quick_fns): Likewise.
951 (basic_lookup_transparent_type_quick): Likewise.
952 (basic_lookup_transparent_type_1): Likewise.
953
b08b16c8
TT
9542019-08-06 Tom Tromey <tromey@adacore.com>
955
956 * source.c (last_source_error): Now bool.
957 (print_source_lines_base): Make "noprint" bool. Only open
958 source file when last_source_visited changes.
959
cb44333d
TT
9602019-08-06 Tom Tromey <tromey@adacore.com>
961
962 * annotate.c (annotate_source_line): Use g_source_cache.
963 * source-cache.c (source_cache::get_plain_source_lines): Change
964 parameters. Populate m_offset_cache.
965 (source_cache::ensure): New method.
966 (source_cache::get_line_charpos): New method.
967 (extract_lines): Move lower. Change parameters.
968 (source_cache::get_source_lines): Move lower.
969 * source-cache.h (class source_cache): Update comment.
970 <get_line_charpos>: New method.
971 <get_source_lines>: Update comment.
972 <clear>: Clear m_offset_cache.
973 <get_plain_source_lines>: Change parameters.
974 <ensure>: New method
975 <m_offset_cache>: New member.
976 * source.c (forget_cached_source_info_for_objfile): Update.
977 (info_source_command): Use g_source_cache.
978 (find_source_lines, open_source_file_with_line_charpos): Remove.
979 (print_source_lines_base, search_command_helper): Use g_source_cache.
980 * source.h (open_source_file_with_line_charpos): Don't declare.
981 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
982 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
983 Use g_source_cache.
984
872dceaa
TT
9852019-08-06 Tom Tromey <tromey@adacore.com>
986
987 * source-cache.c (source_cache::get_plain_source_lines):
988 Remove "first_line" and "last_line" parameters.
989 (source_cache::get_source_lines): Cache plain text.
990 * source-cache.h (class source_cache)
991 <get_plain_source_lines>: Update.
992
269249d9
TT
9932019-08-06 Tom Tromey <tromey@adacore.com>
994
995 * source-cache.c (extract_lines): No longer a method.
996 Changed type of parameter. Include final newline.
997 (selftests::extract_lines_test): New function.
998 (_initialize_source_cache): Likewise.
999 * source-cache.h (class source_cache)
1000 <extract_lines>: Don't declare.
1001
c0e8dcd8
TT
10022019-08-06 Tom Tromey <tromey@adacore.com>
1003
1004 * breakpoint.c (init_breakpoint_sal): Update.
1005 (breakpoint): Update.
1006 * breakpoint.h (struct breakpoint) <filter>: Now a
1007 unique_xmalloc_ptr.
1008
0b27c27d
CB
10092019-08-05 Christian Biesinger <cbiesinger@google.com>
1010
1011 * NEWS: Mention dictionary access on blocks.
1012 * python/py-block.c (blpy_getitem): New function.
1013 (block_object_as_mapping): New struct.
1014 (block_object_type): Use new struct for tp_as_mapping field.
1015
4ee94178
CB
10162019-08-05 Christian Biesinger <cbiesinger@google.com>
1017
1018 * objfiles.h (objfile): Add a comment describing partial symbols.
1019
8abfcabc
TT
10202019-08-05 Tom Tromey <tromey@adacore.com>
1021
1022 * compile/compile.c (_initialize_compile): Use _(), not N_().
1023 * thread.c (_initialize_thread): Use _(), not N_().
1024 * stack.c (_initialize_stack): Use _(), not N_().
1025 * printcmd.c (_initialize_printcmd): Use _(), not N_().
1026
2b79f376
SM
10272019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
1028
1029 * dwarf2read.c (struct dw2_symtab_iterator):
1030 <want_specific_block>: Remove.
1031 <block_index>: Change type to gdb::optional.
1032 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1033 change type of BLOCK_INDEX parameter to gdb::optional.
1034 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1035 (dw2_lookup_symbol): Don't pass argument for
1036 WANT_SPECIFIC_BLOCK.
1037 (dw2_expand_symtabs_for_function): Don't pass argument for
1038 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1039 (class dw2_debug_names_iterator)
1040 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1041 parameter, change BLOCK_INDEX type to gdb::optional.
1042 <m_want_specific_block>: Remove.
1043 <m_block_index>: Change type to gdb::optional.
1044 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1045 gdb::optional. Re-write in function of gdb::optional.
1046 (dw2_debug_names_lookup_symbol): Don't pass argument for
1047 WANT_SPECIFIC_BLOCK.
1048 (dw2_debug_names_expand_symtabs_for_function): Don't pass
1049 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1050 BLOCK_INDEX.
1051
ae60f04e
PW
10522019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1053
1054 * NEWS: Mention changes to "info sources" command.
1055
28cd9371
PW
10562019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1057
1058 * symtab.c (filename_partial_match_opts): New struct type.
1059 (struct output_source_filename_data): New members
1060 regexp, c_regexp, partial_match.
1061 (output_source_filename): Use new members to decide to print file.
1062 (info_sources_option_defs): New variable.
1063 (make_info_sources_options_def_group, print_info_sources_header,
1064 info_sources_command_completer):
1065 New functions.
1066 (info_sources_command): Read new optional arguments.
1067 (_initialize_symtab): Update info sources help.
1068
ca683e3a
AO
10692019-08-02 Alexandre Oliva <oliva@adacore.com>
1070
1071 * ada-lang.c (exception_support_info_v0): Renamed from...
1072 (default_exception_support_info): ... this. Create new
1073 definition for v1.
1074 (ada_has_this_exception_support): Look up catch_handlers_sym.
1075 (ada_exception_support_info_sniffer): Try v0 after default.
1076
f1264162
TT
10772019-08-01 Tom Tromey <tromey@adacore.com>
1078
1079 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1080 gdbarch.h.
1081
0a7b2485
CB
10822019-08-01 Christian Biesinger <cbiesinger@google.com>
1083
1084 * s12z-tdep.c: Fix include path for s12z-opc.h.
1085
c6bdbeb7
AH
10862019-08-01 Alan Hayward <alan.hayward@arm.com>
1087
1088 * NEWS: Require GNU make 3.82.
1089
a2bd7b82
TT
10902019-07-16 Tom Tromey <tom@tromey.com>
1091
1092 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1093 declare.
1094
aa3b6533
TT
10952019-07-30 Tom Tromey <tromey@adacore.com>
1096
1097 * block.c (contained_in): Remove BLOCK_FUNCTION check.
1098
a1530dc7
KB
10992019-07-30 Kevin Buettner <kevinb@redhat.com>
1100
1101 * printcmd.c (print_address_symbolic): Print negative offsets.
1102 (build_address_symbolic): Force signed arithmetic when computing
1103 offset.
1104
2906593f
CB
11052019-07-30 Christian Biesinger <cbiesinger@google.com>
1106
1107 PR/24474: Add a function to lookup static variables.
1108 * NEWS: Mention this new function.
1109 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1110 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1111 * python/python.c (python_GdbMethods): Add new function.
1112
c620ed88
CB
11132019-07-29 Christian Biesinger <cbiesinger@google.com>
1114
1115 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1116 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1117 (objfpy_lookup_static_symbol): New function.
1118 (objfile_object_methods): Add new functions.
1119
bc4268a5
PW
11202019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1121
1122 * NEWS: Mention 'set|show print frame-info'. Mention new
1123 'presence' value for 'frame-arguments'. Mention new '-frame-info'
1124 backtrace argument. Mention that python frame filtering code
1125 is now consistent with what 'backtrace' command prints.
1126
4b5e8d19
PW
11272019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1128
1129 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1130 comments.
1131 (print_frame_info_auto, print_frame_info_source_line,
1132 print_frame_info_location, print_frame_info_source_and_location,
1133 print_frame_info_location_and_address, print_frame_info_short_location):
1134 New declarations.
1135 (struct frame_print_options): New member print_frame_info.
1136 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1137 * stack.h (get_user_print_what_frame_info): New declaration.
1138 (frame_show_address): New declaration.
1139 * stack.c (print_frame_arguments_choices): New value 'presence'.
1140 (print_frame_info_auto, print_frame_info_source_line,
1141 print_frame_info_location, print_frame_info_source_and_location,
1142 print_frame_info_location_and_address, print_frame_info_short_location,
1143 print_frame_info_choices, print_frame_info_print_what): New definitions.
1144 (print_frame_args): Only print dots for args if print frame-arguments
1145 is 'presence'.
1146 (frame_print_option_defs): New element for "frame-info".
1147 (get_user_print_what_frame_info): New function.
1148 (frame_show_address): Make non static. Move comment to stack.h.
1149 (print_frame_info_to_print_what): New function.
1150 (print_frame_info): Update comment. Use fp_opts.print_frame_info
1151 to decide what to print.
1152 (backtrace_command_1): Handle the new print_frame_arguments_presence
1153 value.
1154 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1155 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1156 (py_print_frame): In non-mi mode, use LOCATION as default for
1157 print_what, similarly to frame information printed directly by
1158 backtrace command. Handle frame-info user option in non MI mode.
1159
6bdfee81
KB
11602019-07-27 Kevin Buettner <kevinb@redhat.com>
1161
1162 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1163 Add case for debugging 32-bit target on 64-bit host. Revise
1164 comment.
1165
98a617f8
KB
11662019-07-27 Kevin Buettner <kevinb@redhat.com>
1167
1168 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1169 instead of find_function_entry_range_from_pc.
1170
567238c9
KB
11712019-07-27 Kevin Buettner <kevinb@redhat.com>
1172
1173 * stack.c (find_frame_funname): Remove code which preferred
1174 minsym over symtab sym in "certain pathological cases".
1175
2dc80cf8
KB
1176 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1177 parameter. Change type of "do_demangle" to bool.
1178 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1179 Pass suitable "prefer_sym_over_minsym" flag to
1180 build_address_symbolic(). Don't output "+" for negative offsets.
1181 * printcmd.c (print_address_symbolic): Update invocation of
1182 build_address_symbolic to include a "prefer_sym_over_minsym"
1183 flag.
1184 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1185 Restrict cases in which use of minimal symbol is preferred to that
1186 of a found symbol. Update comments.
1187
1aff7173
KB
1188 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1189 for entry pc when entry pc is out of range for that FDE.
1190
89b085ac
BC
11912019-07-26 Brian Callahan <bcallah@openbsd.org>
1192
1193 PR gdb/24839:
1194 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1195 type.
1196
f32feb4a
CB
11972019-07-25 Christian Biesinger <cbiesinger@google.com>
1198
1199 * python/py-objfile.c (add_separate_debug_file): Fix comment about
1200 this function's Python signature.
1201
1202
12032019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
1204
1205 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1206 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1207 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1208 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1209 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1210
1211
c54e4253
YS
12122019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
1213
1214 * h8300-tdep.c (h8300_register_name_common): New.
1215 h8300_register_name): Use h8300_register_name_common.
1216 (h8300s_register_name): Likewise.
1217 (h8300sx_register_name): Likewise.
1218 (h8300h_register_nam): New.
1219 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1220
1221
40eadf04
SP
12222019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
1223
1224 * arm-tdep.c (arm_skip_cmse_entry): New function.
1225 (arm_is_sgstubs_section): New function.
1226 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1227
bfa2a36d
TT
12282019-07-22 Tom Tromey <tom@tromey.com>
1229
1230 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1231 Don't self-assign.
1232
a8e9d247
AB
12332019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1234
1235 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1236 type_print.
1237
eb86c5e2
AB
12382019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1239
1240 * symtab.c (search_symbols): Adjust msymbol matching type arrays
1241 so that GDB doesn't match any msymbols when searching in the
1242 TYPES_DOMAIN.
1243 (print_symbol_info): Print using typedef_print or type_print based
1244 on the type of the symbol. Add updated FIXME comment moved from...
1245 (_initialize_symtab): ... move and update FIXME comment to above.
1246
a8eab7c6
AB
12472019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1248
1249 * NEWS: Mention adding -q option to "info types".
1250 * symtab.c (struct info_types_options): New struct.
1251 (info_types_options_defs): New variable.
1252 (make_info_types_options_def_group): New function.
1253 (info_types_command): Use gdb::option framework to parse options.
1254 (info_types_command_completer): New function.
1255 (_initialize_symtab): Extend the help text on "info types" and
1256 register command completer.
1257
b4603c34
CB
12582019-07-21 Christian Biesinger <cbiesinger@google.com>
1259
1260 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1261 (lookup_symbol_in_objfile): Change int to block_enum and add a
1262 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1263
c8cdc1e0
CB
12642019-07-20 Christian Biesinger <cbiesinger@google.com>
1265
1266 * MAINTAINERS (Write After Approval): Add self.
1267
01e175fe
AB
12682019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
1269
1270 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1271 instruction to the dummy code region.
1272
56f79b63
TT
12732019-07-19 Tom Tromey <tromey@adacore.com>
1274
1275 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1276 (ARGSUSED, PARAMS, __func__): Remove rules.
1277
4c5aa8e0
AH
12782019-07-19 Alan Hayward <alan.hayward@arm.com>
1279
1280 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1281 * features/arm/arm-with-iwmmxt.c: Remove.
1282 * features/arm/arm-with-iwmmxt.xml: Remove.
1283 * features/arm/arm-with-m-fpa-layout.c: Remove.
1284 * features/arm/arm-with-m-fpa-layout.xml: Remove.
1285 * features/arm/arm-with-m-vfp-d16.c: Remove.
1286 * features/arm/arm-with-m-vfp-d16.xml: Remove.
1287 * features/arm/arm-with-m.c: Remove.
1288 * features/arm/arm-with-m.xml: Remove.
1289 * features/arm/arm-with-neon.c: Remove.
1290 * features/arm/arm-with-neon.xml: Remove.
1291 * features/arm/arm-with-vfpv2.c: Remove.
1292 * features/arm/arm-with-vfpv2.xml: Remove.
1293 * features/arm/arm-with-vfpv3.c: Remove.
1294 * features/arm/arm-with-vfpv3.xml: Remove.
1295
f42b2617
AH
12962019-07-19 Alan Hayward <alan.hayward@arm.com>
1297
1298 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1299
f29ec966
AH
13002019-07-19 Alan Hayward <alan.hayward@arm.com>
1301
1302 * arch/aarch32.c (aarch32_create_target_description): Create
1303 target descriptions using features.
1304 * arch/arm.c (arm_create_target_description)
1305 (arm_create_mprofile_target_description): Likewise.
1306 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1307
d105cce5
AH
13082019-07-19 Alan Hayward <alan.hayward@arm.com>
1309
1310 * Makefile.in: Add new files.
1311 * aarch32-tdep.c: New file.
1312 * aarch32-tdep.h: New file.
1313 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1314 Call aarch32_read_description.
1315 * arch/aarch32.c: New file.
1316 * arch/aarch32.h: New file.
1317 * arch/arm.c (arm_create_target_description)
1318 (arm_create_mprofile_target_description): New function.
1319 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1320 (arm_create_target_description)
1321 (arm_create_mprofile_target_description): New declaration.
1322 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1323 read_description functions.
1324 * arm-linux-nat.c (arm_linux_nat_target::read_description):
1325 Likewise.
1326 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1327 * arm-tdep.c (tdesc_arm_list): New variable.
1328 (arm_register_g_packet_guesses): Call create description functions.
1329 (arm_read_description) (arm_read_mprofile_description): New
1330 function.
1331 * arm-tdep.h (arm_read_description)
1332 (arm_read_mprofile_description): Add declaration.
1333 * configure.tgt: Add new files.
1334
afe09f0b
GL
13352019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
1336
1337 * top.c (new_ui_command): Open specified terminal just once.
1338
cd215b2e
TT
13392019-07-18 Tom Tromey <tromey@adacore.com>
1340
1341 * symtab.c (main_name): Constify return type.
1342 * symfile.c (set_initial_language): Update.
1343 * symtab.h (main_name): Constify return type.
1344
d8f68fcb
TT
13452019-07-17 Tom Tromey <tom@tromey.com>
1346
1347 * tui/tui-winsource.c (tui_update_source_window)
1348 (tui_update_source_window_as_is)
1349 (tui_update_source_windows_with_line): Remove return.
1350 * tui/tui-disasm.c (tui_show_disassem)
1351 (tui_show_disassem_and_update_source): Remove return.
1352 * tui/tui.c (tui_reset): Remove return.
1353 * tui/tui-wingeneral.c
1354 (tui_check_and_display_highlight_if_needed): Remove return.
1355
ca5af91e
TT
13562019-07-17 Tom Tromey <tom@tromey.com>
1357
1358 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1359
5104fe36
TT
13602019-07-17 Tom Tromey <tom@tromey.com>
1361
1362 * tui/tui-winsource.h (struct tui_exec_info_window)
1363 (struct tui_source_window_base): Move from tui-data.h.
1364 * tui/tui-winsource.c: Move many method definitions from
1365 elsewhere. Remove "structuring" comments.
1366 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1367 (tui_source_window_base::refresh_window): Move to
1368 tui-winsource.c.
1369 * tui/tui-win.c (tui_source_window_base::refresh_all)
1370 (tui_source_window_base::update_tab_width)
1371 (tui_source_window_base::set_new_height)
1372 (tui_source_window_base::do_make_visible_with_new_height): Move to
1373 tui-winsource.c.
1374 * tui/tui-source.h: Update.
1375 * tui/tui-source.c (tui_source_window_base::reset): Move to
1376 tui-winsource.c.
1377 * tui/tui-disasm.h: Update.
1378 * tui/tui-data.h (struct tui_exec_info_window): Move to
1379 tui-winsource.h.
1380 (struct tui_source_window_base): Likewise.
1381 * tui/tui-data.c (tui_source_window_base::clear_detail)
1382 (tui_source_window_base, ~tui_source_window_base): Move to
1383 tui-winsource.c.
1384
daa15dde
TT
13852019-07-17 Tom Tromey <tom@tromey.com>
1386
1387 * tui/tui-win.c (tui_resize_all)
1388 (tui_source_window_base::update_tab_width)
1389 (tui_adjust_win_heights): Update.
1390 (tui_win_info::make_invisible_and_set_new_height): Rename from
1391 make_invisible_and_set_new_height.
1392 * tui/tui-data.h (struct tui_win_info)
1393 <make_invisible_and_set_new_height>: New method.
1394
bfad4537
TT
13952019-07-17 Tom Tromey <tom@tromey.com>
1396
1397 * tui/tui.c: Update.
1398 * tui/tui-source.h (struct tui_source_window): Move from
1399 tui-data.h.
1400 * tui/tui-layout.c: Update.
1401 * tui/tui-disasm.c: Update.
1402 * tui/tui-data.h (struct tui_source_window): Move to
1403 tui-source.h.
1404
88f7e873
TT
14052019-07-17 Tom Tromey <tom@tromey.com>
1406
1407 * tui/tui-disasm.h (struct tui_disasm_window): Move from
1408 tui-data.h.
1409 * tui/tui-data.h (struct tui_disasm_window): Move to
1410 tui-disasm.h.
1411
96bd6233
TT
14122019-07-17 Tom Tromey <tom@tromey.com>
1413
1414 * tui/tui-regs.h (struct tui_data_item_window): Move from
1415 tui-data.h.
1416 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1417 * tui/tui-data.h (struct tui_data_item_window): Move to
1418 tui-regs.h.
1419 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1420
ce38393b
TT
14212019-07-17 Tom Tromey <tom@tromey.com>
1422
1423 * tui/tui.c: Update.
1424 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1425 (tui_cmd_window::max_height): Move to tui-command.c.
1426 * tui/tui-layout.c: Update.
1427 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1428 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1429 tui-command.c.
1430 * tui/tui-command.h (struct tui_cmd_window): Move from
1431 tui-data.h.
1432 * tui/tui-command.c: Remove "structuring" comments.
1433 (tui_cmd_window::clear_detail)
1434 (tui_cmd_window::do_make_visible_with_new_height)
1435 (tui_cmd_window::max_height): Move from elsewhere.
1436
2d8b51cb
TT
14372019-07-17 Tom Tromey <tom@tromey.com>
1438
1439 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1440 Now static.
1441 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1442 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1443
18ab23af
TT
14442019-07-17 Tom Tromey <tom@tromey.com>
1445
1446 * tui/tui.c: Update.
1447 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1448 tui-regs.c.
1449 * tui/tui-windata.h: Remove file.
1450 * tui/tui-windata.c: Remove file.
1451 * tui/tui-win.c (tui_data_window::set_new_height)
1452 (tui_data_window::do_make_visible_with_new_height): Move to
1453 tui-regs.c.
1454 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1455 * tui/tui-regs.c: Remove "structuring" comments.
1456 (tui_data_window::first_data_item_displayed)
1457 (tui_data_window::delete_data_content_windows)
1458 (tui_data_window::erase_data_content)
1459 (tui_data_window::display_all_data)
1460 (tui_data_window::refresh_all)
1461 (tui_data_window::do_scroll_vertical)
1462 (tui_data_window::clear_detail, tui_data_window::set_new_height)
1463 (tui_data_window::do_make_visible_with_new_height)
1464 (tui_data_window::refresh_window): Move from elsewhere.
1465 (_initialize_tui_regs): Move to end of file.
1466 * tui/tui-layout.c: Update.
1467 * tui/tui-hooks.c: Update.
1468 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1469 * tui/tui-data.c (tui_data_window::clear_detail): Move to
1470 tui-regs.c.
1471 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1472
88b7e7cc
TT
14732019-07-17 Tom Tromey <tom@tromey.com>
1474
1475 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1476 seen.
1477
0fcd3711
TT
14782019-07-17 Tom Tromey <tom@tromey.com>
1479
1480 * tui/tui-win.c (tui_source_window_base::set_new_height)
1481 (tui_source_window_base::do_make_visible_with_new_height): Use
1482 m_has_locator field directly.
1483 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1484 method.
1485 (struct tui_source_window_base) <has_locator>: Likewise.
1486
4a38112d
TT
14872019-07-17 Tom Tromey <tom@tromey.com>
1488
1489 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1490 Don't declare.
1491 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1492 Remove.
1493 * tui/tui-win.c (tui_source_window_base::set_new_height)
1494 (tui_source_window_base::set_new_height)
1495 (make_invisible_and_set_new_height)
1496 (tui_source_window_base::do_make_visible_with_new_height)
1497 (tui_source_window_base::do_make_visible_with_new_height):
1498 Update.
1499 * tui/tui-layout.c (show_source_disasm_command, show_data)
1500 (show_source_or_disasm_and_command): Update.
1501 * tui/tui-layout.c (show_layout): Update.
1502
09129226
TT
15032019-07-17 Tom Tromey <tom@tromey.com>
1504
1505 * tui/tui-layout.c (make_data_window): Remove.
1506 (show_data): Unify creation and re-initialization cases.
1507
4a8a5e84
TT
15082019-07-17 Tom Tromey <tom@tromey.com>
1509
1510 * tui/tui-layout.c (make_source_window, make_disasm_window):
1511 Remove.
1512 (show_data): Unify creation and re-initialization cases.
1513
76d2be8e
TT
15142019-07-17 Tom Tromey <tom@tromey.com>
1515
1516 * tui/tui-layout.c (make_command_window): Remove.
1517 (show_source_disasm_command, show_source_or_disasm_and_command):
1518 Unify creation and re-initialization cases.
1519
890b8bde
TT
15202019-07-17 Tom Tromey <tom@tromey.com>
1521
1522 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1523 creation and re-initialization cases.
1524
2cdfa113
TT
15252019-07-17 Tom Tromey <tom@tromey.com>
1526
1527 * tui/tui-regs.c (tui_get_register): Return void.
1528
8e3cfd09
TT
15292019-07-17 Tom Tromey <tom@tromey.com>
1530
1531 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1532 Simplify.
1533
f4e04977
TT
15342019-07-17 Tom Tromey <tom@tromey.com>
1535
1536 * tui/tui-layout.c (show_source_disasm_command): Simplify window
1537 resetting.
1538
0379b883
TT
15392019-07-17 Tom Tromey <tom@tromey.com>
1540
1541 * tui/tui.h (tui_set_layout_by_name): Don't declare.
1542 * tui/tui-regs.c (tui_reg_layout): New function.
1543 (tui_show_registers, tui_reg_command): Use it.
1544 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1545 (tui_layout_command): Rename from tui_set_layout_by_name. Change
1546 parameters.
1547 (tui_layout_command): Remove.
1548
b7fbad91
TT
15492019-07-17 Tom Tromey <tom@tromey.com>
1550
1551 * tui/tui-layout.h (tui/tui-layout): Return void.
1552 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
1553
4e1e56b9
TT
15542019-07-17 Tom Tromey <tom@tromey.com>
1555
1556 * tui/tui-layout.c (show_source_disasm_command, show_data):
1557 Update.
1558 (reset_locator): Remove.
1559 (show_source_or_disasm_and_command): Update.
1560
1e0c09ba
TT
15612019-07-17 Tom Tromey <tom@tromey.com>
1562
1563 * tui/tui-source.c (tui_source_window_base::reset): Remove
1564 win_type parameter.
1565 * tui/tui-layout.c (make_command_window, make_source_window)
1566 (make_disasm_window, make_data_window)
1567 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1568 (reset_locator, show_source_or_disasm_and_command): Update.
1569 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1570 win_type parameter.
1571 (struct tui_source_window_base) <reset>: Likewise.
1572
1bf605de
TT
15732019-07-17 Tom Tromey <tom@tromey.com>
1574
1575 * tui/tui-layout.c (show_source_disasm_command): Use
1576 reset_locator.
1577 (reset_locator): New function.
1578 (init_and_make_win): Remove.
1579 (show_source_or_disasm_and_command): Use reset_locator.
1580
098f9ed4
TT
15812019-07-17 Tom Tromey <tom@tromey.com>
1582
1583 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1584 condition.
1585 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1586 Remove condition.
1587 * tui/tui-source.c (tui_source_window_base::reset): New method.
1588 * tui/tui-layout.c (make_command_window): Don't call
1589 init_and_make_win.
1590 (make_source_window, make_disasm_window): Don't call
1591 make_source_or_disasm_window.
1592 (make_data_window): Don't call init_and_make_win. Change calling
1593 convention.
1594 (show_source_disasm_command, show_data): Simplify.
1595 (make_source_or_disasm_window): Remove.
1596 (show_source_or_disasm_and_command): Simplify.
1597 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1598 (struct tui_source_window_base) <reset>: Likewise.
1599 <execution_info>: Remove initializer.
1600 * tui/tui-data.c (tui_source_window_base): Initialize
1601 execution_info.
1602
80110957
TT
16032019-07-17 Tom Tromey <tom@tromey.com>
1604
1605 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1606 variable.
1607
cf82af05
TT
16082019-07-17 Tom Tromey <tom@tromey.com>
1609
1610 * tui/tui.c (tui_rl_other_window): Update.
1611 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1612 superclass method first. Always iterate over regs_content.
1613 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1614 method.
1615 * tui/tui-win.c (tui_set_focus_command): Update.
1616
01aeb396
TT
16172019-07-17 Tom Tromey <tom@tromey.com>
1618
1619 * tui/tui-win.c (tui_set_focus_command): Rename from
1620 tui_set_focus. Call tui_enable.
1621 (tui_set_focus_command): Remove.
1622
fd6c75ee
TT
16232019-07-17 Tom Tromey <tom@tromey.com>
1624
1625 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1626 refresh_window.
1627 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1628 touchwin.
1629 (tui_data_window::refresh_window): Call refresh_window on data
1630 items. Always call superclass refresh_window.
1631 (tui_win_info::refresh): Remove.
1632 (tui_source_window_base::refresh_window): Update.
1633 (tui_refresh_all): Update.
1634 * tui/tui-layout.c (show_source_disasm_command): Remove call to
1635 refresh_window.
1636 (show_source_or_disasm_and_command): Likewise.
1637 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1638 (struct tui_source_window_base) <refresh>: Likewise.
1639
f6cc34a9
TT
16402019-07-17 Tom Tromey <tom@tromey.com>
1641
1642 * tui/tui-winsource.c (tui_clear_source_content)
1643 (tui_show_source_content): Update.
1644 * tui/tui-source.c (tui_source_window::showing_source_p): Check
1645 whether content is empty.
1646 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1647 Remove.
1648
f31ec9af
TT
16492019-07-17 Tom Tromey <tom@tromey.com>
1650
1651 * tui/tui-winsource.c (tui_erase_source_content): Clear the
1652 window's contents.
1653 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1654 * tui/tui-source.c (tui_set_source_content_nil): Remove.
1655
d1b6f1e5
TT
16562019-07-17 Tom Tromey <tom@tromey.com>
1657
1658 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1659 (struct tui_data_item_window): Update.
1660
d9743a13
TT
16612019-07-17 Tom Tromey <tom@tromey.com>
1662
1663 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1664 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1665 defines.
1666
caf0bc4e
TT
16672019-07-17 Tom Tromey <tom@tromey.com>
1668
1669 * tui/tui-winsource.h (tui_erase_source_content)
1670 (tui_clear_source_content): Remove "display_prompt" parameter.
1671 * tui/tui-winsource.c (tui_update_source_window_as_is)
1672 (tui_update_source_windows_with_addr): Update.
1673 (tui_clear_source_content): Remove "display_prompt" parameter.
1674 (tui_erase_source_content): Likewise. Simplify.
1675 (tui_show_source_content): Update.
1676 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1677 * tui/tui-stack.c (tui_show_frame_info): Update.
1678 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1679 Remove defines.
1680
9d391078
TT
16812019-07-17 Tom Tromey <tom@tromey.com>
1682
1683 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1684 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1685 parameter.
1686 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1687 parameter.
1688
a38da35d
TT
16892019-07-17 Tom Tromey <tom@tromey.com>
1690
1691 * tui/tui-winsource.c (tui_clear_source_content)
1692 (tui_show_source_content, tui_show_exec_info_content)
1693 (tui_clear_exec_info_content): Update.
1694 * tui/tui-stack.c (tui_show_locator_content): Update.
1695 (tui_show_frame_info): Update.
1696 * tui/tui-source.h (tui_source_window): Don't declare.
1697 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1698 from tui_source_is_displayed.
1699 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1700 Remove field.
1701 (struct tui_source_window_base) <content_in_use>: New field. Now
1702 bool.
1703 (struct tui_source_window) <showing_source_p>: New method.
1704 (TUI_SRC_WIN): Change cast.
1705 * tui/tui-data.c (tui_initialize_static_data): Update.
1706
c2cd8994
TT
17072019-07-17 Tom Tromey <tom@tromey.com>
1708
1709 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1710 location_matches_p.
1711 * tui/tui-source.c (tui_source_window::location_matches_p): New
1712 method.
1713 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1714 method.
1715 * tui/tui-data.h (struct tui_source_window_base)
1716 <location_matches_p>: New method.
1717 (struct tui_source_window, struct tui_disasm_window)
1718 <location_matches_p>: Likewise.
1719
4dde7b34
TT
17202019-07-17 Tom Tromey <tom@tromey.com>
1721
1722 * tui/tui-win.c (tui_set_win_height_command): Rename from
1723 tui_set_win_height.
1724 (tui_set_win_height_command): Remove.
1725
b73dd877
TT
17262019-07-17 Tom Tromey <tom@tromey.com>
1727
1728 * tui/tui-source.c (tui_source_window): New constructor. Add
1729 observer.
1730 (~tui_source_window): New destructor.
1731 (tui_source_window::style_changed): New method.
1732 * tui/tui-hooks.c (tui_redisplay_source): Remove.
1733 (tui_attach_detach_observers): Update.
1734 * tui/tui-data.h (struct tui_source_window): Make constructor not
1735 inline. Add destructor.
1736 (struct tui_source_window) <style_changed>: New method.
1737 <m_observable>: New member.
1738
ae2b5380
TT
17392019-07-17 Tom Tromey <tom@tromey.com>
1740
1741 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1742 * tui/tui-win.c (tui_resize_all): Fix typo.
1743
1ce3e844
TT
17442019-07-17 Tom Tromey <tom@tromey.com>
1745
1746 * tui/tui-wingeneral.h (tui_refresh_all): Update.
1747 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1748 (tui_refresh_all): Remove "list" parameter. Use foreach.
1749 * tui/tui-win.c (window_name_completer): Use foreach.
1750 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1751 (update_tab_width): Likewise.
1752 * tui/tui-layout.c (show_layout): Update.
1753 * tui/tui-data.h (class tui_window_iterator): New.
1754 (struct all_tui_windows): New.
1755 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1756
fe3eaf1c
TT
17572019-07-17 Tom Tromey <tom@tromey.com>
1758
1759 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1760 parameter. Don't reference globals.
1761 (tui_reg_command): Update.
1762
368c1354
TT
17632019-07-17 Tom Tromey <tom@tromey.com>
1764
1765 * tui/tui-regs.c (tui_show_registers): Simplify.
1766
e80cd204
TT
17672019-07-17 Tom Tromey <tom@tromey.com>
1768
1769 * tui/tui-regs.c (tui_show_registers): Update.
1770 (tui_show_register_group): Add win_info parameter.
1771
aca2dd16
TT
17722019-07-17 Tom Tromey <tom@tromey.com>
1773
1774 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1775 Rename from tui_display_reg_element_at_line.
1776 (tui_data_window::display_registers_from_line): Update.
1777 * tui/tui-data.h (struct tui_data_window)
1778 <display_reg_element_at_line>: New method.
1779
517e9505
TT
17802019-07-17 Tom Tromey <tom@tromey.com>
1781
1782 * tui/tui-regs.h (tui_display_registers_from)
1783 (tui_display_registers_from_line): Don't declare.
1784 * tui/tui-windata.c (tui_data_window::display_all_data)
1785 (tui_data_window::refresh_all)
1786 (tui_data_window::do_scroll_vertical): Update.
1787 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1788 from tui_display_registers_from.
1789 (tui_display_reg_element_at_line): Update.
1790 (tui_data_window::display_registers_from_line): Rename from
1791 tui_display_registers_from_line.
1792 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1793 display_registers_from_line>: New methods.
1794
f76d8b19
TT
17952019-07-17 Tom Tromey <tom@tromey.com>
1796
1797 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1798 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1799 from tui_erase_data_content.
1800 (tui_data_window::display_all_data)
1801 (tui_data_window::refresh_all)
1802 (tui_data_window::do_scroll_vertical): Update.
1803 * tui/tui-regs.c (tui_show_registers): Update.
1804 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1805 New method.
1806
b4094625
TT
18072019-07-17 Tom Tromey <tom@tromey.com>
1808
1809 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1810 declare.
1811 * tui/tui-windata.c
1812 (tui_data_window::delete_data_content_windows): Rename from
1813 tui_delete_data_content_windows.
1814 (tui_data_window::display_all_data)
1815 (tui_data_window::do_scroll_vertical): Update.
1816 * tui/tui-data.h (struct tui_data_window)
1817 <delete_data_content_windows>: New method.
1818
c223a729
TT
18192019-07-17 Tom Tromey <tom@tromey.com>
1820
1821 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1822 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1823
50daf268
TT
18242019-07-17 Tom Tromey <tom@tromey.com>
1825
1826 * tui/tui-windata.h (tui_display_all_data): Don't declare.
1827 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1828 from tui_display_all_data.
1829 * tui/tui-win.c
1830 (tui_data_window::do_make_visible_with_new_height): Update.
1831 * tui/tui-regs.c (tui_show_registers): Update.
1832 * tui/tui-layout.c (tui_set_layout): Update.
1833 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1834 method.
1835
df5f8cab
TT
18362019-07-17 Tom Tromey <tom@tromey.com>
1837
1838 * tui/tui-windata.h (tui_display_data_from): Don't declare.
1839 * tui/tui-windata.c (tui_display_data_from): Remove.
1840 (tui_data_window::refresh_all): Update.
1841
80cb6c27
TT
18422019-07-17 Tom Tromey <tom@tromey.com>
1843
1844 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1845 * tui/tui-windata.c (tui_display_data_from_line): Remove.
1846 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1847 tui_display_registers_from_line.
1848 * tui/tui-regs.h (tui_display_registers_from_line): Update.
1849 * tui/tui-regs.c (tui_display_registers_from_line): Remove
1850 "force_display" parameter.
1851
baff0c28
TT
18522019-07-17 Tom Tromey <tom@tromey.com>
1853
1854 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1855 declare.
1856 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1857 Rename from tui_first_reg_element_no_inline.
1858 (tui_display_reg_element_at_line)
1859 (tui_display_registers_from_line): Update.
1860 * tui/tui-data.h (struct tui_data_window)
1861 <first_reg_element_no_inline>: New method.
1862
3b23c5f2
TT
18632019-07-17 Tom Tromey <tom@tromey.com>
1864
1865 * tui/tui-windata.c (tui_display_data_from)
1866 (tui_data_window::do_scroll_vertical): Update.
1867 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1868 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1869 Rename from tui_line_from_reg_element_no.
1870 (tui_display_registers_from_line): Update.
1871 * tui/tui-data.h (struct tui_data_window)
1872 <line_from_reg_element_no>: New method.
1873
0b5ec218
TT
18742019-07-17 Tom Tromey <tom@tromey.com>
1875
1876 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1877 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1878 tui_last_regs_line_no.
1879 (tui_display_reg_element_at_line)
1880 (tui_display_registers_from_line): Update.
1881 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1882 method.
1883
0807ab7b
TT
18842019-07-17 Tom Tromey <tom@tromey.com>
1885
1886 PR tui/24722:
1887 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1888 (tui_update_breakpoint_info): Add "being_deleted" parameter.
1889 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1890 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1891 (tui_update_breakpoint_info): Likewise.
1892 * tui/tui-hooks.c (tui_event_create_breakpoint)
1893 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1894 Update.
1895
9ad7fdef
TT
18962019-07-17 Tom Tromey <tom@tromey.com>
1897
1898 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1899
5813316f
TT
19002019-07-17 Tom Tromey <tom@tromey.com>
1901
1902 * tui/tui-winsource.c (tui_update_source_window_as_is)
1903 (tui_update_source_windows_with_addr): Update.
1904 * tui/tui-source.h (tui_set_source_content)
1905 (tui_show_symtab_source): Add "win_info" parameter.
1906 * tui/tui-source.c (tui_set_source_content): Add "win_info"
1907 parameter.
1908 (tui_show_symtab_source): Likewise.
1909
00e264e7
TT
19102019-07-17 Tom Tromey <tom@tromey.com>
1911
1912 * tui/tui-wingeneral.c
1913 (tui_check_and_display_highlight_if_needed): Check can_highlight.
1914
06210ce4
TT
19152019-07-17 Tom Tromey <tom@tromey.com>
1916
1917 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1918 (struct tui_cmd_window) <can_scroll>: New method.
1919 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1920 method.
1921
381befee
TT
19222019-07-17 Tom Tromey <tromey@adacore.com>
1923
1924 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1925 do_field_signed>: Rename. Change type of "value".
1926 * ui-out.c (ui_out::field_signed): Rename from field_int.
1927 Change type of "value".
1928 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
1929 type of "value".
1930 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1931 do_field_int. Change type of "value".
1932 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1933 do_field_int. Change type of "value".
1934 * tracepoint.c (trace_status_mi, tfind_1)
1935 (print_one_static_tracepoint_marker): Update.
1936 * thread.c (print_thread_info_1, print_selected_thread_frame):
1937 Update.
1938 * stack.c (print_frame, print_frame_info): Update.
1939 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1940 Update.
1941 * source.c (print_source_lines_base): Update.
1942 * skip.c (info_skip_command): Update.
1943 * record-btrace.c (btrace_ui_out_decode_error)
1944 (btrace_call_history_src_line): Update.
1945 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1946 Update.
1947 * progspace.c (print_program_space): Update.
1948 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1949 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1950 do_field_int. Change type of "value".
1951 * mi/mi-out.c (mi_ui_out::do_table_begin)
1952 (mi_ui_out::do_table_header): Update.
1953 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
1954 type of "value".
1955 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1956 (mi_cmd_data_list_changed_registers, output_register)
1957 (mi_cmd_data_read_memory, mi_load_progress)
1958 (mi_cmd_trace_frame_collected): Update.
1959 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1960 Update.
1961 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1962 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1963 (mi_cmd_var_list_children, varobj_update_one): Update.
1964 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1965 (mi_cmd_stack_list_args, list_arg_or_local): Update.
1966 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1967 * inferior.c (print_inferior): Update.
1968 * gdb_bfd.c (print_one_bfd): Update.
1969 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1970 Update.
1971 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1972 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1973 do_field_int. Change type of "value".
1974 * cli-out.c (cli_ui_out::do_field_signed): Rename from
1975 do_field_int. Change type of "value".
1976 * breakpoint.c (watchpoint_check, print_breakpoint_location)
1977 (print_one_breakpoint_location, print_it_catch_fork)
1978 (print_one_catch_fork, print_it_catch_vfork)
1979 (print_one_catch_vfork, print_it_catch_solib)
1980 (print_it_catch_exec, print_it_ranged_breakpoint)
1981 (print_mention_watchpoint, print_mention_masked_watchpoint)
1982 (bkpt_print_it, update_static_tracepoint): Update.
1983 * break-catch-throw.c (print_it_exception_catchpoint): Update.
1984 * break-catch-syscall.c (print_it_catch_syscall): Update.
1985 * ada-tasks.c (print_ada_task_info): Update.
1986 * ada-lang.c (print_it_exception, print_mention_exception):
1987 Update.
1988
6b78c3f8
AB
19892019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
1990
1991 PR breakpoints/24541
1992 * gdbarch.c: Regenerate.
1993 * gdbarch.h: Regenerate.
1994 * gdbarch.sh: Adjust return type and parameter types for
1995 'stap_adjust_register'.
1996 (i386_stap_adjust_register): Adjust signature and return new
1997 register name.
1998 * stap-probe.c (stap_parse_register_operand): Adjust use of
1999 'gdbarch_stap_adjust_register'.
2000
d72a9b85
TT
20012019-07-17 Tom Tromey <tromey@adacore.com>
2002
2003 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
2004 declare VEC.
2005 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2006 std::vector.
2007 (struct s390_process_info): Add initializers.
2008 (s390_add_process): Use new.
2009 (s390_linux_nat_target::low_forget_process): Use delete.
2010 (s390_linux_nat_target::low_new_fork)
2011 (s390_linux_nat_target::stopped_by_watchpoint)
2012 (s390_linux_nat_target::low_prepare_to_resume)
2013 (s390_linux_nat_target::insert_watchpoint)
2014 (s390_linux_nat_target::insert_hw_breakpoint)
2015 (s390_linux_nat_target::remove_watchpoint)
2016 (s390_linux_nat_target::remove_hw_breakpoint): Update.
2017
206e6c58
JB
20182019-07-16 John Baldwin <jhb@FreeBSD.org>
2019
2020 * aarch64-fbsd-nat.c: Include regcache.h.
2021 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2022 argument.
2023 (aarch64_fbsd_nat_target::fetch_registers)
2024 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2025 variable.
2026 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2027
cbde90f2
JB
20282019-07-16 John Baldwin <jhb@FreeBSD.org>
2029
2030 * fbsd-nat.c: Include gdbarch.h.
2031
07128006
TT
20322019-07-15 Tom Tromey <tromey@adacore.com>
2033
2034 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2035
1f77b012
TT
20362019-07-15 Tom Tromey <tromey@adacore.com>
2037
2038 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2039 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2040 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2041 * cli-out.c (cli_ui_out::do_field_int): New method.
2042 * ui-out.c (ui_out::field_unsigned): New method.
2043 * symfile.c (generic_load): Use field_unsigned.
2044 (print_transfer_performance): Likewise.
2045 * record-btrace.c (ui_out_field_uint): Remove.
2046 (btrace_call_history_insn_range, btrace_call_history): Use
2047 field_unsigned.
2048 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2049 field_unsigned.
2050 * ui-out.h (class ui_out) <field_unsigned>: New method.
2051 <do_field_unsigned>: Likewise.
2052
33eca680
TT
20532019-07-15 Tom Tromey <tromey@adacore.com>
2054
2055 * mi/mi-main.c (list_available_thread_groups): Use field_string.
2056 * mi/mi-interp.c (mi_memory_changed): Use field_string.
2057 * target.c (flash_erase_command): Use field_string.
2058 * infrun.c (print_signal_received_reason): Use field_string.
2059 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2060 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2061 field_string.
2062 * ada-tasks.c (print_ada_task_info): Use field_string.
2063
ca8d69be
TT
20642019-07-15 Tom Tromey <tromey@adacore.com>
2065
2066 * target.c (flash_erase_command): Use field_core_addr.
2067 * symfile.c (generic_load): Use field_core_addr.
2068 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2069 Use field_core_addr.
2070 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2071 field_core_addr.
2072
0d4e84ed
AB
20732019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2074
2075 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2076 value if its desired type is smaller than a CORE_ADDR and signed.
2077
9a49df9d
AB
20782019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2079
2080 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2081 of changes to field names, and use new is_reference field to
2082 decide if a property is a reference or not.
2083 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2084 field.
2085 (struct dwarf2_property_baton): Update header comment, rename
2086 'referenced_type' to 'property_type' and update comments.
2087 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2088 default property type, store in property baton, update to take
2089 accound of renamed field.
2090 (read_func_scope): Update call to attr_to_dynamic_prop.
2091 (read_array_type): Likewise.
2092 (dwarf2_per_cu_addr_sized_int_type): New function.
2093 (read_subrange_index_type): Move type finding code to
2094 dwarf2_per_cu_addr_sized_int_type.
2095 (read_subrange_type): Update calls to attr_to_dynamic_prop.
2096 (dwarf2_per_cu_addr_type): New function.
2097 (set_die_type): Update calls to attr_to_dynamic_prop.
2098
b86352cf
AB
20992019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2100
2101 * dwarf2read.c (read_subrange_index_type): New function.
2102 (read_subrange_type): Move code into new function and call it.
2103 * gdbtypes.c (create_range_type): Add some asserts.
2104
603490bf
AB
21052019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2106
2107 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2108 update return statements.
2109 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2110 declaration, and update comment to match.
2111 * gdbtypes.c (resolve_dynamic_array): Update call to
2112 dwarf2_evaluate_property to match new return type.
2113
592f9d27
AB
21142019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2115
2116 * valarith.c (value_subscripted_rvalue): Change lowerbound
2117 parameter type from int to LONGEST.
2118 * value.h (value_subscripted_rvalue): Likewise in declaration.
2119
60cfcb20
AB
21202019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2121
2122 * cli/cli-utils.c (info_print_command_completer): New function.
2123 * cli/cli-utils.h: Add 'completer.h' include, and forward
2124 declaration for 'struct cmd_list_element'.
2125 (info_print_command_completer): Declare.
2126 * stack.c (_initialize_stack): Add completer for 'info locals' and
2127 'info args'.
2128 * symtab.c (_initialize_symtab): Add completer for 'info
2129 variables' and 'info functions'.
2130 * NEWS: Mention completion for additional info commands.
2131
b16507e0
AB
21322019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2133
2134 * cli/cli-utils.c (extract_info_print_args): Delete.
2135 (extract_arg_maybe_quoted): Delete.
2136 (info_print_options_defs): New variable.
2137 (make_info_print_options_def_group): New function.
2138 (extract_info_print_options): Define new function.
2139 * cli/cli-utils.h (extract_info_print_args): Delete.
2140 (struct info_print_options): New structure.
2141 (extract_info_print_options): Declare new function.
2142 * stack.c (info_locals_command): Update to use new
2143 extract_info_print_options, also add a header comment.
2144 (info_args_command): Likewise.
2145 * symtab.c (info_variables_command): Likewise.
2146 (info_functions_command): Likewise.
2147
021d8588
AB
21482019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2149
2150 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2151 to extract string arguments.
2152 * common/common-utils.c (extract_string_maybe_quoted): New function.
2153 * common/common-utils.h (extract_string_maybe_quoted): Declare.
2154
b777eb6d
TT
21552019-07-11 Tom Tromey <tromey@adacore.com>
2156
2157 * main.c (get_init_files): Use GDBINIT, not gdbinit.
2158 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2159 * top.h (gdbinit): Don't declare.
2160 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2161 into...
2162 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
2163 * top.c (gdb_init): Don't call init_cli_cmds.
2164 (gdbinit): Remove.
2165 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2166
72ee03ff
TT
21672019-07-11 Tom Tromey <tromey@adacore.com>
2168
2169 * python/py-inferior.c (add_thread_object): Don't use thread_obj
2170 after it has been moved.
2171
00db9531
SM
21722019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2173
2174 * valops.c (value_must_coerce_to_target): Change return type to
2175 bool.
2176 * value.h (value_must_coerce_to_target): Likewise.
2177
f2478a7e
SM
21782019-07-10 Simon Marchi <simon.marchi@efficios.com>
2179
2180 * breakpoint.c (is_hardware_watchpoint): Remove
2181 forward-declaration.
2182 (is_masked_watchpoint): Change return type to bool.
2183 (is_tracepoint): Likewise.
2184 (is_breakpoint): Likewise.
2185 (is_hardware_watchpoint): Likewise.
2186 (is_watchpoint): Likewise.
2187 (is_no_memory_software_watchpoint): Likewise.
2188 (is_catchpoint): Likewise.
2189 (breakpoint_1): Make FILTER parameter's return type bool.
2190 is_masked_watchpoint): Change return type to bool.
2191 (save_breakpoints): Make FILTER parameter's return type bool.
2192 * breakpoint.h (is_breakpoint): Change return type to bool.
2193 (is_watchpoint): Likewise.
2194 (is_catchpoint): Likewise.
2195 (is_tracepoint): Likewise.
2196
0d12e84c
TT
21972019-07-10 Tom Tromey <tom@tromey.com>
2198
2199 * defs.h: Don't include gdbarch.h.
2200 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2201 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2202 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2203 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2204 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2205 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2206 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2207 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2208 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2209 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2210 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2211 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2212 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2213 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2214 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2215 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2216 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2217 record-btrace.c, record.h, regcache-dump.c, regcache.h,
2218 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2219 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2220 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2221 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2222 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2223 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2224 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2225 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2226 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2227
f06f1252
TT
22282019-07-10 Tom Tromey <tromey@adacore.com>
2229
2230 * ada-lang.h (is_ada_exception_catchpoint): Declare.
2231 * breakpoint.c (init_ada_exception_breakpoint): Register as
2232 bp_catchpoint.
2233 (print_one_breakpoint_location, print_one_breakpoint): Use
2234 is_ada_exception_catchpoint.
2235 * ada-lang.c (class ada_catchpoint_location): Pass
2236 bp_loc_software_breakpoint to bp_location constructor.
2237 (is_ada_exception_catchpoint): New function.
2238
7a5d944b
TT
22392019-07-10 Tom Tromey <tromey@adacore.com>
2240
2241 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
2242 VEC.
2243 (struct arm_exidx_entry): New method operator<.
2244 (struct arm_exidx_data) <section_maps>: Change type.
2245 (arm_exidx_data_free): Remove.
2246 (arm_exidx_data_key): Change type. Move lower.
2247 (arm_exidx_new_objfile): Update.
2248 (arm_compare_exidx_entries): Remove.
2249 (arm_find_exidx_entry, _initialize_arm_tdep)
2250
48c66e1d
TT
22512019-07-10 Tom Tromey <tromey@adacore.com>
2252
2253 * solib-spu.c (ocl_program_data_key): Change type.
2254 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2255 Update.
2256
a269fbf1
TT
22572019-07-10 Tom Tromey <tromey@adacore.com>
2258
2259 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
2260 (struct solib_aix_inferior_data) <library_list>: Change type.
2261 (solib_aix_inferior_data_handle): Change type.
2262 (get_solib_aix_inferior_data): Update.
2263 (solib_aix_free_library_list): Remove.
2264 (library_list_start_library): Update.
2265 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2266 return type.
2267 (solib_aix_get_library_list)
2268 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2269 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2270
c294730c
TT
22712019-07-10 Tom Tromey <tromey@adacore.com>
2272
2273 * solib-dsbt.c (struct dsbt_info): Add initializers.
2274 (solib_dsbt_pspace_data): Change type.
2275 (dsbt_pspace_data_cleanup): Remove.
2276 (get_dsbt_info, _initialize_dsbt_solib): Update.
2277
9d52077d
TT
22782019-07-10 Tom Tromey <tromey@adacore.com>
2279
2280 * spu-tdep.c (spu_overlay_data): Change type.
2281 (spu_get_overlay_table, spu_overlay_new_objfile)
2282 (_initialize_spu_tdep): Update.
2283
22a20dca
TT
22842019-07-10 Tom Tromey <tromey@adacore.com>
2285
2286 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2287 destructor.
2288 (dbx_objfile_data_key): Change type and declare later.
2289 (DBX_SYMFILE_INFO): Rewrite.
2290 * dbxread.c (dbx_objfile_data_key): Change type.
2291 (dbx_symfile_init): Update.
2292 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
2293 (coffstab_build_psymtabs, elfstab_build_psymtabs)
2294 (stabsect_build_psymtabs, _initialize_dbxread): Update.
2295
cb60f420
TT
22962019-07-10 Tom Tromey <tromey@adacore.com>
2297
2298 * jit.c (jit_program_space_key): Change type. Move lower.
2299 (get_jit_program_space_data): Update.
2300 (jit_program_space_data_cleanup): Remove.
2301 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2302 Update.
2303 (struct jit_program_space_data): Add initializers.
2304
51df2ae3
TT
23052019-07-10 Tom Tromey <tromey@adacore.com>
2306
2307 * solib-darwin.c (struct darwin_info): Add initializers.
2308 (solib_darwin_pspace_data): Change type.
2309 (darwin_pspace_data_cleanup): Remove.
2310 (get_darwin_info, _initialize_darwin_solib): Update.
2311
18101a35
TT
23122019-07-10 Tom Tromey <tromey@adacore.com>
2313
2314 * remote-sim.c (struct sim_inferior_data): Add initializers,
2315 constructor, and destructor.
2316 (sim_inferior_data_key): Change type. Move lower.
2317 (check_for_duplicate_sim_descriptor): Update.
2318 (get_sim_inferior_data): Use new. Update.
2319 (~sim_inferior_data_cleanup): Rename from
2320 sim_inferior_data_cleanup. Simplify.
2321 (gdbsim_close_inferior, simulator_command)
2322 (sim_command_completer, _initialize_remote_sim): Update.
2323 (next_pid, INITIAL_PID): Move earlier.
2324
05b08ac1
TT
23252019-07-10 Tom Tromey <tromey@adacore.com>
2326
2327 * python/python-internal.h (create_thread_object): Return
2328 gdbpy_ref.
2329 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2330 * python/py-inferior.c (struct threadlist_entry): Add
2331 constructor.
2332 <thread_obj>: Now a gdbpy_ref.
2333 (thread_to_thread_object): Update.
2334 (add_thread_object): Use new.
2335 (delete_thread_object): Use delete.
2336 (infpy_threads): Update.
2337 (py_free_inferior): Update. Construct "inf_obj" after acquiring
2338 GIL.
2339
32372d80
TT
23402019-07-10 Tom Tromey <tromey@adacore.com>
2341
2342 * valops.c (value_cast): Specialize error message for Ada.
2343
5c458ae8
SM
23442019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2345
2346 * breakpoint.c (breakpoint_1): Update doc and parameter names.
2347
4c462cb0
SM
23482019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2349
2350 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2351 bpstat_should_step): Return bool, adjust comments.
2352 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2353 bpstat_should_step): Likewise.
2354
89abbcc2
AH
23552019-07-10 Alan Hayward <alan.hayward@arm.com>
2356
2357 * features/Makefile: Use feature target descriptions for Arm.
2358 * features/arm/arm-core.c: Generate new file.
2359 * features/arm/arm-fpa.c: Likewise.
2360 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2361 * features/arm/arm-m-profile.c: Likewise.
2362 * features/arm/arm-vfpv2.c: Likewise.
2363 * features/arm/arm-vfpv3.c: Likewise.
2364 * features/arm/xscale-iwmmxt.c: Likewise.
2365 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2366
166a82be
AH
23672019-07-10 Alan Hayward <alan.hayward@arm.com>
2368
2369 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2370 ptrace earlier.
2371
9fb4c7e9
AH
23722019-07-10 Alan Hayward <alan.hayward@arm.com>
2373
2374 * features/aarch64-pauth.c: Regenerate.
2375
e2d0f980
SM
23762019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
2377
2378 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2379 bool.
2380 (bpstat_what): Use false instead of 0.
2381
a38118e5
PA
23822019-07-09 Pedro Alves <palves@redhat.com>
2383
2384 * break-catch-throw.c (is_exception_catchpoint): New.
2385 * breakpoint.c (print_one_breakpoint_location): New parameter
2386 'raw_loc'. Handle it. Use
2387 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2388 looking at the breakpoint's type.
2389 (print_one_breakpoint): If handling "maint info breakpoints", also
2390 print locations of exception catchpoints.
2391 * breakpoint.h (is_exception_catchpoint): Declare.
2392
cb1e4e32
PA
23932019-07-09 Pedro Alves <palves@redhat.com>
2394
2395 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2396 "addr" field.
2397 (allocate_location_exception_catchpoint): New.
2398 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2399 (initialize_throw_catchpoint_ops): Install
2400 allocate_location_exception_catchpoint as allocate_location
2401 method.
2402 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2403 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2404 bp_loc_other.
2405 (breakpoint_address_is_meaningful): Delete.
2406 (bl_address_is_meaningful): New.
2407 (breakpoint_locations_match): Adjust comment.
2408 (bp_location_from_bp_type): New, factored out of...
2409 (bp_location::bp_location(breakpoint *)): ... this.
2410 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2411 factored out of...
2412 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
2413 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2414 breakpoint_address_is_meaningful.
2415 (bp_locations_compare): Adjust comment.
2416 (update_global_location_list): Use bl_address_is_meaningful
2417 instead of breakpoint_address_is_meaningful.
2418 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2419 explicit.
2420 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2421 * python/py-breakpoint.c (bppy_get_location): No longer check
2422 whether location is null.
2423
b58a68fe
PA
24242019-07-09 Pedro Alves <palves@redhat.com>
2425
2426 PR c++/15468
2427 * breakpoint.c (print_one_breakpoint_location): Remove
2428 single-location assert.
2429
268a13a5
TT
24302019-07-09 Tom Tromey <tom@tromey.com>
2431
2432 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2433 * configure: Rebuild.
2434 * configure.ac: Change common to gdbsupport.
2435 * gdbsupport: Rename from common.
2436 * acinclude.m4: Change common to gdbsupport.
2437 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2438 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2439 gdbsupport.
2440 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2441 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2442 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2443 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2444 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2445 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2446 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2447 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2448 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2449 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2450 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2451 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2452 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2453 coff-pe-read.c, command.h, compile/compile-c-support.c,
2454 compile/compile-c.h, compile/compile-cplus-symbols.c,
2455 compile/compile-cplus-types.c, compile/compile-cplus.h,
2456 compile/compile-loc2c.c, compile/compile.c, completer.c,
2457 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2458 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2459 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2460 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2461 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2462 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2463 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2464 features/aarch64-core.c, features/aarch64-fpu.c,
2465 features/aarch64-pauth.c, features/aarch64-sve.c,
2466 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2467 features/i386/32bit-core.c, features/i386/32bit-linux.c,
2468 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2469 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2470 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2471 features/i386/64bit-core.c, features/i386/64bit-linux.c,
2472 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2473 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2474 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2475 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2476 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2477 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2478 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2479 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2480 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2481 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2482 go32-nat.c, guile/guile.c, guile/scm-ports.c,
2483 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2484 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2485 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2486 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2487 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2488 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2489 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2490 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2491 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2492 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2493 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2494 minsyms.c, mips-linux-tdep.c, namespace.h,
2495 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2496 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2497 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2498 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2499 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2500 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2501 nat/linux-waitpid.c, nat/mips-linux-watch.c,
2502 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2503 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2504 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2505 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2506 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2507 procfs.c, producer.c, progspace.h, psymtab.h,
2508 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2509 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2510 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2511 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2512 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2513 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2514 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2515 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2516 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2517 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2518 target-memory.c, target.c, target.h, target/waitstatus.c,
2519 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2520 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2521 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2522 unittests/array-view-selftests.c,
2523 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2524 unittests/common-utils-selftests.c,
2525 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2526 unittests/format_pieces-selftests.c,
2527 unittests/function-view-selftests.c,
2528 unittests/lookup_name_info-selftests.c,
2529 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2530 unittests/mkdir-recursive-selftests.c,
2531 unittests/observable-selftests.c,
2532 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2533 unittests/parse-connection-spec-selftests.c,
2534 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2535 unittests/scoped_fd-selftests.c,
2536 unittests/scoped_mmap-selftests.c,
2537 unittests/scoped_restore-selftests.c,
2538 unittests/string_view-selftests.c, unittests/style-selftests.c,
2539 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2540 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2541 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2542 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2543 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2544 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2545
5b0e2db4
AB
25462019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2547
2548 * linespec.c (decode_digits_list_mode): Set explicit_line to a
2549 bool value.
2550 (decode_digits_ordinary): Set explicit_line field in sal.
2551 * symtab.c (skip_prologue_sal): Don't skip prologue for a
2552 symtab_and_line that was set on an explicit line number in
2553 assembler code. Do always update the recorded symtab and line if
2554 we do skip the prologue.
2555
0ba852ab
AB
25562019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2557
2558 * breakpoint.c (set_breakpoint_location_function): Remove
2559 explicit_loc parameter.
2560 (momentary_breakpoint_from_master): Update call to
2561 set_breakpoint_location_function.
2562 (add_location_to_breakpoint): Likewise.
2563
b3a7d171
AB
25642019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2565
2566 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2567 required features based on default bfd type when no specific bfd
2568 is present.
2569
1f6f6e21
PW
25702019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2571
2572 * NEWS: Mention that GDB printf and eval commands can now print
2573 C-style and Ada-style convenience var strings without
2574 calling the inferior.
2575 * printcmd.c (printf_c_string): Locally print GDB internal var
2576 instead of transiting via the inferior.
2577 (printf_wide_c_string): Likewise.
2578
25792019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH
2580
2581 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2582
0598af48
TT
25832019-07-04 Tom Tromey <tom@tromey.com>
2584
2585 PR tui/24724:
2586 * tui/tui-winsource.c (tui_clear_source_content): Update.
2587 (tui_source_window_base::set_is_exec_point_at): Fix comment.
2588 (tui_update_breakpoint_info): Update.
2589 (tui_set_exec_info_content): Update.
2590 * tui/tui-source.c (tui_set_source_content_nil): Update.
2591 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2592 has_break.
2593 * tui/tui-data.h (enum tui_bp_flag): New.
2594 (tui_bp_flags): New enum flags type.
2595 (struct tui_source_element) <break_mode>: Change type. Rename
2596 from has_break.
2597 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2598 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
2599 constants.
2600 * tui/tui-winsource.h: Fix comment.
2601
350fab54
AH
26022019-07-04 Alan Hayward <alan.hayward@arm.com>
2603
2604 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2605 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2606 (store_fpregs_to_thread)
2607 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2608 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2609 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2610 (IWMMXT_REGS_SIZE): Add define.
2611 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2612 (fetch_vfp_regs, store_vfp_regs)
2613 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2614 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2615
f0452268
AH
26162019-07-04 Alan Hayward <alan.hayward@arm.com>
2617
2618 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2619 defines.
2620 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2621 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2622 (ARM_INT_REGISTER_SIZE): ...to this.
2623 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2624 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2625 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2626 (arm_linux_collect_gregset, supply_nwfpe_register)
2627 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2628 defines.
2629 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2630 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2631 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2632 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2633 (arm_return_in_memory, arm_store_return_value)
2634 (arm_get_longjmp_target, arm_register_g_packet_guesses)
2635 (arm_record_ld_st_multiple): Likewise.
2636 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2637 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2638
e935475c
AH
26392019-07-04 Alan Hayward <alan.hayward@arm.com>
2640
2641 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2642 AARCH64_DISPLACED_MODIFIED_INSNS.
2643 * aarch64-tdep.c (struct aarch64_displaced_step_data)
2644 (aarch64_displaced_step_copy_insn): Likewise.
2645 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2646 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2647 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2648 ARM_DISPLACED_MODIFIED_INSNS.
2649 * arm-tdep.c (arm_gdbarch_init): Likewise.
2650 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2651 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2652 (struct arm_displaced_step_closure): Use
2653 ARM_DISPLACED_MODIFIED_INSNS.
2654
df0bb381
AH
26552019-07-04 Alan Hayward <alan.hayward@arm.com>
2656
2657 * features/Makefile: Remove unused xml files.
2658 * features/aarch64.xml: Remove.
2659 * features/i386/amd64-avx-avx512-linux.xml: Remove.
2660 * features/i386/amd64-avx-avx512.xml: Remove.
2661 * features/i386/amd64-avx-linux.xml: Remove.
2662 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2663 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2664 * features/i386/amd64-avx-mpx-linux.xml: Remove.
2665 * features/i386/amd64-avx-mpx.xml: Remove.
2666 * features/i386/amd64-avx.xml: Remove.
2667 * features/i386/amd64-linux.xml: Remove.
2668 * features/i386/amd64-mpx-linux.xml: Remove.
2669 * features/i386/amd64-mpx.xml: Remove.
2670 * features/i386/amd64.xml: Remove.
2671 * features/i386/i386-avx-avx512-linux.xml: Remove.
2672 * features/i386/i386-avx-avx512.xml: Remove.
2673 * features/i386/i386-avx-linux.xml: Remove.
2674 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2675 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2676 * features/i386/i386-avx-mpx-linux.xml: Remove.
2677 * features/i386/i386-avx-mpx.xml: Remove.
2678 * features/i386/i386-avx.xml: Remove.
2679 * features/i386/i386-linux.xml: Remove.
2680 * features/i386/i386-mmx-linux.xml: Remove.
2681 * features/i386/i386-mmx.xml: Remove.
2682 * features/i386/i386-mpx-linux.xml: Remove.
2683 * features/i386/i386-mpx.xml: Remove.
2684 * features/i386/i386.xml: Remove.
2685 * features/i386/x32-avx-avx512-linux.xml: Remove.
2686 * features/i386/x32-avx-linux.xml: Remove.
2687 * features/i386/x32-linux.xml: Remove.
2688
edd6266a
AH
26892019-07-04 Alan Hayward <alan.hayward@arm.com>
2690
2691 * regformats/aarch64.dat: Remove.
2692 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2693 * regformats/i386/amd64-avx-linux.dat: Remove.
2694 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2695 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2696 * regformats/i386/amd64-linux.dat: Remove.
2697 * regformats/i386/amd64-mpx-linux.dat: Remove.
2698 * regformats/i386/amd64.dat: Remove.
2699 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2700 * regformats/i386/i386-avx-linux.dat: Remove.
2701 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2702 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2703 * regformats/i386/i386-linux.dat: Remove.
2704 * regformats/i386/i386-mmx-linux.dat: Remove.
2705 * regformats/i386/i386-mpx-linux.dat: Remove.
2706 * regformats/i386/i386.dat: Remove.
2707 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2708 * regformats/i386/x32-avx-linux.dat: Remove.
2709 * regformats/i386/x32-linux.dat: Remove.
2710
2b40fda7
AH
27112019-07-04 Alan Hayward <alan.hayward@arm.com>
2712
2713 * aarch64-tdep.c: Remove xml self tests.
2714 * amd64-linux-tdep.c: Likewise.
2715 * amd64-tdep.c: Likewise.
2716 * i386-linux-tdep.c: Likewise.
2717 * i386-tdep.c: Likewise.
2718
5f4ba3e7
PA
27192019-07-03 Pedro Alves <palves@redhat.com>
2720
2721 PR cli/24732
2722 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2723 (pipe_cmd_option_defs): New.
2724 (make_pipe_cmd_options_def_group): New.
2725 (pipe_command): Use gdb::option::process_options.
2726 (pipe_command_completer): New function.
2727 (_initialize_cli_cmds): Install completer for "pipe" command.
2728
3d9be6f5
PA
27292019-07-03 Pedro Alves <palves@redhat.com>
2730
2731 * cli/cli-option.c (union option_value) <string>: New field.
2732 (struct option_def_and_value): Add ctor, move ctor, dtor and
2733 use DISABLE_COPY_AND_ASSIGN.
2734 (option_def_and_value::clear_value): New.
2735 (parse_option, save_option_value_in_ctx, get_val_type_str)
2736 (add_setshow_cmds_for_options): Handle var_string.
2737 * cli-option.h (union option_def::var_address) <string>: New
2738 field.
2739 (struct string_option_def): New.
2740 * maint-test-options.c (struct test_options_opts): Add default
2741 ctor and use DISABLE_COPY_AND_ASSIGN.
2742 <string_opt>: New field.
2743 (test_options_opts::~test_options_opts): New.
2744 (test_options_opts::dump): Also dump "-string".
2745 (test_options_option_defs): Install "string.
2746
41fc454c
PA
27472019-07-03 Pedro Alves <palves@redhat.com>
2748
2749 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2750 option_value with a null enumeration.
2751 (complete_options): Save the option values in the context.
2752 (save_option_value_in_ctx): New, factored out from ...
2753 (process_options): ... here.
2754 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2755 of the function.
2756 * maint-test-options.c (test_options_opts::dump): New, factored
2757 out from ...
2758 (maintenance_test_options_command_mode): ... here.
2759 (maintenance_test_options_command_completion_result): Delete.
2760 (maintenance_test_options_command_completion_text): Update
2761 comment.
2762 (maintenance_show_test_options_completion_result): Change
2763 prototype. Just print
2764 maintenance_test_options_command_completion_text.
2765 (save_completion_result): New.
2766 (maintenance_test_options_completer_mode): Pass options context to
2767 complete_options, and then save a dump.
2768 (_initialize_maint_test_options): Use add_cmd to install "maint
2769 show test-options-completion-result".
2770
fdbc9870
PA
27712019-07-03 Pedro Alves <palves@redhat.com>
2772
2773 * NEWS (New commands): Mention "with" and "maint with".
2774 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2775 (with_command, with_command_completer): New.
2776 (pipe_command): Adjust to new repeat_previous
2777 interface.
2778 (_initialize_cli_cmds): Install the "with" command and its "w"
2779 alias.
2780 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2781 declarations.
2782 * cli/cli-setshow.c (parse_cli_var_uinteger)
2783 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2784 argument strings for all var_types.
2785 (get_setshow_command_value_string): New, factored out from ...
2786 (do_show_command): ... this.
2787 * cli/cli-setshow.h: Include <string>.
2788 (get_setshow_command_value_string): Declare.
2789 * command.h (repeat_previous): Now returns const char *. Adjust
2790 comment.
2791 * maint.c: Include "cli/cli-cmds.h".
2792 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2793 (_initialize_maint_cmds): Register the "maintenance with" command.
2794 * top.c (repeat_previous): Move bits from pipe_command here:
2795 Return the saved command line, if any; error out if there's no
2796 command to relaunch.
2797
c6ac8931
PA
27982019-07-03 Pedro Alves <palves@redhat.com>
2799
2800 * NEWS (New commands): Mention "maint set/show test-settings"
2801 instead of "maint test-settings".
2802 * maint-test-settings.c (maintenance_test_settings_list): Delete.
2803 (maintenance_test_settings_set_list): Rename to ...
2804 (maintenance_set_test_settings_list): ... this.
2805 (maintenance_test_settings_show_list): Rename to ...
2806 (maintenance_show_test_settings_list): ... this.
2807 (maintenance_test_settings_cmd): Delete.
2808 (maintenance_test_settings_set_cmd): ...
2809 (maintenance_set_test_settings_cmd): ... this.
2810 (maintenance_test_settings_show_cmd): ...
2811 (maintenance_show_test_settings_cmd): ... this.
2812 (maintenance_test_settings_show_value_cmd):
2813 (maintenance_show_test_settings_value_cmd): ... this.
2814 (_initialize_maint_test_settings): No longer install the "maint
2815 test-settings" prefix command. Rename "maint test-settings set"
2816 to "maint set test-settings", and "maint test-settings show" to
2817 "maint show test-settings". Adjust all subcommands.
2818
d1fcf2fd
PA
28192019-07-03 Pedro Alves <palves@redhat.com>
2820
2821 * maint-test-settings.c: Fix file's intro comment. Replace all
2822 references to "test-options" with references to "test-settings",
2823 in comments.
2824
970f9d09
PA
28252019-07-03 Pedro Alves <palves@redhat.com>
2826
2827 * maint-test-settings.c (maintenance_test_settings_xxx)
2828 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2829 New.
2830 (maintenance_test_settings_enums): Use them.
2831 (maintenance_test_settings_enum): Default to
2832 maintenance_test_settings_xxx.
2833 (_initialize_maint_test_settings): Initialize
2834 MAINTENANCE_TEST_SETTINGS_FILENAME.
2835
f3869b1a
SM
28362019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2837
2838 * breakpoint.h (remove_breakpoints_inf): Change return type to
2839 void, move function documentation here.
2840 * breakpoint.c (remove_breakpoints_inf): Change return type to
2841 void, move function documentation to header.
2842
54d66006
PA
28432019-07-02 Pedro Alves <palves@redhat.com>
2844
2845 * NEWS (Completion improvements): Mention "info threads".
2846 * thread.c (struct info_threads_opts, info_threads_option_defs)
2847 (make_info_threads_options_def_group): New.
2848 (info_threads_command): Use gdb::option::process_options.
2849 (info_threads_command_completer): New.
2850 (_initialize_thread): Use gdb::option::build_help to build the
2851 help text for "info threads".
2852
854f6088
SM
28532019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2854
2855 * defs.h (generic_load): Move from here...
2856 * symfile.h (generic_load): ... to here. Rename name parameter
2857 to args.
2858 * symfile.c (generic_load): Add comment.
2859
54ee4252
TT
28602019-07-01 Tom Tromey <tromey@adacore.com>
2861
2862 * dwarf2read.c
2863 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2864 declaration of without_params. Fix formatting.
2865
65392b3e
TT
28662019-07-01 Tom Tromey <tromey@adacore.com>
2867
2868 * ada-exp.y (find_primitive_type): Update.
2869 * ada-lang.h (ada_lookup_symbol): Update.
2870 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2871 parameter.
2872 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2873
7d7571f0
SDJ
28742019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2875
2876 PR breakpoints/24541
2877 * gdbarch.c: Regenerate.
2878 * gdbarch.h: Regenerate.
2879 * gdbarch.sh: Add 'stap_adjust_register'.
2880 * i386-tdep.c: Include '<unordered_set>'.
2881 (i386_stap_adjust_register): New function.
2882 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2883 * stap-probe.c (stap_parse_register_operand): Call
2884 'gdbarch_stap_adjust_register'.
2885
5af5392a
SDJ
28862019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2887
2888 PR python/24742
2889 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2890 * python/python.c (do_start_initialization): Use 'xmalloc'
2891 instead of 'PyMem_Malloc'.
2892
10d06d82
TT
28932019-06-28 Tom Tromey <tromey@adacore.com>
2894
2895 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2896 for Ada.
2897
1b7f24cd
TT
28982019-06-27 Tom Tromey <tromey@adacore.com>
2899
2900 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
2901 objfile_key.
2902 (arm_find_mapping_symbol, arm_record_special_symbol)
2903 (_initialize_arm_tdep): Update.
2904 (arm_objfile_data_free): Remove.
2905
3d507ff2
TT
29062019-06-27 Tom Tromey <tromey@adacore.com>
2907
2908 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2909 to cp_print_static_field.
2910
762c164d
TT
29112019-06-26 Tom Tromey <tromey@adacore.com>
2912
2913 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2914 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2915 declare.
2916
aa2f9bcf
AH
29172019-06-26 Alan Hayward <alan.hayward@arm.com>
2918
2919 * features/aarch64-core.c (create_feature_aarch64_core):
2920 Regenerate.
2921 * features/aarch64-core.xml: Add cpsr flags.
2922
3426ae57
AH
29232019-06-26 Alan Hayward <alan.hayward@arm.com>
2924
2925 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2926 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2927
4838e44c
SM
29282019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2929
2930 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2931 field.
2932 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2933 use.
2934 (arm_record_special_symbol): Don't insert new symbol in sorted
2935 position, push it at the end.
2936
54cc7474
SM
29372019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2938
2939 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2940 (arm_mapping_symbol_s): Remove.
2941 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2942 (arm_mapping_symbol_vec): New typedef.
2943 (struct arm_per_objfile): Add constructor.
2944 <section_maps>: Change type to
2945 std::unique_ptr<arm_mapping_symbol_vec[]>.
2946 (arm_compare_mapping_symbols): Remove.
2947 (arm_find_mapping_symbol): Adjust to section_maps type change.
2948 (arm_objfile_data_free): Call delete on arm_per_objfile.
2949 (arm_record_special_symbol): Adjust to section_maps type change.
2950 Allocate arm_per_objfile with new.
2951
b65b566c
PW
29522019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2953
2954 * cli/cli-cmds.c (alias_command): Compare the alias prefix
2955 with the command prefix.
2956
c2fc64f5
TT
29572019-06-25 Tom Tromey <tom@tromey.com>
2958
2959 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2960 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2961
fb54fa76
TT
29622019-06-25 Tom Tromey <tom@tromey.com>
2963
2964 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2965 type.
2966 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2967 protected.
2968
f7952c57
TT
29692019-06-25 Tom Tromey <tom@tromey.com>
2970
2971 * tui/tui-winsource.c
2972 (tui_source_window_base::set_is_exec_point_at): Add check against
2973 LOA_ADDRESS.
2974
17568d78
TT
29752019-06-25 Tom Tromey <tom@tromey.com>
2976
2977 * tui/tui-source.c (tui_set_source_content): Don't check before
2978 xfree.
2979 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2980
53e7cdba
TT
29812019-06-25 Tom Tromey <tom@tromey.com>
2982
2983 * tui/tui-winsource.h (tui_update_source_window_as_is)
2984 (tui_alloc_source_buffer, tui_line_is_displayed)
2985 (tui_addr_is_displayed): Change type of win_info.
2986 * tui/tui-winsource.c (tui_update_source_window_as_is)
2987 (tui_clear_source_content, tui_show_source_line)
2988 (tui_show_source_content, tui_source_window_base::refill)
2989 (tui_source_window_base::set_is_exec_point_at)
2990 (tui_source_window_base::set_is_exec_point_at)
2991 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2992 (tui_alloc_source_buffer, tui_line_is_displayed)
2993 (tui_addr_is_displayed): Change type of win_info. Update.
2994 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2995 (tui_source_window_base::do_make_visible_with_new_height):
2996 Update.
2997 * tui/tui-source.c (tui_set_source_content)
2998 (tui_set_source_content_nil)
2999 (tui_source_window::do_scroll_vertical): Update.
3000 * tui/tui-layout.c (show_layout): Update.
3001 * tui/tui-disasm.c (tui_set_disassem_content)
3002 (tui_disasm_window::do_scroll_vertical): Update.
3003 * tui/tui-data.h (tui_win_content): Remove.
3004 (struct tui_gen_win_info) <content, content_size>: Remove.
3005 (struct tui_source_element): Add initializers and destructor.
3006 (union tui_which_element, struct tui_win_element): Remove.
3007 (struct tui_source_window_base) <content>: New field.
3008 (struct tui_data_window): Remove destructor.
3009 (tui_alloc_content, tui_free_win_content)
3010 (tui_free_all_source_wins_content): Don't declare.
3011 * tui/tui-data.c (tui_initialize_static_data): Update.
3012 (init_content_element, tui_alloc_content): Remove.
3013 (~tui_gen_win_info): Update.
3014 (~tui_data_window, tui_free_all_source_wins_content)
3015 (tui_free_win_content, free_content, free_content_elements):
3016 Remove.
3017
7908abbf
TT
30182019-06-25 Tom Tromey <tom@tromey.com>
3019
3020 * tui/tui-winsource.h (tui_clear_source_content)
3021 (tui_erase_source_content, tui_show_source_content): Change type
3022 of win_info.
3023 * tui/tui-winsource.c (tui_clear_source_content)
3024 (tui_erase_source_content, tui_show_source_content): Change type
3025 of win_info.
3026 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3027 * tui/tui-source.h (tui_set_source_content_nil): Change type of
3028 win_info.
3029 * tui/tui-source.c (tui_set_source_content_nil): Change type of
3030 win_info.
3031 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3032
02c28df0
TT
30332019-06-25 Tom Tromey <tom@tromey.com>
3034
3035 * tui/tui-winsource.c (tui_clear_source_content)
3036 (tui_source_window_base::set_is_exec_point_at): Update.
3037 * tui/tui-source.c (tui_set_source_content_nil): Update.
3038 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3039 a bool.
3040 * tui/tui-data.c (init_content_element): Update.
3041
6658b1bf
TT
30422019-06-25 Tom Tromey <tom@tromey.com>
3043
3044 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3045 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3046 * tui/tui-layout.c (init_and_make_win): Update.
3047 * tui/tui.h (enum tui_win_type): Update.
3048 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3049 tui_win_is_auxillary.
3050 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3051 tui_win_is_auxillary.
3052
21e1c91e
TT
30532019-06-25 Tom Tromey <tom@tromey.com>
3054
3055 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3056 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3057 (tui_delete_data_content_windows, tui_display_all_data)
3058 (tui_data_window::do_scroll_vertical, tui_display_data_from):
3059 Update.
3060 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3061 * tui/tui-regs.c (tui_last_regs_line_no)
3062 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3063 (tui_show_registers): Update.
3064 (tui_show_register_group): Return void. Update.
3065 (tui_display_registers_from, tui_display_reg_element_at_line)
3066 (tui_display_registers_from_line, tui_check_register_values):
3067 Update.
3068 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3069 member.
3070 (struct tui_data_window) <regs_content>: Now a std::vector.
3071 <regs_content_count>: Remove.
3072 (tui_add_content_elements, tui_free_data_content): Don't declare.
3073 * tui/tui-data.c (tui_data_window::clear_detail): Update.
3074 (init_content_element): Remove DATA_WIN case. Add assert.
3075 (tui_add_content_elements): Remove.
3076 (tui_data_window): Update.
3077 (tui_free_data_content): Remove.
3078 (free_content_elements): Remove DATA_WIN case.
3079
115ac53b
TT
30802019-06-25 Tom Tromey <tom@tromey.com>
3081
3082 * tui/tui-data.c (tui_data_item_window): Update.
3083 * tui/tui-windata.h (tui_check_data_values): Don't declare.
3084 * tui/tui-windata.c (tui_display_all_data)
3085 (tui_display_data_from_line): Update.
3086 (tui_check_data_values): Remove.
3087 * tui/tui-regs.c (tui_show_register_group)
3088 (tui_display_reg_element_at_line): Update.
3089 * tui/tui-hooks.c (tui_register_changed)
3090 (tui_refresh_frame_and_register_information): Call
3091 tui_check_register_values.
3092 * tui/tui-data.h (struct tui_data_window) <data_content,
3093 data_content_count, data_type>: Remove.
3094 (enum tui_data_type): Remove.
3095
3096 * tui/tui-data.c (tui_data_window::clear_detail)
3097 (~tui_data_window): Update.
3098
eaf9738b
TT
30992019-06-25 Tom Tromey <tom@tromey.com>
3100
3101 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3102 declare.
3103 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3104 Rename from tui_first_data_item_displayed. Update.
3105 (tui_data_window::refresh_all)
3106 (tui_data_window::do_scroll_vertical): Update.
3107 * tui/tui-data.h (struct tui_data_window)
3108 <first_data_item_displayed>: Declare new method.
3109
31ca4723
TT
31102019-06-25 Tom Tromey <tom@tromey.com>
3111
3112 * tui/tui-data.h (tui_init_generic_part): Don't declare.
3113 * tui/tui-data.c (tui_init_generic_part): Remove, moving
3114 contents...
3115 (tui_initialize_static_data): ...here.
3116
41bcff7f
TT
31172019-06-25 Tom Tromey <tom@tromey.com>
3118
3119 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3120 (tui_display_registers_from, tui_check_register_values): Update.
3121 (tui_display_register): Remove win_info parameter; update.
3122 (tui_get_register): Change type of parameters.
3123 * tui/tui-data.h (struct tui_data_element): Remove.
3124 (union tui_which_element) <data>: Remove.
3125 <data_window>: Change type.
3126 (struct tui_data_item_window): New.
3127 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3128 case. Add assert.
3129 (~tui_data_item_window): New destructor.
3130 (free_content_elements): Remove DATA_ITEM_WIN case.
3131
d2802c33
TT
31322019-06-25 Tom Tromey <tom@tromey.com>
3133
3134 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3135 Remove.
3136
dd835f8b
TT
31372019-06-25 Tom Tromey <tom@tromey.com>
3138
3139 * tui/tui-data.h (struct tui_command_element): Remove.
3140 (union tui_which_element) <command>: Remove.
3141 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
3142 assert.
3143 (free_content_elements): Remove CMD_WIN case.
3144
bd7db367
TT
31452019-06-25 Tom Tromey <tom@tromey.com>
3146
3147 * tui/tui-layout.c (tui_set_layout): Update.
3148 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3149 * tui/tui-data.c (layout_def): Update.
3150
3add462f
TT
31512019-06-25 Tom Tromey <tom@tromey.com>
3152
3153 * tui/tui-wingeneral.c (tui_refresh_all): Update.
3154 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3155 (tui_source_window_base::set_new_height): Update.
3156 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3157 Update.
3158 (tui_set_locator_fullname, tui_set_locator_info)
3159 (tui_show_frame_info): Update.
3160 * tui/tui-source.c (tui_set_source_content)
3161 (tui_source_is_displayed): Update.
3162 * tui/tui-layout.c (show_source_disasm_command, show_data)
3163 (show_source_or_disasm_and_command): Update.
3164 * tui/tui-disasm.c (tui_set_disassem_content)
3165 (tui_get_begin_asm_address): Update.
3166 * tui/tui-data.h (struct tui_locator_element): Remove.
3167 (union tui_which_element) <locator>: Remove.
3168 (struct tui_locator_window): New.
3169 (tui_locator_win_info_ptr): Change return type.
3170 * tui/tui-data.c (_locator): Change type.
3171 (tui_locator_win_info_ptr): Change return type.
3172 (init_content_element): Remove LOCATOR_WIN case. Add assert.
3173 (tui_alloc_content): Add assert.
3174
489e9d8b
TT
31752019-06-25 Tom Tromey <tom@tromey.com>
3176
3177 * tui/tui-winsource.c
3178 (tui_exec_info_window::maybe_allocate_content): New method.
3179 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3180 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3181 (make_source_or_disasm_window): Add cast.
3182 * tui/tui-data.h (union tui_which_element) <simple_string>:
3183 Remove.
3184 (struct tui_source_info): New.
3185 (struct tui_source_window_base) <execution_info>: Change type.
3186 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3187 case, and add assert.
3188 (tui_alloc_content): Add assert.
3189
c3fabb7d
TT
31902019-06-25 Tom Tromey <tom@tromey.com>
3191
3192 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3193 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3194 * tui/tui-data.c (tui_alloc_win_info): Remove.
3195
bbc228ee
TT
31962019-06-25 Tom Tromey <tom@tromey.com>
3197
3198 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3199 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3200 can_highlight.
3201
5fcee43a
TT
32022019-06-25 Tom Tromey <tom@tromey.com>
3203
3204 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3205 make_visible_with_new_height method.
3206 (tui_win_info::make_visible_with_new_height): New method.
3207 (tui_source_window_base::do_make_visible_with_new_height)
3208 (tui_data_window::do_make_visible_with_new_height)
3209 (tui_cmd_window::do_make_visible_with_new_height): New methods.
3210 (make_visible_with_new_height): Remove.
3211 (tui_resize_all, tui_adjust_win_heights): Use
3212 make_visible_with_new_height method.
3213 * tui/tui-data.h (struct tui_win_info)
3214 <do_make_visible_with_new_height, make_visible_with_new_height>:
3215 New methods.
3216 (struct tui_source_window_base, struct tui_data_window)
3217 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3218 methods.
3219
d83f1fe6
TT
32202019-06-25 Tom Tromey <tom@tromey.com>
3221
3222 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3223 method.
3224 (update_tab_width): Call update_tab_width method.
3225 * tui/tui-data.h (struct tui_win_info)
3226 (struct tui_source_window_base) <update_tab_width>: New methods.
3227
17374de4
TT
32282019-06-25 Tom Tromey <tom@tromey.com>
3229
3230 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3231 parameter.
3232 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3233 parameter.
3234 (tui_gen_win_info::make_visible): Update.
3235 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3236 parameter.
3237 * tui/tui-data.h (enum tui_box): New enum.
3238 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3239
f936bca2
TT
32402019-06-25 Tom Tromey <tom@tromey.com>
3241
3242 * tui/tui-layout.c (make_source_or_disasm_window): Always use
3243 init_and_make_win for EXEC_INFO_WIN.
3244 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3245 longer inline.
3246 (struct tui_win_info) <~tui_win_info>: Inline.
3247 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3248 Don't declare.
3249 * tui/tui-data.c (source_win, disasm_win): Remove globals.
3250 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3251 Remove.
3252 (tui_initialize_static_data): Update.
3253 (~tui_gen_win_info): Handle more cleanup here.
3254 (~tui_source_window_base): Delete "execution_info".
3255 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3256
d6ba6a11
TT
32572019-06-25 Tom Tromey <tom@tromey.com>
3258
3259 * tui/tui-layout.c (make_command_window): Don't set
3260 can_highlight.
3261 (show_source_disasm_command): Call the reset method.
3262 (show_data): Don't set can_highlight. Call the reset method.
3263 (tui_gen_win_info::reset): Rename from init_gen_win_info
3264 (init_and_make_win): Simplify. Return tui_gen_win_info.
3265 (show_source_or_disasm_and_command): Call the reset method.
3266 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3267 (struct tui_cmd_window): Set can_highlight.
3268
48a3bd16
TT
32692019-06-25 Tom Tromey <tom@tromey.com>
3270
3271 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3272 from make_visible.
3273 (tui_make_visible, tui_make_invisible): Rewrite.
3274 (tui_win_info::make_visible): Remove.
3275 (tui_source_window_base::make_visible): Update.
3276 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3277 method. Moved from...
3278 (struct tui_win_info) <make_visible>: ...here.
3279
c3bd716f
TT
32802019-06-25 Tom Tromey <tom@tromey.com>
3281
3282 * tui/tui-winsource.c
3283 (tui_source_window_base::do_scroll_horizontal): Remove direction
3284 parameter.
3285 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3286 direction parameter.
3287 * tui/tui-win.c (tui_win_info::forward_scroll)
3288 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3289 (tui_win_info::right_scroll): Update.
3290 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3291 direction parameter.
3292 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3293 direction parameter.
3294 * tui/tui-data.h (enum tui_scroll_direction): Remove.
3295 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3296 Remove direction parameter.
3297 (struct tui_source_window_base, struct tui_source_window)
3298 (struct tui_disasm_window, struct tui_data_window)
3299 (struct tui_cmd_window): Update.
3300
21c32dca
TT
33012019-06-25 Tom Tromey <tom@tromey.com>
3302
3303 * tui/tui-winsource.h (tui_set_exec_info_content)
3304 (tui_show_exec_info_content, tui_erase_exec_info_content)
3305 (tui_clear_exec_info_content, tui_update_exec_info): Change
3306 argument to tui_source_window_base.
3307 * tui/tui-winsource.c (tui_set_exec_info_content)
3308 (tui_show_exec_info_content, tui_erase_exec_info_content)
3309 (tui_clear_exec_info_content, tui_update_exec_info): Change
3310 argument to tui_source_window_base.
3311
73fbdc65
TT
33122019-06-25 Tom Tromey <tom@tromey.com>
3313
3314 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3315 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3316
33325343
TT
33172019-06-25 Tom Tromey <tom@tromey.com>
3318
3319 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3320 check.
3321
29d2c474
TT
33222019-06-25 Tom Tromey <tom@tromey.com>
3323
3324 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3325 type to void.
3326 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3327 type to void.
3328 * tui/tui-source.c (tui_set_source_content): Update.
3329 * tui/tui-disasm.c (tui_set_disassem_content): Update.
3330
152f3f4b
TT
33312019-06-25 Tom Tromey <tom@tromey.com>
3332
3333 * tui/tui-win.c (window_name_completer, tui_set_focus)
3334 (tui_all_windows_info): Use name method.
3335 * tui/tui-data.h (struct tui_gen_win_info)
3336 (struct tui_source_window, struct tui_disasm_window)
3337 (struct tui_data_window, struct tui_cmd_window) <name>: New
3338 method.
3339 (tui_win_name): Don't declare.
3340 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3341 (tui_win_name): Remove.
3342
be4da588
TT
33432019-06-25 Tom Tromey <tom@tromey.com>
3344
3345 * tui/tui-winsource.h (tui_update_source_window)
3346 (tui_update_source_window_as_is): Change parameter type.
3347 * tui/tui-winsource.c (tui_update_source_window): Change win_info
3348 to be a tui_source_window_base.
3349 (tui_update_source_window_as_is): Likewise.
3350 * tui/tui-win.c (make_visible_with_new_height): Update.
3351
5b81daba
TT
33522019-06-25 Tom Tromey <tom@tromey.com>
3353
3354 * tui/tui-winsource.c (tui_erase_source_content)
3355 (tui_show_source_content, tui_show_exec_info_content)
3356 (tui_erase_exec_info_content): Use refresh_window method.
3357 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3358 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3359 from tui_refresh_win.
3360 (tui_data_window::refresh_window): New method.
3361 (tui_win_info::refresh, tui_source_window_base::refresh)
3362 (tui_refresh_all): Use refresh_window method.
3363 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3364 method.
3365 * tui/tui-regs.c (tui_display_register): Call refresh_window
3366 method.
3367 * tui/tui-layout.c (show_source_disasm_command)
3368 (show_source_or_disasm_and_command): Call refresh_window method.
3369 * tui/tui-data.h (struct tui_gen_win_info)
3370 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3371 New method.
3372
cb2ce893
TT
33732019-06-25 Tom Tromey <tom@tromey.com>
3374
3375 * tui/tui.c (tui_rl_other_window, tui_enable)
3376 (tui_is_window_visible, tui_get_command_dimension): Update.
3377 * tui/tui-winsource.c (tui_update_source_window_as_is)
3378 (tui_clear_source_content, tui_erase_source_content)
3379 (tui_show_source_line, tui_source_window_base::refill)
3380 (tui_source_window_base::do_scroll_horizontal)
3381 (tui_source_window_base::set_is_exec_point_at)
3382 (tui_update_breakpoint_info, tui_set_exec_info_content)
3383 (tui_alloc_source_buffer, tui_line_is_displayed)
3384 (tui_addr_is_displayed): Update.
3385 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3386 (tui_check_and_display_highlight_if_needed)
3387 (tui_win_info::make_visible, tui_win_info::refresh)
3388 (tui_refresh_all): Update.
3389 * tui/tui-windata.c (tui_first_data_item_displayed)
3390 (tui_delete_data_content_windows, tui_erase_data_content)
3391 (tui_display_all_data, tui_data_window::refresh_all)
3392 (tui_check_data_values): Update.
3393 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3394 (tui_set_win_focus_to, tui_win_info::forward_scroll)
3395 (tui_win_info::backward_scroll, tui_refresh_all_win)
3396 (tui_resize_all, tui_set_focus, tui_all_windows_info)
3397 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3398 (tui_source_window_base::set_new_height)
3399 (tui_data_window::set_new_height)
3400 (make_invisible_and_set_new_height)
3401 (make_visible_with_new_height, new_height_ok)
3402 (parse_scrolling_args): Update.
3403 * tui/tui-stack.c (tui_show_frame_info): Update.
3404 * tui/tui-source.c (tui_set_source_content)
3405 (tui_set_source_content_nil, tui_source_is_displayed)
3406 (tui_source_window::do_scroll_vertical): Update.
3407 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3408 (tui_display_registers_from, tui_display_reg_element_at_line)
3409 (tui_check_register_values, tui_reg_command): Update.
3410 * tui/tui-layout.c (tui_default_win_height)
3411 (show_source_disasm_command, show_data, init_and_make_win)
3412 (show_source_or_disasm_and_command): Update.
3413 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3414 (tui_redisplay_readline, tui_mld_flush)
3415 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3416 (tui_getc): Update.
3417 * tui/tui-disasm.c (tui_set_disassem_content)
3418 (tui_disasm_window::do_scroll_vertical): Update.
3419 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3420 Now virtual.
3421 (struct tui_win_info): Derive from tui_gen_win_info.
3422 <~tui_win_info>: Mark as override.
3423 <generic>: Remove member.
3424 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3425 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3426 (~tui_data_window, ~tui_win_info)
3427 (tui_free_all_source_wins_content): Update.
3428 * tui/tui-command.c (tui_refresh_cmd_win): Update.
3429
ab313b35
TT
34302019-06-25 Tom Tromey <tom@tromey.com>
3431
3432 * tui/tui-layout.c (init_and_make_win): Use new.
3433 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3434 destructor, initializers.
3435 (tui_alloc_generic_win_info): Don't declare.
3436 * tui/tui-data.c (_locator): Add argument to constructor.
3437 (source_win, disasm_win): New globals.
3438 (exec_info): Remove.
3439 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3440 Update.
3441 (tui_alloc_generic_win_info): Remove.
3442 (init_content_element): Use new.
3443 (tui_win_info::tui_win_info): Update.
3444 (free_content_elements) <case DATA_WIN>: Use delete.
3445
dc2c33e4
TT
34462019-06-25 Tom Tromey <tom@tromey.com>
3447
3448 * tui/tui-wingeneral.c (tui_refresh_win): Update.
3449 * tui/tui-windata.c (tui_first_data_item_displayed)
3450 (tui_delete_data_content_windows): Update.
3451 * tui/tui-win.c (tui_data_window::set_new_height): Update.
3452 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3453 (tui_display_registers_from, tui_check_register_values): Update.
3454 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3455 pointer.
3456 * tui/tui-data.c (init_content_element): Update. Allocate the new
3457 window.
3458 (tui_free_data_content): Update.
3459 (free_content_elements) <case DATA_WIN>: Free the window.
3460
214a5cbe
TT
34612019-06-25 Tom Tromey <tom@tromey.com>
3462
3463 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3464 Update.
3465 * tui/tui-layout.c (make_command_window)
3466 (show_source_disasm_command, show_data, init_and_make_win)
3467 (show_source_or_disasm_and_command): Update.
3468 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3469 method.
3470 <can_highight, is_highlighted>: Now bool.
3471 (tui_set_win_highlight): Don't declare.
3472 * tui/tui-data.c (tui_set_win_highlight): Remove.
3473
8e2daf15
TT
34742019-06-25 Tom Tromey <tom@tromey.com>
3475
3476 * tui/tui-wingeneral.c (make_visible): Remove check of window
3477 type.
3478
8903bd8a
TT
34792019-06-25 Tom Tromey <tom@tromey.com>
3480
3481 * tui/tui-win.c (tui_win_info::max_height)
3482 (tui_cmd_window::max_height): New methods.
3483 (new_height_ok): Call max_height.
3484 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3485 <max_height>: New method.
3486
3f02ce1e
TT
34872019-06-25 Tom Tromey <tom@tromey.com>
3488
3489 * tui/tui-win.c (tui_source_window_base::set_new_height)
3490 (tui_data_window::set_new_height): New methods.
3491 (make_invisible_and_set_new_height): Call set_new_height method.
3492 * tui/tui-data.h (struct tui_win_info)
3493 (struct tui_source_window_base, struct tui_data_window)
3494 <set_new_height>: New method.
3495
1825f487
TT
34962019-06-25 Tom Tromey <tom@tromey.com>
3497
3498 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3499 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3500 tui_refresh_data_win.
3501 * tui/tui-win.c (tui_source_window_base::refresh_all): New
3502 method.
3503 (tui_refresh_all_win): Call the refresh_all method.
3504 (tui_set_focus): Likewise.
3505 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3506 (struct tui_source_window_base, struct tui_data_window) <refresh>:
3507 Likewise.
3508
ad54d15b
TT
35092019-06-25 Tom Tromey <tom@tromey.com>
3510
3511 * tui/tui-winsource.h (tui_refill_source_window)
3512 (tui_set_is_exec_point_at): Don't declare.
3513 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3514 (tui_source_window_base::refill): Rename from
3515 tui_refill_source_window.
3516 (tui_source_window_base::do_scroll_horizontal): Update.
3517 (tui_source_window_base::set_is_exec_point_at): Rename from
3518 tui_set_is_exec_point_at.
3519 (tui_update_all_breakpoint_info): Update.
3520 * tui/tui-stack.c (tui_show_frame_info): Update.
3521 * tui/tui-layout.c (show_data): Add cast.
3522 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3523 * tui/tui-data.h (struct tui_source_window_base) <refill,
3524 set_is_exec_point_at>: New methods.
3525 (tui_source_windows, tui_add_to_source_windows): Update types.
3526 (tui_add_to_source_windows): Remove redundant declaration.
3527 * tui/tui-data.c (source_windows): Store tui_source_window_base.
3528 (tui_source_windows): Change return type.
3529 (tui_clear_source_windows_detail): Update.
3530 (tui_add_to_source_windows): Change type of parameter.
3531 (tui_free_all_source_wins_content): Update.
3532
2042b506
TT
35332019-06-25 Tom Tromey <tom@tromey.com>
3534
3535 * tui/tui-wingeneral.c (tui_win_info::refresh)
3536 (tui_source_window_base::refresh): New methods.
3537 (tui_refresh_all): Call the refresh method.
3538 * tui/tui-data.h (struct tui_win_info)
3539 (struct tui_source_window_base) <refresh>: New method.
3540
56122977
TT
35412019-06-25 Tom Tromey <tom@tromey.com>
3542
3543 * tui/tui.h (tui_is_window_visible): Return bool.
3544 * tui/tui.c (tui_is_window_visible): Return bool.
3545 * tui/tui-wingeneral.c (tui_make_window, make_visible)
3546 (tui_make_visible, tui_make_invisible)
3547 (tui_win_info::make_visible)
3548 (tui_source_window_base::make_visible, make_all_visible)
3549 (tui_make_all_visible, tui_make_all_invisible): Update.
3550 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3551 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3552 bool.
3553 (struct tui_win_info, struct tui_source_window_base)
3554 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3555 * tui/tui-data.c (tui_init_generic_part): Update.
3556
cda37efb
TT
35572019-06-25 Tom Tromey <tom@tromey.com>
3558
3559 * tui/tui-wingeneral.c (tui_win_info::make_visible)
3560 (tui_source_window_base::make_visible): New methods.
3561 (make_all_visible): Make method call.
3562 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3563 (struct tui_source_window_base, struct tui_cmd_window): Override
3564 make_visible.
3565 (tui_win_is_source_type): Don't declare.
3566 * tui/tui-data.c (tui_win_is_source_type): Remove.
3567
6a0ee02c
TT
35682019-06-25 Tom Tromey <tom@tromey.com>
3569
3570 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3571 NULL check.
3572
63901aec
TT
35732019-06-25 Tom Tromey <tom@tromey.com>
3574
3575 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3576 Inline constructor. Add initializers for members.
3577 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3578 constructors; now inline in class.
3579
ceb13a13
TT
35802019-06-25 Tom Tromey <tom@tromey.com>
3581
3582 * tui/tui-regs.c (tui_show_registers): Update.
3583 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3584 bool.
3585 * tui/tui-data.c (tui_data_window::clear_detail)
3586 (tui_data_window): Update.
3587
238eb706
TT
35882019-06-25 Tom Tromey <tom@tromey.com>
3589
3590 * tui/tui-windata.c (tui_display_all_data)
3591 (tui_display_data_from_line, tui_display_data_from)
3592 (tui_check_data_values, tui_data_window::do_scroll_vertical):
3593 Update.
3594 * tui/tui-regs.c (tui_last_regs_line_no)
3595 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3596 (tui_show_registers, tui_show_register_group)
3597 (tui_display_registers_from, tui_display_reg_element_at_line)
3598 (tui_display_registers_from_line, tui_check_register_values)
3599 (tui_reg_next, tui_reg_prev): Update.
3600 * tui/tui-layout.c (tui_set_layout, show_data): Update.
3601 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
3602 tui_data_window.
3603 (struct tui_win_info) <detail>: Remove. Add new fields from
3604 tui_data_info.
3605 (TUI_DATA_WIN): Add cast.
3606 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3607 (~tui_data_window): Simplify.
3608
81491aa0
TT
36092019-06-25 Tom Tromey <tom@tromey.com>
3610
3611 * tui/tui-layout.c (show_source_disasm_command)
3612 (show_source_or_disasm_and_command): Update.
3613 * tui/tui-io.c (update_cmdwin_start_line)
3614 (tui_redisplay_readline): Update.
3615 * tui/tui-data.h (struct tui_command_info): Remove.
3616 (struct tui_win_info) <detail>: Remove command_info member.
3617 (struct tui_data_window) <start_line>: New member, from
3618 tui_command_info.
3619 (TUI_CMD_WIN): Add casts.
3620
e6e41501
TT
36212019-06-25 Tom Tromey <tom@tromey.com>
3622
3623 * tui/tui-winsource.c (tui_update_source_window)
3624 (tui_refill_source_window)
3625 (tui_source_window_base::do_scroll_horizontal)
3626 (tui_update_breakpoint_info, tui_set_exec_info_content)
3627 (tui_show_exec_info_content, tui_erase_exec_info_content)
3628 (tui_clear_exec_info_content): Update.
3629 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3630 Update.
3631 * tui/tui-win.c (make_invisible_and_set_new_height)
3632 (make_visible_with_new_height): Update.
3633 * tui/tui-source.c (tui_set_source_content)
3634 (tui_show_symtab_source): Update.
3635 * tui/tui-layout.c (extract_display_start_addr)
3636 (show_source_disasm_command, show_data)
3637 (make_source_or_disasm_window)
3638 (show_source_or_disasm_and_command): Update.
3639 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3640 (tui_disasm_window::do_scroll_vertical): Remove shadowing
3641 "gdbarch".
3642 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
3643 to tui_source_window_base.
3644 (struct tui_win_info) <detail>: Remove source_info member.
3645 (struct tui_source_window_base) <has_locator>: Inline.
3646 Move contents from tui_source_info; rename has_locator member to
3647 m_has_locator.
3648 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3649 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3650 header file.
3651 (tui_source_window_base::clear_detail, ~tui_source_window_base):
3652 Simplify.
3653 (tui_free_all_source_wins_content): Cast to
3654 tui_source_window_base.
3655
44f0e208
TT
36562019-06-25 Tom Tromey <tom@tromey.com>
3657
3658 * tui/tui-win.c (make_invisible_and_set_new_height)
3659 (make_visible_with_new_height): Call has_locator method.
3660 * tui/tui-layout.c (show_source_disasm_command, show_data)
3661 (show_source_or_disasm_and_command): Update for bool change.
3662 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3663 (tui_win_info) <has_locator>: New method.
3664 (struct tui_source_window_base) <has_locator>: New method.
3665 (tui_win_has_locator): Don't declare.
3666 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3667 from tui_win_has_locator.
3668 (tui_source_window_base): Use false, not FALSE.
3669
7778b912
TT
36702019-06-25 Tom Tromey <tom@tromey.com>
3671
3672 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3673 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3674 clear_detail method directly.
3675 (tui_clear_win_detail): Remove.
3676
f83d391c
TT
36772019-06-25 Tom Tromey <tom@tromey.com>
3678
3679 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3680 "this", not TUI_DISASM_WIN.
3681
13446e05
TT
36822019-06-25 Tom Tromey <tom@tromey.com>
3683
3684 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
3685 declare.
3686 * tui/tui-winsource.c
3687 (tui_source_window_base::do_scroll_horizontal): Rename from
3688 tui_horizontal_source_scroll.
3689 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3690 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3691 from tui_vertical_data_scroll.
3692 * tui/tui-win.h (tui_scroll): Don't declare.
3693 * tui/tui-win.c (tui_win_info::forward_scroll)
3694 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3695 (tui_win_info::right_scroll): Rename and update.
3696 (tui_scroll_forward_command, tui_scroll_backward_command)
3697 (tui_scroll_left_command, tui_scroll_right_command): Update.
3698 (tui_scroll): Remove.
3699 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3700 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3701 from tui_vertical_source_scroll.
3702 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3703 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3704 from tui_vertical_disassem_scroll.
3705 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3706 do_scroll_horizontal>: New methods.
3707 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3708 Likewise.
3709 (struct tui_source_window_base): Add do_scroll_horizontal.
3710 (struct tui_source_window, struct tui_disasm_window): Add
3711 do_scroll_vertical.
3712 (struct tui_data_window, struct tui_cmd_window): Add
3713 do_scroll_horizontal and do_scroll_vertical.
3714 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3715
5cf82909
TT
37162019-06-25 Tom Tromey <tom@tromey.com>
3717
3718 * tui/tui-data.h (struct tui_source_window_base): New struct.
3719 (struct tui_source_window): Derive from tui_source_window_base.
3720 (struct tui_disasm_window): New struct.
3721 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3722 from tui_source_window::clear_detail.
3723 (tui_source_window_base): Rename from tui_source_window.
3724 (~tui_source_window_base): Rename from ~tui_source_window.
3725 (tui_alloc_win_info): Create a tui_disasm_window.
3726
ee1d42d6
TT
37272019-06-25 Tom Tromey <tom@tromey.com>
3728
3729 * tui/tui-data.h (struct tui_source_window)
3730 (struct tui_data_window): Declare destructors.
3731 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3732 destructors.
3733 (tui_win_info): Simplify.
3734
b4eb2452
TT
37352019-06-25 Tom Tromey <tom@tromey.com>
3736
3737 * tui/tui-winsource.c (tui_display_main)
3738 (tui_update_source_windows_with_addr)
3739 (tui_update_all_breakpoint_info): Update.
3740 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3741 (new_height_ok, parse_scrolling_args): Update.
3742 * tui/tui-stack.c (tui_show_frame_info): Update.
3743 * tui/tui-data.h (struct tui_list): Remove.
3744 (tui_source_windows): Return a reference to a std::vector.
3745 * tui/tui-data.c (source_windows): Now a std::vector.
3746 (tui_source_windows): Change return type.
3747 (tui_clear_source_windows): Rewrite.
3748 (tui_clear_source_windows_detail, tui_add_to_source_windows)
3749 (tui_free_all_source_wins_content): Rewrite.
3750
8761a91b
TT
37512019-06-25 Tom Tromey <tom@tromey.com>
3752
3753 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3754 (struct tui_data_window, struct tui_cmd_window): Declare
3755 clear_detail method.
3756 * tui/tui-data.c (tui_source_window::clear_detail)
3757 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3758 methods.
3759 (tui_clear_win_detail): Simplify.
3760
0ed69eda
TT
37612019-06-25 Tom Tromey <tom@tromey.com>
3762
3763 * tui/tui-layout.c (make_source_window, make_disasm_window)
3764 (make_source_or_disasm_window): Remove win_info_ptr parameter.
3765 Return the new window.
3766 (show_source_disasm_command, show_data)
3767 (show_source_or_disasm_and_command): Update.
3768
82432e10
TT
37692019-06-25 Tom Tromey <tom@tromey.com>
3770
3771 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3772 parameter. Return the new window.
3773 (show_source_disasm_command): Update and remove NULL check.
3774 (show_source_or_disasm_and_command): Update.
3775
ec328aa5
TT
37762019-06-25 Tom Tromey <tom@tromey.com>
3777
3778 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3779
33b906ab
TT
37802019-06-25 Tom Tromey <tom@tromey.com>
3781
3782 * tui/tui-data.h (struct tui_win_info): Make constructor
3783 protected. Make destructor virtual. Add initializers.
3784 (tui_source_window, tui_data_window, tui_cmd_window): New
3785 classes.
3786 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
3787 constructor. Add "type" parameter.
3788 (tui_source_window, tui_data_window, tui_cmd_window): New
3789 constructors.
3790 (tui_alloc_win_info): Instantiate the appropriate subclass.
3791
e7e11af4
TT
37922019-06-25 Tom Tromey <tom@tromey.com>
3793
3794 * tui/tui-win.c (tui_resize_all): Use delete.
3795 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3796 destructor.
3797 (tui_free_window): Don't declare.
3798 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3799 Update.
3800
6792b55e
TT
38012019-06-25 Tom Tromey <tom@tromey.com>
3802
3803 * tui/tui-data.h (struct tui_win_info): Add constructor.
3804 * tui/tui-data.c (tui_alloc_win_info): Use new.
3805 (tui_free_window): Use delete.
3806
f95675e1
TT
38072019-06-22 Tom Tromey <tom@tromey.com>
3808
3809 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3810 declare.
3811 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3812
5bff081c
TT
38132019-06-22 Tom Tromey <tom@tromey.com>
3814
3815 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3816 declare.
3817 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3818
47e3f474
TV
38192019-06-22 Tom de Vries <tdevries@suse.de>
3820
3821 * dwarf2read.c (create_addrmap_from_aranges)
3822 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3823 instead of '%zu'.
3824
fd5866f6
SM
38252019-06-21 Simon Marchi <simon.marchi@efficios.com>
3826
3827 * dwarf2read.h (dwarf2_section_info_def): Remove.
3828 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3829 * dwarf2read.c (struct dwo_sections) <types>: Change type to
3830 std::vector<dwarf2_section_info>.
3831 (struct dwo_file) <~dwo_file>: Remove.
3832 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3833 types field.
3834 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3835 (dwarf2_read_debug_names): Likewise.
3836 (create_debug_types_hash_table): Change parameter type to
3837 array_view, adjust code accordingly.
3838 (dwarf2_locate_dwo_sections): Adjust to std::vector.
3839 (partial_die_info::fixup): Likewise.
3840 (determine_prefix): Likewise.
3841 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3842
fb1eb2f9
SM
38432019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3844
3845 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3846 gdb_bfd_ref_ptr.
3847 <~dwo_file>: Remove call to gdb_bfd_unref.
3848 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3849 gdb_bfd_ref_ptr::get.
3850
51ac9db5
SM
38512019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3852
3853 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3854 type to htab_up.
3855 * dwarf2read.c (struct dwo_file): Initialize fields.
3856 <~dwo_file>: New.
3857 (free_dwo_file): Remove, move content to ~dwo_file.
3858 (struct dwo_file_deleter): Remove.
3859 (dwo_file_up>: Remove custom deleter.
3860 (free_dwo_files): Remove.
3861 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3862 dwo_files.
3863 (process_skeletonless_type_units): Call unique_ptr::get.
3864 (allocate_dwo_file_hash_table): Add deleter to created hash
3865 table. Change return type to htab_up.
3866 (lookup_dwo_file_slot): Don't memset dwo_file, call
3867 unique_ptr::get.
3868 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3869 (create_dwo_unit_in_dwp_v2): Likewise.
3870 (open_and_init_dwo_file): Likewise.
3871 (free_dwo_file_from_slot): Remove.
3872
dc4ccb6f
SM
38732019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3874
3875 * dwarf2read.h (struct dwarf2_section_info) <readin,
3876 is_virtual>: Change type to bool.
3877 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3878 true instead of 1.
3879
e6a1c5cb
TT
38802019-06-19 Tom Tromey <tom@tromey.com>
3881
3882 * tui/tui-data.h (tui_init_content_element): Don't declare.
3883
6f6ffbeb
TT
38842019-06-19 Tom Tromey <tom@tromey.com>
3885
3886 * tui/tui-data.h (tui_init_win_info): Don't declare.
3887
f23f598e
TV
38882019-06-19 Tom de Vries <tdevries@suse.de>
3889
3890 * dwarf2read.h (abstract_to_concrete): Change type to
3891 std::unordered_map<sect_offset, std::vector<sect_offset>,
3892 gdb::hash_enum<sect_offset>>.
3893
680e1bee
TT
38942019-06-19 Tom Tromey <tromey@adacore.com>
3895
3896 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3897 EVAL_AVOID_SIDE_EFFECTS specially.
3898
dcf37923
TT
38992019-06-19 Tom Tromey <tromey@adacore.com>
3900
3901 * source-cache.c (highlighter): New global.
3902 (source_cache::get_source_lines): Create a highlighter on demand.
3903
494986d5
AB
39042019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
3905
3906 * defs.h (deprecated_interactive_hook): Delete declaration.
3907 * interps.c (clear_interpreter_hooks): Remove use of
3908 deprecated_interactive_hook.
3909 * top.c (deprecated_interactive_hook): Delete definition.
3910 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3911
3360b6e7
TV
39122019-06-18 Tom de Vries <tdevries@suse.de>
3913
3914 PR gdb/24515
3915 * dwarf2read.h (abstract_to_concrete): Change type from
3916 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3917 std::unordered_map<sect_offset, std::vector<sect_offset>>.
3918 * dwarf2read.c (read_variable): Update.
3919 (dwarf2_fetch_die_loc_sect_off): Update.
3920
310b3441
TV
39212019-06-17 Tom de Vries <tdevries@suse.de>
3922
3923 PR gdb/24617
3924 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3925 accessing parent[parent_len - 1].
3926
ba9777be
PP
39272019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
3928
3929 PR gdb/24364
3930 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3931 call dtrace_process_dof with NULL dof.
3932
2b9f6e89
TV
39332019-06-16 Tom de Vries <tdevries@suse.de>
3934
3935 PR gdb/24445
3936 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3937
431b3ead
TT
39382019-06-16 Tom Tromey <tom@tromey.com>
3939
3940 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3941 (make_all_visible): Use address of member.
3942
d04b44a1
TT
39432019-06-16 Tom Tromey <tom@tromey.com>
3944
3945 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3946 (tui_free_window, free_content, free_content_elements): Remove
3947 unnecessary cast.
3948 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3949 cast.
3950 * tui/tui-regs.c (tui_show_register_group)
3951 (tui_display_registers_from, tui_display_reg_element_at_line):
3952 Remove unnecessary cast.
3953
bf5142e7
AB
39542019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
3955
3956 * linux-nat.c (normal_mask): Delete.
3957 (_initialize_linux_nat): Don't initialise normal_mask.
3958
c4973306
SM
39592019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
3960
3961 PR gdb/24445
3962 * dwarf-index-write.h (write_psymtabs_to_index): Add
3963 dwz_basename parameter.
3964 * dwarf-index-write.c (write_gdbindex): Move file writing to
3965 write_gdbindex_1. Change return type void.
3966 (assert_file_size): Move up, remove filename parameter.
3967 (write_gdbindex_1): New function.
3968 (write_debug_names): Change return type to void, call
3969 assert_file_size.
3970 (struct index_wip_file): New struct.
3971 (write_psymtabs_to_index): Add dwz_basename parameter. Move
3972 file logic to index_wip_file. Write index for dwz file if
3973 needed.
3974 (save_gdb_index_command): Pass basename of dwz file, if present.
3975 * dwarf-index-cache.c (index_cache::store): Obtain and pass
3976 build-id of dwz file, if present.
3977 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3978 (dwarf2_get_dwz_file): Likewise.
3979 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3980 (dwarf2_get_dwz_file): Likewise.
3981
395f9c91
TT
39822019-06-16 Tom Tromey <tom@tromey.com>
3983
3984 * coffread.c (process_coff_symbol): Use xstrdup.
3985 * value.c (create_internalvar): Use xstrdup.
3986
cafb3438
TT
39872019-06-16 Tom Tromey <tom@tromey.com>
3988
3989 * valops.c (value_cast, value_slice): Remove unnecessary cast.
3990 * breakpoint.c (stopin_command, stopat_command)
3991 (until_break_command, decode_location_default): Remove unnecessary
3992 cast.
3993 * utils.c (subset_compare): Remove unnecessary cast.
3994 * ada-lang.c (ada_update_initial_language): Remove unnecessary
3995 cast.
3996 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3997 cast.
3998 * infcmd.c (path_command): Remove unnecessary cast.
3999 * coffread.c (decode_type): Remove unnecessary cast.
4000 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4001 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4002 * tui/tui-stack.c (tui_show_locator_content)
4003 (tui_show_frame_info): Remove unnecessary cast.
4004 * tui/tui-win.c (tui_scroll_forward_command)
4005 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4006 (parse_scrolling_args): Remove unnecessary cast.
4007 * tui/tui-data.c (init_win_info, tui_del_window)
4008 (tui_free_window, tui_del_data_windows, tui_free_data_content)
4009 (free_content_elements): Remove unnecessary cast.
4010 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4011 unnecessary cast.
4012 * tui/tui-source.c (tui_set_source_content)
4013 (tui_vertical_source_scroll): Remove unnecessary cast.
4014 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4015 cast.
4016 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4017 * tui/tui-regs.c (tui_display_registers_from)
4018 (tui_display_register): Remove unnecessary cast.
4019 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4020 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4021 (make_visible): Remove unnecessary cast.
4022 * tui/tui-winsource.c (tui_erase_source_content)
4023 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4024 unnecessary cast.
4025 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4026 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4027 * stabsread.c (read_type, read_array_type, read_range_type):
4028 Remove unnecessary cast.
4029 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4030 (parse_symbol, parse_type, upgrade_type, parse_external)
4031 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4032 unnecessary cast.
4033 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4034
730ead81
TT
40352019-06-16 Tom Tromey <tom@tromey.com>
4036
4037 * tui/tui-data.c (tui_alloc_generic_win_info)
4038 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4039 checks.
4040
584a927c
AB
40412019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
4042 Andrew Burgess <andrew.burgess@embecosm.com>
4043
4044 * f-typeprint.c (f_print_type): Don't return early for not
4045 associated or not allocated types.
4046 (f_type_print_varspec_suffix): Add print_rank parameter and print
4047 ranks of array types in case they dangling.
4048 (f_type_print_base): Add print_rank parameter.
4049
30056ea0
AB
40502019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4051
4052 * NEWS: Mention new MI commands.
4053 * break-catch-throw.c (enum exception_event_kind): Move to
4054 breakpoint.h.
4055 (print_mention_exception_catchpoint): Output text as a single
4056 message.
4057 (catch_exception_command_1): Rename to...
4058 (catch_exception_event): ...this, make non-static, update header
4059 command, and change some parameter types.
4060 (catch_catch_command): Update for changes to
4061 catch_exception_command_1.
4062 (catch_throw_command): Likewise.
4063 (catch_rethrow_command): Likewise.
4064 * breakpoint.c (enum exception_event_kind): Delete.
4065 * breakpoint.h (enum exception_event_kind): Moved here from
4066 break-catch-throw.c.
4067 (catch_exception_event): Declare.
4068 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4069 (mi_cmd_catch_throw): New function.
4070 (mi_cmd_catch_rethrow): New function.
4071 (mi_cmd_catch_catch): New function.
4072 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4073 'catch-catch' entries.
4074 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4075 (mi_cmd_catch_rethrow): Declare.
4076 (mi_cmd_catch_catch): Declare.
4077
ec8e2b6d
AB
40782019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4079
4080 * annotate.c (annotate_source_line): Change return type to void,
4081 update implementation to match.
4082 * annotate.h (annotate_source_line): Change return type to void,
4083 update header comment.
4084 * stack.c (print_frame_info): Don't change what frame information
4085 is printed based on whether annotations are on or not.
4086
0d3abd8c
AB
40872019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4088
4089 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4090 (annotate_source): Make static.
4091 (annotate_source_line): Moved from source.c and renamed from
4092 identify_source_line. Update the return type.
4093 * annotate.h (annotate_source): Delete declaration.
4094 (annotate_source_line): Declaration moved from source.h, and
4095 renamed from identify_source_line. Return type updated.
4096 * source.c (identify_source_line): Moved to annotate.c and renamed
4097 to annotate_source_line.
4098 (info_line_command): Remove check of annotation_level.
4099 * source.h (identify_source_line): Move declaration to annotate.h
4100 and rename to annotate_source_line.
4101 * stack.c: Add 'annotate.h' include.
4102 (print_frame_info): Remove check of annotation_level before
4103 calling annotate_source_line.
4104
00df30ae
AB
41052019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4106
4107 * source-cache.c (source_cache::get_plain_source_lines): Use
4108 open_source_file_with_line_charpos instead of just
4109 open_source_file, remove call to find_source_lines.
4110 (source_cache::get_source_lines): Likewise.
4111 * source.c (find_source_lines): Make static.
4112 (get_filename_and_charpos): Renamed into...
4113 (open_source_file_with_line_charpos): ..this along with changes to
4114 return a scoped_fd, and some other minor clean ups.
4115 (identify_source_line): Use open_source_file_with_line_charpos.
4116 (search_command_helper): Use open_source_file_with_line_charpos
4117 instead of just open_source_file, remove call to
4118 find_source_lines.
4119 * source.h (open_source_file_with_line_charpos): Declare new
4120 function.
4121 (find_source_lines): Delete declaration.
4122
afda45a2
AB
41232019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4124
4125 * source.c (get_filename_and_charpos): Remove fullname
4126 parameter.
4127 (identify_source_line): Update call to get_filename_and_charpos.
4128
0735b091
TT
41292019-06-14 Tom Tromey <tromey@adacore.com>
4130
4131 PR gdb/24502:
4132 * ui-style.h (skip_ansi_escape): Update comment.
4133 * ui-file.h (class no_terminal_escape_file): New class.
4134 * ui-file.c (no_terminal_escape_file::write)
4135 (no_terminal_escape_file::puts): New methods.
4136 * cli/cli-logging.c (handle_redirections): Use
4137 no_terminal_escape_file.
4138
52ce35e2
TT
41392019-06-14 Tom Tromey <tromey@adacore.com>
4140
4141 * NEWS: Move convenience variable news above Python news.
4142
73cc7272
TT
41432019-06-14 Tom Tromey <tom@tromey.com>
4144
4145 * gnulib: Move directory to top-level.
4146 * configure.ac: Don't configure gnulib.
4147 * configure: Rebuild.
4148 * common/common-defs.h: Use new path to gnulib.
4149 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4150 (GNULIB_H): Remove.
4151 (INCGNU): Look in new gnulib location.
4152 (HFILES_NO_SRCDIR): Remove gnulib files.
4153 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4154 (generated_files): Remove GNULIB_H.
4155 ($(LIBGNU), all-lib): Remove targets.
4156 (distclean): Don't mention GNULIB_BUILDDIR.
4157 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4158
f5686554
TT
41592019-06-14 Tom Tromey <tromey@adacore.com>
4160
4161 * symfile.c (add_symbol_file_command): Remove obsolete comment.
4162 Warn if symbol file does not provide any symbols.
4163
a0c1ffed
TT
41642019-06-14 Tom Tromey <tromey@adacore.com>
4165
4166 * source.c (find_and_open_source): Respect basenames_may_differ.
4167
7c39e397
AB
41682019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
4169
4170 * annotate.c (annotate_breakpoints_invalid): Make use of
4171 scoped_restore_terminal_state.
4172 (annotate_frames_invalid): Likewise.
4173
f411722c
TT
41742019-06-14 Tom Tromey <tromey@adacore.com>
4175
4176 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4177 allow assignment to an internalvar.
4178
4268ec18
TT
41792019-06-14 Tom Tromey <tromey@adacore.com>
4180
4181 * ada-lex.l: Allow "_" in attribute names.
4182
abdb711e
TT
41832019-06-14 Tom Tromey <tromey@adacore.com>
4184
4185 PR gdb/24653:
4186 * regcache.c (registers_changed): Don't call alloca.
4187 * top.c (execute_command): Don't call alloca.
4188
4c048731
PA
41892019-06-13 Pedro Alves <palves@redhat.com>
4190
4191 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4192 'expression'. When parsing an expression, error out if there's
4193 junk after "unlimited".
4194 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4195 (do_set_command): Adjust calls to is_unlimited_literal.
4196
66eb1ed3
PA
41972019-06-13 Pedro Alves <palves@redhat.com>
4198
4199 * compile/compile.c (make_compile_options_def_group): Add braces
4200 around array_view initializer.
4201 * thread.c (make_thread_apply_all_options_def_group)
4202 (make_thread_apply_all_options_def_group): Likewise.
4203
3345721a
PA
42042019-06-13 Pedro Alves <palves@redhat.com>
4205
4206 * NEWS (New commands): Mention "maint test-options
4207 require-delimiter", "maint test-options unknown-is-error", "maint
4208 test-options unknown-is-operand" and "maint show
4209 test-options-completion-result".
4210 (New command options, command completion): New section.
4211 (Completion improvements): New section.
4212 Mention that you can abbreviate "unlimited".
4213
6206060d
PA
42142019-06-13 Pedro Alves <palves@redhat.com>
4215
4216 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4217 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4218 * unittests/cli-utils-selftests.c (test_parse_flags)
4219 (test_parse_flags_qcs): Delete.
4220 (test_cli_utils): Don't call deleted functions.
4221
6665660a
PA
42222019-06-13 Pedro Alves <palves@redhat.com>
4223
4224 * thread.c: Include "cli/cli-option.h".
4225 (tp_array_compar_ascending): Global.
4226 (tp_array_compar): Delete function.
4227 (tp_array_compar_ascending, tp_array_compar_descending): New
4228 functions.
4229 (ascending_option_def, qcs_flag_option_def)
4230 (thr_qcs_flags_option_defs)
4231 (make_thread_apply_all_options_def_group)
4232 (make_thread_apply_options_def_group): New.
4233 (thread_apply_all_command): Use gdb::option::process_options.
4234 (thread_apply_command_completer)
4235 (thread_apply_all_command_completer): New.
4236 (thread_apply_command): Use gdb::option::process_options.
4237 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4238 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
4239 to generate help text of "thread apply". Adjust "taas"'s help.
4240 * tid-parse.c (tid_range_parser::in_thread_range): New method.
4241 * tid-parse.h (tid_range_parser::in_thread_range): New method.
4242
f7e13587
PA
42432019-06-13 Pedro Alves <palves@redhat.com>
4244
4245 * thread.c (thread_apply_command): Check for invalid TID with
4246 isdigit instead of !isalpha.
4247
5d707134
PA
42482019-06-13 Pedro Alves <palves@redhat.com>
4249
4250 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4251 (validate_flags_qcs): New.
4252 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4253 (validate_flags_qcs): Declare.
4254 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4255 (make_frame_apply_options_def_group): New.
4256 (frame_apply_command_count): Process options with
4257 gdb::option::process_options.
4258 (frame_apply_completer): New.
4259 (frame_apply_level_completer, frame_apply_all_completer)
4260 (frame_apply_completer): New.
4261 (_initialize_stack): Update help of "frame apply", "frame apply
4262 level", "frame apply all" and "faas" to mention supported options
4263 and install command completers.
4264 * stack.h (frame_apply_all_completer): Declare.
4265 * thread.c: Include "stack.h".
4266 (tfaas_command): Add "--".
4267 (_initialize_thread): Update help "tfaas" to mention supported
4268 options and install command completer.
4269
272d4594
PA
42702019-06-13 Pedro Alves <palves@redhat.com>
4271
4272 * completer.c (complete_nested_command_line): New.
4273 (gdb_completion_word_break_characters_throw): Add assertion.
4274 * completer.h (complete_nested_command_line): Declare.
4275
90a1ef87
PA
42762019-06-13 Pedro Alves <palves@redhat.com>
4277
4278 * stack.c (parse_backtrace_qualifiers): New.
4279 (backtrace_command): Use it.
4280 (backtrace_command_completer): Complete on qualifiers.
4281
d4c16835
PA
42822019-06-13 Pedro Alves <palves@redhat.com>
4283
4284 * frame.c: Include "cli/cli-option.h.
4285 (user_set_backtrace_options): New.
4286 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4287 Delete.
4288 (get_prev_frame): Adjust.
4289 (boolean_option_def, uinteger_option_def)
4290 (set_backtrace_option_defs): New.
4291 (_initialize_frame): Adjust and use
4292 gdb::option::add_setshow_cmds_for_options to install "set
4293 backtrace past-main" and "set backtrace past-entry".
4294 * frame.h: Include "cli/cli-option.h".
4295 (struct frame_print_options): Forward declare.
4296 (print_frame_arguments_all, print_frame_arguments_scalars)
4297 (print_frame_arguments_none): Declare.
4298 (print_entry_values): Delete declaration.
4299 (struct frame_print_options, user_frame_print_options): New.
4300 (struct set_backtrace_options): New.
4301 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4302 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4303 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4304 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4305 (list_args_or_locals): Add frame_print_options parameter.
4306 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4307 * python/py-framefilter.c (enumerate_args): Pass down
4308 USER_FRAME_PRINT_OPTIONS.
4309 * stack.c: Include "cli/cli-option.h".
4310 (print_frame_arguments_all, print_frame_arguments_scalars)
4311 (print_frame_arguments_none): Declare.
4312 (print_raw_frame_arguments, print_entry_values): Delete.
4313 (user_frame_print_options): New.
4314 (boolean_option_def, enum_option_def, frame_print_option_defs):
4315 New.
4316 (struct backtrace_cmd_options): New.
4317 (bt_flag_option_def): New.
4318 (backtrace_command_option_defs): New.
4319 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4320 (print_frame_arg, read_frame_arg, print_frame_args)
4321 (print_frame_info, print_frame): Add frame_print_options parameter
4322 and use it.
4323 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4324 (backtrace_command_1): Add frame_print_options and
4325 backtrace_cmd_options parameters and use them.
4326 (make_backtrace_options_def_group): New.
4327 (backtrace_command): Process command options with
4328 gdb::option::process_options.
4329 (backtrace_command_completer): New.
4330 (_initialize_stack): Extend "backtrace"'s help to mention
4331 supported options. Install completer for "backtrace".
4332 Install some settings commands with add_setshow_cmds_for_options.
4333
2daf894e
PA
43342019-06-13 Pedro Alves <palves@redhat.com>
4335
4336 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4337 and that "set/show print raw frame-arguments" are now deprecated.
4338
4339 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4340 command.
4341 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4342 * stack.c (_initialize_stack): Install "set/show print
4343 raw-frame-arguments", and deprecate "set/show print raw
4344 frame-arguments".
4345 * valprint.c (_initialize_valprint): Deprecate "set/show print
4346 raw".
4347
e6ed716c
PA
43482019-06-13 Pedro Alves <palves@redhat.com>
4349
4350 * compile/compile.c (struct compile_options): New.
4351 (compile_flag_option_def, compile_command_option_defs)
4352 (make_compile_options_def_group): New.
4353 (compile_file_command): Handle options with
4354 gdb::option::process_options.
4355 (compile_file_command_completer): New function.
4356 (compile_code_command): Handle options with
4357 gdb::option::process_options.
4358 (compile_code_command_completer): New function.
4359 (_initialize_compiler): Install completers for "compile code" and
4360 "compile file". Mention available options in "compile code" and
4361 "compile code"'s help.
4362 * completer.c (advance_to_completion_word): New, factored out from
4363 ...
4364 (advance_to_expression_complete_word_point): ... this.
4365 (advance_to_filename_complete_word_point): New.
4366 * completer.h (advance_to_filename_complete_word_point): New
4367 declaration.
4368
7d8062de
PA
43692019-06-13 Pedro Alves <palves@redhat.com>
4370
4371 * compile/compile.c: Include "cli/cli-option.h".
4372 (compile_print_value): Scope data pointer is now a
4373 value_print_options pointer; adjust.
4374 (compile_print_command): Process options. Scope data pointer is
4375 now a value_print_options pointer; adjust.
4376 (_initialize_compile): Update "compile print"'s help to include
4377 supported options. Install a completer for "compile print".
4378 * cp-valprint.c (show_vtblprint, show_objectprint)
4379 (show_static_field_print): Delete.
4380 (_initialize_cp_valprint): Don't install "set print
4381 static-members", "set print vtbl", "set print object" here.
4382 * printcmd.c: Include "cli/cli-option.h" and
4383 "common/gdb_optional.h".
4384 (print_command_parse_format): Rework to fill in a
4385 value_print_options instead of a format_data.
4386 (print_value): Change parameter type from format_data pointer to
4387 value_print_options reference. Adjust.
4388 (print_command_1): Process options. Adjust to pass down a
4389 value_print_options.
4390 (print_command_completer): New.
4391 (_initialize_printcmd): Install print_command_completer as
4392 handle_brkchars completer for the "print" command. Update
4393 "print"'s help to include supported options.
4394 * valprint.c: Include "cli/cli-option.h".
4395 (show_vtblprint, show_objectprint, show_static_field_print): Moved
4396 here from cp-valprint.c.
4397 (boolean_option_def, uinteger_option_def)
4398 (value_print_option_defs, make_value_print_options_def_group):
4399 New. Use gdb::option::add_setshow_cmds_for_options to install
4400 "set print elements", "set print null-stop", "set print repeats",
4401 "set print pretty", "set print union", "set print array", "set
4402 print address", "set print symbol", "set print array-indexes".
4403 * valprint.h: Include <string> and "cli/cli-option.h".
4404 (make_value_print_options_def_group): Declare.
4405 (print_value): Change parameter type from format_data pointer to
4406 value_print_options reference.
4407 (print_command_completer): Declare.
4408
9d0faba9
PA
44092019-06-13 Pedro Alves <palves@redhat.com>
4410
4411 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4412 (COMMON_SFILES): Add maint-test-settings.c.
4413 * cli/cli-decode.c (boolean_enums): New global, factored out from
4414 ...
4415 (add_setshow_boolean_cmd): ... here.
4416 * cli/cli-decode.h (boolean_enums): Declare.
4417 * cli/cli-option.c: New file.
4418 * cli/cli-option.h: New file.
4419 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4420 factored out from ...
4421 (parse_cli_boolean_value(const char *)): ... this.
4422 (is_unlimited_literal): Change parameter type to pointer to
4423 pointer. Adjust and advance ARG pointer.
4424 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4425 (parse_cli_var_enum): New, factored out from ...
4426 (do_set_command): ... this. Adjust.
4427 * cli/cli-setshow.h (parse_cli_boolean_value)
4428 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4429 (parse_cli_var_enum): Declare.
4430 * cli/cli-utils.c: Include "cli/cli-option.h".
4431 (get_ulongest): New.
4432 * cli/cli-utils.h (get_ulongest): Declare.
4433 (check_for_argument): New overloads.
4434 * maint-test-options.c: New file.
4435
2c722807
PA
44362019-06-13 Pedro Alves <palves@redhat.com>
4437
4438 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4439 parse a range if "-" is at the end of the string.
4440
dee7b4c8
PA
44412019-06-13 Pedro Alves <palves@redhat.com>
4442
4443 * cli/cli-setshow.c (parse_auto_binary_operation)
4444 (parse_cli_boolean_value): Don't allow "o".
4445
dca0f6c0
PA
44462019-06-13 Pedro Alves <palves@redhat.com>
4447
4448 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4449 * NEWS: Mention maint test-settings KIND.
4450 * maint-test-settings.c: New file.
4451
597bf39d
PA
44522019-06-13 Pedro Alves <palves@redhat.com>
4453
4454 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4455 completer.
4456 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4457 "set" completers.
4458
48c410fb
PA
44592019-06-13 Pedro Alves <palves@redhat.com>
4460
4461 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4462 after item.
4463
93bcb043
PA
44642019-06-13 Pedro Alves <palves@redhat.com>
4465
4466 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4467
cbba3ecd
PA
44682019-06-13 Pedro Alves <palves@redhat.com>
4469
4470 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4471 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4472 call.
4473 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4474 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4475 calls.
4476 (check_for_argument): Skip spaces after argument.
4477
b9a3f842
PA
44782019-06-13 Pedro Alves <palves@redhat.com>
4479
4480 * thread.c (thread_apply_command): Adjust TID parsing.
4481 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4482 detected before end of string.
4483 (tid_is_in_list): Error out if LIST is invalid.
4484
3844e605
PA
44852019-06-13 Pedro Alves <palves@redhat.com>
4486
4487 * completer.c (complete_line_internal_1): Rewind completion word
4488 point.
4489 (completion_tracker::advance_custom_word_point_by): Change
4490 parameter type to int.
4491 * completer.h (completion_tracker::advance_custom_word_point_by):
4492 Likewise.
4493
00b56dbe
PA
44942019-06-13 Pedro Alves <palves@redhat.com>
4495
4496 * completer.c (advance_to_completion_word): Handle delimiters.
4497
d106773e
PA
44982019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
4499
4500 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4501
08f10e02
TT
45022019-06-11 Tom Tromey <tom@tromey.com>
4503
4504 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4505 (xmalloc_failed): Move to alloc.c.
4506 * alloc.c: New file.
4507 * Makefile.in (COMMON_SFILES): Add alloc.c.
4508
1c7fe951
TT
45092019-06-11 Tom Tromey <tom@tromey.com>
4510
4511 * nat/linux-waitpid.c: Don't include server.h.
4512 (linux_debug): Remove.
4513 (my_waitpid): Update.
4514
89549d7f
TT
45152019-06-11 Tom Tromey <tromey@adacore.com>
4516
4517 * infcall.c (_initialize_infcall): Remove trailing newline from
4518 help.
4519 * user-regs.c (_initialize_user_regs): Remove trailing newline
4520 from help.
4521 * typeprint.c (_initialize_typeprint): Remove trailing newline
4522 from help.
4523 * reverse.c (_initialize_reverse): Remove trailing newlines from
4524 help.
4525 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4526 from help.
4527 * language.c (add_set_language_command): Remove trailing newline
4528 from help.
4529 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4530 help.
4531 * disasm.c (_initialize_disasm): Remove trailing newline from
4532 help.
4533 * top.c (init_main): Remove trailing newline from help.
4534 * interps.c (_initialize_interpreter): Remove trailing newline
4535 from help.
4536 * btrace.c (_initialize_btrace): Remove trailing newlines from
4537 help.
4538 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4539 from help.
4540 * python/python.c (_initialize_python): Remove trailing newline
4541 from help.
4542 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4543 help.
4544 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4545 from help. Reformat some text.
4546 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4547 from help.
4548 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4549 newline from help.
4550
86108c13
TT
45512019-06-11 Tom Tromey <tromey@adacore.com>
4552
4553 * darwin-nat.c (darwin_decode_exception_message)
4554 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4555
a7067863
AB
45562019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
4557
4558 * valops.c (value_slice): Check for not allocated or not
4559 associated values.
4560
9ab08412
TV
45612019-06-10 Tom de Vries <tdevries@suse.de>
4562
4563 PR gdb/24618
4564 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4565 sure an empty slot (defined by a 32-bit zero pair) is recognized as
4566 invalid.
4567
f19e22e9
TV
45682019-06-10 Tom de Vries <tdevries@suse.de>
4569
4570 PR gdb/24611
4571 * linespec.c (linespec_lexer_lex_string): Remove incorrect
4572 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
4573
e99f9db0
TV
45742019-06-10 Tom de Vries <tdevries@suse.de>
4575
4576 PR symtab/24545
4577 * symtab.c (struct demangled_name_entry): Add language field.
4578 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
4579 static minimal symbol". Set and use language field.
4580
9bf7038b
TT
45812019-06-10 Tom Tromey <tromey@adacore.com>
4582
4583 * ada-lang.c (_initialize_ada_language): Update help text.
4584
422186a9
TT
45852019-06-10 Tom Tromey <tromey@adacore.com>
4586
4587 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4588 with a newline.
4589 * guile/guile.c (handle_boot_error): Don't end warning with a
4590 newline.
4591 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4592 warning with a newline.
4593 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4594 newline.
4595 (s12z_frame_cache): Likewise.
4596 * dwarf-index-cache.c (index_cache::store): Don't end warning with
4597 a newline.
4598 * solib-svr4.c (disable_probes_interface): Don't end warning with
4599 a newline.
4600 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4601 newline.
4602 * python/python.c (do_finish_initialization): Don't end warning
4603 with a newline.
4604
25ce02ee
TT
46052019-06-10 Tom Tromey <tom@tromey.com>
4606
4607 * python/py-breakpoint.c (gdbpy_breakpoint_created)
4608 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4609 gdbpy_enter.
4610
caa429d8
TT
46112019-06-10 Tom Tromey <tromey@adacore.com>
4612
4613 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4614 data.
4615 (elf_new_init): Don't call stabsread_new_init.
4616 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4617 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
4618 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4619
81873cc8
TV
46202019-06-10 Tom de Vries <tdevries@suse.de>
4621
4622 PR symtab/16264
4623 PR symtab/24517
4624 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4625
4fa0265e
РИ
46262019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
4627
4628 * source.c (find_and_open_source): Also rewrite relative file
4629 names.
4630
1a3da2cd
AB
46312019-04-26 Amos Bird <amosbird@gmail.com>
4632
4633 * annotate.c (annotate_thread_exited): Add "thread-exited"
4634 annotation.
4635
3847a7bf
TT
46362019-06-06 Tom Tromey <tromey@adacore.com>
4637
4638 * maint.h (class scoped_command_stats): Use
4639 DISABLE_COPY_AND_ASSIGN.
4640 <print_time>: New method.
4641 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4642 print_time.
4643 (scoped_command_stats::print_time): New method.
4644
312617a3
AB
46452019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
4646
4647 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4648 instructions of lengths 6 or 8 bytes.
4649
b02f78f9
PA
46502019-06-04 Pedro Alves <palves@redhat.com>
4651
4652 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4653
4654 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4655 * breakpoint.c (condition_completer): Likewise.
4656 * cli/cli-dump.c (scan_expression): Likewise.
4657 * common/filestuff.c (mkdir_recursive): Likewise.
4658 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4659 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4660 (gdb_abspath): Likewise.
4661 * compile/compile-cplus-types.c
4662 (compile_cplus_instance::decl_name): Likewise.
4663 * completer.c (complete_explicit_location):
4664 (signal_completer, reg_or_group_completer_1): Likewise.
4665 * cp-support.c (cp_remove_params_if_any): Likewise.
4666 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4667 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4668 * infcmd.c (strip_bg_char): Likewise.
4669 * linespec.c (copy_token_string): Likewise.
4670 * mi/mi-main.c (output_cores): Likewise.
4671 * psymtab.c (psymtab_search_name):
4672 * symfile.c (test_set_ext_lang_command): Likewise.
4673 * target.c (target_fileio_read_stralloc): Likewise.
4674 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4675 * value.c (complete_internalvar): Likewise.
4676
e1f2e1a2
CB
46772019-06-04 Christian Biesinger <cbiesinger@google.com>
4678
4679 Add objfile property to gdb.Type.
d3238f7d
PA
4680 * NEWS: Mention Python API addition.
4681 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 4682
e664d728
PW
46832019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4684
4685 * NEWS: Mention the new set|show style [title|highlight].
4686 Mention changes to "show style", "help" and "apropos".
4687
66d8c862
PW
46882019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4689
4690 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4691 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
4692 instead of print_help_for_command.
4693 (print_doc_of_command): New function.
4694 (help_list): Add 'apropos -v word' suggestion.
4695 (print_help_for_command): Style the command name using title style.
4696 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4697 (_initialize_cli_cmds): Describe -v in apropos_command help.
4698
9303eb2f
PW
46992019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4700
4701 * cli/cli-style.h (cli_style_option): Add name in constructor,
4702 add m_name class member, add constructor with intensity,
4703 add name class function.
4704 (cli_style_option::add_setshow_commands): Remove name argument.
4705 (highlight_style, title_style): New styles.
4706 * cli/cli-style.c (do_show): New function that shows a style
4707 characteristic styling the style name with itself.
4708 (set_style_name): New function.
4709 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4710 Update all callers according to the changes in cli/cli-style.h.
4711 * utils.h (fputs_highlighted): New function.
4712 * utils.c (fputs_highlighted): Likewise.
4713
e2c52041
PW
47142019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4715
4716 * NEWS: Mention new pipe command and new convenience variables.
4717
947d3946
PW
47182019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4719
4720 * cli/cli-cmds.c (pipe_command): New function.
4721 (_initialize_cli_cmds): Call add_com for pipe_command.
4722 Define | as an alias for pipe.
4723 (exit_status_set_internal_vars): New function.
4724 (shell_escape): Call exit_status_set_internal_vars.
4725 cli/cli-decode.c (find_command_name_length): Recognize | as
4726 a single character command.
4727
b8fd0918
PW
47282019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4729
4730 * gdbcmd.h (execute_command_to_ui_file): New declaration.
4731 top.c (execute_command_to_ui_file): New function, mostly a copy
4732 of execute_command_to_string.
4733 (execute_command_to_string): Implement by calling
4734 execute_command_to_ui_file.
4735
68bb5386
PW
47362019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4737
4738 * top.h (saved_command_line): Remove declaration.
4739 * top.c (previous_saved_command_line, previous_repeat_arguments):
4740 New variables.
4741 (saved_command_line): Make static, define together with other
4742 'repeat variables'.
4743 (dont_repeat): Clear repeat_arguments.
4744 (repeat_previous, get_saved_command_line, save_command_line):
4745 New functions.
4746 (gdb_init): Initialize saved_command_line
4747 and previous_saved_command_line.
4748 * main.c (captured_main_1): Remove saved_command_line initialization.
4749 * event-top.c (handle_line_of_input): Update to use
4750 the new 'repeat' related functions instead of direct access to
4751 saved_command_line.
4752 * command.h (repeat_previous, get_saved_command_line,
4753 save_command_line): New declarations.
4754 (dont_repeat): Add comment.
4755
bfcdb852
TT
47562019-05-30 Tom Tromey <tromey@adacore.com>
4757
4758 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4759 Fix comment.
4760 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4761
0ef209f2
JV
47622019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
4763
4764 PR cli/24587
4765 * completer.c (complete): Initialize variable word.
4766
955b06fa
SDJ
47672019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
4768
4769 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4770 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4771 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4772 'body' is NULL to the outter 'if', protecting the '!is_define'
4773 situation as well.
4774
fa9c3fa0
TT
47752019-05-29 Tom Tromey <tromey@adacore.com>
4776
4777 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4778 (dwarf_unknown): New function.
4779 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4780 (dwarf_type_encoding_name): Use dwarf_unknown.
4781
4330d61d
TT
47822019-05-29 Tom Tromey <tromey@adacore.com>
4783
4784 PR c++/20020:
4785 * cp-valprint.c (cp_print_value_fields): Call
4786 cp_print_static_field inside "try".
4787
33a6bc35
TT
47882019-05-29 Tom Tromey <tromey@adacore.com>
4789
4790 * inflow.c (struct terminal_info): Add default operator=.
4791 * configure: Rebuild.
4792 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4793 -Wdeprecated-copy-dtor, -Wredundant-move.
4794
000439d5
TT
47952019-05-29 Tom Tromey <tromey@adacore.com>
4796
4797 * NEWS: Add entry.
4798 * infcmd.c (print_return_value_1): Handle finish_print
4799 option.
4800 (show_print_finish): New function.
4801 (_initialize_infcmd): Add "set/show print finish" commands.
4802 * valprint.c (user_print_options): Initialize new member.
4803 * valprint.h (struct value_print_options) <finish_print>: New
4804 member.
4805
c0e70c62
TT
48062019-05-28 Tom Tromey <tromey@adacore.com>
4807
4808 * ada-lang.c (ada_remove_Xbn_suffix)
4809 (find_old_style_renaming_symbol)
4810 (parse_old_style_renaming): Remove.
4811 (ada_find_renaming_symbol): Don't call
4812 find_old_style_renaming_symbol.
4813 (ada_is_renaming_symbol): Rename from
4814 ada_find_renaming_symbol. Remove "block" parameter. Return
4815 bool. Now static.
4816 (ada_read_var_value): Update and simplify.
4817 * ada-exp.y (write_var_or_type): Remove old code.
4818
766f8836
AH
48192019-05-28 Alan Hayward <alan.hayward@arm.com>
4820
4821 * event-top.c: Remove include comment.
4822 * inflow.c (class scoped_ignore_sigttou): Move from here...
4823 * inflow.h (class scoped_ignore_sigttou): ...to here.
4824 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4825 * top.c: Remove include comment.
4826
eb41253a
TT
48272019-05-27 Tom Tromey <tom@tromey.com>
4828
4829 * NEWS: Fix typo.
4830
4ca51187
TT
48312019-05-22 Tom Tromey <tromey@adacore.com>
4832
4833 * target.c (target_follow_exec): Constify parameter.
4834 * target-delegates.c: Rebuild.
4835 * remote.c (remote_target::follow_exec): Constify parameter.
4836 * infrun.c (follow_exec): Constify parameter.
4837 * target.h (struct target_ops) <follow_exec>: Constify parameter.
4838 (target_follow_exec): Likewise.
4839
8fca4da0
AH
48402019-05-22 Alan Hayward <alan.hayward@arm.com>
4841
4842 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4843 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4844
b7060614
AH
48452019-05-22 Alan Hayward <alan.hayward@arm.com>
4846
4847 * NEWS: Add debugredirect and testsuite sections.
4848
0a5954bd
SC
48492019-05-22 Simon Cook <simon.cook@embecosm.com>
4850
4851 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4852 target descriptions using exclusively floating point register name
4853 aliases.
4854
dc42e902
AB
48552019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
4856
4857 PR gdb/18644:
4858 * f-lang.c (build_fortran_types): Handle the case where
4859 gdbarch_floatformat_for_type returns a nullptr.
4860
fb7806c7
TV
48612019-05-21 Tom de Vries <tdevries@suse.de>
4862
4863 PR cli/24587
4864 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4865
34d11c68
AB
48662019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4867
4868 PR gdb/18644:
4869 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4870 16-byte floats.
4871 * i386-tdep.c (i386_floatformat_for_type): Use
4872 floatformats_ia64_quad for the 16-byte floating point component
4873 within a fortran 32-byte complex number.
4874
122cf0f2
AB
48752019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4876
4877 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4878 delete default constructor.
4879 (find_partial_die): Update to return const struct.
4880 (partial_die_parent_scope): Move variable declaration into scope
4881 of its use and change its type to auto.
4882 (guess_partial_die_structure_name): Likewise.
4883 (partial_die_info::fixup): Likewise.
4884
33d0e35a
TT
48852019-05-17 Tom Tromey <tromey@adacore.com>
4886
4887 * source.c (find_and_open_source): Remove cast.
4888
a45575b0
TT
48892019-05-17 Tom Tromey <tromey@adacore.com>
4890
4891 * annotate.c (annotate_source): Make "filename" const.
4892 * annotate.h (annotate_source): Use const.
4893
81f47ac2
AH
48942019-05-17 Alan Hayward <alan.hayward@arm.com>
4895
4896 * disasm.c (set_disassembler_options): Send errors to stderr.
4897
ca1285d1
AH
48982019-05-17 Alan Hayward <alan.hayward@arm.com>
4899
4900 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4901 (cli_interp_base::set_logging): Check debug_redirect.
4902 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4903 * cli/cli-logging.c (debug_redirect): Add static variable.
4904 (pop_output_files): Add default param.
4905 (handle_redirections): Print debug setting.
4906 (show_logging_command): Likewise.
4907 (_initialize_cli_logging): Add debugredirect command.
4908 * interps.c (current_interp_set_logging): Add debug_redirect
4909 parameter.
4910 * interps.h (set_logging): Add debug_redirect parameter.
4911 (current_interp_set_logging): Likewise.
4912 * mi/mi-common.h: Likewise.
4913 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4914
49152019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
4916 Tom Tromey <tromey@adacore.com>
4917
4918 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4919 directly.
4920 * cli/cli-interp.h (make_logging_output): Remove declaration.
4921 * cli/cli-logging.c (make_logging_output): Remove function.
4922 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4923 directly.
4924 * ui-file.c (tee_file::tee_file): Remove bools.
4925 (tee_file::~tee_file): Remove deletes.
4926 * ui-file.h (tee_file): Remove bools.
4927
26648588
JV
49282019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
4929
4930 * mi/mi-cmds.h (mi_cmd_complete): New function.
4931 * mi/mi-main.c (mi_cmd_complete): Likewise.
4932 * mi/mi-cmds.c: Define new MI command -complete.
4933 * NEWS: Mention new -complete command.
4934
6e035501
JV
49352019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
4936
4937 * completer.h (complete): New function.
4938 * completer.c (complete): Likewise.
4939 * cli/cli-cmds.c: (complete_command): Update to use new complete()
4940 function defined in completer.h.
4941
7d0e2ece
JV
49422019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
4943
e79be6e5 4944 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 4945
fb816e8b
TV
49462019-05-17 Tom de Vries <tdevries@suse.de>
4947
4948 PR gdb/24094
4949 * dwarf2read.c (struct cu_partial_die_info): New struct.
4950 (find_partial_die): Return cu_partial_die_info.
4951 (partial_die_parent_scope, guess_partial_die_structure_name)
4952 (partial_die_info::fixup): Handle new return type of find_partial_die.
4953
677052f2
SDJ
49542019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4955
4956 * stap-probe.c (stap_parse_register_operand): Make "regname" an
4957 "std::string", simplifying the algorithm.
4958
f3da9116
SDJ
49592019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4960
4961 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4962 (stap_static_probe_ops::get_probes): Likewise.
4963
f1bb75ab
SDJ
49642019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4965
4966 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4967 '-')" and "else if".
4968 (stap_parse_single_operand): Join checks for
4969 "gdbarch_stap_parse_special_token_p" and
4970 "gdbarch_stap_parse_special_token" in the same "if" statement.
4971 Invert check when verifying for operation on register
4972 displacement.
4973
3ca58cde
SDJ
49742019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4975
4976 * stap-probe.c (stap_get_opcode): Update comment.
4977 (stap_get_expected_argument_type): Likewise.
4978 (handle_stap_probe): Likewise.
4979
af2d9bee
SDJ
49802019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4981
4982 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4983 return type to 'bool'. Adjust comment. Use 'bool' when
4984 appropriate.
4985 (i386_stap_parse_special_token_three_arg_disp): Likewise.
4986 * stap-probe.c (stap_parse_argument_1): Likewise.
4987 (stap_is_operator): Likewise.
4988 (stap_is_generic_prefix): Likewise.
4989 (stap_is_register_prefix): Likewise.
4990 (stap_is_register_indirection_prefix): Likewise.
4991 (stap_is_integer_prefix): Likewise.
4992 (stap_generic_check_suffix): Likewise.
4993 (stap_check_integer_suffix): Likewise.
4994 (stap_check_register_suffix): Likewise.
4995 (stap_check_register_indirection_suffix): Likewise.
4996 (stap_parse_register_operand): Likewise.
4997 (stap_parse_single_operand): Likewise.
4998 (stap_parse_argument_1): Likewise.
4999 (stap_probe::get_argument_count): Likewise.
5000 (stap_is_operator): Likewise.
5001
61c9c421
TT
50022019-05-16 Tom Tromey <tromey@adacore.com>
5003
5004 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5005 keyword to foreach.
5006
9ddc1af1
SM
50072019-05-15 Simon Marchi <simon.marchi@efficios.com>
5008
5009 * linux-thread-db.c (try_thread_db_load_1): Change return type
5010 to bool.
5011 (try_thread_db_load): Likewise.
5012 (try_thread_db_load_from_pdir_1): Likewise.
5013 (try_thread_db_load_from_pdir): Likewise.
5014 (try_thread_db_load_from_sdir): Likewise.
5015 (try_thread_db_load_from_dir): Likewise.
5016 (thread_db_load_search): Likewise.
5017 (has_libpthread): Likewise.
5018 (thread_db_load): Likewise.
5019
7bede828
SDJ
50202019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
5021
5022 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5023 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5024 NULL, and complain/return if that's the case.
5025
c5358db4
JD
50262019-05-15 John Darrington <john@darrington.wattle.id.au>
5027
5028 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5029 (advance, posn, abstract_read_memory): New functions.
5030 [struct mem_read_abstraction]: New struct.
5031 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5032
c408a94f
TT
50332019-05-14 Tom Tromey <tromey@adacore.com>
5034
5035 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5036 value is not lval_memory.
5037
e7bd7fba
TT
50382019-05-14 Tom Tromey <tromey@adacore.com>
5039
5040 * solib.c (info_sharedlibrary_command): Style the file name.
5041
a6d0f249
AH
50422019-05-14 Alan Hayward <alan.hayward@arm.com>
5043
5044 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5045 (aarch64_vnv_type): Likewise.
5046 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5047 * common/tdesc.c: Likewise.
5048 * common/tdesc.h (enum tdesc_type_kind): Likewise.
5049 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5050 * features/aarch64-fpu.xml: Add ieee half view.
5051 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5052 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5053 * gdbtypes.h (struct builtin_type): Likewise.
5054 (struct objfile_type): Likewise.
5055
66b8bb74
SM
50562019-05-12 Paul Naert <paul.naert@polymtl.ca>
5057
5058 * language.c (language_sniff_from_mangled_name): Fix "langauge"
5059 typo.
5060 * location.h (string_to_event_location): Likewise.
5061
21c219fd
JB
50622019-05-11 Joel Brobecker <brobecker@adacore.com>
5063
5064 GDB 8.3 released.
5065
13674803
SM
50662019-05-10 Simon Marchi <simon.marchi@efficios.com>
5067
5068 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5069 New variable declaration.
5070 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5071 New variable.
5072 (print_one_breakpoint): Use ui_out::test_flags and new global
5073 variable to compute use_fixed_output.
5074 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5075 Remove.
5076 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5077 (mi_multi_location_breakpoint_output_fixed): Remove.
5078 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5079 new variable.
5080 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5081 fix_multi_location_breakpoint_output flag if version >= 3.
5082 * ui-out.h (enum ui_out_flag)
5083 <fix_multi_location_breakpoint_output>: New enumerator.
5084
a9eac7f9
SM
50852019-05-10 Simon Marchi <simon.marchi@efficios.com>
5086
5087 * contrib/cc-with-tweaks.sh: Validate dwz's work.
5088
71bed2db
TT
50892019-05-10 Tom Tromey <tromey@adacore.com>
5090
5091 * ada-lang.c (catch_ada_completer): New function.
5092 (_initialize_ada_language): Use it.
5093
24c54127
TT
50942019-05-10 Tom Tromey <tromey@adacore.com>
5095
5096 * thread.c (print_thread_info): Make "requested_threads" const.
5097 * gdbthread.h (print_thread_info): Make "requested_threads"
5098 const.
5099 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5100 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5101
7a102139
TT
51022019-05-08 Tom Tromey <tom@tromey.com>
5103
5104 * gdbtypes.c (objfile_type_data): Change type.
5105 (objfile_type, _initialize_gdbtypes): Update.
5106
924d79e2
TT
51072019-05-08 Tom Tromey <tom@tromey.com>
5108
5109 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5110 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5111 (_initialize_dwarf2_frame): Update.
5112
4c58e337
TT
51132019-05-08 Tom Tromey <tom@tromey.com>
5114
5115 * objc-lang.c (objc_objfile_data): Change type.
5116 (find_methods): Update.
5117 (_initialize_objc_lang): Remove.
5118
d772d2ab
TT
51192019-05-08 Tom Tromey <tom@tromey.com>
5120
5121 * stabsread.c (rs6000_builtin_type_data): Change type.
5122 (rs6000_builtin_type, _initialize_stabsread): Update.
5123
d11d83f4
TT
51242019-05-08 Tom Tromey <tom@tromey.com>
5125
5126 * mips-tdep.c (mips_pdr_data): Remove.
5127 (_initialize_mips_tdep): Update.
5128
9a73f0ad
TT
51292019-05-08 Tom Tromey <tom@tromey.com>
5130
5131 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5132 (hppa_init_objfile_priv_data, read_unwind_info)
5133 (find_unwind_entry, _initialize_hppa_tdep): Update.
5134
8127a2fa
TT
51352019-05-08 Tom Tromey <tom@tromey.com>
5136
5137 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5138 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
5139 on obstack.
5140 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5141
91d3055d
TT
51422019-05-08 Tom Tromey <tom@tromey.com>
5143
5144 * mdebugread.c (basic_type_data): Change type.
5145 (basic_type, _initialize_mdebugread): Update.
5146
31930bd3
TT
51472019-05-08 Tom Tromey <tom@tromey.com>
5148
5149 * common/gdb_unique_ptr.h (struct noop_deleter): New.
5150
bdb3ed9e
TT
51512019-05-08 Tom Tromey <tom@tromey.com>
5152
5153 * nto-tdep.c (nto_inferior_data_reg): Change type.
5154 (nto_inferior_data): Update.
5155 (nto_inferior_data_cleanup, nto_new_inferior_data)
5156 (_initialize_nto_tdep): Remove.
5157 * nto-tdep.h (struct nto_inferior_data): Add initializers.
5158
f37b313d
TT
51592019-05-08 Tom Tromey <tom@tromey.com>
5160
5161 * ada-lang.c (struct ada_inferior_data): Add initializers.
5162 (ada_inferior_data): Change type.
5163 (ada_inferior_data_cleanup): Remove.
5164 (get_ada_inferior_data, ada_inferior_exit)
5165 (struct ada_pspace_data): Add initializers, destructor.
5166 (ada_pspace_data_handle): Change type.
5167 (get_ada_pspace_data): Update.
5168 (ada_pspace_data_cleanup): Remove.
5169
24699405
TT
51702019-05-08 Tom Tromey <tom@tromey.com>
5171
5172 * coffread.c (struct coff_symfile_info): Add initializers.
5173 (coff_objfile_data_key): Move lower. Change type.
5174 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5175 Update.
5176 (coff_free_info): Remove.
5177
d4e05d2f
TT
51782019-05-08 Tom Tromey <tom@tromey.com>
5179
5180 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5181 (fbsd_pspace_data_handle): Move lower. Change type.
5182 (get_fbsd_pspace_data): Update.
5183 (fbsd_pspace_data_cleanup): Remove.
5184 (_initialize_fbsd_tdep): Update.
5185
14ef6690
TT
51862019-05-08 Tom Tromey <tom@tromey.com>
5187
5188 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5189 (get_ada_tasks_pspace_data): Update.
5190 (ada_tasks_pspace_data_cleanup): Remove.
5191 (_initialize_tasks): Update.
5192 (ada_tasks_inferior_data_handle): Change type.
5193 (get_ada_tasks_inferior_data): Update.
5194 (ada_tasks_inferior_data_cleanup): Remove.
5195 (struct ada_tasks_pspace_data): Add initializers.
5196
814cf43a
TT
51972019-05-08 Tom Tromey <tom@tromey.com>
5198
5199 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5200 * symfile-debug.c (debug_sym_get_probes): Change type.
5201 * stap-probe.c (handle_stap_probe):
5202 (stap_static_probe_ops::get_probes): Change type.
5203 * probe.h (class static_probe_ops) <get_probes>: Change type.
5204 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5205 (parse_probes_in_pspace): Update.
5206 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5207 Update.
5208 (any_static_probe_ops::get_probes): Change type.
5209 * elfread.c (elfread_data): New typedef.
5210 (probe_key): Change type.
5211 (elf_get_probes): Likewise. Update.
5212 (probe_key_free): Remove.
5213 (_initialize_elfread): Update.
5214 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5215 Change type.
5216 (dtrace_process_dof_probe, dtrace_process_dof)
5217 (dtrace_static_probe_ops::get_probe): Change type.
5218
02dc647e
TT
52192019-05-08 Tom Tromey <tom@tromey.com>
5220
5221 * xcoffread.c (struct xcoff_symfile_info): Rename from
5222 coff_symfile_info. Add initializers.
5223 (xcoff_objfile_data_key): Move lower. Change type.
5224 (XCOFF_DATA): Rewrite.
5225 (xcoff_free_info): Remove.
5226 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5227 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5228 (xcoff_initial_scan): Update.
5229
09232438
TT
52302019-05-08 Tom Tromey <tom@tromey.com>
5231
5232 * solib-svr4.c (struct svr4_info): Add initializers and
5233 destructor.
5234 <probes_table>: Now an htab_up.
5235 (solib_svr4_pspace_data): Change type.
5236 (free_probes_table): Simplify.
5237 (~svr4_info): Rename from svr4_pspace_data_cleanup.
5238 (get_svr4_info, probes_table_htab_remove_objfile_probes)
5239 (probes_table_remove_objfile_probes, register_solib_event_probe)
5240 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5241 (_initialize_svr4_solib): Update.
5242
7b4a314f
TT
52432019-05-08 Tom Tromey <tom@tromey.com>
5244
5245 * remote.c (remote_pspace_data): Change type.
5246 (remote_pspace_data_cleanup): Remove.
5247 (get_remote_exec_file, set_pspace_remote_exec_file)
5248 (_initialize_remote): Update.
5249
51d3063a
TT
52502019-05-08 Tom Tromey <tom@tromey.com>
5251
5252 * breakpoint.c (breakpoint_objfile_key): Change type.
5253 (get_breakpoint_objfile_data): Update.
5254 (free_breakpoint_objfile_data): Remove.
5255 (_initialize_breakpoint): Update.
5256
89fb8848
TT
52572019-05-08 Tom Tromey <tom@tromey.com>
5258
5259 * linux-tdep.c (struct linux_info): Add initializers.
5260 (linux_inferior_data): Move. Change type.
5261 (invalidate_linux_cache_inf): Update.
5262 (linux_inferior_data_cleanup): Remove.
5263 (get_linux_inferior_data, _initialize_linux_tdep): Update.
5264
e9b89e2d
TT
52652019-05-08 Tom Tromey <tom@tromey.com>
5266
5267 * auxv.c (auxv_inferior_data): Move. Change type.
5268 (auxv_inferior_data_cleanup): Remove.
5269 (invalidate_auxv_cache_inf): Rewrite.
5270 (get_auxv_inferior_data, _initialize_auxv): Update.
5271
8c42777c
TT
52722019-05-08 Tom Tromey <tom@tromey.com>
5273
5274 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5275 (symfile_debug_objfile_data_key): Change type.
5276 (symfile_debug_installed, debug_qf_has_symbols)
5277 (debug_qf_find_last_source_symtab)
5278 (debug_qf_forget_cached_source_info)
5279 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5280 (debug_qf_print_stats, debug_qf_dump)
5281 (debug_qf_expand_symtabs_for_function)
5282 (debug_qf_expand_all_symtabs)
5283 (debug_qf_expand_symtabs_with_fullname)
5284 (debug_qf_map_matching_symbols)
5285 (debug_qf_expand_symtabs_matching)
5286 (debug_qf_find_pc_sect_compunit_symtab)
5287 (debug_qf_map_symbol_filenames)
5288 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5289 (debug_sym_new_init, debug_sym_init, debug_sym_read)
5290 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5291 (debug_sym_read_linetable, debug_sym_relocate): Update.
5292 (symfile_debug_free_objfile): Remove.
5293 (install_symfile_debug_logging, _initialize_symfile_debug):
5294 Update.
5295
5bfd760d
TT
52962019-05-08 Tom Tromey <tom@tromey.com>
5297
5298 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5299 allocate_on_obstack.
5300 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5301 (get_dwarf2_per_objfile): Update.
5302 (set_dwarf2_per_objfile): Remove.
5303 (dwarf2_has_info, dwarf2_get_section_info): Update.
5304 (dwarf2_free_objfile): Remove.
5305 (_initialize_dwarf2_read): Update.
5306
e85e19b4
TT
53072019-05-08 Tom Tromey <tom@tromey.com>
5308
5309 * auto-load.c (struct auto_load_pspace_info): Add destructor and
5310 initializers.
5311 <unsupported_script_warning_printed,
5312 script_not_found_warning_printed>: Now bool.
5313 (auto_load_pspace_data): Change type.
5314 (~auto_load_pspace_info): Rename from
5315 auto_load_pspace_data_cleanup.
5316 (get_auto_load_pspace_data, init_loaded_scripts_info)
5317 (clear_section_scripts, maybe_print_unsupported_script_warning)
5318 (maybe_print_script_not_found_warning, _initialize_auto_load):
5319 Update.
5320
f6aa7436
TT
53212019-05-08 Tom Tromey <tom@tromey.com>
5322
5323 * objfiles.c (objfile_pspace_info): Add destructor and
5324 initializers.
5325 (objfiles_pspace_data): Change type.
5326 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5327 (get_objfile_pspace_data): Update.
5328 (objfiles_bfd_data): Change type.
5329 (get_objfile_bfd_data): Update.
5330 (objfile_bfd_data_free, _initialize_objfiles): Remove.
5331
6ae614f6
TT
53322019-05-08 Tom Tromey <tom@tromey.com>
5333
5334 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5335 Change type.
5336 (get_catch_syscall_inferior_data): Update.
5337 (catch_syscall_inferior_data_cleanup): Remove.
5338 (_initialize_break_catch_syscall): Update.
5339
6509b8eb
TT
53402019-05-08 Tom Tromey <tom@tromey.com>
5341
5342 * inflow.c (struct terminal_info): Add destructor and
5343 initializers.
5344 (inflow_inferior_data): Change type.
5345 (~terminal_info): Rename from inflow_inferior_data_cleanup.
5346 (get_inflow_inferior_data, inflow_inferior_exit)
5347 (swap_terminal_info, _initialize_inflow): Update.
5348
35632941
TT
53492019-05-08 Tom Tromey <tom@tromey.com>
5350
5351 * target-dcache.c (target_dcache_cleanup): Remove.
5352 (target_dcache_aspace_key): Change type.
5353 (target_dcache_init_p, target_dcache_invalidate)
5354 (target_dcache_get, target_dcache_get_or_init)
5355 (_initialize_target_dcache): Update.
5356 * dcache.h (struct dcache_deleter): New.
5357
3017b94d
TT
53582019-05-08 Tom Tromey <tom@tromey.com>
5359
5360 * symtab.c (struct symbol_cache): Add destructor and
5361 initializers.
5362 (symbol_cache_key): Move. Change type.
5363 (make_symbol_cache, free_symbol_cache): Remove.
5364 (get_symbol_cache): Update.
5365 (symbol_cache_cleanup): Remove.
5366 (ALL_PSPACES, symbol_cache_flush)
5367 (maintenance_print_symbol_cache)
5368 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5369 Update.
5370
a32ad8c5
TT
53712019-05-08 Tom Tromey <tom@tromey.com>
5372
5373 * symtab.c (struct main_info): Add destructor and initializers.
5374 (main_progspace_key): Move. Change type.
5375 (get_main_info): Update.
5376 (main_info_cleanup): Remove.
5377 (_initialize_symtab): Update.
5378
5f6e90a0
TT
53792019-05-08 Tom Tromey <tom@tromey.com>
5380
5381 * registry.h (DECLARE_REGISTRY): Define the _key class.
5382
1bd0c6e4
AB
53832019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
5384
5385 * NEWS: Merge two 'New commands' sections.
5386
2228ef77
XR
53872019-05-08 Joel Brobecker <brobecker@adacore.com>
5388
5389 * ada-valprint.c (ada_val_print_gnat_array): Remove language
5390 parameter and use Ada language definition instead.
5391 (ada_val_print_ptr): Remove unused language parameter.
5392 (ada_val_print_num): Remove language parameter and use Ada language
5393 definition instead.
5394 (ada_val_print_enum, ada_val_print_flt): Remove unused language
5395 parameter.
5396 (ada_val_print_struct_union, ada_val_print_ref): Remove language
5397 parameter and use Ada language definition instead.
5398 (ada_val_print_1): Update all ada_val_print_xxx calls.
5399 Remove language parameter.
5400 (ada_val_print): Update ada_val_print_1 call.
5401
60fcc1c3
TT
54022019-05-08 Tom Tromey <tromey@adacore.com>
5403
5404 * remote.c (remote_hw_watchpoint_limit)
5405 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5406 Now static.
5407
ed2b7c17
TT
54082019-05-08 Tom Tromey <tromey@adacore.com>
5409
5410 * maint.c (_initialize_maint_cmds): Move initialization code to
5411 remote.c.
5412 (watchdog, show_watchdog): Move to remote.c.
5413 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
5414 "watchdog" static.
5415 (_initialize_remote): Move initialization code from maint.c.
5416 * defs.h (watchdog): Don't declare.
5417
b0be6c91
TT
54182019-05-08 Tom Tromey <tromey@adacore.com>
5419
5420 * tui/tui-interp.c: Include main.h.
5421 * interps.c: Include main.h.
5422 * main.h (interpreter_p): Declare.
5423 * defs.h (interpreter_p): Don't declare.
5424
587ee17b
TT
54252019-05-08 Tom Tromey <tromey@adacore.com>
5426
5427 * dwarf2loc.c: Include dwarf2read.h.
5428 * defs.h (read_unsigned_leb128): Don't declare.
5429 * dwarf2read.h (read_unsigned_leb128): Declare.
5430
ca1df239
TT
54312019-05-08 Tom Tromey <tromey@adacore.com>
5432
5433 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5434 method.
5435
99f20f08
TT
54362019-05-08 Tom Tromey <tromey@adacore.com>
5437
5438 * utils.c (fputs_maybe_filtered): Reset style after paging, even
5439 when no wrap column is set.
5440
80e55b13
TT
54412019-05-08 Tom Tromey <tromey@adacore.com>
5442
5443 * c-lang.c (c_get_string): Handle non-C-style arrays.
5444
9d3421af
TT
54452019-05-08 Tom Tromey <tromey@adacore.com>
5446
5447 * typeprint.c (print_offset_data::update): Print the bit offset,
5448 not the number of bits remaining.
5449
844333e2
TT
54502019-05-08 Tom Tromey <tromey@adacore.com>
5451
5452 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5453 padding at end of comment.
5454
988915ee
TT
54552019-05-08 Tom Tromey <tromey@adacore.com>
5456
5457 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5458 Compare main types.
5459
26bfd823
TT
54602019-05-06 Tom Tromey <tom@tromey.com>
5461
5462 * common/scoped_mmap.c: Include common-defs.h.
5463 * common/scoped_mmap.h: Don't include config.h.
5464
89055eaa
TT
54652019-05-04 Tom Tromey <tom@tromey.com>
5466
5467 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5468 (struct aarch64_call_info): Add initializers.
5469 <si>: Now a std::vector.
5470 (pass_on_stack, aarch64_push_dummy_call): Update.
5471
5da01df5
TT
54722019-05-04 Simon Marchi <simon.marchi@efficios.com>
5473 Tom Tromey <tom@tromey.com>
5474
5475 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5476 (ppc_threads): Now a std::vector. Now static.
5477 (hwdebug_find_thread_points_by_tid)
5478 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5479 Update.
5480
fbdf05a1
TT
54812019-05-04 Tom Tromey <tom@tromey.com>
5482
5483 * arc-tdep.c (arc_tdesc_init): Return bool.
5484
06d16ec9
TT
54852019-05-04 Tom Tromey <tom@tromey.com>
5486
5487 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5488 Use gdb_assert_not_reached.
5489
9c056022
TT
54902019-05-04 Tom Tromey <tom@tromey.com>
5491
5492 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5493 "false".
5494
fa9c2a59
TT
54952019-05-04 Tom Tromey <tom@tromey.com>
5496
5497 * arc-tdep.c (arc_tdesc_init): Use bool.
5498
e2eb806a
TT
54992019-05-04 Tom Tromey <tom@tromey.com>
5500
5501 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5502
6fe87677
TT
55032019-05-04 Tom Tromey <tom@tromey.com>
5504
5505 * cli/cli-cmds.c (valid_command_p): Return bool.
5506
7f008c9e
TT
55072019-05-04 Tom Tromey <tom@tromey.com>
5508
5509 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5510 * command.h (valid_user_defined_cmd_name_p): Channge return type.
5511
b6484282
RT
55122019-05-04 Raul Tambre <raul@tambre.ee>
5513
5514 * python/lib/gdb/prompt.py (_ExtendedPrompt)
5515 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5516 operator for comparison.
5517
af97b416
TT
55182019-05-04 Tom Tromey <tom@tromey.com>
5519
5520 * psymtab.c (psymbol_name_matches, match_partial_symbol)
5521 (lookup_partial_symbol, print_partial_symbols)
5522 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5523 (psymbol_compare): Update.
5524 (add_psymbol_to_bcache): Clear the entire psymbol.
5525 (maintenance_check_psymtabs): Update.
5526 * psympriv.h (struct partial_symbol): Don't derive from
5527 general_symbol_info.
5528 <obj_section, unrelocated_address, address,
5529 set_unrelocated_address>: Update.
5530 <ginfo>: New member.
5531 * dwarf-index-write.c (write_psymbols, debug_names::insert)
5532 (debug_names::write_psymbols): Update.
5533
9d6d4be8
TV
55342019-05-04 Tom de Vries <tdevries@suse.de>
5535
5536 * contrib/cc-with-tweaks.sh: Support -n arg.
5537
66452beb
PW
55382019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5539
5540 * corelow.c (core_target::detach): Ensure frame cache and
5541 register caches are cleared.
5542 inferior.c (exit_inferior_1): Likewise.
5543
bde09ab7
TT
55442019-05-03 Sandra Loosemore <sandra@codesourcery.com>
5545 Tom Tromey <tom@tromey.com>
5546
5547 * dictionary.c (collate_pending_symbols_by_language): Remove
5548 "struct" from foreach.
5549 * symtab.c (lookup_global_symbol_from_objfile)
5550 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5551 foreach.
5552 * ser-tcp.c (net_open): Remove "struct" from foreach.
5553 * objfiles.c (objfile_relocate, objfile_rebase)
5554 (objfile_has_symbols): Remove "struct" from foreach.
5555 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5556 from foreach.
5557 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5558 foreach.
5559 * darwin-nat.c (thread_info_from_private_thread_info): Remove
5560 "struct" from foreach.
5561 * ada-lang.c (create_excep_cond_exprs)
5562 (ada_exception_catchpoint_cond_string): Remove "struct" from
5563 foreach.
5564
222a8d25
TT
55652019-05-03 Tom Tromey <tromey@adacore.com>
5566
5567 * ada-exp.y (convert_char_literal): Check suffix of each
5568 enumerator.
5569
fcd60b84
DP
55702019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
5571
5572 PR ada/21406:
5573 * ada-exp.y (yywrap): Don't define.
5574 * ada-lex.l (%option): Add noyywrap
5575 (yywrap): Remove.
5576
5f2459c2
EZ
55772019-05-03 Eli Zaretskii <eliz@gnu.org>
5578
353ea2d1
EZ
5579 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5580 _WIN32_WINNT to the XP level, unless already defined to a higher
5581 level.
5582
5583 * unittests/parse-connection-spec-selftests.c:
5584 * ser-tcp.c:
5585 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
5586 override.
5587
5f2459c2
EZ
5588 * symfile.c (find_separate_debug_file): Remove colon from the
5589 drive spec of DOS/Windows file names of the target, so that the
5590 file name produced from DEBUGDIR and the target's directory will
5591 be valid on DOS/Windows systems.
5592
80062eb9
AB
55932019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
5594
5595 * rust-lang.c (val_print_struct): Handle printing structures
5596 containing strings.
5597
b8c05e85
TT
55982019-05-02 Tom Tromey <tromey@adacore.com>
5599
5600 * valarith.c (_initialize_valarith): Remove.
5601
4504bbde
TT
56022019-05-01 Tom Tromey <tromey@adacore.com>
5603
5604 * ada-lang.c (ada_value_primitive_field): Treat more fields as
5605 bitfields.
5606
d48e62f4
TT
56072019-05-01 Tom Tromey <tromey@adacore.com>
5608
5609 * ada-lang.c (ada_value_assign): Correctly compute starting offset
5610 for big-endian copies.
5611
15f18d14
AT
56122019-04-30 Ali Tamur <tamur@google.com>
5613 * gdb/dwarf2read.c (read_3_bytes): New declaration.
5614 (read_attribute_value): Added DW_FORM_strx1-4 cases.
5615 (read_3_bytes): New function.
5616
ab4ee614
JB
56172019-04-30 Joel Brobecker <brobecker@adacore.com>
5618
5619 * windows-nat.c (main_thread_id): Delete.
5620 (handle_output_debug_string): Replace main_thread_id by
5621 current_event.dwThreadId.
5622 (fake_create_process): Likewise.
5623 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5624 Do not set main_thread_id.
5625 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5626 current_event.dwThreadId.
5627 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5628
8ed5b76e
JB
56292019-04-30 Joel Brobecker <brobecker@adacore.com>
5630
5631 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5632 Use current_event.dwThreadId instead of main_thread_id.
5633
2ff0a947
TT
56342019-04-30 Tom Tromey <tromey@adacore.com>
5635
5636 * ada-lang.c (ada_lookup_simple_minsyms): New function.
5637 (create_excep_cond_exprs): Iterate over program spaces.
5638 (ada_exception_catchpoint_cond_string): Examine all minimal
5639 symbols for exception types.
5640
a776957c
TT
56412019-04-30 Tom Tromey <tromey@adacore.com>
5642
5643 PR c++/24470:
5644 * dwarf2read.c (process_structure_scope): Handle case where type
5645 has template parameters but no symbol was created.
5646
bc68014d
AB
56472019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5648 Chris January <chris.january@arm.com>
5649
5650 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5651 qualifier.
5652 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5653
f1fdc960
AB
56542019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5655
5656 * f-typeprint.c (f_print_type): Update rules for printing
5657 whitespace.
5658 (f_type_print_varspec_suffix): Likewise.
5659
bf7a4de1
AB
56602019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5661 Chris January <chris.january@arm.com>
5662
5663 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5664 function arguments.
5665
bbe75b9d
AB
56662019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5667
5668 * f-lang.c (build_fortran_types): Change name of void type to
5669 lower case.
5670 * f-typeprint.c (f_type_print_base): Print the name of the void
5671 type, rather than a fixed string.
5672 * f-valprint.c (f_decorations): Use lower case void string.
5673
1db455a7
AB
56742019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5675 Chris January <chris.january@arm.com>
5676
5677 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5678 types for Fortran.
5679
b6d03bb2
AB
56802019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5681 Chris January <chris.january@arm.com>
5682 David Lecomber <david.lecomber@arm.com>
5683
5684 * f-exp.y (BINOP_INTRINSIC): New token.
5685 (exp): New parser rule handling BINOP_INTRINSIC.
5686 (f77_keywords): Add new builtin procedures.
5687 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5688 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5689 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5690 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5691 (print_unop_subexp_f): New function.
5692 (print_binop_subexp_f): New function.
5693 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5694 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5695 (dump_subexp_body_f): Likewise.
5696 (operator_check_f): Likewise.
5697 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5698 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5699
83228e93
AB
57002019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5701
5702 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5703 UNOP_KIND.
5704 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5705 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5706 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5707 (operator_length_f): New fuction.
5708 (print_subexp_f): New function.
5709 (op_name_f): New function.
5710 (dump_subexp_body_f): New function.
5711 (operator_check_f): New function.
5712 (exp_descriptor_f): Replace standard expression handling functions
5713 with new functions.
5714 * gdb/fortran-operator.def: New file.
5715 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5716 * gdb/std-operator.def: Remove UNOP_KIND.
5717
6fdcd7cc
AB
57182019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5719
5720 * std-operator.def: Remove unbalanced, stray double quote
5721 character.
5722
2e62ab40
AB
57232019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5724 Chris January <chris.january@arm.com>
5725 Daniel Everett <daniel.everett@arm.com>
5726 Nick Forrington <nick.forrington@arm.com>
5727 Richard Bunt <richard.bunt@arm.com>
5728
5729 * cp-valprint.c (cp_print_value_fields): Allow an additional level
5730 of depth when printing anonymous structs or unions.
5731 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5732 Don't print either the top-level value, or the children if the
5733 max-depth is exceeded.
5734 (ppscm_print_children): When printing the key of a map, allow one
5735 extra level of depth.
5736 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5737 print either the top-level value, or the children if the max-depth
5738 is exceeded.
5739 (print_children): When printing the key of a map, allow one extra
5740 level of depth.
5741 * python/py-value.c (valpy_format_string): Add max_depth keyword.
5742 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5743 (user_print_options): Initialise max_depth field.
5744 (val_print_scalar_or_string_type_p): New function.
5745 (val_print): Check to see if the max depth has been reached.
5746 (val_print_check_max_depth): Define new function.
5747 (show_print_max_depth): New function.
5748 (_initialize_valprint): Add 'print max-depth' option.
5749 * valprint.h (struct value_print_options) <max_depth>: New field.
5750 (val_print_check_max_depth): Declare new function.
5751 * NEWS: Document new feature.
5752
4be290b2
AB
57532019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5754
5755 * ada-lang.c (ada_language_defn): Initialise new field.
5756 * c-lang.c (c_is_string_type_p): New function.
5757 (c_language_defn): Initialise new field.
5758 (cplus_language_defn): Initialise new field.
5759 (asm_language_defn): Initialise new field.
5760 (minimal_language_defn): Initialise new field.
5761 * c-lang.h (c_is_string_type_p): Declare new function.
5762 * d-lang.c (d_language_defn): Initialise new field.
5763 * f-lang.c (f_is_string_type_p): New function.
5764 (f_language_defn): Initialise new field.
5765 * go-lang.c (go_is_string_type_p): New function.
5766 (go_language_defn): Initialise new field.
5767 * language.c (default_is_string_type_p): New function.
5768 (unknown_language_defn): Initialise new field.
5769 (auto_language_defn): Initialise new field.
5770 * language.h (struct language_defn) <la_is_string_type_p>: New
5771 member variable.
5772 (default_is_string_type_p): Declare new function.
5773 * m2-lang.c (m2_language_defn): Initialise new field.
5774 * objc-lang.c (objc_language_defn): Initialise new field.
5775 * opencl-lang.c (opencl_language_defn): Initialise new field.
5776 * p-lang.c (pascal_is_string_type_p): New function.
5777 (pascal_language_defn): Initialise new field.
5778 * rust-lang.c (rust_is_string_type_p): New function.
5779 (rust_language_defn): Initialise new field.
5780
721b08c6
AB
57812019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5782
5783 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5784 New field.
5785 * ada-lang.c (ada_language_defn): Initialise new field.
5786 * c-lang.c (c_language_defn): Likewise.
5787 (cplus_language_defn): Likewise.
5788 (asm_language_defn): Likewise.
5789 (minimal_language_defn): Likewise.
5790 * d-lang.c (d_language_defn): Likewise.
5791 * f-lang.c (f_language_defn): Likewise.
5792 * go-lang.c (go_language_defn): Likewise.
5793 * language.c (unknown_language_defn): Likewise.
5794 (auto_language_defn): Likewise.
5795 * m2-lang.c (m2_language_defn): Likewise.
5796 * objc-lang.c (objc_language_defn): Likewise.
5797 * opencl-lang.c (opencl_language_defn): Likewise.
5798 * p-lang.c (pascal_language_defn): Likewise.
5799 * rust-lang.c (rust_language_defn): Likewise.
5800
fc913e53
AB
58012019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5802
5803 * ada-lang.c (ada_is_character_type): Change return type to bool.
5804 (ada_is_string_type): Likewise.
5805 * ada-lang.h (ada_is_character_type): Update declaration
5806 (ada_is_string_type): Likewise.
5807
fa731fa0
PW
58082019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5809
5810 Support style in 'frame|thread apply'
5811
5812 * gdbcmd.h (execute_command_to_string): New term_out parameter.
5813 * record.c (record_start, record_stop): Update callers of
5814 execute_command_to_string with false.
5815 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5816 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5817 methods.
5818 (class string_file): New constructor with term_out parameter.
5819 Override methods term_out and can_emit_style_escape. New member
5820 term_out.
5821 (class stdio_file): Override can_emit_style_escape.
5822 (class tee_file): Override term_out and can_emit_style_escape.
5823 * utils.h (can_emit_style_escape): Remove.
5824 * utils.c (can_emit_style_escape): Likewise.
5825 Update all callers of can_emit_style_escape (SOMESTREAM) to
5826 SOMESTREAM->can_emit_style_escape.
5827 * source-cache.c (source_cache::get_source_lines): Likewise.
5828 * stack.c (frame_apply_command_count): Call execute_command_to_string
5829 passing the term_out characteristic of the current gdb_stdout.
5830 * thread.c (thr_try_catch_cmd): Likewise.
5831 * top.c (execute_command_to_string): pass term_out parameter
5832 to construct the string_file for the command output.
5833 * ui-file.c (term_cli_styling): New function (most code moved
5834 from utils.c can_emit_style_escape).
5835 (string_file::string_file, string_file::can_emit_style_escape,
5836 stdio_file::can_emit_style_escape, tee_file::term_out,
5837 tee_file::can_emit_style_escape): New functions.
5838
136afab8
PW
58392019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5840
5841 * NEWS: Mention the new set|show may-call-functions.
5842 * infcall.c (may_call_functions_p): New variable.
5843 (show_may_call_functions_p): New function.
5844 (call_function_by_hand_dummy): Throws an error if not
5845 may-call-functions.
5846 (_initialize_infcall): Call add_setshow_boolean_cmd for
5847 may-call-functions.
5848
725cbb63
KS
58492019-04-25 Keith Seitz <keiths@redhat.com>
5850
5851 PR c++/24367
5852 * cp-support.c (inspect_type): Don't attempt substitutions
5853 of symbol with the same name.
5854
3d1cbb78
TT
58552019-04-25 Tom Tromey <tromey@adacore.com>
5856
5857 PR gdb/24475:
5858 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5859 static.
5860
94aeb44b
TT
58612019-04-25 Tom Tromey <tromey@adacore.com>
5862
5863 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5864 rvalue reference.
5865 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5866 (gdb_xml_parser::parse): Use std::move.
5867 * python/python-internal.h (gdbpy_convert_exception): Take a const
5868 reference.
5869 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5870 std::move.
5871 * python/py-utils.c (gdbpy_convert_exception): Take a const
5872 reference.
5873 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5874 Use std::move.
5875 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5876 Use std::move.
5877 * mi/mi-main.c (mi_print_exception): Take a const reference.
5878 * main.c (handle_command_errors): Take a const reference.
5879 * linespec.c (parse_linespec): Use std::move.
5880 * infcall.c (run_inferior_call): Use std::move.
5881 (call_function_by_hand_dummy): Use std::move.
5882 * exec.c (try_open_exec_file): Use std::move.
5883 * exceptions.h (exception_print, exception_fprintf)
5884 (exception_print_same): Update.
5885 * exceptions.c (print_exception, exception_print)
5886 (exception_fprintf, exception_print_same): Change parameters to
5887 const reference.
5888 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5889 * common/new-op.c: Use std::move.
5890 * common/common-exceptions.h (struct gdb_exception): Add move
5891 constructor.
5892 (struct gdb_exception_error, struct gdb_exception_quit, struct
5893 gdb_quit_bad_alloc): Change constructor to move constructor.
5894 (throw_exception): Change parameter to rvalue reference.
5895 * common/common-exceptions.c (throw_exception): Take rvalue
5896 reference.
5897 * cli/cli-interp.c (safe_execute_command): Use std::move.
5898 * breakpoint.c (insert_bp_location, location_to_sals): Use
5899 std::move.
5900
680d7fd5
TT
59012019-04-25 Tom Tromey <tromey@adacore.com>
5902
5903 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5904 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5905 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5906 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5907 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5908 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5909 guile/scm-value.c: Use unpack.
5910 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5911 gdbscm_gdb_exception.
5912 (gdbscm_throw_gdb_exception): Likewise.
5913 (struct gdbscm_gdb_exception): New.
5914 (unpack): New function.
5915 (gdbscm_wrap): Use unpack.
5916
c6fdd8b2
TT
59172019-04-25 Tom Tromey <tromey@adacore.com>
5918
5919 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5920 (gdb_rl_callback_handler): Use std::move.
5921 * common/common-exceptions.h (struct gdb_exception): Add move
5922 assignment operator.
5923 (throw_exception_sjlj): Change "exception" to const reference.
5924 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5925 (throw_exception_sjlj): Change "exception" to const reference.
5926
cc06b668
TT
59272019-04-25 Tom Tromey <tromey@adacore.com>
5928
5929 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5930 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5931 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5932 Update.
5933 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5934 Update.
5935 * mi/mi-interp.c (mi_interp::exec): Update.
5936 * linespec.c (parse_linespec): Update.
5937 * infcall.c (run_inferior_call): Update.
5938 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5939 * guile/scm-symbol.c (gdbscm_lookup_symbol)
5940 (gdbscm_lookup_global_symbol): Update.
5941 * guile/scm-param.c (gdbscm_parameter_value): Update.
5942 * guile/scm-frame.c (gdbscm_frame_read_register)
5943 (gdbscm_frame_read_var): Update.
5944 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5945 * exec.c (try_open_exec_file): Update.
5946 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5947 (gdb_rl_callback_handler): Update.
5948 * common/common-exceptions.h (exception_none): Don't declare.
5949 * common/common-exceptions.c (exception_none): Don't define.
5950 (struct catcher) <exception>: Update.
5951 * cli/cli-interp.c (safe_execute_command): Update.
5952 * breakpoint.c (insert_bp_location, location_to_sals): Update.
5953
cf532bd1
AT
59542019-04-25 Ali Tamur <tamur@google.com>
5955
5956 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5957 (read_attribute_value): Likewise.
5958 (dwarf2_read_addr_index): Update comment.
5959 (read_str_index): Add DW_FORM_strx.
5960 (dwarf2_string_attr): Likewise.
5961 (dwarf2_const_value_attr): Likewise.
5962 (dump_die_shallow): Likewise.
5963 (dwarf2_fetch_constant_bytes): Likewise.
5964 (skip_form_bytes): Likewise.
5965 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5966
82433e3e
SDJ
59672019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
5968
5969 PR corefiles/11608
5970 PR corefiles/18187
5971 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5972 OFFSET. Verify if current mapping contains an ELF header.
5973 (linux_find_memory_regions_full): Adjust call to
5974 dump_mapping_p.
5975
723adb65
SL
59762019-04-25 Sandra Loosemore <sandra@codesourcery.com>
5977 Kang Li <kanglictf@gmail.com>
5978
5979 PR gdb/21600
5980
5981 * dwarf2-frame.c (read_initial_length): Be consistent about using
5982 unsigned representation of length.
5983 (decode_frame_entry_1): Likewise. Check for wraparound of
5984 end pointer as well as buffer overflow.
5985
596179f7
SDJ
59862019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
5987
5988 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5989 "vq".
5990
a59240a4
TT
59912019-04-24 Tom Tromey <tromey@adacore.com>
5992
5993 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5994
f872fdbb
AB
59952019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5996
5997 * s12z-tdep.c (s12z_unwind_pc): Delete.
5998 (s12z_unwind_sp): Delete.
5999 (s12z_gdbarch_init): Don't register deleted functions with
6000 gdbarch.
6001
b614e6f3
AB
60022019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6003
6004 * rl78-tdep.c (rl78_unwind_sp): Delete.
6005 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6006
14faed38
AB
60072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6008
6009 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6010 (xstormy16_unwind_pc): Delete.
6011 (xstormy16_dummy_id): Delete.
6012 (xstormy16_gdbarch_init): Don't register deleted functions with
6013 gdbarch.
6014
541aad8a
AB
60152019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6016
6017 * vax-tdep.c (vax_unwind_pc): Delete.
6018 (vax_gdbarch_init): Don't register deleted function with gdbarch.
6019
29222070
AB
60202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6021
6022 * v850-tdep.c (v850_unwind_sp): Delete.
6023 (v850_unwind_pc): Delete.
6024 (v850_dummy_id): Delete.
6025 (v850_gdbarch_init): Don't register deleted functions with
6026 gdbarch.
6027
0f534d76
AB
60282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6029
6030 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6031 (tilegx_unwind_pc): Delete.
6032 (tilegx_unwind_dummy_id): Delete.
6033 (tilegx_gdbarch_init): Don't register deleted functions with
6034 gdbarch.
6035
1ba7b7f9
AB
60362019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6037
6038 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6039 (tic6x_dummy_id): Delete.
6040 (tic6x_gdbarch_init): Don't register deleted functions with
6041 gdbarch.
6042
d31f262c
AB
60432019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6044
6045 * sparc-tdep.c (sparc_unwind_pc): Delete.
6046 (sparc32_gdbarch_init): Don't register deleted function with
6047 gdbarch.
6048
6d14d64d
AB
60492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6050
6051 * sh-tdep.c (sh_unwind_sp): Delete.
6052 (sh_unwind_pc): Delete.
6053 (sh_dummy_id): Delete.
6054 (sh_gdbarch_init): Don't register deleted functions with
6055 gdbarch.
6056
a40dde9d
AB
60572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6058
6059 * score-tdep.c (score_unwind_sp): Delete.
6060 (score_unwind_pc): Delete.
6061 (score_dummy_id): Delete.
6062 (score_gdbarch_init): Don't register deleted functions with
6063 gdbarch.
6064
47c47d69
AB
60652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6066
6067 * rx-tdep.c (rx_unwind_pc): Delete.
6068 (rx_unwind_sp): Delete.
6069 (rx_dummy_id): Delete.
6070 (rx_gdbarch_init): Don't register deleted functions with
6071 gdbarch. Update comment.
6072
833a4480
AB
60732019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6074
6075 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6076 (rs6000_dummy_id): Delete.
6077 (rs6000_gdbarch_init): Don't register deleted functions with
6078 gdbarch.
6079
3f2cef49
AB
60802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6081
6082 * or1k-tdep.c (or1k_dummy_id): Delete.
6083 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6084
96acf884
AB
60852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6086
6087 * nios2-tdep.c (nios2_dummy_id): Delete.
6088 (nios2_unwind_sp): Delete.
6089 (nios2_gdbarch_init): Don't register deleted functions with
6090 gdbarch.
6091
ca0ab0aa
AB
60922019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6093
6094 * nds32-tdep.c (nds32_dummy_id): Delete.
6095 (nds32_unwind_pc): Delete.
6096 (nds32_unwind_sp): Delete.
6097 (nds32_gdbarch_init): Don't register deleted functions with
6098 gdbarch.
6099
c8259044
AB
61002019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6101
6102 * msp430-tdep.c (msp430_unwind_pc): Delete.
6103 (msp430_unwind_sp): Delete.
6104 (msp430_dummy_id): Delete.
6105 (msp430_gdbarch_init): Don't register deleted functions with
6106 gdbarch.
6107
27f113c8
AB
61082019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6109
6110 * moxie-tdep.c (moxie_unwind_sp): Delete.
6111 (moxie_unwind_pc): Delete.
6112 (moxie_dummy_id): Delete.
6113 (moxie_gdbarch_init): Don't register deleted functions with
6114 gdbarch.
6115
aee6c3cd
AB
61162019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6117
6118 * mn10300-tdep.c (mn10300_dummy_id): Delete.
6119 (mn10300_unwind_pc): Delete.
6120 (mn10300_unwind_sp): Delete.
6121 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6122 mn10300_unwind_sp.
6123 (mn10300_frame_unwind_init): Don't register deleted functions with
6124 gdbarch.
6125
8e2b5aea
AB
61262019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6127
6128 * mep-tdep.c (mep_unwind_pc): Delete.
6129 (mep_unwind_sp): Delete.
6130 (mep_dummy_id): Delete.
6131 (mep_gdbarch_init): Don't register deleted functions with
6132 gdbarch.
6133
43cf3ede
AB
61342019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6135
6136 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6137 (m68hc11_unwind_sp): Delete.
6138 (m68hc11_gdbarch_init): Don't register deleted functions with
6139 gdbarch.
6140
5e79b7bb
AB
61412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6142
6143 * m32r-tdep.c (m32r_unwind_sp): Delete.
6144 (m32r_unwind_pc): Delete.
6145 (m32r_dummy_id): Delete.
6146 (m32r_gdbarch_init): Don't register deleted functions with
6147 gdbarch.
6148
89b268d8
AB
61492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6150
6151 * m32c-tdep.c (m32c_unwind_pc): Delete.
6152 (m32c_unwind_sp): Delete.
6153 (m32c_dummy_id): Delete.
6154 (m32c_gdbarch_init): Don't register deleted functions with
6155 gdbarch.
6156
946c28d2
AB
61572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6158
6159 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6160 (lm32_unwind_pc): Delete.
6161 (lm32_dummy_id): Delete.
6162 (lm32_gdbarch_init): Don't register deleted functions with
6163 gdbarch.
6164
bf12844a
AB
61652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6166
6167 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6168 (iq2000_unwind_pc): Delete.
6169 (iq2000_dummy_id): Delete.
6170 (iq2000_gdbarch_init): Don't register deleted functions with
6171 gdbarch.
6172
ecbc06d2
AB
61732019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6174
6175 * nds32-tdep.c (nds32_type_align): Delete.
6176 (nds32_push_dummy_call): Use type_align instead.
6177
030197b4
AB
61782019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6179
6180 * arm-tdep.c (arm_type_align): Only handle vector override case.
6181 (arm_push_dummy_call): Use type_align.
6182 (arm_gdbarch_init): Register arm_type_align gdbarch function.
6183
b907456c
AB
61842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6185
6186 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6187 case.
6188 (pass_on_stack): Use type_align.
6189 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6190 function.
6191
9e97ba43
TT
61922019-04-23 Tom Tromey <tromey@adacore.com>
6193
6194 * dwarf2read.c (line_header::file_name_at): Remove unused
6195 overload.
6196
6892f601
TV
61972019-04-23 Tom de Vries <tdevries@suse.de>
6198
6199 PR gdb/24438
6200 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6201 invocation.
6202
336d760d
AT
6203
62042019-03-27 Ali Tamur <tamur@google.com>
6205
6206 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6207 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6208 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6209 (dwarf_expr_context::get_addr_index): Likewise
6210 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6211 (symbol_needs_eval_context::get_addr_index): Likewise
6212 (disassemble_dwarf_expression): Add DW_OP_addrx
6213 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6214 (read_cutu_die_from_dwo): Update comment
6215 (skip_one_die): Add DW_FORM_addrx
6216 (read_attribute_value): Likewise
6217 (var_decode_location): Add DW_OP_addrx
6218 (dwarf2_const_value_attr): Add DW_FORM_addrx
6219 (dump_die_shallow): Likewise
6220 (dwarf2_fetch_constant_bytes): Likewise
6221 (decode_locdesc): Add DW_OP_addrx
6222 (skip_form_bytes): Add DW_FORM_addrx
6223
ad9d13f8
AT
62242019-04-22 Ali Tamur <tamur@google.com>
6225
6226 * MAINTAINERS (Write After Approval): Add self.
6227
d70cc3ba
SM
62282019-04-22 Simon Marchi <simon.marchi@efficios.com>
6229
6230 * solib-svr4.c (get_svr4_info): Add pspace parameter.
6231 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6232 (open_symbol_file_object): Likewise.
6233 (svr4_default_sos): Add info parameter.
6234 (svr4_read_so_list): Likewise.
6235 (svr4_current_sos_direct): Adjust functions calls to pass down
6236 info.
6237 (svr4_current_sos_1): Add info parameter.
6238 (svr4_current_sos): Call get_svr4_info, pass info down to
6239 svr4_current_sos_1.
6240 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6241 get_svr4_info.
6242 (svr4_in_dynsym_resolve_code): Pass current_program_space to
6243 get_svr4_info.
6244 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6245 to get_svr4_info.
6246 (probes_table_remove_objfile_probes): Likewise.
6247 (register_solib_event_probe): Add info parameter.
6248 (solist_update_incremental): Pass info parameter down to
6249 svr4_read_so_list.
6250 (disable_probes_interface): Add info parameter.
6251 (svr4_handle_solib_event): Pass current_program_space to
6252 get_svr4_info. Adjust disable_probes_interface cleanup.
6253 (svr4_create_probe_breakpoints): Add info parameter, pass it
6254 down to register_solib_event_probe.
6255 (svr4_create_solib_event_breakpoints): Add info parameter,
6256 pass it down to svr4_create_probe_breakpoints.
6257 (enable_break): Pass info down to
6258 svr4_create_solib_event_breakpoints.
6259 (svr4_solib_create_inferior_hook): Pass current_program_space to
6260 get_svr4_info.
6261 (svr4_clear_solib): Likewise.
6262
7905fc35
PA
62632019-04-22 Pedro Alves <palves@redhat.com>
6264
6265 * solib-svr4.c (svr4_free_objfile_observer): New.
6266 (probe_and_action::objfile): New field.
6267 (probes_table_htab_remove_objfile_probes)
6268 (probes_table_remove_objfile_probes): New functions.
6269 (register_solib_event_probe): Add 'objfile' parameter. Store it
6270 in the new probe_and_action. Don't store the probe in 'lookup'.
6271 (svr4_create_probe_breakpoints): Pass objfile to
6272 register_solib_event_probe.
6273 (_initialize_svr4_solib): Register a free_objfile observer.
6274
fb881986
TT
62752019-04-19 Tom Tromey <tom@tromey.com>
6276
6277 * common/queue.h: Remove.
6278
8732db6c
TT
62792019-04-19 Tom Tromey <tom@tromey.com>
6280
6281 * event-loop.c: Don't include "common/queue.h".
6282
97dfbadd
TT
62832019-04-19 Tom Tromey <tom@tromey.com>
6284
6285 * remote.c (remote_target): Use delete.
6286 * remote-notif.h: Include <list>, not "common/queue.h".
6287 (notif_client_p): Remove typedef.
6288 (remote_notif_state): Add constructor, destructor, initializer.
6289 <notif_queue>: Now a std::list.
6290 (remote_notif_state_xfree): Don't declare.
6291 * remote-notif.c (remote_notif_process, handle_notification)
6292 (remote_notif_state_allocate): Update.
6293 (~remote_notif_state): Rename from remote_notif_state_xfree.
6294
cf250e36
TT
62952019-04-19 Tom Tromey <tom@tromey.com>
6296
6297 * symfile.c (reread_symbols): Update.
6298 * objfiles.c (objfile_register_static_link)
6299 (objfile_lookup_static_link): Update
6300 (~objfile) Don't delete static_links.
6301 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6302
61f4b350
TT
63032019-04-19 Tom Tromey <tom@tromey.com>
6304
6305 * type-stack.h (struct type_stack) <insert>: Constify string.
6306 * type-stack.c (type_stack::insert): Constify string.
6307 * gdbtypes.h (lookup_template_type): Update.
6308 (address_space_name_to_int): Update.
6309 * gdbtypes.c (address_space_name_to_int): Make space_identifier
6310 const.
6311 (lookup_template_type): Make name const.
6312 * c-exp.y: Update rules.
6313 (lex_one_token, classify_name, classify_inner_name)
6314 (c_print_token): Update.
6315 * p-exp.y: Update rules.
6316 (yylex): Update.
6317 * f-exp.y: Update rules.
6318 (yylex): Update.
6319 * d-exp.y: Update rules.
6320 (lex_one_token, classify_name, classify_inner_name): Update.
6321 * parse.c (write_dollar_variable, copy_name): Return std::string.
6322 * parser-defs.h (copy_name): Change return type.
6323 * m2-exp.y: Update rules.
6324 (yylex): Update.
6325 * go-exp.y (lex_one_token): Update.
6326 Update rules.
6327 (classify_unsafe_function, classify_packaged_name)
6328 (classify_name, yylex): Update.
6329
189b8c2e
ST
63302019-04-19 Sergei Trofimovich <siarheit@google.com>
6331
6332 * configure.ac: add --enable-source-highlight switch.
6333 * configure: Regenerate.
6334 * top.c (print_gdb_version): plumb --enable-source-highlight
6335 status to "show configuration".
6336
8ecb59f8
TT
63372019-04-19 Tom Tromey <tromey@adacore.com>
6338
6339 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6340 Check ADA_TYPE_P.
6341 (empty_record, ada_template_to_fixed_record_type_1)
6342 (template_to_static_fixed_type)
6343 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6344 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6345 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6346 macros.
6347
62160ec9
TT
63482019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
6349
6350 PR symtab/24423:
6351 * source.c (print_source_lines_base): Advance "iter" when a
6352 control character is seen.
6353
f2ae8bc8
PW
63542019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6355
6356 * inferior.h (struct infcall_suspend_state_deleter):
6357 Catch exception in destructor to avoid crash.
6358
d563b953
PW
63592019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6360
6361 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6362 close to the add_com "shell".
6363
dc34c897
TT
63642019-04-18 Tom Tromey <tromey@adacore.com>
6365
6366 * process-stratum-target.h (class process_stratum_target)
6367 <stratum>: Add "final".
6368
a12e5744
TT
63692019-04-17 Tom Tromey <tromey@adacore.com>
6370
6371 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6372 against nullptr before use.
6373
a7e559cc
AH
63742019-04-17 Alan Hayward <alan.hayward@arm.com>
6375
6376 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6377
c01660c6
AB
63782019-04-17 Jim Wilson <jimw@sifive.com>
6379 Andrew Burgess <andrew.burgess@embecosm.com>
6380
6381 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6382 code read might fail, assume 4-byte breakpoint in that case.
6383
4aa866af
LS
63842019-04-15 Leszek Swirski <leszeks@google.com>
6385
6386 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6387 rather than a hand-rolled POD check when checking for forced MEMORY
6388 classification.
6389
48574d91
AH
63902019-04-15 Alan Hayward <alan.hayward@arm.com>
6391
6392 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6393 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6394 function.
6395 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6396 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6397 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6398 declaration.
6399
4da037ef
AH
64002019-04-15 Alan Hayward <alan.hayward@arm.com>
6401
6402 * aarch64-linux-nat.c
6403 (aarch64_linux_nat_target::thread_architecture): Add override.
6404 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6405 each VQ.
6406
ccb8d7e8
AH
64072019-04-15 Alan Hayward <alan.hayward@arm.com>
6408
6409 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6410
35add35e
AB
64112019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
6412
6413 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6414 target types of size 96-bits, add some additional comments, and
6415 check that the builtin type we found was the correct size.
6416
51196bbc
EZ
64172019-04-12 Eli Zaretskii <eliz@gnu.org>
6418
6419 * utils.c (prompt_for_continue): Don't restore the styling at the
6420 end, as applied_style has the wrong value. This fixes styling in
6421 long lists of file names that are interrupted by the "Continue?"
6422 prompt.
6423
62253a61
AB
64242019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
6425
6426 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6427 * c-lang.c (c_language_defn): Likewise.
6428 (cplus_language_defn): Likewise.
6429 (asm_language_defn): Likewise.
6430 (minimal_language_defn): Likewise.
6431 * d-lang.c (d_language_defn): Likewise.
6432 * f-lang.c (f_language_defn): Likewise.
6433 * go-lang.c (go_language_defn): Likewise.
6434 * language.c (unknown_language_defn): Likewise.
6435 (auto_language_defn): Likewise.
6436 * language.h (struct language_defn): Remove la_magic field.
6437 (LANG_MAGIC): Delete.
6438 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6439 * objc-lang.c (objc_language_defn): Likewise.
6440 * opencl-lang.c (opencl_language_defn): Likewise.
6441 * p-lang.c (pascal_language_defn): Likewise.
6442 * rust-lang.c (rust_language_defn): Likewise.
6443
a9158a86
AB
64442019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6445
6446 * riscv-tdep.c (riscv_type_align): New function.
6447 (riscv_type_alignment): Delete.
6448 (riscv_arg_location): Use 'type_align'.
6449 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6450
41077b66
AB
64512019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6452
6453 * gdbtypes.c (type_align): A struct with no non-static fields also
6454 has alignment of 1.
6455
9f0272f8
AB
64562019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6457
6458 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6459 component to 0.
6460 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6461 member.
6462 (riscv_struct_info::analyse): New implementation using new
6463 analyse_inner member function.
6464 (riscv_struct_info::field_offset): New member function.
6465 (riscv_struct_info::m_offsets): New member variable.
6466 (riscv_struct_info::analyse_inner): New private member function,
6467 takes the old implementation of riscv_struct_info::analyse but
6468 extended to track field offsets.
6469 (riscv_call_arg_struct): Update the struct folding special cases
6470 to handle cases where empty C++ structs, which are non-zero
6471 length, are found.
6472 (riscv_arg_location): Initialise the length of each location, a
6473 non-zero length now indicates the location is in use.
6474 (riscv_push_dummy_call): Allow for the first location having a
6475 non-zero offset when setting up arguments.
6476 (riscv_return_value): Likewise, but for return values.
6477
02cf60c7
TT
64782019-04-11 Tom Tromey <tromey@adacore.com>
6479
6480 * utils.c (internal_vproblem): Make "msg" const.
6481
68811f8f
AH
64822019-04-11 Alan Hayward <alan.hayward@arm.com>
6483
6484 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6485 * trad-frame.c (trad_frame_reset_saved_regs): New function.
6486 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6487 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6488
3f52fdbc
KB
64892019-04-10 Kevin Buettner <kevinb@redhat.com>
6490
6491 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6492 function.
6493 (fill_gregset): Call amd64_linux_collect_native_gregset instead
6494 of amd64_collect_native_gregset.
6495 (amd64_linux_nat_target::store_registers): Likewise.
6496
e9ad22ee
TT
64972019-04-10 Tom Tromey <tom@tromey.com>
6498
6499 * symtab.c (lookup_global_symbol_from_objfile)
6500 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6501 * objfiles.h (class separate_debug_iterator): New.
6502 (class separate_debug_range): New.
6503 (struct objfile) <separate_debug_objfiles>: New method.
6504 (objfile_separate_debug_iterate): Don't declare.
6505 * objfiles.c (separate_debug_iterator::operator++): Rename from
6506 objfile_separate_debug_iterate.
6507 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6508 iterator.
6509 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6510 iterator.
6511
ee371134
TT
65122019-04-10 Tom Tromey <tom@tromey.com>
6513
6514 * symfile.c (reread_symbols): Remove old comment.
6515 * objfiles.c (free_all_objfiles): Fix a typo.
6516
bf227d61
TT
65172019-04-10 Tom Tromey <tom@tromey.com>
6518
6519 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6520 * minsyms.c (lookup_minimal_symbol): Use foreach.
6521 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6522 (lookup_minimal_symbol_solib_trampoline): Likewise.
6523 * symfile.c (reread_symbols): Use foreach.
6524
8dc433a0
TT
65252019-04-09 Ivan Begert <ivanbegert@gmail.com>
6526 Tom Tromey <tromey@adacore.com>
6527
6528 PR rust/24414:
6529 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6530 (rust_lex_int_test): Change "value" to be LONGEST.
6531 (rust_lex_tests): Add test for long integer literal.
6532
9ab8741a
TT
65332019-04-09 Tom Tromey <tromey@adacore.com>
6534
6535 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6536 to bool.
6537 (extended_remote_target::attach): Update.
6538 (remote_target::remote_notice_new_inferior): Update.
6539 (remote_target::add_current_inferior_and_thread): Update.
6540 * inferior.c (exit_inferior_1): Use "false".
6541 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6542
e242fd12
SM
65432019-04-09 Simon Marchi <simon.marchi@efficios.com>
6544
9ca1957f 6545 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
6546 the "start" command.
6547
2b0c8b01
KB
65482019-04-08 Kevin Buettner <kevinb@redhat.com>
6549
6550 * python/py-inferior.c (infpy_thread_from_thread_handle):
6551 Adjust comments to reflect renaming of thread_from_thread_handle
6552 to thread_from_handle. Adjust keywords. Fix type error message.
6553 (inferior_object_methods): Add thread_from_handle. Retain
6554 thread_from_thread_handle, but mark it as deprecated.
6555
50a82723
KB
65562019-04-08 Kevin Buettner <kevinb@redhat.com>
6557
6558 * gdbthread.h (find_thread_by_handle): Revise declaration.
6559 * thread.c (find_thread_by_handle): Likewise. Adjust
6560 implementation too.
6561 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6562 support for buffer objects as handles.
6563
cf63b016
KB
65642019-04-08 Kevin Buettner <kevinb@redhat.com>
6565
6566 * python/py-infthread.c (thpy_thread_handle): New function.
6567 (thread_object_methods): Register thpy_thread_handle.
6568
3d6c6204
KB
65692019-04-08 Kevin Buettner <kevinb@redhat.com>
6570
6571 * gdbthread.h (thread_to_thread_handle): Declare.
6572 * thread.c (gdbtypes.h): Include.
6573 (thread_to_thread_handle): New function.
6574
6575 * target.h (struct target_ops): Add thread_info_to_thread_handle.
6576 (target_thread_info_to_thread_handle): Declare.
6577 * target.c (target_thread_info_to_thread_handle): New function.
6578 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6579 * target-delegates.c: Regenerate.
6580
6581 * linux-thread-db.c (class thread_db_target): Add method
6582 thread_info_to_thread_handle.
6583 (thread_db_target::thread_info_to_thread_handle): Define.
6584 * remote.c (class remote_target): Add new method
6585 thread_info_to_thread_handle.
6586 (remote_target::thread_info_to_thread_handle): Define.
6587
56be6ea8
PA
65882019-04-08 Pedro Alves <palves@redhat.com>
6589
6590 * common/common-exceptions.c (throw_exception): Don't create
6591 named object to throw; throw directly.
6592 (throw_it): Likewise. Don't initialize gdb_exception::message
6593 here, with new; pass FMT and AP to the ctor instead.
6594 * common/common-exceptions.h: Include <string>.
6595 (gdb_exception::gdb_exception(enum return_reason, enum errors,
6596 const char *, va_list)): New ctor. Use std::make_shared.
6597 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6598 errors)): Delete.
6599 (gdb_exception_error::gdb_exception_error(enum errors, const char
6600 *, va_list)): New.
6601 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6602 Add assertion.
6603 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6604 errors)): Delete.
6605 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6606 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6607 Add assertion.
6608
eedc3f4f
TT
66092019-04-08 Tom Tromey <tom@tromey.com>
6610
6611 * valops.c (value_rtti_indirect_type): Replace throw_exception
6612 with throw.
6613 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6614 with throw.
6615 * thread.c (thr_try_catch_cmd): Replace throw_exception with
6616 throw.
6617 * target.c (target_translate_tls_address): Replace throw_exception
6618 with throw.
6619 * stack.c (frame_apply_command_count): Replace throw_exception
6620 with throw.
6621 * solib-spu.c (append_ocl_sos): Replace throw_exception with
6622 throw.
6623 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6624 with throw.
6625 * rs6000-tdep.c (rs6000_frame_cache)
6626 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6627 * remote.c: Replace throw_exception with throw.
6628 * record-full.c (record_full_message, record_full_wait_1)
6629 (record_full_restore): Replace throw_exception with throw.
6630 * record-btrace.c:
6631 (get_thread_current_frame_id, record_btrace_start_replaying)
6632 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6633 (cmd_record_btrace_start): Replace throw_exception with throw.
6634 * parse.c (parse_exp_in_context_1): Replace throw_exception with
6635 throw.
6636 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6637 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6638 * linespec.c:
6639 (find_linespec_symbols): Replace throw_exception with throw.
6640 * infrun.c (displaced_step_prepare, resume): Replace
6641 throw_exception with throw.
6642 * infcmd.c (post_create_inferior): Replace throw_exception with
6643 throw.
6644 * inf-loop.c (inferior_event_handler): Replace throw_exception
6645 with throw.
6646 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6647 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6648 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6649 (get_prev_frame_always, get_frame_pc_if_available)
6650 (get_frame_address_in_block_if_available, get_frame_language):
6651 Replace throw_exception with throw.
6652 * frame-unwind.c (frame_unwind_try_unwinder): Replace
6653 throw_exception with throw.
6654 * eval.c (fetch_subexp_value, evaluate_var_value)
6655 (evaluate_funcall, evaluate_subexp_standard): Replace
6656 throw_exception with throw.
6657 * dwarf2loc.c (call_site_find_chain)
6658 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6659 Replace throw_exception with throw.
6660 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6661 with throw.
6662 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6663 throw.
6664 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6665 * completer.c (complete_line_internal): Replace throw_exception
6666 with throw.
6667 * compile/compile-object-run.c (compile_object_run): Replace
6668 throw_exception with throw.
6669 * cli/cli-script.c (process_next_line): Replace throw_exception
6670 with throw.
6671 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6672 (btrace_enable, btrace_maint_update_pt_packets): Replace
6673 throw_exception with throw.
6674 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6675 throw_exception with throw.
6676 * break-catch-throw.c (re_set_exception_catchpoint): Replace
6677 throw_exception with throw.
6678 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6679 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6680 * aarch64-tdep.c (aarch64_make_prologue_cache)
6681 (aarch64_make_stub_cache): Replace throw_exception with throw.
6682
26003a20
TT
66832019-04-08 Tom Tromey <tom@tromey.com>
6684
6685 * common/common-exceptions.c (throw_exception): Rename from
6686 throw_exception_cxx. Remove old copy. Make argument const.
6687 (throw_it): Create and throw exception objects directly.
6688 * common/common-exceptions.h (throw_exception): Make argument
6689 const.
6690 (struct gdb_exception_error): Add constructor.
6691 (struct gdb_exception_quit): Add constructor.
6692
d272eb37
TT
66932019-04-08 Tom Tromey <tom@tromey.com>
6694
6695 * common/common-exceptions.h (exception_rethrow): Don't declare.
6696 (TRY_SJLJ): Update comment.
6697 (TRY, CATCH, END_CATCH): Remove.
6698 * common/common-exceptions.c (exception_rethrow): Remove.
6699
230d2906
TT
67002019-04-08 Tom Tromey <tom@tromey.com>
6701
6702 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6703 Remove.
6704 (gdb_exception_error): Rename from
6705 gdb_exception_RETURN_MASK_ERROR.
6706 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6707 (gdb_quit_bad_alloc): Update.
6708 * aarch64-tdep.c: Update.
6709 * ada-lang.c: Update.
6710 * ada-typeprint.c: Update.
6711 * ada-valprint.c: Update.
6712 * amd64-tdep.c: Update.
6713 * arch-utils.c: Update.
6714 * break-catch-throw.c: Update.
6715 * breakpoint.c: Update.
6716 * btrace.c: Update.
6717 * c-varobj.c: Update.
6718 * cli/cli-cmds.c: Update.
6719 * cli/cli-interp.c: Update.
6720 * cli/cli-script.c: Update.
6721 * common/common-exceptions.c: Update.
6722 * common/new-op.c: Update.
6723 * common/selftest.c: Update.
6724 * compile/compile-c-symbols.c: Update.
6725 * compile/compile-cplus-symbols.c: Update.
6726 * compile/compile-object-load.c: Update.
6727 * compile/compile-object-run.c: Update.
6728 * completer.c: Update.
6729 * corelow.c: Update.
6730 * cp-abi.c: Update.
6731 * cp-support.c: Update.
6732 * cp-valprint.c: Update.
6733 * darwin-nat.c: Update.
6734 * disasm-selftests.c: Update.
6735 * dtrace-probe.c: Update.
6736 * dwarf-index-cache.c: Update.
6737 * dwarf-index-write.c: Update.
6738 * dwarf2-frame-tailcall.c: Update.
6739 * dwarf2-frame.c: Update.
6740 * dwarf2loc.c: Update.
6741 * dwarf2read.c: Update.
6742 * eval.c: Update.
6743 * event-loop.c: Update.
6744 * event-top.c: Update.
6745 * exec.c: Update.
6746 * f-valprint.c: Update.
6747 * fbsd-tdep.c: Update.
6748 * frame-unwind.c: Update.
6749 * frame.c: Update.
6750 * gdbtypes.c: Update.
6751 * gnu-v3-abi.c: Update.
6752 * guile/guile-internal.h: Update.
6753 * guile/scm-block.c: Update.
6754 * guile/scm-breakpoint.c: Update.
6755 * guile/scm-cmd.c: Update.
6756 * guile/scm-disasm.c: Update.
6757 * guile/scm-frame.c: Update.
6758 * guile/scm-lazy-string.c: Update.
6759 * guile/scm-math.c: Update.
6760 * guile/scm-param.c: Update.
6761 * guile/scm-ports.c: Update.
6762 * guile/scm-pretty-print.c: Update.
6763 * guile/scm-symbol.c: Update.
6764 * guile/scm-symtab.c: Update.
6765 * guile/scm-type.c: Update.
6766 * guile/scm-value.c: Update.
6767 * i386-linux-tdep.c: Update.
6768 * i386-tdep.c: Update.
6769 * inf-loop.c: Update.
6770 * infcall.c: Update.
6771 * infcmd.c: Update.
6772 * infrun.c: Update.
6773 * jit.c: Update.
6774 * language.c: Update.
6775 * linespec.c: Update.
6776 * linux-fork.c: Update.
6777 * linux-nat.c: Update.
6778 * linux-tdep.c: Update.
6779 * linux-thread-db.c: Update.
6780 * main.c: Update.
6781 * mi/mi-cmd-break.c: Update.
6782 * mi/mi-cmd-stack.c: Update.
6783 * mi/mi-interp.c: Update.
6784 * mi/mi-main.c: Update.
6785 * objc-lang.c: Update.
6786 * p-valprint.c: Update.
6787 * parse.c: Update.
6788 * ppc-linux-tdep.c: Update.
6789 * printcmd.c: Update.
6790 * python/py-arch.c: Update.
6791 * python/py-breakpoint.c: Update.
6792 * python/py-cmd.c: Update.
6793 * python/py-finishbreakpoint.c: Update.
6794 * python/py-frame.c: Update.
6795 * python/py-framefilter.c: Update.
6796 * python/py-gdb-readline.c: Update.
6797 * python/py-inferior.c: Update.
6798 * python/py-infthread.c: Update.
6799 * python/py-lazy-string.c: Update.
6800 * python/py-linetable.c: Update.
6801 * python/py-objfile.c: Update.
6802 * python/py-param.c: Update.
6803 * python/py-prettyprint.c: Update.
6804 * python/py-progspace.c: Update.
6805 * python/py-record-btrace.c: Update.
6806 * python/py-record.c: Update.
6807 * python/py-symbol.c: Update.
6808 * python/py-type.c: Update.
6809 * python/py-unwind.c: Update.
6810 * python/py-utils.c: Update.
6811 * python/py-value.c: Update.
6812 * python/python.c: Update.
6813 * record-btrace.c: Update.
6814 * record-full.c: Update.
6815 * remote-fileio.c: Update.
6816 * remote.c: Update.
6817 * riscv-tdep.c: Update.
6818 * rs6000-aix-tdep.c: Update.
6819 * rs6000-tdep.c: Update.
6820 * rust-exp.y: Update.
6821 * rust-lang.c: Update.
6822 * s390-tdep.c: Update.
6823 * selftest-arch.c: Update.
6824 * solib-dsbt.c: Update.
6825 * solib-frv.c: Update.
6826 * solib-spu.c: Update.
6827 * solib-svr4.c: Update.
6828 * solib.c: Update.
6829 * sparc64-linux-tdep.c: Update.
6830 * stack.c: Update.
6831 * symfile-mem.c: Update.
6832 * symmisc.c: Update.
6833 * target.c: Update.
6834 * thread.c: Update.
6835 * top.c: Update.
6836 * tracefile-tfile.c: Update.
6837 * tui/tui.c: Update.
6838 * typeprint.c: Update.
6839 * unittests/cli-utils-selftests.c: Update.
6840 * unittests/parse-connection-spec-selftests.c: Update.
6841 * valops.c: Update.
6842 * valprint.c: Update.
6843 * value.c: Update.
6844 * varobj.c: Update.
6845 * windows-nat.c: Update.
6846 * x86-linux-nat.c: Update.
6847 * xml-support.c: Update.
6848
a70b8144
TT
68492019-04-08 Tom Tromey <tom@tromey.com>
6850
6851 * xml-support.c: Use C++ exception handling.
6852 * x86-linux-nat.c: Use C++ exception handling.
6853 * windows-nat.c: Use C++ exception handling.
6854 * varobj.c: Use C++ exception handling.
6855 * value.c: Use C++ exception handling.
6856 * valprint.c: Use C++ exception handling.
6857 * valops.c: Use C++ exception handling.
6858 * unittests/parse-connection-spec-selftests.c: Use C++ exception
6859 handling.
6860 * unittests/cli-utils-selftests.c: Use C++ exception handling.
6861 * typeprint.c: Use C++ exception handling.
6862 * tui/tui.c: Use C++ exception handling.
6863 * tracefile-tfile.c: Use C++ exception handling.
6864 * top.c: Use C++ exception handling.
6865 * thread.c: Use C++ exception handling.
6866 * target.c: Use C++ exception handling.
6867 * symmisc.c: Use C++ exception handling.
6868 * symfile-mem.c: Use C++ exception handling.
6869 * stack.c: Use C++ exception handling.
6870 * sparc64-linux-tdep.c: Use C++ exception handling.
6871 * solib.c: Use C++ exception handling.
6872 * solib-svr4.c: Use C++ exception handling.
6873 * solib-spu.c: Use C++ exception handling.
6874 * solib-frv.c: Use C++ exception handling.
6875 * solib-dsbt.c: Use C++ exception handling.
6876 * selftest-arch.c: Use C++ exception handling.
6877 * s390-tdep.c: Use C++ exception handling.
6878 * rust-lang.c: Use C++ exception handling.
6879 * rust-exp.y: Use C++ exception handling.
6880 * rs6000-tdep.c: Use C++ exception handling.
6881 * rs6000-aix-tdep.c: Use C++ exception handling.
6882 * riscv-tdep.c: Use C++ exception handling.
6883 * remote.c: Use C++ exception handling.
6884 * remote-fileio.c: Use C++ exception handling.
6885 * record-full.c: Use C++ exception handling.
6886 * record-btrace.c: Use C++ exception handling.
6887 * python/python.c: Use C++ exception handling.
6888 * python/py-value.c: Use C++ exception handling.
6889 * python/py-utils.c: Use C++ exception handling.
6890 * python/py-unwind.c: Use C++ exception handling.
6891 * python/py-type.c: Use C++ exception handling.
6892 * python/py-symbol.c: Use C++ exception handling.
6893 * python/py-record.c: Use C++ exception handling.
6894 * python/py-record-btrace.c: Use C++ exception handling.
6895 * python/py-progspace.c: Use C++ exception handling.
6896 * python/py-prettyprint.c: Use C++ exception handling.
6897 * python/py-param.c: Use C++ exception handling.
6898 * python/py-objfile.c: Use C++ exception handling.
6899 * python/py-linetable.c: Use C++ exception handling.
6900 * python/py-lazy-string.c: Use C++ exception handling.
6901 * python/py-infthread.c: Use C++ exception handling.
6902 * python/py-inferior.c: Use C++ exception handling.
6903 * python/py-gdb-readline.c: Use C++ exception handling.
6904 * python/py-framefilter.c: Use C++ exception handling.
6905 * python/py-frame.c: Use C++ exception handling.
6906 * python/py-finishbreakpoint.c: Use C++ exception handling.
6907 * python/py-cmd.c: Use C++ exception handling.
6908 * python/py-breakpoint.c: Use C++ exception handling.
6909 * python/py-arch.c: Use C++ exception handling.
6910 * printcmd.c: Use C++ exception handling.
6911 * ppc-linux-tdep.c: Use C++ exception handling.
6912 * parse.c: Use C++ exception handling.
6913 * p-valprint.c: Use C++ exception handling.
6914 * objc-lang.c: Use C++ exception handling.
6915 * mi/mi-main.c: Use C++ exception handling.
6916 * mi/mi-interp.c: Use C++ exception handling.
6917 * mi/mi-cmd-stack.c: Use C++ exception handling.
6918 * mi/mi-cmd-break.c: Use C++ exception handling.
6919 * main.c: Use C++ exception handling.
6920 * linux-thread-db.c: Use C++ exception handling.
6921 * linux-tdep.c: Use C++ exception handling.
6922 * linux-nat.c: Use C++ exception handling.
6923 * linux-fork.c: Use C++ exception handling.
6924 * linespec.c: Use C++ exception handling.
6925 * language.c: Use C++ exception handling.
6926 * jit.c: Use C++ exception handling.
6927 * infrun.c: Use C++ exception handling.
6928 * infcmd.c: Use C++ exception handling.
6929 * infcall.c: Use C++ exception handling.
6930 * inf-loop.c: Use C++ exception handling.
6931 * i386-tdep.c: Use C++ exception handling.
6932 * i386-linux-tdep.c: Use C++ exception handling.
6933 * guile/scm-value.c: Use C++ exception handling.
6934 * guile/scm-type.c: Use C++ exception handling.
6935 * guile/scm-symtab.c: Use C++ exception handling.
6936 * guile/scm-symbol.c: Use C++ exception handling.
6937 * guile/scm-pretty-print.c: Use C++ exception handling.
6938 * guile/scm-ports.c: Use C++ exception handling.
6939 * guile/scm-param.c: Use C++ exception handling.
6940 * guile/scm-math.c: Use C++ exception handling.
6941 * guile/scm-lazy-string.c: Use C++ exception handling.
6942 * guile/scm-frame.c: Use C++ exception handling.
6943 * guile/scm-disasm.c: Use C++ exception handling.
6944 * guile/scm-cmd.c: Use C++ exception handling.
6945 * guile/scm-breakpoint.c: Use C++ exception handling.
6946 * guile/scm-block.c: Use C++ exception handling.
6947 * guile/guile-internal.h: Use C++ exception handling.
6948 * gnu-v3-abi.c: Use C++ exception handling.
6949 * gdbtypes.c: Use C++ exception handling.
6950 * frame.c: Use C++ exception handling.
6951 * frame-unwind.c: Use C++ exception handling.
6952 * fbsd-tdep.c: Use C++ exception handling.
6953 * f-valprint.c: Use C++ exception handling.
6954 * exec.c: Use C++ exception handling.
6955 * event-top.c: Use C++ exception handling.
6956 * event-loop.c: Use C++ exception handling.
6957 * eval.c: Use C++ exception handling.
6958 * dwarf2read.c: Use C++ exception handling.
6959 * dwarf2loc.c: Use C++ exception handling.
6960 * dwarf2-frame.c: Use C++ exception handling.
6961 * dwarf2-frame-tailcall.c: Use C++ exception handling.
6962 * dwarf-index-write.c: Use C++ exception handling.
6963 * dwarf-index-cache.c: Use C++ exception handling.
6964 * dtrace-probe.c: Use C++ exception handling.
6965 * disasm-selftests.c: Use C++ exception handling.
6966 * darwin-nat.c: Use C++ exception handling.
6967 * cp-valprint.c: Use C++ exception handling.
6968 * cp-support.c: Use C++ exception handling.
6969 * cp-abi.c: Use C++ exception handling.
6970 * corelow.c: Use C++ exception handling.
6971 * completer.c: Use C++ exception handling.
6972 * compile/compile-object-run.c: Use C++ exception handling.
6973 * compile/compile-object-load.c: Use C++ exception handling.
6974 * compile/compile-cplus-symbols.c: Use C++ exception handling.
6975 * compile/compile-c-symbols.c: Use C++ exception handling.
6976 * common/selftest.c: Use C++ exception handling.
6977 * common/new-op.c: Use C++ exception handling.
6978 * cli/cli-script.c: Use C++ exception handling.
6979 * cli/cli-interp.c: Use C++ exception handling.
6980 * cli/cli-cmds.c: Use C++ exception handling.
6981 * c-varobj.c: Use C++ exception handling.
6982 * btrace.c: Use C++ exception handling.
6983 * breakpoint.c: Use C++ exception handling.
6984 * break-catch-throw.c: Use C++ exception handling.
6985 * arch-utils.c: Use C++ exception handling.
6986 * amd64-tdep.c: Use C++ exception handling.
6987 * ada-valprint.c: Use C++ exception handling.
6988 * ada-typeprint.c: Use C++ exception handling.
6989 * ada-lang.c: Use C++ exception handling.
6990 * aarch64-tdep.c: Use C++ exception handling.
6991
3d6e9d23
TT
69922019-04-08 Tom Tromey <tom@tromey.com>
6993
6994 * xml-support.c (gdb_xml_parser::parse): Update.
6995 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6996 * value.c (show_convenience): Update.
6997 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6998 (test_parse_flags_qcs): Update.
6999 * thread.c (thr_try_catch_cmd): Update.
7000 * target.c (target_translate_tls_address): Update.
7001 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7002 (info_frame_command_core, frame_apply_command_count): Update.
7003 * rust-exp.y (rust_lex_exception_test): Update.
7004 * riscv-tdep.c (riscv_print_one_register_info): Update.
7005 * remote.c (remote_target::enable_btrace): Update.
7006 * record-btrace.c (record_btrace_enable_warn): Update.
7007 * python/py-utils.c (gdbpy_convert_exception): Update.
7008 * printcmd.c (do_one_display, print_variable_and_value): Update.
7009 * mi/mi-main.c (mi_print_exception): Update.
7010 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7011 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7012 * linux-nat.c (linux_nat_target::attach): Update.
7013 * linux-fork.c (class scoped_switch_fork_info): Update.
7014 * infrun.c (displaced_step_prepare): Update.
7015 * infcall.c (call_function_by_hand_dummy): Update.
7016 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7017 * gnu-v3-abi.c (print_one_vtable): Update.
7018 * frame.c (get_prev_frame_always): Update.
7019 * f-valprint.c (info_common_command_for_block): Update.
7020 * exec.c (try_open_exec_file): Update.
7021 * exceptions.c (print_exception, exception_print)
7022 (exception_fprintf, exception_print_same): Update.
7023 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7024 * dwarf-index-cache.c (index_cache::store)
7025 (index_cache::lookup_gdb_index): Update.
7026 * darwin-nat.c (maybe_cache_shell): Update.
7027 * cp-valprint.c (cp_print_value_fields): Update.
7028 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7029 (gcc_cplus_symbol_address): Update.
7030 * compile/compile-c-symbols.c (gcc_convert_symbol)
7031 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7032 * common/selftest.c: Update.
7033 * common/common-exceptions.h (struct gdb_exception) <message>: Now
7034 a std::string.
7035 (exception_try_scope_entry, exception_try_scope_exit): Don't
7036 declare.
7037 (struct exception_try_scope): Remove.
7038 (TRY): Don't use exception_try_scope.
7039 (struct gdb_exception): Add constructor, operator=.
7040 <what>: New method.
7041 (struct gdb_exception_RETURN_MASK_ALL)
7042 (struct gdb_exception_RETURN_MASK_ERROR)
7043 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7044 (struct gdb_quit_bad_alloc): Update.
7045 * common/common-exceptions.c (exception_none): Change
7046 initializer.
7047 (struct catcher) <state, exception>: Initialize inline.
7048 <prev>: Remove member.
7049 (current_catcher): Remove.
7050 (catchers): New global.
7051 (exceptions_state_mc_init): Simplify.
7052 (catcher_pop): Remove.
7053 (exceptions_state_mc, exceptions_state_mc_catch): Update.
7054 (try_scope_depth, exception_try_scope_entry)
7055 (exception_try_scope_exit): Remove.
7056 (throw_exception_sjlj): Update.
7057 (exception_messages, exception_messages_size): Remove.
7058 (throw_it): Simplify.
7059 (gdb_exception_sliced_copy): Remove.
7060 (throw_exception_cxx): Update.
7061 * cli/cli-script.c (script_from_file): Update.
7062 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7063 Update.
7064 * ada-valprint.c (ada_val_print): Update.
7065 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7066 (create_excep_cond_exprs): Update.
7067
c5c10118
TT
70682019-04-08 Tom Tromey <tom@tromey.com>
7069
7070 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7071 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7072 (TRY, CATCH, END_CATCH): Remove some definitions.
7073 * common/common-exceptions.c: Don't use GDB_XCPT.
7074 (catcher_list_size): Remove.
7075 (throw_exception, throw_it): Simplify.
7076
4de283e4
TT
70772019-04-05 Tom Tromey <tom@tromey.com>
7078
7079 Revert the header-sorting patch.
7080 * ft32-tdep.c: Revert.
7081 * frv-tdep.c: Revert.
7082 * frv-linux-tdep.c: Revert.
7083 * frame.c: Revert.
7084 * frame-unwind.c: Revert.
7085 * frame-base.c: Revert.
7086 * fork-child.c: Revert.
7087 * findvar.c: Revert.
7088 * findcmd.c: Revert.
7089 * filesystem.c: Revert.
7090 * filename-seen-cache.h: Revert.
7091 * filename-seen-cache.c: Revert.
7092 * fbsd-tdep.c: Revert.
7093 * fbsd-nat.h: Revert.
7094 * fbsd-nat.c: Revert.
7095 * f-valprint.c: Revert.
7096 * f-typeprint.c: Revert.
7097 * f-lang.c: Revert.
7098 * extension.h: Revert.
7099 * extension.c: Revert.
7100 * extension-priv.h: Revert.
7101 * expprint.c: Revert.
7102 * exec.h: Revert.
7103 * exec.c: Revert.
7104 * exceptions.c: Revert.
7105 * event-top.c: Revert.
7106 * event-loop.c: Revert.
7107 * eval.c: Revert.
7108 * elfread.c: Revert.
7109 * dwarf2read.h: Revert.
7110 * dwarf2read.c: Revert.
7111 * dwarf2loc.c: Revert.
7112 * dwarf2expr.h: Revert.
7113 * dwarf2expr.c: Revert.
7114 * dwarf2-frame.c: Revert.
7115 * dwarf2-frame-tailcall.c: Revert.
7116 * dwarf-index-write.h: Revert.
7117 * dwarf-index-write.c: Revert.
7118 * dwarf-index-common.c: Revert.
7119 * dwarf-index-cache.h: Revert.
7120 * dwarf-index-cache.c: Revert.
7121 * dummy-frame.c: Revert.
7122 * dtrace-probe.c: Revert.
7123 * disasm.h: Revert.
7124 * disasm.c: Revert.
7125 * disasm-selftests.c: Revert.
7126 * dictionary.c: Revert.
7127 * dicos-tdep.c: Revert.
7128 * demangle.c: Revert.
7129 * dcache.h: Revert.
7130 * dcache.c: Revert.
7131 * darwin-nat.h: Revert.
7132 * darwin-nat.c: Revert.
7133 * darwin-nat-info.c: Revert.
7134 * d-valprint.c: Revert.
7135 * d-namespace.c: Revert.
7136 * d-lang.c: Revert.
7137 * ctf.c: Revert.
7138 * csky-tdep.c: Revert.
7139 * csky-linux-tdep.c: Revert.
7140 * cris-tdep.c: Revert.
7141 * cris-linux-tdep.c: Revert.
7142 * cp-valprint.c: Revert.
7143 * cp-support.c: Revert.
7144 * cp-namespace.c: Revert.
7145 * cp-abi.c: Revert.
7146 * corelow.c: Revert.
7147 * corefile.c: Revert.
7148 * continuations.c: Revert.
7149 * completer.h: Revert.
7150 * completer.c: Revert.
7151 * complaints.c: Revert.
7152 * coffread.c: Revert.
7153 * coff-pe-read.c: Revert.
7154 * cli-out.h: Revert.
7155 * cli-out.c: Revert.
7156 * charset.c: Revert.
7157 * c-varobj.c: Revert.
7158 * c-valprint.c: Revert.
7159 * c-typeprint.c: Revert.
7160 * c-lang.c: Revert.
7161 * buildsym.c: Revert.
7162 * buildsym-legacy.c: Revert.
7163 * build-id.h: Revert.
7164 * build-id.c: Revert.
7165 * btrace.c: Revert.
7166 * bsd-uthread.c: Revert.
7167 * breakpoint.h: Revert.
7168 * breakpoint.c: Revert.
7169 * break-catch-throw.c: Revert.
7170 * break-catch-syscall.c: Revert.
7171 * break-catch-sig.c: Revert.
7172 * blockframe.c: Revert.
7173 * block.c: Revert.
7174 * bfin-tdep.c: Revert.
7175 * bfin-linux-tdep.c: Revert.
7176 * bfd-target.c: Revert.
7177 * bcache.c: Revert.
7178 * ax-general.c: Revert.
7179 * ax-gdb.h: Revert.
7180 * ax-gdb.c: Revert.
7181 * avr-tdep.c: Revert.
7182 * auxv.c: Revert.
7183 * auto-load.c: Revert.
7184 * arm-wince-tdep.c: Revert.
7185 * arm-tdep.c: Revert.
7186 * arm-symbian-tdep.c: Revert.
7187 * arm-pikeos-tdep.c: Revert.
7188 * arm-obsd-tdep.c: Revert.
7189 * arm-nbsd-tdep.c: Revert.
7190 * arm-nbsd-nat.c: Revert.
7191 * arm-linux-tdep.c: Revert.
7192 * arm-linux-nat.c: Revert.
7193 * arm-fbsd-tdep.c: Revert.
7194 * arm-fbsd-nat.c: Revert.
7195 * arm-bsd-tdep.c: Revert.
7196 * arch-utils.c: Revert.
7197 * arc-tdep.c: Revert.
7198 * arc-newlib-tdep.c: Revert.
7199 * annotate.h: Revert.
7200 * annotate.c: Revert.
7201 * amd64-windows-tdep.c: Revert.
7202 * amd64-windows-nat.c: Revert.
7203 * amd64-tdep.c: Revert.
7204 * amd64-sol2-tdep.c: Revert.
7205 * amd64-obsd-tdep.c: Revert.
7206 * amd64-obsd-nat.c: Revert.
7207 * amd64-nbsd-tdep.c: Revert.
7208 * amd64-nbsd-nat.c: Revert.
7209 * amd64-nat.c: Revert.
7210 * amd64-linux-tdep.c: Revert.
7211 * amd64-linux-nat.c: Revert.
7212 * amd64-fbsd-tdep.c: Revert.
7213 * amd64-fbsd-nat.c: Revert.
7214 * amd64-dicos-tdep.c: Revert.
7215 * amd64-darwin-tdep.c: Revert.
7216 * amd64-bsd-nat.c: Revert.
7217 * alpha-tdep.c: Revert.
7218 * alpha-obsd-tdep.c: Revert.
7219 * alpha-nbsd-tdep.c: Revert.
7220 * alpha-mdebug-tdep.c: Revert.
7221 * alpha-linux-tdep.c: Revert.
7222 * alpha-linux-nat.c: Revert.
7223 * alpha-bsd-tdep.c: Revert.
7224 * alpha-bsd-nat.c: Revert.
7225 * aix-thread.c: Revert.
7226 * agent.c: Revert.
7227 * addrmap.c: Revert.
7228 * ada-varobj.c: Revert.
7229 * ada-valprint.c: Revert.
7230 * ada-typeprint.c: Revert.
7231 * ada-tasks.c: Revert.
7232 * ada-lang.c: Revert.
7233 * aarch64-tdep.c: Revert.
7234 * aarch64-ravenscar-thread.c: Revert.
7235 * aarch64-newlib-tdep.c: Revert.
7236 * aarch64-linux-tdep.c: Revert.
7237 * aarch64-linux-nat.c: Revert.
7238 * aarch64-fbsd-tdep.c: Revert.
7239 * aarch64-fbsd-nat.c: Revert.
7240 * aarch32-linux-nat.c: Revert.
7241
d55e5aa6
TT
72422019-04-05 Tom Tromey <tom@tromey.com>
7243
7244 * ft32-tdep.c: Sort headers.
7245 * frv-tdep.c: Sort headers.
7246 * frv-linux-tdep.c: Sort headers.
7247 * frame.c: Sort headers.
7248 * frame-unwind.c: Sort headers.
7249 * frame-base.c: Sort headers.
7250 * fork-child.c: Sort headers.
7251 * findvar.c: Sort headers.
7252 * findcmd.c: Sort headers.
7253 * filesystem.c: Sort headers.
7254 * filename-seen-cache.h: Sort headers.
7255 * filename-seen-cache.c: Sort headers.
7256 * fbsd-tdep.c: Sort headers.
7257 * fbsd-nat.h: Sort headers.
7258 * fbsd-nat.c: Sort headers.
7259 * f-valprint.c: Sort headers.
7260 * f-typeprint.c: Sort headers.
7261 * f-lang.c: Sort headers.
7262 * extension.h: Sort headers.
7263 * extension.c: Sort headers.
7264 * extension-priv.h: Sort headers.
7265 * expprint.c: Sort headers.
7266 * exec.h: Sort headers.
7267 * exec.c: Sort headers.
7268 * exceptions.c: Sort headers.
7269 * event-top.c: Sort headers.
7270 * event-loop.c: Sort headers.
7271 * eval.c: Sort headers.
7272 * elfread.c: Sort headers.
7273 * dwarf2read.h: Sort headers.
7274 * dwarf2read.c: Sort headers.
7275 * dwarf2loc.c: Sort headers.
7276 * dwarf2expr.h: Sort headers.
7277 * dwarf2expr.c: Sort headers.
7278 * dwarf2-frame.c: Sort headers.
7279 * dwarf2-frame-tailcall.c: Sort headers.
7280 * dwarf-index-write.h: Sort headers.
7281 * dwarf-index-write.c: Sort headers.
7282 * dwarf-index-common.c: Sort headers.
7283 * dwarf-index-cache.h: Sort headers.
7284 * dwarf-index-cache.c: Sort headers.
7285 * dummy-frame.c: Sort headers.
7286 * dtrace-probe.c: Sort headers.
7287 * disasm.h: Sort headers.
7288 * disasm.c: Sort headers.
7289 * disasm-selftests.c: Sort headers.
7290 * dictionary.c: Sort headers.
7291 * dicos-tdep.c: Sort headers.
7292 * demangle.c: Sort headers.
7293 * dcache.h: Sort headers.
7294 * dcache.c: Sort headers.
7295 * darwin-nat.h: Sort headers.
7296 * darwin-nat.c: Sort headers.
7297 * darwin-nat-info.c: Sort headers.
7298 * d-valprint.c: Sort headers.
7299 * d-namespace.c: Sort headers.
7300 * d-lang.c: Sort headers.
7301 * ctf.c: Sort headers.
7302 * csky-tdep.c: Sort headers.
7303 * csky-linux-tdep.c: Sort headers.
7304 * cris-tdep.c: Sort headers.
7305 * cris-linux-tdep.c: Sort headers.
7306 * cp-valprint.c: Sort headers.
7307 * cp-support.c: Sort headers.
7308 * cp-namespace.c: Sort headers.
7309 * cp-abi.c: Sort headers.
7310 * corelow.c: Sort headers.
7311 * corefile.c: Sort headers.
7312 * continuations.c: Sort headers.
7313 * completer.h: Sort headers.
7314 * completer.c: Sort headers.
7315 * complaints.c: Sort headers.
7316 * coffread.c: Sort headers.
7317 * coff-pe-read.c: Sort headers.
7318 * cli-out.h: Sort headers.
7319 * cli-out.c: Sort headers.
7320 * charset.c: Sort headers.
7321 * c-varobj.c: Sort headers.
7322 * c-valprint.c: Sort headers.
7323 * c-typeprint.c: Sort headers.
7324 * c-lang.c: Sort headers.
7325 * buildsym.c: Sort headers.
7326 * buildsym-legacy.c: Sort headers.
7327 * build-id.h: Sort headers.
7328 * build-id.c: Sort headers.
7329 * btrace.c: Sort headers.
7330 * bsd-uthread.c: Sort headers.
7331 * breakpoint.h: Sort headers.
7332 * breakpoint.c: Sort headers.
7333 * break-catch-throw.c: Sort headers.
7334 * break-catch-syscall.c: Sort headers.
7335 * break-catch-sig.c: Sort headers.
7336 * blockframe.c: Sort headers.
7337 * block.c: Sort headers.
7338 * bfin-tdep.c: Sort headers.
7339 * bfin-linux-tdep.c: Sort headers.
7340 * bfd-target.c: Sort headers.
7341 * bcache.c: Sort headers.
7342 * ax-general.c: Sort headers.
7343 * ax-gdb.h: Sort headers.
7344 * ax-gdb.c: Sort headers.
7345 * avr-tdep.c: Sort headers.
7346 * auxv.c: Sort headers.
7347 * auto-load.c: Sort headers.
7348 * arm-wince-tdep.c: Sort headers.
7349 * arm-tdep.c: Sort headers.
7350 * arm-symbian-tdep.c: Sort headers.
7351 * arm-pikeos-tdep.c: Sort headers.
7352 * arm-obsd-tdep.c: Sort headers.
7353 * arm-nbsd-tdep.c: Sort headers.
7354 * arm-nbsd-nat.c: Sort headers.
7355 * arm-linux-tdep.c: Sort headers.
7356 * arm-linux-nat.c: Sort headers.
7357 * arm-fbsd-tdep.c: Sort headers.
7358 * arm-fbsd-nat.c: Sort headers.
7359 * arm-bsd-tdep.c: Sort headers.
7360 * arch-utils.c: Sort headers.
7361 * arc-tdep.c: Sort headers.
7362 * arc-newlib-tdep.c: Sort headers.
7363 * annotate.h: Sort headers.
7364 * annotate.c: Sort headers.
7365 * amd64-windows-tdep.c: Sort headers.
7366 * amd64-windows-nat.c: Sort headers.
7367 * amd64-tdep.c: Sort headers.
7368 * amd64-sol2-tdep.c: Sort headers.
7369 * amd64-obsd-tdep.c: Sort headers.
7370 * amd64-obsd-nat.c: Sort headers.
7371 * amd64-nbsd-tdep.c: Sort headers.
7372 * amd64-nbsd-nat.c: Sort headers.
7373 * amd64-nat.c: Sort headers.
7374 * amd64-linux-tdep.c: Sort headers.
7375 * amd64-linux-nat.c: Sort headers.
7376 * amd64-fbsd-tdep.c: Sort headers.
7377 * amd64-fbsd-nat.c: Sort headers.
7378 * amd64-dicos-tdep.c: Sort headers.
7379 * amd64-darwin-tdep.c: Sort headers.
7380 * amd64-bsd-nat.c: Sort headers.
7381 * alpha-tdep.c: Sort headers.
7382 * alpha-obsd-tdep.c: Sort headers.
7383 * alpha-nbsd-tdep.c: Sort headers.
7384 * alpha-mdebug-tdep.c: Sort headers.
7385 * alpha-linux-tdep.c: Sort headers.
7386 * alpha-linux-nat.c: Sort headers.
7387 * alpha-bsd-tdep.c: Sort headers.
7388 * alpha-bsd-nat.c: Sort headers.
7389 * aix-thread.c: Sort headers.
7390 * agent.c: Sort headers.
7391 * addrmap.c: Sort headers.
7392 * ada-varobj.c: Sort headers.
7393 * ada-valprint.c: Sort headers.
7394 * ada-typeprint.c: Sort headers.
7395 * ada-tasks.c: Sort headers.
7396 * ada-lang.c: Sort headers.
7397 * aarch64-tdep.c: Sort headers.
7398 * aarch64-ravenscar-thread.c: Sort headers.
7399 * aarch64-newlib-tdep.c: Sort headers.
7400 * aarch64-linux-tdep.c: Sort headers.
7401 * aarch64-linux-nat.c: Sort headers.
7402 * aarch64-fbsd-tdep.c: Sort headers.
7403 * aarch64-fbsd-nat.c: Sort headers.
7404 * aarch32-linux-nat.c: Sort headers.
7405
699bd4cf
TT
74062019-04-04 Tom Tromey <tom@tromey.com>
7407
7408 * varobj.c (varobj_create): Update.
7409 * rust-exp.y (struct rust_parser) <update_innermost_block,
7410 lookup_symbol>: New methods.
7411 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7412 Rename.
7413 (rust_parser::rust_lookup_type)
7414 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7415 * printcmd.c (display_command, do_one_display): Update.
7416 * parser-defs.h (struct parser_state) <parser_state>: Add
7417 "tracker" parameter.
7418 (block_tracker): New member.
7419 (class innermost_block_tracker) <innermost_block_tracker>: Add
7420 "types" parameter.
7421 <reset>: Remove method.
7422 (innermost_block): Don't declare.
7423 (null_post_parser): Update.
7424 * parse.c (innermost_block): Remove global.
7425 (write_dollar_variable): Update.
7426 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7427 Remove "tracker_types" parameter.
7428 (parse_expression): Add "tracker" parameter.
7429 (parse_expression_for_completion): Update.
7430 (null_post_parser): Add "tracker" parameter.
7431 * p-exp.y: Update rules.
7432 * m2-exp.y: Update rules.
7433 * language.h (struct language_defn) <la_post_parser>: Add
7434 "tracker" parameter.
7435 * go-exp.y: Update rules.
7436 * f-exp.y: Update rules.
7437 * expression.h (parse_expression, parse_exp_1): Add "tracker"
7438 parameter.
7439 * d-exp.y: Update rules.
7440 * c-exp.y: Update rules.
7441 * breakpoint.c (set_breakpoint_condition): Create an
7442 innermost_block_tracker.
7443 (watch_command_1): Likewise.
7444 * ada-lang.c (resolve): Add "tracker" parameter.
7445 (resolve_subexp): Likewise.
7446 * ada-exp.y (write_var_from_sym): Update.
7447
dac43e32
TT
74482019-04-04 Tom Tromey <tom@tromey.com>
7449
7450 * type-stack.h: New file.
7451 * type-stack.c: New file.
7452 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7453 type-stack.h.
7454 (insert_into_type_stack, insert_type, push_type, push_type_int)
7455 (insert_type_address_space, pop_type, pop_type_int)
7456 (pop_typelist, pop_type_stack, append_type_stack)
7457 (push_type_stack, get_type_stack, push_typelist)
7458 (follow_type_instance_flags, follow_types): Don't declare.
7459 * parse.c (type_stack): Remove global.
7460 (parse_exp_in_context): Update.
7461 (insert_into_type_stack, insert_type, push_type, push_type_int)
7462 (insert_type_address_space, pop_type, pop_type_int)
7463 (pop_typelist, pop_type_stack, append_type_stack)
7464 (push_type_stack, get_type_stack, push_typelist)
7465 (follow_type_instance_flags, follow_types): Remove (moved to
7466 type-stack.c).
7467 * f-exp.y (type_stack): New global.
7468 Update rules.
7469 (push_kind_type, f_parse): Update.
7470 * d-exp.y (type_stack): New global.
7471 Update rules.
7472 (d_parse): Update.
7473 * c-exp.y (struct c_parse_state) <type_stack>: New member.
7474 Update rules.
7475 * Makefile.in (COMMON_SFILES): Add type-stack.c.
7476 (HFILES_NO_SRCDIR): Add type-stack.h.
7477
2a612529
TT
74782019-04-04 Tom Tromey <tom@tromey.com>
7479
7480 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7481 (rust_parser::convert_ast_to_expression, rust_parse)
7482 (rust_lex_test_completion, rust_lex_tests): Update.
7483 * parser-defs.h (struct expr_completion_state): New.
7484 (struct parser_state) <parser_state>: Add completion parameter.
7485 <mark_struct_expression, mark_completion_tag>: New methods.
7486 <parse_completion, m_completion_state>: New members.
7487 (prefixify_expression, null_post_parser): Update.
7488 (mark_struct_expression, mark_completion_tag): Don't declare.
7489 * parse.c (parse_completion, expout_last_struct)
7490 (expout_tag_completion_type, expout_completion_name): Remove
7491 globals.
7492 (parser_state::mark_struct_expression)
7493 (parser_state::mark_completion_tag): Now methods.
7494 (prefixify_expression): Add last_struct parameter.
7495 (prefixify_subexp): Likewise.
7496 (parse_exp_1): Update.
7497 (parse_exp_in_context): Add cstate parameter. Update.
7498 (parse_expression_for_completion): Create an
7499 expr_completion_state.
7500 (null_post_parser): Add "completion" parameter.
7501 * p-exp.y: Update rules.
7502 (yylex): Update.
7503 * language.h (struct language_defn) <la_post_parser>: Add
7504 "completing" parameter.
7505 * go-exp.y: Update rules.
7506 (lex_one_token): Update.
7507 * expression.h (parse_completion): Don't declare.
7508 * d-exp.y: Update rules.
7509 (lex_one_token): Update rules.
7510 * c-exp.y: Update rules.
7511 (lex_one_token): Update.
7512 * ada-lang.c (resolve): Add "parse_completion" parameter.
7513 (resolve_subexp): Likewise.
7514 (ada_resolve_function): Likewise.
7515
43476f0b
TT
75162019-04-04 Tom Tromey <tom@tromey.com>
7517
7518 * parser-defs.h (struct parser_state) <start_arglist,
7519 end_arglist>: New methods.
7520 <arglist_len, m_funcall_chain>: New members.
7521 (arglist_len, start_arglist, end_arglist): Don't declare.
7522 * parse.c (arglist_len, funcall_chain): Remove global.
7523 (start_arglist, end_arglist): Remove functions.
7524 (parse_exp_in_context): Update.
7525 * p-exp.y: Update rules.
7526 * m2-exp.y: Update rules.
7527 * go-exp.y: Update rules.
7528 * f-exp.y: Update rules.
7529 * d-exp.y: Update rules.
7530 * c-exp.y: Update rules.
7531
5776fca3
TT
75322019-04-04 Tom Tromey <tom@tromey.com>
7533
7534 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7535 lex_operator, push_back>: New methods.
7536 Update all rules.
7537 (rust_parser::lex_hex, lex_escape): Rename and update.
7538 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7539 (rust_parser::lex_operator): Rename and update.
7540 (rust_parser::lex_number, rustyylex, rustyyerror)
7541 (rust_lex_test_init, rust_lex_test_sequence)
7542 (rust_lex_test_push_back, rust_lex_tests): Update.
7543 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7544 parameter.
7545 <lexptr, prev_lexptr>: New members.
7546 (lexptr, prev_lexptr): Don't declare.
7547 * parse.c (lexptr, prev_lexptr): Remove globals.
7548 (parse_exp_in_context): Update.
7549 * p-exp.y (yylex, yyerror): Update.
7550 * m2-exp.y (parse_number, yylex, yyerror): Update.
7551 * go-exp.y (lex_one_token, yyerror): Update.
7552 * f-exp.y (match_string_literal, yylex, yyerror): Update.
7553 * d-exp.y (lex_one_token, yyerror): Update.
7554 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7555 (lex_one_token, yyerror): Update.
7556 * ada-lex.l (YY_INPUT): Update.
7557 (rewind_to_char): Update.
7558 * ada-exp.y (yyerror): Update.
7559
8621b685
TT
75602019-04-04 Tom Tromey <tom@tromey.com>
7561
7562 * rust-exp.y (rustyylex, rust_lex_tests): Update.
7563 * parser-defs.h (struct parser_state) <parser_state>: Add new
7564 parameter.
7565 <comma_terminates>: New member.
7566 (comma_terminates): Don't declare global.
7567 * parse.c (comma_terminates): Remove global.
7568 (parse_exp_in_context): Update.
7569 * p-exp.y (yylex): Update.
7570 * m2-exp.y (yylex): Update.
7571 * go-exp.y (lex_one_token): Update.
7572 * f-exp.y (yylex): Update.
7573 * d-exp.y (lex_one_token): Update.
7574 * c-exp.y (lex_one_token): Update.
7575 * ada-lex.l: Update.
7576
28aaf3fd
TT
75772019-04-04 Tom Tromey <tom@tromey.com>
7578
7579 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7580 (rustyylex, rust_lex_test_init, rust_lex_test_one)
7581 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7582 * parser-defs.h (paren_depth): Don't declare.
7583 * parse.c (paren_depth): Remove global.
7584 (parse_exp_in_context): Update.
7585 * p-exp.y (paren_depth): New global.
7586 (pascal_parse): Initialize it.
7587 * m2-exp.y (paren_depth): New global.
7588 (m2_parse): Initialize it.
7589 * go-exp.y (paren_depth): New global.
7590 (go_parse): Initialize it.
7591 * f-exp.y (paren_depth): New global.
7592 (f_parse): Initialize it.
7593 * d-exp.y (paren_depth): New global.
7594 (d_parse): Initialize it.
7595 * c-exp.y (paren_depth): New global.
7596 (c_parse): Initialize it.
7597 * ada-lex.l (paren_depth): New global.
7598 (lexer_init): Initialize it.
7599
1e58a4a4
TT
76002019-04-04 Tom Tromey <tom@tromey.com>
7601
7602 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7603 (rust_parser::convert_ast_to_type)
7604 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7605 * parser-defs.h (struct parser_state) <parser_state>: Add
7606 parameters. Initialize new members.
7607 <expression_context_block, expression_context_pc>: New members.
7608 * parse.c (expression_context_block, expression_context_pc):
7609 Remove globals.
7610 (parse_exp_in_context): Update.
7611 * p-exp.y: Update all rules.
7612 (yylex): Update.
7613 * m2-exp.y: Update all rules.
7614 (yylex): Update.
7615 * go-exp.y (yylex): Update.
7616 * f-exp.y (yylex): Update.
7617 * d-exp.y: Update all rules.
7618 (yylex): Update.
7619 * c-exp.y: Update all rules.
7620 (lex_one_token, classify_name, yylex, c_parse): Update.
7621 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7622
37eedb39
TT
76232019-04-04 Tom Tromey <tom@tromey.com>
7624
7625 * gdbarch.h, gdbarch.c: Rebuild.
7626 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7627 * stap-probe.h:
7628 (struct stap_parse_info): Replace "parser_state" with
7629 "expr_builder".
7630 * parser-defs.h (struct expr_builder): Rename from "parser_state".
7631 (parser_state): New class.
7632 * parse.c (expr_builder): Rename.
7633 (expr_builder::release): Rename.
7634 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7635 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7636 (write_exp_elt_longcst, write_exp_elt_floatcst)
7637 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7638 (write_exp_string_vector, write_exp_bitstring)
7639 (write_exp_msymbol, mark_struct_expression)
7640 (write_dollar_variable)
7641 (insert_type_address_space, increase_expout_size): Replace
7642 "parser_state" with "expr_builder".
7643 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7644 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7645 "parser_state" with "expr_builder".
7646
73923d7e
TT
76472019-04-04 Tom Tromey <tom@tromey.com>
7648
7649 * rust-exp.y: Replace "parse_language" with method call.
7650 * p-exp.y:
7651 (yylex): Replace "parse_language" with method call.
7652 * m2-exp.y:
7653 (yylex): Replace "parse_language" with method call.
7654 * go-exp.y (classify_name): Replace "parse_language" with method
7655 call.
7656 * f-exp.y (yylex): Replace "parse_language" with method call.
7657 * d-exp.y (lex_one_token): Replace "parse_language" with method
7658 call.
7659 * c-exp.y:
7660 (lex_one_token, classify_name, yylex): Replace "parse_language"
7661 with method call.
7662 * ada-exp.y (find_primitive_type, type_char)
7663 (type_system_address): Replace "parse_language" with method call.
7664
fa9f5be6
TT
76652019-04-04 Tom Tromey <tom@tromey.com>
7666
7667 * rust-exp.y: Replace "parse_gdbarch" with method call.
7668 * parse.c (write_dollar_variable, insert_type_address_space):
7669 Replace "parse_gdbarch" with method call.
7670 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7671 call.
7672 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7673 call.
7674 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7675 "parse_gdbarch" with method call.
7676 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7677 with method call.
7678 * f-exp.y (parse_type, parse_f_type, yylex): Replace
7679 "parse_gdbarch" with method call.
7680 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7681 "parse_gdbarch" with method call.
7682 * c-exp.y (parse_type, parse_number, classify_name): Replace
7683 "parse_gdbarch" with method call.
7684 * ada-lex.l: Replace "parse_gdbarch" with method call.
7685 * ada-exp.y (parse_type, find_primitive_type, type_char)
7686 (type_system_address): Replace "parse_gdbarch" with method call.
7687
1201a264
TT
76882019-04-04 Tom Tromey <tom@tromey.com>
7689
7690 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7691 * stap-probe.c (stap_parse_argument): Update.
7692 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7693 initial_size parameter.
7694 * rust-exp.y (rust_lex_tests): Update.
7695 * parse.c (parser_state): Update.
7696 (parse_exp_in_context): Update.
7697 * parser-defs.h (struct parser_state) <parser_state>: Remove
7698 "initial_size" parameter.
7699
e3980ce2
TT
77002019-04-04 Tom Tromey <tom@tromey.com>
7701
7702 * parser-defs.h (increase_expout_size): Don't declare.
7703 * parse.c (increase_expout_size): Now static.
7704
e9f8e3f1
TS
77052019-04-04 Thomas Schwinge <thomas@codesourcery.com>
7706
7707 * gnu-nat.c (gnu_nat_target::wait): Fix
7708 target_waitstatus_to_string call.
7709
d7df6549
AB
77102019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7711
7712 * eval.c (evaluate_subexp_standard): Handle internal functions
7713 during Fortran function call handling.
7714
8bdc1658
AB
77152019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7716
7717 * NEWS: Mention new internal functions.
7718 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7719 (read_base_type): Use dwarf2_init_complex_target_type.
7720 * value.c (creal_internal_fn): New function.
7721 (cimag_internal_fn): New function.
7722 (_initialize_values): Register new internal functions.
7723
c29705b7
PW
77242019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7725
7726 * infrun.c (stop_all_threads): If debug_infrun, always
7727 trace the wait status after wait_one, using
7728 target_waitstatus_to_string and target_pid_to_str.
7729 (handle_inferior_event): Replace various trace of
7730 wait status kind by a single trace.
7731 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7732 wait status kind image by target_waitstatus_to_string.
7733 * target/waitstatus.c (target_waitstatus_to_string): Fix
7734 obsolete comment.
7735
05caa1d2
TT
77362019-04-01 Tom Tromey <tromey@adacore.com>
7737
7738 PR symtab/23331:
7739 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7740
9d1447e0
SDJ
77412019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
7742 Pedro Alves <palves@redhat.com>
7743
7744 * top.c (quit_force): Call 'finalize_values'.
7745 * value.c (finalize_values): New function.
7746 * value.h (finalize_values): Declare.
7747
7734102d
EZ
77482019-03-30 Eli Zaretskii <eliz@gnu.org>
7749
7750 * NEWS: Announce $_gdb_major and $_gdb_minor.
7751
7752 * top.c (init_gdb_version_vars): New function.
7753 (gdb_init): Call init_gdb_version_vars.
7754
188e1fa9
TT
77552019-03-29 Tom Tromey <tromey@adacore.com>
7756
7757 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
7758 help text. Remove dead code.
7759
2880242d
KS
77602019-03-29 Keith Seitz <keiths@redhat.com>
7761
7762 From Siddhesh Poyarekar:
7763 * f-lang.h (f77_get_upperbound): Return LONGEST.
7764 (f77_get_lowerbound): Likewise.
7765 * f-typeprint.c (f_type_print_varspec_suffix): Expand
7766 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
7767 print them.
7768 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
7769 plongest to format print it.
7770 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7771 (f77_get_upperbound): Likewise.
7772 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7773 LOWER_BOUND to LONGEST.
7774 (f77_create_arrayprint_offset_tbl): Likewise.
7775
cc1defb1
KS
77762019-03-29 Keith Seitz <keiths@redhat.com>
7777
7778 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7779 %s/pulongest for TYPE_LENGTH instead of %d in format
7780 strings.
7781 * ada-typerint.c (ada_print_type): Likewise.
7782 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7783 * compile/compile-c-support.c (generate_register_struct): Likewise.
7784 * gdbtypes.c (recursive_dump_type): Likewise.
7785 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7786 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
7787 instead of %d in format strings.
7788 * riscv-tdep.c (riscv_type_alignment): Cast second argument
7789 to std::min to ULONGEST.
7790 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7791 instead of %d in format strings.
7792 * tracepoint.c (info_scope_command): Likewise.
7793 * typeprint.c (print_offset_data::update)
7794 (print_offset_data::finish): Likewise.
7795 * xtensa-tdep.c (xtensa_store_return_value)
7796 (xtensa_push_dummy_call): Likewise.
7797
e432ccf1
JT
77982019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
7799
7800 * windows-nat.c (display_selector): Fixed format specifications
7801 for 64-bit Cygwin.
7802
65d2b333
PW
78032019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7804
7805 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7806
f489207e
SL
78072019-03-28 Sandra Loosemore <sandra@codesourcery.com>
7808
7809 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7810 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7811 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7812 (nios2_linux_init_abi): Install it.
7813
bffa1015
AH
78142019-03-28 Alan Hayward <alan.hayward@arm.com>
7815
7816 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7817
fc96163a
AH
78182019-03-28 Alan Hayward <alan.hayward@arm.com>
7819
7820 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7821
20dc7e9b
PW
78222019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7823 Tom Tromey <tromey@adacore.com>
7824
7825 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7826
7f5331a8
JB
78272019-03-26 Joel Brobecker <brobecker@adacore.com>
7828
7829 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7830 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7831 method to compute the bounds of range types. Also print "[evaluated]"
7832 if the bounds' values come from a dynamic evaluation.
7833
18c77628
AB
78342019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
7835
7836 * cp-valprint.c (cp_print_value_fields): Don't print trailing
7837 whitespace when pretty printing is on.
7838
53c973f2
AH
78392019-03-26 Alan Hayward <alan.hayward@arm.com>
7840
e79be6e5 7841 * ppc-linux-nat.c: Add include.
53c973f2 7842
d851aa71
AH
78432019-03-26 Alan Hayward <alan.hayward@arm.com>
7844
e79be6e5 7845 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 7846
2fe7bab7
AH
78472019-03-26 Alan Hayward <alan.hayward@arm.com>
7848
e79be6e5 7849 * arm-linux-nat.c: Add include.
2fe7bab7 7850
068ef30e
SM
78512019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
7852
7853 * source-cache.c (source_cache::get_source_lines): Re-read
7854 fullname after calling open_source_file.
7855
81a24d04
JB
78562019-03-25 John Baldwin <jhb@FreeBSD.org>
7857
7858 * NEWS: Mention TLS support for FreeBSD.
7859
79e7ae11
TT
78602019-03-25 Tom Tromey <tromey@adacore.com>
7861
7862 * minsyms.c (BUNCH_SIZE): Update comment.
7863 (~minimal_symbol_reader): Remove old comment.
7864 (compact_minimal_symbols): Update comment.
7865 (minimal_symbol_reader::install): Remove old comment. Update
7866 other comments.
7867
d45963c2
AH
78682019-03-25 Alan Hayward <alan.hayward@arm.com>
7869
7870 * s390-linux-nat.c: Add include.
7871
0f83012e
AH
78722019-03-25 Alan Hayward <alan.hayward@arm.com>
7873
7874 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7875 Call linux_get_hwcap.
7876 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7877 Likewise.
7878 (aarch64_linux_get_hwcap): Remove function.
7879 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7880 declaration.
7881 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7882 linux_get_hwcap.
7883 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7884 * linux-tdep.c (linux_get_hwcap): Add function.
7885 (linux_get_hwcap2): Likewise.
7886 * linux-tdep.h (linux_get_hwcap): Add declaration.
7887 (linux_get_hwcap2): Likewise.
7888 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7889 (ppc_linux_get_hwcap2): Likewise.
7890 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7891 linux_get_hwcap.
7892 (ppc_linux_nat_target::insert_watchpoint): Likewise.
7893 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7894 (ppc_linux_nat_target::read_description): Likewise.
7895 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7896 * s390-linux-nat.c: Likewise.
7897 * s390-linux-tdep.c (s390_core_read_description): Likewise.
7898
6640a367
TT
78992019-03-24 Tom Tromey <tom@tromey.com>
7900
7901 * ada-lang.c (standard_lookup): Simplify initialization.
7902 (ada_lookup_symbol_nonlocal): Simplify return.
7903 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7904 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7905 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7906 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7907 initialization.
7908 * solib.c (solib_global_lookup): Simplify.
7909 * symtab.c (null_block_symbol): Remove.
7910 (symbol_cache_lookup): Simplify returns.
7911 (lookup_language_this): Simplify returns.
7912 (lookup_symbol_aux): Simplify return.
7913 (lookup_local_symbol): Simplify returns.
7914 (lookup_global_symbol_from_objfile): Simplify return.
7915 (lookup_symbol_in_objfile_symtabs)
7916 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7917 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7918 (lookup_static_symbol, lookup_global_symbol): Simplify return.
7919 * cp-namespace.c (cp_lookup_bare_symbol)
7920 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7921 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7922 (cp_lookup_nested_symbol): Don't use null_block_symbol.
7923 (cp_lookup_symbol_via_imports): Simplify initialization.
7924 (find_symbol_in_baseclass): Likewise.
7925 * symtab.h (null_block_symbol): Remove.
7926 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7927 (d_lookup_nested_symbol, d_lookup_symbol_imports)
7928 (d_lookup_symbol_module): Likewise.
7929 (find_symbol_in_baseclass): Simplify initialization.
7930
a930ebcd
TT
79312019-03-24 Tom Tromey <tom@tromey.com>
7932
7933 * expression.h: Don't include symtab.h.
7934 (struct block): Forward declare.
7935
582942f4
TT
79362019-03-24 Tom Tromey <tom@tromey.com>
7937
7938 * c-exp.y (typebase): Remove casts.
7939 * gdbtypes.c (lookup_unsigned_typename, )
7940 (lookup_signed_typename): Remove cast.
7941 * eval.c (parse_to_comma_and_eval): Remove cast.
7942 * parse.c (write_dollar_variable): Remove cast.
7943 * block.h (struct block) <superblock>: Now const.
7944 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7945 * psymtab.c (psym_map_matching_symbols): Make "block" const.
7946 (map_block): Make "block" const.
7947 * symfile.h (struct quick_symbol_functions)
7948 <map_matching_symbols>: Constify block argument to "callback".
7949 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7950 const.
7951 (find_pc_sect_compunit_symtab): Make "b" const.
7952 (find_symbol_at_address): Likewise.
7953 (search_symbols): Likewise.
7954 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7955 (dw2_debug_names_lookup_symbol): Likewise.
7956 (dw2_map_matching_symbols): Update.
7957 * p-valprint.c (pascal_val_print): Remove "block".
7958 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7959 (aux_add_nonlocal_symbols): Make "block" const.
7960 (resolve_subexp): Remove cast.
7961 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7962 const.
7963 (iterate_over_file_blocks): Likewise.
7964 * f-exp.y (%union) <bval>: Remove.
7965 * coffread.c (patch_opaque_types): Make "b" const.
7966 * spu-tdep.c (spu_catch_start): Make "block" const.
7967 * c-valprint.c (print_unpacked_pointer): Remove "block".
7968 * symmisc.c (dump_symtab_1): Make "b" const.
7969 (block_depth): Make "block" const.
7970 * d-exp.y (%union) <bval>: Remove.
7971 * cp-support.h (cp_lookup_rtti_type): Update.
7972 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7973 * psymtab.c (psym_lookup_symbol): Make "block" const.
7974 (maintenance_check_psymtabs): Make "b" const.
7975 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7976 (enumerate_locals, enumerate_args): Update.
7977 * python/py-symtab.c (stpy_global_block): Make "block" const.
7978 (stpy_static_block): Likewise.
7979 * inline-frame.c (block_starting_point_at): Make "new_block"
7980 const.
7981 * block.c (find_block_in_blockvector): Make return type const.
7982 (blockvector_for_pc_sect): Make "b" const.
7983 (find_block_in_blockvector): Make "b" const.
7984
7ad417dd
TT
79852019-03-23 Tom Tromey <tom@tromey.com>
7986
7987 * varobj.c (varobj_create): Update.
7988 * symfile.c (clear_symtab_users): Don't reset innermost_block.
7989 * printcmd.c (display_command, do_one_display): Don't reset
7990 innermost_block.
7991 * parser-defs.h (enum innermost_block_tracker_type): Move to
7992 expression.h.
7993 (innermost_block): Update comment.
7994 * parse.c (parse_exp_1): Add tracker_types parameter.
7995 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
7996 tracker_types parameter. Reset innermost_block.
7997 (parse_exp_in_context): Remove.
7998 (parse_expression_for_completion): Update.
7999 * objfiles.c (~objfile): Don't reset expression_context_block or
8000 innermost_block.
8001 * expression.h (enum innermost_block_tracker_type): Move from
8002 parser-defs.h.
8003 (parse_exp_1): Add tracker_types parameter.
8004 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8005 reset innermost_block.
8006
b366c208
TT
80072019-03-23 Tom Tromey <tom@tromey.com>
8008
8009 * objfiles.h: Include bcache.h.
8010
9bb9b2f9
TT
80112019-03-23 Tom Tromey <tom@tromey.com>
8012
8013 * linespec.c (get_current_search_block): Use
8014 scoped_restore_current_language.
8015 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8016
59c28372
AH
80172019-03-22 Alan Hayward <alan.hayward@arm.com>
8018 Jiong Wang <jiong.wang@arm.com>
8019
8020 * aarch64-linux-tdep.c
8021 (aarch64_linux_iterate_over_regset_sections): Check for pauth
8022 section.
8023 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8024
17e116a7
AH
80252019-03-22 Alan Hayward <alan.hayward@arm.com>
8026 Jiong Wang <jiong.wang@arm.com>
8027
8028 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8029 instructions.
8030 (aarch64_analyze_prologue_test): Add PACIASP test.
8031 (aarch64_prologue_prev_register): Unmask PC value.
8032
11e1b75f
AH
80332019-03-22 Alan Hayward <alan.hayward@arm.com>
8034 Jiong Wang <jiong.wang@arm.com>
8035
8036 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8037 (aarch64_dwarf2_prev_register): Unmask PC value.
8038 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8039 (aarch64_execute_dwarf_cfa_vendor_op): Check for
8040 DW_CFA_AARCH64_negate_ra_state.
8041 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8042
34dcc7cf
AH
80432019-03-22 Alan Hayward <alan.hayward@arm.com>
8044 Jiong Wang <jiong.wang@arm.com>
8045
8046 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8047 registers.
8048 (aarch64_pseudo_register_name): Likewise.
8049 (aarch64_pseudo_register_type): Likewise.
8050 (aarch64_pseudo_register_reggroup_p): Likewise.
8051 (aarch64_gdbarch_init): Add pauth registers.
8052 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8053 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8054 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8055 (struct gdbarch_tdep): Add regnum for ra_state.
8056
1ef53e6b
AH
80572019-03-22 Alan Hayward <alan.hayward@arm.com>
8058 Jiong Wang <jiong.wang@arm.com>
8059
8060 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8061
76bed0fd
AH
80622019-03-22 Alan Hayward <alan.hayward@arm.com>
8063 Jiong Wang <jiong.wang@arm.com>
8064
8065 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8066 function.
8067 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8068 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8069 (aarch64_gdbarch_init): Add puth registers.
8070 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8071 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8072 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8073
ee4fbcfa
AH
80742019-03-22 Alan Hayward <alan.hayward@arm.com>
8075 Jiong Wang <jiong.wang@arm.com>
8076
8077 * aarch64-linux-nat.c
8078 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8079 * aarch64-linux-tdep.c
8080 (aarch64_linux_core_read_description): Likewise.
8081 (aarch64_linux_get_hwcap): New function.
8082 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8083 (aarch64_linux_get_hwcap): New declaration.
8084
6dc0ebde
AH
80852019-03-22 Alan Hayward <alan.hayward@arm.com>
8086 Jiong Wang <jiong.wang@arm.com>
8087
8088 * aarch64-linux-nat.c
8089 (aarch64_linux_nat_target::read_description): Add pauth param.
8090 * aarch64-linux-tdep.c
8091 (aarch64_linux_core_read_description): Likewise.
8092 * aarch64-tdep.c (struct target_desc): Add in pauth.
8093 (aarch64_read_description): Add pauth param.
8094 (aarch64_gdbarch_init): Likewise.
8095 * aarch64-tdep.h (aarch64_read_description): Likewise.
8096 * arch/aarch64.c (aarch64_create_target_description): Likewise.
8097 * arch/aarch64.h (aarch64_create_target_description): Likewise.
8098 * features/Makefile: Add new files.
8099 * features/aarch64-pauth.c: New file.
8100 * features/aarch64-pauth.xml: New file.
8101
595915c1
TT
81022019-03-20 Tom Tromey <tromey@adacore.com>
8103
8104 * infrun.c (handle_inferior_event): Rename from
8105 handle_inferior_event_1. Create a scoped_value_mark.
8106 (handle_inferior_event): Remove.
8107
4c7d57e7
TT
81082019-03-19 Tom Tromey <tromey@adacore.com>
8109
8110 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8111 * infrun.h (print_stop_event): Add "displays" parameter.
8112 * infrun.c (print_stop_event): Add "displays" parameter.
8113
cb246234
PA
81142019-03-19 Pedro Alves <palves@redhat.com>
8115
8116 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8117 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
8118 to -1. Fix TABs vs spaces.
8119 (tui_ui_out::tui_ui_out): Don't initialize fields here.
8120 * tui/tui-out.h (tui_ui_out) Add intro comments.
8121 <m_line, m_start_of_line>: In-class initialize, and add describing
8122 comment.
8123
3a0e45b2
AH
81242019-03-18 Alan Hayward <alan.hayward@arm.com>
8125
8126 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8127 variable names.
8128 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8129
5371b850
PA
81302019-03-18 Pedro Alves <palves@redhat.com>
8131 Eli Zaretskii <eliz@gnu.org>
8132
8133 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8134 m_line and m_start_of_line.
8135
b17c4cd0
EZ
81362019-03-18 Eli Zaretskii <eliz@gnu.org>
8137
8138 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8139 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8140 it returns a newline. This fixes a regression in TU mode, whereby
8141 the next line is output on the same screen line as the user input.
8142
4bd56d18
TT
81432019-03-18 Tom Tromey <tromey@adacore.com>
8144
8145 * minsyms.c (minimal_symbol_reader::install): Remove call to
8146 obstack_blank.
8147
55c10aca
PA
81482019-03-18 Pedro Alves <palves@redhat.com>
8149
8150 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8151 New globals.
8152 (apply_style): New, factored out from ...
8153 (apply_ansi_escape): ... this. Handle reverse video mode.
8154 (tui_set_reverse_mode): New function.
8155 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8156 * tui/tui-winsource.c (tui_show_source_line): Use
8157 tui_set_reverse_mode instead of setting A_STANDOUT.
8158 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8159 New setter methods.
8160
647bb750
HD
81612019-03-18 Hannes Domani <ssbssa@yahoo.de>
8162
8163 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8164 Handle tabs.
8165
bff8c71f
TT
81662019-03-18 Tom Tromey <tromey@adacore.com>
8167
8168 * ada-lang.c (empty_array): Add "high" parameter.
8169 (ada_evaluate_subexp): Update.
8170
58785d98
ST
81712019-03-17 Sergei Trofimovich <siarheit@google.com>
8172
8173 * unittests/string_view-selftests.c: Define
8174 _initialize_string_view_selftests unconditionally.
8175
d4cbef22
ВМ
81762019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8177
8178 PR gdb/24350
8179 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8180
fce4c071
ВМ
81812019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8182
8183 PR gdb/24351
8184 * windows-nat.c (display_selector): Fix format specifiers.
8185
f7f0a123
EZ
81862019-03-17 Eli Zaretskii <eliz@gnu.org>
8187
8188 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8189 tui_refill_source_window instead of tui_refresh_win, to update the
8190 current execution line. This fixes redisplay of the current line
8191 when stepping through the code with "next" or "step".
8192
ab42892f
EZ
81932019-03-16 Eli Zaretskii <eliz@gnu.org>
8194
8195 * source-cache.c (source_cache::get_source_lines): Call
8196 find_source_lines to initialize s->nlines. This fixes vertical
8197 scrolling of TUI source window when the DOWN arrow is pressed.
8198
8d8c087f
PW
81992019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8200
8201 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8202 linux-thread-db.c (_initialize_thread_db): Likewise.
8203
798e1c30
EZ
82042019-03-16 Eli Zaretskii <eliz@gnu.org>
8205
8206 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8207 wclrtoeol in tui_show_source_line". This reverts changes made in
8208 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8209
eefba3da
TT
82102019-03-15 Tom Tromey <tom@tromey.com>
8211
8212 * symtab.h (struct minimal_symbol): Derive from
8213 general_symbol_info.
8214 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8215 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8216 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8217 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8218 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8219 (MSYMBOL_SEARCH_NAME): Update.
8220 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8221 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8222 * minsyms.c (minimal_symbol_reader::record_full): Update.
8223
0de2420c
TT
82242019-03-15 Tom Tromey <tom@tromey.com>
8225
8226 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8227
042d75e4
TT
82282019-03-15 Tom Tromey <tom@tromey.com>
8229
8230 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8231 unique_xmalloc_ptr.
8232 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8233 Update.
8234 * minsyms.c (lookup_minimal_symbol_by_pc_section)
8235 (build_minimal_symbol_hash_tables)
8236 (minimal_symbol_reader::install): Update.
8237
db92718b
TT
82382019-03-15 Tom Tromey <tom@tromey.com>
8239
8240 * symtab.c (create_demangled_names_hash): Update.
8241 (symbol_set_names): Update.
8242 * objfiles.h (struct objfile_per_bfd_storage)
8243 <demangled_names_hash>: Now an htab_up.
8244 * objfiles.c (objfile_per_bfd_storage): Simplify.
8245
d6797f46
TT
82462019-03-15 Tom Tromey <tom@tromey.com>
8247
8248 * objfiles.h (struct objfile_per_bfd_storage): Declare
8249 destructor.
8250 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8251 New.
8252 (get_objfile_bfd_data): Use new. Don't initialize
8253 language_of_main.
8254 (free_objfile_per_bfd_storage): Remove.
8255 (objfile_bfd_data_free, objfile::~objfile): Use delete.
8256
741d7538
TT
82572019-03-15 Tom Tromey <tom@tromey.com>
8258
8259 * symfile.c (reread_symbols): Update.
8260 * objfiles.c (objfile::objfile): Update.
8261 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8262 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8263 comment.
8264 (minimal_symbol_reader::install): Update.
8265 (terminate_minimal_symbol_table): Remove.
8266 * jit.c (jit_object_close_impl): Update.
8267
788c80d1
TT
82682019-03-15 Tom Tromey <tom@tromey.com>
8269
8270 * minsyms.c (minimal_symbol_reader::record_full): Remove some
8271 initializations.
8272
1b7a07cb
TT
82732019-03-15 Tom Tromey <tom@tromey.com>
8274
8275 * objfiles.h (struct objfile_per_bfd_storage)
8276 <demangled_hash_languages>: Now a bitset.
8277 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8278 (lookup_minimal_symbol): Update.
8279
3db066bc
TT
82802019-03-15 Tom Tromey <tom@tromey.com>
8281
8282 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8283 Don't return the symbol.
8284 * coffread.c (record_minimal_symbol): Use record_full.
8285
3fff2c37
EZ
82862019-03-14 Eli Zaretskii <eliz@gnu.org>
8287
8288 The MS-Windows port of ncurses fails to switch to a color pair if
8289 one or both of the colors are the implicit default colors. This
8290 change records the default colors when TUI is initialized, and
8291 then specifies them explicitly when a color pair uses the default
8292 colors. This allows color styling in TUI mode on MS-Windows.
8293
8294 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
8295 ncurses_norm_attr.
8296 (tui_initialize_io) [__MINGW32__]: Record the default terminal
8297 colors in ncurses_norm_attr.
8298 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8299 "none", replace it with the default color recorded in
8300 ncurses_norm_attr.
8301
3b336828
TT
83022019-03-14 Tom Tromey <tromey@adacore.com>
8303
8304 * source-cache.h (class source_cache) <get_source_lines>: Return
8305 std::string.
8306 * source-cache.c (source_cache::extract_lines): Handle case where
8307 first_pos==npos. Return std::string.
8308 (source_cache::get_source_lines): Update.
8309
d085f989
TT
83102019-03-14 Tom Tromey <tromey@adacore.com>
8311
8312 * NEWS: Add item for "style sources" commands.
8313 * source-cache.c (source_cache::get_source_lines): Check
8314 source_styling.
8315 * cli/cli-style.c (source_styling): New global.
8316 (_initialize_cli_style): Add "style sources" commands.
8317 (show_style_sources): New function.
8318 * cli/cli-style.h (source_styling): Declare.
8319
6f11e682
TT
83202019-03-14 Pedro Alves <palves@redhat.com>
8321 Tom Tromey <tromey@adacore.com>
8322
8323 * tui/tui-winsource.h (tui_refill_source_window): Declare.
8324 * tui/tui-winsource.c (tui_refill_source_window): New function,
8325 from...
8326 (tui_horizontal_source_scroll): ... here. Move some logic.
8327 * cli/cli-style.c (set_style_enabled): Notify new observable.
8328 * tui/tui-hooks.c (tui_redisplay_source): New function.
8329 (tui_attach_detach_observers): Attach or detach
8330 tui_redisplay_source.
8331 * observable.h (source_styling_changed): New observable.
8332 * observable.c: Define source_styling_changed observable.
8333
a068643d
TT
83342019-03-13 Tom Tromey <tromey@adacore.com>
8335
8336 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8337 (i386_gnu_nat_target::store_registers): Update.
8338 * target-debug.h (target_debug_print_std_string): New macro.
8339 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8340 * windows-tdep.c (display_one_tib): Update.
8341 * tui/tui-stack.c (tui_make_status_line): Update.
8342 * top.c (print_inferior_quit_action): Update.
8343 * thread.c (thr_try_catch_cmd): Update.
8344 (add_thread_with_info): Update.
8345 (thread_target_id_str): Update.
8346 (thr_try_catch_cmd): Update.
8347 (thread_command): Update.
8348 (thread_find_command): Update.
8349 * record-btrace.c (record_btrace_target::info_record)
8350 (record_btrace_resume_thread, record_btrace_target::resume)
8351 (record_btrace_cancel_resume, record_btrace_step_thread)
8352 (record_btrace_target::wait, record_btrace_target::wait)
8353 (record_btrace_target::wait, record_btrace_target::stop): Update.
8354 * progspace.c (print_program_space): Update.
8355 * process-stratum-target.c
8356 (process_stratum_target::thread_address_space): Update.
8357 * linux-fork.c (linux_fork_mourn_inferior)
8358 (detach_checkpoint_command, info_checkpoints_command)
8359 (linux_fork_context): Update.
8360 (linux_fork_detach): Update.
8361 (class scoped_switch_fork_info): Update.
8362 (delete_checkpoint_command): Update.
8363 * infrun.c (follow_fork_inferior): Update.
8364 (follow_fork_inferior): Update.
8365 (proceed_after_vfork_done): Update.
8366 (handle_vfork_child_exec_or_exit): Update.
8367 (follow_exec): Update.
8368 (displaced_step_prepare_throw): Update.
8369 (displaced_step_restore): Update.
8370 (start_step_over): Update.
8371 (resume_1): Update.
8372 (clear_proceed_status_thread): Update.
8373 (proceed): Update.
8374 (print_target_wait_results): Update.
8375 (do_target_wait): Update.
8376 (context_switch): Update.
8377 (stop_all_threads): Update.
8378 (restart_threads): Update.
8379 (finish_step_over): Update.
8380 (handle_signal_stop): Update.
8381 (switch_back_to_stepped_thread): Update.
8382 (keep_going_pass_signal): Update.
8383 (print_exited_reason): Update.
8384 (normal_stop): Update.
8385 * inferior.c (inferior_pid_to_str): Change return type.
8386 (print_selected_inferior): Update.
8387 (add_inferior): Update.
8388 (detach_inferior): Update.
8389 * dummy-frame.c (fprint_dummy_frames): Update.
8390 * dcache.c (dcache_info_1): Update.
8391 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8392 (btrace_fetch, btrace_clear): Update.
8393 * linux-tdep.c (linux_core_pid_to_str): Change return type.
8394 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8395 type.
8396 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8397 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8398 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8399 * gdbarch.c, gdbarch.h: Rebuild.
8400 * gdbarch.sh (core_pid_to_str): Change return type.
8401 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8402 return type.
8403 (windows_nat_target::pid_to_str): Change return type.
8404 (windows_delete_thread): Update.
8405 (windows_nat_target::attach): Update.
8406 (windows_nat_target::files_info): Update.
8407 * target-delegates.c: Rebuild.
8408 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8409 return type.
8410 (sol_thread_target::pid_to_str): Change return type.
8411 * remote.c (class remote_target) <pid_to_str>: Change return
8412 type.
8413 (remote_target::pid_to_str): Change return type.
8414 (extended_remote_target::attach, remote_target::remote_stop_ns)
8415 (remote_target::remote_notif_remove_queued_reply)
8416 (remote_target::push_stop_reply, remote_target::disable_btrace):
8417 Update.
8418 (extended_remote_target::attach): Update.
8419 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8420 type.
8421 (gdbsim_target::pid_to_str): Change return type.
8422 * ravenscar-thread.c (struct ravenscar_thread_target)
8423 <pid_to_str>: Change return type.
8424 (ravenscar_thread_target::pid_to_str): Change return type.
8425 * procfs.c (class procfs_target) <pid_to_str>: Change return
8426 type.
8427 (procfs_target::pid_to_str): Change return type.
8428 (procfs_target::attach): Update.
8429 (procfs_target::detach): Update.
8430 (procfs_target::fetch_registers): Update.
8431 (procfs_target::store_registers): Update.
8432 (procfs_target::wait): Update.
8433 (procfs_target::files_info): Update.
8434 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8435 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8436 return type.
8437 (nto_procfs_target::pid_to_str): Change return type.
8438 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8439 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8440 return type.
8441 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8442 (exit_lwp): Update.
8443 (attach_proc_task_lwp_callback, get_detach_signal)
8444 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8445 (linux_nat_target::resume, wait_lwp, stop_callback)
8446 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8447 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8448 (linux_nat_wait_1, resume_stopped_resumed_lwps)
8449 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8450 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8451 type.
8452 (inf_ptrace_target::attach): Update.
8453 (inf_ptrace_target::files_info): Update.
8454 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8455 type.
8456 (go32_nat_target::pid_to_str): Change return type.
8457 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8458 (gnu_nat_target::wait): Update.
8459 (gnu_nat_target::wait): Update.
8460 (gnu_nat_target::resume): Update.
8461 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8462 (fbsd_nat_target::wait): Update.
8463 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8464 type.
8465 (darwin_nat_target::attach): Update.
8466 * corelow.c (class core_target) <pid_to_str>: Change return type.
8467 (core_target::pid_to_str): Change return type.
8468 * target.c (normal_pid_to_str): Change return type.
8469 (default_pid_to_str): Likewise.
8470 (target_pid_to_str): Change return type.
8471 (target_translate_tls_address): Update.
8472 (target_announce_detach): Update.
8473 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8474 return type.
8475 (bsd_uthread_target::pid_to_str): Change return type.
8476 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8477 type.
8478 (bsd_kvm_target::pid_to_str): Change return type.
8479 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8480 return type.
8481 (aix_thread_target::pid_to_str): Change return type.
8482 * target.h (struct target_ops) <pid_to_str>: Change return type.
8483 (target_pid_to_str, normal_pid_to_str): Likewise.
8484 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8485 type.
8486 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8487 type.
8488 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8489 return type.
8490 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8491 type.
8492 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8493 type.
8494 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8495 return type.
8496
b4be1b06
SM
84972019-03-13 Simon Marchi <simon.marchi@ericsson.com>
8498
8499 * NEWS: Mention that the new default MI version is 3. Mention
8500 changes to the output of commands and events that deal with
8501 multi-location breakpoints.
8502 * breakpoint.c: Include "mi/mi-out.h".
8503 (print_one_breakpoint): Change output syntax if using MI version
8504 >= 3.
8505 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8506 New.
8507 (mi_multi_location_breakpoint_output_fixed): New.
8508 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8509 (mi_cmd_fix_multi_location_breakpoint_output): New.
8510 (mi_multi_location_breakpoint_output_fixed): New.
8511 * mi/mi-cmds.c (mi_cmds): Register command
8512 -fix-multi-location-breakpoint-output.
8513 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8514 interpreter "mi".
8515
8e5e5494
SM
85162019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
8517
8518 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8519 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8520 instantiate mi_ui_out based on interpreter name.
8521 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8522 * mi/mi-main.c (mi_load_progress): Likewise.
8523
197df35e
JB
85242019-03-12 John Baldwin <jhb@FreeBSD.org>
8525
8526 * NEWS: Combine separate "New targets" sections for 8.3.
8527
8399425f
JB
85282019-03-12 John Baldwin <jhb@FreeBSD.org>
8529
8530 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8531 (ppcfbsd_init_abi): Install gdbarch
8532 "fetch_tls_load_module_address" and "get_thread_local_address"
8533 methods.
8534
b0f87ed0
JB
85352019-03-12 John Baldwin <jhb@FreeBSD.org>
8536
8537 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8538 (riscv_fbsd_init_abi): Install gdbarch
8539 "fetch_tls_load_module_address" and "get_thread_local_address"
8540 methods.
8541
ce25aa57
JB
85422019-03-12 John Baldwin <jhb@FreeBSD.org>
8543
8544 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8545 (i386fbsd_init_abi): Install gdbarch
8546 "fetch_tls_load_module_address" and "get_thread_local_address"
8547 methods.
8548
f5424cfa
JB
85492019-03-12 John Baldwin <jhb@FreeBSD.org>
8550
8551 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8552 (amd64fbsd_init_abi): Install gdbarch
8553 "fetch_tls_load_module_address" and "get_thread_local_address"
8554 methods.
8555
945f3901
JB
85562019-03-12 John Baldwin <jhb@FreeBSD.org>
8557
8558 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8559 (struct fbsd_pspace_data): New type.
8560 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8561 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8562 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8563 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8564 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8565
ef0bd204
JB
85662019-03-12 John Baldwin <jhb@FreeBSD.org>
8567
8568 * gdbtypes.c (lookup_struct_elt): New function.
8569 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8570 * gdbtypes.h (struct struct_elt): New type.
8571 (lookup_struct_elt): New prototype.
8572
36c53a02
JB
85732019-03-12 John Baldwin <jhb@FreeBSD.org>
8574
8575 * gdbtypes.c (lookup_struct_elt_type): Update comment and
8576 remove disabled code block.
8577
6e056c81
JB
85782019-03-12 John Baldwin <jhb@FreeBSD.org>
8579
8580 * gdbarch.sh (get_thread_local_address): New method.
8581 * gdbarch.h, gdbarch.c: Regenerate.
8582 * target.c (target_translate_tls_address): Use
8583 gdbarch_get_thread_local_address if present instead of
8584 target::get_thread_local_address.
8585
cd250a18
JB
85862019-03-12 John Baldwin <jhb@FreeBSD.org>
8587
8588 * target.h (target::get_thread_local_address): Update comment.
8589
df22c1e5
JB
85902019-03-12 John Baldwin <jhb@FreeBSD.org>
8591
8592 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8593 objfile->separate_debug_objfile_backlink if not NULL.
8594
dd6876c9
JB
85952019-03-12 John Baldwin <jhb@FreeBSD.org>
8596
8597 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8598 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8599 (amd64bsd_store_inferior_registers): Likewise.
8600 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8601 Enable segment base registers.
8602 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8603 PT_GETFSBASE and PT_GETGSBASE.
8604 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8605 PT_SETGSBASE.
8606 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8607 segment base registers.
8608 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8609
1163a4b7
JB
86102019-03-12 John Baldwin <jhb@FreeBSD.org>
8611
8612 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8613 Update calls to i386_target_description to add 'segments'
8614 parameter.
8615 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
8616 add segment base registers.
8617 * arch/i386.c (i386_create_target_description): Add 'segments'
8618 parameter to enable segment base registers.
8619 * arch/i386.h (i386_create_target_description): Likewise.
8620 * features/i386/32bit-segments.xml: New file.
8621 * features/i386/32bit-segments.c: Generate.
8622 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8623 call to i386_target_description to add 'segments' parameter.
8624 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8625 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8626 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8627 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8628 if feature is present.
8629 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8630 Add 'segments' parameter to call to i386_target_description.
8631 (i386_target_description): Add 'segments' parameter to enable
8632 segment base registers.
8633 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8634 to call to i386_target_description.
8635 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8636 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8637 Define I386_NUM_REGS.
8638 (i386_target_description): Add 'segments' parameter to enable
8639 segment base registers.
8640
3a350822
EZ
86412019-03-12 Eli Zaretskii <eliz@gnu.org>
8642
8643 PR/24325
8644 * source-cache.c: #undef open and close, to avoid unresolved
8645 externals during linking.
8646
ffdd69cf
TT
86472019-03-12 Tom Tromey <tromey@adacore.com>
8648
8649 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8650 const. Add initializers.
8651 (_initialize_remote): Don't initialize ptid globals.
8652
ec148c57
PA
86532019-03-12 Pedro Alves <palves@redhat.com>
8654
8655 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8656
32764270
PA
86572019-03-12 Pedro Alves <palves@redhat.com>
8658
8659 * cp-name-parser.y (main): Remove unused 'len' variable.
8660
17547186
TT
86612019-03-12 Tom Tromey <tromey@adacore.com>
8662
8663 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8664 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8665
d3a70e03
TT
86662019-03-12 Tom Tromey <tromey@adacore.com>
8667
8668 * linux-nat.c (iterate_over_lwps): Update.
8669 (stop_callback): Remove parameter.
8670 (stop_wait_callback, detach_callback, resume_set_callback)
8671 (select_singlestep_lwp_callback, set_ignore_sigint)
8672 (status_callback, resumed_callback, resume_clear_callback)
8673 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8674 data parameter.
8675 (linux_nat_target::detach, linux_nat_target::resume)
8676 (linux_stop_and_wait_all_lwps, select_event_lwp)
8677 (linux_nat_filter_event, linux_nat_wait_1)
8678 (linux_nat_target::kill, linux_nat_target::stop)
8679 (linux_nat_target::stop): Update.
8680 (linux_nat_resume_callback): Change type.
8681 (resume_stopped_resumed_lwps, count_events_callback)
8682 (select_event_lwp_callback): Likewise.
8683 (linux_stop_lwp, linux_nat_stop_lwp): Update.
8684 * arm-linux-nat.c (struct update_registers_data): Remove.
8685 (update_registers_callback): Change type.
8686 (arm_linux_insert_hw_breakpoint1): Update.
8687 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8688 parameter.
8689 (x86_linux_dr_set_addr): Update.
8690 (x86_linux_dr_set_control): Update.
8691 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8692 (iterate_over_lwps): Use gdb::function_view.
8693 * nat/aarch64-linux-hw-point.c (struct
8694 aarch64_dr_update_callback_param): Remove.
8695 (debug_reg_change_callback): Change type.
8696 (aarch64_notify_debug_reg_change): Update.
8697 * s390-linux-nat.c (s390_refresh_per_info): Update.
8698
82cb27ff
TT
86992019-03-11 Tom Tromey <tromey@adacore.com>
8700
8701 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8702 redundant assignment to "this_cu".
8703
568c0683
SM
87042019-03-08 Simon Marchi <simon.marchi@efficios.com>
8705
8706 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8707
f09ce22d
SM
87082019-03-08 Simon Marchi <simon.marchi@efficios.com>
8709
8710 * gdbtypes.c (rank_one_type_parm_set): New function extracted
8711 from...
8712 (rank_one_type): ... this.
8713
595f96a9
SM
87142019-03-08 Simon Marchi <simon.marchi@efficios.com>
8715
8716 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8717 from...
8718 (rank_one_type): ... this.
8719
2598a94b
SM
87202019-03-08 Simon Marchi <simon.marchi@efficios.com>
8721
8722 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8723 from...
8724 (rank_one_type): ... this.
8725
7f17b20d
SM
87262019-03-08 Simon Marchi <simon.marchi@efficios.com>
8727
8728 * gdbtypes.c (rank_one_type_parm_float): New function extracted
8729 from...
8730 (rank_one_type): ... this.
8731
2c509035
SM
87322019-03-08 Simon Marchi <simon.marchi@efficios.com>
8733
8734 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8735 from...
8736 (rank_one_type): ... this.
8737
0dd322dc
SM
87382019-03-08 Simon Marchi <simon.marchi@efficios.com>
8739
8740 * gdbtypes.c (rank_one_type_parm_range): New function extracted
8741 from...
8742 (rank_one_type): ... this.
8743
41ea4728
SM
87442019-03-08 Simon Marchi <simon.marchi@efficios.com>
8745
8746 * gdbtypes.c (rank_one_type_parm_char): New function extracted
8747 from...
8748 (rank_one_type): ... this.
8749
793cd1d2
SM
87502019-03-08 Simon Marchi <simon.marchi@efficios.com>
8751
8752 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8753 from...
8754 (rank_one_type): ... this.
8755
34910087
SM
87562019-03-08 Simon Marchi <simon.marchi@efficios.com>
8757
8758 * gdbtypes.c (rank_one_type_parm_int): New function extracted
8759 from...
8760 (rank_one_type): ... this.
8761
f1f832d6
SM
87622019-03-08 Simon Marchi <simon.marchi@efficios.com>
8763
8764 * gdbtypes.c (rank_one_type_parm_func): New function extracted
8765 from...
8766 (rank_one_type): ... this.
8767
b9f4512f
SM
87682019-03-08 Simon Marchi <simon.marchi@efficios.com>
8769
8770 * gdbtypes.c (rank_one_type_parm_array): New function extracted
8771 from...
8772 (rank_one_type): ... this.
8773
9293fc63
SM
87742019-03-08 Simon Marchi <simon.marchi@efficios.com>
8775
8776 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8777 from...
8778 (rank_one_type): ... this.
8779
e3abbe7e
PW
87802019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8781
8782 * inferior.c (initialize_inferiors): Ensure 'help set/show print
8783 inferior-events' shows the example events.
8784
e4adb939
EZ
87852019-03-08 Eli Zaretskii <eliz@gnu.org>
8786
8787 Support styling on native MS-Windows console
8788
8789 PR/24315
8790 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8791 on MS-Windows if $TERM is not defined.
8792
8793 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8794
8795 * posix-hdep.c (gdb_console_fputs):
8796 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8797 functions.
8798 * ui-file.h (gdb_console_fputs): Add prototype.
8799
8800 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8801 back to fputs only if the former returns zero.
8802
25629dfd
TT
88032019-03-07 Tom Tromey <tom@tromey.com>
8804
8805 * symmisc.c (print_symbol_bcache_statistics): Update.
8806 (print_objfile_statistics): Update.
8807 * symfile.c (allocate_symtab): Update.
8808 * stabsread.c: Don't include bcache.h.
8809 * psymtab.h (struct psymbol_bcache): Don't declare.
8810 (class psymtab_storage) <psymbol_cache>: Now a bcache.
8811 (psymbol_bcache_init, psymbol_bcache_free)
8812 (psymbol_bcache_get_bcache): Don't declare.
8813 * psymtab.c (struct psymbol_bcache): Remove.
8814 (psymtab_storage::psymtab_storage): Update.
8815 (psymtab_storage::~psymtab_storage): Update.
8816 (psymbol_bcache_init, psymbol_bcache_free)
8817 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8818 (add_psymbol_to_bcache): Update.
8819 (allocate_psymtab): Update.
8820 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8821 macro_cache>: No longer pointers.
8822 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8823 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8824 * macrotab.c (macro_bcache): Update.
8825 * macroexp.c: Don't include bcache.h.
8826 * gdbtypes.c (check_types_worklist): Update.
8827 (types_deeply_equal): Remove TRY/CATCH. Update.
8828 * elfread.c (elf_symtab_read): Update.
8829 * dwarf2read.c: Don't include bcache.h.
8830 * buildsym.c (buildsym_compunit::get_macro_table): Update.
8831 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8832 (print_bcache_statistics, bcache_memory_used): Don't declare.
8833 (struct bcache): Move from bcache.c. Add constructor, destructor,
8834 methods. Rename all data members.
8835 * bcache.c (struct bcache): Move to bcache.h.
8836 (bcache::expand_hash_table): Rename from expand_hash_table.
8837 (bcache): Remove.
8838 (bcache::insert): Rename from bcache_full.
8839 (bcache::compare): Rename from bcache_compare.
8840 (bcache_xmalloc): Remove.
8841 (bcache::~bcache): Rename from bcache_xfree.
8842 (bcache::print_statistics): Rename from print_bcache_statistics.
8843 (bcache::memory_used): Rename from bcache_memory_used.
8844
fe726667
PA
88452019-03-07 Pedro Alves <palves@redhat.com>
8846
8847 * infrun.c (normal_stop): Also check for
8848 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8849
7584bb30
AB
88502019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
8851
8852 * f-lang.c (value_from_host_double): Moved to...
8853 * value.c (value_from_host_double): ...here.
8854 * value.h (value_from_host_double): Declare.
8855 * guile/scm-math.c (vlscm_convert_typed_number): Use
8856 value_from_host_double.
8857 (vlscm_convert_number): Likewise.
8858 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8859 * python/py-value.c (convert_value_from_python): Likewise.
8860
a7b1986e
TT
88612019-03-06 Tom Tromey <tom@tromey.com>
8862
8863 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8864
0ccf4211
TT
88652019-03-06 Tom Tromey <tom@tromey.com>
8866
8867 * utils.h (free_current_contents): Don't declare.
8868 * utils.c (free_current_contents): Remove.
8869
fe7b42e5
TT
88702019-03-06 Tom Tromey <tom@tromey.com>
8871
8872 * top.c (quit_force): Update.
8873 * main.c (captured_command_loop): Update.
8874 * common/new-op.c (operator new): Update.
8875 * common/common-exceptions.c (struct catcher)
8876 <save_cleanup_chain>: Remove member.
8877 (exceptions_state_mc_init): Update.
8878 (exception_try_scope_entry): Return nullptr.
8879 (exception_try_scope_exit, exception_rethrow)
8880 (throw_exception_sjlj, throw_exception_cxx): Update.
8881 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8882 (all_cleanups, do_cleanups, discard_cleanups)
8883 (discard_final_cleanups, save_cleanups, save_final_cleanups)
8884 (restore_cleanups, restore_final_cleanups): Don't declare.
8885 (do_final_cleanups): Remove parameter.
8886 * common/cleanups.c (cleanup_chain, make_cleanup)
8887 (make_cleanup_dtor, all_cleanups, do_cleanups)
8888 (discard_my_cleanups, discard_cleanups)
8889 (discard_final_cleanups, save_my_cleanups, save_cleanups)
8890 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8891 (null_cleanup): Remove.
8892 (do_final_cleanups): Remove parameter.
8893
c6321f19
TT
88942019-03-06 Tom Tromey <tom@tromey.com>
8895
8896 * remote.c (remote_target::remote_parse_stop_reply): Use
8897 unique_xmalloc_ptr.
8898
61b30099
TT
88992019-03-06 Tom Tromey <tom@tromey.com>
8900
8901 * stabsread.c (struct stabs_field_info): Rename from field_info.
8902 <list, fnlist>: Add initializers.
8903 <obstack>: New member.
8904 (read_member_functions, read_struct_fields, read_baseclasses):
8905 Allocate on obstack. Don't use cleanups.
8906 (read_one_struct_field, read_member_functions, read_struct_fields)
8907 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8908 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8909 (read_struct_type): Update.
8910
6cceac94
TT
89112019-03-06 Tom Tromey <tom@tromey.com>
8912
8913 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8914 * common/filestuff.h (make_cleanup_close): Don't declare.
8915 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8916 Remove.
8917
72412762
TT
89182019-03-06 Tom Tromey <tom@tromey.com>
8919
8920 * solib-aix.c: Use make_scope_exit.
8921
2b6ff1c0
TT
89222019-03-06 Tom Tromey <tom@tromey.com>
8923
8924 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8925 Use make_scope_exit.
8926
d01c5877
TT
89272019-03-06 Tom Tromey <tom@tromey.com>
8928
8929 * solib-svr4.c (disable_probes_interface): Remove parameter.
8930 (svr4_handle_solib_event): Use make_scope_exit.
8931
32603266
TT
89322019-03-06 Tom Tromey <tom@tromey.com>
8933
8934 * remote.c (struct stop_reply_deleter): Remove.
8935 (stop_reply_up): Update.
8936 (struct stop_reply): Derive from notif_event. Don't typedef.
8937 <regcache>: Now a std::vector.
8938 (stop_reply_xfree): Remove.
8939 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8940 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
8941 (remote_target::discard_pending_stop_replies): Use delete.
8942 (remote_target::remote_parse_stop_reply): Update.
8943 (remote_target::process_stop_reply): Update.
8944 * remote-notif.h (struct notif_event): Add virtual destructor.
8945 Remove "dtr" member.
8946 (struct notif_client) <alloc_event>: Return a unique_ptr.
8947 (notif_event_xfree): Don't declare.
8948 (notif_event_up): New typedef.
8949 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8950 (notif_event_xfree, do_notif_event_xfree): Remove.
8951 (remote_notif_state_xfree): Update.
8952
9799571e
TT
89532019-03-06 Tom Tromey <tom@tromey.com>
8954
8955 * infrun.c (displaced_step_clear_cleanup): Now a
8956 forward_scope_exit type.
8957 (displaced_step_prepare_throw): Update.
8958 (displaced_step_fixup): Update.
8959
09e3c4ca
TT
89602019-03-06 Tom Tromey <tom@tromey.com>
8961
8962 * inferior.h (class inferior): Update comment.
8963 * gdbthread.h (class thread_info): Update comment.
8964
e2a03548
TT
89652019-03-06 Joel Brobecker <brobecker@adacore.com>
8966 Tom Tromey <tom@tromey.com>
8967
8968 * stabsread.h (struct stab_section_list): Remove.
8969 (coffstab_build_psymtabs): Update.
8970 * dbxread.c (symbuf_sections): Now a std::vector.
8971 (sect_idx): New global.
8972 (fill_symbuf): Update.
8973 (coffstab_build_psymtabs): Change type of stabsects parameter.
8974 Update.
8975 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8976 std::vector.
8977 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8978 (coff_locate_sections): Update.
8979 (coff_symfile_read): Remove cleanups. Update.
8980 (init_stringtab): Add storage parameter.
8981 (free_stringtab, free_stringtab_cleanup): Remove.
8982 (init_lineno): Add storage parameter.
8983 (free_linetab, free_linetab_cleanup): Remove.
8984
b7e60d85
PA
89852019-03-06 Pedro Alves <palves@redhat.com>
8986
8987 * linux-fork.c (fork_info::clobber_regs): Delete.
8988 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8989 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
8990 comment. Adjust.
8991 (scoped_switch_fork_info::scoped_switch_fork_info)
8992 (checkpoint_command, linux_fork_context): Adjust
8993 fork_save_infrun_state calls.
8994
e52c971f
PA
89952019-03-06 Pedro Alves <palves@redhat.com>
8996
8997 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8998 (inf_has_multiple_threads): Return 'bool' and rewrite using
8999 inferior_info::threads().
9000
06974e6c
PA
90012019-03-06 Pedro Alves <palves@redhat.com>
9002
9003 * linux-fork.c: Include <list>.
9004 (fork_list): Now a std::list instance.
9005 (fork_info): Add ctor, dtor, and in-class initialize all fields.
9006 (forks_exist_p, find_last_fork): Adjust.
9007 (new_fork): Delete.
9008 (one_fork_p): New.
9009 (add_fork): Adjust.
9010 (free_fork): Delete, folded into fork_info::~fork_info().
9011 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9012 Adjust.
9013 (init_fork_list): Delete.
9014 (linux_fork_killall, linux_fork_mourn_inferior)
9015 (linux_fork_detach, info_checkpoints_command): Adjust.
9016 (_initialize_linux_fork): No longer call init_fork_list.
9017
72f31aea
PA
90182019-03-06 Pedro Alves <palves@redhat.com>
9019
9020 * linux-fork.c (new_fork): New, split out of ...
9021 (add_fork): ... this. Return void. Move "first fork" special
9022 case from here, to ...
9023 (checkpoint_command): ... here.
9024 * linux-linux.h (add_fork): Return void.
9025
efbecbc1
AB
90262019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9027
9028 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9029
0841c79a
AB
90302019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9031 Chris January <chris.january@arm.com>
9032 David Lecomber <david.lecomber@arm.com>
9033
9034 * f-exp.y: New token, UNOP_INTRINSIC.
9035 (exp): New pattern using UNOP_INTRINSIC token.
9036 (f77_keywords): Add 'abs' keyword.
9037 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9038 (value_from_host_double): New function.
9039 (evaluate_subexp_f): Support UNOP_ABS.
9040
4a270568
AB
90412019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9042
9043 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9044 types.
9045
067630bd
AB
90462019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9047
9048 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9049 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9050 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9051
3be47f7a
AB
90522019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9053
9054 * f-exp.y (convert_to_kind_type): Handle more type kinds.
9055
4d00f5d8
AB
90562019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9057 Chris January <chris.january@arm.com>
9058
9059 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9060 * f-exp.y: Define 'KIND' token.
9061 (exp): New pattern for KIND expressions.
9062 (ptype): Handle types with a kind extension.
9063 (direct_abs_decl): Extend to spot kind extensions.
9064 (f77_keywords): Add 'kind' to the list.
9065 (push_kind_type): New function.
9066 (convert_to_kind_type): New function.
9067 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9068 * parse.c (operator_length_standard): Likewise.
9069 * parser-defs.h (enum type_pieces): Add tp_kind.
9070 * std-operator.def: Add UNOP_KIND.
9071
e454224f
AB
90722019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9073
9074 * f-exp.y (f_parse): Set yydebug.
9075
9dad4a58
AB
90762019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9077
9078 * f-lang.c (evaluate_subexp_f): New function.
9079 (exp_descriptor_f): New global.
9080 (f_language_defn): Use exp_descriptor_f instead of
9081 exp_descriptor_standard.
9082
c8f91604
AB
90832019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9084
9085 * f-exp.y (struct token): Add comments.
9086 (dot_ops): Remove uppercase versions and the end marker.
9087 (f77_keywords): Likewise.
9088 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9089 entries in the dot_ops array are case insensitive, and use
9090 strncasecmp to compare strings. Also some whitespace cleanup in
9091 this area. Similar for the f77_keywords array, except entries in
9092 this list might be case sensitive.
9093
dd9f2c76
AB
90942019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9095
9096 * f-exp.y (struct f77_boolean_val): Add comments.
9097 (boolean_values): Remove uppercase versions, and end marker.
9098 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9099 and use strncasecmp to achieve case insensitivity. Additionally,
9100 perform whitespace cleanup around this code.
9101
67a3048c
TT
91022019-03-06 Tom Tromey <tromey@adacore.com>
9103
9104 * remote-sim.c (gdbsim_target_open): Use result of
9105 gdb_argv::release.
9106
aa3cfbda
RB
91072019-03-06 Richard Bunt <richard.bunt@arm.com>
9108 Dirk Schubert <dirk.schubert@arm.com>
9109 Chris January <chris.january@arm.com>
9110
9111 * eval.c (evaluate_subexp_standard): Call Fortran argument
9112 wrapping logic.
9113 * f-lang.c (struct value): A value which can be passed into a
9114 Fortran function call.
9115 (fortran_argument_convert): Wrap Fortran arguments in a pointer
9116 where appropriate.
9117 (struct type): Value ready for a Fortran function call.
9118 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9119 is needed.
9120 * f-lang.h (fortran_argument_convert): Declaration.
9121 (fortran_preserve_arg_pointer): Declaration.
9122 * infcall.c (value_arg_coerce): Call Fortran argument logic.
9123
ea38e5df
TT
91242019-03-05 Tom Tromey <tromey@adacore.com>
9125
9126 * python/py-prettyprint.c (print_string_repr): Remove #if.
9127 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9128
06b5b831
TT
91292019-03-05 Tom Tromey <tromey@adacore.com>
9130
9131 * target.c (the_dummy_target): Move later. Change type to
9132 "dummy_target".
9133 (initialize_targets): Don't initialize the_dummy_target.
9134
edbd9e45
TT
91352019-03-05 Tom Tromey <tromey@adacore.com>
9136
9137 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9138 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9139
c119e040
TT
91402019-03-05 Tom Tromey <tromey@adacore.com>
9141
9142 * windows-nat.c (windows_nat_target::attach)
9143 (windows_nat_target::detach): Don't call gdb_flush.
9144 * valprint.c (generic_val_print, val_print, val_print_string):
9145 Don't call gdb_flush.
9146 * utils.c (defaulted_query): Don't call gdb_flush.
9147 * typeprint.c (print_type_scalar): Don't call gdb_flush.
9148 * target.c (target_announce_detach): Don't call gdb_flush.
9149 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9150 * remote.c (extended_remote_target::attach): Don't call
9151 gdb_flush.
9152 * procfs.c (procfs_target::detach): Don't call gdb_flush.
9153 * printcmd.c (do_examine): Don't call gdb_flush.
9154 (info_display_command): Don't call gdb_flush.
9155 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9156 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9157 * memattr.c (info_mem_command): Don't call gdb_flush.
9158 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9159 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9160 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9161 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9162 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9163 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9164 (gnu_nat_target::detach): Don't call gdb_flush.
9165 * f-valprint.c (f_val_print): Don't call gdb_flush.
9166 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9167 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9168 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9169 gdb_flush.
9170 * c-valprint.c (c_val_print): Don't call gdb_flush.
9171 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9172
895dafa6
TT
91732019-03-05 Tom Tromey <tromey@adacore.com>
9174
9175 * varobj.c (update_dynamic_varobj_children): Update.
9176 (install_default_visualizer): Use reset, not release.
9177 * value.c (set_internalvar): Update.
9178 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9179 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9180 ATTRIBUTE_UNUSED_RESULT.
9181
88a774b9
TT
91822019-03-05 Tom Tromey <tromey@adacore.com>
9183
9184 * remote.c (class scoped_remote_fd) <release>: Add
9185 ATTRIBUTE_UNUSED_RESULT.
9186
4e4a8b93
TT
91872019-03-05 Tom Tromey <tromey@adacore.com>
9188
9189 * macroexp.c (struct macro_buffer) <release>: Add
9190 ATTRIBUTE_UNUSED_RESULT.
9191
083eef1f
TT
91922019-03-05 Tom Tromey <tromey@adacore.com>
9193
9194 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9195 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9196 ATTRIBUTE_UNUSED_RESULT.
9197
3cabd438
TT
91982019-03-05 Tom Tromey <tromey@adacore.com>
9199
9200 * common/scoped_fd.h (class scoped_fd) <release>: Add
9201 ATTRIBUTE_UNUSED_RESULT.
9202
41e3300a
TT
92032019-03-05 Tom Tromey <tromey@adacore.com>
9204
9205 * parser-defs.h (struct parser_state) <release>: Add
9206 ATTRIBUTE_UNUSED_RESULT.
9207
18cb7c9f
TT
92082019-03-05 Tom Tromey <tromey@adacore.com>
9209
9210 * utils.h (class gdb_argv) <release>: Add
9211 ATTRIBUTE_UNUSED_RESULT.
9212 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9213
41fa577f
EZ
92142019-03-02 Eli Zaretskii <eliz@gnu.org>
9215
a6a4b2c6
EZ
9216 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9217 for-loop range, to avoid compiler warnings.
9218
9219 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9220 avoid compiler warnings about unused variables.
9221
742a7df5
EZ
9222 * NEWS: Mention end of support for native debugging on MS-Windows
9223 before XP.
9224
41fa577f
EZ
9225 PR gdb/24292
9226 * common/netstuff.c:
9227 * gdbserver/gdbreplay.c
9228 * gdbserver/remote-utils.c:
9229 * ser-tcp.c:
9230 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9231 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
9232 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9233 'getaddrinfo' and 'freeaddrinfo' were not available before
9234 Windows XP, and mingw.org's MinGW headers by default define
9235 _WIN32_WINNT to 0x500.
9236
827f438f
GB
92372019-03-01 Gary Benson <gbenson@redhat.com>
9238
9239 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9240
92137da0
RO
92412019-02-28 Brian Vandenberg <phantall@gmail.com>
9242 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
9243
9244 PR gdb/8527
9245 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9246 set_sigint_trap, clear_sigint_trap.
9247
799efbe8
PW
92482019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9249
9250 * target.c (target_detach): Clear the regcache and the
9251 frame cache.
9252
8ed25214
PA
92532019-02-27 Pedro Alves <palves@redhat.com>
9254
9255 * utils.c (set_screen_size): When we cap the height/width sizes,
9256 tweak the corresponding command variable to show "unlimited":
9257
23031e31
SJ
92582019-02-27 Saagar Jha <saagar@saagarjha.com>
9259 Pedro Alves <palves@redhat.com>
9260
9261 * utils.c (set_screen_size): Reduce "infinite" rows and columns
9262 before calling rl_set_screen_size.
9263
6c28e44a
TT
92642019-02-27 Tom Tromey <tromey@adacore.com>
9265
9266 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9267 define.
9268 * python/py-value.c: Remove Python 2.4 workaround.
9269 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9270 workaround.
9271 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9272 Python 2.4 workaround.
9273 * python/python-internal.h: Remove Python 2.4 comment.
9274 (Py_ssize_t): Don't define.
9275 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9276 (gdb_Py_DECREF): Remove Python 2.4 workaround.
9277 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9278 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9279 * python/python.c (do_start_initialization): Remove Python 2.4
9280 workaround.
9281 * python/py-prettyprint.c (class dummy_python_frame): Remove.
9282 (print_children): Remove Python 2.4 workaround.
9283 * python/py-inferior.c (buffer_procs): Remove Python 2.4
9284 workaround.
9285 (CHARBUFFERPROC_NAME): Remove.
9286 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9287 Python 2.4 workaround.
9288
2c3fc25d 92892019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 9290
2c3fc25d
KB
9291 * NEWS: Note minimum Python version.
9292
6ca62222
KB
92932019-02-27 Kevin Buettner <kevinb@redhat.com>
9294
9295 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9296 code from these functions. Remove corresponding ifdefs. Use
9297 Py_buffer_up instead of explicit calls to PyBuffer_Release.
9298 Remove gotos and target of gotos.
9299 (infpy_search_memory): Likewise.
9300
f4bc7d2c
AB
93012019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9302
9303 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9304 (hppa_gdbarch_init): Don't register deleted functions with
9305 gdbarch.
9306
9734a586
AB
93072019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9308
9309 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9310 (h8300_unwind_sp): Delete.
9311 (h8300_dummy_id): Delete.
9312 (h8300_gdbarch_init): Don't register deleted functions with
9313 gdbarch.
9314
68b867f3
AB
93152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9316
9317 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9318 (ft32_unwind_pc): Delete.
9319 (ft32_unwind_sp): Delete.
9320 (ft32_gdbarch_init): Don't register deleted functions with
9321 gdbarch.
9322
2fbe7ad0
AB
93232019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9324
9325 * gdb/frv-tdep.c (frv_dummy_id): Delete.
9326 (frv_unwind_pc): Delete.
9327 (frv_unwind_sp): Delete.
9328 (frv_gdbarch_init): Don't register deleted functions with
9329 gdbarch.
9330
76055cbe
AB
93312019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9332
9333 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9334 (riscv_unwind_pc): Delete.
9335 (riscv_unwind_sp): Delete.
9336 (riscv_gdbarch_init): Don't register deleted functions with
9337 gdbarch.
9338
4133e5a1
AB
93392019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9340
9341 * gdb/csky-tdep.c (csky_dummy_id): Delete.
9342 (csky_unwind_pc): Delete.
9343 (csky_unwind_sp): Delete.
9344 (csky_gdbarch_init): Don't register deleted functions with
9345 gdbarch.
9346
8010f576
AB
93472019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9348
9349 * gdb/cris-tdep.c (cris_dummy_id): Delete.
9350 (cris_unwind_pc): Delete.
9351 (cris_unwind_sp): Delete.
9352 (cris_gdbarch_init): Don't register deleted functions with
9353 gdbarch.
9354
b56bf084
AB
93552019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9356
9357 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9358 (bfin_unwind_pc): Delete.
9359 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9360
a19a650f
AB
93612019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9362
9363 * gdb/arm-tdep.c (arm_dummy_id): Delete.
9364 (arm_unwind_pc): Delete.
9365 (arm_unwind_sp): Delete.
9366 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9367
f8278c3c
AB
93682019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9369
9370 * gdb/arc-tdep.c (arc_dummy_id): Delete.
9371 (arc_unwind_pc): Delete.
9372 (arc_unwind_sp): Delete.
9373 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9374
480e46cf
AB
93752019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9376
9377 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9378 (alpha_unwind_pc): Delete.
9379 (alpha_gdbarch_init): Don't register deleted functions with
9380 gdbarch.
9381
7a995095
AB
93822019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9383
9384 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9385 (aarch64_unwind_pc): Delete.
9386 (aarch64_unwind_sp): Delete.
9387 (aarch64_gdbarch_init): Don't register deleted functions with
9388 gdbarch.
9389
bf9a735e
AB
93902019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9391
9392 * gdbtypes.c (type_align): Don't consider static members when
9393 computing structure alignment.
9394
5561fc30
AB
93952019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9396
9397 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9398 return 0 for other types.
9399 * arch-utils.c (default_type_align): Always return 0.
9400 * gdbarch.h: Regenerate.
9401 * gdbarch.sh (type_align): Extend comment.
9402 * gdbtypes.c (type_align): Add additional comments, always call
9403 gdbarch_type_align before applying the default rules.
9404 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9405 generic code will then apply a suitable default.
9406 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9407 types, return 0 for other types.
9408
9335e75a
JB
94092019-02-27 Joel Brobecker <brobecker@adacore.com>
9410
9411 * NEWS: Create a new section for the next release branch.
9412 Rename the section of the current branch, now that it has
9413 been cut.
9414
3d34d8de
JB
94152019-02-27 Joel Brobecker <brobecker@adacore.com>
9416
9417 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9418 * version.in: Bump version to 8.3.50.DATE-git.
9419
143420fb
SM
94202019-02-26 Simon Marchi <simon.marchi@efficios.com>
9421
9422 * aix-thread.c (ptid_cmp): Remove unused variable.
9423 (get_signaled_thread): Likewise.
9424 (store_regs_user_thread): Likewise.
9425 (store_regs_kernel_thread): Likewise.
9426 (fetch_regs_kernel_thread): Remove shadowed variable.
9427
172fb711
AB
94282019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
9429
9430 * features/riscv/32bit-cpu.xml: Add register numbers.
9431 * features/riscv/32bit-fpu.c: Regenerate.
9432 * features/riscv/32bit-fpu.xml: Add register numbers.
9433 * features/riscv/64bit-cpu.xml: Add register numbers.
9434 * features/riscv/64bit-fpu.c: Regenerate.
9435 * features/riscv/64bit-fpu.xml: Add register numbers.
9436
26c89782
KB
94372019-02-26 Kevin Buettner <kevinb@redhat.com>
9438
af54ade9 9439 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
9440 * python/py-value.c (convert_buffer_and_type_to_value): New
9441 function.
9442 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9443 Add support for handling an optional second argument. Call
9444 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
9445 * python/python-internal.h (Py_buffer_deleter): New struct.
9446 (Py_buffer_up): New typedef.
9447
0f58c9e8
JB
94482019-02-25 John Baldwin <jhb@FreeBSD.org>
9449
9450 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9451 instead of releasing ownership.
9452
0a0f4c01
JR
94532019-02-25 Jordan Rupprecht <rupprecht@google.com>
9454
9455 * dwarf2read.c (open_and_init_dwp_file): Call
9456 elf_numsections instead of bfd_count_sections to initialize
9457 dwp_file->num_sections.
9458
cd5a152c
TT
94592019-02-25 Tom Tromey <tromey@adacore.com>
9460
9461 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9462
8a6a8513
SDJ
94632019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
9464
9465 * gcore.in: Add '--readnever' option when invoking GDB.
9466
04dcda9c
SM
94672019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9468
9469 * MAINTAINERS: Update my email address.
9470
07bc701d
SM
94712019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9472
9473 * build-id.c (build_id_to_debug_bfd_1): New function.
9474 (build_id_to_debug_bfd): Look for separate debug file in
9475 sysroot.
9476
c6f4a5d0
AB
94772019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
9478
9479 * gdbarch.sh: Update the copyright year range that is placed into
9480 generated files.
9481
9600246d
KS
94822019-02-22 Keith Seitz <keiths@redhat.com>
9483
9484 PR symtab/23853
9485 * linespec.c (create_sals_line_offset): Search for the default
9486 symtab's filename instead of its fullname.
9487
7557a514
AH
94882019-02-21 Alan Hayward <alan.hayward@arm.com>
9489
9490 * NEWS: Update style defaults.
9491
ee2bcb0c
AH
94922019-02-21 Alan Hayward <alan.hayward@arm.com>
9493
9494 * main.c (captured_main_1): Disable styling in batch mode.
9495
0c95f9ed
TT
94962019-02-20 Tom Tromey <tom@tromey.com>
9497
9498 * symtab.c (symtab_symbol_info): Fix typos.
9499
c763b894
TT
95002019-02-20 Tom Tromey <tromey@adacore.com>
9501
9502 * findcmd.c (_initialize_mem_search): Use upper case for
9503 metasyntactic variables.
9504
0ef8a082
AH
95052019-02-20 Alan Hayward <alan.hayward@arm.com>
9506
9507 * aarch64-tdep.c (aarch64_add_reggroups): New function.
9508 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9509
6caa91b6
SM
95102019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
9511
9512 * top.h (source_file_name): Change to std::string.
9513 * top.c (source_file_name): Likewise.
9514 (command_line_input): Adjust.
9515 * cli/cli-script.c (script_from_file): Adjust.
9516
98814c6c
TT
95172019-02-19 Tom Tromey <tromey@adacore.com>
9518
9519 * ravenscar-thread.c
9520 (ravenscar_thread_target::update_thread_list): Don't call
9521 ada_build_task_list.
9522 * ada-lang.h (ada_build_task_list): Don't declare.
9523 * ada-tasks.c (struct ada_tasks_inferior_data)
9524 <task_list_valid_p>: Now bool.
9525 (read_known_tasks, ada_task_list_changed)
9526 (ada_tasks_invalidate_inferior_data): Update.
9527 (read_known_tasks_array): Return bool.
9528 (read_known_tasks_list): Likewise.
9529 (read_known_tasks): Return void.
9530 (ada_build_task_list): Now static.
9531
70cd633e
AB
95322019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
9533
9534 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9535 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9536
040b3e95
PW
95372019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9538
9539 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9540 variant for ada_tasks_pspace_data_handle and
9541 ada_tasks_inferior_data_handle.
9542 (ada_tasks_pspace_data_cleanup): New function.
9543 (ada_tasks_inferior_data_cleanup): New function.
9544
9409233b
TT
95452019-02-17 Tom Tromey <tom@tromey.com>
9546
9547 * macrotab.h (macro_source_fullname): Return a std::string.
9548 * macrotab.c (macro_include, check_for_redefinition)
9549 (macro_undef, macro_lookup_definition, foreach_macro)
9550 (foreach_macro_in_scope): Update.
9551 (macro_source_fullname): Return a std::string.
9552 * macrocmd.c (show_pp_source_pos): Update.
9553
6506371f
TT
95542019-02-17 Tom Tromey <tom@tromey.com>
9555
9556 * macrocmd.c (show_pp_source_pos): Style the file names.
9557
0c820d67
TT
95582019-02-17 Tom Tromey <tom@tromey.com>
9559
9560 PR tui/24197:
9561 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9562
a0087920
TT
95632019-02-17 Tom Tromey <tom@tromey.com>
9564
9565 * ada-lang.c (user_select_syms): Use filtered printing.
9566 * utils.c (wrap_style): New global.
9567 (desired_style): Remove.
9568 (emit_style_escape): Add stream parameter.
9569 (set_output_style, reset_terminal_style, prompt_for_continue):
9570 Update.
9571 (flush_wrap_buffer): Only flush gdb_stdout.
9572 (wrap_here): Set wrap_style.
9573 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
9574 treat escape sequences as a character. Change when wrap buffer is
9575 flushed.
9576 (fputs_styled): Do not set the output style when the default is
9577 requested.
9578 * ui-style.h (struct ui_file_style) <is_default>: New method.
9579 * source.c (print_source_lines_base): Emit escape sequences in one
9580 piece.
9581
75ba10dc
JB
95822019-02-17 Joel Brobecker <brobecker@adacore.com>
9583
9584 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9585 integers and enumeration types.
9586
a2cd4f14
JB
95872019-02-17 Joel Brobecker <brobecker@adacore.com>
9588
9589 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9590 instead of lookup_symbol_in_language
9591 (do_exact_match): New function.
9592 (ada_get_symbol_name_matcher): Return do_exact_match when
9593 doing a verbatim match.
9594
485b851b
TT
95952019-02-15 Tom Tromey <tromey@adacore.com>
9596
9597 * ravenscar-thread.c (ravenscar_thread_target::resume)
9598 (ravenscar_thread_target::wait): Special case wildcard requests.
9599
0b790b1e
TT
96002019-02-15 Tom Tromey <tromey@adacore.com>
9601
9602 * ravenscar-thread.c (base_ptid): Remove.
9603 (struct ravenscar_thread_target) <close>: New method.
9604 <m_base_ptid>: New member.
9605 <update_inferior_ptid, active_task, task_is_currently_active,
9606 runtime_initialized>: Declare methods.
9607 <ravenscar_thread_target>: Add constructor.
9608 (ravenscar_thread_target::task_is_currently_active)
9609 (ravenscar_thread_target::update_inferior_ptid)
9610 (ravenscar_runtime_initialized): Rename. Now methods.
9611 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9612 (ravenscar_thread_target::update_thread_list): Update.
9613 (ravenscar_thread_target::active_task): Now method.
9614 (ravenscar_thread_target::store_registers)
9615 (ravenscar_thread_target::prepare_to_store)
9616 (ravenscar_thread_target::prepare_to_store)
9617 (ravenscar_thread_target::mourn_inferior): Update.
9618 (ravenscar_inferior_created): Use "new" to create target.
9619 (ravenscar_thread_target::get_ada_task_ptid): Update.
9620 (_initialize_ravenscar): Don't initialize base_ptid.
9621 (ravenscar_ops): Remove global.
9622
dea57a62
TT
96232019-02-15 Tom Tromey <tromey@adacore.com>
9624
9625 * target.h (push_target): Declare new overload.
9626 * target.c (push_target): New overload, taking an rvalue reference.
9627 * remote.c (remote_target::open_1): Use push_target overload.
9628 * corelow.c (core_target_open): Use push_target overload.
9629
989f3c58
TT
96302019-02-15 Tom Tromey <tromey@adacore.com>
9631
9632 * ravenscar-thread.c (is_ravenscar_task)
9633 (ravenscar_task_is_currently_active): Return bool.
9634 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9635 (_initialize_ravenscar): Remove "(void)".
9636 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9637 Return bool.
9638
6cbcc006
TT
96392019-02-15 Tom Tromey <tromey@adacore.com>
9640
9641 * ravenscar-thread.c (ravenscar_runtime_initializer)
9642 (has_ravenscar_runtime, get_running_thread_id)
9643 (ravenscar_thread_target::resume): Fix indentation.
9644
7657f14d
TT
96452019-02-15 Tom Tromey <tromey@adacore.com>
9646
9647 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9648 from ravenscar_arch_ops.
9649 (sparc_ravenscar_ops::fetch_registers)
9650 (sparc_ravenscar_ops::store_registers): Now methods.
9651 (sparc_ravenscar_prepare_to_store): Remove.
9652 (sparc_ravenscar_ops): Redefine.
9653 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9654 methods and destructor. Remove members.
9655 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9656 (ravenscar_thread_target::store_registers)
9657 (ravenscar_thread_target::prepare_to_store): Update.
9658 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9659 Remove.
9660 (struct ppc_ravenscar_powerpc_ops): Derive from
9661 ravenscar_arch_ops.
9662 (ppc_ravenscar_powerpc_ops::fetch_registers)
9663 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9664 (ppc_ravenscar_powerpc_ops): Redefine.
9665 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9666 (ppc_ravenscar_e500_ops::fetch_registers)
9667 (ppc_ravenscar_e500_ops::store_registers): Now methods.
9668 (ppc_ravenscar_e500_ops): Redefine.
9669 * aarch64-ravenscar-thread.c
9670 (aarch64_ravenscar_generic_prepare_to_store): Remove.
9671 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9672 (aarch64_ravenscar_fetch_registers)
9673 (aarch64_ravenscar_store_registers): Now methods.
9674 (aarch64_ravenscar_ops): Redefine.
9675
5b6ea500
TT
96762019-02-15 Tom Tromey <tromey@adacore.com>
9677
9678 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9679 (ravenscar_thread_target::stopped_by_hw_breakpoint)
9680 (ravenscar_thread_target::stopped_by_watchpoint)
9681 (ravenscar_thread_target::stopped_data_address)
9682 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9683
e397fd39
TT
96842019-02-15 Tom Tromey <tromey@adacore.com>
9685
9686 * ravenscar-thread.c: Fix some typos.
9687
cc12f4a8
TT
96882019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9689 Tom Tromey <tromey@adacore.com>
9690
9691 * ada-lang.c (ada_exception_sal): Change addr_string to a
9692 std::string.
9693 (create_ada_exception_catchpoint): Update.
9694
5f486660
TT
96952019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9696 Tom Tromey <tromey@adacore.com>
9697
9698 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9699 (bp_location_ops): Remove.
9700 (base_breakpoint_allocate_location): Update.
9701 (free_bp_location): Update.
9702 * ada-lang.c (class ada_catchpoint_location)
9703 <ada_catchpoint_location>: Remove ops parameter.
9704 (ada_catchpoint_location_dtor): Remove.
9705 (ada_catchpoint_location_ops): Remove.
9706 (allocate_location_exception): Update.
9707 * breakpoint.h (struct bp_location_ops): Remove.
9708 (class bp_location) <bp_location>: Remove bp_location_ops
9709 parameter.
9710 <~bp_location>: Add destructor.
9711 <ops>: Remove.
9712
b671c7fb
TS
97132019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9714 Pedro Alves <palves@redhat.com>
9715
9716 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9717 'PATH_MAX'.
9718
8071c5ce
DM
97192019-02-14 David Michael <fedora.dm0@gmail.com>
9720 Samuel Thibault <samuel.thibault@gnu.org>
9721 Thomas Schwinge <thomas@codesourcery.com>
9722
9723 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9724 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9725
b1041ae0
TS
97262019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9727
924514e1
TS
9728 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9729 (check_empty): Use "const char *".
9730
c29ee8d4
TS
9731 * gnu-nat.c (gnu_nat_target::detach): Instead of
9732 'detach_inferior (pid)' call
9733 'detach_inferior (find_inferior_pid (pid))'.
9734
6c6ef69f
TS
9735 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9736 'nat/fork-inferior.o'.
9737 * gnu-nat.c: #include "nat/fork-inferior.h".
9738
2d0a338c
TS
9739 * gnu-nat.c (gnu_nat_target::detach): Instead of
9740 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9741 * gnu-nat.h: #include "inf-child.h".
9742 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9743 'i386_gnu_nat_target::fetch_registers'.
9744 (gnu_store_registers): Rename/move to
9745 'i386_gnu_nat_target::store_registers'.
9746
cabb5f06
TS
9747 * config/i386/nm-i386gnu.h: Don't "#include" any files.
9748 * gnu-nat.h (mach_thread_info): New function.
9749 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9750
b1041ae0
TS
9751 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9752
2988d01e
KF
97532019-02-14 Frederic Konrad <konrad@adacore.com>
9754
9755 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9756
c559d709
JB
97572019-02-14 Joel Brobecker <brobecker@adacore.com>
9758
9759 * windows-nat.c (windows_add_thread): Add new parameter
9760 "main_thread_p" with default value set to false. Update
9761 function documentation as well as all callers.
9762 (windows_delete_thread): Likewise.
9763 (fake_create_process): Update call to windows_add_thread.
9764 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9765 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9766 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9767 call to windows_delete_thread.
9768
007024cc
SM
97692019-02-13 Simon Marchi <simon.marchi@ericsson.com>
9770
9771 * MAINTAINERS: Add Andrew Burgess as global maintainer.
9772
f62318e9
JB
97732019-02-12 John Baldwin <jhb@FreeBSD.org>
9774
9775 * symfile.c (find_separate_debug_file): Use canonical path of
9776 sysroot with child_path instead of gdb_sysroot if it is valid.
9777
cd4b7848
JB
97782019-02-12 John Baldwin <jhb@FreeBSD.org>
9779
9780 * symfile.c (find_separate_debug_file): Use child_path to
9781 determine if an object file is under a sysroot.
9782
efac4bfe
JB
97832019-02-12 John Baldwin <jhb@FreeBSD.org>
9784
9785 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9786 unittests/child-path-selftests.c.
9787 * common/pathstuff.c (child_path): New function.
9788 * common/pathstuff.h (child_path): New prototype.
9789 * unittests/child-path-selftests.c: New file.
9790
402d2bfe
JB
97912019-02-12 John Baldwin <jhb@FreeBSD.org>
9792
9793 * symfile.c (find_separate_debug_file): Look for separate debug
9794 files in debug directories under the sysroot.
9795
1ed9f74e
PW
97962019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9797
9798 * symtab.h (struct minimal_symbol data_p): New const method.
9799 (struct minimal_symbol text_p): Likewise.
9800 * symtab.c (output_source_filename): Use file name style
9801 to print file name.
9802 (print_symbol_info): Likewise.
9803 (print_msymbol_info): Use address style to print addresses.
9804 Use function name style to print executable text symbols.
9805 (expand_symtab_containing_pc): Use data_p.
9806 (find_pc_sect_compunit_symtab): Likewise.
9807
2636d81d
PW
98082019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9809
9810 * breakpoint.c (describe_other_breakpoints): Use address style
9811 to print addresses.
9812 (say_where): Likewise.
9813
ac8c53cc
PW
98142019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9815
9816 * ada-typeprint.c (print_func_type): Print function name
9817 style to print function name.
9818 * c-typeprint.c (c_print_type_1): Likewise.
9819
ea638c43
AH
98202019-02-11 Alan Hayward <alan.hayward@arm.com>
9821
9822 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9823 for execve.
9824
ab759ca8
PW
98252019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9826
9827 * c-exp.y (direct_abs_decl): Use emplace_back to record the
9828 type_stack.
9829
aff29d1c
JB
98302019-02-10 Joel Brobecker <brobecker@adacore.com>
9831
9832 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9833 TYPE_CODE_REF types.
9834
617126bc
JW
98352019-02-08 Jim Wilson <jimw@sifive.com>
9836
9837 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9838 (riscv_linux_fregset): New.
9839 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9840
46e3ed7f
TT
98412019-02-07 Tom Tromey <tom@tromey.com>
9842
9843 * thread.c (thread_cancel_execution_command): Update.
9844 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9845 methods.
9846 (struct thread_fsm_ops): Remove.
9847 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9848 (thread_fsm_should_stop, thread_fsm_return_value)
9849 (thread_fsm_set_finished, thread_fsm_finished_p)
9850 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9851 Don't declare.
9852 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9853 * infrun.c (clear_proceed_status_thread)
9854 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9855 (print_stop_event): Update.
9856 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9857 Add constructor.
9858 (step_command_fsm_ops): Remove.
9859 (new_step_command_fsm): Remove.
9860 (step_1): Update.
9861 (step_command_fsm::should_stop): Rename from
9862 step_command_fsm_should_stop.
9863 (step_command_fsm::clean_up): Rename from
9864 step_command_fsm_clean_up.
9865 (step_command_fsm::do_async_reply_reason): Rename from
9866 step_command_fsm_async_reply_reason.
9867 (struct until_next_fsm): Inherit from thread_fsm. Add
9868 constructor.
9869 (until_next_fsm_ops): Remove.
9870 (new_until_next_fsm): Remove.
9871 (until_next_fsm::should_stop): Rename from
9872 until_next_fsm_should_stop.
9873 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9874 (until_next_fsm::do_async_reply_reason): Rename from
9875 until_next_fsm_async_reply_reason.
9876 (struct finish_command_fsm): Inherit from thread_fsm. Add
9877 constructor. Change type of breakpoint.
9878 (finish_command_fsm_ops): Remove.
9879 (new_finish_command_fsm): Remove.
9880 (finish_command_fsm::should_stop): Rename from
9881 finish_command_fsm_should_stop.
9882 (finish_command_fsm::clean_up): Rename from
9883 finish_command_fsm_clean_up.
9884 (finish_command_fsm::return_value): Rename from
9885 finish_command_fsm_return_value.
9886 (finish_command_fsm::do_async_reply_reason): Rename from
9887 finish_command_fsm_async_reply_reason.
9888 (finish_command): Update.
9889 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9890 Add constructor.
9891 (call_thread_fsm_ops): Remove.
9892 (call_thread_fsm::call_thread_fsm): Rename from
9893 new_call_thread_fsm.
9894 (call_thread_fsm::should_stop): Rename from
9895 call_thread_fsm_should_stop.
9896 (call_thread_fsm::should_notify_stop): Rename from
9897 call_thread_fsm_should_notify_stop.
9898 (run_inferior_call, call_function_by_hand_dummy): Update.
9899 * cli/cli-interp.c (should_print_stop_to_console): Update.
9900 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9901 Add constructor. Change type of location_breakpoint,
9902 caller_breakpoint.
9903 (until_break_fsm_ops): Remove.
9904 (new_until_break_fsm): Remove.
9905 (until_break_fsm::should_stop): Rename from
9906 until_break_fsm_should_stop.
9907 (until_break_fsm::clean_up): Rename from
9908 until_break_fsm_clean_up.
9909 (until_break_fsm::do_async_reply_reason): Rename from
9910 until_break_fsm_async_reply_reason.
9911 (until_break_command): Update.
9912 * thread-fsm.c: Remove.
9913 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9914
1a5c2598
TT
99152019-02-07 Tom Tromey <tom@tromey.com>
9916
9917 * yy-remap.h: Add include guard.
9918 * xtensa-tdep.h: Add include guard.
9919 * xcoffread.h: Rename include guard.
9920 * varobj-iter.h: Add include guard.
9921 * tui/tui.h: Rename include guard.
9922 * tui/tui-winsource.h: Rename include guard.
9923 * tui/tui-wingeneral.h: Rename include guard.
9924 * tui/tui-windata.h: Rename include guard.
9925 * tui/tui-win.h: Rename include guard.
9926 * tui/tui-stack.h: Rename include guard.
9927 * tui/tui-source.h: Rename include guard.
9928 * tui/tui-regs.h: Rename include guard.
9929 * tui/tui-out.h: Rename include guard.
9930 * tui/tui-layout.h: Rename include guard.
9931 * tui/tui-io.h: Rename include guard.
9932 * tui/tui-hooks.h: Rename include guard.
9933 * tui/tui-file.h: Rename include guard.
9934 * tui/tui-disasm.h: Rename include guard.
9935 * tui/tui-data.h: Rename include guard.
9936 * tui/tui-command.h: Rename include guard.
9937 * tic6x-tdep.h: Add include guard.
9938 * target/waitstatus.h: Rename include guard.
9939 * target/wait.h: Rename include guard.
9940 * target/target.h: Rename include guard.
9941 * target/resume.h: Rename include guard.
9942 * target-float.h: Rename include guard.
9943 * stabsread.h: Add include guard.
9944 * rs6000-tdep.h: Add include guard.
9945 * riscv-fbsd-tdep.h: Add include guard.
9946 * regformats/regdef.h: Rename include guard.
9947 * record.h: Rename include guard.
9948 * python/python.h: Rename include guard.
9949 * python/python-internal.h: Rename include guard.
9950 * python/py-stopevent.h: Rename include guard.
9951 * python/py-ref.h: Rename include guard.
9952 * python/py-record.h: Rename include guard.
9953 * python/py-record-full.h: Rename include guard.
9954 * python/py-record-btrace.h: Rename include guard.
9955 * python/py-instruction.h: Rename include guard.
9956 * python/py-events.h: Rename include guard.
9957 * python/py-event.h: Rename include guard.
9958 * procfs.h: Add include guard.
9959 * proc-utils.h: Add include guard.
9960 * p-lang.h: Add include guard.
9961 * or1k-tdep.h: Rename include guard.
9962 * observable.h: Rename include guard.
9963 * nto-tdep.h: Rename include guard.
9964 * nat/x86-linux.h: Rename include guard.
9965 * nat/x86-linux-dregs.h: Rename include guard.
9966 * nat/x86-gcc-cpuid.h: Add include guard.
9967 * nat/x86-dregs.h: Rename include guard.
9968 * nat/x86-cpuid.h: Rename include guard.
9969 * nat/ppc-linux.h: Rename include guard.
9970 * nat/mips-linux-watch.h: Rename include guard.
9971 * nat/linux-waitpid.h: Rename include guard.
9972 * nat/linux-ptrace.h: Rename include guard.
9973 * nat/linux-procfs.h: Rename include guard.
9974 * nat/linux-osdata.h: Rename include guard.
9975 * nat/linux-nat.h: Rename include guard.
9976 * nat/linux-namespaces.h: Rename include guard.
9977 * nat/linux-btrace.h: Rename include guard.
9978 * nat/glibc_thread_db.h: Rename include guard.
9979 * nat/gdb_thread_db.h: Rename include guard.
9980 * nat/gdb_ptrace.h: Rename include guard.
9981 * nat/fork-inferior.h: Rename include guard.
9982 * nat/amd64-linux-siginfo.h: Rename include guard.
9983 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9984 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9985 * nat/aarch64-linux.h: Rename include guard.
9986 * nat/aarch64-linux-hw-point.h: Rename include guard.
9987 * mn10300-tdep.h: Add include guard.
9988 * mips-linux-tdep.h: Add include guard.
9989 * mi/mi-parse.h: Rename include guard.
9990 * mi/mi-out.h: Rename include guard.
9991 * mi/mi-main.h: Rename include guard.
9992 * mi/mi-interp.h: Rename include guard.
9993 * mi/mi-getopt.h: Rename include guard.
9994 * mi/mi-console.h: Rename include guard.
9995 * mi/mi-common.h: Rename include guard.
9996 * mi/mi-cmds.h: Rename include guard.
9997 * mi/mi-cmd-break.h: Rename include guard.
9998 * m2-lang.h: Add include guard.
9999 * location.h: Rename include guard.
10000 * linux-record.h: Rename include guard.
10001 * linux-nat.h: Add include guard.
10002 * linux-fork.h: Add include guard.
10003 * i386-darwin-tdep.h: Rename include guard.
10004 * hppa-linux-offsets.h: Add include guard.
10005 * guile/guile.h: Rename include guard.
10006 * guile/guile-internal.h: Rename include guard.
10007 * gnu-nat.h: Rename include guard.
10008 * gdb-stabs.h: Rename include guard.
10009 * frv-tdep.h: Add include guard.
10010 * f-lang.h: Add include guard.
10011 * event-loop.h: Add include guard.
10012 * darwin-nat.h: Rename include guard.
10013 * cp-abi.h: Rename include guard.
10014 * config/sparc/nm-sol2.h: Rename include guard.
10015 * config/nm-nto.h: Rename include guard.
10016 * config/nm-linux.h: Add include guard.
10017 * config/i386/nm-i386gnu.h: Rename include guard.
10018 * config/djgpp/nl_types.h: Rename include guard.
10019 * config/djgpp/langinfo.h: Rename include guard.
10020 * compile/gcc-cp-plugin.h: Add include guard.
10021 * compile/gcc-c-plugin.h: Add include guard.
10022 * compile/compile.h: Rename include guard.
10023 * compile/compile-object-run.h: Rename include guard.
10024 * compile/compile-object-load.h: Rename include guard.
10025 * compile/compile-internal.h: Rename include guard.
10026 * compile/compile-cplus.h: Rename include guard.
10027 * compile/compile-c.h: Rename include guard.
10028 * common/xml-utils.h: Rename include guard.
10029 * common/x86-xstate.h: Rename include guard.
10030 * common/version.h: Rename include guard.
10031 * common/vec.h: Rename include guard.
10032 * common/tdesc.h: Rename include guard.
10033 * common/selftest.h: Rename include guard.
10034 * common/scoped_restore.h: Rename include guard.
10035 * common/scoped_mmap.h: Rename include guard.
10036 * common/scoped_fd.h: Rename include guard.
10037 * common/safe-iterator.h: Rename include guard.
10038 * common/run-time-clock.h: Rename include guard.
10039 * common/refcounted-object.h: Rename include guard.
10040 * common/queue.h: Rename include guard.
10041 * common/ptid.h: Rename include guard.
10042 * common/print-utils.h: Rename include guard.
10043 * common/preprocessor.h: Rename include guard.
10044 * common/pathstuff.h: Rename include guard.
10045 * common/observable.h: Rename include guard.
10046 * common/netstuff.h: Rename include guard.
10047 * common/job-control.h: Rename include guard.
10048 * common/host-defs.h: Rename include guard.
10049 * common/gdb_wait.h: Rename include guard.
10050 * common/gdb_vecs.h: Rename include guard.
10051 * common/gdb_unlinker.h: Rename include guard.
10052 * common/gdb_unique_ptr.h: Rename include guard.
10053 * common/gdb_tilde_expand.h: Rename include guard.
10054 * common/gdb_sys_time.h: Rename include guard.
10055 * common/gdb_string_view.h: Rename include guard.
10056 * common/gdb_splay_tree.h: Rename include guard.
10057 * common/gdb_setjmp.h: Rename include guard.
10058 * common/gdb_ref_ptr.h: Rename include guard.
10059 * common/gdb_optional.h: Rename include guard.
10060 * common/gdb_locale.h: Rename include guard.
10061 * common/gdb_assert.h: Rename include guard.
10062 * common/filtered-iterator.h: Rename include guard.
10063 * common/filestuff.h: Rename include guard.
10064 * common/fileio.h: Rename include guard.
10065 * common/environ.h: Rename include guard.
10066 * common/common-utils.h: Rename include guard.
10067 * common/common-types.h: Rename include guard.
10068 * common/common-regcache.h: Rename include guard.
10069 * common/common-inferior.h: Rename include guard.
10070 * common/common-gdbthread.h: Rename include guard.
10071 * common/common-exceptions.h: Rename include guard.
10072 * common/common-defs.h: Rename include guard.
10073 * common/common-debug.h: Rename include guard.
10074 * common/cleanups.h: Rename include guard.
10075 * common/buffer.h: Rename include guard.
10076 * common/btrace-common.h: Rename include guard.
10077 * common/break-common.h: Rename include guard.
10078 * cli/cli-utils.h: Rename include guard.
10079 * cli/cli-style.h: Rename include guard.
10080 * cli/cli-setshow.h: Rename include guard.
10081 * cli/cli-script.h: Rename include guard.
10082 * cli/cli-interp.h: Rename include guard.
10083 * cli/cli-decode.h: Rename include guard.
10084 * cli/cli-cmds.h: Rename include guard.
10085 * charset-list.h: Add include guard.
10086 * buildsym-legacy.h: Rename include guard.
10087 * bfin-tdep.h: Add include guard.
10088 * ax.h: Rename include guard.
10089 * arm-linux-tdep.h: Add include guard.
10090 * arm-fbsd-tdep.h: Add include guard.
10091 * arch/xtensa.h: Rename include guard.
10092 * arch/tic6x.h: Add include guard.
10093 * arch/i386.h: Add include guard.
10094 * arch/arm.h: Rename include guard.
10095 * arch/arm-linux.h: Rename include guard.
10096 * arch/arm-get-next-pcs.h: Rename include guard.
10097 * arch/amd64.h: Add include guard.
10098 * arch/aarch64-insn.h: Rename include guard.
10099 * arch-utils.h: Rename include guard.
10100 * annotate.h: Add include guard.
10101 * amd64-darwin-tdep.h: Rename include guard.
10102 * aarch64-linux-tdep.h: Add include guard.
10103 * aarch64-fbsd-tdep.h: Add include guard.
10104 * aarch32-linux-nat.h: Add include guard.
10105
ab9268d2
PW
101062019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10107
10108 * macrotab.c (macro_define_internal): New function that
10109 factorizes macro_define_object_internal and macro_define_function
10110 code.
10111 (macro_define_object_internal): Use macro_define_internal.
10112 (macro_define_function): Likewise.
10113
bb0da2b4
PW
101142019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10115
10116 * macrocmd.c (extract_identifier): Return
10117 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10118 callers.
10119
424eb552
JB
101202019-02-06 John Baldwin <jhb@FreeBSD.org>
10121
10122 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10123
1688cb29
TT
101242019-02-05 Tom Tromey <tom@tromey.com>
10125
10126 * target.c (target_stack::unpush): Move assertion earlier.
10127
b5eba2d8
TT
101282019-01-30 Tom Tromey <tom@tromey.com>
10129
10130 PR python/23615:
10131 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10132 (gdbpy_parse_and_eval): Likewise.
10133 * python/python-internal.h (gdbpy_allow_threads): New class.
10134
7054e2ff
JB
101352019-01-28 John Baldwin <jhb@FreeBSD.org>
10136
10137 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10138 (aarch64_fbsd_fpregmap): Move earlier.
10139 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10140 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10141 instead of individual calls to trad_frame_set_reg_addr.
10142 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10143 earlier.
10144 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10145 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10146 instead of individual calls to trad_frame_set_reg_addr.
10147
36c25ffa
AH
101482019-01-28 Alan Hayward <alan.hayward@arm.com>
10149
10150 * CONTRIBUTE: Replace contribution list with wiki link.
10151
a0707f3c
TT
101522019-01-25 Tom Tromey <tom@tromey.com>
10153
10154 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10155
0747795c
TT
101562019-01-25 Tom Tromey <tom@tromey.com>
10157
10158 * xtensa-linux-nat.c: Fix common/ includes.
10159 * xml-support.h: Fix common/ includes.
10160 * xml-support.c: Fix common/ includes.
10161 * x86-linux-nat.c: Fix common/ includes.
10162 * windows-nat.c: Fix common/ includes.
10163 * varobj.h: Fix common/ includes.
10164 * varobj.c: Fix common/ includes.
10165 * value.c: Fix common/ includes.
10166 * valops.c: Fix common/ includes.
10167 * utils.c: Fix common/ includes.
10168 * unittests/xml-utils-selftests.c: Fix common/ includes.
10169 * unittests/utils-selftests.c: Fix common/ includes.
10170 * unittests/unpack-selftests.c: Fix common/ includes.
10171 * unittests/tracepoint-selftests.c: Fix common/ includes.
10172 * unittests/style-selftests.c: Fix common/ includes.
10173 * unittests/string_view-selftests.c: Fix common/ includes.
10174 * unittests/scoped_restore-selftests.c: Fix common/ includes.
10175 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10176 * unittests/scoped_fd-selftests.c: Fix common/ includes.
10177 * unittests/rsp-low-selftests.c: Fix common/ includes.
10178 * unittests/parse-connection-spec-selftests.c: Fix common/
10179 includes.
10180 * unittests/optional-selftests.c: Fix common/ includes.
10181 * unittests/offset-type-selftests.c: Fix common/ includes.
10182 * unittests/observable-selftests.c: Fix common/ includes.
10183 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10184 * unittests/memrange-selftests.c: Fix common/ includes.
10185 * unittests/memory-map-selftests.c: Fix common/ includes.
10186 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10187 * unittests/function-view-selftests.c: Fix common/ includes.
10188 * unittests/environ-selftests.c: Fix common/ includes.
10189 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10190 * unittests/common-utils-selftests.c: Fix common/ includes.
10191 * unittests/cli-utils-selftests.c: Fix common/ includes.
10192 * unittests/array-view-selftests.c: Fix common/ includes.
10193 * ui-file.c: Fix common/ includes.
10194 * tui/tui-io.c: Fix common/ includes.
10195 * tracepoint.h: Fix common/ includes.
10196 * tracepoint.c: Fix common/ includes.
10197 * tracefile-tfile.c: Fix common/ includes.
10198 * top.h: Fix common/ includes.
10199 * top.c: Fix common/ includes.
10200 * thread.c: Fix common/ includes.
10201 * target/waitstatus.h: Fix common/ includes.
10202 * target/waitstatus.c: Fix common/ includes.
10203 * target.h: Fix common/ includes.
10204 * target.c: Fix common/ includes.
10205 * target-memory.c: Fix common/ includes.
10206 * target-descriptions.c: Fix common/ includes.
10207 * symtab.h: Fix common/ includes.
10208 * symfile.c: Fix common/ includes.
10209 * stap-probe.c: Fix common/ includes.
10210 * spu-linux-nat.c: Fix common/ includes.
10211 * sparc-nat.c: Fix common/ includes.
10212 * source.c: Fix common/ includes.
10213 * solib.c: Fix common/ includes.
10214 * solib-target.c: Fix common/ includes.
10215 * ser-unix.c: Fix common/ includes.
10216 * ser-tcp.c: Fix common/ includes.
10217 * ser-pipe.c: Fix common/ includes.
10218 * ser-base.c: Fix common/ includes.
10219 * selftest-arch.c: Fix common/ includes.
10220 * s12z-tdep.c: Fix common/ includes.
10221 * rust-exp.y: Fix common/ includes.
10222 * rs6000-aix-tdep.c: Fix common/ includes.
10223 * riscv-tdep.c: Fix common/ includes.
10224 * remote.c: Fix common/ includes.
10225 * remote-notif.h: Fix common/ includes.
10226 * remote-fileio.h: Fix common/ includes.
10227 * remote-fileio.c: Fix common/ includes.
10228 * regcache.h: Fix common/ includes.
10229 * regcache.c: Fix common/ includes.
10230 * record-btrace.c: Fix common/ includes.
10231 * python/python.c: Fix common/ includes.
10232 * python/py-type.c: Fix common/ includes.
10233 * python/py-inferior.c: Fix common/ includes.
10234 * progspace.h: Fix common/ includes.
10235 * producer.c: Fix common/ includes.
10236 * procfs.c: Fix common/ includes.
10237 * proc-api.c: Fix common/ includes.
10238 * printcmd.c: Fix common/ includes.
10239 * ppc-linux-nat.c: Fix common/ includes.
10240 * parser-defs.h: Fix common/ includes.
10241 * osdata.c: Fix common/ includes.
10242 * obsd-nat.c: Fix common/ includes.
10243 * nat/x86-linux.c: Fix common/ includes.
10244 * nat/x86-linux-dregs.c: Fix common/ includes.
10245 * nat/x86-dregs.h: Fix common/ includes.
10246 * nat/x86-dregs.c: Fix common/ includes.
10247 * nat/ppc-linux.c: Fix common/ includes.
10248 * nat/mips-linux-watch.h: Fix common/ includes.
10249 * nat/mips-linux-watch.c: Fix common/ includes.
10250 * nat/linux-waitpid.c: Fix common/ includes.
10251 * nat/linux-ptrace.h: Fix common/ includes.
10252 * nat/linux-ptrace.c: Fix common/ includes.
10253 * nat/linux-procfs.c: Fix common/ includes.
10254 * nat/linux-personality.c: Fix common/ includes.
10255 * nat/linux-osdata.c: Fix common/ includes.
10256 * nat/linux-namespaces.c: Fix common/ includes.
10257 * nat/linux-btrace.h: Fix common/ includes.
10258 * nat/linux-btrace.c: Fix common/ includes.
10259 * nat/fork-inferior.c: Fix common/ includes.
10260 * nat/amd64-linux-siginfo.c: Fix common/ includes.
10261 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10262 * nat/aarch64-linux.c: Fix common/ includes.
10263 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10264 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10265 * namespace.h: Fix common/ includes.
10266 * mips-linux-tdep.c: Fix common/ includes.
10267 * minsyms.c: Fix common/ includes.
10268 * mi/mi-parse.h: Fix common/ includes.
10269 * mi/mi-main.c: Fix common/ includes.
10270 * mi/mi-cmd-env.c: Fix common/ includes.
10271 * memrange.h: Fix common/ includes.
10272 * memattr.c: Fix common/ includes.
10273 * maint.h: Fix common/ includes.
10274 * maint.c: Fix common/ includes.
10275 * main.c: Fix common/ includes.
10276 * machoread.c: Fix common/ includes.
10277 * location.c: Fix common/ includes.
10278 * linux-thread-db.c: Fix common/ includes.
10279 * linux-nat.c: Fix common/ includes.
10280 * linux-fork.c: Fix common/ includes.
10281 * inline-frame.c: Fix common/ includes.
10282 * infrun.c: Fix common/ includes.
10283 * inflow.c: Fix common/ includes.
10284 * inferior.h: Fix common/ includes.
10285 * inferior.c: Fix common/ includes.
10286 * infcmd.c: Fix common/ includes.
10287 * inf-ptrace.c: Fix common/ includes.
10288 * inf-child.c: Fix common/ includes.
10289 * ia64-linux-nat.c: Fix common/ includes.
10290 * i387-tdep.c: Fix common/ includes.
10291 * i386-tdep.c: Fix common/ includes.
10292 * i386-linux-tdep.c: Fix common/ includes.
10293 * i386-linux-nat.c: Fix common/ includes.
10294 * i386-go32-tdep.c: Fix common/ includes.
10295 * i386-fbsd-tdep.c: Fix common/ includes.
10296 * i386-fbsd-nat.c: Fix common/ includes.
10297 * guile/scm-type.c: Fix common/ includes.
10298 * guile/guile.c: Fix common/ includes.
10299 * go32-nat.c: Fix common/ includes.
10300 * gnu-nat.c: Fix common/ includes.
10301 * gdbthread.h: Fix common/ includes.
10302 * gdbarch-selftests.c: Fix common/ includes.
10303 * gdb_usleep.c: Fix common/ includes.
10304 * gdb_select.h: Fix common/ includes.
10305 * gdb_bfd.c: Fix common/ includes.
10306 * gcore.c: Fix common/ includes.
10307 * fork-child.c: Fix common/ includes.
10308 * findvar.c: Fix common/ includes.
10309 * fbsd-nat.c: Fix common/ includes.
10310 * event-top.c: Fix common/ includes.
10311 * event-loop.c: Fix common/ includes.
10312 * dwarf2read.c: Fix common/ includes.
10313 * dwarf2loc.c: Fix common/ includes.
10314 * dwarf2-frame.c: Fix common/ includes.
10315 * dwarf-index-cache.c: Fix common/ includes.
10316 * dtrace-probe.c: Fix common/ includes.
10317 * disasm-selftests.c: Fix common/ includes.
10318 * defs.h: Fix common/ includes.
10319 * csky-tdep.c: Fix common/ includes.
10320 * cp-valprint.c: Fix common/ includes.
10321 * cp-support.h: Fix common/ includes.
10322 * cp-support.c: Fix common/ includes.
10323 * corelow.c: Fix common/ includes.
10324 * completer.h: Fix common/ includes.
10325 * completer.c: Fix common/ includes.
10326 * compile/compile.c: Fix common/ includes.
10327 * compile/compile-loc2c.c: Fix common/ includes.
10328 * compile/compile-cplus-types.c: Fix common/ includes.
10329 * compile/compile-cplus-symbols.c: Fix common/ includes.
10330 * command.h: Fix common/ includes.
10331 * cli/cli-dump.c: Fix common/ includes.
10332 * cli/cli-cmds.c: Fix common/ includes.
10333 * charset.c: Fix common/ includes.
10334 * build-id.c: Fix common/ includes.
10335 * btrace.h: Fix common/ includes.
10336 * btrace.c: Fix common/ includes.
10337 * breakpoint.h: Fix common/ includes.
10338 * breakpoint.c: Fix common/ includes.
10339 * ax.h:
10340 (enum agent_op): Fix common/ includes.
10341 * ax-general.c (struct aop_map): Fix common/ includes.
10342 * ax-gdb.c: Fix common/ includes.
10343 * auxv.c: Fix common/ includes.
10344 * auto-load.c: Fix common/ includes.
10345 * arm-tdep.c: Fix common/ includes.
10346 * arch/riscv.c: Fix common/ includes.
10347 * arch/ppc-linux-common.c: Fix common/ includes.
10348 * arch/i386.c: Fix common/ includes.
10349 * arch/arm.c: Fix common/ includes.
10350 * arch/arm-linux.c: Fix common/ includes.
10351 * arch/arm-get-next-pcs.c: Fix common/ includes.
10352 * arch/amd64.c: Fix common/ includes.
10353 * arch/aarch64.c: Fix common/ includes.
10354 * arch/aarch64-insn.c: Fix common/ includes.
10355 * arch-utils.c: Fix common/ includes.
10356 * amd64-windows-tdep.c: Fix common/ includes.
10357 * amd64-tdep.c: Fix common/ includes.
10358 * amd64-sol2-tdep.c: Fix common/ includes.
10359 * amd64-obsd-tdep.c: Fix common/ includes.
10360 * amd64-nbsd-tdep.c: Fix common/ includes.
10361 * amd64-linux-tdep.c: Fix common/ includes.
10362 * amd64-linux-nat.c: Fix common/ includes.
10363 * amd64-fbsd-tdep.c: Fix common/ includes.
10364 * amd64-fbsd-nat.c: Fix common/ includes.
10365 * amd64-dicos-tdep.c: Fix common/ includes.
10366 * amd64-darwin-tdep.c: Fix common/ includes.
10367 * agent.c: Fix common/ includes.
10368 * ada-lang.h: Fix common/ includes.
10369 * ada-lang.c: Fix common/ includes.
10370 * aarch64-tdep.c: Fix common/ includes.
10371
2f5c153e
TT
103722019-01-25 Tom Tromey <tom@tromey.com>
10373
10374 * common/create-version.sh: Use common/version.h.
10375
adc6a863
PA
103762019-01-24 Pedro Alves <palves@redhat.com>
10377
10378 * infrun.c (signal_stop, signal_print, signal_program)
10379 (signal_catch, signal_pass): Now arrays instead of pointers.
10380 (update_signals_program_target, do_target_resume)
10381 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10382 * linux-nat.c (linux_nat_target::pass_signals)
10383 (linux_nat_target::create_inferior, linux_nat_target::attach):
10384 Adjust.
10385 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10386 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10387 * procfs.c (procfs_target::pass_signals): Adjust.
10388 * record-full.c (record_full_target::resume): Adjust.
10389 * remote.c (remote_target::pass_signals)
10390 (remote_target::program_signals): Adjust.
10391 * target-debug.h (target_debug_print_signals): Now takes a
10392 gdb::array_view as parameter. Adjust.
10393 * target.h (target_ops) <pass_signals, program_signals>: Replace
10394 pointer and length parameters with gdb::array_view.
10395 (target_pass_signals, target_program_signals): Likewise.
10396 * target-delegates.c: Regenerate.
10397
3046d67a
PA
103982019-01-24 Pedro Alves <palves@redhat.com>
10399
10400 * common/forward-scope-exit.h
10401 (forward_scope_exit::forward_scope_exit): Pass arguments to
10402 m_bind_function directly, instead of creating a std::bind and
10403 copying that.
10404
353229bf
AH
104052019-01-24 Alan Hayward <alan.hayward@arm.com>
10406
10407 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10408 for static members.
10409 (pass_in_v_vfp_candidate): Likewise.
10410
311dc83a
TT
104112019-01-23 Tom Tromey <tom@tromey.com>
10412 Pedro Alves <palves@redhat.com>
10413
10414 * regcache.c (class regcache_invalidator): Remove.
10415 (regcache::raw_write): Use make_scope_exit.
10416
296bd123
TT
104172019-01-23 Tom Tromey <tom@tromey.com>
10418
10419 * ui-out.h (class ui_out_emit_type): Update comment.
10420
979a0d13
TT
104212019-01-23 Tom Tromey <tom@tromey.com>
10422
10423 * infrun.c (fetch_inferior_event): Update comment.
10424
d238133d
TT
104252019-01-23 Tom Tromey <tom@tromey.com>
10426 Pedro Alves <palves@redhat.com>
10427
10428 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10429 parameter.
10430 (fetch_inferior_event): Use SCOPE_EXIT.
10431
10432
9885e6bb
TT
104332019-01-23 Tom Tromey <tom@tromey.com>
10434 Pedro Alves <palves@redhat.com>
10435
10436 * infrun.c (disable_thread_events): Delete.
10437 (stop_all_threads): Use SCOPE_EXIT.
10438
286526c1
TT
104392019-01-23 Tom Tromey <tom@tromey.com>
10440 Pedro Alves <palves@redhat.com>
10441
10442 * symfile.c: Include forward-scope-exit.h.
10443 (clear_symtab_users_cleanup): Replace forward declaration with
10444 a FORWARD_SCOPE_EXIT.
10445 (syms_from_objfile_1): Use the forward_scope_exit and
10446 gdb::optional instead of cleanup_function.
10447 (reread_symbols): Use the forward_scope_exit instead of
10448 cleanup_function.
10449 (clear_symtab_users_cleanup): Remove function.
10450
1db93f14
TT
104512019-01-23 Tom Tromey <tom@tromey.com>
10452 Pedro Alves <palves@redhat.com>
10453
10454 * linux-nat.c: Include scope-exit.h.
10455 (cleanup_target_stop): Remove.
10456 (linux_nat_target::static_tracepoint_markers_by_strid): Use
10457 SCOPE_EXIT.
10458
2cc83d1e
TT
104592019-01-23 Tom Tromey <tom@tromey.com>
10460 Pedro Alves <palves@redhat.com>
10461
10462 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10463 (call_function_by_hand_dummy): Use SCOPE_EXIT.
10464
694c6bf5
TT
104652019-01-23 Tom Tromey <tom@tromey.com>
10466 Andrew Burgess <andrew.burgess@embecosm.com>
10467 Pedro Alves <palves@redhat.com>
10468
10469 * infrun.c (fetch_inferior_event): Use scope_exit.
10470 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10471 * top.c (execute_command): Use scope_exit.
10472 * breakpoint.c (bpstat_do_actions): Use scope_exit.
10473 * utils.c (do_bpstat_clear_actions_cleanup)
10474 (make_bpstat_clear_actions_cleanup): Remove.
10475
4c41382a
TT
104762019-01-23 Tom Tromey <tom@tromey.com>
10477 Pedro Alves <palves@redhat.com>
10478
10479 * infrun.c: Include "common/scope-exit.h"
10480 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10481 (wait_for_inferior): Use SCOPE_EXIT.
10482 (fetch_inferior_event): Use scope_exit.
10483
89f8fb50
TT
104842019-01-23 Tom Tromey <tom@tromey.com>
10485 Pedro Alves <palves@redhat.com>
10486
10487 * breakpoint.c (create_breakpoint): Remove cleanup.
10488
5419bdae
TT
104892019-01-23 Tom Tromey <tom@tromey.com>
10490 Andrew Burgess <andrew.burgess@embecosm.com>
10491 Pedro Alves <palves@redhat.com>
10492
e587ef42
PA
104932019-01-23 Pedro Alves <palves@redhat.com>
10494
10495 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10496
77f0e74c
PA
104972019-01-23 Pedro Alves <palves@redhat.com>
10498 Andrew Burgess <andrew.burgess@embecosm.com>
10499
10500 * gdbthread.h: Include "common/forward-scope-exit.h".
10501 (scoped_finish_thread_state): Redefine custom class in terms of
10502 forward_scope_exit.
10503
5b9b3e53
PA
105042019-01-23 Pedro Alves <palves@redhat.com>
10505 Andrew Burgess <andrew.burgess@embecosm.com>
10506
10507 * common/forward-scope-exit.h: New file.
10508
54b65c9b
PA
105092019-01-23 Pedro Alves <palves@redhat.com>
10510 Andrew Burgess <andrew.burgess@embecosm.com>
10511 Tom Tromey <tom@tromey.com>
10512
10513 * common/scope-exit.h: New file.
10514
cf08fb29
PA
105152019-01-23 Pedro Alves <palves@redhat.com>
10516
10517 * common/preprocessor.h (ESC): Rename to ...
10518 (ESC_PARENS): ... this.
10519 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10520 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10521
ae73e2e2
TT
105222019-01-23 Tom Tromey <tom@tromey.com>
10523
10524 * language.h (class scoped_switch_to_sym_language_if_auto):
10525 Initialize m_lang in both cases.
10526
6594e122
AH
105272019-01-23 Alan Hayward <alan.hayward@arm.com>
10528
10529 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10530 with XCNEW.
10531
a7c9855d
TT
105322019-01-22 Tom Tromey <tom@tromey.com>
10533
10534 * corelow.c: Do not include sys/file.h.
10535
93cc1d53
TT
105362019-01-22 Tom Tromey <tom@tromey.com>
10537
10538 * tui/tui-wingeneral.h: Include gdb_curses.h.
10539
38561778
TT
105402019-01-22 Tom Tromey <tom@tromey.com>
10541
10542 * source-cache.h (class source_cache) <get_source_lines,
10543 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10544
37b3ab5b
TT
105452019-01-22 Tom Tromey <tom@tromey.com>
10546
10547 * remote-fileio.h (struct remote_target): Declare.
10548
3fabc016
TT
105492019-01-22 Tom Tromey <tom@tromey.com>
10550
10551 * python/py-arch.c: Do not include py-ref.h.
10552 * python/py-bpevent.c: Do not include py-ref.h.
10553 * python/py-cmd.c: Do not include py-ref.h.
10554 * python/py-continueevent.c: Do not include py-ref.h.
10555 * python/py-event.h: Do not include py-ref.h.
10556 * python/py-evtregistry.c: Do not include py-ref.h.
10557 * python/py-finishbreakpoint.c: Do not include py-ref.h.
10558 * python/py-frame.c: Do not include py-ref.h.
10559 * python/py-framefilter.c: Do not include py-ref.h.
10560 * python/py-function.c: Do not include py-ref.h.
10561 * python/py-infevents.c: Do not include py-ref.h.
10562 * python/py-linetable.c: Do not include py-ref.h.
10563 * python/py-objfile.c: Do not include py-ref.h.
10564 * python/py-param.c: Do not include py-ref.h.
10565 * python/py-prettyprint.c: Do not include py-ref.h.
10566 * python/py-progspace.c: Do not include py-ref.h.
10567 * python/py-symbol.c: Do not include py-ref.h.
10568 * python/py-symtab.c: Do not include py-ref.h.
10569 * python/py-type.c: Do not include py-ref.h.
10570 * python/py-unwind.c: Do not include py-ref.h.
10571 * python/py-utils.c: Do not include py-ref.h.
10572 * python/py-value.c: Do not include py-ref.h.
10573 * python/py-varobj.c: Do not include py-ref.h.
10574 * python/py-xmethods.c: Do not include py-ref.h.
10575 * python/python.c: Do not include py-ref.h.
10576 * varobj.c: Do not include py-ref.h.
10577
6b4d7774
TT
105782019-01-22 Tom Tromey <tom@tromey.com>
10579
10580 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10581 keyword for bcache.
10582
7af7e9b5
TT
105832019-01-22 Tom Tromey <tom@tromey.com>
10584
10585 * compile/compile-cplus-types.c: Remove a comment by #include.
10586
951d1049
TT
105872019-01-22 Tom Tromey <tom@tromey.com>
10588
10589 * compile/gcc-c-plugin.h: Include compile-internal.h.
10590
d65d5705
TT
105912019-01-22 Tom Tromey <tom@tromey.com>
10592
10593 * stabsread.c (EXTERN): Do not define.
10594 (symnum, next_symbol_text_func, processing_gcc_compilation)
10595 (within_function, global_sym_chain, global_stabs)
10596 (previous_stab_code, this_object_header_files)
10597 (n_this_object_header_files)
10598 (n_allocated_this_object_header_files): Define.
10599 * stabsread.h (EXTERN): Never define. Use "extern".
10600
b6fb1ee5
PW
106012019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10602
10603 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10604 history_value.
10605
be6d4f74
TT
106062019-01-21 Tom Tromey <tom@tromey.com>
10607
10608 * ui-out.c: Fix includes.
10609 * tui/tui-source.c: Fix includes.
10610 * target.c: Fix includes.
10611 * remote.c: Fix includes.
10612 * regcache.c: Fix includes.
10613 * python/py-block.c: Fix includes.
10614 * printcmd.c: Fix includes.
10615 * or1k-tdep.c: Fix includes.
10616 * mi/mi-main.c: Fix includes.
10617 * m32r-tdep.c: Fix includes.
10618 * csky-tdep.c: Fix includes.
10619 * compile/compile-cplus-types.c: Fix includes.
10620 * cli/cli-interp.c: Fix includes.
10621
73021deb
AH
106222019-01-21 Alan Hayward <alan.hayward@arm.com>
10623
10624 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10625 for padding.
10626
7932255d
TT
106272019-01-16 Tom Tromey <tom@tromey.com>
10628
10629 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
10630 earlier.
10631 (struct objfile) <msymbols_range>: Move from top level.
10632 <msymbols>: New method.
10633 (class objfile_msymbols): Remove.
10634 * symtab.c (default_collect_symbol_completion_matches_break_on):
10635 Update.
10636 * symmisc.c (dump_msymbols): Update.
10637 * stabsread.c (scan_file_globals): Update.
10638 * objc-lang.c (info_selectors_command, info_classes_command)
10639 (find_methods): Update.
10640 * minsyms.c (find_solib_trampoline_target): Update.
10641 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10642 * coffread.c (coff_symfile_read): Update.
10643 * ada-lang.c (ada_lookup_simple_minsym)
10644 (ada_collect_symbol_completion_matches): Update.
10645
604b1bfb
TT
106462019-01-16 Tom Tromey <tom@tromey.com>
10647
10648 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10649 type. Remove no-argument constructor.
10650 <iterator::operator++>: Simplify.
10651 <begin>: Update.
10652 <end>: Use minimal_symbol_count.
10653
f252c6d5
TT
106542019-01-16 Tom Tromey <tom@tromey.com>
10655
10656 * objfiles.h (struct objfile) <psymtabs>: New method.
10657 (class objfile_psymtabs): Remove.
10658 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10659 typedef.
10660 <range>: New method.
10661 (require_partial_symbols): Change return type.
10662 * psymtab.c (require_partial_symbols)
10663 (psym_expand_symtabs_matching): Update.
10664 * mdebugread.c (parse_partial_symbols): Update.
10665 * dbxread.c (dbx_end_psymtab): Update.
10666
b669c953
TT
106672019-01-15 Tom Tromey <tom@tromey.com>
10668
10669 * symtab.c (lookup_objfile_from_block)
10670 (lookup_symbol_in_objfile_symtabs)
10671 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10672 (find_line_symtab, info_sources_command)
10673 (default_collect_symbol_completion_matches_break_on)
10674 (make_source_files_completion_list): Update.
10675 * symmisc.c (print_objfile_statistics, dump_objfile)
10676 (maintenance_print_symbols, maintenance_info_symtabs)
10677 (maintenance_check_symtabs, maintenance_info_line_tables):
10678 Update.
10679 * source.c (select_source_symtab)
10680 (forget_cached_source_info_for_objfile): Update.
10681 * objfiles.h (class objfile_compunits): Remove.
10682 (struct objfile) <compunits_range>: New typedef.
10683 (compunits): New method.
10684 * objfiles.c (objfile_relocate1): Update.
10685 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10686 * maint.c (count_symtabs_and_blocks): Update.
10687 * linespec.c (iterate_over_all_matching_symtabs): Update.
10688 * cp-support.c (add_symbol_overload_list_qualified): Update.
10689 * coffread.c (coff_symtab_read): Update.
10690 * ada-lang.c (add_nonlocal_symbols)
10691 (ada_collect_symbol_completion_matches)
10692 (ada_add_global_exceptions): Update.
10693
7e955d83
TT
106942019-01-15 Tom Tromey <tom@tromey.com>
10695
10696 * progspace.h (program_space) <objfiles_safe_range>: New
10697 typedef.
10698 <objfiles_safe>: New method.
10699 * objfiles.h (class all_objfiles_safe): Remove.
10700 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10701 * jit.c (jit_inferior_exit_hook): Update.
10702
2030c079
TT
107032019-01-17 Tom Tromey <tom@tromey.com>
10704
10705 * progspace.h (program_space) <objfiles_range>: New typedef.
10706 <objfiles>: New method.
10707 <objfiles_head>: Rename from objfiles.
10708 (object_files): Update.
10709 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10710 * guile/scm-pretty-print.c
10711 (ppscm_find_pretty_printer_from_objfiles): Update.
10712 * guile/scm-objfile.c (gdbscm_objfiles): Update.
10713 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10714 Update.
10715 * python/py-progspace.c (pspy_get_objfiles): Update.
10716 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10717 Update.
10718 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10719 (objfpy_lookup_objfile_by_build_id): Update.
10720 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10721 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10722 Update.
10723 * symtab.c (iterate_over_symtabs, matching_obj_sections)
10724 (expand_symtab_containing_pc, lookup_objfile_from_block)
10725 (lookup_static_symbol, basic_lookup_transparent_type)
10726 (find_pc_sect_compunit_symtab, find_symbol_at_address)
10727 (find_line_symtab, info_sources_command)
10728 (default_collect_symbol_completion_matches_break_on)
10729 (make_source_files_completion_list, find_main_name): Update.
10730 * symmisc.c (print_symbol_bcache_statistics)
10731 (print_objfile_statistics, maintenance_print_symbols)
10732 (maintenance_print_msymbols, maintenance_print_objfiles)
10733 (maintenance_info_symtabs, maintenance_check_symtabs)
10734 (maintenance_expand_symtabs, maintenance_info_line_tables):
10735 Update.
10736 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10737 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10738 (map_overlay_command, unmap_overlay_command)
10739 (simple_overlay_update, expand_symtabs_matching)
10740 (map_symbol_filenames): Update.
10741 * symfile-debug.c (set_debug_symfile): Update.
10742 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10743 Update.
10744 * source.c (select_source_symtab, forget_cached_source_info):
10745 Update.
10746 * solib.c (solib_read_symbols): Update.
10747 * solib-spu.c (append_ocl_sos): Update.
10748 * psymtab.c (maintenance_print_psymbols)
10749 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10750 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10751 * printcmd.c (info_symbol_command): Update.
10752 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10753 Update.
10754 * objfiles.h (class all_objfiles): Remove.
10755 * objfiles.c (have_partial_symbols, have_full_symbols)
10756 (have_minimal_symbols, qsort_cmp, update_section_map)
10757 (shared_objfile_contains_address_p)
10758 (default_iterate_over_objfiles_in_search_order): Update.
10759 * objc-lang.c (info_selectors_command, info_classes_command)
10760 (find_methods): Update.
10761 * minsyms.c (find_solib_trampoline_target): Update.
10762 * maint.c (maintenance_info_sections)
10763 (maintenance_translate_address, count_symtabs_and_blocks):
10764 Update.
10765 * main.c (captured_main_1): Update.
10766 * linux-thread-db.c (try_thread_db_load_from_pdir)
10767 (has_libpthread): Update.
10768 * linespec.c (iterate_over_all_matching_symtabs)
10769 (search_minsyms_for_name): Update.
10770 * jit.c (jit_find_objf_with_entry_addr): Update.
10771 * hppa-tdep.c (find_unwind_entry)
10772 (hppa_lookup_stub_minimal_symbol): Update.
10773 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10774 Update.
10775 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10776 (elf_gnu_ifunc_resolve_by_got): Update.
10777 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10778 * dwarf-index-write.c (save_gdb_index_command): Update.
10779 * cp-support.c (add_symbol_overload_list_qualified): Update.
10780 * breakpoint.c (create_overlay_event_breakpoint)
10781 (create_longjmp_master_breakpoint)
10782 (create_std_terminate_master_breakpoint)
10783 (create_exception_master_breakpoint): Update.
10784 * blockframe.c (find_pc_partial_function): Update.
10785 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10786 (ada_collect_symbol_completion_matches)
10787 (ada_add_global_exceptions): Update.
10788
776489e0
TT
107892019-01-17 Tom Tromey <tom@tromey.com>
10790
10791 * solib-target.c (lm_info_target_p): Remove typedef. Don't
10792 declare VEC.
10793 (solib_target_parse_libraries): Change return type.
10794 (library_list_start_segment, library_list_start_section)
10795 (library_list_end_library, library_list_start_library); Update.
10796 (solib_target_free_library_list): Remove.
10797 (solib_target_parse_libraries): Remove cleanup. Change return
10798 type.
10799 (solib_target_current_sos): Update.
10800
6471e7d2
TT
108012019-01-17 Tom Tromey <tromey@bapiya>
10802
10803 * valprint.c: Replace "the the" with "the".
10804 * symtab.c: Replace "the the" with "the".
10805 * solib.c: Replace "the the" with "the".
10806 * solib-dsbt.c: Replace "the the" with "the".
10807 * linespec.c: Replace "the the" with "the".
10808 * dwarf2loc.h: Replace "the the" with "the".
10809 * amd64-windows-tdep.c: Replace "the the" with "the".
10810 * aarch64-tdep.c: Replace "the the" with "the".
10811
c24bdb02
KS
108122019-01-16 Keith Seitz <keiths@redhat.com>
10813
10814 PR gdb/23773
10815 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10816 <builder>: Rename to ..
10817 <m_builder>: ... this and make private.
10818 (dwarf2_cu::get_builder): New method. Change all users of
10819 `builder' to use this method.
10820 (dwarf2_start_symtab): Move to ...
10821 (dwarf2_cu::start_symtab): ... here. Update all callers
10822 (setup_type_unit_groups): Move to ...
10823 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
10824 callers.
10825 (dwarf2_cu::reset_builder): New method.
10826 (process_full_compunit, process_full_type_unit): Use
10827 dwarf2_cu::reset_builder.
10828 (follow_die_offset): Record the ancestor CU if it is different
10829 from the followed DIE's CU.
10830 (follow_die_sig_1): Likewise.
10831
8d64371b
TT
108322019-01-15 Tom Tromey <tom@tromey.com>
10833
10834 * remote.c (class remote_state) <buf>: Now a char_vector.
10835 <buf_size>: Remove.
10836 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
10837 parameter.
10838 (remote_target::getpkt_or_notif_sane_1)
10839 (remote_target::getpkt_sane)
10840 (remote_target::getpkt_or_notif_sane): Likewise.
10841 (class remote_target) <putpkt>: New overload.
10842 (remote_target::read_frame): Change type of "buf_p". Remove
10843 sizeof_p parameter.
10844 (packet_ok): New overload.
10845 (packet_check_result): New overload.
10846 Update all uses.
10847
bb277751
TT
108482019-01-14 Tom Tromey <tom@tromey.com>
10849
10850 * remote-notif.c (handle_notification, remote_notif_ack)
10851 (remote_notif_parse): Make "buf" const.
10852 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10853 const.
10854 (remote_notif_parse, remote_notif_ack, handle_notification):
10855 Likewise.
10856 * remote.c (remote_notif_stop_parse): Make "buf" const.
10857 (remote_target::remote_parse_stop_reply): Make "buf" const.
10858 (remote_notif_stop_ack): Make "buf" const.
10859
05be00a8
TT
108602019-01-14 Tom Tromey <tom@tromey.com>
10861
10862 * remote.c (remote_console_output): Make parameter const.
10863
491adeca
TT
108642019-01-14 Tom Tromey <tom@tromey.com>
10865
10866 * target-debug.h (target_debug_print_signals): Constify.
10867 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10868 * procfs.c (procfs_target::pass_signals): Update.
10869 * linux-nat.c (linux_nat_target::pass_signals): Update.
10870 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10871 * target-delegates.c: Rebuild.
10872 * remote.c (remote_target::program_signals): Update.
10873 (remote_target::pass_signals): Update.
10874 * target.c (target_pass_signals): Constify argument.
10875 (target_program_signals): Likewise.
10876 * target.h (struct target_ops) <pass_signals, program_signals>:
10877 Constify argument.
10878 (target_pass_signals, target_program_signals): Constify argument.
10879
bbd94648
TT
108802019-01-14 Tom Tromey <tom@tromey.com>
10881
10882 PR tui/28819:
10883 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10884
6f072a10
PFC
108852019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
10886
10887 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10888 field.
10889 * rs6000-tdep.c: Include reggroups.h.
10890 (IS_V_ALIAS_PSEUDOREG): Define.
10891 (rs6000_register_name): Return names for the "vX" aliases.
10892 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10893 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
10894 aliases. Call default_register_reggroup_p for all other
10895 pseudo-registers.
10896 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10897 New functions.
10898 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10899 Handle "vX" aliases.
10900 (v_alias_pseudo_register_collect): New function.
10901 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10902 (rs6000_gdbarch_init): Initialize "vX" aliases as
10903 pseudo-registers. Restore registration of
10904 rs6000_pseudo_register_reggroup_p with
10905 set_tdesc_pseudo_register_reggroup_p.
10906
1a782351
MF
109072019-01-13 Max Filippov <jcmvbkbc@gmail.com>
10908
10909 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10910 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10911 set_gdbarch_num_pseudo_regs.
10912
d73cff18
PW
109132019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10914
10915 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10916 Remove arg prefixname, add do_set and do_show.
10917 Add member functions set_list and show_list.
10918 * cli/cli-style.c (class cli_style_option): Update accordingly.
10919 (style_set_list): Move to file scope.
10920 (style_show_list): Likewise.
10921 (set_style): Call help_list.
10922 (show_style): Call cmd_show_list.
10923 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10924 Update to use the new macro.
10925
60a90376
JB
109262019-10-12 Joel Brobecker <brobecker@adacore.com>
10927
10928 * ada-lang.c (_initialize_ada_language): Expand the help text
10929 for the "catch exception" command.
10930
9d7c67bf
PW
109312019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10932
10933 * symtab.c (matching_obj_sections): Initialize obj,
10934 declare it closer to its usage.
10935
7cf47dc4
TT
109362019-01-10 Tom Tromey <tom@tromey.com>
10937
10938 * thread-iter.h (inf_threads_iterator): Use next_iterator.
10939 (basic_inf_threads_range): Remove.
10940 (inf_threads_range, inf_non_exited_threads_range)
10941 (safe_inf_threads_range): Use next_adapter.
10942
d3cb6808
KS
109432019-01-10 Keith Seitz <keiths@redhat.com>
10944
10945 PR gdb/23712
10946 PR symtab/23010
10947 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10948 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10949
63a20375
KS
109502019-01-10 Keith Seitz <keiths@redhat.com>
10951
10952 PR gdb/23712
10953 PR symtab/23010
10954 * dictionary.c (pending_to_vector): Remove.
10955 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10956 Remove _1 suffix, replacing functions of the same name. Update
10957 all callers.
10958 (dict_create_hashed, dict_create_hashed_expandable)
10959 (dict_create_linear, dict_create_linear_expandable, dict_free)
10960 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10961 Make functions static.
10962
b026f593
KS
109632019-01-10 Keith Seitz <keiths@redhat.com>
10964
10965 PR gdb/23712
10966 PR symtab/23010
10967 * dictionary.h (struct dictionary): Replace declaration with
10968 multidictionary.
10969 (dict_create_hashed, dict_create_hashed_expandable)
10970 (dict_create_linear, dict_create_linear_expandable)
10971 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10972 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10973 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10974 taking multidictionary argument.
10975 [ALL_DICT_SYMBOLS]: Update for multidictionary.
10976 * block.h (struct block) <dict>: Change to multidictionary
10977 and rename `multidict'.
10978 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10979 symmisc.c: Update all dictionary references to multidictionary.
10980
c7748ee9
KS
109812019-01-10 Keith Seitz <keiths@redhat.com>
10982
10983 PR gdb/23712
10984 PR symtab/23010
10985 * dictionary.c: Include unordered_map.
10986 (pending_to_vector): New function.
10987 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10988 Rewrite the non-"_1" functions to take vector instead
10989 of linked list.
10990 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10991 "new" _1 versions of the same name.
10992 (multidictionary): Define.
10993 (std::hash<enum language): New definition.
10994 (collate_pending_symbols_by_language, mdict_create_hashed)
10995 (mdict_create_hashed_expandable, mdict_create_linear)
10996 (mdict_create_linear_expandable, mdict_free)
10997 (find_language_dictionary, create_new_language_dictionary)
10998 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10999 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11000 (mdict_size, mdict_empty): New functions.
11001 * dictionary.h (mdict_iterator): Define.
11002
67aa1f3c
PA
110032019-01-10 Pedro Alves <palves@redhat.com>
11004
11005 * breakpoint.c (read_uploaded_action)
11006 (create_tracepoint_from_upload): Adjust to use
11007 gdb::unique_xmalloc_ptr.
11008 * ctf.c (ctf_write_uploaded_tp):
11009 (SET_ARRAY_FIELD): Use emplace_back.
11010 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11011 * tracefile-tfile.c (tfile_write_uploaded_tp):
11012 * tracepoint.c (parse_tracepoint_definition): Adjust to use
11013 gdb::unique_xmalloc_ptr.
11014 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11015 at_string, cond_string, cmd_strings>: Replace char pointers
11016 with gdb::unique_xmalloc_ptr.
11017
2f667667
PA
110182019-01-10 Pedro Alves <palves@redhat.com>
11019
11020 * solib-target.c (library_list_start_library): Don't xstrdup name.
11021
36cb7237
PA
110222019-01-10 Pedro Alves <palves@redhat.com>
11023
11024 * mdebugread.c (parse_partial_symbols): Use
11025 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11026
da584958
AB
110272019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11028
11029 * linux-fork.c (scoped_switch_fork_info)
11030 <~scoped_switch_fork_info>: Fix incorrect variable name.
11031
1ef8573c
AB
110322019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11033
11034 * linux-fork.c (scoped_switch_fork_info)
11035 <scoped_switch_fork_info>: Make explicit.
11036 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11037
8d7bcccb
TT
110382019-01-10 Tom Tromey <tom@tromey.com>
11039
11040 * objfiles.h (objfile::reset_psymtabs): Update.
11041 * objfiles.c (objfile::objfile): Update.
11042 * psymtab.h (psymtab_storage::obstack): Update.
11043 (psymtab_storage::m_obstack): Use gdb::optional.
11044 (class psymtab_storage): Update comment. Remove objfile
11045 parameter.
11046 * psymtab.c (psymtab_storage::psymtab_storage): Update.
11047
b596a3c7
TT
110482019-01-10 Tom Tromey <tom@tromey.com>
11049
11050 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11051 <free_psymtabs>: Now private.
11052 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11053 (allocate_psymtab): Use new method.
11054
a9342b62
TT
110552019-01-10 Tom Tromey <tom@tromey.com>
11056
11057 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11058 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11059 * mdebugread.c (parse_partial_symbols): Use
11060 allocate_dependencies.
11061 * dwarf2read.c (dwarf2_create_include_psymtab): Use
11062 allocate_dependencies.
11063 (process_psymtab_comp_unit_reader)
11064 (build_type_psymtab_dependencies): Likewise.
11065 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11066
5af70966
TT
110672019-01-10 Tom Tromey <tom@tromey.com>
11068
11069 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11070 PSYMBOL_SET_LANGUAGE.
11071 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11072
5923a04c
TT
110732019-01-10 Tom Tromey <tom@tromey.com>
11074
11075 * psymtab.h (psymtab_storage::obstack): New method.
11076 <m_obstack>: Rename from obstack; now private.
11077 * psymtab.c (psymtab_storage): Update.
11078 * dwarf2read.c (create_addrmap_from_index)
11079 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11080 Update.
11081
6d6a12bf
TT
110822019-01-10 Tom Tromey <tom@tromey.com>
11083
11084 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11085 * objfiles.h (objfile::reset_psymtabs): New method.
11086
d320c2b5
TT
110872019-01-10 Tom Tromey <tom@tromey.com>
11088
11089 * symmisc.c (print_symbol_bcache_statistics): Update.
11090 (print_objfile_statistics): Update.
11091 * symfile.c (reread_symbols): Update.
11092 * psymtab.h (class psymtab_storage): New.
11093 * psymtab.c (psymtab_storage): New constructor.
11094 (~psymtab_storage): New destructor.
11095 (require_partial_symbols): Update.
11096 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11097 (find_pc_sect_psymtab, find_pc_sect_psymbol)
11098 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11099 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11100 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11101 (start_psymtab_common, end_psymtab_common)
11102 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11103 (allocate_psymtab): Update.
11104 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11105 Update.
11106 (dump_psymtab_addrmap, maintenance_print_psymbols)
11107 (maintenance_check_psymtabs): Update.
11108 (class objfile_psymtabs): Move to objfiles.h.
11109 * psympriv.h (discard_psymtab): Now inline.
11110 (psymtab_discarder::psymtab_discarder): Update.
11111 (psymtab_discarder::~psymtab_discarder): Update.
11112 (ALL_OBJFILE_PSYMTABS): Rewrite.
11113 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11114 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11115 Remove fields.
11116 <partial_symtabs>: New field.
11117 (class objfile_psymtabs): Move from psymtab.h. Update.
11118 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11119 psymbol_cache.
11120 (objfile::~objfile): Don't destroy psymbol_cache.
11121 * mdebugread.c (parse_partial_symbols): Update.
11122 * dwarf2read.c (create_addrmap_from_index)
11123 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11124 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11125 (add_partial_subprogram, dwarf2_ranges_read): Update.
11126 * dwarf-index-write.c (write_address_map)
11127 (write_one_signatured_type, recursively_write_psymbols)
11128 (class debug_names, class debug_names, write_psymtabs_to_index):
11129 Update.
11130
1d94a5a3
TT
111312019-01-10 Tom Tromey <tom@tromey.com>
11132
11133 * symtab.h (SYMBOL_SET_NAMES): Update.
11134 (symbol_set_names): Update.
11135 (MSYMBOL_SET_NAMES): Update.
11136 * symtab.c (symbol_set_names): Change argument to be an
11137 objfile_per_bfd_storage.
11138 * psymtab.c (add_psymbol_to_bcache): Update.
11139 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11140
0f14768a
TT
111412019-01-10 Tom Tromey <tom@tromey.com>
11142
11143 * symtab.c (create_demangled_names_hash): Change argument to be an
11144 objfile_per_bfd_storage.
11145 (symbol_set_names): Update.
11146
6eee24ce
TT
111472019-01-10 Tom Tromey <tom@tromey.com>
11148
11149 * xcoffread.c (xcoff_initial_scan): Unconditionally call
11150 init_psymbol_list.
11151 * psymtab.c (init_psymbol_list): Do nothing if already called.
11152 * psympriv.h (init_psymbol_list): Add comment.
11153 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11154 init_psymbol_list.
11155 * dbxread.c (dbx_symfile_read): Unconditionally call
11156 init_psymbol_list.
11157
75aedd27
TT
111582019-01-10 Tom Tromey <tom@tromey.com>
11159
11160 * xcoffread.c (scan_xcoff_symtab): Update.
11161 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11162 "where".
11163 * mdebugread.c (parse_partial_symbols)
11164 (handle_psymbol_enumerators): Update.
11165 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11166 * dbxread.c (read_dbx_symtab): Update.
11167 * psympriv.h (psymbol_placement): New enum.
11168 (add_psymbol_to_list): Update.
11169
939652a5
TT
111702019-01-10 Tom Tromey <tom@tromey.com>
11171
11172 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11173 static_psymbols parameters.
11174 (scan_xcoff_symtab): Update.
11175 * psymtab.c (start_psymtab_common): Remove global_psymbols and
11176 static_psymbols parameters.
11177 * psympriv.h (start_psymtab_common): Update.
11178 * mdebugread.c (parse_partial_symbols): Update.
11179 * dwarf2read.c (create_partial_symtab): Update.
11180 * dbxread.c (read_dbx_symtab): Update.
11181 (start_psymtab): Remove global_psymbols and static_psymbols
11182 parameters.
11183
baa62830
TT
111842019-01-10 Tom Tromey <tom@tromey.com>
11185
11186 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11187 * psymtab.c (allocate_psymtab): Add comment.
11188 * psympriv.h (allocate_psymtab): Add comment.
11189 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11190 initializations.
11191 * dbxread.c (dbx_end_psymtab): Remove some initializations.
11192
0e8f53ba
TT
111932019-01-10 Tom Tromey <tom@tromey.com>
11194
11195 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11196 Don't declare.
11197 * mipsread.c: Include mdebugread.h.
11198 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11199 Declare.
11200 * elfread.c: Include mdebugread.h.
11201
b22a7c6a
TT
112022019-01-09 Tom Tromey <tom@tromey.com>
11203
11204 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11205 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11206 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11207 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11208 (psym_lookup_symbol, psym_find_last_source_symtab)
11209 (psym_forget_cached_source_info, psym_print_stats)
11210 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11211 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11212 (psym_map_matching_symbols, psym_expand_symtabs_matching)
11213 (psym_find_compunit_symtab_by_address)
11214 (maintenance_print_psymbols, maintenance_info_psymtabs)
11215 (maintenance_check_psymtabs): Use ranged for.
11216 * psymtab.h (class objfile_psymtabs): New.
11217 (require_partial_symbols): Return objfile_psymtabs.
11218 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11219
3b9d3ac2
TT
112202019-01-09 Tom Tromey <tom@tromey.com>
11221
11222 * symfile.c (overlay_invalidate_all, find_pc_overlay)
11223 (find_pc_mapped_section, list_overlays_command)
11224 (map_overlay_command, unmap_overlay_command)
11225 (simple_overlay_update): Use all_objfiles.
11226 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11227 * printcmd.c (info_symbol_command): Use all_objfiles.
11228 * objfiles.h (ALL_OBJSECTIONS): Remove.
11229 * maint.c (maintenance_translate_address): Use all_objfiles.
11230 * gcore.c (gcore_create_callback): Use all_objfiles.
11231 (objfile_find_memory_regions): Likewise.
11232
8b31193a
TT
112332019-01-09 Tom Tromey <tom@tromey.com>
11234
11235 * symtab.c (find_line_symtab, info_sources_command)
11236 (make_source_files_completion_list): Use objfile_compunits.
11237 * source.c (select_source_symtab): Use objfile_compunits.
11238 * objfiles.h (struct objfile): Update comment.
11239 (ALL_OBJFILES): Remove.
11240 (ALL_FILETABS): Remove.
11241 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11242 objfile_compunits.
11243
d5da8b3c
TT
112442019-01-09 Tom Tromey <tom@tromey.com>
11245
11246 * symmisc.c (print_objfile_statistics, dump_objfile)
11247 (maintenance_print_symbols): Use compunit_filetabs.
11248 * source.c (forget_cached_source_info_for_objfile): Use
11249 compunit_filetabs.
11250 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11251 (ALL_FILETABS): Use compunit_filetabs.
11252 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11253 * coffread.c (coff_symtab_read): Use compunit_filetabs.
11254
5accd1a0
TT
112552019-01-09 Tom Tromey <tom@tromey.com>
11256
11257 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11258 (compunit_filetabs): New.
11259 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11260 compunit_filetabs.
11261 (info_sources_command, make_source_files_completion_list): Remove
11262 declaration.
11263 * symmisc.c (print_objfile_statistics, dump_objfile)
11264 (maintenance_print_symbols): Remove declaration.
11265 (maintenance_info_symtabs): Use compunit_filetabs.
11266 (maintenance_info_line_tables): Likewise.
11267 * source.c (select_source_symtab): Change local variable name.
11268 (forget_cached_source_info_for_objfile): Remove declaration.
11269 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11270 * objfiles.c (objfile_relocate1): Remove declaration.
11271 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11272 declaration.
11273 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11274 * coffread.c (coff_symtab_read): Remove declaration.
11275 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11276 compunit_filetabs.
11277
d8aeb77f
TT
112782019-01-09 Tom Tromey <tom@tromey.com>
11279
11280 * symtab.c (lookup_objfile_from_block)
11281 (find_pc_sect_compunit_symtab, search_symbols)
11282 (default_collect_symbol_completion_matches_break_on): Use
11283 objfile_compunits.
11284 * objfiles.h (ALL_COMPUNITS): Remove.
11285 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11286 * cp-support.c (add_symbol_overload_list_qualified): Use
11287 objfile_compunits.
11288 * ada-lang.c (ada_collect_symbol_completion_matches)
11289 (ada_add_global_exceptions): Use objfile_compunits.
11290
592553c4
TT
112912019-01-09 Tom Tromey <tom@tromey.com>
11292
11293 * source.c (select_source_symtab)
11294 (forget_cached_source_info_for_objfile): Remove declaration.
11295 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11296 declaration.
11297 * maint.c (count_symtabs_and_blocks): Remove declaration.
11298 * cp-support.c (add_symbol_overload_list_qualified): Remove
11299 declaration.
11300 * coffread.c (coff_symtab_read): Remove declaration.
11301 * symtab.c (lookup_symbol_in_objfile_symtabs)
11302 (basic_lookup_transparent_type_1): Use objfile_compunits.
11303 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11304 (info_sources_command, search_symbols)
11305 (default_collect_symbol_completion_matches_break_on)
11306 (make_source_files_completion_list): Remove declaration.
11307 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11308 (ada_collect_symbol_completion_matches)
11309 (ada_add_global_exceptions): Remove declaration.
11310 * linespec.c (iterate_over_all_matching_symtabs): Use
11311 objfile_compunits.
11312 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11313 (class objfile_compunits): New.
11314 (ALL_COMPUNITS): Use objfile_compunits.
11315 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11316 (maintenance_check_symtabs, maintenance_info_line_tables): Use
11317 objfile_compunits.
11318 * objfiles.c (objfile_relocate1): Use objfile_compunits.
11319
5325b9bf
TT
113202019-01-09 Tom Tromey <tom@tromey.com>
11321
11322 * symtab.c (search_symbols)
11323 (default_collect_symbol_completion_matches_break_on): Use
11324 objfile_msymbols.
11325 * ada-lang.c (ada_lookup_simple_minsym)
11326 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11327 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11328 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11329 objfile_msymbols.
11330 * coffread.c (coff_symfile_read): Use objfile_msymbols.
11331 * symmisc.c (dump_msymbols): Use objfile_msymbols.
11332 * objc-lang.c (find_methods): Use objfile_msymbols.
11333 (info_selectors_command, info_classes_command): Likewise.
11334 * stabsread.c (scan_file_globals): Use objfile_msymbols.
11335 * objfiles.h (class objfile_msymbols): New.
11336 (ALL_OBJFILE_MSYMBOLS): Remove.
11337 (ALL_MSYMBOLS): Remove.
11338
cac85af2
TT
113392019-01-09 Tom Tromey <tom@tromey.com>
11340
11341 * common/next-iterator.h (next_adapter): Add Iterator template
11342 parameter.
11343 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11344 (class all_objfiles_safe): New.
11345 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11346 * objfiles.c (put_objfile_before): Update comment.
11347 (add_separate_debug_objfile): Likewise.
11348 (free_all_objfiles): Use all_objfiles_safe.
11349 (objfile_purge_solibs): Likewise.
11350
aed57c53
TT
113512019-01-09 Tom Tromey <tom@tromey.com>
11352
11353 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11354 (expand_symtab_containing_pc, lookup_static_symbol)
11355 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11356 (find_symbol_at_address, find_line_symtab, find_main_name): Use
11357 all_objfiles.
11358 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11359 * breakpoint.c (create_overlay_event_breakpoint)
11360 (create_longjmp_master_breakpoint)
11361 (create_std_terminate_master_breakpoint)
11362 (create_exception_master_breakpoint): Use all_objfiles.
11363 * linux-thread-db.c (try_thread_db_load_from_pdir)
11364 (has_libpthread): Use all_objfiles.
11365 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11366 * linespec.c (iterate_over_all_matching_symtabs)
11367 (search_minsyms_for_name): Use all_objfiles.
11368 * maint.c (maintenance_info_sections): Use all_objfiles.
11369 * main.c (captured_main_1): Use all_objfiles.
11370 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11371 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11372 * guile/scm-pretty-print.c
11373 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11374 * solib-spu.c (append_ocl_sos): Use all_objfiles.
11375 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11376 (maintenance_print_msymbols): Use all_objfiles.
11377 * source.c (select_source_symtab): Use all_objfiles.
11378 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11379 * symfile.c (remove_symbol_file_command)
11380 (expand_symtabs_matching, map_symbol_filenames): Use
11381 all_objfiles.
11382 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11383 all_objfiles.
11384 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11385 * objc-lang.c (find_methods): Use all_objfiles.
11386 * objfiles.c (have_partial_symbols, have_full_symbols)
11387 (have_minimal_symbols, qsort_cmp)
11388 (default_iterate_over_objfiles_in_search_order): Use
11389 all_objfiles.
11390 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11391 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11392 (maintenance_check_psymtabs): Use all_objfiles.
11393 (ALL_PSYMTABS): Remove.
11394 * compile/compile-object-run.c (do_module_cleanup): Use
11395 all_objfiles.
11396 * blockframe.c (find_pc_partial_function): Use all_objfiles.
11397 * cp-support.c (add_symbol_overload_list_qualified): Use
11398 all_objfiles.
11399 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11400 Use all_objfiles.
11401 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11402 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11403 all_objfiles.
11404 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11405 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11406 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11407 Uses all_objfiles.
11408 * solib.c (solib_read_symbols): Use all_objfiles
11409
99d89cde
TT
114102019-01-09 Tom Tromey <tom@tromey.com>
11411
11412 * probe.c (parse_probes_in_pspace): Use all_objfiles.
11413 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11414 all_objfiles.
11415 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11416 * symmisc.c (print_symbol_bcache_statistics)
11417 (print_objfile_statistics, maintenance_print_objfiles)
11418 (maintenance_info_symtabs, maintenance_check_symtabs)
11419 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11420 all_objfiles.
11421 * source.c (forget_cached_source_info): Use all_objfiles.
11422 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11423 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11424 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11425 * objfiles.c (update_section_map): Use all_objfiles.
11426 (shared_objfile_contains_address_p): Likewise.
11427 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11428 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11429
21708325
TT
114302019-01-09 Tom Tromey <tom@tromey.com>
11431
11432 * common/next-iterator.h: New file.
11433 * objfiles.h (class all_objfiles): New.
11434 (struct objfile_iterator): New.
11435
669e09f6
PW
114362019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11437
11438 * NEWS: Move the description of the changed "frame", "select-frame",
11439 and "info frame" commands to the Changed commands section.
11440
041be526
SM
114412019-01-09 Simon Marchi <simon.marchi@ericsson.com>
11442
11443 * gdbtypes.c (check_stub_method_group): Remove handling of old
11444 mangling schemes.
11445 * linespec.c (find_methods): Likewise.
11446 * stabsread.c (read_member_functions): Likewise.
11447 * valops.c (search_struct_method): Likewise.
11448 (value_struct_elt_for_reference): Likewise.
11449 * NEWS: Mention this change.
11450
0e2a2133
AB
114512019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
11452
11453 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11454 print_source_lines.
11455 * source.c (print_source_lines_base): Update line number check.
11456 (print_source_lines): New function.
11457 (source_lines_range::source_lines_range): New function.
11458 * source.h (class source_lines_range): New class.
11459 (print_source_lines): New declaration.
11460
1055a3b4
PW
114612019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11462
11463 * linespec.c (linespec_state_destructor): Free self->canonical_names.
11464
cfeadda5
TT
114652019-01-08 Tom Tromey <tom@tromey.com>
11466 Simon Marchi <simon.marchi@ericsson.com>
11467
11468 PR gdb/24060
11469 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11470 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11471 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11472 * f-exp.y (DOLLAR_VARIABLE): Likewise.
11473 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11474 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11475
583068ca
AB
114762019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11477
11478 * source.c (select_source_symtab): Move header comment to
11479 declaration in source.h.
11480 (forget_cached_source_info_for_objfile): Likewise.
11481 (forget_cached_source_info): Likewise.
11482 (identify_source_line): Likewise.
11483 * source.h (identify_source_line): Move declaration from symtab.h
11484 and add comment from source.c
11485 (print_source_lines): Likewise.
11486 (forget_cached_source_info_for_objfile): Likewise.
11487 (forget_cached_source_info): Likewise.
11488 (select_source_symtab): Likewise.
11489 (enum print_source_lines_flag): Move definition from symtab.h.
11490 * symtab.h (identify_source_line): Move declaration to source.h.
11491 (print_source_lines): Likewise.
11492 (forget_cached_source_info_for_objfile): Likewise.
11493 (forget_cached_source_info): Likewise.
11494 (select_source_symtab): Likewise.
11495 (enum print_source_lines_flag): Move definition to source.h.
11496 * tui/tui-hooks.c: Add 'source.h' include.
11497
ec98a4ad
AB
114982019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11499
11500 * source.c (print_source_lines_base): Handle requests to print
11501 reverse line number sequences, and guard against empty lines
11502 string.
11503
62ea19c1
AB
115042019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11505
11506 * source.c (print_source_lines_base): Fix skip of '\r' if next
11507 character is '\n'.
11508
9d30e1fd
TT
115092019-01-06 Tom Tromey <tom@tromey.com>
11510
11511 * c-exp.y (struct c_parse_state) <macro_original_text,
11512 expansion_obstack>: New member.
11513 (macro_original_text, expansion_obstack): Remove globals.
11514 (scan_macro_expansion, scanning_macro_expansion)
11515 (finished_macro_expansion): Update.
11516 (scan_macro_cleanup): Remove.
11517 (yylex, c_parse): Update.
11518
c65bac38
TT
115192019-01-06 Tom Tromey <tom@tromey.com>
11520
11521 * c-exp.y (struct c_parse_state) <strings>: New member.
11522 (operator_stoken): Update.
11523
02e12e38
TT
115242019-01-06 Tom Tromey <tom@tromey.com>
11525
11526 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
11527 (union type_stack_elt) <typelist_val>: Now a pointer to
11528 std::vector.
11529 (type_stack_cleanup): Don't declare.
11530 (push_typelist): Update.
11531 * parse.c (pop_typelist): Return a std::vector.
11532 (push_typelist): Take a std::vector.
11533 (follow_types): Update. Do not free args.
11534 (type_stack_cleanup): Remove.
11535 * c-exp.y (struct c_parse_state): New.
11536 (cpstate): New global.
11537 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11538 (nonempty_typelist): Update.
11539 (func_mod): Create a new vector.
11540 (c_parse): Create a c_parse_state.
11541 (check_parameter_typelist): Do not delete params.
11542 (function_method): Update. Do not delete type_list.
11543
f097f5ad
TT
115442019-01-06 Tom Tromey <tom@tromey.com>
11545
11546 PR gdb/28155:
11547 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11548 check_typedef.
11549 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11550 (print_return_value): Likewise.
11551
d2adf9f1
TT
115522019-01-05 Tom Tromey <tom@tromey.com>
11553
11554 * contrib/cleanup_check.py: Remove.
11555 * contrib/gcc-with-excheck: Remove.
11556 * contrib/exsummary.py: Remove.
11557 * contrib/excheck.py: Remove.
11558
2eab46b1
JB
115592019-01-05 Joel Brobecker <brobecker@adacore.com>
11560
11561 * thread.c (delete_thread_1): Add gdb_assert that THR is not
11562 NULL. Initialize tpprev to NULL instead of assigning it
11563 to NULL on the next statement.
11564 * windows-nat.c (windows_delete_thread): Remove check for
11565 main_thread_id before printing thread exit notifications.
11566 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11567 Remove thread ID check against main_thread_id.
11568 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11569 windows_delete_thread.
11570 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11571
48c5e7e2
TT
115722019-01-04 Tom Tromey <tom@tromey.com>
11573
11574 * compile/compile.c (_initialize_compile): Use upper case for
11575 metasyntactic variables.
11576 * symmisc.c (_initialize_symmisc): Use upper case for
11577 metasyntactic variables.
11578 * psymtab.c (_initialize_psymtab): Use upper case for
11579 metasyntactic variables.
11580 * demangle.c (demangle_command): Use upper case for metasyntactic
11581 variables.
11582 (_initialize_demangler): Likewise.
11583 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11584 variables.
11585
986041cd
TT
115862019-01-03 Tom Tromey <tom@tromey.com>
11587
11588 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11589
7c711119
TT
115902019-01-03 Tom Tromey <tom@tromey.com>
11591
11592 * python/py-symtab.c (salpy_str): Update.
11593 (struct salpy_sal_object) <symtab>: Now a PyObject.
11594 (salpy_dealloc): Update.
11595 (del_objfile_sal): Use gdbpy_ref.
11596
1b20edf0
TT
115972019-01-03 Tom Tromey <tom@tromey.com>
11598
11599 * python/py-type.c (convert_field): Use new_reference. Return
11600 gdbpy_ref.
11601 (make_fielditem): Return gdbpy_ref.
11602 (typy_fields): Update.
11603 (typy_getitem): Update.
11604 (field_name): Return gdbpy_ref. Use new_reference.
11605 (typy_iterator_iternext): Update.
11606
ea41325b
TT
116072019-01-03 Tom Tromey <tom@tromey.com>
11608
11609 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11610
2a3c71d6
TT
116112019-01-03 Tom Tromey <tom@tromey.com>
11612
11613 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11614 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11615 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11616 (pspy_set_frame_filters, pspy_set_frame_unwinders)
11617 (pspy_set_type_printers): Likewise.
11618 * python/py-function.c (fnpy_init): Use gdbpy_ref.
11619 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11620 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11621 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11622 (objfpy_set_type_printers): Likewise.
11623
5c329e6a
TT
116242019-01-03 Tom Tromey <tom@tromey.com>
11625
11626 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11627 (gdbpy_print_stack): Use gdbpy_err_fetch.
11628 * python/python-internal.h (class gdbpy_err_fetch): New class.
11629 (class gdbpy_enter) <m_error_type, m_error_value,
11630 m_error_traceback>: Remove.
11631 <m_error>: New member.
11632 (gdbpy_exception_to_string): Don't declare.
11633 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11634 * python/py-value.c (convert_value_from_python): Use
11635 gdbpy_err_fetch.
11636 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11637 gdbpy_exception_to_string.
11638 (gdbpy_handle_exception): Use gdbpy_err_fetch.
11639 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11640 gdbpy_err_fetch.
11641
169bb27b
AB
116422019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11643
11644 * linux-nat.c (delete_lwp_cleanup): Delete.
11645 (struct lwp_deleter): New struct.
11646 (lwp_info_up): New typedef.
11647 (linux_nat_target::follow_fork): Delete cleanup, and make use of
11648 lwp_info_up.
11649
a07c8880
AB
116502019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11651
11652 * linux-fork.c (class scoped_switch_fork_info): New class.
11653 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11654
26089c49
AB
116552019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11656
11657 * valops.c (find_overload_match): Remove use of null_cleanup, and
11658 calls to do_cleanups.
11659
06d3e5b0
AB
116602019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11661
11662 * compile/compile-cplus-types.c
11663 (compile_cplus_instance::decl_name): Handle changes to
11664 cp_func_name.
11665 * cp-support.c (cp_func_name): Update header comment, update
11666 return type.
11667 * cp-support.h (cp_func_name): Update return type in declaration.
11668 * valops.c (find_overload_match): Move temp_func local to top
11669 level of function and change its type. Use temp_func to hold and
11670 delete temporary string obtained from cp_func_name.
11671
66644cd3
AB
116722019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11673
11674 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11675 gdb::char_vector, remove cleanup, and update uses of `msg`.
11676
592d8c0a
JW
116772019-01-03 Jim Wilson <jimw@sifive.com>
11678
11679 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11680
c55d06ec
TT
116812019-01-02 Tom Tromey <tom@tromey.com>
11682
11683 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11684 (tdesc_parse_xml): Remove cleanups.
11685 * target-descriptions.h (make_cleanup_free_target_description):
11686 Don't declare.
11687 (target_desc_deleter): New struct.
11688 (target_desc_up): New typedef.
11689 * target-descriptions.c (target_desc_deleter::operator()): Rename
11690 from free_target_description.
11691 (make_cleanup_free_target_description): Remove.
11692
3a6ae42d
TT
116932019-01-02 Tom Tromey <tom@tromey.com>
11694
11695 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
11696 constructor, destructor.
11697 (linespec_parser): Remove typedef.
11698 (~linespec_parser): Rename from linespec_parser_delete.
11699 (linespec_lex_to_end, linespec_complete_label)
11700 (linespec_complete): Update.
11701 (decode_line_full): Remove cleanups.
11702 (decode_line_1): Update.
11703
61fd3e73
TT
117042019-01-02 Tom Tromey <tom@tromey.com>
11705
11706 * python/python-internal.h (inferior_to_inferior_object): Change
11707 return type.
11708 * python/py-exitedevent.c (create_exited_event_object): Update.
11709 * python/py-inferior.c (inferior_to_inferior_object): Return
11710 gdbpy_ref.
11711 (python_new_inferior, python_inferior_deleted)
11712 (thread_to_thread_object, delete_thread_object)
11713 (build_inferior_list, gdbpy_selected_inferior): Update.
11714 * python/py-infthread.c (create_thread_object): Update. Also fail
11715 if inferior_to_inferior_object fails.
11716
d20172fc
SM
117172019-01-02 Simon Marchi <simon.marchi@ericsson.com>
11718
11719 * inferior.h (class inferior) <displaced_step_state>: New field.
11720 * infrun.h (struct displaced_step_state): Move here from
11721 infrun.c. Initialize fields, add constructor.
11722 <inf>: Remove field.
11723 <reset>: New method.
11724 * infrun.c (struct displaced_step_inferior_state): Move to
11725 infrun.h.
11726 (displaced_step_inferior_states): Remove.
11727 (get_displaced_stepping_state): Adust.
11728 (displaced_step_in_progress_any_inferior): Adjust.
11729 (displaced_step_in_progress_thread): Adjust.
11730 (displaced_step_in_progress): Adjust.
11731 (add_displaced_stepping_state): Remove.
11732 (get_displaced_step_closure_by_addr): Adjust.
11733 (remove_displaced_stepping_state): Remove.
11734 (infrun_inferior_exit): Call displaced_step_state.reset.
11735 (use_displaced_stepping): Don't check for NULL.
11736 (displaced_step_prepare_throw): Call
11737 get_displaced_stepping_state.
11738 (displaced_step_fixup): Don't check for NULL.
11739 (prepare_for_detach): Don't check for NULL.
11740
e3319240
PW
117412019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11742
11743 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11744 in case of call that did not complete.
11745
5d36dfb9
AU
117462019-01-02 Andrey Utkin <autkin@undo.io>
11747
11748 * symfile.c (find_separate_debug_file): Fix search of debug files for
11749 remote debuggee.
11750
8833fbf0
TT
117512019-01-02 Tom Tromey <tom@tromey.com>
11752
11753 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11754 indentation.
11755 * python/py-frame.c (frapy_older): Remove cast.
11756 (frapy_newer): Likewise.
11757 * python/py-breakpoint.c (local_setattro): Remove cast.
11758 * python/py-arch.c (archpy_name): Remove local variable.
11759 * python/py-type.c (gdbpy_lookup_type): Remove cast.
11760
4ada3dfd
JB
117612019-01-02 Joel Brobecker <brobecker@adacore.com>
11762
11763 * unittests/basic_string_view/element_access/char/empty.cc:
11764 Fix year range in copyright header.
11765
113b7b81
AB
117662019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
11767
11768 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11769 Delete.
11770 <operator==>: Update with for removed field.
11771 <hash>: Likewise.
11772 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11773 <isa_features>: ...this.
11774 <abi_features>: New field.
11775 (riscv_isa_flen): Update comment.
11776 (riscv_abi_xlen): New declaration.
11777 (riscv_abi_flen): New declaration.
11778 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11779 isa_features.
11780 (riscv_abi_xlen): New function.
11781 (riscv_isa_flen): Update to get answer from isa_features.
11782 (riscv_abi_flen): New function.
11783 (riscv_has_fp_abi): Update to get answer from abi_features.
11784 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11785 xlen and flen.
11786 (riscv_call_info) <xlen, flen>: Update comment.
11787 (riscv_call_arg_struct): Remove invalid assertions
11788 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11789 is removed.
11790 (riscv_gdbarch_init): Gather isa features and abi features
11791 separately, ensure both match on the gdbarch when reusing an old
11792 gdbarch. Relax an error check to allow 32-bit abi float to run on
11793 a target with 64-bit float hardware.
11794
b18ca514
PW
117952019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11796
11797 * source.c (search_command_helper): Stop reverse search
11798 when line 1 has been searched.
11799
ec70d8db
PW
118002019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11801
11802 * record-full.c (record_full_base_target::close): Rewrite
11803 record_full_core_buf_list free logic.
11804
5b38f9c1
PW
118052019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11806
11807 * break-catch-syscall.c (print_one_catch_syscall): xfree
11808 the last text.
11809
66d91b39
JB
118102019-01-01 Joel Brobecker <brobecker@adacore.com>
11811
11812 * top.c (print_gdb_version): Update Copyright year in version
11813 message.
11814
42a4f53d
JB
118152019-01-01 Joel Brobecker <brobecker@adacore.com>
11816
11817 Update copyright year range in all GDB files.
11818
7e955d83 118192019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 11820
5bbd631d 11821 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 11822
5bbd631d 11823For older changes see ChangeLog-2018.
c906108c
SS
11824\f
11825Local Variables:
11826mode: change-log
11827left-margin: 8
11828fill-column: 74
11829version-control: never
57da7796 11830coding: utf-8
c906108c 11831End:
5bbd631d 11832