]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blame - gdb/ChangeLog
Clean up source file error reporting
[thirdparty/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
b08b16c8
TT
12019-08-06 Tom Tromey <tromey@adacore.com>
2
3 * source.c (last_source_error): Now bool.
4 (print_source_lines_base): Make "noprint" bool. Only open
5 source file when last_source_visited changes.
6
cb44333d
TT
72019-08-06 Tom Tromey <tromey@adacore.com>
8
9 * annotate.c (annotate_source_line): Use g_source_cache.
10 * source-cache.c (source_cache::get_plain_source_lines): Change
11 parameters. Populate m_offset_cache.
12 (source_cache::ensure): New method.
13 (source_cache::get_line_charpos): New method.
14 (extract_lines): Move lower. Change parameters.
15 (source_cache::get_source_lines): Move lower.
16 * source-cache.h (class source_cache): Update comment.
17 <get_line_charpos>: New method.
18 <get_source_lines>: Update comment.
19 <clear>: Clear m_offset_cache.
20 <get_plain_source_lines>: Change parameters.
21 <ensure>: New method
22 <m_offset_cache>: New member.
23 * source.c (forget_cached_source_info_for_objfile): Update.
24 (info_source_command): Use g_source_cache.
25 (find_source_lines, open_source_file_with_line_charpos): Remove.
26 (print_source_lines_base, search_command_helper): Use g_source_cache.
27 * source.h (open_source_file_with_line_charpos): Don't declare.
28 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
29 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
30 Use g_source_cache.
31
872dceaa
TT
322019-08-06 Tom Tromey <tromey@adacore.com>
33
34 * source-cache.c (source_cache::get_plain_source_lines):
35 Remove "first_line" and "last_line" parameters.
36 (source_cache::get_source_lines): Cache plain text.
37 * source-cache.h (class source_cache)
38 <get_plain_source_lines>: Update.
39
269249d9
TT
402019-08-06 Tom Tromey <tromey@adacore.com>
41
42 * source-cache.c (extract_lines): No longer a method.
43 Changed type of parameter. Include final newline.
44 (selftests::extract_lines_test): New function.
45 (_initialize_source_cache): Likewise.
46 * source-cache.h (class source_cache)
47 <extract_lines>: Don't declare.
48
c0e8dcd8
TT
492019-08-06 Tom Tromey <tromey@adacore.com>
50
51 * breakpoint.c (init_breakpoint_sal): Update.
52 (breakpoint): Update.
53 * breakpoint.h (struct breakpoint) <filter>: Now a
54 unique_xmalloc_ptr.
55
0b27c27d
CB
562019-08-05 Christian Biesinger <cbiesinger@google.com>
57
58 * NEWS: Mention dictionary access on blocks.
59 * python/py-block.c (blpy_getitem): New function.
60 (block_object_as_mapping): New struct.
61 (block_object_type): Use new struct for tp_as_mapping field.
62
4ee94178
CB
632019-08-05 Christian Biesinger <cbiesinger@google.com>
64
65 * objfiles.h (objfile): Add a comment describing partial symbols.
66
8abfcabc
TT
672019-08-05 Tom Tromey <tromey@adacore.com>
68
69 * compile/compile.c (_initialize_compile): Use _(), not N_().
70 * thread.c (_initialize_thread): Use _(), not N_().
71 * stack.c (_initialize_stack): Use _(), not N_().
72 * printcmd.c (_initialize_printcmd): Use _(), not N_().
73
2b79f376
SM
742019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
75
76 * dwarf2read.c (struct dw2_symtab_iterator):
77 <want_specific_block>: Remove.
78 <block_index>: Change type to gdb::optional.
79 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
80 change type of BLOCK_INDEX parameter to gdb::optional.
81 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
82 (dw2_lookup_symbol): Don't pass argument for
83 WANT_SPECIFIC_BLOCK.
84 (dw2_expand_symtabs_for_function): Don't pass argument for
85 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
86 (class dw2_debug_names_iterator)
87 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
88 parameter, change BLOCK_INDEX type to gdb::optional.
89 <m_want_specific_block>: Remove.
90 <m_block_index>: Change type to gdb::optional.
91 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
92 gdb::optional. Re-write in function of gdb::optional.
93 (dw2_debug_names_lookup_symbol): Don't pass argument for
94 WANT_SPECIFIC_BLOCK.
95 (dw2_debug_names_expand_symtabs_for_function): Don't pass
96 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
97 BLOCK_INDEX.
98
ae60f04e
PW
992019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
100
101 * NEWS: Mention changes to "info sources" command.
102
28cd9371
PW
1032019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
104
105 * symtab.c (filename_partial_match_opts): New struct type.
106 (struct output_source_filename_data): New members
107 regexp, c_regexp, partial_match.
108 (output_source_filename): Use new members to decide to print file.
109 (info_sources_option_defs): New variable.
110 (make_info_sources_options_def_group, print_info_sources_header,
111 info_sources_command_completer):
112 New functions.
113 (info_sources_command): Read new optional arguments.
114 (_initialize_symtab): Update info sources help.
115
ca683e3a
AO
1162019-08-02 Alexandre Oliva <oliva@adacore.com>
117
118 * ada-lang.c (exception_support_info_v0): Renamed from...
119 (default_exception_support_info): ... this. Create new
120 definition for v1.
121 (ada_has_this_exception_support): Look up catch_handlers_sym.
122 (ada_exception_support_info_sniffer): Try v0 after default.
123
f1264162
TT
1242019-08-01 Tom Tromey <tromey@adacore.com>
125
126 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
127 gdbarch.h.
128
0a7b2485
CB
1292019-08-01 Christian Biesinger <cbiesinger@google.com>
130
131 * s12z-tdep.c: Fix include path for s12z-opc.h.
132
c6bdbeb7
AH
1332019-08-01 Alan Hayward <alan.hayward@arm.com>
134
135 * NEWS: Require GNU make 3.82.
136
a2bd7b82
TT
1372019-07-16 Tom Tromey <tom@tromey.com>
138
139 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
140 declare.
141
aa3b6533
TT
1422019-07-30 Tom Tromey <tromey@adacore.com>
143
144 * block.c (contained_in): Remove BLOCK_FUNCTION check.
145
a1530dc7
KB
1462019-07-30 Kevin Buettner <kevinb@redhat.com>
147
148 * printcmd.c (print_address_symbolic): Print negative offsets.
149 (build_address_symbolic): Force signed arithmetic when computing
150 offset.
151
2906593f
CB
1522019-07-30 Christian Biesinger <cbiesinger@google.com>
153
154 PR/24474: Add a function to lookup static variables.
155 * NEWS: Mention this new function.
156 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
157 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
158 * python/python.c (python_GdbMethods): Add new function.
159
c620ed88
CB
1602019-07-29 Christian Biesinger <cbiesinger@google.com>
161
162 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
163 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
164 (objfpy_lookup_static_symbol): New function.
165 (objfile_object_methods): Add new functions.
166
bc4268a5
PW
1672019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
168
169 * NEWS: Mention 'set|show print frame-info'. Mention new
170 'presence' value for 'frame-arguments'. Mention new '-frame-info'
171 backtrace argument. Mention that python frame filtering code
172 is now consistent with what 'backtrace' command prints.
173
4b5e8d19
PW
1742019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
175
176 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
177 comments.
178 (print_frame_info_auto, print_frame_info_source_line,
179 print_frame_info_location, print_frame_info_source_and_location,
180 print_frame_info_location_and_address, print_frame_info_short_location):
181 New declarations.
182 (struct frame_print_options): New member print_frame_info.
183 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
184 * stack.h (get_user_print_what_frame_info): New declaration.
185 (frame_show_address): New declaration.
186 * stack.c (print_frame_arguments_choices): New value 'presence'.
187 (print_frame_info_auto, print_frame_info_source_line,
188 print_frame_info_location, print_frame_info_source_and_location,
189 print_frame_info_location_and_address, print_frame_info_short_location,
190 print_frame_info_choices, print_frame_info_print_what): New definitions.
191 (print_frame_args): Only print dots for args if print frame-arguments
192 is 'presence'.
193 (frame_print_option_defs): New element for "frame-info".
194 (get_user_print_what_frame_info): New function.
195 (frame_show_address): Make non static. Move comment to stack.h.
196 (print_frame_info_to_print_what): New function.
197 (print_frame_info): Update comment. Use fp_opts.print_frame_info
198 to decide what to print.
199 (backtrace_command_1): Handle the new print_frame_arguments_presence
200 value.
201 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
202 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
203 (py_print_frame): In non-mi mode, use LOCATION as default for
204 print_what, similarly to frame information printed directly by
205 backtrace command. Handle frame-info user option in non MI mode.
206
6bdfee81
KB
2072019-07-27 Kevin Buettner <kevinb@redhat.com>
208
209 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
210 Add case for debugging 32-bit target on 64-bit host. Revise
211 comment.
212
98a617f8
KB
2132019-07-27 Kevin Buettner <kevinb@redhat.com>
214
215 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
216 instead of find_function_entry_range_from_pc.
217
567238c9
KB
2182019-07-27 Kevin Buettner <kevinb@redhat.com>
219
220 * stack.c (find_frame_funname): Remove code which preferred
221 minsym over symtab sym in "certain pathological cases".
222
2dc80cf8
KB
223 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
224 parameter. Change type of "do_demangle" to bool.
225 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
226 Pass suitable "prefer_sym_over_minsym" flag to
227 build_address_symbolic(). Don't output "+" for negative offsets.
228 * printcmd.c (print_address_symbolic): Update invocation of
229 build_address_symbolic to include a "prefer_sym_over_minsym"
230 flag.
231 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
232 Restrict cases in which use of minimal symbol is preferred to that
233 of a found symbol. Update comments.
234
1aff7173
KB
235 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
236 for entry pc when entry pc is out of range for that FDE.
237
89b085ac
BC
2382019-07-26 Brian Callahan <bcallah@openbsd.org>
239
240 PR gdb/24839:
241 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
242 type.
243
f32feb4a
CB
2442019-07-25 Christian Biesinger <cbiesinger@google.com>
245
246 * python/py-objfile.c (add_separate_debug_file): Fix comment about
247 this function's Python signature.
248
249
2502019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
251
252 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
253 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
254 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
255 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
256 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
257
258
c54e4253
YS
2592019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
260
261 * h8300-tdep.c (h8300_register_name_common): New.
262 h8300_register_name): Use h8300_register_name_common.
263 (h8300s_register_name): Likewise.
264 (h8300sx_register_name): Likewise.
265 (h8300h_register_nam): New.
266 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
267
268
40eadf04
SP
2692019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
270
271 * arm-tdep.c (arm_skip_cmse_entry): New function.
272 (arm_is_sgstubs_section): New function.
273 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
274
bfa2a36d
TT
2752019-07-22 Tom Tromey <tom@tromey.com>
276
277 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
278 Don't self-assign.
279
a8e9d247
AB
2802019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
281
282 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
283 type_print.
284
eb86c5e2
AB
2852019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
286
287 * symtab.c (search_symbols): Adjust msymbol matching type arrays
288 so that GDB doesn't match any msymbols when searching in the
289 TYPES_DOMAIN.
290 (print_symbol_info): Print using typedef_print or type_print based
291 on the type of the symbol. Add updated FIXME comment moved from...
292 (_initialize_symtab): ... move and update FIXME comment to above.
293
a8eab7c6
AB
2942019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
295
296 * NEWS: Mention adding -q option to "info types".
297 * symtab.c (struct info_types_options): New struct.
298 (info_types_options_defs): New variable.
299 (make_info_types_options_def_group): New function.
300 (info_types_command): Use gdb::option framework to parse options.
301 (info_types_command_completer): New function.
302 (_initialize_symtab): Extend the help text on "info types" and
303 register command completer.
304
b4603c34
CB
3052019-07-21 Christian Biesinger <cbiesinger@google.com>
306
307 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
308 (lookup_symbol_in_objfile): Change int to block_enum and add a
309 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
310
c8cdc1e0
CB
3112019-07-20 Christian Biesinger <cbiesinger@google.com>
312
313 * MAINTAINERS (Write After Approval): Add self.
314
01e175fe
AB
3152019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
316
317 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
318 instruction to the dummy code region.
319
56f79b63
TT
3202019-07-19 Tom Tromey <tromey@adacore.com>
321
322 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
323 (ARGSUSED, PARAMS, __func__): Remove rules.
324
4c5aa8e0
AH
3252019-07-19 Alan Hayward <alan.hayward@arm.com>
326
327 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
328 * features/arm/arm-with-iwmmxt.c: Remove.
329 * features/arm/arm-with-iwmmxt.xml: Remove.
330 * features/arm/arm-with-m-fpa-layout.c: Remove.
331 * features/arm/arm-with-m-fpa-layout.xml: Remove.
332 * features/arm/arm-with-m-vfp-d16.c: Remove.
333 * features/arm/arm-with-m-vfp-d16.xml: Remove.
334 * features/arm/arm-with-m.c: Remove.
335 * features/arm/arm-with-m.xml: Remove.
336 * features/arm/arm-with-neon.c: Remove.
337 * features/arm/arm-with-neon.xml: Remove.
338 * features/arm/arm-with-vfpv2.c: Remove.
339 * features/arm/arm-with-vfpv2.xml: Remove.
340 * features/arm/arm-with-vfpv3.c: Remove.
341 * features/arm/arm-with-vfpv3.xml: Remove.
342
f42b2617
AH
3432019-07-19 Alan Hayward <alan.hayward@arm.com>
344
345 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
346
f29ec966
AH
3472019-07-19 Alan Hayward <alan.hayward@arm.com>
348
349 * arch/aarch32.c (aarch32_create_target_description): Create
350 target descriptions using features.
351 * arch/arm.c (arm_create_target_description)
352 (arm_create_mprofile_target_description): Likewise.
353 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
354
d105cce5
AH
3552019-07-19 Alan Hayward <alan.hayward@arm.com>
356
357 * Makefile.in: Add new files.
358 * aarch32-tdep.c: New file.
359 * aarch32-tdep.h: New file.
360 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
361 Call aarch32_read_description.
362 * arch/aarch32.c: New file.
363 * arch/aarch32.h: New file.
364 * arch/arm.c (arm_create_target_description)
365 (arm_create_mprofile_target_description): New function.
366 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
367 (arm_create_target_description)
368 (arm_create_mprofile_target_description): New declaration.
369 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
370 read_description functions.
371 * arm-linux-nat.c (arm_linux_nat_target::read_description):
372 Likewise.
373 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
374 * arm-tdep.c (tdesc_arm_list): New variable.
375 (arm_register_g_packet_guesses): Call create description functions.
376 (arm_read_description) (arm_read_mprofile_description): New
377 function.
378 * arm-tdep.h (arm_read_description)
379 (arm_read_mprofile_description): Add declaration.
380 * configure.tgt: Add new files.
381
afe09f0b
GL
3822019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
383
384 * top.c (new_ui_command): Open specified terminal just once.
385
cd215b2e
TT
3862019-07-18 Tom Tromey <tromey@adacore.com>
387
388 * symtab.c (main_name): Constify return type.
389 * symfile.c (set_initial_language): Update.
390 * symtab.h (main_name): Constify return type.
391
d8f68fcb
TT
3922019-07-17 Tom Tromey <tom@tromey.com>
393
394 * tui/tui-winsource.c (tui_update_source_window)
395 (tui_update_source_window_as_is)
396 (tui_update_source_windows_with_line): Remove return.
397 * tui/tui-disasm.c (tui_show_disassem)
398 (tui_show_disassem_and_update_source): Remove return.
399 * tui/tui.c (tui_reset): Remove return.
400 * tui/tui-wingeneral.c
401 (tui_check_and_display_highlight_if_needed): Remove return.
402
ca5af91e
TT
4032019-07-17 Tom Tromey <tom@tromey.com>
404
405 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
406
5104fe36
TT
4072019-07-17 Tom Tromey <tom@tromey.com>
408
409 * tui/tui-winsource.h (struct tui_exec_info_window)
410 (struct tui_source_window_base): Move from tui-data.h.
411 * tui/tui-winsource.c: Move many method definitions from
412 elsewhere. Remove "structuring" comments.
413 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
414 (tui_source_window_base::refresh_window): Move to
415 tui-winsource.c.
416 * tui/tui-win.c (tui_source_window_base::refresh_all)
417 (tui_source_window_base::update_tab_width)
418 (tui_source_window_base::set_new_height)
419 (tui_source_window_base::do_make_visible_with_new_height): Move to
420 tui-winsource.c.
421 * tui/tui-source.h: Update.
422 * tui/tui-source.c (tui_source_window_base::reset): Move to
423 tui-winsource.c.
424 * tui/tui-disasm.h: Update.
425 * tui/tui-data.h (struct tui_exec_info_window): Move to
426 tui-winsource.h.
427 (struct tui_source_window_base): Likewise.
428 * tui/tui-data.c (tui_source_window_base::clear_detail)
429 (tui_source_window_base, ~tui_source_window_base): Move to
430 tui-winsource.c.
431
daa15dde
TT
4322019-07-17 Tom Tromey <tom@tromey.com>
433
434 * tui/tui-win.c (tui_resize_all)
435 (tui_source_window_base::update_tab_width)
436 (tui_adjust_win_heights): Update.
437 (tui_win_info::make_invisible_and_set_new_height): Rename from
438 make_invisible_and_set_new_height.
439 * tui/tui-data.h (struct tui_win_info)
440 <make_invisible_and_set_new_height>: New method.
441
bfad4537
TT
4422019-07-17 Tom Tromey <tom@tromey.com>
443
444 * tui/tui.c: Update.
445 * tui/tui-source.h (struct tui_source_window): Move from
446 tui-data.h.
447 * tui/tui-layout.c: Update.
448 * tui/tui-disasm.c: Update.
449 * tui/tui-data.h (struct tui_source_window): Move to
450 tui-source.h.
451
88f7e873
TT
4522019-07-17 Tom Tromey <tom@tromey.com>
453
454 * tui/tui-disasm.h (struct tui_disasm_window): Move from
455 tui-data.h.
456 * tui/tui-data.h (struct tui_disasm_window): Move to
457 tui-disasm.h.
458
96bd6233
TT
4592019-07-17 Tom Tromey <tom@tromey.com>
460
461 * tui/tui-regs.h (struct tui_data_item_window): Move from
462 tui-data.h.
463 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
464 * tui/tui-data.h (struct tui_data_item_window): Move to
465 tui-regs.h.
466 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
467
ce38393b
TT
4682019-07-17 Tom Tromey <tom@tromey.com>
469
470 * tui/tui.c: Update.
471 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
472 (tui_cmd_window::max_height): Move to tui-command.c.
473 * tui/tui-layout.c: Update.
474 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
475 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
476 tui-command.c.
477 * tui/tui-command.h (struct tui_cmd_window): Move from
478 tui-data.h.
479 * tui/tui-command.c: Remove "structuring" comments.
480 (tui_cmd_window::clear_detail)
481 (tui_cmd_window::do_make_visible_with_new_height)
482 (tui_cmd_window::max_height): Move from elsewhere.
483
2d8b51cb
TT
4842019-07-17 Tom Tromey <tom@tromey.com>
485
486 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
487 Now static.
488 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
489 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
490
18ab23af
TT
4912019-07-17 Tom Tromey <tom@tromey.com>
492
493 * tui/tui.c: Update.
494 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
495 tui-regs.c.
496 * tui/tui-windata.h: Remove file.
497 * tui/tui-windata.c: Remove file.
498 * tui/tui-win.c (tui_data_window::set_new_height)
499 (tui_data_window::do_make_visible_with_new_height): Move to
500 tui-regs.c.
501 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
502 * tui/tui-regs.c: Remove "structuring" comments.
503 (tui_data_window::first_data_item_displayed)
504 (tui_data_window::delete_data_content_windows)
505 (tui_data_window::erase_data_content)
506 (tui_data_window::display_all_data)
507 (tui_data_window::refresh_all)
508 (tui_data_window::do_scroll_vertical)
509 (tui_data_window::clear_detail, tui_data_window::set_new_height)
510 (tui_data_window::do_make_visible_with_new_height)
511 (tui_data_window::refresh_window): Move from elsewhere.
512 (_initialize_tui_regs): Move to end of file.
513 * tui/tui-layout.c: Update.
514 * tui/tui-hooks.c: Update.
515 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
516 * tui/tui-data.c (tui_data_window::clear_detail): Move to
517 tui-regs.c.
518 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
519
88b7e7cc
TT
5202019-07-17 Tom Tromey <tom@tromey.com>
521
522 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
523 seen.
524
0fcd3711
TT
5252019-07-17 Tom Tromey <tom@tromey.com>
526
527 * tui/tui-win.c (tui_source_window_base::set_new_height)
528 (tui_source_window_base::do_make_visible_with_new_height): Use
529 m_has_locator field directly.
530 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
531 method.
532 (struct tui_source_window_base) <has_locator>: Likewise.
533
4a38112d
TT
5342019-07-17 Tom Tromey <tom@tromey.com>
535
536 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
537 Don't declare.
538 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
539 Remove.
540 * tui/tui-win.c (tui_source_window_base::set_new_height)
541 (tui_source_window_base::set_new_height)
542 (make_invisible_and_set_new_height)
543 (tui_source_window_base::do_make_visible_with_new_height)
544 (tui_source_window_base::do_make_visible_with_new_height):
545 Update.
546 * tui/tui-layout.c (show_source_disasm_command, show_data)
547 (show_source_or_disasm_and_command): Update.
548 * tui/tui-layout.c (show_layout): Update.
549
09129226
TT
5502019-07-17 Tom Tromey <tom@tromey.com>
551
552 * tui/tui-layout.c (make_data_window): Remove.
553 (show_data): Unify creation and re-initialization cases.
554
4a8a5e84
TT
5552019-07-17 Tom Tromey <tom@tromey.com>
556
557 * tui/tui-layout.c (make_source_window, make_disasm_window):
558 Remove.
559 (show_data): Unify creation and re-initialization cases.
560
76d2be8e
TT
5612019-07-17 Tom Tromey <tom@tromey.com>
562
563 * tui/tui-layout.c (make_command_window): Remove.
564 (show_source_disasm_command, show_source_or_disasm_and_command):
565 Unify creation and re-initialization cases.
566
890b8bde
TT
5672019-07-17 Tom Tromey <tom@tromey.com>
568
569 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
570 creation and re-initialization cases.
571
2cdfa113
TT
5722019-07-17 Tom Tromey <tom@tromey.com>
573
574 * tui/tui-regs.c (tui_get_register): Return void.
575
8e3cfd09
TT
5762019-07-17 Tom Tromey <tom@tromey.com>
577
578 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
579 Simplify.
580
f4e04977
TT
5812019-07-17 Tom Tromey <tom@tromey.com>
582
583 * tui/tui-layout.c (show_source_disasm_command): Simplify window
584 resetting.
585
0379b883
TT
5862019-07-17 Tom Tromey <tom@tromey.com>
587
588 * tui/tui.h (tui_set_layout_by_name): Don't declare.
589 * tui/tui-regs.c (tui_reg_layout): New function.
590 (tui_show_registers, tui_reg_command): Use it.
591 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
592 (tui_layout_command): Rename from tui_set_layout_by_name. Change
593 parameters.
594 (tui_layout_command): Remove.
595
b7fbad91
TT
5962019-07-17 Tom Tromey <tom@tromey.com>
597
598 * tui/tui-layout.h (tui/tui-layout): Return void.
599 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
600
4e1e56b9
TT
6012019-07-17 Tom Tromey <tom@tromey.com>
602
603 * tui/tui-layout.c (show_source_disasm_command, show_data):
604 Update.
605 (reset_locator): Remove.
606 (show_source_or_disasm_and_command): Update.
607
1e0c09ba
TT
6082019-07-17 Tom Tromey <tom@tromey.com>
609
610 * tui/tui-source.c (tui_source_window_base::reset): Remove
611 win_type parameter.
612 * tui/tui-layout.c (make_command_window, make_source_window)
613 (make_disasm_window, make_data_window)
614 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
615 (reset_locator, show_source_or_disasm_and_command): Update.
616 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
617 win_type parameter.
618 (struct tui_source_window_base) <reset>: Likewise.
619
1bf605de
TT
6202019-07-17 Tom Tromey <tom@tromey.com>
621
622 * tui/tui-layout.c (show_source_disasm_command): Use
623 reset_locator.
624 (reset_locator): New function.
625 (init_and_make_win): Remove.
626 (show_source_or_disasm_and_command): Use reset_locator.
627
098f9ed4
TT
6282019-07-17 Tom Tromey <tom@tromey.com>
629
630 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
631 condition.
632 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
633 Remove condition.
634 * tui/tui-source.c (tui_source_window_base::reset): New method.
635 * tui/tui-layout.c (make_command_window): Don't call
636 init_and_make_win.
637 (make_source_window, make_disasm_window): Don't call
638 make_source_or_disasm_window.
639 (make_data_window): Don't call init_and_make_win. Change calling
640 convention.
641 (show_source_disasm_command, show_data): Simplify.
642 (make_source_or_disasm_window): Remove.
643 (show_source_or_disasm_and_command): Simplify.
644 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
645 (struct tui_source_window_base) <reset>: Likewise.
646 <execution_info>: Remove initializer.
647 * tui/tui-data.c (tui_source_window_base): Initialize
648 execution_info.
649
80110957
TT
6502019-07-17 Tom Tromey <tom@tromey.com>
651
652 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
653 variable.
654
cf82af05
TT
6552019-07-17 Tom Tromey <tom@tromey.com>
656
657 * tui/tui.c (tui_rl_other_window): Update.
658 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
659 superclass method first. Always iterate over regs_content.
660 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
661 method.
662 * tui/tui-win.c (tui_set_focus_command): Update.
663
01aeb396
TT
6642019-07-17 Tom Tromey <tom@tromey.com>
665
666 * tui/tui-win.c (tui_set_focus_command): Rename from
667 tui_set_focus. Call tui_enable.
668 (tui_set_focus_command): Remove.
669
fd6c75ee
TT
6702019-07-17 Tom Tromey <tom@tromey.com>
671
672 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
673 refresh_window.
674 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
675 touchwin.
676 (tui_data_window::refresh_window): Call refresh_window on data
677 items. Always call superclass refresh_window.
678 (tui_win_info::refresh): Remove.
679 (tui_source_window_base::refresh_window): Update.
680 (tui_refresh_all): Update.
681 * tui/tui-layout.c (show_source_disasm_command): Remove call to
682 refresh_window.
683 (show_source_or_disasm_and_command): Likewise.
684 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
685 (struct tui_source_window_base) <refresh>: Likewise.
686
f6cc34a9
TT
6872019-07-17 Tom Tromey <tom@tromey.com>
688
689 * tui/tui-winsource.c (tui_clear_source_content)
690 (tui_show_source_content): Update.
691 * tui/tui-source.c (tui_source_window::showing_source_p): Check
692 whether content is empty.
693 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
694 Remove.
695
f31ec9af
TT
6962019-07-17 Tom Tromey <tom@tromey.com>
697
698 * tui/tui-winsource.c (tui_erase_source_content): Clear the
699 window's contents.
700 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
701 * tui/tui-source.c (tui_set_source_content_nil): Remove.
702
d1b6f1e5
TT
7032019-07-17 Tom Tromey <tom@tromey.com>
704
705 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
706 (struct tui_data_item_window): Update.
707
d9743a13
TT
7082019-07-17 Tom Tromey <tom@tromey.com>
709
710 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
711 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
712 defines.
713
caf0bc4e
TT
7142019-07-17 Tom Tromey <tom@tromey.com>
715
716 * tui/tui-winsource.h (tui_erase_source_content)
717 (tui_clear_source_content): Remove "display_prompt" parameter.
718 * tui/tui-winsource.c (tui_update_source_window_as_is)
719 (tui_update_source_windows_with_addr): Update.
720 (tui_clear_source_content): Remove "display_prompt" parameter.
721 (tui_erase_source_content): Likewise. Simplify.
722 (tui_show_source_content): Update.
723 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
724 * tui/tui-stack.c (tui_show_frame_info): Update.
725 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
726 Remove defines.
727
9d391078
TT
7282019-07-17 Tom Tromey <tom@tromey.com>
729
730 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
731 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
732 parameter.
733 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
734 parameter.
735
a38da35d
TT
7362019-07-17 Tom Tromey <tom@tromey.com>
737
738 * tui/tui-winsource.c (tui_clear_source_content)
739 (tui_show_source_content, tui_show_exec_info_content)
740 (tui_clear_exec_info_content): Update.
741 * tui/tui-stack.c (tui_show_locator_content): Update.
742 (tui_show_frame_info): Update.
743 * tui/tui-source.h (tui_source_window): Don't declare.
744 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
745 from tui_source_is_displayed.
746 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
747 Remove field.
748 (struct tui_source_window_base) <content_in_use>: New field. Now
749 bool.
750 (struct tui_source_window) <showing_source_p>: New method.
751 (TUI_SRC_WIN): Change cast.
752 * tui/tui-data.c (tui_initialize_static_data): Update.
753
c2cd8994
TT
7542019-07-17 Tom Tromey <tom@tromey.com>
755
756 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
757 location_matches_p.
758 * tui/tui-source.c (tui_source_window::location_matches_p): New
759 method.
760 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
761 method.
762 * tui/tui-data.h (struct tui_source_window_base)
763 <location_matches_p>: New method.
764 (struct tui_source_window, struct tui_disasm_window)
765 <location_matches_p>: Likewise.
766
4dde7b34
TT
7672019-07-17 Tom Tromey <tom@tromey.com>
768
769 * tui/tui-win.c (tui_set_win_height_command): Rename from
770 tui_set_win_height.
771 (tui_set_win_height_command): Remove.
772
b73dd877
TT
7732019-07-17 Tom Tromey <tom@tromey.com>
774
775 * tui/tui-source.c (tui_source_window): New constructor. Add
776 observer.
777 (~tui_source_window): New destructor.
778 (tui_source_window::style_changed): New method.
779 * tui/tui-hooks.c (tui_redisplay_source): Remove.
780 (tui_attach_detach_observers): Update.
781 * tui/tui-data.h (struct tui_source_window): Make constructor not
782 inline. Add destructor.
783 (struct tui_source_window) <style_changed>: New method.
784 <m_observable>: New member.
785
ae2b5380
TT
7862019-07-17 Tom Tromey <tom@tromey.com>
787
788 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
789 * tui/tui-win.c (tui_resize_all): Fix typo.
790
1ce3e844
TT
7912019-07-17 Tom Tromey <tom@tromey.com>
792
793 * tui/tui-wingeneral.h (tui_refresh_all): Update.
794 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
795 (tui_refresh_all): Remove "list" parameter. Use foreach.
796 * tui/tui-win.c (window_name_completer): Use foreach.
797 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
798 (update_tab_width): Likewise.
799 * tui/tui-layout.c (show_layout): Update.
800 * tui/tui-data.h (class tui_window_iterator): New.
801 (struct all_tui_windows): New.
802 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
803
fe3eaf1c
TT
8042019-07-17 Tom Tromey <tom@tromey.com>
805
806 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
807 parameter. Don't reference globals.
808 (tui_reg_command): Update.
809
368c1354
TT
8102019-07-17 Tom Tromey <tom@tromey.com>
811
812 * tui/tui-regs.c (tui_show_registers): Simplify.
813
e80cd204
TT
8142019-07-17 Tom Tromey <tom@tromey.com>
815
816 * tui/tui-regs.c (tui_show_registers): Update.
817 (tui_show_register_group): Add win_info parameter.
818
aca2dd16
TT
8192019-07-17 Tom Tromey <tom@tromey.com>
820
821 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
822 Rename from tui_display_reg_element_at_line.
823 (tui_data_window::display_registers_from_line): Update.
824 * tui/tui-data.h (struct tui_data_window)
825 <display_reg_element_at_line>: New method.
826
517e9505
TT
8272019-07-17 Tom Tromey <tom@tromey.com>
828
829 * tui/tui-regs.h (tui_display_registers_from)
830 (tui_display_registers_from_line): Don't declare.
831 * tui/tui-windata.c (tui_data_window::display_all_data)
832 (tui_data_window::refresh_all)
833 (tui_data_window::do_scroll_vertical): Update.
834 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
835 from tui_display_registers_from.
836 (tui_display_reg_element_at_line): Update.
837 (tui_data_window::display_registers_from_line): Rename from
838 tui_display_registers_from_line.
839 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
840 display_registers_from_line>: New methods.
841
f76d8b19
TT
8422019-07-17 Tom Tromey <tom@tromey.com>
843
844 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
845 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
846 from tui_erase_data_content.
847 (tui_data_window::display_all_data)
848 (tui_data_window::refresh_all)
849 (tui_data_window::do_scroll_vertical): Update.
850 * tui/tui-regs.c (tui_show_registers): Update.
851 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
852 New method.
853
b4094625
TT
8542019-07-17 Tom Tromey <tom@tromey.com>
855
856 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
857 declare.
858 * tui/tui-windata.c
859 (tui_data_window::delete_data_content_windows): Rename from
860 tui_delete_data_content_windows.
861 (tui_data_window::display_all_data)
862 (tui_data_window::do_scroll_vertical): Update.
863 * tui/tui-data.h (struct tui_data_window)
864 <delete_data_content_windows>: New method.
865
c223a729
TT
8662019-07-17 Tom Tromey <tom@tromey.com>
867
868 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
869 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
870
50daf268
TT
8712019-07-17 Tom Tromey <tom@tromey.com>
872
873 * tui/tui-windata.h (tui_display_all_data): Don't declare.
874 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
875 from tui_display_all_data.
876 * tui/tui-win.c
877 (tui_data_window::do_make_visible_with_new_height): Update.
878 * tui/tui-regs.c (tui_show_registers): Update.
879 * tui/tui-layout.c (tui_set_layout): Update.
880 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
881 method.
882
df5f8cab
TT
8832019-07-17 Tom Tromey <tom@tromey.com>
884
885 * tui/tui-windata.h (tui_display_data_from): Don't declare.
886 * tui/tui-windata.c (tui_display_data_from): Remove.
887 (tui_data_window::refresh_all): Update.
888
80cb6c27
TT
8892019-07-17 Tom Tromey <tom@tromey.com>
890
891 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
892 * tui/tui-windata.c (tui_display_data_from_line): Remove.
893 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
894 tui_display_registers_from_line.
895 * tui/tui-regs.h (tui_display_registers_from_line): Update.
896 * tui/tui-regs.c (tui_display_registers_from_line): Remove
897 "force_display" parameter.
898
baff0c28
TT
8992019-07-17 Tom Tromey <tom@tromey.com>
900
901 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
902 declare.
903 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
904 Rename from tui_first_reg_element_no_inline.
905 (tui_display_reg_element_at_line)
906 (tui_display_registers_from_line): Update.
907 * tui/tui-data.h (struct tui_data_window)
908 <first_reg_element_no_inline>: New method.
909
3b23c5f2
TT
9102019-07-17 Tom Tromey <tom@tromey.com>
911
912 * tui/tui-windata.c (tui_display_data_from)
913 (tui_data_window::do_scroll_vertical): Update.
914 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
915 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
916 Rename from tui_line_from_reg_element_no.
917 (tui_display_registers_from_line): Update.
918 * tui/tui-data.h (struct tui_data_window)
919 <line_from_reg_element_no>: New method.
920
0b5ec218
TT
9212019-07-17 Tom Tromey <tom@tromey.com>
922
923 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
924 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
925 tui_last_regs_line_no.
926 (tui_display_reg_element_at_line)
927 (tui_display_registers_from_line): Update.
928 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
929 method.
930
0807ab7b
TT
9312019-07-17 Tom Tromey <tom@tromey.com>
932
933 PR tui/24722:
934 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
935 (tui_update_breakpoint_info): Add "being_deleted" parameter.
936 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
937 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
938 (tui_update_breakpoint_info): Likewise.
939 * tui/tui-hooks.c (tui_event_create_breakpoint)
940 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
941 Update.
942
9ad7fdef
TT
9432019-07-17 Tom Tromey <tom@tromey.com>
944
945 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
946
5813316f
TT
9472019-07-17 Tom Tromey <tom@tromey.com>
948
949 * tui/tui-winsource.c (tui_update_source_window_as_is)
950 (tui_update_source_windows_with_addr): Update.
951 * tui/tui-source.h (tui_set_source_content)
952 (tui_show_symtab_source): Add "win_info" parameter.
953 * tui/tui-source.c (tui_set_source_content): Add "win_info"
954 parameter.
955 (tui_show_symtab_source): Likewise.
956
00e264e7
TT
9572019-07-17 Tom Tromey <tom@tromey.com>
958
959 * tui/tui-wingeneral.c
960 (tui_check_and_display_highlight_if_needed): Check can_highlight.
961
06210ce4
TT
9622019-07-17 Tom Tromey <tom@tromey.com>
963
964 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
965 (struct tui_cmd_window) <can_scroll>: New method.
966 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
967 method.
968
381befee
TT
9692019-07-17 Tom Tromey <tromey@adacore.com>
970
971 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
972 do_field_signed>: Rename. Change type of "value".
973 * ui-out.c (ui_out::field_signed): Rename from field_int.
974 Change type of "value".
975 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
976 type of "value".
977 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
978 do_field_int. Change type of "value".
979 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
980 do_field_int. Change type of "value".
981 * tracepoint.c (trace_status_mi, tfind_1)
982 (print_one_static_tracepoint_marker): Update.
983 * thread.c (print_thread_info_1, print_selected_thread_frame):
984 Update.
985 * stack.c (print_frame, print_frame_info): Update.
986 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
987 Update.
988 * source.c (print_source_lines_base): Update.
989 * skip.c (info_skip_command): Update.
990 * record-btrace.c (btrace_ui_out_decode_error)
991 (btrace_call_history_src_line): Update.
992 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
993 Update.
994 * progspace.c (print_program_space): Update.
995 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
996 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
997 do_field_int. Change type of "value".
998 * mi/mi-out.c (mi_ui_out::do_table_begin)
999 (mi_ui_out::do_table_header): Update.
1000 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
1001 type of "value".
1002 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1003 (mi_cmd_data_list_changed_registers, output_register)
1004 (mi_cmd_data_read_memory, mi_load_progress)
1005 (mi_cmd_trace_frame_collected): Update.
1006 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1007 Update.
1008 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1009 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1010 (mi_cmd_var_list_children, varobj_update_one): Update.
1011 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1012 (mi_cmd_stack_list_args, list_arg_or_local): Update.
1013 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1014 * inferior.c (print_inferior): Update.
1015 * gdb_bfd.c (print_one_bfd): Update.
1016 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1017 Update.
1018 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1019 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1020 do_field_int. Change type of "value".
1021 * cli-out.c (cli_ui_out::do_field_signed): Rename from
1022 do_field_int. Change type of "value".
1023 * breakpoint.c (watchpoint_check, print_breakpoint_location)
1024 (print_one_breakpoint_location, print_it_catch_fork)
1025 (print_one_catch_fork, print_it_catch_vfork)
1026 (print_one_catch_vfork, print_it_catch_solib)
1027 (print_it_catch_exec, print_it_ranged_breakpoint)
1028 (print_mention_watchpoint, print_mention_masked_watchpoint)
1029 (bkpt_print_it, update_static_tracepoint): Update.
1030 * break-catch-throw.c (print_it_exception_catchpoint): Update.
1031 * break-catch-syscall.c (print_it_catch_syscall): Update.
1032 * ada-tasks.c (print_ada_task_info): Update.
1033 * ada-lang.c (print_it_exception, print_mention_exception):
1034 Update.
1035
6b78c3f8
AB
10362019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
1037
1038 PR breakpoints/24541
1039 * gdbarch.c: Regenerate.
1040 * gdbarch.h: Regenerate.
1041 * gdbarch.sh: Adjust return type and parameter types for
1042 'stap_adjust_register'.
1043 (i386_stap_adjust_register): Adjust signature and return new
1044 register name.
1045 * stap-probe.c (stap_parse_register_operand): Adjust use of
1046 'gdbarch_stap_adjust_register'.
1047
d72a9b85
TT
10482019-07-17 Tom Tromey <tromey@adacore.com>
1049
1050 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
1051 declare VEC.
1052 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1053 std::vector.
1054 (struct s390_process_info): Add initializers.
1055 (s390_add_process): Use new.
1056 (s390_linux_nat_target::low_forget_process): Use delete.
1057 (s390_linux_nat_target::low_new_fork)
1058 (s390_linux_nat_target::stopped_by_watchpoint)
1059 (s390_linux_nat_target::low_prepare_to_resume)
1060 (s390_linux_nat_target::insert_watchpoint)
1061 (s390_linux_nat_target::insert_hw_breakpoint)
1062 (s390_linux_nat_target::remove_watchpoint)
1063 (s390_linux_nat_target::remove_hw_breakpoint): Update.
1064
206e6c58
JB
10652019-07-16 John Baldwin <jhb@FreeBSD.org>
1066
1067 * aarch64-fbsd-nat.c: Include regcache.h.
1068 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1069 argument.
1070 (aarch64_fbsd_nat_target::fetch_registers)
1071 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1072 variable.
1073 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1074
cbde90f2
JB
10752019-07-16 John Baldwin <jhb@FreeBSD.org>
1076
1077 * fbsd-nat.c: Include gdbarch.h.
1078
07128006
TT
10792019-07-15 Tom Tromey <tromey@adacore.com>
1080
1081 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1082
1f77b012
TT
10832019-07-15 Tom Tromey <tromey@adacore.com>
1084
1085 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1086 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1087 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1088 * cli-out.c (cli_ui_out::do_field_int): New method.
1089 * ui-out.c (ui_out::field_unsigned): New method.
1090 * symfile.c (generic_load): Use field_unsigned.
1091 (print_transfer_performance): Likewise.
1092 * record-btrace.c (ui_out_field_uint): Remove.
1093 (btrace_call_history_insn_range, btrace_call_history): Use
1094 field_unsigned.
1095 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1096 field_unsigned.
1097 * ui-out.h (class ui_out) <field_unsigned>: New method.
1098 <do_field_unsigned>: Likewise.
1099
33eca680
TT
11002019-07-15 Tom Tromey <tromey@adacore.com>
1101
1102 * mi/mi-main.c (list_available_thread_groups): Use field_string.
1103 * mi/mi-interp.c (mi_memory_changed): Use field_string.
1104 * target.c (flash_erase_command): Use field_string.
1105 * infrun.c (print_signal_received_reason): Use field_string.
1106 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1107 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1108 field_string.
1109 * ada-tasks.c (print_ada_task_info): Use field_string.
1110
ca8d69be
TT
11112019-07-15 Tom Tromey <tromey@adacore.com>
1112
1113 * target.c (flash_erase_command): Use field_core_addr.
1114 * symfile.c (generic_load): Use field_core_addr.
1115 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1116 Use field_core_addr.
1117 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1118 field_core_addr.
1119
0d4e84ed
AB
11202019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1121
1122 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1123 value if its desired type is smaller than a CORE_ADDR and signed.
1124
9a49df9d
AB
11252019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1126
1127 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1128 of changes to field names, and use new is_reference field to
1129 decide if a property is a reference or not.
1130 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1131 field.
1132 (struct dwarf2_property_baton): Update header comment, rename
1133 'referenced_type' to 'property_type' and update comments.
1134 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1135 default property type, store in property baton, update to take
1136 accound of renamed field.
1137 (read_func_scope): Update call to attr_to_dynamic_prop.
1138 (read_array_type): Likewise.
1139 (dwarf2_per_cu_addr_sized_int_type): New function.
1140 (read_subrange_index_type): Move type finding code to
1141 dwarf2_per_cu_addr_sized_int_type.
1142 (read_subrange_type): Update calls to attr_to_dynamic_prop.
1143 (dwarf2_per_cu_addr_type): New function.
1144 (set_die_type): Update calls to attr_to_dynamic_prop.
1145
b86352cf
AB
11462019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1147
1148 * dwarf2read.c (read_subrange_index_type): New function.
1149 (read_subrange_type): Move code into new function and call it.
1150 * gdbtypes.c (create_range_type): Add some asserts.
1151
603490bf
AB
11522019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1153
1154 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1155 update return statements.
1156 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1157 declaration, and update comment to match.
1158 * gdbtypes.c (resolve_dynamic_array): Update call to
1159 dwarf2_evaluate_property to match new return type.
1160
592f9d27
AB
11612019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1162
1163 * valarith.c (value_subscripted_rvalue): Change lowerbound
1164 parameter type from int to LONGEST.
1165 * value.h (value_subscripted_rvalue): Likewise in declaration.
1166
60cfcb20
AB
11672019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1168
1169 * cli/cli-utils.c (info_print_command_completer): New function.
1170 * cli/cli-utils.h: Add 'completer.h' include, and forward
1171 declaration for 'struct cmd_list_element'.
1172 (info_print_command_completer): Declare.
1173 * stack.c (_initialize_stack): Add completer for 'info locals' and
1174 'info args'.
1175 * symtab.c (_initialize_symtab): Add completer for 'info
1176 variables' and 'info functions'.
1177 * NEWS: Mention completion for additional info commands.
1178
b16507e0
AB
11792019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1180
1181 * cli/cli-utils.c (extract_info_print_args): Delete.
1182 (extract_arg_maybe_quoted): Delete.
1183 (info_print_options_defs): New variable.
1184 (make_info_print_options_def_group): New function.
1185 (extract_info_print_options): Define new function.
1186 * cli/cli-utils.h (extract_info_print_args): Delete.
1187 (struct info_print_options): New structure.
1188 (extract_info_print_options): Declare new function.
1189 * stack.c (info_locals_command): Update to use new
1190 extract_info_print_options, also add a header comment.
1191 (info_args_command): Likewise.
1192 * symtab.c (info_variables_command): Likewise.
1193 (info_functions_command): Likewise.
1194
021d8588
AB
11952019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1196
1197 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1198 to extract string arguments.
1199 * common/common-utils.c (extract_string_maybe_quoted): New function.
1200 * common/common-utils.h (extract_string_maybe_quoted): Declare.
1201
b777eb6d
TT
12022019-07-11 Tom Tromey <tromey@adacore.com>
1203
1204 * main.c (get_init_files): Use GDBINIT, not gdbinit.
1205 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1206 * top.h (gdbinit): Don't declare.
1207 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1208 into...
1209 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
1210 * top.c (gdb_init): Don't call init_cli_cmds.
1211 (gdbinit): Remove.
1212 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1213
72ee03ff
TT
12142019-07-11 Tom Tromey <tromey@adacore.com>
1215
1216 * python/py-inferior.c (add_thread_object): Don't use thread_obj
1217 after it has been moved.
1218
00db9531
SM
12192019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1220
1221 * valops.c (value_must_coerce_to_target): Change return type to
1222 bool.
1223 * value.h (value_must_coerce_to_target): Likewise.
1224
f2478a7e
SM
12252019-07-10 Simon Marchi <simon.marchi@efficios.com>
1226
1227 * breakpoint.c (is_hardware_watchpoint): Remove
1228 forward-declaration.
1229 (is_masked_watchpoint): Change return type to bool.
1230 (is_tracepoint): Likewise.
1231 (is_breakpoint): Likewise.
1232 (is_hardware_watchpoint): Likewise.
1233 (is_watchpoint): Likewise.
1234 (is_no_memory_software_watchpoint): Likewise.
1235 (is_catchpoint): Likewise.
1236 (breakpoint_1): Make FILTER parameter's return type bool.
1237 is_masked_watchpoint): Change return type to bool.
1238 (save_breakpoints): Make FILTER parameter's return type bool.
1239 * breakpoint.h (is_breakpoint): Change return type to bool.
1240 (is_watchpoint): Likewise.
1241 (is_catchpoint): Likewise.
1242 (is_tracepoint): Likewise.
1243
0d12e84c
TT
12442019-07-10 Tom Tromey <tom@tromey.com>
1245
1246 * defs.h: Don't include gdbarch.h.
1247 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1248 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1249 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1250 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1251 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1252 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1253 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1254 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1255 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1256 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1257 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1258 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1259 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1260 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1261 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1262 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1263 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1264 record-btrace.c, record.h, regcache-dump.c, regcache.h,
1265 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1266 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1267 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1268 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1269 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1270 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1271 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1272 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1273 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1274
f06f1252
TT
12752019-07-10 Tom Tromey <tromey@adacore.com>
1276
1277 * ada-lang.h (is_ada_exception_catchpoint): Declare.
1278 * breakpoint.c (init_ada_exception_breakpoint): Register as
1279 bp_catchpoint.
1280 (print_one_breakpoint_location, print_one_breakpoint): Use
1281 is_ada_exception_catchpoint.
1282 * ada-lang.c (class ada_catchpoint_location): Pass
1283 bp_loc_software_breakpoint to bp_location constructor.
1284 (is_ada_exception_catchpoint): New function.
1285
7a5d944b
TT
12862019-07-10 Tom Tromey <tromey@adacore.com>
1287
1288 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
1289 VEC.
1290 (struct arm_exidx_entry): New method operator<.
1291 (struct arm_exidx_data) <section_maps>: Change type.
1292 (arm_exidx_data_free): Remove.
1293 (arm_exidx_data_key): Change type. Move lower.
1294 (arm_exidx_new_objfile): Update.
1295 (arm_compare_exidx_entries): Remove.
1296 (arm_find_exidx_entry, _initialize_arm_tdep)
1297
48c66e1d
TT
12982019-07-10 Tom Tromey <tromey@adacore.com>
1299
1300 * solib-spu.c (ocl_program_data_key): Change type.
1301 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1302 Update.
1303
a269fbf1
TT
13042019-07-10 Tom Tromey <tromey@adacore.com>
1305
1306 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
1307 (struct solib_aix_inferior_data) <library_list>: Change type.
1308 (solib_aix_inferior_data_handle): Change type.
1309 (get_solib_aix_inferior_data): Update.
1310 (solib_aix_free_library_list): Remove.
1311 (library_list_start_library): Update.
1312 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1313 return type.
1314 (solib_aix_get_library_list)
1315 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1316 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1317
c294730c
TT
13182019-07-10 Tom Tromey <tromey@adacore.com>
1319
1320 * solib-dsbt.c (struct dsbt_info): Add initializers.
1321 (solib_dsbt_pspace_data): Change type.
1322 (dsbt_pspace_data_cleanup): Remove.
1323 (get_dsbt_info, _initialize_dsbt_solib): Update.
1324
9d52077d
TT
13252019-07-10 Tom Tromey <tromey@adacore.com>
1326
1327 * spu-tdep.c (spu_overlay_data): Change type.
1328 (spu_get_overlay_table, spu_overlay_new_objfile)
1329 (_initialize_spu_tdep): Update.
1330
22a20dca
TT
13312019-07-10 Tom Tromey <tromey@adacore.com>
1332
1333 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1334 destructor.
1335 (dbx_objfile_data_key): Change type and declare later.
1336 (DBX_SYMFILE_INFO): Rewrite.
1337 * dbxread.c (dbx_objfile_data_key): Change type.
1338 (dbx_symfile_init): Update.
1339 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
1340 (coffstab_build_psymtabs, elfstab_build_psymtabs)
1341 (stabsect_build_psymtabs, _initialize_dbxread): Update.
1342
cb60f420
TT
13432019-07-10 Tom Tromey <tromey@adacore.com>
1344
1345 * jit.c (jit_program_space_key): Change type. Move lower.
1346 (get_jit_program_space_data): Update.
1347 (jit_program_space_data_cleanup): Remove.
1348 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1349 Update.
1350 (struct jit_program_space_data): Add initializers.
1351
51df2ae3
TT
13522019-07-10 Tom Tromey <tromey@adacore.com>
1353
1354 * solib-darwin.c (struct darwin_info): Add initializers.
1355 (solib_darwin_pspace_data): Change type.
1356 (darwin_pspace_data_cleanup): Remove.
1357 (get_darwin_info, _initialize_darwin_solib): Update.
1358
18101a35
TT
13592019-07-10 Tom Tromey <tromey@adacore.com>
1360
1361 * remote-sim.c (struct sim_inferior_data): Add initializers,
1362 constructor, and destructor.
1363 (sim_inferior_data_key): Change type. Move lower.
1364 (check_for_duplicate_sim_descriptor): Update.
1365 (get_sim_inferior_data): Use new. Update.
1366 (~sim_inferior_data_cleanup): Rename from
1367 sim_inferior_data_cleanup. Simplify.
1368 (gdbsim_close_inferior, simulator_command)
1369 (sim_command_completer, _initialize_remote_sim): Update.
1370 (next_pid, INITIAL_PID): Move earlier.
1371
05b08ac1
TT
13722019-07-10 Tom Tromey <tromey@adacore.com>
1373
1374 * python/python-internal.h (create_thread_object): Return
1375 gdbpy_ref.
1376 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1377 * python/py-inferior.c (struct threadlist_entry): Add
1378 constructor.
1379 <thread_obj>: Now a gdbpy_ref.
1380 (thread_to_thread_object): Update.
1381 (add_thread_object): Use new.
1382 (delete_thread_object): Use delete.
1383 (infpy_threads): Update.
1384 (py_free_inferior): Update. Construct "inf_obj" after acquiring
1385 GIL.
1386
32372d80
TT
13872019-07-10 Tom Tromey <tromey@adacore.com>
1388
1389 * valops.c (value_cast): Specialize error message for Ada.
1390
5c458ae8
SM
13912019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1392
1393 * breakpoint.c (breakpoint_1): Update doc and parameter names.
1394
4c462cb0
SM
13952019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1396
1397 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1398 bpstat_should_step): Return bool, adjust comments.
1399 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1400 bpstat_should_step): Likewise.
1401
89abbcc2
AH
14022019-07-10 Alan Hayward <alan.hayward@arm.com>
1403
1404 * features/Makefile: Use feature target descriptions for Arm.
1405 * features/arm/arm-core.c: Generate new file.
1406 * features/arm/arm-fpa.c: Likewise.
1407 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1408 * features/arm/arm-m-profile.c: Likewise.
1409 * features/arm/arm-vfpv2.c: Likewise.
1410 * features/arm/arm-vfpv3.c: Likewise.
1411 * features/arm/xscale-iwmmxt.c: Likewise.
1412 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1413
166a82be
AH
14142019-07-10 Alan Hayward <alan.hayward@arm.com>
1415
1416 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1417 ptrace earlier.
1418
9fb4c7e9
AH
14192019-07-10 Alan Hayward <alan.hayward@arm.com>
1420
1421 * features/aarch64-pauth.c: Regenerate.
1422
e2d0f980
SM
14232019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
1424
1425 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1426 bool.
1427 (bpstat_what): Use false instead of 0.
1428
a38118e5
PA
14292019-07-09 Pedro Alves <palves@redhat.com>
1430
1431 * break-catch-throw.c (is_exception_catchpoint): New.
1432 * breakpoint.c (print_one_breakpoint_location): New parameter
1433 'raw_loc'. Handle it. Use
1434 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1435 looking at the breakpoint's type.
1436 (print_one_breakpoint): If handling "maint info breakpoints", also
1437 print locations of exception catchpoints.
1438 * breakpoint.h (is_exception_catchpoint): Declare.
1439
cb1e4e32
PA
14402019-07-09 Pedro Alves <palves@redhat.com>
1441
1442 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1443 "addr" field.
1444 (allocate_location_exception_catchpoint): New.
1445 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1446 (initialize_throw_catchpoint_ops): Install
1447 allocate_location_exception_catchpoint as allocate_location
1448 method.
1449 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1450 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1451 bp_loc_other.
1452 (breakpoint_address_is_meaningful): Delete.
1453 (bl_address_is_meaningful): New.
1454 (breakpoint_locations_match): Adjust comment.
1455 (bp_location_from_bp_type): New, factored out of...
1456 (bp_location::bp_location(breakpoint *)): ... this.
1457 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1458 factored out of...
1459 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
1460 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1461 breakpoint_address_is_meaningful.
1462 (bp_locations_compare): Adjust comment.
1463 (update_global_location_list): Use bl_address_is_meaningful
1464 instead of breakpoint_address_is_meaningful.
1465 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1466 explicit.
1467 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1468 * python/py-breakpoint.c (bppy_get_location): No longer check
1469 whether location is null.
1470
b58a68fe
PA
14712019-07-09 Pedro Alves <palves@redhat.com>
1472
1473 PR c++/15468
1474 * breakpoint.c (print_one_breakpoint_location): Remove
1475 single-location assert.
1476
268a13a5
TT
14772019-07-09 Tom Tromey <tom@tromey.com>
1478
1479 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1480 * configure: Rebuild.
1481 * configure.ac: Change common to gdbsupport.
1482 * gdbsupport: Rename from common.
1483 * acinclude.m4: Change common to gdbsupport.
1484 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1485 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1486 gdbsupport.
1487 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1488 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1489 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1490 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1491 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1492 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1493 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1494 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1495 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1496 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1497 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1498 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1499 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1500 coff-pe-read.c, command.h, compile/compile-c-support.c,
1501 compile/compile-c.h, compile/compile-cplus-symbols.c,
1502 compile/compile-cplus-types.c, compile/compile-cplus.h,
1503 compile/compile-loc2c.c, compile/compile.c, completer.c,
1504 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1505 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1506 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1507 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1508 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1509 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1510 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1511 features/aarch64-core.c, features/aarch64-fpu.c,
1512 features/aarch64-pauth.c, features/aarch64-sve.c,
1513 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1514 features/i386/32bit-core.c, features/i386/32bit-linux.c,
1515 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1516 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1517 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1518 features/i386/64bit-core.c, features/i386/64bit-linux.c,
1519 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1520 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1521 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1522 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1523 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1524 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1525 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1526 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1527 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1528 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1529 go32-nat.c, guile/guile.c, guile/scm-ports.c,
1530 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1531 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1532 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1533 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1534 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1535 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1536 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1537 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1538 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1539 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1540 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1541 minsyms.c, mips-linux-tdep.c, namespace.h,
1542 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1543 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1544 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1545 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1546 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1547 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1548 nat/linux-waitpid.c, nat/mips-linux-watch.c,
1549 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1550 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1551 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1552 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1553 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1554 procfs.c, producer.c, progspace.h, psymtab.h,
1555 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1556 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1557 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1558 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1559 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1560 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1561 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1562 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1563 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1564 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1565 target-memory.c, target.c, target.h, target/waitstatus.c,
1566 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1567 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1568 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1569 unittests/array-view-selftests.c,
1570 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1571 unittests/common-utils-selftests.c,
1572 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1573 unittests/format_pieces-selftests.c,
1574 unittests/function-view-selftests.c,
1575 unittests/lookup_name_info-selftests.c,
1576 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1577 unittests/mkdir-recursive-selftests.c,
1578 unittests/observable-selftests.c,
1579 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1580 unittests/parse-connection-spec-selftests.c,
1581 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1582 unittests/scoped_fd-selftests.c,
1583 unittests/scoped_mmap-selftests.c,
1584 unittests/scoped_restore-selftests.c,
1585 unittests/string_view-selftests.c, unittests/style-selftests.c,
1586 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1587 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1588 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1589 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1590 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1591 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1592
5b0e2db4
AB
15932019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
1594
1595 * linespec.c (decode_digits_list_mode): Set explicit_line to a
1596 bool value.
1597 (decode_digits_ordinary): Set explicit_line field in sal.
1598 * symtab.c (skip_prologue_sal): Don't skip prologue for a
1599 symtab_and_line that was set on an explicit line number in
1600 assembler code. Do always update the recorded symtab and line if
1601 we do skip the prologue.
1602
0ba852ab
AB
16032019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
1604
1605 * breakpoint.c (set_breakpoint_location_function): Remove
1606 explicit_loc parameter.
1607 (momentary_breakpoint_from_master): Update call to
1608 set_breakpoint_location_function.
1609 (add_location_to_breakpoint): Likewise.
1610
b3a7d171
AB
16112019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
1612
1613 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1614 required features based on default bfd type when no specific bfd
1615 is present.
1616
1f6f6e21
PW
16172019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1618
1619 * NEWS: Mention that GDB printf and eval commands can now print
1620 C-style and Ada-style convenience var strings without
1621 calling the inferior.
1622 * printcmd.c (printf_c_string): Locally print GDB internal var
1623 instead of transiting via the inferior.
1624 (printf_wide_c_string): Likewise.
1625
16262019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH
1627
1628 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1629
0598af48
TT
16302019-07-04 Tom Tromey <tom@tromey.com>
1631
1632 PR tui/24724:
1633 * tui/tui-winsource.c (tui_clear_source_content): Update.
1634 (tui_source_window_base::set_is_exec_point_at): Fix comment.
1635 (tui_update_breakpoint_info): Update.
1636 (tui_set_exec_info_content): Update.
1637 * tui/tui-source.c (tui_set_source_content_nil): Update.
1638 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1639 has_break.
1640 * tui/tui-data.h (enum tui_bp_flag): New.
1641 (tui_bp_flags): New enum flags type.
1642 (struct tui_source_element) <break_mode>: Change type. Rename
1643 from has_break.
1644 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1645 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
1646 constants.
1647 * tui/tui-winsource.h: Fix comment.
1648
350fab54
AH
16492019-07-04 Alan Hayward <alan.hayward@arm.com>
1650
1651 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1652 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1653 (store_fpregs_to_thread)
1654 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1655 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1656 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1657 (IWMMXT_REGS_SIZE): Add define.
1658 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1659 (fetch_vfp_regs, store_vfp_regs)
1660 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1661 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1662
f0452268
AH
16632019-07-04 Alan Hayward <alan.hayward@arm.com>
1664
1665 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1666 defines.
1667 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1668 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1669 (ARM_INT_REGISTER_SIZE): ...to this.
1670 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1671 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1672 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1673 (arm_linux_collect_gregset, supply_nwfpe_register)
1674 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1675 defines.
1676 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1677 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1678 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1679 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1680 (arm_return_in_memory, arm_store_return_value)
1681 (arm_get_longjmp_target, arm_register_g_packet_guesses)
1682 (arm_record_ld_st_multiple): Likewise.
1683 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1684 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1685
e935475c
AH
16862019-07-04 Alan Hayward <alan.hayward@arm.com>
1687
1688 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1689 AARCH64_DISPLACED_MODIFIED_INSNS.
1690 * aarch64-tdep.c (struct aarch64_displaced_step_data)
1691 (aarch64_displaced_step_copy_insn): Likewise.
1692 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1693 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1694 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1695 ARM_DISPLACED_MODIFIED_INSNS.
1696 * arm-tdep.c (arm_gdbarch_init): Likewise.
1697 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1698 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1699 (struct arm_displaced_step_closure): Use
1700 ARM_DISPLACED_MODIFIED_INSNS.
1701
df0bb381
AH
17022019-07-04 Alan Hayward <alan.hayward@arm.com>
1703
1704 * features/Makefile: Remove unused xml files.
1705 * features/aarch64.xml: Remove.
1706 * features/i386/amd64-avx-avx512-linux.xml: Remove.
1707 * features/i386/amd64-avx-avx512.xml: Remove.
1708 * features/i386/amd64-avx-linux.xml: Remove.
1709 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1710 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1711 * features/i386/amd64-avx-mpx-linux.xml: Remove.
1712 * features/i386/amd64-avx-mpx.xml: Remove.
1713 * features/i386/amd64-avx.xml: Remove.
1714 * features/i386/amd64-linux.xml: Remove.
1715 * features/i386/amd64-mpx-linux.xml: Remove.
1716 * features/i386/amd64-mpx.xml: Remove.
1717 * features/i386/amd64.xml: Remove.
1718 * features/i386/i386-avx-avx512-linux.xml: Remove.
1719 * features/i386/i386-avx-avx512.xml: Remove.
1720 * features/i386/i386-avx-linux.xml: Remove.
1721 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1722 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1723 * features/i386/i386-avx-mpx-linux.xml: Remove.
1724 * features/i386/i386-avx-mpx.xml: Remove.
1725 * features/i386/i386-avx.xml: Remove.
1726 * features/i386/i386-linux.xml: Remove.
1727 * features/i386/i386-mmx-linux.xml: Remove.
1728 * features/i386/i386-mmx.xml: Remove.
1729 * features/i386/i386-mpx-linux.xml: Remove.
1730 * features/i386/i386-mpx.xml: Remove.
1731 * features/i386/i386.xml: Remove.
1732 * features/i386/x32-avx-avx512-linux.xml: Remove.
1733 * features/i386/x32-avx-linux.xml: Remove.
1734 * features/i386/x32-linux.xml: Remove.
1735
edd6266a
AH
17362019-07-04 Alan Hayward <alan.hayward@arm.com>
1737
1738 * regformats/aarch64.dat: Remove.
1739 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1740 * regformats/i386/amd64-avx-linux.dat: Remove.
1741 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1742 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1743 * regformats/i386/amd64-linux.dat: Remove.
1744 * regformats/i386/amd64-mpx-linux.dat: Remove.
1745 * regformats/i386/amd64.dat: Remove.
1746 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1747 * regformats/i386/i386-avx-linux.dat: Remove.
1748 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1749 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1750 * regformats/i386/i386-linux.dat: Remove.
1751 * regformats/i386/i386-mmx-linux.dat: Remove.
1752 * regformats/i386/i386-mpx-linux.dat: Remove.
1753 * regformats/i386/i386.dat: Remove.
1754 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1755 * regformats/i386/x32-avx-linux.dat: Remove.
1756 * regformats/i386/x32-linux.dat: Remove.
1757
2b40fda7
AH
17582019-07-04 Alan Hayward <alan.hayward@arm.com>
1759
1760 * aarch64-tdep.c: Remove xml self tests.
1761 * amd64-linux-tdep.c: Likewise.
1762 * amd64-tdep.c: Likewise.
1763 * i386-linux-tdep.c: Likewise.
1764 * i386-tdep.c: Likewise.
1765
5f4ba3e7
PA
17662019-07-03 Pedro Alves <palves@redhat.com>
1767
1768 PR cli/24732
1769 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1770 (pipe_cmd_option_defs): New.
1771 (make_pipe_cmd_options_def_group): New.
1772 (pipe_command): Use gdb::option::process_options.
1773 (pipe_command_completer): New function.
1774 (_initialize_cli_cmds): Install completer for "pipe" command.
1775
3d9be6f5
PA
17762019-07-03 Pedro Alves <palves@redhat.com>
1777
1778 * cli/cli-option.c (union option_value) <string>: New field.
1779 (struct option_def_and_value): Add ctor, move ctor, dtor and
1780 use DISABLE_COPY_AND_ASSIGN.
1781 (option_def_and_value::clear_value): New.
1782 (parse_option, save_option_value_in_ctx, get_val_type_str)
1783 (add_setshow_cmds_for_options): Handle var_string.
1784 * cli-option.h (union option_def::var_address) <string>: New
1785 field.
1786 (struct string_option_def): New.
1787 * maint-test-options.c (struct test_options_opts): Add default
1788 ctor and use DISABLE_COPY_AND_ASSIGN.
1789 <string_opt>: New field.
1790 (test_options_opts::~test_options_opts): New.
1791 (test_options_opts::dump): Also dump "-string".
1792 (test_options_option_defs): Install "string.
1793
41fc454c
PA
17942019-07-03 Pedro Alves <palves@redhat.com>
1795
1796 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1797 option_value with a null enumeration.
1798 (complete_options): Save the option values in the context.
1799 (save_option_value_in_ctx): New, factored out from ...
1800 (process_options): ... here.
1801 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1802 of the function.
1803 * maint-test-options.c (test_options_opts::dump): New, factored
1804 out from ...
1805 (maintenance_test_options_command_mode): ... here.
1806 (maintenance_test_options_command_completion_result): Delete.
1807 (maintenance_test_options_command_completion_text): Update
1808 comment.
1809 (maintenance_show_test_options_completion_result): Change
1810 prototype. Just print
1811 maintenance_test_options_command_completion_text.
1812 (save_completion_result): New.
1813 (maintenance_test_options_completer_mode): Pass options context to
1814 complete_options, and then save a dump.
1815 (_initialize_maint_test_options): Use add_cmd to install "maint
1816 show test-options-completion-result".
1817
fdbc9870
PA
18182019-07-03 Pedro Alves <palves@redhat.com>
1819
1820 * NEWS (New commands): Mention "with" and "maint with".
1821 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1822 (with_command, with_command_completer): New.
1823 (pipe_command): Adjust to new repeat_previous
1824 interface.
1825 (_initialize_cli_cmds): Install the "with" command and its "w"
1826 alias.
1827 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1828 declarations.
1829 * cli/cli-setshow.c (parse_cli_var_uinteger)
1830 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1831 argument strings for all var_types.
1832 (get_setshow_command_value_string): New, factored out from ...
1833 (do_show_command): ... this.
1834 * cli/cli-setshow.h: Include <string>.
1835 (get_setshow_command_value_string): Declare.
1836 * command.h (repeat_previous): Now returns const char *. Adjust
1837 comment.
1838 * maint.c: Include "cli/cli-cmds.h".
1839 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1840 (_initialize_maint_cmds): Register the "maintenance with" command.
1841 * top.c (repeat_previous): Move bits from pipe_command here:
1842 Return the saved command line, if any; error out if there's no
1843 command to relaunch.
1844
c6ac8931
PA
18452019-07-03 Pedro Alves <palves@redhat.com>
1846
1847 * NEWS (New commands): Mention "maint set/show test-settings"
1848 instead of "maint test-settings".
1849 * maint-test-settings.c (maintenance_test_settings_list): Delete.
1850 (maintenance_test_settings_set_list): Rename to ...
1851 (maintenance_set_test_settings_list): ... this.
1852 (maintenance_test_settings_show_list): Rename to ...
1853 (maintenance_show_test_settings_list): ... this.
1854 (maintenance_test_settings_cmd): Delete.
1855 (maintenance_test_settings_set_cmd): ...
1856 (maintenance_set_test_settings_cmd): ... this.
1857 (maintenance_test_settings_show_cmd): ...
1858 (maintenance_show_test_settings_cmd): ... this.
1859 (maintenance_test_settings_show_value_cmd):
1860 (maintenance_show_test_settings_value_cmd): ... this.
1861 (_initialize_maint_test_settings): No longer install the "maint
1862 test-settings" prefix command. Rename "maint test-settings set"
1863 to "maint set test-settings", and "maint test-settings show" to
1864 "maint show test-settings". Adjust all subcommands.
1865
d1fcf2fd
PA
18662019-07-03 Pedro Alves <palves@redhat.com>
1867
1868 * maint-test-settings.c: Fix file's intro comment. Replace all
1869 references to "test-options" with references to "test-settings",
1870 in comments.
1871
970f9d09
PA
18722019-07-03 Pedro Alves <palves@redhat.com>
1873
1874 * maint-test-settings.c (maintenance_test_settings_xxx)
1875 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1876 New.
1877 (maintenance_test_settings_enums): Use them.
1878 (maintenance_test_settings_enum): Default to
1879 maintenance_test_settings_xxx.
1880 (_initialize_maint_test_settings): Initialize
1881 MAINTENANCE_TEST_SETTINGS_FILENAME.
1882
f3869b1a
SM
18832019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
1884
1885 * breakpoint.h (remove_breakpoints_inf): Change return type to
1886 void, move function documentation here.
1887 * breakpoint.c (remove_breakpoints_inf): Change return type to
1888 void, move function documentation to header.
1889
54d66006
PA
18902019-07-02 Pedro Alves <palves@redhat.com>
1891
1892 * NEWS (Completion improvements): Mention "info threads".
1893 * thread.c (struct info_threads_opts, info_threads_option_defs)
1894 (make_info_threads_options_def_group): New.
1895 (info_threads_command): Use gdb::option::process_options.
1896 (info_threads_command_completer): New.
1897 (_initialize_thread): Use gdb::option::build_help to build the
1898 help text for "info threads".
1899
854f6088
SM
19002019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
1901
1902 * defs.h (generic_load): Move from here...
1903 * symfile.h (generic_load): ... to here. Rename name parameter
1904 to args.
1905 * symfile.c (generic_load): Add comment.
1906
54ee4252
TT
19072019-07-01 Tom Tromey <tromey@adacore.com>
1908
1909 * dwarf2read.c
1910 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1911 declaration of without_params. Fix formatting.
1912
65392b3e
TT
19132019-07-01 Tom Tromey <tromey@adacore.com>
1914
1915 * ada-exp.y (find_primitive_type): Update.
1916 * ada-lang.h (ada_lookup_symbol): Update.
1917 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1918 parameter.
1919 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1920
7d7571f0
SDJ
19212019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
1922
1923 PR breakpoints/24541
1924 * gdbarch.c: Regenerate.
1925 * gdbarch.h: Regenerate.
1926 * gdbarch.sh: Add 'stap_adjust_register'.
1927 * i386-tdep.c: Include '<unordered_set>'.
1928 (i386_stap_adjust_register): New function.
1929 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1930 * stap-probe.c (stap_parse_register_operand): Call
1931 'gdbarch_stap_adjust_register'.
1932
5af5392a
SDJ
19332019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
1934
1935 PR python/24742
1936 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1937 * python/python.c (do_start_initialization): Use 'xmalloc'
1938 instead of 'PyMem_Malloc'.
1939
10d06d82
TT
19402019-06-28 Tom Tromey <tromey@adacore.com>
1941
1942 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1943 for Ada.
1944
1b7f24cd
TT
19452019-06-27 Tom Tromey <tromey@adacore.com>
1946
1947 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
1948 objfile_key.
1949 (arm_find_mapping_symbol, arm_record_special_symbol)
1950 (_initialize_arm_tdep): Update.
1951 (arm_objfile_data_free): Remove.
1952
3d507ff2
TT
19532019-06-27 Tom Tromey <tromey@adacore.com>
1954
1955 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1956 to cp_print_static_field.
1957
762c164d
TT
19582019-06-26 Tom Tromey <tromey@adacore.com>
1959
1960 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1961 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1962 declare.
1963
aa2f9bcf
AH
19642019-06-26 Alan Hayward <alan.hayward@arm.com>
1965
1966 * features/aarch64-core.c (create_feature_aarch64_core):
1967 Regenerate.
1968 * features/aarch64-core.xml: Add cpsr flags.
1969
3426ae57
AH
19702019-06-26 Alan Hayward <alan.hayward@arm.com>
1971
1972 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1973 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1974
4838e44c
SM
19752019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
1976
1977 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1978 field.
1979 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1980 use.
1981 (arm_record_special_symbol): Don't insert new symbol in sorted
1982 position, push it at the end.
1983
54cc7474
SM
19842019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
1985
1986 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1987 (arm_mapping_symbol_s): Remove.
1988 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1989 (arm_mapping_symbol_vec): New typedef.
1990 (struct arm_per_objfile): Add constructor.
1991 <section_maps>: Change type to
1992 std::unique_ptr<arm_mapping_symbol_vec[]>.
1993 (arm_compare_mapping_symbols): Remove.
1994 (arm_find_mapping_symbol): Adjust to section_maps type change.
1995 (arm_objfile_data_free): Call delete on arm_per_objfile.
1996 (arm_record_special_symbol): Adjust to section_maps type change.
1997 Allocate arm_per_objfile with new.
1998
b65b566c
PW
19992019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2000
2001 * cli/cli-cmds.c (alias_command): Compare the alias prefix
2002 with the command prefix.
2003
c2fc64f5
TT
20042019-06-25 Tom Tromey <tom@tromey.com>
2005
2006 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2007 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2008
fb54fa76
TT
20092019-06-25 Tom Tromey <tom@tromey.com>
2010
2011 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2012 type.
2013 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2014 protected.
2015
f7952c57
TT
20162019-06-25 Tom Tromey <tom@tromey.com>
2017
2018 * tui/tui-winsource.c
2019 (tui_source_window_base::set_is_exec_point_at): Add check against
2020 LOA_ADDRESS.
2021
17568d78
TT
20222019-06-25 Tom Tromey <tom@tromey.com>
2023
2024 * tui/tui-source.c (tui_set_source_content): Don't check before
2025 xfree.
2026 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2027
53e7cdba
TT
20282019-06-25 Tom Tromey <tom@tromey.com>
2029
2030 * tui/tui-winsource.h (tui_update_source_window_as_is)
2031 (tui_alloc_source_buffer, tui_line_is_displayed)
2032 (tui_addr_is_displayed): Change type of win_info.
2033 * tui/tui-winsource.c (tui_update_source_window_as_is)
2034 (tui_clear_source_content, tui_show_source_line)
2035 (tui_show_source_content, tui_source_window_base::refill)
2036 (tui_source_window_base::set_is_exec_point_at)
2037 (tui_source_window_base::set_is_exec_point_at)
2038 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2039 (tui_alloc_source_buffer, tui_line_is_displayed)
2040 (tui_addr_is_displayed): Change type of win_info. Update.
2041 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2042 (tui_source_window_base::do_make_visible_with_new_height):
2043 Update.
2044 * tui/tui-source.c (tui_set_source_content)
2045 (tui_set_source_content_nil)
2046 (tui_source_window::do_scroll_vertical): Update.
2047 * tui/tui-layout.c (show_layout): Update.
2048 * tui/tui-disasm.c (tui_set_disassem_content)
2049 (tui_disasm_window::do_scroll_vertical): Update.
2050 * tui/tui-data.h (tui_win_content): Remove.
2051 (struct tui_gen_win_info) <content, content_size>: Remove.
2052 (struct tui_source_element): Add initializers and destructor.
2053 (union tui_which_element, struct tui_win_element): Remove.
2054 (struct tui_source_window_base) <content>: New field.
2055 (struct tui_data_window): Remove destructor.
2056 (tui_alloc_content, tui_free_win_content)
2057 (tui_free_all_source_wins_content): Don't declare.
2058 * tui/tui-data.c (tui_initialize_static_data): Update.
2059 (init_content_element, tui_alloc_content): Remove.
2060 (~tui_gen_win_info): Update.
2061 (~tui_data_window, tui_free_all_source_wins_content)
2062 (tui_free_win_content, free_content, free_content_elements):
2063 Remove.
2064
7908abbf
TT
20652019-06-25 Tom Tromey <tom@tromey.com>
2066
2067 * tui/tui-winsource.h (tui_clear_source_content)
2068 (tui_erase_source_content, tui_show_source_content): Change type
2069 of win_info.
2070 * tui/tui-winsource.c (tui_clear_source_content)
2071 (tui_erase_source_content, tui_show_source_content): Change type
2072 of win_info.
2073 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2074 * tui/tui-source.h (tui_set_source_content_nil): Change type of
2075 win_info.
2076 * tui/tui-source.c (tui_set_source_content_nil): Change type of
2077 win_info.
2078 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2079
02c28df0
TT
20802019-06-25 Tom Tromey <tom@tromey.com>
2081
2082 * tui/tui-winsource.c (tui_clear_source_content)
2083 (tui_source_window_base::set_is_exec_point_at): Update.
2084 * tui/tui-source.c (tui_set_source_content_nil): Update.
2085 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2086 a bool.
2087 * tui/tui-data.c (init_content_element): Update.
2088
6658b1bf
TT
20892019-06-25 Tom Tromey <tom@tromey.com>
2090
2091 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2092 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2093 * tui/tui-layout.c (init_and_make_win): Update.
2094 * tui/tui.h (enum tui_win_type): Update.
2095 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2096 tui_win_is_auxillary.
2097 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2098 tui_win_is_auxillary.
2099
21e1c91e
TT
21002019-06-25 Tom Tromey <tom@tromey.com>
2101
2102 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2103 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2104 (tui_delete_data_content_windows, tui_display_all_data)
2105 (tui_data_window::do_scroll_vertical, tui_display_data_from):
2106 Update.
2107 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2108 * tui/tui-regs.c (tui_last_regs_line_no)
2109 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2110 (tui_show_registers): Update.
2111 (tui_show_register_group): Return void. Update.
2112 (tui_display_registers_from, tui_display_reg_element_at_line)
2113 (tui_display_registers_from_line, tui_check_register_values):
2114 Update.
2115 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2116 member.
2117 (struct tui_data_window) <regs_content>: Now a std::vector.
2118 <regs_content_count>: Remove.
2119 (tui_add_content_elements, tui_free_data_content): Don't declare.
2120 * tui/tui-data.c (tui_data_window::clear_detail): Update.
2121 (init_content_element): Remove DATA_WIN case. Add assert.
2122 (tui_add_content_elements): Remove.
2123 (tui_data_window): Update.
2124 (tui_free_data_content): Remove.
2125 (free_content_elements): Remove DATA_WIN case.
2126
115ac53b
TT
21272019-06-25 Tom Tromey <tom@tromey.com>
2128
2129 * tui/tui-data.c (tui_data_item_window): Update.
2130 * tui/tui-windata.h (tui_check_data_values): Don't declare.
2131 * tui/tui-windata.c (tui_display_all_data)
2132 (tui_display_data_from_line): Update.
2133 (tui_check_data_values): Remove.
2134 * tui/tui-regs.c (tui_show_register_group)
2135 (tui_display_reg_element_at_line): Update.
2136 * tui/tui-hooks.c (tui_register_changed)
2137 (tui_refresh_frame_and_register_information): Call
2138 tui_check_register_values.
2139 * tui/tui-data.h (struct tui_data_window) <data_content,
2140 data_content_count, data_type>: Remove.
2141 (enum tui_data_type): Remove.
2142
2143 * tui/tui-data.c (tui_data_window::clear_detail)
2144 (~tui_data_window): Update.
2145
eaf9738b
TT
21462019-06-25 Tom Tromey <tom@tromey.com>
2147
2148 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2149 declare.
2150 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2151 Rename from tui_first_data_item_displayed. Update.
2152 (tui_data_window::refresh_all)
2153 (tui_data_window::do_scroll_vertical): Update.
2154 * tui/tui-data.h (struct tui_data_window)
2155 <first_data_item_displayed>: Declare new method.
2156
31ca4723
TT
21572019-06-25 Tom Tromey <tom@tromey.com>
2158
2159 * tui/tui-data.h (tui_init_generic_part): Don't declare.
2160 * tui/tui-data.c (tui_init_generic_part): Remove, moving
2161 contents...
2162 (tui_initialize_static_data): ...here.
2163
41bcff7f
TT
21642019-06-25 Tom Tromey <tom@tromey.com>
2165
2166 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2167 (tui_display_registers_from, tui_check_register_values): Update.
2168 (tui_display_register): Remove win_info parameter; update.
2169 (tui_get_register): Change type of parameters.
2170 * tui/tui-data.h (struct tui_data_element): Remove.
2171 (union tui_which_element) <data>: Remove.
2172 <data_window>: Change type.
2173 (struct tui_data_item_window): New.
2174 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2175 case. Add assert.
2176 (~tui_data_item_window): New destructor.
2177 (free_content_elements): Remove DATA_ITEM_WIN case.
2178
d2802c33
TT
21792019-06-25 Tom Tromey <tom@tromey.com>
2180
2181 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2182 Remove.
2183
dd835f8b
TT
21842019-06-25 Tom Tromey <tom@tromey.com>
2185
2186 * tui/tui-data.h (struct tui_command_element): Remove.
2187 (union tui_which_element) <command>: Remove.
2188 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
2189 assert.
2190 (free_content_elements): Remove CMD_WIN case.
2191
bd7db367
TT
21922019-06-25 Tom Tromey <tom@tromey.com>
2193
2194 * tui/tui-layout.c (tui_set_layout): Update.
2195 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2196 * tui/tui-data.c (layout_def): Update.
2197
3add462f
TT
21982019-06-25 Tom Tromey <tom@tromey.com>
2199
2200 * tui/tui-wingeneral.c (tui_refresh_all): Update.
2201 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2202 (tui_source_window_base::set_new_height): Update.
2203 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2204 Update.
2205 (tui_set_locator_fullname, tui_set_locator_info)
2206 (tui_show_frame_info): Update.
2207 * tui/tui-source.c (tui_set_source_content)
2208 (tui_source_is_displayed): Update.
2209 * tui/tui-layout.c (show_source_disasm_command, show_data)
2210 (show_source_or_disasm_and_command): Update.
2211 * tui/tui-disasm.c (tui_set_disassem_content)
2212 (tui_get_begin_asm_address): Update.
2213 * tui/tui-data.h (struct tui_locator_element): Remove.
2214 (union tui_which_element) <locator>: Remove.
2215 (struct tui_locator_window): New.
2216 (tui_locator_win_info_ptr): Change return type.
2217 * tui/tui-data.c (_locator): Change type.
2218 (tui_locator_win_info_ptr): Change return type.
2219 (init_content_element): Remove LOCATOR_WIN case. Add assert.
2220 (tui_alloc_content): Add assert.
2221
489e9d8b
TT
22222019-06-25 Tom Tromey <tom@tromey.com>
2223
2224 * tui/tui-winsource.c
2225 (tui_exec_info_window::maybe_allocate_content): New method.
2226 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2227 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2228 (make_source_or_disasm_window): Add cast.
2229 * tui/tui-data.h (union tui_which_element) <simple_string>:
2230 Remove.
2231 (struct tui_source_info): New.
2232 (struct tui_source_window_base) <execution_info>: Change type.
2233 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2234 case, and add assert.
2235 (tui_alloc_content): Add assert.
2236
c3fabb7d
TT
22372019-06-25 Tom Tromey <tom@tromey.com>
2238
2239 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2240 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2241 * tui/tui-data.c (tui_alloc_win_info): Remove.
2242
bbc228ee
TT
22432019-06-25 Tom Tromey <tom@tromey.com>
2244
2245 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2246 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2247 can_highlight.
2248
5fcee43a
TT
22492019-06-25 Tom Tromey <tom@tromey.com>
2250
2251 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2252 make_visible_with_new_height method.
2253 (tui_win_info::make_visible_with_new_height): New method.
2254 (tui_source_window_base::do_make_visible_with_new_height)
2255 (tui_data_window::do_make_visible_with_new_height)
2256 (tui_cmd_window::do_make_visible_with_new_height): New methods.
2257 (make_visible_with_new_height): Remove.
2258 (tui_resize_all, tui_adjust_win_heights): Use
2259 make_visible_with_new_height method.
2260 * tui/tui-data.h (struct tui_win_info)
2261 <do_make_visible_with_new_height, make_visible_with_new_height>:
2262 New methods.
2263 (struct tui_source_window_base, struct tui_data_window)
2264 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2265 methods.
2266
d83f1fe6
TT
22672019-06-25 Tom Tromey <tom@tromey.com>
2268
2269 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2270 method.
2271 (update_tab_width): Call update_tab_width method.
2272 * tui/tui-data.h (struct tui_win_info)
2273 (struct tui_source_window_base) <update_tab_width>: New methods.
2274
17374de4
TT
22752019-06-25 Tom Tromey <tom@tromey.com>
2276
2277 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2278 parameter.
2279 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2280 parameter.
2281 (tui_gen_win_info::make_visible): Update.
2282 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2283 parameter.
2284 * tui/tui-data.h (enum tui_box): New enum.
2285 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2286
f936bca2
TT
22872019-06-25 Tom Tromey <tom@tromey.com>
2288
2289 * tui/tui-layout.c (make_source_or_disasm_window): Always use
2290 init_and_make_win for EXEC_INFO_WIN.
2291 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2292 longer inline.
2293 (struct tui_win_info) <~tui_win_info>: Inline.
2294 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2295 Don't declare.
2296 * tui/tui-data.c (source_win, disasm_win): Remove globals.
2297 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2298 Remove.
2299 (tui_initialize_static_data): Update.
2300 (~tui_gen_win_info): Handle more cleanup here.
2301 (~tui_source_window_base): Delete "execution_info".
2302 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2303
d6ba6a11
TT
23042019-06-25 Tom Tromey <tom@tromey.com>
2305
2306 * tui/tui-layout.c (make_command_window): Don't set
2307 can_highlight.
2308 (show_source_disasm_command): Call the reset method.
2309 (show_data): Don't set can_highlight. Call the reset method.
2310 (tui_gen_win_info::reset): Rename from init_gen_win_info
2311 (init_and_make_win): Simplify. Return tui_gen_win_info.
2312 (show_source_or_disasm_and_command): Call the reset method.
2313 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2314 (struct tui_cmd_window): Set can_highlight.
2315
48a3bd16
TT
23162019-06-25 Tom Tromey <tom@tromey.com>
2317
2318 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2319 from make_visible.
2320 (tui_make_visible, tui_make_invisible): Rewrite.
2321 (tui_win_info::make_visible): Remove.
2322 (tui_source_window_base::make_visible): Update.
2323 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2324 method. Moved from...
2325 (struct tui_win_info) <make_visible>: ...here.
2326
c3bd716f
TT
23272019-06-25 Tom Tromey <tom@tromey.com>
2328
2329 * tui/tui-winsource.c
2330 (tui_source_window_base::do_scroll_horizontal): Remove direction
2331 parameter.
2332 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2333 direction parameter.
2334 * tui/tui-win.c (tui_win_info::forward_scroll)
2335 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2336 (tui_win_info::right_scroll): Update.
2337 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2338 direction parameter.
2339 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2340 direction parameter.
2341 * tui/tui-data.h (enum tui_scroll_direction): Remove.
2342 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2343 Remove direction parameter.
2344 (struct tui_source_window_base, struct tui_source_window)
2345 (struct tui_disasm_window, struct tui_data_window)
2346 (struct tui_cmd_window): Update.
2347
21c32dca
TT
23482019-06-25 Tom Tromey <tom@tromey.com>
2349
2350 * tui/tui-winsource.h (tui_set_exec_info_content)
2351 (tui_show_exec_info_content, tui_erase_exec_info_content)
2352 (tui_clear_exec_info_content, tui_update_exec_info): Change
2353 argument to tui_source_window_base.
2354 * tui/tui-winsource.c (tui_set_exec_info_content)
2355 (tui_show_exec_info_content, tui_erase_exec_info_content)
2356 (tui_clear_exec_info_content, tui_update_exec_info): Change
2357 argument to tui_source_window_base.
2358
73fbdc65
TT
23592019-06-25 Tom Tromey <tom@tromey.com>
2360
2361 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2362 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2363
33325343
TT
23642019-06-25 Tom Tromey <tom@tromey.com>
2365
2366 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2367 check.
2368
29d2c474
TT
23692019-06-25 Tom Tromey <tom@tromey.com>
2370
2371 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2372 type to void.
2373 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2374 type to void.
2375 * tui/tui-source.c (tui_set_source_content): Update.
2376 * tui/tui-disasm.c (tui_set_disassem_content): Update.
2377
152f3f4b
TT
23782019-06-25 Tom Tromey <tom@tromey.com>
2379
2380 * tui/tui-win.c (window_name_completer, tui_set_focus)
2381 (tui_all_windows_info): Use name method.
2382 * tui/tui-data.h (struct tui_gen_win_info)
2383 (struct tui_source_window, struct tui_disasm_window)
2384 (struct tui_data_window, struct tui_cmd_window) <name>: New
2385 method.
2386 (tui_win_name): Don't declare.
2387 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2388 (tui_win_name): Remove.
2389
be4da588
TT
23902019-06-25 Tom Tromey <tom@tromey.com>
2391
2392 * tui/tui-winsource.h (tui_update_source_window)
2393 (tui_update_source_window_as_is): Change parameter type.
2394 * tui/tui-winsource.c (tui_update_source_window): Change win_info
2395 to be a tui_source_window_base.
2396 (tui_update_source_window_as_is): Likewise.
2397 * tui/tui-win.c (make_visible_with_new_height): Update.
2398
5b81daba
TT
23992019-06-25 Tom Tromey <tom@tromey.com>
2400
2401 * tui/tui-winsource.c (tui_erase_source_content)
2402 (tui_show_source_content, tui_show_exec_info_content)
2403 (tui_erase_exec_info_content): Use refresh_window method.
2404 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2405 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2406 from tui_refresh_win.
2407 (tui_data_window::refresh_window): New method.
2408 (tui_win_info::refresh, tui_source_window_base::refresh)
2409 (tui_refresh_all): Use refresh_window method.
2410 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2411 method.
2412 * tui/tui-regs.c (tui_display_register): Call refresh_window
2413 method.
2414 * tui/tui-layout.c (show_source_disasm_command)
2415 (show_source_or_disasm_and_command): Call refresh_window method.
2416 * tui/tui-data.h (struct tui_gen_win_info)
2417 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2418 New method.
2419
cb2ce893
TT
24202019-06-25 Tom Tromey <tom@tromey.com>
2421
2422 * tui/tui.c (tui_rl_other_window, tui_enable)
2423 (tui_is_window_visible, tui_get_command_dimension): Update.
2424 * tui/tui-winsource.c (tui_update_source_window_as_is)
2425 (tui_clear_source_content, tui_erase_source_content)
2426 (tui_show_source_line, tui_source_window_base::refill)
2427 (tui_source_window_base::do_scroll_horizontal)
2428 (tui_source_window_base::set_is_exec_point_at)
2429 (tui_update_breakpoint_info, tui_set_exec_info_content)
2430 (tui_alloc_source_buffer, tui_line_is_displayed)
2431 (tui_addr_is_displayed): Update.
2432 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2433 (tui_check_and_display_highlight_if_needed)
2434 (tui_win_info::make_visible, tui_win_info::refresh)
2435 (tui_refresh_all): Update.
2436 * tui/tui-windata.c (tui_first_data_item_displayed)
2437 (tui_delete_data_content_windows, tui_erase_data_content)
2438 (tui_display_all_data, tui_data_window::refresh_all)
2439 (tui_check_data_values): Update.
2440 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2441 (tui_set_win_focus_to, tui_win_info::forward_scroll)
2442 (tui_win_info::backward_scroll, tui_refresh_all_win)
2443 (tui_resize_all, tui_set_focus, tui_all_windows_info)
2444 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2445 (tui_source_window_base::set_new_height)
2446 (tui_data_window::set_new_height)
2447 (make_invisible_and_set_new_height)
2448 (make_visible_with_new_height, new_height_ok)
2449 (parse_scrolling_args): Update.
2450 * tui/tui-stack.c (tui_show_frame_info): Update.
2451 * tui/tui-source.c (tui_set_source_content)
2452 (tui_set_source_content_nil, tui_source_is_displayed)
2453 (tui_source_window::do_scroll_vertical): Update.
2454 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2455 (tui_display_registers_from, tui_display_reg_element_at_line)
2456 (tui_check_register_values, tui_reg_command): Update.
2457 * tui/tui-layout.c (tui_default_win_height)
2458 (show_source_disasm_command, show_data, init_and_make_win)
2459 (show_source_or_disasm_and_command): Update.
2460 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2461 (tui_redisplay_readline, tui_mld_flush)
2462 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2463 (tui_getc): Update.
2464 * tui/tui-disasm.c (tui_set_disassem_content)
2465 (tui_disasm_window::do_scroll_vertical): Update.
2466 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2467 Now virtual.
2468 (struct tui_win_info): Derive from tui_gen_win_info.
2469 <~tui_win_info>: Mark as override.
2470 <generic>: Remove member.
2471 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2472 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2473 (~tui_data_window, ~tui_win_info)
2474 (tui_free_all_source_wins_content): Update.
2475 * tui/tui-command.c (tui_refresh_cmd_win): Update.
2476
ab313b35
TT
24772019-06-25 Tom Tromey <tom@tromey.com>
2478
2479 * tui/tui-layout.c (init_and_make_win): Use new.
2480 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2481 destructor, initializers.
2482 (tui_alloc_generic_win_info): Don't declare.
2483 * tui/tui-data.c (_locator): Add argument to constructor.
2484 (source_win, disasm_win): New globals.
2485 (exec_info): Remove.
2486 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2487 Update.
2488 (tui_alloc_generic_win_info): Remove.
2489 (init_content_element): Use new.
2490 (tui_win_info::tui_win_info): Update.
2491 (free_content_elements) <case DATA_WIN>: Use delete.
2492
dc2c33e4
TT
24932019-06-25 Tom Tromey <tom@tromey.com>
2494
2495 * tui/tui-wingeneral.c (tui_refresh_win): Update.
2496 * tui/tui-windata.c (tui_first_data_item_displayed)
2497 (tui_delete_data_content_windows): Update.
2498 * tui/tui-win.c (tui_data_window::set_new_height): Update.
2499 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2500 (tui_display_registers_from, tui_check_register_values): Update.
2501 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2502 pointer.
2503 * tui/tui-data.c (init_content_element): Update. Allocate the new
2504 window.
2505 (tui_free_data_content): Update.
2506 (free_content_elements) <case DATA_WIN>: Free the window.
2507
214a5cbe
TT
25082019-06-25 Tom Tromey <tom@tromey.com>
2509
2510 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2511 Update.
2512 * tui/tui-layout.c (make_command_window)
2513 (show_source_disasm_command, show_data, init_and_make_win)
2514 (show_source_or_disasm_and_command): Update.
2515 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2516 method.
2517 <can_highight, is_highlighted>: Now bool.
2518 (tui_set_win_highlight): Don't declare.
2519 * tui/tui-data.c (tui_set_win_highlight): Remove.
2520
8e2daf15
TT
25212019-06-25 Tom Tromey <tom@tromey.com>
2522
2523 * tui/tui-wingeneral.c (make_visible): Remove check of window
2524 type.
2525
8903bd8a
TT
25262019-06-25 Tom Tromey <tom@tromey.com>
2527
2528 * tui/tui-win.c (tui_win_info::max_height)
2529 (tui_cmd_window::max_height): New methods.
2530 (new_height_ok): Call max_height.
2531 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2532 <max_height>: New method.
2533
3f02ce1e
TT
25342019-06-25 Tom Tromey <tom@tromey.com>
2535
2536 * tui/tui-win.c (tui_source_window_base::set_new_height)
2537 (tui_data_window::set_new_height): New methods.
2538 (make_invisible_and_set_new_height): Call set_new_height method.
2539 * tui/tui-data.h (struct tui_win_info)
2540 (struct tui_source_window_base, struct tui_data_window)
2541 <set_new_height>: New method.
2542
1825f487
TT
25432019-06-25 Tom Tromey <tom@tromey.com>
2544
2545 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2546 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2547 tui_refresh_data_win.
2548 * tui/tui-win.c (tui_source_window_base::refresh_all): New
2549 method.
2550 (tui_refresh_all_win): Call the refresh_all method.
2551 (tui_set_focus): Likewise.
2552 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2553 (struct tui_source_window_base, struct tui_data_window) <refresh>:
2554 Likewise.
2555
ad54d15b
TT
25562019-06-25 Tom Tromey <tom@tromey.com>
2557
2558 * tui/tui-winsource.h (tui_refill_source_window)
2559 (tui_set_is_exec_point_at): Don't declare.
2560 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2561 (tui_source_window_base::refill): Rename from
2562 tui_refill_source_window.
2563 (tui_source_window_base::do_scroll_horizontal): Update.
2564 (tui_source_window_base::set_is_exec_point_at): Rename from
2565 tui_set_is_exec_point_at.
2566 (tui_update_all_breakpoint_info): Update.
2567 * tui/tui-stack.c (tui_show_frame_info): Update.
2568 * tui/tui-layout.c (show_data): Add cast.
2569 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2570 * tui/tui-data.h (struct tui_source_window_base) <refill,
2571 set_is_exec_point_at>: New methods.
2572 (tui_source_windows, tui_add_to_source_windows): Update types.
2573 (tui_add_to_source_windows): Remove redundant declaration.
2574 * tui/tui-data.c (source_windows): Store tui_source_window_base.
2575 (tui_source_windows): Change return type.
2576 (tui_clear_source_windows_detail): Update.
2577 (tui_add_to_source_windows): Change type of parameter.
2578 (tui_free_all_source_wins_content): Update.
2579
2042b506
TT
25802019-06-25 Tom Tromey <tom@tromey.com>
2581
2582 * tui/tui-wingeneral.c (tui_win_info::refresh)
2583 (tui_source_window_base::refresh): New methods.
2584 (tui_refresh_all): Call the refresh method.
2585 * tui/tui-data.h (struct tui_win_info)
2586 (struct tui_source_window_base) <refresh>: New method.
2587
56122977
TT
25882019-06-25 Tom Tromey <tom@tromey.com>
2589
2590 * tui/tui.h (tui_is_window_visible): Return bool.
2591 * tui/tui.c (tui_is_window_visible): Return bool.
2592 * tui/tui-wingeneral.c (tui_make_window, make_visible)
2593 (tui_make_visible, tui_make_invisible)
2594 (tui_win_info::make_visible)
2595 (tui_source_window_base::make_visible, make_all_visible)
2596 (tui_make_all_visible, tui_make_all_invisible): Update.
2597 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2598 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2599 bool.
2600 (struct tui_win_info, struct tui_source_window_base)
2601 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2602 * tui/tui-data.c (tui_init_generic_part): Update.
2603
cda37efb
TT
26042019-06-25 Tom Tromey <tom@tromey.com>
2605
2606 * tui/tui-wingeneral.c (tui_win_info::make_visible)
2607 (tui_source_window_base::make_visible): New methods.
2608 (make_all_visible): Make method call.
2609 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2610 (struct tui_source_window_base, struct tui_cmd_window): Override
2611 make_visible.
2612 (tui_win_is_source_type): Don't declare.
2613 * tui/tui-data.c (tui_win_is_source_type): Remove.
2614
6a0ee02c
TT
26152019-06-25 Tom Tromey <tom@tromey.com>
2616
2617 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2618 NULL check.
2619
63901aec
TT
26202019-06-25 Tom Tromey <tom@tromey.com>
2621
2622 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2623 Inline constructor. Add initializers for members.
2624 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2625 constructors; now inline in class.
2626
ceb13a13
TT
26272019-06-25 Tom Tromey <tom@tromey.com>
2628
2629 * tui/tui-regs.c (tui_show_registers): Update.
2630 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2631 bool.
2632 * tui/tui-data.c (tui_data_window::clear_detail)
2633 (tui_data_window): Update.
2634
238eb706
TT
26352019-06-25 Tom Tromey <tom@tromey.com>
2636
2637 * tui/tui-windata.c (tui_display_all_data)
2638 (tui_display_data_from_line, tui_display_data_from)
2639 (tui_check_data_values, tui_data_window::do_scroll_vertical):
2640 Update.
2641 * tui/tui-regs.c (tui_last_regs_line_no)
2642 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2643 (tui_show_registers, tui_show_register_group)
2644 (tui_display_registers_from, tui_display_reg_element_at_line)
2645 (tui_display_registers_from_line, tui_check_register_values)
2646 (tui_reg_next, tui_reg_prev): Update.
2647 * tui/tui-layout.c (tui_set_layout, show_data): Update.
2648 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
2649 tui_data_window.
2650 (struct tui_win_info) <detail>: Remove. Add new fields from
2651 tui_data_info.
2652 (TUI_DATA_WIN): Add cast.
2653 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2654 (~tui_data_window): Simplify.
2655
81491aa0
TT
26562019-06-25 Tom Tromey <tom@tromey.com>
2657
2658 * tui/tui-layout.c (show_source_disasm_command)
2659 (show_source_or_disasm_and_command): Update.
2660 * tui/tui-io.c (update_cmdwin_start_line)
2661 (tui_redisplay_readline): Update.
2662 * tui/tui-data.h (struct tui_command_info): Remove.
2663 (struct tui_win_info) <detail>: Remove command_info member.
2664 (struct tui_data_window) <start_line>: New member, from
2665 tui_command_info.
2666 (TUI_CMD_WIN): Add casts.
2667
e6e41501
TT
26682019-06-25 Tom Tromey <tom@tromey.com>
2669
2670 * tui/tui-winsource.c (tui_update_source_window)
2671 (tui_refill_source_window)
2672 (tui_source_window_base::do_scroll_horizontal)
2673 (tui_update_breakpoint_info, tui_set_exec_info_content)
2674 (tui_show_exec_info_content, tui_erase_exec_info_content)
2675 (tui_clear_exec_info_content): Update.
2676 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2677 Update.
2678 * tui/tui-win.c (make_invisible_and_set_new_height)
2679 (make_visible_with_new_height): Update.
2680 * tui/tui-source.c (tui_set_source_content)
2681 (tui_show_symtab_source): Update.
2682 * tui/tui-layout.c (extract_display_start_addr)
2683 (show_source_disasm_command, show_data)
2684 (make_source_or_disasm_window)
2685 (show_source_or_disasm_and_command): Update.
2686 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2687 (tui_disasm_window::do_scroll_vertical): Remove shadowing
2688 "gdbarch".
2689 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
2690 to tui_source_window_base.
2691 (struct tui_win_info) <detail>: Remove source_info member.
2692 (struct tui_source_window_base) <has_locator>: Inline.
2693 Move contents from tui_source_info; rename has_locator member to
2694 m_has_locator.
2695 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2696 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2697 header file.
2698 (tui_source_window_base::clear_detail, ~tui_source_window_base):
2699 Simplify.
2700 (tui_free_all_source_wins_content): Cast to
2701 tui_source_window_base.
2702
44f0e208
TT
27032019-06-25 Tom Tromey <tom@tromey.com>
2704
2705 * tui/tui-win.c (make_invisible_and_set_new_height)
2706 (make_visible_with_new_height): Call has_locator method.
2707 * tui/tui-layout.c (show_source_disasm_command, show_data)
2708 (show_source_or_disasm_and_command): Update for bool change.
2709 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2710 (tui_win_info) <has_locator>: New method.
2711 (struct tui_source_window_base) <has_locator>: New method.
2712 (tui_win_has_locator): Don't declare.
2713 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2714 from tui_win_has_locator.
2715 (tui_source_window_base): Use false, not FALSE.
2716
7778b912
TT
27172019-06-25 Tom Tromey <tom@tromey.com>
2718
2719 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2720 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2721 clear_detail method directly.
2722 (tui_clear_win_detail): Remove.
2723
f83d391c
TT
27242019-06-25 Tom Tromey <tom@tromey.com>
2725
2726 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2727 "this", not TUI_DISASM_WIN.
2728
13446e05
TT
27292019-06-25 Tom Tromey <tom@tromey.com>
2730
2731 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
2732 declare.
2733 * tui/tui-winsource.c
2734 (tui_source_window_base::do_scroll_horizontal): Rename from
2735 tui_horizontal_source_scroll.
2736 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2737 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2738 from tui_vertical_data_scroll.
2739 * tui/tui-win.h (tui_scroll): Don't declare.
2740 * tui/tui-win.c (tui_win_info::forward_scroll)
2741 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2742 (tui_win_info::right_scroll): Rename and update.
2743 (tui_scroll_forward_command, tui_scroll_backward_command)
2744 (tui_scroll_left_command, tui_scroll_right_command): Update.
2745 (tui_scroll): Remove.
2746 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2747 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2748 from tui_vertical_source_scroll.
2749 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2750 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2751 from tui_vertical_disassem_scroll.
2752 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2753 do_scroll_horizontal>: New methods.
2754 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2755 Likewise.
2756 (struct tui_source_window_base): Add do_scroll_horizontal.
2757 (struct tui_source_window, struct tui_disasm_window): Add
2758 do_scroll_vertical.
2759 (struct tui_data_window, struct tui_cmd_window): Add
2760 do_scroll_horizontal and do_scroll_vertical.
2761 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2762
5cf82909
TT
27632019-06-25 Tom Tromey <tom@tromey.com>
2764
2765 * tui/tui-data.h (struct tui_source_window_base): New struct.
2766 (struct tui_source_window): Derive from tui_source_window_base.
2767 (struct tui_disasm_window): New struct.
2768 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2769 from tui_source_window::clear_detail.
2770 (tui_source_window_base): Rename from tui_source_window.
2771 (~tui_source_window_base): Rename from ~tui_source_window.
2772 (tui_alloc_win_info): Create a tui_disasm_window.
2773
ee1d42d6
TT
27742019-06-25 Tom Tromey <tom@tromey.com>
2775
2776 * tui/tui-data.h (struct tui_source_window)
2777 (struct tui_data_window): Declare destructors.
2778 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2779 destructors.
2780 (tui_win_info): Simplify.
2781
b4eb2452
TT
27822019-06-25 Tom Tromey <tom@tromey.com>
2783
2784 * tui/tui-winsource.c (tui_display_main)
2785 (tui_update_source_windows_with_addr)
2786 (tui_update_all_breakpoint_info): Update.
2787 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2788 (new_height_ok, parse_scrolling_args): Update.
2789 * tui/tui-stack.c (tui_show_frame_info): Update.
2790 * tui/tui-data.h (struct tui_list): Remove.
2791 (tui_source_windows): Return a reference to a std::vector.
2792 * tui/tui-data.c (source_windows): Now a std::vector.
2793 (tui_source_windows): Change return type.
2794 (tui_clear_source_windows): Rewrite.
2795 (tui_clear_source_windows_detail, tui_add_to_source_windows)
2796 (tui_free_all_source_wins_content): Rewrite.
2797
8761a91b
TT
27982019-06-25 Tom Tromey <tom@tromey.com>
2799
2800 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2801 (struct tui_data_window, struct tui_cmd_window): Declare
2802 clear_detail method.
2803 * tui/tui-data.c (tui_source_window::clear_detail)
2804 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2805 methods.
2806 (tui_clear_win_detail): Simplify.
2807
0ed69eda
TT
28082019-06-25 Tom Tromey <tom@tromey.com>
2809
2810 * tui/tui-layout.c (make_source_window, make_disasm_window)
2811 (make_source_or_disasm_window): Remove win_info_ptr parameter.
2812 Return the new window.
2813 (show_source_disasm_command, show_data)
2814 (show_source_or_disasm_and_command): Update.
2815
82432e10
TT
28162019-06-25 Tom Tromey <tom@tromey.com>
2817
2818 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2819 parameter. Return the new window.
2820 (show_source_disasm_command): Update and remove NULL check.
2821 (show_source_or_disasm_and_command): Update.
2822
ec328aa5
TT
28232019-06-25 Tom Tromey <tom@tromey.com>
2824
2825 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2826
33b906ab
TT
28272019-06-25 Tom Tromey <tom@tromey.com>
2828
2829 * tui/tui-data.h (struct tui_win_info): Make constructor
2830 protected. Make destructor virtual. Add initializers.
2831 (tui_source_window, tui_data_window, tui_cmd_window): New
2832 classes.
2833 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
2834 constructor. Add "type" parameter.
2835 (tui_source_window, tui_data_window, tui_cmd_window): New
2836 constructors.
2837 (tui_alloc_win_info): Instantiate the appropriate subclass.
2838
e7e11af4
TT
28392019-06-25 Tom Tromey <tom@tromey.com>
2840
2841 * tui/tui-win.c (tui_resize_all): Use delete.
2842 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2843 destructor.
2844 (tui_free_window): Don't declare.
2845 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2846 Update.
2847
6792b55e
TT
28482019-06-25 Tom Tromey <tom@tromey.com>
2849
2850 * tui/tui-data.h (struct tui_win_info): Add constructor.
2851 * tui/tui-data.c (tui_alloc_win_info): Use new.
2852 (tui_free_window): Use delete.
2853
f95675e1
TT
28542019-06-22 Tom Tromey <tom@tromey.com>
2855
2856 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2857 declare.
2858 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2859
5bff081c
TT
28602019-06-22 Tom Tromey <tom@tromey.com>
2861
2862 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2863 declare.
2864 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2865
47e3f474
TV
28662019-06-22 Tom de Vries <tdevries@suse.de>
2867
2868 * dwarf2read.c (create_addrmap_from_aranges)
2869 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2870 instead of '%zu'.
2871
fd5866f6
SM
28722019-06-21 Simon Marchi <simon.marchi@efficios.com>
2873
2874 * dwarf2read.h (dwarf2_section_info_def): Remove.
2875 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2876 * dwarf2read.c (struct dwo_sections) <types>: Change type to
2877 std::vector<dwarf2_section_info>.
2878 (struct dwo_file) <~dwo_file>: Remove.
2879 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2880 types field.
2881 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2882 (dwarf2_read_debug_names): Likewise.
2883 (create_debug_types_hash_table): Change parameter type to
2884 array_view, adjust code accordingly.
2885 (dwarf2_locate_dwo_sections): Adjust to std::vector.
2886 (partial_die_info::fixup): Likewise.
2887 (determine_prefix): Likewise.
2888 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2889
fb1eb2f9
SM
28902019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
2891
2892 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2893 gdb_bfd_ref_ptr.
2894 <~dwo_file>: Remove call to gdb_bfd_unref.
2895 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2896 gdb_bfd_ref_ptr::get.
2897
51ac9db5
SM
28982019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
2899
2900 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2901 type to htab_up.
2902 * dwarf2read.c (struct dwo_file): Initialize fields.
2903 <~dwo_file>: New.
2904 (free_dwo_file): Remove, move content to ~dwo_file.
2905 (struct dwo_file_deleter): Remove.
2906 (dwo_file_up>: Remove custom deleter.
2907 (free_dwo_files): Remove.
2908 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2909 dwo_files.
2910 (process_skeletonless_type_units): Call unique_ptr::get.
2911 (allocate_dwo_file_hash_table): Add deleter to created hash
2912 table. Change return type to htab_up.
2913 (lookup_dwo_file_slot): Don't memset dwo_file, call
2914 unique_ptr::get.
2915 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2916 (create_dwo_unit_in_dwp_v2): Likewise.
2917 (open_and_init_dwo_file): Likewise.
2918 (free_dwo_file_from_slot): Remove.
2919
dc4ccb6f
SM
29202019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
2921
2922 * dwarf2read.h (struct dwarf2_section_info) <readin,
2923 is_virtual>: Change type to bool.
2924 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2925 true instead of 1.
2926
e6a1c5cb
TT
29272019-06-19 Tom Tromey <tom@tromey.com>
2928
2929 * tui/tui-data.h (tui_init_content_element): Don't declare.
2930
6f6ffbeb
TT
29312019-06-19 Tom Tromey <tom@tromey.com>
2932
2933 * tui/tui-data.h (tui_init_win_info): Don't declare.
2934
f23f598e
TV
29352019-06-19 Tom de Vries <tdevries@suse.de>
2936
2937 * dwarf2read.h (abstract_to_concrete): Change type to
2938 std::unordered_map<sect_offset, std::vector<sect_offset>,
2939 gdb::hash_enum<sect_offset>>.
2940
680e1bee
TT
29412019-06-19 Tom Tromey <tromey@adacore.com>
2942
2943 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2944 EVAL_AVOID_SIDE_EFFECTS specially.
2945
dcf37923
TT
29462019-06-19 Tom Tromey <tromey@adacore.com>
2947
2948 * source-cache.c (highlighter): New global.
2949 (source_cache::get_source_lines): Create a highlighter on demand.
2950
494986d5
AB
29512019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
2952
2953 * defs.h (deprecated_interactive_hook): Delete declaration.
2954 * interps.c (clear_interpreter_hooks): Remove use of
2955 deprecated_interactive_hook.
2956 * top.c (deprecated_interactive_hook): Delete definition.
2957 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2958
3360b6e7
TV
29592019-06-18 Tom de Vries <tdevries@suse.de>
2960
2961 PR gdb/24515
2962 * dwarf2read.h (abstract_to_concrete): Change type from
2963 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2964 std::unordered_map<sect_offset, std::vector<sect_offset>>.
2965 * dwarf2read.c (read_variable): Update.
2966 (dwarf2_fetch_die_loc_sect_off): Update.
2967
310b3441
TV
29682019-06-17 Tom de Vries <tdevries@suse.de>
2969
2970 PR gdb/24617
2971 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2972 accessing parent[parent_len - 1].
2973
ba9777be
PP
29742019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
2975
2976 PR gdb/24364
2977 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2978 call dtrace_process_dof with NULL dof.
2979
2b9f6e89
TV
29802019-06-16 Tom de Vries <tdevries@suse.de>
2981
2982 PR gdb/24445
2983 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2984
431b3ead
TT
29852019-06-16 Tom Tromey <tom@tromey.com>
2986
2987 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2988 (make_all_visible): Use address of member.
2989
d04b44a1
TT
29902019-06-16 Tom Tromey <tom@tromey.com>
2991
2992 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2993 (tui_free_window, free_content, free_content_elements): Remove
2994 unnecessary cast.
2995 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2996 cast.
2997 * tui/tui-regs.c (tui_show_register_group)
2998 (tui_display_registers_from, tui_display_reg_element_at_line):
2999 Remove unnecessary cast.
3000
bf5142e7
AB
30012019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
3002
3003 * linux-nat.c (normal_mask): Delete.
3004 (_initialize_linux_nat): Don't initialise normal_mask.
3005
c4973306
SM
30062019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
3007
3008 PR gdb/24445
3009 * dwarf-index-write.h (write_psymtabs_to_index): Add
3010 dwz_basename parameter.
3011 * dwarf-index-write.c (write_gdbindex): Move file writing to
3012 write_gdbindex_1. Change return type void.
3013 (assert_file_size): Move up, remove filename parameter.
3014 (write_gdbindex_1): New function.
3015 (write_debug_names): Change return type to void, call
3016 assert_file_size.
3017 (struct index_wip_file): New struct.
3018 (write_psymtabs_to_index): Add dwz_basename parameter. Move
3019 file logic to index_wip_file. Write index for dwz file if
3020 needed.
3021 (save_gdb_index_command): Pass basename of dwz file, if present.
3022 * dwarf-index-cache.c (index_cache::store): Obtain and pass
3023 build-id of dwz file, if present.
3024 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3025 (dwarf2_get_dwz_file): Likewise.
3026 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3027 (dwarf2_get_dwz_file): Likewise.
3028
395f9c91
TT
30292019-06-16 Tom Tromey <tom@tromey.com>
3030
3031 * coffread.c (process_coff_symbol): Use xstrdup.
3032 * value.c (create_internalvar): Use xstrdup.
3033
cafb3438
TT
30342019-06-16 Tom Tromey <tom@tromey.com>
3035
3036 * valops.c (value_cast, value_slice): Remove unnecessary cast.
3037 * breakpoint.c (stopin_command, stopat_command)
3038 (until_break_command, decode_location_default): Remove unnecessary
3039 cast.
3040 * utils.c (subset_compare): Remove unnecessary cast.
3041 * ada-lang.c (ada_update_initial_language): Remove unnecessary
3042 cast.
3043 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3044 cast.
3045 * infcmd.c (path_command): Remove unnecessary cast.
3046 * coffread.c (decode_type): Remove unnecessary cast.
3047 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3048 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3049 * tui/tui-stack.c (tui_show_locator_content)
3050 (tui_show_frame_info): Remove unnecessary cast.
3051 * tui/tui-win.c (tui_scroll_forward_command)
3052 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3053 (parse_scrolling_args): Remove unnecessary cast.
3054 * tui/tui-data.c (init_win_info, tui_del_window)
3055 (tui_free_window, tui_del_data_windows, tui_free_data_content)
3056 (free_content_elements): Remove unnecessary cast.
3057 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3058 unnecessary cast.
3059 * tui/tui-source.c (tui_set_source_content)
3060 (tui_vertical_source_scroll): Remove unnecessary cast.
3061 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3062 cast.
3063 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3064 * tui/tui-regs.c (tui_display_registers_from)
3065 (tui_display_register): Remove unnecessary cast.
3066 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3067 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3068 (make_visible): Remove unnecessary cast.
3069 * tui/tui-winsource.c (tui_erase_source_content)
3070 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3071 unnecessary cast.
3072 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3073 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3074 * stabsread.c (read_type, read_array_type, read_range_type):
3075 Remove unnecessary cast.
3076 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3077 (parse_symbol, parse_type, upgrade_type, parse_external)
3078 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3079 unnecessary cast.
3080 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3081
730ead81
TT
30822019-06-16 Tom Tromey <tom@tromey.com>
3083
3084 * tui/tui-data.c (tui_alloc_generic_win_info)
3085 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3086 checks.
3087
584a927c
AB
30882019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
3089 Andrew Burgess <andrew.burgess@embecosm.com>
3090
3091 * f-typeprint.c (f_print_type): Don't return early for not
3092 associated or not allocated types.
3093 (f_type_print_varspec_suffix): Add print_rank parameter and print
3094 ranks of array types in case they dangling.
3095 (f_type_print_base): Add print_rank parameter.
3096
30056ea0
AB
30972019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3098
3099 * NEWS: Mention new MI commands.
3100 * break-catch-throw.c (enum exception_event_kind): Move to
3101 breakpoint.h.
3102 (print_mention_exception_catchpoint): Output text as a single
3103 message.
3104 (catch_exception_command_1): Rename to...
3105 (catch_exception_event): ...this, make non-static, update header
3106 command, and change some parameter types.
3107 (catch_catch_command): Update for changes to
3108 catch_exception_command_1.
3109 (catch_throw_command): Likewise.
3110 (catch_rethrow_command): Likewise.
3111 * breakpoint.c (enum exception_event_kind): Delete.
3112 * breakpoint.h (enum exception_event_kind): Moved here from
3113 break-catch-throw.c.
3114 (catch_exception_event): Declare.
3115 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3116 (mi_cmd_catch_throw): New function.
3117 (mi_cmd_catch_rethrow): New function.
3118 (mi_cmd_catch_catch): New function.
3119 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3120 'catch-catch' entries.
3121 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3122 (mi_cmd_catch_rethrow): Declare.
3123 (mi_cmd_catch_catch): Declare.
3124
ec8e2b6d
AB
31252019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3126
3127 * annotate.c (annotate_source_line): Change return type to void,
3128 update implementation to match.
3129 * annotate.h (annotate_source_line): Change return type to void,
3130 update header comment.
3131 * stack.c (print_frame_info): Don't change what frame information
3132 is printed based on whether annotations are on or not.
3133
0d3abd8c
AB
31342019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3135
3136 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3137 (annotate_source): Make static.
3138 (annotate_source_line): Moved from source.c and renamed from
3139 identify_source_line. Update the return type.
3140 * annotate.h (annotate_source): Delete declaration.
3141 (annotate_source_line): Declaration moved from source.h, and
3142 renamed from identify_source_line. Return type updated.
3143 * source.c (identify_source_line): Moved to annotate.c and renamed
3144 to annotate_source_line.
3145 (info_line_command): Remove check of annotation_level.
3146 * source.h (identify_source_line): Move declaration to annotate.h
3147 and rename to annotate_source_line.
3148 * stack.c: Add 'annotate.h' include.
3149 (print_frame_info): Remove check of annotation_level before
3150 calling annotate_source_line.
3151
00df30ae
AB
31522019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3153
3154 * source-cache.c (source_cache::get_plain_source_lines): Use
3155 open_source_file_with_line_charpos instead of just
3156 open_source_file, remove call to find_source_lines.
3157 (source_cache::get_source_lines): Likewise.
3158 * source.c (find_source_lines): Make static.
3159 (get_filename_and_charpos): Renamed into...
3160 (open_source_file_with_line_charpos): ..this along with changes to
3161 return a scoped_fd, and some other minor clean ups.
3162 (identify_source_line): Use open_source_file_with_line_charpos.
3163 (search_command_helper): Use open_source_file_with_line_charpos
3164 instead of just open_source_file, remove call to
3165 find_source_lines.
3166 * source.h (open_source_file_with_line_charpos): Declare new
3167 function.
3168 (find_source_lines): Delete declaration.
3169
afda45a2
AB
31702019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3171
3172 * source.c (get_filename_and_charpos): Remove fullname
3173 parameter.
3174 (identify_source_line): Update call to get_filename_and_charpos.
3175
0735b091
TT
31762019-06-14 Tom Tromey <tromey@adacore.com>
3177
3178 PR gdb/24502:
3179 * ui-style.h (skip_ansi_escape): Update comment.
3180 * ui-file.h (class no_terminal_escape_file): New class.
3181 * ui-file.c (no_terminal_escape_file::write)
3182 (no_terminal_escape_file::puts): New methods.
3183 * cli/cli-logging.c (handle_redirections): Use
3184 no_terminal_escape_file.
3185
52ce35e2
TT
31862019-06-14 Tom Tromey <tromey@adacore.com>
3187
3188 * NEWS: Move convenience variable news above Python news.
3189
73cc7272
TT
31902019-06-14 Tom Tromey <tom@tromey.com>
3191
3192 * gnulib: Move directory to top-level.
3193 * configure.ac: Don't configure gnulib.
3194 * configure: Rebuild.
3195 * common/common-defs.h: Use new path to gnulib.
3196 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3197 (GNULIB_H): Remove.
3198 (INCGNU): Look in new gnulib location.
3199 (HFILES_NO_SRCDIR): Remove gnulib files.
3200 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3201 (generated_files): Remove GNULIB_H.
3202 ($(LIBGNU), all-lib): Remove targets.
3203 (distclean): Don't mention GNULIB_BUILDDIR.
3204 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3205
f5686554
TT
32062019-06-14 Tom Tromey <tromey@adacore.com>
3207
3208 * symfile.c (add_symbol_file_command): Remove obsolete comment.
3209 Warn if symbol file does not provide any symbols.
3210
a0c1ffed
TT
32112019-06-14 Tom Tromey <tromey@adacore.com>
3212
3213 * source.c (find_and_open_source): Respect basenames_may_differ.
3214
7c39e397
AB
32152019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
3216
3217 * annotate.c (annotate_breakpoints_invalid): Make use of
3218 scoped_restore_terminal_state.
3219 (annotate_frames_invalid): Likewise.
3220
f411722c
TT
32212019-06-14 Tom Tromey <tromey@adacore.com>
3222
3223 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3224 allow assignment to an internalvar.
3225
4268ec18
TT
32262019-06-14 Tom Tromey <tromey@adacore.com>
3227
3228 * ada-lex.l: Allow "_" in attribute names.
3229
abdb711e
TT
32302019-06-14 Tom Tromey <tromey@adacore.com>
3231
3232 PR gdb/24653:
3233 * regcache.c (registers_changed): Don't call alloca.
3234 * top.c (execute_command): Don't call alloca.
3235
4c048731
PA
32362019-06-13 Pedro Alves <palves@redhat.com>
3237
3238 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3239 'expression'. When parsing an expression, error out if there's
3240 junk after "unlimited".
3241 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3242 (do_set_command): Adjust calls to is_unlimited_literal.
3243
66eb1ed3
PA
32442019-06-13 Pedro Alves <palves@redhat.com>
3245
3246 * compile/compile.c (make_compile_options_def_group): Add braces
3247 around array_view initializer.
3248 * thread.c (make_thread_apply_all_options_def_group)
3249 (make_thread_apply_all_options_def_group): Likewise.
3250
3345721a
PA
32512019-06-13 Pedro Alves <palves@redhat.com>
3252
3253 * NEWS (New commands): Mention "maint test-options
3254 require-delimiter", "maint test-options unknown-is-error", "maint
3255 test-options unknown-is-operand" and "maint show
3256 test-options-completion-result".
3257 (New command options, command completion): New section.
3258 (Completion improvements): New section.
3259 Mention that you can abbreviate "unlimited".
3260
6206060d
PA
32612019-06-13 Pedro Alves <palves@redhat.com>
3262
3263 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3264 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3265 * unittests/cli-utils-selftests.c (test_parse_flags)
3266 (test_parse_flags_qcs): Delete.
3267 (test_cli_utils): Don't call deleted functions.
3268
6665660a
PA
32692019-06-13 Pedro Alves <palves@redhat.com>
3270
3271 * thread.c: Include "cli/cli-option.h".
3272 (tp_array_compar_ascending): Global.
3273 (tp_array_compar): Delete function.
3274 (tp_array_compar_ascending, tp_array_compar_descending): New
3275 functions.
3276 (ascending_option_def, qcs_flag_option_def)
3277 (thr_qcs_flags_option_defs)
3278 (make_thread_apply_all_options_def_group)
3279 (make_thread_apply_options_def_group): New.
3280 (thread_apply_all_command): Use gdb::option::process_options.
3281 (thread_apply_command_completer)
3282 (thread_apply_all_command_completer): New.
3283 (thread_apply_command): Use gdb::option::process_options.
3284 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3285 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
3286 to generate help text of "thread apply". Adjust "taas"'s help.
3287 * tid-parse.c (tid_range_parser::in_thread_range): New method.
3288 * tid-parse.h (tid_range_parser::in_thread_range): New method.
3289
f7e13587
PA
32902019-06-13 Pedro Alves <palves@redhat.com>
3291
3292 * thread.c (thread_apply_command): Check for invalid TID with
3293 isdigit instead of !isalpha.
3294
5d707134
PA
32952019-06-13 Pedro Alves <palves@redhat.com>
3296
3297 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3298 (validate_flags_qcs): New.
3299 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3300 (validate_flags_qcs): Declare.
3301 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3302 (make_frame_apply_options_def_group): New.
3303 (frame_apply_command_count): Process options with
3304 gdb::option::process_options.
3305 (frame_apply_completer): New.
3306 (frame_apply_level_completer, frame_apply_all_completer)
3307 (frame_apply_completer): New.
3308 (_initialize_stack): Update help of "frame apply", "frame apply
3309 level", "frame apply all" and "faas" to mention supported options
3310 and install command completers.
3311 * stack.h (frame_apply_all_completer): Declare.
3312 * thread.c: Include "stack.h".
3313 (tfaas_command): Add "--".
3314 (_initialize_thread): Update help "tfaas" to mention supported
3315 options and install command completer.
3316
272d4594
PA
33172019-06-13 Pedro Alves <palves@redhat.com>
3318
3319 * completer.c (complete_nested_command_line): New.
3320 (gdb_completion_word_break_characters_throw): Add assertion.
3321 * completer.h (complete_nested_command_line): Declare.
3322
90a1ef87
PA
33232019-06-13 Pedro Alves <palves@redhat.com>
3324
3325 * stack.c (parse_backtrace_qualifiers): New.
3326 (backtrace_command): Use it.
3327 (backtrace_command_completer): Complete on qualifiers.
3328
d4c16835
PA
33292019-06-13 Pedro Alves <palves@redhat.com>
3330
3331 * frame.c: Include "cli/cli-option.h.
3332 (user_set_backtrace_options): New.
3333 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3334 Delete.
3335 (get_prev_frame): Adjust.
3336 (boolean_option_def, uinteger_option_def)
3337 (set_backtrace_option_defs): New.
3338 (_initialize_frame): Adjust and use
3339 gdb::option::add_setshow_cmds_for_options to install "set
3340 backtrace past-main" and "set backtrace past-entry".
3341 * frame.h: Include "cli/cli-option.h".
3342 (struct frame_print_options): Forward declare.
3343 (print_frame_arguments_all, print_frame_arguments_scalars)
3344 (print_frame_arguments_none): Declare.
3345 (print_entry_values): Delete declaration.
3346 (struct frame_print_options, user_frame_print_options): New.
3347 (struct set_backtrace_options): New.
3348 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3349 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3350 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3351 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3352 (list_args_or_locals): Add frame_print_options parameter.
3353 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3354 * python/py-framefilter.c (enumerate_args): Pass down
3355 USER_FRAME_PRINT_OPTIONS.
3356 * stack.c: Include "cli/cli-option.h".
3357 (print_frame_arguments_all, print_frame_arguments_scalars)
3358 (print_frame_arguments_none): Declare.
3359 (print_raw_frame_arguments, print_entry_values): Delete.
3360 (user_frame_print_options): New.
3361 (boolean_option_def, enum_option_def, frame_print_option_defs):
3362 New.
3363 (struct backtrace_cmd_options): New.
3364 (bt_flag_option_def): New.
3365 (backtrace_command_option_defs): New.
3366 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3367 (print_frame_arg, read_frame_arg, print_frame_args)
3368 (print_frame_info, print_frame): Add frame_print_options parameter
3369 and use it.
3370 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3371 (backtrace_command_1): Add frame_print_options and
3372 backtrace_cmd_options parameters and use them.
3373 (make_backtrace_options_def_group): New.
3374 (backtrace_command): Process command options with
3375 gdb::option::process_options.
3376 (backtrace_command_completer): New.
3377 (_initialize_stack): Extend "backtrace"'s help to mention
3378 supported options. Install completer for "backtrace".
3379 Install some settings commands with add_setshow_cmds_for_options.
3380
2daf894e
PA
33812019-06-13 Pedro Alves <palves@redhat.com>
3382
3383 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3384 and that "set/show print raw frame-arguments" are now deprecated.
3385
3386 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3387 command.
3388 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3389 * stack.c (_initialize_stack): Install "set/show print
3390 raw-frame-arguments", and deprecate "set/show print raw
3391 frame-arguments".
3392 * valprint.c (_initialize_valprint): Deprecate "set/show print
3393 raw".
3394
e6ed716c
PA
33952019-06-13 Pedro Alves <palves@redhat.com>
3396
3397 * compile/compile.c (struct compile_options): New.
3398 (compile_flag_option_def, compile_command_option_defs)
3399 (make_compile_options_def_group): New.
3400 (compile_file_command): Handle options with
3401 gdb::option::process_options.
3402 (compile_file_command_completer): New function.
3403 (compile_code_command): Handle options with
3404 gdb::option::process_options.
3405 (compile_code_command_completer): New function.
3406 (_initialize_compiler): Install completers for "compile code" and
3407 "compile file". Mention available options in "compile code" and
3408 "compile code"'s help.
3409 * completer.c (advance_to_completion_word): New, factored out from
3410 ...
3411 (advance_to_expression_complete_word_point): ... this.
3412 (advance_to_filename_complete_word_point): New.
3413 * completer.h (advance_to_filename_complete_word_point): New
3414 declaration.
3415
7d8062de
PA
34162019-06-13 Pedro Alves <palves@redhat.com>
3417
3418 * compile/compile.c: Include "cli/cli-option.h".
3419 (compile_print_value): Scope data pointer is now a
3420 value_print_options pointer; adjust.
3421 (compile_print_command): Process options. Scope data pointer is
3422 now a value_print_options pointer; adjust.
3423 (_initialize_compile): Update "compile print"'s help to include
3424 supported options. Install a completer for "compile print".
3425 * cp-valprint.c (show_vtblprint, show_objectprint)
3426 (show_static_field_print): Delete.
3427 (_initialize_cp_valprint): Don't install "set print
3428 static-members", "set print vtbl", "set print object" here.
3429 * printcmd.c: Include "cli/cli-option.h" and
3430 "common/gdb_optional.h".
3431 (print_command_parse_format): Rework to fill in a
3432 value_print_options instead of a format_data.
3433 (print_value): Change parameter type from format_data pointer to
3434 value_print_options reference. Adjust.
3435 (print_command_1): Process options. Adjust to pass down a
3436 value_print_options.
3437 (print_command_completer): New.
3438 (_initialize_printcmd): Install print_command_completer as
3439 handle_brkchars completer for the "print" command. Update
3440 "print"'s help to include supported options.
3441 * valprint.c: Include "cli/cli-option.h".
3442 (show_vtblprint, show_objectprint, show_static_field_print): Moved
3443 here from cp-valprint.c.
3444 (boolean_option_def, uinteger_option_def)
3445 (value_print_option_defs, make_value_print_options_def_group):
3446 New. Use gdb::option::add_setshow_cmds_for_options to install
3447 "set print elements", "set print null-stop", "set print repeats",
3448 "set print pretty", "set print union", "set print array", "set
3449 print address", "set print symbol", "set print array-indexes".
3450 * valprint.h: Include <string> and "cli/cli-option.h".
3451 (make_value_print_options_def_group): Declare.
3452 (print_value): Change parameter type from format_data pointer to
3453 value_print_options reference.
3454 (print_command_completer): Declare.
3455
9d0faba9
PA
34562019-06-13 Pedro Alves <palves@redhat.com>
3457
3458 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3459 (COMMON_SFILES): Add maint-test-settings.c.
3460 * cli/cli-decode.c (boolean_enums): New global, factored out from
3461 ...
3462 (add_setshow_boolean_cmd): ... here.
3463 * cli/cli-decode.h (boolean_enums): Declare.
3464 * cli/cli-option.c: New file.
3465 * cli/cli-option.h: New file.
3466 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3467 factored out from ...
3468 (parse_cli_boolean_value(const char *)): ... this.
3469 (is_unlimited_literal): Change parameter type to pointer to
3470 pointer. Adjust and advance ARG pointer.
3471 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3472 (parse_cli_var_enum): New, factored out from ...
3473 (do_set_command): ... this. Adjust.
3474 * cli/cli-setshow.h (parse_cli_boolean_value)
3475 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3476 (parse_cli_var_enum): Declare.
3477 * cli/cli-utils.c: Include "cli/cli-option.h".
3478 (get_ulongest): New.
3479 * cli/cli-utils.h (get_ulongest): Declare.
3480 (check_for_argument): New overloads.
3481 * maint-test-options.c: New file.
3482
2c722807
PA
34832019-06-13 Pedro Alves <palves@redhat.com>
3484
3485 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3486 parse a range if "-" is at the end of the string.
3487
dee7b4c8
PA
34882019-06-13 Pedro Alves <palves@redhat.com>
3489
3490 * cli/cli-setshow.c (parse_auto_binary_operation)
3491 (parse_cli_boolean_value): Don't allow "o".
3492
dca0f6c0
PA
34932019-06-13 Pedro Alves <palves@redhat.com>
3494
3495 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3496 * NEWS: Mention maint test-settings KIND.
3497 * maint-test-settings.c: New file.
3498
597bf39d
PA
34992019-06-13 Pedro Alves <palves@redhat.com>
3500
3501 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3502 completer.
3503 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3504 "set" completers.
3505
48c410fb
PA
35062019-06-13 Pedro Alves <palves@redhat.com>
3507
3508 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3509 after item.
3510
93bcb043
PA
35112019-06-13 Pedro Alves <palves@redhat.com>
3512
3513 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3514
cbba3ecd
PA
35152019-06-13 Pedro Alves <palves@redhat.com>
3516
3517 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3518 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3519 call.
3520 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3521 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3522 calls.
3523 (check_for_argument): Skip spaces after argument.
3524
b9a3f842
PA
35252019-06-13 Pedro Alves <palves@redhat.com>
3526
3527 * thread.c (thread_apply_command): Adjust TID parsing.
3528 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3529 detected before end of string.
3530 (tid_is_in_list): Error out if LIST is invalid.
3531
3844e605
PA
35322019-06-13 Pedro Alves <palves@redhat.com>
3533
3534 * completer.c (complete_line_internal_1): Rewind completion word
3535 point.
3536 (completion_tracker::advance_custom_word_point_by): Change
3537 parameter type to int.
3538 * completer.h (completion_tracker::advance_custom_word_point_by):
3539 Likewise.
3540
00b56dbe
PA
35412019-06-13 Pedro Alves <palves@redhat.com>
3542
3543 * completer.c (advance_to_completion_word): Handle delimiters.
3544
d106773e
PA
35452019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
3546
3547 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3548
08f10e02
TT
35492019-06-11 Tom Tromey <tom@tromey.com>
3550
3551 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3552 (xmalloc_failed): Move to alloc.c.
3553 * alloc.c: New file.
3554 * Makefile.in (COMMON_SFILES): Add alloc.c.
3555
1c7fe951
TT
35562019-06-11 Tom Tromey <tom@tromey.com>
3557
3558 * nat/linux-waitpid.c: Don't include server.h.
3559 (linux_debug): Remove.
3560 (my_waitpid): Update.
3561
89549d7f
TT
35622019-06-11 Tom Tromey <tromey@adacore.com>
3563
3564 * infcall.c (_initialize_infcall): Remove trailing newline from
3565 help.
3566 * user-regs.c (_initialize_user_regs): Remove trailing newline
3567 from help.
3568 * typeprint.c (_initialize_typeprint): Remove trailing newline
3569 from help.
3570 * reverse.c (_initialize_reverse): Remove trailing newlines from
3571 help.
3572 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3573 from help.
3574 * language.c (add_set_language_command): Remove trailing newline
3575 from help.
3576 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3577 help.
3578 * disasm.c (_initialize_disasm): Remove trailing newline from
3579 help.
3580 * top.c (init_main): Remove trailing newline from help.
3581 * interps.c (_initialize_interpreter): Remove trailing newline
3582 from help.
3583 * btrace.c (_initialize_btrace): Remove trailing newlines from
3584 help.
3585 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3586 from help.
3587 * python/python.c (_initialize_python): Remove trailing newline
3588 from help.
3589 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3590 help.
3591 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3592 from help. Reformat some text.
3593 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3594 from help.
3595 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3596 newline from help.
3597
86108c13
TT
35982019-06-11 Tom Tromey <tromey@adacore.com>
3599
3600 * darwin-nat.c (darwin_decode_exception_message)
3601 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3602
a7067863
AB
36032019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
3604
3605 * valops.c (value_slice): Check for not allocated or not
3606 associated values.
3607
9ab08412
TV
36082019-06-10 Tom de Vries <tdevries@suse.de>
3609
3610 PR gdb/24618
3611 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3612 sure an empty slot (defined by a 32-bit zero pair) is recognized as
3613 invalid.
3614
f19e22e9
TV
36152019-06-10 Tom de Vries <tdevries@suse.de>
3616
3617 PR gdb/24611
3618 * linespec.c (linespec_lexer_lex_string): Remove incorrect
3619 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
3620
e99f9db0
TV
36212019-06-10 Tom de Vries <tdevries@suse.de>
3622
3623 PR symtab/24545
3624 * symtab.c (struct demangled_name_entry): Add language field.
3625 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
3626 static minimal symbol". Set and use language field.
3627
9bf7038b
TT
36282019-06-10 Tom Tromey <tromey@adacore.com>
3629
3630 * ada-lang.c (_initialize_ada_language): Update help text.
3631
422186a9
TT
36322019-06-10 Tom Tromey <tromey@adacore.com>
3633
3634 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3635 with a newline.
3636 * guile/guile.c (handle_boot_error): Don't end warning with a
3637 newline.
3638 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3639 warning with a newline.
3640 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3641 newline.
3642 (s12z_frame_cache): Likewise.
3643 * dwarf-index-cache.c (index_cache::store): Don't end warning with
3644 a newline.
3645 * solib-svr4.c (disable_probes_interface): Don't end warning with
3646 a newline.
3647 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3648 newline.
3649 * python/python.c (do_finish_initialization): Don't end warning
3650 with a newline.
3651
25ce02ee
TT
36522019-06-10 Tom Tromey <tom@tromey.com>
3653
3654 * python/py-breakpoint.c (gdbpy_breakpoint_created)
3655 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3656 gdbpy_enter.
3657
caa429d8
TT
36582019-06-10 Tom Tromey <tromey@adacore.com>
3659
3660 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3661 data.
3662 (elf_new_init): Don't call stabsread_new_init.
3663 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3664 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
3665 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3666
81873cc8
TV
36672019-06-10 Tom de Vries <tdevries@suse.de>
3668
3669 PR symtab/16264
3670 PR symtab/24517
3671 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3672
4fa0265e
РИ
36732019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
3674
3675 * source.c (find_and_open_source): Also rewrite relative file
3676 names.
3677
1a3da2cd
AB
36782019-04-26 Amos Bird <amosbird@gmail.com>
3679
3680 * annotate.c (annotate_thread_exited): Add "thread-exited"
3681 annotation.
3682
3847a7bf
TT
36832019-06-06 Tom Tromey <tromey@adacore.com>
3684
3685 * maint.h (class scoped_command_stats): Use
3686 DISABLE_COPY_AND_ASSIGN.
3687 <print_time>: New method.
3688 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3689 print_time.
3690 (scoped_command_stats::print_time): New method.
3691
312617a3
AB
36922019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
3693
3694 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3695 instructions of lengths 6 or 8 bytes.
3696
b02f78f9
PA
36972019-06-04 Pedro Alves <palves@redhat.com>
3698
3699 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3700
3701 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3702 * breakpoint.c (condition_completer): Likewise.
3703 * cli/cli-dump.c (scan_expression): Likewise.
3704 * common/filestuff.c (mkdir_recursive): Likewise.
3705 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3706 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3707 (gdb_abspath): Likewise.
3708 * compile/compile-cplus-types.c
3709 (compile_cplus_instance::decl_name): Likewise.
3710 * completer.c (complete_explicit_location):
3711 (signal_completer, reg_or_group_completer_1): Likewise.
3712 * cp-support.c (cp_remove_params_if_any): Likewise.
3713 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3714 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3715 * infcmd.c (strip_bg_char): Likewise.
3716 * linespec.c (copy_token_string): Likewise.
3717 * mi/mi-main.c (output_cores): Likewise.
3718 * psymtab.c (psymtab_search_name):
3719 * symfile.c (test_set_ext_lang_command): Likewise.
3720 * target.c (target_fileio_read_stralloc): Likewise.
3721 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3722 * value.c (complete_internalvar): Likewise.
3723
e1f2e1a2
CB
37242019-06-04 Christian Biesinger <cbiesinger@google.com>
3725
3726 Add objfile property to gdb.Type.
d3238f7d
PA
3727 * NEWS: Mention Python API addition.
3728 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 3729
e664d728
PW
37302019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3731
3732 * NEWS: Mention the new set|show style [title|highlight].
3733 Mention changes to "show style", "help" and "apropos".
3734
66d8c862
PW
37352019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3736
3737 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3738 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
3739 instead of print_help_for_command.
3740 (print_doc_of_command): New function.
3741 (help_list): Add 'apropos -v word' suggestion.
3742 (print_help_for_command): Style the command name using title style.
3743 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3744 (_initialize_cli_cmds): Describe -v in apropos_command help.
3745
9303eb2f
PW
37462019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3747
3748 * cli/cli-style.h (cli_style_option): Add name in constructor,
3749 add m_name class member, add constructor with intensity,
3750 add name class function.
3751 (cli_style_option::add_setshow_commands): Remove name argument.
3752 (highlight_style, title_style): New styles.
3753 * cli/cli-style.c (do_show): New function that shows a style
3754 characteristic styling the style name with itself.
3755 (set_style_name): New function.
3756 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3757 Update all callers according to the changes in cli/cli-style.h.
3758 * utils.h (fputs_highlighted): New function.
3759 * utils.c (fputs_highlighted): Likewise.
3760
e2c52041
PW
37612019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3762
3763 * NEWS: Mention new pipe command and new convenience variables.
3764
947d3946
PW
37652019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3766
3767 * cli/cli-cmds.c (pipe_command): New function.
3768 (_initialize_cli_cmds): Call add_com for pipe_command.
3769 Define | as an alias for pipe.
3770 (exit_status_set_internal_vars): New function.
3771 (shell_escape): Call exit_status_set_internal_vars.
3772 cli/cli-decode.c (find_command_name_length): Recognize | as
3773 a single character command.
3774
b8fd0918
PW
37752019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3776
3777 * gdbcmd.h (execute_command_to_ui_file): New declaration.
3778 top.c (execute_command_to_ui_file): New function, mostly a copy
3779 of execute_command_to_string.
3780 (execute_command_to_string): Implement by calling
3781 execute_command_to_ui_file.
3782
68bb5386
PW
37832019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3784
3785 * top.h (saved_command_line): Remove declaration.
3786 * top.c (previous_saved_command_line, previous_repeat_arguments):
3787 New variables.
3788 (saved_command_line): Make static, define together with other
3789 'repeat variables'.
3790 (dont_repeat): Clear repeat_arguments.
3791 (repeat_previous, get_saved_command_line, save_command_line):
3792 New functions.
3793 (gdb_init): Initialize saved_command_line
3794 and previous_saved_command_line.
3795 * main.c (captured_main_1): Remove saved_command_line initialization.
3796 * event-top.c (handle_line_of_input): Update to use
3797 the new 'repeat' related functions instead of direct access to
3798 saved_command_line.
3799 * command.h (repeat_previous, get_saved_command_line,
3800 save_command_line): New declarations.
3801 (dont_repeat): Add comment.
3802
bfcdb852
TT
38032019-05-30 Tom Tromey <tromey@adacore.com>
3804
3805 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3806 Fix comment.
3807 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3808
0ef209f2
JV
38092019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
3810
3811 PR cli/24587
3812 * completer.c (complete): Initialize variable word.
3813
955b06fa
SDJ
38142019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
3815
3816 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3817 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3818 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3819 'body' is NULL to the outter 'if', protecting the '!is_define'
3820 situation as well.
3821
fa9c3fa0
TT
38222019-05-29 Tom Tromey <tromey@adacore.com>
3823
3824 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3825 (dwarf_unknown): New function.
3826 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3827 (dwarf_type_encoding_name): Use dwarf_unknown.
3828
4330d61d
TT
38292019-05-29 Tom Tromey <tromey@adacore.com>
3830
3831 PR c++/20020:
3832 * cp-valprint.c (cp_print_value_fields): Call
3833 cp_print_static_field inside "try".
3834
33a6bc35
TT
38352019-05-29 Tom Tromey <tromey@adacore.com>
3836
3837 * inflow.c (struct terminal_info): Add default operator=.
3838 * configure: Rebuild.
3839 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3840 -Wdeprecated-copy-dtor, -Wredundant-move.
3841
000439d5
TT
38422019-05-29 Tom Tromey <tromey@adacore.com>
3843
3844 * NEWS: Add entry.
3845 * infcmd.c (print_return_value_1): Handle finish_print
3846 option.
3847 (show_print_finish): New function.
3848 (_initialize_infcmd): Add "set/show print finish" commands.
3849 * valprint.c (user_print_options): Initialize new member.
3850 * valprint.h (struct value_print_options) <finish_print>: New
3851 member.
3852
c0e70c62
TT
38532019-05-28 Tom Tromey <tromey@adacore.com>
3854
3855 * ada-lang.c (ada_remove_Xbn_suffix)
3856 (find_old_style_renaming_symbol)
3857 (parse_old_style_renaming): Remove.
3858 (ada_find_renaming_symbol): Don't call
3859 find_old_style_renaming_symbol.
3860 (ada_is_renaming_symbol): Rename from
3861 ada_find_renaming_symbol. Remove "block" parameter. Return
3862 bool. Now static.
3863 (ada_read_var_value): Update and simplify.
3864 * ada-exp.y (write_var_or_type): Remove old code.
3865
766f8836
AH
38662019-05-28 Alan Hayward <alan.hayward@arm.com>
3867
3868 * event-top.c: Remove include comment.
3869 * inflow.c (class scoped_ignore_sigttou): Move from here...
3870 * inflow.h (class scoped_ignore_sigttou): ...to here.
3871 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3872 * top.c: Remove include comment.
3873
eb41253a
TT
38742019-05-27 Tom Tromey <tom@tromey.com>
3875
3876 * NEWS: Fix typo.
3877
4ca51187
TT
38782019-05-22 Tom Tromey <tromey@adacore.com>
3879
3880 * target.c (target_follow_exec): Constify parameter.
3881 * target-delegates.c: Rebuild.
3882 * remote.c (remote_target::follow_exec): Constify parameter.
3883 * infrun.c (follow_exec): Constify parameter.
3884 * target.h (struct target_ops) <follow_exec>: Constify parameter.
3885 (target_follow_exec): Likewise.
3886
8fca4da0
AH
38872019-05-22 Alan Hayward <alan.hayward@arm.com>
3888
3889 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3890 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3891
b7060614
AH
38922019-05-22 Alan Hayward <alan.hayward@arm.com>
3893
3894 * NEWS: Add debugredirect and testsuite sections.
3895
0a5954bd
SC
38962019-05-22 Simon Cook <simon.cook@embecosm.com>
3897
3898 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3899 target descriptions using exclusively floating point register name
3900 aliases.
3901
dc42e902
AB
39022019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
3903
3904 PR gdb/18644:
3905 * f-lang.c (build_fortran_types): Handle the case where
3906 gdbarch_floatformat_for_type returns a nullptr.
3907
fb7806c7
TV
39082019-05-21 Tom de Vries <tdevries@suse.de>
3909
3910 PR cli/24587
3911 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3912
34d11c68
AB
39132019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
3914
3915 PR gdb/18644:
3916 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3917 16-byte floats.
3918 * i386-tdep.c (i386_floatformat_for_type): Use
3919 floatformats_ia64_quad for the 16-byte floating point component
3920 within a fortran 32-byte complex number.
3921
122cf0f2
AB
39222019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
3923
3924 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3925 delete default constructor.
3926 (find_partial_die): Update to return const struct.
3927 (partial_die_parent_scope): Move variable declaration into scope
3928 of its use and change its type to auto.
3929 (guess_partial_die_structure_name): Likewise.
3930 (partial_die_info::fixup): Likewise.
3931
33d0e35a
TT
39322019-05-17 Tom Tromey <tromey@adacore.com>
3933
3934 * source.c (find_and_open_source): Remove cast.
3935
a45575b0
TT
39362019-05-17 Tom Tromey <tromey@adacore.com>
3937
3938 * annotate.c (annotate_source): Make "filename" const.
3939 * annotate.h (annotate_source): Use const.
3940
81f47ac2
AH
39412019-05-17 Alan Hayward <alan.hayward@arm.com>
3942
3943 * disasm.c (set_disassembler_options): Send errors to stderr.
3944
ca1285d1
AH
39452019-05-17 Alan Hayward <alan.hayward@arm.com>
3946
3947 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3948 (cli_interp_base::set_logging): Check debug_redirect.
3949 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3950 * cli/cli-logging.c (debug_redirect): Add static variable.
3951 (pop_output_files): Add default param.
3952 (handle_redirections): Print debug setting.
3953 (show_logging_command): Likewise.
3954 (_initialize_cli_logging): Add debugredirect command.
3955 * interps.c (current_interp_set_logging): Add debug_redirect
3956 parameter.
3957 * interps.h (set_logging): Add debug_redirect parameter.
3958 (current_interp_set_logging): Likewise.
3959 * mi/mi-common.h: Likewise.
3960 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3961
39622019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
3963 Tom Tromey <tromey@adacore.com>
3964
3965 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3966 directly.
3967 * cli/cli-interp.h (make_logging_output): Remove declaration.
3968 * cli/cli-logging.c (make_logging_output): Remove function.
3969 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3970 directly.
3971 * ui-file.c (tee_file::tee_file): Remove bools.
3972 (tee_file::~tee_file): Remove deletes.
3973 * ui-file.h (tee_file): Remove bools.
3974
26648588
JV
39752019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
3976
3977 * mi/mi-cmds.h (mi_cmd_complete): New function.
3978 * mi/mi-main.c (mi_cmd_complete): Likewise.
3979 * mi/mi-cmds.c: Define new MI command -complete.
3980 * NEWS: Mention new -complete command.
3981
6e035501
JV
39822019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
3983
3984 * completer.h (complete): New function.
3985 * completer.c (complete): Likewise.
3986 * cli/cli-cmds.c: (complete_command): Update to use new complete()
3987 function defined in completer.h.
3988
7d0e2ece
JV
39892019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
3990
e79be6e5 3991 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 3992
fb816e8b
TV
39932019-05-17 Tom de Vries <tdevries@suse.de>
3994
3995 PR gdb/24094
3996 * dwarf2read.c (struct cu_partial_die_info): New struct.
3997 (find_partial_die): Return cu_partial_die_info.
3998 (partial_die_parent_scope, guess_partial_die_structure_name)
3999 (partial_die_info::fixup): Handle new return type of find_partial_die.
4000
677052f2
SDJ
40012019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4002
4003 * stap-probe.c (stap_parse_register_operand): Make "regname" an
4004 "std::string", simplifying the algorithm.
4005
f3da9116
SDJ
40062019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4007
4008 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4009 (stap_static_probe_ops::get_probes): Likewise.
4010
f1bb75ab
SDJ
40112019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4012
4013 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4014 '-')" and "else if".
4015 (stap_parse_single_operand): Join checks for
4016 "gdbarch_stap_parse_special_token_p" and
4017 "gdbarch_stap_parse_special_token" in the same "if" statement.
4018 Invert check when verifying for operation on register
4019 displacement.
4020
3ca58cde
SDJ
40212019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4022
4023 * stap-probe.c (stap_get_opcode): Update comment.
4024 (stap_get_expected_argument_type): Likewise.
4025 (handle_stap_probe): Likewise.
4026
af2d9bee
SDJ
40272019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4028
4029 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4030 return type to 'bool'. Adjust comment. Use 'bool' when
4031 appropriate.
4032 (i386_stap_parse_special_token_three_arg_disp): Likewise.
4033 * stap-probe.c (stap_parse_argument_1): Likewise.
4034 (stap_is_operator): Likewise.
4035 (stap_is_generic_prefix): Likewise.
4036 (stap_is_register_prefix): Likewise.
4037 (stap_is_register_indirection_prefix): Likewise.
4038 (stap_is_integer_prefix): Likewise.
4039 (stap_generic_check_suffix): Likewise.
4040 (stap_check_integer_suffix): Likewise.
4041 (stap_check_register_suffix): Likewise.
4042 (stap_check_register_indirection_suffix): Likewise.
4043 (stap_parse_register_operand): Likewise.
4044 (stap_parse_single_operand): Likewise.
4045 (stap_parse_argument_1): Likewise.
4046 (stap_probe::get_argument_count): Likewise.
4047 (stap_is_operator): Likewise.
4048
61c9c421
TT
40492019-05-16 Tom Tromey <tromey@adacore.com>
4050
4051 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4052 keyword to foreach.
4053
9ddc1af1
SM
40542019-05-15 Simon Marchi <simon.marchi@efficios.com>
4055
4056 * linux-thread-db.c (try_thread_db_load_1): Change return type
4057 to bool.
4058 (try_thread_db_load): Likewise.
4059 (try_thread_db_load_from_pdir_1): Likewise.
4060 (try_thread_db_load_from_pdir): Likewise.
4061 (try_thread_db_load_from_sdir): Likewise.
4062 (try_thread_db_load_from_dir): Likewise.
4063 (thread_db_load_search): Likewise.
4064 (has_libpthread): Likewise.
4065 (thread_db_load): Likewise.
4066
7bede828
SDJ
40672019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
4068
4069 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4070 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4071 NULL, and complain/return if that's the case.
4072
c5358db4
JD
40732019-05-15 John Darrington <john@darrington.wattle.id.au>
4074
4075 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4076 (advance, posn, abstract_read_memory): New functions.
4077 [struct mem_read_abstraction]: New struct.
4078 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4079
c408a94f
TT
40802019-05-14 Tom Tromey <tromey@adacore.com>
4081
4082 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4083 value is not lval_memory.
4084
e7bd7fba
TT
40852019-05-14 Tom Tromey <tromey@adacore.com>
4086
4087 * solib.c (info_sharedlibrary_command): Style the file name.
4088
a6d0f249
AH
40892019-05-14 Alan Hayward <alan.hayward@arm.com>
4090
4091 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4092 (aarch64_vnv_type): Likewise.
4093 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4094 * common/tdesc.c: Likewise.
4095 * common/tdesc.h (enum tdesc_type_kind): Likewise.
4096 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4097 * features/aarch64-fpu.xml: Add ieee half view.
4098 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4099 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4100 * gdbtypes.h (struct builtin_type): Likewise.
4101 (struct objfile_type): Likewise.
4102
66b8bb74
SM
41032019-05-12 Paul Naert <paul.naert@polymtl.ca>
4104
4105 * language.c (language_sniff_from_mangled_name): Fix "langauge"
4106 typo.
4107 * location.h (string_to_event_location): Likewise.
4108
21c219fd
JB
41092019-05-11 Joel Brobecker <brobecker@adacore.com>
4110
4111 GDB 8.3 released.
4112
13674803
SM
41132019-05-10 Simon Marchi <simon.marchi@efficios.com>
4114
4115 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4116 New variable declaration.
4117 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4118 New variable.
4119 (print_one_breakpoint): Use ui_out::test_flags and new global
4120 variable to compute use_fixed_output.
4121 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4122 Remove.
4123 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4124 (mi_multi_location_breakpoint_output_fixed): Remove.
4125 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4126 new variable.
4127 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4128 fix_multi_location_breakpoint_output flag if version >= 3.
4129 * ui-out.h (enum ui_out_flag)
4130 <fix_multi_location_breakpoint_output>: New enumerator.
4131
a9eac7f9
SM
41322019-05-10 Simon Marchi <simon.marchi@efficios.com>
4133
4134 * contrib/cc-with-tweaks.sh: Validate dwz's work.
4135
71bed2db
TT
41362019-05-10 Tom Tromey <tromey@adacore.com>
4137
4138 * ada-lang.c (catch_ada_completer): New function.
4139 (_initialize_ada_language): Use it.
4140
24c54127
TT
41412019-05-10 Tom Tromey <tromey@adacore.com>
4142
4143 * thread.c (print_thread_info): Make "requested_threads" const.
4144 * gdbthread.h (print_thread_info): Make "requested_threads"
4145 const.
4146 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4147 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4148
7a102139
TT
41492019-05-08 Tom Tromey <tom@tromey.com>
4150
4151 * gdbtypes.c (objfile_type_data): Change type.
4152 (objfile_type, _initialize_gdbtypes): Update.
4153
924d79e2
TT
41542019-05-08 Tom Tromey <tom@tromey.com>
4155
4156 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4157 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4158 (_initialize_dwarf2_frame): Update.
4159
4c58e337
TT
41602019-05-08 Tom Tromey <tom@tromey.com>
4161
4162 * objc-lang.c (objc_objfile_data): Change type.
4163 (find_methods): Update.
4164 (_initialize_objc_lang): Remove.
4165
d772d2ab
TT
41662019-05-08 Tom Tromey <tom@tromey.com>
4167
4168 * stabsread.c (rs6000_builtin_type_data): Change type.
4169 (rs6000_builtin_type, _initialize_stabsread): Update.
4170
d11d83f4
TT
41712019-05-08 Tom Tromey <tom@tromey.com>
4172
4173 * mips-tdep.c (mips_pdr_data): Remove.
4174 (_initialize_mips_tdep): Update.
4175
9a73f0ad
TT
41762019-05-08 Tom Tromey <tom@tromey.com>
4177
4178 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4179 (hppa_init_objfile_priv_data, read_unwind_info)
4180 (find_unwind_entry, _initialize_hppa_tdep): Update.
4181
8127a2fa
TT
41822019-05-08 Tom Tromey <tom@tromey.com>
4183
4184 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4185 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
4186 on obstack.
4187 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4188
91d3055d
TT
41892019-05-08 Tom Tromey <tom@tromey.com>
4190
4191 * mdebugread.c (basic_type_data): Change type.
4192 (basic_type, _initialize_mdebugread): Update.
4193
31930bd3
TT
41942019-05-08 Tom Tromey <tom@tromey.com>
4195
4196 * common/gdb_unique_ptr.h (struct noop_deleter): New.
4197
bdb3ed9e
TT
41982019-05-08 Tom Tromey <tom@tromey.com>
4199
4200 * nto-tdep.c (nto_inferior_data_reg): Change type.
4201 (nto_inferior_data): Update.
4202 (nto_inferior_data_cleanup, nto_new_inferior_data)
4203 (_initialize_nto_tdep): Remove.
4204 * nto-tdep.h (struct nto_inferior_data): Add initializers.
4205
f37b313d
TT
42062019-05-08 Tom Tromey <tom@tromey.com>
4207
4208 * ada-lang.c (struct ada_inferior_data): Add initializers.
4209 (ada_inferior_data): Change type.
4210 (ada_inferior_data_cleanup): Remove.
4211 (get_ada_inferior_data, ada_inferior_exit)
4212 (struct ada_pspace_data): Add initializers, destructor.
4213 (ada_pspace_data_handle): Change type.
4214 (get_ada_pspace_data): Update.
4215 (ada_pspace_data_cleanup): Remove.
4216
24699405
TT
42172019-05-08 Tom Tromey <tom@tromey.com>
4218
4219 * coffread.c (struct coff_symfile_info): Add initializers.
4220 (coff_objfile_data_key): Move lower. Change type.
4221 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4222 Update.
4223 (coff_free_info): Remove.
4224
d4e05d2f
TT
42252019-05-08 Tom Tromey <tom@tromey.com>
4226
4227 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4228 (fbsd_pspace_data_handle): Move lower. Change type.
4229 (get_fbsd_pspace_data): Update.
4230 (fbsd_pspace_data_cleanup): Remove.
4231 (_initialize_fbsd_tdep): Update.
4232
14ef6690
TT
42332019-05-08 Tom Tromey <tom@tromey.com>
4234
4235 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4236 (get_ada_tasks_pspace_data): Update.
4237 (ada_tasks_pspace_data_cleanup): Remove.
4238 (_initialize_tasks): Update.
4239 (ada_tasks_inferior_data_handle): Change type.
4240 (get_ada_tasks_inferior_data): Update.
4241 (ada_tasks_inferior_data_cleanup): Remove.
4242 (struct ada_tasks_pspace_data): Add initializers.
4243
814cf43a
TT
42442019-05-08 Tom Tromey <tom@tromey.com>
4245
4246 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4247 * symfile-debug.c (debug_sym_get_probes): Change type.
4248 * stap-probe.c (handle_stap_probe):
4249 (stap_static_probe_ops::get_probes): Change type.
4250 * probe.h (class static_probe_ops) <get_probes>: Change type.
4251 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4252 (parse_probes_in_pspace): Update.
4253 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4254 Update.
4255 (any_static_probe_ops::get_probes): Change type.
4256 * elfread.c (elfread_data): New typedef.
4257 (probe_key): Change type.
4258 (elf_get_probes): Likewise. Update.
4259 (probe_key_free): Remove.
4260 (_initialize_elfread): Update.
4261 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4262 Change type.
4263 (dtrace_process_dof_probe, dtrace_process_dof)
4264 (dtrace_static_probe_ops::get_probe): Change type.
4265
02dc647e
TT
42662019-05-08 Tom Tromey <tom@tromey.com>
4267
4268 * xcoffread.c (struct xcoff_symfile_info): Rename from
4269 coff_symfile_info. Add initializers.
4270 (xcoff_objfile_data_key): Move lower. Change type.
4271 (XCOFF_DATA): Rewrite.
4272 (xcoff_free_info): Remove.
4273 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4274 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4275 (xcoff_initial_scan): Update.
4276
09232438
TT
42772019-05-08 Tom Tromey <tom@tromey.com>
4278
4279 * solib-svr4.c (struct svr4_info): Add initializers and
4280 destructor.
4281 <probes_table>: Now an htab_up.
4282 (solib_svr4_pspace_data): Change type.
4283 (free_probes_table): Simplify.
4284 (~svr4_info): Rename from svr4_pspace_data_cleanup.
4285 (get_svr4_info, probes_table_htab_remove_objfile_probes)
4286 (probes_table_remove_objfile_probes, register_solib_event_probe)
4287 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4288 (_initialize_svr4_solib): Update.
4289
7b4a314f
TT
42902019-05-08 Tom Tromey <tom@tromey.com>
4291
4292 * remote.c (remote_pspace_data): Change type.
4293 (remote_pspace_data_cleanup): Remove.
4294 (get_remote_exec_file, set_pspace_remote_exec_file)
4295 (_initialize_remote): Update.
4296
51d3063a
TT
42972019-05-08 Tom Tromey <tom@tromey.com>
4298
4299 * breakpoint.c (breakpoint_objfile_key): Change type.
4300 (get_breakpoint_objfile_data): Update.
4301 (free_breakpoint_objfile_data): Remove.
4302 (_initialize_breakpoint): Update.
4303
89fb8848
TT
43042019-05-08 Tom Tromey <tom@tromey.com>
4305
4306 * linux-tdep.c (struct linux_info): Add initializers.
4307 (linux_inferior_data): Move. Change type.
4308 (invalidate_linux_cache_inf): Update.
4309 (linux_inferior_data_cleanup): Remove.
4310 (get_linux_inferior_data, _initialize_linux_tdep): Update.
4311
e9b89e2d
TT
43122019-05-08 Tom Tromey <tom@tromey.com>
4313
4314 * auxv.c (auxv_inferior_data): Move. Change type.
4315 (auxv_inferior_data_cleanup): Remove.
4316 (invalidate_auxv_cache_inf): Rewrite.
4317 (get_auxv_inferior_data, _initialize_auxv): Update.
4318
8c42777c
TT
43192019-05-08 Tom Tromey <tom@tromey.com>
4320
4321 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4322 (symfile_debug_objfile_data_key): Change type.
4323 (symfile_debug_installed, debug_qf_has_symbols)
4324 (debug_qf_find_last_source_symtab)
4325 (debug_qf_forget_cached_source_info)
4326 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4327 (debug_qf_print_stats, debug_qf_dump)
4328 (debug_qf_expand_symtabs_for_function)
4329 (debug_qf_expand_all_symtabs)
4330 (debug_qf_expand_symtabs_with_fullname)
4331 (debug_qf_map_matching_symbols)
4332 (debug_qf_expand_symtabs_matching)
4333 (debug_qf_find_pc_sect_compunit_symtab)
4334 (debug_qf_map_symbol_filenames)
4335 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4336 (debug_sym_new_init, debug_sym_init, debug_sym_read)
4337 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4338 (debug_sym_read_linetable, debug_sym_relocate): Update.
4339 (symfile_debug_free_objfile): Remove.
4340 (install_symfile_debug_logging, _initialize_symfile_debug):
4341 Update.
4342
5bfd760d
TT
43432019-05-08 Tom Tromey <tom@tromey.com>
4344
4345 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4346 allocate_on_obstack.
4347 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4348 (get_dwarf2_per_objfile): Update.
4349 (set_dwarf2_per_objfile): Remove.
4350 (dwarf2_has_info, dwarf2_get_section_info): Update.
4351 (dwarf2_free_objfile): Remove.
4352 (_initialize_dwarf2_read): Update.
4353
e85e19b4
TT
43542019-05-08 Tom Tromey <tom@tromey.com>
4355
4356 * auto-load.c (struct auto_load_pspace_info): Add destructor and
4357 initializers.
4358 <unsupported_script_warning_printed,
4359 script_not_found_warning_printed>: Now bool.
4360 (auto_load_pspace_data): Change type.
4361 (~auto_load_pspace_info): Rename from
4362 auto_load_pspace_data_cleanup.
4363 (get_auto_load_pspace_data, init_loaded_scripts_info)
4364 (clear_section_scripts, maybe_print_unsupported_script_warning)
4365 (maybe_print_script_not_found_warning, _initialize_auto_load):
4366 Update.
4367
f6aa7436
TT
43682019-05-08 Tom Tromey <tom@tromey.com>
4369
4370 * objfiles.c (objfile_pspace_info): Add destructor and
4371 initializers.
4372 (objfiles_pspace_data): Change type.
4373 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4374 (get_objfile_pspace_data): Update.
4375 (objfiles_bfd_data): Change type.
4376 (get_objfile_bfd_data): Update.
4377 (objfile_bfd_data_free, _initialize_objfiles): Remove.
4378
6ae614f6
TT
43792019-05-08 Tom Tromey <tom@tromey.com>
4380
4381 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4382 Change type.
4383 (get_catch_syscall_inferior_data): Update.
4384 (catch_syscall_inferior_data_cleanup): Remove.
4385 (_initialize_break_catch_syscall): Update.
4386
6509b8eb
TT
43872019-05-08 Tom Tromey <tom@tromey.com>
4388
4389 * inflow.c (struct terminal_info): Add destructor and
4390 initializers.
4391 (inflow_inferior_data): Change type.
4392 (~terminal_info): Rename from inflow_inferior_data_cleanup.
4393 (get_inflow_inferior_data, inflow_inferior_exit)
4394 (swap_terminal_info, _initialize_inflow): Update.
4395
35632941
TT
43962019-05-08 Tom Tromey <tom@tromey.com>
4397
4398 * target-dcache.c (target_dcache_cleanup): Remove.
4399 (target_dcache_aspace_key): Change type.
4400 (target_dcache_init_p, target_dcache_invalidate)
4401 (target_dcache_get, target_dcache_get_or_init)
4402 (_initialize_target_dcache): Update.
4403 * dcache.h (struct dcache_deleter): New.
4404
3017b94d
TT
44052019-05-08 Tom Tromey <tom@tromey.com>
4406
4407 * symtab.c (struct symbol_cache): Add destructor and
4408 initializers.
4409 (symbol_cache_key): Move. Change type.
4410 (make_symbol_cache, free_symbol_cache): Remove.
4411 (get_symbol_cache): Update.
4412 (symbol_cache_cleanup): Remove.
4413 (ALL_PSPACES, symbol_cache_flush)
4414 (maintenance_print_symbol_cache)
4415 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4416 Update.
4417
a32ad8c5
TT
44182019-05-08 Tom Tromey <tom@tromey.com>
4419
4420 * symtab.c (struct main_info): Add destructor and initializers.
4421 (main_progspace_key): Move. Change type.
4422 (get_main_info): Update.
4423 (main_info_cleanup): Remove.
4424 (_initialize_symtab): Update.
4425
5f6e90a0
TT
44262019-05-08 Tom Tromey <tom@tromey.com>
4427
4428 * registry.h (DECLARE_REGISTRY): Define the _key class.
4429
1bd0c6e4
AB
44302019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
4431
4432 * NEWS: Merge two 'New commands' sections.
4433
2228ef77
XR
44342019-05-08 Joel Brobecker <brobecker@adacore.com>
4435
4436 * ada-valprint.c (ada_val_print_gnat_array): Remove language
4437 parameter and use Ada language definition instead.
4438 (ada_val_print_ptr): Remove unused language parameter.
4439 (ada_val_print_num): Remove language parameter and use Ada language
4440 definition instead.
4441 (ada_val_print_enum, ada_val_print_flt): Remove unused language
4442 parameter.
4443 (ada_val_print_struct_union, ada_val_print_ref): Remove language
4444 parameter and use Ada language definition instead.
4445 (ada_val_print_1): Update all ada_val_print_xxx calls.
4446 Remove language parameter.
4447 (ada_val_print): Update ada_val_print_1 call.
4448
60fcc1c3
TT
44492019-05-08 Tom Tromey <tromey@adacore.com>
4450
4451 * remote.c (remote_hw_watchpoint_limit)
4452 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4453 Now static.
4454
ed2b7c17
TT
44552019-05-08 Tom Tromey <tromey@adacore.com>
4456
4457 * maint.c (_initialize_maint_cmds): Move initialization code to
4458 remote.c.
4459 (watchdog, show_watchdog): Move to remote.c.
4460 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
4461 "watchdog" static.
4462 (_initialize_remote): Move initialization code from maint.c.
4463 * defs.h (watchdog): Don't declare.
4464
b0be6c91
TT
44652019-05-08 Tom Tromey <tromey@adacore.com>
4466
4467 * tui/tui-interp.c: Include main.h.
4468 * interps.c: Include main.h.
4469 * main.h (interpreter_p): Declare.
4470 * defs.h (interpreter_p): Don't declare.
4471
587ee17b
TT
44722019-05-08 Tom Tromey <tromey@adacore.com>
4473
4474 * dwarf2loc.c: Include dwarf2read.h.
4475 * defs.h (read_unsigned_leb128): Don't declare.
4476 * dwarf2read.h (read_unsigned_leb128): Declare.
4477
ca1df239
TT
44782019-05-08 Tom Tromey <tromey@adacore.com>
4479
4480 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4481 method.
4482
99f20f08
TT
44832019-05-08 Tom Tromey <tromey@adacore.com>
4484
4485 * utils.c (fputs_maybe_filtered): Reset style after paging, even
4486 when no wrap column is set.
4487
80e55b13
TT
44882019-05-08 Tom Tromey <tromey@adacore.com>
4489
4490 * c-lang.c (c_get_string): Handle non-C-style arrays.
4491
9d3421af
TT
44922019-05-08 Tom Tromey <tromey@adacore.com>
4493
4494 * typeprint.c (print_offset_data::update): Print the bit offset,
4495 not the number of bits remaining.
4496
844333e2
TT
44972019-05-08 Tom Tromey <tromey@adacore.com>
4498
4499 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4500 padding at end of comment.
4501
988915ee
TT
45022019-05-08 Tom Tromey <tromey@adacore.com>
4503
4504 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4505 Compare main types.
4506
26bfd823
TT
45072019-05-06 Tom Tromey <tom@tromey.com>
4508
4509 * common/scoped_mmap.c: Include common-defs.h.
4510 * common/scoped_mmap.h: Don't include config.h.
4511
89055eaa
TT
45122019-05-04 Tom Tromey <tom@tromey.com>
4513
4514 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4515 (struct aarch64_call_info): Add initializers.
4516 <si>: Now a std::vector.
4517 (pass_on_stack, aarch64_push_dummy_call): Update.
4518
5da01df5
TT
45192019-05-04 Simon Marchi <simon.marchi@efficios.com>
4520 Tom Tromey <tom@tromey.com>
4521
4522 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4523 (ppc_threads): Now a std::vector. Now static.
4524 (hwdebug_find_thread_points_by_tid)
4525 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4526 Update.
4527
fbdf05a1
TT
45282019-05-04 Tom Tromey <tom@tromey.com>
4529
4530 * arc-tdep.c (arc_tdesc_init): Return bool.
4531
06d16ec9
TT
45322019-05-04 Tom Tromey <tom@tromey.com>
4533
4534 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4535 Use gdb_assert_not_reached.
4536
9c056022
TT
45372019-05-04 Tom Tromey <tom@tromey.com>
4538
4539 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4540 "false".
4541
fa9c2a59
TT
45422019-05-04 Tom Tromey <tom@tromey.com>
4543
4544 * arc-tdep.c (arc_tdesc_init): Use bool.
4545
e2eb806a
TT
45462019-05-04 Tom Tromey <tom@tromey.com>
4547
4548 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4549
6fe87677
TT
45502019-05-04 Tom Tromey <tom@tromey.com>
4551
4552 * cli/cli-cmds.c (valid_command_p): Return bool.
4553
7f008c9e
TT
45542019-05-04 Tom Tromey <tom@tromey.com>
4555
4556 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4557 * command.h (valid_user_defined_cmd_name_p): Channge return type.
4558
b6484282
RT
45592019-05-04 Raul Tambre <raul@tambre.ee>
4560
4561 * python/lib/gdb/prompt.py (_ExtendedPrompt)
4562 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4563 operator for comparison.
4564
af97b416
TT
45652019-05-04 Tom Tromey <tom@tromey.com>
4566
4567 * psymtab.c (psymbol_name_matches, match_partial_symbol)
4568 (lookup_partial_symbol, print_partial_symbols)
4569 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4570 (psymbol_compare): Update.
4571 (add_psymbol_to_bcache): Clear the entire psymbol.
4572 (maintenance_check_psymtabs): Update.
4573 * psympriv.h (struct partial_symbol): Don't derive from
4574 general_symbol_info.
4575 <obj_section, unrelocated_address, address,
4576 set_unrelocated_address>: Update.
4577 <ginfo>: New member.
4578 * dwarf-index-write.c (write_psymbols, debug_names::insert)
4579 (debug_names::write_psymbols): Update.
4580
9d6d4be8
TV
45812019-05-04 Tom de Vries <tdevries@suse.de>
4582
4583 * contrib/cc-with-tweaks.sh: Support -n arg.
4584
66452beb
PW
45852019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4586
4587 * corelow.c (core_target::detach): Ensure frame cache and
4588 register caches are cleared.
4589 inferior.c (exit_inferior_1): Likewise.
4590
bde09ab7
TT
45912019-05-03 Sandra Loosemore <sandra@codesourcery.com>
4592 Tom Tromey <tom@tromey.com>
4593
4594 * dictionary.c (collate_pending_symbols_by_language): Remove
4595 "struct" from foreach.
4596 * symtab.c (lookup_global_symbol_from_objfile)
4597 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4598 foreach.
4599 * ser-tcp.c (net_open): Remove "struct" from foreach.
4600 * objfiles.c (objfile_relocate, objfile_rebase)
4601 (objfile_has_symbols): Remove "struct" from foreach.
4602 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4603 from foreach.
4604 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4605 foreach.
4606 * darwin-nat.c (thread_info_from_private_thread_info): Remove
4607 "struct" from foreach.
4608 * ada-lang.c (create_excep_cond_exprs)
4609 (ada_exception_catchpoint_cond_string): Remove "struct" from
4610 foreach.
4611
222a8d25
TT
46122019-05-03 Tom Tromey <tromey@adacore.com>
4613
4614 * ada-exp.y (convert_char_literal): Check suffix of each
4615 enumerator.
4616
fcd60b84
DP
46172019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
4618
4619 PR ada/21406:
4620 * ada-exp.y (yywrap): Don't define.
4621 * ada-lex.l (%option): Add noyywrap
4622 (yywrap): Remove.
4623
5f2459c2
EZ
46242019-05-03 Eli Zaretskii <eliz@gnu.org>
4625
353ea2d1
EZ
4626 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4627 _WIN32_WINNT to the XP level, unless already defined to a higher
4628 level.
4629
4630 * unittests/parse-connection-spec-selftests.c:
4631 * ser-tcp.c:
4632 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
4633 override.
4634
5f2459c2
EZ
4635 * symfile.c (find_separate_debug_file): Remove colon from the
4636 drive spec of DOS/Windows file names of the target, so that the
4637 file name produced from DEBUGDIR and the target's directory will
4638 be valid on DOS/Windows systems.
4639
80062eb9
AB
46402019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
4641
4642 * rust-lang.c (val_print_struct): Handle printing structures
4643 containing strings.
4644
b8c05e85
TT
46452019-05-02 Tom Tromey <tromey@adacore.com>
4646
4647 * valarith.c (_initialize_valarith): Remove.
4648
4504bbde
TT
46492019-05-01 Tom Tromey <tromey@adacore.com>
4650
4651 * ada-lang.c (ada_value_primitive_field): Treat more fields as
4652 bitfields.
4653
d48e62f4
TT
46542019-05-01 Tom Tromey <tromey@adacore.com>
4655
4656 * ada-lang.c (ada_value_assign): Correctly compute starting offset
4657 for big-endian copies.
4658
15f18d14
AT
46592019-04-30 Ali Tamur <tamur@google.com>
4660 * gdb/dwarf2read.c (read_3_bytes): New declaration.
4661 (read_attribute_value): Added DW_FORM_strx1-4 cases.
4662 (read_3_bytes): New function.
4663
ab4ee614
JB
46642019-04-30 Joel Brobecker <brobecker@adacore.com>
4665
4666 * windows-nat.c (main_thread_id): Delete.
4667 (handle_output_debug_string): Replace main_thread_id by
4668 current_event.dwThreadId.
4669 (fake_create_process): Likewise.
4670 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4671 Do not set main_thread_id.
4672 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4673 current_event.dwThreadId.
4674 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4675
8ed5b76e
JB
46762019-04-30 Joel Brobecker <brobecker@adacore.com>
4677
4678 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4679 Use current_event.dwThreadId instead of main_thread_id.
4680
2ff0a947
TT
46812019-04-30 Tom Tromey <tromey@adacore.com>
4682
4683 * ada-lang.c (ada_lookup_simple_minsyms): New function.
4684 (create_excep_cond_exprs): Iterate over program spaces.
4685 (ada_exception_catchpoint_cond_string): Examine all minimal
4686 symbols for exception types.
4687
a776957c
TT
46882019-04-30 Tom Tromey <tromey@adacore.com>
4689
4690 PR c++/24470:
4691 * dwarf2read.c (process_structure_scope): Handle case where type
4692 has template parameters but no symbol was created.
4693
bc68014d
AB
46942019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4695 Chris January <chris.january@arm.com>
4696
4697 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4698 qualifier.
4699 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4700
f1fdc960
AB
47012019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4702
4703 * f-typeprint.c (f_print_type): Update rules for printing
4704 whitespace.
4705 (f_type_print_varspec_suffix): Likewise.
4706
bf7a4de1
AB
47072019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4708 Chris January <chris.january@arm.com>
4709
4710 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4711 function arguments.
4712
bbe75b9d
AB
47132019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4714
4715 * f-lang.c (build_fortran_types): Change name of void type to
4716 lower case.
4717 * f-typeprint.c (f_type_print_base): Print the name of the void
4718 type, rather than a fixed string.
4719 * f-valprint.c (f_decorations): Use lower case void string.
4720
1db455a7
AB
47212019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4722 Chris January <chris.january@arm.com>
4723
4724 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4725 types for Fortran.
4726
b6d03bb2
AB
47272019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4728 Chris January <chris.january@arm.com>
4729 David Lecomber <david.lecomber@arm.com>
4730
4731 * f-exp.y (BINOP_INTRINSIC): New token.
4732 (exp): New parser rule handling BINOP_INTRINSIC.
4733 (f77_keywords): Add new builtin procedures.
4734 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4735 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4736 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4737 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4738 (print_unop_subexp_f): New function.
4739 (print_binop_subexp_f): New function.
4740 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4741 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4742 (dump_subexp_body_f): Likewise.
4743 (operator_check_f): Likewise.
4744 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4745 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4746
83228e93
AB
47472019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4748
4749 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4750 UNOP_KIND.
4751 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4752 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4753 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4754 (operator_length_f): New fuction.
4755 (print_subexp_f): New function.
4756 (op_name_f): New function.
4757 (dump_subexp_body_f): New function.
4758 (operator_check_f): New function.
4759 (exp_descriptor_f): Replace standard expression handling functions
4760 with new functions.
4761 * gdb/fortran-operator.def: New file.
4762 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4763 * gdb/std-operator.def: Remove UNOP_KIND.
4764
6fdcd7cc
AB
47652019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4766
4767 * std-operator.def: Remove unbalanced, stray double quote
4768 character.
4769
2e62ab40
AB
47702019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4771 Chris January <chris.january@arm.com>
4772 Daniel Everett <daniel.everett@arm.com>
4773 Nick Forrington <nick.forrington@arm.com>
4774 Richard Bunt <richard.bunt@arm.com>
4775
4776 * cp-valprint.c (cp_print_value_fields): Allow an additional level
4777 of depth when printing anonymous structs or unions.
4778 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4779 Don't print either the top-level value, or the children if the
4780 max-depth is exceeded.
4781 (ppscm_print_children): When printing the key of a map, allow one
4782 extra level of depth.
4783 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4784 print either the top-level value, or the children if the max-depth
4785 is exceeded.
4786 (print_children): When printing the key of a map, allow one extra
4787 level of depth.
4788 * python/py-value.c (valpy_format_string): Add max_depth keyword.
4789 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4790 (user_print_options): Initialise max_depth field.
4791 (val_print_scalar_or_string_type_p): New function.
4792 (val_print): Check to see if the max depth has been reached.
4793 (val_print_check_max_depth): Define new function.
4794 (show_print_max_depth): New function.
4795 (_initialize_valprint): Add 'print max-depth' option.
4796 * valprint.h (struct value_print_options) <max_depth>: New field.
4797 (val_print_check_max_depth): Declare new function.
4798 * NEWS: Document new feature.
4799
4be290b2
AB
48002019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4801
4802 * ada-lang.c (ada_language_defn): Initialise new field.
4803 * c-lang.c (c_is_string_type_p): New function.
4804 (c_language_defn): Initialise new field.
4805 (cplus_language_defn): Initialise new field.
4806 (asm_language_defn): Initialise new field.
4807 (minimal_language_defn): Initialise new field.
4808 * c-lang.h (c_is_string_type_p): Declare new function.
4809 * d-lang.c (d_language_defn): Initialise new field.
4810 * f-lang.c (f_is_string_type_p): New function.
4811 (f_language_defn): Initialise new field.
4812 * go-lang.c (go_is_string_type_p): New function.
4813 (go_language_defn): Initialise new field.
4814 * language.c (default_is_string_type_p): New function.
4815 (unknown_language_defn): Initialise new field.
4816 (auto_language_defn): Initialise new field.
4817 * language.h (struct language_defn) <la_is_string_type_p>: New
4818 member variable.
4819 (default_is_string_type_p): Declare new function.
4820 * m2-lang.c (m2_language_defn): Initialise new field.
4821 * objc-lang.c (objc_language_defn): Initialise new field.
4822 * opencl-lang.c (opencl_language_defn): Initialise new field.
4823 * p-lang.c (pascal_is_string_type_p): New function.
4824 (pascal_language_defn): Initialise new field.
4825 * rust-lang.c (rust_is_string_type_p): New function.
4826 (rust_language_defn): Initialise new field.
4827
721b08c6
AB
48282019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4829
4830 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4831 New field.
4832 * ada-lang.c (ada_language_defn): Initialise new field.
4833 * c-lang.c (c_language_defn): Likewise.
4834 (cplus_language_defn): Likewise.
4835 (asm_language_defn): Likewise.
4836 (minimal_language_defn): Likewise.
4837 * d-lang.c (d_language_defn): Likewise.
4838 * f-lang.c (f_language_defn): Likewise.
4839 * go-lang.c (go_language_defn): Likewise.
4840 * language.c (unknown_language_defn): Likewise.
4841 (auto_language_defn): Likewise.
4842 * m2-lang.c (m2_language_defn): Likewise.
4843 * objc-lang.c (objc_language_defn): Likewise.
4844 * opencl-lang.c (opencl_language_defn): Likewise.
4845 * p-lang.c (pascal_language_defn): Likewise.
4846 * rust-lang.c (rust_language_defn): Likewise.
4847
fc913e53
AB
48482019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4849
4850 * ada-lang.c (ada_is_character_type): Change return type to bool.
4851 (ada_is_string_type): Likewise.
4852 * ada-lang.h (ada_is_character_type): Update declaration
4853 (ada_is_string_type): Likewise.
4854
fa731fa0
PW
48552019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4856
4857 Support style in 'frame|thread apply'
4858
4859 * gdbcmd.h (execute_command_to_string): New term_out parameter.
4860 * record.c (record_start, record_stop): Update callers of
4861 execute_command_to_string with false.
4862 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4863 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4864 methods.
4865 (class string_file): New constructor with term_out parameter.
4866 Override methods term_out and can_emit_style_escape. New member
4867 term_out.
4868 (class stdio_file): Override can_emit_style_escape.
4869 (class tee_file): Override term_out and can_emit_style_escape.
4870 * utils.h (can_emit_style_escape): Remove.
4871 * utils.c (can_emit_style_escape): Likewise.
4872 Update all callers of can_emit_style_escape (SOMESTREAM) to
4873 SOMESTREAM->can_emit_style_escape.
4874 * source-cache.c (source_cache::get_source_lines): Likewise.
4875 * stack.c (frame_apply_command_count): Call execute_command_to_string
4876 passing the term_out characteristic of the current gdb_stdout.
4877 * thread.c (thr_try_catch_cmd): Likewise.
4878 * top.c (execute_command_to_string): pass term_out parameter
4879 to construct the string_file for the command output.
4880 * ui-file.c (term_cli_styling): New function (most code moved
4881 from utils.c can_emit_style_escape).
4882 (string_file::string_file, string_file::can_emit_style_escape,
4883 stdio_file::can_emit_style_escape, tee_file::term_out,
4884 tee_file::can_emit_style_escape): New functions.
4885
136afab8
PW
48862019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4887
4888 * NEWS: Mention the new set|show may-call-functions.
4889 * infcall.c (may_call_functions_p): New variable.
4890 (show_may_call_functions_p): New function.
4891 (call_function_by_hand_dummy): Throws an error if not
4892 may-call-functions.
4893 (_initialize_infcall): Call add_setshow_boolean_cmd for
4894 may-call-functions.
4895
725cbb63
KS
48962019-04-25 Keith Seitz <keiths@redhat.com>
4897
4898 PR c++/24367
4899 * cp-support.c (inspect_type): Don't attempt substitutions
4900 of symbol with the same name.
4901
3d1cbb78
TT
49022019-04-25 Tom Tromey <tromey@adacore.com>
4903
4904 PR gdb/24475:
4905 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4906 static.
4907
94aeb44b
TT
49082019-04-25 Tom Tromey <tromey@adacore.com>
4909
4910 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4911 rvalue reference.
4912 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4913 (gdb_xml_parser::parse): Use std::move.
4914 * python/python-internal.h (gdbpy_convert_exception): Take a const
4915 reference.
4916 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4917 std::move.
4918 * python/py-utils.c (gdbpy_convert_exception): Take a const
4919 reference.
4920 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4921 Use std::move.
4922 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4923 Use std::move.
4924 * mi/mi-main.c (mi_print_exception): Take a const reference.
4925 * main.c (handle_command_errors): Take a const reference.
4926 * linespec.c (parse_linespec): Use std::move.
4927 * infcall.c (run_inferior_call): Use std::move.
4928 (call_function_by_hand_dummy): Use std::move.
4929 * exec.c (try_open_exec_file): Use std::move.
4930 * exceptions.h (exception_print, exception_fprintf)
4931 (exception_print_same): Update.
4932 * exceptions.c (print_exception, exception_print)
4933 (exception_fprintf, exception_print_same): Change parameters to
4934 const reference.
4935 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4936 * common/new-op.c: Use std::move.
4937 * common/common-exceptions.h (struct gdb_exception): Add move
4938 constructor.
4939 (struct gdb_exception_error, struct gdb_exception_quit, struct
4940 gdb_quit_bad_alloc): Change constructor to move constructor.
4941 (throw_exception): Change parameter to rvalue reference.
4942 * common/common-exceptions.c (throw_exception): Take rvalue
4943 reference.
4944 * cli/cli-interp.c (safe_execute_command): Use std::move.
4945 * breakpoint.c (insert_bp_location, location_to_sals): Use
4946 std::move.
4947
680d7fd5
TT
49482019-04-25 Tom Tromey <tromey@adacore.com>
4949
4950 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4951 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4952 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4953 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4954 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4955 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4956 guile/scm-value.c: Use unpack.
4957 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4958 gdbscm_gdb_exception.
4959 (gdbscm_throw_gdb_exception): Likewise.
4960 (struct gdbscm_gdb_exception): New.
4961 (unpack): New function.
4962 (gdbscm_wrap): Use unpack.
4963
c6fdd8b2
TT
49642019-04-25 Tom Tromey <tromey@adacore.com>
4965
4966 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4967 (gdb_rl_callback_handler): Use std::move.
4968 * common/common-exceptions.h (struct gdb_exception): Add move
4969 assignment operator.
4970 (throw_exception_sjlj): Change "exception" to const reference.
4971 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4972 (throw_exception_sjlj): Change "exception" to const reference.
4973
cc06b668
TT
49742019-04-25 Tom Tromey <tromey@adacore.com>
4975
4976 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4977 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4978 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4979 Update.
4980 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4981 Update.
4982 * mi/mi-interp.c (mi_interp::exec): Update.
4983 * linespec.c (parse_linespec): Update.
4984 * infcall.c (run_inferior_call): Update.
4985 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4986 * guile/scm-symbol.c (gdbscm_lookup_symbol)
4987 (gdbscm_lookup_global_symbol): Update.
4988 * guile/scm-param.c (gdbscm_parameter_value): Update.
4989 * guile/scm-frame.c (gdbscm_frame_read_register)
4990 (gdbscm_frame_read_var): Update.
4991 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4992 * exec.c (try_open_exec_file): Update.
4993 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4994 (gdb_rl_callback_handler): Update.
4995 * common/common-exceptions.h (exception_none): Don't declare.
4996 * common/common-exceptions.c (exception_none): Don't define.
4997 (struct catcher) <exception>: Update.
4998 * cli/cli-interp.c (safe_execute_command): Update.
4999 * breakpoint.c (insert_bp_location, location_to_sals): Update.
5000
cf532bd1
AT
50012019-04-25 Ali Tamur <tamur@google.com>
5002
5003 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5004 (read_attribute_value): Likewise.
5005 (dwarf2_read_addr_index): Update comment.
5006 (read_str_index): Add DW_FORM_strx.
5007 (dwarf2_string_attr): Likewise.
5008 (dwarf2_const_value_attr): Likewise.
5009 (dump_die_shallow): Likewise.
5010 (dwarf2_fetch_constant_bytes): Likewise.
5011 (skip_form_bytes): Likewise.
5012 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5013
82433e3e
SDJ
50142019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
5015
5016 PR corefiles/11608
5017 PR corefiles/18187
5018 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5019 OFFSET. Verify if current mapping contains an ELF header.
5020 (linux_find_memory_regions_full): Adjust call to
5021 dump_mapping_p.
5022
723adb65
SL
50232019-04-25 Sandra Loosemore <sandra@codesourcery.com>
5024 Kang Li <kanglictf@gmail.com>
5025
5026 PR gdb/21600
5027
5028 * dwarf2-frame.c (read_initial_length): Be consistent about using
5029 unsigned representation of length.
5030 (decode_frame_entry_1): Likewise. Check for wraparound of
5031 end pointer as well as buffer overflow.
5032
596179f7
SDJ
50332019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
5034
5035 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5036 "vq".
5037
a59240a4
TT
50382019-04-24 Tom Tromey <tromey@adacore.com>
5039
5040 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5041
f872fdbb
AB
50422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5043
5044 * s12z-tdep.c (s12z_unwind_pc): Delete.
5045 (s12z_unwind_sp): Delete.
5046 (s12z_gdbarch_init): Don't register deleted functions with
5047 gdbarch.
5048
b614e6f3
AB
50492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5050
5051 * rl78-tdep.c (rl78_unwind_sp): Delete.
5052 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5053
14faed38
AB
50542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5055
5056 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5057 (xstormy16_unwind_pc): Delete.
5058 (xstormy16_dummy_id): Delete.
5059 (xstormy16_gdbarch_init): Don't register deleted functions with
5060 gdbarch.
5061
541aad8a
AB
50622019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5063
5064 * vax-tdep.c (vax_unwind_pc): Delete.
5065 (vax_gdbarch_init): Don't register deleted function with gdbarch.
5066
29222070
AB
50672019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5068
5069 * v850-tdep.c (v850_unwind_sp): Delete.
5070 (v850_unwind_pc): Delete.
5071 (v850_dummy_id): Delete.
5072 (v850_gdbarch_init): Don't register deleted functions with
5073 gdbarch.
5074
0f534d76
AB
50752019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5076
5077 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5078 (tilegx_unwind_pc): Delete.
5079 (tilegx_unwind_dummy_id): Delete.
5080 (tilegx_gdbarch_init): Don't register deleted functions with
5081 gdbarch.
5082
1ba7b7f9
AB
50832019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5084
5085 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5086 (tic6x_dummy_id): Delete.
5087 (tic6x_gdbarch_init): Don't register deleted functions with
5088 gdbarch.
5089
d31f262c
AB
50902019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5091
5092 * sparc-tdep.c (sparc_unwind_pc): Delete.
5093 (sparc32_gdbarch_init): Don't register deleted function with
5094 gdbarch.
5095
6d14d64d
AB
50962019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5097
5098 * sh-tdep.c (sh_unwind_sp): Delete.
5099 (sh_unwind_pc): Delete.
5100 (sh_dummy_id): Delete.
5101 (sh_gdbarch_init): Don't register deleted functions with
5102 gdbarch.
5103
a40dde9d
AB
51042019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5105
5106 * score-tdep.c (score_unwind_sp): Delete.
5107 (score_unwind_pc): Delete.
5108 (score_dummy_id): Delete.
5109 (score_gdbarch_init): Don't register deleted functions with
5110 gdbarch.
5111
47c47d69
AB
51122019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5113
5114 * rx-tdep.c (rx_unwind_pc): Delete.
5115 (rx_unwind_sp): Delete.
5116 (rx_dummy_id): Delete.
5117 (rx_gdbarch_init): Don't register deleted functions with
5118 gdbarch. Update comment.
5119
833a4480
AB
51202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5121
5122 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5123 (rs6000_dummy_id): Delete.
5124 (rs6000_gdbarch_init): Don't register deleted functions with
5125 gdbarch.
5126
3f2cef49
AB
51272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5128
5129 * or1k-tdep.c (or1k_dummy_id): Delete.
5130 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5131
96acf884
AB
51322019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5133
5134 * nios2-tdep.c (nios2_dummy_id): Delete.
5135 (nios2_unwind_sp): Delete.
5136 (nios2_gdbarch_init): Don't register deleted functions with
5137 gdbarch.
5138
ca0ab0aa
AB
51392019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5140
5141 * nds32-tdep.c (nds32_dummy_id): Delete.
5142 (nds32_unwind_pc): Delete.
5143 (nds32_unwind_sp): Delete.
5144 (nds32_gdbarch_init): Don't register deleted functions with
5145 gdbarch.
5146
c8259044
AB
51472019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5148
5149 * msp430-tdep.c (msp430_unwind_pc): Delete.
5150 (msp430_unwind_sp): Delete.
5151 (msp430_dummy_id): Delete.
5152 (msp430_gdbarch_init): Don't register deleted functions with
5153 gdbarch.
5154
27f113c8
AB
51552019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5156
5157 * moxie-tdep.c (moxie_unwind_sp): Delete.
5158 (moxie_unwind_pc): Delete.
5159 (moxie_dummy_id): Delete.
5160 (moxie_gdbarch_init): Don't register deleted functions with
5161 gdbarch.
5162
aee6c3cd
AB
51632019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5164
5165 * mn10300-tdep.c (mn10300_dummy_id): Delete.
5166 (mn10300_unwind_pc): Delete.
5167 (mn10300_unwind_sp): Delete.
5168 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5169 mn10300_unwind_sp.
5170 (mn10300_frame_unwind_init): Don't register deleted functions with
5171 gdbarch.
5172
8e2b5aea
AB
51732019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5174
5175 * mep-tdep.c (mep_unwind_pc): Delete.
5176 (mep_unwind_sp): Delete.
5177 (mep_dummy_id): Delete.
5178 (mep_gdbarch_init): Don't register deleted functions with
5179 gdbarch.
5180
43cf3ede
AB
51812019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5182
5183 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5184 (m68hc11_unwind_sp): Delete.
5185 (m68hc11_gdbarch_init): Don't register deleted functions with
5186 gdbarch.
5187
5e79b7bb
AB
51882019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5189
5190 * m32r-tdep.c (m32r_unwind_sp): Delete.
5191 (m32r_unwind_pc): Delete.
5192 (m32r_dummy_id): Delete.
5193 (m32r_gdbarch_init): Don't register deleted functions with
5194 gdbarch.
5195
89b268d8
AB
51962019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5197
5198 * m32c-tdep.c (m32c_unwind_pc): Delete.
5199 (m32c_unwind_sp): Delete.
5200 (m32c_dummy_id): Delete.
5201 (m32c_gdbarch_init): Don't register deleted functions with
5202 gdbarch.
5203
946c28d2
AB
52042019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5205
5206 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5207 (lm32_unwind_pc): Delete.
5208 (lm32_dummy_id): Delete.
5209 (lm32_gdbarch_init): Don't register deleted functions with
5210 gdbarch.
5211
bf12844a
AB
52122019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5213
5214 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5215 (iq2000_unwind_pc): Delete.
5216 (iq2000_dummy_id): Delete.
5217 (iq2000_gdbarch_init): Don't register deleted functions with
5218 gdbarch.
5219
ecbc06d2
AB
52202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5221
5222 * nds32-tdep.c (nds32_type_align): Delete.
5223 (nds32_push_dummy_call): Use type_align instead.
5224
030197b4
AB
52252019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5226
5227 * arm-tdep.c (arm_type_align): Only handle vector override case.
5228 (arm_push_dummy_call): Use type_align.
5229 (arm_gdbarch_init): Register arm_type_align gdbarch function.
5230
b907456c
AB
52312019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5232
5233 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5234 case.
5235 (pass_on_stack): Use type_align.
5236 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5237 function.
5238
9e97ba43
TT
52392019-04-23 Tom Tromey <tromey@adacore.com>
5240
5241 * dwarf2read.c (line_header::file_name_at): Remove unused
5242 overload.
5243
6892f601
TV
52442019-04-23 Tom de Vries <tdevries@suse.de>
5245
5246 PR gdb/24438
5247 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5248 invocation.
5249
336d760d
AT
5250
52512019-03-27 Ali Tamur <tamur@google.com>
5252
5253 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5254 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5255 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5256 (dwarf_expr_context::get_addr_index): Likewise
5257 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5258 (symbol_needs_eval_context::get_addr_index): Likewise
5259 (disassemble_dwarf_expression): Add DW_OP_addrx
5260 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5261 (read_cutu_die_from_dwo): Update comment
5262 (skip_one_die): Add DW_FORM_addrx
5263 (read_attribute_value): Likewise
5264 (var_decode_location): Add DW_OP_addrx
5265 (dwarf2_const_value_attr): Add DW_FORM_addrx
5266 (dump_die_shallow): Likewise
5267 (dwarf2_fetch_constant_bytes): Likewise
5268 (decode_locdesc): Add DW_OP_addrx
5269 (skip_form_bytes): Add DW_FORM_addrx
5270
ad9d13f8
AT
52712019-04-22 Ali Tamur <tamur@google.com>
5272
5273 * MAINTAINERS (Write After Approval): Add self.
5274
d70cc3ba
SM
52752019-04-22 Simon Marchi <simon.marchi@efficios.com>
5276
5277 * solib-svr4.c (get_svr4_info): Add pspace parameter.
5278 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5279 (open_symbol_file_object): Likewise.
5280 (svr4_default_sos): Add info parameter.
5281 (svr4_read_so_list): Likewise.
5282 (svr4_current_sos_direct): Adjust functions calls to pass down
5283 info.
5284 (svr4_current_sos_1): Add info parameter.
5285 (svr4_current_sos): Call get_svr4_info, pass info down to
5286 svr4_current_sos_1.
5287 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5288 get_svr4_info.
5289 (svr4_in_dynsym_resolve_code): Pass current_program_space to
5290 get_svr4_info.
5291 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5292 to get_svr4_info.
5293 (probes_table_remove_objfile_probes): Likewise.
5294 (register_solib_event_probe): Add info parameter.
5295 (solist_update_incremental): Pass info parameter down to
5296 svr4_read_so_list.
5297 (disable_probes_interface): Add info parameter.
5298 (svr4_handle_solib_event): Pass current_program_space to
5299 get_svr4_info. Adjust disable_probes_interface cleanup.
5300 (svr4_create_probe_breakpoints): Add info parameter, pass it
5301 down to register_solib_event_probe.
5302 (svr4_create_solib_event_breakpoints): Add info parameter,
5303 pass it down to svr4_create_probe_breakpoints.
5304 (enable_break): Pass info down to
5305 svr4_create_solib_event_breakpoints.
5306 (svr4_solib_create_inferior_hook): Pass current_program_space to
5307 get_svr4_info.
5308 (svr4_clear_solib): Likewise.
5309
7905fc35
PA
53102019-04-22 Pedro Alves <palves@redhat.com>
5311
5312 * solib-svr4.c (svr4_free_objfile_observer): New.
5313 (probe_and_action::objfile): New field.
5314 (probes_table_htab_remove_objfile_probes)
5315 (probes_table_remove_objfile_probes): New functions.
5316 (register_solib_event_probe): Add 'objfile' parameter. Store it
5317 in the new probe_and_action. Don't store the probe in 'lookup'.
5318 (svr4_create_probe_breakpoints): Pass objfile to
5319 register_solib_event_probe.
5320 (_initialize_svr4_solib): Register a free_objfile observer.
5321
fb881986
TT
53222019-04-19 Tom Tromey <tom@tromey.com>
5323
5324 * common/queue.h: Remove.
5325
8732db6c
TT
53262019-04-19 Tom Tromey <tom@tromey.com>
5327
5328 * event-loop.c: Don't include "common/queue.h".
5329
97dfbadd
TT
53302019-04-19 Tom Tromey <tom@tromey.com>
5331
5332 * remote.c (remote_target): Use delete.
5333 * remote-notif.h: Include <list>, not "common/queue.h".
5334 (notif_client_p): Remove typedef.
5335 (remote_notif_state): Add constructor, destructor, initializer.
5336 <notif_queue>: Now a std::list.
5337 (remote_notif_state_xfree): Don't declare.
5338 * remote-notif.c (remote_notif_process, handle_notification)
5339 (remote_notif_state_allocate): Update.
5340 (~remote_notif_state): Rename from remote_notif_state_xfree.
5341
cf250e36
TT
53422019-04-19 Tom Tromey <tom@tromey.com>
5343
5344 * symfile.c (reread_symbols): Update.
5345 * objfiles.c (objfile_register_static_link)
5346 (objfile_lookup_static_link): Update
5347 (~objfile) Don't delete static_links.
5348 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5349
61f4b350
TT
53502019-04-19 Tom Tromey <tom@tromey.com>
5351
5352 * type-stack.h (struct type_stack) <insert>: Constify string.
5353 * type-stack.c (type_stack::insert): Constify string.
5354 * gdbtypes.h (lookup_template_type): Update.
5355 (address_space_name_to_int): Update.
5356 * gdbtypes.c (address_space_name_to_int): Make space_identifier
5357 const.
5358 (lookup_template_type): Make name const.
5359 * c-exp.y: Update rules.
5360 (lex_one_token, classify_name, classify_inner_name)
5361 (c_print_token): Update.
5362 * p-exp.y: Update rules.
5363 (yylex): Update.
5364 * f-exp.y: Update rules.
5365 (yylex): Update.
5366 * d-exp.y: Update rules.
5367 (lex_one_token, classify_name, classify_inner_name): Update.
5368 * parse.c (write_dollar_variable, copy_name): Return std::string.
5369 * parser-defs.h (copy_name): Change return type.
5370 * m2-exp.y: Update rules.
5371 (yylex): Update.
5372 * go-exp.y (lex_one_token): Update.
5373 Update rules.
5374 (classify_unsafe_function, classify_packaged_name)
5375 (classify_name, yylex): Update.
5376
189b8c2e
ST
53772019-04-19 Sergei Trofimovich <siarheit@google.com>
5378
5379 * configure.ac: add --enable-source-highlight switch.
5380 * configure: Regenerate.
5381 * top.c (print_gdb_version): plumb --enable-source-highlight
5382 status to "show configuration".
5383
8ecb59f8
TT
53842019-04-19 Tom Tromey <tromey@adacore.com>
5385
5386 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5387 Check ADA_TYPE_P.
5388 (empty_record, ada_template_to_fixed_record_type_1)
5389 (template_to_static_fixed_type)
5390 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5391 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5392 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5393 macros.
5394
62160ec9
TT
53952019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
5396
5397 PR symtab/24423:
5398 * source.c (print_source_lines_base): Advance "iter" when a
5399 control character is seen.
5400
f2ae8bc8
PW
54012019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5402
5403 * inferior.h (struct infcall_suspend_state_deleter):
5404 Catch exception in destructor to avoid crash.
5405
d563b953
PW
54062019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5407
5408 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5409 close to the add_com "shell".
5410
dc34c897
TT
54112019-04-18 Tom Tromey <tromey@adacore.com>
5412
5413 * process-stratum-target.h (class process_stratum_target)
5414 <stratum>: Add "final".
5415
a12e5744
TT
54162019-04-17 Tom Tromey <tromey@adacore.com>
5417
5418 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5419 against nullptr before use.
5420
a7e559cc
AH
54212019-04-17 Alan Hayward <alan.hayward@arm.com>
5422
5423 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5424
c01660c6
AB
54252019-04-17 Jim Wilson <jimw@sifive.com>
5426 Andrew Burgess <andrew.burgess@embecosm.com>
5427
5428 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5429 code read might fail, assume 4-byte breakpoint in that case.
5430
4aa866af
LS
54312019-04-15 Leszek Swirski <leszeks@google.com>
5432
5433 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5434 rather than a hand-rolled POD check when checking for forced MEMORY
5435 classification.
5436
48574d91
AH
54372019-04-15 Alan Hayward <alan.hayward@arm.com>
5438
5439 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5440 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5441 function.
5442 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5443 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5444 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5445 declaration.
5446
4da037ef
AH
54472019-04-15 Alan Hayward <alan.hayward@arm.com>
5448
5449 * aarch64-linux-nat.c
5450 (aarch64_linux_nat_target::thread_architecture): Add override.
5451 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5452 each VQ.
5453
ccb8d7e8
AH
54542019-04-15 Alan Hayward <alan.hayward@arm.com>
5455
5456 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5457
35add35e
AB
54582019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
5459
5460 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5461 target types of size 96-bits, add some additional comments, and
5462 check that the builtin type we found was the correct size.
5463
51196bbc
EZ
54642019-04-12 Eli Zaretskii <eliz@gnu.org>
5465
5466 * utils.c (prompt_for_continue): Don't restore the styling at the
5467 end, as applied_style has the wrong value. This fixes styling in
5468 long lists of file names that are interrupted by the "Continue?"
5469 prompt.
5470
62253a61
AB
54712019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
5472
5473 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5474 * c-lang.c (c_language_defn): Likewise.
5475 (cplus_language_defn): Likewise.
5476 (asm_language_defn): Likewise.
5477 (minimal_language_defn): Likewise.
5478 * d-lang.c (d_language_defn): Likewise.
5479 * f-lang.c (f_language_defn): Likewise.
5480 * go-lang.c (go_language_defn): Likewise.
5481 * language.c (unknown_language_defn): Likewise.
5482 (auto_language_defn): Likewise.
5483 * language.h (struct language_defn): Remove la_magic field.
5484 (LANG_MAGIC): Delete.
5485 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5486 * objc-lang.c (objc_language_defn): Likewise.
5487 * opencl-lang.c (opencl_language_defn): Likewise.
5488 * p-lang.c (pascal_language_defn): Likewise.
5489 * rust-lang.c (rust_language_defn): Likewise.
5490
a9158a86
AB
54912019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
5492
5493 * riscv-tdep.c (riscv_type_align): New function.
5494 (riscv_type_alignment): Delete.
5495 (riscv_arg_location): Use 'type_align'.
5496 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5497
41077b66
AB
54982019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
5499
5500 * gdbtypes.c (type_align): A struct with no non-static fields also
5501 has alignment of 1.
5502
9f0272f8
AB
55032019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
5504
5505 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5506 component to 0.
5507 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5508 member.
5509 (riscv_struct_info::analyse): New implementation using new
5510 analyse_inner member function.
5511 (riscv_struct_info::field_offset): New member function.
5512 (riscv_struct_info::m_offsets): New member variable.
5513 (riscv_struct_info::analyse_inner): New private member function,
5514 takes the old implementation of riscv_struct_info::analyse but
5515 extended to track field offsets.
5516 (riscv_call_arg_struct): Update the struct folding special cases
5517 to handle cases where empty C++ structs, which are non-zero
5518 length, are found.
5519 (riscv_arg_location): Initialise the length of each location, a
5520 non-zero length now indicates the location is in use.
5521 (riscv_push_dummy_call): Allow for the first location having a
5522 non-zero offset when setting up arguments.
5523 (riscv_return_value): Likewise, but for return values.
5524
02cf60c7
TT
55252019-04-11 Tom Tromey <tromey@adacore.com>
5526
5527 * utils.c (internal_vproblem): Make "msg" const.
5528
68811f8f
AH
55292019-04-11 Alan Hayward <alan.hayward@arm.com>
5530
5531 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5532 * trad-frame.c (trad_frame_reset_saved_regs): New function.
5533 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5534 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5535
3f52fdbc
KB
55362019-04-10 Kevin Buettner <kevinb@redhat.com>
5537
5538 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5539 function.
5540 (fill_gregset): Call amd64_linux_collect_native_gregset instead
5541 of amd64_collect_native_gregset.
5542 (amd64_linux_nat_target::store_registers): Likewise.
5543
e9ad22ee
TT
55442019-04-10 Tom Tromey <tom@tromey.com>
5545
5546 * symtab.c (lookup_global_symbol_from_objfile)
5547 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5548 * objfiles.h (class separate_debug_iterator): New.
5549 (class separate_debug_range): New.
5550 (struct objfile) <separate_debug_objfiles>: New method.
5551 (objfile_separate_debug_iterate): Don't declare.
5552 * objfiles.c (separate_debug_iterator::operator++): Rename from
5553 objfile_separate_debug_iterate.
5554 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5555 iterator.
5556 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5557 iterator.
5558
ee371134
TT
55592019-04-10 Tom Tromey <tom@tromey.com>
5560
5561 * symfile.c (reread_symbols): Remove old comment.
5562 * objfiles.c (free_all_objfiles): Fix a typo.
5563
bf227d61
TT
55642019-04-10 Tom Tromey <tom@tromey.com>
5565
5566 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5567 * minsyms.c (lookup_minimal_symbol): Use foreach.
5568 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5569 (lookup_minimal_symbol_solib_trampoline): Likewise.
5570 * symfile.c (reread_symbols): Use foreach.
5571
8dc433a0
TT
55722019-04-09 Ivan Begert <ivanbegert@gmail.com>
5573 Tom Tromey <tromey@adacore.com>
5574
5575 PR rust/24414:
5576 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5577 (rust_lex_int_test): Change "value" to be LONGEST.
5578 (rust_lex_tests): Add test for long integer literal.
5579
9ab8741a
TT
55802019-04-09 Tom Tromey <tromey@adacore.com>
5581
5582 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5583 to bool.
5584 (extended_remote_target::attach): Update.
5585 (remote_target::remote_notice_new_inferior): Update.
5586 (remote_target::add_current_inferior_and_thread): Update.
5587 * inferior.c (exit_inferior_1): Use "false".
5588 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5589
e242fd12
SM
55902019-04-09 Simon Marchi <simon.marchi@efficios.com>
5591
9ca1957f 5592 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
5593 the "start" command.
5594
2b0c8b01
KB
55952019-04-08 Kevin Buettner <kevinb@redhat.com>
5596
5597 * python/py-inferior.c (infpy_thread_from_thread_handle):
5598 Adjust comments to reflect renaming of thread_from_thread_handle
5599 to thread_from_handle. Adjust keywords. Fix type error message.
5600 (inferior_object_methods): Add thread_from_handle. Retain
5601 thread_from_thread_handle, but mark it as deprecated.
5602
50a82723
KB
56032019-04-08 Kevin Buettner <kevinb@redhat.com>
5604
5605 * gdbthread.h (find_thread_by_handle): Revise declaration.
5606 * thread.c (find_thread_by_handle): Likewise. Adjust
5607 implementation too.
5608 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5609 support for buffer objects as handles.
5610
cf63b016
KB
56112019-04-08 Kevin Buettner <kevinb@redhat.com>
5612
5613 * python/py-infthread.c (thpy_thread_handle): New function.
5614 (thread_object_methods): Register thpy_thread_handle.
5615
3d6c6204
KB
56162019-04-08 Kevin Buettner <kevinb@redhat.com>
5617
5618 * gdbthread.h (thread_to_thread_handle): Declare.
5619 * thread.c (gdbtypes.h): Include.
5620 (thread_to_thread_handle): New function.
5621
5622 * target.h (struct target_ops): Add thread_info_to_thread_handle.
5623 (target_thread_info_to_thread_handle): Declare.
5624 * target.c (target_thread_info_to_thread_handle): New function.
5625 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5626 * target-delegates.c: Regenerate.
5627
5628 * linux-thread-db.c (class thread_db_target): Add method
5629 thread_info_to_thread_handle.
5630 (thread_db_target::thread_info_to_thread_handle): Define.
5631 * remote.c (class remote_target): Add new method
5632 thread_info_to_thread_handle.
5633 (remote_target::thread_info_to_thread_handle): Define.
5634
56be6ea8
PA
56352019-04-08 Pedro Alves <palves@redhat.com>
5636
5637 * common/common-exceptions.c (throw_exception): Don't create
5638 named object to throw; throw directly.
5639 (throw_it): Likewise. Don't initialize gdb_exception::message
5640 here, with new; pass FMT and AP to the ctor instead.
5641 * common/common-exceptions.h: Include <string>.
5642 (gdb_exception::gdb_exception(enum return_reason, enum errors,
5643 const char *, va_list)): New ctor. Use std::make_shared.
5644 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5645 errors)): Delete.
5646 (gdb_exception_error::gdb_exception_error(enum errors, const char
5647 *, va_list)): New.
5648 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5649 Add assertion.
5650 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5651 errors)): Delete.
5652 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5653 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5654 Add assertion.
5655
eedc3f4f
TT
56562019-04-08 Tom Tromey <tom@tromey.com>
5657
5658 * valops.c (value_rtti_indirect_type): Replace throw_exception
5659 with throw.
5660 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5661 with throw.
5662 * thread.c (thr_try_catch_cmd): Replace throw_exception with
5663 throw.
5664 * target.c (target_translate_tls_address): Replace throw_exception
5665 with throw.
5666 * stack.c (frame_apply_command_count): Replace throw_exception
5667 with throw.
5668 * solib-spu.c (append_ocl_sos): Replace throw_exception with
5669 throw.
5670 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5671 with throw.
5672 * rs6000-tdep.c (rs6000_frame_cache)
5673 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5674 * remote.c: Replace throw_exception with throw.
5675 * record-full.c (record_full_message, record_full_wait_1)
5676 (record_full_restore): Replace throw_exception with throw.
5677 * record-btrace.c:
5678 (get_thread_current_frame_id, record_btrace_start_replaying)
5679 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5680 (cmd_record_btrace_start): Replace throw_exception with throw.
5681 * parse.c (parse_exp_in_context_1): Replace throw_exception with
5682 throw.
5683 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5684 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5685 * linespec.c:
5686 (find_linespec_symbols): Replace throw_exception with throw.
5687 * infrun.c (displaced_step_prepare, resume): Replace
5688 throw_exception with throw.
5689 * infcmd.c (post_create_inferior): Replace throw_exception with
5690 throw.
5691 * inf-loop.c (inferior_event_handler): Replace throw_exception
5692 with throw.
5693 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5694 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5695 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5696 (get_prev_frame_always, get_frame_pc_if_available)
5697 (get_frame_address_in_block_if_available, get_frame_language):
5698 Replace throw_exception with throw.
5699 * frame-unwind.c (frame_unwind_try_unwinder): Replace
5700 throw_exception with throw.
5701 * eval.c (fetch_subexp_value, evaluate_var_value)
5702 (evaluate_funcall, evaluate_subexp_standard): Replace
5703 throw_exception with throw.
5704 * dwarf2loc.c (call_site_find_chain)
5705 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5706 Replace throw_exception with throw.
5707 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5708 with throw.
5709 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5710 throw.
5711 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5712 * completer.c (complete_line_internal): Replace throw_exception
5713 with throw.
5714 * compile/compile-object-run.c (compile_object_run): Replace
5715 throw_exception with throw.
5716 * cli/cli-script.c (process_next_line): Replace throw_exception
5717 with throw.
5718 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5719 (btrace_enable, btrace_maint_update_pt_packets): Replace
5720 throw_exception with throw.
5721 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5722 throw_exception with throw.
5723 * break-catch-throw.c (re_set_exception_catchpoint): Replace
5724 throw_exception with throw.
5725 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5726 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5727 * aarch64-tdep.c (aarch64_make_prologue_cache)
5728 (aarch64_make_stub_cache): Replace throw_exception with throw.
5729
26003a20
TT
57302019-04-08 Tom Tromey <tom@tromey.com>
5731
5732 * common/common-exceptions.c (throw_exception): Rename from
5733 throw_exception_cxx. Remove old copy. Make argument const.
5734 (throw_it): Create and throw exception objects directly.
5735 * common/common-exceptions.h (throw_exception): Make argument
5736 const.
5737 (struct gdb_exception_error): Add constructor.
5738 (struct gdb_exception_quit): Add constructor.
5739
d272eb37
TT
57402019-04-08 Tom Tromey <tom@tromey.com>
5741
5742 * common/common-exceptions.h (exception_rethrow): Don't declare.
5743 (TRY_SJLJ): Update comment.
5744 (TRY, CATCH, END_CATCH): Remove.
5745 * common/common-exceptions.c (exception_rethrow): Remove.
5746
230d2906
TT
57472019-04-08 Tom Tromey <tom@tromey.com>
5748
5749 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5750 Remove.
5751 (gdb_exception_error): Rename from
5752 gdb_exception_RETURN_MASK_ERROR.
5753 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5754 (gdb_quit_bad_alloc): Update.
5755 * aarch64-tdep.c: Update.
5756 * ada-lang.c: Update.
5757 * ada-typeprint.c: Update.
5758 * ada-valprint.c: Update.
5759 * amd64-tdep.c: Update.
5760 * arch-utils.c: Update.
5761 * break-catch-throw.c: Update.
5762 * breakpoint.c: Update.
5763 * btrace.c: Update.
5764 * c-varobj.c: Update.
5765 * cli/cli-cmds.c: Update.
5766 * cli/cli-interp.c: Update.
5767 * cli/cli-script.c: Update.
5768 * common/common-exceptions.c: Update.
5769 * common/new-op.c: Update.
5770 * common/selftest.c: Update.
5771 * compile/compile-c-symbols.c: Update.
5772 * compile/compile-cplus-symbols.c: Update.
5773 * compile/compile-object-load.c: Update.
5774 * compile/compile-object-run.c: Update.
5775 * completer.c: Update.
5776 * corelow.c: Update.
5777 * cp-abi.c: Update.
5778 * cp-support.c: Update.
5779 * cp-valprint.c: Update.
5780 * darwin-nat.c: Update.
5781 * disasm-selftests.c: Update.
5782 * dtrace-probe.c: Update.
5783 * dwarf-index-cache.c: Update.
5784 * dwarf-index-write.c: Update.
5785 * dwarf2-frame-tailcall.c: Update.
5786 * dwarf2-frame.c: Update.
5787 * dwarf2loc.c: Update.
5788 * dwarf2read.c: Update.
5789 * eval.c: Update.
5790 * event-loop.c: Update.
5791 * event-top.c: Update.
5792 * exec.c: Update.
5793 * f-valprint.c: Update.
5794 * fbsd-tdep.c: Update.
5795 * frame-unwind.c: Update.
5796 * frame.c: Update.
5797 * gdbtypes.c: Update.
5798 * gnu-v3-abi.c: Update.
5799 * guile/guile-internal.h: Update.
5800 * guile/scm-block.c: Update.
5801 * guile/scm-breakpoint.c: Update.
5802 * guile/scm-cmd.c: Update.
5803 * guile/scm-disasm.c: Update.
5804 * guile/scm-frame.c: Update.
5805 * guile/scm-lazy-string.c: Update.
5806 * guile/scm-math.c: Update.
5807 * guile/scm-param.c: Update.
5808 * guile/scm-ports.c: Update.
5809 * guile/scm-pretty-print.c: Update.
5810 * guile/scm-symbol.c: Update.
5811 * guile/scm-symtab.c: Update.
5812 * guile/scm-type.c: Update.
5813 * guile/scm-value.c: Update.
5814 * i386-linux-tdep.c: Update.
5815 * i386-tdep.c: Update.
5816 * inf-loop.c: Update.
5817 * infcall.c: Update.
5818 * infcmd.c: Update.
5819 * infrun.c: Update.
5820 * jit.c: Update.
5821 * language.c: Update.
5822 * linespec.c: Update.
5823 * linux-fork.c: Update.
5824 * linux-nat.c: Update.
5825 * linux-tdep.c: Update.
5826 * linux-thread-db.c: Update.
5827 * main.c: Update.
5828 * mi/mi-cmd-break.c: Update.
5829 * mi/mi-cmd-stack.c: Update.
5830 * mi/mi-interp.c: Update.
5831 * mi/mi-main.c: Update.
5832 * objc-lang.c: Update.
5833 * p-valprint.c: Update.
5834 * parse.c: Update.
5835 * ppc-linux-tdep.c: Update.
5836 * printcmd.c: Update.
5837 * python/py-arch.c: Update.
5838 * python/py-breakpoint.c: Update.
5839 * python/py-cmd.c: Update.
5840 * python/py-finishbreakpoint.c: Update.
5841 * python/py-frame.c: Update.
5842 * python/py-framefilter.c: Update.
5843 * python/py-gdb-readline.c: Update.
5844 * python/py-inferior.c: Update.
5845 * python/py-infthread.c: Update.
5846 * python/py-lazy-string.c: Update.
5847 * python/py-linetable.c: Update.
5848 * python/py-objfile.c: Update.
5849 * python/py-param.c: Update.
5850 * python/py-prettyprint.c: Update.
5851 * python/py-progspace.c: Update.
5852 * python/py-record-btrace.c: Update.
5853 * python/py-record.c: Update.
5854 * python/py-symbol.c: Update.
5855 * python/py-type.c: Update.
5856 * python/py-unwind.c: Update.
5857 * python/py-utils.c: Update.
5858 * python/py-value.c: Update.
5859 * python/python.c: Update.
5860 * record-btrace.c: Update.
5861 * record-full.c: Update.
5862 * remote-fileio.c: Update.
5863 * remote.c: Update.
5864 * riscv-tdep.c: Update.
5865 * rs6000-aix-tdep.c: Update.
5866 * rs6000-tdep.c: Update.
5867 * rust-exp.y: Update.
5868 * rust-lang.c: Update.
5869 * s390-tdep.c: Update.
5870 * selftest-arch.c: Update.
5871 * solib-dsbt.c: Update.
5872 * solib-frv.c: Update.
5873 * solib-spu.c: Update.
5874 * solib-svr4.c: Update.
5875 * solib.c: Update.
5876 * sparc64-linux-tdep.c: Update.
5877 * stack.c: Update.
5878 * symfile-mem.c: Update.
5879 * symmisc.c: Update.
5880 * target.c: Update.
5881 * thread.c: Update.
5882 * top.c: Update.
5883 * tracefile-tfile.c: Update.
5884 * tui/tui.c: Update.
5885 * typeprint.c: Update.
5886 * unittests/cli-utils-selftests.c: Update.
5887 * unittests/parse-connection-spec-selftests.c: Update.
5888 * valops.c: Update.
5889 * valprint.c: Update.
5890 * value.c: Update.
5891 * varobj.c: Update.
5892 * windows-nat.c: Update.
5893 * x86-linux-nat.c: Update.
5894 * xml-support.c: Update.
5895
a70b8144
TT
58962019-04-08 Tom Tromey <tom@tromey.com>
5897
5898 * xml-support.c: Use C++ exception handling.
5899 * x86-linux-nat.c: Use C++ exception handling.
5900 * windows-nat.c: Use C++ exception handling.
5901 * varobj.c: Use C++ exception handling.
5902 * value.c: Use C++ exception handling.
5903 * valprint.c: Use C++ exception handling.
5904 * valops.c: Use C++ exception handling.
5905 * unittests/parse-connection-spec-selftests.c: Use C++ exception
5906 handling.
5907 * unittests/cli-utils-selftests.c: Use C++ exception handling.
5908 * typeprint.c: Use C++ exception handling.
5909 * tui/tui.c: Use C++ exception handling.
5910 * tracefile-tfile.c: Use C++ exception handling.
5911 * top.c: Use C++ exception handling.
5912 * thread.c: Use C++ exception handling.
5913 * target.c: Use C++ exception handling.
5914 * symmisc.c: Use C++ exception handling.
5915 * symfile-mem.c: Use C++ exception handling.
5916 * stack.c: Use C++ exception handling.
5917 * sparc64-linux-tdep.c: Use C++ exception handling.
5918 * solib.c: Use C++ exception handling.
5919 * solib-svr4.c: Use C++ exception handling.
5920 * solib-spu.c: Use C++ exception handling.
5921 * solib-frv.c: Use C++ exception handling.
5922 * solib-dsbt.c: Use C++ exception handling.
5923 * selftest-arch.c: Use C++ exception handling.
5924 * s390-tdep.c: Use C++ exception handling.
5925 * rust-lang.c: Use C++ exception handling.
5926 * rust-exp.y: Use C++ exception handling.
5927 * rs6000-tdep.c: Use C++ exception handling.
5928 * rs6000-aix-tdep.c: Use C++ exception handling.
5929 * riscv-tdep.c: Use C++ exception handling.
5930 * remote.c: Use C++ exception handling.
5931 * remote-fileio.c: Use C++ exception handling.
5932 * record-full.c: Use C++ exception handling.
5933 * record-btrace.c: Use C++ exception handling.
5934 * python/python.c: Use C++ exception handling.
5935 * python/py-value.c: Use C++ exception handling.
5936 * python/py-utils.c: Use C++ exception handling.
5937 * python/py-unwind.c: Use C++ exception handling.
5938 * python/py-type.c: Use C++ exception handling.
5939 * python/py-symbol.c: Use C++ exception handling.
5940 * python/py-record.c: Use C++ exception handling.
5941 * python/py-record-btrace.c: Use C++ exception handling.
5942 * python/py-progspace.c: Use C++ exception handling.
5943 * python/py-prettyprint.c: Use C++ exception handling.
5944 * python/py-param.c: Use C++ exception handling.
5945 * python/py-objfile.c: Use C++ exception handling.
5946 * python/py-linetable.c: Use C++ exception handling.
5947 * python/py-lazy-string.c: Use C++ exception handling.
5948 * python/py-infthread.c: Use C++ exception handling.
5949 * python/py-inferior.c: Use C++ exception handling.
5950 * python/py-gdb-readline.c: Use C++ exception handling.
5951 * python/py-framefilter.c: Use C++ exception handling.
5952 * python/py-frame.c: Use C++ exception handling.
5953 * python/py-finishbreakpoint.c: Use C++ exception handling.
5954 * python/py-cmd.c: Use C++ exception handling.
5955 * python/py-breakpoint.c: Use C++ exception handling.
5956 * python/py-arch.c: Use C++ exception handling.
5957 * printcmd.c: Use C++ exception handling.
5958 * ppc-linux-tdep.c: Use C++ exception handling.
5959 * parse.c: Use C++ exception handling.
5960 * p-valprint.c: Use C++ exception handling.
5961 * objc-lang.c: Use C++ exception handling.
5962 * mi/mi-main.c: Use C++ exception handling.
5963 * mi/mi-interp.c: Use C++ exception handling.
5964 * mi/mi-cmd-stack.c: Use C++ exception handling.
5965 * mi/mi-cmd-break.c: Use C++ exception handling.
5966 * main.c: Use C++ exception handling.
5967 * linux-thread-db.c: Use C++ exception handling.
5968 * linux-tdep.c: Use C++ exception handling.
5969 * linux-nat.c: Use C++ exception handling.
5970 * linux-fork.c: Use C++ exception handling.
5971 * linespec.c: Use C++ exception handling.
5972 * language.c: Use C++ exception handling.
5973 * jit.c: Use C++ exception handling.
5974 * infrun.c: Use C++ exception handling.
5975 * infcmd.c: Use C++ exception handling.
5976 * infcall.c: Use C++ exception handling.
5977 * inf-loop.c: Use C++ exception handling.
5978 * i386-tdep.c: Use C++ exception handling.
5979 * i386-linux-tdep.c: Use C++ exception handling.
5980 * guile/scm-value.c: Use C++ exception handling.
5981 * guile/scm-type.c: Use C++ exception handling.
5982 * guile/scm-symtab.c: Use C++ exception handling.
5983 * guile/scm-symbol.c: Use C++ exception handling.
5984 * guile/scm-pretty-print.c: Use C++ exception handling.
5985 * guile/scm-ports.c: Use C++ exception handling.
5986 * guile/scm-param.c: Use C++ exception handling.
5987 * guile/scm-math.c: Use C++ exception handling.
5988 * guile/scm-lazy-string.c: Use C++ exception handling.
5989 * guile/scm-frame.c: Use C++ exception handling.
5990 * guile/scm-disasm.c: Use C++ exception handling.
5991 * guile/scm-cmd.c: Use C++ exception handling.
5992 * guile/scm-breakpoint.c: Use C++ exception handling.
5993 * guile/scm-block.c: Use C++ exception handling.
5994 * guile/guile-internal.h: Use C++ exception handling.
5995 * gnu-v3-abi.c: Use C++ exception handling.
5996 * gdbtypes.c: Use C++ exception handling.
5997 * frame.c: Use C++ exception handling.
5998 * frame-unwind.c: Use C++ exception handling.
5999 * fbsd-tdep.c: Use C++ exception handling.
6000 * f-valprint.c: Use C++ exception handling.
6001 * exec.c: Use C++ exception handling.
6002 * event-top.c: Use C++ exception handling.
6003 * event-loop.c: Use C++ exception handling.
6004 * eval.c: Use C++ exception handling.
6005 * dwarf2read.c: Use C++ exception handling.
6006 * dwarf2loc.c: Use C++ exception handling.
6007 * dwarf2-frame.c: Use C++ exception handling.
6008 * dwarf2-frame-tailcall.c: Use C++ exception handling.
6009 * dwarf-index-write.c: Use C++ exception handling.
6010 * dwarf-index-cache.c: Use C++ exception handling.
6011 * dtrace-probe.c: Use C++ exception handling.
6012 * disasm-selftests.c: Use C++ exception handling.
6013 * darwin-nat.c: Use C++ exception handling.
6014 * cp-valprint.c: Use C++ exception handling.
6015 * cp-support.c: Use C++ exception handling.
6016 * cp-abi.c: Use C++ exception handling.
6017 * corelow.c: Use C++ exception handling.
6018 * completer.c: Use C++ exception handling.
6019 * compile/compile-object-run.c: Use C++ exception handling.
6020 * compile/compile-object-load.c: Use C++ exception handling.
6021 * compile/compile-cplus-symbols.c: Use C++ exception handling.
6022 * compile/compile-c-symbols.c: Use C++ exception handling.
6023 * common/selftest.c: Use C++ exception handling.
6024 * common/new-op.c: Use C++ exception handling.
6025 * cli/cli-script.c: Use C++ exception handling.
6026 * cli/cli-interp.c: Use C++ exception handling.
6027 * cli/cli-cmds.c: Use C++ exception handling.
6028 * c-varobj.c: Use C++ exception handling.
6029 * btrace.c: Use C++ exception handling.
6030 * breakpoint.c: Use C++ exception handling.
6031 * break-catch-throw.c: Use C++ exception handling.
6032 * arch-utils.c: Use C++ exception handling.
6033 * amd64-tdep.c: Use C++ exception handling.
6034 * ada-valprint.c: Use C++ exception handling.
6035 * ada-typeprint.c: Use C++ exception handling.
6036 * ada-lang.c: Use C++ exception handling.
6037 * aarch64-tdep.c: Use C++ exception handling.
6038
3d6e9d23
TT
60392019-04-08 Tom Tromey <tom@tromey.com>
6040
6041 * xml-support.c (gdb_xml_parser::parse): Update.
6042 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6043 * value.c (show_convenience): Update.
6044 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6045 (test_parse_flags_qcs): Update.
6046 * thread.c (thr_try_catch_cmd): Update.
6047 * target.c (target_translate_tls_address): Update.
6048 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6049 (info_frame_command_core, frame_apply_command_count): Update.
6050 * rust-exp.y (rust_lex_exception_test): Update.
6051 * riscv-tdep.c (riscv_print_one_register_info): Update.
6052 * remote.c (remote_target::enable_btrace): Update.
6053 * record-btrace.c (record_btrace_enable_warn): Update.
6054 * python/py-utils.c (gdbpy_convert_exception): Update.
6055 * printcmd.c (do_one_display, print_variable_and_value): Update.
6056 * mi/mi-main.c (mi_print_exception): Update.
6057 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6058 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6059 * linux-nat.c (linux_nat_target::attach): Update.
6060 * linux-fork.c (class scoped_switch_fork_info): Update.
6061 * infrun.c (displaced_step_prepare): Update.
6062 * infcall.c (call_function_by_hand_dummy): Update.
6063 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6064 * gnu-v3-abi.c (print_one_vtable): Update.
6065 * frame.c (get_prev_frame_always): Update.
6066 * f-valprint.c (info_common_command_for_block): Update.
6067 * exec.c (try_open_exec_file): Update.
6068 * exceptions.c (print_exception, exception_print)
6069 (exception_fprintf, exception_print_same): Update.
6070 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6071 * dwarf-index-cache.c (index_cache::store)
6072 (index_cache::lookup_gdb_index): Update.
6073 * darwin-nat.c (maybe_cache_shell): Update.
6074 * cp-valprint.c (cp_print_value_fields): Update.
6075 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6076 (gcc_cplus_symbol_address): Update.
6077 * compile/compile-c-symbols.c (gcc_convert_symbol)
6078 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6079 * common/selftest.c: Update.
6080 * common/common-exceptions.h (struct gdb_exception) <message>: Now
6081 a std::string.
6082 (exception_try_scope_entry, exception_try_scope_exit): Don't
6083 declare.
6084 (struct exception_try_scope): Remove.
6085 (TRY): Don't use exception_try_scope.
6086 (struct gdb_exception): Add constructor, operator=.
6087 <what>: New method.
6088 (struct gdb_exception_RETURN_MASK_ALL)
6089 (struct gdb_exception_RETURN_MASK_ERROR)
6090 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6091 (struct gdb_quit_bad_alloc): Update.
6092 * common/common-exceptions.c (exception_none): Change
6093 initializer.
6094 (struct catcher) <state, exception>: Initialize inline.
6095 <prev>: Remove member.
6096 (current_catcher): Remove.
6097 (catchers): New global.
6098 (exceptions_state_mc_init): Simplify.
6099 (catcher_pop): Remove.
6100 (exceptions_state_mc, exceptions_state_mc_catch): Update.
6101 (try_scope_depth, exception_try_scope_entry)
6102 (exception_try_scope_exit): Remove.
6103 (throw_exception_sjlj): Update.
6104 (exception_messages, exception_messages_size): Remove.
6105 (throw_it): Simplify.
6106 (gdb_exception_sliced_copy): Remove.
6107 (throw_exception_cxx): Update.
6108 * cli/cli-script.c (script_from_file): Update.
6109 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6110 Update.
6111 * ada-valprint.c (ada_val_print): Update.
6112 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6113 (create_excep_cond_exprs): Update.
6114
c5c10118
TT
61152019-04-08 Tom Tromey <tom@tromey.com>
6116
6117 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6118 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6119 (TRY, CATCH, END_CATCH): Remove some definitions.
6120 * common/common-exceptions.c: Don't use GDB_XCPT.
6121 (catcher_list_size): Remove.
6122 (throw_exception, throw_it): Simplify.
6123
4de283e4
TT
61242019-04-05 Tom Tromey <tom@tromey.com>
6125
6126 Revert the header-sorting patch.
6127 * ft32-tdep.c: Revert.
6128 * frv-tdep.c: Revert.
6129 * frv-linux-tdep.c: Revert.
6130 * frame.c: Revert.
6131 * frame-unwind.c: Revert.
6132 * frame-base.c: Revert.
6133 * fork-child.c: Revert.
6134 * findvar.c: Revert.
6135 * findcmd.c: Revert.
6136 * filesystem.c: Revert.
6137 * filename-seen-cache.h: Revert.
6138 * filename-seen-cache.c: Revert.
6139 * fbsd-tdep.c: Revert.
6140 * fbsd-nat.h: Revert.
6141 * fbsd-nat.c: Revert.
6142 * f-valprint.c: Revert.
6143 * f-typeprint.c: Revert.
6144 * f-lang.c: Revert.
6145 * extension.h: Revert.
6146 * extension.c: Revert.
6147 * extension-priv.h: Revert.
6148 * expprint.c: Revert.
6149 * exec.h: Revert.
6150 * exec.c: Revert.
6151 * exceptions.c: Revert.
6152 * event-top.c: Revert.
6153 * event-loop.c: Revert.
6154 * eval.c: Revert.
6155 * elfread.c: Revert.
6156 * dwarf2read.h: Revert.
6157 * dwarf2read.c: Revert.
6158 * dwarf2loc.c: Revert.
6159 * dwarf2expr.h: Revert.
6160 * dwarf2expr.c: Revert.
6161 * dwarf2-frame.c: Revert.
6162 * dwarf2-frame-tailcall.c: Revert.
6163 * dwarf-index-write.h: Revert.
6164 * dwarf-index-write.c: Revert.
6165 * dwarf-index-common.c: Revert.
6166 * dwarf-index-cache.h: Revert.
6167 * dwarf-index-cache.c: Revert.
6168 * dummy-frame.c: Revert.
6169 * dtrace-probe.c: Revert.
6170 * disasm.h: Revert.
6171 * disasm.c: Revert.
6172 * disasm-selftests.c: Revert.
6173 * dictionary.c: Revert.
6174 * dicos-tdep.c: Revert.
6175 * demangle.c: Revert.
6176 * dcache.h: Revert.
6177 * dcache.c: Revert.
6178 * darwin-nat.h: Revert.
6179 * darwin-nat.c: Revert.
6180 * darwin-nat-info.c: Revert.
6181 * d-valprint.c: Revert.
6182 * d-namespace.c: Revert.
6183 * d-lang.c: Revert.
6184 * ctf.c: Revert.
6185 * csky-tdep.c: Revert.
6186 * csky-linux-tdep.c: Revert.
6187 * cris-tdep.c: Revert.
6188 * cris-linux-tdep.c: Revert.
6189 * cp-valprint.c: Revert.
6190 * cp-support.c: Revert.
6191 * cp-namespace.c: Revert.
6192 * cp-abi.c: Revert.
6193 * corelow.c: Revert.
6194 * corefile.c: Revert.
6195 * continuations.c: Revert.
6196 * completer.h: Revert.
6197 * completer.c: Revert.
6198 * complaints.c: Revert.
6199 * coffread.c: Revert.
6200 * coff-pe-read.c: Revert.
6201 * cli-out.h: Revert.
6202 * cli-out.c: Revert.
6203 * charset.c: Revert.
6204 * c-varobj.c: Revert.
6205 * c-valprint.c: Revert.
6206 * c-typeprint.c: Revert.
6207 * c-lang.c: Revert.
6208 * buildsym.c: Revert.
6209 * buildsym-legacy.c: Revert.
6210 * build-id.h: Revert.
6211 * build-id.c: Revert.
6212 * btrace.c: Revert.
6213 * bsd-uthread.c: Revert.
6214 * breakpoint.h: Revert.
6215 * breakpoint.c: Revert.
6216 * break-catch-throw.c: Revert.
6217 * break-catch-syscall.c: Revert.
6218 * break-catch-sig.c: Revert.
6219 * blockframe.c: Revert.
6220 * block.c: Revert.
6221 * bfin-tdep.c: Revert.
6222 * bfin-linux-tdep.c: Revert.
6223 * bfd-target.c: Revert.
6224 * bcache.c: Revert.
6225 * ax-general.c: Revert.
6226 * ax-gdb.h: Revert.
6227 * ax-gdb.c: Revert.
6228 * avr-tdep.c: Revert.
6229 * auxv.c: Revert.
6230 * auto-load.c: Revert.
6231 * arm-wince-tdep.c: Revert.
6232 * arm-tdep.c: Revert.
6233 * arm-symbian-tdep.c: Revert.
6234 * arm-pikeos-tdep.c: Revert.
6235 * arm-obsd-tdep.c: Revert.
6236 * arm-nbsd-tdep.c: Revert.
6237 * arm-nbsd-nat.c: Revert.
6238 * arm-linux-tdep.c: Revert.
6239 * arm-linux-nat.c: Revert.
6240 * arm-fbsd-tdep.c: Revert.
6241 * arm-fbsd-nat.c: Revert.
6242 * arm-bsd-tdep.c: Revert.
6243 * arch-utils.c: Revert.
6244 * arc-tdep.c: Revert.
6245 * arc-newlib-tdep.c: Revert.
6246 * annotate.h: Revert.
6247 * annotate.c: Revert.
6248 * amd64-windows-tdep.c: Revert.
6249 * amd64-windows-nat.c: Revert.
6250 * amd64-tdep.c: Revert.
6251 * amd64-sol2-tdep.c: Revert.
6252 * amd64-obsd-tdep.c: Revert.
6253 * amd64-obsd-nat.c: Revert.
6254 * amd64-nbsd-tdep.c: Revert.
6255 * amd64-nbsd-nat.c: Revert.
6256 * amd64-nat.c: Revert.
6257 * amd64-linux-tdep.c: Revert.
6258 * amd64-linux-nat.c: Revert.
6259 * amd64-fbsd-tdep.c: Revert.
6260 * amd64-fbsd-nat.c: Revert.
6261 * amd64-dicos-tdep.c: Revert.
6262 * amd64-darwin-tdep.c: Revert.
6263 * amd64-bsd-nat.c: Revert.
6264 * alpha-tdep.c: Revert.
6265 * alpha-obsd-tdep.c: Revert.
6266 * alpha-nbsd-tdep.c: Revert.
6267 * alpha-mdebug-tdep.c: Revert.
6268 * alpha-linux-tdep.c: Revert.
6269 * alpha-linux-nat.c: Revert.
6270 * alpha-bsd-tdep.c: Revert.
6271 * alpha-bsd-nat.c: Revert.
6272 * aix-thread.c: Revert.
6273 * agent.c: Revert.
6274 * addrmap.c: Revert.
6275 * ada-varobj.c: Revert.
6276 * ada-valprint.c: Revert.
6277 * ada-typeprint.c: Revert.
6278 * ada-tasks.c: Revert.
6279 * ada-lang.c: Revert.
6280 * aarch64-tdep.c: Revert.
6281 * aarch64-ravenscar-thread.c: Revert.
6282 * aarch64-newlib-tdep.c: Revert.
6283 * aarch64-linux-tdep.c: Revert.
6284 * aarch64-linux-nat.c: Revert.
6285 * aarch64-fbsd-tdep.c: Revert.
6286 * aarch64-fbsd-nat.c: Revert.
6287 * aarch32-linux-nat.c: Revert.
6288
d55e5aa6
TT
62892019-04-05 Tom Tromey <tom@tromey.com>
6290
6291 * ft32-tdep.c: Sort headers.
6292 * frv-tdep.c: Sort headers.
6293 * frv-linux-tdep.c: Sort headers.
6294 * frame.c: Sort headers.
6295 * frame-unwind.c: Sort headers.
6296 * frame-base.c: Sort headers.
6297 * fork-child.c: Sort headers.
6298 * findvar.c: Sort headers.
6299 * findcmd.c: Sort headers.
6300 * filesystem.c: Sort headers.
6301 * filename-seen-cache.h: Sort headers.
6302 * filename-seen-cache.c: Sort headers.
6303 * fbsd-tdep.c: Sort headers.
6304 * fbsd-nat.h: Sort headers.
6305 * fbsd-nat.c: Sort headers.
6306 * f-valprint.c: Sort headers.
6307 * f-typeprint.c: Sort headers.
6308 * f-lang.c: Sort headers.
6309 * extension.h: Sort headers.
6310 * extension.c: Sort headers.
6311 * extension-priv.h: Sort headers.
6312 * expprint.c: Sort headers.
6313 * exec.h: Sort headers.
6314 * exec.c: Sort headers.
6315 * exceptions.c: Sort headers.
6316 * event-top.c: Sort headers.
6317 * event-loop.c: Sort headers.
6318 * eval.c: Sort headers.
6319 * elfread.c: Sort headers.
6320 * dwarf2read.h: Sort headers.
6321 * dwarf2read.c: Sort headers.
6322 * dwarf2loc.c: Sort headers.
6323 * dwarf2expr.h: Sort headers.
6324 * dwarf2expr.c: Sort headers.
6325 * dwarf2-frame.c: Sort headers.
6326 * dwarf2-frame-tailcall.c: Sort headers.
6327 * dwarf-index-write.h: Sort headers.
6328 * dwarf-index-write.c: Sort headers.
6329 * dwarf-index-common.c: Sort headers.
6330 * dwarf-index-cache.h: Sort headers.
6331 * dwarf-index-cache.c: Sort headers.
6332 * dummy-frame.c: Sort headers.
6333 * dtrace-probe.c: Sort headers.
6334 * disasm.h: Sort headers.
6335 * disasm.c: Sort headers.
6336 * disasm-selftests.c: Sort headers.
6337 * dictionary.c: Sort headers.
6338 * dicos-tdep.c: Sort headers.
6339 * demangle.c: Sort headers.
6340 * dcache.h: Sort headers.
6341 * dcache.c: Sort headers.
6342 * darwin-nat.h: Sort headers.
6343 * darwin-nat.c: Sort headers.
6344 * darwin-nat-info.c: Sort headers.
6345 * d-valprint.c: Sort headers.
6346 * d-namespace.c: Sort headers.
6347 * d-lang.c: Sort headers.
6348 * ctf.c: Sort headers.
6349 * csky-tdep.c: Sort headers.
6350 * csky-linux-tdep.c: Sort headers.
6351 * cris-tdep.c: Sort headers.
6352 * cris-linux-tdep.c: Sort headers.
6353 * cp-valprint.c: Sort headers.
6354 * cp-support.c: Sort headers.
6355 * cp-namespace.c: Sort headers.
6356 * cp-abi.c: Sort headers.
6357 * corelow.c: Sort headers.
6358 * corefile.c: Sort headers.
6359 * continuations.c: Sort headers.
6360 * completer.h: Sort headers.
6361 * completer.c: Sort headers.
6362 * complaints.c: Sort headers.
6363 * coffread.c: Sort headers.
6364 * coff-pe-read.c: Sort headers.
6365 * cli-out.h: Sort headers.
6366 * cli-out.c: Sort headers.
6367 * charset.c: Sort headers.
6368 * c-varobj.c: Sort headers.
6369 * c-valprint.c: Sort headers.
6370 * c-typeprint.c: Sort headers.
6371 * c-lang.c: Sort headers.
6372 * buildsym.c: Sort headers.
6373 * buildsym-legacy.c: Sort headers.
6374 * build-id.h: Sort headers.
6375 * build-id.c: Sort headers.
6376 * btrace.c: Sort headers.
6377 * bsd-uthread.c: Sort headers.
6378 * breakpoint.h: Sort headers.
6379 * breakpoint.c: Sort headers.
6380 * break-catch-throw.c: Sort headers.
6381 * break-catch-syscall.c: Sort headers.
6382 * break-catch-sig.c: Sort headers.
6383 * blockframe.c: Sort headers.
6384 * block.c: Sort headers.
6385 * bfin-tdep.c: Sort headers.
6386 * bfin-linux-tdep.c: Sort headers.
6387 * bfd-target.c: Sort headers.
6388 * bcache.c: Sort headers.
6389 * ax-general.c: Sort headers.
6390 * ax-gdb.h: Sort headers.
6391 * ax-gdb.c: Sort headers.
6392 * avr-tdep.c: Sort headers.
6393 * auxv.c: Sort headers.
6394 * auto-load.c: Sort headers.
6395 * arm-wince-tdep.c: Sort headers.
6396 * arm-tdep.c: Sort headers.
6397 * arm-symbian-tdep.c: Sort headers.
6398 * arm-pikeos-tdep.c: Sort headers.
6399 * arm-obsd-tdep.c: Sort headers.
6400 * arm-nbsd-tdep.c: Sort headers.
6401 * arm-nbsd-nat.c: Sort headers.
6402 * arm-linux-tdep.c: Sort headers.
6403 * arm-linux-nat.c: Sort headers.
6404 * arm-fbsd-tdep.c: Sort headers.
6405 * arm-fbsd-nat.c: Sort headers.
6406 * arm-bsd-tdep.c: Sort headers.
6407 * arch-utils.c: Sort headers.
6408 * arc-tdep.c: Sort headers.
6409 * arc-newlib-tdep.c: Sort headers.
6410 * annotate.h: Sort headers.
6411 * annotate.c: Sort headers.
6412 * amd64-windows-tdep.c: Sort headers.
6413 * amd64-windows-nat.c: Sort headers.
6414 * amd64-tdep.c: Sort headers.
6415 * amd64-sol2-tdep.c: Sort headers.
6416 * amd64-obsd-tdep.c: Sort headers.
6417 * amd64-obsd-nat.c: Sort headers.
6418 * amd64-nbsd-tdep.c: Sort headers.
6419 * amd64-nbsd-nat.c: Sort headers.
6420 * amd64-nat.c: Sort headers.
6421 * amd64-linux-tdep.c: Sort headers.
6422 * amd64-linux-nat.c: Sort headers.
6423 * amd64-fbsd-tdep.c: Sort headers.
6424 * amd64-fbsd-nat.c: Sort headers.
6425 * amd64-dicos-tdep.c: Sort headers.
6426 * amd64-darwin-tdep.c: Sort headers.
6427 * amd64-bsd-nat.c: Sort headers.
6428 * alpha-tdep.c: Sort headers.
6429 * alpha-obsd-tdep.c: Sort headers.
6430 * alpha-nbsd-tdep.c: Sort headers.
6431 * alpha-mdebug-tdep.c: Sort headers.
6432 * alpha-linux-tdep.c: Sort headers.
6433 * alpha-linux-nat.c: Sort headers.
6434 * alpha-bsd-tdep.c: Sort headers.
6435 * alpha-bsd-nat.c: Sort headers.
6436 * aix-thread.c: Sort headers.
6437 * agent.c: Sort headers.
6438 * addrmap.c: Sort headers.
6439 * ada-varobj.c: Sort headers.
6440 * ada-valprint.c: Sort headers.
6441 * ada-typeprint.c: Sort headers.
6442 * ada-tasks.c: Sort headers.
6443 * ada-lang.c: Sort headers.
6444 * aarch64-tdep.c: Sort headers.
6445 * aarch64-ravenscar-thread.c: Sort headers.
6446 * aarch64-newlib-tdep.c: Sort headers.
6447 * aarch64-linux-tdep.c: Sort headers.
6448 * aarch64-linux-nat.c: Sort headers.
6449 * aarch64-fbsd-tdep.c: Sort headers.
6450 * aarch64-fbsd-nat.c: Sort headers.
6451 * aarch32-linux-nat.c: Sort headers.
6452
699bd4cf
TT
64532019-04-04 Tom Tromey <tom@tromey.com>
6454
6455 * varobj.c (varobj_create): Update.
6456 * rust-exp.y (struct rust_parser) <update_innermost_block,
6457 lookup_symbol>: New methods.
6458 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6459 Rename.
6460 (rust_parser::rust_lookup_type)
6461 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6462 * printcmd.c (display_command, do_one_display): Update.
6463 * parser-defs.h (struct parser_state) <parser_state>: Add
6464 "tracker" parameter.
6465 (block_tracker): New member.
6466 (class innermost_block_tracker) <innermost_block_tracker>: Add
6467 "types" parameter.
6468 <reset>: Remove method.
6469 (innermost_block): Don't declare.
6470 (null_post_parser): Update.
6471 * parse.c (innermost_block): Remove global.
6472 (write_dollar_variable): Update.
6473 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6474 Remove "tracker_types" parameter.
6475 (parse_expression): Add "tracker" parameter.
6476 (parse_expression_for_completion): Update.
6477 (null_post_parser): Add "tracker" parameter.
6478 * p-exp.y: Update rules.
6479 * m2-exp.y: Update rules.
6480 * language.h (struct language_defn) <la_post_parser>: Add
6481 "tracker" parameter.
6482 * go-exp.y: Update rules.
6483 * f-exp.y: Update rules.
6484 * expression.h (parse_expression, parse_exp_1): Add "tracker"
6485 parameter.
6486 * d-exp.y: Update rules.
6487 * c-exp.y: Update rules.
6488 * breakpoint.c (set_breakpoint_condition): Create an
6489 innermost_block_tracker.
6490 (watch_command_1): Likewise.
6491 * ada-lang.c (resolve): Add "tracker" parameter.
6492 (resolve_subexp): Likewise.
6493 * ada-exp.y (write_var_from_sym): Update.
6494
dac43e32
TT
64952019-04-04 Tom Tromey <tom@tromey.com>
6496
6497 * type-stack.h: New file.
6498 * type-stack.c: New file.
6499 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6500 type-stack.h.
6501 (insert_into_type_stack, insert_type, push_type, push_type_int)
6502 (insert_type_address_space, pop_type, pop_type_int)
6503 (pop_typelist, pop_type_stack, append_type_stack)
6504 (push_type_stack, get_type_stack, push_typelist)
6505 (follow_type_instance_flags, follow_types): Don't declare.
6506 * parse.c (type_stack): Remove global.
6507 (parse_exp_in_context): Update.
6508 (insert_into_type_stack, insert_type, push_type, push_type_int)
6509 (insert_type_address_space, pop_type, pop_type_int)
6510 (pop_typelist, pop_type_stack, append_type_stack)
6511 (push_type_stack, get_type_stack, push_typelist)
6512 (follow_type_instance_flags, follow_types): Remove (moved to
6513 type-stack.c).
6514 * f-exp.y (type_stack): New global.
6515 Update rules.
6516 (push_kind_type, f_parse): Update.
6517 * d-exp.y (type_stack): New global.
6518 Update rules.
6519 (d_parse): Update.
6520 * c-exp.y (struct c_parse_state) <type_stack>: New member.
6521 Update rules.
6522 * Makefile.in (COMMON_SFILES): Add type-stack.c.
6523 (HFILES_NO_SRCDIR): Add type-stack.h.
6524
2a612529
TT
65252019-04-04 Tom Tromey <tom@tromey.com>
6526
6527 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6528 (rust_parser::convert_ast_to_expression, rust_parse)
6529 (rust_lex_test_completion, rust_lex_tests): Update.
6530 * parser-defs.h (struct expr_completion_state): New.
6531 (struct parser_state) <parser_state>: Add completion parameter.
6532 <mark_struct_expression, mark_completion_tag>: New methods.
6533 <parse_completion, m_completion_state>: New members.
6534 (prefixify_expression, null_post_parser): Update.
6535 (mark_struct_expression, mark_completion_tag): Don't declare.
6536 * parse.c (parse_completion, expout_last_struct)
6537 (expout_tag_completion_type, expout_completion_name): Remove
6538 globals.
6539 (parser_state::mark_struct_expression)
6540 (parser_state::mark_completion_tag): Now methods.
6541 (prefixify_expression): Add last_struct parameter.
6542 (prefixify_subexp): Likewise.
6543 (parse_exp_1): Update.
6544 (parse_exp_in_context): Add cstate parameter. Update.
6545 (parse_expression_for_completion): Create an
6546 expr_completion_state.
6547 (null_post_parser): Add "completion" parameter.
6548 * p-exp.y: Update rules.
6549 (yylex): Update.
6550 * language.h (struct language_defn) <la_post_parser>: Add
6551 "completing" parameter.
6552 * go-exp.y: Update rules.
6553 (lex_one_token): Update.
6554 * expression.h (parse_completion): Don't declare.
6555 * d-exp.y: Update rules.
6556 (lex_one_token): Update rules.
6557 * c-exp.y: Update rules.
6558 (lex_one_token): Update.
6559 * ada-lang.c (resolve): Add "parse_completion" parameter.
6560 (resolve_subexp): Likewise.
6561 (ada_resolve_function): Likewise.
6562
43476f0b
TT
65632019-04-04 Tom Tromey <tom@tromey.com>
6564
6565 * parser-defs.h (struct parser_state) <start_arglist,
6566 end_arglist>: New methods.
6567 <arglist_len, m_funcall_chain>: New members.
6568 (arglist_len, start_arglist, end_arglist): Don't declare.
6569 * parse.c (arglist_len, funcall_chain): Remove global.
6570 (start_arglist, end_arglist): Remove functions.
6571 (parse_exp_in_context): Update.
6572 * p-exp.y: Update rules.
6573 * m2-exp.y: Update rules.
6574 * go-exp.y: Update rules.
6575 * f-exp.y: Update rules.
6576 * d-exp.y: Update rules.
6577 * c-exp.y: Update rules.
6578
5776fca3
TT
65792019-04-04 Tom Tromey <tom@tromey.com>
6580
6581 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6582 lex_operator, push_back>: New methods.
6583 Update all rules.
6584 (rust_parser::lex_hex, lex_escape): Rename and update.
6585 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6586 (rust_parser::lex_operator): Rename and update.
6587 (rust_parser::lex_number, rustyylex, rustyyerror)
6588 (rust_lex_test_init, rust_lex_test_sequence)
6589 (rust_lex_test_push_back, rust_lex_tests): Update.
6590 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6591 parameter.
6592 <lexptr, prev_lexptr>: New members.
6593 (lexptr, prev_lexptr): Don't declare.
6594 * parse.c (lexptr, prev_lexptr): Remove globals.
6595 (parse_exp_in_context): Update.
6596 * p-exp.y (yylex, yyerror): Update.
6597 * m2-exp.y (parse_number, yylex, yyerror): Update.
6598 * go-exp.y (lex_one_token, yyerror): Update.
6599 * f-exp.y (match_string_literal, yylex, yyerror): Update.
6600 * d-exp.y (lex_one_token, yyerror): Update.
6601 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6602 (lex_one_token, yyerror): Update.
6603 * ada-lex.l (YY_INPUT): Update.
6604 (rewind_to_char): Update.
6605 * ada-exp.y (yyerror): Update.
6606
8621b685
TT
66072019-04-04 Tom Tromey <tom@tromey.com>
6608
6609 * rust-exp.y (rustyylex, rust_lex_tests): Update.
6610 * parser-defs.h (struct parser_state) <parser_state>: Add new
6611 parameter.
6612 <comma_terminates>: New member.
6613 (comma_terminates): Don't declare global.
6614 * parse.c (comma_terminates): Remove global.
6615 (parse_exp_in_context): Update.
6616 * p-exp.y (yylex): Update.
6617 * m2-exp.y (yylex): Update.
6618 * go-exp.y (lex_one_token): Update.
6619 * f-exp.y (yylex): Update.
6620 * d-exp.y (lex_one_token): Update.
6621 * c-exp.y (lex_one_token): Update.
6622 * ada-lex.l: Update.
6623
28aaf3fd
TT
66242019-04-04 Tom Tromey <tom@tromey.com>
6625
6626 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6627 (rustyylex, rust_lex_test_init, rust_lex_test_one)
6628 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6629 * parser-defs.h (paren_depth): Don't declare.
6630 * parse.c (paren_depth): Remove global.
6631 (parse_exp_in_context): Update.
6632 * p-exp.y (paren_depth): New global.
6633 (pascal_parse): Initialize it.
6634 * m2-exp.y (paren_depth): New global.
6635 (m2_parse): Initialize it.
6636 * go-exp.y (paren_depth): New global.
6637 (go_parse): Initialize it.
6638 * f-exp.y (paren_depth): New global.
6639 (f_parse): Initialize it.
6640 * d-exp.y (paren_depth): New global.
6641 (d_parse): Initialize it.
6642 * c-exp.y (paren_depth): New global.
6643 (c_parse): Initialize it.
6644 * ada-lex.l (paren_depth): New global.
6645 (lexer_init): Initialize it.
6646
1e58a4a4
TT
66472019-04-04 Tom Tromey <tom@tromey.com>
6648
6649 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6650 (rust_parser::convert_ast_to_type)
6651 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6652 * parser-defs.h (struct parser_state) <parser_state>: Add
6653 parameters. Initialize new members.
6654 <expression_context_block, expression_context_pc>: New members.
6655 * parse.c (expression_context_block, expression_context_pc):
6656 Remove globals.
6657 (parse_exp_in_context): Update.
6658 * p-exp.y: Update all rules.
6659 (yylex): Update.
6660 * m2-exp.y: Update all rules.
6661 (yylex): Update.
6662 * go-exp.y (yylex): Update.
6663 * f-exp.y (yylex): Update.
6664 * d-exp.y: Update all rules.
6665 (yylex): Update.
6666 * c-exp.y: Update all rules.
6667 (lex_one_token, classify_name, yylex, c_parse): Update.
6668 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6669
37eedb39
TT
66702019-04-04 Tom Tromey <tom@tromey.com>
6671
6672 * gdbarch.h, gdbarch.c: Rebuild.
6673 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6674 * stap-probe.h:
6675 (struct stap_parse_info): Replace "parser_state" with
6676 "expr_builder".
6677 * parser-defs.h (struct expr_builder): Rename from "parser_state".
6678 (parser_state): New class.
6679 * parse.c (expr_builder): Rename.
6680 (expr_builder::release): Rename.
6681 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6682 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6683 (write_exp_elt_longcst, write_exp_elt_floatcst)
6684 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6685 (write_exp_string_vector, write_exp_bitstring)
6686 (write_exp_msymbol, mark_struct_expression)
6687 (write_dollar_variable)
6688 (insert_type_address_space, increase_expout_size): Replace
6689 "parser_state" with "expr_builder".
6690 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6691 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6692 "parser_state" with "expr_builder".
6693
73923d7e
TT
66942019-04-04 Tom Tromey <tom@tromey.com>
6695
6696 * rust-exp.y: Replace "parse_language" with method call.
6697 * p-exp.y:
6698 (yylex): Replace "parse_language" with method call.
6699 * m2-exp.y:
6700 (yylex): Replace "parse_language" with method call.
6701 * go-exp.y (classify_name): Replace "parse_language" with method
6702 call.
6703 * f-exp.y (yylex): Replace "parse_language" with method call.
6704 * d-exp.y (lex_one_token): Replace "parse_language" with method
6705 call.
6706 * c-exp.y:
6707 (lex_one_token, classify_name, yylex): Replace "parse_language"
6708 with method call.
6709 * ada-exp.y (find_primitive_type, type_char)
6710 (type_system_address): Replace "parse_language" with method call.
6711
fa9f5be6
TT
67122019-04-04 Tom Tromey <tom@tromey.com>
6713
6714 * rust-exp.y: Replace "parse_gdbarch" with method call.
6715 * parse.c (write_dollar_variable, insert_type_address_space):
6716 Replace "parse_gdbarch" with method call.
6717 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6718 call.
6719 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6720 call.
6721 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6722 "parse_gdbarch" with method call.
6723 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6724 with method call.
6725 * f-exp.y (parse_type, parse_f_type, yylex): Replace
6726 "parse_gdbarch" with method call.
6727 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6728 "parse_gdbarch" with method call.
6729 * c-exp.y (parse_type, parse_number, classify_name): Replace
6730 "parse_gdbarch" with method call.
6731 * ada-lex.l: Replace "parse_gdbarch" with method call.
6732 * ada-exp.y (parse_type, find_primitive_type, type_char)
6733 (type_system_address): Replace "parse_gdbarch" with method call.
6734
1201a264
TT
67352019-04-04 Tom Tromey <tom@tromey.com>
6736
6737 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6738 * stap-probe.c (stap_parse_argument): Update.
6739 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6740 initial_size parameter.
6741 * rust-exp.y (rust_lex_tests): Update.
6742 * parse.c (parser_state): Update.
6743 (parse_exp_in_context): Update.
6744 * parser-defs.h (struct parser_state) <parser_state>: Remove
6745 "initial_size" parameter.
6746
e3980ce2
TT
67472019-04-04 Tom Tromey <tom@tromey.com>
6748
6749 * parser-defs.h (increase_expout_size): Don't declare.
6750 * parse.c (increase_expout_size): Now static.
6751
e9f8e3f1
TS
67522019-04-04 Thomas Schwinge <thomas@codesourcery.com>
6753
6754 * gnu-nat.c (gnu_nat_target::wait): Fix
6755 target_waitstatus_to_string call.
6756
d7df6549
AB
67572019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
6758
6759 * eval.c (evaluate_subexp_standard): Handle internal functions
6760 during Fortran function call handling.
6761
8bdc1658
AB
67622019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
6763
6764 * NEWS: Mention new internal functions.
6765 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6766 (read_base_type): Use dwarf2_init_complex_target_type.
6767 * value.c (creal_internal_fn): New function.
6768 (cimag_internal_fn): New function.
6769 (_initialize_values): Register new internal functions.
6770
c29705b7
PW
67712019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6772
6773 * infrun.c (stop_all_threads): If debug_infrun, always
6774 trace the wait status after wait_one, using
6775 target_waitstatus_to_string and target_pid_to_str.
6776 (handle_inferior_event): Replace various trace of
6777 wait status kind by a single trace.
6778 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6779 wait status kind image by target_waitstatus_to_string.
6780 * target/waitstatus.c (target_waitstatus_to_string): Fix
6781 obsolete comment.
6782
05caa1d2
TT
67832019-04-01 Tom Tromey <tromey@adacore.com>
6784
6785 PR symtab/23331:
6786 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6787
9d1447e0
SDJ
67882019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
6789 Pedro Alves <palves@redhat.com>
6790
6791 * top.c (quit_force): Call 'finalize_values'.
6792 * value.c (finalize_values): New function.
6793 * value.h (finalize_values): Declare.
6794
7734102d
EZ
67952019-03-30 Eli Zaretskii <eliz@gnu.org>
6796
6797 * NEWS: Announce $_gdb_major and $_gdb_minor.
6798
6799 * top.c (init_gdb_version_vars): New function.
6800 (gdb_init): Call init_gdb_version_vars.
6801
188e1fa9
TT
68022019-03-29 Tom Tromey <tromey@adacore.com>
6803
6804 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
6805 help text. Remove dead code.
6806
2880242d
KS
68072019-03-29 Keith Seitz <keiths@redhat.com>
6808
6809 From Siddhesh Poyarekar:
6810 * f-lang.h (f77_get_upperbound): Return LONGEST.
6811 (f77_get_lowerbound): Likewise.
6812 * f-typeprint.c (f_type_print_varspec_suffix): Expand
6813 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
6814 print them.
6815 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
6816 plongest to format print it.
6817 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6818 (f77_get_upperbound): Likewise.
6819 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6820 LOWER_BOUND to LONGEST.
6821 (f77_create_arrayprint_offset_tbl): Likewise.
6822
cc1defb1
KS
68232019-03-29 Keith Seitz <keiths@redhat.com>
6824
6825 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6826 %s/pulongest for TYPE_LENGTH instead of %d in format
6827 strings.
6828 * ada-typerint.c (ada_print_type): Likewise.
6829 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6830 * compile/compile-c-support.c (generate_register_struct): Likewise.
6831 * gdbtypes.c (recursive_dump_type): Likewise.
6832 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6833 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
6834 instead of %d in format strings.
6835 * riscv-tdep.c (riscv_type_alignment): Cast second argument
6836 to std::min to ULONGEST.
6837 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6838 instead of %d in format strings.
6839 * tracepoint.c (info_scope_command): Likewise.
6840 * typeprint.c (print_offset_data::update)
6841 (print_offset_data::finish): Likewise.
6842 * xtensa-tdep.c (xtensa_store_return_value)
6843 (xtensa_push_dummy_call): Likewise.
6844
e432ccf1
JT
68452019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
6846
6847 * windows-nat.c (display_selector): Fixed format specifications
6848 for 64-bit Cygwin.
6849
65d2b333
PW
68502019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6851
6852 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6853
f489207e
SL
68542019-03-28 Sandra Loosemore <sandra@codesourcery.com>
6855
6856 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6857 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6858 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6859 (nios2_linux_init_abi): Install it.
6860
bffa1015
AH
68612019-03-28 Alan Hayward <alan.hayward@arm.com>
6862
6863 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6864
fc96163a
AH
68652019-03-28 Alan Hayward <alan.hayward@arm.com>
6866
6867 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6868
20dc7e9b
PW
68692019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6870 Tom Tromey <tromey@adacore.com>
6871
6872 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6873
7f5331a8
JB
68742019-03-26 Joel Brobecker <brobecker@adacore.com>
6875
6876 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6877 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6878 method to compute the bounds of range types. Also print "[evaluated]"
6879 if the bounds' values come from a dynamic evaluation.
6880
18c77628
AB
68812019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
6882
6883 * cp-valprint.c (cp_print_value_fields): Don't print trailing
6884 whitespace when pretty printing is on.
6885
53c973f2
AH
68862019-03-26 Alan Hayward <alan.hayward@arm.com>
6887
e79be6e5 6888 * ppc-linux-nat.c: Add include.
53c973f2 6889
d851aa71
AH
68902019-03-26 Alan Hayward <alan.hayward@arm.com>
6891
e79be6e5 6892 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 6893
2fe7bab7
AH
68942019-03-26 Alan Hayward <alan.hayward@arm.com>
6895
e79be6e5 6896 * arm-linux-nat.c: Add include.
2fe7bab7 6897
068ef30e
SM
68982019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
6899
6900 * source-cache.c (source_cache::get_source_lines): Re-read
6901 fullname after calling open_source_file.
6902
81a24d04
JB
69032019-03-25 John Baldwin <jhb@FreeBSD.org>
6904
6905 * NEWS: Mention TLS support for FreeBSD.
6906
79e7ae11
TT
69072019-03-25 Tom Tromey <tromey@adacore.com>
6908
6909 * minsyms.c (BUNCH_SIZE): Update comment.
6910 (~minimal_symbol_reader): Remove old comment.
6911 (compact_minimal_symbols): Update comment.
6912 (minimal_symbol_reader::install): Remove old comment. Update
6913 other comments.
6914
d45963c2
AH
69152019-03-25 Alan Hayward <alan.hayward@arm.com>
6916
6917 * s390-linux-nat.c: Add include.
6918
0f83012e
AH
69192019-03-25 Alan Hayward <alan.hayward@arm.com>
6920
6921 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6922 Call linux_get_hwcap.
6923 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6924 Likewise.
6925 (aarch64_linux_get_hwcap): Remove function.
6926 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6927 declaration.
6928 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6929 linux_get_hwcap.
6930 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6931 * linux-tdep.c (linux_get_hwcap): Add function.
6932 (linux_get_hwcap2): Likewise.
6933 * linux-tdep.h (linux_get_hwcap): Add declaration.
6934 (linux_get_hwcap2): Likewise.
6935 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6936 (ppc_linux_get_hwcap2): Likewise.
6937 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6938 linux_get_hwcap.
6939 (ppc_linux_nat_target::insert_watchpoint): Likewise.
6940 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6941 (ppc_linux_nat_target::read_description): Likewise.
6942 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6943 * s390-linux-nat.c: Likewise.
6944 * s390-linux-tdep.c (s390_core_read_description): Likewise.
6945
6640a367
TT
69462019-03-24 Tom Tromey <tom@tromey.com>
6947
6948 * ada-lang.c (standard_lookup): Simplify initialization.
6949 (ada_lookup_symbol_nonlocal): Simplify return.
6950 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6951 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6952 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6953 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6954 initialization.
6955 * solib.c (solib_global_lookup): Simplify.
6956 * symtab.c (null_block_symbol): Remove.
6957 (symbol_cache_lookup): Simplify returns.
6958 (lookup_language_this): Simplify returns.
6959 (lookup_symbol_aux): Simplify return.
6960 (lookup_local_symbol): Simplify returns.
6961 (lookup_global_symbol_from_objfile): Simplify return.
6962 (lookup_symbol_in_objfile_symtabs)
6963 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6964 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6965 (lookup_static_symbol, lookup_global_symbol): Simplify return.
6966 * cp-namespace.c (cp_lookup_bare_symbol)
6967 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6968 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6969 (cp_lookup_nested_symbol): Don't use null_block_symbol.
6970 (cp_lookup_symbol_via_imports): Simplify initialization.
6971 (find_symbol_in_baseclass): Likewise.
6972 * symtab.h (null_block_symbol): Remove.
6973 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6974 (d_lookup_nested_symbol, d_lookup_symbol_imports)
6975 (d_lookup_symbol_module): Likewise.
6976 (find_symbol_in_baseclass): Simplify initialization.
6977
a930ebcd
TT
69782019-03-24 Tom Tromey <tom@tromey.com>
6979
6980 * expression.h: Don't include symtab.h.
6981 (struct block): Forward declare.
6982
582942f4
TT
69832019-03-24 Tom Tromey <tom@tromey.com>
6984
6985 * c-exp.y (typebase): Remove casts.
6986 * gdbtypes.c (lookup_unsigned_typename, )
6987 (lookup_signed_typename): Remove cast.
6988 * eval.c (parse_to_comma_and_eval): Remove cast.
6989 * parse.c (write_dollar_variable): Remove cast.
6990 * block.h (struct block) <superblock>: Now const.
6991 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6992 * psymtab.c (psym_map_matching_symbols): Make "block" const.
6993 (map_block): Make "block" const.
6994 * symfile.h (struct quick_symbol_functions)
6995 <map_matching_symbols>: Constify block argument to "callback".
6996 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6997 const.
6998 (find_pc_sect_compunit_symtab): Make "b" const.
6999 (find_symbol_at_address): Likewise.
7000 (search_symbols): Likewise.
7001 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7002 (dw2_debug_names_lookup_symbol): Likewise.
7003 (dw2_map_matching_symbols): Update.
7004 * p-valprint.c (pascal_val_print): Remove "block".
7005 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7006 (aux_add_nonlocal_symbols): Make "block" const.
7007 (resolve_subexp): Remove cast.
7008 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7009 const.
7010 (iterate_over_file_blocks): Likewise.
7011 * f-exp.y (%union) <bval>: Remove.
7012 * coffread.c (patch_opaque_types): Make "b" const.
7013 * spu-tdep.c (spu_catch_start): Make "block" const.
7014 * c-valprint.c (print_unpacked_pointer): Remove "block".
7015 * symmisc.c (dump_symtab_1): Make "b" const.
7016 (block_depth): Make "block" const.
7017 * d-exp.y (%union) <bval>: Remove.
7018 * cp-support.h (cp_lookup_rtti_type): Update.
7019 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7020 * psymtab.c (psym_lookup_symbol): Make "block" const.
7021 (maintenance_check_psymtabs): Make "b" const.
7022 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7023 (enumerate_locals, enumerate_args): Update.
7024 * python/py-symtab.c (stpy_global_block): Make "block" const.
7025 (stpy_static_block): Likewise.
7026 * inline-frame.c (block_starting_point_at): Make "new_block"
7027 const.
7028 * block.c (find_block_in_blockvector): Make return type const.
7029 (blockvector_for_pc_sect): Make "b" const.
7030 (find_block_in_blockvector): Make "b" const.
7031
7ad417dd
TT
70322019-03-23 Tom Tromey <tom@tromey.com>
7033
7034 * varobj.c (varobj_create): Update.
7035 * symfile.c (clear_symtab_users): Don't reset innermost_block.
7036 * printcmd.c (display_command, do_one_display): Don't reset
7037 innermost_block.
7038 * parser-defs.h (enum innermost_block_tracker_type): Move to
7039 expression.h.
7040 (innermost_block): Update comment.
7041 * parse.c (parse_exp_1): Add tracker_types parameter.
7042 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
7043 tracker_types parameter. Reset innermost_block.
7044 (parse_exp_in_context): Remove.
7045 (parse_expression_for_completion): Update.
7046 * objfiles.c (~objfile): Don't reset expression_context_block or
7047 innermost_block.
7048 * expression.h (enum innermost_block_tracker_type): Move from
7049 parser-defs.h.
7050 (parse_exp_1): Add tracker_types parameter.
7051 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7052 reset innermost_block.
7053
b366c208
TT
70542019-03-23 Tom Tromey <tom@tromey.com>
7055
7056 * objfiles.h: Include bcache.h.
7057
9bb9b2f9
TT
70582019-03-23 Tom Tromey <tom@tromey.com>
7059
7060 * linespec.c (get_current_search_block): Use
7061 scoped_restore_current_language.
7062 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7063
59c28372
AH
70642019-03-22 Alan Hayward <alan.hayward@arm.com>
7065 Jiong Wang <jiong.wang@arm.com>
7066
7067 * aarch64-linux-tdep.c
7068 (aarch64_linux_iterate_over_regset_sections): Check for pauth
7069 section.
7070 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7071
17e116a7
AH
70722019-03-22 Alan Hayward <alan.hayward@arm.com>
7073 Jiong Wang <jiong.wang@arm.com>
7074
7075 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7076 instructions.
7077 (aarch64_analyze_prologue_test): Add PACIASP test.
7078 (aarch64_prologue_prev_register): Unmask PC value.
7079
11e1b75f
AH
70802019-03-22 Alan Hayward <alan.hayward@arm.com>
7081 Jiong Wang <jiong.wang@arm.com>
7082
7083 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7084 (aarch64_dwarf2_prev_register): Unmask PC value.
7085 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7086 (aarch64_execute_dwarf_cfa_vendor_op): Check for
7087 DW_CFA_AARCH64_negate_ra_state.
7088 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7089
34dcc7cf
AH
70902019-03-22 Alan Hayward <alan.hayward@arm.com>
7091 Jiong Wang <jiong.wang@arm.com>
7092
7093 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7094 registers.
7095 (aarch64_pseudo_register_name): Likewise.
7096 (aarch64_pseudo_register_type): Likewise.
7097 (aarch64_pseudo_register_reggroup_p): Likewise.
7098 (aarch64_gdbarch_init): Add pauth registers.
7099 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7100 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7101 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7102 (struct gdbarch_tdep): Add regnum for ra_state.
7103
1ef53e6b
AH
71042019-03-22 Alan Hayward <alan.hayward@arm.com>
7105 Jiong Wang <jiong.wang@arm.com>
7106
7107 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7108
76bed0fd
AH
71092019-03-22 Alan Hayward <alan.hayward@arm.com>
7110 Jiong Wang <jiong.wang@arm.com>
7111
7112 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7113 function.
7114 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7115 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7116 (aarch64_gdbarch_init): Add puth registers.
7117 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7118 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7119 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7120
ee4fbcfa
AH
71212019-03-22 Alan Hayward <alan.hayward@arm.com>
7122 Jiong Wang <jiong.wang@arm.com>
7123
7124 * aarch64-linux-nat.c
7125 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7126 * aarch64-linux-tdep.c
7127 (aarch64_linux_core_read_description): Likewise.
7128 (aarch64_linux_get_hwcap): New function.
7129 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7130 (aarch64_linux_get_hwcap): New declaration.
7131
6dc0ebde
AH
71322019-03-22 Alan Hayward <alan.hayward@arm.com>
7133 Jiong Wang <jiong.wang@arm.com>
7134
7135 * aarch64-linux-nat.c
7136 (aarch64_linux_nat_target::read_description): Add pauth param.
7137 * aarch64-linux-tdep.c
7138 (aarch64_linux_core_read_description): Likewise.
7139 * aarch64-tdep.c (struct target_desc): Add in pauth.
7140 (aarch64_read_description): Add pauth param.
7141 (aarch64_gdbarch_init): Likewise.
7142 * aarch64-tdep.h (aarch64_read_description): Likewise.
7143 * arch/aarch64.c (aarch64_create_target_description): Likewise.
7144 * arch/aarch64.h (aarch64_create_target_description): Likewise.
7145 * features/Makefile: Add new files.
7146 * features/aarch64-pauth.c: New file.
7147 * features/aarch64-pauth.xml: New file.
7148
595915c1
TT
71492019-03-20 Tom Tromey <tromey@adacore.com>
7150
7151 * infrun.c (handle_inferior_event): Rename from
7152 handle_inferior_event_1. Create a scoped_value_mark.
7153 (handle_inferior_event): Remove.
7154
4c7d57e7
TT
71552019-03-19 Tom Tromey <tromey@adacore.com>
7156
7157 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7158 * infrun.h (print_stop_event): Add "displays" parameter.
7159 * infrun.c (print_stop_event): Add "displays" parameter.
7160
cb246234
PA
71612019-03-19 Pedro Alves <palves@redhat.com>
7162
7163 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7164 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
7165 to -1. Fix TABs vs spaces.
7166 (tui_ui_out::tui_ui_out): Don't initialize fields here.
7167 * tui/tui-out.h (tui_ui_out) Add intro comments.
7168 <m_line, m_start_of_line>: In-class initialize, and add describing
7169 comment.
7170
3a0e45b2
AH
71712019-03-18 Alan Hayward <alan.hayward@arm.com>
7172
7173 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7174 variable names.
7175 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7176
5371b850
PA
71772019-03-18 Pedro Alves <palves@redhat.com>
7178 Eli Zaretskii <eliz@gnu.org>
7179
7180 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7181 m_line and m_start_of_line.
7182
b17c4cd0
EZ
71832019-03-18 Eli Zaretskii <eliz@gnu.org>
7184
7185 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7186 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7187 it returns a newline. This fixes a regression in TU mode, whereby
7188 the next line is output on the same screen line as the user input.
7189
4bd56d18
TT
71902019-03-18 Tom Tromey <tromey@adacore.com>
7191
7192 * minsyms.c (minimal_symbol_reader::install): Remove call to
7193 obstack_blank.
7194
55c10aca
PA
71952019-03-18 Pedro Alves <palves@redhat.com>
7196
7197 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7198 New globals.
7199 (apply_style): New, factored out from ...
7200 (apply_ansi_escape): ... this. Handle reverse video mode.
7201 (tui_set_reverse_mode): New function.
7202 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7203 * tui/tui-winsource.c (tui_show_source_line): Use
7204 tui_set_reverse_mode instead of setting A_STANDOUT.
7205 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7206 New setter methods.
7207
647bb750
HD
72082019-03-18 Hannes Domani <ssbssa@yahoo.de>
7209
7210 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7211 Handle tabs.
7212
bff8c71f
TT
72132019-03-18 Tom Tromey <tromey@adacore.com>
7214
7215 * ada-lang.c (empty_array): Add "high" parameter.
7216 (ada_evaluate_subexp): Update.
7217
58785d98
ST
72182019-03-17 Sergei Trofimovich <siarheit@google.com>
7219
7220 * unittests/string_view-selftests.c: Define
7221 _initialize_string_view_selftests unconditionally.
7222
d4cbef22
ВМ
72232019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
7224
7225 PR gdb/24350
7226 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7227
fce4c071
ВМ
72282019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
7229
7230 PR gdb/24351
7231 * windows-nat.c (display_selector): Fix format specifiers.
7232
f7f0a123
EZ
72332019-03-17 Eli Zaretskii <eliz@gnu.org>
7234
7235 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7236 tui_refill_source_window instead of tui_refresh_win, to update the
7237 current execution line. This fixes redisplay of the current line
7238 when stepping through the code with "next" or "step".
7239
ab42892f
EZ
72402019-03-16 Eli Zaretskii <eliz@gnu.org>
7241
7242 * source-cache.c (source_cache::get_source_lines): Call
7243 find_source_lines to initialize s->nlines. This fixes vertical
7244 scrolling of TUI source window when the DOWN arrow is pressed.
7245
8d8c087f
PW
72462019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7247
7248 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7249 linux-thread-db.c (_initialize_thread_db): Likewise.
7250
798e1c30
EZ
72512019-03-16 Eli Zaretskii <eliz@gnu.org>
7252
7253 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7254 wclrtoeol in tui_show_source_line". This reverts changes made in
7255 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7256
eefba3da
TT
72572019-03-15 Tom Tromey <tom@tromey.com>
7258
7259 * symtab.h (struct minimal_symbol): Derive from
7260 general_symbol_info.
7261 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7262 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7263 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7264 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7265 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7266 (MSYMBOL_SEARCH_NAME): Update.
7267 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7268 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7269 * minsyms.c (minimal_symbol_reader::record_full): Update.
7270
0de2420c
TT
72712019-03-15 Tom Tromey <tom@tromey.com>
7272
7273 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7274
042d75e4
TT
72752019-03-15 Tom Tromey <tom@tromey.com>
7276
7277 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7278 unique_xmalloc_ptr.
7279 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7280 Update.
7281 * minsyms.c (lookup_minimal_symbol_by_pc_section)
7282 (build_minimal_symbol_hash_tables)
7283 (minimal_symbol_reader::install): Update.
7284
db92718b
TT
72852019-03-15 Tom Tromey <tom@tromey.com>
7286
7287 * symtab.c (create_demangled_names_hash): Update.
7288 (symbol_set_names): Update.
7289 * objfiles.h (struct objfile_per_bfd_storage)
7290 <demangled_names_hash>: Now an htab_up.
7291 * objfiles.c (objfile_per_bfd_storage): Simplify.
7292
d6797f46
TT
72932019-03-15 Tom Tromey <tom@tromey.com>
7294
7295 * objfiles.h (struct objfile_per_bfd_storage): Declare
7296 destructor.
7297 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7298 New.
7299 (get_objfile_bfd_data): Use new. Don't initialize
7300 language_of_main.
7301 (free_objfile_per_bfd_storage): Remove.
7302 (objfile_bfd_data_free, objfile::~objfile): Use delete.
7303
741d7538
TT
73042019-03-15 Tom Tromey <tom@tromey.com>
7305
7306 * symfile.c (reread_symbols): Update.
7307 * objfiles.c (objfile::objfile): Update.
7308 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7309 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7310 comment.
7311 (minimal_symbol_reader::install): Update.
7312 (terminate_minimal_symbol_table): Remove.
7313 * jit.c (jit_object_close_impl): Update.
7314
788c80d1
TT
73152019-03-15 Tom Tromey <tom@tromey.com>
7316
7317 * minsyms.c (minimal_symbol_reader::record_full): Remove some
7318 initializations.
7319
1b7a07cb
TT
73202019-03-15 Tom Tromey <tom@tromey.com>
7321
7322 * objfiles.h (struct objfile_per_bfd_storage)
7323 <demangled_hash_languages>: Now a bitset.
7324 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7325 (lookup_minimal_symbol): Update.
7326
3db066bc
TT
73272019-03-15 Tom Tromey <tom@tromey.com>
7328
7329 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7330 Don't return the symbol.
7331 * coffread.c (record_minimal_symbol): Use record_full.
7332
3fff2c37
EZ
73332019-03-14 Eli Zaretskii <eliz@gnu.org>
7334
7335 The MS-Windows port of ncurses fails to switch to a color pair if
7336 one or both of the colors are the implicit default colors. This
7337 change records the default colors when TUI is initialized, and
7338 then specifies them explicitly when a color pair uses the default
7339 colors. This allows color styling in TUI mode on MS-Windows.
7340
7341 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
7342 ncurses_norm_attr.
7343 (tui_initialize_io) [__MINGW32__]: Record the default terminal
7344 colors in ncurses_norm_attr.
7345 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7346 "none", replace it with the default color recorded in
7347 ncurses_norm_attr.
7348
3b336828
TT
73492019-03-14 Tom Tromey <tromey@adacore.com>
7350
7351 * source-cache.h (class source_cache) <get_source_lines>: Return
7352 std::string.
7353 * source-cache.c (source_cache::extract_lines): Handle case where
7354 first_pos==npos. Return std::string.
7355 (source_cache::get_source_lines): Update.
7356
d085f989
TT
73572019-03-14 Tom Tromey <tromey@adacore.com>
7358
7359 * NEWS: Add item for "style sources" commands.
7360 * source-cache.c (source_cache::get_source_lines): Check
7361 source_styling.
7362 * cli/cli-style.c (source_styling): New global.
7363 (_initialize_cli_style): Add "style sources" commands.
7364 (show_style_sources): New function.
7365 * cli/cli-style.h (source_styling): Declare.
7366
6f11e682
TT
73672019-03-14 Pedro Alves <palves@redhat.com>
7368 Tom Tromey <tromey@adacore.com>
7369
7370 * tui/tui-winsource.h (tui_refill_source_window): Declare.
7371 * tui/tui-winsource.c (tui_refill_source_window): New function,
7372 from...
7373 (tui_horizontal_source_scroll): ... here. Move some logic.
7374 * cli/cli-style.c (set_style_enabled): Notify new observable.
7375 * tui/tui-hooks.c (tui_redisplay_source): New function.
7376 (tui_attach_detach_observers): Attach or detach
7377 tui_redisplay_source.
7378 * observable.h (source_styling_changed): New observable.
7379 * observable.c: Define source_styling_changed observable.
7380
a068643d
TT
73812019-03-13 Tom Tromey <tromey@adacore.com>
7382
7383 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7384 (i386_gnu_nat_target::store_registers): Update.
7385 * target-debug.h (target_debug_print_std_string): New macro.
7386 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7387 * windows-tdep.c (display_one_tib): Update.
7388 * tui/tui-stack.c (tui_make_status_line): Update.
7389 * top.c (print_inferior_quit_action): Update.
7390 * thread.c (thr_try_catch_cmd): Update.
7391 (add_thread_with_info): Update.
7392 (thread_target_id_str): Update.
7393 (thr_try_catch_cmd): Update.
7394 (thread_command): Update.
7395 (thread_find_command): Update.
7396 * record-btrace.c (record_btrace_target::info_record)
7397 (record_btrace_resume_thread, record_btrace_target::resume)
7398 (record_btrace_cancel_resume, record_btrace_step_thread)
7399 (record_btrace_target::wait, record_btrace_target::wait)
7400 (record_btrace_target::wait, record_btrace_target::stop): Update.
7401 * progspace.c (print_program_space): Update.
7402 * process-stratum-target.c
7403 (process_stratum_target::thread_address_space): Update.
7404 * linux-fork.c (linux_fork_mourn_inferior)
7405 (detach_checkpoint_command, info_checkpoints_command)
7406 (linux_fork_context): Update.
7407 (linux_fork_detach): Update.
7408 (class scoped_switch_fork_info): Update.
7409 (delete_checkpoint_command): Update.
7410 * infrun.c (follow_fork_inferior): Update.
7411 (follow_fork_inferior): Update.
7412 (proceed_after_vfork_done): Update.
7413 (handle_vfork_child_exec_or_exit): Update.
7414 (follow_exec): Update.
7415 (displaced_step_prepare_throw): Update.
7416 (displaced_step_restore): Update.
7417 (start_step_over): Update.
7418 (resume_1): Update.
7419 (clear_proceed_status_thread): Update.
7420 (proceed): Update.
7421 (print_target_wait_results): Update.
7422 (do_target_wait): Update.
7423 (context_switch): Update.
7424 (stop_all_threads): Update.
7425 (restart_threads): Update.
7426 (finish_step_over): Update.
7427 (handle_signal_stop): Update.
7428 (switch_back_to_stepped_thread): Update.
7429 (keep_going_pass_signal): Update.
7430 (print_exited_reason): Update.
7431 (normal_stop): Update.
7432 * inferior.c (inferior_pid_to_str): Change return type.
7433 (print_selected_inferior): Update.
7434 (add_inferior): Update.
7435 (detach_inferior): Update.
7436 * dummy-frame.c (fprint_dummy_frames): Update.
7437 * dcache.c (dcache_info_1): Update.
7438 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7439 (btrace_fetch, btrace_clear): Update.
7440 * linux-tdep.c (linux_core_pid_to_str): Change return type.
7441 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7442 type.
7443 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7444 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7445 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7446 * gdbarch.c, gdbarch.h: Rebuild.
7447 * gdbarch.sh (core_pid_to_str): Change return type.
7448 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7449 return type.
7450 (windows_nat_target::pid_to_str): Change return type.
7451 (windows_delete_thread): Update.
7452 (windows_nat_target::attach): Update.
7453 (windows_nat_target::files_info): Update.
7454 * target-delegates.c: Rebuild.
7455 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7456 return type.
7457 (sol_thread_target::pid_to_str): Change return type.
7458 * remote.c (class remote_target) <pid_to_str>: Change return
7459 type.
7460 (remote_target::pid_to_str): Change return type.
7461 (extended_remote_target::attach, remote_target::remote_stop_ns)
7462 (remote_target::remote_notif_remove_queued_reply)
7463 (remote_target::push_stop_reply, remote_target::disable_btrace):
7464 Update.
7465 (extended_remote_target::attach): Update.
7466 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7467 type.
7468 (gdbsim_target::pid_to_str): Change return type.
7469 * ravenscar-thread.c (struct ravenscar_thread_target)
7470 <pid_to_str>: Change return type.
7471 (ravenscar_thread_target::pid_to_str): Change return type.
7472 * procfs.c (class procfs_target) <pid_to_str>: Change return
7473 type.
7474 (procfs_target::pid_to_str): Change return type.
7475 (procfs_target::attach): Update.
7476 (procfs_target::detach): Update.
7477 (procfs_target::fetch_registers): Update.
7478 (procfs_target::store_registers): Update.
7479 (procfs_target::wait): Update.
7480 (procfs_target::files_info): Update.
7481 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7482 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7483 return type.
7484 (nto_procfs_target::pid_to_str): Change return type.
7485 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7486 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7487 return type.
7488 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7489 (exit_lwp): Update.
7490 (attach_proc_task_lwp_callback, get_detach_signal)
7491 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7492 (linux_nat_target::resume, wait_lwp, stop_callback)
7493 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7494 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7495 (linux_nat_wait_1, resume_stopped_resumed_lwps)
7496 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7497 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7498 type.
7499 (inf_ptrace_target::attach): Update.
7500 (inf_ptrace_target::files_info): Update.
7501 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7502 type.
7503 (go32_nat_target::pid_to_str): Change return type.
7504 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7505 (gnu_nat_target::wait): Update.
7506 (gnu_nat_target::wait): Update.
7507 (gnu_nat_target::resume): Update.
7508 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7509 (fbsd_nat_target::wait): Update.
7510 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7511 type.
7512 (darwin_nat_target::attach): Update.
7513 * corelow.c (class core_target) <pid_to_str>: Change return type.
7514 (core_target::pid_to_str): Change return type.
7515 * target.c (normal_pid_to_str): Change return type.
7516 (default_pid_to_str): Likewise.
7517 (target_pid_to_str): Change return type.
7518 (target_translate_tls_address): Update.
7519 (target_announce_detach): Update.
7520 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7521 return type.
7522 (bsd_uthread_target::pid_to_str): Change return type.
7523 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7524 type.
7525 (bsd_kvm_target::pid_to_str): Change return type.
7526 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7527 return type.
7528 (aix_thread_target::pid_to_str): Change return type.
7529 * target.h (struct target_ops) <pid_to_str>: Change return type.
7530 (target_pid_to_str, normal_pid_to_str): Likewise.
7531 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7532 type.
7533 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7534 type.
7535 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7536 return type.
7537 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7538 type.
7539 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7540 type.
7541 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7542 return type.
7543
b4be1b06
SM
75442019-03-13 Simon Marchi <simon.marchi@ericsson.com>
7545
7546 * NEWS: Mention that the new default MI version is 3. Mention
7547 changes to the output of commands and events that deal with
7548 multi-location breakpoints.
7549 * breakpoint.c: Include "mi/mi-out.h".
7550 (print_one_breakpoint): Change output syntax if using MI version
7551 >= 3.
7552 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7553 New.
7554 (mi_multi_location_breakpoint_output_fixed): New.
7555 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7556 (mi_cmd_fix_multi_location_breakpoint_output): New.
7557 (mi_multi_location_breakpoint_output_fixed): New.
7558 * mi/mi-cmds.c (mi_cmds): Register command
7559 -fix-multi-location-breakpoint-output.
7560 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7561 interpreter "mi".
7562
8e5e5494
SM
75632019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
7564
7565 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7566 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7567 instantiate mi_ui_out based on interpreter name.
7568 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7569 * mi/mi-main.c (mi_load_progress): Likewise.
7570
197df35e
JB
75712019-03-12 John Baldwin <jhb@FreeBSD.org>
7572
7573 * NEWS: Combine separate "New targets" sections for 8.3.
7574
8399425f
JB
75752019-03-12 John Baldwin <jhb@FreeBSD.org>
7576
7577 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7578 (ppcfbsd_init_abi): Install gdbarch
7579 "fetch_tls_load_module_address" and "get_thread_local_address"
7580 methods.
7581
b0f87ed0
JB
75822019-03-12 John Baldwin <jhb@FreeBSD.org>
7583
7584 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7585 (riscv_fbsd_init_abi): Install gdbarch
7586 "fetch_tls_load_module_address" and "get_thread_local_address"
7587 methods.
7588
ce25aa57
JB
75892019-03-12 John Baldwin <jhb@FreeBSD.org>
7590
7591 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7592 (i386fbsd_init_abi): Install gdbarch
7593 "fetch_tls_load_module_address" and "get_thread_local_address"
7594 methods.
7595
f5424cfa
JB
75962019-03-12 John Baldwin <jhb@FreeBSD.org>
7597
7598 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7599 (amd64fbsd_init_abi): Install gdbarch
7600 "fetch_tls_load_module_address" and "get_thread_local_address"
7601 methods.
7602
945f3901
JB
76032019-03-12 John Baldwin <jhb@FreeBSD.org>
7604
7605 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7606 (struct fbsd_pspace_data): New type.
7607 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7608 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7609 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7610 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7611 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7612
ef0bd204
JB
76132019-03-12 John Baldwin <jhb@FreeBSD.org>
7614
7615 * gdbtypes.c (lookup_struct_elt): New function.
7616 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7617 * gdbtypes.h (struct struct_elt): New type.
7618 (lookup_struct_elt): New prototype.
7619
36c53a02
JB
76202019-03-12 John Baldwin <jhb@FreeBSD.org>
7621
7622 * gdbtypes.c (lookup_struct_elt_type): Update comment and
7623 remove disabled code block.
7624
6e056c81
JB
76252019-03-12 John Baldwin <jhb@FreeBSD.org>
7626
7627 * gdbarch.sh (get_thread_local_address): New method.
7628 * gdbarch.h, gdbarch.c: Regenerate.
7629 * target.c (target_translate_tls_address): Use
7630 gdbarch_get_thread_local_address if present instead of
7631 target::get_thread_local_address.
7632
cd250a18
JB
76332019-03-12 John Baldwin <jhb@FreeBSD.org>
7634
7635 * target.h (target::get_thread_local_address): Update comment.
7636
df22c1e5
JB
76372019-03-12 John Baldwin <jhb@FreeBSD.org>
7638
7639 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7640 objfile->separate_debug_objfile_backlink if not NULL.
7641
dd6876c9
JB
76422019-03-12 John Baldwin <jhb@FreeBSD.org>
7643
7644 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7645 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7646 (amd64bsd_store_inferior_registers): Likewise.
7647 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7648 Enable segment base registers.
7649 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7650 PT_GETFSBASE and PT_GETGSBASE.
7651 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7652 PT_SETGSBASE.
7653 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7654 segment base registers.
7655 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7656
1163a4b7
JB
76572019-03-12 John Baldwin <jhb@FreeBSD.org>
7658
7659 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7660 Update calls to i386_target_description to add 'segments'
7661 parameter.
7662 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
7663 add segment base registers.
7664 * arch/i386.c (i386_create_target_description): Add 'segments'
7665 parameter to enable segment base registers.
7666 * arch/i386.h (i386_create_target_description): Likewise.
7667 * features/i386/32bit-segments.xml: New file.
7668 * features/i386/32bit-segments.c: Generate.
7669 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7670 call to i386_target_description to add 'segments' parameter.
7671 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7672 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7673 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7674 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7675 if feature is present.
7676 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7677 Add 'segments' parameter to call to i386_target_description.
7678 (i386_target_description): Add 'segments' parameter to enable
7679 segment base registers.
7680 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7681 to call to i386_target_description.
7682 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7683 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7684 Define I386_NUM_REGS.
7685 (i386_target_description): Add 'segments' parameter to enable
7686 segment base registers.
7687
3a350822
EZ
76882019-03-12 Eli Zaretskii <eliz@gnu.org>
7689
7690 PR/24325
7691 * source-cache.c: #undef open and close, to avoid unresolved
7692 externals during linking.
7693
ffdd69cf
TT
76942019-03-12 Tom Tromey <tromey@adacore.com>
7695
7696 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7697 const. Add initializers.
7698 (_initialize_remote): Don't initialize ptid globals.
7699
ec148c57
PA
77002019-03-12 Pedro Alves <palves@redhat.com>
7701
7702 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7703
32764270
PA
77042019-03-12 Pedro Alves <palves@redhat.com>
7705
7706 * cp-name-parser.y (main): Remove unused 'len' variable.
7707
17547186
TT
77082019-03-12 Tom Tromey <tromey@adacore.com>
7709
7710 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7711 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7712
d3a70e03
TT
77132019-03-12 Tom Tromey <tromey@adacore.com>
7714
7715 * linux-nat.c (iterate_over_lwps): Update.
7716 (stop_callback): Remove parameter.
7717 (stop_wait_callback, detach_callback, resume_set_callback)
7718 (select_singlestep_lwp_callback, set_ignore_sigint)
7719 (status_callback, resumed_callback, resume_clear_callback)
7720 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7721 data parameter.
7722 (linux_nat_target::detach, linux_nat_target::resume)
7723 (linux_stop_and_wait_all_lwps, select_event_lwp)
7724 (linux_nat_filter_event, linux_nat_wait_1)
7725 (linux_nat_target::kill, linux_nat_target::stop)
7726 (linux_nat_target::stop): Update.
7727 (linux_nat_resume_callback): Change type.
7728 (resume_stopped_resumed_lwps, count_events_callback)
7729 (select_event_lwp_callback): Likewise.
7730 (linux_stop_lwp, linux_nat_stop_lwp): Update.
7731 * arm-linux-nat.c (struct update_registers_data): Remove.
7732 (update_registers_callback): Change type.
7733 (arm_linux_insert_hw_breakpoint1): Update.
7734 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7735 parameter.
7736 (x86_linux_dr_set_addr): Update.
7737 (x86_linux_dr_set_control): Update.
7738 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7739 (iterate_over_lwps): Use gdb::function_view.
7740 * nat/aarch64-linux-hw-point.c (struct
7741 aarch64_dr_update_callback_param): Remove.
7742 (debug_reg_change_callback): Change type.
7743 (aarch64_notify_debug_reg_change): Update.
7744 * s390-linux-nat.c (s390_refresh_per_info): Update.
7745
82cb27ff
TT
77462019-03-11 Tom Tromey <tromey@adacore.com>
7747
7748 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7749 redundant assignment to "this_cu".
7750
568c0683
SM
77512019-03-08 Simon Marchi <simon.marchi@efficios.com>
7752
7753 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7754
f09ce22d
SM
77552019-03-08 Simon Marchi <simon.marchi@efficios.com>
7756
7757 * gdbtypes.c (rank_one_type_parm_set): New function extracted
7758 from...
7759 (rank_one_type): ... this.
7760
595f96a9
SM
77612019-03-08 Simon Marchi <simon.marchi@efficios.com>
7762
7763 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7764 from...
7765 (rank_one_type): ... this.
7766
2598a94b
SM
77672019-03-08 Simon Marchi <simon.marchi@efficios.com>
7768
7769 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7770 from...
7771 (rank_one_type): ... this.
7772
7f17b20d
SM
77732019-03-08 Simon Marchi <simon.marchi@efficios.com>
7774
7775 * gdbtypes.c (rank_one_type_parm_float): New function extracted
7776 from...
7777 (rank_one_type): ... this.
7778
2c509035
SM
77792019-03-08 Simon Marchi <simon.marchi@efficios.com>
7780
7781 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7782 from...
7783 (rank_one_type): ... this.
7784
0dd322dc
SM
77852019-03-08 Simon Marchi <simon.marchi@efficios.com>
7786
7787 * gdbtypes.c (rank_one_type_parm_range): New function extracted
7788 from...
7789 (rank_one_type): ... this.
7790
41ea4728
SM
77912019-03-08 Simon Marchi <simon.marchi@efficios.com>
7792
7793 * gdbtypes.c (rank_one_type_parm_char): New function extracted
7794 from...
7795 (rank_one_type): ... this.
7796
793cd1d2
SM
77972019-03-08 Simon Marchi <simon.marchi@efficios.com>
7798
7799 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7800 from...
7801 (rank_one_type): ... this.
7802
34910087
SM
78032019-03-08 Simon Marchi <simon.marchi@efficios.com>
7804
7805 * gdbtypes.c (rank_one_type_parm_int): New function extracted
7806 from...
7807 (rank_one_type): ... this.
7808
f1f832d6
SM
78092019-03-08 Simon Marchi <simon.marchi@efficios.com>
7810
7811 * gdbtypes.c (rank_one_type_parm_func): New function extracted
7812 from...
7813 (rank_one_type): ... this.
7814
b9f4512f
SM
78152019-03-08 Simon Marchi <simon.marchi@efficios.com>
7816
7817 * gdbtypes.c (rank_one_type_parm_array): New function extracted
7818 from...
7819 (rank_one_type): ... this.
7820
9293fc63
SM
78212019-03-08 Simon Marchi <simon.marchi@efficios.com>
7822
7823 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7824 from...
7825 (rank_one_type): ... this.
7826
e3abbe7e
PW
78272019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7828
7829 * inferior.c (initialize_inferiors): Ensure 'help set/show print
7830 inferior-events' shows the example events.
7831
e4adb939
EZ
78322019-03-08 Eli Zaretskii <eliz@gnu.org>
7833
7834 Support styling on native MS-Windows console
7835
7836 PR/24315
7837 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7838 on MS-Windows if $TERM is not defined.
7839
7840 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7841
7842 * posix-hdep.c (gdb_console_fputs):
7843 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7844 functions.
7845 * ui-file.h (gdb_console_fputs): Add prototype.
7846
7847 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7848 back to fputs only if the former returns zero.
7849
25629dfd
TT
78502019-03-07 Tom Tromey <tom@tromey.com>
7851
7852 * symmisc.c (print_symbol_bcache_statistics): Update.
7853 (print_objfile_statistics): Update.
7854 * symfile.c (allocate_symtab): Update.
7855 * stabsread.c: Don't include bcache.h.
7856 * psymtab.h (struct psymbol_bcache): Don't declare.
7857 (class psymtab_storage) <psymbol_cache>: Now a bcache.
7858 (psymbol_bcache_init, psymbol_bcache_free)
7859 (psymbol_bcache_get_bcache): Don't declare.
7860 * psymtab.c (struct psymbol_bcache): Remove.
7861 (psymtab_storage::psymtab_storage): Update.
7862 (psymtab_storage::~psymtab_storage): Update.
7863 (psymbol_bcache_init, psymbol_bcache_free)
7864 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7865 (add_psymbol_to_bcache): Update.
7866 (allocate_psymtab): Update.
7867 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7868 macro_cache>: No longer pointers.
7869 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7870 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7871 * macrotab.c (macro_bcache): Update.
7872 * macroexp.c: Don't include bcache.h.
7873 * gdbtypes.c (check_types_worklist): Update.
7874 (types_deeply_equal): Remove TRY/CATCH. Update.
7875 * elfread.c (elf_symtab_read): Update.
7876 * dwarf2read.c: Don't include bcache.h.
7877 * buildsym.c (buildsym_compunit::get_macro_table): Update.
7878 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7879 (print_bcache_statistics, bcache_memory_used): Don't declare.
7880 (struct bcache): Move from bcache.c. Add constructor, destructor,
7881 methods. Rename all data members.
7882 * bcache.c (struct bcache): Move to bcache.h.
7883 (bcache::expand_hash_table): Rename from expand_hash_table.
7884 (bcache): Remove.
7885 (bcache::insert): Rename from bcache_full.
7886 (bcache::compare): Rename from bcache_compare.
7887 (bcache_xmalloc): Remove.
7888 (bcache::~bcache): Rename from bcache_xfree.
7889 (bcache::print_statistics): Rename from print_bcache_statistics.
7890 (bcache::memory_used): Rename from bcache_memory_used.
7891
fe726667
PA
78922019-03-07 Pedro Alves <palves@redhat.com>
7893
7894 * infrun.c (normal_stop): Also check for
7895 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7896
7584bb30
AB
78972019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
7898
7899 * f-lang.c (value_from_host_double): Moved to...
7900 * value.c (value_from_host_double): ...here.
7901 * value.h (value_from_host_double): Declare.
7902 * guile/scm-math.c (vlscm_convert_typed_number): Use
7903 value_from_host_double.
7904 (vlscm_convert_number): Likewise.
7905 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7906 * python/py-value.c (convert_value_from_python): Likewise.
7907
a7b1986e
TT
79082019-03-06 Tom Tromey <tom@tromey.com>
7909
7910 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7911
0ccf4211
TT
79122019-03-06 Tom Tromey <tom@tromey.com>
7913
7914 * utils.h (free_current_contents): Don't declare.
7915 * utils.c (free_current_contents): Remove.
7916
fe7b42e5
TT
79172019-03-06 Tom Tromey <tom@tromey.com>
7918
7919 * top.c (quit_force): Update.
7920 * main.c (captured_command_loop): Update.
7921 * common/new-op.c (operator new): Update.
7922 * common/common-exceptions.c (struct catcher)
7923 <save_cleanup_chain>: Remove member.
7924 (exceptions_state_mc_init): Update.
7925 (exception_try_scope_entry): Return nullptr.
7926 (exception_try_scope_exit, exception_rethrow)
7927 (throw_exception_sjlj, throw_exception_cxx): Update.
7928 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7929 (all_cleanups, do_cleanups, discard_cleanups)
7930 (discard_final_cleanups, save_cleanups, save_final_cleanups)
7931 (restore_cleanups, restore_final_cleanups): Don't declare.
7932 (do_final_cleanups): Remove parameter.
7933 * common/cleanups.c (cleanup_chain, make_cleanup)
7934 (make_cleanup_dtor, all_cleanups, do_cleanups)
7935 (discard_my_cleanups, discard_cleanups)
7936 (discard_final_cleanups, save_my_cleanups, save_cleanups)
7937 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7938 (null_cleanup): Remove.
7939 (do_final_cleanups): Remove parameter.
7940
c6321f19
TT
79412019-03-06 Tom Tromey <tom@tromey.com>
7942
7943 * remote.c (remote_target::remote_parse_stop_reply): Use
7944 unique_xmalloc_ptr.
7945
61b30099
TT
79462019-03-06 Tom Tromey <tom@tromey.com>
7947
7948 * stabsread.c (struct stabs_field_info): Rename from field_info.
7949 <list, fnlist>: Add initializers.
7950 <obstack>: New member.
7951 (read_member_functions, read_struct_fields, read_baseclasses):
7952 Allocate on obstack. Don't use cleanups.
7953 (read_one_struct_field, read_member_functions, read_struct_fields)
7954 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7955 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7956 (read_struct_type): Update.
7957
6cceac94
TT
79582019-03-06 Tom Tromey <tom@tromey.com>
7959
7960 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7961 * common/filestuff.h (make_cleanup_close): Don't declare.
7962 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7963 Remove.
7964
72412762
TT
79652019-03-06 Tom Tromey <tom@tromey.com>
7966
7967 * solib-aix.c: Use make_scope_exit.
7968
2b6ff1c0
TT
79692019-03-06 Tom Tromey <tom@tromey.com>
7970
7971 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7972 Use make_scope_exit.
7973
d01c5877
TT
79742019-03-06 Tom Tromey <tom@tromey.com>
7975
7976 * solib-svr4.c (disable_probes_interface): Remove parameter.
7977 (svr4_handle_solib_event): Use make_scope_exit.
7978
32603266
TT
79792019-03-06 Tom Tromey <tom@tromey.com>
7980
7981 * remote.c (struct stop_reply_deleter): Remove.
7982 (stop_reply_up): Update.
7983 (struct stop_reply): Derive from notif_event. Don't typedef.
7984 <regcache>: Now a std::vector.
7985 (stop_reply_xfree): Remove.
7986 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7987 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
7988 (remote_target::discard_pending_stop_replies): Use delete.
7989 (remote_target::remote_parse_stop_reply): Update.
7990 (remote_target::process_stop_reply): Update.
7991 * remote-notif.h (struct notif_event): Add virtual destructor.
7992 Remove "dtr" member.
7993 (struct notif_client) <alloc_event>: Return a unique_ptr.
7994 (notif_event_xfree): Don't declare.
7995 (notif_event_up): New typedef.
7996 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7997 (notif_event_xfree, do_notif_event_xfree): Remove.
7998 (remote_notif_state_xfree): Update.
7999
9799571e
TT
80002019-03-06 Tom Tromey <tom@tromey.com>
8001
8002 * infrun.c (displaced_step_clear_cleanup): Now a
8003 forward_scope_exit type.
8004 (displaced_step_prepare_throw): Update.
8005 (displaced_step_fixup): Update.
8006
09e3c4ca
TT
80072019-03-06 Tom Tromey <tom@tromey.com>
8008
8009 * inferior.h (class inferior): Update comment.
8010 * gdbthread.h (class thread_info): Update comment.
8011
e2a03548
TT
80122019-03-06 Joel Brobecker <brobecker@adacore.com>
8013 Tom Tromey <tom@tromey.com>
8014
8015 * stabsread.h (struct stab_section_list): Remove.
8016 (coffstab_build_psymtabs): Update.
8017 * dbxread.c (symbuf_sections): Now a std::vector.
8018 (sect_idx): New global.
8019 (fill_symbuf): Update.
8020 (coffstab_build_psymtabs): Change type of stabsects parameter.
8021 Update.
8022 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8023 std::vector.
8024 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8025 (coff_locate_sections): Update.
8026 (coff_symfile_read): Remove cleanups. Update.
8027 (init_stringtab): Add storage parameter.
8028 (free_stringtab, free_stringtab_cleanup): Remove.
8029 (init_lineno): Add storage parameter.
8030 (free_linetab, free_linetab_cleanup): Remove.
8031
b7e60d85
PA
80322019-03-06 Pedro Alves <palves@redhat.com>
8033
8034 * linux-fork.c (fork_info::clobber_regs): Delete.
8035 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8036 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
8037 comment. Adjust.
8038 (scoped_switch_fork_info::scoped_switch_fork_info)
8039 (checkpoint_command, linux_fork_context): Adjust
8040 fork_save_infrun_state calls.
8041
e52c971f
PA
80422019-03-06 Pedro Alves <palves@redhat.com>
8043
8044 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8045 (inf_has_multiple_threads): Return 'bool' and rewrite using
8046 inferior_info::threads().
8047
06974e6c
PA
80482019-03-06 Pedro Alves <palves@redhat.com>
8049
8050 * linux-fork.c: Include <list>.
8051 (fork_list): Now a std::list instance.
8052 (fork_info): Add ctor, dtor, and in-class initialize all fields.
8053 (forks_exist_p, find_last_fork): Adjust.
8054 (new_fork): Delete.
8055 (one_fork_p): New.
8056 (add_fork): Adjust.
8057 (free_fork): Delete, folded into fork_info::~fork_info().
8058 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8059 Adjust.
8060 (init_fork_list): Delete.
8061 (linux_fork_killall, linux_fork_mourn_inferior)
8062 (linux_fork_detach, info_checkpoints_command): Adjust.
8063 (_initialize_linux_fork): No longer call init_fork_list.
8064
72f31aea
PA
80652019-03-06 Pedro Alves <palves@redhat.com>
8066
8067 * linux-fork.c (new_fork): New, split out of ...
8068 (add_fork): ... this. Return void. Move "first fork" special
8069 case from here, to ...
8070 (checkpoint_command): ... here.
8071 * linux-linux.h (add_fork): Return void.
8072
efbecbc1
AB
80732019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8074
8075 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8076
0841c79a
AB
80772019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8078 Chris January <chris.january@arm.com>
8079 David Lecomber <david.lecomber@arm.com>
8080
8081 * f-exp.y: New token, UNOP_INTRINSIC.
8082 (exp): New pattern using UNOP_INTRINSIC token.
8083 (f77_keywords): Add 'abs' keyword.
8084 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8085 (value_from_host_double): New function.
8086 (evaluate_subexp_f): Support UNOP_ABS.
8087
4a270568
AB
80882019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8089
8090 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8091 types.
8092
067630bd
AB
80932019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8094
8095 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8096 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8097 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8098
3be47f7a
AB
80992019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8100
8101 * f-exp.y (convert_to_kind_type): Handle more type kinds.
8102
4d00f5d8
AB
81032019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8104 Chris January <chris.january@arm.com>
8105
8106 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8107 * f-exp.y: Define 'KIND' token.
8108 (exp): New pattern for KIND expressions.
8109 (ptype): Handle types with a kind extension.
8110 (direct_abs_decl): Extend to spot kind extensions.
8111 (f77_keywords): Add 'kind' to the list.
8112 (push_kind_type): New function.
8113 (convert_to_kind_type): New function.
8114 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8115 * parse.c (operator_length_standard): Likewise.
8116 * parser-defs.h (enum type_pieces): Add tp_kind.
8117 * std-operator.def: Add UNOP_KIND.
8118
e454224f
AB
81192019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8120
8121 * f-exp.y (f_parse): Set yydebug.
8122
9dad4a58
AB
81232019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8124
8125 * f-lang.c (evaluate_subexp_f): New function.
8126 (exp_descriptor_f): New global.
8127 (f_language_defn): Use exp_descriptor_f instead of
8128 exp_descriptor_standard.
8129
c8f91604
AB
81302019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8131
8132 * f-exp.y (struct token): Add comments.
8133 (dot_ops): Remove uppercase versions and the end marker.
8134 (f77_keywords): Likewise.
8135 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8136 entries in the dot_ops array are case insensitive, and use
8137 strncasecmp to compare strings. Also some whitespace cleanup in
8138 this area. Similar for the f77_keywords array, except entries in
8139 this list might be case sensitive.
8140
dd9f2c76
AB
81412019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8142
8143 * f-exp.y (struct f77_boolean_val): Add comments.
8144 (boolean_values): Remove uppercase versions, and end marker.
8145 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8146 and use strncasecmp to achieve case insensitivity. Additionally,
8147 perform whitespace cleanup around this code.
8148
67a3048c
TT
81492019-03-06 Tom Tromey <tromey@adacore.com>
8150
8151 * remote-sim.c (gdbsim_target_open): Use result of
8152 gdb_argv::release.
8153
aa3cfbda
RB
81542019-03-06 Richard Bunt <richard.bunt@arm.com>
8155 Dirk Schubert <dirk.schubert@arm.com>
8156 Chris January <chris.january@arm.com>
8157
8158 * eval.c (evaluate_subexp_standard): Call Fortran argument
8159 wrapping logic.
8160 * f-lang.c (struct value): A value which can be passed into a
8161 Fortran function call.
8162 (fortran_argument_convert): Wrap Fortran arguments in a pointer
8163 where appropriate.
8164 (struct type): Value ready for a Fortran function call.
8165 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8166 is needed.
8167 * f-lang.h (fortran_argument_convert): Declaration.
8168 (fortran_preserve_arg_pointer): Declaration.
8169 * infcall.c (value_arg_coerce): Call Fortran argument logic.
8170
ea38e5df
TT
81712019-03-05 Tom Tromey <tromey@adacore.com>
8172
8173 * python/py-prettyprint.c (print_string_repr): Remove #if.
8174 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8175
06b5b831
TT
81762019-03-05 Tom Tromey <tromey@adacore.com>
8177
8178 * target.c (the_dummy_target): Move later. Change type to
8179 "dummy_target".
8180 (initialize_targets): Don't initialize the_dummy_target.
8181
edbd9e45
TT
81822019-03-05 Tom Tromey <tromey@adacore.com>
8183
8184 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8185 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8186
c119e040
TT
81872019-03-05 Tom Tromey <tromey@adacore.com>
8188
8189 * windows-nat.c (windows_nat_target::attach)
8190 (windows_nat_target::detach): Don't call gdb_flush.
8191 * valprint.c (generic_val_print, val_print, val_print_string):
8192 Don't call gdb_flush.
8193 * utils.c (defaulted_query): Don't call gdb_flush.
8194 * typeprint.c (print_type_scalar): Don't call gdb_flush.
8195 * target.c (target_announce_detach): Don't call gdb_flush.
8196 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8197 * remote.c (extended_remote_target::attach): Don't call
8198 gdb_flush.
8199 * procfs.c (procfs_target::detach): Don't call gdb_flush.
8200 * printcmd.c (do_examine): Don't call gdb_flush.
8201 (info_display_command): Don't call gdb_flush.
8202 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8203 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8204 * memattr.c (info_mem_command): Don't call gdb_flush.
8205 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8206 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8207 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8208 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8209 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8210 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8211 (gnu_nat_target::detach): Don't call gdb_flush.
8212 * f-valprint.c (f_val_print): Don't call gdb_flush.
8213 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8214 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8215 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8216 gdb_flush.
8217 * c-valprint.c (c_val_print): Don't call gdb_flush.
8218 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8219
895dafa6
TT
82202019-03-05 Tom Tromey <tromey@adacore.com>
8221
8222 * varobj.c (update_dynamic_varobj_children): Update.
8223 (install_default_visualizer): Use reset, not release.
8224 * value.c (set_internalvar): Update.
8225 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8226 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8227 ATTRIBUTE_UNUSED_RESULT.
8228
88a774b9
TT
82292019-03-05 Tom Tromey <tromey@adacore.com>
8230
8231 * remote.c (class scoped_remote_fd) <release>: Add
8232 ATTRIBUTE_UNUSED_RESULT.
8233
4e4a8b93
TT
82342019-03-05 Tom Tromey <tromey@adacore.com>
8235
8236 * macroexp.c (struct macro_buffer) <release>: Add
8237 ATTRIBUTE_UNUSED_RESULT.
8238
083eef1f
TT
82392019-03-05 Tom Tromey <tromey@adacore.com>
8240
8241 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8242 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8243 ATTRIBUTE_UNUSED_RESULT.
8244
3cabd438
TT
82452019-03-05 Tom Tromey <tromey@adacore.com>
8246
8247 * common/scoped_fd.h (class scoped_fd) <release>: Add
8248 ATTRIBUTE_UNUSED_RESULT.
8249
41e3300a
TT
82502019-03-05 Tom Tromey <tromey@adacore.com>
8251
8252 * parser-defs.h (struct parser_state) <release>: Add
8253 ATTRIBUTE_UNUSED_RESULT.
8254
18cb7c9f
TT
82552019-03-05 Tom Tromey <tromey@adacore.com>
8256
8257 * utils.h (class gdb_argv) <release>: Add
8258 ATTRIBUTE_UNUSED_RESULT.
8259 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8260
41fa577f
EZ
82612019-03-02 Eli Zaretskii <eliz@gnu.org>
8262
a6a4b2c6
EZ
8263 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8264 for-loop range, to avoid compiler warnings.
8265
8266 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8267 avoid compiler warnings about unused variables.
8268
742a7df5
EZ
8269 * NEWS: Mention end of support for native debugging on MS-Windows
8270 before XP.
8271
41fa577f
EZ
8272 PR gdb/24292
8273 * common/netstuff.c:
8274 * gdbserver/gdbreplay.c
8275 * gdbserver/remote-utils.c:
8276 * ser-tcp.c:
8277 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8278 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
8279 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8280 'getaddrinfo' and 'freeaddrinfo' were not available before
8281 Windows XP, and mingw.org's MinGW headers by default define
8282 _WIN32_WINNT to 0x500.
8283
827f438f
GB
82842019-03-01 Gary Benson <gbenson@redhat.com>
8285
8286 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8287
92137da0
RO
82882019-02-28 Brian Vandenberg <phantall@gmail.com>
8289 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
8290
8291 PR gdb/8527
8292 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8293 set_sigint_trap, clear_sigint_trap.
8294
799efbe8
PW
82952019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8296
8297 * target.c (target_detach): Clear the regcache and the
8298 frame cache.
8299
8ed25214
PA
83002019-02-27 Pedro Alves <palves@redhat.com>
8301
8302 * utils.c (set_screen_size): When we cap the height/width sizes,
8303 tweak the corresponding command variable to show "unlimited":
8304
23031e31
SJ
83052019-02-27 Saagar Jha <saagar@saagarjha.com>
8306 Pedro Alves <palves@redhat.com>
8307
8308 * utils.c (set_screen_size): Reduce "infinite" rows and columns
8309 before calling rl_set_screen_size.
8310
6c28e44a
TT
83112019-02-27 Tom Tromey <tromey@adacore.com>
8312
8313 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8314 define.
8315 * python/py-value.c: Remove Python 2.4 workaround.
8316 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8317 workaround.
8318 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8319 Python 2.4 workaround.
8320 * python/python-internal.h: Remove Python 2.4 comment.
8321 (Py_ssize_t): Don't define.
8322 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8323 (gdb_Py_DECREF): Remove Python 2.4 workaround.
8324 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8325 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8326 * python/python.c (do_start_initialization): Remove Python 2.4
8327 workaround.
8328 * python/py-prettyprint.c (class dummy_python_frame): Remove.
8329 (print_children): Remove Python 2.4 workaround.
8330 * python/py-inferior.c (buffer_procs): Remove Python 2.4
8331 workaround.
8332 (CHARBUFFERPROC_NAME): Remove.
8333 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8334 Python 2.4 workaround.
8335
2c3fc25d 83362019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 8337
2c3fc25d
KB
8338 * NEWS: Note minimum Python version.
8339
6ca62222
KB
83402019-02-27 Kevin Buettner <kevinb@redhat.com>
8341
8342 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8343 code from these functions. Remove corresponding ifdefs. Use
8344 Py_buffer_up instead of explicit calls to PyBuffer_Release.
8345 Remove gotos and target of gotos.
8346 (infpy_search_memory): Likewise.
8347
f4bc7d2c
AB
83482019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8349
8350 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8351 (hppa_gdbarch_init): Don't register deleted functions with
8352 gdbarch.
8353
9734a586
AB
83542019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8355
8356 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8357 (h8300_unwind_sp): Delete.
8358 (h8300_dummy_id): Delete.
8359 (h8300_gdbarch_init): Don't register deleted functions with
8360 gdbarch.
8361
68b867f3
AB
83622019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8363
8364 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8365 (ft32_unwind_pc): Delete.
8366 (ft32_unwind_sp): Delete.
8367 (ft32_gdbarch_init): Don't register deleted functions with
8368 gdbarch.
8369
2fbe7ad0
AB
83702019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8371
8372 * gdb/frv-tdep.c (frv_dummy_id): Delete.
8373 (frv_unwind_pc): Delete.
8374 (frv_unwind_sp): Delete.
8375 (frv_gdbarch_init): Don't register deleted functions with
8376 gdbarch.
8377
76055cbe
AB
83782019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8379
8380 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8381 (riscv_unwind_pc): Delete.
8382 (riscv_unwind_sp): Delete.
8383 (riscv_gdbarch_init): Don't register deleted functions with
8384 gdbarch.
8385
4133e5a1
AB
83862019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8387
8388 * gdb/csky-tdep.c (csky_dummy_id): Delete.
8389 (csky_unwind_pc): Delete.
8390 (csky_unwind_sp): Delete.
8391 (csky_gdbarch_init): Don't register deleted functions with
8392 gdbarch.
8393
8010f576
AB
83942019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8395
8396 * gdb/cris-tdep.c (cris_dummy_id): Delete.
8397 (cris_unwind_pc): Delete.
8398 (cris_unwind_sp): Delete.
8399 (cris_gdbarch_init): Don't register deleted functions with
8400 gdbarch.
8401
b56bf084
AB
84022019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8403
8404 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8405 (bfin_unwind_pc): Delete.
8406 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8407
a19a650f
AB
84082019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8409
8410 * gdb/arm-tdep.c (arm_dummy_id): Delete.
8411 (arm_unwind_pc): Delete.
8412 (arm_unwind_sp): Delete.
8413 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8414
f8278c3c
AB
84152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8416
8417 * gdb/arc-tdep.c (arc_dummy_id): Delete.
8418 (arc_unwind_pc): Delete.
8419 (arc_unwind_sp): Delete.
8420 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8421
480e46cf
AB
84222019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8423
8424 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8425 (alpha_unwind_pc): Delete.
8426 (alpha_gdbarch_init): Don't register deleted functions with
8427 gdbarch.
8428
7a995095
AB
84292019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8430
8431 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8432 (aarch64_unwind_pc): Delete.
8433 (aarch64_unwind_sp): Delete.
8434 (aarch64_gdbarch_init): Don't register deleted functions with
8435 gdbarch.
8436
bf9a735e
AB
84372019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8438
8439 * gdbtypes.c (type_align): Don't consider static members when
8440 computing structure alignment.
8441
5561fc30
AB
84422019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8443
8444 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8445 return 0 for other types.
8446 * arch-utils.c (default_type_align): Always return 0.
8447 * gdbarch.h: Regenerate.
8448 * gdbarch.sh (type_align): Extend comment.
8449 * gdbtypes.c (type_align): Add additional comments, always call
8450 gdbarch_type_align before applying the default rules.
8451 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8452 generic code will then apply a suitable default.
8453 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8454 types, return 0 for other types.
8455
9335e75a
JB
84562019-02-27 Joel Brobecker <brobecker@adacore.com>
8457
8458 * NEWS: Create a new section for the next release branch.
8459 Rename the section of the current branch, now that it has
8460 been cut.
8461
3d34d8de
JB
84622019-02-27 Joel Brobecker <brobecker@adacore.com>
8463
8464 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8465 * version.in: Bump version to 8.3.50.DATE-git.
8466
143420fb
SM
84672019-02-26 Simon Marchi <simon.marchi@efficios.com>
8468
8469 * aix-thread.c (ptid_cmp): Remove unused variable.
8470 (get_signaled_thread): Likewise.
8471 (store_regs_user_thread): Likewise.
8472 (store_regs_kernel_thread): Likewise.
8473 (fetch_regs_kernel_thread): Remove shadowed variable.
8474
172fb711
AB
84752019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
8476
8477 * features/riscv/32bit-cpu.xml: Add register numbers.
8478 * features/riscv/32bit-fpu.c: Regenerate.
8479 * features/riscv/32bit-fpu.xml: Add register numbers.
8480 * features/riscv/64bit-cpu.xml: Add register numbers.
8481 * features/riscv/64bit-fpu.c: Regenerate.
8482 * features/riscv/64bit-fpu.xml: Add register numbers.
8483
26c89782
KB
84842019-02-26 Kevin Buettner <kevinb@redhat.com>
8485
af54ade9 8486 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
8487 * python/py-value.c (convert_buffer_and_type_to_value): New
8488 function.
8489 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8490 Add support for handling an optional second argument. Call
8491 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
8492 * python/python-internal.h (Py_buffer_deleter): New struct.
8493 (Py_buffer_up): New typedef.
8494
0f58c9e8
JB
84952019-02-25 John Baldwin <jhb@FreeBSD.org>
8496
8497 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8498 instead of releasing ownership.
8499
0a0f4c01
JR
85002019-02-25 Jordan Rupprecht <rupprecht@google.com>
8501
8502 * dwarf2read.c (open_and_init_dwp_file): Call
8503 elf_numsections instead of bfd_count_sections to initialize
8504 dwp_file->num_sections.
8505
cd5a152c
TT
85062019-02-25 Tom Tromey <tromey@adacore.com>
8507
8508 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8509
8a6a8513
SDJ
85102019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
8511
8512 * gcore.in: Add '--readnever' option when invoking GDB.
8513
04dcda9c
SM
85142019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
8515
8516 * MAINTAINERS: Update my email address.
8517
07bc701d
SM
85182019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
8519
8520 * build-id.c (build_id_to_debug_bfd_1): New function.
8521 (build_id_to_debug_bfd): Look for separate debug file in
8522 sysroot.
8523
c6f4a5d0
AB
85242019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
8525
8526 * gdbarch.sh: Update the copyright year range that is placed into
8527 generated files.
8528
9600246d
KS
85292019-02-22 Keith Seitz <keiths@redhat.com>
8530
8531 PR symtab/23853
8532 * linespec.c (create_sals_line_offset): Search for the default
8533 symtab's filename instead of its fullname.
8534
7557a514
AH
85352019-02-21 Alan Hayward <alan.hayward@arm.com>
8536
8537 * NEWS: Update style defaults.
8538
ee2bcb0c
AH
85392019-02-21 Alan Hayward <alan.hayward@arm.com>
8540
8541 * main.c (captured_main_1): Disable styling in batch mode.
8542
0c95f9ed
TT
85432019-02-20 Tom Tromey <tom@tromey.com>
8544
8545 * symtab.c (symtab_symbol_info): Fix typos.
8546
c763b894
TT
85472019-02-20 Tom Tromey <tromey@adacore.com>
8548
8549 * findcmd.c (_initialize_mem_search): Use upper case for
8550 metasyntactic variables.
8551
0ef8a082
AH
85522019-02-20 Alan Hayward <alan.hayward@arm.com>
8553
8554 * aarch64-tdep.c (aarch64_add_reggroups): New function.
8555 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8556
6caa91b6
SM
85572019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
8558
8559 * top.h (source_file_name): Change to std::string.
8560 * top.c (source_file_name): Likewise.
8561 (command_line_input): Adjust.
8562 * cli/cli-script.c (script_from_file): Adjust.
8563
98814c6c
TT
85642019-02-19 Tom Tromey <tromey@adacore.com>
8565
8566 * ravenscar-thread.c
8567 (ravenscar_thread_target::update_thread_list): Don't call
8568 ada_build_task_list.
8569 * ada-lang.h (ada_build_task_list): Don't declare.
8570 * ada-tasks.c (struct ada_tasks_inferior_data)
8571 <task_list_valid_p>: Now bool.
8572 (read_known_tasks, ada_task_list_changed)
8573 (ada_tasks_invalidate_inferior_data): Update.
8574 (read_known_tasks_array): Return bool.
8575 (read_known_tasks_list): Likewise.
8576 (read_known_tasks): Return void.
8577 (ada_build_task_list): Now static.
8578
70cd633e
AB
85792019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
8580
8581 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8582 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8583
040b3e95
PW
85842019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8585
8586 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8587 variant for ada_tasks_pspace_data_handle and
8588 ada_tasks_inferior_data_handle.
8589 (ada_tasks_pspace_data_cleanup): New function.
8590 (ada_tasks_inferior_data_cleanup): New function.
8591
9409233b
TT
85922019-02-17 Tom Tromey <tom@tromey.com>
8593
8594 * macrotab.h (macro_source_fullname): Return a std::string.
8595 * macrotab.c (macro_include, check_for_redefinition)
8596 (macro_undef, macro_lookup_definition, foreach_macro)
8597 (foreach_macro_in_scope): Update.
8598 (macro_source_fullname): Return a std::string.
8599 * macrocmd.c (show_pp_source_pos): Update.
8600
6506371f
TT
86012019-02-17 Tom Tromey <tom@tromey.com>
8602
8603 * macrocmd.c (show_pp_source_pos): Style the file names.
8604
0c820d67
TT
86052019-02-17 Tom Tromey <tom@tromey.com>
8606
8607 PR tui/24197:
8608 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8609
a0087920
TT
86102019-02-17 Tom Tromey <tom@tromey.com>
8611
8612 * ada-lang.c (user_select_syms): Use filtered printing.
8613 * utils.c (wrap_style): New global.
8614 (desired_style): Remove.
8615 (emit_style_escape): Add stream parameter.
8616 (set_output_style, reset_terminal_style, prompt_for_continue):
8617 Update.
8618 (flush_wrap_buffer): Only flush gdb_stdout.
8619 (wrap_here): Set wrap_style.
8620 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
8621 treat escape sequences as a character. Change when wrap buffer is
8622 flushed.
8623 (fputs_styled): Do not set the output style when the default is
8624 requested.
8625 * ui-style.h (struct ui_file_style) <is_default>: New method.
8626 * source.c (print_source_lines_base): Emit escape sequences in one
8627 piece.
8628
75ba10dc
JB
86292019-02-17 Joel Brobecker <brobecker@adacore.com>
8630
8631 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8632 integers and enumeration types.
8633
a2cd4f14
JB
86342019-02-17 Joel Brobecker <brobecker@adacore.com>
8635
8636 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8637 instead of lookup_symbol_in_language
8638 (do_exact_match): New function.
8639 (ada_get_symbol_name_matcher): Return do_exact_match when
8640 doing a verbatim match.
8641
485b851b
TT
86422019-02-15 Tom Tromey <tromey@adacore.com>
8643
8644 * ravenscar-thread.c (ravenscar_thread_target::resume)
8645 (ravenscar_thread_target::wait): Special case wildcard requests.
8646
0b790b1e
TT
86472019-02-15 Tom Tromey <tromey@adacore.com>
8648
8649 * ravenscar-thread.c (base_ptid): Remove.
8650 (struct ravenscar_thread_target) <close>: New method.
8651 <m_base_ptid>: New member.
8652 <update_inferior_ptid, active_task, task_is_currently_active,
8653 runtime_initialized>: Declare methods.
8654 <ravenscar_thread_target>: Add constructor.
8655 (ravenscar_thread_target::task_is_currently_active)
8656 (ravenscar_thread_target::update_inferior_ptid)
8657 (ravenscar_runtime_initialized): Rename. Now methods.
8658 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8659 (ravenscar_thread_target::update_thread_list): Update.
8660 (ravenscar_thread_target::active_task): Now method.
8661 (ravenscar_thread_target::store_registers)
8662 (ravenscar_thread_target::prepare_to_store)
8663 (ravenscar_thread_target::prepare_to_store)
8664 (ravenscar_thread_target::mourn_inferior): Update.
8665 (ravenscar_inferior_created): Use "new" to create target.
8666 (ravenscar_thread_target::get_ada_task_ptid): Update.
8667 (_initialize_ravenscar): Don't initialize base_ptid.
8668 (ravenscar_ops): Remove global.
8669
dea57a62
TT
86702019-02-15 Tom Tromey <tromey@adacore.com>
8671
8672 * target.h (push_target): Declare new overload.
8673 * target.c (push_target): New overload, taking an rvalue reference.
8674 * remote.c (remote_target::open_1): Use push_target overload.
8675 * corelow.c (core_target_open): Use push_target overload.
8676
989f3c58
TT
86772019-02-15 Tom Tromey <tromey@adacore.com>
8678
8679 * ravenscar-thread.c (is_ravenscar_task)
8680 (ravenscar_task_is_currently_active): Return bool.
8681 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8682 (_initialize_ravenscar): Remove "(void)".
8683 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8684 Return bool.
8685
6cbcc006
TT
86862019-02-15 Tom Tromey <tromey@adacore.com>
8687
8688 * ravenscar-thread.c (ravenscar_runtime_initializer)
8689 (has_ravenscar_runtime, get_running_thread_id)
8690 (ravenscar_thread_target::resume): Fix indentation.
8691
7657f14d
TT
86922019-02-15 Tom Tromey <tromey@adacore.com>
8693
8694 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8695 from ravenscar_arch_ops.
8696 (sparc_ravenscar_ops::fetch_registers)
8697 (sparc_ravenscar_ops::store_registers): Now methods.
8698 (sparc_ravenscar_prepare_to_store): Remove.
8699 (sparc_ravenscar_ops): Redefine.
8700 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8701 methods and destructor. Remove members.
8702 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8703 (ravenscar_thread_target::store_registers)
8704 (ravenscar_thread_target::prepare_to_store): Update.
8705 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8706 Remove.
8707 (struct ppc_ravenscar_powerpc_ops): Derive from
8708 ravenscar_arch_ops.
8709 (ppc_ravenscar_powerpc_ops::fetch_registers)
8710 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8711 (ppc_ravenscar_powerpc_ops): Redefine.
8712 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8713 (ppc_ravenscar_e500_ops::fetch_registers)
8714 (ppc_ravenscar_e500_ops::store_registers): Now methods.
8715 (ppc_ravenscar_e500_ops): Redefine.
8716 * aarch64-ravenscar-thread.c
8717 (aarch64_ravenscar_generic_prepare_to_store): Remove.
8718 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8719 (aarch64_ravenscar_fetch_registers)
8720 (aarch64_ravenscar_store_registers): Now methods.
8721 (aarch64_ravenscar_ops): Redefine.
8722
5b6ea500
TT
87232019-02-15 Tom Tromey <tromey@adacore.com>
8724
8725 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8726 (ravenscar_thread_target::stopped_by_hw_breakpoint)
8727 (ravenscar_thread_target::stopped_by_watchpoint)
8728 (ravenscar_thread_target::stopped_data_address)
8729 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8730
e397fd39
TT
87312019-02-15 Tom Tromey <tromey@adacore.com>
8732
8733 * ravenscar-thread.c: Fix some typos.
8734
cc12f4a8
TT
87352019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8736 Tom Tromey <tromey@adacore.com>
8737
8738 * ada-lang.c (ada_exception_sal): Change addr_string to a
8739 std::string.
8740 (create_ada_exception_catchpoint): Update.
8741
5f486660
TT
87422019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8743 Tom Tromey <tromey@adacore.com>
8744
8745 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8746 (bp_location_ops): Remove.
8747 (base_breakpoint_allocate_location): Update.
8748 (free_bp_location): Update.
8749 * ada-lang.c (class ada_catchpoint_location)
8750 <ada_catchpoint_location>: Remove ops parameter.
8751 (ada_catchpoint_location_dtor): Remove.
8752 (ada_catchpoint_location_ops): Remove.
8753 (allocate_location_exception): Update.
8754 * breakpoint.h (struct bp_location_ops): Remove.
8755 (class bp_location) <bp_location>: Remove bp_location_ops
8756 parameter.
8757 <~bp_location>: Add destructor.
8758 <ops>: Remove.
8759
b671c7fb
TS
87602019-02-14 Thomas Schwinge <thomas@codesourcery.com>
8761 Pedro Alves <palves@redhat.com>
8762
8763 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8764 'PATH_MAX'.
8765
8071c5ce
DM
87662019-02-14 David Michael <fedora.dm0@gmail.com>
8767 Samuel Thibault <samuel.thibault@gnu.org>
8768 Thomas Schwinge <thomas@codesourcery.com>
8769
8770 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8771 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8772
b1041ae0
TS
87732019-02-14 Thomas Schwinge <thomas@codesourcery.com>
8774
924514e1
TS
8775 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8776 (check_empty): Use "const char *".
8777
c29ee8d4
TS
8778 * gnu-nat.c (gnu_nat_target::detach): Instead of
8779 'detach_inferior (pid)' call
8780 'detach_inferior (find_inferior_pid (pid))'.
8781
6c6ef69f
TS
8782 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8783 'nat/fork-inferior.o'.
8784 * gnu-nat.c: #include "nat/fork-inferior.h".
8785
2d0a338c
TS
8786 * gnu-nat.c (gnu_nat_target::detach): Instead of
8787 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8788 * gnu-nat.h: #include "inf-child.h".
8789 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8790 'i386_gnu_nat_target::fetch_registers'.
8791 (gnu_store_registers): Rename/move to
8792 'i386_gnu_nat_target::store_registers'.
8793
cabb5f06
TS
8794 * config/i386/nm-i386gnu.h: Don't "#include" any files.
8795 * gnu-nat.h (mach_thread_info): New function.
8796 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8797
b1041ae0
TS
8798 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8799
2988d01e
KF
88002019-02-14 Frederic Konrad <konrad@adacore.com>
8801
8802 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8803
c559d709
JB
88042019-02-14 Joel Brobecker <brobecker@adacore.com>
8805
8806 * windows-nat.c (windows_add_thread): Add new parameter
8807 "main_thread_p" with default value set to false. Update
8808 function documentation as well as all callers.
8809 (windows_delete_thread): Likewise.
8810 (fake_create_process): Update call to windows_add_thread.
8811 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8812 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8813 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8814 call to windows_delete_thread.
8815
007024cc
SM
88162019-02-13 Simon Marchi <simon.marchi@ericsson.com>
8817
8818 * MAINTAINERS: Add Andrew Burgess as global maintainer.
8819
f62318e9
JB
88202019-02-12 John Baldwin <jhb@FreeBSD.org>
8821
8822 * symfile.c (find_separate_debug_file): Use canonical path of
8823 sysroot with child_path instead of gdb_sysroot if it is valid.
8824
cd4b7848
JB
88252019-02-12 John Baldwin <jhb@FreeBSD.org>
8826
8827 * symfile.c (find_separate_debug_file): Use child_path to
8828 determine if an object file is under a sysroot.
8829
efac4bfe
JB
88302019-02-12 John Baldwin <jhb@FreeBSD.org>
8831
8832 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8833 unittests/child-path-selftests.c.
8834 * common/pathstuff.c (child_path): New function.
8835 * common/pathstuff.h (child_path): New prototype.
8836 * unittests/child-path-selftests.c: New file.
8837
402d2bfe
JB
88382019-02-12 John Baldwin <jhb@FreeBSD.org>
8839
8840 * symfile.c (find_separate_debug_file): Look for separate debug
8841 files in debug directories under the sysroot.
8842
1ed9f74e
PW
88432019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8844
8845 * symtab.h (struct minimal_symbol data_p): New const method.
8846 (struct minimal_symbol text_p): Likewise.
8847 * symtab.c (output_source_filename): Use file name style
8848 to print file name.
8849 (print_symbol_info): Likewise.
8850 (print_msymbol_info): Use address style to print addresses.
8851 Use function name style to print executable text symbols.
8852 (expand_symtab_containing_pc): Use data_p.
8853 (find_pc_sect_compunit_symtab): Likewise.
8854
2636d81d
PW
88552019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8856
8857 * breakpoint.c (describe_other_breakpoints): Use address style
8858 to print addresses.
8859 (say_where): Likewise.
8860
ac8c53cc
PW
88612019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8862
8863 * ada-typeprint.c (print_func_type): Print function name
8864 style to print function name.
8865 * c-typeprint.c (c_print_type_1): Likewise.
8866
ea638c43
AH
88672019-02-11 Alan Hayward <alan.hayward@arm.com>
8868
8869 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8870 for execve.
8871
ab759ca8
PW
88722019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8873
8874 * c-exp.y (direct_abs_decl): Use emplace_back to record the
8875 type_stack.
8876
aff29d1c
JB
88772019-02-10 Joel Brobecker <brobecker@adacore.com>
8878
8879 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8880 TYPE_CODE_REF types.
8881
617126bc
JW
88822019-02-08 Jim Wilson <jimw@sifive.com>
8883
8884 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8885 (riscv_linux_fregset): New.
8886 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8887
46e3ed7f
TT
88882019-02-07 Tom Tromey <tom@tromey.com>
8889
8890 * thread.c (thread_cancel_execution_command): Update.
8891 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8892 methods.
8893 (struct thread_fsm_ops): Remove.
8894 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8895 (thread_fsm_should_stop, thread_fsm_return_value)
8896 (thread_fsm_set_finished, thread_fsm_finished_p)
8897 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8898 Don't declare.
8899 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8900 * infrun.c (clear_proceed_status_thread)
8901 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8902 (print_stop_event): Update.
8903 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8904 Add constructor.
8905 (step_command_fsm_ops): Remove.
8906 (new_step_command_fsm): Remove.
8907 (step_1): Update.
8908 (step_command_fsm::should_stop): Rename from
8909 step_command_fsm_should_stop.
8910 (step_command_fsm::clean_up): Rename from
8911 step_command_fsm_clean_up.
8912 (step_command_fsm::do_async_reply_reason): Rename from
8913 step_command_fsm_async_reply_reason.
8914 (struct until_next_fsm): Inherit from thread_fsm. Add
8915 constructor.
8916 (until_next_fsm_ops): Remove.
8917 (new_until_next_fsm): Remove.
8918 (until_next_fsm::should_stop): Rename from
8919 until_next_fsm_should_stop.
8920 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8921 (until_next_fsm::do_async_reply_reason): Rename from
8922 until_next_fsm_async_reply_reason.
8923 (struct finish_command_fsm): Inherit from thread_fsm. Add
8924 constructor. Change type of breakpoint.
8925 (finish_command_fsm_ops): Remove.
8926 (new_finish_command_fsm): Remove.
8927 (finish_command_fsm::should_stop): Rename from
8928 finish_command_fsm_should_stop.
8929 (finish_command_fsm::clean_up): Rename from
8930 finish_command_fsm_clean_up.
8931 (finish_command_fsm::return_value): Rename from
8932 finish_command_fsm_return_value.
8933 (finish_command_fsm::do_async_reply_reason): Rename from
8934 finish_command_fsm_async_reply_reason.
8935 (finish_command): Update.
8936 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8937 Add constructor.
8938 (call_thread_fsm_ops): Remove.
8939 (call_thread_fsm::call_thread_fsm): Rename from
8940 new_call_thread_fsm.
8941 (call_thread_fsm::should_stop): Rename from
8942 call_thread_fsm_should_stop.
8943 (call_thread_fsm::should_notify_stop): Rename from
8944 call_thread_fsm_should_notify_stop.
8945 (run_inferior_call, call_function_by_hand_dummy): Update.
8946 * cli/cli-interp.c (should_print_stop_to_console): Update.
8947 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8948 Add constructor. Change type of location_breakpoint,
8949 caller_breakpoint.
8950 (until_break_fsm_ops): Remove.
8951 (new_until_break_fsm): Remove.
8952 (until_break_fsm::should_stop): Rename from
8953 until_break_fsm_should_stop.
8954 (until_break_fsm::clean_up): Rename from
8955 until_break_fsm_clean_up.
8956 (until_break_fsm::do_async_reply_reason): Rename from
8957 until_break_fsm_async_reply_reason.
8958 (until_break_command): Update.
8959 * thread-fsm.c: Remove.
8960 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8961
1a5c2598
TT
89622019-02-07 Tom Tromey <tom@tromey.com>
8963
8964 * yy-remap.h: Add include guard.
8965 * xtensa-tdep.h: Add include guard.
8966 * xcoffread.h: Rename include guard.
8967 * varobj-iter.h: Add include guard.
8968 * tui/tui.h: Rename include guard.
8969 * tui/tui-winsource.h: Rename include guard.
8970 * tui/tui-wingeneral.h: Rename include guard.
8971 * tui/tui-windata.h: Rename include guard.
8972 * tui/tui-win.h: Rename include guard.
8973 * tui/tui-stack.h: Rename include guard.
8974 * tui/tui-source.h: Rename include guard.
8975 * tui/tui-regs.h: Rename include guard.
8976 * tui/tui-out.h: Rename include guard.
8977 * tui/tui-layout.h: Rename include guard.
8978 * tui/tui-io.h: Rename include guard.
8979 * tui/tui-hooks.h: Rename include guard.
8980 * tui/tui-file.h: Rename include guard.
8981 * tui/tui-disasm.h: Rename include guard.
8982 * tui/tui-data.h: Rename include guard.
8983 * tui/tui-command.h: Rename include guard.
8984 * tic6x-tdep.h: Add include guard.
8985 * target/waitstatus.h: Rename include guard.
8986 * target/wait.h: Rename include guard.
8987 * target/target.h: Rename include guard.
8988 * target/resume.h: Rename include guard.
8989 * target-float.h: Rename include guard.
8990 * stabsread.h: Add include guard.
8991 * rs6000-tdep.h: Add include guard.
8992 * riscv-fbsd-tdep.h: Add include guard.
8993 * regformats/regdef.h: Rename include guard.
8994 * record.h: Rename include guard.
8995 * python/python.h: Rename include guard.
8996 * python/python-internal.h: Rename include guard.
8997 * python/py-stopevent.h: Rename include guard.
8998 * python/py-ref.h: Rename include guard.
8999 * python/py-record.h: Rename include guard.
9000 * python/py-record-full.h: Rename include guard.
9001 * python/py-record-btrace.h: Rename include guard.
9002 * python/py-instruction.h: Rename include guard.
9003 * python/py-events.h: Rename include guard.
9004 * python/py-event.h: Rename include guard.
9005 * procfs.h: Add include guard.
9006 * proc-utils.h: Add include guard.
9007 * p-lang.h: Add include guard.
9008 * or1k-tdep.h: Rename include guard.
9009 * observable.h: Rename include guard.
9010 * nto-tdep.h: Rename include guard.
9011 * nat/x86-linux.h: Rename include guard.
9012 * nat/x86-linux-dregs.h: Rename include guard.
9013 * nat/x86-gcc-cpuid.h: Add include guard.
9014 * nat/x86-dregs.h: Rename include guard.
9015 * nat/x86-cpuid.h: Rename include guard.
9016 * nat/ppc-linux.h: Rename include guard.
9017 * nat/mips-linux-watch.h: Rename include guard.
9018 * nat/linux-waitpid.h: Rename include guard.
9019 * nat/linux-ptrace.h: Rename include guard.
9020 * nat/linux-procfs.h: Rename include guard.
9021 * nat/linux-osdata.h: Rename include guard.
9022 * nat/linux-nat.h: Rename include guard.
9023 * nat/linux-namespaces.h: Rename include guard.
9024 * nat/linux-btrace.h: Rename include guard.
9025 * nat/glibc_thread_db.h: Rename include guard.
9026 * nat/gdb_thread_db.h: Rename include guard.
9027 * nat/gdb_ptrace.h: Rename include guard.
9028 * nat/fork-inferior.h: Rename include guard.
9029 * nat/amd64-linux-siginfo.h: Rename include guard.
9030 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9031 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9032 * nat/aarch64-linux.h: Rename include guard.
9033 * nat/aarch64-linux-hw-point.h: Rename include guard.
9034 * mn10300-tdep.h: Add include guard.
9035 * mips-linux-tdep.h: Add include guard.
9036 * mi/mi-parse.h: Rename include guard.
9037 * mi/mi-out.h: Rename include guard.
9038 * mi/mi-main.h: Rename include guard.
9039 * mi/mi-interp.h: Rename include guard.
9040 * mi/mi-getopt.h: Rename include guard.
9041 * mi/mi-console.h: Rename include guard.
9042 * mi/mi-common.h: Rename include guard.
9043 * mi/mi-cmds.h: Rename include guard.
9044 * mi/mi-cmd-break.h: Rename include guard.
9045 * m2-lang.h: Add include guard.
9046 * location.h: Rename include guard.
9047 * linux-record.h: Rename include guard.
9048 * linux-nat.h: Add include guard.
9049 * linux-fork.h: Add include guard.
9050 * i386-darwin-tdep.h: Rename include guard.
9051 * hppa-linux-offsets.h: Add include guard.
9052 * guile/guile.h: Rename include guard.
9053 * guile/guile-internal.h: Rename include guard.
9054 * gnu-nat.h: Rename include guard.
9055 * gdb-stabs.h: Rename include guard.
9056 * frv-tdep.h: Add include guard.
9057 * f-lang.h: Add include guard.
9058 * event-loop.h: Add include guard.
9059 * darwin-nat.h: Rename include guard.
9060 * cp-abi.h: Rename include guard.
9061 * config/sparc/nm-sol2.h: Rename include guard.
9062 * config/nm-nto.h: Rename include guard.
9063 * config/nm-linux.h: Add include guard.
9064 * config/i386/nm-i386gnu.h: Rename include guard.
9065 * config/djgpp/nl_types.h: Rename include guard.
9066 * config/djgpp/langinfo.h: Rename include guard.
9067 * compile/gcc-cp-plugin.h: Add include guard.
9068 * compile/gcc-c-plugin.h: Add include guard.
9069 * compile/compile.h: Rename include guard.
9070 * compile/compile-object-run.h: Rename include guard.
9071 * compile/compile-object-load.h: Rename include guard.
9072 * compile/compile-internal.h: Rename include guard.
9073 * compile/compile-cplus.h: Rename include guard.
9074 * compile/compile-c.h: Rename include guard.
9075 * common/xml-utils.h: Rename include guard.
9076 * common/x86-xstate.h: Rename include guard.
9077 * common/version.h: Rename include guard.
9078 * common/vec.h: Rename include guard.
9079 * common/tdesc.h: Rename include guard.
9080 * common/selftest.h: Rename include guard.
9081 * common/scoped_restore.h: Rename include guard.
9082 * common/scoped_mmap.h: Rename include guard.
9083 * common/scoped_fd.h: Rename include guard.
9084 * common/safe-iterator.h: Rename include guard.
9085 * common/run-time-clock.h: Rename include guard.
9086 * common/refcounted-object.h: Rename include guard.
9087 * common/queue.h: Rename include guard.
9088 * common/ptid.h: Rename include guard.
9089 * common/print-utils.h: Rename include guard.
9090 * common/preprocessor.h: Rename include guard.
9091 * common/pathstuff.h: Rename include guard.
9092 * common/observable.h: Rename include guard.
9093 * common/netstuff.h: Rename include guard.
9094 * common/job-control.h: Rename include guard.
9095 * common/host-defs.h: Rename include guard.
9096 * common/gdb_wait.h: Rename include guard.
9097 * common/gdb_vecs.h: Rename include guard.
9098 * common/gdb_unlinker.h: Rename include guard.
9099 * common/gdb_unique_ptr.h: Rename include guard.
9100 * common/gdb_tilde_expand.h: Rename include guard.
9101 * common/gdb_sys_time.h: Rename include guard.
9102 * common/gdb_string_view.h: Rename include guard.
9103 * common/gdb_splay_tree.h: Rename include guard.
9104 * common/gdb_setjmp.h: Rename include guard.
9105 * common/gdb_ref_ptr.h: Rename include guard.
9106 * common/gdb_optional.h: Rename include guard.
9107 * common/gdb_locale.h: Rename include guard.
9108 * common/gdb_assert.h: Rename include guard.
9109 * common/filtered-iterator.h: Rename include guard.
9110 * common/filestuff.h: Rename include guard.
9111 * common/fileio.h: Rename include guard.
9112 * common/environ.h: Rename include guard.
9113 * common/common-utils.h: Rename include guard.
9114 * common/common-types.h: Rename include guard.
9115 * common/common-regcache.h: Rename include guard.
9116 * common/common-inferior.h: Rename include guard.
9117 * common/common-gdbthread.h: Rename include guard.
9118 * common/common-exceptions.h: Rename include guard.
9119 * common/common-defs.h: Rename include guard.
9120 * common/common-debug.h: Rename include guard.
9121 * common/cleanups.h: Rename include guard.
9122 * common/buffer.h: Rename include guard.
9123 * common/btrace-common.h: Rename include guard.
9124 * common/break-common.h: Rename include guard.
9125 * cli/cli-utils.h: Rename include guard.
9126 * cli/cli-style.h: Rename include guard.
9127 * cli/cli-setshow.h: Rename include guard.
9128 * cli/cli-script.h: Rename include guard.
9129 * cli/cli-interp.h: Rename include guard.
9130 * cli/cli-decode.h: Rename include guard.
9131 * cli/cli-cmds.h: Rename include guard.
9132 * charset-list.h: Add include guard.
9133 * buildsym-legacy.h: Rename include guard.
9134 * bfin-tdep.h: Add include guard.
9135 * ax.h: Rename include guard.
9136 * arm-linux-tdep.h: Add include guard.
9137 * arm-fbsd-tdep.h: Add include guard.
9138 * arch/xtensa.h: Rename include guard.
9139 * arch/tic6x.h: Add include guard.
9140 * arch/i386.h: Add include guard.
9141 * arch/arm.h: Rename include guard.
9142 * arch/arm-linux.h: Rename include guard.
9143 * arch/arm-get-next-pcs.h: Rename include guard.
9144 * arch/amd64.h: Add include guard.
9145 * arch/aarch64-insn.h: Rename include guard.
9146 * arch-utils.h: Rename include guard.
9147 * annotate.h: Add include guard.
9148 * amd64-darwin-tdep.h: Rename include guard.
9149 * aarch64-linux-tdep.h: Add include guard.
9150 * aarch64-fbsd-tdep.h: Add include guard.
9151 * aarch32-linux-nat.h: Add include guard.
9152
ab9268d2
PW
91532019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9154
9155 * macrotab.c (macro_define_internal): New function that
9156 factorizes macro_define_object_internal and macro_define_function
9157 code.
9158 (macro_define_object_internal): Use macro_define_internal.
9159 (macro_define_function): Likewise.
9160
bb0da2b4
PW
91612019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9162
9163 * macrocmd.c (extract_identifier): Return
9164 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9165 callers.
9166
424eb552
JB
91672019-02-06 John Baldwin <jhb@FreeBSD.org>
9168
9169 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9170
1688cb29
TT
91712019-02-05 Tom Tromey <tom@tromey.com>
9172
9173 * target.c (target_stack::unpush): Move assertion earlier.
9174
b5eba2d8
TT
91752019-01-30 Tom Tromey <tom@tromey.com>
9176
9177 PR python/23615:
9178 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9179 (gdbpy_parse_and_eval): Likewise.
9180 * python/python-internal.h (gdbpy_allow_threads): New class.
9181
7054e2ff
JB
91822019-01-28 John Baldwin <jhb@FreeBSD.org>
9183
9184 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9185 (aarch64_fbsd_fpregmap): Move earlier.
9186 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9187 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9188 instead of individual calls to trad_frame_set_reg_addr.
9189 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9190 earlier.
9191 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9192 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9193 instead of individual calls to trad_frame_set_reg_addr.
9194
36c25ffa
AH
91952019-01-28 Alan Hayward <alan.hayward@arm.com>
9196
9197 * CONTRIBUTE: Replace contribution list with wiki link.
9198
a0707f3c
TT
91992019-01-25 Tom Tromey <tom@tromey.com>
9200
9201 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9202
0747795c
TT
92032019-01-25 Tom Tromey <tom@tromey.com>
9204
9205 * xtensa-linux-nat.c: Fix common/ includes.
9206 * xml-support.h: Fix common/ includes.
9207 * xml-support.c: Fix common/ includes.
9208 * x86-linux-nat.c: Fix common/ includes.
9209 * windows-nat.c: Fix common/ includes.
9210 * varobj.h: Fix common/ includes.
9211 * varobj.c: Fix common/ includes.
9212 * value.c: Fix common/ includes.
9213 * valops.c: Fix common/ includes.
9214 * utils.c: Fix common/ includes.
9215 * unittests/xml-utils-selftests.c: Fix common/ includes.
9216 * unittests/utils-selftests.c: Fix common/ includes.
9217 * unittests/unpack-selftests.c: Fix common/ includes.
9218 * unittests/tracepoint-selftests.c: Fix common/ includes.
9219 * unittests/style-selftests.c: Fix common/ includes.
9220 * unittests/string_view-selftests.c: Fix common/ includes.
9221 * unittests/scoped_restore-selftests.c: Fix common/ includes.
9222 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9223 * unittests/scoped_fd-selftests.c: Fix common/ includes.
9224 * unittests/rsp-low-selftests.c: Fix common/ includes.
9225 * unittests/parse-connection-spec-selftests.c: Fix common/
9226 includes.
9227 * unittests/optional-selftests.c: Fix common/ includes.
9228 * unittests/offset-type-selftests.c: Fix common/ includes.
9229 * unittests/observable-selftests.c: Fix common/ includes.
9230 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9231 * unittests/memrange-selftests.c: Fix common/ includes.
9232 * unittests/memory-map-selftests.c: Fix common/ includes.
9233 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9234 * unittests/function-view-selftests.c: Fix common/ includes.
9235 * unittests/environ-selftests.c: Fix common/ includes.
9236 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9237 * unittests/common-utils-selftests.c: Fix common/ includes.
9238 * unittests/cli-utils-selftests.c: Fix common/ includes.
9239 * unittests/array-view-selftests.c: Fix common/ includes.
9240 * ui-file.c: Fix common/ includes.
9241 * tui/tui-io.c: Fix common/ includes.
9242 * tracepoint.h: Fix common/ includes.
9243 * tracepoint.c: Fix common/ includes.
9244 * tracefile-tfile.c: Fix common/ includes.
9245 * top.h: Fix common/ includes.
9246 * top.c: Fix common/ includes.
9247 * thread.c: Fix common/ includes.
9248 * target/waitstatus.h: Fix common/ includes.
9249 * target/waitstatus.c: Fix common/ includes.
9250 * target.h: Fix common/ includes.
9251 * target.c: Fix common/ includes.
9252 * target-memory.c: Fix common/ includes.
9253 * target-descriptions.c: Fix common/ includes.
9254 * symtab.h: Fix common/ includes.
9255 * symfile.c: Fix common/ includes.
9256 * stap-probe.c: Fix common/ includes.
9257 * spu-linux-nat.c: Fix common/ includes.
9258 * sparc-nat.c: Fix common/ includes.
9259 * source.c: Fix common/ includes.
9260 * solib.c: Fix common/ includes.
9261 * solib-target.c: Fix common/ includes.
9262 * ser-unix.c: Fix common/ includes.
9263 * ser-tcp.c: Fix common/ includes.
9264 * ser-pipe.c: Fix common/ includes.
9265 * ser-base.c: Fix common/ includes.
9266 * selftest-arch.c: Fix common/ includes.
9267 * s12z-tdep.c: Fix common/ includes.
9268 * rust-exp.y: Fix common/ includes.
9269 * rs6000-aix-tdep.c: Fix common/ includes.
9270 * riscv-tdep.c: Fix common/ includes.
9271 * remote.c: Fix common/ includes.
9272 * remote-notif.h: Fix common/ includes.
9273 * remote-fileio.h: Fix common/ includes.
9274 * remote-fileio.c: Fix common/ includes.
9275 * regcache.h: Fix common/ includes.
9276 * regcache.c: Fix common/ includes.
9277 * record-btrace.c: Fix common/ includes.
9278 * python/python.c: Fix common/ includes.
9279 * python/py-type.c: Fix common/ includes.
9280 * python/py-inferior.c: Fix common/ includes.
9281 * progspace.h: Fix common/ includes.
9282 * producer.c: Fix common/ includes.
9283 * procfs.c: Fix common/ includes.
9284 * proc-api.c: Fix common/ includes.
9285 * printcmd.c: Fix common/ includes.
9286 * ppc-linux-nat.c: Fix common/ includes.
9287 * parser-defs.h: Fix common/ includes.
9288 * osdata.c: Fix common/ includes.
9289 * obsd-nat.c: Fix common/ includes.
9290 * nat/x86-linux.c: Fix common/ includes.
9291 * nat/x86-linux-dregs.c: Fix common/ includes.
9292 * nat/x86-dregs.h: Fix common/ includes.
9293 * nat/x86-dregs.c: Fix common/ includes.
9294 * nat/ppc-linux.c: Fix common/ includes.
9295 * nat/mips-linux-watch.h: Fix common/ includes.
9296 * nat/mips-linux-watch.c: Fix common/ includes.
9297 * nat/linux-waitpid.c: Fix common/ includes.
9298 * nat/linux-ptrace.h: Fix common/ includes.
9299 * nat/linux-ptrace.c: Fix common/ includes.
9300 * nat/linux-procfs.c: Fix common/ includes.
9301 * nat/linux-personality.c: Fix common/ includes.
9302 * nat/linux-osdata.c: Fix common/ includes.
9303 * nat/linux-namespaces.c: Fix common/ includes.
9304 * nat/linux-btrace.h: Fix common/ includes.
9305 * nat/linux-btrace.c: Fix common/ includes.
9306 * nat/fork-inferior.c: Fix common/ includes.
9307 * nat/amd64-linux-siginfo.c: Fix common/ includes.
9308 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9309 * nat/aarch64-linux.c: Fix common/ includes.
9310 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9311 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9312 * namespace.h: Fix common/ includes.
9313 * mips-linux-tdep.c: Fix common/ includes.
9314 * minsyms.c: Fix common/ includes.
9315 * mi/mi-parse.h: Fix common/ includes.
9316 * mi/mi-main.c: Fix common/ includes.
9317 * mi/mi-cmd-env.c: Fix common/ includes.
9318 * memrange.h: Fix common/ includes.
9319 * memattr.c: Fix common/ includes.
9320 * maint.h: Fix common/ includes.
9321 * maint.c: Fix common/ includes.
9322 * main.c: Fix common/ includes.
9323 * machoread.c: Fix common/ includes.
9324 * location.c: Fix common/ includes.
9325 * linux-thread-db.c: Fix common/ includes.
9326 * linux-nat.c: Fix common/ includes.
9327 * linux-fork.c: Fix common/ includes.
9328 * inline-frame.c: Fix common/ includes.
9329 * infrun.c: Fix common/ includes.
9330 * inflow.c: Fix common/ includes.
9331 * inferior.h: Fix common/ includes.
9332 * inferior.c: Fix common/ includes.
9333 * infcmd.c: Fix common/ includes.
9334 * inf-ptrace.c: Fix common/ includes.
9335 * inf-child.c: Fix common/ includes.
9336 * ia64-linux-nat.c: Fix common/ includes.
9337 * i387-tdep.c: Fix common/ includes.
9338 * i386-tdep.c: Fix common/ includes.
9339 * i386-linux-tdep.c: Fix common/ includes.
9340 * i386-linux-nat.c: Fix common/ includes.
9341 * i386-go32-tdep.c: Fix common/ includes.
9342 * i386-fbsd-tdep.c: Fix common/ includes.
9343 * i386-fbsd-nat.c: Fix common/ includes.
9344 * guile/scm-type.c: Fix common/ includes.
9345 * guile/guile.c: Fix common/ includes.
9346 * go32-nat.c: Fix common/ includes.
9347 * gnu-nat.c: Fix common/ includes.
9348 * gdbthread.h: Fix common/ includes.
9349 * gdbarch-selftests.c: Fix common/ includes.
9350 * gdb_usleep.c: Fix common/ includes.
9351 * gdb_select.h: Fix common/ includes.
9352 * gdb_bfd.c: Fix common/ includes.
9353 * gcore.c: Fix common/ includes.
9354 * fork-child.c: Fix common/ includes.
9355 * findvar.c: Fix common/ includes.
9356 * fbsd-nat.c: Fix common/ includes.
9357 * event-top.c: Fix common/ includes.
9358 * event-loop.c: Fix common/ includes.
9359 * dwarf2read.c: Fix common/ includes.
9360 * dwarf2loc.c: Fix common/ includes.
9361 * dwarf2-frame.c: Fix common/ includes.
9362 * dwarf-index-cache.c: Fix common/ includes.
9363 * dtrace-probe.c: Fix common/ includes.
9364 * disasm-selftests.c: Fix common/ includes.
9365 * defs.h: Fix common/ includes.
9366 * csky-tdep.c: Fix common/ includes.
9367 * cp-valprint.c: Fix common/ includes.
9368 * cp-support.h: Fix common/ includes.
9369 * cp-support.c: Fix common/ includes.
9370 * corelow.c: Fix common/ includes.
9371 * completer.h: Fix common/ includes.
9372 * completer.c: Fix common/ includes.
9373 * compile/compile.c: Fix common/ includes.
9374 * compile/compile-loc2c.c: Fix common/ includes.
9375 * compile/compile-cplus-types.c: Fix common/ includes.
9376 * compile/compile-cplus-symbols.c: Fix common/ includes.
9377 * command.h: Fix common/ includes.
9378 * cli/cli-dump.c: Fix common/ includes.
9379 * cli/cli-cmds.c: Fix common/ includes.
9380 * charset.c: Fix common/ includes.
9381 * build-id.c: Fix common/ includes.
9382 * btrace.h: Fix common/ includes.
9383 * btrace.c: Fix common/ includes.
9384 * breakpoint.h: Fix common/ includes.
9385 * breakpoint.c: Fix common/ includes.
9386 * ax.h:
9387 (enum agent_op): Fix common/ includes.
9388 * ax-general.c (struct aop_map): Fix common/ includes.
9389 * ax-gdb.c: Fix common/ includes.
9390 * auxv.c: Fix common/ includes.
9391 * auto-load.c: Fix common/ includes.
9392 * arm-tdep.c: Fix common/ includes.
9393 * arch/riscv.c: Fix common/ includes.
9394 * arch/ppc-linux-common.c: Fix common/ includes.
9395 * arch/i386.c: Fix common/ includes.
9396 * arch/arm.c: Fix common/ includes.
9397 * arch/arm-linux.c: Fix common/ includes.
9398 * arch/arm-get-next-pcs.c: Fix common/ includes.
9399 * arch/amd64.c: Fix common/ includes.
9400 * arch/aarch64.c: Fix common/ includes.
9401 * arch/aarch64-insn.c: Fix common/ includes.
9402 * arch-utils.c: Fix common/ includes.
9403 * amd64-windows-tdep.c: Fix common/ includes.
9404 * amd64-tdep.c: Fix common/ includes.
9405 * amd64-sol2-tdep.c: Fix common/ includes.
9406 * amd64-obsd-tdep.c: Fix common/ includes.
9407 * amd64-nbsd-tdep.c: Fix common/ includes.
9408 * amd64-linux-tdep.c: Fix common/ includes.
9409 * amd64-linux-nat.c: Fix common/ includes.
9410 * amd64-fbsd-tdep.c: Fix common/ includes.
9411 * amd64-fbsd-nat.c: Fix common/ includes.
9412 * amd64-dicos-tdep.c: Fix common/ includes.
9413 * amd64-darwin-tdep.c: Fix common/ includes.
9414 * agent.c: Fix common/ includes.
9415 * ada-lang.h: Fix common/ includes.
9416 * ada-lang.c: Fix common/ includes.
9417 * aarch64-tdep.c: Fix common/ includes.
9418
2f5c153e
TT
94192019-01-25 Tom Tromey <tom@tromey.com>
9420
9421 * common/create-version.sh: Use common/version.h.
9422
adc6a863
PA
94232019-01-24 Pedro Alves <palves@redhat.com>
9424
9425 * infrun.c (signal_stop, signal_print, signal_program)
9426 (signal_catch, signal_pass): Now arrays instead of pointers.
9427 (update_signals_program_target, do_target_resume)
9428 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9429 * linux-nat.c (linux_nat_target::pass_signals)
9430 (linux_nat_target::create_inferior, linux_nat_target::attach):
9431 Adjust.
9432 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9433 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9434 * procfs.c (procfs_target::pass_signals): Adjust.
9435 * record-full.c (record_full_target::resume): Adjust.
9436 * remote.c (remote_target::pass_signals)
9437 (remote_target::program_signals): Adjust.
9438 * target-debug.h (target_debug_print_signals): Now takes a
9439 gdb::array_view as parameter. Adjust.
9440 * target.h (target_ops) <pass_signals, program_signals>: Replace
9441 pointer and length parameters with gdb::array_view.
9442 (target_pass_signals, target_program_signals): Likewise.
9443 * target-delegates.c: Regenerate.
9444
3046d67a
PA
94452019-01-24 Pedro Alves <palves@redhat.com>
9446
9447 * common/forward-scope-exit.h
9448 (forward_scope_exit::forward_scope_exit): Pass arguments to
9449 m_bind_function directly, instead of creating a std::bind and
9450 copying that.
9451
353229bf
AH
94522019-01-24 Alan Hayward <alan.hayward@arm.com>
9453
9454 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9455 for static members.
9456 (pass_in_v_vfp_candidate): Likewise.
9457
311dc83a
TT
94582019-01-23 Tom Tromey <tom@tromey.com>
9459 Pedro Alves <palves@redhat.com>
9460
9461 * regcache.c (class regcache_invalidator): Remove.
9462 (regcache::raw_write): Use make_scope_exit.
9463
296bd123
TT
94642019-01-23 Tom Tromey <tom@tromey.com>
9465
9466 * ui-out.h (class ui_out_emit_type): Update comment.
9467
979a0d13
TT
94682019-01-23 Tom Tromey <tom@tromey.com>
9469
9470 * infrun.c (fetch_inferior_event): Update comment.
9471
d238133d
TT
94722019-01-23 Tom Tromey <tom@tromey.com>
9473 Pedro Alves <palves@redhat.com>
9474
9475 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9476 parameter.
9477 (fetch_inferior_event): Use SCOPE_EXIT.
9478
9479
9885e6bb
TT
94802019-01-23 Tom Tromey <tom@tromey.com>
9481 Pedro Alves <palves@redhat.com>
9482
9483 * infrun.c (disable_thread_events): Delete.
9484 (stop_all_threads): Use SCOPE_EXIT.
9485
286526c1
TT
94862019-01-23 Tom Tromey <tom@tromey.com>
9487 Pedro Alves <palves@redhat.com>
9488
9489 * symfile.c: Include forward-scope-exit.h.
9490 (clear_symtab_users_cleanup): Replace forward declaration with
9491 a FORWARD_SCOPE_EXIT.
9492 (syms_from_objfile_1): Use the forward_scope_exit and
9493 gdb::optional instead of cleanup_function.
9494 (reread_symbols): Use the forward_scope_exit instead of
9495 cleanup_function.
9496 (clear_symtab_users_cleanup): Remove function.
9497
1db93f14
TT
94982019-01-23 Tom Tromey <tom@tromey.com>
9499 Pedro Alves <palves@redhat.com>
9500
9501 * linux-nat.c: Include scope-exit.h.
9502 (cleanup_target_stop): Remove.
9503 (linux_nat_target::static_tracepoint_markers_by_strid): Use
9504 SCOPE_EXIT.
9505
2cc83d1e
TT
95062019-01-23 Tom Tromey <tom@tromey.com>
9507 Pedro Alves <palves@redhat.com>
9508
9509 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9510 (call_function_by_hand_dummy): Use SCOPE_EXIT.
9511
694c6bf5
TT
95122019-01-23 Tom Tromey <tom@tromey.com>
9513 Andrew Burgess <andrew.burgess@embecosm.com>
9514 Pedro Alves <palves@redhat.com>
9515
9516 * infrun.c (fetch_inferior_event): Use scope_exit.
9517 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9518 * top.c (execute_command): Use scope_exit.
9519 * breakpoint.c (bpstat_do_actions): Use scope_exit.
9520 * utils.c (do_bpstat_clear_actions_cleanup)
9521 (make_bpstat_clear_actions_cleanup): Remove.
9522
4c41382a
TT
95232019-01-23 Tom Tromey <tom@tromey.com>
9524 Pedro Alves <palves@redhat.com>
9525
9526 * infrun.c: Include "common/scope-exit.h"
9527 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9528 (wait_for_inferior): Use SCOPE_EXIT.
9529 (fetch_inferior_event): Use scope_exit.
9530
89f8fb50
TT
95312019-01-23 Tom Tromey <tom@tromey.com>
9532 Pedro Alves <palves@redhat.com>
9533
9534 * breakpoint.c (create_breakpoint): Remove cleanup.
9535
5419bdae
TT
95362019-01-23 Tom Tromey <tom@tromey.com>
9537 Andrew Burgess <andrew.burgess@embecosm.com>
9538 Pedro Alves <palves@redhat.com>
9539
e587ef42
PA
95402019-01-23 Pedro Alves <palves@redhat.com>
9541
9542 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9543
77f0e74c
PA
95442019-01-23 Pedro Alves <palves@redhat.com>
9545 Andrew Burgess <andrew.burgess@embecosm.com>
9546
9547 * gdbthread.h: Include "common/forward-scope-exit.h".
9548 (scoped_finish_thread_state): Redefine custom class in terms of
9549 forward_scope_exit.
9550
5b9b3e53
PA
95512019-01-23 Pedro Alves <palves@redhat.com>
9552 Andrew Burgess <andrew.burgess@embecosm.com>
9553
9554 * common/forward-scope-exit.h: New file.
9555
54b65c9b
PA
95562019-01-23 Pedro Alves <palves@redhat.com>
9557 Andrew Burgess <andrew.burgess@embecosm.com>
9558 Tom Tromey <tom@tromey.com>
9559
9560 * common/scope-exit.h: New file.
9561
cf08fb29
PA
95622019-01-23 Pedro Alves <palves@redhat.com>
9563
9564 * common/preprocessor.h (ESC): Rename to ...
9565 (ESC_PARENS): ... this.
9566 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9567 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9568
ae73e2e2
TT
95692019-01-23 Tom Tromey <tom@tromey.com>
9570
9571 * language.h (class scoped_switch_to_sym_language_if_auto):
9572 Initialize m_lang in both cases.
9573
6594e122
AH
95742019-01-23 Alan Hayward <alan.hayward@arm.com>
9575
9576 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9577 with XCNEW.
9578
a7c9855d
TT
95792019-01-22 Tom Tromey <tom@tromey.com>
9580
9581 * corelow.c: Do not include sys/file.h.
9582
93cc1d53
TT
95832019-01-22 Tom Tromey <tom@tromey.com>
9584
9585 * tui/tui-wingeneral.h: Include gdb_curses.h.
9586
38561778
TT
95872019-01-22 Tom Tromey <tom@tromey.com>
9588
9589 * source-cache.h (class source_cache) <get_source_lines,
9590 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9591
37b3ab5b
TT
95922019-01-22 Tom Tromey <tom@tromey.com>
9593
9594 * remote-fileio.h (struct remote_target): Declare.
9595
3fabc016
TT
95962019-01-22 Tom Tromey <tom@tromey.com>
9597
9598 * python/py-arch.c: Do not include py-ref.h.
9599 * python/py-bpevent.c: Do not include py-ref.h.
9600 * python/py-cmd.c: Do not include py-ref.h.
9601 * python/py-continueevent.c: Do not include py-ref.h.
9602 * python/py-event.h: Do not include py-ref.h.
9603 * python/py-evtregistry.c: Do not include py-ref.h.
9604 * python/py-finishbreakpoint.c: Do not include py-ref.h.
9605 * python/py-frame.c: Do not include py-ref.h.
9606 * python/py-framefilter.c: Do not include py-ref.h.
9607 * python/py-function.c: Do not include py-ref.h.
9608 * python/py-infevents.c: Do not include py-ref.h.
9609 * python/py-linetable.c: Do not include py-ref.h.
9610 * python/py-objfile.c: Do not include py-ref.h.
9611 * python/py-param.c: Do not include py-ref.h.
9612 * python/py-prettyprint.c: Do not include py-ref.h.
9613 * python/py-progspace.c: Do not include py-ref.h.
9614 * python/py-symbol.c: Do not include py-ref.h.
9615 * python/py-symtab.c: Do not include py-ref.h.
9616 * python/py-type.c: Do not include py-ref.h.
9617 * python/py-unwind.c: Do not include py-ref.h.
9618 * python/py-utils.c: Do not include py-ref.h.
9619 * python/py-value.c: Do not include py-ref.h.
9620 * python/py-varobj.c: Do not include py-ref.h.
9621 * python/py-xmethods.c: Do not include py-ref.h.
9622 * python/python.c: Do not include py-ref.h.
9623 * varobj.c: Do not include py-ref.h.
9624
6b4d7774
TT
96252019-01-22 Tom Tromey <tom@tromey.com>
9626
9627 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9628 keyword for bcache.
9629
7af7e9b5
TT
96302019-01-22 Tom Tromey <tom@tromey.com>
9631
9632 * compile/compile-cplus-types.c: Remove a comment by #include.
9633
951d1049
TT
96342019-01-22 Tom Tromey <tom@tromey.com>
9635
9636 * compile/gcc-c-plugin.h: Include compile-internal.h.
9637
d65d5705
TT
96382019-01-22 Tom Tromey <tom@tromey.com>
9639
9640 * stabsread.c (EXTERN): Do not define.
9641 (symnum, next_symbol_text_func, processing_gcc_compilation)
9642 (within_function, global_sym_chain, global_stabs)
9643 (previous_stab_code, this_object_header_files)
9644 (n_this_object_header_files)
9645 (n_allocated_this_object_header_files): Define.
9646 * stabsread.h (EXTERN): Never define. Use "extern".
9647
b6fb1ee5
PW
96482019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9649
9650 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9651 history_value.
9652
be6d4f74
TT
96532019-01-21 Tom Tromey <tom@tromey.com>
9654
9655 * ui-out.c: Fix includes.
9656 * tui/tui-source.c: Fix includes.
9657 * target.c: Fix includes.
9658 * remote.c: Fix includes.
9659 * regcache.c: Fix includes.
9660 * python/py-block.c: Fix includes.
9661 * printcmd.c: Fix includes.
9662 * or1k-tdep.c: Fix includes.
9663 * mi/mi-main.c: Fix includes.
9664 * m32r-tdep.c: Fix includes.
9665 * csky-tdep.c: Fix includes.
9666 * compile/compile-cplus-types.c: Fix includes.
9667 * cli/cli-interp.c: Fix includes.
9668
73021deb
AH
96692019-01-21 Alan Hayward <alan.hayward@arm.com>
9670
9671 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9672 for padding.
9673
7932255d
TT
96742019-01-16 Tom Tromey <tom@tromey.com>
9675
9676 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
9677 earlier.
9678 (struct objfile) <msymbols_range>: Move from top level.
9679 <msymbols>: New method.
9680 (class objfile_msymbols): Remove.
9681 * symtab.c (default_collect_symbol_completion_matches_break_on):
9682 Update.
9683 * symmisc.c (dump_msymbols): Update.
9684 * stabsread.c (scan_file_globals): Update.
9685 * objc-lang.c (info_selectors_command, info_classes_command)
9686 (find_methods): Update.
9687 * minsyms.c (find_solib_trampoline_target): Update.
9688 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9689 * coffread.c (coff_symfile_read): Update.
9690 * ada-lang.c (ada_lookup_simple_minsym)
9691 (ada_collect_symbol_completion_matches): Update.
9692
604b1bfb
TT
96932019-01-16 Tom Tromey <tom@tromey.com>
9694
9695 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9696 type. Remove no-argument constructor.
9697 <iterator::operator++>: Simplify.
9698 <begin>: Update.
9699 <end>: Use minimal_symbol_count.
9700
f252c6d5
TT
97012019-01-16 Tom Tromey <tom@tromey.com>
9702
9703 * objfiles.h (struct objfile) <psymtabs>: New method.
9704 (class objfile_psymtabs): Remove.
9705 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9706 typedef.
9707 <range>: New method.
9708 (require_partial_symbols): Change return type.
9709 * psymtab.c (require_partial_symbols)
9710 (psym_expand_symtabs_matching): Update.
9711 * mdebugread.c (parse_partial_symbols): Update.
9712 * dbxread.c (dbx_end_psymtab): Update.
9713
b669c953
TT
97142019-01-15 Tom Tromey <tom@tromey.com>
9715
9716 * symtab.c (lookup_objfile_from_block)
9717 (lookup_symbol_in_objfile_symtabs)
9718 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9719 (find_line_symtab, info_sources_command)
9720 (default_collect_symbol_completion_matches_break_on)
9721 (make_source_files_completion_list): Update.
9722 * symmisc.c (print_objfile_statistics, dump_objfile)
9723 (maintenance_print_symbols, maintenance_info_symtabs)
9724 (maintenance_check_symtabs, maintenance_info_line_tables):
9725 Update.
9726 * source.c (select_source_symtab)
9727 (forget_cached_source_info_for_objfile): Update.
9728 * objfiles.h (class objfile_compunits): Remove.
9729 (struct objfile) <compunits_range>: New typedef.
9730 (compunits): New method.
9731 * objfiles.c (objfile_relocate1): Update.
9732 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9733 * maint.c (count_symtabs_and_blocks): Update.
9734 * linespec.c (iterate_over_all_matching_symtabs): Update.
9735 * cp-support.c (add_symbol_overload_list_qualified): Update.
9736 * coffread.c (coff_symtab_read): Update.
9737 * ada-lang.c (add_nonlocal_symbols)
9738 (ada_collect_symbol_completion_matches)
9739 (ada_add_global_exceptions): Update.
9740
7e955d83
TT
97412019-01-15 Tom Tromey <tom@tromey.com>
9742
9743 * progspace.h (program_space) <objfiles_safe_range>: New
9744 typedef.
9745 <objfiles_safe>: New method.
9746 * objfiles.h (class all_objfiles_safe): Remove.
9747 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9748 * jit.c (jit_inferior_exit_hook): Update.
9749
2030c079
TT
97502019-01-17 Tom Tromey <tom@tromey.com>
9751
9752 * progspace.h (program_space) <objfiles_range>: New typedef.
9753 <objfiles>: New method.
9754 <objfiles_head>: Rename from objfiles.
9755 (object_files): Update.
9756 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9757 * guile/scm-pretty-print.c
9758 (ppscm_find_pretty_printer_from_objfiles): Update.
9759 * guile/scm-objfile.c (gdbscm_objfiles): Update.
9760 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9761 Update.
9762 * python/py-progspace.c (pspy_get_objfiles): Update.
9763 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9764 Update.
9765 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9766 (objfpy_lookup_objfile_by_build_id): Update.
9767 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9768 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9769 Update.
9770 * symtab.c (iterate_over_symtabs, matching_obj_sections)
9771 (expand_symtab_containing_pc, lookup_objfile_from_block)
9772 (lookup_static_symbol, basic_lookup_transparent_type)
9773 (find_pc_sect_compunit_symtab, find_symbol_at_address)
9774 (find_line_symtab, info_sources_command)
9775 (default_collect_symbol_completion_matches_break_on)
9776 (make_source_files_completion_list, find_main_name): Update.
9777 * symmisc.c (print_symbol_bcache_statistics)
9778 (print_objfile_statistics, maintenance_print_symbols)
9779 (maintenance_print_msymbols, maintenance_print_objfiles)
9780 (maintenance_info_symtabs, maintenance_check_symtabs)
9781 (maintenance_expand_symtabs, maintenance_info_line_tables):
9782 Update.
9783 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9784 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9785 (map_overlay_command, unmap_overlay_command)
9786 (simple_overlay_update, expand_symtabs_matching)
9787 (map_symbol_filenames): Update.
9788 * symfile-debug.c (set_debug_symfile): Update.
9789 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9790 Update.
9791 * source.c (select_source_symtab, forget_cached_source_info):
9792 Update.
9793 * solib.c (solib_read_symbols): Update.
9794 * solib-spu.c (append_ocl_sos): Update.
9795 * psymtab.c (maintenance_print_psymbols)
9796 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9797 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9798 * printcmd.c (info_symbol_command): Update.
9799 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9800 Update.
9801 * objfiles.h (class all_objfiles): Remove.
9802 * objfiles.c (have_partial_symbols, have_full_symbols)
9803 (have_minimal_symbols, qsort_cmp, update_section_map)
9804 (shared_objfile_contains_address_p)
9805 (default_iterate_over_objfiles_in_search_order): Update.
9806 * objc-lang.c (info_selectors_command, info_classes_command)
9807 (find_methods): Update.
9808 * minsyms.c (find_solib_trampoline_target): Update.
9809 * maint.c (maintenance_info_sections)
9810 (maintenance_translate_address, count_symtabs_and_blocks):
9811 Update.
9812 * main.c (captured_main_1): Update.
9813 * linux-thread-db.c (try_thread_db_load_from_pdir)
9814 (has_libpthread): Update.
9815 * linespec.c (iterate_over_all_matching_symtabs)
9816 (search_minsyms_for_name): Update.
9817 * jit.c (jit_find_objf_with_entry_addr): Update.
9818 * hppa-tdep.c (find_unwind_entry)
9819 (hppa_lookup_stub_minimal_symbol): Update.
9820 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9821 Update.
9822 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9823 (elf_gnu_ifunc_resolve_by_got): Update.
9824 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9825 * dwarf-index-write.c (save_gdb_index_command): Update.
9826 * cp-support.c (add_symbol_overload_list_qualified): Update.
9827 * breakpoint.c (create_overlay_event_breakpoint)
9828 (create_longjmp_master_breakpoint)
9829 (create_std_terminate_master_breakpoint)
9830 (create_exception_master_breakpoint): Update.
9831 * blockframe.c (find_pc_partial_function): Update.
9832 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9833 (ada_collect_symbol_completion_matches)
9834 (ada_add_global_exceptions): Update.
9835
776489e0
TT
98362019-01-17 Tom Tromey <tom@tromey.com>
9837
9838 * solib-target.c (lm_info_target_p): Remove typedef. Don't
9839 declare VEC.
9840 (solib_target_parse_libraries): Change return type.
9841 (library_list_start_segment, library_list_start_section)
9842 (library_list_end_library, library_list_start_library); Update.
9843 (solib_target_free_library_list): Remove.
9844 (solib_target_parse_libraries): Remove cleanup. Change return
9845 type.
9846 (solib_target_current_sos): Update.
9847
6471e7d2
TT
98482019-01-17 Tom Tromey <tromey@bapiya>
9849
9850 * valprint.c: Replace "the the" with "the".
9851 * symtab.c: Replace "the the" with "the".
9852 * solib.c: Replace "the the" with "the".
9853 * solib-dsbt.c: Replace "the the" with "the".
9854 * linespec.c: Replace "the the" with "the".
9855 * dwarf2loc.h: Replace "the the" with "the".
9856 * amd64-windows-tdep.c: Replace "the the" with "the".
9857 * aarch64-tdep.c: Replace "the the" with "the".
9858
c24bdb02
KS
98592019-01-16 Keith Seitz <keiths@redhat.com>
9860
9861 PR gdb/23773
9862 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9863 <builder>: Rename to ..
9864 <m_builder>: ... this and make private.
9865 (dwarf2_cu::get_builder): New method. Change all users of
9866 `builder' to use this method.
9867 (dwarf2_start_symtab): Move to ...
9868 (dwarf2_cu::start_symtab): ... here. Update all callers
9869 (setup_type_unit_groups): Move to ...
9870 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
9871 callers.
9872 (dwarf2_cu::reset_builder): New method.
9873 (process_full_compunit, process_full_type_unit): Use
9874 dwarf2_cu::reset_builder.
9875 (follow_die_offset): Record the ancestor CU if it is different
9876 from the followed DIE's CU.
9877 (follow_die_sig_1): Likewise.
9878
8d64371b
TT
98792019-01-15 Tom Tromey <tom@tromey.com>
9880
9881 * remote.c (class remote_state) <buf>: Now a char_vector.
9882 <buf_size>: Remove.
9883 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
9884 parameter.
9885 (remote_target::getpkt_or_notif_sane_1)
9886 (remote_target::getpkt_sane)
9887 (remote_target::getpkt_or_notif_sane): Likewise.
9888 (class remote_target) <putpkt>: New overload.
9889 (remote_target::read_frame): Change type of "buf_p". Remove
9890 sizeof_p parameter.
9891 (packet_ok): New overload.
9892 (packet_check_result): New overload.
9893 Update all uses.
9894
bb277751
TT
98952019-01-14 Tom Tromey <tom@tromey.com>
9896
9897 * remote-notif.c (handle_notification, remote_notif_ack)
9898 (remote_notif_parse): Make "buf" const.
9899 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9900 const.
9901 (remote_notif_parse, remote_notif_ack, handle_notification):
9902 Likewise.
9903 * remote.c (remote_notif_stop_parse): Make "buf" const.
9904 (remote_target::remote_parse_stop_reply): Make "buf" const.
9905 (remote_notif_stop_ack): Make "buf" const.
9906
05be00a8
TT
99072019-01-14 Tom Tromey <tom@tromey.com>
9908
9909 * remote.c (remote_console_output): Make parameter const.
9910
491adeca
TT
99112019-01-14 Tom Tromey <tom@tromey.com>
9912
9913 * target-debug.h (target_debug_print_signals): Constify.
9914 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9915 * procfs.c (procfs_target::pass_signals): Update.
9916 * linux-nat.c (linux_nat_target::pass_signals): Update.
9917 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9918 * target-delegates.c: Rebuild.
9919 * remote.c (remote_target::program_signals): Update.
9920 (remote_target::pass_signals): Update.
9921 * target.c (target_pass_signals): Constify argument.
9922 (target_program_signals): Likewise.
9923 * target.h (struct target_ops) <pass_signals, program_signals>:
9924 Constify argument.
9925 (target_pass_signals, target_program_signals): Constify argument.
9926
bbd94648
TT
99272019-01-14 Tom Tromey <tom@tromey.com>
9928
9929 PR tui/28819:
9930 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9931
6f072a10
PFC
99322019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
9933
9934 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9935 field.
9936 * rs6000-tdep.c: Include reggroups.h.
9937 (IS_V_ALIAS_PSEUDOREG): Define.
9938 (rs6000_register_name): Return names for the "vX" aliases.
9939 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9940 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
9941 aliases. Call default_register_reggroup_p for all other
9942 pseudo-registers.
9943 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9944 New functions.
9945 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9946 Handle "vX" aliases.
9947 (v_alias_pseudo_register_collect): New function.
9948 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9949 (rs6000_gdbarch_init): Initialize "vX" aliases as
9950 pseudo-registers. Restore registration of
9951 rs6000_pseudo_register_reggroup_p with
9952 set_tdesc_pseudo_register_reggroup_p.
9953
1a782351
MF
99542019-01-13 Max Filippov <jcmvbkbc@gmail.com>
9955
9956 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9957 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9958 set_gdbarch_num_pseudo_regs.
9959
d73cff18
PW
99602019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9961
9962 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9963 Remove arg prefixname, add do_set and do_show.
9964 Add member functions set_list and show_list.
9965 * cli/cli-style.c (class cli_style_option): Update accordingly.
9966 (style_set_list): Move to file scope.
9967 (style_show_list): Likewise.
9968 (set_style): Call help_list.
9969 (show_style): Call cmd_show_list.
9970 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9971 Update to use the new macro.
9972
60a90376
JB
99732019-10-12 Joel Brobecker <brobecker@adacore.com>
9974
9975 * ada-lang.c (_initialize_ada_language): Expand the help text
9976 for the "catch exception" command.
9977
9d7c67bf
PW
99782019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9979
9980 * symtab.c (matching_obj_sections): Initialize obj,
9981 declare it closer to its usage.
9982
7cf47dc4
TT
99832019-01-10 Tom Tromey <tom@tromey.com>
9984
9985 * thread-iter.h (inf_threads_iterator): Use next_iterator.
9986 (basic_inf_threads_range): Remove.
9987 (inf_threads_range, inf_non_exited_threads_range)
9988 (safe_inf_threads_range): Use next_adapter.
9989
d3cb6808
KS
99902019-01-10 Keith Seitz <keiths@redhat.com>
9991
9992 PR gdb/23712
9993 PR symtab/23010
9994 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9995 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9996
63a20375
KS
99972019-01-10 Keith Seitz <keiths@redhat.com>
9998
9999 PR gdb/23712
10000 PR symtab/23010
10001 * dictionary.c (pending_to_vector): Remove.
10002 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10003 Remove _1 suffix, replacing functions of the same name. Update
10004 all callers.
10005 (dict_create_hashed, dict_create_hashed_expandable)
10006 (dict_create_linear, dict_create_linear_expandable, dict_free)
10007 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10008 Make functions static.
10009
b026f593
KS
100102019-01-10 Keith Seitz <keiths@redhat.com>
10011
10012 PR gdb/23712
10013 PR symtab/23010
10014 * dictionary.h (struct dictionary): Replace declaration with
10015 multidictionary.
10016 (dict_create_hashed, dict_create_hashed_expandable)
10017 (dict_create_linear, dict_create_linear_expandable)
10018 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10019 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10020 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10021 taking multidictionary argument.
10022 [ALL_DICT_SYMBOLS]: Update for multidictionary.
10023 * block.h (struct block) <dict>: Change to multidictionary
10024 and rename `multidict'.
10025 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10026 symmisc.c: Update all dictionary references to multidictionary.
10027
c7748ee9
KS
100282019-01-10 Keith Seitz <keiths@redhat.com>
10029
10030 PR gdb/23712
10031 PR symtab/23010
10032 * dictionary.c: Include unordered_map.
10033 (pending_to_vector): New function.
10034 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10035 Rewrite the non-"_1" functions to take vector instead
10036 of linked list.
10037 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10038 "new" _1 versions of the same name.
10039 (multidictionary): Define.
10040 (std::hash<enum language): New definition.
10041 (collate_pending_symbols_by_language, mdict_create_hashed)
10042 (mdict_create_hashed_expandable, mdict_create_linear)
10043 (mdict_create_linear_expandable, mdict_free)
10044 (find_language_dictionary, create_new_language_dictionary)
10045 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10046 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10047 (mdict_size, mdict_empty): New functions.
10048 * dictionary.h (mdict_iterator): Define.
10049
67aa1f3c
PA
100502019-01-10 Pedro Alves <palves@redhat.com>
10051
10052 * breakpoint.c (read_uploaded_action)
10053 (create_tracepoint_from_upload): Adjust to use
10054 gdb::unique_xmalloc_ptr.
10055 * ctf.c (ctf_write_uploaded_tp):
10056 (SET_ARRAY_FIELD): Use emplace_back.
10057 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10058 * tracefile-tfile.c (tfile_write_uploaded_tp):
10059 * tracepoint.c (parse_tracepoint_definition): Adjust to use
10060 gdb::unique_xmalloc_ptr.
10061 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10062 at_string, cond_string, cmd_strings>: Replace char pointers
10063 with gdb::unique_xmalloc_ptr.
10064
2f667667
PA
100652019-01-10 Pedro Alves <palves@redhat.com>
10066
10067 * solib-target.c (library_list_start_library): Don't xstrdup name.
10068
36cb7237
PA
100692019-01-10 Pedro Alves <palves@redhat.com>
10070
10071 * mdebugread.c (parse_partial_symbols): Use
10072 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10073
da584958
AB
100742019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
10075
10076 * linux-fork.c (scoped_switch_fork_info)
10077 <~scoped_switch_fork_info>: Fix incorrect variable name.
10078
1ef8573c
AB
100792019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
10080
10081 * linux-fork.c (scoped_switch_fork_info)
10082 <scoped_switch_fork_info>: Make explicit.
10083 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10084
8d7bcccb
TT
100852019-01-10 Tom Tromey <tom@tromey.com>
10086
10087 * objfiles.h (objfile::reset_psymtabs): Update.
10088 * objfiles.c (objfile::objfile): Update.
10089 * psymtab.h (psymtab_storage::obstack): Update.
10090 (psymtab_storage::m_obstack): Use gdb::optional.
10091 (class psymtab_storage): Update comment. Remove objfile
10092 parameter.
10093 * psymtab.c (psymtab_storage::psymtab_storage): Update.
10094
b596a3c7
TT
100952019-01-10 Tom Tromey <tom@tromey.com>
10096
10097 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10098 <free_psymtabs>: Now private.
10099 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10100 (allocate_psymtab): Use new method.
10101
a9342b62
TT
101022019-01-10 Tom Tromey <tom@tromey.com>
10103
10104 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10105 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10106 * mdebugread.c (parse_partial_symbols): Use
10107 allocate_dependencies.
10108 * dwarf2read.c (dwarf2_create_include_psymtab): Use
10109 allocate_dependencies.
10110 (process_psymtab_comp_unit_reader)
10111 (build_type_psymtab_dependencies): Likewise.
10112 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10113
5af70966
TT
101142019-01-10 Tom Tromey <tom@tromey.com>
10115
10116 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10117 PSYMBOL_SET_LANGUAGE.
10118 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10119
5923a04c
TT
101202019-01-10 Tom Tromey <tom@tromey.com>
10121
10122 * psymtab.h (psymtab_storage::obstack): New method.
10123 <m_obstack>: Rename from obstack; now private.
10124 * psymtab.c (psymtab_storage): Update.
10125 * dwarf2read.c (create_addrmap_from_index)
10126 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10127 Update.
10128
6d6a12bf
TT
101292019-01-10 Tom Tromey <tom@tromey.com>
10130
10131 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10132 * objfiles.h (objfile::reset_psymtabs): New method.
10133
d320c2b5
TT
101342019-01-10 Tom Tromey <tom@tromey.com>
10135
10136 * symmisc.c (print_symbol_bcache_statistics): Update.
10137 (print_objfile_statistics): Update.
10138 * symfile.c (reread_symbols): Update.
10139 * psymtab.h (class psymtab_storage): New.
10140 * psymtab.c (psymtab_storage): New constructor.
10141 (~psymtab_storage): New destructor.
10142 (require_partial_symbols): Update.
10143 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10144 (find_pc_sect_psymtab, find_pc_sect_psymbol)
10145 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10146 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10147 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10148 (start_psymtab_common, end_psymtab_common)
10149 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10150 (allocate_psymtab): Update.
10151 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10152 Update.
10153 (dump_psymtab_addrmap, maintenance_print_psymbols)
10154 (maintenance_check_psymtabs): Update.
10155 (class objfile_psymtabs): Move to objfiles.h.
10156 * psympriv.h (discard_psymtab): Now inline.
10157 (psymtab_discarder::psymtab_discarder): Update.
10158 (psymtab_discarder::~psymtab_discarder): Update.
10159 (ALL_OBJFILE_PSYMTABS): Rewrite.
10160 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10161 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10162 Remove fields.
10163 <partial_symtabs>: New field.
10164 (class objfile_psymtabs): Move from psymtab.h. Update.
10165 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10166 psymbol_cache.
10167 (objfile::~objfile): Don't destroy psymbol_cache.
10168 * mdebugread.c (parse_partial_symbols): Update.
10169 * dwarf2read.c (create_addrmap_from_index)
10170 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10171 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10172 (add_partial_subprogram, dwarf2_ranges_read): Update.
10173 * dwarf-index-write.c (write_address_map)
10174 (write_one_signatured_type, recursively_write_psymbols)
10175 (class debug_names, class debug_names, write_psymtabs_to_index):
10176 Update.
10177
1d94a5a3
TT
101782019-01-10 Tom Tromey <tom@tromey.com>
10179
10180 * symtab.h (SYMBOL_SET_NAMES): Update.
10181 (symbol_set_names): Update.
10182 (MSYMBOL_SET_NAMES): Update.
10183 * symtab.c (symbol_set_names): Change argument to be an
10184 objfile_per_bfd_storage.
10185 * psymtab.c (add_psymbol_to_bcache): Update.
10186 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10187
0f14768a
TT
101882019-01-10 Tom Tromey <tom@tromey.com>
10189
10190 * symtab.c (create_demangled_names_hash): Change argument to be an
10191 objfile_per_bfd_storage.
10192 (symbol_set_names): Update.
10193
6eee24ce
TT
101942019-01-10 Tom Tromey <tom@tromey.com>
10195
10196 * xcoffread.c (xcoff_initial_scan): Unconditionally call
10197 init_psymbol_list.
10198 * psymtab.c (init_psymbol_list): Do nothing if already called.
10199 * psympriv.h (init_psymbol_list): Add comment.
10200 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10201 init_psymbol_list.
10202 * dbxread.c (dbx_symfile_read): Unconditionally call
10203 init_psymbol_list.
10204
75aedd27
TT
102052019-01-10 Tom Tromey <tom@tromey.com>
10206
10207 * xcoffread.c (scan_xcoff_symtab): Update.
10208 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10209 "where".
10210 * mdebugread.c (parse_partial_symbols)
10211 (handle_psymbol_enumerators): Update.
10212 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10213 * dbxread.c (read_dbx_symtab): Update.
10214 * psympriv.h (psymbol_placement): New enum.
10215 (add_psymbol_to_list): Update.
10216
939652a5
TT
102172019-01-10 Tom Tromey <tom@tromey.com>
10218
10219 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10220 static_psymbols parameters.
10221 (scan_xcoff_symtab): Update.
10222 * psymtab.c (start_psymtab_common): Remove global_psymbols and
10223 static_psymbols parameters.
10224 * psympriv.h (start_psymtab_common): Update.
10225 * mdebugread.c (parse_partial_symbols): Update.
10226 * dwarf2read.c (create_partial_symtab): Update.
10227 * dbxread.c (read_dbx_symtab): Update.
10228 (start_psymtab): Remove global_psymbols and static_psymbols
10229 parameters.
10230
baa62830
TT
102312019-01-10 Tom Tromey <tom@tromey.com>
10232
10233 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10234 * psymtab.c (allocate_psymtab): Add comment.
10235 * psympriv.h (allocate_psymtab): Add comment.
10236 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10237 initializations.
10238 * dbxread.c (dbx_end_psymtab): Remove some initializations.
10239
0e8f53ba
TT
102402019-01-10 Tom Tromey <tom@tromey.com>
10241
10242 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10243 Don't declare.
10244 * mipsread.c: Include mdebugread.h.
10245 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10246 Declare.
10247 * elfread.c: Include mdebugread.h.
10248
b22a7c6a
TT
102492019-01-09 Tom Tromey <tom@tromey.com>
10250
10251 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10252 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10253 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10254 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10255 (psym_lookup_symbol, psym_find_last_source_symtab)
10256 (psym_forget_cached_source_info, psym_print_stats)
10257 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10258 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10259 (psym_map_matching_symbols, psym_expand_symtabs_matching)
10260 (psym_find_compunit_symtab_by_address)
10261 (maintenance_print_psymbols, maintenance_info_psymtabs)
10262 (maintenance_check_psymtabs): Use ranged for.
10263 * psymtab.h (class objfile_psymtabs): New.
10264 (require_partial_symbols): Return objfile_psymtabs.
10265 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10266
3b9d3ac2
TT
102672019-01-09 Tom Tromey <tom@tromey.com>
10268
10269 * symfile.c (overlay_invalidate_all, find_pc_overlay)
10270 (find_pc_mapped_section, list_overlays_command)
10271 (map_overlay_command, unmap_overlay_command)
10272 (simple_overlay_update): Use all_objfiles.
10273 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10274 * printcmd.c (info_symbol_command): Use all_objfiles.
10275 * objfiles.h (ALL_OBJSECTIONS): Remove.
10276 * maint.c (maintenance_translate_address): Use all_objfiles.
10277 * gcore.c (gcore_create_callback): Use all_objfiles.
10278 (objfile_find_memory_regions): Likewise.
10279
8b31193a
TT
102802019-01-09 Tom Tromey <tom@tromey.com>
10281
10282 * symtab.c (find_line_symtab, info_sources_command)
10283 (make_source_files_completion_list): Use objfile_compunits.
10284 * source.c (select_source_symtab): Use objfile_compunits.
10285 * objfiles.h (struct objfile): Update comment.
10286 (ALL_OBJFILES): Remove.
10287 (ALL_FILETABS): Remove.
10288 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10289 objfile_compunits.
10290
d5da8b3c
TT
102912019-01-09 Tom Tromey <tom@tromey.com>
10292
10293 * symmisc.c (print_objfile_statistics, dump_objfile)
10294 (maintenance_print_symbols): Use compunit_filetabs.
10295 * source.c (forget_cached_source_info_for_objfile): Use
10296 compunit_filetabs.
10297 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10298 (ALL_FILETABS): Use compunit_filetabs.
10299 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10300 * coffread.c (coff_symtab_read): Use compunit_filetabs.
10301
5accd1a0
TT
103022019-01-09 Tom Tromey <tom@tromey.com>
10303
10304 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10305 (compunit_filetabs): New.
10306 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10307 compunit_filetabs.
10308 (info_sources_command, make_source_files_completion_list): Remove
10309 declaration.
10310 * symmisc.c (print_objfile_statistics, dump_objfile)
10311 (maintenance_print_symbols): Remove declaration.
10312 (maintenance_info_symtabs): Use compunit_filetabs.
10313 (maintenance_info_line_tables): Likewise.
10314 * source.c (select_source_symtab): Change local variable name.
10315 (forget_cached_source_info_for_objfile): Remove declaration.
10316 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10317 * objfiles.c (objfile_relocate1): Remove declaration.
10318 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10319 declaration.
10320 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10321 * coffread.c (coff_symtab_read): Remove declaration.
10322 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10323 compunit_filetabs.
10324
d8aeb77f
TT
103252019-01-09 Tom Tromey <tom@tromey.com>
10326
10327 * symtab.c (lookup_objfile_from_block)
10328 (find_pc_sect_compunit_symtab, search_symbols)
10329 (default_collect_symbol_completion_matches_break_on): Use
10330 objfile_compunits.
10331 * objfiles.h (ALL_COMPUNITS): Remove.
10332 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10333 * cp-support.c (add_symbol_overload_list_qualified): Use
10334 objfile_compunits.
10335 * ada-lang.c (ada_collect_symbol_completion_matches)
10336 (ada_add_global_exceptions): Use objfile_compunits.
10337
592553c4
TT
103382019-01-09 Tom Tromey <tom@tromey.com>
10339
10340 * source.c (select_source_symtab)
10341 (forget_cached_source_info_for_objfile): Remove declaration.
10342 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10343 declaration.
10344 * maint.c (count_symtabs_and_blocks): Remove declaration.
10345 * cp-support.c (add_symbol_overload_list_qualified): Remove
10346 declaration.
10347 * coffread.c (coff_symtab_read): Remove declaration.
10348 * symtab.c (lookup_symbol_in_objfile_symtabs)
10349 (basic_lookup_transparent_type_1): Use objfile_compunits.
10350 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10351 (info_sources_command, search_symbols)
10352 (default_collect_symbol_completion_matches_break_on)
10353 (make_source_files_completion_list): Remove declaration.
10354 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10355 (ada_collect_symbol_completion_matches)
10356 (ada_add_global_exceptions): Remove declaration.
10357 * linespec.c (iterate_over_all_matching_symtabs): Use
10358 objfile_compunits.
10359 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10360 (class objfile_compunits): New.
10361 (ALL_COMPUNITS): Use objfile_compunits.
10362 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10363 (maintenance_check_symtabs, maintenance_info_line_tables): Use
10364 objfile_compunits.
10365 * objfiles.c (objfile_relocate1): Use objfile_compunits.
10366
5325b9bf
TT
103672019-01-09 Tom Tromey <tom@tromey.com>
10368
10369 * symtab.c (search_symbols)
10370 (default_collect_symbol_completion_matches_break_on): Use
10371 objfile_msymbols.
10372 * ada-lang.c (ada_lookup_simple_minsym)
10373 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10374 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10375 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10376 objfile_msymbols.
10377 * coffread.c (coff_symfile_read): Use objfile_msymbols.
10378 * symmisc.c (dump_msymbols): Use objfile_msymbols.
10379 * objc-lang.c (find_methods): Use objfile_msymbols.
10380 (info_selectors_command, info_classes_command): Likewise.
10381 * stabsread.c (scan_file_globals): Use objfile_msymbols.
10382 * objfiles.h (class objfile_msymbols): New.
10383 (ALL_OBJFILE_MSYMBOLS): Remove.
10384 (ALL_MSYMBOLS): Remove.
10385
cac85af2
TT
103862019-01-09 Tom Tromey <tom@tromey.com>
10387
10388 * common/next-iterator.h (next_adapter): Add Iterator template
10389 parameter.
10390 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10391 (class all_objfiles_safe): New.
10392 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10393 * objfiles.c (put_objfile_before): Update comment.
10394 (add_separate_debug_objfile): Likewise.
10395 (free_all_objfiles): Use all_objfiles_safe.
10396 (objfile_purge_solibs): Likewise.
10397
aed57c53
TT
103982019-01-09 Tom Tromey <tom@tromey.com>
10399
10400 * symtab.c (iterate_over_symtabs, matching_obj_sections)
10401 (expand_symtab_containing_pc, lookup_static_symbol)
10402 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10403 (find_symbol_at_address, find_line_symtab, find_main_name): Use
10404 all_objfiles.
10405 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10406 * breakpoint.c (create_overlay_event_breakpoint)
10407 (create_longjmp_master_breakpoint)
10408 (create_std_terminate_master_breakpoint)
10409 (create_exception_master_breakpoint): Use all_objfiles.
10410 * linux-thread-db.c (try_thread_db_load_from_pdir)
10411 (has_libpthread): Use all_objfiles.
10412 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10413 * linespec.c (iterate_over_all_matching_symtabs)
10414 (search_minsyms_for_name): Use all_objfiles.
10415 * maint.c (maintenance_info_sections): Use all_objfiles.
10416 * main.c (captured_main_1): Use all_objfiles.
10417 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10418 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10419 * guile/scm-pretty-print.c
10420 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10421 * solib-spu.c (append_ocl_sos): Use all_objfiles.
10422 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10423 (maintenance_print_msymbols): Use all_objfiles.
10424 * source.c (select_source_symtab): Use all_objfiles.
10425 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10426 * symfile.c (remove_symbol_file_command)
10427 (expand_symtabs_matching, map_symbol_filenames): Use
10428 all_objfiles.
10429 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10430 all_objfiles.
10431 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10432 * objc-lang.c (find_methods): Use all_objfiles.
10433 * objfiles.c (have_partial_symbols, have_full_symbols)
10434 (have_minimal_symbols, qsort_cmp)
10435 (default_iterate_over_objfiles_in_search_order): Use
10436 all_objfiles.
10437 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10438 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10439 (maintenance_check_psymtabs): Use all_objfiles.
10440 (ALL_PSYMTABS): Remove.
10441 * compile/compile-object-run.c (do_module_cleanup): Use
10442 all_objfiles.
10443 * blockframe.c (find_pc_partial_function): Use all_objfiles.
10444 * cp-support.c (add_symbol_overload_list_qualified): Use
10445 all_objfiles.
10446 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10447 Use all_objfiles.
10448 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10449 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10450 all_objfiles.
10451 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10452 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10453 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10454 Uses all_objfiles.
10455 * solib.c (solib_read_symbols): Use all_objfiles
10456
99d89cde
TT
104572019-01-09 Tom Tromey <tom@tromey.com>
10458
10459 * probe.c (parse_probes_in_pspace): Use all_objfiles.
10460 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10461 all_objfiles.
10462 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10463 * symmisc.c (print_symbol_bcache_statistics)
10464 (print_objfile_statistics, maintenance_print_objfiles)
10465 (maintenance_info_symtabs, maintenance_check_symtabs)
10466 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10467 all_objfiles.
10468 * source.c (forget_cached_source_info): Use all_objfiles.
10469 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10470 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10471 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10472 * objfiles.c (update_section_map): Use all_objfiles.
10473 (shared_objfile_contains_address_p): Likewise.
10474 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10475 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10476
21708325
TT
104772019-01-09 Tom Tromey <tom@tromey.com>
10478
10479 * common/next-iterator.h: New file.
10480 * objfiles.h (class all_objfiles): New.
10481 (struct objfile_iterator): New.
10482
669e09f6
PW
104832019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10484
10485 * NEWS: Move the description of the changed "frame", "select-frame",
10486 and "info frame" commands to the Changed commands section.
10487
041be526
SM
104882019-01-09 Simon Marchi <simon.marchi@ericsson.com>
10489
10490 * gdbtypes.c (check_stub_method_group): Remove handling of old
10491 mangling schemes.
10492 * linespec.c (find_methods): Likewise.
10493 * stabsread.c (read_member_functions): Likewise.
10494 * valops.c (search_struct_method): Likewise.
10495 (value_struct_elt_for_reference): Likewise.
10496 * NEWS: Mention this change.
10497
0e2a2133
AB
104982019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
10499
10500 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10501 print_source_lines.
10502 * source.c (print_source_lines_base): Update line number check.
10503 (print_source_lines): New function.
10504 (source_lines_range::source_lines_range): New function.
10505 * source.h (class source_lines_range): New class.
10506 (print_source_lines): New declaration.
10507
1055a3b4
PW
105082019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10509
10510 * linespec.c (linespec_state_destructor): Free self->canonical_names.
10511
cfeadda5
TT
105122019-01-08 Tom Tromey <tom@tromey.com>
10513 Simon Marchi <simon.marchi@ericsson.com>
10514
10515 PR gdb/24060
10516 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10517 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10518 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10519 * f-exp.y (DOLLAR_VARIABLE): Likewise.
10520 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10521 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10522
583068ca
AB
105232019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
10524
10525 * source.c (select_source_symtab): Move header comment to
10526 declaration in source.h.
10527 (forget_cached_source_info_for_objfile): Likewise.
10528 (forget_cached_source_info): Likewise.
10529 (identify_source_line): Likewise.
10530 * source.h (identify_source_line): Move declaration from symtab.h
10531 and add comment from source.c
10532 (print_source_lines): Likewise.
10533 (forget_cached_source_info_for_objfile): Likewise.
10534 (forget_cached_source_info): Likewise.
10535 (select_source_symtab): Likewise.
10536 (enum print_source_lines_flag): Move definition from symtab.h.
10537 * symtab.h (identify_source_line): Move declaration to source.h.
10538 (print_source_lines): Likewise.
10539 (forget_cached_source_info_for_objfile): Likewise.
10540 (forget_cached_source_info): Likewise.
10541 (select_source_symtab): Likewise.
10542 (enum print_source_lines_flag): Move definition to source.h.
10543 * tui/tui-hooks.c: Add 'source.h' include.
10544
ec98a4ad
AB
105452019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
10546
10547 * source.c (print_source_lines_base): Handle requests to print
10548 reverse line number sequences, and guard against empty lines
10549 string.
10550
62ea19c1
AB
105512019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
10552
10553 * source.c (print_source_lines_base): Fix skip of '\r' if next
10554 character is '\n'.
10555
9d30e1fd
TT
105562019-01-06 Tom Tromey <tom@tromey.com>
10557
10558 * c-exp.y (struct c_parse_state) <macro_original_text,
10559 expansion_obstack>: New member.
10560 (macro_original_text, expansion_obstack): Remove globals.
10561 (scan_macro_expansion, scanning_macro_expansion)
10562 (finished_macro_expansion): Update.
10563 (scan_macro_cleanup): Remove.
10564 (yylex, c_parse): Update.
10565
c65bac38
TT
105662019-01-06 Tom Tromey <tom@tromey.com>
10567
10568 * c-exp.y (struct c_parse_state) <strings>: New member.
10569 (operator_stoken): Update.
10570
02e12e38
TT
105712019-01-06 Tom Tromey <tom@tromey.com>
10572
10573 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
10574 (union type_stack_elt) <typelist_val>: Now a pointer to
10575 std::vector.
10576 (type_stack_cleanup): Don't declare.
10577 (push_typelist): Update.
10578 * parse.c (pop_typelist): Return a std::vector.
10579 (push_typelist): Take a std::vector.
10580 (follow_types): Update. Do not free args.
10581 (type_stack_cleanup): Remove.
10582 * c-exp.y (struct c_parse_state): New.
10583 (cpstate): New global.
10584 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10585 (nonempty_typelist): Update.
10586 (func_mod): Create a new vector.
10587 (c_parse): Create a c_parse_state.
10588 (check_parameter_typelist): Do not delete params.
10589 (function_method): Update. Do not delete type_list.
10590
f097f5ad
TT
105912019-01-06 Tom Tromey <tom@tromey.com>
10592
10593 PR gdb/28155:
10594 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10595 check_typedef.
10596 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10597 (print_return_value): Likewise.
10598
d2adf9f1
TT
105992019-01-05 Tom Tromey <tom@tromey.com>
10600
10601 * contrib/cleanup_check.py: Remove.
10602 * contrib/gcc-with-excheck: Remove.
10603 * contrib/exsummary.py: Remove.
10604 * contrib/excheck.py: Remove.
10605
2eab46b1
JB
106062019-01-05 Joel Brobecker <brobecker@adacore.com>
10607
10608 * thread.c (delete_thread_1): Add gdb_assert that THR is not
10609 NULL. Initialize tpprev to NULL instead of assigning it
10610 to NULL on the next statement.
10611 * windows-nat.c (windows_delete_thread): Remove check for
10612 main_thread_id before printing thread exit notifications.
10613 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10614 Remove thread ID check against main_thread_id.
10615 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10616 windows_delete_thread.
10617 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10618
48c5e7e2
TT
106192019-01-04 Tom Tromey <tom@tromey.com>
10620
10621 * compile/compile.c (_initialize_compile): Use upper case for
10622 metasyntactic variables.
10623 * symmisc.c (_initialize_symmisc): Use upper case for
10624 metasyntactic variables.
10625 * psymtab.c (_initialize_psymtab): Use upper case for
10626 metasyntactic variables.
10627 * demangle.c (demangle_command): Use upper case for metasyntactic
10628 variables.
10629 (_initialize_demangler): Likewise.
10630 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10631 variables.
10632
986041cd
TT
106332019-01-03 Tom Tromey <tom@tromey.com>
10634
10635 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10636
7c711119
TT
106372019-01-03 Tom Tromey <tom@tromey.com>
10638
10639 * python/py-symtab.c (salpy_str): Update.
10640 (struct salpy_sal_object) <symtab>: Now a PyObject.
10641 (salpy_dealloc): Update.
10642 (del_objfile_sal): Use gdbpy_ref.
10643
1b20edf0
TT
106442019-01-03 Tom Tromey <tom@tromey.com>
10645
10646 * python/py-type.c (convert_field): Use new_reference. Return
10647 gdbpy_ref.
10648 (make_fielditem): Return gdbpy_ref.
10649 (typy_fields): Update.
10650 (typy_getitem): Update.
10651 (field_name): Return gdbpy_ref. Use new_reference.
10652 (typy_iterator_iternext): Update.
10653
ea41325b
TT
106542019-01-03 Tom Tromey <tom@tromey.com>
10655
10656 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10657
2a3c71d6
TT
106582019-01-03 Tom Tromey <tom@tromey.com>
10659
10660 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10661 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10662 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10663 (pspy_set_frame_filters, pspy_set_frame_unwinders)
10664 (pspy_set_type_printers): Likewise.
10665 * python/py-function.c (fnpy_init): Use gdbpy_ref.
10666 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10667 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10668 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10669 (objfpy_set_type_printers): Likewise.
10670
5c329e6a
TT
106712019-01-03 Tom Tromey <tom@tromey.com>
10672
10673 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10674 (gdbpy_print_stack): Use gdbpy_err_fetch.
10675 * python/python-internal.h (class gdbpy_err_fetch): New class.
10676 (class gdbpy_enter) <m_error_type, m_error_value,
10677 m_error_traceback>: Remove.
10678 <m_error>: New member.
10679 (gdbpy_exception_to_string): Don't declare.
10680 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10681 * python/py-value.c (convert_value_from_python): Use
10682 gdbpy_err_fetch.
10683 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10684 gdbpy_exception_to_string.
10685 (gdbpy_handle_exception): Use gdbpy_err_fetch.
10686 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10687 gdbpy_err_fetch.
10688
169bb27b
AB
106892019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10690
10691 * linux-nat.c (delete_lwp_cleanup): Delete.
10692 (struct lwp_deleter): New struct.
10693 (lwp_info_up): New typedef.
10694 (linux_nat_target::follow_fork): Delete cleanup, and make use of
10695 lwp_info_up.
10696
a07c8880
AB
106972019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10698
10699 * linux-fork.c (class scoped_switch_fork_info): New class.
10700 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10701
26089c49
AB
107022019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10703
10704 * valops.c (find_overload_match): Remove use of null_cleanup, and
10705 calls to do_cleanups.
10706
06d3e5b0
AB
107072019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10708
10709 * compile/compile-cplus-types.c
10710 (compile_cplus_instance::decl_name): Handle changes to
10711 cp_func_name.
10712 * cp-support.c (cp_func_name): Update header comment, update
10713 return type.
10714 * cp-support.h (cp_func_name): Update return type in declaration.
10715 * valops.c (find_overload_match): Move temp_func local to top
10716 level of function and change its type. Use temp_func to hold and
10717 delete temporary string obtained from cp_func_name.
10718
66644cd3
AB
107192019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10720
10721 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10722 gdb::char_vector, remove cleanup, and update uses of `msg`.
10723
592d8c0a
JW
107242019-01-03 Jim Wilson <jimw@sifive.com>
10725
10726 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10727
c55d06ec
TT
107282019-01-02 Tom Tromey <tom@tromey.com>
10729
10730 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10731 (tdesc_parse_xml): Remove cleanups.
10732 * target-descriptions.h (make_cleanup_free_target_description):
10733 Don't declare.
10734 (target_desc_deleter): New struct.
10735 (target_desc_up): New typedef.
10736 * target-descriptions.c (target_desc_deleter::operator()): Rename
10737 from free_target_description.
10738 (make_cleanup_free_target_description): Remove.
10739
3a6ae42d
TT
107402019-01-02 Tom Tromey <tom@tromey.com>
10741
10742 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
10743 constructor, destructor.
10744 (linespec_parser): Remove typedef.
10745 (~linespec_parser): Rename from linespec_parser_delete.
10746 (linespec_lex_to_end, linespec_complete_label)
10747 (linespec_complete): Update.
10748 (decode_line_full): Remove cleanups.
10749 (decode_line_1): Update.
10750
61fd3e73
TT
107512019-01-02 Tom Tromey <tom@tromey.com>
10752
10753 * python/python-internal.h (inferior_to_inferior_object): Change
10754 return type.
10755 * python/py-exitedevent.c (create_exited_event_object): Update.
10756 * python/py-inferior.c (inferior_to_inferior_object): Return
10757 gdbpy_ref.
10758 (python_new_inferior, python_inferior_deleted)
10759 (thread_to_thread_object, delete_thread_object)
10760 (build_inferior_list, gdbpy_selected_inferior): Update.
10761 * python/py-infthread.c (create_thread_object): Update. Also fail
10762 if inferior_to_inferior_object fails.
10763
d20172fc
SM
107642019-01-02 Simon Marchi <simon.marchi@ericsson.com>
10765
10766 * inferior.h (class inferior) <displaced_step_state>: New field.
10767 * infrun.h (struct displaced_step_state): Move here from
10768 infrun.c. Initialize fields, add constructor.
10769 <inf>: Remove field.
10770 <reset>: New method.
10771 * infrun.c (struct displaced_step_inferior_state): Move to
10772 infrun.h.
10773 (displaced_step_inferior_states): Remove.
10774 (get_displaced_stepping_state): Adust.
10775 (displaced_step_in_progress_any_inferior): Adjust.
10776 (displaced_step_in_progress_thread): Adjust.
10777 (displaced_step_in_progress): Adjust.
10778 (add_displaced_stepping_state): Remove.
10779 (get_displaced_step_closure_by_addr): Adjust.
10780 (remove_displaced_stepping_state): Remove.
10781 (infrun_inferior_exit): Call displaced_step_state.reset.
10782 (use_displaced_stepping): Don't check for NULL.
10783 (displaced_step_prepare_throw): Call
10784 get_displaced_stepping_state.
10785 (displaced_step_fixup): Don't check for NULL.
10786 (prepare_for_detach): Don't check for NULL.
10787
e3319240
PW
107882019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10789
10790 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10791 in case of call that did not complete.
10792
5d36dfb9
AU
107932019-01-02 Andrey Utkin <autkin@undo.io>
10794
10795 * symfile.c (find_separate_debug_file): Fix search of debug files for
10796 remote debuggee.
10797
8833fbf0
TT
107982019-01-02 Tom Tromey <tom@tromey.com>
10799
10800 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10801 indentation.
10802 * python/py-frame.c (frapy_older): Remove cast.
10803 (frapy_newer): Likewise.
10804 * python/py-breakpoint.c (local_setattro): Remove cast.
10805 * python/py-arch.c (archpy_name): Remove local variable.
10806 * python/py-type.c (gdbpy_lookup_type): Remove cast.
10807
4ada3dfd
JB
108082019-01-02 Joel Brobecker <brobecker@adacore.com>
10809
10810 * unittests/basic_string_view/element_access/char/empty.cc:
10811 Fix year range in copyright header.
10812
113b7b81
AB
108132019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
10814
10815 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10816 Delete.
10817 <operator==>: Update with for removed field.
10818 <hash>: Likewise.
10819 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10820 <isa_features>: ...this.
10821 <abi_features>: New field.
10822 (riscv_isa_flen): Update comment.
10823 (riscv_abi_xlen): New declaration.
10824 (riscv_abi_flen): New declaration.
10825 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10826 isa_features.
10827 (riscv_abi_xlen): New function.
10828 (riscv_isa_flen): Update to get answer from isa_features.
10829 (riscv_abi_flen): New function.
10830 (riscv_has_fp_abi): Update to get answer from abi_features.
10831 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10832 xlen and flen.
10833 (riscv_call_info) <xlen, flen>: Update comment.
10834 (riscv_call_arg_struct): Remove invalid assertions
10835 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10836 is removed.
10837 (riscv_gdbarch_init): Gather isa features and abi features
10838 separately, ensure both match on the gdbarch when reusing an old
10839 gdbarch. Relax an error check to allow 32-bit abi float to run on
10840 a target with 64-bit float hardware.
10841
b18ca514
PW
108422019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10843
10844 * source.c (search_command_helper): Stop reverse search
10845 when line 1 has been searched.
10846
ec70d8db
PW
108472019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10848
10849 * record-full.c (record_full_base_target::close): Rewrite
10850 record_full_core_buf_list free logic.
10851
5b38f9c1
PW
108522019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10853
10854 * break-catch-syscall.c (print_one_catch_syscall): xfree
10855 the last text.
10856
66d91b39
JB
108572019-01-01 Joel Brobecker <brobecker@adacore.com>
10858
10859 * top.c (print_gdb_version): Update Copyright year in version
10860 message.
10861
42a4f53d
JB
108622019-01-01 Joel Brobecker <brobecker@adacore.com>
10863
10864 Update copyright year range in all GDB files.
10865
7e955d83 108662019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 10867
5bbd631d 10868 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 10869
5bbd631d 10870For older changes see ChangeLog-2018.
c906108c
SS
10871\f
10872Local Variables:
10873mode: change-log
10874left-margin: 8
10875fill-column: 74
10876version-control: never
57da7796 10877coding: utf-8
c906108c 10878End:
5bbd631d 10879