]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blame - gdb/ChangeLog
Move DWARF index-related things to a separate file
[thirdparty/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
cd4fb1b2
SM
12018-03-27 Simon Marchi <simon.marchi@ericsson.com>
2
3 * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
4 dwarf-index-write.c
5 (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
6 * dwarf-index-common.c: New file.
7 * dwarf-index-common.h: New file.
8 * dwarf-index-write.c: New file.
9 * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
10 (struct dwarf2_section_info): Move from here.
11 (dwarf2_section_info_def): Likewise.
12 (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
13 (offset_type): Likewise.
14 (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
15 (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
16 (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
17 (byte_swap): Likewise.
18 (MAYBE_SWAP): Likewise.
19 (dwarf2_per_cu_ptr): Likewise.
20 (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
21 (struct tu_stats): Likewise.
22 (struct dwarf2_per_objfile): Likewise.
23 (struct dwarf2_per_cu_data): Likewise.
24 (struct signatured_type): Likewise.
25 (sig_type_ptr): Likewise.
26 (DEF_VEC_P (sig_type_ptr)): Likewise.
27 (INDEX4_SUFFIX): Likewise.
28 (INDEX5_SUFFIX): Likewise.
29 (DEBUG_STR_SUFFIX): Likewise.
30 (dwarf2_read_section): Make non-static.
31 (mapped_index_string_hash): Move from here.
32 (dwarf5_djb_hash): Likewise.
33 (file_write): Likewise.
34 (class data_buf): Likewise.
35 (struct symtab_index_entry): Likewise.
36 (struct mapped_symtab): Likewise.
37 (find_slot): Likewise.
38 (hash_expand): Likewise.
39 (add_index_entry): Likewise.
40 (uniquify_cu_indices): Likewise.
41 (class c_str_view): Likewise.
42 (class c_str_view_hasher): Likewise.
43 (class vector_hasher): Likewise.
44 (write_hash_table): Likewise.
45 (psym_index_map): Likewise.
46 (struct addrmap_index_data): Likewise.
47 (add_address_entry): Likewise.
48 (add_address_entry_worker): Likewise.
49 (write_address_map): Likewise.
50 (symbol_kind): Likewise.
51 (write_psymbols): Likewise.
52 (struct signatured_type_index_data): Likewise.
53 (write_one_signatured_type): Likewise.
54 (recursively_count_psymbols): Likewise.
55 (recursively_write_psymbols): Likewise.
56 (class debug_names): Likewise.
57 (check_dwarf64_offsets): Likewise.
58 (psyms_seen_size): Likewise.
59 (write_gdbindex): Likewise.
60 (write_debug_names): Likewise.
61 (assert_file_size): Likewise.
62 (write_psymtabs_to_index): Likewise.
63 (save_gdb_index_command): Likewise.
64 (_initialize_dwarf2_read): Don't register the "save gdb-index"
65 command.
66 * dwarf2read.h: New file.
67
59cc4834
JB
682018-03-27 Joel Brobecker <brobecker@adacore.com>
69
70 PR gdb/22670
71 * dwarf2read.c (dwarf2_physname): Do not return the demangled
72 symbol name if the CU's language stores symbol names in linkage
73 format.
74 * language.h (struct language_defn)
75 <la_store_sym_names_in_linkage_form_p>: New field. Adjust
76 all instances of this struct.
77
67501539
TT
782018-03-26 Tom Tromey <tom@tromey.com>
79
80 * stack.c (backtrace_command_1): Remove verbose code.
81
76c939ac
TT
822018-03-26 Tom Tromey <tom@tromey.com>
83
84 * python/py-framefilter.c (py_print_type): Don't catch
85 exceptions. Return void.
86 (py_print_value): Likewise.
87 (py_print_single_arg): Likewise.
88 (enumerate_args): Don't catch exceptions.
89 (py_print_args): Likewise.
90 (py_print_frame): Likewise.
91 (gdbpy_apply_frame_filter): Catch exceptions here.
92
9507b29c
TT
932018-03-26 Tom Tromey <tom@tromey.com>
94
95 * stack.c (_initialize_stack): Remove trailing newlines from help
96 text. Add "Usage" line to "backtrace" help.
97
eb68e487
TT
982018-03-26 Tom Tromey <tom@tromey.com>
99
100 PR python/16486:
101 * python/py-framefilter.c (py_print_args): Call wrap_hint.
102
1f111921
TT
1032018-03-26 Tom Tromey <tom@tromey.com>
104
105 * python/py-framefilter.c (py_print_single_arg): Return
106 EXT_LANG_BT_ERROR from catch.
107
fb7eb8b5
TT
1082018-03-26 Tom Tromey <tom@tromey.com>
109
110 PR backtrace/15584:
111 * stack.c (backtrace_command_1): Move some code into no-filters
112 "if".
113
4ca59a9f
TT
1142018-03-26 Tom Tromey <tom@tromey.com>
115
116 * python/py-framefilter.c (throw_quit_or_print_exception): New
117 function.
118 (gdbpy_apply_frame_filter): Use it.
119
92256134
TT
1202018-03-26 Tom Tromey <tom@tromey.com>
121
122 PR cli/17716:
123 * python/py-framefilter.c (py_print_type, py_print_value)
124 (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
125 RETURN_MASK_ERROR.
126
7a630bc2
TT
1272018-03-26 Tom Tromey <tom@tromey.com>
128
129 * python/py-framefilter.c (enumerate_args): Use
130 gdb::unique_xmalloc_ptr.
131
63283d4a
TT
1322018-03-26 Tom Tromey <tom@tromey.com>
133
134 * python/py-framefilter.c (py_print_frame): Return
135 EXT_LANG_BT_OK.
136 (gdbpy_apply_frame_filter): Update comment.
137 * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
138 Remove.
139 <EXT_LANG_BT_NO_FILTERS>: Change value.
140
978d6c75
TT
1412018-03-26 Tom Tromey <tom@tromey.com>
142
143 PR backtrace/15582:
144 * stack.c (backtrace_command): Parse "hide" argument.
145 * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
146 * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
147 constant.
148
1cf7e640
TT
1492018-03-26 Tom Tromey <tom@tromey.com>
150
151 * stack.c (backtrace_command_1): Remove "show_locals" parameter,
152 add "flags".
153 (backtrace_command): Remove "fulltrace", add "flags".
154
ea3b0687
TT
1552018-03-26 Tom Tromey <tom@tromey.com>
156
157 * stack.c (backtrace_command): Rewrite command line parsing.
158
9f034d75
SM
1592018-03-26 Simon Marchi <simon.marchi@ericsson.com>
160
161 * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
162
ce1459e5
SM
1632018-03-26 Simon Marchi <simon.marchi@ericsson.com>
164
165 * filename-seen-cache.h: Add include guard.
166
4f7ae6f5
KS
1672018-03-26 Keith Seitz <keiths@redhat.com>
168
169 * symfile.c (place_section): Remove "struct" from section_addr_info
170 in comment.
171 * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
172 "struct" keyword from section_addr_info.
173
5cd3e386
AH
1742018-03-26 Alan Hayward <alan.hayward@arm.com>
175
176 * regformats/regdef.h (reg): Add constructors.
177
3e5ef9a4
PA
1782018-03-25 Pedro Alves <palves@redhat.com>
179
180 * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
181 if then/else bodies in var_func_name extraction.
182
c88d2fcc 1832018-03-23 Weimin Pan <weimin.pan@oracle.com>
bce02d88
WP
184
185 * minsyms.c (lookup_minimal_symbol_and_objfile): Use
186 lookup_minimal_symbol() to find symbol entry.
187 * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
188
b7fee5a3
KS
1892018-03-23 Keith Seitz <keiths@redhat.com>
190
191 PR c++/22968
192 * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
193 nested type definitions for C++, too.
194
2cc9b304
TT
1952018-03-23 Tom Tromey <tom@tromey.com>
196
197 * machoread.c (struct oso_el): Add a constructor. Don't define as
198 a typedef.
199 (macho_register_oso): Remove.
200 (macho_symtab_read): Take a std::vector.
201 (oso_el_compare_name): Now a std::sort comparator.
202 (macho_symfile_read_all_oso): Take a std::vector.
203 (macho_symfile_read): Use std::vector. Remove cleanups.
204
a2b2bc12
TT
2052018-03-22 Tom Tromey <tom@tromey.com>
206
207 * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
208 (record_full_goto_bookmark): Use std::string.
209
7a8f494c
PFC
2102018-03-22 Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
211
212 PR tdep/18295
213 * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
214 a single mask.
215
dd6d677f
PFC
2162018-03-22 Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
217
218 * rs6000-tdep.c (store_insn_p): New function.
219 (skip_prologue): New variable alloca_reg_offset. Set lr_reg
220 and cr_reg to their unshifted values. Use store_insn_p to
221 match LR saves using either R1 or fdata->alloca_reg. Use
222 store_insn_p to match CR saves. Set alloca_reg_offset
223 when alloca_reg and framep are set. Remove lr_reg shift
224 when assigning to fdata->lr_register.
225
26d6cec4
AA
2262018-03-22 Andreas Arnez <arnez@linux.vnet.ibm.com>
227
228 * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
229 command line args instead of emitting a warning.
230
5d9310c4
SM
2312018-03-22 Simon Marchi <simon.marchi@polymtl.ca>
232
233 * tracepoint.h (struct static_tracepoint_marker): Initialize
234 fields, define default constructor, move constructor and move
235 assignment, disable the rest.
236 <str_id, extra>: Make std::string.
237 (release_static_tracepoint_marker): Remove.
238 (free_current_marker): Remove.
239 * tracepoint.c (free_current_marker): Remove.
240 (parse_static_tracepoint_marker_definition): Adjust to
241 std::string, use new hex2str overload.
242 (release_static_tracepoint_marker): Remove.
243 (print_one_static_tracepoint_marker): Get marker by reference
244 and adjust to std::string.
245 (info_static_tracepoint_markers_command): Adjust to std::vector
246 changes
247 * target.h (static_tracepoint_marker_p): Remove typedef.
248 (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
249 (struct target_ops) <to_static_tracepoint_marker_at>: Return
250 bool.
251 <to_static_tracepoint_markers_by_strid>: Return std::vector.
252 * target-debug.h
253 (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
254 (target_debug_print_std_vector_static_tracepoint_marker): New.
255 (target_debug_print_struct_static_tracepoint_marker_p): Rename
256 to...
257 (target_debug_print_static_tracepoint_marker_p): ... this.
258 * target-delegates.c: Re-generate.
259 * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
260 Make std::string.
261 * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
262 (decode_static_tracepoint_spec): Adjust to std::vector.
263 (tracepoint_print_one_detail): Adjust to std::string.
264 (strace_marker_decode_location): Adjust to std::string.
265 (update_static_tracepoint): Adjust to std::string, remove call
266 to release_static_tracepoint_marker.
267 * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
268 Adjust to std::vector.
269 * remote.c (remote_static_tracepoint_marker_at): Return bool.
270 (remote_static_tracepoint_markers_by_strid): Adjust to
271 std::vector.
272 * common/rsp-low.h (hex2str): New overload with explicit count
273 of bytes.
274 * common/rsp-low.c (hex2str): New overload with explicit count
275 of bytes.
276 * unittests/rsp-low-selftests.c (test_hex2str): New function.
277 (_initialize_rsp_low_selftests): Add test_hex2str test.
278 * unittests/tracepoint-selftests.c
279 (test_parse_static_tracepoint_marker_definition): Adjust to
280 std::string.
281
62c222b6
SM
2822018-03-22 Simon Marchi <simon.marchi@polymtl.ca>
283
284 * tracepoint.c (parse_static_tracepoint_marker_definition):
285 Consider case where the definition is followed by more
286 definitions.
287 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
288 tracepoint-selftests.c.
289 * unittests/tracepoint-selftests.c: New.
290
7eb2418f
PFC
2912018-03-21 Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
292
293 * MAINTAINERS (Write After Approval): Add Pedro Franco de
294 Carvalho.
295
7cbe16e9
SR
2962018-03-20 Stephen Roberts <stephen.roberts@arm.com>
297
298 * gdb/symtab.c (find_pc_sect_line): fixed indentation.
299
4ee89e90
SR
3002018-03-20 Stephen Roberts <stephen.roberts@arm.com>
301
302 * gdb/symtab.c (find_pc_sect_line): now uses binary search.
303
92630041
TT
3042018-03-19 Tom Tromey <tom@tromey.com>
305
306 * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
307 "IDENT" production.
308
76727919
TT
3092018-03-19 Pedro Alves <palves@redhat.com>
310 Tom Tromey <tom@tromey.com>
311
312 * unittests/observable-selftests.c: New file.
313 * common/observable.h: New file.
314 * observable.h: New file.
315 * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
316 arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
317 breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
318 corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
319 extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
320 infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
321 linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
322 mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
323 ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
324 python/py-breakpoint.c, python/py-finishbreakpoint.c,
325 python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
326 record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
327 riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
328 spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
329 symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
330 tui/tui-interp.c, valops.c: Update all users.
331 * tui/tui-hooks.c (tui_bp_created_observer)
332 (tui_bp_deleted_observer, tui_bp_modified_observer)
333 (tui_inferior_exit_observer, tui_before_prompt_observer)
334 (tui_normal_stop_observer, tui_register_changed_observer):
335 Remove.
336 (tui_observers_token): New global.
337 (attach_or_detach, tui_attach_detach_observers): New functions.
338 (tui_install_hooks, tui_remove_hooks): Use
339 tui_attach_detach_observers.
340 * record-btrace.c (record_btrace_thread_observer): Remove.
341 (record_btrace_thread_observer_token): New global.
342 * observer.sh: Remove.
343 * observer.c: Rename to observable.c.
344 * observable.c (namespace gdb_observers): Define new objects.
345 (observer_debug): Move into gdb_observers namespace.
346 (struct observer, struct observer_list, xalloc_observer_list_node)
347 (xfree_observer_list_node, generic_observer_attach)
348 (generic_observer_detach, generic_observer_notify): Remove.
349 (_initialize_observer): Update.
350 Don't include observer.inc.
351 * Makefile.in (generated_files): Remove observer.h, observer.inc.
352 (clean mostlyclean): Likewise.
353 (observer.h, observer.inc): Remove targets.
354 (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
355 (COMMON_SFILES): Use observable.c, not observer.c.
356 * .gitignore: Remove observer.h.
357
1cb1f3da
TT
3582018-03-18 Tom Tromey <tom@tromey.com>
359
360 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
361 gdb::def_vector.
362 (bfd_lookup_symbol_from_dyn_symtab): Likewise.
363
a06ab151
TT
3642018-03-17 Tom Tromey <tom@tromey.com>
365
366 * auto-load.c (auto_load_objfile_script_1): Use std::string.
367
770623f7
TT
3682018-03-17 Tom Tromey <tom@tromey.com>
369
370 * target.c (class scoped_target_fd): New.
371 (target_fileio_close_cleanup): Remove.
372 (target_fileio_read_alloc_1): Use scoped_target_fd.
373
39be3c7e
SM
3742018-03-16 Simon Marchi <simon.marchi@polymtl.ca>
375
376 * silent-rules.mk: New.
377 * Makefile.in: Include silent-rules.mk
378 (srcdir, VPATH, top_srcdir): Move up.
379 (COMPILE): Add ECHO_CXX.
380 (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
381 (init.c): Add ECHO_INIT_C.
382 (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
383 (version.c): Add ECHO_GEN.
384 (printcmd.o): Add ECHO_CXX.
385 (target-float.o): Add ECHO_CXX.
386 (ada-exp.o): Add ECHO_CXX.
387 (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
388 (insight$(EXEEXT)): Add ECHO_CXXLD.
389 * gnulib/configure.ac: Add AM_SILENT_RULES.
390 * gnulib/aclocal.m4: Re-generate.
391 * gnulib/configure: Re-generate.
392 * gnulib/import/Makefile.in: Re-generate.
393
37e136b1
TT
3942018-03-16 Tom Tromey <tom@tromey.com>
395
396 * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
397 * utils.h (make_cleanup_free_section_addr_info): Don't declare.
398 * utils.c (do_free_section_addr_info)
399 (make_cleanup_free_section_addr_info): Remove.
400 * symfile.h (struct other_sections): Add constructor.
401 (struct section_addr_info): Remove.
402 (section_addr_info): New typedef.
403 (struct sym_fns) <sym_offsets>: Change type of parameter.
404 (build_section_addr_info_from_objfile)
405 (relative_addr_info_to_section_offsets, addr_info_make_relative)
406 (default_symfile_offsets, symbol_file_add)
407 (symbol_file_add_from_bfd)
408 (build_section_addr_info_from_section_table): Update.
409 (alloc_section_addr_info, free_section_addr_info): Don't declare.
410 * symfile.c (alloc_section_addr_info): Remove.
411 (build_section_addr_info_from_section_table): Change return type.
412 Update.
413 (build_section_addr_info_from_bfd)
414 (build_section_addr_info_from_objfile): Likewise.
415 (free_section_addr_info): Remove.
416 (relative_addr_info_to_section_offsets): Change type of "addrs".
417 (addrs_section_compar): Now a std::sort comparator.
418 (addrs_section_sort): Change return type.
419 (addr_info_make_relative): Change type of "addrs". Update.
420 (default_symfile_offsets, syms_from_objfile_1)
421 (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
422 (symbol_file_add_separate): Update.
423 (symbol_file_add): Change type of "addrs". Update.
424 (add_symbol_file_command): Update. Remove cleanups.
425 * symfile-mem.c (symbol_file_add_from_memory): Update. Remove
426 cleanups.
427 * symfile-debug.c (debug_sym_offsets): Change type of "info".
428 * solib.c (solib_read_symbols): Update.
429 * objfiles.c (objfile_relocate): Update. Remove cleanups.
430 * machoread.c (macho_symfile_offsets): Update.
431 * jit.c (jit_bfd_try_read_symtab): Update.
432
03afa6ef
SM
4332018-03-15 Simon Marchi <simon.marchi@polymtl.ca>
434
435 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
436 unittests/utils-selftests.c.
437 * unittests/utils-selftests.c: New file.
438
3ae9ce5d
TT
4392018-03-14 Tom Tromey <tom@tromey.com>
440
441 PR cli/14977:
442 * printcmd.c (printf_c_string, printf_wide_c_string): Special case
443 for NULL.
444
b8c2339b
TT
4452018-03-14 Tom Tromey <tom@tromey.com>
446
447 PR cli/19918:
448 * printcmd.c (printf_pointer): Allow "-" in format.
449
80ae639d
TT
4502018-03-14 Tom Tromey <tom@tromey.com>
451
452 * printcmd.c (_initialize_printcmd): Add usage to printf.
453
0d671d99
YQ
4542018-03-14 Yao Qi <qiyao@sourceware.org>
455
456 * MAINTAINERS: Update my email address.
457
b577b6af
TT
4582018-03-13 Tom Tromey <tom@tromey.com>
459
460 * machoread.c (macho_check_dsym): Change filenamep to a
461 std::string*.
462 (macho_symfile_read): Update.
463 * symfile.c (load_command): Use std::string.
464
89a3b63e
AB
4652018-03-12 Andrew Burgess <andrew.burgess@embecosm.com>
466
467 * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
468 to error message string.
469 (riscv_register_name): Use xsnprintf instead of sprintf.
470 (riscv_insn::fetch_instruction): Use gdb_assert instead of
471 internal_error.
472 (riscv_print_arg_location): Use gdb_assert_not_reached instead of
473 error.
474 (riscv_push_dummy_call): Likewise.
475
984c7238
TT
4762018-03-12 Tom Tromey <tom@tromey.com>
477
478 * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
479 Use gdb::byte_vector.
480 * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
481
933522d1
YQ
4822018-03-12 Yao Qi <yao.qi@linaro.org>
483
484 * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
485 parameter type to readable_regcache.
486 * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
487 the declaration.
488
be2daae6
TT
4892018-03-11 Tom Tromey <tom@tromey.com>
490
491 * dwarf2read.c (struct nextfield): Add initializers.
492 (struct nextfnfield): Remove.
493 (struct fnfieldlist): Add initializers. Remove "length" and
494 "head", use std::vector.
495 (struct decl_field_list): Remove.
496 (struct field_info): Add initializers.
497 <fields, baseclasses>: Now std::vector.
498 <nbaseclasses, nfnfields, typedef_field_list_count,
499 nested_types_list_count>: Remove.
500 (dwarf2_add_field, dwarf2_add_type_defn)
501 (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
502 (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
503 (process_structure_scope): Update.
504
484cf504
TT
5052018-03-11 Tom Tromey <tom@tromey.com>
506
507 * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
508 for use by std::sort.
509 (build_type_psymtabs_1): Use std::vector.
510
9bd8e0b0
EZ
5112018-03-09 Eli Zaretskii <eliz@gnu.org>
512
513 * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
514 and LIBMPFR in the printed configuration.
515
5dc1a704
TT
5162018-03-08 Tom Tromey <tom@tromey.com>
517
518 * source.c (get_filename_and_charpos): Use scoped_fd.
519 * nto-procfs.c (procfs_open_1): Use scoped_fd.
520 (procfs_pidlist): Likewise.
521 * procfs.c (proc_get_LDT_entry): Use scoped_fd.
522 (iterate_over_mappings): Likewise.
523
fdf07f3a
TT
5242018-03-08 Tom Tromey <tom@tromey.com>
525
526 * infcall.c (struct call_return_meta_info)
527 <stack_temporaries_enabled>: Remove.
528 (get_call_return_value, call_function_by_hand_dummy): Update.
529 * thread.c (disable_thread_stack_temporaries): Remove.
530 (enable_thread_stack_temporaries): Remove.
531 (thread_stack_temporaries_enabled_p): Return bool.
532 (push_thread_stack_temporary, value_in_thread_stack_temporaries)
533 (get_last_thread_stack_temporary): Update.
534 * eval.c (evaluate_subexp): Update.
535 * gdbthread.h (class enable_thread_stack_temporaries): Now a
536 class, not a function.
537 (value_ptr, value_vec): Remove typedefs.
538 (class thread_info) <stack_temporaries_enabled>: Now bool.
539 <stack_temporaries>: Now a std::vector.
540 (thread_stack_temporaries_enabled_p)
541 (value_in_thread_stack_temporaries): Return bool.
542
567a3e54
SM
5432018-03-08 Simon Marchi <simon.marchi@ericsson.com>
544
545 * remote.c (putpkt_binary): Fix omitted bytes reporting.
546 (getpkt_or_notif_sane_1): Likewise.
547
00b40057
SM
5482018-03-08 Simon Marchi <simon.marchi@polymtl.ca>
549
550 * build-id.c (build_id_to_debug_bfd): Use std::string.
551
a8dbfd58
SM
5522018-03-08 Simon Marchi <simon.marchi@polymtl.ca>
553
554 * build-id.c (find_separate_debug_file_by_buildid): Return
555 std::string.
556 * build-id.h (find_separate_debug_file_by_buildid): Return
557 std::string.
558 * coffread.c (coff_symfile_read): Adjust to std::string.
559 * elfread.c (elf_symfile_read): Adjust to std::string.
560 * symfile.c (separate_debug_file_exists): Change parameter to
561 std::string.
562 (find_separate_debug_file): Return std::string.
563 (find_separate_debug_file_by_debuglink): Return std::string.
564 * symfile.h (find_separate_debug_file_by_debuglink): Return
565 std::string.
566
e6a58aa8
SM
5672018-03-08 Simon Marchi <simon.marchi@polymtl.ca>
568
569 * common/xml-utils.c (xml_escape_text): Move code to...
570 (xml_escape_text_append): ... this new function.
571 * common/xml-utils.h (xml_escape_text_append): New declaration.
572 * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
573 New function.
574 (_initialize_xml_utils): register test_xml_escape_text_append as
575 a selftest.
576
4ef0bef6
AH
5772018-03-07 Alan Hayward <alan.hayward@arm.com>
578
579 * defs.h: Remove MAX_REGISTER_SIZE.
580 * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
581 asserts.
582 * python/py-unwind.c (pyuw_sniffer): Likewise.
583
e0d3522b
TT
5842018-03-07 Tom Tromey <tom@tromey.com>
585
586 * linux-tdep.c (linux_info_proc): Update.
587 * target.h (struct target_ops) <to_fileio_readlink>: Return
588 optional<string>.
589 (target_fileio_readlink): Return optional<string>.
590 * remote.c (remote_hostio_readlink): Return optional<string>.
591 * inf-child.c (inf_child_fileio_readlink): Return
592 optional<string>.
593 * target.c (target_fileio_readlink): Return optional<string>.
594
ea005f31
AB
5952018-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
596
597 * regcache.c (cooked_read_test): Add riscv to the list of
598 architectures that have a save_reggroup.
599
e95a97d4
AA
6002018-03-07 Andreas Arnez <arnez@linux.vnet.ibm.com>
601
602 * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
603 value is not a dynamic class object.
604
d8344f3d
TT
6052018-03-06 Tom Tromey <tom@tromey.com>
606
607 * rust-exp.y: Formatting fixes.
608
9add17f2
AB
6092018-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
610
611 * riscv-tdep.c (riscv_register_name): Remove target description
612 support.
613 (riscv_gdbarch_init): Remove target description check.
614
c9486dfe
AB
6152018-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
616
617 * riscv-tdep.c: Remove 'Contributed by ...' lines from header
618 comment.
619 * riscv-tdep.h: Likewise.
620
d74aff3d
AB
6212018-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
622
623 * riscv-tdep.c (riscv_pseudo_register_read): Delete.
624 (riscv_pseudo_register_write): Delete.
625 (riscv_gdbarch_init): Remove all use of pseudo registers.
626
7ea78b59
SM
6272018-03-06 Simon Marchi <simon.marchi@polymtl.ca>
628
629 * record-btrace.c (btrace_print_lines): Replace cleanup
630 parameter with RAII equivalents.
631 (btrace_insn_history): Replace cleanup with RAII equivalents.
632 * ui-out.h (make_cleanup_ui_out_list_begin_end,
633 make_cleanup_ui_out_tuple_begin_end): Remove.
634 * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
635 make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
636 make_cleanup_ui_out_list_begin_end): Remove.
637
53127008
SM
6382018-03-06 Simon Marchi <simon.marchi@polymtl.ca>
639
640 * record-btrace.c (record_btrace_maybe_mark_async_event): Change
641 parameter types to std::vector. Use bool.
642 (record_btrace_wait): Replace VEC(tp_t) with
643 std::vector<thread_info *>.
644 * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
645
228f1508
SM
6462018-03-06 Simon Marchi <simon.marchi@polymtl.ca>
647
648 * record-btrace.c (record_btrace_disable_callback): Remove.
649 (struct scoped_btrace_disable): New.
650 (record_btrace_open): Use scoped_btrace_disable.
651
b2970c23
AB
6522018-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
653
654 * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
655 reading values from registers.
656
fb294655
AB
6572018-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
658
659 * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
660 where appropriate.
661
cab5bb9d
AB
6622018-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
663
664 * riscv-tdep.c (riscv_print_arg_location): Add header comment,
665 change parameter type. Use GDB's print functions, and use
666 core_addr_to_string where appropriate.
667 (riscv_push_dummy_call): Use core_addr_to_string where
668 appropriate, update call to riscv_print_arg_location, and reindent
669 a few lines.
670 (riscv_return_value): Update call to riscv_print_arg_location.
671
dbbb1059
AB
6722018-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
673 Tim Newsome <tim@sifive.com>
674 Albert Ou <a0u@eecs.berkeley.edu>
675 Darius Rad <darius@bluespec.com>
676
677 * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
678 (HFILES_NO_SRCDIR): Add riscv-tdep.h.
679 (ALLDEPFILES): Add riscv-tdep.c
680 * configure.tgt: Add riscv support.
681 * riscv-tdep.c: New file.
682 * riscv-tdep.h: New file.
683 * NEWS: Mention new target.
684 * MAINTAINERS: Add entry for riscv.
685
5dc43913
AB
6862018-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
687
688 * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
689 fields within aggregates.
690
3dea1ef7
SM
6912018-03-04 Simon Marchi <simon.marchi@polymtl.ca>
692
693 * record-btrace.c (btrace_print_lines): Change type of flags to
694 gdb_disassembly_flags.
695
7efba073
JB
6962018-03-04 John Baldwin <jhb@FreeBSD.org>
697
698 * fbsd-nat.c: Include "inf-ptrace.h".
699 (USE_SIGTRAP_SIGINFO): Conditionally define.
700 [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
701 (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
702 [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
703 function.
704 [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
705 Likewise.
706 [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
707 Likewise.
708 (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
709 "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
710 "supports_stopped_by_hw_breakpoint" target methods.
711
386a8676
JB
7122018-03-04 John Baldwin <jhb@FreeBSD.org>
713
714 * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
715 * fbsd-nat.c (debug_fbsd_nat): New variable.
716 (show_fbsd_nat_debug): New function.
717 (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
718 (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
719
12279366
JB
7202018-03-04 John Baldwin <jhb@FreeBSD.org>
721
722 * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
723 * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
724 prototype.
725 * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
726 (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
727 method.
728
54693cf5
SM
7292018-03-02 Simon Marchi <simon.marchi@polymtl.ca>
730
731 * common/gdb_vecs.c (free_char_ptr_vec): Remove.
732 * common/gdb_vecs.h (free_char_ptr_vec): Remove.
733
ccb2231c
SM
7342018-03-02 Simon Marchi <simon.marchi@polymtl.ca>
735
736 * charset.c (struct charset_vector): New.
737 (charsets): Change type to charset_vector.
738 (find_charset_names): Adjust.
739 (add_one): Adjust.
740 (_initialize_charset): Adjust.
741
6fb16ce6
SM
7422018-03-02 Simon Marchi <simon.marchi@polymtl.ca>
743
744 * progspace.h (struct program_space) <deleted_solibs>: Change
745 type to std::vector<std::string>.
746 * progspace.c (clear_program_space_solib_cache): Adjust.
747 * breakpoint.c (print_solib_event): Adjust.
748 (check_status_catch_solib): Adjust.
749 * solib.c (update_solib_list): Adjust.
750 * ui-out.h (class ui_out) <field_string>: New overload.
751 * ui-out.c (ui_out::field_string): New overload.
752
564b1e3f
SM
7532018-03-02 Simon Marchi <simon.marchi@polymtl.ca>
754
755 * progspace.h (struct program_space): Add constructor and
756 destructor, initialize fields.
757 (add_program_space): Remove.
758 * progspace.c (add_program_space): Rename to...
759 (program_space::program_space): ... this.
760 (release_program_space): Rename to...
761 (program_space::~program_space): ... this.
762 (delete_program_space): Use delete to delete program_space.
763 (initialize_progspace): Use new to allocate program_space.
764 * inferior.c (add_inferior_with_spaces): Likewise.
765 (clone_inferior_command): Likewise.
766 * infrun.c (follow_fork_inferior): Likewise.
767 (handle_vfork_child_exec_or_exit): Likewise.
768
e80aaf61
SM
7692018-03-02 Simon Marchi <simon.marchi@polymtl.ca>
770
771 * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
772 (delim_string_to_char_ptr_vec): Return std::vector of
773 gdb::unique_xmalloc_ptr.
774 (dirnames_to_char_ptr_vec_append): Take std::vector of
775 gdb::unique_xmalloc_ptr.
776 (dirnames_to_char_ptr_vec): Return std::vector of
777 gdb::unique_xmalloc_ptr.
778 * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
779 Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
780 (delim_string_to_char_ptr_vec): Return an std::vector of
781 gdb::unique_xmalloc_ptr, adjust the code.
782 (dirnames_to_char_ptr_vec_append): Take an std::vector of
783 gdb::unique_xmalloc_ptr, adjust the code.
784 (dirnames_to_char_ptr_vec): Return an std::vector of
785 gdb::unique_xmalloc_ptr, adjust the code.
786 * auto-load.c (auto_load_safe_path_vec): Change type to
787 std::vector of gdb::unique_xmalloc_ptr.
788 (auto_load_expand_dir_vars): Return an std::vector of
789 gdb::unique_xmalloc_ptr, adjust the code.
790 (auto_load_safe_path_vec_update): Adjust.
791 (filename_is_in_auto_load_safe_path_vec): Adjust.
792 (auto_load_objfile_script_1): Adjust.
793 * build-id.c (build_id_to_debug_bfd): Adjust.
794 * linux-thread-db.c (thread_db_load_search): Adjust.
795 * source.c (add_path): Adjust.
796 (openp): Adjust.
797 * symfile.c (find_separate_debug_file): Adjust.
798 * utils.c (do_free_char_ptr_vec): Remove.
799 (make_cleanup_free_char_ptr_vec): Remove.
800
ab818ade
SDJ
8012018-03-01 Sergio Durigan Junior <sergiodj@redhat.com>
802
803 PR gdb/22907
804 * common/pathstuff.c: Conditionally include "<windows.h>".
805
e1e6f073
GS
8062018-03-01 Georg Sauthoff <mail@georg.so>
807
808 PR gdb/22888
809 * gcore.in: Quote variables and switch interpreter to bash.
810
c7b15a66
TT
8112018-03-01 Tom Tromey <tom@tromey.com>
812
813 * dwarf2read.c (alloc_discriminant_info): Fix default_index
814 assertion. Add assertion for discriminant_index.
815 (quirk_rust_enum): Use correct base type name in univariant case.
816
0cb7c7b0
SM
8172018-03-01 Simon Marchi <simon.marchi@ericsson.com>
818
819 * record.c (get_call_history_modifiers): Return a
820 record_print_flags.
821 (cmd_record_call_history): Adjust.
822 * record-btrace.c (record_btrace_call_history): Adjust.
823 (record_btrace_call_history_range): Adjust.
824 (record_btrace_call_history_from): Adjust.
825 * target-debug.h (target_debug_print_record_print_flags): New.
826 * target-delegates.c: Re-generate.
827 * target.c (target_call_history): Change flags type.
828 (target_call_history_from): Likewise.
829 (target_call_history_range): Likewise.
830 * target.h (struct target_ops) <target_call_history>: Likewise.
831 (target_call_history_from): Likewise.
832 (target_call_history_range): Likewise.
833
25e3c82c
SDJ
8342018-02-28 Sergio Durigan Junior <sergiodj@redhat.com>
835 Simon Marchi <simon.marchi@polymtl.ca>
836
837 * common/common-utils.c: Include "sys/stat.h".
838 (is_regular_file): Move here from "source.c"; change return
839 type to "bool".
840 * common/common-utils.h (is_regular_file): New prototype.
841 * common/pathstuff.c (contains_dir_separator): New function.
842 * common/pathstuff.h (contains_dir_separator): New prototype.
843 * source.c: Don't include "sys/stat.h".
844 (is_regular_file): Move to "common/common-utils.c".
845
b4987c95
SDJ
8462018-02-28 Sergio Durigan Junior <sergiodj@redhat.com>
847
848 * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
849 (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
850 * auto-load.c: Include "common/pathstuff.h".
851 * common/common-def.h (current_directory): Move here.
852 * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
853 function.
854 * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
855 prototype.
856 * common/pathstuff.c: New file.
857 * common/pathstuff.h: New file.
858 * compile/compile.c: Include "common/pathstuff.h".
859 * defs.h (current_directory): Move to "common/common-defs.h".
860 * dwarf2read.c: Include "common/pathstuff.h".
861 * exec.c: Likewise.
862 * guile/scm-safe-call.c: Likewise.
863 * linux-thread-db.c: Likewise.
864 * main.c: Likewise.
865 * nto-tdep.c: Likewise.
866 * objfiles.c: Likewise.
867 * source.c: Likewise.
868 * symtab.c: Likewise.
869 * utils.c: Include "common/pathstuff.h".
870 (gdb_realpath): Move to "common/pathstuff.c".
871 (gdb_realpath_keepfile): Likewise.
872 (gdb_abspath): Likewise.
873 * utils.h (gdb_realpath): Move to "common/pathstuff.h".
874 (gdb_realpath_keepfile): Likewise.
875 (gdb_abspath): Likewise.
876
f169cfdc
JB
8772018-02-28 John Baldwin <jhb@FreeBSD.org>
878
879 * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
880 wildcard process pid for super_resume for kernels with a
881 specific bug.
882
e05cac70
PM
8832018-02-27 Phil Muldoon <pmuldoon@redhat.com>
884
885 * compile/compile.c (get_args): Add additional comments
886 explaining function.
887
55089490
TT
8882018-02-27 Simon Marchi <simon.marchi@polymtl.ca>
889 Tom Tromey <tom@tromey.com>
890
891 * target.h (memory_write_request_s): Remove typedef. Don't define
892 VEC.
893 (target_write_memory_blocks): Change argument to std::vector.
894 (struct memory_write_request): Add constructor.
895 * target-memory.c (compare_block_starting_address): Return bool.
896 Change argument types.
897 (claim_memory): Change arguments to use std::vector.
898 (split_regular_and_flash_blocks, blocks_to_erase)
899 (compute_garbled_blocks): Likewise.
900 (cleanup_request_data, cleanup_write_requests_vector): Remove.
901 (target_write_memory_blocks): Change argument to std::vector.
902 * symfile.c (struct load_section_data): Add constructor and
903 destructor. Use std::vector for "requests".
904 (struct load_progress_data): Add initializers.
905 (load_section_callback): Update. Use "new".
906 (clear_memory_write_data): Remove.
907 (generic_load): Update.
908
0c305b61
AH
9092018-02-27 Alan Hayward <alan.hayward@arm.com>
910
911 * arch/aarch64.h: Use common/tdesc.h.
912
c5196c92
MR
9132018-02-26 Maciej W. Rozycki <macro@mips.com>
914
915 * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
916 architecture with a 64-bit ABI.
917
37c33887
MR
9182018-02-26 Maciej W. Rozycki <macro@mips.com>
919
920 * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
921 ahead of target description loading.
922
d4dd3282
TT
9232018-02-26 Tom Tromey <tom@tromey.com>
924
925 * stack.c (backtrace_command_1): Update.
926 * python/python-internal.h (gdbpy_apply_frame_filter): Change type
927 of "flags".
928 * python/py-framefilter.c (py_print_frame)
929 (gdbpy_apply_frame_filter): Change type of "flags".
930 * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
931 of "flags".
932 (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
933 (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
934 * extension.h (enum frame_filter_flag): Rename from
935 frame_filter_flags.
936 (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
937 (apply_ext_lang_frame_filter): Change type of "flags".
938 * extension.c (apply_ext_lang_frame_filter): Change type of
939 "flags".
940 * extension-priv.h (struct extension_language_ops)
941 <apply_frame_filter>: Change type of "flags".
942
6893c19a
TT
9432018-02-26 Tom Tromey <tom@tromey.com>
944
945 PR python/16497:
946 * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag. Fix
947 off-by-one in py_end computation.
948 * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
949 PRINT_MORE_FRAMES.
950 * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
951 constant.
952
2ddeaf8a
TT
9532018-02-26 Tom Tromey <tom@tromey.com>
954
955 * dwarf2read.c (struct variant_field): New.
956 (struct nextfield) <variant>: New field.
957 (dwarf2_add_field): Handle DW_TAG_variant_part.
958 (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
959 discriminated union.
960 (read_structure_type): Handle DW_TAG_variant_part.
961 (handle_struct_member_die): New function, extracted from
962 process_structure_scope. Handle DW_TAG_variant.
963 (process_structure_scope): Handle discriminated unions. Call
964 handle_struct_member_die.
965
c9317f21
TT
9662018-02-26 Tom Tromey <tom@tromey.com>
967
968 * rust-lang.h (rust_last_path_segment): Declare.
969 * rust-lang.c (rust_last_path_segment): Now public. Change
970 contract.
971 (struct disr_info): Remove.
972 (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
973 (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
974 (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
975 (rust_enum_p, rust_enum_variant): New function.
976 (rust_underscore_fields): Remove "offset" parameter.
977 (rust_print_enum): New function.
978 (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
979 <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
980 (rust_print_struct_def): Add "for_rust_enum" parameter. Handle
981 enums.
982 (rust_internal_print_type): New function, from rust_print_type.
983 Remove enum code.
984 (rust_print_type): Call rust_internal_print_type.
985 (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
986 Update enum handling.
987 * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
988 (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
989 (rust_union_quirks): New functions.
990 (process_full_comp_unit, process_full_type_unit): Call
991 rust_union_quirks.
992 (process_structure_scope): Update rust_unions if necessary.
993
7c22600a
TT
9942018-02-26 Tom Tromey <tom@tromey.com>
995
996 * value.h (value_union_variant): Declare.
997 * valops.c (value_union_variant): New function.
998 * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
999 (struct discriminant_info): New.
1000 (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
1001 enumerator.
1002 (struct main_type) <flag_discriminated_union>: New field.
1003
15ce8941
TT
10042018-02-26 Tom Tromey <tom@tromey.com>
1005
1006 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1007 unittests/unpack-selftests.c.
1008 * unittests/unpack-selftests.c: New file.
1009 * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
1010
48fbe735
YQ
10112018-02-26 Yao Qi <yao.qi@linaro.org>
1012
1013 * dwarf2read.c (struct partial_die_info) <read>: New method.
1014 (read_partial_die): Remove the declaration.
1015 (load_partial_dies): Update.
1016 (partial_die_info::partial_die_info):
1017 (read_partial_die): Change it to partial_die_info::read.
1018
52356b79
YQ
10192018-02-26 Yao Qi <yao.qi@linaro.org>
1020
1021 * dwarf2read.c (struct partial_die_info) <fixup>: New method.
1022 (fixup_partial_die): Remove declaration.
1023 (scan_partial_symbols): Update.
1024 (partial_die_parent_scope): Likewise.
1025 (partial_die_full_name): Likewise.
1026 (fixup_partial_die): Change it to partial_die_info::fixup.
1027
35cc7ed7
YQ
10282018-02-26 Yao Qi <yao.qi@linaro.org>
1029
1030 * dwarf2read.c (read_partial_die): Update the declaration.
1031 (load_partial_dies): Caller update.
1032 (read_partial_die): Remove one argument abbrev_len.
1033
6f06d47b
YQ
10342018-02-26 Yao Qi <yao.qi@linaro.org>
1035
1036 * dwarf2read.c (struct partial_die_info): Add ctor, delete
1037 assignment operator.
1038 (load_partial_dies): Use ctor and copy ctor.
1039 (read_partial_die): Update.
1040 (dwarf2_cu::find_partial_die): Use ctor.
1041
d590ff25
YQ
10422018-02-26 Yao Qi <yao.qi@linaro.org>
1043
1044 * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
1045 (find_partial_die_in_comp_unit): Change it to
1046 dwarf2_cu::find_partial_die.
1047 (find_partial_die): Update.
1048
fd0a254f
YQ
10492018-02-26 Yao Qi <yao.qi@linaro.org>
1050
1051 * dwarf2read.c (read_partial_die): Remove the code checking abbrev
1052 is NULL.
1053
cd9983dd
YQ
10542018-02-26 Yao Qi <yao.qi@linaro.org>
1055
1056 * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
1057
f46cd62a
AH
10582018-02-26 Alan Hayward <alan.hayward@arm.com>
1059
1060 * arch/amd64.h: Use common/tdesc.h.
1061 * arch/i386.c: Likewise.
1062 * arch/i386.h: Likewise.
1063 * arch/tic6x.c: Likewise.
1064 * arch/tdesc.h: Move file from here...
1065 * common/tdesc.h: ...to here.
1066 * features/aarch64-core.c: Regenerate.
1067 * features/aarch64-fpu.c: Regenerate.
1068 * features/i386/32bit-avx.c: Regenerate.
1069 * features/i386/32bit-avx512.c: Regenerate.
1070 * features/i386/32bit-core.c: Regenerate.
1071 * features/i386/32bit-linux.c: Regenerate.
1072 * features/i386/32bit-mpx.c: Regenerate.
1073 * features/i386/32bit-pkeys.c: Regenerate.
1074 * features/i386/32bit-sse.c: Regenerate.
1075 * features/i386/64bit-avx.c: Regenerate.
1076 * features/i386/64bit-avx512.c: Regenerate.
1077 * features/i386/64bit-core.c: Regenerate.
1078 * features/i386/64bit-linux.c: Regenerate.
1079 * features/i386/64bit-mpx.c: Regenerate.
1080 * features/i386/64bit-pkeys.c: Regenerate.
1081 * features/i386/64bit-segments.c: Regenerate.
1082 * features/i386/64bit-sse.c: Regenerate.
1083 * features/i386/x32-core.c: Regenerate.
1084 * features/tic6x-c6xp.c: Regenerate.
1085 * features/tic6x-core.c: Regenerate.
1086 * features/tic6x-gp.c: Regenerate.
1087 * target-descriptions.c: Use common/tdesc.h.
1088 * target-descriptions.h: Likewise.
1089
9b292f68
TT
10902018-02-24 Tom Tromey <tom@tromey.com>
1091
1092 * linux-thread-db.c (try_thread_db_load_from_pdir_1)
1093 (try_thread_db_load_from_dir, thread_db_load_search): Use
1094 std::string.
1095 (info_auto_load_libthread_db_compare): Return bool. Change
1096 argument types.
1097 (info_auto_load_libthread_db): Use std::vector, std::string.
1098 Remove cleanups.
1099
281d762b
TT
11002018-02-24 Tom Tromey <tom@tromey.com>
1101
1102 * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
1103 std::string.
1104 * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
1105 std::string*.
1106 * gdbarch.c: Rebuild.
1107 * gdbarch.h: Rebuild.
1108 * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
1109 * arch-utils.h (default_fast_tracepoint_valid_at): Update.
1110 * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
1111 std::string*.
1112
9d8780f0
SM
11132018-02-23 Simon Marchi <simon.marchi@polymtl.ca>
1114
1115 * gdbtypes.h (sect_offset): Change type to uint64_t.
1116 (sect_offset_str): New function.
1117 * dwarf2read.c (create_addrmap_from_aranges): Use
1118 sect_offset_str.
1119 (error_check_comp_unit_head): Likewise.
1120 (create_debug_type_hash_table): Likewise.
1121 (read_cutu_die_from_dwo): Likewise.
1122 (init_cutu_and_read_dies): Likewise.
1123 (init_cutu_and_read_dies_no_follow): Likewise.
1124 (process_psymtab_comp_unit_reader): Likewise.
1125 (partial_die_parent_scope): Likewise.
1126 (peek_die_abbrev): Likewise.
1127 (process_queue): Likewise.
1128 (dwarf2_physname): Likewise.
1129 (read_namespace_alias): Likewise.
1130 (read_import_statement): Likewise.
1131 (create_dwo_cu_reader): Likewise.
1132 (create_cus_hash_table): Likewise.
1133 (lookup_dwo_cutu): Likewise.
1134 (inherit_abstract_dies): Likewise.
1135 (read_func_scope): Likewise.
1136 (read_call_site_scope): Likewise.
1137 (dwarf2_add_member_fn): Likewise.
1138 (read_common_block): Likewise.
1139 (read_module_type): Likewise.
1140 (read_typedef): Likewise.
1141 (read_subrange_type): Likewise.
1142 (load_partial_dies): Likewise.
1143 (read_partial_die): Likewise.
1144 (find_partial_die): Likewise.
1145 (read_str_index): Likewise.
1146 (dwarf2_string_attr): Likewise.
1147 (build_error_marker_type): Likewise.
1148 (lookup_die_type): Likewise.
1149 (dump_die_shallow): Likewise.
1150 (follow_die_ref): Likewise.
1151 (dwarf2_fetch_die_loc_sect_off): Likewise.
1152 (dwarf2_fetch_constant_bytes): Likewise.
1153 (follow_die_sig): Likewise.
1154 (get_signatured_type): Likewise.
1155 (get_DW_AT_signature_type): Likewise.
1156 (dwarf2_find_containing_comp_unit): Likewise.
1157 (set_die_type): Likewise.
1158
8ec57239
JB
11592018-02-21 John Baldwin <jhb@FreeBSD.org>
1160
1161 * arch/aarch64.c: Include "common-defs.h".
1162 * arch/amd64.c: Likewise.
1163 * arch/i386.c: Likewise.
1164
3eac2b65
TT
11652018-02-21 Tom Tromey <tom@tromey.com>
1166
1167 * value.h: (extract_field_op): Update.
1168 * eval.c (extract_field_op): Return a const char *.
1169 * expression.h (parse_expression_for_completion): Update.
1170 * completer.c (complete_expression): Update.
1171 (add_struct_fields): Make fieldname const.
1172 * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
1173 (mark_completion_tag, parse_exp_in_context_1): Update.
1174 (parse_expression_for_completion): Change "name" to
1175 unique_xmalloc_ptr*.
1176
6ccb583f
TT
11772018-02-21 Tom Tromey <tom@tromey.com>
1178
1179 * infcall.c (call_function_by_hand_dummy): Use std::vector.
1180
c113ed0c
YQ
11812018-02-21 Yao Qi <yao.qi@linaro.org>
1182
1183 * avr-tdep.c (avr_read_pc): Change parameter type to
1184 readable_regcache.
1185 * gdbarch.sh (read_pc): Likewise.
1186 * gdbarch.c: Re-generated.
1187 * gdbarch.h: Re-generated.
1188 * hppa-tdep.c (hppa_read_pc): Change parameter type to
1189 readable_regcache.
1190 * ia64-tdep.c (ia64_read_pc): Likewise.
1191 * mips-tdep.c (mips_read_pc): Likewise.
1192 * spu-tdep.c (spu_read_pc): Likewise.
1193
4c74fe6b
YQ
11942018-02-21 Yao Qi <yao.qi@linaro.org>
1195
1196 * Makefile.in (COMMON_SFILES): Add regcache-dump.c
1197 * regcache-dump.c: New file.
1198 * regcache.c: Move register_dump to regcache-dump.c.
1199 (maintenance_print_registers): Likewise.
1200 (maintenance_print_raw_registers): Likewise.
1201 (maintenance_print_cooked_registers): Likewise.
1202 (maintenance_print_register_groups): Likewise.
1203 (maintenance_print_remote_registers): Likewise.
1204 (_initialize_regcache): Likewise.
1205 * regcache.h (register_dump): Moved from regcache.c.
1206
796bb026
YQ
12072018-02-21 Yao Qi <yao.qi@linaro.org>
1208
1209 * regcache.c (regcache::regcache): Update.
1210 (regcache::invalidate): Move it to detached_regcache::invalidate.
1211 (get_thread_arch_aspace_regcache): Update.
1212 (regcache::raw_update): Update.
1213 (regcache::cooked_read): Remove some code.
1214 (regcache::cooked_read_value): Likewise.
1215 (regcache::raw_write): Remove assert on m_readonly_p.
1216 (regcache::raw_supply_integer): Move it to
1217 detached_regcache::raw_supply_integer.
1218 (regcache::raw_supply_zeroed): Likewise.
1219 * regcache.h (detached_regcache) <raw_supply_integer>: New
1220 declaration.
1221 <raw_supply_zeroed, invalidate>: Likewise.
1222 (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
1223 <invalidate>: Likewise.
1224 <m_readonly_p>: Removed.
1225
215c69dc
YQ
12262018-02-21 Yao Qi <yao.qi@linaro.org>
1227
1228 * infcmd.c (get_return_value): Let stop_regs point to
1229 get_current_regcache.
1230 * regcache.c (regcache::regcache): Remove.
1231 (register_dump_reg_buffer): New class.
1232 (regcache_print): Adjust.
1233 * regcache.h (regcache): Remove constructors.
1234
f3384e66
YQ
12352018-02-21 Yao Qi <yao.qi@linaro.org>
1236
1237 * regcache.c (class register_dump): New class.
1238 (register_dump_regcache, register_dump_none): New class.
1239 (register_dump_remote, register_dump_groups): New class.
1240 (regcache_print): Update.
1241 * regcache.h (regcache_dump_what): Move it to regcache.c.
1242 (regcache) <dump>: Remove.
1243
c8ec2f33
YQ
12442018-02-21 Yao Qi <yao.qi@linaro.org>
1245
1246 * jit.c (struct jit_unwind_private) <regcache>: Change its type to
1247 reg_buffer_rw *.
1248 (jit_unwind_reg_set_impl): Call raw_supply.
1249 (jit_frame_sniffer): Use reg_buffer_rw.
1250 * record-full.c (record_full_core_regbuf): Change its type.
1251 (record_full_core_open_1): Use reg_buffer_rw.
1252 (record_full_close): Likewise.
1253 (record_full_core_fetch_registers): Use regcache->raw_supply.
1254 (record_full_core_store_registers): Likewise.
1255 * regcache.c (regcache::get_register_status): Move it to
1256 reg_buffer.
1257 (regcache_raw_set_cached_value): Remove.
1258 (regcache::raw_set_cached_value): Remove.
1259 (regcache::raw_write): Call raw_supply.
1260 (regcache::raw_supply): Move it to reg_buffer_rw.
1261 * regcache.h (regcache_raw_set_cached_value): Remove.
1262 (reg_buffer_rw): New class.
1263
daf6667d
YQ
12642018-02-21 Yao Qi <yao.qi@linaro.org>
1265
1266 * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
1267 readonly_detached_regcache.
1268 (dummy_frame_prev_register): Use regcache->cooked_read.
1269 * frame.c (frame_save_as_regcache): Change return type.
1270 (frame_pop): Update.
1271 * frame.h (frame_save_as_regcache): Update declaration.
1272 * inferior.h (get_infcall_suspend_state_regcache): Update
1273 declaration.
1274 * infrun.c (infcall_suspend_state) <registers>: use
1275 readonly_detached_regcache.
1276 (save_infcall_suspend_state): Don't use regcache_dup.
1277 (get_infcall_suspend_state_regcache): Change return type.
1278 * linux-fork.c (struct fork_info) <savedregs>: Change to
1279 readonly_detached_regcache.
1280 <pc>: New field.
1281 (fork_save_infrun_state): Don't use regcache_dup.
1282 (info_checkpoints_command): Adjust.
1283 * mi/mi-main.c (register_changed_p): Update declaration.
1284 (mi_cmd_data_list_changed_registers): Use
1285 readonly_detached_regcache.
1286 (register_changed_p): Change parameter type to
1287 readonly_detached_regcache.
1288 * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
1289 readonly_detached_regcache.
1290 (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
1291 * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
1292 New.
1293 (regcache::save): Move it to reg_buffer.
1294 (regcache::restore): Change parameter type.
1295 (regcache_dup): Remove.
1296 * regcache.h (reg_buffer) <save>: New method.
1297 (readonly_detached_regcache): New class.
1298 * spu-tdep.c (spu2ppu_cache) <regcache>: Use
1299 readonly_detached_regcache.
1300 (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
1301
fc5b8736
YQ
13022018-02-21 Yao Qi <yao.qi@linaro.org>
1303
1304 * frame.c (frame_save_as_regcache): Use regcache method save.
1305 (frame_pop): Use regcache method restore.
1306 * infrun.c (restore_infcall_suspend_state): Likewise.
1307 * linux-fork.c (fork_load_infrun_state): Likewise.
1308 * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
1309 save.
1310 * regcache.c (regcache_save): Remove.
1311 (regcache::restore): More asserts.
1312 (regcache_cpy): Remove.
1313 * regcache.h (regcache_save): Remove the declaration.
1314 (regcache::restore): Move from private to public.
1315 Remove the friend declaration of regcache_cpy.
1316 (regcache_cpy): Remove declaration.
1317
849d0ba8
YQ
13182018-02-21 Yao Qi <yao.qi@linaro.org>
1319
1320 * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
1321 parameter type to 'readable_regcache *'.
1322 * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
1323 * arm-tdep.c (arm_neon_quad_read): Likewise.
1324 (arm_pseudo_read): Likewise.
1325 * avr-tdep.c (avr_pseudo_register_read): Likewise.
1326 * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
1327 * frv-tdep.c (frv_pseudo_register_read): Likewise.
1328 * gdbarch.c: Re-generated.
1329 * gdbarch.h: Re-generated.
1330 * gdbarch.sh (pseudo_register_read): Change parameter type to
1331 'readable_regcache *'.
1332 (pseudo_register_read_value): Likewise.
1333 * h8300-tdep.c (pseudo_from_raw_register): Likewise.
1334 (h8300_pseudo_register_read): Likewise.
1335 * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
1336 * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
1337 (i386_pseudo_register_read_into_value): Likewise.
1338 (i386_pseudo_register_read_value): Likewise.
1339 * i386-tdep.h (i386_pseudo_register_read_into_value): Update
1340 declaration.
1341 * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
1342 * m32c-tdep.c (m32c_raw_read): Likewise.
1343 (m32c_read_flg): Likewise.
1344 (m32c_banked_register): Likewise.
1345 (m32c_banked_read): Likewise.
1346 (m32c_sb_read): Likewise.
1347 (m32c_part_read): Likewise.
1348 (m32c_cat_read): Likewise.
1349 (m32c_r3r2r1r0_read): Likewise.
1350 (m32c_pseudo_register_read): Likewise.
1351 * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
1352 * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
1353 (mep_pseudo_cr64_read): Likewise.
1354 (mep_pseudo_register_read): Likewise.
1355 * mips-tdep.c (mips_pseudo_register_read): Likewise.
1356 * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
1357 * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
1358 * regcache.c (regcache::raw_read): Move it to readable_regcache.
1359 (regcache::cooked_read): Likewise.
1360 (regcache::cooked_read_value): Likewise.
1361 (regcache_cooked_read_signed):
1362 (regcache::cooked_read): Likewise.
1363 * regcache.h (readable_regcache): New class.
1364 (regcache): Inherit readable_regcache. Move some methods to
1365 readable_regcache.
1366 * rl78-tdep.c (rl78_pseudo_register_read): Change
1367 parameter type to 'readable_regcache *'.
1368 * rs6000-tdep.c (do_regcache_raw_read): Remove.
1369 (e500_pseudo_register_read): Change parameter type to
1370 'readable_regcache *'.
1371 (dfp_pseudo_register_read): Likewise.
1372 (vsx_pseudo_register_read): Likewise.
1373 (efpr_pseudo_register_read): Likewise.
1374 * s390-tdep.c (s390_pseudo_register_read): Likewise.
1375 * sh-tdep.c (sh_pseudo_register_read): Likewise.
1376 * sh64-tdep.c (pseudo_register_read_portions): Likewise.
1377 (sh64_pseudo_register_read): Likewise.
1378 * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
1379 * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
1380 * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
1381 (spu_pseudo_register_read): Likewise.
1382 * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
1383 (xtensa_pseudo_register_read): Likewise.
1384
31716595
YQ
13852018-02-21 Yao Qi <yao.qi@linaro.org>
1386
1387 * regcache.c (regcache::regcache): Call reg_buffer ctor.
1388 (regcache::arch): Move it to reg_buffer::arch.
1389 (regcache::register_buffer): Likewise.
1390 (regcache::assert_regnum): Likewise.
1391 (regcache::num_raw_registers): Likewise.
1392 * regcache.h (reg_buffer): New class.
1393 (regcache): Inherit reg_buffer.
1394
7104e59b
SM
13952018-02-20 Simon Marchi <simon.marchi@ericsson.com>
1396
1397 * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
1398 gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
1399
2d8adcbd
MM
14002018-02-20 Markus Metzger <markus.t.metzger@intel.com>
1401
1402 * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
1403
b5884fa7
AH
14042018-02-19 Alan Hayward <alan.hayward@arm.com>
1405
1406 * Makefile.in: (COMMON_SFILES): Add common/*.c files.
1407 (SFILES): Remove common/*.c files.
1408 (COMMON_OBS): Remove some *.o files built from common/*.c files.
1409 * common/common.host: Add common reference.
1410 * configure.ac: Likewise.
1411 * configure: Regenerate.
1412
fd90ace4
YQ
14132018-02-16 Yao Qi <yao.qi@linaro.org>
1414
1415 * block.c (block_namespace_info): Inherit allocate_on_obstack.
1416 (block_initialize_namespace): Use new.
1417 * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
1418 (dwarf2_free_objfile): Use delete.
1419 * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
1420 (copy_type_recursive): Use new.
1421 * gdb_obstack.h (allocate_on_obstack): New.
1422
85046ae2
YQ
14232018-02-15 Yao Qi <yao.qi@linaro.org>
1424
1425 PR gdb/22849
1426 * inferior.c (exit_inferior_1): Reset inf->control.
1427
355c559b
JB
14282018-02-15 Joel Brobecker <brobecker@adacore.com>
1429
1430 * ada-lang.c (ada_to_fixed_value_create): Delete advance
1431 declaration.
1432
980548fd
PA
14332018-02-14 Pedro Alves <palves@redhat.com>
1434
1435 * frame-unwind.c (frame_unwind_try_unwinder): Always call
1436 frame_cleanup_after_sniffer on exception.
1437
692d6f97
TT
14382018-02-14 Tom Tromey <tom@tromey.com>
1439
1440 * solist.h (struct target_so_ops) <bfd_open>: Make pathname
1441 const.
1442 (solib_bfd_open): Make pathname const.
1443 * solib.c (solib_bfd_open): Make pathname const.
1444 * solib-spu.c (spu_bfd_fopen): Make name const.
1445 (spu_bfd_open): Make pathname const.
1446 * solib-darwin.c (darwin_bfd_open): Make pathname const.
1447 * solib-aix.c (solib_aix_bfd_open): Make pathname const.
1448
e0cc99a6
TT
14492018-02-14 Tom Tromey <tom@tromey.com>
1450
1451 * symfile.c (symfile_bfd_open): Update.
1452 * source.h (openp, source_full_path_of, find_and_open_source):
1453 Change argument type to unique_xmalloc_ptr.
1454 * source.c (openp): Take a unique_xmalloc_ptr.
1455 (source_full_path_of, find_and_open_source): Likewise.
1456 (open_source_file, symtab_to_fullname): Update.
1457 * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
1458 unique_xmalloc_ptr.
1459 * solib.c (solib_find_1): Use unique_xmalloc_ptr.
1460 (exec_file_find): Update.
1461 * psymtab.c (psymtab_to_fullname): Update.
1462 * nto-tdep.h (nto_find_and_open_solib): Update.
1463 * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
1464 unique_xmalloc_ptr.
1465 * exec.c (exec_file_attach): Update.
1466 * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
1467 * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
1468
b46a8d7c
TT
14692018-02-14 Tom Tromey <tom@tromey.com>
1470
1471 * solib.c: Include source.h.
1472 * nto-tdep.c: Include source.h.
1473 * mi/mi-cmd-env.c: Include source.h.
1474 * infcmd.c: Include source.h.
1475 * exec.c: Include source.h.
1476 * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
1477 (add_path, directory_switch, source_path, init_source_path): Move
1478 declarations...
1479 * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
1480 (add_path, directory_switch, source_path, init_source_path):
1481 ...here.
1482
797bc1cb
TT
14832018-02-14 Tom Tromey <tom@tromey.com>
1484
1485 * solist.h (exec_file_find, solib_find): Return
1486 unique_xmalloc_ptr.
1487 (solib_bfd_fopen): Take a const char *.
1488 * solib.c (solib_find_1): Return unique_xmalloc_ptr.
1489 (exec_file_find, solib_find): Likewise.
1490 (solib_bfd_fopen): Do not take ownership of "pathname".
1491 (solib_bfd_open): Use unique_xmalloc_ptr.
1492 * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
1493 * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
1494 * infrun.c (follow_exec): Use unique_xmalloc_ptr.
1495 * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
1496
f98b2e33
JB
14972018-02-14 Joel Brobecker <brobecker@adacore.com>
1498
1499 * ada-lang.c (name_match_type_from_name): Remove reference to
1500 ada_name_for_lookup in function's documentation.
1501 * ada-lang.h (ada_name_for_lookup): Delete declaration.
1502
24b9144d
SM
15032018-02-13 Simon Marchi <simon.marchi@polymtl.ca>
1504
1505 * defs.h (enum openp_flags): New enum.
1506 (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
1507 Move to enum openp_flags.
1508 (openp_flags): New enum flags.
1509 (openp): Change parameter type to openp_flags.
1510 * source.c (openp): Change parameter type to openp_flags.
1511 * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
1512 * dwarf2read.c (try_open_dwop_file): Use openp_flags.
1513
387cd15b
SM
15142018-02-13 Simon Marchi <simon.marchi@polymtl.ca>
1515
1516 * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
1517 per-command.
1518
b303c6f6
AB
15192018-02-12 Andrew Burgess <andrew.burgess@embecosm.com>
1520
1521 * dwarf2read.c (dwarf2_release_queue): Delete function, move body
1522 into...
1523 (class dwarf2_queue_guard): ...the destructor of this new class.
1524 (dw2_do_instantiate_symtab): Create instance of the new class
1525 dwarf2_queue_guard, remove cleanup.
1526
9c3630e9
TT
15272018-02-09 Tom Tromey <tom@tromey.com>
1528
1529 * source.c (find_source_lines): Don't reference past the end of
1530 the vector.
1531
c4e12631
MM
15322018-02-09 Markus Metzger <markus.t.metzger@intel.com>
1533
1534 * remote.c (remote_btrace_maybe_reopen): Change error message.
1535 * btrace.c (btrace_enable): Likewise.
1536 (parse_xml_btrace): Likewise.
1537 (parse_xml_btrace_conf): Likewise.
1538
88711fbf
MM
15392018-02-09 Markus Metzger <markus.t.metzger@intel.com>
1540
1541 * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
1542 (linux_enable_pt, linux_enable_bts): Call
1543 diagnose_perf_event_open_fail.
1544
17ad2a4f
MM
15452018-02-09 Markus Metzger <markus.t.metzger@intel.com>
1546
1547 * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
1548 Remove parameter and change return type. Update callers. Move it.
1549 (linux_enable_bts, linux_enable_pt): Improve error message.
1550 (linux_enable_pt): Remove zero buffer size check.
1551 (linux_enable_btrace): Improve error messages. Remove NULL return
1552 check.
1553
de6242d3
MM
15542018-02-09 Markus Metzger <markus.t.metzger@intel.com>
1555
1556 * btrace.c (btrace_enable): Remove target_supports_btrace call.
1557 * nat/linux-btrace.c (perf_event_pt_event_type): Move.
1558 (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
1559 (linux_supports_pt, linux_supports_btrace): Remove.
1560 (linux_enable_bts): Call cpu_supports_bts.
1561 * nat/linux-btrace.h (linux_supports_btrace): Remove.
1562 * remote.c (remote_supports_btrace): Remove.
1563 (init_remote_ops): Remove remote_supports_btrace.
1564 * target-delegates.c: Regenerated.
1565 * target.c (target_supports_btrace): Remove.
1566 * target.h (target_ops) <to_supports_btrace>: Remove
1567 (target_supports_btrace): Remove.
1568 * x86-linux-nat.c (x86_linux_create_target): Remove
1569 linux_supports_btrace.
1570
9ee23a85
MM
15712018-02-09 Markus Metzger <markus.t.metzger@intel.com>
1572
1573 * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
1574 btrace failed.
1575 * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
1576 exception and use message in own exception.
1577
5c3284c1
MM
15782018-02-09 Markus Metzger <markus.t.metzger@intel.com>
1579
1580 * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
1581 (perf_event_pt_event_type): Use gdb_file_up.
1582 (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
1583 scoped_fd, and scoped_mmap.
1584
84696f37
MM
15852018-02-09 Markus Metzger <markus.t.metzger@intel.com>
1586
1587 * common/scoped_mmap.h: New.
1588 * unittests/scoped_mmap-selftest.c: New.
1589 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1590 unittests/scoped_mmap-selftest.c.
1591
ea4a0888
MM
15922018-02-09 Markus Metzger <markus.t.metzger@intel.com>
1593
1594 * common/scoped_fd.h: New.
1595 * unittests/scoped_fd-selftest.c: New.
1596 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1597 unittests/scoped_fd-selftest.c.
1598
869e8290
TT
15992018-02-09 Tom Tromey <tom@tromey.com>
1600
1601 * auto-load.c (auto_load_section_scripts): Use
1602 gdb::unique_xmalloc_ptr.
1603
a37a2ae7
TT
16042018-02-09 Tom Tromey <tom@tromey.com>
1605
1606 * auto-load.c (execute_script_contents): Use std::string.
1607
4e725347
JB
16082018-02-09 Joel Brobecker <brobecker@adacore.com>
1609
1610 * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
1611 Python function, rather than a new command.
1612
9a897d43
TT
16132018-02-08 Tom Tromey <tom@tromey.com>
1614
1615 * solib.c (solib_find_1): Use std::string.
1616 (solib_bfd_fopen): Use unique_xmalloc_ptr.
1617
58ef3771
TT
16182018-02-08 Tom Tromey <tom@tromey.com>
1619
1620 * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
1621
a9abc434
TT
16222018-02-08 Tom Tromey <tom@tromey.com>
1623
1624 * source.c (find_source_lines): Use gdb::def_vector.
1625
84f27c6f
TT
16262018-02-08 Tom Tromey <tom@tromey.com>
1627
1628 * macrocmd.c (struct temporary_macro_definition): New.
1629 (macro_define_command): Use temporary_macro_definition. Remove
1630 cleanups.
1631 (free_macro_definition_ptr): Remove.
1632
0354904b
TT
16332018-02-08 Tom Tromey <tom@tromey.com>
1634
1635 * macroexp.c (maybe_expand): Use std::string.
1636
1739cf24
TT
16372018-02-08 Tom Tromey <tom@tromey.com>
1638
1639 * macroexp.c (struct macro_buffer): Add initializers for some
1640 members.
1641 (init_buffer, init_shared_buffer, free_buffer)
1642 (free_buffer_return_text): Remove.
1643 (macro_buffer): New constructors.
1644 (~macro_buffer): New destructor.
1645 (macro_buffer::set_shared): New method.
1646 (macro_buffer::resize_buffer, macro_buffer::appendc)
1647 (macro_buffer::appendmem): Now methods, not free functions.
1648 (set_token, append_tokens_without_splicing, stringify)
1649 (macro_stringify): Update.
1650 (gather_arguments): Change return type. Remove argc_p argument,
1651 add args_ptr argument. Use std::vector.
1652 (substitute_args): Remove argc argument. Accept std::vector.
1653 (expand): Update. Use std::vector.
1654 (scan, macro_expand, macro_expand_next): Update.
1655
f6c2623e
TT
16562018-02-08 Tom Tromey <tom@tromey.com>
1657
1658 * symtab.c (default_collect_symbol_completion_matches_break_on):
1659 Use unique_xmalloc_ptr.
1660 * macroscope.h: (sal_macro_scope, user_macro_scope)
1661 (default_macro_scope): Return unique_xmalloc_ptr.
1662 * macroscope.c (sal_macro_scope, user_macro_scope)
1663 (default_macro_scope): Return unique_xmalloc_ptr.
1664 * macroexp.h (macro_expand, macro_expand_once): Return
1665 unique_xmalloc_ptr.
1666 * macroexp.c (macro_expand, macro_expand_once): Return
1667 unique_xmalloc_ptr.
1668 * macrocmd.c (macro_expand_command, macro_expand_once_command)
1669 (info_macro_command, info_macros_command): Use
1670 unique_xmalloc_ptr.
1671 * compile/compile-c-support.c (write_macro_definitions): Use
1672 unique_xmalloc_ptr.
1673 * c-exp.y (c_parse): Use unique_xmalloc_ptr.
1674
c2e0e465
SM
16752018-02-07 Simon Marchi <simon.marchi@ericsson.com>
1676
1677 * value.c (value_static_field): Assign field type instead of
1678 containing type when returning an optimized out value.
1679
3f8c94b4
YQ
16802018-02-06 Yao Qi <yao.qi@linaro.org>
1681
1682 * ft32-tdep.c (ft32_read_pc): Remove.
1683 (ft32_write_pc): Remove.
1684 (ft32_gdbarch_init): Update.
1685 * m32r-tdep.c (m32r_read_pc): Remove.
1686 (m32r_gdbarch_init): Update.
1687 * mep-tdep.c (mep_read_pc): Remove.
1688 (mep_gdbarch_init): Update.
1689 * microblaze-tdep.c (microblaze_write_pc): Remove.
1690 (microblaze_gdbarch_init): Update.
1691 * mn10300-tdep.c (mn10300_read_pc): Remove.
1692 (mn10300_write_pc): Remove.
1693 (mn10300_gdbarch_init): Update.
1694 * moxie-tdep.c (moxie_read_pc): Remove.
1695 (moxie_write_pc): Remove.
1696 (moxie_gdbarch_init): Update.
1697
bca65a23
YQ
16982018-02-06 Yao Qi <yao.qi@linaro.org>
1699
1700 * expprint.c (print_subexp_standard): Handle
1701 OP_F77_UNDETERMINED_ARGLIST.
1702 (dump_subexp_body_standard): Likewise.
1703
583e3f90 17042018-02-05 Alan Hayward <alan.hayward@arm.com>
b8df6ca7 1705
583e3f90
YQ
1706 * target-descriptions.c (tdesc_element_visitor) Add empty
1707 implementations.
b8df6ca7
AH
1708 (tdesc_type): Move make_gdb_type from here.
1709 (tdesc_type_builtin): Likewise.
1710 (tdesc_type_vector): Likewise.
1711 (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
1712 (make_gdb_type_struct): Move from tdesc_type_with_fields.
1713 (make_gdb_type_union): Likewise.
1714 (make_gdb_type_flags): Likewise.
1715 (make_gdb_type_enum): Likewise.
1716 (make_gdb_type): New function.
1717 (tdesc_register_type): Use static make_gdb_type.
1718
e813d34a
RK
17192018-02-05 Ruslan Kabatsayev <b7.10110111@gmail.com>
1720
1721 * infcmd.c (default_print_one_register_info): Align natural-format
1722 column values consistently one under another.
1723 (pad_to_column): New function.
1724
0eb876f5
JB
17252018-02-05 Joel Brobecker <brobecker@adacore.com>
1726
1727 * dwarf2read.c (dwarf2_physname): Move commment.
1728
0625771b
LS
17292018-02-01 Leszek Swirski <leszeks@google.com>
1730
1731 * varobj.c (varobj_formatted_print_options): Allow recursive
1732 pretty printing if pretty printing is enabled.
1733
59498c30
LS
17342018-02-01 Leszek Swirski <leszeks@google.com>
1735
1736 * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
1737 names after a structop as a filename.
1738
2d9e6acb
YQ
17392018-02-01 Yao Qi <yao.qi@linaro.org>
1740
1741 * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
1742 (arm_record_coproc_data_proc): Likewise.
1743
df95a9cf
YQ
17442018-02-01 Yao Qi <yao.qi@linaro.org>
1745
1746 * arm-tdep.c (arm_record_extension_space): Change ret to signed.
1747
07e5f5cf
NP
17482018-01-31 Nikola Prica <nikola.prica@rt-rk.com>
1749
1750 * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
1751 assign shifted lr_reg to fdata->lr_register when lr_reg is set.
1752
3045b475
PA
17532018-01-31 Pedro Alves <palves@redhat.com>
1754
1755 * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
1756 * inflow.c (child_terminal_save_inferior): Wrap reference to
1757 tcgetpgrp in HAVE_TERMIOS_H.
1758 (child_interrupt, child_pass_ctrlc): Wrap references to signal in
1759 _WIN32.
1760 * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
1761 always iterate over all inferiors.
1762 (gdbsim_cntrl_c): Adjust.
1763 * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
1764
929b5ad4
JB
17652018-01-31 Joel Brobecker <brobecker@adacore.com>
1766
1767 * gdbtypes.c (lookup_array_range_type): Make sure the array's
1768 index type is objfile-owned if the element type is as well.
1769
29236ca2
JB
17702018-01-31 Joel Brobecker <brobecker@adacore.com>
1771
1772 GDB 8.1 released.
1773
c81e8879
PR
17742018-01-30 Philipp Rudo <prudo@linux.vnet.ibm.com>
1775
1776 * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
1777 "features/s390x-linux64.c".
1778 (_initialize_s390_linux_tdep): Remove initialization of tdescs
1779 s390_linux32 and s390x_linux64.
1780 (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
1781 default tdesc.
1782 * s390-tdep.c: Include "features/s390-linux32.c" and
1783 "features/s390x-linux64.c".
1784 (s390_tdesc_valid): Add check for tdesc_has_registers.
1785 (s390_gdbarch_init): Make sure there is always a valid tdesc.
1786 (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
1787 tdesc_s390x_linux64.
1788 * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
1789 tdesc_s390x_linux64 to...
1790 * s390-tdep.h: ...here.
1791
e671cd59
PA
17922018-01-30 Pedro Alves <palves@redhat.com>
1793
1794 PR gdb/13211
1795 * config.in, configure: Regenerate.
1796 * configure.ac: Check for getpgid.
1797 * go32-nat.c (go32_pass_ctrlc): New.
1798 (go32_target): Install it.
1799 * inf-child.c (inf_child_target): Install
1800 child_terminal_save_inferior, child_pass_ctrlc and
1801 child_interrupt.
1802 * inf-ptrace.c (inf_ptrace_interrupt): Delete.
1803 (inf_ptrace_target): No longer install it.
1804 * infcmd.c (interrupt_target_1): Adjust.
1805 * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
1806 (child_interrupt): Declare.
1807 (inferior::terminal_state): New.
1808 * inflow.c (struct terminal_info): Update comments.
1809 (inferior_process_group): Delete.
1810 (terminal_is_ours): Delete.
1811 (gdb_tty_state): New.
1812 (child_terminal_init): Adjust.
1813 (is_gdb_terminal, sharing_input_terminal_1)
1814 (sharing_input_terminal): New functions.
1815 (child_terminal_inferior): Adjust. Use sharing_input_terminal.
1816 Set the process's actual process group in the foreground if
1817 possible. Handle is_ours_for_output/is_ours distinction. Don't
1818 mark terminal as the inferior's if not sharing GDB's terminal.
1819 Don't check attach_flag.
1820 (child_terminal_ours_for_output, child_terminal_ours): Adjust to
1821 pass down a target_terminal_state.
1822 (child_terminal_save_inferior): New, factored out from ...
1823 (child_terminal_ours_1): ... this. Handle
1824 target_terminal_state::is_ours_for_output.
1825 (child_interrupt, child_pass_ctrlc): New.
1826 (inflow_inferior_exit): Clear the inferior's terminal_state.
1827 (copy_terminal_info): Copy the inferior's terminal state.
1828 (_initialize_inflow): Remove reference to terminal_is_ours.
1829 * inflow.h (inferior_process_group): Delete.
1830 * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
1831 * procfs.c (procfs_target): Don't install procfs_interrupt.
1832 (procfs_interrupt): Delete.
1833 * remote.c (remote_serial_quit_handler): Adjust.
1834 (remote_interrupt): Remove ptid parameter. Adjust.
1835 * target-delegates.c: Regenerate.
1836 * target.c: Include "terminal.h".
1837 (target_terminal::terminal_state): Rename to ...
1838 (target_terminal::m_terminal_state): ... this.
1839 (target_terminal::init): Adjust.
1840 (target_terminal::inferior): Adjust to per-inferior
1841 terminal_state.
1842 (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
1843 (target_terminal::ours, target_terminal::ours_for_output): Use
1844 target_terminal_is_ours_kind.
1845 (target_interrupt): Remove ptid parameter. Adjust.
1846 (default_target_pass_ctrlc): Adjust.
1847 * target.h (target_ops::to_terminal_save_inferior): New field.
1848 (target_ops::to_interrupt): Remove ptid_t parameter.
1849 (target_interrupt): Remove ptid_t parameter. Update comment.
1850 (target_pass_ctrlc): Update comment.
1851 * target/target.h (target_terminal_state): New scoped enum,
1852 factored out of ...
1853 (target_terminal::terminal_state): ... here.
1854 (target_terminal::inferior): Update comments.
1855 (target_terminal::restore_inferior): New.
1856 (target_terminal::is_inferior, target_terminal::is_ours)
1857 (target_terminal::is_ours_for_output): Adjust.
1858 (target_terminal::scoped_restore_terminal_state): Adjust to
1859 rename, and call restore_inferior() instead of inferior().
1860 (target_terminal::scoped_restore_terminal_state::m_state): Change
1861 type.
1862 (target_terminal::terminal_state): Rename to ...
1863 (target_terminal::m_terminal_state): ... this and change type.
1864
9c3a5d93
PA
18652018-01-30 Pedro Alves <palves@redhat.com>
1866
1867 * linux-nat.c (wait_for_signal): New function.
1868 (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
1869 directly.
1870 (async_terminal_is_ours)
1871 (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
1872 (linux_nat_add_target): Don't override
1873 to_terminal_inferior/to_terminal_ours.
1874
69ab5edb
SDJ
18752018-01-29 Sergio Durigan Junior <sergiodj@redhat.com>
1876
1877 * remote.c (remote_follow_fork): Don't call "detach_inferior".
1878
fc8e7e75
SM
18792018-01-28 Simon Marchi <simon.marchi@ericsson.com>
1880
1881 * dwarf2read.c (free_dwo_files): Add forward-declaration.
1882 (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
1883 dwarf2_per_objfile_free here.
1884 (dwarf2_per_objfile_free): Remove.
1885 (_initialize_dwarf2_read): Don't register
1886 dwarf2_per_objfile_free as a registry cleanup.
1887
b2a426e2
EZ
18882018-01-27 Eli Zaretskii <eliz@gnu.org>
1889
1890 Avoid compilation errors in MinGW native builds
1891
1892 The error is triggered by including python-internal.h, and the
1893 error message is:
1894
1895 In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
1896 from build-gnulib/import/math.h:27,
1897 from d:/usr/Python26/include/pyport.h:235,
1898 from d:/usr/Python26/include/Python.h:58,
1899 from python/python-internal.h:94,
1900 from python/py-arch.c:24:
1901 d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
1902 using ::hypot;
1903 ^~~~~
1904
1905 This happens because Python headers define 'hypot' to expand t
1906 '_hypot' in the Windows builds.
1907 * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
1908 'hypoth'. This avoids a compilation error.
1909
0bdd8eac
AH
19102018-01-26 Alan Hayward <alan.hayward@arm.com>
1911
1912 * MAINTAINERS (Write After Approval): Fix ordering.
1913
56ae9dc3
AH
19142018-01-26 Alan Hayward <alan.hayward@arm.com>
1915
1916 * MAINTAINERS (Write After Approval): Add Alan Hayward.
1917
7433498b
AM
19182018-01-26 Alan Modra <amodra@gmail.com>
1919
1920 * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
1921 (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
1922 Remove nop. Make const. Comment.
1923 (powerpc32_plt_stub_so_2): New.
1924 (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
1925 Correct count. Update uses.
1926 (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
1927 Move common code reading PLT entry word. Correct
1928 powerpc32_plt_stub PLT address calculation.
1929 * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
1930 (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
1931 (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
1932 (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
1933 (ppc64_standard_linkage8): Likewise.
1934 * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
1935 Correct insns description.
1936 * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
1937
0f59d5fc
PA
19382018-01-24 Pedro Alves <palves@redhat.com>
1939
1940 GCC PR libstdc++/83906
1941 * gdbtypes.c (operator==(const dynamic_prop &,
1942 const dynamic_prop &)): New.
1943 (operator==(const range_bounds &, const range_bounds &)): New.
1944 (check_types_equal): Use them instead of memcmp.
1945 * gdbtypes.h (operator==(const dynamic_prop &,
1946 const dynamic_prop &)): Declare.
1947 (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
1948 (operator==(const range_bounds &, const range_bounds &)): Declare.
1949 (operator!=(const range_bounds &, const range_bounds &)): Declare.
1950
ef8914a4
PR
19512018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
1952
1953 * s390-linux-tdep.c (s390_record_address_mask)
1954 (s390_record_calc_disp_common, s390_record_calc_disp)
1955 (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
1956 (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
1957 (s390_process_record): Move to s390-tdep.c.
1958 (s390_linux_init_abi_any): Adjust.
1959 * s390-tdep.c (s390_record_address_mask)
1960 (s390_record_calc_disp_common, s390_record_calc_disp)
1961 (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
1962 (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
1963 (s390_process_record): Moved from s390-linux-tdep.c
1964 (s390_gdbarch_init): Adjust.
1965
d6e58945
PR
19662018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
1967
1968 * s390-linux-nat.c (s390-tdep.h): New include.
1969 * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
1970 (HFILES_NO_SRCDIR): Add s390-tdep.h.
1971 (ALLDEPFILES): Add s390-tdep.c.
1972 * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
1973 * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
1974 * s390-tdep.h: ...this. New file.
1975 * s390-linux-tdep.c (s390-tdep.h): New include.
1976 (_initialize_s390_tdep): Rename to...
1977 (_initialize_s390_linux_tdep): ...this and adjust.
1978 (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
1979 (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
1980 s390-tdep.h.
1981 (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
1982 (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
1983 (s390_is_partial_instruction, s390_software_single_step)
1984 (is_non_branch_ril, s390_displaced_step_copy_insn)
1985 (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
1986 (s390_prologue_data, s390_addr, s390_store, s390_load)
1987 (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
1988 (s390_register_call_saved, s390_guess_tracepoint_registers)
1989 (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
1990 (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
1991 (s390_pseudo_register_name, s390_pseudo_register_type)
1992 (s390_pseudo_register_read, s390_pseudo_register_write)
1993 (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
1994 (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
1995 (s390_addr_bits_remove, s390_address_class_type_flags)
1996 (s390_address_class_type_flags_to_name)
1997 (s390_address_class_name_to_type_flags, s390_effective_inner_type)
1998 (s390_function_arg_float, s390_function_arg_vector)
1999 (is_power_of_two, s390_function_arg_integer, s390_arg_state)
2000 (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
2001 (s390_frame_align, s390_register_return_value, s390_return_value)
2002 (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
2003 (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
2004 (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
2005 (s390_trad_frame_prev_register, s390_unwind_cache)
2006 (s390_prologue_frame_unwind_cache)
2007 (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
2008 (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
2009 (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
2010 (s390_stub_frame_this_id, s390_stub_frame_prev_register)
2011 (s390_stub_frame_sniffer, s390_stub_frame_unwind)
2012 (s390_frame_base_address, s390_local_base_address)
2013 (s390_frame_base, s390_gcc_target_options)
2014 (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
2015 (s390_validate_reg_range, s390_tdesc_valid)
2016 (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
2017 * s390-tdep.c: ...this. New file.
2018
9c0b896e
PR
20192018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
2020
2021 * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
2022 (s390_process_record, s390_gdbarch_tdep_alloc)
2023 (s390_linux_init_abi_any): Use/set new hook.
2024
7042632b
PR
20252018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
2026
2027 * s390-linux-tdep.c (osabi.h): New include.
2028 (s390_linux_init_abi_31, s390_linux_init_abi_64)
2029 (s390_linux_init_abi_any): New functions.
2030 (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
2031
650f5e13
PR
20322018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
2033
2034 * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
2035 tdesc_has_registers check
2036
47c9317e
PR
20372018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
2038
2039 * s390-linux-tdep.c (s390_tdesc_valid): New function.
2040 (s390_validate_reg_range): New macro.
2041 (s390_gdbarch_init): Adjust.
2042
095085d8
PR
20432018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
2044
2045 * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
2046 (s390_gdbarch_tdep_alloc): Adjust.
2047 (s390_gdbarch_init): Adjust.
2048
ab9bcc67
PR
20492018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
2050
2051 * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
2052 <have_tdb>: Change type to bool.
2053 (s390_gdbarch_tdep_alloc): Adjust.
2054 (s390_gdbarch_init): Adjust.
2055
21f6f5ff
PR
20562018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
2057
2058 * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
2059 (gdbarch_tdep) <have_upper, have_vx>: New fields.
2060 (s390_gdbarch_tdep_alloc): New function.
2061 (s390_gdbarch_init): Allocate tdep at start and use its fields
2062 instead of separate variables.
2063
0eb97953
PR
20642018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
2065
2066 * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
2067 when looking for cached gdbarch and add comment for remaining.
2068
5c319bb2
PA
20692018-01-22 Pedro Alves <palves@redhat.com>
2070 Sergio Durigan Junior <sergiodj@redhat.com>
2071
2072 * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
2073 case.
2074
d65ce302
MR
20752018-01-22 Maciej W. Rozycki <macro@mips.com>
2076
2077 * MAINTAINERS: Update my company e-mail address.
2078
ec7a5fcb
YQ
20792018-01-22 Yao Qi <yao.qi@linaro.org>
2080
2081 * regcache.c (cooked_write_test): New function.
2082 (_initialize_regcache): Register the test.
2083
11f57cb6
YQ
20842018-01-22 Yao Qi <yao.qi@linaro.org>
2085
2086 * ia64-tdep.c (ia64_pseudo_register_read): Call
2087 regcache->cooked_read instead of regcache_cooked_read_unsigned.
2088 * m32c-tdep.c (m32c_cat_read): Likewise.
2089 (m32c_r3r2r1r0_read): Likewise.
2090 * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
2091 * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
2092
03f50fc8
YQ
20932018-01-22 Yao Qi <yao.qi@linaro.org>
2094
2095 * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
2096 method raw_read instead of regcache_raw_read.
2097 * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
2098 * arm-tdep.c (arm_neon_quad_read): Likewise.
2099 * avr-tdep.c (avr_pseudo_register_read): Likewise.
2100 * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
2101 * frv-tdep.c (frv_pseudo_register_read): Likewise.
2102 * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
2103 * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
2104 (i386_pseudo_register_read_into_value): Likewise.
2105 * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
2106 * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
2107 * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
2108 * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
2109 * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
2110 * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
2111 * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
2112 * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
2113 * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
2114
dc711524
YQ
21152018-01-22 Yao Qi <yao.qi@linaro.org>
2116
2117 * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
2118 * configure.tgt: Remove target mt.
2119 * mt-tdep.c: Remove.
2120 * regcache.c (cooked_read_test): Remove the check for mt.
2121
3f5a868b
YQ
21222018-01-22 Yao Qi <yao.qi@linaro.org>
2123
2124 * jit.c (jit_frame_prev_register): Call regcache::cooked_read
2125 instead of gdbarch_pseudo_register_read_value.
2126
de4cb04a
JB
21272018-01-22 Joel Brobecker <brobecker@adacore.com>
2128
2129 * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
2130 language is Ada.
2131
a9e40818
JB
21322018-01-22 Joel Brobecker <brobecker@adacore.com>
2133
2134 * linespec.c (create_sals_line_offset): Remove code that preserved
2135 the symtab_and_line's line number.
2136
e707fc44
AB
21372018-01-21 Andrew Burgess <andrew.burgess@embecosm.com>
2138
2139 * varobj.c (varobj_create): Don't set valid_block when creating a
2140 floating varobj.
2141
03d0bf7b
AB
21422018-01-21 Andrew Burgess <andrew.burgess@embecosm.com>
2143
2144 * varobj.c (varobj_create): Remove out of date comment.
2145
ae451627
AB
21462018-01-21 Andrew Burgess <andrew.burgess@embecosm.com>
2147
2148 PR mi/20395
2149 * ada-exp.y (write_var_from_sym): Pass extra parameter when
2150 updating innermost block.
2151 * parse.c (innermost_block_tracker::update): Take extra type
2152 parameter, and check types match before updating innermost block.
2153 (write_dollar_variable): Update innermost block for registers.
2154 * parser-defs.h (enum innermost_block_tracker_type): New enum.
2155 (innermost_block_tracker::innermost_block_tracker): Initialise
2156 m_types member.
2157 (innermost_block_tracker::reset): Take type parameter.
2158 (innermost_block_tracker::update): Take type parameter, and pass
2159 type through as needed.
2160 (innermost_block_tracker::m_types): New member.
2161 * varobj.c (varobj_create): Pass type when reseting innermost
2162 block.
2163
aee1fcdf
AB
21642018-01-21 Andrew Burgess <andrew.burgess@embecosm.com>
2165
2166 * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
2167 * ada-lang.c (resolve_subexp): Likewise.
2168 * breakpoint.c (set_breakpoint_condition) Likewise.
2169 (watch_command_1) Likewise.
2170 * c-exp.y (variable): Likewise.
2171 * d-exp.y (PrimaryExpression): Likewise.
2172 * f-exp.y (variable): Likewise.
2173 * go-exp.y (variable): Likewise.
2174 * m2-exp.y (variable): Likewise.
2175 * objfiles.c (objfile::~objfile): Likewise.
2176 * p-exp.y (variable): Likewise.
2177 * parse.c (innermost_block): Change type.
2178 * parser-defs.h (class innermost_block_tracker): New.
2179 (innermost_block): Change to innermost_block_tracker.
2180 * printcmd.c (display_command): Switch to innermost_block API.
2181 (do_one_display): Likewise.
2182 * rust-exp.y (do_one_display): Likewise.
2183 * symfile.c (clear_symtab_users): Likewise.
2184 * varobj.c (varobj_create): Switch to innermost_block API, replace
2185 use of innermost_block with block stored on varobj object.
2186
396af9a1
AB
21872018-01-21 Andrew Burgess <andrew.burgess@embecosm.com>
2188
2189 * expression.h (innermost_block): Remove declaration.
2190 * varobj.c: Add 'parser-defs.h' include.
2191
fcfcc376
TT
21922018-01-19 Tom Tromey <tom@tromey.com>
2193
2194 * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
2195 symbols in the static and global blocks.
2196
5a6c3296
JC
21972018-01-19 James Clarke <jrtc27@jrtc27.com>
2198
2199 * nat/linux-ptrace.c: Remove unnecessary reinclusion of
2200 gdb_ptrace.h, and move including gdb_wait.h ...
2201 * nat/linux-ptrace.h: ... to here.
2202
bc09b0c1
SM
22032018-01-19 Simon Marchi <simon.marchi@ericsson.com>
2204
2205 * inf-ptrace.c (inf_ptrace_detach): Adjust call to
2206 inf_ptrace_detach_success.
2207 (inf_ptrace_detach_success): Add inferior parameter, use it
2208 instead of inferior_ptid, pass it to detach_inferior.
2209 * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
2210 parameter.
2211 * inferior.c (detach_inferior): Add overload that takes an
2212 inferior object.
2213 * inferior.h (detach_inferior): Likewise.
2214 * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
2215 use inferior_ptid, adjust call to inf_ptrace_detach_success.
2216 * linux-thread-db.c (thread_db_detach): Use inf parameter.
2217
6e1e1966
SM
22182018-01-19 Simon Marchi <simon.marchi@ericsson.com>
2219
2220 * target.h (struct target_ops) <to_detach>: Add inferior
2221 parameter.
2222 (target_detach): Likewise.
2223 * target.c (dispose_inferior): Pass inferior down.
2224 (target_detach): Pass inferior down. Assert that it is equal to
2225 the current inferior.
2226 * aix-thread.c (aix_thread_detach): Pass inferior down.
2227 * corefile.c (core_file_command): Pass current_inferior() down.
2228 * corelow.c (core_detach): Add inferior parameter.
2229 * darwin-nat.c (darwin_detach): Likewise.
2230 * gnu-nat.c (gnu_detach): Likewise.
2231 * inf-ptrace.c (inf_ptrace_detach): Likewise.
2232 * infcmd.c (detach_command): Pass current_inferior() down to
2233 target_detach.
2234 * infrun.c (follow_fork_inferior): Pass parent_inf to
2235 target_detach.
2236 (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
2237 target_detach.
2238 * linux-nat.c (linux_nat_detach): Add inferior parameter.
2239 * linux-thread-db.c (thread_db_detach): Likewise.
2240 * nto-procfs.c (procfs_detach): Likewise.
2241 * procfs.c (procfs_detach): Likewise.
2242 * record.c (record_detach): Likewise.
2243 * record.h (struct inferior): Forward-declare.
2244 (record_detach): Add inferior parameter.
2245 * remote-sim.c (gdbsim_detach): Likewise.
2246 * remote.c (remote_detach_1): Likewise.
2247 (remote_detach): Likewise.
2248 (extended_remote_detach): Likewise.
2249 * sol-thread.c (sol_thread_detach): Likewise.
2250 * target-debug.h (target_debug_print_inferior_p): New macro.
2251 * target-delegates.c: Re-generate.
2252 * top.c (kill_or_detach): Pass inferior down to target_detach.
2253 * windows-nat.c (windows_detach): Add inferior parameter.
2254
6bd6f3b6
SM
22552018-01-19 Simon Marchi <simon.marchi@ericsson.com>
2256
2257 * target.h (struct target_ops) <to_detach>: Remove args
2258 parameter.
2259 (target_detach): Likewise.
2260 * target.c (dispose_inferior): Adjust.
2261 (target_detach): Remove args parameter, adjust.
2262 * aix-thread.c (aix_thread_detach): Adjust.
2263 * corefile.c (core_file_command): Adjust.
2264 * corelow.c (core_detach): Adjust.
2265 * darwin-nat.c (darwin_detach): Adjust.
2266 * gnu-nat.c (gnu_detach): Adjust.
2267 * inf-ptrace.c (inf_ptrace_detach): Adjust.
2268 * infcmd.c (detach_command): Adjust
2269 * infrun.c (follow_fork_inferior): Adjust.
2270 (handle_vfork_child_exec_or_exit): Adjust.
2271 * linux-fork.c (linux_fork_detach): Remove args parameter.
2272 * linux-fork.h (linux_fork_detach): Likewise.
2273 * linux-nat.c (linux_nat_detach): Likewise, and adjust.
2274 * linux-thread-db.c (thread_db_detach): Likewise.
2275 * nto-procfs.c (procfs_detach): Likewise.
2276 * procfs.c (procfs_detach): Likewise.
2277 (do_detach): Remove signo parameter.
2278 * record.c (record_detach): Remove args parameter.
2279 * record.h (record_detach): Likewise.
2280 * remote-sim.c (gdbsim_detach): Likewise.
2281 * remote.c (remote_detach_1): Likewise.
2282 (remote_detach): Likewise.
2283 (extended_remote_detach): Likewise.
2284 * sol-thread.c (sol_thread_detach): Likewise.
2285 * target-delegates.c: Re-generate.
2286 * top.c (struct qt_args) <args>: Remove field.
2287 (kill_or_detach): Don't pass args.
2288 (quit_force): Don't set args.
2289 * windows-nat.c (windows_detach): Remove args parameter.
2290
88af8ea8
YQ
22912018-01-19 Yao Qi <yao.qi@linaro.org>
2292
2293 * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
2294 (arm_linux_init_abi): Install it.
2295
dea445b9
YQ
22962018-01-19 Yao Qi <yao.qi@linaro.org>
2297
2298 * osabi.c (gdb_osabi_names): Extend the regexp for
2299 arm-linux-gnueabihf.
2300
4a17f768
YQ
23012018-01-18 Yao Qi <yao.qi@linaro.org>
2302
2303 * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
2304 m_abbrevs.
2305 (abbrev_table::add_abbrev): Update.
2306 (abbrev_table::lookup_abbrev): Update.
2307
d679c21a
YQ
23082018-01-18 Yao Qi <yao.qi@linaro.org>
2309
2310 * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
2311
7d937cad
SDJ
23122018-01-17 Sergio Durigan Junior <sergiodj@redhat.com>
2313
2314 * compile/compile.c (compile_to_object): Convert "triplet_rx"
2315 to "std::string".
2316
9e14690d
TT
23172018-01-17 Tom Tromey <tom@tromey.com>
2318
2319 * dwarf2read.c (symbolp): Remove typedef. Don't instantiate VEC.
2320
50a82047
TT
23212018-01-17 Tom Tromey <tom@tromey.com>
2322
2323 * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
2324 * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
2325 (create_array_type_with_stride): Update.
2326 * dwarf2read.c (set_die_type): Update.
2327
c89b44cd
TT
23282018-01-17 Tom Tromey <tom@tromey.com>
2329
2330 * dwarf2read.c (delayed_method_info): Remove typedef.
2331 (dwarf2_cu::method_info): Now a std::vector.
2332 (add_to_method_list): Update.
2333 (free_delayed_list): Remove.
2334 (compute_delayed_physnames): Update.
2335 (process_full_comp_unit, process_full_type_unit): Clear the method
2336 list. Remove cleanups.
2337 (psymtab_include_file_name): Add name_holder parameter. Use
2338 unique_xmalloc_ptr.
2339 (dwarf_decode_lines): Update.
2340
fcd3b13d
SM
23412018-01-17 Tom Tromey <tom@tromey.com>
2342 Simon Marchi <simon.marchi@ericsson.com>
2343
2344 * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
2345 (dwarf2_per_objfile::free_cached_comp_units)
2346 (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
2347 (init_cutu_and_read_dies_no_follow): Update.
2348 (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
2349 (dwarf2_cu::~dwarf2_cu): New.
2350 (free_heap_comp_unit, free_stack_comp_unit): Remove.
2351 (age_cached_comp_units, free_one_cached_comp_unit): Update.
2352
685af9cd
TT
23532018-01-17 Tom Tromey <tom@tromey.com>
2354 Simon Marchi <simon.marchi@ericsson.com>
2355
2356 * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
2357 (struct die_reader_specs) <abbrev_table>: New member.
2358 (struct abbrev_table): Add constructor.
2359 <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
2360 <abbrev_obstack>: Now an auto_obstack.
2361 (abbrev_table_up): New typedef.
2362 (init_cu_die_reader): Add abbrev_table parameter.
2363 (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
2364 Add result_dwo_abbrev_table.
2365 (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
2366 (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
2367 Update.
2368 (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
2369 parameter.
2370 (skip_children): Update.
2371 (abbrev_table::alloc_abbrev): Rename from
2372 abbrev_table_alloc_abbrev.
2373 (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
2374 (abbrev_table::lookup_abbrev): Rename from
2375 abbrev_table_lookup_abbrev.
2376 (abbrev_table_read_table): Return abbrev_table_up.
2377 (abbrev_table_free, abbrev_table_free_cleanup)
2378 (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
2379 (load_partial_dies): Update.
2380
5e2db402
TT
23812018-01-17 Tom Tromey <tom@tromey.com>
2382
2383 * dwarf2read.c (dwarf2_compute_name): Update comment.
2384 (read_func_scope, read_variable): Update.
2385 (new_symbol): Remove.
2386 (new_symbol_full): Rename to new_symbol.
2387
ee7f689e 23882018-01-17 Mike Gulick <mgulick@mathworks.com>
41667530
MG
2389
2390 PR gdb/16577
2391 * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
2392 a warning instead of throwing an error, set section size to 0 and return
2393 NULL.
2394 * gdb_bfd.h (gdb_bfd_map_section): Update description.
2395
4d9b86e1
SM
23962018-01-17 Simon Marchi <simon.marchi@ericsson.com>
2397
2398 * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
2399 std::string.
2400 (linux_ptrace_attach_fail_reason_string): Likewise.
2401 * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
2402 Likewise.
2403 (linux_ptrace_attach_fail_reason_string): Likewise.
2404 * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
2405
a7b2d0fb
SM
24062018-01-17 Simon Marchi <simon.marchi@ericsson.com>
2407
2408 * linux-nat.c (linux_nat_attach): Remove xstrdup.
2409
f517c180
EA
24102018-01-17 Eldar Abusalimov <eldar.abusalimov@jetbrains.com>
2411
2412 PR gdb/21559
2413 * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
2414 checking for fs_base/gs_base fields in struct user_regs_struct.
2415 * configure: Regenerate.
2416
7045b1ca
YQ
24172018-01-17 Yao Qi <yao.qi@linaro.org>
2418
2419 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
2420 function.
2421 (aarch64_linux_init_abi): Install it to gdbarch hook
2422 gcc_target_options.
2423
db422fb2
PA
24242018-01-15 Pedro Alves <palves@redhat.com>
2425
2426 * common/signals-state-save-restore.c
2427 (save_original_signals_state): Fix typos.
2428
ba643918
SDJ
24292017-01-12 Tom Tromey <tom@tromey.com>
2430 Sergio Durigan Junior <sergiodj@redhat.com>
2431
2432 * Makefile.in (install-only): Install gdb-add-index.
2433
906b4aac
JB
24342018-01-12 John Baldwin <jhb@FreeBSD.org>
2435
2436 * fbsd-tdep.c (KVE_PROTECTION): Correct value.
2437
bdf2a94a
AA
24382018-01-12 Andreas Arnez <arnez@linux.vnet.ibm.com>
2439
2440 * infrun.c (keep_going_pass_signal): Clear step-over info when
2441 insert_breakpoints fails.
2442
71d378ae
PA
24432018-01-11 Pedro Alves <palves@redhat.com>
2444
2445 PR gdb/22583
2446 * infrun.c (resume): Rename to ...
2447 (resume_1): ... this.
2448 (resume): Reimplement as wrapper around resume_1.
2449
3cada740
PA
24502018-01-11 Pedro Alves <palves@redhat.com>
2451
2452 PR remote/22597
2453 * remote.c (remote_parse_stop_reply): Default to the last-set
2454 general thread instead of to 'magic_null_ptid'.
2455
618daa93
PA
24562018-01-10 Pedro Alves <palves@redhat.com>
2457
2458 * language.h (language_get_symbol_name_matcher): Rename ...
2459 (get_symbol_name_matcher): ... this.
2460 * language.c (language_get_symbol_name_matcher): Ditto.
2461 * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
2462 callers adjusted.
2463
c63d3e8d
PA
24642018-01-10 Pedro Alves <palves@redhat.com>
2465
2466 PR gdb/22670
2467 * dwarf2read.c
2468 (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
2469 Adjust to use language_get_symbol_name_matcher instead of
2470 language_defn::la_get_symbol_name_matcher.
2471 * language.c (language_get_symbol_name_matcher): If in Ada mode
2472 and the lookup name is a verbatim match, return Ada's matcher.
2473 * language.h (language_get_symbol_name_matcher): Adjust comment.
2474 (ada_lookup_name_info::verbatim_p):: New method.
2475
d4c2a405
PA
24762018-01-10 Pedro Alves <palves@redhat.com>
2477
2478 PR gdb/22670
2479 * ada-lang.c (ada_collect_symbol_completion_matches): If the
2480 minsym's language is language_auto or language_cplus, pass down
2481 language_ada instead.
2482 * symtab.c (compare_symbol_name): Don't frob symbol language here.
2483
8825213e
PA
24842018-01-10 Pedro Alves <palves@redhat.com>
2485
2486 PR gdb/22670
2487 * minsyms.c (linkage_name_str): New function.
2488 (iterate_over_minimal_symbols): Use it.
2489
2d97a5d9
JB
24902018-01-09 John Baldwin <jhb@FreeBSD.org>
2491
2492 * NEWS: Document that 'info proc' now works on FreeBSD.
2493
92fce24d
JB
24942018-01-09 John Baldwin <jhb@FreeBSD.org>
2495
2496 * configure.ac: Check for kinfo_getfile in libutil.
2497 * configure: Regenerate.
2498 * config.in: Regenerate.
2499 * fbsd-nat.c: Include "fbsd-tdep.h".
2500 (fbsd_fetch_cmdline): New.
2501 (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
2502 rather than calling error.
2503 (fbsd_info_proc): New.
2504 (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
2505 (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
2506 (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
2507
262f62f5
JB
25082018-01-09 John Baldwin <jhb@FreeBSD.org>
2509
2510 * fbsd-nat.c (struct free_deleter): Remove.
2511 (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
2512
b999e203
JB
25132018-01-09 John Baldwin <jhb@FreeBSD.org>
2514
2515 * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
2516 NULL for an empty pathname.
2517
d2176225
JB
25182018-01-09 John Baldwin <jhb@FreeBSD.org>
2519
2520 * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
2521 (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
2522 (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
2523 (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
2524 (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
2525 (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
2526 (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
2527 (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
2528 (kinfo_proc_layout_32, kinfo_proc_layout_i386)
2529 (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
2530 (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
2531 (fbsd_core_fetch_timeval, fbsd_print_sigset)
2532 (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
2533 (fbsd_init_abi): Install gdbarch "core_info_proc" method.
2534 * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
2535
9c4ac400
ST
25362018-01-08 Samuel Thibault <samuel.thibault@ens-lyon.org>
2537
2538 * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
2539 (gnu_xfer_auxv): New function.
2540 (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
2541 TARGET_OBJECT_AUXV.
2542
1e5ded6c
YQ
25432018-01-08 Yao Qi <yao.qi@linaro.org>
2544 Simon Marchi <simon.marchi@ericsson.com>
2545
2546 * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
2547 common/selftest.c.
2548 (COMMON_OBS): Remove selftest.o.
2549 * configure.ac: Append selftest-arch.c and common/selftest.c to
2550 CONFIG_SRCS. Append selftest-arch.o and selftest.o to COMMON_OBS.
2551 * configure: Re-generated.
2552 * maint.c (maintenance_selftest): Wrap selftests::run_tests with
2553 GDB_SELF_TEST.
2554 (maintenance_info_selftests): Likewise.
2555
04bafb1e
XR
25562018-01-08 Xavier Roirand <roirand@adacore.com>
2557
2558 * ada-valprint.c (val_print_packed_array_elements): Use
2559 proper number of elements when printing an array indexed
2560 by an enumeration type.
2561
518817b3
SM
25622018-01-07 Simon Marchi <simon.marchi@polymtl.ca>
2563
2564 * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
2565 (dw2_get_file_names_reader): Adjust.
2566 (lookup_dwo_signatured_type): Adjust.
2567 (lookup_dwp_signatured_type): Adjust.
2568 (lookup_signatured_type): Adjust.
2569 (create_type_unit_group): Adjust.
2570 (get_type_unit_group): Adjust.
2571 (process_psymtab_comp_unit_reader): Adjust.
2572 (build_type_psymtabs_reader): Adjust.
2573 (scan_partial_symbols): Adjust.
2574 (add_partial_symbol): Adjust.
2575 (add_partial_subprogram): Adjust.
2576 (peek_die_abbrev): Adjust.
2577 (fixup_go_packaging): Adjust.
2578 (process_imported_unit_die): Adjust.
2579 (dwarf2_compute_name): Adjust.
2580 (dwarf2_physname): Adjust.
2581 (read_import_statement): Adjust.
2582 (handle_DW_AT_stmt_list): Adjust.
2583 (read_file_scope): Adjust.
2584 (read_func_scope): Adjust.
2585 (read_lexical_block_scope): Adjust.
2586 (read_call_site_scope): Adjust.
2587 (read_variable): Adjust.
2588 (dwarf2_rnglists_process): Adjust.
2589 (dwarf2_ranges_process): Adjust.
2590 (dwarf2_ranges_read): Adjust.
2591 (dwarf2_get_pc_bounds): Adjust.
2592 (dwarf2_record_block_ranges): Adjust.
2593 (dwarf2_add_field): Adjust.
2594 (dwarf2_add_member_fn): Adjust.
2595 (read_structure_type): Adjust.
2596 (process_structure_scope): Adjust.
2597 (read_enumeration_type): Adjust.
2598 (read_array_type): Adjust.
2599 (mark_common_block_symbol_computed): Adjust.
2600 (read_common_block): Adjust.
2601 (read_namespace_type): Adjust.
2602 (read_namespace): Adjust.
2603 (read_module_type): Adjust.
2604 (read_tag_pointer_type): Adjust.
2605 (read_tag_ptr_to_member_type): Adjust.
2606 (read_tag_string_type): Adjust.
2607 (read_subroutine_type): Adjust.
2608 (read_typedef): Adjust.
2609 (read_base_type): Adjust.
2610 (attr_to_dynamic_prop): Adjust.
2611 (read_subrange_type): Adjust.
2612 (read_unspecified_type): Adjust.
2613 (dwarf2_read_abbrevs): Adjust.
2614 (load_partial_dies): Adjust.
2615 (read_partial_die): Adjust.
2616 (find_partial_die): Adjust.
2617 (guess_partial_die_structure_name): Adjust.
2618 (fixup_partial_die): Adjust.
2619 (read_attribute_value): Adjust.
2620 (read_addr_index): Adjust.
2621 (read_addr_index_from_leb128): Adjust.
2622 (read_str_index): Adjust.
2623 (dwarf2_string_attr): Adjust.
2624 (get_debug_line_section): Adjust.
2625 (dwarf_decode_line_header): Adjust.
2626 (lnp_state_machine::check_line_address): Adjust.
2627 (dwarf_decode_lines_1): Adjust.
2628 (dwarf_decode_lines): Adjust.
2629 (dwarf2_start_symtab): Adjust.
2630 (var_decode_location): Adjust.
2631 (new_symbol_full): Adjust.
2632 (dwarf2_const_value_data): Adjust.
2633 (dwarf2_const_value_attr): Adjust.
2634 (dwarf2_const_value): Adjust.
2635 (die_type): Adjust.
2636 (die_containing_type): Adjust.
2637 (build_error_marker_type): Adjust.
2638 (lookup_die_type): Adjust.
2639 (guess_full_die_structure_name): Adjust.
2640 (anonymous_struct_prefix): Adjust.
2641 (determine_prefix): Adjust.
2642 (dwarf2_name): Adjust.
2643 (follow_die_ref_or_sig): Adjust.
2644 (follow_die_offset): Adjust.
2645 (follow_die_ref): Adjust.
2646 (follow_die_sig_1): Adjust.
2647 (follow_die_sig): Adjust.
2648 (get_signatured_type): Adjust.
2649 (get_DW_AT_signature_type): Adjust.
2650 (decode_locdesc): Adjust.
2651 (dwarf_decode_macros): Adjust.
2652 (cu_debug_loc_section): Adjust.
2653 (fill_in_loclist_baton): Adjust.
2654 (dwarf2_symbol_mark_computed): Adjust.
2655 (init_one_comp_unit): Don't assign
2656 dwarf2_cu::dwarf2_per_objfile.
2657 (set_die_type): Adjust.
2658
ed2dc618
SM
26592018-01-07 Simon Marchi <simon.marchi@ericsson.com>
2660
2661 * dwarf2read.c (struct mapped_debug_names): Add constructor.
2662 <dwarf2_per_objfile>: New field.
2663 (dwarf2_per_objfile): Remove global.
2664 (get_dwarf2_per_objfile): New function.
2665 (set_dwarf2_per_objfile): New function.
2666 (dwarf2_build_psymtabs_hard): Change objfile parameter to
2667 dwarf2_per_objfile.
2668 (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
2669 (read_abbrev_offset): Likewise.
2670 (read_indirect_string): Likewise.
2671 (read_indirect_line_string): Likewise.
2672 (read_indirect_string_at_offset): Likewise.
2673 (read_indirect_string_from_dwz): Likewise.
2674 (dwarf2_find_containing_comp_unit): Change objfile parameter to
2675 dwarf2_per_objfile.
2676 (age_cached_comp_units): Add dwarf2_per_objfile parameter.
2677 (create_all_comp_units): Change objfile parameter to
2678 dwarf2_per_objfile.
2679 (create_all_type_units): Likewise.
2680 (process_queue): Add dwarf2_per_objfile parameter.
2681 (read_and_check_comp_unit_head): Likewise.
2682 (lookup_dwo_unit_in_dwp): Likewise.
2683 (get_dwp_file): Likewise.
2684 (process_cu_includes): Likewise.
2685 (struct free_dwo_file_cleanup_data): New struct.
2686 (dwarf2_has_info): Use get_dwarf2_per_objfile and
2687 set_dwarf2_per_objfile.
2688 (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
2689 (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
2690 context, adjust calls.
2691 (dw2_instantiate_symtab): Likewise.
2692 (dw2_get_cutu): Add dwarf2_per_objfile parameter.
2693 (dw2_get_cu): Likewise.
2694 (create_cu_from_index_list): Change objfile parameter to
2695 dwarf2_per_objfile.
2696 (create_cus_from_index_list): Get dwarf2_per_objfile from
2697 context, adjust calls.
2698 (create_cus_from_index): Likewise.
2699 (create_signatured_type_table_from_index): Change objfile
2700 parameter to dwarf2_per_objfile.
2701 (create_signatured_type_table_from_debug_names): Change objfile
2702 parameter to dwarf2_per_objfile.
2703 (create_addrmap_from_index): Likewise.
2704 (create_addrmap_from_aranges): Likewise.
2705 (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
2706 (dw2_setup): Remove.
2707 (dw2_get_file_names_reader): Get dwarf2_per_objfile from
2708 context.
2709 (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
2710 get_dwarf2_per_objfile.
2711 (dw2_forget_cached_source_info): Likewise.
2712 (dw2_map_symtabs_matching_filename): Likewise.
2713 (struct dw2_symtab_iterator) <index>: Remove.
2714 <dwarf2_per_objfile>: New field.
2715 (dw2_symtab_iter_init): Replace index parameter with
2716 dwarf2_per_objfile.
2717 (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
2718 (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
2719 (dw2_print_stats): Likewise.
2720 (dw2_dump): Likewise.
2721 (dw2_expand_symtabs_for_function): Likewise.
2722 (dw2_expand_all_symtabs): Likewise.
2723 (dw2_expand_symtabs_with_fullname): Likewise.
2724 (dw2_expand_marked_cus): Replace index and objfile parameters
2725 with dwarf2_per_objfile.
2726 (dw_expand_symtabs_matching_file_matcher): Add
2727 dwarf2_per_objfile parameter and adjust calls.
2728 (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
2729 adjust calls.
2730 (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
2731 (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
2732 adjust calls.
2733 (create_cus_from_debug_names_list): Replace objfile parameter
2734 with dwarf2_per_objfile and adjust calls.
2735 (create_cus_from_debug_names): Likewise.
2736 (dwarf2_read_debug_names): Likewise.
2737 (mapped_debug_names::namei_to_name): Adjust call.
2738 (dw2_debug_names_iterator::next): Likewise.
2739 (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
2740 (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
2741 (dw2_debug_names_dump): Likewise.
2742 (dw2_debug_names_expand_symtabs_for_function): Likewise.
2743 (dw2_debug_names_expand_symtabs_matching): Likewise.
2744 (dwarf2_initialize_objfile): Likewise.
2745 (dwarf2_build_psymtabs): Likewise.
2746 (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
2747 this_cu.
2748 (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
2749 (read_and_check_comp_unit_head): Likewise.
2750 (read_abbrev_offset): Likewise.
2751 (create_debug_type_hash_table): Likewise.
2752 (create_debug_types_hash_table): Likewise.
2753 (create_all_type_units): Replace objfile parameter with
2754 dwarf2_per_objfile.
2755 (add_type_unit): Add dwarf2_per_objfile parameter.
2756 (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
2757 with dwarf2_per_objfile.
2758 (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
2759 (lookup_dwp_signatured_type): Likewise.
2760 (lookup_signatured_type): Likewise.
2761 (read_cutu_die_from_dwo): Likewise.
2762 (init_tu_and_read_dwo_dies): Likewise.
2763 (init_cutu_and_read_dies): Likewise.
2764 (init_cutu_and_read_dies_no_follow): Likewise.
2765 (allocate_type_unit_groups_table): Add objfile parameter.
2766 (create_type_unit_group): Use dwarf2_per_objfile from cu.
2767 (get_type_unit_group): Likewise.
2768 (process_psymtab_comp_unit): Update call.
2769 (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
2770 (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
2771 (print_tu_stats): Likewise.
2772 (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
2773 in void* parameter.
2774 (build_type_psymtabs): Change objfile parameter to
2775 dwarf2_per_objfile.
2776 (process_skeletonless_type_unit): Use dwarf2_per_objfile
2777 passed in void* parameter.
2778 (process_skeletonless_type_units): Change objfile parameter to
2779 dwarf2_per_objfile.
2780 (set_partial_user): Likewise.
2781 (dwarf2_build_psymtabs_hard): Likewise.
2782 (read_comp_units_from_section): Likewise.
2783 (create_all_comp_units): Likewise.
2784 (scan_partial_symbols): Update calls.
2785 (add_partial_symbol): Likewise.
2786 (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
2787 (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
2788 (process_queue): Add dwarf2_per_objfile parameter.
2789 (get_compunit_symtab): Use dwarf2_per_objfile from cu.
2790 (compute_compunit_symtab_includes): Likewise.
2791 (process_cu_includes): Add dwarf2_per_objfile parameter.
2792 (process_full_comp_unit): Use dwarf2_per_objfile from cu.
2793 (process_full_type_unit): Likewise.
2794 (process_imported_unit_die): Update call.
2795 (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
2796 (read_file_scope): Likewise.
2797 (allocate_dwo_file_hash_table): Add objfile parameter.
2798 (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
2799 (create_cus_hash_table): Likewise.
2800 (create_dwp_hash_table): Likewise.
2801 (create_dwo_unit_in_dwp_v1): Likewise.
2802 (create_dwp_v2_section): Likewise.
2803 (create_dwo_unit_in_dwp_v2): Likewise.
2804 (lookup_dwo_unit_in_dwp): Likewise.
2805 (try_open_dwop_file): Likewise.
2806 (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
2807 (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
2808 cleanup to include a reference to dwarf2_per_objfile.
2809 (open_dwp_file): Add dwarf2_per_objfile parameter.
2810 (open_and_init_dwp_file): Likewise.
2811 (get_dwp_file): Likewise.
2812 (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
2813 (queue_and_load_all_dwo_tus): Update call.
2814 (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
2815 data.
2816 (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
2817 (dwarf2_ranges_process): Likewise.
2818 (dwarf2_get_pc_bounds): Likewise.
2819 (mark_common_block_symbol_computed): Likewise.
2820 (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
2821 (dwarf2_read_abbrevs): Update call.
2822 (read_partial_die): Use dwarf2_per_objfile from cu.
2823 (find_partial_die): Likewise.
2824 (fixup_partial_die): Likewise.
2825 (read_attribute_value): Likewise.
2826 (read_indirect_string_at_offset_from): Add objfile parameter.
2827 (read_indirect_string_at_offset): Add dwarf2_per_objfile
2828 parameter.
2829 (read_indirect_string_from_dwz): Add objfile parameter.
2830 (read_indirect_string): Add objfile parameter.
2831 (read_addr_index_1): Add dwarf2_per_objfile parameter.
2832 (read_addr_index): Use dwarf2_per_objfile from cu.
2833 (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
2834 call dw2_setup.
2835 (read_str_index): Use dwarf2_per_objfile from cu.
2836 (get_debug_line_section): Likewise.
2837 (read_formatted_entries): Add dwarf2_per_objfile parameter.
2838 (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
2839 (new_symbol_full): Use dwarf2_per_objfile from cu.
2840 (build_error_marker_type): Likewise.
2841 (lookup_die_type): Likewise.
2842 (determine_prefix): Likewise.
2843 (follow_die_offset): Likewise.
2844 (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
2845 (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
2846 (dwarf2_fetch_die_type_sect_off): Likewise.
2847 (dwarf2_get_die_type): Likewise.
2848 (follow_die_sig_1): Use dwarf2_per_objfile from cu.
2849 (get_signatured_type): Likewise.
2850 (get_DW_AT_signature_type): Likewise.
2851 (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
2852 (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
2853 (cu_debug_loc_section): Likewise.
2854 (fill_in_loclist_baton): Likewise.
2855 (dwarf2_symbol_mark_computed): Likewise.
2856 (dwarf2_find_containing_comp_unit): Change objfile parameter to
2857 dwarf2_per_objfile.
2858 (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
2859 parameter.
2860 (age_cached_comp_units): Add dwarf2_per_objfile parameter.
2861 (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
2862 (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
2863 (set_die_type): Use dwarf2_free_objfile from cu.
2864 (get_die_type_at_offset): Likewise.
2865 (dwarf2_per_objfile_free): Don't assign global variable.
2866 (debug_names) <constructor>: Add dwarf2_per_objfile
2867 parameter, update m_debugstrlookup construction.
2868 (debug_names::debug_str_lookup): Add dwarf2_per_objfile
2869 parameter.
2870 <m_dwarf2_per_objfile>: New field.
2871 <lookup>: Use m_dwarf2_per_objfile.
2872 (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
2873 (psyms_seen_size): Likewise.
2874 (write_gdbindex): Replace objfile parameter with
2875 dwarf2_per_objfile.
2876 (write_debug_names): Likewise.
2877 (write_psymtabs_to_index): Likewise.
2878 (save_gdb_index_command): Use get_dwarf2_per_objfile, update
2879 calls.
2880
e3b94546
SM
28812018-01-07 Simon Marchi <simon.marchi@ericsson.com>
2882
2883 * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
2884 <dwarf2_per_objfile>: New field.
2885 (struct dwarf2_per_cu_data) <objfile>: Remove.
2886 <dwarf2_per_objfile>: New field.
2887 (create_cu_from_index_list): Assign dwarf2_per_objfile instead
2888 of objfile.
2889 (create_signatured_type_table_from_index): Likewise.
2890 (create_debug_type_hash_table): Likewise.
2891 (fill_in_sig_entry_from_dwo_entry): Likewise.
2892 (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
2893 (create_type_unit_group): Assign dwarf2_per_objfile instead of
2894 objfile.
2895 (create_partial_symtab): Access objfile through
2896 dwarf2_per_objfile.
2897 (process_psymtab_comp_unit_reader): Likewise.
2898 (read_comp_units_from_section): Likewise.
2899 (scan_partial_symbols): Likewise.
2900 (add_partial_symbol): Likewise.
2901 (add_partial_subprogram): Likewise.
2902 (peek_die_abbrev): Likewise.
2903 (fixup_go_packaging): Likewise.
2904 (process_full_comp_unit): Likewise.
2905 (process_full_type_unit): Likewise.
2906 (process_imported_unit_die): Likewise.
2907 (dwarf2_compute_name): Likewise.
2908 (dwarf2_physname): Likewise.
2909 (read_import_statement): Likewise.
2910 (create_cus_hash_table): Assign dwarf2_physname instead of
2911 objfile.
2912 (read_func_scope): Access objfile through dwarf2_per_objfile.
2913 (read_lexical_block_scope): Likewise.
2914 (read_call_site_scope): Likewise.
2915 (read_variable): Likewise.
2916 (dwarf2_rnglists_process): Likewise.
2917 (dwarf2_ranges_process): Likewise.
2918 (dwarf2_ranges_read): Likewise.
2919 (dwarf2_record_block_ranges): Likewise.
2920 (dwarf2_add_field): Likewise.
2921 (dwarf2_add_member_fn): Likewise.
2922 (read_structure_type): Likewise.
2923 (process_structure_scope): Likewise.
2924 (read_enumeration_type): Likewise.
2925 (read_array_type): Likewise.
2926 (read_common_block): Likewise.
2927 (read_namespace_type): Likewise.
2928 (read_namespace): Likewise.
2929 (read_module_type): Likewise.
2930 (read_tag_pointer_type): Likewise.
2931 (read_tag_ptr_to_member_type): Likewise.
2932 (read_tag_string_type): Likewise.
2933 (read_subroutine_type): Likewise.
2934 (read_typedef): Likewise.
2935 (read_base_type): Likewise.
2936 (attr_to_dynamic_prop): Likewise.
2937 (read_subrange_type): Likewise.
2938 (read_unspecified_type): Likewise.
2939 (load_partial_dies): Likewise.
2940 (read_partial_die): Likewise.
2941 (find_partial_die): Likewise.
2942 (guess_partial_die_structure_name): Likewise.
2943 (fixup_partial_die): Likewise.
2944 (read_attribute_value): Likewise.
2945 (read_addr_index_from_leb128): Likewise.
2946 (dwarf2_read_addr_index): Likewise.
2947 (dwarf2_string_attr): Likewise.
2948 (lnp_state_machine::check_line_address): Likewise.
2949 (dwarf_decode_lines_1): Likewise.
2950 (dwarf_decode_lines): Likewise.
2951 (dwarf2_start_symtab): Likewise.
2952 (var_decode_location): Likewise.
2953 (new_symbol_full): Likewise.
2954 (dwarf2_const_value_data): Likewise.
2955 (dwarf2_const_value_attr): Likewise.
2956 (dwarf2_const_value): Likewise.
2957 (die_type): Likewise.
2958 (die_containing_type): Likewise.
2959 (lookup_die_type): Likewise.
2960 (guess_full_die_structure_name): Likewise.
2961 (anonymous_struct_prefix): Likewise.
2962 (dwarf2_name): Likewise.
2963 (follow_die_ref_or_sig): Likewise.
2964 (follow_die_offset): Likewise.
2965 (follow_die_ref): Likewise.
2966 (dwarf2_fetch_die_loc_sect_off): Likewise.
2967 (dwarf2_fetch_constant_bytes): Likewise.
2968 (dwarf2_fetch_die_type_sect_off): Likewise.
2969 (dwarf2_get_die_type): Likewise.
2970 (follow_die_sig): Likewise.
2971 (decode_locdesc): Likewise.
2972 (dwarf2_per_cu_objfile): Likewise.
2973 (dwarf2_per_cu_text_offset): Likewise.
2974 (init_one_comp_unit): Assign dwarf2_per_objfile instead of
2975 objfile.
2976 (set_die_type): Access objfile through
2977 dwarf2_per_objfile.
2978
b01ba14d
SM
29792018-01-07 Simon Marchi <simon.marchi@ericsson.com>
2980
2981 * valprint.c (converted_character_d): Remove typedef.
2982 (DEF_VEC_O (converted_character_d)): Remove.
2983 (count_next_character): Use std::vector.
2984 (print_converted_chars_to_obstack): Likewise.
2985 (generic_printstr): Likewise.
2986
4d0fdd9b
SM
29872018-01-07 Simon Marchi <simon.marchi@polymtl.ca>
2988
2989 * xml-support.h (struct gdb_xml_value): Add constructor.
2990 <value>: Change type to unique_xmalloc_ptr.
2991 (gdb_xml_value_s): Remove typedef.
2992 (DEF_VEC_O (gdb_xml_value_s)): Remove.
2993 (gdb_xml_element_start_handler): Change parameter type to
2994 std::vector.
2995 (xml_find_attribute): Likewise.
2996 * xml-support.c (xml_find_attribute): Change parameter type to
2997 std::vector and adjust.
2998 (gdb_xml_values_cleanup): Remove.
2999 (gdb_xml_parser::start_element): Adjust to std::vector.
3000 (xinclude_start_include): Change paraeter type to std::vector
3001 and adjust.
3002 * btrace.c (check_xml_btrace_version): Likewise.
3003 (parse_xml_btrace_block): Likewise.
3004 (parse_xml_btrace_pt_config_cpu): Likewise.
3005 (parse_xml_btrace_pt): Likewise.
3006 (parse_xml_btrace_conf_bts): Likewise.
3007 (parse_xml_btrace_conf_pt): Likewise.
3008 * memory-map.c (memory_map_start_memory): Likewise.
3009 (memory_map_start_property): Likewise.
3010 * osdata.c (osdata_start_osdata): Likewise.
3011 (osdata_start_item): Likewise.
3012 (osdata_start_column): Likewise.
3013 * remote.c (start_thread): Likewise.
3014 * solib-aix.c (library_list_start_library): Likewise.
3015 (library_list_start_list): Likewise.
3016 * solib-svr4.c (library_list_start_library): Likewise.
3017 (svr4_library_list_start_list): Likewise.
3018 * solib-target.c (library_list_start_segment): Likewise.
3019 (library_list_start_section): Likewise.
3020 (library_list_start_library): Likewise.
3021 (library_list_start_list): Likewise.
3022 * tracepoint.c (traceframe_info_start_memory): Likewise.
3023 (traceframe_info_start_tvar): Likewise.
3024 * xml-syscall.c (syscall_start_syscall): Likewise.
3025 * xml-tdesc.c (tdesc_start_target): Likewise.
3026 (tdesc_start_feature): Likewise.
3027 (tdesc_start_reg): Likewise.
3028 (tdesc_start_union): Likewise.
3029 (tdesc_start_struct): Likewise.
3030 (tdesc_start_flags): Likewise.
3031 (tdesc_start_enum): Likewise.
3032 (tdesc_start_field): Likewise.
3033 (tdesc_start_enum_value): Likewise.
3034 (tdesc_start_vector): Likewise.
3035
f979c73f
SM
30362018-01-07 Simon Marchi <simon.marchi@polymtl.ca>
3037
3038 * extension.h (struct xmethod_worker) <clone>: Remove.
3039 * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
3040 Remove.
3041 (python_xmethod_worker::clone): Remove.
3042 * valops.c (find_overload_match): Use std::move instead of
3043 clone.
3044
ba18742c
SM
30452018-01-07 Simon Marchi <simon.marchi@polymtl.ca>
3046
3047 * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
3048 (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
3049 <free_xmethod_worker_data>: Remove.
3050 <get_matching_xmethod_workers>: Chance VEC to std::vector.
3051 <get_xmethod_arg_types>: Remove.
3052 <get_xmethod_result_type>: Remove.
3053 <invoke_xmethod>: Remove.
3054 * extension.c (new_xmethod_worker): Remove.
3055 (clone_xmethod_worker): Remove.
3056 (get_matching_xmethod_workers): Return void, pass std::vector by
3057 pointer.
3058 (get_xmethod_arg_types): Rename to...
3059 (xmethod_worker::get_arg_types): ... this, and adjust.
3060 (get_xmethod_result_type): Rename to...
3061 (xmethod_worker::get_result_type): ... this, and adjust.
3062 (invoke_xmethod): Remove.
3063 (free_xmethod_worker): Remove.
3064 (free_xmethod_worker_vec): Remove.
3065 * extension.h (enum ext_lang_rc): Move here from
3066 extension-priv.h.
3067 (struct xmethod_worker): Add constructor and destructor.
3068 <data>: Remove.
3069 <value>: Remove.
3070 <invoke, clone, do_get_result_type, do_get_arg_types>: New
3071 virtual pure methods.
3072 <get_arg_types, get_result_type>: New methods.
3073 (xmethod_worker_ptr): Remove typedef.
3074 (DEF_VEC_P (xmethod_worker_ptr)): Remove.
3075 (xmethod_worker_vec): Remove typedef.
3076 (xmethod_worker_up): New typedef.
3077 (invoke_xmethod): Remove.
3078 (clone_xmethod_worker): Remove.
3079 (free_xmethod_worker): Remove.
3080 (free_xmethod_worker_vec): Remove.
3081 (get_xmethod_arg_types): Remove.
3082 (get_xmethod_result_type): Remove.
3083 * valops.c (find_method_list): Use std::vector, don't use
3084 intermediate vector.
3085 (value_find_oload_method_list): Use std::vector.
3086 (find_overload_match): Use std::vector.
3087 (find_oload_champ): Use std::vector.
3088 * value.c (value_free): Use operator delete.
3089 (value_of_xmethod): Rename to...
3090 (value_from_xmethod): ... this. Don't assign
3091 xmethod_worker::value, take rvalue-reference.
3092 (result_type_of_xmethod): Adjust.
3093 (call_xmethod): Adjust.
3094 * value.h: Include extension.h.
3095 (struct xmethod_worker): Don't forward-declare.
3096 (value_of_xmethod): Rename to...
3097 (value_from_xmethod): ... this, take rvalue-reference.
3098 * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
3099 (struct python_xmethod_worker): ... this, add constructor and
3100 destructor.
3101 <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
3102 (gdbpy_free_xmethod_worker_data): Rename to...
3103 (python_xmethod_worker::~python_xmethod_worker): ... this and
3104 adjust.
3105 (gdbpy_clone_xmethod_worker_data): Rename to...
3106 (python_xmethod_worker::clone): ... this and adjust.
3107 (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
3108 temporary vector.
3109 (gdbpy_get_xmethod_arg_types): Rename to...
3110 (python_xmethod_worker::do_get_arg_types): ... this and adjust.
3111 (gdbpy_get_xmethod_result_type): Rename to...
3112 (python_xmethod_worker::do_get_result_type): ... this and
3113 adjust.
3114 (gdbpy_invoke_xmethod): Rename to...
3115 (python_xmethod_worker::invoke): ... this and adjust.
3116 (new_python_xmethod_worker): Rename to...
3117 (python_xmethod_worker::python_xmethod_worker): ... this and
3118 adjust.
3119 * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
3120 Remove.
3121 (gdbpy_free_xmethod_worker_data): Remove.
3122 (gdbpy_get_matching_xmethod_workers): Use std::vector.
3123 (gdbpy_get_xmethod_arg_types): Remove.
3124 (gdbpy_get_xmethod_result_type): Remove.
3125 (gdbpy_invoke_xmethod): Remove.
3126 * python/python.c (python_extension_ops): Remove obsolete
3127 callbacks.
3128
e379cee6
PA
31292018-01-05 Pedro Alves <palves@redhat.com>
3130
3131 PR gdb/18653
3132 * common/signals-state-save-restore.c
3133 (save_original_signals_state): New parameter 'quiet'. Warn if we
3134 find a custom handler preinstalled, instead of internal erroring.
3135 But only warn if !quiet.
3136 * common/signals-state-save-restore.h
3137 (save_original_signals_state): New parameter 'quiet'.
3138 * main.c (captured_main_1): Move save_original_signals_state call
3139 after option handling, and pass QUIET.
3140
a655456c
PA
31412018-01-05 Pedro Alves <palves@redhat.com>
3142
3143 * spu-tdep.c (spu_catch_start): Pass
3144 symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
3145
de63c46b
PA
31462018-01-05 Pedro Alves <palves@redhat.com>
3147
3148 PR gdb/22670
3149 * ada-lang.c (literal_symbol_name_matcher): New function.
3150 (ada_get_symbol_name_matcher): Use it for
3151 symbol_name_match_type::SEARCH_NAME.
3152 * block.c (block_lookup_symbol): New parameter 'match_type'. Pass
3153 it down instead of assuming symbol_name_match_type::FULL.
3154 * block.h (block_lookup_symbol): New parameter 'match_type'.
3155 * c-valprint.c (print_unpacked_pointer): Use
3156 lookup_symbol_search_name instead of lookup_symbol.
3157 * compile/compile-object-load.c (get_out_value_type): Pass down
3158 symbol_name_match_type::SEARCH_NAME.
3159 * cp-namespace.c (cp_basic_lookup_symbol): Pass down
3160 symbol_name_match_type::FULL.
3161 * cp-support.c (cp_get_symbol_name_matcher): Handle
3162 symbol_name_match_type::SEARCH_NAME.
3163 * infrun.c (insert_exception_resume_breakpoint): Use
3164 lookup_symbol_search_name.
3165 * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
3166 * psymtab.c (maintenance_check_psymtabs): Use
3167 symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
3168 * stack.c (print_frame_args): Use lookup_symbol_search_name and
3169 SYMBOL_SEARCH_NAME.
3170 * symtab.c (lookup_local_symbol): Don't demangle the lookup name
3171 if symbol_name_match_type::SEARCH_NAME.
3172 (lookup_symbol_in_language): Pass down
3173 symbol_name_match_type::FULL.
3174 (lookup_symbol_search_name): New.
3175 (lookup_language_this): Pass down
3176 symbol_name_match_type::SEARCH_NAME.
3177 (lookup_symbol_aux, lookup_local_symbol): New parameter
3178 'match_type'. Pass it down.
3179 * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
3180 (lookup_symbol_search_name): New declaration.
3181 (lookup_symbol_in_block): New 'match_type' parameter.
3182
f98fc17b
PA
31832018-01-05 Pedro Alves <palves@redhat.com>
3184
3185 PR gdb/22670
3186 * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
3187 ada_lookup_symbol.
3188 (ada_lookup_symbol): Reimplement in terms of
3189 ada_lookup_symbol_list, bits factored out from
3190 ada_lookup_encoded_symbol.
3191
342f8240
JB
31922018-01-05 Joel Brobecker <brobecker@adacore.com>
3193
3194 * ada-exp.y (write_object_renaming): When subscripting an array
3195 using a symbol as the index, pass the block in call to
3196 ada_lookup_encoded_symbol when looking that symbol up.
3197
7150d33c
JG
31982018-01-05 Jerome Guitton <guitton@adacore.com>
3199
3200 * ada-lang.c (ada_array_length): Use ada_index_type instead of
3201 TYPE_INDEX_TYPE.
3202
cc0e770c
JB
32032018-01-05 Joel Brobecker <brobecker@adacore.com>
3204
3205 * ada-lang.c (ada_to_fixed_value_create): Add handling of
3206 the case where VALUE_LVAL (val0) is not lval_memory.
3207
f79da888 32082018-01-05 Xavier Roirand <roirand@adacore.com>
e3861a03
XR
3209
3210 * ada-valprint.c (print_optional_low_bound): Handle
3211 character-indexed array printing like boolean-indexed array
3212 printing.
3213
cd385f94
JB
32142018-01-05 Joel Brobecker <brobecker@adacore.com>
3215
3216 * NEWS: Create a new section for the next release branch.
3217 Rename the section of the current branch, now that it has
3218 been cut.
3219
09aca949
JB
32202018-01-05 Joel Brobecker <brobecker@adacore.com>
3221
3222 GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
3223 * version.in: Bump version to 8.1.50.DATE-git.
3224
9f757bf7
XR
32252018-01-03 Xavier Roirand <roirand@adacore.com>
3226
3227 * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
3228 Add field.
3229 * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
3230 Add field.
3231 (default_exception_support_info) <catch_handlers_sym>: Add field.
3232 (exception_support_info_fallback) <catch_handlers_sym>: Add field.
3233 (ada_exception_name_addr_1): Add "catch handlers" handling.
3234 (ada_exception_catchpoint_cond_string) <ex>: New parameter.
3235 Update all callers.
3236 (create_excep_cond_exprs) <ex>: Add parameter.
3237 (re_set_exception): Update create_excep_cond_exprs call.
3238 (print_it_exception, print_one_exception, print_mention_exception)
3239 (print_recreate_exception): Add "catch handler" handling.
3240 (allocate_location_catch_handlers, re_set_catch_handlers)
3241 (check_status_catch_handlers, print_it_catch_handlers)
3242 (print_one_catch_handlers, print_mention_catch_handlers)
3243 (print_recreate_catch_handlers): New function.
3244 (catch_handlers_breakpoint_ops): New variable.
3245 (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
3246 Add parameter. Add "catch handler" handling.
3247 (ada_exception_sym_name, ada_exception_breakpoint_ops):
3248 Add "catch handler" handling.
3249 (ada_exception_catchpoint_cond_string): Add "catch handler"
3250 handling.
3251 (create_ada_exception_catchpoint): Update create_excep_cond_exprs
3252 call.
3253 (catch_ada_handlers_command): New function.
3254 (initialize_ada_catchpoint_ops): Initialize "catch handlers"
3255 operations structure.
3256 (_initialize_ada_language): Add "catch handlers" command entry.
3257 * NEWS: Document "catch handlers" feature.
3258
9fe561ab
JB
32592018-01-02 Joel Brobecker <brobecker@adacore.com>
3260
3261 * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
3262 account when creating the array type of the slice.
3263 (ada_value_slice): Likewise.
3264
a405673c
JB
32652018-01-02 Joel Brobecker <brobecker@adacore.com>
3266
3267 * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
3268 New enum value.
3269 (create_array_type_with_stride): Add byte_stride_prop parameter.
3270 * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
3271 New parameter. Update all callers in this file.
3272 (array_type_has_dynamic_stride): New function.
3273 (is_dynamic_type_internal, resolve_dynamic_array): Add handling
3274 of arrays with dynamic byte strides.
3275 * dwarf2read.c (read_array_type): Add support for dynamic
3276 DW_AT_byte_stride attributes.
3277
74a2f8ff
JB
32782018-01-02 Joel Brobecker <brobecker@adacore.com>
3279
3280 * dwarf2read.c (read_unspecified_type): Treat
3281 DW_TAG_enumeration_type DIEs from Ada units as stubs.
3282
e2882c85
JB
32832018-01-01 Joel Brobecker <brobecker@adacore.com>
3284
3285 Update copyright year range in all GDB files.
3286
1690bb24
JB
32872018-01-01 Joel Brobecker <brobecker@adacore.com>
3288
3289 * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
3290 and gdb/testsuite/gdb.base/step-line.c.
3291
0f0c98a8
JB
32922018-01-01 Joel Brobecker <brobecker@adacore.com>
3293
3294 * copyright.py (main): Dump the contents of
3295 MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
3296 even if BY_HAND is empty.
3297
82e1e79a
JB
32982018-01-01 Joel Brobecker <brobecker@adacore.com>
3299
3300 * top.c (print_gdb_version): Update Copyright year in version
3301 message.
3302
053f54e5 33032018-01-01 Joel Brobecker <brobecker@adacore.com>
47fea877 3304
053f54e5 3305 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
47fea877 3306
053f54e5 3307For older changes see ChangeLog-2017.
c906108c
SS
3308\f
3309Local Variables:
3310mode: change-log
3311left-margin: 8
3312fill-column: 74
3313version-control: never
57da7796 3314coding: utf-8
c906108c 3315End: