]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blame - libctf/ChangeLog
libctf: error out on corrupt CTF with invalid header flags
[thirdparty/binutils-gdb.git] / libctf / ChangeLog
CommitLineData
ec388c16
NA
12020-07-22 Nick Alcock <nick.alcock@oracle.com>
2
3 * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
4
67d4cc67
NA
52020-07-22 Nick Alcock <nick.alcock@oracle.com>
6
7 ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
8
e28591b3
NA
92020-07-22 Nick Alcock <nick.alcock@oracle.com>
10
11 * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
12 sorting functions.
13 (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
14 ctf_dynhash_next_sorted.
15 <cu.ctn_h>: New, pointer to the dynhash under iteration.
16 <cu.ctn_s>: New, pointer to the dynset under iteration.
17 (ctf_hash_sort_f): Sorting function passed to...
18 (ctf_dynhash_next_sorted): ... this new function.
19 (ctf_dynhash_next): New.
20 (ctf_dynset_next): New.
21 * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
22 (ctf_dynhash_cnext): New.
23 (ctf_dynset_cnext): New.
24 * ctf-hash.c (ctf_dynhash_next_sorted): New.
25 (ctf_dynhash_next): New.
26 (ctf_dynset_next): New.
27 * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
28 needed.
29 (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
30
688d28f6
NA
312020-07-22 Nick Alcock <nick.alcock@oracle.com>
32
33 * ctf-impl.h (ctf_next): New.
34 (ctf_get_dict): New prototype.
35 * ctf-lookup.c (ctf_get_dict): New, split out of...
36 (ctf_lookup_by_id): ... here.
37 * ctf-util.c (ctf_next_create): New.
38 (ctf_next_destroy): New.
39 (ctf_next_copy): New.
40 * ctf-types.c (includes): Add <assert.h>.
41 (ctf_member_next): New.
42 (ctf_enum_next): New.
43 (ctf_type_iter): Document the lack of iteration over parent
44 types.
45 (ctf_type_next): New.
46 (ctf_variable_next): New.
47 * ctf-archive.c (ctf_archive_next): New.
48 * libctf.ver: Add new public functions.
49
2399827b
NA
502020-07-22 Nick Alcock <nick.alcock@oracle.com>
51
52 * libctf.ver (ctf_ref): New.
53 * ctf-open.c (ctf_ref): Implement it.
54
9850ce4d
NA
552020-07-22 Nick Alcock <nick.alcock@oracle.com>
56
57 * ctf-inlines.h (ctf_forwardable_kind): New.
58 * ctf-create.c (ctf_add_forward): Use it.
59
2c9ca36b
NA
602020-07-22 Nick Alcock <nick.alcock@oracle.com>
61
62 * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
63 * ctf-inlines.h (ctf_get_ctt_size): ... to here.
64
77648241
NA
652020-07-22 Nick Alcock <nick.alcock@oracle.com>
66
67 * ctf-hash.c (ctf_dynset_eq_string): New.
68 (ctf_dynset_create): New.
69 (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
70 (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
71 (key_to_internal): New.
72 (internal_to_key): New.
73 (ctf_dynset_insert): New.
74 (ctf_dynset_remove): New.
75 (ctf_dynset_destroy): New.
76 (ctf_dynset_lookup): New.
77 (ctf_dynset_exists): New.
78 (ctf_dynset_lookup_any): New.
79 (ctf_hash_insert_type): Coding style.
80 (ctf_hash_define_type): Likewise.
81 * ctf-impl.h (ctf_dynset_t): New.
82 (ctf_dynset_eq_string): New.
83 (ctf_dynset_create): New.
84 (ctf_dynset_insert): New.
85 (ctf_dynset_remove): New.
86 (ctf_dynset_destroy): New.
87 (ctf_dynset_lookup): New.
88 (ctf_dynset_exists): New.
89 (ctf_dynset_lookup_any): New.
90 * ctf-inlines.h (ctf_dynset_cinsert): New.
91
a49c6c6a
NA
922020-07-22 Nick Alcock <nick.alcock@oracle.com>
93
94 * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
95 <value_free>: Likewise.
96 <owner>: New.
97 (ctf_dynhash_item_free): Indirect through the owner.
98 (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
99 allocate space for the key_free and value_free fields fields
100 if necessary.
101 (ctf_hashtab_insert): Likewise. Fix OOM errno value.
102 (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
103 value_free if they will exist. Set the slot's owner, but only
104 if it exists.
105 (ctf_dynhash_remove): Adjust.
106
5ceee3db
NA
1072020-07-22 Nick Alcock <nick.alcock@oracle.com>
108
109 * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
110 there is a key-freeing function and the key already exists.
111
809f6eb3
NA
1122020-07-22 Nick Alcock <nick.alcock@oracle.com>
113
114 * ctf-inlines.h: New file.
115 * ctf-impl.h: Include it.
116 (ctf_hash_iter_find_f): New typedef.
117 (ctf_dynhash_elements): New.
118 (ctf_dynhash_lookup_kv): New.
119 (ctf_dynhash_iter_find): New.
120 * ctf-hash.c (ctf_dynhash_lookup_kv): New.
121 (ctf_traverse_find_cb_arg_t): New.
122 (ctf_hashtab_traverse_find): New.
123 (ctf_dynhash_iter_find): New.
124 (ctf_dynhash_elements): New.
125
469e75b6
NA
1262020-07-22 Nick Alcock <nick.alcock@oracle.com>
127
128 * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
129
9c23dfa5
NA
1302020-07-22 Nick Alcock <nick.alcock@oracle.com>
131
132 * ctf-archive.c (ctf_archive_count): New.
133 * libctf.ver: New public function.
134
e0325e2c
NA
1352020-07-22 Nick Alcock <nick.alcock@oracle.com>
136
137 * ctf-types.c (ctf_member_count): New.
138 * libctf.ver: New public function.
139
9b15cbb7
NA
1402020-07-22 Nick Alcock <nick.alcock@oracle.com>
141
142 * ctf-types.c (ctf_type_kind_forwarded): New.
143
01d93174
NA
1442020-07-22 Nick Alcock <nick.alcock@oracle.com>
145
146 * ctf-types.c (ctf_type_name_raw): New.
147 (ctf_type_aname_raw): Reimplement accordingly.
148
5ec7465f
NA
1492020-07-22 Nick Alcock <nick.alcock@oracle.com>
150
151 * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
152
601e455b
NA
1532020-07-22 Nick Alcock <nick.alcock@oracle.com>
154
155 * ctf-impl.h (struct ctf_archive_internal)
156 <ctfi_unmap_on_close>: New.
157 (ctf_new_archive_internal): Adjust.
158 * ctf-archive.c (ctf_new_archive_internal): Likewise.
159 Initialize ctfi_unmap_on_close. Adjust error path.
160 (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
161 (unmap_on_close is 0).
162 (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
163 * ctf-open-bfd.c (ctf_fdopen): Adjust.
164
96e3ec29
NA
1652020-07-22 Nick Alcock <nick.alcock@oracle.com>
166
167 * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
168 ints, floats or typedefs have no name. Fix comment typo.
169
502e838e
NA
1702020-07-22 Nick Alcock <nick.alcock@oracle.com>
171
172 * ctf-create.c (ctf_add_slice): Support slices of any kind that
173 resolves to an integral type.
174 * ctf-types.c (ctf_type_encoding): Resolve the type before
175 fishing its encoding out.
176
dd987f00
NA
1772020-07-22 Nick Alcock <nick.alcock@oracle.com>
178
179 * ctf-create.c (ctf_create): Mark dirty.
180
f47ca311
NA
1812020-07-22 Nick Alcock <nick.alcock@oracle.com>
182
183 * ctf-create.c (membcmp) Skip nameless members.
184
ab769488
NA
1852020-07-22 Nick Alcock <nick.alcock@oracle.com>
186
187 * ctf-create.c (ctf_add_member_offset): Support names of ""
188 as if they were the null pointer.
189
2484ca43
NA
1902020-07-22 Nick Alcock <nick.alcock@oracle.com>
191
192 * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
193 special-casing.
194
43706199
NA
1952020-07-22 Nick Alcock <nick.alcock@oracle.com>
196
197 * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
198
9943fa3a
NA
1992020-07-22 Nick Alcock <nick.alcock@oracle.com>
200
201 * ctf-create.c (ctf_serialize): Add cast.
202 (ctf_add_slice): Likewise.
203
afd78bd6
NA
2042020-07-22 Nick Alcock <nick.alcock@oracle.com>
205
206 * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
207 * ctf-create.c (ctf_add_function): Check for unimplemented type
208 and populate at the same time. Populate one-by-one, not via
209 memcpy.
210 (ctf_serialize): Remove unnecessary cast.
211 * ctf-types.c (ctf_func_type_info): Likewise.
212 (ctf_func_type_args): Likewise. Fix comment typo.
213
2361f1c8
NA
2142020-07-22 Nick Alcock <nick.alcock@oracle.com>
215
216 * ctf-create.c (ctf_add_reftype): Support refs to type zero.
217 (ctf_add_array): Support array contents of type zero.
218 (ctf_add_function): Support arguments and return types of
219 type zero.
220 (ctf_add_typedef): Support typedefs to type zero.
221 (ctf_add_member_offset): Support members of type zero,
222 unless added at unspecified (naturally-aligned) offset.
223
7eea9d3b
NA
2242020-07-22 Nick Alcock <nick.alcock@oracle.com>
225
226 * ctf-error.c: Include <stddef.h>, for offsetof.
227 (_ctf_errlist): Migrate to...
228 (_ctf_errlist_t): ... this.
229 (_ctf_erridx): New, indexes into _ctf_errlist_t.
230 (_ctf_nerr): Remove.
231 (ctf_errmsg): Adjust accordingly.
232 * Makefile.am (BUILT_SOURCES): Note...
233 (ctf-error.h): ... this new rule.
234 * Makefile.in: Regenerate.
235 * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
236 * .gitignore: New, ignore ctf-error.h.
237
b64751cf
NA
2382020-07-22 Nick Alcock <nick.alcock@oracle.com>
239
240 * ctf-impl.h: Fix typos in comments.
241
df16e041
NC
2422020-07-22 Nick Clifton <nickc@redhat.com>
243
244 * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
245 same file descriptor.
246
b115b9fd
NC
2472020-07-04 Nick Clifton <nickc@redhat.com>
248
249 Binutils 2.35 branch created.
250
8e6635bd
NA
2512020-06-26 Nick Alcock <nick.alcock@oracle.com>
252
253 * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
254 alphabetical order.
255 * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
256 * config.h.in: Regenerated.
257 * Makefile.in: Likewise.
258 * configure: Likewise.
259
c1401ecc
NA
2602020-06-26 Nick Alcock <nick.alcock@oracle.com>
261
262 * ctf-create.c: Include <unistd.h>.
263 * ctf-open-bfd.c: Likewise.
264
e755667f
NA
2652020-06-26 Nick Alcock <nick.alcock@oracle.com>
266
267 PR libctf/25120
268 * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
269 * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
270 means this is declared.
271 (bswap_32): Likewise.
272 (bswap_64): Likewise.
273 (bswap_identity_64): Remove, unused.
274 * configure: Regenerated.
275 * config.h.in: Likewise.
276
86670658
NA
2772020-06-26 Nick Alcock <nick.alcock@oracle.com>
278
279 PR libctf/25120
280 * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
281 (_libctf_unlikely_): Likewise.
282 (_libctf_unused): Likewise.
283 (_libctf_malloc_): Likewise.
284
2e428e74
NA
2852020-06-26 Nick Alcock <nick.alcock@oracle.com>
286
287 PR libctf/25120
288 * ctf-archive.c (search_nametbl): No longer global: declare...
289 (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
290 (search_modent_by_name): Take and use ARG for the nametbl.
291
2f6ecaed
NA
2922020-06-26 Nick Alcock <nick.alcock@oracle.com>
293
294 * ctf-impl.h (ctf_new_archive_internal): Declare.
295 (ctf_arc_bufopen): Remove.
296 (ctf_archive_internal) <ctfi_free_symsect>: New.
297 * ctf-archive.c (ctf_arc_close): Use it.
298 (ctf_arc_bufopen): Fuse into...
299 (ctf_new_archive_internal): ... this, moved across from...
300 * ctf-open-bfd.c: ... here.
301 (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
302 * libctf.ver: Add it.
303
8ffcdf18
NA
3042020-06-26 Nick Alcock <nick.alcock@oracle.com>
305
306 * ctf-create.c (ctf_add_forward): Intern in the right namespace.
307 (ctf_dtd_delete): Remove correspondingly.
308 (ctf_rollback): Likewise.
309
d04a47ac
NA
3102020-06-26 Nick Alcock <nick.alcock@oracle.com>
311
312 * ctf-create.c (ctf_add_type_internal): Hand back existing types
313 unchanged.
314
6bbf9da8
NA
3152020-06-26 Nick Alcock <nick.alcock@oracle.com>
316
317 * ctf-create.c (ctf_add_forward): Don't add forwards to
318 types that already exist.
319
fe4c2d55
NA
3202020-06-26 Nick Alcock <nick.alcock@oracle.com>
321
322 * ctf-open.c (init_types): Only intern root-visible types.
323 * ctf-create.c (ctf_dtd_insert): Likewise.
324 (ctf_dtd_delete): Only remove root-visible types.
325 (ctf_rollback): Likewise.
326 (ctf_add_generic): Adjust.
327 (ctf_add_struct_sized): Adjust comment.
328 (ctf_add_union_sized): Likewise.
329 (ctf_add_enum): Likewise.
330 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
331
11978942
JB
3322020-03-11 John Baldwin <jhb@FreeBSD.org>
333
334 * swap.h (bswap_identity_64): Make static.
335
ae774686
NC
3362020-01-18 Nick Clifton <nickc@redhat.com>
337
338 Binutils 2.34 branch created.
339
eb9a7e35 3402020-01-05 Joel Brobecker <brobecker@adacore.com>
3a657c60
EZ
341
342 PR binutils/25155:
343 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
344 * configure, config.h.in: Regenerate.
345
b14ce8bf
AM
3462020-01-01 Alan Modra <amodra@gmail.com>
347
348 Update year range in copyright notice of all files.
349
cbbbc402
SM
3502019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
351
352 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
353
fa56cdcd
NA
3542019-09-30 Nick Alcock <nick.alcock@oracle.com>
355
356 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
357 * ctf-types.c (ctf_type_lname): Likewise.
358
ad613f1d
NA
3592019-09-23 Nick Alcock <nick.alcock@oracle.com>
360
361 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
362 ctf_import after the first for a given file.
363
9323dd86
NA
3642019-09-23 Nick Alcock <nick.alcock@oracle.com>
365
366 * ctf-impl.h (ctf_str_append_noerr): Declare.
367 * ctf-util.c (ctf_str_append_noerr): Define in terms of
368 ctf_str_append.
369 * ctf-dump.c (str_append): New, call it.
370 (ctf_dump_format_type): Use str_append, not ctf_str_append.
371 (ctf_dump_label): Likewise.
372 (ctf_dump_objts): Likewise.
373 (ctf_dump_funcs): Likewise.
374 (ctf_dump_var): Likewise.
375 (ctf_dump_member): Likewise.
376 (ctf_dump_type): Likewise.
377 (ctf_dump): Likewise.
378
de07e349
NA
3792019-09-23 Nick Alcock <nick.alcock@oracle.com>
380
381 * ctf-impl.h (ctf_alloc): Remove.
382 (ctf_free): Likewise.
383 (ctf_strdup): Likewise.
384 * ctf-subr.c (ctf_alloc): Remove.
385 (ctf_free): Likewise.
386 * ctf-util.c (ctf_strdup): Remove.
387
388 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
389 ctf_free; strdup, not ctf_strdup.
390 (ctf_dtd_delete): Likewise.
391 (ctf_dvd_delete): Likewise.
392 (ctf_add_generic): Likewise.
393 (ctf_add_function): Likewise.
394 (ctf_add_enumerator): Likewise.
395 (ctf_add_member_offset): Likewise.
396 (ctf_add_variable): Likewise.
397 (membadd): Likewise.
398 (ctf_compress_write): Likewise.
399 (ctf_write_mem): Likewise.
400 * ctf-decl.c (ctf_decl_push): Likewise.
401 (ctf_decl_fini): Likewise.
402 (ctf_decl_sprintf): Likewise. Check for OOM.
403 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
404 ctf_free; strdup, not ctf_strdup.
405 (ctf_dump_free): Likewise.
406 (ctf_dump): Likewise.
407 * ctf-open.c (upgrade_types_v1): Likewise.
408 (init_types): Likewise.
409 (ctf_file_close): Likewise.
410 (ctf_bufopen_internal): Likewise. Check for OOM.
411 (ctf_parent_name_set): Likewise: report the OOM to the caller.
412 (ctf_cuname_set): Likewise.
413 (ctf_import): Likewise.
414 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
415 free, not ctf_free; strdup, not ctf_strdup.
416 (ctf_str_free_atom): Likewise.
417 (ctf_str_create_atoms): Likewise.
418 (ctf_str_add_ref_internal): Likewise.
419 (ctf_str_remove_ref): Likewise.
420 (ctf_str_write_strtab): Likewise.
421
9c1a2295
NA
4222019-08-09 Nick Alcock <nick.alcock@oracle.com>
423
424 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
425 work right for non-int/fps.
426
1a6ab13e
NA
4272019-08-08 Nick Alcock <nick.alcock@oracle.com>
428
429 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
430 null pointer.
431
99dc3ebd
NA
4322019-08-07 Nick Alcock <nick.alcock@oracle.com>
433
434 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
435 * ctf-open.c (ctf_file_close): Free it.
436 * ctf-create.c (ctf_serialize): Adjust.
437 (membcmp): When reporting a conflict due to an error, report the
438 error.
439 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
440 (ctf_add_type_internal): ... this. Hand back types we are already
441 in the middle of adding immediately. Hand back structs/unions with
442 the same number of members immediately. Do not walk the dynamic
443 list. Call ctf_add_type_internal, not ctf_add_type. Handle
444 forwards promoted to other types and the inverse case identically.
445 Add structs to the mapping as soon as we intern them, before they
446 gain any members.
447
676c3ecb
NA
4482019-08-09 Nick Alcock <nick.alcock@oracle.com>
449
450 * ctf-impl.h (ctf_names_t): New.
451 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
452 (ctf_file_t) <ctf_structs>: Likewise.
453 <ctf_unions>: Likewise.
454 <ctf_enums>: Likewise.
455 <ctf_names>: Likewise.
456 <ctf_lookups>: Improve comment.
457 <ctf_ptrtab_len>: New.
458 <ctf_prov_strtab>: New.
459 <ctf_str_prov_offset>: New.
460 <ctf_dtbyname>: Remove, redundant to the names hashes.
461 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
462 (ctf_dtdef_t) <dtd_name>: Remove.
463 <dtd_data>: Note that the ctt_name is now populated.
464 (ctf_str_atom_t) <csa_offset>: This is now the strtab
465 offset for internal strings too.
466 <csa_external_offset>: New, the external strtab offset.
467 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
468 (ctf_name_table): New declaration.
469 (ctf_lookup_by_rawname): Likewise.
470 (ctf_lookup_by_rawhash): Likewise.
471 (ctf_set_ctl_hashes): Likewise.
472 (ctf_serialize): Likewise.
473 (ctf_dtd_insert): Adjust.
474 (ctf_simple_open_internal): Likewise.
475 (ctf_bufopen_internal): Likewise.
476 (ctf_list_empty_p): Likewise.
477 (ctf_str_remove_ref): Likewise.
478 (ctf_str_add): Returns uint32_t now.
479 (ctf_str_add_ref): Likewise.
480 (ctf_str_add_external): Now returns a boolean (int).
481 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
482 for strings in the appropriate range.
483 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
484 when adding the null string to the new strtab.
485 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
486 (ctf_str_add_ref_internal): Add make_provisional argument. If
487 make_provisional, populate the offset and fill in the
488 ctf_prov_strtab accordingly.
489 (ctf_str_add): Return the offset, not the string.
490 (ctf_str_add_ref): Likewise.
491 (ctf_str_add_external): Return a success integer.
492 (ctf_str_remove_ref): New, remove a single ref.
493 (ctf_str_count_strtab): Do not count the initial null string's
494 length or the existence or length of any unreferenced internal
495 atoms.
496 (ctf_str_populate_sorttab): Skip atoms with no refs.
497 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
498 to the cts_len for the null string, since it is no longer done
499 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
500 Populate the csa_offset for both internal and external cases.
501 Flush the ctf_prov_strtab afterwards, and reset the
502 ctf_str_prov_offset.
503 * ctf-create.c (ctf_grow_ptrtab): New.
504 (ctf_create): Call it. Initialize new fields rather than old
505 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
506 Set the ctl hashes and data model.
507 (ctf_update): Rename to...
508 (ctf_serialize): ... this. Leave a compatibility function behind.
509 Tell ctf_simple_open_internal that this is a writable dictionary.
510 Pass the new fields along from the old dictionary. Drop
511 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
512 Do not zero out the DTD's ctt_name.
513 (ctf_prefixed_name): Rename to...
514 (ctf_name_table): ... this. No longer return a prefixed name: return
515 the applicable name table instead.
516 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
517 kind we're adding. Migrate away from dtd_name.
518 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
519 deleted ctt_name.
520 (ctf_dtd_lookup_type_by_name): Remove.
521 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
522 No longer check ctf_dtnextid: check ctf_typemax instead.
523 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
524 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
525 ctf_name_table and the right name table, and migrate away from
526 dtd_name as in ctf_dtd_delete.
527 (ctf_add_generic): Pass in the kind explicitly and pass it to
528 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
529 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
530 Grow the ptrtab if needed.
531 (ctf_add_encoded): Pass in the kind.
532 (ctf_add_slice): Likewise.
533 (ctf_add_array): Likewise.
534 (ctf_add_function): Likewise.
535 (ctf_add_typedef): Likewise.
536 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
537 ctt_name rather than dtd_name.
538 (ctf_add_struct_sized): Pass in the kind. Use
539 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
540 ctf_dtd_lookup_type_by_name.
541 (ctf_add_union_sized): Likewise.
542 (ctf_add_enum): Likewise.
543 (ctf_add_enum_encoded): Likewise.
544 (ctf_add_forward): Likewise.
545 (ctf_add_type): Likewise.
546 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
547 being initialized until after the call.
548 (ctf_write_mem): Likewise.
549 (ctf_write): Likewise.
550 * ctf-archive.c (arc_write_one_ctf): Likewise.
551 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
552 ctf_hash_lookup_type.
553 (ctf_lookup_by_id): No longer check the readonly types if the
554 dictionary is writable.
555 * ctf-open.c (init_types): Assert that this dictionary is not
556 writable. Adjust to use the new name hashes, ctf_name_table,
557 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
558 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
559 if set. Drop out early when dictionary is writable. Split the
560 ctf_lookups initialization into...
561 (ctf_set_cth_hashes): ... this new function.
562 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
563 (ctf_simple_open): Adjust accordingly.
564 (ctf_bufopen): Likewise.
565 (ctf_file_close): Destroy the appropriate name hashes. No longer
566 destroy ctf_dtbyname, which is gone.
567 (ctf_getdatasect): Remove spurious "extern".
568 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
569 specified name table, given a kind.
570 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
571 (ctf_member_iter): Add support for iterating over the
572 dynamic type list.
573 (ctf_enum_iter): Likewise.
574 (ctf_variable_iter): Likewise.
575 (ctf_type_rvisit): Likewise.
576 (ctf_member_info): Add support for types in the dynamic type list.
577 (ctf_enum_name): Likewise.
578 (ctf_enum_value): Likewise.
579 (ctf_func_type_info): Likewise.
580 (ctf_func_type_args): Likewise.
581 * ctf-link.c (ctf_accumulate_archive_names): No longer call
582 ctf_update.
583 (ctf_link_write): Likewise.
584 (ctf_link_intern_extern_string): Adjust for new
585 ctf_str_add_external return value.
586 (ctf_link_add_strtab): Likewise.
587 * ctf-util.c (ctf_list_empty_p): New.
588
791915db
NA
5892019-08-05 Nick Alcock <nick.alcock@oracle.com>
590
591 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
592 type zero.
593 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
594 members and types.
595 (ctf_add_variable): Likewise for variables pointing to them.
596 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
597 type link failure, but do warn for others.
598 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
599 errors to be ENOMEM.
600 (ctf_dump_member): Likewise.
601 (ctf_dump_type): Likewise.
602 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
603 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
604 (ctf_dump_header): Likewise.
605 (ctf_dump_label): likewise.
606 (ctf_dump_objts): likewise.
607 (ctf_dump_funcs): likewise.
608 (ctf_dump_var): likewise.
609 (ctf_dump_str): Likewise.
610
87279e3c
NA
6112019-09-30 Nick Alcock <nick.alcock@oracle.com>
612
613 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
614 (LT_INIT): Likewise.
615 (AM_INSTALL_LIBBFD): Likewise.
616 (dlopen): Note why this is necessary in a comment.
617 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
618 opcodes/.
619 (SHARED_LDFLAGS): Likewise.
620 (BFD_LIBADD): Likewise, for libbfd.
621 (BFD_DEPENDENCIES): Likewise.
622 (VERSION_FLAGS): Initialize, using a version script if ld supports
623 one, or libtool -export-symbols-regex otherwise.
624 (AC_CONFIG_MACRO_DIR): Add ../BFD.
625 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
626 (INCDIR): New.
627 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
628 (noinst_LIBRARIES): Replace with...
629 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
630 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
631 libctf-nobfd.la as well.
632 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
633 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
634 (libctf_a_SOURCES): Rename to...
635 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
636 ctf-open-bfd.c.
637 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
638 with ctf-open-bfd.c added.
639 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
640 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
641 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
642 * Makefile.am [INSTALL_LIBCTF]: Use it.
643 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
644 libtool macros.
645 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
646 the unstable components).
647 * Makefile.in: Regenerated.
648 * config.h.in: Likewise.
649 * configure: Likewise.
650
6512019-07-30 Nick Alcock <nick.alcock@oracle.com>
652
653 * configure.ac (INSTALL_LIBCTF): New, controlled by
654 --enable-install-libctf.
655 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
656 * Makefile.in: Regenerated.
657 * configure: Regenerated.
658
f046147d
NA
6592019-07-30 Nick Alcock <nick.alcock@oracle.com>
660
661 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
662 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
663
edc8bbe9
NA
6642019-07-30 Nick Alcock <nick.alcock@oracle.com>
665
666 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
667
7e97445a
NA
6682019-07-13 Nick Alcock <nick.alcock@oracle.com>
669
670 * ctf-impl.h (includes): Include <sys/param.h> here.
671
5ae6af75
NA
6722019-07-30 Nick Alcock <nick.alcock@oracle.com>
673
674 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
675 (flip_objts): Likewise.
676 (flip_vars): Likewise.
677 (flip_types): Likewise.
678
1820745a
NA
6792019-07-30 Nick Alcock <nick.alcock@oracle.com>
680
681 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
682 freeing functions: if set, free the key and value if the slot
683 already exists. Always reassign the key.
684 (ctf_dynhash_insert): Adjust call appropriately.
685 (ctf_hash_insert_type): Likewise.
686
5de9eada
NA
6872019-08-03 Nick Alcock <nick.alcock@oracle.com>
688
689 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
690 type kind. Allow forwards to unify with pre-existing structs/
691 unions/enums.
692
49ea9b45
NA
6932019-07-30 Nick Alcock <nick.alcock@oracle.com>
694
695 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
696 <ctf_link_memb_name_changer>: Likewise.
697 <ctf_link_memb_name_changer_arg>: Likewise.
698 * ctf-create.c (ctf_update): Update accordingly.
699 * ctf-open.c (ctf_file_close): Likewise.
700 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
701 (ctf_link_add_cu_mapping): New.
702 (ctf_link_set_memb_name_changer): Likewise.
703 (ctf_change_parent_name): New.
704 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
705 allocated by the caller's ctf_link_memb_name_changer.
706 <ndynames>: Likewise.
707 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
708 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
709 ctf_change_parent_name. Free any resulting names.
710
eabb7154
NA
7112019-07-13 Nick Alcock <nick.alcock@oracle.com>
712
713 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
714 (ctf_link_one_type): ... here, with parent-name setting added.
715 (check_variable): New.
716 (ctf_link_one_variable): Likewise.
717 (ctf_link_one_input_archive_member): Call it.
718 * ctf-error.c (_ctf_errlist): Updated with new errors.
719
886453cb
NA
7202019-07-13 Nick Alcock <nick.alcock@oracle.com>
721
722 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
723 (struct ctf_link_type_mapping_key): New.
724 (ctf_hash_type_mapping_key): Likewise.
725 (ctf_hash_eq_type_mapping_key): Likewise.
726 (ctf_add_type_mapping): Likewise.
727 (ctf_type_mapping): Likewise.
728 (ctf_dynhash_empty): Likewise.
729 * ctf-open.c (ctf_file_close): Update accordingly.
730 * ctf-create.c (ctf_update): Likewise.
731 (ctf_add_type): Populate the mapping.
732 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
733 (ctf_hash_eq_type_mapping_key): Check the key for equality.
734 (ctf_dynhash_insert): Fix comment typo.
735 (ctf_dynhash_empty): New.
736 * ctf-link.c (ctf_add_type_mapping): New.
737 (ctf_type_mapping): Likewise.
738 (empty_link_type_mapping): New.
739 (ctf_link_one_input_archive): Call it.
740
72c83edd
NA
7412019-07-13 Nick Alcock <nick.alcock@oracle.com>
742
743 * ctf-link.c: New file, linking of the string and type sections.
744 * Makefile.am (libctf_a_SOURCES): Add it.
745 * Makefile.in: Regenerate.
746
747 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
748 ctf_link_outputs.
749 * ctf-create.c (ctf_update): Update accordingly.
750 * ctf-open.c (ctf_file_close): Likewise.
751 * ctf-error.c (_ctf_errlist): Updated with new errors.
752
d18f9f16
NA
7532019-07-13 Nick Alcock <nick.alcock@oracle.com>
754
755 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
756
b4f0e09c
NA
7572019-07-13 Nick Alcock <nick.alcock@oracle.com>
758
759 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
760 ctf_type_iter.
761 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
762 (ctf_dump_format_type): Add non-root-type { } notation.
763 Add root flag to prototype.
764 (ctf_dump_label): Adjust accordingly.
765 (ctf_dump_objts): Likewise.
766 (ctf_dump_var): Likewise.
767
3dde2c91
NA
7682019-07-13 Nick Alcock <nick.alcock@oracle.com>
769
770 * ctf-create.c (ctf_compress_write): Fix double-free.
771
5537f9b9
NA
7722019-07-13 Nick Alcock <nick.alcock@oracle.com>
773
774 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
775 of...
776 (ctf_arc_write_fd): ... this new function.
777 * ctf-create.c (ctf_write_mem): New.
778
d851ecd3
NA
7792019-07-13 Nick Alcock <nick.alcock@oracle.com>
780
781 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
782 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
783 (ctf_str_add_ref): Name the last arg.
784 (ctf_str_add_external) New.
785 (ctf_str_add_strraw_explicit): Likewise.
786 (ctf_simple_open_internal): Likewise.
787 (ctf_bufopen_internal): Likewise.
788
789 * ctf-string.c (ctf_strraw_explicit): Split from...
790 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
791 (ctf_str_add_ref_internal): Return the atom, not the
792 string.
793 (ctf_str_add): Adjust accordingly.
794 (ctf_str_add_ref): Likewise. Move up in the file.
795 (ctf_str_add_external): New: update the csa_offset.
796 (ctf_str_count_strtab): Only account for strings with no csa_offset
797 in the internal strtab length.
798 (ctf_str_write_strtab): If the csa_offset is set, update the
799 string's refs without writing the string out, and update the
800 ctf_syn_ext_strtab. Make OOM handling less ugly.
801 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
802 (ctf_update): Handle failure to populate the strtab. Pass in the
803 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
804 Call ctf_simple_open_internal, not ctf_simple_open.
805 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
806 strings by hand.
807 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
808 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
809 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
810 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
811 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
812 (ctf_simple_open_internal): ... this new function, which calls
813 ctf_bufopen_internal.
814 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
815 (ctf_bufopen_internal): ... this new function, which sets
816 ctf_syn_ext_strtab.
817
0ac62312
NA
8182019-07-13 Nick Alcock <nick.alcock@oracle.com>
819
820 * ctf_types.c (ctf_type_iter_all): New.
821
2db912ba
NA
8222019-07-13 Nick Alcock <nick.alcock@oracle.com>
823
824 * ctf-open.c (init_symtab): Check for overflow against the right
825 section.
826 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
827 (upgrade_types_v1): Note that these sections are not checked.
828 (flip_header): Endian-swap the header fields.
829 (flip_ctf): Endian-swap the sections.
830 (flip_objts): Update comment.
831 (ctf_bufopen): Check header offsets and alignment for validity.
832
6d5944fc
NA
8332019-07-13 Nick Alcock <nick.alcock@oracle.com>
834
835 * ctf-open-bfd.c: Add <assert.h>.
836 (ctf_bfdopen_ctfsect): Open string and symbol tables using
837 techniques borrowed from bfd_elf_sym_name.
838 (ctf_new_archive_internal): Improve comment.
839 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
840 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
841 no symbol section, but not vice versa.
842
9b32cba4
NA
8432019-07-08 Nick Alcock <nick.alcock@oracle.com>
844
845 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
846 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
847 * ctf-dump.c (dump_header): New function, dump the CTF header.
848 (ctf_dump): Call it.
849 (ctf_dump_header_strfield): New function.
850 (ctf_dump_header_sectfield): Likewise.
851
fd55eae8
NA
8522019-07-06 Nick Alcock <nick.alcock@oracle.com>
853
854 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
855 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
856 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
857 ctf_base: do not assume that it is always sizeof (ctf_header_t).
858 Print out ctf_cuname: only print out ctf_parname if set.
859 (ctf_free_base): Removed, ctf_base is no longer freed: free
860 ctf_dynbase instead.
861 (ctf_set_version): Fix spacing.
862 (upgrade_header): New, in-place header upgrading.
863 (upgrade_types): Rename to...
864 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
865 longer track old and new headers separately. No longer allow for
866 header sizes explicitly: squeeze the headers out on upgrade (they
867 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
868 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
869 (upgrade_types): New, also handle ctf_parmax updating.
870 (flip_header): Flip ctf_cuname.
871 (flip_types): Flip BUF explicitly rather than deriving BUF from
872 BASE.
873 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
874 required alignment of objtoff and funcoff. No longer store it in
875 the ctf_buf unless that buf is derived unmodified from the input.
876 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
877 that duplicate fields in ctf_file: move allocation of ctf_file
878 further up instead. Call upgrade_header as needed. Move
879 version-specific ctf_parmax initialization into upgrade_types. More
880 concise error handling.
881 (ctf_file_close): No longer test for null pointers before freeing.
882 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
883 ctf_free_base.
884 (ctf_cuname): New.
885 (ctf_cuname_set): New.
886 * ctf-create.c (ctf_update): Populate ctf_cuname.
887 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
888 comment.
889 (ctf_write): Likewise.
890 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
891 Fix the compression length: fp->ctf_size never counted the CTF
892 header. Simplify the compress call accordingly.
893
a2230b5e
HPN
8942019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
895
896 * ctf-endian.h: Don't assume htole64 and le64toh are always
897 present if HAVE_ENDIAN_H; also check if htole64 is defined.
898 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
899 not bswap_identity_64.
900
fd361982
AM
9012019-09-18 Alan Modra <amodra@gmail.com>
902
903 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
904
60391a25
PB
9052019-09-09 Phil Blundell <pb@pbcl.net>
906
907 binutils 2.33 branch created.
908
12a0b67d
NA
9092019-07-18 Nick Alcock <nick.alcock@oracle.com>
910
911 * ctf-types.c (ctf_type_aname_raw): New.
912 (ctf_func_type_info): Likewise.
913 (ctf_func_type_args): Likewise.
914 * ctf-error.c (_ctf_errlist): Fix description.
915 * ctf-lookup.c: Fix file description.
916
083114f8 9172019-06-28 Nick Alcock <nick.alcock@oracle.com>
f57cf0e3
NA
918
919 * ctf-create.c (ctf_create): Fix off-by-one error.
920
083114f8 9212019-06-28 Nick Alcock <nick.alcock@oracle.com>
f5e9c9bd
NA
922
923 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
924 struct ctf_strs.
925 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
926 (struct ctf_str_atom): New, disambiguated single string.
927 (struct ctf_str_atom_ref): New, points to some other location that
928 references this string's offset.
929 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
930 Remove member ctf_dtvstrlen: we no longer track the total strlen
931 as we add strings.
932 (ctf_str_create_atoms): Declare new function in ctf-string.c.
933 (ctf_str_free_atoms): Likewise.
934 (ctf_str_add): Likewise.
935 (ctf_str_add_ref): Likewise.
936 (ctf_str_rollback): Likewise.
937 (ctf_str_purge_refs): Likewise.
938 (ctf_str_write_strtab): Likewise.
939 (ctf_realloc): Declare new function in ctf-util.c.
940
941 * ctf-open.c (ctf_bufopen): Create the atoms table.
942 (ctf_file_close): Destroy it.
943 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
944 special-case the position of the parname string. Construct the
945 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
946 rest of each buffer element is constructed, not via open-coding:
947 realloc the CTF buffer and append the strtab to it. No longer
948 maintain ctf_dtvstrlen. Sort the variable entry table later, after
949 strtab construction.
950 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
951 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
952 after buffer element construction instead.
953 (ctf_copy_lmembers): Likewise.
954 (ctf_copy_emembers): Likewise.
955 (ctf_create): No longer maintain the ctf_dtvstrlen.
956 (ctf_dtd_delete): Likewise.
957 (ctf_dvd_delete): Likewise.
958 (ctf_add_generic): Likewise.
959 (ctf_add_enumerator): Likewise.
960 (ctf_add_member_offset): Likewise.
961 (ctf_add_variable): Likewise.
962 (membadd): Likewise.
963 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
964 if there are active ctf_str_num_refs.
965 (ctf_strraw): Move to ctf-string.c.
966 (ctf_strptr): Likewise.
967 * ctf-string.c: New file, strtab manipulation.
968
969 * Makefile.am (libctf_a_SOURCES): Add it.
970 * Makefile.in: Regenerate.
971
083114f8 9722019-06-28 Nick Alcock <nick.alcock@oracle.com>
9658dc39
NA
973
974 * ctf-impl.h (ctf_hash_iter_f): New.
975 (ctf_dynhash_iter): New declaration.
976 (ctf_dynhash_iter_remove): New declaration.
977 * ctf-hash.c (ctf_dynhash_iter): Define.
978 (ctf_dynhash_iter_remove): Likewise.
979 (ctf_hashtab_traverse): New.
980 (ctf_hashtab_traverse_remove): Likewise.
981 (struct ctf_traverse_cb_arg): Likewise.
982 (struct ctf_traverse_remove_cb_arg): Likewise.
983
083114f8 9842019-06-28 Nick Alcock <nick.alcock@oracle.com>
3e10cffc
NA
985
986 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
987
083114f8 9882019-06-28 Nick Alcock <nick.alcock@oracle.com>
c550e7ba
NA
989
990 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
991 (ctf_dump_funcs): Likewise.
992
083114f8 9932019-06-19 Nick Alcock <nick.alcock@oracle.com>
cf02c44d
NA
994
995 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
996 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
997 little-endian CTF archive magic. Do not check the CTF version:
998 ctf_simple_open does that in endian-safe ways. Do not dereference
999 null pointers on open failure.
1000
083114f8 10012019-06-19 Nick Alcock <nick.alcock@oracle.com>
7cee1826
NA
1002
1003 * ctf-open.c (get_vbytes_common): Return the new slice size.
1004 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1005 Remember to copy in the CTF data when opening an uncompressed
1006 foreign-endian CTF file. Prune useless variable manipulation.
1007
083114f8 10082019-06-19 Nick Alcock <nick.alcock@oracle.com>
0b4fa56e
NA
1009
1010 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1011 seen.
1012
083114f8 10132019-06-19 Nick Alcock <nick.alcock@oracle.com>
364620bf
NA
1014
1015 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1016 output.
1017
083114f8 10182019-06-19 Nick Alcock <nick.alcock@oracle.com>
65365aa8
NA
1019
1020 * ctf-subr.c (_PAGESIZE): Remove.
1021 (ctf_data_alloc): Likewise.
1022 (ctf_data_free): Likewise.
1023 (ctf_data_protect): Likewise.
1024 * ctf-impl.h: Remove declarations.
1025 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1026 ctf_free, not ctf_data_free.
1027 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
1028 the buffer again on compression error.
1029 * ctf-open.c (ctf_set_base): No longer track the size: call
1030 ctf_free, not ctf_data_free.
1031 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
1032 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
1033
083114f8 10342019-06-19 Nick Alcock <nick.alcock@oracle.com>
24865428
NA
1035
1036 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1037 ctf_dynhash_insert.
1038 (ctf_dvd_insert): Likewise.
1039 (ctf_add_generic): Likewise.
1040 (ctf_add_variable): Likewise.
1041 * ctf-impl.h: Adjust declarations.
1042
3a3a077c
AM
10432019-06-14 Alan Modra <amodra@gmail.com>
1044
1045 * configure: Regenerate.
1046
942d35f7
NA
10472019-06-06 Nick Alcock <nick.alcock@oracle.com>
1048
1049 * ctf-decls.h: Include <libiberty.h>.
1050 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1051
595a4d43
NA
10522019-06-06 Nick Alcock <nick.alcock@oracle.com>
1053
1054 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1055 (ctf_dump_objts): Likewise.
1056 (ctf_dump_funcs): Likewise.
1057 (ctf_dump_member): Likewise.
1058 (ctf_dump_str): Likewise.
1059
f5e73be1
NA
10602019-06-06 Nick Alcock <nick.alcock@oracle.com>
1061
1062 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1063 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1064
62d8e3b7
NA
10652019-06-05 Nick Alcock <nick.alcock@oracle.com>
1066
1067 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1068 (ctf_arc_open_by_offset): Likewise.
1069 * ctf-create.c (ctf_add_type): Likewise.
1070
76fad999
TT
10712019-06-04 Tom Tromey <tromey@adacore.com>
1072
1073 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1074 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1075
ad118caa
NA
10762019-06-04 Nick Alcock <nick.alcock@oracle.com>
1077
1078 * configure.ac: Check for O_CLOEXEC.
1079 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1080 * config.h.in: Regenerate.
1081 * configure: Likewise.
1082
6b22174f
NA
10832019-06-04 Nick Alcock <nick.alcock@oracle.com>
1084
1085 * qsort_r.c: Rename to...
1086 * ctf-qsort_r.c: ... this.
1087 (_quicksort): Define to ctf_qsort_r.
1088 * ctf-decls.h (qsort_r): Remove.
1089 (ctf_qsort_r): Add.
1090 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1091 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1092 * Makefile.am (libctf_a_LIBADD): Remove.
1093 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1094 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1095 * ctf-create.c (ctf_update): Likewise.
1096 * configure.ac: Check for BSD versus GNU qsort_r signature.
1097 * Makefile.in: Regenerate.
1098 * config.h.in: Likewise.
1099 * configure: Likewise.
1100
941accce
NA
11012019-06-03 Nick Alcock <nick.alcock@oracle.com>
1102
1103 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1104
a0486bac
JM
11052019-05-29 Nick Alcock <nick.alcock@oracle.com>
1106
1107 * Makefile.am (ZLIB): New.
1108 (ZLIBINC): Likewise.
1109 (AM_CFLAGS): Use them.
1110 (libctf_a_LIBADD): New, for LIBOBJS.
1111 * configure.ac: Check for zlib, endian.h, and qsort_r.
1112 * ctf-endian.h: New, providing htole64 and le64toh.
1113 * swap.h: Code style fixes.
1114 (bswap_identity_64): New.
1115 * qsort_r.c: New, from gnulib (with one added #include).
1116 * ctf-decls.h: New, providing a conditional qsort_r declaration,
1117 and unconditional definitions of MIN and MAX.
1118 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
1119 (ctf_set_errno): Now returns unsigned long.
1120 * ctf-util.c (ctf_set_errno): Adjust here too.
1121 * ctf-archive.c: Use ctf-endian.h.
1122 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
1123 cts_flags and cts_offset.
1124 (ctf_arc_write): Drop debugging dependent on the size of off_t.
1125 * ctf-create.c: Provide a definition of roundup if not defined.
1126 (ctf_create): Drop cts_type, cts_flags and cts_offset.
1127 (ctf_add_reftype): Do not check if type IDs are below zero.
1128 (ctf_add_slice): Likewise.
1129 (ctf_add_typedef): Likewise.
1130 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1131 when known error-free. Drop CTF_ERR usage for functions returning
1132 int.
1133 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1134 int.
1135 (ctf_add_variable): Likewise.
1136 (enumcmp): Likewise.
1137 (enumadd): Likewise.
1138 (membcmp): Likewise.
1139 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
1140 when known error-free.
1141 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1142 returning int: use CTF_ERR for functions returning ctf_type_id.
1143 (ctf_dump_label): Likewise.
1144 (ctf_dump_objts): Likewise.
1145 * ctf-labels.c (ctf_label_topmost): Likewise.
1146 (ctf_label_iter): Likewise.
1147 (ctf_label_info): Likewise.
1148 * ctf-lookup.c (ctf_func_args): Likewise.
1149 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1150 (ctf_bufopen): Likewise. Use zlib types as needed.
1151 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1152 returning int.
1153 (ctf_enum_iter): Likewise.
1154 (ctf_type_size): Likewise.
1155 (ctf_type_align): Likewise. Cast to size_t where appropriate.
1156 (ctf_type_kind_unsliced): Likewise.
1157 (ctf_type_kind): Likewise.
1158 (ctf_type_encoding): Likewise.
1159 (ctf_member_info): Likewise.
1160 (ctf_array_info): Likewise.
1161 (ctf_enum_value): Likewise.
1162 (ctf_type_rvisit): Likewise.
1163 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1164 cts_offset.
1165 (ctf_simple_open): Likewise.
1166 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
1167 * Makefile.in: Regenerate.
1168 * aclocal.m4: Likewise.
1169 * config.h: Likewise.
1170 * configure: Likewise.
1171
9698cf9b
NA
11722019-05-28 Nick Alcock <nick.alcock@oracle.com>
1173
1174 * configure.in: Check for bfd_section_from_elf_index.
1175 * configure: Regenerate.
1176 * config.h.in [HAVE_BFD_ELF]: Likewise.
1177 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1178 abfd is potentially unused now.
1179
0e65dfba
NA
11802019-05-28 Nick Alcock <nick.alcock@oracle.com>
1181
1182 * Makefile.am: New.
1183 * Makefile.in: Regenerated.
1184 * config.h.in: Likewise.
1185 * aclocal.m4: Likewise.
1186 * configure: Likewise.
1187
a30b3e18
NA
11882019-05-28 Nick Alcock <nick.alcock@oracle.com>
1189
1190 * ctf-dump.c: New.
1191
6dbf2b73
NA
11922019-05-28 Nick Alcock <nick.alcock@oracle.com>
1193
1194 * ctf-labels.c: New.
1195
6c33b742
NA
11962019-05-28 Nick Alcock <nick.alcock@oracle.com>
1197
1198 * ctf-impl.h (_libctf_version): New declaration.
1199 * ctf-subr.c (_libctf_version): Define it.
1200 (ctf_version): New.
1201
c499eb68
NA
12022019-05-28 Nick Alcock <nick.alcock@oracle.com>
1203
1204 * ctf-create.c (enumcmp): New.
1205 (enumadd): Likewise.
1206 (membcmp): Likewise.
1207 (membadd): Likewise.
1208 (ctf_add_type): Likewise.
1209
b437bfe0
NA
12102019-05-28 Nick Alcock <nick.alcock@oracle.com>
1211
1212 * ctf-lookup.c (isqualifier): New.
1213 (ctf_lookup_by_name): Likewise.
1214 (struct ctf_lookup_var_key): Likewise.
1215 (ctf_lookup_var): Likewise.
1216 (ctf_lookup_variable): Likewise.
1217 (ctf_lookup_symbol_name): Likewise.
1218 (ctf_lookup_by_symbol): Likewise.
1219 (ctf_func_info): Likewise.
1220 (ctf_func_args): Likewise.
1221
316afdb1
NA
12222019-05-28 Nick Alcock <nick.alcock@oracle.com>
1223
1224 * ctf-decl.c: New file.
1225 * ctf-types.c: Likewise.
1226 * ctf-impl.h: New declarations.
1227
143dce84
NA
12282019-05-28 Nick Alcock <nick.alcock@oracle.com>
1229
1230 * ctf-open-bfd.c: New file.
1231 * ctf-open.c (ctf_close): New.
1232 * ctf-impl.h: Include bfd.h.
1233 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1234 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1235 ctfi_bfd_close.
1236 (ctf_bfdopen_ctfsect): New declaration.
1237 (_CTF_SECTION): likewise.
1238
9402cc59
NA
12392019-05-28 Nick Alcock <nick.alcock@oracle.com>
1240
1241 * ctf-archive.c: New.
1242 * ctf-impl.h (ctf_archive_internal): New type.
1243 (ctf_arc_open_internal): New declaration.
1244 (ctf_arc_bufopen): Likewise.
1245 (ctf_arc_close_internal): Likewise.
1246
72f33921
NA
12472019-05-28 Nick Alcock <nick.alcock@oracle.com>
1248
1249 * ctf-open.c: New file.
1250 * swap.h: Likewise.
1251
47d546f4
NA
12522019-05-28 Nick Alcock <nick.alcock@oracle.com>
1253
1254 * ctf-create.c: New file.
1255 * ctf-lookup.c: New file.
1256
a5be9bbe
NA
12572019-05-28 Nick Alcock <nick.alcock@oracle.com>
1258
1259 * ctf-impl.h: New definitions and declarations for type creation
1260 and lookup.
1261
c0754cdd
NA
12622019-05-28 Nick Alcock <nick.alcock@oracle.com>
1263
1264 * ctf-hash.c: New file.
1265 * ctf-impl.h: New declarations.
1266
479604f4
NA
12672019-05-28 Nick Alcock <nick.alcock@oracle.com>
1268
1269 * ctf-error.c: New file.
1270
94585e7f
NA
12712019-05-28 Nick Alcock <nick.alcock@oracle.com>
1272
1273 * ctf-util.c: New file.
1274 * elf.h: Likewise.
1275 * ctf-impl.h: Include it, and add declarations.
1276
60da9d95
NA
12772019-05-28 Nick Alcock <nick.alcock@oracle.com>
1278
1279 * ctf-impl.h: New file.
1280 * ctf-subr.c: New file.
1281
1282\f
1283Local Variables:
1284mode: change-log
1285left-margin: 8
1286fill-column: 76
1287version-control: never
1288End: