]>
git.ipfire.org Git - thirdparty/mdadm.git/blob - Incremental.c
2 * Incremental.c - support --incremental. Part of:
3 * mdadm - manage Linux "md" devices aka RAID arrays.
5 * Copyright (C) 2006-2013 Neil Brown <neilb@suse.de>
8 * This program is free software; you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or
11 * (at your option) any later version.
13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details.
18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software
20 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
23 * Email: <neilb@suse.de>
27 * QVB Post Office, NSW 1230
36 static int count_active(struct supertype
*st
, struct mdinfo
*sra
,
37 int mdfd
, char **availp
,
39 static void find_reject(int mdfd
, struct supertype
*st
, struct mdinfo
*sra
,
40 int number
, __u64 events
, int verbose
,
42 static int try_spare(char *devname
, int *dfdp
, struct dev_policy
*pol
,
43 struct map_ent
*target
,
44 struct supertype
*st
, int verbose
);
46 static int Incremental_container(struct supertype
*st
, char *devname
,
47 struct context
*c
, char *only
);
49 int Incremental(struct mddev_dev
*devlist
, struct context
*c
,
52 /* Add this device to an array, creating the array if necessary
53 * and starting the array if sensible or - if runstop>0 - if possible.
55 * This has several steps:
57 * 1/ Check if device is permitted by mdadm.conf, reject if not.
58 * 2/ Find metadata, reject if none appropriate (check
59 * version/name from args)
60 * 3/ Check if there is a match in mdadm.conf
61 * 3a/ if not, check for homehost match. If no match, assemble as
63 * 4/ Determine device number.
64 * - If in mdadm.conf with std name, use that
65 * - UUID in /var/run/mdadm.map use that
66 * - If name is suggestive, use that. unless in use with different uuid.
67 * - Choose a free, high number.
68 * - Use a partitioned device unless strong suggestion not to.
70 * Don't choose partitioned for containers.
71 * 5/ Find out if array already exists
73 * - choose a name, from mdadm.conf or 'name' field in array.
77 * - check one drive in array to make sure metadata is a reasonably
78 * close match. Reject if not (e.g. different type)
80 * 6/ Make sure /var/run/mdadm.map contains this array.
81 * 7/ Is there enough devices to possibly start the array?
82 * For a container, this means running Incremental_container.
83 * 7a/ if not, finish with success.
85 * - read all metadata and arrange devices like -A does
86 * - if number of OK devices match expected, or -R and there are enough,
87 * start the array (auto-readonly).
90 struct mdinfo info
, dinfo
;
91 struct mdinfo
*sra
= NULL
, *d
;
92 struct mddev_ident
*match
;
93 char chosen_name
[1024];
96 struct map_ent
*mp
, *map
= NULL
;
97 int dfd
= -1, mdfd
= -1;
102 struct dev_policy
*policy
= NULL
;
103 struct map_ent target_array
;
105 char *devname
= devlist
->devname
;
106 int journal_device_missing
= 0;
108 struct createinfo
*ci
= conf_get_create_info();
110 if (!stat_is_blkdev(devname
, &rdev
))
112 dfd
= dev_open(devname
, O_RDONLY
);
115 pr_err("cannot open %s: %s.\n",
116 devname
, strerror(errno
));
119 /* If the device is a container, we do something very different */
120 if (must_be_container(dfd
)) {
122 st
= super_by_fd(dfd
, NULL
);
123 if (st
&& st
->ss
->load_container
)
124 rv
= st
->ss
->load_container(st
, dfd
, NULL
);
127 if (!rv
&& st
->ss
->container_content
) {
129 pr_err("failed to get exclusive lock on mapfile\n");
131 printf("MD_DEVNAME=%s\n", devname
);
132 rv
= Incremental_container(st
, devname
, c
, NULL
);
137 pr_err("%s is not part of an md array.\n",
142 /* 1/ Check if device is permitted by mdadm.conf */
144 for (;devlist
; devlist
= devlist
->next
)
145 if (conf_test_dev(devlist
->devname
))
148 devlist
= conf_get_devs();
149 for (;devlist
; devlist
= devlist
->next
) {
150 if (stat_is_blkdev(devlist
->devname
, &rdev2
) &&
157 pr_err("%s not permitted by mdadm.conf.\n",
162 /* 2/ Find metadata, reject if none appropriate (check
163 * version/name from args) */
165 if (!fstat_is_blkdev(dfd
, devname
, &rdev
))
168 dinfo
.disk
.major
= major(rdev
);
169 dinfo
.disk
.minor
= minor(rdev
);
171 policy
= disk_policy(&dinfo
);
172 have_target
= policy_check_path(&dinfo
, &target_array
);
174 if (st
== NULL
&& (st
= guess_super_type(dfd
, guess_array
)) == NULL
) {
176 pr_err("no recognisable superblock on %s.\n",
178 rv
= try_spare(devname
, &dfd
, policy
,
179 have_target
? &target_array
: NULL
,
183 st
->ignore_hw_compat
= 0;
185 if (st
->ss
->compare_super
== NULL
||
186 st
->ss
->load_super(st
, dfd
, c
->verbose
>= 0 ? devname
: NULL
)) {
188 pr_err("no RAID superblock on %s.\n",
190 rv
= try_spare(devname
, &dfd
, policy
,
191 have_target
? &target_array
: NULL
,
196 close (dfd
); dfd
= -1;
198 st
->ss
->getinfo_super(st
, &info
, NULL
);
200 /* 3/ Check if there is a match in mdadm.conf */
201 match
= conf_match(st
, &info
, devname
, c
->verbose
, &rv
);
202 if (!match
&& rv
== 2)
205 if (match
&& match
->devname
&& is_devname_ignore(match
->devname
) == true) {
207 pr_err("array containing %s is explicitly ignored by mdadm.conf\n",
212 /* 3a/ if not, check for homehost match. If no match, continue
213 * but don't trust the 'name' in the array. Thus a 'random' minor
214 * number will be assigned, and the device name will be based
218 else if (st
->ss
->match_home(st
, c
->homehost
) == 1)
220 else if (st
->ss
->match_home(st
, "any") == 1)
221 trustworthy
= LOCAL_ANY
;
223 trustworthy
= FOREIGN
;
225 if (!match
&& !conf_test_metadata(st
->ss
->name
, policy
,
226 (trustworthy
== LOCAL
))) {
228 pr_err("%s has metadata type %s for which auto-assembly is disabled\n",
229 devname
, st
->ss
->name
);
232 if (trustworthy
== LOCAL_ANY
)
235 /* There are three possible sources for 'autof': command line,
236 * ARRAY line in mdadm.conf, or CREATE line in mdadm.conf.
237 * ARRAY takes precedence, then command line, then
240 if (match
&& match
->autof
)
241 c
->autof
= match
->autof
;
243 c
->autof
= ci
->autof
;
245 name_to_use
= info
.name
;
246 if (name_to_use
[0] == 0 && is_container(info
.array
.level
)) {
247 name_to_use
= info
.text_version
;
248 trustworthy
= METADATA
;
250 if (name_to_use
[0] && trustworthy
!= LOCAL
&&
251 ! c
->require_homehost
&&
252 conf_name_is_free(name_to_use
))
255 /* strip "hostname:" prefix from name if we have decided
256 * to treat it as LOCAL
258 if (trustworthy
== LOCAL
&& strchr(name_to_use
, ':') != NULL
)
259 name_to_use
= strchr(name_to_use
, ':')+1;
261 /* 4/ Check if array exists.
264 pr_err("failed to get exclusive lock on mapfile\n");
265 /* Now check we can get O_EXCL. If not, probably "mdadm -A" has
268 dfd
= dev_open(devname
, O_RDONLY
|O_EXCL
);
271 pr_err("cannot reopen %s: %s.\n",
272 devname
, strerror(errno
));
275 /* Cannot hold it open while we add the device to the array,
276 * so we must release the O_EXCL and depend on the map_lock()
277 * So now is the best time to remove any partitions.
279 remove_partitions(dfd
);
283 mp
= map_by_uuid(&map
, info
.uuid
);
285 mdfd
= open_dev(mp
->devnm
);
291 /* Skip the clustered ones. This should be started by
292 * clustering resource agents
294 if (info
.array
.state
& (1 << MD_SB_CLUSTERED
))
297 /* Couldn't find an existing array, maybe make a new one */
298 mdfd
= create_mddev(match
? match
->devname
: NULL
,
299 name_to_use
, c
->autof
, trustworthy
, chosen_name
, 0);
304 if (sysfs_init(&info
, mdfd
, NULL
)) {
305 pr_err("unable to initialize sysfs for %s\n",
311 if (set_array_info(mdfd
, st
, &info
) != 0) {
312 pr_err("failed to set array info for %s: %s\n",
313 chosen_name
, strerror(errno
));
319 dinfo
.disk
.major
= major(rdev
);
320 dinfo
.disk
.minor
= minor(rdev
);
321 if (add_disk(mdfd
, st
, &info
, &dinfo
) != 0) {
322 pr_err("failed to add %s to new array %s: %s.\n",
323 devname
, chosen_name
, strerror(errno
));
324 ioctl(mdfd
, STOP_ARRAY
, 0);
328 sra
= sysfs_read(mdfd
, NULL
, (GET_DEVS
| GET_STATE
|
329 GET_OFFSET
| GET_SIZE
));
331 if (!sra
|| !sra
->devs
|| sra
->devs
->disk
.raid_disk
>= 0) {
332 /* It really should be 'none' - must be old buggy
333 * kernel, and mdadm -I may not be able to complete.
336 ioctl(mdfd
, STOP_ARRAY
, NULL
);
337 pr_err("You have an old buggy kernel which cannot support\n --incremental reliably. Aborting.\n");
341 info
.array
.working_disks
= 1;
342 /* 6/ Make sure /var/run/mdadm.map contains this array. */
343 map_update(&map
, fd2devnm(mdfd
),
345 info
.uuid
, chosen_name
);
348 /* - check one drive in array to make sure metadata is a reasonably */
349 /* close match. Reject if not (e.g. different type) */
350 /* - add the device */
354 struct supertype
*st2
;
355 struct mdinfo info2
, *d
;
357 sra
= sysfs_read(mdfd
, NULL
, (GET_DEVS
| GET_STATE
|
358 GET_OFFSET
| GET_SIZE
));
361 strcpy(chosen_name
, mp
->path
);
363 strcpy(chosen_name
, mp
->devnm
);
365 /* It is generally not OK to add non-spare drives to a
366 * running array as they are probably missing because
367 * they failed. However if runstop is 1, then the
368 * array was possibly started early and our best bet is
369 * to add this anyway.
370 * Also if action policy is re-add or better we allow
372 * This doesn't apply to containers as the 'non-spare'
373 * flag has a different meaning. The test has to happen
374 * at the device level there
376 if (!st
->ss
->external
&&
377 (info
.disk
.state
& (1 << MD_DISK_SYNC
)) != 0 &&
378 !policy_action_allows(policy
, st
->ss
->name
, act_re_add
) &&
380 if (md_array_active(mdfd
)) {
381 pr_err("not adding %s to active array (without --run) %s\n",
382 devname
, chosen_name
);
392 sprintf(dn
, "%d:%d", sra
->devs
->disk
.major
,
393 sra
->devs
->disk
.minor
);
394 dfd2
= dev_open(dn
, O_RDONLY
);
396 pr_err("unable to open %s\n", devname
);
401 if (st2
->ss
->load_super(st2
, dfd2
, NULL
) ||
402 st
->ss
->compare_super(st
, st2
, 1) != 0) {
403 pr_err("metadata mismatch between %s and chosen array %s\n",
404 devname
, chosen_name
);
410 st2
->ss
->getinfo_super(st2
, &info2
, NULL
);
411 st2
->ss
->free_super(st2
);
412 if (info
.array
.level
!= info2
.array
.level
||
413 memcmp(info
.uuid
, info2
.uuid
, 16) != 0 ||
414 info
.array
.raid_disks
!= info2
.array
.raid_disks
) {
415 pr_err("unexpected difference between %s and %s.\n",
416 chosen_name
, devname
);
421 info
.disk
.major
= major(rdev
);
422 info
.disk
.minor
= minor(rdev
);
423 /* add disk needs to know about containers */
424 if (st
->ss
->external
)
425 sra
->array
.level
= LEVEL_CONTAINER
;
427 if (info
.array
.state
& (1 << MD_SB_CLUSTERED
))
428 info
.disk
.state
|= (1 << MD_DISK_CLUSTER_ADD
);
430 err
= add_disk(mdfd
, st
, sra
, &info
);
431 if (err
< 0 && errno
== EBUSY
) {
432 /* could be another device present with the same
433 * disk.number. Find and reject any such
435 find_reject(mdfd
, st
, sra
, info
.disk
.number
,
436 info
.events
, c
->verbose
, chosen_name
);
437 err
= add_disk(mdfd
, st
, sra
, &info
);
439 if (err
< 0 && errno
== EINVAL
&&
440 info
.disk
.state
& (1<<MD_DISK_SYNC
)) {
441 /* Maybe it needs to be added as a spare */
442 if (policy_action_allows(policy
, st
->ss
->name
,
444 info
.disk
.state
&= ~(1<<MD_DISK_SYNC
);
445 err
= add_disk(mdfd
, st
, sra
, &info
);
448 pr_err("can only add %s to %s as a spare, and force-spare is not set.\n",
449 devname
, chosen_name
);
452 pr_err("failed to add %s to existing array %s: %s.\n",
453 devname
, chosen_name
, strerror(errno
));
457 info
.array
.working_disks
= 0;
458 for (d
= sra
->devs
; d
; d
=d
->next
)
459 info
.array
.working_disks
++;
462 if (strncmp(chosen_name
, DEV_MD_DIR
, DEV_MD_DIR_LEN
) == 0)
463 md_devname
= chosen_name
+ DEV_MD_DIR_LEN
;
465 md_devname
= chosen_name
;
467 printf("MD_DEVICE=%s\n", fd2devnm(mdfd
));
468 printf("MD_DEVNAME=%s\n", md_devname
);
469 printf("MD_FOREIGN=%s\n", trustworthy
== FOREIGN
? "yes" : "no");
472 /* 7/ Is there enough devices to possibly start the array? */
473 /* 7a/ if not, finish with success. */
474 if (is_container(info
.array
.level
)) {
476 /* Try to assemble within the container */
477 sysfs_uevent(sra
, "change");
478 if (!c
->export
&& c
->verbose
>= 0)
479 pr_err("container %s now has %d device%s\n",
480 chosen_name
, info
.array
.working_disks
,
481 info
.array
.working_disks
== 1?"":"s");
482 sysfs_rules_apply(chosen_name
, &info
);
483 wait_for(chosen_name
, mdfd
);
484 if (st
->ss
->external
)
485 strcpy(devnm
, fd2devnm(mdfd
));
486 if (st
->ss
->load_container
)
487 rv
= st
->ss
->load_container(st
, mdfd
, NULL
);
491 rv
= Incremental_container(st
, chosen_name
, c
, NULL
);
493 /* after spare is added, ping monitor for external metadata
494 * so that it can eg. try to rebuild degraded array */
495 if (st
->ss
->external
)
500 /* We have added something to the array, so need to re-read the
501 * state. Eventually this state should be kept up-to-date as
505 sra
= sysfs_read(mdfd
, NULL
, (GET_DEVS
| GET_STATE
|
506 GET_OFFSET
| GET_SIZE
));
507 active_disks
= count_active(st
, sra
, mdfd
, &avail
, &info
);
512 journal_device_missing
= (info
.journal_device_required
) && (info
.journal_clean
== 0);
514 if (info
.consistency_policy
== CONSISTENCY_POLICY_PPL
)
515 info
.array
.state
|= 1;
517 if (enough(info
.array
.level
, info
.array
.raid_disks
,
518 info
.array
.layout
, info
.array
.state
& 1, avail
) == 0) {
520 printf("MD_STARTED=no\n");
521 } else if (c
->verbose
>= 0)
522 pr_err("%s attached to %s, not enough to start (%d).\n",
523 devname
, chosen_name
, active_disks
);
529 /* - if number of OK devices match expected, or -R and there */
531 /* + add any bitmap file */
532 /* + start the array (auto-readonly). */
534 if (md_array_active(mdfd
)) {
536 printf("MD_STARTED=already\n");
537 } else if (c
->verbose
>= 0)
538 pr_err("%s attached to %s which is already active.\n",
539 devname
, chosen_name
);
545 if (c
->runstop
> 0 || (!journal_device_missing
&& active_disks
>= info
.array
.working_disks
)) {
547 /* Let's try to start it */
549 if (journal_device_missing
)
550 pr_err("Trying to run with missing journal device\n");
551 if (info
.reshape_active
&& !(info
.reshape_active
& RESHAPE_NO_BACKUP
)) {
552 pr_err("%s: This array is being reshaped and cannot be started\n",
554 cont_err("by --incremental. Please use --assemble\n");
557 if (match
&& match
->bitmap_file
) {
558 int bmfd
= open(match
->bitmap_file
, O_RDWR
);
560 pr_err("Could not open bitmap file %s.\n",
564 if (ioctl(mdfd
, SET_BITMAP_FILE
, bmfd
) != 0) {
566 pr_err("Failed to set bitmapfile for %s.\n",
572 /* Need to remove from the array any devices which
573 * 'count_active' discerned were too old or inappropriate
575 for (d
= sra
? sra
->devs
: NULL
; d
; d
= d
->next
)
576 if (d
->disk
.state
& (1<<MD_DISK_REMOVED
))
577 remove_disk(mdfd
, st
, sra
, d
);
579 if ((sra
== NULL
|| active_disks
>= info
.array
.working_disks
) &&
580 trustworthy
!= FOREIGN
)
581 rv
= ioctl(mdfd
, RUN_ARRAY
, NULL
);
583 rv
= sysfs_set_str(sra
, NULL
,
584 "array_state", "read-auto");
585 /* Array might be O_EXCL which will interfere with
586 * fsck and mount. So re-open without O_EXCL.
591 printf("MD_STARTED=yes\n");
592 } else if (c
->verbose
>= 0)
593 pr_err("%s attached to %s, which has been started.\n",
594 devname
, chosen_name
);
596 wait_for(chosen_name
, mdfd
);
597 /* We just started the array, so some devices
598 * might have been evicted from the array
599 * because their event counts were too old.
600 * If the action=re-add policy is in-force for
601 * those devices we should re-add them now.
603 for (dsk
= sra
->devs
; dsk
; dsk
= dsk
->next
) {
604 if (disk_action_allows(dsk
, st
->ss
->name
,
606 add_disk(mdfd
, st
, sra
, dsk
) == 0)
607 pr_err("%s re-added to %s\n",
608 dsk
->sys_name
, chosen_name
);
611 pr_err("%s attached to %s, but failed to start: %s.\n",
612 devname
, chosen_name
, strerror(errno
));
617 printf("MD_STARTED=unsafe\n");
618 } else if (journal_device_missing
) {
619 pr_err("Journal device is missing, not safe to start yet.\n");
620 } else if (c
->verbose
>= 0)
621 pr_err("%s attached to %s, not enough to start safely.\n",
622 devname
, chosen_name
);
632 dev_policy_free(policy
);
640 static void find_reject(int mdfd
, struct supertype
*st
, struct mdinfo
*sra
,
641 int number
, __u64 events
, int verbose
,
644 /* Find a device attached to this array with a disk.number of number
645 * and events less than the passed events, and remove the device.
649 if (md_array_active(mdfd
))
650 return; /* not safe to remove from active arrays
651 * without thinking more */
653 for (d
= sra
->devs
; d
; d
= d
->next
) {
654 char dn
[24]; // 2*11 bytes for ints (including sign) + colon + null byte
657 sprintf(dn
, "%d:%d", d
->disk
.major
, d
->disk
.minor
);
658 dfd
= dev_open(dn
, O_RDONLY
);
661 if (st
->ss
->load_super(st
, dfd
, NULL
)) {
665 st
->ss
->getinfo_super(st
, &info
, NULL
);
666 st
->ss
->free_super(st
);
669 if (info
.disk
.number
!= number
|| info
.events
>= events
)
672 if (d
->disk
.raid_disk
> -1)
673 sysfs_set_str(sra
, d
, "slot", STR_COMMON_NONE
);
674 if (sysfs_set_str(sra
, d
, "state", "remove") == 0)
676 pr_err("removing old device %s from %s\n",
677 d
->sys_name
+4, array_name
);
681 static int count_active(struct supertype
*st
, struct mdinfo
*sra
,
682 int mdfd
, char **availp
,
683 struct mdinfo
*bestinfo
)
685 /* count how many devices in sra think they are active */
689 __u64 max_events
= 0;
690 __u64 max_journal_events
= 0;
702 for (d
= sra
->devs
; d
; d
= d
->next
)
704 for (d
= sra
->devs
, devnum
= 0 ; d
; d
= d
->next
, devnum
++) {
710 sprintf(dn
, "%d:%d", d
->disk
.major
, d
->disk
.minor
);
711 dfd
= dev_open(dn
, O_RDONLY
);
714 ok
= st
->ss
->load_super(st
, dfd
, NULL
);
719 info
.array
.raid_disks
= raid_disks
;
720 st
->ss
->getinfo_super(st
, &info
, devmap
+ raid_disks
* devnum
);
721 if (info
.disk
.raid_disk
== MD_DISK_ROLE_JOURNAL
&&
722 info
.events
> max_journal_events
)
723 max_journal_events
= info
.events
;
725 raid_disks
= info
.array
.raid_disks
;
726 avail
= xcalloc(raid_disks
, 1);
729 best
= xcalloc(raid_disks
, sizeof(int));
730 devmap
= xcalloc(raid_disks
, numdevs
);
732 st
->ss
->getinfo_super(st
, &info
, devmap
);
735 if (info
.disk
.state
& (1<<MD_DISK_SYNC
))
739 max_events
= info
.events
;
740 avail
[info
.disk
.raid_disk
] = 2;
741 best
[info
.disk
.raid_disk
] = devnum
;
742 st
->ss
->getinfo_super(st
, bestinfo
, NULL
);
743 } else if (info
.events
== max_events
) {
744 avail
[info
.disk
.raid_disk
] = 2;
745 best
[info
.disk
.raid_disk
] = devnum
;
746 } else if (info
.events
== max_events
-1) {
747 if (avail
[info
.disk
.raid_disk
] == 0) {
748 avail
[info
.disk
.raid_disk
] = 1;
749 best
[info
.disk
.raid_disk
] = devnum
;
751 } else if (info
.events
< max_events
- 1)
753 else if (info
.events
== max_events
+1) {
755 max_events
= info
.events
;
756 for (i
= 0; i
< raid_disks
; i
++)
759 avail
[info
.disk
.raid_disk
] = 2;
760 best
[info
.disk
.raid_disk
] = devnum
;
761 st
->ss
->getinfo_super(st
, bestinfo
, NULL
);
762 } else { /* info.events much bigger */
763 memset(avail
, 0, raid_disks
);
764 max_events
= info
.events
;
765 avail
[info
.disk
.raid_disk
] = 2;
766 best
[info
.disk
.raid_disk
] = devnum
;
767 st
->ss
->getinfo_super(st
, bestinfo
, NULL
);
769 } else if (info
.disk
.state
& (1<<MD_DISK_REPLACEMENT
))
771 st
->ss
->free_super(st
);
773 if (max_journal_events
>= max_events
- 1)
774 bestinfo
->journal_clean
= 1;
778 /* We need to reject any device that thinks the best device is
779 * failed or missing */
780 for (b
= 0; b
< raid_disks
; b
++)
784 for (i
= 0 ; i
< raid_disks
; i
++) {
785 if (i
!= b
&& avail
[i
])
786 if (devmap
[raid_disks
* best
[i
] + b
] == 0) {
787 /* This device thinks 'b' is failed -
790 for (d
=sra
->devs
; devnum
; d
= d
->next
)
792 d
->disk
.state
|= (1 << MD_DISK_REMOVED
);
798 /* Also need to reject any spare device with an event count that
801 for (d
= sra
->devs
; d
; d
= d
->next
) {
802 if (!(d
->disk
.state
& (1<<MD_DISK_SYNC
)) &&
803 d
->events
> max_events
)
804 d
->disk
.state
|= (1 << MD_DISK_REMOVED
);
808 return cnt
+ replcnt
;
811 /* test if container has degraded member(s) */
813 container_members_max_degradation(struct map_ent
*map
, struct map_ent
*me
)
816 int degraded
, max_degraded
= 0;
818 for(; map
; map
= map
->next
) {
819 if (!metadata_container_matches(map
->metadata
, me
->devnm
))
821 /* most accurate information regarding array degradation */
822 sra
= sysfs_read(-1, map
->devnm
,
823 GET_DISKS
| GET_DEVS
| GET_STATE
);
826 degraded
= sra
->array
.raid_disks
- sra
->array
.active_disks
-
827 sra
->array
.spare_disks
;
828 if (degraded
> max_degraded
)
829 max_degraded
= degraded
;
836 static int array_try_spare(char *devname
, int *dfdp
, struct dev_policy
*pol
,
837 struct map_ent
*target
, int bare
,
838 struct supertype
*st
, int verbose
)
840 /* This device doesn't have any md metadata
841 * The device policy allows 'spare' and if !bare, it allows spare-same-slot.
842 * If 'st' is not set, then we only know that some metadata allows this,
843 * others possibly don't.
844 * So look for a container or array to attach the device to.
845 * Prefer 'target' if that is set and the array is found.
847 * If st is set, then only arrays of that type are considered
848 * Return 0 on success, or some exit code on failure, probably 1.
852 struct map_ent
*mp
, *map
= NULL
;
853 struct mdinfo
*chosen
= NULL
;
856 if (!fstat_is_blkdev(dfd
, devname
, &rdev
))
860 * Now we need to find a suitable array to add this to.
861 * We only accept arrays that:
863 * - are in the same domains as the device
864 * - are of an size for which the device will be useful
865 * and we choose the one that is the most degraded
868 if (map_lock(&map
)) {
869 pr_err("failed to get exclusive lock on mapfile\n");
872 for (mp
= map
; mp
; mp
= mp
->next
) {
873 struct supertype
*st2
;
874 struct domainlist
*dl
= NULL
;
876 unsigned long long devsize
, freesize
= 0;
877 struct spare_criteria sc
= {0, 0};
879 if (is_subarray(mp
->metadata
))
882 st2
= st
->ss
->match_metadata_desc(mp
->metadata
);
884 (st
->minor_version
>= 0 &&
885 st
->minor_version
!= st2
->minor_version
)) {
887 pr_err("not adding %s to %s as metadata type doesn't match\n",
894 sra
= sysfs_read(-1, mp
->devnm
,
895 GET_DEVS
|GET_OFFSET
|GET_SIZE
|GET_STATE
|
896 GET_COMPONENT
|GET_VERSION
);
898 sra
->array
.failed_disks
= -1;
904 for(i
= 0; !st2
&& superlist
[i
]; i
++)
905 st2
= superlist
[i
]->match_metadata_desc(
909 pr_err("not adding %s to %s as metadata not recognised.\n",
913 /* Need to double check the 'act_spare' permissions applies
916 if (!policy_action_allows(pol
, st2
->ss
->name
, act_spare
))
918 if (!bare
&& !policy_action_allows(pol
, st2
->ss
->name
,
919 act_spare_same_slot
))
923 /* update number of failed disks for mostly degraded
924 * container member */
925 if (sra
->array
.failed_disks
== -1)
926 sra
->array
.failed_disks
= container_members_max_degradation(map
, mp
);
928 get_dev_size(dfd
, NULL
, &devsize
);
929 if (sra
->component_size
== 0) {
930 /* true for containers, here we must read superblock
931 * to obtain minimum spare size */
932 struct supertype
*st3
= dup_super(st2
);
933 int mdfd
= open_dev(mp
->devnm
);
938 if (st3
->ss
->load_container
&&
939 !st3
->ss
->load_container(st3
, mdfd
, mp
->path
)) {
940 if (st3
->ss
->get_spare_criteria
)
941 st3
->ss
->get_spare_criteria(st3
, &sc
);
942 st3
->ss
->free_super(st3
);
947 if ((sra
->component_size
> 0 &&
948 st2
->ss
->validate_geometry(st2
, sra
->array
.level
, sra
->array
.layout
,
949 sra
->array
.raid_disks
, &sra
->array
.chunk_size
,
951 sra
->devs
? sra
->devs
->data_offset
: INVALID_SECTORS
,
952 devname
, &freesize
, sra
->consistency_policy
,
954 freesize
< sra
->component_size
) ||
955 (sra
->component_size
== 0 && devsize
< sc
.min_size
)) {
957 pr_err("not adding %s to %s as it is too small\n",
961 /* test against target.
962 * If 'target' is set and 'bare' is false, we only accept
963 * arrays/containers that match 'target'.
964 * If 'target' is set and 'bare' is true, we prefer the
965 * array which matches 'target'.
966 * target is considered only if we deal with degraded array
968 if (target
&& policy_action_allows(pol
, st2
->ss
->name
,
969 act_spare_same_slot
)) {
970 if (strcmp(target
->metadata
, mp
->metadata
) == 0 &&
971 memcmp(target
->uuid
, mp
->uuid
,
972 sizeof(target
->uuid
)) == 0 &&
973 sra
->array
.failed_disks
> 0) {
974 /* This is our target!! */
978 /* skip to end so we don't check any more */
988 dl
= domain_from_array(sra
, st2
->ss
->name
);
989 if (domain_test(dl
, pol
, st2
->ss
->name
) != 1) {
990 /* domain test fails */
992 pr_err("not adding %s to %s as it is not in a compatible domain\n",
997 /* all tests passed, OK to add to this array */
1001 } else if (chosen
->array
.failed_disks
< sra
->array
.failed_disks
) {
1014 /* add current device to chosen array as a spare */
1015 int mdfd
= open_dev(chosen
->sys_name
);
1017 struct mddev_dev devlist
;
1018 char chosen_devname
[24]; // 2*11 for int (including signs) + colon + null
1019 devlist
.next
= NULL
;
1021 devlist
.writemostly
= FlagDefault
;
1022 devlist
.failfast
= FlagDefault
;
1023 devlist
.devname
= chosen_devname
;
1024 sprintf(chosen_devname
, "%d:%d", major(rdev
),
1026 devlist
.disposition
= 'a';
1029 rv
= Manage_subdevs(chosen
->sys_name
, mdfd
, &devlist
,
1030 -1, 0, UOPT_UNDEFINED
, 0);
1035 pr_err("added %s as spare for %s\n",
1036 devname
, chosen
->sys_name
);
1038 pr_err("failed to add %s as spare for %s\n",
1039 devname
, chosen
->sys_name
);
1047 static int partition_try_spare(char *devname
, int *dfdp
, struct dev_policy
*pol
,
1048 struct supertype
*st
, int verbose
)
1050 /* we know that at least one partition virtual-metadata is
1051 * allowed to incorporate spares like this device. We need to
1052 * find a suitable device to copy partition information from.
1054 * Getting a list of all disk (not partition) devices is
1055 * slightly non-trivial. We could look at /sys/block, but
1056 * that is theoretically due to be removed. Maybe best to use
1057 * /dev/disk/by-path/?* and ignore names ending '-partNN' as
1058 * we depend on this directory of 'path' info. But that fails
1059 * to find loop devices and probably others. Maybe don't
1060 * worry about that, they aren't the real target.
1062 * So: check things in /dev/disk/by-path to see if they are in
1063 * a compatible domain, then load the partition table and see
1064 * if it is OK for the new device, and choose the largest
1065 * partition table that fits.
1069 char *chosen
= NULL
;
1070 unsigned long long chosen_size
= 0;
1071 struct supertype
*chosen_st
= NULL
;
1074 dir
= opendir("/dev/disk/by-path");
1077 while ((de
= readdir(dir
)) != NULL
) {
1079 struct dev_policy
*pol2
= NULL
;
1080 struct domainlist
*domlist
= NULL
;
1083 struct supertype
*st2
= NULL
;
1084 char *devname
= NULL
;
1085 unsigned long long devsectors
;
1088 if (de
->d_ino
== 0 || de
->d_name
[0] == '.' ||
1089 (de
->d_type
!= DT_LNK
&& de
->d_type
!= DT_UNKNOWN
))
1092 ep
= de
->d_name
+ strlen(de
->d_name
);
1093 while (ep
> de
->d_name
&&
1096 if (ep
> de
->d_name
+ 5 &&
1097 strncmp(ep
-5, "-part", 5) == 0)
1098 /* This is a partition - skip it */
1101 pathlist
[0] = de
->d_name
;
1103 pol2
= path_policy(pathlist
, type_disk
);
1105 domain_merge(&domlist
, pol2
, st
? st
->ss
->name
: NULL
);
1106 if (domain_test(domlist
, pol
, st
? st
->ss
->name
: NULL
) != 1)
1107 /* new device is incompatible with this device. */
1110 domain_free(domlist
);
1113 if (asprintf(&devname
, "/dev/disk/by-path/%s", de
->d_name
) != 1) {
1117 fd
= open(devname
, O_RDONLY
);
1120 if (get_dev_size(fd
, devname
, &devsectors
) == 0)
1125 st2
= dup_super(st
);
1127 st2
= guess_super_type(fd
, guess_partitions
);
1128 if (st2
== NULL
|| st2
->ss
->load_super(st2
, fd
, NULL
) < 0)
1130 st2
->ignore_hw_compat
= 0;
1133 /* Check domain policy again, this time referring to metadata */
1134 domain_merge(&domlist
, pol2
, st2
->ss
->name
);
1135 if (domain_test(domlist
, pol
, st2
->ss
->name
) != 1)
1136 /* Incompatible devices for this metadata type */
1138 if (!policy_action_allows(pol
, st2
->ss
->name
, act_spare
))
1139 /* Some partition types allow sparing, but not
1145 st2
->ss
->getinfo_super(st2
, &info
, NULL
);
1146 if (info
.component_size
> devsectors
)
1147 /* This partitioning doesn't fit in the device */
1150 /* This is an acceptable device to copy partition
1151 * metadata from. We could just stop here, but I
1152 * think I want to keep looking incase a larger
1153 * metadata which makes better use of the device can
1156 if (chosen
== NULL
|| chosen_size
< info
.component_size
) {
1157 chosen_size
= info
.component_size
;
1162 chosen_st
->ss
->free_super(chosen_st
);
1171 domain_free(domlist
);
1172 dev_policy_free(pol2
);
1174 st2
->ss
->free_super(st2
);
1186 /* 'chosen' is the best device we can find. Let's write its
1187 * metadata to devname dfd is read-only so don't use that
1189 fd
= open(devname
, O_RDWR
);
1191 chosen_st
->ss
->store_super(chosen_st
, fd
);
1195 chosen_st
->ss
->free_super(chosen_st
);
1200 static int is_bare(int dfd
)
1202 unsigned long long size
= 0;
1203 char bufpad
[4096 + 4096];
1204 char *buf
= (char*)(((long)bufpad
+ 4096) & ~4095);
1206 if (lseek(dfd
, 0, SEEK_SET
) != 0 ||
1207 read(dfd
, buf
, 4096) != 4096)
1210 if (buf
[0] != '\0' && buf
[0] != '\x5a' && buf
[0] != '\xff')
1212 if (memcmp(buf
, buf
+1, 4095) != 0)
1215 /* OK, first 4K appear blank, try the end. */
1216 get_dev_size(dfd
, NULL
, &size
);
1217 if (lseek(dfd
, size
-4096, SEEK_SET
) < 0 ||
1218 read(dfd
, buf
, 4096) != 4096)
1221 if (buf
[0] != '\0' && buf
[0] != '\x5a' && buf
[0] != '\xff')
1223 if (memcmp(buf
, buf
+1, 4095) != 0)
1229 /* adding a spare to a regular array is quite different from adding one to
1230 * a set-of-partitions virtual array.
1231 * This function determines which is worth trying and tries as appropriate.
1232 * Arrays are given priority over partitions.
1234 static int try_spare(char *devname
, int *dfdp
, struct dev_policy
*pol
,
1235 struct map_ent
*target
,
1236 struct supertype
*st
, int verbose
)
1241 int partitions_ok
= 0;
1245 /* Can only add a spare if device has at least one domain */
1246 if (pol_find(pol
, pol_domain
) == NULL
)
1248 /* And only if some action allows spares */
1249 if (!policy_action_allows(pol
, st
?st
->ss
->name
:NULL
, act_spare
))
1252 /* Now check if the device is bare.
1253 * bare devices can always be added as a spare
1254 * non-bare devices can only be added if spare-same-slot is permitted,
1255 * and this device is replacing a previous device - in which case 'target'
1258 if (!is_bare(dfd
)) {
1259 /* Must have a target and allow same_slot */
1260 /* Later - may allow force_spare without target */
1262 !policy_action_allows(pol
, st
?st
->ss
->name
:NULL
,
1263 act_spare_same_slot
)) {
1265 pr_err("%s is not bare, so not considering as a spare\n",
1273 /* It might be OK to add this device to an array - need to see
1274 * what arrays might be candidates.
1277 /* just try to add 'array' or 'partition' based on this metadata */
1278 if (st
->ss
->add_to_super
)
1279 return array_try_spare(devname
, dfdp
, pol
, target
, bare
,
1282 return partition_try_spare(devname
, dfdp
, pol
,
1285 /* No metadata was specified or found so options are open.
1286 * Check for whether any array metadata, or any partition metadata
1287 * might allow adding the spare. This check is just help to avoid
1288 * a more costly scan of all arrays when we can be sure that will
1291 for (i
= 0; (!arrays_ok
|| !partitions_ok
) && superlist
[i
] ; i
++) {
1292 if (superlist
[i
]->add_to_super
&& !arrays_ok
&&
1293 policy_action_allows(pol
, superlist
[i
]->name
, act_spare
))
1295 if (superlist
[i
]->add_to_super
== NULL
&& !partitions_ok
&&
1296 policy_action_allows(pol
, superlist
[i
]->name
, act_spare
))
1301 rv
= array_try_spare(devname
, dfdp
, pol
, target
, bare
,
1303 if (rv
!= 0 && partitions_ok
)
1304 rv
= partition_try_spare(devname
, dfdp
, pol
, st
, verbose
);
1308 int IncrementalScan(struct context
*c
, char *devnm
)
1310 /* look at every device listed in the 'map' file.
1311 * If one is found that is not running then:
1312 * look in mdadm.conf for bitmap file.
1313 * if one exists, but array has none, add it.
1314 * try to start array in auto-readonly mode
1316 struct map_ent
*mapl
= NULL
;
1318 struct mddev_ident
*devs
, *mddev
;
1324 devs
= conf_get_ident(NULL
);
1327 for (me
= mapl
; me
; me
= me
->next
) {
1331 if (devnm
&& strcmp(devnm
, me
->devnm
) != 0)
1333 if (me
->metadata
[0] == '/') {
1339 /* member array, need to work on container */
1340 strncpy(container
, me
->metadata
+1, 32);
1342 sl
= strchr(container
, '/');
1349 mdfd
= open_dev(me
->devnm
);
1351 if (!is_fd_valid(mdfd
))
1353 if (!isdigit(me
->metadata
[0])) {
1354 /* must be a container */
1355 struct supertype
*st
= super_by_fd(mdfd
, NULL
);
1357 struct map_ent
*map
= NULL
;
1359 if (st
&& st
->ss
->load_container
)
1360 ret
= st
->ss
->load_container(st
, mdfd
, NULL
);
1362 if (!ret
&& st
&& st
->ss
->container_content
) {
1364 pr_err("failed to get exclusive lock on mapfile\n");
1365 ret
= Incremental_container(st
, me
->path
, c
, only
);
1372 if (md_array_active(mdfd
)) {
1376 /* Ok, we can try this one. Maybe it needs a bitmap */
1377 for (mddev
= devs
; mddev
; mddev
= mddev
->next
)
1378 if (mddev
->devname
&& me
->path
&&
1379 devname_matches(mddev
->devname
, me
->path
))
1381 if (mddev
&& mddev
->bitmap_file
) {
1383 * Note: early kernels will wrongly fail this, so it
1389 bmfd
= open(mddev
->bitmap_file
, O_RDWR
);
1390 if (is_fd_valid(bmfd
)) {
1391 added
= ioctl(mdfd
, SET_BITMAP_FILE
, bmfd
);
1394 if (c
->verbose
>= 0) {
1396 pr_err("Added bitmap %s to %s\n",
1397 mddev
->bitmap_file
, me
->path
);
1398 else if (errno
!= EEXIST
)
1399 pr_err("Failed to add bitmap to %s: %s\n",
1400 me
->path
, strerror(errno
));
1403 /* FIXME check for reshape_active and consider not
1406 sra
= sysfs_read(mdfd
, NULL
, 0);
1408 if (sysfs_set_str(sra
, NULL
,
1409 "array_state", "read-auto") == 0) {
1410 if (c
->verbose
>= 0)
1411 pr_err("started array %s\n",
1412 me
->path
?: me
->devnm
);
1414 pr_err("failed to start array %s: %s\n",
1415 me
->path
?: me
->devnm
,
1427 static char *container2devname(char *devname
)
1429 char *mdname
= NULL
;
1431 if (devname
[0] == '/') {
1432 int fd
= open(devname
, O_RDONLY
);
1434 mdname
= xstrdup(fd2devnm(fd
));
1439 struct map_ent
*mp
, *map
= NULL
;
1441 if (!parse_uuid(devname
, uuid
))
1443 mp
= map_by_uuid(&map
, uuid
);
1445 mdname
= xstrdup(mp
->devnm
);
1452 static int Incremental_container(struct supertype
*st
, char *devname
,
1453 struct context
*c
, char *only
)
1455 /* Collect the contents of this container and for each
1456 * array, choose a device name and assemble the array.
1459 struct mdinfo
*list
;
1461 struct map_ent
*map
= NULL
;
1464 struct mddev_ident
*match
;
1468 st
->ss
->getinfo_super(st
, &info
, NULL
);
1470 if (info
.container_enough
< 0 || (info
.container_enough
== 0 && c
->runstop
< 1)) {
1472 printf("MD_STARTED=no\n");
1473 else if (c
->verbose
)
1474 pr_err("Not enough devices to start the container.\n");
1479 match
= conf_match(st
, &info
, devname
, c
->verbose
, &rv
);
1480 if (match
== NULL
&& rv
== 2)
1483 /* Need to compute 'trustworthy' */
1485 trustworthy
= LOCAL
;
1486 else if (st
->ss
->match_home(st
, c
->homehost
) == 1)
1487 trustworthy
= LOCAL
;
1488 else if (st
->ss
->match_home(st
, "any") == 1)
1489 trustworthy
= LOCAL
;
1491 trustworthy
= FOREIGN
;
1493 list
= st
->ss
->container_content(st
, NULL
);
1494 /* when nothing to activate - quit */
1497 printf("MD_STARTED=nothing\n");
1501 for (ra
= list
; ra
; ra
= ra
->next
) {
1503 char chosen_name
[1024];
1505 struct mddev_ident
*match
= NULL
;
1507 /* do not activate arrays blocked by metadata handler */
1508 if (ra
->array
.state
& (1 << MD_SB_BLOCK_VOLUME
)) {
1509 pr_err("Cannot activate array %s in %s.\n",
1510 ra
->text_version
, devname
);
1513 mp
= map_by_uuid(&map
, ra
->uuid
);
1516 mdfd
= open_dev(mp
->devnm
);
1517 if (!is_fd_valid(mdfd
)) {
1518 pr_err("failed to open %s: %s.\n",
1519 mp
->devnm
, strerror(errno
));
1524 strcpy(chosen_name
, mp
->path
);
1526 strcpy(chosen_name
, mp
->devnm
);
1529 /* Check in mdadm.conf for container == devname and
1530 * member == ra->text_version after second slash.
1532 char *sub
= strchr(ra
->text_version
+1, '/');
1533 struct mddev_ident
*array_list
;
1536 array_list
= conf_get_ident(NULL
);
1539 for(; array_list
; array_list
= array_list
->next
) {
1541 if (array_list
->member
== NULL
||
1542 array_list
->container
== NULL
)
1544 if (strcmp(array_list
->member
, sub
) != 0)
1546 if (array_list
->uuid_set
&&
1547 !same_uuid(ra
->uuid
, array_list
->uuid
, st
->ss
->swapuuid
))
1549 dn
= container2devname(array_list
->container
);
1552 if (strncmp(dn
, ra
->text_version
+1,
1554 ra
->text_version
[strlen(dn
)+1] != '/') {
1559 /* we have a match */
1562 pr_err("match found for member %s\n",
1563 array_list
->member
);
1567 if (match
&& match
->devname
&& is_devname_ignore(match
->devname
) == true) {
1569 pr_err("array %s/%s is explicitly ignored by mdadm.conf\n",
1570 match
->container
, match
->member
);
1574 trustworthy
= LOCAL
;
1576 mdfd
= create_mddev(match
? match
->devname
: NULL
,
1582 if (!is_fd_valid(mdfd
)) {
1583 pr_err("create_mddev failed with chosen name %s: %s.\n",
1584 chosen_name
, strerror(errno
));
1590 if (only
&& (!mp
|| strcmp(mp
->devnm
, only
) != 0)) {
1595 assemble_container_content(st
, mdfd
, ra
, c
,
1596 chosen_name
, &result
);
1601 if (c
->export
&& result
) {
1603 printf("MD_STARTED");
1604 if (result
& INCR_NO
) {
1605 printf("%cno", sep
);
1608 if (result
& INCR_UNSAFE
) {
1609 printf("%cunsafe", sep
);
1612 if (result
& INCR_ALREADY
) {
1613 printf("%calready", sep
);
1616 if (result
& INCR_YES
) {
1617 printf("%cyes", sep
);
1629 static void remove_from_member_array(struct mdstat_ent
*memb
,
1630 struct mddev_dev
*devlist
, int verbose
)
1632 int subfd
= open_dev(memb
->devnm
);
1636 * Ignore the return value because it's necessary
1637 * to handle failure condition here.
1639 Manage_subdevs(memb
->devnm
, subfd
, devlist
, verbose
,
1640 0, UOPT_UNDEFINED
, 0);
1646 * IncrementalRemove - Attempt to see if the passed in device belongs to any
1647 * raid arrays, and if so first fail (if needed) and then remove the device.
1649 * @devname - The device we want to remove
1650 * @id_path - name as found in /dev/disk/by-path for this device
1652 * Note: the device name must be a kernel name like "sda", so
1653 * that we can find it in /proc/mdstat
1655 int IncrementalRemove(char *devname
, char *id_path
, int verbose
)
1659 struct mdstat_ent
*ent
;
1660 struct mddev_dev devlist
;
1662 char buf
[SYSFS_MAX_BUF_SIZE
];
1665 dprintf("incremental removal without --path <id_path> lacks the possibility to re-add new device in this port\n");
1667 if (strchr(devname
, '/')) {
1668 pr_err("incremental removal requires a kernel device name, not a file: %s\n", devname
);
1671 ent
= mdstat_by_component(devname
);
1674 pr_err("%s does not appear to be a component of any array\n", devname
);
1677 if (sysfs_init(&mdi
, -1, ent
->devnm
)) {
1678 pr_err("unable to initialize sysfs for: %s\n", devname
);
1681 mdfd
= open_dev_excl(ent
->devnm
);
1682 if (is_fd_valid(mdfd
)) {
1684 if (sysfs_get_str(&mdi
, NULL
, "array_state",
1685 buf
, sizeof(buf
)) > 0) {
1686 if (strncmp(buf
, "active", 6) == 0 ||
1687 strncmp(buf
, "clean", 5) == 0)
1688 sysfs_set_str(&mdi
, NULL
,
1689 "array_state", "read-auto");
1692 mdfd
= open_dev(ent
->devnm
);
1695 pr_err("Cannot open array %s!!\n", ent
->devnm
);
1701 struct map_ent
*map
= NULL
, *me
;
1702 me
= map_by_devnm(&map
, ent
->devnm
);
1704 policy_save_path(id_path
, me
);
1708 memset(&devlist
, 0, sizeof(devlist
));
1709 devlist
.devname
= devname
;
1710 devlist
.disposition
= 'I';
1711 /* for a container, we must fail each member array */
1712 if (ent
->metadata_version
&&
1713 strncmp(ent
->metadata_version
, "external:", 9) == 0) {
1714 struct mdstat_ent
*mdstat
= mdstat_read(0, 0);
1715 struct mdstat_ent
*memb
;
1716 for (memb
= mdstat
; memb
; memb
= memb
->next
) {
1717 if (is_container_member(memb
, ent
->devnm
))
1718 remove_from_member_array(memb
,
1721 free_mdstat(mdstat
);
1724 * This 'I' incremental remove is a try-best effort,
1725 * the failure condition can be safely ignored
1726 * because of the following up 'r' remove.
1728 Manage_subdevs(ent
->devnm
, mdfd
, &devlist
,
1729 verbose
, 0, UOPT_UNDEFINED
, 0);
1732 devlist
.disposition
= 'r';
1733 rv
= Manage_subdevs(ent
->devnm
, mdfd
, &devlist
,
1734 verbose
, 0, UOPT_UNDEFINED
, 0);