bfd/ChangeLog

   1 2020-03-05  Alan Modra  <amodra@gmail.com>
   2
   3         * archive64.c (_bfd_archive_64_bit_slurp_armap): Check parsed_size
   4         against file size before allocating memory.  Use bfd_alloc rather
   5         than bfd_zalloc for carsym/strings memory.
   6
   7 2020-03-04  Alan Modra  <amodra@gmail.com>
   8
   9         * elf.c (elf_fake_sections): Ensure sh_addralign is such that
  10         sh_addr mod sh_addalign is zero.
  11
  12 2020-03-04  Alan Modra  <amodra@gmail.com>
  13
  14         * format.c (bfd_check_format_matches): Call cleanup on error exit.
  15
  16 2020-03-03  Alan Modra  <amodra@gmail.com>
  17
  18         * format.c (struct bfd_preserve): Add cleanup field.
  19         (bfd_preserve_save): Add cleanup param and save.
  20         (bfd_preserve_restore): Return cleanup.
  21         (bfd_preserve_finish): Call the cleanup for the discarded match.
  22         (bfd_check_format_matches): Pass cleanup to bfd_preserve_save,
  23         and clear when preserving a match.  Restore cleanup too when
  24         restoring that match.
  25
  26 2020-03-02  Alan Modra  <amodra@gmail.com>
  27
  28         * cisco-core.c (cisco_core_file_p): Return bfd_cleanup.
  29         * hpux-core.c (hpux_core_core_file_p): Update prototype.
  30         * sco5-core.c (sco5_core_file_p): Return bfd_cleanup.
  31         (core_sco5_vec): Correct initialisers.
  32
  33 2020-03-02  Alan Modra  <amodra@gmail.com>
  34
  35         * aix386-core.c (aix386_core_file_p): Return bfd_cleanup.
  36         * aix5ppc-core.c (xcoff64_core_p): Likewise.
  37         * cisco-core.c (cisco_core_file_validate): Likewise.
  38         * hppabsd-core.c (hppabsd_core_core_file_p): Likewise.
  39         * hpux-core.c (hpux_core_core_file_p): Likewise.
  40         * irix-core.c (irix_core_core_file_p): Likewise.
  41         * lynx-core.c (lynx_core_file_p): Likewise.
  42         * netbsd-core.c (netbsd_core_file_p): Likewise.
  43         * osf-core.c (osf_core_core_file_p): Likewise.
  44         * ptrace-core.c (ptrace_unix_core_file_p): Likewise.
  45         * sco5-core.c (sco5_core_file_p): Likewise.
  46
  47 2020-03-02  H.J. Lu  <hongjiu.lu@intel.com>
  48
  49         * trad-core.c (trad_unix_core_file_p): Return bfd_cleanup.
  50
  51 2020-03-02  Alan Modra  <amodra@gmail.com>
  52
  53         * targets.c (bfd_cleanup): New typedef.
  54         (struct bfd <_bfd_check_format>): Return a bfd_cleanup.
  55         * libbfd-in.h (_bfd_no_cleanup): Define.
  56         * format.c (bfd_reinit): Add cleanup parameter, call it.
  57         (bfd_check_format_matches): Set cleanup from _bfd_check_format
  58         call and pass to bfd_reinit.  Delete temp, use abfd->xvec instead.
  59         * aout-target.h (callback, object_p): Return bfd_cleanup.
  60         * aout-tic30.c (tic30_aout_callback, tic30_aout_object_p): Likewise.
  61         * archive.c (bfd_generic_archive_p): Likewise.
  62         * binary.c (binary_object_p): Likewise.
  63         * coff-alpha.c (alpha_ecoff_object_p): Likewise.
  64         * coff-ia64.c (ia64coff_object_p): Likewise.
  65         * coff-rs6000.c (_bfd_xcoff_archive_p, rs6000coff_core_p): Likewise.
  66         * coff-sh.c (coff_small_object_p): Likewise.
  67         * coff-stgo32.c (go32_check_format): Likewise.
  68         * coff64-rs6000.c (xcoff64_archive_p, rs6000coff_core_p),
  69         (xcoff64_core_p): Likewise.
  70         * coffgen.c (coff_real_object_p, coff_object_p): Likewise.
  71         * elf-bfd.h (bfd_elf32_object_p, bfd_elf32_core_file_p),
  72         (bfd_elf64_object_p, bfd_elf64_core_file_p): Likewise.
  73         * elfcode.h (elf_object_p): Likewise.
  74         * elfcore.h (elf_core_file_p): Likewise.
  75         * i386msdos.c (msdos_object_p): Likewise.
  76         * ihex.c (ihex_object_p): Likewise.
  77         * libaout.h (some_aout_object_p): Likewise.
  78         * libbfd-in.h (bfd_generic_archive_p, _bfd_dummy_target),
  79         (_bfd_vms_lib_alpha_archive_p, _bfd_vms_lib_ia64_archive_p): Likewise.
  80         * libbfd.c (_bfd_dummy_target): Likewise.
  81         * libcoff-in.h (coff_object_p): Likewise.
  82         * mach-o-aarch64.c (bfd_mach_o_arm64_object_p),
  83         (bfd_mach_o_arm64_core_p): Likewise.
  84         * mach-o-arm.c (bfd_mach_o_arm_object_p),
  85         (bfd_mach_o_arm_core_p): Likewise.
  86         * mach-o-i386.c (bfd_mach_o_i386_object_p),
  87         (bfd_mach_o_i386_core_p): Likewise.
  88         * mach-o-x86-64.c (bfd_mach_o_x86_64_object_p),
  89         (bfd_mach_o_x86_64_core_p): Likewise.
  90         * mach-o.c (bfd_mach_o_header_p, bfd_mach_o_gen_object_p),
  91         (bfd_mach_o_gen_core_p, bfd_mach_o_fat_archive_p): Likewise.
  92         * mach-o.h (bfd_mach_o_object_p, bfd_mach_o_core_p),
  93         (bfd_mach_o_fat_archive_p, bfd_mach_o_header_p): Likewise.
  94         * mmo.c (mmo_object_p): Likewise.
  95         * pef.c (bfd_pef_object_p, bfd_pef_xlib_object_p): Likewise.
  96         * peicode.h (coff_real_object_p, pe_ILF_object_p),
  97         (pe_bfd_object_p): Likewise.
  98         * plugin.c (ld_plugin_object_p, bfd_plugin_object_p): Likewise.
  99         * ppcboot.c (ppcboot_object_p): Likewise.
 100         * rs6000-core.c (rs6000coff_core_p): Likewise.
 101         * som.c (som_object_setup, som_object_p): Likewise.
 102         * srec.c (srec_object_p, symbolsrec_object_p): Likewise.
 103         * tekhex.c (tekhex_object_p): Likewise.
 104         * vms-alpha.c (alpha_vms_object_p): Likewise.
 105         * vms-lib.c (_bfd_vms_lib_archive_p, _bfd_vms_lib_alpha_archive_p),
 106         (_bfd_vms_lib_ia64_archive_p, _bfd_vms_lib_txt_archive_p): Likewise.
 107         * wasm-module.c (wasm_object_p): Likewise.
 108         * xsym.c (bfd_sym_object_p): Likewise.
 109         * xsym.h (bfd_sym_object_p): Likewise.
 110         * aoutx.h (some_aout_object_p): Likewise, and callback parameter
 111         return type.
 112         * pdp11.c (some_aout_object_p): Likewise.
 113         * plugin.c (register_ld_plugin_object_p): Update object_p
 114         parameter type.
 115         * plugin.h (register_ld_plugin_object_p): Likewise.
 116         * bfd-in2.h: Regenerate.
 117         * libbfd.h: Regenerate.
 118         * libcoff.h: Regenerate.
 119
 120 2020-03-02  Alan Modra  <amodra@gmail.com>
 121
 122         * coff-alpha.c (alpha_ecoff_le_vec): Add SEC_SMALL_DATA to
 123         applicable section flags.
 124         * coff-mips.c (mips_ecoff_le_vec, mips_ecoff_be_vec): Likewise.
 125         (mips_ecoff_bele_vec): Likewise.
 126         * coffcode.h (sec_to_styp_flags): Set SEC_SMALL_DATA for .sdata
 127         and .sbss sections.
 128         * ecoff.c (_bfd_ecoff_new_section_hook): Likewise.
 129         (_bfd_ecoff_styp_to_sec_flags): Likewise.
 130
 131 2020-03-02  Alan Modra  <amodra@gmail.com>
 132
 133         * elf32-m32r.c (m32r_elf_section_flags): New function.
 134         (elf_backend_section_flags): Define.
 135         * elf32-nds32.c (nds32_elf_section_flags): New function.
 136         (elf_backend_section_flags): Define.
 137         * elf32-ppc.c (ppc_elf_section_from_shdr): Set SEC_SMALL_DATA for
 138         .sbss and .sdata sections.
 139         * elf32-v850.c (v850_elf_section_from_shdr): Set SEC_SMALL_DATA
 140         for SHF_V850_GPREL sections.
 141         * elf64-alpha.c (elf64_alpha_section_from_shdr): Delete outdated
 142         FIXME.
 143         * elf64-hppa.c (elf64_hppa_section_from_shdr): Set SEC_SMALL_DATA
 144         for SHF_PARISC_SHORT sections.
 145         * elf64-ppc.c (ppc64_elf_section_flags): New function.
 146         (elf_backend_section_flags): Define.
 147         * elfxx-mips.c (_bfd_mips_elf_section_from_shdr): Set SEC_SMALL_DATA
 148         for SHF_MIPS_GPREL sections.  Delete FIXME.
 149
 150 2020-03-02  Alan Modra  <amodra@gmail.com>
 151
 152         * elf-bfd.h (elf_backend_section_flags): Remove flagword* param.
 153         * elf.c (_bfd_elf_make_section_from_shdr): Set section flags before
 154         calling elf_backend_section_flags with adjusted params.  Use
 155         newsect->flags past that point.
 156         (_bfd_elf_new_section_hook): Always set sh_type and sh_flags for
 157         special sections.
 158         (_bfd_elf_init_private_section_data): Allow normal sh_type sections
 159         to have their type overridden, and all sh_flags but processor and
 160         os specific.
 161         * elf32-arm.c (elf32_arm_section_flags): Adjust for changed params.
 162         * elf32-mep.c (mep_elf_section_flags): Likewise.
 163         * elf32-nios2.c (nios2_elf32_section_flags): Likewise.
 164         * elf64-alpha.c (elf64_alpha_section_flags): Likewise.
 165         * elf64-ia64-vms.c (elf64_ia64_section_flags): Likewise.
 166         * elfnn-ia64.c (elfNN_ia64_section_flags): Likewise.
 167         * elfnn-aarch64.c (elfNN_aarch64_size_stubs): Exclude the linker
 168         stub BFD and non-aarch64 input files when scanning for stubs.
 169
 170 2020-03-02  Alan Modra  <amodra@gmail.com>
 171
 172         * coff-alpha.c (alpha_ecoff_get_elt_at_filepos): Provide an upper
 173         limit to decompressed element size.
 174
 175 2020-03-02  Alan Modra  <amodra@gmail.com>
 176
 177         * vms-lib.c (vms_traverse_index): Add recur_count param and
 178         update calls.  Fail on excessive recursion.
 179
 180 2020-03-02  Alan Modra  <amodra@gmail.com>
 181
 182         * vms-alpha.c (vms_get_remaining_object_record): Use
 183         bfd_realloc_or_free rather than bfd_realloc.
 184         (add_symbol_entry, vector_grow1, alpha_vms_slurp_relocs): Likewise.
 185         (dst_define_location, parse_module): Likewise, and check realloc
 186         return status before using memory.  Return status from function
 187         adjusting all callers.
 188
 189 2020-02-28  Alan Modra  <amodra@gmail.com>
 190
 191         * vms-lib.c (_bfd_vms_lib_archive_p): Free memory on error paths.
 192
 193 2020-02-28  Alan Modra  <amodra@gmail.com>
 194
 195         * vms-alpha.c (alpha_vms_object_p): Use _bfd_malloc_and_read.
 196         Remove duplicate undersize check.
 197
 198 2020-02-27  Alan Modra  <amodra@gmail.com>
 199
 200         PR 24511
 201         * mmo.c (mmo_scan): Set SEC_DATA for .data.
 202
 203 2020-02-27  Alan Modra  <amodra@gmail.com>
 204
 205         PR 24511
 206         * syms.c (stt): Trim off all but 'e', 'i' and 'p' entries.
 207         (coff_section_type): Adjust comment.
 208         (decode_section_type): Likewise.  Call coff_section_type before
 209         decode_section_type.
 210         (bfd_decode_symclass): Use 'c' for common sections other than
 211         the standard one.
 212
 213 2020-02-27  Alan Modra  <amodra@gmail.com>
 214
 215         * coff-rs6000.c (_bfd_xcoff_read_ar_hdr): Put all data in one
 216         malloc'd block.
 217
 218 2020-02-27  Alan Modra  <amodra@gmail.com>
 219
 220         * bfd.c (bfd_stat_arch_elt): Use vector of containing archive,
 221         if file is an archive element.
 222         * bfd-in2.h: Regenerate.
 223
 224 2020-02-26  Alan Modra  <amodra@gmail.com>
 225
 226         * archive.c (do_slurp_bsd_armap): Increase minimum parsed_size, and
 227         bfd_set_error on failing test.  Don't bother changing bfd_error on
 228         file read error.  Check symdef_count is multiple of BSD_SYMDEF_SIZE.
 229         Check sym name is within string buffer.  Use size_t for some vars.
 230         (do_slurp_coff_armap): Use size_t for some variables, fix size of
 231         int_buf.  Don't change bfd_error on file read error.  Use
 232         _bfd_mul_overflow when calculating carsym buffer size.  Reorder
 233         calculations to catch overflows before they occur.  malloc and
 234         free raw armap rather than using bfd_alloc.  Read raw armap before
 235         allocating carsym+strings buffer.
 236         (_bfd_slurp_extended_name_table): Localize variables.  Check
 237         name size against file size.
 238
 239 2020-02-26  Alan Modra  <amodra@gmail.com>
 240
 241         * vms-lib.c (vms_lib_read_index): Release correct buffer.
 242
 243 2020-02-26  Alan Modra  <amodra@gmail.com>
 244
 245         * elf32-rx.c (rx_elf_relocate_section): Use bfd_malloc rather than
 246         malloc.  Check for NULL return from bfd_malloc.
 247         (rx_table_find, rx_table_map): Likewise.
 248         (rx_set_section_contents): Check bfd_alloc return.
 249         (rx_dump_symtab): Don't alloc internal_syms or external_syms.
 250
 251 2020-02-26  Alan Modra  <amodra@gmail.com>
 252
 253         * aoutx.h: Indent labels correctly.  Format error strings.
 254         * archive.c: Likewise.
 255         * archive64.c: Likewise.
 256         * coff-arm.c: Likewise.
 257         * coff-rs6000.c: Likewise.
 258         * coff-stgo32.c: Likewise.
 259         * cpu-arm.c: Likewise.
 260         * dwarf2.c: Likewise.
 261         * elf-ifunc.c: Likewise.
 262         * elf-properties.c: Likewise.
 263         * elf-s390-common.c: Likewise.
 264         * elf-strtab.c: Likewise.
 265         * elf.c: Likewise.
 266         * elf32-arm.c: Likewise.
 267         * elf32-bfin.c: Likewise.
 268         * elf32-cr16.c: Likewise.
 269         * elf32-csky.c: Likewise.
 270         * elf32-i386.c: Likewise.
 271         * elf32-m68k.c: Likewise.
 272         * elf32-msp430.c: Likewise.
 273         * elf32-nds32.c: Likewise.
 274         * elf32-nios2.c: Likewise.
 275         * elf32-pru.c: Likewise.
 276         * elf32-xtensa.c: Likewise.
 277         * elf64-ia64-vms.c: Likewise.
 278         * elf64-x86-64.c: Likewise.
 279         * elfcode.h: Likewise.
 280         * elfcore.h: Likewise.
 281         * elflink.c: Likewise.
 282         * elfnn-aarch64.c: Likewise.
 283         * elfnn-ia64.c: Likewise.
 284         * elfnn-riscv.c: Likewise.
 285         * elfxx-mips.c: Likewise.
 286         * elfxx-sparc.c: Likewise.
 287         * elfxx-x86.c: Likewise.
 288         * i386lynx.c: Likewise.
 289         * merge.c: Likewise.
 290         * pdp11.c: Likewise.
 291         * plugin.c: Likewise.
 292         * reloc.c: Likewise.
 293
 294 2020-02-26  Alan Modra  <amodra@gmail.com>
 295
 296         PR 25593
 297         * elf-bfd.h (struct elf_link_hash_table): Rename "loaded" to
 298         "dyn_loaded".
 299         (bfd_elf_add_dt_needed_tag): Declare.
 300         * elf-strtab.c (_bfd_elf_strtab_restore): Handle NULL buf.
 301         * elflink.c (bfd_elf_add_dt_needed_tag): Make global and rename
 302         from elf_add_dt_needed_tag.  Remove soname and doit param.
 303         (elf_link_add_object_symbols): Don't use elf_add_dt_needed_tag
 304         to see whether as-needed lib is already loaded, use dyn_loaded
 305         list instead.  When saving and restoring around as-needed lib
 306         handle possibility that dynstr has not been initialised.  Don't
 307         add DT_NEEDED tags here.  Limit dyn_loaded list to dynamic libs.
 308         Mark libs loaded via DT_NEEDED entries of other libs with
 309         DYN_NO_NEEDED if they should not be mentioned in DT_NEEDED of
 310         the output.
 311         (elf_link_check_versioned_symbol): Remove now unneccesary
 312         DYNAMIC check when traversing dyn_loaded list.
 313
 314 2020-02-26  Alan Modra  <amodra@gmail.com>
 315
 316         * bfdio.c (bfd_get_file_size): Ignore bogus archive element sizes.
 317
 318 2020-02-25  H.J. Lu  <hongjiu.lu@intel.com>
 319
 320         PR binutils/25584
 321         * plugin.c (need_lto_wrapper_p): New.
 322         (bfd_plugin_set_program_name): Add an int argument to set
 323         need_lto_wrapper_p.
 324         (get_lto_wrapper): Return FALSE if need_lto_wrapper_p isn't
 325         set.
 326         * plugin.h (bfd_plugin_set_program_name): Add an int argument.
 327
 328 2020-02-24  Alan Modra  <amodra@gmail.com>
 329
 330         * vms-lib.c (_bfd_vms_lib_archive_p): Correct overflow checks.
 331
 332 2020-02-24  Alan Modra  <amodra@gmail.com>
 333
 334         * vms-lib.c (struct carsym_mem): Add limit.
 335         (vms_add_index): Heed limit.
 336         (vms_traverse_index): Catch buffer overflows.  Remove outdated fixme.
 337         (vms_lib_read_index): Set up limit.  Catch 32-bit overflow.
 338         Always return actual number read.
 339         (_bfd_vms_lib_archive_p): Catch buffer overflows.  Replace
 340         assertion with error exit.
 341
 342 2020-02-22  Alan Modra  <amodra@gmail.com>
 343
 344         PR 25585
 345         * elf.c (assign_file_positions_for_load_sections): Continue linking
 346         on "PHDR segment not covered by LOAD segment" errors.
 347
 348 2020-02-21  Alan Modra  <amodra@gmail.com>
 349
 350         * mach-o.c (bfd_mach_o_canonicalize_relocs): Fix ineffective
 351         overflow check.
 352         (bfd_mach_o_canonicalize_reloc): Likewise.
 353         (bfd_mach_o_canonicalize_dynamic_reloc): Likewise.  Sanity check
 354         counts and offsets against file size.
 355         (bfd_mach_o_build_dysymtab): Fix ineffective overflow check.
 356         (bfd_mach_o_mangle_sections): Remove unnecessary overflow check.
 357         (bfd_mach_o_read_symtab_symbols): Sanity check count and offset
 358         against file size.  Delete symbol table error message.
 359         (bfd_mach_o_read_dysymtab): Sanity check counts and offsets
 360         against file size.
 361         (bfd_mach_o_read_symtab): Likewise.
 362         (bfd_mach_o_read_command): Pass file size.
 363         (bfd_mach_o_scan): Sanity check command count against file size.
 364
 365 2020-02-21  Alan Modra  <amodra@gmail.com>
 366
 367         PR 25569
 368         * aoutx.h (adjust_o_magic, adjust_z_magic, adjust_n_magic): Use
 369         "text", "data" and "bss" section pointer vars.  Don't update
 370         section size, just exec header sizes.
 371         (adjust_sizes_and_vmas): Don't update text section size.  Set
 372         initial exec header a_text.  Print exec headers sizes.
 373         * pdp11.c (adjust_o_magic, adjust_z_magic, adjust_n_magic),
 374         (adjust_sizes_and_vmas): Similarly.  Formatting.
 375         (final_link): Correct final file extension.
 376
 377 2020-02-20  Nick Clifton  <nickc@redhat.com>
 378
 379         * elf-bfd.h (struct elf_backend_data): Add symbol_section_index
 380         callback.
 381         * elfxx-target.h (elf_backend_symbol_section_index): Provide
 382         default definition.
 383         (elfNN_bed): Initialise the symbol_section_index field.
 384         * elf.c (swap_out_syms): Call symbol_section_index, if defined, on
 385         OS and PROC specific section indicies.  Warn if converting other
 386         reserved incidies to SHN_ABS.
 387
 388 2020-02-19  Sergey Belyashov  <sergey.belyashov@gmail.com>
 389
 390         PR 25537
 391         * cpu-z80.c: Add machine type compatibility checking.
 392
 393 2020-02-19  H.J. Lu  <hongjiu.lu@intel.com>
 394
 395         PR binutils/25355
 396         * plugin.c (plugin_list_entry): Remove handle.
 397         (try_load_plugin): Call dlclose before return.
 398
 399 2020-02-19  Alan Modra  <amodra@gmail.com>
 400
 401         * libbfd-in.h (_bfd_constant_p): Define.
 402         (_bfd_alloc_and_read, _bfd_malloc_and_read): Check read size against
 403         file size before allocating memory.
 404         * coffgen.c (_bfd_coff_get_external_symbols): Remove file size check.
 405         * elf.c (bfd_elf_get_str_section): Likewise.
 406         (_bfd_elf_slurp_version_tables): Likewise.
 407         * libbfd.h: Regenerate.
 408
 409 2020-02-19  Alan Modra  <amodra@gmail.com>
 410
 411         * libbfd-in.h (_bfd_alloc_and_read, _bfd_malloc_and_read): New.
 412         * aoutx.h (aout_get_external_symbols): Replace calls to
 413         bfd_[m]alloc and bfd_bread with call to _bfd_[m]alloc_and_read.
 414         (slurp_reloc_table): Likewise.
 415         * archive.c (do_slurp_bsd_armap): Likewise.
 416         (do_slurp_coff_armap): Likewise.
 417         * archive64.c (_bfd_archive_64_bit_slurp_armap): Likewise.
 418         * coff-rs6000.c (_bfd_xcoff_slurp_armap): Likewise.
 419         * coff64-rs6000.c (xcoff64_slurp_armap): Likewise.
 420         * coffcode.h (coff_set_arch_mach_hook, buy_and_read): Likewise.
 421         * coffgen.c (coff_real_object_p, coff_object_p, build_debug_section),
 422         (_bfd_coff_get_external_symbols): Likewise.
 423         * ecoff.c (ecoff_slurp_symbolic_header),
 424         (_bfd_ecoff_slurp_symbolic_info, ecoff_slurp_reloc_table),
 425         (_bfd_ecoff_slurp_armap, ecoff_link_add_object_symbols, READ),
 426         (ecoff_indirect_link_order): Likewise.
 427         * elf.c (bfd_elf_get_str_section, setup_group, elf_read_notes),
 428         (_bfd_elf_slurp_version_tables): Likewise.
 429         * elf32-m32c.c (m32c_elf_relax_section): Likewise.
 430         * elf32-rl78.c (rl78_elf_relax_section): Likewise.
 431         * elf32-rx.c (elf32_rx_relax_section): Likewise.
 432         * elf64-alpha.c (READ): Likewise.
 433         * elf64-mips.c (mips_elf64_slurp_one_reloc_table): Likewise.
 434         * elf64-sparc.c (elf64_sparc_slurp_one_reloc_table): Likewise.
 435         * elfcode.h (elf_slurp_symbol_table),
 436         (elf_slurp_reloc_table_from_section): Likewise.
 437         * elflink.c (elf_link_add_object_symbols),
 438         (elf_link_check_versioned_symbol): Likewise.
 439         * elfxx-mips.c (READ): Likewise.
 440         * i386lynx.c (slurp_reloc_table): Likewise.
 441         * lynx-core.c (lynx_core_file_p): Likewise.
 442         * mach-o.c (bfd_mach_o_canonicalize_relocs),
 443         (bfd_mach_o_read_symtab_strtab, bfd_mach_o_alloc_and_read),
 444         (bfd_mach_o_read_prebound_dylib, bfd_mach_o_read_dyld_content
 445         * pdp11.c (aout_get_external_symbols, slurp_reloc_table
 446         * pef.c (bfd_pef_print_loader_section, bfd_pef_scan_start_address),
 447         (bfd_pef_parse_symbols): Likewise.
 448         * peicode.h (pe_ILF_object_p, pe_bfd_object_p
 449         * som.c (setup_sections, som_slurp_string_table),
 450         (som_slurp_reloc_table, som_bfd_count_ar_symbols),
 451         (som_bfd_fill_in_ar_symbols): Likewise.
 452         * vms-alpha.c (module_find_nearest_line, evax_bfd_print_dst),
 453         (evax_bfd_print_image): Likewise.
 454         * vms-lib.c (_bfd_vms_lib_archive_p): Likewise.
 455         * wasm-module.c (wasm_scan): Likewise.
 456         * xcofflink.c (xcoff_link_add_symbols): Likewise.
 457         * xsym.c (bfd_sym_read_name_table),
 458         (bfd_sym_print_type_information_table_entry): Likewise.
 459         * libbfd.h: Regenerate.
 460
 461 2020-02-19  Alan Modra  <amodra@gmail.com>
 462
 463         * aoutx.h (slurp_reloc_table): Allocate reloc_cache after
 464         reading external relocs.
 465         * ecoff.c (ecoff_slurp_reloc_table): Likewise.
 466         * archive.c (_bfd_write_archive_contents): Don't twiddle bfd_error
 467         after bfd_bread.
 468         * archive64.c (_bfd_archive_64_bit_slurp_armap): Remove unnecessary
 469         bfd_release.
 470         * elf32-m32c.c (m32c_offset_for_reloc): Make shndx_buf a bfd_byte*.
 471         (m32c_elf_relax_section): Likewise.
 472         * elf32-rl78.c (rl78_offset_for_reloc): Likewise.
 473         (rl78_elf_relax_section): Likewise.
 474         * elf32-rx.c (rx_offset_for_reloc): Likewise.
 475         (elf32_rx_relax_section): Likewise.
 476         * mach-o.c (bfd_mach_o_alloc_and_read): Move earlier with better
 477         parameter types and use..
 478         (bfd_mach_o_read_dylinker, bfd_mach_o_read_dylib),
 479         (bfd_mach_o_read_fvmlib, bfd_mach_o_read_str): ..in these functions.
 480         * peicode.h (pe_bfd_object_p): Don't zero the part of opthdr
 481         being read from file, just the extra.
 482         * som.c (som_slurp_symbol_table): Allocate internal symbol buffer
 483         after reading external syms.  Free on failure.
 484
 485 2020-02-19  Alan Modra  <amodra@gmail.com>
 486
 487         * coffcode.h (buy_and_read, coff_slurp_line_table),
 488         (coff_slurp_symbol_table, coff_slurp_reloc_table): Replace
 489         bfd_[z][m]alloc2 calls with _bfd_mul_overflow followed by the
 490         corresponding bfd_alloc call.  Adjust variables to suit.
 491         * coffgen.c (_bfd_coff_get_external_symbols): Likewise.
 492         * ecoff.c (_bfd_ecoff_slurp_symbolic_info),
 493         (_bfd_ecoff_slurp_symbol_table, READ): Likewise.
 494         * elf.c (bfd_elf_get_elf_syms, setup_group, bfd_section_from_shdr),
 495         (swap_out_syms, _bfd_elf_slurp_version_tables): Likewise.
 496         * elf32-m32c.c (m32c_elf_relax_section): Likewise.
 497         * elf32-rl78.c (rl78_elf_relax_section): Likewise.
 498         * elf32-rx.c (elf32_rx_relax_section): Likewise.
 499         * elf64-alpha.c (READ): Likewise.
 500         * elfcode.h (elf_object_p, elf_write_relocs, elf_write_shdrs_and_ehdr),
 501         (elf_slurp_symbol_table, elf_slurp_reloc_table),
 502         (bfd_from_remote_memory): Likewise.
 503         * elfcore.h (core_find_build_id): Likewise.
 504         * elfxx-mips.c (READ): Likewise.
 505         * mach-o.c (bfd_mach_o_mangle_sections),
 506         (bfd_mach_o_read_symtab_symbols, bfd_mach_o_read_thread),
 507         (bfd_mach_o_read_dysymtab, bfd_mach_o_flatten_sections),
 508         (bfd_mach_o_scan, bfd_mach_o_fat_archive_p): Likewise.
 509         * som.c (setup_sections, som_prep_for_fixups)
 510         (som_build_and_write_symbol_table, som_slurp_symbol_table),
 511         (som_slurp_reloc_table, som_bfd_count_ar_symbols),
 512         (som_bfd_fill_in_ar_symbols, som_slurp_armap),
 513         (som_bfd_ar_write_symbol_stuff): Likewise.
 514         * vms-alpha.c (vector_grow1): Likewise.
 515         * vms-lib.c (vms_add_index): Likewise.
 516         * wasm-module.c (wasm_scan_name_function_section): Likewise.
 517         * libbfd.c (bfd_malloc2, bfd_realloc2, bfd_zmalloc2): Delete.
 518         * opncls.c (bfd_alloc2, bfd_zalloc2): Delete.
 519         * libbfd-in.h (bfd_malloc2, bfd_realloc2, bfd_zmalloc2),
 520         (bfd_alloc2, bfd_zalloc2): Delete.
 521         (_bfd_mul_overflow): Define.
 522         * libbfd.h: Regenerate.
 523
 524 2020-02-19  Alan Modra  <amodra@gmail.com>
 525
 526         * elf.c (bfd_section_from_shdr): Use bfd_zalloc rather than
 527         bfd_zalloc2.
 528         (assign_section_numbers): Likewise.
 529         (elf_map_symbols): Likewise, and bfd_alloc rather than bfd_alloc2.
 530         (_bfd_elf_map_sections_to_segments): Use bfd_malloc rather than
 531         bfd_malloc2, size_t amt, and unsigned tls_count.
 532         (rewrite_elf_program_header): Use bfd_malloc and size_t amt.
 533         * elflink.c (elf_create_symbuf): Use bfd_malloc.
 534         (elf_output_implib): Use bfd_alloc.
 535
 536 2020-02-19  Alan Modra  <amodra@gmail.com>
 537
 538         * bfd.c (struct bfd): Move format and direction to other
 539         bitfields.  Add "size".
 540         * bfdio.c (bfd_get_size): Cache size when not writing file.
 541         * opncls.c (bfd_get_debug_link_info_1): Allow for bfd_get_size
 542         returning zero, ie. unknown.
 543         (bfd_get_alt_debug_link_info): Likewise.
 544         * bfd-in2.h: Regenerate.
 545
 546 2020-02-19  Alan Modra  <amodra@gmail.com>
 547
 548         * coffgen.c (_bfd_coff_get_external_symbols): Don't call
 549         bfd_get_file_size twice.
 550         (_bfd_coff_read_string_table): Allow for bfd_get_file_size
 551         zero, ie. unknown, return.
 552         * elf-attrs.c (_bfd_elf_parse_attributes): Likewise.
 553         * elfcode.h (elf_swap_shdr_in): Likewise.
 554         (elf_object_p): Don't call bfd_get_file_size twice and correct
 555         file size check.
 556
 557 2020-02-19  Alan Modra  <amodra@gmail.com>
 558
 559         * mach-o.c (bfd_mach_o_flatten_sections): Return a bfd_boolean,
 560         FALSE if memory alloc fails.  Adjust calls.
 561         * som.c (som_prep_for_fixups): Likewise.
 562         * vms-alpha.c (alpha_vms_add_fixup_lp, alpha_vms_add_fixup_ca),
 563         (alpha_vms_add_fixup_qr, alpha_vms_add_fixup_lr),
 564         (alpha_vms_add_lw_reloc, alpha_vms_add_qw_reloc): Likewise.
 565         * som.c (som_build_and_write_symbol_table): Return via error_return
 566         on seek failure.
 567         * vms-alpha.c (VEC_APPEND): Adjust for vector_grow1 changes.
 568         (VEC_APPEND_EL): Delete.
 569         (vector_grow1): Return pointer to element.  Catch overflow.
 570         Return NULL on memory allocation failure.
 571         (alpha_vms_add_fixup_lp): Replace VEC_APPEND_EL with VEC_APPEND.
 572         (alpha_vms_add_fixup_ca): Likewise.
 573         (alpha_vms_link_add_object_symbols): Check VEC_APPEND result
 574         before using.
 575         * elf.c (bfd_section_from_shdr): Check bfd_zalloc2 result.
 576
 577 2020-02-19  Alan Modra  <amodra@gmail.com>
 578
 579         * aix386-core.c (aix386_core_file_p): Use size_t for "amt".
 580         * aout-target.h (object_p): Likewise.
 581         * aout-tic30.c (tic30_aout_object_p): Likewise.
 582         * aoutx.h (some_aout_object_p, mkobject, make_empty_symbol),
 583         (emit_stringtab, write_syms, link_hash_table_create),
 584         (aout_link_write_other_symbol): Likewise.
 585         * archive.c (_bfd_generic_mkarchive, bfd_generic_archive_p),
 586         (bfd_ar_hdr_from_filesystem, _bfd_write_archive_contents),
 587         (_bfd_compute_and_write_armap): Likewise.
 588         * archures.c (bfd_arch_list): Likewise.
 589         * bfd.c (bfd_record_phdr): Likewise.
 590         * binary.c (binary_canonicalize_symtab): Likewise.
 591         * cisco-core.c (cisco_core_file_validate): Likewise.
 592         * coff-arm.c (coff_arm_link_hash_table_create, find_thumb_glue),
 593         (find_arm_glue, record_arm_to_thumb_glue),
 594         (record_thumb_to_arm_glue): Likewise.
 595         * coff-ppc.c (ppc_coff_link_hash_table_create, record_toc),
 596         (ppc_allocate_toc_section): Likewise.
 597         * coff-rs6000.c (_bfd_xcoff_mkobject, _bfd_xcoff_archive_p): Likewise.
 598         * coff-sh.c (sh_relax_section): Likewise.
 599         * coff64-rs6000.c (xcoff64_archive_p): Likewise.
 600         * coffcode.h (handle_COMDAT, coff_new_section_hook),
 601         (coff_set_alignment_hook, coff_mkobject),
 602         (coff_compute_section_file_positions): Likewise.
 603         * coffgen.c (coff_make_empty_symbol, coff_bfd_make_debug_symbol),
 604         (coff_find_nearest_line_with_names),
 605         ( bfd_coff_set_symbol_class): Likewise.
 606         * cofflink.c (_bfd_coff_link_hash_table_create),
 607         (_bfd_coff_link_input_bfd): Likewise.
 608         * dwarf1.c (alloc_dwarf1_unit, alloc_dwarf1_func): Likewise.
 609         * dwarf2.c (read_abbrevs, read_attribute_value, add_line_info),
 610         (build_line_info_table, sort_line_sequences),
 611         (line_info_add_include_dir, line_info_add_file_name),
 612         (decode_line_info, scan_unit_for_symbols, parse_comp_unit),
 613         (place_sections, _bfd_dwarf2_slurp_debug_info): Likewise.
 614         * ecoff.c (_bfd_ecoff_mkobject, _bfd_ecoff_make_empty_symbol),
 615         (_bfd_ecoff_find_nearest_line),
 616         (_bfd_ecoff_bfd_link_hash_table_create): Likewise.
 617         * ecofflink.c (bfd_ecoff_debug_init): Likewise.
 618         * elf-hppa.h (_bfd_elf_hppa_gen_reloc_type): Likewise.
 619         * elf-m10300.c (mn10300_elf_relax_section),
 620         (elf32_mn10300_link_hash_table_create): Likewise.
 621         * elf-strtab.c (_bfd_elf_strtab_init): Likewise.
 622         * elf.c (make_mapping, copy_elf_program_header): Likewise.
 623         * elf32-arm.c (elf32_arm_link_hash_table_create),
 624         (elf32_arm_setup_section_lists, elf32_arm_check_relocs),
 625         (elf32_arm_new_section_hook): Likewise.
 626         * elf32-avr.c (elf_avr_new_section_hook),
 627         (elf32_avr_link_hash_table_create, get_local_syms),
 628         (elf32_avr_setup_section_lists): Likewise.
 629         * elf32-bfin.c (bfinfdpic_elf_link_hash_table_create),
 630         (bfin_link_hash_table_create): Likewise.
 631         * elf32-cr16.c (elf32_cr16_link_hash_table_create): Likewise.
 632         * elf32-cris.c (elf_cris_link_hash_table_create): Likewise.
 633         * elf32-csky.c (csky_elf_link_hash_table_create),
 634         (csky_elf_check_relocs, elf32_csky_setup_section_lists): Likewise.
 635         * elf32-frv.c (frvfdpic_elf_link_hash_table_create): Likewise.
 636         * elf32-hppa.c (elf32_hppa_link_hash_table_create),
 637         (elf32_hppa_setup_section_lists, get_local_syms): Likewise.
 638         * elf32-i386.c (elf_i386_check_relocs): Likewise.
 639         * elf32-lm32.c (lm32_elf_link_hash_table_create): Likewise.
 640         * elf32-m32r.c (m32r_elf_link_hash_table_create),
 641         (m32r_elf_check_relocs): Likewise.
 642         * elf32-m68hc1x.c (m68hc11_elf_hash_table_create),
 643         (elf32_m68hc11_setup_section_lists),
 644         (elf32_m68hc11_size_stubs): Likewise.
 645         * elf32-m68k.c (elf_m68k_link_hash_table_create): Likewise.
 646         * elf32-metag.c (elf_metag_link_hash_table_create),
 647         (elf_metag_setup_section_lists): Likewise.
 648         * elf32-microblaze.c (microblaze_elf_link_hash_table_create),
 649         (microblaze_elf_check_relocs): Likewise.
 650         * elf32-nds32.c (nds32_elf_link_hash_table_create),
 651         (nds32_elf_check_relocs): Likewise.
 652         * elf32-nios2.c (nios2_elf32_setup_section_lists),
 653         (get_local_syms, nios2_elf32_check_relocs),
 654         (nios2_elf32_link_hash_table_create): Likewise.
 655         * elf32-or1k.c (or1k_elf_link_hash_table_create),
 656         (or1k_elf_check_relocs): Likewise.
 657         * elf32-ppc.c (ppc_elf_modify_segment_map, update_plt_info): Likewise.
 658         * elf32-pru.c (pru_elf32_link_hash_table_create): Likewise.
 659         * elf32-s390.c (elf_s390_link_hash_table_create),
 660         (elf_s390_check_relocs): Likewise.
 661         * elf32-score.c (score_elf_create_got_section),
 662         (s3_elf32_score_new_section_hook),
 663         (elf32_score_link_hash_table_create): Likewise.
 664         * elf32-score7.c (score_elf_create_got_section),
 665         (s7_elf32_score_new_section_hook): Likewise.
 666         * elf32-sh.c (sh_elf_link_hash_table_create),
 667         (sh_elf_check_relocs): Likewise.
 668         * elf32-tic6x.c (elf32_tic6x_link_hash_table_create),
 669         (elf32_tic6x_new_section_hook, elf32_tic6x_check_relocs): Likewise.
 670         * elf32-tilepro.c (tilepro_elf_link_hash_table_create),
 671         (tilepro_elf_check_relocs): Likewise.
 672         * elf32-v850.c (remember_hi16s_reloc): Likewise.
 673         * elf32-vax.c (elf_vax_link_hash_table_create): Likewise.
 674         * elf32-xtensa.c (elf_xtensa_link_hash_table_create),
 675         (elf_xtensa_new_section_hook): Likewise.
 676         * elf64-alpha.c (elf64_alpha_bfd_link_hash_table_create),
 677         (get_got_entry, elf64_alpha_check_relocs): Likewise.
 678         * elf64-hppa.c (elf64_hppa_hash_table_create): Likewise.
 679         * elf64-ia64-vms.c (elf64_ia64_object_p): Likewise.
 680         * elf64-mmix.c (mmix_elf_new_section_hook): Likewise.
 681         * elf64-ppc.c (ppc64_elf_new_section_hook),
 682         (ppc64_elf_link_hash_table_create, update_local_sym_info),
 683         (update_plt_info, ppc64_elf_check_relocs): Likewise.
 684         * elf64-s390.c (elf_s390_link_hash_table_create),
 685         (elf_s390_check_relocs): Likewise.
 686         * elf64-x86-64.c (elf_x86_64_check_relocs): Likewise.
 687         * elflink.c (bfd_elf_link_record_local_dynamic_symbol),
 688         (_bfd_elf_link_find_version_dependencies, elf_link_add_object_symbols),
 689         (elf_link_add_archive_symbols, compute_bucket_count),
 690         (bfd_elf_size_dynsym_hash_dynstr, _bfd_elf_link_hash_table_create),
 691         (bfd_elf_get_bfd_needed_list, elf_link_swap_symbols_out),
 692         (bfd_elf_final_link): Likewise.
 693         * elfnn-aarch64.c (elfNN_aarch64_link_hash_table_create),
 694         (elfNN_aarch64_setup_section_lists, elfNN_aarch64_check_relocs),
 695         (elfNN_aarch64_new_section_hook): Likewise.
 696         * elfnn-ia64.c (elfNN_ia64_object_p): Likewise.
 697         * elfnn-riscv.c (riscv_elf_link_hash_table_create),
 698         (riscv_elf_check_relocs): Likewise.
 699         * elfxx-mips.c (_bfd_mips_elf_new_section_hook),
 700         (_bfd_mips_elf_add_symbol_hook, _bfd_mips_elf_check_relocs),
 701         (_bfd_mips_elf_modify_segment_map, _bfd_mips_elf_set_section_contents),
 702         (_bfd_mips_elf_link_hash_table_create): Likewise.
 703         * elfxx-sparc.c (_bfd_sparc_elf_link_hash_table_create),
 704         (_bfd_sparc_elf_check_relocs),
 705         (_bfd_sparc_elf_new_section_hook): Likewise.
 706         * elfxx-tilegx.c (tilegx_elf_link_hash_table_create),
 707         (tilegx_elf_check_relocs): Likewise.
 708         * elfxx-x86.c (_bfd_x86_elf_link_hash_table_create): Likewise.
 709         * format.c (bfd_check_format_matches): Likewise.
 710         * hash.c (_bfd_stringtab_init): Likewise.
 711         * ihex.c (ihex_scan): Likewise.
 712         * irix-core.c (irix_core_core_file_p): Likewise.
 713         * linker.c (bfd_wrapped_link_hash_lookup),
 714         (_bfd_generic_link_hash_table_create),
 715         (_bfd_generic_reloc_link_order): Likewise.
 716         * lynx-core.c (lynx_core_file_p): Likewise.
 717         * netbsd-core.c (netbsd_core_file_p): Likewise.
 718         * osf-core.c (osf_core_core_file_p): Likewise.
 719         * pdp11.c (some_aout_object_p, mkobject, make_empty_symbol),
 720         (link_hash_table_create, aout_link_write_other_symbol): Likewise.
 721         * peXXigen.c (_bfd_XX_bfd_copy_private_section_data): Likewise.
 722         * peicode.h (pe_mkobject): Likewise.
 723         * ppcboot.c (ppcboot_mkobject, ppcboot_canonicalize_symtab): Likewise.
 724         * ptrace-core.c (ptrace_unix_core_file_p): Likewise.
 725         * sco5-core.c (read_uarea): Likewise.
 726         * som.c (hppa_som_gen_reloc_type, som_object_p, som_prep_headers),
 727         (som_write_fixups, som_write_space_strings, som_write_symbol_strings),
 728         (som_finish_writing, som_canonicalize_symtab, som_new_section_hook),
 729         (som_bfd_copy_private_section_data, bfd_som_set_section_attributes),
 730         (bfd_som_attach_aux_hdr, som_write_armap): Likewise.
 731         * srec.c (srec_scan): Likewise.
 732         * syms.c (_bfd_generic_make_empty_symbol): Likewise.
 733         * targets.c (bfd_target_list): Likewise.
 734         * tekhex.c (first_phase, tekhex_sizeof_headers): Likewise.
 735         * trad-core.c (trad_unix_core_file_p): Likewise.
 736         * vms-alpha.c (vms_initialize, alpha_vms_bfd_link_hash_table_create),
 737         (vms_new_section_hook): Likewise.
 738         * wasm-module.c (wasm_make_empty_symbol): Likewise.
 739         * xcofflink.c (xcoff_get_section_contents),
 740         (_bfd_xcoff_bfd_link_hash_table_create, xcoff_set_import_path),
 741         (xcoff_find_function, bfd_xcoff_link_record_set, xcoff_build_ldsym),
 742         (bfd_xcoff_size_dynamic_sections, xcoff_link_input_bfd): Likewise.
 743
 744 2020-02-19  Alan Modra  <amodra@gmail.com>
 745
 746         * elfxx-riscv.c (riscv_multi_letter_ext_valid_p): Don't use C99.
 747
 748 2020-02-13  H.J. Lu  <hongjiu.lu@intel.com>
 749
 750         * plugin.c (try_load_plugin): Make plugin_list_iter an argument
 751         and use it if it isn't NULL.  Remove has_plugin_p argument.  Add
 752         a build_list_p argument.  Don't search plugin_list.  Short circuit
 753         when building the plugin list.
 754         (has_plugin): Renamed to has_plugin_list.
 755         (bfd_plugin_set_plugin): Don't set has_plugin.
 756         (bfd_plugin_specified_p): Check plugin_list instead.
 757         (build_plugin_list): New function.
 758         (load_plugin): Call build_plugin_list and use plugin_list.
 759
 760 2020-02-11  H.J. Lu  <hongjiu.lu@intel.com>
 761
 762         PR binutils/25355
 763         * plugin.c (try_claim): Always clean up for LTO wrapper.
 764         (try_load_plugin): Treat each object as independent.  Create a
 765         copy for plugin name.
 766
 767 2020-02-11  Nick Clifton  <nickc@redhat.com>
 768
 769         * elf32-msp430.c (msp430_final_link_relocate): Always use longs
 770         for addresses in print statements.
 771         (msp430_elf_relax_delete_bytes): Likewise.
 772         (msp430_elf_relax_add_words): Likewise.
 773         (msp430_elf_relax_section): Likewise.
 774
 775 2020-02-11  H.J. Lu  <hongjiu.lu@intel.com>
 776
 777         * plugin.c (add_symbols): Clear plugin_data memory.
 778
 779 2020-02-10  H.J. Lu  <hongjiu.lu@intel.com>
 780
 781         PR binutils/25355
 782         * configure.ac (HAVE_EXECUTABLE_SUFFIX): New AC_DEFINE.
 783         (EXECUTABLE_SUFFIX): Likewise.
 784         * config.in: Regenerated.
 785         * configure: Likewise.
 786         * plugin.c (bfd_plugin_close_and_cleanup): Removed.
 787         (plugin_list_entry): Add all_symbols_read, cleanup_handler,
 788         gcc, lto_wrapper, resolution_file, resolution_option, gcc_env,
 789         real_bfd, real_nsyms, real_syms, lto_nsyms and lto_syms.
 790         (get_lto_wrapper): New.
 791         (setup_lto_wrapper_env): Likewise.
 792         (current_plugin): Likewise.
 793         (register_all_symbols_read): Likewise.
 794         (register_cleanup): Likewise.
 795         (get_symbols): Likewise.
 796         (add_input_file): Likewise.
 797         (bfd_plugin_close_and_cleanup): Likewise.
 798         (claim_file): Removed.
 799         (register_claim_file): Set current_plugin->claim_file.
 800         (add_symbols): Make a copy of LTO symbols.  Set lto_nsyms and
 801         lto_syms in current_plugin.
 802         (try_claim): Use current_plugin->claim_file.  Call LTO plugin
 803         all_symbols_read handler.  Copy real symbols to plugin_data.
 804         Call LTO plugin cleanup handler.  Clean up for LTO wrapper.
 805         (try_load_plugin): Don't reuse the previous plugin for LTO
 806         wrapper.  Set up GCC LTO wrapper if possible.  Don't set
 807         plugin_list_iter->claim_file.
 808         (bfd_plugin_canonicalize_symtab): Use real LTO symbols if
 809         possible.
 810         * plugin.h (plugin_data_struct): Add real_bfd, real_nsyms and
 811         real_syms.
 812
 813 2020-02-10  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 814
 815         * elf32-msp430.c (msp430_elf_relax_section): Before relaxing a branch,
 816         check if previous instruction matches a conditional jump inserted
 817         earlier. Invert conditional jump and delete branch in this case.
 818
 819 2020-02-10  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 820
 821         * elf32-msp430.c (msp430_elf_relax_add_two_words): Rename to
 822         msp430_elf_relax_add_words. Support insertion of either one or two
 823         words.
 824         (msp430_elf_relax_section): Catch opcode of 0x3c00 when relocation
 825         needs to be grown. Handle insertion of branch instruction to replace
 826         jump.
 827
 828 2020-02-10  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 829
 830         * elf32-msp430.c (msp430_final_link_relocate): Add printf statements for
 831         debugging relocations.
 832         (msp430_elf_relax_delete_bytes): Likewise.
 833         (msp430_elf_relax_add_two_words): Likewise.
 834         (msp430_elf_relax_section): Likewise.
 835
 836 2020-02-10  Alan Modra  <amodra@gmail.com>
 837
 838         * archures.c: Wrap overlong z80 comments.
 839         * bfd-in2.h: Regenerate.
 840
 841 2020-02-07  Sergey Belyashov  <sergey.belyashov@gmail.com>
 842
 843         PR 25469
 844         * archures.c: Add GBZ80 and Z80N machine values.
 845         * reloc.c: Add BFD_RELOC_Z80_16_BE.
 846         * coff-z80.c: Add support for new reloc.
 847         * coffcode.h: Add support for new machine values.
 848         * cpu-z80.c: Add support for new machine names.
 849         * elf32-z80.c: Add support for new reloc.
 850         * bfd-in2.h: Regenerate.
 851         * libbfd.h: Regenerate.
 852
 853 2020-02-07  Nick Clifton  <nickc@redhat.com>
 854
 855         PR 23932
 856         * elf.c (rewrite_elf_program_header): Do not complain if no
 857         sections are mapped to a segment.
 858
 859 2020-02-06  H.J. Lu  <hongjiu.lu@intel.com>
 860
 861         PR ld/25490
 862         * elflink.c (_bfd_elf_gc_mark_extra_sections): Issue an error
 863         for garbage collection on __patchable_function_entries section
 864         without linked-to section.
 865
 866 2020-02-06  H.J. Lu  <hongjiu.lu@intel.com>
 867
 868         PR gas/25381
 869         * bfd-in2.h: Regenerated.
 870         * elflink.c (_bfd_elf_gc_mark_extra_sections): Call mark_hook
 871         on section if gc_mark of any of its linked-to sections is set
 872         and don't set gc_mark again.
 873         * section.c (asection): Add linked_to_symbol_name to map_head
 874         union.
 875
 876 2020-02-06  Maciej W. Rozycki  <macro@wdc.com>
 877
 878         * elf32-v850.c (v850_elf_relax_section): Fix the index used for
 879         reporting an unrecognized instruction with R_V850_LONGJUMP.
 880
 881 2020-02-05  Alan Modra  <amodra@gmail.com>
 882
 883         * elf64-ppc.c (ppc_stub_plt_branch): Match comment with reality.
 884
 885 2020-02-04  Alan Modra  <amodra@gmail.com>
 886
 887         * elf32-ppc.c (ppc_elf_relocate_section): After applying
 888         R_PPC_VLE_ADDR20, goto copy_reloc.
 889
 890 2020-02-02  H.J. Lu  <hongjiu.lu@intel.com>
 891
 892         * bfd-in2.h: Regenerated.
 893         * section.c (SEC_ASSEMBLER_SECTION_ID): Fix a typo in comments.
 894
 895 2020-02-02  H.J. Lu  <hongjiu.lu@intel.com>
 896
 897         PR gas/25380
 898         * bfd-in2.h: Regenerated.
 899         * ecoff.c (bfd_debug_section): Add section_id.
 900         * section.c (bfd_section): Add section_id.
 901         (SEC_ASSEMBLER_SECTION_ID): New.
 902         (BFD_FAKE_SECTION): Add section_id.
 903
 904 2020-02-01  Nick Clifton  <nickc@redhat.com>
 905
 906         * config.bfd: Move the c30-aout and tic30-aout targets onto the
 907         obsolete list.
 908
 909 2020-01-31  Sandra Loosemore  <sandra@codesourcery.com>
 910
 911         * elf-eh-frame.c (_bfd_elf_write_section_eh_frame): DW_EH_PE_datarel
 912         encodings are relative to the GOT on nios2, too.
 913
 914 2020-01-31  Alan Modra  <amodra@gmail.com>
 915
 916         * Makefile.am (elf32-target.h, elf64-target.h): Don't use a temp
 917         file.  Use $< and $@ in rules.
 918         (elf32-aarch64.c, elf64-aarch64.c): Likewise.
 919         (elf32-ia64.c, elf64-ia64.c): Likewise.
 920         (elf32-riscv.c, elf64-riscv.c): Likewise.
 921         (peigen.c, pepigen.c, pex64igen.c): Likewise.
 922         (elf32-aarch64.c, elf64-aarch64.c): Don't emit $srcdir on #line.
 923         (elf32-riscv.c, elf64-riscv.c): Likewise, and use $(SED).
 924         (elf32-ia64.c, elf64-ia64.c): Do emit #line.
 925         (peigen.c, pepigen.c, pex64igen.c): Likewise.
 926         * Makefile.in: Regenerate.
 927
 928 2020-01-31  Alan Modra  <amodra@gmail.com>
 929
 930         PR 4110
 931         * elf.c (setup_group): Don't clear entire section contents,
 932         just the padding after group flags.  Release alloc'd memory
 933         after a seek or read failure.
 934
 935 2020-01-16  Jon Turney  <jon.turney@dronecode.org.uk>
 936
 937         * peXXigen.c (pe_is_repro): New function.
 938         (_bfd_XX_print_private_bfd_data_common): Note timestamp is
 939         actually a build hash if PE_IMAGE_DEBUG_TYPE_REPRO is present.
 940
 941 2020-01-16  Jon Turney  <jon.turney@dronecode.org.uk>
 942
 943         * peXXigen.c (debug_type_names): Add names for new debug data type
 944         values.
 945
 946 2020-01-16  Jon Turney  <jon.turney@dronecode.org.uk>
 947
 948         * peXXigen.c (pe_print_debugdata): Fix the iteration variable for
 949         inner loop.  Fix a memory leak.
 950
 951 2020-01-30  Alan Modra  <amodra@gmail.com>
 952
 953         * coffgen.c (coff_real_object_p): Don't clear obj_coff_keep_syms
 954         or obj_coff_keep_strings here.
 955         (coff_get_normalized_symtab): Free external syms directly.
 956         * xcofflink.c (xcoff_link_input_bfd): Restore obj_coff_keep_syms
 957         on error exit path.
 958
 959 2020-01-27  Jim Wilson  <jimw@sifive.com>
 960
 961         * cpu-riscv.c (riscv_scan): New.
 962         (N): Change bfd_default_scan to riscv_scan.
 963
 964 2020-01-27  Andreas Schwab  <schwab@suse.de>
 965
 966         * Makefile.am (ALL_MACHINES): Remove cpu-plugin.lo.
 967         (ALL_MACHINES_CFILES): Remove cpu-plugin.c.
 968         * Makefile.in: Regenerate.
 969         * cpu-plugin.c: Remove.
 970         * archures.c (enum bfd_architecture): Remove bfd_arch_plugin.
 971         (bfd_plugin_arch): Remove declaration.
 972         * bfd-in2.h: Regenerate.
 973         * po/SRC-POTFILES.in: Regenerate.
 974
 975 2020-01-27  H.J. Lu  <hongjiu.lu@intel.com>
 976             Alan Modra  <amodra@gmail.com>
 977
 978         PR ld/25458
 979         * elflink.c (_bfd_elf_gc_mark_rsec): Mark all weak aliases.
 980
 981 2020-01-24  Jim Wilson  <jimw@sifive.com>
 982
 983         * elfxx-riscv.c (riscv_get_prefix_class): Format s case like others.
 984         (riscv_parse_prefixed_ext): Fix s extension comment and reword to
 985         avoid over long line.
 986
 987 2020-01-24  Nick Clifton  <nickc@redhat.com>
 988
 989         PR 25447
 990         * coffgen.c (_bfd_coff_close_and_cleanup): Do not clear the keep
 991         syms and keep strings flags as these may have been set in order to
 992         prevent a bogus call to free.
 993
 994 2020-01-23  Nick Clifton  <nickc@redhat.com>
 995
 996         * po/fr.po: Updated French translation.
 997
 998 2020-01-23  Alan Modra  <amodra@gmail.com>
 999
1000         PR 25444
1001         * elf.c (assign_file_positions_for_load_sections): Avoid divide
1002         by zero when p_align is zero.
1003
1004 2020-01-22  Maxim Blinov  <maxim.blinov@embecosm.com>
1005
1006         * bfd/elfnn-riscv.c (riscv_skip_prefix): New.
1007         (riscv_prefix_cmp): Likewise.
1008         (riscv_non_std_ext_p): Deleted.
1009         (riscv_std_sv_ext_p): Likewise.
1010         (riscv_non_std_sv_ext_p): Likewise.
1011         (riscv_merge_non_std_and_sv_ext): Rename to...
1012         (riscv_merge_multi_letter_ext): and modified to use riscv_prefix_cmp.
1013         (riscv_merge_arch_attr_info): Replace 3 calls to
1014         riscv_merge_non_std_and_sv_ext with single call to
1015         riscv_merge_multi_letter_ext.
1016         * bfd/elfxx-riscv.c (riscv_parse_std_ext): Break if we
1017         encounter a 'z' prefix.
1018         (riscv_get_prefix_class): New function, return prefix class based
1019         on first few characters of input string.
1020         (riscv_parse_config): New structure to factor out minor differences
1021         in extension class parsing behaviour.
1022         (riscv_parse_sv_or_non_std_ext): Rename to...
1023         (riscv_parse_prefixed_ext): and parameterise with
1024         riscv_parse_config.
1025         (riscv_std_z_ext_strtab, riscv_std_s_ext_strtab): New.
1026         (riscv_multi_letter_ext_valid_p): New.
1027         (riscv_ext_x_valid_p, riscv_ext_z_valid_p, riscv_ext_s_valid_p): New.
1028         (riscv_parse_subset): Delegate all non-single-letter parsing work
1029         to riscv_parse_prefixed_ext.
1030         * bfd/elfxx-riscv.h (riscv_isa_ext_class): New type.
1031         (riscv_get_prefix_class): Declare.
1032
1033 2020-01-22  Alan Modra  <amodra@gmail.com>
1034
1035         * elf64-ppc.c (struct ppc_link_hash_table): Add tga_group.
1036         (ppc64_elf_archive_symbol_lookup): Extract __tls_get_addr_opt for
1037         __tls_get_addr_desc.
1038         (ppc64_elf_size_stubs): Add section for linker generated
1039         __tls_get_addr_desc wrapper function.  Loop at least once if
1040         generating this function.
1041         (emit_tga_desc, emit_tga_desc_eh_frame): New functions.
1042         (ppc64_elf_build_stubs): Generate __tls_get_addr_desc.
1043
1044 2020-01-22  Alan Modra  <amodra@gmail.com>
1045
1046         * elf64-ppc.h (struct ppc64_elf_params): Add no_tls_get_addr_regsave.
1047         * elf64-ppc.c (struct ppc_link_hash_table): Add tga_desc and
1048         tga_desc_fd.
1049         (is_tls_get_addr): Match tga_desc and tga_desc_df too.
1050         (STDU_R1_0R1, ADDI_R1_R1): Define.
1051         (tls_get_addr_prologue, tls_get_addr_epilogue): New functions.
1052         (ppc64_elf_tls_setup): Set up tga_desc and tga_desc_fd.  Indirect
1053         tga_desc_fd to opt_fd, and tga_desc to opt.  Set
1054         no_tls_get_addr_regsave.
1055         (branch_reloc_hash_match): Add hash3 and hash4.
1056         (ppc64_elf_tls_optimize): Handle tga_desc_fd and tga_desc too.
1057         (ppc64_elf_size_dynamic_sections): Likewise.
1058         (ppc64_elf_relocate_section): Likewise.
1059         (plt_stub_size, build_plt_stub): Likewise.  Size regsave
1060         __tls_get_addr stub.
1061         (build_tls_get_addr_stub): Build regsave __tls_get_addr stub and
1062         eh_frame.
1063         (ppc_size_one_stub): Handle tga_desc_fd and tga_desc too.  Size
1064         eh_frame for regsave __tls_get_addr.
1065
1066 2020-01-22  Alan Modra  <amodra@gmail.com>
1067
1068         * elf64-ppc.c (ppc64_elf_size_stubs): Correct condition under
1069         which __tls_get_addr calls will be eliminated.
1070
1071 2020-01-20  Nick Clifton  <nickc@redhat.com>
1072
1073         * po/pt.po: Updates Portuguese translation.
1074         * po/ru.po: Updated Russian translation.
1075         * po/uk.po: Updated Ukranian translation.
1076
1077 2020-01-20  H.J. Lu  <hongjiu.lu@intel.com>
1078
1079         PR ld/25416
1080         * elf64-x86-64.c (elf_x86_64_check_tls_transition): Support
1081         "rex leal x@tlsdesc(%rip), %reg" and "call *x@tlsdesc(%eax)" in
1082         X32 mode.
1083         (elf_x86_64_relocate_section): In x32 mode, for GDesc -> LE
1084         transition, relax "rex leal x@tlsdesc(%rip), %reg" to
1085         "rex movl $x@tpoff, %reg", for GDesc -> IE transition, relax
1086         "rex leal x@tlsdesc(%rip), %reg" to
1087         "rex movl x@gottpoff(%rip), %eax".  For both transitions, relax
1088         "call *(%eax)" to "nopl (%rax)".
1089
1090 2020-01-20  Alan Modra  <amodra@gmail.com>
1091
1092         * elf64-ppc.c (LD_R11_0R3, CMPDI_R11_0, STD_R11_0R1, LD_R11_0R1),
1093         (MTLR_R11): Don't define.
1094         (LD_R0_0R3, CMPDI_R0_0): Define.
1095         (build_tls_get_addr_stub): Don't use r11 in stub.
1096
1097 2020-01-20  Alan Modra  <amodra@gmail.com>
1098
1099         * elf64-ppc.c (ppc_elf_hash_entry): New function, use throughout file.
1100         (defined_sym_val, is_tls_get_addr): Likewise.
1101
1102 2020-01-18  Nick Clifton  <nickc@redhat.com>
1103
1104         * version.m4 (BFD_VERSION): Set to 2.34.50.
1105         * configure: Regenerate.
1106         * po/bfd.pot: Regenerate.
1107
1108 2020-01-18  Nick Clifton  <nickc@redhat.com>
1109
1110         Binutils 2.34 branch created.
1111
1112 2020-01-17  Christian Biesinger  <cbiesinger@google.com>
1113
1114         * coff-arm.c: Fix spelling error (seperate).
1115         * elfxx-riscv.c (riscv_parse_sv_or_non_std_ext): Fix spelling
1116         error (seperate).
1117         * sysdep.h (strnlen): Fix spelling error (seperate).
1118
1119 2020-01-15  Lars Brinkhoff  <lars@nocrew.org>
1120
1121         PR 20694
1122         * pdp11.c (TARGET_PAGE_SIZE): Set to 8192.
1123
1124 2020-01-15  Alan Modra  <amodra@gmail.com>
1125
1126         PR 25384
1127         * elf64-ppc.c (ELIMINATE_COPY_RELOCS): Update comment.
1128         (ppc64_elf_adjust_dynamic_symbol): Don't allow .dynbss copies
1129         of function symbols unless dot symbols are present.  Do warn
1130         whenever one is created, regardles of whether a PLT entry is
1131         also emitted for the function symbol.
1132
1133 2020-01-14  Alan Modra  <amodra@gmail.com>
1134
1135         * som.c (som_bfd_count_ar_symbols): Error when file position
1136         of symbols on chains is not strictly increasing.
1137
1138 2020-01-14  Alan Modra  <amodra@gmail.com>
1139
1140         * vms.h (VMS_DEBUG): Define as 0.
1141         * vms-alpha.c (image_write): Move debug output after bounds check.
1142         Tidy bounds check.
1143         (_bfd_vms_slurp_eihd): Warning fix.
1144         (_bfd_vms_slurp_etir): Init variables to avoid bogus warnings.
1145
1146 2020-01-13  Alan Modra  <amodra@gmail.com>
1147
1148         * vms-alpha.c (_bfd_vms_slurp_egsd): Ensure minimum size even
1149         for "ignored" records.
1150
1151 2020-01-13  Alan Modra  <amodra@gmail.com>
1152
1153         * wasm-module.c (wasm_scan_name_function_section): Formatting.
1154         Delete asect name check.  Move asect NULL check to wasm_object_p.
1155         Correct bounds check of sizes against end.  Replace uses of
1156         bfd_zalloc with bfd_alloc, zeroing only necessary bytes.  Use
1157         just one bfd_release.
1158         (wasm_scan): Don't use malloc/strdup for section names,
1159         bfd_alloc instead.  Simplify code prefixing section name.
1160         Formatting.  Don't attempt to free memory here..
1161         (wasm_object_p): ..do so here.
1162
1163 2020-01-10  Szabolcs Nagy  <szabolcs.nagy@arm.com>
1164
1165         PR ld/22269
1166         * elf32-arm.c (elf32_arm_final_link_relocate): Use
1167         UNDEFWEAK_NO_DYNAMIC_RELOC.
1168         (allocate_dynrelocs_for_symbol): Likewise.
1169
1170 2020-01-10  Tamar Christina  <tamar.christina@arm.com>
1171
1172         PR 25210
1173         * elfnn-aarch64.c (_bfd_aarch64_create_stub_section): Remove elfclass.
1174
1175 2020-01-10  Alan Modra  <amodra@gmail.com>
1176
1177         * coff-alpha.c (alpha_ecoff_object_p): Calculate size in bfd_size_type.
1178
1179 2020-01-09  Nick Clifton  <nickc@redhat.com>
1180
1181         PR 25221
1182         * bfd.c (bfd_convert_section_contents): Check for a compress
1183         header size that is larger than the actual section size.
1184
1185 2020-01-08  Alan Modra  <amodra@gmail.com>
1186
1187         PR 25351
1188         * elflink.c (bfd_elf_final_link): Call _bfd_fix_excluded_sec_syms
1189         after removing sections.
1190
1191 2020-01-06  Jim Wilson  <jimw@sifive.com>
1192
1193         PR 25205
1194         * elfnn-riscv.c (riscv_elf_relocate_section) <R_RISCV_CALL>: Add
1195         check for !bfd_link_pic (info).
1196         <R_RISCV_CALL_PLT>: Move next to R_RISCV_CALL.
1197         <R_RISCV_JAL>: Add comment.
1198         (_bfd_riscv_relax_section): For plt.offset check, add check for
1199         bfd_link_pic (info).  Add comment.
1200
1201 2020-01-06  Alan Modra  <amodra@gmail.com>
1202
1203         * format.c (bfd_check_format_matches): Ignore bfd_error on target
1204         match failures.  Don't init to bfd_error_wrong_format before
1205         calling _bfd_check_format.
1206
1207 2020-01-06  Alan Modra  <amodra@gmail.com>
1208
1209         * vms-alpha.c (_bfd_vms_push, _bfd_vms_pop): Return pass/fail
1210         status rather than exiting on stack overflow or underflow.
1211         (_bfd_vms_slurp_etir): Adjust to suit.
1212
1213 2020-01-06  Alan Modra  <amodra@gmail.com>
1214
1215         * som.c (som_bfd_fill_in_ar_symbols): Bounds check som_dict index.
1216
1217 2020-01-06  Alan Modra  <amodra@gmail.com>
1218
1219         * mach-o.c (bfd_mach_o_read_dylinker): Don't read past end of
1220         command.  Check name offset is within command.
1221         (bfd_mach_o_read_dylib, bfd_mach_o_read_prebound_dylib),
1222         (bfd_mach_o_read_prebind_cksum, bfd_mach_o_read_twolevel_hints),
1223         (bfd_mach_o_read_fvmlib, bfd_mach_o_read_dysymtab),
1224         (bfd_mach_o_read_symtab, bfd_mach_o_read_uuid),
1225         (bfd_mach_o_read_linkedit, bfd_mach_o_read_str),
1226         (bfd_mach_o_read_dyld_info, bfd_mach_o_read_version_min),
1227         (bfd_mach_o_read_encryption_info, bfd_mach_o_read_source_version),
1228         (bfd_mach_o_read_encryption_info_64, bfd_mach_o_read_main),
1229         (bfd_mach_o_read_note, bfd_mach_o_read_build_version),
1230         (bfd_mach_o_read_segment): Similarly.
1231         (bfd_mach_o_read_thread): Properly bound check thread struct.
1232         Don't repeat checks on second loop.
1233         (bfd_mach_o_read_command): Fail on invalid command length.
1234
1235 2020-01-04  Alan Modra  <amodra@gmail.com>
1236
1237         * format.c (bfd_check_format_matches): Add preserve_match.
1238         Save initial bfd state in "preserve", matched bfd state in
1239         "preserve_match".  Save just the first match.  Release
1240         bfd_alloc memory.  Restore and finish preserved state as
1241         appropriate on all function exit paths.
1242
1243 2020-01-04  Alan Modra  <amodra@gmail.com>
1244
1245         * mmo.c (mmo_mkobject): Allocate tdata with bfd_zalloc.
1246
1247 2020-01-04  Alan Modra  <amodra@gmail.com>
1248
1249         * coffgen.c (coff_real_object_p): Free malloc'd memory on target
1250         match too.
1251
1252 2020-01-03  Nick Clifton  <nickc@redhat.com>
1253
1254         PR 25307
1255         (bfd_pef_parse_function_stubs): Correct the test that ensures that
1256         there is enough data remaining in the code buffer before
1257         attempting to read a function stub.
1258
1259 2020-01-03  Nick Clifton  <nickc@redhat.com>
1260
1261         PR 25308
1262         * elf-properties.c (_bfd_elf_convert_gnu_properties): Check the
1263         return value from bfd_malloc.
1264         * elf32-arm.c (bfd_elf32_arm_vfp11_fix_veneer_locations): Likewise.
1265         (bfd_elf32_arm_stm32l4xx_fix_veneer_locations): Likewise.
1266         (elf32_arm_filter_cmse_symbols): Likewise.
1267         (elf32_arm_write_section): Likewise.
1268         * mach-o.c (bfd_mach_o_core_fetch_environment): Likewise.
1269         (bfd_mach_o_follow_dsym): Likewise.
1270         * pef.c (bfd_pef_print_loader_section): Likewise.
1271         (bfd_pef_scan_start_address): Likewise.
1272         (bfd_pef_parse_function_stubs): Likewise.
1273         (bfd_pef_parse_symbols): Likewise.
1274
1275 2020-01-03  Sergei Trofimovich  <siarheit@google.com>
1276
1277         * elfnn-ia64.c (elfNN_ia64_merge_private_bfd_data): don't fail
1278         on binary inputs ld/PR25316.
1279         (is_ia64_elf): new helper to filter on ia64 objects.
1280
1281 2020-01-03  Jan Beulich  <jbeulich@suse.com>
1282
1283         * mach-o.c (cpusubtype, bfd_mach_o_header_p): Insert underscore
1284         in parameter names.
1285         (bfd_mach_o_scan): Insert underscore in two variable names.
1286
1287 2020-01-02  Sergey Belyashov  <sergey.belyashov@gmail.com>
1288
1289         * Makefile.am: Add z80-elf target support.
1290         * configure.ac: Likewise.
1291         * targets.c: Likewise.
1292         * Makefile.in: Regenerate.
1293         * configure: Regenerate.
1294         * config.bfd: Add z80-elf target support and new arches: ez80 and
1295         z180.
1296         * elf32-z80.c: New file.
1297         * archures.c: Add new z80 architectures: eZ80 and Z180.
1298         * coffcode.h: Likewise.
1299         * cpu-z80.c: Likewise.
1300         * coff-z80.c: Add new relocations for Z80 target and local label
1301         check.
1302         * reloc.c: Add new relocs.
1303         * bfd-in2.h: Regenerate.
1304         * libbfd.h: Regenerate.
1305
1306 2020-01-02  Tamar Christina  <tamar.christina@arm.com>
1307
1308         PR 25210
1309         PR 24753
1310         * elfnn-aarch64.c (_bfd_aarch64_create_stub_section): Set ELF class.
1311
1312 2020-01-01  Alan Modra  <amodra@gmail.com>
1313
1314         Update year range in copyright notice of all files.
1315
1316 For older changes see ChangeLog-2019
1317 \f
1318 Copyright (C) 2020 Free Software Foundation, Inc.
1319
1320 Copying and distribution of this file, with or without modification,
1321 are permitted in any medium without royalty provided the copyright
1322 notice and this notice are preserved.
1323
1324 Local Variables:
1325 mode: change-log
1326 left-margin: 8
1327 fill-column: 74
1328 version-control: never
1329 End: