binutils/ChangeLog

   1 2015-04-27  Andreas Krebbel  <krebbel@linux.vnet.ibm.com>
   2
   3         * readelf.c (display_s390_gnu_attribute): New function.
   4         (process_s390_specific): New function.
   5         (process_arch_specific): Call process_s390_specific.
   6
   7 2015-04-24  Nick Clifton  <nickc@redhat.com>
   8
   9         PR 18313
  10         * ieee.c (ieee_read_cxx_class): Initialise the varargs variable.
  11         * readelf.c (uncompress_section_contents): Zero initialise the
  12         zstream structure.
  13
  14 2015-04-23  H.J. Lu  <hongjiu.lu@intel.com>
  15
  16         PR binutils/18209
  17         * objcopy.c (setup_section): Copy compress status.
  18
  19 2015-04-15  H.J. Lu  <hongjiu.lu@intel.com>
  20
  21         * NEWS: Mention
  22         --compress-debug-sections=[none|zlib|zlib-gnu|zlib-gabi].
  23
  24 2015-04-14  Nick Clifton  <nickc@redhat.com>
  25
  26         * readelf.c (target_specific_reloc_handling): Add code to handle
  27         RL78 complex relocs.
  28
  29 2015-04-13  Doug Evans  <dje@google.com>
  30
  31         PR binutils/18218
  32         * readelf.c (printable_section_name): Constify sec argument.
  33         (apply_relocations): Ditto.  New arg "size".  All callers updated.
  34         (load_specific_debug_section): Constify sec argument.
  35         Remove side-effect of modifying sec->sh_size.
  36
  37 2015-04-09  H.J. Lu  <hongjiu.lu@intel.com>
  38
  39         * objcopy.c (do_debug_sections): Use bit patterns.
  40         (copy_object): Return FALSE for compress_zlib, compress_gnu_zlib
  41         and compress_gabi_zlib on non-ELF input.
  42         (copy_file): Don't check non-ELF input here.
  43
  44 2015-04-09  Nick Clifton  <nickc@redhat.com>
  45
  46         * readelf.c (get_machine_flags): Report the setting of the string
  47         insn using bits.
  48
  49 2015-04-08  H.J. Lu  <hongjiu.lu@intel.com>
  50
  51         * objcopy.c (do_debug_sections): Add compress_zlib,
  52         compress_gnu_zlib and compress_gabi_zlib.
  53         (copy_options): Use optional_argument on compress-debug-sections.
  54         (copy_usage): Update --compress-debug-sections.
  55         (copy_file): Handle compress_zlib, compress_gnu_zlib and
  56         compress_gabi_zlib.
  57         (copy_main): Handle
  58         --compress-debug-sections={none|zlib|zlib-gnu|zlib-gabi}.
  59         * doc/binutils.texi: Document
  60         --compress-debug-sections={none|zlib|zlib-gnu|zlib-gabi}.
  61
  62 2015-04-08  H.J. Lu  <hongjiu.lu@intel.com>
  63
  64         * objcopy.c (copy_usage): Replace "--interleave [<number>]" with
  65         --interleave[=<number>].
  66
  67 2015-04-05  H.J. Lu  <hongjiu.lu@intel.com>
  68
  69         * readelf.c (get_elf_section_flags): Support SHF_COMPRESSED.
  70         (get_compression_header): New.
  71         (process_section_headers): Dump compression header if needed.
  72         (uncompress_section_contents): Don't free compressed_buffer here.
  73         (load_specific_debug_section): Free the compressed buffer, update
  74         the section buffer and the section size if uncompress is
  75         successful.
  76
  77 2015-04-02  H.J. Lu  <hongjiu.lu@intel.com>
  78
  79         * configure: Regenerated.
  80
  81 2015-04-02  Mike Frysinger  <vapier@gentoo.org>
  82
  83         * MAINTAINERS: Update my e-mail address.
  84
  85 2015-04-01  H.J. Lu  <hongjiu.lu@intel.com>
  86
  87         * configure: Regenerated.
  88
  89 2015-03-31  H.J. Lu  <hongjiu.lu@intel.com>
  90
  91         * configure.ac: Revert the AM_ZLIB change.
  92         * Makefile.in: Regenerated.
  93         * aclocal.m4: Likewise.
  94         * configure: Likewise.
  95
  96 2015-03-31  H.J. Lu  <hongjiu.lu@intel.com>
  97
  98         * Makefile.am (ZLIB): New.
  99         (ZLIBINC): Likewise.
 100         (AM_CFLAGS): Add $(ZLIBINC).
 101         (readelf_LDADD): Add $(ZLIB).
 102         * configure.ac (AM_ZLIB): Removed.
 103         (zlibdir): New.  AC_SUBST.
 104         (zlibinc): Likewise.
 105         Add --with-system-zlib.
 106         * Makefile.in: Regenerated.
 107         * config.in: Likewise.
 108         * configure: Likewise.
 109
 110 2015-03-19  Nick Clifton  <nickc@redhat.com>
 111
 112         * readelf.c (get_machine_flags): Decode RL78's G13 and G14 flags.
 113
 114 2015-03-18  Jon Turney  <jon.turney@dronecode.org.uk>
 115             Nick Clifton  <nickc@redhat.com>
 116
 117         PR binutils/18087
 118         * doc/binutils.texi: Note that when objcopy compresses debug
 119         sections the compression is only performed if it makes the section
 120         smaller.
 121
 122 2015-03-10  H.J. Lu  <hongjiu.lu@intel.com>
 123
 124         PR binutils/18101
 125         * readelf.c (parse_args): Move nothing to do warning to ...
 126         (main): Here.
 127
 128 2015-03-10  Nick Clifton  <nickc@redhat.com>
 129
 130         PR binutils/18101
 131         * readelf.c (parse_args): Enhance check for nothing to do by
 132         accounting for the --wide option.
 133
 134         PR binutils/17636
 135         * objcopy.c (copy_object): Avoid calling fatal as that does not
 136         allow the parent to clean up temporary files.
 137
 138 2015-03-10  Yuri Gribov  <y.gribov@samsung.arm>
 139
 140         PR ld/16572
 141         * readelf.c: Remove support for ELF_ARM_HASENTRY.
 142
 143 2015-03-05  Nick Clifton  <nickc@redhat.com>
 144
 145         PR binutils/18064
 146         * doc/binutils.texi (objcopy): Extend description of
 147         --add-gnu-debuglink option to explain that the separate debug info
 148         file must exist.  Add a description of what to do if the debug
 149         info file is built in one place but then installed into a separate
 150         location.
 151
 152 2015-03-05  Nick Clifton  <nickc@redhat.com>
 153
 154         PR binutils/17994
 155         * dlltool.c (temp_file_to_remove): New local array.
 156         (unlink_temp_files): New functions - unlinks any file in the
 157         temp_file_to_remove array, unless dotdeltemps is set.
 158         (gen_exp_file): Add temp files to array.
 159         (make_head): Likewise.
 160         (make_delay_head): Likewise.
 161         (make_tail): Likewise.
 162         (gen_lib_file): Call unlink_temp_files.
 163
 164 2015-02-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 165
 166         * objcopy.c (update_sections): New list.
 167         (command_line_switch): Add OPTION_UPDATE_SECTION.
 168         (copy_options): Add update-section.
 169         (copy_usage): Document new option.
 170         (is_update_section): New function.
 171         (is_strip_section_1): Add check for attempt to update and remove
 172         the same section.
 173         (copy_object): Update size and content of requested sections.
 174         (skip_section): Don't copy for updated sections.
 175         (copy_main): Handle --update-section.
 176         * doc/binutils.texi (objcopy): Add description of --update-section
 177         option.
 178         * NEWS: Mention --update-section option.
 179
 180 2015-02-26  Nick Clifton  <nickc@redhat.com>
 181
 182         PR binutils/17512
 183         * coffgrok.c (do_type): Check for an out of range tag index.
 184         Check for integer overflow computing array dimension.
 185         (do_define): Likewise.
 186
 187 2015-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 188
 189         * objcopy.c (init_section_add): Rename optarg to arg in order to
 190         avoid shadowing a global variable.
 191
 192 2015-02-26  Nick Clifton  <nickc@redhat.com>
 193
 194         PR binutils/17512
 195         * resrc.c (write_rc_messagetable): Tighten check for invalid
 196         message lengths.
 197
 198         * dwarf.c (display_debug_loc): Pacify the undefined behaviour
 199         sanitizer by simplifying address difference calculation.
 200         (struct Frame_Chunk): Change type of cfa_offset to dwarf_vma in
 201         order to avoid arithmetic overflows.
 202         (frame_display_row): Cast cfa_offset before printing it.
 203         (display_debug_frames): Likewise.
 204         Check for an unexpected segment size.
 205         Chnage type of 'l' local to dwarf_vma and cast it back to an int
 206         when printing.
 207         (process_cu_tu_index): Tighten check for an invalid ncols value.
 208         * readelf.c (process_corefile_note_segment): Check for
 209         inote.descdata extending beyond the end of the section.
 210         (process_v850_notes): Likewise.
 211
 212 2015-02-26  Terry Guo  <terry.guo@arm.com>
 213
 214         * readelf.c (arm_attr_tag_ABI_HardFP_use): Update how we
 215         display it.
 216
 217 2015-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 218
 219         * objcopy.c (init_section_add): New function.
 220         (section_add_load_file): New function.
 221         (copy_main): Make use of new functions.
 222
 223 2015-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 224
 225         * od-elf32_avr.c: Add elf32-avr.h include.
 226         (OPT_AVRPROP): Define.
 227         (options[]): Add 'avr-prop' entry.
 228         (elf32_avr_help): Add avr-prop help text.
 229         (elf32_avr_dump_avr_prop): New function.
 230         (elf32_avr_dump): Add check for avr-prop.
 231
 232 2015-02-24  Nick Clifton  <nickc@redhat.com>
 233
 234         * readelf.c (get_machine_flags): Remove deprecated V850 machine
 235         flags.
 236         (get_v850_section_type_name): New function.  Handles V850 special
 237         sections.
 238         (get_section_type_name): Add support for V850.
 239         (get_v850_elf_note_type): New function.  Returns the name of a
 240         V850 note.
 241         (print_v850_note): New function.  Prints a V850 note.
 242         (process_v850_notes): New function.  Prints V850 notes.
 243         (process_note_sections): Add support for V850.
 244
 245 2015-02-24  Mike Frysinger  <vapier@gentoo.org>
 246
 247         PR binutils/17531
 248         * readelf.c (process_symbol_table): Declare chained.  Increment it
 249         in every loop.  Abort when chained is larger than nchains.  Move
 250         error check outside of chain loop.
 251
 252 2015-02-24  Dmitry Antipov  <dantipov@nvidia.com>
 253
 254         * readelf.c (find_symbol_for_address): Use a binary search to
 255         speed up symbol location.  Skip check for function symbol type.
 256         (*_unw_aux_info): Add funtab and nfuns fields contains a sorted
 257         list of function symbols.
 258         (dump_ia64_unwind): Initialise the funtab and nfuns fields and
 259         pass them to find_symbol_for_address.
 260         (dump_hppa_unwind): Likewise.
 261         (arm_print_vma_and_name): Pass funtab to find_symbol_for_address.
 262         (dump_arm_unwind): Initialise the funtab and nfuns fields.
 263
 264 2015-02-24  Nick Clifton  <nickc@redhat.com>
 265
 266         * objdump.c (dump_section): Extend the warning message displayed
 267         when a section cannot be loaded.
 268
 269 2015-02-21  Mike Frysinger  <vapier@gentoo.org>
 270
 271         * readelf.c (process_program_headers): Add newline to warning
 272         message.
 273
 274 2015-02-20  Andreas Arnez  <arnez@linux.vnet.ibm.com>
 275
 276         * readelf.c (get_note_type): Add NT_S390_VXRS_LOW and
 277         NT_S390_VXRS_HIGH.
 278
 279 2015-02-13  Nick Clifton  <nickc@redhat.com>
 280
 281         PR binutils/17512
 282         * dwarf.c (read_leb128): Fix test for shift becoming too large.
 283
 284         * coffgrok.c (do_define): Add check for type size overflow.
 285         * srconv.c (walk_tree_sfile): Check that enough sections are
 286         available before parsing.
 287         (prescan): Likewise.
 288
 289         PR binutils/17531
 290         * dwarf.c (display_debug_aranges): Add check for an excessive
 291         ar_length value.
 292         (process_cu_tu_index): Check for a row * columns sum being too
 293         large.
 294
 295 2015-02-13  Alan Modra  <amodra@gmail.com>
 296
 297         * dwarf.c: Formatting, whitespace.
 298         (process_debug_info): Style fix.
 299
 300 2015-02-11  Nick Clifton  <nickc@redhat.com>
 301
 302         * rl78-decode.opc: Add 'a' attribute to instructions that support
 303         [HL+0] addressing.
 304         * rl78-decode.c: Regenerate.
 305         * rl78-dis.c (print_insn_rl78): Display the offset in [HL+0]
 306         addresses.
 307
 308 2015-02-11  Nick Clifton  <nickc@redhat.com>
 309
 310         PR binutils/17531
 311         * dwarf.c (display_debug_pubnames_worker): Work around compiler
 312         bug checking address ranges.
 313         (display_debug_frames): Likewise.
 314         (display_gdb_index): Likewise.
 315         (process_cu_tu_index): Add range check on the ncols value.
 316
 317 2015-02-10  Nick Clifton  <nickc@redhat.com>
 318
 319         PR binutils/17512
 320         * dwarf.c (eh_addr_size): Use an unsigned type.
 321         (size_of_encoded_value): Return an unsigned type.
 322         (read_leb128): Break if the shift becomes too big.
 323         (process_extended_line_op): Do not read the address if the length
 324         is too long.
 325         (read_cie): Warn and fail if the pointer size or segment size are
 326         too big.
 327         * dwarf.h (DWARF2_External_LineInfo): Delete unused and incorrect
 328         structure definition.
 329         (DWARF2_External_PubNames): Likewise.
 330         (DWARF2_External_CompUnit): Likewise.
 331         (DWARF2_External_ARange): Likewise.
 332         (DWARF2_Internal_LineInfo): Use dwarf_vma type for
 333         li_prologue_length.
 334         (eh_addr_size): Update prototype.
 335
 336         PR binutils/17531
 337         * dwarf.c (process_debug_info): Zero the debug information array
 338         since correct initialisation cannot be relied upon.
 339         (process_cu_tu_index): Improve range checks.
 340
 341         PR binutils/17531
 342         * dwarf.c (display_debug_pubnames_worker): Use dwarf_vma type for
 343         offset.
 344         * readelf.c (dump_relocations): Handle printing offsets which are
 345         MIN_INT.
 346         (process_corefile_note_segment): Add range check of the namesz
 347         field.
 348
 349 2015-02-09  Mark Wielaard  <mjw@redhat.com>
 350
 351         * dwarf.c (read_and_display_attr_value): Handle DW_LANG_Fortran03
 352         and DW_LANG_Fortran08.
 353
 354 2015-02-06  Nick Clifton  <nickc@redhat.com>
 355
 356         PR binutils/17512
 357         * dwarf.c (display_debug_frames): Fix range checks to work on
 358         32-bit binaries complied on a 64-bit host.
 359
 360         PR binutils/17531
 361         * dwarf.c (xcmalloc): Fail if the arguments are too big.
 362         (xcrealloc): Likewise.
 363         (xcalloc2): Likewise.
 364         * readelf.c (process_mips_specific): Fail if an option has an
 365         invalid size.
 366
 367 2015-02-05  Alan Modra  <amodra@gmail.com>
 368
 369         PR binutils/17926
 370         * dwarf.c (dwarf_select_sections_by_letters): Don't refer to optarg.
 371
 372 2015-02-04  Nick Clifton  <nickc@redhat.com>
 373
 374         PR binutils/17531
 375         * dwarf.c (read_and_display_attr_value): Test for a block length
 376         being so long that it wraps around to before the start of the block.
 377         (process_debug_info): Test for section_begin wrapping around to
 378         before the start of the section.
 379         (display_gdb_index): Test for num_cus being so large that the end
 380         address wraps around to before the start of the section.
 381         (process_cu_tu_index): Test for j being so large that the section
 382         index pool wraps around to before the start of the section.
 383
 384 2015-02-03  Nick Clifton  <nickc@redhat.com>
 385
 386         PR binutils/17531
 387         * dwarf.c (process_debug_info): Add range check.
 388         (display_debug_pubnames_worker): Likewise.
 389         (display_gdb_index): Fix range check.
 390         (process_cu_tu_index): Add range check.
 391         * readelf.c (get_data): Change parameter types from size_t to
 392         bfd_size_type.  Add checks for loss of accuracy when casting from
 393         bfd_size_type to size_t.
 394         (get_dynamic_data): Likewise.
 395         (process_section_groups): Limit number of error messages.
 396
 397 2015-02-03  Nick Clifton  <nickc@redhat.com>
 398
 399         PR binutils/17512
 400         * objdump.c (display_any_bfd): Fail if archives nest too deeply.
 401
 402 2015-01-28  James Bowman  <james.bowman@ftdichip.com>
 403
 404         * readelf.c: Add FT32 support.
 405
 406 2015-01-27  Nick Clifton  <nickc@redhat.com>
 407
 408         PR binutils/17512
 409         * dlltool.c (identify_search_archive): If the last archive was the
 410         same as the current archive, terminate the loop.
 411
 412         * addr2line.c (slurp_symtab): If the symcount is zero, free the
 413         symbol table pointer.
 414
 415         * rcparse.y: Add checks to avoid integer divide by zero.
 416         * rescoff.c (read_coff_rsrc): Add check on the size of the
 417         resource section.
 418         (read_coff_res_dir): Add check on the nesting level.
 419         Check for resource names overrunning the buffer.
 420         * resrc.c (write_rc_messagetable): Update formatting.
 421         Add check of 'elen' being zero.
 422
 423 2015-01-23  Nick Clifton  <nickc@redhat.com>
 424
 425         * nlmconv.c (powerpc_mangle_relocs): Fix build errors introduced
 426         by recent delta, when compiling on for a 32-bit host.
 427
 428 2015-01-21  Nick Clifton  <nickc@redhat.com>
 429
 430         PR binutils/17512
 431         * addr2line.c (main): Call bfd_set_error_program_name.
 432         * ar.c (main): Likewise.
 433         * coffdump.c (main): Likewise.
 434         * cxxfilt.c (main): Likewise.
 435         * dlltool.c (main): Likewise.
 436         * nlmconv.c (main): Likewise.
 437         * nm.c (main): Likewise.
 438         * objdump.c (main): Likewise.
 439         * size.c (main): Likewise.
 440         * srconv.c (main): Likewise.
 441         * strings.c (main): Likewise.
 442         * sysdump.c (main): Likewise.
 443         * windmc.c (main): Likewise.
 444         * windres.c (main): Likewise.
 445         * objcopy.c (main): Likewise.
 446         (copy_relocations_in_section): Check for relocs without associated
 447         symbol pointers.
 448
 449 2015-01-21  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
 450
 451         * MAINTAINERS: Add self to ARM maintainers list.
 452
 453 2015-01-21  Nick Clifton  <nickc@redhat.com>
 454
 455         PR binutils/17512
 456         * coffgrok.c (do_type): Check that computed ref exists.
 457         (doit): Add range checks when computing section for scope.
 458
 459 2015-01-12  H.J. Lu  <hongjiu.lu@intel.com>
 460
 461         * dwarf.c (process_debug_info): Properly check abbrev size.
 462
 463 2015-01-12  Nick Clifton  <nickc@redhat.com>
 464
 465         PR binutils/17531
 466         * dwarf.c (process_debug_info): Check for abbrev_base being larger
 467         than the section size.
 468         (process_cu_tu_index): Use xcalloc2 to allocate the CU and TU
 469         arrays.
 470         (xcalloc2): New function.  Like xcalloc, but checks for overflow.
 471         (display_debug_addr): Use xcalloc to allocate the debug_addr_info
 472         array.  Check for an address_base that is too large.
 473
 474         * dwarf.h (xcalloc2): Prototype.
 475
 476 2015-01-12  Alan Modra  <amodra@gmail.com>
 477
 478         * prdbg.c (print_debugging_info): Don't use void* for function
 479         pointer param.
 480         * budbg.h (print_debugging_info): Update prototype.
 481
 482 2015-01-08  Nick Clifton  <nickc@redhat.com>
 483
 484         PR binutils/17512
 485         * ojcopy.c (copy_object): Free the symbol table if no symbols
 486         could be loaded.
 487         (copy_file): Use bfd_close_all_done to close files that could not
 488         be copied.
 489
 490         * sysdump.c (getINT): Fail if reading off the end of the buffer.
 491         Replace call to abort with a call to fatal.
 492         (getCHARS): Prevetn reading off the end of the buffer.
 493
 494         * nlmconv.c (i386_mangle_relocs): Skip relocs without an
 495         associated symbol.
 496         (powerpc_mangle_relocs): Skip unrecognised relocs.  Check address
 497         range before applying a reloc.
 498
 499 2015-01-07  Nick Clifton  <nickc@redhat.com>
 500
 501         PR binutils/17512
 502         * dlltool.c (scan_obj_file): Break loop if the last archive
 503         displayed matches the current archive.
 504
 505         * objdump.c (display_any_bfd): Add a depth limit to nested archive
 506         display in order to avoid infinite loops.
 507         * srconv.c: Replace calls to abort with calls to fatal with an
 508         error message.
 509
 510 2015-01-06  Nick Clifton  <nickc@redhat.com>
 511
 512         PR binutils/17512
 513         * coffdump.c (dump_coff_section): Check for a symbol being
 514         available before printing its name.
 515         (main): Check the return value from coff_grok.
 516         * coffgrok.c: Reformat and tidy.
 517         Add range checks to most functions.
 518         (coff_grok): Return NULL if the input bfd is not in a COFF
 519         format.
 520         * coffgrok.h: Reformat and tidy.
 521         (struct coff_section): Change the nrelocs field to unsigned.
 522         * srconv.c (main): Check the return value from coff_grok.
 523
 524 2015-01-05  Nick Clifton  <nickc@redhat.com>
 525
 526         PR binutils/17512
 527         * nm.c (print_symbol): Add 'is_synthetic' parameter.  Use it to
 528         help initialize the info.elfinfo field.
 529         (print_size_symbols): Add 'synth_count' parameter.  Use it to set
 530         the is_synthetic parameter when calling print_symbol.
 531         (print_symbols): Likewise.
 532         (display_rel_file): Pass synth_count to printing function.
 533         (display_archive): Break loop if the last archive displayed
 534         matches the current archive.
 535         * size.c (display_archive): Likewise.
 536
 537 2015-01-05  Nick Clifton  <nickc@redhat.com>
 538
 539         PR binutils/17531
 540         * dwarf.c (alloc_num_debug_info_entries): New variable.
 541         (process_debug_info): Set it.  Use it to avoid displaying
 542         attributes for which there is no info.
 543         (display_debug_abbrev): Check that the debug_info_entry index is
 544         valid before using it.
 545         (display_loc_list_dwo): Likewise.
 546         (process_cu_tu_index): Add range check for an overlarge dw_sect
 547         value.
 548         (free_debug_memory): Reset alloc_num_debug_info_entries.
 549         * readelf.c (slurp_ia64_unwind_table): Warn if the reloc could not
 550         be indentified.
 551         (dynamic_section_mips_val): Warn if the timestamp is invalid.
 552         (print_mips_got_entry): Add a data_end parameter.  Warn if a read
 553         would go beyond the end of the data, and return an error value.
 554         (process_mips_specific): Do not read options from beyond the end
 555         of the section.
 556         Correct code to display optional data at the end of an option.
 557         Warn if there are too many GOT symbols.
 558         Update calls to print_mips_got_entry, and handle error returns.
 559
 560 2015-01-05  Daniel Klauer  <daniel.c.klauer@web.de>
 561
 562         PR binutils/17489
 563         * doc/binutils.texi (dlltool): Correct description of --kill-at
 564         option.
 565
 566 2015-01-01  Alan Modra  <amodra@gmail.com>
 567
 568         * version.c (print_version): Just print current year.
 569
 570 2015-01-01  Alan Modra  <amodra@gmail.com>
 571
 572         Update year range in copyright notice of all files.
 573
 574 For older changes see ChangeLog-2014
 575 \f
 576 Copyright (C) 2015 Free Software Foundation, Inc.
 577
 578 Copying and distribution of this file, with or without modification,
 579 are permitted in any medium without royalty provided the copyright
 580 notice and this notice are preserved.
 581
 582 Local Variables:
 583 mode: change-log
 584 left-margin: 8
 585 fill-column: 74
 586 version-control: never
 587 End: