gdb/ChangeLog

   1 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
   2             Chris January  <chris.january@arm.com>
   3
   4         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
   5         types for Fortran.
   6
   7 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
   8             Chris January  <chris.january@arm.com>
   9             David Lecomber  <david.lecomber@arm.com>
  10
  11         * f-exp.y (BINOP_INTRINSIC): New token.
  12         (exp): New parser rule handling BINOP_INTRINSIC.
  13         (f77_keywords): Add new builtin procedures.
  14         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
  15         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  16         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
  17         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  18         (print_unop_subexp_f): New function.
  19         (print_binop_subexp_f): New function.
  20         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  21         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  22         (dump_subexp_body_f): Likewise.
  23         (operator_check_f): Likewise.
  24         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  25         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
  26
  27 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  28
  29         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
  30         UNOP_KIND.
  31         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
  32         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
  33         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
  34         (operator_length_f): New fuction.
  35         (print_subexp_f): New function.
  36         (op_name_f): New function.
  37         (dump_subexp_body_f): New function.
  38         (operator_check_f): New function.
  39         (exp_descriptor_f): Replace standard expression handling functions
  40         with new functions.
  41         * gdb/fortran-operator.def: New file.
  42         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
  43         * gdb/std-operator.def: Remove UNOP_KIND.
  44
  45 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  46
  47         * std-operator.def: Remove unbalanced, stray double quote
  48         character.
  49
  50 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
  51             Chris January  <chris.january@arm.com>
  52             Daniel Everett  <daniel.everett@arm.com>
  53             Nick Forrington  <nick.forrington@arm.com>
  54             Richard Bunt  <richard.bunt@arm.com>
  55
  56         * cp-valprint.c (cp_print_value_fields): Allow an additional level
  57         of depth when printing anonymous structs or unions.
  58         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
  59         Don't print either the top-level value, or the children if the
  60         max-depth is exceeded.
  61         (ppscm_print_children): When printing the key of a map, allow one
  62         extra level of depth.
  63         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
  64         print either the top-level value, or the children if the max-depth
  65         is exceeded.
  66         (print_children): When printing the key of a map, allow one extra
  67         level of depth.
  68         * python/py-value.c (valpy_format_string): Add max_depth keyword.
  69         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
  70         (user_print_options): Initialise max_depth field.
  71         (val_print_scalar_or_string_type_p): New function.
  72         (val_print): Check to see if the max depth has been reached.
  73         (val_print_check_max_depth): Define new function.
  74         (show_print_max_depth): New function.
  75         (_initialize_valprint): Add 'print max-depth' option.
  76         * valprint.h (struct value_print_options) <max_depth>: New field.
  77         (val_print_check_max_depth): Declare new function.
  78         * NEWS: Document new feature.
  79
  80 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
  81
  82         * ada-lang.c (ada_language_defn): Initialise new field.
  83         * c-lang.c (c_is_string_type_p): New function.
  84         (c_language_defn): Initialise new field.
  85         (cplus_language_defn): Initialise new field.
  86         (asm_language_defn): Initialise new field.
  87         (minimal_language_defn): Initialise new field.
  88         * c-lang.h (c_is_string_type_p): Declare new function.
  89         * d-lang.c (d_language_defn): Initialise new field.
  90         * f-lang.c (f_is_string_type_p): New function.
  91         (f_language_defn): Initialise new field.
  92         * go-lang.c (go_is_string_type_p): New function.
  93         (go_language_defn): Initialise new field.
  94         * language.c (default_is_string_type_p): New function.
  95         (unknown_language_defn): Initialise new field.
  96         (auto_language_defn): Initialise new field.
  97         * language.h (struct language_defn) <la_is_string_type_p>: New
  98         member variable.
  99         (default_is_string_type_p): Declare new function.
 100         * m2-lang.c (m2_language_defn): Initialise new field.
 101         * objc-lang.c (objc_language_defn): Initialise new field.
 102         * opencl-lang.c (opencl_language_defn): Initialise new field.
 103         * p-lang.c (pascal_is_string_type_p): New function.
 104         (pascal_language_defn): Initialise new field.
 105         * rust-lang.c (rust_is_string_type_p): New function.
 106         (rust_language_defn): Initialise new field.
 107
 108 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 109
 110         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 111         New field.
 112         * ada-lang.c (ada_language_defn): Initialise new field.
 113         * c-lang.c (c_language_defn): Likewise.
 114         (cplus_language_defn): Likewise.
 115         (asm_language_defn): Likewise.
 116         (minimal_language_defn): Likewise.
 117         * d-lang.c (d_language_defn): Likewise.
 118         * f-lang.c (f_language_defn): Likewise.
 119         * go-lang.c (go_language_defn): Likewise.
 120         * language.c (unknown_language_defn): Likewise.
 121         (auto_language_defn): Likewise.
 122         * m2-lang.c (m2_language_defn): Likewise.
 123         * objc-lang.c (objc_language_defn): Likewise.
 124         * opencl-lang.c (opencl_language_defn): Likewise.
 125         * p-lang.c (pascal_language_defn): Likewise.
 126         * rust-lang.c (rust_language_defn): Likewise.
 127
 128 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 129
 130         * ada-lang.c (ada_is_character_type): Change return type to bool.
 131         (ada_is_string_type): Likewise.
 132         * ada-lang.h (ada_is_character_type): Update declaration
 133         (ada_is_string_type): Likewise.
 134
 135 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 136
 137         Support style in 'frame|thread apply'
 138
 139         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 140         * record.c (record_start, record_stop): Update callers of
 141         execute_command_to_string with false.
 142         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 143         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 144         methods.
 145         (class string_file): New constructor with term_out parameter.
 146         Override methods term_out and can_emit_style_escape.  New member
 147         term_out.
 148         (class stdio_file): Override can_emit_style_escape.
 149         (class tee_file): Override term_out and can_emit_style_escape.
 150         * utils.h (can_emit_style_escape): Remove.
 151         * utils.c (can_emit_style_escape): Likewise.
 152         Update all callers of can_emit_style_escape (SOMESTREAM) to
 153         SOMESTREAM->can_emit_style_escape.
 154         * source-cache.c (source_cache::get_source_lines): Likewise.
 155         * stack.c (frame_apply_command_count): Call execute_command_to_string
 156         passing the term_out characteristic of the current gdb_stdout.
 157         * thread.c (thr_try_catch_cmd): Likewise.
 158         * top.c (execute_command_to_string): pass term_out parameter
 159         to construct the string_file for the command output.
 160         * ui-file.c (term_cli_styling): New function (most code moved
 161         from utils.c can_emit_style_escape).
 162         (string_file::string_file, string_file::can_emit_style_escape,
 163         stdio_file::can_emit_style_escape, tee_file::term_out,
 164         tee_file::can_emit_style_escape): New functions.
 165
 166 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 167
 168         * NEWS: Mention the new set|show may-call-functions.
 169         * infcall.c (may_call_functions_p): New variable.
 170         (show_may_call_functions_p): New function.
 171         (call_function_by_hand_dummy): Throws an error if not
 172         may-call-functions.
 173         (_initialize_infcall): Call add_setshow_boolean_cmd for
 174         may-call-functions.
 175
 176 2019-04-25  Keith Seitz  <keiths@redhat.com>
 177
 178         PR c++/24367
 179         * cp-support.c (inspect_type): Don't attempt substitutions
 180         of symbol with the same name.
 181
 182 2019-04-25  Tom Tromey  <tromey@adacore.com>
 183
 184         PR gdb/24475:
 185         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 186         static.
 187
 188 2019-04-25  Tom Tromey  <tromey@adacore.com>
 189
 190         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 191         rvalue reference.
 192         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 193         (gdb_xml_parser::parse): Use std::move.
 194         * python/python-internal.h (gdbpy_convert_exception): Take a const
 195         reference.
 196         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 197         std::move.
 198         * python/py-utils.c (gdbpy_convert_exception): Take a const
 199         reference.
 200         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 201         Use std::move.
 202         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 203         Use std::move.
 204         * mi/mi-main.c (mi_print_exception): Take a const reference.
 205         * main.c (handle_command_errors): Take a const reference.
 206         * linespec.c (parse_linespec): Use std::move.
 207         * infcall.c (run_inferior_call): Use std::move.
 208         (call_function_by_hand_dummy): Use std::move.
 209         * exec.c (try_open_exec_file): Use std::move.
 210         * exceptions.h (exception_print, exception_fprintf)
 211         (exception_print_same): Update.
 212         * exceptions.c (print_exception, exception_print)
 213         (exception_fprintf, exception_print_same): Change parameters to
 214         const reference.
 215         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 216         * common/new-op.c: Use std::move.
 217         * common/common-exceptions.h (struct gdb_exception): Add move
 218         constructor.
 219         (struct gdb_exception_error, struct gdb_exception_quit, struct
 220         gdb_quit_bad_alloc): Change constructor to move constructor.
 221         (throw_exception): Change parameter to rvalue reference.
 222         * common/common-exceptions.c (throw_exception): Take rvalue
 223         reference.
 224         * cli/cli-interp.c (safe_execute_command): Use std::move.
 225         * breakpoint.c (insert_bp_location, location_to_sals): Use
 226         std::move.
 227
 228 2019-04-25  Tom Tromey  <tromey@adacore.com>
 229
 230         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 231         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 232         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 233         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 234         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 235         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 236         guile/scm-value.c: Use unpack.
 237         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 238         gdbscm_gdb_exception.
 239         (gdbscm_throw_gdb_exception): Likewise.
 240         (struct gdbscm_gdb_exception): New.
 241         (unpack): New function.
 242         (gdbscm_wrap): Use unpack.
 243
 244 2019-04-25  Tom Tromey  <tromey@adacore.com>
 245
 246         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 247         (gdb_rl_callback_handler): Use std::move.
 248         * common/common-exceptions.h (struct gdb_exception): Add move
 249         assignment operator.
 250         (throw_exception_sjlj): Change "exception" to const reference.
 251         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 252         (throw_exception_sjlj): Change "exception" to const reference.
 253
 254 2019-04-25  Tom Tromey  <tromey@adacore.com>
 255
 256         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 257         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 258         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 259         Update.
 260         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 261         Update.
 262         * mi/mi-interp.c (mi_interp::exec): Update.
 263         * linespec.c (parse_linespec): Update.
 264         * infcall.c (run_inferior_call): Update.
 265         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 266         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 267         (gdbscm_lookup_global_symbol): Update.
 268         * guile/scm-param.c (gdbscm_parameter_value): Update.
 269         * guile/scm-frame.c (gdbscm_frame_read_register)
 270         (gdbscm_frame_read_var): Update.
 271         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 272         * exec.c (try_open_exec_file): Update.
 273         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 274         (gdb_rl_callback_handler): Update.
 275         * common/common-exceptions.h (exception_none): Don't declare.
 276         * common/common-exceptions.c (exception_none): Don't define.
 277         (struct catcher) <exception>: Update.
 278         * cli/cli-interp.c (safe_execute_command): Update.
 279         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 280
 281 2019-04-25  Ali Tamur  <tamur@google.com>
 282
 283         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 284         (read_attribute_value): Likewise.
 285         (dwarf2_read_addr_index): Update comment.
 286         (read_str_index): Add DW_FORM_strx.
 287         (dwarf2_string_attr): Likewise.
 288         (dwarf2_const_value_attr): Likewise.
 289         (dump_die_shallow): Likewise.
 290         (dwarf2_fetch_constant_bytes): Likewise.
 291         (skip_form_bytes): Likewise.
 292         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 293
 294 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 295
 296         PR corefiles/11608
 297         PR corefiles/18187
 298         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 299         OFFSET.  Verify if current mapping contains an ELF header.
 300         (linux_find_memory_regions_full): Adjust call to
 301         dump_mapping_p.
 302
 303 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 304             Kang Li <kanglictf@gmail.com>
 305
 306         PR gdb/21600
 307
 308         * dwarf2-frame.c (read_initial_length): Be consistent about using
 309         unsigned representation of length.
 310         (decode_frame_entry_1): Likewise.  Check for wraparound of
 311         end pointer as well as buffer overflow.
 312
 313 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 314
 315         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 316         "vq".
 317
 318 2019-04-24  Tom Tromey  <tromey@adacore.com>
 319
 320         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 321
 322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 323
 324         * s12z-tdep.c (s12z_unwind_pc): Delete.
 325         (s12z_unwind_sp): Delete.
 326         (s12z_gdbarch_init): Don't register deleted functions with
 327         gdbarch.
 328
 329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 330
 331         * rl78-tdep.c (rl78_unwind_sp): Delete.
 332         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 333
 334 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 335
 336         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 337         (xstormy16_unwind_pc): Delete.
 338         (xstormy16_dummy_id): Delete.
 339         (xstormy16_gdbarch_init): Don't register deleted functions with
 340         gdbarch.
 341
 342 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 343
 344         * vax-tdep.c (vax_unwind_pc): Delete.
 345         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 346
 347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 348
 349         * v850-tdep.c (v850_unwind_sp): Delete.
 350         (v850_unwind_pc): Delete.
 351         (v850_dummy_id): Delete.
 352         (v850_gdbarch_init): Don't register deleted functions with
 353         gdbarch.
 354
 355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 356
 357         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 358         (tilegx_unwind_pc): Delete.
 359         (tilegx_unwind_dummy_id): Delete.
 360         (tilegx_gdbarch_init): Don't register deleted functions with
 361         gdbarch.
 362
 363 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 364
 365         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 366         (tic6x_dummy_id): Delete.
 367         (tic6x_gdbarch_init): Don't register deleted functions with
 368         gdbarch.
 369
 370 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 371
 372         * sparc-tdep.c (sparc_unwind_pc): Delete.
 373         (sparc32_gdbarch_init): Don't register deleted function with
 374         gdbarch.
 375
 376 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 377
 378         * sh-tdep.c (sh_unwind_sp): Delete.
 379         (sh_unwind_pc): Delete.
 380         (sh_dummy_id): Delete.
 381         (sh_gdbarch_init): Don't register deleted functions with
 382         gdbarch.
 383
 384 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 385
 386         * score-tdep.c (score_unwind_sp): Delete.
 387         (score_unwind_pc): Delete.
 388         (score_dummy_id): Delete.
 389         (score_gdbarch_init): Don't register deleted functions with
 390         gdbarch.
 391
 392 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 393
 394         * rx-tdep.c (rx_unwind_pc): Delete.
 395         (rx_unwind_sp): Delete.
 396         (rx_dummy_id): Delete.
 397         (rx_gdbarch_init): Don't register deleted functions with
 398         gdbarch.  Update comment.
 399
 400 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 401
 402         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 403         (rs6000_dummy_id): Delete.
 404         (rs6000_gdbarch_init): Don't register deleted functions with
 405         gdbarch.
 406
 407 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 408
 409         * or1k-tdep.c (or1k_dummy_id): Delete.
 410         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 411
 412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 413
 414         * nios2-tdep.c (nios2_dummy_id): Delete.
 415         (nios2_unwind_sp): Delete.
 416         (nios2_gdbarch_init): Don't register deleted functions with
 417         gdbarch.
 418
 419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 420
 421         * nds32-tdep.c (nds32_dummy_id): Delete.
 422         (nds32_unwind_pc): Delete.
 423         (nds32_unwind_sp): Delete.
 424         (nds32_gdbarch_init): Don't register deleted functions with
 425         gdbarch.
 426
 427 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 428
 429         * msp430-tdep.c (msp430_unwind_pc): Delete.
 430         (msp430_unwind_sp): Delete.
 431         (msp430_dummy_id): Delete.
 432         (msp430_gdbarch_init): Don't register deleted functions with
 433         gdbarch.
 434
 435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 436
 437         * moxie-tdep.c (moxie_unwind_sp): Delete.
 438         (moxie_unwind_pc): Delete.
 439         (moxie_dummy_id): Delete.
 440         (moxie_gdbarch_init): Don't register deleted functions with
 441         gdbarch.
 442
 443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 444
 445         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 446         (mn10300_unwind_pc): Delete.
 447         (mn10300_unwind_sp): Delete.
 448         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 449         mn10300_unwind_sp.
 450         (mn10300_frame_unwind_init): Don't register deleted functions with
 451         gdbarch.
 452
 453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 454
 455         * mep-tdep.c (mep_unwind_pc): Delete.
 456         (mep_unwind_sp): Delete.
 457         (mep_dummy_id): Delete.
 458         (mep_gdbarch_init): Don't register deleted functions with
 459         gdbarch.
 460
 461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 462
 463         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 464         (m68hc11_unwind_sp): Delete.
 465         (m68hc11_gdbarch_init): Don't register deleted functions with
 466         gdbarch.
 467
 468 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 469
 470         * m32r-tdep.c (m32r_unwind_sp): Delete.
 471         (m32r_unwind_pc): Delete.
 472         (m32r_dummy_id): Delete.
 473         (m32r_gdbarch_init): Don't register deleted functions with
 474         gdbarch.
 475
 476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 477
 478         * m32c-tdep.c (m32c_unwind_pc): Delete.
 479         (m32c_unwind_sp): Delete.
 480         (m32c_dummy_id): Delete.
 481         (m32c_gdbarch_init): Don't register deleted functions with
 482         gdbarch.
 483
 484 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 485
 486         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 487         (lm32_unwind_pc): Delete.
 488         (lm32_dummy_id): Delete.
 489         (lm32_gdbarch_init): Don't register deleted functions with
 490         gdbarch.
 491
 492 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 493
 494         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 495         (iq2000_unwind_pc): Delete.
 496         (iq2000_dummy_id): Delete.
 497         (iq2000_gdbarch_init): Don't register deleted functions with
 498         gdbarch.
 499
 500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 501
 502         * nds32-tdep.c (nds32_type_align): Delete.
 503         (nds32_push_dummy_call): Use type_align instead.
 504
 505 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 506
 507         * arm-tdep.c (arm_type_align): Only handle vector override case.
 508         (arm_push_dummy_call): Use type_align.
 509         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 510
 511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 512
 513         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 514         case.
 515         (pass_on_stack): Use type_align.
 516         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 517         function.
 518
 519 2019-04-23  Tom Tromey  <tromey@adacore.com>
 520
 521         * dwarf2read.c (line_header::file_name_at): Remove unused
 522         overload.
 523
 524 2019-04-23  Tom de Vries  <tdevries@suse.de>
 525
 526         PR gdb/24438
 527         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 528         invocation.
 529
 530
 531 2019-03-27  Ali Tamur  <tamur@google.com>
 532
 533         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 534         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 535         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 536         (dwarf_expr_context::get_addr_index): Likewise
 537         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 538         (symbol_needs_eval_context::get_addr_index): Likewise
 539         (disassemble_dwarf_expression): Add DW_OP_addrx
 540         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 541         (read_cutu_die_from_dwo): Update comment
 542         (skip_one_die): Add DW_FORM_addrx
 543         (read_attribute_value): Likewise
 544         (var_decode_location): Add DW_OP_addrx
 545         (dwarf2_const_value_attr): Add DW_FORM_addrx
 546         (dump_die_shallow): Likewise
 547         (dwarf2_fetch_constant_bytes): Likewise
 548         (decode_locdesc): Add DW_OP_addrx
 549         (skip_form_bytes): Add DW_FORM_addrx
 550
 551 2019-04-22  Ali Tamur  <tamur@google.com>
 552
 553         * MAINTAINERS (Write After Approval): Add self.
 554
 555 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 556
 557         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 558         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 559         (open_symbol_file_object): Likewise.
 560         (svr4_default_sos): Add info parameter.
 561         (svr4_read_so_list): Likewise.
 562         (svr4_current_sos_direct): Adjust functions calls to pass down
 563         info.
 564         (svr4_current_sos_1): Add info parameter.
 565         (svr4_current_sos): Call get_svr4_info, pass info down to
 566         svr4_current_sos_1.
 567         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 568         get_svr4_info.
 569         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 570         get_svr4_info.
 571         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 572         to get_svr4_info.
 573         (probes_table_remove_objfile_probes): Likewise.
 574         (register_solib_event_probe): Add info parameter.
 575         (solist_update_incremental): Pass info parameter down to
 576         svr4_read_so_list.
 577         (disable_probes_interface): Add info parameter.
 578         (svr4_handle_solib_event): Pass current_program_space to
 579         get_svr4_info.  Adjust disable_probes_interface cleanup.
 580         (svr4_create_probe_breakpoints): Add info parameter, pass it
 581         down to register_solib_event_probe.
 582         (svr4_create_solib_event_breakpoints): Add info parameter,
 583         pass it down to svr4_create_probe_breakpoints.
 584         (enable_break): Pass info down to
 585         svr4_create_solib_event_breakpoints.
 586         (svr4_solib_create_inferior_hook): Pass current_program_space to
 587         get_svr4_info.
 588         (svr4_clear_solib): Likewise.
 589
 590 2019-04-22  Pedro Alves  <palves@redhat.com>
 591
 592         * solib-svr4.c (svr4_free_objfile_observer): New.
 593         (probe_and_action::objfile): New field.
 594         (probes_table_htab_remove_objfile_probes)
 595         (probes_table_remove_objfile_probes): New functions.
 596         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 597         in the new probe_and_action.  Don't store the probe in 'lookup'.
 598         (svr4_create_probe_breakpoints): Pass objfile to
 599         register_solib_event_probe.
 600         (_initialize_svr4_solib): Register a free_objfile observer.
 601
 602 2019-04-19  Tom Tromey  <tom@tromey.com>
 603
 604         * common/queue.h: Remove.
 605
 606 2019-04-19  Tom Tromey  <tom@tromey.com>
 607
 608         * event-loop.c: Don't include "common/queue.h".
 609
 610 2019-04-19  Tom Tromey  <tom@tromey.com>
 611
 612         * remote.c (remote_target): Use delete.
 613         * remote-notif.h: Include <list>, not "common/queue.h".
 614         (notif_client_p): Remove typedef.
 615         (remote_notif_state): Add constructor, destructor, initializer.
 616         <notif_queue>: Now a std::list.
 617         (remote_notif_state_xfree): Don't declare.
 618         * remote-notif.c (remote_notif_process, handle_notification)
 619         (remote_notif_state_allocate): Update.
 620         (~remote_notif_state): Rename from remote_notif_state_xfree.
 621
 622 2019-04-19  Tom Tromey  <tom@tromey.com>
 623
 624         * symfile.c (reread_symbols): Update.
 625         * objfiles.c (objfile_register_static_link)
 626         (objfile_lookup_static_link): Update
 627         (~objfile) Don't delete static_links.
 628         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 629
 630 2019-04-19  Tom Tromey  <tom@tromey.com>
 631
 632         * type-stack.h (struct type_stack) <insert>: Constify string.
 633         * type-stack.c (type_stack::insert): Constify string.
 634         * gdbtypes.h (lookup_template_type): Update.
 635         (address_space_name_to_int): Update.
 636         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 637         const.
 638         (lookup_template_type): Make name const.
 639         * c-exp.y: Update rules.
 640         (lex_one_token, classify_name, classify_inner_name)
 641         (c_print_token): Update.
 642         * p-exp.y: Update rules.
 643         (yylex): Update.
 644         * f-exp.y: Update rules.
 645         (yylex): Update.
 646         * d-exp.y: Update rules.
 647         (lex_one_token, classify_name, classify_inner_name): Update.
 648         * parse.c (write_dollar_variable, copy_name): Return std::string.
 649         * parser-defs.h (copy_name): Change return type.
 650         * m2-exp.y: Update rules.
 651         (yylex): Update.
 652         * go-exp.y (lex_one_token): Update.
 653         Update rules.
 654         (classify_unsafe_function, classify_packaged_name)
 655         (classify_name, yylex): Update.
 656
 657 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 658
 659         * configure.ac: add --enable-source-highlight switch.
 660         * configure: Regenerate.
 661         * top.c (print_gdb_version): plumb --enable-source-highlight
 662         status to "show configuration".
 663
 664 2019-04-19  Tom Tromey  <tromey@adacore.com>
 665
 666         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 667         Check ADA_TYPE_P.
 668         (empty_record, ada_template_to_fixed_record_type_1)
 669         (template_to_static_fixed_type)
 670         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 671         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 672         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 673         macros.
 674
 675 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 676
 677         PR symtab/24423:
 678         * source.c (print_source_lines_base): Advance "iter" when a
 679         control character is seen.
 680
 681 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 682
 683         * inferior.h (struct infcall_suspend_state_deleter):
 684         Catch exception in destructor to avoid crash.
 685
 686 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 687
 688         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 689         close to the add_com "shell".
 690
 691 2019-04-18  Tom Tromey  <tromey@adacore.com>
 692
 693         * process-stratum-target.h (class process_stratum_target)
 694         <stratum>: Add "final".
 695
 696 2019-04-17  Tom Tromey  <tromey@adacore.com>
 697
 698         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 699         against nullptr before use.
 700
 701 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 702
 703         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 704
 705 2019-04-17  Jim Wilson  <jimw@sifive.com>
 706             Andrew Burgess  <andrew.burgess@embecosm.com>
 707
 708         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 709         code read might fail, assume 4-byte breakpoint in that case.
 710
 711 2019-04-15  Leszek Swirski  <leszeks@google.com>
 712
 713         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 714         rather than a hand-rolled POD check when checking for forced MEMORY
 715         classification.
 716
 717 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 718
 719         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 720         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 721         function.
 722         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 723         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 724         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 725         declaration.
 726
 727 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 728
 729         * aarch64-linux-nat.c
 730         (aarch64_linux_nat_target::thread_architecture): Add override.
 731         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 732         each VQ.
 733
 734 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 735
 736         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 737
 738 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 739
 740         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 741         target types of size 96-bits, add some additional comments, and
 742         check that the builtin type we found was the correct size.
 743
 744 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 745
 746         * utils.c (prompt_for_continue): Don't restore the styling at the
 747         end, as applied_style has the wrong value.  This fixes styling in
 748         long lists of file names that are interrupted by the "Continue?"
 749         prompt.
 750
 751 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 752
 753         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 754         * c-lang.c (c_language_defn): Likewise.
 755         (cplus_language_defn): Likewise.
 756         (asm_language_defn): Likewise.
 757         (minimal_language_defn): Likewise.
 758         * d-lang.c (d_language_defn): Likewise.
 759         * f-lang.c (f_language_defn): Likewise.
 760         * go-lang.c (go_language_defn): Likewise.
 761         * language.c (unknown_language_defn): Likewise.
 762         (auto_language_defn): Likewise.
 763         * language.h (struct language_defn): Remove la_magic field.
 764         (LANG_MAGIC): Delete.
 765         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 766         * objc-lang.c (objc_language_defn): Likewise.
 767         * opencl-lang.c (opencl_language_defn): Likewise.
 768         * p-lang.c (pascal_language_defn): Likewise.
 769         * rust-lang.c (rust_language_defn): Likewise.
 770
 771 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 772
 773         * riscv-tdep.c (riscv_type_align): New function.
 774         (riscv_type_alignment): Delete.
 775         (riscv_arg_location): Use 'type_align'.
 776         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 777
 778 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * gdbtypes.c (type_align): A struct with no non-static fields also
 781         has alignment of 1.
 782
 783 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 784
 785         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 786         component to 0.
 787         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 788         member.
 789         (riscv_struct_info::analyse): New implementation using new
 790         analyse_inner member function.
 791         (riscv_struct_info::field_offset): New member function.
 792         (riscv_struct_info::m_offsets): New member variable.
 793         (riscv_struct_info::analyse_inner): New private member function,
 794         takes the old implementation of riscv_struct_info::analyse but
 795         extended to track field offsets.
 796         (riscv_call_arg_struct): Update the struct folding special cases
 797         to handle cases where empty C++ structs, which are non-zero
 798         length, are found.
 799         (riscv_arg_location): Initialise the length of each location, a
 800         non-zero length now indicates the location is in use.
 801         (riscv_push_dummy_call): Allow for the first location having a
 802         non-zero offset when setting up arguments.
 803         (riscv_return_value): Likewise, but for return values.
 804
 805 2019-04-11  Tom Tromey  <tromey@adacore.com>
 806
 807         * utils.c (internal_vproblem): Make "msg" const.
 808
 809 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 810
 811         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 812         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 813         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 814         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 815
 816 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 817
 818         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 819         function.
 820         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 821         of amd64_collect_native_gregset.
 822         (amd64_linux_nat_target::store_registers): Likewise.
 823
 824 2019-04-10  Tom Tromey  <tom@tromey.com>
 825
 826         * symtab.c (lookup_global_symbol_from_objfile)
 827         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 828         * objfiles.h (class separate_debug_iterator): New.
 829         (class separate_debug_range): New.
 830         (struct objfile) <separate_debug_objfiles>: New method.
 831         (objfile_separate_debug_iterate): Don't declare.
 832         * objfiles.c (separate_debug_iterator::operator++): Rename from
 833         objfile_separate_debug_iterate.
 834         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 835         iterator.
 836         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 837         iterator.
 838
 839 2019-04-10  Tom Tromey  <tom@tromey.com>
 840
 841         * symfile.c (reread_symbols): Remove old comment.
 842         * objfiles.c (free_all_objfiles): Fix a typo.
 843
 844 2019-04-10  Tom Tromey  <tom@tromey.com>
 845
 846         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 847         * minsyms.c (lookup_minimal_symbol): Use foreach.
 848         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 849         (lookup_minimal_symbol_solib_trampoline): Likewise.
 850         * symfile.c (reread_symbols): Use foreach.
 851
 852 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 853             Tom Tromey  <tromey@adacore.com>
 854
 855         PR rust/24414:
 856         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 857         (rust_lex_int_test): Change "value" to be LONGEST.
 858         (rust_lex_tests): Add test for long integer literal.
 859
 860 2019-04-09  Tom Tromey  <tromey@adacore.com>
 861
 862         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 863         to bool.
 864         (extended_remote_target::attach): Update.
 865         (remote_target::remote_notice_new_inferior): Update.
 866         (remote_target::add_current_inferior_and_thread): Update.
 867         * inferior.c (exit_inferior_1): Use "false".
 868         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 869
 870 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 871
 872         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 873         the "start" command.
 874
 875 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 876
 877         * python/py-inferior.c (infpy_thread_from_thread_handle):
 878         Adjust comments to reflect renaming of thread_from_thread_handle
 879         to thread_from_handle.  Adjust keywords.  Fix type error message.
 880         (inferior_object_methods): Add thread_from_handle.  Retain
 881         thread_from_thread_handle, but mark it as deprecated.
 882
 883 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 884
 885         * gdbthread.h (find_thread_by_handle): Revise declaration.
 886         * thread.c (find_thread_by_handle): Likewise.  Adjust
 887         implementation too.
 888         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 889         support for buffer objects as handles.
 890
 891 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 892
 893         * python/py-infthread.c (thpy_thread_handle): New function.
 894         (thread_object_methods): Register thpy_thread_handle.
 895
 896 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 897
 898         * gdbthread.h (thread_to_thread_handle): Declare.
 899         * thread.c (gdbtypes.h): Include.
 900         (thread_to_thread_handle): New function.
 901
 902         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 903         (target_thread_info_to_thread_handle): Declare.
 904         * target.c (target_thread_info_to_thread_handle): New function.
 905         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 906         * target-delegates.c: Regenerate.
 907
 908         * linux-thread-db.c (class thread_db_target): Add method
 909         thread_info_to_thread_handle.
 910         (thread_db_target::thread_info_to_thread_handle): Define.
 911         * remote.c (class remote_target): Add new method
 912         thread_info_to_thread_handle.
 913         (remote_target::thread_info_to_thread_handle): Define.
 914
 915 2019-04-08  Pedro Alves  <palves@redhat.com>
 916
 917         * common/common-exceptions.c (throw_exception): Don't create
 918         named object to throw; throw directly.
 919         (throw_it): Likewise.  Don't initialize gdb_exception::message
 920         here, with new; pass FMT and AP to the ctor instead.
 921         * common/common-exceptions.h: Include <string>.
 922         (gdb_exception::gdb_exception(enum return_reason, enum errors,
 923         const char *, va_list)): New ctor.  Use std::make_shared.
 924         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
 925         errors)): Delete.
 926         (gdb_exception_error::gdb_exception_error(enum errors, const char
 927         *, va_list)): New.
 928         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
 929         Add assertion.
 930         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
 931         errors)): Delete.
 932         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
 933         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
 934         Add assertion.
 935
 936 2019-04-08  Tom Tromey  <tom@tromey.com>
 937
 938         * valops.c (value_rtti_indirect_type): Replace throw_exception
 939         with throw.
 940         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
 941         with throw.
 942         * thread.c (thr_try_catch_cmd): Replace throw_exception with
 943         throw.
 944         * target.c (target_translate_tls_address): Replace throw_exception
 945         with throw.
 946         * stack.c (frame_apply_command_count): Replace throw_exception
 947         with throw.
 948         * solib-spu.c (append_ocl_sos): Replace throw_exception with
 949         throw.
 950         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
 951         with throw.
 952         * rs6000-tdep.c (rs6000_frame_cache)
 953         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
 954         * remote.c: Replace throw_exception with throw.
 955         * record-full.c (record_full_message, record_full_wait_1)
 956         (record_full_restore): Replace throw_exception with throw.
 957         * record-btrace.c:
 958         (get_thread_current_frame_id, record_btrace_start_replaying)
 959         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
 960         (cmd_record_btrace_start): Replace throw_exception with throw.
 961         * parse.c (parse_exp_in_context_1): Replace throw_exception with
 962         throw.
 963         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
 964         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
 965         * linespec.c:
 966         (find_linespec_symbols): Replace throw_exception with throw.
 967         * infrun.c (displaced_step_prepare, resume): Replace
 968         throw_exception with throw.
 969         * infcmd.c (post_create_inferior): Replace throw_exception with
 970         throw.
 971         * inf-loop.c (inferior_event_handler): Replace throw_exception
 972         with throw.
 973         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
 974         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
 975         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
 976         (get_prev_frame_always, get_frame_pc_if_available)
 977         (get_frame_address_in_block_if_available, get_frame_language):
 978         Replace throw_exception with throw.
 979         * frame-unwind.c (frame_unwind_try_unwinder): Replace
 980         throw_exception with throw.
 981         * eval.c (fetch_subexp_value, evaluate_var_value)
 982         (evaluate_funcall, evaluate_subexp_standard): Replace
 983         throw_exception with throw.
 984         * dwarf2loc.c (call_site_find_chain)
 985         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
 986         Replace throw_exception with throw.
 987         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
 988         with throw.
 989         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
 990         throw.
 991         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
 992         * completer.c (complete_line_internal): Replace throw_exception
 993         with throw.
 994         * compile/compile-object-run.c (compile_object_run): Replace
 995         throw_exception with throw.
 996         * cli/cli-script.c (process_next_line): Replace throw_exception
 997         with throw.
 998         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
 999         (btrace_enable, btrace_maint_update_pt_packets): Replace
1000         throw_exception with throw.
1001         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1002         throw_exception with throw.
1003         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1004         throw_exception with throw.
1005         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1006         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1007         * aarch64-tdep.c (aarch64_make_prologue_cache)
1008         (aarch64_make_stub_cache): Replace throw_exception with throw.
1009
1010 2019-04-08  Tom Tromey  <tom@tromey.com>
1011
1012         * common/common-exceptions.c (throw_exception): Rename from
1013         throw_exception_cxx.  Remove old copy.  Make argument const.
1014         (throw_it): Create and throw exception objects directly.
1015         * common/common-exceptions.h (throw_exception): Make argument
1016         const.
1017         (struct gdb_exception_error): Add constructor.
1018         (struct gdb_exception_quit): Add constructor.
1019
1020 2019-04-08  Tom Tromey  <tom@tromey.com>
1021
1022         * common/common-exceptions.h (exception_rethrow): Don't declare.
1023         (TRY_SJLJ): Update comment.
1024         (TRY, CATCH, END_CATCH): Remove.
1025         * common/common-exceptions.c (exception_rethrow): Remove.
1026
1027 2019-04-08  Tom Tromey  <tom@tromey.com>
1028
1029         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1030         Remove.
1031         (gdb_exception_error): Rename from
1032         gdb_exception_RETURN_MASK_ERROR.
1033         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1034         (gdb_quit_bad_alloc): Update.
1035         * aarch64-tdep.c: Update.
1036         * ada-lang.c: Update.
1037         * ada-typeprint.c: Update.
1038         * ada-valprint.c: Update.
1039         * amd64-tdep.c: Update.
1040         * arch-utils.c: Update.
1041         * break-catch-throw.c: Update.
1042         * breakpoint.c: Update.
1043         * btrace.c: Update.
1044         * c-varobj.c: Update.
1045         * cli/cli-cmds.c: Update.
1046         * cli/cli-interp.c: Update.
1047         * cli/cli-script.c: Update.
1048         * common/common-exceptions.c: Update.
1049         * common/new-op.c: Update.
1050         * common/selftest.c: Update.
1051         * compile/compile-c-symbols.c: Update.
1052         * compile/compile-cplus-symbols.c: Update.
1053         * compile/compile-object-load.c: Update.
1054         * compile/compile-object-run.c: Update.
1055         * completer.c: Update.
1056         * corelow.c: Update.
1057         * cp-abi.c: Update.
1058         * cp-support.c: Update.
1059         * cp-valprint.c: Update.
1060         * darwin-nat.c: Update.
1061         * disasm-selftests.c: Update.
1062         * dtrace-probe.c: Update.
1063         * dwarf-index-cache.c: Update.
1064         * dwarf-index-write.c: Update.
1065         * dwarf2-frame-tailcall.c: Update.
1066         * dwarf2-frame.c: Update.
1067         * dwarf2loc.c: Update.
1068         * dwarf2read.c: Update.
1069         * eval.c: Update.
1070         * event-loop.c: Update.
1071         * event-top.c: Update.
1072         * exec.c: Update.
1073         * f-valprint.c: Update.
1074         * fbsd-tdep.c: Update.
1075         * frame-unwind.c: Update.
1076         * frame.c: Update.
1077         * gdbtypes.c: Update.
1078         * gnu-v3-abi.c: Update.
1079         * guile/guile-internal.h: Update.
1080         * guile/scm-block.c: Update.
1081         * guile/scm-breakpoint.c: Update.
1082         * guile/scm-cmd.c: Update.
1083         * guile/scm-disasm.c: Update.
1084         * guile/scm-frame.c: Update.
1085         * guile/scm-lazy-string.c: Update.
1086         * guile/scm-math.c: Update.
1087         * guile/scm-param.c: Update.
1088         * guile/scm-ports.c: Update.
1089         * guile/scm-pretty-print.c: Update.
1090         * guile/scm-symbol.c: Update.
1091         * guile/scm-symtab.c: Update.
1092         * guile/scm-type.c: Update.
1093         * guile/scm-value.c: Update.
1094         * i386-linux-tdep.c: Update.
1095         * i386-tdep.c: Update.
1096         * inf-loop.c: Update.
1097         * infcall.c: Update.
1098         * infcmd.c: Update.
1099         * infrun.c: Update.
1100         * jit.c: Update.
1101         * language.c: Update.
1102         * linespec.c: Update.
1103         * linux-fork.c: Update.
1104         * linux-nat.c: Update.
1105         * linux-tdep.c: Update.
1106         * linux-thread-db.c: Update.
1107         * main.c: Update.
1108         * mi/mi-cmd-break.c: Update.
1109         * mi/mi-cmd-stack.c: Update.
1110         * mi/mi-interp.c: Update.
1111         * mi/mi-main.c: Update.
1112         * objc-lang.c: Update.
1113         * p-valprint.c: Update.
1114         * parse.c: Update.
1115         * ppc-linux-tdep.c: Update.
1116         * printcmd.c: Update.
1117         * python/py-arch.c: Update.
1118         * python/py-breakpoint.c: Update.
1119         * python/py-cmd.c: Update.
1120         * python/py-finishbreakpoint.c: Update.
1121         * python/py-frame.c: Update.
1122         * python/py-framefilter.c: Update.
1123         * python/py-gdb-readline.c: Update.
1124         * python/py-inferior.c: Update.
1125         * python/py-infthread.c: Update.
1126         * python/py-lazy-string.c: Update.
1127         * python/py-linetable.c: Update.
1128         * python/py-objfile.c: Update.
1129         * python/py-param.c: Update.
1130         * python/py-prettyprint.c: Update.
1131         * python/py-progspace.c: Update.
1132         * python/py-record-btrace.c: Update.
1133         * python/py-record.c: Update.
1134         * python/py-symbol.c: Update.
1135         * python/py-type.c: Update.
1136         * python/py-unwind.c: Update.
1137         * python/py-utils.c: Update.
1138         * python/py-value.c: Update.
1139         * python/python.c: Update.
1140         * record-btrace.c: Update.
1141         * record-full.c: Update.
1142         * remote-fileio.c: Update.
1143         * remote.c: Update.
1144         * riscv-tdep.c: Update.
1145         * rs6000-aix-tdep.c: Update.
1146         * rs6000-tdep.c: Update.
1147         * rust-exp.y: Update.
1148         * rust-lang.c: Update.
1149         * s390-tdep.c: Update.
1150         * selftest-arch.c: Update.
1151         * solib-dsbt.c: Update.
1152         * solib-frv.c: Update.
1153         * solib-spu.c: Update.
1154         * solib-svr4.c: Update.
1155         * solib.c: Update.
1156         * sparc64-linux-tdep.c: Update.
1157         * stack.c: Update.
1158         * symfile-mem.c: Update.
1159         * symmisc.c: Update.
1160         * target.c: Update.
1161         * thread.c: Update.
1162         * top.c: Update.
1163         * tracefile-tfile.c: Update.
1164         * tui/tui.c: Update.
1165         * typeprint.c: Update.
1166         * unittests/cli-utils-selftests.c: Update.
1167         * unittests/parse-connection-spec-selftests.c: Update.
1168         * valops.c: Update.
1169         * valprint.c: Update.
1170         * value.c: Update.
1171         * varobj.c: Update.
1172         * windows-nat.c: Update.
1173         * x86-linux-nat.c: Update.
1174         * xml-support.c: Update.
1175
1176 2019-04-08  Tom Tromey  <tom@tromey.com>
1177
1178         * xml-support.c: Use C++ exception handling.
1179         * x86-linux-nat.c: Use C++ exception handling.
1180         * windows-nat.c: Use C++ exception handling.
1181         * varobj.c: Use C++ exception handling.
1182         * value.c: Use C++ exception handling.
1183         * valprint.c: Use C++ exception handling.
1184         * valops.c: Use C++ exception handling.
1185         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1186         handling.
1187         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1188         * typeprint.c: Use C++ exception handling.
1189         * tui/tui.c: Use C++ exception handling.
1190         * tracefile-tfile.c: Use C++ exception handling.
1191         * top.c: Use C++ exception handling.
1192         * thread.c: Use C++ exception handling.
1193         * target.c: Use C++ exception handling.
1194         * symmisc.c: Use C++ exception handling.
1195         * symfile-mem.c: Use C++ exception handling.
1196         * stack.c: Use C++ exception handling.
1197         * sparc64-linux-tdep.c: Use C++ exception handling.
1198         * solib.c: Use C++ exception handling.
1199         * solib-svr4.c: Use C++ exception handling.
1200         * solib-spu.c: Use C++ exception handling.
1201         * solib-frv.c: Use C++ exception handling.
1202         * solib-dsbt.c: Use C++ exception handling.
1203         * selftest-arch.c: Use C++ exception handling.
1204         * s390-tdep.c: Use C++ exception handling.
1205         * rust-lang.c: Use C++ exception handling.
1206         * rust-exp.y: Use C++ exception handling.
1207         * rs6000-tdep.c: Use C++ exception handling.
1208         * rs6000-aix-tdep.c: Use C++ exception handling.
1209         * riscv-tdep.c: Use C++ exception handling.
1210         * remote.c: Use C++ exception handling.
1211         * remote-fileio.c: Use C++ exception handling.
1212         * record-full.c: Use C++ exception handling.
1213         * record-btrace.c: Use C++ exception handling.
1214         * python/python.c: Use C++ exception handling.
1215         * python/py-value.c: Use C++ exception handling.
1216         * python/py-utils.c: Use C++ exception handling.
1217         * python/py-unwind.c: Use C++ exception handling.
1218         * python/py-type.c: Use C++ exception handling.
1219         * python/py-symbol.c: Use C++ exception handling.
1220         * python/py-record.c: Use C++ exception handling.
1221         * python/py-record-btrace.c: Use C++ exception handling.
1222         * python/py-progspace.c: Use C++ exception handling.
1223         * python/py-prettyprint.c: Use C++ exception handling.
1224         * python/py-param.c: Use C++ exception handling.
1225         * python/py-objfile.c: Use C++ exception handling.
1226         * python/py-linetable.c: Use C++ exception handling.
1227         * python/py-lazy-string.c: Use C++ exception handling.
1228         * python/py-infthread.c: Use C++ exception handling.
1229         * python/py-inferior.c: Use C++ exception handling.
1230         * python/py-gdb-readline.c: Use C++ exception handling.
1231         * python/py-framefilter.c: Use C++ exception handling.
1232         * python/py-frame.c: Use C++ exception handling.
1233         * python/py-finishbreakpoint.c: Use C++ exception handling.
1234         * python/py-cmd.c: Use C++ exception handling.
1235         * python/py-breakpoint.c: Use C++ exception handling.
1236         * python/py-arch.c: Use C++ exception handling.
1237         * printcmd.c: Use C++ exception handling.
1238         * ppc-linux-tdep.c: Use C++ exception handling.
1239         * parse.c: Use C++ exception handling.
1240         * p-valprint.c: Use C++ exception handling.
1241         * objc-lang.c: Use C++ exception handling.
1242         * mi/mi-main.c: Use C++ exception handling.
1243         * mi/mi-interp.c: Use C++ exception handling.
1244         * mi/mi-cmd-stack.c: Use C++ exception handling.
1245         * mi/mi-cmd-break.c: Use C++ exception handling.
1246         * main.c: Use C++ exception handling.
1247         * linux-thread-db.c: Use C++ exception handling.
1248         * linux-tdep.c: Use C++ exception handling.
1249         * linux-nat.c: Use C++ exception handling.
1250         * linux-fork.c: Use C++ exception handling.
1251         * linespec.c: Use C++ exception handling.
1252         * language.c: Use C++ exception handling.
1253         * jit.c: Use C++ exception handling.
1254         * infrun.c: Use C++ exception handling.
1255         * infcmd.c: Use C++ exception handling.
1256         * infcall.c: Use C++ exception handling.
1257         * inf-loop.c: Use C++ exception handling.
1258         * i386-tdep.c: Use C++ exception handling.
1259         * i386-linux-tdep.c: Use C++ exception handling.
1260         * guile/scm-value.c: Use C++ exception handling.
1261         * guile/scm-type.c: Use C++ exception handling.
1262         * guile/scm-symtab.c: Use C++ exception handling.
1263         * guile/scm-symbol.c: Use C++ exception handling.
1264         * guile/scm-pretty-print.c: Use C++ exception handling.
1265         * guile/scm-ports.c: Use C++ exception handling.
1266         * guile/scm-param.c: Use C++ exception handling.
1267         * guile/scm-math.c: Use C++ exception handling.
1268         * guile/scm-lazy-string.c: Use C++ exception handling.
1269         * guile/scm-frame.c: Use C++ exception handling.
1270         * guile/scm-disasm.c: Use C++ exception handling.
1271         * guile/scm-cmd.c: Use C++ exception handling.
1272         * guile/scm-breakpoint.c: Use C++ exception handling.
1273         * guile/scm-block.c: Use C++ exception handling.
1274         * guile/guile-internal.h: Use C++ exception handling.
1275         * gnu-v3-abi.c: Use C++ exception handling.
1276         * gdbtypes.c: Use C++ exception handling.
1277         * frame.c: Use C++ exception handling.
1278         * frame-unwind.c: Use C++ exception handling.
1279         * fbsd-tdep.c: Use C++ exception handling.
1280         * f-valprint.c: Use C++ exception handling.
1281         * exec.c: Use C++ exception handling.
1282         * event-top.c: Use C++ exception handling.
1283         * event-loop.c: Use C++ exception handling.
1284         * eval.c: Use C++ exception handling.
1285         * dwarf2read.c: Use C++ exception handling.
1286         * dwarf2loc.c: Use C++ exception handling.
1287         * dwarf2-frame.c: Use C++ exception handling.
1288         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1289         * dwarf-index-write.c: Use C++ exception handling.
1290         * dwarf-index-cache.c: Use C++ exception handling.
1291         * dtrace-probe.c: Use C++ exception handling.
1292         * disasm-selftests.c: Use C++ exception handling.
1293         * darwin-nat.c: Use C++ exception handling.
1294         * cp-valprint.c: Use C++ exception handling.
1295         * cp-support.c: Use C++ exception handling.
1296         * cp-abi.c: Use C++ exception handling.
1297         * corelow.c: Use C++ exception handling.
1298         * completer.c: Use C++ exception handling.
1299         * compile/compile-object-run.c: Use C++ exception handling.
1300         * compile/compile-object-load.c: Use C++ exception handling.
1301         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1302         * compile/compile-c-symbols.c: Use C++ exception handling.
1303         * common/selftest.c: Use C++ exception handling.
1304         * common/new-op.c: Use C++ exception handling.
1305         * cli/cli-script.c: Use C++ exception handling.
1306         * cli/cli-interp.c: Use C++ exception handling.
1307         * cli/cli-cmds.c: Use C++ exception handling.
1308         * c-varobj.c: Use C++ exception handling.
1309         * btrace.c: Use C++ exception handling.
1310         * breakpoint.c: Use C++ exception handling.
1311         * break-catch-throw.c: Use C++ exception handling.
1312         * arch-utils.c: Use C++ exception handling.
1313         * amd64-tdep.c: Use C++ exception handling.
1314         * ada-valprint.c: Use C++ exception handling.
1315         * ada-typeprint.c: Use C++ exception handling.
1316         * ada-lang.c: Use C++ exception handling.
1317         * aarch64-tdep.c: Use C++ exception handling.
1318
1319 2019-04-08  Tom Tromey  <tom@tromey.com>
1320
1321         * xml-support.c (gdb_xml_parser::parse): Update.
1322         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1323         * value.c (show_convenience): Update.
1324         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1325         (test_parse_flags_qcs): Update.
1326         * thread.c (thr_try_catch_cmd): Update.
1327         * target.c (target_translate_tls_address): Update.
1328         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1329         (info_frame_command_core, frame_apply_command_count): Update.
1330         * rust-exp.y (rust_lex_exception_test): Update.
1331         * riscv-tdep.c (riscv_print_one_register_info): Update.
1332         * remote.c (remote_target::enable_btrace): Update.
1333         * record-btrace.c (record_btrace_enable_warn): Update.
1334         * python/py-utils.c (gdbpy_convert_exception): Update.
1335         * printcmd.c (do_one_display, print_variable_and_value): Update.
1336         * mi/mi-main.c (mi_print_exception): Update.
1337         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1338         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1339         * linux-nat.c (linux_nat_target::attach): Update.
1340         * linux-fork.c (class scoped_switch_fork_info): Update.
1341         * infrun.c (displaced_step_prepare): Update.
1342         * infcall.c (call_function_by_hand_dummy): Update.
1343         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1344         * gnu-v3-abi.c (print_one_vtable): Update.
1345         * frame.c (get_prev_frame_always): Update.
1346         * f-valprint.c (info_common_command_for_block): Update.
1347         * exec.c (try_open_exec_file): Update.
1348         * exceptions.c (print_exception, exception_print)
1349         (exception_fprintf, exception_print_same): Update.
1350         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1351         * dwarf-index-cache.c (index_cache::store)
1352         (index_cache::lookup_gdb_index): Update.
1353         * darwin-nat.c (maybe_cache_shell): Update.
1354         * cp-valprint.c (cp_print_value_fields): Update.
1355         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1356         (gcc_cplus_symbol_address): Update.
1357         * compile/compile-c-symbols.c (gcc_convert_symbol)
1358         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1359         * common/selftest.c: Update.
1360         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1361         a std::string.
1362         (exception_try_scope_entry, exception_try_scope_exit): Don't
1363         declare.
1364         (struct exception_try_scope): Remove.
1365         (TRY): Don't use exception_try_scope.
1366         (struct gdb_exception): Add constructor, operator=.
1367         <what>: New method.
1368         (struct gdb_exception_RETURN_MASK_ALL)
1369         (struct gdb_exception_RETURN_MASK_ERROR)
1370         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1371         (struct gdb_quit_bad_alloc): Update.
1372         * common/common-exceptions.c (exception_none): Change
1373         initializer.
1374         (struct catcher) <state, exception>: Initialize inline.
1375         <prev>: Remove member.
1376         (current_catcher): Remove.
1377         (catchers): New global.
1378         (exceptions_state_mc_init): Simplify.
1379         (catcher_pop): Remove.
1380         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1381         (try_scope_depth, exception_try_scope_entry)
1382         (exception_try_scope_exit): Remove.
1383         (throw_exception_sjlj): Update.
1384         (exception_messages, exception_messages_size): Remove.
1385         (throw_it): Simplify.
1386         (gdb_exception_sliced_copy): Remove.
1387         (throw_exception_cxx): Update.
1388         * cli/cli-script.c (script_from_file): Update.
1389         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1390         Update.
1391         * ada-valprint.c (ada_val_print): Update.
1392         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1393         (create_excep_cond_exprs): Update.
1394
1395 2019-04-08  Tom Tromey  <tom@tromey.com>
1396
1397         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1398         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1399         (TRY, CATCH, END_CATCH): Remove some definitions.
1400         * common/common-exceptions.c: Don't use GDB_XCPT.
1401         (catcher_list_size): Remove.
1402         (throw_exception, throw_it): Simplify.
1403
1404 2019-04-05  Tom Tromey  <tom@tromey.com>
1405
1406         Revert the header-sorting patch.
1407         * ft32-tdep.c: Revert.
1408         * frv-tdep.c: Revert.
1409         * frv-linux-tdep.c: Revert.
1410         * frame.c: Revert.
1411         * frame-unwind.c: Revert.
1412         * frame-base.c: Revert.
1413         * fork-child.c: Revert.
1414         * findvar.c: Revert.
1415         * findcmd.c: Revert.
1416         * filesystem.c: Revert.
1417         * filename-seen-cache.h: Revert.
1418         * filename-seen-cache.c: Revert.
1419         * fbsd-tdep.c: Revert.
1420         * fbsd-nat.h: Revert.
1421         * fbsd-nat.c: Revert.
1422         * f-valprint.c: Revert.
1423         * f-typeprint.c: Revert.
1424         * f-lang.c: Revert.
1425         * extension.h: Revert.
1426         * extension.c: Revert.
1427         * extension-priv.h: Revert.
1428         * expprint.c: Revert.
1429         * exec.h: Revert.
1430         * exec.c: Revert.
1431         * exceptions.c: Revert.
1432         * event-top.c: Revert.
1433         * event-loop.c: Revert.
1434         * eval.c: Revert.
1435         * elfread.c: Revert.
1436         * dwarf2read.h: Revert.
1437         * dwarf2read.c: Revert.
1438         * dwarf2loc.c: Revert.
1439         * dwarf2expr.h: Revert.
1440         * dwarf2expr.c: Revert.
1441         * dwarf2-frame.c: Revert.
1442         * dwarf2-frame-tailcall.c: Revert.
1443         * dwarf-index-write.h: Revert.
1444         * dwarf-index-write.c: Revert.
1445         * dwarf-index-common.c: Revert.
1446         * dwarf-index-cache.h: Revert.
1447         * dwarf-index-cache.c: Revert.
1448         * dummy-frame.c: Revert.
1449         * dtrace-probe.c: Revert.
1450         * disasm.h: Revert.
1451         * disasm.c: Revert.
1452         * disasm-selftests.c: Revert.
1453         * dictionary.c: Revert.
1454         * dicos-tdep.c: Revert.
1455         * demangle.c: Revert.
1456         * dcache.h: Revert.
1457         * dcache.c: Revert.
1458         * darwin-nat.h: Revert.
1459         * darwin-nat.c: Revert.
1460         * darwin-nat-info.c: Revert.
1461         * d-valprint.c: Revert.
1462         * d-namespace.c: Revert.
1463         * d-lang.c: Revert.
1464         * ctf.c: Revert.
1465         * csky-tdep.c: Revert.
1466         * csky-linux-tdep.c: Revert.
1467         * cris-tdep.c: Revert.
1468         * cris-linux-tdep.c: Revert.
1469         * cp-valprint.c: Revert.
1470         * cp-support.c: Revert.
1471         * cp-namespace.c: Revert.
1472         * cp-abi.c: Revert.
1473         * corelow.c: Revert.
1474         * corefile.c: Revert.
1475         * continuations.c: Revert.
1476         * completer.h: Revert.
1477         * completer.c: Revert.
1478         * complaints.c: Revert.
1479         * coffread.c: Revert.
1480         * coff-pe-read.c: Revert.
1481         * cli-out.h: Revert.
1482         * cli-out.c: Revert.
1483         * charset.c: Revert.
1484         * c-varobj.c: Revert.
1485         * c-valprint.c: Revert.
1486         * c-typeprint.c: Revert.
1487         * c-lang.c: Revert.
1488         * buildsym.c: Revert.
1489         * buildsym-legacy.c: Revert.
1490         * build-id.h: Revert.
1491         * build-id.c: Revert.
1492         * btrace.c: Revert.
1493         * bsd-uthread.c: Revert.
1494         * breakpoint.h: Revert.
1495         * breakpoint.c: Revert.
1496         * break-catch-throw.c: Revert.
1497         * break-catch-syscall.c: Revert.
1498         * break-catch-sig.c: Revert.
1499         * blockframe.c: Revert.
1500         * block.c: Revert.
1501         * bfin-tdep.c: Revert.
1502         * bfin-linux-tdep.c: Revert.
1503         * bfd-target.c: Revert.
1504         * bcache.c: Revert.
1505         * ax-general.c: Revert.
1506         * ax-gdb.h: Revert.
1507         * ax-gdb.c: Revert.
1508         * avr-tdep.c: Revert.
1509         * auxv.c: Revert.
1510         * auto-load.c: Revert.
1511         * arm-wince-tdep.c: Revert.
1512         * arm-tdep.c: Revert.
1513         * arm-symbian-tdep.c: Revert.
1514         * arm-pikeos-tdep.c: Revert.
1515         * arm-obsd-tdep.c: Revert.
1516         * arm-nbsd-tdep.c: Revert.
1517         * arm-nbsd-nat.c: Revert.
1518         * arm-linux-tdep.c: Revert.
1519         * arm-linux-nat.c: Revert.
1520         * arm-fbsd-tdep.c: Revert.
1521         * arm-fbsd-nat.c: Revert.
1522         * arm-bsd-tdep.c: Revert.
1523         * arch-utils.c: Revert.
1524         * arc-tdep.c: Revert.
1525         * arc-newlib-tdep.c: Revert.
1526         * annotate.h: Revert.
1527         * annotate.c: Revert.
1528         * amd64-windows-tdep.c: Revert.
1529         * amd64-windows-nat.c: Revert.
1530         * amd64-tdep.c: Revert.
1531         * amd64-sol2-tdep.c: Revert.
1532         * amd64-obsd-tdep.c: Revert.
1533         * amd64-obsd-nat.c: Revert.
1534         * amd64-nbsd-tdep.c: Revert.
1535         * amd64-nbsd-nat.c: Revert.
1536         * amd64-nat.c: Revert.
1537         * amd64-linux-tdep.c: Revert.
1538         * amd64-linux-nat.c: Revert.
1539         * amd64-fbsd-tdep.c: Revert.
1540         * amd64-fbsd-nat.c: Revert.
1541         * amd64-dicos-tdep.c: Revert.
1542         * amd64-darwin-tdep.c: Revert.
1543         * amd64-bsd-nat.c: Revert.
1544         * alpha-tdep.c: Revert.
1545         * alpha-obsd-tdep.c: Revert.
1546         * alpha-nbsd-tdep.c: Revert.
1547         * alpha-mdebug-tdep.c: Revert.
1548         * alpha-linux-tdep.c: Revert.
1549         * alpha-linux-nat.c: Revert.
1550         * alpha-bsd-tdep.c: Revert.
1551         * alpha-bsd-nat.c: Revert.
1552         * aix-thread.c: Revert.
1553         * agent.c: Revert.
1554         * addrmap.c: Revert.
1555         * ada-varobj.c: Revert.
1556         * ada-valprint.c: Revert.
1557         * ada-typeprint.c: Revert.
1558         * ada-tasks.c: Revert.
1559         * ada-lang.c: Revert.
1560         * aarch64-tdep.c: Revert.
1561         * aarch64-ravenscar-thread.c: Revert.
1562         * aarch64-newlib-tdep.c: Revert.
1563         * aarch64-linux-tdep.c: Revert.
1564         * aarch64-linux-nat.c: Revert.
1565         * aarch64-fbsd-tdep.c: Revert.
1566         * aarch64-fbsd-nat.c: Revert.
1567         * aarch32-linux-nat.c: Revert.
1568
1569 2019-04-05  Tom Tromey  <tom@tromey.com>
1570
1571         * ft32-tdep.c: Sort headers.
1572         * frv-tdep.c: Sort headers.
1573         * frv-linux-tdep.c: Sort headers.
1574         * frame.c: Sort headers.
1575         * frame-unwind.c: Sort headers.
1576         * frame-base.c: Sort headers.
1577         * fork-child.c: Sort headers.
1578         * findvar.c: Sort headers.
1579         * findcmd.c: Sort headers.
1580         * filesystem.c: Sort headers.
1581         * filename-seen-cache.h: Sort headers.
1582         * filename-seen-cache.c: Sort headers.
1583         * fbsd-tdep.c: Sort headers.
1584         * fbsd-nat.h: Sort headers.
1585         * fbsd-nat.c: Sort headers.
1586         * f-valprint.c: Sort headers.
1587         * f-typeprint.c: Sort headers.
1588         * f-lang.c: Sort headers.
1589         * extension.h: Sort headers.
1590         * extension.c: Sort headers.
1591         * extension-priv.h: Sort headers.
1592         * expprint.c: Sort headers.
1593         * exec.h: Sort headers.
1594         * exec.c: Sort headers.
1595         * exceptions.c: Sort headers.
1596         * event-top.c: Sort headers.
1597         * event-loop.c: Sort headers.
1598         * eval.c: Sort headers.
1599         * elfread.c: Sort headers.
1600         * dwarf2read.h: Sort headers.
1601         * dwarf2read.c: Sort headers.
1602         * dwarf2loc.c: Sort headers.
1603         * dwarf2expr.h: Sort headers.
1604         * dwarf2expr.c: Sort headers.
1605         * dwarf2-frame.c: Sort headers.
1606         * dwarf2-frame-tailcall.c: Sort headers.
1607         * dwarf-index-write.h: Sort headers.
1608         * dwarf-index-write.c: Sort headers.
1609         * dwarf-index-common.c: Sort headers.
1610         * dwarf-index-cache.h: Sort headers.
1611         * dwarf-index-cache.c: Sort headers.
1612         * dummy-frame.c: Sort headers.
1613         * dtrace-probe.c: Sort headers.
1614         * disasm.h: Sort headers.
1615         * disasm.c: Sort headers.
1616         * disasm-selftests.c: Sort headers.
1617         * dictionary.c: Sort headers.
1618         * dicos-tdep.c: Sort headers.
1619         * demangle.c: Sort headers.
1620         * dcache.h: Sort headers.
1621         * dcache.c: Sort headers.
1622         * darwin-nat.h: Sort headers.
1623         * darwin-nat.c: Sort headers.
1624         * darwin-nat-info.c: Sort headers.
1625         * d-valprint.c: Sort headers.
1626         * d-namespace.c: Sort headers.
1627         * d-lang.c: Sort headers.
1628         * ctf.c: Sort headers.
1629         * csky-tdep.c: Sort headers.
1630         * csky-linux-tdep.c: Sort headers.
1631         * cris-tdep.c: Sort headers.
1632         * cris-linux-tdep.c: Sort headers.
1633         * cp-valprint.c: Sort headers.
1634         * cp-support.c: Sort headers.
1635         * cp-namespace.c: Sort headers.
1636         * cp-abi.c: Sort headers.
1637         * corelow.c: Sort headers.
1638         * corefile.c: Sort headers.
1639         * continuations.c: Sort headers.
1640         * completer.h: Sort headers.
1641         * completer.c: Sort headers.
1642         * complaints.c: Sort headers.
1643         * coffread.c: Sort headers.
1644         * coff-pe-read.c: Sort headers.
1645         * cli-out.h: Sort headers.
1646         * cli-out.c: Sort headers.
1647         * charset.c: Sort headers.
1648         * c-varobj.c: Sort headers.
1649         * c-valprint.c: Sort headers.
1650         * c-typeprint.c: Sort headers.
1651         * c-lang.c: Sort headers.
1652         * buildsym.c: Sort headers.
1653         * buildsym-legacy.c: Sort headers.
1654         * build-id.h: Sort headers.
1655         * build-id.c: Sort headers.
1656         * btrace.c: Sort headers.
1657         * bsd-uthread.c: Sort headers.
1658         * breakpoint.h: Sort headers.
1659         * breakpoint.c: Sort headers.
1660         * break-catch-throw.c: Sort headers.
1661         * break-catch-syscall.c: Sort headers.
1662         * break-catch-sig.c: Sort headers.
1663         * blockframe.c: Sort headers.
1664         * block.c: Sort headers.
1665         * bfin-tdep.c: Sort headers.
1666         * bfin-linux-tdep.c: Sort headers.
1667         * bfd-target.c: Sort headers.
1668         * bcache.c: Sort headers.
1669         * ax-general.c: Sort headers.
1670         * ax-gdb.h: Sort headers.
1671         * ax-gdb.c: Sort headers.
1672         * avr-tdep.c: Sort headers.
1673         * auxv.c: Sort headers.
1674         * auto-load.c: Sort headers.
1675         * arm-wince-tdep.c: Sort headers.
1676         * arm-tdep.c: Sort headers.
1677         * arm-symbian-tdep.c: Sort headers.
1678         * arm-pikeos-tdep.c: Sort headers.
1679         * arm-obsd-tdep.c: Sort headers.
1680         * arm-nbsd-tdep.c: Sort headers.
1681         * arm-nbsd-nat.c: Sort headers.
1682         * arm-linux-tdep.c: Sort headers.
1683         * arm-linux-nat.c: Sort headers.
1684         * arm-fbsd-tdep.c: Sort headers.
1685         * arm-fbsd-nat.c: Sort headers.
1686         * arm-bsd-tdep.c: Sort headers.
1687         * arch-utils.c: Sort headers.
1688         * arc-tdep.c: Sort headers.
1689         * arc-newlib-tdep.c: Sort headers.
1690         * annotate.h: Sort headers.
1691         * annotate.c: Sort headers.
1692         * amd64-windows-tdep.c: Sort headers.
1693         * amd64-windows-nat.c: Sort headers.
1694         * amd64-tdep.c: Sort headers.
1695         * amd64-sol2-tdep.c: Sort headers.
1696         * amd64-obsd-tdep.c: Sort headers.
1697         * amd64-obsd-nat.c: Sort headers.
1698         * amd64-nbsd-tdep.c: Sort headers.
1699         * amd64-nbsd-nat.c: Sort headers.
1700         * amd64-nat.c: Sort headers.
1701         * amd64-linux-tdep.c: Sort headers.
1702         * amd64-linux-nat.c: Sort headers.
1703         * amd64-fbsd-tdep.c: Sort headers.
1704         * amd64-fbsd-nat.c: Sort headers.
1705         * amd64-dicos-tdep.c: Sort headers.
1706         * amd64-darwin-tdep.c: Sort headers.
1707         * amd64-bsd-nat.c: Sort headers.
1708         * alpha-tdep.c: Sort headers.
1709         * alpha-obsd-tdep.c: Sort headers.
1710         * alpha-nbsd-tdep.c: Sort headers.
1711         * alpha-mdebug-tdep.c: Sort headers.
1712         * alpha-linux-tdep.c: Sort headers.
1713         * alpha-linux-nat.c: Sort headers.
1714         * alpha-bsd-tdep.c: Sort headers.
1715         * alpha-bsd-nat.c: Sort headers.
1716         * aix-thread.c: Sort headers.
1717         * agent.c: Sort headers.
1718         * addrmap.c: Sort headers.
1719         * ada-varobj.c: Sort headers.
1720         * ada-valprint.c: Sort headers.
1721         * ada-typeprint.c: Sort headers.
1722         * ada-tasks.c: Sort headers.
1723         * ada-lang.c: Sort headers.
1724         * aarch64-tdep.c: Sort headers.
1725         * aarch64-ravenscar-thread.c: Sort headers.
1726         * aarch64-newlib-tdep.c: Sort headers.
1727         * aarch64-linux-tdep.c: Sort headers.
1728         * aarch64-linux-nat.c: Sort headers.
1729         * aarch64-fbsd-tdep.c: Sort headers.
1730         * aarch64-fbsd-nat.c: Sort headers.
1731         * aarch32-linux-nat.c: Sort headers.
1732
1733 2019-04-04  Tom Tromey  <tom@tromey.com>
1734
1735         * varobj.c (varobj_create): Update.
1736         * rust-exp.y (struct rust_parser) <update_innermost_block,
1737         lookup_symbol>: New methods.
1738         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1739         Rename.
1740         (rust_parser::rust_lookup_type)
1741         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1742         * printcmd.c (display_command, do_one_display): Update.
1743         * parser-defs.h (struct parser_state) <parser_state>: Add
1744         "tracker" parameter.
1745         (block_tracker): New member.
1746         (class innermost_block_tracker) <innermost_block_tracker>: Add
1747         "types" parameter.
1748         <reset>: Remove method.
1749         (innermost_block): Don't declare.
1750         (null_post_parser): Update.
1751         * parse.c (innermost_block): Remove global.
1752         (write_dollar_variable): Update.
1753         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1754         Remove "tracker_types" parameter.
1755         (parse_expression): Add "tracker" parameter.
1756         (parse_expression_for_completion): Update.
1757         (null_post_parser): Add "tracker" parameter.
1758         * p-exp.y: Update rules.
1759         * m2-exp.y: Update rules.
1760         * language.h (struct language_defn) <la_post_parser>: Add
1761         "tracker" parameter.
1762         * go-exp.y: Update rules.
1763         * f-exp.y: Update rules.
1764         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1765         parameter.
1766         * d-exp.y: Update rules.
1767         * c-exp.y: Update rules.
1768         * breakpoint.c (set_breakpoint_condition): Create an
1769         innermost_block_tracker.
1770         (watch_command_1): Likewise.
1771         * ada-lang.c (resolve): Add "tracker" parameter.
1772         (resolve_subexp): Likewise.
1773         * ada-exp.y (write_var_from_sym): Update.
1774
1775 2019-04-04  Tom Tromey  <tom@tromey.com>
1776
1777         * type-stack.h: New file.
1778         * type-stack.c: New file.
1779         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1780         type-stack.h.
1781         (insert_into_type_stack, insert_type, push_type, push_type_int)
1782         (insert_type_address_space, pop_type, pop_type_int)
1783         (pop_typelist, pop_type_stack, append_type_stack)
1784         (push_type_stack, get_type_stack, push_typelist)
1785         (follow_type_instance_flags, follow_types): Don't declare.
1786         * parse.c (type_stack): Remove global.
1787         (parse_exp_in_context): Update.
1788         (insert_into_type_stack, insert_type, push_type, push_type_int)
1789         (insert_type_address_space, pop_type, pop_type_int)
1790         (pop_typelist, pop_type_stack, append_type_stack)
1791         (push_type_stack, get_type_stack, push_typelist)
1792         (follow_type_instance_flags, follow_types): Remove (moved to
1793         type-stack.c).
1794         * f-exp.y (type_stack): New global.
1795         Update rules.
1796         (push_kind_type, f_parse): Update.
1797         * d-exp.y (type_stack): New global.
1798         Update rules.
1799         (d_parse): Update.
1800         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1801         Update rules.
1802         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1803         (HFILES_NO_SRCDIR): Add type-stack.h.
1804
1805 2019-04-04  Tom Tromey  <tom@tromey.com>
1806
1807         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1808         (rust_parser::convert_ast_to_expression, rust_parse)
1809         (rust_lex_test_completion, rust_lex_tests): Update.
1810         * parser-defs.h (struct expr_completion_state): New.
1811         (struct parser_state) <parser_state>: Add completion parameter.
1812         <mark_struct_expression, mark_completion_tag>: New methods.
1813         <parse_completion, m_completion_state>: New members.
1814         (prefixify_expression, null_post_parser): Update.
1815         (mark_struct_expression, mark_completion_tag): Don't declare.
1816         * parse.c (parse_completion, expout_last_struct)
1817         (expout_tag_completion_type, expout_completion_name): Remove
1818         globals.
1819         (parser_state::mark_struct_expression)
1820         (parser_state::mark_completion_tag): Now methods.
1821         (prefixify_expression): Add last_struct parameter.
1822         (prefixify_subexp): Likewise.
1823         (parse_exp_1): Update.
1824         (parse_exp_in_context): Add cstate parameter.  Update.
1825         (parse_expression_for_completion): Create an
1826         expr_completion_state.
1827         (null_post_parser): Add "completion" parameter.
1828         * p-exp.y: Update rules.
1829         (yylex): Update.
1830         * language.h (struct language_defn) <la_post_parser>: Add
1831         "completing" parameter.
1832         * go-exp.y: Update rules.
1833         (lex_one_token): Update.
1834         * expression.h (parse_completion): Don't declare.
1835         * d-exp.y: Update rules.
1836         (lex_one_token): Update rules.
1837         * c-exp.y: Update rules.
1838         (lex_one_token): Update.
1839         * ada-lang.c (resolve): Add "parse_completion" parameter.
1840         (resolve_subexp): Likewise.
1841         (ada_resolve_function): Likewise.
1842
1843 2019-04-04  Tom Tromey  <tom@tromey.com>
1844
1845         * parser-defs.h (struct parser_state) <start_arglist,
1846         end_arglist>: New methods.
1847         <arglist_len, m_funcall_chain>: New members.
1848         (arglist_len, start_arglist, end_arglist): Don't declare.
1849         * parse.c (arglist_len, funcall_chain): Remove global.
1850         (start_arglist, end_arglist): Remove functions.
1851         (parse_exp_in_context): Update.
1852         * p-exp.y: Update rules.
1853         * m2-exp.y: Update rules.
1854         * go-exp.y: Update rules.
1855         * f-exp.y: Update rules.
1856         * d-exp.y: Update rules.
1857         * c-exp.y: Update rules.
1858
1859 2019-04-04  Tom Tromey  <tom@tromey.com>
1860
1861         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1862         lex_operator, push_back>: New methods.
1863         Update all rules.
1864         (rust_parser::lex_hex, lex_escape): Rename and update.
1865         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1866         (rust_parser::lex_operator): Rename and update.
1867         (rust_parser::lex_number, rustyylex, rustyyerror)
1868         (rust_lex_test_init, rust_lex_test_sequence)
1869         (rust_lex_test_push_back, rust_lex_tests): Update.
1870         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1871         parameter.
1872         <lexptr, prev_lexptr>: New members.
1873         (lexptr, prev_lexptr): Don't declare.
1874         * parse.c (lexptr, prev_lexptr): Remove globals.
1875         (parse_exp_in_context): Update.
1876         * p-exp.y (yylex, yyerror): Update.
1877         * m2-exp.y (parse_number, yylex, yyerror): Update.
1878         * go-exp.y (lex_one_token, yyerror): Update.
1879         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1880         * d-exp.y (lex_one_token, yyerror): Update.
1881         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1882         (lex_one_token, yyerror): Update.
1883         * ada-lex.l (YY_INPUT): Update.
1884         (rewind_to_char): Update.
1885         * ada-exp.y (yyerror): Update.
1886
1887 2019-04-04  Tom Tromey  <tom@tromey.com>
1888
1889         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1890         * parser-defs.h (struct parser_state) <parser_state>: Add new
1891         parameter.
1892         <comma_terminates>: New member.
1893         (comma_terminates): Don't declare global.
1894         * parse.c (comma_terminates): Remove global.
1895         (parse_exp_in_context): Update.
1896         * p-exp.y (yylex): Update.
1897         * m2-exp.y (yylex): Update.
1898         * go-exp.y (lex_one_token): Update.
1899         * f-exp.y (yylex): Update.
1900         * d-exp.y (lex_one_token): Update.
1901         * c-exp.y (lex_one_token): Update.
1902         * ada-lex.l: Update.
1903
1904 2019-04-04  Tom Tromey  <tom@tromey.com>
1905
1906         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1907         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1908         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1909         * parser-defs.h (paren_depth): Don't declare.
1910         * parse.c (paren_depth): Remove global.
1911         (parse_exp_in_context): Update.
1912         * p-exp.y (paren_depth): New global.
1913         (pascal_parse): Initialize it.
1914         * m2-exp.y (paren_depth): New global.
1915         (m2_parse): Initialize it.
1916         * go-exp.y (paren_depth): New global.
1917         (go_parse): Initialize it.
1918         * f-exp.y (paren_depth): New global.
1919         (f_parse): Initialize it.
1920         * d-exp.y (paren_depth): New global.
1921         (d_parse): Initialize it.
1922         * c-exp.y (paren_depth): New global.
1923         (c_parse): Initialize it.
1924         * ada-lex.l (paren_depth): New global.
1925         (lexer_init): Initialize it.
1926
1927 2019-04-04  Tom Tromey  <tom@tromey.com>
1928
1929         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1930         (rust_parser::convert_ast_to_type)
1931         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1932         * parser-defs.h (struct parser_state) <parser_state>: Add
1933         parameters.  Initialize new members.
1934         <expression_context_block, expression_context_pc>: New members.
1935         * parse.c (expression_context_block, expression_context_pc):
1936         Remove globals.
1937         (parse_exp_in_context): Update.
1938         * p-exp.y: Update all rules.
1939         (yylex): Update.
1940         * m2-exp.y: Update all rules.
1941         (yylex): Update.
1942         * go-exp.y (yylex): Update.
1943         * f-exp.y (yylex): Update.
1944         * d-exp.y: Update all rules.
1945         (yylex): Update.
1946         * c-exp.y: Update all rules.
1947         (lex_one_token, classify_name, yylex, c_parse): Update.
1948         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1949
1950 2019-04-04  Tom Tromey  <tom@tromey.com>
1951
1952         * gdbarch.h, gdbarch.c: Rebuild.
1953         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1954         * stap-probe.h:
1955         (struct stap_parse_info): Replace "parser_state" with
1956         "expr_builder".
1957         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1958         (parser_state): New class.
1959         * parse.c (expr_builder): Rename.
1960         (expr_builder::release): Rename.
1961         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1962         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1963         (write_exp_elt_longcst, write_exp_elt_floatcst)
1964         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1965         (write_exp_string_vector, write_exp_bitstring)
1966         (write_exp_msymbol, mark_struct_expression)
1967         (write_dollar_variable)
1968         (insert_type_address_space, increase_expout_size): Replace
1969         "parser_state" with "expr_builder".
1970         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1971         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1972         "parser_state" with "expr_builder".
1973
1974 2019-04-04  Tom Tromey  <tom@tromey.com>
1975
1976         * rust-exp.y: Replace "parse_language" with method call.
1977         * p-exp.y:
1978         (yylex): Replace "parse_language" with method call.
1979         * m2-exp.y:
1980         (yylex): Replace "parse_language" with method call.
1981         * go-exp.y (classify_name): Replace "parse_language" with method
1982         call.
1983         * f-exp.y (yylex): Replace "parse_language" with method call.
1984         * d-exp.y (lex_one_token): Replace "parse_language" with method
1985         call.
1986         * c-exp.y:
1987         (lex_one_token, classify_name, yylex): Replace "parse_language"
1988         with method call.
1989         * ada-exp.y (find_primitive_type, type_char)
1990         (type_system_address): Replace "parse_language" with method call.
1991
1992 2019-04-04  Tom Tromey  <tom@tromey.com>
1993
1994         * rust-exp.y: Replace "parse_gdbarch" with method call.
1995         * parse.c (write_dollar_variable, insert_type_address_space):
1996         Replace "parse_gdbarch" with method call.
1997         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1998         call.
1999         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2000         call.
2001         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2002         "parse_gdbarch" with method call.
2003         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2004         with method call.
2005         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2006         "parse_gdbarch" with method call.
2007         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2008         "parse_gdbarch" with method call.
2009         * c-exp.y (parse_type, parse_number, classify_name): Replace
2010         "parse_gdbarch" with method call.
2011         * ada-lex.l: Replace "parse_gdbarch" with method call.
2012         * ada-exp.y (parse_type, find_primitive_type, type_char)
2013         (type_system_address): Replace "parse_gdbarch" with method call.
2014
2015 2019-04-04  Tom Tromey  <tom@tromey.com>
2016
2017         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2018         * stap-probe.c (stap_parse_argument): Update.
2019         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2020         initial_size parameter.
2021         * rust-exp.y (rust_lex_tests): Update.
2022         * parse.c (parser_state): Update.
2023         (parse_exp_in_context): Update.
2024         * parser-defs.h (struct parser_state) <parser_state>: Remove
2025         "initial_size" parameter.
2026
2027 2019-04-04  Tom Tromey  <tom@tromey.com>
2028
2029         * parser-defs.h (increase_expout_size): Don't declare.
2030         * parse.c (increase_expout_size): Now static.
2031
2032 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2033
2034         * gnu-nat.c (gnu_nat_target::wait): Fix
2035         target_waitstatus_to_string call.
2036
2037 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2038
2039         * eval.c (evaluate_subexp_standard): Handle internal functions
2040         during Fortran function call handling.
2041
2042 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2043
2044         * NEWS: Mention new internal functions.
2045         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2046         (read_base_type): Use dwarf2_init_complex_target_type.
2047         * value.c (creal_internal_fn): New function.
2048         (cimag_internal_fn): New function.
2049         (_initialize_values): Register new internal functions.
2050
2051 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2052
2053         * infrun.c (stop_all_threads): If debug_infrun, always
2054         trace the wait status after wait_one, using
2055         target_waitstatus_to_string and target_pid_to_str.
2056         (handle_inferior_event): Replace various trace of
2057         wait status kind by a single trace.
2058         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2059         wait status kind image by target_waitstatus_to_string.
2060         * target/waitstatus.c (target_waitstatus_to_string): Fix
2061         obsolete comment.
2062
2063 2019-04-01  Tom Tromey  <tromey@adacore.com>
2064
2065         PR symtab/23331:
2066         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2067
2068 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2069             Pedro Alves  <palves@redhat.com>
2070
2071         * top.c (quit_force): Call 'finalize_values'.
2072         * value.c (finalize_values): New function.
2073         * value.h (finalize_values): Declare.
2074
2075 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2076
2077         * NEWS: Announce $_gdb_major and $_gdb_minor.
2078
2079         * top.c (init_gdb_version_vars): New function.
2080         (gdb_init): Call init_gdb_version_vars.
2081
2082 2019-03-29  Tom Tromey  <tromey@adacore.com>
2083
2084         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2085         help text.  Remove dead code.
2086
2087 2019-03-29  Keith Seitz  <keiths@redhat.com>
2088
2089         From Siddhesh Poyarekar:
2090         * f-lang.h (f77_get_upperbound): Return LONGEST.
2091         (f77_get_lowerbound): Likewise.
2092         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2093         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2094         print them.
2095         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2096         plongest to format print it.
2097         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2098         (f77_get_upperbound): Likewise.
2099         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2100         LOWER_BOUND to LONGEST.
2101         (f77_create_arrayprint_offset_tbl): Likewise.
2102
2103 2019-03-29  Keith Seitz  <keiths@redhat.com>
2104
2105         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2106         %s/pulongest for TYPE_LENGTH instead of %d in format
2107         strings.
2108         * ada-typerint.c (ada_print_type): Likewise.
2109         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2110         * compile/compile-c-support.c (generate_register_struct): Likewise.
2111         * gdbtypes.c (recursive_dump_type): Likewise.
2112         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2113         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2114         instead of %d in format strings.
2115         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2116         to std::min to ULONGEST.
2117         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2118         instead of %d in format strings.
2119         * tracepoint.c (info_scope_command): Likewise.
2120         * typeprint.c (print_offset_data::update)
2121         (print_offset_data::finish): Likewise.
2122         * xtensa-tdep.c (xtensa_store_return_value)
2123         (xtensa_push_dummy_call): Likewise.
2124
2125 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2126
2127         * windows-nat.c (display_selector): Fixed format specifications
2128         for 64-bit Cygwin.
2129
2130 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2131
2132         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2133
2134 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2135
2136         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2137         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2138         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2139         (nios2_linux_init_abi): Install it.
2140
2141 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2142
2143         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2144
2145 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2146
2147         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2148
2149 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2150             Tom Tromey  <tromey@adacore.com>
2151
2152         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2153
2154 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2155
2156         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2157         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2158         method to compute the bounds of range types. Also print "[evaluated]"
2159         if the bounds' values come from a dynamic evaluation.
2160
2161 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2162
2163         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2164         whitespace when pretty printing is on.
2165
2166 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2167
2168         * ppc-linux-nat.c: Add include.
2169
2170 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2171
2172         * NEWS: Mention AArch64 Pointer Authentication.
2173
2174 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2175
2176         * arm-linux-nat.c: Add include.
2177
2178 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2179
2180         * source-cache.c (source_cache::get_source_lines): Re-read
2181         fullname after calling open_source_file.
2182
2183 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2184
2185         * NEWS: Mention TLS support for FreeBSD.
2186
2187 2019-03-25  Tom Tromey  <tromey@adacore.com>
2188
2189         * minsyms.c (BUNCH_SIZE): Update comment.
2190         (~minimal_symbol_reader): Remove old comment.
2191         (compact_minimal_symbols): Update comment.
2192         (minimal_symbol_reader::install): Remove old comment.  Update
2193         other comments.
2194
2195 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2196
2197         * s390-linux-nat.c: Add include.
2198
2199 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2200
2201         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2202         Call linux_get_hwcap.
2203         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2204         Likewise.
2205         (aarch64_linux_get_hwcap): Remove function.
2206         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2207         declaration.
2208         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2209         linux_get_hwcap.
2210         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2211         * linux-tdep.c (linux_get_hwcap): Add function.
2212         (linux_get_hwcap2): Likewise.
2213         * linux-tdep.h (linux_get_hwcap): Add declaration.
2214         (linux_get_hwcap2): Likewise.
2215         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2216         (ppc_linux_get_hwcap2): Likewise.
2217         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2218         linux_get_hwcap.
2219         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2220         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2221         (ppc_linux_nat_target::read_description): Likewise.
2222         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2223         * s390-linux-nat.c: Likewise.
2224         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2225
2226 2019-03-24  Tom Tromey  <tom@tromey.com>
2227
2228         * ada-lang.c (standard_lookup): Simplify initialization.
2229         (ada_lookup_symbol_nonlocal): Simplify return.
2230         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2231         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2232         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2233         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2234         initialization.
2235         * solib.c (solib_global_lookup): Simplify.
2236         * symtab.c (null_block_symbol): Remove.
2237         (symbol_cache_lookup): Simplify returns.
2238         (lookup_language_this): Simplify returns.
2239         (lookup_symbol_aux): Simplify return.
2240         (lookup_local_symbol): Simplify returns.
2241         (lookup_global_symbol_from_objfile): Simplify return.
2242         (lookup_symbol_in_objfile_symtabs)
2243         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2244         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2245         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2246         * cp-namespace.c (cp_lookup_bare_symbol)
2247         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2248         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2249         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2250         (cp_lookup_symbol_via_imports): Simplify initialization.
2251         (find_symbol_in_baseclass): Likewise.
2252         * symtab.h (null_block_symbol): Remove.
2253         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2254         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2255         (d_lookup_symbol_module): Likewise.
2256         (find_symbol_in_baseclass): Simplify initialization.
2257
2258 2019-03-24  Tom Tromey  <tom@tromey.com>
2259
2260         * expression.h: Don't include symtab.h.
2261         (struct block): Forward declare.
2262
2263 2019-03-24  Tom Tromey  <tom@tromey.com>
2264
2265         * c-exp.y (typebase): Remove casts.
2266         * gdbtypes.c (lookup_unsigned_typename, )
2267         (lookup_signed_typename): Remove cast.
2268         * eval.c (parse_to_comma_and_eval): Remove cast.
2269         * parse.c (write_dollar_variable): Remove cast.
2270         * block.h (struct block) <superblock>: Now const.
2271         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2272         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2273         (map_block): Make "block" const.
2274         * symfile.h (struct quick_symbol_functions)
2275         <map_matching_symbols>: Constify block argument to "callback".
2276         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2277         const.
2278         (find_pc_sect_compunit_symtab): Make "b" const.
2279         (find_symbol_at_address): Likewise.
2280         (search_symbols): Likewise.
2281         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2282         (dw2_debug_names_lookup_symbol): Likewise.
2283         (dw2_map_matching_symbols): Update.
2284         * p-valprint.c (pascal_val_print): Remove "block".
2285         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2286         (aux_add_nonlocal_symbols): Make "block" const.
2287         (resolve_subexp): Remove cast.
2288         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2289         const.
2290         (iterate_over_file_blocks): Likewise.
2291         * f-exp.y (%union) <bval>: Remove.
2292         * coffread.c (patch_opaque_types): Make "b" const.
2293         * spu-tdep.c (spu_catch_start): Make "block" const.
2294         * c-valprint.c (print_unpacked_pointer): Remove "block".
2295         * symmisc.c (dump_symtab_1): Make "b" const.
2296         (block_depth): Make "block" const.
2297         * d-exp.y (%union) <bval>: Remove.
2298         * cp-support.h (cp_lookup_rtti_type): Update.
2299         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2300         * psymtab.c (psym_lookup_symbol): Make "block" const.
2301         (maintenance_check_psymtabs): Make "b" const.
2302         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2303         (enumerate_locals, enumerate_args): Update.
2304         * python/py-symtab.c (stpy_global_block): Make "block" const.
2305         (stpy_static_block): Likewise.
2306         * inline-frame.c (block_starting_point_at): Make "new_block"
2307         const.
2308         * block.c (find_block_in_blockvector): Make return type const.
2309         (blockvector_for_pc_sect): Make "b" const.
2310         (find_block_in_blockvector): Make "b" const.
2311
2312 2019-03-23  Tom Tromey  <tom@tromey.com>
2313
2314         * varobj.c (varobj_create): Update.
2315         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2316         * printcmd.c (display_command, do_one_display): Don't reset
2317         innermost_block.
2318         * parser-defs.h (enum innermost_block_tracker_type): Move to
2319         expression.h.
2320         (innermost_block): Update comment.
2321         * parse.c (parse_exp_1): Add tracker_types parameter.
2322         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2323         tracker_types parameter.  Reset innermost_block.
2324         (parse_exp_in_context): Remove.
2325         (parse_expression_for_completion): Update.
2326         * objfiles.c (~objfile): Don't reset expression_context_block or
2327         innermost_block.
2328         * expression.h (enum innermost_block_tracker_type): Move from
2329         parser-defs.h.
2330         (parse_exp_1): Add tracker_types parameter.
2331         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2332         reset innermost_block.
2333
2334 2019-03-23  Tom Tromey  <tom@tromey.com>
2335
2336         * objfiles.h: Include bcache.h.
2337
2338 2019-03-23  Tom Tromey  <tom@tromey.com>
2339
2340         * linespec.c (get_current_search_block): Use
2341         scoped_restore_current_language.
2342         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2343
2344 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2345             Jiong Wang  <jiong.wang@arm.com>
2346
2347         * aarch64-linux-tdep.c
2348         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2349         section.
2350         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2351
2352 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2353             Jiong Wang  <jiong.wang@arm.com>
2354
2355         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2356         instructions.
2357         (aarch64_analyze_prologue_test): Add PACIASP test.
2358         (aarch64_prologue_prev_register): Unmask PC value.
2359
2360 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2361             Jiong Wang  <jiong.wang@arm.com>
2362
2363         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2364         (aarch64_dwarf2_prev_register): Unmask PC value.
2365         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2366         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2367         DW_CFA_AARCH64_negate_ra_state.
2368         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2369
2370 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2371             Jiong Wang  <jiong.wang@arm.com>
2372
2373         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2374         registers.
2375         (aarch64_pseudo_register_name): Likewise.
2376         (aarch64_pseudo_register_type): Likewise.
2377         (aarch64_pseudo_register_reggroup_p): Likewise.
2378         (aarch64_gdbarch_init): Add pauth registers.
2379         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2380         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2381         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2382         (struct gdbarch_tdep): Add regnum for ra_state.
2383
2384 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2385             Jiong Wang  <jiong.wang@arm.com>
2386
2387         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2388
2389 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2390             Jiong Wang  <jiong.wang@arm.com>
2391
2392         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2393         function.
2394         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2395         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2396         (aarch64_gdbarch_init): Add puth registers.
2397         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2398         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2399         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2400
2401 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2402             Jiong Wang  <jiong.wang@arm.com>
2403
2404         * aarch64-linux-nat.c
2405         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2406         * aarch64-linux-tdep.c
2407         (aarch64_linux_core_read_description): Likewise.
2408         (aarch64_linux_get_hwcap): New function.
2409         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2410         (aarch64_linux_get_hwcap): New declaration.
2411
2412 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2413             Jiong Wang  <jiong.wang@arm.com>
2414
2415         * aarch64-linux-nat.c
2416         (aarch64_linux_nat_target::read_description): Add pauth param.
2417         * aarch64-linux-tdep.c
2418         (aarch64_linux_core_read_description): Likewise.
2419         * aarch64-tdep.c (struct target_desc): Add in pauth.
2420         (aarch64_read_description): Add pauth param.
2421         (aarch64_gdbarch_init): Likewise.
2422         * aarch64-tdep.h (aarch64_read_description): Likewise.
2423         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2424         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2425         * features/Makefile: Add new files.
2426         * features/aarch64-pauth.c: New file.
2427         * features/aarch64-pauth.xml: New file.
2428
2429 2019-03-20  Tom Tromey  <tromey@adacore.com>
2430
2431         * infrun.c (handle_inferior_event): Rename from
2432         handle_inferior_event_1.  Create a scoped_value_mark.
2433         (handle_inferior_event): Remove.
2434
2435 2019-03-19  Tom Tromey  <tromey@adacore.com>
2436
2437         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2438         * infrun.h (print_stop_event): Add "displays" parameter.
2439         * infrun.c (print_stop_event): Add "displays" parameter.
2440
2441 2019-03-19  Pedro Alves  <palves@redhat.com>
2442
2443         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2444         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2445         to -1.  Fix TABs vs spaces.
2446         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2447         * tui/tui-out.h (tui_ui_out) Add intro comments.
2448         <m_line, m_start_of_line>: In-class initialize, and add describing
2449         comment.
2450
2451 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2452
2453         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2454         variable names.
2455         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2456
2457 2019-03-18  Pedro Alves  <palves@redhat.com>
2458             Eli Zaretskii <eliz@gnu.org>
2459
2460         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2461         m_line and m_start_of_line.
2462
2463 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2464
2465         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2466         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2467         it returns a newline.  This fixes a regression in TU mode, whereby
2468         the next line is output on the same screen line as the user input.
2469
2470 2019-03-18  Tom Tromey  <tromey@adacore.com>
2471
2472         * minsyms.c (minimal_symbol_reader::install): Remove call to
2473         obstack_blank.
2474
2475 2019-03-18  Pedro Alves  <palves@redhat.com>
2476
2477         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2478         New globals.
2479         (apply_style): New, factored out from ...
2480         (apply_ansi_escape): ... this.  Handle reverse video mode.
2481         (tui_set_reverse_mode): New function.
2482         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2483         * tui/tui-winsource.c (tui_show_source_line): Use
2484         tui_set_reverse_mode instead of setting A_STANDOUT.
2485         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2486         New setter methods.
2487
2488 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2489
2490         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2491         Handle tabs.
2492
2493 2019-03-18  Tom Tromey  <tromey@adacore.com>
2494
2495         * ada-lang.c (empty_array): Add "high" parameter.
2496         (ada_evaluate_subexp): Update.
2497
2498 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2499
2500         * unittests/string_view-selftests.c: Define
2501         _initialize_string_view_selftests unconditionally.
2502
2503 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2504
2505         PR gdb/24350
2506         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2507
2508 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2509
2510         PR gdb/24351
2511         * windows-nat.c (display_selector): Fix format specifiers.
2512
2513 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2514
2515         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2516         tui_refill_source_window instead of tui_refresh_win, to update the
2517         current execution line.  This fixes redisplay of the current line
2518         when stepping through the code with "next" or "step".
2519
2520 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2521
2522         * source-cache.c (source_cache::get_source_lines): Call
2523         find_source_lines to initialize s->nlines.  This fixes vertical
2524         scrolling of TUI source window when the DOWN arrow is pressed.
2525
2526 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2527
2528         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2529         linux-thread-db.c (_initialize_thread_db): Likewise.
2530
2531 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2532
2533         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2534         wclrtoeol in tui_show_source_line".  This reverts changes made in
2535         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2536
2537 2019-03-15  Tom Tromey  <tom@tromey.com>
2538
2539         * symtab.h (struct minimal_symbol): Derive from
2540         general_symbol_info.
2541         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2542         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2543         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2544         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2545         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2546         (MSYMBOL_SEARCH_NAME): Update.
2547         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2548         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2549         * minsyms.c (minimal_symbol_reader::record_full): Update.
2550
2551 2019-03-15  Tom Tromey  <tom@tromey.com>
2552
2553         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2554
2555 2019-03-15  Tom Tromey  <tom@tromey.com>
2556
2557         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2558         unique_xmalloc_ptr.
2559         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2560         Update.
2561         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2562         (build_minimal_symbol_hash_tables)
2563         (minimal_symbol_reader::install): Update.
2564
2565 2019-03-15  Tom Tromey  <tom@tromey.com>
2566
2567         * symtab.c (create_demangled_names_hash): Update.
2568         (symbol_set_names): Update.
2569         * objfiles.h (struct objfile_per_bfd_storage)
2570         <demangled_names_hash>: Now an htab_up.
2571         * objfiles.c (objfile_per_bfd_storage): Simplify.
2572
2573 2019-03-15  Tom Tromey  <tom@tromey.com>
2574
2575         * objfiles.h (struct objfile_per_bfd_storage): Declare
2576         destructor.
2577         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2578         New.
2579         (get_objfile_bfd_data): Use new.  Don't initialize
2580         language_of_main.
2581         (free_objfile_per_bfd_storage): Remove.
2582         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2583
2584 2019-03-15  Tom Tromey  <tom@tromey.com>
2585
2586         * symfile.c (reread_symbols): Update.
2587         * objfiles.c (objfile::objfile): Update.
2588         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2589         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2590         comment.
2591         (minimal_symbol_reader::install): Update.
2592         (terminate_minimal_symbol_table): Remove.
2593         * jit.c (jit_object_close_impl): Update.
2594
2595 2019-03-15  Tom Tromey  <tom@tromey.com>
2596
2597         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2598         initializations.
2599
2600 2019-03-15  Tom Tromey  <tom@tromey.com>
2601
2602         * objfiles.h (struct objfile_per_bfd_storage)
2603         <demangled_hash_languages>: Now a bitset.
2604         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2605         (lookup_minimal_symbol): Update.
2606
2607 2019-03-15  Tom Tromey  <tom@tromey.com>
2608
2609         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2610         Don't return the symbol.
2611         * coffread.c (record_minimal_symbol): Use record_full.
2612
2613 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2614
2615         The MS-Windows port of ncurses fails to switch to a color pair if
2616         one or both of the colors are the implicit default colors.  This
2617         change records the default colors when TUI is initialized, and
2618         then specifies them explicitly when a color pair uses the default
2619         colors.  This allows color styling in TUI mode on MS-Windows.
2620
2621         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2622         ncurses_norm_attr.
2623         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2624         colors in ncurses_norm_attr.
2625         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2626         "none", replace it with the default color recorded in
2627         ncurses_norm_attr.
2628
2629 2019-03-14  Tom Tromey  <tromey@adacore.com>
2630
2631         * source-cache.h (class source_cache) <get_source_lines>: Return
2632         std::string.
2633         * source-cache.c (source_cache::extract_lines): Handle case where
2634         first_pos==npos.  Return std::string.
2635         (source_cache::get_source_lines): Update.
2636
2637 2019-03-14  Tom Tromey  <tromey@adacore.com>
2638
2639         * NEWS: Add item for "style sources" commands.
2640         * source-cache.c (source_cache::get_source_lines): Check
2641         source_styling.
2642         * cli/cli-style.c (source_styling): New global.
2643         (_initialize_cli_style): Add "style sources" commands.
2644         (show_style_sources): New function.
2645         * cli/cli-style.h (source_styling): Declare.
2646
2647 2019-03-14  Pedro Alves  <palves@redhat.com>
2648             Tom Tromey  <tromey@adacore.com>
2649
2650         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2651         * tui/tui-winsource.c (tui_refill_source_window): New function,
2652         from...
2653         (tui_horizontal_source_scroll): ... here.  Move some logic.
2654         * cli/cli-style.c (set_style_enabled): Notify new observable.
2655         * tui/tui-hooks.c (tui_redisplay_source): New function.
2656         (tui_attach_detach_observers): Attach or detach
2657         tui_redisplay_source.
2658         * observable.h (source_styling_changed): New observable.
2659         * observable.c: Define source_styling_changed observable.
2660
2661 2019-03-13  Tom Tromey  <tromey@adacore.com>
2662
2663         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2664         (i386_gnu_nat_target::store_registers): Update.
2665         * target-debug.h (target_debug_print_std_string): New macro.
2666         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2667         * windows-tdep.c (display_one_tib): Update.
2668         * tui/tui-stack.c (tui_make_status_line): Update.
2669         * top.c (print_inferior_quit_action): Update.
2670         * thread.c (thr_try_catch_cmd): Update.
2671         (add_thread_with_info): Update.
2672         (thread_target_id_str): Update.
2673         (thr_try_catch_cmd): Update.
2674         (thread_command): Update.
2675         (thread_find_command): Update.
2676         * record-btrace.c (record_btrace_target::info_record)
2677         (record_btrace_resume_thread, record_btrace_target::resume)
2678         (record_btrace_cancel_resume, record_btrace_step_thread)
2679         (record_btrace_target::wait, record_btrace_target::wait)
2680         (record_btrace_target::wait, record_btrace_target::stop): Update.
2681         * progspace.c (print_program_space): Update.
2682         * process-stratum-target.c
2683         (process_stratum_target::thread_address_space): Update.
2684         * linux-fork.c (linux_fork_mourn_inferior)
2685         (detach_checkpoint_command, info_checkpoints_command)
2686         (linux_fork_context): Update.
2687         (linux_fork_detach): Update.
2688         (class scoped_switch_fork_info): Update.
2689         (delete_checkpoint_command): Update.
2690         * infrun.c (follow_fork_inferior): Update.
2691         (follow_fork_inferior): Update.
2692         (proceed_after_vfork_done): Update.
2693         (handle_vfork_child_exec_or_exit): Update.
2694         (follow_exec): Update.
2695         (displaced_step_prepare_throw): Update.
2696         (displaced_step_restore): Update.
2697         (start_step_over): Update.
2698         (resume_1): Update.
2699         (clear_proceed_status_thread): Update.
2700         (proceed): Update.
2701         (print_target_wait_results): Update.
2702         (do_target_wait): Update.
2703         (context_switch): Update.
2704         (stop_all_threads): Update.
2705         (restart_threads): Update.
2706         (finish_step_over): Update.
2707         (handle_signal_stop): Update.
2708         (switch_back_to_stepped_thread): Update.
2709         (keep_going_pass_signal): Update.
2710         (print_exited_reason): Update.
2711         (normal_stop): Update.
2712         * inferior.c (inferior_pid_to_str): Change return type.
2713         (print_selected_inferior): Update.
2714         (add_inferior): Update.
2715         (detach_inferior): Update.
2716         * dummy-frame.c (fprint_dummy_frames): Update.
2717         * dcache.c (dcache_info_1): Update.
2718         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2719         (btrace_fetch, btrace_clear): Update.
2720         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2721         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2722         type.
2723         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2724         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2725         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2726         * gdbarch.c, gdbarch.h: Rebuild.
2727         * gdbarch.sh (core_pid_to_str): Change return type.
2728         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2729         return type.
2730         (windows_nat_target::pid_to_str): Change return type.
2731         (windows_delete_thread): Update.
2732         (windows_nat_target::attach): Update.
2733         (windows_nat_target::files_info): Update.
2734         * target-delegates.c: Rebuild.
2735         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2736         return type.
2737         (sol_thread_target::pid_to_str): Change return type.
2738         * remote.c (class remote_target) <pid_to_str>: Change return
2739         type.
2740         (remote_target::pid_to_str): Change return type.
2741         (extended_remote_target::attach, remote_target::remote_stop_ns)
2742         (remote_target::remote_notif_remove_queued_reply)
2743         (remote_target::push_stop_reply, remote_target::disable_btrace):
2744         Update.
2745         (extended_remote_target::attach): Update.
2746         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2747         type.
2748         (gdbsim_target::pid_to_str): Change return type.
2749         * ravenscar-thread.c (struct ravenscar_thread_target)
2750         <pid_to_str>: Change return type.
2751         (ravenscar_thread_target::pid_to_str): Change return type.
2752         * procfs.c (class procfs_target) <pid_to_str>: Change return
2753         type.
2754         (procfs_target::pid_to_str): Change return type.
2755         (procfs_target::attach): Update.
2756         (procfs_target::detach): Update.
2757         (procfs_target::fetch_registers): Update.
2758         (procfs_target::store_registers): Update.
2759         (procfs_target::wait): Update.
2760         (procfs_target::files_info): Update.
2761         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2762         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2763         return type.
2764         (nto_procfs_target::pid_to_str): Change return type.
2765         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2766         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2767         return type.
2768         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2769         (exit_lwp): Update.
2770         (attach_proc_task_lwp_callback, get_detach_signal)
2771         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2772         (linux_nat_target::resume, wait_lwp, stop_callback)
2773         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2774         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2775         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2776         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2777         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2778         type.
2779         (inf_ptrace_target::attach): Update.
2780         (inf_ptrace_target::files_info): Update.
2781         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2782         type.
2783         (go32_nat_target::pid_to_str): Change return type.
2784         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2785         (gnu_nat_target::wait): Update.
2786         (gnu_nat_target::wait): Update.
2787         (gnu_nat_target::resume): Update.
2788         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2789         (fbsd_nat_target::wait): Update.
2790         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2791         type.
2792         (darwin_nat_target::attach): Update.
2793         * corelow.c (class core_target) <pid_to_str>: Change return type.
2794         (core_target::pid_to_str): Change return type.
2795         * target.c (normal_pid_to_str): Change return type.
2796         (default_pid_to_str): Likewise.
2797         (target_pid_to_str): Change return type.
2798         (target_translate_tls_address): Update.
2799         (target_announce_detach): Update.
2800         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2801         return type.
2802         (bsd_uthread_target::pid_to_str): Change return type.
2803         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2804         type.
2805         (bsd_kvm_target::pid_to_str): Change return type.
2806         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2807         return type.
2808         (aix_thread_target::pid_to_str): Change return type.
2809         * target.h (struct target_ops) <pid_to_str>: Change return type.
2810         (target_pid_to_str, normal_pid_to_str): Likewise.
2811         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2812         type.
2813         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2814         type.
2815         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2816         return type.
2817         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2818         type.
2819         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2820         type.
2821         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2822         return type.
2823
2824 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2825
2826         * NEWS: Mention that the new default MI version is 3.  Mention
2827         changes to the output of commands and events that deal with
2828         multi-location breakpoints.
2829         * breakpoint.c: Include "mi/mi-out.h".
2830         (print_one_breakpoint): Change output syntax if using MI version
2831         >= 3.
2832         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2833         New.
2834         (mi_multi_location_breakpoint_output_fixed): New.
2835         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2836         (mi_cmd_fix_multi_location_breakpoint_output): New.
2837         (mi_multi_location_breakpoint_output_fixed): New.
2838         * mi/mi-cmds.c (mi_cmds): Register command
2839         -fix-multi-location-breakpoint-output.
2840         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2841         interpreter "mi".
2842
2843 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2844
2845         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2846         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2847         instantiate mi_ui_out based on interpreter name.
2848         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2849         * mi/mi-main.c (mi_load_progress): Likewise.
2850
2851 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2852
2853         * NEWS: Combine separate "New targets" sections for 8.3.
2854
2855 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2856
2857         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2858         (ppcfbsd_init_abi): Install gdbarch
2859         "fetch_tls_load_module_address" and "get_thread_local_address"
2860         methods.
2861
2862 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2863
2864         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2865         (riscv_fbsd_init_abi): Install gdbarch
2866         "fetch_tls_load_module_address" and "get_thread_local_address"
2867         methods.
2868
2869 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2870
2871         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2872         (i386fbsd_init_abi): Install gdbarch
2873         "fetch_tls_load_module_address" and "get_thread_local_address"
2874         methods.
2875
2876 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2877
2878         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2879         (amd64fbsd_init_abi): Install gdbarch
2880         "fetch_tls_load_module_address" and "get_thread_local_address"
2881         methods.
2882
2883 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2884
2885         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2886         (struct fbsd_pspace_data): New type.
2887         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2888         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2889         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2890         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2891         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2892
2893 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2894
2895         * gdbtypes.c (lookup_struct_elt): New function.
2896         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2897         * gdbtypes.h (struct struct_elt): New type.
2898         (lookup_struct_elt): New prototype.
2899
2900 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2901
2902         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2903         remove disabled code block.
2904
2905 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2906
2907         * gdbarch.sh (get_thread_local_address): New method.
2908         * gdbarch.h, gdbarch.c: Regenerate.
2909         * target.c (target_translate_tls_address): Use
2910         gdbarch_get_thread_local_address if present instead of
2911         target::get_thread_local_address.
2912
2913 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2914
2915         * target.h (target::get_thread_local_address): Update comment.
2916
2917 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2918
2919         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2920         objfile->separate_debug_objfile_backlink if not NULL.
2921
2922 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2923
2924         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2925         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2926         (amd64bsd_store_inferior_registers): Likewise.
2927         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2928         Enable segment base registers.
2929         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2930         PT_GETFSBASE and PT_GETGSBASE.
2931         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2932         PT_SETGSBASE.
2933         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2934         segment base registers.
2935         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2936
2937 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2938
2939         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2940         Update calls to i386_target_description to add 'segments'
2941         parameter.
2942         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2943         add segment base registers.
2944         * arch/i386.c (i386_create_target_description): Add 'segments'
2945         parameter to enable segment base registers.
2946         * arch/i386.h (i386_create_target_description): Likewise.
2947         * features/i386/32bit-segments.xml: New file.
2948         * features/i386/32bit-segments.c: Generate.
2949         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2950         call to i386_target_description to add 'segments' parameter.
2951         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2952         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2953         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2954         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2955         if feature is present.
2956         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2957         Add 'segments' parameter to call to i386_target_description.
2958         (i386_target_description): Add 'segments' parameter to enable
2959         segment base registers.
2960         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2961         to call to i386_target_description.
2962         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2963         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2964         Define I386_NUM_REGS.
2965         (i386_target_description): Add 'segments' parameter to enable
2966         segment base registers.
2967
2968 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2969
2970         PR/24325
2971         * source-cache.c: #undef open and close, to avoid unresolved
2972         externals during linking.
2973
2974 2019-03-12  Tom Tromey  <tromey@adacore.com>
2975
2976         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2977         const.  Add initializers.
2978         (_initialize_remote): Don't initialize ptid globals.
2979
2980 2019-03-12  Pedro Alves  <palves@redhat.com>
2981
2982         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2983
2984 2019-03-12  Pedro Alves  <palves@redhat.com>
2985
2986         * cp-name-parser.y (main): Remove unused 'len' variable.
2987
2988 2019-03-12  Tom Tromey  <tromey@adacore.com>
2989
2990         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2991         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2992
2993 2019-03-12  Tom Tromey  <tromey@adacore.com>
2994
2995         * linux-nat.c (iterate_over_lwps): Update.
2996         (stop_callback): Remove parameter.
2997         (stop_wait_callback, detach_callback, resume_set_callback)
2998         (select_singlestep_lwp_callback, set_ignore_sigint)
2999         (status_callback, resumed_callback, resume_clear_callback)
3000         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3001         data parameter.
3002         (linux_nat_target::detach, linux_nat_target::resume)
3003         (linux_stop_and_wait_all_lwps, select_event_lwp)
3004         (linux_nat_filter_event, linux_nat_wait_1)
3005         (linux_nat_target::kill, linux_nat_target::stop)
3006         (linux_nat_target::stop): Update.
3007         (linux_nat_resume_callback): Change type.
3008         (resume_stopped_resumed_lwps, count_events_callback)
3009         (select_event_lwp_callback): Likewise.
3010         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3011         * arm-linux-nat.c (struct update_registers_data): Remove.
3012         (update_registers_callback): Change type.
3013         (arm_linux_insert_hw_breakpoint1): Update.
3014         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3015         parameter.
3016         (x86_linux_dr_set_addr): Update.
3017         (x86_linux_dr_set_control): Update.
3018         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3019         (iterate_over_lwps): Use gdb::function_view.
3020         * nat/aarch64-linux-hw-point.c (struct
3021         aarch64_dr_update_callback_param): Remove.
3022         (debug_reg_change_callback): Change type.
3023         (aarch64_notify_debug_reg_change): Update.
3024         * s390-linux-nat.c (s390_refresh_per_info): Update.
3025
3026 2019-03-11  Tom Tromey  <tromey@adacore.com>
3027
3028         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3029         redundant assignment to "this_cu".
3030
3031 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3032
3033         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3034
3035 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3036
3037         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3038         from...
3039         (rank_one_type): ... this.
3040
3041 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3042
3043         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3044         from...
3045         (rank_one_type): ... this.
3046
3047 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3048
3049         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3050         from...
3051         (rank_one_type): ... this.
3052
3053 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3054
3055         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3056         from...
3057         (rank_one_type): ... this.
3058
3059 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3060
3061         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3062         from...
3063         (rank_one_type): ... this.
3064
3065 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3066
3067         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3068         from...
3069         (rank_one_type): ... this.
3070
3071 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3072
3073         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3074         from...
3075         (rank_one_type): ... this.
3076
3077 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3078
3079         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3080         from...
3081         (rank_one_type): ... this.
3082
3083 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3084
3085         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3086         from...
3087         (rank_one_type): ... this.
3088
3089 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3090
3091         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3092         from...
3093         (rank_one_type): ... this.
3094
3095 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3096
3097         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3098         from...
3099         (rank_one_type): ... this.
3100
3101 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3102
3103         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3104         from...
3105         (rank_one_type): ... this.
3106
3107 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3108
3109         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3110         inferior-events' shows the example events.
3111
3112 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3113
3114         Support styling on native MS-Windows console
3115
3116         PR/24315
3117         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3118         on MS-Windows if $TERM is not defined.
3119
3120         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3121
3122         * posix-hdep.c (gdb_console_fputs):
3123         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3124         functions.
3125         * ui-file.h (gdb_console_fputs): Add prototype.
3126
3127         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3128         back to fputs only if the former returns zero.
3129
3130 2019-03-07  Tom Tromey  <tom@tromey.com>
3131
3132         * symmisc.c (print_symbol_bcache_statistics): Update.
3133         (print_objfile_statistics): Update.
3134         * symfile.c (allocate_symtab): Update.
3135         * stabsread.c: Don't include bcache.h.
3136         * psymtab.h (struct psymbol_bcache): Don't declare.
3137         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3138         (psymbol_bcache_init, psymbol_bcache_free)
3139         (psymbol_bcache_get_bcache): Don't declare.
3140         * psymtab.c (struct psymbol_bcache): Remove.
3141         (psymtab_storage::psymtab_storage): Update.
3142         (psymtab_storage::~psymtab_storage): Update.
3143         (psymbol_bcache_init, psymbol_bcache_free)
3144         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3145         (add_psymbol_to_bcache): Update.
3146         (allocate_psymtab): Update.
3147         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3148         macro_cache>: No longer pointers.
3149         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3150         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3151         * macrotab.c (macro_bcache): Update.
3152         * macroexp.c: Don't include bcache.h.
3153         * gdbtypes.c (check_types_worklist): Update.
3154         (types_deeply_equal): Remove TRY/CATCH.  Update.
3155         * elfread.c (elf_symtab_read): Update.
3156         * dwarf2read.c: Don't include bcache.h.
3157         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3158         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3159         (print_bcache_statistics, bcache_memory_used): Don't declare.
3160         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3161         methods.  Rename all data members.
3162         * bcache.c (struct bcache): Move to bcache.h.
3163         (bcache::expand_hash_table): Rename from expand_hash_table.
3164         (bcache): Remove.
3165         (bcache::insert): Rename from bcache_full.
3166         (bcache::compare): Rename from bcache_compare.
3167         (bcache_xmalloc): Remove.
3168         (bcache::~bcache): Rename from bcache_xfree.
3169         (bcache::print_statistics): Rename from print_bcache_statistics.
3170         (bcache::memory_used): Rename from bcache_memory_used.
3171
3172 2019-03-07  Pedro Alves  <palves@redhat.com>
3173
3174         * infrun.c (normal_stop): Also check for
3175         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3176
3177 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3178
3179         * f-lang.c (value_from_host_double): Moved to...
3180         * value.c (value_from_host_double): ...here.
3181         * value.h (value_from_host_double): Declare.
3182         * guile/scm-math.c (vlscm_convert_typed_number): Use
3183         value_from_host_double.
3184         (vlscm_convert_number): Likewise.
3185         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3186         * python/py-value.c (convert_value_from_python): Likewise.
3187
3188 2019-03-06  Tom Tromey  <tom@tromey.com>
3189
3190         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3191
3192 2019-03-06  Tom Tromey  <tom@tromey.com>
3193
3194         * utils.h (free_current_contents): Don't declare.
3195         * utils.c (free_current_contents): Remove.
3196
3197 2019-03-06  Tom Tromey  <tom@tromey.com>
3198
3199         * top.c (quit_force): Update.
3200         * main.c (captured_command_loop): Update.
3201         * common/new-op.c (operator new): Update.
3202         * common/common-exceptions.c (struct catcher)
3203         <save_cleanup_chain>: Remove member.
3204         (exceptions_state_mc_init): Update.
3205         (exception_try_scope_entry): Return nullptr.
3206         (exception_try_scope_exit, exception_rethrow)
3207         (throw_exception_sjlj, throw_exception_cxx): Update.
3208         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3209         (all_cleanups, do_cleanups, discard_cleanups)
3210         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3211         (restore_cleanups, restore_final_cleanups): Don't declare.
3212         (do_final_cleanups): Remove parameter.
3213         * common/cleanups.c (cleanup_chain, make_cleanup)
3214         (make_cleanup_dtor, all_cleanups, do_cleanups)
3215         (discard_my_cleanups, discard_cleanups)
3216         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3217         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3218         (null_cleanup): Remove.
3219         (do_final_cleanups): Remove parameter.
3220
3221 2019-03-06  Tom Tromey  <tom@tromey.com>
3222
3223         * remote.c (remote_target::remote_parse_stop_reply): Use
3224         unique_xmalloc_ptr.
3225
3226 2019-03-06  Tom Tromey  <tom@tromey.com>
3227
3228         * stabsread.c (struct stabs_field_info): Rename from field_info.
3229         <list, fnlist>: Add initializers.
3230         <obstack>: New member.
3231         (read_member_functions, read_struct_fields, read_baseclasses):
3232         Allocate on obstack.  Don't use cleanups.
3233         (read_one_struct_field, read_member_functions, read_struct_fields)
3234         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3235         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3236         (read_struct_type): Update.
3237
3238 2019-03-06  Tom Tromey  <tom@tromey.com>
3239
3240         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3241         * common/filestuff.h (make_cleanup_close): Don't declare.
3242         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3243         Remove.
3244
3245 2019-03-06  Tom Tromey  <tom@tromey.com>
3246
3247         * solib-aix.c: Use make_scope_exit.
3248
3249 2019-03-06  Tom Tromey  <tom@tromey.com>
3250
3251         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3252         Use make_scope_exit.
3253
3254 2019-03-06  Tom Tromey  <tom@tromey.com>
3255
3256         * solib-svr4.c (disable_probes_interface): Remove parameter.
3257         (svr4_handle_solib_event): Use make_scope_exit.
3258
3259 2019-03-06  Tom Tromey  <tom@tromey.com>
3260
3261         * remote.c (struct stop_reply_deleter): Remove.
3262         (stop_reply_up): Update.
3263         (struct stop_reply): Derive from notif_event.  Don't typedef.
3264         <regcache>: Now a std::vector.
3265         (stop_reply_xfree): Remove.
3266         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3267         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3268         (remote_target::discard_pending_stop_replies): Use delete.
3269         (remote_target::remote_parse_stop_reply): Update.
3270         (remote_target::process_stop_reply): Update.
3271         * remote-notif.h (struct notif_event): Add virtual destructor.
3272         Remove "dtr" member.
3273         (struct notif_client) <alloc_event>: Return a unique_ptr.
3274         (notif_event_xfree): Don't declare.
3275         (notif_event_up): New typedef.
3276         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3277         (notif_event_xfree, do_notif_event_xfree): Remove.
3278         (remote_notif_state_xfree): Update.
3279
3280 2019-03-06  Tom Tromey  <tom@tromey.com>
3281
3282         * infrun.c (displaced_step_clear_cleanup): Now a
3283         forward_scope_exit type.
3284         (displaced_step_prepare_throw): Update.
3285         (displaced_step_fixup): Update.
3286
3287 2019-03-06  Tom Tromey  <tom@tromey.com>
3288
3289         * inferior.h (class inferior): Update comment.
3290         * gdbthread.h (class thread_info): Update comment.
3291
3292 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3293             Tom Tromey  <tom@tromey.com>
3294
3295         * stabsread.h (struct stab_section_list): Remove.
3296         (coffstab_build_psymtabs): Update.
3297         * dbxread.c (symbuf_sections): Now a std::vector.
3298         (sect_idx): New global.
3299         (fill_symbuf): Update.
3300         (coffstab_build_psymtabs): Change type of stabsects parameter.
3301         Update.
3302         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3303         std::vector.
3304         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3305         (coff_locate_sections): Update.
3306         (coff_symfile_read): Remove cleanups.  Update.
3307         (init_stringtab): Add storage parameter.
3308         (free_stringtab, free_stringtab_cleanup): Remove.
3309         (init_lineno): Add storage parameter.
3310         (free_linetab, free_linetab_cleanup): Remove.
3311
3312 2019-03-06  Pedro Alves  <palves@redhat.com>
3313
3314         * linux-fork.c (fork_info::clobber_regs): Delete.
3315         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3316         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3317         comment.  Adjust.
3318         (scoped_switch_fork_info::scoped_switch_fork_info)
3319         (checkpoint_command, linux_fork_context): Adjust
3320         fork_save_infrun_state calls.
3321
3322 2019-03-06  Pedro Alves  <palves@redhat.com>
3323
3324         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3325         (inf_has_multiple_threads): Return 'bool' and rewrite using
3326         inferior_info::threads().
3327
3328 2019-03-06  Pedro Alves  <palves@redhat.com>
3329
3330         * linux-fork.c: Include <list>.
3331         (fork_list): Now a std::list instance.
3332         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3333         (forks_exist_p, find_last_fork): Adjust.
3334         (new_fork): Delete.
3335         (one_fork_p): New.
3336         (add_fork): Adjust.
3337         (free_fork): Delete, folded into fork_info::~fork_info().
3338         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3339         Adjust.
3340         (init_fork_list): Delete.
3341         (linux_fork_killall, linux_fork_mourn_inferior)
3342         (linux_fork_detach, info_checkpoints_command): Adjust.
3343         (_initialize_linux_fork): No longer call init_fork_list.
3344
3345 2019-03-06  Pedro Alves  <palves@redhat.com>
3346
3347         * linux-fork.c (new_fork): New, split out of ...
3348         (add_fork): ... this.  Return void.  Move "first fork" special
3349         case from here, to ...
3350         (checkpoint_command): ... here.
3351         * linux-linux.h (add_fork): Return void.
3352
3353 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3354
3355         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3356
3357 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3358             Chris January  <chris.january@arm.com>
3359             David Lecomber  <david.lecomber@arm.com>
3360
3361         * f-exp.y: New token, UNOP_INTRINSIC.
3362         (exp): New pattern using UNOP_INTRINSIC token.
3363         (f77_keywords): Add 'abs' keyword.
3364         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3365         (value_from_host_double): New function.
3366         (evaluate_subexp_f): Support UNOP_ABS.
3367
3368 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3369
3370         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3371         types.
3372
3373 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3374
3375         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3376         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3377         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3378
3379 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3380
3381         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3382
3383 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3384             Chris January  <chris.january@arm.com>
3385
3386         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3387         * f-exp.y: Define 'KIND' token.
3388         (exp): New pattern for KIND expressions.
3389         (ptype): Handle types with a kind extension.
3390         (direct_abs_decl): Extend to spot kind extensions.
3391         (f77_keywords): Add 'kind' to the list.
3392         (push_kind_type): New function.
3393         (convert_to_kind_type): New function.
3394         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3395         * parse.c (operator_length_standard): Likewise.
3396         * parser-defs.h (enum type_pieces): Add tp_kind.
3397         * std-operator.def: Add UNOP_KIND.
3398
3399 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3400
3401         * f-exp.y (f_parse): Set yydebug.
3402
3403 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3404
3405         * f-lang.c (evaluate_subexp_f): New function.
3406         (exp_descriptor_f): New global.
3407         (f_language_defn): Use exp_descriptor_f instead of
3408         exp_descriptor_standard.
3409
3410 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3411
3412         * f-exp.y (struct token): Add comments.
3413         (dot_ops): Remove uppercase versions and the end marker.
3414         (f77_keywords): Likewise.
3415         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3416         entries in the dot_ops array are case insensitive, and use
3417         strncasecmp to compare strings.  Also some whitespace cleanup in
3418         this area.  Similar for the f77_keywords array, except entries in
3419         this list might be case sensitive.
3420
3421 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3422
3423         * f-exp.y (struct f77_boolean_val): Add comments.
3424         (boolean_values): Remove uppercase versions, and end marker.
3425         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3426         and use strncasecmp to achieve case insensitivity.  Additionally,
3427         perform whitespace cleanup around this code.
3428
3429 2019-03-06  Tom Tromey  <tromey@adacore.com>
3430
3431         * remote-sim.c (gdbsim_target_open): Use result of
3432         gdb_argv::release.
3433
3434 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3435         Dirk Schubert  <dirk.schubert@arm.com>
3436         Chris January  <chris.january@arm.com>
3437
3438         * eval.c (evaluate_subexp_standard): Call Fortran argument
3439         wrapping logic.
3440         * f-lang.c (struct value): A value which can be passed into a
3441         Fortran function call.
3442         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3443         where appropriate.
3444         (struct type): Value ready for a Fortran function call.
3445         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3446         is needed.
3447         * f-lang.h (fortran_argument_convert): Declaration.
3448         (fortran_preserve_arg_pointer): Declaration.
3449         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3450
3451 2019-03-05  Tom Tromey  <tromey@adacore.com>
3452
3453         * python/py-prettyprint.c (print_string_repr): Remove #if.
3454         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3455
3456 2019-03-05  Tom Tromey  <tromey@adacore.com>
3457
3458         * target.c (the_dummy_target): Move later.  Change type to
3459         "dummy_target".
3460         (initialize_targets): Don't initialize the_dummy_target.
3461
3462 2019-03-05  Tom Tromey  <tromey@adacore.com>
3463
3464         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3465         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3466
3467 2019-03-05  Tom Tromey  <tromey@adacore.com>
3468
3469         * windows-nat.c (windows_nat_target::attach)
3470         (windows_nat_target::detach): Don't call gdb_flush.
3471         * valprint.c (generic_val_print, val_print, val_print_string):
3472         Don't call gdb_flush.
3473         * utils.c (defaulted_query): Don't call gdb_flush.
3474         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3475         * target.c (target_announce_detach): Don't call gdb_flush.
3476         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3477         * remote.c (extended_remote_target::attach): Don't call
3478         gdb_flush.
3479         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3480         * printcmd.c (do_examine): Don't call gdb_flush.
3481         (info_display_command): Don't call gdb_flush.
3482         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3483         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3484         * memattr.c (info_mem_command): Don't call gdb_flush.
3485         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3486         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3487         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3488         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3489         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3490         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3491         (gnu_nat_target::detach): Don't call gdb_flush.
3492         * f-valprint.c (f_val_print): Don't call gdb_flush.
3493         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3494         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3495         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3496         gdb_flush.
3497         * c-valprint.c (c_val_print): Don't call gdb_flush.
3498         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3499
3500 2019-03-05  Tom Tromey  <tromey@adacore.com>
3501
3502         * varobj.c (update_dynamic_varobj_children): Update.
3503         (install_default_visualizer): Use reset, not release.
3504         * value.c (set_internalvar): Update.
3505         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3506         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3507         ATTRIBUTE_UNUSED_RESULT.
3508
3509 2019-03-05  Tom Tromey  <tromey@adacore.com>
3510
3511         * remote.c (class scoped_remote_fd) <release>: Add
3512         ATTRIBUTE_UNUSED_RESULT.
3513
3514 2019-03-05  Tom Tromey  <tromey@adacore.com>
3515
3516         * macroexp.c (struct macro_buffer) <release>: Add
3517         ATTRIBUTE_UNUSED_RESULT.
3518
3519 2019-03-05  Tom Tromey  <tromey@adacore.com>
3520
3521         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3522         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3523         ATTRIBUTE_UNUSED_RESULT.
3524
3525 2019-03-05  Tom Tromey  <tromey@adacore.com>
3526
3527         * common/scoped_fd.h (class scoped_fd) <release>: Add
3528         ATTRIBUTE_UNUSED_RESULT.
3529
3530 2019-03-05  Tom Tromey  <tromey@adacore.com>
3531
3532         * parser-defs.h (struct parser_state) <release>: Add
3533         ATTRIBUTE_UNUSED_RESULT.
3534
3535 2019-03-05  Tom Tromey  <tromey@adacore.com>
3536
3537         * utils.h (class gdb_argv) <release>: Add
3538         ATTRIBUTE_UNUSED_RESULT.
3539         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3540
3541 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3542
3543         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3544         for-loop range, to avoid compiler warnings.
3545
3546         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3547         avoid compiler warnings about unused variables.
3548
3549         * NEWS: Mention end of support for native debugging on MS-Windows
3550         before XP.
3551
3552         PR gdb/24292
3553         * common/netstuff.c:
3554         * gdbserver/gdbreplay.c
3555         * gdbserver/remote-utils.c:
3556         * ser-tcp.c:
3557         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3558         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3559         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3560         'getaddrinfo' and 'freeaddrinfo' were not available before
3561         Windows XP, and mingw.org's MinGW headers by default define
3562         _WIN32_WINNT to 0x500.
3563
3564 2019-03-01  Gary Benson <gbenson@redhat.com>
3565
3566         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3567
3568 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3569             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3570
3571         PR gdb/8527
3572         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3573         set_sigint_trap, clear_sigint_trap.
3574
3575 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3576
3577         * target.c (target_detach): Clear the regcache and the
3578         frame cache.
3579
3580 2019-02-27  Pedro Alves  <palves@redhat.com>
3581
3582         * utils.c (set_screen_size): When we cap the height/width sizes,
3583         tweak the corresponding command variable to show "unlimited":
3584
3585 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3586             Pedro Alves  <palves@redhat.com>
3587
3588         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3589         before calling rl_set_screen_size.
3590
3591 2019-02-27  Tom Tromey  <tromey@adacore.com>
3592
3593         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3594         define.
3595         * python/py-value.c: Remove Python 2.4 workaround.
3596         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3597         workaround.
3598         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3599         Python 2.4 workaround.
3600         * python/python-internal.h: Remove Python 2.4 comment.
3601         (Py_ssize_t): Don't define.
3602         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3603         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3604         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3605         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3606         * python/python.c (do_start_initialization): Remove Python 2.4
3607         workaround.
3608         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3609         (print_children): Remove Python 2.4 workaround.
3610         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3611         workaround.
3612         (CHARBUFFERPROC_NAME): Remove.
3613         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3614         Python 2.4 workaround.
3615
3616 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3617
3618         * NEWS: Note minimum Python version.
3619
3620 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3621
3622         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3623         code from these functions.  Remove corresponding ifdefs.  Use
3624         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3625         Remove gotos and target of gotos.
3626         (infpy_search_memory): Likewise.
3627
3628 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3629
3630         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3631         (hppa_gdbarch_init): Don't register deleted functions with
3632         gdbarch.
3633
3634 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3635
3636         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3637         (h8300_unwind_sp): Delete.
3638         (h8300_dummy_id): Delete.
3639         (h8300_gdbarch_init): Don't register deleted functions with
3640         gdbarch.
3641
3642 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3643
3644         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3645         (ft32_unwind_pc): Delete.
3646         (ft32_unwind_sp): Delete.
3647         (ft32_gdbarch_init): Don't register deleted functions with
3648         gdbarch.
3649
3650 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3651
3652         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3653         (frv_unwind_pc): Delete.
3654         (frv_unwind_sp): Delete.
3655         (frv_gdbarch_init): Don't register deleted functions with
3656         gdbarch.
3657
3658 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3659
3660         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3661         (riscv_unwind_pc): Delete.
3662         (riscv_unwind_sp): Delete.
3663         (riscv_gdbarch_init): Don't register deleted functions with
3664         gdbarch.
3665
3666 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3667
3668         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3669         (csky_unwind_pc): Delete.
3670         (csky_unwind_sp): Delete.
3671         (csky_gdbarch_init): Don't register deleted functions with
3672         gdbarch.
3673
3674 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3675
3676         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3677         (cris_unwind_pc): Delete.
3678         (cris_unwind_sp): Delete.
3679         (cris_gdbarch_init): Don't register deleted functions with
3680         gdbarch.
3681
3682 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3683
3684         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3685         (bfin_unwind_pc): Delete.
3686         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3687
3688 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3689
3690         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3691         (arm_unwind_pc): Delete.
3692         (arm_unwind_sp): Delete.
3693         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3694
3695 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3696
3697         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3698         (arc_unwind_pc): Delete.
3699         (arc_unwind_sp): Delete.
3700         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3701
3702 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3703
3704         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3705         (alpha_unwind_pc): Delete.
3706         (alpha_gdbarch_init): Don't register deleted functions with
3707         gdbarch.
3708
3709 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3710
3711         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3712         (aarch64_unwind_pc): Delete.
3713         (aarch64_unwind_sp): Delete.
3714         (aarch64_gdbarch_init): Don't register deleted functions with
3715         gdbarch.
3716
3717 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3718
3719         * gdbtypes.c (type_align): Don't consider static members when
3720         computing structure alignment.
3721
3722 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3723
3724         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3725         return 0 for other types.
3726         * arch-utils.c (default_type_align): Always return 0.
3727         * gdbarch.h: Regenerate.
3728         * gdbarch.sh (type_align): Extend comment.
3729         * gdbtypes.c (type_align): Add additional comments, always call
3730         gdbarch_type_align before applying the default rules.
3731         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3732         generic code will then apply a suitable default.
3733         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3734         types, return 0 for other types.
3735
3736 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3737
3738         * NEWS: Create a new section for the next release branch.
3739         Rename the section of the current branch, now that it has
3740         been cut.
3741
3742 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3743
3744         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3745         * version.in: Bump version to 8.3.50.DATE-git.
3746
3747 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3748
3749         * aix-thread.c (ptid_cmp): Remove unused variable.
3750         (get_signaled_thread): Likewise.
3751         (store_regs_user_thread): Likewise.
3752         (store_regs_kernel_thread): Likewise.
3753         (fetch_regs_kernel_thread): Remove shadowed variable.
3754
3755 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3756
3757         * features/riscv/32bit-cpu.xml: Add register numbers.
3758         * features/riscv/32bit-fpu.c: Regenerate.
3759         * features/riscv/32bit-fpu.xml: Add register numbers.
3760         * features/riscv/64bit-cpu.xml: Add register numbers.
3761         * features/riscv/64bit-fpu.c: Regenerate.
3762         * features/riscv/64bit-fpu.xml: Add register numbers.
3763
3764 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3765
3766         * NEWS: Mention two argument form of gdb.Value constructor.
3767         * python/py-value.c (convert_buffer_and_type_to_value): New
3768         function.
3769         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3770         Add support for handling an optional second argument.  Call
3771         convert_buffer_and_type_to_value as appropriate.
3772         * python/python-internal.h (Py_buffer_deleter): New struct.
3773         (Py_buffer_up): New typedef.
3774
3775 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3776
3777         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3778         instead of releasing ownership.
3779
3780 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3781
3782         * dwarf2read.c (open_and_init_dwp_file): Call
3783         elf_numsections instead of bfd_count_sections to initialize
3784         dwp_file->num_sections.
3785
3786 2019-02-25  Tom Tromey  <tromey@adacore.com>
3787
3788         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3789
3790 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3791
3792         * gcore.in: Add '--readnever' option when invoking GDB.
3793
3794 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3795
3796         * MAINTAINERS: Update my email address.
3797
3798 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3799
3800         * build-id.c (build_id_to_debug_bfd_1): New function.
3801         (build_id_to_debug_bfd): Look for separate debug file in
3802         sysroot.
3803
3804 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3805
3806         * gdbarch.sh: Update the copyright year range that is placed into
3807         generated files.
3808
3809 2019-02-22  Keith Seitz  <keiths@redhat.com>
3810
3811         PR symtab/23853
3812         * linespec.c (create_sals_line_offset): Search for the default
3813         symtab's filename instead of its fullname.
3814
3815 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3816
3817         * NEWS: Update style defaults.
3818
3819 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3820
3821         * main.c (captured_main_1): Disable styling in batch mode.
3822
3823 2019-02-20  Tom Tromey  <tom@tromey.com>
3824
3825         * symtab.c (symtab_symbol_info): Fix typos.
3826
3827 2019-02-20  Tom Tromey  <tromey@adacore.com>
3828
3829         * findcmd.c (_initialize_mem_search): Use upper case for
3830         metasyntactic variables.
3831
3832 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3833
3834         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3835         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3836
3837 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3838
3839         * top.h (source_file_name): Change to std::string.
3840         * top.c (source_file_name): Likewise.
3841         (command_line_input): Adjust.
3842         * cli/cli-script.c (script_from_file): Adjust.
3843
3844 2019-02-19  Tom Tromey  <tromey@adacore.com>
3845
3846         * ravenscar-thread.c
3847         (ravenscar_thread_target::update_thread_list): Don't call
3848         ada_build_task_list.
3849         * ada-lang.h (ada_build_task_list): Don't declare.
3850         * ada-tasks.c (struct ada_tasks_inferior_data)
3851         <task_list_valid_p>: Now bool.
3852         (read_known_tasks, ada_task_list_changed)
3853         (ada_tasks_invalidate_inferior_data): Update.
3854         (read_known_tasks_array): Return bool.
3855         (read_known_tasks_list): Likewise.
3856         (read_known_tasks): Return void.
3857         (ada_build_task_list): Now static.
3858
3859 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3860
3861         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3862         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3863
3864 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3865
3866         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3867         variant for ada_tasks_pspace_data_handle and
3868         ada_tasks_inferior_data_handle.
3869         (ada_tasks_pspace_data_cleanup): New function.
3870         (ada_tasks_inferior_data_cleanup): New function.
3871
3872 2019-02-17  Tom Tromey  <tom@tromey.com>
3873
3874         * macrotab.h (macro_source_fullname): Return a std::string.
3875         * macrotab.c (macro_include, check_for_redefinition)
3876         (macro_undef, macro_lookup_definition, foreach_macro)
3877         (foreach_macro_in_scope): Update.
3878         (macro_source_fullname): Return a std::string.
3879         * macrocmd.c (show_pp_source_pos): Update.
3880
3881 2019-02-17  Tom Tromey  <tom@tromey.com>
3882
3883         * macrocmd.c (show_pp_source_pos): Style the file names.
3884
3885 2019-02-17  Tom Tromey  <tom@tromey.com>
3886
3887         PR tui/24197:
3888         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3889
3890 2019-02-17  Tom Tromey  <tom@tromey.com>
3891
3892         * ada-lang.c (user_select_syms): Use filtered printing.
3893         * utils.c (wrap_style): New global.
3894         (desired_style): Remove.
3895         (emit_style_escape): Add stream parameter.
3896         (set_output_style, reset_terminal_style, prompt_for_continue):
3897         Update.
3898         (flush_wrap_buffer): Only flush gdb_stdout.
3899         (wrap_here): Set wrap_style.
3900         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3901         treat escape sequences as a character.  Change when wrap buffer is
3902         flushed.
3903         (fputs_styled): Do not set the output style when the default is
3904         requested.
3905         * ui-style.h (struct ui_file_style) <is_default>: New method.
3906         * source.c (print_source_lines_base): Emit escape sequences in one
3907         piece.
3908
3909 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3910
3911         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3912         integers and enumeration types.
3913
3914 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3915
3916         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3917         instead of lookup_symbol_in_language
3918         (do_exact_match): New function.
3919         (ada_get_symbol_name_matcher): Return do_exact_match when
3920         doing a verbatim match.
3921
3922 2019-02-15  Tom Tromey  <tromey@adacore.com>
3923
3924         * ravenscar-thread.c (ravenscar_thread_target::resume)
3925         (ravenscar_thread_target::wait): Special case wildcard requests.
3926
3927 2019-02-15  Tom Tromey  <tromey@adacore.com>
3928
3929         * ravenscar-thread.c (base_ptid): Remove.
3930         (struct ravenscar_thread_target) <close>: New method.
3931         <m_base_ptid>: New member.
3932         <update_inferior_ptid, active_task, task_is_currently_active,
3933         runtime_initialized>: Declare methods.
3934         <ravenscar_thread_target>: Add constructor.
3935         (ravenscar_thread_target::task_is_currently_active)
3936         (ravenscar_thread_target::update_inferior_ptid)
3937         (ravenscar_runtime_initialized): Rename.  Now methods.
3938         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3939         (ravenscar_thread_target::update_thread_list): Update.
3940         (ravenscar_thread_target::active_task): Now method.
3941         (ravenscar_thread_target::store_registers)
3942         (ravenscar_thread_target::prepare_to_store)
3943         (ravenscar_thread_target::prepare_to_store)
3944         (ravenscar_thread_target::mourn_inferior): Update.
3945         (ravenscar_inferior_created): Use "new" to create target.
3946         (ravenscar_thread_target::get_ada_task_ptid): Update.
3947         (_initialize_ravenscar): Don't initialize base_ptid.
3948         (ravenscar_ops): Remove global.
3949
3950 2019-02-15  Tom Tromey  <tromey@adacore.com>
3951
3952         * target.h (push_target): Declare new overload.
3953         * target.c (push_target): New overload, taking an rvalue reference.
3954         * remote.c (remote_target::open_1): Use push_target overload.
3955         * corelow.c (core_target_open): Use push_target overload.
3956
3957 2019-02-15  Tom Tromey  <tromey@adacore.com>
3958
3959         * ravenscar-thread.c (is_ravenscar_task)
3960         (ravenscar_task_is_currently_active): Return bool.
3961         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3962         (_initialize_ravenscar): Remove "(void)".
3963         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3964         Return bool.
3965
3966 2019-02-15  Tom Tromey  <tromey@adacore.com>
3967
3968         * ravenscar-thread.c (ravenscar_runtime_initializer)
3969         (has_ravenscar_runtime, get_running_thread_id)
3970         (ravenscar_thread_target::resume): Fix indentation.
3971
3972 2019-02-15  Tom Tromey  <tromey@adacore.com>
3973
3974         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3975         from ravenscar_arch_ops.
3976         (sparc_ravenscar_ops::fetch_registers)
3977         (sparc_ravenscar_ops::store_registers): Now methods.
3978         (sparc_ravenscar_prepare_to_store): Remove.
3979         (sparc_ravenscar_ops): Redefine.
3980         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3981         methods and destructor.  Remove members.
3982         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3983         (ravenscar_thread_target::store_registers)
3984         (ravenscar_thread_target::prepare_to_store): Update.
3985         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3986         Remove.
3987         (struct ppc_ravenscar_powerpc_ops): Derive from
3988         ravenscar_arch_ops.
3989         (ppc_ravenscar_powerpc_ops::fetch_registers)
3990         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3991         (ppc_ravenscar_powerpc_ops): Redefine.
3992         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3993         (ppc_ravenscar_e500_ops::fetch_registers)
3994         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3995         (ppc_ravenscar_e500_ops): Redefine.
3996         * aarch64-ravenscar-thread.c
3997         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3998         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3999         (aarch64_ravenscar_fetch_registers)
4000         (aarch64_ravenscar_store_registers): Now methods.
4001         (aarch64_ravenscar_ops): Redefine.
4002
4003 2019-02-15  Tom Tromey  <tromey@adacore.com>
4004
4005         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4006         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4007         (ravenscar_thread_target::stopped_by_watchpoint)
4008         (ravenscar_thread_target::stopped_data_address)
4009         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4010
4011 2019-02-15  Tom Tromey  <tromey@adacore.com>
4012
4013         * ravenscar-thread.c: Fix some typos.
4014
4015 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4016             Tom Tromey  <tromey@adacore.com>
4017
4018         * ada-lang.c (ada_exception_sal): Change addr_string to a
4019         std::string.
4020         (create_ada_exception_catchpoint): Update.
4021
4022 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4023             Tom Tromey  <tromey@adacore.com>
4024
4025         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4026         (bp_location_ops): Remove.
4027         (base_breakpoint_allocate_location): Update.
4028         (free_bp_location): Update.
4029         * ada-lang.c (class ada_catchpoint_location)
4030         <ada_catchpoint_location>: Remove ops parameter.
4031         (ada_catchpoint_location_dtor): Remove.
4032         (ada_catchpoint_location_ops): Remove.
4033         (allocate_location_exception): Update.
4034         * breakpoint.h (struct bp_location_ops): Remove.
4035         (class bp_location) <bp_location>: Remove bp_location_ops
4036         parameter.
4037         <~bp_location>: Add destructor.
4038         <ops>: Remove.
4039
4040 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4041             Pedro Alves  <palves@redhat.com>
4042
4043         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4044         'PATH_MAX'.
4045
4046 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4047             Samuel Thibault  <samuel.thibault@gnu.org>
4048             Thomas Schwinge  <thomas@codesourcery.com>
4049
4050         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4051         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4052
4053 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4054
4055         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4056         (check_empty): Use "const char *".
4057
4058         * gnu-nat.c (gnu_nat_target::detach): Instead of
4059         'detach_inferior (pid)' call
4060         'detach_inferior (find_inferior_pid (pid))'.
4061
4062         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4063         'nat/fork-inferior.o'.
4064         * gnu-nat.c: #include "nat/fork-inferior.h".
4065
4066         * gnu-nat.c (gnu_nat_target::detach): Instead of
4067         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4068         * gnu-nat.h: #include "inf-child.h".
4069         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4070         'i386_gnu_nat_target::fetch_registers'.
4071         (gnu_store_registers): Rename/move to
4072         'i386_gnu_nat_target::store_registers'.
4073
4074         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4075         * gnu-nat.h (mach_thread_info): New function.
4076         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4077
4078         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4079
4080 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4081
4082         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4083
4084 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4085
4086         * windows-nat.c (windows_add_thread): Add new parameter
4087         "main_thread_p" with default value set to false.  Update
4088         function documentation as well as all callers.
4089         (windows_delete_thread): Likewise.
4090         (fake_create_process): Update call to windows_add_thread.
4091         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4092         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4093         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4094         call to windows_delete_thread.
4095
4096 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4097
4098         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4099
4100 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4101
4102         * symfile.c (find_separate_debug_file): Use canonical path of
4103         sysroot with child_path instead of gdb_sysroot if it is valid.
4104
4105 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4106
4107         * symfile.c (find_separate_debug_file): Use child_path to
4108         determine if an object file is under a sysroot.
4109
4110 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4111
4112         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4113         unittests/child-path-selftests.c.
4114         * common/pathstuff.c (child_path): New function.
4115         * common/pathstuff.h (child_path): New prototype.
4116         * unittests/child-path-selftests.c: New file.
4117
4118 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4119
4120         * symfile.c (find_separate_debug_file): Look for separate debug
4121         files in debug directories under the sysroot.
4122
4123 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4124
4125         * symtab.h (struct minimal_symbol data_p): New const method.
4126         (struct minimal_symbol text_p): Likewise.
4127         * symtab.c (output_source_filename): Use file name style
4128         to print file name.
4129         (print_symbol_info): Likewise.
4130         (print_msymbol_info): Use address style to print addresses.
4131         Use function name style to print executable text symbols.
4132         (expand_symtab_containing_pc): Use data_p.
4133         (find_pc_sect_compunit_symtab): Likewise.
4134
4135 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4136
4137         * breakpoint.c (describe_other_breakpoints): Use address style
4138         to print addresses.
4139         (say_where): Likewise.
4140
4141 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4142
4143         * ada-typeprint.c (print_func_type): Print function name
4144         style to print function name.
4145         * c-typeprint.c (c_print_type_1): Likewise.
4146
4147 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4148
4149         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4150         for execve.
4151
4152 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4153
4154         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4155         type_stack.
4156
4157 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4158
4159         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4160         TYPE_CODE_REF types.
4161
4162 2019-02-08  Jim Wilson  <jimw@sifive.com>
4163
4164         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4165         (riscv_linux_fregset): New.
4166         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4167
4168 2019-02-07  Tom Tromey  <tom@tromey.com>
4169
4170         * thread.c (thread_cancel_execution_command): Update.
4171         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4172         methods.
4173         (struct thread_fsm_ops): Remove.
4174         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4175         (thread_fsm_should_stop, thread_fsm_return_value)
4176         (thread_fsm_set_finished, thread_fsm_finished_p)
4177         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4178         Don't declare.
4179         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4180         * infrun.c (clear_proceed_status_thread)
4181         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4182         (print_stop_event): Update.
4183         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4184         Add constructor.
4185         (step_command_fsm_ops): Remove.
4186         (new_step_command_fsm): Remove.
4187         (step_1): Update.
4188         (step_command_fsm::should_stop): Rename from
4189         step_command_fsm_should_stop.
4190         (step_command_fsm::clean_up): Rename from
4191         step_command_fsm_clean_up.
4192         (step_command_fsm::do_async_reply_reason): Rename from
4193         step_command_fsm_async_reply_reason.
4194         (struct until_next_fsm): Inherit from thread_fsm.  Add
4195         constructor.
4196         (until_next_fsm_ops): Remove.
4197         (new_until_next_fsm): Remove.
4198         (until_next_fsm::should_stop): Rename from
4199         until_next_fsm_should_stop.
4200         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4201         (until_next_fsm::do_async_reply_reason): Rename from
4202         until_next_fsm_async_reply_reason.
4203         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4204         constructor.  Change type of breakpoint.
4205         (finish_command_fsm_ops): Remove.
4206         (new_finish_command_fsm): Remove.
4207         (finish_command_fsm::should_stop): Rename from
4208         finish_command_fsm_should_stop.
4209         (finish_command_fsm::clean_up): Rename from
4210         finish_command_fsm_clean_up.
4211         (finish_command_fsm::return_value): Rename from
4212         finish_command_fsm_return_value.
4213         (finish_command_fsm::do_async_reply_reason): Rename from
4214         finish_command_fsm_async_reply_reason.
4215         (finish_command): Update.
4216         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4217         Add constructor.
4218         (call_thread_fsm_ops): Remove.
4219         (call_thread_fsm::call_thread_fsm): Rename from
4220         new_call_thread_fsm.
4221         (call_thread_fsm::should_stop): Rename from
4222         call_thread_fsm_should_stop.
4223         (call_thread_fsm::should_notify_stop): Rename from
4224         call_thread_fsm_should_notify_stop.
4225         (run_inferior_call, call_function_by_hand_dummy): Update.
4226         * cli/cli-interp.c (should_print_stop_to_console): Update.
4227         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4228         Add constructor.  Change type of location_breakpoint,
4229         caller_breakpoint.
4230         (until_break_fsm_ops): Remove.
4231         (new_until_break_fsm): Remove.
4232         (until_break_fsm::should_stop): Rename from
4233         until_break_fsm_should_stop.
4234         (until_break_fsm::clean_up): Rename from
4235         until_break_fsm_clean_up.
4236         (until_break_fsm::do_async_reply_reason): Rename from
4237         until_break_fsm_async_reply_reason.
4238         (until_break_command): Update.
4239         * thread-fsm.c: Remove.
4240         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4241
4242 2019-02-07  Tom Tromey  <tom@tromey.com>
4243
4244         * yy-remap.h: Add include guard.
4245         * xtensa-tdep.h: Add include guard.
4246         * xcoffread.h: Rename include guard.
4247         * varobj-iter.h: Add include guard.
4248         * tui/tui.h: Rename include guard.
4249         * tui/tui-winsource.h: Rename include guard.
4250         * tui/tui-wingeneral.h: Rename include guard.
4251         * tui/tui-windata.h: Rename include guard.
4252         * tui/tui-win.h: Rename include guard.
4253         * tui/tui-stack.h: Rename include guard.
4254         * tui/tui-source.h: Rename include guard.
4255         * tui/tui-regs.h: Rename include guard.
4256         * tui/tui-out.h: Rename include guard.
4257         * tui/tui-layout.h: Rename include guard.
4258         * tui/tui-io.h: Rename include guard.
4259         * tui/tui-hooks.h: Rename include guard.
4260         * tui/tui-file.h: Rename include guard.
4261         * tui/tui-disasm.h: Rename include guard.
4262         * tui/tui-data.h: Rename include guard.
4263         * tui/tui-command.h: Rename include guard.
4264         * tic6x-tdep.h: Add include guard.
4265         * target/waitstatus.h: Rename include guard.
4266         * target/wait.h: Rename include guard.
4267         * target/target.h: Rename include guard.
4268         * target/resume.h: Rename include guard.
4269         * target-float.h: Rename include guard.
4270         * stabsread.h: Add include guard.
4271         * rs6000-tdep.h: Add include guard.
4272         * riscv-fbsd-tdep.h: Add include guard.
4273         * regformats/regdef.h: Rename include guard.
4274         * record.h: Rename include guard.
4275         * python/python.h: Rename include guard.
4276         * python/python-internal.h: Rename include guard.
4277         * python/py-stopevent.h: Rename include guard.
4278         * python/py-ref.h: Rename include guard.
4279         * python/py-record.h: Rename include guard.
4280         * python/py-record-full.h: Rename include guard.
4281         * python/py-record-btrace.h: Rename include guard.
4282         * python/py-instruction.h: Rename include guard.
4283         * python/py-events.h: Rename include guard.
4284         * python/py-event.h: Rename include guard.
4285         * procfs.h: Add include guard.
4286         * proc-utils.h: Add include guard.
4287         * p-lang.h: Add include guard.
4288         * or1k-tdep.h: Rename include guard.
4289         * observable.h: Rename include guard.
4290         * nto-tdep.h: Rename include guard.
4291         * nat/x86-linux.h: Rename include guard.
4292         * nat/x86-linux-dregs.h: Rename include guard.
4293         * nat/x86-gcc-cpuid.h: Add include guard.
4294         * nat/x86-dregs.h: Rename include guard.
4295         * nat/x86-cpuid.h: Rename include guard.
4296         * nat/ppc-linux.h: Rename include guard.
4297         * nat/mips-linux-watch.h: Rename include guard.
4298         * nat/linux-waitpid.h: Rename include guard.
4299         * nat/linux-ptrace.h: Rename include guard.
4300         * nat/linux-procfs.h: Rename include guard.
4301         * nat/linux-osdata.h: Rename include guard.
4302         * nat/linux-nat.h: Rename include guard.
4303         * nat/linux-namespaces.h: Rename include guard.
4304         * nat/linux-btrace.h: Rename include guard.
4305         * nat/glibc_thread_db.h: Rename include guard.
4306         * nat/gdb_thread_db.h: Rename include guard.
4307         * nat/gdb_ptrace.h: Rename include guard.
4308         * nat/fork-inferior.h: Rename include guard.
4309         * nat/amd64-linux-siginfo.h: Rename include guard.
4310         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4311         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4312         * nat/aarch64-linux.h: Rename include guard.
4313         * nat/aarch64-linux-hw-point.h: Rename include guard.
4314         * mn10300-tdep.h: Add include guard.
4315         * mips-linux-tdep.h: Add include guard.
4316         * mi/mi-parse.h: Rename include guard.
4317         * mi/mi-out.h: Rename include guard.
4318         * mi/mi-main.h: Rename include guard.
4319         * mi/mi-interp.h: Rename include guard.
4320         * mi/mi-getopt.h: Rename include guard.
4321         * mi/mi-console.h: Rename include guard.
4322         * mi/mi-common.h: Rename include guard.
4323         * mi/mi-cmds.h: Rename include guard.
4324         * mi/mi-cmd-break.h: Rename include guard.
4325         * m2-lang.h: Add include guard.
4326         * location.h: Rename include guard.
4327         * linux-record.h: Rename include guard.
4328         * linux-nat.h: Add include guard.
4329         * linux-fork.h: Add include guard.
4330         * i386-darwin-tdep.h: Rename include guard.
4331         * hppa-linux-offsets.h: Add include guard.
4332         * guile/guile.h: Rename include guard.
4333         * guile/guile-internal.h: Rename include guard.
4334         * gnu-nat.h: Rename include guard.
4335         * gdb-stabs.h: Rename include guard.
4336         * frv-tdep.h: Add include guard.
4337         * f-lang.h: Add include guard.
4338         * event-loop.h: Add include guard.
4339         * darwin-nat.h: Rename include guard.
4340         * cp-abi.h: Rename include guard.
4341         * config/sparc/nm-sol2.h: Rename include guard.
4342         * config/nm-nto.h: Rename include guard.
4343         * config/nm-linux.h: Add include guard.
4344         * config/i386/nm-i386gnu.h: Rename include guard.
4345         * config/djgpp/nl_types.h: Rename include guard.
4346         * config/djgpp/langinfo.h: Rename include guard.
4347         * compile/gcc-cp-plugin.h: Add include guard.
4348         * compile/gcc-c-plugin.h: Add include guard.
4349         * compile/compile.h: Rename include guard.
4350         * compile/compile-object-run.h: Rename include guard.
4351         * compile/compile-object-load.h: Rename include guard.
4352         * compile/compile-internal.h: Rename include guard.
4353         * compile/compile-cplus.h: Rename include guard.
4354         * compile/compile-c.h: Rename include guard.
4355         * common/xml-utils.h: Rename include guard.
4356         * common/x86-xstate.h: Rename include guard.
4357         * common/version.h: Rename include guard.
4358         * common/vec.h: Rename include guard.
4359         * common/tdesc.h: Rename include guard.
4360         * common/selftest.h: Rename include guard.
4361         * common/scoped_restore.h: Rename include guard.
4362         * common/scoped_mmap.h: Rename include guard.
4363         * common/scoped_fd.h: Rename include guard.
4364         * common/safe-iterator.h: Rename include guard.
4365         * common/run-time-clock.h: Rename include guard.
4366         * common/refcounted-object.h: Rename include guard.
4367         * common/queue.h: Rename include guard.
4368         * common/ptid.h: Rename include guard.
4369         * common/print-utils.h: Rename include guard.
4370         * common/preprocessor.h: Rename include guard.
4371         * common/pathstuff.h: Rename include guard.
4372         * common/observable.h: Rename include guard.
4373         * common/netstuff.h: Rename include guard.
4374         * common/job-control.h: Rename include guard.
4375         * common/host-defs.h: Rename include guard.
4376         * common/gdb_wait.h: Rename include guard.
4377         * common/gdb_vecs.h: Rename include guard.
4378         * common/gdb_unlinker.h: Rename include guard.
4379         * common/gdb_unique_ptr.h: Rename include guard.
4380         * common/gdb_tilde_expand.h: Rename include guard.
4381         * common/gdb_sys_time.h: Rename include guard.
4382         * common/gdb_string_view.h: Rename include guard.
4383         * common/gdb_splay_tree.h: Rename include guard.
4384         * common/gdb_setjmp.h: Rename include guard.
4385         * common/gdb_ref_ptr.h: Rename include guard.
4386         * common/gdb_optional.h: Rename include guard.
4387         * common/gdb_locale.h: Rename include guard.
4388         * common/gdb_assert.h: Rename include guard.
4389         * common/filtered-iterator.h: Rename include guard.
4390         * common/filestuff.h: Rename include guard.
4391         * common/fileio.h: Rename include guard.
4392         * common/environ.h: Rename include guard.
4393         * common/common-utils.h: Rename include guard.
4394         * common/common-types.h: Rename include guard.
4395         * common/common-regcache.h: Rename include guard.
4396         * common/common-inferior.h: Rename include guard.
4397         * common/common-gdbthread.h: Rename include guard.
4398         * common/common-exceptions.h: Rename include guard.
4399         * common/common-defs.h: Rename include guard.
4400         * common/common-debug.h: Rename include guard.
4401         * common/cleanups.h: Rename include guard.
4402         * common/buffer.h: Rename include guard.
4403         * common/btrace-common.h: Rename include guard.
4404         * common/break-common.h: Rename include guard.
4405         * cli/cli-utils.h: Rename include guard.
4406         * cli/cli-style.h: Rename include guard.
4407         * cli/cli-setshow.h: Rename include guard.
4408         * cli/cli-script.h: Rename include guard.
4409         * cli/cli-interp.h: Rename include guard.
4410         * cli/cli-decode.h: Rename include guard.
4411         * cli/cli-cmds.h: Rename include guard.
4412         * charset-list.h: Add include guard.
4413         * buildsym-legacy.h: Rename include guard.
4414         * bfin-tdep.h: Add include guard.
4415         * ax.h: Rename include guard.
4416         * arm-linux-tdep.h: Add include guard.
4417         * arm-fbsd-tdep.h: Add include guard.
4418         * arch/xtensa.h: Rename include guard.
4419         * arch/tic6x.h: Add include guard.
4420         * arch/i386.h: Add include guard.
4421         * arch/arm.h: Rename include guard.
4422         * arch/arm-linux.h: Rename include guard.
4423         * arch/arm-get-next-pcs.h: Rename include guard.
4424         * arch/amd64.h: Add include guard.
4425         * arch/aarch64-insn.h: Rename include guard.
4426         * arch-utils.h: Rename include guard.
4427         * annotate.h: Add include guard.
4428         * amd64-darwin-tdep.h: Rename include guard.
4429         * aarch64-linux-tdep.h: Add include guard.
4430         * aarch64-fbsd-tdep.h: Add include guard.
4431         * aarch32-linux-nat.h: Add include guard.
4432
4433 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4434
4435         * macrotab.c (macro_define_internal): New function that
4436         factorizes macro_define_object_internal and macro_define_function
4437         code.
4438         (macro_define_object_internal): Use macro_define_internal.
4439         (macro_define_function): Likewise.
4440
4441 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4442
4443         * macrocmd.c (extract_identifier): Return
4444         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4445         callers.
4446
4447 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4448
4449         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4450
4451 2019-02-05  Tom Tromey  <tom@tromey.com>
4452
4453         * target.c (target_stack::unpush): Move assertion earlier.
4454
4455 2019-01-30  Tom Tromey  <tom@tromey.com>
4456
4457         PR python/23615:
4458         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4459         (gdbpy_parse_and_eval): Likewise.
4460         * python/python-internal.h (gdbpy_allow_threads): New class.
4461
4462 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4463
4464         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4465         (aarch64_fbsd_fpregmap): Move earlier.
4466         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4467         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4468         instead of individual calls to trad_frame_set_reg_addr.
4469         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4470         earlier.
4471         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4472         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4473         instead of individual calls to trad_frame_set_reg_addr.
4474
4475 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4476
4477         * CONTRIBUTE: Replace contribution list with wiki link.
4478
4479 2019-01-25  Tom Tromey  <tom@tromey.com>
4480
4481         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4482
4483 2019-01-25  Tom Tromey  <tom@tromey.com>
4484
4485         * xtensa-linux-nat.c: Fix common/ includes.
4486         * xml-support.h: Fix common/ includes.
4487         * xml-support.c: Fix common/ includes.
4488         * x86-linux-nat.c: Fix common/ includes.
4489         * windows-nat.c: Fix common/ includes.
4490         * varobj.h: Fix common/ includes.
4491         * varobj.c: Fix common/ includes.
4492         * value.c: Fix common/ includes.
4493         * valops.c: Fix common/ includes.
4494         * utils.c: Fix common/ includes.
4495         * unittests/xml-utils-selftests.c: Fix common/ includes.
4496         * unittests/utils-selftests.c: Fix common/ includes.
4497         * unittests/unpack-selftests.c: Fix common/ includes.
4498         * unittests/tracepoint-selftests.c: Fix common/ includes.
4499         * unittests/style-selftests.c: Fix common/ includes.
4500         * unittests/string_view-selftests.c: Fix common/ includes.
4501         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4502         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4503         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4504         * unittests/rsp-low-selftests.c: Fix common/ includes.
4505         * unittests/parse-connection-spec-selftests.c: Fix common/
4506         includes.
4507         * unittests/optional-selftests.c: Fix common/ includes.
4508         * unittests/offset-type-selftests.c: Fix common/ includes.
4509         * unittests/observable-selftests.c: Fix common/ includes.
4510         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4511         * unittests/memrange-selftests.c: Fix common/ includes.
4512         * unittests/memory-map-selftests.c: Fix common/ includes.
4513         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4514         * unittests/function-view-selftests.c: Fix common/ includes.
4515         * unittests/environ-selftests.c: Fix common/ includes.
4516         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4517         * unittests/common-utils-selftests.c: Fix common/ includes.
4518         * unittests/cli-utils-selftests.c: Fix common/ includes.
4519         * unittests/array-view-selftests.c: Fix common/ includes.
4520         * ui-file.c: Fix common/ includes.
4521         * tui/tui-io.c: Fix common/ includes.
4522         * tracepoint.h: Fix common/ includes.
4523         * tracepoint.c: Fix common/ includes.
4524         * tracefile-tfile.c: Fix common/ includes.
4525         * top.h: Fix common/ includes.
4526         * top.c: Fix common/ includes.
4527         * thread.c: Fix common/ includes.
4528         * target/waitstatus.h: Fix common/ includes.
4529         * target/waitstatus.c: Fix common/ includes.
4530         * target.h: Fix common/ includes.
4531         * target.c: Fix common/ includes.
4532         * target-memory.c: Fix common/ includes.
4533         * target-descriptions.c: Fix common/ includes.
4534         * symtab.h: Fix common/ includes.
4535         * symfile.c: Fix common/ includes.
4536         * stap-probe.c: Fix common/ includes.
4537         * spu-linux-nat.c: Fix common/ includes.
4538         * sparc-nat.c: Fix common/ includes.
4539         * source.c: Fix common/ includes.
4540         * solib.c: Fix common/ includes.
4541         * solib-target.c: Fix common/ includes.
4542         * ser-unix.c: Fix common/ includes.
4543         * ser-tcp.c: Fix common/ includes.
4544         * ser-pipe.c: Fix common/ includes.
4545         * ser-base.c: Fix common/ includes.
4546         * selftest-arch.c: Fix common/ includes.
4547         * s12z-tdep.c: Fix common/ includes.
4548         * rust-exp.y: Fix common/ includes.
4549         * rs6000-aix-tdep.c: Fix common/ includes.
4550         * riscv-tdep.c: Fix common/ includes.
4551         * remote.c: Fix common/ includes.
4552         * remote-notif.h: Fix common/ includes.
4553         * remote-fileio.h: Fix common/ includes.
4554         * remote-fileio.c: Fix common/ includes.
4555         * regcache.h: Fix common/ includes.
4556         * regcache.c: Fix common/ includes.
4557         * record-btrace.c: Fix common/ includes.
4558         * python/python.c: Fix common/ includes.
4559         * python/py-type.c: Fix common/ includes.
4560         * python/py-inferior.c: Fix common/ includes.
4561         * progspace.h: Fix common/ includes.
4562         * producer.c: Fix common/ includes.
4563         * procfs.c: Fix common/ includes.
4564         * proc-api.c: Fix common/ includes.
4565         * printcmd.c: Fix common/ includes.
4566         * ppc-linux-nat.c: Fix common/ includes.
4567         * parser-defs.h: Fix common/ includes.
4568         * osdata.c: Fix common/ includes.
4569         * obsd-nat.c: Fix common/ includes.
4570         * nat/x86-linux.c: Fix common/ includes.
4571         * nat/x86-linux-dregs.c: Fix common/ includes.
4572         * nat/x86-dregs.h: Fix common/ includes.
4573         * nat/x86-dregs.c: Fix common/ includes.
4574         * nat/ppc-linux.c: Fix common/ includes.
4575         * nat/mips-linux-watch.h: Fix common/ includes.
4576         * nat/mips-linux-watch.c: Fix common/ includes.
4577         * nat/linux-waitpid.c: Fix common/ includes.
4578         * nat/linux-ptrace.h: Fix common/ includes.
4579         * nat/linux-ptrace.c: Fix common/ includes.
4580         * nat/linux-procfs.c: Fix common/ includes.
4581         * nat/linux-personality.c: Fix common/ includes.
4582         * nat/linux-osdata.c: Fix common/ includes.
4583         * nat/linux-namespaces.c: Fix common/ includes.
4584         * nat/linux-btrace.h: Fix common/ includes.
4585         * nat/linux-btrace.c: Fix common/ includes.
4586         * nat/fork-inferior.c: Fix common/ includes.
4587         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4588         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4589         * nat/aarch64-linux.c: Fix common/ includes.
4590         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4591         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4592         * namespace.h: Fix common/ includes.
4593         * mips-linux-tdep.c: Fix common/ includes.
4594         * minsyms.c: Fix common/ includes.
4595         * mi/mi-parse.h: Fix common/ includes.
4596         * mi/mi-main.c: Fix common/ includes.
4597         * mi/mi-cmd-env.c: Fix common/ includes.
4598         * memrange.h: Fix common/ includes.
4599         * memattr.c: Fix common/ includes.
4600         * maint.h: Fix common/ includes.
4601         * maint.c: Fix common/ includes.
4602         * main.c: Fix common/ includes.
4603         * machoread.c: Fix common/ includes.
4604         * location.c: Fix common/ includes.
4605         * linux-thread-db.c: Fix common/ includes.
4606         * linux-nat.c: Fix common/ includes.
4607         * linux-fork.c: Fix common/ includes.
4608         * inline-frame.c: Fix common/ includes.
4609         * infrun.c: Fix common/ includes.
4610         * inflow.c: Fix common/ includes.
4611         * inferior.h: Fix common/ includes.
4612         * inferior.c: Fix common/ includes.
4613         * infcmd.c: Fix common/ includes.
4614         * inf-ptrace.c: Fix common/ includes.
4615         * inf-child.c: Fix common/ includes.
4616         * ia64-linux-nat.c: Fix common/ includes.
4617         * i387-tdep.c: Fix common/ includes.
4618         * i386-tdep.c: Fix common/ includes.
4619         * i386-linux-tdep.c: Fix common/ includes.
4620         * i386-linux-nat.c: Fix common/ includes.
4621         * i386-go32-tdep.c: Fix common/ includes.
4622         * i386-fbsd-tdep.c: Fix common/ includes.
4623         * i386-fbsd-nat.c: Fix common/ includes.
4624         * guile/scm-type.c: Fix common/ includes.
4625         * guile/guile.c: Fix common/ includes.
4626         * go32-nat.c: Fix common/ includes.
4627         * gnu-nat.c: Fix common/ includes.
4628         * gdbthread.h: Fix common/ includes.
4629         * gdbarch-selftests.c: Fix common/ includes.
4630         * gdb_usleep.c: Fix common/ includes.
4631         * gdb_select.h: Fix common/ includes.
4632         * gdb_bfd.c: Fix common/ includes.
4633         * gcore.c: Fix common/ includes.
4634         * fork-child.c: Fix common/ includes.
4635         * findvar.c: Fix common/ includes.
4636         * fbsd-nat.c: Fix common/ includes.
4637         * event-top.c: Fix common/ includes.
4638         * event-loop.c: Fix common/ includes.
4639         * dwarf2read.c: Fix common/ includes.
4640         * dwarf2loc.c: Fix common/ includes.
4641         * dwarf2-frame.c: Fix common/ includes.
4642         * dwarf-index-cache.c: Fix common/ includes.
4643         * dtrace-probe.c: Fix common/ includes.
4644         * disasm-selftests.c: Fix common/ includes.
4645         * defs.h: Fix common/ includes.
4646         * csky-tdep.c: Fix common/ includes.
4647         * cp-valprint.c: Fix common/ includes.
4648         * cp-support.h: Fix common/ includes.
4649         * cp-support.c: Fix common/ includes.
4650         * corelow.c: Fix common/ includes.
4651         * completer.h: Fix common/ includes.
4652         * completer.c: Fix common/ includes.
4653         * compile/compile.c: Fix common/ includes.
4654         * compile/compile-loc2c.c: Fix common/ includes.
4655         * compile/compile-cplus-types.c: Fix common/ includes.
4656         * compile/compile-cplus-symbols.c: Fix common/ includes.
4657         * command.h: Fix common/ includes.
4658         * cli/cli-dump.c: Fix common/ includes.
4659         * cli/cli-cmds.c: Fix common/ includes.
4660         * charset.c: Fix common/ includes.
4661         * build-id.c: Fix common/ includes.
4662         * btrace.h: Fix common/ includes.
4663         * btrace.c: Fix common/ includes.
4664         * breakpoint.h: Fix common/ includes.
4665         * breakpoint.c: Fix common/ includes.
4666         * ax.h:
4667         (enum agent_op): Fix common/ includes.
4668         * ax-general.c (struct aop_map): Fix common/ includes.
4669         * ax-gdb.c: Fix common/ includes.
4670         * auxv.c: Fix common/ includes.
4671         * auto-load.c: Fix common/ includes.
4672         * arm-tdep.c: Fix common/ includes.
4673         * arch/riscv.c: Fix common/ includes.
4674         * arch/ppc-linux-common.c: Fix common/ includes.
4675         * arch/i386.c: Fix common/ includes.
4676         * arch/arm.c: Fix common/ includes.
4677         * arch/arm-linux.c: Fix common/ includes.
4678         * arch/arm-get-next-pcs.c: Fix common/ includes.
4679         * arch/amd64.c: Fix common/ includes.
4680         * arch/aarch64.c: Fix common/ includes.
4681         * arch/aarch64-insn.c: Fix common/ includes.
4682         * arch-utils.c: Fix common/ includes.
4683         * amd64-windows-tdep.c: Fix common/ includes.
4684         * amd64-tdep.c: Fix common/ includes.
4685         * amd64-sol2-tdep.c: Fix common/ includes.
4686         * amd64-obsd-tdep.c: Fix common/ includes.
4687         * amd64-nbsd-tdep.c: Fix common/ includes.
4688         * amd64-linux-tdep.c: Fix common/ includes.
4689         * amd64-linux-nat.c: Fix common/ includes.
4690         * amd64-fbsd-tdep.c: Fix common/ includes.
4691         * amd64-fbsd-nat.c: Fix common/ includes.
4692         * amd64-dicos-tdep.c: Fix common/ includes.
4693         * amd64-darwin-tdep.c: Fix common/ includes.
4694         * agent.c: Fix common/ includes.
4695         * ada-lang.h: Fix common/ includes.
4696         * ada-lang.c: Fix common/ includes.
4697         * aarch64-tdep.c: Fix common/ includes.
4698
4699 2019-01-25  Tom Tromey  <tom@tromey.com>
4700
4701         * common/create-version.sh: Use common/version.h.
4702
4703 2019-01-24  Pedro Alves  <palves@redhat.com>
4704
4705         * infrun.c (signal_stop, signal_print, signal_program)
4706         (signal_catch, signal_pass): Now arrays instead of pointers.
4707         (update_signals_program_target, do_target_resume)
4708         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4709         * linux-nat.c (linux_nat_target::pass_signals)
4710         (linux_nat_target::create_inferior, linux_nat_target::attach):
4711         Adjust.
4712         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4713         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4714         * procfs.c (procfs_target::pass_signals): Adjust.
4715         * record-full.c (record_full_target::resume): Adjust.
4716         * remote.c (remote_target::pass_signals)
4717         (remote_target::program_signals): Adjust.
4718         * target-debug.h (target_debug_print_signals): Now takes a
4719         gdb::array_view as parameter.  Adjust.
4720         * target.h (target_ops) <pass_signals, program_signals>: Replace
4721         pointer and length parameters with gdb::array_view.
4722         (target_pass_signals, target_program_signals): Likewise.
4723         * target-delegates.c: Regenerate.
4724
4725 2019-01-24  Pedro Alves  <palves@redhat.com>
4726
4727         * common/forward-scope-exit.h
4728         (forward_scope_exit::forward_scope_exit): Pass arguments to
4729         m_bind_function directly, instead of creating a std::bind and
4730         copying that.
4731
4732 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4733
4734         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4735         for static members.
4736         (pass_in_v_vfp_candidate): Likewise.
4737
4738 2019-01-23  Tom Tromey  <tom@tromey.com>
4739             Pedro Alves  <palves@redhat.com>
4740
4741         * regcache.c (class regcache_invalidator): Remove.
4742         (regcache::raw_write): Use make_scope_exit.
4743
4744 2019-01-23  Tom Tromey  <tom@tromey.com>
4745
4746         * ui-out.h (class ui_out_emit_type): Update comment.
4747
4748 2019-01-23  Tom Tromey  <tom@tromey.com>
4749
4750         * infrun.c (fetch_inferior_event): Update comment.
4751
4752 2019-01-23  Tom Tromey  <tom@tromey.com>
4753             Pedro Alves  <palves@redhat.com>
4754
4755         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4756         parameter.
4757         (fetch_inferior_event): Use SCOPE_EXIT.
4758
4759
4760 2019-01-23  Tom Tromey  <tom@tromey.com>
4761             Pedro Alves  <palves@redhat.com>
4762
4763         * infrun.c (disable_thread_events): Delete.
4764         (stop_all_threads): Use SCOPE_EXIT.
4765
4766 2019-01-23  Tom Tromey  <tom@tromey.com>
4767             Pedro Alves  <palves@redhat.com>
4768
4769         * symfile.c: Include forward-scope-exit.h.
4770         (clear_symtab_users_cleanup): Replace forward declaration with
4771         a FORWARD_SCOPE_EXIT.
4772         (syms_from_objfile_1): Use the forward_scope_exit and
4773         gdb::optional instead of cleanup_function.
4774         (reread_symbols): Use the forward_scope_exit instead of
4775         cleanup_function.
4776         (clear_symtab_users_cleanup): Remove function.
4777
4778 2019-01-23  Tom Tromey  <tom@tromey.com>
4779             Pedro Alves  <palves@redhat.com>
4780
4781         * linux-nat.c: Include scope-exit.h.
4782         (cleanup_target_stop): Remove.
4783         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4784         SCOPE_EXIT.
4785
4786 2019-01-23  Tom Tromey  <tom@tromey.com>
4787             Pedro Alves  <palves@redhat.com>
4788
4789         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4790         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4791
4792 2019-01-23  Tom Tromey  <tom@tromey.com>
4793             Andrew Burgess  <andrew.burgess@embecosm.com>
4794             Pedro Alves  <palves@redhat.com>
4795
4796         * infrun.c (fetch_inferior_event): Use scope_exit.
4797         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4798         * top.c (execute_command): Use scope_exit.
4799         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4800         * utils.c (do_bpstat_clear_actions_cleanup)
4801         (make_bpstat_clear_actions_cleanup): Remove.
4802
4803 2019-01-23  Tom Tromey  <tom@tromey.com>
4804             Pedro Alves  <palves@redhat.com>
4805
4806         * infrun.c: Include "common/scope-exit.h"
4807         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4808         (wait_for_inferior): Use SCOPE_EXIT.
4809         (fetch_inferior_event): Use scope_exit.
4810
4811 2019-01-23  Tom Tromey  <tom@tromey.com>
4812             Pedro Alves  <palves@redhat.com>
4813
4814         * breakpoint.c (create_breakpoint): Remove cleanup.
4815
4816 2019-01-23  Tom Tromey  <tom@tromey.com>
4817             Andrew Burgess  <andrew.burgess@embecosm.com>
4818             Pedro Alves  <palves@redhat.com>
4819
4820 2019-01-23  Pedro Alves  <palves@redhat.com>
4821
4822         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4823
4824 2019-01-23  Pedro Alves  <palves@redhat.com>
4825             Andrew Burgess  <andrew.burgess@embecosm.com>
4826
4827         * gdbthread.h: Include "common/forward-scope-exit.h".
4828         (scoped_finish_thread_state): Redefine custom class in terms of
4829         forward_scope_exit.
4830
4831 2019-01-23  Pedro Alves  <palves@redhat.com>
4832             Andrew Burgess  <andrew.burgess@embecosm.com>
4833
4834         * common/forward-scope-exit.h: New file.
4835
4836 2019-01-23  Pedro Alves  <palves@redhat.com>
4837             Andrew Burgess  <andrew.burgess@embecosm.com>
4838             Tom Tromey  <tom@tromey.com>
4839
4840         * common/scope-exit.h: New file.
4841
4842 2019-01-23  Pedro Alves  <palves@redhat.com>
4843
4844         * common/preprocessor.h (ESC): Rename to ...
4845         (ESC_PARENS): ... this.
4846         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4847         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4848
4849 2019-01-23  Tom Tromey  <tom@tromey.com>
4850
4851         * language.h (class scoped_switch_to_sym_language_if_auto):
4852         Initialize m_lang in both cases.
4853
4854 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4855
4856         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4857         with XCNEW.
4858
4859 2019-01-22  Tom Tromey  <tom@tromey.com>
4860
4861         * corelow.c: Do not include sys/file.h.
4862
4863 2019-01-22  Tom Tromey  <tom@tromey.com>
4864
4865         * tui/tui-wingeneral.h: Include gdb_curses.h.
4866
4867 2019-01-22  Tom Tromey  <tom@tromey.com>
4868
4869         * source-cache.h (class source_cache) <get_source_lines,
4870         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4871
4872 2019-01-22  Tom Tromey  <tom@tromey.com>
4873
4874         * remote-fileio.h (struct remote_target): Declare.
4875
4876 2019-01-22  Tom Tromey  <tom@tromey.com>
4877
4878         * python/py-arch.c: Do not include py-ref.h.
4879         * python/py-bpevent.c: Do not include py-ref.h.
4880         * python/py-cmd.c: Do not include py-ref.h.
4881         * python/py-continueevent.c: Do not include py-ref.h.
4882         * python/py-event.h: Do not include py-ref.h.
4883         * python/py-evtregistry.c: Do not include py-ref.h.
4884         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4885         * python/py-frame.c: Do not include py-ref.h.
4886         * python/py-framefilter.c: Do not include py-ref.h.
4887         * python/py-function.c: Do not include py-ref.h.
4888         * python/py-infevents.c: Do not include py-ref.h.
4889         * python/py-linetable.c: Do not include py-ref.h.
4890         * python/py-objfile.c: Do not include py-ref.h.
4891         * python/py-param.c: Do not include py-ref.h.
4892         * python/py-prettyprint.c: Do not include py-ref.h.
4893         * python/py-progspace.c: Do not include py-ref.h.
4894         * python/py-symbol.c: Do not include py-ref.h.
4895         * python/py-symtab.c: Do not include py-ref.h.
4896         * python/py-type.c: Do not include py-ref.h.
4897         * python/py-unwind.c: Do not include py-ref.h.
4898         * python/py-utils.c: Do not include py-ref.h.
4899         * python/py-value.c: Do not include py-ref.h.
4900         * python/py-varobj.c: Do not include py-ref.h.
4901         * python/py-xmethods.c: Do not include py-ref.h.
4902         * python/python.c: Do not include py-ref.h.
4903         * varobj.c: Do not include py-ref.h.
4904
4905 2019-01-22  Tom Tromey  <tom@tromey.com>
4906
4907         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4908         keyword for bcache.
4909
4910 2019-01-22  Tom Tromey  <tom@tromey.com>
4911
4912         * compile/compile-cplus-types.c: Remove a comment by #include.
4913
4914 2019-01-22  Tom Tromey  <tom@tromey.com>
4915
4916         * compile/gcc-c-plugin.h: Include compile-internal.h.
4917
4918 2019-01-22  Tom Tromey  <tom@tromey.com>
4919
4920         * stabsread.c (EXTERN): Do not define.
4921         (symnum, next_symbol_text_func, processing_gcc_compilation)
4922         (within_function, global_sym_chain, global_stabs)
4923         (previous_stab_code, this_object_header_files)
4924         (n_this_object_header_files)
4925         (n_allocated_this_object_header_files): Define.
4926         * stabsread.h (EXTERN): Never define.  Use "extern".
4927
4928 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4929
4930         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4931         history_value.
4932
4933 2019-01-21  Tom Tromey  <tom@tromey.com>
4934
4935         * ui-out.c: Fix includes.
4936         * tui/tui-source.c: Fix includes.
4937         * target.c: Fix includes.
4938         * remote.c: Fix includes.
4939         * regcache.c: Fix includes.
4940         * python/py-block.c: Fix includes.
4941         * printcmd.c: Fix includes.
4942         * or1k-tdep.c: Fix includes.
4943         * mi/mi-main.c: Fix includes.
4944         * m32r-tdep.c: Fix includes.
4945         * csky-tdep.c: Fix includes.
4946         * compile/compile-cplus-types.c: Fix includes.
4947         * cli/cli-interp.c: Fix includes.
4948
4949 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4950
4951         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4952         for padding.
4953
4954 2019-01-16  Tom Tromey  <tom@tromey.com>
4955
4956         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4957         earlier.
4958         (struct objfile) <msymbols_range>: Move from top level.
4959         <msymbols>: New method.
4960         (class objfile_msymbols): Remove.
4961         * symtab.c (default_collect_symbol_completion_matches_break_on):
4962         Update.
4963         * symmisc.c (dump_msymbols): Update.
4964         * stabsread.c (scan_file_globals): Update.
4965         * objc-lang.c (info_selectors_command, info_classes_command)
4966         (find_methods): Update.
4967         * minsyms.c (find_solib_trampoline_target): Update.
4968         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4969         * coffread.c (coff_symfile_read): Update.
4970         * ada-lang.c (ada_lookup_simple_minsym)
4971         (ada_collect_symbol_completion_matches): Update.
4972
4973 2019-01-16  Tom Tromey  <tom@tromey.com>
4974
4975         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4976         type.  Remove no-argument constructor.
4977         <iterator::operator++>: Simplify.
4978         <begin>: Update.
4979         <end>: Use minimal_symbol_count.
4980
4981 2019-01-16  Tom Tromey  <tom@tromey.com>
4982
4983         * objfiles.h (struct objfile) <psymtabs>: New method.
4984         (class objfile_psymtabs): Remove.
4985         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4986         typedef.
4987         <range>: New method.
4988         (require_partial_symbols): Change return type.
4989         * psymtab.c (require_partial_symbols)
4990         (psym_expand_symtabs_matching): Update.
4991         * mdebugread.c (parse_partial_symbols): Update.
4992         * dbxread.c (dbx_end_psymtab): Update.
4993
4994 2019-01-15  Tom Tromey  <tom@tromey.com>
4995
4996         * symtab.c (lookup_objfile_from_block)
4997         (lookup_symbol_in_objfile_symtabs)
4998         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4999         (find_line_symtab, info_sources_command)
5000         (default_collect_symbol_completion_matches_break_on)
5001         (make_source_files_completion_list): Update.
5002         * symmisc.c (print_objfile_statistics, dump_objfile)
5003         (maintenance_print_symbols, maintenance_info_symtabs)
5004         (maintenance_check_symtabs, maintenance_info_line_tables):
5005         Update.
5006         * source.c (select_source_symtab)
5007         (forget_cached_source_info_for_objfile): Update.
5008         * objfiles.h (class objfile_compunits): Remove.
5009         (struct objfile) <compunits_range>: New typedef.
5010         (compunits): New method.
5011         * objfiles.c (objfile_relocate1): Update.
5012         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5013         * maint.c (count_symtabs_and_blocks): Update.
5014         * linespec.c (iterate_over_all_matching_symtabs): Update.
5015         * cp-support.c (add_symbol_overload_list_qualified): Update.
5016         * coffread.c (coff_symtab_read): Update.
5017         * ada-lang.c (add_nonlocal_symbols)
5018         (ada_collect_symbol_completion_matches)
5019         (ada_add_global_exceptions): Update.
5020
5021 2019-01-15  Tom Tromey  <tom@tromey.com>
5022
5023         * progspace.h (program_space) <objfiles_safe_range>: New
5024         typedef.
5025         <objfiles_safe>: New method.
5026         * objfiles.h (class all_objfiles_safe): Remove.
5027         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5028         * jit.c (jit_inferior_exit_hook): Update.
5029
5030 2019-01-17  Tom Tromey  <tom@tromey.com>
5031
5032         * progspace.h (program_space) <objfiles_range>: New typedef.
5033         <objfiles>: New method.
5034         <objfiles_head>: Rename from objfiles.
5035         (object_files): Update.
5036         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5037         * guile/scm-pretty-print.c
5038         (ppscm_find_pretty_printer_from_objfiles): Update.
5039         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5040         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5041         Update.
5042         * python/py-progspace.c (pspy_get_objfiles): Update.
5043         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5044         Update.
5045         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5046         (objfpy_lookup_objfile_by_build_id): Update.
5047         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5048         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5049         Update.
5050         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5051         (expand_symtab_containing_pc, lookup_objfile_from_block)
5052         (lookup_static_symbol, basic_lookup_transparent_type)
5053         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5054         (find_line_symtab, info_sources_command)
5055         (default_collect_symbol_completion_matches_break_on)
5056         (make_source_files_completion_list, find_main_name): Update.
5057         * symmisc.c (print_symbol_bcache_statistics)
5058         (print_objfile_statistics, maintenance_print_symbols)
5059         (maintenance_print_msymbols, maintenance_print_objfiles)
5060         (maintenance_info_symtabs, maintenance_check_symtabs)
5061         (maintenance_expand_symtabs, maintenance_info_line_tables):
5062         Update.
5063         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5064         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5065         (map_overlay_command, unmap_overlay_command)
5066         (simple_overlay_update, expand_symtabs_matching)
5067         (map_symbol_filenames): Update.
5068         * symfile-debug.c (set_debug_symfile): Update.
5069         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5070         Update.
5071         * source.c (select_source_symtab, forget_cached_source_info):
5072         Update.
5073         * solib.c (solib_read_symbols): Update.
5074         * solib-spu.c (append_ocl_sos): Update.
5075         * psymtab.c (maintenance_print_psymbols)
5076         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5077         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5078         * printcmd.c (info_symbol_command): Update.
5079         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5080         Update.
5081         * objfiles.h (class all_objfiles): Remove.
5082         * objfiles.c (have_partial_symbols, have_full_symbols)
5083         (have_minimal_symbols, qsort_cmp, update_section_map)
5084         (shared_objfile_contains_address_p)
5085         (default_iterate_over_objfiles_in_search_order): Update.
5086         * objc-lang.c (info_selectors_command, info_classes_command)
5087         (find_methods): Update.
5088         * minsyms.c (find_solib_trampoline_target): Update.
5089         * maint.c (maintenance_info_sections)
5090         (maintenance_translate_address, count_symtabs_and_blocks):
5091         Update.
5092         * main.c (captured_main_1): Update.
5093         * linux-thread-db.c (try_thread_db_load_from_pdir)
5094         (has_libpthread): Update.
5095         * linespec.c (iterate_over_all_matching_symtabs)
5096         (search_minsyms_for_name): Update.
5097         * jit.c (jit_find_objf_with_entry_addr): Update.
5098         * hppa-tdep.c (find_unwind_entry)
5099         (hppa_lookup_stub_minimal_symbol): Update.
5100         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5101         Update.
5102         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5103         (elf_gnu_ifunc_resolve_by_got): Update.
5104         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5105         * dwarf-index-write.c (save_gdb_index_command): Update.
5106         * cp-support.c (add_symbol_overload_list_qualified): Update.
5107         * breakpoint.c (create_overlay_event_breakpoint)
5108         (create_longjmp_master_breakpoint)
5109         (create_std_terminate_master_breakpoint)
5110         (create_exception_master_breakpoint): Update.
5111         * blockframe.c (find_pc_partial_function): Update.
5112         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5113         (ada_collect_symbol_completion_matches)
5114         (ada_add_global_exceptions): Update.
5115
5116 2019-01-17  Tom Tromey  <tom@tromey.com>
5117
5118         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5119         declare VEC.
5120         (solib_target_parse_libraries): Change return type.
5121         (library_list_start_segment, library_list_start_section)
5122         (library_list_end_library, library_list_start_library); Update.
5123         (solib_target_free_library_list): Remove.
5124         (solib_target_parse_libraries): Remove cleanup.  Change return
5125         type.
5126         (solib_target_current_sos): Update.
5127
5128 2019-01-17  Tom Tromey  <tromey@bapiya>
5129
5130         * valprint.c: Replace "the the" with "the".
5131         * symtab.c: Replace "the the" with "the".
5132         * solib.c: Replace "the the" with "the".
5133         * solib-dsbt.c: Replace "the the" with "the".
5134         * linespec.c: Replace "the the" with "the".
5135         * dwarf2loc.h: Replace "the the" with "the".
5136         * amd64-windows-tdep.c: Replace "the the" with "the".
5137         * aarch64-tdep.c: Replace "the the" with "the".
5138
5139 2019-01-16  Keith Seitz  <keiths@redhat.com>
5140
5141         PR gdb/23773
5142         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5143         <builder>: Rename to ..
5144         <m_builder>: ... this and make private.
5145         (dwarf2_cu::get_builder): New method.  Change all users of
5146         `builder' to use this method.
5147         (dwarf2_start_symtab): Move to ...
5148         (dwarf2_cu::start_symtab): ... here.  Update all callers
5149         (setup_type_unit_groups): Move to ...
5150         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5151         callers.
5152         (dwarf2_cu::reset_builder): New method.
5153         (process_full_compunit, process_full_type_unit): Use
5154         dwarf2_cu::reset_builder.
5155         (follow_die_offset): Record the ancestor CU if it is different
5156         from the followed DIE's CU.
5157         (follow_die_sig_1): Likewise.
5158
5159 2019-01-15  Tom Tromey  <tom@tromey.com>
5160
5161         * remote.c (class remote_state) <buf>: Now a char_vector.
5162         <buf_size>: Remove.
5163         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5164         parameter.
5165         (remote_target::getpkt_or_notif_sane_1)
5166         (remote_target::getpkt_sane)
5167         (remote_target::getpkt_or_notif_sane): Likewise.
5168         (class remote_target) <putpkt>: New overload.
5169         (remote_target::read_frame): Change type of "buf_p".  Remove
5170         sizeof_p parameter.
5171         (packet_ok): New overload.
5172         (packet_check_result): New overload.
5173         Update all uses.
5174
5175 2019-01-14  Tom Tromey  <tom@tromey.com>
5176
5177         * remote-notif.c (handle_notification, remote_notif_ack)
5178         (remote_notif_parse): Make "buf" const.
5179         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5180         const.
5181         (remote_notif_parse, remote_notif_ack, handle_notification):
5182         Likewise.
5183         * remote.c (remote_notif_stop_parse): Make "buf" const.
5184         (remote_target::remote_parse_stop_reply): Make "buf" const.
5185         (remote_notif_stop_ack): Make "buf" const.
5186
5187 2019-01-14  Tom Tromey  <tom@tromey.com>
5188
5189         * remote.c (remote_console_output): Make parameter const.
5190
5191 2019-01-14  Tom Tromey  <tom@tromey.com>
5192
5193         * target-debug.h (target_debug_print_signals): Constify.
5194         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5195         * procfs.c (procfs_target::pass_signals): Update.
5196         * linux-nat.c (linux_nat_target::pass_signals): Update.
5197         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5198         * target-delegates.c: Rebuild.
5199         * remote.c (remote_target::program_signals): Update.
5200         (remote_target::pass_signals): Update.
5201         * target.c (target_pass_signals): Constify argument.
5202         (target_program_signals): Likewise.
5203         * target.h (struct target_ops) <pass_signals, program_signals>:
5204         Constify argument.
5205         (target_pass_signals, target_program_signals): Constify argument.
5206
5207 2019-01-14  Tom Tromey  <tom@tromey.com>
5208
5209         PR tui/28819:
5210         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5211
5212 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5213
5214         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5215         field.
5216         * rs6000-tdep.c: Include reggroups.h.
5217         (IS_V_ALIAS_PSEUDOREG): Define.
5218         (rs6000_register_name): Return names for the "vX" aliases.
5219         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5220         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5221         aliases.  Call default_register_reggroup_p for all other
5222         pseudo-registers.
5223         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5224         New functions.
5225         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5226         Handle "vX" aliases.
5227         (v_alias_pseudo_register_collect): New function.
5228         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5229         (rs6000_gdbarch_init): Initialize "vX" aliases as
5230         pseudo-registers.  Restore registration of
5231         rs6000_pseudo_register_reggroup_p with
5232         set_tdesc_pseudo_register_reggroup_p.
5233
5234 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5235
5236         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5237         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5238         set_gdbarch_num_pseudo_regs.
5239
5240 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5241
5242         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5243         Remove arg prefixname, add do_set and do_show.
5244         Add member functions set_list and show_list.
5245         * cli/cli-style.c (class cli_style_option): Update accordingly.
5246         (style_set_list): Move to file scope.
5247         (style_show_list): Likewise.
5248         (set_style): Call help_list.
5249         (show_style): Call cmd_show_list.
5250         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5251         Update to use the new macro.
5252
5253 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5254
5255         * ada-lang.c (_initialize_ada_language): Expand the help text
5256         for the "catch exception" command.
5257
5258 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5259
5260         * symtab.c (matching_obj_sections): Initialize obj,
5261         declare it closer to its usage.
5262
5263 2019-01-10  Tom Tromey  <tom@tromey.com>
5264
5265         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5266         (basic_inf_threads_range): Remove.
5267         (inf_threads_range, inf_non_exited_threads_range)
5268         (safe_inf_threads_range): Use next_adapter.
5269
5270 2019-01-10  Keith Seitz  <keiths@redhat.com>
5271
5272         PR gdb/23712
5273         PR symtab/23010
5274         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5275         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5276
5277 2019-01-10  Keith Seitz  <keiths@redhat.com>
5278
5279         PR gdb/23712
5280         PR symtab/23010
5281         * dictionary.c (pending_to_vector): Remove.
5282         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5283         Remove _1 suffix, replacing functions of the same name.  Update
5284         all callers.
5285         (dict_create_hashed, dict_create_hashed_expandable)
5286         (dict_create_linear, dict_create_linear_expandable, dict_free)
5287         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5288         Make functions static.
5289
5290 2019-01-10  Keith Seitz  <keiths@redhat.com>
5291
5292         PR gdb/23712
5293         PR symtab/23010
5294         * dictionary.h (struct dictionary): Replace declaration with
5295         multidictionary.
5296         (dict_create_hashed, dict_create_hashed_expandable)
5297         (dict_create_linear, dict_create_linear_expandable)
5298         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5299         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5300         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5301         taking multidictionary argument.
5302         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5303         * block.h (struct block) <dict>: Change to multidictionary
5304         and rename `multidict'.
5305         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5306         symmisc.c: Update all dictionary references to multidictionary.
5307
5308 2019-01-10  Keith Seitz  <keiths@redhat.com>
5309
5310         PR gdb/23712
5311         PR symtab/23010
5312         * dictionary.c: Include unordered_map.
5313         (pending_to_vector): New function.
5314         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5315         Rewrite the non-"_1" functions to take vector instead
5316         of linked list.
5317         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5318         "new" _1 versions of the same name.
5319         (multidictionary): Define.
5320         (std::hash<enum language): New definition.
5321         (collate_pending_symbols_by_language, mdict_create_hashed)
5322         (mdict_create_hashed_expandable, mdict_create_linear)
5323         (mdict_create_linear_expandable, mdict_free)
5324         (find_language_dictionary, create_new_language_dictionary)
5325         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5326         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5327         (mdict_size, mdict_empty): New functions.
5328         * dictionary.h (mdict_iterator): Define.
5329
5330 2019-01-10  Pedro Alves  <palves@redhat.com>
5331
5332         * breakpoint.c (read_uploaded_action)
5333         (create_tracepoint_from_upload): Adjust to use
5334         gdb::unique_xmalloc_ptr.
5335         * ctf.c (ctf_write_uploaded_tp):
5336         (SET_ARRAY_FIELD): Use emplace_back.
5337         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5338         * tracefile-tfile.c (tfile_write_uploaded_tp):
5339         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5340         gdb::unique_xmalloc_ptr.
5341         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5342         at_string, cond_string, cmd_strings>: Replace char pointers
5343         with gdb::unique_xmalloc_ptr.
5344
5345 2019-01-10  Pedro Alves  <palves@redhat.com>
5346
5347         * solib-target.c (library_list_start_library): Don't xstrdup name.
5348
5349 2019-01-10  Pedro Alves  <palves@redhat.com>
5350
5351         * mdebugread.c (parse_partial_symbols): Use
5352         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5353
5354 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5355
5356         * linux-fork.c (scoped_switch_fork_info)
5357         <~scoped_switch_fork_info>: Fix incorrect variable name.
5358
5359 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5360
5361         * linux-fork.c (scoped_switch_fork_info)
5362         <scoped_switch_fork_info>: Make explicit.
5363         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5364
5365 2019-01-10  Tom Tromey  <tom@tromey.com>
5366
5367         * objfiles.h (objfile::reset_psymtabs): Update.
5368         * objfiles.c (objfile::objfile): Update.
5369         * psymtab.h (psymtab_storage::obstack): Update.
5370         (psymtab_storage::m_obstack): Use gdb::optional.
5371         (class psymtab_storage): Update comment.  Remove objfile
5372         parameter.
5373         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5374
5375 2019-01-10  Tom Tromey  <tom@tromey.com>
5376
5377         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5378         <free_psymtabs>: Now private.
5379         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5380         (allocate_psymtab): Use new method.
5381
5382 2019-01-10  Tom Tromey  <tom@tromey.com>
5383
5384         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5385         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5386         * mdebugread.c (parse_partial_symbols): Use
5387         allocate_dependencies.
5388         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5389         allocate_dependencies.
5390         (process_psymtab_comp_unit_reader)
5391         (build_type_psymtab_dependencies): Likewise.
5392         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5393
5394 2019-01-10  Tom Tromey  <tom@tromey.com>
5395
5396         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5397         PSYMBOL_SET_LANGUAGE.
5398         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5399
5400 2019-01-10  Tom Tromey  <tom@tromey.com>
5401
5402         * psymtab.h (psymtab_storage::obstack): New method.
5403         <m_obstack>: Rename from obstack; now private.
5404         * psymtab.c (psymtab_storage): Update.
5405         * dwarf2read.c (create_addrmap_from_index)
5406         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5407         Update.
5408
5409 2019-01-10  Tom Tromey  <tom@tromey.com>
5410
5411         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5412         * objfiles.h (objfile::reset_psymtabs): New method.
5413
5414 2019-01-10  Tom Tromey  <tom@tromey.com>
5415
5416         * symmisc.c (print_symbol_bcache_statistics): Update.
5417         (print_objfile_statistics): Update.
5418         * symfile.c (reread_symbols): Update.
5419         * psymtab.h (class psymtab_storage): New.
5420         * psymtab.c (psymtab_storage): New constructor.
5421         (~psymtab_storage): New destructor.
5422         (require_partial_symbols): Update.
5423         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5424         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5425         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5426         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5427         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5428         (start_psymtab_common, end_psymtab_common)
5429         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5430         (allocate_psymtab): Update.
5431         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5432         Update.
5433         (dump_psymtab_addrmap, maintenance_print_psymbols)
5434         (maintenance_check_psymtabs): Update.
5435         (class objfile_psymtabs): Move to objfiles.h.
5436         * psympriv.h (discard_psymtab): Now inline.
5437         (psymtab_discarder::psymtab_discarder): Update.
5438         (psymtab_discarder::~psymtab_discarder): Update.
5439         (ALL_OBJFILE_PSYMTABS): Rewrite.
5440         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5441         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5442         Remove fields.
5443         <partial_symtabs>: New field.
5444         (class objfile_psymtabs): Move from psymtab.h.  Update.
5445         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5446         psymbol_cache.
5447         (objfile::~objfile): Don't destroy psymbol_cache.
5448         * mdebugread.c (parse_partial_symbols): Update.
5449         * dwarf2read.c (create_addrmap_from_index)
5450         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5451         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5452         (add_partial_subprogram, dwarf2_ranges_read): Update.
5453         * dwarf-index-write.c (write_address_map)
5454         (write_one_signatured_type, recursively_write_psymbols)
5455         (class debug_names, class debug_names, write_psymtabs_to_index):
5456         Update.
5457
5458 2019-01-10  Tom Tromey  <tom@tromey.com>
5459
5460         * symtab.h (SYMBOL_SET_NAMES): Update.
5461         (symbol_set_names): Update.
5462         (MSYMBOL_SET_NAMES): Update.
5463         * symtab.c (symbol_set_names): Change argument to be an
5464         objfile_per_bfd_storage.
5465         * psymtab.c (add_psymbol_to_bcache): Update.
5466         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5467
5468 2019-01-10  Tom Tromey  <tom@tromey.com>
5469
5470         * symtab.c (create_demangled_names_hash): Change argument to be an
5471         objfile_per_bfd_storage.
5472         (symbol_set_names): Update.
5473
5474 2019-01-10  Tom Tromey  <tom@tromey.com>
5475
5476         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5477         init_psymbol_list.
5478         * psymtab.c (init_psymbol_list): Do nothing if already called.
5479         * psympriv.h (init_psymbol_list): Add comment.
5480         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5481         init_psymbol_list.
5482         * dbxread.c (dbx_symfile_read): Unconditionally call
5483         init_psymbol_list.
5484
5485 2019-01-10  Tom Tromey  <tom@tromey.com>
5486
5487         * xcoffread.c (scan_xcoff_symtab): Update.
5488         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5489         "where".
5490         * mdebugread.c (parse_partial_symbols)
5491         (handle_psymbol_enumerators): Update.
5492         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5493         * dbxread.c (read_dbx_symtab): Update.
5494         * psympriv.h (psymbol_placement): New enum.
5495         (add_psymbol_to_list): Update.
5496
5497 2019-01-10  Tom Tromey  <tom@tromey.com>
5498
5499         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5500         static_psymbols parameters.
5501         (scan_xcoff_symtab): Update.
5502         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5503         static_psymbols parameters.
5504         * psympriv.h (start_psymtab_common): Update.
5505         * mdebugread.c (parse_partial_symbols): Update.
5506         * dwarf2read.c (create_partial_symtab): Update.
5507         * dbxread.c (read_dbx_symtab): Update.
5508         (start_psymtab): Remove global_psymbols and static_psymbols
5509         parameters.
5510
5511 2019-01-10  Tom Tromey  <tom@tromey.com>
5512
5513         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5514         * psymtab.c (allocate_psymtab): Add comment.
5515         * psympriv.h (allocate_psymtab): Add comment.
5516         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5517         initializations.
5518         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5519
5520 2019-01-10  Tom Tromey  <tom@tromey.com>
5521
5522         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5523         Don't declare.
5524         * mipsread.c: Include mdebugread.h.
5525         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5526         Declare.
5527         * elfread.c: Include mdebugread.h.
5528
5529 2019-01-09  Tom Tromey  <tom@tromey.com>
5530
5531         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5532         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5533         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5534         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5535         (psym_lookup_symbol, psym_find_last_source_symtab)
5536         (psym_forget_cached_source_info, psym_print_stats)
5537         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5538         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5539         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5540         (psym_find_compunit_symtab_by_address)
5541         (maintenance_print_psymbols, maintenance_info_psymtabs)
5542         (maintenance_check_psymtabs): Use ranged for.
5543         * psymtab.h (class objfile_psymtabs): New.
5544         (require_partial_symbols): Return objfile_psymtabs.
5545         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5546
5547 2019-01-09  Tom Tromey  <tom@tromey.com>
5548
5549         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5550         (find_pc_mapped_section, list_overlays_command)
5551         (map_overlay_command, unmap_overlay_command)
5552         (simple_overlay_update): Use all_objfiles.
5553         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5554         * printcmd.c (info_symbol_command): Use all_objfiles.
5555         * objfiles.h (ALL_OBJSECTIONS): Remove.
5556         * maint.c (maintenance_translate_address): Use all_objfiles.
5557         * gcore.c (gcore_create_callback): Use all_objfiles.
5558         (objfile_find_memory_regions): Likewise.
5559
5560 2019-01-09  Tom Tromey  <tom@tromey.com>
5561
5562         * symtab.c (find_line_symtab, info_sources_command)
5563         (make_source_files_completion_list): Use objfile_compunits.
5564         * source.c (select_source_symtab): Use objfile_compunits.
5565         * objfiles.h (struct objfile): Update comment.
5566         (ALL_OBJFILES): Remove.
5567         (ALL_FILETABS): Remove.
5568         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5569         objfile_compunits.
5570
5571 2019-01-09  Tom Tromey  <tom@tromey.com>
5572
5573         * symmisc.c (print_objfile_statistics, dump_objfile)
5574         (maintenance_print_symbols): Use compunit_filetabs.
5575         * source.c (forget_cached_source_info_for_objfile): Use
5576         compunit_filetabs.
5577         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5578         (ALL_FILETABS): Use compunit_filetabs.
5579         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5580         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5581
5582 2019-01-09  Tom Tromey  <tom@tromey.com>
5583
5584         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5585         (compunit_filetabs): New.
5586         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5587         compunit_filetabs.
5588         (info_sources_command, make_source_files_completion_list): Remove
5589         declaration.
5590         * symmisc.c (print_objfile_statistics, dump_objfile)
5591         (maintenance_print_symbols): Remove declaration.
5592         (maintenance_info_symtabs): Use compunit_filetabs.
5593         (maintenance_info_line_tables): Likewise.
5594         * source.c (select_source_symtab): Change local variable name.
5595         (forget_cached_source_info_for_objfile): Remove declaration.
5596         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5597         * objfiles.c (objfile_relocate1): Remove declaration.
5598         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5599         declaration.
5600         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5601         * coffread.c (coff_symtab_read): Remove declaration.
5602         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5603         compunit_filetabs.
5604
5605 2019-01-09  Tom Tromey  <tom@tromey.com>
5606
5607         * symtab.c (lookup_objfile_from_block)
5608         (find_pc_sect_compunit_symtab, search_symbols)
5609         (default_collect_symbol_completion_matches_break_on): Use
5610         objfile_compunits.
5611         * objfiles.h (ALL_COMPUNITS): Remove.
5612         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5613         * cp-support.c (add_symbol_overload_list_qualified): Use
5614         objfile_compunits.
5615         * ada-lang.c (ada_collect_symbol_completion_matches)
5616         (ada_add_global_exceptions): Use objfile_compunits.
5617
5618 2019-01-09  Tom Tromey  <tom@tromey.com>
5619
5620         * source.c (select_source_symtab)
5621         (forget_cached_source_info_for_objfile): Remove declaration.
5622         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5623         declaration.
5624         * maint.c (count_symtabs_and_blocks): Remove declaration.
5625         * cp-support.c (add_symbol_overload_list_qualified): Remove
5626         declaration.
5627         * coffread.c (coff_symtab_read): Remove declaration.
5628         * symtab.c (lookup_symbol_in_objfile_symtabs)
5629         (basic_lookup_transparent_type_1): Use objfile_compunits.
5630         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5631         (info_sources_command, search_symbols)
5632         (default_collect_symbol_completion_matches_break_on)
5633         (make_source_files_completion_list): Remove declaration.
5634         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5635         (ada_collect_symbol_completion_matches)
5636         (ada_add_global_exceptions): Remove declaration.
5637         * linespec.c (iterate_over_all_matching_symtabs): Use
5638         objfile_compunits.
5639         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5640         (class objfile_compunits): New.
5641         (ALL_COMPUNITS): Use objfile_compunits.
5642         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5643         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5644         objfile_compunits.
5645         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5646
5647 2019-01-09  Tom Tromey  <tom@tromey.com>
5648
5649         * symtab.c (search_symbols)
5650         (default_collect_symbol_completion_matches_break_on): Use
5651         objfile_msymbols.
5652         * ada-lang.c (ada_lookup_simple_minsym)
5653         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5654         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5655         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5656         objfile_msymbols.
5657         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5658         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5659         * objc-lang.c (find_methods): Use objfile_msymbols.
5660         (info_selectors_command, info_classes_command): Likewise.
5661         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5662         * objfiles.h (class objfile_msymbols): New.
5663         (ALL_OBJFILE_MSYMBOLS): Remove.
5664         (ALL_MSYMBOLS): Remove.
5665
5666 2019-01-09  Tom Tromey  <tom@tromey.com>
5667
5668         * common/next-iterator.h (next_adapter): Add Iterator template
5669         parameter.
5670         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5671         (class all_objfiles_safe): New.
5672         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5673         * objfiles.c (put_objfile_before): Update comment.
5674         (add_separate_debug_objfile): Likewise.
5675         (free_all_objfiles): Use all_objfiles_safe.
5676         (objfile_purge_solibs): Likewise.
5677
5678 2019-01-09  Tom Tromey  <tom@tromey.com>
5679
5680         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5681         (expand_symtab_containing_pc, lookup_static_symbol)
5682         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5683         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5684         all_objfiles.
5685         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5686         * breakpoint.c (create_overlay_event_breakpoint)
5687         (create_longjmp_master_breakpoint)
5688         (create_std_terminate_master_breakpoint)
5689         (create_exception_master_breakpoint): Use all_objfiles.
5690         * linux-thread-db.c (try_thread_db_load_from_pdir)
5691         (has_libpthread): Use all_objfiles.
5692         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5693         * linespec.c (iterate_over_all_matching_symtabs)
5694         (search_minsyms_for_name): Use all_objfiles.
5695         * maint.c (maintenance_info_sections): Use all_objfiles.
5696         * main.c (captured_main_1): Use all_objfiles.
5697         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5698         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5699         * guile/scm-pretty-print.c
5700         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5701         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5702         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5703         (maintenance_print_msymbols): Use all_objfiles.
5704         * source.c (select_source_symtab): Use all_objfiles.
5705         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5706         * symfile.c (remove_symbol_file_command)
5707         (expand_symtabs_matching, map_symbol_filenames): Use
5708         all_objfiles.
5709         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5710         all_objfiles.
5711         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5712         * objc-lang.c (find_methods): Use all_objfiles.
5713         * objfiles.c (have_partial_symbols, have_full_symbols)
5714         (have_minimal_symbols, qsort_cmp)
5715         (default_iterate_over_objfiles_in_search_order): Use
5716         all_objfiles.
5717         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5718         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5719         (maintenance_check_psymtabs): Use all_objfiles.
5720         (ALL_PSYMTABS): Remove.
5721         * compile/compile-object-run.c (do_module_cleanup): Use
5722         all_objfiles.
5723         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5724         * cp-support.c (add_symbol_overload_list_qualified): Use
5725         all_objfiles.
5726         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5727         Use all_objfiles.
5728         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5729         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5730         all_objfiles.
5731         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5732         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5733         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5734         Uses all_objfiles.
5735         * solib.c (solib_read_symbols): Use all_objfiles
5736
5737 2019-01-09  Tom Tromey  <tom@tromey.com>
5738
5739         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5740         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5741         all_objfiles.
5742         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5743         * symmisc.c (print_symbol_bcache_statistics)
5744         (print_objfile_statistics, maintenance_print_objfiles)
5745         (maintenance_info_symtabs, maintenance_check_symtabs)
5746         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5747         all_objfiles.
5748         * source.c (forget_cached_source_info): Use all_objfiles.
5749         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5750         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5751         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5752         * objfiles.c (update_section_map): Use all_objfiles.
5753         (shared_objfile_contains_address_p): Likewise.
5754         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5755         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5756
5757 2019-01-09  Tom Tromey  <tom@tromey.com>
5758
5759         * common/next-iterator.h: New file.
5760         * objfiles.h (class all_objfiles): New.
5761         (struct objfile_iterator): New.
5762
5763 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5764
5765         * NEWS: Move the description of the changed "frame", "select-frame",
5766          and "info frame" commands to the Changed commands section.
5767
5768 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5769
5770         * gdbtypes.c (check_stub_method_group): Remove handling of old
5771         mangling schemes.
5772         * linespec.c (find_methods): Likewise.
5773         * stabsread.c (read_member_functions): Likewise.
5774         * valops.c (search_struct_method): Likewise.
5775         (value_struct_elt_for_reference): Likewise.
5776         * NEWS: Mention this change.
5777
5778 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5779
5780         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5781         print_source_lines.
5782         * source.c (print_source_lines_base): Update line number check.
5783         (print_source_lines): New function.
5784         (source_lines_range::source_lines_range): New function.
5785         * source.h (class source_lines_range): New class.
5786         (print_source_lines): New declaration.
5787
5788 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5789
5790         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5791
5792 2019-01-08  Tom Tromey  <tom@tromey.com>
5793             Simon Marchi  <simon.marchi@ericsson.com>
5794
5795         PR gdb/24060
5796         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5797         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5798         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5799         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5800         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5801         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5802
5803 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5804
5805         * source.c (select_source_symtab): Move header comment to
5806         declaration in source.h.
5807         (forget_cached_source_info_for_objfile): Likewise.
5808         (forget_cached_source_info): Likewise.
5809         (identify_source_line): Likewise.
5810         * source.h (identify_source_line): Move declaration from symtab.h
5811         and add comment from source.c
5812         (print_source_lines): Likewise.
5813         (forget_cached_source_info_for_objfile): Likewise.
5814         (forget_cached_source_info): Likewise.
5815         (select_source_symtab): Likewise.
5816         (enum print_source_lines_flag): Move definition from symtab.h.
5817         * symtab.h (identify_source_line): Move declaration to source.h.
5818         (print_source_lines): Likewise.
5819         (forget_cached_source_info_for_objfile): Likewise.
5820         (forget_cached_source_info): Likewise.
5821         (select_source_symtab): Likewise.
5822         (enum print_source_lines_flag): Move definition to source.h.
5823         * tui/tui-hooks.c: Add 'source.h' include.
5824
5825 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5826
5827         * source.c (print_source_lines_base): Handle requests to print
5828         reverse line number sequences, and guard against empty lines
5829         string.
5830
5831 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5832
5833         * source.c (print_source_lines_base): Fix skip of '\r' if next
5834         character is '\n'.
5835
5836 2019-01-06  Tom Tromey  <tom@tromey.com>
5837
5838         * c-exp.y (struct c_parse_state) <macro_original_text,
5839         expansion_obstack>: New member.
5840         (macro_original_text, expansion_obstack): Remove globals.
5841         (scan_macro_expansion, scanning_macro_expansion)
5842         (finished_macro_expansion): Update.
5843         (scan_macro_cleanup): Remove.
5844         (yylex, c_parse): Update.
5845
5846 2019-01-06  Tom Tromey  <tom@tromey.com>
5847
5848         * c-exp.y (struct c_parse_state) <strings>: New member.
5849         (operator_stoken): Update.
5850
5851 2019-01-06  Tom Tromey  <tom@tromey.com>
5852
5853         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5854         (union type_stack_elt) <typelist_val>: Now a pointer to
5855         std::vector.
5856         (type_stack_cleanup): Don't declare.
5857         (push_typelist): Update.
5858         * parse.c (pop_typelist): Return a std::vector.
5859         (push_typelist): Take a std::vector.
5860         (follow_types): Update.  Do not free args.
5861         (type_stack_cleanup): Remove.
5862         * c-exp.y (struct c_parse_state): New.
5863         (cpstate): New global.
5864         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5865         (nonempty_typelist): Update.
5866         (func_mod): Create a new vector.
5867         (c_parse): Create a c_parse_state.
5868         (check_parameter_typelist): Do not delete params.
5869         (function_method): Update.  Do not delete type_list.
5870
5871 2019-01-06  Tom Tromey  <tom@tromey.com>
5872
5873         PR gdb/28155:
5874         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5875         check_typedef.
5876         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5877         (print_return_value): Likewise.
5878
5879 2019-01-05  Tom Tromey  <tom@tromey.com>
5880
5881         * contrib/cleanup_check.py: Remove.
5882         * contrib/gcc-with-excheck: Remove.
5883         * contrib/exsummary.py: Remove.
5884         * contrib/excheck.py: Remove.
5885
5886 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5887
5888         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5889         NULL. Initialize tpprev to NULL instead of assigning it
5890         to NULL on the next statement.
5891         * windows-nat.c (windows_delete_thread): Remove check for
5892         main_thread_id before printing thread exit notifications.
5893         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5894         Remove thread ID check against main_thread_id.
5895         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5896         windows_delete_thread.
5897         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5898
5899 2019-01-04  Tom Tromey  <tom@tromey.com>
5900
5901         * compile/compile.c (_initialize_compile): Use upper case for
5902         metasyntactic variables.
5903         * symmisc.c (_initialize_symmisc): Use upper case for
5904         metasyntactic variables.
5905         * psymtab.c (_initialize_psymtab): Use upper case for
5906         metasyntactic variables.
5907         * demangle.c (demangle_command): Use upper case for metasyntactic
5908         variables.
5909         (_initialize_demangler): Likewise.
5910         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5911         variables.
5912
5913 2019-01-03  Tom Tromey  <tom@tromey.com>
5914
5915         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5916
5917 2019-01-03  Tom Tromey  <tom@tromey.com>
5918
5919         * python/py-symtab.c (salpy_str): Update.
5920         (struct salpy_sal_object) <symtab>: Now a PyObject.
5921         (salpy_dealloc): Update.
5922         (del_objfile_sal): Use gdbpy_ref.
5923
5924 2019-01-03  Tom Tromey  <tom@tromey.com>
5925
5926         * python/py-type.c (convert_field): Use new_reference.  Return
5927         gdbpy_ref.
5928         (make_fielditem): Return gdbpy_ref.
5929         (typy_fields): Update.
5930         (typy_getitem): Update.
5931         (field_name): Return gdbpy_ref.  Use new_reference.
5932         (typy_iterator_iternext): Update.
5933
5934 2019-01-03  Tom Tromey  <tom@tromey.com>
5935
5936         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5937
5938 2019-01-03  Tom Tromey  <tom@tromey.com>
5939
5940         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5941         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5942         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5943         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5944         (pspy_set_type_printers): Likewise.
5945         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5946         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5947         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5948         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5949         (objfpy_set_type_printers): Likewise.
5950
5951 2019-01-03  Tom Tromey  <tom@tromey.com>
5952
5953         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5954         (gdbpy_print_stack): Use gdbpy_err_fetch.
5955         * python/python-internal.h (class gdbpy_err_fetch): New class.
5956         (class gdbpy_enter) <m_error_type, m_error_value,
5957         m_error_traceback>: Remove.
5958         <m_error>: New member.
5959         (gdbpy_exception_to_string): Don't declare.
5960         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5961         * python/py-value.c (convert_value_from_python): Use
5962         gdbpy_err_fetch.
5963         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5964         gdbpy_exception_to_string.
5965         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5966         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5967         gdbpy_err_fetch.
5968
5969 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5970
5971         * linux-nat.c (delete_lwp_cleanup): Delete.
5972         (struct lwp_deleter): New struct.
5973         (lwp_info_up): New typedef.
5974         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5975         lwp_info_up.
5976
5977 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5978
5979         * linux-fork.c (class scoped_switch_fork_info): New class.
5980         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5981
5982 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5983
5984         * valops.c (find_overload_match): Remove use of null_cleanup, and
5985         calls to do_cleanups.
5986
5987 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5988
5989         * compile/compile-cplus-types.c
5990         (compile_cplus_instance::decl_name): Handle changes to
5991         cp_func_name.
5992         * cp-support.c (cp_func_name): Update header comment, update
5993         return type.
5994         * cp-support.h (cp_func_name): Update return type in declaration.
5995         * valops.c (find_overload_match): Move temp_func local to top
5996         level of function and change its type.  Use temp_func to hold and
5997         delete temporary string obtained from cp_func_name.
5998
5999 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6000
6001         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6002         gdb::char_vector, remove cleanup, and update uses of `msg`.
6003
6004 2019-01-03  Jim Wilson  <jimw@sifive.com>
6005
6006         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6007
6008 2019-01-02  Tom Tromey  <tom@tromey.com>
6009
6010         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6011         (tdesc_parse_xml): Remove cleanups.
6012         * target-descriptions.h (make_cleanup_free_target_description):
6013         Don't declare.
6014         (target_desc_deleter): New struct.
6015         (target_desc_up): New typedef.
6016         * target-descriptions.c (target_desc_deleter::operator()): Rename
6017         from free_target_description.
6018         (make_cleanup_free_target_description): Remove.
6019
6020 2019-01-02  Tom Tromey  <tom@tromey.com>
6021
6022         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6023         constructor, destructor.
6024         (linespec_parser): Remove typedef.
6025         (~linespec_parser): Rename from linespec_parser_delete.
6026         (linespec_lex_to_end, linespec_complete_label)
6027         (linespec_complete): Update.
6028         (decode_line_full): Remove cleanups.
6029         (decode_line_1): Update.
6030
6031 2019-01-02  Tom Tromey  <tom@tromey.com>
6032
6033         * python/python-internal.h (inferior_to_inferior_object): Change
6034         return type.
6035         * python/py-exitedevent.c (create_exited_event_object): Update.
6036         * python/py-inferior.c (inferior_to_inferior_object): Return
6037         gdbpy_ref.
6038         (python_new_inferior, python_inferior_deleted)
6039         (thread_to_thread_object, delete_thread_object)
6040         (build_inferior_list, gdbpy_selected_inferior): Update.
6041         * python/py-infthread.c (create_thread_object): Update.  Also fail
6042         if inferior_to_inferior_object fails.
6043
6044 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6045
6046         * inferior.h (class inferior) <displaced_step_state>: New field.
6047         * infrun.h (struct displaced_step_state): Move here from
6048         infrun.c.  Initialize fields, add constructor.
6049         <inf>: Remove field.
6050         <reset>: New method.
6051         * infrun.c (struct displaced_step_inferior_state): Move to
6052         infrun.h.
6053         (displaced_step_inferior_states): Remove.
6054         (get_displaced_stepping_state): Adust.
6055         (displaced_step_in_progress_any_inferior): Adjust.
6056         (displaced_step_in_progress_thread): Adjust.
6057         (displaced_step_in_progress): Adjust.
6058         (add_displaced_stepping_state): Remove.
6059         (get_displaced_step_closure_by_addr): Adjust.
6060         (remove_displaced_stepping_state): Remove.
6061         (infrun_inferior_exit): Call displaced_step_state.reset.
6062         (use_displaced_stepping): Don't check for NULL.
6063         (displaced_step_prepare_throw): Call
6064         get_displaced_stepping_state.
6065         (displaced_step_fixup): Don't check for NULL.
6066         (prepare_for_detach): Don't check for NULL.
6067
6068 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6069
6070         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6071          in case of call that did not complete.
6072
6073 2019-01-02  Andrey Utkin  <autkin@undo.io>
6074
6075         * symfile.c (find_separate_debug_file): Fix search of debug files for
6076         remote debuggee.
6077
6078 2019-01-02  Tom Tromey  <tom@tromey.com>
6079
6080         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6081         indentation.
6082         * python/py-frame.c (frapy_older): Remove cast.
6083         (frapy_newer): Likewise.
6084         * python/py-breakpoint.c (local_setattro): Remove cast.
6085         * python/py-arch.c (archpy_name): Remove local variable.
6086         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6087
6088 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6089
6090         * unittests/basic_string_view/element_access/char/empty.cc:
6091         Fix year range in copyright header.
6092
6093 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6094
6095         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6096         Delete.
6097         <operator==>: Update with for removed field.
6098         <hash>: Likewise.
6099         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6100         <isa_features>: ...this.
6101         <abi_features>: New field.
6102         (riscv_isa_flen): Update comment.
6103         (riscv_abi_xlen): New declaration.
6104         (riscv_abi_flen): New declaration.
6105         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6106         isa_features.
6107         (riscv_abi_xlen): New function.
6108         (riscv_isa_flen): Update to get answer from isa_features.
6109         (riscv_abi_flen): New function.
6110         (riscv_has_fp_abi): Update to get answer from abi_features.
6111         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6112         xlen and flen.
6113         (riscv_call_info) <xlen, flen>: Update comment.
6114         (riscv_call_arg_struct): Remove invalid assertions
6115         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6116         is removed.
6117         (riscv_gdbarch_init): Gather isa features and abi features
6118         separately, ensure both match on the gdbarch when reusing an old
6119         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6120         a target with 64-bit float hardware.
6121
6122 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6123
6124         * source.c (search_command_helper): Stop reverse search
6125         when line 1 has been searched.
6126
6127 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6128
6129         * record-full.c (record_full_base_target::close): Rewrite
6130         record_full_core_buf_list free logic.
6131
6132 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6133
6134         * break-catch-syscall.c (print_one_catch_syscall): xfree
6135         the last text.
6136
6137 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6138
6139         * top.c (print_gdb_version): Update Copyright year in version
6140         message.
6141
6142 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6143
6144         Update copyright year range in all GDB files.
6145
6146 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6147
6148         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6149
6150 For older changes see ChangeLog-2018.
6151 \f
6152 Local Variables:
6153 mode: change-log
6154 left-margin: 8
6155 fill-column: 74
6156 version-control: never
6157 coding: utf-8
6158 End:
6159