]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blob - gdb/ChangeLog
Make extern declaration of dwarf_always_disassemble correct
[thirdparty/binutils-gdb.git] / gdb / ChangeLog
1 2019-09-18 Christian Biesinger <cbiesinger@google.com>
2
3 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4 to bool to match definition in dwarf2read.c.
5
6 2019-09-17 Christian Biesinger <cbiesinger@google.com>
7
8 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
9 (print_signatures): Likewise.
10 (trust_pad_over_xvs): Likewise.
11 * arch/aarch64-insn.c (aarch64_debug): Likewise.
12 * arch/aarch64-insn.h (aarch64_debug): Likewise.
13 * arm-linux-nat.c (arm_apcs_32): Likewise.
14 * arm-linux-tdep.c (arm_apcs_32): Likewise.
15 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
16 * arm-tdep.c (arm_debug): Likewise.
17 (arm_apcs_32): Likewise.
18 * auto-load.c (debug_auto_load): Likewise.
19 (auto_load_gdb_scripts): Likewise.
20 (global_auto_load): Likewise.
21 (auto_load_local_gdbinit): Likewise.
22 (auto_load_local_gdbinit_loaded): Likewise.
23 * auto-load.h (global_auto_load): Likewise.
24 (auto_load_local_gdbinit): Likewise.
25 (auto_load_local_gdbinit_loaded): Likewise.
26 * breakpoint.c (disconnected_dprintf): Likewise.
27 (breakpoint_proceeded): Likewise.
28 (automatic_hardware_breakpoints): Likewise.
29 (always_inserted_mode): Likewise.
30 (target_exact_watchpoints): Likewise.
31 (_initialize_breakpoint): Update.
32 * breakpoint.h (target_exact_watchpoints): Change to bool.
33 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
34 * cli/cli-cmds.c (trace_commands): Likewise.
35 * cli/cli-cmds.h (trace_commands): Likewise.
36 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
37 to bool*.
38 * cli/cli-logging.c (logging_overwrite): Change to bool.
39 (logging_redirect): Likewise.
40 (debug_redirect): Likewise.
41 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
42 (struct boolean_option_def) <get_var_address_cb_>: Change return type
43 to bool.
44 <boolean_option_def>: Update.
45 (struct flag_option_def): Change default type of Context to bool
46 from int.
47 <flag_option_def>: Change return type of var_address_cb_ to bool*.
48 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
49 (get_setshow_command_value_string): Likewise.
50 * cli/cli-style.c (cli_styling): Change to bool.
51 (source_styling): Likewise.
52 * cli/cli-style.h (source_styling): Likewise.
53 (cli_styling): Likewise.
54 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
55 to bool.
56 * command.h (var_types): Update comment.
57 (add_setshow_boolean_cmd): Change int* var argument to bool*.
58 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
59 bool.
60 (debug_compile_cplus_scopes): Likewise.
61 * compile/compile-internal.h (compile_debug): Likewise.
62 * compile/compile.c (compile_debug): Likewise.
63 (struct compile_options) <raw>: Likewise.
64 * cp-support.c (catch_demangler_crashes): Likewise.
65 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
66 (usr_cmd_cris_dwarf2_cfi): Likewise.
67 * csky-tdep.c (csky_debug): Likewise.
68 * darwin-nat.c (enable_mach_exceptions): Likewise.
69 * dcache.c (dcache_enabled_p): Likewise.
70 * defs.h (info_verbose): Likewise.
71 * demangle.c (demangle): Likewise.
72 (asm_demangle): Likewise.
73 * dwarf-index-cache.c (debug_index_cache): Likewise.
74 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
75 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
76 * dwarf2read.c (check_physname): Likewise.
77 (use_deprecated_index_sections): Likewise.
78 (dwarf_always_disassemble): Likewise.
79 * eval.c (overload_resolution): Likewise.
80 * event-top.c (set_editing_cmd_var): Likewise.
81 (exec_done_display_p): Likewise.
82 * event-top.h (set_editing_cmd_var): Likewise.
83 (exec_done_display_p): Likewise.
84 * exec.c (write_files): Likewise.
85 * fbsd-nat.c (debug_fbsd_lwp): Likewise
86 (debug_fbsd_nat): Likewise.
87 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
88 Likewise.
89 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
90 <backtrace_past_entry> Likewise.
91 * gdb-demangle.h (demangle): Likewise.
92 (asm_demangle): Likewise.
93 * gdb_bfd.c (bfd_sharing): Likewise.
94 * gdbcore.h (write_files): Likewise.
95 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
96 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
97 * gdbthread.h (print_thread_events): Likewise.
98 * gdbtypes.c (opaque_type_resolution): Likewise.
99 (strict_type_checking): Likewise.
100 * gnu-nat.c (gnu_debug_flag): Likewise.
101 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
102 * guile/scm-param.c (pascm_variable): Add boolval.
103 (add_setshow_generic): Update.
104 (pascm_param_value): Update.
105 (pascm_set_param_value_x): Update.
106 * hppa-tdep.c (hppa_debug): Change to bool..
107 * infcall.c (may_call_functions_p): Likewise.
108 (coerce_float_to_double_p): Likewise.
109 (unwind_on_signal_p): Likewise.
110 (unwind_on_terminating_exception_p): Likewise.
111 * infcmd.c (startup_with_shell): Likewise.
112 * inferior.c (print_inferior_events): Likewise.
113 * inferior.h (startup_with_shell): Likewise.
114 (print_inferior_events): Likewise.
115 * infrun.c (step_stop_if_no_debug): Likewise.
116 (detach_fork): Likewise.
117 (debug_displaced): Likewise.
118 (disable_randomization): Likewise.
119 (non_stop): Likewise.
120 (non_stop_1): Likewise.
121 (observer_mode): Likewise.
122 (observer_mode_1): Likewise.
123 (set_observer_mode): Update.
124 (sched_multi): Change to bool.
125 * infrun.h (debug_displaced): Likewise.
126 (sched_multi): Likewise.
127 (step_stop_if_no_debug): Likewise.
128 (non_stop): Likewise.
129 (disable_randomization): Likewise.
130 * linux-tdep.c (use_coredump_filter): Likewise.
131 (dump_excluded_mappings): Likewise.
132 * linux-thread-db.c (auto_load_thread_db): Likewise.
133 (check_thread_db_on_load): Likewise.
134 * main.c (captured_main_1): Update.
135 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
136 xx2_opt, boolean_opt>: Change to bool.
137 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
138 * maint.c (maintenance_profile_p): Likewise.
139 (per_command_time): Likewise.
140 (per_command_space): Likewise.
141 (per_command_symtab): Likewise.
142 * memattr.c (inaccessible_by_default): Likewise.
143 * mi/mi-main.c (mi_async): Likewise.
144 (mi_async_1): Likewise.
145 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
146 * nat/fork-inferior.h (startup_with_shell): Likewise.
147 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
148 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
149 * nios2-tdep.c (nios2_debug): Likewise.
150 * or1k-tdep.c (or1k_debug): Likewise.
151 * parse.c (parser_debug): Likewise.
152 * parser-defs.h (parser_debug): Likewise.
153 * printcmd.c (print_symbol_filename): Likewise.
154 * proc-api.c (procfs_trace): Likewise.
155 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
156 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
157 (set_parameter_value): Update.
158 (add_setshow_generic): Update.
159 * python/py-value.c (copy_py_bool_obj): Change argument from int*
160 to bool*.
161 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
162 int*.
163 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
164 * record-btrace.c (record_btrace_target::store_registers): Update.
165 * record-full.c (record_full_memory_query): Change to bool.
166 (record_full_stop_at_limit): Likewise.
167 * record-full.h (record_full_memory_query): Likewise.
168 * remote-notif.c (notif_debug): Likewise.
169 * remote-notif.h (notif_debug): Likewise.
170 * remote.c (use_range_stepping): Likewise.
171 (interrupt_on_connect): Likewise.
172 (remote_break): Likewise.
173 * ser-tcp.c (tcp_auto_retry): Likewise.
174 * ser-unix.c (serial_hwflow): Likewise.
175 * skip.c (debug_skip): Likewise.
176 * solib-aix.c (solib_aix_debug): Likewise.
177 * spu-tdep.c (spu_stop_on_load_p): Likewise.
178 (spu_auto_flush_cache_p): Likewise.
179 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
180 Likewise.
181 (struct info_print_options) <quiet>: Likewise.
182 * symfile-debug.c (debug_symfile): Likewise.
183 * symfile.c (auto_solib_add): Likewise.
184 (separate_debug_file_debug): Likewise.
185 * symfile.h (auto_solib_add): Likewise.
186 (separate_debug_file_debug): Likewise.
187 * symtab.c (basenames_may_differ): Likewise.
188 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
189 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
190 (struct info_types_options) <quiet>: Likewise.
191 * symtab.h (demangle): Likewise.
192 (basenames_may_differ): Likewise.
193 * target-dcache.c (stack_cache_enabled_1): Likewise.
194 (code_cache_enabled_1): Likewise.
195 * target.c (trust_readonly): Likewise.
196 (may_write_registers): Likewise.
197 (may_write_memory): Likewise.
198 (may_insert_breakpoints): Likewise.
199 (may_insert_tracepoints): Likewise.
200 (may_insert_fast_tracepoints): Likewise.
201 (may_stop): Likewise.
202 (auto_connect_native_target): Likewise.
203 (target_stop_and_wait): Update.
204 (target_async_permitted): Change to bool.
205 (target_async_permitted_1): Likewise.
206 (may_write_registers_1): Likewise.
207 (may_write_memory_1): Likewise.
208 (may_insert_breakpoints_1): Likewise.
209 (may_insert_tracepoints_1): Likewise.
210 (may_insert_fast_tracepoints_1): Likewise.
211 (may_stop_1): Likewise.
212 * target.h (target_async_permitted): Likewise.
213 (may_write_registers): Likewise.
214 (may_write_memory): Likewise.
215 (may_insert_breakpoints): Likewise.
216 (may_insert_tracepoints): Likewise.
217 (may_insert_fast_tracepoints): Likewise.
218 (may_stop): Likewise.
219 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
220 (make_thread_apply_all_options_def_group): Change argument from int*
221 to bool*.
222 (thread_apply_all_command): Update.
223 (print_thread_events): Change to bool.
224 * top.c (confirm): Likewise.
225 (command_editing_p): Likewise.
226 (history_expansion_p): Likewise.
227 (write_history_p): Likewise.
228 (info_verbose): Likewise.
229 * top.h (confirm): Likewise.
230 (history_expansion_p): Likewise.
231 * tracepoint.c (disconnected_tracing): Likewise.
232 (circular_trace_buffer): Likewise.
233 * typeprint.c (print_methods): Likewise.
234 (print_typedefs): Likewise.
235 * utils.c (debug_timestamp): Likewise.
236 (sevenbit_strings): Likewise.
237 (pagination_enabled): Likewise.
238 * utils.h (sevenbit_strings): Likewise.
239 (pagination_enabled): Likewise.
240 * valops.c (overload_resolution): Likewise.
241 * valprint.h (struct value_print_options) <prettyformat_arrays,
242 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
243 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
244 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
245 Likewise.
246 * windows-nat.c (new_console): Likewise.
247 (cygwin_exceptions): Likewise.
248 (new_group): Likewise.
249 (debug_exec): Likewise.
250 (debug_events): Likewise.
251 (debug_memory): Likewise.
252 (debug_exceptions): Likewise.
253 (useshell): Likewise.
254 * windows-tdep.c (maint_display_all_tib): Likewise.
255 * xml-support.c (debug_xml): Likewise.
256
257 2019-09-17 Mike Gulick <mgulick@mathworks.com>
258
259 * source.c (prepare_path_for_appending): New function.
260 (openp): Make use of new function.
261 (find_and_open_source): Search for the compilation directory and
262 source file as a relative path beneath the directory search path.
263
264 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
265
266 * source-cache.c (source_cache::get_line_charpos): Catch
267 exceptions and return false, this matches the behaviour documented
268 in the header file.
269
270 2019-09-17 Joel Brobecker <brobecker@adacore.com>
271
272 * ada-tasks.c (info_task): Remove quoting of the task's name.
273
274 2019-09-16 Christian Biesinger <cbiesinger@google.com>
275
276 * symfile.c (auto_solib_add): Replace comment with a reference
277 to the header file.
278
279 2019-09-14 Christian Biesinger <cbiesinger@google.com>
280
281 * NEWS: Mention that gdb can now be compiled with Python 3
282 on Windows.
283
284 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
285
286 * maint.c (maint_print_section_data::maint_print_section_data):
287 Force use of 'float log10 (float)' by casting the argument to
288 float.
289
290 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
291
292 * maint.c: Add 'cmath' include.
293 (struct maint_print_section_data): New structure.
294 (print_section_index): New function.
295 (print_bfd_section_info): Add header comment, small whitespace
296 cleanup, and update to call new print_section_index function.
297 (print_objfile_section_info): Likewise.
298 (maint_obj_section_from_bfd_section): New function.
299 (print_bfd_section_info_maybe_relocated): New function.
300 (maintenance_info_sections): Add header comment, always use
301 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
302
303 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
304
305 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
306 inner scope, add check that the objfile has psymtabs before
307 checking psymtabs_addrmap.
308 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
309
310 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
311
312 * NEWS: Announce that Ada task names are now shown at more places,
313 and between quotes (except in info task output).
314 * gdb/ada-tasks.c (task_to_str): New function.
315 (display_current_task_id): Call task_to_str.
316 (task_command_1): Likewise.
317 (print_ada_task_info): In non-mi mode, Properly align headers and data
318 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
319
320 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
321
322 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
323 prstatus.pr_lwp.pr_info instead of making it up.
324
325 2019-09-11 Christian Biesinger <cbiesinger@google.com>
326
327 * auto-load.c (auto_load_expand_dir_vars): Update.
328 * defs.h (gdb_datadir): Change to std::string.
329 (python_libdir): Likewise.
330 (relocate_gdb_directory): Change return type to std::string.
331 * guile/guile.c (gdbscm_data_directory): Update.
332 (initialize_scheme_side): Update.
333 * jit.c (jit_reader_dir): Change to std::string.
334 (jit_reader_load_command): Update.
335 * main.c (gdb_datadir): Change to std::string.
336 (python_libdir): Likewise.
337 (set_gdb_data_directory): Update.
338 (relocate_path): Change to return std::string.
339 (relocate_gdb_directory): Change to return std::string.
340 (relocate_gdbinit_path_maybe_in_datadir): Update.
341 (captured_main_1): Update.
342 * python/python.c (do_start_initialization): Update.
343 * top.c (show_gdb_datadir): Update.
344 * xml-syscall.c (xml_init_syscalls_info): Update.
345 (init_syscalls_info): Update.
346
347 2019-09-11 Christian Biesinger <cbiesinger@google.com>
348
349 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
350 out of get_init_files.
351 (get_init_files): Update.
352
353 2019-09-11 Christian Biesinger <cbiesinger@google.com>
354
355 * main.c (get_init_files): Change to use std::string.
356 (captured_main_1): Update.
357 (print_gdb_help): Update.
358
359 2019-09-11 Ali Tamur <tamur@google.com>
360
361 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
362 implementation.
363
364 2019-09-11 Christian Biesinger <cbiesinger@google.com>
365
366 * dbxread.c (read_dbx_symtab): Update.
367 * dwarf2read.c (load_partial_dies): Update.
368 * mdebugread.c (parse_partial_symbols): Update.
369 (handle_psymbol_enumerators): Update.
370 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
371 * psymtab.c (add_psymbol_to_bcache): Likewise.
372 (add_psymbol_to_list): Likewise.
373 * symtab.c (symbol_set_names): Likewise.
374 * symtab.h (symbol_set_names): Likewise.
375 * xcoffread.c (scan_xcoff_symtab): Update.
376
377 2019-09-11 Tom Tromey <tom@tromey.com>
378
379 * symfile-mem.c (symbol_file_add_from_memory): Use
380 bfd_set_filename.
381 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
382 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
383
384 2019-09-10 Tom Tromey <tromey@adacore.com>
385
386 * dwarf-index-write.c (write_psymbols): Extend error message.
387 (debug_names::insert): Add Ada code.
388 (debug_names::write_psymbols): Remove Ada check.
389 (debug_names) <m_string_obstack>: New member.
390 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
391 (gdb_index_symbol_name_matcher::matches): Remove.
392 (mapped_index_base::find_name_components_bounds): Add "lang"
393 parameter.
394 (mapped_index_base::build_name_components): Also split names
395 according to Ada syntax.
396 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
397 type of "match_callback".
398 (check_match, check_find_bounds_finds)
399 (dw2_expand_symtabs_matching): Update.
400 (dw2_debug_names_iterator): Add new constructor.
401 (dw2_debug_names_map_matching_symbols): New function.
402 (dw2_debug_names_expand_symtabs_matching): Update.
403 (dwarf2_debug_names_functions): Use
404 dw2_debug_names_map_matching_symbols.
405
406 2019-09-10 Tom Tromey <tromey@adacore.com>
407
408 * dwarf2read.c (dw2_get_file_names_reader): Add the
409 CU's file name to the results.
410
411 2019-09-10 Tom Tromey <tromey@adacore.com>
412
413 * ada-lang.c (add_nonlocal_symbols): Combine calls to
414 map_matching_symbols. Update.
415 * dwarf2read.c (dw2_map_matching_symbols): Update.
416 * psymtab.c (match_partial_symbol): Change type; update.
417 (psym_map_matching_symbols): Likewise.
418 * symfile-debug.c (debug_qf_map_matching_symbols): Change
419 type; update.
420 * symfile.h (struct quick_symbol_functions)
421 <map_matching_symbols>: Change "name" to be a lookup_name_info.
422 Remove "match".
423
424 2019-09-10 Tom Tromey <tromey@adacore.com>
425
426 * psymtab.c (map_block): Remove.
427 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
428 * symtab.c (iterate_over_symbols_terminated): New function.
429 * symtab.c (iterate_over_symbols_terminated): Declare.
430
431 2019-09-10 Tom Tromey <tromey@adacore.com>
432
433 * ada-lang.c (ada_iterate_over_symbols): Return bool.
434 * language.h (struct language_defn) <la_iterate_over_symbols>:
435 Return bool.
436 * symtab.c (iterate_over_symbols): Return bool.
437 * symtab.h (iterate_over_symbols): Return bool.
438
439 2019-09-10 Tom Tromey <tromey@adacore.com>
440
441 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
442 (add_nonlocal_symbols): Update.
443 * dwarf2read.c (dw2_map_matching_symbols): Change type.
444 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
445 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
446 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
447 Change type of "callback". Remove "data".
448
449
450 2019-09-09 Ali Tamur <tamur@google.com>
451
452 * dwarf2read.c (comp_unit_head): Update comment.
453 (dwarf2_dwo_name): New function declaration.
454 (dwarf_unit_type_name): New function declaration.
455 (read_comp_unit_head): Add support for new compilation units,
456 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
457 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
458 (currently named as "signature") in their header. Also clarify error
459 messages.
460 (lookup_dwo_id): New function. Returns the dwo id of the given
461 compile unit.
462 (lookup_dwo_unit): Use the new lookup_dwo_id function.
463 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
464 functions.
465 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
466 (dwarf2_dwo_name): Get the dwo name if present.
467 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
468 purposes.
469
470 2019-09-09 Tom Tromey <tom@tromey.com>
471
472 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
473
474 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
475
476 * python/python.c (do_start_initialization): Make progname_copy static,
477 to avoid a leak report.
478
479 2019-09-08 Tom Tromey <tom@tromey.com>
480
481 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
482
483 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
484
485 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
486 Change type to gdb::optional<block_enum>.
487 (dw2_symtab_iter_init): Change block_index parameter type
488 to gdb::optional<block_enum>.
489 (dw2_lookup_symbol): Change block_index parameter
490 type to block_enum.c
491 (dw2_debug_names_lookup_symbol): Likewise.
492 * psymtab.c (psym_lookup_symbol): Likewise.
493 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
494 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
495 Likewise.
496
497 2019-09-06 Christian Biesinger <cbiesinger@google.com>
498
499 * defs.h (relocate_gdb_directory): Change int to bool in
500 signature and rename flag to relocatable.
501 * main.c (relocate_path): Likewise.
502 (relocate_gdb_directory): Likewise.
503
504 2019-09-06 Alan Modra <amodra@gmail.com>
505
506 * coffread.c (coff_symfile_read): Constify filename variable.
507 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
508 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
509 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
510 * solib.c (reload_shared_libraries_1): Likewise.
511 * symfile.c (reread_symbols): Likewise.
512 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
513 * solib-darwin.c (darwin_bfd_open): Likewise.
514 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
515
516 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
517
518 * psymtab.c (print_partial_symbols): Handle missing domain_enum
519 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
520
521 2019-09-03 Tom Tromey <tromey@adacore.com>
522
523 * ada-valprint.c (ada_val_print_num): Don't recurse for range
524 types.
525 (has_negatives): Unbias a range type bound.
526 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
527 * gdbtypes.c (operator==): Handle new field.
528 (create_range_type): Add "bias" parameter.
529 (create_static_range_type, resolve_dynamic_range): Update.
530 * gdbtypes.h (struct range_bounds) <bias>: New member.
531 (create_range_type): Add bias parameter.
532 * printcmd.c (print_scalar_formatted): Unbias range types.
533 * value.c (unpack_long): Unbias range types.
534 (pack_long): Bias range types.
535
536 2019-09-02 Alan Hayward <alan.hayward@arm.com>
537
538 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
539 probe arguments.
540
541 2019-09-02 Alan Hayward <alan.hayward@arm.com>
542
543 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
544 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
545 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
546 (compile_probe_arg): Likewise.
547 * probe.h (get_argument_count): Likewise.
548 * solib-svr4.c (solib_event_probe_action): Likewise.
549 * stap-probe.c (stap_probe::get_argument_count): Likewise.
550
551 2019-09-02 Alan Hayward <alan.hayward@arm.com>
552
553 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
554 code to here...
555 (svr4_create_solib_event_breakpoints): ...from here.
556
557 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
558
559 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
560 suffix from warning message.
561
562 2019-08-30 Tom Tromey <tom@tromey.com>
563
564 * tui/tui-winsource.h (struct tui_source_window_base)
565 <refresh_all>: Don't declare.
566 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
567 Remove.
568 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
569 tui_show_locator_content.
570 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
571 declare.
572 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
573 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
574 declare.
575
576 2019-08-30 Tom Tromey <tom@tromey.com>
577
578 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
579
580 2019-08-30 Tom Tromey <tom@tromey.com>
581
582 * tui/tui-stack.c (_initialize_tui_stack): Move later.
583 Remove unnecessary forward declarations.
584
585 2019-08-30 Tom Tromey <tom@tromey.com>
586
587 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
588 rerender.
589 (tui_update_locator_fullname, tui_show_frame_info): Don't call
590 tui_show_locator_content.
591
592 2019-08-30 Tom Tromey <tom@tromey.com>
593
594 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
595 (tui_locator_window::rerender): Rewrite using body of previous
596 tui_show_locator_content.
597
598 2019-08-30 Tom Tromey <tom@tromey.com>
599
600 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
601 set_locator_fullname>: New methods.
602 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
603 Rename from tui_set_locator_fullname.
604 (tui_locator_window::set_locator_info): Rename from
605 tui_set_locator_info. Return bool.
606 (tui_update_locator_fullname, tui_show_frame_info): Update.
607
608 2019-08-30 Tom Tromey <tom@tromey.com>
609
610 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
611
612 2019-08-30 Tom Tromey <tom@tromey.com>
613
614 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
615 call touchwin.
616
617 2019-08-30 Tom Tromey <tom@tromey.com>
618
619 * tui/tui-wingeneral.c (box_win): Assume win_info and
620 win_info->handle cannot be NULL.
621
622 2019-08-30 Tom Tromey <tom@tromey.com>
623
624 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
625 refresh_window>: Declare.
626 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
627 resize.
628 (tui_data_item_window::rerender): Rename from
629 tui_display_register.
630 (tui_data_item_window::refresh_window): New method.
631 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
632 no-op.
633
634 2019-08-30 Tom Tromey <tom@tromey.com>
635
636 * tui/tui-regs.h (struct tui_data_window) <regs_content,
637 regs_column_count, current_group>: Move later. Now private.
638 <get_current_group>: New method.
639 * tui/tui-regs.c (tui_reg_command): Update.
640 * tui/tui-layout.c (tui_set_layout): Update.
641
642 2019-08-30 Tom Tromey <tom@tromey.com>
643
644 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
645 (tui_data_window::rerender): Don't call
646 check_and_display_highlight_if_needed.
647 (tui_data_window::refresh_all): Remove call to
648 erase_data_content.
649
650 2019-08-30 Tom Tromey <tom@tromey.com>
651
652 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
653 (tui_data_window::display_registers_from)
654 (tui_data_window::display_reg_element_at_line)
655 (tui_data_window::display_registers_from_line): Remove checks of
656 "empty".
657
658 2019-08-30 Tom Tromey <tom@tromey.com>
659
660 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
661 Don't declare.
662 * tui/tui-regs.c (tui_data_window::show_registers): Call
663 rerender.
664 (tui_data_window::rerender): Rename from display_all_data.
665 (tui_data_window::rerender): Remove old implementation.
666
667 2019-08-30 Tom Tromey <tom@tromey.com>
668
669 * tui/tui-regs.c (tui_data_window::display_all_data): Change
670 text.
671 * tui/tui-data.h (NO_DATA_STRING): Remove define.
672
673 2019-08-29 Bernhard Wodok <barto@gmx.net>
674 Sergio Durigan Junior <sergiodj@redhat.com>
675
676 PR win32/24284
677 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
678
679 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
680
681 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
682 when searching for types.
683
684 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
685
686 * f-lang.c (f_language_defn): Use f_print_typedef.
687 * f-lang.h (f_print_typedef): Declare.
688 * f-typeprint.c (f_print_typedef): Define.
689
690 2019-08-27 Christian Biesinger <cbiesinger@google.com>
691
692 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
693
694 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
695
696 * cli/cli-utils.c (info_print_options_defs): Delete.
697 (make_info_print_options_def_group): Delete.
698 (extract_info_print_options): Delete.
699 (info_print_command_completer): Delete.
700 (info_print_args_help): Add extra parameter, and optionally
701 include text about -n flag.
702 * cli/cli-utils.h (struct info_print_options): Delete.
703 (extract_info_print_options): Delete declaration.
704 (info_print_command_completer): Delete declaration.
705 (info_print_args_help): Add extra parameter, extend header
706 comment.
707 * python/python.c (gdbpy_rbreak): Pass additional parameter to
708 search_symbols.
709 * stack.c (struct info_print_options): New type.
710 (info_print_options_defs): New file scoped variable.
711 (make_info_print_options_def_group): New static function.
712 (info_print_command_completer): New static function.
713 (info_locals_command): Update to use new local functions.
714 (info_args_command): Likewise.
715 (_initialize_stack): Add extra parameter to calls to
716 info_print_args_help.
717 * symtab.c (search_symbols): Add extra parameter, use this to
718 possibly excluse non-debug symbols.
719 (symtab_symbol_info): Add extra parameter, which is passed on to
720 search_symbols.
721 (struct info_print_options): New type.
722 (info_print_options_defs): New file scoped variable.
723 (make_info_print_options_def_group): New static function.
724 (info_print_command_completer): New static function.
725 (info_variables_command): Update to use local functions, and pass
726 extra parameter through to symtab_symbol_info.
727 (info_functions_command): Likewise.
728 (info_types_command): Pass additional argument through to
729 symtab_symbol_info.
730 (rbreak_command): Pass extra argument to search_symbols.
731 (_initialize_symtab): Add extra arguments for calls to
732 info_print_args_help, and update help text for 'info variables',
733 'whereis', and 'info functions' commands.
734 * symtab.h (search_symbols): Add extra argument to declaration.
735 * NEWS: Mention new flags.
736
737 2019-08-26 Christian Biesinger <cbiesinger@google.com>
738
739 * symtab.c (lookup_static_symbol): Call the new function (and move
740 it down to be next to lookup_global_symbol).
741 (struct global_sym_lookup_data): Add block_enum member and rename to...
742 (struct global_or_static_sym_lookup_data): ...this.
743 (lookup_symbol_global_iterator_cb): Pass block_index instead of
744 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
745 (lookup_symbol_global_or_static_iterator_cb): ...this.
746 (lookup_global_or_static_symbol): New function.
747 (lookup_global_symbol): Call new function.
748
749 2019-08-26 Tom de Vries <tdevries@suse.de>
750
751 PR c++/24852
752 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
753 when pc_probe.prob == NULL.
754
755 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
756
757 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
758 variable symbol_linkage to symbol_linkage_.
759
760 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
761
762 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
763 represent whether the symbol is static, dynamic, or we don't
764 know.
765
766 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
767
768 * gdb/rx-tdep.c (rx_register_names): New.
769 (rx_register_name): Delete.
770 (rx_psw_type): Delete.
771 (rx_fpsw_type): Delete.
772 (rx_register_type): Delete.
773 (rx_gdbarch_init): Convert target-descriptions.
774 (_initialize_rx_tdep): Add initialize_tdesc_rx.
775 * gdb/features/Makefile: Add rx.xml.
776 * gdb/features/rx.xml: New.
777 * gdb/features/rx.c: Generated.
778 * gdb/NEWS: Mention target description support.
779
780 2019-08-22 Christian Biesinger <cbiesinger@google.com>
781
782 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
783 *slot_ptr.
784
785 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
786
787 * configure.ac: Don't check for 'dlfcn.h' (moved to
788 gdbsupport/common.m4).
789 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
790 'gdbsupport/'.
791 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
792 * compile/compile-c-support.c: Include
793 'gdbsupport/gdb-dlfcn.h'.
794 * gdbsupport/common.m4: Check for 'dlfcn.h'.
795 * gdb-dlfcn.c: Move to...
796 * gdbsupport/gdb-dlfcn.c: ... here.
797 * gdb-dlfcn.h: Move to...
798 * gdbsupport/gdb-dlfcn.h: ... here.
799
800 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
801
802 * nios2-tdep.c (struct reg_value): Improve comments. Make
803 the offset field signed.
804
805 2019-08-22 Christian Biesinger <cbiesinger@google.com>
806
807 * python/lib/gdb/__init__.py (_execute_file): New function.
808 * python/python.c (python_run_simple_file): Call gdb._execute_file
809 on Windows.
810
811 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
812
813 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
814 all uses as this was never set to anything but a zero value.
815
816 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
817
818 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
819
820 2019-08-21 Christian Biesinger <cbiesinger@google.com>
821
822 * tui/tui-data.h (tui_gen_win_info): Add an =default
823 move constructor, required by some GCC versions.
824
825 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
826
827 * go32-nat.c (go32_sysinfo): Add hygon_p.
828
829 2019-08-20 Tom Tromey <tom@tromey.com>
830
831 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
832 line_from_reg_element_no, first_reg_element_no_inline,
833 display_all_data, delete_data_content_windows,
834 erase_data_content>: Now private.
835
836 2019-08-20 Tom Tromey <tom@tromey.com>
837
838 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
839 (tui_unhighlight_win, tui_highlight_win)
840 (tui_win_info::make_window): Update.
841 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
842
843 2019-08-20 Tom Tromey <tom@tromey.com>
844
845 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
846 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
847 (MAX_PID_WIDTH): Move to tui-stack.c.
848 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
849 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
850 (MAX_PID_WIDTH): Move from tui-data.h.
851
852 2019-08-20 Tom Tromey <tom@tromey.com>
853
854 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
855 * tui/tui-wingeneral.c (box_win): Change type of win_info.
856 (box_win): Update.
857 (tui_gen_win_info::make_window): Rename from tui_make_window.
858 (tui_win_info::make_window): New method.
859 (tui_gen_win_info::make_visible): Update.
860 * tui/tui-source.c (tui_source_window::set_contents): Update.
861 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
862 (tui_data_window::display_registers_from): Update.
863 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
864 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
865 Declare.
866 <can_box>: Remove.
867 <title>: Remove.
868 (struct tui_win_info) <make_window>: Declare.
869 <can_box>: Now virtual.
870 <title>: New member.
871 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
872 * tui/tui-command.c (tui_cmd_window::resize): Update.
873
874 2019-08-20 Tom Tromey <tom@tromey.com>
875
876 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
877 * tui/tui-regs.c (tui_data_window::show_registers): Update.
878 (tui_data_window::check_register_values): Update.
879
880 2019-08-20 Tom Tromey <tom@tromey.com>
881
882 * tui/tui-regs.h (struct tui_data_window): Use
883 DISABLE_COPY_AND_ASSIGN.
884 <regs_content>: Change type, removing unique_ptr.
885 <tui_data_window>: Add move constructor.
886 * tui/tui-regs.c (tui_data_window::show_registers)
887 (tui_data_window::show_register_group)
888 (tui_data_window::display_registers_from)
889 (tui_data_window::display_registers_from)
890 (tui_data_window::first_data_item_displayed)
891 (tui_data_window::delete_data_content_windows)
892 (tui_data_window::rerender, tui_data_window::refresh_window)
893 (tui_data_window::check_register_values): Update.
894
895 2019-08-20 Tom Tromey <tom@tromey.com>
896
897 * tui/tui-regs.h (struct tui_data_window) <show_registers,
898 show_register_group>: Declare.
899 (tui_show_register_group): Don't declare.
900 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
901 tui_show_registers.
902 (tui_data_window::show_register_group): Rename from
903 tui_show_register_group.
904 (tui_data_window::check_register_values, tui_reg_command):
905 Update.
906 * tui/tui-layout.c (tui_set_layout): Update.
907
908 2019-08-20 Tom Tromey <tom@tromey.com>
909
910 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
911 Declare.
912 (tui_check_register_values): Don't declare.
913 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
914 from tui_check_register_values.
915 * tui/tui-hooks.c (tui_register_changed): Update.
916
917 2019-08-20 Tom Tromey <tom@tromey.com>
918
919 * tui/tui-regs.c (tui_reg_layout): Move later.
920 (tui_show_registers): Don't enable TUI mode or change layout.
921
922 2019-08-20 Tom Tromey <tom@tromey.com>
923
924 * tui/tui-regs.h (struct tui_data_item_window)
925 <~tui_data_item_window>: Remove.
926 <content>: Now a unique_xmalloc_ptr.
927 * tui/tui-regs.c (tui_register_format): Return a
928 unique_xmalloc_ptr.
929 (tui_get_register): Update.
930 (~tui_data_item_window): Remove.
931 (tui_data_window::display_registers_from, tui_display_register):
932 Update.
933 * tui/tui-io.h (tui_expand_tabs): Update.
934 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
935 Remove "col" parameter.
936
937 2019-08-20 Tom Tromey <tom@tromey.com>
938
939 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
940 field.
941 * tui/tui-regs.c (~tui_data_item_window): Update.
942
943 2019-08-20 Tom Tromey <tom@tromey.com>
944
945 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
946 earlier.
947
948 2019-08-20 Tom Tromey <tom@tromey.com>
949
950 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
951
952 2019-08-20 Tom Tromey <tom@tromey.com>
953
954 * tui/tui-source.h (struct tui_source_window): Update.
955 * tui/tui-regs.c (tui_show_registers): Update.
956 * tui/tui-disasm.h (struct tui_disasm_window): Update.
957 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
958 (NO_REGS_STRING): Remove defines.
959
960 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
961
962 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
963 unnecessary thread walk if remote doesn't support the packet.
964
965 2019-08-19 Tom Tromey <tromey@adacore.com>
966
967 * python/py-value.c (value_has_field): Fix indentation.
968
969 2019-08-19 Tom Tromey <tromey@adacore.com>
970
971 * printcmd.c (do_one_display, info_display_command): Update.
972 * block.h (contained_in): Return bool. Add allow_nested
973 parameter.
974 * block.c (contained_in): Return bool. Add allow_nested
975 parameter.
976
977 2019-08-19 Tom Tromey <tom@tromey.com>
978
979 * configure: Rebuild.
980 * configure.ac: Disallow the combination of -static-libstdc++ and
981 source highlight.
982 * source-cache.c (get_language_name): Handle rust.
983 (source_cache::get_source_lines): Ignore highlighting exceptions.
984
985 2019-08-16 Tom Tromey <tom@tromey.com>
986
987 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
988 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
989 (struct tui_source_window_base) <make_visible, refresh_window,
990 resize>: Remove methods.
991 <execution_info>: Remove field.
992 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
993 (tui_show_source_line, tui_source_window_base)
994 (~tui_source_window_base): Update.
995 (tui_source_window_base::resize)
996 (tui_source_window_base::make_visible)
997 (tui_source_window_base::refresh_window): Remove.
998 (tui_source_window_base::update_exec_info): Update.
999 * tui/tui-source.c (tui_source_window::set_contents): Update.
1000 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1001
1002 2019-08-16 Tom Tromey <tom@tromey.com>
1003
1004 * tui/tui-hooks.c (tui_remove_hooks): Don't set
1005 deprecated_query_hook.
1006
1007 2019-08-16 Tom Tromey <tom@tromey.com>
1008
1009 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1010 (tui_update_source_windows_with_line): Update.
1011 * tui/tui-source.h (struct tui_source_window)
1012 <show_symtab_source>: Declare.
1013 (tui_show_symtab_source): Don't declare.
1014 * tui/tui-source.c (tui_show_symtab_source): Rename from
1015 tui_show_symtab_source.
1016
1017 2019-08-16 Tom Tromey <tom@tromey.com>
1018
1019 * tui/tui-winsource.h (struct tui_source_window_base)
1020 <set_contents>: Declare.
1021 * tui/tui-winsource.c
1022 (tui_source_window_base::update_source_window_as_is): Update.
1023 * tui/tui-source.h (struct tui_source_window) <set_contents>:
1024 Declare.
1025 (tui_set_source_content): Don't declare.
1026 * tui/tui-source.c (tui_source_window::set_contents): Rename from
1027 tui_set_source_content.
1028 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1029 Declare.
1030 (tui_set_disassem_content): Don't declare.
1031 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1032 tui_set_disassem_content.
1033
1034 2019-08-16 Tom Tromey <tom@tromey.com>
1035
1036 * tui/tui-winsource.h (struct tui_source_window_base)
1037 <update_breakpoint_info>: Declare.
1038 (tui_update_breakpoint_info): Don't declare.
1039 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1040 (tui_update_all_breakpoint_info): Update.
1041 (tui_source_window_base::update_breakpoint_info): Rename from
1042 tui_update_breakpoint_info.
1043 (tui_source_window_base::update_exec_info): Update.
1044
1045 2019-08-16 Tom Tromey <tom@tromey.com>
1046
1047 * tui/tui-winsource.h (struct tui_source_window_base)
1048 <update_source_window>: Declare.
1049 (tui_update_source_window): Don't declare.
1050 * tui/tui-winsource.c
1051 (tui_source_window_base::update_source_window): Rename from
1052 tui_update_source_window.
1053 (tui_source_window_base::rerender): Update.
1054 * tui/tui-source.c (tui_source_window::maybe_update): Update.
1055 * tui/tui-disasm.c (tui_show_disassem)
1056 (tui_show_disassem_and_update_source)
1057 (tui_disasm_window::maybe_update): Update.
1058
1059 2019-08-16 Tom Tromey <tom@tromey.com>
1060
1061 * tui/tui-winsource.h (struct tui_source_window_base)
1062 <update_source_window_as_is>: Declare.
1063 (tui_update_source_window_as_is): Don't declare.
1064 * tui/tui-winsource.c (tui_update_source_window): Update
1065 (tui_source_window_base::update_source_window_as_is): Rename from
1066 tui_update_source_window_as_is.
1067 (tui_source_window_base::refill): Update.
1068 * tui/tui-source.c (tui_show_symtab_source): Update.
1069 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1070 Update.
1071
1072 2019-08-16 Tom Tromey <tom@tromey.com>
1073
1074 * tui/tui-winsource.h (tui_update_source_window)
1075 (tui_update_source_window_as_is): Remove "noerror" parameter.
1076 * tui/tui-winsource.c (tui_update_source_window)
1077 (tui_update_source_window_as_is): Remove "noerror" parameter.
1078 (tui_update_source_windows_with_addr)
1079 (tui_update_source_windows_with_line)
1080 (tui_source_window_base::rerender)
1081 (tui_source_window_base::refill): Update.
1082 * tui/tui-source.h (tui_set_source_content)
1083 (tui_show_symtab_source): Remove "noerror" parameter.
1084 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1085 parameter.
1086 (tui_show_symtab_source): Likewise.
1087 (tui_source_window::maybe_update): Update.
1088 * tui/tui-disasm.c (tui_show_disassem)
1089 (tui_show_disassem_and_update_source)
1090 (tui_disasm_window::do_scroll_vertical)
1091 (tui_disasm_window::maybe_update): Update.
1092
1093 2019-08-16 Tom Tromey <tom@tromey.com>
1094
1095 * tui/tui.c (tui_is_window_visible): Update.
1096 * tui/tui-wingeneral.c (tui_make_window)
1097 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1098 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1099 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1100 (tui_set_win_height_command, parse_scrolling_args): Update.
1101 * tui/tui-source.c (tui_source_window::style_changed): Update.
1102 * tui/tui-regs.c (tui_show_registers)
1103 (tui_data_window::first_data_item_displayed)
1104 (tui_data_window::delete_data_content_windows)
1105 (tui_check_register_values, tui_reg_command): Update.
1106 * tui/tui-disasm.c (tui_show_disassem): Update.
1107 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1108 method.
1109 <is_visible>: Remove field.
1110 * tui/tui-data.c (tui_next_win, tui_prev_win)
1111 (tui_delete_invisible_windows): Update.
1112
1113 2019-08-16 Tom Tromey <tom@tromey.com>
1114
1115 * tui/tui-winsource.h (struct tui_source_window_base)
1116 <m_has_locator>: Remove.
1117 * tui/tui-layout.c (show_source_disasm_command, show_data)
1118 (show_source_or_disasm_and_command): Update.
1119
1120 2019-08-16 Alan Hayward <alan.hayward@arm.com>
1121
1122 * NEWS (Other MI changes): New subsection.
1123 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1124 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1125 * arch-utils.c (default_get_pc_address_flags): New function.
1126 * arch-utils.h (default_get_pc_address_flags): New declaration.
1127 * gdbarch.sh: Add get_pc_address_flags.
1128 * gdbarch.c: Regenerate.
1129 * gdbarch.h: Likewise.
1130 * stack.c (print_pc): New function.
1131 (print_frame_info) (print_frame): Call print_pc.
1132
1133 2019-08-16 Tom de Vries <tdevries@suse.de>
1134
1135 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1136 print_objfile_section_info.
1137
1138 2019-08-15 Tom Tromey <tom@tromey.com>
1139
1140 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1141 calling update_cmdwin_start_line.
1142 * tui/tui-winsource.h (struct tui_source_window_base)
1143 <do_make_visible_with_new_height, set_new_height>: Don't declare.
1144 <rerender>: Declare.
1145 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1146 Call rerender.
1147 (tui_source_window_base::set_new_height): Remove.
1148 (tui_source_window_base::rerender): Rename from
1149 do_make_visible_with_new_height.
1150 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1151 resize method.
1152 (tui_win_info::make_invisible_and_set_new_height)
1153 (tui_win_info::make_visible_with_new_height): Remove.
1154 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1155 Declare.
1156 * tui/tui-stack.c (tui_locator_window::rerender): New method.
1157 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1158 do_make_visible_with_new_height>: Don't declare.
1159 <rerender>: Declare.
1160 * tui/tui-regs.c (tui_data_window::rerender): Rename from
1161 set_new_height.
1162 (tui_data_window::do_make_visible_with_new_height): Remove.
1163 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1164 call tui_show_locator_content.
1165 (tui_gen_win_info::resize): Call rerender.
1166 (show_source_or_disasm_and_command): Don't call
1167 tui_show_locator_content.
1168 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1169 method.
1170 (struct tui_win_info) <rerender>: Declare.
1171 <set_new_height, make_invisible_and_set_new_height,
1172 make_visible_with_new_height>: Don't declare.
1173 * tui/tui-data.c (tui_win_list::rerender): New method.
1174 * tui/tui-command.h (struct tui_cmd_window)
1175 <do_make_visible_with_new_height>: Don't declare.
1176 * tui/tui-command.c
1177 (tui_cmd_window::do_make_visible_with_new_height): Remove.
1178
1179 2019-08-15 Tom Tromey <tromey@adacore.com>
1180
1181 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1182 * ada-lang.c (ada_enum_name): Likewise.
1183
1184 2019-08-15 Christian Biesinger <cbiesinger@google.com>
1185
1186 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1187 leading underscore.
1188 (GdbOutputErrorFile): Likewise.
1189 (global scope): Adjust constructor calls to GdbOutput{,Error}File
1190 accordingly.
1191 (execute_unwinders): Rename to have a leading underscore.
1192 (auto_load_packages): Likewise.
1193 (global scope): Adjust call to auto_load_packages accordingly.
1194 (GdbSetPythonDirectory): Likewise.
1195 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1196 instead of execute_unwinders.
1197
1198 2019-08-15 Tom Tromey <tom@tromey.com>
1199
1200 * tui/tui-layout.c (show_layout, show_source_disasm_command)
1201 (show_data): Don't change window visibility.
1202 (tui_gen_win_info::resize): Remove special case for command
1203 window. Use wresize, when available.
1204 (show_source_or_disasm_and_command): Don't change window
1205 visibility.
1206 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1207 <make_visible>: New method.
1208 * tui/tui-command.c (tui_cmd_window::resize): New method.
1209
1210 2019-08-15 Tom Tromey <tom@tromey.com>
1211
1212 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1213 (struct tui_source_windows): New.
1214 * tui/tui-winsource.c (tui_display_main): Update.
1215 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1216 (new_height_ok, parse_scrolling_args): Update.
1217 * tui/tui-layout.c (show_layout, show_data): Update.
1218 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1219 (tui_add_to_source_windows): Don't declare.
1220 * tui/tui-data.c (source_windows, tui_source_windows)
1221 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1222
1223 2019-08-15 Tom Tromey <tom@tromey.com>
1224
1225 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1226 Rename from reset.
1227 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1228 * tui/tui-layout.c (show_source_disasm_command, show_data):
1229 Update.
1230 (tui_gen_win_info::resize): Rename.
1231 (show_source_or_disasm_and_command): Update.
1232 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1233 reset.
1234
1235 2019-08-15 Tom Tromey <tom@tromey.com>
1236
1237 * tui/tui-stack.c (tui_initialize_static_data): Remove.
1238 * tui/tui-interp.c (tui_interp::init): Don't call
1239 tui_initialize_static_data.
1240 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1241
1242 2019-08-15 Tom Tromey <tom@tromey.com>
1243
1244 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1245 examine tui_win_list.
1246
1247 2019-08-15 Tom Tromey <tom@tromey.com>
1248
1249 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1250 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1251 tui_clear_source_content.
1252 (tui_clear_source_content): Remove.
1253 (tui_source_window_base::do_erase_source_content): Hoist call to
1254 content.clear().
1255 * tui/tui-stack.c (tui_show_frame_info): Don't call
1256 tui_clear_source_content.
1257
1258 2019-08-15 Tom Tromey <tom@tromey.com>
1259
1260 * tui/tui-winsource.h (struct tui_source_window_base)
1261 <do_erase_source_content>: New method.
1262 <erase_source_content>: New method.
1263 (tui_erase_source_content): Don't declare.
1264 * tui/tui-winsource.c (tui_clear_source_content): Update.
1265 (tui_source_window_base::do_erase_source_content): Rename from
1266 tui_erase_source_content.
1267 (tui_source_window_base::show_source_content): Update.
1268 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1269 * tui/tui-source.h (struct tui_source_window)
1270 <erase_source_content>: New method.
1271 * tui/tui-disasm.h (struct tui_disasm_window)
1272 <erase_source_content>: New method.
1273
1274 2019-08-15 Tom Tromey <tom@tromey.com>
1275
1276 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1277 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1278 constructor.
1279 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1280 * tui/tui-source.c (tui_set_source_content): Update.
1281 * tui/tui-disasm.c (tui_set_disassem_content): Update.
1282
1283 2019-08-15 Tom Tromey <tom@tromey.com>
1284
1285 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1286 * tui/tui-winsource.c (tui_line_is_displayed): Move to
1287 tui-source.c.
1288 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1289 Declare.
1290 * tui/tui-source.c (tui_source_window::line_is_displayed): New
1291 method.
1292 (tui_source_window::maybe_update): Update.
1293
1294 2019-08-15 Tom Tromey <tom@tromey.com>
1295
1296 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1297 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1298 tui-disasm.c.
1299 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1300 Declare.
1301 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1302 method.
1303 (tui_disasm_window::maybe_update): Update.
1304
1305 2019-08-15 Tom Tromey <tom@tromey.com>
1306
1307 * tui/tui-winsource.h (struct tui_source_window_base)
1308 <maybe_update>: Declare.
1309 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1310 method.
1311 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1312 Declare.
1313 * tui/tui-source.c (tui_source_window::maybe_update): New method.
1314 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1315 Declare.
1316 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1317
1318 2019-08-15 Tom Tromey <tom@tromey.com>
1319
1320 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1321
1322 2019-08-15 Tom Tromey <tom@tromey.com>
1323
1324 * tui/tui-wingeneral.c: Include tui-stack.h.
1325 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1326 (struct tui_locator_window): Move from tui-data.h.
1327 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1328 (tui_initialize_static_data): Move from tui-data.c.
1329 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1330 (struct tui_locator_window): Move to tui-stack.c.
1331 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1332 (tui_initialize_static_data): Move to tui-stack.c.
1333
1334 2019-08-15 Tom Tromey <tom@tromey.com>
1335
1336 * tui/tui-layout.c (show_source_disasm_command)
1337 (show_source_or_disasm_and_command): Use make_visible method, not
1338 tui_make_window.
1339 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1340 Remove.
1341
1342 2019-08-15 Tom Tromey <tom@tromey.com>
1343
1344 * tui/tui-wingeneral.h (tui_make_window): Update.
1345 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1346 parameter.
1347 (tui_gen_win_info::make_visible): Update.
1348 * tui/tui-regs.c (tui_data_window::display_registers_from):
1349 Update.
1350 * tui/tui-layout.c (show_source_disasm_command)
1351 (show_source_or_disasm_and_command): Update.
1352 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1353 (enum tui_box): Remove.
1354 (struct tui_win_info) <can_box>: New method.
1355 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1356 method.
1357
1358 2019-08-15 Tom de Vries <tdevries@suse.de>
1359
1360 * linux-nat-trad.c: Include gdbarch.h.
1361
1362 2019-08-14 Alan Hayward <alan.hayward@arm.com>
1363
1364 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1365 register sizes.
1366
1367 2019-08-14 Tom Tromey <tromey@adacore.com>
1368
1369 * darwin-nat.c: Include gdbarch.h.
1370 * darwin-nat-info.c: Include gdbarch.h.
1371
1372 2019-08-13 Tom Tromey <tom@tromey.com>
1373
1374 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1375 Remove.
1376 * tui/tui-data.c (tui_initialize_static_data): Update.
1377
1378 2019-08-13 Tom Tromey <tom@tromey.com>
1379
1380 * tui/tui-winsource.h (struct tui_exec_info_window)
1381 <~tui_exec_info_window, maybe_allocate_content, get_content,
1382 m_content>: Remove.
1383 (struct tui_source_window_base) <set_exec_info_content,
1384 show_exec_info_content>: Don't declare.
1385 * tui/tui-winsource.c
1386 (tui_exec_info_window::maybe_allocate_content): Remove.
1387 (tui_source_window_base::update_exec_info): Rename from
1388 set_exec_info_content.
1389 (tui_source_window_base::show_exec_info_content)
1390 (tui_source_window_base::update_exec_info): Remove.
1391
1392 2019-08-13 Tom Tromey <tom@tromey.com>
1393
1394 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1395 declare.
1396 * tui/tui-winsource.c (tui_update_source_window_as_is)
1397 (tui_update_source_windows_with_addr, tui_erase_source_content):
1398 Update.
1399 (tui_clear_exec_info_content): Remove.
1400
1401 2019-08-13 Tom Tromey <tom@tromey.com>
1402
1403 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1404 declare.
1405 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1406 call tui_erase_exec_info_content.
1407 (tui_clear_exec_info_content): Rename from
1408 tui_erase_exec_info_content.
1409 (tui_clear_exec_info_content): Delete.
1410
1411 2019-08-13 Tom Tromey <tom@tromey.com>
1412
1413 * tui/tui-winsource.h (struct tui_source_window_base)
1414 <show_exec_info_content>: Declare.
1415 (tui_show_exec_info_content): Don't declare.
1416 * tui/tui-winsource.c
1417 (tui_source_window_base::show_exec_info_content): Rename from
1418 tui_show_exec_info_content.
1419 (tui_source_window_base::update_exec_info): Update.
1420
1421 2019-08-13 Tom Tromey <tom@tromey.com>
1422
1423 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1424 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1425 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1426 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1427 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1428 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1429 ... here.
1430
1431 2019-08-13 Tom Tromey <tom@tromey.com>
1432
1433 * tui/tui-winsource.h (struct tui_source_window_base)
1434 <update_exec_info>: Declare.
1435 (tui_update_exec_info): Don't declare.
1436 * tui/tui-winsource.c (tui_update_source_window_as_is)
1437 (tui_source_window_base::refresh_all)
1438 (tui_update_all_breakpoint_info): Update.
1439 (tui_source_window_base::update_exec_info): Rename from
1440 tui_update_exec_info.
1441 * tui/tui-stack.c (tui_show_frame_info): Update.
1442
1443 2019-08-13 Tom Tromey <tom@tromey.com>
1444
1445 * tui/tui-winsource.h (struct tui_source_window_base)
1446 <set_exec_info_content>: Declare.
1447 (tui_set_exec_info_content): Don't declare.
1448 * tui/tui-winsource.c
1449 (tui_source_window_base::set_exec_info_content): Rename from
1450 tui_set_exec_info_content.
1451 (tui_update_exec_info): Update.
1452
1453 2019-08-13 Tom Tromey <tom@tromey.com>
1454
1455 * tui/tui-winsource.h (struct tui_source_window_base)
1456 <show_source_content>: Declare.
1457 (tui_show_source_content): Don't declare.
1458 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1459 (tui_source_window_base::show_source_content): Rename from
1460 tui_show_source_content.
1461 (tui_source_window_base::refresh_all): Update.
1462 * tui/tui-layout.c (show_source_disasm_command)
1463 (show_source_or_disasm_and_command): Update.
1464
1465 2019-08-13 Tom Tromey <tom@tromey.com>
1466
1467 * tui/tui-winsource.c (tui_erase_source_content)
1468 (tui_show_source_content, tui_source_window_base::refresh_all):
1469 Update.
1470 * tui/tui-wingeneral.h
1471 (tui_check_and_display_highlight_if_needed): Don't declare.
1472 * tui/tui-wingeneral.c
1473 (tui_win_info::check_and_display_highlight_if_needed): Rename from
1474 check_and_display_highlight_if_needed.
1475 * tui/tui-win.c (tui_rehighlight_all)
1476 (tui_win_info::make_visible_with_new_height): Update.
1477 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1478 (tui_data_window::erase_data_content)
1479 (tui_data_window::display_all_data): Update.
1480 * tui/tui-data.h (struct tui_win_info)
1481 <check_and_display_highlight_if_needed>: Declare.
1482
1483 2019-08-13 Tom Tromey <tom@tromey.com>
1484
1485 * tui/tui-win.c (tui_resize_all): Call
1486 tui_delete_invisible_windows.
1487 * tui/tui-layout.c (show_layout): Call
1488 tui_delete_invisible_windows.
1489 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1490 * tui/tui-data.c (tui_delete_invisible_windows): New function.
1491
1492 2019-08-13 Tom Tromey <tom@tromey.com>
1493
1494 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
1495 tui_add_win_to_layout.
1496
1497 2019-08-13 Tom Tromey <tom@tromey.com>
1498
1499 * tui/tui-layout.h (tui_default_win_height): Don't declare.
1500 * tui/tui-layout.c (tui_default_win_height): Now static.
1501
1502 2019-08-13 Tom Tromey <tom@tromey.com>
1503
1504 * tui/tui-layout.c (show_layout): Unify all layout cases into a
1505 single switch.
1506 (show_source_disasm_command, show_source_or_disasm_and_command):
1507 Don't check current layout.
1508
1509 2019-08-13 Tom Tromey <tom@tromey.com>
1510
1511 * tui/tui-wingeneral.c (make_all_visible): Remove.
1512 (tui_make_all_invisible): Simplify.
1513 * tui/tui-layout.c (tui_make_all_invisible): Move from
1514 tui-wingeneral.c; simplify.
1515 (show_layout): Hoist call to tui_make_all_invisible.
1516 (show_data): Don't call tui_make_all_invisible.
1517
1518 2019-08-13 Tom Tromey <tom@tromey.com>
1519
1520 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1521 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1522
1523 2019-08-13 Tom Tromey <tom@tromey.com>
1524
1525 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1526 tui-data.c.
1527 (show_source_disasm_command, show_data)
1528 (show_source_or_disasm_and_command): Don't use
1529 tui_set_current_layout_to.
1530 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1531 * tui/tui-data.c (current_layout, tui_current_layout): Move to
1532 tui-layout.c.
1533 (tui_set_current_layout_to): Remove.
1534
1535 2019-08-13 Tom Tromey <tom@tromey.com>
1536
1537 * tui/tui-layout.c (tui_set_layout): Update.
1538 * tui/tui-data.h (struct tui_layout_def): Remove.
1539 (tui_layout_def): Don't declare.
1540 * tui/tui-data.c (layout_def): Remove.
1541 (tui_layout_def): Remove.
1542
1543 2019-08-13 Tom Tromey <tom@tromey.com>
1544
1545 * tui/tui-winsource.h (struct tui_source_window_base)
1546 <clear_detail>: No longer "override".
1547 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1548 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1549 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1550 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1551 Remove.
1552 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1553
1554 2019-08-13 Tom Tromey <tromey@adacore.com>
1555
1556 * tracepoint.c: Don't include readline.h or history.h.
1557
1558 2019-08-12 Tom Tromey <tom@tromey.com>
1559
1560 * configure: Rebuild.
1561 * configure.ac: Check for readline 7.
1562 * NEWS: Mention readline 7 requirement.
1563 * README: Update.
1564
1565 2019-08-12 Tom Tromey <tom@tromey.com>
1566
1567 * mingw-hdep.c (gdb_select): Remove readline hack.
1568
1569 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
1570
1571 * blockframe.c (find_pc_partial_function): Set *block to nullptr
1572 when the function fails.
1573
1574 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
1575
1576 * s390-tdep.c (s390_type_align): New function.
1577 (s390_gdbarch_init): Set it as type_align gdbarch method.
1578
1579 2019-08-09 Tom de Vries <tdevries@suse.de>
1580
1581 PR gdb/24591
1582 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1583 pc_low with relocation offset.
1584
1585 2019-08-07 Tom Tromey <tromey@adacore.com>
1586
1587 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1588 (print_frame_args): Update.
1589 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1590 Update.
1591 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1592 * frame.h (struct frame_arg): Add initializers.
1593 <error>: Now a unique_xmalloc_ptr.
1594
1595 2019-08-07 Alan Hayward <alan.hayward@arm.com>
1596
1597 * NEWS: Expand the Pointer Authentication entry.
1598 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1599 (aarch64_frame_unmask_lr): ... to this.
1600 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1601 Call aarch64_frame_unmask_lr.
1602 * frame.c (struct frame_info): Add "masked" variable.
1603 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1604 (fprint_frame): Check for masked pc.
1605 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1606 declarations.
1607 * python/py-framefilter.c (py_print_frame): Check for masked pc.
1608 * stack.c (print_frame): Check for masked pc.
1609
1610 2019-08-06 Tom Tromey <tom@tromey.com>
1611
1612 * stabsread.c (patch_block_stabs, read_one_struct_field)
1613 (read_enum_type): Use obstack_strndup.
1614 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1615 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1616 * dwarf2read.c (guess_full_die_structure_name)
1617 (anonymous_struct_prefix): Use obstack_strndup.
1618 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1619 * c-exp.y (yylex): Use obstack_strndup.
1620 * ada-exp.y (write_object_renaming, write_ambiguous_var)
1621 (write_var_or_type): Use obstack_strndup.
1622
1623 2019-08-06 Tom Tromey <tom@tromey.com>
1624
1625 * symfile.c (reread_symbols): Use obstack_strdup.
1626 * stabsread.c (read_type): Use obstack_strdup.
1627 * gdb_obstack.h (obstack_strdup): New overload.
1628 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1629 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1630 (dwarf2_canonicalize_name): Use obstack_strdup.
1631 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1632 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1633 Use obstack_strdup.
1634
1635 2019-08-06 Tom Tromey <tom@tromey.com>
1636
1637 * gdb_obstack.h (obstack_strdup): Define.
1638 * gdb_obstack.c (obstack_strdup): Don't define.
1639
1640 2019-08-06 Tom Tromey <tom@tromey.com>
1641
1642 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1643 obstack_strdup.
1644 * typeprint.c (typedef_hash_table::find_global_typedef): Use
1645 obstack_strdup.
1646 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1647 * stabsread.c (common_block_start): Use obstack_strdup.
1648 * objfiles.c (set_objfile_main_name, objfile): Use
1649 obstack_strdup.
1650 * namespace.c (add_using_directive): Use obstack_strdup.
1651 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1652 * jit.c (finalize_symtab): Use obstack_strdup.
1653 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1654 (guess_partial_die_structure_name, partial_die_info::fixup)
1655 (dwarf2_name): Use obstack_strdup.
1656 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1657 obstack_strdup.
1658 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1659 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1660 obstack_strdup.
1661 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1662
1663 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1664
1665 * unittests/help-doc-selftests.c: New file.
1666 * Makefile.in: Add the new file.
1667
1668 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1669
1670 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1671 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
1672 the full first line, except when FOR_VALUE_PREFIX. In this case,
1673 the trailing '.' is not output, and the first character is uppercased.
1674 (print_help_for_command): Update call to print_doc_line.
1675 (print_doc_of_command): Likewise.
1676 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1677 * cli/cli-option.c (append_indented_doc): Do not append newline.
1678 (build_help_option): Append newline after first appended_indented_doc
1679 only if a second call is done.
1680 (build_help): Append 2 new lines before each option, except the first
1681 one.
1682 * compile/compile.c (_initialize_compile): Add new lines after
1683 %OPTIONS%, when not at the end of the help.
1684 Change help doc or code
1685 producing the help doc to respect the invariants.
1686 * maint-test-options.c (_initialize_maint_test_options): Likewise.
1687 Also removed the new line after 'Options:', as all other commands
1688 do not put an empty line between 'Options:' and the first option.
1689 * printcmd.c (_initialize_printcmd): Likewise.
1690 * stack.c (_initialize_stack): Likewise.
1691 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1692 incorrectly telling COMMAND is optional.
1693 * ada-lang.c (_initialize_ada_language): Change help doc or code
1694 producing the help doc to respect the invariants.
1695 * ada-tasks.c (_initialize_ada_tasks): Likewise.
1696 * breakpoint.c (_initialize_breakpoint): Likewise.
1697 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1698 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1699 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1700 * cli/cli-style.c (cli_style_option::add_setshow_commands,
1701 _initialize_cli_style): Likewise.
1702 * corelow.c (core_target_info): Likewise.
1703 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1704 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1705 * filesystem.c (_initialize_filesystem): Likewise.
1706 * frame.c (_initialize_frame): Likewise.
1707 * gnu-nat.c (add_task_commands): Likewise.
1708 * infcall.c (_initialize_infcall): Likewise.
1709 * infcmd.c (_initialize_infcmd): Likewise.
1710 * interps.c (_initialize_interpreter): Likewise.
1711 * language.c (_initialize_language): Likewise.
1712 * linux-fork.c (_initialize_linux_fork): Likewise.
1713 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1714 * maint.c (_initialize_maint_cmds): Likewise.
1715 * memattr.c (_initialize_mem): Likewise.
1716 * printcmd.c (_initialize_printcmd): Likewise.
1717 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1718 _RegEx): Likewise.
1719 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1720 * record-btrace.c (_initialize_record_btrace): Likewise.
1721 * record-full.c (_initialize_record_full): Likewise.
1722 * record.c (_initialize_record): Likewise.
1723 * regcache-dump.c (_initialize_regcache_dump): Likewise.
1724 * regcache.c (_initialize_regcache): Likewise.
1725 * remote.c (add_packet_config_cmd, init_remote_threadtests,
1726 _initialize_remote): Likewise.
1727 * ser-tcp.c (_initialize_ser_tcp): Likewise.
1728 * serial.c (_initialize_serial): Likewise.
1729 * skip.c (_initialize_step_skip): Likewise.
1730 * source.c (_initialize_source): Likewise.
1731 * stack.c (_initialize_stack): Likewise.
1732 * symfile.c (_initialize_symfile): Likewise.
1733 * symtab.c (_initialize_symtab): Likewise.
1734 * target-descriptions.c (_initialize_target_descriptions): Likewise.
1735 * top.c (init_main): Likewise.
1736 * tracefile-tfile.c (tfile_target_info): Likewise.
1737 * tracepoint.c (_initialize_tracepoint): Likewise.
1738 * tui/tui-win.c (_initialize_tui_win): Likewise.
1739 * utils.c (add_internal_problem_command): Likewise.
1740 * valprint.c (value_print_option_defs): Likewise.
1741
1742 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
1743
1744 PR build/24886
1745 * configure.ac: Drop enable-libmcheck support.
1746 * configure, config.in: Rebuild.
1747 * libmcheck.m4: Remove.
1748 * acinclude.m4: Don't include it.
1749 * Makefile.in: Don't distribute it.
1750 * top.c (print_gdb_configuration): Don't mention it.
1751
1752 2019-08-06 Tom Tromey <tom@tromey.com>
1753
1754 * utils.c (set_output_style): Sometimes pass stream to
1755 emit_style_escape.
1756 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1757 * record-btrace.c (btrace_insn_history): Update.
1758 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1759 method.
1760 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1761 Update initializers.
1762 <m_uiout>: New field.
1763 <m_di>: Move lower.
1764 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1765 Remove "uiout" parameter.
1766 (dump_insns): Update.
1767 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1768 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1769
1770 2019-08-06 Christian Biesinger <cbiesinger@google.com>
1771
1772 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1773 (error_in_psymtab_expansion): Likewise.
1774 (lookup_symbol_via_quick_fns): Likewise.
1775 (basic_lookup_transparent_type_quick): Likewise.
1776 (basic_lookup_transparent_type_1): Likewise.
1777
1778 2019-08-06 Tom Tromey <tromey@adacore.com>
1779
1780 * source.c (last_source_error): Now bool.
1781 (print_source_lines_base): Make "noprint" bool. Only open
1782 source file when last_source_visited changes.
1783
1784 2019-08-06 Tom Tromey <tromey@adacore.com>
1785
1786 * annotate.c (annotate_source_line): Use g_source_cache.
1787 * source-cache.c (source_cache::get_plain_source_lines): Change
1788 parameters. Populate m_offset_cache.
1789 (source_cache::ensure): New method.
1790 (source_cache::get_line_charpos): New method.
1791 (extract_lines): Move lower. Change parameters.
1792 (source_cache::get_source_lines): Move lower.
1793 * source-cache.h (class source_cache): Update comment.
1794 <get_line_charpos>: New method.
1795 <get_source_lines>: Update comment.
1796 <clear>: Clear m_offset_cache.
1797 <get_plain_source_lines>: Change parameters.
1798 <ensure>: New method
1799 <m_offset_cache>: New member.
1800 * source.c (forget_cached_source_info_for_objfile): Update.
1801 (info_source_command): Use g_source_cache.
1802 (find_source_lines, open_source_file_with_line_charpos): Remove.
1803 (print_source_lines_base, search_command_helper): Use g_source_cache.
1804 * source.h (open_source_file_with_line_charpos): Don't declare.
1805 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1806 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1807 Use g_source_cache.
1808
1809 2019-08-06 Tom Tromey <tromey@adacore.com>
1810
1811 * source-cache.c (source_cache::get_plain_source_lines):
1812 Remove "first_line" and "last_line" parameters.
1813 (source_cache::get_source_lines): Cache plain text.
1814 * source-cache.h (class source_cache)
1815 <get_plain_source_lines>: Update.
1816
1817 2019-08-06 Tom Tromey <tromey@adacore.com>
1818
1819 * source-cache.c (extract_lines): No longer a method.
1820 Changed type of parameter. Include final newline.
1821 (selftests::extract_lines_test): New function.
1822 (_initialize_source_cache): Likewise.
1823 * source-cache.h (class source_cache)
1824 <extract_lines>: Don't declare.
1825
1826 2019-08-06 Tom Tromey <tromey@adacore.com>
1827
1828 * breakpoint.c (init_breakpoint_sal): Update.
1829 (breakpoint): Update.
1830 * breakpoint.h (struct breakpoint) <filter>: Now a
1831 unique_xmalloc_ptr.
1832
1833 2019-08-05 Christian Biesinger <cbiesinger@google.com>
1834
1835 * NEWS: Mention dictionary access on blocks.
1836 * python/py-block.c (blpy_getitem): New function.
1837 (block_object_as_mapping): New struct.
1838 (block_object_type): Use new struct for tp_as_mapping field.
1839
1840 2019-08-05 Christian Biesinger <cbiesinger@google.com>
1841
1842 * objfiles.h (objfile): Add a comment describing partial symbols.
1843
1844 2019-08-05 Tom Tromey <tromey@adacore.com>
1845
1846 * compile/compile.c (_initialize_compile): Use _(), not N_().
1847 * thread.c (_initialize_thread): Use _(), not N_().
1848 * stack.c (_initialize_stack): Use _(), not N_().
1849 * printcmd.c (_initialize_printcmd): Use _(), not N_().
1850
1851 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
1852
1853 * dwarf2read.c (struct dw2_symtab_iterator):
1854 <want_specific_block>: Remove.
1855 <block_index>: Change type to gdb::optional.
1856 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1857 change type of BLOCK_INDEX parameter to gdb::optional.
1858 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1859 (dw2_lookup_symbol): Don't pass argument for
1860 WANT_SPECIFIC_BLOCK.
1861 (dw2_expand_symtabs_for_function): Don't pass argument for
1862 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1863 (class dw2_debug_names_iterator)
1864 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1865 parameter, change BLOCK_INDEX type to gdb::optional.
1866 <m_want_specific_block>: Remove.
1867 <m_block_index>: Change type to gdb::optional.
1868 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1869 gdb::optional. Re-write in function of gdb::optional.
1870 (dw2_debug_names_lookup_symbol): Don't pass argument for
1871 WANT_SPECIFIC_BLOCK.
1872 (dw2_debug_names_expand_symtabs_for_function): Don't pass
1873 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1874 BLOCK_INDEX.
1875
1876 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1877
1878 * NEWS: Mention changes to "info sources" command.
1879
1880 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1881
1882 * symtab.c (filename_partial_match_opts): New struct type.
1883 (struct output_source_filename_data): New members
1884 regexp, c_regexp, partial_match.
1885 (output_source_filename): Use new members to decide to print file.
1886 (info_sources_option_defs): New variable.
1887 (make_info_sources_options_def_group, print_info_sources_header,
1888 info_sources_command_completer):
1889 New functions.
1890 (info_sources_command): Read new optional arguments.
1891 (_initialize_symtab): Update info sources help.
1892
1893 2019-08-02 Alexandre Oliva <oliva@adacore.com>
1894
1895 * ada-lang.c (exception_support_info_v0): Renamed from...
1896 (default_exception_support_info): ... this. Create new
1897 definition for v1.
1898 (ada_has_this_exception_support): Look up catch_handlers_sym.
1899 (ada_exception_support_info_sniffer): Try v0 after default.
1900
1901 2019-08-01 Tom Tromey <tromey@adacore.com>
1902
1903 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1904 gdbarch.h.
1905
1906 2019-08-01 Christian Biesinger <cbiesinger@google.com>
1907
1908 * s12z-tdep.c: Fix include path for s12z-opc.h.
1909
1910 2019-08-01 Alan Hayward <alan.hayward@arm.com>
1911
1912 * NEWS: Require GNU make 3.82.
1913
1914 2019-07-16 Tom Tromey <tom@tromey.com>
1915
1916 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1917 declare.
1918
1919 2019-07-30 Tom Tromey <tromey@adacore.com>
1920
1921 * block.c (contained_in): Remove BLOCK_FUNCTION check.
1922
1923 2019-07-30 Kevin Buettner <kevinb@redhat.com>
1924
1925 * printcmd.c (print_address_symbolic): Print negative offsets.
1926 (build_address_symbolic): Force signed arithmetic when computing
1927 offset.
1928
1929 2019-07-30 Christian Biesinger <cbiesinger@google.com>
1930
1931 PR/24474: Add a function to lookup static variables.
1932 * NEWS: Mention this new function.
1933 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1934 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1935 * python/python.c (python_GdbMethods): Add new function.
1936
1937 2019-07-29 Christian Biesinger <cbiesinger@google.com>
1938
1939 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1940 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1941 (objfpy_lookup_static_symbol): New function.
1942 (objfile_object_methods): Add new functions.
1943
1944 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1945
1946 * NEWS: Mention 'set|show print frame-info'. Mention new
1947 'presence' value for 'frame-arguments'. Mention new '-frame-info'
1948 backtrace argument. Mention that python frame filtering code
1949 is now consistent with what 'backtrace' command prints.
1950
1951 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1952
1953 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1954 comments.
1955 (print_frame_info_auto, print_frame_info_source_line,
1956 print_frame_info_location, print_frame_info_source_and_location,
1957 print_frame_info_location_and_address, print_frame_info_short_location):
1958 New declarations.
1959 (struct frame_print_options): New member print_frame_info.
1960 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1961 * stack.h (get_user_print_what_frame_info): New declaration.
1962 (frame_show_address): New declaration.
1963 * stack.c (print_frame_arguments_choices): New value 'presence'.
1964 (print_frame_info_auto, print_frame_info_source_line,
1965 print_frame_info_location, print_frame_info_source_and_location,
1966 print_frame_info_location_and_address, print_frame_info_short_location,
1967 print_frame_info_choices, print_frame_info_print_what): New definitions.
1968 (print_frame_args): Only print dots for args if print frame-arguments
1969 is 'presence'.
1970 (frame_print_option_defs): New element for "frame-info".
1971 (get_user_print_what_frame_info): New function.
1972 (frame_show_address): Make non static. Move comment to stack.h.
1973 (print_frame_info_to_print_what): New function.
1974 (print_frame_info): Update comment. Use fp_opts.print_frame_info
1975 to decide what to print.
1976 (backtrace_command_1): Handle the new print_frame_arguments_presence
1977 value.
1978 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1979 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1980 (py_print_frame): In non-mi mode, use LOCATION as default for
1981 print_what, similarly to frame information printed directly by
1982 backtrace command. Handle frame-info user option in non MI mode.
1983
1984 2019-07-27 Kevin Buettner <kevinb@redhat.com>
1985
1986 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1987 Add case for debugging 32-bit target on 64-bit host. Revise
1988 comment.
1989
1990 2019-07-27 Kevin Buettner <kevinb@redhat.com>
1991
1992 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1993 instead of find_function_entry_range_from_pc.
1994
1995 2019-07-27 Kevin Buettner <kevinb@redhat.com>
1996
1997 * stack.c (find_frame_funname): Remove code which preferred
1998 minsym over symtab sym in "certain pathological cases".
1999
2000 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2001 parameter. Change type of "do_demangle" to bool.
2002 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2003 Pass suitable "prefer_sym_over_minsym" flag to
2004 build_address_symbolic(). Don't output "+" for negative offsets.
2005 * printcmd.c (print_address_symbolic): Update invocation of
2006 build_address_symbolic to include a "prefer_sym_over_minsym"
2007 flag.
2008 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2009 Restrict cases in which use of minimal symbol is preferred to that
2010 of a found symbol. Update comments.
2011
2012 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2013 for entry pc when entry pc is out of range for that FDE.
2014
2015 2019-07-26 Brian Callahan <bcallah@openbsd.org>
2016
2017 PR gdb/24839:
2018 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2019 type.
2020
2021 2019-07-25 Christian Biesinger <cbiesinger@google.com>
2022
2023 * python/py-objfile.c (add_separate_debug_file): Fix comment about
2024 this function's Python signature.
2025
2026
2027 2019-07-24 Christian Biesinger <cbiesinger@google.com>
2028
2029 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2030 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2031 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2032 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2033 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2034
2035
2036 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
2037
2038 * h8300-tdep.c (h8300_register_name_common): New.
2039 h8300_register_name): Use h8300_register_name_common.
2040 (h8300s_register_name): Likewise.
2041 (h8300sx_register_name): Likewise.
2042 (h8300h_register_nam): New.
2043 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2044
2045
2046 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
2047
2048 * arm-tdep.c (arm_skip_cmse_entry): New function.
2049 (arm_is_sgstubs_section): New function.
2050 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2051
2052 2019-07-22 Tom Tromey <tom@tromey.com>
2053
2054 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2055 Don't self-assign.
2056
2057 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2058
2059 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2060 type_print.
2061
2062 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2063
2064 * symtab.c (search_symbols): Adjust msymbol matching type arrays
2065 so that GDB doesn't match any msymbols when searching in the
2066 TYPES_DOMAIN.
2067 (print_symbol_info): Print using typedef_print or type_print based
2068 on the type of the symbol. Add updated FIXME comment moved from...
2069 (_initialize_symtab): ... move and update FIXME comment to above.
2070
2071 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2072
2073 * NEWS: Mention adding -q option to "info types".
2074 * symtab.c (struct info_types_options): New struct.
2075 (info_types_options_defs): New variable.
2076 (make_info_types_options_def_group): New function.
2077 (info_types_command): Use gdb::option framework to parse options.
2078 (info_types_command_completer): New function.
2079 (_initialize_symtab): Extend the help text on "info types" and
2080 register command completer.
2081
2082 2019-07-21 Christian Biesinger <cbiesinger@google.com>
2083
2084 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2085 (lookup_symbol_in_objfile): Change int to block_enum and add a
2086 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2087
2088 2019-07-20 Christian Biesinger <cbiesinger@google.com>
2089
2090 * MAINTAINERS (Write After Approval): Add self.
2091
2092 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
2093
2094 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2095 instruction to the dummy code region.
2096
2097 2019-07-19 Tom Tromey <tromey@adacore.com>
2098
2099 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2100 (ARGSUSED, PARAMS, __func__): Remove rules.
2101
2102 2019-07-19 Alan Hayward <alan.hayward@arm.com>
2103
2104 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2105 * features/arm/arm-with-iwmmxt.c: Remove.
2106 * features/arm/arm-with-iwmmxt.xml: Remove.
2107 * features/arm/arm-with-m-fpa-layout.c: Remove.
2108 * features/arm/arm-with-m-fpa-layout.xml: Remove.
2109 * features/arm/arm-with-m-vfp-d16.c: Remove.
2110 * features/arm/arm-with-m-vfp-d16.xml: Remove.
2111 * features/arm/arm-with-m.c: Remove.
2112 * features/arm/arm-with-m.xml: Remove.
2113 * features/arm/arm-with-neon.c: Remove.
2114 * features/arm/arm-with-neon.xml: Remove.
2115 * features/arm/arm-with-vfpv2.c: Remove.
2116 * features/arm/arm-with-vfpv2.xml: Remove.
2117 * features/arm/arm-with-vfpv3.c: Remove.
2118 * features/arm/arm-with-vfpv3.xml: Remove.
2119
2120 2019-07-19 Alan Hayward <alan.hayward@arm.com>
2121
2122 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2123
2124 2019-07-19 Alan Hayward <alan.hayward@arm.com>
2125
2126 * arch/aarch32.c (aarch32_create_target_description): Create
2127 target descriptions using features.
2128 * arch/arm.c (arm_create_target_description)
2129 (arm_create_mprofile_target_description): Likewise.
2130 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2131
2132 2019-07-19 Alan Hayward <alan.hayward@arm.com>
2133
2134 * Makefile.in: Add new files.
2135 * aarch32-tdep.c: New file.
2136 * aarch32-tdep.h: New file.
2137 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2138 Call aarch32_read_description.
2139 * arch/aarch32.c: New file.
2140 * arch/aarch32.h: New file.
2141 * arch/arm.c (arm_create_target_description)
2142 (arm_create_mprofile_target_description): New function.
2143 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2144 (arm_create_target_description)
2145 (arm_create_mprofile_target_description): New declaration.
2146 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2147 read_description functions.
2148 * arm-linux-nat.c (arm_linux_nat_target::read_description):
2149 Likewise.
2150 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2151 * arm-tdep.c (tdesc_arm_list): New variable.
2152 (arm_register_g_packet_guesses): Call create description functions.
2153 (arm_read_description) (arm_read_mprofile_description): New
2154 function.
2155 * arm-tdep.h (arm_read_description)
2156 (arm_read_mprofile_description): Add declaration.
2157 * configure.tgt: Add new files.
2158
2159 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
2160
2161 * top.c (new_ui_command): Open specified terminal just once.
2162
2163 2019-07-18 Tom Tromey <tromey@adacore.com>
2164
2165 * symtab.c (main_name): Constify return type.
2166 * symfile.c (set_initial_language): Update.
2167 * symtab.h (main_name): Constify return type.
2168
2169 2019-07-17 Tom Tromey <tom@tromey.com>
2170
2171 * tui/tui-winsource.c (tui_update_source_window)
2172 (tui_update_source_window_as_is)
2173 (tui_update_source_windows_with_line): Remove return.
2174 * tui/tui-disasm.c (tui_show_disassem)
2175 (tui_show_disassem_and_update_source): Remove return.
2176 * tui/tui.c (tui_reset): Remove return.
2177 * tui/tui-wingeneral.c
2178 (tui_check_and_display_highlight_if_needed): Remove return.
2179
2180 2019-07-17 Tom Tromey <tom@tromey.com>
2181
2182 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2183
2184 2019-07-17 Tom Tromey <tom@tromey.com>
2185
2186 * tui/tui-winsource.h (struct tui_exec_info_window)
2187 (struct tui_source_window_base): Move from tui-data.h.
2188 * tui/tui-winsource.c: Move many method definitions from
2189 elsewhere. Remove "structuring" comments.
2190 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2191 (tui_source_window_base::refresh_window): Move to
2192 tui-winsource.c.
2193 * tui/tui-win.c (tui_source_window_base::refresh_all)
2194 (tui_source_window_base::update_tab_width)
2195 (tui_source_window_base::set_new_height)
2196 (tui_source_window_base::do_make_visible_with_new_height): Move to
2197 tui-winsource.c.
2198 * tui/tui-source.h: Update.
2199 * tui/tui-source.c (tui_source_window_base::reset): Move to
2200 tui-winsource.c.
2201 * tui/tui-disasm.h: Update.
2202 * tui/tui-data.h (struct tui_exec_info_window): Move to
2203 tui-winsource.h.
2204 (struct tui_source_window_base): Likewise.
2205 * tui/tui-data.c (tui_source_window_base::clear_detail)
2206 (tui_source_window_base, ~tui_source_window_base): Move to
2207 tui-winsource.c.
2208
2209 2019-07-17 Tom Tromey <tom@tromey.com>
2210
2211 * tui/tui-win.c (tui_resize_all)
2212 (tui_source_window_base::update_tab_width)
2213 (tui_adjust_win_heights): Update.
2214 (tui_win_info::make_invisible_and_set_new_height): Rename from
2215 make_invisible_and_set_new_height.
2216 * tui/tui-data.h (struct tui_win_info)
2217 <make_invisible_and_set_new_height>: New method.
2218
2219 2019-07-17 Tom Tromey <tom@tromey.com>
2220
2221 * tui/tui.c: Update.
2222 * tui/tui-source.h (struct tui_source_window): Move from
2223 tui-data.h.
2224 * tui/tui-layout.c: Update.
2225 * tui/tui-disasm.c: Update.
2226 * tui/tui-data.h (struct tui_source_window): Move to
2227 tui-source.h.
2228
2229 2019-07-17 Tom Tromey <tom@tromey.com>
2230
2231 * tui/tui-disasm.h (struct tui_disasm_window): Move from
2232 tui-data.h.
2233 * tui/tui-data.h (struct tui_disasm_window): Move to
2234 tui-disasm.h.
2235
2236 2019-07-17 Tom Tromey <tom@tromey.com>
2237
2238 * tui/tui-regs.h (struct tui_data_item_window): Move from
2239 tui-data.h.
2240 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2241 * tui/tui-data.h (struct tui_data_item_window): Move to
2242 tui-regs.h.
2243 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2244
2245 2019-07-17 Tom Tromey <tom@tromey.com>
2246
2247 * tui/tui.c: Update.
2248 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2249 (tui_cmd_window::max_height): Move to tui-command.c.
2250 * tui/tui-layout.c: Update.
2251 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2252 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2253 tui-command.c.
2254 * tui/tui-command.h (struct tui_cmd_window): Move from
2255 tui-data.h.
2256 * tui/tui-command.c: Remove "structuring" comments.
2257 (tui_cmd_window::clear_detail)
2258 (tui_cmd_window::do_make_visible_with_new_height)
2259 (tui_cmd_window::max_height): Move from elsewhere.
2260
2261 2019-07-17 Tom Tromey <tom@tromey.com>
2262
2263 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2264 Now static.
2265 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2266 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2267
2268 2019-07-17 Tom Tromey <tom@tromey.com>
2269
2270 * tui/tui.c: Update.
2271 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2272 tui-regs.c.
2273 * tui/tui-windata.h: Remove file.
2274 * tui/tui-windata.c: Remove file.
2275 * tui/tui-win.c (tui_data_window::set_new_height)
2276 (tui_data_window::do_make_visible_with_new_height): Move to
2277 tui-regs.c.
2278 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2279 * tui/tui-regs.c: Remove "structuring" comments.
2280 (tui_data_window::first_data_item_displayed)
2281 (tui_data_window::delete_data_content_windows)
2282 (tui_data_window::erase_data_content)
2283 (tui_data_window::display_all_data)
2284 (tui_data_window::refresh_all)
2285 (tui_data_window::do_scroll_vertical)
2286 (tui_data_window::clear_detail, tui_data_window::set_new_height)
2287 (tui_data_window::do_make_visible_with_new_height)
2288 (tui_data_window::refresh_window): Move from elsewhere.
2289 (_initialize_tui_regs): Move to end of file.
2290 * tui/tui-layout.c: Update.
2291 * tui/tui-hooks.c: Update.
2292 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2293 * tui/tui-data.c (tui_data_window::clear_detail): Move to
2294 tui-regs.c.
2295 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2296
2297 2019-07-17 Tom Tromey <tom@tromey.com>
2298
2299 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2300 seen.
2301
2302 2019-07-17 Tom Tromey <tom@tromey.com>
2303
2304 * tui/tui-win.c (tui_source_window_base::set_new_height)
2305 (tui_source_window_base::do_make_visible_with_new_height): Use
2306 m_has_locator field directly.
2307 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2308 method.
2309 (struct tui_source_window_base) <has_locator>: Likewise.
2310
2311 2019-07-17 Tom Tromey <tom@tromey.com>
2312
2313 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2314 Don't declare.
2315 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2316 Remove.
2317 * tui/tui-win.c (tui_source_window_base::set_new_height)
2318 (tui_source_window_base::set_new_height)
2319 (make_invisible_and_set_new_height)
2320 (tui_source_window_base::do_make_visible_with_new_height)
2321 (tui_source_window_base::do_make_visible_with_new_height):
2322 Update.
2323 * tui/tui-layout.c (show_source_disasm_command, show_data)
2324 (show_source_or_disasm_and_command): Update.
2325 * tui/tui-layout.c (show_layout): Update.
2326
2327 2019-07-17 Tom Tromey <tom@tromey.com>
2328
2329 * tui/tui-layout.c (make_data_window): Remove.
2330 (show_data): Unify creation and re-initialization cases.
2331
2332 2019-07-17 Tom Tromey <tom@tromey.com>
2333
2334 * tui/tui-layout.c (make_source_window, make_disasm_window):
2335 Remove.
2336 (show_data): Unify creation and re-initialization cases.
2337
2338 2019-07-17 Tom Tromey <tom@tromey.com>
2339
2340 * tui/tui-layout.c (make_command_window): Remove.
2341 (show_source_disasm_command, show_source_or_disasm_and_command):
2342 Unify creation and re-initialization cases.
2343
2344 2019-07-17 Tom Tromey <tom@tromey.com>
2345
2346 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2347 creation and re-initialization cases.
2348
2349 2019-07-17 Tom Tromey <tom@tromey.com>
2350
2351 * tui/tui-regs.c (tui_get_register): Return void.
2352
2353 2019-07-17 Tom Tromey <tom@tromey.com>
2354
2355 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2356 Simplify.
2357
2358 2019-07-17 Tom Tromey <tom@tromey.com>
2359
2360 * tui/tui-layout.c (show_source_disasm_command): Simplify window
2361 resetting.
2362
2363 2019-07-17 Tom Tromey <tom@tromey.com>
2364
2365 * tui/tui.h (tui_set_layout_by_name): Don't declare.
2366 * tui/tui-regs.c (tui_reg_layout): New function.
2367 (tui_show_registers, tui_reg_command): Use it.
2368 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2369 (tui_layout_command): Rename from tui_set_layout_by_name. Change
2370 parameters.
2371 (tui_layout_command): Remove.
2372
2373 2019-07-17 Tom Tromey <tom@tromey.com>
2374
2375 * tui/tui-layout.h (tui/tui-layout): Return void.
2376 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
2377
2378 2019-07-17 Tom Tromey <tom@tromey.com>
2379
2380 * tui/tui-layout.c (show_source_disasm_command, show_data):
2381 Update.
2382 (reset_locator): Remove.
2383 (show_source_or_disasm_and_command): Update.
2384
2385 2019-07-17 Tom Tromey <tom@tromey.com>
2386
2387 * tui/tui-source.c (tui_source_window_base::reset): Remove
2388 win_type parameter.
2389 * tui/tui-layout.c (make_command_window, make_source_window)
2390 (make_disasm_window, make_data_window)
2391 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2392 (reset_locator, show_source_or_disasm_and_command): Update.
2393 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2394 win_type parameter.
2395 (struct tui_source_window_base) <reset>: Likewise.
2396
2397 2019-07-17 Tom Tromey <tom@tromey.com>
2398
2399 * tui/tui-layout.c (show_source_disasm_command): Use
2400 reset_locator.
2401 (reset_locator): New function.
2402 (init_and_make_win): Remove.
2403 (show_source_or_disasm_and_command): Use reset_locator.
2404
2405 2019-07-17 Tom Tromey <tom@tromey.com>
2406
2407 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2408 condition.
2409 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2410 Remove condition.
2411 * tui/tui-source.c (tui_source_window_base::reset): New method.
2412 * tui/tui-layout.c (make_command_window): Don't call
2413 init_and_make_win.
2414 (make_source_window, make_disasm_window): Don't call
2415 make_source_or_disasm_window.
2416 (make_data_window): Don't call init_and_make_win. Change calling
2417 convention.
2418 (show_source_disasm_command, show_data): Simplify.
2419 (make_source_or_disasm_window): Remove.
2420 (show_source_or_disasm_and_command): Simplify.
2421 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2422 (struct tui_source_window_base) <reset>: Likewise.
2423 <execution_info>: Remove initializer.
2424 * tui/tui-data.c (tui_source_window_base): Initialize
2425 execution_info.
2426
2427 2019-07-17 Tom Tromey <tom@tromey.com>
2428
2429 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2430 variable.
2431
2432 2019-07-17 Tom Tromey <tom@tromey.com>
2433
2434 * tui/tui.c (tui_rl_other_window): Update.
2435 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2436 superclass method first. Always iterate over regs_content.
2437 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2438 method.
2439 * tui/tui-win.c (tui_set_focus_command): Update.
2440
2441 2019-07-17 Tom Tromey <tom@tromey.com>
2442
2443 * tui/tui-win.c (tui_set_focus_command): Rename from
2444 tui_set_focus. Call tui_enable.
2445 (tui_set_focus_command): Remove.
2446
2447 2019-07-17 Tom Tromey <tom@tromey.com>
2448
2449 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2450 refresh_window.
2451 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2452 touchwin.
2453 (tui_data_window::refresh_window): Call refresh_window on data
2454 items. Always call superclass refresh_window.
2455 (tui_win_info::refresh): Remove.
2456 (tui_source_window_base::refresh_window): Update.
2457 (tui_refresh_all): Update.
2458 * tui/tui-layout.c (show_source_disasm_command): Remove call to
2459 refresh_window.
2460 (show_source_or_disasm_and_command): Likewise.
2461 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2462 (struct tui_source_window_base) <refresh>: Likewise.
2463
2464 2019-07-17 Tom Tromey <tom@tromey.com>
2465
2466 * tui/tui-winsource.c (tui_clear_source_content)
2467 (tui_show_source_content): Update.
2468 * tui/tui-source.c (tui_source_window::showing_source_p): Check
2469 whether content is empty.
2470 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2471 Remove.
2472
2473 2019-07-17 Tom Tromey <tom@tromey.com>
2474
2475 * tui/tui-winsource.c (tui_erase_source_content): Clear the
2476 window's contents.
2477 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2478 * tui/tui-source.c (tui_set_source_content_nil): Remove.
2479
2480 2019-07-17 Tom Tromey <tom@tromey.com>
2481
2482 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2483 (struct tui_data_item_window): Update.
2484
2485 2019-07-17 Tom Tromey <tom@tromey.com>
2486
2487 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2488 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2489 defines.
2490
2491 2019-07-17 Tom Tromey <tom@tromey.com>
2492
2493 * tui/tui-winsource.h (tui_erase_source_content)
2494 (tui_clear_source_content): Remove "display_prompt" parameter.
2495 * tui/tui-winsource.c (tui_update_source_window_as_is)
2496 (tui_update_source_windows_with_addr): Update.
2497 (tui_clear_source_content): Remove "display_prompt" parameter.
2498 (tui_erase_source_content): Likewise. Simplify.
2499 (tui_show_source_content): Update.
2500 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2501 * tui/tui-stack.c (tui_show_frame_info): Update.
2502 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2503 Remove defines.
2504
2505 2019-07-17 Tom Tromey <tom@tromey.com>
2506
2507 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2508 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2509 parameter.
2510 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2511 parameter.
2512
2513 2019-07-17 Tom Tromey <tom@tromey.com>
2514
2515 * tui/tui-winsource.c (tui_clear_source_content)
2516 (tui_show_source_content, tui_show_exec_info_content)
2517 (tui_clear_exec_info_content): Update.
2518 * tui/tui-stack.c (tui_show_locator_content): Update.
2519 (tui_show_frame_info): Update.
2520 * tui/tui-source.h (tui_source_window): Don't declare.
2521 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2522 from tui_source_is_displayed.
2523 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2524 Remove field.
2525 (struct tui_source_window_base) <content_in_use>: New field. Now
2526 bool.
2527 (struct tui_source_window) <showing_source_p>: New method.
2528 (TUI_SRC_WIN): Change cast.
2529 * tui/tui-data.c (tui_initialize_static_data): Update.
2530
2531 2019-07-17 Tom Tromey <tom@tromey.com>
2532
2533 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2534 location_matches_p.
2535 * tui/tui-source.c (tui_source_window::location_matches_p): New
2536 method.
2537 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2538 method.
2539 * tui/tui-data.h (struct tui_source_window_base)
2540 <location_matches_p>: New method.
2541 (struct tui_source_window, struct tui_disasm_window)
2542 <location_matches_p>: Likewise.
2543
2544 2019-07-17 Tom Tromey <tom@tromey.com>
2545
2546 * tui/tui-win.c (tui_set_win_height_command): Rename from
2547 tui_set_win_height.
2548 (tui_set_win_height_command): Remove.
2549
2550 2019-07-17 Tom Tromey <tom@tromey.com>
2551
2552 * tui/tui-source.c (tui_source_window): New constructor. Add
2553 observer.
2554 (~tui_source_window): New destructor.
2555 (tui_source_window::style_changed): New method.
2556 * tui/tui-hooks.c (tui_redisplay_source): Remove.
2557 (tui_attach_detach_observers): Update.
2558 * tui/tui-data.h (struct tui_source_window): Make constructor not
2559 inline. Add destructor.
2560 (struct tui_source_window) <style_changed>: New method.
2561 <m_observable>: New member.
2562
2563 2019-07-17 Tom Tromey <tom@tromey.com>
2564
2565 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2566 * tui/tui-win.c (tui_resize_all): Fix typo.
2567
2568 2019-07-17 Tom Tromey <tom@tromey.com>
2569
2570 * tui/tui-wingeneral.h (tui_refresh_all): Update.
2571 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2572 (tui_refresh_all): Remove "list" parameter. Use foreach.
2573 * tui/tui-win.c (window_name_completer): Use foreach.
2574 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2575 (update_tab_width): Likewise.
2576 * tui/tui-layout.c (show_layout): Update.
2577 * tui/tui-data.h (class tui_window_iterator): New.
2578 (struct all_tui_windows): New.
2579 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2580
2581 2019-07-17 Tom Tromey <tom@tromey.com>
2582
2583 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2584 parameter. Don't reference globals.
2585 (tui_reg_command): Update.
2586
2587 2019-07-17 Tom Tromey <tom@tromey.com>
2588
2589 * tui/tui-regs.c (tui_show_registers): Simplify.
2590
2591 2019-07-17 Tom Tromey <tom@tromey.com>
2592
2593 * tui/tui-regs.c (tui_show_registers): Update.
2594 (tui_show_register_group): Add win_info parameter.
2595
2596 2019-07-17 Tom Tromey <tom@tromey.com>
2597
2598 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2599 Rename from tui_display_reg_element_at_line.
2600 (tui_data_window::display_registers_from_line): Update.
2601 * tui/tui-data.h (struct tui_data_window)
2602 <display_reg_element_at_line>: New method.
2603
2604 2019-07-17 Tom Tromey <tom@tromey.com>
2605
2606 * tui/tui-regs.h (tui_display_registers_from)
2607 (tui_display_registers_from_line): Don't declare.
2608 * tui/tui-windata.c (tui_data_window::display_all_data)
2609 (tui_data_window::refresh_all)
2610 (tui_data_window::do_scroll_vertical): Update.
2611 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2612 from tui_display_registers_from.
2613 (tui_display_reg_element_at_line): Update.
2614 (tui_data_window::display_registers_from_line): Rename from
2615 tui_display_registers_from_line.
2616 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2617 display_registers_from_line>: New methods.
2618
2619 2019-07-17 Tom Tromey <tom@tromey.com>
2620
2621 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2622 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2623 from tui_erase_data_content.
2624 (tui_data_window::display_all_data)
2625 (tui_data_window::refresh_all)
2626 (tui_data_window::do_scroll_vertical): Update.
2627 * tui/tui-regs.c (tui_show_registers): Update.
2628 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2629 New method.
2630
2631 2019-07-17 Tom Tromey <tom@tromey.com>
2632
2633 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2634 declare.
2635 * tui/tui-windata.c
2636 (tui_data_window::delete_data_content_windows): Rename from
2637 tui_delete_data_content_windows.
2638 (tui_data_window::display_all_data)
2639 (tui_data_window::do_scroll_vertical): Update.
2640 * tui/tui-data.h (struct tui_data_window)
2641 <delete_data_content_windows>: New method.
2642
2643 2019-07-17 Tom Tromey <tom@tromey.com>
2644
2645 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2646 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2647
2648 2019-07-17 Tom Tromey <tom@tromey.com>
2649
2650 * tui/tui-windata.h (tui_display_all_data): Don't declare.
2651 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2652 from tui_display_all_data.
2653 * tui/tui-win.c
2654 (tui_data_window::do_make_visible_with_new_height): Update.
2655 * tui/tui-regs.c (tui_show_registers): Update.
2656 * tui/tui-layout.c (tui_set_layout): Update.
2657 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2658 method.
2659
2660 2019-07-17 Tom Tromey <tom@tromey.com>
2661
2662 * tui/tui-windata.h (tui_display_data_from): Don't declare.
2663 * tui/tui-windata.c (tui_display_data_from): Remove.
2664 (tui_data_window::refresh_all): Update.
2665
2666 2019-07-17 Tom Tromey <tom@tromey.com>
2667
2668 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2669 * tui/tui-windata.c (tui_display_data_from_line): Remove.
2670 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2671 tui_display_registers_from_line.
2672 * tui/tui-regs.h (tui_display_registers_from_line): Update.
2673 * tui/tui-regs.c (tui_display_registers_from_line): Remove
2674 "force_display" parameter.
2675
2676 2019-07-17 Tom Tromey <tom@tromey.com>
2677
2678 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2679 declare.
2680 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2681 Rename from tui_first_reg_element_no_inline.
2682 (tui_display_reg_element_at_line)
2683 (tui_display_registers_from_line): Update.
2684 * tui/tui-data.h (struct tui_data_window)
2685 <first_reg_element_no_inline>: New method.
2686
2687 2019-07-17 Tom Tromey <tom@tromey.com>
2688
2689 * tui/tui-windata.c (tui_display_data_from)
2690 (tui_data_window::do_scroll_vertical): Update.
2691 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2692 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2693 Rename from tui_line_from_reg_element_no.
2694 (tui_display_registers_from_line): Update.
2695 * tui/tui-data.h (struct tui_data_window)
2696 <line_from_reg_element_no>: New method.
2697
2698 2019-07-17 Tom Tromey <tom@tromey.com>
2699
2700 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2701 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2702 tui_last_regs_line_no.
2703 (tui_display_reg_element_at_line)
2704 (tui_display_registers_from_line): Update.
2705 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2706 method.
2707
2708 2019-07-17 Tom Tromey <tom@tromey.com>
2709
2710 PR tui/24722:
2711 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2712 (tui_update_breakpoint_info): Add "being_deleted" parameter.
2713 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2714 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2715 (tui_update_breakpoint_info): Likewise.
2716 * tui/tui-hooks.c (tui_event_create_breakpoint)
2717 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2718 Update.
2719
2720 2019-07-17 Tom Tromey <tom@tromey.com>
2721
2722 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2723
2724 2019-07-17 Tom Tromey <tom@tromey.com>
2725
2726 * tui/tui-winsource.c (tui_update_source_window_as_is)
2727 (tui_update_source_windows_with_addr): Update.
2728 * tui/tui-source.h (tui_set_source_content)
2729 (tui_show_symtab_source): Add "win_info" parameter.
2730 * tui/tui-source.c (tui_set_source_content): Add "win_info"
2731 parameter.
2732 (tui_show_symtab_source): Likewise.
2733
2734 2019-07-17 Tom Tromey <tom@tromey.com>
2735
2736 * tui/tui-wingeneral.c
2737 (tui_check_and_display_highlight_if_needed): Check can_highlight.
2738
2739 2019-07-17 Tom Tromey <tom@tromey.com>
2740
2741 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2742 (struct tui_cmd_window) <can_scroll>: New method.
2743 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2744 method.
2745
2746 2019-07-17 Tom Tromey <tromey@adacore.com>
2747
2748 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2749 do_field_signed>: Rename. Change type of "value".
2750 * ui-out.c (ui_out::field_signed): Rename from field_int.
2751 Change type of "value".
2752 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
2753 type of "value".
2754 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2755 do_field_int. Change type of "value".
2756 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2757 do_field_int. Change type of "value".
2758 * tracepoint.c (trace_status_mi, tfind_1)
2759 (print_one_static_tracepoint_marker): Update.
2760 * thread.c (print_thread_info_1, print_selected_thread_frame):
2761 Update.
2762 * stack.c (print_frame, print_frame_info): Update.
2763 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2764 Update.
2765 * source.c (print_source_lines_base): Update.
2766 * skip.c (info_skip_command): Update.
2767 * record-btrace.c (btrace_ui_out_decode_error)
2768 (btrace_call_history_src_line): Update.
2769 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2770 Update.
2771 * progspace.c (print_program_space): Update.
2772 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2773 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2774 do_field_int. Change type of "value".
2775 * mi/mi-out.c (mi_ui_out::do_table_begin)
2776 (mi_ui_out::do_table_header): Update.
2777 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
2778 type of "value".
2779 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2780 (mi_cmd_data_list_changed_registers, output_register)
2781 (mi_cmd_data_read_memory, mi_load_progress)
2782 (mi_cmd_trace_frame_collected): Update.
2783 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2784 Update.
2785 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2786 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2787 (mi_cmd_var_list_children, varobj_update_one): Update.
2788 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2789 (mi_cmd_stack_list_args, list_arg_or_local): Update.
2790 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2791 * inferior.c (print_inferior): Update.
2792 * gdb_bfd.c (print_one_bfd): Update.
2793 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2794 Update.
2795 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2796 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2797 do_field_int. Change type of "value".
2798 * cli-out.c (cli_ui_out::do_field_signed): Rename from
2799 do_field_int. Change type of "value".
2800 * breakpoint.c (watchpoint_check, print_breakpoint_location)
2801 (print_one_breakpoint_location, print_it_catch_fork)
2802 (print_one_catch_fork, print_it_catch_vfork)
2803 (print_one_catch_vfork, print_it_catch_solib)
2804 (print_it_catch_exec, print_it_ranged_breakpoint)
2805 (print_mention_watchpoint, print_mention_masked_watchpoint)
2806 (bkpt_print_it, update_static_tracepoint): Update.
2807 * break-catch-throw.c (print_it_exception_catchpoint): Update.
2808 * break-catch-syscall.c (print_it_catch_syscall): Update.
2809 * ada-tasks.c (print_ada_task_info): Update.
2810 * ada-lang.c (print_it_exception, print_mention_exception):
2811 Update.
2812
2813 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
2814
2815 PR breakpoints/24541
2816 * gdbarch.c: Regenerate.
2817 * gdbarch.h: Regenerate.
2818 * gdbarch.sh: Adjust return type and parameter types for
2819 'stap_adjust_register'.
2820 (i386_stap_adjust_register): Adjust signature and return new
2821 register name.
2822 * stap-probe.c (stap_parse_register_operand): Adjust use of
2823 'gdbarch_stap_adjust_register'.
2824
2825 2019-07-17 Tom Tromey <tromey@adacore.com>
2826
2827 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
2828 declare VEC.
2829 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2830 std::vector.
2831 (struct s390_process_info): Add initializers.
2832 (s390_add_process): Use new.
2833 (s390_linux_nat_target::low_forget_process): Use delete.
2834 (s390_linux_nat_target::low_new_fork)
2835 (s390_linux_nat_target::stopped_by_watchpoint)
2836 (s390_linux_nat_target::low_prepare_to_resume)
2837 (s390_linux_nat_target::insert_watchpoint)
2838 (s390_linux_nat_target::insert_hw_breakpoint)
2839 (s390_linux_nat_target::remove_watchpoint)
2840 (s390_linux_nat_target::remove_hw_breakpoint): Update.
2841
2842 2019-07-16 John Baldwin <jhb@FreeBSD.org>
2843
2844 * aarch64-fbsd-nat.c: Include regcache.h.
2845 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2846 argument.
2847 (aarch64_fbsd_nat_target::fetch_registers)
2848 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2849 variable.
2850 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2851
2852 2019-07-16 John Baldwin <jhb@FreeBSD.org>
2853
2854 * fbsd-nat.c: Include gdbarch.h.
2855
2856 2019-07-15 Tom Tromey <tromey@adacore.com>
2857
2858 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2859
2860 2019-07-15 Tom Tromey <tromey@adacore.com>
2861
2862 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2863 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2864 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2865 * cli-out.c (cli_ui_out::do_field_int): New method.
2866 * ui-out.c (ui_out::field_unsigned): New method.
2867 * symfile.c (generic_load): Use field_unsigned.
2868 (print_transfer_performance): Likewise.
2869 * record-btrace.c (ui_out_field_uint): Remove.
2870 (btrace_call_history_insn_range, btrace_call_history): Use
2871 field_unsigned.
2872 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2873 field_unsigned.
2874 * ui-out.h (class ui_out) <field_unsigned>: New method.
2875 <do_field_unsigned>: Likewise.
2876
2877 2019-07-15 Tom Tromey <tromey@adacore.com>
2878
2879 * mi/mi-main.c (list_available_thread_groups): Use field_string.
2880 * mi/mi-interp.c (mi_memory_changed): Use field_string.
2881 * target.c (flash_erase_command): Use field_string.
2882 * infrun.c (print_signal_received_reason): Use field_string.
2883 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2884 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2885 field_string.
2886 * ada-tasks.c (print_ada_task_info): Use field_string.
2887
2888 2019-07-15 Tom Tromey <tromey@adacore.com>
2889
2890 * target.c (flash_erase_command): Use field_core_addr.
2891 * symfile.c (generic_load): Use field_core_addr.
2892 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2893 Use field_core_addr.
2894 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2895 field_core_addr.
2896
2897 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2898
2899 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2900 value if its desired type is smaller than a CORE_ADDR and signed.
2901
2902 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2903
2904 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2905 of changes to field names, and use new is_reference field to
2906 decide if a property is a reference or not.
2907 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2908 field.
2909 (struct dwarf2_property_baton): Update header comment, rename
2910 'referenced_type' to 'property_type' and update comments.
2911 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2912 default property type, store in property baton, update to take
2913 accound of renamed field.
2914 (read_func_scope): Update call to attr_to_dynamic_prop.
2915 (read_array_type): Likewise.
2916 (dwarf2_per_cu_addr_sized_int_type): New function.
2917 (read_subrange_index_type): Move type finding code to
2918 dwarf2_per_cu_addr_sized_int_type.
2919 (read_subrange_type): Update calls to attr_to_dynamic_prop.
2920 (dwarf2_per_cu_addr_type): New function.
2921 (set_die_type): Update calls to attr_to_dynamic_prop.
2922
2923 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2924
2925 * dwarf2read.c (read_subrange_index_type): New function.
2926 (read_subrange_type): Move code into new function and call it.
2927 * gdbtypes.c (create_range_type): Add some asserts.
2928
2929 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2930
2931 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2932 update return statements.
2933 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2934 declaration, and update comment to match.
2935 * gdbtypes.c (resolve_dynamic_array): Update call to
2936 dwarf2_evaluate_property to match new return type.
2937
2938 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2939
2940 * valarith.c (value_subscripted_rvalue): Change lowerbound
2941 parameter type from int to LONGEST.
2942 * value.h (value_subscripted_rvalue): Likewise in declaration.
2943
2944 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2945
2946 * cli/cli-utils.c (info_print_command_completer): New function.
2947 * cli/cli-utils.h: Add 'completer.h' include, and forward
2948 declaration for 'struct cmd_list_element'.
2949 (info_print_command_completer): Declare.
2950 * stack.c (_initialize_stack): Add completer for 'info locals' and
2951 'info args'.
2952 * symtab.c (_initialize_symtab): Add completer for 'info
2953 variables' and 'info functions'.
2954 * NEWS: Mention completion for additional info commands.
2955
2956 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2957
2958 * cli/cli-utils.c (extract_info_print_args): Delete.
2959 (extract_arg_maybe_quoted): Delete.
2960 (info_print_options_defs): New variable.
2961 (make_info_print_options_def_group): New function.
2962 (extract_info_print_options): Define new function.
2963 * cli/cli-utils.h (extract_info_print_args): Delete.
2964 (struct info_print_options): New structure.
2965 (extract_info_print_options): Declare new function.
2966 * stack.c (info_locals_command): Update to use new
2967 extract_info_print_options, also add a header comment.
2968 (info_args_command): Likewise.
2969 * symtab.c (info_variables_command): Likewise.
2970 (info_functions_command): Likewise.
2971
2972 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2973
2974 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2975 to extract string arguments.
2976 * common/common-utils.c (extract_string_maybe_quoted): New function.
2977 * common/common-utils.h (extract_string_maybe_quoted): Declare.
2978
2979 2019-07-11 Tom Tromey <tromey@adacore.com>
2980
2981 * main.c (get_init_files): Use GDBINIT, not gdbinit.
2982 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2983 * top.h (gdbinit): Don't declare.
2984 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2985 into...
2986 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
2987 * top.c (gdb_init): Don't call init_cli_cmds.
2988 (gdbinit): Remove.
2989 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2990
2991 2019-07-11 Tom Tromey <tromey@adacore.com>
2992
2993 * python/py-inferior.c (add_thread_object): Don't use thread_obj
2994 after it has been moved.
2995
2996 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2997
2998 * valops.c (value_must_coerce_to_target): Change return type to
2999 bool.
3000 * value.h (value_must_coerce_to_target): Likewise.
3001
3002 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
3003
3004 * breakpoint.c (is_hardware_watchpoint): Remove
3005 forward-declaration.
3006 (is_masked_watchpoint): Change return type to bool.
3007 (is_tracepoint): Likewise.
3008 (is_breakpoint): Likewise.
3009 (is_hardware_watchpoint): Likewise.
3010 (is_watchpoint): Likewise.
3011 (is_no_memory_software_watchpoint): Likewise.
3012 (is_catchpoint): Likewise.
3013 (breakpoint_1): Make FILTER parameter's return type bool.
3014 is_masked_watchpoint): Change return type to bool.
3015 (save_breakpoints): Make FILTER parameter's return type bool.
3016 * breakpoint.h (is_breakpoint): Change return type to bool.
3017 (is_watchpoint): Likewise.
3018 (is_catchpoint): Likewise.
3019 (is_tracepoint): Likewise.
3020
3021 2019-07-10 Tom Tromey <tom@tromey.com>
3022
3023 * defs.h: Don't include gdbarch.h.
3024 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3025 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3026 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3027 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3028 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3029 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3030 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3031 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3032 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3033 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3034 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3035 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3036 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3037 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3038 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3039 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3040 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3041 record-btrace.c, record.h, regcache-dump.c, regcache.h,
3042 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3043 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3044 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3045 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3046 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3047 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3048 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3049 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3050 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3051
3052 2019-07-10 Tom Tromey <tromey@adacore.com>
3053
3054 * ada-lang.h (is_ada_exception_catchpoint): Declare.
3055 * breakpoint.c (init_ada_exception_breakpoint): Register as
3056 bp_catchpoint.
3057 (print_one_breakpoint_location, print_one_breakpoint): Use
3058 is_ada_exception_catchpoint.
3059 * ada-lang.c (class ada_catchpoint_location): Pass
3060 bp_loc_software_breakpoint to bp_location constructor.
3061 (is_ada_exception_catchpoint): New function.
3062
3063 2019-07-10 Tom Tromey <tromey@adacore.com>
3064
3065 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
3066 VEC.
3067 (struct arm_exidx_entry): New method operator<.
3068 (struct arm_exidx_data) <section_maps>: Change type.
3069 (arm_exidx_data_free): Remove.
3070 (arm_exidx_data_key): Change type. Move lower.
3071 (arm_exidx_new_objfile): Update.
3072 (arm_compare_exidx_entries): Remove.
3073 (arm_find_exidx_entry, _initialize_arm_tdep)
3074
3075 2019-07-10 Tom Tromey <tromey@adacore.com>
3076
3077 * solib-spu.c (ocl_program_data_key): Change type.
3078 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3079 Update.
3080
3081 2019-07-10 Tom Tromey <tromey@adacore.com>
3082
3083 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
3084 (struct solib_aix_inferior_data) <library_list>: Change type.
3085 (solib_aix_inferior_data_handle): Change type.
3086 (get_solib_aix_inferior_data): Update.
3087 (solib_aix_free_library_list): Remove.
3088 (library_list_start_library): Update.
3089 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3090 return type.
3091 (solib_aix_get_library_list)
3092 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3093 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3094
3095 2019-07-10 Tom Tromey <tromey@adacore.com>
3096
3097 * solib-dsbt.c (struct dsbt_info): Add initializers.
3098 (solib_dsbt_pspace_data): Change type.
3099 (dsbt_pspace_data_cleanup): Remove.
3100 (get_dsbt_info, _initialize_dsbt_solib): Update.
3101
3102 2019-07-10 Tom Tromey <tromey@adacore.com>
3103
3104 * spu-tdep.c (spu_overlay_data): Change type.
3105 (spu_get_overlay_table, spu_overlay_new_objfile)
3106 (_initialize_spu_tdep): Update.
3107
3108 2019-07-10 Tom Tromey <tromey@adacore.com>
3109
3110 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3111 destructor.
3112 (dbx_objfile_data_key): Change type and declare later.
3113 (DBX_SYMFILE_INFO): Rewrite.
3114 * dbxread.c (dbx_objfile_data_key): Change type.
3115 (dbx_symfile_init): Update.
3116 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
3117 (coffstab_build_psymtabs, elfstab_build_psymtabs)
3118 (stabsect_build_psymtabs, _initialize_dbxread): Update.
3119
3120 2019-07-10 Tom Tromey <tromey@adacore.com>
3121
3122 * jit.c (jit_program_space_key): Change type. Move lower.
3123 (get_jit_program_space_data): Update.
3124 (jit_program_space_data_cleanup): Remove.
3125 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3126 Update.
3127 (struct jit_program_space_data): Add initializers.
3128
3129 2019-07-10 Tom Tromey <tromey@adacore.com>
3130
3131 * solib-darwin.c (struct darwin_info): Add initializers.
3132 (solib_darwin_pspace_data): Change type.
3133 (darwin_pspace_data_cleanup): Remove.
3134 (get_darwin_info, _initialize_darwin_solib): Update.
3135
3136 2019-07-10 Tom Tromey <tromey@adacore.com>
3137
3138 * remote-sim.c (struct sim_inferior_data): Add initializers,
3139 constructor, and destructor.
3140 (sim_inferior_data_key): Change type. Move lower.
3141 (check_for_duplicate_sim_descriptor): Update.
3142 (get_sim_inferior_data): Use new. Update.
3143 (~sim_inferior_data_cleanup): Rename from
3144 sim_inferior_data_cleanup. Simplify.
3145 (gdbsim_close_inferior, simulator_command)
3146 (sim_command_completer, _initialize_remote_sim): Update.
3147 (next_pid, INITIAL_PID): Move earlier.
3148
3149 2019-07-10 Tom Tromey <tromey@adacore.com>
3150
3151 * python/python-internal.h (create_thread_object): Return
3152 gdbpy_ref.
3153 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3154 * python/py-inferior.c (struct threadlist_entry): Add
3155 constructor.
3156 <thread_obj>: Now a gdbpy_ref.
3157 (thread_to_thread_object): Update.
3158 (add_thread_object): Use new.
3159 (delete_thread_object): Use delete.
3160 (infpy_threads): Update.
3161 (py_free_inferior): Update. Construct "inf_obj" after acquiring
3162 GIL.
3163
3164 2019-07-10 Tom Tromey <tromey@adacore.com>
3165
3166 * valops.c (value_cast): Specialize error message for Ada.
3167
3168 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3169
3170 * breakpoint.c (breakpoint_1): Update doc and parameter names.
3171
3172 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3173
3174 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3175 bpstat_should_step): Return bool, adjust comments.
3176 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3177 bpstat_should_step): Likewise.
3178
3179 2019-07-10 Alan Hayward <alan.hayward@arm.com>
3180
3181 * features/Makefile: Use feature target descriptions for Arm.
3182 * features/arm/arm-core.c: Generate new file.
3183 * features/arm/arm-fpa.c: Likewise.
3184 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3185 * features/arm/arm-m-profile.c: Likewise.
3186 * features/arm/arm-vfpv2.c: Likewise.
3187 * features/arm/arm-vfpv3.c: Likewise.
3188 * features/arm/xscale-iwmmxt.c: Likewise.
3189 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3190
3191 2019-07-10 Alan Hayward <alan.hayward@arm.com>
3192
3193 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3194 ptrace earlier.
3195
3196 2019-07-10 Alan Hayward <alan.hayward@arm.com>
3197
3198 * features/aarch64-pauth.c: Regenerate.
3199
3200 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
3201
3202 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3203 bool.
3204 (bpstat_what): Use false instead of 0.
3205
3206 2019-07-09 Pedro Alves <palves@redhat.com>
3207
3208 * break-catch-throw.c (is_exception_catchpoint): New.
3209 * breakpoint.c (print_one_breakpoint_location): New parameter
3210 'raw_loc'. Handle it. Use
3211 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3212 looking at the breakpoint's type.
3213 (print_one_breakpoint): If handling "maint info breakpoints", also
3214 print locations of exception catchpoints.
3215 * breakpoint.h (is_exception_catchpoint): Declare.
3216
3217 2019-07-09 Pedro Alves <palves@redhat.com>
3218
3219 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3220 "addr" field.
3221 (allocate_location_exception_catchpoint): New.
3222 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3223 (initialize_throw_catchpoint_ops): Install
3224 allocate_location_exception_catchpoint as allocate_location
3225 method.
3226 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3227 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3228 bp_loc_other.
3229 (breakpoint_address_is_meaningful): Delete.
3230 (bl_address_is_meaningful): New.
3231 (breakpoint_locations_match): Adjust comment.
3232 (bp_location_from_bp_type): New, factored out of...
3233 (bp_location::bp_location(breakpoint *)): ... this.
3234 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3235 factored out of...
3236 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
3237 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3238 breakpoint_address_is_meaningful.
3239 (bp_locations_compare): Adjust comment.
3240 (update_global_location_list): Use bl_address_is_meaningful
3241 instead of breakpoint_address_is_meaningful.
3242 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3243 explicit.
3244 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3245 * python/py-breakpoint.c (bppy_get_location): No longer check
3246 whether location is null.
3247
3248 2019-07-09 Pedro Alves <palves@redhat.com>
3249
3250 PR c++/15468
3251 * breakpoint.c (print_one_breakpoint_location): Remove
3252 single-location assert.
3253
3254 2019-07-09 Tom Tromey <tom@tromey.com>
3255
3256 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3257 * configure: Rebuild.
3258 * configure.ac: Change common to gdbsupport.
3259 * gdbsupport: Rename from common.
3260 * acinclude.m4: Change common to gdbsupport.
3261 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3262 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3263 gdbsupport.
3264 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3265 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3266 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3267 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3268 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3269 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3270 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3271 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3272 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3273 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3274 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3275 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3276 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3277 coff-pe-read.c, command.h, compile/compile-c-support.c,
3278 compile/compile-c.h, compile/compile-cplus-symbols.c,
3279 compile/compile-cplus-types.c, compile/compile-cplus.h,
3280 compile/compile-loc2c.c, compile/compile.c, completer.c,
3281 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3282 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3283 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3284 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3285 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3286 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3287 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3288 features/aarch64-core.c, features/aarch64-fpu.c,
3289 features/aarch64-pauth.c, features/aarch64-sve.c,
3290 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3291 features/i386/32bit-core.c, features/i386/32bit-linux.c,
3292 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3293 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3294 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3295 features/i386/64bit-core.c, features/i386/64bit-linux.c,
3296 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3297 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3298 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3299 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3300 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3301 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3302 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3303 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3304 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3305 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3306 go32-nat.c, guile/guile.c, guile/scm-ports.c,
3307 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3308 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3309 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3310 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3311 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3312 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3313 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3314 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3315 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3316 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3317 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3318 minsyms.c, mips-linux-tdep.c, namespace.h,
3319 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3320 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3321 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3322 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3323 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3324 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3325 nat/linux-waitpid.c, nat/mips-linux-watch.c,
3326 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3327 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3328 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3329 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3330 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3331 procfs.c, producer.c, progspace.h, psymtab.h,
3332 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3333 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3334 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3335 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3336 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3337 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3338 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3339 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3340 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3341 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3342 target-memory.c, target.c, target.h, target/waitstatus.c,
3343 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3344 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3345 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3346 unittests/array-view-selftests.c,
3347 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3348 unittests/common-utils-selftests.c,
3349 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3350 unittests/format_pieces-selftests.c,
3351 unittests/function-view-selftests.c,
3352 unittests/lookup_name_info-selftests.c,
3353 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3354 unittests/mkdir-recursive-selftests.c,
3355 unittests/observable-selftests.c,
3356 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3357 unittests/parse-connection-spec-selftests.c,
3358 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3359 unittests/scoped_fd-selftests.c,
3360 unittests/scoped_mmap-selftests.c,
3361 unittests/scoped_restore-selftests.c,
3362 unittests/string_view-selftests.c, unittests/style-selftests.c,
3363 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3364 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3365 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3366 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3367 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3368 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3369
3370 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3371
3372 * linespec.c (decode_digits_list_mode): Set explicit_line to a
3373 bool value.
3374 (decode_digits_ordinary): Set explicit_line field in sal.
3375 * symtab.c (skip_prologue_sal): Don't skip prologue for a
3376 symtab_and_line that was set on an explicit line number in
3377 assembler code. Do always update the recorded symtab and line if
3378 we do skip the prologue.
3379
3380 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3381
3382 * breakpoint.c (set_breakpoint_location_function): Remove
3383 explicit_loc parameter.
3384 (momentary_breakpoint_from_master): Update call to
3385 set_breakpoint_location_function.
3386 (add_location_to_breakpoint): Likewise.
3387
3388 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3389
3390 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3391 required features based on default bfd type when no specific bfd
3392 is present.
3393
3394 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3395
3396 * NEWS: Mention that GDB printf and eval commands can now print
3397 C-style and Ada-style convenience var strings without
3398 calling the inferior.
3399 * printcmd.c (printf_c_string): Locally print GDB internal var
3400 instead of transiting via the inferior.
3401 (printf_wide_c_string): Likewise.
3402
3403 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3404
3405 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3406
3407 2019-07-04 Tom Tromey <tom@tromey.com>
3408
3409 PR tui/24724:
3410 * tui/tui-winsource.c (tui_clear_source_content): Update.
3411 (tui_source_window_base::set_is_exec_point_at): Fix comment.
3412 (tui_update_breakpoint_info): Update.
3413 (tui_set_exec_info_content): Update.
3414 * tui/tui-source.c (tui_set_source_content_nil): Update.
3415 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3416 has_break.
3417 * tui/tui-data.h (enum tui_bp_flag): New.
3418 (tui_bp_flags): New enum flags type.
3419 (struct tui_source_element) <break_mode>: Change type. Rename
3420 from has_break.
3421 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3422 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
3423 constants.
3424 * tui/tui-winsource.h: Fix comment.
3425
3426 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3427
3428 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3429 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3430 (store_fpregs_to_thread)
3431 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3432 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3433 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3434 (IWMMXT_REGS_SIZE): Add define.
3435 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3436 (fetch_vfp_regs, store_vfp_regs)
3437 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3438 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3439
3440 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3441
3442 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3443 defines.
3444 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3445 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3446 (ARM_INT_REGISTER_SIZE): ...to this.
3447 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3448 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3449 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3450 (arm_linux_collect_gregset, supply_nwfpe_register)
3451 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3452 defines.
3453 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3454 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3455 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3456 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3457 (arm_return_in_memory, arm_store_return_value)
3458 (arm_get_longjmp_target, arm_register_g_packet_guesses)
3459 (arm_record_ld_st_multiple): Likewise.
3460 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3461 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3462
3463 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3464
3465 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3466 AARCH64_DISPLACED_MODIFIED_INSNS.
3467 * aarch64-tdep.c (struct aarch64_displaced_step_data)
3468 (aarch64_displaced_step_copy_insn): Likewise.
3469 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3470 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3471 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3472 ARM_DISPLACED_MODIFIED_INSNS.
3473 * arm-tdep.c (arm_gdbarch_init): Likewise.
3474 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3475 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3476 (struct arm_displaced_step_closure): Use
3477 ARM_DISPLACED_MODIFIED_INSNS.
3478
3479 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3480
3481 * features/Makefile: Remove unused xml files.
3482 * features/aarch64.xml: Remove.
3483 * features/i386/amd64-avx-avx512-linux.xml: Remove.
3484 * features/i386/amd64-avx-avx512.xml: Remove.
3485 * features/i386/amd64-avx-linux.xml: Remove.
3486 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3487 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3488 * features/i386/amd64-avx-mpx-linux.xml: Remove.
3489 * features/i386/amd64-avx-mpx.xml: Remove.
3490 * features/i386/amd64-avx.xml: Remove.
3491 * features/i386/amd64-linux.xml: Remove.
3492 * features/i386/amd64-mpx-linux.xml: Remove.
3493 * features/i386/amd64-mpx.xml: Remove.
3494 * features/i386/amd64.xml: Remove.
3495 * features/i386/i386-avx-avx512-linux.xml: Remove.
3496 * features/i386/i386-avx-avx512.xml: Remove.
3497 * features/i386/i386-avx-linux.xml: Remove.
3498 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3499 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3500 * features/i386/i386-avx-mpx-linux.xml: Remove.
3501 * features/i386/i386-avx-mpx.xml: Remove.
3502 * features/i386/i386-avx.xml: Remove.
3503 * features/i386/i386-linux.xml: Remove.
3504 * features/i386/i386-mmx-linux.xml: Remove.
3505 * features/i386/i386-mmx.xml: Remove.
3506 * features/i386/i386-mpx-linux.xml: Remove.
3507 * features/i386/i386-mpx.xml: Remove.
3508 * features/i386/i386.xml: Remove.
3509 * features/i386/x32-avx-avx512-linux.xml: Remove.
3510 * features/i386/x32-avx-linux.xml: Remove.
3511 * features/i386/x32-linux.xml: Remove.
3512
3513 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3514
3515 * regformats/aarch64.dat: Remove.
3516 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3517 * regformats/i386/amd64-avx-linux.dat: Remove.
3518 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3519 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3520 * regformats/i386/amd64-linux.dat: Remove.
3521 * regformats/i386/amd64-mpx-linux.dat: Remove.
3522 * regformats/i386/amd64.dat: Remove.
3523 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3524 * regformats/i386/i386-avx-linux.dat: Remove.
3525 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3526 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3527 * regformats/i386/i386-linux.dat: Remove.
3528 * regformats/i386/i386-mmx-linux.dat: Remove.
3529 * regformats/i386/i386-mpx-linux.dat: Remove.
3530 * regformats/i386/i386.dat: Remove.
3531 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3532 * regformats/i386/x32-avx-linux.dat: Remove.
3533 * regformats/i386/x32-linux.dat: Remove.
3534
3535 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3536
3537 * aarch64-tdep.c: Remove xml self tests.
3538 * amd64-linux-tdep.c: Likewise.
3539 * amd64-tdep.c: Likewise.
3540 * i386-linux-tdep.c: Likewise.
3541 * i386-tdep.c: Likewise.
3542
3543 2019-07-03 Pedro Alves <palves@redhat.com>
3544
3545 PR cli/24732
3546 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3547 (pipe_cmd_option_defs): New.
3548 (make_pipe_cmd_options_def_group): New.
3549 (pipe_command): Use gdb::option::process_options.
3550 (pipe_command_completer): New function.
3551 (_initialize_cli_cmds): Install completer for "pipe" command.
3552
3553 2019-07-03 Pedro Alves <palves@redhat.com>
3554
3555 * cli/cli-option.c (union option_value) <string>: New field.
3556 (struct option_def_and_value): Add ctor, move ctor, dtor and
3557 use DISABLE_COPY_AND_ASSIGN.
3558 (option_def_and_value::clear_value): New.
3559 (parse_option, save_option_value_in_ctx, get_val_type_str)
3560 (add_setshow_cmds_for_options): Handle var_string.
3561 * cli-option.h (union option_def::var_address) <string>: New
3562 field.
3563 (struct string_option_def): New.
3564 * maint-test-options.c (struct test_options_opts): Add default
3565 ctor and use DISABLE_COPY_AND_ASSIGN.
3566 <string_opt>: New field.
3567 (test_options_opts::~test_options_opts): New.
3568 (test_options_opts::dump): Also dump "-string".
3569 (test_options_option_defs): Install "string.
3570
3571 2019-07-03 Pedro Alves <palves@redhat.com>
3572
3573 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3574 option_value with a null enumeration.
3575 (complete_options): Save the option values in the context.
3576 (save_option_value_in_ctx): New, factored out from ...
3577 (process_options): ... here.
3578 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3579 of the function.
3580 * maint-test-options.c (test_options_opts::dump): New, factored
3581 out from ...
3582 (maintenance_test_options_command_mode): ... here.
3583 (maintenance_test_options_command_completion_result): Delete.
3584 (maintenance_test_options_command_completion_text): Update
3585 comment.
3586 (maintenance_show_test_options_completion_result): Change
3587 prototype. Just print
3588 maintenance_test_options_command_completion_text.
3589 (save_completion_result): New.
3590 (maintenance_test_options_completer_mode): Pass options context to
3591 complete_options, and then save a dump.
3592 (_initialize_maint_test_options): Use add_cmd to install "maint
3593 show test-options-completion-result".
3594
3595 2019-07-03 Pedro Alves <palves@redhat.com>
3596
3597 * NEWS (New commands): Mention "with" and "maint with".
3598 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3599 (with_command, with_command_completer): New.
3600 (pipe_command): Adjust to new repeat_previous
3601 interface.
3602 (_initialize_cli_cmds): Install the "with" command and its "w"
3603 alias.
3604 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3605 declarations.
3606 * cli/cli-setshow.c (parse_cli_var_uinteger)
3607 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3608 argument strings for all var_types.
3609 (get_setshow_command_value_string): New, factored out from ...
3610 (do_show_command): ... this.
3611 * cli/cli-setshow.h: Include <string>.
3612 (get_setshow_command_value_string): Declare.
3613 * command.h (repeat_previous): Now returns const char *. Adjust
3614 comment.
3615 * maint.c: Include "cli/cli-cmds.h".
3616 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3617 (_initialize_maint_cmds): Register the "maintenance with" command.
3618 * top.c (repeat_previous): Move bits from pipe_command here:
3619 Return the saved command line, if any; error out if there's no
3620 command to relaunch.
3621
3622 2019-07-03 Pedro Alves <palves@redhat.com>
3623
3624 * NEWS (New commands): Mention "maint set/show test-settings"
3625 instead of "maint test-settings".
3626 * maint-test-settings.c (maintenance_test_settings_list): Delete.
3627 (maintenance_test_settings_set_list): Rename to ...
3628 (maintenance_set_test_settings_list): ... this.
3629 (maintenance_test_settings_show_list): Rename to ...
3630 (maintenance_show_test_settings_list): ... this.
3631 (maintenance_test_settings_cmd): Delete.
3632 (maintenance_test_settings_set_cmd): ...
3633 (maintenance_set_test_settings_cmd): ... this.
3634 (maintenance_test_settings_show_cmd): ...
3635 (maintenance_show_test_settings_cmd): ... this.
3636 (maintenance_test_settings_show_value_cmd):
3637 (maintenance_show_test_settings_value_cmd): ... this.
3638 (_initialize_maint_test_settings): No longer install the "maint
3639 test-settings" prefix command. Rename "maint test-settings set"
3640 to "maint set test-settings", and "maint test-settings show" to
3641 "maint show test-settings". Adjust all subcommands.
3642
3643 2019-07-03 Pedro Alves <palves@redhat.com>
3644
3645 * maint-test-settings.c: Fix file's intro comment. Replace all
3646 references to "test-options" with references to "test-settings",
3647 in comments.
3648
3649 2019-07-03 Pedro Alves <palves@redhat.com>
3650
3651 * maint-test-settings.c (maintenance_test_settings_xxx)
3652 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3653 New.
3654 (maintenance_test_settings_enums): Use them.
3655 (maintenance_test_settings_enum): Default to
3656 maintenance_test_settings_xxx.
3657 (_initialize_maint_test_settings): Initialize
3658 MAINTENANCE_TEST_SETTINGS_FILENAME.
3659
3660 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3661
3662 * breakpoint.h (remove_breakpoints_inf): Change return type to
3663 void, move function documentation here.
3664 * breakpoint.c (remove_breakpoints_inf): Change return type to
3665 void, move function documentation to header.
3666
3667 2019-07-02 Pedro Alves <palves@redhat.com>
3668
3669 * NEWS (Completion improvements): Mention "info threads".
3670 * thread.c (struct info_threads_opts, info_threads_option_defs)
3671 (make_info_threads_options_def_group): New.
3672 (info_threads_command): Use gdb::option::process_options.
3673 (info_threads_command_completer): New.
3674 (_initialize_thread): Use gdb::option::build_help to build the
3675 help text for "info threads".
3676
3677 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3678
3679 * defs.h (generic_load): Move from here...
3680 * symfile.h (generic_load): ... to here. Rename name parameter
3681 to args.
3682 * symfile.c (generic_load): Add comment.
3683
3684 2019-07-01 Tom Tromey <tromey@adacore.com>
3685
3686 * dwarf2read.c
3687 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3688 declaration of without_params. Fix formatting.
3689
3690 2019-07-01 Tom Tromey <tromey@adacore.com>
3691
3692 * ada-exp.y (find_primitive_type): Update.
3693 * ada-lang.h (ada_lookup_symbol): Update.
3694 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3695 parameter.
3696 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3697
3698 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3699
3700 PR breakpoints/24541
3701 * gdbarch.c: Regenerate.
3702 * gdbarch.h: Regenerate.
3703 * gdbarch.sh: Add 'stap_adjust_register'.
3704 * i386-tdep.c: Include '<unordered_set>'.
3705 (i386_stap_adjust_register): New function.
3706 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3707 * stap-probe.c (stap_parse_register_operand): Call
3708 'gdbarch_stap_adjust_register'.
3709
3710 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3711
3712 PR python/24742
3713 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3714 * python/python.c (do_start_initialization): Use 'xmalloc'
3715 instead of 'PyMem_Malloc'.
3716
3717 2019-06-28 Tom Tromey <tromey@adacore.com>
3718
3719 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3720 for Ada.
3721
3722 2019-06-27 Tom Tromey <tromey@adacore.com>
3723
3724 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
3725 objfile_key.
3726 (arm_find_mapping_symbol, arm_record_special_symbol)
3727 (_initialize_arm_tdep): Update.
3728 (arm_objfile_data_free): Remove.
3729
3730 2019-06-27 Tom Tromey <tromey@adacore.com>
3731
3732 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3733 to cp_print_static_field.
3734
3735 2019-06-26 Tom Tromey <tromey@adacore.com>
3736
3737 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3738 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3739 declare.
3740
3741 2019-06-26 Alan Hayward <alan.hayward@arm.com>
3742
3743 * features/aarch64-core.c (create_feature_aarch64_core):
3744 Regenerate.
3745 * features/aarch64-core.xml: Add cpsr flags.
3746
3747 2019-06-26 Alan Hayward <alan.hayward@arm.com>
3748
3749 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3750 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3751
3752 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3753
3754 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3755 field.
3756 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3757 use.
3758 (arm_record_special_symbol): Don't insert new symbol in sorted
3759 position, push it at the end.
3760
3761 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3762
3763 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3764 (arm_mapping_symbol_s): Remove.
3765 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3766 (arm_mapping_symbol_vec): New typedef.
3767 (struct arm_per_objfile): Add constructor.
3768 <section_maps>: Change type to
3769 std::unique_ptr<arm_mapping_symbol_vec[]>.
3770 (arm_compare_mapping_symbols): Remove.
3771 (arm_find_mapping_symbol): Adjust to section_maps type change.
3772 (arm_objfile_data_free): Call delete on arm_per_objfile.
3773 (arm_record_special_symbol): Adjust to section_maps type change.
3774 Allocate arm_per_objfile with new.
3775
3776 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3777
3778 * cli/cli-cmds.c (alias_command): Compare the alias prefix
3779 with the command prefix.
3780
3781 2019-06-25 Tom Tromey <tom@tromey.com>
3782
3783 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3784 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3785
3786 2019-06-25 Tom Tromey <tom@tromey.com>
3787
3788 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3789 type.
3790 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3791 protected.
3792
3793 2019-06-25 Tom Tromey <tom@tromey.com>
3794
3795 * tui/tui-winsource.c
3796 (tui_source_window_base::set_is_exec_point_at): Add check against
3797 LOA_ADDRESS.
3798
3799 2019-06-25 Tom Tromey <tom@tromey.com>
3800
3801 * tui/tui-source.c (tui_set_source_content): Don't check before
3802 xfree.
3803 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3804
3805 2019-06-25 Tom Tromey <tom@tromey.com>
3806
3807 * tui/tui-winsource.h (tui_update_source_window_as_is)
3808 (tui_alloc_source_buffer, tui_line_is_displayed)
3809 (tui_addr_is_displayed): Change type of win_info.
3810 * tui/tui-winsource.c (tui_update_source_window_as_is)
3811 (tui_clear_source_content, tui_show_source_line)
3812 (tui_show_source_content, tui_source_window_base::refill)
3813 (tui_source_window_base::set_is_exec_point_at)
3814 (tui_source_window_base::set_is_exec_point_at)
3815 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3816 (tui_alloc_source_buffer, tui_line_is_displayed)
3817 (tui_addr_is_displayed): Change type of win_info. Update.
3818 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3819 (tui_source_window_base::do_make_visible_with_new_height):
3820 Update.
3821 * tui/tui-source.c (tui_set_source_content)
3822 (tui_set_source_content_nil)
3823 (tui_source_window::do_scroll_vertical): Update.
3824 * tui/tui-layout.c (show_layout): Update.
3825 * tui/tui-disasm.c (tui_set_disassem_content)
3826 (tui_disasm_window::do_scroll_vertical): Update.
3827 * tui/tui-data.h (tui_win_content): Remove.
3828 (struct tui_gen_win_info) <content, content_size>: Remove.
3829 (struct tui_source_element): Add initializers and destructor.
3830 (union tui_which_element, struct tui_win_element): Remove.
3831 (struct tui_source_window_base) <content>: New field.
3832 (struct tui_data_window): Remove destructor.
3833 (tui_alloc_content, tui_free_win_content)
3834 (tui_free_all_source_wins_content): Don't declare.
3835 * tui/tui-data.c (tui_initialize_static_data): Update.
3836 (init_content_element, tui_alloc_content): Remove.
3837 (~tui_gen_win_info): Update.
3838 (~tui_data_window, tui_free_all_source_wins_content)
3839 (tui_free_win_content, free_content, free_content_elements):
3840 Remove.
3841
3842 2019-06-25 Tom Tromey <tom@tromey.com>
3843
3844 * tui/tui-winsource.h (tui_clear_source_content)
3845 (tui_erase_source_content, tui_show_source_content): Change type
3846 of win_info.
3847 * tui/tui-winsource.c (tui_clear_source_content)
3848 (tui_erase_source_content, tui_show_source_content): Change type
3849 of win_info.
3850 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3851 * tui/tui-source.h (tui_set_source_content_nil): Change type of
3852 win_info.
3853 * tui/tui-source.c (tui_set_source_content_nil): Change type of
3854 win_info.
3855 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3856
3857 2019-06-25 Tom Tromey <tom@tromey.com>
3858
3859 * tui/tui-winsource.c (tui_clear_source_content)
3860 (tui_source_window_base::set_is_exec_point_at): Update.
3861 * tui/tui-source.c (tui_set_source_content_nil): Update.
3862 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3863 a bool.
3864 * tui/tui-data.c (init_content_element): Update.
3865
3866 2019-06-25 Tom Tromey <tom@tromey.com>
3867
3868 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3869 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3870 * tui/tui-layout.c (init_and_make_win): Update.
3871 * tui/tui.h (enum tui_win_type): Update.
3872 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3873 tui_win_is_auxillary.
3874 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3875 tui_win_is_auxillary.
3876
3877 2019-06-25 Tom Tromey <tom@tromey.com>
3878
3879 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3880 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3881 (tui_delete_data_content_windows, tui_display_all_data)
3882 (tui_data_window::do_scroll_vertical, tui_display_data_from):
3883 Update.
3884 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3885 * tui/tui-regs.c (tui_last_regs_line_no)
3886 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3887 (tui_show_registers): Update.
3888 (tui_show_register_group): Return void. Update.
3889 (tui_display_registers_from, tui_display_reg_element_at_line)
3890 (tui_display_registers_from_line, tui_check_register_values):
3891 Update.
3892 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3893 member.
3894 (struct tui_data_window) <regs_content>: Now a std::vector.
3895 <regs_content_count>: Remove.
3896 (tui_add_content_elements, tui_free_data_content): Don't declare.
3897 * tui/tui-data.c (tui_data_window::clear_detail): Update.
3898 (init_content_element): Remove DATA_WIN case. Add assert.
3899 (tui_add_content_elements): Remove.
3900 (tui_data_window): Update.
3901 (tui_free_data_content): Remove.
3902 (free_content_elements): Remove DATA_WIN case.
3903
3904 2019-06-25 Tom Tromey <tom@tromey.com>
3905
3906 * tui/tui-data.c (tui_data_item_window): Update.
3907 * tui/tui-windata.h (tui_check_data_values): Don't declare.
3908 * tui/tui-windata.c (tui_display_all_data)
3909 (tui_display_data_from_line): Update.
3910 (tui_check_data_values): Remove.
3911 * tui/tui-regs.c (tui_show_register_group)
3912 (tui_display_reg_element_at_line): Update.
3913 * tui/tui-hooks.c (tui_register_changed)
3914 (tui_refresh_frame_and_register_information): Call
3915 tui_check_register_values.
3916 * tui/tui-data.h (struct tui_data_window) <data_content,
3917 data_content_count, data_type>: Remove.
3918 (enum tui_data_type): Remove.
3919
3920 * tui/tui-data.c (tui_data_window::clear_detail)
3921 (~tui_data_window): Update.
3922
3923 2019-06-25 Tom Tromey <tom@tromey.com>
3924
3925 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3926 declare.
3927 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3928 Rename from tui_first_data_item_displayed. Update.
3929 (tui_data_window::refresh_all)
3930 (tui_data_window::do_scroll_vertical): Update.
3931 * tui/tui-data.h (struct tui_data_window)
3932 <first_data_item_displayed>: Declare new method.
3933
3934 2019-06-25 Tom Tromey <tom@tromey.com>
3935
3936 * tui/tui-data.h (tui_init_generic_part): Don't declare.
3937 * tui/tui-data.c (tui_init_generic_part): Remove, moving
3938 contents...
3939 (tui_initialize_static_data): ...here.
3940
3941 2019-06-25 Tom Tromey <tom@tromey.com>
3942
3943 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3944 (tui_display_registers_from, tui_check_register_values): Update.
3945 (tui_display_register): Remove win_info parameter; update.
3946 (tui_get_register): Change type of parameters.
3947 * tui/tui-data.h (struct tui_data_element): Remove.
3948 (union tui_which_element) <data>: Remove.
3949 <data_window>: Change type.
3950 (struct tui_data_item_window): New.
3951 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3952 case. Add assert.
3953 (~tui_data_item_window): New destructor.
3954 (free_content_elements): Remove DATA_ITEM_WIN case.
3955
3956 2019-06-25 Tom Tromey <tom@tromey.com>
3957
3958 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3959 Remove.
3960
3961 2019-06-25 Tom Tromey <tom@tromey.com>
3962
3963 * tui/tui-data.h (struct tui_command_element): Remove.
3964 (union tui_which_element) <command>: Remove.
3965 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
3966 assert.
3967 (free_content_elements): Remove CMD_WIN case.
3968
3969 2019-06-25 Tom Tromey <tom@tromey.com>
3970
3971 * tui/tui-layout.c (tui_set_layout): Update.
3972 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3973 * tui/tui-data.c (layout_def): Update.
3974
3975 2019-06-25 Tom Tromey <tom@tromey.com>
3976
3977 * tui/tui-wingeneral.c (tui_refresh_all): Update.
3978 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3979 (tui_source_window_base::set_new_height): Update.
3980 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3981 Update.
3982 (tui_set_locator_fullname, tui_set_locator_info)
3983 (tui_show_frame_info): Update.
3984 * tui/tui-source.c (tui_set_source_content)
3985 (tui_source_is_displayed): Update.
3986 * tui/tui-layout.c (show_source_disasm_command, show_data)
3987 (show_source_or_disasm_and_command): Update.
3988 * tui/tui-disasm.c (tui_set_disassem_content)
3989 (tui_get_begin_asm_address): Update.
3990 * tui/tui-data.h (struct tui_locator_element): Remove.
3991 (union tui_which_element) <locator>: Remove.
3992 (struct tui_locator_window): New.
3993 (tui_locator_win_info_ptr): Change return type.
3994 * tui/tui-data.c (_locator): Change type.
3995 (tui_locator_win_info_ptr): Change return type.
3996 (init_content_element): Remove LOCATOR_WIN case. Add assert.
3997 (tui_alloc_content): Add assert.
3998
3999 2019-06-25 Tom Tromey <tom@tromey.com>
4000
4001 * tui/tui-winsource.c
4002 (tui_exec_info_window::maybe_allocate_content): New method.
4003 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4004 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4005 (make_source_or_disasm_window): Add cast.
4006 * tui/tui-data.h (union tui_which_element) <simple_string>:
4007 Remove.
4008 (struct tui_source_info): New.
4009 (struct tui_source_window_base) <execution_info>: Change type.
4010 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4011 case, and add assert.
4012 (tui_alloc_content): Add assert.
4013
4014 2019-06-25 Tom Tromey <tom@tromey.com>
4015
4016 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4017 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4018 * tui/tui-data.c (tui_alloc_win_info): Remove.
4019
4020 2019-06-25 Tom Tromey <tom@tromey.com>
4021
4022 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4023 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4024 can_highlight.
4025
4026 2019-06-25 Tom Tromey <tom@tromey.com>
4027
4028 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4029 make_visible_with_new_height method.
4030 (tui_win_info::make_visible_with_new_height): New method.
4031 (tui_source_window_base::do_make_visible_with_new_height)
4032 (tui_data_window::do_make_visible_with_new_height)
4033 (tui_cmd_window::do_make_visible_with_new_height): New methods.
4034 (make_visible_with_new_height): Remove.
4035 (tui_resize_all, tui_adjust_win_heights): Use
4036 make_visible_with_new_height method.
4037 * tui/tui-data.h (struct tui_win_info)
4038 <do_make_visible_with_new_height, make_visible_with_new_height>:
4039 New methods.
4040 (struct tui_source_window_base, struct tui_data_window)
4041 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4042 methods.
4043
4044 2019-06-25 Tom Tromey <tom@tromey.com>
4045
4046 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4047 method.
4048 (update_tab_width): Call update_tab_width method.
4049 * tui/tui-data.h (struct tui_win_info)
4050 (struct tui_source_window_base) <update_tab_width>: New methods.
4051
4052 2019-06-25 Tom Tromey <tom@tromey.com>
4053
4054 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4055 parameter.
4056 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4057 parameter.
4058 (tui_gen_win_info::make_visible): Update.
4059 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4060 parameter.
4061 * tui/tui-data.h (enum tui_box): New enum.
4062 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4063
4064 2019-06-25 Tom Tromey <tom@tromey.com>
4065
4066 * tui/tui-layout.c (make_source_or_disasm_window): Always use
4067 init_and_make_win for EXEC_INFO_WIN.
4068 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4069 longer inline.
4070 (struct tui_win_info) <~tui_win_info>: Inline.
4071 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4072 Don't declare.
4073 * tui/tui-data.c (source_win, disasm_win): Remove globals.
4074 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4075 Remove.
4076 (tui_initialize_static_data): Update.
4077 (~tui_gen_win_info): Handle more cleanup here.
4078 (~tui_source_window_base): Delete "execution_info".
4079 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4080
4081 2019-06-25 Tom Tromey <tom@tromey.com>
4082
4083 * tui/tui-layout.c (make_command_window): Don't set
4084 can_highlight.
4085 (show_source_disasm_command): Call the reset method.
4086 (show_data): Don't set can_highlight. Call the reset method.
4087 (tui_gen_win_info::reset): Rename from init_gen_win_info
4088 (init_and_make_win): Simplify. Return tui_gen_win_info.
4089 (show_source_or_disasm_and_command): Call the reset method.
4090 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4091 (struct tui_cmd_window): Set can_highlight.
4092
4093 2019-06-25 Tom Tromey <tom@tromey.com>
4094
4095 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4096 from make_visible.
4097 (tui_make_visible, tui_make_invisible): Rewrite.
4098 (tui_win_info::make_visible): Remove.
4099 (tui_source_window_base::make_visible): Update.
4100 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4101 method. Moved from...
4102 (struct tui_win_info) <make_visible>: ...here.
4103
4104 2019-06-25 Tom Tromey <tom@tromey.com>
4105
4106 * tui/tui-winsource.c
4107 (tui_source_window_base::do_scroll_horizontal): Remove direction
4108 parameter.
4109 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4110 direction parameter.
4111 * tui/tui-win.c (tui_win_info::forward_scroll)
4112 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4113 (tui_win_info::right_scroll): Update.
4114 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4115 direction parameter.
4116 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4117 direction parameter.
4118 * tui/tui-data.h (enum tui_scroll_direction): Remove.
4119 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4120 Remove direction parameter.
4121 (struct tui_source_window_base, struct tui_source_window)
4122 (struct tui_disasm_window, struct tui_data_window)
4123 (struct tui_cmd_window): Update.
4124
4125 2019-06-25 Tom Tromey <tom@tromey.com>
4126
4127 * tui/tui-winsource.h (tui_set_exec_info_content)
4128 (tui_show_exec_info_content, tui_erase_exec_info_content)
4129 (tui_clear_exec_info_content, tui_update_exec_info): Change
4130 argument to tui_source_window_base.
4131 * tui/tui-winsource.c (tui_set_exec_info_content)
4132 (tui_show_exec_info_content, tui_erase_exec_info_content)
4133 (tui_clear_exec_info_content, tui_update_exec_info): Change
4134 argument to tui_source_window_base.
4135
4136 2019-06-25 Tom Tromey <tom@tromey.com>
4137
4138 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4139 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4140
4141 2019-06-25 Tom Tromey <tom@tromey.com>
4142
4143 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4144 check.
4145
4146 2019-06-25 Tom Tromey <tom@tromey.com>
4147
4148 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4149 type to void.
4150 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4151 type to void.
4152 * tui/tui-source.c (tui_set_source_content): Update.
4153 * tui/tui-disasm.c (tui_set_disassem_content): Update.
4154
4155 2019-06-25 Tom Tromey <tom@tromey.com>
4156
4157 * tui/tui-win.c (window_name_completer, tui_set_focus)
4158 (tui_all_windows_info): Use name method.
4159 * tui/tui-data.h (struct tui_gen_win_info)
4160 (struct tui_source_window, struct tui_disasm_window)
4161 (struct tui_data_window, struct tui_cmd_window) <name>: New
4162 method.
4163 (tui_win_name): Don't declare.
4164 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4165 (tui_win_name): Remove.
4166
4167 2019-06-25 Tom Tromey <tom@tromey.com>
4168
4169 * tui/tui-winsource.h (tui_update_source_window)
4170 (tui_update_source_window_as_is): Change parameter type.
4171 * tui/tui-winsource.c (tui_update_source_window): Change win_info
4172 to be a tui_source_window_base.
4173 (tui_update_source_window_as_is): Likewise.
4174 * tui/tui-win.c (make_visible_with_new_height): Update.
4175
4176 2019-06-25 Tom Tromey <tom@tromey.com>
4177
4178 * tui/tui-winsource.c (tui_erase_source_content)
4179 (tui_show_source_content, tui_show_exec_info_content)
4180 (tui_erase_exec_info_content): Use refresh_window method.
4181 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4182 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4183 from tui_refresh_win.
4184 (tui_data_window::refresh_window): New method.
4185 (tui_win_info::refresh, tui_source_window_base::refresh)
4186 (tui_refresh_all): Use refresh_window method.
4187 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4188 method.
4189 * tui/tui-regs.c (tui_display_register): Call refresh_window
4190 method.
4191 * tui/tui-layout.c (show_source_disasm_command)
4192 (show_source_or_disasm_and_command): Call refresh_window method.
4193 * tui/tui-data.h (struct tui_gen_win_info)
4194 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4195 New method.
4196
4197 2019-06-25 Tom Tromey <tom@tromey.com>
4198
4199 * tui/tui.c (tui_rl_other_window, tui_enable)
4200 (tui_is_window_visible, tui_get_command_dimension): Update.
4201 * tui/tui-winsource.c (tui_update_source_window_as_is)
4202 (tui_clear_source_content, tui_erase_source_content)
4203 (tui_show_source_line, tui_source_window_base::refill)
4204 (tui_source_window_base::do_scroll_horizontal)
4205 (tui_source_window_base::set_is_exec_point_at)
4206 (tui_update_breakpoint_info, tui_set_exec_info_content)
4207 (tui_alloc_source_buffer, tui_line_is_displayed)
4208 (tui_addr_is_displayed): Update.
4209 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4210 (tui_check_and_display_highlight_if_needed)
4211 (tui_win_info::make_visible, tui_win_info::refresh)
4212 (tui_refresh_all): Update.
4213 * tui/tui-windata.c (tui_first_data_item_displayed)
4214 (tui_delete_data_content_windows, tui_erase_data_content)
4215 (tui_display_all_data, tui_data_window::refresh_all)
4216 (tui_check_data_values): Update.
4217 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4218 (tui_set_win_focus_to, tui_win_info::forward_scroll)
4219 (tui_win_info::backward_scroll, tui_refresh_all_win)
4220 (tui_resize_all, tui_set_focus, tui_all_windows_info)
4221 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4222 (tui_source_window_base::set_new_height)
4223 (tui_data_window::set_new_height)
4224 (make_invisible_and_set_new_height)
4225 (make_visible_with_new_height, new_height_ok)
4226 (parse_scrolling_args): Update.
4227 * tui/tui-stack.c (tui_show_frame_info): Update.
4228 * tui/tui-source.c (tui_set_source_content)
4229 (tui_set_source_content_nil, tui_source_is_displayed)
4230 (tui_source_window::do_scroll_vertical): Update.
4231 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4232 (tui_display_registers_from, tui_display_reg_element_at_line)
4233 (tui_check_register_values, tui_reg_command): Update.
4234 * tui/tui-layout.c (tui_default_win_height)
4235 (show_source_disasm_command, show_data, init_and_make_win)
4236 (show_source_or_disasm_and_command): Update.
4237 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4238 (tui_redisplay_readline, tui_mld_flush)
4239 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4240 (tui_getc): Update.
4241 * tui/tui-disasm.c (tui_set_disassem_content)
4242 (tui_disasm_window::do_scroll_vertical): Update.
4243 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4244 Now virtual.
4245 (struct tui_win_info): Derive from tui_gen_win_info.
4246 <~tui_win_info>: Mark as override.
4247 <generic>: Remove member.
4248 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4249 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4250 (~tui_data_window, ~tui_win_info)
4251 (tui_free_all_source_wins_content): Update.
4252 * tui/tui-command.c (tui_refresh_cmd_win): Update.
4253
4254 2019-06-25 Tom Tromey <tom@tromey.com>
4255
4256 * tui/tui-layout.c (init_and_make_win): Use new.
4257 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4258 destructor, initializers.
4259 (tui_alloc_generic_win_info): Don't declare.
4260 * tui/tui-data.c (_locator): Add argument to constructor.
4261 (source_win, disasm_win): New globals.
4262 (exec_info): Remove.
4263 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4264 Update.
4265 (tui_alloc_generic_win_info): Remove.
4266 (init_content_element): Use new.
4267 (tui_win_info::tui_win_info): Update.
4268 (free_content_elements) <case DATA_WIN>: Use delete.
4269
4270 2019-06-25 Tom Tromey <tom@tromey.com>
4271
4272 * tui/tui-wingeneral.c (tui_refresh_win): Update.
4273 * tui/tui-windata.c (tui_first_data_item_displayed)
4274 (tui_delete_data_content_windows): Update.
4275 * tui/tui-win.c (tui_data_window::set_new_height): Update.
4276 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4277 (tui_display_registers_from, tui_check_register_values): Update.
4278 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4279 pointer.
4280 * tui/tui-data.c (init_content_element): Update. Allocate the new
4281 window.
4282 (tui_free_data_content): Update.
4283 (free_content_elements) <case DATA_WIN>: Free the window.
4284
4285 2019-06-25 Tom Tromey <tom@tromey.com>
4286
4287 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4288 Update.
4289 * tui/tui-layout.c (make_command_window)
4290 (show_source_disasm_command, show_data, init_and_make_win)
4291 (show_source_or_disasm_and_command): Update.
4292 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4293 method.
4294 <can_highight, is_highlighted>: Now bool.
4295 (tui_set_win_highlight): Don't declare.
4296 * tui/tui-data.c (tui_set_win_highlight): Remove.
4297
4298 2019-06-25 Tom Tromey <tom@tromey.com>
4299
4300 * tui/tui-wingeneral.c (make_visible): Remove check of window
4301 type.
4302
4303 2019-06-25 Tom Tromey <tom@tromey.com>
4304
4305 * tui/tui-win.c (tui_win_info::max_height)
4306 (tui_cmd_window::max_height): New methods.
4307 (new_height_ok): Call max_height.
4308 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4309 <max_height>: New method.
4310
4311 2019-06-25 Tom Tromey <tom@tromey.com>
4312
4313 * tui/tui-win.c (tui_source_window_base::set_new_height)
4314 (tui_data_window::set_new_height): New methods.
4315 (make_invisible_and_set_new_height): Call set_new_height method.
4316 * tui/tui-data.h (struct tui_win_info)
4317 (struct tui_source_window_base, struct tui_data_window)
4318 <set_new_height>: New method.
4319
4320 2019-06-25 Tom Tromey <tom@tromey.com>
4321
4322 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4323 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4324 tui_refresh_data_win.
4325 * tui/tui-win.c (tui_source_window_base::refresh_all): New
4326 method.
4327 (tui_refresh_all_win): Call the refresh_all method.
4328 (tui_set_focus): Likewise.
4329 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4330 (struct tui_source_window_base, struct tui_data_window) <refresh>:
4331 Likewise.
4332
4333 2019-06-25 Tom Tromey <tom@tromey.com>
4334
4335 * tui/tui-winsource.h (tui_refill_source_window)
4336 (tui_set_is_exec_point_at): Don't declare.
4337 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4338 (tui_source_window_base::refill): Rename from
4339 tui_refill_source_window.
4340 (tui_source_window_base::do_scroll_horizontal): Update.
4341 (tui_source_window_base::set_is_exec_point_at): Rename from
4342 tui_set_is_exec_point_at.
4343 (tui_update_all_breakpoint_info): Update.
4344 * tui/tui-stack.c (tui_show_frame_info): Update.
4345 * tui/tui-layout.c (show_data): Add cast.
4346 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4347 * tui/tui-data.h (struct tui_source_window_base) <refill,
4348 set_is_exec_point_at>: New methods.
4349 (tui_source_windows, tui_add_to_source_windows): Update types.
4350 (tui_add_to_source_windows): Remove redundant declaration.
4351 * tui/tui-data.c (source_windows): Store tui_source_window_base.
4352 (tui_source_windows): Change return type.
4353 (tui_clear_source_windows_detail): Update.
4354 (tui_add_to_source_windows): Change type of parameter.
4355 (tui_free_all_source_wins_content): Update.
4356
4357 2019-06-25 Tom Tromey <tom@tromey.com>
4358
4359 * tui/tui-wingeneral.c (tui_win_info::refresh)
4360 (tui_source_window_base::refresh): New methods.
4361 (tui_refresh_all): Call the refresh method.
4362 * tui/tui-data.h (struct tui_win_info)
4363 (struct tui_source_window_base) <refresh>: New method.
4364
4365 2019-06-25 Tom Tromey <tom@tromey.com>
4366
4367 * tui/tui.h (tui_is_window_visible): Return bool.
4368 * tui/tui.c (tui_is_window_visible): Return bool.
4369 * tui/tui-wingeneral.c (tui_make_window, make_visible)
4370 (tui_make_visible, tui_make_invisible)
4371 (tui_win_info::make_visible)
4372 (tui_source_window_base::make_visible, make_all_visible)
4373 (tui_make_all_visible, tui_make_all_invisible): Update.
4374 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4375 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4376 bool.
4377 (struct tui_win_info, struct tui_source_window_base)
4378 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4379 * tui/tui-data.c (tui_init_generic_part): Update.
4380
4381 2019-06-25 Tom Tromey <tom@tromey.com>
4382
4383 * tui/tui-wingeneral.c (tui_win_info::make_visible)
4384 (tui_source_window_base::make_visible): New methods.
4385 (make_all_visible): Make method call.
4386 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4387 (struct tui_source_window_base, struct tui_cmd_window): Override
4388 make_visible.
4389 (tui_win_is_source_type): Don't declare.
4390 * tui/tui-data.c (tui_win_is_source_type): Remove.
4391
4392 2019-06-25 Tom Tromey <tom@tromey.com>
4393
4394 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4395 NULL check.
4396
4397 2019-06-25 Tom Tromey <tom@tromey.com>
4398
4399 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4400 Inline constructor. Add initializers for members.
4401 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4402 constructors; now inline in class.
4403
4404 2019-06-25 Tom Tromey <tom@tromey.com>
4405
4406 * tui/tui-regs.c (tui_show_registers): Update.
4407 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4408 bool.
4409 * tui/tui-data.c (tui_data_window::clear_detail)
4410 (tui_data_window): Update.
4411
4412 2019-06-25 Tom Tromey <tom@tromey.com>
4413
4414 * tui/tui-windata.c (tui_display_all_data)
4415 (tui_display_data_from_line, tui_display_data_from)
4416 (tui_check_data_values, tui_data_window::do_scroll_vertical):
4417 Update.
4418 * tui/tui-regs.c (tui_last_regs_line_no)
4419 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4420 (tui_show_registers, tui_show_register_group)
4421 (tui_display_registers_from, tui_display_reg_element_at_line)
4422 (tui_display_registers_from_line, tui_check_register_values)
4423 (tui_reg_next, tui_reg_prev): Update.
4424 * tui/tui-layout.c (tui_set_layout, show_data): Update.
4425 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
4426 tui_data_window.
4427 (struct tui_win_info) <detail>: Remove. Add new fields from
4428 tui_data_info.
4429 (TUI_DATA_WIN): Add cast.
4430 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4431 (~tui_data_window): Simplify.
4432
4433 2019-06-25 Tom Tromey <tom@tromey.com>
4434
4435 * tui/tui-layout.c (show_source_disasm_command)
4436 (show_source_or_disasm_and_command): Update.
4437 * tui/tui-io.c (update_cmdwin_start_line)
4438 (tui_redisplay_readline): Update.
4439 * tui/tui-data.h (struct tui_command_info): Remove.
4440 (struct tui_win_info) <detail>: Remove command_info member.
4441 (struct tui_data_window) <start_line>: New member, from
4442 tui_command_info.
4443 (TUI_CMD_WIN): Add casts.
4444
4445 2019-06-25 Tom Tromey <tom@tromey.com>
4446
4447 * tui/tui-winsource.c (tui_update_source_window)
4448 (tui_refill_source_window)
4449 (tui_source_window_base::do_scroll_horizontal)
4450 (tui_update_breakpoint_info, tui_set_exec_info_content)
4451 (tui_show_exec_info_content, tui_erase_exec_info_content)
4452 (tui_clear_exec_info_content): Update.
4453 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4454 Update.
4455 * tui/tui-win.c (make_invisible_and_set_new_height)
4456 (make_visible_with_new_height): Update.
4457 * tui/tui-source.c (tui_set_source_content)
4458 (tui_show_symtab_source): Update.
4459 * tui/tui-layout.c (extract_display_start_addr)
4460 (show_source_disasm_command, show_data)
4461 (make_source_or_disasm_window)
4462 (show_source_or_disasm_and_command): Update.
4463 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4464 (tui_disasm_window::do_scroll_vertical): Remove shadowing
4465 "gdbarch".
4466 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
4467 to tui_source_window_base.
4468 (struct tui_win_info) <detail>: Remove source_info member.
4469 (struct tui_source_window_base) <has_locator>: Inline.
4470 Move contents from tui_source_info; rename has_locator member to
4471 m_has_locator.
4472 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4473 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4474 header file.
4475 (tui_source_window_base::clear_detail, ~tui_source_window_base):
4476 Simplify.
4477 (tui_free_all_source_wins_content): Cast to
4478 tui_source_window_base.
4479
4480 2019-06-25 Tom Tromey <tom@tromey.com>
4481
4482 * tui/tui-win.c (make_invisible_and_set_new_height)
4483 (make_visible_with_new_height): Call has_locator method.
4484 * tui/tui-layout.c (show_source_disasm_command, show_data)
4485 (show_source_or_disasm_and_command): Update for bool change.
4486 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4487 (tui_win_info) <has_locator>: New method.
4488 (struct tui_source_window_base) <has_locator>: New method.
4489 (tui_win_has_locator): Don't declare.
4490 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4491 from tui_win_has_locator.
4492 (tui_source_window_base): Use false, not FALSE.
4493
4494 2019-06-25 Tom Tromey <tom@tromey.com>
4495
4496 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4497 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4498 clear_detail method directly.
4499 (tui_clear_win_detail): Remove.
4500
4501 2019-06-25 Tom Tromey <tom@tromey.com>
4502
4503 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4504 "this", not TUI_DISASM_WIN.
4505
4506 2019-06-25 Tom Tromey <tom@tromey.com>
4507
4508 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
4509 declare.
4510 * tui/tui-winsource.c
4511 (tui_source_window_base::do_scroll_horizontal): Rename from
4512 tui_horizontal_source_scroll.
4513 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4514 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4515 from tui_vertical_data_scroll.
4516 * tui/tui-win.h (tui_scroll): Don't declare.
4517 * tui/tui-win.c (tui_win_info::forward_scroll)
4518 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4519 (tui_win_info::right_scroll): Rename and update.
4520 (tui_scroll_forward_command, tui_scroll_backward_command)
4521 (tui_scroll_left_command, tui_scroll_right_command): Update.
4522 (tui_scroll): Remove.
4523 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4524 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4525 from tui_vertical_source_scroll.
4526 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4527 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4528 from tui_vertical_disassem_scroll.
4529 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4530 do_scroll_horizontal>: New methods.
4531 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4532 Likewise.
4533 (struct tui_source_window_base): Add do_scroll_horizontal.
4534 (struct tui_source_window, struct tui_disasm_window): Add
4535 do_scroll_vertical.
4536 (struct tui_data_window, struct tui_cmd_window): Add
4537 do_scroll_horizontal and do_scroll_vertical.
4538 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4539
4540 2019-06-25 Tom Tromey <tom@tromey.com>
4541
4542 * tui/tui-data.h (struct tui_source_window_base): New struct.
4543 (struct tui_source_window): Derive from tui_source_window_base.
4544 (struct tui_disasm_window): New struct.
4545 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4546 from tui_source_window::clear_detail.
4547 (tui_source_window_base): Rename from tui_source_window.
4548 (~tui_source_window_base): Rename from ~tui_source_window.
4549 (tui_alloc_win_info): Create a tui_disasm_window.
4550
4551 2019-06-25 Tom Tromey <tom@tromey.com>
4552
4553 * tui/tui-data.h (struct tui_source_window)
4554 (struct tui_data_window): Declare destructors.
4555 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4556 destructors.
4557 (tui_win_info): Simplify.
4558
4559 2019-06-25 Tom Tromey <tom@tromey.com>
4560
4561 * tui/tui-winsource.c (tui_display_main)
4562 (tui_update_source_windows_with_addr)
4563 (tui_update_all_breakpoint_info): Update.
4564 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4565 (new_height_ok, parse_scrolling_args): Update.
4566 * tui/tui-stack.c (tui_show_frame_info): Update.
4567 * tui/tui-data.h (struct tui_list): Remove.
4568 (tui_source_windows): Return a reference to a std::vector.
4569 * tui/tui-data.c (source_windows): Now a std::vector.
4570 (tui_source_windows): Change return type.
4571 (tui_clear_source_windows): Rewrite.
4572 (tui_clear_source_windows_detail, tui_add_to_source_windows)
4573 (tui_free_all_source_wins_content): Rewrite.
4574
4575 2019-06-25 Tom Tromey <tom@tromey.com>
4576
4577 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4578 (struct tui_data_window, struct tui_cmd_window): Declare
4579 clear_detail method.
4580 * tui/tui-data.c (tui_source_window::clear_detail)
4581 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4582 methods.
4583 (tui_clear_win_detail): Simplify.
4584
4585 2019-06-25 Tom Tromey <tom@tromey.com>
4586
4587 * tui/tui-layout.c (make_source_window, make_disasm_window)
4588 (make_source_or_disasm_window): Remove win_info_ptr parameter.
4589 Return the new window.
4590 (show_source_disasm_command, show_data)
4591 (show_source_or_disasm_and_command): Update.
4592
4593 2019-06-25 Tom Tromey <tom@tromey.com>
4594
4595 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4596 parameter. Return the new window.
4597 (show_source_disasm_command): Update and remove NULL check.
4598 (show_source_or_disasm_and_command): Update.
4599
4600 2019-06-25 Tom Tromey <tom@tromey.com>
4601
4602 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4603
4604 2019-06-25 Tom Tromey <tom@tromey.com>
4605
4606 * tui/tui-data.h (struct tui_win_info): Make constructor
4607 protected. Make destructor virtual. Add initializers.
4608 (tui_source_window, tui_data_window, tui_cmd_window): New
4609 classes.
4610 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
4611 constructor. Add "type" parameter.
4612 (tui_source_window, tui_data_window, tui_cmd_window): New
4613 constructors.
4614 (tui_alloc_win_info): Instantiate the appropriate subclass.
4615
4616 2019-06-25 Tom Tromey <tom@tromey.com>
4617
4618 * tui/tui-win.c (tui_resize_all): Use delete.
4619 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4620 destructor.
4621 (tui_free_window): Don't declare.
4622 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4623 Update.
4624
4625 2019-06-25 Tom Tromey <tom@tromey.com>
4626
4627 * tui/tui-data.h (struct tui_win_info): Add constructor.
4628 * tui/tui-data.c (tui_alloc_win_info): Use new.
4629 (tui_free_window): Use delete.
4630
4631 2019-06-22 Tom Tromey <tom@tromey.com>
4632
4633 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4634 declare.
4635 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4636
4637 2019-06-22 Tom Tromey <tom@tromey.com>
4638
4639 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4640 declare.
4641 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4642
4643 2019-06-22 Tom de Vries <tdevries@suse.de>
4644
4645 * dwarf2read.c (create_addrmap_from_aranges)
4646 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4647 instead of '%zu'.
4648
4649 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
4650
4651 * dwarf2read.h (dwarf2_section_info_def): Remove.
4652 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4653 * dwarf2read.c (struct dwo_sections) <types>: Change type to
4654 std::vector<dwarf2_section_info>.
4655 (struct dwo_file) <~dwo_file>: Remove.
4656 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4657 types field.
4658 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4659 (dwarf2_read_debug_names): Likewise.
4660 (create_debug_types_hash_table): Change parameter type to
4661 array_view, adjust code accordingly.
4662 (dwarf2_locate_dwo_sections): Adjust to std::vector.
4663 (partial_die_info::fixup): Likewise.
4664 (determine_prefix): Likewise.
4665 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4666
4667 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4668
4669 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4670 gdb_bfd_ref_ptr.
4671 <~dwo_file>: Remove call to gdb_bfd_unref.
4672 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4673 gdb_bfd_ref_ptr::get.
4674
4675 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4676
4677 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4678 type to htab_up.
4679 * dwarf2read.c (struct dwo_file): Initialize fields.
4680 <~dwo_file>: New.
4681 (free_dwo_file): Remove, move content to ~dwo_file.
4682 (struct dwo_file_deleter): Remove.
4683 (dwo_file_up>: Remove custom deleter.
4684 (free_dwo_files): Remove.
4685 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4686 dwo_files.
4687 (process_skeletonless_type_units): Call unique_ptr::get.
4688 (allocate_dwo_file_hash_table): Add deleter to created hash
4689 table. Change return type to htab_up.
4690 (lookup_dwo_file_slot): Don't memset dwo_file, call
4691 unique_ptr::get.
4692 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4693 (create_dwo_unit_in_dwp_v2): Likewise.
4694 (open_and_init_dwo_file): Likewise.
4695 (free_dwo_file_from_slot): Remove.
4696
4697 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4698
4699 * dwarf2read.h (struct dwarf2_section_info) <readin,
4700 is_virtual>: Change type to bool.
4701 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4702 true instead of 1.
4703
4704 2019-06-19 Tom Tromey <tom@tromey.com>
4705
4706 * tui/tui-data.h (tui_init_content_element): Don't declare.
4707
4708 2019-06-19 Tom Tromey <tom@tromey.com>
4709
4710 * tui/tui-data.h (tui_init_win_info): Don't declare.
4711
4712 2019-06-19 Tom de Vries <tdevries@suse.de>
4713
4714 * dwarf2read.h (abstract_to_concrete): Change type to
4715 std::unordered_map<sect_offset, std::vector<sect_offset>,
4716 gdb::hash_enum<sect_offset>>.
4717
4718 2019-06-19 Tom Tromey <tromey@adacore.com>
4719
4720 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4721 EVAL_AVOID_SIDE_EFFECTS specially.
4722
4723 2019-06-19 Tom Tromey <tromey@adacore.com>
4724
4725 * source-cache.c (highlighter): New global.
4726 (source_cache::get_source_lines): Create a highlighter on demand.
4727
4728 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
4729
4730 * defs.h (deprecated_interactive_hook): Delete declaration.
4731 * interps.c (clear_interpreter_hooks): Remove use of
4732 deprecated_interactive_hook.
4733 * top.c (deprecated_interactive_hook): Delete definition.
4734 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4735
4736 2019-06-18 Tom de Vries <tdevries@suse.de>
4737
4738 PR gdb/24515
4739 * dwarf2read.h (abstract_to_concrete): Change type from
4740 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4741 std::unordered_map<sect_offset, std::vector<sect_offset>>.
4742 * dwarf2read.c (read_variable): Update.
4743 (dwarf2_fetch_die_loc_sect_off): Update.
4744
4745 2019-06-17 Tom de Vries <tdevries@suse.de>
4746
4747 PR gdb/24617
4748 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4749 accessing parent[parent_len - 1].
4750
4751 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
4752
4753 PR gdb/24364
4754 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4755 call dtrace_process_dof with NULL dof.
4756
4757 2019-06-16 Tom de Vries <tdevries@suse.de>
4758
4759 PR gdb/24445
4760 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4761
4762 2019-06-16 Tom Tromey <tom@tromey.com>
4763
4764 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4765 (make_all_visible): Use address of member.
4766
4767 2019-06-16 Tom Tromey <tom@tromey.com>
4768
4769 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4770 (tui_free_window, free_content, free_content_elements): Remove
4771 unnecessary cast.
4772 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4773 cast.
4774 * tui/tui-regs.c (tui_show_register_group)
4775 (tui_display_registers_from, tui_display_reg_element_at_line):
4776 Remove unnecessary cast.
4777
4778 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
4779
4780 * linux-nat.c (normal_mask): Delete.
4781 (_initialize_linux_nat): Don't initialise normal_mask.
4782
4783 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
4784
4785 PR gdb/24445
4786 * dwarf-index-write.h (write_psymtabs_to_index): Add
4787 dwz_basename parameter.
4788 * dwarf-index-write.c (write_gdbindex): Move file writing to
4789 write_gdbindex_1. Change return type void.
4790 (assert_file_size): Move up, remove filename parameter.
4791 (write_gdbindex_1): New function.
4792 (write_debug_names): Change return type to void, call
4793 assert_file_size.
4794 (struct index_wip_file): New struct.
4795 (write_psymtabs_to_index): Add dwz_basename parameter. Move
4796 file logic to index_wip_file. Write index for dwz file if
4797 needed.
4798 (save_gdb_index_command): Pass basename of dwz file, if present.
4799 * dwarf-index-cache.c (index_cache::store): Obtain and pass
4800 build-id of dwz file, if present.
4801 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4802 (dwarf2_get_dwz_file): Likewise.
4803 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4804 (dwarf2_get_dwz_file): Likewise.
4805
4806 2019-06-16 Tom Tromey <tom@tromey.com>
4807
4808 * coffread.c (process_coff_symbol): Use xstrdup.
4809 * value.c (create_internalvar): Use xstrdup.
4810
4811 2019-06-16 Tom Tromey <tom@tromey.com>
4812
4813 * valops.c (value_cast, value_slice): Remove unnecessary cast.
4814 * breakpoint.c (stopin_command, stopat_command)
4815 (until_break_command, decode_location_default): Remove unnecessary
4816 cast.
4817 * utils.c (subset_compare): Remove unnecessary cast.
4818 * ada-lang.c (ada_update_initial_language): Remove unnecessary
4819 cast.
4820 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4821 cast.
4822 * infcmd.c (path_command): Remove unnecessary cast.
4823 * coffread.c (decode_type): Remove unnecessary cast.
4824 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4825 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4826 * tui/tui-stack.c (tui_show_locator_content)
4827 (tui_show_frame_info): Remove unnecessary cast.
4828 * tui/tui-win.c (tui_scroll_forward_command)
4829 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4830 (parse_scrolling_args): Remove unnecessary cast.
4831 * tui/tui-data.c (init_win_info, tui_del_window)
4832 (tui_free_window, tui_del_data_windows, tui_free_data_content)
4833 (free_content_elements): Remove unnecessary cast.
4834 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4835 unnecessary cast.
4836 * tui/tui-source.c (tui_set_source_content)
4837 (tui_vertical_source_scroll): Remove unnecessary cast.
4838 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4839 cast.
4840 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4841 * tui/tui-regs.c (tui_display_registers_from)
4842 (tui_display_register): Remove unnecessary cast.
4843 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4844 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4845 (make_visible): Remove unnecessary cast.
4846 * tui/tui-winsource.c (tui_erase_source_content)
4847 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4848 unnecessary cast.
4849 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4850 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4851 * stabsread.c (read_type, read_array_type, read_range_type):
4852 Remove unnecessary cast.
4853 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4854 (parse_symbol, parse_type, upgrade_type, parse_external)
4855 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4856 unnecessary cast.
4857 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4858
4859 2019-06-16 Tom Tromey <tom@tromey.com>
4860
4861 * tui/tui-data.c (tui_alloc_generic_win_info)
4862 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4863 checks.
4864
4865 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
4866 Andrew Burgess <andrew.burgess@embecosm.com>
4867
4868 * f-typeprint.c (f_print_type): Don't return early for not
4869 associated or not allocated types.
4870 (f_type_print_varspec_suffix): Add print_rank parameter and print
4871 ranks of array types in case they dangling.
4872 (f_type_print_base): Add print_rank parameter.
4873
4874 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4875
4876 * NEWS: Mention new MI commands.
4877 * break-catch-throw.c (enum exception_event_kind): Move to
4878 breakpoint.h.
4879 (print_mention_exception_catchpoint): Output text as a single
4880 message.
4881 (catch_exception_command_1): Rename to...
4882 (catch_exception_event): ...this, make non-static, update header
4883 command, and change some parameter types.
4884 (catch_catch_command): Update for changes to
4885 catch_exception_command_1.
4886 (catch_throw_command): Likewise.
4887 (catch_rethrow_command): Likewise.
4888 * breakpoint.c (enum exception_event_kind): Delete.
4889 * breakpoint.h (enum exception_event_kind): Moved here from
4890 break-catch-throw.c.
4891 (catch_exception_event): Declare.
4892 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4893 (mi_cmd_catch_throw): New function.
4894 (mi_cmd_catch_rethrow): New function.
4895 (mi_cmd_catch_catch): New function.
4896 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4897 'catch-catch' entries.
4898 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4899 (mi_cmd_catch_rethrow): Declare.
4900 (mi_cmd_catch_catch): Declare.
4901
4902 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4903
4904 * annotate.c (annotate_source_line): Change return type to void,
4905 update implementation to match.
4906 * annotate.h (annotate_source_line): Change return type to void,
4907 update header comment.
4908 * stack.c (print_frame_info): Don't change what frame information
4909 is printed based on whether annotations are on or not.
4910
4911 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4912
4913 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4914 (annotate_source): Make static.
4915 (annotate_source_line): Moved from source.c and renamed from
4916 identify_source_line. Update the return type.
4917 * annotate.h (annotate_source): Delete declaration.
4918 (annotate_source_line): Declaration moved from source.h, and
4919 renamed from identify_source_line. Return type updated.
4920 * source.c (identify_source_line): Moved to annotate.c and renamed
4921 to annotate_source_line.
4922 (info_line_command): Remove check of annotation_level.
4923 * source.h (identify_source_line): Move declaration to annotate.h
4924 and rename to annotate_source_line.
4925 * stack.c: Add 'annotate.h' include.
4926 (print_frame_info): Remove check of annotation_level before
4927 calling annotate_source_line.
4928
4929 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4930
4931 * source-cache.c (source_cache::get_plain_source_lines): Use
4932 open_source_file_with_line_charpos instead of just
4933 open_source_file, remove call to find_source_lines.
4934 (source_cache::get_source_lines): Likewise.
4935 * source.c (find_source_lines): Make static.
4936 (get_filename_and_charpos): Renamed into...
4937 (open_source_file_with_line_charpos): ..this along with changes to
4938 return a scoped_fd, and some other minor clean ups.
4939 (identify_source_line): Use open_source_file_with_line_charpos.
4940 (search_command_helper): Use open_source_file_with_line_charpos
4941 instead of just open_source_file, remove call to
4942 find_source_lines.
4943 * source.h (open_source_file_with_line_charpos): Declare new
4944 function.
4945 (find_source_lines): Delete declaration.
4946
4947 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4948
4949 * source.c (get_filename_and_charpos): Remove fullname
4950 parameter.
4951 (identify_source_line): Update call to get_filename_and_charpos.
4952
4953 2019-06-14 Tom Tromey <tromey@adacore.com>
4954
4955 PR gdb/24502:
4956 * ui-style.h (skip_ansi_escape): Update comment.
4957 * ui-file.h (class no_terminal_escape_file): New class.
4958 * ui-file.c (no_terminal_escape_file::write)
4959 (no_terminal_escape_file::puts): New methods.
4960 * cli/cli-logging.c (handle_redirections): Use
4961 no_terminal_escape_file.
4962
4963 2019-06-14 Tom Tromey <tromey@adacore.com>
4964
4965 * NEWS: Move convenience variable news above Python news.
4966
4967 2019-06-14 Tom Tromey <tom@tromey.com>
4968
4969 * gnulib: Move directory to top-level.
4970 * configure.ac: Don't configure gnulib.
4971 * configure: Rebuild.
4972 * common/common-defs.h: Use new path to gnulib.
4973 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4974 (GNULIB_H): Remove.
4975 (INCGNU): Look in new gnulib location.
4976 (HFILES_NO_SRCDIR): Remove gnulib files.
4977 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4978 (generated_files): Remove GNULIB_H.
4979 ($(LIBGNU), all-lib): Remove targets.
4980 (distclean): Don't mention GNULIB_BUILDDIR.
4981 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4982
4983 2019-06-14 Tom Tromey <tromey@adacore.com>
4984
4985 * symfile.c (add_symbol_file_command): Remove obsolete comment.
4986 Warn if symbol file does not provide any symbols.
4987
4988 2019-06-14 Tom Tromey <tromey@adacore.com>
4989
4990 * source.c (find_and_open_source): Respect basenames_may_differ.
4991
4992 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
4993
4994 * annotate.c (annotate_breakpoints_invalid): Make use of
4995 scoped_restore_terminal_state.
4996 (annotate_frames_invalid): Likewise.
4997
4998 2019-06-14 Tom Tromey <tromey@adacore.com>
4999
5000 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5001 allow assignment to an internalvar.
5002
5003 2019-06-14 Tom Tromey <tromey@adacore.com>
5004
5005 * ada-lex.l: Allow "_" in attribute names.
5006
5007 2019-06-14 Tom Tromey <tromey@adacore.com>
5008
5009 PR gdb/24653:
5010 * regcache.c (registers_changed): Don't call alloca.
5011 * top.c (execute_command): Don't call alloca.
5012
5013 2019-06-13 Pedro Alves <palves@redhat.com>
5014
5015 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5016 'expression'. When parsing an expression, error out if there's
5017 junk after "unlimited".
5018 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5019 (do_set_command): Adjust calls to is_unlimited_literal.
5020
5021 2019-06-13 Pedro Alves <palves@redhat.com>
5022
5023 * compile/compile.c (make_compile_options_def_group): Add braces
5024 around array_view initializer.
5025 * thread.c (make_thread_apply_all_options_def_group)
5026 (make_thread_apply_all_options_def_group): Likewise.
5027
5028 2019-06-13 Pedro Alves <palves@redhat.com>
5029
5030 * NEWS (New commands): Mention "maint test-options
5031 require-delimiter", "maint test-options unknown-is-error", "maint
5032 test-options unknown-is-operand" and "maint show
5033 test-options-completion-result".
5034 (New command options, command completion): New section.
5035 (Completion improvements): New section.
5036 Mention that you can abbreviate "unlimited".
5037
5038 2019-06-13 Pedro Alves <palves@redhat.com>
5039
5040 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5041 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5042 * unittests/cli-utils-selftests.c (test_parse_flags)
5043 (test_parse_flags_qcs): Delete.
5044 (test_cli_utils): Don't call deleted functions.
5045
5046 2019-06-13 Pedro Alves <palves@redhat.com>
5047
5048 * thread.c: Include "cli/cli-option.h".
5049 (tp_array_compar_ascending): Global.
5050 (tp_array_compar): Delete function.
5051 (tp_array_compar_ascending, tp_array_compar_descending): New
5052 functions.
5053 (ascending_option_def, qcs_flag_option_def)
5054 (thr_qcs_flags_option_defs)
5055 (make_thread_apply_all_options_def_group)
5056 (make_thread_apply_options_def_group): New.
5057 (thread_apply_all_command): Use gdb::option::process_options.
5058 (thread_apply_command_completer)
5059 (thread_apply_all_command_completer): New.
5060 (thread_apply_command): Use gdb::option::process_options.
5061 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5062 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
5063 to generate help text of "thread apply". Adjust "taas"'s help.
5064 * tid-parse.c (tid_range_parser::in_thread_range): New method.
5065 * tid-parse.h (tid_range_parser::in_thread_range): New method.
5066
5067 2019-06-13 Pedro Alves <palves@redhat.com>
5068
5069 * thread.c (thread_apply_command): Check for invalid TID with
5070 isdigit instead of !isalpha.
5071
5072 2019-06-13 Pedro Alves <palves@redhat.com>
5073
5074 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5075 (validate_flags_qcs): New.
5076 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5077 (validate_flags_qcs): Declare.
5078 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5079 (make_frame_apply_options_def_group): New.
5080 (frame_apply_command_count): Process options with
5081 gdb::option::process_options.
5082 (frame_apply_completer): New.
5083 (frame_apply_level_completer, frame_apply_all_completer)
5084 (frame_apply_completer): New.
5085 (_initialize_stack): Update help of "frame apply", "frame apply
5086 level", "frame apply all" and "faas" to mention supported options
5087 and install command completers.
5088 * stack.h (frame_apply_all_completer): Declare.
5089 * thread.c: Include "stack.h".
5090 (tfaas_command): Add "--".
5091 (_initialize_thread): Update help "tfaas" to mention supported
5092 options and install command completer.
5093
5094 2019-06-13 Pedro Alves <palves@redhat.com>
5095
5096 * completer.c (complete_nested_command_line): New.
5097 (gdb_completion_word_break_characters_throw): Add assertion.
5098 * completer.h (complete_nested_command_line): Declare.
5099
5100 2019-06-13 Pedro Alves <palves@redhat.com>
5101
5102 * stack.c (parse_backtrace_qualifiers): New.
5103 (backtrace_command): Use it.
5104 (backtrace_command_completer): Complete on qualifiers.
5105
5106 2019-06-13 Pedro Alves <palves@redhat.com>
5107
5108 * frame.c: Include "cli/cli-option.h.
5109 (user_set_backtrace_options): New.
5110 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5111 Delete.
5112 (get_prev_frame): Adjust.
5113 (boolean_option_def, uinteger_option_def)
5114 (set_backtrace_option_defs): New.
5115 (_initialize_frame): Adjust and use
5116 gdb::option::add_setshow_cmds_for_options to install "set
5117 backtrace past-main" and "set backtrace past-entry".
5118 * frame.h: Include "cli/cli-option.h".
5119 (struct frame_print_options): Forward declare.
5120 (print_frame_arguments_all, print_frame_arguments_scalars)
5121 (print_frame_arguments_none): Declare.
5122 (print_entry_values): Delete declaration.
5123 (struct frame_print_options, user_frame_print_options): New.
5124 (struct set_backtrace_options): New.
5125 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5126 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5127 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5128 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5129 (list_args_or_locals): Add frame_print_options parameter.
5130 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5131 * python/py-framefilter.c (enumerate_args): Pass down
5132 USER_FRAME_PRINT_OPTIONS.
5133 * stack.c: Include "cli/cli-option.h".
5134 (print_frame_arguments_all, print_frame_arguments_scalars)
5135 (print_frame_arguments_none): Declare.
5136 (print_raw_frame_arguments, print_entry_values): Delete.
5137 (user_frame_print_options): New.
5138 (boolean_option_def, enum_option_def, frame_print_option_defs):
5139 New.
5140 (struct backtrace_cmd_options): New.
5141 (bt_flag_option_def): New.
5142 (backtrace_command_option_defs): New.
5143 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5144 (print_frame_arg, read_frame_arg, print_frame_args)
5145 (print_frame_info, print_frame): Add frame_print_options parameter
5146 and use it.
5147 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5148 (backtrace_command_1): Add frame_print_options and
5149 backtrace_cmd_options parameters and use them.
5150 (make_backtrace_options_def_group): New.
5151 (backtrace_command): Process command options with
5152 gdb::option::process_options.
5153 (backtrace_command_completer): New.
5154 (_initialize_stack): Extend "backtrace"'s help to mention
5155 supported options. Install completer for "backtrace".
5156 Install some settings commands with add_setshow_cmds_for_options.
5157
5158 2019-06-13 Pedro Alves <palves@redhat.com>
5159
5160 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5161 and that "set/show print raw frame-arguments" are now deprecated.
5162
5163 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5164 command.
5165 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5166 * stack.c (_initialize_stack): Install "set/show print
5167 raw-frame-arguments", and deprecate "set/show print raw
5168 frame-arguments".
5169 * valprint.c (_initialize_valprint): Deprecate "set/show print
5170 raw".
5171
5172 2019-06-13 Pedro Alves <palves@redhat.com>
5173
5174 * compile/compile.c (struct compile_options): New.
5175 (compile_flag_option_def, compile_command_option_defs)
5176 (make_compile_options_def_group): New.
5177 (compile_file_command): Handle options with
5178 gdb::option::process_options.
5179 (compile_file_command_completer): New function.
5180 (compile_code_command): Handle options with
5181 gdb::option::process_options.
5182 (compile_code_command_completer): New function.
5183 (_initialize_compiler): Install completers for "compile code" and
5184 "compile file". Mention available options in "compile code" and
5185 "compile code"'s help.
5186 * completer.c (advance_to_completion_word): New, factored out from
5187 ...
5188 (advance_to_expression_complete_word_point): ... this.
5189 (advance_to_filename_complete_word_point): New.
5190 * completer.h (advance_to_filename_complete_word_point): New
5191 declaration.
5192
5193 2019-06-13 Pedro Alves <palves@redhat.com>
5194
5195 * compile/compile.c: Include "cli/cli-option.h".
5196 (compile_print_value): Scope data pointer is now a
5197 value_print_options pointer; adjust.
5198 (compile_print_command): Process options. Scope data pointer is
5199 now a value_print_options pointer; adjust.
5200 (_initialize_compile): Update "compile print"'s help to include
5201 supported options. Install a completer for "compile print".
5202 * cp-valprint.c (show_vtblprint, show_objectprint)
5203 (show_static_field_print): Delete.
5204 (_initialize_cp_valprint): Don't install "set print
5205 static-members", "set print vtbl", "set print object" here.
5206 * printcmd.c: Include "cli/cli-option.h" and
5207 "common/gdb_optional.h".
5208 (print_command_parse_format): Rework to fill in a
5209 value_print_options instead of a format_data.
5210 (print_value): Change parameter type from format_data pointer to
5211 value_print_options reference. Adjust.
5212 (print_command_1): Process options. Adjust to pass down a
5213 value_print_options.
5214 (print_command_completer): New.
5215 (_initialize_printcmd): Install print_command_completer as
5216 handle_brkchars completer for the "print" command. Update
5217 "print"'s help to include supported options.
5218 * valprint.c: Include "cli/cli-option.h".
5219 (show_vtblprint, show_objectprint, show_static_field_print): Moved
5220 here from cp-valprint.c.
5221 (boolean_option_def, uinteger_option_def)
5222 (value_print_option_defs, make_value_print_options_def_group):
5223 New. Use gdb::option::add_setshow_cmds_for_options to install
5224 "set print elements", "set print null-stop", "set print repeats",
5225 "set print pretty", "set print union", "set print array", "set
5226 print address", "set print symbol", "set print array-indexes".
5227 * valprint.h: Include <string> and "cli/cli-option.h".
5228 (make_value_print_options_def_group): Declare.
5229 (print_value): Change parameter type from format_data pointer to
5230 value_print_options reference.
5231 (print_command_completer): Declare.
5232
5233 2019-06-13 Pedro Alves <palves@redhat.com>
5234
5235 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5236 (COMMON_SFILES): Add maint-test-settings.c.
5237 * cli/cli-decode.c (boolean_enums): New global, factored out from
5238 ...
5239 (add_setshow_boolean_cmd): ... here.
5240 * cli/cli-decode.h (boolean_enums): Declare.
5241 * cli/cli-option.c: New file.
5242 * cli/cli-option.h: New file.
5243 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5244 factored out from ...
5245 (parse_cli_boolean_value(const char *)): ... this.
5246 (is_unlimited_literal): Change parameter type to pointer to
5247 pointer. Adjust and advance ARG pointer.
5248 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5249 (parse_cli_var_enum): New, factored out from ...
5250 (do_set_command): ... this. Adjust.
5251 * cli/cli-setshow.h (parse_cli_boolean_value)
5252 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5253 (parse_cli_var_enum): Declare.
5254 * cli/cli-utils.c: Include "cli/cli-option.h".
5255 (get_ulongest): New.
5256 * cli/cli-utils.h (get_ulongest): Declare.
5257 (check_for_argument): New overloads.
5258 * maint-test-options.c: New file.
5259
5260 2019-06-13 Pedro Alves <palves@redhat.com>
5261
5262 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5263 parse a range if "-" is at the end of the string.
5264
5265 2019-06-13 Pedro Alves <palves@redhat.com>
5266
5267 * cli/cli-setshow.c (parse_auto_binary_operation)
5268 (parse_cli_boolean_value): Don't allow "o".
5269
5270 2019-06-13 Pedro Alves <palves@redhat.com>
5271
5272 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5273 * NEWS: Mention maint test-settings KIND.
5274 * maint-test-settings.c: New file.
5275
5276 2019-06-13 Pedro Alves <palves@redhat.com>
5277
5278 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5279 completer.
5280 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5281 "set" completers.
5282
5283 2019-06-13 Pedro Alves <palves@redhat.com>
5284
5285 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5286 after item.
5287
5288 2019-06-13 Pedro Alves <palves@redhat.com>
5289
5290 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5291
5292 2019-06-13 Pedro Alves <palves@redhat.com>
5293
5294 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5295 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5296 call.
5297 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5298 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5299 calls.
5300 (check_for_argument): Skip spaces after argument.
5301
5302 2019-06-13 Pedro Alves <palves@redhat.com>
5303
5304 * thread.c (thread_apply_command): Adjust TID parsing.
5305 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5306 detected before end of string.
5307 (tid_is_in_list): Error out if LIST is invalid.
5308
5309 2019-06-13 Pedro Alves <palves@redhat.com>
5310
5311 * completer.c (complete_line_internal_1): Rewind completion word
5312 point.
5313 (completion_tracker::advance_custom_word_point_by): Change
5314 parameter type to int.
5315 * completer.h (completion_tracker::advance_custom_word_point_by):
5316 Likewise.
5317
5318 2019-06-13 Pedro Alves <palves@redhat.com>
5319
5320 * completer.c (advance_to_completion_word): Handle delimiters.
5321
5322 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
5323
5324 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5325
5326 2019-06-11 Tom Tromey <tom@tromey.com>
5327
5328 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5329 (xmalloc_failed): Move to alloc.c.
5330 * alloc.c: New file.
5331 * Makefile.in (COMMON_SFILES): Add alloc.c.
5332
5333 2019-06-11 Tom Tromey <tom@tromey.com>
5334
5335 * nat/linux-waitpid.c: Don't include server.h.
5336 (linux_debug): Remove.
5337 (my_waitpid): Update.
5338
5339 2019-06-11 Tom Tromey <tromey@adacore.com>
5340
5341 * infcall.c (_initialize_infcall): Remove trailing newline from
5342 help.
5343 * user-regs.c (_initialize_user_regs): Remove trailing newline
5344 from help.
5345 * typeprint.c (_initialize_typeprint): Remove trailing newline
5346 from help.
5347 * reverse.c (_initialize_reverse): Remove trailing newlines from
5348 help.
5349 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5350 from help.
5351 * language.c (add_set_language_command): Remove trailing newline
5352 from help.
5353 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5354 help.
5355 * disasm.c (_initialize_disasm): Remove trailing newline from
5356 help.
5357 * top.c (init_main): Remove trailing newline from help.
5358 * interps.c (_initialize_interpreter): Remove trailing newline
5359 from help.
5360 * btrace.c (_initialize_btrace): Remove trailing newlines from
5361 help.
5362 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5363 from help.
5364 * python/python.c (_initialize_python): Remove trailing newline
5365 from help.
5366 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5367 help.
5368 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5369 from help. Reformat some text.
5370 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5371 from help.
5372 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5373 newline from help.
5374
5375 2019-06-11 Tom Tromey <tromey@adacore.com>
5376
5377 * darwin-nat.c (darwin_decode_exception_message)
5378 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5379
5380 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
5381
5382 * valops.c (value_slice): Check for not allocated or not
5383 associated values.
5384
5385 2019-06-10 Tom de Vries <tdevries@suse.de>
5386
5387 PR gdb/24618
5388 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5389 sure an empty slot (defined by a 32-bit zero pair) is recognized as
5390 invalid.
5391
5392 2019-06-10 Tom de Vries <tdevries@suse.de>
5393
5394 PR gdb/24611
5395 * linespec.c (linespec_lexer_lex_string): Remove incorrect
5396 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
5397
5398 2019-06-10 Tom de Vries <tdevries@suse.de>
5399
5400 PR symtab/24545
5401 * symtab.c (struct demangled_name_entry): Add language field.
5402 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
5403 static minimal symbol". Set and use language field.
5404
5405 2019-06-10 Tom Tromey <tromey@adacore.com>
5406
5407 * ada-lang.c (_initialize_ada_language): Update help text.
5408
5409 2019-06-10 Tom Tromey <tromey@adacore.com>
5410
5411 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5412 with a newline.
5413 * guile/guile.c (handle_boot_error): Don't end warning with a
5414 newline.
5415 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5416 warning with a newline.
5417 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5418 newline.
5419 (s12z_frame_cache): Likewise.
5420 * dwarf-index-cache.c (index_cache::store): Don't end warning with
5421 a newline.
5422 * solib-svr4.c (disable_probes_interface): Don't end warning with
5423 a newline.
5424 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5425 newline.
5426 * python/python.c (do_finish_initialization): Don't end warning
5427 with a newline.
5428
5429 2019-06-10 Tom Tromey <tom@tromey.com>
5430
5431 * python/py-breakpoint.c (gdbpy_breakpoint_created)
5432 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5433 gdbpy_enter.
5434
5435 2019-06-10 Tom Tromey <tromey@adacore.com>
5436
5437 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5438 data.
5439 (elf_new_init): Don't call stabsread_new_init.
5440 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5441 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
5442 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5443
5444 2019-06-10 Tom de Vries <tdevries@suse.de>
5445
5446 PR symtab/16264
5447 PR symtab/24517
5448 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5449
5450 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
5451
5452 * source.c (find_and_open_source): Also rewrite relative file
5453 names.
5454
5455 2019-04-26 Amos Bird <amosbird@gmail.com>
5456
5457 * annotate.c (annotate_thread_exited): Add "thread-exited"
5458 annotation.
5459
5460 2019-06-06 Tom Tromey <tromey@adacore.com>
5461
5462 * maint.h (class scoped_command_stats): Use
5463 DISABLE_COPY_AND_ASSIGN.
5464 <print_time>: New method.
5465 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5466 print_time.
5467 (scoped_command_stats::print_time): New method.
5468
5469 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
5470
5471 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5472 instructions of lengths 6 or 8 bytes.
5473
5474 2019-06-04 Pedro Alves <palves@redhat.com>
5475
5476 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5477
5478 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5479 * breakpoint.c (condition_completer): Likewise.
5480 * cli/cli-dump.c (scan_expression): Likewise.
5481 * common/filestuff.c (mkdir_recursive): Likewise.
5482 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5483 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5484 (gdb_abspath): Likewise.
5485 * compile/compile-cplus-types.c
5486 (compile_cplus_instance::decl_name): Likewise.
5487 * completer.c (complete_explicit_location):
5488 (signal_completer, reg_or_group_completer_1): Likewise.
5489 * cp-support.c (cp_remove_params_if_any): Likewise.
5490 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5491 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5492 * infcmd.c (strip_bg_char): Likewise.
5493 * linespec.c (copy_token_string): Likewise.
5494 * mi/mi-main.c (output_cores): Likewise.
5495 * psymtab.c (psymtab_search_name):
5496 * symfile.c (test_set_ext_lang_command): Likewise.
5497 * target.c (target_fileio_read_stralloc): Likewise.
5498 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5499 * value.c (complete_internalvar): Likewise.
5500
5501 2019-06-04 Christian Biesinger <cbiesinger@google.com>
5502
5503 Add objfile property to gdb.Type.
5504 * NEWS: Mention Python API addition.
5505 * python/py-type.c (typy_get_objfile): New method.
5506
5507 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5508
5509 * NEWS: Mention the new set|show style [title|highlight].
5510 Mention changes to "show style", "help" and "apropos".
5511
5512 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5513
5514 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5515 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
5516 instead of print_help_for_command.
5517 (print_doc_of_command): New function.
5518 (help_list): Add 'apropos -v word' suggestion.
5519 (print_help_for_command): Style the command name using title style.
5520 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5521 (_initialize_cli_cmds): Describe -v in apropos_command help.
5522
5523 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5524
5525 * cli/cli-style.h (cli_style_option): Add name in constructor,
5526 add m_name class member, add constructor with intensity,
5527 add name class function.
5528 (cli_style_option::add_setshow_commands): Remove name argument.
5529 (highlight_style, title_style): New styles.
5530 * cli/cli-style.c (do_show): New function that shows a style
5531 characteristic styling the style name with itself.
5532 (set_style_name): New function.
5533 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5534 Update all callers according to the changes in cli/cli-style.h.
5535 * utils.h (fputs_highlighted): New function.
5536 * utils.c (fputs_highlighted): Likewise.
5537
5538 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5539
5540 * NEWS: Mention new pipe command and new convenience variables.
5541
5542 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5543
5544 * cli/cli-cmds.c (pipe_command): New function.
5545 (_initialize_cli_cmds): Call add_com for pipe_command.
5546 Define | as an alias for pipe.
5547 (exit_status_set_internal_vars): New function.
5548 (shell_escape): Call exit_status_set_internal_vars.
5549 cli/cli-decode.c (find_command_name_length): Recognize | as
5550 a single character command.
5551
5552 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5553
5554 * gdbcmd.h (execute_command_to_ui_file): New declaration.
5555 top.c (execute_command_to_ui_file): New function, mostly a copy
5556 of execute_command_to_string.
5557 (execute_command_to_string): Implement by calling
5558 execute_command_to_ui_file.
5559
5560 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5561
5562 * top.h (saved_command_line): Remove declaration.
5563 * top.c (previous_saved_command_line, previous_repeat_arguments):
5564 New variables.
5565 (saved_command_line): Make static, define together with other
5566 'repeat variables'.
5567 (dont_repeat): Clear repeat_arguments.
5568 (repeat_previous, get_saved_command_line, save_command_line):
5569 New functions.
5570 (gdb_init): Initialize saved_command_line
5571 and previous_saved_command_line.
5572 * main.c (captured_main_1): Remove saved_command_line initialization.
5573 * event-top.c (handle_line_of_input): Update to use
5574 the new 'repeat' related functions instead of direct access to
5575 saved_command_line.
5576 * command.h (repeat_previous, get_saved_command_line,
5577 save_command_line): New declarations.
5578 (dont_repeat): Add comment.
5579
5580 2019-05-30 Tom Tromey <tromey@adacore.com>
5581
5582 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5583 Fix comment.
5584 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5585
5586 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
5587
5588 PR cli/24587
5589 * completer.c (complete): Initialize variable word.
5590
5591 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
5592
5593 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5594 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5595 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5596 'body' is NULL to the outter 'if', protecting the '!is_define'
5597 situation as well.
5598
5599 2019-05-29 Tom Tromey <tromey@adacore.com>
5600
5601 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5602 (dwarf_unknown): New function.
5603 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5604 (dwarf_type_encoding_name): Use dwarf_unknown.
5605
5606 2019-05-29 Tom Tromey <tromey@adacore.com>
5607
5608 PR c++/20020:
5609 * cp-valprint.c (cp_print_value_fields): Call
5610 cp_print_static_field inside "try".
5611
5612 2019-05-29 Tom Tromey <tromey@adacore.com>
5613
5614 * inflow.c (struct terminal_info): Add default operator=.
5615 * configure: Rebuild.
5616 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5617 -Wdeprecated-copy-dtor, -Wredundant-move.
5618
5619 2019-05-29 Tom Tromey <tromey@adacore.com>
5620
5621 * NEWS: Add entry.
5622 * infcmd.c (print_return_value_1): Handle finish_print
5623 option.
5624 (show_print_finish): New function.
5625 (_initialize_infcmd): Add "set/show print finish" commands.
5626 * valprint.c (user_print_options): Initialize new member.
5627 * valprint.h (struct value_print_options) <finish_print>: New
5628 member.
5629
5630 2019-05-28 Tom Tromey <tromey@adacore.com>
5631
5632 * ada-lang.c (ada_remove_Xbn_suffix)
5633 (find_old_style_renaming_symbol)
5634 (parse_old_style_renaming): Remove.
5635 (ada_find_renaming_symbol): Don't call
5636 find_old_style_renaming_symbol.
5637 (ada_is_renaming_symbol): Rename from
5638 ada_find_renaming_symbol. Remove "block" parameter. Return
5639 bool. Now static.
5640 (ada_read_var_value): Update and simplify.
5641 * ada-exp.y (write_var_or_type): Remove old code.
5642
5643 2019-05-28 Alan Hayward <alan.hayward@arm.com>
5644
5645 * event-top.c: Remove include comment.
5646 * inflow.c (class scoped_ignore_sigttou): Move from here...
5647 * inflow.h (class scoped_ignore_sigttou): ...to here.
5648 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5649 * top.c: Remove include comment.
5650
5651 2019-05-27 Tom Tromey <tom@tromey.com>
5652
5653 * NEWS: Fix typo.
5654
5655 2019-05-22 Tom Tromey <tromey@adacore.com>
5656
5657 * target.c (target_follow_exec): Constify parameter.
5658 * target-delegates.c: Rebuild.
5659 * remote.c (remote_target::follow_exec): Constify parameter.
5660 * infrun.c (follow_exec): Constify parameter.
5661 * target.h (struct target_ops) <follow_exec>: Constify parameter.
5662 (target_follow_exec): Likewise.
5663
5664 2019-05-22 Alan Hayward <alan.hayward@arm.com>
5665
5666 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5667 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5668
5669 2019-05-22 Alan Hayward <alan.hayward@arm.com>
5670
5671 * NEWS: Add debugredirect and testsuite sections.
5672
5673 2019-05-22 Simon Cook <simon.cook@embecosm.com>
5674
5675 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5676 target descriptions using exclusively floating point register name
5677 aliases.
5678
5679 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
5680
5681 PR gdb/18644:
5682 * f-lang.c (build_fortran_types): Handle the case where
5683 gdbarch_floatformat_for_type returns a nullptr.
5684
5685 2019-05-21 Tom de Vries <tdevries@suse.de>
5686
5687 PR cli/24587
5688 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5689
5690 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5691
5692 PR gdb/18644:
5693 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5694 16-byte floats.
5695 * i386-tdep.c (i386_floatformat_for_type): Use
5696 floatformats_ia64_quad for the 16-byte floating point component
5697 within a fortran 32-byte complex number.
5698
5699 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5700
5701 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5702 delete default constructor.
5703 (find_partial_die): Update to return const struct.
5704 (partial_die_parent_scope): Move variable declaration into scope
5705 of its use and change its type to auto.
5706 (guess_partial_die_structure_name): Likewise.
5707 (partial_die_info::fixup): Likewise.
5708
5709 2019-05-17 Tom Tromey <tromey@adacore.com>
5710
5711 * source.c (find_and_open_source): Remove cast.
5712
5713 2019-05-17 Tom Tromey <tromey@adacore.com>
5714
5715 * annotate.c (annotate_source): Make "filename" const.
5716 * annotate.h (annotate_source): Use const.
5717
5718 2019-05-17 Alan Hayward <alan.hayward@arm.com>
5719
5720 * disasm.c (set_disassembler_options): Send errors to stderr.
5721
5722 2019-05-17 Alan Hayward <alan.hayward@arm.com>
5723
5724 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5725 (cli_interp_base::set_logging): Check debug_redirect.
5726 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5727 * cli/cli-logging.c (debug_redirect): Add static variable.
5728 (pop_output_files): Add default param.
5729 (handle_redirections): Print debug setting.
5730 (show_logging_command): Likewise.
5731 (_initialize_cli_logging): Add debugredirect command.
5732 * interps.c (current_interp_set_logging): Add debug_redirect
5733 parameter.
5734 * interps.h (set_logging): Add debug_redirect parameter.
5735 (current_interp_set_logging): Likewise.
5736 * mi/mi-common.h: Likewise.
5737 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5738
5739 2019-05-17 Alan Hayward <alan.hayward@arm.com>
5740 Tom Tromey <tromey@adacore.com>
5741
5742 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5743 directly.
5744 * cli/cli-interp.h (make_logging_output): Remove declaration.
5745 * cli/cli-logging.c (make_logging_output): Remove function.
5746 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5747 directly.
5748 * ui-file.c (tee_file::tee_file): Remove bools.
5749 (tee_file::~tee_file): Remove deletes.
5750 * ui-file.h (tee_file): Remove bools.
5751
5752 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
5753
5754 * mi/mi-cmds.h (mi_cmd_complete): New function.
5755 * mi/mi-main.c (mi_cmd_complete): Likewise.
5756 * mi/mi-cmds.c: Define new MI command -complete.
5757 * NEWS: Mention new -complete command.
5758
5759 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
5760
5761 * completer.h (complete): New function.
5762 * completer.c (complete): Likewise.
5763 * cli/cli-cmds.c: (complete_command): Update to use new complete()
5764 function defined in completer.h.
5765
5766 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
5767
5768 * MAINTAINERS (Write After Approval): Add myself.
5769
5770 2019-05-17 Tom de Vries <tdevries@suse.de>
5771
5772 PR gdb/24094
5773 * dwarf2read.c (struct cu_partial_die_info): New struct.
5774 (find_partial_die): Return cu_partial_die_info.
5775 (partial_die_parent_scope, guess_partial_die_structure_name)
5776 (partial_die_info::fixup): Handle new return type of find_partial_die.
5777
5778 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5779
5780 * stap-probe.c (stap_parse_register_operand): Make "regname" an
5781 "std::string", simplifying the algorithm.
5782
5783 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5784
5785 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5786 (stap_static_probe_ops::get_probes): Likewise.
5787
5788 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5789
5790 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5791 '-')" and "else if".
5792 (stap_parse_single_operand): Join checks for
5793 "gdbarch_stap_parse_special_token_p" and
5794 "gdbarch_stap_parse_special_token" in the same "if" statement.
5795 Invert check when verifying for operation on register
5796 displacement.
5797
5798 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5799
5800 * stap-probe.c (stap_get_opcode): Update comment.
5801 (stap_get_expected_argument_type): Likewise.
5802 (handle_stap_probe): Likewise.
5803
5804 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5805
5806 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5807 return type to 'bool'. Adjust comment. Use 'bool' when
5808 appropriate.
5809 (i386_stap_parse_special_token_three_arg_disp): Likewise.
5810 * stap-probe.c (stap_parse_argument_1): Likewise.
5811 (stap_is_operator): Likewise.
5812 (stap_is_generic_prefix): Likewise.
5813 (stap_is_register_prefix): Likewise.
5814 (stap_is_register_indirection_prefix): Likewise.
5815 (stap_is_integer_prefix): Likewise.
5816 (stap_generic_check_suffix): Likewise.
5817 (stap_check_integer_suffix): Likewise.
5818 (stap_check_register_suffix): Likewise.
5819 (stap_check_register_indirection_suffix): Likewise.
5820 (stap_parse_register_operand): Likewise.
5821 (stap_parse_single_operand): Likewise.
5822 (stap_parse_argument_1): Likewise.
5823 (stap_probe::get_argument_count): Likewise.
5824 (stap_is_operator): Likewise.
5825
5826 2019-05-16 Tom Tromey <tromey@adacore.com>
5827
5828 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5829 keyword to foreach.
5830
5831 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
5832
5833 * linux-thread-db.c (try_thread_db_load_1): Change return type
5834 to bool.
5835 (try_thread_db_load): Likewise.
5836 (try_thread_db_load_from_pdir_1): Likewise.
5837 (try_thread_db_load_from_pdir): Likewise.
5838 (try_thread_db_load_from_sdir): Likewise.
5839 (try_thread_db_load_from_dir): Likewise.
5840 (thread_db_load_search): Likewise.
5841 (has_libpthread): Likewise.
5842 (thread_db_load): Likewise.
5843
5844 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
5845
5846 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5847 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5848 NULL, and complain/return if that's the case.
5849
5850 2019-05-15 John Darrington <john@darrington.wattle.id.au>
5851
5852 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5853 (advance, posn, abstract_read_memory): New functions.
5854 [struct mem_read_abstraction]: New struct.
5855 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5856
5857 2019-05-14 Tom Tromey <tromey@adacore.com>
5858
5859 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5860 value is not lval_memory.
5861
5862 2019-05-14 Tom Tromey <tromey@adacore.com>
5863
5864 * solib.c (info_sharedlibrary_command): Style the file name.
5865
5866 2019-05-14 Alan Hayward <alan.hayward@arm.com>
5867
5868 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5869 (aarch64_vnv_type): Likewise.
5870 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5871 * common/tdesc.c: Likewise.
5872 * common/tdesc.h (enum tdesc_type_kind): Likewise.
5873 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5874 * features/aarch64-fpu.xml: Add ieee half view.
5875 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5876 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5877 * gdbtypes.h (struct builtin_type): Likewise.
5878 (struct objfile_type): Likewise.
5879
5880 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
5881
5882 * language.c (language_sniff_from_mangled_name): Fix "langauge"
5883 typo.
5884 * location.h (string_to_event_location): Likewise.
5885
5886 2019-05-11 Joel Brobecker <brobecker@adacore.com>
5887
5888 GDB 8.3 released.
5889
5890 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
5891
5892 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5893 New variable declaration.
5894 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5895 New variable.
5896 (print_one_breakpoint): Use ui_out::test_flags and new global
5897 variable to compute use_fixed_output.
5898 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5899 Remove.
5900 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5901 (mi_multi_location_breakpoint_output_fixed): Remove.
5902 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5903 new variable.
5904 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5905 fix_multi_location_breakpoint_output flag if version >= 3.
5906 * ui-out.h (enum ui_out_flag)
5907 <fix_multi_location_breakpoint_output>: New enumerator.
5908
5909 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
5910
5911 * contrib/cc-with-tweaks.sh: Validate dwz's work.
5912
5913 2019-05-10 Tom Tromey <tromey@adacore.com>
5914
5915 * ada-lang.c (catch_ada_completer): New function.
5916 (_initialize_ada_language): Use it.
5917
5918 2019-05-10 Tom Tromey <tromey@adacore.com>
5919
5920 * thread.c (print_thread_info): Make "requested_threads" const.
5921 * gdbthread.h (print_thread_info): Make "requested_threads"
5922 const.
5923 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5924 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5925
5926 2019-05-08 Tom Tromey <tom@tromey.com>
5927
5928 * gdbtypes.c (objfile_type_data): Change type.
5929 (objfile_type, _initialize_gdbtypes): Update.
5930
5931 2019-05-08 Tom Tromey <tom@tromey.com>
5932
5933 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5934 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5935 (_initialize_dwarf2_frame): Update.
5936
5937 2019-05-08 Tom Tromey <tom@tromey.com>
5938
5939 * objc-lang.c (objc_objfile_data): Change type.
5940 (find_methods): Update.
5941 (_initialize_objc_lang): Remove.
5942
5943 2019-05-08 Tom Tromey <tom@tromey.com>
5944
5945 * stabsread.c (rs6000_builtin_type_data): Change type.
5946 (rs6000_builtin_type, _initialize_stabsread): Update.
5947
5948 2019-05-08 Tom Tromey <tom@tromey.com>
5949
5950 * mips-tdep.c (mips_pdr_data): Remove.
5951 (_initialize_mips_tdep): Update.
5952
5953 2019-05-08 Tom Tromey <tom@tromey.com>
5954
5955 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5956 (hppa_init_objfile_priv_data, read_unwind_info)
5957 (find_unwind_entry, _initialize_hppa_tdep): Update.
5958
5959 2019-05-08 Tom Tromey <tom@tromey.com>
5960
5961 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5962 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
5963 on obstack.
5964 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5965
5966 2019-05-08 Tom Tromey <tom@tromey.com>
5967
5968 * mdebugread.c (basic_type_data): Change type.
5969 (basic_type, _initialize_mdebugread): Update.
5970
5971 2019-05-08 Tom Tromey <tom@tromey.com>
5972
5973 * common/gdb_unique_ptr.h (struct noop_deleter): New.
5974
5975 2019-05-08 Tom Tromey <tom@tromey.com>
5976
5977 * nto-tdep.c (nto_inferior_data_reg): Change type.
5978 (nto_inferior_data): Update.
5979 (nto_inferior_data_cleanup, nto_new_inferior_data)
5980 (_initialize_nto_tdep): Remove.
5981 * nto-tdep.h (struct nto_inferior_data): Add initializers.
5982
5983 2019-05-08 Tom Tromey <tom@tromey.com>
5984
5985 * ada-lang.c (struct ada_inferior_data): Add initializers.
5986 (ada_inferior_data): Change type.
5987 (ada_inferior_data_cleanup): Remove.
5988 (get_ada_inferior_data, ada_inferior_exit)
5989 (struct ada_pspace_data): Add initializers, destructor.
5990 (ada_pspace_data_handle): Change type.
5991 (get_ada_pspace_data): Update.
5992 (ada_pspace_data_cleanup): Remove.
5993
5994 2019-05-08 Tom Tromey <tom@tromey.com>
5995
5996 * coffread.c (struct coff_symfile_info): Add initializers.
5997 (coff_objfile_data_key): Move lower. Change type.
5998 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5999 Update.
6000 (coff_free_info): Remove.
6001
6002 2019-05-08 Tom Tromey <tom@tromey.com>
6003
6004 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6005 (fbsd_pspace_data_handle): Move lower. Change type.
6006 (get_fbsd_pspace_data): Update.
6007 (fbsd_pspace_data_cleanup): Remove.
6008 (_initialize_fbsd_tdep): Update.
6009
6010 2019-05-08 Tom Tromey <tom@tromey.com>
6011
6012 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6013 (get_ada_tasks_pspace_data): Update.
6014 (ada_tasks_pspace_data_cleanup): Remove.
6015 (_initialize_tasks): Update.
6016 (ada_tasks_inferior_data_handle): Change type.
6017 (get_ada_tasks_inferior_data): Update.
6018 (ada_tasks_inferior_data_cleanup): Remove.
6019 (struct ada_tasks_pspace_data): Add initializers.
6020
6021 2019-05-08 Tom Tromey <tom@tromey.com>
6022
6023 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6024 * symfile-debug.c (debug_sym_get_probes): Change type.
6025 * stap-probe.c (handle_stap_probe):
6026 (stap_static_probe_ops::get_probes): Change type.
6027 * probe.h (class static_probe_ops) <get_probes>: Change type.
6028 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6029 (parse_probes_in_pspace): Update.
6030 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6031 Update.
6032 (any_static_probe_ops::get_probes): Change type.
6033 * elfread.c (elfread_data): New typedef.
6034 (probe_key): Change type.
6035 (elf_get_probes): Likewise. Update.
6036 (probe_key_free): Remove.
6037 (_initialize_elfread): Update.
6038 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6039 Change type.
6040 (dtrace_process_dof_probe, dtrace_process_dof)
6041 (dtrace_static_probe_ops::get_probe): Change type.
6042
6043 2019-05-08 Tom Tromey <tom@tromey.com>
6044
6045 * xcoffread.c (struct xcoff_symfile_info): Rename from
6046 coff_symfile_info. Add initializers.
6047 (xcoff_objfile_data_key): Move lower. Change type.
6048 (XCOFF_DATA): Rewrite.
6049 (xcoff_free_info): Remove.
6050 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6051 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6052 (xcoff_initial_scan): Update.
6053
6054 2019-05-08 Tom Tromey <tom@tromey.com>
6055
6056 * solib-svr4.c (struct svr4_info): Add initializers and
6057 destructor.
6058 <probes_table>: Now an htab_up.
6059 (solib_svr4_pspace_data): Change type.
6060 (free_probes_table): Simplify.
6061 (~svr4_info): Rename from svr4_pspace_data_cleanup.
6062 (get_svr4_info, probes_table_htab_remove_objfile_probes)
6063 (probes_table_remove_objfile_probes, register_solib_event_probe)
6064 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6065 (_initialize_svr4_solib): Update.
6066
6067 2019-05-08 Tom Tromey <tom@tromey.com>
6068
6069 * remote.c (remote_pspace_data): Change type.
6070 (remote_pspace_data_cleanup): Remove.
6071 (get_remote_exec_file, set_pspace_remote_exec_file)
6072 (_initialize_remote): Update.
6073
6074 2019-05-08 Tom Tromey <tom@tromey.com>
6075
6076 * breakpoint.c (breakpoint_objfile_key): Change type.
6077 (get_breakpoint_objfile_data): Update.
6078 (free_breakpoint_objfile_data): Remove.
6079 (_initialize_breakpoint): Update.
6080
6081 2019-05-08 Tom Tromey <tom@tromey.com>
6082
6083 * linux-tdep.c (struct linux_info): Add initializers.
6084 (linux_inferior_data): Move. Change type.
6085 (invalidate_linux_cache_inf): Update.
6086 (linux_inferior_data_cleanup): Remove.
6087 (get_linux_inferior_data, _initialize_linux_tdep): Update.
6088
6089 2019-05-08 Tom Tromey <tom@tromey.com>
6090
6091 * auxv.c (auxv_inferior_data): Move. Change type.
6092 (auxv_inferior_data_cleanup): Remove.
6093 (invalidate_auxv_cache_inf): Rewrite.
6094 (get_auxv_inferior_data, _initialize_auxv): Update.
6095
6096 2019-05-08 Tom Tromey <tom@tromey.com>
6097
6098 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6099 (symfile_debug_objfile_data_key): Change type.
6100 (symfile_debug_installed, debug_qf_has_symbols)
6101 (debug_qf_find_last_source_symtab)
6102 (debug_qf_forget_cached_source_info)
6103 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6104 (debug_qf_print_stats, debug_qf_dump)
6105 (debug_qf_expand_symtabs_for_function)
6106 (debug_qf_expand_all_symtabs)
6107 (debug_qf_expand_symtabs_with_fullname)
6108 (debug_qf_map_matching_symbols)
6109 (debug_qf_expand_symtabs_matching)
6110 (debug_qf_find_pc_sect_compunit_symtab)
6111 (debug_qf_map_symbol_filenames)
6112 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6113 (debug_sym_new_init, debug_sym_init, debug_sym_read)
6114 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6115 (debug_sym_read_linetable, debug_sym_relocate): Update.
6116 (symfile_debug_free_objfile): Remove.
6117 (install_symfile_debug_logging, _initialize_symfile_debug):
6118 Update.
6119
6120 2019-05-08 Tom Tromey <tom@tromey.com>
6121
6122 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6123 allocate_on_obstack.
6124 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6125 (get_dwarf2_per_objfile): Update.
6126 (set_dwarf2_per_objfile): Remove.
6127 (dwarf2_has_info, dwarf2_get_section_info): Update.
6128 (dwarf2_free_objfile): Remove.
6129 (_initialize_dwarf2_read): Update.
6130
6131 2019-05-08 Tom Tromey <tom@tromey.com>
6132
6133 * auto-load.c (struct auto_load_pspace_info): Add destructor and
6134 initializers.
6135 <unsupported_script_warning_printed,
6136 script_not_found_warning_printed>: Now bool.
6137 (auto_load_pspace_data): Change type.
6138 (~auto_load_pspace_info): Rename from
6139 auto_load_pspace_data_cleanup.
6140 (get_auto_load_pspace_data, init_loaded_scripts_info)
6141 (clear_section_scripts, maybe_print_unsupported_script_warning)
6142 (maybe_print_script_not_found_warning, _initialize_auto_load):
6143 Update.
6144
6145 2019-05-08 Tom Tromey <tom@tromey.com>
6146
6147 * objfiles.c (objfile_pspace_info): Add destructor and
6148 initializers.
6149 (objfiles_pspace_data): Change type.
6150 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6151 (get_objfile_pspace_data): Update.
6152 (objfiles_bfd_data): Change type.
6153 (get_objfile_bfd_data): Update.
6154 (objfile_bfd_data_free, _initialize_objfiles): Remove.
6155
6156 2019-05-08 Tom Tromey <tom@tromey.com>
6157
6158 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6159 Change type.
6160 (get_catch_syscall_inferior_data): Update.
6161 (catch_syscall_inferior_data_cleanup): Remove.
6162 (_initialize_break_catch_syscall): Update.
6163
6164 2019-05-08 Tom Tromey <tom@tromey.com>
6165
6166 * inflow.c (struct terminal_info): Add destructor and
6167 initializers.
6168 (inflow_inferior_data): Change type.
6169 (~terminal_info): Rename from inflow_inferior_data_cleanup.
6170 (get_inflow_inferior_data, inflow_inferior_exit)
6171 (swap_terminal_info, _initialize_inflow): Update.
6172
6173 2019-05-08 Tom Tromey <tom@tromey.com>
6174
6175 * target-dcache.c (target_dcache_cleanup): Remove.
6176 (target_dcache_aspace_key): Change type.
6177 (target_dcache_init_p, target_dcache_invalidate)
6178 (target_dcache_get, target_dcache_get_or_init)
6179 (_initialize_target_dcache): Update.
6180 * dcache.h (struct dcache_deleter): New.
6181
6182 2019-05-08 Tom Tromey <tom@tromey.com>
6183
6184 * symtab.c (struct symbol_cache): Add destructor and
6185 initializers.
6186 (symbol_cache_key): Move. Change type.
6187 (make_symbol_cache, free_symbol_cache): Remove.
6188 (get_symbol_cache): Update.
6189 (symbol_cache_cleanup): Remove.
6190 (ALL_PSPACES, symbol_cache_flush)
6191 (maintenance_print_symbol_cache)
6192 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6193 Update.
6194
6195 2019-05-08 Tom Tromey <tom@tromey.com>
6196
6197 * symtab.c (struct main_info): Add destructor and initializers.
6198 (main_progspace_key): Move. Change type.
6199 (get_main_info): Update.
6200 (main_info_cleanup): Remove.
6201 (_initialize_symtab): Update.
6202
6203 2019-05-08 Tom Tromey <tom@tromey.com>
6204
6205 * registry.h (DECLARE_REGISTRY): Define the _key class.
6206
6207 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
6208
6209 * NEWS: Merge two 'New commands' sections.
6210
6211 2019-05-08 Joel Brobecker <brobecker@adacore.com>
6212
6213 * ada-valprint.c (ada_val_print_gnat_array): Remove language
6214 parameter and use Ada language definition instead.
6215 (ada_val_print_ptr): Remove unused language parameter.
6216 (ada_val_print_num): Remove language parameter and use Ada language
6217 definition instead.
6218 (ada_val_print_enum, ada_val_print_flt): Remove unused language
6219 parameter.
6220 (ada_val_print_struct_union, ada_val_print_ref): Remove language
6221 parameter and use Ada language definition instead.
6222 (ada_val_print_1): Update all ada_val_print_xxx calls.
6223 Remove language parameter.
6224 (ada_val_print): Update ada_val_print_1 call.
6225
6226 2019-05-08 Tom Tromey <tromey@adacore.com>
6227
6228 * remote.c (remote_hw_watchpoint_limit)
6229 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6230 Now static.
6231
6232 2019-05-08 Tom Tromey <tromey@adacore.com>
6233
6234 * maint.c (_initialize_maint_cmds): Move initialization code to
6235 remote.c.
6236 (watchdog, show_watchdog): Move to remote.c.
6237 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
6238 "watchdog" static.
6239 (_initialize_remote): Move initialization code from maint.c.
6240 * defs.h (watchdog): Don't declare.
6241
6242 2019-05-08 Tom Tromey <tromey@adacore.com>
6243
6244 * tui/tui-interp.c: Include main.h.
6245 * interps.c: Include main.h.
6246 * main.h (interpreter_p): Declare.
6247 * defs.h (interpreter_p): Don't declare.
6248
6249 2019-05-08 Tom Tromey <tromey@adacore.com>
6250
6251 * dwarf2loc.c: Include dwarf2read.h.
6252 * defs.h (read_unsigned_leb128): Don't declare.
6253 * dwarf2read.h (read_unsigned_leb128): Declare.
6254
6255 2019-05-08 Tom Tromey <tromey@adacore.com>
6256
6257 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6258 method.
6259
6260 2019-05-08 Tom Tromey <tromey@adacore.com>
6261
6262 * utils.c (fputs_maybe_filtered): Reset style after paging, even
6263 when no wrap column is set.
6264
6265 2019-05-08 Tom Tromey <tromey@adacore.com>
6266
6267 * c-lang.c (c_get_string): Handle non-C-style arrays.
6268
6269 2019-05-08 Tom Tromey <tromey@adacore.com>
6270
6271 * typeprint.c (print_offset_data::update): Print the bit offset,
6272 not the number of bits remaining.
6273
6274 2019-05-08 Tom Tromey <tromey@adacore.com>
6275
6276 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6277 padding at end of comment.
6278
6279 2019-05-08 Tom Tromey <tromey@adacore.com>
6280
6281 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6282 Compare main types.
6283
6284 2019-05-06 Tom Tromey <tom@tromey.com>
6285
6286 * common/scoped_mmap.c: Include common-defs.h.
6287 * common/scoped_mmap.h: Don't include config.h.
6288
6289 2019-05-04 Tom Tromey <tom@tromey.com>
6290
6291 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6292 (struct aarch64_call_info): Add initializers.
6293 <si>: Now a std::vector.
6294 (pass_on_stack, aarch64_push_dummy_call): Update.
6295
6296 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
6297 Tom Tromey <tom@tromey.com>
6298
6299 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6300 (ppc_threads): Now a std::vector. Now static.
6301 (hwdebug_find_thread_points_by_tid)
6302 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6303 Update.
6304
6305 2019-05-04 Tom Tromey <tom@tromey.com>
6306
6307 * arc-tdep.c (arc_tdesc_init): Return bool.
6308
6309 2019-05-04 Tom Tromey <tom@tromey.com>
6310
6311 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6312 Use gdb_assert_not_reached.
6313
6314 2019-05-04 Tom Tromey <tom@tromey.com>
6315
6316 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6317 "false".
6318
6319 2019-05-04 Tom Tromey <tom@tromey.com>
6320
6321 * arc-tdep.c (arc_tdesc_init): Use bool.
6322
6323 2019-05-04 Tom Tromey <tom@tromey.com>
6324
6325 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6326
6327 2019-05-04 Tom Tromey <tom@tromey.com>
6328
6329 * cli/cli-cmds.c (valid_command_p): Return bool.
6330
6331 2019-05-04 Tom Tromey <tom@tromey.com>
6332
6333 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6334 * command.h (valid_user_defined_cmd_name_p): Channge return type.
6335
6336 2019-05-04 Raul Tambre <raul@tambre.ee>
6337
6338 * python/lib/gdb/prompt.py (_ExtendedPrompt)
6339 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6340 operator for comparison.
6341
6342 2019-05-04 Tom Tromey <tom@tromey.com>
6343
6344 * psymtab.c (psymbol_name_matches, match_partial_symbol)
6345 (lookup_partial_symbol, print_partial_symbols)
6346 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6347 (psymbol_compare): Update.
6348 (add_psymbol_to_bcache): Clear the entire psymbol.
6349 (maintenance_check_psymtabs): Update.
6350 * psympriv.h (struct partial_symbol): Don't derive from
6351 general_symbol_info.
6352 <obj_section, unrelocated_address, address,
6353 set_unrelocated_address>: Update.
6354 <ginfo>: New member.
6355 * dwarf-index-write.c (write_psymbols, debug_names::insert)
6356 (debug_names::write_psymbols): Update.
6357
6358 2019-05-04 Tom de Vries <tdevries@suse.de>
6359
6360 * contrib/cc-with-tweaks.sh: Support -n arg.
6361
6362 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6363
6364 * corelow.c (core_target::detach): Ensure frame cache and
6365 register caches are cleared.
6366 inferior.c (exit_inferior_1): Likewise.
6367
6368 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
6369 Tom Tromey <tom@tromey.com>
6370
6371 * dictionary.c (collate_pending_symbols_by_language): Remove
6372 "struct" from foreach.
6373 * symtab.c (lookup_global_symbol_from_objfile)
6374 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6375 foreach.
6376 * ser-tcp.c (net_open): Remove "struct" from foreach.
6377 * objfiles.c (objfile_relocate, objfile_rebase)
6378 (objfile_has_symbols): Remove "struct" from foreach.
6379 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6380 from foreach.
6381 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6382 foreach.
6383 * darwin-nat.c (thread_info_from_private_thread_info): Remove
6384 "struct" from foreach.
6385 * ada-lang.c (create_excep_cond_exprs)
6386 (ada_exception_catchpoint_cond_string): Remove "struct" from
6387 foreach.
6388
6389 2019-05-03 Tom Tromey <tromey@adacore.com>
6390
6391 * ada-exp.y (convert_char_literal): Check suffix of each
6392 enumerator.
6393
6394 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
6395
6396 PR ada/21406:
6397 * ada-exp.y (yywrap): Don't define.
6398 * ada-lex.l (%option): Add noyywrap
6399 (yywrap): Remove.
6400
6401 2019-05-03 Eli Zaretskii <eliz@gnu.org>
6402
6403 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6404 _WIN32_WINNT to the XP level, unless already defined to a higher
6405 level.
6406
6407 * unittests/parse-connection-spec-selftests.c:
6408 * ser-tcp.c:
6409 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
6410 override.
6411
6412 * symfile.c (find_separate_debug_file): Remove colon from the
6413 drive spec of DOS/Windows file names of the target, so that the
6414 file name produced from DEBUGDIR and the target's directory will
6415 be valid on DOS/Windows systems.
6416
6417 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
6418
6419 * rust-lang.c (val_print_struct): Handle printing structures
6420 containing strings.
6421
6422 2019-05-02 Tom Tromey <tromey@adacore.com>
6423
6424 * valarith.c (_initialize_valarith): Remove.
6425
6426 2019-05-01 Tom Tromey <tromey@adacore.com>
6427
6428 * ada-lang.c (ada_value_primitive_field): Treat more fields as
6429 bitfields.
6430
6431 2019-05-01 Tom Tromey <tromey@adacore.com>
6432
6433 * ada-lang.c (ada_value_assign): Correctly compute starting offset
6434 for big-endian copies.
6435
6436 2019-04-30 Ali Tamur <tamur@google.com>
6437 * gdb/dwarf2read.c (read_3_bytes): New declaration.
6438 (read_attribute_value): Added DW_FORM_strx1-4 cases.
6439 (read_3_bytes): New function.
6440
6441 2019-04-30 Joel Brobecker <brobecker@adacore.com>
6442
6443 * windows-nat.c (main_thread_id): Delete.
6444 (handle_output_debug_string): Replace main_thread_id by
6445 current_event.dwThreadId.
6446 (fake_create_process): Likewise.
6447 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6448 Do not set main_thread_id.
6449 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6450 current_event.dwThreadId.
6451 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6452
6453 2019-04-30 Joel Brobecker <brobecker@adacore.com>
6454
6455 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6456 Use current_event.dwThreadId instead of main_thread_id.
6457
6458 2019-04-30 Tom Tromey <tromey@adacore.com>
6459
6460 * ada-lang.c (ada_lookup_simple_minsyms): New function.
6461 (create_excep_cond_exprs): Iterate over program spaces.
6462 (ada_exception_catchpoint_cond_string): Examine all minimal
6463 symbols for exception types.
6464
6465 2019-04-30 Tom Tromey <tromey@adacore.com>
6466
6467 PR c++/24470:
6468 * dwarf2read.c (process_structure_scope): Handle case where type
6469 has template parameters but no symbol was created.
6470
6471 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6472 Chris January <chris.january@arm.com>
6473
6474 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6475 qualifier.
6476 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6477
6478 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6479
6480 * f-typeprint.c (f_print_type): Update rules for printing
6481 whitespace.
6482 (f_type_print_varspec_suffix): Likewise.
6483
6484 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6485 Chris January <chris.january@arm.com>
6486
6487 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6488 function arguments.
6489
6490 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6491
6492 * f-lang.c (build_fortran_types): Change name of void type to
6493 lower case.
6494 * f-typeprint.c (f_type_print_base): Print the name of the void
6495 type, rather than a fixed string.
6496 * f-valprint.c (f_decorations): Use lower case void string.
6497
6498 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6499 Chris January <chris.january@arm.com>
6500
6501 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6502 types for Fortran.
6503
6504 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6505 Chris January <chris.january@arm.com>
6506 David Lecomber <david.lecomber@arm.com>
6507
6508 * f-exp.y (BINOP_INTRINSIC): New token.
6509 (exp): New parser rule handling BINOP_INTRINSIC.
6510 (f77_keywords): Add new builtin procedures.
6511 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6512 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6513 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6514 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6515 (print_unop_subexp_f): New function.
6516 (print_binop_subexp_f): New function.
6517 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6518 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6519 (dump_subexp_body_f): Likewise.
6520 (operator_check_f): Likewise.
6521 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6522 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6523
6524 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6525
6526 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6527 UNOP_KIND.
6528 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6529 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6530 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6531 (operator_length_f): New fuction.
6532 (print_subexp_f): New function.
6533 (op_name_f): New function.
6534 (dump_subexp_body_f): New function.
6535 (operator_check_f): New function.
6536 (exp_descriptor_f): Replace standard expression handling functions
6537 with new functions.
6538 * gdb/fortran-operator.def: New file.
6539 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6540 * gdb/std-operator.def: Remove UNOP_KIND.
6541
6542 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6543
6544 * std-operator.def: Remove unbalanced, stray double quote
6545 character.
6546
6547 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6548 Chris January <chris.january@arm.com>
6549 Daniel Everett <daniel.everett@arm.com>
6550 Nick Forrington <nick.forrington@arm.com>
6551 Richard Bunt <richard.bunt@arm.com>
6552
6553 * cp-valprint.c (cp_print_value_fields): Allow an additional level
6554 of depth when printing anonymous structs or unions.
6555 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6556 Don't print either the top-level value, or the children if the
6557 max-depth is exceeded.
6558 (ppscm_print_children): When printing the key of a map, allow one
6559 extra level of depth.
6560 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6561 print either the top-level value, or the children if the max-depth
6562 is exceeded.
6563 (print_children): When printing the key of a map, allow one extra
6564 level of depth.
6565 * python/py-value.c (valpy_format_string): Add max_depth keyword.
6566 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6567 (user_print_options): Initialise max_depth field.
6568 (val_print_scalar_or_string_type_p): New function.
6569 (val_print): Check to see if the max depth has been reached.
6570 (val_print_check_max_depth): Define new function.
6571 (show_print_max_depth): New function.
6572 (_initialize_valprint): Add 'print max-depth' option.
6573 * valprint.h (struct value_print_options) <max_depth>: New field.
6574 (val_print_check_max_depth): Declare new function.
6575 * NEWS: Document new feature.
6576
6577 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6578
6579 * ada-lang.c (ada_language_defn): Initialise new field.
6580 * c-lang.c (c_is_string_type_p): New function.
6581 (c_language_defn): Initialise new field.
6582 (cplus_language_defn): Initialise new field.
6583 (asm_language_defn): Initialise new field.
6584 (minimal_language_defn): Initialise new field.
6585 * c-lang.h (c_is_string_type_p): Declare new function.
6586 * d-lang.c (d_language_defn): Initialise new field.
6587 * f-lang.c (f_is_string_type_p): New function.
6588 (f_language_defn): Initialise new field.
6589 * go-lang.c (go_is_string_type_p): New function.
6590 (go_language_defn): Initialise new field.
6591 * language.c (default_is_string_type_p): New function.
6592 (unknown_language_defn): Initialise new field.
6593 (auto_language_defn): Initialise new field.
6594 * language.h (struct language_defn) <la_is_string_type_p>: New
6595 member variable.
6596 (default_is_string_type_p): Declare new function.
6597 * m2-lang.c (m2_language_defn): Initialise new field.
6598 * objc-lang.c (objc_language_defn): Initialise new field.
6599 * opencl-lang.c (opencl_language_defn): Initialise new field.
6600 * p-lang.c (pascal_is_string_type_p): New function.
6601 (pascal_language_defn): Initialise new field.
6602 * rust-lang.c (rust_is_string_type_p): New function.
6603 (rust_language_defn): Initialise new field.
6604
6605 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6606
6607 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6608 New field.
6609 * ada-lang.c (ada_language_defn): Initialise new field.
6610 * c-lang.c (c_language_defn): Likewise.
6611 (cplus_language_defn): Likewise.
6612 (asm_language_defn): Likewise.
6613 (minimal_language_defn): Likewise.
6614 * d-lang.c (d_language_defn): Likewise.
6615 * f-lang.c (f_language_defn): Likewise.
6616 * go-lang.c (go_language_defn): Likewise.
6617 * language.c (unknown_language_defn): Likewise.
6618 (auto_language_defn): Likewise.
6619 * m2-lang.c (m2_language_defn): Likewise.
6620 * objc-lang.c (objc_language_defn): Likewise.
6621 * opencl-lang.c (opencl_language_defn): Likewise.
6622 * p-lang.c (pascal_language_defn): Likewise.
6623 * rust-lang.c (rust_language_defn): Likewise.
6624
6625 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6626
6627 * ada-lang.c (ada_is_character_type): Change return type to bool.
6628 (ada_is_string_type): Likewise.
6629 * ada-lang.h (ada_is_character_type): Update declaration
6630 (ada_is_string_type): Likewise.
6631
6632 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6633
6634 Support style in 'frame|thread apply'
6635
6636 * gdbcmd.h (execute_command_to_string): New term_out parameter.
6637 * record.c (record_start, record_stop): Update callers of
6638 execute_command_to_string with false.
6639 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6640 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6641 methods.
6642 (class string_file): New constructor with term_out parameter.
6643 Override methods term_out and can_emit_style_escape. New member
6644 term_out.
6645 (class stdio_file): Override can_emit_style_escape.
6646 (class tee_file): Override term_out and can_emit_style_escape.
6647 * utils.h (can_emit_style_escape): Remove.
6648 * utils.c (can_emit_style_escape): Likewise.
6649 Update all callers of can_emit_style_escape (SOMESTREAM) to
6650 SOMESTREAM->can_emit_style_escape.
6651 * source-cache.c (source_cache::get_source_lines): Likewise.
6652 * stack.c (frame_apply_command_count): Call execute_command_to_string
6653 passing the term_out characteristic of the current gdb_stdout.
6654 * thread.c (thr_try_catch_cmd): Likewise.
6655 * top.c (execute_command_to_string): pass term_out parameter
6656 to construct the string_file for the command output.
6657 * ui-file.c (term_cli_styling): New function (most code moved
6658 from utils.c can_emit_style_escape).
6659 (string_file::string_file, string_file::can_emit_style_escape,
6660 stdio_file::can_emit_style_escape, tee_file::term_out,
6661 tee_file::can_emit_style_escape): New functions.
6662
6663 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6664
6665 * NEWS: Mention the new set|show may-call-functions.
6666 * infcall.c (may_call_functions_p): New variable.
6667 (show_may_call_functions_p): New function.
6668 (call_function_by_hand_dummy): Throws an error if not
6669 may-call-functions.
6670 (_initialize_infcall): Call add_setshow_boolean_cmd for
6671 may-call-functions.
6672
6673 2019-04-25 Keith Seitz <keiths@redhat.com>
6674
6675 PR c++/24367
6676 * cp-support.c (inspect_type): Don't attempt substitutions
6677 of symbol with the same name.
6678
6679 2019-04-25 Tom Tromey <tromey@adacore.com>
6680
6681 PR gdb/24475:
6682 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6683 static.
6684
6685 2019-04-25 Tom Tromey <tromey@adacore.com>
6686
6687 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6688 rvalue reference.
6689 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6690 (gdb_xml_parser::parse): Use std::move.
6691 * python/python-internal.h (gdbpy_convert_exception): Take a const
6692 reference.
6693 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6694 std::move.
6695 * python/py-utils.c (gdbpy_convert_exception): Take a const
6696 reference.
6697 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6698 Use std::move.
6699 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6700 Use std::move.
6701 * mi/mi-main.c (mi_print_exception): Take a const reference.
6702 * main.c (handle_command_errors): Take a const reference.
6703 * linespec.c (parse_linespec): Use std::move.
6704 * infcall.c (run_inferior_call): Use std::move.
6705 (call_function_by_hand_dummy): Use std::move.
6706 * exec.c (try_open_exec_file): Use std::move.
6707 * exceptions.h (exception_print, exception_fprintf)
6708 (exception_print_same): Update.
6709 * exceptions.c (print_exception, exception_print)
6710 (exception_fprintf, exception_print_same): Change parameters to
6711 const reference.
6712 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6713 * common/new-op.c: Use std::move.
6714 * common/common-exceptions.h (struct gdb_exception): Add move
6715 constructor.
6716 (struct gdb_exception_error, struct gdb_exception_quit, struct
6717 gdb_quit_bad_alloc): Change constructor to move constructor.
6718 (throw_exception): Change parameter to rvalue reference.
6719 * common/common-exceptions.c (throw_exception): Take rvalue
6720 reference.
6721 * cli/cli-interp.c (safe_execute_command): Use std::move.
6722 * breakpoint.c (insert_bp_location, location_to_sals): Use
6723 std::move.
6724
6725 2019-04-25 Tom Tromey <tromey@adacore.com>
6726
6727 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6728 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6729 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6730 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6731 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6732 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6733 guile/scm-value.c: Use unpack.
6734 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6735 gdbscm_gdb_exception.
6736 (gdbscm_throw_gdb_exception): Likewise.
6737 (struct gdbscm_gdb_exception): New.
6738 (unpack): New function.
6739 (gdbscm_wrap): Use unpack.
6740
6741 2019-04-25 Tom Tromey <tromey@adacore.com>
6742
6743 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6744 (gdb_rl_callback_handler): Use std::move.
6745 * common/common-exceptions.h (struct gdb_exception): Add move
6746 assignment operator.
6747 (throw_exception_sjlj): Change "exception" to const reference.
6748 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6749 (throw_exception_sjlj): Change "exception" to const reference.
6750
6751 2019-04-25 Tom Tromey <tromey@adacore.com>
6752
6753 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6754 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6755 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6756 Update.
6757 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6758 Update.
6759 * mi/mi-interp.c (mi_interp::exec): Update.
6760 * linespec.c (parse_linespec): Update.
6761 * infcall.c (run_inferior_call): Update.
6762 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6763 * guile/scm-symbol.c (gdbscm_lookup_symbol)
6764 (gdbscm_lookup_global_symbol): Update.
6765 * guile/scm-param.c (gdbscm_parameter_value): Update.
6766 * guile/scm-frame.c (gdbscm_frame_read_register)
6767 (gdbscm_frame_read_var): Update.
6768 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6769 * exec.c (try_open_exec_file): Update.
6770 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6771 (gdb_rl_callback_handler): Update.
6772 * common/common-exceptions.h (exception_none): Don't declare.
6773 * common/common-exceptions.c (exception_none): Don't define.
6774 (struct catcher) <exception>: Update.
6775 * cli/cli-interp.c (safe_execute_command): Update.
6776 * breakpoint.c (insert_bp_location, location_to_sals): Update.
6777
6778 2019-04-25 Ali Tamur <tamur@google.com>
6779
6780 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6781 (read_attribute_value): Likewise.
6782 (dwarf2_read_addr_index): Update comment.
6783 (read_str_index): Add DW_FORM_strx.
6784 (dwarf2_string_attr): Likewise.
6785 (dwarf2_const_value_attr): Likewise.
6786 (dump_die_shallow): Likewise.
6787 (dwarf2_fetch_constant_bytes): Likewise.
6788 (skip_form_bytes): Likewise.
6789 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6790
6791 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
6792
6793 PR corefiles/11608
6794 PR corefiles/18187
6795 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6796 OFFSET. Verify if current mapping contains an ELF header.
6797 (linux_find_memory_regions_full): Adjust call to
6798 dump_mapping_p.
6799
6800 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
6801 Kang Li <kanglictf@gmail.com>
6802
6803 PR gdb/21600
6804
6805 * dwarf2-frame.c (read_initial_length): Be consistent about using
6806 unsigned representation of length.
6807 (decode_frame_entry_1): Likewise. Check for wraparound of
6808 end pointer as well as buffer overflow.
6809
6810 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
6811
6812 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6813 "vq".
6814
6815 2019-04-24 Tom Tromey <tromey@adacore.com>
6816
6817 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6818
6819 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6820
6821 * s12z-tdep.c (s12z_unwind_pc): Delete.
6822 (s12z_unwind_sp): Delete.
6823 (s12z_gdbarch_init): Don't register deleted functions with
6824 gdbarch.
6825
6826 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6827
6828 * rl78-tdep.c (rl78_unwind_sp): Delete.
6829 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6830
6831 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6832
6833 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6834 (xstormy16_unwind_pc): Delete.
6835 (xstormy16_dummy_id): Delete.
6836 (xstormy16_gdbarch_init): Don't register deleted functions with
6837 gdbarch.
6838
6839 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6840
6841 * vax-tdep.c (vax_unwind_pc): Delete.
6842 (vax_gdbarch_init): Don't register deleted function with gdbarch.
6843
6844 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6845
6846 * v850-tdep.c (v850_unwind_sp): Delete.
6847 (v850_unwind_pc): Delete.
6848 (v850_dummy_id): Delete.
6849 (v850_gdbarch_init): Don't register deleted functions with
6850 gdbarch.
6851
6852 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6853
6854 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6855 (tilegx_unwind_pc): Delete.
6856 (tilegx_unwind_dummy_id): Delete.
6857 (tilegx_gdbarch_init): Don't register deleted functions with
6858 gdbarch.
6859
6860 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6861
6862 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6863 (tic6x_dummy_id): Delete.
6864 (tic6x_gdbarch_init): Don't register deleted functions with
6865 gdbarch.
6866
6867 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6868
6869 * sparc-tdep.c (sparc_unwind_pc): Delete.
6870 (sparc32_gdbarch_init): Don't register deleted function with
6871 gdbarch.
6872
6873 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6874
6875 * sh-tdep.c (sh_unwind_sp): Delete.
6876 (sh_unwind_pc): Delete.
6877 (sh_dummy_id): Delete.
6878 (sh_gdbarch_init): Don't register deleted functions with
6879 gdbarch.
6880
6881 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6882
6883 * score-tdep.c (score_unwind_sp): Delete.
6884 (score_unwind_pc): Delete.
6885 (score_dummy_id): Delete.
6886 (score_gdbarch_init): Don't register deleted functions with
6887 gdbarch.
6888
6889 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6890
6891 * rx-tdep.c (rx_unwind_pc): Delete.
6892 (rx_unwind_sp): Delete.
6893 (rx_dummy_id): Delete.
6894 (rx_gdbarch_init): Don't register deleted functions with
6895 gdbarch. Update comment.
6896
6897 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6898
6899 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6900 (rs6000_dummy_id): Delete.
6901 (rs6000_gdbarch_init): Don't register deleted functions with
6902 gdbarch.
6903
6904 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6905
6906 * or1k-tdep.c (or1k_dummy_id): Delete.
6907 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6908
6909 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6910
6911 * nios2-tdep.c (nios2_dummy_id): Delete.
6912 (nios2_unwind_sp): Delete.
6913 (nios2_gdbarch_init): Don't register deleted functions with
6914 gdbarch.
6915
6916 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6917
6918 * nds32-tdep.c (nds32_dummy_id): Delete.
6919 (nds32_unwind_pc): Delete.
6920 (nds32_unwind_sp): Delete.
6921 (nds32_gdbarch_init): Don't register deleted functions with
6922 gdbarch.
6923
6924 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6925
6926 * msp430-tdep.c (msp430_unwind_pc): Delete.
6927 (msp430_unwind_sp): Delete.
6928 (msp430_dummy_id): Delete.
6929 (msp430_gdbarch_init): Don't register deleted functions with
6930 gdbarch.
6931
6932 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6933
6934 * moxie-tdep.c (moxie_unwind_sp): Delete.
6935 (moxie_unwind_pc): Delete.
6936 (moxie_dummy_id): Delete.
6937 (moxie_gdbarch_init): Don't register deleted functions with
6938 gdbarch.
6939
6940 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6941
6942 * mn10300-tdep.c (mn10300_dummy_id): Delete.
6943 (mn10300_unwind_pc): Delete.
6944 (mn10300_unwind_sp): Delete.
6945 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6946 mn10300_unwind_sp.
6947 (mn10300_frame_unwind_init): Don't register deleted functions with
6948 gdbarch.
6949
6950 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6951
6952 * mep-tdep.c (mep_unwind_pc): Delete.
6953 (mep_unwind_sp): Delete.
6954 (mep_dummy_id): Delete.
6955 (mep_gdbarch_init): Don't register deleted functions with
6956 gdbarch.
6957
6958 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6959
6960 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6961 (m68hc11_unwind_sp): Delete.
6962 (m68hc11_gdbarch_init): Don't register deleted functions with
6963 gdbarch.
6964
6965 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6966
6967 * m32r-tdep.c (m32r_unwind_sp): Delete.
6968 (m32r_unwind_pc): Delete.
6969 (m32r_dummy_id): Delete.
6970 (m32r_gdbarch_init): Don't register deleted functions with
6971 gdbarch.
6972
6973 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6974
6975 * m32c-tdep.c (m32c_unwind_pc): Delete.
6976 (m32c_unwind_sp): Delete.
6977 (m32c_dummy_id): Delete.
6978 (m32c_gdbarch_init): Don't register deleted functions with
6979 gdbarch.
6980
6981 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6982
6983 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6984 (lm32_unwind_pc): Delete.
6985 (lm32_dummy_id): Delete.
6986 (lm32_gdbarch_init): Don't register deleted functions with
6987 gdbarch.
6988
6989 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6990
6991 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6992 (iq2000_unwind_pc): Delete.
6993 (iq2000_dummy_id): Delete.
6994 (iq2000_gdbarch_init): Don't register deleted functions with
6995 gdbarch.
6996
6997 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6998
6999 * nds32-tdep.c (nds32_type_align): Delete.
7000 (nds32_push_dummy_call): Use type_align instead.
7001
7002 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7003
7004 * arm-tdep.c (arm_type_align): Only handle vector override case.
7005 (arm_push_dummy_call): Use type_align.
7006 (arm_gdbarch_init): Register arm_type_align gdbarch function.
7007
7008 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7009
7010 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7011 case.
7012 (pass_on_stack): Use type_align.
7013 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7014 function.
7015
7016 2019-04-23 Tom Tromey <tromey@adacore.com>
7017
7018 * dwarf2read.c (line_header::file_name_at): Remove unused
7019 overload.
7020
7021 2019-04-23 Tom de Vries <tdevries@suse.de>
7022
7023 PR gdb/24438
7024 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7025 invocation.
7026
7027
7028 2019-03-27 Ali Tamur <tamur@google.com>
7029
7030 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7031 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7032 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7033 (dwarf_expr_context::get_addr_index): Likewise
7034 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7035 (symbol_needs_eval_context::get_addr_index): Likewise
7036 (disassemble_dwarf_expression): Add DW_OP_addrx
7037 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7038 (read_cutu_die_from_dwo): Update comment
7039 (skip_one_die): Add DW_FORM_addrx
7040 (read_attribute_value): Likewise
7041 (var_decode_location): Add DW_OP_addrx
7042 (dwarf2_const_value_attr): Add DW_FORM_addrx
7043 (dump_die_shallow): Likewise
7044 (dwarf2_fetch_constant_bytes): Likewise
7045 (decode_locdesc): Add DW_OP_addrx
7046 (skip_form_bytes): Add DW_FORM_addrx
7047
7048 2019-04-22 Ali Tamur <tamur@google.com>
7049
7050 * MAINTAINERS (Write After Approval): Add self.
7051
7052 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
7053
7054 * solib-svr4.c (get_svr4_info): Add pspace parameter.
7055 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7056 (open_symbol_file_object): Likewise.
7057 (svr4_default_sos): Add info parameter.
7058 (svr4_read_so_list): Likewise.
7059 (svr4_current_sos_direct): Adjust functions calls to pass down
7060 info.
7061 (svr4_current_sos_1): Add info parameter.
7062 (svr4_current_sos): Call get_svr4_info, pass info down to
7063 svr4_current_sos_1.
7064 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7065 get_svr4_info.
7066 (svr4_in_dynsym_resolve_code): Pass current_program_space to
7067 get_svr4_info.
7068 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7069 to get_svr4_info.
7070 (probes_table_remove_objfile_probes): Likewise.
7071 (register_solib_event_probe): Add info parameter.
7072 (solist_update_incremental): Pass info parameter down to
7073 svr4_read_so_list.
7074 (disable_probes_interface): Add info parameter.
7075 (svr4_handle_solib_event): Pass current_program_space to
7076 get_svr4_info. Adjust disable_probes_interface cleanup.
7077 (svr4_create_probe_breakpoints): Add info parameter, pass it
7078 down to register_solib_event_probe.
7079 (svr4_create_solib_event_breakpoints): Add info parameter,
7080 pass it down to svr4_create_probe_breakpoints.
7081 (enable_break): Pass info down to
7082 svr4_create_solib_event_breakpoints.
7083 (svr4_solib_create_inferior_hook): Pass current_program_space to
7084 get_svr4_info.
7085 (svr4_clear_solib): Likewise.
7086
7087 2019-04-22 Pedro Alves <palves@redhat.com>
7088
7089 * solib-svr4.c (svr4_free_objfile_observer): New.
7090 (probe_and_action::objfile): New field.
7091 (probes_table_htab_remove_objfile_probes)
7092 (probes_table_remove_objfile_probes): New functions.
7093 (register_solib_event_probe): Add 'objfile' parameter. Store it
7094 in the new probe_and_action. Don't store the probe in 'lookup'.
7095 (svr4_create_probe_breakpoints): Pass objfile to
7096 register_solib_event_probe.
7097 (_initialize_svr4_solib): Register a free_objfile observer.
7098
7099 2019-04-19 Tom Tromey <tom@tromey.com>
7100
7101 * common/queue.h: Remove.
7102
7103 2019-04-19 Tom Tromey <tom@tromey.com>
7104
7105 * event-loop.c: Don't include "common/queue.h".
7106
7107 2019-04-19 Tom Tromey <tom@tromey.com>
7108
7109 * remote.c (remote_target): Use delete.
7110 * remote-notif.h: Include <list>, not "common/queue.h".
7111 (notif_client_p): Remove typedef.
7112 (remote_notif_state): Add constructor, destructor, initializer.
7113 <notif_queue>: Now a std::list.
7114 (remote_notif_state_xfree): Don't declare.
7115 * remote-notif.c (remote_notif_process, handle_notification)
7116 (remote_notif_state_allocate): Update.
7117 (~remote_notif_state): Rename from remote_notif_state_xfree.
7118
7119 2019-04-19 Tom Tromey <tom@tromey.com>
7120
7121 * symfile.c (reread_symbols): Update.
7122 * objfiles.c (objfile_register_static_link)
7123 (objfile_lookup_static_link): Update
7124 (~objfile) Don't delete static_links.
7125 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7126
7127 2019-04-19 Tom Tromey <tom@tromey.com>
7128
7129 * type-stack.h (struct type_stack) <insert>: Constify string.
7130 * type-stack.c (type_stack::insert): Constify string.
7131 * gdbtypes.h (lookup_template_type): Update.
7132 (address_space_name_to_int): Update.
7133 * gdbtypes.c (address_space_name_to_int): Make space_identifier
7134 const.
7135 (lookup_template_type): Make name const.
7136 * c-exp.y: Update rules.
7137 (lex_one_token, classify_name, classify_inner_name)
7138 (c_print_token): Update.
7139 * p-exp.y: Update rules.
7140 (yylex): Update.
7141 * f-exp.y: Update rules.
7142 (yylex): Update.
7143 * d-exp.y: Update rules.
7144 (lex_one_token, classify_name, classify_inner_name): Update.
7145 * parse.c (write_dollar_variable, copy_name): Return std::string.
7146 * parser-defs.h (copy_name): Change return type.
7147 * m2-exp.y: Update rules.
7148 (yylex): Update.
7149 * go-exp.y (lex_one_token): Update.
7150 Update rules.
7151 (classify_unsafe_function, classify_packaged_name)
7152 (classify_name, yylex): Update.
7153
7154 2019-04-19 Sergei Trofimovich <siarheit@google.com>
7155
7156 * configure.ac: add --enable-source-highlight switch.
7157 * configure: Regenerate.
7158 * top.c (print_gdb_version): plumb --enable-source-highlight
7159 status to "show configuration".
7160
7161 2019-04-19 Tom Tromey <tromey@adacore.com>
7162
7163 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7164 Check ADA_TYPE_P.
7165 (empty_record, ada_template_to_fixed_record_type_1)
7166 (template_to_static_fixed_type)
7167 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7168 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7169 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7170 macros.
7171
7172 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
7173
7174 PR symtab/24423:
7175 * source.c (print_source_lines_base): Advance "iter" when a
7176 control character is seen.
7177
7178 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7179
7180 * inferior.h (struct infcall_suspend_state_deleter):
7181 Catch exception in destructor to avoid crash.
7182
7183 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7184
7185 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7186 close to the add_com "shell".
7187
7188 2019-04-18 Tom Tromey <tromey@adacore.com>
7189
7190 * process-stratum-target.h (class process_stratum_target)
7191 <stratum>: Add "final".
7192
7193 2019-04-17 Tom Tromey <tromey@adacore.com>
7194
7195 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7196 against nullptr before use.
7197
7198 2019-04-17 Alan Hayward <alan.hayward@arm.com>
7199
7200 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7201
7202 2019-04-17 Jim Wilson <jimw@sifive.com>
7203 Andrew Burgess <andrew.burgess@embecosm.com>
7204
7205 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7206 code read might fail, assume 4-byte breakpoint in that case.
7207
7208 2019-04-15 Leszek Swirski <leszeks@google.com>
7209
7210 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7211 rather than a hand-rolled POD check when checking for forced MEMORY
7212 classification.
7213
7214 2019-04-15 Alan Hayward <alan.hayward@arm.com>
7215
7216 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7217 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7218 function.
7219 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7220 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7221 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7222 declaration.
7223
7224 2019-04-15 Alan Hayward <alan.hayward@arm.com>
7225
7226 * aarch64-linux-nat.c
7227 (aarch64_linux_nat_target::thread_architecture): Add override.
7228 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7229 each VQ.
7230
7231 2019-04-15 Alan Hayward <alan.hayward@arm.com>
7232
7233 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7234
7235 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
7236
7237 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7238 target types of size 96-bits, add some additional comments, and
7239 check that the builtin type we found was the correct size.
7240
7241 2019-04-12 Eli Zaretskii <eliz@gnu.org>
7242
7243 * utils.c (prompt_for_continue): Don't restore the styling at the
7244 end, as applied_style has the wrong value. This fixes styling in
7245 long lists of file names that are interrupted by the "Continue?"
7246 prompt.
7247
7248 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
7249
7250 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7251 * c-lang.c (c_language_defn): Likewise.
7252 (cplus_language_defn): Likewise.
7253 (asm_language_defn): Likewise.
7254 (minimal_language_defn): Likewise.
7255 * d-lang.c (d_language_defn): Likewise.
7256 * f-lang.c (f_language_defn): Likewise.
7257 * go-lang.c (go_language_defn): Likewise.
7258 * language.c (unknown_language_defn): Likewise.
7259 (auto_language_defn): Likewise.
7260 * language.h (struct language_defn): Remove la_magic field.
7261 (LANG_MAGIC): Delete.
7262 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7263 * objc-lang.c (objc_language_defn): Likewise.
7264 * opencl-lang.c (opencl_language_defn): Likewise.
7265 * p-lang.c (pascal_language_defn): Likewise.
7266 * rust-lang.c (rust_language_defn): Likewise.
7267
7268 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7269
7270 * riscv-tdep.c (riscv_type_align): New function.
7271 (riscv_type_alignment): Delete.
7272 (riscv_arg_location): Use 'type_align'.
7273 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7274
7275 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7276
7277 * gdbtypes.c (type_align): A struct with no non-static fields also
7278 has alignment of 1.
7279
7280 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7281
7282 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7283 component to 0.
7284 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7285 member.
7286 (riscv_struct_info::analyse): New implementation using new
7287 analyse_inner member function.
7288 (riscv_struct_info::field_offset): New member function.
7289 (riscv_struct_info::m_offsets): New member variable.
7290 (riscv_struct_info::analyse_inner): New private member function,
7291 takes the old implementation of riscv_struct_info::analyse but
7292 extended to track field offsets.
7293 (riscv_call_arg_struct): Update the struct folding special cases
7294 to handle cases where empty C++ structs, which are non-zero
7295 length, are found.
7296 (riscv_arg_location): Initialise the length of each location, a
7297 non-zero length now indicates the location is in use.
7298 (riscv_push_dummy_call): Allow for the first location having a
7299 non-zero offset when setting up arguments.
7300 (riscv_return_value): Likewise, but for return values.
7301
7302 2019-04-11 Tom Tromey <tromey@adacore.com>
7303
7304 * utils.c (internal_vproblem): Make "msg" const.
7305
7306 2019-04-11 Alan Hayward <alan.hayward@arm.com>
7307
7308 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7309 * trad-frame.c (trad_frame_reset_saved_regs): New function.
7310 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7311 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7312
7313 2019-04-10 Kevin Buettner <kevinb@redhat.com>
7314
7315 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7316 function.
7317 (fill_gregset): Call amd64_linux_collect_native_gregset instead
7318 of amd64_collect_native_gregset.
7319 (amd64_linux_nat_target::store_registers): Likewise.
7320
7321 2019-04-10 Tom Tromey <tom@tromey.com>
7322
7323 * symtab.c (lookup_global_symbol_from_objfile)
7324 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7325 * objfiles.h (class separate_debug_iterator): New.
7326 (class separate_debug_range): New.
7327 (struct objfile) <separate_debug_objfiles>: New method.
7328 (objfile_separate_debug_iterate): Don't declare.
7329 * objfiles.c (separate_debug_iterator::operator++): Rename from
7330 objfile_separate_debug_iterate.
7331 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7332 iterator.
7333 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7334 iterator.
7335
7336 2019-04-10 Tom Tromey <tom@tromey.com>
7337
7338 * symfile.c (reread_symbols): Remove old comment.
7339 * objfiles.c (free_all_objfiles): Fix a typo.
7340
7341 2019-04-10 Tom Tromey <tom@tromey.com>
7342
7343 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7344 * minsyms.c (lookup_minimal_symbol): Use foreach.
7345 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7346 (lookup_minimal_symbol_solib_trampoline): Likewise.
7347 * symfile.c (reread_symbols): Use foreach.
7348
7349 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
7350 Tom Tromey <tromey@adacore.com>
7351
7352 PR rust/24414:
7353 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7354 (rust_lex_int_test): Change "value" to be LONGEST.
7355 (rust_lex_tests): Add test for long integer literal.
7356
7357 2019-04-09 Tom Tromey <tromey@adacore.com>
7358
7359 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7360 to bool.
7361 (extended_remote_target::attach): Update.
7362 (remote_target::remote_notice_new_inferior): Update.
7363 (remote_target::add_current_inferior_and_thread): Update.
7364 * inferior.c (exit_inferior_1): Use "false".
7365 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7366
7367 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
7368
7369 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7370 the "start" command.
7371
7372 2019-04-08 Kevin Buettner <kevinb@redhat.com>
7373
7374 * python/py-inferior.c (infpy_thread_from_thread_handle):
7375 Adjust comments to reflect renaming of thread_from_thread_handle
7376 to thread_from_handle. Adjust keywords. Fix type error message.
7377 (inferior_object_methods): Add thread_from_handle. Retain
7378 thread_from_thread_handle, but mark it as deprecated.
7379
7380 2019-04-08 Kevin Buettner <kevinb@redhat.com>
7381
7382 * gdbthread.h (find_thread_by_handle): Revise declaration.
7383 * thread.c (find_thread_by_handle): Likewise. Adjust
7384 implementation too.
7385 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7386 support for buffer objects as handles.
7387
7388 2019-04-08 Kevin Buettner <kevinb@redhat.com>
7389
7390 * python/py-infthread.c (thpy_thread_handle): New function.
7391 (thread_object_methods): Register thpy_thread_handle.
7392
7393 2019-04-08 Kevin Buettner <kevinb@redhat.com>
7394
7395 * gdbthread.h (thread_to_thread_handle): Declare.
7396 * thread.c (gdbtypes.h): Include.
7397 (thread_to_thread_handle): New function.
7398
7399 * target.h (struct target_ops): Add thread_info_to_thread_handle.
7400 (target_thread_info_to_thread_handle): Declare.
7401 * target.c (target_thread_info_to_thread_handle): New function.
7402 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7403 * target-delegates.c: Regenerate.
7404
7405 * linux-thread-db.c (class thread_db_target): Add method
7406 thread_info_to_thread_handle.
7407 (thread_db_target::thread_info_to_thread_handle): Define.
7408 * remote.c (class remote_target): Add new method
7409 thread_info_to_thread_handle.
7410 (remote_target::thread_info_to_thread_handle): Define.
7411
7412 2019-04-08 Pedro Alves <palves@redhat.com>
7413
7414 * common/common-exceptions.c (throw_exception): Don't create
7415 named object to throw; throw directly.
7416 (throw_it): Likewise. Don't initialize gdb_exception::message
7417 here, with new; pass FMT and AP to the ctor instead.
7418 * common/common-exceptions.h: Include <string>.
7419 (gdb_exception::gdb_exception(enum return_reason, enum errors,
7420 const char *, va_list)): New ctor. Use std::make_shared.
7421 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7422 errors)): Delete.
7423 (gdb_exception_error::gdb_exception_error(enum errors, const char
7424 *, va_list)): New.
7425 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7426 Add assertion.
7427 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7428 errors)): Delete.
7429 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7430 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7431 Add assertion.
7432
7433 2019-04-08 Tom Tromey <tom@tromey.com>
7434
7435 * valops.c (value_rtti_indirect_type): Replace throw_exception
7436 with throw.
7437 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7438 with throw.
7439 * thread.c (thr_try_catch_cmd): Replace throw_exception with
7440 throw.
7441 * target.c (target_translate_tls_address): Replace throw_exception
7442 with throw.
7443 * stack.c (frame_apply_command_count): Replace throw_exception
7444 with throw.
7445 * solib-spu.c (append_ocl_sos): Replace throw_exception with
7446 throw.
7447 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7448 with throw.
7449 * rs6000-tdep.c (rs6000_frame_cache)
7450 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7451 * remote.c: Replace throw_exception with throw.
7452 * record-full.c (record_full_message, record_full_wait_1)
7453 (record_full_restore): Replace throw_exception with throw.
7454 * record-btrace.c:
7455 (get_thread_current_frame_id, record_btrace_start_replaying)
7456 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7457 (cmd_record_btrace_start): Replace throw_exception with throw.
7458 * parse.c (parse_exp_in_context_1): Replace throw_exception with
7459 throw.
7460 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7461 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7462 * linespec.c:
7463 (find_linespec_symbols): Replace throw_exception with throw.
7464 * infrun.c (displaced_step_prepare, resume): Replace
7465 throw_exception with throw.
7466 * infcmd.c (post_create_inferior): Replace throw_exception with
7467 throw.
7468 * inf-loop.c (inferior_event_handler): Replace throw_exception
7469 with throw.
7470 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7471 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7472 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7473 (get_prev_frame_always, get_frame_pc_if_available)
7474 (get_frame_address_in_block_if_available, get_frame_language):
7475 Replace throw_exception with throw.
7476 * frame-unwind.c (frame_unwind_try_unwinder): Replace
7477 throw_exception with throw.
7478 * eval.c (fetch_subexp_value, evaluate_var_value)
7479 (evaluate_funcall, evaluate_subexp_standard): Replace
7480 throw_exception with throw.
7481 * dwarf2loc.c (call_site_find_chain)
7482 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7483 Replace throw_exception with throw.
7484 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7485 with throw.
7486 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7487 throw.
7488 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7489 * completer.c (complete_line_internal): Replace throw_exception
7490 with throw.
7491 * compile/compile-object-run.c (compile_object_run): Replace
7492 throw_exception with throw.
7493 * cli/cli-script.c (process_next_line): Replace throw_exception
7494 with throw.
7495 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7496 (btrace_enable, btrace_maint_update_pt_packets): Replace
7497 throw_exception with throw.
7498 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7499 throw_exception with throw.
7500 * break-catch-throw.c (re_set_exception_catchpoint): Replace
7501 throw_exception with throw.
7502 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7503 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7504 * aarch64-tdep.c (aarch64_make_prologue_cache)
7505 (aarch64_make_stub_cache): Replace throw_exception with throw.
7506
7507 2019-04-08 Tom Tromey <tom@tromey.com>
7508
7509 * common/common-exceptions.c (throw_exception): Rename from
7510 throw_exception_cxx. Remove old copy. Make argument const.
7511 (throw_it): Create and throw exception objects directly.
7512 * common/common-exceptions.h (throw_exception): Make argument
7513 const.
7514 (struct gdb_exception_error): Add constructor.
7515 (struct gdb_exception_quit): Add constructor.
7516
7517 2019-04-08 Tom Tromey <tom@tromey.com>
7518
7519 * common/common-exceptions.h (exception_rethrow): Don't declare.
7520 (TRY_SJLJ): Update comment.
7521 (TRY, CATCH, END_CATCH): Remove.
7522 * common/common-exceptions.c (exception_rethrow): Remove.
7523
7524 2019-04-08 Tom Tromey <tom@tromey.com>
7525
7526 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7527 Remove.
7528 (gdb_exception_error): Rename from
7529 gdb_exception_RETURN_MASK_ERROR.
7530 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7531 (gdb_quit_bad_alloc): Update.
7532 * aarch64-tdep.c: Update.
7533 * ada-lang.c: Update.
7534 * ada-typeprint.c: Update.
7535 * ada-valprint.c: Update.
7536 * amd64-tdep.c: Update.
7537 * arch-utils.c: Update.
7538 * break-catch-throw.c: Update.
7539 * breakpoint.c: Update.
7540 * btrace.c: Update.
7541 * c-varobj.c: Update.
7542 * cli/cli-cmds.c: Update.
7543 * cli/cli-interp.c: Update.
7544 * cli/cli-script.c: Update.
7545 * common/common-exceptions.c: Update.
7546 * common/new-op.c: Update.
7547 * common/selftest.c: Update.
7548 * compile/compile-c-symbols.c: Update.
7549 * compile/compile-cplus-symbols.c: Update.
7550 * compile/compile-object-load.c: Update.
7551 * compile/compile-object-run.c: Update.
7552 * completer.c: Update.
7553 * corelow.c: Update.
7554 * cp-abi.c: Update.
7555 * cp-support.c: Update.
7556 * cp-valprint.c: Update.
7557 * darwin-nat.c: Update.
7558 * disasm-selftests.c: Update.
7559 * dtrace-probe.c: Update.
7560 * dwarf-index-cache.c: Update.
7561 * dwarf-index-write.c: Update.
7562 * dwarf2-frame-tailcall.c: Update.
7563 * dwarf2-frame.c: Update.
7564 * dwarf2loc.c: Update.
7565 * dwarf2read.c: Update.
7566 * eval.c: Update.
7567 * event-loop.c: Update.
7568 * event-top.c: Update.
7569 * exec.c: Update.
7570 * f-valprint.c: Update.
7571 * fbsd-tdep.c: Update.
7572 * frame-unwind.c: Update.
7573 * frame.c: Update.
7574 * gdbtypes.c: Update.
7575 * gnu-v3-abi.c: Update.
7576 * guile/guile-internal.h: Update.
7577 * guile/scm-block.c: Update.
7578 * guile/scm-breakpoint.c: Update.
7579 * guile/scm-cmd.c: Update.
7580 * guile/scm-disasm.c: Update.
7581 * guile/scm-frame.c: Update.
7582 * guile/scm-lazy-string.c: Update.
7583 * guile/scm-math.c: Update.
7584 * guile/scm-param.c: Update.
7585 * guile/scm-ports.c: Update.
7586 * guile/scm-pretty-print.c: Update.
7587 * guile/scm-symbol.c: Update.
7588 * guile/scm-symtab.c: Update.
7589 * guile/scm-type.c: Update.
7590 * guile/scm-value.c: Update.
7591 * i386-linux-tdep.c: Update.
7592 * i386-tdep.c: Update.
7593 * inf-loop.c: Update.
7594 * infcall.c: Update.
7595 * infcmd.c: Update.
7596 * infrun.c: Update.
7597 * jit.c: Update.
7598 * language.c: Update.
7599 * linespec.c: Update.
7600 * linux-fork.c: Update.
7601 * linux-nat.c: Update.
7602 * linux-tdep.c: Update.
7603 * linux-thread-db.c: Update.
7604 * main.c: Update.
7605 * mi/mi-cmd-break.c: Update.
7606 * mi/mi-cmd-stack.c: Update.
7607 * mi/mi-interp.c: Update.
7608 * mi/mi-main.c: Update.
7609 * objc-lang.c: Update.
7610 * p-valprint.c: Update.
7611 * parse.c: Update.
7612 * ppc-linux-tdep.c: Update.
7613 * printcmd.c: Update.
7614 * python/py-arch.c: Update.
7615 * python/py-breakpoint.c: Update.
7616 * python/py-cmd.c: Update.
7617 * python/py-finishbreakpoint.c: Update.
7618 * python/py-frame.c: Update.
7619 * python/py-framefilter.c: Update.
7620 * python/py-gdb-readline.c: Update.
7621 * python/py-inferior.c: Update.
7622 * python/py-infthread.c: Update.
7623 * python/py-lazy-string.c: Update.
7624 * python/py-linetable.c: Update.
7625 * python/py-objfile.c: Update.
7626 * python/py-param.c: Update.
7627 * python/py-prettyprint.c: Update.
7628 * python/py-progspace.c: Update.
7629 * python/py-record-btrace.c: Update.
7630 * python/py-record.c: Update.
7631 * python/py-symbol.c: Update.
7632 * python/py-type.c: Update.
7633 * python/py-unwind.c: Update.
7634 * python/py-utils.c: Update.
7635 * python/py-value.c: Update.
7636 * python/python.c: Update.
7637 * record-btrace.c: Update.
7638 * record-full.c: Update.
7639 * remote-fileio.c: Update.
7640 * remote.c: Update.
7641 * riscv-tdep.c: Update.
7642 * rs6000-aix-tdep.c: Update.
7643 * rs6000-tdep.c: Update.
7644 * rust-exp.y: Update.
7645 * rust-lang.c: Update.
7646 * s390-tdep.c: Update.
7647 * selftest-arch.c: Update.
7648 * solib-dsbt.c: Update.
7649 * solib-frv.c: Update.
7650 * solib-spu.c: Update.
7651 * solib-svr4.c: Update.
7652 * solib.c: Update.
7653 * sparc64-linux-tdep.c: Update.
7654 * stack.c: Update.
7655 * symfile-mem.c: Update.
7656 * symmisc.c: Update.
7657 * target.c: Update.
7658 * thread.c: Update.
7659 * top.c: Update.
7660 * tracefile-tfile.c: Update.
7661 * tui/tui.c: Update.
7662 * typeprint.c: Update.
7663 * unittests/cli-utils-selftests.c: Update.
7664 * unittests/parse-connection-spec-selftests.c: Update.
7665 * valops.c: Update.
7666 * valprint.c: Update.
7667 * value.c: Update.
7668 * varobj.c: Update.
7669 * windows-nat.c: Update.
7670 * x86-linux-nat.c: Update.
7671 * xml-support.c: Update.
7672
7673 2019-04-08 Tom Tromey <tom@tromey.com>
7674
7675 * xml-support.c: Use C++ exception handling.
7676 * x86-linux-nat.c: Use C++ exception handling.
7677 * windows-nat.c: Use C++ exception handling.
7678 * varobj.c: Use C++ exception handling.
7679 * value.c: Use C++ exception handling.
7680 * valprint.c: Use C++ exception handling.
7681 * valops.c: Use C++ exception handling.
7682 * unittests/parse-connection-spec-selftests.c: Use C++ exception
7683 handling.
7684 * unittests/cli-utils-selftests.c: Use C++ exception handling.
7685 * typeprint.c: Use C++ exception handling.
7686 * tui/tui.c: Use C++ exception handling.
7687 * tracefile-tfile.c: Use C++ exception handling.
7688 * top.c: Use C++ exception handling.
7689 * thread.c: Use C++ exception handling.
7690 * target.c: Use C++ exception handling.
7691 * symmisc.c: Use C++ exception handling.
7692 * symfile-mem.c: Use C++ exception handling.
7693 * stack.c: Use C++ exception handling.
7694 * sparc64-linux-tdep.c: Use C++ exception handling.
7695 * solib.c: Use C++ exception handling.
7696 * solib-svr4.c: Use C++ exception handling.
7697 * solib-spu.c: Use C++ exception handling.
7698 * solib-frv.c: Use C++ exception handling.
7699 * solib-dsbt.c: Use C++ exception handling.
7700 * selftest-arch.c: Use C++ exception handling.
7701 * s390-tdep.c: Use C++ exception handling.
7702 * rust-lang.c: Use C++ exception handling.
7703 * rust-exp.y: Use C++ exception handling.
7704 * rs6000-tdep.c: Use C++ exception handling.
7705 * rs6000-aix-tdep.c: Use C++ exception handling.
7706 * riscv-tdep.c: Use C++ exception handling.
7707 * remote.c: Use C++ exception handling.
7708 * remote-fileio.c: Use C++ exception handling.
7709 * record-full.c: Use C++ exception handling.
7710 * record-btrace.c: Use C++ exception handling.
7711 * python/python.c: Use C++ exception handling.
7712 * python/py-value.c: Use C++ exception handling.
7713 * python/py-utils.c: Use C++ exception handling.
7714 * python/py-unwind.c: Use C++ exception handling.
7715 * python/py-type.c: Use C++ exception handling.
7716 * python/py-symbol.c: Use C++ exception handling.
7717 * python/py-record.c: Use C++ exception handling.
7718 * python/py-record-btrace.c: Use C++ exception handling.
7719 * python/py-progspace.c: Use C++ exception handling.
7720 * python/py-prettyprint.c: Use C++ exception handling.
7721 * python/py-param.c: Use C++ exception handling.
7722 * python/py-objfile.c: Use C++ exception handling.
7723 * python/py-linetable.c: Use C++ exception handling.
7724 * python/py-lazy-string.c: Use C++ exception handling.
7725 * python/py-infthread.c: Use C++ exception handling.
7726 * python/py-inferior.c: Use C++ exception handling.
7727 * python/py-gdb-readline.c: Use C++ exception handling.
7728 * python/py-framefilter.c: Use C++ exception handling.
7729 * python/py-frame.c: Use C++ exception handling.
7730 * python/py-finishbreakpoint.c: Use C++ exception handling.
7731 * python/py-cmd.c: Use C++ exception handling.
7732 * python/py-breakpoint.c: Use C++ exception handling.
7733 * python/py-arch.c: Use C++ exception handling.
7734 * printcmd.c: Use C++ exception handling.
7735 * ppc-linux-tdep.c: Use C++ exception handling.
7736 * parse.c: Use C++ exception handling.
7737 * p-valprint.c: Use C++ exception handling.
7738 * objc-lang.c: Use C++ exception handling.
7739 * mi/mi-main.c: Use C++ exception handling.
7740 * mi/mi-interp.c: Use C++ exception handling.
7741 * mi/mi-cmd-stack.c: Use C++ exception handling.
7742 * mi/mi-cmd-break.c: Use C++ exception handling.
7743 * main.c: Use C++ exception handling.
7744 * linux-thread-db.c: Use C++ exception handling.
7745 * linux-tdep.c: Use C++ exception handling.
7746 * linux-nat.c: Use C++ exception handling.
7747 * linux-fork.c: Use C++ exception handling.
7748 * linespec.c: Use C++ exception handling.
7749 * language.c: Use C++ exception handling.
7750 * jit.c: Use C++ exception handling.
7751 * infrun.c: Use C++ exception handling.
7752 * infcmd.c: Use C++ exception handling.
7753 * infcall.c: Use C++ exception handling.
7754 * inf-loop.c: Use C++ exception handling.
7755 * i386-tdep.c: Use C++ exception handling.
7756 * i386-linux-tdep.c: Use C++ exception handling.
7757 * guile/scm-value.c: Use C++ exception handling.
7758 * guile/scm-type.c: Use C++ exception handling.
7759 * guile/scm-symtab.c: Use C++ exception handling.
7760 * guile/scm-symbol.c: Use C++ exception handling.
7761 * guile/scm-pretty-print.c: Use C++ exception handling.
7762 * guile/scm-ports.c: Use C++ exception handling.
7763 * guile/scm-param.c: Use C++ exception handling.
7764 * guile/scm-math.c: Use C++ exception handling.
7765 * guile/scm-lazy-string.c: Use C++ exception handling.
7766 * guile/scm-frame.c: Use C++ exception handling.
7767 * guile/scm-disasm.c: Use C++ exception handling.
7768 * guile/scm-cmd.c: Use C++ exception handling.
7769 * guile/scm-breakpoint.c: Use C++ exception handling.
7770 * guile/scm-block.c: Use C++ exception handling.
7771 * guile/guile-internal.h: Use C++ exception handling.
7772 * gnu-v3-abi.c: Use C++ exception handling.
7773 * gdbtypes.c: Use C++ exception handling.
7774 * frame.c: Use C++ exception handling.
7775 * frame-unwind.c: Use C++ exception handling.
7776 * fbsd-tdep.c: Use C++ exception handling.
7777 * f-valprint.c: Use C++ exception handling.
7778 * exec.c: Use C++ exception handling.
7779 * event-top.c: Use C++ exception handling.
7780 * event-loop.c: Use C++ exception handling.
7781 * eval.c: Use C++ exception handling.
7782 * dwarf2read.c: Use C++ exception handling.
7783 * dwarf2loc.c: Use C++ exception handling.
7784 * dwarf2-frame.c: Use C++ exception handling.
7785 * dwarf2-frame-tailcall.c: Use C++ exception handling.
7786 * dwarf-index-write.c: Use C++ exception handling.
7787 * dwarf-index-cache.c: Use C++ exception handling.
7788 * dtrace-probe.c: Use C++ exception handling.
7789 * disasm-selftests.c: Use C++ exception handling.
7790 * darwin-nat.c: Use C++ exception handling.
7791 * cp-valprint.c: Use C++ exception handling.
7792 * cp-support.c: Use C++ exception handling.
7793 * cp-abi.c: Use C++ exception handling.
7794 * corelow.c: Use C++ exception handling.
7795 * completer.c: Use C++ exception handling.
7796 * compile/compile-object-run.c: Use C++ exception handling.
7797 * compile/compile-object-load.c: Use C++ exception handling.
7798 * compile/compile-cplus-symbols.c: Use C++ exception handling.
7799 * compile/compile-c-symbols.c: Use C++ exception handling.
7800 * common/selftest.c: Use C++ exception handling.
7801 * common/new-op.c: Use C++ exception handling.
7802 * cli/cli-script.c: Use C++ exception handling.
7803 * cli/cli-interp.c: Use C++ exception handling.
7804 * cli/cli-cmds.c: Use C++ exception handling.
7805 * c-varobj.c: Use C++ exception handling.
7806 * btrace.c: Use C++ exception handling.
7807 * breakpoint.c: Use C++ exception handling.
7808 * break-catch-throw.c: Use C++ exception handling.
7809 * arch-utils.c: Use C++ exception handling.
7810 * amd64-tdep.c: Use C++ exception handling.
7811 * ada-valprint.c: Use C++ exception handling.
7812 * ada-typeprint.c: Use C++ exception handling.
7813 * ada-lang.c: Use C++ exception handling.
7814 * aarch64-tdep.c: Use C++ exception handling.
7815
7816 2019-04-08 Tom Tromey <tom@tromey.com>
7817
7818 * xml-support.c (gdb_xml_parser::parse): Update.
7819 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7820 * value.c (show_convenience): Update.
7821 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7822 (test_parse_flags_qcs): Update.
7823 * thread.c (thr_try_catch_cmd): Update.
7824 * target.c (target_translate_tls_address): Update.
7825 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7826 (info_frame_command_core, frame_apply_command_count): Update.
7827 * rust-exp.y (rust_lex_exception_test): Update.
7828 * riscv-tdep.c (riscv_print_one_register_info): Update.
7829 * remote.c (remote_target::enable_btrace): Update.
7830 * record-btrace.c (record_btrace_enable_warn): Update.
7831 * python/py-utils.c (gdbpy_convert_exception): Update.
7832 * printcmd.c (do_one_display, print_variable_and_value): Update.
7833 * mi/mi-main.c (mi_print_exception): Update.
7834 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7835 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7836 * linux-nat.c (linux_nat_target::attach): Update.
7837 * linux-fork.c (class scoped_switch_fork_info): Update.
7838 * infrun.c (displaced_step_prepare): Update.
7839 * infcall.c (call_function_by_hand_dummy): Update.
7840 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7841 * gnu-v3-abi.c (print_one_vtable): Update.
7842 * frame.c (get_prev_frame_always): Update.
7843 * f-valprint.c (info_common_command_for_block): Update.
7844 * exec.c (try_open_exec_file): Update.
7845 * exceptions.c (print_exception, exception_print)
7846 (exception_fprintf, exception_print_same): Update.
7847 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7848 * dwarf-index-cache.c (index_cache::store)
7849 (index_cache::lookup_gdb_index): Update.
7850 * darwin-nat.c (maybe_cache_shell): Update.
7851 * cp-valprint.c (cp_print_value_fields): Update.
7852 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7853 (gcc_cplus_symbol_address): Update.
7854 * compile/compile-c-symbols.c (gcc_convert_symbol)
7855 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7856 * common/selftest.c: Update.
7857 * common/common-exceptions.h (struct gdb_exception) <message>: Now
7858 a std::string.
7859 (exception_try_scope_entry, exception_try_scope_exit): Don't
7860 declare.
7861 (struct exception_try_scope): Remove.
7862 (TRY): Don't use exception_try_scope.
7863 (struct gdb_exception): Add constructor, operator=.
7864 <what>: New method.
7865 (struct gdb_exception_RETURN_MASK_ALL)
7866 (struct gdb_exception_RETURN_MASK_ERROR)
7867 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7868 (struct gdb_quit_bad_alloc): Update.
7869 * common/common-exceptions.c (exception_none): Change
7870 initializer.
7871 (struct catcher) <state, exception>: Initialize inline.
7872 <prev>: Remove member.
7873 (current_catcher): Remove.
7874 (catchers): New global.
7875 (exceptions_state_mc_init): Simplify.
7876 (catcher_pop): Remove.
7877 (exceptions_state_mc, exceptions_state_mc_catch): Update.
7878 (try_scope_depth, exception_try_scope_entry)
7879 (exception_try_scope_exit): Remove.
7880 (throw_exception_sjlj): Update.
7881 (exception_messages, exception_messages_size): Remove.
7882 (throw_it): Simplify.
7883 (gdb_exception_sliced_copy): Remove.
7884 (throw_exception_cxx): Update.
7885 * cli/cli-script.c (script_from_file): Update.
7886 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7887 Update.
7888 * ada-valprint.c (ada_val_print): Update.
7889 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7890 (create_excep_cond_exprs): Update.
7891
7892 2019-04-08 Tom Tromey <tom@tromey.com>
7893
7894 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7895 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7896 (TRY, CATCH, END_CATCH): Remove some definitions.
7897 * common/common-exceptions.c: Don't use GDB_XCPT.
7898 (catcher_list_size): Remove.
7899 (throw_exception, throw_it): Simplify.
7900
7901 2019-04-05 Tom Tromey <tom@tromey.com>
7902
7903 Revert the header-sorting patch.
7904 * ft32-tdep.c: Revert.
7905 * frv-tdep.c: Revert.
7906 * frv-linux-tdep.c: Revert.
7907 * frame.c: Revert.
7908 * frame-unwind.c: Revert.
7909 * frame-base.c: Revert.
7910 * fork-child.c: Revert.
7911 * findvar.c: Revert.
7912 * findcmd.c: Revert.
7913 * filesystem.c: Revert.
7914 * filename-seen-cache.h: Revert.
7915 * filename-seen-cache.c: Revert.
7916 * fbsd-tdep.c: Revert.
7917 * fbsd-nat.h: Revert.
7918 * fbsd-nat.c: Revert.
7919 * f-valprint.c: Revert.
7920 * f-typeprint.c: Revert.
7921 * f-lang.c: Revert.
7922 * extension.h: Revert.
7923 * extension.c: Revert.
7924 * extension-priv.h: Revert.
7925 * expprint.c: Revert.
7926 * exec.h: Revert.
7927 * exec.c: Revert.
7928 * exceptions.c: Revert.
7929 * event-top.c: Revert.
7930 * event-loop.c: Revert.
7931 * eval.c: Revert.
7932 * elfread.c: Revert.
7933 * dwarf2read.h: Revert.
7934 * dwarf2read.c: Revert.
7935 * dwarf2loc.c: Revert.
7936 * dwarf2expr.h: Revert.
7937 * dwarf2expr.c: Revert.
7938 * dwarf2-frame.c: Revert.
7939 * dwarf2-frame-tailcall.c: Revert.
7940 * dwarf-index-write.h: Revert.
7941 * dwarf-index-write.c: Revert.
7942 * dwarf-index-common.c: Revert.
7943 * dwarf-index-cache.h: Revert.
7944 * dwarf-index-cache.c: Revert.
7945 * dummy-frame.c: Revert.
7946 * dtrace-probe.c: Revert.
7947 * disasm.h: Revert.
7948 * disasm.c: Revert.
7949 * disasm-selftests.c: Revert.
7950 * dictionary.c: Revert.
7951 * dicos-tdep.c: Revert.
7952 * demangle.c: Revert.
7953 * dcache.h: Revert.
7954 * dcache.c: Revert.
7955 * darwin-nat.h: Revert.
7956 * darwin-nat.c: Revert.
7957 * darwin-nat-info.c: Revert.
7958 * d-valprint.c: Revert.
7959 * d-namespace.c: Revert.
7960 * d-lang.c: Revert.
7961 * ctf.c: Revert.
7962 * csky-tdep.c: Revert.
7963 * csky-linux-tdep.c: Revert.
7964 * cris-tdep.c: Revert.
7965 * cris-linux-tdep.c: Revert.
7966 * cp-valprint.c: Revert.
7967 * cp-support.c: Revert.
7968 * cp-namespace.c: Revert.
7969 * cp-abi.c: Revert.
7970 * corelow.c: Revert.
7971 * corefile.c: Revert.
7972 * continuations.c: Revert.
7973 * completer.h: Revert.
7974 * completer.c: Revert.
7975 * complaints.c: Revert.
7976 * coffread.c: Revert.
7977 * coff-pe-read.c: Revert.
7978 * cli-out.h: Revert.
7979 * cli-out.c: Revert.
7980 * charset.c: Revert.
7981 * c-varobj.c: Revert.
7982 * c-valprint.c: Revert.
7983 * c-typeprint.c: Revert.
7984 * c-lang.c: Revert.
7985 * buildsym.c: Revert.
7986 * buildsym-legacy.c: Revert.
7987 * build-id.h: Revert.
7988 * build-id.c: Revert.
7989 * btrace.c: Revert.
7990 * bsd-uthread.c: Revert.
7991 * breakpoint.h: Revert.
7992 * breakpoint.c: Revert.
7993 * break-catch-throw.c: Revert.
7994 * break-catch-syscall.c: Revert.
7995 * break-catch-sig.c: Revert.
7996 * blockframe.c: Revert.
7997 * block.c: Revert.
7998 * bfin-tdep.c: Revert.
7999 * bfin-linux-tdep.c: Revert.
8000 * bfd-target.c: Revert.
8001 * bcache.c: Revert.
8002 * ax-general.c: Revert.
8003 * ax-gdb.h: Revert.
8004 * ax-gdb.c: Revert.
8005 * avr-tdep.c: Revert.
8006 * auxv.c: Revert.
8007 * auto-load.c: Revert.
8008 * arm-wince-tdep.c: Revert.
8009 * arm-tdep.c: Revert.
8010 * arm-symbian-tdep.c: Revert.
8011 * arm-pikeos-tdep.c: Revert.
8012 * arm-obsd-tdep.c: Revert.
8013 * arm-nbsd-tdep.c: Revert.
8014 * arm-nbsd-nat.c: Revert.
8015 * arm-linux-tdep.c: Revert.
8016 * arm-linux-nat.c: Revert.
8017 * arm-fbsd-tdep.c: Revert.
8018 * arm-fbsd-nat.c: Revert.
8019 * arm-bsd-tdep.c: Revert.
8020 * arch-utils.c: Revert.
8021 * arc-tdep.c: Revert.
8022 * arc-newlib-tdep.c: Revert.
8023 * annotate.h: Revert.
8024 * annotate.c: Revert.
8025 * amd64-windows-tdep.c: Revert.
8026 * amd64-windows-nat.c: Revert.
8027 * amd64-tdep.c: Revert.
8028 * amd64-sol2-tdep.c: Revert.
8029 * amd64-obsd-tdep.c: Revert.
8030 * amd64-obsd-nat.c: Revert.
8031 * amd64-nbsd-tdep.c: Revert.
8032 * amd64-nbsd-nat.c: Revert.
8033 * amd64-nat.c: Revert.
8034 * amd64-linux-tdep.c: Revert.
8035 * amd64-linux-nat.c: Revert.
8036 * amd64-fbsd-tdep.c: Revert.
8037 * amd64-fbsd-nat.c: Revert.
8038 * amd64-dicos-tdep.c: Revert.
8039 * amd64-darwin-tdep.c: Revert.
8040 * amd64-bsd-nat.c: Revert.
8041 * alpha-tdep.c: Revert.
8042 * alpha-obsd-tdep.c: Revert.
8043 * alpha-nbsd-tdep.c: Revert.
8044 * alpha-mdebug-tdep.c: Revert.
8045 * alpha-linux-tdep.c: Revert.
8046 * alpha-linux-nat.c: Revert.
8047 * alpha-bsd-tdep.c: Revert.
8048 * alpha-bsd-nat.c: Revert.
8049 * aix-thread.c: Revert.
8050 * agent.c: Revert.
8051 * addrmap.c: Revert.
8052 * ada-varobj.c: Revert.
8053 * ada-valprint.c: Revert.
8054 * ada-typeprint.c: Revert.
8055 * ada-tasks.c: Revert.
8056 * ada-lang.c: Revert.
8057 * aarch64-tdep.c: Revert.
8058 * aarch64-ravenscar-thread.c: Revert.
8059 * aarch64-newlib-tdep.c: Revert.
8060 * aarch64-linux-tdep.c: Revert.
8061 * aarch64-linux-nat.c: Revert.
8062 * aarch64-fbsd-tdep.c: Revert.
8063 * aarch64-fbsd-nat.c: Revert.
8064 * aarch32-linux-nat.c: Revert.
8065
8066 2019-04-05 Tom Tromey <tom@tromey.com>
8067
8068 * ft32-tdep.c: Sort headers.
8069 * frv-tdep.c: Sort headers.
8070 * frv-linux-tdep.c: Sort headers.
8071 * frame.c: Sort headers.
8072 * frame-unwind.c: Sort headers.
8073 * frame-base.c: Sort headers.
8074 * fork-child.c: Sort headers.
8075 * findvar.c: Sort headers.
8076 * findcmd.c: Sort headers.
8077 * filesystem.c: Sort headers.
8078 * filename-seen-cache.h: Sort headers.
8079 * filename-seen-cache.c: Sort headers.
8080 * fbsd-tdep.c: Sort headers.
8081 * fbsd-nat.h: Sort headers.
8082 * fbsd-nat.c: Sort headers.
8083 * f-valprint.c: Sort headers.
8084 * f-typeprint.c: Sort headers.
8085 * f-lang.c: Sort headers.
8086 * extension.h: Sort headers.
8087 * extension.c: Sort headers.
8088 * extension-priv.h: Sort headers.
8089 * expprint.c: Sort headers.
8090 * exec.h: Sort headers.
8091 * exec.c: Sort headers.
8092 * exceptions.c: Sort headers.
8093 * event-top.c: Sort headers.
8094 * event-loop.c: Sort headers.
8095 * eval.c: Sort headers.
8096 * elfread.c: Sort headers.
8097 * dwarf2read.h: Sort headers.
8098 * dwarf2read.c: Sort headers.
8099 * dwarf2loc.c: Sort headers.
8100 * dwarf2expr.h: Sort headers.
8101 * dwarf2expr.c: Sort headers.
8102 * dwarf2-frame.c: Sort headers.
8103 * dwarf2-frame-tailcall.c: Sort headers.
8104 * dwarf-index-write.h: Sort headers.
8105 * dwarf-index-write.c: Sort headers.
8106 * dwarf-index-common.c: Sort headers.
8107 * dwarf-index-cache.h: Sort headers.
8108 * dwarf-index-cache.c: Sort headers.
8109 * dummy-frame.c: Sort headers.
8110 * dtrace-probe.c: Sort headers.
8111 * disasm.h: Sort headers.
8112 * disasm.c: Sort headers.
8113 * disasm-selftests.c: Sort headers.
8114 * dictionary.c: Sort headers.
8115 * dicos-tdep.c: Sort headers.
8116 * demangle.c: Sort headers.
8117 * dcache.h: Sort headers.
8118 * dcache.c: Sort headers.
8119 * darwin-nat.h: Sort headers.
8120 * darwin-nat.c: Sort headers.
8121 * darwin-nat-info.c: Sort headers.
8122 * d-valprint.c: Sort headers.
8123 * d-namespace.c: Sort headers.
8124 * d-lang.c: Sort headers.
8125 * ctf.c: Sort headers.
8126 * csky-tdep.c: Sort headers.
8127 * csky-linux-tdep.c: Sort headers.
8128 * cris-tdep.c: Sort headers.
8129 * cris-linux-tdep.c: Sort headers.
8130 * cp-valprint.c: Sort headers.
8131 * cp-support.c: Sort headers.
8132 * cp-namespace.c: Sort headers.
8133 * cp-abi.c: Sort headers.
8134 * corelow.c: Sort headers.
8135 * corefile.c: Sort headers.
8136 * continuations.c: Sort headers.
8137 * completer.h: Sort headers.
8138 * completer.c: Sort headers.
8139 * complaints.c: Sort headers.
8140 * coffread.c: Sort headers.
8141 * coff-pe-read.c: Sort headers.
8142 * cli-out.h: Sort headers.
8143 * cli-out.c: Sort headers.
8144 * charset.c: Sort headers.
8145 * c-varobj.c: Sort headers.
8146 * c-valprint.c: Sort headers.
8147 * c-typeprint.c: Sort headers.
8148 * c-lang.c: Sort headers.
8149 * buildsym.c: Sort headers.
8150 * buildsym-legacy.c: Sort headers.
8151 * build-id.h: Sort headers.
8152 * build-id.c: Sort headers.
8153 * btrace.c: Sort headers.
8154 * bsd-uthread.c: Sort headers.
8155 * breakpoint.h: Sort headers.
8156 * breakpoint.c: Sort headers.
8157 * break-catch-throw.c: Sort headers.
8158 * break-catch-syscall.c: Sort headers.
8159 * break-catch-sig.c: Sort headers.
8160 * blockframe.c: Sort headers.
8161 * block.c: Sort headers.
8162 * bfin-tdep.c: Sort headers.
8163 * bfin-linux-tdep.c: Sort headers.
8164 * bfd-target.c: Sort headers.
8165 * bcache.c: Sort headers.
8166 * ax-general.c: Sort headers.
8167 * ax-gdb.h: Sort headers.
8168 * ax-gdb.c: Sort headers.
8169 * avr-tdep.c: Sort headers.
8170 * auxv.c: Sort headers.
8171 * auto-load.c: Sort headers.
8172 * arm-wince-tdep.c: Sort headers.
8173 * arm-tdep.c: Sort headers.
8174 * arm-symbian-tdep.c: Sort headers.
8175 * arm-pikeos-tdep.c: Sort headers.
8176 * arm-obsd-tdep.c: Sort headers.
8177 * arm-nbsd-tdep.c: Sort headers.
8178 * arm-nbsd-nat.c: Sort headers.
8179 * arm-linux-tdep.c: Sort headers.
8180 * arm-linux-nat.c: Sort headers.
8181 * arm-fbsd-tdep.c: Sort headers.
8182 * arm-fbsd-nat.c: Sort headers.
8183 * arm-bsd-tdep.c: Sort headers.
8184 * arch-utils.c: Sort headers.
8185 * arc-tdep.c: Sort headers.
8186 * arc-newlib-tdep.c: Sort headers.
8187 * annotate.h: Sort headers.
8188 * annotate.c: Sort headers.
8189 * amd64-windows-tdep.c: Sort headers.
8190 * amd64-windows-nat.c: Sort headers.
8191 * amd64-tdep.c: Sort headers.
8192 * amd64-sol2-tdep.c: Sort headers.
8193 * amd64-obsd-tdep.c: Sort headers.
8194 * amd64-obsd-nat.c: Sort headers.
8195 * amd64-nbsd-tdep.c: Sort headers.
8196 * amd64-nbsd-nat.c: Sort headers.
8197 * amd64-nat.c: Sort headers.
8198 * amd64-linux-tdep.c: Sort headers.
8199 * amd64-linux-nat.c: Sort headers.
8200 * amd64-fbsd-tdep.c: Sort headers.
8201 * amd64-fbsd-nat.c: Sort headers.
8202 * amd64-dicos-tdep.c: Sort headers.
8203 * amd64-darwin-tdep.c: Sort headers.
8204 * amd64-bsd-nat.c: Sort headers.
8205 * alpha-tdep.c: Sort headers.
8206 * alpha-obsd-tdep.c: Sort headers.
8207 * alpha-nbsd-tdep.c: Sort headers.
8208 * alpha-mdebug-tdep.c: Sort headers.
8209 * alpha-linux-tdep.c: Sort headers.
8210 * alpha-linux-nat.c: Sort headers.
8211 * alpha-bsd-tdep.c: Sort headers.
8212 * alpha-bsd-nat.c: Sort headers.
8213 * aix-thread.c: Sort headers.
8214 * agent.c: Sort headers.
8215 * addrmap.c: Sort headers.
8216 * ada-varobj.c: Sort headers.
8217 * ada-valprint.c: Sort headers.
8218 * ada-typeprint.c: Sort headers.
8219 * ada-tasks.c: Sort headers.
8220 * ada-lang.c: Sort headers.
8221 * aarch64-tdep.c: Sort headers.
8222 * aarch64-ravenscar-thread.c: Sort headers.
8223 * aarch64-newlib-tdep.c: Sort headers.
8224 * aarch64-linux-tdep.c: Sort headers.
8225 * aarch64-linux-nat.c: Sort headers.
8226 * aarch64-fbsd-tdep.c: Sort headers.
8227 * aarch64-fbsd-nat.c: Sort headers.
8228 * aarch32-linux-nat.c: Sort headers.
8229
8230 2019-04-04 Tom Tromey <tom@tromey.com>
8231
8232 * varobj.c (varobj_create): Update.
8233 * rust-exp.y (struct rust_parser) <update_innermost_block,
8234 lookup_symbol>: New methods.
8235 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8236 Rename.
8237 (rust_parser::rust_lookup_type)
8238 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8239 * printcmd.c (display_command, do_one_display): Update.
8240 * parser-defs.h (struct parser_state) <parser_state>: Add
8241 "tracker" parameter.
8242 (block_tracker): New member.
8243 (class innermost_block_tracker) <innermost_block_tracker>: Add
8244 "types" parameter.
8245 <reset>: Remove method.
8246 (innermost_block): Don't declare.
8247 (null_post_parser): Update.
8248 * parse.c (innermost_block): Remove global.
8249 (write_dollar_variable): Update.
8250 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8251 Remove "tracker_types" parameter.
8252 (parse_expression): Add "tracker" parameter.
8253 (parse_expression_for_completion): Update.
8254 (null_post_parser): Add "tracker" parameter.
8255 * p-exp.y: Update rules.
8256 * m2-exp.y: Update rules.
8257 * language.h (struct language_defn) <la_post_parser>: Add
8258 "tracker" parameter.
8259 * go-exp.y: Update rules.
8260 * f-exp.y: Update rules.
8261 * expression.h (parse_expression, parse_exp_1): Add "tracker"
8262 parameter.
8263 * d-exp.y: Update rules.
8264 * c-exp.y: Update rules.
8265 * breakpoint.c (set_breakpoint_condition): Create an
8266 innermost_block_tracker.
8267 (watch_command_1): Likewise.
8268 * ada-lang.c (resolve): Add "tracker" parameter.
8269 (resolve_subexp): Likewise.
8270 * ada-exp.y (write_var_from_sym): Update.
8271
8272 2019-04-04 Tom Tromey <tom@tromey.com>
8273
8274 * type-stack.h: New file.
8275 * type-stack.c: New file.
8276 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8277 type-stack.h.
8278 (insert_into_type_stack, insert_type, push_type, push_type_int)
8279 (insert_type_address_space, pop_type, pop_type_int)
8280 (pop_typelist, pop_type_stack, append_type_stack)
8281 (push_type_stack, get_type_stack, push_typelist)
8282 (follow_type_instance_flags, follow_types): Don't declare.
8283 * parse.c (type_stack): Remove global.
8284 (parse_exp_in_context): Update.
8285 (insert_into_type_stack, insert_type, push_type, push_type_int)
8286 (insert_type_address_space, pop_type, pop_type_int)
8287 (pop_typelist, pop_type_stack, append_type_stack)
8288 (push_type_stack, get_type_stack, push_typelist)
8289 (follow_type_instance_flags, follow_types): Remove (moved to
8290 type-stack.c).
8291 * f-exp.y (type_stack): New global.
8292 Update rules.
8293 (push_kind_type, f_parse): Update.
8294 * d-exp.y (type_stack): New global.
8295 Update rules.
8296 (d_parse): Update.
8297 * c-exp.y (struct c_parse_state) <type_stack>: New member.
8298 Update rules.
8299 * Makefile.in (COMMON_SFILES): Add type-stack.c.
8300 (HFILES_NO_SRCDIR): Add type-stack.h.
8301
8302 2019-04-04 Tom Tromey <tom@tromey.com>
8303
8304 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8305 (rust_parser::convert_ast_to_expression, rust_parse)
8306 (rust_lex_test_completion, rust_lex_tests): Update.
8307 * parser-defs.h (struct expr_completion_state): New.
8308 (struct parser_state) <parser_state>: Add completion parameter.
8309 <mark_struct_expression, mark_completion_tag>: New methods.
8310 <parse_completion, m_completion_state>: New members.
8311 (prefixify_expression, null_post_parser): Update.
8312 (mark_struct_expression, mark_completion_tag): Don't declare.
8313 * parse.c (parse_completion, expout_last_struct)
8314 (expout_tag_completion_type, expout_completion_name): Remove
8315 globals.
8316 (parser_state::mark_struct_expression)
8317 (parser_state::mark_completion_tag): Now methods.
8318 (prefixify_expression): Add last_struct parameter.
8319 (prefixify_subexp): Likewise.
8320 (parse_exp_1): Update.
8321 (parse_exp_in_context): Add cstate parameter. Update.
8322 (parse_expression_for_completion): Create an
8323 expr_completion_state.
8324 (null_post_parser): Add "completion" parameter.
8325 * p-exp.y: Update rules.
8326 (yylex): Update.
8327 * language.h (struct language_defn) <la_post_parser>: Add
8328 "completing" parameter.
8329 * go-exp.y: Update rules.
8330 (lex_one_token): Update.
8331 * expression.h (parse_completion): Don't declare.
8332 * d-exp.y: Update rules.
8333 (lex_one_token): Update rules.
8334 * c-exp.y: Update rules.
8335 (lex_one_token): Update.
8336 * ada-lang.c (resolve): Add "parse_completion" parameter.
8337 (resolve_subexp): Likewise.
8338 (ada_resolve_function): Likewise.
8339
8340 2019-04-04 Tom Tromey <tom@tromey.com>
8341
8342 * parser-defs.h (struct parser_state) <start_arglist,
8343 end_arglist>: New methods.
8344 <arglist_len, m_funcall_chain>: New members.
8345 (arglist_len, start_arglist, end_arglist): Don't declare.
8346 * parse.c (arglist_len, funcall_chain): Remove global.
8347 (start_arglist, end_arglist): Remove functions.
8348 (parse_exp_in_context): Update.
8349 * p-exp.y: Update rules.
8350 * m2-exp.y: Update rules.
8351 * go-exp.y: Update rules.
8352 * f-exp.y: Update rules.
8353 * d-exp.y: Update rules.
8354 * c-exp.y: Update rules.
8355
8356 2019-04-04 Tom Tromey <tom@tromey.com>
8357
8358 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8359 lex_operator, push_back>: New methods.
8360 Update all rules.
8361 (rust_parser::lex_hex, lex_escape): Rename and update.
8362 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8363 (rust_parser::lex_operator): Rename and update.
8364 (rust_parser::lex_number, rustyylex, rustyyerror)
8365 (rust_lex_test_init, rust_lex_test_sequence)
8366 (rust_lex_test_push_back, rust_lex_tests): Update.
8367 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8368 parameter.
8369 <lexptr, prev_lexptr>: New members.
8370 (lexptr, prev_lexptr): Don't declare.
8371 * parse.c (lexptr, prev_lexptr): Remove globals.
8372 (parse_exp_in_context): Update.
8373 * p-exp.y (yylex, yyerror): Update.
8374 * m2-exp.y (parse_number, yylex, yyerror): Update.
8375 * go-exp.y (lex_one_token, yyerror): Update.
8376 * f-exp.y (match_string_literal, yylex, yyerror): Update.
8377 * d-exp.y (lex_one_token, yyerror): Update.
8378 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8379 (lex_one_token, yyerror): Update.
8380 * ada-lex.l (YY_INPUT): Update.
8381 (rewind_to_char): Update.
8382 * ada-exp.y (yyerror): Update.
8383
8384 2019-04-04 Tom Tromey <tom@tromey.com>
8385
8386 * rust-exp.y (rustyylex, rust_lex_tests): Update.
8387 * parser-defs.h (struct parser_state) <parser_state>: Add new
8388 parameter.
8389 <comma_terminates>: New member.
8390 (comma_terminates): Don't declare global.
8391 * parse.c (comma_terminates): Remove global.
8392 (parse_exp_in_context): Update.
8393 * p-exp.y (yylex): Update.
8394 * m2-exp.y (yylex): Update.
8395 * go-exp.y (lex_one_token): Update.
8396 * f-exp.y (yylex): Update.
8397 * d-exp.y (lex_one_token): Update.
8398 * c-exp.y (lex_one_token): Update.
8399 * ada-lex.l: Update.
8400
8401 2019-04-04 Tom Tromey <tom@tromey.com>
8402
8403 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8404 (rustyylex, rust_lex_test_init, rust_lex_test_one)
8405 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8406 * parser-defs.h (paren_depth): Don't declare.
8407 * parse.c (paren_depth): Remove global.
8408 (parse_exp_in_context): Update.
8409 * p-exp.y (paren_depth): New global.
8410 (pascal_parse): Initialize it.
8411 * m2-exp.y (paren_depth): New global.
8412 (m2_parse): Initialize it.
8413 * go-exp.y (paren_depth): New global.
8414 (go_parse): Initialize it.
8415 * f-exp.y (paren_depth): New global.
8416 (f_parse): Initialize it.
8417 * d-exp.y (paren_depth): New global.
8418 (d_parse): Initialize it.
8419 * c-exp.y (paren_depth): New global.
8420 (c_parse): Initialize it.
8421 * ada-lex.l (paren_depth): New global.
8422 (lexer_init): Initialize it.
8423
8424 2019-04-04 Tom Tromey <tom@tromey.com>
8425
8426 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8427 (rust_parser::convert_ast_to_type)
8428 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8429 * parser-defs.h (struct parser_state) <parser_state>: Add
8430 parameters. Initialize new members.
8431 <expression_context_block, expression_context_pc>: New members.
8432 * parse.c (expression_context_block, expression_context_pc):
8433 Remove globals.
8434 (parse_exp_in_context): Update.
8435 * p-exp.y: Update all rules.
8436 (yylex): Update.
8437 * m2-exp.y: Update all rules.
8438 (yylex): Update.
8439 * go-exp.y (yylex): Update.
8440 * f-exp.y (yylex): Update.
8441 * d-exp.y: Update all rules.
8442 (yylex): Update.
8443 * c-exp.y: Update all rules.
8444 (lex_one_token, classify_name, yylex, c_parse): Update.
8445 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8446
8447 2019-04-04 Tom Tromey <tom@tromey.com>
8448
8449 * gdbarch.h, gdbarch.c: Rebuild.
8450 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8451 * stap-probe.h:
8452 (struct stap_parse_info): Replace "parser_state" with
8453 "expr_builder".
8454 * parser-defs.h (struct expr_builder): Rename from "parser_state".
8455 (parser_state): New class.
8456 * parse.c (expr_builder): Rename.
8457 (expr_builder::release): Rename.
8458 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8459 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8460 (write_exp_elt_longcst, write_exp_elt_floatcst)
8461 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8462 (write_exp_string_vector, write_exp_bitstring)
8463 (write_exp_msymbol, mark_struct_expression)
8464 (write_dollar_variable)
8465 (insert_type_address_space, increase_expout_size): Replace
8466 "parser_state" with "expr_builder".
8467 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8468 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8469 "parser_state" with "expr_builder".
8470
8471 2019-04-04 Tom Tromey <tom@tromey.com>
8472
8473 * rust-exp.y: Replace "parse_language" with method call.
8474 * p-exp.y:
8475 (yylex): Replace "parse_language" with method call.
8476 * m2-exp.y:
8477 (yylex): Replace "parse_language" with method call.
8478 * go-exp.y (classify_name): Replace "parse_language" with method
8479 call.
8480 * f-exp.y (yylex): Replace "parse_language" with method call.
8481 * d-exp.y (lex_one_token): Replace "parse_language" with method
8482 call.
8483 * c-exp.y:
8484 (lex_one_token, classify_name, yylex): Replace "parse_language"
8485 with method call.
8486 * ada-exp.y (find_primitive_type, type_char)
8487 (type_system_address): Replace "parse_language" with method call.
8488
8489 2019-04-04 Tom Tromey <tom@tromey.com>
8490
8491 * rust-exp.y: Replace "parse_gdbarch" with method call.
8492 * parse.c (write_dollar_variable, insert_type_address_space):
8493 Replace "parse_gdbarch" with method call.
8494 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8495 call.
8496 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8497 call.
8498 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8499 "parse_gdbarch" with method call.
8500 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8501 with method call.
8502 * f-exp.y (parse_type, parse_f_type, yylex): Replace
8503 "parse_gdbarch" with method call.
8504 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8505 "parse_gdbarch" with method call.
8506 * c-exp.y (parse_type, parse_number, classify_name): Replace
8507 "parse_gdbarch" with method call.
8508 * ada-lex.l: Replace "parse_gdbarch" with method call.
8509 * ada-exp.y (parse_type, find_primitive_type, type_char)
8510 (type_system_address): Replace "parse_gdbarch" with method call.
8511
8512 2019-04-04 Tom Tromey <tom@tromey.com>
8513
8514 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8515 * stap-probe.c (stap_parse_argument): Update.
8516 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8517 initial_size parameter.
8518 * rust-exp.y (rust_lex_tests): Update.
8519 * parse.c (parser_state): Update.
8520 (parse_exp_in_context): Update.
8521 * parser-defs.h (struct parser_state) <parser_state>: Remove
8522 "initial_size" parameter.
8523
8524 2019-04-04 Tom Tromey <tom@tromey.com>
8525
8526 * parser-defs.h (increase_expout_size): Don't declare.
8527 * parse.c (increase_expout_size): Now static.
8528
8529 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
8530
8531 * gnu-nat.c (gnu_nat_target::wait): Fix
8532 target_waitstatus_to_string call.
8533
8534 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8535
8536 * eval.c (evaluate_subexp_standard): Handle internal functions
8537 during Fortran function call handling.
8538
8539 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8540
8541 * NEWS: Mention new internal functions.
8542 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8543 (read_base_type): Use dwarf2_init_complex_target_type.
8544 * value.c (creal_internal_fn): New function.
8545 (cimag_internal_fn): New function.
8546 (_initialize_values): Register new internal functions.
8547
8548 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8549
8550 * infrun.c (stop_all_threads): If debug_infrun, always
8551 trace the wait status after wait_one, using
8552 target_waitstatus_to_string and target_pid_to_str.
8553 (handle_inferior_event): Replace various trace of
8554 wait status kind by a single trace.
8555 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8556 wait status kind image by target_waitstatus_to_string.
8557 * target/waitstatus.c (target_waitstatus_to_string): Fix
8558 obsolete comment.
8559
8560 2019-04-01 Tom Tromey <tromey@adacore.com>
8561
8562 PR symtab/23331:
8563 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8564
8565 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
8566 Pedro Alves <palves@redhat.com>
8567
8568 * top.c (quit_force): Call 'finalize_values'.
8569 * value.c (finalize_values): New function.
8570 * value.h (finalize_values): Declare.
8571
8572 2019-03-30 Eli Zaretskii <eliz@gnu.org>
8573
8574 * NEWS: Announce $_gdb_major and $_gdb_minor.
8575
8576 * top.c (init_gdb_version_vars): New function.
8577 (gdb_init): Call init_gdb_version_vars.
8578
8579 2019-03-29 Tom Tromey <tromey@adacore.com>
8580
8581 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
8582 help text. Remove dead code.
8583
8584 2019-03-29 Keith Seitz <keiths@redhat.com>
8585
8586 From Siddhesh Poyarekar:
8587 * f-lang.h (f77_get_upperbound): Return LONGEST.
8588 (f77_get_lowerbound): Likewise.
8589 * f-typeprint.c (f_type_print_varspec_suffix): Expand
8590 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
8591 print them.
8592 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
8593 plongest to format print it.
8594 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8595 (f77_get_upperbound): Likewise.
8596 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8597 LOWER_BOUND to LONGEST.
8598 (f77_create_arrayprint_offset_tbl): Likewise.
8599
8600 2019-03-29 Keith Seitz <keiths@redhat.com>
8601
8602 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8603 %s/pulongest for TYPE_LENGTH instead of %d in format
8604 strings.
8605 * ada-typerint.c (ada_print_type): Likewise.
8606 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8607 * compile/compile-c-support.c (generate_register_struct): Likewise.
8608 * gdbtypes.c (recursive_dump_type): Likewise.
8609 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8610 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
8611 instead of %d in format strings.
8612 * riscv-tdep.c (riscv_type_alignment): Cast second argument
8613 to std::min to ULONGEST.
8614 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8615 instead of %d in format strings.
8616 * tracepoint.c (info_scope_command): Likewise.
8617 * typeprint.c (print_offset_data::update)
8618 (print_offset_data::finish): Likewise.
8619 * xtensa-tdep.c (xtensa_store_return_value)
8620 (xtensa_push_dummy_call): Likewise.
8621
8622 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
8623
8624 * windows-nat.c (display_selector): Fixed format specifications
8625 for 64-bit Cygwin.
8626
8627 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8628
8629 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8630
8631 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
8632
8633 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8634 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8635 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8636 (nios2_linux_init_abi): Install it.
8637
8638 2019-03-28 Alan Hayward <alan.hayward@arm.com>
8639
8640 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8641
8642 2019-03-28 Alan Hayward <alan.hayward@arm.com>
8643
8644 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8645
8646 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8647 Tom Tromey <tromey@adacore.com>
8648
8649 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8650
8651 2019-03-26 Joel Brobecker <brobecker@adacore.com>
8652
8653 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8654 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8655 method to compute the bounds of range types. Also print "[evaluated]"
8656 if the bounds' values come from a dynamic evaluation.
8657
8658 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
8659
8660 * cp-valprint.c (cp_print_value_fields): Don't print trailing
8661 whitespace when pretty printing is on.
8662
8663 2019-03-26 Alan Hayward <alan.hayward@arm.com>
8664
8665 * ppc-linux-nat.c: Add include.
8666
8667 2019-03-26 Alan Hayward <alan.hayward@arm.com>
8668
8669 * NEWS: Mention AArch64 Pointer Authentication.
8670
8671 2019-03-26 Alan Hayward <alan.hayward@arm.com>
8672
8673 * arm-linux-nat.c: Add include.
8674
8675 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
8676
8677 * source-cache.c (source_cache::get_source_lines): Re-read
8678 fullname after calling open_source_file.
8679
8680 2019-03-25 John Baldwin <jhb@FreeBSD.org>
8681
8682 * NEWS: Mention TLS support for FreeBSD.
8683
8684 2019-03-25 Tom Tromey <tromey@adacore.com>
8685
8686 * minsyms.c (BUNCH_SIZE): Update comment.
8687 (~minimal_symbol_reader): Remove old comment.
8688 (compact_minimal_symbols): Update comment.
8689 (minimal_symbol_reader::install): Remove old comment. Update
8690 other comments.
8691
8692 2019-03-25 Alan Hayward <alan.hayward@arm.com>
8693
8694 * s390-linux-nat.c: Add include.
8695
8696 2019-03-25 Alan Hayward <alan.hayward@arm.com>
8697
8698 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8699 Call linux_get_hwcap.
8700 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8701 Likewise.
8702 (aarch64_linux_get_hwcap): Remove function.
8703 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8704 declaration.
8705 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8706 linux_get_hwcap.
8707 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8708 * linux-tdep.c (linux_get_hwcap): Add function.
8709 (linux_get_hwcap2): Likewise.
8710 * linux-tdep.h (linux_get_hwcap): Add declaration.
8711 (linux_get_hwcap2): Likewise.
8712 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8713 (ppc_linux_get_hwcap2): Likewise.
8714 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8715 linux_get_hwcap.
8716 (ppc_linux_nat_target::insert_watchpoint): Likewise.
8717 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8718 (ppc_linux_nat_target::read_description): Likewise.
8719 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8720 * s390-linux-nat.c: Likewise.
8721 * s390-linux-tdep.c (s390_core_read_description): Likewise.
8722
8723 2019-03-24 Tom Tromey <tom@tromey.com>
8724
8725 * ada-lang.c (standard_lookup): Simplify initialization.
8726 (ada_lookup_symbol_nonlocal): Simplify return.
8727 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8728 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8729 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8730 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8731 initialization.
8732 * solib.c (solib_global_lookup): Simplify.
8733 * symtab.c (null_block_symbol): Remove.
8734 (symbol_cache_lookup): Simplify returns.
8735 (lookup_language_this): Simplify returns.
8736 (lookup_symbol_aux): Simplify return.
8737 (lookup_local_symbol): Simplify returns.
8738 (lookup_global_symbol_from_objfile): Simplify return.
8739 (lookup_symbol_in_objfile_symtabs)
8740 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8741 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8742 (lookup_static_symbol, lookup_global_symbol): Simplify return.
8743 * cp-namespace.c (cp_lookup_bare_symbol)
8744 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8745 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8746 (cp_lookup_nested_symbol): Don't use null_block_symbol.
8747 (cp_lookup_symbol_via_imports): Simplify initialization.
8748 (find_symbol_in_baseclass): Likewise.
8749 * symtab.h (null_block_symbol): Remove.
8750 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8751 (d_lookup_nested_symbol, d_lookup_symbol_imports)
8752 (d_lookup_symbol_module): Likewise.
8753 (find_symbol_in_baseclass): Simplify initialization.
8754
8755 2019-03-24 Tom Tromey <tom@tromey.com>
8756
8757 * expression.h: Don't include symtab.h.
8758 (struct block): Forward declare.
8759
8760 2019-03-24 Tom Tromey <tom@tromey.com>
8761
8762 * c-exp.y (typebase): Remove casts.
8763 * gdbtypes.c (lookup_unsigned_typename, )
8764 (lookup_signed_typename): Remove cast.
8765 * eval.c (parse_to_comma_and_eval): Remove cast.
8766 * parse.c (write_dollar_variable): Remove cast.
8767 * block.h (struct block) <superblock>: Now const.
8768 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8769 * psymtab.c (psym_map_matching_symbols): Make "block" const.
8770 (map_block): Make "block" const.
8771 * symfile.h (struct quick_symbol_functions)
8772 <map_matching_symbols>: Constify block argument to "callback".
8773 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8774 const.
8775 (find_pc_sect_compunit_symtab): Make "b" const.
8776 (find_symbol_at_address): Likewise.
8777 (search_symbols): Likewise.
8778 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8779 (dw2_debug_names_lookup_symbol): Likewise.
8780 (dw2_map_matching_symbols): Update.
8781 * p-valprint.c (pascal_val_print): Remove "block".
8782 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8783 (aux_add_nonlocal_symbols): Make "block" const.
8784 (resolve_subexp): Remove cast.
8785 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8786 const.
8787 (iterate_over_file_blocks): Likewise.
8788 * f-exp.y (%union) <bval>: Remove.
8789 * coffread.c (patch_opaque_types): Make "b" const.
8790 * spu-tdep.c (spu_catch_start): Make "block" const.
8791 * c-valprint.c (print_unpacked_pointer): Remove "block".
8792 * symmisc.c (dump_symtab_1): Make "b" const.
8793 (block_depth): Make "block" const.
8794 * d-exp.y (%union) <bval>: Remove.
8795 * cp-support.h (cp_lookup_rtti_type): Update.
8796 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8797 * psymtab.c (psym_lookup_symbol): Make "block" const.
8798 (maintenance_check_psymtabs): Make "b" const.
8799 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8800 (enumerate_locals, enumerate_args): Update.
8801 * python/py-symtab.c (stpy_global_block): Make "block" const.
8802 (stpy_static_block): Likewise.
8803 * inline-frame.c (block_starting_point_at): Make "new_block"
8804 const.
8805 * block.c (find_block_in_blockvector): Make return type const.
8806 (blockvector_for_pc_sect): Make "b" const.
8807 (find_block_in_blockvector): Make "b" const.
8808
8809 2019-03-23 Tom Tromey <tom@tromey.com>
8810
8811 * varobj.c (varobj_create): Update.
8812 * symfile.c (clear_symtab_users): Don't reset innermost_block.
8813 * printcmd.c (display_command, do_one_display): Don't reset
8814 innermost_block.
8815 * parser-defs.h (enum innermost_block_tracker_type): Move to
8816 expression.h.
8817 (innermost_block): Update comment.
8818 * parse.c (parse_exp_1): Add tracker_types parameter.
8819 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
8820 tracker_types parameter. Reset innermost_block.
8821 (parse_exp_in_context): Remove.
8822 (parse_expression_for_completion): Update.
8823 * objfiles.c (~objfile): Don't reset expression_context_block or
8824 innermost_block.
8825 * expression.h (enum innermost_block_tracker_type): Move from
8826 parser-defs.h.
8827 (parse_exp_1): Add tracker_types parameter.
8828 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8829 reset innermost_block.
8830
8831 2019-03-23 Tom Tromey <tom@tromey.com>
8832
8833 * objfiles.h: Include bcache.h.
8834
8835 2019-03-23 Tom Tromey <tom@tromey.com>
8836
8837 * linespec.c (get_current_search_block): Use
8838 scoped_restore_current_language.
8839 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8840
8841 2019-03-22 Alan Hayward <alan.hayward@arm.com>
8842 Jiong Wang <jiong.wang@arm.com>
8843
8844 * aarch64-linux-tdep.c
8845 (aarch64_linux_iterate_over_regset_sections): Check for pauth
8846 section.
8847 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8848
8849 2019-03-22 Alan Hayward <alan.hayward@arm.com>
8850 Jiong Wang <jiong.wang@arm.com>
8851
8852 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8853 instructions.
8854 (aarch64_analyze_prologue_test): Add PACIASP test.
8855 (aarch64_prologue_prev_register): Unmask PC value.
8856
8857 2019-03-22 Alan Hayward <alan.hayward@arm.com>
8858 Jiong Wang <jiong.wang@arm.com>
8859
8860 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8861 (aarch64_dwarf2_prev_register): Unmask PC value.
8862 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8863 (aarch64_execute_dwarf_cfa_vendor_op): Check for
8864 DW_CFA_AARCH64_negate_ra_state.
8865 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8866
8867 2019-03-22 Alan Hayward <alan.hayward@arm.com>
8868 Jiong Wang <jiong.wang@arm.com>
8869
8870 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8871 registers.
8872 (aarch64_pseudo_register_name): Likewise.
8873 (aarch64_pseudo_register_type): Likewise.
8874 (aarch64_pseudo_register_reggroup_p): Likewise.
8875 (aarch64_gdbarch_init): Add pauth registers.
8876 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8877 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8878 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8879 (struct gdbarch_tdep): Add regnum for ra_state.
8880
8881 2019-03-22 Alan Hayward <alan.hayward@arm.com>
8882 Jiong Wang <jiong.wang@arm.com>
8883
8884 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8885
8886 2019-03-22 Alan Hayward <alan.hayward@arm.com>
8887 Jiong Wang <jiong.wang@arm.com>
8888
8889 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8890 function.
8891 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8892 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8893 (aarch64_gdbarch_init): Add puth registers.
8894 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8895 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8896 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8897
8898 2019-03-22 Alan Hayward <alan.hayward@arm.com>
8899 Jiong Wang <jiong.wang@arm.com>
8900
8901 * aarch64-linux-nat.c
8902 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8903 * aarch64-linux-tdep.c
8904 (aarch64_linux_core_read_description): Likewise.
8905 (aarch64_linux_get_hwcap): New function.
8906 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8907 (aarch64_linux_get_hwcap): New declaration.
8908
8909 2019-03-22 Alan Hayward <alan.hayward@arm.com>
8910 Jiong Wang <jiong.wang@arm.com>
8911
8912 * aarch64-linux-nat.c
8913 (aarch64_linux_nat_target::read_description): Add pauth param.
8914 * aarch64-linux-tdep.c
8915 (aarch64_linux_core_read_description): Likewise.
8916 * aarch64-tdep.c (struct target_desc): Add in pauth.
8917 (aarch64_read_description): Add pauth param.
8918 (aarch64_gdbarch_init): Likewise.
8919 * aarch64-tdep.h (aarch64_read_description): Likewise.
8920 * arch/aarch64.c (aarch64_create_target_description): Likewise.
8921 * arch/aarch64.h (aarch64_create_target_description): Likewise.
8922 * features/Makefile: Add new files.
8923 * features/aarch64-pauth.c: New file.
8924 * features/aarch64-pauth.xml: New file.
8925
8926 2019-03-20 Tom Tromey <tromey@adacore.com>
8927
8928 * infrun.c (handle_inferior_event): Rename from
8929 handle_inferior_event_1. Create a scoped_value_mark.
8930 (handle_inferior_event): Remove.
8931
8932 2019-03-19 Tom Tromey <tromey@adacore.com>
8933
8934 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8935 * infrun.h (print_stop_event): Add "displays" parameter.
8936 * infrun.c (print_stop_event): Add "displays" parameter.
8937
8938 2019-03-19 Pedro Alves <palves@redhat.com>
8939
8940 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8941 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
8942 to -1. Fix TABs vs spaces.
8943 (tui_ui_out::tui_ui_out): Don't initialize fields here.
8944 * tui/tui-out.h (tui_ui_out) Add intro comments.
8945 <m_line, m_start_of_line>: In-class initialize, and add describing
8946 comment.
8947
8948 2019-03-18 Alan Hayward <alan.hayward@arm.com>
8949
8950 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8951 variable names.
8952 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8953
8954 2019-03-18 Pedro Alves <palves@redhat.com>
8955 Eli Zaretskii <eliz@gnu.org>
8956
8957 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8958 m_line and m_start_of_line.
8959
8960 2019-03-18 Eli Zaretskii <eliz@gnu.org>
8961
8962 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8963 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8964 it returns a newline. This fixes a regression in TU mode, whereby
8965 the next line is output on the same screen line as the user input.
8966
8967 2019-03-18 Tom Tromey <tromey@adacore.com>
8968
8969 * minsyms.c (minimal_symbol_reader::install): Remove call to
8970 obstack_blank.
8971
8972 2019-03-18 Pedro Alves <palves@redhat.com>
8973
8974 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8975 New globals.
8976 (apply_style): New, factored out from ...
8977 (apply_ansi_escape): ... this. Handle reverse video mode.
8978 (tui_set_reverse_mode): New function.
8979 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8980 * tui/tui-winsource.c (tui_show_source_line): Use
8981 tui_set_reverse_mode instead of setting A_STANDOUT.
8982 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8983 New setter methods.
8984
8985 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
8986
8987 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8988 Handle tabs.
8989
8990 2019-03-18 Tom Tromey <tromey@adacore.com>
8991
8992 * ada-lang.c (empty_array): Add "high" parameter.
8993 (ada_evaluate_subexp): Update.
8994
8995 2019-03-17 Sergei Trofimovich <siarheit@google.com>
8996
8997 * unittests/string_view-selftests.c: Define
8998 _initialize_string_view_selftests unconditionally.
8999
9000 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
9001
9002 PR gdb/24350
9003 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9004
9005 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
9006
9007 PR gdb/24351
9008 * windows-nat.c (display_selector): Fix format specifiers.
9009
9010 2019-03-17 Eli Zaretskii <eliz@gnu.org>
9011
9012 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9013 tui_refill_source_window instead of tui_refresh_win, to update the
9014 current execution line. This fixes redisplay of the current line
9015 when stepping through the code with "next" or "step".
9016
9017 2019-03-16 Eli Zaretskii <eliz@gnu.org>
9018
9019 * source-cache.c (source_cache::get_source_lines): Call
9020 find_source_lines to initialize s->nlines. This fixes vertical
9021 scrolling of TUI source window when the DOWN arrow is pressed.
9022
9023 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9024
9025 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9026 linux-thread-db.c (_initialize_thread_db): Likewise.
9027
9028 2019-03-16 Eli Zaretskii <eliz@gnu.org>
9029
9030 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9031 wclrtoeol in tui_show_source_line". This reverts changes made in
9032 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9033
9034 2019-03-15 Tom Tromey <tom@tromey.com>
9035
9036 * symtab.h (struct minimal_symbol): Derive from
9037 general_symbol_info.
9038 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9039 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9040 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9041 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9042 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9043 (MSYMBOL_SEARCH_NAME): Update.
9044 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9045 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9046 * minsyms.c (minimal_symbol_reader::record_full): Update.
9047
9048 2019-03-15 Tom Tromey <tom@tromey.com>
9049
9050 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9051
9052 2019-03-15 Tom Tromey <tom@tromey.com>
9053
9054 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9055 unique_xmalloc_ptr.
9056 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9057 Update.
9058 * minsyms.c (lookup_minimal_symbol_by_pc_section)
9059 (build_minimal_symbol_hash_tables)
9060 (minimal_symbol_reader::install): Update.
9061
9062 2019-03-15 Tom Tromey <tom@tromey.com>
9063
9064 * symtab.c (create_demangled_names_hash): Update.
9065 (symbol_set_names): Update.
9066 * objfiles.h (struct objfile_per_bfd_storage)
9067 <demangled_names_hash>: Now an htab_up.
9068 * objfiles.c (objfile_per_bfd_storage): Simplify.
9069
9070 2019-03-15 Tom Tromey <tom@tromey.com>
9071
9072 * objfiles.h (struct objfile_per_bfd_storage): Declare
9073 destructor.
9074 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9075 New.
9076 (get_objfile_bfd_data): Use new. Don't initialize
9077 language_of_main.
9078 (free_objfile_per_bfd_storage): Remove.
9079 (objfile_bfd_data_free, objfile::~objfile): Use delete.
9080
9081 2019-03-15 Tom Tromey <tom@tromey.com>
9082
9083 * symfile.c (reread_symbols): Update.
9084 * objfiles.c (objfile::objfile): Update.
9085 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9086 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9087 comment.
9088 (minimal_symbol_reader::install): Update.
9089 (terminate_minimal_symbol_table): Remove.
9090 * jit.c (jit_object_close_impl): Update.
9091
9092 2019-03-15 Tom Tromey <tom@tromey.com>
9093
9094 * minsyms.c (minimal_symbol_reader::record_full): Remove some
9095 initializations.
9096
9097 2019-03-15 Tom Tromey <tom@tromey.com>
9098
9099 * objfiles.h (struct objfile_per_bfd_storage)
9100 <demangled_hash_languages>: Now a bitset.
9101 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9102 (lookup_minimal_symbol): Update.
9103
9104 2019-03-15 Tom Tromey <tom@tromey.com>
9105
9106 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9107 Don't return the symbol.
9108 * coffread.c (record_minimal_symbol): Use record_full.
9109
9110 2019-03-14 Eli Zaretskii <eliz@gnu.org>
9111
9112 The MS-Windows port of ncurses fails to switch to a color pair if
9113 one or both of the colors are the implicit default colors. This
9114 change records the default colors when TUI is initialized, and
9115 then specifies them explicitly when a color pair uses the default
9116 colors. This allows color styling in TUI mode on MS-Windows.
9117
9118 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
9119 ncurses_norm_attr.
9120 (tui_initialize_io) [__MINGW32__]: Record the default terminal
9121 colors in ncurses_norm_attr.
9122 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9123 "none", replace it with the default color recorded in
9124 ncurses_norm_attr.
9125
9126 2019-03-14 Tom Tromey <tromey@adacore.com>
9127
9128 * source-cache.h (class source_cache) <get_source_lines>: Return
9129 std::string.
9130 * source-cache.c (source_cache::extract_lines): Handle case where
9131 first_pos==npos. Return std::string.
9132 (source_cache::get_source_lines): Update.
9133
9134 2019-03-14 Tom Tromey <tromey@adacore.com>
9135
9136 * NEWS: Add item for "style sources" commands.
9137 * source-cache.c (source_cache::get_source_lines): Check
9138 source_styling.
9139 * cli/cli-style.c (source_styling): New global.
9140 (_initialize_cli_style): Add "style sources" commands.
9141 (show_style_sources): New function.
9142 * cli/cli-style.h (source_styling): Declare.
9143
9144 2019-03-14 Pedro Alves <palves@redhat.com>
9145 Tom Tromey <tromey@adacore.com>
9146
9147 * tui/tui-winsource.h (tui_refill_source_window): Declare.
9148 * tui/tui-winsource.c (tui_refill_source_window): New function,
9149 from...
9150 (tui_horizontal_source_scroll): ... here. Move some logic.
9151 * cli/cli-style.c (set_style_enabled): Notify new observable.
9152 * tui/tui-hooks.c (tui_redisplay_source): New function.
9153 (tui_attach_detach_observers): Attach or detach
9154 tui_redisplay_source.
9155 * observable.h (source_styling_changed): New observable.
9156 * observable.c: Define source_styling_changed observable.
9157
9158 2019-03-13 Tom Tromey <tromey@adacore.com>
9159
9160 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9161 (i386_gnu_nat_target::store_registers): Update.
9162 * target-debug.h (target_debug_print_std_string): New macro.
9163 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9164 * windows-tdep.c (display_one_tib): Update.
9165 * tui/tui-stack.c (tui_make_status_line): Update.
9166 * top.c (print_inferior_quit_action): Update.
9167 * thread.c (thr_try_catch_cmd): Update.
9168 (add_thread_with_info): Update.
9169 (thread_target_id_str): Update.
9170 (thr_try_catch_cmd): Update.
9171 (thread_command): Update.
9172 (thread_find_command): Update.
9173 * record-btrace.c (record_btrace_target::info_record)
9174 (record_btrace_resume_thread, record_btrace_target::resume)
9175 (record_btrace_cancel_resume, record_btrace_step_thread)
9176 (record_btrace_target::wait, record_btrace_target::wait)
9177 (record_btrace_target::wait, record_btrace_target::stop): Update.
9178 * progspace.c (print_program_space): Update.
9179 * process-stratum-target.c
9180 (process_stratum_target::thread_address_space): Update.
9181 * linux-fork.c (linux_fork_mourn_inferior)
9182 (detach_checkpoint_command, info_checkpoints_command)
9183 (linux_fork_context): Update.
9184 (linux_fork_detach): Update.
9185 (class scoped_switch_fork_info): Update.
9186 (delete_checkpoint_command): Update.
9187 * infrun.c (follow_fork_inferior): Update.
9188 (follow_fork_inferior): Update.
9189 (proceed_after_vfork_done): Update.
9190 (handle_vfork_child_exec_or_exit): Update.
9191 (follow_exec): Update.
9192 (displaced_step_prepare_throw): Update.
9193 (displaced_step_restore): Update.
9194 (start_step_over): Update.
9195 (resume_1): Update.
9196 (clear_proceed_status_thread): Update.
9197 (proceed): Update.
9198 (print_target_wait_results): Update.
9199 (do_target_wait): Update.
9200 (context_switch): Update.
9201 (stop_all_threads): Update.
9202 (restart_threads): Update.
9203 (finish_step_over): Update.
9204 (handle_signal_stop): Update.
9205 (switch_back_to_stepped_thread): Update.
9206 (keep_going_pass_signal): Update.
9207 (print_exited_reason): Update.
9208 (normal_stop): Update.
9209 * inferior.c (inferior_pid_to_str): Change return type.
9210 (print_selected_inferior): Update.
9211 (add_inferior): Update.
9212 (detach_inferior): Update.
9213 * dummy-frame.c (fprint_dummy_frames): Update.
9214 * dcache.c (dcache_info_1): Update.
9215 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9216 (btrace_fetch, btrace_clear): Update.
9217 * linux-tdep.c (linux_core_pid_to_str): Change return type.
9218 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9219 type.
9220 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9221 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9222 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9223 * gdbarch.c, gdbarch.h: Rebuild.
9224 * gdbarch.sh (core_pid_to_str): Change return type.
9225 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9226 return type.
9227 (windows_nat_target::pid_to_str): Change return type.
9228 (windows_delete_thread): Update.
9229 (windows_nat_target::attach): Update.
9230 (windows_nat_target::files_info): Update.
9231 * target-delegates.c: Rebuild.
9232 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9233 return type.
9234 (sol_thread_target::pid_to_str): Change return type.
9235 * remote.c (class remote_target) <pid_to_str>: Change return
9236 type.
9237 (remote_target::pid_to_str): Change return type.
9238 (extended_remote_target::attach, remote_target::remote_stop_ns)
9239 (remote_target::remote_notif_remove_queued_reply)
9240 (remote_target::push_stop_reply, remote_target::disable_btrace):
9241 Update.
9242 (extended_remote_target::attach): Update.
9243 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9244 type.
9245 (gdbsim_target::pid_to_str): Change return type.
9246 * ravenscar-thread.c (struct ravenscar_thread_target)
9247 <pid_to_str>: Change return type.
9248 (ravenscar_thread_target::pid_to_str): Change return type.
9249 * procfs.c (class procfs_target) <pid_to_str>: Change return
9250 type.
9251 (procfs_target::pid_to_str): Change return type.
9252 (procfs_target::attach): Update.
9253 (procfs_target::detach): Update.
9254 (procfs_target::fetch_registers): Update.
9255 (procfs_target::store_registers): Update.
9256 (procfs_target::wait): Update.
9257 (procfs_target::files_info): Update.
9258 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9259 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9260 return type.
9261 (nto_procfs_target::pid_to_str): Change return type.
9262 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9263 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9264 return type.
9265 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9266 (exit_lwp): Update.
9267 (attach_proc_task_lwp_callback, get_detach_signal)
9268 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9269 (linux_nat_target::resume, wait_lwp, stop_callback)
9270 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9271 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9272 (linux_nat_wait_1, resume_stopped_resumed_lwps)
9273 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9274 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9275 type.
9276 (inf_ptrace_target::attach): Update.
9277 (inf_ptrace_target::files_info): Update.
9278 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9279 type.
9280 (go32_nat_target::pid_to_str): Change return type.
9281 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9282 (gnu_nat_target::wait): Update.
9283 (gnu_nat_target::wait): Update.
9284 (gnu_nat_target::resume): Update.
9285 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9286 (fbsd_nat_target::wait): Update.
9287 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9288 type.
9289 (darwin_nat_target::attach): Update.
9290 * corelow.c (class core_target) <pid_to_str>: Change return type.
9291 (core_target::pid_to_str): Change return type.
9292 * target.c (normal_pid_to_str): Change return type.
9293 (default_pid_to_str): Likewise.
9294 (target_pid_to_str): Change return type.
9295 (target_translate_tls_address): Update.
9296 (target_announce_detach): Update.
9297 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9298 return type.
9299 (bsd_uthread_target::pid_to_str): Change return type.
9300 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9301 type.
9302 (bsd_kvm_target::pid_to_str): Change return type.
9303 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9304 return type.
9305 (aix_thread_target::pid_to_str): Change return type.
9306 * target.h (struct target_ops) <pid_to_str>: Change return type.
9307 (target_pid_to_str, normal_pid_to_str): Likewise.
9308 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9309 type.
9310 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9311 type.
9312 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9313 return type.
9314 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9315 type.
9316 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9317 type.
9318 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9319 return type.
9320
9321 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
9322
9323 * NEWS: Mention that the new default MI version is 3. Mention
9324 changes to the output of commands and events that deal with
9325 multi-location breakpoints.
9326 * breakpoint.c: Include "mi/mi-out.h".
9327 (print_one_breakpoint): Change output syntax if using MI version
9328 >= 3.
9329 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9330 New.
9331 (mi_multi_location_breakpoint_output_fixed): New.
9332 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9333 (mi_cmd_fix_multi_location_breakpoint_output): New.
9334 (mi_multi_location_breakpoint_output_fixed): New.
9335 * mi/mi-cmds.c (mi_cmds): Register command
9336 -fix-multi-location-breakpoint-output.
9337 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9338 interpreter "mi".
9339
9340 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
9341
9342 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9343 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9344 instantiate mi_ui_out based on interpreter name.
9345 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9346 * mi/mi-main.c (mi_load_progress): Likewise.
9347
9348 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9349
9350 * NEWS: Combine separate "New targets" sections for 8.3.
9351
9352 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9353
9354 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9355 (ppcfbsd_init_abi): Install gdbarch
9356 "fetch_tls_load_module_address" and "get_thread_local_address"
9357 methods.
9358
9359 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9360
9361 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9362 (riscv_fbsd_init_abi): Install gdbarch
9363 "fetch_tls_load_module_address" and "get_thread_local_address"
9364 methods.
9365
9366 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9367
9368 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9369 (i386fbsd_init_abi): Install gdbarch
9370 "fetch_tls_load_module_address" and "get_thread_local_address"
9371 methods.
9372
9373 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9374
9375 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9376 (amd64fbsd_init_abi): Install gdbarch
9377 "fetch_tls_load_module_address" and "get_thread_local_address"
9378 methods.
9379
9380 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9381
9382 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9383 (struct fbsd_pspace_data): New type.
9384 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9385 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9386 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9387 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9388 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9389
9390 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9391
9392 * gdbtypes.c (lookup_struct_elt): New function.
9393 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9394 * gdbtypes.h (struct struct_elt): New type.
9395 (lookup_struct_elt): New prototype.
9396
9397 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9398
9399 * gdbtypes.c (lookup_struct_elt_type): Update comment and
9400 remove disabled code block.
9401
9402 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9403
9404 * gdbarch.sh (get_thread_local_address): New method.
9405 * gdbarch.h, gdbarch.c: Regenerate.
9406 * target.c (target_translate_tls_address): Use
9407 gdbarch_get_thread_local_address if present instead of
9408 target::get_thread_local_address.
9409
9410 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9411
9412 * target.h (target::get_thread_local_address): Update comment.
9413
9414 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9415
9416 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9417 objfile->separate_debug_objfile_backlink if not NULL.
9418
9419 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9420
9421 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9422 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9423 (amd64bsd_store_inferior_registers): Likewise.
9424 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9425 Enable segment base registers.
9426 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9427 PT_GETFSBASE and PT_GETGSBASE.
9428 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9429 PT_SETGSBASE.
9430 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9431 segment base registers.
9432 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9433
9434 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9435
9436 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9437 Update calls to i386_target_description to add 'segments'
9438 parameter.
9439 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
9440 add segment base registers.
9441 * arch/i386.c (i386_create_target_description): Add 'segments'
9442 parameter to enable segment base registers.
9443 * arch/i386.h (i386_create_target_description): Likewise.
9444 * features/i386/32bit-segments.xml: New file.
9445 * features/i386/32bit-segments.c: Generate.
9446 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9447 call to i386_target_description to add 'segments' parameter.
9448 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9449 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9450 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9451 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9452 if feature is present.
9453 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9454 Add 'segments' parameter to call to i386_target_description.
9455 (i386_target_description): Add 'segments' parameter to enable
9456 segment base registers.
9457 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9458 to call to i386_target_description.
9459 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9460 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9461 Define I386_NUM_REGS.
9462 (i386_target_description): Add 'segments' parameter to enable
9463 segment base registers.
9464
9465 2019-03-12 Eli Zaretskii <eliz@gnu.org>
9466
9467 PR/24325
9468 * source-cache.c: #undef open and close, to avoid unresolved
9469 externals during linking.
9470
9471 2019-03-12 Tom Tromey <tromey@adacore.com>
9472
9473 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9474 const. Add initializers.
9475 (_initialize_remote): Don't initialize ptid globals.
9476
9477 2019-03-12 Pedro Alves <palves@redhat.com>
9478
9479 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9480
9481 2019-03-12 Pedro Alves <palves@redhat.com>
9482
9483 * cp-name-parser.y (main): Remove unused 'len' variable.
9484
9485 2019-03-12 Tom Tromey <tromey@adacore.com>
9486
9487 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9488 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9489
9490 2019-03-12 Tom Tromey <tromey@adacore.com>
9491
9492 * linux-nat.c (iterate_over_lwps): Update.
9493 (stop_callback): Remove parameter.
9494 (stop_wait_callback, detach_callback, resume_set_callback)
9495 (select_singlestep_lwp_callback, set_ignore_sigint)
9496 (status_callback, resumed_callback, resume_clear_callback)
9497 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9498 data parameter.
9499 (linux_nat_target::detach, linux_nat_target::resume)
9500 (linux_stop_and_wait_all_lwps, select_event_lwp)
9501 (linux_nat_filter_event, linux_nat_wait_1)
9502 (linux_nat_target::kill, linux_nat_target::stop)
9503 (linux_nat_target::stop): Update.
9504 (linux_nat_resume_callback): Change type.
9505 (resume_stopped_resumed_lwps, count_events_callback)
9506 (select_event_lwp_callback): Likewise.
9507 (linux_stop_lwp, linux_nat_stop_lwp): Update.
9508 * arm-linux-nat.c (struct update_registers_data): Remove.
9509 (update_registers_callback): Change type.
9510 (arm_linux_insert_hw_breakpoint1): Update.
9511 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9512 parameter.
9513 (x86_linux_dr_set_addr): Update.
9514 (x86_linux_dr_set_control): Update.
9515 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9516 (iterate_over_lwps): Use gdb::function_view.
9517 * nat/aarch64-linux-hw-point.c (struct
9518 aarch64_dr_update_callback_param): Remove.
9519 (debug_reg_change_callback): Change type.
9520 (aarch64_notify_debug_reg_change): Update.
9521 * s390-linux-nat.c (s390_refresh_per_info): Update.
9522
9523 2019-03-11 Tom Tromey <tromey@adacore.com>
9524
9525 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9526 redundant assignment to "this_cu".
9527
9528 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9529
9530 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9531
9532 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9533
9534 * gdbtypes.c (rank_one_type_parm_set): New function extracted
9535 from...
9536 (rank_one_type): ... this.
9537
9538 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9539
9540 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9541 from...
9542 (rank_one_type): ... this.
9543
9544 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9545
9546 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9547 from...
9548 (rank_one_type): ... this.
9549
9550 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9551
9552 * gdbtypes.c (rank_one_type_parm_float): New function extracted
9553 from...
9554 (rank_one_type): ... this.
9555
9556 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9557
9558 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9559 from...
9560 (rank_one_type): ... this.
9561
9562 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9563
9564 * gdbtypes.c (rank_one_type_parm_range): New function extracted
9565 from...
9566 (rank_one_type): ... this.
9567
9568 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9569
9570 * gdbtypes.c (rank_one_type_parm_char): New function extracted
9571 from...
9572 (rank_one_type): ... this.
9573
9574 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9575
9576 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9577 from...
9578 (rank_one_type): ... this.
9579
9580 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9581
9582 * gdbtypes.c (rank_one_type_parm_int): New function extracted
9583 from...
9584 (rank_one_type): ... this.
9585
9586 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9587
9588 * gdbtypes.c (rank_one_type_parm_func): New function extracted
9589 from...
9590 (rank_one_type): ... this.
9591
9592 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9593
9594 * gdbtypes.c (rank_one_type_parm_array): New function extracted
9595 from...
9596 (rank_one_type): ... this.
9597
9598 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9599
9600 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9601 from...
9602 (rank_one_type): ... this.
9603
9604 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9605
9606 * inferior.c (initialize_inferiors): Ensure 'help set/show print
9607 inferior-events' shows the example events.
9608
9609 2019-03-08 Eli Zaretskii <eliz@gnu.org>
9610
9611 Support styling on native MS-Windows console
9612
9613 PR/24315
9614 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9615 on MS-Windows if $TERM is not defined.
9616
9617 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9618
9619 * posix-hdep.c (gdb_console_fputs):
9620 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9621 functions.
9622 * ui-file.h (gdb_console_fputs): Add prototype.
9623
9624 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9625 back to fputs only if the former returns zero.
9626
9627 2019-03-07 Tom Tromey <tom@tromey.com>
9628
9629 * symmisc.c (print_symbol_bcache_statistics): Update.
9630 (print_objfile_statistics): Update.
9631 * symfile.c (allocate_symtab): Update.
9632 * stabsread.c: Don't include bcache.h.
9633 * psymtab.h (struct psymbol_bcache): Don't declare.
9634 (class psymtab_storage) <psymbol_cache>: Now a bcache.
9635 (psymbol_bcache_init, psymbol_bcache_free)
9636 (psymbol_bcache_get_bcache): Don't declare.
9637 * psymtab.c (struct psymbol_bcache): Remove.
9638 (psymtab_storage::psymtab_storage): Update.
9639 (psymtab_storage::~psymtab_storage): Update.
9640 (psymbol_bcache_init, psymbol_bcache_free)
9641 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9642 (add_psymbol_to_bcache): Update.
9643 (allocate_psymtab): Update.
9644 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9645 macro_cache>: No longer pointers.
9646 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9647 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9648 * macrotab.c (macro_bcache): Update.
9649 * macroexp.c: Don't include bcache.h.
9650 * gdbtypes.c (check_types_worklist): Update.
9651 (types_deeply_equal): Remove TRY/CATCH. Update.
9652 * elfread.c (elf_symtab_read): Update.
9653 * dwarf2read.c: Don't include bcache.h.
9654 * buildsym.c (buildsym_compunit::get_macro_table): Update.
9655 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9656 (print_bcache_statistics, bcache_memory_used): Don't declare.
9657 (struct bcache): Move from bcache.c. Add constructor, destructor,
9658 methods. Rename all data members.
9659 * bcache.c (struct bcache): Move to bcache.h.
9660 (bcache::expand_hash_table): Rename from expand_hash_table.
9661 (bcache): Remove.
9662 (bcache::insert): Rename from bcache_full.
9663 (bcache::compare): Rename from bcache_compare.
9664 (bcache_xmalloc): Remove.
9665 (bcache::~bcache): Rename from bcache_xfree.
9666 (bcache::print_statistics): Rename from print_bcache_statistics.
9667 (bcache::memory_used): Rename from bcache_memory_used.
9668
9669 2019-03-07 Pedro Alves <palves@redhat.com>
9670
9671 * infrun.c (normal_stop): Also check for
9672 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9673
9674 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
9675
9676 * f-lang.c (value_from_host_double): Moved to...
9677 * value.c (value_from_host_double): ...here.
9678 * value.h (value_from_host_double): Declare.
9679 * guile/scm-math.c (vlscm_convert_typed_number): Use
9680 value_from_host_double.
9681 (vlscm_convert_number): Likewise.
9682 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9683 * python/py-value.c (convert_value_from_python): Likewise.
9684
9685 2019-03-06 Tom Tromey <tom@tromey.com>
9686
9687 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9688
9689 2019-03-06 Tom Tromey <tom@tromey.com>
9690
9691 * utils.h (free_current_contents): Don't declare.
9692 * utils.c (free_current_contents): Remove.
9693
9694 2019-03-06 Tom Tromey <tom@tromey.com>
9695
9696 * top.c (quit_force): Update.
9697 * main.c (captured_command_loop): Update.
9698 * common/new-op.c (operator new): Update.
9699 * common/common-exceptions.c (struct catcher)
9700 <save_cleanup_chain>: Remove member.
9701 (exceptions_state_mc_init): Update.
9702 (exception_try_scope_entry): Return nullptr.
9703 (exception_try_scope_exit, exception_rethrow)
9704 (throw_exception_sjlj, throw_exception_cxx): Update.
9705 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9706 (all_cleanups, do_cleanups, discard_cleanups)
9707 (discard_final_cleanups, save_cleanups, save_final_cleanups)
9708 (restore_cleanups, restore_final_cleanups): Don't declare.
9709 (do_final_cleanups): Remove parameter.
9710 * common/cleanups.c (cleanup_chain, make_cleanup)
9711 (make_cleanup_dtor, all_cleanups, do_cleanups)
9712 (discard_my_cleanups, discard_cleanups)
9713 (discard_final_cleanups, save_my_cleanups, save_cleanups)
9714 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9715 (null_cleanup): Remove.
9716 (do_final_cleanups): Remove parameter.
9717
9718 2019-03-06 Tom Tromey <tom@tromey.com>
9719
9720 * remote.c (remote_target::remote_parse_stop_reply): Use
9721 unique_xmalloc_ptr.
9722
9723 2019-03-06 Tom Tromey <tom@tromey.com>
9724
9725 * stabsread.c (struct stabs_field_info): Rename from field_info.
9726 <list, fnlist>: Add initializers.
9727 <obstack>: New member.
9728 (read_member_functions, read_struct_fields, read_baseclasses):
9729 Allocate on obstack. Don't use cleanups.
9730 (read_one_struct_field, read_member_functions, read_struct_fields)
9731 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9732 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9733 (read_struct_type): Update.
9734
9735 2019-03-06 Tom Tromey <tom@tromey.com>
9736
9737 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9738 * common/filestuff.h (make_cleanup_close): Don't declare.
9739 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9740 Remove.
9741
9742 2019-03-06 Tom Tromey <tom@tromey.com>
9743
9744 * solib-aix.c: Use make_scope_exit.
9745
9746 2019-03-06 Tom Tromey <tom@tromey.com>
9747
9748 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9749 Use make_scope_exit.
9750
9751 2019-03-06 Tom Tromey <tom@tromey.com>
9752
9753 * solib-svr4.c (disable_probes_interface): Remove parameter.
9754 (svr4_handle_solib_event): Use make_scope_exit.
9755
9756 2019-03-06 Tom Tromey <tom@tromey.com>
9757
9758 * remote.c (struct stop_reply_deleter): Remove.
9759 (stop_reply_up): Update.
9760 (struct stop_reply): Derive from notif_event. Don't typedef.
9761 <regcache>: Now a std::vector.
9762 (stop_reply_xfree): Remove.
9763 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9764 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
9765 (remote_target::discard_pending_stop_replies): Use delete.
9766 (remote_target::remote_parse_stop_reply): Update.
9767 (remote_target::process_stop_reply): Update.
9768 * remote-notif.h (struct notif_event): Add virtual destructor.
9769 Remove "dtr" member.
9770 (struct notif_client) <alloc_event>: Return a unique_ptr.
9771 (notif_event_xfree): Don't declare.
9772 (notif_event_up): New typedef.
9773 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9774 (notif_event_xfree, do_notif_event_xfree): Remove.
9775 (remote_notif_state_xfree): Update.
9776
9777 2019-03-06 Tom Tromey <tom@tromey.com>
9778
9779 * infrun.c (displaced_step_clear_cleanup): Now a
9780 forward_scope_exit type.
9781 (displaced_step_prepare_throw): Update.
9782 (displaced_step_fixup): Update.
9783
9784 2019-03-06 Tom Tromey <tom@tromey.com>
9785
9786 * inferior.h (class inferior): Update comment.
9787 * gdbthread.h (class thread_info): Update comment.
9788
9789 2019-03-06 Joel Brobecker <brobecker@adacore.com>
9790 Tom Tromey <tom@tromey.com>
9791
9792 * stabsread.h (struct stab_section_list): Remove.
9793 (coffstab_build_psymtabs): Update.
9794 * dbxread.c (symbuf_sections): Now a std::vector.
9795 (sect_idx): New global.
9796 (fill_symbuf): Update.
9797 (coffstab_build_psymtabs): Change type of stabsects parameter.
9798 Update.
9799 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9800 std::vector.
9801 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9802 (coff_locate_sections): Update.
9803 (coff_symfile_read): Remove cleanups. Update.
9804 (init_stringtab): Add storage parameter.
9805 (free_stringtab, free_stringtab_cleanup): Remove.
9806 (init_lineno): Add storage parameter.
9807 (free_linetab, free_linetab_cleanup): Remove.
9808
9809 2019-03-06 Pedro Alves <palves@redhat.com>
9810
9811 * linux-fork.c (fork_info::clobber_regs): Delete.
9812 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9813 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
9814 comment. Adjust.
9815 (scoped_switch_fork_info::scoped_switch_fork_info)
9816 (checkpoint_command, linux_fork_context): Adjust
9817 fork_save_infrun_state calls.
9818
9819 2019-03-06 Pedro Alves <palves@redhat.com>
9820
9821 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9822 (inf_has_multiple_threads): Return 'bool' and rewrite using
9823 inferior_info::threads().
9824
9825 2019-03-06 Pedro Alves <palves@redhat.com>
9826
9827 * linux-fork.c: Include <list>.
9828 (fork_list): Now a std::list instance.
9829 (fork_info): Add ctor, dtor, and in-class initialize all fields.
9830 (forks_exist_p, find_last_fork): Adjust.
9831 (new_fork): Delete.
9832 (one_fork_p): New.
9833 (add_fork): Adjust.
9834 (free_fork): Delete, folded into fork_info::~fork_info().
9835 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9836 Adjust.
9837 (init_fork_list): Delete.
9838 (linux_fork_killall, linux_fork_mourn_inferior)
9839 (linux_fork_detach, info_checkpoints_command): Adjust.
9840 (_initialize_linux_fork): No longer call init_fork_list.
9841
9842 2019-03-06 Pedro Alves <palves@redhat.com>
9843
9844 * linux-fork.c (new_fork): New, split out of ...
9845 (add_fork): ... this. Return void. Move "first fork" special
9846 case from here, to ...
9847 (checkpoint_command): ... here.
9848 * linux-linux.h (add_fork): Return void.
9849
9850 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9851
9852 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9853
9854 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9855 Chris January <chris.january@arm.com>
9856 David Lecomber <david.lecomber@arm.com>
9857
9858 * f-exp.y: New token, UNOP_INTRINSIC.
9859 (exp): New pattern using UNOP_INTRINSIC token.
9860 (f77_keywords): Add 'abs' keyword.
9861 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9862 (value_from_host_double): New function.
9863 (evaluate_subexp_f): Support UNOP_ABS.
9864
9865 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9866
9867 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9868 types.
9869
9870 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9871
9872 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9873 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9874 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9875
9876 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9877
9878 * f-exp.y (convert_to_kind_type): Handle more type kinds.
9879
9880 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9881 Chris January <chris.january@arm.com>
9882
9883 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9884 * f-exp.y: Define 'KIND' token.
9885 (exp): New pattern for KIND expressions.
9886 (ptype): Handle types with a kind extension.
9887 (direct_abs_decl): Extend to spot kind extensions.
9888 (f77_keywords): Add 'kind' to the list.
9889 (push_kind_type): New function.
9890 (convert_to_kind_type): New function.
9891 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9892 * parse.c (operator_length_standard): Likewise.
9893 * parser-defs.h (enum type_pieces): Add tp_kind.
9894 * std-operator.def: Add UNOP_KIND.
9895
9896 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9897
9898 * f-exp.y (f_parse): Set yydebug.
9899
9900 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9901
9902 * f-lang.c (evaluate_subexp_f): New function.
9903 (exp_descriptor_f): New global.
9904 (f_language_defn): Use exp_descriptor_f instead of
9905 exp_descriptor_standard.
9906
9907 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9908
9909 * f-exp.y (struct token): Add comments.
9910 (dot_ops): Remove uppercase versions and the end marker.
9911 (f77_keywords): Likewise.
9912 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9913 entries in the dot_ops array are case insensitive, and use
9914 strncasecmp to compare strings. Also some whitespace cleanup in
9915 this area. Similar for the f77_keywords array, except entries in
9916 this list might be case sensitive.
9917
9918 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9919
9920 * f-exp.y (struct f77_boolean_val): Add comments.
9921 (boolean_values): Remove uppercase versions, and end marker.
9922 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9923 and use strncasecmp to achieve case insensitivity. Additionally,
9924 perform whitespace cleanup around this code.
9925
9926 2019-03-06 Tom Tromey <tromey@adacore.com>
9927
9928 * remote-sim.c (gdbsim_target_open): Use result of
9929 gdb_argv::release.
9930
9931 2019-03-06 Richard Bunt <richard.bunt@arm.com>
9932 Dirk Schubert <dirk.schubert@arm.com>
9933 Chris January <chris.january@arm.com>
9934
9935 * eval.c (evaluate_subexp_standard): Call Fortran argument
9936 wrapping logic.
9937 * f-lang.c (struct value): A value which can be passed into a
9938 Fortran function call.
9939 (fortran_argument_convert): Wrap Fortran arguments in a pointer
9940 where appropriate.
9941 (struct type): Value ready for a Fortran function call.
9942 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9943 is needed.
9944 * f-lang.h (fortran_argument_convert): Declaration.
9945 (fortran_preserve_arg_pointer): Declaration.
9946 * infcall.c (value_arg_coerce): Call Fortran argument logic.
9947
9948 2019-03-05 Tom Tromey <tromey@adacore.com>
9949
9950 * python/py-prettyprint.c (print_string_repr): Remove #if.
9951 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9952
9953 2019-03-05 Tom Tromey <tromey@adacore.com>
9954
9955 * target.c (the_dummy_target): Move later. Change type to
9956 "dummy_target".
9957 (initialize_targets): Don't initialize the_dummy_target.
9958
9959 2019-03-05 Tom Tromey <tromey@adacore.com>
9960
9961 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9962 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9963
9964 2019-03-05 Tom Tromey <tromey@adacore.com>
9965
9966 * windows-nat.c (windows_nat_target::attach)
9967 (windows_nat_target::detach): Don't call gdb_flush.
9968 * valprint.c (generic_val_print, val_print, val_print_string):
9969 Don't call gdb_flush.
9970 * utils.c (defaulted_query): Don't call gdb_flush.
9971 * typeprint.c (print_type_scalar): Don't call gdb_flush.
9972 * target.c (target_announce_detach): Don't call gdb_flush.
9973 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9974 * remote.c (extended_remote_target::attach): Don't call
9975 gdb_flush.
9976 * procfs.c (procfs_target::detach): Don't call gdb_flush.
9977 * printcmd.c (do_examine): Don't call gdb_flush.
9978 (info_display_command): Don't call gdb_flush.
9979 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9980 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9981 * memattr.c (info_mem_command): Don't call gdb_flush.
9982 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9983 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9984 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9985 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9986 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9987 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9988 (gnu_nat_target::detach): Don't call gdb_flush.
9989 * f-valprint.c (f_val_print): Don't call gdb_flush.
9990 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9991 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9992 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9993 gdb_flush.
9994 * c-valprint.c (c_val_print): Don't call gdb_flush.
9995 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9996
9997 2019-03-05 Tom Tromey <tromey@adacore.com>
9998
9999 * varobj.c (update_dynamic_varobj_children): Update.
10000 (install_default_visualizer): Use reset, not release.
10001 * value.c (set_internalvar): Update.
10002 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10003 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10004 ATTRIBUTE_UNUSED_RESULT.
10005
10006 2019-03-05 Tom Tromey <tromey@adacore.com>
10007
10008 * remote.c (class scoped_remote_fd) <release>: Add
10009 ATTRIBUTE_UNUSED_RESULT.
10010
10011 2019-03-05 Tom Tromey <tromey@adacore.com>
10012
10013 * macroexp.c (struct macro_buffer) <release>: Add
10014 ATTRIBUTE_UNUSED_RESULT.
10015
10016 2019-03-05 Tom Tromey <tromey@adacore.com>
10017
10018 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10019 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10020 ATTRIBUTE_UNUSED_RESULT.
10021
10022 2019-03-05 Tom Tromey <tromey@adacore.com>
10023
10024 * common/scoped_fd.h (class scoped_fd) <release>: Add
10025 ATTRIBUTE_UNUSED_RESULT.
10026
10027 2019-03-05 Tom Tromey <tromey@adacore.com>
10028
10029 * parser-defs.h (struct parser_state) <release>: Add
10030 ATTRIBUTE_UNUSED_RESULT.
10031
10032 2019-03-05 Tom Tromey <tromey@adacore.com>
10033
10034 * utils.h (class gdb_argv) <release>: Add
10035 ATTRIBUTE_UNUSED_RESULT.
10036 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10037
10038 2019-03-02 Eli Zaretskii <eliz@gnu.org>
10039
10040 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10041 for-loop range, to avoid compiler warnings.
10042
10043 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10044 avoid compiler warnings about unused variables.
10045
10046 * NEWS: Mention end of support for native debugging on MS-Windows
10047 before XP.
10048
10049 PR gdb/24292
10050 * common/netstuff.c:
10051 * gdbserver/gdbreplay.c
10052 * gdbserver/remote-utils.c:
10053 * ser-tcp.c:
10054 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10055 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
10056 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10057 'getaddrinfo' and 'freeaddrinfo' were not available before
10058 Windows XP, and mingw.org's MinGW headers by default define
10059 _WIN32_WINNT to 0x500.
10060
10061 2019-03-01 Gary Benson <gbenson@redhat.com>
10062
10063 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10064
10065 2019-02-28 Brian Vandenberg <phantall@gmail.com>
10066 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
10067
10068 PR gdb/8527
10069 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10070 set_sigint_trap, clear_sigint_trap.
10071
10072 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10073
10074 * target.c (target_detach): Clear the regcache and the
10075 frame cache.
10076
10077 2019-02-27 Pedro Alves <palves@redhat.com>
10078
10079 * utils.c (set_screen_size): When we cap the height/width sizes,
10080 tweak the corresponding command variable to show "unlimited":
10081
10082 2019-02-27 Saagar Jha <saagar@saagarjha.com>
10083 Pedro Alves <palves@redhat.com>
10084
10085 * utils.c (set_screen_size): Reduce "infinite" rows and columns
10086 before calling rl_set_screen_size.
10087
10088 2019-02-27 Tom Tromey <tromey@adacore.com>
10089
10090 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10091 define.
10092 * python/py-value.c: Remove Python 2.4 workaround.
10093 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10094 workaround.
10095 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10096 Python 2.4 workaround.
10097 * python/python-internal.h: Remove Python 2.4 comment.
10098 (Py_ssize_t): Don't define.
10099 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10100 (gdb_Py_DECREF): Remove Python 2.4 workaround.
10101 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10102 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10103 * python/python.c (do_start_initialization): Remove Python 2.4
10104 workaround.
10105 * python/py-prettyprint.c (class dummy_python_frame): Remove.
10106 (print_children): Remove Python 2.4 workaround.
10107 * python/py-inferior.c (buffer_procs): Remove Python 2.4
10108 workaround.
10109 (CHARBUFFERPROC_NAME): Remove.
10110 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10111 Python 2.4 workaround.
10112
10113 2019-02-27 Kevin Buettner <kevinb@redhat.com>
10114
10115 * NEWS: Note minimum Python version.
10116
10117 2019-02-27 Kevin Buettner <kevinb@redhat.com>
10118
10119 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10120 code from these functions. Remove corresponding ifdefs. Use
10121 Py_buffer_up instead of explicit calls to PyBuffer_Release.
10122 Remove gotos and target of gotos.
10123 (infpy_search_memory): Likewise.
10124
10125 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10126
10127 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10128 (hppa_gdbarch_init): Don't register deleted functions with
10129 gdbarch.
10130
10131 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10132
10133 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10134 (h8300_unwind_sp): Delete.
10135 (h8300_dummy_id): Delete.
10136 (h8300_gdbarch_init): Don't register deleted functions with
10137 gdbarch.
10138
10139 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10140
10141 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10142 (ft32_unwind_pc): Delete.
10143 (ft32_unwind_sp): Delete.
10144 (ft32_gdbarch_init): Don't register deleted functions with
10145 gdbarch.
10146
10147 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10148
10149 * gdb/frv-tdep.c (frv_dummy_id): Delete.
10150 (frv_unwind_pc): Delete.
10151 (frv_unwind_sp): Delete.
10152 (frv_gdbarch_init): Don't register deleted functions with
10153 gdbarch.
10154
10155 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10156
10157 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10158 (riscv_unwind_pc): Delete.
10159 (riscv_unwind_sp): Delete.
10160 (riscv_gdbarch_init): Don't register deleted functions with
10161 gdbarch.
10162
10163 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10164
10165 * gdb/csky-tdep.c (csky_dummy_id): Delete.
10166 (csky_unwind_pc): Delete.
10167 (csky_unwind_sp): Delete.
10168 (csky_gdbarch_init): Don't register deleted functions with
10169 gdbarch.
10170
10171 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10172
10173 * gdb/cris-tdep.c (cris_dummy_id): Delete.
10174 (cris_unwind_pc): Delete.
10175 (cris_unwind_sp): Delete.
10176 (cris_gdbarch_init): Don't register deleted functions with
10177 gdbarch.
10178
10179 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10180
10181 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10182 (bfin_unwind_pc): Delete.
10183 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10184
10185 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10186
10187 * gdb/arm-tdep.c (arm_dummy_id): Delete.
10188 (arm_unwind_pc): Delete.
10189 (arm_unwind_sp): Delete.
10190 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10191
10192 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10193
10194 * gdb/arc-tdep.c (arc_dummy_id): Delete.
10195 (arc_unwind_pc): Delete.
10196 (arc_unwind_sp): Delete.
10197 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10198
10199 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10200
10201 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10202 (alpha_unwind_pc): Delete.
10203 (alpha_gdbarch_init): Don't register deleted functions with
10204 gdbarch.
10205
10206 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10207
10208 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10209 (aarch64_unwind_pc): Delete.
10210 (aarch64_unwind_sp): Delete.
10211 (aarch64_gdbarch_init): Don't register deleted functions with
10212 gdbarch.
10213
10214 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10215
10216 * gdbtypes.c (type_align): Don't consider static members when
10217 computing structure alignment.
10218
10219 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10220
10221 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10222 return 0 for other types.
10223 * arch-utils.c (default_type_align): Always return 0.
10224 * gdbarch.h: Regenerate.
10225 * gdbarch.sh (type_align): Extend comment.
10226 * gdbtypes.c (type_align): Add additional comments, always call
10227 gdbarch_type_align before applying the default rules.
10228 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10229 generic code will then apply a suitable default.
10230 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10231 types, return 0 for other types.
10232
10233 2019-02-27 Joel Brobecker <brobecker@adacore.com>
10234
10235 * NEWS: Create a new section for the next release branch.
10236 Rename the section of the current branch, now that it has
10237 been cut.
10238
10239 2019-02-27 Joel Brobecker <brobecker@adacore.com>
10240
10241 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10242 * version.in: Bump version to 8.3.50.DATE-git.
10243
10244 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
10245
10246 * aix-thread.c (ptid_cmp): Remove unused variable.
10247 (get_signaled_thread): Likewise.
10248 (store_regs_user_thread): Likewise.
10249 (store_regs_kernel_thread): Likewise.
10250 (fetch_regs_kernel_thread): Remove shadowed variable.
10251
10252 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
10253
10254 * features/riscv/32bit-cpu.xml: Add register numbers.
10255 * features/riscv/32bit-fpu.c: Regenerate.
10256 * features/riscv/32bit-fpu.xml: Add register numbers.
10257 * features/riscv/64bit-cpu.xml: Add register numbers.
10258 * features/riscv/64bit-fpu.c: Regenerate.
10259 * features/riscv/64bit-fpu.xml: Add register numbers.
10260
10261 2019-02-26 Kevin Buettner <kevinb@redhat.com>
10262
10263 * NEWS: Mention two argument form of gdb.Value constructor.
10264 * python/py-value.c (convert_buffer_and_type_to_value): New
10265 function.
10266 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10267 Add support for handling an optional second argument. Call
10268 convert_buffer_and_type_to_value as appropriate.
10269 * python/python-internal.h (Py_buffer_deleter): New struct.
10270 (Py_buffer_up): New typedef.
10271
10272 2019-02-25 John Baldwin <jhb@FreeBSD.org>
10273
10274 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10275 instead of releasing ownership.
10276
10277 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
10278
10279 * dwarf2read.c (open_and_init_dwp_file): Call
10280 elf_numsections instead of bfd_count_sections to initialize
10281 dwp_file->num_sections.
10282
10283 2019-02-25 Tom Tromey <tromey@adacore.com>
10284
10285 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10286
10287 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
10288
10289 * gcore.in: Add '--readnever' option when invoking GDB.
10290
10291 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
10292
10293 * MAINTAINERS: Update my email address.
10294
10295 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
10296
10297 * build-id.c (build_id_to_debug_bfd_1): New function.
10298 (build_id_to_debug_bfd): Look for separate debug file in
10299 sysroot.
10300
10301 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
10302
10303 * gdbarch.sh: Update the copyright year range that is placed into
10304 generated files.
10305
10306 2019-02-22 Keith Seitz <keiths@redhat.com>
10307
10308 PR symtab/23853
10309 * linespec.c (create_sals_line_offset): Search for the default
10310 symtab's filename instead of its fullname.
10311
10312 2019-02-21 Alan Hayward <alan.hayward@arm.com>
10313
10314 * NEWS: Update style defaults.
10315
10316 2019-02-21 Alan Hayward <alan.hayward@arm.com>
10317
10318 * main.c (captured_main_1): Disable styling in batch mode.
10319
10320 2019-02-20 Tom Tromey <tom@tromey.com>
10321
10322 * symtab.c (symtab_symbol_info): Fix typos.
10323
10324 2019-02-20 Tom Tromey <tromey@adacore.com>
10325
10326 * findcmd.c (_initialize_mem_search): Use upper case for
10327 metasyntactic variables.
10328
10329 2019-02-20 Alan Hayward <alan.hayward@arm.com>
10330
10331 * aarch64-tdep.c (aarch64_add_reggroups): New function.
10332 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10333
10334 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
10335
10336 * top.h (source_file_name): Change to std::string.
10337 * top.c (source_file_name): Likewise.
10338 (command_line_input): Adjust.
10339 * cli/cli-script.c (script_from_file): Adjust.
10340
10341 2019-02-19 Tom Tromey <tromey@adacore.com>
10342
10343 * ravenscar-thread.c
10344 (ravenscar_thread_target::update_thread_list): Don't call
10345 ada_build_task_list.
10346 * ada-lang.h (ada_build_task_list): Don't declare.
10347 * ada-tasks.c (struct ada_tasks_inferior_data)
10348 <task_list_valid_p>: Now bool.
10349 (read_known_tasks, ada_task_list_changed)
10350 (ada_tasks_invalidate_inferior_data): Update.
10351 (read_known_tasks_array): Return bool.
10352 (read_known_tasks_list): Likewise.
10353 (read_known_tasks): Return void.
10354 (ada_build_task_list): Now static.
10355
10356 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
10357
10358 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10359 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10360
10361 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10362
10363 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10364 variant for ada_tasks_pspace_data_handle and
10365 ada_tasks_inferior_data_handle.
10366 (ada_tasks_pspace_data_cleanup): New function.
10367 (ada_tasks_inferior_data_cleanup): New function.
10368
10369 2019-02-17 Tom Tromey <tom@tromey.com>
10370
10371 * macrotab.h (macro_source_fullname): Return a std::string.
10372 * macrotab.c (macro_include, check_for_redefinition)
10373 (macro_undef, macro_lookup_definition, foreach_macro)
10374 (foreach_macro_in_scope): Update.
10375 (macro_source_fullname): Return a std::string.
10376 * macrocmd.c (show_pp_source_pos): Update.
10377
10378 2019-02-17 Tom Tromey <tom@tromey.com>
10379
10380 * macrocmd.c (show_pp_source_pos): Style the file names.
10381
10382 2019-02-17 Tom Tromey <tom@tromey.com>
10383
10384 PR tui/24197:
10385 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10386
10387 2019-02-17 Tom Tromey <tom@tromey.com>
10388
10389 * ada-lang.c (user_select_syms): Use filtered printing.
10390 * utils.c (wrap_style): New global.
10391 (desired_style): Remove.
10392 (emit_style_escape): Add stream parameter.
10393 (set_output_style, reset_terminal_style, prompt_for_continue):
10394 Update.
10395 (flush_wrap_buffer): Only flush gdb_stdout.
10396 (wrap_here): Set wrap_style.
10397 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
10398 treat escape sequences as a character. Change when wrap buffer is
10399 flushed.
10400 (fputs_styled): Do not set the output style when the default is
10401 requested.
10402 * ui-style.h (struct ui_file_style) <is_default>: New method.
10403 * source.c (print_source_lines_base): Emit escape sequences in one
10404 piece.
10405
10406 2019-02-17 Joel Brobecker <brobecker@adacore.com>
10407
10408 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10409 integers and enumeration types.
10410
10411 2019-02-17 Joel Brobecker <brobecker@adacore.com>
10412
10413 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10414 instead of lookup_symbol_in_language
10415 (do_exact_match): New function.
10416 (ada_get_symbol_name_matcher): Return do_exact_match when
10417 doing a verbatim match.
10418
10419 2019-02-15 Tom Tromey <tromey@adacore.com>
10420
10421 * ravenscar-thread.c (ravenscar_thread_target::resume)
10422 (ravenscar_thread_target::wait): Special case wildcard requests.
10423
10424 2019-02-15 Tom Tromey <tromey@adacore.com>
10425
10426 * ravenscar-thread.c (base_ptid): Remove.
10427 (struct ravenscar_thread_target) <close>: New method.
10428 <m_base_ptid>: New member.
10429 <update_inferior_ptid, active_task, task_is_currently_active,
10430 runtime_initialized>: Declare methods.
10431 <ravenscar_thread_target>: Add constructor.
10432 (ravenscar_thread_target::task_is_currently_active)
10433 (ravenscar_thread_target::update_inferior_ptid)
10434 (ravenscar_runtime_initialized): Rename. Now methods.
10435 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10436 (ravenscar_thread_target::update_thread_list): Update.
10437 (ravenscar_thread_target::active_task): Now method.
10438 (ravenscar_thread_target::store_registers)
10439 (ravenscar_thread_target::prepare_to_store)
10440 (ravenscar_thread_target::prepare_to_store)
10441 (ravenscar_thread_target::mourn_inferior): Update.
10442 (ravenscar_inferior_created): Use "new" to create target.
10443 (ravenscar_thread_target::get_ada_task_ptid): Update.
10444 (_initialize_ravenscar): Don't initialize base_ptid.
10445 (ravenscar_ops): Remove global.
10446
10447 2019-02-15 Tom Tromey <tromey@adacore.com>
10448
10449 * target.h (push_target): Declare new overload.
10450 * target.c (push_target): New overload, taking an rvalue reference.
10451 * remote.c (remote_target::open_1): Use push_target overload.
10452 * corelow.c (core_target_open): Use push_target overload.
10453
10454 2019-02-15 Tom Tromey <tromey@adacore.com>
10455
10456 * ravenscar-thread.c (is_ravenscar_task)
10457 (ravenscar_task_is_currently_active): Return bool.
10458 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10459 (_initialize_ravenscar): Remove "(void)".
10460 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10461 Return bool.
10462
10463 2019-02-15 Tom Tromey <tromey@adacore.com>
10464
10465 * ravenscar-thread.c (ravenscar_runtime_initializer)
10466 (has_ravenscar_runtime, get_running_thread_id)
10467 (ravenscar_thread_target::resume): Fix indentation.
10468
10469 2019-02-15 Tom Tromey <tromey@adacore.com>
10470
10471 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10472 from ravenscar_arch_ops.
10473 (sparc_ravenscar_ops::fetch_registers)
10474 (sparc_ravenscar_ops::store_registers): Now methods.
10475 (sparc_ravenscar_prepare_to_store): Remove.
10476 (sparc_ravenscar_ops): Redefine.
10477 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10478 methods and destructor. Remove members.
10479 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10480 (ravenscar_thread_target::store_registers)
10481 (ravenscar_thread_target::prepare_to_store): Update.
10482 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10483 Remove.
10484 (struct ppc_ravenscar_powerpc_ops): Derive from
10485 ravenscar_arch_ops.
10486 (ppc_ravenscar_powerpc_ops::fetch_registers)
10487 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10488 (ppc_ravenscar_powerpc_ops): Redefine.
10489 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10490 (ppc_ravenscar_e500_ops::fetch_registers)
10491 (ppc_ravenscar_e500_ops::store_registers): Now methods.
10492 (ppc_ravenscar_e500_ops): Redefine.
10493 * aarch64-ravenscar-thread.c
10494 (aarch64_ravenscar_generic_prepare_to_store): Remove.
10495 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10496 (aarch64_ravenscar_fetch_registers)
10497 (aarch64_ravenscar_store_registers): Now methods.
10498 (aarch64_ravenscar_ops): Redefine.
10499
10500 2019-02-15 Tom Tromey <tromey@adacore.com>
10501
10502 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10503 (ravenscar_thread_target::stopped_by_hw_breakpoint)
10504 (ravenscar_thread_target::stopped_by_watchpoint)
10505 (ravenscar_thread_target::stopped_data_address)
10506 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10507
10508 2019-02-15 Tom Tromey <tromey@adacore.com>
10509
10510 * ravenscar-thread.c: Fix some typos.
10511
10512 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10513 Tom Tromey <tromey@adacore.com>
10514
10515 * ada-lang.c (ada_exception_sal): Change addr_string to a
10516 std::string.
10517 (create_ada_exception_catchpoint): Update.
10518
10519 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10520 Tom Tromey <tromey@adacore.com>
10521
10522 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10523 (bp_location_ops): Remove.
10524 (base_breakpoint_allocate_location): Update.
10525 (free_bp_location): Update.
10526 * ada-lang.c (class ada_catchpoint_location)
10527 <ada_catchpoint_location>: Remove ops parameter.
10528 (ada_catchpoint_location_dtor): Remove.
10529 (ada_catchpoint_location_ops): Remove.
10530 (allocate_location_exception): Update.
10531 * breakpoint.h (struct bp_location_ops): Remove.
10532 (class bp_location) <bp_location>: Remove bp_location_ops
10533 parameter.
10534 <~bp_location>: Add destructor.
10535 <ops>: Remove.
10536
10537 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
10538 Pedro Alves <palves@redhat.com>
10539
10540 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10541 'PATH_MAX'.
10542
10543 2019-02-14 David Michael <fedora.dm0@gmail.com>
10544 Samuel Thibault <samuel.thibault@gnu.org>
10545 Thomas Schwinge <thomas@codesourcery.com>
10546
10547 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10548 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10549
10550 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
10551
10552 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10553 (check_empty): Use "const char *".
10554
10555 * gnu-nat.c (gnu_nat_target::detach): Instead of
10556 'detach_inferior (pid)' call
10557 'detach_inferior (find_inferior_pid (pid))'.
10558
10559 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10560 'nat/fork-inferior.o'.
10561 * gnu-nat.c: #include "nat/fork-inferior.h".
10562
10563 * gnu-nat.c (gnu_nat_target::detach): Instead of
10564 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10565 * gnu-nat.h: #include "inf-child.h".
10566 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10567 'i386_gnu_nat_target::fetch_registers'.
10568 (gnu_store_registers): Rename/move to
10569 'i386_gnu_nat_target::store_registers'.
10570
10571 * config/i386/nm-i386gnu.h: Don't "#include" any files.
10572 * gnu-nat.h (mach_thread_info): New function.
10573 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10574
10575 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10576
10577 2019-02-14 Frederic Konrad <konrad@adacore.com>
10578
10579 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10580
10581 2019-02-14 Joel Brobecker <brobecker@adacore.com>
10582
10583 * windows-nat.c (windows_add_thread): Add new parameter
10584 "main_thread_p" with default value set to false. Update
10585 function documentation as well as all callers.
10586 (windows_delete_thread): Likewise.
10587 (fake_create_process): Update call to windows_add_thread.
10588 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10589 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10590 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10591 call to windows_delete_thread.
10592
10593 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
10594
10595 * MAINTAINERS: Add Andrew Burgess as global maintainer.
10596
10597 2019-02-12 John Baldwin <jhb@FreeBSD.org>
10598
10599 * symfile.c (find_separate_debug_file): Use canonical path of
10600 sysroot with child_path instead of gdb_sysroot if it is valid.
10601
10602 2019-02-12 John Baldwin <jhb@FreeBSD.org>
10603
10604 * symfile.c (find_separate_debug_file): Use child_path to
10605 determine if an object file is under a sysroot.
10606
10607 2019-02-12 John Baldwin <jhb@FreeBSD.org>
10608
10609 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10610 unittests/child-path-selftests.c.
10611 * common/pathstuff.c (child_path): New function.
10612 * common/pathstuff.h (child_path): New prototype.
10613 * unittests/child-path-selftests.c: New file.
10614
10615 2019-02-12 John Baldwin <jhb@FreeBSD.org>
10616
10617 * symfile.c (find_separate_debug_file): Look for separate debug
10618 files in debug directories under the sysroot.
10619
10620 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10621
10622 * symtab.h (struct minimal_symbol data_p): New const method.
10623 (struct minimal_symbol text_p): Likewise.
10624 * symtab.c (output_source_filename): Use file name style
10625 to print file name.
10626 (print_symbol_info): Likewise.
10627 (print_msymbol_info): Use address style to print addresses.
10628 Use function name style to print executable text symbols.
10629 (expand_symtab_containing_pc): Use data_p.
10630 (find_pc_sect_compunit_symtab): Likewise.
10631
10632 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10633
10634 * breakpoint.c (describe_other_breakpoints): Use address style
10635 to print addresses.
10636 (say_where): Likewise.
10637
10638 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10639
10640 * ada-typeprint.c (print_func_type): Print function name
10641 style to print function name.
10642 * c-typeprint.c (c_print_type_1): Likewise.
10643
10644 2019-02-11 Alan Hayward <alan.hayward@arm.com>
10645
10646 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10647 for execve.
10648
10649 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10650
10651 * c-exp.y (direct_abs_decl): Use emplace_back to record the
10652 type_stack.
10653
10654 2019-02-10 Joel Brobecker <brobecker@adacore.com>
10655
10656 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10657 TYPE_CODE_REF types.
10658
10659 2019-02-08 Jim Wilson <jimw@sifive.com>
10660
10661 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10662 (riscv_linux_fregset): New.
10663 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10664
10665 2019-02-07 Tom Tromey <tom@tromey.com>
10666
10667 * thread.c (thread_cancel_execution_command): Update.
10668 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10669 methods.
10670 (struct thread_fsm_ops): Remove.
10671 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10672 (thread_fsm_should_stop, thread_fsm_return_value)
10673 (thread_fsm_set_finished, thread_fsm_finished_p)
10674 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10675 Don't declare.
10676 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10677 * infrun.c (clear_proceed_status_thread)
10678 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10679 (print_stop_event): Update.
10680 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10681 Add constructor.
10682 (step_command_fsm_ops): Remove.
10683 (new_step_command_fsm): Remove.
10684 (step_1): Update.
10685 (step_command_fsm::should_stop): Rename from
10686 step_command_fsm_should_stop.
10687 (step_command_fsm::clean_up): Rename from
10688 step_command_fsm_clean_up.
10689 (step_command_fsm::do_async_reply_reason): Rename from
10690 step_command_fsm_async_reply_reason.
10691 (struct until_next_fsm): Inherit from thread_fsm. Add
10692 constructor.
10693 (until_next_fsm_ops): Remove.
10694 (new_until_next_fsm): Remove.
10695 (until_next_fsm::should_stop): Rename from
10696 until_next_fsm_should_stop.
10697 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10698 (until_next_fsm::do_async_reply_reason): Rename from
10699 until_next_fsm_async_reply_reason.
10700 (struct finish_command_fsm): Inherit from thread_fsm. Add
10701 constructor. Change type of breakpoint.
10702 (finish_command_fsm_ops): Remove.
10703 (new_finish_command_fsm): Remove.
10704 (finish_command_fsm::should_stop): Rename from
10705 finish_command_fsm_should_stop.
10706 (finish_command_fsm::clean_up): Rename from
10707 finish_command_fsm_clean_up.
10708 (finish_command_fsm::return_value): Rename from
10709 finish_command_fsm_return_value.
10710 (finish_command_fsm::do_async_reply_reason): Rename from
10711 finish_command_fsm_async_reply_reason.
10712 (finish_command): Update.
10713 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10714 Add constructor.
10715 (call_thread_fsm_ops): Remove.
10716 (call_thread_fsm::call_thread_fsm): Rename from
10717 new_call_thread_fsm.
10718 (call_thread_fsm::should_stop): Rename from
10719 call_thread_fsm_should_stop.
10720 (call_thread_fsm::should_notify_stop): Rename from
10721 call_thread_fsm_should_notify_stop.
10722 (run_inferior_call, call_function_by_hand_dummy): Update.
10723 * cli/cli-interp.c (should_print_stop_to_console): Update.
10724 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10725 Add constructor. Change type of location_breakpoint,
10726 caller_breakpoint.
10727 (until_break_fsm_ops): Remove.
10728 (new_until_break_fsm): Remove.
10729 (until_break_fsm::should_stop): Rename from
10730 until_break_fsm_should_stop.
10731 (until_break_fsm::clean_up): Rename from
10732 until_break_fsm_clean_up.
10733 (until_break_fsm::do_async_reply_reason): Rename from
10734 until_break_fsm_async_reply_reason.
10735 (until_break_command): Update.
10736 * thread-fsm.c: Remove.
10737 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10738
10739 2019-02-07 Tom Tromey <tom@tromey.com>
10740
10741 * yy-remap.h: Add include guard.
10742 * xtensa-tdep.h: Add include guard.
10743 * xcoffread.h: Rename include guard.
10744 * varobj-iter.h: Add include guard.
10745 * tui/tui.h: Rename include guard.
10746 * tui/tui-winsource.h: Rename include guard.
10747 * tui/tui-wingeneral.h: Rename include guard.
10748 * tui/tui-windata.h: Rename include guard.
10749 * tui/tui-win.h: Rename include guard.
10750 * tui/tui-stack.h: Rename include guard.
10751 * tui/tui-source.h: Rename include guard.
10752 * tui/tui-regs.h: Rename include guard.
10753 * tui/tui-out.h: Rename include guard.
10754 * tui/tui-layout.h: Rename include guard.
10755 * tui/tui-io.h: Rename include guard.
10756 * tui/tui-hooks.h: Rename include guard.
10757 * tui/tui-file.h: Rename include guard.
10758 * tui/tui-disasm.h: Rename include guard.
10759 * tui/tui-data.h: Rename include guard.
10760 * tui/tui-command.h: Rename include guard.
10761 * tic6x-tdep.h: Add include guard.
10762 * target/waitstatus.h: Rename include guard.
10763 * target/wait.h: Rename include guard.
10764 * target/target.h: Rename include guard.
10765 * target/resume.h: Rename include guard.
10766 * target-float.h: Rename include guard.
10767 * stabsread.h: Add include guard.
10768 * rs6000-tdep.h: Add include guard.
10769 * riscv-fbsd-tdep.h: Add include guard.
10770 * regformats/regdef.h: Rename include guard.
10771 * record.h: Rename include guard.
10772 * python/python.h: Rename include guard.
10773 * python/python-internal.h: Rename include guard.
10774 * python/py-stopevent.h: Rename include guard.
10775 * python/py-ref.h: Rename include guard.
10776 * python/py-record.h: Rename include guard.
10777 * python/py-record-full.h: Rename include guard.
10778 * python/py-record-btrace.h: Rename include guard.
10779 * python/py-instruction.h: Rename include guard.
10780 * python/py-events.h: Rename include guard.
10781 * python/py-event.h: Rename include guard.
10782 * procfs.h: Add include guard.
10783 * proc-utils.h: Add include guard.
10784 * p-lang.h: Add include guard.
10785 * or1k-tdep.h: Rename include guard.
10786 * observable.h: Rename include guard.
10787 * nto-tdep.h: Rename include guard.
10788 * nat/x86-linux.h: Rename include guard.
10789 * nat/x86-linux-dregs.h: Rename include guard.
10790 * nat/x86-gcc-cpuid.h: Add include guard.
10791 * nat/x86-dregs.h: Rename include guard.
10792 * nat/x86-cpuid.h: Rename include guard.
10793 * nat/ppc-linux.h: Rename include guard.
10794 * nat/mips-linux-watch.h: Rename include guard.
10795 * nat/linux-waitpid.h: Rename include guard.
10796 * nat/linux-ptrace.h: Rename include guard.
10797 * nat/linux-procfs.h: Rename include guard.
10798 * nat/linux-osdata.h: Rename include guard.
10799 * nat/linux-nat.h: Rename include guard.
10800 * nat/linux-namespaces.h: Rename include guard.
10801 * nat/linux-btrace.h: Rename include guard.
10802 * nat/glibc_thread_db.h: Rename include guard.
10803 * nat/gdb_thread_db.h: Rename include guard.
10804 * nat/gdb_ptrace.h: Rename include guard.
10805 * nat/fork-inferior.h: Rename include guard.
10806 * nat/amd64-linux-siginfo.h: Rename include guard.
10807 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10808 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10809 * nat/aarch64-linux.h: Rename include guard.
10810 * nat/aarch64-linux-hw-point.h: Rename include guard.
10811 * mn10300-tdep.h: Add include guard.
10812 * mips-linux-tdep.h: Add include guard.
10813 * mi/mi-parse.h: Rename include guard.
10814 * mi/mi-out.h: Rename include guard.
10815 * mi/mi-main.h: Rename include guard.
10816 * mi/mi-interp.h: Rename include guard.
10817 * mi/mi-getopt.h: Rename include guard.
10818 * mi/mi-console.h: Rename include guard.
10819 * mi/mi-common.h: Rename include guard.
10820 * mi/mi-cmds.h: Rename include guard.
10821 * mi/mi-cmd-break.h: Rename include guard.
10822 * m2-lang.h: Add include guard.
10823 * location.h: Rename include guard.
10824 * linux-record.h: Rename include guard.
10825 * linux-nat.h: Add include guard.
10826 * linux-fork.h: Add include guard.
10827 * i386-darwin-tdep.h: Rename include guard.
10828 * hppa-linux-offsets.h: Add include guard.
10829 * guile/guile.h: Rename include guard.
10830 * guile/guile-internal.h: Rename include guard.
10831 * gnu-nat.h: Rename include guard.
10832 * gdb-stabs.h: Rename include guard.
10833 * frv-tdep.h: Add include guard.
10834 * f-lang.h: Add include guard.
10835 * event-loop.h: Add include guard.
10836 * darwin-nat.h: Rename include guard.
10837 * cp-abi.h: Rename include guard.
10838 * config/sparc/nm-sol2.h: Rename include guard.
10839 * config/nm-nto.h: Rename include guard.
10840 * config/nm-linux.h: Add include guard.
10841 * config/i386/nm-i386gnu.h: Rename include guard.
10842 * config/djgpp/nl_types.h: Rename include guard.
10843 * config/djgpp/langinfo.h: Rename include guard.
10844 * compile/gcc-cp-plugin.h: Add include guard.
10845 * compile/gcc-c-plugin.h: Add include guard.
10846 * compile/compile.h: Rename include guard.
10847 * compile/compile-object-run.h: Rename include guard.
10848 * compile/compile-object-load.h: Rename include guard.
10849 * compile/compile-internal.h: Rename include guard.
10850 * compile/compile-cplus.h: Rename include guard.
10851 * compile/compile-c.h: Rename include guard.
10852 * common/xml-utils.h: Rename include guard.
10853 * common/x86-xstate.h: Rename include guard.
10854 * common/version.h: Rename include guard.
10855 * common/vec.h: Rename include guard.
10856 * common/tdesc.h: Rename include guard.
10857 * common/selftest.h: Rename include guard.
10858 * common/scoped_restore.h: Rename include guard.
10859 * common/scoped_mmap.h: Rename include guard.
10860 * common/scoped_fd.h: Rename include guard.
10861 * common/safe-iterator.h: Rename include guard.
10862 * common/run-time-clock.h: Rename include guard.
10863 * common/refcounted-object.h: Rename include guard.
10864 * common/queue.h: Rename include guard.
10865 * common/ptid.h: Rename include guard.
10866 * common/print-utils.h: Rename include guard.
10867 * common/preprocessor.h: Rename include guard.
10868 * common/pathstuff.h: Rename include guard.
10869 * common/observable.h: Rename include guard.
10870 * common/netstuff.h: Rename include guard.
10871 * common/job-control.h: Rename include guard.
10872 * common/host-defs.h: Rename include guard.
10873 * common/gdb_wait.h: Rename include guard.
10874 * common/gdb_vecs.h: Rename include guard.
10875 * common/gdb_unlinker.h: Rename include guard.
10876 * common/gdb_unique_ptr.h: Rename include guard.
10877 * common/gdb_tilde_expand.h: Rename include guard.
10878 * common/gdb_sys_time.h: Rename include guard.
10879 * common/gdb_string_view.h: Rename include guard.
10880 * common/gdb_splay_tree.h: Rename include guard.
10881 * common/gdb_setjmp.h: Rename include guard.
10882 * common/gdb_ref_ptr.h: Rename include guard.
10883 * common/gdb_optional.h: Rename include guard.
10884 * common/gdb_locale.h: Rename include guard.
10885 * common/gdb_assert.h: Rename include guard.
10886 * common/filtered-iterator.h: Rename include guard.
10887 * common/filestuff.h: Rename include guard.
10888 * common/fileio.h: Rename include guard.
10889 * common/environ.h: Rename include guard.
10890 * common/common-utils.h: Rename include guard.
10891 * common/common-types.h: Rename include guard.
10892 * common/common-regcache.h: Rename include guard.
10893 * common/common-inferior.h: Rename include guard.
10894 * common/common-gdbthread.h: Rename include guard.
10895 * common/common-exceptions.h: Rename include guard.
10896 * common/common-defs.h: Rename include guard.
10897 * common/common-debug.h: Rename include guard.
10898 * common/cleanups.h: Rename include guard.
10899 * common/buffer.h: Rename include guard.
10900 * common/btrace-common.h: Rename include guard.
10901 * common/break-common.h: Rename include guard.
10902 * cli/cli-utils.h: Rename include guard.
10903 * cli/cli-style.h: Rename include guard.
10904 * cli/cli-setshow.h: Rename include guard.
10905 * cli/cli-script.h: Rename include guard.
10906 * cli/cli-interp.h: Rename include guard.
10907 * cli/cli-decode.h: Rename include guard.
10908 * cli/cli-cmds.h: Rename include guard.
10909 * charset-list.h: Add include guard.
10910 * buildsym-legacy.h: Rename include guard.
10911 * bfin-tdep.h: Add include guard.
10912 * ax.h: Rename include guard.
10913 * arm-linux-tdep.h: Add include guard.
10914 * arm-fbsd-tdep.h: Add include guard.
10915 * arch/xtensa.h: Rename include guard.
10916 * arch/tic6x.h: Add include guard.
10917 * arch/i386.h: Add include guard.
10918 * arch/arm.h: Rename include guard.
10919 * arch/arm-linux.h: Rename include guard.
10920 * arch/arm-get-next-pcs.h: Rename include guard.
10921 * arch/amd64.h: Add include guard.
10922 * arch/aarch64-insn.h: Rename include guard.
10923 * arch-utils.h: Rename include guard.
10924 * annotate.h: Add include guard.
10925 * amd64-darwin-tdep.h: Rename include guard.
10926 * aarch64-linux-tdep.h: Add include guard.
10927 * aarch64-fbsd-tdep.h: Add include guard.
10928 * aarch32-linux-nat.h: Add include guard.
10929
10930 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10931
10932 * macrotab.c (macro_define_internal): New function that
10933 factorizes macro_define_object_internal and macro_define_function
10934 code.
10935 (macro_define_object_internal): Use macro_define_internal.
10936 (macro_define_function): Likewise.
10937
10938 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10939
10940 * macrocmd.c (extract_identifier): Return
10941 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10942 callers.
10943
10944 2019-02-06 John Baldwin <jhb@FreeBSD.org>
10945
10946 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10947
10948 2019-02-05 Tom Tromey <tom@tromey.com>
10949
10950 * target.c (target_stack::unpush): Move assertion earlier.
10951
10952 2019-01-30 Tom Tromey <tom@tromey.com>
10953
10954 PR python/23615:
10955 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10956 (gdbpy_parse_and_eval): Likewise.
10957 * python/python-internal.h (gdbpy_allow_threads): New class.
10958
10959 2019-01-28 John Baldwin <jhb@FreeBSD.org>
10960
10961 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10962 (aarch64_fbsd_fpregmap): Move earlier.
10963 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10964 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10965 instead of individual calls to trad_frame_set_reg_addr.
10966 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10967 earlier.
10968 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10969 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10970 instead of individual calls to trad_frame_set_reg_addr.
10971
10972 2019-01-28 Alan Hayward <alan.hayward@arm.com>
10973
10974 * CONTRIBUTE: Replace contribution list with wiki link.
10975
10976 2019-01-25 Tom Tromey <tom@tromey.com>
10977
10978 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10979
10980 2019-01-25 Tom Tromey <tom@tromey.com>
10981
10982 * xtensa-linux-nat.c: Fix common/ includes.
10983 * xml-support.h: Fix common/ includes.
10984 * xml-support.c: Fix common/ includes.
10985 * x86-linux-nat.c: Fix common/ includes.
10986 * windows-nat.c: Fix common/ includes.
10987 * varobj.h: Fix common/ includes.
10988 * varobj.c: Fix common/ includes.
10989 * value.c: Fix common/ includes.
10990 * valops.c: Fix common/ includes.
10991 * utils.c: Fix common/ includes.
10992 * unittests/xml-utils-selftests.c: Fix common/ includes.
10993 * unittests/utils-selftests.c: Fix common/ includes.
10994 * unittests/unpack-selftests.c: Fix common/ includes.
10995 * unittests/tracepoint-selftests.c: Fix common/ includes.
10996 * unittests/style-selftests.c: Fix common/ includes.
10997 * unittests/string_view-selftests.c: Fix common/ includes.
10998 * unittests/scoped_restore-selftests.c: Fix common/ includes.
10999 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11000 * unittests/scoped_fd-selftests.c: Fix common/ includes.
11001 * unittests/rsp-low-selftests.c: Fix common/ includes.
11002 * unittests/parse-connection-spec-selftests.c: Fix common/
11003 includes.
11004 * unittests/optional-selftests.c: Fix common/ includes.
11005 * unittests/offset-type-selftests.c: Fix common/ includes.
11006 * unittests/observable-selftests.c: Fix common/ includes.
11007 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11008 * unittests/memrange-selftests.c: Fix common/ includes.
11009 * unittests/memory-map-selftests.c: Fix common/ includes.
11010 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11011 * unittests/function-view-selftests.c: Fix common/ includes.
11012 * unittests/environ-selftests.c: Fix common/ includes.
11013 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11014 * unittests/common-utils-selftests.c: Fix common/ includes.
11015 * unittests/cli-utils-selftests.c: Fix common/ includes.
11016 * unittests/array-view-selftests.c: Fix common/ includes.
11017 * ui-file.c: Fix common/ includes.
11018 * tui/tui-io.c: Fix common/ includes.
11019 * tracepoint.h: Fix common/ includes.
11020 * tracepoint.c: Fix common/ includes.
11021 * tracefile-tfile.c: Fix common/ includes.
11022 * top.h: Fix common/ includes.
11023 * top.c: Fix common/ includes.
11024 * thread.c: Fix common/ includes.
11025 * target/waitstatus.h: Fix common/ includes.
11026 * target/waitstatus.c: Fix common/ includes.
11027 * target.h: Fix common/ includes.
11028 * target.c: Fix common/ includes.
11029 * target-memory.c: Fix common/ includes.
11030 * target-descriptions.c: Fix common/ includes.
11031 * symtab.h: Fix common/ includes.
11032 * symfile.c: Fix common/ includes.
11033 * stap-probe.c: Fix common/ includes.
11034 * spu-linux-nat.c: Fix common/ includes.
11035 * sparc-nat.c: Fix common/ includes.
11036 * source.c: Fix common/ includes.
11037 * solib.c: Fix common/ includes.
11038 * solib-target.c: Fix common/ includes.
11039 * ser-unix.c: Fix common/ includes.
11040 * ser-tcp.c: Fix common/ includes.
11041 * ser-pipe.c: Fix common/ includes.
11042 * ser-base.c: Fix common/ includes.
11043 * selftest-arch.c: Fix common/ includes.
11044 * s12z-tdep.c: Fix common/ includes.
11045 * rust-exp.y: Fix common/ includes.
11046 * rs6000-aix-tdep.c: Fix common/ includes.
11047 * riscv-tdep.c: Fix common/ includes.
11048 * remote.c: Fix common/ includes.
11049 * remote-notif.h: Fix common/ includes.
11050 * remote-fileio.h: Fix common/ includes.
11051 * remote-fileio.c: Fix common/ includes.
11052 * regcache.h: Fix common/ includes.
11053 * regcache.c: Fix common/ includes.
11054 * record-btrace.c: Fix common/ includes.
11055 * python/python.c: Fix common/ includes.
11056 * python/py-type.c: Fix common/ includes.
11057 * python/py-inferior.c: Fix common/ includes.
11058 * progspace.h: Fix common/ includes.
11059 * producer.c: Fix common/ includes.
11060 * procfs.c: Fix common/ includes.
11061 * proc-api.c: Fix common/ includes.
11062 * printcmd.c: Fix common/ includes.
11063 * ppc-linux-nat.c: Fix common/ includes.
11064 * parser-defs.h: Fix common/ includes.
11065 * osdata.c: Fix common/ includes.
11066 * obsd-nat.c: Fix common/ includes.
11067 * nat/x86-linux.c: Fix common/ includes.
11068 * nat/x86-linux-dregs.c: Fix common/ includes.
11069 * nat/x86-dregs.h: Fix common/ includes.
11070 * nat/x86-dregs.c: Fix common/ includes.
11071 * nat/ppc-linux.c: Fix common/ includes.
11072 * nat/mips-linux-watch.h: Fix common/ includes.
11073 * nat/mips-linux-watch.c: Fix common/ includes.
11074 * nat/linux-waitpid.c: Fix common/ includes.
11075 * nat/linux-ptrace.h: Fix common/ includes.
11076 * nat/linux-ptrace.c: Fix common/ includes.
11077 * nat/linux-procfs.c: Fix common/ includes.
11078 * nat/linux-personality.c: Fix common/ includes.
11079 * nat/linux-osdata.c: Fix common/ includes.
11080 * nat/linux-namespaces.c: Fix common/ includes.
11081 * nat/linux-btrace.h: Fix common/ includes.
11082 * nat/linux-btrace.c: Fix common/ includes.
11083 * nat/fork-inferior.c: Fix common/ includes.
11084 * nat/amd64-linux-siginfo.c: Fix common/ includes.
11085 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11086 * nat/aarch64-linux.c: Fix common/ includes.
11087 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11088 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11089 * namespace.h: Fix common/ includes.
11090 * mips-linux-tdep.c: Fix common/ includes.
11091 * minsyms.c: Fix common/ includes.
11092 * mi/mi-parse.h: Fix common/ includes.
11093 * mi/mi-main.c: Fix common/ includes.
11094 * mi/mi-cmd-env.c: Fix common/ includes.
11095 * memrange.h: Fix common/ includes.
11096 * memattr.c: Fix common/ includes.
11097 * maint.h: Fix common/ includes.
11098 * maint.c: Fix common/ includes.
11099 * main.c: Fix common/ includes.
11100 * machoread.c: Fix common/ includes.
11101 * location.c: Fix common/ includes.
11102 * linux-thread-db.c: Fix common/ includes.
11103 * linux-nat.c: Fix common/ includes.
11104 * linux-fork.c: Fix common/ includes.
11105 * inline-frame.c: Fix common/ includes.
11106 * infrun.c: Fix common/ includes.
11107 * inflow.c: Fix common/ includes.
11108 * inferior.h: Fix common/ includes.
11109 * inferior.c: Fix common/ includes.
11110 * infcmd.c: Fix common/ includes.
11111 * inf-ptrace.c: Fix common/ includes.
11112 * inf-child.c: Fix common/ includes.
11113 * ia64-linux-nat.c: Fix common/ includes.
11114 * i387-tdep.c: Fix common/ includes.
11115 * i386-tdep.c: Fix common/ includes.
11116 * i386-linux-tdep.c: Fix common/ includes.
11117 * i386-linux-nat.c: Fix common/ includes.
11118 * i386-go32-tdep.c: Fix common/ includes.
11119 * i386-fbsd-tdep.c: Fix common/ includes.
11120 * i386-fbsd-nat.c: Fix common/ includes.
11121 * guile/scm-type.c: Fix common/ includes.
11122 * guile/guile.c: Fix common/ includes.
11123 * go32-nat.c: Fix common/ includes.
11124 * gnu-nat.c: Fix common/ includes.
11125 * gdbthread.h: Fix common/ includes.
11126 * gdbarch-selftests.c: Fix common/ includes.
11127 * gdb_usleep.c: Fix common/ includes.
11128 * gdb_select.h: Fix common/ includes.
11129 * gdb_bfd.c: Fix common/ includes.
11130 * gcore.c: Fix common/ includes.
11131 * fork-child.c: Fix common/ includes.
11132 * findvar.c: Fix common/ includes.
11133 * fbsd-nat.c: Fix common/ includes.
11134 * event-top.c: Fix common/ includes.
11135 * event-loop.c: Fix common/ includes.
11136 * dwarf2read.c: Fix common/ includes.
11137 * dwarf2loc.c: Fix common/ includes.
11138 * dwarf2-frame.c: Fix common/ includes.
11139 * dwarf-index-cache.c: Fix common/ includes.
11140 * dtrace-probe.c: Fix common/ includes.
11141 * disasm-selftests.c: Fix common/ includes.
11142 * defs.h: Fix common/ includes.
11143 * csky-tdep.c: Fix common/ includes.
11144 * cp-valprint.c: Fix common/ includes.
11145 * cp-support.h: Fix common/ includes.
11146 * cp-support.c: Fix common/ includes.
11147 * corelow.c: Fix common/ includes.
11148 * completer.h: Fix common/ includes.
11149 * completer.c: Fix common/ includes.
11150 * compile/compile.c: Fix common/ includes.
11151 * compile/compile-loc2c.c: Fix common/ includes.
11152 * compile/compile-cplus-types.c: Fix common/ includes.
11153 * compile/compile-cplus-symbols.c: Fix common/ includes.
11154 * command.h: Fix common/ includes.
11155 * cli/cli-dump.c: Fix common/ includes.
11156 * cli/cli-cmds.c: Fix common/ includes.
11157 * charset.c: Fix common/ includes.
11158 * build-id.c: Fix common/ includes.
11159 * btrace.h: Fix common/ includes.
11160 * btrace.c: Fix common/ includes.
11161 * breakpoint.h: Fix common/ includes.
11162 * breakpoint.c: Fix common/ includes.
11163 * ax.h:
11164 (enum agent_op): Fix common/ includes.
11165 * ax-general.c (struct aop_map): Fix common/ includes.
11166 * ax-gdb.c: Fix common/ includes.
11167 * auxv.c: Fix common/ includes.
11168 * auto-load.c: Fix common/ includes.
11169 * arm-tdep.c: Fix common/ includes.
11170 * arch/riscv.c: Fix common/ includes.
11171 * arch/ppc-linux-common.c: Fix common/ includes.
11172 * arch/i386.c: Fix common/ includes.
11173 * arch/arm.c: Fix common/ includes.
11174 * arch/arm-linux.c: Fix common/ includes.
11175 * arch/arm-get-next-pcs.c: Fix common/ includes.
11176 * arch/amd64.c: Fix common/ includes.
11177 * arch/aarch64.c: Fix common/ includes.
11178 * arch/aarch64-insn.c: Fix common/ includes.
11179 * arch-utils.c: Fix common/ includes.
11180 * amd64-windows-tdep.c: Fix common/ includes.
11181 * amd64-tdep.c: Fix common/ includes.
11182 * amd64-sol2-tdep.c: Fix common/ includes.
11183 * amd64-obsd-tdep.c: Fix common/ includes.
11184 * amd64-nbsd-tdep.c: Fix common/ includes.
11185 * amd64-linux-tdep.c: Fix common/ includes.
11186 * amd64-linux-nat.c: Fix common/ includes.
11187 * amd64-fbsd-tdep.c: Fix common/ includes.
11188 * amd64-fbsd-nat.c: Fix common/ includes.
11189 * amd64-dicos-tdep.c: Fix common/ includes.
11190 * amd64-darwin-tdep.c: Fix common/ includes.
11191 * agent.c: Fix common/ includes.
11192 * ada-lang.h: Fix common/ includes.
11193 * ada-lang.c: Fix common/ includes.
11194 * aarch64-tdep.c: Fix common/ includes.
11195
11196 2019-01-25 Tom Tromey <tom@tromey.com>
11197
11198 * common/create-version.sh: Use common/version.h.
11199
11200 2019-01-24 Pedro Alves <palves@redhat.com>
11201
11202 * infrun.c (signal_stop, signal_print, signal_program)
11203 (signal_catch, signal_pass): Now arrays instead of pointers.
11204 (update_signals_program_target, do_target_resume)
11205 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11206 * linux-nat.c (linux_nat_target::pass_signals)
11207 (linux_nat_target::create_inferior, linux_nat_target::attach):
11208 Adjust.
11209 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11210 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11211 * procfs.c (procfs_target::pass_signals): Adjust.
11212 * record-full.c (record_full_target::resume): Adjust.
11213 * remote.c (remote_target::pass_signals)
11214 (remote_target::program_signals): Adjust.
11215 * target-debug.h (target_debug_print_signals): Now takes a
11216 gdb::array_view as parameter. Adjust.
11217 * target.h (target_ops) <pass_signals, program_signals>: Replace
11218 pointer and length parameters with gdb::array_view.
11219 (target_pass_signals, target_program_signals): Likewise.
11220 * target-delegates.c: Regenerate.
11221
11222 2019-01-24 Pedro Alves <palves@redhat.com>
11223
11224 * common/forward-scope-exit.h
11225 (forward_scope_exit::forward_scope_exit): Pass arguments to
11226 m_bind_function directly, instead of creating a std::bind and
11227 copying that.
11228
11229 2019-01-24 Alan Hayward <alan.hayward@arm.com>
11230
11231 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11232 for static members.
11233 (pass_in_v_vfp_candidate): Likewise.
11234
11235 2019-01-23 Tom Tromey <tom@tromey.com>
11236 Pedro Alves <palves@redhat.com>
11237
11238 * regcache.c (class regcache_invalidator): Remove.
11239 (regcache::raw_write): Use make_scope_exit.
11240
11241 2019-01-23 Tom Tromey <tom@tromey.com>
11242
11243 * ui-out.h (class ui_out_emit_type): Update comment.
11244
11245 2019-01-23 Tom Tromey <tom@tromey.com>
11246
11247 * infrun.c (fetch_inferior_event): Update comment.
11248
11249 2019-01-23 Tom Tromey <tom@tromey.com>
11250 Pedro Alves <palves@redhat.com>
11251
11252 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11253 parameter.
11254 (fetch_inferior_event): Use SCOPE_EXIT.
11255
11256
11257 2019-01-23 Tom Tromey <tom@tromey.com>
11258 Pedro Alves <palves@redhat.com>
11259
11260 * infrun.c (disable_thread_events): Delete.
11261 (stop_all_threads): Use SCOPE_EXIT.
11262
11263 2019-01-23 Tom Tromey <tom@tromey.com>
11264 Pedro Alves <palves@redhat.com>
11265
11266 * symfile.c: Include forward-scope-exit.h.
11267 (clear_symtab_users_cleanup): Replace forward declaration with
11268 a FORWARD_SCOPE_EXIT.
11269 (syms_from_objfile_1): Use the forward_scope_exit and
11270 gdb::optional instead of cleanup_function.
11271 (reread_symbols): Use the forward_scope_exit instead of
11272 cleanup_function.
11273 (clear_symtab_users_cleanup): Remove function.
11274
11275 2019-01-23 Tom Tromey <tom@tromey.com>
11276 Pedro Alves <palves@redhat.com>
11277
11278 * linux-nat.c: Include scope-exit.h.
11279 (cleanup_target_stop): Remove.
11280 (linux_nat_target::static_tracepoint_markers_by_strid): Use
11281 SCOPE_EXIT.
11282
11283 2019-01-23 Tom Tromey <tom@tromey.com>
11284 Pedro Alves <palves@redhat.com>
11285
11286 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11287 (call_function_by_hand_dummy): Use SCOPE_EXIT.
11288
11289 2019-01-23 Tom Tromey <tom@tromey.com>
11290 Andrew Burgess <andrew.burgess@embecosm.com>
11291 Pedro Alves <palves@redhat.com>
11292
11293 * infrun.c (fetch_inferior_event): Use scope_exit.
11294 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11295 * top.c (execute_command): Use scope_exit.
11296 * breakpoint.c (bpstat_do_actions): Use scope_exit.
11297 * utils.c (do_bpstat_clear_actions_cleanup)
11298 (make_bpstat_clear_actions_cleanup): Remove.
11299
11300 2019-01-23 Tom Tromey <tom@tromey.com>
11301 Pedro Alves <palves@redhat.com>
11302
11303 * infrun.c: Include "common/scope-exit.h"
11304 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11305 (wait_for_inferior): Use SCOPE_EXIT.
11306 (fetch_inferior_event): Use scope_exit.
11307
11308 2019-01-23 Tom Tromey <tom@tromey.com>
11309 Pedro Alves <palves@redhat.com>
11310
11311 * breakpoint.c (create_breakpoint): Remove cleanup.
11312
11313 2019-01-23 Tom Tromey <tom@tromey.com>
11314 Andrew Burgess <andrew.burgess@embecosm.com>
11315 Pedro Alves <palves@redhat.com>
11316
11317 2019-01-23 Pedro Alves <palves@redhat.com>
11318
11319 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11320
11321 2019-01-23 Pedro Alves <palves@redhat.com>
11322 Andrew Burgess <andrew.burgess@embecosm.com>
11323
11324 * gdbthread.h: Include "common/forward-scope-exit.h".
11325 (scoped_finish_thread_state): Redefine custom class in terms of
11326 forward_scope_exit.
11327
11328 2019-01-23 Pedro Alves <palves@redhat.com>
11329 Andrew Burgess <andrew.burgess@embecosm.com>
11330
11331 * common/forward-scope-exit.h: New file.
11332
11333 2019-01-23 Pedro Alves <palves@redhat.com>
11334 Andrew Burgess <andrew.burgess@embecosm.com>
11335 Tom Tromey <tom@tromey.com>
11336
11337 * common/scope-exit.h: New file.
11338
11339 2019-01-23 Pedro Alves <palves@redhat.com>
11340
11341 * common/preprocessor.h (ESC): Rename to ...
11342 (ESC_PARENS): ... this.
11343 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11344 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11345
11346 2019-01-23 Tom Tromey <tom@tromey.com>
11347
11348 * language.h (class scoped_switch_to_sym_language_if_auto):
11349 Initialize m_lang in both cases.
11350
11351 2019-01-23 Alan Hayward <alan.hayward@arm.com>
11352
11353 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11354 with XCNEW.
11355
11356 2019-01-22 Tom Tromey <tom@tromey.com>
11357
11358 * corelow.c: Do not include sys/file.h.
11359
11360 2019-01-22 Tom Tromey <tom@tromey.com>
11361
11362 * tui/tui-wingeneral.h: Include gdb_curses.h.
11363
11364 2019-01-22 Tom Tromey <tom@tromey.com>
11365
11366 * source-cache.h (class source_cache) <get_source_lines,
11367 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11368
11369 2019-01-22 Tom Tromey <tom@tromey.com>
11370
11371 * remote-fileio.h (struct remote_target): Declare.
11372
11373 2019-01-22 Tom Tromey <tom@tromey.com>
11374
11375 * python/py-arch.c: Do not include py-ref.h.
11376 * python/py-bpevent.c: Do not include py-ref.h.
11377 * python/py-cmd.c: Do not include py-ref.h.
11378 * python/py-continueevent.c: Do not include py-ref.h.
11379 * python/py-event.h: Do not include py-ref.h.
11380 * python/py-evtregistry.c: Do not include py-ref.h.
11381 * python/py-finishbreakpoint.c: Do not include py-ref.h.
11382 * python/py-frame.c: Do not include py-ref.h.
11383 * python/py-framefilter.c: Do not include py-ref.h.
11384 * python/py-function.c: Do not include py-ref.h.
11385 * python/py-infevents.c: Do not include py-ref.h.
11386 * python/py-linetable.c: Do not include py-ref.h.
11387 * python/py-objfile.c: Do not include py-ref.h.
11388 * python/py-param.c: Do not include py-ref.h.
11389 * python/py-prettyprint.c: Do not include py-ref.h.
11390 * python/py-progspace.c: Do not include py-ref.h.
11391 * python/py-symbol.c: Do not include py-ref.h.
11392 * python/py-symtab.c: Do not include py-ref.h.
11393 * python/py-type.c: Do not include py-ref.h.
11394 * python/py-unwind.c: Do not include py-ref.h.
11395 * python/py-utils.c: Do not include py-ref.h.
11396 * python/py-value.c: Do not include py-ref.h.
11397 * python/py-varobj.c: Do not include py-ref.h.
11398 * python/py-xmethods.c: Do not include py-ref.h.
11399 * python/python.c: Do not include py-ref.h.
11400 * varobj.c: Do not include py-ref.h.
11401
11402 2019-01-22 Tom Tromey <tom@tromey.com>
11403
11404 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11405 keyword for bcache.
11406
11407 2019-01-22 Tom Tromey <tom@tromey.com>
11408
11409 * compile/compile-cplus-types.c: Remove a comment by #include.
11410
11411 2019-01-22 Tom Tromey <tom@tromey.com>
11412
11413 * compile/gcc-c-plugin.h: Include compile-internal.h.
11414
11415 2019-01-22 Tom Tromey <tom@tromey.com>
11416
11417 * stabsread.c (EXTERN): Do not define.
11418 (symnum, next_symbol_text_func, processing_gcc_compilation)
11419 (within_function, global_sym_chain, global_stabs)
11420 (previous_stab_code, this_object_header_files)
11421 (n_this_object_header_files)
11422 (n_allocated_this_object_header_files): Define.
11423 * stabsread.h (EXTERN): Never define. Use "extern".
11424
11425 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11426
11427 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11428 history_value.
11429
11430 2019-01-21 Tom Tromey <tom@tromey.com>
11431
11432 * ui-out.c: Fix includes.
11433 * tui/tui-source.c: Fix includes.
11434 * target.c: Fix includes.
11435 * remote.c: Fix includes.
11436 * regcache.c: Fix includes.
11437 * python/py-block.c: Fix includes.
11438 * printcmd.c: Fix includes.
11439 * or1k-tdep.c: Fix includes.
11440 * mi/mi-main.c: Fix includes.
11441 * m32r-tdep.c: Fix includes.
11442 * csky-tdep.c: Fix includes.
11443 * compile/compile-cplus-types.c: Fix includes.
11444 * cli/cli-interp.c: Fix includes.
11445
11446 2019-01-21 Alan Hayward <alan.hayward@arm.com>
11447
11448 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11449 for padding.
11450
11451 2019-01-16 Tom Tromey <tom@tromey.com>
11452
11453 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
11454 earlier.
11455 (struct objfile) <msymbols_range>: Move from top level.
11456 <msymbols>: New method.
11457 (class objfile_msymbols): Remove.
11458 * symtab.c (default_collect_symbol_completion_matches_break_on):
11459 Update.
11460 * symmisc.c (dump_msymbols): Update.
11461 * stabsread.c (scan_file_globals): Update.
11462 * objc-lang.c (info_selectors_command, info_classes_command)
11463 (find_methods): Update.
11464 * minsyms.c (find_solib_trampoline_target): Update.
11465 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11466 * coffread.c (coff_symfile_read): Update.
11467 * ada-lang.c (ada_lookup_simple_minsym)
11468 (ada_collect_symbol_completion_matches): Update.
11469
11470 2019-01-16 Tom Tromey <tom@tromey.com>
11471
11472 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11473 type. Remove no-argument constructor.
11474 <iterator::operator++>: Simplify.
11475 <begin>: Update.
11476 <end>: Use minimal_symbol_count.
11477
11478 2019-01-16 Tom Tromey <tom@tromey.com>
11479
11480 * objfiles.h (struct objfile) <psymtabs>: New method.
11481 (class objfile_psymtabs): Remove.
11482 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11483 typedef.
11484 <range>: New method.
11485 (require_partial_symbols): Change return type.
11486 * psymtab.c (require_partial_symbols)
11487 (psym_expand_symtabs_matching): Update.
11488 * mdebugread.c (parse_partial_symbols): Update.
11489 * dbxread.c (dbx_end_psymtab): Update.
11490
11491 2019-01-15 Tom Tromey <tom@tromey.com>
11492
11493 * symtab.c (lookup_objfile_from_block)
11494 (lookup_symbol_in_objfile_symtabs)
11495 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11496 (find_line_symtab, info_sources_command)
11497 (default_collect_symbol_completion_matches_break_on)
11498 (make_source_files_completion_list): Update.
11499 * symmisc.c (print_objfile_statistics, dump_objfile)
11500 (maintenance_print_symbols, maintenance_info_symtabs)
11501 (maintenance_check_symtabs, maintenance_info_line_tables):
11502 Update.
11503 * source.c (select_source_symtab)
11504 (forget_cached_source_info_for_objfile): Update.
11505 * objfiles.h (class objfile_compunits): Remove.
11506 (struct objfile) <compunits_range>: New typedef.
11507 (compunits): New method.
11508 * objfiles.c (objfile_relocate1): Update.
11509 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11510 * maint.c (count_symtabs_and_blocks): Update.
11511 * linespec.c (iterate_over_all_matching_symtabs): Update.
11512 * cp-support.c (add_symbol_overload_list_qualified): Update.
11513 * coffread.c (coff_symtab_read): Update.
11514 * ada-lang.c (add_nonlocal_symbols)
11515 (ada_collect_symbol_completion_matches)
11516 (ada_add_global_exceptions): Update.
11517
11518 2019-01-15 Tom Tromey <tom@tromey.com>
11519
11520 * progspace.h (program_space) <objfiles_safe_range>: New
11521 typedef.
11522 <objfiles_safe>: New method.
11523 * objfiles.h (class all_objfiles_safe): Remove.
11524 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11525 * jit.c (jit_inferior_exit_hook): Update.
11526
11527 2019-01-17 Tom Tromey <tom@tromey.com>
11528
11529 * progspace.h (program_space) <objfiles_range>: New typedef.
11530 <objfiles>: New method.
11531 <objfiles_head>: Rename from objfiles.
11532 (object_files): Update.
11533 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11534 * guile/scm-pretty-print.c
11535 (ppscm_find_pretty_printer_from_objfiles): Update.
11536 * guile/scm-objfile.c (gdbscm_objfiles): Update.
11537 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11538 Update.
11539 * python/py-progspace.c (pspy_get_objfiles): Update.
11540 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11541 Update.
11542 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11543 (objfpy_lookup_objfile_by_build_id): Update.
11544 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11545 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11546 Update.
11547 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11548 (expand_symtab_containing_pc, lookup_objfile_from_block)
11549 (lookup_static_symbol, basic_lookup_transparent_type)
11550 (find_pc_sect_compunit_symtab, find_symbol_at_address)
11551 (find_line_symtab, info_sources_command)
11552 (default_collect_symbol_completion_matches_break_on)
11553 (make_source_files_completion_list, find_main_name): Update.
11554 * symmisc.c (print_symbol_bcache_statistics)
11555 (print_objfile_statistics, maintenance_print_symbols)
11556 (maintenance_print_msymbols, maintenance_print_objfiles)
11557 (maintenance_info_symtabs, maintenance_check_symtabs)
11558 (maintenance_expand_symtabs, maintenance_info_line_tables):
11559 Update.
11560 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11561 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11562 (map_overlay_command, unmap_overlay_command)
11563 (simple_overlay_update, expand_symtabs_matching)
11564 (map_symbol_filenames): Update.
11565 * symfile-debug.c (set_debug_symfile): Update.
11566 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11567 Update.
11568 * source.c (select_source_symtab, forget_cached_source_info):
11569 Update.
11570 * solib.c (solib_read_symbols): Update.
11571 * solib-spu.c (append_ocl_sos): Update.
11572 * psymtab.c (maintenance_print_psymbols)
11573 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11574 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11575 * printcmd.c (info_symbol_command): Update.
11576 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11577 Update.
11578 * objfiles.h (class all_objfiles): Remove.
11579 * objfiles.c (have_partial_symbols, have_full_symbols)
11580 (have_minimal_symbols, qsort_cmp, update_section_map)
11581 (shared_objfile_contains_address_p)
11582 (default_iterate_over_objfiles_in_search_order): Update.
11583 * objc-lang.c (info_selectors_command, info_classes_command)
11584 (find_methods): Update.
11585 * minsyms.c (find_solib_trampoline_target): Update.
11586 * maint.c (maintenance_info_sections)
11587 (maintenance_translate_address, count_symtabs_and_blocks):
11588 Update.
11589 * main.c (captured_main_1): Update.
11590 * linux-thread-db.c (try_thread_db_load_from_pdir)
11591 (has_libpthread): Update.
11592 * linespec.c (iterate_over_all_matching_symtabs)
11593 (search_minsyms_for_name): Update.
11594 * jit.c (jit_find_objf_with_entry_addr): Update.
11595 * hppa-tdep.c (find_unwind_entry)
11596 (hppa_lookup_stub_minimal_symbol): Update.
11597 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11598 Update.
11599 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11600 (elf_gnu_ifunc_resolve_by_got): Update.
11601 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11602 * dwarf-index-write.c (save_gdb_index_command): Update.
11603 * cp-support.c (add_symbol_overload_list_qualified): Update.
11604 * breakpoint.c (create_overlay_event_breakpoint)
11605 (create_longjmp_master_breakpoint)
11606 (create_std_terminate_master_breakpoint)
11607 (create_exception_master_breakpoint): Update.
11608 * blockframe.c (find_pc_partial_function): Update.
11609 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11610 (ada_collect_symbol_completion_matches)
11611 (ada_add_global_exceptions): Update.
11612
11613 2019-01-17 Tom Tromey <tom@tromey.com>
11614
11615 * solib-target.c (lm_info_target_p): Remove typedef. Don't
11616 declare VEC.
11617 (solib_target_parse_libraries): Change return type.
11618 (library_list_start_segment, library_list_start_section)
11619 (library_list_end_library, library_list_start_library); Update.
11620 (solib_target_free_library_list): Remove.
11621 (solib_target_parse_libraries): Remove cleanup. Change return
11622 type.
11623 (solib_target_current_sos): Update.
11624
11625 2019-01-17 Tom Tromey <tromey@bapiya>
11626
11627 * valprint.c: Replace "the the" with "the".
11628 * symtab.c: Replace "the the" with "the".
11629 * solib.c: Replace "the the" with "the".
11630 * solib-dsbt.c: Replace "the the" with "the".
11631 * linespec.c: Replace "the the" with "the".
11632 * dwarf2loc.h: Replace "the the" with "the".
11633 * amd64-windows-tdep.c: Replace "the the" with "the".
11634 * aarch64-tdep.c: Replace "the the" with "the".
11635
11636 2019-01-16 Keith Seitz <keiths@redhat.com>
11637
11638 PR gdb/23773
11639 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11640 <builder>: Rename to ..
11641 <m_builder>: ... this and make private.
11642 (dwarf2_cu::get_builder): New method. Change all users of
11643 `builder' to use this method.
11644 (dwarf2_start_symtab): Move to ...
11645 (dwarf2_cu::start_symtab): ... here. Update all callers
11646 (setup_type_unit_groups): Move to ...
11647 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
11648 callers.
11649 (dwarf2_cu::reset_builder): New method.
11650 (process_full_compunit, process_full_type_unit): Use
11651 dwarf2_cu::reset_builder.
11652 (follow_die_offset): Record the ancestor CU if it is different
11653 from the followed DIE's CU.
11654 (follow_die_sig_1): Likewise.
11655
11656 2019-01-15 Tom Tromey <tom@tromey.com>
11657
11658 * remote.c (class remote_state) <buf>: Now a char_vector.
11659 <buf_size>: Remove.
11660 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
11661 parameter.
11662 (remote_target::getpkt_or_notif_sane_1)
11663 (remote_target::getpkt_sane)
11664 (remote_target::getpkt_or_notif_sane): Likewise.
11665 (class remote_target) <putpkt>: New overload.
11666 (remote_target::read_frame): Change type of "buf_p". Remove
11667 sizeof_p parameter.
11668 (packet_ok): New overload.
11669 (packet_check_result): New overload.
11670 Update all uses.
11671
11672 2019-01-14 Tom Tromey <tom@tromey.com>
11673
11674 * remote-notif.c (handle_notification, remote_notif_ack)
11675 (remote_notif_parse): Make "buf" const.
11676 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11677 const.
11678 (remote_notif_parse, remote_notif_ack, handle_notification):
11679 Likewise.
11680 * remote.c (remote_notif_stop_parse): Make "buf" const.
11681 (remote_target::remote_parse_stop_reply): Make "buf" const.
11682 (remote_notif_stop_ack): Make "buf" const.
11683
11684 2019-01-14 Tom Tromey <tom@tromey.com>
11685
11686 * remote.c (remote_console_output): Make parameter const.
11687
11688 2019-01-14 Tom Tromey <tom@tromey.com>
11689
11690 * target-debug.h (target_debug_print_signals): Constify.
11691 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11692 * procfs.c (procfs_target::pass_signals): Update.
11693 * linux-nat.c (linux_nat_target::pass_signals): Update.
11694 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11695 * target-delegates.c: Rebuild.
11696 * remote.c (remote_target::program_signals): Update.
11697 (remote_target::pass_signals): Update.
11698 * target.c (target_pass_signals): Constify argument.
11699 (target_program_signals): Likewise.
11700 * target.h (struct target_ops) <pass_signals, program_signals>:
11701 Constify argument.
11702 (target_pass_signals, target_program_signals): Constify argument.
11703
11704 2019-01-14 Tom Tromey <tom@tromey.com>
11705
11706 PR tui/28819:
11707 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11708
11709 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
11710
11711 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11712 field.
11713 * rs6000-tdep.c: Include reggroups.h.
11714 (IS_V_ALIAS_PSEUDOREG): Define.
11715 (rs6000_register_name): Return names for the "vX" aliases.
11716 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11717 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
11718 aliases. Call default_register_reggroup_p for all other
11719 pseudo-registers.
11720 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11721 New functions.
11722 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11723 Handle "vX" aliases.
11724 (v_alias_pseudo_register_collect): New function.
11725 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11726 (rs6000_gdbarch_init): Initialize "vX" aliases as
11727 pseudo-registers. Restore registration of
11728 rs6000_pseudo_register_reggroup_p with
11729 set_tdesc_pseudo_register_reggroup_p.
11730
11731 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
11732
11733 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11734 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11735 set_gdbarch_num_pseudo_regs.
11736
11737 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11738
11739 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11740 Remove arg prefixname, add do_set and do_show.
11741 Add member functions set_list and show_list.
11742 * cli/cli-style.c (class cli_style_option): Update accordingly.
11743 (style_set_list): Move to file scope.
11744 (style_show_list): Likewise.
11745 (set_style): Call help_list.
11746 (show_style): Call cmd_show_list.
11747 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11748 Update to use the new macro.
11749
11750 2019-10-12 Joel Brobecker <brobecker@adacore.com>
11751
11752 * ada-lang.c (_initialize_ada_language): Expand the help text
11753 for the "catch exception" command.
11754
11755 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11756
11757 * symtab.c (matching_obj_sections): Initialize obj,
11758 declare it closer to its usage.
11759
11760 2019-01-10 Tom Tromey <tom@tromey.com>
11761
11762 * thread-iter.h (inf_threads_iterator): Use next_iterator.
11763 (basic_inf_threads_range): Remove.
11764 (inf_threads_range, inf_non_exited_threads_range)
11765 (safe_inf_threads_range): Use next_adapter.
11766
11767 2019-01-10 Keith Seitz <keiths@redhat.com>
11768
11769 PR gdb/23712
11770 PR symtab/23010
11771 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11772 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11773
11774 2019-01-10 Keith Seitz <keiths@redhat.com>
11775
11776 PR gdb/23712
11777 PR symtab/23010
11778 * dictionary.c (pending_to_vector): Remove.
11779 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11780 Remove _1 suffix, replacing functions of the same name. Update
11781 all callers.
11782 (dict_create_hashed, dict_create_hashed_expandable)
11783 (dict_create_linear, dict_create_linear_expandable, dict_free)
11784 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11785 Make functions static.
11786
11787 2019-01-10 Keith Seitz <keiths@redhat.com>
11788
11789 PR gdb/23712
11790 PR symtab/23010
11791 * dictionary.h (struct dictionary): Replace declaration with
11792 multidictionary.
11793 (dict_create_hashed, dict_create_hashed_expandable)
11794 (dict_create_linear, dict_create_linear_expandable)
11795 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11796 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11797 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11798 taking multidictionary argument.
11799 [ALL_DICT_SYMBOLS]: Update for multidictionary.
11800 * block.h (struct block) <dict>: Change to multidictionary
11801 and rename `multidict'.
11802 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11803 symmisc.c: Update all dictionary references to multidictionary.
11804
11805 2019-01-10 Keith Seitz <keiths@redhat.com>
11806
11807 PR gdb/23712
11808 PR symtab/23010
11809 * dictionary.c: Include unordered_map.
11810 (pending_to_vector): New function.
11811 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11812 Rewrite the non-"_1" functions to take vector instead
11813 of linked list.
11814 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11815 "new" _1 versions of the same name.
11816 (multidictionary): Define.
11817 (std::hash<enum language): New definition.
11818 (collate_pending_symbols_by_language, mdict_create_hashed)
11819 (mdict_create_hashed_expandable, mdict_create_linear)
11820 (mdict_create_linear_expandable, mdict_free)
11821 (find_language_dictionary, create_new_language_dictionary)
11822 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11823 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11824 (mdict_size, mdict_empty): New functions.
11825 * dictionary.h (mdict_iterator): Define.
11826
11827 2019-01-10 Pedro Alves <palves@redhat.com>
11828
11829 * breakpoint.c (read_uploaded_action)
11830 (create_tracepoint_from_upload): Adjust to use
11831 gdb::unique_xmalloc_ptr.
11832 * ctf.c (ctf_write_uploaded_tp):
11833 (SET_ARRAY_FIELD): Use emplace_back.
11834 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11835 * tracefile-tfile.c (tfile_write_uploaded_tp):
11836 * tracepoint.c (parse_tracepoint_definition): Adjust to use
11837 gdb::unique_xmalloc_ptr.
11838 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11839 at_string, cond_string, cmd_strings>: Replace char pointers
11840 with gdb::unique_xmalloc_ptr.
11841
11842 2019-01-10 Pedro Alves <palves@redhat.com>
11843
11844 * solib-target.c (library_list_start_library): Don't xstrdup name.
11845
11846 2019-01-10 Pedro Alves <palves@redhat.com>
11847
11848 * mdebugread.c (parse_partial_symbols): Use
11849 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11850
11851 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11852
11853 * linux-fork.c (scoped_switch_fork_info)
11854 <~scoped_switch_fork_info>: Fix incorrect variable name.
11855
11856 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11857
11858 * linux-fork.c (scoped_switch_fork_info)
11859 <scoped_switch_fork_info>: Make explicit.
11860 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11861
11862 2019-01-10 Tom Tromey <tom@tromey.com>
11863
11864 * objfiles.h (objfile::reset_psymtabs): Update.
11865 * objfiles.c (objfile::objfile): Update.
11866 * psymtab.h (psymtab_storage::obstack): Update.
11867 (psymtab_storage::m_obstack): Use gdb::optional.
11868 (class psymtab_storage): Update comment. Remove objfile
11869 parameter.
11870 * psymtab.c (psymtab_storage::psymtab_storage): Update.
11871
11872 2019-01-10 Tom Tromey <tom@tromey.com>
11873
11874 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11875 <free_psymtabs>: Now private.
11876 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11877 (allocate_psymtab): Use new method.
11878
11879 2019-01-10 Tom Tromey <tom@tromey.com>
11880
11881 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11882 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11883 * mdebugread.c (parse_partial_symbols): Use
11884 allocate_dependencies.
11885 * dwarf2read.c (dwarf2_create_include_psymtab): Use
11886 allocate_dependencies.
11887 (process_psymtab_comp_unit_reader)
11888 (build_type_psymtab_dependencies): Likewise.
11889 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11890
11891 2019-01-10 Tom Tromey <tom@tromey.com>
11892
11893 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11894 PSYMBOL_SET_LANGUAGE.
11895 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11896
11897 2019-01-10 Tom Tromey <tom@tromey.com>
11898
11899 * psymtab.h (psymtab_storage::obstack): New method.
11900 <m_obstack>: Rename from obstack; now private.
11901 * psymtab.c (psymtab_storage): Update.
11902 * dwarf2read.c (create_addrmap_from_index)
11903 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11904 Update.
11905
11906 2019-01-10 Tom Tromey <tom@tromey.com>
11907
11908 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11909 * objfiles.h (objfile::reset_psymtabs): New method.
11910
11911 2019-01-10 Tom Tromey <tom@tromey.com>
11912
11913 * symmisc.c (print_symbol_bcache_statistics): Update.
11914 (print_objfile_statistics): Update.
11915 * symfile.c (reread_symbols): Update.
11916 * psymtab.h (class psymtab_storage): New.
11917 * psymtab.c (psymtab_storage): New constructor.
11918 (~psymtab_storage): New destructor.
11919 (require_partial_symbols): Update.
11920 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11921 (find_pc_sect_psymtab, find_pc_sect_psymbol)
11922 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11923 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11924 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11925 (start_psymtab_common, end_psymtab_common)
11926 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11927 (allocate_psymtab): Update.
11928 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11929 Update.
11930 (dump_psymtab_addrmap, maintenance_print_psymbols)
11931 (maintenance_check_psymtabs): Update.
11932 (class objfile_psymtabs): Move to objfiles.h.
11933 * psympriv.h (discard_psymtab): Now inline.
11934 (psymtab_discarder::psymtab_discarder): Update.
11935 (psymtab_discarder::~psymtab_discarder): Update.
11936 (ALL_OBJFILE_PSYMTABS): Rewrite.
11937 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11938 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11939 Remove fields.
11940 <partial_symtabs>: New field.
11941 (class objfile_psymtabs): Move from psymtab.h. Update.
11942 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11943 psymbol_cache.
11944 (objfile::~objfile): Don't destroy psymbol_cache.
11945 * mdebugread.c (parse_partial_symbols): Update.
11946 * dwarf2read.c (create_addrmap_from_index)
11947 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11948 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11949 (add_partial_subprogram, dwarf2_ranges_read): Update.
11950 * dwarf-index-write.c (write_address_map)
11951 (write_one_signatured_type, recursively_write_psymbols)
11952 (class debug_names, class debug_names, write_psymtabs_to_index):
11953 Update.
11954
11955 2019-01-10 Tom Tromey <tom@tromey.com>
11956
11957 * symtab.h (SYMBOL_SET_NAMES): Update.
11958 (symbol_set_names): Update.
11959 (MSYMBOL_SET_NAMES): Update.
11960 * symtab.c (symbol_set_names): Change argument to be an
11961 objfile_per_bfd_storage.
11962 * psymtab.c (add_psymbol_to_bcache): Update.
11963 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11964
11965 2019-01-10 Tom Tromey <tom@tromey.com>
11966
11967 * symtab.c (create_demangled_names_hash): Change argument to be an
11968 objfile_per_bfd_storage.
11969 (symbol_set_names): Update.
11970
11971 2019-01-10 Tom Tromey <tom@tromey.com>
11972
11973 * xcoffread.c (xcoff_initial_scan): Unconditionally call
11974 init_psymbol_list.
11975 * psymtab.c (init_psymbol_list): Do nothing if already called.
11976 * psympriv.h (init_psymbol_list): Add comment.
11977 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11978 init_psymbol_list.
11979 * dbxread.c (dbx_symfile_read): Unconditionally call
11980 init_psymbol_list.
11981
11982 2019-01-10 Tom Tromey <tom@tromey.com>
11983
11984 * xcoffread.c (scan_xcoff_symtab): Update.
11985 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11986 "where".
11987 * mdebugread.c (parse_partial_symbols)
11988 (handle_psymbol_enumerators): Update.
11989 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11990 * dbxread.c (read_dbx_symtab): Update.
11991 * psympriv.h (psymbol_placement): New enum.
11992 (add_psymbol_to_list): Update.
11993
11994 2019-01-10 Tom Tromey <tom@tromey.com>
11995
11996 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11997 static_psymbols parameters.
11998 (scan_xcoff_symtab): Update.
11999 * psymtab.c (start_psymtab_common): Remove global_psymbols and
12000 static_psymbols parameters.
12001 * psympriv.h (start_psymtab_common): Update.
12002 * mdebugread.c (parse_partial_symbols): Update.
12003 * dwarf2read.c (create_partial_symtab): Update.
12004 * dbxread.c (read_dbx_symtab): Update.
12005 (start_psymtab): Remove global_psymbols and static_psymbols
12006 parameters.
12007
12008 2019-01-10 Tom Tromey <tom@tromey.com>
12009
12010 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12011 * psymtab.c (allocate_psymtab): Add comment.
12012 * psympriv.h (allocate_psymtab): Add comment.
12013 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12014 initializations.
12015 * dbxread.c (dbx_end_psymtab): Remove some initializations.
12016
12017 2019-01-10 Tom Tromey <tom@tromey.com>
12018
12019 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12020 Don't declare.
12021 * mipsread.c: Include mdebugread.h.
12022 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12023 Declare.
12024 * elfread.c: Include mdebugread.h.
12025
12026 2019-01-09 Tom Tromey <tom@tromey.com>
12027
12028 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12029 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12030 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12031 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12032 (psym_lookup_symbol, psym_find_last_source_symtab)
12033 (psym_forget_cached_source_info, psym_print_stats)
12034 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12035 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12036 (psym_map_matching_symbols, psym_expand_symtabs_matching)
12037 (psym_find_compunit_symtab_by_address)
12038 (maintenance_print_psymbols, maintenance_info_psymtabs)
12039 (maintenance_check_psymtabs): Use ranged for.
12040 * psymtab.h (class objfile_psymtabs): New.
12041 (require_partial_symbols): Return objfile_psymtabs.
12042 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12043
12044 2019-01-09 Tom Tromey <tom@tromey.com>
12045
12046 * symfile.c (overlay_invalidate_all, find_pc_overlay)
12047 (find_pc_mapped_section, list_overlays_command)
12048 (map_overlay_command, unmap_overlay_command)
12049 (simple_overlay_update): Use all_objfiles.
12050 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12051 * printcmd.c (info_symbol_command): Use all_objfiles.
12052 * objfiles.h (ALL_OBJSECTIONS): Remove.
12053 * maint.c (maintenance_translate_address): Use all_objfiles.
12054 * gcore.c (gcore_create_callback): Use all_objfiles.
12055 (objfile_find_memory_regions): Likewise.
12056
12057 2019-01-09 Tom Tromey <tom@tromey.com>
12058
12059 * symtab.c (find_line_symtab, info_sources_command)
12060 (make_source_files_completion_list): Use objfile_compunits.
12061 * source.c (select_source_symtab): Use objfile_compunits.
12062 * objfiles.h (struct objfile): Update comment.
12063 (ALL_OBJFILES): Remove.
12064 (ALL_FILETABS): Remove.
12065 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12066 objfile_compunits.
12067
12068 2019-01-09 Tom Tromey <tom@tromey.com>
12069
12070 * symmisc.c (print_objfile_statistics, dump_objfile)
12071 (maintenance_print_symbols): Use compunit_filetabs.
12072 * source.c (forget_cached_source_info_for_objfile): Use
12073 compunit_filetabs.
12074 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12075 (ALL_FILETABS): Use compunit_filetabs.
12076 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12077 * coffread.c (coff_symtab_read): Use compunit_filetabs.
12078
12079 2019-01-09 Tom Tromey <tom@tromey.com>
12080
12081 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12082 (compunit_filetabs): New.
12083 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12084 compunit_filetabs.
12085 (info_sources_command, make_source_files_completion_list): Remove
12086 declaration.
12087 * symmisc.c (print_objfile_statistics, dump_objfile)
12088 (maintenance_print_symbols): Remove declaration.
12089 (maintenance_info_symtabs): Use compunit_filetabs.
12090 (maintenance_info_line_tables): Likewise.
12091 * source.c (select_source_symtab): Change local variable name.
12092 (forget_cached_source_info_for_objfile): Remove declaration.
12093 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12094 * objfiles.c (objfile_relocate1): Remove declaration.
12095 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12096 declaration.
12097 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12098 * coffread.c (coff_symtab_read): Remove declaration.
12099 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12100 compunit_filetabs.
12101
12102 2019-01-09 Tom Tromey <tom@tromey.com>
12103
12104 * symtab.c (lookup_objfile_from_block)
12105 (find_pc_sect_compunit_symtab, search_symbols)
12106 (default_collect_symbol_completion_matches_break_on): Use
12107 objfile_compunits.
12108 * objfiles.h (ALL_COMPUNITS): Remove.
12109 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12110 * cp-support.c (add_symbol_overload_list_qualified): Use
12111 objfile_compunits.
12112 * ada-lang.c (ada_collect_symbol_completion_matches)
12113 (ada_add_global_exceptions): Use objfile_compunits.
12114
12115 2019-01-09 Tom Tromey <tom@tromey.com>
12116
12117 * source.c (select_source_symtab)
12118 (forget_cached_source_info_for_objfile): Remove declaration.
12119 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12120 declaration.
12121 * maint.c (count_symtabs_and_blocks): Remove declaration.
12122 * cp-support.c (add_symbol_overload_list_qualified): Remove
12123 declaration.
12124 * coffread.c (coff_symtab_read): Remove declaration.
12125 * symtab.c (lookup_symbol_in_objfile_symtabs)
12126 (basic_lookup_transparent_type_1): Use objfile_compunits.
12127 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12128 (info_sources_command, search_symbols)
12129 (default_collect_symbol_completion_matches_break_on)
12130 (make_source_files_completion_list): Remove declaration.
12131 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12132 (ada_collect_symbol_completion_matches)
12133 (ada_add_global_exceptions): Remove declaration.
12134 * linespec.c (iterate_over_all_matching_symtabs): Use
12135 objfile_compunits.
12136 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12137 (class objfile_compunits): New.
12138 (ALL_COMPUNITS): Use objfile_compunits.
12139 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12140 (maintenance_check_symtabs, maintenance_info_line_tables): Use
12141 objfile_compunits.
12142 * objfiles.c (objfile_relocate1): Use objfile_compunits.
12143
12144 2019-01-09 Tom Tromey <tom@tromey.com>
12145
12146 * symtab.c (search_symbols)
12147 (default_collect_symbol_completion_matches_break_on): Use
12148 objfile_msymbols.
12149 * ada-lang.c (ada_lookup_simple_minsym)
12150 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12151 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12152 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12153 objfile_msymbols.
12154 * coffread.c (coff_symfile_read): Use objfile_msymbols.
12155 * symmisc.c (dump_msymbols): Use objfile_msymbols.
12156 * objc-lang.c (find_methods): Use objfile_msymbols.
12157 (info_selectors_command, info_classes_command): Likewise.
12158 * stabsread.c (scan_file_globals): Use objfile_msymbols.
12159 * objfiles.h (class objfile_msymbols): New.
12160 (ALL_OBJFILE_MSYMBOLS): Remove.
12161 (ALL_MSYMBOLS): Remove.
12162
12163 2019-01-09 Tom Tromey <tom@tromey.com>
12164
12165 * common/next-iterator.h (next_adapter): Add Iterator template
12166 parameter.
12167 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12168 (class all_objfiles_safe): New.
12169 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12170 * objfiles.c (put_objfile_before): Update comment.
12171 (add_separate_debug_objfile): Likewise.
12172 (free_all_objfiles): Use all_objfiles_safe.
12173 (objfile_purge_solibs): Likewise.
12174
12175 2019-01-09 Tom Tromey <tom@tromey.com>
12176
12177 * symtab.c (iterate_over_symtabs, matching_obj_sections)
12178 (expand_symtab_containing_pc, lookup_static_symbol)
12179 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12180 (find_symbol_at_address, find_line_symtab, find_main_name): Use
12181 all_objfiles.
12182 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12183 * breakpoint.c (create_overlay_event_breakpoint)
12184 (create_longjmp_master_breakpoint)
12185 (create_std_terminate_master_breakpoint)
12186 (create_exception_master_breakpoint): Use all_objfiles.
12187 * linux-thread-db.c (try_thread_db_load_from_pdir)
12188 (has_libpthread): Use all_objfiles.
12189 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12190 * linespec.c (iterate_over_all_matching_symtabs)
12191 (search_minsyms_for_name): Use all_objfiles.
12192 * maint.c (maintenance_info_sections): Use all_objfiles.
12193 * main.c (captured_main_1): Use all_objfiles.
12194 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12195 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12196 * guile/scm-pretty-print.c
12197 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12198 * solib-spu.c (append_ocl_sos): Use all_objfiles.
12199 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12200 (maintenance_print_msymbols): Use all_objfiles.
12201 * source.c (select_source_symtab): Use all_objfiles.
12202 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12203 * symfile.c (remove_symbol_file_command)
12204 (expand_symtabs_matching, map_symbol_filenames): Use
12205 all_objfiles.
12206 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12207 all_objfiles.
12208 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12209 * objc-lang.c (find_methods): Use all_objfiles.
12210 * objfiles.c (have_partial_symbols, have_full_symbols)
12211 (have_minimal_symbols, qsort_cmp)
12212 (default_iterate_over_objfiles_in_search_order): Use
12213 all_objfiles.
12214 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12215 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12216 (maintenance_check_psymtabs): Use all_objfiles.
12217 (ALL_PSYMTABS): Remove.
12218 * compile/compile-object-run.c (do_module_cleanup): Use
12219 all_objfiles.
12220 * blockframe.c (find_pc_partial_function): Use all_objfiles.
12221 * cp-support.c (add_symbol_overload_list_qualified): Use
12222 all_objfiles.
12223 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12224 Use all_objfiles.
12225 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12226 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12227 all_objfiles.
12228 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12229 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12230 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12231 Uses all_objfiles.
12232 * solib.c (solib_read_symbols): Use all_objfiles
12233
12234 2019-01-09 Tom Tromey <tom@tromey.com>
12235
12236 * probe.c (parse_probes_in_pspace): Use all_objfiles.
12237 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12238 all_objfiles.
12239 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12240 * symmisc.c (print_symbol_bcache_statistics)
12241 (print_objfile_statistics, maintenance_print_objfiles)
12242 (maintenance_info_symtabs, maintenance_check_symtabs)
12243 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12244 all_objfiles.
12245 * source.c (forget_cached_source_info): Use all_objfiles.
12246 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12247 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12248 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12249 * objfiles.c (update_section_map): Use all_objfiles.
12250 (shared_objfile_contains_address_p): Likewise.
12251 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12252 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12253
12254 2019-01-09 Tom Tromey <tom@tromey.com>
12255
12256 * common/next-iterator.h: New file.
12257 * objfiles.h (class all_objfiles): New.
12258 (struct objfile_iterator): New.
12259
12260 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12261
12262 * NEWS: Move the description of the changed "frame", "select-frame",
12263 and "info frame" commands to the Changed commands section.
12264
12265 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
12266
12267 * gdbtypes.c (check_stub_method_group): Remove handling of old
12268 mangling schemes.
12269 * linespec.c (find_methods): Likewise.
12270 * stabsread.c (read_member_functions): Likewise.
12271 * valops.c (search_struct_method): Likewise.
12272 (value_struct_elt_for_reference): Likewise.
12273 * NEWS: Mention this change.
12274
12275 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
12276
12277 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12278 print_source_lines.
12279 * source.c (print_source_lines_base): Update line number check.
12280 (print_source_lines): New function.
12281 (source_lines_range::source_lines_range): New function.
12282 * source.h (class source_lines_range): New class.
12283 (print_source_lines): New declaration.
12284
12285 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12286
12287 * linespec.c (linespec_state_destructor): Free self->canonical_names.
12288
12289 2019-01-08 Tom Tromey <tom@tromey.com>
12290 Simon Marchi <simon.marchi@ericsson.com>
12291
12292 PR gdb/24060
12293 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12294 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12295 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12296 * f-exp.y (DOLLAR_VARIABLE): Likewise.
12297 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12298 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12299
12300 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12301
12302 * source.c (select_source_symtab): Move header comment to
12303 declaration in source.h.
12304 (forget_cached_source_info_for_objfile): Likewise.
12305 (forget_cached_source_info): Likewise.
12306 (identify_source_line): Likewise.
12307 * source.h (identify_source_line): Move declaration from symtab.h
12308 and add comment from source.c
12309 (print_source_lines): Likewise.
12310 (forget_cached_source_info_for_objfile): Likewise.
12311 (forget_cached_source_info): Likewise.
12312 (select_source_symtab): Likewise.
12313 (enum print_source_lines_flag): Move definition from symtab.h.
12314 * symtab.h (identify_source_line): Move declaration to source.h.
12315 (print_source_lines): Likewise.
12316 (forget_cached_source_info_for_objfile): Likewise.
12317 (forget_cached_source_info): Likewise.
12318 (select_source_symtab): Likewise.
12319 (enum print_source_lines_flag): Move definition to source.h.
12320 * tui/tui-hooks.c: Add 'source.h' include.
12321
12322 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12323
12324 * source.c (print_source_lines_base): Handle requests to print
12325 reverse line number sequences, and guard against empty lines
12326 string.
12327
12328 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12329
12330 * source.c (print_source_lines_base): Fix skip of '\r' if next
12331 character is '\n'.
12332
12333 2019-01-06 Tom Tromey <tom@tromey.com>
12334
12335 * c-exp.y (struct c_parse_state) <macro_original_text,
12336 expansion_obstack>: New member.
12337 (macro_original_text, expansion_obstack): Remove globals.
12338 (scan_macro_expansion, scanning_macro_expansion)
12339 (finished_macro_expansion): Update.
12340 (scan_macro_cleanup): Remove.
12341 (yylex, c_parse): Update.
12342
12343 2019-01-06 Tom Tromey <tom@tromey.com>
12344
12345 * c-exp.y (struct c_parse_state) <strings>: New member.
12346 (operator_stoken): Update.
12347
12348 2019-01-06 Tom Tromey <tom@tromey.com>
12349
12350 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
12351 (union type_stack_elt) <typelist_val>: Now a pointer to
12352 std::vector.
12353 (type_stack_cleanup): Don't declare.
12354 (push_typelist): Update.
12355 * parse.c (pop_typelist): Return a std::vector.
12356 (push_typelist): Take a std::vector.
12357 (follow_types): Update. Do not free args.
12358 (type_stack_cleanup): Remove.
12359 * c-exp.y (struct c_parse_state): New.
12360 (cpstate): New global.
12361 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12362 (nonempty_typelist): Update.
12363 (func_mod): Create a new vector.
12364 (c_parse): Create a c_parse_state.
12365 (check_parameter_typelist): Do not delete params.
12366 (function_method): Update. Do not delete type_list.
12367
12368 2019-01-06 Tom Tromey <tom@tromey.com>
12369
12370 PR gdb/28155:
12371 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12372 check_typedef.
12373 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12374 (print_return_value): Likewise.
12375
12376 2019-01-05 Tom Tromey <tom@tromey.com>
12377
12378 * contrib/cleanup_check.py: Remove.
12379 * contrib/gcc-with-excheck: Remove.
12380 * contrib/exsummary.py: Remove.
12381 * contrib/excheck.py: Remove.
12382
12383 2019-01-05 Joel Brobecker <brobecker@adacore.com>
12384
12385 * thread.c (delete_thread_1): Add gdb_assert that THR is not
12386 NULL. Initialize tpprev to NULL instead of assigning it
12387 to NULL on the next statement.
12388 * windows-nat.c (windows_delete_thread): Remove check for
12389 main_thread_id before printing thread exit notifications.
12390 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12391 Remove thread ID check against main_thread_id.
12392 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12393 windows_delete_thread.
12394 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12395
12396 2019-01-04 Tom Tromey <tom@tromey.com>
12397
12398 * compile/compile.c (_initialize_compile): Use upper case for
12399 metasyntactic variables.
12400 * symmisc.c (_initialize_symmisc): Use upper case for
12401 metasyntactic variables.
12402 * psymtab.c (_initialize_psymtab): Use upper case for
12403 metasyntactic variables.
12404 * demangle.c (demangle_command): Use upper case for metasyntactic
12405 variables.
12406 (_initialize_demangler): Likewise.
12407 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12408 variables.
12409
12410 2019-01-03 Tom Tromey <tom@tromey.com>
12411
12412 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12413
12414 2019-01-03 Tom Tromey <tom@tromey.com>
12415
12416 * python/py-symtab.c (salpy_str): Update.
12417 (struct salpy_sal_object) <symtab>: Now a PyObject.
12418 (salpy_dealloc): Update.
12419 (del_objfile_sal): Use gdbpy_ref.
12420
12421 2019-01-03 Tom Tromey <tom@tromey.com>
12422
12423 * python/py-type.c (convert_field): Use new_reference. Return
12424 gdbpy_ref.
12425 (make_fielditem): Return gdbpy_ref.
12426 (typy_fields): Update.
12427 (typy_getitem): Update.
12428 (field_name): Return gdbpy_ref. Use new_reference.
12429 (typy_iterator_iternext): Update.
12430
12431 2019-01-03 Tom Tromey <tom@tromey.com>
12432
12433 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12434
12435 2019-01-03 Tom Tromey <tom@tromey.com>
12436
12437 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12438 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12439 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12440 (pspy_set_frame_filters, pspy_set_frame_unwinders)
12441 (pspy_set_type_printers): Likewise.
12442 * python/py-function.c (fnpy_init): Use gdbpy_ref.
12443 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12444 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12445 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12446 (objfpy_set_type_printers): Likewise.
12447
12448 2019-01-03 Tom Tromey <tom@tromey.com>
12449
12450 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12451 (gdbpy_print_stack): Use gdbpy_err_fetch.
12452 * python/python-internal.h (class gdbpy_err_fetch): New class.
12453 (class gdbpy_enter) <m_error_type, m_error_value,
12454 m_error_traceback>: Remove.
12455 <m_error>: New member.
12456 (gdbpy_exception_to_string): Don't declare.
12457 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12458 * python/py-value.c (convert_value_from_python): Use
12459 gdbpy_err_fetch.
12460 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12461 gdbpy_exception_to_string.
12462 (gdbpy_handle_exception): Use gdbpy_err_fetch.
12463 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12464 gdbpy_err_fetch.
12465
12466 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12467
12468 * linux-nat.c (delete_lwp_cleanup): Delete.
12469 (struct lwp_deleter): New struct.
12470 (lwp_info_up): New typedef.
12471 (linux_nat_target::follow_fork): Delete cleanup, and make use of
12472 lwp_info_up.
12473
12474 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12475
12476 * linux-fork.c (class scoped_switch_fork_info): New class.
12477 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12478
12479 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12480
12481 * valops.c (find_overload_match): Remove use of null_cleanup, and
12482 calls to do_cleanups.
12483
12484 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12485
12486 * compile/compile-cplus-types.c
12487 (compile_cplus_instance::decl_name): Handle changes to
12488 cp_func_name.
12489 * cp-support.c (cp_func_name): Update header comment, update
12490 return type.
12491 * cp-support.h (cp_func_name): Update return type in declaration.
12492 * valops.c (find_overload_match): Move temp_func local to top
12493 level of function and change its type. Use temp_func to hold and
12494 delete temporary string obtained from cp_func_name.
12495
12496 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12497
12498 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12499 gdb::char_vector, remove cleanup, and update uses of `msg`.
12500
12501 2019-01-03 Jim Wilson <jimw@sifive.com>
12502
12503 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12504
12505 2019-01-02 Tom Tromey <tom@tromey.com>
12506
12507 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12508 (tdesc_parse_xml): Remove cleanups.
12509 * target-descriptions.h (make_cleanup_free_target_description):
12510 Don't declare.
12511 (target_desc_deleter): New struct.
12512 (target_desc_up): New typedef.
12513 * target-descriptions.c (target_desc_deleter::operator()): Rename
12514 from free_target_description.
12515 (make_cleanup_free_target_description): Remove.
12516
12517 2019-01-02 Tom Tromey <tom@tromey.com>
12518
12519 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
12520 constructor, destructor.
12521 (linespec_parser): Remove typedef.
12522 (~linespec_parser): Rename from linespec_parser_delete.
12523 (linespec_lex_to_end, linespec_complete_label)
12524 (linespec_complete): Update.
12525 (decode_line_full): Remove cleanups.
12526 (decode_line_1): Update.
12527
12528 2019-01-02 Tom Tromey <tom@tromey.com>
12529
12530 * python/python-internal.h (inferior_to_inferior_object): Change
12531 return type.
12532 * python/py-exitedevent.c (create_exited_event_object): Update.
12533 * python/py-inferior.c (inferior_to_inferior_object): Return
12534 gdbpy_ref.
12535 (python_new_inferior, python_inferior_deleted)
12536 (thread_to_thread_object, delete_thread_object)
12537 (build_inferior_list, gdbpy_selected_inferior): Update.
12538 * python/py-infthread.c (create_thread_object): Update. Also fail
12539 if inferior_to_inferior_object fails.
12540
12541 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
12542
12543 * inferior.h (class inferior) <displaced_step_state>: New field.
12544 * infrun.h (struct displaced_step_state): Move here from
12545 infrun.c. Initialize fields, add constructor.
12546 <inf>: Remove field.
12547 <reset>: New method.
12548 * infrun.c (struct displaced_step_inferior_state): Move to
12549 infrun.h.
12550 (displaced_step_inferior_states): Remove.
12551 (get_displaced_stepping_state): Adust.
12552 (displaced_step_in_progress_any_inferior): Adjust.
12553 (displaced_step_in_progress_thread): Adjust.
12554 (displaced_step_in_progress): Adjust.
12555 (add_displaced_stepping_state): Remove.
12556 (get_displaced_step_closure_by_addr): Adjust.
12557 (remove_displaced_stepping_state): Remove.
12558 (infrun_inferior_exit): Call displaced_step_state.reset.
12559 (use_displaced_stepping): Don't check for NULL.
12560 (displaced_step_prepare_throw): Call
12561 get_displaced_stepping_state.
12562 (displaced_step_fixup): Don't check for NULL.
12563 (prepare_for_detach): Don't check for NULL.
12564
12565 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12566
12567 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12568 in case of call that did not complete.
12569
12570 2019-01-02 Andrey Utkin <autkin@undo.io>
12571
12572 * symfile.c (find_separate_debug_file): Fix search of debug files for
12573 remote debuggee.
12574
12575 2019-01-02 Tom Tromey <tom@tromey.com>
12576
12577 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12578 indentation.
12579 * python/py-frame.c (frapy_older): Remove cast.
12580 (frapy_newer): Likewise.
12581 * python/py-breakpoint.c (local_setattro): Remove cast.
12582 * python/py-arch.c (archpy_name): Remove local variable.
12583 * python/py-type.c (gdbpy_lookup_type): Remove cast.
12584
12585 2019-01-02 Joel Brobecker <brobecker@adacore.com>
12586
12587 * unittests/basic_string_view/element_access/char/empty.cc:
12588 Fix year range in copyright header.
12589
12590 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
12591
12592 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12593 Delete.
12594 <operator==>: Update with for removed field.
12595 <hash>: Likewise.
12596 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12597 <isa_features>: ...this.
12598 <abi_features>: New field.
12599 (riscv_isa_flen): Update comment.
12600 (riscv_abi_xlen): New declaration.
12601 (riscv_abi_flen): New declaration.
12602 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12603 isa_features.
12604 (riscv_abi_xlen): New function.
12605 (riscv_isa_flen): Update to get answer from isa_features.
12606 (riscv_abi_flen): New function.
12607 (riscv_has_fp_abi): Update to get answer from abi_features.
12608 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12609 xlen and flen.
12610 (riscv_call_info) <xlen, flen>: Update comment.
12611 (riscv_call_arg_struct): Remove invalid assertions
12612 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12613 is removed.
12614 (riscv_gdbarch_init): Gather isa features and abi features
12615 separately, ensure both match on the gdbarch when reusing an old
12616 gdbarch. Relax an error check to allow 32-bit abi float to run on
12617 a target with 64-bit float hardware.
12618
12619 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12620
12621 * source.c (search_command_helper): Stop reverse search
12622 when line 1 has been searched.
12623
12624 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12625
12626 * record-full.c (record_full_base_target::close): Rewrite
12627 record_full_core_buf_list free logic.
12628
12629 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12630
12631 * break-catch-syscall.c (print_one_catch_syscall): xfree
12632 the last text.
12633
12634 2019-01-01 Joel Brobecker <brobecker@adacore.com>
12635
12636 * top.c (print_gdb_version): Update Copyright year in version
12637 message.
12638
12639 2019-01-01 Joel Brobecker <brobecker@adacore.com>
12640
12641 Update copyright year range in all GDB files.
12642
12643 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
12644
12645 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12646
12647 For older changes see ChangeLog-2018.
12648 \f
12649 Local Variables:
12650 mode: change-log
12651 left-margin: 8
12652 fill-column: 74
12653 version-control: never
12654 coding: utf-8
12655 End:
12656