gdb/ChangeLog

   1 2019-08-30  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-stack.c (_initialize_tui_stack): Move later.
   4         Remove unnecessary forward declarations.
   5
   6 2019-08-30  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
   9         rerender.
  10         (tui_update_locator_fullname, tui_show_frame_info): Don't call
  11         tui_show_locator_content.
  12
  13 2019-08-30  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
  16         (tui_locator_window::rerender): Rewrite using body of previous
  17         tui_show_locator_content.
  18
  19 2019-08-30  Tom Tromey  <tom@tromey.com>
  20
  21         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
  22         set_locator_fullname>: New methods.
  23         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
  24         Rename from tui_set_locator_fullname.
  25         (tui_locator_window::set_locator_info): Rename from
  26         tui_set_locator_info.  Return bool.
  27         (tui_update_locator_fullname, tui_show_frame_info): Update.
  28
  29 2019-08-30  Tom Tromey  <tom@tromey.com>
  30
  31         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
  32
  33 2019-08-30  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
  36         call touchwin.
  37
  38 2019-08-30  Tom Tromey  <tom@tromey.com>
  39
  40         * tui/tui-wingeneral.c (box_win): Assume win_info and
  41         win_info->handle cannot be NULL.
  42
  43 2019-08-30  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
  46         refresh_window>: Declare.
  47         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
  48         resize.
  49         (tui_data_item_window::rerender): Rename from
  50         tui_display_register.
  51         (tui_data_item_window::refresh_window): New method.
  52         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
  53         no-op.
  54
  55 2019-08-30  Tom Tromey  <tom@tromey.com>
  56
  57         * tui/tui-regs.h (struct tui_data_window) <regs_content,
  58         regs_column_count, current_group>: Move later.  Now private.
  59         <get_current_group>: New method.
  60         * tui/tui-regs.c (tui_reg_command): Update.
  61         * tui/tui-layout.c (tui_set_layout): Update.
  62
  63 2019-08-30  Tom Tromey  <tom@tromey.com>
  64
  65         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
  66         (tui_data_window::rerender): Don't call
  67         check_and_display_highlight_if_needed.
  68         (tui_data_window::refresh_all): Remove call to
  69         erase_data_content.
  70
  71 2019-08-30  Tom Tromey  <tom@tromey.com>
  72
  73         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
  74         (tui_data_window::display_registers_from)
  75         (tui_data_window::display_reg_element_at_line)
  76         (tui_data_window::display_registers_from_line): Remove checks of
  77         "empty".
  78
  79 2019-08-30  Tom Tromey  <tom@tromey.com>
  80
  81         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
  82         Don't declare.
  83         * tui/tui-regs.c (tui_data_window::show_registers): Call
  84         rerender.
  85         (tui_data_window::rerender): Rename from display_all_data.
  86         (tui_data_window::rerender): Remove old implementation.
  87
  88 2019-08-30  Tom Tromey  <tom@tromey.com>
  89
  90         * tui/tui-regs.c (tui_data_window::display_all_data): Change
  91         text.
  92         * tui/tui-data.h (NO_DATA_STRING): Remove define.
  93
  94 2019-08-29  Bernhard Wodok  <barto@gmx.net>
  95             Sergio Durigan Junior  <sergiodj@redhat.com>
  96
  97         PR win32/24284
  98         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
  99
 100 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 101
 102         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 103         when searching for types.
 104
 105 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 106
 107         * f-lang.c (f_language_defn): Use f_print_typedef.
 108         * f-lang.h (f_print_typedef): Declare.
 109         * f-typeprint.c (f_print_typedef): Define.
 110
 111 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 112
 113         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 114
 115 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 116
 117         * cli/cli-utils.c (info_print_options_defs): Delete.
 118         (make_info_print_options_def_group): Delete.
 119         (extract_info_print_options): Delete.
 120         (info_print_command_completer): Delete.
 121         (info_print_args_help): Add extra parameter, and optionally
 122         include text about -n flag.
 123         * cli/cli-utils.h (struct info_print_options): Delete.
 124         (extract_info_print_options): Delete declaration.
 125         (info_print_command_completer): Delete declaration.
 126         (info_print_args_help): Add extra parameter, extend header
 127         comment.
 128         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 129         search_symbols.
 130         * stack.c (struct info_print_options): New type.
 131         (info_print_options_defs): New file scoped variable.
 132         (make_info_print_options_def_group): New static function.
 133         (info_print_command_completer): New static function.
 134         (info_locals_command): Update to use new local functions.
 135         (info_args_command): Likewise.
 136         (_initialize_stack): Add extra parameter to calls to
 137         info_print_args_help.
 138         * symtab.c (search_symbols): Add extra parameter, use this to
 139         possibly excluse non-debug symbols.
 140         (symtab_symbol_info): Add extra parameter, which is passed on to
 141         search_symbols.
 142         (struct info_print_options): New type.
 143         (info_print_options_defs): New file scoped variable.
 144         (make_info_print_options_def_group): New static function.
 145         (info_print_command_completer): New static function.
 146         (info_variables_command): Update to use local functions, and pass
 147         extra parameter through to symtab_symbol_info.
 148         (info_functions_command): Likewise.
 149         (info_types_command): Pass additional argument through to
 150         symtab_symbol_info.
 151         (rbreak_command): Pass extra argument to search_symbols.
 152         (_initialize_symtab): Add extra arguments for calls to
 153         info_print_args_help, and update help text for 'info variables',
 154         'whereis', and 'info functions' commands.
 155         * symtab.h (search_symbols): Add extra argument to declaration.
 156         * NEWS: Mention new flags.
 157
 158 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 159
 160         * symtab.c (lookup_static_symbol): Call the new function (and move
 161         it down to be next to lookup_global_symbol).
 162         (struct global_sym_lookup_data): Add block_enum member and rename to...
 163         (struct global_or_static_sym_lookup_data): ...this.
 164         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 165         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 166         (lookup_symbol_global_or_static_iterator_cb): ...this.
 167         (lookup_global_or_static_symbol): New function.
 168         (lookup_global_symbol): Call new function.
 169
 170 2019-08-26  Tom de Vries  <tdevries@suse.de>
 171
 172         PR c++/24852
 173         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 174         when pc_probe.prob == NULL.
 175
 176 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 177
 178         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 179         variable symbol_linkage to symbol_linkage_.
 180
 181 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 182
 183         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 184         represent whether the symbol is static, dynamic, or we don't
 185         know.
 186
 187 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 188
 189         * gdb/rx-tdep.c (rx_register_names): New.
 190         (rx_register_name): Delete.
 191         (rx_psw_type): Delete.
 192         (rx_fpsw_type): Delete.
 193         (rx_register_type): Delete.
 194         (rx_gdbarch_init): Convert target-descriptions.
 195         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 196         * gdb/features/Makefile: Add rx.xml.
 197         * gdb/features/rx.xml: New.
 198         * gdb/features/rx.c: Generated.
 199         * gdb/NEWS: Mention target description support.
 200
 201 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 202
 203         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 204         *slot_ptr.
 205
 206 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 207
 208         * configure.ac: Don't check for 'dlfcn.h' (moved to
 209         gdbsupport/common.m4).
 210         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 211         'gdbsupport/'.
 212         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 213         * compile/compile-c-support.c: Include
 214         'gdbsupport/gdb-dlfcn.h'.
 215         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 216         * gdb-dlfcn.c: Move to...
 217         * gdbsupport/gdb-dlfcn.c: ... here.
 218         * gdb-dlfcn.h: Move to...
 219         * gdbsupport/gdb-dlfcn.h: ... here.
 220
 221 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 222
 223         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 224         the offset field signed.
 225
 226 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 227
 228         * python/lib/gdb/__init__.py (_execute_file): New function.
 229         * python/python.c (python_run_simple_file): Call gdb._execute_file
 230         on Windows.
 231
 232 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 233
 234         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 235         all uses as this was never set to anything but a zero value.
 236
 237 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 238
 239         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 240
 241 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 242
 243         * tui/tui-data.h (tui_gen_win_info): Add an =default
 244         move constructor, required by some GCC versions.
 245
 246 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 247
 248         * go32-nat.c (go32_sysinfo): Add hygon_p.
 249
 250 2019-08-20  Tom Tromey  <tom@tromey.com>
 251
 252         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 253         line_from_reg_element_no, first_reg_element_no_inline,
 254         display_all_data, delete_data_content_windows,
 255         erase_data_content>: Now private.
 256
 257 2019-08-20  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 260         (tui_unhighlight_win, tui_highlight_win)
 261         (tui_win_info::make_window): Update.
 262         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 263
 264 2019-08-20  Tom Tromey  <tom@tromey.com>
 265
 266         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 267         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 268         (MAX_PID_WIDTH): Move to tui-stack.c.
 269         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 270         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 271         (MAX_PID_WIDTH): Move from tui-data.h.
 272
 273 2019-08-20  Tom Tromey  <tom@tromey.com>
 274
 275         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 276         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 277         (box_win): Update.
 278         (tui_gen_win_info::make_window): Rename from tui_make_window.
 279         (tui_win_info::make_window): New method.
 280         (tui_gen_win_info::make_visible): Update.
 281         * tui/tui-source.c (tui_source_window::set_contents): Update.
 282         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 283         (tui_data_window::display_registers_from): Update.
 284         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 285         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 286         Declare.
 287         <can_box>: Remove.
 288         <title>: Remove.
 289         (struct tui_win_info) <make_window>: Declare.
 290         <can_box>: Now virtual.
 291         <title>: New member.
 292         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 293         * tui/tui-command.c (tui_cmd_window::resize): Update.
 294
 295 2019-08-20  Tom Tromey  <tom@tromey.com>
 296
 297         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 298         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 299         (tui_data_window::check_register_values): Update.
 300
 301 2019-08-20  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-regs.h (struct tui_data_window): Use
 304         DISABLE_COPY_AND_ASSIGN.
 305         <regs_content>: Change type, removing unique_ptr.
 306         <tui_data_window>: Add move constructor.
 307         * tui/tui-regs.c (tui_data_window::show_registers)
 308         (tui_data_window::show_register_group)
 309         (tui_data_window::display_registers_from)
 310         (tui_data_window::display_registers_from)
 311         (tui_data_window::first_data_item_displayed)
 312         (tui_data_window::delete_data_content_windows)
 313         (tui_data_window::rerender, tui_data_window::refresh_window)
 314         (tui_data_window::check_register_values): Update.
 315
 316 2019-08-20  Tom Tromey  <tom@tromey.com>
 317
 318         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 319         show_register_group>: Declare.
 320         (tui_show_register_group): Don't declare.
 321         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 322         tui_show_registers.
 323         (tui_data_window::show_register_group): Rename from
 324         tui_show_register_group.
 325         (tui_data_window::check_register_values, tui_reg_command):
 326         Update.
 327         * tui/tui-layout.c (tui_set_layout): Update.
 328
 329 2019-08-20  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 332         Declare.
 333         (tui_check_register_values): Don't declare.
 334         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 335         from tui_check_register_values.
 336         * tui/tui-hooks.c (tui_register_changed): Update.
 337
 338 2019-08-20  Tom Tromey  <tom@tromey.com>
 339
 340         * tui/tui-regs.c (tui_reg_layout): Move later.
 341         (tui_show_registers): Don't enable TUI mode or change layout.
 342
 343 2019-08-20  Tom Tromey  <tom@tromey.com>
 344
 345         * tui/tui-regs.h (struct tui_data_item_window)
 346         <~tui_data_item_window>: Remove.
 347         <content>: Now a unique_xmalloc_ptr.
 348         * tui/tui-regs.c (tui_register_format): Return a
 349         unique_xmalloc_ptr.
 350         (tui_get_register): Update.
 351         (~tui_data_item_window): Remove.
 352         (tui_data_window::display_registers_from, tui_display_register):
 353         Update.
 354         * tui/tui-io.h (tui_expand_tabs): Update.
 355         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 356         Remove "col" parameter.
 357
 358 2019-08-20  Tom Tromey  <tom@tromey.com>
 359
 360         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 361         field.
 362         * tui/tui-regs.c (~tui_data_item_window): Update.
 363
 364 2019-08-20  Tom Tromey  <tom@tromey.com>
 365
 366         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 367         earlier.
 368
 369 2019-08-20  Tom Tromey  <tom@tromey.com>
 370
 371         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 372
 373 2019-08-20  Tom Tromey  <tom@tromey.com>
 374
 375         * tui/tui-source.h (struct tui_source_window): Update.
 376         * tui/tui-regs.c (tui_show_registers): Update.
 377         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 378         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 379         (NO_REGS_STRING): Remove defines.
 380
 381 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 382
 383         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 384         unnecessary thread walk if remote doesn't support the packet.
 385
 386 2019-08-19  Tom Tromey  <tromey@adacore.com>
 387
 388         * python/py-value.c (value_has_field): Fix indentation.
 389
 390 2019-08-19  Tom Tromey  <tromey@adacore.com>
 391
 392         * printcmd.c (do_one_display, info_display_command): Update.
 393         * block.h (contained_in): Return bool.  Add allow_nested
 394         parameter.
 395         * block.c (contained_in): Return bool.  Add allow_nested
 396         parameter.
 397
 398 2019-08-19  Tom Tromey  <tom@tromey.com>
 399
 400         * configure: Rebuild.
 401         * configure.ac: Disallow the combination of -static-libstdc++ and
 402         source highlight.
 403         * source-cache.c (get_language_name): Handle rust.
 404         (source_cache::get_source_lines): Ignore highlighting exceptions.
 405
 406 2019-08-16  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 409         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 410         (struct tui_source_window_base) <make_visible, refresh_window,
 411         resize>: Remove methods.
 412         <execution_info>: Remove field.
 413         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 414         (tui_show_source_line, tui_source_window_base)
 415         (~tui_source_window_base): Update.
 416         (tui_source_window_base::resize)
 417         (tui_source_window_base::make_visible)
 418         (tui_source_window_base::refresh_window): Remove.
 419         (tui_source_window_base::update_exec_info): Update.
 420         * tui/tui-source.c (tui_source_window::set_contents): Update.
 421         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 422
 423 2019-08-16  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 426         deprecated_query_hook.
 427
 428 2019-08-16  Tom Tromey  <tom@tromey.com>
 429
 430         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 431         (tui_update_source_windows_with_line): Update.
 432         * tui/tui-source.h (struct tui_source_window)
 433         <show_symtab_source>: Declare.
 434         (tui_show_symtab_source): Don't declare.
 435         * tui/tui-source.c (tui_show_symtab_source): Rename from
 436         tui_show_symtab_source.
 437
 438 2019-08-16  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-winsource.h (struct tui_source_window_base)
 441         <set_contents>: Declare.
 442         * tui/tui-winsource.c
 443         (tui_source_window_base::update_source_window_as_is): Update.
 444         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 445         Declare.
 446         (tui_set_source_content): Don't declare.
 447         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 448         tui_set_source_content.
 449         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 450         Declare.
 451         (tui_set_disassem_content): Don't declare.
 452         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 453         tui_set_disassem_content.
 454
 455 2019-08-16  Tom Tromey  <tom@tromey.com>
 456
 457         * tui/tui-winsource.h (struct tui_source_window_base)
 458         <update_breakpoint_info>: Declare.
 459         (tui_update_breakpoint_info): Don't declare.
 460         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 461         (tui_update_all_breakpoint_info): Update.
 462         (tui_source_window_base::update_breakpoint_info): Rename from
 463         tui_update_breakpoint_info.
 464         (tui_source_window_base::update_exec_info): Update.
 465
 466 2019-08-16  Tom Tromey  <tom@tromey.com>
 467
 468         * tui/tui-winsource.h (struct tui_source_window_base)
 469         <update_source_window>: Declare.
 470         (tui_update_source_window): Don't declare.
 471         * tui/tui-winsource.c
 472         (tui_source_window_base::update_source_window): Rename from
 473         tui_update_source_window.
 474         (tui_source_window_base::rerender): Update.
 475         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 476         * tui/tui-disasm.c (tui_show_disassem)
 477         (tui_show_disassem_and_update_source)
 478         (tui_disasm_window::maybe_update): Update.
 479
 480 2019-08-16  Tom Tromey  <tom@tromey.com>
 481
 482         * tui/tui-winsource.h (struct tui_source_window_base)
 483         <update_source_window_as_is>: Declare.
 484         (tui_update_source_window_as_is): Don't declare.
 485         * tui/tui-winsource.c (tui_update_source_window): Update
 486         (tui_source_window_base::update_source_window_as_is): Rename from
 487         tui_update_source_window_as_is.
 488         (tui_source_window_base::refill): Update.
 489         * tui/tui-source.c (tui_show_symtab_source): Update.
 490         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 491         Update.
 492
 493 2019-08-16  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui-winsource.h (tui_update_source_window)
 496         (tui_update_source_window_as_is): Remove "noerror" parameter.
 497         * tui/tui-winsource.c (tui_update_source_window)
 498         (tui_update_source_window_as_is): Remove "noerror" parameter.
 499         (tui_update_source_windows_with_addr)
 500         (tui_update_source_windows_with_line)
 501         (tui_source_window_base::rerender)
 502         (tui_source_window_base::refill): Update.
 503         * tui/tui-source.h (tui_set_source_content)
 504         (tui_show_symtab_source): Remove "noerror" parameter.
 505         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 506         parameter.
 507         (tui_show_symtab_source): Likewise.
 508         (tui_source_window::maybe_update): Update.
 509         * tui/tui-disasm.c (tui_show_disassem)
 510         (tui_show_disassem_and_update_source)
 511         (tui_disasm_window::do_scroll_vertical)
 512         (tui_disasm_window::maybe_update): Update.
 513
 514 2019-08-16  Tom Tromey  <tom@tromey.com>
 515
 516         * tui/tui.c (tui_is_window_visible): Update.
 517         * tui/tui-wingeneral.c (tui_make_window)
 518         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 519         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 520         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 521         (tui_set_win_height_command, parse_scrolling_args): Update.
 522         * tui/tui-source.c (tui_source_window::style_changed): Update.
 523         * tui/tui-regs.c (tui_show_registers)
 524         (tui_data_window::first_data_item_displayed)
 525         (tui_data_window::delete_data_content_windows)
 526         (tui_check_register_values, tui_reg_command): Update.
 527         * tui/tui-disasm.c (tui_show_disassem): Update.
 528         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 529         method.
 530         <is_visible>: Remove field.
 531         * tui/tui-data.c (tui_next_win, tui_prev_win)
 532         (tui_delete_invisible_windows): Update.
 533
 534 2019-08-16  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-winsource.h (struct tui_source_window_base)
 537         <m_has_locator>: Remove.
 538         * tui/tui-layout.c (show_source_disasm_command, show_data)
 539         (show_source_or_disasm_and_command): Update.
 540
 541 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 542
 543         * NEWS (Other MI changes): New subsection.
 544         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 545         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 546         * arch-utils.c (default_get_pc_address_flags): New function.
 547         * arch-utils.h (default_get_pc_address_flags): New declaration.
 548         * gdbarch.sh: Add get_pc_address_flags.
 549         * gdbarch.c: Regenerate.
 550         * gdbarch.h: Likewise.
 551         * stack.c (print_pc): New function.
 552         (print_frame_info) (print_frame): Call print_pc.
 553
 554 2019-08-16  Tom de Vries  <tdevries@suse.de>
 555
 556         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 557         print_objfile_section_info.
 558
 559 2019-08-15  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 562         calling update_cmdwin_start_line.
 563         * tui/tui-winsource.h (struct tui_source_window_base)
 564         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 565         <rerender>: Declare.
 566         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 567         Call rerender.
 568         (tui_source_window_base::set_new_height): Remove.
 569         (tui_source_window_base::rerender): Rename from
 570         do_make_visible_with_new_height.
 571         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 572         resize method.
 573         (tui_win_info::make_invisible_and_set_new_height)
 574         (tui_win_info::make_visible_with_new_height): Remove.
 575         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 576         Declare.
 577         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 578         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 579         do_make_visible_with_new_height>: Don't declare.
 580         <rerender>: Declare.
 581         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 582         set_new_height.
 583         (tui_data_window::do_make_visible_with_new_height): Remove.
 584         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 585         call tui_show_locator_content.
 586         (tui_gen_win_info::resize): Call rerender.
 587         (show_source_or_disasm_and_command): Don't call
 588         tui_show_locator_content.
 589         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 590         method.
 591         (struct tui_win_info) <rerender>: Declare.
 592         <set_new_height, make_invisible_and_set_new_height,
 593         make_visible_with_new_height>: Don't declare.
 594         * tui/tui-data.c (tui_win_list::rerender): New method.
 595         * tui/tui-command.h (struct tui_cmd_window)
 596         <do_make_visible_with_new_height>: Don't declare.
 597         * tui/tui-command.c
 598         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 599
 600 2019-08-15  Tom Tromey  <tromey@adacore.com>
 601
 602         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 603         * ada-lang.c (ada_enum_name): Likewise.
 604
 605 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 606
 607         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 608         leading underscore.
 609         (GdbOutputErrorFile): Likewise.
 610         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 611         accordingly.
 612         (execute_unwinders): Rename to have a leading underscore.
 613         (auto_load_packages): Likewise.
 614         (global scope): Adjust call to auto_load_packages accordingly.
 615         (GdbSetPythonDirectory): Likewise.
 616         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 617         instead of execute_unwinders.
 618
 619 2019-08-15  Tom Tromey  <tom@tromey.com>
 620
 621         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 622         (show_data): Don't change window visibility.
 623         (tui_gen_win_info::resize): Remove special case for command
 624         window.  Use wresize, when available.
 625         (show_source_or_disasm_and_command): Don't change window
 626         visibility.
 627         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 628         <make_visible>: New method.
 629         * tui/tui-command.c (tui_cmd_window::resize): New method.
 630
 631 2019-08-15  Tom Tromey  <tom@tromey.com>
 632
 633         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 634         (struct tui_source_windows): New.
 635         * tui/tui-winsource.c (tui_display_main): Update.
 636         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 637         (new_height_ok, parse_scrolling_args): Update.
 638         * tui/tui-layout.c (show_layout, show_data): Update.
 639         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 640         (tui_add_to_source_windows): Don't declare.
 641         * tui/tui-data.c (source_windows, tui_source_windows)
 642         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 643
 644 2019-08-15  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 647         Rename from reset.
 648         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 649         * tui/tui-layout.c (show_source_disasm_command, show_data):
 650         Update.
 651         (tui_gen_win_info::resize): Rename.
 652         (show_source_or_disasm_and_command): Update.
 653         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 654         reset.
 655
 656 2019-08-15  Tom Tromey  <tom@tromey.com>
 657
 658         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 659         * tui/tui-interp.c (tui_interp::init): Don't call
 660         tui_initialize_static_data.
 661         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 662
 663 2019-08-15  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 666         examine tui_win_list.
 667
 668 2019-08-15  Tom Tromey  <tom@tromey.com>
 669
 670         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 671         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 672         tui_clear_source_content.
 673         (tui_clear_source_content): Remove.
 674         (tui_source_window_base::do_erase_source_content): Hoist call to
 675         content.clear().
 676         * tui/tui-stack.c (tui_show_frame_info): Don't call
 677         tui_clear_source_content.
 678
 679 2019-08-15  Tom Tromey  <tom@tromey.com>
 680
 681         * tui/tui-winsource.h (struct tui_source_window_base)
 682         <do_erase_source_content>: New method.
 683         <erase_source_content>: New method.
 684         (tui_erase_source_content): Don't declare.
 685         * tui/tui-winsource.c (tui_clear_source_content): Update.
 686         (tui_source_window_base::do_erase_source_content): Rename from
 687         tui_erase_source_content.
 688         (tui_source_window_base::show_source_content): Update.
 689         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 690         * tui/tui-source.h (struct tui_source_window)
 691         <erase_source_content>: New method.
 692         * tui/tui-disasm.h (struct tui_disasm_window)
 693         <erase_source_content>: New method.
 694
 695 2019-08-15  Tom Tromey  <tom@tromey.com>
 696
 697         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 698         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 699         constructor.
 700         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 701         * tui/tui-source.c (tui_set_source_content): Update.
 702         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 703
 704 2019-08-15  Tom Tromey  <tom@tromey.com>
 705
 706         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 707         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 708         tui-source.c.
 709         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 710         Declare.
 711         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 712         method.
 713         (tui_source_window::maybe_update): Update.
 714
 715 2019-08-15  Tom Tromey  <tom@tromey.com>
 716
 717         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 718         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 719         tui-disasm.c.
 720         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 721         Declare.
 722         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 723         method.
 724         (tui_disasm_window::maybe_update): Update.
 725
 726 2019-08-15  Tom Tromey  <tom@tromey.com>
 727
 728         * tui/tui-winsource.h (struct tui_source_window_base)
 729         <maybe_update>: Declare.
 730         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 731         method.
 732         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 733         Declare.
 734         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 735         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 736         Declare.
 737         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 738
 739 2019-08-15  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 742
 743 2019-08-15  Tom Tromey  <tom@tromey.com>
 744
 745         * tui/tui-wingeneral.c: Include tui-stack.h.
 746         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 747         (struct tui_locator_window): Move from tui-data.h.
 748         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 749         (tui_initialize_static_data): Move from tui-data.c.
 750         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 751         (struct tui_locator_window): Move to tui-stack.c.
 752         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 753         (tui_initialize_static_data): Move to tui-stack.c.
 754
 755 2019-08-15  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui-layout.c (show_source_disasm_command)
 758         (show_source_or_disasm_and_command): Use make_visible method, not
 759         tui_make_window.
 760         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 761         Remove.
 762
 763 2019-08-15  Tom Tromey  <tom@tromey.com>
 764
 765         * tui/tui-wingeneral.h (tui_make_window): Update.
 766         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 767         parameter.
 768         (tui_gen_win_info::make_visible): Update.
 769         * tui/tui-regs.c (tui_data_window::display_registers_from):
 770         Update.
 771         * tui/tui-layout.c (show_source_disasm_command)
 772         (show_source_or_disasm_and_command): Update.
 773         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 774         (enum tui_box): Remove.
 775         (struct tui_win_info) <can_box>: New method.
 776         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 777         method.
 778
 779 2019-08-15  Tom de Vries  <tdevries@suse.de>
 780
 781         * linux-nat-trad.c: Include gdbarch.h.
 782
 783 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 784
 785         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 786         register sizes.
 787
 788 2019-08-14  Tom Tromey  <tromey@adacore.com>
 789
 790         * darwin-nat.c: Include gdbarch.h.
 791         * darwin-nat-info.c: Include gdbarch.h.
 792
 793 2019-08-13  Tom Tromey  <tom@tromey.com>
 794
 795         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 796         Remove.
 797         * tui/tui-data.c (tui_initialize_static_data): Update.
 798
 799 2019-08-13  Tom Tromey  <tom@tromey.com>
 800
 801         * tui/tui-winsource.h (struct tui_exec_info_window)
 802         <~tui_exec_info_window, maybe_allocate_content, get_content,
 803         m_content>: Remove.
 804         (struct tui_source_window_base) <set_exec_info_content,
 805         show_exec_info_content>: Don't declare.
 806         * tui/tui-winsource.c
 807         (tui_exec_info_window::maybe_allocate_content): Remove.
 808         (tui_source_window_base::update_exec_info): Rename from
 809         set_exec_info_content.
 810         (tui_source_window_base::show_exec_info_content)
 811         (tui_source_window_base::update_exec_info): Remove.
 812
 813 2019-08-13  Tom Tromey  <tom@tromey.com>
 814
 815         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 816         declare.
 817         * tui/tui-winsource.c (tui_update_source_window_as_is)
 818         (tui_update_source_windows_with_addr, tui_erase_source_content):
 819         Update.
 820         (tui_clear_exec_info_content): Remove.
 821
 822 2019-08-13  Tom Tromey  <tom@tromey.com>
 823
 824         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 825         declare.
 826         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 827         call tui_erase_exec_info_content.
 828         (tui_clear_exec_info_content): Rename from
 829         tui_erase_exec_info_content.
 830         (tui_clear_exec_info_content): Delete.
 831
 832 2019-08-13  Tom Tromey  <tom@tromey.com>
 833
 834         * tui/tui-winsource.h (struct tui_source_window_base)
 835         <show_exec_info_content>: Declare.
 836         (tui_show_exec_info_content): Don't declare.
 837         * tui/tui-winsource.c
 838         (tui_source_window_base::show_exec_info_content): Rename from
 839         tui_show_exec_info_content.
 840         (tui_source_window_base::update_exec_info): Update.
 841
 842 2019-08-13  Tom Tromey  <tom@tromey.com>
 843
 844         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 845         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 846         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 847         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 848         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 849         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 850         ... here.
 851
 852 2019-08-13  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-winsource.h (struct tui_source_window_base)
 855         <update_exec_info>: Declare.
 856         (tui_update_exec_info): Don't declare.
 857         * tui/tui-winsource.c (tui_update_source_window_as_is)
 858         (tui_source_window_base::refresh_all)
 859         (tui_update_all_breakpoint_info): Update.
 860         (tui_source_window_base::update_exec_info): Rename from
 861         tui_update_exec_info.
 862         * tui/tui-stack.c (tui_show_frame_info): Update.
 863
 864 2019-08-13  Tom Tromey  <tom@tromey.com>
 865
 866         * tui/tui-winsource.h (struct tui_source_window_base)
 867         <set_exec_info_content>: Declare.
 868         (tui_set_exec_info_content): Don't declare.
 869         * tui/tui-winsource.c
 870         (tui_source_window_base::set_exec_info_content): Rename from
 871         tui_set_exec_info_content.
 872         (tui_update_exec_info): Update.
 873
 874 2019-08-13  Tom Tromey  <tom@tromey.com>
 875
 876         * tui/tui-winsource.h (struct tui_source_window_base)
 877         <show_source_content>: Declare.
 878         (tui_show_source_content): Don't declare.
 879         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 880         (tui_source_window_base::show_source_content): Rename from
 881         tui_show_source_content.
 882         (tui_source_window_base::refresh_all): Update.
 883         * tui/tui-layout.c (show_source_disasm_command)
 884         (show_source_or_disasm_and_command): Update.
 885
 886 2019-08-13  Tom Tromey  <tom@tromey.com>
 887
 888         * tui/tui-winsource.c (tui_erase_source_content)
 889         (tui_show_source_content, tui_source_window_base::refresh_all):
 890         Update.
 891         * tui/tui-wingeneral.h
 892         (tui_check_and_display_highlight_if_needed): Don't declare.
 893         * tui/tui-wingeneral.c
 894         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 895         check_and_display_highlight_if_needed.
 896         * tui/tui-win.c (tui_rehighlight_all)
 897         (tui_win_info::make_visible_with_new_height): Update.
 898         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 899         (tui_data_window::erase_data_content)
 900         (tui_data_window::display_all_data): Update.
 901         * tui/tui-data.h (struct tui_win_info)
 902         <check_and_display_highlight_if_needed>: Declare.
 903
 904 2019-08-13  Tom Tromey  <tom@tromey.com>
 905
 906         * tui/tui-win.c (tui_resize_all): Call
 907         tui_delete_invisible_windows.
 908         * tui/tui-layout.c (show_layout): Call
 909         tui_delete_invisible_windows.
 910         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 911         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 912
 913 2019-08-13  Tom Tromey  <tom@tromey.com>
 914
 915         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 916         tui_add_win_to_layout.
 917
 918 2019-08-13  Tom Tromey  <tom@tromey.com>
 919
 920         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 921         * tui/tui-layout.c (tui_default_win_height): Now static.
 922
 923 2019-08-13  Tom Tromey  <tom@tromey.com>
 924
 925         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 926         single switch.
 927         (show_source_disasm_command, show_source_or_disasm_and_command):
 928         Don't check current layout.
 929
 930 2019-08-13  Tom Tromey  <tom@tromey.com>
 931
 932         * tui/tui-wingeneral.c (make_all_visible): Remove.
 933         (tui_make_all_invisible): Simplify.
 934         * tui/tui-layout.c (tui_make_all_invisible): Move from
 935         tui-wingeneral.c; simplify.
 936         (show_layout): Hoist call to tui_make_all_invisible.
 937         (show_data): Don't call tui_make_all_invisible.
 938
 939 2019-08-13  Tom Tromey  <tom@tromey.com>
 940
 941         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 942         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 943
 944 2019-08-13  Tom Tromey  <tom@tromey.com>
 945
 946         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 947         tui-data.c.
 948         (show_source_disasm_command, show_data)
 949         (show_source_or_disasm_and_command): Don't use
 950         tui_set_current_layout_to.
 951         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 952         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 953         tui-layout.c.
 954         (tui_set_current_layout_to): Remove.
 955
 956 2019-08-13  Tom Tromey  <tom@tromey.com>
 957
 958         * tui/tui-layout.c (tui_set_layout): Update.
 959         * tui/tui-data.h (struct tui_layout_def): Remove.
 960         (tui_layout_def): Don't declare.
 961         * tui/tui-data.c (layout_def): Remove.
 962         (tui_layout_def): Remove.
 963
 964 2019-08-13  Tom Tromey  <tom@tromey.com>
 965
 966         * tui/tui-winsource.h (struct tui_source_window_base)
 967         <clear_detail>: No longer "override".
 968         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 969         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 970         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 971         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 972         Remove.
 973         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 974
 975 2019-08-13  Tom Tromey  <tromey@adacore.com>
 976
 977         * tracepoint.c: Don't include readline.h or history.h.
 978
 979 2019-08-12  Tom Tromey  <tom@tromey.com>
 980
 981         * configure: Rebuild.
 982         * configure.ac: Check for readline 7.
 983         * NEWS: Mention readline 7 requirement.
 984         * README: Update.
 985
 986 2019-08-12  Tom Tromey  <tom@tromey.com>
 987
 988         * mingw-hdep.c (gdb_select): Remove readline hack.
 989
 990 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 991
 992         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 993         when the function fails.
 994
 995 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 996
 997         * s390-tdep.c (s390_type_align): New function.
 998         (s390_gdbarch_init): Set it as type_align gdbarch method.
 999
1000 2019-08-09  Tom de Vries  <tdevries@suse.de>
1001
1002         PR gdb/24591
1003         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1004         pc_low with relocation offset.
1005
1006 2019-08-07  Tom Tromey  <tromey@adacore.com>
1007
1008         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1009         (print_frame_args): Update.
1010         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1011         Update.
1012         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1013         * frame.h (struct frame_arg): Add initializers.
1014         <error>: Now a unique_xmalloc_ptr.
1015
1016 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1017
1018         * NEWS: Expand the Pointer Authentication entry.
1019         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1020         (aarch64_frame_unmask_lr): ... to this.
1021         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1022         Call aarch64_frame_unmask_lr.
1023         * frame.c (struct frame_info): Add "masked" variable.
1024         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1025         (fprint_frame): Check for masked pc.
1026         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1027         declarations.
1028         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1029         * stack.c (print_frame): Check for masked pc.
1030
1031 2019-08-06  Tom Tromey  <tom@tromey.com>
1032
1033         * stabsread.c (patch_block_stabs, read_one_struct_field)
1034         (read_enum_type): Use obstack_strndup.
1035         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1036         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1037         * dwarf2read.c (guess_full_die_structure_name)
1038         (anonymous_struct_prefix): Use obstack_strndup.
1039         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1040         * c-exp.y (yylex): Use obstack_strndup.
1041         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1042         (write_var_or_type): Use obstack_strndup.
1043
1044 2019-08-06  Tom Tromey  <tom@tromey.com>
1045
1046         * symfile.c (reread_symbols): Use obstack_strdup.
1047         * stabsread.c (read_type): Use obstack_strdup.
1048         * gdb_obstack.h (obstack_strdup): New overload.
1049         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1050         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1051         (dwarf2_canonicalize_name): Use obstack_strdup.
1052         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1053         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1054         Use obstack_strdup.
1055
1056 2019-08-06  Tom Tromey  <tom@tromey.com>
1057
1058         * gdb_obstack.h (obstack_strdup): Define.
1059         * gdb_obstack.c (obstack_strdup): Don't define.
1060
1061 2019-08-06  Tom Tromey  <tom@tromey.com>
1062
1063         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1064         obstack_strdup.
1065         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1066         obstack_strdup.
1067         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1068         * stabsread.c (common_block_start): Use obstack_strdup.
1069         * objfiles.c (set_objfile_main_name, objfile): Use
1070         obstack_strdup.
1071         * namespace.c (add_using_directive): Use obstack_strdup.
1072         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1073         * jit.c (finalize_symtab): Use obstack_strdup.
1074         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1075         (guess_partial_die_structure_name, partial_die_info::fixup)
1076         (dwarf2_name): Use obstack_strdup.
1077         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1078         obstack_strdup.
1079         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1080         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1081         obstack_strdup.
1082         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1083
1084 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1085
1086         * unittests/help-doc-selftests.c: New file.
1087         * Makefile.in: Add the new file.
1088
1089 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1090
1091         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1092         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1093         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1094         the trailing '.' is not output, and the first character is uppercased.
1095         (print_help_for_command): Update call to print_doc_line.
1096         (print_doc_of_command): Likewise.
1097         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1098         * cli/cli-option.c (append_indented_doc): Do not append newline.
1099         (build_help_option): Append newline after first appended_indented_doc
1100         only if a second call is done.
1101         (build_help): Append 2 new lines before each option, except the first
1102         one.
1103         * compile/compile.c (_initialize_compile): Add new lines after
1104         %OPTIONS%, when not at the end of the help.
1105         Change help doc or code
1106         producing the help doc to respect the invariants.
1107         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1108         Also removed the new line after 'Options:', as all other commands
1109         do not put an empty line between 'Options:' and the first option.
1110         * printcmd.c (_initialize_printcmd): Likewise.
1111         * stack.c (_initialize_stack): Likewise.
1112         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1113         incorrectly telling COMMAND is optional.
1114         * ada-lang.c (_initialize_ada_language): Change help doc or code
1115         producing the help doc to respect the invariants.
1116         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1117         * breakpoint.c (_initialize_breakpoint): Likewise.
1118         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1119         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1120         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1121         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1122         _initialize_cli_style): Likewise.
1123         * corelow.c (core_target_info): Likewise.
1124         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1125         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1126         * filesystem.c (_initialize_filesystem): Likewise.
1127         * frame.c (_initialize_frame): Likewise.
1128         * gnu-nat.c (add_task_commands): Likewise.
1129         * infcall.c (_initialize_infcall): Likewise.
1130         * infcmd.c (_initialize_infcmd): Likewise.
1131         * interps.c (_initialize_interpreter): Likewise.
1132         * language.c (_initialize_language): Likewise.
1133         * linux-fork.c (_initialize_linux_fork): Likewise.
1134         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1135         * maint.c (_initialize_maint_cmds): Likewise.
1136         * memattr.c (_initialize_mem): Likewise.
1137         * printcmd.c (_initialize_printcmd): Likewise.
1138         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1139         _RegEx): Likewise.
1140         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1141         * record-btrace.c (_initialize_record_btrace): Likewise.
1142         * record-full.c (_initialize_record_full): Likewise.
1143         * record.c (_initialize_record): Likewise.
1144         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1145         * regcache.c (_initialize_regcache): Likewise.
1146         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1147         _initialize_remote): Likewise.
1148         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1149         * serial.c (_initialize_serial): Likewise.
1150         * skip.c (_initialize_step_skip): Likewise.
1151         * source.c (_initialize_source): Likewise.
1152         * stack.c (_initialize_stack): Likewise.
1153         * symfile.c (_initialize_symfile): Likewise.
1154         * symtab.c (_initialize_symtab): Likewise.
1155         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1156         * top.c (init_main): Likewise.
1157         * tracefile-tfile.c (tfile_target_info): Likewise.
1158         * tracepoint.c (_initialize_tracepoint): Likewise.
1159         * tui/tui-win.c (_initialize_tui_win): Likewise.
1160         * utils.c (add_internal_problem_command): Likewise.
1161         * valprint.c (value_print_option_defs): Likewise.
1162
1163 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1164
1165         PR build/24886
1166         * configure.ac: Drop enable-libmcheck support.
1167         * configure, config.in: Rebuild.
1168         * libmcheck.m4: Remove.
1169         * acinclude.m4: Don't include it.
1170         * Makefile.in: Don't distribute it.
1171         * top.c (print_gdb_configuration): Don't mention it.
1172
1173 2019-08-06  Tom Tromey  <tom@tromey.com>
1174
1175         * utils.c (set_output_style): Sometimes pass stream to
1176         emit_style_escape.
1177         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1178         * record-btrace.c (btrace_insn_history): Update.
1179         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1180         method.
1181         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1182         Update initializers.
1183         <m_uiout>: New field.
1184         <m_di>: Move lower.
1185         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1186         Remove "uiout" parameter.
1187         (dump_insns): Update.
1188         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1189         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1190
1191 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1192
1193         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1194         (error_in_psymtab_expansion): Likewise.
1195         (lookup_symbol_via_quick_fns): Likewise.
1196         (basic_lookup_transparent_type_quick): Likewise.
1197         (basic_lookup_transparent_type_1): Likewise.
1198
1199 2019-08-06  Tom Tromey  <tromey@adacore.com>
1200
1201         * source.c (last_source_error): Now bool.
1202         (print_source_lines_base): Make "noprint" bool.  Only open
1203         source file when last_source_visited changes.
1204
1205 2019-08-06  Tom Tromey  <tromey@adacore.com>
1206
1207         * annotate.c (annotate_source_line): Use g_source_cache.
1208         * source-cache.c (source_cache::get_plain_source_lines): Change
1209         parameters.  Populate m_offset_cache.
1210         (source_cache::ensure): New method.
1211         (source_cache::get_line_charpos): New method.
1212         (extract_lines): Move lower.  Change parameters.
1213         (source_cache::get_source_lines): Move lower.
1214         * source-cache.h (class source_cache): Update comment.
1215         <get_line_charpos>: New method.
1216         <get_source_lines>: Update comment.
1217         <clear>: Clear m_offset_cache.
1218         <get_plain_source_lines>: Change parameters.
1219         <ensure>: New method
1220         <m_offset_cache>: New member.
1221         * source.c (forget_cached_source_info_for_objfile): Update.
1222         (info_source_command): Use g_source_cache.
1223         (find_source_lines, open_source_file_with_line_charpos): Remove.
1224         (print_source_lines_base, search_command_helper): Use g_source_cache.
1225         * source.h (open_source_file_with_line_charpos): Don't declare.
1226         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1227         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1228         Use g_source_cache.
1229
1230 2019-08-06  Tom Tromey  <tromey@adacore.com>
1231
1232         * source-cache.c (source_cache::get_plain_source_lines):
1233         Remove "first_line" and "last_line" parameters.
1234         (source_cache::get_source_lines): Cache plain text.
1235         * source-cache.h (class source_cache)
1236         <get_plain_source_lines>: Update.
1237
1238 2019-08-06  Tom Tromey  <tromey@adacore.com>
1239
1240         * source-cache.c (extract_lines): No longer a method.
1241         Changed type of parameter.  Include final newline.
1242         (selftests::extract_lines_test): New function.
1243         (_initialize_source_cache): Likewise.
1244         * source-cache.h (class source_cache)
1245         <extract_lines>: Don't declare.
1246
1247 2019-08-06  Tom Tromey  <tromey@adacore.com>
1248
1249         * breakpoint.c (init_breakpoint_sal): Update.
1250         (breakpoint): Update.
1251         * breakpoint.h (struct breakpoint) <filter>: Now a
1252         unique_xmalloc_ptr.
1253
1254 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1255
1256         * NEWS: Mention dictionary access on blocks.
1257         * python/py-block.c (blpy_getitem): New function.
1258         (block_object_as_mapping): New struct.
1259         (block_object_type): Use new struct for tp_as_mapping field.
1260
1261 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1262
1263         * objfiles.h (objfile): Add a comment describing partial symbols.
1264
1265 2019-08-05  Tom Tromey  <tromey@adacore.com>
1266
1267         * compile/compile.c (_initialize_compile): Use _(), not N_().
1268         * thread.c (_initialize_thread): Use _(), not N_().
1269         * stack.c (_initialize_stack): Use _(), not N_().
1270         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1271
1272 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1273
1274         * dwarf2read.c (struct dw2_symtab_iterator):
1275         <want_specific_block>: Remove.
1276         <block_index>: Change type to gdb::optional.
1277         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1278         change type of BLOCK_INDEX parameter to gdb::optional.
1279         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1280         (dw2_lookup_symbol): Don't pass argument for
1281         WANT_SPECIFIC_BLOCK.
1282         (dw2_expand_symtabs_for_function): Don't pass argument for
1283         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1284         (class dw2_debug_names_iterator)
1285         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1286         parameter, change BLOCK_INDEX type to gdb::optional.
1287         <m_want_specific_block>: Remove.
1288         <m_block_index>: Change type to gdb::optional.
1289         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1290         gdb::optional.  Re-write in function of gdb::optional.
1291         (dw2_debug_names_lookup_symbol): Don't pass argument for
1292         WANT_SPECIFIC_BLOCK.
1293         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1294         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1295         BLOCK_INDEX.
1296
1297 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1298
1299         * NEWS: Mention changes to "info sources" command.
1300
1301 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1302
1303         * symtab.c (filename_partial_match_opts): New struct type.
1304         (struct output_source_filename_data): New members
1305         regexp, c_regexp, partial_match.
1306         (output_source_filename): Use new members to decide to print file.
1307         (info_sources_option_defs): New variable.
1308         (make_info_sources_options_def_group, print_info_sources_header,
1309         info_sources_command_completer):
1310         New functions.
1311         (info_sources_command): Read new optional arguments.
1312         (_initialize_symtab): Update info sources help.
1313
1314 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1315
1316         * ada-lang.c (exception_support_info_v0): Renamed from...
1317         (default_exception_support_info): ... this.  Create new
1318         definition for v1.
1319         (ada_has_this_exception_support): Look up catch_handlers_sym.
1320         (ada_exception_support_info_sniffer): Try v0 after default.
1321
1322 2019-08-01  Tom Tromey  <tromey@adacore.com>
1323
1324         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1325         gdbarch.h.
1326
1327 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1328
1329         * s12z-tdep.c: Fix include path for s12z-opc.h.
1330
1331 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1332
1333         * NEWS: Require GNU make 3.82.
1334
1335 2019-07-16  Tom Tromey  <tom@tromey.com>
1336
1337         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1338         declare.
1339
1340 2019-07-30  Tom Tromey  <tromey@adacore.com>
1341
1342         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1343
1344 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1345
1346         * printcmd.c (print_address_symbolic): Print negative offsets.
1347         (build_address_symbolic): Force signed arithmetic when computing
1348         offset.
1349
1350 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1351
1352         PR/24474: Add a function to lookup static variables.
1353         * NEWS: Mention this new function.
1354         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1355         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1356         * python/python.c (python_GdbMethods): Add new function.
1357
1358 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1359
1360         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1361         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1362         (objfpy_lookup_static_symbol): New function.
1363         (objfile_object_methods): Add new functions.
1364
1365 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1366
1367         * NEWS: Mention 'set|show print frame-info'.  Mention new
1368         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1369         backtrace argument.  Mention that python frame filtering code
1370         is now consistent with what 'backtrace' command prints.
1371
1372 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1373
1374         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1375         comments.
1376         (print_frame_info_auto, print_frame_info_source_line,
1377         print_frame_info_location, print_frame_info_source_and_location,
1378         print_frame_info_location_and_address, print_frame_info_short_location):
1379         New declarations.
1380         (struct frame_print_options): New member print_frame_info.
1381         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1382         * stack.h (get_user_print_what_frame_info): New declaration.
1383         (frame_show_address): New declaration.
1384         * stack.c (print_frame_arguments_choices): New value 'presence'.
1385         (print_frame_info_auto, print_frame_info_source_line,
1386         print_frame_info_location, print_frame_info_source_and_location,
1387         print_frame_info_location_and_address, print_frame_info_short_location,
1388         print_frame_info_choices, print_frame_info_print_what): New definitions.
1389         (print_frame_args): Only print dots for args if print frame-arguments
1390         is 'presence'.
1391         (frame_print_option_defs): New element for "frame-info".
1392         (get_user_print_what_frame_info): New function.
1393         (frame_show_address): Make non static.  Move comment to stack.h.
1394         (print_frame_info_to_print_what): New function.
1395         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1396         to decide what to print.
1397         (backtrace_command_1): Handle the new print_frame_arguments_presence
1398         value.
1399         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1400         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1401         (py_print_frame): In non-mi mode, use LOCATION as default for
1402         print_what, similarly to frame information printed directly by
1403         backtrace command. Handle frame-info user option in non MI mode.
1404
1405 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1406
1407         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1408         Add case for debugging 32-bit target on 64-bit host.  Revise
1409         comment.
1410
1411 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1412
1413         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1414         instead of find_function_entry_range_from_pc.
1415
1416 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1417
1418         * stack.c (find_frame_funname): Remove code which preferred
1419         minsym over symtab sym in "certain pathological cases".
1420
1421         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1422         parameter.  Change type of "do_demangle" to bool.
1423         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1424         Pass suitable "prefer_sym_over_minsym" flag to
1425         build_address_symbolic().  Don't output "+" for negative offsets.
1426         * printcmd.c (print_address_symbolic): Update invocation of
1427         build_address_symbolic to include a "prefer_sym_over_minsym"
1428         flag.
1429         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1430         Restrict cases in which use of minimal symbol is preferred to that
1431         of a found symbol.  Update comments.
1432
1433         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1434         for entry pc when entry pc is out of range for that FDE.
1435
1436 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1437
1438         PR gdb/24839:
1439         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1440         type.
1441
1442 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1443
1444         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1445         this function's Python signature.
1446
1447
1448 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1449
1450         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1451         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1452         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1453         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1454         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1455
1456
1457 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1458
1459         * h8300-tdep.c (h8300_register_name_common): New.
1460         h8300_register_name): Use h8300_register_name_common.
1461         (h8300s_register_name): Likewise.
1462         (h8300sx_register_name): Likewise.
1463         (h8300h_register_nam): New.
1464         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1465
1466
1467 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1468
1469         * arm-tdep.c (arm_skip_cmse_entry): New function.
1470         (arm_is_sgstubs_section): New function.
1471         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1472
1473 2019-07-22  Tom Tromey  <tom@tromey.com>
1474
1475         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1476         Don't self-assign.
1477
1478 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1479
1480         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1481         type_print.
1482
1483 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1484
1485         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1486         so that GDB doesn't match any msymbols when searching in the
1487         TYPES_DOMAIN.
1488         (print_symbol_info): Print using typedef_print or type_print based
1489         on the type of the symbol.  Add updated FIXME comment moved from...
1490         (_initialize_symtab): ... move and update FIXME comment to above.
1491
1492 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1493
1494         * NEWS: Mention adding -q option to "info types".
1495         * symtab.c (struct info_types_options): New struct.
1496         (info_types_options_defs): New variable.
1497         (make_info_types_options_def_group): New function.
1498         (info_types_command): Use gdb::option framework to parse options.
1499         (info_types_command_completer): New function.
1500         (_initialize_symtab): Extend the help text on "info types" and
1501         register command completer.
1502
1503 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1504
1505         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1506         (lookup_symbol_in_objfile): Change int to block_enum and add a
1507         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1508
1509 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1510
1511         * MAINTAINERS (Write After Approval): Add self.
1512
1513 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1514
1515         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1516         instruction to the dummy code region.
1517
1518 2019-07-19  Tom Tromey  <tromey@adacore.com>
1519
1520         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1521         (ARGSUSED, PARAMS, __func__): Remove rules.
1522
1523 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1524
1525         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1526         * features/arm/arm-with-iwmmxt.c: Remove.
1527         * features/arm/arm-with-iwmmxt.xml: Remove.
1528         * features/arm/arm-with-m-fpa-layout.c: Remove.
1529         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1530         * features/arm/arm-with-m-vfp-d16.c: Remove.
1531         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1532         * features/arm/arm-with-m.c: Remove.
1533         * features/arm/arm-with-m.xml: Remove.
1534         * features/arm/arm-with-neon.c: Remove.
1535         * features/arm/arm-with-neon.xml: Remove.
1536         * features/arm/arm-with-vfpv2.c: Remove.
1537         * features/arm/arm-with-vfpv2.xml: Remove.
1538         * features/arm/arm-with-vfpv3.c: Remove.
1539         * features/arm/arm-with-vfpv3.xml: Remove.
1540
1541 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1542
1543         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1544
1545 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1546
1547         * arch/aarch32.c (aarch32_create_target_description): Create
1548         target descriptions using features.
1549         * arch/arm.c (arm_create_target_description)
1550         (arm_create_mprofile_target_description): Likewise.
1551         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1552
1553 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1554
1555         * Makefile.in: Add new files.
1556         * aarch32-tdep.c: New file.
1557         * aarch32-tdep.h: New file.
1558         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1559         Call aarch32_read_description.
1560         * arch/aarch32.c: New file.
1561         * arch/aarch32.h: New file.
1562         * arch/arm.c (arm_create_target_description)
1563         (arm_create_mprofile_target_description): New function.
1564         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1565         (arm_create_target_description)
1566         (arm_create_mprofile_target_description): New declaration.
1567         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1568         read_description functions.
1569         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1570         Likewise.
1571         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1572         * arm-tdep.c (tdesc_arm_list): New variable.
1573         (arm_register_g_packet_guesses): Call create description functions.
1574         (arm_read_description) (arm_read_mprofile_description): New
1575         function.
1576         * arm-tdep.h (arm_read_description)
1577         (arm_read_mprofile_description): Add declaration.
1578         * configure.tgt: Add new files.
1579
1580 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1581
1582         * top.c (new_ui_command): Open specified terminal just once.
1583
1584 2019-07-18  Tom Tromey  <tromey@adacore.com>
1585
1586         * symtab.c (main_name): Constify return type.
1587         * symfile.c (set_initial_language): Update.
1588         * symtab.h (main_name): Constify return type.
1589
1590 2019-07-17  Tom Tromey  <tom@tromey.com>
1591
1592         * tui/tui-winsource.c (tui_update_source_window)
1593         (tui_update_source_window_as_is)
1594         (tui_update_source_windows_with_line): Remove return.
1595         * tui/tui-disasm.c (tui_show_disassem)
1596         (tui_show_disassem_and_update_source): Remove return.
1597         * tui/tui.c (tui_reset): Remove return.
1598         * tui/tui-wingeneral.c
1599         (tui_check_and_display_highlight_if_needed): Remove return.
1600
1601 2019-07-17  Tom Tromey  <tom@tromey.com>
1602
1603         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1604
1605 2019-07-17  Tom Tromey  <tom@tromey.com>
1606
1607         * tui/tui-winsource.h (struct tui_exec_info_window)
1608         (struct tui_source_window_base): Move from tui-data.h.
1609         * tui/tui-winsource.c: Move many method definitions from
1610         elsewhere.  Remove "structuring" comments.
1611         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1612         (tui_source_window_base::refresh_window): Move to
1613         tui-winsource.c.
1614         * tui/tui-win.c (tui_source_window_base::refresh_all)
1615         (tui_source_window_base::update_tab_width)
1616         (tui_source_window_base::set_new_height)
1617         (tui_source_window_base::do_make_visible_with_new_height): Move to
1618         tui-winsource.c.
1619         * tui/tui-source.h: Update.
1620         * tui/tui-source.c (tui_source_window_base::reset): Move to
1621         tui-winsource.c.
1622         * tui/tui-disasm.h: Update.
1623         * tui/tui-data.h (struct tui_exec_info_window): Move to
1624         tui-winsource.h.
1625         (struct tui_source_window_base): Likewise.
1626         * tui/tui-data.c (tui_source_window_base::clear_detail)
1627         (tui_source_window_base, ~tui_source_window_base): Move to
1628         tui-winsource.c.
1629
1630 2019-07-17  Tom Tromey  <tom@tromey.com>
1631
1632         * tui/tui-win.c (tui_resize_all)
1633         (tui_source_window_base::update_tab_width)
1634         (tui_adjust_win_heights): Update.
1635         (tui_win_info::make_invisible_and_set_new_height): Rename from
1636         make_invisible_and_set_new_height.
1637         * tui/tui-data.h (struct tui_win_info)
1638         <make_invisible_and_set_new_height>: New method.
1639
1640 2019-07-17  Tom Tromey  <tom@tromey.com>
1641
1642         * tui/tui.c: Update.
1643         * tui/tui-source.h (struct tui_source_window): Move from
1644         tui-data.h.
1645         * tui/tui-layout.c: Update.
1646         * tui/tui-disasm.c: Update.
1647         * tui/tui-data.h (struct tui_source_window): Move to
1648         tui-source.h.
1649
1650 2019-07-17  Tom Tromey  <tom@tromey.com>
1651
1652         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1653         tui-data.h.
1654         * tui/tui-data.h (struct tui_disasm_window): Move to
1655         tui-disasm.h.
1656
1657 2019-07-17  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-regs.h (struct tui_data_item_window): Move from
1660         tui-data.h.
1661         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1662         * tui/tui-data.h (struct tui_data_item_window): Move to
1663         tui-regs.h.
1664         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1665
1666 2019-07-17  Tom Tromey  <tom@tromey.com>
1667
1668         * tui/tui.c: Update.
1669         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1670         (tui_cmd_window::max_height): Move to tui-command.c.
1671         * tui/tui-layout.c: Update.
1672         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1673         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1674         tui-command.c.
1675         * tui/tui-command.h (struct tui_cmd_window): Move from
1676         tui-data.h.
1677         * tui/tui-command.c: Remove "structuring" comments.
1678         (tui_cmd_window::clear_detail)
1679         (tui_cmd_window::do_make_visible_with_new_height)
1680         (tui_cmd_window::max_height): Move from elsewhere.
1681
1682 2019-07-17  Tom Tromey  <tom@tromey.com>
1683
1684         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1685         Now static.
1686         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1687         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1688
1689 2019-07-17  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui.c: Update.
1692         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1693         tui-regs.c.
1694         * tui/tui-windata.h: Remove file.
1695         * tui/tui-windata.c: Remove file.
1696         * tui/tui-win.c (tui_data_window::set_new_height)
1697         (tui_data_window::do_make_visible_with_new_height): Move to
1698         tui-regs.c.
1699         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1700         * tui/tui-regs.c: Remove "structuring" comments.
1701         (tui_data_window::first_data_item_displayed)
1702         (tui_data_window::delete_data_content_windows)
1703         (tui_data_window::erase_data_content)
1704         (tui_data_window::display_all_data)
1705         (tui_data_window::refresh_all)
1706         (tui_data_window::do_scroll_vertical)
1707         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1708         (tui_data_window::do_make_visible_with_new_height)
1709         (tui_data_window::refresh_window): Move from elsewhere.
1710         (_initialize_tui_regs): Move to end of file.
1711         * tui/tui-layout.c: Update.
1712         * tui/tui-hooks.c: Update.
1713         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1714         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1715         tui-regs.c.
1716         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1717
1718 2019-07-17  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1721         seen.
1722
1723 2019-07-17  Tom Tromey  <tom@tromey.com>
1724
1725         * tui/tui-win.c (tui_source_window_base::set_new_height)
1726         (tui_source_window_base::do_make_visible_with_new_height): Use
1727         m_has_locator field directly.
1728         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1729         method.
1730         (struct tui_source_window_base) <has_locator>: Likewise.
1731
1732 2019-07-17  Tom Tromey  <tom@tromey.com>
1733
1734         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1735         Don't declare.
1736         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1737         Remove.
1738         * tui/tui-win.c (tui_source_window_base::set_new_height)
1739         (tui_source_window_base::set_new_height)
1740         (make_invisible_and_set_new_height)
1741         (tui_source_window_base::do_make_visible_with_new_height)
1742         (tui_source_window_base::do_make_visible_with_new_height):
1743         Update.
1744         * tui/tui-layout.c (show_source_disasm_command, show_data)
1745         (show_source_or_disasm_and_command): Update.
1746         * tui/tui-layout.c (show_layout): Update.
1747
1748 2019-07-17  Tom Tromey  <tom@tromey.com>
1749
1750         * tui/tui-layout.c (make_data_window): Remove.
1751         (show_data): Unify creation and re-initialization cases.
1752
1753 2019-07-17  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui-layout.c (make_source_window, make_disasm_window):
1756         Remove.
1757         (show_data): Unify creation and re-initialization cases.
1758
1759 2019-07-17  Tom Tromey  <tom@tromey.com>
1760
1761         * tui/tui-layout.c (make_command_window): Remove.
1762         (show_source_disasm_command, show_source_or_disasm_and_command):
1763         Unify creation and re-initialization cases.
1764
1765 2019-07-17  Tom Tromey  <tom@tromey.com>
1766
1767         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1768         creation and re-initialization cases.
1769
1770 2019-07-17  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-regs.c (tui_get_register): Return void.
1773
1774 2019-07-17  Tom Tromey  <tom@tromey.com>
1775
1776         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1777         Simplify.
1778
1779 2019-07-17  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1782         resetting.
1783
1784 2019-07-17  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1787         * tui/tui-regs.c (tui_reg_layout): New function.
1788         (tui_show_registers, tui_reg_command): Use it.
1789         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1790         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1791         parameters.
1792         (tui_layout_command): Remove.
1793
1794 2019-07-17  Tom Tromey  <tom@tromey.com>
1795
1796         * tui/tui-layout.h (tui/tui-layout): Return void.
1797         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1798
1799 2019-07-17  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-layout.c (show_source_disasm_command, show_data):
1802         Update.
1803         (reset_locator): Remove.
1804         (show_source_or_disasm_and_command): Update.
1805
1806 2019-07-17  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-source.c (tui_source_window_base::reset): Remove
1809         win_type parameter.
1810         * tui/tui-layout.c (make_command_window, make_source_window)
1811         (make_disasm_window, make_data_window)
1812         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1813         (reset_locator, show_source_or_disasm_and_command): Update.
1814         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1815         win_type parameter.
1816         (struct tui_source_window_base) <reset>: Likewise.
1817
1818 2019-07-17  Tom Tromey  <tom@tromey.com>
1819
1820         * tui/tui-layout.c (show_source_disasm_command): Use
1821         reset_locator.
1822         (reset_locator): New function.
1823         (init_and_make_win): Remove.
1824         (show_source_or_disasm_and_command): Use reset_locator.
1825
1826 2019-07-17  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1829         condition.
1830         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1831         Remove condition.
1832         * tui/tui-source.c (tui_source_window_base::reset): New method.
1833         * tui/tui-layout.c (make_command_window): Don't call
1834         init_and_make_win.
1835         (make_source_window, make_disasm_window): Don't call
1836         make_source_or_disasm_window.
1837         (make_data_window): Don't call init_and_make_win.  Change calling
1838         convention.
1839         (show_source_disasm_command, show_data): Simplify.
1840         (make_source_or_disasm_window): Remove.
1841         (show_source_or_disasm_and_command): Simplify.
1842         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1843         (struct tui_source_window_base) <reset>: Likewise.
1844         <execution_info>: Remove initializer.
1845         * tui/tui-data.c (tui_source_window_base): Initialize
1846         execution_info.
1847
1848 2019-07-17  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1851         variable.
1852
1853 2019-07-17  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui.c (tui_rl_other_window): Update.
1856         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1857         superclass method first.  Always iterate over regs_content.
1858         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1859         method.
1860         * tui/tui-win.c (tui_set_focus_command): Update.
1861
1862 2019-07-17  Tom Tromey  <tom@tromey.com>
1863
1864         * tui/tui-win.c (tui_set_focus_command): Rename from
1865         tui_set_focus.  Call tui_enable.
1866         (tui_set_focus_command): Remove.
1867
1868 2019-07-17  Tom Tromey  <tom@tromey.com>
1869
1870         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1871         refresh_window.
1872         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1873         touchwin.
1874         (tui_data_window::refresh_window): Call refresh_window on data
1875         items.  Always call superclass refresh_window.
1876         (tui_win_info::refresh): Remove.
1877         (tui_source_window_base::refresh_window): Update.
1878         (tui_refresh_all): Update.
1879         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1880         refresh_window.
1881         (show_source_or_disasm_and_command): Likewise.
1882         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1883         (struct tui_source_window_base) <refresh>: Likewise.
1884
1885 2019-07-17  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-winsource.c (tui_clear_source_content)
1888         (tui_show_source_content): Update.
1889         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1890         whether content is empty.
1891         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1892         Remove.
1893
1894 2019-07-17  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1897         window's contents.
1898         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1899         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1900
1901 2019-07-17  Tom Tromey  <tom@tromey.com>
1902
1903         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1904         (struct tui_data_item_window): Update.
1905
1906 2019-07-17  Tom Tromey  <tom@tromey.com>
1907
1908         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1909         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1910         defines.
1911
1912 2019-07-17  Tom Tromey  <tom@tromey.com>
1913
1914         * tui/tui-winsource.h (tui_erase_source_content)
1915         (tui_clear_source_content): Remove "display_prompt" parameter.
1916         * tui/tui-winsource.c (tui_update_source_window_as_is)
1917         (tui_update_source_windows_with_addr): Update.
1918         (tui_clear_source_content): Remove "display_prompt" parameter.
1919         (tui_erase_source_content): Likewise.  Simplify.
1920         (tui_show_source_content): Update.
1921         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1922         * tui/tui-stack.c (tui_show_frame_info): Update.
1923         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1924         Remove defines.
1925
1926 2019-07-17  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1929         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1930         parameter.
1931         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1932         parameter.
1933
1934 2019-07-17  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui-winsource.c (tui_clear_source_content)
1937         (tui_show_source_content, tui_show_exec_info_content)
1938         (tui_clear_exec_info_content): Update.
1939         * tui/tui-stack.c (tui_show_locator_content): Update.
1940         (tui_show_frame_info): Update.
1941         * tui/tui-source.h (tui_source_window): Don't declare.
1942         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1943         from tui_source_is_displayed.
1944         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1945         Remove field.
1946         (struct tui_source_window_base) <content_in_use>: New field.  Now
1947         bool.
1948         (struct tui_source_window) <showing_source_p>: New method.
1949         (TUI_SRC_WIN): Change cast.
1950         * tui/tui-data.c (tui_initialize_static_data): Update.
1951
1952 2019-07-17  Tom Tromey  <tom@tromey.com>
1953
1954         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1955         location_matches_p.
1956         * tui/tui-source.c (tui_source_window::location_matches_p): New
1957         method.
1958         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1959         method.
1960         * tui/tui-data.h (struct tui_source_window_base)
1961         <location_matches_p>: New method.
1962         (struct tui_source_window, struct tui_disasm_window)
1963         <location_matches_p>: Likewise.
1964
1965 2019-07-17  Tom Tromey  <tom@tromey.com>
1966
1967         * tui/tui-win.c (tui_set_win_height_command): Rename from
1968         tui_set_win_height.
1969         (tui_set_win_height_command): Remove.
1970
1971 2019-07-17  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-source.c (tui_source_window): New constructor.  Add
1974         observer.
1975         (~tui_source_window): New destructor.
1976         (tui_source_window::style_changed): New method.
1977         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1978         (tui_attach_detach_observers): Update.
1979         * tui/tui-data.h (struct tui_source_window): Make constructor not
1980         inline.  Add destructor.
1981         (struct tui_source_window) <style_changed>: New method.
1982         <m_observable>: New member.
1983
1984 2019-07-17  Tom Tromey  <tom@tromey.com>
1985
1986         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1987         * tui/tui-win.c (tui_resize_all): Fix typo.
1988
1989 2019-07-17  Tom Tromey  <tom@tromey.com>
1990
1991         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1992         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1993         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1994         * tui/tui-win.c (window_name_completer): Use foreach.
1995         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1996         (update_tab_width): Likewise.
1997         * tui/tui-layout.c (show_layout): Update.
1998         * tui/tui-data.h (class tui_window_iterator): New.
1999         (struct all_tui_windows): New.
2000         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2001
2002 2019-07-17  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2005         parameter.  Don't reference globals.
2006         (tui_reg_command): Update.
2007
2008 2019-07-17  Tom Tromey  <tom@tromey.com>
2009
2010         * tui/tui-regs.c (tui_show_registers): Simplify.
2011
2012 2019-07-17  Tom Tromey  <tom@tromey.com>
2013
2014         * tui/tui-regs.c (tui_show_registers): Update.
2015         (tui_show_register_group): Add win_info parameter.
2016
2017 2019-07-17  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2020         Rename from tui_display_reg_element_at_line.
2021         (tui_data_window::display_registers_from_line): Update.
2022         * tui/tui-data.h (struct tui_data_window)
2023         <display_reg_element_at_line>: New method.
2024
2025 2019-07-17  Tom Tromey  <tom@tromey.com>
2026
2027         * tui/tui-regs.h (tui_display_registers_from)
2028         (tui_display_registers_from_line): Don't declare.
2029         * tui/tui-windata.c (tui_data_window::display_all_data)
2030         (tui_data_window::refresh_all)
2031         (tui_data_window::do_scroll_vertical): Update.
2032         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2033         from tui_display_registers_from.
2034         (tui_display_reg_element_at_line): Update.
2035         (tui_data_window::display_registers_from_line): Rename from
2036         tui_display_registers_from_line.
2037         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2038         display_registers_from_line>: New methods.
2039
2040 2019-07-17  Tom Tromey  <tom@tromey.com>
2041
2042         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2043         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2044         from tui_erase_data_content.
2045         (tui_data_window::display_all_data)
2046         (tui_data_window::refresh_all)
2047         (tui_data_window::do_scroll_vertical): Update.
2048         * tui/tui-regs.c (tui_show_registers): Update.
2049         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2050         New method.
2051
2052 2019-07-17  Tom Tromey  <tom@tromey.com>
2053
2054         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2055         declare.
2056         * tui/tui-windata.c
2057         (tui_data_window::delete_data_content_windows): Rename from
2058         tui_delete_data_content_windows.
2059         (tui_data_window::display_all_data)
2060         (tui_data_window::do_scroll_vertical): Update.
2061         * tui/tui-data.h (struct tui_data_window)
2062         <delete_data_content_windows>: New method.
2063
2064 2019-07-17  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2067         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2068
2069 2019-07-17  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2072         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2073         from tui_display_all_data.
2074         * tui/tui-win.c
2075         (tui_data_window::do_make_visible_with_new_height): Update.
2076         * tui/tui-regs.c (tui_show_registers): Update.
2077         * tui/tui-layout.c (tui_set_layout): Update.
2078         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2079         method.
2080
2081 2019-07-17  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2084         * tui/tui-windata.c (tui_display_data_from): Remove.
2085         (tui_data_window::refresh_all): Update.
2086
2087 2019-07-17  Tom Tromey  <tom@tromey.com>
2088
2089         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2090         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2091         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2092         tui_display_registers_from_line.
2093         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2094         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2095         "force_display" parameter.
2096
2097 2019-07-17  Tom Tromey  <tom@tromey.com>
2098
2099         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2100         declare.
2101         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2102         Rename from tui_first_reg_element_no_inline.
2103         (tui_display_reg_element_at_line)
2104         (tui_display_registers_from_line): Update.
2105         * tui/tui-data.h (struct tui_data_window)
2106         <first_reg_element_no_inline>: New method.
2107
2108 2019-07-17  Tom Tromey  <tom@tromey.com>
2109
2110         * tui/tui-windata.c (tui_display_data_from)
2111         (tui_data_window::do_scroll_vertical): Update.
2112         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2113         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2114         Rename from tui_line_from_reg_element_no.
2115         (tui_display_registers_from_line): Update.
2116         * tui/tui-data.h (struct tui_data_window)
2117         <line_from_reg_element_no>: New method.
2118
2119 2019-07-17  Tom Tromey  <tom@tromey.com>
2120
2121         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2122         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2123         tui_last_regs_line_no.
2124         (tui_display_reg_element_at_line)
2125         (tui_display_registers_from_line): Update.
2126         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2127         method.
2128
2129 2019-07-17  Tom Tromey  <tom@tromey.com>
2130
2131         PR tui/24722:
2132         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2133         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2134         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2135         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2136         (tui_update_breakpoint_info): Likewise.
2137         * tui/tui-hooks.c (tui_event_create_breakpoint)
2138         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2139         Update.
2140
2141 2019-07-17  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2144
2145 2019-07-17  Tom Tromey  <tom@tromey.com>
2146
2147         * tui/tui-winsource.c (tui_update_source_window_as_is)
2148         (tui_update_source_windows_with_addr): Update.
2149         * tui/tui-source.h (tui_set_source_content)
2150         (tui_show_symtab_source): Add "win_info" parameter.
2151         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2152         parameter.
2153         (tui_show_symtab_source): Likewise.
2154
2155 2019-07-17  Tom Tromey  <tom@tromey.com>
2156
2157         * tui/tui-wingeneral.c
2158         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2159
2160 2019-07-17  Tom Tromey  <tom@tromey.com>
2161
2162         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2163         (struct tui_cmd_window) <can_scroll>: New method.
2164         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2165         method.
2166
2167 2019-07-17  Tom Tromey  <tromey@adacore.com>
2168
2169         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2170         do_field_signed>: Rename.  Change type of "value".
2171         * ui-out.c (ui_out::field_signed): Rename from field_int.
2172         Change type of "value".
2173         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2174         type of "value".
2175         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2176         do_field_int.  Change type of "value".
2177         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2178         do_field_int.  Change type of "value".
2179         * tracepoint.c (trace_status_mi, tfind_1)
2180         (print_one_static_tracepoint_marker): Update.
2181         * thread.c (print_thread_info_1, print_selected_thread_frame):
2182         Update.
2183         * stack.c (print_frame, print_frame_info): Update.
2184         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2185         Update.
2186         * source.c (print_source_lines_base): Update.
2187         * skip.c (info_skip_command): Update.
2188         * record-btrace.c (btrace_ui_out_decode_error)
2189         (btrace_call_history_src_line): Update.
2190         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2191         Update.
2192         * progspace.c (print_program_space): Update.
2193         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2194         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2195         do_field_int.  Change type of "value".
2196         * mi/mi-out.c (mi_ui_out::do_table_begin)
2197         (mi_ui_out::do_table_header): Update.
2198         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2199         type of "value".
2200         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2201         (mi_cmd_data_list_changed_registers, output_register)
2202         (mi_cmd_data_read_memory, mi_load_progress)
2203         (mi_cmd_trace_frame_collected): Update.
2204         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2205         Update.
2206         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2207         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2208         (mi_cmd_var_list_children, varobj_update_one): Update.
2209         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2210         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2211         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2212         * inferior.c (print_inferior): Update.
2213         * gdb_bfd.c (print_one_bfd): Update.
2214         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2215         Update.
2216         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2217         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2218         do_field_int.  Change type of "value".
2219         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2220         do_field_int.  Change type of "value".
2221         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2222         (print_one_breakpoint_location, print_it_catch_fork)
2223         (print_one_catch_fork, print_it_catch_vfork)
2224         (print_one_catch_vfork, print_it_catch_solib)
2225         (print_it_catch_exec, print_it_ranged_breakpoint)
2226         (print_mention_watchpoint, print_mention_masked_watchpoint)
2227         (bkpt_print_it, update_static_tracepoint): Update.
2228         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2229         * break-catch-syscall.c (print_it_catch_syscall): Update.
2230         * ada-tasks.c (print_ada_task_info): Update.
2231         * ada-lang.c (print_it_exception, print_mention_exception):
2232         Update.
2233
2234 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2235
2236         PR breakpoints/24541
2237         * gdbarch.c: Regenerate.
2238         * gdbarch.h: Regenerate.
2239         * gdbarch.sh: Adjust return type and parameter types for
2240         'stap_adjust_register'.
2241         (i386_stap_adjust_register): Adjust signature and return new
2242         register name.
2243         * stap-probe.c (stap_parse_register_operand): Adjust use of
2244         'gdbarch_stap_adjust_register'.
2245
2246 2019-07-17  Tom Tromey  <tromey@adacore.com>
2247
2248         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2249         declare VEC.
2250         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2251         std::vector.
2252         (struct s390_process_info): Add initializers.
2253         (s390_add_process): Use new.
2254         (s390_linux_nat_target::low_forget_process): Use delete.
2255         (s390_linux_nat_target::low_new_fork)
2256         (s390_linux_nat_target::stopped_by_watchpoint)
2257         (s390_linux_nat_target::low_prepare_to_resume)
2258         (s390_linux_nat_target::insert_watchpoint)
2259         (s390_linux_nat_target::insert_hw_breakpoint)
2260         (s390_linux_nat_target::remove_watchpoint)
2261         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2262
2263 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2264
2265         * aarch64-fbsd-nat.c: Include regcache.h.
2266         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2267         argument.
2268         (aarch64_fbsd_nat_target::fetch_registers)
2269         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2270         variable.
2271         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2272
2273 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2274
2275         * fbsd-nat.c: Include gdbarch.h.
2276
2277 2019-07-15  Tom Tromey  <tromey@adacore.com>
2278
2279         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2280
2281 2019-07-15  Tom Tromey  <tromey@adacore.com>
2282
2283         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2284         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2285         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2286         * cli-out.c (cli_ui_out::do_field_int): New method.
2287         * ui-out.c (ui_out::field_unsigned): New method.
2288         * symfile.c (generic_load): Use field_unsigned.
2289         (print_transfer_performance): Likewise.
2290         * record-btrace.c (ui_out_field_uint): Remove.
2291         (btrace_call_history_insn_range, btrace_call_history): Use
2292         field_unsigned.
2293         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2294         field_unsigned.
2295         * ui-out.h (class ui_out) <field_unsigned>: New method.
2296         <do_field_unsigned>: Likewise.
2297
2298 2019-07-15  Tom Tromey  <tromey@adacore.com>
2299
2300         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2301         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2302         * target.c (flash_erase_command): Use field_string.
2303         * infrun.c (print_signal_received_reason): Use field_string.
2304         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2305         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2306         field_string.
2307         * ada-tasks.c (print_ada_task_info): Use field_string.
2308
2309 2019-07-15  Tom Tromey  <tromey@adacore.com>
2310
2311         * target.c (flash_erase_command): Use field_core_addr.
2312         * symfile.c (generic_load): Use field_core_addr.
2313         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2314         Use field_core_addr.
2315         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2316         field_core_addr.
2317
2318 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2319
2320         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2321         value if its desired type is smaller than a CORE_ADDR and signed.
2322
2323 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2324
2325         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2326         of changes to field names, and use new is_reference field to
2327         decide if a property is a reference or not.
2328         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2329         field.
2330         (struct dwarf2_property_baton): Update header comment, rename
2331         'referenced_type' to 'property_type' and update comments.
2332         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2333         default property type, store in property baton, update to take
2334         accound of renamed field.
2335         (read_func_scope): Update call to attr_to_dynamic_prop.
2336         (read_array_type): Likewise.
2337         (dwarf2_per_cu_addr_sized_int_type): New function.
2338         (read_subrange_index_type): Move type finding code to
2339         dwarf2_per_cu_addr_sized_int_type.
2340         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2341         (dwarf2_per_cu_addr_type): New function.
2342         (set_die_type): Update calls to attr_to_dynamic_prop.
2343
2344 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2345
2346         * dwarf2read.c (read_subrange_index_type): New function.
2347         (read_subrange_type): Move code into new function and call it.
2348         * gdbtypes.c (create_range_type): Add some asserts.
2349
2350 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2351
2352         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2353         update return statements.
2354         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2355         declaration, and update comment to match.
2356         * gdbtypes.c (resolve_dynamic_array): Update call to
2357         dwarf2_evaluate_property to match new return type.
2358
2359 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2360
2361         * valarith.c (value_subscripted_rvalue): Change lowerbound
2362         parameter type from int to LONGEST.
2363         * value.h (value_subscripted_rvalue): Likewise in declaration.
2364
2365 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2366
2367         * cli/cli-utils.c (info_print_command_completer): New function.
2368         * cli/cli-utils.h: Add 'completer.h' include, and forward
2369         declaration for 'struct cmd_list_element'.
2370         (info_print_command_completer): Declare.
2371         * stack.c (_initialize_stack): Add completer for 'info locals' and
2372         'info args'.
2373         * symtab.c (_initialize_symtab): Add completer for 'info
2374         variables' and 'info functions'.
2375         * NEWS: Mention completion for additional info commands.
2376
2377 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2378
2379         * cli/cli-utils.c (extract_info_print_args): Delete.
2380         (extract_arg_maybe_quoted): Delete.
2381         (info_print_options_defs): New variable.
2382         (make_info_print_options_def_group): New function.
2383         (extract_info_print_options): Define new function.
2384         * cli/cli-utils.h (extract_info_print_args): Delete.
2385         (struct info_print_options): New structure.
2386         (extract_info_print_options): Declare new function.
2387         * stack.c (info_locals_command): Update to use new
2388         extract_info_print_options, also add a header comment.
2389         (info_args_command): Likewise.
2390         * symtab.c (info_variables_command): Likewise.
2391         (info_functions_command): Likewise.
2392
2393 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2394
2395         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2396         to extract string arguments.
2397         * common/common-utils.c (extract_string_maybe_quoted): New function.
2398         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2399
2400 2019-07-11  Tom Tromey  <tromey@adacore.com>
2401
2402         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2403         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2404         * top.h (gdbinit): Don't declare.
2405         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2406         into...
2407         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2408         * top.c (gdb_init): Don't call init_cli_cmds.
2409         (gdbinit): Remove.
2410         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2411
2412 2019-07-11  Tom Tromey  <tromey@adacore.com>
2413
2414         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2415         after it has been moved.
2416
2417 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2418
2419         * valops.c (value_must_coerce_to_target): Change return type to
2420         bool.
2421         * value.h (value_must_coerce_to_target): Likewise.
2422
2423 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2424
2425         * breakpoint.c (is_hardware_watchpoint): Remove
2426         forward-declaration.
2427         (is_masked_watchpoint): Change return type to bool.
2428         (is_tracepoint): Likewise.
2429         (is_breakpoint): Likewise.
2430         (is_hardware_watchpoint): Likewise.
2431         (is_watchpoint): Likewise.
2432         (is_no_memory_software_watchpoint): Likewise.
2433         (is_catchpoint): Likewise.
2434         (breakpoint_1): Make FILTER parameter's return type bool.
2435         is_masked_watchpoint): Change return type to bool.
2436         (save_breakpoints): Make FILTER parameter's return type bool.
2437         * breakpoint.h (is_breakpoint): Change return type to bool.
2438         (is_watchpoint): Likewise.
2439         (is_catchpoint): Likewise.
2440         (is_tracepoint): Likewise.
2441
2442 2019-07-10  Tom Tromey  <tom@tromey.com>
2443
2444         * defs.h: Don't include gdbarch.h.
2445         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2446         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2447         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2448         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2449         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2450         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2451         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2452         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2453         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2454         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2455         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2456         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2457         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2458         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2459         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2460         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2461         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2462         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2463         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2464         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2465         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2466         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2467         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2468         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2469         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2470         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2471         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2472
2473 2019-07-10  Tom Tromey  <tromey@adacore.com>
2474
2475         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2476         * breakpoint.c (init_ada_exception_breakpoint): Register as
2477         bp_catchpoint.
2478         (print_one_breakpoint_location, print_one_breakpoint): Use
2479         is_ada_exception_catchpoint.
2480         * ada-lang.c (class ada_catchpoint_location): Pass
2481         bp_loc_software_breakpoint to bp_location constructor.
2482         (is_ada_exception_catchpoint): New function.
2483
2484 2019-07-10  Tom Tromey  <tromey@adacore.com>
2485
2486         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2487         VEC.
2488         (struct arm_exidx_entry): New method operator<.
2489         (struct arm_exidx_data) <section_maps>: Change type.
2490         (arm_exidx_data_free): Remove.
2491         (arm_exidx_data_key): Change type.  Move lower.
2492         (arm_exidx_new_objfile): Update.
2493         (arm_compare_exidx_entries): Remove.
2494         (arm_find_exidx_entry, _initialize_arm_tdep)
2495
2496 2019-07-10  Tom Tromey  <tromey@adacore.com>
2497
2498         * solib-spu.c (ocl_program_data_key): Change type.
2499         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2500         Update.
2501
2502 2019-07-10  Tom Tromey  <tromey@adacore.com>
2503
2504         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2505         (struct solib_aix_inferior_data) <library_list>: Change type.
2506         (solib_aix_inferior_data_handle): Change type.
2507         (get_solib_aix_inferior_data): Update.
2508         (solib_aix_free_library_list): Remove.
2509         (library_list_start_library): Update.
2510         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2511         return type.
2512         (solib_aix_get_library_list)
2513         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2514         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2515
2516 2019-07-10  Tom Tromey  <tromey@adacore.com>
2517
2518         * solib-dsbt.c (struct dsbt_info): Add initializers.
2519         (solib_dsbt_pspace_data): Change type.
2520         (dsbt_pspace_data_cleanup): Remove.
2521         (get_dsbt_info, _initialize_dsbt_solib): Update.
2522
2523 2019-07-10  Tom Tromey  <tromey@adacore.com>
2524
2525         * spu-tdep.c (spu_overlay_data): Change type.
2526         (spu_get_overlay_table, spu_overlay_new_objfile)
2527         (_initialize_spu_tdep): Update.
2528
2529 2019-07-10  Tom Tromey  <tromey@adacore.com>
2530
2531         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2532         destructor.
2533         (dbx_objfile_data_key): Change type and declare later.
2534         (DBX_SYMFILE_INFO): Rewrite.
2535         * dbxread.c (dbx_objfile_data_key): Change type.
2536         (dbx_symfile_init): Update.
2537         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2538         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2539         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2540
2541 2019-07-10  Tom Tromey  <tromey@adacore.com>
2542
2543         * jit.c (jit_program_space_key): Change type.  Move lower.
2544         (get_jit_program_space_data): Update.
2545         (jit_program_space_data_cleanup): Remove.
2546         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2547         Update.
2548         (struct jit_program_space_data): Add initializers.
2549
2550 2019-07-10  Tom Tromey  <tromey@adacore.com>
2551
2552         * solib-darwin.c (struct darwin_info): Add initializers.
2553         (solib_darwin_pspace_data): Change type.
2554         (darwin_pspace_data_cleanup): Remove.
2555         (get_darwin_info, _initialize_darwin_solib): Update.
2556
2557 2019-07-10  Tom Tromey  <tromey@adacore.com>
2558
2559         * remote-sim.c (struct sim_inferior_data): Add initializers,
2560         constructor, and destructor.
2561         (sim_inferior_data_key): Change type.  Move lower.
2562         (check_for_duplicate_sim_descriptor): Update.
2563         (get_sim_inferior_data): Use new.  Update.
2564         (~sim_inferior_data_cleanup): Rename from
2565         sim_inferior_data_cleanup.  Simplify.
2566         (gdbsim_close_inferior, simulator_command)
2567         (sim_command_completer, _initialize_remote_sim): Update.
2568         (next_pid, INITIAL_PID): Move earlier.
2569
2570 2019-07-10  Tom Tromey  <tromey@adacore.com>
2571
2572         * python/python-internal.h (create_thread_object): Return
2573         gdbpy_ref.
2574         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2575         * python/py-inferior.c (struct threadlist_entry): Add
2576         constructor.
2577         <thread_obj>: Now a gdbpy_ref.
2578         (thread_to_thread_object): Update.
2579         (add_thread_object): Use new.
2580         (delete_thread_object): Use delete.
2581         (infpy_threads): Update.
2582         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2583         GIL.
2584
2585 2019-07-10  Tom Tromey  <tromey@adacore.com>
2586
2587         * valops.c (value_cast): Specialize error message for Ada.
2588
2589 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2590
2591         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2592
2593 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2594
2595         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2596         bpstat_should_step): Return bool, adjust comments.
2597         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2598         bpstat_should_step): Likewise.
2599
2600 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2601
2602         * features/Makefile: Use feature target descriptions for Arm.
2603         * features/arm/arm-core.c: Generate new file.
2604         * features/arm/arm-fpa.c: Likewise.
2605         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2606         * features/arm/arm-m-profile.c: Likewise.
2607         * features/arm/arm-vfpv2.c: Likewise.
2608         * features/arm/arm-vfpv3.c: Likewise.
2609         * features/arm/xscale-iwmmxt.c: Likewise.
2610         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2611
2612 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2613
2614         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2615         ptrace earlier.
2616
2617 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2618
2619         * features/aarch64-pauth.c: Regenerate.
2620
2621 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2622
2623         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2624         bool.
2625         (bpstat_what): Use false instead of 0.
2626
2627 2019-07-09  Pedro Alves  <palves@redhat.com>
2628
2629         * break-catch-throw.c (is_exception_catchpoint): New.
2630         * breakpoint.c (print_one_breakpoint_location): New parameter
2631         'raw_loc'.  Handle it.  Use
2632         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2633         looking at the breakpoint's type.
2634         (print_one_breakpoint): If handling "maint info breakpoints", also
2635         print locations of exception catchpoints.
2636         * breakpoint.h (is_exception_catchpoint): Declare.
2637
2638 2019-07-09  Pedro Alves  <palves@redhat.com>
2639
2640         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2641         "addr" field.
2642         (allocate_location_exception_catchpoint): New.
2643         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2644         (initialize_throw_catchpoint_ops): Install
2645         allocate_location_exception_catchpoint as allocate_location
2646         method.
2647         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2648         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2649         bp_loc_other.
2650         (breakpoint_address_is_meaningful): Delete.
2651         (bl_address_is_meaningful): New.
2652         (breakpoint_locations_match): Adjust comment.
2653         (bp_location_from_bp_type): New, factored out of...
2654         (bp_location::bp_location(breakpoint *)): ... this.
2655         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2656         factored out of...
2657         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2658         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2659         breakpoint_address_is_meaningful.
2660         (bp_locations_compare): Adjust comment.
2661         (update_global_location_list): Use bl_address_is_meaningful
2662         instead of breakpoint_address_is_meaningful.
2663         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2664         explicit.
2665         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2666         * python/py-breakpoint.c (bppy_get_location): No longer check
2667         whether location is null.
2668
2669 2019-07-09  Pedro Alves  <palves@redhat.com>
2670
2671         PR c++/15468
2672         * breakpoint.c (print_one_breakpoint_location): Remove
2673         single-location assert.
2674
2675 2019-07-09  Tom Tromey  <tom@tromey.com>
2676
2677         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2678         * configure: Rebuild.
2679         * configure.ac: Change common to gdbsupport.
2680         * gdbsupport: Rename from common.
2681         * acinclude.m4: Change common to gdbsupport.
2682         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2683         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2684         gdbsupport.
2685         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2686         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2687         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2688         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2689         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2690         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2691         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2692         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2693         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2694         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2695         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2696         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2697         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2698         coff-pe-read.c, command.h, compile/compile-c-support.c,
2699         compile/compile-c.h, compile/compile-cplus-symbols.c,
2700         compile/compile-cplus-types.c, compile/compile-cplus.h,
2701         compile/compile-loc2c.c, compile/compile.c, completer.c,
2702         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2703         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2704         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2705         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2706         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2707         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2708         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2709         features/aarch64-core.c, features/aarch64-fpu.c,
2710         features/aarch64-pauth.c, features/aarch64-sve.c,
2711         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2712         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2713         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2714         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2715         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2716         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2717         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2718         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2719         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2720         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2721         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2722         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2723         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2724         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2725         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2726         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2727         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2728         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2729         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2730         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2731         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2732         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2733         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2734         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2735         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2736         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2737         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2738         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2739         minsyms.c, mips-linux-tdep.c, namespace.h,
2740         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2741         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2742         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2743         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2744         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2745         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2746         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2747         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2748         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2749         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2750         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2751         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2752         procfs.c, producer.c, progspace.h, psymtab.h,
2753         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2754         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2755         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2756         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2757         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2758         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2759         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2760         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2761         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2762         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2763         target-memory.c, target.c, target.h, target/waitstatus.c,
2764         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2765         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2766         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2767         unittests/array-view-selftests.c,
2768         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2769         unittests/common-utils-selftests.c,
2770         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2771         unittests/format_pieces-selftests.c,
2772         unittests/function-view-selftests.c,
2773         unittests/lookup_name_info-selftests.c,
2774         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2775         unittests/mkdir-recursive-selftests.c,
2776         unittests/observable-selftests.c,
2777         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2778         unittests/parse-connection-spec-selftests.c,
2779         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2780         unittests/scoped_fd-selftests.c,
2781         unittests/scoped_mmap-selftests.c,
2782         unittests/scoped_restore-selftests.c,
2783         unittests/string_view-selftests.c, unittests/style-selftests.c,
2784         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2785         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2786         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2787         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2788         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2789         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2790
2791 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2792
2793         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2794         bool value.
2795         (decode_digits_ordinary): Set explicit_line field in sal.
2796         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2797         symtab_and_line that was set on an explicit line number in
2798         assembler code.  Do always update the recorded symtab and line if
2799         we do skip the prologue.
2800
2801 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2802
2803         * breakpoint.c (set_breakpoint_location_function): Remove
2804         explicit_loc parameter.
2805         (momentary_breakpoint_from_master): Update call to
2806         set_breakpoint_location_function.
2807         (add_location_to_breakpoint): Likewise.
2808
2809 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2810
2811         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2812         required features based on default bfd type when no specific bfd
2813         is present.
2814
2815 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2816
2817         * NEWS: Mention that GDB printf and eval commands can now print
2818         C-style and Ada-style convenience var strings without
2819         calling the inferior.
2820         * printcmd.c (printf_c_string): Locally print GDB internal var
2821         instead of transiting via the inferior.
2822         (printf_wide_c_string): Likewise.
2823
2824 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2825
2826         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2827
2828 2019-07-04  Tom Tromey  <tom@tromey.com>
2829
2830         PR tui/24724:
2831         * tui/tui-winsource.c (tui_clear_source_content): Update.
2832         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2833         (tui_update_breakpoint_info): Update.
2834         (tui_set_exec_info_content): Update.
2835         * tui/tui-source.c (tui_set_source_content_nil): Update.
2836         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2837         has_break.
2838         * tui/tui-data.h (enum tui_bp_flag): New.
2839         (tui_bp_flags): New enum flags type.
2840         (struct tui_source_element) <break_mode>: Change type.  Rename
2841         from has_break.
2842         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2843         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2844         constants.
2845         * tui/tui-winsource.h: Fix comment.
2846
2847 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2848
2849         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2850         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2851         (store_fpregs_to_thread)
2852         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2853         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2854         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2855         (IWMMXT_REGS_SIZE): Add define.
2856         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2857         (fetch_vfp_regs, store_vfp_regs)
2858         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2859         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2860
2861 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2862
2863         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2864         defines.
2865         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2866         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2867         (ARM_INT_REGISTER_SIZE): ...to this.
2868         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2869         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2870         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2871         (arm_linux_collect_gregset, supply_nwfpe_register)
2872         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2873         defines.
2874         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2875         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2876         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2877         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2878         (arm_return_in_memory, arm_store_return_value)
2879         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2880         (arm_record_ld_st_multiple): Likewise.
2881         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2882         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2883
2884 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2885
2886         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2887         AARCH64_DISPLACED_MODIFIED_INSNS.
2888         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2889         (aarch64_displaced_step_copy_insn): Likewise.
2890         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2891         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2892         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2893         ARM_DISPLACED_MODIFIED_INSNS.
2894         * arm-tdep.c (arm_gdbarch_init): Likewise.
2895         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2896         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2897         (struct arm_displaced_step_closure): Use
2898         ARM_DISPLACED_MODIFIED_INSNS.
2899
2900 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2901
2902         * features/Makefile: Remove unused xml files.
2903         * features/aarch64.xml: Remove.
2904         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2905         * features/i386/amd64-avx-avx512.xml: Remove.
2906         * features/i386/amd64-avx-linux.xml: Remove.
2907         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2908         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2909         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2910         * features/i386/amd64-avx-mpx.xml: Remove.
2911         * features/i386/amd64-avx.xml: Remove.
2912         * features/i386/amd64-linux.xml: Remove.
2913         * features/i386/amd64-mpx-linux.xml: Remove.
2914         * features/i386/amd64-mpx.xml: Remove.
2915         * features/i386/amd64.xml: Remove.
2916         * features/i386/i386-avx-avx512-linux.xml: Remove.
2917         * features/i386/i386-avx-avx512.xml: Remove.
2918         * features/i386/i386-avx-linux.xml: Remove.
2919         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2920         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2921         * features/i386/i386-avx-mpx-linux.xml: Remove.
2922         * features/i386/i386-avx-mpx.xml: Remove.
2923         * features/i386/i386-avx.xml: Remove.
2924         * features/i386/i386-linux.xml: Remove.
2925         * features/i386/i386-mmx-linux.xml: Remove.
2926         * features/i386/i386-mmx.xml: Remove.
2927         * features/i386/i386-mpx-linux.xml: Remove.
2928         * features/i386/i386-mpx.xml: Remove.
2929         * features/i386/i386.xml: Remove.
2930         * features/i386/x32-avx-avx512-linux.xml: Remove.
2931         * features/i386/x32-avx-linux.xml: Remove.
2932         * features/i386/x32-linux.xml: Remove.
2933
2934 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2935
2936         * regformats/aarch64.dat: Remove.
2937         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2938         * regformats/i386/amd64-avx-linux.dat: Remove.
2939         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2940         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2941         * regformats/i386/amd64-linux.dat: Remove.
2942         * regformats/i386/amd64-mpx-linux.dat: Remove.
2943         * regformats/i386/amd64.dat: Remove.
2944         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2945         * regformats/i386/i386-avx-linux.dat: Remove.
2946         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2947         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2948         * regformats/i386/i386-linux.dat: Remove.
2949         * regformats/i386/i386-mmx-linux.dat: Remove.
2950         * regformats/i386/i386-mpx-linux.dat: Remove.
2951         * regformats/i386/i386.dat: Remove.
2952         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2953         * regformats/i386/x32-avx-linux.dat: Remove.
2954         * regformats/i386/x32-linux.dat: Remove.
2955
2956 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2957
2958         * aarch64-tdep.c: Remove xml self tests.
2959         * amd64-linux-tdep.c: Likewise.
2960         * amd64-tdep.c: Likewise.
2961         * i386-linux-tdep.c: Likewise.
2962         * i386-tdep.c: Likewise.
2963
2964 2019-07-03  Pedro Alves  <palves@redhat.com>
2965
2966         PR cli/24732
2967         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2968         (pipe_cmd_option_defs): New.
2969         (make_pipe_cmd_options_def_group): New.
2970         (pipe_command): Use gdb::option::process_options.
2971         (pipe_command_completer): New function.
2972         (_initialize_cli_cmds): Install completer for "pipe" command.
2973
2974 2019-07-03  Pedro Alves  <palves@redhat.com>
2975
2976         * cli/cli-option.c (union option_value) <string>: New field.
2977         (struct option_def_and_value): Add ctor, move ctor, dtor and
2978         use DISABLE_COPY_AND_ASSIGN.
2979         (option_def_and_value::clear_value): New.
2980         (parse_option, save_option_value_in_ctx, get_val_type_str)
2981         (add_setshow_cmds_for_options): Handle var_string.
2982         * cli-option.h (union option_def::var_address) <string>: New
2983         field.
2984         (struct string_option_def): New.
2985         * maint-test-options.c (struct test_options_opts): Add default
2986         ctor and use DISABLE_COPY_AND_ASSIGN.
2987         <string_opt>: New field.
2988         (test_options_opts::~test_options_opts): New.
2989         (test_options_opts::dump): Also dump "-string".
2990         (test_options_option_defs): Install "string.
2991
2992 2019-07-03  Pedro Alves  <palves@redhat.com>
2993
2994         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2995         option_value with a null enumeration.
2996         (complete_options): Save the option values in the context.
2997         (save_option_value_in_ctx): New, factored out from ...
2998         (process_options): ... here.
2999         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3000         of the function.
3001         * maint-test-options.c (test_options_opts::dump): New, factored
3002         out from ...
3003         (maintenance_test_options_command_mode): ... here.
3004         (maintenance_test_options_command_completion_result): Delete.
3005         (maintenance_test_options_command_completion_text): Update
3006         comment.
3007         (maintenance_show_test_options_completion_result): Change
3008         prototype.  Just print
3009         maintenance_test_options_command_completion_text.
3010         (save_completion_result): New.
3011         (maintenance_test_options_completer_mode): Pass options context to
3012         complete_options, and then save a dump.
3013         (_initialize_maint_test_options): Use add_cmd to install "maint
3014         show test-options-completion-result".
3015
3016 2019-07-03  Pedro Alves  <palves@redhat.com>
3017
3018         * NEWS (New commands): Mention "with" and "maint with".
3019         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3020         (with_command, with_command_completer): New.
3021         (pipe_command): Adjust to new repeat_previous
3022         interface.
3023         (_initialize_cli_cmds): Install the "with" command and its "w"
3024         alias.
3025         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3026         declarations.
3027         * cli/cli-setshow.c (parse_cli_var_uinteger)
3028         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3029         argument strings for all var_types.
3030         (get_setshow_command_value_string): New, factored out from ...
3031         (do_show_command): ... this.
3032         * cli/cli-setshow.h: Include <string>.
3033         (get_setshow_command_value_string): Declare.
3034         * command.h (repeat_previous): Now returns const char *.  Adjust
3035         comment.
3036         * maint.c: Include "cli/cli-cmds.h".
3037         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3038         (_initialize_maint_cmds): Register the "maintenance with" command.
3039         * top.c (repeat_previous): Move bits from pipe_command here:
3040         Return the saved command line, if any; error out if there's no
3041         command to relaunch.
3042
3043 2019-07-03  Pedro Alves  <palves@redhat.com>
3044
3045         * NEWS (New commands): Mention "maint set/show test-settings"
3046         instead of "maint test-settings".
3047         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3048         (maintenance_test_settings_set_list): Rename to ...
3049         (maintenance_set_test_settings_list): ... this.
3050         (maintenance_test_settings_show_list): Rename to  ...
3051         (maintenance_show_test_settings_list): ... this.
3052         (maintenance_test_settings_cmd): Delete.
3053         (maintenance_test_settings_set_cmd): ...
3054         (maintenance_set_test_settings_cmd): ... this.
3055         (maintenance_test_settings_show_cmd): ...
3056         (maintenance_show_test_settings_cmd): ... this.
3057         (maintenance_test_settings_show_value_cmd):
3058         (maintenance_show_test_settings_value_cmd): ... this.
3059         (_initialize_maint_test_settings): No longer install the "maint
3060         test-settings" prefix command.  Rename "maint test-settings set"
3061         to "maint set test-settings", and "maint test-settings show" to
3062         "maint show test-settings".  Adjust all subcommands.
3063
3064 2019-07-03  Pedro Alves  <palves@redhat.com>
3065
3066         * maint-test-settings.c: Fix file's intro comment.  Replace all
3067         references to "test-options" with references to "test-settings",
3068         in comments.
3069
3070 2019-07-03  Pedro Alves  <palves@redhat.com>
3071
3072         * maint-test-settings.c (maintenance_test_settings_xxx)
3073         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3074         New.
3075         (maintenance_test_settings_enums): Use them.
3076         (maintenance_test_settings_enum): Default to
3077         maintenance_test_settings_xxx.
3078         (_initialize_maint_test_settings): Initialize
3079         MAINTENANCE_TEST_SETTINGS_FILENAME.
3080
3081 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3082
3083         * breakpoint.h (remove_breakpoints_inf): Change return type to
3084         void, move function documentation here.
3085         * breakpoint.c (remove_breakpoints_inf): Change return type to
3086         void, move function documentation to header.
3087
3088 2019-07-02  Pedro Alves  <palves@redhat.com>
3089
3090         * NEWS (Completion improvements): Mention "info threads".
3091         * thread.c (struct info_threads_opts, info_threads_option_defs)
3092         (make_info_threads_options_def_group): New.
3093         (info_threads_command): Use gdb::option::process_options.
3094         (info_threads_command_completer): New.
3095         (_initialize_thread): Use gdb::option::build_help to build the
3096         help text for "info threads".
3097
3098 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3099
3100         * defs.h (generic_load): Move from here...
3101         * symfile.h (generic_load): ... to here.  Rename name parameter
3102         to args.
3103         * symfile.c (generic_load): Add comment.
3104
3105 2019-07-01  Tom Tromey  <tromey@adacore.com>
3106
3107         * dwarf2read.c
3108         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3109         declaration of without_params.  Fix formatting.
3110
3111 2019-07-01  Tom Tromey  <tromey@adacore.com>
3112
3113         * ada-exp.y (find_primitive_type): Update.
3114         * ada-lang.h (ada_lookup_symbol): Update.
3115         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3116         parameter.
3117         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3118
3119 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3120
3121         PR breakpoints/24541
3122         * gdbarch.c: Regenerate.
3123         * gdbarch.h: Regenerate.
3124         * gdbarch.sh: Add 'stap_adjust_register'.
3125         * i386-tdep.c: Include '<unordered_set>'.
3126         (i386_stap_adjust_register): New function.
3127         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3128         * stap-probe.c (stap_parse_register_operand): Call
3129         'gdbarch_stap_adjust_register'.
3130
3131 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3132
3133         PR python/24742
3134         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3135         * python/python.c (do_start_initialization): Use 'xmalloc'
3136         instead of 'PyMem_Malloc'.
3137
3138 2019-06-28  Tom Tromey  <tromey@adacore.com>
3139
3140         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3141         for Ada.
3142
3143 2019-06-27  Tom Tromey  <tromey@adacore.com>
3144
3145         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3146         objfile_key.
3147         (arm_find_mapping_symbol, arm_record_special_symbol)
3148         (_initialize_arm_tdep): Update.
3149         (arm_objfile_data_free): Remove.
3150
3151 2019-06-27  Tom Tromey  <tromey@adacore.com>
3152
3153         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3154         to cp_print_static_field.
3155
3156 2019-06-26  Tom Tromey  <tromey@adacore.com>
3157
3158         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3159         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3160         declare.
3161
3162 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3163
3164         * features/aarch64-core.c (create_feature_aarch64_core):
3165         Regenerate.
3166         * features/aarch64-core.xml: Add cpsr flags.
3167
3168 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3169
3170         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3171         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3172
3173 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3174
3175         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3176         field.
3177         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3178         use.
3179         (arm_record_special_symbol): Don't insert new symbol in sorted
3180         position, push it at the end.
3181
3182 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3183
3184         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3185         (arm_mapping_symbol_s): Remove.
3186         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3187         (arm_mapping_symbol_vec): New typedef.
3188         (struct arm_per_objfile): Add constructor.
3189         <section_maps>: Change type to
3190         std::unique_ptr<arm_mapping_symbol_vec[]>.
3191         (arm_compare_mapping_symbols): Remove.
3192         (arm_find_mapping_symbol): Adjust to section_maps type change.
3193         (arm_objfile_data_free): Call delete on arm_per_objfile.
3194         (arm_record_special_symbol): Adjust to section_maps type change.
3195         Allocate arm_per_objfile with new.
3196
3197 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3198
3199         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3200         with the command prefix.
3201
3202 2019-06-25  Tom Tromey  <tom@tromey.com>
3203
3204         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3205         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3206
3207 2019-06-25  Tom Tromey  <tom@tromey.com>
3208
3209         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3210         type.
3211         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3212         protected.
3213
3214 2019-06-25  Tom Tromey  <tom@tromey.com>
3215
3216         * tui/tui-winsource.c
3217         (tui_source_window_base::set_is_exec_point_at): Add check against
3218         LOA_ADDRESS.
3219
3220 2019-06-25  Tom Tromey  <tom@tromey.com>
3221
3222         * tui/tui-source.c (tui_set_source_content): Don't check before
3223         xfree.
3224         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3225
3226 2019-06-25  Tom Tromey  <tom@tromey.com>
3227
3228         * tui/tui-winsource.h (tui_update_source_window_as_is)
3229         (tui_alloc_source_buffer, tui_line_is_displayed)
3230         (tui_addr_is_displayed): Change type of win_info.
3231         * tui/tui-winsource.c (tui_update_source_window_as_is)
3232         (tui_clear_source_content, tui_show_source_line)
3233         (tui_show_source_content, tui_source_window_base::refill)
3234         (tui_source_window_base::set_is_exec_point_at)
3235         (tui_source_window_base::set_is_exec_point_at)
3236         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3237         (tui_alloc_source_buffer, tui_line_is_displayed)
3238         (tui_addr_is_displayed): Change type of win_info.  Update.
3239         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3240         (tui_source_window_base::do_make_visible_with_new_height):
3241         Update.
3242         * tui/tui-source.c (tui_set_source_content)
3243         (tui_set_source_content_nil)
3244         (tui_source_window::do_scroll_vertical): Update.
3245         * tui/tui-layout.c (show_layout): Update.
3246         * tui/tui-disasm.c (tui_set_disassem_content)
3247         (tui_disasm_window::do_scroll_vertical): Update.
3248         * tui/tui-data.h (tui_win_content): Remove.
3249         (struct tui_gen_win_info) <content, content_size>: Remove.
3250         (struct tui_source_element): Add initializers and destructor.
3251         (union tui_which_element, struct tui_win_element): Remove.
3252         (struct tui_source_window_base) <content>: New field.
3253         (struct tui_data_window): Remove destructor.
3254         (tui_alloc_content, tui_free_win_content)
3255         (tui_free_all_source_wins_content): Don't declare.
3256         * tui/tui-data.c (tui_initialize_static_data): Update.
3257         (init_content_element, tui_alloc_content): Remove.
3258         (~tui_gen_win_info): Update.
3259         (~tui_data_window, tui_free_all_source_wins_content)
3260         (tui_free_win_content, free_content, free_content_elements):
3261         Remove.
3262
3263 2019-06-25  Tom Tromey  <tom@tromey.com>
3264
3265         * tui/tui-winsource.h (tui_clear_source_content)
3266         (tui_erase_source_content, tui_show_source_content): Change type
3267         of win_info.
3268         * tui/tui-winsource.c (tui_clear_source_content)
3269         (tui_erase_source_content, tui_show_source_content): Change type
3270         of win_info.
3271         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3272         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3273         win_info.
3274         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3275         win_info.
3276         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3277
3278 2019-06-25  Tom Tromey  <tom@tromey.com>
3279
3280         * tui/tui-winsource.c (tui_clear_source_content)
3281         (tui_source_window_base::set_is_exec_point_at): Update.
3282         * tui/tui-source.c (tui_set_source_content_nil): Update.
3283         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3284         a bool.
3285         * tui/tui-data.c (init_content_element): Update.
3286
3287 2019-06-25  Tom Tromey  <tom@tromey.com>
3288
3289         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3290         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3291         * tui/tui-layout.c (init_and_make_win): Update.
3292         * tui/tui.h (enum tui_win_type): Update.
3293         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3294         tui_win_is_auxillary.
3295         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3296         tui_win_is_auxillary.
3297
3298 2019-06-25  Tom Tromey  <tom@tromey.com>
3299
3300         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3301         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3302         (tui_delete_data_content_windows, tui_display_all_data)
3303         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3304         Update.
3305         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3306         * tui/tui-regs.c (tui_last_regs_line_no)
3307         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3308         (tui_show_registers): Update.
3309         (tui_show_register_group): Return void.  Update.
3310         (tui_display_registers_from, tui_display_reg_element_at_line)
3311         (tui_display_registers_from_line, tui_check_register_values):
3312         Update.
3313         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3314         member.
3315         (struct tui_data_window) <regs_content>: Now a std::vector.
3316         <regs_content_count>: Remove.
3317         (tui_add_content_elements, tui_free_data_content): Don't declare.
3318         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3319         (init_content_element): Remove DATA_WIN case.  Add assert.
3320         (tui_add_content_elements): Remove.
3321         (tui_data_window): Update.
3322         (tui_free_data_content): Remove.
3323         (free_content_elements): Remove DATA_WIN case.
3324
3325 2019-06-25  Tom Tromey  <tom@tromey.com>
3326
3327         * tui/tui-data.c (tui_data_item_window): Update.
3328         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3329         * tui/tui-windata.c (tui_display_all_data)
3330         (tui_display_data_from_line): Update.
3331         (tui_check_data_values): Remove.
3332         * tui/tui-regs.c (tui_show_register_group)
3333         (tui_display_reg_element_at_line): Update.
3334         * tui/tui-hooks.c (tui_register_changed)
3335         (tui_refresh_frame_and_register_information): Call
3336         tui_check_register_values.
3337         * tui/tui-data.h (struct tui_data_window) <data_content,
3338         data_content_count, data_type>: Remove.
3339         (enum tui_data_type): Remove.
3340
3341         * tui/tui-data.c (tui_data_window::clear_detail)
3342         (~tui_data_window): Update.
3343
3344 2019-06-25  Tom Tromey  <tom@tromey.com>
3345
3346         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3347         declare.
3348         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3349         Rename from tui_first_data_item_displayed.  Update.
3350         (tui_data_window::refresh_all)
3351         (tui_data_window::do_scroll_vertical): Update.
3352         * tui/tui-data.h (struct tui_data_window)
3353         <first_data_item_displayed>: Declare new method.
3354
3355 2019-06-25  Tom Tromey  <tom@tromey.com>
3356
3357         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3358         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3359         contents...
3360         (tui_initialize_static_data): ...here.
3361
3362 2019-06-25  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3365         (tui_display_registers_from, tui_check_register_values): Update.
3366         (tui_display_register): Remove win_info parameter; update.
3367         (tui_get_register): Change type of parameters.
3368         * tui/tui-data.h (struct tui_data_element): Remove.
3369         (union tui_which_element) <data>: Remove.
3370         <data_window>: Change type.
3371         (struct tui_data_item_window): New.
3372         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3373         case.  Add assert.
3374         (~tui_data_item_window): New destructor.
3375         (free_content_elements): Remove DATA_ITEM_WIN case.
3376
3377 2019-06-25  Tom Tromey  <tom@tromey.com>
3378
3379         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3380         Remove.
3381
3382 2019-06-25  Tom Tromey  <tom@tromey.com>
3383
3384         * tui/tui-data.h (struct tui_command_element): Remove.
3385         (union tui_which_element) <command>: Remove.
3386         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3387         assert.
3388         (free_content_elements): Remove CMD_WIN case.
3389
3390 2019-06-25  Tom Tromey  <tom@tromey.com>
3391
3392         * tui/tui-layout.c (tui_set_layout): Update.
3393         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3394         * tui/tui-data.c (layout_def): Update.
3395
3396 2019-06-25  Tom Tromey  <tom@tromey.com>
3397
3398         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3399         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3400         (tui_source_window_base::set_new_height): Update.
3401         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3402         Update.
3403         (tui_set_locator_fullname, tui_set_locator_info)
3404         (tui_show_frame_info): Update.
3405         * tui/tui-source.c (tui_set_source_content)
3406         (tui_source_is_displayed): Update.
3407         * tui/tui-layout.c (show_source_disasm_command, show_data)
3408         (show_source_or_disasm_and_command): Update.
3409         * tui/tui-disasm.c (tui_set_disassem_content)
3410         (tui_get_begin_asm_address): Update.
3411         * tui/tui-data.h (struct tui_locator_element): Remove.
3412         (union tui_which_element) <locator>: Remove.
3413         (struct tui_locator_window): New.
3414         (tui_locator_win_info_ptr): Change return type.
3415         * tui/tui-data.c (_locator): Change type.
3416         (tui_locator_win_info_ptr): Change return type.
3417         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3418         (tui_alloc_content): Add assert.
3419
3420 2019-06-25  Tom Tromey  <tom@tromey.com>
3421
3422         * tui/tui-winsource.c
3423         (tui_exec_info_window::maybe_allocate_content): New method.
3424         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3425         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3426         (make_source_or_disasm_window): Add cast.
3427         * tui/tui-data.h (union tui_which_element) <simple_string>:
3428         Remove.
3429         (struct tui_source_info): New.
3430         (struct tui_source_window_base) <execution_info>: Change type.
3431         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3432         case, and add assert.
3433         (tui_alloc_content): Add assert.
3434
3435 2019-06-25  Tom Tromey  <tom@tromey.com>
3436
3437         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3438         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3439         * tui/tui-data.c (tui_alloc_win_info): Remove.
3440
3441 2019-06-25  Tom Tromey  <tom@tromey.com>
3442
3443         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3444         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3445         can_highlight.
3446
3447 2019-06-25  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3450         make_visible_with_new_height method.
3451         (tui_win_info::make_visible_with_new_height): New method.
3452         (tui_source_window_base::do_make_visible_with_new_height)
3453         (tui_data_window::do_make_visible_with_new_height)
3454         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3455         (make_visible_with_new_height): Remove.
3456         (tui_resize_all, tui_adjust_win_heights): Use
3457         make_visible_with_new_height method.
3458         * tui/tui-data.h (struct tui_win_info)
3459         <do_make_visible_with_new_height, make_visible_with_new_height>:
3460         New methods.
3461         (struct tui_source_window_base, struct tui_data_window)
3462         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3463         methods.
3464
3465 2019-06-25  Tom Tromey  <tom@tromey.com>
3466
3467         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3468         method.
3469         (update_tab_width): Call update_tab_width method.
3470         * tui/tui-data.h (struct tui_win_info)
3471         (struct tui_source_window_base) <update_tab_width>: New methods.
3472
3473 2019-06-25  Tom Tromey  <tom@tromey.com>
3474
3475         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3476         parameter.
3477         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3478         parameter.
3479         (tui_gen_win_info::make_visible): Update.
3480         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3481         parameter.
3482         * tui/tui-data.h (enum tui_box): New enum.
3483         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3484
3485 2019-06-25  Tom Tromey  <tom@tromey.com>
3486
3487         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3488         init_and_make_win for EXEC_INFO_WIN.
3489         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3490         longer inline.
3491         (struct tui_win_info) <~tui_win_info>: Inline.
3492         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3493         Don't declare.
3494         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3495         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3496         Remove.
3497         (tui_initialize_static_data): Update.
3498         (~tui_gen_win_info): Handle more cleanup here.
3499         (~tui_source_window_base): Delete "execution_info".
3500         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3501
3502 2019-06-25  Tom Tromey  <tom@tromey.com>
3503
3504         * tui/tui-layout.c (make_command_window): Don't set
3505         can_highlight.
3506         (show_source_disasm_command): Call the reset method.
3507         (show_data): Don't set can_highlight.  Call the reset method.
3508         (tui_gen_win_info::reset): Rename from init_gen_win_info
3509         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3510         (show_source_or_disasm_and_command): Call the reset method.
3511         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3512         (struct tui_cmd_window): Set can_highlight.
3513
3514 2019-06-25  Tom Tromey  <tom@tromey.com>
3515
3516         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3517         from make_visible.
3518         (tui_make_visible, tui_make_invisible): Rewrite.
3519         (tui_win_info::make_visible): Remove.
3520         (tui_source_window_base::make_visible): Update.
3521         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3522         method.  Moved from...
3523         (struct tui_win_info) <make_visible>: ...here.
3524
3525 2019-06-25  Tom Tromey  <tom@tromey.com>
3526
3527         * tui/tui-winsource.c
3528         (tui_source_window_base::do_scroll_horizontal): Remove direction
3529         parameter.
3530         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3531         direction parameter.
3532         * tui/tui-win.c (tui_win_info::forward_scroll)
3533         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3534         (tui_win_info::right_scroll): Update.
3535         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3536         direction parameter.
3537         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3538         direction parameter.
3539         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3540         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3541         Remove direction parameter.
3542         (struct tui_source_window_base, struct tui_source_window)
3543         (struct tui_disasm_window, struct tui_data_window)
3544         (struct tui_cmd_window): Update.
3545
3546 2019-06-25  Tom Tromey  <tom@tromey.com>
3547
3548         * tui/tui-winsource.h (tui_set_exec_info_content)
3549         (tui_show_exec_info_content, tui_erase_exec_info_content)
3550         (tui_clear_exec_info_content, tui_update_exec_info): Change
3551         argument to tui_source_window_base.
3552         * tui/tui-winsource.c (tui_set_exec_info_content)
3553         (tui_show_exec_info_content, tui_erase_exec_info_content)
3554         (tui_clear_exec_info_content, tui_update_exec_info): Change
3555         argument to tui_source_window_base.
3556
3557 2019-06-25  Tom Tromey  <tom@tromey.com>
3558
3559         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3560         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3561
3562 2019-06-25  Tom Tromey  <tom@tromey.com>
3563
3564         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3565         check.
3566
3567 2019-06-25  Tom Tromey  <tom@tromey.com>
3568
3569         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3570         type to void.
3571         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3572         type to void.
3573         * tui/tui-source.c (tui_set_source_content): Update.
3574         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3575
3576 2019-06-25  Tom Tromey  <tom@tromey.com>
3577
3578         * tui/tui-win.c (window_name_completer, tui_set_focus)
3579         (tui_all_windows_info): Use name method.
3580         * tui/tui-data.h (struct tui_gen_win_info)
3581         (struct tui_source_window, struct tui_disasm_window)
3582         (struct tui_data_window, struct tui_cmd_window) <name>: New
3583         method.
3584         (tui_win_name): Don't declare.
3585         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3586         (tui_win_name): Remove.
3587
3588 2019-06-25  Tom Tromey  <tom@tromey.com>
3589
3590         * tui/tui-winsource.h (tui_update_source_window)
3591         (tui_update_source_window_as_is): Change parameter type.
3592         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3593         to be a tui_source_window_base.
3594         (tui_update_source_window_as_is): Likewise.
3595         * tui/tui-win.c (make_visible_with_new_height): Update.
3596
3597 2019-06-25  Tom Tromey  <tom@tromey.com>
3598
3599         * tui/tui-winsource.c (tui_erase_source_content)
3600         (tui_show_source_content, tui_show_exec_info_content)
3601         (tui_erase_exec_info_content): Use refresh_window method.
3602         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3603         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3604         from tui_refresh_win.
3605         (tui_data_window::refresh_window): New method.
3606         (tui_win_info::refresh, tui_source_window_base::refresh)
3607         (tui_refresh_all): Use refresh_window method.
3608         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3609         method.
3610         * tui/tui-regs.c (tui_display_register): Call refresh_window
3611         method.
3612         * tui/tui-layout.c (show_source_disasm_command)
3613         (show_source_or_disasm_and_command): Call refresh_window method.
3614         * tui/tui-data.h (struct tui_gen_win_info)
3615         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3616         New method.
3617
3618 2019-06-25  Tom Tromey  <tom@tromey.com>
3619
3620         * tui/tui.c (tui_rl_other_window, tui_enable)
3621         (tui_is_window_visible, tui_get_command_dimension): Update.
3622         * tui/tui-winsource.c (tui_update_source_window_as_is)
3623         (tui_clear_source_content, tui_erase_source_content)
3624         (tui_show_source_line, tui_source_window_base::refill)
3625         (tui_source_window_base::do_scroll_horizontal)
3626         (tui_source_window_base::set_is_exec_point_at)
3627         (tui_update_breakpoint_info, tui_set_exec_info_content)
3628         (tui_alloc_source_buffer, tui_line_is_displayed)
3629         (tui_addr_is_displayed): Update.
3630         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3631         (tui_check_and_display_highlight_if_needed)
3632         (tui_win_info::make_visible, tui_win_info::refresh)
3633         (tui_refresh_all): Update.
3634         * tui/tui-windata.c (tui_first_data_item_displayed)
3635         (tui_delete_data_content_windows, tui_erase_data_content)
3636         (tui_display_all_data, tui_data_window::refresh_all)
3637         (tui_check_data_values): Update.
3638         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3639         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3640         (tui_win_info::backward_scroll, tui_refresh_all_win)
3641         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3642         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3643         (tui_source_window_base::set_new_height)
3644         (tui_data_window::set_new_height)
3645         (make_invisible_and_set_new_height)
3646         (make_visible_with_new_height, new_height_ok)
3647         (parse_scrolling_args): Update.
3648         * tui/tui-stack.c (tui_show_frame_info): Update.
3649         * tui/tui-source.c (tui_set_source_content)
3650         (tui_set_source_content_nil, tui_source_is_displayed)
3651         (tui_source_window::do_scroll_vertical): Update.
3652         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3653         (tui_display_registers_from, tui_display_reg_element_at_line)
3654         (tui_check_register_values, tui_reg_command): Update.
3655         * tui/tui-layout.c (tui_default_win_height)
3656         (show_source_disasm_command, show_data, init_and_make_win)
3657         (show_source_or_disasm_and_command): Update.
3658         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3659         (tui_redisplay_readline, tui_mld_flush)
3660         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3661         (tui_getc): Update.
3662         * tui/tui-disasm.c (tui_set_disassem_content)
3663         (tui_disasm_window::do_scroll_vertical): Update.
3664         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3665         Now virtual.
3666         (struct tui_win_info): Derive from tui_gen_win_info.
3667         <~tui_win_info>: Mark as override.
3668         <generic>: Remove member.
3669         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3670         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3671         (~tui_data_window, ~tui_win_info)
3672         (tui_free_all_source_wins_content): Update.
3673         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3674
3675 2019-06-25  Tom Tromey  <tom@tromey.com>
3676
3677         * tui/tui-layout.c (init_and_make_win): Use new.
3678         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3679         destructor, initializers.
3680         (tui_alloc_generic_win_info): Don't declare.
3681         * tui/tui-data.c (_locator): Add argument to constructor.
3682         (source_win, disasm_win): New globals.
3683         (exec_info): Remove.
3684         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3685         Update.
3686         (tui_alloc_generic_win_info): Remove.
3687         (init_content_element): Use new.
3688         (tui_win_info::tui_win_info): Update.
3689         (free_content_elements) <case DATA_WIN>: Use delete.
3690
3691 2019-06-25  Tom Tromey  <tom@tromey.com>
3692
3693         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3694         * tui/tui-windata.c (tui_first_data_item_displayed)
3695         (tui_delete_data_content_windows): Update.
3696         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3697         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3698         (tui_display_registers_from, tui_check_register_values): Update.
3699         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3700         pointer.
3701         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3702         window.
3703         (tui_free_data_content): Update.
3704         (free_content_elements) <case DATA_WIN>: Free the window.
3705
3706 2019-06-25  Tom Tromey  <tom@tromey.com>
3707
3708         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3709         Update.
3710         * tui/tui-layout.c (make_command_window)
3711         (show_source_disasm_command, show_data, init_and_make_win)
3712         (show_source_or_disasm_and_command): Update.
3713         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3714         method.
3715         <can_highight, is_highlighted>: Now bool.
3716         (tui_set_win_highlight): Don't declare.
3717         * tui/tui-data.c (tui_set_win_highlight): Remove.
3718
3719 2019-06-25  Tom Tromey  <tom@tromey.com>
3720
3721         * tui/tui-wingeneral.c (make_visible): Remove check of window
3722         type.
3723
3724 2019-06-25  Tom Tromey  <tom@tromey.com>
3725
3726         * tui/tui-win.c (tui_win_info::max_height)
3727         (tui_cmd_window::max_height): New methods.
3728         (new_height_ok): Call max_height.
3729         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3730         <max_height>: New method.
3731
3732 2019-06-25  Tom Tromey  <tom@tromey.com>
3733
3734         * tui/tui-win.c (tui_source_window_base::set_new_height)
3735         (tui_data_window::set_new_height): New methods.
3736         (make_invisible_and_set_new_height): Call set_new_height method.
3737         * tui/tui-data.h (struct tui_win_info)
3738         (struct tui_source_window_base, struct tui_data_window)
3739         <set_new_height>: New method.
3740
3741 2019-06-25  Tom Tromey  <tom@tromey.com>
3742
3743         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3744         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3745         tui_refresh_data_win.
3746         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3747         method.
3748         (tui_refresh_all_win): Call the refresh_all method.
3749         (tui_set_focus): Likewise.
3750         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3751         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3752         Likewise.
3753
3754 2019-06-25  Tom Tromey  <tom@tromey.com>
3755
3756         * tui/tui-winsource.h (tui_refill_source_window)
3757         (tui_set_is_exec_point_at): Don't declare.
3758         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3759         (tui_source_window_base::refill): Rename from
3760         tui_refill_source_window.
3761         (tui_source_window_base::do_scroll_horizontal): Update.
3762         (tui_source_window_base::set_is_exec_point_at): Rename from
3763         tui_set_is_exec_point_at.
3764         (tui_update_all_breakpoint_info): Update.
3765         * tui/tui-stack.c (tui_show_frame_info): Update.
3766         * tui/tui-layout.c (show_data): Add cast.
3767         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3768         * tui/tui-data.h (struct tui_source_window_base) <refill,
3769         set_is_exec_point_at>: New methods.
3770         (tui_source_windows, tui_add_to_source_windows): Update types.
3771         (tui_add_to_source_windows): Remove redundant declaration.
3772         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3773         (tui_source_windows): Change return type.
3774         (tui_clear_source_windows_detail): Update.
3775         (tui_add_to_source_windows): Change type of parameter.
3776         (tui_free_all_source_wins_content): Update.
3777
3778 2019-06-25  Tom Tromey  <tom@tromey.com>
3779
3780         * tui/tui-wingeneral.c (tui_win_info::refresh)
3781         (tui_source_window_base::refresh): New methods.
3782         (tui_refresh_all): Call the refresh method.
3783         * tui/tui-data.h (struct tui_win_info)
3784         (struct tui_source_window_base) <refresh>: New method.
3785
3786 2019-06-25  Tom Tromey  <tom@tromey.com>
3787
3788         * tui/tui.h (tui_is_window_visible): Return bool.
3789         * tui/tui.c (tui_is_window_visible): Return bool.
3790         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3791         (tui_make_visible, tui_make_invisible)
3792         (tui_win_info::make_visible)
3793         (tui_source_window_base::make_visible, make_all_visible)
3794         (tui_make_all_visible, tui_make_all_invisible): Update.
3795         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3796         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3797         bool.
3798         (struct tui_win_info, struct tui_source_window_base)
3799         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3800         * tui/tui-data.c (tui_init_generic_part): Update.
3801
3802 2019-06-25  Tom Tromey  <tom@tromey.com>
3803
3804         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3805         (tui_source_window_base::make_visible): New methods.
3806         (make_all_visible): Make method call.
3807         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3808         (struct tui_source_window_base, struct tui_cmd_window): Override
3809         make_visible.
3810         (tui_win_is_source_type): Don't declare.
3811         * tui/tui-data.c (tui_win_is_source_type): Remove.
3812
3813 2019-06-25  Tom Tromey  <tom@tromey.com>
3814
3815         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3816         NULL check.
3817
3818 2019-06-25  Tom Tromey  <tom@tromey.com>
3819
3820         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3821         Inline constructor.  Add initializers for members.
3822         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3823         constructors; now inline in class.
3824
3825 2019-06-25  Tom Tromey  <tom@tromey.com>
3826
3827         * tui/tui-regs.c (tui_show_registers): Update.
3828         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3829         bool.
3830         * tui/tui-data.c (tui_data_window::clear_detail)
3831         (tui_data_window): Update.
3832
3833 2019-06-25  Tom Tromey  <tom@tromey.com>
3834
3835         * tui/tui-windata.c (tui_display_all_data)
3836         (tui_display_data_from_line, tui_display_data_from)
3837         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3838         Update.
3839         * tui/tui-regs.c (tui_last_regs_line_no)
3840         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3841         (tui_show_registers, tui_show_register_group)
3842         (tui_display_registers_from, tui_display_reg_element_at_line)
3843         (tui_display_registers_from_line, tui_check_register_values)
3844         (tui_reg_next, tui_reg_prev): Update.
3845         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3846         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3847         tui_data_window.
3848         (struct tui_win_info) <detail>: Remove.  Add new fields from
3849         tui_data_info.
3850         (TUI_DATA_WIN): Add cast.
3851         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3852         (~tui_data_window): Simplify.
3853
3854 2019-06-25  Tom Tromey  <tom@tromey.com>
3855
3856         * tui/tui-layout.c (show_source_disasm_command)
3857         (show_source_or_disasm_and_command): Update.
3858         * tui/tui-io.c (update_cmdwin_start_line)
3859         (tui_redisplay_readline): Update.
3860         * tui/tui-data.h (struct tui_command_info): Remove.
3861         (struct tui_win_info) <detail>: Remove command_info member.
3862         (struct tui_data_window) <start_line>: New member, from
3863         tui_command_info.
3864         (TUI_CMD_WIN): Add casts.
3865
3866 2019-06-25  Tom Tromey  <tom@tromey.com>
3867
3868         * tui/tui-winsource.c (tui_update_source_window)
3869         (tui_refill_source_window)
3870         (tui_source_window_base::do_scroll_horizontal)
3871         (tui_update_breakpoint_info, tui_set_exec_info_content)
3872         (tui_show_exec_info_content, tui_erase_exec_info_content)
3873         (tui_clear_exec_info_content): Update.
3874         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3875         Update.
3876         * tui/tui-win.c (make_invisible_and_set_new_height)
3877         (make_visible_with_new_height): Update.
3878         * tui/tui-source.c (tui_set_source_content)
3879         (tui_show_symtab_source): Update.
3880         * tui/tui-layout.c (extract_display_start_addr)
3881         (show_source_disasm_command, show_data)
3882         (make_source_or_disasm_window)
3883         (show_source_or_disasm_and_command): Update.
3884         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3885         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3886         "gdbarch".
3887         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3888         to tui_source_window_base.
3889         (struct tui_win_info) <detail>: Remove source_info member.
3890         (struct tui_source_window_base) <has_locator>: Inline.
3891         Move contents from tui_source_info; rename has_locator member to
3892         m_has_locator.
3893         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3894         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3895         header file.
3896         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3897         Simplify.
3898         (tui_free_all_source_wins_content): Cast to
3899         tui_source_window_base.
3900
3901 2019-06-25  Tom Tromey  <tom@tromey.com>
3902
3903         * tui/tui-win.c (make_invisible_and_set_new_height)
3904         (make_visible_with_new_height): Call has_locator method.
3905         * tui/tui-layout.c (show_source_disasm_command, show_data)
3906         (show_source_or_disasm_and_command): Update for bool change.
3907         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3908         (tui_win_info) <has_locator>: New method.
3909         (struct tui_source_window_base) <has_locator>: New method.
3910         (tui_win_has_locator): Don't declare.
3911         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3912         from tui_win_has_locator.
3913         (tui_source_window_base): Use false, not FALSE.
3914
3915 2019-06-25  Tom Tromey  <tom@tromey.com>
3916
3917         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3918         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3919         clear_detail method directly.
3920         (tui_clear_win_detail): Remove.
3921
3922 2019-06-25  Tom Tromey  <tom@tromey.com>
3923
3924         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3925         "this", not TUI_DISASM_WIN.
3926
3927 2019-06-25  Tom Tromey  <tom@tromey.com>
3928
3929         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3930         declare.
3931         * tui/tui-winsource.c
3932         (tui_source_window_base::do_scroll_horizontal): Rename from
3933         tui_horizontal_source_scroll.
3934         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3935         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3936         from tui_vertical_data_scroll.
3937         * tui/tui-win.h (tui_scroll): Don't declare.
3938         * tui/tui-win.c (tui_win_info::forward_scroll)
3939         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3940         (tui_win_info::right_scroll): Rename and update.
3941         (tui_scroll_forward_command, tui_scroll_backward_command)
3942         (tui_scroll_left_command, tui_scroll_right_command): Update.
3943         (tui_scroll): Remove.
3944         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3945         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3946         from tui_vertical_source_scroll.
3947         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3948         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3949         from tui_vertical_disassem_scroll.
3950         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3951         do_scroll_horizontal>: New methods.
3952         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3953         Likewise.
3954         (struct tui_source_window_base): Add do_scroll_horizontal.
3955         (struct tui_source_window, struct tui_disasm_window): Add
3956         do_scroll_vertical.
3957         (struct tui_data_window, struct tui_cmd_window): Add
3958         do_scroll_horizontal and do_scroll_vertical.
3959         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3960
3961 2019-06-25  Tom Tromey  <tom@tromey.com>
3962
3963         * tui/tui-data.h (struct tui_source_window_base): New struct.
3964         (struct tui_source_window): Derive from tui_source_window_base.
3965         (struct tui_disasm_window): New struct.
3966         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3967         from tui_source_window::clear_detail.
3968         (tui_source_window_base): Rename from tui_source_window.
3969         (~tui_source_window_base): Rename from ~tui_source_window.
3970         (tui_alloc_win_info): Create a tui_disasm_window.
3971
3972 2019-06-25  Tom Tromey  <tom@tromey.com>
3973
3974         * tui/tui-data.h (struct tui_source_window)
3975         (struct tui_data_window): Declare destructors.
3976         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3977         destructors.
3978         (tui_win_info): Simplify.
3979
3980 2019-06-25  Tom Tromey  <tom@tromey.com>
3981
3982         * tui/tui-winsource.c (tui_display_main)
3983         (tui_update_source_windows_with_addr)
3984         (tui_update_all_breakpoint_info): Update.
3985         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3986         (new_height_ok, parse_scrolling_args): Update.
3987         * tui/tui-stack.c (tui_show_frame_info): Update.
3988         * tui/tui-data.h (struct tui_list): Remove.
3989         (tui_source_windows): Return a reference to a std::vector.
3990         * tui/tui-data.c (source_windows): Now a std::vector.
3991         (tui_source_windows): Change return type.
3992         (tui_clear_source_windows): Rewrite.
3993         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3994         (tui_free_all_source_wins_content): Rewrite.
3995
3996 2019-06-25  Tom Tromey  <tom@tromey.com>
3997
3998         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3999         (struct tui_data_window, struct tui_cmd_window): Declare
4000         clear_detail method.
4001         * tui/tui-data.c (tui_source_window::clear_detail)
4002         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4003         methods.
4004         (tui_clear_win_detail): Simplify.
4005
4006 2019-06-25  Tom Tromey  <tom@tromey.com>
4007
4008         * tui/tui-layout.c (make_source_window, make_disasm_window)
4009         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4010         Return the new window.
4011         (show_source_disasm_command, show_data)
4012         (show_source_or_disasm_and_command): Update.
4013
4014 2019-06-25  Tom Tromey  <tom@tromey.com>
4015
4016         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4017         parameter.  Return the new window.
4018         (show_source_disasm_command): Update and remove NULL check.
4019         (show_source_or_disasm_and_command): Update.
4020
4021 2019-06-25  Tom Tromey  <tom@tromey.com>
4022
4023         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4024
4025 2019-06-25  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-data.h (struct tui_win_info): Make constructor
4028         protected.  Make destructor virtual.  Add initializers.
4029         (tui_source_window, tui_data_window, tui_cmd_window): New
4030         classes.
4031         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4032         constructor.  Add "type" parameter.
4033         (tui_source_window, tui_data_window, tui_cmd_window): New
4034         constructors.
4035         (tui_alloc_win_info): Instantiate the appropriate subclass.
4036
4037 2019-06-25  Tom Tromey  <tom@tromey.com>
4038
4039         * tui/tui-win.c (tui_resize_all): Use delete.
4040         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4041         destructor.
4042         (tui_free_window): Don't declare.
4043         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4044         Update.
4045
4046 2019-06-25  Tom Tromey  <tom@tromey.com>
4047
4048         * tui/tui-data.h (struct tui_win_info): Add constructor.
4049         * tui/tui-data.c (tui_alloc_win_info): Use new.
4050         (tui_free_window): Use delete.
4051
4052 2019-06-22  Tom Tromey  <tom@tromey.com>
4053
4054         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4055         declare.
4056         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4057
4058 2019-06-22  Tom Tromey  <tom@tromey.com>
4059
4060         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4061         declare.
4062         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4063
4064 2019-06-22  Tom de Vries  <tdevries@suse.de>
4065
4066         * dwarf2read.c (create_addrmap_from_aranges)
4067         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4068         instead of '%zu'.
4069
4070 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4071
4072         * dwarf2read.h (dwarf2_section_info_def): Remove.
4073         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4074         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4075         std::vector<dwarf2_section_info>.
4076         (struct dwo_file) <~dwo_file>: Remove.
4077         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4078         types field.
4079         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4080         (dwarf2_read_debug_names): Likewise.
4081         (create_debug_types_hash_table): Change parameter type to
4082         array_view, adjust code accordingly.
4083         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4084         (partial_die_info::fixup): Likewise.
4085         (determine_prefix): Likewise.
4086         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4087
4088 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4089
4090         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4091         gdb_bfd_ref_ptr.
4092         <~dwo_file>: Remove call to gdb_bfd_unref.
4093         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4094         gdb_bfd_ref_ptr::get.
4095
4096 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4097
4098         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4099         type to htab_up.
4100         * dwarf2read.c (struct dwo_file): Initialize fields.
4101         <~dwo_file>: New.
4102         (free_dwo_file): Remove, move content to ~dwo_file.
4103         (struct dwo_file_deleter): Remove.
4104         (dwo_file_up>: Remove custom deleter.
4105         (free_dwo_files): Remove.
4106         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4107         dwo_files.
4108         (process_skeletonless_type_units): Call unique_ptr::get.
4109         (allocate_dwo_file_hash_table): Add deleter to created hash
4110         table.  Change return type to htab_up.
4111         (lookup_dwo_file_slot): Don't memset dwo_file, call
4112         unique_ptr::get.
4113         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4114         (create_dwo_unit_in_dwp_v2): Likewise.
4115         (open_and_init_dwo_file): Likewise.
4116         (free_dwo_file_from_slot): Remove.
4117
4118 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4119
4120         * dwarf2read.h (struct dwarf2_section_info) <readin,
4121         is_virtual>: Change type to bool.
4122         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4123         true instead of 1.
4124
4125 2019-06-19  Tom Tromey  <tom@tromey.com>
4126
4127         * tui/tui-data.h (tui_init_content_element): Don't declare.
4128
4129 2019-06-19  Tom Tromey  <tom@tromey.com>
4130
4131         * tui/tui-data.h (tui_init_win_info): Don't declare.
4132
4133 2019-06-19  Tom de Vries  <tdevries@suse.de>
4134
4135         * dwarf2read.h (abstract_to_concrete): Change type to
4136         std::unordered_map<sect_offset, std::vector<sect_offset>,
4137         gdb::hash_enum<sect_offset>>.
4138
4139 2019-06-19  Tom Tromey  <tromey@adacore.com>
4140
4141         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4142         EVAL_AVOID_SIDE_EFFECTS specially.
4143
4144 2019-06-19  Tom Tromey  <tromey@adacore.com>
4145
4146         * source-cache.c (highlighter): New global.
4147         (source_cache::get_source_lines): Create a highlighter on demand.
4148
4149 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4150
4151         * defs.h (deprecated_interactive_hook): Delete declaration.
4152         * interps.c (clear_interpreter_hooks): Remove use of
4153         deprecated_interactive_hook.
4154         * top.c (deprecated_interactive_hook): Delete definition.
4155         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4156
4157 2019-06-18  Tom de Vries  <tdevries@suse.de>
4158
4159         PR gdb/24515
4160         * dwarf2read.h (abstract_to_concrete): Change type from
4161         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4162         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4163         * dwarf2read.c (read_variable): Update.
4164         (dwarf2_fetch_die_loc_sect_off): Update.
4165
4166 2019-06-17  Tom de Vries  <tdevries@suse.de>
4167
4168         PR gdb/24617
4169         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4170         accessing parent[parent_len - 1].
4171
4172 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4173
4174         PR gdb/24364
4175         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4176         call dtrace_process_dof with NULL dof.
4177
4178 2019-06-16  Tom de Vries  <tdevries@suse.de>
4179
4180         PR gdb/24445
4181         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4182
4183 2019-06-16  Tom Tromey  <tom@tromey.com>
4184
4185         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4186         (make_all_visible): Use address of member.
4187
4188 2019-06-16  Tom Tromey  <tom@tromey.com>
4189
4190         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4191         (tui_free_window, free_content, free_content_elements): Remove
4192         unnecessary cast.
4193         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4194         cast.
4195         * tui/tui-regs.c (tui_show_register_group)
4196         (tui_display_registers_from, tui_display_reg_element_at_line):
4197         Remove unnecessary cast.
4198
4199 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4200
4201         * linux-nat.c (normal_mask): Delete.
4202         (_initialize_linux_nat): Don't initialise normal_mask.
4203
4204 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4205
4206         PR gdb/24445
4207         * dwarf-index-write.h (write_psymtabs_to_index): Add
4208         dwz_basename parameter.
4209         * dwarf-index-write.c (write_gdbindex): Move file writing to
4210         write_gdbindex_1.  Change return type void.
4211         (assert_file_size): Move up, remove filename parameter.
4212         (write_gdbindex_1): New function.
4213         (write_debug_names): Change return type to void, call
4214         assert_file_size.
4215         (struct index_wip_file): New struct.
4216         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4217         file logic to index_wip_file.  Write index for dwz file if
4218         needed.
4219         (save_gdb_index_command): Pass basename of dwz file, if present.
4220         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4221         build-id of dwz file, if present.
4222         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4223         (dwarf2_get_dwz_file): Likewise.
4224         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4225         (dwarf2_get_dwz_file): Likewise.
4226
4227 2019-06-16  Tom Tromey  <tom@tromey.com>
4228
4229         * coffread.c (process_coff_symbol): Use xstrdup.
4230         * value.c (create_internalvar): Use xstrdup.
4231
4232 2019-06-16  Tom Tromey  <tom@tromey.com>
4233
4234         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4235         * breakpoint.c (stopin_command, stopat_command)
4236         (until_break_command, decode_location_default): Remove unnecessary
4237         cast.
4238         * utils.c (subset_compare): Remove unnecessary cast.
4239         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4240         cast.
4241         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4242         cast.
4243         * infcmd.c (path_command): Remove unnecessary cast.
4244         * coffread.c (decode_type): Remove unnecessary cast.
4245         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4246         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4247         * tui/tui-stack.c (tui_show_locator_content)
4248         (tui_show_frame_info): Remove unnecessary cast.
4249         * tui/tui-win.c (tui_scroll_forward_command)
4250         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4251         (parse_scrolling_args): Remove unnecessary cast.
4252         * tui/tui-data.c (init_win_info, tui_del_window)
4253         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4254         (free_content_elements): Remove unnecessary cast.
4255         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4256         unnecessary cast.
4257         * tui/tui-source.c (tui_set_source_content)
4258         (tui_vertical_source_scroll): Remove unnecessary cast.
4259         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4260         cast.
4261         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4262         * tui/tui-regs.c (tui_display_registers_from)
4263         (tui_display_register): Remove unnecessary cast.
4264         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4265         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4266         (make_visible): Remove unnecessary cast.
4267         * tui/tui-winsource.c (tui_erase_source_content)
4268         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4269         unnecessary cast.
4270         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4271         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4272         * stabsread.c (read_type, read_array_type, read_range_type):
4273         Remove unnecessary cast.
4274         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4275         (parse_symbol, parse_type, upgrade_type, parse_external)
4276         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4277         unnecessary cast.
4278         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4279
4280 2019-06-16  Tom Tromey  <tom@tromey.com>
4281
4282         * tui/tui-data.c (tui_alloc_generic_win_info)
4283         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4284         checks.
4285
4286 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4287             Andrew Burgess  <andrew.burgess@embecosm.com>
4288
4289         * f-typeprint.c (f_print_type): Don't return early for not
4290         associated or not allocated types.
4291         (f_type_print_varspec_suffix): Add print_rank parameter and print
4292         ranks of array types in case they dangling.
4293         (f_type_print_base): Add print_rank parameter.
4294
4295 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4296
4297         * NEWS: Mention new MI commands.
4298         * break-catch-throw.c (enum exception_event_kind): Move to
4299         breakpoint.h.
4300         (print_mention_exception_catchpoint): Output text as a single
4301         message.
4302         (catch_exception_command_1): Rename to...
4303         (catch_exception_event): ...this, make non-static, update header
4304         command, and change some parameter types.
4305         (catch_catch_command): Update for changes to
4306         catch_exception_command_1.
4307         (catch_throw_command): Likewise.
4308         (catch_rethrow_command): Likewise.
4309         * breakpoint.c (enum exception_event_kind): Delete.
4310         * breakpoint.h (enum exception_event_kind): Moved here from
4311         break-catch-throw.c.
4312         (catch_exception_event): Declare.
4313         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4314         (mi_cmd_catch_throw): New function.
4315         (mi_cmd_catch_rethrow): New function.
4316         (mi_cmd_catch_catch): New function.
4317         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4318         'catch-catch' entries.
4319         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4320         (mi_cmd_catch_rethrow): Declare.
4321         (mi_cmd_catch_catch): Declare.
4322
4323 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4324
4325         * annotate.c (annotate_source_line): Change return type to void,
4326         update implementation to match.
4327         * annotate.h (annotate_source_line): Change return type to void,
4328         update header comment.
4329         * stack.c (print_frame_info): Don't change what frame information
4330         is printed based on whether annotations are on or not.
4331
4332 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4333
4334         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4335         (annotate_source): Make static.
4336         (annotate_source_line): Moved from source.c and renamed from
4337         identify_source_line.  Update the return type.
4338         * annotate.h (annotate_source): Delete declaration.
4339         (annotate_source_line): Declaration moved from source.h, and
4340         renamed from identify_source_line.  Return type updated.
4341         * source.c (identify_source_line): Moved to annotate.c and renamed
4342         to annotate_source_line.
4343         (info_line_command): Remove check of annotation_level.
4344         * source.h (identify_source_line): Move declaration to annotate.h
4345         and rename to annotate_source_line.
4346         * stack.c: Add 'annotate.h' include.
4347         (print_frame_info): Remove check of annotation_level before
4348         calling annotate_source_line.
4349
4350 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4351
4352         * source-cache.c (source_cache::get_plain_source_lines): Use
4353         open_source_file_with_line_charpos instead of just
4354         open_source_file, remove call to find_source_lines.
4355         (source_cache::get_source_lines): Likewise.
4356         * source.c (find_source_lines): Make static.
4357         (get_filename_and_charpos): Renamed into...
4358         (open_source_file_with_line_charpos): ..this along with changes to
4359         return a scoped_fd, and some other minor clean ups.
4360         (identify_source_line): Use open_source_file_with_line_charpos.
4361         (search_command_helper): Use open_source_file_with_line_charpos
4362         instead of just open_source_file, remove call to
4363         find_source_lines.
4364         * source.h (open_source_file_with_line_charpos): Declare new
4365         function.
4366         (find_source_lines): Delete declaration.
4367
4368 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4369
4370         * source.c (get_filename_and_charpos): Remove fullname
4371         parameter.
4372         (identify_source_line): Update call to get_filename_and_charpos.
4373
4374 2019-06-14  Tom Tromey  <tromey@adacore.com>
4375
4376         PR gdb/24502:
4377         * ui-style.h (skip_ansi_escape): Update comment.
4378         * ui-file.h (class no_terminal_escape_file): New class.
4379         * ui-file.c (no_terminal_escape_file::write)
4380         (no_terminal_escape_file::puts): New methods.
4381         * cli/cli-logging.c (handle_redirections): Use
4382         no_terminal_escape_file.
4383
4384 2019-06-14  Tom Tromey  <tromey@adacore.com>
4385
4386         * NEWS: Move convenience variable news above Python news.
4387
4388 2019-06-14  Tom Tromey  <tom@tromey.com>
4389
4390         * gnulib: Move directory to top-level.
4391         * configure.ac: Don't configure gnulib.
4392         * configure: Rebuild.
4393         * common/common-defs.h: Use new path to gnulib.
4394         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4395         (GNULIB_H): Remove.
4396         (INCGNU): Look in new gnulib location.
4397         (HFILES_NO_SRCDIR): Remove gnulib files.
4398         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4399         (generated_files): Remove GNULIB_H.
4400         ($(LIBGNU), all-lib): Remove targets.
4401         (distclean): Don't mention GNULIB_BUILDDIR.
4402         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4403
4404 2019-06-14  Tom Tromey  <tromey@adacore.com>
4405
4406         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4407         Warn if symbol file does not provide any symbols.
4408
4409 2019-06-14  Tom Tromey  <tromey@adacore.com>
4410
4411         * source.c (find_and_open_source): Respect basenames_may_differ.
4412
4413 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4414
4415         * annotate.c (annotate_breakpoints_invalid): Make use of
4416         scoped_restore_terminal_state.
4417         (annotate_frames_invalid): Likewise.
4418
4419 2019-06-14  Tom Tromey  <tromey@adacore.com>
4420
4421         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4422         allow assignment to an internalvar.
4423
4424 2019-06-14  Tom Tromey  <tromey@adacore.com>
4425
4426         * ada-lex.l: Allow "_" in attribute names.
4427
4428 2019-06-14  Tom Tromey  <tromey@adacore.com>
4429
4430         PR gdb/24653:
4431         * regcache.c (registers_changed): Don't call alloca.
4432         * top.c (execute_command): Don't call alloca.
4433
4434 2019-06-13  Pedro Alves  <palves@redhat.com>
4435
4436         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4437         'expression'.  When parsing an expression, error out if there's
4438         junk after "unlimited".
4439         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4440         (do_set_command): Adjust calls to is_unlimited_literal.
4441
4442 2019-06-13  Pedro Alves  <palves@redhat.com>
4443
4444         * compile/compile.c (make_compile_options_def_group): Add braces
4445         around array_view initializer.
4446         * thread.c (make_thread_apply_all_options_def_group)
4447         (make_thread_apply_all_options_def_group): Likewise.
4448
4449 2019-06-13  Pedro Alves  <palves@redhat.com>
4450
4451         * NEWS (New commands): Mention "maint test-options
4452         require-delimiter", "maint test-options unknown-is-error", "maint
4453         test-options unknown-is-operand" and "maint show
4454         test-options-completion-result".
4455         (New command options, command completion): New section.
4456         (Completion improvements): New section.
4457         Mention that you can abbreviate "unlimited".
4458
4459 2019-06-13  Pedro Alves  <palves@redhat.com>
4460
4461         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4462         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4463         * unittests/cli-utils-selftests.c (test_parse_flags)
4464         (test_parse_flags_qcs): Delete.
4465         (test_cli_utils): Don't call deleted functions.
4466
4467 2019-06-13  Pedro Alves  <palves@redhat.com>
4468
4469         * thread.c: Include "cli/cli-option.h".
4470         (tp_array_compar_ascending): Global.
4471         (tp_array_compar): Delete function.
4472         (tp_array_compar_ascending, tp_array_compar_descending): New
4473         functions.
4474         (ascending_option_def, qcs_flag_option_def)
4475         (thr_qcs_flags_option_defs)
4476         (make_thread_apply_all_options_def_group)
4477         (make_thread_apply_options_def_group): New.
4478         (thread_apply_all_command): Use gdb::option::process_options.
4479         (thread_apply_command_completer)
4480         (thread_apply_all_command_completer): New.
4481         (thread_apply_command): Use gdb::option::process_options.
4482         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4483         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4484         to generate help text of "thread apply".  Adjust "taas"'s help.
4485         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4486         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4487
4488 2019-06-13  Pedro Alves  <palves@redhat.com>
4489
4490         * thread.c (thread_apply_command): Check for invalid TID with
4491         isdigit instead of !isalpha.
4492
4493 2019-06-13  Pedro Alves  <palves@redhat.com>
4494
4495         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4496         (validate_flags_qcs): New.
4497         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4498         (validate_flags_qcs): Declare.
4499         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4500         (make_frame_apply_options_def_group): New.
4501         (frame_apply_command_count): Process options with
4502         gdb::option::process_options.
4503         (frame_apply_completer): New.
4504         (frame_apply_level_completer, frame_apply_all_completer)
4505         (frame_apply_completer): New.
4506         (_initialize_stack): Update help of "frame apply", "frame apply
4507         level", "frame apply all" and "faas" to mention supported options
4508         and install command completers.
4509         * stack.h (frame_apply_all_completer): Declare.
4510         * thread.c: Include "stack.h".
4511         (tfaas_command): Add "--".
4512         (_initialize_thread): Update help "tfaas" to mention supported
4513         options and install command completer.
4514
4515 2019-06-13  Pedro Alves  <palves@redhat.com>
4516
4517         * completer.c (complete_nested_command_line): New.
4518         (gdb_completion_word_break_characters_throw): Add assertion.
4519         * completer.h (complete_nested_command_line): Declare.
4520
4521 2019-06-13  Pedro Alves  <palves@redhat.com>
4522
4523         * stack.c (parse_backtrace_qualifiers): New.
4524         (backtrace_command): Use it.
4525         (backtrace_command_completer): Complete on qualifiers.
4526
4527 2019-06-13  Pedro Alves  <palves@redhat.com>
4528
4529         * frame.c: Include "cli/cli-option.h.
4530         (user_set_backtrace_options): New.
4531         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4532         Delete.
4533         (get_prev_frame): Adjust.
4534         (boolean_option_def, uinteger_option_def)
4535         (set_backtrace_option_defs): New.
4536         (_initialize_frame): Adjust and use
4537         gdb::option::add_setshow_cmds_for_options to install "set
4538         backtrace past-main" and "set backtrace past-entry".
4539         * frame.h: Include "cli/cli-option.h".
4540         (struct frame_print_options): Forward declare.
4541         (print_frame_arguments_all, print_frame_arguments_scalars)
4542         (print_frame_arguments_none): Declare.
4543         (print_entry_values): Delete declaration.
4544         (struct frame_print_options, user_frame_print_options): New.
4545         (struct set_backtrace_options): New.
4546         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4547         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4548         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4549         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4550         (list_args_or_locals): Add frame_print_options parameter.
4551         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4552         * python/py-framefilter.c (enumerate_args): Pass down
4553         USER_FRAME_PRINT_OPTIONS.
4554         * stack.c: Include "cli/cli-option.h".
4555         (print_frame_arguments_all, print_frame_arguments_scalars)
4556         (print_frame_arguments_none): Declare.
4557         (print_raw_frame_arguments, print_entry_values): Delete.
4558         (user_frame_print_options): New.
4559         (boolean_option_def, enum_option_def, frame_print_option_defs):
4560         New.
4561         (struct backtrace_cmd_options): New.
4562         (bt_flag_option_def): New.
4563         (backtrace_command_option_defs): New.
4564         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4565         (print_frame_arg, read_frame_arg, print_frame_args)
4566         (print_frame_info, print_frame): Add frame_print_options parameter
4567         and use it.
4568         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4569         (backtrace_command_1): Add frame_print_options and
4570         backtrace_cmd_options parameters and use them.
4571         (make_backtrace_options_def_group): New.
4572         (backtrace_command): Process command options with
4573         gdb::option::process_options.
4574         (backtrace_command_completer): New.
4575         (_initialize_stack): Extend "backtrace"'s help to mention
4576         supported options.  Install completer for "backtrace".
4577         Install some settings commands with add_setshow_cmds_for_options.
4578
4579 2019-06-13  Pedro Alves  <palves@redhat.com>
4580
4581         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4582         and that "set/show print raw frame-arguments" are now deprecated.
4583
4584         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4585         command.
4586         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4587         * stack.c (_initialize_stack): Install "set/show print
4588         raw-frame-arguments", and deprecate "set/show print raw
4589         frame-arguments".
4590         * valprint.c (_initialize_valprint): Deprecate "set/show print
4591         raw".
4592
4593 2019-06-13  Pedro Alves  <palves@redhat.com>
4594
4595         * compile/compile.c (struct compile_options): New.
4596         (compile_flag_option_def, compile_command_option_defs)
4597         (make_compile_options_def_group): New.
4598         (compile_file_command): Handle options with
4599         gdb::option::process_options.
4600         (compile_file_command_completer): New function.
4601         (compile_code_command): Handle options with
4602         gdb::option::process_options.
4603         (compile_code_command_completer): New function.
4604         (_initialize_compiler): Install completers for "compile code" and
4605         "compile file".  Mention available options in "compile code" and
4606         "compile code"'s help.
4607         * completer.c (advance_to_completion_word): New, factored out from
4608         ...
4609         (advance_to_expression_complete_word_point): ... this.
4610         (advance_to_filename_complete_word_point): New.
4611         * completer.h (advance_to_filename_complete_word_point): New
4612         declaration.
4613
4614 2019-06-13  Pedro Alves  <palves@redhat.com>
4615
4616         * compile/compile.c: Include "cli/cli-option.h".
4617         (compile_print_value): Scope data pointer is now a
4618         value_print_options pointer; adjust.
4619         (compile_print_command): Process options.  Scope data pointer is
4620         now a value_print_options pointer; adjust.
4621         (_initialize_compile): Update "compile print"'s help to include
4622         supported options.  Install a completer for "compile print".
4623         * cp-valprint.c (show_vtblprint, show_objectprint)
4624         (show_static_field_print): Delete.
4625         (_initialize_cp_valprint): Don't install "set print
4626         static-members", "set print vtbl", "set print object" here.
4627         * printcmd.c: Include "cli/cli-option.h" and
4628         "common/gdb_optional.h".
4629         (print_command_parse_format): Rework to fill in a
4630         value_print_options instead of a format_data.
4631         (print_value): Change parameter type from format_data pointer to
4632         value_print_options reference.  Adjust.
4633         (print_command_1): Process options.  Adjust to pass down a
4634         value_print_options.
4635         (print_command_completer): New.
4636         (_initialize_printcmd): Install print_command_completer as
4637         handle_brkchars completer for the "print" command.  Update
4638         "print"'s help to include supported options.
4639         * valprint.c: Include "cli/cli-option.h".
4640         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4641         here from cp-valprint.c.
4642         (boolean_option_def, uinteger_option_def)
4643         (value_print_option_defs, make_value_print_options_def_group):
4644         New.  Use gdb::option::add_setshow_cmds_for_options to install
4645         "set print elements", "set print null-stop", "set print repeats",
4646         "set print pretty", "set print union", "set print array", "set
4647         print address", "set print symbol", "set print array-indexes".
4648         * valprint.h: Include <string> and "cli/cli-option.h".
4649         (make_value_print_options_def_group): Declare.
4650         (print_value): Change parameter type from format_data pointer to
4651         value_print_options reference.
4652         (print_command_completer): Declare.
4653
4654 2019-06-13  Pedro Alves  <palves@redhat.com>
4655
4656         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4657         (COMMON_SFILES): Add maint-test-settings.c.
4658         * cli/cli-decode.c (boolean_enums): New global, factored out from
4659         ...
4660         (add_setshow_boolean_cmd): ... here.
4661         * cli/cli-decode.h (boolean_enums): Declare.
4662         * cli/cli-option.c: New file.
4663         * cli/cli-option.h: New file.
4664         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4665         factored out from ...
4666         (parse_cli_boolean_value(const char *)): ... this.
4667         (is_unlimited_literal): Change parameter type to pointer to
4668         pointer.  Adjust and advance ARG pointer.
4669         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4670         (parse_cli_var_enum): New, factored out from ...
4671         (do_set_command): ... this.  Adjust.
4672         * cli/cli-setshow.h (parse_cli_boolean_value)
4673         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4674         (parse_cli_var_enum): Declare.
4675         * cli/cli-utils.c: Include "cli/cli-option.h".
4676         (get_ulongest): New.
4677         * cli/cli-utils.h (get_ulongest): Declare.
4678         (check_for_argument): New overloads.
4679         * maint-test-options.c: New file.
4680
4681 2019-06-13  Pedro Alves  <palves@redhat.com>
4682
4683         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4684         parse a range if "-" is at the end of the string.
4685
4686 2019-06-13  Pedro Alves  <palves@redhat.com>
4687
4688         * cli/cli-setshow.c (parse_auto_binary_operation)
4689         (parse_cli_boolean_value): Don't allow "o".
4690
4691 2019-06-13  Pedro Alves  <palves@redhat.com>
4692
4693         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4694         * NEWS: Mention maint test-settings KIND.
4695         * maint-test-settings.c: New file.
4696
4697 2019-06-13  Pedro Alves  <palves@redhat.com>
4698
4699         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4700         completer.
4701         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4702         "set" completers.
4703
4704 2019-06-13  Pedro Alves  <palves@redhat.com>
4705
4706         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4707         after item.
4708
4709 2019-06-13  Pedro Alves  <palves@redhat.com>
4710
4711         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4712
4713 2019-06-13  Pedro Alves <palves@redhat.com>
4714
4715         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4716         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4717         call.
4718         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4719         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4720         calls.
4721         (check_for_argument): Skip spaces after argument.
4722
4723 2019-06-13  Pedro Alves  <palves@redhat.com>
4724
4725         * thread.c (thread_apply_command): Adjust TID parsing.
4726         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4727         detected before end of string.
4728         (tid_is_in_list): Error out if LIST is invalid.
4729
4730 2019-06-13  Pedro Alves  <palves@redhat.com>
4731
4732         * completer.c (complete_line_internal_1): Rewind completion word
4733         point.
4734         (completion_tracker::advance_custom_word_point_by): Change
4735         parameter type to int.
4736         * completer.h (completion_tracker::advance_custom_word_point_by):
4737         Likewise.
4738
4739 2019-06-13  Pedro Alves  <palves@redhat.com>
4740
4741         * completer.c (advance_to_completion_word): Handle delimiters.
4742
4743 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4744
4745         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4746
4747 2019-06-11  Tom Tromey  <tom@tromey.com>
4748
4749         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4750         (xmalloc_failed): Move to alloc.c.
4751         * alloc.c: New file.
4752         * Makefile.in (COMMON_SFILES): Add alloc.c.
4753
4754 2019-06-11  Tom Tromey  <tom@tromey.com>
4755
4756         * nat/linux-waitpid.c: Don't include server.h.
4757         (linux_debug): Remove.
4758         (my_waitpid): Update.
4759
4760 2019-06-11  Tom Tromey  <tromey@adacore.com>
4761
4762         * infcall.c (_initialize_infcall): Remove trailing newline from
4763         help.
4764         * user-regs.c (_initialize_user_regs): Remove trailing newline
4765         from help.
4766         * typeprint.c (_initialize_typeprint): Remove trailing newline
4767         from help.
4768         * reverse.c (_initialize_reverse): Remove trailing newlines from
4769         help.
4770         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4771         from help.
4772         * language.c (add_set_language_command): Remove trailing newline
4773         from help.
4774         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4775         help.
4776         * disasm.c (_initialize_disasm): Remove trailing newline from
4777         help.
4778         * top.c (init_main): Remove trailing newline from help.
4779         * interps.c (_initialize_interpreter): Remove trailing newline
4780         from help.
4781         * btrace.c (_initialize_btrace): Remove trailing newlines from
4782         help.
4783         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4784         from help.
4785         * python/python.c (_initialize_python): Remove trailing newline
4786         from help.
4787         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4788         help.
4789         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4790         from help.  Reformat some text.
4791         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4792         from help.
4793         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4794         newline from help.
4795
4796 2019-06-11  Tom Tromey  <tromey@adacore.com>
4797
4798         * darwin-nat.c (darwin_decode_exception_message)
4799         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4800
4801 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4802
4803         * valops.c (value_slice): Check for not allocated or not
4804         associated values.
4805
4806 2019-06-10  Tom de Vries  <tdevries@suse.de>
4807
4808         PR gdb/24618
4809         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4810         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4811         invalid.
4812
4813 2019-06-10  Tom de Vries  <tdevries@suse.de>
4814
4815         PR gdb/24611
4816         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4817         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4818
4819 2019-06-10  Tom de Vries  <tdevries@suse.de>
4820
4821         PR symtab/24545
4822         * symtab.c (struct demangled_name_entry): Add language field.
4823         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4824         static minimal symbol".  Set and use language field.
4825
4826 2019-06-10  Tom Tromey  <tromey@adacore.com>
4827
4828         * ada-lang.c (_initialize_ada_language): Update help text.
4829
4830 2019-06-10  Tom Tromey  <tromey@adacore.com>
4831
4832         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4833         with a newline.
4834         * guile/guile.c (handle_boot_error): Don't end warning with a
4835         newline.
4836         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4837         warning with a newline.
4838         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4839         newline.
4840         (s12z_frame_cache): Likewise.
4841         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4842         a newline.
4843         * solib-svr4.c (disable_probes_interface): Don't end warning with
4844         a newline.
4845         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4846         newline.
4847         * python/python.c (do_finish_initialization): Don't end warning
4848         with a newline.
4849
4850 2019-06-10  Tom Tromey  <tom@tromey.com>
4851
4852         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4853         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4854         gdbpy_enter.
4855
4856 2019-06-10  Tom Tromey  <tromey@adacore.com>
4857
4858         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4859         data.
4860         (elf_new_init): Don't call stabsread_new_init.
4861         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4862         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4863         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4864
4865 2019-06-10  Tom de Vries  <tdevries@suse.de>
4866
4867         PR symtab/16264
4868         PR symtab/24517
4869         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4870
4871 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4872
4873         * source.c (find_and_open_source): Also rewrite relative file
4874         names.
4875
4876 2019-04-26  Amos Bird  <amosbird@gmail.com>
4877
4878         * annotate.c (annotate_thread_exited): Add "thread-exited"
4879         annotation.
4880
4881 2019-06-06  Tom Tromey  <tromey@adacore.com>
4882
4883         * maint.h (class scoped_command_stats): Use
4884         DISABLE_COPY_AND_ASSIGN.
4885         <print_time>: New method.
4886         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4887         print_time.
4888         (scoped_command_stats::print_time): New method.
4889
4890 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4891
4892         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4893         instructions of lengths 6 or 8 bytes.
4894
4895 2019-06-04  Pedro Alves  <palves@redhat.com>
4896
4897         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4898
4899         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4900         * breakpoint.c (condition_completer): Likewise.
4901         * cli/cli-dump.c (scan_expression): Likewise.
4902         * common/filestuff.c (mkdir_recursive): Likewise.
4903         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4904         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4905         (gdb_abspath): Likewise.
4906         * compile/compile-cplus-types.c
4907         (compile_cplus_instance::decl_name): Likewise.
4908         * completer.c (complete_explicit_location):
4909         (signal_completer, reg_or_group_completer_1): Likewise.
4910         * cp-support.c (cp_remove_params_if_any): Likewise.
4911         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4912         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4913         * infcmd.c (strip_bg_char): Likewise.
4914         * linespec.c (copy_token_string): Likewise.
4915         * mi/mi-main.c (output_cores): Likewise.
4916         * psymtab.c (psymtab_search_name):
4917         * symfile.c (test_set_ext_lang_command): Likewise.
4918         * target.c (target_fileio_read_stralloc): Likewise.
4919         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4920         * value.c (complete_internalvar): Likewise.
4921
4922 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4923
4924         Add objfile property to gdb.Type.
4925         * NEWS: Mention Python API addition.
4926         * python/py-type.c (typy_get_objfile): New method.
4927
4928 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4929
4930         * NEWS: Mention the new set|show style [title|highlight].
4931         Mention changes to "show style", "help" and "apropos".
4932
4933 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4934
4935         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4936         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4937         instead of print_help_for_command.
4938         (print_doc_of_command): New function.
4939         (help_list): Add 'apropos -v word' suggestion.
4940         (print_help_for_command): Style the command name using title style.
4941         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4942         (_initialize_cli_cmds): Describe -v in apropos_command help.
4943
4944 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4945
4946         * cli/cli-style.h (cli_style_option): Add name in constructor,
4947         add m_name class member, add constructor with intensity,
4948         add name class function.
4949         (cli_style_option::add_setshow_commands): Remove name argument.
4950         (highlight_style, title_style): New styles.
4951         * cli/cli-style.c (do_show): New function that shows a style
4952         characteristic styling the style name with itself.
4953         (set_style_name): New function.
4954         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4955         Update all callers according to the changes in cli/cli-style.h.
4956         * utils.h (fputs_highlighted): New function.
4957         * utils.c (fputs_highlighted): Likewise.
4958
4959 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4960
4961         * NEWS: Mention new pipe command and new convenience variables.
4962
4963 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4964
4965         * cli/cli-cmds.c (pipe_command): New function.
4966         (_initialize_cli_cmds): Call add_com for pipe_command.
4967         Define | as an alias for pipe.
4968         (exit_status_set_internal_vars): New function.
4969         (shell_escape): Call exit_status_set_internal_vars.
4970         cli/cli-decode.c (find_command_name_length): Recognize | as
4971         a single character command.
4972
4973 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4974
4975         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4976         top.c (execute_command_to_ui_file): New function, mostly a copy
4977         of execute_command_to_string.
4978         (execute_command_to_string): Implement by calling
4979         execute_command_to_ui_file.
4980
4981 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4982
4983         * top.h (saved_command_line): Remove declaration.
4984         * top.c (previous_saved_command_line, previous_repeat_arguments):
4985         New variables.
4986         (saved_command_line): Make static, define together with other
4987         'repeat variables'.
4988         (dont_repeat): Clear repeat_arguments.
4989         (repeat_previous, get_saved_command_line, save_command_line):
4990         New functions.
4991         (gdb_init): Initialize saved_command_line
4992         and previous_saved_command_line.
4993         * main.c (captured_main_1): Remove saved_command_line initialization.
4994         * event-top.c (handle_line_of_input): Update to use
4995         the new 'repeat' related functions instead of direct access to
4996         saved_command_line.
4997         * command.h (repeat_previous, get_saved_command_line,
4998         save_command_line): New declarations.
4999         (dont_repeat): Add comment.
5000
5001 2019-05-30  Tom Tromey  <tromey@adacore.com>
5002
5003         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5004         Fix comment.
5005         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5006
5007 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5008
5009         PR cli/24587
5010         * completer.c (complete): Initialize variable word.
5011
5012 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5013
5014         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5015         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5016         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5017         'body' is NULL to the outter 'if', protecting the '!is_define'
5018         situation as well.
5019
5020 2019-05-29  Tom Tromey  <tromey@adacore.com>
5021
5022         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5023         (dwarf_unknown): New function.
5024         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5025         (dwarf_type_encoding_name): Use dwarf_unknown.
5026
5027 2019-05-29  Tom Tromey  <tromey@adacore.com>
5028
5029         PR c++/20020:
5030         * cp-valprint.c (cp_print_value_fields): Call
5031         cp_print_static_field inside "try".
5032
5033 2019-05-29  Tom Tromey  <tromey@adacore.com>
5034
5035         * inflow.c (struct terminal_info): Add default operator=.
5036         * configure: Rebuild.
5037         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5038         -Wdeprecated-copy-dtor, -Wredundant-move.
5039
5040 2019-05-29  Tom Tromey  <tromey@adacore.com>
5041
5042         * NEWS: Add entry.
5043         * infcmd.c (print_return_value_1): Handle finish_print
5044         option.
5045         (show_print_finish): New function.
5046         (_initialize_infcmd): Add "set/show print finish" commands.
5047         * valprint.c (user_print_options): Initialize new member.
5048         * valprint.h (struct value_print_options) <finish_print>: New
5049         member.
5050
5051 2019-05-28  Tom Tromey  <tromey@adacore.com>
5052
5053         * ada-lang.c (ada_remove_Xbn_suffix)
5054         (find_old_style_renaming_symbol)
5055         (parse_old_style_renaming): Remove.
5056         (ada_find_renaming_symbol): Don't call
5057         find_old_style_renaming_symbol.
5058         (ada_is_renaming_symbol): Rename from
5059         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5060         bool.  Now static.
5061         (ada_read_var_value): Update and simplify.
5062         * ada-exp.y (write_var_or_type): Remove old code.
5063
5064 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5065
5066         * event-top.c: Remove include comment.
5067         * inflow.c (class scoped_ignore_sigttou): Move from here...
5068         * inflow.h (class scoped_ignore_sigttou): ...to here.
5069         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5070         * top.c:  Remove include comment.
5071
5072 2019-05-27  Tom Tromey  <tom@tromey.com>
5073
5074         * NEWS: Fix typo.
5075
5076 2019-05-22  Tom Tromey  <tromey@adacore.com>
5077
5078         * target.c (target_follow_exec): Constify parameter.
5079         * target-delegates.c: Rebuild.
5080         * remote.c (remote_target::follow_exec): Constify parameter.
5081         * infrun.c (follow_exec): Constify parameter.
5082         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5083         (target_follow_exec): Likewise.
5084
5085 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5086
5087         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5088         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5089
5090 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5091
5092         * NEWS: Add debugredirect and testsuite sections.
5093
5094 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5095
5096         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5097         target descriptions using exclusively floating point register name
5098         aliases.
5099
5100 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5101
5102         PR gdb/18644:
5103         * f-lang.c (build_fortran_types): Handle the case where
5104         gdbarch_floatformat_for_type returns a nullptr.
5105
5106 2019-05-21  Tom de Vries  <tdevries@suse.de>
5107
5108         PR cli/24587
5109         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5110
5111 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5112
5113         PR gdb/18644:
5114         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5115         16-byte floats.
5116         * i386-tdep.c (i386_floatformat_for_type): Use
5117         floatformats_ia64_quad for the 16-byte floating point component
5118         within a fortran 32-byte complex number.
5119
5120 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5121
5122         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5123         delete default constructor.
5124         (find_partial_die): Update to return const struct.
5125         (partial_die_parent_scope): Move variable declaration into scope
5126         of its use and change its type to auto.
5127         (guess_partial_die_structure_name): Likewise.
5128         (partial_die_info::fixup): Likewise.
5129
5130 2019-05-17  Tom Tromey  <tromey@adacore.com>
5131
5132         * source.c (find_and_open_source): Remove cast.
5133
5134 2019-05-17  Tom Tromey  <tromey@adacore.com>
5135
5136         * annotate.c (annotate_source): Make "filename" const.
5137         * annotate.h (annotate_source): Use const.
5138
5139 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5140
5141         * disasm.c (set_disassembler_options): Send errors to stderr.
5142
5143 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5144
5145         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5146         (cli_interp_base::set_logging): Check debug_redirect.
5147         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5148         * cli/cli-logging.c (debug_redirect): Add static variable.
5149         (pop_output_files): Add default param.
5150         (handle_redirections): Print debug setting.
5151         (show_logging_command): Likewise.
5152         (_initialize_cli_logging): Add debugredirect command.
5153         * interps.c (current_interp_set_logging): Add debug_redirect
5154         parameter.
5155         * interps.h (set_logging): Add debug_redirect parameter.
5156         (current_interp_set_logging): Likewise.
5157         * mi/mi-common.h: Likewise.
5158         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5159
5160 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5161             Tom Tromey  <tromey@adacore.com>
5162
5163         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5164         directly.
5165         * cli/cli-interp.h (make_logging_output): Remove declaration.
5166         * cli/cli-logging.c (make_logging_output): Remove function.
5167         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5168         directly.
5169         * ui-file.c (tee_file::tee_file): Remove bools.
5170         (tee_file::~tee_file): Remove deletes.
5171         * ui-file.h (tee_file): Remove bools.
5172
5173 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5174
5175         * mi/mi-cmds.h (mi_cmd_complete): New function.
5176         * mi/mi-main.c (mi_cmd_complete): Likewise.
5177         * mi/mi-cmds.c: Define new MI command -complete.
5178         * NEWS: Mention new -complete command.
5179
5180 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5181
5182         * completer.h (complete): New function.
5183         * completer.c (complete): Likewise.
5184         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5185         function defined in completer.h.
5186
5187 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5188
5189         * MAINTAINERS (Write After Approval): Add myself.
5190
5191 2019-05-17  Tom de Vries  <tdevries@suse.de>
5192
5193         PR gdb/24094
5194         * dwarf2read.c (struct cu_partial_die_info): New struct.
5195         (find_partial_die): Return cu_partial_die_info.
5196         (partial_die_parent_scope, guess_partial_die_structure_name)
5197         (partial_die_info::fixup): Handle new return type of find_partial_die.
5198
5199 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5200
5201         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5202         "std::string", simplifying the algorithm.
5203
5204 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5205
5206         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5207         (stap_static_probe_ops::get_probes): Likewise.
5208
5209 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5210
5211         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5212         '-')" and "else if".
5213         (stap_parse_single_operand): Join checks for
5214         "gdbarch_stap_parse_special_token_p" and
5215         "gdbarch_stap_parse_special_token" in the same "if" statement.
5216         Invert check when verifying for operation on register
5217         displacement.
5218
5219 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5220
5221         * stap-probe.c (stap_get_opcode): Update comment.
5222         (stap_get_expected_argument_type): Likewise.
5223         (handle_stap_probe): Likewise.
5224
5225 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5226
5227         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5228         return type to 'bool'.  Adjust comment.  Use 'bool' when
5229         appropriate.
5230         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5231         * stap-probe.c (stap_parse_argument_1): Likewise.
5232         (stap_is_operator): Likewise.
5233         (stap_is_generic_prefix): Likewise.
5234         (stap_is_register_prefix): Likewise.
5235         (stap_is_register_indirection_prefix): Likewise.
5236         (stap_is_integer_prefix): Likewise.
5237         (stap_generic_check_suffix): Likewise.
5238         (stap_check_integer_suffix): Likewise.
5239         (stap_check_register_suffix): Likewise.
5240         (stap_check_register_indirection_suffix): Likewise.
5241         (stap_parse_register_operand): Likewise.
5242         (stap_parse_single_operand): Likewise.
5243         (stap_parse_argument_1): Likewise.
5244         (stap_probe::get_argument_count): Likewise.
5245         (stap_is_operator): Likewise.
5246
5247 2019-05-16  Tom Tromey  <tromey@adacore.com>
5248
5249         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5250         keyword to foreach.
5251
5252 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5253
5254         * linux-thread-db.c (try_thread_db_load_1): Change return type
5255         to bool.
5256         (try_thread_db_load): Likewise.
5257         (try_thread_db_load_from_pdir_1): Likewise.
5258         (try_thread_db_load_from_pdir): Likewise.
5259         (try_thread_db_load_from_sdir): Likewise.
5260         (try_thread_db_load_from_dir): Likewise.
5261         (thread_db_load_search): Likewise.
5262         (has_libpthread): Likewise.
5263         (thread_db_load): Likewise.
5264
5265 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5266
5267         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5268         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5269         NULL, and complain/return if that's the case.
5270
5271 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5272
5273         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5274         (advance, posn, abstract_read_memory): New functions.
5275         [struct mem_read_abstraction]: New struct.
5276         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5277
5278 2019-05-14  Tom Tromey  <tromey@adacore.com>
5279
5280         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5281         value is not lval_memory.
5282
5283 2019-05-14  Tom Tromey  <tromey@adacore.com>
5284
5285         * solib.c (info_sharedlibrary_command): Style the file name.
5286
5287 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5288
5289         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5290         (aarch64_vnv_type): Likewise.
5291         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5292         * common/tdesc.c: Likewise.
5293         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5294         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5295         * features/aarch64-fpu.xml: Add ieee half view.
5296         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5297         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5298         * gdbtypes.h (struct builtin_type): Likewise.
5299         (struct objfile_type): Likewise.
5300
5301 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5302
5303         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5304         typo.
5305         * location.h (string_to_event_location): Likewise.
5306
5307 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5308
5309         GDB 8.3 released.
5310
5311 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5312
5313         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5314         New variable declaration.
5315         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5316         New variable.
5317         (print_one_breakpoint): Use ui_out::test_flags and new global
5318         variable to compute use_fixed_output.
5319         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5320         Remove.
5321         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5322         (mi_multi_location_breakpoint_output_fixed): Remove.
5323         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5324         new variable.
5325         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5326         fix_multi_location_breakpoint_output flag if version >= 3.
5327         * ui-out.h (enum ui_out_flag)
5328         <fix_multi_location_breakpoint_output>: New enumerator.
5329
5330 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5331
5332         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5333
5334 2019-05-10  Tom Tromey  <tromey@adacore.com>
5335
5336         * ada-lang.c (catch_ada_completer): New function.
5337         (_initialize_ada_language): Use it.
5338
5339 2019-05-10  Tom Tromey  <tromey@adacore.com>
5340
5341         * thread.c (print_thread_info): Make "requested_threads" const.
5342         * gdbthread.h (print_thread_info): Make "requested_threads"
5343         const.
5344         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5345         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5346
5347 2019-05-08  Tom Tromey  <tom@tromey.com>
5348
5349         * gdbtypes.c (objfile_type_data): Change type.
5350         (objfile_type, _initialize_gdbtypes): Update.
5351
5352 2019-05-08  Tom Tromey  <tom@tromey.com>
5353
5354         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5355         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5356         (_initialize_dwarf2_frame): Update.
5357
5358 2019-05-08  Tom Tromey  <tom@tromey.com>
5359
5360         * objc-lang.c (objc_objfile_data): Change type.
5361         (find_methods): Update.
5362         (_initialize_objc_lang): Remove.
5363
5364 2019-05-08  Tom Tromey  <tom@tromey.com>
5365
5366         * stabsread.c (rs6000_builtin_type_data): Change type.
5367         (rs6000_builtin_type, _initialize_stabsread): Update.
5368
5369 2019-05-08  Tom Tromey  <tom@tromey.com>
5370
5371         * mips-tdep.c (mips_pdr_data): Remove.
5372         (_initialize_mips_tdep): Update.
5373
5374 2019-05-08  Tom Tromey  <tom@tromey.com>
5375
5376         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5377         (hppa_init_objfile_priv_data, read_unwind_info)
5378         (find_unwind_entry, _initialize_hppa_tdep): Update.
5379
5380 2019-05-08  Tom Tromey  <tom@tromey.com>
5381
5382         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5383         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5384         on obstack.
5385         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5386
5387 2019-05-08  Tom Tromey  <tom@tromey.com>
5388
5389         * mdebugread.c (basic_type_data): Change type.
5390         (basic_type, _initialize_mdebugread): Update.
5391
5392 2019-05-08  Tom Tromey  <tom@tromey.com>
5393
5394         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5395
5396 2019-05-08  Tom Tromey  <tom@tromey.com>
5397
5398         * nto-tdep.c (nto_inferior_data_reg): Change type.
5399         (nto_inferior_data): Update.
5400         (nto_inferior_data_cleanup, nto_new_inferior_data)
5401         (_initialize_nto_tdep): Remove.
5402         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5403
5404 2019-05-08  Tom Tromey  <tom@tromey.com>
5405
5406         * ada-lang.c (struct ada_inferior_data): Add initializers.
5407         (ada_inferior_data): Change type.
5408         (ada_inferior_data_cleanup): Remove.
5409         (get_ada_inferior_data, ada_inferior_exit)
5410         (struct ada_pspace_data): Add initializers, destructor.
5411         (ada_pspace_data_handle): Change type.
5412         (get_ada_pspace_data): Update.
5413         (ada_pspace_data_cleanup): Remove.
5414
5415 2019-05-08  Tom Tromey  <tom@tromey.com>
5416
5417         * coffread.c (struct coff_symfile_info): Add initializers.
5418         (coff_objfile_data_key): Move lower.  Change type.
5419         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5420         Update.
5421         (coff_free_info): Remove.
5422
5423 2019-05-08  Tom Tromey  <tom@tromey.com>
5424
5425         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5426         (fbsd_pspace_data_handle): Move lower.  Change type.
5427         (get_fbsd_pspace_data): Update.
5428         (fbsd_pspace_data_cleanup): Remove.
5429         (_initialize_fbsd_tdep): Update.
5430
5431 2019-05-08  Tom Tromey  <tom@tromey.com>
5432
5433         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5434         (get_ada_tasks_pspace_data): Update.
5435         (ada_tasks_pspace_data_cleanup): Remove.
5436         (_initialize_tasks): Update.
5437         (ada_tasks_inferior_data_handle): Change type.
5438         (get_ada_tasks_inferior_data): Update.
5439         (ada_tasks_inferior_data_cleanup): Remove.
5440         (struct ada_tasks_pspace_data): Add initializers.
5441
5442 2019-05-08  Tom Tromey  <tom@tromey.com>
5443
5444         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5445         * symfile-debug.c (debug_sym_get_probes): Change type.
5446         * stap-probe.c (handle_stap_probe):
5447         (stap_static_probe_ops::get_probes): Change type.
5448         * probe.h (class static_probe_ops) <get_probes>: Change type.
5449         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5450         (parse_probes_in_pspace): Update.
5451         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5452         Update.
5453         (any_static_probe_ops::get_probes): Change type.
5454         * elfread.c (elfread_data): New typedef.
5455         (probe_key): Change type.
5456         (elf_get_probes): Likewise.  Update.
5457         (probe_key_free): Remove.
5458         (_initialize_elfread): Update.
5459         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5460         Change type.
5461         (dtrace_process_dof_probe, dtrace_process_dof)
5462         (dtrace_static_probe_ops::get_probe): Change type.
5463
5464 2019-05-08  Tom Tromey  <tom@tromey.com>
5465
5466         * xcoffread.c (struct xcoff_symfile_info): Rename from
5467         coff_symfile_info.  Add initializers.
5468         (xcoff_objfile_data_key): Move lower.  Change type.
5469         (XCOFF_DATA): Rewrite.
5470         (xcoff_free_info): Remove.
5471         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5472         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5473         (xcoff_initial_scan): Update.
5474
5475 2019-05-08  Tom Tromey  <tom@tromey.com>
5476
5477         * solib-svr4.c (struct svr4_info): Add initializers and
5478         destructor.
5479         <probes_table>: Now an htab_up.
5480         (solib_svr4_pspace_data): Change type.
5481         (free_probes_table): Simplify.
5482         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5483         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5484         (probes_table_remove_objfile_probes, register_solib_event_probe)
5485         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5486         (_initialize_svr4_solib): Update.
5487
5488 2019-05-08  Tom Tromey  <tom@tromey.com>
5489
5490         * remote.c (remote_pspace_data): Change type.
5491         (remote_pspace_data_cleanup): Remove.
5492         (get_remote_exec_file, set_pspace_remote_exec_file)
5493         (_initialize_remote): Update.
5494
5495 2019-05-08  Tom Tromey  <tom@tromey.com>
5496
5497         * breakpoint.c (breakpoint_objfile_key): Change type.
5498         (get_breakpoint_objfile_data): Update.
5499         (free_breakpoint_objfile_data): Remove.
5500         (_initialize_breakpoint): Update.
5501
5502 2019-05-08  Tom Tromey  <tom@tromey.com>
5503
5504         * linux-tdep.c (struct linux_info): Add initializers.
5505         (linux_inferior_data): Move.  Change type.
5506         (invalidate_linux_cache_inf): Update.
5507         (linux_inferior_data_cleanup): Remove.
5508         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5509
5510 2019-05-08  Tom Tromey  <tom@tromey.com>
5511
5512         * auxv.c (auxv_inferior_data): Move.  Change type.
5513         (auxv_inferior_data_cleanup): Remove.
5514         (invalidate_auxv_cache_inf): Rewrite.
5515         (get_auxv_inferior_data, _initialize_auxv): Update.
5516
5517 2019-05-08  Tom Tromey  <tom@tromey.com>
5518
5519         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5520         (symfile_debug_objfile_data_key): Change type.
5521         (symfile_debug_installed, debug_qf_has_symbols)
5522         (debug_qf_find_last_source_symtab)
5523         (debug_qf_forget_cached_source_info)
5524         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5525         (debug_qf_print_stats, debug_qf_dump)
5526         (debug_qf_expand_symtabs_for_function)
5527         (debug_qf_expand_all_symtabs)
5528         (debug_qf_expand_symtabs_with_fullname)
5529         (debug_qf_map_matching_symbols)
5530         (debug_qf_expand_symtabs_matching)
5531         (debug_qf_find_pc_sect_compunit_symtab)
5532         (debug_qf_map_symbol_filenames)
5533         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5534         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5535         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5536         (debug_sym_read_linetable, debug_sym_relocate): Update.
5537         (symfile_debug_free_objfile): Remove.
5538         (install_symfile_debug_logging, _initialize_symfile_debug):
5539         Update.
5540
5541 2019-05-08  Tom Tromey  <tom@tromey.com>
5542
5543         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5544         allocate_on_obstack.
5545         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5546         (get_dwarf2_per_objfile): Update.
5547         (set_dwarf2_per_objfile): Remove.
5548         (dwarf2_has_info, dwarf2_get_section_info): Update.
5549         (dwarf2_free_objfile): Remove.
5550         (_initialize_dwarf2_read): Update.
5551
5552 2019-05-08  Tom Tromey  <tom@tromey.com>
5553
5554         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5555         initializers.
5556         <unsupported_script_warning_printed,
5557         script_not_found_warning_printed>: Now bool.
5558         (auto_load_pspace_data): Change type.
5559         (~auto_load_pspace_info): Rename from
5560         auto_load_pspace_data_cleanup.
5561         (get_auto_load_pspace_data, init_loaded_scripts_info)
5562         (clear_section_scripts, maybe_print_unsupported_script_warning)
5563         (maybe_print_script_not_found_warning, _initialize_auto_load):
5564         Update.
5565
5566 2019-05-08  Tom Tromey  <tom@tromey.com>
5567
5568         * objfiles.c (objfile_pspace_info): Add destructor and
5569         initializers.
5570         (objfiles_pspace_data): Change type.
5571         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5572         (get_objfile_pspace_data): Update.
5573         (objfiles_bfd_data): Change type.
5574         (get_objfile_bfd_data): Update.
5575         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5576
5577 2019-05-08  Tom Tromey  <tom@tromey.com>
5578
5579         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5580         Change type.
5581         (get_catch_syscall_inferior_data): Update.
5582         (catch_syscall_inferior_data_cleanup): Remove.
5583         (_initialize_break_catch_syscall): Update.
5584
5585 2019-05-08  Tom Tromey  <tom@tromey.com>
5586
5587         * inflow.c (struct terminal_info): Add destructor and
5588         initializers.
5589         (inflow_inferior_data): Change type.
5590         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5591         (get_inflow_inferior_data, inflow_inferior_exit)
5592         (swap_terminal_info, _initialize_inflow): Update.
5593
5594 2019-05-08  Tom Tromey  <tom@tromey.com>
5595
5596         * target-dcache.c (target_dcache_cleanup): Remove.
5597         (target_dcache_aspace_key): Change type.
5598         (target_dcache_init_p, target_dcache_invalidate)
5599         (target_dcache_get, target_dcache_get_or_init)
5600         (_initialize_target_dcache): Update.
5601         * dcache.h (struct dcache_deleter): New.
5602
5603 2019-05-08  Tom Tromey  <tom@tromey.com>
5604
5605         * symtab.c (struct symbol_cache): Add destructor and
5606         initializers.
5607         (symbol_cache_key): Move.  Change type.
5608         (make_symbol_cache, free_symbol_cache): Remove.
5609         (get_symbol_cache): Update.
5610         (symbol_cache_cleanup): Remove.
5611         (ALL_PSPACES, symbol_cache_flush)
5612         (maintenance_print_symbol_cache)
5613         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5614         Update.
5615
5616 2019-05-08  Tom Tromey  <tom@tromey.com>
5617
5618         * symtab.c (struct main_info): Add destructor and initializers.
5619         (main_progspace_key): Move.  Change type.
5620         (get_main_info): Update.
5621         (main_info_cleanup): Remove.
5622         (_initialize_symtab): Update.
5623
5624 2019-05-08  Tom Tromey  <tom@tromey.com>
5625
5626         * registry.h (DECLARE_REGISTRY): Define the _key class.
5627
5628 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5629
5630         * NEWS: Merge two 'New commands' sections.
5631
5632 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5633
5634         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5635         parameter and use Ada language definition instead.
5636         (ada_val_print_ptr): Remove unused language parameter.
5637         (ada_val_print_num): Remove language parameter and use Ada language
5638         definition instead.
5639         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5640         parameter.
5641         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5642         parameter and use Ada language definition instead.
5643         (ada_val_print_1): Update all ada_val_print_xxx calls.
5644         Remove language parameter.
5645         (ada_val_print): Update ada_val_print_1 call.
5646
5647 2019-05-08  Tom Tromey  <tromey@adacore.com>
5648
5649         * remote.c (remote_hw_watchpoint_limit)
5650         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5651         Now static.
5652
5653 2019-05-08  Tom Tromey  <tromey@adacore.com>
5654
5655         * maint.c (_initialize_maint_cmds): Move initialization code to
5656         remote.c.
5657         (watchdog, show_watchdog): Move to remote.c.
5658         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5659         "watchdog" static.
5660         (_initialize_remote): Move initialization code from maint.c.
5661         * defs.h (watchdog): Don't declare.
5662
5663 2019-05-08  Tom Tromey  <tromey@adacore.com>
5664
5665         * tui/tui-interp.c: Include main.h.
5666         * interps.c: Include main.h.
5667         * main.h (interpreter_p): Declare.
5668         * defs.h (interpreter_p): Don't declare.
5669
5670 2019-05-08  Tom Tromey  <tromey@adacore.com>
5671
5672         * dwarf2loc.c: Include dwarf2read.h.
5673         * defs.h (read_unsigned_leb128): Don't declare.
5674         * dwarf2read.h (read_unsigned_leb128): Declare.
5675
5676 2019-05-08  Tom Tromey  <tromey@adacore.com>
5677
5678         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5679         method.
5680
5681 2019-05-08  Tom Tromey  <tromey@adacore.com>
5682
5683         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5684         when no wrap column is set.
5685
5686 2019-05-08  Tom Tromey  <tromey@adacore.com>
5687
5688         * c-lang.c (c_get_string): Handle non-C-style arrays.
5689
5690 2019-05-08  Tom Tromey  <tromey@adacore.com>
5691
5692         * typeprint.c (print_offset_data::update): Print the bit offset,
5693         not the number of bits remaining.
5694
5695 2019-05-08  Tom Tromey  <tromey@adacore.com>
5696
5697         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5698         padding at end of comment.
5699
5700 2019-05-08  Tom Tromey  <tromey@adacore.com>
5701
5702         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5703         Compare main types.
5704
5705 2019-05-06  Tom Tromey  <tom@tromey.com>
5706
5707         * common/scoped_mmap.c: Include common-defs.h.
5708         * common/scoped_mmap.h: Don't include config.h.
5709
5710 2019-05-04  Tom Tromey  <tom@tromey.com>
5711
5712         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5713         (struct aarch64_call_info): Add initializers.
5714         <si>: Now a std::vector.
5715         (pass_on_stack, aarch64_push_dummy_call): Update.
5716
5717 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5718             Tom Tromey  <tom@tromey.com>
5719
5720         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5721         (ppc_threads): Now a std::vector.  Now static.
5722         (hwdebug_find_thread_points_by_tid)
5723         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5724         Update.
5725
5726 2019-05-04  Tom Tromey  <tom@tromey.com>
5727
5728         * arc-tdep.c (arc_tdesc_init): Return bool.
5729
5730 2019-05-04  Tom Tromey  <tom@tromey.com>
5731
5732         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5733         Use gdb_assert_not_reached.
5734
5735 2019-05-04  Tom Tromey  <tom@tromey.com>
5736
5737         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5738         "false".
5739
5740 2019-05-04  Tom Tromey  <tom@tromey.com>
5741
5742         * arc-tdep.c (arc_tdesc_init): Use bool.
5743
5744 2019-05-04  Tom Tromey  <tom@tromey.com>
5745
5746         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5747
5748 2019-05-04  Tom Tromey  <tom@tromey.com>
5749
5750         * cli/cli-cmds.c (valid_command_p): Return bool.
5751
5752 2019-05-04  Tom Tromey  <tom@tromey.com>
5753
5754         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5755         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5756
5757 2019-05-04  Raul Tambre  <raul@tambre.ee>
5758
5759         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5760         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5761         operator for comparison.
5762
5763 2019-05-04  Tom Tromey  <tom@tromey.com>
5764
5765         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5766         (lookup_partial_symbol, print_partial_symbols)
5767         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5768         (psymbol_compare): Update.
5769         (add_psymbol_to_bcache): Clear the entire psymbol.
5770         (maintenance_check_psymtabs): Update.
5771         * psympriv.h (struct partial_symbol): Don't derive from
5772         general_symbol_info.
5773         <obj_section, unrelocated_address, address,
5774         set_unrelocated_address>: Update.
5775         <ginfo>: New member.
5776         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5777         (debug_names::write_psymbols): Update.
5778
5779 2019-05-04  Tom de Vries  <tdevries@suse.de>
5780
5781         * contrib/cc-with-tweaks.sh: Support -n arg.
5782
5783 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5784
5785         * corelow.c (core_target::detach): Ensure frame cache and
5786         register caches are cleared.
5787         inferior.c (exit_inferior_1): Likewise.
5788
5789 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5790             Tom Tromey  <tom@tromey.com>
5791
5792         * dictionary.c (collate_pending_symbols_by_language): Remove
5793         "struct" from foreach.
5794         * symtab.c (lookup_global_symbol_from_objfile)
5795         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5796         foreach.
5797         * ser-tcp.c (net_open): Remove "struct" from foreach.
5798         * objfiles.c (objfile_relocate, objfile_rebase)
5799         (objfile_has_symbols): Remove "struct" from foreach.
5800         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5801         from foreach.
5802         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5803         foreach.
5804         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5805         "struct" from foreach.
5806         * ada-lang.c (create_excep_cond_exprs)
5807         (ada_exception_catchpoint_cond_string): Remove "struct" from
5808         foreach.
5809
5810 2019-05-03  Tom Tromey  <tromey@adacore.com>
5811
5812         * ada-exp.y (convert_char_literal): Check suffix of each
5813         enumerator.
5814
5815 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5816
5817         PR ada/21406:
5818         * ada-exp.y (yywrap): Don't define.
5819         * ada-lex.l (%option): Add noyywrap
5820         (yywrap): Remove.
5821
5822 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5823
5824         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5825         _WIN32_WINNT to the XP level, unless already defined to a higher
5826         level.
5827
5828         * unittests/parse-connection-spec-selftests.c:
5829         * ser-tcp.c:
5830         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5831         override.
5832
5833         * symfile.c (find_separate_debug_file): Remove colon from the
5834         drive spec of DOS/Windows file names of the target, so that the
5835         file name produced from DEBUGDIR and the target's directory will
5836         be valid on DOS/Windows systems.
5837
5838 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5839
5840         * rust-lang.c (val_print_struct): Handle printing structures
5841         containing strings.
5842
5843 2019-05-02  Tom Tromey  <tromey@adacore.com>
5844
5845         * valarith.c (_initialize_valarith): Remove.
5846
5847 2019-05-01  Tom Tromey  <tromey@adacore.com>
5848
5849         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5850         bitfields.
5851
5852 2019-05-01  Tom Tromey  <tromey@adacore.com>
5853
5854         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5855         for big-endian copies.
5856
5857 2019-04-30  Ali Tamur  <tamur@google.com>
5858         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5859         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5860         (read_3_bytes): New function.
5861
5862 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5863
5864         * windows-nat.c (main_thread_id): Delete.
5865         (handle_output_debug_string): Replace main_thread_id by
5866         current_event.dwThreadId.
5867         (fake_create_process): Likewise.
5868         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5869         Do not set main_thread_id.
5870         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5871         current_event.dwThreadId.
5872         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5873
5874 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5875
5876         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5877         Use current_event.dwThreadId instead of main_thread_id.
5878
5879 2019-04-30  Tom Tromey  <tromey@adacore.com>
5880
5881         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5882         (create_excep_cond_exprs): Iterate over program spaces.
5883         (ada_exception_catchpoint_cond_string): Examine all minimal
5884         symbols for exception types.
5885
5886 2019-04-30  Tom Tromey  <tromey@adacore.com>
5887
5888         PR c++/24470:
5889         * dwarf2read.c (process_structure_scope): Handle case where type
5890         has template parameters but no symbol was created.
5891
5892 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5893             Chris January  <chris.january@arm.com>
5894
5895         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5896         qualifier.
5897         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5898
5899 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5900
5901         * f-typeprint.c (f_print_type): Update rules for printing
5902         whitespace.
5903         (f_type_print_varspec_suffix): Likewise.
5904
5905 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5906             Chris January  <chris.january@arm.com>
5907
5908         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5909         function arguments.
5910
5911 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5912
5913         * f-lang.c (build_fortran_types): Change name of void type to
5914         lower case.
5915         * f-typeprint.c (f_type_print_base): Print the name of the void
5916         type, rather than a fixed string.
5917         * f-valprint.c (f_decorations): Use lower case void string.
5918
5919 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5920             Chris January  <chris.january@arm.com>
5921
5922         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5923         types for Fortran.
5924
5925 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5926             Chris January  <chris.january@arm.com>
5927             David Lecomber  <david.lecomber@arm.com>
5928
5929         * f-exp.y (BINOP_INTRINSIC): New token.
5930         (exp): New parser rule handling BINOP_INTRINSIC.
5931         (f77_keywords): Add new builtin procedures.
5932         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5933         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5934         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5935         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5936         (print_unop_subexp_f): New function.
5937         (print_binop_subexp_f): New function.
5938         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5939         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5940         (dump_subexp_body_f): Likewise.
5941         (operator_check_f): Likewise.
5942         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5943         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5944
5945 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5946
5947         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5948         UNOP_KIND.
5949         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5950         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5951         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5952         (operator_length_f): New fuction.
5953         (print_subexp_f): New function.
5954         (op_name_f): New function.
5955         (dump_subexp_body_f): New function.
5956         (operator_check_f): New function.
5957         (exp_descriptor_f): Replace standard expression handling functions
5958         with new functions.
5959         * gdb/fortran-operator.def: New file.
5960         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5961         * gdb/std-operator.def: Remove UNOP_KIND.
5962
5963 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5964
5965         * std-operator.def: Remove unbalanced, stray double quote
5966         character.
5967
5968 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5969             Chris January  <chris.january@arm.com>
5970             Daniel Everett  <daniel.everett@arm.com>
5971             Nick Forrington  <nick.forrington@arm.com>
5972             Richard Bunt  <richard.bunt@arm.com>
5973
5974         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5975         of depth when printing anonymous structs or unions.
5976         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5977         Don't print either the top-level value, or the children if the
5978         max-depth is exceeded.
5979         (ppscm_print_children): When printing the key of a map, allow one
5980         extra level of depth.
5981         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5982         print either the top-level value, or the children if the max-depth
5983         is exceeded.
5984         (print_children): When printing the key of a map, allow one extra
5985         level of depth.
5986         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5987         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5988         (user_print_options): Initialise max_depth field.
5989         (val_print_scalar_or_string_type_p): New function.
5990         (val_print): Check to see if the max depth has been reached.
5991         (val_print_check_max_depth): Define new function.
5992         (show_print_max_depth): New function.
5993         (_initialize_valprint): Add 'print max-depth' option.
5994         * valprint.h (struct value_print_options) <max_depth>: New field.
5995         (val_print_check_max_depth): Declare new function.
5996         * NEWS: Document new feature.
5997
5998 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5999
6000         * ada-lang.c (ada_language_defn): Initialise new field.
6001         * c-lang.c (c_is_string_type_p): New function.
6002         (c_language_defn): Initialise new field.
6003         (cplus_language_defn): Initialise new field.
6004         (asm_language_defn): Initialise new field.
6005         (minimal_language_defn): Initialise new field.
6006         * c-lang.h (c_is_string_type_p): Declare new function.
6007         * d-lang.c (d_language_defn): Initialise new field.
6008         * f-lang.c (f_is_string_type_p): New function.
6009         (f_language_defn): Initialise new field.
6010         * go-lang.c (go_is_string_type_p): New function.
6011         (go_language_defn): Initialise new field.
6012         * language.c (default_is_string_type_p): New function.
6013         (unknown_language_defn): Initialise new field.
6014         (auto_language_defn): Initialise new field.
6015         * language.h (struct language_defn) <la_is_string_type_p>: New
6016         member variable.
6017         (default_is_string_type_p): Declare new function.
6018         * m2-lang.c (m2_language_defn): Initialise new field.
6019         * objc-lang.c (objc_language_defn): Initialise new field.
6020         * opencl-lang.c (opencl_language_defn): Initialise new field.
6021         * p-lang.c (pascal_is_string_type_p): New function.
6022         (pascal_language_defn): Initialise new field.
6023         * rust-lang.c (rust_is_string_type_p): New function.
6024         (rust_language_defn): Initialise new field.
6025
6026 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6027
6028         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6029         New field.
6030         * ada-lang.c (ada_language_defn): Initialise new field.
6031         * c-lang.c (c_language_defn): Likewise.
6032         (cplus_language_defn): Likewise.
6033         (asm_language_defn): Likewise.
6034         (minimal_language_defn): Likewise.
6035         * d-lang.c (d_language_defn): Likewise.
6036         * f-lang.c (f_language_defn): Likewise.
6037         * go-lang.c (go_language_defn): Likewise.
6038         * language.c (unknown_language_defn): Likewise.
6039         (auto_language_defn): Likewise.
6040         * m2-lang.c (m2_language_defn): Likewise.
6041         * objc-lang.c (objc_language_defn): Likewise.
6042         * opencl-lang.c (opencl_language_defn): Likewise.
6043         * p-lang.c (pascal_language_defn): Likewise.
6044         * rust-lang.c (rust_language_defn): Likewise.
6045
6046 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6047
6048         * ada-lang.c (ada_is_character_type): Change return type to bool.
6049         (ada_is_string_type): Likewise.
6050         * ada-lang.h (ada_is_character_type): Update declaration
6051         (ada_is_string_type): Likewise.
6052
6053 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6054
6055         Support style in 'frame|thread apply'
6056
6057         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6058         * record.c (record_start, record_stop): Update callers of
6059         execute_command_to_string with false.
6060         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6061         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6062         methods.
6063         (class string_file): New constructor with term_out parameter.
6064         Override methods term_out and can_emit_style_escape.  New member
6065         term_out.
6066         (class stdio_file): Override can_emit_style_escape.
6067         (class tee_file): Override term_out and can_emit_style_escape.
6068         * utils.h (can_emit_style_escape): Remove.
6069         * utils.c (can_emit_style_escape): Likewise.
6070         Update all callers of can_emit_style_escape (SOMESTREAM) to
6071         SOMESTREAM->can_emit_style_escape.
6072         * source-cache.c (source_cache::get_source_lines): Likewise.
6073         * stack.c (frame_apply_command_count): Call execute_command_to_string
6074         passing the term_out characteristic of the current gdb_stdout.
6075         * thread.c (thr_try_catch_cmd): Likewise.
6076         * top.c (execute_command_to_string): pass term_out parameter
6077         to construct the string_file for the command output.
6078         * ui-file.c (term_cli_styling): New function (most code moved
6079         from utils.c can_emit_style_escape).
6080         (string_file::string_file, string_file::can_emit_style_escape,
6081         stdio_file::can_emit_style_escape, tee_file::term_out,
6082         tee_file::can_emit_style_escape): New functions.
6083
6084 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6085
6086         * NEWS: Mention the new set|show may-call-functions.
6087         * infcall.c (may_call_functions_p): New variable.
6088         (show_may_call_functions_p): New function.
6089         (call_function_by_hand_dummy): Throws an error if not
6090         may-call-functions.
6091         (_initialize_infcall): Call add_setshow_boolean_cmd for
6092         may-call-functions.
6093
6094 2019-04-25  Keith Seitz  <keiths@redhat.com>
6095
6096         PR c++/24367
6097         * cp-support.c (inspect_type): Don't attempt substitutions
6098         of symbol with the same name.
6099
6100 2019-04-25  Tom Tromey  <tromey@adacore.com>
6101
6102         PR gdb/24475:
6103         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6104         static.
6105
6106 2019-04-25  Tom Tromey  <tromey@adacore.com>
6107
6108         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6109         rvalue reference.
6110         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6111         (gdb_xml_parser::parse): Use std::move.
6112         * python/python-internal.h (gdbpy_convert_exception): Take a const
6113         reference.
6114         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6115         std::move.
6116         * python/py-utils.c (gdbpy_convert_exception): Take a const
6117         reference.
6118         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6119         Use std::move.
6120         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6121         Use std::move.
6122         * mi/mi-main.c (mi_print_exception): Take a const reference.
6123         * main.c (handle_command_errors): Take a const reference.
6124         * linespec.c (parse_linespec): Use std::move.
6125         * infcall.c (run_inferior_call): Use std::move.
6126         (call_function_by_hand_dummy): Use std::move.
6127         * exec.c (try_open_exec_file): Use std::move.
6128         * exceptions.h (exception_print, exception_fprintf)
6129         (exception_print_same): Update.
6130         * exceptions.c (print_exception, exception_print)
6131         (exception_fprintf, exception_print_same): Change parameters to
6132         const reference.
6133         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6134         * common/new-op.c: Use std::move.
6135         * common/common-exceptions.h (struct gdb_exception): Add move
6136         constructor.
6137         (struct gdb_exception_error, struct gdb_exception_quit, struct
6138         gdb_quit_bad_alloc): Change constructor to move constructor.
6139         (throw_exception): Change parameter to rvalue reference.
6140         * common/common-exceptions.c (throw_exception): Take rvalue
6141         reference.
6142         * cli/cli-interp.c (safe_execute_command): Use std::move.
6143         * breakpoint.c (insert_bp_location, location_to_sals): Use
6144         std::move.
6145
6146 2019-04-25  Tom Tromey  <tromey@adacore.com>
6147
6148         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6149         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6150         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6151         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6152         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6153         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6154         guile/scm-value.c: Use unpack.
6155         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6156         gdbscm_gdb_exception.
6157         (gdbscm_throw_gdb_exception): Likewise.
6158         (struct gdbscm_gdb_exception): New.
6159         (unpack): New function.
6160         (gdbscm_wrap): Use unpack.
6161
6162 2019-04-25  Tom Tromey  <tromey@adacore.com>
6163
6164         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6165         (gdb_rl_callback_handler): Use std::move.
6166         * common/common-exceptions.h (struct gdb_exception): Add move
6167         assignment operator.
6168         (throw_exception_sjlj): Change "exception" to const reference.
6169         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6170         (throw_exception_sjlj): Change "exception" to const reference.
6171
6172 2019-04-25  Tom Tromey  <tromey@adacore.com>
6173
6174         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6175         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6176         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6177         Update.
6178         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6179         Update.
6180         * mi/mi-interp.c (mi_interp::exec): Update.
6181         * linespec.c (parse_linespec): Update.
6182         * infcall.c (run_inferior_call): Update.
6183         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6184         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6185         (gdbscm_lookup_global_symbol): Update.
6186         * guile/scm-param.c (gdbscm_parameter_value): Update.
6187         * guile/scm-frame.c (gdbscm_frame_read_register)
6188         (gdbscm_frame_read_var): Update.
6189         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6190         * exec.c (try_open_exec_file): Update.
6191         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6192         (gdb_rl_callback_handler): Update.
6193         * common/common-exceptions.h (exception_none): Don't declare.
6194         * common/common-exceptions.c (exception_none): Don't define.
6195         (struct catcher) <exception>: Update.
6196         * cli/cli-interp.c (safe_execute_command): Update.
6197         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6198
6199 2019-04-25  Ali Tamur  <tamur@google.com>
6200
6201         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6202         (read_attribute_value): Likewise.
6203         (dwarf2_read_addr_index): Update comment.
6204         (read_str_index): Add DW_FORM_strx.
6205         (dwarf2_string_attr): Likewise.
6206         (dwarf2_const_value_attr): Likewise.
6207         (dump_die_shallow): Likewise.
6208         (dwarf2_fetch_constant_bytes): Likewise.
6209         (skip_form_bytes): Likewise.
6210         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6211
6212 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6213
6214         PR corefiles/11608
6215         PR corefiles/18187
6216         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6217         OFFSET.  Verify if current mapping contains an ELF header.
6218         (linux_find_memory_regions_full): Adjust call to
6219         dump_mapping_p.
6220
6221 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6222             Kang Li <kanglictf@gmail.com>
6223
6224         PR gdb/21600
6225
6226         * dwarf2-frame.c (read_initial_length): Be consistent about using
6227         unsigned representation of length.
6228         (decode_frame_entry_1): Likewise.  Check for wraparound of
6229         end pointer as well as buffer overflow.
6230
6231 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6232
6233         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6234         "vq".
6235
6236 2019-04-24  Tom Tromey  <tromey@adacore.com>
6237
6238         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6239
6240 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6241
6242         * s12z-tdep.c (s12z_unwind_pc): Delete.
6243         (s12z_unwind_sp): Delete.
6244         (s12z_gdbarch_init): Don't register deleted functions with
6245         gdbarch.
6246
6247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6248
6249         * rl78-tdep.c (rl78_unwind_sp): Delete.
6250         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6251
6252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6253
6254         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6255         (xstormy16_unwind_pc): Delete.
6256         (xstormy16_dummy_id): Delete.
6257         (xstormy16_gdbarch_init): Don't register deleted functions with
6258         gdbarch.
6259
6260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6261
6262         * vax-tdep.c (vax_unwind_pc): Delete.
6263         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6264
6265 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6266
6267         * v850-tdep.c (v850_unwind_sp): Delete.
6268         (v850_unwind_pc): Delete.
6269         (v850_dummy_id): Delete.
6270         (v850_gdbarch_init): Don't register deleted functions with
6271         gdbarch.
6272
6273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6274
6275         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6276         (tilegx_unwind_pc): Delete.
6277         (tilegx_unwind_dummy_id): Delete.
6278         (tilegx_gdbarch_init): Don't register deleted functions with
6279         gdbarch.
6280
6281 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6282
6283         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6284         (tic6x_dummy_id): Delete.
6285         (tic6x_gdbarch_init): Don't register deleted functions with
6286         gdbarch.
6287
6288 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6289
6290         * sparc-tdep.c (sparc_unwind_pc): Delete.
6291         (sparc32_gdbarch_init): Don't register deleted function with
6292         gdbarch.
6293
6294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6295
6296         * sh-tdep.c (sh_unwind_sp): Delete.
6297         (sh_unwind_pc): Delete.
6298         (sh_dummy_id): Delete.
6299         (sh_gdbarch_init): Don't register deleted functions with
6300         gdbarch.
6301
6302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6303
6304         * score-tdep.c (score_unwind_sp): Delete.
6305         (score_unwind_pc): Delete.
6306         (score_dummy_id): Delete.
6307         (score_gdbarch_init): Don't register deleted functions with
6308         gdbarch.
6309
6310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6311
6312         * rx-tdep.c (rx_unwind_pc): Delete.
6313         (rx_unwind_sp): Delete.
6314         (rx_dummy_id): Delete.
6315         (rx_gdbarch_init): Don't register deleted functions with
6316         gdbarch.  Update comment.
6317
6318 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6319
6320         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6321         (rs6000_dummy_id): Delete.
6322         (rs6000_gdbarch_init): Don't register deleted functions with
6323         gdbarch.
6324
6325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6326
6327         * or1k-tdep.c (or1k_dummy_id): Delete.
6328         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6329
6330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6331
6332         * nios2-tdep.c (nios2_dummy_id): Delete.
6333         (nios2_unwind_sp): Delete.
6334         (nios2_gdbarch_init): Don't register deleted functions with
6335         gdbarch.
6336
6337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6338
6339         * nds32-tdep.c (nds32_dummy_id): Delete.
6340         (nds32_unwind_pc): Delete.
6341         (nds32_unwind_sp): Delete.
6342         (nds32_gdbarch_init): Don't register deleted functions with
6343         gdbarch.
6344
6345 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6346
6347         * msp430-tdep.c (msp430_unwind_pc): Delete.
6348         (msp430_unwind_sp): Delete.
6349         (msp430_dummy_id): Delete.
6350         (msp430_gdbarch_init): Don't register deleted functions with
6351         gdbarch.
6352
6353 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6354
6355         * moxie-tdep.c (moxie_unwind_sp): Delete.
6356         (moxie_unwind_pc): Delete.
6357         (moxie_dummy_id): Delete.
6358         (moxie_gdbarch_init): Don't register deleted functions with
6359         gdbarch.
6360
6361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6362
6363         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6364         (mn10300_unwind_pc): Delete.
6365         (mn10300_unwind_sp): Delete.
6366         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6367         mn10300_unwind_sp.
6368         (mn10300_frame_unwind_init): Don't register deleted functions with
6369         gdbarch.
6370
6371 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6372
6373         * mep-tdep.c (mep_unwind_pc): Delete.
6374         (mep_unwind_sp): Delete.
6375         (mep_dummy_id): Delete.
6376         (mep_gdbarch_init): Don't register deleted functions with
6377         gdbarch.
6378
6379 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6380
6381         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6382         (m68hc11_unwind_sp): Delete.
6383         (m68hc11_gdbarch_init): Don't register deleted functions with
6384         gdbarch.
6385
6386 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6387
6388         * m32r-tdep.c (m32r_unwind_sp): Delete.
6389         (m32r_unwind_pc): Delete.
6390         (m32r_dummy_id): Delete.
6391         (m32r_gdbarch_init): Don't register deleted functions with
6392         gdbarch.
6393
6394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6395
6396         * m32c-tdep.c (m32c_unwind_pc): Delete.
6397         (m32c_unwind_sp): Delete.
6398         (m32c_dummy_id): Delete.
6399         (m32c_gdbarch_init): Don't register deleted functions with
6400         gdbarch.
6401
6402 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6403
6404         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6405         (lm32_unwind_pc): Delete.
6406         (lm32_dummy_id): Delete.
6407         (lm32_gdbarch_init): Don't register deleted functions with
6408         gdbarch.
6409
6410 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6411
6412         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6413         (iq2000_unwind_pc): Delete.
6414         (iq2000_dummy_id): Delete.
6415         (iq2000_gdbarch_init): Don't register deleted functions with
6416         gdbarch.
6417
6418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6419
6420         * nds32-tdep.c (nds32_type_align): Delete.
6421         (nds32_push_dummy_call): Use type_align instead.
6422
6423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6424
6425         * arm-tdep.c (arm_type_align): Only handle vector override case.
6426         (arm_push_dummy_call): Use type_align.
6427         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6428
6429 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6430
6431         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6432         case.
6433         (pass_on_stack): Use type_align.
6434         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6435         function.
6436
6437 2019-04-23  Tom Tromey  <tromey@adacore.com>
6438
6439         * dwarf2read.c (line_header::file_name_at): Remove unused
6440         overload.
6441
6442 2019-04-23  Tom de Vries  <tdevries@suse.de>
6443
6444         PR gdb/24438
6445         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6446         invocation.
6447
6448
6449 2019-03-27  Ali Tamur  <tamur@google.com>
6450
6451         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6452         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6453         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6454         (dwarf_expr_context::get_addr_index): Likewise
6455         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6456         (symbol_needs_eval_context::get_addr_index): Likewise
6457         (disassemble_dwarf_expression): Add DW_OP_addrx
6458         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6459         (read_cutu_die_from_dwo): Update comment
6460         (skip_one_die): Add DW_FORM_addrx
6461         (read_attribute_value): Likewise
6462         (var_decode_location): Add DW_OP_addrx
6463         (dwarf2_const_value_attr): Add DW_FORM_addrx
6464         (dump_die_shallow): Likewise
6465         (dwarf2_fetch_constant_bytes): Likewise
6466         (decode_locdesc): Add DW_OP_addrx
6467         (skip_form_bytes): Add DW_FORM_addrx
6468
6469 2019-04-22  Ali Tamur  <tamur@google.com>
6470
6471         * MAINTAINERS (Write After Approval): Add self.
6472
6473 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6474
6475         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6476         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6477         (open_symbol_file_object): Likewise.
6478         (svr4_default_sos): Add info parameter.
6479         (svr4_read_so_list): Likewise.
6480         (svr4_current_sos_direct): Adjust functions calls to pass down
6481         info.
6482         (svr4_current_sos_1): Add info parameter.
6483         (svr4_current_sos): Call get_svr4_info, pass info down to
6484         svr4_current_sos_1.
6485         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6486         get_svr4_info.
6487         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6488         get_svr4_info.
6489         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6490         to get_svr4_info.
6491         (probes_table_remove_objfile_probes): Likewise.
6492         (register_solib_event_probe): Add info parameter.
6493         (solist_update_incremental): Pass info parameter down to
6494         svr4_read_so_list.
6495         (disable_probes_interface): Add info parameter.
6496         (svr4_handle_solib_event): Pass current_program_space to
6497         get_svr4_info.  Adjust disable_probes_interface cleanup.
6498         (svr4_create_probe_breakpoints): Add info parameter, pass it
6499         down to register_solib_event_probe.
6500         (svr4_create_solib_event_breakpoints): Add info parameter,
6501         pass it down to svr4_create_probe_breakpoints.
6502         (enable_break): Pass info down to
6503         svr4_create_solib_event_breakpoints.
6504         (svr4_solib_create_inferior_hook): Pass current_program_space to
6505         get_svr4_info.
6506         (svr4_clear_solib): Likewise.
6507
6508 2019-04-22  Pedro Alves  <palves@redhat.com>
6509
6510         * solib-svr4.c (svr4_free_objfile_observer): New.
6511         (probe_and_action::objfile): New field.
6512         (probes_table_htab_remove_objfile_probes)
6513         (probes_table_remove_objfile_probes): New functions.
6514         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6515         in the new probe_and_action.  Don't store the probe in 'lookup'.
6516         (svr4_create_probe_breakpoints): Pass objfile to
6517         register_solib_event_probe.
6518         (_initialize_svr4_solib): Register a free_objfile observer.
6519
6520 2019-04-19  Tom Tromey  <tom@tromey.com>
6521
6522         * common/queue.h: Remove.
6523
6524 2019-04-19  Tom Tromey  <tom@tromey.com>
6525
6526         * event-loop.c: Don't include "common/queue.h".
6527
6528 2019-04-19  Tom Tromey  <tom@tromey.com>
6529
6530         * remote.c (remote_target): Use delete.
6531         * remote-notif.h: Include <list>, not "common/queue.h".
6532         (notif_client_p): Remove typedef.
6533         (remote_notif_state): Add constructor, destructor, initializer.
6534         <notif_queue>: Now a std::list.
6535         (remote_notif_state_xfree): Don't declare.
6536         * remote-notif.c (remote_notif_process, handle_notification)
6537         (remote_notif_state_allocate): Update.
6538         (~remote_notif_state): Rename from remote_notif_state_xfree.
6539
6540 2019-04-19  Tom Tromey  <tom@tromey.com>
6541
6542         * symfile.c (reread_symbols): Update.
6543         * objfiles.c (objfile_register_static_link)
6544         (objfile_lookup_static_link): Update
6545         (~objfile) Don't delete static_links.
6546         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6547
6548 2019-04-19  Tom Tromey  <tom@tromey.com>
6549
6550         * type-stack.h (struct type_stack) <insert>: Constify string.
6551         * type-stack.c (type_stack::insert): Constify string.
6552         * gdbtypes.h (lookup_template_type): Update.
6553         (address_space_name_to_int): Update.
6554         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6555         const.
6556         (lookup_template_type): Make name const.
6557         * c-exp.y: Update rules.
6558         (lex_one_token, classify_name, classify_inner_name)
6559         (c_print_token): Update.
6560         * p-exp.y: Update rules.
6561         (yylex): Update.
6562         * f-exp.y: Update rules.
6563         (yylex): Update.
6564         * d-exp.y: Update rules.
6565         (lex_one_token, classify_name, classify_inner_name): Update.
6566         * parse.c (write_dollar_variable, copy_name): Return std::string.
6567         * parser-defs.h (copy_name): Change return type.
6568         * m2-exp.y: Update rules.
6569         (yylex): Update.
6570         * go-exp.y (lex_one_token): Update.
6571         Update rules.
6572         (classify_unsafe_function, classify_packaged_name)
6573         (classify_name, yylex): Update.
6574
6575 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6576
6577         * configure.ac: add --enable-source-highlight switch.
6578         * configure: Regenerate.
6579         * top.c (print_gdb_version): plumb --enable-source-highlight
6580         status to "show configuration".
6581
6582 2019-04-19  Tom Tromey  <tromey@adacore.com>
6583
6584         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6585         Check ADA_TYPE_P.
6586         (empty_record, ada_template_to_fixed_record_type_1)
6587         (template_to_static_fixed_type)
6588         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6589         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6590         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6591         macros.
6592
6593 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6594
6595         PR symtab/24423:
6596         * source.c (print_source_lines_base): Advance "iter" when a
6597         control character is seen.
6598
6599 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6600
6601         * inferior.h (struct infcall_suspend_state_deleter):
6602         Catch exception in destructor to avoid crash.
6603
6604 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6605
6606         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6607         close to the add_com "shell".
6608
6609 2019-04-18  Tom Tromey  <tromey@adacore.com>
6610
6611         * process-stratum-target.h (class process_stratum_target)
6612         <stratum>: Add "final".
6613
6614 2019-04-17  Tom Tromey  <tromey@adacore.com>
6615
6616         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6617         against nullptr before use.
6618
6619 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6620
6621         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6622
6623 2019-04-17  Jim Wilson  <jimw@sifive.com>
6624             Andrew Burgess  <andrew.burgess@embecosm.com>
6625
6626         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6627         code read might fail, assume 4-byte breakpoint in that case.
6628
6629 2019-04-15  Leszek Swirski  <leszeks@google.com>
6630
6631         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6632         rather than a hand-rolled POD check when checking for forced MEMORY
6633         classification.
6634
6635 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6636
6637         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6638         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6639         function.
6640         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6641         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6642         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6643         declaration.
6644
6645 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6646
6647         * aarch64-linux-nat.c
6648         (aarch64_linux_nat_target::thread_architecture): Add override.
6649         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6650         each VQ.
6651
6652 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6653
6654         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6655
6656 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6657
6658         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6659         target types of size 96-bits, add some additional comments, and
6660         check that the builtin type we found was the correct size.
6661
6662 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6663
6664         * utils.c (prompt_for_continue): Don't restore the styling at the
6665         end, as applied_style has the wrong value.  This fixes styling in
6666         long lists of file names that are interrupted by the "Continue?"
6667         prompt.
6668
6669 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6670
6671         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6672         * c-lang.c (c_language_defn): Likewise.
6673         (cplus_language_defn): Likewise.
6674         (asm_language_defn): Likewise.
6675         (minimal_language_defn): Likewise.
6676         * d-lang.c (d_language_defn): Likewise.
6677         * f-lang.c (f_language_defn): Likewise.
6678         * go-lang.c (go_language_defn): Likewise.
6679         * language.c (unknown_language_defn): Likewise.
6680         (auto_language_defn): Likewise.
6681         * language.h (struct language_defn): Remove la_magic field.
6682         (LANG_MAGIC): Delete.
6683         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6684         * objc-lang.c (objc_language_defn): Likewise.
6685         * opencl-lang.c (opencl_language_defn): Likewise.
6686         * p-lang.c (pascal_language_defn): Likewise.
6687         * rust-lang.c (rust_language_defn): Likewise.
6688
6689 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6690
6691         * riscv-tdep.c (riscv_type_align): New function.
6692         (riscv_type_alignment): Delete.
6693         (riscv_arg_location): Use 'type_align'.
6694         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6695
6696 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6697
6698         * gdbtypes.c (type_align): A struct with no non-static fields also
6699         has alignment of 1.
6700
6701 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6702
6703         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6704         component to 0.
6705         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6706         member.
6707         (riscv_struct_info::analyse): New implementation using new
6708         analyse_inner member function.
6709         (riscv_struct_info::field_offset): New member function.
6710         (riscv_struct_info::m_offsets): New member variable.
6711         (riscv_struct_info::analyse_inner): New private member function,
6712         takes the old implementation of riscv_struct_info::analyse but
6713         extended to track field offsets.
6714         (riscv_call_arg_struct): Update the struct folding special cases
6715         to handle cases where empty C++ structs, which are non-zero
6716         length, are found.
6717         (riscv_arg_location): Initialise the length of each location, a
6718         non-zero length now indicates the location is in use.
6719         (riscv_push_dummy_call): Allow for the first location having a
6720         non-zero offset when setting up arguments.
6721         (riscv_return_value): Likewise, but for return values.
6722
6723 2019-04-11  Tom Tromey  <tromey@adacore.com>
6724
6725         * utils.c (internal_vproblem): Make "msg" const.
6726
6727 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6728
6729         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6730         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6731         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6732         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6733
6734 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6735
6736         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6737         function.
6738         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6739         of amd64_collect_native_gregset.
6740         (amd64_linux_nat_target::store_registers): Likewise.
6741
6742 2019-04-10  Tom Tromey  <tom@tromey.com>
6743
6744         * symtab.c (lookup_global_symbol_from_objfile)
6745         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6746         * objfiles.h (class separate_debug_iterator): New.
6747         (class separate_debug_range): New.
6748         (struct objfile) <separate_debug_objfiles>: New method.
6749         (objfile_separate_debug_iterate): Don't declare.
6750         * objfiles.c (separate_debug_iterator::operator++): Rename from
6751         objfile_separate_debug_iterate.
6752         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6753         iterator.
6754         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6755         iterator.
6756
6757 2019-04-10  Tom Tromey  <tom@tromey.com>
6758
6759         * symfile.c (reread_symbols): Remove old comment.
6760         * objfiles.c (free_all_objfiles): Fix a typo.
6761
6762 2019-04-10  Tom Tromey  <tom@tromey.com>
6763
6764         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6765         * minsyms.c (lookup_minimal_symbol): Use foreach.
6766         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6767         (lookup_minimal_symbol_solib_trampoline): Likewise.
6768         * symfile.c (reread_symbols): Use foreach.
6769
6770 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6771             Tom Tromey  <tromey@adacore.com>
6772
6773         PR rust/24414:
6774         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6775         (rust_lex_int_test): Change "value" to be LONGEST.
6776         (rust_lex_tests): Add test for long integer literal.
6777
6778 2019-04-09  Tom Tromey  <tromey@adacore.com>
6779
6780         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6781         to bool.
6782         (extended_remote_target::attach): Update.
6783         (remote_target::remote_notice_new_inferior): Update.
6784         (remote_target::add_current_inferior_and_thread): Update.
6785         * inferior.c (exit_inferior_1): Use "false".
6786         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6787
6788 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6789
6790         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6791         the "start" command.
6792
6793 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6794
6795         * python/py-inferior.c (infpy_thread_from_thread_handle):
6796         Adjust comments to reflect renaming of thread_from_thread_handle
6797         to thread_from_handle.  Adjust keywords.  Fix type error message.
6798         (inferior_object_methods): Add thread_from_handle.  Retain
6799         thread_from_thread_handle, but mark it as deprecated.
6800
6801 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6802
6803         * gdbthread.h (find_thread_by_handle): Revise declaration.
6804         * thread.c (find_thread_by_handle): Likewise.  Adjust
6805         implementation too.
6806         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6807         support for buffer objects as handles.
6808
6809 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6810
6811         * python/py-infthread.c (thpy_thread_handle): New function.
6812         (thread_object_methods): Register thpy_thread_handle.
6813
6814 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6815
6816         * gdbthread.h (thread_to_thread_handle): Declare.
6817         * thread.c (gdbtypes.h): Include.
6818         (thread_to_thread_handle): New function.
6819
6820         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6821         (target_thread_info_to_thread_handle): Declare.
6822         * target.c (target_thread_info_to_thread_handle): New function.
6823         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6824         * target-delegates.c: Regenerate.
6825
6826         * linux-thread-db.c (class thread_db_target): Add method
6827         thread_info_to_thread_handle.
6828         (thread_db_target::thread_info_to_thread_handle): Define.
6829         * remote.c (class remote_target): Add new method
6830         thread_info_to_thread_handle.
6831         (remote_target::thread_info_to_thread_handle): Define.
6832
6833 2019-04-08  Pedro Alves  <palves@redhat.com>
6834
6835         * common/common-exceptions.c (throw_exception): Don't create
6836         named object to throw; throw directly.
6837         (throw_it): Likewise.  Don't initialize gdb_exception::message
6838         here, with new; pass FMT and AP to the ctor instead.
6839         * common/common-exceptions.h: Include <string>.
6840         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6841         const char *, va_list)): New ctor.  Use std::make_shared.
6842         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6843         errors)): Delete.
6844         (gdb_exception_error::gdb_exception_error(enum errors, const char
6845         *, va_list)): New.
6846         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6847         Add assertion.
6848         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6849         errors)): Delete.
6850         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6851         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6852         Add assertion.
6853
6854 2019-04-08  Tom Tromey  <tom@tromey.com>
6855
6856         * valops.c (value_rtti_indirect_type): Replace throw_exception
6857         with throw.
6858         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6859         with throw.
6860         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6861         throw.
6862         * target.c (target_translate_tls_address): Replace throw_exception
6863         with throw.
6864         * stack.c (frame_apply_command_count): Replace throw_exception
6865         with throw.
6866         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6867         throw.
6868         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6869         with throw.
6870         * rs6000-tdep.c (rs6000_frame_cache)
6871         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6872         * remote.c: Replace throw_exception with throw.
6873         * record-full.c (record_full_message, record_full_wait_1)
6874         (record_full_restore): Replace throw_exception with throw.
6875         * record-btrace.c:
6876         (get_thread_current_frame_id, record_btrace_start_replaying)
6877         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6878         (cmd_record_btrace_start): Replace throw_exception with throw.
6879         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6880         throw.
6881         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6882         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6883         * linespec.c:
6884         (find_linespec_symbols): Replace throw_exception with throw.
6885         * infrun.c (displaced_step_prepare, resume): Replace
6886         throw_exception with throw.
6887         * infcmd.c (post_create_inferior): Replace throw_exception with
6888         throw.
6889         * inf-loop.c (inferior_event_handler): Replace throw_exception
6890         with throw.
6891         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6892         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6893         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6894         (get_prev_frame_always, get_frame_pc_if_available)
6895         (get_frame_address_in_block_if_available, get_frame_language):
6896         Replace throw_exception with throw.
6897         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6898         throw_exception with throw.
6899         * eval.c (fetch_subexp_value, evaluate_var_value)
6900         (evaluate_funcall, evaluate_subexp_standard): Replace
6901         throw_exception with throw.
6902         * dwarf2loc.c (call_site_find_chain)
6903         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6904         Replace throw_exception with throw.
6905         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6906         with throw.
6907         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6908         throw.
6909         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6910         * completer.c (complete_line_internal): Replace throw_exception
6911         with throw.
6912         * compile/compile-object-run.c (compile_object_run): Replace
6913         throw_exception with throw.
6914         * cli/cli-script.c (process_next_line): Replace throw_exception
6915         with throw.
6916         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6917         (btrace_enable, btrace_maint_update_pt_packets): Replace
6918         throw_exception with throw.
6919         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6920         throw_exception with throw.
6921         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6922         throw_exception with throw.
6923         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6924         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6925         * aarch64-tdep.c (aarch64_make_prologue_cache)
6926         (aarch64_make_stub_cache): Replace throw_exception with throw.
6927
6928 2019-04-08  Tom Tromey  <tom@tromey.com>
6929
6930         * common/common-exceptions.c (throw_exception): Rename from
6931         throw_exception_cxx.  Remove old copy.  Make argument const.
6932         (throw_it): Create and throw exception objects directly.
6933         * common/common-exceptions.h (throw_exception): Make argument
6934         const.
6935         (struct gdb_exception_error): Add constructor.
6936         (struct gdb_exception_quit): Add constructor.
6937
6938 2019-04-08  Tom Tromey  <tom@tromey.com>
6939
6940         * common/common-exceptions.h (exception_rethrow): Don't declare.
6941         (TRY_SJLJ): Update comment.
6942         (TRY, CATCH, END_CATCH): Remove.
6943         * common/common-exceptions.c (exception_rethrow): Remove.
6944
6945 2019-04-08  Tom Tromey  <tom@tromey.com>
6946
6947         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6948         Remove.
6949         (gdb_exception_error): Rename from
6950         gdb_exception_RETURN_MASK_ERROR.
6951         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6952         (gdb_quit_bad_alloc): Update.
6953         * aarch64-tdep.c: Update.
6954         * ada-lang.c: Update.
6955         * ada-typeprint.c: Update.
6956         * ada-valprint.c: Update.
6957         * amd64-tdep.c: Update.
6958         * arch-utils.c: Update.
6959         * break-catch-throw.c: Update.
6960         * breakpoint.c: Update.
6961         * btrace.c: Update.
6962         * c-varobj.c: Update.
6963         * cli/cli-cmds.c: Update.
6964         * cli/cli-interp.c: Update.
6965         * cli/cli-script.c: Update.
6966         * common/common-exceptions.c: Update.
6967         * common/new-op.c: Update.
6968         * common/selftest.c: Update.
6969         * compile/compile-c-symbols.c: Update.
6970         * compile/compile-cplus-symbols.c: Update.
6971         * compile/compile-object-load.c: Update.
6972         * compile/compile-object-run.c: Update.
6973         * completer.c: Update.
6974         * corelow.c: Update.
6975         * cp-abi.c: Update.
6976         * cp-support.c: Update.
6977         * cp-valprint.c: Update.
6978         * darwin-nat.c: Update.
6979         * disasm-selftests.c: Update.
6980         * dtrace-probe.c: Update.
6981         * dwarf-index-cache.c: Update.
6982         * dwarf-index-write.c: Update.
6983         * dwarf2-frame-tailcall.c: Update.
6984         * dwarf2-frame.c: Update.
6985         * dwarf2loc.c: Update.
6986         * dwarf2read.c: Update.
6987         * eval.c: Update.
6988         * event-loop.c: Update.
6989         * event-top.c: Update.
6990         * exec.c: Update.
6991         * f-valprint.c: Update.
6992         * fbsd-tdep.c: Update.
6993         * frame-unwind.c: Update.
6994         * frame.c: Update.
6995         * gdbtypes.c: Update.
6996         * gnu-v3-abi.c: Update.
6997         * guile/guile-internal.h: Update.
6998         * guile/scm-block.c: Update.
6999         * guile/scm-breakpoint.c: Update.
7000         * guile/scm-cmd.c: Update.
7001         * guile/scm-disasm.c: Update.
7002         * guile/scm-frame.c: Update.
7003         * guile/scm-lazy-string.c: Update.
7004         * guile/scm-math.c: Update.
7005         * guile/scm-param.c: Update.
7006         * guile/scm-ports.c: Update.
7007         * guile/scm-pretty-print.c: Update.
7008         * guile/scm-symbol.c: Update.
7009         * guile/scm-symtab.c: Update.
7010         * guile/scm-type.c: Update.
7011         * guile/scm-value.c: Update.
7012         * i386-linux-tdep.c: Update.
7013         * i386-tdep.c: Update.
7014         * inf-loop.c: Update.
7015         * infcall.c: Update.
7016         * infcmd.c: Update.
7017         * infrun.c: Update.
7018         * jit.c: Update.
7019         * language.c: Update.
7020         * linespec.c: Update.
7021         * linux-fork.c: Update.
7022         * linux-nat.c: Update.
7023         * linux-tdep.c: Update.
7024         * linux-thread-db.c: Update.
7025         * main.c: Update.
7026         * mi/mi-cmd-break.c: Update.
7027         * mi/mi-cmd-stack.c: Update.
7028         * mi/mi-interp.c: Update.
7029         * mi/mi-main.c: Update.
7030         * objc-lang.c: Update.
7031         * p-valprint.c: Update.
7032         * parse.c: Update.
7033         * ppc-linux-tdep.c: Update.
7034         * printcmd.c: Update.
7035         * python/py-arch.c: Update.
7036         * python/py-breakpoint.c: Update.
7037         * python/py-cmd.c: Update.
7038         * python/py-finishbreakpoint.c: Update.
7039         * python/py-frame.c: Update.
7040         * python/py-framefilter.c: Update.
7041         * python/py-gdb-readline.c: Update.
7042         * python/py-inferior.c: Update.
7043         * python/py-infthread.c: Update.
7044         * python/py-lazy-string.c: Update.
7045         * python/py-linetable.c: Update.
7046         * python/py-objfile.c: Update.
7047         * python/py-param.c: Update.
7048         * python/py-prettyprint.c: Update.
7049         * python/py-progspace.c: Update.
7050         * python/py-record-btrace.c: Update.
7051         * python/py-record.c: Update.
7052         * python/py-symbol.c: Update.
7053         * python/py-type.c: Update.
7054         * python/py-unwind.c: Update.
7055         * python/py-utils.c: Update.
7056         * python/py-value.c: Update.
7057         * python/python.c: Update.
7058         * record-btrace.c: Update.
7059         * record-full.c: Update.
7060         * remote-fileio.c: Update.
7061         * remote.c: Update.
7062         * riscv-tdep.c: Update.
7063         * rs6000-aix-tdep.c: Update.
7064         * rs6000-tdep.c: Update.
7065         * rust-exp.y: Update.
7066         * rust-lang.c: Update.
7067         * s390-tdep.c: Update.
7068         * selftest-arch.c: Update.
7069         * solib-dsbt.c: Update.
7070         * solib-frv.c: Update.
7071         * solib-spu.c: Update.
7072         * solib-svr4.c: Update.
7073         * solib.c: Update.
7074         * sparc64-linux-tdep.c: Update.
7075         * stack.c: Update.
7076         * symfile-mem.c: Update.
7077         * symmisc.c: Update.
7078         * target.c: Update.
7079         * thread.c: Update.
7080         * top.c: Update.
7081         * tracefile-tfile.c: Update.
7082         * tui/tui.c: Update.
7083         * typeprint.c: Update.
7084         * unittests/cli-utils-selftests.c: Update.
7085         * unittests/parse-connection-spec-selftests.c: Update.
7086         * valops.c: Update.
7087         * valprint.c: Update.
7088         * value.c: Update.
7089         * varobj.c: Update.
7090         * windows-nat.c: Update.
7091         * x86-linux-nat.c: Update.
7092         * xml-support.c: Update.
7093
7094 2019-04-08  Tom Tromey  <tom@tromey.com>
7095
7096         * xml-support.c: Use C++ exception handling.
7097         * x86-linux-nat.c: Use C++ exception handling.
7098         * windows-nat.c: Use C++ exception handling.
7099         * varobj.c: Use C++ exception handling.
7100         * value.c: Use C++ exception handling.
7101         * valprint.c: Use C++ exception handling.
7102         * valops.c: Use C++ exception handling.
7103         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7104         handling.
7105         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7106         * typeprint.c: Use C++ exception handling.
7107         * tui/tui.c: Use C++ exception handling.
7108         * tracefile-tfile.c: Use C++ exception handling.
7109         * top.c: Use C++ exception handling.
7110         * thread.c: Use C++ exception handling.
7111         * target.c: Use C++ exception handling.
7112         * symmisc.c: Use C++ exception handling.
7113         * symfile-mem.c: Use C++ exception handling.
7114         * stack.c: Use C++ exception handling.
7115         * sparc64-linux-tdep.c: Use C++ exception handling.
7116         * solib.c: Use C++ exception handling.
7117         * solib-svr4.c: Use C++ exception handling.
7118         * solib-spu.c: Use C++ exception handling.
7119         * solib-frv.c: Use C++ exception handling.
7120         * solib-dsbt.c: Use C++ exception handling.
7121         * selftest-arch.c: Use C++ exception handling.
7122         * s390-tdep.c: Use C++ exception handling.
7123         * rust-lang.c: Use C++ exception handling.
7124         * rust-exp.y: Use C++ exception handling.
7125         * rs6000-tdep.c: Use C++ exception handling.
7126         * rs6000-aix-tdep.c: Use C++ exception handling.
7127         * riscv-tdep.c: Use C++ exception handling.
7128         * remote.c: Use C++ exception handling.
7129         * remote-fileio.c: Use C++ exception handling.
7130         * record-full.c: Use C++ exception handling.
7131         * record-btrace.c: Use C++ exception handling.
7132         * python/python.c: Use C++ exception handling.
7133         * python/py-value.c: Use C++ exception handling.
7134         * python/py-utils.c: Use C++ exception handling.
7135         * python/py-unwind.c: Use C++ exception handling.
7136         * python/py-type.c: Use C++ exception handling.
7137         * python/py-symbol.c: Use C++ exception handling.
7138         * python/py-record.c: Use C++ exception handling.
7139         * python/py-record-btrace.c: Use C++ exception handling.
7140         * python/py-progspace.c: Use C++ exception handling.
7141         * python/py-prettyprint.c: Use C++ exception handling.
7142         * python/py-param.c: Use C++ exception handling.
7143         * python/py-objfile.c: Use C++ exception handling.
7144         * python/py-linetable.c: Use C++ exception handling.
7145         * python/py-lazy-string.c: Use C++ exception handling.
7146         * python/py-infthread.c: Use C++ exception handling.
7147         * python/py-inferior.c: Use C++ exception handling.
7148         * python/py-gdb-readline.c: Use C++ exception handling.
7149         * python/py-framefilter.c: Use C++ exception handling.
7150         * python/py-frame.c: Use C++ exception handling.
7151         * python/py-finishbreakpoint.c: Use C++ exception handling.
7152         * python/py-cmd.c: Use C++ exception handling.
7153         * python/py-breakpoint.c: Use C++ exception handling.
7154         * python/py-arch.c: Use C++ exception handling.
7155         * printcmd.c: Use C++ exception handling.
7156         * ppc-linux-tdep.c: Use C++ exception handling.
7157         * parse.c: Use C++ exception handling.
7158         * p-valprint.c: Use C++ exception handling.
7159         * objc-lang.c: Use C++ exception handling.
7160         * mi/mi-main.c: Use C++ exception handling.
7161         * mi/mi-interp.c: Use C++ exception handling.
7162         * mi/mi-cmd-stack.c: Use C++ exception handling.
7163         * mi/mi-cmd-break.c: Use C++ exception handling.
7164         * main.c: Use C++ exception handling.
7165         * linux-thread-db.c: Use C++ exception handling.
7166         * linux-tdep.c: Use C++ exception handling.
7167         * linux-nat.c: Use C++ exception handling.
7168         * linux-fork.c: Use C++ exception handling.
7169         * linespec.c: Use C++ exception handling.
7170         * language.c: Use C++ exception handling.
7171         * jit.c: Use C++ exception handling.
7172         * infrun.c: Use C++ exception handling.
7173         * infcmd.c: Use C++ exception handling.
7174         * infcall.c: Use C++ exception handling.
7175         * inf-loop.c: Use C++ exception handling.
7176         * i386-tdep.c: Use C++ exception handling.
7177         * i386-linux-tdep.c: Use C++ exception handling.
7178         * guile/scm-value.c: Use C++ exception handling.
7179         * guile/scm-type.c: Use C++ exception handling.
7180         * guile/scm-symtab.c: Use C++ exception handling.
7181         * guile/scm-symbol.c: Use C++ exception handling.
7182         * guile/scm-pretty-print.c: Use C++ exception handling.
7183         * guile/scm-ports.c: Use C++ exception handling.
7184         * guile/scm-param.c: Use C++ exception handling.
7185         * guile/scm-math.c: Use C++ exception handling.
7186         * guile/scm-lazy-string.c: Use C++ exception handling.
7187         * guile/scm-frame.c: Use C++ exception handling.
7188         * guile/scm-disasm.c: Use C++ exception handling.
7189         * guile/scm-cmd.c: Use C++ exception handling.
7190         * guile/scm-breakpoint.c: Use C++ exception handling.
7191         * guile/scm-block.c: Use C++ exception handling.
7192         * guile/guile-internal.h: Use C++ exception handling.
7193         * gnu-v3-abi.c: Use C++ exception handling.
7194         * gdbtypes.c: Use C++ exception handling.
7195         * frame.c: Use C++ exception handling.
7196         * frame-unwind.c: Use C++ exception handling.
7197         * fbsd-tdep.c: Use C++ exception handling.
7198         * f-valprint.c: Use C++ exception handling.
7199         * exec.c: Use C++ exception handling.
7200         * event-top.c: Use C++ exception handling.
7201         * event-loop.c: Use C++ exception handling.
7202         * eval.c: Use C++ exception handling.
7203         * dwarf2read.c: Use C++ exception handling.
7204         * dwarf2loc.c: Use C++ exception handling.
7205         * dwarf2-frame.c: Use C++ exception handling.
7206         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7207         * dwarf-index-write.c: Use C++ exception handling.
7208         * dwarf-index-cache.c: Use C++ exception handling.
7209         * dtrace-probe.c: Use C++ exception handling.
7210         * disasm-selftests.c: Use C++ exception handling.
7211         * darwin-nat.c: Use C++ exception handling.
7212         * cp-valprint.c: Use C++ exception handling.
7213         * cp-support.c: Use C++ exception handling.
7214         * cp-abi.c: Use C++ exception handling.
7215         * corelow.c: Use C++ exception handling.
7216         * completer.c: Use C++ exception handling.
7217         * compile/compile-object-run.c: Use C++ exception handling.
7218         * compile/compile-object-load.c: Use C++ exception handling.
7219         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7220         * compile/compile-c-symbols.c: Use C++ exception handling.
7221         * common/selftest.c: Use C++ exception handling.
7222         * common/new-op.c: Use C++ exception handling.
7223         * cli/cli-script.c: Use C++ exception handling.
7224         * cli/cli-interp.c: Use C++ exception handling.
7225         * cli/cli-cmds.c: Use C++ exception handling.
7226         * c-varobj.c: Use C++ exception handling.
7227         * btrace.c: Use C++ exception handling.
7228         * breakpoint.c: Use C++ exception handling.
7229         * break-catch-throw.c: Use C++ exception handling.
7230         * arch-utils.c: Use C++ exception handling.
7231         * amd64-tdep.c: Use C++ exception handling.
7232         * ada-valprint.c: Use C++ exception handling.
7233         * ada-typeprint.c: Use C++ exception handling.
7234         * ada-lang.c: Use C++ exception handling.
7235         * aarch64-tdep.c: Use C++ exception handling.
7236
7237 2019-04-08  Tom Tromey  <tom@tromey.com>
7238
7239         * xml-support.c (gdb_xml_parser::parse): Update.
7240         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7241         * value.c (show_convenience): Update.
7242         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7243         (test_parse_flags_qcs): Update.
7244         * thread.c (thr_try_catch_cmd): Update.
7245         * target.c (target_translate_tls_address): Update.
7246         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7247         (info_frame_command_core, frame_apply_command_count): Update.
7248         * rust-exp.y (rust_lex_exception_test): Update.
7249         * riscv-tdep.c (riscv_print_one_register_info): Update.
7250         * remote.c (remote_target::enable_btrace): Update.
7251         * record-btrace.c (record_btrace_enable_warn): Update.
7252         * python/py-utils.c (gdbpy_convert_exception): Update.
7253         * printcmd.c (do_one_display, print_variable_and_value): Update.
7254         * mi/mi-main.c (mi_print_exception): Update.
7255         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7256         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7257         * linux-nat.c (linux_nat_target::attach): Update.
7258         * linux-fork.c (class scoped_switch_fork_info): Update.
7259         * infrun.c (displaced_step_prepare): Update.
7260         * infcall.c (call_function_by_hand_dummy): Update.
7261         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7262         * gnu-v3-abi.c (print_one_vtable): Update.
7263         * frame.c (get_prev_frame_always): Update.
7264         * f-valprint.c (info_common_command_for_block): Update.
7265         * exec.c (try_open_exec_file): Update.
7266         * exceptions.c (print_exception, exception_print)
7267         (exception_fprintf, exception_print_same): Update.
7268         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7269         * dwarf-index-cache.c (index_cache::store)
7270         (index_cache::lookup_gdb_index): Update.
7271         * darwin-nat.c (maybe_cache_shell): Update.
7272         * cp-valprint.c (cp_print_value_fields): Update.
7273         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7274         (gcc_cplus_symbol_address): Update.
7275         * compile/compile-c-symbols.c (gcc_convert_symbol)
7276         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7277         * common/selftest.c: Update.
7278         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7279         a std::string.
7280         (exception_try_scope_entry, exception_try_scope_exit): Don't
7281         declare.
7282         (struct exception_try_scope): Remove.
7283         (TRY): Don't use exception_try_scope.
7284         (struct gdb_exception): Add constructor, operator=.
7285         <what>: New method.
7286         (struct gdb_exception_RETURN_MASK_ALL)
7287         (struct gdb_exception_RETURN_MASK_ERROR)
7288         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7289         (struct gdb_quit_bad_alloc): Update.
7290         * common/common-exceptions.c (exception_none): Change
7291         initializer.
7292         (struct catcher) <state, exception>: Initialize inline.
7293         <prev>: Remove member.
7294         (current_catcher): Remove.
7295         (catchers): New global.
7296         (exceptions_state_mc_init): Simplify.
7297         (catcher_pop): Remove.
7298         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7299         (try_scope_depth, exception_try_scope_entry)
7300         (exception_try_scope_exit): Remove.
7301         (throw_exception_sjlj): Update.
7302         (exception_messages, exception_messages_size): Remove.
7303         (throw_it): Simplify.
7304         (gdb_exception_sliced_copy): Remove.
7305         (throw_exception_cxx): Update.
7306         * cli/cli-script.c (script_from_file): Update.
7307         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7308         Update.
7309         * ada-valprint.c (ada_val_print): Update.
7310         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7311         (create_excep_cond_exprs): Update.
7312
7313 2019-04-08  Tom Tromey  <tom@tromey.com>
7314
7315         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7316         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7317         (TRY, CATCH, END_CATCH): Remove some definitions.
7318         * common/common-exceptions.c: Don't use GDB_XCPT.
7319         (catcher_list_size): Remove.
7320         (throw_exception, throw_it): Simplify.
7321
7322 2019-04-05  Tom Tromey  <tom@tromey.com>
7323
7324         Revert the header-sorting patch.
7325         * ft32-tdep.c: Revert.
7326         * frv-tdep.c: Revert.
7327         * frv-linux-tdep.c: Revert.
7328         * frame.c: Revert.
7329         * frame-unwind.c: Revert.
7330         * frame-base.c: Revert.
7331         * fork-child.c: Revert.
7332         * findvar.c: Revert.
7333         * findcmd.c: Revert.
7334         * filesystem.c: Revert.
7335         * filename-seen-cache.h: Revert.
7336         * filename-seen-cache.c: Revert.
7337         * fbsd-tdep.c: Revert.
7338         * fbsd-nat.h: Revert.
7339         * fbsd-nat.c: Revert.
7340         * f-valprint.c: Revert.
7341         * f-typeprint.c: Revert.
7342         * f-lang.c: Revert.
7343         * extension.h: Revert.
7344         * extension.c: Revert.
7345         * extension-priv.h: Revert.
7346         * expprint.c: Revert.
7347         * exec.h: Revert.
7348         * exec.c: Revert.
7349         * exceptions.c: Revert.
7350         * event-top.c: Revert.
7351         * event-loop.c: Revert.
7352         * eval.c: Revert.
7353         * elfread.c: Revert.
7354         * dwarf2read.h: Revert.
7355         * dwarf2read.c: Revert.
7356         * dwarf2loc.c: Revert.
7357         * dwarf2expr.h: Revert.
7358         * dwarf2expr.c: Revert.
7359         * dwarf2-frame.c: Revert.
7360         * dwarf2-frame-tailcall.c: Revert.
7361         * dwarf-index-write.h: Revert.
7362         * dwarf-index-write.c: Revert.
7363         * dwarf-index-common.c: Revert.
7364         * dwarf-index-cache.h: Revert.
7365         * dwarf-index-cache.c: Revert.
7366         * dummy-frame.c: Revert.
7367         * dtrace-probe.c: Revert.
7368         * disasm.h: Revert.
7369         * disasm.c: Revert.
7370         * disasm-selftests.c: Revert.
7371         * dictionary.c: Revert.
7372         * dicos-tdep.c: Revert.
7373         * demangle.c: Revert.
7374         * dcache.h: Revert.
7375         * dcache.c: Revert.
7376         * darwin-nat.h: Revert.
7377         * darwin-nat.c: Revert.
7378         * darwin-nat-info.c: Revert.
7379         * d-valprint.c: Revert.
7380         * d-namespace.c: Revert.
7381         * d-lang.c: Revert.
7382         * ctf.c: Revert.
7383         * csky-tdep.c: Revert.
7384         * csky-linux-tdep.c: Revert.
7385         * cris-tdep.c: Revert.
7386         * cris-linux-tdep.c: Revert.
7387         * cp-valprint.c: Revert.
7388         * cp-support.c: Revert.
7389         * cp-namespace.c: Revert.
7390         * cp-abi.c: Revert.
7391         * corelow.c: Revert.
7392         * corefile.c: Revert.
7393         * continuations.c: Revert.
7394         * completer.h: Revert.
7395         * completer.c: Revert.
7396         * complaints.c: Revert.
7397         * coffread.c: Revert.
7398         * coff-pe-read.c: Revert.
7399         * cli-out.h: Revert.
7400         * cli-out.c: Revert.
7401         * charset.c: Revert.
7402         * c-varobj.c: Revert.
7403         * c-valprint.c: Revert.
7404         * c-typeprint.c: Revert.
7405         * c-lang.c: Revert.
7406         * buildsym.c: Revert.
7407         * buildsym-legacy.c: Revert.
7408         * build-id.h: Revert.
7409         * build-id.c: Revert.
7410         * btrace.c: Revert.
7411         * bsd-uthread.c: Revert.
7412         * breakpoint.h: Revert.
7413         * breakpoint.c: Revert.
7414         * break-catch-throw.c: Revert.
7415         * break-catch-syscall.c: Revert.
7416         * break-catch-sig.c: Revert.
7417         * blockframe.c: Revert.
7418         * block.c: Revert.
7419         * bfin-tdep.c: Revert.
7420         * bfin-linux-tdep.c: Revert.
7421         * bfd-target.c: Revert.
7422         * bcache.c: Revert.
7423         * ax-general.c: Revert.
7424         * ax-gdb.h: Revert.
7425         * ax-gdb.c: Revert.
7426         * avr-tdep.c: Revert.
7427         * auxv.c: Revert.
7428         * auto-load.c: Revert.
7429         * arm-wince-tdep.c: Revert.
7430         * arm-tdep.c: Revert.
7431         * arm-symbian-tdep.c: Revert.
7432         * arm-pikeos-tdep.c: Revert.
7433         * arm-obsd-tdep.c: Revert.
7434         * arm-nbsd-tdep.c: Revert.
7435         * arm-nbsd-nat.c: Revert.
7436         * arm-linux-tdep.c: Revert.
7437         * arm-linux-nat.c: Revert.
7438         * arm-fbsd-tdep.c: Revert.
7439         * arm-fbsd-nat.c: Revert.
7440         * arm-bsd-tdep.c: Revert.
7441         * arch-utils.c: Revert.
7442         * arc-tdep.c: Revert.
7443         * arc-newlib-tdep.c: Revert.
7444         * annotate.h: Revert.
7445         * annotate.c: Revert.
7446         * amd64-windows-tdep.c: Revert.
7447         * amd64-windows-nat.c: Revert.
7448         * amd64-tdep.c: Revert.
7449         * amd64-sol2-tdep.c: Revert.
7450         * amd64-obsd-tdep.c: Revert.
7451         * amd64-obsd-nat.c: Revert.
7452         * amd64-nbsd-tdep.c: Revert.
7453         * amd64-nbsd-nat.c: Revert.
7454         * amd64-nat.c: Revert.
7455         * amd64-linux-tdep.c: Revert.
7456         * amd64-linux-nat.c: Revert.
7457         * amd64-fbsd-tdep.c: Revert.
7458         * amd64-fbsd-nat.c: Revert.
7459         * amd64-dicos-tdep.c: Revert.
7460         * amd64-darwin-tdep.c: Revert.
7461         * amd64-bsd-nat.c: Revert.
7462         * alpha-tdep.c: Revert.
7463         * alpha-obsd-tdep.c: Revert.
7464         * alpha-nbsd-tdep.c: Revert.
7465         * alpha-mdebug-tdep.c: Revert.
7466         * alpha-linux-tdep.c: Revert.
7467         * alpha-linux-nat.c: Revert.
7468         * alpha-bsd-tdep.c: Revert.
7469         * alpha-bsd-nat.c: Revert.
7470         * aix-thread.c: Revert.
7471         * agent.c: Revert.
7472         * addrmap.c: Revert.
7473         * ada-varobj.c: Revert.
7474         * ada-valprint.c: Revert.
7475         * ada-typeprint.c: Revert.
7476         * ada-tasks.c: Revert.
7477         * ada-lang.c: Revert.
7478         * aarch64-tdep.c: Revert.
7479         * aarch64-ravenscar-thread.c: Revert.
7480         * aarch64-newlib-tdep.c: Revert.
7481         * aarch64-linux-tdep.c: Revert.
7482         * aarch64-linux-nat.c: Revert.
7483         * aarch64-fbsd-tdep.c: Revert.
7484         * aarch64-fbsd-nat.c: Revert.
7485         * aarch32-linux-nat.c: Revert.
7486
7487 2019-04-05  Tom Tromey  <tom@tromey.com>
7488
7489         * ft32-tdep.c: Sort headers.
7490         * frv-tdep.c: Sort headers.
7491         * frv-linux-tdep.c: Sort headers.
7492         * frame.c: Sort headers.
7493         * frame-unwind.c: Sort headers.
7494         * frame-base.c: Sort headers.
7495         * fork-child.c: Sort headers.
7496         * findvar.c: Sort headers.
7497         * findcmd.c: Sort headers.
7498         * filesystem.c: Sort headers.
7499         * filename-seen-cache.h: Sort headers.
7500         * filename-seen-cache.c: Sort headers.
7501         * fbsd-tdep.c: Sort headers.
7502         * fbsd-nat.h: Sort headers.
7503         * fbsd-nat.c: Sort headers.
7504         * f-valprint.c: Sort headers.
7505         * f-typeprint.c: Sort headers.
7506         * f-lang.c: Sort headers.
7507         * extension.h: Sort headers.
7508         * extension.c: Sort headers.
7509         * extension-priv.h: Sort headers.
7510         * expprint.c: Sort headers.
7511         * exec.h: Sort headers.
7512         * exec.c: Sort headers.
7513         * exceptions.c: Sort headers.
7514         * event-top.c: Sort headers.
7515         * event-loop.c: Sort headers.
7516         * eval.c: Sort headers.
7517         * elfread.c: Sort headers.
7518         * dwarf2read.h: Sort headers.
7519         * dwarf2read.c: Sort headers.
7520         * dwarf2loc.c: Sort headers.
7521         * dwarf2expr.h: Sort headers.
7522         * dwarf2expr.c: Sort headers.
7523         * dwarf2-frame.c: Sort headers.
7524         * dwarf2-frame-tailcall.c: Sort headers.
7525         * dwarf-index-write.h: Sort headers.
7526         * dwarf-index-write.c: Sort headers.
7527         * dwarf-index-common.c: Sort headers.
7528         * dwarf-index-cache.h: Sort headers.
7529         * dwarf-index-cache.c: Sort headers.
7530         * dummy-frame.c: Sort headers.
7531         * dtrace-probe.c: Sort headers.
7532         * disasm.h: Sort headers.
7533         * disasm.c: Sort headers.
7534         * disasm-selftests.c: Sort headers.
7535         * dictionary.c: Sort headers.
7536         * dicos-tdep.c: Sort headers.
7537         * demangle.c: Sort headers.
7538         * dcache.h: Sort headers.
7539         * dcache.c: Sort headers.
7540         * darwin-nat.h: Sort headers.
7541         * darwin-nat.c: Sort headers.
7542         * darwin-nat-info.c: Sort headers.
7543         * d-valprint.c: Sort headers.
7544         * d-namespace.c: Sort headers.
7545         * d-lang.c: Sort headers.
7546         * ctf.c: Sort headers.
7547         * csky-tdep.c: Sort headers.
7548         * csky-linux-tdep.c: Sort headers.
7549         * cris-tdep.c: Sort headers.
7550         * cris-linux-tdep.c: Sort headers.
7551         * cp-valprint.c: Sort headers.
7552         * cp-support.c: Sort headers.
7553         * cp-namespace.c: Sort headers.
7554         * cp-abi.c: Sort headers.
7555         * corelow.c: Sort headers.
7556         * corefile.c: Sort headers.
7557         * continuations.c: Sort headers.
7558         * completer.h: Sort headers.
7559         * completer.c: Sort headers.
7560         * complaints.c: Sort headers.
7561         * coffread.c: Sort headers.
7562         * coff-pe-read.c: Sort headers.
7563         * cli-out.h: Sort headers.
7564         * cli-out.c: Sort headers.
7565         * charset.c: Sort headers.
7566         * c-varobj.c: Sort headers.
7567         * c-valprint.c: Sort headers.
7568         * c-typeprint.c: Sort headers.
7569         * c-lang.c: Sort headers.
7570         * buildsym.c: Sort headers.
7571         * buildsym-legacy.c: Sort headers.
7572         * build-id.h: Sort headers.
7573         * build-id.c: Sort headers.
7574         * btrace.c: Sort headers.
7575         * bsd-uthread.c: Sort headers.
7576         * breakpoint.h: Sort headers.
7577         * breakpoint.c: Sort headers.
7578         * break-catch-throw.c: Sort headers.
7579         * break-catch-syscall.c: Sort headers.
7580         * break-catch-sig.c: Sort headers.
7581         * blockframe.c: Sort headers.
7582         * block.c: Sort headers.
7583         * bfin-tdep.c: Sort headers.
7584         * bfin-linux-tdep.c: Sort headers.
7585         * bfd-target.c: Sort headers.
7586         * bcache.c: Sort headers.
7587         * ax-general.c: Sort headers.
7588         * ax-gdb.h: Sort headers.
7589         * ax-gdb.c: Sort headers.
7590         * avr-tdep.c: Sort headers.
7591         * auxv.c: Sort headers.
7592         * auto-load.c: Sort headers.
7593         * arm-wince-tdep.c: Sort headers.
7594         * arm-tdep.c: Sort headers.
7595         * arm-symbian-tdep.c: Sort headers.
7596         * arm-pikeos-tdep.c: Sort headers.
7597         * arm-obsd-tdep.c: Sort headers.
7598         * arm-nbsd-tdep.c: Sort headers.
7599         * arm-nbsd-nat.c: Sort headers.
7600         * arm-linux-tdep.c: Sort headers.
7601         * arm-linux-nat.c: Sort headers.
7602         * arm-fbsd-tdep.c: Sort headers.
7603         * arm-fbsd-nat.c: Sort headers.
7604         * arm-bsd-tdep.c: Sort headers.
7605         * arch-utils.c: Sort headers.
7606         * arc-tdep.c: Sort headers.
7607         * arc-newlib-tdep.c: Sort headers.
7608         * annotate.h: Sort headers.
7609         * annotate.c: Sort headers.
7610         * amd64-windows-tdep.c: Sort headers.
7611         * amd64-windows-nat.c: Sort headers.
7612         * amd64-tdep.c: Sort headers.
7613         * amd64-sol2-tdep.c: Sort headers.
7614         * amd64-obsd-tdep.c: Sort headers.
7615         * amd64-obsd-nat.c: Sort headers.
7616         * amd64-nbsd-tdep.c: Sort headers.
7617         * amd64-nbsd-nat.c: Sort headers.
7618         * amd64-nat.c: Sort headers.
7619         * amd64-linux-tdep.c: Sort headers.
7620         * amd64-linux-nat.c: Sort headers.
7621         * amd64-fbsd-tdep.c: Sort headers.
7622         * amd64-fbsd-nat.c: Sort headers.
7623         * amd64-dicos-tdep.c: Sort headers.
7624         * amd64-darwin-tdep.c: Sort headers.
7625         * amd64-bsd-nat.c: Sort headers.
7626         * alpha-tdep.c: Sort headers.
7627         * alpha-obsd-tdep.c: Sort headers.
7628         * alpha-nbsd-tdep.c: Sort headers.
7629         * alpha-mdebug-tdep.c: Sort headers.
7630         * alpha-linux-tdep.c: Sort headers.
7631         * alpha-linux-nat.c: Sort headers.
7632         * alpha-bsd-tdep.c: Sort headers.
7633         * alpha-bsd-nat.c: Sort headers.
7634         * aix-thread.c: Sort headers.
7635         * agent.c: Sort headers.
7636         * addrmap.c: Sort headers.
7637         * ada-varobj.c: Sort headers.
7638         * ada-valprint.c: Sort headers.
7639         * ada-typeprint.c: Sort headers.
7640         * ada-tasks.c: Sort headers.
7641         * ada-lang.c: Sort headers.
7642         * aarch64-tdep.c: Sort headers.
7643         * aarch64-ravenscar-thread.c: Sort headers.
7644         * aarch64-newlib-tdep.c: Sort headers.
7645         * aarch64-linux-tdep.c: Sort headers.
7646         * aarch64-linux-nat.c: Sort headers.
7647         * aarch64-fbsd-tdep.c: Sort headers.
7648         * aarch64-fbsd-nat.c: Sort headers.
7649         * aarch32-linux-nat.c: Sort headers.
7650
7651 2019-04-04  Tom Tromey  <tom@tromey.com>
7652
7653         * varobj.c (varobj_create): Update.
7654         * rust-exp.y (struct rust_parser) <update_innermost_block,
7655         lookup_symbol>: New methods.
7656         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7657         Rename.
7658         (rust_parser::rust_lookup_type)
7659         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7660         * printcmd.c (display_command, do_one_display): Update.
7661         * parser-defs.h (struct parser_state) <parser_state>: Add
7662         "tracker" parameter.
7663         (block_tracker): New member.
7664         (class innermost_block_tracker) <innermost_block_tracker>: Add
7665         "types" parameter.
7666         <reset>: Remove method.
7667         (innermost_block): Don't declare.
7668         (null_post_parser): Update.
7669         * parse.c (innermost_block): Remove global.
7670         (write_dollar_variable): Update.
7671         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7672         Remove "tracker_types" parameter.
7673         (parse_expression): Add "tracker" parameter.
7674         (parse_expression_for_completion): Update.
7675         (null_post_parser): Add "tracker" parameter.
7676         * p-exp.y: Update rules.
7677         * m2-exp.y: Update rules.
7678         * language.h (struct language_defn) <la_post_parser>: Add
7679         "tracker" parameter.
7680         * go-exp.y: Update rules.
7681         * f-exp.y: Update rules.
7682         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7683         parameter.
7684         * d-exp.y: Update rules.
7685         * c-exp.y: Update rules.
7686         * breakpoint.c (set_breakpoint_condition): Create an
7687         innermost_block_tracker.
7688         (watch_command_1): Likewise.
7689         * ada-lang.c (resolve): Add "tracker" parameter.
7690         (resolve_subexp): Likewise.
7691         * ada-exp.y (write_var_from_sym): Update.
7692
7693 2019-04-04  Tom Tromey  <tom@tromey.com>
7694
7695         * type-stack.h: New file.
7696         * type-stack.c: New file.
7697         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7698         type-stack.h.
7699         (insert_into_type_stack, insert_type, push_type, push_type_int)
7700         (insert_type_address_space, pop_type, pop_type_int)
7701         (pop_typelist, pop_type_stack, append_type_stack)
7702         (push_type_stack, get_type_stack, push_typelist)
7703         (follow_type_instance_flags, follow_types): Don't declare.
7704         * parse.c (type_stack): Remove global.
7705         (parse_exp_in_context): Update.
7706         (insert_into_type_stack, insert_type, push_type, push_type_int)
7707         (insert_type_address_space, pop_type, pop_type_int)
7708         (pop_typelist, pop_type_stack, append_type_stack)
7709         (push_type_stack, get_type_stack, push_typelist)
7710         (follow_type_instance_flags, follow_types): Remove (moved to
7711         type-stack.c).
7712         * f-exp.y (type_stack): New global.
7713         Update rules.
7714         (push_kind_type, f_parse): Update.
7715         * d-exp.y (type_stack): New global.
7716         Update rules.
7717         (d_parse): Update.
7718         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7719         Update rules.
7720         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7721         (HFILES_NO_SRCDIR): Add type-stack.h.
7722
7723 2019-04-04  Tom Tromey  <tom@tromey.com>
7724
7725         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7726         (rust_parser::convert_ast_to_expression, rust_parse)
7727         (rust_lex_test_completion, rust_lex_tests): Update.
7728         * parser-defs.h (struct expr_completion_state): New.
7729         (struct parser_state) <parser_state>: Add completion parameter.
7730         <mark_struct_expression, mark_completion_tag>: New methods.
7731         <parse_completion, m_completion_state>: New members.
7732         (prefixify_expression, null_post_parser): Update.
7733         (mark_struct_expression, mark_completion_tag): Don't declare.
7734         * parse.c (parse_completion, expout_last_struct)
7735         (expout_tag_completion_type, expout_completion_name): Remove
7736         globals.
7737         (parser_state::mark_struct_expression)
7738         (parser_state::mark_completion_tag): Now methods.
7739         (prefixify_expression): Add last_struct parameter.
7740         (prefixify_subexp): Likewise.
7741         (parse_exp_1): Update.
7742         (parse_exp_in_context): Add cstate parameter.  Update.
7743         (parse_expression_for_completion): Create an
7744         expr_completion_state.
7745         (null_post_parser): Add "completion" parameter.
7746         * p-exp.y: Update rules.
7747         (yylex): Update.
7748         * language.h (struct language_defn) <la_post_parser>: Add
7749         "completing" parameter.
7750         * go-exp.y: Update rules.
7751         (lex_one_token): Update.
7752         * expression.h (parse_completion): Don't declare.
7753         * d-exp.y: Update rules.
7754         (lex_one_token): Update rules.
7755         * c-exp.y: Update rules.
7756         (lex_one_token): Update.
7757         * ada-lang.c (resolve): Add "parse_completion" parameter.
7758         (resolve_subexp): Likewise.
7759         (ada_resolve_function): Likewise.
7760
7761 2019-04-04  Tom Tromey  <tom@tromey.com>
7762
7763         * parser-defs.h (struct parser_state) <start_arglist,
7764         end_arglist>: New methods.
7765         <arglist_len, m_funcall_chain>: New members.
7766         (arglist_len, start_arglist, end_arglist): Don't declare.
7767         * parse.c (arglist_len, funcall_chain): Remove global.
7768         (start_arglist, end_arglist): Remove functions.
7769         (parse_exp_in_context): Update.
7770         * p-exp.y: Update rules.
7771         * m2-exp.y: Update rules.
7772         * go-exp.y: Update rules.
7773         * f-exp.y: Update rules.
7774         * d-exp.y: Update rules.
7775         * c-exp.y: Update rules.
7776
7777 2019-04-04  Tom Tromey  <tom@tromey.com>
7778
7779         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7780         lex_operator, push_back>: New methods.
7781         Update all rules.
7782         (rust_parser::lex_hex, lex_escape): Rename and update.
7783         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7784         (rust_parser::lex_operator): Rename and update.
7785         (rust_parser::lex_number, rustyylex, rustyyerror)
7786         (rust_lex_test_init, rust_lex_test_sequence)
7787         (rust_lex_test_push_back, rust_lex_tests): Update.
7788         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7789         parameter.
7790         <lexptr, prev_lexptr>: New members.
7791         (lexptr, prev_lexptr): Don't declare.
7792         * parse.c (lexptr, prev_lexptr): Remove globals.
7793         (parse_exp_in_context): Update.
7794         * p-exp.y (yylex, yyerror): Update.
7795         * m2-exp.y (parse_number, yylex, yyerror): Update.
7796         * go-exp.y (lex_one_token, yyerror): Update.
7797         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7798         * d-exp.y (lex_one_token, yyerror): Update.
7799         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7800         (lex_one_token, yyerror): Update.
7801         * ada-lex.l (YY_INPUT): Update.
7802         (rewind_to_char): Update.
7803         * ada-exp.y (yyerror): Update.
7804
7805 2019-04-04  Tom Tromey  <tom@tromey.com>
7806
7807         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7808         * parser-defs.h (struct parser_state) <parser_state>: Add new
7809         parameter.
7810         <comma_terminates>: New member.
7811         (comma_terminates): Don't declare global.
7812         * parse.c (comma_terminates): Remove global.
7813         (parse_exp_in_context): Update.
7814         * p-exp.y (yylex): Update.
7815         * m2-exp.y (yylex): Update.
7816         * go-exp.y (lex_one_token): Update.
7817         * f-exp.y (yylex): Update.
7818         * d-exp.y (lex_one_token): Update.
7819         * c-exp.y (lex_one_token): Update.
7820         * ada-lex.l: Update.
7821
7822 2019-04-04  Tom Tromey  <tom@tromey.com>
7823
7824         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7825         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7826         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7827         * parser-defs.h (paren_depth): Don't declare.
7828         * parse.c (paren_depth): Remove global.
7829         (parse_exp_in_context): Update.
7830         * p-exp.y (paren_depth): New global.
7831         (pascal_parse): Initialize it.
7832         * m2-exp.y (paren_depth): New global.
7833         (m2_parse): Initialize it.
7834         * go-exp.y (paren_depth): New global.
7835         (go_parse): Initialize it.
7836         * f-exp.y (paren_depth): New global.
7837         (f_parse): Initialize it.
7838         * d-exp.y (paren_depth): New global.
7839         (d_parse): Initialize it.
7840         * c-exp.y (paren_depth): New global.
7841         (c_parse): Initialize it.
7842         * ada-lex.l (paren_depth): New global.
7843         (lexer_init): Initialize it.
7844
7845 2019-04-04  Tom Tromey  <tom@tromey.com>
7846
7847         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7848         (rust_parser::convert_ast_to_type)
7849         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7850         * parser-defs.h (struct parser_state) <parser_state>: Add
7851         parameters.  Initialize new members.
7852         <expression_context_block, expression_context_pc>: New members.
7853         * parse.c (expression_context_block, expression_context_pc):
7854         Remove globals.
7855         (parse_exp_in_context): Update.
7856         * p-exp.y: Update all rules.
7857         (yylex): Update.
7858         * m2-exp.y: Update all rules.
7859         (yylex): Update.
7860         * go-exp.y (yylex): Update.
7861         * f-exp.y (yylex): Update.
7862         * d-exp.y: Update all rules.
7863         (yylex): Update.
7864         * c-exp.y: Update all rules.
7865         (lex_one_token, classify_name, yylex, c_parse): Update.
7866         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7867
7868 2019-04-04  Tom Tromey  <tom@tromey.com>
7869
7870         * gdbarch.h, gdbarch.c: Rebuild.
7871         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7872         * stap-probe.h:
7873         (struct stap_parse_info): Replace "parser_state" with
7874         "expr_builder".
7875         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7876         (parser_state): New class.
7877         * parse.c (expr_builder): Rename.
7878         (expr_builder::release): Rename.
7879         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7880         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7881         (write_exp_elt_longcst, write_exp_elt_floatcst)
7882         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7883         (write_exp_string_vector, write_exp_bitstring)
7884         (write_exp_msymbol, mark_struct_expression)
7885         (write_dollar_variable)
7886         (insert_type_address_space, increase_expout_size): Replace
7887         "parser_state" with "expr_builder".
7888         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7889         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7890         "parser_state" with "expr_builder".
7891
7892 2019-04-04  Tom Tromey  <tom@tromey.com>
7893
7894         * rust-exp.y: Replace "parse_language" with method call.
7895         * p-exp.y:
7896         (yylex): Replace "parse_language" with method call.
7897         * m2-exp.y:
7898         (yylex): Replace "parse_language" with method call.
7899         * go-exp.y (classify_name): Replace "parse_language" with method
7900         call.
7901         * f-exp.y (yylex): Replace "parse_language" with method call.
7902         * d-exp.y (lex_one_token): Replace "parse_language" with method
7903         call.
7904         * c-exp.y:
7905         (lex_one_token, classify_name, yylex): Replace "parse_language"
7906         with method call.
7907         * ada-exp.y (find_primitive_type, type_char)
7908         (type_system_address): Replace "parse_language" with method call.
7909
7910 2019-04-04  Tom Tromey  <tom@tromey.com>
7911
7912         * rust-exp.y: Replace "parse_gdbarch" with method call.
7913         * parse.c (write_dollar_variable, insert_type_address_space):
7914         Replace "parse_gdbarch" with method call.
7915         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7916         call.
7917         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7918         call.
7919         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7920         "parse_gdbarch" with method call.
7921         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7922         with method call.
7923         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7924         "parse_gdbarch" with method call.
7925         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7926         "parse_gdbarch" with method call.
7927         * c-exp.y (parse_type, parse_number, classify_name): Replace
7928         "parse_gdbarch" with method call.
7929         * ada-lex.l: Replace "parse_gdbarch" with method call.
7930         * ada-exp.y (parse_type, find_primitive_type, type_char)
7931         (type_system_address): Replace "parse_gdbarch" with method call.
7932
7933 2019-04-04  Tom Tromey  <tom@tromey.com>
7934
7935         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7936         * stap-probe.c (stap_parse_argument): Update.
7937         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7938         initial_size parameter.
7939         * rust-exp.y (rust_lex_tests): Update.
7940         * parse.c (parser_state): Update.
7941         (parse_exp_in_context): Update.
7942         * parser-defs.h (struct parser_state) <parser_state>: Remove
7943         "initial_size" parameter.
7944
7945 2019-04-04  Tom Tromey  <tom@tromey.com>
7946
7947         * parser-defs.h (increase_expout_size): Don't declare.
7948         * parse.c (increase_expout_size): Now static.
7949
7950 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7951
7952         * gnu-nat.c (gnu_nat_target::wait): Fix
7953         target_waitstatus_to_string call.
7954
7955 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7956
7957         * eval.c (evaluate_subexp_standard): Handle internal functions
7958         during Fortran function call handling.
7959
7960 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7961
7962         * NEWS: Mention new internal functions.
7963         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7964         (read_base_type): Use dwarf2_init_complex_target_type.
7965         * value.c (creal_internal_fn): New function.
7966         (cimag_internal_fn): New function.
7967         (_initialize_values): Register new internal functions.
7968
7969 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7970
7971         * infrun.c (stop_all_threads): If debug_infrun, always
7972         trace the wait status after wait_one, using
7973         target_waitstatus_to_string and target_pid_to_str.
7974         (handle_inferior_event): Replace various trace of
7975         wait status kind by a single trace.
7976         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7977         wait status kind image by target_waitstatus_to_string.
7978         * target/waitstatus.c (target_waitstatus_to_string): Fix
7979         obsolete comment.
7980
7981 2019-04-01  Tom Tromey  <tromey@adacore.com>
7982
7983         PR symtab/23331:
7984         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7985
7986 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7987             Pedro Alves  <palves@redhat.com>
7988
7989         * top.c (quit_force): Call 'finalize_values'.
7990         * value.c (finalize_values): New function.
7991         * value.h (finalize_values): Declare.
7992
7993 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7994
7995         * NEWS: Announce $_gdb_major and $_gdb_minor.
7996
7997         * top.c (init_gdb_version_vars): New function.
7998         (gdb_init): Call init_gdb_version_vars.
7999
8000 2019-03-29  Tom Tromey  <tromey@adacore.com>
8001
8002         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8003         help text.  Remove dead code.
8004
8005 2019-03-29  Keith Seitz  <keiths@redhat.com>
8006
8007         From Siddhesh Poyarekar:
8008         * f-lang.h (f77_get_upperbound): Return LONGEST.
8009         (f77_get_lowerbound): Likewise.
8010         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8011         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8012         print them.
8013         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8014         plongest to format print it.
8015         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8016         (f77_get_upperbound): Likewise.
8017         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8018         LOWER_BOUND to LONGEST.
8019         (f77_create_arrayprint_offset_tbl): Likewise.
8020
8021 2019-03-29  Keith Seitz  <keiths@redhat.com>
8022
8023         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8024         %s/pulongest for TYPE_LENGTH instead of %d in format
8025         strings.
8026         * ada-typerint.c (ada_print_type): Likewise.
8027         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8028         * compile/compile-c-support.c (generate_register_struct): Likewise.
8029         * gdbtypes.c (recursive_dump_type): Likewise.
8030         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8031         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8032         instead of %d in format strings.
8033         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8034         to std::min to ULONGEST.
8035         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8036         instead of %d in format strings.
8037         * tracepoint.c (info_scope_command): Likewise.
8038         * typeprint.c (print_offset_data::update)
8039         (print_offset_data::finish): Likewise.
8040         * xtensa-tdep.c (xtensa_store_return_value)
8041         (xtensa_push_dummy_call): Likewise.
8042
8043 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8044
8045         * windows-nat.c (display_selector): Fixed format specifications
8046         for 64-bit Cygwin.
8047
8048 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8049
8050         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8051
8052 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8053
8054         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8055         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8056         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8057         (nios2_linux_init_abi): Install it.
8058
8059 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8060
8061         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8062
8063 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8064
8065         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8066
8067 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8068             Tom Tromey  <tromey@adacore.com>
8069
8070         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8071
8072 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8073
8074         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8075         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8076         method to compute the bounds of range types. Also print "[evaluated]"
8077         if the bounds' values come from a dynamic evaluation.
8078
8079 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8080
8081         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8082         whitespace when pretty printing is on.
8083
8084 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8085
8086         * ppc-linux-nat.c: Add include.
8087
8088 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8089
8090         * NEWS: Mention AArch64 Pointer Authentication.
8091
8092 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8093
8094         * arm-linux-nat.c: Add include.
8095
8096 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8097
8098         * source-cache.c (source_cache::get_source_lines): Re-read
8099         fullname after calling open_source_file.
8100
8101 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8102
8103         * NEWS: Mention TLS support for FreeBSD.
8104
8105 2019-03-25  Tom Tromey  <tromey@adacore.com>
8106
8107         * minsyms.c (BUNCH_SIZE): Update comment.
8108         (~minimal_symbol_reader): Remove old comment.
8109         (compact_minimal_symbols): Update comment.
8110         (minimal_symbol_reader::install): Remove old comment.  Update
8111         other comments.
8112
8113 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8114
8115         * s390-linux-nat.c: Add include.
8116
8117 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8118
8119         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8120         Call linux_get_hwcap.
8121         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8122         Likewise.
8123         (aarch64_linux_get_hwcap): Remove function.
8124         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8125         declaration.
8126         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8127         linux_get_hwcap.
8128         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8129         * linux-tdep.c (linux_get_hwcap): Add function.
8130         (linux_get_hwcap2): Likewise.
8131         * linux-tdep.h (linux_get_hwcap): Add declaration.
8132         (linux_get_hwcap2): Likewise.
8133         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8134         (ppc_linux_get_hwcap2): Likewise.
8135         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8136         linux_get_hwcap.
8137         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8138         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8139         (ppc_linux_nat_target::read_description): Likewise.
8140         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8141         * s390-linux-nat.c: Likewise.
8142         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8143
8144 2019-03-24  Tom Tromey  <tom@tromey.com>
8145
8146         * ada-lang.c (standard_lookup): Simplify initialization.
8147         (ada_lookup_symbol_nonlocal): Simplify return.
8148         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8149         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8150         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8151         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8152         initialization.
8153         * solib.c (solib_global_lookup): Simplify.
8154         * symtab.c (null_block_symbol): Remove.
8155         (symbol_cache_lookup): Simplify returns.
8156         (lookup_language_this): Simplify returns.
8157         (lookup_symbol_aux): Simplify return.
8158         (lookup_local_symbol): Simplify returns.
8159         (lookup_global_symbol_from_objfile): Simplify return.
8160         (lookup_symbol_in_objfile_symtabs)
8161         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8162         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8163         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8164         * cp-namespace.c (cp_lookup_bare_symbol)
8165         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8166         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8167         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8168         (cp_lookup_symbol_via_imports): Simplify initialization.
8169         (find_symbol_in_baseclass): Likewise.
8170         * symtab.h (null_block_symbol): Remove.
8171         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8172         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8173         (d_lookup_symbol_module): Likewise.
8174         (find_symbol_in_baseclass): Simplify initialization.
8175
8176 2019-03-24  Tom Tromey  <tom@tromey.com>
8177
8178         * expression.h: Don't include symtab.h.
8179         (struct block): Forward declare.
8180
8181 2019-03-24  Tom Tromey  <tom@tromey.com>
8182
8183         * c-exp.y (typebase): Remove casts.
8184         * gdbtypes.c (lookup_unsigned_typename, )
8185         (lookup_signed_typename): Remove cast.
8186         * eval.c (parse_to_comma_and_eval): Remove cast.
8187         * parse.c (write_dollar_variable): Remove cast.
8188         * block.h (struct block) <superblock>: Now const.
8189         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8190         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8191         (map_block): Make "block" const.
8192         * symfile.h (struct quick_symbol_functions)
8193         <map_matching_symbols>: Constify block argument to "callback".
8194         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8195         const.
8196         (find_pc_sect_compunit_symtab): Make "b" const.
8197         (find_symbol_at_address): Likewise.
8198         (search_symbols): Likewise.
8199         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8200         (dw2_debug_names_lookup_symbol): Likewise.
8201         (dw2_map_matching_symbols): Update.
8202         * p-valprint.c (pascal_val_print): Remove "block".
8203         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8204         (aux_add_nonlocal_symbols): Make "block" const.
8205         (resolve_subexp): Remove cast.
8206         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8207         const.
8208         (iterate_over_file_blocks): Likewise.
8209         * f-exp.y (%union) <bval>: Remove.
8210         * coffread.c (patch_opaque_types): Make "b" const.
8211         * spu-tdep.c (spu_catch_start): Make "block" const.
8212         * c-valprint.c (print_unpacked_pointer): Remove "block".
8213         * symmisc.c (dump_symtab_1): Make "b" const.
8214         (block_depth): Make "block" const.
8215         * d-exp.y (%union) <bval>: Remove.
8216         * cp-support.h (cp_lookup_rtti_type): Update.
8217         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8218         * psymtab.c (psym_lookup_symbol): Make "block" const.
8219         (maintenance_check_psymtabs): Make "b" const.
8220         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8221         (enumerate_locals, enumerate_args): Update.
8222         * python/py-symtab.c (stpy_global_block): Make "block" const.
8223         (stpy_static_block): Likewise.
8224         * inline-frame.c (block_starting_point_at): Make "new_block"
8225         const.
8226         * block.c (find_block_in_blockvector): Make return type const.
8227         (blockvector_for_pc_sect): Make "b" const.
8228         (find_block_in_blockvector): Make "b" const.
8229
8230 2019-03-23  Tom Tromey  <tom@tromey.com>
8231
8232         * varobj.c (varobj_create): Update.
8233         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8234         * printcmd.c (display_command, do_one_display): Don't reset
8235         innermost_block.
8236         * parser-defs.h (enum innermost_block_tracker_type): Move to
8237         expression.h.
8238         (innermost_block): Update comment.
8239         * parse.c (parse_exp_1): Add tracker_types parameter.
8240         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8241         tracker_types parameter.  Reset innermost_block.
8242         (parse_exp_in_context): Remove.
8243         (parse_expression_for_completion): Update.
8244         * objfiles.c (~objfile): Don't reset expression_context_block or
8245         innermost_block.
8246         * expression.h (enum innermost_block_tracker_type): Move from
8247         parser-defs.h.
8248         (parse_exp_1): Add tracker_types parameter.
8249         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8250         reset innermost_block.
8251
8252 2019-03-23  Tom Tromey  <tom@tromey.com>
8253
8254         * objfiles.h: Include bcache.h.
8255
8256 2019-03-23  Tom Tromey  <tom@tromey.com>
8257
8258         * linespec.c (get_current_search_block): Use
8259         scoped_restore_current_language.
8260         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8261
8262 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8263             Jiong Wang  <jiong.wang@arm.com>
8264
8265         * aarch64-linux-tdep.c
8266         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8267         section.
8268         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8269
8270 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8271             Jiong Wang  <jiong.wang@arm.com>
8272
8273         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8274         instructions.
8275         (aarch64_analyze_prologue_test): Add PACIASP test.
8276         (aarch64_prologue_prev_register): Unmask PC value.
8277
8278 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8279             Jiong Wang  <jiong.wang@arm.com>
8280
8281         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8282         (aarch64_dwarf2_prev_register): Unmask PC value.
8283         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8284         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8285         DW_CFA_AARCH64_negate_ra_state.
8286         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8287
8288 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8289             Jiong Wang  <jiong.wang@arm.com>
8290
8291         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8292         registers.
8293         (aarch64_pseudo_register_name): Likewise.
8294         (aarch64_pseudo_register_type): Likewise.
8295         (aarch64_pseudo_register_reggroup_p): Likewise.
8296         (aarch64_gdbarch_init): Add pauth registers.
8297         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8298         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8299         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8300         (struct gdbarch_tdep): Add regnum for ra_state.
8301
8302 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8303             Jiong Wang  <jiong.wang@arm.com>
8304
8305         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8306
8307 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8308             Jiong Wang  <jiong.wang@arm.com>
8309
8310         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8311         function.
8312         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8313         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8314         (aarch64_gdbarch_init): Add puth registers.
8315         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8316         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8317         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8318
8319 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8320             Jiong Wang  <jiong.wang@arm.com>
8321
8322         * aarch64-linux-nat.c
8323         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8324         * aarch64-linux-tdep.c
8325         (aarch64_linux_core_read_description): Likewise.
8326         (aarch64_linux_get_hwcap): New function.
8327         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8328         (aarch64_linux_get_hwcap): New declaration.
8329
8330 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8331             Jiong Wang  <jiong.wang@arm.com>
8332
8333         * aarch64-linux-nat.c
8334         (aarch64_linux_nat_target::read_description): Add pauth param.
8335         * aarch64-linux-tdep.c
8336         (aarch64_linux_core_read_description): Likewise.
8337         * aarch64-tdep.c (struct target_desc): Add in pauth.
8338         (aarch64_read_description): Add pauth param.
8339         (aarch64_gdbarch_init): Likewise.
8340         * aarch64-tdep.h (aarch64_read_description): Likewise.
8341         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8342         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8343         * features/Makefile: Add new files.
8344         * features/aarch64-pauth.c: New file.
8345         * features/aarch64-pauth.xml: New file.
8346
8347 2019-03-20  Tom Tromey  <tromey@adacore.com>
8348
8349         * infrun.c (handle_inferior_event): Rename from
8350         handle_inferior_event_1.  Create a scoped_value_mark.
8351         (handle_inferior_event): Remove.
8352
8353 2019-03-19  Tom Tromey  <tromey@adacore.com>
8354
8355         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8356         * infrun.h (print_stop_event): Add "displays" parameter.
8357         * infrun.c (print_stop_event): Add "displays" parameter.
8358
8359 2019-03-19  Pedro Alves  <palves@redhat.com>
8360
8361         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8362         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8363         to -1.  Fix TABs vs spaces.
8364         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8365         * tui/tui-out.h (tui_ui_out) Add intro comments.
8366         <m_line, m_start_of_line>: In-class initialize, and add describing
8367         comment.
8368
8369 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8370
8371         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8372         variable names.
8373         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8374
8375 2019-03-18  Pedro Alves  <palves@redhat.com>
8376             Eli Zaretskii <eliz@gnu.org>
8377
8378         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8379         m_line and m_start_of_line.
8380
8381 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8382
8383         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8384         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8385         it returns a newline.  This fixes a regression in TU mode, whereby
8386         the next line is output on the same screen line as the user input.
8387
8388 2019-03-18  Tom Tromey  <tromey@adacore.com>
8389
8390         * minsyms.c (minimal_symbol_reader::install): Remove call to
8391         obstack_blank.
8392
8393 2019-03-18  Pedro Alves  <palves@redhat.com>
8394
8395         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8396         New globals.
8397         (apply_style): New, factored out from ...
8398         (apply_ansi_escape): ... this.  Handle reverse video mode.
8399         (tui_set_reverse_mode): New function.
8400         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8401         * tui/tui-winsource.c (tui_show_source_line): Use
8402         tui_set_reverse_mode instead of setting A_STANDOUT.
8403         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8404         New setter methods.
8405
8406 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8407
8408         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8409         Handle tabs.
8410
8411 2019-03-18  Tom Tromey  <tromey@adacore.com>
8412
8413         * ada-lang.c (empty_array): Add "high" parameter.
8414         (ada_evaluate_subexp): Update.
8415
8416 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8417
8418         * unittests/string_view-selftests.c: Define
8419         _initialize_string_view_selftests unconditionally.
8420
8421 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8422
8423         PR gdb/24350
8424         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8425
8426 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8427
8428         PR gdb/24351
8429         * windows-nat.c (display_selector): Fix format specifiers.
8430
8431 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8432
8433         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8434         tui_refill_source_window instead of tui_refresh_win, to update the
8435         current execution line.  This fixes redisplay of the current line
8436         when stepping through the code with "next" or "step".
8437
8438 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8439
8440         * source-cache.c (source_cache::get_source_lines): Call
8441         find_source_lines to initialize s->nlines.  This fixes vertical
8442         scrolling of TUI source window when the DOWN arrow is pressed.
8443
8444 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8445
8446         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8447         linux-thread-db.c (_initialize_thread_db): Likewise.
8448
8449 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8450
8451         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8452         wclrtoeol in tui_show_source_line".  This reverts changes made in
8453         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8454
8455 2019-03-15  Tom Tromey  <tom@tromey.com>
8456
8457         * symtab.h (struct minimal_symbol): Derive from
8458         general_symbol_info.
8459         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8460         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8461         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8462         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8463         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8464         (MSYMBOL_SEARCH_NAME): Update.
8465         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8466         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8467         * minsyms.c (minimal_symbol_reader::record_full): Update.
8468
8469 2019-03-15  Tom Tromey  <tom@tromey.com>
8470
8471         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8472
8473 2019-03-15  Tom Tromey  <tom@tromey.com>
8474
8475         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8476         unique_xmalloc_ptr.
8477         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8478         Update.
8479         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8480         (build_minimal_symbol_hash_tables)
8481         (minimal_symbol_reader::install): Update.
8482
8483 2019-03-15  Tom Tromey  <tom@tromey.com>
8484
8485         * symtab.c (create_demangled_names_hash): Update.
8486         (symbol_set_names): Update.
8487         * objfiles.h (struct objfile_per_bfd_storage)
8488         <demangled_names_hash>: Now an htab_up.
8489         * objfiles.c (objfile_per_bfd_storage): Simplify.
8490
8491 2019-03-15  Tom Tromey  <tom@tromey.com>
8492
8493         * objfiles.h (struct objfile_per_bfd_storage): Declare
8494         destructor.
8495         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8496         New.
8497         (get_objfile_bfd_data): Use new.  Don't initialize
8498         language_of_main.
8499         (free_objfile_per_bfd_storage): Remove.
8500         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8501
8502 2019-03-15  Tom Tromey  <tom@tromey.com>
8503
8504         * symfile.c (reread_symbols): Update.
8505         * objfiles.c (objfile::objfile): Update.
8506         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8507         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8508         comment.
8509         (minimal_symbol_reader::install): Update.
8510         (terminate_minimal_symbol_table): Remove.
8511         * jit.c (jit_object_close_impl): Update.
8512
8513 2019-03-15  Tom Tromey  <tom@tromey.com>
8514
8515         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8516         initializations.
8517
8518 2019-03-15  Tom Tromey  <tom@tromey.com>
8519
8520         * objfiles.h (struct objfile_per_bfd_storage)
8521         <demangled_hash_languages>: Now a bitset.
8522         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8523         (lookup_minimal_symbol): Update.
8524
8525 2019-03-15  Tom Tromey  <tom@tromey.com>
8526
8527         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8528         Don't return the symbol.
8529         * coffread.c (record_minimal_symbol): Use record_full.
8530
8531 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8532
8533         The MS-Windows port of ncurses fails to switch to a color pair if
8534         one or both of the colors are the implicit default colors.  This
8535         change records the default colors when TUI is initialized, and
8536         then specifies them explicitly when a color pair uses the default
8537         colors.  This allows color styling in TUI mode on MS-Windows.
8538
8539         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8540         ncurses_norm_attr.
8541         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8542         colors in ncurses_norm_attr.
8543         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8544         "none", replace it with the default color recorded in
8545         ncurses_norm_attr.
8546
8547 2019-03-14  Tom Tromey  <tromey@adacore.com>
8548
8549         * source-cache.h (class source_cache) <get_source_lines>: Return
8550         std::string.
8551         * source-cache.c (source_cache::extract_lines): Handle case where
8552         first_pos==npos.  Return std::string.
8553         (source_cache::get_source_lines): Update.
8554
8555 2019-03-14  Tom Tromey  <tromey@adacore.com>
8556
8557         * NEWS: Add item for "style sources" commands.
8558         * source-cache.c (source_cache::get_source_lines): Check
8559         source_styling.
8560         * cli/cli-style.c (source_styling): New global.
8561         (_initialize_cli_style): Add "style sources" commands.
8562         (show_style_sources): New function.
8563         * cli/cli-style.h (source_styling): Declare.
8564
8565 2019-03-14  Pedro Alves  <palves@redhat.com>
8566             Tom Tromey  <tromey@adacore.com>
8567
8568         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8569         * tui/tui-winsource.c (tui_refill_source_window): New function,
8570         from...
8571         (tui_horizontal_source_scroll): ... here.  Move some logic.
8572         * cli/cli-style.c (set_style_enabled): Notify new observable.
8573         * tui/tui-hooks.c (tui_redisplay_source): New function.
8574         (tui_attach_detach_observers): Attach or detach
8575         tui_redisplay_source.
8576         * observable.h (source_styling_changed): New observable.
8577         * observable.c: Define source_styling_changed observable.
8578
8579 2019-03-13  Tom Tromey  <tromey@adacore.com>
8580
8581         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8582         (i386_gnu_nat_target::store_registers): Update.
8583         * target-debug.h (target_debug_print_std_string): New macro.
8584         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8585         * windows-tdep.c (display_one_tib): Update.
8586         * tui/tui-stack.c (tui_make_status_line): Update.
8587         * top.c (print_inferior_quit_action): Update.
8588         * thread.c (thr_try_catch_cmd): Update.
8589         (add_thread_with_info): Update.
8590         (thread_target_id_str): Update.
8591         (thr_try_catch_cmd): Update.
8592         (thread_command): Update.
8593         (thread_find_command): Update.
8594         * record-btrace.c (record_btrace_target::info_record)
8595         (record_btrace_resume_thread, record_btrace_target::resume)
8596         (record_btrace_cancel_resume, record_btrace_step_thread)
8597         (record_btrace_target::wait, record_btrace_target::wait)
8598         (record_btrace_target::wait, record_btrace_target::stop): Update.
8599         * progspace.c (print_program_space): Update.
8600         * process-stratum-target.c
8601         (process_stratum_target::thread_address_space): Update.
8602         * linux-fork.c (linux_fork_mourn_inferior)
8603         (detach_checkpoint_command, info_checkpoints_command)
8604         (linux_fork_context): Update.
8605         (linux_fork_detach): Update.
8606         (class scoped_switch_fork_info): Update.
8607         (delete_checkpoint_command): Update.
8608         * infrun.c (follow_fork_inferior): Update.
8609         (follow_fork_inferior): Update.
8610         (proceed_after_vfork_done): Update.
8611         (handle_vfork_child_exec_or_exit): Update.
8612         (follow_exec): Update.
8613         (displaced_step_prepare_throw): Update.
8614         (displaced_step_restore): Update.
8615         (start_step_over): Update.
8616         (resume_1): Update.
8617         (clear_proceed_status_thread): Update.
8618         (proceed): Update.
8619         (print_target_wait_results): Update.
8620         (do_target_wait): Update.
8621         (context_switch): Update.
8622         (stop_all_threads): Update.
8623         (restart_threads): Update.
8624         (finish_step_over): Update.
8625         (handle_signal_stop): Update.
8626         (switch_back_to_stepped_thread): Update.
8627         (keep_going_pass_signal): Update.
8628         (print_exited_reason): Update.
8629         (normal_stop): Update.
8630         * inferior.c (inferior_pid_to_str): Change return type.
8631         (print_selected_inferior): Update.
8632         (add_inferior): Update.
8633         (detach_inferior): Update.
8634         * dummy-frame.c (fprint_dummy_frames): Update.
8635         * dcache.c (dcache_info_1): Update.
8636         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8637         (btrace_fetch, btrace_clear): Update.
8638         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8639         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8640         type.
8641         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8642         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8643         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8644         * gdbarch.c, gdbarch.h: Rebuild.
8645         * gdbarch.sh (core_pid_to_str): Change return type.
8646         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8647         return type.
8648         (windows_nat_target::pid_to_str): Change return type.
8649         (windows_delete_thread): Update.
8650         (windows_nat_target::attach): Update.
8651         (windows_nat_target::files_info): Update.
8652         * target-delegates.c: Rebuild.
8653         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8654         return type.
8655         (sol_thread_target::pid_to_str): Change return type.
8656         * remote.c (class remote_target) <pid_to_str>: Change return
8657         type.
8658         (remote_target::pid_to_str): Change return type.
8659         (extended_remote_target::attach, remote_target::remote_stop_ns)
8660         (remote_target::remote_notif_remove_queued_reply)
8661         (remote_target::push_stop_reply, remote_target::disable_btrace):
8662         Update.
8663         (extended_remote_target::attach): Update.
8664         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8665         type.
8666         (gdbsim_target::pid_to_str): Change return type.
8667         * ravenscar-thread.c (struct ravenscar_thread_target)
8668         <pid_to_str>: Change return type.
8669         (ravenscar_thread_target::pid_to_str): Change return type.
8670         * procfs.c (class procfs_target) <pid_to_str>: Change return
8671         type.
8672         (procfs_target::pid_to_str): Change return type.
8673         (procfs_target::attach): Update.
8674         (procfs_target::detach): Update.
8675         (procfs_target::fetch_registers): Update.
8676         (procfs_target::store_registers): Update.
8677         (procfs_target::wait): Update.
8678         (procfs_target::files_info): Update.
8679         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8680         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8681         return type.
8682         (nto_procfs_target::pid_to_str): Change return type.
8683         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8684         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8685         return type.
8686         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8687         (exit_lwp): Update.
8688         (attach_proc_task_lwp_callback, get_detach_signal)
8689         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8690         (linux_nat_target::resume, wait_lwp, stop_callback)
8691         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8692         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8693         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8694         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8695         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8696         type.
8697         (inf_ptrace_target::attach): Update.
8698         (inf_ptrace_target::files_info): Update.
8699         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8700         type.
8701         (go32_nat_target::pid_to_str): Change return type.
8702         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8703         (gnu_nat_target::wait): Update.
8704         (gnu_nat_target::wait): Update.
8705         (gnu_nat_target::resume): Update.
8706         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8707         (fbsd_nat_target::wait): Update.
8708         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8709         type.
8710         (darwin_nat_target::attach): Update.
8711         * corelow.c (class core_target) <pid_to_str>: Change return type.
8712         (core_target::pid_to_str): Change return type.
8713         * target.c (normal_pid_to_str): Change return type.
8714         (default_pid_to_str): Likewise.
8715         (target_pid_to_str): Change return type.
8716         (target_translate_tls_address): Update.
8717         (target_announce_detach): Update.
8718         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8719         return type.
8720         (bsd_uthread_target::pid_to_str): Change return type.
8721         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8722         type.
8723         (bsd_kvm_target::pid_to_str): Change return type.
8724         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8725         return type.
8726         (aix_thread_target::pid_to_str): Change return type.
8727         * target.h (struct target_ops) <pid_to_str>: Change return type.
8728         (target_pid_to_str, normal_pid_to_str): Likewise.
8729         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8730         type.
8731         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8732         type.
8733         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8734         return type.
8735         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8736         type.
8737         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8738         type.
8739         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8740         return type.
8741
8742 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8743
8744         * NEWS: Mention that the new default MI version is 3.  Mention
8745         changes to the output of commands and events that deal with
8746         multi-location breakpoints.
8747         * breakpoint.c: Include "mi/mi-out.h".
8748         (print_one_breakpoint): Change output syntax if using MI version
8749         >= 3.
8750         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8751         New.
8752         (mi_multi_location_breakpoint_output_fixed): New.
8753         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8754         (mi_cmd_fix_multi_location_breakpoint_output): New.
8755         (mi_multi_location_breakpoint_output_fixed): New.
8756         * mi/mi-cmds.c (mi_cmds): Register command
8757         -fix-multi-location-breakpoint-output.
8758         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8759         interpreter "mi".
8760
8761 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8762
8763         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8764         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8765         instantiate mi_ui_out based on interpreter name.
8766         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8767         * mi/mi-main.c (mi_load_progress): Likewise.
8768
8769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8770
8771         * NEWS: Combine separate "New targets" sections for 8.3.
8772
8773 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8774
8775         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8776         (ppcfbsd_init_abi): Install gdbarch
8777         "fetch_tls_load_module_address" and "get_thread_local_address"
8778         methods.
8779
8780 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8781
8782         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8783         (riscv_fbsd_init_abi): Install gdbarch
8784         "fetch_tls_load_module_address" and "get_thread_local_address"
8785         methods.
8786
8787 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8788
8789         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8790         (i386fbsd_init_abi): Install gdbarch
8791         "fetch_tls_load_module_address" and "get_thread_local_address"
8792         methods.
8793
8794 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8795
8796         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8797         (amd64fbsd_init_abi): Install gdbarch
8798         "fetch_tls_load_module_address" and "get_thread_local_address"
8799         methods.
8800
8801 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8802
8803         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8804         (struct fbsd_pspace_data): New type.
8805         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8806         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8807         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8808         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8809         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8810
8811 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8812
8813         * gdbtypes.c (lookup_struct_elt): New function.
8814         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8815         * gdbtypes.h (struct struct_elt): New type.
8816         (lookup_struct_elt): New prototype.
8817
8818 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8819
8820         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8821         remove disabled code block.
8822
8823 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8824
8825         * gdbarch.sh (get_thread_local_address): New method.
8826         * gdbarch.h, gdbarch.c: Regenerate.
8827         * target.c (target_translate_tls_address): Use
8828         gdbarch_get_thread_local_address if present instead of
8829         target::get_thread_local_address.
8830
8831 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8832
8833         * target.h (target::get_thread_local_address): Update comment.
8834
8835 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8836
8837         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8838         objfile->separate_debug_objfile_backlink if not NULL.
8839
8840 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8841
8842         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8843         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8844         (amd64bsd_store_inferior_registers): Likewise.
8845         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8846         Enable segment base registers.
8847         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8848         PT_GETFSBASE and PT_GETGSBASE.
8849         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8850         PT_SETGSBASE.
8851         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8852         segment base registers.
8853         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8854
8855 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8856
8857         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8858         Update calls to i386_target_description to add 'segments'
8859         parameter.
8860         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8861         add segment base registers.
8862         * arch/i386.c (i386_create_target_description): Add 'segments'
8863         parameter to enable segment base registers.
8864         * arch/i386.h (i386_create_target_description): Likewise.
8865         * features/i386/32bit-segments.xml: New file.
8866         * features/i386/32bit-segments.c: Generate.
8867         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8868         call to i386_target_description to add 'segments' parameter.
8869         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8870         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8871         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8872         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8873         if feature is present.
8874         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8875         Add 'segments' parameter to call to i386_target_description.
8876         (i386_target_description): Add 'segments' parameter to enable
8877         segment base registers.
8878         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8879         to call to i386_target_description.
8880         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8881         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8882         Define I386_NUM_REGS.
8883         (i386_target_description): Add 'segments' parameter to enable
8884         segment base registers.
8885
8886 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8887
8888         PR/24325
8889         * source-cache.c: #undef open and close, to avoid unresolved
8890         externals during linking.
8891
8892 2019-03-12  Tom Tromey  <tromey@adacore.com>
8893
8894         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8895         const.  Add initializers.
8896         (_initialize_remote): Don't initialize ptid globals.
8897
8898 2019-03-12  Pedro Alves  <palves@redhat.com>
8899
8900         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8901
8902 2019-03-12  Pedro Alves  <palves@redhat.com>
8903
8904         * cp-name-parser.y (main): Remove unused 'len' variable.
8905
8906 2019-03-12  Tom Tromey  <tromey@adacore.com>
8907
8908         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8909         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8910
8911 2019-03-12  Tom Tromey  <tromey@adacore.com>
8912
8913         * linux-nat.c (iterate_over_lwps): Update.
8914         (stop_callback): Remove parameter.
8915         (stop_wait_callback, detach_callback, resume_set_callback)
8916         (select_singlestep_lwp_callback, set_ignore_sigint)
8917         (status_callback, resumed_callback, resume_clear_callback)
8918         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8919         data parameter.
8920         (linux_nat_target::detach, linux_nat_target::resume)
8921         (linux_stop_and_wait_all_lwps, select_event_lwp)
8922         (linux_nat_filter_event, linux_nat_wait_1)
8923         (linux_nat_target::kill, linux_nat_target::stop)
8924         (linux_nat_target::stop): Update.
8925         (linux_nat_resume_callback): Change type.
8926         (resume_stopped_resumed_lwps, count_events_callback)
8927         (select_event_lwp_callback): Likewise.
8928         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8929         * arm-linux-nat.c (struct update_registers_data): Remove.
8930         (update_registers_callback): Change type.
8931         (arm_linux_insert_hw_breakpoint1): Update.
8932         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8933         parameter.
8934         (x86_linux_dr_set_addr): Update.
8935         (x86_linux_dr_set_control): Update.
8936         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8937         (iterate_over_lwps): Use gdb::function_view.
8938         * nat/aarch64-linux-hw-point.c (struct
8939         aarch64_dr_update_callback_param): Remove.
8940         (debug_reg_change_callback): Change type.
8941         (aarch64_notify_debug_reg_change): Update.
8942         * s390-linux-nat.c (s390_refresh_per_info): Update.
8943
8944 2019-03-11  Tom Tromey  <tromey@adacore.com>
8945
8946         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8947         redundant assignment to "this_cu".
8948
8949 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8950
8951         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8952
8953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8954
8955         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8956         from...
8957         (rank_one_type): ... this.
8958
8959 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8960
8961         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8962         from...
8963         (rank_one_type): ... this.
8964
8965 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8966
8967         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8968         from...
8969         (rank_one_type): ... this.
8970
8971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8972
8973         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8974         from...
8975         (rank_one_type): ... this.
8976
8977 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8978
8979         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8980         from...
8981         (rank_one_type): ... this.
8982
8983 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8984
8985         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8986         from...
8987         (rank_one_type): ... this.
8988
8989 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8990
8991         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8992         from...
8993         (rank_one_type): ... this.
8994
8995 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8996
8997         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8998         from...
8999         (rank_one_type): ... this.
9000
9001 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9002
9003         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9004         from...
9005         (rank_one_type): ... this.
9006
9007 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9008
9009         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9010         from...
9011         (rank_one_type): ... this.
9012
9013 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9014
9015         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9016         from...
9017         (rank_one_type): ... this.
9018
9019 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9020
9021         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9022         from...
9023         (rank_one_type): ... this.
9024
9025 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9026
9027         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9028         inferior-events' shows the example events.
9029
9030 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9031
9032         Support styling on native MS-Windows console
9033
9034         PR/24315
9035         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9036         on MS-Windows if $TERM is not defined.
9037
9038         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9039
9040         * posix-hdep.c (gdb_console_fputs):
9041         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9042         functions.
9043         * ui-file.h (gdb_console_fputs): Add prototype.
9044
9045         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9046         back to fputs only if the former returns zero.
9047
9048 2019-03-07  Tom Tromey  <tom@tromey.com>
9049
9050         * symmisc.c (print_symbol_bcache_statistics): Update.
9051         (print_objfile_statistics): Update.
9052         * symfile.c (allocate_symtab): Update.
9053         * stabsread.c: Don't include bcache.h.
9054         * psymtab.h (struct psymbol_bcache): Don't declare.
9055         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9056         (psymbol_bcache_init, psymbol_bcache_free)
9057         (psymbol_bcache_get_bcache): Don't declare.
9058         * psymtab.c (struct psymbol_bcache): Remove.
9059         (psymtab_storage::psymtab_storage): Update.
9060         (psymtab_storage::~psymtab_storage): Update.
9061         (psymbol_bcache_init, psymbol_bcache_free)
9062         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9063         (add_psymbol_to_bcache): Update.
9064         (allocate_psymtab): Update.
9065         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9066         macro_cache>: No longer pointers.
9067         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9068         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9069         * macrotab.c (macro_bcache): Update.
9070         * macroexp.c: Don't include bcache.h.
9071         * gdbtypes.c (check_types_worklist): Update.
9072         (types_deeply_equal): Remove TRY/CATCH.  Update.
9073         * elfread.c (elf_symtab_read): Update.
9074         * dwarf2read.c: Don't include bcache.h.
9075         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9076         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9077         (print_bcache_statistics, bcache_memory_used): Don't declare.
9078         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9079         methods.  Rename all data members.
9080         * bcache.c (struct bcache): Move to bcache.h.
9081         (bcache::expand_hash_table): Rename from expand_hash_table.
9082         (bcache): Remove.
9083         (bcache::insert): Rename from bcache_full.
9084         (bcache::compare): Rename from bcache_compare.
9085         (bcache_xmalloc): Remove.
9086         (bcache::~bcache): Rename from bcache_xfree.
9087         (bcache::print_statistics): Rename from print_bcache_statistics.
9088         (bcache::memory_used): Rename from bcache_memory_used.
9089
9090 2019-03-07  Pedro Alves  <palves@redhat.com>
9091
9092         * infrun.c (normal_stop): Also check for
9093         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9094
9095 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9096
9097         * f-lang.c (value_from_host_double): Moved to...
9098         * value.c (value_from_host_double): ...here.
9099         * value.h (value_from_host_double): Declare.
9100         * guile/scm-math.c (vlscm_convert_typed_number): Use
9101         value_from_host_double.
9102         (vlscm_convert_number): Likewise.
9103         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9104         * python/py-value.c (convert_value_from_python): Likewise.
9105
9106 2019-03-06  Tom Tromey  <tom@tromey.com>
9107
9108         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9109
9110 2019-03-06  Tom Tromey  <tom@tromey.com>
9111
9112         * utils.h (free_current_contents): Don't declare.
9113         * utils.c (free_current_contents): Remove.
9114
9115 2019-03-06  Tom Tromey  <tom@tromey.com>
9116
9117         * top.c (quit_force): Update.
9118         * main.c (captured_command_loop): Update.
9119         * common/new-op.c (operator new): Update.
9120         * common/common-exceptions.c (struct catcher)
9121         <save_cleanup_chain>: Remove member.
9122         (exceptions_state_mc_init): Update.
9123         (exception_try_scope_entry): Return nullptr.
9124         (exception_try_scope_exit, exception_rethrow)
9125         (throw_exception_sjlj, throw_exception_cxx): Update.
9126         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9127         (all_cleanups, do_cleanups, discard_cleanups)
9128         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9129         (restore_cleanups, restore_final_cleanups): Don't declare.
9130         (do_final_cleanups): Remove parameter.
9131         * common/cleanups.c (cleanup_chain, make_cleanup)
9132         (make_cleanup_dtor, all_cleanups, do_cleanups)
9133         (discard_my_cleanups, discard_cleanups)
9134         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9135         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9136         (null_cleanup): Remove.
9137         (do_final_cleanups): Remove parameter.
9138
9139 2019-03-06  Tom Tromey  <tom@tromey.com>
9140
9141         * remote.c (remote_target::remote_parse_stop_reply): Use
9142         unique_xmalloc_ptr.
9143
9144 2019-03-06  Tom Tromey  <tom@tromey.com>
9145
9146         * stabsread.c (struct stabs_field_info): Rename from field_info.
9147         <list, fnlist>: Add initializers.
9148         <obstack>: New member.
9149         (read_member_functions, read_struct_fields, read_baseclasses):
9150         Allocate on obstack.  Don't use cleanups.
9151         (read_one_struct_field, read_member_functions, read_struct_fields)
9152         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9153         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9154         (read_struct_type): Update.
9155
9156 2019-03-06  Tom Tromey  <tom@tromey.com>
9157
9158         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9159         * common/filestuff.h (make_cleanup_close): Don't declare.
9160         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9161         Remove.
9162
9163 2019-03-06  Tom Tromey  <tom@tromey.com>
9164
9165         * solib-aix.c: Use make_scope_exit.
9166
9167 2019-03-06  Tom Tromey  <tom@tromey.com>
9168
9169         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9170         Use make_scope_exit.
9171
9172 2019-03-06  Tom Tromey  <tom@tromey.com>
9173
9174         * solib-svr4.c (disable_probes_interface): Remove parameter.
9175         (svr4_handle_solib_event): Use make_scope_exit.
9176
9177 2019-03-06  Tom Tromey  <tom@tromey.com>
9178
9179         * remote.c (struct stop_reply_deleter): Remove.
9180         (stop_reply_up): Update.
9181         (struct stop_reply): Derive from notif_event.  Don't typedef.
9182         <regcache>: Now a std::vector.
9183         (stop_reply_xfree): Remove.
9184         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9185         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9186         (remote_target::discard_pending_stop_replies): Use delete.
9187         (remote_target::remote_parse_stop_reply): Update.
9188         (remote_target::process_stop_reply): Update.
9189         * remote-notif.h (struct notif_event): Add virtual destructor.
9190         Remove "dtr" member.
9191         (struct notif_client) <alloc_event>: Return a unique_ptr.
9192         (notif_event_xfree): Don't declare.
9193         (notif_event_up): New typedef.
9194         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9195         (notif_event_xfree, do_notif_event_xfree): Remove.
9196         (remote_notif_state_xfree): Update.
9197
9198 2019-03-06  Tom Tromey  <tom@tromey.com>
9199
9200         * infrun.c (displaced_step_clear_cleanup): Now a
9201         forward_scope_exit type.
9202         (displaced_step_prepare_throw): Update.
9203         (displaced_step_fixup): Update.
9204
9205 2019-03-06  Tom Tromey  <tom@tromey.com>
9206
9207         * inferior.h (class inferior): Update comment.
9208         * gdbthread.h (class thread_info): Update comment.
9209
9210 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9211             Tom Tromey  <tom@tromey.com>
9212
9213         * stabsread.h (struct stab_section_list): Remove.
9214         (coffstab_build_psymtabs): Update.
9215         * dbxread.c (symbuf_sections): Now a std::vector.
9216         (sect_idx): New global.
9217         (fill_symbuf): Update.
9218         (coffstab_build_psymtabs): Change type of stabsects parameter.
9219         Update.
9220         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9221         std::vector.
9222         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9223         (coff_locate_sections): Update.
9224         (coff_symfile_read): Remove cleanups.  Update.
9225         (init_stringtab): Add storage parameter.
9226         (free_stringtab, free_stringtab_cleanup): Remove.
9227         (init_lineno): Add storage parameter.
9228         (free_linetab, free_linetab_cleanup): Remove.
9229
9230 2019-03-06  Pedro Alves  <palves@redhat.com>
9231
9232         * linux-fork.c (fork_info::clobber_regs): Delete.
9233         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9234         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9235         comment.  Adjust.
9236         (scoped_switch_fork_info::scoped_switch_fork_info)
9237         (checkpoint_command, linux_fork_context): Adjust
9238         fork_save_infrun_state calls.
9239
9240 2019-03-06  Pedro Alves  <palves@redhat.com>
9241
9242         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9243         (inf_has_multiple_threads): Return 'bool' and rewrite using
9244         inferior_info::threads().
9245
9246 2019-03-06  Pedro Alves  <palves@redhat.com>
9247
9248         * linux-fork.c: Include <list>.
9249         (fork_list): Now a std::list instance.
9250         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9251         (forks_exist_p, find_last_fork): Adjust.
9252         (new_fork): Delete.
9253         (one_fork_p): New.
9254         (add_fork): Adjust.
9255         (free_fork): Delete, folded into fork_info::~fork_info().
9256         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9257         Adjust.
9258         (init_fork_list): Delete.
9259         (linux_fork_killall, linux_fork_mourn_inferior)
9260         (linux_fork_detach, info_checkpoints_command): Adjust.
9261         (_initialize_linux_fork): No longer call init_fork_list.
9262
9263 2019-03-06  Pedro Alves  <palves@redhat.com>
9264
9265         * linux-fork.c (new_fork): New, split out of ...
9266         (add_fork): ... this.  Return void.  Move "first fork" special
9267         case from here, to ...
9268         (checkpoint_command): ... here.
9269         * linux-linux.h (add_fork): Return void.
9270
9271 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9272
9273         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9274
9275 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9276             Chris January  <chris.january@arm.com>
9277             David Lecomber  <david.lecomber@arm.com>
9278
9279         * f-exp.y: New token, UNOP_INTRINSIC.
9280         (exp): New pattern using UNOP_INTRINSIC token.
9281         (f77_keywords): Add 'abs' keyword.
9282         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9283         (value_from_host_double): New function.
9284         (evaluate_subexp_f): Support UNOP_ABS.
9285
9286 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9287
9288         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9289         types.
9290
9291 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9292
9293         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9294         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9295         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9296
9297 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9298
9299         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9300
9301 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9302             Chris January  <chris.january@arm.com>
9303
9304         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9305         * f-exp.y: Define 'KIND' token.
9306         (exp): New pattern for KIND expressions.
9307         (ptype): Handle types with a kind extension.
9308         (direct_abs_decl): Extend to spot kind extensions.
9309         (f77_keywords): Add 'kind' to the list.
9310         (push_kind_type): New function.
9311         (convert_to_kind_type): New function.
9312         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9313         * parse.c (operator_length_standard): Likewise.
9314         * parser-defs.h (enum type_pieces): Add tp_kind.
9315         * std-operator.def: Add UNOP_KIND.
9316
9317 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9318
9319         * f-exp.y (f_parse): Set yydebug.
9320
9321 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9322
9323         * f-lang.c (evaluate_subexp_f): New function.
9324         (exp_descriptor_f): New global.
9325         (f_language_defn): Use exp_descriptor_f instead of
9326         exp_descriptor_standard.
9327
9328 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9329
9330         * f-exp.y (struct token): Add comments.
9331         (dot_ops): Remove uppercase versions and the end marker.
9332         (f77_keywords): Likewise.
9333         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9334         entries in the dot_ops array are case insensitive, and use
9335         strncasecmp to compare strings.  Also some whitespace cleanup in
9336         this area.  Similar for the f77_keywords array, except entries in
9337         this list might be case sensitive.
9338
9339 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9340
9341         * f-exp.y (struct f77_boolean_val): Add comments.
9342         (boolean_values): Remove uppercase versions, and end marker.
9343         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9344         and use strncasecmp to achieve case insensitivity.  Additionally,
9345         perform whitespace cleanup around this code.
9346
9347 2019-03-06  Tom Tromey  <tromey@adacore.com>
9348
9349         * remote-sim.c (gdbsim_target_open): Use result of
9350         gdb_argv::release.
9351
9352 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9353         Dirk Schubert  <dirk.schubert@arm.com>
9354         Chris January  <chris.january@arm.com>
9355
9356         * eval.c (evaluate_subexp_standard): Call Fortran argument
9357         wrapping logic.
9358         * f-lang.c (struct value): A value which can be passed into a
9359         Fortran function call.
9360         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9361         where appropriate.
9362         (struct type): Value ready for a Fortran function call.
9363         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9364         is needed.
9365         * f-lang.h (fortran_argument_convert): Declaration.
9366         (fortran_preserve_arg_pointer): Declaration.
9367         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9368
9369 2019-03-05  Tom Tromey  <tromey@adacore.com>
9370
9371         * python/py-prettyprint.c (print_string_repr): Remove #if.
9372         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9373
9374 2019-03-05  Tom Tromey  <tromey@adacore.com>
9375
9376         * target.c (the_dummy_target): Move later.  Change type to
9377         "dummy_target".
9378         (initialize_targets): Don't initialize the_dummy_target.
9379
9380 2019-03-05  Tom Tromey  <tromey@adacore.com>
9381
9382         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9383         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9384
9385 2019-03-05  Tom Tromey  <tromey@adacore.com>
9386
9387         * windows-nat.c (windows_nat_target::attach)
9388         (windows_nat_target::detach): Don't call gdb_flush.
9389         * valprint.c (generic_val_print, val_print, val_print_string):
9390         Don't call gdb_flush.
9391         * utils.c (defaulted_query): Don't call gdb_flush.
9392         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9393         * target.c (target_announce_detach): Don't call gdb_flush.
9394         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9395         * remote.c (extended_remote_target::attach): Don't call
9396         gdb_flush.
9397         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9398         * printcmd.c (do_examine): Don't call gdb_flush.
9399         (info_display_command): Don't call gdb_flush.
9400         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9401         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9402         * memattr.c (info_mem_command): Don't call gdb_flush.
9403         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9404         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9405         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9406         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9407         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9408         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9409         (gnu_nat_target::detach): Don't call gdb_flush.
9410         * f-valprint.c (f_val_print): Don't call gdb_flush.
9411         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9412         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9413         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9414         gdb_flush.
9415         * c-valprint.c (c_val_print): Don't call gdb_flush.
9416         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9417
9418 2019-03-05  Tom Tromey  <tromey@adacore.com>
9419
9420         * varobj.c (update_dynamic_varobj_children): Update.
9421         (install_default_visualizer): Use reset, not release.
9422         * value.c (set_internalvar): Update.
9423         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9424         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9425         ATTRIBUTE_UNUSED_RESULT.
9426
9427 2019-03-05  Tom Tromey  <tromey@adacore.com>
9428
9429         * remote.c (class scoped_remote_fd) <release>: Add
9430         ATTRIBUTE_UNUSED_RESULT.
9431
9432 2019-03-05  Tom Tromey  <tromey@adacore.com>
9433
9434         * macroexp.c (struct macro_buffer) <release>: Add
9435         ATTRIBUTE_UNUSED_RESULT.
9436
9437 2019-03-05  Tom Tromey  <tromey@adacore.com>
9438
9439         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9440         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9441         ATTRIBUTE_UNUSED_RESULT.
9442
9443 2019-03-05  Tom Tromey  <tromey@adacore.com>
9444
9445         * common/scoped_fd.h (class scoped_fd) <release>: Add
9446         ATTRIBUTE_UNUSED_RESULT.
9447
9448 2019-03-05  Tom Tromey  <tromey@adacore.com>
9449
9450         * parser-defs.h (struct parser_state) <release>: Add
9451         ATTRIBUTE_UNUSED_RESULT.
9452
9453 2019-03-05  Tom Tromey  <tromey@adacore.com>
9454
9455         * utils.h (class gdb_argv) <release>: Add
9456         ATTRIBUTE_UNUSED_RESULT.
9457         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9458
9459 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9460
9461         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9462         for-loop range, to avoid compiler warnings.
9463
9464         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9465         avoid compiler warnings about unused variables.
9466
9467         * NEWS: Mention end of support for native debugging on MS-Windows
9468         before XP.
9469
9470         PR gdb/24292
9471         * common/netstuff.c:
9472         * gdbserver/gdbreplay.c
9473         * gdbserver/remote-utils.c:
9474         * ser-tcp.c:
9475         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9476         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9477         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9478         'getaddrinfo' and 'freeaddrinfo' were not available before
9479         Windows XP, and mingw.org's MinGW headers by default define
9480         _WIN32_WINNT to 0x500.
9481
9482 2019-03-01  Gary Benson <gbenson@redhat.com>
9483
9484         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9485
9486 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9487             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9488
9489         PR gdb/8527
9490         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9491         set_sigint_trap, clear_sigint_trap.
9492
9493 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9494
9495         * target.c (target_detach): Clear the regcache and the
9496         frame cache.
9497
9498 2019-02-27  Pedro Alves  <palves@redhat.com>
9499
9500         * utils.c (set_screen_size): When we cap the height/width sizes,
9501         tweak the corresponding command variable to show "unlimited":
9502
9503 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9504             Pedro Alves  <palves@redhat.com>
9505
9506         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9507         before calling rl_set_screen_size.
9508
9509 2019-02-27  Tom Tromey  <tromey@adacore.com>
9510
9511         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9512         define.
9513         * python/py-value.c: Remove Python 2.4 workaround.
9514         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9515         workaround.
9516         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9517         Python 2.4 workaround.
9518         * python/python-internal.h: Remove Python 2.4 comment.
9519         (Py_ssize_t): Don't define.
9520         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9521         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9522         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9523         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9524         * python/python.c (do_start_initialization): Remove Python 2.4
9525         workaround.
9526         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9527         (print_children): Remove Python 2.4 workaround.
9528         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9529         workaround.
9530         (CHARBUFFERPROC_NAME): Remove.
9531         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9532         Python 2.4 workaround.
9533
9534 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9535
9536         * NEWS: Note minimum Python version.
9537
9538 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9539
9540         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9541         code from these functions.  Remove corresponding ifdefs.  Use
9542         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9543         Remove gotos and target of gotos.
9544         (infpy_search_memory): Likewise.
9545
9546 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9547
9548         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9549         (hppa_gdbarch_init): Don't register deleted functions with
9550         gdbarch.
9551
9552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9553
9554         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9555         (h8300_unwind_sp): Delete.
9556         (h8300_dummy_id): Delete.
9557         (h8300_gdbarch_init): Don't register deleted functions with
9558         gdbarch.
9559
9560 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9561
9562         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9563         (ft32_unwind_pc): Delete.
9564         (ft32_unwind_sp): Delete.
9565         (ft32_gdbarch_init): Don't register deleted functions with
9566         gdbarch.
9567
9568 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9569
9570         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9571         (frv_unwind_pc): Delete.
9572         (frv_unwind_sp): Delete.
9573         (frv_gdbarch_init): Don't register deleted functions with
9574         gdbarch.
9575
9576 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9577
9578         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9579         (riscv_unwind_pc): Delete.
9580         (riscv_unwind_sp): Delete.
9581         (riscv_gdbarch_init): Don't register deleted functions with
9582         gdbarch.
9583
9584 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9585
9586         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9587         (csky_unwind_pc): Delete.
9588         (csky_unwind_sp): Delete.
9589         (csky_gdbarch_init): Don't register deleted functions with
9590         gdbarch.
9591
9592 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9593
9594         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9595         (cris_unwind_pc): Delete.
9596         (cris_unwind_sp): Delete.
9597         (cris_gdbarch_init): Don't register deleted functions with
9598         gdbarch.
9599
9600 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9601
9602         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9603         (bfin_unwind_pc): Delete.
9604         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9605
9606 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9607
9608         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9609         (arm_unwind_pc): Delete.
9610         (arm_unwind_sp): Delete.
9611         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9612
9613 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9614
9615         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9616         (arc_unwind_pc): Delete.
9617         (arc_unwind_sp): Delete.
9618         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9619
9620 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9621
9622         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9623         (alpha_unwind_pc): Delete.
9624         (alpha_gdbarch_init): Don't register deleted functions with
9625         gdbarch.
9626
9627 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9628
9629         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9630         (aarch64_unwind_pc): Delete.
9631         (aarch64_unwind_sp): Delete.
9632         (aarch64_gdbarch_init): Don't register deleted functions with
9633         gdbarch.
9634
9635 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9636
9637         * gdbtypes.c (type_align): Don't consider static members when
9638         computing structure alignment.
9639
9640 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9641
9642         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9643         return 0 for other types.
9644         * arch-utils.c (default_type_align): Always return 0.
9645         * gdbarch.h: Regenerate.
9646         * gdbarch.sh (type_align): Extend comment.
9647         * gdbtypes.c (type_align): Add additional comments, always call
9648         gdbarch_type_align before applying the default rules.
9649         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9650         generic code will then apply a suitable default.
9651         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9652         types, return 0 for other types.
9653
9654 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9655
9656         * NEWS: Create a new section for the next release branch.
9657         Rename the section of the current branch, now that it has
9658         been cut.
9659
9660 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9661
9662         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9663         * version.in: Bump version to 8.3.50.DATE-git.
9664
9665 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9666
9667         * aix-thread.c (ptid_cmp): Remove unused variable.
9668         (get_signaled_thread): Likewise.
9669         (store_regs_user_thread): Likewise.
9670         (store_regs_kernel_thread): Likewise.
9671         (fetch_regs_kernel_thread): Remove shadowed variable.
9672
9673 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9674
9675         * features/riscv/32bit-cpu.xml: Add register numbers.
9676         * features/riscv/32bit-fpu.c: Regenerate.
9677         * features/riscv/32bit-fpu.xml: Add register numbers.
9678         * features/riscv/64bit-cpu.xml: Add register numbers.
9679         * features/riscv/64bit-fpu.c: Regenerate.
9680         * features/riscv/64bit-fpu.xml: Add register numbers.
9681
9682 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9683
9684         * NEWS: Mention two argument form of gdb.Value constructor.
9685         * python/py-value.c (convert_buffer_and_type_to_value): New
9686         function.
9687         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9688         Add support for handling an optional second argument.  Call
9689         convert_buffer_and_type_to_value as appropriate.
9690         * python/python-internal.h (Py_buffer_deleter): New struct.
9691         (Py_buffer_up): New typedef.
9692
9693 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9694
9695         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9696         instead of releasing ownership.
9697
9698 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9699
9700         * dwarf2read.c (open_and_init_dwp_file): Call
9701         elf_numsections instead of bfd_count_sections to initialize
9702         dwp_file->num_sections.
9703
9704 2019-02-25  Tom Tromey  <tromey@adacore.com>
9705
9706         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9707
9708 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9709
9710         * gcore.in: Add '--readnever' option when invoking GDB.
9711
9712 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9713
9714         * MAINTAINERS: Update my email address.
9715
9716 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9717
9718         * build-id.c (build_id_to_debug_bfd_1): New function.
9719         (build_id_to_debug_bfd): Look for separate debug file in
9720         sysroot.
9721
9722 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9723
9724         * gdbarch.sh: Update the copyright year range that is placed into
9725         generated files.
9726
9727 2019-02-22  Keith Seitz  <keiths@redhat.com>
9728
9729         PR symtab/23853
9730         * linespec.c (create_sals_line_offset): Search for the default
9731         symtab's filename instead of its fullname.
9732
9733 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9734
9735         * NEWS: Update style defaults.
9736
9737 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9738
9739         * main.c (captured_main_1): Disable styling in batch mode.
9740
9741 2019-02-20  Tom Tromey  <tom@tromey.com>
9742
9743         * symtab.c (symtab_symbol_info): Fix typos.
9744
9745 2019-02-20  Tom Tromey  <tromey@adacore.com>
9746
9747         * findcmd.c (_initialize_mem_search): Use upper case for
9748         metasyntactic variables.
9749
9750 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9751
9752         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9753         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9754
9755 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9756
9757         * top.h (source_file_name): Change to std::string.
9758         * top.c (source_file_name): Likewise.
9759         (command_line_input): Adjust.
9760         * cli/cli-script.c (script_from_file): Adjust.
9761
9762 2019-02-19  Tom Tromey  <tromey@adacore.com>
9763
9764         * ravenscar-thread.c
9765         (ravenscar_thread_target::update_thread_list): Don't call
9766         ada_build_task_list.
9767         * ada-lang.h (ada_build_task_list): Don't declare.
9768         * ada-tasks.c (struct ada_tasks_inferior_data)
9769         <task_list_valid_p>: Now bool.
9770         (read_known_tasks, ada_task_list_changed)
9771         (ada_tasks_invalidate_inferior_data): Update.
9772         (read_known_tasks_array): Return bool.
9773         (read_known_tasks_list): Likewise.
9774         (read_known_tasks): Return void.
9775         (ada_build_task_list): Now static.
9776
9777 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9778
9779         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9780         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9781
9782 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9783
9784         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9785         variant for ada_tasks_pspace_data_handle and
9786         ada_tasks_inferior_data_handle.
9787         (ada_tasks_pspace_data_cleanup): New function.
9788         (ada_tasks_inferior_data_cleanup): New function.
9789
9790 2019-02-17  Tom Tromey  <tom@tromey.com>
9791
9792         * macrotab.h (macro_source_fullname): Return a std::string.
9793         * macrotab.c (macro_include, check_for_redefinition)
9794         (macro_undef, macro_lookup_definition, foreach_macro)
9795         (foreach_macro_in_scope): Update.
9796         (macro_source_fullname): Return a std::string.
9797         * macrocmd.c (show_pp_source_pos): Update.
9798
9799 2019-02-17  Tom Tromey  <tom@tromey.com>
9800
9801         * macrocmd.c (show_pp_source_pos): Style the file names.
9802
9803 2019-02-17  Tom Tromey  <tom@tromey.com>
9804
9805         PR tui/24197:
9806         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9807
9808 2019-02-17  Tom Tromey  <tom@tromey.com>
9809
9810         * ada-lang.c (user_select_syms): Use filtered printing.
9811         * utils.c (wrap_style): New global.
9812         (desired_style): Remove.
9813         (emit_style_escape): Add stream parameter.
9814         (set_output_style, reset_terminal_style, prompt_for_continue):
9815         Update.
9816         (flush_wrap_buffer): Only flush gdb_stdout.
9817         (wrap_here): Set wrap_style.
9818         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9819         treat escape sequences as a character.  Change when wrap buffer is
9820         flushed.
9821         (fputs_styled): Do not set the output style when the default is
9822         requested.
9823         * ui-style.h (struct ui_file_style) <is_default>: New method.
9824         * source.c (print_source_lines_base): Emit escape sequences in one
9825         piece.
9826
9827 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9828
9829         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9830         integers and enumeration types.
9831
9832 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9833
9834         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9835         instead of lookup_symbol_in_language
9836         (do_exact_match): New function.
9837         (ada_get_symbol_name_matcher): Return do_exact_match when
9838         doing a verbatim match.
9839
9840 2019-02-15  Tom Tromey  <tromey@adacore.com>
9841
9842         * ravenscar-thread.c (ravenscar_thread_target::resume)
9843         (ravenscar_thread_target::wait): Special case wildcard requests.
9844
9845 2019-02-15  Tom Tromey  <tromey@adacore.com>
9846
9847         * ravenscar-thread.c (base_ptid): Remove.
9848         (struct ravenscar_thread_target) <close>: New method.
9849         <m_base_ptid>: New member.
9850         <update_inferior_ptid, active_task, task_is_currently_active,
9851         runtime_initialized>: Declare methods.
9852         <ravenscar_thread_target>: Add constructor.
9853         (ravenscar_thread_target::task_is_currently_active)
9854         (ravenscar_thread_target::update_inferior_ptid)
9855         (ravenscar_runtime_initialized): Rename.  Now methods.
9856         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9857         (ravenscar_thread_target::update_thread_list): Update.
9858         (ravenscar_thread_target::active_task): Now method.
9859         (ravenscar_thread_target::store_registers)
9860         (ravenscar_thread_target::prepare_to_store)
9861         (ravenscar_thread_target::prepare_to_store)
9862         (ravenscar_thread_target::mourn_inferior): Update.
9863         (ravenscar_inferior_created): Use "new" to create target.
9864         (ravenscar_thread_target::get_ada_task_ptid): Update.
9865         (_initialize_ravenscar): Don't initialize base_ptid.
9866         (ravenscar_ops): Remove global.
9867
9868 2019-02-15  Tom Tromey  <tromey@adacore.com>
9869
9870         * target.h (push_target): Declare new overload.
9871         * target.c (push_target): New overload, taking an rvalue reference.
9872         * remote.c (remote_target::open_1): Use push_target overload.
9873         * corelow.c (core_target_open): Use push_target overload.
9874
9875 2019-02-15  Tom Tromey  <tromey@adacore.com>
9876
9877         * ravenscar-thread.c (is_ravenscar_task)
9878         (ravenscar_task_is_currently_active): Return bool.
9879         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9880         (_initialize_ravenscar): Remove "(void)".
9881         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9882         Return bool.
9883
9884 2019-02-15  Tom Tromey  <tromey@adacore.com>
9885
9886         * ravenscar-thread.c (ravenscar_runtime_initializer)
9887         (has_ravenscar_runtime, get_running_thread_id)
9888         (ravenscar_thread_target::resume): Fix indentation.
9889
9890 2019-02-15  Tom Tromey  <tromey@adacore.com>
9891
9892         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9893         from ravenscar_arch_ops.
9894         (sparc_ravenscar_ops::fetch_registers)
9895         (sparc_ravenscar_ops::store_registers): Now methods.
9896         (sparc_ravenscar_prepare_to_store): Remove.
9897         (sparc_ravenscar_ops): Redefine.
9898         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9899         methods and destructor.  Remove members.
9900         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9901         (ravenscar_thread_target::store_registers)
9902         (ravenscar_thread_target::prepare_to_store): Update.
9903         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9904         Remove.
9905         (struct ppc_ravenscar_powerpc_ops): Derive from
9906         ravenscar_arch_ops.
9907         (ppc_ravenscar_powerpc_ops::fetch_registers)
9908         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9909         (ppc_ravenscar_powerpc_ops): Redefine.
9910         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9911         (ppc_ravenscar_e500_ops::fetch_registers)
9912         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9913         (ppc_ravenscar_e500_ops): Redefine.
9914         * aarch64-ravenscar-thread.c
9915         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9916         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9917         (aarch64_ravenscar_fetch_registers)
9918         (aarch64_ravenscar_store_registers): Now methods.
9919         (aarch64_ravenscar_ops): Redefine.
9920
9921 2019-02-15  Tom Tromey  <tromey@adacore.com>
9922
9923         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9924         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9925         (ravenscar_thread_target::stopped_by_watchpoint)
9926         (ravenscar_thread_target::stopped_data_address)
9927         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9928
9929 2019-02-15  Tom Tromey  <tromey@adacore.com>
9930
9931         * ravenscar-thread.c: Fix some typos.
9932
9933 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9934             Tom Tromey  <tromey@adacore.com>
9935
9936         * ada-lang.c (ada_exception_sal): Change addr_string to a
9937         std::string.
9938         (create_ada_exception_catchpoint): Update.
9939
9940 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9941             Tom Tromey  <tromey@adacore.com>
9942
9943         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9944         (bp_location_ops): Remove.
9945         (base_breakpoint_allocate_location): Update.
9946         (free_bp_location): Update.
9947         * ada-lang.c (class ada_catchpoint_location)
9948         <ada_catchpoint_location>: Remove ops parameter.
9949         (ada_catchpoint_location_dtor): Remove.
9950         (ada_catchpoint_location_ops): Remove.
9951         (allocate_location_exception): Update.
9952         * breakpoint.h (struct bp_location_ops): Remove.
9953         (class bp_location) <bp_location>: Remove bp_location_ops
9954         parameter.
9955         <~bp_location>: Add destructor.
9956         <ops>: Remove.
9957
9958 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9959             Pedro Alves  <palves@redhat.com>
9960
9961         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9962         'PATH_MAX'.
9963
9964 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9965             Samuel Thibault  <samuel.thibault@gnu.org>
9966             Thomas Schwinge  <thomas@codesourcery.com>
9967
9968         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9969         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9970
9971 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9972
9973         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9974         (check_empty): Use "const char *".
9975
9976         * gnu-nat.c (gnu_nat_target::detach): Instead of
9977         'detach_inferior (pid)' call
9978         'detach_inferior (find_inferior_pid (pid))'.
9979
9980         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9981         'nat/fork-inferior.o'.
9982         * gnu-nat.c: #include "nat/fork-inferior.h".
9983
9984         * gnu-nat.c (gnu_nat_target::detach): Instead of
9985         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9986         * gnu-nat.h: #include "inf-child.h".
9987         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9988         'i386_gnu_nat_target::fetch_registers'.
9989         (gnu_store_registers): Rename/move to
9990         'i386_gnu_nat_target::store_registers'.
9991
9992         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9993         * gnu-nat.h (mach_thread_info): New function.
9994         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9995
9996         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9997
9998 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9999
10000         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10001
10002 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10003
10004         * windows-nat.c (windows_add_thread): Add new parameter
10005         "main_thread_p" with default value set to false.  Update
10006         function documentation as well as all callers.
10007         (windows_delete_thread): Likewise.
10008         (fake_create_process): Update call to windows_add_thread.
10009         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10010         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10011         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10012         call to windows_delete_thread.
10013
10014 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10015
10016         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10017
10018 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10019
10020         * symfile.c (find_separate_debug_file): Use canonical path of
10021         sysroot with child_path instead of gdb_sysroot if it is valid.
10022
10023 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10024
10025         * symfile.c (find_separate_debug_file): Use child_path to
10026         determine if an object file is under a sysroot.
10027
10028 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10029
10030         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10031         unittests/child-path-selftests.c.
10032         * common/pathstuff.c (child_path): New function.
10033         * common/pathstuff.h (child_path): New prototype.
10034         * unittests/child-path-selftests.c: New file.
10035
10036 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10037
10038         * symfile.c (find_separate_debug_file): Look for separate debug
10039         files in debug directories under the sysroot.
10040
10041 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10042
10043         * symtab.h (struct minimal_symbol data_p): New const method.
10044         (struct minimal_symbol text_p): Likewise.
10045         * symtab.c (output_source_filename): Use file name style
10046         to print file name.
10047         (print_symbol_info): Likewise.
10048         (print_msymbol_info): Use address style to print addresses.
10049         Use function name style to print executable text symbols.
10050         (expand_symtab_containing_pc): Use data_p.
10051         (find_pc_sect_compunit_symtab): Likewise.
10052
10053 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10054
10055         * breakpoint.c (describe_other_breakpoints): Use address style
10056         to print addresses.
10057         (say_where): Likewise.
10058
10059 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10060
10061         * ada-typeprint.c (print_func_type): Print function name
10062         style to print function name.
10063         * c-typeprint.c (c_print_type_1): Likewise.
10064
10065 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10066
10067         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10068         for execve.
10069
10070 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10071
10072         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10073         type_stack.
10074
10075 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10076
10077         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10078         TYPE_CODE_REF types.
10079
10080 2019-02-08  Jim Wilson  <jimw@sifive.com>
10081
10082         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10083         (riscv_linux_fregset): New.
10084         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10085
10086 2019-02-07  Tom Tromey  <tom@tromey.com>
10087
10088         * thread.c (thread_cancel_execution_command): Update.
10089         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10090         methods.
10091         (struct thread_fsm_ops): Remove.
10092         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10093         (thread_fsm_should_stop, thread_fsm_return_value)
10094         (thread_fsm_set_finished, thread_fsm_finished_p)
10095         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10096         Don't declare.
10097         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10098         * infrun.c (clear_proceed_status_thread)
10099         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10100         (print_stop_event): Update.
10101         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10102         Add constructor.
10103         (step_command_fsm_ops): Remove.
10104         (new_step_command_fsm): Remove.
10105         (step_1): Update.
10106         (step_command_fsm::should_stop): Rename from
10107         step_command_fsm_should_stop.
10108         (step_command_fsm::clean_up): Rename from
10109         step_command_fsm_clean_up.
10110         (step_command_fsm::do_async_reply_reason): Rename from
10111         step_command_fsm_async_reply_reason.
10112         (struct until_next_fsm): Inherit from thread_fsm.  Add
10113         constructor.
10114         (until_next_fsm_ops): Remove.
10115         (new_until_next_fsm): Remove.
10116         (until_next_fsm::should_stop): Rename from
10117         until_next_fsm_should_stop.
10118         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10119         (until_next_fsm::do_async_reply_reason): Rename from
10120         until_next_fsm_async_reply_reason.
10121         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10122         constructor.  Change type of breakpoint.
10123         (finish_command_fsm_ops): Remove.
10124         (new_finish_command_fsm): Remove.
10125         (finish_command_fsm::should_stop): Rename from
10126         finish_command_fsm_should_stop.
10127         (finish_command_fsm::clean_up): Rename from
10128         finish_command_fsm_clean_up.
10129         (finish_command_fsm::return_value): Rename from
10130         finish_command_fsm_return_value.
10131         (finish_command_fsm::do_async_reply_reason): Rename from
10132         finish_command_fsm_async_reply_reason.
10133         (finish_command): Update.
10134         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10135         Add constructor.
10136         (call_thread_fsm_ops): Remove.
10137         (call_thread_fsm::call_thread_fsm): Rename from
10138         new_call_thread_fsm.
10139         (call_thread_fsm::should_stop): Rename from
10140         call_thread_fsm_should_stop.
10141         (call_thread_fsm::should_notify_stop): Rename from
10142         call_thread_fsm_should_notify_stop.
10143         (run_inferior_call, call_function_by_hand_dummy): Update.
10144         * cli/cli-interp.c (should_print_stop_to_console): Update.
10145         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10146         Add constructor.  Change type of location_breakpoint,
10147         caller_breakpoint.
10148         (until_break_fsm_ops): Remove.
10149         (new_until_break_fsm): Remove.
10150         (until_break_fsm::should_stop): Rename from
10151         until_break_fsm_should_stop.
10152         (until_break_fsm::clean_up): Rename from
10153         until_break_fsm_clean_up.
10154         (until_break_fsm::do_async_reply_reason): Rename from
10155         until_break_fsm_async_reply_reason.
10156         (until_break_command): Update.
10157         * thread-fsm.c: Remove.
10158         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10159
10160 2019-02-07  Tom Tromey  <tom@tromey.com>
10161
10162         * yy-remap.h: Add include guard.
10163         * xtensa-tdep.h: Add include guard.
10164         * xcoffread.h: Rename include guard.
10165         * varobj-iter.h: Add include guard.
10166         * tui/tui.h: Rename include guard.
10167         * tui/tui-winsource.h: Rename include guard.
10168         * tui/tui-wingeneral.h: Rename include guard.
10169         * tui/tui-windata.h: Rename include guard.
10170         * tui/tui-win.h: Rename include guard.
10171         * tui/tui-stack.h: Rename include guard.
10172         * tui/tui-source.h: Rename include guard.
10173         * tui/tui-regs.h: Rename include guard.
10174         * tui/tui-out.h: Rename include guard.
10175         * tui/tui-layout.h: Rename include guard.
10176         * tui/tui-io.h: Rename include guard.
10177         * tui/tui-hooks.h: Rename include guard.
10178         * tui/tui-file.h: Rename include guard.
10179         * tui/tui-disasm.h: Rename include guard.
10180         * tui/tui-data.h: Rename include guard.
10181         * tui/tui-command.h: Rename include guard.
10182         * tic6x-tdep.h: Add include guard.
10183         * target/waitstatus.h: Rename include guard.
10184         * target/wait.h: Rename include guard.
10185         * target/target.h: Rename include guard.
10186         * target/resume.h: Rename include guard.
10187         * target-float.h: Rename include guard.
10188         * stabsread.h: Add include guard.
10189         * rs6000-tdep.h: Add include guard.
10190         * riscv-fbsd-tdep.h: Add include guard.
10191         * regformats/regdef.h: Rename include guard.
10192         * record.h: Rename include guard.
10193         * python/python.h: Rename include guard.
10194         * python/python-internal.h: Rename include guard.
10195         * python/py-stopevent.h: Rename include guard.
10196         * python/py-ref.h: Rename include guard.
10197         * python/py-record.h: Rename include guard.
10198         * python/py-record-full.h: Rename include guard.
10199         * python/py-record-btrace.h: Rename include guard.
10200         * python/py-instruction.h: Rename include guard.
10201         * python/py-events.h: Rename include guard.
10202         * python/py-event.h: Rename include guard.
10203         * procfs.h: Add include guard.
10204         * proc-utils.h: Add include guard.
10205         * p-lang.h: Add include guard.
10206         * or1k-tdep.h: Rename include guard.
10207         * observable.h: Rename include guard.
10208         * nto-tdep.h: Rename include guard.
10209         * nat/x86-linux.h: Rename include guard.
10210         * nat/x86-linux-dregs.h: Rename include guard.
10211         * nat/x86-gcc-cpuid.h: Add include guard.
10212         * nat/x86-dregs.h: Rename include guard.
10213         * nat/x86-cpuid.h: Rename include guard.
10214         * nat/ppc-linux.h: Rename include guard.
10215         * nat/mips-linux-watch.h: Rename include guard.
10216         * nat/linux-waitpid.h: Rename include guard.
10217         * nat/linux-ptrace.h: Rename include guard.
10218         * nat/linux-procfs.h: Rename include guard.
10219         * nat/linux-osdata.h: Rename include guard.
10220         * nat/linux-nat.h: Rename include guard.
10221         * nat/linux-namespaces.h: Rename include guard.
10222         * nat/linux-btrace.h: Rename include guard.
10223         * nat/glibc_thread_db.h: Rename include guard.
10224         * nat/gdb_thread_db.h: Rename include guard.
10225         * nat/gdb_ptrace.h: Rename include guard.
10226         * nat/fork-inferior.h: Rename include guard.
10227         * nat/amd64-linux-siginfo.h: Rename include guard.
10228         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10229         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10230         * nat/aarch64-linux.h: Rename include guard.
10231         * nat/aarch64-linux-hw-point.h: Rename include guard.
10232         * mn10300-tdep.h: Add include guard.
10233         * mips-linux-tdep.h: Add include guard.
10234         * mi/mi-parse.h: Rename include guard.
10235         * mi/mi-out.h: Rename include guard.
10236         * mi/mi-main.h: Rename include guard.
10237         * mi/mi-interp.h: Rename include guard.
10238         * mi/mi-getopt.h: Rename include guard.
10239         * mi/mi-console.h: Rename include guard.
10240         * mi/mi-common.h: Rename include guard.
10241         * mi/mi-cmds.h: Rename include guard.
10242         * mi/mi-cmd-break.h: Rename include guard.
10243         * m2-lang.h: Add include guard.
10244         * location.h: Rename include guard.
10245         * linux-record.h: Rename include guard.
10246         * linux-nat.h: Add include guard.
10247         * linux-fork.h: Add include guard.
10248         * i386-darwin-tdep.h: Rename include guard.
10249         * hppa-linux-offsets.h: Add include guard.
10250         * guile/guile.h: Rename include guard.
10251         * guile/guile-internal.h: Rename include guard.
10252         * gnu-nat.h: Rename include guard.
10253         * gdb-stabs.h: Rename include guard.
10254         * frv-tdep.h: Add include guard.
10255         * f-lang.h: Add include guard.
10256         * event-loop.h: Add include guard.
10257         * darwin-nat.h: Rename include guard.
10258         * cp-abi.h: Rename include guard.
10259         * config/sparc/nm-sol2.h: Rename include guard.
10260         * config/nm-nto.h: Rename include guard.
10261         * config/nm-linux.h: Add include guard.
10262         * config/i386/nm-i386gnu.h: Rename include guard.
10263         * config/djgpp/nl_types.h: Rename include guard.
10264         * config/djgpp/langinfo.h: Rename include guard.
10265         * compile/gcc-cp-plugin.h: Add include guard.
10266         * compile/gcc-c-plugin.h: Add include guard.
10267         * compile/compile.h: Rename include guard.
10268         * compile/compile-object-run.h: Rename include guard.
10269         * compile/compile-object-load.h: Rename include guard.
10270         * compile/compile-internal.h: Rename include guard.
10271         * compile/compile-cplus.h: Rename include guard.
10272         * compile/compile-c.h: Rename include guard.
10273         * common/xml-utils.h: Rename include guard.
10274         * common/x86-xstate.h: Rename include guard.
10275         * common/version.h: Rename include guard.
10276         * common/vec.h: Rename include guard.
10277         * common/tdesc.h: Rename include guard.
10278         * common/selftest.h: Rename include guard.
10279         * common/scoped_restore.h: Rename include guard.
10280         * common/scoped_mmap.h: Rename include guard.
10281         * common/scoped_fd.h: Rename include guard.
10282         * common/safe-iterator.h: Rename include guard.
10283         * common/run-time-clock.h: Rename include guard.
10284         * common/refcounted-object.h: Rename include guard.
10285         * common/queue.h: Rename include guard.
10286         * common/ptid.h: Rename include guard.
10287         * common/print-utils.h: Rename include guard.
10288         * common/preprocessor.h: Rename include guard.
10289         * common/pathstuff.h: Rename include guard.
10290         * common/observable.h: Rename include guard.
10291         * common/netstuff.h: Rename include guard.
10292         * common/job-control.h: Rename include guard.
10293         * common/host-defs.h: Rename include guard.
10294         * common/gdb_wait.h: Rename include guard.
10295         * common/gdb_vecs.h: Rename include guard.
10296         * common/gdb_unlinker.h: Rename include guard.
10297         * common/gdb_unique_ptr.h: Rename include guard.
10298         * common/gdb_tilde_expand.h: Rename include guard.
10299         * common/gdb_sys_time.h: Rename include guard.
10300         * common/gdb_string_view.h: Rename include guard.
10301         * common/gdb_splay_tree.h: Rename include guard.
10302         * common/gdb_setjmp.h: Rename include guard.
10303         * common/gdb_ref_ptr.h: Rename include guard.
10304         * common/gdb_optional.h: Rename include guard.
10305         * common/gdb_locale.h: Rename include guard.
10306         * common/gdb_assert.h: Rename include guard.
10307         * common/filtered-iterator.h: Rename include guard.
10308         * common/filestuff.h: Rename include guard.
10309         * common/fileio.h: Rename include guard.
10310         * common/environ.h: Rename include guard.
10311         * common/common-utils.h: Rename include guard.
10312         * common/common-types.h: Rename include guard.
10313         * common/common-regcache.h: Rename include guard.
10314         * common/common-inferior.h: Rename include guard.
10315         * common/common-gdbthread.h: Rename include guard.
10316         * common/common-exceptions.h: Rename include guard.
10317         * common/common-defs.h: Rename include guard.
10318         * common/common-debug.h: Rename include guard.
10319         * common/cleanups.h: Rename include guard.
10320         * common/buffer.h: Rename include guard.
10321         * common/btrace-common.h: Rename include guard.
10322         * common/break-common.h: Rename include guard.
10323         * cli/cli-utils.h: Rename include guard.
10324         * cli/cli-style.h: Rename include guard.
10325         * cli/cli-setshow.h: Rename include guard.
10326         * cli/cli-script.h: Rename include guard.
10327         * cli/cli-interp.h: Rename include guard.
10328         * cli/cli-decode.h: Rename include guard.
10329         * cli/cli-cmds.h: Rename include guard.
10330         * charset-list.h: Add include guard.
10331         * buildsym-legacy.h: Rename include guard.
10332         * bfin-tdep.h: Add include guard.
10333         * ax.h: Rename include guard.
10334         * arm-linux-tdep.h: Add include guard.
10335         * arm-fbsd-tdep.h: Add include guard.
10336         * arch/xtensa.h: Rename include guard.
10337         * arch/tic6x.h: Add include guard.
10338         * arch/i386.h: Add include guard.
10339         * arch/arm.h: Rename include guard.
10340         * arch/arm-linux.h: Rename include guard.
10341         * arch/arm-get-next-pcs.h: Rename include guard.
10342         * arch/amd64.h: Add include guard.
10343         * arch/aarch64-insn.h: Rename include guard.
10344         * arch-utils.h: Rename include guard.
10345         * annotate.h: Add include guard.
10346         * amd64-darwin-tdep.h: Rename include guard.
10347         * aarch64-linux-tdep.h: Add include guard.
10348         * aarch64-fbsd-tdep.h: Add include guard.
10349         * aarch32-linux-nat.h: Add include guard.
10350
10351 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10352
10353         * macrotab.c (macro_define_internal): New function that
10354         factorizes macro_define_object_internal and macro_define_function
10355         code.
10356         (macro_define_object_internal): Use macro_define_internal.
10357         (macro_define_function): Likewise.
10358
10359 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10360
10361         * macrocmd.c (extract_identifier): Return
10362         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10363         callers.
10364
10365 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10366
10367         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10368
10369 2019-02-05  Tom Tromey  <tom@tromey.com>
10370
10371         * target.c (target_stack::unpush): Move assertion earlier.
10372
10373 2019-01-30  Tom Tromey  <tom@tromey.com>
10374
10375         PR python/23615:
10376         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10377         (gdbpy_parse_and_eval): Likewise.
10378         * python/python-internal.h (gdbpy_allow_threads): New class.
10379
10380 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10381
10382         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10383         (aarch64_fbsd_fpregmap): Move earlier.
10384         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10385         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10386         instead of individual calls to trad_frame_set_reg_addr.
10387         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10388         earlier.
10389         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10390         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10391         instead of individual calls to trad_frame_set_reg_addr.
10392
10393 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10394
10395         * CONTRIBUTE: Replace contribution list with wiki link.
10396
10397 2019-01-25  Tom Tromey  <tom@tromey.com>
10398
10399         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10400
10401 2019-01-25  Tom Tromey  <tom@tromey.com>
10402
10403         * xtensa-linux-nat.c: Fix common/ includes.
10404         * xml-support.h: Fix common/ includes.
10405         * xml-support.c: Fix common/ includes.
10406         * x86-linux-nat.c: Fix common/ includes.
10407         * windows-nat.c: Fix common/ includes.
10408         * varobj.h: Fix common/ includes.
10409         * varobj.c: Fix common/ includes.
10410         * value.c: Fix common/ includes.
10411         * valops.c: Fix common/ includes.
10412         * utils.c: Fix common/ includes.
10413         * unittests/xml-utils-selftests.c: Fix common/ includes.
10414         * unittests/utils-selftests.c: Fix common/ includes.
10415         * unittests/unpack-selftests.c: Fix common/ includes.
10416         * unittests/tracepoint-selftests.c: Fix common/ includes.
10417         * unittests/style-selftests.c: Fix common/ includes.
10418         * unittests/string_view-selftests.c: Fix common/ includes.
10419         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10420         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10421         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10422         * unittests/rsp-low-selftests.c: Fix common/ includes.
10423         * unittests/parse-connection-spec-selftests.c: Fix common/
10424         includes.
10425         * unittests/optional-selftests.c: Fix common/ includes.
10426         * unittests/offset-type-selftests.c: Fix common/ includes.
10427         * unittests/observable-selftests.c: Fix common/ includes.
10428         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10429         * unittests/memrange-selftests.c: Fix common/ includes.
10430         * unittests/memory-map-selftests.c: Fix common/ includes.
10431         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10432         * unittests/function-view-selftests.c: Fix common/ includes.
10433         * unittests/environ-selftests.c: Fix common/ includes.
10434         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10435         * unittests/common-utils-selftests.c: Fix common/ includes.
10436         * unittests/cli-utils-selftests.c: Fix common/ includes.
10437         * unittests/array-view-selftests.c: Fix common/ includes.
10438         * ui-file.c: Fix common/ includes.
10439         * tui/tui-io.c: Fix common/ includes.
10440         * tracepoint.h: Fix common/ includes.
10441         * tracepoint.c: Fix common/ includes.
10442         * tracefile-tfile.c: Fix common/ includes.
10443         * top.h: Fix common/ includes.
10444         * top.c: Fix common/ includes.
10445         * thread.c: Fix common/ includes.
10446         * target/waitstatus.h: Fix common/ includes.
10447         * target/waitstatus.c: Fix common/ includes.
10448         * target.h: Fix common/ includes.
10449         * target.c: Fix common/ includes.
10450         * target-memory.c: Fix common/ includes.
10451         * target-descriptions.c: Fix common/ includes.
10452         * symtab.h: Fix common/ includes.
10453         * symfile.c: Fix common/ includes.
10454         * stap-probe.c: Fix common/ includes.
10455         * spu-linux-nat.c: Fix common/ includes.
10456         * sparc-nat.c: Fix common/ includes.
10457         * source.c: Fix common/ includes.
10458         * solib.c: Fix common/ includes.
10459         * solib-target.c: Fix common/ includes.
10460         * ser-unix.c: Fix common/ includes.
10461         * ser-tcp.c: Fix common/ includes.
10462         * ser-pipe.c: Fix common/ includes.
10463         * ser-base.c: Fix common/ includes.
10464         * selftest-arch.c: Fix common/ includes.
10465         * s12z-tdep.c: Fix common/ includes.
10466         * rust-exp.y: Fix common/ includes.
10467         * rs6000-aix-tdep.c: Fix common/ includes.
10468         * riscv-tdep.c: Fix common/ includes.
10469         * remote.c: Fix common/ includes.
10470         * remote-notif.h: Fix common/ includes.
10471         * remote-fileio.h: Fix common/ includes.
10472         * remote-fileio.c: Fix common/ includes.
10473         * regcache.h: Fix common/ includes.
10474         * regcache.c: Fix common/ includes.
10475         * record-btrace.c: Fix common/ includes.
10476         * python/python.c: Fix common/ includes.
10477         * python/py-type.c: Fix common/ includes.
10478         * python/py-inferior.c: Fix common/ includes.
10479         * progspace.h: Fix common/ includes.
10480         * producer.c: Fix common/ includes.
10481         * procfs.c: Fix common/ includes.
10482         * proc-api.c: Fix common/ includes.
10483         * printcmd.c: Fix common/ includes.
10484         * ppc-linux-nat.c: Fix common/ includes.
10485         * parser-defs.h: Fix common/ includes.
10486         * osdata.c: Fix common/ includes.
10487         * obsd-nat.c: Fix common/ includes.
10488         * nat/x86-linux.c: Fix common/ includes.
10489         * nat/x86-linux-dregs.c: Fix common/ includes.
10490         * nat/x86-dregs.h: Fix common/ includes.
10491         * nat/x86-dregs.c: Fix common/ includes.
10492         * nat/ppc-linux.c: Fix common/ includes.
10493         * nat/mips-linux-watch.h: Fix common/ includes.
10494         * nat/mips-linux-watch.c: Fix common/ includes.
10495         * nat/linux-waitpid.c: Fix common/ includes.
10496         * nat/linux-ptrace.h: Fix common/ includes.
10497         * nat/linux-ptrace.c: Fix common/ includes.
10498         * nat/linux-procfs.c: Fix common/ includes.
10499         * nat/linux-personality.c: Fix common/ includes.
10500         * nat/linux-osdata.c: Fix common/ includes.
10501         * nat/linux-namespaces.c: Fix common/ includes.
10502         * nat/linux-btrace.h: Fix common/ includes.
10503         * nat/linux-btrace.c: Fix common/ includes.
10504         * nat/fork-inferior.c: Fix common/ includes.
10505         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10506         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10507         * nat/aarch64-linux.c: Fix common/ includes.
10508         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10509         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10510         * namespace.h: Fix common/ includes.
10511         * mips-linux-tdep.c: Fix common/ includes.
10512         * minsyms.c: Fix common/ includes.
10513         * mi/mi-parse.h: Fix common/ includes.
10514         * mi/mi-main.c: Fix common/ includes.
10515         * mi/mi-cmd-env.c: Fix common/ includes.
10516         * memrange.h: Fix common/ includes.
10517         * memattr.c: Fix common/ includes.
10518         * maint.h: Fix common/ includes.
10519         * maint.c: Fix common/ includes.
10520         * main.c: Fix common/ includes.
10521         * machoread.c: Fix common/ includes.
10522         * location.c: Fix common/ includes.
10523         * linux-thread-db.c: Fix common/ includes.
10524         * linux-nat.c: Fix common/ includes.
10525         * linux-fork.c: Fix common/ includes.
10526         * inline-frame.c: Fix common/ includes.
10527         * infrun.c: Fix common/ includes.
10528         * inflow.c: Fix common/ includes.
10529         * inferior.h: Fix common/ includes.
10530         * inferior.c: Fix common/ includes.
10531         * infcmd.c: Fix common/ includes.
10532         * inf-ptrace.c: Fix common/ includes.
10533         * inf-child.c: Fix common/ includes.
10534         * ia64-linux-nat.c: Fix common/ includes.
10535         * i387-tdep.c: Fix common/ includes.
10536         * i386-tdep.c: Fix common/ includes.
10537         * i386-linux-tdep.c: Fix common/ includes.
10538         * i386-linux-nat.c: Fix common/ includes.
10539         * i386-go32-tdep.c: Fix common/ includes.
10540         * i386-fbsd-tdep.c: Fix common/ includes.
10541         * i386-fbsd-nat.c: Fix common/ includes.
10542         * guile/scm-type.c: Fix common/ includes.
10543         * guile/guile.c: Fix common/ includes.
10544         * go32-nat.c: Fix common/ includes.
10545         * gnu-nat.c: Fix common/ includes.
10546         * gdbthread.h: Fix common/ includes.
10547         * gdbarch-selftests.c: Fix common/ includes.
10548         * gdb_usleep.c: Fix common/ includes.
10549         * gdb_select.h: Fix common/ includes.
10550         * gdb_bfd.c: Fix common/ includes.
10551         * gcore.c: Fix common/ includes.
10552         * fork-child.c: Fix common/ includes.
10553         * findvar.c: Fix common/ includes.
10554         * fbsd-nat.c: Fix common/ includes.
10555         * event-top.c: Fix common/ includes.
10556         * event-loop.c: Fix common/ includes.
10557         * dwarf2read.c: Fix common/ includes.
10558         * dwarf2loc.c: Fix common/ includes.
10559         * dwarf2-frame.c: Fix common/ includes.
10560         * dwarf-index-cache.c: Fix common/ includes.
10561         * dtrace-probe.c: Fix common/ includes.
10562         * disasm-selftests.c: Fix common/ includes.
10563         * defs.h: Fix common/ includes.
10564         * csky-tdep.c: Fix common/ includes.
10565         * cp-valprint.c: Fix common/ includes.
10566         * cp-support.h: Fix common/ includes.
10567         * cp-support.c: Fix common/ includes.
10568         * corelow.c: Fix common/ includes.
10569         * completer.h: Fix common/ includes.
10570         * completer.c: Fix common/ includes.
10571         * compile/compile.c: Fix common/ includes.
10572         * compile/compile-loc2c.c: Fix common/ includes.
10573         * compile/compile-cplus-types.c: Fix common/ includes.
10574         * compile/compile-cplus-symbols.c: Fix common/ includes.
10575         * command.h: Fix common/ includes.
10576         * cli/cli-dump.c: Fix common/ includes.
10577         * cli/cli-cmds.c: Fix common/ includes.
10578         * charset.c: Fix common/ includes.
10579         * build-id.c: Fix common/ includes.
10580         * btrace.h: Fix common/ includes.
10581         * btrace.c: Fix common/ includes.
10582         * breakpoint.h: Fix common/ includes.
10583         * breakpoint.c: Fix common/ includes.
10584         * ax.h:
10585         (enum agent_op): Fix common/ includes.
10586         * ax-general.c (struct aop_map): Fix common/ includes.
10587         * ax-gdb.c: Fix common/ includes.
10588         * auxv.c: Fix common/ includes.
10589         * auto-load.c: Fix common/ includes.
10590         * arm-tdep.c: Fix common/ includes.
10591         * arch/riscv.c: Fix common/ includes.
10592         * arch/ppc-linux-common.c: Fix common/ includes.
10593         * arch/i386.c: Fix common/ includes.
10594         * arch/arm.c: Fix common/ includes.
10595         * arch/arm-linux.c: Fix common/ includes.
10596         * arch/arm-get-next-pcs.c: Fix common/ includes.
10597         * arch/amd64.c: Fix common/ includes.
10598         * arch/aarch64.c: Fix common/ includes.
10599         * arch/aarch64-insn.c: Fix common/ includes.
10600         * arch-utils.c: Fix common/ includes.
10601         * amd64-windows-tdep.c: Fix common/ includes.
10602         * amd64-tdep.c: Fix common/ includes.
10603         * amd64-sol2-tdep.c: Fix common/ includes.
10604         * amd64-obsd-tdep.c: Fix common/ includes.
10605         * amd64-nbsd-tdep.c: Fix common/ includes.
10606         * amd64-linux-tdep.c: Fix common/ includes.
10607         * amd64-linux-nat.c: Fix common/ includes.
10608         * amd64-fbsd-tdep.c: Fix common/ includes.
10609         * amd64-fbsd-nat.c: Fix common/ includes.
10610         * amd64-dicos-tdep.c: Fix common/ includes.
10611         * amd64-darwin-tdep.c: Fix common/ includes.
10612         * agent.c: Fix common/ includes.
10613         * ada-lang.h: Fix common/ includes.
10614         * ada-lang.c: Fix common/ includes.
10615         * aarch64-tdep.c: Fix common/ includes.
10616
10617 2019-01-25  Tom Tromey  <tom@tromey.com>
10618
10619         * common/create-version.sh: Use common/version.h.
10620
10621 2019-01-24  Pedro Alves  <palves@redhat.com>
10622
10623         * infrun.c (signal_stop, signal_print, signal_program)
10624         (signal_catch, signal_pass): Now arrays instead of pointers.
10625         (update_signals_program_target, do_target_resume)
10626         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10627         * linux-nat.c (linux_nat_target::pass_signals)
10628         (linux_nat_target::create_inferior, linux_nat_target::attach):
10629         Adjust.
10630         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10631         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10632         * procfs.c (procfs_target::pass_signals): Adjust.
10633         * record-full.c (record_full_target::resume): Adjust.
10634         * remote.c (remote_target::pass_signals)
10635         (remote_target::program_signals): Adjust.
10636         * target-debug.h (target_debug_print_signals): Now takes a
10637         gdb::array_view as parameter.  Adjust.
10638         * target.h (target_ops) <pass_signals, program_signals>: Replace
10639         pointer and length parameters with gdb::array_view.
10640         (target_pass_signals, target_program_signals): Likewise.
10641         * target-delegates.c: Regenerate.
10642
10643 2019-01-24  Pedro Alves  <palves@redhat.com>
10644
10645         * common/forward-scope-exit.h
10646         (forward_scope_exit::forward_scope_exit): Pass arguments to
10647         m_bind_function directly, instead of creating a std::bind and
10648         copying that.
10649
10650 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10651
10652         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10653         for static members.
10654         (pass_in_v_vfp_candidate): Likewise.
10655
10656 2019-01-23  Tom Tromey  <tom@tromey.com>
10657             Pedro Alves  <palves@redhat.com>
10658
10659         * regcache.c (class regcache_invalidator): Remove.
10660         (regcache::raw_write): Use make_scope_exit.
10661
10662 2019-01-23  Tom Tromey  <tom@tromey.com>
10663
10664         * ui-out.h (class ui_out_emit_type): Update comment.
10665
10666 2019-01-23  Tom Tromey  <tom@tromey.com>
10667
10668         * infrun.c (fetch_inferior_event): Update comment.
10669
10670 2019-01-23  Tom Tromey  <tom@tromey.com>
10671             Pedro Alves  <palves@redhat.com>
10672
10673         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10674         parameter.
10675         (fetch_inferior_event): Use SCOPE_EXIT.
10676
10677
10678 2019-01-23  Tom Tromey  <tom@tromey.com>
10679             Pedro Alves  <palves@redhat.com>
10680
10681         * infrun.c (disable_thread_events): Delete.
10682         (stop_all_threads): Use SCOPE_EXIT.
10683
10684 2019-01-23  Tom Tromey  <tom@tromey.com>
10685             Pedro Alves  <palves@redhat.com>
10686
10687         * symfile.c: Include forward-scope-exit.h.
10688         (clear_symtab_users_cleanup): Replace forward declaration with
10689         a FORWARD_SCOPE_EXIT.
10690         (syms_from_objfile_1): Use the forward_scope_exit and
10691         gdb::optional instead of cleanup_function.
10692         (reread_symbols): Use the forward_scope_exit instead of
10693         cleanup_function.
10694         (clear_symtab_users_cleanup): Remove function.
10695
10696 2019-01-23  Tom Tromey  <tom@tromey.com>
10697             Pedro Alves  <palves@redhat.com>
10698
10699         * linux-nat.c: Include scope-exit.h.
10700         (cleanup_target_stop): Remove.
10701         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10702         SCOPE_EXIT.
10703
10704 2019-01-23  Tom Tromey  <tom@tromey.com>
10705             Pedro Alves  <palves@redhat.com>
10706
10707         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10708         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10709
10710 2019-01-23  Tom Tromey  <tom@tromey.com>
10711             Andrew Burgess  <andrew.burgess@embecosm.com>
10712             Pedro Alves  <palves@redhat.com>
10713
10714         * infrun.c (fetch_inferior_event): Use scope_exit.
10715         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10716         * top.c (execute_command): Use scope_exit.
10717         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10718         * utils.c (do_bpstat_clear_actions_cleanup)
10719         (make_bpstat_clear_actions_cleanup): Remove.
10720
10721 2019-01-23  Tom Tromey  <tom@tromey.com>
10722             Pedro Alves  <palves@redhat.com>
10723
10724         * infrun.c: Include "common/scope-exit.h"
10725         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10726         (wait_for_inferior): Use SCOPE_EXIT.
10727         (fetch_inferior_event): Use scope_exit.
10728
10729 2019-01-23  Tom Tromey  <tom@tromey.com>
10730             Pedro Alves  <palves@redhat.com>
10731
10732         * breakpoint.c (create_breakpoint): Remove cleanup.
10733
10734 2019-01-23  Tom Tromey  <tom@tromey.com>
10735             Andrew Burgess  <andrew.burgess@embecosm.com>
10736             Pedro Alves  <palves@redhat.com>
10737
10738 2019-01-23  Pedro Alves  <palves@redhat.com>
10739
10740         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10741
10742 2019-01-23  Pedro Alves  <palves@redhat.com>
10743             Andrew Burgess  <andrew.burgess@embecosm.com>
10744
10745         * gdbthread.h: Include "common/forward-scope-exit.h".
10746         (scoped_finish_thread_state): Redefine custom class in terms of
10747         forward_scope_exit.
10748
10749 2019-01-23  Pedro Alves  <palves@redhat.com>
10750             Andrew Burgess  <andrew.burgess@embecosm.com>
10751
10752         * common/forward-scope-exit.h: New file.
10753
10754 2019-01-23  Pedro Alves  <palves@redhat.com>
10755             Andrew Burgess  <andrew.burgess@embecosm.com>
10756             Tom Tromey  <tom@tromey.com>
10757
10758         * common/scope-exit.h: New file.
10759
10760 2019-01-23  Pedro Alves  <palves@redhat.com>
10761
10762         * common/preprocessor.h (ESC): Rename to ...
10763         (ESC_PARENS): ... this.
10764         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10765         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10766
10767 2019-01-23  Tom Tromey  <tom@tromey.com>
10768
10769         * language.h (class scoped_switch_to_sym_language_if_auto):
10770         Initialize m_lang in both cases.
10771
10772 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10773
10774         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10775         with XCNEW.
10776
10777 2019-01-22  Tom Tromey  <tom@tromey.com>
10778
10779         * corelow.c: Do not include sys/file.h.
10780
10781 2019-01-22  Tom Tromey  <tom@tromey.com>
10782
10783         * tui/tui-wingeneral.h: Include gdb_curses.h.
10784
10785 2019-01-22  Tom Tromey  <tom@tromey.com>
10786
10787         * source-cache.h (class source_cache) <get_source_lines,
10788         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10789
10790 2019-01-22  Tom Tromey  <tom@tromey.com>
10791
10792         * remote-fileio.h (struct remote_target): Declare.
10793
10794 2019-01-22  Tom Tromey  <tom@tromey.com>
10795
10796         * python/py-arch.c: Do not include py-ref.h.
10797         * python/py-bpevent.c: Do not include py-ref.h.
10798         * python/py-cmd.c: Do not include py-ref.h.
10799         * python/py-continueevent.c: Do not include py-ref.h.
10800         * python/py-event.h: Do not include py-ref.h.
10801         * python/py-evtregistry.c: Do not include py-ref.h.
10802         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10803         * python/py-frame.c: Do not include py-ref.h.
10804         * python/py-framefilter.c: Do not include py-ref.h.
10805         * python/py-function.c: Do not include py-ref.h.
10806         * python/py-infevents.c: Do not include py-ref.h.
10807         * python/py-linetable.c: Do not include py-ref.h.
10808         * python/py-objfile.c: Do not include py-ref.h.
10809         * python/py-param.c: Do not include py-ref.h.
10810         * python/py-prettyprint.c: Do not include py-ref.h.
10811         * python/py-progspace.c: Do not include py-ref.h.
10812         * python/py-symbol.c: Do not include py-ref.h.
10813         * python/py-symtab.c: Do not include py-ref.h.
10814         * python/py-type.c: Do not include py-ref.h.
10815         * python/py-unwind.c: Do not include py-ref.h.
10816         * python/py-utils.c: Do not include py-ref.h.
10817         * python/py-value.c: Do not include py-ref.h.
10818         * python/py-varobj.c: Do not include py-ref.h.
10819         * python/py-xmethods.c: Do not include py-ref.h.
10820         * python/python.c: Do not include py-ref.h.
10821         * varobj.c: Do not include py-ref.h.
10822
10823 2019-01-22  Tom Tromey  <tom@tromey.com>
10824
10825         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10826         keyword for bcache.
10827
10828 2019-01-22  Tom Tromey  <tom@tromey.com>
10829
10830         * compile/compile-cplus-types.c: Remove a comment by #include.
10831
10832 2019-01-22  Tom Tromey  <tom@tromey.com>
10833
10834         * compile/gcc-c-plugin.h: Include compile-internal.h.
10835
10836 2019-01-22  Tom Tromey  <tom@tromey.com>
10837
10838         * stabsread.c (EXTERN): Do not define.
10839         (symnum, next_symbol_text_func, processing_gcc_compilation)
10840         (within_function, global_sym_chain, global_stabs)
10841         (previous_stab_code, this_object_header_files)
10842         (n_this_object_header_files)
10843         (n_allocated_this_object_header_files): Define.
10844         * stabsread.h (EXTERN): Never define.  Use "extern".
10845
10846 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10847
10848         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10849         history_value.
10850
10851 2019-01-21  Tom Tromey  <tom@tromey.com>
10852
10853         * ui-out.c: Fix includes.
10854         * tui/tui-source.c: Fix includes.
10855         * target.c: Fix includes.
10856         * remote.c: Fix includes.
10857         * regcache.c: Fix includes.
10858         * python/py-block.c: Fix includes.
10859         * printcmd.c: Fix includes.
10860         * or1k-tdep.c: Fix includes.
10861         * mi/mi-main.c: Fix includes.
10862         * m32r-tdep.c: Fix includes.
10863         * csky-tdep.c: Fix includes.
10864         * compile/compile-cplus-types.c: Fix includes.
10865         * cli/cli-interp.c: Fix includes.
10866
10867 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10868
10869         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10870         for padding.
10871
10872 2019-01-16  Tom Tromey  <tom@tromey.com>
10873
10874         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10875         earlier.
10876         (struct objfile) <msymbols_range>: Move from top level.
10877         <msymbols>: New method.
10878         (class objfile_msymbols): Remove.
10879         * symtab.c (default_collect_symbol_completion_matches_break_on):
10880         Update.
10881         * symmisc.c (dump_msymbols): Update.
10882         * stabsread.c (scan_file_globals): Update.
10883         * objc-lang.c (info_selectors_command, info_classes_command)
10884         (find_methods): Update.
10885         * minsyms.c (find_solib_trampoline_target): Update.
10886         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10887         * coffread.c (coff_symfile_read): Update.
10888         * ada-lang.c (ada_lookup_simple_minsym)
10889         (ada_collect_symbol_completion_matches): Update.
10890
10891 2019-01-16  Tom Tromey  <tom@tromey.com>
10892
10893         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10894         type.  Remove no-argument constructor.
10895         <iterator::operator++>: Simplify.
10896         <begin>: Update.
10897         <end>: Use minimal_symbol_count.
10898
10899 2019-01-16  Tom Tromey  <tom@tromey.com>
10900
10901         * objfiles.h (struct objfile) <psymtabs>: New method.
10902         (class objfile_psymtabs): Remove.
10903         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10904         typedef.
10905         <range>: New method.
10906         (require_partial_symbols): Change return type.
10907         * psymtab.c (require_partial_symbols)
10908         (psym_expand_symtabs_matching): Update.
10909         * mdebugread.c (parse_partial_symbols): Update.
10910         * dbxread.c (dbx_end_psymtab): Update.
10911
10912 2019-01-15  Tom Tromey  <tom@tromey.com>
10913
10914         * symtab.c (lookup_objfile_from_block)
10915         (lookup_symbol_in_objfile_symtabs)
10916         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10917         (find_line_symtab, info_sources_command)
10918         (default_collect_symbol_completion_matches_break_on)
10919         (make_source_files_completion_list): Update.
10920         * symmisc.c (print_objfile_statistics, dump_objfile)
10921         (maintenance_print_symbols, maintenance_info_symtabs)
10922         (maintenance_check_symtabs, maintenance_info_line_tables):
10923         Update.
10924         * source.c (select_source_symtab)
10925         (forget_cached_source_info_for_objfile): Update.
10926         * objfiles.h (class objfile_compunits): Remove.
10927         (struct objfile) <compunits_range>: New typedef.
10928         (compunits): New method.
10929         * objfiles.c (objfile_relocate1): Update.
10930         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10931         * maint.c (count_symtabs_and_blocks): Update.
10932         * linespec.c (iterate_over_all_matching_symtabs): Update.
10933         * cp-support.c (add_symbol_overload_list_qualified): Update.
10934         * coffread.c (coff_symtab_read): Update.
10935         * ada-lang.c (add_nonlocal_symbols)
10936         (ada_collect_symbol_completion_matches)
10937         (ada_add_global_exceptions): Update.
10938
10939 2019-01-15  Tom Tromey  <tom@tromey.com>
10940
10941         * progspace.h (program_space) <objfiles_safe_range>: New
10942         typedef.
10943         <objfiles_safe>: New method.
10944         * objfiles.h (class all_objfiles_safe): Remove.
10945         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10946         * jit.c (jit_inferior_exit_hook): Update.
10947
10948 2019-01-17  Tom Tromey  <tom@tromey.com>
10949
10950         * progspace.h (program_space) <objfiles_range>: New typedef.
10951         <objfiles>: New method.
10952         <objfiles_head>: Rename from objfiles.
10953         (object_files): Update.
10954         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10955         * guile/scm-pretty-print.c
10956         (ppscm_find_pretty_printer_from_objfiles): Update.
10957         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10958         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10959         Update.
10960         * python/py-progspace.c (pspy_get_objfiles): Update.
10961         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10962         Update.
10963         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10964         (objfpy_lookup_objfile_by_build_id): Update.
10965         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10966         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10967         Update.
10968         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10969         (expand_symtab_containing_pc, lookup_objfile_from_block)
10970         (lookup_static_symbol, basic_lookup_transparent_type)
10971         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10972         (find_line_symtab, info_sources_command)
10973         (default_collect_symbol_completion_matches_break_on)
10974         (make_source_files_completion_list, find_main_name): Update.
10975         * symmisc.c (print_symbol_bcache_statistics)
10976         (print_objfile_statistics, maintenance_print_symbols)
10977         (maintenance_print_msymbols, maintenance_print_objfiles)
10978         (maintenance_info_symtabs, maintenance_check_symtabs)
10979         (maintenance_expand_symtabs, maintenance_info_line_tables):
10980         Update.
10981         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10982         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10983         (map_overlay_command, unmap_overlay_command)
10984         (simple_overlay_update, expand_symtabs_matching)
10985         (map_symbol_filenames): Update.
10986         * symfile-debug.c (set_debug_symfile): Update.
10987         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10988         Update.
10989         * source.c (select_source_symtab, forget_cached_source_info):
10990         Update.
10991         * solib.c (solib_read_symbols): Update.
10992         * solib-spu.c (append_ocl_sos): Update.
10993         * psymtab.c (maintenance_print_psymbols)
10994         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10995         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10996         * printcmd.c (info_symbol_command): Update.
10997         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10998         Update.
10999         * objfiles.h (class all_objfiles): Remove.
11000         * objfiles.c (have_partial_symbols, have_full_symbols)
11001         (have_minimal_symbols, qsort_cmp, update_section_map)
11002         (shared_objfile_contains_address_p)
11003         (default_iterate_over_objfiles_in_search_order): Update.
11004         * objc-lang.c (info_selectors_command, info_classes_command)
11005         (find_methods): Update.
11006         * minsyms.c (find_solib_trampoline_target): Update.
11007         * maint.c (maintenance_info_sections)
11008         (maintenance_translate_address, count_symtabs_and_blocks):
11009         Update.
11010         * main.c (captured_main_1): Update.
11011         * linux-thread-db.c (try_thread_db_load_from_pdir)
11012         (has_libpthread): Update.
11013         * linespec.c (iterate_over_all_matching_symtabs)
11014         (search_minsyms_for_name): Update.
11015         * jit.c (jit_find_objf_with_entry_addr): Update.
11016         * hppa-tdep.c (find_unwind_entry)
11017         (hppa_lookup_stub_minimal_symbol): Update.
11018         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11019         Update.
11020         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11021         (elf_gnu_ifunc_resolve_by_got): Update.
11022         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11023         * dwarf-index-write.c (save_gdb_index_command): Update.
11024         * cp-support.c (add_symbol_overload_list_qualified): Update.
11025         * breakpoint.c (create_overlay_event_breakpoint)
11026         (create_longjmp_master_breakpoint)
11027         (create_std_terminate_master_breakpoint)
11028         (create_exception_master_breakpoint): Update.
11029         * blockframe.c (find_pc_partial_function): Update.
11030         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11031         (ada_collect_symbol_completion_matches)
11032         (ada_add_global_exceptions): Update.
11033
11034 2019-01-17  Tom Tromey  <tom@tromey.com>
11035
11036         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11037         declare VEC.
11038         (solib_target_parse_libraries): Change return type.
11039         (library_list_start_segment, library_list_start_section)
11040         (library_list_end_library, library_list_start_library); Update.
11041         (solib_target_free_library_list): Remove.
11042         (solib_target_parse_libraries): Remove cleanup.  Change return
11043         type.
11044         (solib_target_current_sos): Update.
11045
11046 2019-01-17  Tom Tromey  <tromey@bapiya>
11047
11048         * valprint.c: Replace "the the" with "the".
11049         * symtab.c: Replace "the the" with "the".
11050         * solib.c: Replace "the the" with "the".
11051         * solib-dsbt.c: Replace "the the" with "the".
11052         * linespec.c: Replace "the the" with "the".
11053         * dwarf2loc.h: Replace "the the" with "the".
11054         * amd64-windows-tdep.c: Replace "the the" with "the".
11055         * aarch64-tdep.c: Replace "the the" with "the".
11056
11057 2019-01-16  Keith Seitz  <keiths@redhat.com>
11058
11059         PR gdb/23773
11060         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11061         <builder>: Rename to ..
11062         <m_builder>: ... this and make private.
11063         (dwarf2_cu::get_builder): New method.  Change all users of
11064         `builder' to use this method.
11065         (dwarf2_start_symtab): Move to ...
11066         (dwarf2_cu::start_symtab): ... here.  Update all callers
11067         (setup_type_unit_groups): Move to ...
11068         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11069         callers.
11070         (dwarf2_cu::reset_builder): New method.
11071         (process_full_compunit, process_full_type_unit): Use
11072         dwarf2_cu::reset_builder.
11073         (follow_die_offset): Record the ancestor CU if it is different
11074         from the followed DIE's CU.
11075         (follow_die_sig_1): Likewise.
11076
11077 2019-01-15  Tom Tromey  <tom@tromey.com>
11078
11079         * remote.c (class remote_state) <buf>: Now a char_vector.
11080         <buf_size>: Remove.
11081         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11082         parameter.
11083         (remote_target::getpkt_or_notif_sane_1)
11084         (remote_target::getpkt_sane)
11085         (remote_target::getpkt_or_notif_sane): Likewise.
11086         (class remote_target) <putpkt>: New overload.
11087         (remote_target::read_frame): Change type of "buf_p".  Remove
11088         sizeof_p parameter.
11089         (packet_ok): New overload.
11090         (packet_check_result): New overload.
11091         Update all uses.
11092
11093 2019-01-14  Tom Tromey  <tom@tromey.com>
11094
11095         * remote-notif.c (handle_notification, remote_notif_ack)
11096         (remote_notif_parse): Make "buf" const.
11097         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11098         const.
11099         (remote_notif_parse, remote_notif_ack, handle_notification):
11100         Likewise.
11101         * remote.c (remote_notif_stop_parse): Make "buf" const.
11102         (remote_target::remote_parse_stop_reply): Make "buf" const.
11103         (remote_notif_stop_ack): Make "buf" const.
11104
11105 2019-01-14  Tom Tromey  <tom@tromey.com>
11106
11107         * remote.c (remote_console_output): Make parameter const.
11108
11109 2019-01-14  Tom Tromey  <tom@tromey.com>
11110
11111         * target-debug.h (target_debug_print_signals): Constify.
11112         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11113         * procfs.c (procfs_target::pass_signals): Update.
11114         * linux-nat.c (linux_nat_target::pass_signals): Update.
11115         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11116         * target-delegates.c: Rebuild.
11117         * remote.c (remote_target::program_signals): Update.
11118         (remote_target::pass_signals): Update.
11119         * target.c (target_pass_signals): Constify argument.
11120         (target_program_signals): Likewise.
11121         * target.h (struct target_ops) <pass_signals, program_signals>:
11122         Constify argument.
11123         (target_pass_signals, target_program_signals): Constify argument.
11124
11125 2019-01-14  Tom Tromey  <tom@tromey.com>
11126
11127         PR tui/28819:
11128         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11129
11130 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11131
11132         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11133         field.
11134         * rs6000-tdep.c: Include reggroups.h.
11135         (IS_V_ALIAS_PSEUDOREG): Define.
11136         (rs6000_register_name): Return names for the "vX" aliases.
11137         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11138         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11139         aliases.  Call default_register_reggroup_p for all other
11140         pseudo-registers.
11141         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11142         New functions.
11143         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11144         Handle "vX" aliases.
11145         (v_alias_pseudo_register_collect): New function.
11146         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11147         (rs6000_gdbarch_init): Initialize "vX" aliases as
11148         pseudo-registers.  Restore registration of
11149         rs6000_pseudo_register_reggroup_p with
11150         set_tdesc_pseudo_register_reggroup_p.
11151
11152 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11153
11154         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11155         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11156         set_gdbarch_num_pseudo_regs.
11157
11158 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11159
11160         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11161         Remove arg prefixname, add do_set and do_show.
11162         Add member functions set_list and show_list.
11163         * cli/cli-style.c (class cli_style_option): Update accordingly.
11164         (style_set_list): Move to file scope.
11165         (style_show_list): Likewise.
11166         (set_style): Call help_list.
11167         (show_style): Call cmd_show_list.
11168         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11169         Update to use the new macro.
11170
11171 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11172
11173         * ada-lang.c (_initialize_ada_language): Expand the help text
11174         for the "catch exception" command.
11175
11176 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11177
11178         * symtab.c (matching_obj_sections): Initialize obj,
11179         declare it closer to its usage.
11180
11181 2019-01-10  Tom Tromey  <tom@tromey.com>
11182
11183         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11184         (basic_inf_threads_range): Remove.
11185         (inf_threads_range, inf_non_exited_threads_range)
11186         (safe_inf_threads_range): Use next_adapter.
11187
11188 2019-01-10  Keith Seitz  <keiths@redhat.com>
11189
11190         PR gdb/23712
11191         PR symtab/23010
11192         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11193         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11194
11195 2019-01-10  Keith Seitz  <keiths@redhat.com>
11196
11197         PR gdb/23712
11198         PR symtab/23010
11199         * dictionary.c (pending_to_vector): Remove.
11200         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11201         Remove _1 suffix, replacing functions of the same name.  Update
11202         all callers.
11203         (dict_create_hashed, dict_create_hashed_expandable)
11204         (dict_create_linear, dict_create_linear_expandable, dict_free)
11205         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11206         Make functions static.
11207
11208 2019-01-10  Keith Seitz  <keiths@redhat.com>
11209
11210         PR gdb/23712
11211         PR symtab/23010
11212         * dictionary.h (struct dictionary): Replace declaration with
11213         multidictionary.
11214         (dict_create_hashed, dict_create_hashed_expandable)
11215         (dict_create_linear, dict_create_linear_expandable)
11216         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11217         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11218         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11219         taking multidictionary argument.
11220         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11221         * block.h (struct block) <dict>: Change to multidictionary
11222         and rename `multidict'.
11223         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11224         symmisc.c: Update all dictionary references to multidictionary.
11225
11226 2019-01-10  Keith Seitz  <keiths@redhat.com>
11227
11228         PR gdb/23712
11229         PR symtab/23010
11230         * dictionary.c: Include unordered_map.
11231         (pending_to_vector): New function.
11232         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11233         Rewrite the non-"_1" functions to take vector instead
11234         of linked list.
11235         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11236         "new" _1 versions of the same name.
11237         (multidictionary): Define.
11238         (std::hash<enum language): New definition.
11239         (collate_pending_symbols_by_language, mdict_create_hashed)
11240         (mdict_create_hashed_expandable, mdict_create_linear)
11241         (mdict_create_linear_expandable, mdict_free)
11242         (find_language_dictionary, create_new_language_dictionary)
11243         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11244         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11245         (mdict_size, mdict_empty): New functions.
11246         * dictionary.h (mdict_iterator): Define.
11247
11248 2019-01-10  Pedro Alves  <palves@redhat.com>
11249
11250         * breakpoint.c (read_uploaded_action)
11251         (create_tracepoint_from_upload): Adjust to use
11252         gdb::unique_xmalloc_ptr.
11253         * ctf.c (ctf_write_uploaded_tp):
11254         (SET_ARRAY_FIELD): Use emplace_back.
11255         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11256         * tracefile-tfile.c (tfile_write_uploaded_tp):
11257         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11258         gdb::unique_xmalloc_ptr.
11259         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11260         at_string, cond_string, cmd_strings>: Replace char pointers
11261         with gdb::unique_xmalloc_ptr.
11262
11263 2019-01-10  Pedro Alves  <palves@redhat.com>
11264
11265         * solib-target.c (library_list_start_library): Don't xstrdup name.
11266
11267 2019-01-10  Pedro Alves  <palves@redhat.com>
11268
11269         * mdebugread.c (parse_partial_symbols): Use
11270         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11271
11272 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11273
11274         * linux-fork.c (scoped_switch_fork_info)
11275         <~scoped_switch_fork_info>: Fix incorrect variable name.
11276
11277 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11278
11279         * linux-fork.c (scoped_switch_fork_info)
11280         <scoped_switch_fork_info>: Make explicit.
11281         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11282
11283 2019-01-10  Tom Tromey  <tom@tromey.com>
11284
11285         * objfiles.h (objfile::reset_psymtabs): Update.
11286         * objfiles.c (objfile::objfile): Update.
11287         * psymtab.h (psymtab_storage::obstack): Update.
11288         (psymtab_storage::m_obstack): Use gdb::optional.
11289         (class psymtab_storage): Update comment.  Remove objfile
11290         parameter.
11291         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11292
11293 2019-01-10  Tom Tromey  <tom@tromey.com>
11294
11295         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11296         <free_psymtabs>: Now private.
11297         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11298         (allocate_psymtab): Use new method.
11299
11300 2019-01-10  Tom Tromey  <tom@tromey.com>
11301
11302         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11303         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11304         * mdebugread.c (parse_partial_symbols): Use
11305         allocate_dependencies.
11306         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11307         allocate_dependencies.
11308         (process_psymtab_comp_unit_reader)
11309         (build_type_psymtab_dependencies): Likewise.
11310         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11311
11312 2019-01-10  Tom Tromey  <tom@tromey.com>
11313
11314         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11315         PSYMBOL_SET_LANGUAGE.
11316         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11317
11318 2019-01-10  Tom Tromey  <tom@tromey.com>
11319
11320         * psymtab.h (psymtab_storage::obstack): New method.
11321         <m_obstack>: Rename from obstack; now private.
11322         * psymtab.c (psymtab_storage): Update.
11323         * dwarf2read.c (create_addrmap_from_index)
11324         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11325         Update.
11326
11327 2019-01-10  Tom Tromey  <tom@tromey.com>
11328
11329         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11330         * objfiles.h (objfile::reset_psymtabs): New method.
11331
11332 2019-01-10  Tom Tromey  <tom@tromey.com>
11333
11334         * symmisc.c (print_symbol_bcache_statistics): Update.
11335         (print_objfile_statistics): Update.
11336         * symfile.c (reread_symbols): Update.
11337         * psymtab.h (class psymtab_storage): New.
11338         * psymtab.c (psymtab_storage): New constructor.
11339         (~psymtab_storage): New destructor.
11340         (require_partial_symbols): Update.
11341         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11342         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11343         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11344         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11345         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11346         (start_psymtab_common, end_psymtab_common)
11347         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11348         (allocate_psymtab): Update.
11349         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11350         Update.
11351         (dump_psymtab_addrmap, maintenance_print_psymbols)
11352         (maintenance_check_psymtabs): Update.
11353         (class objfile_psymtabs): Move to objfiles.h.
11354         * psympriv.h (discard_psymtab): Now inline.
11355         (psymtab_discarder::psymtab_discarder): Update.
11356         (psymtab_discarder::~psymtab_discarder): Update.
11357         (ALL_OBJFILE_PSYMTABS): Rewrite.
11358         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11359         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11360         Remove fields.
11361         <partial_symtabs>: New field.
11362         (class objfile_psymtabs): Move from psymtab.h.  Update.
11363         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11364         psymbol_cache.
11365         (objfile::~objfile): Don't destroy psymbol_cache.
11366         * mdebugread.c (parse_partial_symbols): Update.
11367         * dwarf2read.c (create_addrmap_from_index)
11368         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11369         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11370         (add_partial_subprogram, dwarf2_ranges_read): Update.
11371         * dwarf-index-write.c (write_address_map)
11372         (write_one_signatured_type, recursively_write_psymbols)
11373         (class debug_names, class debug_names, write_psymtabs_to_index):
11374         Update.
11375
11376 2019-01-10  Tom Tromey  <tom@tromey.com>
11377
11378         * symtab.h (SYMBOL_SET_NAMES): Update.
11379         (symbol_set_names): Update.
11380         (MSYMBOL_SET_NAMES): Update.
11381         * symtab.c (symbol_set_names): Change argument to be an
11382         objfile_per_bfd_storage.
11383         * psymtab.c (add_psymbol_to_bcache): Update.
11384         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11385
11386 2019-01-10  Tom Tromey  <tom@tromey.com>
11387
11388         * symtab.c (create_demangled_names_hash): Change argument to be an
11389         objfile_per_bfd_storage.
11390         (symbol_set_names): Update.
11391
11392 2019-01-10  Tom Tromey  <tom@tromey.com>
11393
11394         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11395         init_psymbol_list.
11396         * psymtab.c (init_psymbol_list): Do nothing if already called.
11397         * psympriv.h (init_psymbol_list): Add comment.
11398         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11399         init_psymbol_list.
11400         * dbxread.c (dbx_symfile_read): Unconditionally call
11401         init_psymbol_list.
11402
11403 2019-01-10  Tom Tromey  <tom@tromey.com>
11404
11405         * xcoffread.c (scan_xcoff_symtab): Update.
11406         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11407         "where".
11408         * mdebugread.c (parse_partial_symbols)
11409         (handle_psymbol_enumerators): Update.
11410         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11411         * dbxread.c (read_dbx_symtab): Update.
11412         * psympriv.h (psymbol_placement): New enum.
11413         (add_psymbol_to_list): Update.
11414
11415 2019-01-10  Tom Tromey  <tom@tromey.com>
11416
11417         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11418         static_psymbols parameters.
11419         (scan_xcoff_symtab): Update.
11420         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11421         static_psymbols parameters.
11422         * psympriv.h (start_psymtab_common): Update.
11423         * mdebugread.c (parse_partial_symbols): Update.
11424         * dwarf2read.c (create_partial_symtab): Update.
11425         * dbxread.c (read_dbx_symtab): Update.
11426         (start_psymtab): Remove global_psymbols and static_psymbols
11427         parameters.
11428
11429 2019-01-10  Tom Tromey  <tom@tromey.com>
11430
11431         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11432         * psymtab.c (allocate_psymtab): Add comment.
11433         * psympriv.h (allocate_psymtab): Add comment.
11434         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11435         initializations.
11436         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11437
11438 2019-01-10  Tom Tromey  <tom@tromey.com>
11439
11440         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11441         Don't declare.
11442         * mipsread.c: Include mdebugread.h.
11443         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11444         Declare.
11445         * elfread.c: Include mdebugread.h.
11446
11447 2019-01-09  Tom Tromey  <tom@tromey.com>
11448
11449         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11450         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11451         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11452         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11453         (psym_lookup_symbol, psym_find_last_source_symtab)
11454         (psym_forget_cached_source_info, psym_print_stats)
11455         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11456         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11457         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11458         (psym_find_compunit_symtab_by_address)
11459         (maintenance_print_psymbols, maintenance_info_psymtabs)
11460         (maintenance_check_psymtabs): Use ranged for.
11461         * psymtab.h (class objfile_psymtabs): New.
11462         (require_partial_symbols): Return objfile_psymtabs.
11463         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11464
11465 2019-01-09  Tom Tromey  <tom@tromey.com>
11466
11467         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11468         (find_pc_mapped_section, list_overlays_command)
11469         (map_overlay_command, unmap_overlay_command)
11470         (simple_overlay_update): Use all_objfiles.
11471         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11472         * printcmd.c (info_symbol_command): Use all_objfiles.
11473         * objfiles.h (ALL_OBJSECTIONS): Remove.
11474         * maint.c (maintenance_translate_address): Use all_objfiles.
11475         * gcore.c (gcore_create_callback): Use all_objfiles.
11476         (objfile_find_memory_regions): Likewise.
11477
11478 2019-01-09  Tom Tromey  <tom@tromey.com>
11479
11480         * symtab.c (find_line_symtab, info_sources_command)
11481         (make_source_files_completion_list): Use objfile_compunits.
11482         * source.c (select_source_symtab): Use objfile_compunits.
11483         * objfiles.h (struct objfile): Update comment.
11484         (ALL_OBJFILES): Remove.
11485         (ALL_FILETABS): Remove.
11486         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11487         objfile_compunits.
11488
11489 2019-01-09  Tom Tromey  <tom@tromey.com>
11490
11491         * symmisc.c (print_objfile_statistics, dump_objfile)
11492         (maintenance_print_symbols): Use compunit_filetabs.
11493         * source.c (forget_cached_source_info_for_objfile): Use
11494         compunit_filetabs.
11495         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11496         (ALL_FILETABS): Use compunit_filetabs.
11497         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11498         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11499
11500 2019-01-09  Tom Tromey  <tom@tromey.com>
11501
11502         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11503         (compunit_filetabs): New.
11504         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11505         compunit_filetabs.
11506         (info_sources_command, make_source_files_completion_list): Remove
11507         declaration.
11508         * symmisc.c (print_objfile_statistics, dump_objfile)
11509         (maintenance_print_symbols): Remove declaration.
11510         (maintenance_info_symtabs): Use compunit_filetabs.
11511         (maintenance_info_line_tables): Likewise.
11512         * source.c (select_source_symtab): Change local variable name.
11513         (forget_cached_source_info_for_objfile): Remove declaration.
11514         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11515         * objfiles.c (objfile_relocate1): Remove declaration.
11516         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11517         declaration.
11518         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11519         * coffread.c (coff_symtab_read): Remove declaration.
11520         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11521         compunit_filetabs.
11522
11523 2019-01-09  Tom Tromey  <tom@tromey.com>
11524
11525         * symtab.c (lookup_objfile_from_block)
11526         (find_pc_sect_compunit_symtab, search_symbols)
11527         (default_collect_symbol_completion_matches_break_on): Use
11528         objfile_compunits.
11529         * objfiles.h (ALL_COMPUNITS): Remove.
11530         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11531         * cp-support.c (add_symbol_overload_list_qualified): Use
11532         objfile_compunits.
11533         * ada-lang.c (ada_collect_symbol_completion_matches)
11534         (ada_add_global_exceptions): Use objfile_compunits.
11535
11536 2019-01-09  Tom Tromey  <tom@tromey.com>
11537
11538         * source.c (select_source_symtab)
11539         (forget_cached_source_info_for_objfile): Remove declaration.
11540         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11541         declaration.
11542         * maint.c (count_symtabs_and_blocks): Remove declaration.
11543         * cp-support.c (add_symbol_overload_list_qualified): Remove
11544         declaration.
11545         * coffread.c (coff_symtab_read): Remove declaration.
11546         * symtab.c (lookup_symbol_in_objfile_symtabs)
11547         (basic_lookup_transparent_type_1): Use objfile_compunits.
11548         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11549         (info_sources_command, search_symbols)
11550         (default_collect_symbol_completion_matches_break_on)
11551         (make_source_files_completion_list): Remove declaration.
11552         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11553         (ada_collect_symbol_completion_matches)
11554         (ada_add_global_exceptions): Remove declaration.
11555         * linespec.c (iterate_over_all_matching_symtabs): Use
11556         objfile_compunits.
11557         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11558         (class objfile_compunits): New.
11559         (ALL_COMPUNITS): Use objfile_compunits.
11560         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11561         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11562         objfile_compunits.
11563         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11564
11565 2019-01-09  Tom Tromey  <tom@tromey.com>
11566
11567         * symtab.c (search_symbols)
11568         (default_collect_symbol_completion_matches_break_on): Use
11569         objfile_msymbols.
11570         * ada-lang.c (ada_lookup_simple_minsym)
11571         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11572         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11573         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11574         objfile_msymbols.
11575         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11576         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11577         * objc-lang.c (find_methods): Use objfile_msymbols.
11578         (info_selectors_command, info_classes_command): Likewise.
11579         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11580         * objfiles.h (class objfile_msymbols): New.
11581         (ALL_OBJFILE_MSYMBOLS): Remove.
11582         (ALL_MSYMBOLS): Remove.
11583
11584 2019-01-09  Tom Tromey  <tom@tromey.com>
11585
11586         * common/next-iterator.h (next_adapter): Add Iterator template
11587         parameter.
11588         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11589         (class all_objfiles_safe): New.
11590         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11591         * objfiles.c (put_objfile_before): Update comment.
11592         (add_separate_debug_objfile): Likewise.
11593         (free_all_objfiles): Use all_objfiles_safe.
11594         (objfile_purge_solibs): Likewise.
11595
11596 2019-01-09  Tom Tromey  <tom@tromey.com>
11597
11598         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11599         (expand_symtab_containing_pc, lookup_static_symbol)
11600         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11601         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11602         all_objfiles.
11603         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11604         * breakpoint.c (create_overlay_event_breakpoint)
11605         (create_longjmp_master_breakpoint)
11606         (create_std_terminate_master_breakpoint)
11607         (create_exception_master_breakpoint): Use all_objfiles.
11608         * linux-thread-db.c (try_thread_db_load_from_pdir)
11609         (has_libpthread): Use all_objfiles.
11610         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11611         * linespec.c (iterate_over_all_matching_symtabs)
11612         (search_minsyms_for_name): Use all_objfiles.
11613         * maint.c (maintenance_info_sections): Use all_objfiles.
11614         * main.c (captured_main_1): Use all_objfiles.
11615         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11616         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11617         * guile/scm-pretty-print.c
11618         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11619         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11620         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11621         (maintenance_print_msymbols): Use all_objfiles.
11622         * source.c (select_source_symtab): Use all_objfiles.
11623         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11624         * symfile.c (remove_symbol_file_command)
11625         (expand_symtabs_matching, map_symbol_filenames): Use
11626         all_objfiles.
11627         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11628         all_objfiles.
11629         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11630         * objc-lang.c (find_methods): Use all_objfiles.
11631         * objfiles.c (have_partial_symbols, have_full_symbols)
11632         (have_minimal_symbols, qsort_cmp)
11633         (default_iterate_over_objfiles_in_search_order): Use
11634         all_objfiles.
11635         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11636         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11637         (maintenance_check_psymtabs): Use all_objfiles.
11638         (ALL_PSYMTABS): Remove.
11639         * compile/compile-object-run.c (do_module_cleanup): Use
11640         all_objfiles.
11641         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11642         * cp-support.c (add_symbol_overload_list_qualified): Use
11643         all_objfiles.
11644         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11645         Use all_objfiles.
11646         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11647         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11648         all_objfiles.
11649         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11650         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11651         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11652         Uses all_objfiles.
11653         * solib.c (solib_read_symbols): Use all_objfiles
11654
11655 2019-01-09  Tom Tromey  <tom@tromey.com>
11656
11657         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11658         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11659         all_objfiles.
11660         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11661         * symmisc.c (print_symbol_bcache_statistics)
11662         (print_objfile_statistics, maintenance_print_objfiles)
11663         (maintenance_info_symtabs, maintenance_check_symtabs)
11664         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11665         all_objfiles.
11666         * source.c (forget_cached_source_info): Use all_objfiles.
11667         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11668         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11669         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11670         * objfiles.c (update_section_map): Use all_objfiles.
11671         (shared_objfile_contains_address_p): Likewise.
11672         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11673         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11674
11675 2019-01-09  Tom Tromey  <tom@tromey.com>
11676
11677         * common/next-iterator.h: New file.
11678         * objfiles.h (class all_objfiles): New.
11679         (struct objfile_iterator): New.
11680
11681 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11682
11683         * NEWS: Move the description of the changed "frame", "select-frame",
11684          and "info frame" commands to the Changed commands section.
11685
11686 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11687
11688         * gdbtypes.c (check_stub_method_group): Remove handling of old
11689         mangling schemes.
11690         * linespec.c (find_methods): Likewise.
11691         * stabsread.c (read_member_functions): Likewise.
11692         * valops.c (search_struct_method): Likewise.
11693         (value_struct_elt_for_reference): Likewise.
11694         * NEWS: Mention this change.
11695
11696 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11697
11698         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11699         print_source_lines.
11700         * source.c (print_source_lines_base): Update line number check.
11701         (print_source_lines): New function.
11702         (source_lines_range::source_lines_range): New function.
11703         * source.h (class source_lines_range): New class.
11704         (print_source_lines): New declaration.
11705
11706 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11707
11708         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11709
11710 2019-01-08  Tom Tromey  <tom@tromey.com>
11711             Simon Marchi  <simon.marchi@ericsson.com>
11712
11713         PR gdb/24060
11714         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11715         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11716         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11717         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11718         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11719         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11720
11721 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11722
11723         * source.c (select_source_symtab): Move header comment to
11724         declaration in source.h.
11725         (forget_cached_source_info_for_objfile): Likewise.
11726         (forget_cached_source_info): Likewise.
11727         (identify_source_line): Likewise.
11728         * source.h (identify_source_line): Move declaration from symtab.h
11729         and add comment from source.c
11730         (print_source_lines): Likewise.
11731         (forget_cached_source_info_for_objfile): Likewise.
11732         (forget_cached_source_info): Likewise.
11733         (select_source_symtab): Likewise.
11734         (enum print_source_lines_flag): Move definition from symtab.h.
11735         * symtab.h (identify_source_line): Move declaration to source.h.
11736         (print_source_lines): Likewise.
11737         (forget_cached_source_info_for_objfile): Likewise.
11738         (forget_cached_source_info): Likewise.
11739         (select_source_symtab): Likewise.
11740         (enum print_source_lines_flag): Move definition to source.h.
11741         * tui/tui-hooks.c: Add 'source.h' include.
11742
11743 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11744
11745         * source.c (print_source_lines_base): Handle requests to print
11746         reverse line number sequences, and guard against empty lines
11747         string.
11748
11749 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11750
11751         * source.c (print_source_lines_base): Fix skip of '\r' if next
11752         character is '\n'.
11753
11754 2019-01-06  Tom Tromey  <tom@tromey.com>
11755
11756         * c-exp.y (struct c_parse_state) <macro_original_text,
11757         expansion_obstack>: New member.
11758         (macro_original_text, expansion_obstack): Remove globals.
11759         (scan_macro_expansion, scanning_macro_expansion)
11760         (finished_macro_expansion): Update.
11761         (scan_macro_cleanup): Remove.
11762         (yylex, c_parse): Update.
11763
11764 2019-01-06  Tom Tromey  <tom@tromey.com>
11765
11766         * c-exp.y (struct c_parse_state) <strings>: New member.
11767         (operator_stoken): Update.
11768
11769 2019-01-06  Tom Tromey  <tom@tromey.com>
11770
11771         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11772         (union type_stack_elt) <typelist_val>: Now a pointer to
11773         std::vector.
11774         (type_stack_cleanup): Don't declare.
11775         (push_typelist): Update.
11776         * parse.c (pop_typelist): Return a std::vector.
11777         (push_typelist): Take a std::vector.
11778         (follow_types): Update.  Do not free args.
11779         (type_stack_cleanup): Remove.
11780         * c-exp.y (struct c_parse_state): New.
11781         (cpstate): New global.
11782         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11783         (nonempty_typelist): Update.
11784         (func_mod): Create a new vector.
11785         (c_parse): Create a c_parse_state.
11786         (check_parameter_typelist): Do not delete params.
11787         (function_method): Update.  Do not delete type_list.
11788
11789 2019-01-06  Tom Tromey  <tom@tromey.com>
11790
11791         PR gdb/28155:
11792         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11793         check_typedef.
11794         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11795         (print_return_value): Likewise.
11796
11797 2019-01-05  Tom Tromey  <tom@tromey.com>
11798
11799         * contrib/cleanup_check.py: Remove.
11800         * contrib/gcc-with-excheck: Remove.
11801         * contrib/exsummary.py: Remove.
11802         * contrib/excheck.py: Remove.
11803
11804 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11805
11806         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11807         NULL. Initialize tpprev to NULL instead of assigning it
11808         to NULL on the next statement.
11809         * windows-nat.c (windows_delete_thread): Remove check for
11810         main_thread_id before printing thread exit notifications.
11811         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11812         Remove thread ID check against main_thread_id.
11813         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11814         windows_delete_thread.
11815         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11816
11817 2019-01-04  Tom Tromey  <tom@tromey.com>
11818
11819         * compile/compile.c (_initialize_compile): Use upper case for
11820         metasyntactic variables.
11821         * symmisc.c (_initialize_symmisc): Use upper case for
11822         metasyntactic variables.
11823         * psymtab.c (_initialize_psymtab): Use upper case for
11824         metasyntactic variables.
11825         * demangle.c (demangle_command): Use upper case for metasyntactic
11826         variables.
11827         (_initialize_demangler): Likewise.
11828         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11829         variables.
11830
11831 2019-01-03  Tom Tromey  <tom@tromey.com>
11832
11833         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11834
11835 2019-01-03  Tom Tromey  <tom@tromey.com>
11836
11837         * python/py-symtab.c (salpy_str): Update.
11838         (struct salpy_sal_object) <symtab>: Now a PyObject.
11839         (salpy_dealloc): Update.
11840         (del_objfile_sal): Use gdbpy_ref.
11841
11842 2019-01-03  Tom Tromey  <tom@tromey.com>
11843
11844         * python/py-type.c (convert_field): Use new_reference.  Return
11845         gdbpy_ref.
11846         (make_fielditem): Return gdbpy_ref.
11847         (typy_fields): Update.
11848         (typy_getitem): Update.
11849         (field_name): Return gdbpy_ref.  Use new_reference.
11850         (typy_iterator_iternext): Update.
11851
11852 2019-01-03  Tom Tromey  <tom@tromey.com>
11853
11854         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11855
11856 2019-01-03  Tom Tromey  <tom@tromey.com>
11857
11858         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11859         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11860         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11861         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11862         (pspy_set_type_printers): Likewise.
11863         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11864         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11865         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11866         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11867         (objfpy_set_type_printers): Likewise.
11868
11869 2019-01-03  Tom Tromey  <tom@tromey.com>
11870
11871         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11872         (gdbpy_print_stack): Use gdbpy_err_fetch.
11873         * python/python-internal.h (class gdbpy_err_fetch): New class.
11874         (class gdbpy_enter) <m_error_type, m_error_value,
11875         m_error_traceback>: Remove.
11876         <m_error>: New member.
11877         (gdbpy_exception_to_string): Don't declare.
11878         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11879         * python/py-value.c (convert_value_from_python): Use
11880         gdbpy_err_fetch.
11881         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11882         gdbpy_exception_to_string.
11883         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11884         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11885         gdbpy_err_fetch.
11886
11887 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11888
11889         * linux-nat.c (delete_lwp_cleanup): Delete.
11890         (struct lwp_deleter): New struct.
11891         (lwp_info_up): New typedef.
11892         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11893         lwp_info_up.
11894
11895 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11896
11897         * linux-fork.c (class scoped_switch_fork_info): New class.
11898         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11899
11900 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11901
11902         * valops.c (find_overload_match): Remove use of null_cleanup, and
11903         calls to do_cleanups.
11904
11905 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11906
11907         * compile/compile-cplus-types.c
11908         (compile_cplus_instance::decl_name): Handle changes to
11909         cp_func_name.
11910         * cp-support.c (cp_func_name): Update header comment, update
11911         return type.
11912         * cp-support.h (cp_func_name): Update return type in declaration.
11913         * valops.c (find_overload_match): Move temp_func local to top
11914         level of function and change its type.  Use temp_func to hold and
11915         delete temporary string obtained from cp_func_name.
11916
11917 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11918
11919         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11920         gdb::char_vector, remove cleanup, and update uses of `msg`.
11921
11922 2019-01-03  Jim Wilson  <jimw@sifive.com>
11923
11924         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11925
11926 2019-01-02  Tom Tromey  <tom@tromey.com>
11927
11928         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11929         (tdesc_parse_xml): Remove cleanups.
11930         * target-descriptions.h (make_cleanup_free_target_description):
11931         Don't declare.
11932         (target_desc_deleter): New struct.
11933         (target_desc_up): New typedef.
11934         * target-descriptions.c (target_desc_deleter::operator()): Rename
11935         from free_target_description.
11936         (make_cleanup_free_target_description): Remove.
11937
11938 2019-01-02  Tom Tromey  <tom@tromey.com>
11939
11940         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11941         constructor, destructor.
11942         (linespec_parser): Remove typedef.
11943         (~linespec_parser): Rename from linespec_parser_delete.
11944         (linespec_lex_to_end, linespec_complete_label)
11945         (linespec_complete): Update.
11946         (decode_line_full): Remove cleanups.
11947         (decode_line_1): Update.
11948
11949 2019-01-02  Tom Tromey  <tom@tromey.com>
11950
11951         * python/python-internal.h (inferior_to_inferior_object): Change
11952         return type.
11953         * python/py-exitedevent.c (create_exited_event_object): Update.
11954         * python/py-inferior.c (inferior_to_inferior_object): Return
11955         gdbpy_ref.
11956         (python_new_inferior, python_inferior_deleted)
11957         (thread_to_thread_object, delete_thread_object)
11958         (build_inferior_list, gdbpy_selected_inferior): Update.
11959         * python/py-infthread.c (create_thread_object): Update.  Also fail
11960         if inferior_to_inferior_object fails.
11961
11962 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11963
11964         * inferior.h (class inferior) <displaced_step_state>: New field.
11965         * infrun.h (struct displaced_step_state): Move here from
11966         infrun.c.  Initialize fields, add constructor.
11967         <inf>: Remove field.
11968         <reset>: New method.
11969         * infrun.c (struct displaced_step_inferior_state): Move to
11970         infrun.h.
11971         (displaced_step_inferior_states): Remove.
11972         (get_displaced_stepping_state): Adust.
11973         (displaced_step_in_progress_any_inferior): Adjust.
11974         (displaced_step_in_progress_thread): Adjust.
11975         (displaced_step_in_progress): Adjust.
11976         (add_displaced_stepping_state): Remove.
11977         (get_displaced_step_closure_by_addr): Adjust.
11978         (remove_displaced_stepping_state): Remove.
11979         (infrun_inferior_exit): Call displaced_step_state.reset.
11980         (use_displaced_stepping): Don't check for NULL.
11981         (displaced_step_prepare_throw): Call
11982         get_displaced_stepping_state.
11983         (displaced_step_fixup): Don't check for NULL.
11984         (prepare_for_detach): Don't check for NULL.
11985
11986 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11987
11988         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11989          in case of call that did not complete.
11990
11991 2019-01-02  Andrey Utkin  <autkin@undo.io>
11992
11993         * symfile.c (find_separate_debug_file): Fix search of debug files for
11994         remote debuggee.
11995
11996 2019-01-02  Tom Tromey  <tom@tromey.com>
11997
11998         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11999         indentation.
12000         * python/py-frame.c (frapy_older): Remove cast.
12001         (frapy_newer): Likewise.
12002         * python/py-breakpoint.c (local_setattro): Remove cast.
12003         * python/py-arch.c (archpy_name): Remove local variable.
12004         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12005
12006 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12007
12008         * unittests/basic_string_view/element_access/char/empty.cc:
12009         Fix year range in copyright header.
12010
12011 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12012
12013         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12014         Delete.
12015         <operator==>: Update with for removed field.
12016         <hash>: Likewise.
12017         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12018         <isa_features>: ...this.
12019         <abi_features>: New field.
12020         (riscv_isa_flen): Update comment.
12021         (riscv_abi_xlen): New declaration.
12022         (riscv_abi_flen): New declaration.
12023         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12024         isa_features.
12025         (riscv_abi_xlen): New function.
12026         (riscv_isa_flen): Update to get answer from isa_features.
12027         (riscv_abi_flen): New function.
12028         (riscv_has_fp_abi): Update to get answer from abi_features.
12029         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12030         xlen and flen.
12031         (riscv_call_info) <xlen, flen>: Update comment.
12032         (riscv_call_arg_struct): Remove invalid assertions
12033         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12034         is removed.
12035         (riscv_gdbarch_init): Gather isa features and abi features
12036         separately, ensure both match on the gdbarch when reusing an old
12037         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12038         a target with 64-bit float hardware.
12039
12040 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12041
12042         * source.c (search_command_helper): Stop reverse search
12043         when line 1 has been searched.
12044
12045 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12046
12047         * record-full.c (record_full_base_target::close): Rewrite
12048         record_full_core_buf_list free logic.
12049
12050 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12051
12052         * break-catch-syscall.c (print_one_catch_syscall): xfree
12053         the last text.
12054
12055 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12056
12057         * top.c (print_gdb_version): Update Copyright year in version
12058         message.
12059
12060 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12061
12062         Update copyright year range in all GDB files.
12063
12064 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12065
12066         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12067
12068 For older changes see ChangeLog-2018.
12069 \f
12070 Local Variables:
12071 mode: change-log
12072 left-margin: 8
12073 fill-column: 74
12074 version-control: never
12075 coding: utf-8
12076 End:
12077