gdb/ChangeLog

   1 2019-08-30  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
   4         set_locator_fullname>: New methods.
   5         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
   6         Rename from tui_set_locator_fullname.
   7         (tui_locator_window::set_locator_info): Rename from
   8         tui_set_locator_info.  Return bool.
   9         (tui_update_locator_fullname, tui_show_frame_info): Update.
  10
  11 2019-08-30  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
  14
  15 2019-08-30  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
  18         call touchwin.
  19
  20 2019-08-30  Tom Tromey  <tom@tromey.com>
  21
  22         * tui/tui-wingeneral.c (box_win): Assume win_info and
  23         win_info->handle cannot be NULL.
  24
  25 2019-08-30  Tom Tromey  <tom@tromey.com>
  26
  27         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
  28         refresh_window>: Declare.
  29         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
  30         resize.
  31         (tui_data_item_window::rerender): Rename from
  32         tui_display_register.
  33         (tui_data_item_window::refresh_window): New method.
  34         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
  35         no-op.
  36
  37 2019-08-30  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui-regs.h (struct tui_data_window) <regs_content,
  40         regs_column_count, current_group>: Move later.  Now private.
  41         <get_current_group>: New method.
  42         * tui/tui-regs.c (tui_reg_command): Update.
  43         * tui/tui-layout.c (tui_set_layout): Update.
  44
  45 2019-08-30  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
  48         (tui_data_window::rerender): Don't call
  49         check_and_display_highlight_if_needed.
  50         (tui_data_window::refresh_all): Remove call to
  51         erase_data_content.
  52
  53 2019-08-30  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
  56         (tui_data_window::display_registers_from)
  57         (tui_data_window::display_reg_element_at_line)
  58         (tui_data_window::display_registers_from_line): Remove checks of
  59         "empty".
  60
  61 2019-08-30  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
  64         Don't declare.
  65         * tui/tui-regs.c (tui_data_window::show_registers): Call
  66         rerender.
  67         (tui_data_window::rerender): Rename from display_all_data.
  68         (tui_data_window::rerender): Remove old implementation.
  69
  70 2019-08-30  Tom Tromey  <tom@tromey.com>
  71
  72         * tui/tui-regs.c (tui_data_window::display_all_data): Change
  73         text.
  74         * tui/tui-data.h (NO_DATA_STRING): Remove define.
  75
  76 2019-08-29  Bernhard Wodok  <barto@gmx.net>
  77             Sergio Durigan Junior  <sergiodj@redhat.com>
  78
  79         PR win32/24284
  80         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
  81
  82 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  83
  84         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
  85         when searching for types.
  86
  87 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  88
  89         * f-lang.c (f_language_defn): Use f_print_typedef.
  90         * f-lang.h (f_print_typedef): Declare.
  91         * f-typeprint.c (f_print_typedef): Define.
  92
  93 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
  94
  95         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
  96
  97 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  98
  99         * cli/cli-utils.c (info_print_options_defs): Delete.
 100         (make_info_print_options_def_group): Delete.
 101         (extract_info_print_options): Delete.
 102         (info_print_command_completer): Delete.
 103         (info_print_args_help): Add extra parameter, and optionally
 104         include text about -n flag.
 105         * cli/cli-utils.h (struct info_print_options): Delete.
 106         (extract_info_print_options): Delete declaration.
 107         (info_print_command_completer): Delete declaration.
 108         (info_print_args_help): Add extra parameter, extend header
 109         comment.
 110         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 111         search_symbols.
 112         * stack.c (struct info_print_options): New type.
 113         (info_print_options_defs): New file scoped variable.
 114         (make_info_print_options_def_group): New static function.
 115         (info_print_command_completer): New static function.
 116         (info_locals_command): Update to use new local functions.
 117         (info_args_command): Likewise.
 118         (_initialize_stack): Add extra parameter to calls to
 119         info_print_args_help.
 120         * symtab.c (search_symbols): Add extra parameter, use this to
 121         possibly excluse non-debug symbols.
 122         (symtab_symbol_info): Add extra parameter, which is passed on to
 123         search_symbols.
 124         (struct info_print_options): New type.
 125         (info_print_options_defs): New file scoped variable.
 126         (make_info_print_options_def_group): New static function.
 127         (info_print_command_completer): New static function.
 128         (info_variables_command): Update to use local functions, and pass
 129         extra parameter through to symtab_symbol_info.
 130         (info_functions_command): Likewise.
 131         (info_types_command): Pass additional argument through to
 132         symtab_symbol_info.
 133         (rbreak_command): Pass extra argument to search_symbols.
 134         (_initialize_symtab): Add extra arguments for calls to
 135         info_print_args_help, and update help text for 'info variables',
 136         'whereis', and 'info functions' commands.
 137         * symtab.h (search_symbols): Add extra argument to declaration.
 138         * NEWS: Mention new flags.
 139
 140 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 141
 142         * symtab.c (lookup_static_symbol): Call the new function (and move
 143         it down to be next to lookup_global_symbol).
 144         (struct global_sym_lookup_data): Add block_enum member and rename to...
 145         (struct global_or_static_sym_lookup_data): ...this.
 146         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 147         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 148         (lookup_symbol_global_or_static_iterator_cb): ...this.
 149         (lookup_global_or_static_symbol): New function.
 150         (lookup_global_symbol): Call new function.
 151
 152 2019-08-26  Tom de Vries  <tdevries@suse.de>
 153
 154         PR c++/24852
 155         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 156         when pc_probe.prob == NULL.
 157
 158 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 159
 160         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 161         variable symbol_linkage to symbol_linkage_.
 162
 163 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 164
 165         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 166         represent whether the symbol is static, dynamic, or we don't
 167         know.
 168
 169 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 170
 171         * gdb/rx-tdep.c (rx_register_names): New.
 172         (rx_register_name): Delete.
 173         (rx_psw_type): Delete.
 174         (rx_fpsw_type): Delete.
 175         (rx_register_type): Delete.
 176         (rx_gdbarch_init): Convert target-descriptions.
 177         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 178         * gdb/features/Makefile: Add rx.xml.
 179         * gdb/features/rx.xml: New.
 180         * gdb/features/rx.c: Generated.
 181         * gdb/NEWS: Mention target description support.
 182
 183 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 184
 185         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 186         *slot_ptr.
 187
 188 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 189
 190         * configure.ac: Don't check for 'dlfcn.h' (moved to
 191         gdbsupport/common.m4).
 192         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 193         'gdbsupport/'.
 194         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 195         * compile/compile-c-support.c: Include
 196         'gdbsupport/gdb-dlfcn.h'.
 197         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 198         * gdb-dlfcn.c: Move to...
 199         * gdbsupport/gdb-dlfcn.c: ... here.
 200         * gdb-dlfcn.h: Move to...
 201         * gdbsupport/gdb-dlfcn.h: ... here.
 202
 203 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 204
 205         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 206         the offset field signed.
 207
 208 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 209
 210         * python/lib/gdb/__init__.py (_execute_file): New function.
 211         * python/python.c (python_run_simple_file): Call gdb._execute_file
 212         on Windows.
 213
 214 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 215
 216         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 217         all uses as this was never set to anything but a zero value.
 218
 219 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 220
 221         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 222
 223 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 224
 225         * tui/tui-data.h (tui_gen_win_info): Add an =default
 226         move constructor, required by some GCC versions.
 227
 228 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 229
 230         * go32-nat.c (go32_sysinfo): Add hygon_p.
 231
 232 2019-08-20  Tom Tromey  <tom@tromey.com>
 233
 234         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 235         line_from_reg_element_no, first_reg_element_no_inline,
 236         display_all_data, delete_data_content_windows,
 237         erase_data_content>: Now private.
 238
 239 2019-08-20  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 242         (tui_unhighlight_win, tui_highlight_win)
 243         (tui_win_info::make_window): Update.
 244         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 245
 246 2019-08-20  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 249         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 250         (MAX_PID_WIDTH): Move to tui-stack.c.
 251         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 252         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 253         (MAX_PID_WIDTH): Move from tui-data.h.
 254
 255 2019-08-20  Tom Tromey  <tom@tromey.com>
 256
 257         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 258         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 259         (box_win): Update.
 260         (tui_gen_win_info::make_window): Rename from tui_make_window.
 261         (tui_win_info::make_window): New method.
 262         (tui_gen_win_info::make_visible): Update.
 263         * tui/tui-source.c (tui_source_window::set_contents): Update.
 264         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 265         (tui_data_window::display_registers_from): Update.
 266         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 267         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 268         Declare.
 269         <can_box>: Remove.
 270         <title>: Remove.
 271         (struct tui_win_info) <make_window>: Declare.
 272         <can_box>: Now virtual.
 273         <title>: New member.
 274         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 275         * tui/tui-command.c (tui_cmd_window::resize): Update.
 276
 277 2019-08-20  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 280         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 281         (tui_data_window::check_register_values): Update.
 282
 283 2019-08-20  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-regs.h (struct tui_data_window): Use
 286         DISABLE_COPY_AND_ASSIGN.
 287         <regs_content>: Change type, removing unique_ptr.
 288         <tui_data_window>: Add move constructor.
 289         * tui/tui-regs.c (tui_data_window::show_registers)
 290         (tui_data_window::show_register_group)
 291         (tui_data_window::display_registers_from)
 292         (tui_data_window::display_registers_from)
 293         (tui_data_window::first_data_item_displayed)
 294         (tui_data_window::delete_data_content_windows)
 295         (tui_data_window::rerender, tui_data_window::refresh_window)
 296         (tui_data_window::check_register_values): Update.
 297
 298 2019-08-20  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 301         show_register_group>: Declare.
 302         (tui_show_register_group): Don't declare.
 303         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 304         tui_show_registers.
 305         (tui_data_window::show_register_group): Rename from
 306         tui_show_register_group.
 307         (tui_data_window::check_register_values, tui_reg_command):
 308         Update.
 309         * tui/tui-layout.c (tui_set_layout): Update.
 310
 311 2019-08-20  Tom Tromey  <tom@tromey.com>
 312
 313         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 314         Declare.
 315         (tui_check_register_values): Don't declare.
 316         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 317         from tui_check_register_values.
 318         * tui/tui-hooks.c (tui_register_changed): Update.
 319
 320 2019-08-20  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-regs.c (tui_reg_layout): Move later.
 323         (tui_show_registers): Don't enable TUI mode or change layout.
 324
 325 2019-08-20  Tom Tromey  <tom@tromey.com>
 326
 327         * tui/tui-regs.h (struct tui_data_item_window)
 328         <~tui_data_item_window>: Remove.
 329         <content>: Now a unique_xmalloc_ptr.
 330         * tui/tui-regs.c (tui_register_format): Return a
 331         unique_xmalloc_ptr.
 332         (tui_get_register): Update.
 333         (~tui_data_item_window): Remove.
 334         (tui_data_window::display_registers_from, tui_display_register):
 335         Update.
 336         * tui/tui-io.h (tui_expand_tabs): Update.
 337         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 338         Remove "col" parameter.
 339
 340 2019-08-20  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 343         field.
 344         * tui/tui-regs.c (~tui_data_item_window): Update.
 345
 346 2019-08-20  Tom Tromey  <tom@tromey.com>
 347
 348         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 349         earlier.
 350
 351 2019-08-20  Tom Tromey  <tom@tromey.com>
 352
 353         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 354
 355 2019-08-20  Tom Tromey  <tom@tromey.com>
 356
 357         * tui/tui-source.h (struct tui_source_window): Update.
 358         * tui/tui-regs.c (tui_show_registers): Update.
 359         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 360         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 361         (NO_REGS_STRING): Remove defines.
 362
 363 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 364
 365         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 366         unnecessary thread walk if remote doesn't support the packet.
 367
 368 2019-08-19  Tom Tromey  <tromey@adacore.com>
 369
 370         * python/py-value.c (value_has_field): Fix indentation.
 371
 372 2019-08-19  Tom Tromey  <tromey@adacore.com>
 373
 374         * printcmd.c (do_one_display, info_display_command): Update.
 375         * block.h (contained_in): Return bool.  Add allow_nested
 376         parameter.
 377         * block.c (contained_in): Return bool.  Add allow_nested
 378         parameter.
 379
 380 2019-08-19  Tom Tromey  <tom@tromey.com>
 381
 382         * configure: Rebuild.
 383         * configure.ac: Disallow the combination of -static-libstdc++ and
 384         source highlight.
 385         * source-cache.c (get_language_name): Handle rust.
 386         (source_cache::get_source_lines): Ignore highlighting exceptions.
 387
 388 2019-08-16  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 391         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 392         (struct tui_source_window_base) <make_visible, refresh_window,
 393         resize>: Remove methods.
 394         <execution_info>: Remove field.
 395         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 396         (tui_show_source_line, tui_source_window_base)
 397         (~tui_source_window_base): Update.
 398         (tui_source_window_base::resize)
 399         (tui_source_window_base::make_visible)
 400         (tui_source_window_base::refresh_window): Remove.
 401         (tui_source_window_base::update_exec_info): Update.
 402         * tui/tui-source.c (tui_source_window::set_contents): Update.
 403         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 404
 405 2019-08-16  Tom Tromey  <tom@tromey.com>
 406
 407         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 408         deprecated_query_hook.
 409
 410 2019-08-16  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 413         (tui_update_source_windows_with_line): Update.
 414         * tui/tui-source.h (struct tui_source_window)
 415         <show_symtab_source>: Declare.
 416         (tui_show_symtab_source): Don't declare.
 417         * tui/tui-source.c (tui_show_symtab_source): Rename from
 418         tui_show_symtab_source.
 419
 420 2019-08-16  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-winsource.h (struct tui_source_window_base)
 423         <set_contents>: Declare.
 424         * tui/tui-winsource.c
 425         (tui_source_window_base::update_source_window_as_is): Update.
 426         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 427         Declare.
 428         (tui_set_source_content): Don't declare.
 429         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 430         tui_set_source_content.
 431         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 432         Declare.
 433         (tui_set_disassem_content): Don't declare.
 434         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 435         tui_set_disassem_content.
 436
 437 2019-08-16  Tom Tromey  <tom@tromey.com>
 438
 439         * tui/tui-winsource.h (struct tui_source_window_base)
 440         <update_breakpoint_info>: Declare.
 441         (tui_update_breakpoint_info): Don't declare.
 442         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 443         (tui_update_all_breakpoint_info): Update.
 444         (tui_source_window_base::update_breakpoint_info): Rename from
 445         tui_update_breakpoint_info.
 446         (tui_source_window_base::update_exec_info): Update.
 447
 448 2019-08-16  Tom Tromey  <tom@tromey.com>
 449
 450         * tui/tui-winsource.h (struct tui_source_window_base)
 451         <update_source_window>: Declare.
 452         (tui_update_source_window): Don't declare.
 453         * tui/tui-winsource.c
 454         (tui_source_window_base::update_source_window): Rename from
 455         tui_update_source_window.
 456         (tui_source_window_base::rerender): Update.
 457         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 458         * tui/tui-disasm.c (tui_show_disassem)
 459         (tui_show_disassem_and_update_source)
 460         (tui_disasm_window::maybe_update): Update.
 461
 462 2019-08-16  Tom Tromey  <tom@tromey.com>
 463
 464         * tui/tui-winsource.h (struct tui_source_window_base)
 465         <update_source_window_as_is>: Declare.
 466         (tui_update_source_window_as_is): Don't declare.
 467         * tui/tui-winsource.c (tui_update_source_window): Update
 468         (tui_source_window_base::update_source_window_as_is): Rename from
 469         tui_update_source_window_as_is.
 470         (tui_source_window_base::refill): Update.
 471         * tui/tui-source.c (tui_show_symtab_source): Update.
 472         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 473         Update.
 474
 475 2019-08-16  Tom Tromey  <tom@tromey.com>
 476
 477         * tui/tui-winsource.h (tui_update_source_window)
 478         (tui_update_source_window_as_is): Remove "noerror" parameter.
 479         * tui/tui-winsource.c (tui_update_source_window)
 480         (tui_update_source_window_as_is): Remove "noerror" parameter.
 481         (tui_update_source_windows_with_addr)
 482         (tui_update_source_windows_with_line)
 483         (tui_source_window_base::rerender)
 484         (tui_source_window_base::refill): Update.
 485         * tui/tui-source.h (tui_set_source_content)
 486         (tui_show_symtab_source): Remove "noerror" parameter.
 487         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 488         parameter.
 489         (tui_show_symtab_source): Likewise.
 490         (tui_source_window::maybe_update): Update.
 491         * tui/tui-disasm.c (tui_show_disassem)
 492         (tui_show_disassem_and_update_source)
 493         (tui_disasm_window::do_scroll_vertical)
 494         (tui_disasm_window::maybe_update): Update.
 495
 496 2019-08-16  Tom Tromey  <tom@tromey.com>
 497
 498         * tui/tui.c (tui_is_window_visible): Update.
 499         * tui/tui-wingeneral.c (tui_make_window)
 500         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 501         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 502         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 503         (tui_set_win_height_command, parse_scrolling_args): Update.
 504         * tui/tui-source.c (tui_source_window::style_changed): Update.
 505         * tui/tui-regs.c (tui_show_registers)
 506         (tui_data_window::first_data_item_displayed)
 507         (tui_data_window::delete_data_content_windows)
 508         (tui_check_register_values, tui_reg_command): Update.
 509         * tui/tui-disasm.c (tui_show_disassem): Update.
 510         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 511         method.
 512         <is_visible>: Remove field.
 513         * tui/tui-data.c (tui_next_win, tui_prev_win)
 514         (tui_delete_invisible_windows): Update.
 515
 516 2019-08-16  Tom Tromey  <tom@tromey.com>
 517
 518         * tui/tui-winsource.h (struct tui_source_window_base)
 519         <m_has_locator>: Remove.
 520         * tui/tui-layout.c (show_source_disasm_command, show_data)
 521         (show_source_or_disasm_and_command): Update.
 522
 523 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 524
 525         * NEWS (Other MI changes): New subsection.
 526         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 527         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 528         * arch-utils.c (default_get_pc_address_flags): New function.
 529         * arch-utils.h (default_get_pc_address_flags): New declaration.
 530         * gdbarch.sh: Add get_pc_address_flags.
 531         * gdbarch.c: Regenerate.
 532         * gdbarch.h: Likewise.
 533         * stack.c (print_pc): New function.
 534         (print_frame_info) (print_frame): Call print_pc.
 535
 536 2019-08-16  Tom de Vries  <tdevries@suse.de>
 537
 538         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 539         print_objfile_section_info.
 540
 541 2019-08-15  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 544         calling update_cmdwin_start_line.
 545         * tui/tui-winsource.h (struct tui_source_window_base)
 546         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 547         <rerender>: Declare.
 548         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 549         Call rerender.
 550         (tui_source_window_base::set_new_height): Remove.
 551         (tui_source_window_base::rerender): Rename from
 552         do_make_visible_with_new_height.
 553         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 554         resize method.
 555         (tui_win_info::make_invisible_and_set_new_height)
 556         (tui_win_info::make_visible_with_new_height): Remove.
 557         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 558         Declare.
 559         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 560         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 561         do_make_visible_with_new_height>: Don't declare.
 562         <rerender>: Declare.
 563         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 564         set_new_height.
 565         (tui_data_window::do_make_visible_with_new_height): Remove.
 566         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 567         call tui_show_locator_content.
 568         (tui_gen_win_info::resize): Call rerender.
 569         (show_source_or_disasm_and_command): Don't call
 570         tui_show_locator_content.
 571         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 572         method.
 573         (struct tui_win_info) <rerender>: Declare.
 574         <set_new_height, make_invisible_and_set_new_height,
 575         make_visible_with_new_height>: Don't declare.
 576         * tui/tui-data.c (tui_win_list::rerender): New method.
 577         * tui/tui-command.h (struct tui_cmd_window)
 578         <do_make_visible_with_new_height>: Don't declare.
 579         * tui/tui-command.c
 580         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 581
 582 2019-08-15  Tom Tromey  <tromey@adacore.com>
 583
 584         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 585         * ada-lang.c (ada_enum_name): Likewise.
 586
 587 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 588
 589         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 590         leading underscore.
 591         (GdbOutputErrorFile): Likewise.
 592         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 593         accordingly.
 594         (execute_unwinders): Rename to have a leading underscore.
 595         (auto_load_packages): Likewise.
 596         (global scope): Adjust call to auto_load_packages accordingly.
 597         (GdbSetPythonDirectory): Likewise.
 598         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 599         instead of execute_unwinders.
 600
 601 2019-08-15  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 604         (show_data): Don't change window visibility.
 605         (tui_gen_win_info::resize): Remove special case for command
 606         window.  Use wresize, when available.
 607         (show_source_or_disasm_and_command): Don't change window
 608         visibility.
 609         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 610         <make_visible>: New method.
 611         * tui/tui-command.c (tui_cmd_window::resize): New method.
 612
 613 2019-08-15  Tom Tromey  <tom@tromey.com>
 614
 615         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 616         (struct tui_source_windows): New.
 617         * tui/tui-winsource.c (tui_display_main): Update.
 618         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 619         (new_height_ok, parse_scrolling_args): Update.
 620         * tui/tui-layout.c (show_layout, show_data): Update.
 621         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 622         (tui_add_to_source_windows): Don't declare.
 623         * tui/tui-data.c (source_windows, tui_source_windows)
 624         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 625
 626 2019-08-15  Tom Tromey  <tom@tromey.com>
 627
 628         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 629         Rename from reset.
 630         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 631         * tui/tui-layout.c (show_source_disasm_command, show_data):
 632         Update.
 633         (tui_gen_win_info::resize): Rename.
 634         (show_source_or_disasm_and_command): Update.
 635         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 636         reset.
 637
 638 2019-08-15  Tom Tromey  <tom@tromey.com>
 639
 640         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 641         * tui/tui-interp.c (tui_interp::init): Don't call
 642         tui_initialize_static_data.
 643         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 644
 645 2019-08-15  Tom Tromey  <tom@tromey.com>
 646
 647         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 648         examine tui_win_list.
 649
 650 2019-08-15  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 653         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 654         tui_clear_source_content.
 655         (tui_clear_source_content): Remove.
 656         (tui_source_window_base::do_erase_source_content): Hoist call to
 657         content.clear().
 658         * tui/tui-stack.c (tui_show_frame_info): Don't call
 659         tui_clear_source_content.
 660
 661 2019-08-15  Tom Tromey  <tom@tromey.com>
 662
 663         * tui/tui-winsource.h (struct tui_source_window_base)
 664         <do_erase_source_content>: New method.
 665         <erase_source_content>: New method.
 666         (tui_erase_source_content): Don't declare.
 667         * tui/tui-winsource.c (tui_clear_source_content): Update.
 668         (tui_source_window_base::do_erase_source_content): Rename from
 669         tui_erase_source_content.
 670         (tui_source_window_base::show_source_content): Update.
 671         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 672         * tui/tui-source.h (struct tui_source_window)
 673         <erase_source_content>: New method.
 674         * tui/tui-disasm.h (struct tui_disasm_window)
 675         <erase_source_content>: New method.
 676
 677 2019-08-15  Tom Tromey  <tom@tromey.com>
 678
 679         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 680         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 681         constructor.
 682         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 683         * tui/tui-source.c (tui_set_source_content): Update.
 684         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 685
 686 2019-08-15  Tom Tromey  <tom@tromey.com>
 687
 688         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 689         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 690         tui-source.c.
 691         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 692         Declare.
 693         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 694         method.
 695         (tui_source_window::maybe_update): Update.
 696
 697 2019-08-15  Tom Tromey  <tom@tromey.com>
 698
 699         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 700         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 701         tui-disasm.c.
 702         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 703         Declare.
 704         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 705         method.
 706         (tui_disasm_window::maybe_update): Update.
 707
 708 2019-08-15  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-winsource.h (struct tui_source_window_base)
 711         <maybe_update>: Declare.
 712         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 713         method.
 714         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 715         Declare.
 716         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 717         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 718         Declare.
 719         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 720
 721 2019-08-15  Tom Tromey  <tom@tromey.com>
 722
 723         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 724
 725 2019-08-15  Tom Tromey  <tom@tromey.com>
 726
 727         * tui/tui-wingeneral.c: Include tui-stack.h.
 728         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 729         (struct tui_locator_window): Move from tui-data.h.
 730         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 731         (tui_initialize_static_data): Move from tui-data.c.
 732         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 733         (struct tui_locator_window): Move to tui-stack.c.
 734         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 735         (tui_initialize_static_data): Move to tui-stack.c.
 736
 737 2019-08-15  Tom Tromey  <tom@tromey.com>
 738
 739         * tui/tui-layout.c (show_source_disasm_command)
 740         (show_source_or_disasm_and_command): Use make_visible method, not
 741         tui_make_window.
 742         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 743         Remove.
 744
 745 2019-08-15  Tom Tromey  <tom@tromey.com>
 746
 747         * tui/tui-wingeneral.h (tui_make_window): Update.
 748         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 749         parameter.
 750         (tui_gen_win_info::make_visible): Update.
 751         * tui/tui-regs.c (tui_data_window::display_registers_from):
 752         Update.
 753         * tui/tui-layout.c (show_source_disasm_command)
 754         (show_source_or_disasm_and_command): Update.
 755         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 756         (enum tui_box): Remove.
 757         (struct tui_win_info) <can_box>: New method.
 758         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 759         method.
 760
 761 2019-08-15  Tom de Vries  <tdevries@suse.de>
 762
 763         * linux-nat-trad.c: Include gdbarch.h.
 764
 765 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 766
 767         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 768         register sizes.
 769
 770 2019-08-14  Tom Tromey  <tromey@adacore.com>
 771
 772         * darwin-nat.c: Include gdbarch.h.
 773         * darwin-nat-info.c: Include gdbarch.h.
 774
 775 2019-08-13  Tom Tromey  <tom@tromey.com>
 776
 777         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 778         Remove.
 779         * tui/tui-data.c (tui_initialize_static_data): Update.
 780
 781 2019-08-13  Tom Tromey  <tom@tromey.com>
 782
 783         * tui/tui-winsource.h (struct tui_exec_info_window)
 784         <~tui_exec_info_window, maybe_allocate_content, get_content,
 785         m_content>: Remove.
 786         (struct tui_source_window_base) <set_exec_info_content,
 787         show_exec_info_content>: Don't declare.
 788         * tui/tui-winsource.c
 789         (tui_exec_info_window::maybe_allocate_content): Remove.
 790         (tui_source_window_base::update_exec_info): Rename from
 791         set_exec_info_content.
 792         (tui_source_window_base::show_exec_info_content)
 793         (tui_source_window_base::update_exec_info): Remove.
 794
 795 2019-08-13  Tom Tromey  <tom@tromey.com>
 796
 797         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 798         declare.
 799         * tui/tui-winsource.c (tui_update_source_window_as_is)
 800         (tui_update_source_windows_with_addr, tui_erase_source_content):
 801         Update.
 802         (tui_clear_exec_info_content): Remove.
 803
 804 2019-08-13  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 807         declare.
 808         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 809         call tui_erase_exec_info_content.
 810         (tui_clear_exec_info_content): Rename from
 811         tui_erase_exec_info_content.
 812         (tui_clear_exec_info_content): Delete.
 813
 814 2019-08-13  Tom Tromey  <tom@tromey.com>
 815
 816         * tui/tui-winsource.h (struct tui_source_window_base)
 817         <show_exec_info_content>: Declare.
 818         (tui_show_exec_info_content): Don't declare.
 819         * tui/tui-winsource.c
 820         (tui_source_window_base::show_exec_info_content): Rename from
 821         tui_show_exec_info_content.
 822         (tui_source_window_base::update_exec_info): Update.
 823
 824 2019-08-13  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 827         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 828         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 829         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 830         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 831         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 832         ... here.
 833
 834 2019-08-13  Tom Tromey  <tom@tromey.com>
 835
 836         * tui/tui-winsource.h (struct tui_source_window_base)
 837         <update_exec_info>: Declare.
 838         (tui_update_exec_info): Don't declare.
 839         * tui/tui-winsource.c (tui_update_source_window_as_is)
 840         (tui_source_window_base::refresh_all)
 841         (tui_update_all_breakpoint_info): Update.
 842         (tui_source_window_base::update_exec_info): Rename from
 843         tui_update_exec_info.
 844         * tui/tui-stack.c (tui_show_frame_info): Update.
 845
 846 2019-08-13  Tom Tromey  <tom@tromey.com>
 847
 848         * tui/tui-winsource.h (struct tui_source_window_base)
 849         <set_exec_info_content>: Declare.
 850         (tui_set_exec_info_content): Don't declare.
 851         * tui/tui-winsource.c
 852         (tui_source_window_base::set_exec_info_content): Rename from
 853         tui_set_exec_info_content.
 854         (tui_update_exec_info): Update.
 855
 856 2019-08-13  Tom Tromey  <tom@tromey.com>
 857
 858         * tui/tui-winsource.h (struct tui_source_window_base)
 859         <show_source_content>: Declare.
 860         (tui_show_source_content): Don't declare.
 861         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 862         (tui_source_window_base::show_source_content): Rename from
 863         tui_show_source_content.
 864         (tui_source_window_base::refresh_all): Update.
 865         * tui/tui-layout.c (show_source_disasm_command)
 866         (show_source_or_disasm_and_command): Update.
 867
 868 2019-08-13  Tom Tromey  <tom@tromey.com>
 869
 870         * tui/tui-winsource.c (tui_erase_source_content)
 871         (tui_show_source_content, tui_source_window_base::refresh_all):
 872         Update.
 873         * tui/tui-wingeneral.h
 874         (tui_check_and_display_highlight_if_needed): Don't declare.
 875         * tui/tui-wingeneral.c
 876         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 877         check_and_display_highlight_if_needed.
 878         * tui/tui-win.c (tui_rehighlight_all)
 879         (tui_win_info::make_visible_with_new_height): Update.
 880         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 881         (tui_data_window::erase_data_content)
 882         (tui_data_window::display_all_data): Update.
 883         * tui/tui-data.h (struct tui_win_info)
 884         <check_and_display_highlight_if_needed>: Declare.
 885
 886 2019-08-13  Tom Tromey  <tom@tromey.com>
 887
 888         * tui/tui-win.c (tui_resize_all): Call
 889         tui_delete_invisible_windows.
 890         * tui/tui-layout.c (show_layout): Call
 891         tui_delete_invisible_windows.
 892         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 893         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 894
 895 2019-08-13  Tom Tromey  <tom@tromey.com>
 896
 897         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 898         tui_add_win_to_layout.
 899
 900 2019-08-13  Tom Tromey  <tom@tromey.com>
 901
 902         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 903         * tui/tui-layout.c (tui_default_win_height): Now static.
 904
 905 2019-08-13  Tom Tromey  <tom@tromey.com>
 906
 907         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 908         single switch.
 909         (show_source_disasm_command, show_source_or_disasm_and_command):
 910         Don't check current layout.
 911
 912 2019-08-13  Tom Tromey  <tom@tromey.com>
 913
 914         * tui/tui-wingeneral.c (make_all_visible): Remove.
 915         (tui_make_all_invisible): Simplify.
 916         * tui/tui-layout.c (tui_make_all_invisible): Move from
 917         tui-wingeneral.c; simplify.
 918         (show_layout): Hoist call to tui_make_all_invisible.
 919         (show_data): Don't call tui_make_all_invisible.
 920
 921 2019-08-13  Tom Tromey  <tom@tromey.com>
 922
 923         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 924         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 925
 926 2019-08-13  Tom Tromey  <tom@tromey.com>
 927
 928         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 929         tui-data.c.
 930         (show_source_disasm_command, show_data)
 931         (show_source_or_disasm_and_command): Don't use
 932         tui_set_current_layout_to.
 933         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 934         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 935         tui-layout.c.
 936         (tui_set_current_layout_to): Remove.
 937
 938 2019-08-13  Tom Tromey  <tom@tromey.com>
 939
 940         * tui/tui-layout.c (tui_set_layout): Update.
 941         * tui/tui-data.h (struct tui_layout_def): Remove.
 942         (tui_layout_def): Don't declare.
 943         * tui/tui-data.c (layout_def): Remove.
 944         (tui_layout_def): Remove.
 945
 946 2019-08-13  Tom Tromey  <tom@tromey.com>
 947
 948         * tui/tui-winsource.h (struct tui_source_window_base)
 949         <clear_detail>: No longer "override".
 950         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 951         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 952         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 953         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 954         Remove.
 955         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 956
 957 2019-08-13  Tom Tromey  <tromey@adacore.com>
 958
 959         * tracepoint.c: Don't include readline.h or history.h.
 960
 961 2019-08-12  Tom Tromey  <tom@tromey.com>
 962
 963         * configure: Rebuild.
 964         * configure.ac: Check for readline 7.
 965         * NEWS: Mention readline 7 requirement.
 966         * README: Update.
 967
 968 2019-08-12  Tom Tromey  <tom@tromey.com>
 969
 970         * mingw-hdep.c (gdb_select): Remove readline hack.
 971
 972 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 973
 974         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 975         when the function fails.
 976
 977 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 978
 979         * s390-tdep.c (s390_type_align): New function.
 980         (s390_gdbarch_init): Set it as type_align gdbarch method.
 981
 982 2019-08-09  Tom de Vries  <tdevries@suse.de>
 983
 984         PR gdb/24591
 985         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 986         pc_low with relocation offset.
 987
 988 2019-08-07  Tom Tromey  <tromey@adacore.com>
 989
 990         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 991         (print_frame_args): Update.
 992         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 993         Update.
 994         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 995         * frame.h (struct frame_arg): Add initializers.
 996         <error>: Now a unique_xmalloc_ptr.
 997
 998 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 999
1000         * NEWS: Expand the Pointer Authentication entry.
1001         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1002         (aarch64_frame_unmask_lr): ... to this.
1003         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1004         Call aarch64_frame_unmask_lr.
1005         * frame.c (struct frame_info): Add "masked" variable.
1006         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1007         (fprint_frame): Check for masked pc.
1008         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1009         declarations.
1010         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1011         * stack.c (print_frame): Check for masked pc.
1012
1013 2019-08-06  Tom Tromey  <tom@tromey.com>
1014
1015         * stabsread.c (patch_block_stabs, read_one_struct_field)
1016         (read_enum_type): Use obstack_strndup.
1017         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1018         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1019         * dwarf2read.c (guess_full_die_structure_name)
1020         (anonymous_struct_prefix): Use obstack_strndup.
1021         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1022         * c-exp.y (yylex): Use obstack_strndup.
1023         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1024         (write_var_or_type): Use obstack_strndup.
1025
1026 2019-08-06  Tom Tromey  <tom@tromey.com>
1027
1028         * symfile.c (reread_symbols): Use obstack_strdup.
1029         * stabsread.c (read_type): Use obstack_strdup.
1030         * gdb_obstack.h (obstack_strdup): New overload.
1031         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1032         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1033         (dwarf2_canonicalize_name): Use obstack_strdup.
1034         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1035         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1036         Use obstack_strdup.
1037
1038 2019-08-06  Tom Tromey  <tom@tromey.com>
1039
1040         * gdb_obstack.h (obstack_strdup): Define.
1041         * gdb_obstack.c (obstack_strdup): Don't define.
1042
1043 2019-08-06  Tom Tromey  <tom@tromey.com>
1044
1045         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1046         obstack_strdup.
1047         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1048         obstack_strdup.
1049         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1050         * stabsread.c (common_block_start): Use obstack_strdup.
1051         * objfiles.c (set_objfile_main_name, objfile): Use
1052         obstack_strdup.
1053         * namespace.c (add_using_directive): Use obstack_strdup.
1054         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1055         * jit.c (finalize_symtab): Use obstack_strdup.
1056         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1057         (guess_partial_die_structure_name, partial_die_info::fixup)
1058         (dwarf2_name): Use obstack_strdup.
1059         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1060         obstack_strdup.
1061         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1062         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1063         obstack_strdup.
1064         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1065
1066 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1067
1068         * unittests/help-doc-selftests.c: New file.
1069         * Makefile.in: Add the new file.
1070
1071 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1072
1073         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1074         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1075         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1076         the trailing '.' is not output, and the first character is uppercased.
1077         (print_help_for_command): Update call to print_doc_line.
1078         (print_doc_of_command): Likewise.
1079         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1080         * cli/cli-option.c (append_indented_doc): Do not append newline.
1081         (build_help_option): Append newline after first appended_indented_doc
1082         only if a second call is done.
1083         (build_help): Append 2 new lines before each option, except the first
1084         one.
1085         * compile/compile.c (_initialize_compile): Add new lines after
1086         %OPTIONS%, when not at the end of the help.
1087         Change help doc or code
1088         producing the help doc to respect the invariants.
1089         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1090         Also removed the new line after 'Options:', as all other commands
1091         do not put an empty line between 'Options:' and the first option.
1092         * printcmd.c (_initialize_printcmd): Likewise.
1093         * stack.c (_initialize_stack): Likewise.
1094         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1095         incorrectly telling COMMAND is optional.
1096         * ada-lang.c (_initialize_ada_language): Change help doc or code
1097         producing the help doc to respect the invariants.
1098         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1099         * breakpoint.c (_initialize_breakpoint): Likewise.
1100         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1101         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1102         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1103         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1104         _initialize_cli_style): Likewise.
1105         * corelow.c (core_target_info): Likewise.
1106         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1107         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1108         * filesystem.c (_initialize_filesystem): Likewise.
1109         * frame.c (_initialize_frame): Likewise.
1110         * gnu-nat.c (add_task_commands): Likewise.
1111         * infcall.c (_initialize_infcall): Likewise.
1112         * infcmd.c (_initialize_infcmd): Likewise.
1113         * interps.c (_initialize_interpreter): Likewise.
1114         * language.c (_initialize_language): Likewise.
1115         * linux-fork.c (_initialize_linux_fork): Likewise.
1116         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1117         * maint.c (_initialize_maint_cmds): Likewise.
1118         * memattr.c (_initialize_mem): Likewise.
1119         * printcmd.c (_initialize_printcmd): Likewise.
1120         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1121         _RegEx): Likewise.
1122         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1123         * record-btrace.c (_initialize_record_btrace): Likewise.
1124         * record-full.c (_initialize_record_full): Likewise.
1125         * record.c (_initialize_record): Likewise.
1126         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1127         * regcache.c (_initialize_regcache): Likewise.
1128         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1129         _initialize_remote): Likewise.
1130         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1131         * serial.c (_initialize_serial): Likewise.
1132         * skip.c (_initialize_step_skip): Likewise.
1133         * source.c (_initialize_source): Likewise.
1134         * stack.c (_initialize_stack): Likewise.
1135         * symfile.c (_initialize_symfile): Likewise.
1136         * symtab.c (_initialize_symtab): Likewise.
1137         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1138         * top.c (init_main): Likewise.
1139         * tracefile-tfile.c (tfile_target_info): Likewise.
1140         * tracepoint.c (_initialize_tracepoint): Likewise.
1141         * tui/tui-win.c (_initialize_tui_win): Likewise.
1142         * utils.c (add_internal_problem_command): Likewise.
1143         * valprint.c (value_print_option_defs): Likewise.
1144
1145 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1146
1147         PR build/24886
1148         * configure.ac: Drop enable-libmcheck support.
1149         * configure, config.in: Rebuild.
1150         * libmcheck.m4: Remove.
1151         * acinclude.m4: Don't include it.
1152         * Makefile.in: Don't distribute it.
1153         * top.c (print_gdb_configuration): Don't mention it.
1154
1155 2019-08-06  Tom Tromey  <tom@tromey.com>
1156
1157         * utils.c (set_output_style): Sometimes pass stream to
1158         emit_style_escape.
1159         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1160         * record-btrace.c (btrace_insn_history): Update.
1161         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1162         method.
1163         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1164         Update initializers.
1165         <m_uiout>: New field.
1166         <m_di>: Move lower.
1167         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1168         Remove "uiout" parameter.
1169         (dump_insns): Update.
1170         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1171         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1172
1173 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1174
1175         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1176         (error_in_psymtab_expansion): Likewise.
1177         (lookup_symbol_via_quick_fns): Likewise.
1178         (basic_lookup_transparent_type_quick): Likewise.
1179         (basic_lookup_transparent_type_1): Likewise.
1180
1181 2019-08-06  Tom Tromey  <tromey@adacore.com>
1182
1183         * source.c (last_source_error): Now bool.
1184         (print_source_lines_base): Make "noprint" bool.  Only open
1185         source file when last_source_visited changes.
1186
1187 2019-08-06  Tom Tromey  <tromey@adacore.com>
1188
1189         * annotate.c (annotate_source_line): Use g_source_cache.
1190         * source-cache.c (source_cache::get_plain_source_lines): Change
1191         parameters.  Populate m_offset_cache.
1192         (source_cache::ensure): New method.
1193         (source_cache::get_line_charpos): New method.
1194         (extract_lines): Move lower.  Change parameters.
1195         (source_cache::get_source_lines): Move lower.
1196         * source-cache.h (class source_cache): Update comment.
1197         <get_line_charpos>: New method.
1198         <get_source_lines>: Update comment.
1199         <clear>: Clear m_offset_cache.
1200         <get_plain_source_lines>: Change parameters.
1201         <ensure>: New method
1202         <m_offset_cache>: New member.
1203         * source.c (forget_cached_source_info_for_objfile): Update.
1204         (info_source_command): Use g_source_cache.
1205         (find_source_lines, open_source_file_with_line_charpos): Remove.
1206         (print_source_lines_base, search_command_helper): Use g_source_cache.
1207         * source.h (open_source_file_with_line_charpos): Don't declare.
1208         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1209         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1210         Use g_source_cache.
1211
1212 2019-08-06  Tom Tromey  <tromey@adacore.com>
1213
1214         * source-cache.c (source_cache::get_plain_source_lines):
1215         Remove "first_line" and "last_line" parameters.
1216         (source_cache::get_source_lines): Cache plain text.
1217         * source-cache.h (class source_cache)
1218         <get_plain_source_lines>: Update.
1219
1220 2019-08-06  Tom Tromey  <tromey@adacore.com>
1221
1222         * source-cache.c (extract_lines): No longer a method.
1223         Changed type of parameter.  Include final newline.
1224         (selftests::extract_lines_test): New function.
1225         (_initialize_source_cache): Likewise.
1226         * source-cache.h (class source_cache)
1227         <extract_lines>: Don't declare.
1228
1229 2019-08-06  Tom Tromey  <tromey@adacore.com>
1230
1231         * breakpoint.c (init_breakpoint_sal): Update.
1232         (breakpoint): Update.
1233         * breakpoint.h (struct breakpoint) <filter>: Now a
1234         unique_xmalloc_ptr.
1235
1236 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1237
1238         * NEWS: Mention dictionary access on blocks.
1239         * python/py-block.c (blpy_getitem): New function.
1240         (block_object_as_mapping): New struct.
1241         (block_object_type): Use new struct for tp_as_mapping field.
1242
1243 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1244
1245         * objfiles.h (objfile): Add a comment describing partial symbols.
1246
1247 2019-08-05  Tom Tromey  <tromey@adacore.com>
1248
1249         * compile/compile.c (_initialize_compile): Use _(), not N_().
1250         * thread.c (_initialize_thread): Use _(), not N_().
1251         * stack.c (_initialize_stack): Use _(), not N_().
1252         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1253
1254 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1255
1256         * dwarf2read.c (struct dw2_symtab_iterator):
1257         <want_specific_block>: Remove.
1258         <block_index>: Change type to gdb::optional.
1259         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1260         change type of BLOCK_INDEX parameter to gdb::optional.
1261         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1262         (dw2_lookup_symbol): Don't pass argument for
1263         WANT_SPECIFIC_BLOCK.
1264         (dw2_expand_symtabs_for_function): Don't pass argument for
1265         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1266         (class dw2_debug_names_iterator)
1267         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1268         parameter, change BLOCK_INDEX type to gdb::optional.
1269         <m_want_specific_block>: Remove.
1270         <m_block_index>: Change type to gdb::optional.
1271         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1272         gdb::optional.  Re-write in function of gdb::optional.
1273         (dw2_debug_names_lookup_symbol): Don't pass argument for
1274         WANT_SPECIFIC_BLOCK.
1275         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1276         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1277         BLOCK_INDEX.
1278
1279 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1280
1281         * NEWS: Mention changes to "info sources" command.
1282
1283 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1284
1285         * symtab.c (filename_partial_match_opts): New struct type.
1286         (struct output_source_filename_data): New members
1287         regexp, c_regexp, partial_match.
1288         (output_source_filename): Use new members to decide to print file.
1289         (info_sources_option_defs): New variable.
1290         (make_info_sources_options_def_group, print_info_sources_header,
1291         info_sources_command_completer):
1292         New functions.
1293         (info_sources_command): Read new optional arguments.
1294         (_initialize_symtab): Update info sources help.
1295
1296 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1297
1298         * ada-lang.c (exception_support_info_v0): Renamed from...
1299         (default_exception_support_info): ... this.  Create new
1300         definition for v1.
1301         (ada_has_this_exception_support): Look up catch_handlers_sym.
1302         (ada_exception_support_info_sniffer): Try v0 after default.
1303
1304 2019-08-01  Tom Tromey  <tromey@adacore.com>
1305
1306         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1307         gdbarch.h.
1308
1309 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1310
1311         * s12z-tdep.c: Fix include path for s12z-opc.h.
1312
1313 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1314
1315         * NEWS: Require GNU make 3.82.
1316
1317 2019-07-16  Tom Tromey  <tom@tromey.com>
1318
1319         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1320         declare.
1321
1322 2019-07-30  Tom Tromey  <tromey@adacore.com>
1323
1324         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1325
1326 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1327
1328         * printcmd.c (print_address_symbolic): Print negative offsets.
1329         (build_address_symbolic): Force signed arithmetic when computing
1330         offset.
1331
1332 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1333
1334         PR/24474: Add a function to lookup static variables.
1335         * NEWS: Mention this new function.
1336         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1337         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1338         * python/python.c (python_GdbMethods): Add new function.
1339
1340 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1341
1342         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1343         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1344         (objfpy_lookup_static_symbol): New function.
1345         (objfile_object_methods): Add new functions.
1346
1347 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1348
1349         * NEWS: Mention 'set|show print frame-info'.  Mention new
1350         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1351         backtrace argument.  Mention that python frame filtering code
1352         is now consistent with what 'backtrace' command prints.
1353
1354 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1355
1356         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1357         comments.
1358         (print_frame_info_auto, print_frame_info_source_line,
1359         print_frame_info_location, print_frame_info_source_and_location,
1360         print_frame_info_location_and_address, print_frame_info_short_location):
1361         New declarations.
1362         (struct frame_print_options): New member print_frame_info.
1363         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1364         * stack.h (get_user_print_what_frame_info): New declaration.
1365         (frame_show_address): New declaration.
1366         * stack.c (print_frame_arguments_choices): New value 'presence'.
1367         (print_frame_info_auto, print_frame_info_source_line,
1368         print_frame_info_location, print_frame_info_source_and_location,
1369         print_frame_info_location_and_address, print_frame_info_short_location,
1370         print_frame_info_choices, print_frame_info_print_what): New definitions.
1371         (print_frame_args): Only print dots for args if print frame-arguments
1372         is 'presence'.
1373         (frame_print_option_defs): New element for "frame-info".
1374         (get_user_print_what_frame_info): New function.
1375         (frame_show_address): Make non static.  Move comment to stack.h.
1376         (print_frame_info_to_print_what): New function.
1377         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1378         to decide what to print.
1379         (backtrace_command_1): Handle the new print_frame_arguments_presence
1380         value.
1381         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1382         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1383         (py_print_frame): In non-mi mode, use LOCATION as default for
1384         print_what, similarly to frame information printed directly by
1385         backtrace command. Handle frame-info user option in non MI mode.
1386
1387 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1388
1389         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1390         Add case for debugging 32-bit target on 64-bit host.  Revise
1391         comment.
1392
1393 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1394
1395         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1396         instead of find_function_entry_range_from_pc.
1397
1398 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1399
1400         * stack.c (find_frame_funname): Remove code which preferred
1401         minsym over symtab sym in "certain pathological cases".
1402
1403         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1404         parameter.  Change type of "do_demangle" to bool.
1405         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1406         Pass suitable "prefer_sym_over_minsym" flag to
1407         build_address_symbolic().  Don't output "+" for negative offsets.
1408         * printcmd.c (print_address_symbolic): Update invocation of
1409         build_address_symbolic to include a "prefer_sym_over_minsym"
1410         flag.
1411         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1412         Restrict cases in which use of minimal symbol is preferred to that
1413         of a found symbol.  Update comments.
1414
1415         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1416         for entry pc when entry pc is out of range for that FDE.
1417
1418 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1419
1420         PR gdb/24839:
1421         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1422         type.
1423
1424 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1425
1426         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1427         this function's Python signature.
1428
1429
1430 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1431
1432         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1433         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1434         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1435         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1436         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1437
1438
1439 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1440
1441         * h8300-tdep.c (h8300_register_name_common): New.
1442         h8300_register_name): Use h8300_register_name_common.
1443         (h8300s_register_name): Likewise.
1444         (h8300sx_register_name): Likewise.
1445         (h8300h_register_nam): New.
1446         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1447
1448
1449 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1450
1451         * arm-tdep.c (arm_skip_cmse_entry): New function.
1452         (arm_is_sgstubs_section): New function.
1453         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1454
1455 2019-07-22  Tom Tromey  <tom@tromey.com>
1456
1457         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1458         Don't self-assign.
1459
1460 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1461
1462         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1463         type_print.
1464
1465 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1466
1467         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1468         so that GDB doesn't match any msymbols when searching in the
1469         TYPES_DOMAIN.
1470         (print_symbol_info): Print using typedef_print or type_print based
1471         on the type of the symbol.  Add updated FIXME comment moved from...
1472         (_initialize_symtab): ... move and update FIXME comment to above.
1473
1474 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1475
1476         * NEWS: Mention adding -q option to "info types".
1477         * symtab.c (struct info_types_options): New struct.
1478         (info_types_options_defs): New variable.
1479         (make_info_types_options_def_group): New function.
1480         (info_types_command): Use gdb::option framework to parse options.
1481         (info_types_command_completer): New function.
1482         (_initialize_symtab): Extend the help text on "info types" and
1483         register command completer.
1484
1485 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1486
1487         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1488         (lookup_symbol_in_objfile): Change int to block_enum and add a
1489         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1490
1491 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1492
1493         * MAINTAINERS (Write After Approval): Add self.
1494
1495 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1496
1497         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1498         instruction to the dummy code region.
1499
1500 2019-07-19  Tom Tromey  <tromey@adacore.com>
1501
1502         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1503         (ARGSUSED, PARAMS, __func__): Remove rules.
1504
1505 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1506
1507         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1508         * features/arm/arm-with-iwmmxt.c: Remove.
1509         * features/arm/arm-with-iwmmxt.xml: Remove.
1510         * features/arm/arm-with-m-fpa-layout.c: Remove.
1511         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1512         * features/arm/arm-with-m-vfp-d16.c: Remove.
1513         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1514         * features/arm/arm-with-m.c: Remove.
1515         * features/arm/arm-with-m.xml: Remove.
1516         * features/arm/arm-with-neon.c: Remove.
1517         * features/arm/arm-with-neon.xml: Remove.
1518         * features/arm/arm-with-vfpv2.c: Remove.
1519         * features/arm/arm-with-vfpv2.xml: Remove.
1520         * features/arm/arm-with-vfpv3.c: Remove.
1521         * features/arm/arm-with-vfpv3.xml: Remove.
1522
1523 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1524
1525         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1526
1527 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1528
1529         * arch/aarch32.c (aarch32_create_target_description): Create
1530         target descriptions using features.
1531         * arch/arm.c (arm_create_target_description)
1532         (arm_create_mprofile_target_description): Likewise.
1533         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1534
1535 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1536
1537         * Makefile.in: Add new files.
1538         * aarch32-tdep.c: New file.
1539         * aarch32-tdep.h: New file.
1540         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1541         Call aarch32_read_description.
1542         * arch/aarch32.c: New file.
1543         * arch/aarch32.h: New file.
1544         * arch/arm.c (arm_create_target_description)
1545         (arm_create_mprofile_target_description): New function.
1546         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1547         (arm_create_target_description)
1548         (arm_create_mprofile_target_description): New declaration.
1549         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1550         read_description functions.
1551         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1552         Likewise.
1553         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1554         * arm-tdep.c (tdesc_arm_list): New variable.
1555         (arm_register_g_packet_guesses): Call create description functions.
1556         (arm_read_description) (arm_read_mprofile_description): New
1557         function.
1558         * arm-tdep.h (arm_read_description)
1559         (arm_read_mprofile_description): Add declaration.
1560         * configure.tgt: Add new files.
1561
1562 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1563
1564         * top.c (new_ui_command): Open specified terminal just once.
1565
1566 2019-07-18  Tom Tromey  <tromey@adacore.com>
1567
1568         * symtab.c (main_name): Constify return type.
1569         * symfile.c (set_initial_language): Update.
1570         * symtab.h (main_name): Constify return type.
1571
1572 2019-07-17  Tom Tromey  <tom@tromey.com>
1573
1574         * tui/tui-winsource.c (tui_update_source_window)
1575         (tui_update_source_window_as_is)
1576         (tui_update_source_windows_with_line): Remove return.
1577         * tui/tui-disasm.c (tui_show_disassem)
1578         (tui_show_disassem_and_update_source): Remove return.
1579         * tui/tui.c (tui_reset): Remove return.
1580         * tui/tui-wingeneral.c
1581         (tui_check_and_display_highlight_if_needed): Remove return.
1582
1583 2019-07-17  Tom Tromey  <tom@tromey.com>
1584
1585         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1586
1587 2019-07-17  Tom Tromey  <tom@tromey.com>
1588
1589         * tui/tui-winsource.h (struct tui_exec_info_window)
1590         (struct tui_source_window_base): Move from tui-data.h.
1591         * tui/tui-winsource.c: Move many method definitions from
1592         elsewhere.  Remove "structuring" comments.
1593         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1594         (tui_source_window_base::refresh_window): Move to
1595         tui-winsource.c.
1596         * tui/tui-win.c (tui_source_window_base::refresh_all)
1597         (tui_source_window_base::update_tab_width)
1598         (tui_source_window_base::set_new_height)
1599         (tui_source_window_base::do_make_visible_with_new_height): Move to
1600         tui-winsource.c.
1601         * tui/tui-source.h: Update.
1602         * tui/tui-source.c (tui_source_window_base::reset): Move to
1603         tui-winsource.c.
1604         * tui/tui-disasm.h: Update.
1605         * tui/tui-data.h (struct tui_exec_info_window): Move to
1606         tui-winsource.h.
1607         (struct tui_source_window_base): Likewise.
1608         * tui/tui-data.c (tui_source_window_base::clear_detail)
1609         (tui_source_window_base, ~tui_source_window_base): Move to
1610         tui-winsource.c.
1611
1612 2019-07-17  Tom Tromey  <tom@tromey.com>
1613
1614         * tui/tui-win.c (tui_resize_all)
1615         (tui_source_window_base::update_tab_width)
1616         (tui_adjust_win_heights): Update.
1617         (tui_win_info::make_invisible_and_set_new_height): Rename from
1618         make_invisible_and_set_new_height.
1619         * tui/tui-data.h (struct tui_win_info)
1620         <make_invisible_and_set_new_height>: New method.
1621
1622 2019-07-17  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui.c: Update.
1625         * tui/tui-source.h (struct tui_source_window): Move from
1626         tui-data.h.
1627         * tui/tui-layout.c: Update.
1628         * tui/tui-disasm.c: Update.
1629         * tui/tui-data.h (struct tui_source_window): Move to
1630         tui-source.h.
1631
1632 2019-07-17  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1635         tui-data.h.
1636         * tui/tui-data.h (struct tui_disasm_window): Move to
1637         tui-disasm.h.
1638
1639 2019-07-17  Tom Tromey  <tom@tromey.com>
1640
1641         * tui/tui-regs.h (struct tui_data_item_window): Move from
1642         tui-data.h.
1643         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1644         * tui/tui-data.h (struct tui_data_item_window): Move to
1645         tui-regs.h.
1646         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1647
1648 2019-07-17  Tom Tromey  <tom@tromey.com>
1649
1650         * tui/tui.c: Update.
1651         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1652         (tui_cmd_window::max_height): Move to tui-command.c.
1653         * tui/tui-layout.c: Update.
1654         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1655         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1656         tui-command.c.
1657         * tui/tui-command.h (struct tui_cmd_window): Move from
1658         tui-data.h.
1659         * tui/tui-command.c: Remove "structuring" comments.
1660         (tui_cmd_window::clear_detail)
1661         (tui_cmd_window::do_make_visible_with_new_height)
1662         (tui_cmd_window::max_height): Move from elsewhere.
1663
1664 2019-07-17  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1667         Now static.
1668         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1669         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1670
1671 2019-07-17  Tom Tromey  <tom@tromey.com>
1672
1673         * tui/tui.c: Update.
1674         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1675         tui-regs.c.
1676         * tui/tui-windata.h: Remove file.
1677         * tui/tui-windata.c: Remove file.
1678         * tui/tui-win.c (tui_data_window::set_new_height)
1679         (tui_data_window::do_make_visible_with_new_height): Move to
1680         tui-regs.c.
1681         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1682         * tui/tui-regs.c: Remove "structuring" comments.
1683         (tui_data_window::first_data_item_displayed)
1684         (tui_data_window::delete_data_content_windows)
1685         (tui_data_window::erase_data_content)
1686         (tui_data_window::display_all_data)
1687         (tui_data_window::refresh_all)
1688         (tui_data_window::do_scroll_vertical)
1689         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1690         (tui_data_window::do_make_visible_with_new_height)
1691         (tui_data_window::refresh_window): Move from elsewhere.
1692         (_initialize_tui_regs): Move to end of file.
1693         * tui/tui-layout.c: Update.
1694         * tui/tui-hooks.c: Update.
1695         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1696         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1697         tui-regs.c.
1698         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1699
1700 2019-07-17  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1703         seen.
1704
1705 2019-07-17  Tom Tromey  <tom@tromey.com>
1706
1707         * tui/tui-win.c (tui_source_window_base::set_new_height)
1708         (tui_source_window_base::do_make_visible_with_new_height): Use
1709         m_has_locator field directly.
1710         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1711         method.
1712         (struct tui_source_window_base) <has_locator>: Likewise.
1713
1714 2019-07-17  Tom Tromey  <tom@tromey.com>
1715
1716         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1717         Don't declare.
1718         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1719         Remove.
1720         * tui/tui-win.c (tui_source_window_base::set_new_height)
1721         (tui_source_window_base::set_new_height)
1722         (make_invisible_and_set_new_height)
1723         (tui_source_window_base::do_make_visible_with_new_height)
1724         (tui_source_window_base::do_make_visible_with_new_height):
1725         Update.
1726         * tui/tui-layout.c (show_source_disasm_command, show_data)
1727         (show_source_or_disasm_and_command): Update.
1728         * tui/tui-layout.c (show_layout): Update.
1729
1730 2019-07-17  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui-layout.c (make_data_window): Remove.
1733         (show_data): Unify creation and re-initialization cases.
1734
1735 2019-07-17  Tom Tromey  <tom@tromey.com>
1736
1737         * tui/tui-layout.c (make_source_window, make_disasm_window):
1738         Remove.
1739         (show_data): Unify creation and re-initialization cases.
1740
1741 2019-07-17  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-layout.c (make_command_window): Remove.
1744         (show_source_disasm_command, show_source_or_disasm_and_command):
1745         Unify creation and re-initialization cases.
1746
1747 2019-07-17  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1750         creation and re-initialization cases.
1751
1752 2019-07-17  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-regs.c (tui_get_register): Return void.
1755
1756 2019-07-17  Tom Tromey  <tom@tromey.com>
1757
1758         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1759         Simplify.
1760
1761 2019-07-17  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1764         resetting.
1765
1766 2019-07-17  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1769         * tui/tui-regs.c (tui_reg_layout): New function.
1770         (tui_show_registers, tui_reg_command): Use it.
1771         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1772         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1773         parameters.
1774         (tui_layout_command): Remove.
1775
1776 2019-07-17  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui-layout.h (tui/tui-layout): Return void.
1779         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1780
1781 2019-07-17  Tom Tromey  <tom@tromey.com>
1782
1783         * tui/tui-layout.c (show_source_disasm_command, show_data):
1784         Update.
1785         (reset_locator): Remove.
1786         (show_source_or_disasm_and_command): Update.
1787
1788 2019-07-17  Tom Tromey  <tom@tromey.com>
1789
1790         * tui/tui-source.c (tui_source_window_base::reset): Remove
1791         win_type parameter.
1792         * tui/tui-layout.c (make_command_window, make_source_window)
1793         (make_disasm_window, make_data_window)
1794         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1795         (reset_locator, show_source_or_disasm_and_command): Update.
1796         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1797         win_type parameter.
1798         (struct tui_source_window_base) <reset>: Likewise.
1799
1800 2019-07-17  Tom Tromey  <tom@tromey.com>
1801
1802         * tui/tui-layout.c (show_source_disasm_command): Use
1803         reset_locator.
1804         (reset_locator): New function.
1805         (init_and_make_win): Remove.
1806         (show_source_or_disasm_and_command): Use reset_locator.
1807
1808 2019-07-17  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1811         condition.
1812         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1813         Remove condition.
1814         * tui/tui-source.c (tui_source_window_base::reset): New method.
1815         * tui/tui-layout.c (make_command_window): Don't call
1816         init_and_make_win.
1817         (make_source_window, make_disasm_window): Don't call
1818         make_source_or_disasm_window.
1819         (make_data_window): Don't call init_and_make_win.  Change calling
1820         convention.
1821         (show_source_disasm_command, show_data): Simplify.
1822         (make_source_or_disasm_window): Remove.
1823         (show_source_or_disasm_and_command): Simplify.
1824         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1825         (struct tui_source_window_base) <reset>: Likewise.
1826         <execution_info>: Remove initializer.
1827         * tui/tui-data.c (tui_source_window_base): Initialize
1828         execution_info.
1829
1830 2019-07-17  Tom Tromey  <tom@tromey.com>
1831
1832         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1833         variable.
1834
1835 2019-07-17  Tom Tromey  <tom@tromey.com>
1836
1837         * tui/tui.c (tui_rl_other_window): Update.
1838         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1839         superclass method first.  Always iterate over regs_content.
1840         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1841         method.
1842         * tui/tui-win.c (tui_set_focus_command): Update.
1843
1844 2019-07-17  Tom Tromey  <tom@tromey.com>
1845
1846         * tui/tui-win.c (tui_set_focus_command): Rename from
1847         tui_set_focus.  Call tui_enable.
1848         (tui_set_focus_command): Remove.
1849
1850 2019-07-17  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1853         refresh_window.
1854         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1855         touchwin.
1856         (tui_data_window::refresh_window): Call refresh_window on data
1857         items.  Always call superclass refresh_window.
1858         (tui_win_info::refresh): Remove.
1859         (tui_source_window_base::refresh_window): Update.
1860         (tui_refresh_all): Update.
1861         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1862         refresh_window.
1863         (show_source_or_disasm_and_command): Likewise.
1864         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1865         (struct tui_source_window_base) <refresh>: Likewise.
1866
1867 2019-07-17  Tom Tromey  <tom@tromey.com>
1868
1869         * tui/tui-winsource.c (tui_clear_source_content)
1870         (tui_show_source_content): Update.
1871         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1872         whether content is empty.
1873         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1874         Remove.
1875
1876 2019-07-17  Tom Tromey  <tom@tromey.com>
1877
1878         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1879         window's contents.
1880         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1881         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1882
1883 2019-07-17  Tom Tromey  <tom@tromey.com>
1884
1885         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1886         (struct tui_data_item_window): Update.
1887
1888 2019-07-17  Tom Tromey  <tom@tromey.com>
1889
1890         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1891         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1892         defines.
1893
1894 2019-07-17  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-winsource.h (tui_erase_source_content)
1897         (tui_clear_source_content): Remove "display_prompt" parameter.
1898         * tui/tui-winsource.c (tui_update_source_window_as_is)
1899         (tui_update_source_windows_with_addr): Update.
1900         (tui_clear_source_content): Remove "display_prompt" parameter.
1901         (tui_erase_source_content): Likewise.  Simplify.
1902         (tui_show_source_content): Update.
1903         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1904         * tui/tui-stack.c (tui_show_frame_info): Update.
1905         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1906         Remove defines.
1907
1908 2019-07-17  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1911         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1912         parameter.
1913         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1914         parameter.
1915
1916 2019-07-17  Tom Tromey  <tom@tromey.com>
1917
1918         * tui/tui-winsource.c (tui_clear_source_content)
1919         (tui_show_source_content, tui_show_exec_info_content)
1920         (tui_clear_exec_info_content): Update.
1921         * tui/tui-stack.c (tui_show_locator_content): Update.
1922         (tui_show_frame_info): Update.
1923         * tui/tui-source.h (tui_source_window): Don't declare.
1924         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1925         from tui_source_is_displayed.
1926         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1927         Remove field.
1928         (struct tui_source_window_base) <content_in_use>: New field.  Now
1929         bool.
1930         (struct tui_source_window) <showing_source_p>: New method.
1931         (TUI_SRC_WIN): Change cast.
1932         * tui/tui-data.c (tui_initialize_static_data): Update.
1933
1934 2019-07-17  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1937         location_matches_p.
1938         * tui/tui-source.c (tui_source_window::location_matches_p): New
1939         method.
1940         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1941         method.
1942         * tui/tui-data.h (struct tui_source_window_base)
1943         <location_matches_p>: New method.
1944         (struct tui_source_window, struct tui_disasm_window)
1945         <location_matches_p>: Likewise.
1946
1947 2019-07-17  Tom Tromey  <tom@tromey.com>
1948
1949         * tui/tui-win.c (tui_set_win_height_command): Rename from
1950         tui_set_win_height.
1951         (tui_set_win_height_command): Remove.
1952
1953 2019-07-17  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui-source.c (tui_source_window): New constructor.  Add
1956         observer.
1957         (~tui_source_window): New destructor.
1958         (tui_source_window::style_changed): New method.
1959         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1960         (tui_attach_detach_observers): Update.
1961         * tui/tui-data.h (struct tui_source_window): Make constructor not
1962         inline.  Add destructor.
1963         (struct tui_source_window) <style_changed>: New method.
1964         <m_observable>: New member.
1965
1966 2019-07-17  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1969         * tui/tui-win.c (tui_resize_all): Fix typo.
1970
1971 2019-07-17  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1974         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1975         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1976         * tui/tui-win.c (window_name_completer): Use foreach.
1977         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1978         (update_tab_width): Likewise.
1979         * tui/tui-layout.c (show_layout): Update.
1980         * tui/tui-data.h (class tui_window_iterator): New.
1981         (struct all_tui_windows): New.
1982         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1983
1984 2019-07-17  Tom Tromey  <tom@tromey.com>
1985
1986         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1987         parameter.  Don't reference globals.
1988         (tui_reg_command): Update.
1989
1990 2019-07-17  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-regs.c (tui_show_registers): Simplify.
1993
1994 2019-07-17  Tom Tromey  <tom@tromey.com>
1995
1996         * tui/tui-regs.c (tui_show_registers): Update.
1997         (tui_show_register_group): Add win_info parameter.
1998
1999 2019-07-17  Tom Tromey  <tom@tromey.com>
2000
2001         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2002         Rename from tui_display_reg_element_at_line.
2003         (tui_data_window::display_registers_from_line): Update.
2004         * tui/tui-data.h (struct tui_data_window)
2005         <display_reg_element_at_line>: New method.
2006
2007 2019-07-17  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-regs.h (tui_display_registers_from)
2010         (tui_display_registers_from_line): Don't declare.
2011         * tui/tui-windata.c (tui_data_window::display_all_data)
2012         (tui_data_window::refresh_all)
2013         (tui_data_window::do_scroll_vertical): Update.
2014         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2015         from tui_display_registers_from.
2016         (tui_display_reg_element_at_line): Update.
2017         (tui_data_window::display_registers_from_line): Rename from
2018         tui_display_registers_from_line.
2019         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2020         display_registers_from_line>: New methods.
2021
2022 2019-07-17  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2025         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2026         from tui_erase_data_content.
2027         (tui_data_window::display_all_data)
2028         (tui_data_window::refresh_all)
2029         (tui_data_window::do_scroll_vertical): Update.
2030         * tui/tui-regs.c (tui_show_registers): Update.
2031         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2032         New method.
2033
2034 2019-07-17  Tom Tromey  <tom@tromey.com>
2035
2036         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2037         declare.
2038         * tui/tui-windata.c
2039         (tui_data_window::delete_data_content_windows): Rename from
2040         tui_delete_data_content_windows.
2041         (tui_data_window::display_all_data)
2042         (tui_data_window::do_scroll_vertical): Update.
2043         * tui/tui-data.h (struct tui_data_window)
2044         <delete_data_content_windows>: New method.
2045
2046 2019-07-17  Tom Tromey  <tom@tromey.com>
2047
2048         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2049         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2050
2051 2019-07-17  Tom Tromey  <tom@tromey.com>
2052
2053         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2054         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2055         from tui_display_all_data.
2056         * tui/tui-win.c
2057         (tui_data_window::do_make_visible_with_new_height): Update.
2058         * tui/tui-regs.c (tui_show_registers): Update.
2059         * tui/tui-layout.c (tui_set_layout): Update.
2060         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2061         method.
2062
2063 2019-07-17  Tom Tromey  <tom@tromey.com>
2064
2065         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2066         * tui/tui-windata.c (tui_display_data_from): Remove.
2067         (tui_data_window::refresh_all): Update.
2068
2069 2019-07-17  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2072         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2073         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2074         tui_display_registers_from_line.
2075         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2076         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2077         "force_display" parameter.
2078
2079 2019-07-17  Tom Tromey  <tom@tromey.com>
2080
2081         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2082         declare.
2083         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2084         Rename from tui_first_reg_element_no_inline.
2085         (tui_display_reg_element_at_line)
2086         (tui_display_registers_from_line): Update.
2087         * tui/tui-data.h (struct tui_data_window)
2088         <first_reg_element_no_inline>: New method.
2089
2090 2019-07-17  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-windata.c (tui_display_data_from)
2093         (tui_data_window::do_scroll_vertical): Update.
2094         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2095         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2096         Rename from tui_line_from_reg_element_no.
2097         (tui_display_registers_from_line): Update.
2098         * tui/tui-data.h (struct tui_data_window)
2099         <line_from_reg_element_no>: New method.
2100
2101 2019-07-17  Tom Tromey  <tom@tromey.com>
2102
2103         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2104         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2105         tui_last_regs_line_no.
2106         (tui_display_reg_element_at_line)
2107         (tui_display_registers_from_line): Update.
2108         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2109         method.
2110
2111 2019-07-17  Tom Tromey  <tom@tromey.com>
2112
2113         PR tui/24722:
2114         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2115         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2116         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2117         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2118         (tui_update_breakpoint_info): Likewise.
2119         * tui/tui-hooks.c (tui_event_create_breakpoint)
2120         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2121         Update.
2122
2123 2019-07-17  Tom Tromey  <tom@tromey.com>
2124
2125         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2126
2127 2019-07-17  Tom Tromey  <tom@tromey.com>
2128
2129         * tui/tui-winsource.c (tui_update_source_window_as_is)
2130         (tui_update_source_windows_with_addr): Update.
2131         * tui/tui-source.h (tui_set_source_content)
2132         (tui_show_symtab_source): Add "win_info" parameter.
2133         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2134         parameter.
2135         (tui_show_symtab_source): Likewise.
2136
2137 2019-07-17  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-wingeneral.c
2140         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2141
2142 2019-07-17  Tom Tromey  <tom@tromey.com>
2143
2144         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2145         (struct tui_cmd_window) <can_scroll>: New method.
2146         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2147         method.
2148
2149 2019-07-17  Tom Tromey  <tromey@adacore.com>
2150
2151         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2152         do_field_signed>: Rename.  Change type of "value".
2153         * ui-out.c (ui_out::field_signed): Rename from field_int.
2154         Change type of "value".
2155         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2156         type of "value".
2157         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2158         do_field_int.  Change type of "value".
2159         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2160         do_field_int.  Change type of "value".
2161         * tracepoint.c (trace_status_mi, tfind_1)
2162         (print_one_static_tracepoint_marker): Update.
2163         * thread.c (print_thread_info_1, print_selected_thread_frame):
2164         Update.
2165         * stack.c (print_frame, print_frame_info): Update.
2166         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2167         Update.
2168         * source.c (print_source_lines_base): Update.
2169         * skip.c (info_skip_command): Update.
2170         * record-btrace.c (btrace_ui_out_decode_error)
2171         (btrace_call_history_src_line): Update.
2172         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2173         Update.
2174         * progspace.c (print_program_space): Update.
2175         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2176         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2177         do_field_int.  Change type of "value".
2178         * mi/mi-out.c (mi_ui_out::do_table_begin)
2179         (mi_ui_out::do_table_header): Update.
2180         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2181         type of "value".
2182         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2183         (mi_cmd_data_list_changed_registers, output_register)
2184         (mi_cmd_data_read_memory, mi_load_progress)
2185         (mi_cmd_trace_frame_collected): Update.
2186         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2187         Update.
2188         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2189         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2190         (mi_cmd_var_list_children, varobj_update_one): Update.
2191         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2192         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2193         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2194         * inferior.c (print_inferior): Update.
2195         * gdb_bfd.c (print_one_bfd): Update.
2196         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2197         Update.
2198         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2199         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2200         do_field_int.  Change type of "value".
2201         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2202         do_field_int.  Change type of "value".
2203         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2204         (print_one_breakpoint_location, print_it_catch_fork)
2205         (print_one_catch_fork, print_it_catch_vfork)
2206         (print_one_catch_vfork, print_it_catch_solib)
2207         (print_it_catch_exec, print_it_ranged_breakpoint)
2208         (print_mention_watchpoint, print_mention_masked_watchpoint)
2209         (bkpt_print_it, update_static_tracepoint): Update.
2210         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2211         * break-catch-syscall.c (print_it_catch_syscall): Update.
2212         * ada-tasks.c (print_ada_task_info): Update.
2213         * ada-lang.c (print_it_exception, print_mention_exception):
2214         Update.
2215
2216 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2217
2218         PR breakpoints/24541
2219         * gdbarch.c: Regenerate.
2220         * gdbarch.h: Regenerate.
2221         * gdbarch.sh: Adjust return type and parameter types for
2222         'stap_adjust_register'.
2223         (i386_stap_adjust_register): Adjust signature and return new
2224         register name.
2225         * stap-probe.c (stap_parse_register_operand): Adjust use of
2226         'gdbarch_stap_adjust_register'.
2227
2228 2019-07-17  Tom Tromey  <tromey@adacore.com>
2229
2230         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2231         declare VEC.
2232         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2233         std::vector.
2234         (struct s390_process_info): Add initializers.
2235         (s390_add_process): Use new.
2236         (s390_linux_nat_target::low_forget_process): Use delete.
2237         (s390_linux_nat_target::low_new_fork)
2238         (s390_linux_nat_target::stopped_by_watchpoint)
2239         (s390_linux_nat_target::low_prepare_to_resume)
2240         (s390_linux_nat_target::insert_watchpoint)
2241         (s390_linux_nat_target::insert_hw_breakpoint)
2242         (s390_linux_nat_target::remove_watchpoint)
2243         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2244
2245 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2246
2247         * aarch64-fbsd-nat.c: Include regcache.h.
2248         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2249         argument.
2250         (aarch64_fbsd_nat_target::fetch_registers)
2251         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2252         variable.
2253         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2254
2255 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2256
2257         * fbsd-nat.c: Include gdbarch.h.
2258
2259 2019-07-15  Tom Tromey  <tromey@adacore.com>
2260
2261         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2262
2263 2019-07-15  Tom Tromey  <tromey@adacore.com>
2264
2265         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2266         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2267         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2268         * cli-out.c (cli_ui_out::do_field_int): New method.
2269         * ui-out.c (ui_out::field_unsigned): New method.
2270         * symfile.c (generic_load): Use field_unsigned.
2271         (print_transfer_performance): Likewise.
2272         * record-btrace.c (ui_out_field_uint): Remove.
2273         (btrace_call_history_insn_range, btrace_call_history): Use
2274         field_unsigned.
2275         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2276         field_unsigned.
2277         * ui-out.h (class ui_out) <field_unsigned>: New method.
2278         <do_field_unsigned>: Likewise.
2279
2280 2019-07-15  Tom Tromey  <tromey@adacore.com>
2281
2282         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2283         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2284         * target.c (flash_erase_command): Use field_string.
2285         * infrun.c (print_signal_received_reason): Use field_string.
2286         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2287         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2288         field_string.
2289         * ada-tasks.c (print_ada_task_info): Use field_string.
2290
2291 2019-07-15  Tom Tromey  <tromey@adacore.com>
2292
2293         * target.c (flash_erase_command): Use field_core_addr.
2294         * symfile.c (generic_load): Use field_core_addr.
2295         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2296         Use field_core_addr.
2297         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2298         field_core_addr.
2299
2300 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2301
2302         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2303         value if its desired type is smaller than a CORE_ADDR and signed.
2304
2305 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2306
2307         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2308         of changes to field names, and use new is_reference field to
2309         decide if a property is a reference or not.
2310         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2311         field.
2312         (struct dwarf2_property_baton): Update header comment, rename
2313         'referenced_type' to 'property_type' and update comments.
2314         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2315         default property type, store in property baton, update to take
2316         accound of renamed field.
2317         (read_func_scope): Update call to attr_to_dynamic_prop.
2318         (read_array_type): Likewise.
2319         (dwarf2_per_cu_addr_sized_int_type): New function.
2320         (read_subrange_index_type): Move type finding code to
2321         dwarf2_per_cu_addr_sized_int_type.
2322         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2323         (dwarf2_per_cu_addr_type): New function.
2324         (set_die_type): Update calls to attr_to_dynamic_prop.
2325
2326 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2327
2328         * dwarf2read.c (read_subrange_index_type): New function.
2329         (read_subrange_type): Move code into new function and call it.
2330         * gdbtypes.c (create_range_type): Add some asserts.
2331
2332 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2333
2334         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2335         update return statements.
2336         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2337         declaration, and update comment to match.
2338         * gdbtypes.c (resolve_dynamic_array): Update call to
2339         dwarf2_evaluate_property to match new return type.
2340
2341 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2342
2343         * valarith.c (value_subscripted_rvalue): Change lowerbound
2344         parameter type from int to LONGEST.
2345         * value.h (value_subscripted_rvalue): Likewise in declaration.
2346
2347 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2348
2349         * cli/cli-utils.c (info_print_command_completer): New function.
2350         * cli/cli-utils.h: Add 'completer.h' include, and forward
2351         declaration for 'struct cmd_list_element'.
2352         (info_print_command_completer): Declare.
2353         * stack.c (_initialize_stack): Add completer for 'info locals' and
2354         'info args'.
2355         * symtab.c (_initialize_symtab): Add completer for 'info
2356         variables' and 'info functions'.
2357         * NEWS: Mention completion for additional info commands.
2358
2359 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2360
2361         * cli/cli-utils.c (extract_info_print_args): Delete.
2362         (extract_arg_maybe_quoted): Delete.
2363         (info_print_options_defs): New variable.
2364         (make_info_print_options_def_group): New function.
2365         (extract_info_print_options): Define new function.
2366         * cli/cli-utils.h (extract_info_print_args): Delete.
2367         (struct info_print_options): New structure.
2368         (extract_info_print_options): Declare new function.
2369         * stack.c (info_locals_command): Update to use new
2370         extract_info_print_options, also add a header comment.
2371         (info_args_command): Likewise.
2372         * symtab.c (info_variables_command): Likewise.
2373         (info_functions_command): Likewise.
2374
2375 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2376
2377         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2378         to extract string arguments.
2379         * common/common-utils.c (extract_string_maybe_quoted): New function.
2380         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2381
2382 2019-07-11  Tom Tromey  <tromey@adacore.com>
2383
2384         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2385         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2386         * top.h (gdbinit): Don't declare.
2387         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2388         into...
2389         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2390         * top.c (gdb_init): Don't call init_cli_cmds.
2391         (gdbinit): Remove.
2392         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2393
2394 2019-07-11  Tom Tromey  <tromey@adacore.com>
2395
2396         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2397         after it has been moved.
2398
2399 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2400
2401         * valops.c (value_must_coerce_to_target): Change return type to
2402         bool.
2403         * value.h (value_must_coerce_to_target): Likewise.
2404
2405 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2406
2407         * breakpoint.c (is_hardware_watchpoint): Remove
2408         forward-declaration.
2409         (is_masked_watchpoint): Change return type to bool.
2410         (is_tracepoint): Likewise.
2411         (is_breakpoint): Likewise.
2412         (is_hardware_watchpoint): Likewise.
2413         (is_watchpoint): Likewise.
2414         (is_no_memory_software_watchpoint): Likewise.
2415         (is_catchpoint): Likewise.
2416         (breakpoint_1): Make FILTER parameter's return type bool.
2417         is_masked_watchpoint): Change return type to bool.
2418         (save_breakpoints): Make FILTER parameter's return type bool.
2419         * breakpoint.h (is_breakpoint): Change return type to bool.
2420         (is_watchpoint): Likewise.
2421         (is_catchpoint): Likewise.
2422         (is_tracepoint): Likewise.
2423
2424 2019-07-10  Tom Tromey  <tom@tromey.com>
2425
2426         * defs.h: Don't include gdbarch.h.
2427         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2428         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2429         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2430         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2431         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2432         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2433         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2434         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2435         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2436         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2437         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2438         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2439         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2440         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2441         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2442         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2443         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2444         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2445         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2446         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2447         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2448         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2449         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2450         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2451         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2452         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2453         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2454
2455 2019-07-10  Tom Tromey  <tromey@adacore.com>
2456
2457         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2458         * breakpoint.c (init_ada_exception_breakpoint): Register as
2459         bp_catchpoint.
2460         (print_one_breakpoint_location, print_one_breakpoint): Use
2461         is_ada_exception_catchpoint.
2462         * ada-lang.c (class ada_catchpoint_location): Pass
2463         bp_loc_software_breakpoint to bp_location constructor.
2464         (is_ada_exception_catchpoint): New function.
2465
2466 2019-07-10  Tom Tromey  <tromey@adacore.com>
2467
2468         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2469         VEC.
2470         (struct arm_exidx_entry): New method operator<.
2471         (struct arm_exidx_data) <section_maps>: Change type.
2472         (arm_exidx_data_free): Remove.
2473         (arm_exidx_data_key): Change type.  Move lower.
2474         (arm_exidx_new_objfile): Update.
2475         (arm_compare_exidx_entries): Remove.
2476         (arm_find_exidx_entry, _initialize_arm_tdep)
2477
2478 2019-07-10  Tom Tromey  <tromey@adacore.com>
2479
2480         * solib-spu.c (ocl_program_data_key): Change type.
2481         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2482         Update.
2483
2484 2019-07-10  Tom Tromey  <tromey@adacore.com>
2485
2486         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2487         (struct solib_aix_inferior_data) <library_list>: Change type.
2488         (solib_aix_inferior_data_handle): Change type.
2489         (get_solib_aix_inferior_data): Update.
2490         (solib_aix_free_library_list): Remove.
2491         (library_list_start_library): Update.
2492         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2493         return type.
2494         (solib_aix_get_library_list)
2495         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2496         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2497
2498 2019-07-10  Tom Tromey  <tromey@adacore.com>
2499
2500         * solib-dsbt.c (struct dsbt_info): Add initializers.
2501         (solib_dsbt_pspace_data): Change type.
2502         (dsbt_pspace_data_cleanup): Remove.
2503         (get_dsbt_info, _initialize_dsbt_solib): Update.
2504
2505 2019-07-10  Tom Tromey  <tromey@adacore.com>
2506
2507         * spu-tdep.c (spu_overlay_data): Change type.
2508         (spu_get_overlay_table, spu_overlay_new_objfile)
2509         (_initialize_spu_tdep): Update.
2510
2511 2019-07-10  Tom Tromey  <tromey@adacore.com>
2512
2513         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2514         destructor.
2515         (dbx_objfile_data_key): Change type and declare later.
2516         (DBX_SYMFILE_INFO): Rewrite.
2517         * dbxread.c (dbx_objfile_data_key): Change type.
2518         (dbx_symfile_init): Update.
2519         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2520         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2521         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2522
2523 2019-07-10  Tom Tromey  <tromey@adacore.com>
2524
2525         * jit.c (jit_program_space_key): Change type.  Move lower.
2526         (get_jit_program_space_data): Update.
2527         (jit_program_space_data_cleanup): Remove.
2528         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2529         Update.
2530         (struct jit_program_space_data): Add initializers.
2531
2532 2019-07-10  Tom Tromey  <tromey@adacore.com>
2533
2534         * solib-darwin.c (struct darwin_info): Add initializers.
2535         (solib_darwin_pspace_data): Change type.
2536         (darwin_pspace_data_cleanup): Remove.
2537         (get_darwin_info, _initialize_darwin_solib): Update.
2538
2539 2019-07-10  Tom Tromey  <tromey@adacore.com>
2540
2541         * remote-sim.c (struct sim_inferior_data): Add initializers,
2542         constructor, and destructor.
2543         (sim_inferior_data_key): Change type.  Move lower.
2544         (check_for_duplicate_sim_descriptor): Update.
2545         (get_sim_inferior_data): Use new.  Update.
2546         (~sim_inferior_data_cleanup): Rename from
2547         sim_inferior_data_cleanup.  Simplify.
2548         (gdbsim_close_inferior, simulator_command)
2549         (sim_command_completer, _initialize_remote_sim): Update.
2550         (next_pid, INITIAL_PID): Move earlier.
2551
2552 2019-07-10  Tom Tromey  <tromey@adacore.com>
2553
2554         * python/python-internal.h (create_thread_object): Return
2555         gdbpy_ref.
2556         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2557         * python/py-inferior.c (struct threadlist_entry): Add
2558         constructor.
2559         <thread_obj>: Now a gdbpy_ref.
2560         (thread_to_thread_object): Update.
2561         (add_thread_object): Use new.
2562         (delete_thread_object): Use delete.
2563         (infpy_threads): Update.
2564         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2565         GIL.
2566
2567 2019-07-10  Tom Tromey  <tromey@adacore.com>
2568
2569         * valops.c (value_cast): Specialize error message for Ada.
2570
2571 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2572
2573         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2574
2575 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2576
2577         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2578         bpstat_should_step): Return bool, adjust comments.
2579         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2580         bpstat_should_step): Likewise.
2581
2582 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2583
2584         * features/Makefile: Use feature target descriptions for Arm.
2585         * features/arm/arm-core.c: Generate new file.
2586         * features/arm/arm-fpa.c: Likewise.
2587         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2588         * features/arm/arm-m-profile.c: Likewise.
2589         * features/arm/arm-vfpv2.c: Likewise.
2590         * features/arm/arm-vfpv3.c: Likewise.
2591         * features/arm/xscale-iwmmxt.c: Likewise.
2592         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2593
2594 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2595
2596         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2597         ptrace earlier.
2598
2599 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2600
2601         * features/aarch64-pauth.c: Regenerate.
2602
2603 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2604
2605         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2606         bool.
2607         (bpstat_what): Use false instead of 0.
2608
2609 2019-07-09  Pedro Alves  <palves@redhat.com>
2610
2611         * break-catch-throw.c (is_exception_catchpoint): New.
2612         * breakpoint.c (print_one_breakpoint_location): New parameter
2613         'raw_loc'.  Handle it.  Use
2614         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2615         looking at the breakpoint's type.
2616         (print_one_breakpoint): If handling "maint info breakpoints", also
2617         print locations of exception catchpoints.
2618         * breakpoint.h (is_exception_catchpoint): Declare.
2619
2620 2019-07-09  Pedro Alves  <palves@redhat.com>
2621
2622         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2623         "addr" field.
2624         (allocate_location_exception_catchpoint): New.
2625         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2626         (initialize_throw_catchpoint_ops): Install
2627         allocate_location_exception_catchpoint as allocate_location
2628         method.
2629         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2630         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2631         bp_loc_other.
2632         (breakpoint_address_is_meaningful): Delete.
2633         (bl_address_is_meaningful): New.
2634         (breakpoint_locations_match): Adjust comment.
2635         (bp_location_from_bp_type): New, factored out of...
2636         (bp_location::bp_location(breakpoint *)): ... this.
2637         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2638         factored out of...
2639         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2640         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2641         breakpoint_address_is_meaningful.
2642         (bp_locations_compare): Adjust comment.
2643         (update_global_location_list): Use bl_address_is_meaningful
2644         instead of breakpoint_address_is_meaningful.
2645         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2646         explicit.
2647         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2648         * python/py-breakpoint.c (bppy_get_location): No longer check
2649         whether location is null.
2650
2651 2019-07-09  Pedro Alves  <palves@redhat.com>
2652
2653         PR c++/15468
2654         * breakpoint.c (print_one_breakpoint_location): Remove
2655         single-location assert.
2656
2657 2019-07-09  Tom Tromey  <tom@tromey.com>
2658
2659         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2660         * configure: Rebuild.
2661         * configure.ac: Change common to gdbsupport.
2662         * gdbsupport: Rename from common.
2663         * acinclude.m4: Change common to gdbsupport.
2664         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2665         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2666         gdbsupport.
2667         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2668         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2669         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2670         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2671         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2672         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2673         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2674         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2675         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2676         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2677         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2678         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2679         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2680         coff-pe-read.c, command.h, compile/compile-c-support.c,
2681         compile/compile-c.h, compile/compile-cplus-symbols.c,
2682         compile/compile-cplus-types.c, compile/compile-cplus.h,
2683         compile/compile-loc2c.c, compile/compile.c, completer.c,
2684         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2685         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2686         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2687         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2688         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2689         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2690         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2691         features/aarch64-core.c, features/aarch64-fpu.c,
2692         features/aarch64-pauth.c, features/aarch64-sve.c,
2693         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2694         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2695         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2696         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2697         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2698         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2699         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2700         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2701         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2702         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2703         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2704         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2705         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2706         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2707         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2708         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2709         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2710         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2711         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2712         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2713         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2714         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2715         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2716         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2717         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2718         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2719         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2720         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2721         minsyms.c, mips-linux-tdep.c, namespace.h,
2722         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2723         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2724         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2725         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2726         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2727         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2728         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2729         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2730         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2731         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2732         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2733         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2734         procfs.c, producer.c, progspace.h, psymtab.h,
2735         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2736         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2737         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2738         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2739         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2740         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2741         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2742         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2743         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2744         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2745         target-memory.c, target.c, target.h, target/waitstatus.c,
2746         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2747         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2748         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2749         unittests/array-view-selftests.c,
2750         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2751         unittests/common-utils-selftests.c,
2752         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2753         unittests/format_pieces-selftests.c,
2754         unittests/function-view-selftests.c,
2755         unittests/lookup_name_info-selftests.c,
2756         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2757         unittests/mkdir-recursive-selftests.c,
2758         unittests/observable-selftests.c,
2759         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2760         unittests/parse-connection-spec-selftests.c,
2761         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2762         unittests/scoped_fd-selftests.c,
2763         unittests/scoped_mmap-selftests.c,
2764         unittests/scoped_restore-selftests.c,
2765         unittests/string_view-selftests.c, unittests/style-selftests.c,
2766         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2767         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2768         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2769         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2770         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2771         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2772
2773 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2774
2775         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2776         bool value.
2777         (decode_digits_ordinary): Set explicit_line field in sal.
2778         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2779         symtab_and_line that was set on an explicit line number in
2780         assembler code.  Do always update the recorded symtab and line if
2781         we do skip the prologue.
2782
2783 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2784
2785         * breakpoint.c (set_breakpoint_location_function): Remove
2786         explicit_loc parameter.
2787         (momentary_breakpoint_from_master): Update call to
2788         set_breakpoint_location_function.
2789         (add_location_to_breakpoint): Likewise.
2790
2791 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2792
2793         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2794         required features based on default bfd type when no specific bfd
2795         is present.
2796
2797 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2798
2799         * NEWS: Mention that GDB printf and eval commands can now print
2800         C-style and Ada-style convenience var strings without
2801         calling the inferior.
2802         * printcmd.c (printf_c_string): Locally print GDB internal var
2803         instead of transiting via the inferior.
2804         (printf_wide_c_string): Likewise.
2805
2806 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2807
2808         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2809
2810 2019-07-04  Tom Tromey  <tom@tromey.com>
2811
2812         PR tui/24724:
2813         * tui/tui-winsource.c (tui_clear_source_content): Update.
2814         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2815         (tui_update_breakpoint_info): Update.
2816         (tui_set_exec_info_content): Update.
2817         * tui/tui-source.c (tui_set_source_content_nil): Update.
2818         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2819         has_break.
2820         * tui/tui-data.h (enum tui_bp_flag): New.
2821         (tui_bp_flags): New enum flags type.
2822         (struct tui_source_element) <break_mode>: Change type.  Rename
2823         from has_break.
2824         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2825         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2826         constants.
2827         * tui/tui-winsource.h: Fix comment.
2828
2829 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2830
2831         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2832         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2833         (store_fpregs_to_thread)
2834         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2835         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2836         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2837         (IWMMXT_REGS_SIZE): Add define.
2838         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2839         (fetch_vfp_regs, store_vfp_regs)
2840         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2841         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2842
2843 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2844
2845         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2846         defines.
2847         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2848         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2849         (ARM_INT_REGISTER_SIZE): ...to this.
2850         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2851         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2852         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2853         (arm_linux_collect_gregset, supply_nwfpe_register)
2854         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2855         defines.
2856         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2857         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2858         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2859         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2860         (arm_return_in_memory, arm_store_return_value)
2861         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2862         (arm_record_ld_st_multiple): Likewise.
2863         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2864         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2865
2866 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2867
2868         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2869         AARCH64_DISPLACED_MODIFIED_INSNS.
2870         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2871         (aarch64_displaced_step_copy_insn): Likewise.
2872         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2873         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2874         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2875         ARM_DISPLACED_MODIFIED_INSNS.
2876         * arm-tdep.c (arm_gdbarch_init): Likewise.
2877         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2878         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2879         (struct arm_displaced_step_closure): Use
2880         ARM_DISPLACED_MODIFIED_INSNS.
2881
2882 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2883
2884         * features/Makefile: Remove unused xml files.
2885         * features/aarch64.xml: Remove.
2886         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2887         * features/i386/amd64-avx-avx512.xml: Remove.
2888         * features/i386/amd64-avx-linux.xml: Remove.
2889         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2890         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2891         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2892         * features/i386/amd64-avx-mpx.xml: Remove.
2893         * features/i386/amd64-avx.xml: Remove.
2894         * features/i386/amd64-linux.xml: Remove.
2895         * features/i386/amd64-mpx-linux.xml: Remove.
2896         * features/i386/amd64-mpx.xml: Remove.
2897         * features/i386/amd64.xml: Remove.
2898         * features/i386/i386-avx-avx512-linux.xml: Remove.
2899         * features/i386/i386-avx-avx512.xml: Remove.
2900         * features/i386/i386-avx-linux.xml: Remove.
2901         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2902         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2903         * features/i386/i386-avx-mpx-linux.xml: Remove.
2904         * features/i386/i386-avx-mpx.xml: Remove.
2905         * features/i386/i386-avx.xml: Remove.
2906         * features/i386/i386-linux.xml: Remove.
2907         * features/i386/i386-mmx-linux.xml: Remove.
2908         * features/i386/i386-mmx.xml: Remove.
2909         * features/i386/i386-mpx-linux.xml: Remove.
2910         * features/i386/i386-mpx.xml: Remove.
2911         * features/i386/i386.xml: Remove.
2912         * features/i386/x32-avx-avx512-linux.xml: Remove.
2913         * features/i386/x32-avx-linux.xml: Remove.
2914         * features/i386/x32-linux.xml: Remove.
2915
2916 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2917
2918         * regformats/aarch64.dat: Remove.
2919         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2920         * regformats/i386/amd64-avx-linux.dat: Remove.
2921         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2922         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2923         * regformats/i386/amd64-linux.dat: Remove.
2924         * regformats/i386/amd64-mpx-linux.dat: Remove.
2925         * regformats/i386/amd64.dat: Remove.
2926         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2927         * regformats/i386/i386-avx-linux.dat: Remove.
2928         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2929         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2930         * regformats/i386/i386-linux.dat: Remove.
2931         * regformats/i386/i386-mmx-linux.dat: Remove.
2932         * regformats/i386/i386-mpx-linux.dat: Remove.
2933         * regformats/i386/i386.dat: Remove.
2934         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2935         * regformats/i386/x32-avx-linux.dat: Remove.
2936         * regformats/i386/x32-linux.dat: Remove.
2937
2938 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2939
2940         * aarch64-tdep.c: Remove xml self tests.
2941         * amd64-linux-tdep.c: Likewise.
2942         * amd64-tdep.c: Likewise.
2943         * i386-linux-tdep.c: Likewise.
2944         * i386-tdep.c: Likewise.
2945
2946 2019-07-03  Pedro Alves  <palves@redhat.com>
2947
2948         PR cli/24732
2949         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2950         (pipe_cmd_option_defs): New.
2951         (make_pipe_cmd_options_def_group): New.
2952         (pipe_command): Use gdb::option::process_options.
2953         (pipe_command_completer): New function.
2954         (_initialize_cli_cmds): Install completer for "pipe" command.
2955
2956 2019-07-03  Pedro Alves  <palves@redhat.com>
2957
2958         * cli/cli-option.c (union option_value) <string>: New field.
2959         (struct option_def_and_value): Add ctor, move ctor, dtor and
2960         use DISABLE_COPY_AND_ASSIGN.
2961         (option_def_and_value::clear_value): New.
2962         (parse_option, save_option_value_in_ctx, get_val_type_str)
2963         (add_setshow_cmds_for_options): Handle var_string.
2964         * cli-option.h (union option_def::var_address) <string>: New
2965         field.
2966         (struct string_option_def): New.
2967         * maint-test-options.c (struct test_options_opts): Add default
2968         ctor and use DISABLE_COPY_AND_ASSIGN.
2969         <string_opt>: New field.
2970         (test_options_opts::~test_options_opts): New.
2971         (test_options_opts::dump): Also dump "-string".
2972         (test_options_option_defs): Install "string.
2973
2974 2019-07-03  Pedro Alves  <palves@redhat.com>
2975
2976         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2977         option_value with a null enumeration.
2978         (complete_options): Save the option values in the context.
2979         (save_option_value_in_ctx): New, factored out from ...
2980         (process_options): ... here.
2981         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2982         of the function.
2983         * maint-test-options.c (test_options_opts::dump): New, factored
2984         out from ...
2985         (maintenance_test_options_command_mode): ... here.
2986         (maintenance_test_options_command_completion_result): Delete.
2987         (maintenance_test_options_command_completion_text): Update
2988         comment.
2989         (maintenance_show_test_options_completion_result): Change
2990         prototype.  Just print
2991         maintenance_test_options_command_completion_text.
2992         (save_completion_result): New.
2993         (maintenance_test_options_completer_mode): Pass options context to
2994         complete_options, and then save a dump.
2995         (_initialize_maint_test_options): Use add_cmd to install "maint
2996         show test-options-completion-result".
2997
2998 2019-07-03  Pedro Alves  <palves@redhat.com>
2999
3000         * NEWS (New commands): Mention "with" and "maint with".
3001         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3002         (with_command, with_command_completer): New.
3003         (pipe_command): Adjust to new repeat_previous
3004         interface.
3005         (_initialize_cli_cmds): Install the "with" command and its "w"
3006         alias.
3007         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3008         declarations.
3009         * cli/cli-setshow.c (parse_cli_var_uinteger)
3010         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3011         argument strings for all var_types.
3012         (get_setshow_command_value_string): New, factored out from ...
3013         (do_show_command): ... this.
3014         * cli/cli-setshow.h: Include <string>.
3015         (get_setshow_command_value_string): Declare.
3016         * command.h (repeat_previous): Now returns const char *.  Adjust
3017         comment.
3018         * maint.c: Include "cli/cli-cmds.h".
3019         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3020         (_initialize_maint_cmds): Register the "maintenance with" command.
3021         * top.c (repeat_previous): Move bits from pipe_command here:
3022         Return the saved command line, if any; error out if there's no
3023         command to relaunch.
3024
3025 2019-07-03  Pedro Alves  <palves@redhat.com>
3026
3027         * NEWS (New commands): Mention "maint set/show test-settings"
3028         instead of "maint test-settings".
3029         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3030         (maintenance_test_settings_set_list): Rename to ...
3031         (maintenance_set_test_settings_list): ... this.
3032         (maintenance_test_settings_show_list): Rename to  ...
3033         (maintenance_show_test_settings_list): ... this.
3034         (maintenance_test_settings_cmd): Delete.
3035         (maintenance_test_settings_set_cmd): ...
3036         (maintenance_set_test_settings_cmd): ... this.
3037         (maintenance_test_settings_show_cmd): ...
3038         (maintenance_show_test_settings_cmd): ... this.
3039         (maintenance_test_settings_show_value_cmd):
3040         (maintenance_show_test_settings_value_cmd): ... this.
3041         (_initialize_maint_test_settings): No longer install the "maint
3042         test-settings" prefix command.  Rename "maint test-settings set"
3043         to "maint set test-settings", and "maint test-settings show" to
3044         "maint show test-settings".  Adjust all subcommands.
3045
3046 2019-07-03  Pedro Alves  <palves@redhat.com>
3047
3048         * maint-test-settings.c: Fix file's intro comment.  Replace all
3049         references to "test-options" with references to "test-settings",
3050         in comments.
3051
3052 2019-07-03  Pedro Alves  <palves@redhat.com>
3053
3054         * maint-test-settings.c (maintenance_test_settings_xxx)
3055         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3056         New.
3057         (maintenance_test_settings_enums): Use them.
3058         (maintenance_test_settings_enum): Default to
3059         maintenance_test_settings_xxx.
3060         (_initialize_maint_test_settings): Initialize
3061         MAINTENANCE_TEST_SETTINGS_FILENAME.
3062
3063 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3064
3065         * breakpoint.h (remove_breakpoints_inf): Change return type to
3066         void, move function documentation here.
3067         * breakpoint.c (remove_breakpoints_inf): Change return type to
3068         void, move function documentation to header.
3069
3070 2019-07-02  Pedro Alves  <palves@redhat.com>
3071
3072         * NEWS (Completion improvements): Mention "info threads".
3073         * thread.c (struct info_threads_opts, info_threads_option_defs)
3074         (make_info_threads_options_def_group): New.
3075         (info_threads_command): Use gdb::option::process_options.
3076         (info_threads_command_completer): New.
3077         (_initialize_thread): Use gdb::option::build_help to build the
3078         help text for "info threads".
3079
3080 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3081
3082         * defs.h (generic_load): Move from here...
3083         * symfile.h (generic_load): ... to here.  Rename name parameter
3084         to args.
3085         * symfile.c (generic_load): Add comment.
3086
3087 2019-07-01  Tom Tromey  <tromey@adacore.com>
3088
3089         * dwarf2read.c
3090         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3091         declaration of without_params.  Fix formatting.
3092
3093 2019-07-01  Tom Tromey  <tromey@adacore.com>
3094
3095         * ada-exp.y (find_primitive_type): Update.
3096         * ada-lang.h (ada_lookup_symbol): Update.
3097         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3098         parameter.
3099         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3100
3101 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3102
3103         PR breakpoints/24541
3104         * gdbarch.c: Regenerate.
3105         * gdbarch.h: Regenerate.
3106         * gdbarch.sh: Add 'stap_adjust_register'.
3107         * i386-tdep.c: Include '<unordered_set>'.
3108         (i386_stap_adjust_register): New function.
3109         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3110         * stap-probe.c (stap_parse_register_operand): Call
3111         'gdbarch_stap_adjust_register'.
3112
3113 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3114
3115         PR python/24742
3116         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3117         * python/python.c (do_start_initialization): Use 'xmalloc'
3118         instead of 'PyMem_Malloc'.
3119
3120 2019-06-28  Tom Tromey  <tromey@adacore.com>
3121
3122         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3123         for Ada.
3124
3125 2019-06-27  Tom Tromey  <tromey@adacore.com>
3126
3127         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3128         objfile_key.
3129         (arm_find_mapping_symbol, arm_record_special_symbol)
3130         (_initialize_arm_tdep): Update.
3131         (arm_objfile_data_free): Remove.
3132
3133 2019-06-27  Tom Tromey  <tromey@adacore.com>
3134
3135         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3136         to cp_print_static_field.
3137
3138 2019-06-26  Tom Tromey  <tromey@adacore.com>
3139
3140         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3141         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3142         declare.
3143
3144 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3145
3146         * features/aarch64-core.c (create_feature_aarch64_core):
3147         Regenerate.
3148         * features/aarch64-core.xml: Add cpsr flags.
3149
3150 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3151
3152         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3153         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3154
3155 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3156
3157         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3158         field.
3159         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3160         use.
3161         (arm_record_special_symbol): Don't insert new symbol in sorted
3162         position, push it at the end.
3163
3164 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3165
3166         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3167         (arm_mapping_symbol_s): Remove.
3168         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3169         (arm_mapping_symbol_vec): New typedef.
3170         (struct arm_per_objfile): Add constructor.
3171         <section_maps>: Change type to
3172         std::unique_ptr<arm_mapping_symbol_vec[]>.
3173         (arm_compare_mapping_symbols): Remove.
3174         (arm_find_mapping_symbol): Adjust to section_maps type change.
3175         (arm_objfile_data_free): Call delete on arm_per_objfile.
3176         (arm_record_special_symbol): Adjust to section_maps type change.
3177         Allocate arm_per_objfile with new.
3178
3179 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3180
3181         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3182         with the command prefix.
3183
3184 2019-06-25  Tom Tromey  <tom@tromey.com>
3185
3186         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3187         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3188
3189 2019-06-25  Tom Tromey  <tom@tromey.com>
3190
3191         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3192         type.
3193         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3194         protected.
3195
3196 2019-06-25  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui-winsource.c
3199         (tui_source_window_base::set_is_exec_point_at): Add check against
3200         LOA_ADDRESS.
3201
3202 2019-06-25  Tom Tromey  <tom@tromey.com>
3203
3204         * tui/tui-source.c (tui_set_source_content): Don't check before
3205         xfree.
3206         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3207
3208 2019-06-25  Tom Tromey  <tom@tromey.com>
3209
3210         * tui/tui-winsource.h (tui_update_source_window_as_is)
3211         (tui_alloc_source_buffer, tui_line_is_displayed)
3212         (tui_addr_is_displayed): Change type of win_info.
3213         * tui/tui-winsource.c (tui_update_source_window_as_is)
3214         (tui_clear_source_content, tui_show_source_line)
3215         (tui_show_source_content, tui_source_window_base::refill)
3216         (tui_source_window_base::set_is_exec_point_at)
3217         (tui_source_window_base::set_is_exec_point_at)
3218         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3219         (tui_alloc_source_buffer, tui_line_is_displayed)
3220         (tui_addr_is_displayed): Change type of win_info.  Update.
3221         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3222         (tui_source_window_base::do_make_visible_with_new_height):
3223         Update.
3224         * tui/tui-source.c (tui_set_source_content)
3225         (tui_set_source_content_nil)
3226         (tui_source_window::do_scroll_vertical): Update.
3227         * tui/tui-layout.c (show_layout): Update.
3228         * tui/tui-disasm.c (tui_set_disassem_content)
3229         (tui_disasm_window::do_scroll_vertical): Update.
3230         * tui/tui-data.h (tui_win_content): Remove.
3231         (struct tui_gen_win_info) <content, content_size>: Remove.
3232         (struct tui_source_element): Add initializers and destructor.
3233         (union tui_which_element, struct tui_win_element): Remove.
3234         (struct tui_source_window_base) <content>: New field.
3235         (struct tui_data_window): Remove destructor.
3236         (tui_alloc_content, tui_free_win_content)
3237         (tui_free_all_source_wins_content): Don't declare.
3238         * tui/tui-data.c (tui_initialize_static_data): Update.
3239         (init_content_element, tui_alloc_content): Remove.
3240         (~tui_gen_win_info): Update.
3241         (~tui_data_window, tui_free_all_source_wins_content)
3242         (tui_free_win_content, free_content, free_content_elements):
3243         Remove.
3244
3245 2019-06-25  Tom Tromey  <tom@tromey.com>
3246
3247         * tui/tui-winsource.h (tui_clear_source_content)
3248         (tui_erase_source_content, tui_show_source_content): Change type
3249         of win_info.
3250         * tui/tui-winsource.c (tui_clear_source_content)
3251         (tui_erase_source_content, tui_show_source_content): Change type
3252         of win_info.
3253         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3254         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3255         win_info.
3256         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3257         win_info.
3258         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3259
3260 2019-06-25  Tom Tromey  <tom@tromey.com>
3261
3262         * tui/tui-winsource.c (tui_clear_source_content)
3263         (tui_source_window_base::set_is_exec_point_at): Update.
3264         * tui/tui-source.c (tui_set_source_content_nil): Update.
3265         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3266         a bool.
3267         * tui/tui-data.c (init_content_element): Update.
3268
3269 2019-06-25  Tom Tromey  <tom@tromey.com>
3270
3271         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3272         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3273         * tui/tui-layout.c (init_and_make_win): Update.
3274         * tui/tui.h (enum tui_win_type): Update.
3275         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3276         tui_win_is_auxillary.
3277         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3278         tui_win_is_auxillary.
3279
3280 2019-06-25  Tom Tromey  <tom@tromey.com>
3281
3282         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3283         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3284         (tui_delete_data_content_windows, tui_display_all_data)
3285         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3286         Update.
3287         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3288         * tui/tui-regs.c (tui_last_regs_line_no)
3289         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3290         (tui_show_registers): Update.
3291         (tui_show_register_group): Return void.  Update.
3292         (tui_display_registers_from, tui_display_reg_element_at_line)
3293         (tui_display_registers_from_line, tui_check_register_values):
3294         Update.
3295         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3296         member.
3297         (struct tui_data_window) <regs_content>: Now a std::vector.
3298         <regs_content_count>: Remove.
3299         (tui_add_content_elements, tui_free_data_content): Don't declare.
3300         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3301         (init_content_element): Remove DATA_WIN case.  Add assert.
3302         (tui_add_content_elements): Remove.
3303         (tui_data_window): Update.
3304         (tui_free_data_content): Remove.
3305         (free_content_elements): Remove DATA_WIN case.
3306
3307 2019-06-25  Tom Tromey  <tom@tromey.com>
3308
3309         * tui/tui-data.c (tui_data_item_window): Update.
3310         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3311         * tui/tui-windata.c (tui_display_all_data)
3312         (tui_display_data_from_line): Update.
3313         (tui_check_data_values): Remove.
3314         * tui/tui-regs.c (tui_show_register_group)
3315         (tui_display_reg_element_at_line): Update.
3316         * tui/tui-hooks.c (tui_register_changed)
3317         (tui_refresh_frame_and_register_information): Call
3318         tui_check_register_values.
3319         * tui/tui-data.h (struct tui_data_window) <data_content,
3320         data_content_count, data_type>: Remove.
3321         (enum tui_data_type): Remove.
3322
3323         * tui/tui-data.c (tui_data_window::clear_detail)
3324         (~tui_data_window): Update.
3325
3326 2019-06-25  Tom Tromey  <tom@tromey.com>
3327
3328         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3329         declare.
3330         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3331         Rename from tui_first_data_item_displayed.  Update.
3332         (tui_data_window::refresh_all)
3333         (tui_data_window::do_scroll_vertical): Update.
3334         * tui/tui-data.h (struct tui_data_window)
3335         <first_data_item_displayed>: Declare new method.
3336
3337 2019-06-25  Tom Tromey  <tom@tromey.com>
3338
3339         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3340         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3341         contents...
3342         (tui_initialize_static_data): ...here.
3343
3344 2019-06-25  Tom Tromey  <tom@tromey.com>
3345
3346         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3347         (tui_display_registers_from, tui_check_register_values): Update.
3348         (tui_display_register): Remove win_info parameter; update.
3349         (tui_get_register): Change type of parameters.
3350         * tui/tui-data.h (struct tui_data_element): Remove.
3351         (union tui_which_element) <data>: Remove.
3352         <data_window>: Change type.
3353         (struct tui_data_item_window): New.
3354         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3355         case.  Add assert.
3356         (~tui_data_item_window): New destructor.
3357         (free_content_elements): Remove DATA_ITEM_WIN case.
3358
3359 2019-06-25  Tom Tromey  <tom@tromey.com>
3360
3361         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3362         Remove.
3363
3364 2019-06-25  Tom Tromey  <tom@tromey.com>
3365
3366         * tui/tui-data.h (struct tui_command_element): Remove.
3367         (union tui_which_element) <command>: Remove.
3368         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3369         assert.
3370         (free_content_elements): Remove CMD_WIN case.
3371
3372 2019-06-25  Tom Tromey  <tom@tromey.com>
3373
3374         * tui/tui-layout.c (tui_set_layout): Update.
3375         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3376         * tui/tui-data.c (layout_def): Update.
3377
3378 2019-06-25  Tom Tromey  <tom@tromey.com>
3379
3380         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3381         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3382         (tui_source_window_base::set_new_height): Update.
3383         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3384         Update.
3385         (tui_set_locator_fullname, tui_set_locator_info)
3386         (tui_show_frame_info): Update.
3387         * tui/tui-source.c (tui_set_source_content)
3388         (tui_source_is_displayed): Update.
3389         * tui/tui-layout.c (show_source_disasm_command, show_data)
3390         (show_source_or_disasm_and_command): Update.
3391         * tui/tui-disasm.c (tui_set_disassem_content)
3392         (tui_get_begin_asm_address): Update.
3393         * tui/tui-data.h (struct tui_locator_element): Remove.
3394         (union tui_which_element) <locator>: Remove.
3395         (struct tui_locator_window): New.
3396         (tui_locator_win_info_ptr): Change return type.
3397         * tui/tui-data.c (_locator): Change type.
3398         (tui_locator_win_info_ptr): Change return type.
3399         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3400         (tui_alloc_content): Add assert.
3401
3402 2019-06-25  Tom Tromey  <tom@tromey.com>
3403
3404         * tui/tui-winsource.c
3405         (tui_exec_info_window::maybe_allocate_content): New method.
3406         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3407         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3408         (make_source_or_disasm_window): Add cast.
3409         * tui/tui-data.h (union tui_which_element) <simple_string>:
3410         Remove.
3411         (struct tui_source_info): New.
3412         (struct tui_source_window_base) <execution_info>: Change type.
3413         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3414         case, and add assert.
3415         (tui_alloc_content): Add assert.
3416
3417 2019-06-25  Tom Tromey  <tom@tromey.com>
3418
3419         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3420         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3421         * tui/tui-data.c (tui_alloc_win_info): Remove.
3422
3423 2019-06-25  Tom Tromey  <tom@tromey.com>
3424
3425         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3426         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3427         can_highlight.
3428
3429 2019-06-25  Tom Tromey  <tom@tromey.com>
3430
3431         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3432         make_visible_with_new_height method.
3433         (tui_win_info::make_visible_with_new_height): New method.
3434         (tui_source_window_base::do_make_visible_with_new_height)
3435         (tui_data_window::do_make_visible_with_new_height)
3436         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3437         (make_visible_with_new_height): Remove.
3438         (tui_resize_all, tui_adjust_win_heights): Use
3439         make_visible_with_new_height method.
3440         * tui/tui-data.h (struct tui_win_info)
3441         <do_make_visible_with_new_height, make_visible_with_new_height>:
3442         New methods.
3443         (struct tui_source_window_base, struct tui_data_window)
3444         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3445         methods.
3446
3447 2019-06-25  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3450         method.
3451         (update_tab_width): Call update_tab_width method.
3452         * tui/tui-data.h (struct tui_win_info)
3453         (struct tui_source_window_base) <update_tab_width>: New methods.
3454
3455 2019-06-25  Tom Tromey  <tom@tromey.com>
3456
3457         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3458         parameter.
3459         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3460         parameter.
3461         (tui_gen_win_info::make_visible): Update.
3462         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3463         parameter.
3464         * tui/tui-data.h (enum tui_box): New enum.
3465         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3466
3467 2019-06-25  Tom Tromey  <tom@tromey.com>
3468
3469         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3470         init_and_make_win for EXEC_INFO_WIN.
3471         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3472         longer inline.
3473         (struct tui_win_info) <~tui_win_info>: Inline.
3474         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3475         Don't declare.
3476         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3477         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3478         Remove.
3479         (tui_initialize_static_data): Update.
3480         (~tui_gen_win_info): Handle more cleanup here.
3481         (~tui_source_window_base): Delete "execution_info".
3482         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3483
3484 2019-06-25  Tom Tromey  <tom@tromey.com>
3485
3486         * tui/tui-layout.c (make_command_window): Don't set
3487         can_highlight.
3488         (show_source_disasm_command): Call the reset method.
3489         (show_data): Don't set can_highlight.  Call the reset method.
3490         (tui_gen_win_info::reset): Rename from init_gen_win_info
3491         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3492         (show_source_or_disasm_and_command): Call the reset method.
3493         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3494         (struct tui_cmd_window): Set can_highlight.
3495
3496 2019-06-25  Tom Tromey  <tom@tromey.com>
3497
3498         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3499         from make_visible.
3500         (tui_make_visible, tui_make_invisible): Rewrite.
3501         (tui_win_info::make_visible): Remove.
3502         (tui_source_window_base::make_visible): Update.
3503         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3504         method.  Moved from...
3505         (struct tui_win_info) <make_visible>: ...here.
3506
3507 2019-06-25  Tom Tromey  <tom@tromey.com>
3508
3509         * tui/tui-winsource.c
3510         (tui_source_window_base::do_scroll_horizontal): Remove direction
3511         parameter.
3512         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3513         direction parameter.
3514         * tui/tui-win.c (tui_win_info::forward_scroll)
3515         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3516         (tui_win_info::right_scroll): Update.
3517         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3518         direction parameter.
3519         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3520         direction parameter.
3521         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3522         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3523         Remove direction parameter.
3524         (struct tui_source_window_base, struct tui_source_window)
3525         (struct tui_disasm_window, struct tui_data_window)
3526         (struct tui_cmd_window): Update.
3527
3528 2019-06-25  Tom Tromey  <tom@tromey.com>
3529
3530         * tui/tui-winsource.h (tui_set_exec_info_content)
3531         (tui_show_exec_info_content, tui_erase_exec_info_content)
3532         (tui_clear_exec_info_content, tui_update_exec_info): Change
3533         argument to tui_source_window_base.
3534         * tui/tui-winsource.c (tui_set_exec_info_content)
3535         (tui_show_exec_info_content, tui_erase_exec_info_content)
3536         (tui_clear_exec_info_content, tui_update_exec_info): Change
3537         argument to tui_source_window_base.
3538
3539 2019-06-25  Tom Tromey  <tom@tromey.com>
3540
3541         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3542         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3543
3544 2019-06-25  Tom Tromey  <tom@tromey.com>
3545
3546         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3547         check.
3548
3549 2019-06-25  Tom Tromey  <tom@tromey.com>
3550
3551         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3552         type to void.
3553         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3554         type to void.
3555         * tui/tui-source.c (tui_set_source_content): Update.
3556         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3557
3558 2019-06-25  Tom Tromey  <tom@tromey.com>
3559
3560         * tui/tui-win.c (window_name_completer, tui_set_focus)
3561         (tui_all_windows_info): Use name method.
3562         * tui/tui-data.h (struct tui_gen_win_info)
3563         (struct tui_source_window, struct tui_disasm_window)
3564         (struct tui_data_window, struct tui_cmd_window) <name>: New
3565         method.
3566         (tui_win_name): Don't declare.
3567         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3568         (tui_win_name): Remove.
3569
3570 2019-06-25  Tom Tromey  <tom@tromey.com>
3571
3572         * tui/tui-winsource.h (tui_update_source_window)
3573         (tui_update_source_window_as_is): Change parameter type.
3574         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3575         to be a tui_source_window_base.
3576         (tui_update_source_window_as_is): Likewise.
3577         * tui/tui-win.c (make_visible_with_new_height): Update.
3578
3579 2019-06-25  Tom Tromey  <tom@tromey.com>
3580
3581         * tui/tui-winsource.c (tui_erase_source_content)
3582         (tui_show_source_content, tui_show_exec_info_content)
3583         (tui_erase_exec_info_content): Use refresh_window method.
3584         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3585         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3586         from tui_refresh_win.
3587         (tui_data_window::refresh_window): New method.
3588         (tui_win_info::refresh, tui_source_window_base::refresh)
3589         (tui_refresh_all): Use refresh_window method.
3590         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3591         method.
3592         * tui/tui-regs.c (tui_display_register): Call refresh_window
3593         method.
3594         * tui/tui-layout.c (show_source_disasm_command)
3595         (show_source_or_disasm_and_command): Call refresh_window method.
3596         * tui/tui-data.h (struct tui_gen_win_info)
3597         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3598         New method.
3599
3600 2019-06-25  Tom Tromey  <tom@tromey.com>
3601
3602         * tui/tui.c (tui_rl_other_window, tui_enable)
3603         (tui_is_window_visible, tui_get_command_dimension): Update.
3604         * tui/tui-winsource.c (tui_update_source_window_as_is)
3605         (tui_clear_source_content, tui_erase_source_content)
3606         (tui_show_source_line, tui_source_window_base::refill)
3607         (tui_source_window_base::do_scroll_horizontal)
3608         (tui_source_window_base::set_is_exec_point_at)
3609         (tui_update_breakpoint_info, tui_set_exec_info_content)
3610         (tui_alloc_source_buffer, tui_line_is_displayed)
3611         (tui_addr_is_displayed): Update.
3612         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3613         (tui_check_and_display_highlight_if_needed)
3614         (tui_win_info::make_visible, tui_win_info::refresh)
3615         (tui_refresh_all): Update.
3616         * tui/tui-windata.c (tui_first_data_item_displayed)
3617         (tui_delete_data_content_windows, tui_erase_data_content)
3618         (tui_display_all_data, tui_data_window::refresh_all)
3619         (tui_check_data_values): Update.
3620         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3621         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3622         (tui_win_info::backward_scroll, tui_refresh_all_win)
3623         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3624         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3625         (tui_source_window_base::set_new_height)
3626         (tui_data_window::set_new_height)
3627         (make_invisible_and_set_new_height)
3628         (make_visible_with_new_height, new_height_ok)
3629         (parse_scrolling_args): Update.
3630         * tui/tui-stack.c (tui_show_frame_info): Update.
3631         * tui/tui-source.c (tui_set_source_content)
3632         (tui_set_source_content_nil, tui_source_is_displayed)
3633         (tui_source_window::do_scroll_vertical): Update.
3634         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3635         (tui_display_registers_from, tui_display_reg_element_at_line)
3636         (tui_check_register_values, tui_reg_command): Update.
3637         * tui/tui-layout.c (tui_default_win_height)
3638         (show_source_disasm_command, show_data, init_and_make_win)
3639         (show_source_or_disasm_and_command): Update.
3640         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3641         (tui_redisplay_readline, tui_mld_flush)
3642         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3643         (tui_getc): Update.
3644         * tui/tui-disasm.c (tui_set_disassem_content)
3645         (tui_disasm_window::do_scroll_vertical): Update.
3646         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3647         Now virtual.
3648         (struct tui_win_info): Derive from tui_gen_win_info.
3649         <~tui_win_info>: Mark as override.
3650         <generic>: Remove member.
3651         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3652         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3653         (~tui_data_window, ~tui_win_info)
3654         (tui_free_all_source_wins_content): Update.
3655         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3656
3657 2019-06-25  Tom Tromey  <tom@tromey.com>
3658
3659         * tui/tui-layout.c (init_and_make_win): Use new.
3660         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3661         destructor, initializers.
3662         (tui_alloc_generic_win_info): Don't declare.
3663         * tui/tui-data.c (_locator): Add argument to constructor.
3664         (source_win, disasm_win): New globals.
3665         (exec_info): Remove.
3666         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3667         Update.
3668         (tui_alloc_generic_win_info): Remove.
3669         (init_content_element): Use new.
3670         (tui_win_info::tui_win_info): Update.
3671         (free_content_elements) <case DATA_WIN>: Use delete.
3672
3673 2019-06-25  Tom Tromey  <tom@tromey.com>
3674
3675         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3676         * tui/tui-windata.c (tui_first_data_item_displayed)
3677         (tui_delete_data_content_windows): Update.
3678         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3679         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3680         (tui_display_registers_from, tui_check_register_values): Update.
3681         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3682         pointer.
3683         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3684         window.
3685         (tui_free_data_content): Update.
3686         (free_content_elements) <case DATA_WIN>: Free the window.
3687
3688 2019-06-25  Tom Tromey  <tom@tromey.com>
3689
3690         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3691         Update.
3692         * tui/tui-layout.c (make_command_window)
3693         (show_source_disasm_command, show_data, init_and_make_win)
3694         (show_source_or_disasm_and_command): Update.
3695         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3696         method.
3697         <can_highight, is_highlighted>: Now bool.
3698         (tui_set_win_highlight): Don't declare.
3699         * tui/tui-data.c (tui_set_win_highlight): Remove.
3700
3701 2019-06-25  Tom Tromey  <tom@tromey.com>
3702
3703         * tui/tui-wingeneral.c (make_visible): Remove check of window
3704         type.
3705
3706 2019-06-25  Tom Tromey  <tom@tromey.com>
3707
3708         * tui/tui-win.c (tui_win_info::max_height)
3709         (tui_cmd_window::max_height): New methods.
3710         (new_height_ok): Call max_height.
3711         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3712         <max_height>: New method.
3713
3714 2019-06-25  Tom Tromey  <tom@tromey.com>
3715
3716         * tui/tui-win.c (tui_source_window_base::set_new_height)
3717         (tui_data_window::set_new_height): New methods.
3718         (make_invisible_and_set_new_height): Call set_new_height method.
3719         * tui/tui-data.h (struct tui_win_info)
3720         (struct tui_source_window_base, struct tui_data_window)
3721         <set_new_height>: New method.
3722
3723 2019-06-25  Tom Tromey  <tom@tromey.com>
3724
3725         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3726         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3727         tui_refresh_data_win.
3728         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3729         method.
3730         (tui_refresh_all_win): Call the refresh_all method.
3731         (tui_set_focus): Likewise.
3732         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3733         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3734         Likewise.
3735
3736 2019-06-25  Tom Tromey  <tom@tromey.com>
3737
3738         * tui/tui-winsource.h (tui_refill_source_window)
3739         (tui_set_is_exec_point_at): Don't declare.
3740         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3741         (tui_source_window_base::refill): Rename from
3742         tui_refill_source_window.
3743         (tui_source_window_base::do_scroll_horizontal): Update.
3744         (tui_source_window_base::set_is_exec_point_at): Rename from
3745         tui_set_is_exec_point_at.
3746         (tui_update_all_breakpoint_info): Update.
3747         * tui/tui-stack.c (tui_show_frame_info): Update.
3748         * tui/tui-layout.c (show_data): Add cast.
3749         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3750         * tui/tui-data.h (struct tui_source_window_base) <refill,
3751         set_is_exec_point_at>: New methods.
3752         (tui_source_windows, tui_add_to_source_windows): Update types.
3753         (tui_add_to_source_windows): Remove redundant declaration.
3754         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3755         (tui_source_windows): Change return type.
3756         (tui_clear_source_windows_detail): Update.
3757         (tui_add_to_source_windows): Change type of parameter.
3758         (tui_free_all_source_wins_content): Update.
3759
3760 2019-06-25  Tom Tromey  <tom@tromey.com>
3761
3762         * tui/tui-wingeneral.c (tui_win_info::refresh)
3763         (tui_source_window_base::refresh): New methods.
3764         (tui_refresh_all): Call the refresh method.
3765         * tui/tui-data.h (struct tui_win_info)
3766         (struct tui_source_window_base) <refresh>: New method.
3767
3768 2019-06-25  Tom Tromey  <tom@tromey.com>
3769
3770         * tui/tui.h (tui_is_window_visible): Return bool.
3771         * tui/tui.c (tui_is_window_visible): Return bool.
3772         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3773         (tui_make_visible, tui_make_invisible)
3774         (tui_win_info::make_visible)
3775         (tui_source_window_base::make_visible, make_all_visible)
3776         (tui_make_all_visible, tui_make_all_invisible): Update.
3777         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3778         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3779         bool.
3780         (struct tui_win_info, struct tui_source_window_base)
3781         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3782         * tui/tui-data.c (tui_init_generic_part): Update.
3783
3784 2019-06-25  Tom Tromey  <tom@tromey.com>
3785
3786         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3787         (tui_source_window_base::make_visible): New methods.
3788         (make_all_visible): Make method call.
3789         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3790         (struct tui_source_window_base, struct tui_cmd_window): Override
3791         make_visible.
3792         (tui_win_is_source_type): Don't declare.
3793         * tui/tui-data.c (tui_win_is_source_type): Remove.
3794
3795 2019-06-25  Tom Tromey  <tom@tromey.com>
3796
3797         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3798         NULL check.
3799
3800 2019-06-25  Tom Tromey  <tom@tromey.com>
3801
3802         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3803         Inline constructor.  Add initializers for members.
3804         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3805         constructors; now inline in class.
3806
3807 2019-06-25  Tom Tromey  <tom@tromey.com>
3808
3809         * tui/tui-regs.c (tui_show_registers): Update.
3810         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3811         bool.
3812         * tui/tui-data.c (tui_data_window::clear_detail)
3813         (tui_data_window): Update.
3814
3815 2019-06-25  Tom Tromey  <tom@tromey.com>
3816
3817         * tui/tui-windata.c (tui_display_all_data)
3818         (tui_display_data_from_line, tui_display_data_from)
3819         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3820         Update.
3821         * tui/tui-regs.c (tui_last_regs_line_no)
3822         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3823         (tui_show_registers, tui_show_register_group)
3824         (tui_display_registers_from, tui_display_reg_element_at_line)
3825         (tui_display_registers_from_line, tui_check_register_values)
3826         (tui_reg_next, tui_reg_prev): Update.
3827         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3828         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3829         tui_data_window.
3830         (struct tui_win_info) <detail>: Remove.  Add new fields from
3831         tui_data_info.
3832         (TUI_DATA_WIN): Add cast.
3833         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3834         (~tui_data_window): Simplify.
3835
3836 2019-06-25  Tom Tromey  <tom@tromey.com>
3837
3838         * tui/tui-layout.c (show_source_disasm_command)
3839         (show_source_or_disasm_and_command): Update.
3840         * tui/tui-io.c (update_cmdwin_start_line)
3841         (tui_redisplay_readline): Update.
3842         * tui/tui-data.h (struct tui_command_info): Remove.
3843         (struct tui_win_info) <detail>: Remove command_info member.
3844         (struct tui_data_window) <start_line>: New member, from
3845         tui_command_info.
3846         (TUI_CMD_WIN): Add casts.
3847
3848 2019-06-25  Tom Tromey  <tom@tromey.com>
3849
3850         * tui/tui-winsource.c (tui_update_source_window)
3851         (tui_refill_source_window)
3852         (tui_source_window_base::do_scroll_horizontal)
3853         (tui_update_breakpoint_info, tui_set_exec_info_content)
3854         (tui_show_exec_info_content, tui_erase_exec_info_content)
3855         (tui_clear_exec_info_content): Update.
3856         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3857         Update.
3858         * tui/tui-win.c (make_invisible_and_set_new_height)
3859         (make_visible_with_new_height): Update.
3860         * tui/tui-source.c (tui_set_source_content)
3861         (tui_show_symtab_source): Update.
3862         * tui/tui-layout.c (extract_display_start_addr)
3863         (show_source_disasm_command, show_data)
3864         (make_source_or_disasm_window)
3865         (show_source_or_disasm_and_command): Update.
3866         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3867         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3868         "gdbarch".
3869         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3870         to tui_source_window_base.
3871         (struct tui_win_info) <detail>: Remove source_info member.
3872         (struct tui_source_window_base) <has_locator>: Inline.
3873         Move contents from tui_source_info; rename has_locator member to
3874         m_has_locator.
3875         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3876         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3877         header file.
3878         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3879         Simplify.
3880         (tui_free_all_source_wins_content): Cast to
3881         tui_source_window_base.
3882
3883 2019-06-25  Tom Tromey  <tom@tromey.com>
3884
3885         * tui/tui-win.c (make_invisible_and_set_new_height)
3886         (make_visible_with_new_height): Call has_locator method.
3887         * tui/tui-layout.c (show_source_disasm_command, show_data)
3888         (show_source_or_disasm_and_command): Update for bool change.
3889         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3890         (tui_win_info) <has_locator>: New method.
3891         (struct tui_source_window_base) <has_locator>: New method.
3892         (tui_win_has_locator): Don't declare.
3893         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3894         from tui_win_has_locator.
3895         (tui_source_window_base): Use false, not FALSE.
3896
3897 2019-06-25  Tom Tromey  <tom@tromey.com>
3898
3899         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3900         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3901         clear_detail method directly.
3902         (tui_clear_win_detail): Remove.
3903
3904 2019-06-25  Tom Tromey  <tom@tromey.com>
3905
3906         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3907         "this", not TUI_DISASM_WIN.
3908
3909 2019-06-25  Tom Tromey  <tom@tromey.com>
3910
3911         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3912         declare.
3913         * tui/tui-winsource.c
3914         (tui_source_window_base::do_scroll_horizontal): Rename from
3915         tui_horizontal_source_scroll.
3916         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3917         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3918         from tui_vertical_data_scroll.
3919         * tui/tui-win.h (tui_scroll): Don't declare.
3920         * tui/tui-win.c (tui_win_info::forward_scroll)
3921         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3922         (tui_win_info::right_scroll): Rename and update.
3923         (tui_scroll_forward_command, tui_scroll_backward_command)
3924         (tui_scroll_left_command, tui_scroll_right_command): Update.
3925         (tui_scroll): Remove.
3926         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3927         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3928         from tui_vertical_source_scroll.
3929         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3930         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3931         from tui_vertical_disassem_scroll.
3932         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3933         do_scroll_horizontal>: New methods.
3934         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3935         Likewise.
3936         (struct tui_source_window_base): Add do_scroll_horizontal.
3937         (struct tui_source_window, struct tui_disasm_window): Add
3938         do_scroll_vertical.
3939         (struct tui_data_window, struct tui_cmd_window): Add
3940         do_scroll_horizontal and do_scroll_vertical.
3941         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3942
3943 2019-06-25  Tom Tromey  <tom@tromey.com>
3944
3945         * tui/tui-data.h (struct tui_source_window_base): New struct.
3946         (struct tui_source_window): Derive from tui_source_window_base.
3947         (struct tui_disasm_window): New struct.
3948         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3949         from tui_source_window::clear_detail.
3950         (tui_source_window_base): Rename from tui_source_window.
3951         (~tui_source_window_base): Rename from ~tui_source_window.
3952         (tui_alloc_win_info): Create a tui_disasm_window.
3953
3954 2019-06-25  Tom Tromey  <tom@tromey.com>
3955
3956         * tui/tui-data.h (struct tui_source_window)
3957         (struct tui_data_window): Declare destructors.
3958         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3959         destructors.
3960         (tui_win_info): Simplify.
3961
3962 2019-06-25  Tom Tromey  <tom@tromey.com>
3963
3964         * tui/tui-winsource.c (tui_display_main)
3965         (tui_update_source_windows_with_addr)
3966         (tui_update_all_breakpoint_info): Update.
3967         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3968         (new_height_ok, parse_scrolling_args): Update.
3969         * tui/tui-stack.c (tui_show_frame_info): Update.
3970         * tui/tui-data.h (struct tui_list): Remove.
3971         (tui_source_windows): Return a reference to a std::vector.
3972         * tui/tui-data.c (source_windows): Now a std::vector.
3973         (tui_source_windows): Change return type.
3974         (tui_clear_source_windows): Rewrite.
3975         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3976         (tui_free_all_source_wins_content): Rewrite.
3977
3978 2019-06-25  Tom Tromey  <tom@tromey.com>
3979
3980         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3981         (struct tui_data_window, struct tui_cmd_window): Declare
3982         clear_detail method.
3983         * tui/tui-data.c (tui_source_window::clear_detail)
3984         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3985         methods.
3986         (tui_clear_win_detail): Simplify.
3987
3988 2019-06-25  Tom Tromey  <tom@tromey.com>
3989
3990         * tui/tui-layout.c (make_source_window, make_disasm_window)
3991         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3992         Return the new window.
3993         (show_source_disasm_command, show_data)
3994         (show_source_or_disasm_and_command): Update.
3995
3996 2019-06-25  Tom Tromey  <tom@tromey.com>
3997
3998         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3999         parameter.  Return the new window.
4000         (show_source_disasm_command): Update and remove NULL check.
4001         (show_source_or_disasm_and_command): Update.
4002
4003 2019-06-25  Tom Tromey  <tom@tromey.com>
4004
4005         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4006
4007 2019-06-25  Tom Tromey  <tom@tromey.com>
4008
4009         * tui/tui-data.h (struct tui_win_info): Make constructor
4010         protected.  Make destructor virtual.  Add initializers.
4011         (tui_source_window, tui_data_window, tui_cmd_window): New
4012         classes.
4013         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4014         constructor.  Add "type" parameter.
4015         (tui_source_window, tui_data_window, tui_cmd_window): New
4016         constructors.
4017         (tui_alloc_win_info): Instantiate the appropriate subclass.
4018
4019 2019-06-25  Tom Tromey  <tom@tromey.com>
4020
4021         * tui/tui-win.c (tui_resize_all): Use delete.
4022         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4023         destructor.
4024         (tui_free_window): Don't declare.
4025         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4026         Update.
4027
4028 2019-06-25  Tom Tromey  <tom@tromey.com>
4029
4030         * tui/tui-data.h (struct tui_win_info): Add constructor.
4031         * tui/tui-data.c (tui_alloc_win_info): Use new.
4032         (tui_free_window): Use delete.
4033
4034 2019-06-22  Tom Tromey  <tom@tromey.com>
4035
4036         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4037         declare.
4038         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4039
4040 2019-06-22  Tom Tromey  <tom@tromey.com>
4041
4042         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4043         declare.
4044         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4045
4046 2019-06-22  Tom de Vries  <tdevries@suse.de>
4047
4048         * dwarf2read.c (create_addrmap_from_aranges)
4049         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4050         instead of '%zu'.
4051
4052 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4053
4054         * dwarf2read.h (dwarf2_section_info_def): Remove.
4055         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4056         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4057         std::vector<dwarf2_section_info>.
4058         (struct dwo_file) <~dwo_file>: Remove.
4059         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4060         types field.
4061         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4062         (dwarf2_read_debug_names): Likewise.
4063         (create_debug_types_hash_table): Change parameter type to
4064         array_view, adjust code accordingly.
4065         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4066         (partial_die_info::fixup): Likewise.
4067         (determine_prefix): Likewise.
4068         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4069
4070 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4071
4072         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4073         gdb_bfd_ref_ptr.
4074         <~dwo_file>: Remove call to gdb_bfd_unref.
4075         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4076         gdb_bfd_ref_ptr::get.
4077
4078 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4079
4080         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4081         type to htab_up.
4082         * dwarf2read.c (struct dwo_file): Initialize fields.
4083         <~dwo_file>: New.
4084         (free_dwo_file): Remove, move content to ~dwo_file.
4085         (struct dwo_file_deleter): Remove.
4086         (dwo_file_up>: Remove custom deleter.
4087         (free_dwo_files): Remove.
4088         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4089         dwo_files.
4090         (process_skeletonless_type_units): Call unique_ptr::get.
4091         (allocate_dwo_file_hash_table): Add deleter to created hash
4092         table.  Change return type to htab_up.
4093         (lookup_dwo_file_slot): Don't memset dwo_file, call
4094         unique_ptr::get.
4095         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4096         (create_dwo_unit_in_dwp_v2): Likewise.
4097         (open_and_init_dwo_file): Likewise.
4098         (free_dwo_file_from_slot): Remove.
4099
4100 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4101
4102         * dwarf2read.h (struct dwarf2_section_info) <readin,
4103         is_virtual>: Change type to bool.
4104         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4105         true instead of 1.
4106
4107 2019-06-19  Tom Tromey  <tom@tromey.com>
4108
4109         * tui/tui-data.h (tui_init_content_element): Don't declare.
4110
4111 2019-06-19  Tom Tromey  <tom@tromey.com>
4112
4113         * tui/tui-data.h (tui_init_win_info): Don't declare.
4114
4115 2019-06-19  Tom de Vries  <tdevries@suse.de>
4116
4117         * dwarf2read.h (abstract_to_concrete): Change type to
4118         std::unordered_map<sect_offset, std::vector<sect_offset>,
4119         gdb::hash_enum<sect_offset>>.
4120
4121 2019-06-19  Tom Tromey  <tromey@adacore.com>
4122
4123         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4124         EVAL_AVOID_SIDE_EFFECTS specially.
4125
4126 2019-06-19  Tom Tromey  <tromey@adacore.com>
4127
4128         * source-cache.c (highlighter): New global.
4129         (source_cache::get_source_lines): Create a highlighter on demand.
4130
4131 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4132
4133         * defs.h (deprecated_interactive_hook): Delete declaration.
4134         * interps.c (clear_interpreter_hooks): Remove use of
4135         deprecated_interactive_hook.
4136         * top.c (deprecated_interactive_hook): Delete definition.
4137         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4138
4139 2019-06-18  Tom de Vries  <tdevries@suse.de>
4140
4141         PR gdb/24515
4142         * dwarf2read.h (abstract_to_concrete): Change type from
4143         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4144         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4145         * dwarf2read.c (read_variable): Update.
4146         (dwarf2_fetch_die_loc_sect_off): Update.
4147
4148 2019-06-17  Tom de Vries  <tdevries@suse.de>
4149
4150         PR gdb/24617
4151         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4152         accessing parent[parent_len - 1].
4153
4154 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4155
4156         PR gdb/24364
4157         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4158         call dtrace_process_dof with NULL dof.
4159
4160 2019-06-16  Tom de Vries  <tdevries@suse.de>
4161
4162         PR gdb/24445
4163         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4164
4165 2019-06-16  Tom Tromey  <tom@tromey.com>
4166
4167         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4168         (make_all_visible): Use address of member.
4169
4170 2019-06-16  Tom Tromey  <tom@tromey.com>
4171
4172         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4173         (tui_free_window, free_content, free_content_elements): Remove
4174         unnecessary cast.
4175         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4176         cast.
4177         * tui/tui-regs.c (tui_show_register_group)
4178         (tui_display_registers_from, tui_display_reg_element_at_line):
4179         Remove unnecessary cast.
4180
4181 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4182
4183         * linux-nat.c (normal_mask): Delete.
4184         (_initialize_linux_nat): Don't initialise normal_mask.
4185
4186 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4187
4188         PR gdb/24445
4189         * dwarf-index-write.h (write_psymtabs_to_index): Add
4190         dwz_basename parameter.
4191         * dwarf-index-write.c (write_gdbindex): Move file writing to
4192         write_gdbindex_1.  Change return type void.
4193         (assert_file_size): Move up, remove filename parameter.
4194         (write_gdbindex_1): New function.
4195         (write_debug_names): Change return type to void, call
4196         assert_file_size.
4197         (struct index_wip_file): New struct.
4198         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4199         file logic to index_wip_file.  Write index for dwz file if
4200         needed.
4201         (save_gdb_index_command): Pass basename of dwz file, if present.
4202         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4203         build-id of dwz file, if present.
4204         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4205         (dwarf2_get_dwz_file): Likewise.
4206         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4207         (dwarf2_get_dwz_file): Likewise.
4208
4209 2019-06-16  Tom Tromey  <tom@tromey.com>
4210
4211         * coffread.c (process_coff_symbol): Use xstrdup.
4212         * value.c (create_internalvar): Use xstrdup.
4213
4214 2019-06-16  Tom Tromey  <tom@tromey.com>
4215
4216         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4217         * breakpoint.c (stopin_command, stopat_command)
4218         (until_break_command, decode_location_default): Remove unnecessary
4219         cast.
4220         * utils.c (subset_compare): Remove unnecessary cast.
4221         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4222         cast.
4223         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4224         cast.
4225         * infcmd.c (path_command): Remove unnecessary cast.
4226         * coffread.c (decode_type): Remove unnecessary cast.
4227         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4228         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4229         * tui/tui-stack.c (tui_show_locator_content)
4230         (tui_show_frame_info): Remove unnecessary cast.
4231         * tui/tui-win.c (tui_scroll_forward_command)
4232         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4233         (parse_scrolling_args): Remove unnecessary cast.
4234         * tui/tui-data.c (init_win_info, tui_del_window)
4235         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4236         (free_content_elements): Remove unnecessary cast.
4237         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4238         unnecessary cast.
4239         * tui/tui-source.c (tui_set_source_content)
4240         (tui_vertical_source_scroll): Remove unnecessary cast.
4241         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4242         cast.
4243         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4244         * tui/tui-regs.c (tui_display_registers_from)
4245         (tui_display_register): Remove unnecessary cast.
4246         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4247         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4248         (make_visible): Remove unnecessary cast.
4249         * tui/tui-winsource.c (tui_erase_source_content)
4250         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4251         unnecessary cast.
4252         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4253         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4254         * stabsread.c (read_type, read_array_type, read_range_type):
4255         Remove unnecessary cast.
4256         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4257         (parse_symbol, parse_type, upgrade_type, parse_external)
4258         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4259         unnecessary cast.
4260         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4261
4262 2019-06-16  Tom Tromey  <tom@tromey.com>
4263
4264         * tui/tui-data.c (tui_alloc_generic_win_info)
4265         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4266         checks.
4267
4268 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4269             Andrew Burgess  <andrew.burgess@embecosm.com>
4270
4271         * f-typeprint.c (f_print_type): Don't return early for not
4272         associated or not allocated types.
4273         (f_type_print_varspec_suffix): Add print_rank parameter and print
4274         ranks of array types in case they dangling.
4275         (f_type_print_base): Add print_rank parameter.
4276
4277 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4278
4279         * NEWS: Mention new MI commands.
4280         * break-catch-throw.c (enum exception_event_kind): Move to
4281         breakpoint.h.
4282         (print_mention_exception_catchpoint): Output text as a single
4283         message.
4284         (catch_exception_command_1): Rename to...
4285         (catch_exception_event): ...this, make non-static, update header
4286         command, and change some parameter types.
4287         (catch_catch_command): Update for changes to
4288         catch_exception_command_1.
4289         (catch_throw_command): Likewise.
4290         (catch_rethrow_command): Likewise.
4291         * breakpoint.c (enum exception_event_kind): Delete.
4292         * breakpoint.h (enum exception_event_kind): Moved here from
4293         break-catch-throw.c.
4294         (catch_exception_event): Declare.
4295         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4296         (mi_cmd_catch_throw): New function.
4297         (mi_cmd_catch_rethrow): New function.
4298         (mi_cmd_catch_catch): New function.
4299         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4300         'catch-catch' entries.
4301         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4302         (mi_cmd_catch_rethrow): Declare.
4303         (mi_cmd_catch_catch): Declare.
4304
4305 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4306
4307         * annotate.c (annotate_source_line): Change return type to void,
4308         update implementation to match.
4309         * annotate.h (annotate_source_line): Change return type to void,
4310         update header comment.
4311         * stack.c (print_frame_info): Don't change what frame information
4312         is printed based on whether annotations are on or not.
4313
4314 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4315
4316         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4317         (annotate_source): Make static.
4318         (annotate_source_line): Moved from source.c and renamed from
4319         identify_source_line.  Update the return type.
4320         * annotate.h (annotate_source): Delete declaration.
4321         (annotate_source_line): Declaration moved from source.h, and
4322         renamed from identify_source_line.  Return type updated.
4323         * source.c (identify_source_line): Moved to annotate.c and renamed
4324         to annotate_source_line.
4325         (info_line_command): Remove check of annotation_level.
4326         * source.h (identify_source_line): Move declaration to annotate.h
4327         and rename to annotate_source_line.
4328         * stack.c: Add 'annotate.h' include.
4329         (print_frame_info): Remove check of annotation_level before
4330         calling annotate_source_line.
4331
4332 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4333
4334         * source-cache.c (source_cache::get_plain_source_lines): Use
4335         open_source_file_with_line_charpos instead of just
4336         open_source_file, remove call to find_source_lines.
4337         (source_cache::get_source_lines): Likewise.
4338         * source.c (find_source_lines): Make static.
4339         (get_filename_and_charpos): Renamed into...
4340         (open_source_file_with_line_charpos): ..this along with changes to
4341         return a scoped_fd, and some other minor clean ups.
4342         (identify_source_line): Use open_source_file_with_line_charpos.
4343         (search_command_helper): Use open_source_file_with_line_charpos
4344         instead of just open_source_file, remove call to
4345         find_source_lines.
4346         * source.h (open_source_file_with_line_charpos): Declare new
4347         function.
4348         (find_source_lines): Delete declaration.
4349
4350 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4351
4352         * source.c (get_filename_and_charpos): Remove fullname
4353         parameter.
4354         (identify_source_line): Update call to get_filename_and_charpos.
4355
4356 2019-06-14  Tom Tromey  <tromey@adacore.com>
4357
4358         PR gdb/24502:
4359         * ui-style.h (skip_ansi_escape): Update comment.
4360         * ui-file.h (class no_terminal_escape_file): New class.
4361         * ui-file.c (no_terminal_escape_file::write)
4362         (no_terminal_escape_file::puts): New methods.
4363         * cli/cli-logging.c (handle_redirections): Use
4364         no_terminal_escape_file.
4365
4366 2019-06-14  Tom Tromey  <tromey@adacore.com>
4367
4368         * NEWS: Move convenience variable news above Python news.
4369
4370 2019-06-14  Tom Tromey  <tom@tromey.com>
4371
4372         * gnulib: Move directory to top-level.
4373         * configure.ac: Don't configure gnulib.
4374         * configure: Rebuild.
4375         * common/common-defs.h: Use new path to gnulib.
4376         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4377         (GNULIB_H): Remove.
4378         (INCGNU): Look in new gnulib location.
4379         (HFILES_NO_SRCDIR): Remove gnulib files.
4380         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4381         (generated_files): Remove GNULIB_H.
4382         ($(LIBGNU), all-lib): Remove targets.
4383         (distclean): Don't mention GNULIB_BUILDDIR.
4384         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4385
4386 2019-06-14  Tom Tromey  <tromey@adacore.com>
4387
4388         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4389         Warn if symbol file does not provide any symbols.
4390
4391 2019-06-14  Tom Tromey  <tromey@adacore.com>
4392
4393         * source.c (find_and_open_source): Respect basenames_may_differ.
4394
4395 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4396
4397         * annotate.c (annotate_breakpoints_invalid): Make use of
4398         scoped_restore_terminal_state.
4399         (annotate_frames_invalid): Likewise.
4400
4401 2019-06-14  Tom Tromey  <tromey@adacore.com>
4402
4403         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4404         allow assignment to an internalvar.
4405
4406 2019-06-14  Tom Tromey  <tromey@adacore.com>
4407
4408         * ada-lex.l: Allow "_" in attribute names.
4409
4410 2019-06-14  Tom Tromey  <tromey@adacore.com>
4411
4412         PR gdb/24653:
4413         * regcache.c (registers_changed): Don't call alloca.
4414         * top.c (execute_command): Don't call alloca.
4415
4416 2019-06-13  Pedro Alves  <palves@redhat.com>
4417
4418         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4419         'expression'.  When parsing an expression, error out if there's
4420         junk after "unlimited".
4421         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4422         (do_set_command): Adjust calls to is_unlimited_literal.
4423
4424 2019-06-13  Pedro Alves  <palves@redhat.com>
4425
4426         * compile/compile.c (make_compile_options_def_group): Add braces
4427         around array_view initializer.
4428         * thread.c (make_thread_apply_all_options_def_group)
4429         (make_thread_apply_all_options_def_group): Likewise.
4430
4431 2019-06-13  Pedro Alves  <palves@redhat.com>
4432
4433         * NEWS (New commands): Mention "maint test-options
4434         require-delimiter", "maint test-options unknown-is-error", "maint
4435         test-options unknown-is-operand" and "maint show
4436         test-options-completion-result".
4437         (New command options, command completion): New section.
4438         (Completion improvements): New section.
4439         Mention that you can abbreviate "unlimited".
4440
4441 2019-06-13  Pedro Alves  <palves@redhat.com>
4442
4443         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4444         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4445         * unittests/cli-utils-selftests.c (test_parse_flags)
4446         (test_parse_flags_qcs): Delete.
4447         (test_cli_utils): Don't call deleted functions.
4448
4449 2019-06-13  Pedro Alves  <palves@redhat.com>
4450
4451         * thread.c: Include "cli/cli-option.h".
4452         (tp_array_compar_ascending): Global.
4453         (tp_array_compar): Delete function.
4454         (tp_array_compar_ascending, tp_array_compar_descending): New
4455         functions.
4456         (ascending_option_def, qcs_flag_option_def)
4457         (thr_qcs_flags_option_defs)
4458         (make_thread_apply_all_options_def_group)
4459         (make_thread_apply_options_def_group): New.
4460         (thread_apply_all_command): Use gdb::option::process_options.
4461         (thread_apply_command_completer)
4462         (thread_apply_all_command_completer): New.
4463         (thread_apply_command): Use gdb::option::process_options.
4464         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4465         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4466         to generate help text of "thread apply".  Adjust "taas"'s help.
4467         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4468         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4469
4470 2019-06-13  Pedro Alves  <palves@redhat.com>
4471
4472         * thread.c (thread_apply_command): Check for invalid TID with
4473         isdigit instead of !isalpha.
4474
4475 2019-06-13  Pedro Alves  <palves@redhat.com>
4476
4477         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4478         (validate_flags_qcs): New.
4479         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4480         (validate_flags_qcs): Declare.
4481         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4482         (make_frame_apply_options_def_group): New.
4483         (frame_apply_command_count): Process options with
4484         gdb::option::process_options.
4485         (frame_apply_completer): New.
4486         (frame_apply_level_completer, frame_apply_all_completer)
4487         (frame_apply_completer): New.
4488         (_initialize_stack): Update help of "frame apply", "frame apply
4489         level", "frame apply all" and "faas" to mention supported options
4490         and install command completers.
4491         * stack.h (frame_apply_all_completer): Declare.
4492         * thread.c: Include "stack.h".
4493         (tfaas_command): Add "--".
4494         (_initialize_thread): Update help "tfaas" to mention supported
4495         options and install command completer.
4496
4497 2019-06-13  Pedro Alves  <palves@redhat.com>
4498
4499         * completer.c (complete_nested_command_line): New.
4500         (gdb_completion_word_break_characters_throw): Add assertion.
4501         * completer.h (complete_nested_command_line): Declare.
4502
4503 2019-06-13  Pedro Alves  <palves@redhat.com>
4504
4505         * stack.c (parse_backtrace_qualifiers): New.
4506         (backtrace_command): Use it.
4507         (backtrace_command_completer): Complete on qualifiers.
4508
4509 2019-06-13  Pedro Alves  <palves@redhat.com>
4510
4511         * frame.c: Include "cli/cli-option.h.
4512         (user_set_backtrace_options): New.
4513         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4514         Delete.
4515         (get_prev_frame): Adjust.
4516         (boolean_option_def, uinteger_option_def)
4517         (set_backtrace_option_defs): New.
4518         (_initialize_frame): Adjust and use
4519         gdb::option::add_setshow_cmds_for_options to install "set
4520         backtrace past-main" and "set backtrace past-entry".
4521         * frame.h: Include "cli/cli-option.h".
4522         (struct frame_print_options): Forward declare.
4523         (print_frame_arguments_all, print_frame_arguments_scalars)
4524         (print_frame_arguments_none): Declare.
4525         (print_entry_values): Delete declaration.
4526         (struct frame_print_options, user_frame_print_options): New.
4527         (struct set_backtrace_options): New.
4528         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4529         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4530         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4531         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4532         (list_args_or_locals): Add frame_print_options parameter.
4533         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4534         * python/py-framefilter.c (enumerate_args): Pass down
4535         USER_FRAME_PRINT_OPTIONS.
4536         * stack.c: Include "cli/cli-option.h".
4537         (print_frame_arguments_all, print_frame_arguments_scalars)
4538         (print_frame_arguments_none): Declare.
4539         (print_raw_frame_arguments, print_entry_values): Delete.
4540         (user_frame_print_options): New.
4541         (boolean_option_def, enum_option_def, frame_print_option_defs):
4542         New.
4543         (struct backtrace_cmd_options): New.
4544         (bt_flag_option_def): New.
4545         (backtrace_command_option_defs): New.
4546         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4547         (print_frame_arg, read_frame_arg, print_frame_args)
4548         (print_frame_info, print_frame): Add frame_print_options parameter
4549         and use it.
4550         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4551         (backtrace_command_1): Add frame_print_options and
4552         backtrace_cmd_options parameters and use them.
4553         (make_backtrace_options_def_group): New.
4554         (backtrace_command): Process command options with
4555         gdb::option::process_options.
4556         (backtrace_command_completer): New.
4557         (_initialize_stack): Extend "backtrace"'s help to mention
4558         supported options.  Install completer for "backtrace".
4559         Install some settings commands with add_setshow_cmds_for_options.
4560
4561 2019-06-13  Pedro Alves  <palves@redhat.com>
4562
4563         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4564         and that "set/show print raw frame-arguments" are now deprecated.
4565
4566         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4567         command.
4568         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4569         * stack.c (_initialize_stack): Install "set/show print
4570         raw-frame-arguments", and deprecate "set/show print raw
4571         frame-arguments".
4572         * valprint.c (_initialize_valprint): Deprecate "set/show print
4573         raw".
4574
4575 2019-06-13  Pedro Alves  <palves@redhat.com>
4576
4577         * compile/compile.c (struct compile_options): New.
4578         (compile_flag_option_def, compile_command_option_defs)
4579         (make_compile_options_def_group): New.
4580         (compile_file_command): Handle options with
4581         gdb::option::process_options.
4582         (compile_file_command_completer): New function.
4583         (compile_code_command): Handle options with
4584         gdb::option::process_options.
4585         (compile_code_command_completer): New function.
4586         (_initialize_compiler): Install completers for "compile code" and
4587         "compile file".  Mention available options in "compile code" and
4588         "compile code"'s help.
4589         * completer.c (advance_to_completion_word): New, factored out from
4590         ...
4591         (advance_to_expression_complete_word_point): ... this.
4592         (advance_to_filename_complete_word_point): New.
4593         * completer.h (advance_to_filename_complete_word_point): New
4594         declaration.
4595
4596 2019-06-13  Pedro Alves  <palves@redhat.com>
4597
4598         * compile/compile.c: Include "cli/cli-option.h".
4599         (compile_print_value): Scope data pointer is now a
4600         value_print_options pointer; adjust.
4601         (compile_print_command): Process options.  Scope data pointer is
4602         now a value_print_options pointer; adjust.
4603         (_initialize_compile): Update "compile print"'s help to include
4604         supported options.  Install a completer for "compile print".
4605         * cp-valprint.c (show_vtblprint, show_objectprint)
4606         (show_static_field_print): Delete.
4607         (_initialize_cp_valprint): Don't install "set print
4608         static-members", "set print vtbl", "set print object" here.
4609         * printcmd.c: Include "cli/cli-option.h" and
4610         "common/gdb_optional.h".
4611         (print_command_parse_format): Rework to fill in a
4612         value_print_options instead of a format_data.
4613         (print_value): Change parameter type from format_data pointer to
4614         value_print_options reference.  Adjust.
4615         (print_command_1): Process options.  Adjust to pass down a
4616         value_print_options.
4617         (print_command_completer): New.
4618         (_initialize_printcmd): Install print_command_completer as
4619         handle_brkchars completer for the "print" command.  Update
4620         "print"'s help to include supported options.
4621         * valprint.c: Include "cli/cli-option.h".
4622         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4623         here from cp-valprint.c.
4624         (boolean_option_def, uinteger_option_def)
4625         (value_print_option_defs, make_value_print_options_def_group):
4626         New.  Use gdb::option::add_setshow_cmds_for_options to install
4627         "set print elements", "set print null-stop", "set print repeats",
4628         "set print pretty", "set print union", "set print array", "set
4629         print address", "set print symbol", "set print array-indexes".
4630         * valprint.h: Include <string> and "cli/cli-option.h".
4631         (make_value_print_options_def_group): Declare.
4632         (print_value): Change parameter type from format_data pointer to
4633         value_print_options reference.
4634         (print_command_completer): Declare.
4635
4636 2019-06-13  Pedro Alves  <palves@redhat.com>
4637
4638         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4639         (COMMON_SFILES): Add maint-test-settings.c.
4640         * cli/cli-decode.c (boolean_enums): New global, factored out from
4641         ...
4642         (add_setshow_boolean_cmd): ... here.
4643         * cli/cli-decode.h (boolean_enums): Declare.
4644         * cli/cli-option.c: New file.
4645         * cli/cli-option.h: New file.
4646         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4647         factored out from ...
4648         (parse_cli_boolean_value(const char *)): ... this.
4649         (is_unlimited_literal): Change parameter type to pointer to
4650         pointer.  Adjust and advance ARG pointer.
4651         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4652         (parse_cli_var_enum): New, factored out from ...
4653         (do_set_command): ... this.  Adjust.
4654         * cli/cli-setshow.h (parse_cli_boolean_value)
4655         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4656         (parse_cli_var_enum): Declare.
4657         * cli/cli-utils.c: Include "cli/cli-option.h".
4658         (get_ulongest): New.
4659         * cli/cli-utils.h (get_ulongest): Declare.
4660         (check_for_argument): New overloads.
4661         * maint-test-options.c: New file.
4662
4663 2019-06-13  Pedro Alves  <palves@redhat.com>
4664
4665         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4666         parse a range if "-" is at the end of the string.
4667
4668 2019-06-13  Pedro Alves  <palves@redhat.com>
4669
4670         * cli/cli-setshow.c (parse_auto_binary_operation)
4671         (parse_cli_boolean_value): Don't allow "o".
4672
4673 2019-06-13  Pedro Alves  <palves@redhat.com>
4674
4675         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4676         * NEWS: Mention maint test-settings KIND.
4677         * maint-test-settings.c: New file.
4678
4679 2019-06-13  Pedro Alves  <palves@redhat.com>
4680
4681         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4682         completer.
4683         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4684         "set" completers.
4685
4686 2019-06-13  Pedro Alves  <palves@redhat.com>
4687
4688         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4689         after item.
4690
4691 2019-06-13  Pedro Alves  <palves@redhat.com>
4692
4693         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4694
4695 2019-06-13  Pedro Alves <palves@redhat.com>
4696
4697         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4698         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4699         call.
4700         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4701         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4702         calls.
4703         (check_for_argument): Skip spaces after argument.
4704
4705 2019-06-13  Pedro Alves  <palves@redhat.com>
4706
4707         * thread.c (thread_apply_command): Adjust TID parsing.
4708         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4709         detected before end of string.
4710         (tid_is_in_list): Error out if LIST is invalid.
4711
4712 2019-06-13  Pedro Alves  <palves@redhat.com>
4713
4714         * completer.c (complete_line_internal_1): Rewind completion word
4715         point.
4716         (completion_tracker::advance_custom_word_point_by): Change
4717         parameter type to int.
4718         * completer.h (completion_tracker::advance_custom_word_point_by):
4719         Likewise.
4720
4721 2019-06-13  Pedro Alves  <palves@redhat.com>
4722
4723         * completer.c (advance_to_completion_word): Handle delimiters.
4724
4725 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4726
4727         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4728
4729 2019-06-11  Tom Tromey  <tom@tromey.com>
4730
4731         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4732         (xmalloc_failed): Move to alloc.c.
4733         * alloc.c: New file.
4734         * Makefile.in (COMMON_SFILES): Add alloc.c.
4735
4736 2019-06-11  Tom Tromey  <tom@tromey.com>
4737
4738         * nat/linux-waitpid.c: Don't include server.h.
4739         (linux_debug): Remove.
4740         (my_waitpid): Update.
4741
4742 2019-06-11  Tom Tromey  <tromey@adacore.com>
4743
4744         * infcall.c (_initialize_infcall): Remove trailing newline from
4745         help.
4746         * user-regs.c (_initialize_user_regs): Remove trailing newline
4747         from help.
4748         * typeprint.c (_initialize_typeprint): Remove trailing newline
4749         from help.
4750         * reverse.c (_initialize_reverse): Remove trailing newlines from
4751         help.
4752         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4753         from help.
4754         * language.c (add_set_language_command): Remove trailing newline
4755         from help.
4756         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4757         help.
4758         * disasm.c (_initialize_disasm): Remove trailing newline from
4759         help.
4760         * top.c (init_main): Remove trailing newline from help.
4761         * interps.c (_initialize_interpreter): Remove trailing newline
4762         from help.
4763         * btrace.c (_initialize_btrace): Remove trailing newlines from
4764         help.
4765         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4766         from help.
4767         * python/python.c (_initialize_python): Remove trailing newline
4768         from help.
4769         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4770         help.
4771         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4772         from help.  Reformat some text.
4773         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4774         from help.
4775         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4776         newline from help.
4777
4778 2019-06-11  Tom Tromey  <tromey@adacore.com>
4779
4780         * darwin-nat.c (darwin_decode_exception_message)
4781         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4782
4783 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4784
4785         * valops.c (value_slice): Check for not allocated or not
4786         associated values.
4787
4788 2019-06-10  Tom de Vries  <tdevries@suse.de>
4789
4790         PR gdb/24618
4791         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4792         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4793         invalid.
4794
4795 2019-06-10  Tom de Vries  <tdevries@suse.de>
4796
4797         PR gdb/24611
4798         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4799         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4800
4801 2019-06-10  Tom de Vries  <tdevries@suse.de>
4802
4803         PR symtab/24545
4804         * symtab.c (struct demangled_name_entry): Add language field.
4805         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4806         static minimal symbol".  Set and use language field.
4807
4808 2019-06-10  Tom Tromey  <tromey@adacore.com>
4809
4810         * ada-lang.c (_initialize_ada_language): Update help text.
4811
4812 2019-06-10  Tom Tromey  <tromey@adacore.com>
4813
4814         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4815         with a newline.
4816         * guile/guile.c (handle_boot_error): Don't end warning with a
4817         newline.
4818         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4819         warning with a newline.
4820         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4821         newline.
4822         (s12z_frame_cache): Likewise.
4823         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4824         a newline.
4825         * solib-svr4.c (disable_probes_interface): Don't end warning with
4826         a newline.
4827         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4828         newline.
4829         * python/python.c (do_finish_initialization): Don't end warning
4830         with a newline.
4831
4832 2019-06-10  Tom Tromey  <tom@tromey.com>
4833
4834         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4835         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4836         gdbpy_enter.
4837
4838 2019-06-10  Tom Tromey  <tromey@adacore.com>
4839
4840         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4841         data.
4842         (elf_new_init): Don't call stabsread_new_init.
4843         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4844         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4845         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4846
4847 2019-06-10  Tom de Vries  <tdevries@suse.de>
4848
4849         PR symtab/16264
4850         PR symtab/24517
4851         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4852
4853 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4854
4855         * source.c (find_and_open_source): Also rewrite relative file
4856         names.
4857
4858 2019-04-26  Amos Bird  <amosbird@gmail.com>
4859
4860         * annotate.c (annotate_thread_exited): Add "thread-exited"
4861         annotation.
4862
4863 2019-06-06  Tom Tromey  <tromey@adacore.com>
4864
4865         * maint.h (class scoped_command_stats): Use
4866         DISABLE_COPY_AND_ASSIGN.
4867         <print_time>: New method.
4868         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4869         print_time.
4870         (scoped_command_stats::print_time): New method.
4871
4872 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4873
4874         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4875         instructions of lengths 6 or 8 bytes.
4876
4877 2019-06-04  Pedro Alves  <palves@redhat.com>
4878
4879         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4880
4881         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4882         * breakpoint.c (condition_completer): Likewise.
4883         * cli/cli-dump.c (scan_expression): Likewise.
4884         * common/filestuff.c (mkdir_recursive): Likewise.
4885         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4886         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4887         (gdb_abspath): Likewise.
4888         * compile/compile-cplus-types.c
4889         (compile_cplus_instance::decl_name): Likewise.
4890         * completer.c (complete_explicit_location):
4891         (signal_completer, reg_or_group_completer_1): Likewise.
4892         * cp-support.c (cp_remove_params_if_any): Likewise.
4893         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4894         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4895         * infcmd.c (strip_bg_char): Likewise.
4896         * linespec.c (copy_token_string): Likewise.
4897         * mi/mi-main.c (output_cores): Likewise.
4898         * psymtab.c (psymtab_search_name):
4899         * symfile.c (test_set_ext_lang_command): Likewise.
4900         * target.c (target_fileio_read_stralloc): Likewise.
4901         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4902         * value.c (complete_internalvar): Likewise.
4903
4904 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4905
4906         Add objfile property to gdb.Type.
4907         * NEWS: Mention Python API addition.
4908         * python/py-type.c (typy_get_objfile): New method.
4909
4910 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4911
4912         * NEWS: Mention the new set|show style [title|highlight].
4913         Mention changes to "show style", "help" and "apropos".
4914
4915 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4916
4917         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4918         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4919         instead of print_help_for_command.
4920         (print_doc_of_command): New function.
4921         (help_list): Add 'apropos -v word' suggestion.
4922         (print_help_for_command): Style the command name using title style.
4923         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4924         (_initialize_cli_cmds): Describe -v in apropos_command help.
4925
4926 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4927
4928         * cli/cli-style.h (cli_style_option): Add name in constructor,
4929         add m_name class member, add constructor with intensity,
4930         add name class function.
4931         (cli_style_option::add_setshow_commands): Remove name argument.
4932         (highlight_style, title_style): New styles.
4933         * cli/cli-style.c (do_show): New function that shows a style
4934         characteristic styling the style name with itself.
4935         (set_style_name): New function.
4936         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4937         Update all callers according to the changes in cli/cli-style.h.
4938         * utils.h (fputs_highlighted): New function.
4939         * utils.c (fputs_highlighted): Likewise.
4940
4941 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4942
4943         * NEWS: Mention new pipe command and new convenience variables.
4944
4945 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4946
4947         * cli/cli-cmds.c (pipe_command): New function.
4948         (_initialize_cli_cmds): Call add_com for pipe_command.
4949         Define | as an alias for pipe.
4950         (exit_status_set_internal_vars): New function.
4951         (shell_escape): Call exit_status_set_internal_vars.
4952         cli/cli-decode.c (find_command_name_length): Recognize | as
4953         a single character command.
4954
4955 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4956
4957         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4958         top.c (execute_command_to_ui_file): New function, mostly a copy
4959         of execute_command_to_string.
4960         (execute_command_to_string): Implement by calling
4961         execute_command_to_ui_file.
4962
4963 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4964
4965         * top.h (saved_command_line): Remove declaration.
4966         * top.c (previous_saved_command_line, previous_repeat_arguments):
4967         New variables.
4968         (saved_command_line): Make static, define together with other
4969         'repeat variables'.
4970         (dont_repeat): Clear repeat_arguments.
4971         (repeat_previous, get_saved_command_line, save_command_line):
4972         New functions.
4973         (gdb_init): Initialize saved_command_line
4974         and previous_saved_command_line.
4975         * main.c (captured_main_1): Remove saved_command_line initialization.
4976         * event-top.c (handle_line_of_input): Update to use
4977         the new 'repeat' related functions instead of direct access to
4978         saved_command_line.
4979         * command.h (repeat_previous, get_saved_command_line,
4980         save_command_line): New declarations.
4981         (dont_repeat): Add comment.
4982
4983 2019-05-30  Tom Tromey  <tromey@adacore.com>
4984
4985         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4986         Fix comment.
4987         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4988
4989 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4990
4991         PR cli/24587
4992         * completer.c (complete): Initialize variable word.
4993
4994 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4995
4996         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4997         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4998         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4999         'body' is NULL to the outter 'if', protecting the '!is_define'
5000         situation as well.
5001
5002 2019-05-29  Tom Tromey  <tromey@adacore.com>
5003
5004         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5005         (dwarf_unknown): New function.
5006         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5007         (dwarf_type_encoding_name): Use dwarf_unknown.
5008
5009 2019-05-29  Tom Tromey  <tromey@adacore.com>
5010
5011         PR c++/20020:
5012         * cp-valprint.c (cp_print_value_fields): Call
5013         cp_print_static_field inside "try".
5014
5015 2019-05-29  Tom Tromey  <tromey@adacore.com>
5016
5017         * inflow.c (struct terminal_info): Add default operator=.
5018         * configure: Rebuild.
5019         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5020         -Wdeprecated-copy-dtor, -Wredundant-move.
5021
5022 2019-05-29  Tom Tromey  <tromey@adacore.com>
5023
5024         * NEWS: Add entry.
5025         * infcmd.c (print_return_value_1): Handle finish_print
5026         option.
5027         (show_print_finish): New function.
5028         (_initialize_infcmd): Add "set/show print finish" commands.
5029         * valprint.c (user_print_options): Initialize new member.
5030         * valprint.h (struct value_print_options) <finish_print>: New
5031         member.
5032
5033 2019-05-28  Tom Tromey  <tromey@adacore.com>
5034
5035         * ada-lang.c (ada_remove_Xbn_suffix)
5036         (find_old_style_renaming_symbol)
5037         (parse_old_style_renaming): Remove.
5038         (ada_find_renaming_symbol): Don't call
5039         find_old_style_renaming_symbol.
5040         (ada_is_renaming_symbol): Rename from
5041         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5042         bool.  Now static.
5043         (ada_read_var_value): Update and simplify.
5044         * ada-exp.y (write_var_or_type): Remove old code.
5045
5046 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5047
5048         * event-top.c: Remove include comment.
5049         * inflow.c (class scoped_ignore_sigttou): Move from here...
5050         * inflow.h (class scoped_ignore_sigttou): ...to here.
5051         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5052         * top.c:  Remove include comment.
5053
5054 2019-05-27  Tom Tromey  <tom@tromey.com>
5055
5056         * NEWS: Fix typo.
5057
5058 2019-05-22  Tom Tromey  <tromey@adacore.com>
5059
5060         * target.c (target_follow_exec): Constify parameter.
5061         * target-delegates.c: Rebuild.
5062         * remote.c (remote_target::follow_exec): Constify parameter.
5063         * infrun.c (follow_exec): Constify parameter.
5064         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5065         (target_follow_exec): Likewise.
5066
5067 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5068
5069         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5070         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5071
5072 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5073
5074         * NEWS: Add debugredirect and testsuite sections.
5075
5076 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5077
5078         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5079         target descriptions using exclusively floating point register name
5080         aliases.
5081
5082 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5083
5084         PR gdb/18644:
5085         * f-lang.c (build_fortran_types): Handle the case where
5086         gdbarch_floatformat_for_type returns a nullptr.
5087
5088 2019-05-21  Tom de Vries  <tdevries@suse.de>
5089
5090         PR cli/24587
5091         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5092
5093 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5094
5095         PR gdb/18644:
5096         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5097         16-byte floats.
5098         * i386-tdep.c (i386_floatformat_for_type): Use
5099         floatformats_ia64_quad for the 16-byte floating point component
5100         within a fortran 32-byte complex number.
5101
5102 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5103
5104         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5105         delete default constructor.
5106         (find_partial_die): Update to return const struct.
5107         (partial_die_parent_scope): Move variable declaration into scope
5108         of its use and change its type to auto.
5109         (guess_partial_die_structure_name): Likewise.
5110         (partial_die_info::fixup): Likewise.
5111
5112 2019-05-17  Tom Tromey  <tromey@adacore.com>
5113
5114         * source.c (find_and_open_source): Remove cast.
5115
5116 2019-05-17  Tom Tromey  <tromey@adacore.com>
5117
5118         * annotate.c (annotate_source): Make "filename" const.
5119         * annotate.h (annotate_source): Use const.
5120
5121 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5122
5123         * disasm.c (set_disassembler_options): Send errors to stderr.
5124
5125 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5126
5127         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5128         (cli_interp_base::set_logging): Check debug_redirect.
5129         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5130         * cli/cli-logging.c (debug_redirect): Add static variable.
5131         (pop_output_files): Add default param.
5132         (handle_redirections): Print debug setting.
5133         (show_logging_command): Likewise.
5134         (_initialize_cli_logging): Add debugredirect command.
5135         * interps.c (current_interp_set_logging): Add debug_redirect
5136         parameter.
5137         * interps.h (set_logging): Add debug_redirect parameter.
5138         (current_interp_set_logging): Likewise.
5139         * mi/mi-common.h: Likewise.
5140         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5141
5142 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5143             Tom Tromey  <tromey@adacore.com>
5144
5145         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5146         directly.
5147         * cli/cli-interp.h (make_logging_output): Remove declaration.
5148         * cli/cli-logging.c (make_logging_output): Remove function.
5149         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5150         directly.
5151         * ui-file.c (tee_file::tee_file): Remove bools.
5152         (tee_file::~tee_file): Remove deletes.
5153         * ui-file.h (tee_file): Remove bools.
5154
5155 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5156
5157         * mi/mi-cmds.h (mi_cmd_complete): New function.
5158         * mi/mi-main.c (mi_cmd_complete): Likewise.
5159         * mi/mi-cmds.c: Define new MI command -complete.
5160         * NEWS: Mention new -complete command.
5161
5162 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5163
5164         * completer.h (complete): New function.
5165         * completer.c (complete): Likewise.
5166         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5167         function defined in completer.h.
5168
5169 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5170
5171         * MAINTAINERS (Write After Approval): Add myself.
5172
5173 2019-05-17  Tom de Vries  <tdevries@suse.de>
5174
5175         PR gdb/24094
5176         * dwarf2read.c (struct cu_partial_die_info): New struct.
5177         (find_partial_die): Return cu_partial_die_info.
5178         (partial_die_parent_scope, guess_partial_die_structure_name)
5179         (partial_die_info::fixup): Handle new return type of find_partial_die.
5180
5181 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5182
5183         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5184         "std::string", simplifying the algorithm.
5185
5186 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5187
5188         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5189         (stap_static_probe_ops::get_probes): Likewise.
5190
5191 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5192
5193         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5194         '-')" and "else if".
5195         (stap_parse_single_operand): Join checks for
5196         "gdbarch_stap_parse_special_token_p" and
5197         "gdbarch_stap_parse_special_token" in the same "if" statement.
5198         Invert check when verifying for operation on register
5199         displacement.
5200
5201 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5202
5203         * stap-probe.c (stap_get_opcode): Update comment.
5204         (stap_get_expected_argument_type): Likewise.
5205         (handle_stap_probe): Likewise.
5206
5207 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5208
5209         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5210         return type to 'bool'.  Adjust comment.  Use 'bool' when
5211         appropriate.
5212         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5213         * stap-probe.c (stap_parse_argument_1): Likewise.
5214         (stap_is_operator): Likewise.
5215         (stap_is_generic_prefix): Likewise.
5216         (stap_is_register_prefix): Likewise.
5217         (stap_is_register_indirection_prefix): Likewise.
5218         (stap_is_integer_prefix): Likewise.
5219         (stap_generic_check_suffix): Likewise.
5220         (stap_check_integer_suffix): Likewise.
5221         (stap_check_register_suffix): Likewise.
5222         (stap_check_register_indirection_suffix): Likewise.
5223         (stap_parse_register_operand): Likewise.
5224         (stap_parse_single_operand): Likewise.
5225         (stap_parse_argument_1): Likewise.
5226         (stap_probe::get_argument_count): Likewise.
5227         (stap_is_operator): Likewise.
5228
5229 2019-05-16  Tom Tromey  <tromey@adacore.com>
5230
5231         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5232         keyword to foreach.
5233
5234 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5235
5236         * linux-thread-db.c (try_thread_db_load_1): Change return type
5237         to bool.
5238         (try_thread_db_load): Likewise.
5239         (try_thread_db_load_from_pdir_1): Likewise.
5240         (try_thread_db_load_from_pdir): Likewise.
5241         (try_thread_db_load_from_sdir): Likewise.
5242         (try_thread_db_load_from_dir): Likewise.
5243         (thread_db_load_search): Likewise.
5244         (has_libpthread): Likewise.
5245         (thread_db_load): Likewise.
5246
5247 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5248
5249         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5250         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5251         NULL, and complain/return if that's the case.
5252
5253 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5254
5255         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5256         (advance, posn, abstract_read_memory): New functions.
5257         [struct mem_read_abstraction]: New struct.
5258         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5259
5260 2019-05-14  Tom Tromey  <tromey@adacore.com>
5261
5262         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5263         value is not lval_memory.
5264
5265 2019-05-14  Tom Tromey  <tromey@adacore.com>
5266
5267         * solib.c (info_sharedlibrary_command): Style the file name.
5268
5269 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5270
5271         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5272         (aarch64_vnv_type): Likewise.
5273         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5274         * common/tdesc.c: Likewise.
5275         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5276         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5277         * features/aarch64-fpu.xml: Add ieee half view.
5278         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5279         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5280         * gdbtypes.h (struct builtin_type): Likewise.
5281         (struct objfile_type): Likewise.
5282
5283 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5284
5285         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5286         typo.
5287         * location.h (string_to_event_location): Likewise.
5288
5289 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5290
5291         GDB 8.3 released.
5292
5293 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5294
5295         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5296         New variable declaration.
5297         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5298         New variable.
5299         (print_one_breakpoint): Use ui_out::test_flags and new global
5300         variable to compute use_fixed_output.
5301         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5302         Remove.
5303         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5304         (mi_multi_location_breakpoint_output_fixed): Remove.
5305         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5306         new variable.
5307         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5308         fix_multi_location_breakpoint_output flag if version >= 3.
5309         * ui-out.h (enum ui_out_flag)
5310         <fix_multi_location_breakpoint_output>: New enumerator.
5311
5312 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5313
5314         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5315
5316 2019-05-10  Tom Tromey  <tromey@adacore.com>
5317
5318         * ada-lang.c (catch_ada_completer): New function.
5319         (_initialize_ada_language): Use it.
5320
5321 2019-05-10  Tom Tromey  <tromey@adacore.com>
5322
5323         * thread.c (print_thread_info): Make "requested_threads" const.
5324         * gdbthread.h (print_thread_info): Make "requested_threads"
5325         const.
5326         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5327         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5328
5329 2019-05-08  Tom Tromey  <tom@tromey.com>
5330
5331         * gdbtypes.c (objfile_type_data): Change type.
5332         (objfile_type, _initialize_gdbtypes): Update.
5333
5334 2019-05-08  Tom Tromey  <tom@tromey.com>
5335
5336         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5337         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5338         (_initialize_dwarf2_frame): Update.
5339
5340 2019-05-08  Tom Tromey  <tom@tromey.com>
5341
5342         * objc-lang.c (objc_objfile_data): Change type.
5343         (find_methods): Update.
5344         (_initialize_objc_lang): Remove.
5345
5346 2019-05-08  Tom Tromey  <tom@tromey.com>
5347
5348         * stabsread.c (rs6000_builtin_type_data): Change type.
5349         (rs6000_builtin_type, _initialize_stabsread): Update.
5350
5351 2019-05-08  Tom Tromey  <tom@tromey.com>
5352
5353         * mips-tdep.c (mips_pdr_data): Remove.
5354         (_initialize_mips_tdep): Update.
5355
5356 2019-05-08  Tom Tromey  <tom@tromey.com>
5357
5358         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5359         (hppa_init_objfile_priv_data, read_unwind_info)
5360         (find_unwind_entry, _initialize_hppa_tdep): Update.
5361
5362 2019-05-08  Tom Tromey  <tom@tromey.com>
5363
5364         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5365         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5366         on obstack.
5367         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5368
5369 2019-05-08  Tom Tromey  <tom@tromey.com>
5370
5371         * mdebugread.c (basic_type_data): Change type.
5372         (basic_type, _initialize_mdebugread): Update.
5373
5374 2019-05-08  Tom Tromey  <tom@tromey.com>
5375
5376         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5377
5378 2019-05-08  Tom Tromey  <tom@tromey.com>
5379
5380         * nto-tdep.c (nto_inferior_data_reg): Change type.
5381         (nto_inferior_data): Update.
5382         (nto_inferior_data_cleanup, nto_new_inferior_data)
5383         (_initialize_nto_tdep): Remove.
5384         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5385
5386 2019-05-08  Tom Tromey  <tom@tromey.com>
5387
5388         * ada-lang.c (struct ada_inferior_data): Add initializers.
5389         (ada_inferior_data): Change type.
5390         (ada_inferior_data_cleanup): Remove.
5391         (get_ada_inferior_data, ada_inferior_exit)
5392         (struct ada_pspace_data): Add initializers, destructor.
5393         (ada_pspace_data_handle): Change type.
5394         (get_ada_pspace_data): Update.
5395         (ada_pspace_data_cleanup): Remove.
5396
5397 2019-05-08  Tom Tromey  <tom@tromey.com>
5398
5399         * coffread.c (struct coff_symfile_info): Add initializers.
5400         (coff_objfile_data_key): Move lower.  Change type.
5401         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5402         Update.
5403         (coff_free_info): Remove.
5404
5405 2019-05-08  Tom Tromey  <tom@tromey.com>
5406
5407         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5408         (fbsd_pspace_data_handle): Move lower.  Change type.
5409         (get_fbsd_pspace_data): Update.
5410         (fbsd_pspace_data_cleanup): Remove.
5411         (_initialize_fbsd_tdep): Update.
5412
5413 2019-05-08  Tom Tromey  <tom@tromey.com>
5414
5415         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5416         (get_ada_tasks_pspace_data): Update.
5417         (ada_tasks_pspace_data_cleanup): Remove.
5418         (_initialize_tasks): Update.
5419         (ada_tasks_inferior_data_handle): Change type.
5420         (get_ada_tasks_inferior_data): Update.
5421         (ada_tasks_inferior_data_cleanup): Remove.
5422         (struct ada_tasks_pspace_data): Add initializers.
5423
5424 2019-05-08  Tom Tromey  <tom@tromey.com>
5425
5426         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5427         * symfile-debug.c (debug_sym_get_probes): Change type.
5428         * stap-probe.c (handle_stap_probe):
5429         (stap_static_probe_ops::get_probes): Change type.
5430         * probe.h (class static_probe_ops) <get_probes>: Change type.
5431         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5432         (parse_probes_in_pspace): Update.
5433         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5434         Update.
5435         (any_static_probe_ops::get_probes): Change type.
5436         * elfread.c (elfread_data): New typedef.
5437         (probe_key): Change type.
5438         (elf_get_probes): Likewise.  Update.
5439         (probe_key_free): Remove.
5440         (_initialize_elfread): Update.
5441         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5442         Change type.
5443         (dtrace_process_dof_probe, dtrace_process_dof)
5444         (dtrace_static_probe_ops::get_probe): Change type.
5445
5446 2019-05-08  Tom Tromey  <tom@tromey.com>
5447
5448         * xcoffread.c (struct xcoff_symfile_info): Rename from
5449         coff_symfile_info.  Add initializers.
5450         (xcoff_objfile_data_key): Move lower.  Change type.
5451         (XCOFF_DATA): Rewrite.
5452         (xcoff_free_info): Remove.
5453         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5454         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5455         (xcoff_initial_scan): Update.
5456
5457 2019-05-08  Tom Tromey  <tom@tromey.com>
5458
5459         * solib-svr4.c (struct svr4_info): Add initializers and
5460         destructor.
5461         <probes_table>: Now an htab_up.
5462         (solib_svr4_pspace_data): Change type.
5463         (free_probes_table): Simplify.
5464         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5465         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5466         (probes_table_remove_objfile_probes, register_solib_event_probe)
5467         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5468         (_initialize_svr4_solib): Update.
5469
5470 2019-05-08  Tom Tromey  <tom@tromey.com>
5471
5472         * remote.c (remote_pspace_data): Change type.
5473         (remote_pspace_data_cleanup): Remove.
5474         (get_remote_exec_file, set_pspace_remote_exec_file)
5475         (_initialize_remote): Update.
5476
5477 2019-05-08  Tom Tromey  <tom@tromey.com>
5478
5479         * breakpoint.c (breakpoint_objfile_key): Change type.
5480         (get_breakpoint_objfile_data): Update.
5481         (free_breakpoint_objfile_data): Remove.
5482         (_initialize_breakpoint): Update.
5483
5484 2019-05-08  Tom Tromey  <tom@tromey.com>
5485
5486         * linux-tdep.c (struct linux_info): Add initializers.
5487         (linux_inferior_data): Move.  Change type.
5488         (invalidate_linux_cache_inf): Update.
5489         (linux_inferior_data_cleanup): Remove.
5490         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5491
5492 2019-05-08  Tom Tromey  <tom@tromey.com>
5493
5494         * auxv.c (auxv_inferior_data): Move.  Change type.
5495         (auxv_inferior_data_cleanup): Remove.
5496         (invalidate_auxv_cache_inf): Rewrite.
5497         (get_auxv_inferior_data, _initialize_auxv): Update.
5498
5499 2019-05-08  Tom Tromey  <tom@tromey.com>
5500
5501         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5502         (symfile_debug_objfile_data_key): Change type.
5503         (symfile_debug_installed, debug_qf_has_symbols)
5504         (debug_qf_find_last_source_symtab)
5505         (debug_qf_forget_cached_source_info)
5506         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5507         (debug_qf_print_stats, debug_qf_dump)
5508         (debug_qf_expand_symtabs_for_function)
5509         (debug_qf_expand_all_symtabs)
5510         (debug_qf_expand_symtabs_with_fullname)
5511         (debug_qf_map_matching_symbols)
5512         (debug_qf_expand_symtabs_matching)
5513         (debug_qf_find_pc_sect_compunit_symtab)
5514         (debug_qf_map_symbol_filenames)
5515         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5516         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5517         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5518         (debug_sym_read_linetable, debug_sym_relocate): Update.
5519         (symfile_debug_free_objfile): Remove.
5520         (install_symfile_debug_logging, _initialize_symfile_debug):
5521         Update.
5522
5523 2019-05-08  Tom Tromey  <tom@tromey.com>
5524
5525         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5526         allocate_on_obstack.
5527         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5528         (get_dwarf2_per_objfile): Update.
5529         (set_dwarf2_per_objfile): Remove.
5530         (dwarf2_has_info, dwarf2_get_section_info): Update.
5531         (dwarf2_free_objfile): Remove.
5532         (_initialize_dwarf2_read): Update.
5533
5534 2019-05-08  Tom Tromey  <tom@tromey.com>
5535
5536         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5537         initializers.
5538         <unsupported_script_warning_printed,
5539         script_not_found_warning_printed>: Now bool.
5540         (auto_load_pspace_data): Change type.
5541         (~auto_load_pspace_info): Rename from
5542         auto_load_pspace_data_cleanup.
5543         (get_auto_load_pspace_data, init_loaded_scripts_info)
5544         (clear_section_scripts, maybe_print_unsupported_script_warning)
5545         (maybe_print_script_not_found_warning, _initialize_auto_load):
5546         Update.
5547
5548 2019-05-08  Tom Tromey  <tom@tromey.com>
5549
5550         * objfiles.c (objfile_pspace_info): Add destructor and
5551         initializers.
5552         (objfiles_pspace_data): Change type.
5553         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5554         (get_objfile_pspace_data): Update.
5555         (objfiles_bfd_data): Change type.
5556         (get_objfile_bfd_data): Update.
5557         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5558
5559 2019-05-08  Tom Tromey  <tom@tromey.com>
5560
5561         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5562         Change type.
5563         (get_catch_syscall_inferior_data): Update.
5564         (catch_syscall_inferior_data_cleanup): Remove.
5565         (_initialize_break_catch_syscall): Update.
5566
5567 2019-05-08  Tom Tromey  <tom@tromey.com>
5568
5569         * inflow.c (struct terminal_info): Add destructor and
5570         initializers.
5571         (inflow_inferior_data): Change type.
5572         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5573         (get_inflow_inferior_data, inflow_inferior_exit)
5574         (swap_terminal_info, _initialize_inflow): Update.
5575
5576 2019-05-08  Tom Tromey  <tom@tromey.com>
5577
5578         * target-dcache.c (target_dcache_cleanup): Remove.
5579         (target_dcache_aspace_key): Change type.
5580         (target_dcache_init_p, target_dcache_invalidate)
5581         (target_dcache_get, target_dcache_get_or_init)
5582         (_initialize_target_dcache): Update.
5583         * dcache.h (struct dcache_deleter): New.
5584
5585 2019-05-08  Tom Tromey  <tom@tromey.com>
5586
5587         * symtab.c (struct symbol_cache): Add destructor and
5588         initializers.
5589         (symbol_cache_key): Move.  Change type.
5590         (make_symbol_cache, free_symbol_cache): Remove.
5591         (get_symbol_cache): Update.
5592         (symbol_cache_cleanup): Remove.
5593         (ALL_PSPACES, symbol_cache_flush)
5594         (maintenance_print_symbol_cache)
5595         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5596         Update.
5597
5598 2019-05-08  Tom Tromey  <tom@tromey.com>
5599
5600         * symtab.c (struct main_info): Add destructor and initializers.
5601         (main_progspace_key): Move.  Change type.
5602         (get_main_info): Update.
5603         (main_info_cleanup): Remove.
5604         (_initialize_symtab): Update.
5605
5606 2019-05-08  Tom Tromey  <tom@tromey.com>
5607
5608         * registry.h (DECLARE_REGISTRY): Define the _key class.
5609
5610 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5611
5612         * NEWS: Merge two 'New commands' sections.
5613
5614 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5615
5616         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5617         parameter and use Ada language definition instead.
5618         (ada_val_print_ptr): Remove unused language parameter.
5619         (ada_val_print_num): Remove language parameter and use Ada language
5620         definition instead.
5621         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5622         parameter.
5623         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5624         parameter and use Ada language definition instead.
5625         (ada_val_print_1): Update all ada_val_print_xxx calls.
5626         Remove language parameter.
5627         (ada_val_print): Update ada_val_print_1 call.
5628
5629 2019-05-08  Tom Tromey  <tromey@adacore.com>
5630
5631         * remote.c (remote_hw_watchpoint_limit)
5632         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5633         Now static.
5634
5635 2019-05-08  Tom Tromey  <tromey@adacore.com>
5636
5637         * maint.c (_initialize_maint_cmds): Move initialization code to
5638         remote.c.
5639         (watchdog, show_watchdog): Move to remote.c.
5640         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5641         "watchdog" static.
5642         (_initialize_remote): Move initialization code from maint.c.
5643         * defs.h (watchdog): Don't declare.
5644
5645 2019-05-08  Tom Tromey  <tromey@adacore.com>
5646
5647         * tui/tui-interp.c: Include main.h.
5648         * interps.c: Include main.h.
5649         * main.h (interpreter_p): Declare.
5650         * defs.h (interpreter_p): Don't declare.
5651
5652 2019-05-08  Tom Tromey  <tromey@adacore.com>
5653
5654         * dwarf2loc.c: Include dwarf2read.h.
5655         * defs.h (read_unsigned_leb128): Don't declare.
5656         * dwarf2read.h (read_unsigned_leb128): Declare.
5657
5658 2019-05-08  Tom Tromey  <tromey@adacore.com>
5659
5660         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5661         method.
5662
5663 2019-05-08  Tom Tromey  <tromey@adacore.com>
5664
5665         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5666         when no wrap column is set.
5667
5668 2019-05-08  Tom Tromey  <tromey@adacore.com>
5669
5670         * c-lang.c (c_get_string): Handle non-C-style arrays.
5671
5672 2019-05-08  Tom Tromey  <tromey@adacore.com>
5673
5674         * typeprint.c (print_offset_data::update): Print the bit offset,
5675         not the number of bits remaining.
5676
5677 2019-05-08  Tom Tromey  <tromey@adacore.com>
5678
5679         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5680         padding at end of comment.
5681
5682 2019-05-08  Tom Tromey  <tromey@adacore.com>
5683
5684         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5685         Compare main types.
5686
5687 2019-05-06  Tom Tromey  <tom@tromey.com>
5688
5689         * common/scoped_mmap.c: Include common-defs.h.
5690         * common/scoped_mmap.h: Don't include config.h.
5691
5692 2019-05-04  Tom Tromey  <tom@tromey.com>
5693
5694         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5695         (struct aarch64_call_info): Add initializers.
5696         <si>: Now a std::vector.
5697         (pass_on_stack, aarch64_push_dummy_call): Update.
5698
5699 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5700             Tom Tromey  <tom@tromey.com>
5701
5702         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5703         (ppc_threads): Now a std::vector.  Now static.
5704         (hwdebug_find_thread_points_by_tid)
5705         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5706         Update.
5707
5708 2019-05-04  Tom Tromey  <tom@tromey.com>
5709
5710         * arc-tdep.c (arc_tdesc_init): Return bool.
5711
5712 2019-05-04  Tom Tromey  <tom@tromey.com>
5713
5714         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5715         Use gdb_assert_not_reached.
5716
5717 2019-05-04  Tom Tromey  <tom@tromey.com>
5718
5719         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5720         "false".
5721
5722 2019-05-04  Tom Tromey  <tom@tromey.com>
5723
5724         * arc-tdep.c (arc_tdesc_init): Use bool.
5725
5726 2019-05-04  Tom Tromey  <tom@tromey.com>
5727
5728         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5729
5730 2019-05-04  Tom Tromey  <tom@tromey.com>
5731
5732         * cli/cli-cmds.c (valid_command_p): Return bool.
5733
5734 2019-05-04  Tom Tromey  <tom@tromey.com>
5735
5736         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5737         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5738
5739 2019-05-04  Raul Tambre  <raul@tambre.ee>
5740
5741         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5742         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5743         operator for comparison.
5744
5745 2019-05-04  Tom Tromey  <tom@tromey.com>
5746
5747         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5748         (lookup_partial_symbol, print_partial_symbols)
5749         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5750         (psymbol_compare): Update.
5751         (add_psymbol_to_bcache): Clear the entire psymbol.
5752         (maintenance_check_psymtabs): Update.
5753         * psympriv.h (struct partial_symbol): Don't derive from
5754         general_symbol_info.
5755         <obj_section, unrelocated_address, address,
5756         set_unrelocated_address>: Update.
5757         <ginfo>: New member.
5758         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5759         (debug_names::write_psymbols): Update.
5760
5761 2019-05-04  Tom de Vries  <tdevries@suse.de>
5762
5763         * contrib/cc-with-tweaks.sh: Support -n arg.
5764
5765 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5766
5767         * corelow.c (core_target::detach): Ensure frame cache and
5768         register caches are cleared.
5769         inferior.c (exit_inferior_1): Likewise.
5770
5771 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5772             Tom Tromey  <tom@tromey.com>
5773
5774         * dictionary.c (collate_pending_symbols_by_language): Remove
5775         "struct" from foreach.
5776         * symtab.c (lookup_global_symbol_from_objfile)
5777         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5778         foreach.
5779         * ser-tcp.c (net_open): Remove "struct" from foreach.
5780         * objfiles.c (objfile_relocate, objfile_rebase)
5781         (objfile_has_symbols): Remove "struct" from foreach.
5782         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5783         from foreach.
5784         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5785         foreach.
5786         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5787         "struct" from foreach.
5788         * ada-lang.c (create_excep_cond_exprs)
5789         (ada_exception_catchpoint_cond_string): Remove "struct" from
5790         foreach.
5791
5792 2019-05-03  Tom Tromey  <tromey@adacore.com>
5793
5794         * ada-exp.y (convert_char_literal): Check suffix of each
5795         enumerator.
5796
5797 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5798
5799         PR ada/21406:
5800         * ada-exp.y (yywrap): Don't define.
5801         * ada-lex.l (%option): Add noyywrap
5802         (yywrap): Remove.
5803
5804 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5805
5806         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5807         _WIN32_WINNT to the XP level, unless already defined to a higher
5808         level.
5809
5810         * unittests/parse-connection-spec-selftests.c:
5811         * ser-tcp.c:
5812         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5813         override.
5814
5815         * symfile.c (find_separate_debug_file): Remove colon from the
5816         drive spec of DOS/Windows file names of the target, so that the
5817         file name produced from DEBUGDIR and the target's directory will
5818         be valid on DOS/Windows systems.
5819
5820 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5821
5822         * rust-lang.c (val_print_struct): Handle printing structures
5823         containing strings.
5824
5825 2019-05-02  Tom Tromey  <tromey@adacore.com>
5826
5827         * valarith.c (_initialize_valarith): Remove.
5828
5829 2019-05-01  Tom Tromey  <tromey@adacore.com>
5830
5831         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5832         bitfields.
5833
5834 2019-05-01  Tom Tromey  <tromey@adacore.com>
5835
5836         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5837         for big-endian copies.
5838
5839 2019-04-30  Ali Tamur  <tamur@google.com>
5840         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5841         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5842         (read_3_bytes): New function.
5843
5844 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5845
5846         * windows-nat.c (main_thread_id): Delete.
5847         (handle_output_debug_string): Replace main_thread_id by
5848         current_event.dwThreadId.
5849         (fake_create_process): Likewise.
5850         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5851         Do not set main_thread_id.
5852         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5853         current_event.dwThreadId.
5854         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5855
5856 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5857
5858         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5859         Use current_event.dwThreadId instead of main_thread_id.
5860
5861 2019-04-30  Tom Tromey  <tromey@adacore.com>
5862
5863         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5864         (create_excep_cond_exprs): Iterate over program spaces.
5865         (ada_exception_catchpoint_cond_string): Examine all minimal
5866         symbols for exception types.
5867
5868 2019-04-30  Tom Tromey  <tromey@adacore.com>
5869
5870         PR c++/24470:
5871         * dwarf2read.c (process_structure_scope): Handle case where type
5872         has template parameters but no symbol was created.
5873
5874 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5875             Chris January  <chris.january@arm.com>
5876
5877         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5878         qualifier.
5879         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5880
5881 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5882
5883         * f-typeprint.c (f_print_type): Update rules for printing
5884         whitespace.
5885         (f_type_print_varspec_suffix): Likewise.
5886
5887 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5888             Chris January  <chris.january@arm.com>
5889
5890         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5891         function arguments.
5892
5893 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5894
5895         * f-lang.c (build_fortran_types): Change name of void type to
5896         lower case.
5897         * f-typeprint.c (f_type_print_base): Print the name of the void
5898         type, rather than a fixed string.
5899         * f-valprint.c (f_decorations): Use lower case void string.
5900
5901 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5902             Chris January  <chris.january@arm.com>
5903
5904         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5905         types for Fortran.
5906
5907 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5908             Chris January  <chris.january@arm.com>
5909             David Lecomber  <david.lecomber@arm.com>
5910
5911         * f-exp.y (BINOP_INTRINSIC): New token.
5912         (exp): New parser rule handling BINOP_INTRINSIC.
5913         (f77_keywords): Add new builtin procedures.
5914         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5915         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5916         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5917         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5918         (print_unop_subexp_f): New function.
5919         (print_binop_subexp_f): New function.
5920         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5921         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5922         (dump_subexp_body_f): Likewise.
5923         (operator_check_f): Likewise.
5924         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5925         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5926
5927 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5928
5929         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5930         UNOP_KIND.
5931         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5932         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5933         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5934         (operator_length_f): New fuction.
5935         (print_subexp_f): New function.
5936         (op_name_f): New function.
5937         (dump_subexp_body_f): New function.
5938         (operator_check_f): New function.
5939         (exp_descriptor_f): Replace standard expression handling functions
5940         with new functions.
5941         * gdb/fortran-operator.def: New file.
5942         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5943         * gdb/std-operator.def: Remove UNOP_KIND.
5944
5945 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5946
5947         * std-operator.def: Remove unbalanced, stray double quote
5948         character.
5949
5950 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5951             Chris January  <chris.january@arm.com>
5952             Daniel Everett  <daniel.everett@arm.com>
5953             Nick Forrington  <nick.forrington@arm.com>
5954             Richard Bunt  <richard.bunt@arm.com>
5955
5956         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5957         of depth when printing anonymous structs or unions.
5958         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5959         Don't print either the top-level value, or the children if the
5960         max-depth is exceeded.
5961         (ppscm_print_children): When printing the key of a map, allow one
5962         extra level of depth.
5963         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5964         print either the top-level value, or the children if the max-depth
5965         is exceeded.
5966         (print_children): When printing the key of a map, allow one extra
5967         level of depth.
5968         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5969         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5970         (user_print_options): Initialise max_depth field.
5971         (val_print_scalar_or_string_type_p): New function.
5972         (val_print): Check to see if the max depth has been reached.
5973         (val_print_check_max_depth): Define new function.
5974         (show_print_max_depth): New function.
5975         (_initialize_valprint): Add 'print max-depth' option.
5976         * valprint.h (struct value_print_options) <max_depth>: New field.
5977         (val_print_check_max_depth): Declare new function.
5978         * NEWS: Document new feature.
5979
5980 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5981
5982         * ada-lang.c (ada_language_defn): Initialise new field.
5983         * c-lang.c (c_is_string_type_p): New function.
5984         (c_language_defn): Initialise new field.
5985         (cplus_language_defn): Initialise new field.
5986         (asm_language_defn): Initialise new field.
5987         (minimal_language_defn): Initialise new field.
5988         * c-lang.h (c_is_string_type_p): Declare new function.
5989         * d-lang.c (d_language_defn): Initialise new field.
5990         * f-lang.c (f_is_string_type_p): New function.
5991         (f_language_defn): Initialise new field.
5992         * go-lang.c (go_is_string_type_p): New function.
5993         (go_language_defn): Initialise new field.
5994         * language.c (default_is_string_type_p): New function.
5995         (unknown_language_defn): Initialise new field.
5996         (auto_language_defn): Initialise new field.
5997         * language.h (struct language_defn) <la_is_string_type_p>: New
5998         member variable.
5999         (default_is_string_type_p): Declare new function.
6000         * m2-lang.c (m2_language_defn): Initialise new field.
6001         * objc-lang.c (objc_language_defn): Initialise new field.
6002         * opencl-lang.c (opencl_language_defn): Initialise new field.
6003         * p-lang.c (pascal_is_string_type_p): New function.
6004         (pascal_language_defn): Initialise new field.
6005         * rust-lang.c (rust_is_string_type_p): New function.
6006         (rust_language_defn): Initialise new field.
6007
6008 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6009
6010         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6011         New field.
6012         * ada-lang.c (ada_language_defn): Initialise new field.
6013         * c-lang.c (c_language_defn): Likewise.
6014         (cplus_language_defn): Likewise.
6015         (asm_language_defn): Likewise.
6016         (minimal_language_defn): Likewise.
6017         * d-lang.c (d_language_defn): Likewise.
6018         * f-lang.c (f_language_defn): Likewise.
6019         * go-lang.c (go_language_defn): Likewise.
6020         * language.c (unknown_language_defn): Likewise.
6021         (auto_language_defn): Likewise.
6022         * m2-lang.c (m2_language_defn): Likewise.
6023         * objc-lang.c (objc_language_defn): Likewise.
6024         * opencl-lang.c (opencl_language_defn): Likewise.
6025         * p-lang.c (pascal_language_defn): Likewise.
6026         * rust-lang.c (rust_language_defn): Likewise.
6027
6028 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6029
6030         * ada-lang.c (ada_is_character_type): Change return type to bool.
6031         (ada_is_string_type): Likewise.
6032         * ada-lang.h (ada_is_character_type): Update declaration
6033         (ada_is_string_type): Likewise.
6034
6035 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6036
6037         Support style in 'frame|thread apply'
6038
6039         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6040         * record.c (record_start, record_stop): Update callers of
6041         execute_command_to_string with false.
6042         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6043         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6044         methods.
6045         (class string_file): New constructor with term_out parameter.
6046         Override methods term_out and can_emit_style_escape.  New member
6047         term_out.
6048         (class stdio_file): Override can_emit_style_escape.
6049         (class tee_file): Override term_out and can_emit_style_escape.
6050         * utils.h (can_emit_style_escape): Remove.
6051         * utils.c (can_emit_style_escape): Likewise.
6052         Update all callers of can_emit_style_escape (SOMESTREAM) to
6053         SOMESTREAM->can_emit_style_escape.
6054         * source-cache.c (source_cache::get_source_lines): Likewise.
6055         * stack.c (frame_apply_command_count): Call execute_command_to_string
6056         passing the term_out characteristic of the current gdb_stdout.
6057         * thread.c (thr_try_catch_cmd): Likewise.
6058         * top.c (execute_command_to_string): pass term_out parameter
6059         to construct the string_file for the command output.
6060         * ui-file.c (term_cli_styling): New function (most code moved
6061         from utils.c can_emit_style_escape).
6062         (string_file::string_file, string_file::can_emit_style_escape,
6063         stdio_file::can_emit_style_escape, tee_file::term_out,
6064         tee_file::can_emit_style_escape): New functions.
6065
6066 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6067
6068         * NEWS: Mention the new set|show may-call-functions.
6069         * infcall.c (may_call_functions_p): New variable.
6070         (show_may_call_functions_p): New function.
6071         (call_function_by_hand_dummy): Throws an error if not
6072         may-call-functions.
6073         (_initialize_infcall): Call add_setshow_boolean_cmd for
6074         may-call-functions.
6075
6076 2019-04-25  Keith Seitz  <keiths@redhat.com>
6077
6078         PR c++/24367
6079         * cp-support.c (inspect_type): Don't attempt substitutions
6080         of symbol with the same name.
6081
6082 2019-04-25  Tom Tromey  <tromey@adacore.com>
6083
6084         PR gdb/24475:
6085         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6086         static.
6087
6088 2019-04-25  Tom Tromey  <tromey@adacore.com>
6089
6090         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6091         rvalue reference.
6092         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6093         (gdb_xml_parser::parse): Use std::move.
6094         * python/python-internal.h (gdbpy_convert_exception): Take a const
6095         reference.
6096         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6097         std::move.
6098         * python/py-utils.c (gdbpy_convert_exception): Take a const
6099         reference.
6100         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6101         Use std::move.
6102         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6103         Use std::move.
6104         * mi/mi-main.c (mi_print_exception): Take a const reference.
6105         * main.c (handle_command_errors): Take a const reference.
6106         * linespec.c (parse_linespec): Use std::move.
6107         * infcall.c (run_inferior_call): Use std::move.
6108         (call_function_by_hand_dummy): Use std::move.
6109         * exec.c (try_open_exec_file): Use std::move.
6110         * exceptions.h (exception_print, exception_fprintf)
6111         (exception_print_same): Update.
6112         * exceptions.c (print_exception, exception_print)
6113         (exception_fprintf, exception_print_same): Change parameters to
6114         const reference.
6115         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6116         * common/new-op.c: Use std::move.
6117         * common/common-exceptions.h (struct gdb_exception): Add move
6118         constructor.
6119         (struct gdb_exception_error, struct gdb_exception_quit, struct
6120         gdb_quit_bad_alloc): Change constructor to move constructor.
6121         (throw_exception): Change parameter to rvalue reference.
6122         * common/common-exceptions.c (throw_exception): Take rvalue
6123         reference.
6124         * cli/cli-interp.c (safe_execute_command): Use std::move.
6125         * breakpoint.c (insert_bp_location, location_to_sals): Use
6126         std::move.
6127
6128 2019-04-25  Tom Tromey  <tromey@adacore.com>
6129
6130         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6131         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6132         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6133         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6134         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6135         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6136         guile/scm-value.c: Use unpack.
6137         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6138         gdbscm_gdb_exception.
6139         (gdbscm_throw_gdb_exception): Likewise.
6140         (struct gdbscm_gdb_exception): New.
6141         (unpack): New function.
6142         (gdbscm_wrap): Use unpack.
6143
6144 2019-04-25  Tom Tromey  <tromey@adacore.com>
6145
6146         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6147         (gdb_rl_callback_handler): Use std::move.
6148         * common/common-exceptions.h (struct gdb_exception): Add move
6149         assignment operator.
6150         (throw_exception_sjlj): Change "exception" to const reference.
6151         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6152         (throw_exception_sjlj): Change "exception" to const reference.
6153
6154 2019-04-25  Tom Tromey  <tromey@adacore.com>
6155
6156         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6157         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6158         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6159         Update.
6160         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6161         Update.
6162         * mi/mi-interp.c (mi_interp::exec): Update.
6163         * linespec.c (parse_linespec): Update.
6164         * infcall.c (run_inferior_call): Update.
6165         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6166         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6167         (gdbscm_lookup_global_symbol): Update.
6168         * guile/scm-param.c (gdbscm_parameter_value): Update.
6169         * guile/scm-frame.c (gdbscm_frame_read_register)
6170         (gdbscm_frame_read_var): Update.
6171         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6172         * exec.c (try_open_exec_file): Update.
6173         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6174         (gdb_rl_callback_handler): Update.
6175         * common/common-exceptions.h (exception_none): Don't declare.
6176         * common/common-exceptions.c (exception_none): Don't define.
6177         (struct catcher) <exception>: Update.
6178         * cli/cli-interp.c (safe_execute_command): Update.
6179         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6180
6181 2019-04-25  Ali Tamur  <tamur@google.com>
6182
6183         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6184         (read_attribute_value): Likewise.
6185         (dwarf2_read_addr_index): Update comment.
6186         (read_str_index): Add DW_FORM_strx.
6187         (dwarf2_string_attr): Likewise.
6188         (dwarf2_const_value_attr): Likewise.
6189         (dump_die_shallow): Likewise.
6190         (dwarf2_fetch_constant_bytes): Likewise.
6191         (skip_form_bytes): Likewise.
6192         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6193
6194 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6195
6196         PR corefiles/11608
6197         PR corefiles/18187
6198         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6199         OFFSET.  Verify if current mapping contains an ELF header.
6200         (linux_find_memory_regions_full): Adjust call to
6201         dump_mapping_p.
6202
6203 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6204             Kang Li <kanglictf@gmail.com>
6205
6206         PR gdb/21600
6207
6208         * dwarf2-frame.c (read_initial_length): Be consistent about using
6209         unsigned representation of length.
6210         (decode_frame_entry_1): Likewise.  Check for wraparound of
6211         end pointer as well as buffer overflow.
6212
6213 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6214
6215         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6216         "vq".
6217
6218 2019-04-24  Tom Tromey  <tromey@adacore.com>
6219
6220         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6221
6222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6223
6224         * s12z-tdep.c (s12z_unwind_pc): Delete.
6225         (s12z_unwind_sp): Delete.
6226         (s12z_gdbarch_init): Don't register deleted functions with
6227         gdbarch.
6228
6229 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6230
6231         * rl78-tdep.c (rl78_unwind_sp): Delete.
6232         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6233
6234 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6235
6236         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6237         (xstormy16_unwind_pc): Delete.
6238         (xstormy16_dummy_id): Delete.
6239         (xstormy16_gdbarch_init): Don't register deleted functions with
6240         gdbarch.
6241
6242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6243
6244         * vax-tdep.c (vax_unwind_pc): Delete.
6245         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6246
6247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6248
6249         * v850-tdep.c (v850_unwind_sp): Delete.
6250         (v850_unwind_pc): Delete.
6251         (v850_dummy_id): Delete.
6252         (v850_gdbarch_init): Don't register deleted functions with
6253         gdbarch.
6254
6255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6256
6257         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6258         (tilegx_unwind_pc): Delete.
6259         (tilegx_unwind_dummy_id): Delete.
6260         (tilegx_gdbarch_init): Don't register deleted functions with
6261         gdbarch.
6262
6263 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6264
6265         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6266         (tic6x_dummy_id): Delete.
6267         (tic6x_gdbarch_init): Don't register deleted functions with
6268         gdbarch.
6269
6270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6271
6272         * sparc-tdep.c (sparc_unwind_pc): Delete.
6273         (sparc32_gdbarch_init): Don't register deleted function with
6274         gdbarch.
6275
6276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6277
6278         * sh-tdep.c (sh_unwind_sp): Delete.
6279         (sh_unwind_pc): Delete.
6280         (sh_dummy_id): Delete.
6281         (sh_gdbarch_init): Don't register deleted functions with
6282         gdbarch.
6283
6284 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6285
6286         * score-tdep.c (score_unwind_sp): Delete.
6287         (score_unwind_pc): Delete.
6288         (score_dummy_id): Delete.
6289         (score_gdbarch_init): Don't register deleted functions with
6290         gdbarch.
6291
6292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6293
6294         * rx-tdep.c (rx_unwind_pc): Delete.
6295         (rx_unwind_sp): Delete.
6296         (rx_dummy_id): Delete.
6297         (rx_gdbarch_init): Don't register deleted functions with
6298         gdbarch.  Update comment.
6299
6300 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6301
6302         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6303         (rs6000_dummy_id): Delete.
6304         (rs6000_gdbarch_init): Don't register deleted functions with
6305         gdbarch.
6306
6307 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6308
6309         * or1k-tdep.c (or1k_dummy_id): Delete.
6310         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6311
6312 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6313
6314         * nios2-tdep.c (nios2_dummy_id): Delete.
6315         (nios2_unwind_sp): Delete.
6316         (nios2_gdbarch_init): Don't register deleted functions with
6317         gdbarch.
6318
6319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6320
6321         * nds32-tdep.c (nds32_dummy_id): Delete.
6322         (nds32_unwind_pc): Delete.
6323         (nds32_unwind_sp): Delete.
6324         (nds32_gdbarch_init): Don't register deleted functions with
6325         gdbarch.
6326
6327 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6328
6329         * msp430-tdep.c (msp430_unwind_pc): Delete.
6330         (msp430_unwind_sp): Delete.
6331         (msp430_dummy_id): Delete.
6332         (msp430_gdbarch_init): Don't register deleted functions with
6333         gdbarch.
6334
6335 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6336
6337         * moxie-tdep.c (moxie_unwind_sp): Delete.
6338         (moxie_unwind_pc): Delete.
6339         (moxie_dummy_id): Delete.
6340         (moxie_gdbarch_init): Don't register deleted functions with
6341         gdbarch.
6342
6343 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6344
6345         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6346         (mn10300_unwind_pc): Delete.
6347         (mn10300_unwind_sp): Delete.
6348         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6349         mn10300_unwind_sp.
6350         (mn10300_frame_unwind_init): Don't register deleted functions with
6351         gdbarch.
6352
6353 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6354
6355         * mep-tdep.c (mep_unwind_pc): Delete.
6356         (mep_unwind_sp): Delete.
6357         (mep_dummy_id): Delete.
6358         (mep_gdbarch_init): Don't register deleted functions with
6359         gdbarch.
6360
6361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6362
6363         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6364         (m68hc11_unwind_sp): Delete.
6365         (m68hc11_gdbarch_init): Don't register deleted functions with
6366         gdbarch.
6367
6368 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6369
6370         * m32r-tdep.c (m32r_unwind_sp): Delete.
6371         (m32r_unwind_pc): Delete.
6372         (m32r_dummy_id): Delete.
6373         (m32r_gdbarch_init): Don't register deleted functions with
6374         gdbarch.
6375
6376 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6377
6378         * m32c-tdep.c (m32c_unwind_pc): Delete.
6379         (m32c_unwind_sp): Delete.
6380         (m32c_dummy_id): Delete.
6381         (m32c_gdbarch_init): Don't register deleted functions with
6382         gdbarch.
6383
6384 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6385
6386         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6387         (lm32_unwind_pc): Delete.
6388         (lm32_dummy_id): Delete.
6389         (lm32_gdbarch_init): Don't register deleted functions with
6390         gdbarch.
6391
6392 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6393
6394         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6395         (iq2000_unwind_pc): Delete.
6396         (iq2000_dummy_id): Delete.
6397         (iq2000_gdbarch_init): Don't register deleted functions with
6398         gdbarch.
6399
6400 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6401
6402         * nds32-tdep.c (nds32_type_align): Delete.
6403         (nds32_push_dummy_call): Use type_align instead.
6404
6405 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6406
6407         * arm-tdep.c (arm_type_align): Only handle vector override case.
6408         (arm_push_dummy_call): Use type_align.
6409         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6410
6411 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6412
6413         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6414         case.
6415         (pass_on_stack): Use type_align.
6416         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6417         function.
6418
6419 2019-04-23  Tom Tromey  <tromey@adacore.com>
6420
6421         * dwarf2read.c (line_header::file_name_at): Remove unused
6422         overload.
6423
6424 2019-04-23  Tom de Vries  <tdevries@suse.de>
6425
6426         PR gdb/24438
6427         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6428         invocation.
6429
6430
6431 2019-03-27  Ali Tamur  <tamur@google.com>
6432
6433         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6434         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6435         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6436         (dwarf_expr_context::get_addr_index): Likewise
6437         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6438         (symbol_needs_eval_context::get_addr_index): Likewise
6439         (disassemble_dwarf_expression): Add DW_OP_addrx
6440         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6441         (read_cutu_die_from_dwo): Update comment
6442         (skip_one_die): Add DW_FORM_addrx
6443         (read_attribute_value): Likewise
6444         (var_decode_location): Add DW_OP_addrx
6445         (dwarf2_const_value_attr): Add DW_FORM_addrx
6446         (dump_die_shallow): Likewise
6447         (dwarf2_fetch_constant_bytes): Likewise
6448         (decode_locdesc): Add DW_OP_addrx
6449         (skip_form_bytes): Add DW_FORM_addrx
6450
6451 2019-04-22  Ali Tamur  <tamur@google.com>
6452
6453         * MAINTAINERS (Write After Approval): Add self.
6454
6455 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6456
6457         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6458         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6459         (open_symbol_file_object): Likewise.
6460         (svr4_default_sos): Add info parameter.
6461         (svr4_read_so_list): Likewise.
6462         (svr4_current_sos_direct): Adjust functions calls to pass down
6463         info.
6464         (svr4_current_sos_1): Add info parameter.
6465         (svr4_current_sos): Call get_svr4_info, pass info down to
6466         svr4_current_sos_1.
6467         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6468         get_svr4_info.
6469         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6470         get_svr4_info.
6471         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6472         to get_svr4_info.
6473         (probes_table_remove_objfile_probes): Likewise.
6474         (register_solib_event_probe): Add info parameter.
6475         (solist_update_incremental): Pass info parameter down to
6476         svr4_read_so_list.
6477         (disable_probes_interface): Add info parameter.
6478         (svr4_handle_solib_event): Pass current_program_space to
6479         get_svr4_info.  Adjust disable_probes_interface cleanup.
6480         (svr4_create_probe_breakpoints): Add info parameter, pass it
6481         down to register_solib_event_probe.
6482         (svr4_create_solib_event_breakpoints): Add info parameter,
6483         pass it down to svr4_create_probe_breakpoints.
6484         (enable_break): Pass info down to
6485         svr4_create_solib_event_breakpoints.
6486         (svr4_solib_create_inferior_hook): Pass current_program_space to
6487         get_svr4_info.
6488         (svr4_clear_solib): Likewise.
6489
6490 2019-04-22  Pedro Alves  <palves@redhat.com>
6491
6492         * solib-svr4.c (svr4_free_objfile_observer): New.
6493         (probe_and_action::objfile): New field.
6494         (probes_table_htab_remove_objfile_probes)
6495         (probes_table_remove_objfile_probes): New functions.
6496         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6497         in the new probe_and_action.  Don't store the probe in 'lookup'.
6498         (svr4_create_probe_breakpoints): Pass objfile to
6499         register_solib_event_probe.
6500         (_initialize_svr4_solib): Register a free_objfile observer.
6501
6502 2019-04-19  Tom Tromey  <tom@tromey.com>
6503
6504         * common/queue.h: Remove.
6505
6506 2019-04-19  Tom Tromey  <tom@tromey.com>
6507
6508         * event-loop.c: Don't include "common/queue.h".
6509
6510 2019-04-19  Tom Tromey  <tom@tromey.com>
6511
6512         * remote.c (remote_target): Use delete.
6513         * remote-notif.h: Include <list>, not "common/queue.h".
6514         (notif_client_p): Remove typedef.
6515         (remote_notif_state): Add constructor, destructor, initializer.
6516         <notif_queue>: Now a std::list.
6517         (remote_notif_state_xfree): Don't declare.
6518         * remote-notif.c (remote_notif_process, handle_notification)
6519         (remote_notif_state_allocate): Update.
6520         (~remote_notif_state): Rename from remote_notif_state_xfree.
6521
6522 2019-04-19  Tom Tromey  <tom@tromey.com>
6523
6524         * symfile.c (reread_symbols): Update.
6525         * objfiles.c (objfile_register_static_link)
6526         (objfile_lookup_static_link): Update
6527         (~objfile) Don't delete static_links.
6528         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6529
6530 2019-04-19  Tom Tromey  <tom@tromey.com>
6531
6532         * type-stack.h (struct type_stack) <insert>: Constify string.
6533         * type-stack.c (type_stack::insert): Constify string.
6534         * gdbtypes.h (lookup_template_type): Update.
6535         (address_space_name_to_int): Update.
6536         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6537         const.
6538         (lookup_template_type): Make name const.
6539         * c-exp.y: Update rules.
6540         (lex_one_token, classify_name, classify_inner_name)
6541         (c_print_token): Update.
6542         * p-exp.y: Update rules.
6543         (yylex): Update.
6544         * f-exp.y: Update rules.
6545         (yylex): Update.
6546         * d-exp.y: Update rules.
6547         (lex_one_token, classify_name, classify_inner_name): Update.
6548         * parse.c (write_dollar_variable, copy_name): Return std::string.
6549         * parser-defs.h (copy_name): Change return type.
6550         * m2-exp.y: Update rules.
6551         (yylex): Update.
6552         * go-exp.y (lex_one_token): Update.
6553         Update rules.
6554         (classify_unsafe_function, classify_packaged_name)
6555         (classify_name, yylex): Update.
6556
6557 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6558
6559         * configure.ac: add --enable-source-highlight switch.
6560         * configure: Regenerate.
6561         * top.c (print_gdb_version): plumb --enable-source-highlight
6562         status to "show configuration".
6563
6564 2019-04-19  Tom Tromey  <tromey@adacore.com>
6565
6566         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6567         Check ADA_TYPE_P.
6568         (empty_record, ada_template_to_fixed_record_type_1)
6569         (template_to_static_fixed_type)
6570         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6571         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6572         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6573         macros.
6574
6575 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6576
6577         PR symtab/24423:
6578         * source.c (print_source_lines_base): Advance "iter" when a
6579         control character is seen.
6580
6581 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6582
6583         * inferior.h (struct infcall_suspend_state_deleter):
6584         Catch exception in destructor to avoid crash.
6585
6586 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6587
6588         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6589         close to the add_com "shell".
6590
6591 2019-04-18  Tom Tromey  <tromey@adacore.com>
6592
6593         * process-stratum-target.h (class process_stratum_target)
6594         <stratum>: Add "final".
6595
6596 2019-04-17  Tom Tromey  <tromey@adacore.com>
6597
6598         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6599         against nullptr before use.
6600
6601 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6602
6603         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6604
6605 2019-04-17  Jim Wilson  <jimw@sifive.com>
6606             Andrew Burgess  <andrew.burgess@embecosm.com>
6607
6608         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6609         code read might fail, assume 4-byte breakpoint in that case.
6610
6611 2019-04-15  Leszek Swirski  <leszeks@google.com>
6612
6613         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6614         rather than a hand-rolled POD check when checking for forced MEMORY
6615         classification.
6616
6617 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6618
6619         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6620         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6621         function.
6622         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6623         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6624         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6625         declaration.
6626
6627 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6628
6629         * aarch64-linux-nat.c
6630         (aarch64_linux_nat_target::thread_architecture): Add override.
6631         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6632         each VQ.
6633
6634 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6635
6636         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6637
6638 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6639
6640         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6641         target types of size 96-bits, add some additional comments, and
6642         check that the builtin type we found was the correct size.
6643
6644 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6645
6646         * utils.c (prompt_for_continue): Don't restore the styling at the
6647         end, as applied_style has the wrong value.  This fixes styling in
6648         long lists of file names that are interrupted by the "Continue?"
6649         prompt.
6650
6651 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6652
6653         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6654         * c-lang.c (c_language_defn): Likewise.
6655         (cplus_language_defn): Likewise.
6656         (asm_language_defn): Likewise.
6657         (minimal_language_defn): Likewise.
6658         * d-lang.c (d_language_defn): Likewise.
6659         * f-lang.c (f_language_defn): Likewise.
6660         * go-lang.c (go_language_defn): Likewise.
6661         * language.c (unknown_language_defn): Likewise.
6662         (auto_language_defn): Likewise.
6663         * language.h (struct language_defn): Remove la_magic field.
6664         (LANG_MAGIC): Delete.
6665         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6666         * objc-lang.c (objc_language_defn): Likewise.
6667         * opencl-lang.c (opencl_language_defn): Likewise.
6668         * p-lang.c (pascal_language_defn): Likewise.
6669         * rust-lang.c (rust_language_defn): Likewise.
6670
6671 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6672
6673         * riscv-tdep.c (riscv_type_align): New function.
6674         (riscv_type_alignment): Delete.
6675         (riscv_arg_location): Use 'type_align'.
6676         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6677
6678 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6679
6680         * gdbtypes.c (type_align): A struct with no non-static fields also
6681         has alignment of 1.
6682
6683 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6684
6685         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6686         component to 0.
6687         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6688         member.
6689         (riscv_struct_info::analyse): New implementation using new
6690         analyse_inner member function.
6691         (riscv_struct_info::field_offset): New member function.
6692         (riscv_struct_info::m_offsets): New member variable.
6693         (riscv_struct_info::analyse_inner): New private member function,
6694         takes the old implementation of riscv_struct_info::analyse but
6695         extended to track field offsets.
6696         (riscv_call_arg_struct): Update the struct folding special cases
6697         to handle cases where empty C++ structs, which are non-zero
6698         length, are found.
6699         (riscv_arg_location): Initialise the length of each location, a
6700         non-zero length now indicates the location is in use.
6701         (riscv_push_dummy_call): Allow for the first location having a
6702         non-zero offset when setting up arguments.
6703         (riscv_return_value): Likewise, but for return values.
6704
6705 2019-04-11  Tom Tromey  <tromey@adacore.com>
6706
6707         * utils.c (internal_vproblem): Make "msg" const.
6708
6709 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6710
6711         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6712         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6713         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6714         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6715
6716 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6717
6718         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6719         function.
6720         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6721         of amd64_collect_native_gregset.
6722         (amd64_linux_nat_target::store_registers): Likewise.
6723
6724 2019-04-10  Tom Tromey  <tom@tromey.com>
6725
6726         * symtab.c (lookup_global_symbol_from_objfile)
6727         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6728         * objfiles.h (class separate_debug_iterator): New.
6729         (class separate_debug_range): New.
6730         (struct objfile) <separate_debug_objfiles>: New method.
6731         (objfile_separate_debug_iterate): Don't declare.
6732         * objfiles.c (separate_debug_iterator::operator++): Rename from
6733         objfile_separate_debug_iterate.
6734         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6735         iterator.
6736         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6737         iterator.
6738
6739 2019-04-10  Tom Tromey  <tom@tromey.com>
6740
6741         * symfile.c (reread_symbols): Remove old comment.
6742         * objfiles.c (free_all_objfiles): Fix a typo.
6743
6744 2019-04-10  Tom Tromey  <tom@tromey.com>
6745
6746         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6747         * minsyms.c (lookup_minimal_symbol): Use foreach.
6748         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6749         (lookup_minimal_symbol_solib_trampoline): Likewise.
6750         * symfile.c (reread_symbols): Use foreach.
6751
6752 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6753             Tom Tromey  <tromey@adacore.com>
6754
6755         PR rust/24414:
6756         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6757         (rust_lex_int_test): Change "value" to be LONGEST.
6758         (rust_lex_tests): Add test for long integer literal.
6759
6760 2019-04-09  Tom Tromey  <tromey@adacore.com>
6761
6762         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6763         to bool.
6764         (extended_remote_target::attach): Update.
6765         (remote_target::remote_notice_new_inferior): Update.
6766         (remote_target::add_current_inferior_and_thread): Update.
6767         * inferior.c (exit_inferior_1): Use "false".
6768         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6769
6770 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6771
6772         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6773         the "start" command.
6774
6775 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6776
6777         * python/py-inferior.c (infpy_thread_from_thread_handle):
6778         Adjust comments to reflect renaming of thread_from_thread_handle
6779         to thread_from_handle.  Adjust keywords.  Fix type error message.
6780         (inferior_object_methods): Add thread_from_handle.  Retain
6781         thread_from_thread_handle, but mark it as deprecated.
6782
6783 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6784
6785         * gdbthread.h (find_thread_by_handle): Revise declaration.
6786         * thread.c (find_thread_by_handle): Likewise.  Adjust
6787         implementation too.
6788         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6789         support for buffer objects as handles.
6790
6791 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6792
6793         * python/py-infthread.c (thpy_thread_handle): New function.
6794         (thread_object_methods): Register thpy_thread_handle.
6795
6796 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6797
6798         * gdbthread.h (thread_to_thread_handle): Declare.
6799         * thread.c (gdbtypes.h): Include.
6800         (thread_to_thread_handle): New function.
6801
6802         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6803         (target_thread_info_to_thread_handle): Declare.
6804         * target.c (target_thread_info_to_thread_handle): New function.
6805         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6806         * target-delegates.c: Regenerate.
6807
6808         * linux-thread-db.c (class thread_db_target): Add method
6809         thread_info_to_thread_handle.
6810         (thread_db_target::thread_info_to_thread_handle): Define.
6811         * remote.c (class remote_target): Add new method
6812         thread_info_to_thread_handle.
6813         (remote_target::thread_info_to_thread_handle): Define.
6814
6815 2019-04-08  Pedro Alves  <palves@redhat.com>
6816
6817         * common/common-exceptions.c (throw_exception): Don't create
6818         named object to throw; throw directly.
6819         (throw_it): Likewise.  Don't initialize gdb_exception::message
6820         here, with new; pass FMT and AP to the ctor instead.
6821         * common/common-exceptions.h: Include <string>.
6822         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6823         const char *, va_list)): New ctor.  Use std::make_shared.
6824         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6825         errors)): Delete.
6826         (gdb_exception_error::gdb_exception_error(enum errors, const char
6827         *, va_list)): New.
6828         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6829         Add assertion.
6830         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6831         errors)): Delete.
6832         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6833         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6834         Add assertion.
6835
6836 2019-04-08  Tom Tromey  <tom@tromey.com>
6837
6838         * valops.c (value_rtti_indirect_type): Replace throw_exception
6839         with throw.
6840         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6841         with throw.
6842         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6843         throw.
6844         * target.c (target_translate_tls_address): Replace throw_exception
6845         with throw.
6846         * stack.c (frame_apply_command_count): Replace throw_exception
6847         with throw.
6848         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6849         throw.
6850         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6851         with throw.
6852         * rs6000-tdep.c (rs6000_frame_cache)
6853         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6854         * remote.c: Replace throw_exception with throw.
6855         * record-full.c (record_full_message, record_full_wait_1)
6856         (record_full_restore): Replace throw_exception with throw.
6857         * record-btrace.c:
6858         (get_thread_current_frame_id, record_btrace_start_replaying)
6859         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6860         (cmd_record_btrace_start): Replace throw_exception with throw.
6861         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6862         throw.
6863         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6864         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6865         * linespec.c:
6866         (find_linespec_symbols): Replace throw_exception with throw.
6867         * infrun.c (displaced_step_prepare, resume): Replace
6868         throw_exception with throw.
6869         * infcmd.c (post_create_inferior): Replace throw_exception with
6870         throw.
6871         * inf-loop.c (inferior_event_handler): Replace throw_exception
6872         with throw.
6873         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6874         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6875         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6876         (get_prev_frame_always, get_frame_pc_if_available)
6877         (get_frame_address_in_block_if_available, get_frame_language):
6878         Replace throw_exception with throw.
6879         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6880         throw_exception with throw.
6881         * eval.c (fetch_subexp_value, evaluate_var_value)
6882         (evaluate_funcall, evaluate_subexp_standard): Replace
6883         throw_exception with throw.
6884         * dwarf2loc.c (call_site_find_chain)
6885         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6886         Replace throw_exception with throw.
6887         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6888         with throw.
6889         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6890         throw.
6891         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6892         * completer.c (complete_line_internal): Replace throw_exception
6893         with throw.
6894         * compile/compile-object-run.c (compile_object_run): Replace
6895         throw_exception with throw.
6896         * cli/cli-script.c (process_next_line): Replace throw_exception
6897         with throw.
6898         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6899         (btrace_enable, btrace_maint_update_pt_packets): Replace
6900         throw_exception with throw.
6901         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6902         throw_exception with throw.
6903         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6904         throw_exception with throw.
6905         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6906         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6907         * aarch64-tdep.c (aarch64_make_prologue_cache)
6908         (aarch64_make_stub_cache): Replace throw_exception with throw.
6909
6910 2019-04-08  Tom Tromey  <tom@tromey.com>
6911
6912         * common/common-exceptions.c (throw_exception): Rename from
6913         throw_exception_cxx.  Remove old copy.  Make argument const.
6914         (throw_it): Create and throw exception objects directly.
6915         * common/common-exceptions.h (throw_exception): Make argument
6916         const.
6917         (struct gdb_exception_error): Add constructor.
6918         (struct gdb_exception_quit): Add constructor.
6919
6920 2019-04-08  Tom Tromey  <tom@tromey.com>
6921
6922         * common/common-exceptions.h (exception_rethrow): Don't declare.
6923         (TRY_SJLJ): Update comment.
6924         (TRY, CATCH, END_CATCH): Remove.
6925         * common/common-exceptions.c (exception_rethrow): Remove.
6926
6927 2019-04-08  Tom Tromey  <tom@tromey.com>
6928
6929         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6930         Remove.
6931         (gdb_exception_error): Rename from
6932         gdb_exception_RETURN_MASK_ERROR.
6933         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6934         (gdb_quit_bad_alloc): Update.
6935         * aarch64-tdep.c: Update.
6936         * ada-lang.c: Update.
6937         * ada-typeprint.c: Update.
6938         * ada-valprint.c: Update.
6939         * amd64-tdep.c: Update.
6940         * arch-utils.c: Update.
6941         * break-catch-throw.c: Update.
6942         * breakpoint.c: Update.
6943         * btrace.c: Update.
6944         * c-varobj.c: Update.
6945         * cli/cli-cmds.c: Update.
6946         * cli/cli-interp.c: Update.
6947         * cli/cli-script.c: Update.
6948         * common/common-exceptions.c: Update.
6949         * common/new-op.c: Update.
6950         * common/selftest.c: Update.
6951         * compile/compile-c-symbols.c: Update.
6952         * compile/compile-cplus-symbols.c: Update.
6953         * compile/compile-object-load.c: Update.
6954         * compile/compile-object-run.c: Update.
6955         * completer.c: Update.
6956         * corelow.c: Update.
6957         * cp-abi.c: Update.
6958         * cp-support.c: Update.
6959         * cp-valprint.c: Update.
6960         * darwin-nat.c: Update.
6961         * disasm-selftests.c: Update.
6962         * dtrace-probe.c: Update.
6963         * dwarf-index-cache.c: Update.
6964         * dwarf-index-write.c: Update.
6965         * dwarf2-frame-tailcall.c: Update.
6966         * dwarf2-frame.c: Update.
6967         * dwarf2loc.c: Update.
6968         * dwarf2read.c: Update.
6969         * eval.c: Update.
6970         * event-loop.c: Update.
6971         * event-top.c: Update.
6972         * exec.c: Update.
6973         * f-valprint.c: Update.
6974         * fbsd-tdep.c: Update.
6975         * frame-unwind.c: Update.
6976         * frame.c: Update.
6977         * gdbtypes.c: Update.
6978         * gnu-v3-abi.c: Update.
6979         * guile/guile-internal.h: Update.
6980         * guile/scm-block.c: Update.
6981         * guile/scm-breakpoint.c: Update.
6982         * guile/scm-cmd.c: Update.
6983         * guile/scm-disasm.c: Update.
6984         * guile/scm-frame.c: Update.
6985         * guile/scm-lazy-string.c: Update.
6986         * guile/scm-math.c: Update.
6987         * guile/scm-param.c: Update.
6988         * guile/scm-ports.c: Update.
6989         * guile/scm-pretty-print.c: Update.
6990         * guile/scm-symbol.c: Update.
6991         * guile/scm-symtab.c: Update.
6992         * guile/scm-type.c: Update.
6993         * guile/scm-value.c: Update.
6994         * i386-linux-tdep.c: Update.
6995         * i386-tdep.c: Update.
6996         * inf-loop.c: Update.
6997         * infcall.c: Update.
6998         * infcmd.c: Update.
6999         * infrun.c: Update.
7000         * jit.c: Update.
7001         * language.c: Update.
7002         * linespec.c: Update.
7003         * linux-fork.c: Update.
7004         * linux-nat.c: Update.
7005         * linux-tdep.c: Update.
7006         * linux-thread-db.c: Update.
7007         * main.c: Update.
7008         * mi/mi-cmd-break.c: Update.
7009         * mi/mi-cmd-stack.c: Update.
7010         * mi/mi-interp.c: Update.
7011         * mi/mi-main.c: Update.
7012         * objc-lang.c: Update.
7013         * p-valprint.c: Update.
7014         * parse.c: Update.
7015         * ppc-linux-tdep.c: Update.
7016         * printcmd.c: Update.
7017         * python/py-arch.c: Update.
7018         * python/py-breakpoint.c: Update.
7019         * python/py-cmd.c: Update.
7020         * python/py-finishbreakpoint.c: Update.
7021         * python/py-frame.c: Update.
7022         * python/py-framefilter.c: Update.
7023         * python/py-gdb-readline.c: Update.
7024         * python/py-inferior.c: Update.
7025         * python/py-infthread.c: Update.
7026         * python/py-lazy-string.c: Update.
7027         * python/py-linetable.c: Update.
7028         * python/py-objfile.c: Update.
7029         * python/py-param.c: Update.
7030         * python/py-prettyprint.c: Update.
7031         * python/py-progspace.c: Update.
7032         * python/py-record-btrace.c: Update.
7033         * python/py-record.c: Update.
7034         * python/py-symbol.c: Update.
7035         * python/py-type.c: Update.
7036         * python/py-unwind.c: Update.
7037         * python/py-utils.c: Update.
7038         * python/py-value.c: Update.
7039         * python/python.c: Update.
7040         * record-btrace.c: Update.
7041         * record-full.c: Update.
7042         * remote-fileio.c: Update.
7043         * remote.c: Update.
7044         * riscv-tdep.c: Update.
7045         * rs6000-aix-tdep.c: Update.
7046         * rs6000-tdep.c: Update.
7047         * rust-exp.y: Update.
7048         * rust-lang.c: Update.
7049         * s390-tdep.c: Update.
7050         * selftest-arch.c: Update.
7051         * solib-dsbt.c: Update.
7052         * solib-frv.c: Update.
7053         * solib-spu.c: Update.
7054         * solib-svr4.c: Update.
7055         * solib.c: Update.
7056         * sparc64-linux-tdep.c: Update.
7057         * stack.c: Update.
7058         * symfile-mem.c: Update.
7059         * symmisc.c: Update.
7060         * target.c: Update.
7061         * thread.c: Update.
7062         * top.c: Update.
7063         * tracefile-tfile.c: Update.
7064         * tui/tui.c: Update.
7065         * typeprint.c: Update.
7066         * unittests/cli-utils-selftests.c: Update.
7067         * unittests/parse-connection-spec-selftests.c: Update.
7068         * valops.c: Update.
7069         * valprint.c: Update.
7070         * value.c: Update.
7071         * varobj.c: Update.
7072         * windows-nat.c: Update.
7073         * x86-linux-nat.c: Update.
7074         * xml-support.c: Update.
7075
7076 2019-04-08  Tom Tromey  <tom@tromey.com>
7077
7078         * xml-support.c: Use C++ exception handling.
7079         * x86-linux-nat.c: Use C++ exception handling.
7080         * windows-nat.c: Use C++ exception handling.
7081         * varobj.c: Use C++ exception handling.
7082         * value.c: Use C++ exception handling.
7083         * valprint.c: Use C++ exception handling.
7084         * valops.c: Use C++ exception handling.
7085         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7086         handling.
7087         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7088         * typeprint.c: Use C++ exception handling.
7089         * tui/tui.c: Use C++ exception handling.
7090         * tracefile-tfile.c: Use C++ exception handling.
7091         * top.c: Use C++ exception handling.
7092         * thread.c: Use C++ exception handling.
7093         * target.c: Use C++ exception handling.
7094         * symmisc.c: Use C++ exception handling.
7095         * symfile-mem.c: Use C++ exception handling.
7096         * stack.c: Use C++ exception handling.
7097         * sparc64-linux-tdep.c: Use C++ exception handling.
7098         * solib.c: Use C++ exception handling.
7099         * solib-svr4.c: Use C++ exception handling.
7100         * solib-spu.c: Use C++ exception handling.
7101         * solib-frv.c: Use C++ exception handling.
7102         * solib-dsbt.c: Use C++ exception handling.
7103         * selftest-arch.c: Use C++ exception handling.
7104         * s390-tdep.c: Use C++ exception handling.
7105         * rust-lang.c: Use C++ exception handling.
7106         * rust-exp.y: Use C++ exception handling.
7107         * rs6000-tdep.c: Use C++ exception handling.
7108         * rs6000-aix-tdep.c: Use C++ exception handling.
7109         * riscv-tdep.c: Use C++ exception handling.
7110         * remote.c: Use C++ exception handling.
7111         * remote-fileio.c: Use C++ exception handling.
7112         * record-full.c: Use C++ exception handling.
7113         * record-btrace.c: Use C++ exception handling.
7114         * python/python.c: Use C++ exception handling.
7115         * python/py-value.c: Use C++ exception handling.
7116         * python/py-utils.c: Use C++ exception handling.
7117         * python/py-unwind.c: Use C++ exception handling.
7118         * python/py-type.c: Use C++ exception handling.
7119         * python/py-symbol.c: Use C++ exception handling.
7120         * python/py-record.c: Use C++ exception handling.
7121         * python/py-record-btrace.c: Use C++ exception handling.
7122         * python/py-progspace.c: Use C++ exception handling.
7123         * python/py-prettyprint.c: Use C++ exception handling.
7124         * python/py-param.c: Use C++ exception handling.
7125         * python/py-objfile.c: Use C++ exception handling.
7126         * python/py-linetable.c: Use C++ exception handling.
7127         * python/py-lazy-string.c: Use C++ exception handling.
7128         * python/py-infthread.c: Use C++ exception handling.
7129         * python/py-inferior.c: Use C++ exception handling.
7130         * python/py-gdb-readline.c: Use C++ exception handling.
7131         * python/py-framefilter.c: Use C++ exception handling.
7132         * python/py-frame.c: Use C++ exception handling.
7133         * python/py-finishbreakpoint.c: Use C++ exception handling.
7134         * python/py-cmd.c: Use C++ exception handling.
7135         * python/py-breakpoint.c: Use C++ exception handling.
7136         * python/py-arch.c: Use C++ exception handling.
7137         * printcmd.c: Use C++ exception handling.
7138         * ppc-linux-tdep.c: Use C++ exception handling.
7139         * parse.c: Use C++ exception handling.
7140         * p-valprint.c: Use C++ exception handling.
7141         * objc-lang.c: Use C++ exception handling.
7142         * mi/mi-main.c: Use C++ exception handling.
7143         * mi/mi-interp.c: Use C++ exception handling.
7144         * mi/mi-cmd-stack.c: Use C++ exception handling.
7145         * mi/mi-cmd-break.c: Use C++ exception handling.
7146         * main.c: Use C++ exception handling.
7147         * linux-thread-db.c: Use C++ exception handling.
7148         * linux-tdep.c: Use C++ exception handling.
7149         * linux-nat.c: Use C++ exception handling.
7150         * linux-fork.c: Use C++ exception handling.
7151         * linespec.c: Use C++ exception handling.
7152         * language.c: Use C++ exception handling.
7153         * jit.c: Use C++ exception handling.
7154         * infrun.c: Use C++ exception handling.
7155         * infcmd.c: Use C++ exception handling.
7156         * infcall.c: Use C++ exception handling.
7157         * inf-loop.c: Use C++ exception handling.
7158         * i386-tdep.c: Use C++ exception handling.
7159         * i386-linux-tdep.c: Use C++ exception handling.
7160         * guile/scm-value.c: Use C++ exception handling.
7161         * guile/scm-type.c: Use C++ exception handling.
7162         * guile/scm-symtab.c: Use C++ exception handling.
7163         * guile/scm-symbol.c: Use C++ exception handling.
7164         * guile/scm-pretty-print.c: Use C++ exception handling.
7165         * guile/scm-ports.c: Use C++ exception handling.
7166         * guile/scm-param.c: Use C++ exception handling.
7167         * guile/scm-math.c: Use C++ exception handling.
7168         * guile/scm-lazy-string.c: Use C++ exception handling.
7169         * guile/scm-frame.c: Use C++ exception handling.
7170         * guile/scm-disasm.c: Use C++ exception handling.
7171         * guile/scm-cmd.c: Use C++ exception handling.
7172         * guile/scm-breakpoint.c: Use C++ exception handling.
7173         * guile/scm-block.c: Use C++ exception handling.
7174         * guile/guile-internal.h: Use C++ exception handling.
7175         * gnu-v3-abi.c: Use C++ exception handling.
7176         * gdbtypes.c: Use C++ exception handling.
7177         * frame.c: Use C++ exception handling.
7178         * frame-unwind.c: Use C++ exception handling.
7179         * fbsd-tdep.c: Use C++ exception handling.
7180         * f-valprint.c: Use C++ exception handling.
7181         * exec.c: Use C++ exception handling.
7182         * event-top.c: Use C++ exception handling.
7183         * event-loop.c: Use C++ exception handling.
7184         * eval.c: Use C++ exception handling.
7185         * dwarf2read.c: Use C++ exception handling.
7186         * dwarf2loc.c: Use C++ exception handling.
7187         * dwarf2-frame.c: Use C++ exception handling.
7188         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7189         * dwarf-index-write.c: Use C++ exception handling.
7190         * dwarf-index-cache.c: Use C++ exception handling.
7191         * dtrace-probe.c: Use C++ exception handling.
7192         * disasm-selftests.c: Use C++ exception handling.
7193         * darwin-nat.c: Use C++ exception handling.
7194         * cp-valprint.c: Use C++ exception handling.
7195         * cp-support.c: Use C++ exception handling.
7196         * cp-abi.c: Use C++ exception handling.
7197         * corelow.c: Use C++ exception handling.
7198         * completer.c: Use C++ exception handling.
7199         * compile/compile-object-run.c: Use C++ exception handling.
7200         * compile/compile-object-load.c: Use C++ exception handling.
7201         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7202         * compile/compile-c-symbols.c: Use C++ exception handling.
7203         * common/selftest.c: Use C++ exception handling.
7204         * common/new-op.c: Use C++ exception handling.
7205         * cli/cli-script.c: Use C++ exception handling.
7206         * cli/cli-interp.c: Use C++ exception handling.
7207         * cli/cli-cmds.c: Use C++ exception handling.
7208         * c-varobj.c: Use C++ exception handling.
7209         * btrace.c: Use C++ exception handling.
7210         * breakpoint.c: Use C++ exception handling.
7211         * break-catch-throw.c: Use C++ exception handling.
7212         * arch-utils.c: Use C++ exception handling.
7213         * amd64-tdep.c: Use C++ exception handling.
7214         * ada-valprint.c: Use C++ exception handling.
7215         * ada-typeprint.c: Use C++ exception handling.
7216         * ada-lang.c: Use C++ exception handling.
7217         * aarch64-tdep.c: Use C++ exception handling.
7218
7219 2019-04-08  Tom Tromey  <tom@tromey.com>
7220
7221         * xml-support.c (gdb_xml_parser::parse): Update.
7222         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7223         * value.c (show_convenience): Update.
7224         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7225         (test_parse_flags_qcs): Update.
7226         * thread.c (thr_try_catch_cmd): Update.
7227         * target.c (target_translate_tls_address): Update.
7228         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7229         (info_frame_command_core, frame_apply_command_count): Update.
7230         * rust-exp.y (rust_lex_exception_test): Update.
7231         * riscv-tdep.c (riscv_print_one_register_info): Update.
7232         * remote.c (remote_target::enable_btrace): Update.
7233         * record-btrace.c (record_btrace_enable_warn): Update.
7234         * python/py-utils.c (gdbpy_convert_exception): Update.
7235         * printcmd.c (do_one_display, print_variable_and_value): Update.
7236         * mi/mi-main.c (mi_print_exception): Update.
7237         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7238         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7239         * linux-nat.c (linux_nat_target::attach): Update.
7240         * linux-fork.c (class scoped_switch_fork_info): Update.
7241         * infrun.c (displaced_step_prepare): Update.
7242         * infcall.c (call_function_by_hand_dummy): Update.
7243         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7244         * gnu-v3-abi.c (print_one_vtable): Update.
7245         * frame.c (get_prev_frame_always): Update.
7246         * f-valprint.c (info_common_command_for_block): Update.
7247         * exec.c (try_open_exec_file): Update.
7248         * exceptions.c (print_exception, exception_print)
7249         (exception_fprintf, exception_print_same): Update.
7250         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7251         * dwarf-index-cache.c (index_cache::store)
7252         (index_cache::lookup_gdb_index): Update.
7253         * darwin-nat.c (maybe_cache_shell): Update.
7254         * cp-valprint.c (cp_print_value_fields): Update.
7255         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7256         (gcc_cplus_symbol_address): Update.
7257         * compile/compile-c-symbols.c (gcc_convert_symbol)
7258         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7259         * common/selftest.c: Update.
7260         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7261         a std::string.
7262         (exception_try_scope_entry, exception_try_scope_exit): Don't
7263         declare.
7264         (struct exception_try_scope): Remove.
7265         (TRY): Don't use exception_try_scope.
7266         (struct gdb_exception): Add constructor, operator=.
7267         <what>: New method.
7268         (struct gdb_exception_RETURN_MASK_ALL)
7269         (struct gdb_exception_RETURN_MASK_ERROR)
7270         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7271         (struct gdb_quit_bad_alloc): Update.
7272         * common/common-exceptions.c (exception_none): Change
7273         initializer.
7274         (struct catcher) <state, exception>: Initialize inline.
7275         <prev>: Remove member.
7276         (current_catcher): Remove.
7277         (catchers): New global.
7278         (exceptions_state_mc_init): Simplify.
7279         (catcher_pop): Remove.
7280         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7281         (try_scope_depth, exception_try_scope_entry)
7282         (exception_try_scope_exit): Remove.
7283         (throw_exception_sjlj): Update.
7284         (exception_messages, exception_messages_size): Remove.
7285         (throw_it): Simplify.
7286         (gdb_exception_sliced_copy): Remove.
7287         (throw_exception_cxx): Update.
7288         * cli/cli-script.c (script_from_file): Update.
7289         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7290         Update.
7291         * ada-valprint.c (ada_val_print): Update.
7292         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7293         (create_excep_cond_exprs): Update.
7294
7295 2019-04-08  Tom Tromey  <tom@tromey.com>
7296
7297         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7298         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7299         (TRY, CATCH, END_CATCH): Remove some definitions.
7300         * common/common-exceptions.c: Don't use GDB_XCPT.
7301         (catcher_list_size): Remove.
7302         (throw_exception, throw_it): Simplify.
7303
7304 2019-04-05  Tom Tromey  <tom@tromey.com>
7305
7306         Revert the header-sorting patch.
7307         * ft32-tdep.c: Revert.
7308         * frv-tdep.c: Revert.
7309         * frv-linux-tdep.c: Revert.
7310         * frame.c: Revert.
7311         * frame-unwind.c: Revert.
7312         * frame-base.c: Revert.
7313         * fork-child.c: Revert.
7314         * findvar.c: Revert.
7315         * findcmd.c: Revert.
7316         * filesystem.c: Revert.
7317         * filename-seen-cache.h: Revert.
7318         * filename-seen-cache.c: Revert.
7319         * fbsd-tdep.c: Revert.
7320         * fbsd-nat.h: Revert.
7321         * fbsd-nat.c: Revert.
7322         * f-valprint.c: Revert.
7323         * f-typeprint.c: Revert.
7324         * f-lang.c: Revert.
7325         * extension.h: Revert.
7326         * extension.c: Revert.
7327         * extension-priv.h: Revert.
7328         * expprint.c: Revert.
7329         * exec.h: Revert.
7330         * exec.c: Revert.
7331         * exceptions.c: Revert.
7332         * event-top.c: Revert.
7333         * event-loop.c: Revert.
7334         * eval.c: Revert.
7335         * elfread.c: Revert.
7336         * dwarf2read.h: Revert.
7337         * dwarf2read.c: Revert.
7338         * dwarf2loc.c: Revert.
7339         * dwarf2expr.h: Revert.
7340         * dwarf2expr.c: Revert.
7341         * dwarf2-frame.c: Revert.
7342         * dwarf2-frame-tailcall.c: Revert.
7343         * dwarf-index-write.h: Revert.
7344         * dwarf-index-write.c: Revert.
7345         * dwarf-index-common.c: Revert.
7346         * dwarf-index-cache.h: Revert.
7347         * dwarf-index-cache.c: Revert.
7348         * dummy-frame.c: Revert.
7349         * dtrace-probe.c: Revert.
7350         * disasm.h: Revert.
7351         * disasm.c: Revert.
7352         * disasm-selftests.c: Revert.
7353         * dictionary.c: Revert.
7354         * dicos-tdep.c: Revert.
7355         * demangle.c: Revert.
7356         * dcache.h: Revert.
7357         * dcache.c: Revert.
7358         * darwin-nat.h: Revert.
7359         * darwin-nat.c: Revert.
7360         * darwin-nat-info.c: Revert.
7361         * d-valprint.c: Revert.
7362         * d-namespace.c: Revert.
7363         * d-lang.c: Revert.
7364         * ctf.c: Revert.
7365         * csky-tdep.c: Revert.
7366         * csky-linux-tdep.c: Revert.
7367         * cris-tdep.c: Revert.
7368         * cris-linux-tdep.c: Revert.
7369         * cp-valprint.c: Revert.
7370         * cp-support.c: Revert.
7371         * cp-namespace.c: Revert.
7372         * cp-abi.c: Revert.
7373         * corelow.c: Revert.
7374         * corefile.c: Revert.
7375         * continuations.c: Revert.
7376         * completer.h: Revert.
7377         * completer.c: Revert.
7378         * complaints.c: Revert.
7379         * coffread.c: Revert.
7380         * coff-pe-read.c: Revert.
7381         * cli-out.h: Revert.
7382         * cli-out.c: Revert.
7383         * charset.c: Revert.
7384         * c-varobj.c: Revert.
7385         * c-valprint.c: Revert.
7386         * c-typeprint.c: Revert.
7387         * c-lang.c: Revert.
7388         * buildsym.c: Revert.
7389         * buildsym-legacy.c: Revert.
7390         * build-id.h: Revert.
7391         * build-id.c: Revert.
7392         * btrace.c: Revert.
7393         * bsd-uthread.c: Revert.
7394         * breakpoint.h: Revert.
7395         * breakpoint.c: Revert.
7396         * break-catch-throw.c: Revert.
7397         * break-catch-syscall.c: Revert.
7398         * break-catch-sig.c: Revert.
7399         * blockframe.c: Revert.
7400         * block.c: Revert.
7401         * bfin-tdep.c: Revert.
7402         * bfin-linux-tdep.c: Revert.
7403         * bfd-target.c: Revert.
7404         * bcache.c: Revert.
7405         * ax-general.c: Revert.
7406         * ax-gdb.h: Revert.
7407         * ax-gdb.c: Revert.
7408         * avr-tdep.c: Revert.
7409         * auxv.c: Revert.
7410         * auto-load.c: Revert.
7411         * arm-wince-tdep.c: Revert.
7412         * arm-tdep.c: Revert.
7413         * arm-symbian-tdep.c: Revert.
7414         * arm-pikeos-tdep.c: Revert.
7415         * arm-obsd-tdep.c: Revert.
7416         * arm-nbsd-tdep.c: Revert.
7417         * arm-nbsd-nat.c: Revert.
7418         * arm-linux-tdep.c: Revert.
7419         * arm-linux-nat.c: Revert.
7420         * arm-fbsd-tdep.c: Revert.
7421         * arm-fbsd-nat.c: Revert.
7422         * arm-bsd-tdep.c: Revert.
7423         * arch-utils.c: Revert.
7424         * arc-tdep.c: Revert.
7425         * arc-newlib-tdep.c: Revert.
7426         * annotate.h: Revert.
7427         * annotate.c: Revert.
7428         * amd64-windows-tdep.c: Revert.
7429         * amd64-windows-nat.c: Revert.
7430         * amd64-tdep.c: Revert.
7431         * amd64-sol2-tdep.c: Revert.
7432         * amd64-obsd-tdep.c: Revert.
7433         * amd64-obsd-nat.c: Revert.
7434         * amd64-nbsd-tdep.c: Revert.
7435         * amd64-nbsd-nat.c: Revert.
7436         * amd64-nat.c: Revert.
7437         * amd64-linux-tdep.c: Revert.
7438         * amd64-linux-nat.c: Revert.
7439         * amd64-fbsd-tdep.c: Revert.
7440         * amd64-fbsd-nat.c: Revert.
7441         * amd64-dicos-tdep.c: Revert.
7442         * amd64-darwin-tdep.c: Revert.
7443         * amd64-bsd-nat.c: Revert.
7444         * alpha-tdep.c: Revert.
7445         * alpha-obsd-tdep.c: Revert.
7446         * alpha-nbsd-tdep.c: Revert.
7447         * alpha-mdebug-tdep.c: Revert.
7448         * alpha-linux-tdep.c: Revert.
7449         * alpha-linux-nat.c: Revert.
7450         * alpha-bsd-tdep.c: Revert.
7451         * alpha-bsd-nat.c: Revert.
7452         * aix-thread.c: Revert.
7453         * agent.c: Revert.
7454         * addrmap.c: Revert.
7455         * ada-varobj.c: Revert.
7456         * ada-valprint.c: Revert.
7457         * ada-typeprint.c: Revert.
7458         * ada-tasks.c: Revert.
7459         * ada-lang.c: Revert.
7460         * aarch64-tdep.c: Revert.
7461         * aarch64-ravenscar-thread.c: Revert.
7462         * aarch64-newlib-tdep.c: Revert.
7463         * aarch64-linux-tdep.c: Revert.
7464         * aarch64-linux-nat.c: Revert.
7465         * aarch64-fbsd-tdep.c: Revert.
7466         * aarch64-fbsd-nat.c: Revert.
7467         * aarch32-linux-nat.c: Revert.
7468
7469 2019-04-05  Tom Tromey  <tom@tromey.com>
7470
7471         * ft32-tdep.c: Sort headers.
7472         * frv-tdep.c: Sort headers.
7473         * frv-linux-tdep.c: Sort headers.
7474         * frame.c: Sort headers.
7475         * frame-unwind.c: Sort headers.
7476         * frame-base.c: Sort headers.
7477         * fork-child.c: Sort headers.
7478         * findvar.c: Sort headers.
7479         * findcmd.c: Sort headers.
7480         * filesystem.c: Sort headers.
7481         * filename-seen-cache.h: Sort headers.
7482         * filename-seen-cache.c: Sort headers.
7483         * fbsd-tdep.c: Sort headers.
7484         * fbsd-nat.h: Sort headers.
7485         * fbsd-nat.c: Sort headers.
7486         * f-valprint.c: Sort headers.
7487         * f-typeprint.c: Sort headers.
7488         * f-lang.c: Sort headers.
7489         * extension.h: Sort headers.
7490         * extension.c: Sort headers.
7491         * extension-priv.h: Sort headers.
7492         * expprint.c: Sort headers.
7493         * exec.h: Sort headers.
7494         * exec.c: Sort headers.
7495         * exceptions.c: Sort headers.
7496         * event-top.c: Sort headers.
7497         * event-loop.c: Sort headers.
7498         * eval.c: Sort headers.
7499         * elfread.c: Sort headers.
7500         * dwarf2read.h: Sort headers.
7501         * dwarf2read.c: Sort headers.
7502         * dwarf2loc.c: Sort headers.
7503         * dwarf2expr.h: Sort headers.
7504         * dwarf2expr.c: Sort headers.
7505         * dwarf2-frame.c: Sort headers.
7506         * dwarf2-frame-tailcall.c: Sort headers.
7507         * dwarf-index-write.h: Sort headers.
7508         * dwarf-index-write.c: Sort headers.
7509         * dwarf-index-common.c: Sort headers.
7510         * dwarf-index-cache.h: Sort headers.
7511         * dwarf-index-cache.c: Sort headers.
7512         * dummy-frame.c: Sort headers.
7513         * dtrace-probe.c: Sort headers.
7514         * disasm.h: Sort headers.
7515         * disasm.c: Sort headers.
7516         * disasm-selftests.c: Sort headers.
7517         * dictionary.c: Sort headers.
7518         * dicos-tdep.c: Sort headers.
7519         * demangle.c: Sort headers.
7520         * dcache.h: Sort headers.
7521         * dcache.c: Sort headers.
7522         * darwin-nat.h: Sort headers.
7523         * darwin-nat.c: Sort headers.
7524         * darwin-nat-info.c: Sort headers.
7525         * d-valprint.c: Sort headers.
7526         * d-namespace.c: Sort headers.
7527         * d-lang.c: Sort headers.
7528         * ctf.c: Sort headers.
7529         * csky-tdep.c: Sort headers.
7530         * csky-linux-tdep.c: Sort headers.
7531         * cris-tdep.c: Sort headers.
7532         * cris-linux-tdep.c: Sort headers.
7533         * cp-valprint.c: Sort headers.
7534         * cp-support.c: Sort headers.
7535         * cp-namespace.c: Sort headers.
7536         * cp-abi.c: Sort headers.
7537         * corelow.c: Sort headers.
7538         * corefile.c: Sort headers.
7539         * continuations.c: Sort headers.
7540         * completer.h: Sort headers.
7541         * completer.c: Sort headers.
7542         * complaints.c: Sort headers.
7543         * coffread.c: Sort headers.
7544         * coff-pe-read.c: Sort headers.
7545         * cli-out.h: Sort headers.
7546         * cli-out.c: Sort headers.
7547         * charset.c: Sort headers.
7548         * c-varobj.c: Sort headers.
7549         * c-valprint.c: Sort headers.
7550         * c-typeprint.c: Sort headers.
7551         * c-lang.c: Sort headers.
7552         * buildsym.c: Sort headers.
7553         * buildsym-legacy.c: Sort headers.
7554         * build-id.h: Sort headers.
7555         * build-id.c: Sort headers.
7556         * btrace.c: Sort headers.
7557         * bsd-uthread.c: Sort headers.
7558         * breakpoint.h: Sort headers.
7559         * breakpoint.c: Sort headers.
7560         * break-catch-throw.c: Sort headers.
7561         * break-catch-syscall.c: Sort headers.
7562         * break-catch-sig.c: Sort headers.
7563         * blockframe.c: Sort headers.
7564         * block.c: Sort headers.
7565         * bfin-tdep.c: Sort headers.
7566         * bfin-linux-tdep.c: Sort headers.
7567         * bfd-target.c: Sort headers.
7568         * bcache.c: Sort headers.
7569         * ax-general.c: Sort headers.
7570         * ax-gdb.h: Sort headers.
7571         * ax-gdb.c: Sort headers.
7572         * avr-tdep.c: Sort headers.
7573         * auxv.c: Sort headers.
7574         * auto-load.c: Sort headers.
7575         * arm-wince-tdep.c: Sort headers.
7576         * arm-tdep.c: Sort headers.
7577         * arm-symbian-tdep.c: Sort headers.
7578         * arm-pikeos-tdep.c: Sort headers.
7579         * arm-obsd-tdep.c: Sort headers.
7580         * arm-nbsd-tdep.c: Sort headers.
7581         * arm-nbsd-nat.c: Sort headers.
7582         * arm-linux-tdep.c: Sort headers.
7583         * arm-linux-nat.c: Sort headers.
7584         * arm-fbsd-tdep.c: Sort headers.
7585         * arm-fbsd-nat.c: Sort headers.
7586         * arm-bsd-tdep.c: Sort headers.
7587         * arch-utils.c: Sort headers.
7588         * arc-tdep.c: Sort headers.
7589         * arc-newlib-tdep.c: Sort headers.
7590         * annotate.h: Sort headers.
7591         * annotate.c: Sort headers.
7592         * amd64-windows-tdep.c: Sort headers.
7593         * amd64-windows-nat.c: Sort headers.
7594         * amd64-tdep.c: Sort headers.
7595         * amd64-sol2-tdep.c: Sort headers.
7596         * amd64-obsd-tdep.c: Sort headers.
7597         * amd64-obsd-nat.c: Sort headers.
7598         * amd64-nbsd-tdep.c: Sort headers.
7599         * amd64-nbsd-nat.c: Sort headers.
7600         * amd64-nat.c: Sort headers.
7601         * amd64-linux-tdep.c: Sort headers.
7602         * amd64-linux-nat.c: Sort headers.
7603         * amd64-fbsd-tdep.c: Sort headers.
7604         * amd64-fbsd-nat.c: Sort headers.
7605         * amd64-dicos-tdep.c: Sort headers.
7606         * amd64-darwin-tdep.c: Sort headers.
7607         * amd64-bsd-nat.c: Sort headers.
7608         * alpha-tdep.c: Sort headers.
7609         * alpha-obsd-tdep.c: Sort headers.
7610         * alpha-nbsd-tdep.c: Sort headers.
7611         * alpha-mdebug-tdep.c: Sort headers.
7612         * alpha-linux-tdep.c: Sort headers.
7613         * alpha-linux-nat.c: Sort headers.
7614         * alpha-bsd-tdep.c: Sort headers.
7615         * alpha-bsd-nat.c: Sort headers.
7616         * aix-thread.c: Sort headers.
7617         * agent.c: Sort headers.
7618         * addrmap.c: Sort headers.
7619         * ada-varobj.c: Sort headers.
7620         * ada-valprint.c: Sort headers.
7621         * ada-typeprint.c: Sort headers.
7622         * ada-tasks.c: Sort headers.
7623         * ada-lang.c: Sort headers.
7624         * aarch64-tdep.c: Sort headers.
7625         * aarch64-ravenscar-thread.c: Sort headers.
7626         * aarch64-newlib-tdep.c: Sort headers.
7627         * aarch64-linux-tdep.c: Sort headers.
7628         * aarch64-linux-nat.c: Sort headers.
7629         * aarch64-fbsd-tdep.c: Sort headers.
7630         * aarch64-fbsd-nat.c: Sort headers.
7631         * aarch32-linux-nat.c: Sort headers.
7632
7633 2019-04-04  Tom Tromey  <tom@tromey.com>
7634
7635         * varobj.c (varobj_create): Update.
7636         * rust-exp.y (struct rust_parser) <update_innermost_block,
7637         lookup_symbol>: New methods.
7638         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7639         Rename.
7640         (rust_parser::rust_lookup_type)
7641         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7642         * printcmd.c (display_command, do_one_display): Update.
7643         * parser-defs.h (struct parser_state) <parser_state>: Add
7644         "tracker" parameter.
7645         (block_tracker): New member.
7646         (class innermost_block_tracker) <innermost_block_tracker>: Add
7647         "types" parameter.
7648         <reset>: Remove method.
7649         (innermost_block): Don't declare.
7650         (null_post_parser): Update.
7651         * parse.c (innermost_block): Remove global.
7652         (write_dollar_variable): Update.
7653         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7654         Remove "tracker_types" parameter.
7655         (parse_expression): Add "tracker" parameter.
7656         (parse_expression_for_completion): Update.
7657         (null_post_parser): Add "tracker" parameter.
7658         * p-exp.y: Update rules.
7659         * m2-exp.y: Update rules.
7660         * language.h (struct language_defn) <la_post_parser>: Add
7661         "tracker" parameter.
7662         * go-exp.y: Update rules.
7663         * f-exp.y: Update rules.
7664         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7665         parameter.
7666         * d-exp.y: Update rules.
7667         * c-exp.y: Update rules.
7668         * breakpoint.c (set_breakpoint_condition): Create an
7669         innermost_block_tracker.
7670         (watch_command_1): Likewise.
7671         * ada-lang.c (resolve): Add "tracker" parameter.
7672         (resolve_subexp): Likewise.
7673         * ada-exp.y (write_var_from_sym): Update.
7674
7675 2019-04-04  Tom Tromey  <tom@tromey.com>
7676
7677         * type-stack.h: New file.
7678         * type-stack.c: New file.
7679         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7680         type-stack.h.
7681         (insert_into_type_stack, insert_type, push_type, push_type_int)
7682         (insert_type_address_space, pop_type, pop_type_int)
7683         (pop_typelist, pop_type_stack, append_type_stack)
7684         (push_type_stack, get_type_stack, push_typelist)
7685         (follow_type_instance_flags, follow_types): Don't declare.
7686         * parse.c (type_stack): Remove global.
7687         (parse_exp_in_context): Update.
7688         (insert_into_type_stack, insert_type, push_type, push_type_int)
7689         (insert_type_address_space, pop_type, pop_type_int)
7690         (pop_typelist, pop_type_stack, append_type_stack)
7691         (push_type_stack, get_type_stack, push_typelist)
7692         (follow_type_instance_flags, follow_types): Remove (moved to
7693         type-stack.c).
7694         * f-exp.y (type_stack): New global.
7695         Update rules.
7696         (push_kind_type, f_parse): Update.
7697         * d-exp.y (type_stack): New global.
7698         Update rules.
7699         (d_parse): Update.
7700         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7701         Update rules.
7702         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7703         (HFILES_NO_SRCDIR): Add type-stack.h.
7704
7705 2019-04-04  Tom Tromey  <tom@tromey.com>
7706
7707         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7708         (rust_parser::convert_ast_to_expression, rust_parse)
7709         (rust_lex_test_completion, rust_lex_tests): Update.
7710         * parser-defs.h (struct expr_completion_state): New.
7711         (struct parser_state) <parser_state>: Add completion parameter.
7712         <mark_struct_expression, mark_completion_tag>: New methods.
7713         <parse_completion, m_completion_state>: New members.
7714         (prefixify_expression, null_post_parser): Update.
7715         (mark_struct_expression, mark_completion_tag): Don't declare.
7716         * parse.c (parse_completion, expout_last_struct)
7717         (expout_tag_completion_type, expout_completion_name): Remove
7718         globals.
7719         (parser_state::mark_struct_expression)
7720         (parser_state::mark_completion_tag): Now methods.
7721         (prefixify_expression): Add last_struct parameter.
7722         (prefixify_subexp): Likewise.
7723         (parse_exp_1): Update.
7724         (parse_exp_in_context): Add cstate parameter.  Update.
7725         (parse_expression_for_completion): Create an
7726         expr_completion_state.
7727         (null_post_parser): Add "completion" parameter.
7728         * p-exp.y: Update rules.
7729         (yylex): Update.
7730         * language.h (struct language_defn) <la_post_parser>: Add
7731         "completing" parameter.
7732         * go-exp.y: Update rules.
7733         (lex_one_token): Update.
7734         * expression.h (parse_completion): Don't declare.
7735         * d-exp.y: Update rules.
7736         (lex_one_token): Update rules.
7737         * c-exp.y: Update rules.
7738         (lex_one_token): Update.
7739         * ada-lang.c (resolve): Add "parse_completion" parameter.
7740         (resolve_subexp): Likewise.
7741         (ada_resolve_function): Likewise.
7742
7743 2019-04-04  Tom Tromey  <tom@tromey.com>
7744
7745         * parser-defs.h (struct parser_state) <start_arglist,
7746         end_arglist>: New methods.
7747         <arglist_len, m_funcall_chain>: New members.
7748         (arglist_len, start_arglist, end_arglist): Don't declare.
7749         * parse.c (arglist_len, funcall_chain): Remove global.
7750         (start_arglist, end_arglist): Remove functions.
7751         (parse_exp_in_context): Update.
7752         * p-exp.y: Update rules.
7753         * m2-exp.y: Update rules.
7754         * go-exp.y: Update rules.
7755         * f-exp.y: Update rules.
7756         * d-exp.y: Update rules.
7757         * c-exp.y: Update rules.
7758
7759 2019-04-04  Tom Tromey  <tom@tromey.com>
7760
7761         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7762         lex_operator, push_back>: New methods.
7763         Update all rules.
7764         (rust_parser::lex_hex, lex_escape): Rename and update.
7765         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7766         (rust_parser::lex_operator): Rename and update.
7767         (rust_parser::lex_number, rustyylex, rustyyerror)
7768         (rust_lex_test_init, rust_lex_test_sequence)
7769         (rust_lex_test_push_back, rust_lex_tests): Update.
7770         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7771         parameter.
7772         <lexptr, prev_lexptr>: New members.
7773         (lexptr, prev_lexptr): Don't declare.
7774         * parse.c (lexptr, prev_lexptr): Remove globals.
7775         (parse_exp_in_context): Update.
7776         * p-exp.y (yylex, yyerror): Update.
7777         * m2-exp.y (parse_number, yylex, yyerror): Update.
7778         * go-exp.y (lex_one_token, yyerror): Update.
7779         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7780         * d-exp.y (lex_one_token, yyerror): Update.
7781         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7782         (lex_one_token, yyerror): Update.
7783         * ada-lex.l (YY_INPUT): Update.
7784         (rewind_to_char): Update.
7785         * ada-exp.y (yyerror): Update.
7786
7787 2019-04-04  Tom Tromey  <tom@tromey.com>
7788
7789         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7790         * parser-defs.h (struct parser_state) <parser_state>: Add new
7791         parameter.
7792         <comma_terminates>: New member.
7793         (comma_terminates): Don't declare global.
7794         * parse.c (comma_terminates): Remove global.
7795         (parse_exp_in_context): Update.
7796         * p-exp.y (yylex): Update.
7797         * m2-exp.y (yylex): Update.
7798         * go-exp.y (lex_one_token): Update.
7799         * f-exp.y (yylex): Update.
7800         * d-exp.y (lex_one_token): Update.
7801         * c-exp.y (lex_one_token): Update.
7802         * ada-lex.l: Update.
7803
7804 2019-04-04  Tom Tromey  <tom@tromey.com>
7805
7806         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7807         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7808         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7809         * parser-defs.h (paren_depth): Don't declare.
7810         * parse.c (paren_depth): Remove global.
7811         (parse_exp_in_context): Update.
7812         * p-exp.y (paren_depth): New global.
7813         (pascal_parse): Initialize it.
7814         * m2-exp.y (paren_depth): New global.
7815         (m2_parse): Initialize it.
7816         * go-exp.y (paren_depth): New global.
7817         (go_parse): Initialize it.
7818         * f-exp.y (paren_depth): New global.
7819         (f_parse): Initialize it.
7820         * d-exp.y (paren_depth): New global.
7821         (d_parse): Initialize it.
7822         * c-exp.y (paren_depth): New global.
7823         (c_parse): Initialize it.
7824         * ada-lex.l (paren_depth): New global.
7825         (lexer_init): Initialize it.
7826
7827 2019-04-04  Tom Tromey  <tom@tromey.com>
7828
7829         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7830         (rust_parser::convert_ast_to_type)
7831         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7832         * parser-defs.h (struct parser_state) <parser_state>: Add
7833         parameters.  Initialize new members.
7834         <expression_context_block, expression_context_pc>: New members.
7835         * parse.c (expression_context_block, expression_context_pc):
7836         Remove globals.
7837         (parse_exp_in_context): Update.
7838         * p-exp.y: Update all rules.
7839         (yylex): Update.
7840         * m2-exp.y: Update all rules.
7841         (yylex): Update.
7842         * go-exp.y (yylex): Update.
7843         * f-exp.y (yylex): Update.
7844         * d-exp.y: Update all rules.
7845         (yylex): Update.
7846         * c-exp.y: Update all rules.
7847         (lex_one_token, classify_name, yylex, c_parse): Update.
7848         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7849
7850 2019-04-04  Tom Tromey  <tom@tromey.com>
7851
7852         * gdbarch.h, gdbarch.c: Rebuild.
7853         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7854         * stap-probe.h:
7855         (struct stap_parse_info): Replace "parser_state" with
7856         "expr_builder".
7857         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7858         (parser_state): New class.
7859         * parse.c (expr_builder): Rename.
7860         (expr_builder::release): Rename.
7861         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7862         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7863         (write_exp_elt_longcst, write_exp_elt_floatcst)
7864         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7865         (write_exp_string_vector, write_exp_bitstring)
7866         (write_exp_msymbol, mark_struct_expression)
7867         (write_dollar_variable)
7868         (insert_type_address_space, increase_expout_size): Replace
7869         "parser_state" with "expr_builder".
7870         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7871         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7872         "parser_state" with "expr_builder".
7873
7874 2019-04-04  Tom Tromey  <tom@tromey.com>
7875
7876         * rust-exp.y: Replace "parse_language" with method call.
7877         * p-exp.y:
7878         (yylex): Replace "parse_language" with method call.
7879         * m2-exp.y:
7880         (yylex): Replace "parse_language" with method call.
7881         * go-exp.y (classify_name): Replace "parse_language" with method
7882         call.
7883         * f-exp.y (yylex): Replace "parse_language" with method call.
7884         * d-exp.y (lex_one_token): Replace "parse_language" with method
7885         call.
7886         * c-exp.y:
7887         (lex_one_token, classify_name, yylex): Replace "parse_language"
7888         with method call.
7889         * ada-exp.y (find_primitive_type, type_char)
7890         (type_system_address): Replace "parse_language" with method call.
7891
7892 2019-04-04  Tom Tromey  <tom@tromey.com>
7893
7894         * rust-exp.y: Replace "parse_gdbarch" with method call.
7895         * parse.c (write_dollar_variable, insert_type_address_space):
7896         Replace "parse_gdbarch" with method call.
7897         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7898         call.
7899         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7900         call.
7901         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7902         "parse_gdbarch" with method call.
7903         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7904         with method call.
7905         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7906         "parse_gdbarch" with method call.
7907         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7908         "parse_gdbarch" with method call.
7909         * c-exp.y (parse_type, parse_number, classify_name): Replace
7910         "parse_gdbarch" with method call.
7911         * ada-lex.l: Replace "parse_gdbarch" with method call.
7912         * ada-exp.y (parse_type, find_primitive_type, type_char)
7913         (type_system_address): Replace "parse_gdbarch" with method call.
7914
7915 2019-04-04  Tom Tromey  <tom@tromey.com>
7916
7917         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7918         * stap-probe.c (stap_parse_argument): Update.
7919         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7920         initial_size parameter.
7921         * rust-exp.y (rust_lex_tests): Update.
7922         * parse.c (parser_state): Update.
7923         (parse_exp_in_context): Update.
7924         * parser-defs.h (struct parser_state) <parser_state>: Remove
7925         "initial_size" parameter.
7926
7927 2019-04-04  Tom Tromey  <tom@tromey.com>
7928
7929         * parser-defs.h (increase_expout_size): Don't declare.
7930         * parse.c (increase_expout_size): Now static.
7931
7932 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7933
7934         * gnu-nat.c (gnu_nat_target::wait): Fix
7935         target_waitstatus_to_string call.
7936
7937 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7938
7939         * eval.c (evaluate_subexp_standard): Handle internal functions
7940         during Fortran function call handling.
7941
7942 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7943
7944         * NEWS: Mention new internal functions.
7945         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7946         (read_base_type): Use dwarf2_init_complex_target_type.
7947         * value.c (creal_internal_fn): New function.
7948         (cimag_internal_fn): New function.
7949         (_initialize_values): Register new internal functions.
7950
7951 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7952
7953         * infrun.c (stop_all_threads): If debug_infrun, always
7954         trace the wait status after wait_one, using
7955         target_waitstatus_to_string and target_pid_to_str.
7956         (handle_inferior_event): Replace various trace of
7957         wait status kind by a single trace.
7958         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7959         wait status kind image by target_waitstatus_to_string.
7960         * target/waitstatus.c (target_waitstatus_to_string): Fix
7961         obsolete comment.
7962
7963 2019-04-01  Tom Tromey  <tromey@adacore.com>
7964
7965         PR symtab/23331:
7966         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7967
7968 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7969             Pedro Alves  <palves@redhat.com>
7970
7971         * top.c (quit_force): Call 'finalize_values'.
7972         * value.c (finalize_values): New function.
7973         * value.h (finalize_values): Declare.
7974
7975 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7976
7977         * NEWS: Announce $_gdb_major and $_gdb_minor.
7978
7979         * top.c (init_gdb_version_vars): New function.
7980         (gdb_init): Call init_gdb_version_vars.
7981
7982 2019-03-29  Tom Tromey  <tromey@adacore.com>
7983
7984         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7985         help text.  Remove dead code.
7986
7987 2019-03-29  Keith Seitz  <keiths@redhat.com>
7988
7989         From Siddhesh Poyarekar:
7990         * f-lang.h (f77_get_upperbound): Return LONGEST.
7991         (f77_get_lowerbound): Likewise.
7992         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7993         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7994         print them.
7995         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7996         plongest to format print it.
7997         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7998         (f77_get_upperbound): Likewise.
7999         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8000         LOWER_BOUND to LONGEST.
8001         (f77_create_arrayprint_offset_tbl): Likewise.
8002
8003 2019-03-29  Keith Seitz  <keiths@redhat.com>
8004
8005         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8006         %s/pulongest for TYPE_LENGTH instead of %d in format
8007         strings.
8008         * ada-typerint.c (ada_print_type): Likewise.
8009         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8010         * compile/compile-c-support.c (generate_register_struct): Likewise.
8011         * gdbtypes.c (recursive_dump_type): Likewise.
8012         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8013         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8014         instead of %d in format strings.
8015         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8016         to std::min to ULONGEST.
8017         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8018         instead of %d in format strings.
8019         * tracepoint.c (info_scope_command): Likewise.
8020         * typeprint.c (print_offset_data::update)
8021         (print_offset_data::finish): Likewise.
8022         * xtensa-tdep.c (xtensa_store_return_value)
8023         (xtensa_push_dummy_call): Likewise.
8024
8025 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8026
8027         * windows-nat.c (display_selector): Fixed format specifications
8028         for 64-bit Cygwin.
8029
8030 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8031
8032         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8033
8034 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8035
8036         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8037         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8038         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8039         (nios2_linux_init_abi): Install it.
8040
8041 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8042
8043         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8044
8045 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8046
8047         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8048
8049 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8050             Tom Tromey  <tromey@adacore.com>
8051
8052         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8053
8054 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8055
8056         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8057         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8058         method to compute the bounds of range types. Also print "[evaluated]"
8059         if the bounds' values come from a dynamic evaluation.
8060
8061 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8062
8063         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8064         whitespace when pretty printing is on.
8065
8066 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8067
8068         * ppc-linux-nat.c: Add include.
8069
8070 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8071
8072         * NEWS: Mention AArch64 Pointer Authentication.
8073
8074 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8075
8076         * arm-linux-nat.c: Add include.
8077
8078 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8079
8080         * source-cache.c (source_cache::get_source_lines): Re-read
8081         fullname after calling open_source_file.
8082
8083 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8084
8085         * NEWS: Mention TLS support for FreeBSD.
8086
8087 2019-03-25  Tom Tromey  <tromey@adacore.com>
8088
8089         * minsyms.c (BUNCH_SIZE): Update comment.
8090         (~minimal_symbol_reader): Remove old comment.
8091         (compact_minimal_symbols): Update comment.
8092         (minimal_symbol_reader::install): Remove old comment.  Update
8093         other comments.
8094
8095 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8096
8097         * s390-linux-nat.c: Add include.
8098
8099 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8100
8101         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8102         Call linux_get_hwcap.
8103         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8104         Likewise.
8105         (aarch64_linux_get_hwcap): Remove function.
8106         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8107         declaration.
8108         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8109         linux_get_hwcap.
8110         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8111         * linux-tdep.c (linux_get_hwcap): Add function.
8112         (linux_get_hwcap2): Likewise.
8113         * linux-tdep.h (linux_get_hwcap): Add declaration.
8114         (linux_get_hwcap2): Likewise.
8115         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8116         (ppc_linux_get_hwcap2): Likewise.
8117         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8118         linux_get_hwcap.
8119         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8120         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8121         (ppc_linux_nat_target::read_description): Likewise.
8122         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8123         * s390-linux-nat.c: Likewise.
8124         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8125
8126 2019-03-24  Tom Tromey  <tom@tromey.com>
8127
8128         * ada-lang.c (standard_lookup): Simplify initialization.
8129         (ada_lookup_symbol_nonlocal): Simplify return.
8130         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8131         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8132         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8133         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8134         initialization.
8135         * solib.c (solib_global_lookup): Simplify.
8136         * symtab.c (null_block_symbol): Remove.
8137         (symbol_cache_lookup): Simplify returns.
8138         (lookup_language_this): Simplify returns.
8139         (lookup_symbol_aux): Simplify return.
8140         (lookup_local_symbol): Simplify returns.
8141         (lookup_global_symbol_from_objfile): Simplify return.
8142         (lookup_symbol_in_objfile_symtabs)
8143         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8144         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8145         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8146         * cp-namespace.c (cp_lookup_bare_symbol)
8147         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8148         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8149         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8150         (cp_lookup_symbol_via_imports): Simplify initialization.
8151         (find_symbol_in_baseclass): Likewise.
8152         * symtab.h (null_block_symbol): Remove.
8153         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8154         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8155         (d_lookup_symbol_module): Likewise.
8156         (find_symbol_in_baseclass): Simplify initialization.
8157
8158 2019-03-24  Tom Tromey  <tom@tromey.com>
8159
8160         * expression.h: Don't include symtab.h.
8161         (struct block): Forward declare.
8162
8163 2019-03-24  Tom Tromey  <tom@tromey.com>
8164
8165         * c-exp.y (typebase): Remove casts.
8166         * gdbtypes.c (lookup_unsigned_typename, )
8167         (lookup_signed_typename): Remove cast.
8168         * eval.c (parse_to_comma_and_eval): Remove cast.
8169         * parse.c (write_dollar_variable): Remove cast.
8170         * block.h (struct block) <superblock>: Now const.
8171         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8172         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8173         (map_block): Make "block" const.
8174         * symfile.h (struct quick_symbol_functions)
8175         <map_matching_symbols>: Constify block argument to "callback".
8176         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8177         const.
8178         (find_pc_sect_compunit_symtab): Make "b" const.
8179         (find_symbol_at_address): Likewise.
8180         (search_symbols): Likewise.
8181         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8182         (dw2_debug_names_lookup_symbol): Likewise.
8183         (dw2_map_matching_symbols): Update.
8184         * p-valprint.c (pascal_val_print): Remove "block".
8185         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8186         (aux_add_nonlocal_symbols): Make "block" const.
8187         (resolve_subexp): Remove cast.
8188         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8189         const.
8190         (iterate_over_file_blocks): Likewise.
8191         * f-exp.y (%union) <bval>: Remove.
8192         * coffread.c (patch_opaque_types): Make "b" const.
8193         * spu-tdep.c (spu_catch_start): Make "block" const.
8194         * c-valprint.c (print_unpacked_pointer): Remove "block".
8195         * symmisc.c (dump_symtab_1): Make "b" const.
8196         (block_depth): Make "block" const.
8197         * d-exp.y (%union) <bval>: Remove.
8198         * cp-support.h (cp_lookup_rtti_type): Update.
8199         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8200         * psymtab.c (psym_lookup_symbol): Make "block" const.
8201         (maintenance_check_psymtabs): Make "b" const.
8202         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8203         (enumerate_locals, enumerate_args): Update.
8204         * python/py-symtab.c (stpy_global_block): Make "block" const.
8205         (stpy_static_block): Likewise.
8206         * inline-frame.c (block_starting_point_at): Make "new_block"
8207         const.
8208         * block.c (find_block_in_blockvector): Make return type const.
8209         (blockvector_for_pc_sect): Make "b" const.
8210         (find_block_in_blockvector): Make "b" const.
8211
8212 2019-03-23  Tom Tromey  <tom@tromey.com>
8213
8214         * varobj.c (varobj_create): Update.
8215         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8216         * printcmd.c (display_command, do_one_display): Don't reset
8217         innermost_block.
8218         * parser-defs.h (enum innermost_block_tracker_type): Move to
8219         expression.h.
8220         (innermost_block): Update comment.
8221         * parse.c (parse_exp_1): Add tracker_types parameter.
8222         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8223         tracker_types parameter.  Reset innermost_block.
8224         (parse_exp_in_context): Remove.
8225         (parse_expression_for_completion): Update.
8226         * objfiles.c (~objfile): Don't reset expression_context_block or
8227         innermost_block.
8228         * expression.h (enum innermost_block_tracker_type): Move from
8229         parser-defs.h.
8230         (parse_exp_1): Add tracker_types parameter.
8231         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8232         reset innermost_block.
8233
8234 2019-03-23  Tom Tromey  <tom@tromey.com>
8235
8236         * objfiles.h: Include bcache.h.
8237
8238 2019-03-23  Tom Tromey  <tom@tromey.com>
8239
8240         * linespec.c (get_current_search_block): Use
8241         scoped_restore_current_language.
8242         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8243
8244 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8245             Jiong Wang  <jiong.wang@arm.com>
8246
8247         * aarch64-linux-tdep.c
8248         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8249         section.
8250         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8251
8252 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8253             Jiong Wang  <jiong.wang@arm.com>
8254
8255         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8256         instructions.
8257         (aarch64_analyze_prologue_test): Add PACIASP test.
8258         (aarch64_prologue_prev_register): Unmask PC value.
8259
8260 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8261             Jiong Wang  <jiong.wang@arm.com>
8262
8263         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8264         (aarch64_dwarf2_prev_register): Unmask PC value.
8265         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8266         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8267         DW_CFA_AARCH64_negate_ra_state.
8268         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8269
8270 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8271             Jiong Wang  <jiong.wang@arm.com>
8272
8273         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8274         registers.
8275         (aarch64_pseudo_register_name): Likewise.
8276         (aarch64_pseudo_register_type): Likewise.
8277         (aarch64_pseudo_register_reggroup_p): Likewise.
8278         (aarch64_gdbarch_init): Add pauth registers.
8279         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8280         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8281         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8282         (struct gdbarch_tdep): Add regnum for ra_state.
8283
8284 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8285             Jiong Wang  <jiong.wang@arm.com>
8286
8287         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8288
8289 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8290             Jiong Wang  <jiong.wang@arm.com>
8291
8292         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8293         function.
8294         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8295         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8296         (aarch64_gdbarch_init): Add puth registers.
8297         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8298         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8299         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8300
8301 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8302             Jiong Wang  <jiong.wang@arm.com>
8303
8304         * aarch64-linux-nat.c
8305         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8306         * aarch64-linux-tdep.c
8307         (aarch64_linux_core_read_description): Likewise.
8308         (aarch64_linux_get_hwcap): New function.
8309         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8310         (aarch64_linux_get_hwcap): New declaration.
8311
8312 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8313             Jiong Wang  <jiong.wang@arm.com>
8314
8315         * aarch64-linux-nat.c
8316         (aarch64_linux_nat_target::read_description): Add pauth param.
8317         * aarch64-linux-tdep.c
8318         (aarch64_linux_core_read_description): Likewise.
8319         * aarch64-tdep.c (struct target_desc): Add in pauth.
8320         (aarch64_read_description): Add pauth param.
8321         (aarch64_gdbarch_init): Likewise.
8322         * aarch64-tdep.h (aarch64_read_description): Likewise.
8323         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8324         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8325         * features/Makefile: Add new files.
8326         * features/aarch64-pauth.c: New file.
8327         * features/aarch64-pauth.xml: New file.
8328
8329 2019-03-20  Tom Tromey  <tromey@adacore.com>
8330
8331         * infrun.c (handle_inferior_event): Rename from
8332         handle_inferior_event_1.  Create a scoped_value_mark.
8333         (handle_inferior_event): Remove.
8334
8335 2019-03-19  Tom Tromey  <tromey@adacore.com>
8336
8337         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8338         * infrun.h (print_stop_event): Add "displays" parameter.
8339         * infrun.c (print_stop_event): Add "displays" parameter.
8340
8341 2019-03-19  Pedro Alves  <palves@redhat.com>
8342
8343         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8344         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8345         to -1.  Fix TABs vs spaces.
8346         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8347         * tui/tui-out.h (tui_ui_out) Add intro comments.
8348         <m_line, m_start_of_line>: In-class initialize, and add describing
8349         comment.
8350
8351 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8352
8353         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8354         variable names.
8355         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8356
8357 2019-03-18  Pedro Alves  <palves@redhat.com>
8358             Eli Zaretskii <eliz@gnu.org>
8359
8360         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8361         m_line and m_start_of_line.
8362
8363 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8364
8365         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8366         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8367         it returns a newline.  This fixes a regression in TU mode, whereby
8368         the next line is output on the same screen line as the user input.
8369
8370 2019-03-18  Tom Tromey  <tromey@adacore.com>
8371
8372         * minsyms.c (minimal_symbol_reader::install): Remove call to
8373         obstack_blank.
8374
8375 2019-03-18  Pedro Alves  <palves@redhat.com>
8376
8377         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8378         New globals.
8379         (apply_style): New, factored out from ...
8380         (apply_ansi_escape): ... this.  Handle reverse video mode.
8381         (tui_set_reverse_mode): New function.
8382         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8383         * tui/tui-winsource.c (tui_show_source_line): Use
8384         tui_set_reverse_mode instead of setting A_STANDOUT.
8385         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8386         New setter methods.
8387
8388 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8389
8390         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8391         Handle tabs.
8392
8393 2019-03-18  Tom Tromey  <tromey@adacore.com>
8394
8395         * ada-lang.c (empty_array): Add "high" parameter.
8396         (ada_evaluate_subexp): Update.
8397
8398 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8399
8400         * unittests/string_view-selftests.c: Define
8401         _initialize_string_view_selftests unconditionally.
8402
8403 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8404
8405         PR gdb/24350
8406         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8407
8408 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8409
8410         PR gdb/24351
8411         * windows-nat.c (display_selector): Fix format specifiers.
8412
8413 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8414
8415         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8416         tui_refill_source_window instead of tui_refresh_win, to update the
8417         current execution line.  This fixes redisplay of the current line
8418         when stepping through the code with "next" or "step".
8419
8420 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8421
8422         * source-cache.c (source_cache::get_source_lines): Call
8423         find_source_lines to initialize s->nlines.  This fixes vertical
8424         scrolling of TUI source window when the DOWN arrow is pressed.
8425
8426 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8427
8428         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8429         linux-thread-db.c (_initialize_thread_db): Likewise.
8430
8431 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8432
8433         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8434         wclrtoeol in tui_show_source_line".  This reverts changes made in
8435         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8436
8437 2019-03-15  Tom Tromey  <tom@tromey.com>
8438
8439         * symtab.h (struct minimal_symbol): Derive from
8440         general_symbol_info.
8441         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8442         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8443         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8444         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8445         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8446         (MSYMBOL_SEARCH_NAME): Update.
8447         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8448         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8449         * minsyms.c (minimal_symbol_reader::record_full): Update.
8450
8451 2019-03-15  Tom Tromey  <tom@tromey.com>
8452
8453         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8454
8455 2019-03-15  Tom Tromey  <tom@tromey.com>
8456
8457         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8458         unique_xmalloc_ptr.
8459         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8460         Update.
8461         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8462         (build_minimal_symbol_hash_tables)
8463         (minimal_symbol_reader::install): Update.
8464
8465 2019-03-15  Tom Tromey  <tom@tromey.com>
8466
8467         * symtab.c (create_demangled_names_hash): Update.
8468         (symbol_set_names): Update.
8469         * objfiles.h (struct objfile_per_bfd_storage)
8470         <demangled_names_hash>: Now an htab_up.
8471         * objfiles.c (objfile_per_bfd_storage): Simplify.
8472
8473 2019-03-15  Tom Tromey  <tom@tromey.com>
8474
8475         * objfiles.h (struct objfile_per_bfd_storage): Declare
8476         destructor.
8477         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8478         New.
8479         (get_objfile_bfd_data): Use new.  Don't initialize
8480         language_of_main.
8481         (free_objfile_per_bfd_storage): Remove.
8482         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8483
8484 2019-03-15  Tom Tromey  <tom@tromey.com>
8485
8486         * symfile.c (reread_symbols): Update.
8487         * objfiles.c (objfile::objfile): Update.
8488         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8489         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8490         comment.
8491         (minimal_symbol_reader::install): Update.
8492         (terminate_minimal_symbol_table): Remove.
8493         * jit.c (jit_object_close_impl): Update.
8494
8495 2019-03-15  Tom Tromey  <tom@tromey.com>
8496
8497         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8498         initializations.
8499
8500 2019-03-15  Tom Tromey  <tom@tromey.com>
8501
8502         * objfiles.h (struct objfile_per_bfd_storage)
8503         <demangled_hash_languages>: Now a bitset.
8504         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8505         (lookup_minimal_symbol): Update.
8506
8507 2019-03-15  Tom Tromey  <tom@tromey.com>
8508
8509         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8510         Don't return the symbol.
8511         * coffread.c (record_minimal_symbol): Use record_full.
8512
8513 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8514
8515         The MS-Windows port of ncurses fails to switch to a color pair if
8516         one or both of the colors are the implicit default colors.  This
8517         change records the default colors when TUI is initialized, and
8518         then specifies them explicitly when a color pair uses the default
8519         colors.  This allows color styling in TUI mode on MS-Windows.
8520
8521         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8522         ncurses_norm_attr.
8523         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8524         colors in ncurses_norm_attr.
8525         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8526         "none", replace it with the default color recorded in
8527         ncurses_norm_attr.
8528
8529 2019-03-14  Tom Tromey  <tromey@adacore.com>
8530
8531         * source-cache.h (class source_cache) <get_source_lines>: Return
8532         std::string.
8533         * source-cache.c (source_cache::extract_lines): Handle case where
8534         first_pos==npos.  Return std::string.
8535         (source_cache::get_source_lines): Update.
8536
8537 2019-03-14  Tom Tromey  <tromey@adacore.com>
8538
8539         * NEWS: Add item for "style sources" commands.
8540         * source-cache.c (source_cache::get_source_lines): Check
8541         source_styling.
8542         * cli/cli-style.c (source_styling): New global.
8543         (_initialize_cli_style): Add "style sources" commands.
8544         (show_style_sources): New function.
8545         * cli/cli-style.h (source_styling): Declare.
8546
8547 2019-03-14  Pedro Alves  <palves@redhat.com>
8548             Tom Tromey  <tromey@adacore.com>
8549
8550         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8551         * tui/tui-winsource.c (tui_refill_source_window): New function,
8552         from...
8553         (tui_horizontal_source_scroll): ... here.  Move some logic.
8554         * cli/cli-style.c (set_style_enabled): Notify new observable.
8555         * tui/tui-hooks.c (tui_redisplay_source): New function.
8556         (tui_attach_detach_observers): Attach or detach
8557         tui_redisplay_source.
8558         * observable.h (source_styling_changed): New observable.
8559         * observable.c: Define source_styling_changed observable.
8560
8561 2019-03-13  Tom Tromey  <tromey@adacore.com>
8562
8563         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8564         (i386_gnu_nat_target::store_registers): Update.
8565         * target-debug.h (target_debug_print_std_string): New macro.
8566         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8567         * windows-tdep.c (display_one_tib): Update.
8568         * tui/tui-stack.c (tui_make_status_line): Update.
8569         * top.c (print_inferior_quit_action): Update.
8570         * thread.c (thr_try_catch_cmd): Update.
8571         (add_thread_with_info): Update.
8572         (thread_target_id_str): Update.
8573         (thr_try_catch_cmd): Update.
8574         (thread_command): Update.
8575         (thread_find_command): Update.
8576         * record-btrace.c (record_btrace_target::info_record)
8577         (record_btrace_resume_thread, record_btrace_target::resume)
8578         (record_btrace_cancel_resume, record_btrace_step_thread)
8579         (record_btrace_target::wait, record_btrace_target::wait)
8580         (record_btrace_target::wait, record_btrace_target::stop): Update.
8581         * progspace.c (print_program_space): Update.
8582         * process-stratum-target.c
8583         (process_stratum_target::thread_address_space): Update.
8584         * linux-fork.c (linux_fork_mourn_inferior)
8585         (detach_checkpoint_command, info_checkpoints_command)
8586         (linux_fork_context): Update.
8587         (linux_fork_detach): Update.
8588         (class scoped_switch_fork_info): Update.
8589         (delete_checkpoint_command): Update.
8590         * infrun.c (follow_fork_inferior): Update.
8591         (follow_fork_inferior): Update.
8592         (proceed_after_vfork_done): Update.
8593         (handle_vfork_child_exec_or_exit): Update.
8594         (follow_exec): Update.
8595         (displaced_step_prepare_throw): Update.
8596         (displaced_step_restore): Update.
8597         (start_step_over): Update.
8598         (resume_1): Update.
8599         (clear_proceed_status_thread): Update.
8600         (proceed): Update.
8601         (print_target_wait_results): Update.
8602         (do_target_wait): Update.
8603         (context_switch): Update.
8604         (stop_all_threads): Update.
8605         (restart_threads): Update.
8606         (finish_step_over): Update.
8607         (handle_signal_stop): Update.
8608         (switch_back_to_stepped_thread): Update.
8609         (keep_going_pass_signal): Update.
8610         (print_exited_reason): Update.
8611         (normal_stop): Update.
8612         * inferior.c (inferior_pid_to_str): Change return type.
8613         (print_selected_inferior): Update.
8614         (add_inferior): Update.
8615         (detach_inferior): Update.
8616         * dummy-frame.c (fprint_dummy_frames): Update.
8617         * dcache.c (dcache_info_1): Update.
8618         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8619         (btrace_fetch, btrace_clear): Update.
8620         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8621         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8622         type.
8623         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8624         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8625         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8626         * gdbarch.c, gdbarch.h: Rebuild.
8627         * gdbarch.sh (core_pid_to_str): Change return type.
8628         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8629         return type.
8630         (windows_nat_target::pid_to_str): Change return type.
8631         (windows_delete_thread): Update.
8632         (windows_nat_target::attach): Update.
8633         (windows_nat_target::files_info): Update.
8634         * target-delegates.c: Rebuild.
8635         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8636         return type.
8637         (sol_thread_target::pid_to_str): Change return type.
8638         * remote.c (class remote_target) <pid_to_str>: Change return
8639         type.
8640         (remote_target::pid_to_str): Change return type.
8641         (extended_remote_target::attach, remote_target::remote_stop_ns)
8642         (remote_target::remote_notif_remove_queued_reply)
8643         (remote_target::push_stop_reply, remote_target::disable_btrace):
8644         Update.
8645         (extended_remote_target::attach): Update.
8646         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8647         type.
8648         (gdbsim_target::pid_to_str): Change return type.
8649         * ravenscar-thread.c (struct ravenscar_thread_target)
8650         <pid_to_str>: Change return type.
8651         (ravenscar_thread_target::pid_to_str): Change return type.
8652         * procfs.c (class procfs_target) <pid_to_str>: Change return
8653         type.
8654         (procfs_target::pid_to_str): Change return type.
8655         (procfs_target::attach): Update.
8656         (procfs_target::detach): Update.
8657         (procfs_target::fetch_registers): Update.
8658         (procfs_target::store_registers): Update.
8659         (procfs_target::wait): Update.
8660         (procfs_target::files_info): Update.
8661         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8662         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8663         return type.
8664         (nto_procfs_target::pid_to_str): Change return type.
8665         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8666         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8667         return type.
8668         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8669         (exit_lwp): Update.
8670         (attach_proc_task_lwp_callback, get_detach_signal)
8671         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8672         (linux_nat_target::resume, wait_lwp, stop_callback)
8673         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8674         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8675         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8676         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8677         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8678         type.
8679         (inf_ptrace_target::attach): Update.
8680         (inf_ptrace_target::files_info): Update.
8681         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8682         type.
8683         (go32_nat_target::pid_to_str): Change return type.
8684         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8685         (gnu_nat_target::wait): Update.
8686         (gnu_nat_target::wait): Update.
8687         (gnu_nat_target::resume): Update.
8688         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8689         (fbsd_nat_target::wait): Update.
8690         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8691         type.
8692         (darwin_nat_target::attach): Update.
8693         * corelow.c (class core_target) <pid_to_str>: Change return type.
8694         (core_target::pid_to_str): Change return type.
8695         * target.c (normal_pid_to_str): Change return type.
8696         (default_pid_to_str): Likewise.
8697         (target_pid_to_str): Change return type.
8698         (target_translate_tls_address): Update.
8699         (target_announce_detach): Update.
8700         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8701         return type.
8702         (bsd_uthread_target::pid_to_str): Change return type.
8703         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8704         type.
8705         (bsd_kvm_target::pid_to_str): Change return type.
8706         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8707         return type.
8708         (aix_thread_target::pid_to_str): Change return type.
8709         * target.h (struct target_ops) <pid_to_str>: Change return type.
8710         (target_pid_to_str, normal_pid_to_str): Likewise.
8711         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8712         type.
8713         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8714         type.
8715         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8716         return type.
8717         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8718         type.
8719         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8720         type.
8721         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8722         return type.
8723
8724 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8725
8726         * NEWS: Mention that the new default MI version is 3.  Mention
8727         changes to the output of commands and events that deal with
8728         multi-location breakpoints.
8729         * breakpoint.c: Include "mi/mi-out.h".
8730         (print_one_breakpoint): Change output syntax if using MI version
8731         >= 3.
8732         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8733         New.
8734         (mi_multi_location_breakpoint_output_fixed): New.
8735         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8736         (mi_cmd_fix_multi_location_breakpoint_output): New.
8737         (mi_multi_location_breakpoint_output_fixed): New.
8738         * mi/mi-cmds.c (mi_cmds): Register command
8739         -fix-multi-location-breakpoint-output.
8740         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8741         interpreter "mi".
8742
8743 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8744
8745         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8746         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8747         instantiate mi_ui_out based on interpreter name.
8748         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8749         * mi/mi-main.c (mi_load_progress): Likewise.
8750
8751 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8752
8753         * NEWS: Combine separate "New targets" sections for 8.3.
8754
8755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8756
8757         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8758         (ppcfbsd_init_abi): Install gdbarch
8759         "fetch_tls_load_module_address" and "get_thread_local_address"
8760         methods.
8761
8762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8763
8764         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8765         (riscv_fbsd_init_abi): Install gdbarch
8766         "fetch_tls_load_module_address" and "get_thread_local_address"
8767         methods.
8768
8769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8770
8771         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8772         (i386fbsd_init_abi): Install gdbarch
8773         "fetch_tls_load_module_address" and "get_thread_local_address"
8774         methods.
8775
8776 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8777
8778         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8779         (amd64fbsd_init_abi): Install gdbarch
8780         "fetch_tls_load_module_address" and "get_thread_local_address"
8781         methods.
8782
8783 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8784
8785         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8786         (struct fbsd_pspace_data): New type.
8787         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8788         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8789         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8790         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8791         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8792
8793 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8794
8795         * gdbtypes.c (lookup_struct_elt): New function.
8796         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8797         * gdbtypes.h (struct struct_elt): New type.
8798         (lookup_struct_elt): New prototype.
8799
8800 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8801
8802         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8803         remove disabled code block.
8804
8805 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8806
8807         * gdbarch.sh (get_thread_local_address): New method.
8808         * gdbarch.h, gdbarch.c: Regenerate.
8809         * target.c (target_translate_tls_address): Use
8810         gdbarch_get_thread_local_address if present instead of
8811         target::get_thread_local_address.
8812
8813 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8814
8815         * target.h (target::get_thread_local_address): Update comment.
8816
8817 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8818
8819         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8820         objfile->separate_debug_objfile_backlink if not NULL.
8821
8822 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8823
8824         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8825         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8826         (amd64bsd_store_inferior_registers): Likewise.
8827         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8828         Enable segment base registers.
8829         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8830         PT_GETFSBASE and PT_GETGSBASE.
8831         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8832         PT_SETGSBASE.
8833         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8834         segment base registers.
8835         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8836
8837 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8838
8839         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8840         Update calls to i386_target_description to add 'segments'
8841         parameter.
8842         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8843         add segment base registers.
8844         * arch/i386.c (i386_create_target_description): Add 'segments'
8845         parameter to enable segment base registers.
8846         * arch/i386.h (i386_create_target_description): Likewise.
8847         * features/i386/32bit-segments.xml: New file.
8848         * features/i386/32bit-segments.c: Generate.
8849         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8850         call to i386_target_description to add 'segments' parameter.
8851         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8852         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8853         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8854         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8855         if feature is present.
8856         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8857         Add 'segments' parameter to call to i386_target_description.
8858         (i386_target_description): Add 'segments' parameter to enable
8859         segment base registers.
8860         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8861         to call to i386_target_description.
8862         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8863         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8864         Define I386_NUM_REGS.
8865         (i386_target_description): Add 'segments' parameter to enable
8866         segment base registers.
8867
8868 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8869
8870         PR/24325
8871         * source-cache.c: #undef open and close, to avoid unresolved
8872         externals during linking.
8873
8874 2019-03-12  Tom Tromey  <tromey@adacore.com>
8875
8876         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8877         const.  Add initializers.
8878         (_initialize_remote): Don't initialize ptid globals.
8879
8880 2019-03-12  Pedro Alves  <palves@redhat.com>
8881
8882         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8883
8884 2019-03-12  Pedro Alves  <palves@redhat.com>
8885
8886         * cp-name-parser.y (main): Remove unused 'len' variable.
8887
8888 2019-03-12  Tom Tromey  <tromey@adacore.com>
8889
8890         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8891         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8892
8893 2019-03-12  Tom Tromey  <tromey@adacore.com>
8894
8895         * linux-nat.c (iterate_over_lwps): Update.
8896         (stop_callback): Remove parameter.
8897         (stop_wait_callback, detach_callback, resume_set_callback)
8898         (select_singlestep_lwp_callback, set_ignore_sigint)
8899         (status_callback, resumed_callback, resume_clear_callback)
8900         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8901         data parameter.
8902         (linux_nat_target::detach, linux_nat_target::resume)
8903         (linux_stop_and_wait_all_lwps, select_event_lwp)
8904         (linux_nat_filter_event, linux_nat_wait_1)
8905         (linux_nat_target::kill, linux_nat_target::stop)
8906         (linux_nat_target::stop): Update.
8907         (linux_nat_resume_callback): Change type.
8908         (resume_stopped_resumed_lwps, count_events_callback)
8909         (select_event_lwp_callback): Likewise.
8910         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8911         * arm-linux-nat.c (struct update_registers_data): Remove.
8912         (update_registers_callback): Change type.
8913         (arm_linux_insert_hw_breakpoint1): Update.
8914         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8915         parameter.
8916         (x86_linux_dr_set_addr): Update.
8917         (x86_linux_dr_set_control): Update.
8918         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8919         (iterate_over_lwps): Use gdb::function_view.
8920         * nat/aarch64-linux-hw-point.c (struct
8921         aarch64_dr_update_callback_param): Remove.
8922         (debug_reg_change_callback): Change type.
8923         (aarch64_notify_debug_reg_change): Update.
8924         * s390-linux-nat.c (s390_refresh_per_info): Update.
8925
8926 2019-03-11  Tom Tromey  <tromey@adacore.com>
8927
8928         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8929         redundant assignment to "this_cu".
8930
8931 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8932
8933         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8934
8935 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8936
8937         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8938         from...
8939         (rank_one_type): ... this.
8940
8941 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8942
8943         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8944         from...
8945         (rank_one_type): ... this.
8946
8947 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8948
8949         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8950         from...
8951         (rank_one_type): ... this.
8952
8953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8954
8955         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8956         from...
8957         (rank_one_type): ... this.
8958
8959 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8960
8961         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8962         from...
8963         (rank_one_type): ... this.
8964
8965 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8966
8967         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8968         from...
8969         (rank_one_type): ... this.
8970
8971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8972
8973         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8974         from...
8975         (rank_one_type): ... this.
8976
8977 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8978
8979         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8980         from...
8981         (rank_one_type): ... this.
8982
8983 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8984
8985         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8986         from...
8987         (rank_one_type): ... this.
8988
8989 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8990
8991         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8992         from...
8993         (rank_one_type): ... this.
8994
8995 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8996
8997         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8998         from...
8999         (rank_one_type): ... this.
9000
9001 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9002
9003         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9004         from...
9005         (rank_one_type): ... this.
9006
9007 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9008
9009         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9010         inferior-events' shows the example events.
9011
9012 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9013
9014         Support styling on native MS-Windows console
9015
9016         PR/24315
9017         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9018         on MS-Windows if $TERM is not defined.
9019
9020         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9021
9022         * posix-hdep.c (gdb_console_fputs):
9023         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9024         functions.
9025         * ui-file.h (gdb_console_fputs): Add prototype.
9026
9027         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9028         back to fputs only if the former returns zero.
9029
9030 2019-03-07  Tom Tromey  <tom@tromey.com>
9031
9032         * symmisc.c (print_symbol_bcache_statistics): Update.
9033         (print_objfile_statistics): Update.
9034         * symfile.c (allocate_symtab): Update.
9035         * stabsread.c: Don't include bcache.h.
9036         * psymtab.h (struct psymbol_bcache): Don't declare.
9037         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9038         (psymbol_bcache_init, psymbol_bcache_free)
9039         (psymbol_bcache_get_bcache): Don't declare.
9040         * psymtab.c (struct psymbol_bcache): Remove.
9041         (psymtab_storage::psymtab_storage): Update.
9042         (psymtab_storage::~psymtab_storage): Update.
9043         (psymbol_bcache_init, psymbol_bcache_free)
9044         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9045         (add_psymbol_to_bcache): Update.
9046         (allocate_psymtab): Update.
9047         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9048         macro_cache>: No longer pointers.
9049         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9050         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9051         * macrotab.c (macro_bcache): Update.
9052         * macroexp.c: Don't include bcache.h.
9053         * gdbtypes.c (check_types_worklist): Update.
9054         (types_deeply_equal): Remove TRY/CATCH.  Update.
9055         * elfread.c (elf_symtab_read): Update.
9056         * dwarf2read.c: Don't include bcache.h.
9057         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9058         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9059         (print_bcache_statistics, bcache_memory_used): Don't declare.
9060         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9061         methods.  Rename all data members.
9062         * bcache.c (struct bcache): Move to bcache.h.
9063         (bcache::expand_hash_table): Rename from expand_hash_table.
9064         (bcache): Remove.
9065         (bcache::insert): Rename from bcache_full.
9066         (bcache::compare): Rename from bcache_compare.
9067         (bcache_xmalloc): Remove.
9068         (bcache::~bcache): Rename from bcache_xfree.
9069         (bcache::print_statistics): Rename from print_bcache_statistics.
9070         (bcache::memory_used): Rename from bcache_memory_used.
9071
9072 2019-03-07  Pedro Alves  <palves@redhat.com>
9073
9074         * infrun.c (normal_stop): Also check for
9075         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9076
9077 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9078
9079         * f-lang.c (value_from_host_double): Moved to...
9080         * value.c (value_from_host_double): ...here.
9081         * value.h (value_from_host_double): Declare.
9082         * guile/scm-math.c (vlscm_convert_typed_number): Use
9083         value_from_host_double.
9084         (vlscm_convert_number): Likewise.
9085         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9086         * python/py-value.c (convert_value_from_python): Likewise.
9087
9088 2019-03-06  Tom Tromey  <tom@tromey.com>
9089
9090         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9091
9092 2019-03-06  Tom Tromey  <tom@tromey.com>
9093
9094         * utils.h (free_current_contents): Don't declare.
9095         * utils.c (free_current_contents): Remove.
9096
9097 2019-03-06  Tom Tromey  <tom@tromey.com>
9098
9099         * top.c (quit_force): Update.
9100         * main.c (captured_command_loop): Update.
9101         * common/new-op.c (operator new): Update.
9102         * common/common-exceptions.c (struct catcher)
9103         <save_cleanup_chain>: Remove member.
9104         (exceptions_state_mc_init): Update.
9105         (exception_try_scope_entry): Return nullptr.
9106         (exception_try_scope_exit, exception_rethrow)
9107         (throw_exception_sjlj, throw_exception_cxx): Update.
9108         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9109         (all_cleanups, do_cleanups, discard_cleanups)
9110         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9111         (restore_cleanups, restore_final_cleanups): Don't declare.
9112         (do_final_cleanups): Remove parameter.
9113         * common/cleanups.c (cleanup_chain, make_cleanup)
9114         (make_cleanup_dtor, all_cleanups, do_cleanups)
9115         (discard_my_cleanups, discard_cleanups)
9116         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9117         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9118         (null_cleanup): Remove.
9119         (do_final_cleanups): Remove parameter.
9120
9121 2019-03-06  Tom Tromey  <tom@tromey.com>
9122
9123         * remote.c (remote_target::remote_parse_stop_reply): Use
9124         unique_xmalloc_ptr.
9125
9126 2019-03-06  Tom Tromey  <tom@tromey.com>
9127
9128         * stabsread.c (struct stabs_field_info): Rename from field_info.
9129         <list, fnlist>: Add initializers.
9130         <obstack>: New member.
9131         (read_member_functions, read_struct_fields, read_baseclasses):
9132         Allocate on obstack.  Don't use cleanups.
9133         (read_one_struct_field, read_member_functions, read_struct_fields)
9134         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9135         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9136         (read_struct_type): Update.
9137
9138 2019-03-06  Tom Tromey  <tom@tromey.com>
9139
9140         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9141         * common/filestuff.h (make_cleanup_close): Don't declare.
9142         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9143         Remove.
9144
9145 2019-03-06  Tom Tromey  <tom@tromey.com>
9146
9147         * solib-aix.c: Use make_scope_exit.
9148
9149 2019-03-06  Tom Tromey  <tom@tromey.com>
9150
9151         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9152         Use make_scope_exit.
9153
9154 2019-03-06  Tom Tromey  <tom@tromey.com>
9155
9156         * solib-svr4.c (disable_probes_interface): Remove parameter.
9157         (svr4_handle_solib_event): Use make_scope_exit.
9158
9159 2019-03-06  Tom Tromey  <tom@tromey.com>
9160
9161         * remote.c (struct stop_reply_deleter): Remove.
9162         (stop_reply_up): Update.
9163         (struct stop_reply): Derive from notif_event.  Don't typedef.
9164         <regcache>: Now a std::vector.
9165         (stop_reply_xfree): Remove.
9166         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9167         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9168         (remote_target::discard_pending_stop_replies): Use delete.
9169         (remote_target::remote_parse_stop_reply): Update.
9170         (remote_target::process_stop_reply): Update.
9171         * remote-notif.h (struct notif_event): Add virtual destructor.
9172         Remove "dtr" member.
9173         (struct notif_client) <alloc_event>: Return a unique_ptr.
9174         (notif_event_xfree): Don't declare.
9175         (notif_event_up): New typedef.
9176         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9177         (notif_event_xfree, do_notif_event_xfree): Remove.
9178         (remote_notif_state_xfree): Update.
9179
9180 2019-03-06  Tom Tromey  <tom@tromey.com>
9181
9182         * infrun.c (displaced_step_clear_cleanup): Now a
9183         forward_scope_exit type.
9184         (displaced_step_prepare_throw): Update.
9185         (displaced_step_fixup): Update.
9186
9187 2019-03-06  Tom Tromey  <tom@tromey.com>
9188
9189         * inferior.h (class inferior): Update comment.
9190         * gdbthread.h (class thread_info): Update comment.
9191
9192 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9193             Tom Tromey  <tom@tromey.com>
9194
9195         * stabsread.h (struct stab_section_list): Remove.
9196         (coffstab_build_psymtabs): Update.
9197         * dbxread.c (symbuf_sections): Now a std::vector.
9198         (sect_idx): New global.
9199         (fill_symbuf): Update.
9200         (coffstab_build_psymtabs): Change type of stabsects parameter.
9201         Update.
9202         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9203         std::vector.
9204         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9205         (coff_locate_sections): Update.
9206         (coff_symfile_read): Remove cleanups.  Update.
9207         (init_stringtab): Add storage parameter.
9208         (free_stringtab, free_stringtab_cleanup): Remove.
9209         (init_lineno): Add storage parameter.
9210         (free_linetab, free_linetab_cleanup): Remove.
9211
9212 2019-03-06  Pedro Alves  <palves@redhat.com>
9213
9214         * linux-fork.c (fork_info::clobber_regs): Delete.
9215         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9216         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9217         comment.  Adjust.
9218         (scoped_switch_fork_info::scoped_switch_fork_info)
9219         (checkpoint_command, linux_fork_context): Adjust
9220         fork_save_infrun_state calls.
9221
9222 2019-03-06  Pedro Alves  <palves@redhat.com>
9223
9224         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9225         (inf_has_multiple_threads): Return 'bool' and rewrite using
9226         inferior_info::threads().
9227
9228 2019-03-06  Pedro Alves  <palves@redhat.com>
9229
9230         * linux-fork.c: Include <list>.
9231         (fork_list): Now a std::list instance.
9232         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9233         (forks_exist_p, find_last_fork): Adjust.
9234         (new_fork): Delete.
9235         (one_fork_p): New.
9236         (add_fork): Adjust.
9237         (free_fork): Delete, folded into fork_info::~fork_info().
9238         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9239         Adjust.
9240         (init_fork_list): Delete.
9241         (linux_fork_killall, linux_fork_mourn_inferior)
9242         (linux_fork_detach, info_checkpoints_command): Adjust.
9243         (_initialize_linux_fork): No longer call init_fork_list.
9244
9245 2019-03-06  Pedro Alves  <palves@redhat.com>
9246
9247         * linux-fork.c (new_fork): New, split out of ...
9248         (add_fork): ... this.  Return void.  Move "first fork" special
9249         case from here, to ...
9250         (checkpoint_command): ... here.
9251         * linux-linux.h (add_fork): Return void.
9252
9253 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9254
9255         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9256
9257 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9258             Chris January  <chris.january@arm.com>
9259             David Lecomber  <david.lecomber@arm.com>
9260
9261         * f-exp.y: New token, UNOP_INTRINSIC.
9262         (exp): New pattern using UNOP_INTRINSIC token.
9263         (f77_keywords): Add 'abs' keyword.
9264         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9265         (value_from_host_double): New function.
9266         (evaluate_subexp_f): Support UNOP_ABS.
9267
9268 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9269
9270         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9271         types.
9272
9273 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9274
9275         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9276         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9277         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9278
9279 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9280
9281         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9282
9283 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9284             Chris January  <chris.january@arm.com>
9285
9286         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9287         * f-exp.y: Define 'KIND' token.
9288         (exp): New pattern for KIND expressions.
9289         (ptype): Handle types with a kind extension.
9290         (direct_abs_decl): Extend to spot kind extensions.
9291         (f77_keywords): Add 'kind' to the list.
9292         (push_kind_type): New function.
9293         (convert_to_kind_type): New function.
9294         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9295         * parse.c (operator_length_standard): Likewise.
9296         * parser-defs.h (enum type_pieces): Add tp_kind.
9297         * std-operator.def: Add UNOP_KIND.
9298
9299 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9300
9301         * f-exp.y (f_parse): Set yydebug.
9302
9303 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9304
9305         * f-lang.c (evaluate_subexp_f): New function.
9306         (exp_descriptor_f): New global.
9307         (f_language_defn): Use exp_descriptor_f instead of
9308         exp_descriptor_standard.
9309
9310 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9311
9312         * f-exp.y (struct token): Add comments.
9313         (dot_ops): Remove uppercase versions and the end marker.
9314         (f77_keywords): Likewise.
9315         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9316         entries in the dot_ops array are case insensitive, and use
9317         strncasecmp to compare strings.  Also some whitespace cleanup in
9318         this area.  Similar for the f77_keywords array, except entries in
9319         this list might be case sensitive.
9320
9321 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9322
9323         * f-exp.y (struct f77_boolean_val): Add comments.
9324         (boolean_values): Remove uppercase versions, and end marker.
9325         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9326         and use strncasecmp to achieve case insensitivity.  Additionally,
9327         perform whitespace cleanup around this code.
9328
9329 2019-03-06  Tom Tromey  <tromey@adacore.com>
9330
9331         * remote-sim.c (gdbsim_target_open): Use result of
9332         gdb_argv::release.
9333
9334 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9335         Dirk Schubert  <dirk.schubert@arm.com>
9336         Chris January  <chris.january@arm.com>
9337
9338         * eval.c (evaluate_subexp_standard): Call Fortran argument
9339         wrapping logic.
9340         * f-lang.c (struct value): A value which can be passed into a
9341         Fortran function call.
9342         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9343         where appropriate.
9344         (struct type): Value ready for a Fortran function call.
9345         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9346         is needed.
9347         * f-lang.h (fortran_argument_convert): Declaration.
9348         (fortran_preserve_arg_pointer): Declaration.
9349         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9350
9351 2019-03-05  Tom Tromey  <tromey@adacore.com>
9352
9353         * python/py-prettyprint.c (print_string_repr): Remove #if.
9354         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9355
9356 2019-03-05  Tom Tromey  <tromey@adacore.com>
9357
9358         * target.c (the_dummy_target): Move later.  Change type to
9359         "dummy_target".
9360         (initialize_targets): Don't initialize the_dummy_target.
9361
9362 2019-03-05  Tom Tromey  <tromey@adacore.com>
9363
9364         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9365         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9366
9367 2019-03-05  Tom Tromey  <tromey@adacore.com>
9368
9369         * windows-nat.c (windows_nat_target::attach)
9370         (windows_nat_target::detach): Don't call gdb_flush.
9371         * valprint.c (generic_val_print, val_print, val_print_string):
9372         Don't call gdb_flush.
9373         * utils.c (defaulted_query): Don't call gdb_flush.
9374         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9375         * target.c (target_announce_detach): Don't call gdb_flush.
9376         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9377         * remote.c (extended_remote_target::attach): Don't call
9378         gdb_flush.
9379         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9380         * printcmd.c (do_examine): Don't call gdb_flush.
9381         (info_display_command): Don't call gdb_flush.
9382         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9383         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9384         * memattr.c (info_mem_command): Don't call gdb_flush.
9385         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9386         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9387         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9388         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9389         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9390         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9391         (gnu_nat_target::detach): Don't call gdb_flush.
9392         * f-valprint.c (f_val_print): Don't call gdb_flush.
9393         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9394         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9395         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9396         gdb_flush.
9397         * c-valprint.c (c_val_print): Don't call gdb_flush.
9398         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9399
9400 2019-03-05  Tom Tromey  <tromey@adacore.com>
9401
9402         * varobj.c (update_dynamic_varobj_children): Update.
9403         (install_default_visualizer): Use reset, not release.
9404         * value.c (set_internalvar): Update.
9405         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9406         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9407         ATTRIBUTE_UNUSED_RESULT.
9408
9409 2019-03-05  Tom Tromey  <tromey@adacore.com>
9410
9411         * remote.c (class scoped_remote_fd) <release>: Add
9412         ATTRIBUTE_UNUSED_RESULT.
9413
9414 2019-03-05  Tom Tromey  <tromey@adacore.com>
9415
9416         * macroexp.c (struct macro_buffer) <release>: Add
9417         ATTRIBUTE_UNUSED_RESULT.
9418
9419 2019-03-05  Tom Tromey  <tromey@adacore.com>
9420
9421         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9422         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9423         ATTRIBUTE_UNUSED_RESULT.
9424
9425 2019-03-05  Tom Tromey  <tromey@adacore.com>
9426
9427         * common/scoped_fd.h (class scoped_fd) <release>: Add
9428         ATTRIBUTE_UNUSED_RESULT.
9429
9430 2019-03-05  Tom Tromey  <tromey@adacore.com>
9431
9432         * parser-defs.h (struct parser_state) <release>: Add
9433         ATTRIBUTE_UNUSED_RESULT.
9434
9435 2019-03-05  Tom Tromey  <tromey@adacore.com>
9436
9437         * utils.h (class gdb_argv) <release>: Add
9438         ATTRIBUTE_UNUSED_RESULT.
9439         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9440
9441 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9442
9443         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9444         for-loop range, to avoid compiler warnings.
9445
9446         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9447         avoid compiler warnings about unused variables.
9448
9449         * NEWS: Mention end of support for native debugging on MS-Windows
9450         before XP.
9451
9452         PR gdb/24292
9453         * common/netstuff.c:
9454         * gdbserver/gdbreplay.c
9455         * gdbserver/remote-utils.c:
9456         * ser-tcp.c:
9457         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9458         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9459         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9460         'getaddrinfo' and 'freeaddrinfo' were not available before
9461         Windows XP, and mingw.org's MinGW headers by default define
9462         _WIN32_WINNT to 0x500.
9463
9464 2019-03-01  Gary Benson <gbenson@redhat.com>
9465
9466         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9467
9468 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9469             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9470
9471         PR gdb/8527
9472         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9473         set_sigint_trap, clear_sigint_trap.
9474
9475 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9476
9477         * target.c (target_detach): Clear the regcache and the
9478         frame cache.
9479
9480 2019-02-27  Pedro Alves  <palves@redhat.com>
9481
9482         * utils.c (set_screen_size): When we cap the height/width sizes,
9483         tweak the corresponding command variable to show "unlimited":
9484
9485 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9486             Pedro Alves  <palves@redhat.com>
9487
9488         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9489         before calling rl_set_screen_size.
9490
9491 2019-02-27  Tom Tromey  <tromey@adacore.com>
9492
9493         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9494         define.
9495         * python/py-value.c: Remove Python 2.4 workaround.
9496         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9497         workaround.
9498         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9499         Python 2.4 workaround.
9500         * python/python-internal.h: Remove Python 2.4 comment.
9501         (Py_ssize_t): Don't define.
9502         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9503         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9504         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9505         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9506         * python/python.c (do_start_initialization): Remove Python 2.4
9507         workaround.
9508         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9509         (print_children): Remove Python 2.4 workaround.
9510         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9511         workaround.
9512         (CHARBUFFERPROC_NAME): Remove.
9513         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9514         Python 2.4 workaround.
9515
9516 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9517
9518         * NEWS: Note minimum Python version.
9519
9520 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9521
9522         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9523         code from these functions.  Remove corresponding ifdefs.  Use
9524         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9525         Remove gotos and target of gotos.
9526         (infpy_search_memory): Likewise.
9527
9528 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9529
9530         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9531         (hppa_gdbarch_init): Don't register deleted functions with
9532         gdbarch.
9533
9534 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9535
9536         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9537         (h8300_unwind_sp): Delete.
9538         (h8300_dummy_id): Delete.
9539         (h8300_gdbarch_init): Don't register deleted functions with
9540         gdbarch.
9541
9542 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9543
9544         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9545         (ft32_unwind_pc): Delete.
9546         (ft32_unwind_sp): Delete.
9547         (ft32_gdbarch_init): Don't register deleted functions with
9548         gdbarch.
9549
9550 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9551
9552         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9553         (frv_unwind_pc): Delete.
9554         (frv_unwind_sp): Delete.
9555         (frv_gdbarch_init): Don't register deleted functions with
9556         gdbarch.
9557
9558 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9559
9560         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9561         (riscv_unwind_pc): Delete.
9562         (riscv_unwind_sp): Delete.
9563         (riscv_gdbarch_init): Don't register deleted functions with
9564         gdbarch.
9565
9566 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9567
9568         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9569         (csky_unwind_pc): Delete.
9570         (csky_unwind_sp): Delete.
9571         (csky_gdbarch_init): Don't register deleted functions with
9572         gdbarch.
9573
9574 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9575
9576         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9577         (cris_unwind_pc): Delete.
9578         (cris_unwind_sp): Delete.
9579         (cris_gdbarch_init): Don't register deleted functions with
9580         gdbarch.
9581
9582 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9583
9584         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9585         (bfin_unwind_pc): Delete.
9586         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9587
9588 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9589
9590         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9591         (arm_unwind_pc): Delete.
9592         (arm_unwind_sp): Delete.
9593         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9594
9595 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9596
9597         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9598         (arc_unwind_pc): Delete.
9599         (arc_unwind_sp): Delete.
9600         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9601
9602 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9603
9604         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9605         (alpha_unwind_pc): Delete.
9606         (alpha_gdbarch_init): Don't register deleted functions with
9607         gdbarch.
9608
9609 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9610
9611         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9612         (aarch64_unwind_pc): Delete.
9613         (aarch64_unwind_sp): Delete.
9614         (aarch64_gdbarch_init): Don't register deleted functions with
9615         gdbarch.
9616
9617 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9618
9619         * gdbtypes.c (type_align): Don't consider static members when
9620         computing structure alignment.
9621
9622 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9623
9624         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9625         return 0 for other types.
9626         * arch-utils.c (default_type_align): Always return 0.
9627         * gdbarch.h: Regenerate.
9628         * gdbarch.sh (type_align): Extend comment.
9629         * gdbtypes.c (type_align): Add additional comments, always call
9630         gdbarch_type_align before applying the default rules.
9631         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9632         generic code will then apply a suitable default.
9633         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9634         types, return 0 for other types.
9635
9636 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9637
9638         * NEWS: Create a new section for the next release branch.
9639         Rename the section of the current branch, now that it has
9640         been cut.
9641
9642 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9643
9644         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9645         * version.in: Bump version to 8.3.50.DATE-git.
9646
9647 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9648
9649         * aix-thread.c (ptid_cmp): Remove unused variable.
9650         (get_signaled_thread): Likewise.
9651         (store_regs_user_thread): Likewise.
9652         (store_regs_kernel_thread): Likewise.
9653         (fetch_regs_kernel_thread): Remove shadowed variable.
9654
9655 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9656
9657         * features/riscv/32bit-cpu.xml: Add register numbers.
9658         * features/riscv/32bit-fpu.c: Regenerate.
9659         * features/riscv/32bit-fpu.xml: Add register numbers.
9660         * features/riscv/64bit-cpu.xml: Add register numbers.
9661         * features/riscv/64bit-fpu.c: Regenerate.
9662         * features/riscv/64bit-fpu.xml: Add register numbers.
9663
9664 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9665
9666         * NEWS: Mention two argument form of gdb.Value constructor.
9667         * python/py-value.c (convert_buffer_and_type_to_value): New
9668         function.
9669         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9670         Add support for handling an optional second argument.  Call
9671         convert_buffer_and_type_to_value as appropriate.
9672         * python/python-internal.h (Py_buffer_deleter): New struct.
9673         (Py_buffer_up): New typedef.
9674
9675 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9676
9677         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9678         instead of releasing ownership.
9679
9680 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9681
9682         * dwarf2read.c (open_and_init_dwp_file): Call
9683         elf_numsections instead of bfd_count_sections to initialize
9684         dwp_file->num_sections.
9685
9686 2019-02-25  Tom Tromey  <tromey@adacore.com>
9687
9688         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9689
9690 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9691
9692         * gcore.in: Add '--readnever' option when invoking GDB.
9693
9694 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9695
9696         * MAINTAINERS: Update my email address.
9697
9698 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9699
9700         * build-id.c (build_id_to_debug_bfd_1): New function.
9701         (build_id_to_debug_bfd): Look for separate debug file in
9702         sysroot.
9703
9704 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9705
9706         * gdbarch.sh: Update the copyright year range that is placed into
9707         generated files.
9708
9709 2019-02-22  Keith Seitz  <keiths@redhat.com>
9710
9711         PR symtab/23853
9712         * linespec.c (create_sals_line_offset): Search for the default
9713         symtab's filename instead of its fullname.
9714
9715 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9716
9717         * NEWS: Update style defaults.
9718
9719 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9720
9721         * main.c (captured_main_1): Disable styling in batch mode.
9722
9723 2019-02-20  Tom Tromey  <tom@tromey.com>
9724
9725         * symtab.c (symtab_symbol_info): Fix typos.
9726
9727 2019-02-20  Tom Tromey  <tromey@adacore.com>
9728
9729         * findcmd.c (_initialize_mem_search): Use upper case for
9730         metasyntactic variables.
9731
9732 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9733
9734         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9735         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9736
9737 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9738
9739         * top.h (source_file_name): Change to std::string.
9740         * top.c (source_file_name): Likewise.
9741         (command_line_input): Adjust.
9742         * cli/cli-script.c (script_from_file): Adjust.
9743
9744 2019-02-19  Tom Tromey  <tromey@adacore.com>
9745
9746         * ravenscar-thread.c
9747         (ravenscar_thread_target::update_thread_list): Don't call
9748         ada_build_task_list.
9749         * ada-lang.h (ada_build_task_list): Don't declare.
9750         * ada-tasks.c (struct ada_tasks_inferior_data)
9751         <task_list_valid_p>: Now bool.
9752         (read_known_tasks, ada_task_list_changed)
9753         (ada_tasks_invalidate_inferior_data): Update.
9754         (read_known_tasks_array): Return bool.
9755         (read_known_tasks_list): Likewise.
9756         (read_known_tasks): Return void.
9757         (ada_build_task_list): Now static.
9758
9759 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9760
9761         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9762         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9763
9764 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9765
9766         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9767         variant for ada_tasks_pspace_data_handle and
9768         ada_tasks_inferior_data_handle.
9769         (ada_tasks_pspace_data_cleanup): New function.
9770         (ada_tasks_inferior_data_cleanup): New function.
9771
9772 2019-02-17  Tom Tromey  <tom@tromey.com>
9773
9774         * macrotab.h (macro_source_fullname): Return a std::string.
9775         * macrotab.c (macro_include, check_for_redefinition)
9776         (macro_undef, macro_lookup_definition, foreach_macro)
9777         (foreach_macro_in_scope): Update.
9778         (macro_source_fullname): Return a std::string.
9779         * macrocmd.c (show_pp_source_pos): Update.
9780
9781 2019-02-17  Tom Tromey  <tom@tromey.com>
9782
9783         * macrocmd.c (show_pp_source_pos): Style the file names.
9784
9785 2019-02-17  Tom Tromey  <tom@tromey.com>
9786
9787         PR tui/24197:
9788         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9789
9790 2019-02-17  Tom Tromey  <tom@tromey.com>
9791
9792         * ada-lang.c (user_select_syms): Use filtered printing.
9793         * utils.c (wrap_style): New global.
9794         (desired_style): Remove.
9795         (emit_style_escape): Add stream parameter.
9796         (set_output_style, reset_terminal_style, prompt_for_continue):
9797         Update.
9798         (flush_wrap_buffer): Only flush gdb_stdout.
9799         (wrap_here): Set wrap_style.
9800         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9801         treat escape sequences as a character.  Change when wrap buffer is
9802         flushed.
9803         (fputs_styled): Do not set the output style when the default is
9804         requested.
9805         * ui-style.h (struct ui_file_style) <is_default>: New method.
9806         * source.c (print_source_lines_base): Emit escape sequences in one
9807         piece.
9808
9809 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9810
9811         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9812         integers and enumeration types.
9813
9814 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9815
9816         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9817         instead of lookup_symbol_in_language
9818         (do_exact_match): New function.
9819         (ada_get_symbol_name_matcher): Return do_exact_match when
9820         doing a verbatim match.
9821
9822 2019-02-15  Tom Tromey  <tromey@adacore.com>
9823
9824         * ravenscar-thread.c (ravenscar_thread_target::resume)
9825         (ravenscar_thread_target::wait): Special case wildcard requests.
9826
9827 2019-02-15  Tom Tromey  <tromey@adacore.com>
9828
9829         * ravenscar-thread.c (base_ptid): Remove.
9830         (struct ravenscar_thread_target) <close>: New method.
9831         <m_base_ptid>: New member.
9832         <update_inferior_ptid, active_task, task_is_currently_active,
9833         runtime_initialized>: Declare methods.
9834         <ravenscar_thread_target>: Add constructor.
9835         (ravenscar_thread_target::task_is_currently_active)
9836         (ravenscar_thread_target::update_inferior_ptid)
9837         (ravenscar_runtime_initialized): Rename.  Now methods.
9838         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9839         (ravenscar_thread_target::update_thread_list): Update.
9840         (ravenscar_thread_target::active_task): Now method.
9841         (ravenscar_thread_target::store_registers)
9842         (ravenscar_thread_target::prepare_to_store)
9843         (ravenscar_thread_target::prepare_to_store)
9844         (ravenscar_thread_target::mourn_inferior): Update.
9845         (ravenscar_inferior_created): Use "new" to create target.
9846         (ravenscar_thread_target::get_ada_task_ptid): Update.
9847         (_initialize_ravenscar): Don't initialize base_ptid.
9848         (ravenscar_ops): Remove global.
9849
9850 2019-02-15  Tom Tromey  <tromey@adacore.com>
9851
9852         * target.h (push_target): Declare new overload.
9853         * target.c (push_target): New overload, taking an rvalue reference.
9854         * remote.c (remote_target::open_1): Use push_target overload.
9855         * corelow.c (core_target_open): Use push_target overload.
9856
9857 2019-02-15  Tom Tromey  <tromey@adacore.com>
9858
9859         * ravenscar-thread.c (is_ravenscar_task)
9860         (ravenscar_task_is_currently_active): Return bool.
9861         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9862         (_initialize_ravenscar): Remove "(void)".
9863         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9864         Return bool.
9865
9866 2019-02-15  Tom Tromey  <tromey@adacore.com>
9867
9868         * ravenscar-thread.c (ravenscar_runtime_initializer)
9869         (has_ravenscar_runtime, get_running_thread_id)
9870         (ravenscar_thread_target::resume): Fix indentation.
9871
9872 2019-02-15  Tom Tromey  <tromey@adacore.com>
9873
9874         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9875         from ravenscar_arch_ops.
9876         (sparc_ravenscar_ops::fetch_registers)
9877         (sparc_ravenscar_ops::store_registers): Now methods.
9878         (sparc_ravenscar_prepare_to_store): Remove.
9879         (sparc_ravenscar_ops): Redefine.
9880         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9881         methods and destructor.  Remove members.
9882         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9883         (ravenscar_thread_target::store_registers)
9884         (ravenscar_thread_target::prepare_to_store): Update.
9885         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9886         Remove.
9887         (struct ppc_ravenscar_powerpc_ops): Derive from
9888         ravenscar_arch_ops.
9889         (ppc_ravenscar_powerpc_ops::fetch_registers)
9890         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9891         (ppc_ravenscar_powerpc_ops): Redefine.
9892         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9893         (ppc_ravenscar_e500_ops::fetch_registers)
9894         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9895         (ppc_ravenscar_e500_ops): Redefine.
9896         * aarch64-ravenscar-thread.c
9897         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9898         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9899         (aarch64_ravenscar_fetch_registers)
9900         (aarch64_ravenscar_store_registers): Now methods.
9901         (aarch64_ravenscar_ops): Redefine.
9902
9903 2019-02-15  Tom Tromey  <tromey@adacore.com>
9904
9905         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9906         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9907         (ravenscar_thread_target::stopped_by_watchpoint)
9908         (ravenscar_thread_target::stopped_data_address)
9909         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9910
9911 2019-02-15  Tom Tromey  <tromey@adacore.com>
9912
9913         * ravenscar-thread.c: Fix some typos.
9914
9915 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9916             Tom Tromey  <tromey@adacore.com>
9917
9918         * ada-lang.c (ada_exception_sal): Change addr_string to a
9919         std::string.
9920         (create_ada_exception_catchpoint): Update.
9921
9922 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9923             Tom Tromey  <tromey@adacore.com>
9924
9925         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9926         (bp_location_ops): Remove.
9927         (base_breakpoint_allocate_location): Update.
9928         (free_bp_location): Update.
9929         * ada-lang.c (class ada_catchpoint_location)
9930         <ada_catchpoint_location>: Remove ops parameter.
9931         (ada_catchpoint_location_dtor): Remove.
9932         (ada_catchpoint_location_ops): Remove.
9933         (allocate_location_exception): Update.
9934         * breakpoint.h (struct bp_location_ops): Remove.
9935         (class bp_location) <bp_location>: Remove bp_location_ops
9936         parameter.
9937         <~bp_location>: Add destructor.
9938         <ops>: Remove.
9939
9940 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9941             Pedro Alves  <palves@redhat.com>
9942
9943         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9944         'PATH_MAX'.
9945
9946 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9947             Samuel Thibault  <samuel.thibault@gnu.org>
9948             Thomas Schwinge  <thomas@codesourcery.com>
9949
9950         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9951         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9952
9953 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9954
9955         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9956         (check_empty): Use "const char *".
9957
9958         * gnu-nat.c (gnu_nat_target::detach): Instead of
9959         'detach_inferior (pid)' call
9960         'detach_inferior (find_inferior_pid (pid))'.
9961
9962         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9963         'nat/fork-inferior.o'.
9964         * gnu-nat.c: #include "nat/fork-inferior.h".
9965
9966         * gnu-nat.c (gnu_nat_target::detach): Instead of
9967         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9968         * gnu-nat.h: #include "inf-child.h".
9969         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9970         'i386_gnu_nat_target::fetch_registers'.
9971         (gnu_store_registers): Rename/move to
9972         'i386_gnu_nat_target::store_registers'.
9973
9974         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9975         * gnu-nat.h (mach_thread_info): New function.
9976         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9977
9978         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9979
9980 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9981
9982         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9983
9984 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9985
9986         * windows-nat.c (windows_add_thread): Add new parameter
9987         "main_thread_p" with default value set to false.  Update
9988         function documentation as well as all callers.
9989         (windows_delete_thread): Likewise.
9990         (fake_create_process): Update call to windows_add_thread.
9991         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9992         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9993         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9994         call to windows_delete_thread.
9995
9996 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9997
9998         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9999
10000 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10001
10002         * symfile.c (find_separate_debug_file): Use canonical path of
10003         sysroot with child_path instead of gdb_sysroot if it is valid.
10004
10005 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10006
10007         * symfile.c (find_separate_debug_file): Use child_path to
10008         determine if an object file is under a sysroot.
10009
10010 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10011
10012         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10013         unittests/child-path-selftests.c.
10014         * common/pathstuff.c (child_path): New function.
10015         * common/pathstuff.h (child_path): New prototype.
10016         * unittests/child-path-selftests.c: New file.
10017
10018 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10019
10020         * symfile.c (find_separate_debug_file): Look for separate debug
10021         files in debug directories under the sysroot.
10022
10023 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10024
10025         * symtab.h (struct minimal_symbol data_p): New const method.
10026         (struct minimal_symbol text_p): Likewise.
10027         * symtab.c (output_source_filename): Use file name style
10028         to print file name.
10029         (print_symbol_info): Likewise.
10030         (print_msymbol_info): Use address style to print addresses.
10031         Use function name style to print executable text symbols.
10032         (expand_symtab_containing_pc): Use data_p.
10033         (find_pc_sect_compunit_symtab): Likewise.
10034
10035 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10036
10037         * breakpoint.c (describe_other_breakpoints): Use address style
10038         to print addresses.
10039         (say_where): Likewise.
10040
10041 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10042
10043         * ada-typeprint.c (print_func_type): Print function name
10044         style to print function name.
10045         * c-typeprint.c (c_print_type_1): Likewise.
10046
10047 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10048
10049         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10050         for execve.
10051
10052 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10053
10054         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10055         type_stack.
10056
10057 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10058
10059         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10060         TYPE_CODE_REF types.
10061
10062 2019-02-08  Jim Wilson  <jimw@sifive.com>
10063
10064         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10065         (riscv_linux_fregset): New.
10066         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10067
10068 2019-02-07  Tom Tromey  <tom@tromey.com>
10069
10070         * thread.c (thread_cancel_execution_command): Update.
10071         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10072         methods.
10073         (struct thread_fsm_ops): Remove.
10074         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10075         (thread_fsm_should_stop, thread_fsm_return_value)
10076         (thread_fsm_set_finished, thread_fsm_finished_p)
10077         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10078         Don't declare.
10079         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10080         * infrun.c (clear_proceed_status_thread)
10081         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10082         (print_stop_event): Update.
10083         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10084         Add constructor.
10085         (step_command_fsm_ops): Remove.
10086         (new_step_command_fsm): Remove.
10087         (step_1): Update.
10088         (step_command_fsm::should_stop): Rename from
10089         step_command_fsm_should_stop.
10090         (step_command_fsm::clean_up): Rename from
10091         step_command_fsm_clean_up.
10092         (step_command_fsm::do_async_reply_reason): Rename from
10093         step_command_fsm_async_reply_reason.
10094         (struct until_next_fsm): Inherit from thread_fsm.  Add
10095         constructor.
10096         (until_next_fsm_ops): Remove.
10097         (new_until_next_fsm): Remove.
10098         (until_next_fsm::should_stop): Rename from
10099         until_next_fsm_should_stop.
10100         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10101         (until_next_fsm::do_async_reply_reason): Rename from
10102         until_next_fsm_async_reply_reason.
10103         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10104         constructor.  Change type of breakpoint.
10105         (finish_command_fsm_ops): Remove.
10106         (new_finish_command_fsm): Remove.
10107         (finish_command_fsm::should_stop): Rename from
10108         finish_command_fsm_should_stop.
10109         (finish_command_fsm::clean_up): Rename from
10110         finish_command_fsm_clean_up.
10111         (finish_command_fsm::return_value): Rename from
10112         finish_command_fsm_return_value.
10113         (finish_command_fsm::do_async_reply_reason): Rename from
10114         finish_command_fsm_async_reply_reason.
10115         (finish_command): Update.
10116         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10117         Add constructor.
10118         (call_thread_fsm_ops): Remove.
10119         (call_thread_fsm::call_thread_fsm): Rename from
10120         new_call_thread_fsm.
10121         (call_thread_fsm::should_stop): Rename from
10122         call_thread_fsm_should_stop.
10123         (call_thread_fsm::should_notify_stop): Rename from
10124         call_thread_fsm_should_notify_stop.
10125         (run_inferior_call, call_function_by_hand_dummy): Update.
10126         * cli/cli-interp.c (should_print_stop_to_console): Update.
10127         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10128         Add constructor.  Change type of location_breakpoint,
10129         caller_breakpoint.
10130         (until_break_fsm_ops): Remove.
10131         (new_until_break_fsm): Remove.
10132         (until_break_fsm::should_stop): Rename from
10133         until_break_fsm_should_stop.
10134         (until_break_fsm::clean_up): Rename from
10135         until_break_fsm_clean_up.
10136         (until_break_fsm::do_async_reply_reason): Rename from
10137         until_break_fsm_async_reply_reason.
10138         (until_break_command): Update.
10139         * thread-fsm.c: Remove.
10140         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10141
10142 2019-02-07  Tom Tromey  <tom@tromey.com>
10143
10144         * yy-remap.h: Add include guard.
10145         * xtensa-tdep.h: Add include guard.
10146         * xcoffread.h: Rename include guard.
10147         * varobj-iter.h: Add include guard.
10148         * tui/tui.h: Rename include guard.
10149         * tui/tui-winsource.h: Rename include guard.
10150         * tui/tui-wingeneral.h: Rename include guard.
10151         * tui/tui-windata.h: Rename include guard.
10152         * tui/tui-win.h: Rename include guard.
10153         * tui/tui-stack.h: Rename include guard.
10154         * tui/tui-source.h: Rename include guard.
10155         * tui/tui-regs.h: Rename include guard.
10156         * tui/tui-out.h: Rename include guard.
10157         * tui/tui-layout.h: Rename include guard.
10158         * tui/tui-io.h: Rename include guard.
10159         * tui/tui-hooks.h: Rename include guard.
10160         * tui/tui-file.h: Rename include guard.
10161         * tui/tui-disasm.h: Rename include guard.
10162         * tui/tui-data.h: Rename include guard.
10163         * tui/tui-command.h: Rename include guard.
10164         * tic6x-tdep.h: Add include guard.
10165         * target/waitstatus.h: Rename include guard.
10166         * target/wait.h: Rename include guard.
10167         * target/target.h: Rename include guard.
10168         * target/resume.h: Rename include guard.
10169         * target-float.h: Rename include guard.
10170         * stabsread.h: Add include guard.
10171         * rs6000-tdep.h: Add include guard.
10172         * riscv-fbsd-tdep.h: Add include guard.
10173         * regformats/regdef.h: Rename include guard.
10174         * record.h: Rename include guard.
10175         * python/python.h: Rename include guard.
10176         * python/python-internal.h: Rename include guard.
10177         * python/py-stopevent.h: Rename include guard.
10178         * python/py-ref.h: Rename include guard.
10179         * python/py-record.h: Rename include guard.
10180         * python/py-record-full.h: Rename include guard.
10181         * python/py-record-btrace.h: Rename include guard.
10182         * python/py-instruction.h: Rename include guard.
10183         * python/py-events.h: Rename include guard.
10184         * python/py-event.h: Rename include guard.
10185         * procfs.h: Add include guard.
10186         * proc-utils.h: Add include guard.
10187         * p-lang.h: Add include guard.
10188         * or1k-tdep.h: Rename include guard.
10189         * observable.h: Rename include guard.
10190         * nto-tdep.h: Rename include guard.
10191         * nat/x86-linux.h: Rename include guard.
10192         * nat/x86-linux-dregs.h: Rename include guard.
10193         * nat/x86-gcc-cpuid.h: Add include guard.
10194         * nat/x86-dregs.h: Rename include guard.
10195         * nat/x86-cpuid.h: Rename include guard.
10196         * nat/ppc-linux.h: Rename include guard.
10197         * nat/mips-linux-watch.h: Rename include guard.
10198         * nat/linux-waitpid.h: Rename include guard.
10199         * nat/linux-ptrace.h: Rename include guard.
10200         * nat/linux-procfs.h: Rename include guard.
10201         * nat/linux-osdata.h: Rename include guard.
10202         * nat/linux-nat.h: Rename include guard.
10203         * nat/linux-namespaces.h: Rename include guard.
10204         * nat/linux-btrace.h: Rename include guard.
10205         * nat/glibc_thread_db.h: Rename include guard.
10206         * nat/gdb_thread_db.h: Rename include guard.
10207         * nat/gdb_ptrace.h: Rename include guard.
10208         * nat/fork-inferior.h: Rename include guard.
10209         * nat/amd64-linux-siginfo.h: Rename include guard.
10210         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10211         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10212         * nat/aarch64-linux.h: Rename include guard.
10213         * nat/aarch64-linux-hw-point.h: Rename include guard.
10214         * mn10300-tdep.h: Add include guard.
10215         * mips-linux-tdep.h: Add include guard.
10216         * mi/mi-parse.h: Rename include guard.
10217         * mi/mi-out.h: Rename include guard.
10218         * mi/mi-main.h: Rename include guard.
10219         * mi/mi-interp.h: Rename include guard.
10220         * mi/mi-getopt.h: Rename include guard.
10221         * mi/mi-console.h: Rename include guard.
10222         * mi/mi-common.h: Rename include guard.
10223         * mi/mi-cmds.h: Rename include guard.
10224         * mi/mi-cmd-break.h: Rename include guard.
10225         * m2-lang.h: Add include guard.
10226         * location.h: Rename include guard.
10227         * linux-record.h: Rename include guard.
10228         * linux-nat.h: Add include guard.
10229         * linux-fork.h: Add include guard.
10230         * i386-darwin-tdep.h: Rename include guard.
10231         * hppa-linux-offsets.h: Add include guard.
10232         * guile/guile.h: Rename include guard.
10233         * guile/guile-internal.h: Rename include guard.
10234         * gnu-nat.h: Rename include guard.
10235         * gdb-stabs.h: Rename include guard.
10236         * frv-tdep.h: Add include guard.
10237         * f-lang.h: Add include guard.
10238         * event-loop.h: Add include guard.
10239         * darwin-nat.h: Rename include guard.
10240         * cp-abi.h: Rename include guard.
10241         * config/sparc/nm-sol2.h: Rename include guard.
10242         * config/nm-nto.h: Rename include guard.
10243         * config/nm-linux.h: Add include guard.
10244         * config/i386/nm-i386gnu.h: Rename include guard.
10245         * config/djgpp/nl_types.h: Rename include guard.
10246         * config/djgpp/langinfo.h: Rename include guard.
10247         * compile/gcc-cp-plugin.h: Add include guard.
10248         * compile/gcc-c-plugin.h: Add include guard.
10249         * compile/compile.h: Rename include guard.
10250         * compile/compile-object-run.h: Rename include guard.
10251         * compile/compile-object-load.h: Rename include guard.
10252         * compile/compile-internal.h: Rename include guard.
10253         * compile/compile-cplus.h: Rename include guard.
10254         * compile/compile-c.h: Rename include guard.
10255         * common/xml-utils.h: Rename include guard.
10256         * common/x86-xstate.h: Rename include guard.
10257         * common/version.h: Rename include guard.
10258         * common/vec.h: Rename include guard.
10259         * common/tdesc.h: Rename include guard.
10260         * common/selftest.h: Rename include guard.
10261         * common/scoped_restore.h: Rename include guard.
10262         * common/scoped_mmap.h: Rename include guard.
10263         * common/scoped_fd.h: Rename include guard.
10264         * common/safe-iterator.h: Rename include guard.
10265         * common/run-time-clock.h: Rename include guard.
10266         * common/refcounted-object.h: Rename include guard.
10267         * common/queue.h: Rename include guard.
10268         * common/ptid.h: Rename include guard.
10269         * common/print-utils.h: Rename include guard.
10270         * common/preprocessor.h: Rename include guard.
10271         * common/pathstuff.h: Rename include guard.
10272         * common/observable.h: Rename include guard.
10273         * common/netstuff.h: Rename include guard.
10274         * common/job-control.h: Rename include guard.
10275         * common/host-defs.h: Rename include guard.
10276         * common/gdb_wait.h: Rename include guard.
10277         * common/gdb_vecs.h: Rename include guard.
10278         * common/gdb_unlinker.h: Rename include guard.
10279         * common/gdb_unique_ptr.h: Rename include guard.
10280         * common/gdb_tilde_expand.h: Rename include guard.
10281         * common/gdb_sys_time.h: Rename include guard.
10282         * common/gdb_string_view.h: Rename include guard.
10283         * common/gdb_splay_tree.h: Rename include guard.
10284         * common/gdb_setjmp.h: Rename include guard.
10285         * common/gdb_ref_ptr.h: Rename include guard.
10286         * common/gdb_optional.h: Rename include guard.
10287         * common/gdb_locale.h: Rename include guard.
10288         * common/gdb_assert.h: Rename include guard.
10289         * common/filtered-iterator.h: Rename include guard.
10290         * common/filestuff.h: Rename include guard.
10291         * common/fileio.h: Rename include guard.
10292         * common/environ.h: Rename include guard.
10293         * common/common-utils.h: Rename include guard.
10294         * common/common-types.h: Rename include guard.
10295         * common/common-regcache.h: Rename include guard.
10296         * common/common-inferior.h: Rename include guard.
10297         * common/common-gdbthread.h: Rename include guard.
10298         * common/common-exceptions.h: Rename include guard.
10299         * common/common-defs.h: Rename include guard.
10300         * common/common-debug.h: Rename include guard.
10301         * common/cleanups.h: Rename include guard.
10302         * common/buffer.h: Rename include guard.
10303         * common/btrace-common.h: Rename include guard.
10304         * common/break-common.h: Rename include guard.
10305         * cli/cli-utils.h: Rename include guard.
10306         * cli/cli-style.h: Rename include guard.
10307         * cli/cli-setshow.h: Rename include guard.
10308         * cli/cli-script.h: Rename include guard.
10309         * cli/cli-interp.h: Rename include guard.
10310         * cli/cli-decode.h: Rename include guard.
10311         * cli/cli-cmds.h: Rename include guard.
10312         * charset-list.h: Add include guard.
10313         * buildsym-legacy.h: Rename include guard.
10314         * bfin-tdep.h: Add include guard.
10315         * ax.h: Rename include guard.
10316         * arm-linux-tdep.h: Add include guard.
10317         * arm-fbsd-tdep.h: Add include guard.
10318         * arch/xtensa.h: Rename include guard.
10319         * arch/tic6x.h: Add include guard.
10320         * arch/i386.h: Add include guard.
10321         * arch/arm.h: Rename include guard.
10322         * arch/arm-linux.h: Rename include guard.
10323         * arch/arm-get-next-pcs.h: Rename include guard.
10324         * arch/amd64.h: Add include guard.
10325         * arch/aarch64-insn.h: Rename include guard.
10326         * arch-utils.h: Rename include guard.
10327         * annotate.h: Add include guard.
10328         * amd64-darwin-tdep.h: Rename include guard.
10329         * aarch64-linux-tdep.h: Add include guard.
10330         * aarch64-fbsd-tdep.h: Add include guard.
10331         * aarch32-linux-nat.h: Add include guard.
10332
10333 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10334
10335         * macrotab.c (macro_define_internal): New function that
10336         factorizes macro_define_object_internal and macro_define_function
10337         code.
10338         (macro_define_object_internal): Use macro_define_internal.
10339         (macro_define_function): Likewise.
10340
10341 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10342
10343         * macrocmd.c (extract_identifier): Return
10344         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10345         callers.
10346
10347 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10348
10349         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10350
10351 2019-02-05  Tom Tromey  <tom@tromey.com>
10352
10353         * target.c (target_stack::unpush): Move assertion earlier.
10354
10355 2019-01-30  Tom Tromey  <tom@tromey.com>
10356
10357         PR python/23615:
10358         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10359         (gdbpy_parse_and_eval): Likewise.
10360         * python/python-internal.h (gdbpy_allow_threads): New class.
10361
10362 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10363
10364         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10365         (aarch64_fbsd_fpregmap): Move earlier.
10366         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10367         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10368         instead of individual calls to trad_frame_set_reg_addr.
10369         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10370         earlier.
10371         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10372         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10373         instead of individual calls to trad_frame_set_reg_addr.
10374
10375 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10376
10377         * CONTRIBUTE: Replace contribution list with wiki link.
10378
10379 2019-01-25  Tom Tromey  <tom@tromey.com>
10380
10381         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10382
10383 2019-01-25  Tom Tromey  <tom@tromey.com>
10384
10385         * xtensa-linux-nat.c: Fix common/ includes.
10386         * xml-support.h: Fix common/ includes.
10387         * xml-support.c: Fix common/ includes.
10388         * x86-linux-nat.c: Fix common/ includes.
10389         * windows-nat.c: Fix common/ includes.
10390         * varobj.h: Fix common/ includes.
10391         * varobj.c: Fix common/ includes.
10392         * value.c: Fix common/ includes.
10393         * valops.c: Fix common/ includes.
10394         * utils.c: Fix common/ includes.
10395         * unittests/xml-utils-selftests.c: Fix common/ includes.
10396         * unittests/utils-selftests.c: Fix common/ includes.
10397         * unittests/unpack-selftests.c: Fix common/ includes.
10398         * unittests/tracepoint-selftests.c: Fix common/ includes.
10399         * unittests/style-selftests.c: Fix common/ includes.
10400         * unittests/string_view-selftests.c: Fix common/ includes.
10401         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10402         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10403         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10404         * unittests/rsp-low-selftests.c: Fix common/ includes.
10405         * unittests/parse-connection-spec-selftests.c: Fix common/
10406         includes.
10407         * unittests/optional-selftests.c: Fix common/ includes.
10408         * unittests/offset-type-selftests.c: Fix common/ includes.
10409         * unittests/observable-selftests.c: Fix common/ includes.
10410         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10411         * unittests/memrange-selftests.c: Fix common/ includes.
10412         * unittests/memory-map-selftests.c: Fix common/ includes.
10413         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10414         * unittests/function-view-selftests.c: Fix common/ includes.
10415         * unittests/environ-selftests.c: Fix common/ includes.
10416         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10417         * unittests/common-utils-selftests.c: Fix common/ includes.
10418         * unittests/cli-utils-selftests.c: Fix common/ includes.
10419         * unittests/array-view-selftests.c: Fix common/ includes.
10420         * ui-file.c: Fix common/ includes.
10421         * tui/tui-io.c: Fix common/ includes.
10422         * tracepoint.h: Fix common/ includes.
10423         * tracepoint.c: Fix common/ includes.
10424         * tracefile-tfile.c: Fix common/ includes.
10425         * top.h: Fix common/ includes.
10426         * top.c: Fix common/ includes.
10427         * thread.c: Fix common/ includes.
10428         * target/waitstatus.h: Fix common/ includes.
10429         * target/waitstatus.c: Fix common/ includes.
10430         * target.h: Fix common/ includes.
10431         * target.c: Fix common/ includes.
10432         * target-memory.c: Fix common/ includes.
10433         * target-descriptions.c: Fix common/ includes.
10434         * symtab.h: Fix common/ includes.
10435         * symfile.c: Fix common/ includes.
10436         * stap-probe.c: Fix common/ includes.
10437         * spu-linux-nat.c: Fix common/ includes.
10438         * sparc-nat.c: Fix common/ includes.
10439         * source.c: Fix common/ includes.
10440         * solib.c: Fix common/ includes.
10441         * solib-target.c: Fix common/ includes.
10442         * ser-unix.c: Fix common/ includes.
10443         * ser-tcp.c: Fix common/ includes.
10444         * ser-pipe.c: Fix common/ includes.
10445         * ser-base.c: Fix common/ includes.
10446         * selftest-arch.c: Fix common/ includes.
10447         * s12z-tdep.c: Fix common/ includes.
10448         * rust-exp.y: Fix common/ includes.
10449         * rs6000-aix-tdep.c: Fix common/ includes.
10450         * riscv-tdep.c: Fix common/ includes.
10451         * remote.c: Fix common/ includes.
10452         * remote-notif.h: Fix common/ includes.
10453         * remote-fileio.h: Fix common/ includes.
10454         * remote-fileio.c: Fix common/ includes.
10455         * regcache.h: Fix common/ includes.
10456         * regcache.c: Fix common/ includes.
10457         * record-btrace.c: Fix common/ includes.
10458         * python/python.c: Fix common/ includes.
10459         * python/py-type.c: Fix common/ includes.
10460         * python/py-inferior.c: Fix common/ includes.
10461         * progspace.h: Fix common/ includes.
10462         * producer.c: Fix common/ includes.
10463         * procfs.c: Fix common/ includes.
10464         * proc-api.c: Fix common/ includes.
10465         * printcmd.c: Fix common/ includes.
10466         * ppc-linux-nat.c: Fix common/ includes.
10467         * parser-defs.h: Fix common/ includes.
10468         * osdata.c: Fix common/ includes.
10469         * obsd-nat.c: Fix common/ includes.
10470         * nat/x86-linux.c: Fix common/ includes.
10471         * nat/x86-linux-dregs.c: Fix common/ includes.
10472         * nat/x86-dregs.h: Fix common/ includes.
10473         * nat/x86-dregs.c: Fix common/ includes.
10474         * nat/ppc-linux.c: Fix common/ includes.
10475         * nat/mips-linux-watch.h: Fix common/ includes.
10476         * nat/mips-linux-watch.c: Fix common/ includes.
10477         * nat/linux-waitpid.c: Fix common/ includes.
10478         * nat/linux-ptrace.h: Fix common/ includes.
10479         * nat/linux-ptrace.c: Fix common/ includes.
10480         * nat/linux-procfs.c: Fix common/ includes.
10481         * nat/linux-personality.c: Fix common/ includes.
10482         * nat/linux-osdata.c: Fix common/ includes.
10483         * nat/linux-namespaces.c: Fix common/ includes.
10484         * nat/linux-btrace.h: Fix common/ includes.
10485         * nat/linux-btrace.c: Fix common/ includes.
10486         * nat/fork-inferior.c: Fix common/ includes.
10487         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10488         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10489         * nat/aarch64-linux.c: Fix common/ includes.
10490         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10491         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10492         * namespace.h: Fix common/ includes.
10493         * mips-linux-tdep.c: Fix common/ includes.
10494         * minsyms.c: Fix common/ includes.
10495         * mi/mi-parse.h: Fix common/ includes.
10496         * mi/mi-main.c: Fix common/ includes.
10497         * mi/mi-cmd-env.c: Fix common/ includes.
10498         * memrange.h: Fix common/ includes.
10499         * memattr.c: Fix common/ includes.
10500         * maint.h: Fix common/ includes.
10501         * maint.c: Fix common/ includes.
10502         * main.c: Fix common/ includes.
10503         * machoread.c: Fix common/ includes.
10504         * location.c: Fix common/ includes.
10505         * linux-thread-db.c: Fix common/ includes.
10506         * linux-nat.c: Fix common/ includes.
10507         * linux-fork.c: Fix common/ includes.
10508         * inline-frame.c: Fix common/ includes.
10509         * infrun.c: Fix common/ includes.
10510         * inflow.c: Fix common/ includes.
10511         * inferior.h: Fix common/ includes.
10512         * inferior.c: Fix common/ includes.
10513         * infcmd.c: Fix common/ includes.
10514         * inf-ptrace.c: Fix common/ includes.
10515         * inf-child.c: Fix common/ includes.
10516         * ia64-linux-nat.c: Fix common/ includes.
10517         * i387-tdep.c: Fix common/ includes.
10518         * i386-tdep.c: Fix common/ includes.
10519         * i386-linux-tdep.c: Fix common/ includes.
10520         * i386-linux-nat.c: Fix common/ includes.
10521         * i386-go32-tdep.c: Fix common/ includes.
10522         * i386-fbsd-tdep.c: Fix common/ includes.
10523         * i386-fbsd-nat.c: Fix common/ includes.
10524         * guile/scm-type.c: Fix common/ includes.
10525         * guile/guile.c: Fix common/ includes.
10526         * go32-nat.c: Fix common/ includes.
10527         * gnu-nat.c: Fix common/ includes.
10528         * gdbthread.h: Fix common/ includes.
10529         * gdbarch-selftests.c: Fix common/ includes.
10530         * gdb_usleep.c: Fix common/ includes.
10531         * gdb_select.h: Fix common/ includes.
10532         * gdb_bfd.c: Fix common/ includes.
10533         * gcore.c: Fix common/ includes.
10534         * fork-child.c: Fix common/ includes.
10535         * findvar.c: Fix common/ includes.
10536         * fbsd-nat.c: Fix common/ includes.
10537         * event-top.c: Fix common/ includes.
10538         * event-loop.c: Fix common/ includes.
10539         * dwarf2read.c: Fix common/ includes.
10540         * dwarf2loc.c: Fix common/ includes.
10541         * dwarf2-frame.c: Fix common/ includes.
10542         * dwarf-index-cache.c: Fix common/ includes.
10543         * dtrace-probe.c: Fix common/ includes.
10544         * disasm-selftests.c: Fix common/ includes.
10545         * defs.h: Fix common/ includes.
10546         * csky-tdep.c: Fix common/ includes.
10547         * cp-valprint.c: Fix common/ includes.
10548         * cp-support.h: Fix common/ includes.
10549         * cp-support.c: Fix common/ includes.
10550         * corelow.c: Fix common/ includes.
10551         * completer.h: Fix common/ includes.
10552         * completer.c: Fix common/ includes.
10553         * compile/compile.c: Fix common/ includes.
10554         * compile/compile-loc2c.c: Fix common/ includes.
10555         * compile/compile-cplus-types.c: Fix common/ includes.
10556         * compile/compile-cplus-symbols.c: Fix common/ includes.
10557         * command.h: Fix common/ includes.
10558         * cli/cli-dump.c: Fix common/ includes.
10559         * cli/cli-cmds.c: Fix common/ includes.
10560         * charset.c: Fix common/ includes.
10561         * build-id.c: Fix common/ includes.
10562         * btrace.h: Fix common/ includes.
10563         * btrace.c: Fix common/ includes.
10564         * breakpoint.h: Fix common/ includes.
10565         * breakpoint.c: Fix common/ includes.
10566         * ax.h:
10567         (enum agent_op): Fix common/ includes.
10568         * ax-general.c (struct aop_map): Fix common/ includes.
10569         * ax-gdb.c: Fix common/ includes.
10570         * auxv.c: Fix common/ includes.
10571         * auto-load.c: Fix common/ includes.
10572         * arm-tdep.c: Fix common/ includes.
10573         * arch/riscv.c: Fix common/ includes.
10574         * arch/ppc-linux-common.c: Fix common/ includes.
10575         * arch/i386.c: Fix common/ includes.
10576         * arch/arm.c: Fix common/ includes.
10577         * arch/arm-linux.c: Fix common/ includes.
10578         * arch/arm-get-next-pcs.c: Fix common/ includes.
10579         * arch/amd64.c: Fix common/ includes.
10580         * arch/aarch64.c: Fix common/ includes.
10581         * arch/aarch64-insn.c: Fix common/ includes.
10582         * arch-utils.c: Fix common/ includes.
10583         * amd64-windows-tdep.c: Fix common/ includes.
10584         * amd64-tdep.c: Fix common/ includes.
10585         * amd64-sol2-tdep.c: Fix common/ includes.
10586         * amd64-obsd-tdep.c: Fix common/ includes.
10587         * amd64-nbsd-tdep.c: Fix common/ includes.
10588         * amd64-linux-tdep.c: Fix common/ includes.
10589         * amd64-linux-nat.c: Fix common/ includes.
10590         * amd64-fbsd-tdep.c: Fix common/ includes.
10591         * amd64-fbsd-nat.c: Fix common/ includes.
10592         * amd64-dicos-tdep.c: Fix common/ includes.
10593         * amd64-darwin-tdep.c: Fix common/ includes.
10594         * agent.c: Fix common/ includes.
10595         * ada-lang.h: Fix common/ includes.
10596         * ada-lang.c: Fix common/ includes.
10597         * aarch64-tdep.c: Fix common/ includes.
10598
10599 2019-01-25  Tom Tromey  <tom@tromey.com>
10600
10601         * common/create-version.sh: Use common/version.h.
10602
10603 2019-01-24  Pedro Alves  <palves@redhat.com>
10604
10605         * infrun.c (signal_stop, signal_print, signal_program)
10606         (signal_catch, signal_pass): Now arrays instead of pointers.
10607         (update_signals_program_target, do_target_resume)
10608         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10609         * linux-nat.c (linux_nat_target::pass_signals)
10610         (linux_nat_target::create_inferior, linux_nat_target::attach):
10611         Adjust.
10612         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10613         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10614         * procfs.c (procfs_target::pass_signals): Adjust.
10615         * record-full.c (record_full_target::resume): Adjust.
10616         * remote.c (remote_target::pass_signals)
10617         (remote_target::program_signals): Adjust.
10618         * target-debug.h (target_debug_print_signals): Now takes a
10619         gdb::array_view as parameter.  Adjust.
10620         * target.h (target_ops) <pass_signals, program_signals>: Replace
10621         pointer and length parameters with gdb::array_view.
10622         (target_pass_signals, target_program_signals): Likewise.
10623         * target-delegates.c: Regenerate.
10624
10625 2019-01-24  Pedro Alves  <palves@redhat.com>
10626
10627         * common/forward-scope-exit.h
10628         (forward_scope_exit::forward_scope_exit): Pass arguments to
10629         m_bind_function directly, instead of creating a std::bind and
10630         copying that.
10631
10632 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10633
10634         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10635         for static members.
10636         (pass_in_v_vfp_candidate): Likewise.
10637
10638 2019-01-23  Tom Tromey  <tom@tromey.com>
10639             Pedro Alves  <palves@redhat.com>
10640
10641         * regcache.c (class regcache_invalidator): Remove.
10642         (regcache::raw_write): Use make_scope_exit.
10643
10644 2019-01-23  Tom Tromey  <tom@tromey.com>
10645
10646         * ui-out.h (class ui_out_emit_type): Update comment.
10647
10648 2019-01-23  Tom Tromey  <tom@tromey.com>
10649
10650         * infrun.c (fetch_inferior_event): Update comment.
10651
10652 2019-01-23  Tom Tromey  <tom@tromey.com>
10653             Pedro Alves  <palves@redhat.com>
10654
10655         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10656         parameter.
10657         (fetch_inferior_event): Use SCOPE_EXIT.
10658
10659
10660 2019-01-23  Tom Tromey  <tom@tromey.com>
10661             Pedro Alves  <palves@redhat.com>
10662
10663         * infrun.c (disable_thread_events): Delete.
10664         (stop_all_threads): Use SCOPE_EXIT.
10665
10666 2019-01-23  Tom Tromey  <tom@tromey.com>
10667             Pedro Alves  <palves@redhat.com>
10668
10669         * symfile.c: Include forward-scope-exit.h.
10670         (clear_symtab_users_cleanup): Replace forward declaration with
10671         a FORWARD_SCOPE_EXIT.
10672         (syms_from_objfile_1): Use the forward_scope_exit and
10673         gdb::optional instead of cleanup_function.
10674         (reread_symbols): Use the forward_scope_exit instead of
10675         cleanup_function.
10676         (clear_symtab_users_cleanup): Remove function.
10677
10678 2019-01-23  Tom Tromey  <tom@tromey.com>
10679             Pedro Alves  <palves@redhat.com>
10680
10681         * linux-nat.c: Include scope-exit.h.
10682         (cleanup_target_stop): Remove.
10683         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10684         SCOPE_EXIT.
10685
10686 2019-01-23  Tom Tromey  <tom@tromey.com>
10687             Pedro Alves  <palves@redhat.com>
10688
10689         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10690         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10691
10692 2019-01-23  Tom Tromey  <tom@tromey.com>
10693             Andrew Burgess  <andrew.burgess@embecosm.com>
10694             Pedro Alves  <palves@redhat.com>
10695
10696         * infrun.c (fetch_inferior_event): Use scope_exit.
10697         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10698         * top.c (execute_command): Use scope_exit.
10699         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10700         * utils.c (do_bpstat_clear_actions_cleanup)
10701         (make_bpstat_clear_actions_cleanup): Remove.
10702
10703 2019-01-23  Tom Tromey  <tom@tromey.com>
10704             Pedro Alves  <palves@redhat.com>
10705
10706         * infrun.c: Include "common/scope-exit.h"
10707         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10708         (wait_for_inferior): Use SCOPE_EXIT.
10709         (fetch_inferior_event): Use scope_exit.
10710
10711 2019-01-23  Tom Tromey  <tom@tromey.com>
10712             Pedro Alves  <palves@redhat.com>
10713
10714         * breakpoint.c (create_breakpoint): Remove cleanup.
10715
10716 2019-01-23  Tom Tromey  <tom@tromey.com>
10717             Andrew Burgess  <andrew.burgess@embecosm.com>
10718             Pedro Alves  <palves@redhat.com>
10719
10720 2019-01-23  Pedro Alves  <palves@redhat.com>
10721
10722         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10723
10724 2019-01-23  Pedro Alves  <palves@redhat.com>
10725             Andrew Burgess  <andrew.burgess@embecosm.com>
10726
10727         * gdbthread.h: Include "common/forward-scope-exit.h".
10728         (scoped_finish_thread_state): Redefine custom class in terms of
10729         forward_scope_exit.
10730
10731 2019-01-23  Pedro Alves  <palves@redhat.com>
10732             Andrew Burgess  <andrew.burgess@embecosm.com>
10733
10734         * common/forward-scope-exit.h: New file.
10735
10736 2019-01-23  Pedro Alves  <palves@redhat.com>
10737             Andrew Burgess  <andrew.burgess@embecosm.com>
10738             Tom Tromey  <tom@tromey.com>
10739
10740         * common/scope-exit.h: New file.
10741
10742 2019-01-23  Pedro Alves  <palves@redhat.com>
10743
10744         * common/preprocessor.h (ESC): Rename to ...
10745         (ESC_PARENS): ... this.
10746         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10747         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10748
10749 2019-01-23  Tom Tromey  <tom@tromey.com>
10750
10751         * language.h (class scoped_switch_to_sym_language_if_auto):
10752         Initialize m_lang in both cases.
10753
10754 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10755
10756         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10757         with XCNEW.
10758
10759 2019-01-22  Tom Tromey  <tom@tromey.com>
10760
10761         * corelow.c: Do not include sys/file.h.
10762
10763 2019-01-22  Tom Tromey  <tom@tromey.com>
10764
10765         * tui/tui-wingeneral.h: Include gdb_curses.h.
10766
10767 2019-01-22  Tom Tromey  <tom@tromey.com>
10768
10769         * source-cache.h (class source_cache) <get_source_lines,
10770         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10771
10772 2019-01-22  Tom Tromey  <tom@tromey.com>
10773
10774         * remote-fileio.h (struct remote_target): Declare.
10775
10776 2019-01-22  Tom Tromey  <tom@tromey.com>
10777
10778         * python/py-arch.c: Do not include py-ref.h.
10779         * python/py-bpevent.c: Do not include py-ref.h.
10780         * python/py-cmd.c: Do not include py-ref.h.
10781         * python/py-continueevent.c: Do not include py-ref.h.
10782         * python/py-event.h: Do not include py-ref.h.
10783         * python/py-evtregistry.c: Do not include py-ref.h.
10784         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10785         * python/py-frame.c: Do not include py-ref.h.
10786         * python/py-framefilter.c: Do not include py-ref.h.
10787         * python/py-function.c: Do not include py-ref.h.
10788         * python/py-infevents.c: Do not include py-ref.h.
10789         * python/py-linetable.c: Do not include py-ref.h.
10790         * python/py-objfile.c: Do not include py-ref.h.
10791         * python/py-param.c: Do not include py-ref.h.
10792         * python/py-prettyprint.c: Do not include py-ref.h.
10793         * python/py-progspace.c: Do not include py-ref.h.
10794         * python/py-symbol.c: Do not include py-ref.h.
10795         * python/py-symtab.c: Do not include py-ref.h.
10796         * python/py-type.c: Do not include py-ref.h.
10797         * python/py-unwind.c: Do not include py-ref.h.
10798         * python/py-utils.c: Do not include py-ref.h.
10799         * python/py-value.c: Do not include py-ref.h.
10800         * python/py-varobj.c: Do not include py-ref.h.
10801         * python/py-xmethods.c: Do not include py-ref.h.
10802         * python/python.c: Do not include py-ref.h.
10803         * varobj.c: Do not include py-ref.h.
10804
10805 2019-01-22  Tom Tromey  <tom@tromey.com>
10806
10807         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10808         keyword for bcache.
10809
10810 2019-01-22  Tom Tromey  <tom@tromey.com>
10811
10812         * compile/compile-cplus-types.c: Remove a comment by #include.
10813
10814 2019-01-22  Tom Tromey  <tom@tromey.com>
10815
10816         * compile/gcc-c-plugin.h: Include compile-internal.h.
10817
10818 2019-01-22  Tom Tromey  <tom@tromey.com>
10819
10820         * stabsread.c (EXTERN): Do not define.
10821         (symnum, next_symbol_text_func, processing_gcc_compilation)
10822         (within_function, global_sym_chain, global_stabs)
10823         (previous_stab_code, this_object_header_files)
10824         (n_this_object_header_files)
10825         (n_allocated_this_object_header_files): Define.
10826         * stabsread.h (EXTERN): Never define.  Use "extern".
10827
10828 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10829
10830         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10831         history_value.
10832
10833 2019-01-21  Tom Tromey  <tom@tromey.com>
10834
10835         * ui-out.c: Fix includes.
10836         * tui/tui-source.c: Fix includes.
10837         * target.c: Fix includes.
10838         * remote.c: Fix includes.
10839         * regcache.c: Fix includes.
10840         * python/py-block.c: Fix includes.
10841         * printcmd.c: Fix includes.
10842         * or1k-tdep.c: Fix includes.
10843         * mi/mi-main.c: Fix includes.
10844         * m32r-tdep.c: Fix includes.
10845         * csky-tdep.c: Fix includes.
10846         * compile/compile-cplus-types.c: Fix includes.
10847         * cli/cli-interp.c: Fix includes.
10848
10849 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10850
10851         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10852         for padding.
10853
10854 2019-01-16  Tom Tromey  <tom@tromey.com>
10855
10856         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10857         earlier.
10858         (struct objfile) <msymbols_range>: Move from top level.
10859         <msymbols>: New method.
10860         (class objfile_msymbols): Remove.
10861         * symtab.c (default_collect_symbol_completion_matches_break_on):
10862         Update.
10863         * symmisc.c (dump_msymbols): Update.
10864         * stabsread.c (scan_file_globals): Update.
10865         * objc-lang.c (info_selectors_command, info_classes_command)
10866         (find_methods): Update.
10867         * minsyms.c (find_solib_trampoline_target): Update.
10868         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10869         * coffread.c (coff_symfile_read): Update.
10870         * ada-lang.c (ada_lookup_simple_minsym)
10871         (ada_collect_symbol_completion_matches): Update.
10872
10873 2019-01-16  Tom Tromey  <tom@tromey.com>
10874
10875         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10876         type.  Remove no-argument constructor.
10877         <iterator::operator++>: Simplify.
10878         <begin>: Update.
10879         <end>: Use minimal_symbol_count.
10880
10881 2019-01-16  Tom Tromey  <tom@tromey.com>
10882
10883         * objfiles.h (struct objfile) <psymtabs>: New method.
10884         (class objfile_psymtabs): Remove.
10885         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10886         typedef.
10887         <range>: New method.
10888         (require_partial_symbols): Change return type.
10889         * psymtab.c (require_partial_symbols)
10890         (psym_expand_symtabs_matching): Update.
10891         * mdebugread.c (parse_partial_symbols): Update.
10892         * dbxread.c (dbx_end_psymtab): Update.
10893
10894 2019-01-15  Tom Tromey  <tom@tromey.com>
10895
10896         * symtab.c (lookup_objfile_from_block)
10897         (lookup_symbol_in_objfile_symtabs)
10898         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10899         (find_line_symtab, info_sources_command)
10900         (default_collect_symbol_completion_matches_break_on)
10901         (make_source_files_completion_list): Update.
10902         * symmisc.c (print_objfile_statistics, dump_objfile)
10903         (maintenance_print_symbols, maintenance_info_symtabs)
10904         (maintenance_check_symtabs, maintenance_info_line_tables):
10905         Update.
10906         * source.c (select_source_symtab)
10907         (forget_cached_source_info_for_objfile): Update.
10908         * objfiles.h (class objfile_compunits): Remove.
10909         (struct objfile) <compunits_range>: New typedef.
10910         (compunits): New method.
10911         * objfiles.c (objfile_relocate1): Update.
10912         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10913         * maint.c (count_symtabs_and_blocks): Update.
10914         * linespec.c (iterate_over_all_matching_symtabs): Update.
10915         * cp-support.c (add_symbol_overload_list_qualified): Update.
10916         * coffread.c (coff_symtab_read): Update.
10917         * ada-lang.c (add_nonlocal_symbols)
10918         (ada_collect_symbol_completion_matches)
10919         (ada_add_global_exceptions): Update.
10920
10921 2019-01-15  Tom Tromey  <tom@tromey.com>
10922
10923         * progspace.h (program_space) <objfiles_safe_range>: New
10924         typedef.
10925         <objfiles_safe>: New method.
10926         * objfiles.h (class all_objfiles_safe): Remove.
10927         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10928         * jit.c (jit_inferior_exit_hook): Update.
10929
10930 2019-01-17  Tom Tromey  <tom@tromey.com>
10931
10932         * progspace.h (program_space) <objfiles_range>: New typedef.
10933         <objfiles>: New method.
10934         <objfiles_head>: Rename from objfiles.
10935         (object_files): Update.
10936         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10937         * guile/scm-pretty-print.c
10938         (ppscm_find_pretty_printer_from_objfiles): Update.
10939         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10940         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10941         Update.
10942         * python/py-progspace.c (pspy_get_objfiles): Update.
10943         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10944         Update.
10945         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10946         (objfpy_lookup_objfile_by_build_id): Update.
10947         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10948         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10949         Update.
10950         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10951         (expand_symtab_containing_pc, lookup_objfile_from_block)
10952         (lookup_static_symbol, basic_lookup_transparent_type)
10953         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10954         (find_line_symtab, info_sources_command)
10955         (default_collect_symbol_completion_matches_break_on)
10956         (make_source_files_completion_list, find_main_name): Update.
10957         * symmisc.c (print_symbol_bcache_statistics)
10958         (print_objfile_statistics, maintenance_print_symbols)
10959         (maintenance_print_msymbols, maintenance_print_objfiles)
10960         (maintenance_info_symtabs, maintenance_check_symtabs)
10961         (maintenance_expand_symtabs, maintenance_info_line_tables):
10962         Update.
10963         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10964         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10965         (map_overlay_command, unmap_overlay_command)
10966         (simple_overlay_update, expand_symtabs_matching)
10967         (map_symbol_filenames): Update.
10968         * symfile-debug.c (set_debug_symfile): Update.
10969         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10970         Update.
10971         * source.c (select_source_symtab, forget_cached_source_info):
10972         Update.
10973         * solib.c (solib_read_symbols): Update.
10974         * solib-spu.c (append_ocl_sos): Update.
10975         * psymtab.c (maintenance_print_psymbols)
10976         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10977         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10978         * printcmd.c (info_symbol_command): Update.
10979         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10980         Update.
10981         * objfiles.h (class all_objfiles): Remove.
10982         * objfiles.c (have_partial_symbols, have_full_symbols)
10983         (have_minimal_symbols, qsort_cmp, update_section_map)
10984         (shared_objfile_contains_address_p)
10985         (default_iterate_over_objfiles_in_search_order): Update.
10986         * objc-lang.c (info_selectors_command, info_classes_command)
10987         (find_methods): Update.
10988         * minsyms.c (find_solib_trampoline_target): Update.
10989         * maint.c (maintenance_info_sections)
10990         (maintenance_translate_address, count_symtabs_and_blocks):
10991         Update.
10992         * main.c (captured_main_1): Update.
10993         * linux-thread-db.c (try_thread_db_load_from_pdir)
10994         (has_libpthread): Update.
10995         * linespec.c (iterate_over_all_matching_symtabs)
10996         (search_minsyms_for_name): Update.
10997         * jit.c (jit_find_objf_with_entry_addr): Update.
10998         * hppa-tdep.c (find_unwind_entry)
10999         (hppa_lookup_stub_minimal_symbol): Update.
11000         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11001         Update.
11002         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11003         (elf_gnu_ifunc_resolve_by_got): Update.
11004         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11005         * dwarf-index-write.c (save_gdb_index_command): Update.
11006         * cp-support.c (add_symbol_overload_list_qualified): Update.
11007         * breakpoint.c (create_overlay_event_breakpoint)
11008         (create_longjmp_master_breakpoint)
11009         (create_std_terminate_master_breakpoint)
11010         (create_exception_master_breakpoint): Update.
11011         * blockframe.c (find_pc_partial_function): Update.
11012         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11013         (ada_collect_symbol_completion_matches)
11014         (ada_add_global_exceptions): Update.
11015
11016 2019-01-17  Tom Tromey  <tom@tromey.com>
11017
11018         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11019         declare VEC.
11020         (solib_target_parse_libraries): Change return type.
11021         (library_list_start_segment, library_list_start_section)
11022         (library_list_end_library, library_list_start_library); Update.
11023         (solib_target_free_library_list): Remove.
11024         (solib_target_parse_libraries): Remove cleanup.  Change return
11025         type.
11026         (solib_target_current_sos): Update.
11027
11028 2019-01-17  Tom Tromey  <tromey@bapiya>
11029
11030         * valprint.c: Replace "the the" with "the".
11031         * symtab.c: Replace "the the" with "the".
11032         * solib.c: Replace "the the" with "the".
11033         * solib-dsbt.c: Replace "the the" with "the".
11034         * linespec.c: Replace "the the" with "the".
11035         * dwarf2loc.h: Replace "the the" with "the".
11036         * amd64-windows-tdep.c: Replace "the the" with "the".
11037         * aarch64-tdep.c: Replace "the the" with "the".
11038
11039 2019-01-16  Keith Seitz  <keiths@redhat.com>
11040
11041         PR gdb/23773
11042         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11043         <builder>: Rename to ..
11044         <m_builder>: ... this and make private.
11045         (dwarf2_cu::get_builder): New method.  Change all users of
11046         `builder' to use this method.
11047         (dwarf2_start_symtab): Move to ...
11048         (dwarf2_cu::start_symtab): ... here.  Update all callers
11049         (setup_type_unit_groups): Move to ...
11050         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11051         callers.
11052         (dwarf2_cu::reset_builder): New method.
11053         (process_full_compunit, process_full_type_unit): Use
11054         dwarf2_cu::reset_builder.
11055         (follow_die_offset): Record the ancestor CU if it is different
11056         from the followed DIE's CU.
11057         (follow_die_sig_1): Likewise.
11058
11059 2019-01-15  Tom Tromey  <tom@tromey.com>
11060
11061         * remote.c (class remote_state) <buf>: Now a char_vector.
11062         <buf_size>: Remove.
11063         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11064         parameter.
11065         (remote_target::getpkt_or_notif_sane_1)
11066         (remote_target::getpkt_sane)
11067         (remote_target::getpkt_or_notif_sane): Likewise.
11068         (class remote_target) <putpkt>: New overload.
11069         (remote_target::read_frame): Change type of "buf_p".  Remove
11070         sizeof_p parameter.
11071         (packet_ok): New overload.
11072         (packet_check_result): New overload.
11073         Update all uses.
11074
11075 2019-01-14  Tom Tromey  <tom@tromey.com>
11076
11077         * remote-notif.c (handle_notification, remote_notif_ack)
11078         (remote_notif_parse): Make "buf" const.
11079         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11080         const.
11081         (remote_notif_parse, remote_notif_ack, handle_notification):
11082         Likewise.
11083         * remote.c (remote_notif_stop_parse): Make "buf" const.
11084         (remote_target::remote_parse_stop_reply): Make "buf" const.
11085         (remote_notif_stop_ack): Make "buf" const.
11086
11087 2019-01-14  Tom Tromey  <tom@tromey.com>
11088
11089         * remote.c (remote_console_output): Make parameter const.
11090
11091 2019-01-14  Tom Tromey  <tom@tromey.com>
11092
11093         * target-debug.h (target_debug_print_signals): Constify.
11094         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11095         * procfs.c (procfs_target::pass_signals): Update.
11096         * linux-nat.c (linux_nat_target::pass_signals): Update.
11097         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11098         * target-delegates.c: Rebuild.
11099         * remote.c (remote_target::program_signals): Update.
11100         (remote_target::pass_signals): Update.
11101         * target.c (target_pass_signals): Constify argument.
11102         (target_program_signals): Likewise.
11103         * target.h (struct target_ops) <pass_signals, program_signals>:
11104         Constify argument.
11105         (target_pass_signals, target_program_signals): Constify argument.
11106
11107 2019-01-14  Tom Tromey  <tom@tromey.com>
11108
11109         PR tui/28819:
11110         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11111
11112 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11113
11114         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11115         field.
11116         * rs6000-tdep.c: Include reggroups.h.
11117         (IS_V_ALIAS_PSEUDOREG): Define.
11118         (rs6000_register_name): Return names for the "vX" aliases.
11119         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11120         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11121         aliases.  Call default_register_reggroup_p for all other
11122         pseudo-registers.
11123         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11124         New functions.
11125         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11126         Handle "vX" aliases.
11127         (v_alias_pseudo_register_collect): New function.
11128         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11129         (rs6000_gdbarch_init): Initialize "vX" aliases as
11130         pseudo-registers.  Restore registration of
11131         rs6000_pseudo_register_reggroup_p with
11132         set_tdesc_pseudo_register_reggroup_p.
11133
11134 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11135
11136         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11137         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11138         set_gdbarch_num_pseudo_regs.
11139
11140 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11141
11142         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11143         Remove arg prefixname, add do_set and do_show.
11144         Add member functions set_list and show_list.
11145         * cli/cli-style.c (class cli_style_option): Update accordingly.
11146         (style_set_list): Move to file scope.
11147         (style_show_list): Likewise.
11148         (set_style): Call help_list.
11149         (show_style): Call cmd_show_list.
11150         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11151         Update to use the new macro.
11152
11153 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11154
11155         * ada-lang.c (_initialize_ada_language): Expand the help text
11156         for the "catch exception" command.
11157
11158 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11159
11160         * symtab.c (matching_obj_sections): Initialize obj,
11161         declare it closer to its usage.
11162
11163 2019-01-10  Tom Tromey  <tom@tromey.com>
11164
11165         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11166         (basic_inf_threads_range): Remove.
11167         (inf_threads_range, inf_non_exited_threads_range)
11168         (safe_inf_threads_range): Use next_adapter.
11169
11170 2019-01-10  Keith Seitz  <keiths@redhat.com>
11171
11172         PR gdb/23712
11173         PR symtab/23010
11174         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11175         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11176
11177 2019-01-10  Keith Seitz  <keiths@redhat.com>
11178
11179         PR gdb/23712
11180         PR symtab/23010
11181         * dictionary.c (pending_to_vector): Remove.
11182         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11183         Remove _1 suffix, replacing functions of the same name.  Update
11184         all callers.
11185         (dict_create_hashed, dict_create_hashed_expandable)
11186         (dict_create_linear, dict_create_linear_expandable, dict_free)
11187         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11188         Make functions static.
11189
11190 2019-01-10  Keith Seitz  <keiths@redhat.com>
11191
11192         PR gdb/23712
11193         PR symtab/23010
11194         * dictionary.h (struct dictionary): Replace declaration with
11195         multidictionary.
11196         (dict_create_hashed, dict_create_hashed_expandable)
11197         (dict_create_linear, dict_create_linear_expandable)
11198         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11199         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11200         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11201         taking multidictionary argument.
11202         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11203         * block.h (struct block) <dict>: Change to multidictionary
11204         and rename `multidict'.
11205         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11206         symmisc.c: Update all dictionary references to multidictionary.
11207
11208 2019-01-10  Keith Seitz  <keiths@redhat.com>
11209
11210         PR gdb/23712
11211         PR symtab/23010
11212         * dictionary.c: Include unordered_map.
11213         (pending_to_vector): New function.
11214         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11215         Rewrite the non-"_1" functions to take vector instead
11216         of linked list.
11217         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11218         "new" _1 versions of the same name.
11219         (multidictionary): Define.
11220         (std::hash<enum language): New definition.
11221         (collate_pending_symbols_by_language, mdict_create_hashed)
11222         (mdict_create_hashed_expandable, mdict_create_linear)
11223         (mdict_create_linear_expandable, mdict_free)
11224         (find_language_dictionary, create_new_language_dictionary)
11225         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11226         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11227         (mdict_size, mdict_empty): New functions.
11228         * dictionary.h (mdict_iterator): Define.
11229
11230 2019-01-10  Pedro Alves  <palves@redhat.com>
11231
11232         * breakpoint.c (read_uploaded_action)
11233         (create_tracepoint_from_upload): Adjust to use
11234         gdb::unique_xmalloc_ptr.
11235         * ctf.c (ctf_write_uploaded_tp):
11236         (SET_ARRAY_FIELD): Use emplace_back.
11237         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11238         * tracefile-tfile.c (tfile_write_uploaded_tp):
11239         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11240         gdb::unique_xmalloc_ptr.
11241         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11242         at_string, cond_string, cmd_strings>: Replace char pointers
11243         with gdb::unique_xmalloc_ptr.
11244
11245 2019-01-10  Pedro Alves  <palves@redhat.com>
11246
11247         * solib-target.c (library_list_start_library): Don't xstrdup name.
11248
11249 2019-01-10  Pedro Alves  <palves@redhat.com>
11250
11251         * mdebugread.c (parse_partial_symbols): Use
11252         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11253
11254 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11255
11256         * linux-fork.c (scoped_switch_fork_info)
11257         <~scoped_switch_fork_info>: Fix incorrect variable name.
11258
11259 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11260
11261         * linux-fork.c (scoped_switch_fork_info)
11262         <scoped_switch_fork_info>: Make explicit.
11263         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11264
11265 2019-01-10  Tom Tromey  <tom@tromey.com>
11266
11267         * objfiles.h (objfile::reset_psymtabs): Update.
11268         * objfiles.c (objfile::objfile): Update.
11269         * psymtab.h (psymtab_storage::obstack): Update.
11270         (psymtab_storage::m_obstack): Use gdb::optional.
11271         (class psymtab_storage): Update comment.  Remove objfile
11272         parameter.
11273         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11274
11275 2019-01-10  Tom Tromey  <tom@tromey.com>
11276
11277         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11278         <free_psymtabs>: Now private.
11279         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11280         (allocate_psymtab): Use new method.
11281
11282 2019-01-10  Tom Tromey  <tom@tromey.com>
11283
11284         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11285         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11286         * mdebugread.c (parse_partial_symbols): Use
11287         allocate_dependencies.
11288         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11289         allocate_dependencies.
11290         (process_psymtab_comp_unit_reader)
11291         (build_type_psymtab_dependencies): Likewise.
11292         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11293
11294 2019-01-10  Tom Tromey  <tom@tromey.com>
11295
11296         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11297         PSYMBOL_SET_LANGUAGE.
11298         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11299
11300 2019-01-10  Tom Tromey  <tom@tromey.com>
11301
11302         * psymtab.h (psymtab_storage::obstack): New method.
11303         <m_obstack>: Rename from obstack; now private.
11304         * psymtab.c (psymtab_storage): Update.
11305         * dwarf2read.c (create_addrmap_from_index)
11306         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11307         Update.
11308
11309 2019-01-10  Tom Tromey  <tom@tromey.com>
11310
11311         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11312         * objfiles.h (objfile::reset_psymtabs): New method.
11313
11314 2019-01-10  Tom Tromey  <tom@tromey.com>
11315
11316         * symmisc.c (print_symbol_bcache_statistics): Update.
11317         (print_objfile_statistics): Update.
11318         * symfile.c (reread_symbols): Update.
11319         * psymtab.h (class psymtab_storage): New.
11320         * psymtab.c (psymtab_storage): New constructor.
11321         (~psymtab_storage): New destructor.
11322         (require_partial_symbols): Update.
11323         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11324         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11325         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11326         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11327         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11328         (start_psymtab_common, end_psymtab_common)
11329         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11330         (allocate_psymtab): Update.
11331         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11332         Update.
11333         (dump_psymtab_addrmap, maintenance_print_psymbols)
11334         (maintenance_check_psymtabs): Update.
11335         (class objfile_psymtabs): Move to objfiles.h.
11336         * psympriv.h (discard_psymtab): Now inline.
11337         (psymtab_discarder::psymtab_discarder): Update.
11338         (psymtab_discarder::~psymtab_discarder): Update.
11339         (ALL_OBJFILE_PSYMTABS): Rewrite.
11340         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11341         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11342         Remove fields.
11343         <partial_symtabs>: New field.
11344         (class objfile_psymtabs): Move from psymtab.h.  Update.
11345         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11346         psymbol_cache.
11347         (objfile::~objfile): Don't destroy psymbol_cache.
11348         * mdebugread.c (parse_partial_symbols): Update.
11349         * dwarf2read.c (create_addrmap_from_index)
11350         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11351         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11352         (add_partial_subprogram, dwarf2_ranges_read): Update.
11353         * dwarf-index-write.c (write_address_map)
11354         (write_one_signatured_type, recursively_write_psymbols)
11355         (class debug_names, class debug_names, write_psymtabs_to_index):
11356         Update.
11357
11358 2019-01-10  Tom Tromey  <tom@tromey.com>
11359
11360         * symtab.h (SYMBOL_SET_NAMES): Update.
11361         (symbol_set_names): Update.
11362         (MSYMBOL_SET_NAMES): Update.
11363         * symtab.c (symbol_set_names): Change argument to be an
11364         objfile_per_bfd_storage.
11365         * psymtab.c (add_psymbol_to_bcache): Update.
11366         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11367
11368 2019-01-10  Tom Tromey  <tom@tromey.com>
11369
11370         * symtab.c (create_demangled_names_hash): Change argument to be an
11371         objfile_per_bfd_storage.
11372         (symbol_set_names): Update.
11373
11374 2019-01-10  Tom Tromey  <tom@tromey.com>
11375
11376         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11377         init_psymbol_list.
11378         * psymtab.c (init_psymbol_list): Do nothing if already called.
11379         * psympriv.h (init_psymbol_list): Add comment.
11380         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11381         init_psymbol_list.
11382         * dbxread.c (dbx_symfile_read): Unconditionally call
11383         init_psymbol_list.
11384
11385 2019-01-10  Tom Tromey  <tom@tromey.com>
11386
11387         * xcoffread.c (scan_xcoff_symtab): Update.
11388         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11389         "where".
11390         * mdebugread.c (parse_partial_symbols)
11391         (handle_psymbol_enumerators): Update.
11392         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11393         * dbxread.c (read_dbx_symtab): Update.
11394         * psympriv.h (psymbol_placement): New enum.
11395         (add_psymbol_to_list): Update.
11396
11397 2019-01-10  Tom Tromey  <tom@tromey.com>
11398
11399         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11400         static_psymbols parameters.
11401         (scan_xcoff_symtab): Update.
11402         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11403         static_psymbols parameters.
11404         * psympriv.h (start_psymtab_common): Update.
11405         * mdebugread.c (parse_partial_symbols): Update.
11406         * dwarf2read.c (create_partial_symtab): Update.
11407         * dbxread.c (read_dbx_symtab): Update.
11408         (start_psymtab): Remove global_psymbols and static_psymbols
11409         parameters.
11410
11411 2019-01-10  Tom Tromey  <tom@tromey.com>
11412
11413         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11414         * psymtab.c (allocate_psymtab): Add comment.
11415         * psympriv.h (allocate_psymtab): Add comment.
11416         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11417         initializations.
11418         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11419
11420 2019-01-10  Tom Tromey  <tom@tromey.com>
11421
11422         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11423         Don't declare.
11424         * mipsread.c: Include mdebugread.h.
11425         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11426         Declare.
11427         * elfread.c: Include mdebugread.h.
11428
11429 2019-01-09  Tom Tromey  <tom@tromey.com>
11430
11431         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11432         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11433         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11434         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11435         (psym_lookup_symbol, psym_find_last_source_symtab)
11436         (psym_forget_cached_source_info, psym_print_stats)
11437         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11438         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11439         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11440         (psym_find_compunit_symtab_by_address)
11441         (maintenance_print_psymbols, maintenance_info_psymtabs)
11442         (maintenance_check_psymtabs): Use ranged for.
11443         * psymtab.h (class objfile_psymtabs): New.
11444         (require_partial_symbols): Return objfile_psymtabs.
11445         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11446
11447 2019-01-09  Tom Tromey  <tom@tromey.com>
11448
11449         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11450         (find_pc_mapped_section, list_overlays_command)
11451         (map_overlay_command, unmap_overlay_command)
11452         (simple_overlay_update): Use all_objfiles.
11453         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11454         * printcmd.c (info_symbol_command): Use all_objfiles.
11455         * objfiles.h (ALL_OBJSECTIONS): Remove.
11456         * maint.c (maintenance_translate_address): Use all_objfiles.
11457         * gcore.c (gcore_create_callback): Use all_objfiles.
11458         (objfile_find_memory_regions): Likewise.
11459
11460 2019-01-09  Tom Tromey  <tom@tromey.com>
11461
11462         * symtab.c (find_line_symtab, info_sources_command)
11463         (make_source_files_completion_list): Use objfile_compunits.
11464         * source.c (select_source_symtab): Use objfile_compunits.
11465         * objfiles.h (struct objfile): Update comment.
11466         (ALL_OBJFILES): Remove.
11467         (ALL_FILETABS): Remove.
11468         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11469         objfile_compunits.
11470
11471 2019-01-09  Tom Tromey  <tom@tromey.com>
11472
11473         * symmisc.c (print_objfile_statistics, dump_objfile)
11474         (maintenance_print_symbols): Use compunit_filetabs.
11475         * source.c (forget_cached_source_info_for_objfile): Use
11476         compunit_filetabs.
11477         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11478         (ALL_FILETABS): Use compunit_filetabs.
11479         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11480         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11481
11482 2019-01-09  Tom Tromey  <tom@tromey.com>
11483
11484         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11485         (compunit_filetabs): New.
11486         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11487         compunit_filetabs.
11488         (info_sources_command, make_source_files_completion_list): Remove
11489         declaration.
11490         * symmisc.c (print_objfile_statistics, dump_objfile)
11491         (maintenance_print_symbols): Remove declaration.
11492         (maintenance_info_symtabs): Use compunit_filetabs.
11493         (maintenance_info_line_tables): Likewise.
11494         * source.c (select_source_symtab): Change local variable name.
11495         (forget_cached_source_info_for_objfile): Remove declaration.
11496         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11497         * objfiles.c (objfile_relocate1): Remove declaration.
11498         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11499         declaration.
11500         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11501         * coffread.c (coff_symtab_read): Remove declaration.
11502         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11503         compunit_filetabs.
11504
11505 2019-01-09  Tom Tromey  <tom@tromey.com>
11506
11507         * symtab.c (lookup_objfile_from_block)
11508         (find_pc_sect_compunit_symtab, search_symbols)
11509         (default_collect_symbol_completion_matches_break_on): Use
11510         objfile_compunits.
11511         * objfiles.h (ALL_COMPUNITS): Remove.
11512         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11513         * cp-support.c (add_symbol_overload_list_qualified): Use
11514         objfile_compunits.
11515         * ada-lang.c (ada_collect_symbol_completion_matches)
11516         (ada_add_global_exceptions): Use objfile_compunits.
11517
11518 2019-01-09  Tom Tromey  <tom@tromey.com>
11519
11520         * source.c (select_source_symtab)
11521         (forget_cached_source_info_for_objfile): Remove declaration.
11522         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11523         declaration.
11524         * maint.c (count_symtabs_and_blocks): Remove declaration.
11525         * cp-support.c (add_symbol_overload_list_qualified): Remove
11526         declaration.
11527         * coffread.c (coff_symtab_read): Remove declaration.
11528         * symtab.c (lookup_symbol_in_objfile_symtabs)
11529         (basic_lookup_transparent_type_1): Use objfile_compunits.
11530         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11531         (info_sources_command, search_symbols)
11532         (default_collect_symbol_completion_matches_break_on)
11533         (make_source_files_completion_list): Remove declaration.
11534         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11535         (ada_collect_symbol_completion_matches)
11536         (ada_add_global_exceptions): Remove declaration.
11537         * linespec.c (iterate_over_all_matching_symtabs): Use
11538         objfile_compunits.
11539         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11540         (class objfile_compunits): New.
11541         (ALL_COMPUNITS): Use objfile_compunits.
11542         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11543         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11544         objfile_compunits.
11545         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11546
11547 2019-01-09  Tom Tromey  <tom@tromey.com>
11548
11549         * symtab.c (search_symbols)
11550         (default_collect_symbol_completion_matches_break_on): Use
11551         objfile_msymbols.
11552         * ada-lang.c (ada_lookup_simple_minsym)
11553         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11554         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11555         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11556         objfile_msymbols.
11557         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11558         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11559         * objc-lang.c (find_methods): Use objfile_msymbols.
11560         (info_selectors_command, info_classes_command): Likewise.
11561         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11562         * objfiles.h (class objfile_msymbols): New.
11563         (ALL_OBJFILE_MSYMBOLS): Remove.
11564         (ALL_MSYMBOLS): Remove.
11565
11566 2019-01-09  Tom Tromey  <tom@tromey.com>
11567
11568         * common/next-iterator.h (next_adapter): Add Iterator template
11569         parameter.
11570         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11571         (class all_objfiles_safe): New.
11572         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11573         * objfiles.c (put_objfile_before): Update comment.
11574         (add_separate_debug_objfile): Likewise.
11575         (free_all_objfiles): Use all_objfiles_safe.
11576         (objfile_purge_solibs): Likewise.
11577
11578 2019-01-09  Tom Tromey  <tom@tromey.com>
11579
11580         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11581         (expand_symtab_containing_pc, lookup_static_symbol)
11582         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11583         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11584         all_objfiles.
11585         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11586         * breakpoint.c (create_overlay_event_breakpoint)
11587         (create_longjmp_master_breakpoint)
11588         (create_std_terminate_master_breakpoint)
11589         (create_exception_master_breakpoint): Use all_objfiles.
11590         * linux-thread-db.c (try_thread_db_load_from_pdir)
11591         (has_libpthread): Use all_objfiles.
11592         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11593         * linespec.c (iterate_over_all_matching_symtabs)
11594         (search_minsyms_for_name): Use all_objfiles.
11595         * maint.c (maintenance_info_sections): Use all_objfiles.
11596         * main.c (captured_main_1): Use all_objfiles.
11597         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11598         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11599         * guile/scm-pretty-print.c
11600         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11601         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11602         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11603         (maintenance_print_msymbols): Use all_objfiles.
11604         * source.c (select_source_symtab): Use all_objfiles.
11605         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11606         * symfile.c (remove_symbol_file_command)
11607         (expand_symtabs_matching, map_symbol_filenames): Use
11608         all_objfiles.
11609         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11610         all_objfiles.
11611         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11612         * objc-lang.c (find_methods): Use all_objfiles.
11613         * objfiles.c (have_partial_symbols, have_full_symbols)
11614         (have_minimal_symbols, qsort_cmp)
11615         (default_iterate_over_objfiles_in_search_order): Use
11616         all_objfiles.
11617         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11618         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11619         (maintenance_check_psymtabs): Use all_objfiles.
11620         (ALL_PSYMTABS): Remove.
11621         * compile/compile-object-run.c (do_module_cleanup): Use
11622         all_objfiles.
11623         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11624         * cp-support.c (add_symbol_overload_list_qualified): Use
11625         all_objfiles.
11626         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11627         Use all_objfiles.
11628         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11629         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11630         all_objfiles.
11631         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11632         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11633         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11634         Uses all_objfiles.
11635         * solib.c (solib_read_symbols): Use all_objfiles
11636
11637 2019-01-09  Tom Tromey  <tom@tromey.com>
11638
11639         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11640         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11641         all_objfiles.
11642         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11643         * symmisc.c (print_symbol_bcache_statistics)
11644         (print_objfile_statistics, maintenance_print_objfiles)
11645         (maintenance_info_symtabs, maintenance_check_symtabs)
11646         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11647         all_objfiles.
11648         * source.c (forget_cached_source_info): Use all_objfiles.
11649         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11650         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11651         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11652         * objfiles.c (update_section_map): Use all_objfiles.
11653         (shared_objfile_contains_address_p): Likewise.
11654         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11655         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11656
11657 2019-01-09  Tom Tromey  <tom@tromey.com>
11658
11659         * common/next-iterator.h: New file.
11660         * objfiles.h (class all_objfiles): New.
11661         (struct objfile_iterator): New.
11662
11663 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11664
11665         * NEWS: Move the description of the changed "frame", "select-frame",
11666          and "info frame" commands to the Changed commands section.
11667
11668 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11669
11670         * gdbtypes.c (check_stub_method_group): Remove handling of old
11671         mangling schemes.
11672         * linespec.c (find_methods): Likewise.
11673         * stabsread.c (read_member_functions): Likewise.
11674         * valops.c (search_struct_method): Likewise.
11675         (value_struct_elt_for_reference): Likewise.
11676         * NEWS: Mention this change.
11677
11678 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11679
11680         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11681         print_source_lines.
11682         * source.c (print_source_lines_base): Update line number check.
11683         (print_source_lines): New function.
11684         (source_lines_range::source_lines_range): New function.
11685         * source.h (class source_lines_range): New class.
11686         (print_source_lines): New declaration.
11687
11688 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11689
11690         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11691
11692 2019-01-08  Tom Tromey  <tom@tromey.com>
11693             Simon Marchi  <simon.marchi@ericsson.com>
11694
11695         PR gdb/24060
11696         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11697         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11698         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11699         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11700         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11701         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11702
11703 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11704
11705         * source.c (select_source_symtab): Move header comment to
11706         declaration in source.h.
11707         (forget_cached_source_info_for_objfile): Likewise.
11708         (forget_cached_source_info): Likewise.
11709         (identify_source_line): Likewise.
11710         * source.h (identify_source_line): Move declaration from symtab.h
11711         and add comment from source.c
11712         (print_source_lines): Likewise.
11713         (forget_cached_source_info_for_objfile): Likewise.
11714         (forget_cached_source_info): Likewise.
11715         (select_source_symtab): Likewise.
11716         (enum print_source_lines_flag): Move definition from symtab.h.
11717         * symtab.h (identify_source_line): Move declaration to source.h.
11718         (print_source_lines): Likewise.
11719         (forget_cached_source_info_for_objfile): Likewise.
11720         (forget_cached_source_info): Likewise.
11721         (select_source_symtab): Likewise.
11722         (enum print_source_lines_flag): Move definition to source.h.
11723         * tui/tui-hooks.c: Add 'source.h' include.
11724
11725 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11726
11727         * source.c (print_source_lines_base): Handle requests to print
11728         reverse line number sequences, and guard against empty lines
11729         string.
11730
11731 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11732
11733         * source.c (print_source_lines_base): Fix skip of '\r' if next
11734         character is '\n'.
11735
11736 2019-01-06  Tom Tromey  <tom@tromey.com>
11737
11738         * c-exp.y (struct c_parse_state) <macro_original_text,
11739         expansion_obstack>: New member.
11740         (macro_original_text, expansion_obstack): Remove globals.
11741         (scan_macro_expansion, scanning_macro_expansion)
11742         (finished_macro_expansion): Update.
11743         (scan_macro_cleanup): Remove.
11744         (yylex, c_parse): Update.
11745
11746 2019-01-06  Tom Tromey  <tom@tromey.com>
11747
11748         * c-exp.y (struct c_parse_state) <strings>: New member.
11749         (operator_stoken): Update.
11750
11751 2019-01-06  Tom Tromey  <tom@tromey.com>
11752
11753         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11754         (union type_stack_elt) <typelist_val>: Now a pointer to
11755         std::vector.
11756         (type_stack_cleanup): Don't declare.
11757         (push_typelist): Update.
11758         * parse.c (pop_typelist): Return a std::vector.
11759         (push_typelist): Take a std::vector.
11760         (follow_types): Update.  Do not free args.
11761         (type_stack_cleanup): Remove.
11762         * c-exp.y (struct c_parse_state): New.
11763         (cpstate): New global.
11764         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11765         (nonempty_typelist): Update.
11766         (func_mod): Create a new vector.
11767         (c_parse): Create a c_parse_state.
11768         (check_parameter_typelist): Do not delete params.
11769         (function_method): Update.  Do not delete type_list.
11770
11771 2019-01-06  Tom Tromey  <tom@tromey.com>
11772
11773         PR gdb/28155:
11774         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11775         check_typedef.
11776         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11777         (print_return_value): Likewise.
11778
11779 2019-01-05  Tom Tromey  <tom@tromey.com>
11780
11781         * contrib/cleanup_check.py: Remove.
11782         * contrib/gcc-with-excheck: Remove.
11783         * contrib/exsummary.py: Remove.
11784         * contrib/excheck.py: Remove.
11785
11786 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11787
11788         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11789         NULL. Initialize tpprev to NULL instead of assigning it
11790         to NULL on the next statement.
11791         * windows-nat.c (windows_delete_thread): Remove check for
11792         main_thread_id before printing thread exit notifications.
11793         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11794         Remove thread ID check against main_thread_id.
11795         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11796         windows_delete_thread.
11797         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11798
11799 2019-01-04  Tom Tromey  <tom@tromey.com>
11800
11801         * compile/compile.c (_initialize_compile): Use upper case for
11802         metasyntactic variables.
11803         * symmisc.c (_initialize_symmisc): Use upper case for
11804         metasyntactic variables.
11805         * psymtab.c (_initialize_psymtab): Use upper case for
11806         metasyntactic variables.
11807         * demangle.c (demangle_command): Use upper case for metasyntactic
11808         variables.
11809         (_initialize_demangler): Likewise.
11810         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11811         variables.
11812
11813 2019-01-03  Tom Tromey  <tom@tromey.com>
11814
11815         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11816
11817 2019-01-03  Tom Tromey  <tom@tromey.com>
11818
11819         * python/py-symtab.c (salpy_str): Update.
11820         (struct salpy_sal_object) <symtab>: Now a PyObject.
11821         (salpy_dealloc): Update.
11822         (del_objfile_sal): Use gdbpy_ref.
11823
11824 2019-01-03  Tom Tromey  <tom@tromey.com>
11825
11826         * python/py-type.c (convert_field): Use new_reference.  Return
11827         gdbpy_ref.
11828         (make_fielditem): Return gdbpy_ref.
11829         (typy_fields): Update.
11830         (typy_getitem): Update.
11831         (field_name): Return gdbpy_ref.  Use new_reference.
11832         (typy_iterator_iternext): Update.
11833
11834 2019-01-03  Tom Tromey  <tom@tromey.com>
11835
11836         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11837
11838 2019-01-03  Tom Tromey  <tom@tromey.com>
11839
11840         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11841         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11842         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11843         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11844         (pspy_set_type_printers): Likewise.
11845         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11846         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11847         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11848         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11849         (objfpy_set_type_printers): Likewise.
11850
11851 2019-01-03  Tom Tromey  <tom@tromey.com>
11852
11853         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11854         (gdbpy_print_stack): Use gdbpy_err_fetch.
11855         * python/python-internal.h (class gdbpy_err_fetch): New class.
11856         (class gdbpy_enter) <m_error_type, m_error_value,
11857         m_error_traceback>: Remove.
11858         <m_error>: New member.
11859         (gdbpy_exception_to_string): Don't declare.
11860         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11861         * python/py-value.c (convert_value_from_python): Use
11862         gdbpy_err_fetch.
11863         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11864         gdbpy_exception_to_string.
11865         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11866         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11867         gdbpy_err_fetch.
11868
11869 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11870
11871         * linux-nat.c (delete_lwp_cleanup): Delete.
11872         (struct lwp_deleter): New struct.
11873         (lwp_info_up): New typedef.
11874         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11875         lwp_info_up.
11876
11877 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11878
11879         * linux-fork.c (class scoped_switch_fork_info): New class.
11880         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11881
11882 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11883
11884         * valops.c (find_overload_match): Remove use of null_cleanup, and
11885         calls to do_cleanups.
11886
11887 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11888
11889         * compile/compile-cplus-types.c
11890         (compile_cplus_instance::decl_name): Handle changes to
11891         cp_func_name.
11892         * cp-support.c (cp_func_name): Update header comment, update
11893         return type.
11894         * cp-support.h (cp_func_name): Update return type in declaration.
11895         * valops.c (find_overload_match): Move temp_func local to top
11896         level of function and change its type.  Use temp_func to hold and
11897         delete temporary string obtained from cp_func_name.
11898
11899 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11900
11901         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11902         gdb::char_vector, remove cleanup, and update uses of `msg`.
11903
11904 2019-01-03  Jim Wilson  <jimw@sifive.com>
11905
11906         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11907
11908 2019-01-02  Tom Tromey  <tom@tromey.com>
11909
11910         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11911         (tdesc_parse_xml): Remove cleanups.
11912         * target-descriptions.h (make_cleanup_free_target_description):
11913         Don't declare.
11914         (target_desc_deleter): New struct.
11915         (target_desc_up): New typedef.
11916         * target-descriptions.c (target_desc_deleter::operator()): Rename
11917         from free_target_description.
11918         (make_cleanup_free_target_description): Remove.
11919
11920 2019-01-02  Tom Tromey  <tom@tromey.com>
11921
11922         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11923         constructor, destructor.
11924         (linespec_parser): Remove typedef.
11925         (~linespec_parser): Rename from linespec_parser_delete.
11926         (linespec_lex_to_end, linespec_complete_label)
11927         (linespec_complete): Update.
11928         (decode_line_full): Remove cleanups.
11929         (decode_line_1): Update.
11930
11931 2019-01-02  Tom Tromey  <tom@tromey.com>
11932
11933         * python/python-internal.h (inferior_to_inferior_object): Change
11934         return type.
11935         * python/py-exitedevent.c (create_exited_event_object): Update.
11936         * python/py-inferior.c (inferior_to_inferior_object): Return
11937         gdbpy_ref.
11938         (python_new_inferior, python_inferior_deleted)
11939         (thread_to_thread_object, delete_thread_object)
11940         (build_inferior_list, gdbpy_selected_inferior): Update.
11941         * python/py-infthread.c (create_thread_object): Update.  Also fail
11942         if inferior_to_inferior_object fails.
11943
11944 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11945
11946         * inferior.h (class inferior) <displaced_step_state>: New field.
11947         * infrun.h (struct displaced_step_state): Move here from
11948         infrun.c.  Initialize fields, add constructor.
11949         <inf>: Remove field.
11950         <reset>: New method.
11951         * infrun.c (struct displaced_step_inferior_state): Move to
11952         infrun.h.
11953         (displaced_step_inferior_states): Remove.
11954         (get_displaced_stepping_state): Adust.
11955         (displaced_step_in_progress_any_inferior): Adjust.
11956         (displaced_step_in_progress_thread): Adjust.
11957         (displaced_step_in_progress): Adjust.
11958         (add_displaced_stepping_state): Remove.
11959         (get_displaced_step_closure_by_addr): Adjust.
11960         (remove_displaced_stepping_state): Remove.
11961         (infrun_inferior_exit): Call displaced_step_state.reset.
11962         (use_displaced_stepping): Don't check for NULL.
11963         (displaced_step_prepare_throw): Call
11964         get_displaced_stepping_state.
11965         (displaced_step_fixup): Don't check for NULL.
11966         (prepare_for_detach): Don't check for NULL.
11967
11968 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11969
11970         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11971          in case of call that did not complete.
11972
11973 2019-01-02  Andrey Utkin  <autkin@undo.io>
11974
11975         * symfile.c (find_separate_debug_file): Fix search of debug files for
11976         remote debuggee.
11977
11978 2019-01-02  Tom Tromey  <tom@tromey.com>
11979
11980         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11981         indentation.
11982         * python/py-frame.c (frapy_older): Remove cast.
11983         (frapy_newer): Likewise.
11984         * python/py-breakpoint.c (local_setattro): Remove cast.
11985         * python/py-arch.c (archpy_name): Remove local variable.
11986         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11987
11988 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11989
11990         * unittests/basic_string_view/element_access/char/empty.cc:
11991         Fix year range in copyright header.
11992
11993 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11994
11995         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11996         Delete.
11997         <operator==>: Update with for removed field.
11998         <hash>: Likewise.
11999         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12000         <isa_features>: ...this.
12001         <abi_features>: New field.
12002         (riscv_isa_flen): Update comment.
12003         (riscv_abi_xlen): New declaration.
12004         (riscv_abi_flen): New declaration.
12005         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12006         isa_features.
12007         (riscv_abi_xlen): New function.
12008         (riscv_isa_flen): Update to get answer from isa_features.
12009         (riscv_abi_flen): New function.
12010         (riscv_has_fp_abi): Update to get answer from abi_features.
12011         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12012         xlen and flen.
12013         (riscv_call_info) <xlen, flen>: Update comment.
12014         (riscv_call_arg_struct): Remove invalid assertions
12015         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12016         is removed.
12017         (riscv_gdbarch_init): Gather isa features and abi features
12018         separately, ensure both match on the gdbarch when reusing an old
12019         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12020         a target with 64-bit float hardware.
12021
12022 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12023
12024         * source.c (search_command_helper): Stop reverse search
12025         when line 1 has been searched.
12026
12027 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12028
12029         * record-full.c (record_full_base_target::close): Rewrite
12030         record_full_core_buf_list free logic.
12031
12032 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12033
12034         * break-catch-syscall.c (print_one_catch_syscall): xfree
12035         the last text.
12036
12037 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12038
12039         * top.c (print_gdb_version): Update Copyright year in version
12040         message.
12041
12042 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12043
12044         Update copyright year range in all GDB files.
12045
12046 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12047
12048         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12049
12050 For older changes see ChangeLog-2018.
12051 \f
12052 Local Variables:
12053 mode: change-log
12054 left-margin: 8
12055 fill-column: 74
12056 version-control: never
12057 coding: utf-8
12058 End:
12059