gdb/ChangeLog

   1 2019-06-18  Tom de Vries  <tdevries@suse.de>
   2
   3         PR gdb/24515
   4         * dwarf2read.h (abstract_to_concrete): Change type from
   5         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
   6         std::unordered_map<sect_offset, std::vector<sect_offset>>.
   7         * dwarf2read.c (read_variable): Update.
   8         (dwarf2_fetch_die_loc_sect_off): Update.
   9
  10 2019-06-17  Tom de Vries  <tdevries@suse.de>
  11
  12         PR gdb/24617
  13         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
  14         accessing parent[parent_len - 1].
  15
  16 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
  17
  18         PR gdb/24364
  19         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
  20         call dtrace_process_dof with NULL dof.
  21
  22 2019-06-16  Tom de Vries  <tdevries@suse.de>
  23
  24         PR gdb/24445
  25         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
  26
  27 2019-06-16  Tom Tromey  <tom@tromey.com>
  28
  29         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
  30         (make_all_visible): Use address of member.
  31
  32 2019-06-16  Tom Tromey  <tom@tromey.com>
  33
  34         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
  35         (tui_free_window, free_content, free_content_elements): Remove
  36         unnecessary cast.
  37         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
  38         cast.
  39         * tui/tui-regs.c (tui_show_register_group)
  40         (tui_display_registers_from, tui_display_reg_element_at_line):
  41         Remove unnecessary cast.
  42
  43 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
  44
  45         * linux-nat.c (normal_mask): Delete.
  46         (_initialize_linux_nat): Don't initialise normal_mask.
  47
  48 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
  49
  50         PR gdb/24445
  51         * dwarf-index-write.h (write_psymtabs_to_index): Add
  52         dwz_basename parameter.
  53         * dwarf-index-write.c (write_gdbindex): Move file writing to
  54         write_gdbindex_1.  Change return type void.
  55         (assert_file_size): Move up, remove filename parameter.
  56         (write_gdbindex_1): New function.
  57         (write_debug_names): Change return type to void, call
  58         assert_file_size.
  59         (struct index_wip_file): New struct.
  60         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
  61         file logic to index_wip_file.  Write index for dwz file if
  62         needed.
  63         (save_gdb_index_command): Pass basename of dwz file, if present.
  64         * dwarf-index-cache.c (index_cache::store): Obtain and pass
  65         build-id of dwz file, if present.
  66         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
  67         (dwarf2_get_dwz_file): Likewise.
  68         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
  69         (dwarf2_get_dwz_file): Likewise.
  70
  71 2019-06-16  Tom Tromey  <tom@tromey.com>
  72
  73         * coffread.c (process_coff_symbol): Use xstrdup.
  74         * value.c (create_internalvar): Use xstrdup.
  75
  76 2019-06-16  Tom Tromey  <tom@tromey.com>
  77
  78         * valops.c (value_cast, value_slice): Remove unnecessary cast.
  79         * breakpoint.c (stopin_command, stopat_command)
  80         (until_break_command, decode_location_default): Remove unnecessary
  81         cast.
  82         * utils.c (subset_compare): Remove unnecessary cast.
  83         * ada-lang.c (ada_update_initial_language): Remove unnecessary
  84         cast.
  85         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
  86         cast.
  87         * infcmd.c (path_command): Remove unnecessary cast.
  88         * coffread.c (decode_type): Remove unnecessary cast.
  89         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
  90         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
  91         * tui/tui-stack.c (tui_show_locator_content)
  92         (tui_show_frame_info): Remove unnecessary cast.
  93         * tui/tui-win.c (tui_scroll_forward_command)
  94         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
  95         (parse_scrolling_args): Remove unnecessary cast.
  96         * tui/tui-data.c (init_win_info, tui_del_window)
  97         (tui_free_window, tui_del_data_windows, tui_free_data_content)
  98         (free_content_elements): Remove unnecessary cast.
  99         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 100         unnecessary cast.
 101         * tui/tui-source.c (tui_set_source_content)
 102         (tui_vertical_source_scroll): Remove unnecessary cast.
 103         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 104         cast.
 105         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 106         * tui/tui-regs.c (tui_display_registers_from)
 107         (tui_display_register): Remove unnecessary cast.
 108         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 109         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 110         (make_visible): Remove unnecessary cast.
 111         * tui/tui-winsource.c (tui_erase_source_content)
 112         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 113         unnecessary cast.
 114         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 115         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 116         * stabsread.c (read_type, read_array_type, read_range_type):
 117         Remove unnecessary cast.
 118         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 119         (parse_symbol, parse_type, upgrade_type, parse_external)
 120         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 121         unnecessary cast.
 122         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 123
 124 2019-06-16  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui-data.c (tui_alloc_generic_win_info)
 127         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 128         checks.
 129
 130 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 131             Andrew Burgess  <andrew.burgess@embecosm.com>
 132
 133         * f-typeprint.c (f_print_type): Don't return early for not
 134         associated or not allocated types.
 135         (f_type_print_varspec_suffix): Add print_rank parameter and print
 136         ranks of array types in case they dangling.
 137         (f_type_print_base): Add print_rank parameter.
 138
 139 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 140
 141         * NEWS: Mention new MI commands.
 142         * break-catch-throw.c (enum exception_event_kind): Move to
 143         breakpoint.h.
 144         (print_mention_exception_catchpoint): Output text as a single
 145         message.
 146         (catch_exception_command_1): Rename to...
 147         (catch_exception_event): ...this, make non-static, update header
 148         command, and change some parameter types.
 149         (catch_catch_command): Update for changes to
 150         catch_exception_command_1.
 151         (catch_throw_command): Likewise.
 152         (catch_rethrow_command): Likewise.
 153         * breakpoint.c (enum exception_event_kind): Delete.
 154         * breakpoint.h (enum exception_event_kind): Moved here from
 155         break-catch-throw.c.
 156         (catch_exception_event): Declare.
 157         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 158         (mi_cmd_catch_throw): New function.
 159         (mi_cmd_catch_rethrow): New function.
 160         (mi_cmd_catch_catch): New function.
 161         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 162         'catch-catch' entries.
 163         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 164         (mi_cmd_catch_rethrow): Declare.
 165         (mi_cmd_catch_catch): Declare.
 166
 167 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 168
 169         * annotate.c (annotate_source_line): Change return type to void,
 170         update implementation to match.
 171         * annotate.h (annotate_source_line): Change return type to void,
 172         update header comment.
 173         * stack.c (print_frame_info): Don't change what frame information
 174         is printed based on whether annotations are on or not.
 175
 176 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 177
 178         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 179         (annotate_source): Make static.
 180         (annotate_source_line): Moved from source.c and renamed from
 181         identify_source_line.  Update the return type.
 182         * annotate.h (annotate_source): Delete declaration.
 183         (annotate_source_line): Declaration moved from source.h, and
 184         renamed from identify_source_line.  Return type updated.
 185         * source.c (identify_source_line): Moved to annotate.c and renamed
 186         to annotate_source_line.
 187         (info_line_command): Remove check of annotation_level.
 188         * source.h (identify_source_line): Move declaration to annotate.h
 189         and rename to annotate_source_line.
 190         * stack.c: Add 'annotate.h' include.
 191         (print_frame_info): Remove check of annotation_level before
 192         calling annotate_source_line.
 193
 194 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 195
 196         * source-cache.c (source_cache::get_plain_source_lines): Use
 197         open_source_file_with_line_charpos instead of just
 198         open_source_file, remove call to find_source_lines.
 199         (source_cache::get_source_lines): Likewise.
 200         * source.c (find_source_lines): Make static.
 201         (get_filename_and_charpos): Renamed into...
 202         (open_source_file_with_line_charpos): ..this along with changes to
 203         return a scoped_fd, and some other minor clean ups.
 204         (identify_source_line): Use open_source_file_with_line_charpos.
 205         (search_command_helper): Use open_source_file_with_line_charpos
 206         instead of just open_source_file, remove call to
 207         find_source_lines.
 208         * source.h (open_source_file_with_line_charpos): Declare new
 209         function.
 210         (find_source_lines): Delete declaration.
 211
 212 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 213
 214         * source.c (get_filename_and_charpos): Remove fullname
 215         parameter.
 216         (identify_source_line): Update call to get_filename_and_charpos.
 217
 218 2019-06-14  Tom Tromey  <tromey@adacore.com>
 219
 220         PR gdb/24502:
 221         * ui-style.h (skip_ansi_escape): Update comment.
 222         * ui-file.h (class no_terminal_escape_file): New class.
 223         * ui-file.c (no_terminal_escape_file::write)
 224         (no_terminal_escape_file::puts): New methods.
 225         * cli/cli-logging.c (handle_redirections): Use
 226         no_terminal_escape_file.
 227
 228 2019-06-14  Tom Tromey  <tromey@adacore.com>
 229
 230         * NEWS: Move convenience variable news above Python news.
 231
 232 2019-06-14  Tom Tromey  <tom@tromey.com>
 233
 234         * gnulib: Move directory to top-level.
 235         * configure.ac: Don't configure gnulib.
 236         * configure: Rebuild.
 237         * common/common-defs.h: Use new path to gnulib.
 238         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 239         (GNULIB_H): Remove.
 240         (INCGNU): Look in new gnulib location.
 241         (HFILES_NO_SRCDIR): Remove gnulib files.
 242         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 243         (generated_files): Remove GNULIB_H.
 244         ($(LIBGNU), all-lib): Remove targets.
 245         (distclean): Don't mention GNULIB_BUILDDIR.
 246         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 247
 248 2019-06-14  Tom Tromey  <tromey@adacore.com>
 249
 250         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 251         Warn if symbol file does not provide any symbols.
 252
 253 2019-06-14  Tom Tromey  <tromey@adacore.com>
 254
 255         * source.c (find_and_open_source): Respect basenames_may_differ.
 256
 257 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 258
 259         * annotate.c (annotate_breakpoints_invalid): Make use of
 260         scoped_restore_terminal_state.
 261         (annotate_frames_invalid): Likewise.
 262
 263 2019-06-14  Tom Tromey  <tromey@adacore.com>
 264
 265         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 266         allow assignment to an internalvar.
 267
 268 2019-06-14  Tom Tromey  <tromey@adacore.com>
 269
 270         * ada-lex.l: Allow "_" in attribute names.
 271
 272 2019-06-14  Tom Tromey  <tromey@adacore.com>
 273
 274         PR gdb/24653:
 275         * regcache.c (registers_changed): Don't call alloca.
 276         * top.c (execute_command): Don't call alloca.
 277
 278 2019-06-13  Pedro Alves  <palves@redhat.com>
 279
 280         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 281         'expression'.  When parsing an expression, error out if there's
 282         junk after "unlimited".
 283         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 284         (do_set_command): Adjust calls to is_unlimited_literal.
 285
 286 2019-06-13  Pedro Alves  <palves@redhat.com>
 287
 288         * compile/compile.c (make_compile_options_def_group): Add braces
 289         around array_view initializer.
 290         * thread.c (make_thread_apply_all_options_def_group)
 291         (make_thread_apply_all_options_def_group): Likewise.
 292
 293 2019-06-13  Pedro Alves  <palves@redhat.com>
 294
 295         * NEWS (New commands): Mention "maint test-options
 296         require-delimiter", "maint test-options unknown-is-error", "maint
 297         test-options unknown-is-operand" and "maint show
 298         test-options-completion-result".
 299         (New command options, command completion): New section.
 300         (Completion improvements): New section.
 301         Mention that you can abbreviate "unlimited".
 302
 303 2019-06-13  Pedro Alves  <palves@redhat.com>
 304
 305         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 306         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 307         * unittests/cli-utils-selftests.c (test_parse_flags)
 308         (test_parse_flags_qcs): Delete.
 309         (test_cli_utils): Don't call deleted functions.
 310
 311 2019-06-13  Pedro Alves  <palves@redhat.com>
 312
 313         * thread.c: Include "cli/cli-option.h".
 314         (tp_array_compar_ascending): Global.
 315         (tp_array_compar): Delete function.
 316         (tp_array_compar_ascending, tp_array_compar_descending): New
 317         functions.
 318         (ascending_option_def, qcs_flag_option_def)
 319         (thr_qcs_flags_option_defs)
 320         (make_thread_apply_all_options_def_group)
 321         (make_thread_apply_options_def_group): New.
 322         (thread_apply_all_command): Use gdb::option::process_options.
 323         (thread_apply_command_completer)
 324         (thread_apply_all_command_completer): New.
 325         (thread_apply_command): Use gdb::option::process_options.
 326         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 327         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 328         to generate help text of "thread apply".  Adjust "taas"'s help.
 329         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 330         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 331
 332 2019-06-13  Pedro Alves  <palves@redhat.com>
 333
 334         * thread.c (thread_apply_command): Check for invalid TID with
 335         isdigit instead of !isalpha.
 336
 337 2019-06-13  Pedro Alves  <palves@redhat.com>
 338
 339         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 340         (validate_flags_qcs): New.
 341         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 342         (validate_flags_qcs): Declare.
 343         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 344         (make_frame_apply_options_def_group): New.
 345         (frame_apply_command_count): Process options with
 346         gdb::option::process_options.
 347         (frame_apply_completer): New.
 348         (frame_apply_level_completer, frame_apply_all_completer)
 349         (frame_apply_completer): New.
 350         (_initialize_stack): Update help of "frame apply", "frame apply
 351         level", "frame apply all" and "faas" to mention supported options
 352         and install command completers.
 353         * stack.h (frame_apply_all_completer): Declare.
 354         * thread.c: Include "stack.h".
 355         (tfaas_command): Add "--".
 356         (_initialize_thread): Update help "tfaas" to mention supported
 357         options and install command completer.
 358
 359 2019-06-13  Pedro Alves  <palves@redhat.com>
 360
 361         * completer.c (complete_nested_command_line): New.
 362         (gdb_completion_word_break_characters_throw): Add assertion.
 363         * completer.h (complete_nested_command_line): Declare.
 364
 365 2019-06-13  Pedro Alves  <palves@redhat.com>
 366
 367         * stack.c (parse_backtrace_qualifiers): New.
 368         (backtrace_command): Use it.
 369         (backtrace_command_completer): Complete on qualifiers.
 370
 371 2019-06-13  Pedro Alves  <palves@redhat.com>
 372
 373         * frame.c: Include "cli/cli-option.h.
 374         (user_set_backtrace_options): New.
 375         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 376         Delete.
 377         (get_prev_frame): Adjust.
 378         (boolean_option_def, uinteger_option_def)
 379         (set_backtrace_option_defs): New.
 380         (_initialize_frame): Adjust and use
 381         gdb::option::add_setshow_cmds_for_options to install "set
 382         backtrace past-main" and "set backtrace past-entry".
 383         * frame.h: Include "cli/cli-option.h".
 384         (struct frame_print_options): Forward declare.
 385         (print_frame_arguments_all, print_frame_arguments_scalars)
 386         (print_frame_arguments_none): Declare.
 387         (print_entry_values): Delete declaration.
 388         (struct frame_print_options, user_frame_print_options): New.
 389         (struct set_backtrace_options): New.
 390         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 391         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 392         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 393         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 394         (list_args_or_locals): Add frame_print_options parameter.
 395         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 396         * python/py-framefilter.c (enumerate_args): Pass down
 397         USER_FRAME_PRINT_OPTIONS.
 398         * stack.c: Include "cli/cli-option.h".
 399         (print_frame_arguments_all, print_frame_arguments_scalars)
 400         (print_frame_arguments_none): Declare.
 401         (print_raw_frame_arguments, print_entry_values): Delete.
 402         (user_frame_print_options): New.
 403         (boolean_option_def, enum_option_def, frame_print_option_defs):
 404         New.
 405         (struct backtrace_cmd_options): New.
 406         (bt_flag_option_def): New.
 407         (backtrace_command_option_defs): New.
 408         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 409         (print_frame_arg, read_frame_arg, print_frame_args)
 410         (print_frame_info, print_frame): Add frame_print_options parameter
 411         and use it.
 412         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 413         (backtrace_command_1): Add frame_print_options and
 414         backtrace_cmd_options parameters and use them.
 415         (make_backtrace_options_def_group): New.
 416         (backtrace_command): Process command options with
 417         gdb::option::process_options.
 418         (backtrace_command_completer): New.
 419         (_initialize_stack): Extend "backtrace"'s help to mention
 420         supported options.  Install completer for "backtrace".
 421         Install some settings commands with add_setshow_cmds_for_options.
 422
 423 2019-06-13  Pedro Alves  <palves@redhat.com>
 424
 425         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 426         and that "set/show print raw frame-arguments" are now deprecated.
 427
 428         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 429         command.
 430         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 431         * stack.c (_initialize_stack): Install "set/show print
 432         raw-frame-arguments", and deprecate "set/show print raw
 433         frame-arguments".
 434         * valprint.c (_initialize_valprint): Deprecate "set/show print
 435         raw".
 436
 437 2019-06-13  Pedro Alves  <palves@redhat.com>
 438
 439         * compile/compile.c (struct compile_options): New.
 440         (compile_flag_option_def, compile_command_option_defs)
 441         (make_compile_options_def_group): New.
 442         (compile_file_command): Handle options with
 443         gdb::option::process_options.
 444         (compile_file_command_completer): New function.
 445         (compile_code_command): Handle options with
 446         gdb::option::process_options.
 447         (compile_code_command_completer): New function.
 448         (_initialize_compiler): Install completers for "compile code" and
 449         "compile file".  Mention available options in "compile code" and
 450         "compile code"'s help.
 451         * completer.c (advance_to_completion_word): New, factored out from
 452         ...
 453         (advance_to_expression_complete_word_point): ... this.
 454         (advance_to_filename_complete_word_point): New.
 455         * completer.h (advance_to_filename_complete_word_point): New
 456         declaration.
 457
 458 2019-06-13  Pedro Alves  <palves@redhat.com>
 459
 460         * compile/compile.c: Include "cli/cli-option.h".
 461         (compile_print_value): Scope data pointer is now a
 462         value_print_options pointer; adjust.
 463         (compile_print_command): Process options.  Scope data pointer is
 464         now a value_print_options pointer; adjust.
 465         (_initialize_compile): Update "compile print"'s help to include
 466         supported options.  Install a completer for "compile print".
 467         * cp-valprint.c (show_vtblprint, show_objectprint)
 468         (show_static_field_print): Delete.
 469         (_initialize_cp_valprint): Don't install "set print
 470         static-members", "set print vtbl", "set print object" here.
 471         * printcmd.c: Include "cli/cli-option.h" and
 472         "common/gdb_optional.h".
 473         (print_command_parse_format): Rework to fill in a
 474         value_print_options instead of a format_data.
 475         (print_value): Change parameter type from format_data pointer to
 476         value_print_options reference.  Adjust.
 477         (print_command_1): Process options.  Adjust to pass down a
 478         value_print_options.
 479         (print_command_completer): New.
 480         (_initialize_printcmd): Install print_command_completer as
 481         handle_brkchars completer for the "print" command.  Update
 482         "print"'s help to include supported options.
 483         * valprint.c: Include "cli/cli-option.h".
 484         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 485         here from cp-valprint.c.
 486         (boolean_option_def, uinteger_option_def)
 487         (value_print_option_defs, make_value_print_options_def_group):
 488         New.  Use gdb::option::add_setshow_cmds_for_options to install
 489         "set print elements", "set print null-stop", "set print repeats",
 490         "set print pretty", "set print union", "set print array", "set
 491         print address", "set print symbol", "set print array-indexes".
 492         * valprint.h: Include <string> and "cli/cli-option.h".
 493         (make_value_print_options_def_group): Declare.
 494         (print_value): Change parameter type from format_data pointer to
 495         value_print_options reference.
 496         (print_command_completer): Declare.
 497
 498 2019-06-13  Pedro Alves  <palves@redhat.com>
 499
 500         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 501         (COMMON_SFILES): Add maint-test-settings.c.
 502         * cli/cli-decode.c (boolean_enums): New global, factored out from
 503         ...
 504         (add_setshow_boolean_cmd): ... here.
 505         * cli/cli-decode.h (boolean_enums): Declare.
 506         * cli/cli-option.c: New file.
 507         * cli/cli-option.h: New file.
 508         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 509         factored out from ...
 510         (parse_cli_boolean_value(const char *)): ... this.
 511         (is_unlimited_literal): Change parameter type to pointer to
 512         pointer.  Adjust and advance ARG pointer.
 513         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 514         (parse_cli_var_enum): New, factored out from ...
 515         (do_set_command): ... this.  Adjust.
 516         * cli/cli-setshow.h (parse_cli_boolean_value)
 517         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 518         (parse_cli_var_enum): Declare.
 519         * cli/cli-utils.c: Include "cli/cli-option.h".
 520         (get_ulongest): New.
 521         * cli/cli-utils.h (get_ulongest): Declare.
 522         (check_for_argument): New overloads.
 523         * maint-test-options.c: New file.
 524
 525 2019-06-13  Pedro Alves  <palves@redhat.com>
 526
 527         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 528         parse a range if "-" is at the end of the string.
 529
 530 2019-06-13  Pedro Alves  <palves@redhat.com>
 531
 532         * cli/cli-setshow.c (parse_auto_binary_operation)
 533         (parse_cli_boolean_value): Don't allow "o".
 534
 535 2019-06-13  Pedro Alves  <palves@redhat.com>
 536
 537         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 538         * NEWS: Mention maint test-settings KIND.
 539         * maint-test-settings.c: New file.
 540
 541 2019-06-13  Pedro Alves  <palves@redhat.com>
 542
 543         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 544         completer.
 545         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 546         "set" completers.
 547
 548 2019-06-13  Pedro Alves  <palves@redhat.com>
 549
 550         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 551         after item.
 552
 553 2019-06-13  Pedro Alves  <palves@redhat.com>
 554
 555         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 556
 557 2019-06-13  Pedro Alves <palves@redhat.com>
 558
 559         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 560         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 561         call.
 562         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 563         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 564         calls.
 565         (check_for_argument): Skip spaces after argument.
 566
 567 2019-06-13  Pedro Alves  <palves@redhat.com>
 568
 569         * thread.c (thread_apply_command): Adjust TID parsing.
 570         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 571         detected before end of string.
 572         (tid_is_in_list): Error out if LIST is invalid.
 573
 574 2019-06-13  Pedro Alves  <palves@redhat.com>
 575
 576         * completer.c (complete_line_internal_1): Rewind completion word
 577         point.
 578         (completion_tracker::advance_custom_word_point_by): Change
 579         parameter type to int.
 580         * completer.h (completion_tracker::advance_custom_word_point_by):
 581         Likewise.
 582
 583 2019-06-13  Pedro Alves  <palves@redhat.com>
 584
 585         * completer.c (advance_to_completion_word): Handle delimiters.
 586
 587 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 588
 589         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 590
 591 2019-06-11  Tom Tromey  <tom@tromey.com>
 592
 593         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 594         (xmalloc_failed): Move to alloc.c.
 595         * alloc.c: New file.
 596         * Makefile.in (COMMON_SFILES): Add alloc.c.
 597
 598 2019-06-11  Tom Tromey  <tom@tromey.com>
 599
 600         * nat/linux-waitpid.c: Don't include server.h.
 601         (linux_debug): Remove.
 602         (my_waitpid): Update.
 603
 604 2019-06-11  Tom Tromey  <tromey@adacore.com>
 605
 606         * infcall.c (_initialize_infcall): Remove trailing newline from
 607         help.
 608         * user-regs.c (_initialize_user_regs): Remove trailing newline
 609         from help.
 610         * typeprint.c (_initialize_typeprint): Remove trailing newline
 611         from help.
 612         * reverse.c (_initialize_reverse): Remove trailing newlines from
 613         help.
 614         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 615         from help.
 616         * language.c (add_set_language_command): Remove trailing newline
 617         from help.
 618         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 619         help.
 620         * disasm.c (_initialize_disasm): Remove trailing newline from
 621         help.
 622         * top.c (init_main): Remove trailing newline from help.
 623         * interps.c (_initialize_interpreter): Remove trailing newline
 624         from help.
 625         * btrace.c (_initialize_btrace): Remove trailing newlines from
 626         help.
 627         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 628         from help.
 629         * python/python.c (_initialize_python): Remove trailing newline
 630         from help.
 631         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 632         help.
 633         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 634         from help.  Reformat some text.
 635         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 636         from help.
 637         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 638         newline from help.
 639
 640 2019-06-11  Tom Tromey  <tromey@adacore.com>
 641
 642         * darwin-nat.c (darwin_decode_exception_message)
 643         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 644
 645 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 646
 647         * valops.c (value_slice): Check for not allocated or not
 648         associated values.
 649
 650 2019-06-10  Tom de Vries  <tdevries@suse.de>
 651
 652         PR gdb/24618
 653         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 654         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 655         invalid.
 656
 657 2019-06-10  Tom de Vries  <tdevries@suse.de>
 658
 659         PR gdb/24611
 660         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 661         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 662
 663 2019-06-10  Tom de Vries  <tdevries@suse.de>
 664
 665         PR symtab/24545
 666         * symtab.c (struct demangled_name_entry): Add language field.
 667         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 668         static minimal symbol".  Set and use language field.
 669
 670 2019-06-10  Tom Tromey  <tromey@adacore.com>
 671
 672         * ada-lang.c (_initialize_ada_language): Update help text.
 673
 674 2019-06-10  Tom Tromey  <tromey@adacore.com>
 675
 676         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 677         with a newline.
 678         * guile/guile.c (handle_boot_error): Don't end warning with a
 679         newline.
 680         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 681         warning with a newline.
 682         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 683         newline.
 684         (s12z_frame_cache): Likewise.
 685         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 686         a newline.
 687         * solib-svr4.c (disable_probes_interface): Don't end warning with
 688         a newline.
 689         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 690         newline.
 691         * python/python.c (do_finish_initialization): Don't end warning
 692         with a newline.
 693
 694 2019-06-10  Tom Tromey  <tom@tromey.com>
 695
 696         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 697         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 698         gdbpy_enter.
 699
 700 2019-06-10  Tom Tromey  <tromey@adacore.com>
 701
 702         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 703         data.
 704         (elf_new_init): Don't call stabsread_new_init.
 705         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 706         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 707         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 708
 709 2019-06-10  Tom de Vries  <tdevries@suse.de>
 710
 711         PR symtab/16264
 712         PR symtab/24517
 713         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 714
 715 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 716
 717         * source.c (find_and_open_source): Also rewrite relative file
 718         names.
 719
 720 2019-04-26  Amos Bird  <amosbird@gmail.com>
 721
 722         * annotate.c (annotate_thread_exited): Add "thread-exited"
 723         annotation.
 724
 725 2019-06-06  Tom Tromey  <tromey@adacore.com>
 726
 727         * maint.h (class scoped_command_stats): Use
 728         DISABLE_COPY_AND_ASSIGN.
 729         <print_time>: New method.
 730         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 731         print_time.
 732         (scoped_command_stats::print_time): New method.
 733
 734 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 735
 736         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 737         instructions of lengths 6 or 8 bytes.
 738
 739 2019-06-04  Pedro Alves  <palves@redhat.com>
 740
 741         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 742
 743         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 744         * breakpoint.c (condition_completer): Likewise.
 745         * cli/cli-dump.c (scan_expression): Likewise.
 746         * common/filestuff.c (mkdir_recursive): Likewise.
 747         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 748         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 749         (gdb_abspath): Likewise.
 750         * compile/compile-cplus-types.c
 751         (compile_cplus_instance::decl_name): Likewise.
 752         * completer.c (complete_explicit_location):
 753         (signal_completer, reg_or_group_completer_1): Likewise.
 754         * cp-support.c (cp_remove_params_if_any): Likewise.
 755         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 756         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 757         * infcmd.c (strip_bg_char): Likewise.
 758         * linespec.c (copy_token_string): Likewise.
 759         * mi/mi-main.c (output_cores): Likewise.
 760         * psymtab.c (psymtab_search_name):
 761         * symfile.c (test_set_ext_lang_command): Likewise.
 762         * target.c (target_fileio_read_stralloc): Likewise.
 763         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 764         * value.c (complete_internalvar): Likewise.
 765
 766 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 767
 768         Add objfile property to gdb.Type.
 769         * NEWS: Mention Python API addition.
 770         * python/py-type.c (typy_get_objfile): New method.
 771
 772 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 773
 774         * NEWS: Mention the new set|show style [title|highlight].
 775         Mention changes to "show style", "help" and "apropos".
 776
 777 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 778
 779         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 780         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 781         instead of print_help_for_command.
 782         (print_doc_of_command): New function.
 783         (help_list): Add 'apropos -v word' suggestion.
 784         (print_help_for_command): Style the command name using title style.
 785         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 786         (_initialize_cli_cmds): Describe -v in apropos_command help.
 787
 788 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 789
 790         * cli/cli-style.h (cli_style_option): Add name in constructor,
 791         add m_name class member, add constructor with intensity,
 792         add name class function.
 793         (cli_style_option::add_setshow_commands): Remove name argument.
 794         (highlight_style, title_style): New styles.
 795         * cli/cli-style.c (do_show): New function that shows a style
 796         characteristic styling the style name with itself.
 797         (set_style_name): New function.
 798         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 799         Update all callers according to the changes in cli/cli-style.h.
 800         * utils.h (fputs_highlighted): New function.
 801         * utils.c (fputs_highlighted): Likewise.
 802
 803 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 804
 805         * NEWS: Mention new pipe command and new convenience variables.
 806
 807 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 808
 809         * cli/cli-cmds.c (pipe_command): New function.
 810         (_initialize_cli_cmds): Call add_com for pipe_command.
 811         Define | as an alias for pipe.
 812         (exit_status_set_internal_vars): New function.
 813         (shell_escape): Call exit_status_set_internal_vars.
 814         cli/cli-decode.c (find_command_name_length): Recognize | as
 815         a single character command.
 816
 817 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 818
 819         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 820         top.c (execute_command_to_ui_file): New function, mostly a copy
 821         of execute_command_to_string.
 822         (execute_command_to_string): Implement by calling
 823         execute_command_to_ui_file.
 824
 825 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 826
 827         * top.h (saved_command_line): Remove declaration.
 828         * top.c (previous_saved_command_line, previous_repeat_arguments):
 829         New variables.
 830         (saved_command_line): Make static, define together with other
 831         'repeat variables'.
 832         (dont_repeat): Clear repeat_arguments.
 833         (repeat_previous, get_saved_command_line, save_command_line):
 834         New functions.
 835         (gdb_init): Initialize saved_command_line
 836         and previous_saved_command_line.
 837         * main.c (captured_main_1): Remove saved_command_line initialization.
 838         * event-top.c (handle_line_of_input): Update to use
 839         the new 'repeat' related functions instead of direct access to
 840         saved_command_line.
 841         * command.h (repeat_previous, get_saved_command_line,
 842         save_command_line): New declarations.
 843         (dont_repeat): Add comment.
 844
 845 2019-05-30  Tom Tromey  <tromey@adacore.com>
 846
 847         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 848         Fix comment.
 849         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 850
 851 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 852
 853         PR cli/24587
 854         * completer.c (complete): Initialize variable word.
 855
 856 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 857
 858         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 859         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 860         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 861         'body' is NULL to the outter 'if', protecting the '!is_define'
 862         situation as well.
 863
 864 2019-05-29  Tom Tromey  <tromey@adacore.com>
 865
 866         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 867         (dwarf_unknown): New function.
 868         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 869         (dwarf_type_encoding_name): Use dwarf_unknown.
 870
 871 2019-05-29  Tom Tromey  <tromey@adacore.com>
 872
 873         PR c++/20020:
 874         * cp-valprint.c (cp_print_value_fields): Call
 875         cp_print_static_field inside "try".
 876
 877 2019-05-29  Tom Tromey  <tromey@adacore.com>
 878
 879         * inflow.c (struct terminal_info): Add default operator=.
 880         * configure: Rebuild.
 881         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 882         -Wdeprecated-copy-dtor, -Wredundant-move.
 883
 884 2019-05-29  Tom Tromey  <tromey@adacore.com>
 885
 886         * NEWS: Add entry.
 887         * infcmd.c (print_return_value_1): Handle finish_print
 888         option.
 889         (show_print_finish): New function.
 890         (_initialize_infcmd): Add "set/show print finish" commands.
 891         * valprint.c (user_print_options): Initialize new member.
 892         * valprint.h (struct value_print_options) <finish_print>: New
 893         member.
 894
 895 2019-05-28  Tom Tromey  <tromey@adacore.com>
 896
 897         * ada-lang.c (ada_remove_Xbn_suffix)
 898         (find_old_style_renaming_symbol)
 899         (parse_old_style_renaming): Remove.
 900         (ada_find_renaming_symbol): Don't call
 901         find_old_style_renaming_symbol.
 902         (ada_is_renaming_symbol): Rename from
 903         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 904         bool.  Now static.
 905         (ada_read_var_value): Update and simplify.
 906         * ada-exp.y (write_var_or_type): Remove old code.
 907
 908 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 909
 910         * event-top.c: Remove include comment.
 911         * inflow.c (class scoped_ignore_sigttou): Move from here...
 912         * inflow.h (class scoped_ignore_sigttou): ...to here.
 913         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 914         * top.c:  Remove include comment.
 915
 916 2019-05-27  Tom Tromey  <tom@tromey.com>
 917
 918         * NEWS: Fix typo.
 919
 920 2019-05-22  Tom Tromey  <tromey@adacore.com>
 921
 922         * target.c (target_follow_exec): Constify parameter.
 923         * target-delegates.c: Rebuild.
 924         * remote.c (remote_target::follow_exec): Constify parameter.
 925         * infrun.c (follow_exec): Constify parameter.
 926         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 927         (target_follow_exec): Likewise.
 928
 929 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 930
 931         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 932         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 933
 934 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 935
 936         * NEWS: Add debugredirect and testsuite sections.
 937
 938 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 939
 940         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 941         target descriptions using exclusively floating point register name
 942         aliases.
 943
 944 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 945
 946         PR gdb/18644:
 947         * f-lang.c (build_fortran_types): Handle the case where
 948         gdbarch_floatformat_for_type returns a nullptr.
 949
 950 2019-05-21  Tom de Vries  <tdevries@suse.de>
 951
 952         PR cli/24587
 953         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 954
 955 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 956
 957         PR gdb/18644:
 958         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 959         16-byte floats.
 960         * i386-tdep.c (i386_floatformat_for_type): Use
 961         floatformats_ia64_quad for the 16-byte floating point component
 962         within a fortran 32-byte complex number.
 963
 964 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 965
 966         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 967         delete default constructor.
 968         (find_partial_die): Update to return const struct.
 969         (partial_die_parent_scope): Move variable declaration into scope
 970         of its use and change its type to auto.
 971         (guess_partial_die_structure_name): Likewise.
 972         (partial_die_info::fixup): Likewise.
 973
 974 2019-05-17  Tom Tromey  <tromey@adacore.com>
 975
 976         * source.c (find_and_open_source): Remove cast.
 977
 978 2019-05-17  Tom Tromey  <tromey@adacore.com>
 979
 980         * annotate.c (annotate_source): Make "filename" const.
 981         * annotate.h (annotate_source): Use const.
 982
 983 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 984
 985         * disasm.c (set_disassembler_options): Send errors to stderr.
 986
 987 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 988
 989         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 990         (cli_interp_base::set_logging): Check debug_redirect.
 991         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 992         * cli/cli-logging.c (debug_redirect): Add static variable.
 993         (pop_output_files): Add default param.
 994         (handle_redirections): Print debug setting.
 995         (show_logging_command): Likewise.
 996         (_initialize_cli_logging): Add debugredirect command.
 997         * interps.c (current_interp_set_logging): Add debug_redirect
 998         parameter.
 999         * interps.h (set_logging): Add debug_redirect parameter.
1000         (current_interp_set_logging): Likewise.
1001         * mi/mi-common.h: Likewise.
1002         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1003
1004 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1005             Tom Tromey  <tromey@adacore.com>
1006
1007         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1008         directly.
1009         * cli/cli-interp.h (make_logging_output): Remove declaration.
1010         * cli/cli-logging.c (make_logging_output): Remove function.
1011         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1012         directly.
1013         * ui-file.c (tee_file::tee_file): Remove bools.
1014         (tee_file::~tee_file): Remove deletes.
1015         * ui-file.h (tee_file): Remove bools.
1016
1017 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1018
1019         * mi/mi-cmds.h (mi_cmd_complete): New function.
1020         * mi/mi-main.c (mi_cmd_complete): Likewise.
1021         * mi/mi-cmds.c: Define new MI command -complete.
1022         * NEWS: Mention new -complete command.
1023
1024 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1025
1026         * completer.h (complete): New function.
1027         * completer.c (complete): Likewise.
1028         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1029         function defined in completer.h.
1030
1031 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1032
1033         * MAINTAINERS (Write After Approval): Add myself.
1034
1035 2019-05-17  Tom de Vries  <tdevries@suse.de>
1036
1037         PR gdb/24094
1038         * dwarf2read.c (struct cu_partial_die_info): New struct.
1039         (find_partial_die): Return cu_partial_die_info.
1040         (partial_die_parent_scope, guess_partial_die_structure_name)
1041         (partial_die_info::fixup): Handle new return type of find_partial_die.
1042
1043 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1044
1045         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1046         "std::string", simplifying the algorithm.
1047
1048 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1049
1050         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1051         (stap_static_probe_ops::get_probes): Likewise.
1052
1053 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1054
1055         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1056         '-')" and "else if".
1057         (stap_parse_single_operand): Join checks for
1058         "gdbarch_stap_parse_special_token_p" and
1059         "gdbarch_stap_parse_special_token" in the same "if" statement.
1060         Invert check when verifying for operation on register
1061         displacement.
1062
1063 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1064
1065         * stap-probe.c (stap_get_opcode): Update comment.
1066         (stap_get_expected_argument_type): Likewise.
1067         (handle_stap_probe): Likewise.
1068
1069 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1070
1071         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1072         return type to 'bool'.  Adjust comment.  Use 'bool' when
1073         appropriate.
1074         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1075         * stap-probe.c (stap_parse_argument_1): Likewise.
1076         (stap_is_operator): Likewise.
1077         (stap_is_generic_prefix): Likewise.
1078         (stap_is_register_prefix): Likewise.
1079         (stap_is_register_indirection_prefix): Likewise.
1080         (stap_is_integer_prefix): Likewise.
1081         (stap_generic_check_suffix): Likewise.
1082         (stap_check_integer_suffix): Likewise.
1083         (stap_check_register_suffix): Likewise.
1084         (stap_check_register_indirection_suffix): Likewise.
1085         (stap_parse_register_operand): Likewise.
1086         (stap_parse_single_operand): Likewise.
1087         (stap_parse_argument_1): Likewise.
1088         (stap_probe::get_argument_count): Likewise.
1089         (stap_is_operator): Likewise.
1090
1091 2019-05-16  Tom Tromey  <tromey@adacore.com>
1092
1093         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1094         keyword to foreach.
1095
1096 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1097
1098         * linux-thread-db.c (try_thread_db_load_1): Change return type
1099         to bool.
1100         (try_thread_db_load): Likewise.
1101         (try_thread_db_load_from_pdir_1): Likewise.
1102         (try_thread_db_load_from_pdir): Likewise.
1103         (try_thread_db_load_from_sdir): Likewise.
1104         (try_thread_db_load_from_dir): Likewise.
1105         (thread_db_load_search): Likewise.
1106         (has_libpthread): Likewise.
1107         (thread_db_load): Likewise.
1108
1109 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1110
1111         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1112         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1113         NULL, and complain/return if that's the case.
1114
1115 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1116
1117         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1118         (advance, posn, abstract_read_memory): New functions.
1119         [struct mem_read_abstraction]: New struct.
1120         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1121
1122 2019-05-14  Tom Tromey  <tromey@adacore.com>
1123
1124         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1125         value is not lval_memory.
1126
1127 2019-05-14  Tom Tromey  <tromey@adacore.com>
1128
1129         * solib.c (info_sharedlibrary_command): Style the file name.
1130
1131 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1132
1133         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1134         (aarch64_vnv_type): Likewise.
1135         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1136         * common/tdesc.c: Likewise.
1137         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1138         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1139         * features/aarch64-fpu.xml: Add ieee half view.
1140         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1141         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1142         * gdbtypes.h (struct builtin_type): Likewise.
1143         (struct objfile_type): Likewise.
1144
1145 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1146
1147         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1148         typo.
1149         * location.h (string_to_event_location): Likewise.
1150
1151 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1152
1153         GDB 8.3 released.
1154
1155 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1156
1157         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1158         New variable declaration.
1159         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1160         New variable.
1161         (print_one_breakpoint): Use ui_out::test_flags and new global
1162         variable to compute use_fixed_output.
1163         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1164         Remove.
1165         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1166         (mi_multi_location_breakpoint_output_fixed): Remove.
1167         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1168         new variable.
1169         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1170         fix_multi_location_breakpoint_output flag if version >= 3.
1171         * ui-out.h (enum ui_out_flag)
1172         <fix_multi_location_breakpoint_output>: New enumerator.
1173
1174 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1175
1176         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1177
1178 2019-05-10  Tom Tromey  <tromey@adacore.com>
1179
1180         * ada-lang.c (catch_ada_completer): New function.
1181         (_initialize_ada_language): Use it.
1182
1183 2019-05-10  Tom Tromey  <tromey@adacore.com>
1184
1185         * thread.c (print_thread_info): Make "requested_threads" const.
1186         * gdbthread.h (print_thread_info): Make "requested_threads"
1187         const.
1188         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1189         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1190
1191 2019-05-08  Tom Tromey  <tom@tromey.com>
1192
1193         * gdbtypes.c (objfile_type_data): Change type.
1194         (objfile_type, _initialize_gdbtypes): Update.
1195
1196 2019-05-08  Tom Tromey  <tom@tromey.com>
1197
1198         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1199         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1200         (_initialize_dwarf2_frame): Update.
1201
1202 2019-05-08  Tom Tromey  <tom@tromey.com>
1203
1204         * objc-lang.c (objc_objfile_data): Change type.
1205         (find_methods): Update.
1206         (_initialize_objc_lang): Remove.
1207
1208 2019-05-08  Tom Tromey  <tom@tromey.com>
1209
1210         * stabsread.c (rs6000_builtin_type_data): Change type.
1211         (rs6000_builtin_type, _initialize_stabsread): Update.
1212
1213 2019-05-08  Tom Tromey  <tom@tromey.com>
1214
1215         * mips-tdep.c (mips_pdr_data): Remove.
1216         (_initialize_mips_tdep): Update.
1217
1218 2019-05-08  Tom Tromey  <tom@tromey.com>
1219
1220         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1221         (hppa_init_objfile_priv_data, read_unwind_info)
1222         (find_unwind_entry, _initialize_hppa_tdep): Update.
1223
1224 2019-05-08  Tom Tromey  <tom@tromey.com>
1225
1226         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1227         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1228         on obstack.
1229         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1230
1231 2019-05-08  Tom Tromey  <tom@tromey.com>
1232
1233         * mdebugread.c (basic_type_data): Change type.
1234         (basic_type, _initialize_mdebugread): Update.
1235
1236 2019-05-08  Tom Tromey  <tom@tromey.com>
1237
1238         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1239
1240 2019-05-08  Tom Tromey  <tom@tromey.com>
1241
1242         * nto-tdep.c (nto_inferior_data_reg): Change type.
1243         (nto_inferior_data): Update.
1244         (nto_inferior_data_cleanup, nto_new_inferior_data)
1245         (_initialize_nto_tdep): Remove.
1246         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1247
1248 2019-05-08  Tom Tromey  <tom@tromey.com>
1249
1250         * ada-lang.c (struct ada_inferior_data): Add initializers.
1251         (ada_inferior_data): Change type.
1252         (ada_inferior_data_cleanup): Remove.
1253         (get_ada_inferior_data, ada_inferior_exit)
1254         (struct ada_pspace_data): Add initializers, destructor.
1255         (ada_pspace_data_handle): Change type.
1256         (get_ada_pspace_data): Update.
1257         (ada_pspace_data_cleanup): Remove.
1258
1259 2019-05-08  Tom Tromey  <tom@tromey.com>
1260
1261         * coffread.c (struct coff_symfile_info): Add initializers.
1262         (coff_objfile_data_key): Move lower.  Change type.
1263         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1264         Update.
1265         (coff_free_info): Remove.
1266
1267 2019-05-08  Tom Tromey  <tom@tromey.com>
1268
1269         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1270         (fbsd_pspace_data_handle): Move lower.  Change type.
1271         (get_fbsd_pspace_data): Update.
1272         (fbsd_pspace_data_cleanup): Remove.
1273         (_initialize_fbsd_tdep): Update.
1274
1275 2019-05-08  Tom Tromey  <tom@tromey.com>
1276
1277         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1278         (get_ada_tasks_pspace_data): Update.
1279         (ada_tasks_pspace_data_cleanup): Remove.
1280         (_initialize_tasks): Update.
1281         (ada_tasks_inferior_data_handle): Change type.
1282         (get_ada_tasks_inferior_data): Update.
1283         (ada_tasks_inferior_data_cleanup): Remove.
1284         (struct ada_tasks_pspace_data): Add initializers.
1285
1286 2019-05-08  Tom Tromey  <tom@tromey.com>
1287
1288         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1289         * symfile-debug.c (debug_sym_get_probes): Change type.
1290         * stap-probe.c (handle_stap_probe):
1291         (stap_static_probe_ops::get_probes): Change type.
1292         * probe.h (class static_probe_ops) <get_probes>: Change type.
1293         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1294         (parse_probes_in_pspace): Update.
1295         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1296         Update.
1297         (any_static_probe_ops::get_probes): Change type.
1298         * elfread.c (elfread_data): New typedef.
1299         (probe_key): Change type.
1300         (elf_get_probes): Likewise.  Update.
1301         (probe_key_free): Remove.
1302         (_initialize_elfread): Update.
1303         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1304         Change type.
1305         (dtrace_process_dof_probe, dtrace_process_dof)
1306         (dtrace_static_probe_ops::get_probe): Change type.
1307
1308 2019-05-08  Tom Tromey  <tom@tromey.com>
1309
1310         * xcoffread.c (struct xcoff_symfile_info): Rename from
1311         coff_symfile_info.  Add initializers.
1312         (xcoff_objfile_data_key): Move lower.  Change type.
1313         (XCOFF_DATA): Rewrite.
1314         (xcoff_free_info): Remove.
1315         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1316         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1317         (xcoff_initial_scan): Update.
1318
1319 2019-05-08  Tom Tromey  <tom@tromey.com>
1320
1321         * solib-svr4.c (struct svr4_info): Add initializers and
1322         destructor.
1323         <probes_table>: Now an htab_up.
1324         (solib_svr4_pspace_data): Change type.
1325         (free_probes_table): Simplify.
1326         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1327         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1328         (probes_table_remove_objfile_probes, register_solib_event_probe)
1329         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1330         (_initialize_svr4_solib): Update.
1331
1332 2019-05-08  Tom Tromey  <tom@tromey.com>
1333
1334         * remote.c (remote_pspace_data): Change type.
1335         (remote_pspace_data_cleanup): Remove.
1336         (get_remote_exec_file, set_pspace_remote_exec_file)
1337         (_initialize_remote): Update.
1338
1339 2019-05-08  Tom Tromey  <tom@tromey.com>
1340
1341         * breakpoint.c (breakpoint_objfile_key): Change type.
1342         (get_breakpoint_objfile_data): Update.
1343         (free_breakpoint_objfile_data): Remove.
1344         (_initialize_breakpoint): Update.
1345
1346 2019-05-08  Tom Tromey  <tom@tromey.com>
1347
1348         * linux-tdep.c (struct linux_info): Add initializers.
1349         (linux_inferior_data): Move.  Change type.
1350         (invalidate_linux_cache_inf): Update.
1351         (linux_inferior_data_cleanup): Remove.
1352         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1353
1354 2019-05-08  Tom Tromey  <tom@tromey.com>
1355
1356         * auxv.c (auxv_inferior_data): Move.  Change type.
1357         (auxv_inferior_data_cleanup): Remove.
1358         (invalidate_auxv_cache_inf): Rewrite.
1359         (get_auxv_inferior_data, _initialize_auxv): Update.
1360
1361 2019-05-08  Tom Tromey  <tom@tromey.com>
1362
1363         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1364         (symfile_debug_objfile_data_key): Change type.
1365         (symfile_debug_installed, debug_qf_has_symbols)
1366         (debug_qf_find_last_source_symtab)
1367         (debug_qf_forget_cached_source_info)
1368         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1369         (debug_qf_print_stats, debug_qf_dump)
1370         (debug_qf_expand_symtabs_for_function)
1371         (debug_qf_expand_all_symtabs)
1372         (debug_qf_expand_symtabs_with_fullname)
1373         (debug_qf_map_matching_symbols)
1374         (debug_qf_expand_symtabs_matching)
1375         (debug_qf_find_pc_sect_compunit_symtab)
1376         (debug_qf_map_symbol_filenames)
1377         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1378         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1379         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1380         (debug_sym_read_linetable, debug_sym_relocate): Update.
1381         (symfile_debug_free_objfile): Remove.
1382         (install_symfile_debug_logging, _initialize_symfile_debug):
1383         Update.
1384
1385 2019-05-08  Tom Tromey  <tom@tromey.com>
1386
1387         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1388         allocate_on_obstack.
1389         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1390         (get_dwarf2_per_objfile): Update.
1391         (set_dwarf2_per_objfile): Remove.
1392         (dwarf2_has_info, dwarf2_get_section_info): Update.
1393         (dwarf2_free_objfile): Remove.
1394         (_initialize_dwarf2_read): Update.
1395
1396 2019-05-08  Tom Tromey  <tom@tromey.com>
1397
1398         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1399         initializers.
1400         <unsupported_script_warning_printed,
1401         script_not_found_warning_printed>: Now bool.
1402         (auto_load_pspace_data): Change type.
1403         (~auto_load_pspace_info): Rename from
1404         auto_load_pspace_data_cleanup.
1405         (get_auto_load_pspace_data, init_loaded_scripts_info)
1406         (clear_section_scripts, maybe_print_unsupported_script_warning)
1407         (maybe_print_script_not_found_warning, _initialize_auto_load):
1408         Update.
1409
1410 2019-05-08  Tom Tromey  <tom@tromey.com>
1411
1412         * objfiles.c (objfile_pspace_info): Add destructor and
1413         initializers.
1414         (objfiles_pspace_data): Change type.
1415         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1416         (get_objfile_pspace_data): Update.
1417         (objfiles_bfd_data): Change type.
1418         (get_objfile_bfd_data): Update.
1419         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1420
1421 2019-05-08  Tom Tromey  <tom@tromey.com>
1422
1423         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1424         Change type.
1425         (get_catch_syscall_inferior_data): Update.
1426         (catch_syscall_inferior_data_cleanup): Remove.
1427         (_initialize_break_catch_syscall): Update.
1428
1429 2019-05-08  Tom Tromey  <tom@tromey.com>
1430
1431         * inflow.c (struct terminal_info): Add destructor and
1432         initializers.
1433         (inflow_inferior_data): Change type.
1434         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1435         (get_inflow_inferior_data, inflow_inferior_exit)
1436         (swap_terminal_info, _initialize_inflow): Update.
1437
1438 2019-05-08  Tom Tromey  <tom@tromey.com>
1439
1440         * target-dcache.c (target_dcache_cleanup): Remove.
1441         (target_dcache_aspace_key): Change type.
1442         (target_dcache_init_p, target_dcache_invalidate)
1443         (target_dcache_get, target_dcache_get_or_init)
1444         (_initialize_target_dcache): Update.
1445         * dcache.h (struct dcache_deleter): New.
1446
1447 2019-05-08  Tom Tromey  <tom@tromey.com>
1448
1449         * symtab.c (struct symbol_cache): Add destructor and
1450         initializers.
1451         (symbol_cache_key): Move.  Change type.
1452         (make_symbol_cache, free_symbol_cache): Remove.
1453         (get_symbol_cache): Update.
1454         (symbol_cache_cleanup): Remove.
1455         (ALL_PSPACES, symbol_cache_flush)
1456         (maintenance_print_symbol_cache)
1457         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1458         Update.
1459
1460 2019-05-08  Tom Tromey  <tom@tromey.com>
1461
1462         * symtab.c (struct main_info): Add destructor and initializers.
1463         (main_progspace_key): Move.  Change type.
1464         (get_main_info): Update.
1465         (main_info_cleanup): Remove.
1466         (_initialize_symtab): Update.
1467
1468 2019-05-08  Tom Tromey  <tom@tromey.com>
1469
1470         * registry.h (DECLARE_REGISTRY): Define the _key class.
1471
1472 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1473
1474         * NEWS: Merge two 'New commands' sections.
1475
1476 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1477
1478         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1479         parameter and use Ada language definition instead.
1480         (ada_val_print_ptr): Remove unused language parameter.
1481         (ada_val_print_num): Remove language parameter and use Ada language
1482         definition instead.
1483         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1484         parameter.
1485         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1486         parameter and use Ada language definition instead.
1487         (ada_val_print_1): Update all ada_val_print_xxx calls.
1488         Remove language parameter.
1489         (ada_val_print): Update ada_val_print_1 call.
1490
1491 2019-05-08  Tom Tromey  <tromey@adacore.com>
1492
1493         * remote.c (remote_hw_watchpoint_limit)
1494         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1495         Now static.
1496
1497 2019-05-08  Tom Tromey  <tromey@adacore.com>
1498
1499         * maint.c (_initialize_maint_cmds): Move initialization code to
1500         remote.c.
1501         (watchdog, show_watchdog): Move to remote.c.
1502         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1503         "watchdog" static.
1504         (_initialize_remote): Move initialization code from maint.c.
1505         * defs.h (watchdog): Don't declare.
1506
1507 2019-05-08  Tom Tromey  <tromey@adacore.com>
1508
1509         * tui/tui-interp.c: Include main.h.
1510         * interps.c: Include main.h.
1511         * main.h (interpreter_p): Declare.
1512         * defs.h (interpreter_p): Don't declare.
1513
1514 2019-05-08  Tom Tromey  <tromey@adacore.com>
1515
1516         * dwarf2loc.c: Include dwarf2read.h.
1517         * defs.h (read_unsigned_leb128): Don't declare.
1518         * dwarf2read.h (read_unsigned_leb128): Declare.
1519
1520 2019-05-08  Tom Tromey  <tromey@adacore.com>
1521
1522         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1523         method.
1524
1525 2019-05-08  Tom Tromey  <tromey@adacore.com>
1526
1527         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1528         when no wrap column is set.
1529
1530 2019-05-08  Tom Tromey  <tromey@adacore.com>
1531
1532         * c-lang.c (c_get_string): Handle non-C-style arrays.
1533
1534 2019-05-08  Tom Tromey  <tromey@adacore.com>
1535
1536         * typeprint.c (print_offset_data::update): Print the bit offset,
1537         not the number of bits remaining.
1538
1539 2019-05-08  Tom Tromey  <tromey@adacore.com>
1540
1541         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1542         padding at end of comment.
1543
1544 2019-05-08  Tom Tromey  <tromey@adacore.com>
1545
1546         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1547         Compare main types.
1548
1549 2019-05-06  Tom Tromey  <tom@tromey.com>
1550
1551         * common/scoped_mmap.c: Include common-defs.h.
1552         * common/scoped_mmap.h: Don't include config.h.
1553
1554 2019-05-04  Tom Tromey  <tom@tromey.com>
1555
1556         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1557         (struct aarch64_call_info): Add initializers.
1558         <si>: Now a std::vector.
1559         (pass_on_stack, aarch64_push_dummy_call): Update.
1560
1561 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1562             Tom Tromey  <tom@tromey.com>
1563
1564         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1565         (ppc_threads): Now a std::vector.  Now static.
1566         (hwdebug_find_thread_points_by_tid)
1567         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1568         Update.
1569
1570 2019-05-04  Tom Tromey  <tom@tromey.com>
1571
1572         * arc-tdep.c (arc_tdesc_init): Return bool.
1573
1574 2019-05-04  Tom Tromey  <tom@tromey.com>
1575
1576         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1577         Use gdb_assert_not_reached.
1578
1579 2019-05-04  Tom Tromey  <tom@tromey.com>
1580
1581         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1582         "false".
1583
1584 2019-05-04  Tom Tromey  <tom@tromey.com>
1585
1586         * arc-tdep.c (arc_tdesc_init): Use bool.
1587
1588 2019-05-04  Tom Tromey  <tom@tromey.com>
1589
1590         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1591
1592 2019-05-04  Tom Tromey  <tom@tromey.com>
1593
1594         * cli/cli-cmds.c (valid_command_p): Return bool.
1595
1596 2019-05-04  Tom Tromey  <tom@tromey.com>
1597
1598         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1599         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1600
1601 2019-05-04  Raul Tambre  <raul@tambre.ee>
1602
1603         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1604         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1605         operator for comparison.
1606
1607 2019-05-04  Tom Tromey  <tom@tromey.com>
1608
1609         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1610         (lookup_partial_symbol, print_partial_symbols)
1611         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1612         (psymbol_compare): Update.
1613         (add_psymbol_to_bcache): Clear the entire psymbol.
1614         (maintenance_check_psymtabs): Update.
1615         * psympriv.h (struct partial_symbol): Don't derive from
1616         general_symbol_info.
1617         <obj_section, unrelocated_address, address,
1618         set_unrelocated_address>: Update.
1619         <ginfo>: New member.
1620         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1621         (debug_names::write_psymbols): Update.
1622
1623 2019-05-04  Tom de Vries  <tdevries@suse.de>
1624
1625         * contrib/cc-with-tweaks.sh: Support -n arg.
1626
1627 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1628
1629         * corelow.c (core_target::detach): Ensure frame cache and
1630         register caches are cleared.
1631         inferior.c (exit_inferior_1): Likewise.
1632
1633 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1634             Tom Tromey  <tom@tromey.com>
1635
1636         * dictionary.c (collate_pending_symbols_by_language): Remove
1637         "struct" from foreach.
1638         * symtab.c (lookup_global_symbol_from_objfile)
1639         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1640         foreach.
1641         * ser-tcp.c (net_open): Remove "struct" from foreach.
1642         * objfiles.c (objfile_relocate, objfile_rebase)
1643         (objfile_has_symbols): Remove "struct" from foreach.
1644         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1645         from foreach.
1646         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1647         foreach.
1648         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1649         "struct" from foreach.
1650         * ada-lang.c (create_excep_cond_exprs)
1651         (ada_exception_catchpoint_cond_string): Remove "struct" from
1652         foreach.
1653
1654 2019-05-03  Tom Tromey  <tromey@adacore.com>
1655
1656         * ada-exp.y (convert_char_literal): Check suffix of each
1657         enumerator.
1658
1659 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1660
1661         PR ada/21406:
1662         * ada-exp.y (yywrap): Don't define.
1663         * ada-lex.l (%option): Add noyywrap
1664         (yywrap): Remove.
1665
1666 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1667
1668         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1669         _WIN32_WINNT to the XP level, unless already defined to a higher
1670         level.
1671
1672         * unittests/parse-connection-spec-selftests.c:
1673         * ser-tcp.c:
1674         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1675         override.
1676
1677         * symfile.c (find_separate_debug_file): Remove colon from the
1678         drive spec of DOS/Windows file names of the target, so that the
1679         file name produced from DEBUGDIR and the target's directory will
1680         be valid on DOS/Windows systems.
1681
1682 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1683
1684         * rust-lang.c (val_print_struct): Handle printing structures
1685         containing strings.
1686
1687 2019-05-02  Tom Tromey  <tromey@adacore.com>
1688
1689         * valarith.c (_initialize_valarith): Remove.
1690
1691 2019-05-01  Tom Tromey  <tromey@adacore.com>
1692
1693         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1694         bitfields.
1695
1696 2019-05-01  Tom Tromey  <tromey@adacore.com>
1697
1698         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1699         for big-endian copies.
1700
1701 2019-04-30  Ali Tamur  <tamur@google.com>
1702         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1703         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1704         (read_3_bytes): New function.
1705
1706 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1707
1708         * windows-nat.c (main_thread_id): Delete.
1709         (handle_output_debug_string): Replace main_thread_id by
1710         current_event.dwThreadId.
1711         (fake_create_process): Likewise.
1712         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1713         Do not set main_thread_id.
1714         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1715         current_event.dwThreadId.
1716         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1717
1718 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1719
1720         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1721         Use current_event.dwThreadId instead of main_thread_id.
1722
1723 2019-04-30  Tom Tromey  <tromey@adacore.com>
1724
1725         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1726         (create_excep_cond_exprs): Iterate over program spaces.
1727         (ada_exception_catchpoint_cond_string): Examine all minimal
1728         symbols for exception types.
1729
1730 2019-04-30  Tom Tromey  <tromey@adacore.com>
1731
1732         PR c++/24470:
1733         * dwarf2read.c (process_structure_scope): Handle case where type
1734         has template parameters but no symbol was created.
1735
1736 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1737             Chris January  <chris.january@arm.com>
1738
1739         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1740         qualifier.
1741         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1742
1743 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1744
1745         * f-typeprint.c (f_print_type): Update rules for printing
1746         whitespace.
1747         (f_type_print_varspec_suffix): Likewise.
1748
1749 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1750             Chris January  <chris.january@arm.com>
1751
1752         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1753         function arguments.
1754
1755 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1756
1757         * f-lang.c (build_fortran_types): Change name of void type to
1758         lower case.
1759         * f-typeprint.c (f_type_print_base): Print the name of the void
1760         type, rather than a fixed string.
1761         * f-valprint.c (f_decorations): Use lower case void string.
1762
1763 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1764             Chris January  <chris.january@arm.com>
1765
1766         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1767         types for Fortran.
1768
1769 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1770             Chris January  <chris.january@arm.com>
1771             David Lecomber  <david.lecomber@arm.com>
1772
1773         * f-exp.y (BINOP_INTRINSIC): New token.
1774         (exp): New parser rule handling BINOP_INTRINSIC.
1775         (f77_keywords): Add new builtin procedures.
1776         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1777         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1778         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1779         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1780         (print_unop_subexp_f): New function.
1781         (print_binop_subexp_f): New function.
1782         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1783         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1784         (dump_subexp_body_f): Likewise.
1785         (operator_check_f): Likewise.
1786         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1787         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1788
1789 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1790
1791         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1792         UNOP_KIND.
1793         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1794         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1795         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1796         (operator_length_f): New fuction.
1797         (print_subexp_f): New function.
1798         (op_name_f): New function.
1799         (dump_subexp_body_f): New function.
1800         (operator_check_f): New function.
1801         (exp_descriptor_f): Replace standard expression handling functions
1802         with new functions.
1803         * gdb/fortran-operator.def: New file.
1804         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1805         * gdb/std-operator.def: Remove UNOP_KIND.
1806
1807 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1808
1809         * std-operator.def: Remove unbalanced, stray double quote
1810         character.
1811
1812 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1813             Chris January  <chris.january@arm.com>
1814             Daniel Everett  <daniel.everett@arm.com>
1815             Nick Forrington  <nick.forrington@arm.com>
1816             Richard Bunt  <richard.bunt@arm.com>
1817
1818         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1819         of depth when printing anonymous structs or unions.
1820         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1821         Don't print either the top-level value, or the children if the
1822         max-depth is exceeded.
1823         (ppscm_print_children): When printing the key of a map, allow one
1824         extra level of depth.
1825         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1826         print either the top-level value, or the children if the max-depth
1827         is exceeded.
1828         (print_children): When printing the key of a map, allow one extra
1829         level of depth.
1830         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1831         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1832         (user_print_options): Initialise max_depth field.
1833         (val_print_scalar_or_string_type_p): New function.
1834         (val_print): Check to see if the max depth has been reached.
1835         (val_print_check_max_depth): Define new function.
1836         (show_print_max_depth): New function.
1837         (_initialize_valprint): Add 'print max-depth' option.
1838         * valprint.h (struct value_print_options) <max_depth>: New field.
1839         (val_print_check_max_depth): Declare new function.
1840         * NEWS: Document new feature.
1841
1842 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1843
1844         * ada-lang.c (ada_language_defn): Initialise new field.
1845         * c-lang.c (c_is_string_type_p): New function.
1846         (c_language_defn): Initialise new field.
1847         (cplus_language_defn): Initialise new field.
1848         (asm_language_defn): Initialise new field.
1849         (minimal_language_defn): Initialise new field.
1850         * c-lang.h (c_is_string_type_p): Declare new function.
1851         * d-lang.c (d_language_defn): Initialise new field.
1852         * f-lang.c (f_is_string_type_p): New function.
1853         (f_language_defn): Initialise new field.
1854         * go-lang.c (go_is_string_type_p): New function.
1855         (go_language_defn): Initialise new field.
1856         * language.c (default_is_string_type_p): New function.
1857         (unknown_language_defn): Initialise new field.
1858         (auto_language_defn): Initialise new field.
1859         * language.h (struct language_defn) <la_is_string_type_p>: New
1860         member variable.
1861         (default_is_string_type_p): Declare new function.
1862         * m2-lang.c (m2_language_defn): Initialise new field.
1863         * objc-lang.c (objc_language_defn): Initialise new field.
1864         * opencl-lang.c (opencl_language_defn): Initialise new field.
1865         * p-lang.c (pascal_is_string_type_p): New function.
1866         (pascal_language_defn): Initialise new field.
1867         * rust-lang.c (rust_is_string_type_p): New function.
1868         (rust_language_defn): Initialise new field.
1869
1870 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1871
1872         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1873         New field.
1874         * ada-lang.c (ada_language_defn): Initialise new field.
1875         * c-lang.c (c_language_defn): Likewise.
1876         (cplus_language_defn): Likewise.
1877         (asm_language_defn): Likewise.
1878         (minimal_language_defn): Likewise.
1879         * d-lang.c (d_language_defn): Likewise.
1880         * f-lang.c (f_language_defn): Likewise.
1881         * go-lang.c (go_language_defn): Likewise.
1882         * language.c (unknown_language_defn): Likewise.
1883         (auto_language_defn): Likewise.
1884         * m2-lang.c (m2_language_defn): Likewise.
1885         * objc-lang.c (objc_language_defn): Likewise.
1886         * opencl-lang.c (opencl_language_defn): Likewise.
1887         * p-lang.c (pascal_language_defn): Likewise.
1888         * rust-lang.c (rust_language_defn): Likewise.
1889
1890 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1891
1892         * ada-lang.c (ada_is_character_type): Change return type to bool.
1893         (ada_is_string_type): Likewise.
1894         * ada-lang.h (ada_is_character_type): Update declaration
1895         (ada_is_string_type): Likewise.
1896
1897 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1898
1899         Support style in 'frame|thread apply'
1900
1901         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1902         * record.c (record_start, record_stop): Update callers of
1903         execute_command_to_string with false.
1904         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1905         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1906         methods.
1907         (class string_file): New constructor with term_out parameter.
1908         Override methods term_out and can_emit_style_escape.  New member
1909         term_out.
1910         (class stdio_file): Override can_emit_style_escape.
1911         (class tee_file): Override term_out and can_emit_style_escape.
1912         * utils.h (can_emit_style_escape): Remove.
1913         * utils.c (can_emit_style_escape): Likewise.
1914         Update all callers of can_emit_style_escape (SOMESTREAM) to
1915         SOMESTREAM->can_emit_style_escape.
1916         * source-cache.c (source_cache::get_source_lines): Likewise.
1917         * stack.c (frame_apply_command_count): Call execute_command_to_string
1918         passing the term_out characteristic of the current gdb_stdout.
1919         * thread.c (thr_try_catch_cmd): Likewise.
1920         * top.c (execute_command_to_string): pass term_out parameter
1921         to construct the string_file for the command output.
1922         * ui-file.c (term_cli_styling): New function (most code moved
1923         from utils.c can_emit_style_escape).
1924         (string_file::string_file, string_file::can_emit_style_escape,
1925         stdio_file::can_emit_style_escape, tee_file::term_out,
1926         tee_file::can_emit_style_escape): New functions.
1927
1928 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1929
1930         * NEWS: Mention the new set|show may-call-functions.
1931         * infcall.c (may_call_functions_p): New variable.
1932         (show_may_call_functions_p): New function.
1933         (call_function_by_hand_dummy): Throws an error if not
1934         may-call-functions.
1935         (_initialize_infcall): Call add_setshow_boolean_cmd for
1936         may-call-functions.
1937
1938 2019-04-25  Keith Seitz  <keiths@redhat.com>
1939
1940         PR c++/24367
1941         * cp-support.c (inspect_type): Don't attempt substitutions
1942         of symbol with the same name.
1943
1944 2019-04-25  Tom Tromey  <tromey@adacore.com>
1945
1946         PR gdb/24475:
1947         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1948         static.
1949
1950 2019-04-25  Tom Tromey  <tromey@adacore.com>
1951
1952         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1953         rvalue reference.
1954         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1955         (gdb_xml_parser::parse): Use std::move.
1956         * python/python-internal.h (gdbpy_convert_exception): Take a const
1957         reference.
1958         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1959         std::move.
1960         * python/py-utils.c (gdbpy_convert_exception): Take a const
1961         reference.
1962         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1963         Use std::move.
1964         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1965         Use std::move.
1966         * mi/mi-main.c (mi_print_exception): Take a const reference.
1967         * main.c (handle_command_errors): Take a const reference.
1968         * linespec.c (parse_linespec): Use std::move.
1969         * infcall.c (run_inferior_call): Use std::move.
1970         (call_function_by_hand_dummy): Use std::move.
1971         * exec.c (try_open_exec_file): Use std::move.
1972         * exceptions.h (exception_print, exception_fprintf)
1973         (exception_print_same): Update.
1974         * exceptions.c (print_exception, exception_print)
1975         (exception_fprintf, exception_print_same): Change parameters to
1976         const reference.
1977         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1978         * common/new-op.c: Use std::move.
1979         * common/common-exceptions.h (struct gdb_exception): Add move
1980         constructor.
1981         (struct gdb_exception_error, struct gdb_exception_quit, struct
1982         gdb_quit_bad_alloc): Change constructor to move constructor.
1983         (throw_exception): Change parameter to rvalue reference.
1984         * common/common-exceptions.c (throw_exception): Take rvalue
1985         reference.
1986         * cli/cli-interp.c (safe_execute_command): Use std::move.
1987         * breakpoint.c (insert_bp_location, location_to_sals): Use
1988         std::move.
1989
1990 2019-04-25  Tom Tromey  <tromey@adacore.com>
1991
1992         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1993         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1994         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1995         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1996         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1997         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1998         guile/scm-value.c: Use unpack.
1999         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2000         gdbscm_gdb_exception.
2001         (gdbscm_throw_gdb_exception): Likewise.
2002         (struct gdbscm_gdb_exception): New.
2003         (unpack): New function.
2004         (gdbscm_wrap): Use unpack.
2005
2006 2019-04-25  Tom Tromey  <tromey@adacore.com>
2007
2008         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2009         (gdb_rl_callback_handler): Use std::move.
2010         * common/common-exceptions.h (struct gdb_exception): Add move
2011         assignment operator.
2012         (throw_exception_sjlj): Change "exception" to const reference.
2013         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2014         (throw_exception_sjlj): Change "exception" to const reference.
2015
2016 2019-04-25  Tom Tromey  <tromey@adacore.com>
2017
2018         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2019         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2020         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2021         Update.
2022         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2023         Update.
2024         * mi/mi-interp.c (mi_interp::exec): Update.
2025         * linespec.c (parse_linespec): Update.
2026         * infcall.c (run_inferior_call): Update.
2027         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2028         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2029         (gdbscm_lookup_global_symbol): Update.
2030         * guile/scm-param.c (gdbscm_parameter_value): Update.
2031         * guile/scm-frame.c (gdbscm_frame_read_register)
2032         (gdbscm_frame_read_var): Update.
2033         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2034         * exec.c (try_open_exec_file): Update.
2035         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2036         (gdb_rl_callback_handler): Update.
2037         * common/common-exceptions.h (exception_none): Don't declare.
2038         * common/common-exceptions.c (exception_none): Don't define.
2039         (struct catcher) <exception>: Update.
2040         * cli/cli-interp.c (safe_execute_command): Update.
2041         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2042
2043 2019-04-25  Ali Tamur  <tamur@google.com>
2044
2045         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2046         (read_attribute_value): Likewise.
2047         (dwarf2_read_addr_index): Update comment.
2048         (read_str_index): Add DW_FORM_strx.
2049         (dwarf2_string_attr): Likewise.
2050         (dwarf2_const_value_attr): Likewise.
2051         (dump_die_shallow): Likewise.
2052         (dwarf2_fetch_constant_bytes): Likewise.
2053         (skip_form_bytes): Likewise.
2054         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2055
2056 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2057
2058         PR corefiles/11608
2059         PR corefiles/18187
2060         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2061         OFFSET.  Verify if current mapping contains an ELF header.
2062         (linux_find_memory_regions_full): Adjust call to
2063         dump_mapping_p.
2064
2065 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2066             Kang Li <kanglictf@gmail.com>
2067
2068         PR gdb/21600
2069
2070         * dwarf2-frame.c (read_initial_length): Be consistent about using
2071         unsigned representation of length.
2072         (decode_frame_entry_1): Likewise.  Check for wraparound of
2073         end pointer as well as buffer overflow.
2074
2075 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2076
2077         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2078         "vq".
2079
2080 2019-04-24  Tom Tromey  <tromey@adacore.com>
2081
2082         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2083
2084 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2085
2086         * s12z-tdep.c (s12z_unwind_pc): Delete.
2087         (s12z_unwind_sp): Delete.
2088         (s12z_gdbarch_init): Don't register deleted functions with
2089         gdbarch.
2090
2091 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2092
2093         * rl78-tdep.c (rl78_unwind_sp): Delete.
2094         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2095
2096 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2097
2098         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2099         (xstormy16_unwind_pc): Delete.
2100         (xstormy16_dummy_id): Delete.
2101         (xstormy16_gdbarch_init): Don't register deleted functions with
2102         gdbarch.
2103
2104 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2105
2106         * vax-tdep.c (vax_unwind_pc): Delete.
2107         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2108
2109 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2110
2111         * v850-tdep.c (v850_unwind_sp): Delete.
2112         (v850_unwind_pc): Delete.
2113         (v850_dummy_id): Delete.
2114         (v850_gdbarch_init): Don't register deleted functions with
2115         gdbarch.
2116
2117 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2118
2119         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2120         (tilegx_unwind_pc): Delete.
2121         (tilegx_unwind_dummy_id): Delete.
2122         (tilegx_gdbarch_init): Don't register deleted functions with
2123         gdbarch.
2124
2125 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2126
2127         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2128         (tic6x_dummy_id): Delete.
2129         (tic6x_gdbarch_init): Don't register deleted functions with
2130         gdbarch.
2131
2132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2133
2134         * sparc-tdep.c (sparc_unwind_pc): Delete.
2135         (sparc32_gdbarch_init): Don't register deleted function with
2136         gdbarch.
2137
2138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2139
2140         * sh-tdep.c (sh_unwind_sp): Delete.
2141         (sh_unwind_pc): Delete.
2142         (sh_dummy_id): Delete.
2143         (sh_gdbarch_init): Don't register deleted functions with
2144         gdbarch.
2145
2146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2147
2148         * score-tdep.c (score_unwind_sp): Delete.
2149         (score_unwind_pc): Delete.
2150         (score_dummy_id): Delete.
2151         (score_gdbarch_init): Don't register deleted functions with
2152         gdbarch.
2153
2154 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2155
2156         * rx-tdep.c (rx_unwind_pc): Delete.
2157         (rx_unwind_sp): Delete.
2158         (rx_dummy_id): Delete.
2159         (rx_gdbarch_init): Don't register deleted functions with
2160         gdbarch.  Update comment.
2161
2162 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2163
2164         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2165         (rs6000_dummy_id): Delete.
2166         (rs6000_gdbarch_init): Don't register deleted functions with
2167         gdbarch.
2168
2169 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2170
2171         * or1k-tdep.c (or1k_dummy_id): Delete.
2172         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2173
2174 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2175
2176         * nios2-tdep.c (nios2_dummy_id): Delete.
2177         (nios2_unwind_sp): Delete.
2178         (nios2_gdbarch_init): Don't register deleted functions with
2179         gdbarch.
2180
2181 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2182
2183         * nds32-tdep.c (nds32_dummy_id): Delete.
2184         (nds32_unwind_pc): Delete.
2185         (nds32_unwind_sp): Delete.
2186         (nds32_gdbarch_init): Don't register deleted functions with
2187         gdbarch.
2188
2189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2190
2191         * msp430-tdep.c (msp430_unwind_pc): Delete.
2192         (msp430_unwind_sp): Delete.
2193         (msp430_dummy_id): Delete.
2194         (msp430_gdbarch_init): Don't register deleted functions with
2195         gdbarch.
2196
2197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2198
2199         * moxie-tdep.c (moxie_unwind_sp): Delete.
2200         (moxie_unwind_pc): Delete.
2201         (moxie_dummy_id): Delete.
2202         (moxie_gdbarch_init): Don't register deleted functions with
2203         gdbarch.
2204
2205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2206
2207         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2208         (mn10300_unwind_pc): Delete.
2209         (mn10300_unwind_sp): Delete.
2210         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2211         mn10300_unwind_sp.
2212         (mn10300_frame_unwind_init): Don't register deleted functions with
2213         gdbarch.
2214
2215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2216
2217         * mep-tdep.c (mep_unwind_pc): Delete.
2218         (mep_unwind_sp): Delete.
2219         (mep_dummy_id): Delete.
2220         (mep_gdbarch_init): Don't register deleted functions with
2221         gdbarch.
2222
2223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2224
2225         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2226         (m68hc11_unwind_sp): Delete.
2227         (m68hc11_gdbarch_init): Don't register deleted functions with
2228         gdbarch.
2229
2230 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2231
2232         * m32r-tdep.c (m32r_unwind_sp): Delete.
2233         (m32r_unwind_pc): Delete.
2234         (m32r_dummy_id): Delete.
2235         (m32r_gdbarch_init): Don't register deleted functions with
2236         gdbarch.
2237
2238 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2239
2240         * m32c-tdep.c (m32c_unwind_pc): Delete.
2241         (m32c_unwind_sp): Delete.
2242         (m32c_dummy_id): Delete.
2243         (m32c_gdbarch_init): Don't register deleted functions with
2244         gdbarch.
2245
2246 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2247
2248         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2249         (lm32_unwind_pc): Delete.
2250         (lm32_dummy_id): Delete.
2251         (lm32_gdbarch_init): Don't register deleted functions with
2252         gdbarch.
2253
2254 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2255
2256         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2257         (iq2000_unwind_pc): Delete.
2258         (iq2000_dummy_id): Delete.
2259         (iq2000_gdbarch_init): Don't register deleted functions with
2260         gdbarch.
2261
2262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2263
2264         * nds32-tdep.c (nds32_type_align): Delete.
2265         (nds32_push_dummy_call): Use type_align instead.
2266
2267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2268
2269         * arm-tdep.c (arm_type_align): Only handle vector override case.
2270         (arm_push_dummy_call): Use type_align.
2271         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2272
2273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2274
2275         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2276         case.
2277         (pass_on_stack): Use type_align.
2278         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2279         function.
2280
2281 2019-04-23  Tom Tromey  <tromey@adacore.com>
2282
2283         * dwarf2read.c (line_header::file_name_at): Remove unused
2284         overload.
2285
2286 2019-04-23  Tom de Vries  <tdevries@suse.de>
2287
2288         PR gdb/24438
2289         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2290         invocation.
2291
2292
2293 2019-03-27  Ali Tamur  <tamur@google.com>
2294
2295         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2296         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2297         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2298         (dwarf_expr_context::get_addr_index): Likewise
2299         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2300         (symbol_needs_eval_context::get_addr_index): Likewise
2301         (disassemble_dwarf_expression): Add DW_OP_addrx
2302         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2303         (read_cutu_die_from_dwo): Update comment
2304         (skip_one_die): Add DW_FORM_addrx
2305         (read_attribute_value): Likewise
2306         (var_decode_location): Add DW_OP_addrx
2307         (dwarf2_const_value_attr): Add DW_FORM_addrx
2308         (dump_die_shallow): Likewise
2309         (dwarf2_fetch_constant_bytes): Likewise
2310         (decode_locdesc): Add DW_OP_addrx
2311         (skip_form_bytes): Add DW_FORM_addrx
2312
2313 2019-04-22  Ali Tamur  <tamur@google.com>
2314
2315         * MAINTAINERS (Write After Approval): Add self.
2316
2317 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2318
2319         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2320         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2321         (open_symbol_file_object): Likewise.
2322         (svr4_default_sos): Add info parameter.
2323         (svr4_read_so_list): Likewise.
2324         (svr4_current_sos_direct): Adjust functions calls to pass down
2325         info.
2326         (svr4_current_sos_1): Add info parameter.
2327         (svr4_current_sos): Call get_svr4_info, pass info down to
2328         svr4_current_sos_1.
2329         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2330         get_svr4_info.
2331         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2332         get_svr4_info.
2333         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2334         to get_svr4_info.
2335         (probes_table_remove_objfile_probes): Likewise.
2336         (register_solib_event_probe): Add info parameter.
2337         (solist_update_incremental): Pass info parameter down to
2338         svr4_read_so_list.
2339         (disable_probes_interface): Add info parameter.
2340         (svr4_handle_solib_event): Pass current_program_space to
2341         get_svr4_info.  Adjust disable_probes_interface cleanup.
2342         (svr4_create_probe_breakpoints): Add info parameter, pass it
2343         down to register_solib_event_probe.
2344         (svr4_create_solib_event_breakpoints): Add info parameter,
2345         pass it down to svr4_create_probe_breakpoints.
2346         (enable_break): Pass info down to
2347         svr4_create_solib_event_breakpoints.
2348         (svr4_solib_create_inferior_hook): Pass current_program_space to
2349         get_svr4_info.
2350         (svr4_clear_solib): Likewise.
2351
2352 2019-04-22  Pedro Alves  <palves@redhat.com>
2353
2354         * solib-svr4.c (svr4_free_objfile_observer): New.
2355         (probe_and_action::objfile): New field.
2356         (probes_table_htab_remove_objfile_probes)
2357         (probes_table_remove_objfile_probes): New functions.
2358         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2359         in the new probe_and_action.  Don't store the probe in 'lookup'.
2360         (svr4_create_probe_breakpoints): Pass objfile to
2361         register_solib_event_probe.
2362         (_initialize_svr4_solib): Register a free_objfile observer.
2363
2364 2019-04-19  Tom Tromey  <tom@tromey.com>
2365
2366         * common/queue.h: Remove.
2367
2368 2019-04-19  Tom Tromey  <tom@tromey.com>
2369
2370         * event-loop.c: Don't include "common/queue.h".
2371
2372 2019-04-19  Tom Tromey  <tom@tromey.com>
2373
2374         * remote.c (remote_target): Use delete.
2375         * remote-notif.h: Include <list>, not "common/queue.h".
2376         (notif_client_p): Remove typedef.
2377         (remote_notif_state): Add constructor, destructor, initializer.
2378         <notif_queue>: Now a std::list.
2379         (remote_notif_state_xfree): Don't declare.
2380         * remote-notif.c (remote_notif_process, handle_notification)
2381         (remote_notif_state_allocate): Update.
2382         (~remote_notif_state): Rename from remote_notif_state_xfree.
2383
2384 2019-04-19  Tom Tromey  <tom@tromey.com>
2385
2386         * symfile.c (reread_symbols): Update.
2387         * objfiles.c (objfile_register_static_link)
2388         (objfile_lookup_static_link): Update
2389         (~objfile) Don't delete static_links.
2390         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2391
2392 2019-04-19  Tom Tromey  <tom@tromey.com>
2393
2394         * type-stack.h (struct type_stack) <insert>: Constify string.
2395         * type-stack.c (type_stack::insert): Constify string.
2396         * gdbtypes.h (lookup_template_type): Update.
2397         (address_space_name_to_int): Update.
2398         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2399         const.
2400         (lookup_template_type): Make name const.
2401         * c-exp.y: Update rules.
2402         (lex_one_token, classify_name, classify_inner_name)
2403         (c_print_token): Update.
2404         * p-exp.y: Update rules.
2405         (yylex): Update.
2406         * f-exp.y: Update rules.
2407         (yylex): Update.
2408         * d-exp.y: Update rules.
2409         (lex_one_token, classify_name, classify_inner_name): Update.
2410         * parse.c (write_dollar_variable, copy_name): Return std::string.
2411         * parser-defs.h (copy_name): Change return type.
2412         * m2-exp.y: Update rules.
2413         (yylex): Update.
2414         * go-exp.y (lex_one_token): Update.
2415         Update rules.
2416         (classify_unsafe_function, classify_packaged_name)
2417         (classify_name, yylex): Update.
2418
2419 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2420
2421         * configure.ac: add --enable-source-highlight switch.
2422         * configure: Regenerate.
2423         * top.c (print_gdb_version): plumb --enable-source-highlight
2424         status to "show configuration".
2425
2426 2019-04-19  Tom Tromey  <tromey@adacore.com>
2427
2428         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2429         Check ADA_TYPE_P.
2430         (empty_record, ada_template_to_fixed_record_type_1)
2431         (template_to_static_fixed_type)
2432         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2433         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2434         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2435         macros.
2436
2437 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2438
2439         PR symtab/24423:
2440         * source.c (print_source_lines_base): Advance "iter" when a
2441         control character is seen.
2442
2443 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2444
2445         * inferior.h (struct infcall_suspend_state_deleter):
2446         Catch exception in destructor to avoid crash.
2447
2448 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2449
2450         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2451         close to the add_com "shell".
2452
2453 2019-04-18  Tom Tromey  <tromey@adacore.com>
2454
2455         * process-stratum-target.h (class process_stratum_target)
2456         <stratum>: Add "final".
2457
2458 2019-04-17  Tom Tromey  <tromey@adacore.com>
2459
2460         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2461         against nullptr before use.
2462
2463 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2464
2465         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2466
2467 2019-04-17  Jim Wilson  <jimw@sifive.com>
2468             Andrew Burgess  <andrew.burgess@embecosm.com>
2469
2470         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2471         code read might fail, assume 4-byte breakpoint in that case.
2472
2473 2019-04-15  Leszek Swirski  <leszeks@google.com>
2474
2475         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2476         rather than a hand-rolled POD check when checking for forced MEMORY
2477         classification.
2478
2479 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2480
2481         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2482         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2483         function.
2484         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2485         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2486         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2487         declaration.
2488
2489 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2490
2491         * aarch64-linux-nat.c
2492         (aarch64_linux_nat_target::thread_architecture): Add override.
2493         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2494         each VQ.
2495
2496 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2497
2498         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2499
2500 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2501
2502         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2503         target types of size 96-bits, add some additional comments, and
2504         check that the builtin type we found was the correct size.
2505
2506 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2507
2508         * utils.c (prompt_for_continue): Don't restore the styling at the
2509         end, as applied_style has the wrong value.  This fixes styling in
2510         long lists of file names that are interrupted by the "Continue?"
2511         prompt.
2512
2513 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2514
2515         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2516         * c-lang.c (c_language_defn): Likewise.
2517         (cplus_language_defn): Likewise.
2518         (asm_language_defn): Likewise.
2519         (minimal_language_defn): Likewise.
2520         * d-lang.c (d_language_defn): Likewise.
2521         * f-lang.c (f_language_defn): Likewise.
2522         * go-lang.c (go_language_defn): Likewise.
2523         * language.c (unknown_language_defn): Likewise.
2524         (auto_language_defn): Likewise.
2525         * language.h (struct language_defn): Remove la_magic field.
2526         (LANG_MAGIC): Delete.
2527         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2528         * objc-lang.c (objc_language_defn): Likewise.
2529         * opencl-lang.c (opencl_language_defn): Likewise.
2530         * p-lang.c (pascal_language_defn): Likewise.
2531         * rust-lang.c (rust_language_defn): Likewise.
2532
2533 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2534
2535         * riscv-tdep.c (riscv_type_align): New function.
2536         (riscv_type_alignment): Delete.
2537         (riscv_arg_location): Use 'type_align'.
2538         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2539
2540 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2541
2542         * gdbtypes.c (type_align): A struct with no non-static fields also
2543         has alignment of 1.
2544
2545 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2546
2547         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2548         component to 0.
2549         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2550         member.
2551         (riscv_struct_info::analyse): New implementation using new
2552         analyse_inner member function.
2553         (riscv_struct_info::field_offset): New member function.
2554         (riscv_struct_info::m_offsets): New member variable.
2555         (riscv_struct_info::analyse_inner): New private member function,
2556         takes the old implementation of riscv_struct_info::analyse but
2557         extended to track field offsets.
2558         (riscv_call_arg_struct): Update the struct folding special cases
2559         to handle cases where empty C++ structs, which are non-zero
2560         length, are found.
2561         (riscv_arg_location): Initialise the length of each location, a
2562         non-zero length now indicates the location is in use.
2563         (riscv_push_dummy_call): Allow for the first location having a
2564         non-zero offset when setting up arguments.
2565         (riscv_return_value): Likewise, but for return values.
2566
2567 2019-04-11  Tom Tromey  <tromey@adacore.com>
2568
2569         * utils.c (internal_vproblem): Make "msg" const.
2570
2571 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2572
2573         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2574         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2575         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2576         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2577
2578 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2579
2580         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2581         function.
2582         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2583         of amd64_collect_native_gregset.
2584         (amd64_linux_nat_target::store_registers): Likewise.
2585
2586 2019-04-10  Tom Tromey  <tom@tromey.com>
2587
2588         * symtab.c (lookup_global_symbol_from_objfile)
2589         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2590         * objfiles.h (class separate_debug_iterator): New.
2591         (class separate_debug_range): New.
2592         (struct objfile) <separate_debug_objfiles>: New method.
2593         (objfile_separate_debug_iterate): Don't declare.
2594         * objfiles.c (separate_debug_iterator::operator++): Rename from
2595         objfile_separate_debug_iterate.
2596         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2597         iterator.
2598         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2599         iterator.
2600
2601 2019-04-10  Tom Tromey  <tom@tromey.com>
2602
2603         * symfile.c (reread_symbols): Remove old comment.
2604         * objfiles.c (free_all_objfiles): Fix a typo.
2605
2606 2019-04-10  Tom Tromey  <tom@tromey.com>
2607
2608         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2609         * minsyms.c (lookup_minimal_symbol): Use foreach.
2610         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2611         (lookup_minimal_symbol_solib_trampoline): Likewise.
2612         * symfile.c (reread_symbols): Use foreach.
2613
2614 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2615             Tom Tromey  <tromey@adacore.com>
2616
2617         PR rust/24414:
2618         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2619         (rust_lex_int_test): Change "value" to be LONGEST.
2620         (rust_lex_tests): Add test for long integer literal.
2621
2622 2019-04-09  Tom Tromey  <tromey@adacore.com>
2623
2624         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2625         to bool.
2626         (extended_remote_target::attach): Update.
2627         (remote_target::remote_notice_new_inferior): Update.
2628         (remote_target::add_current_inferior_and_thread): Update.
2629         * inferior.c (exit_inferior_1): Use "false".
2630         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2631
2632 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2633
2634         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2635         the "start" command.
2636
2637 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2638
2639         * python/py-inferior.c (infpy_thread_from_thread_handle):
2640         Adjust comments to reflect renaming of thread_from_thread_handle
2641         to thread_from_handle.  Adjust keywords.  Fix type error message.
2642         (inferior_object_methods): Add thread_from_handle.  Retain
2643         thread_from_thread_handle, but mark it as deprecated.
2644
2645 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2646
2647         * gdbthread.h (find_thread_by_handle): Revise declaration.
2648         * thread.c (find_thread_by_handle): Likewise.  Adjust
2649         implementation too.
2650         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2651         support for buffer objects as handles.
2652
2653 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2654
2655         * python/py-infthread.c (thpy_thread_handle): New function.
2656         (thread_object_methods): Register thpy_thread_handle.
2657
2658 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2659
2660         * gdbthread.h (thread_to_thread_handle): Declare.
2661         * thread.c (gdbtypes.h): Include.
2662         (thread_to_thread_handle): New function.
2663
2664         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2665         (target_thread_info_to_thread_handle): Declare.
2666         * target.c (target_thread_info_to_thread_handle): New function.
2667         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2668         * target-delegates.c: Regenerate.
2669
2670         * linux-thread-db.c (class thread_db_target): Add method
2671         thread_info_to_thread_handle.
2672         (thread_db_target::thread_info_to_thread_handle): Define.
2673         * remote.c (class remote_target): Add new method
2674         thread_info_to_thread_handle.
2675         (remote_target::thread_info_to_thread_handle): Define.
2676
2677 2019-04-08  Pedro Alves  <palves@redhat.com>
2678
2679         * common/common-exceptions.c (throw_exception): Don't create
2680         named object to throw; throw directly.
2681         (throw_it): Likewise.  Don't initialize gdb_exception::message
2682         here, with new; pass FMT and AP to the ctor instead.
2683         * common/common-exceptions.h: Include <string>.
2684         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2685         const char *, va_list)): New ctor.  Use std::make_shared.
2686         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2687         errors)): Delete.
2688         (gdb_exception_error::gdb_exception_error(enum errors, const char
2689         *, va_list)): New.
2690         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2691         Add assertion.
2692         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2693         errors)): Delete.
2694         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2695         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2696         Add assertion.
2697
2698 2019-04-08  Tom Tromey  <tom@tromey.com>
2699
2700         * valops.c (value_rtti_indirect_type): Replace throw_exception
2701         with throw.
2702         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2703         with throw.
2704         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2705         throw.
2706         * target.c (target_translate_tls_address): Replace throw_exception
2707         with throw.
2708         * stack.c (frame_apply_command_count): Replace throw_exception
2709         with throw.
2710         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2711         throw.
2712         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2713         with throw.
2714         * rs6000-tdep.c (rs6000_frame_cache)
2715         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2716         * remote.c: Replace throw_exception with throw.
2717         * record-full.c (record_full_message, record_full_wait_1)
2718         (record_full_restore): Replace throw_exception with throw.
2719         * record-btrace.c:
2720         (get_thread_current_frame_id, record_btrace_start_replaying)
2721         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2722         (cmd_record_btrace_start): Replace throw_exception with throw.
2723         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2724         throw.
2725         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2726         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2727         * linespec.c:
2728         (find_linespec_symbols): Replace throw_exception with throw.
2729         * infrun.c (displaced_step_prepare, resume): Replace
2730         throw_exception with throw.
2731         * infcmd.c (post_create_inferior): Replace throw_exception with
2732         throw.
2733         * inf-loop.c (inferior_event_handler): Replace throw_exception
2734         with throw.
2735         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2736         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2737         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2738         (get_prev_frame_always, get_frame_pc_if_available)
2739         (get_frame_address_in_block_if_available, get_frame_language):
2740         Replace throw_exception with throw.
2741         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2742         throw_exception with throw.
2743         * eval.c (fetch_subexp_value, evaluate_var_value)
2744         (evaluate_funcall, evaluate_subexp_standard): Replace
2745         throw_exception with throw.
2746         * dwarf2loc.c (call_site_find_chain)
2747         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2748         Replace throw_exception with throw.
2749         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2750         with throw.
2751         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2752         throw.
2753         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2754         * completer.c (complete_line_internal): Replace throw_exception
2755         with throw.
2756         * compile/compile-object-run.c (compile_object_run): Replace
2757         throw_exception with throw.
2758         * cli/cli-script.c (process_next_line): Replace throw_exception
2759         with throw.
2760         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2761         (btrace_enable, btrace_maint_update_pt_packets): Replace
2762         throw_exception with throw.
2763         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2764         throw_exception with throw.
2765         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2766         throw_exception with throw.
2767         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2768         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2769         * aarch64-tdep.c (aarch64_make_prologue_cache)
2770         (aarch64_make_stub_cache): Replace throw_exception with throw.
2771
2772 2019-04-08  Tom Tromey  <tom@tromey.com>
2773
2774         * common/common-exceptions.c (throw_exception): Rename from
2775         throw_exception_cxx.  Remove old copy.  Make argument const.
2776         (throw_it): Create and throw exception objects directly.
2777         * common/common-exceptions.h (throw_exception): Make argument
2778         const.
2779         (struct gdb_exception_error): Add constructor.
2780         (struct gdb_exception_quit): Add constructor.
2781
2782 2019-04-08  Tom Tromey  <tom@tromey.com>
2783
2784         * common/common-exceptions.h (exception_rethrow): Don't declare.
2785         (TRY_SJLJ): Update comment.
2786         (TRY, CATCH, END_CATCH): Remove.
2787         * common/common-exceptions.c (exception_rethrow): Remove.
2788
2789 2019-04-08  Tom Tromey  <tom@tromey.com>
2790
2791         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2792         Remove.
2793         (gdb_exception_error): Rename from
2794         gdb_exception_RETURN_MASK_ERROR.
2795         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2796         (gdb_quit_bad_alloc): Update.
2797         * aarch64-tdep.c: Update.
2798         * ada-lang.c: Update.
2799         * ada-typeprint.c: Update.
2800         * ada-valprint.c: Update.
2801         * amd64-tdep.c: Update.
2802         * arch-utils.c: Update.
2803         * break-catch-throw.c: Update.
2804         * breakpoint.c: Update.
2805         * btrace.c: Update.
2806         * c-varobj.c: Update.
2807         * cli/cli-cmds.c: Update.
2808         * cli/cli-interp.c: Update.
2809         * cli/cli-script.c: Update.
2810         * common/common-exceptions.c: Update.
2811         * common/new-op.c: Update.
2812         * common/selftest.c: Update.
2813         * compile/compile-c-symbols.c: Update.
2814         * compile/compile-cplus-symbols.c: Update.
2815         * compile/compile-object-load.c: Update.
2816         * compile/compile-object-run.c: Update.
2817         * completer.c: Update.
2818         * corelow.c: Update.
2819         * cp-abi.c: Update.
2820         * cp-support.c: Update.
2821         * cp-valprint.c: Update.
2822         * darwin-nat.c: Update.
2823         * disasm-selftests.c: Update.
2824         * dtrace-probe.c: Update.
2825         * dwarf-index-cache.c: Update.
2826         * dwarf-index-write.c: Update.
2827         * dwarf2-frame-tailcall.c: Update.
2828         * dwarf2-frame.c: Update.
2829         * dwarf2loc.c: Update.
2830         * dwarf2read.c: Update.
2831         * eval.c: Update.
2832         * event-loop.c: Update.
2833         * event-top.c: Update.
2834         * exec.c: Update.
2835         * f-valprint.c: Update.
2836         * fbsd-tdep.c: Update.
2837         * frame-unwind.c: Update.
2838         * frame.c: Update.
2839         * gdbtypes.c: Update.
2840         * gnu-v3-abi.c: Update.
2841         * guile/guile-internal.h: Update.
2842         * guile/scm-block.c: Update.
2843         * guile/scm-breakpoint.c: Update.
2844         * guile/scm-cmd.c: Update.
2845         * guile/scm-disasm.c: Update.
2846         * guile/scm-frame.c: Update.
2847         * guile/scm-lazy-string.c: Update.
2848         * guile/scm-math.c: Update.
2849         * guile/scm-param.c: Update.
2850         * guile/scm-ports.c: Update.
2851         * guile/scm-pretty-print.c: Update.
2852         * guile/scm-symbol.c: Update.
2853         * guile/scm-symtab.c: Update.
2854         * guile/scm-type.c: Update.
2855         * guile/scm-value.c: Update.
2856         * i386-linux-tdep.c: Update.
2857         * i386-tdep.c: Update.
2858         * inf-loop.c: Update.
2859         * infcall.c: Update.
2860         * infcmd.c: Update.
2861         * infrun.c: Update.
2862         * jit.c: Update.
2863         * language.c: Update.
2864         * linespec.c: Update.
2865         * linux-fork.c: Update.
2866         * linux-nat.c: Update.
2867         * linux-tdep.c: Update.
2868         * linux-thread-db.c: Update.
2869         * main.c: Update.
2870         * mi/mi-cmd-break.c: Update.
2871         * mi/mi-cmd-stack.c: Update.
2872         * mi/mi-interp.c: Update.
2873         * mi/mi-main.c: Update.
2874         * objc-lang.c: Update.
2875         * p-valprint.c: Update.
2876         * parse.c: Update.
2877         * ppc-linux-tdep.c: Update.
2878         * printcmd.c: Update.
2879         * python/py-arch.c: Update.
2880         * python/py-breakpoint.c: Update.
2881         * python/py-cmd.c: Update.
2882         * python/py-finishbreakpoint.c: Update.
2883         * python/py-frame.c: Update.
2884         * python/py-framefilter.c: Update.
2885         * python/py-gdb-readline.c: Update.
2886         * python/py-inferior.c: Update.
2887         * python/py-infthread.c: Update.
2888         * python/py-lazy-string.c: Update.
2889         * python/py-linetable.c: Update.
2890         * python/py-objfile.c: Update.
2891         * python/py-param.c: Update.
2892         * python/py-prettyprint.c: Update.
2893         * python/py-progspace.c: Update.
2894         * python/py-record-btrace.c: Update.
2895         * python/py-record.c: Update.
2896         * python/py-symbol.c: Update.
2897         * python/py-type.c: Update.
2898         * python/py-unwind.c: Update.
2899         * python/py-utils.c: Update.
2900         * python/py-value.c: Update.
2901         * python/python.c: Update.
2902         * record-btrace.c: Update.
2903         * record-full.c: Update.
2904         * remote-fileio.c: Update.
2905         * remote.c: Update.
2906         * riscv-tdep.c: Update.
2907         * rs6000-aix-tdep.c: Update.
2908         * rs6000-tdep.c: Update.
2909         * rust-exp.y: Update.
2910         * rust-lang.c: Update.
2911         * s390-tdep.c: Update.
2912         * selftest-arch.c: Update.
2913         * solib-dsbt.c: Update.
2914         * solib-frv.c: Update.
2915         * solib-spu.c: Update.
2916         * solib-svr4.c: Update.
2917         * solib.c: Update.
2918         * sparc64-linux-tdep.c: Update.
2919         * stack.c: Update.
2920         * symfile-mem.c: Update.
2921         * symmisc.c: Update.
2922         * target.c: Update.
2923         * thread.c: Update.
2924         * top.c: Update.
2925         * tracefile-tfile.c: Update.
2926         * tui/tui.c: Update.
2927         * typeprint.c: Update.
2928         * unittests/cli-utils-selftests.c: Update.
2929         * unittests/parse-connection-spec-selftests.c: Update.
2930         * valops.c: Update.
2931         * valprint.c: Update.
2932         * value.c: Update.
2933         * varobj.c: Update.
2934         * windows-nat.c: Update.
2935         * x86-linux-nat.c: Update.
2936         * xml-support.c: Update.
2937
2938 2019-04-08  Tom Tromey  <tom@tromey.com>
2939
2940         * xml-support.c: Use C++ exception handling.
2941         * x86-linux-nat.c: Use C++ exception handling.
2942         * windows-nat.c: Use C++ exception handling.
2943         * varobj.c: Use C++ exception handling.
2944         * value.c: Use C++ exception handling.
2945         * valprint.c: Use C++ exception handling.
2946         * valops.c: Use C++ exception handling.
2947         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2948         handling.
2949         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2950         * typeprint.c: Use C++ exception handling.
2951         * tui/tui.c: Use C++ exception handling.
2952         * tracefile-tfile.c: Use C++ exception handling.
2953         * top.c: Use C++ exception handling.
2954         * thread.c: Use C++ exception handling.
2955         * target.c: Use C++ exception handling.
2956         * symmisc.c: Use C++ exception handling.
2957         * symfile-mem.c: Use C++ exception handling.
2958         * stack.c: Use C++ exception handling.
2959         * sparc64-linux-tdep.c: Use C++ exception handling.
2960         * solib.c: Use C++ exception handling.
2961         * solib-svr4.c: Use C++ exception handling.
2962         * solib-spu.c: Use C++ exception handling.
2963         * solib-frv.c: Use C++ exception handling.
2964         * solib-dsbt.c: Use C++ exception handling.
2965         * selftest-arch.c: Use C++ exception handling.
2966         * s390-tdep.c: Use C++ exception handling.
2967         * rust-lang.c: Use C++ exception handling.
2968         * rust-exp.y: Use C++ exception handling.
2969         * rs6000-tdep.c: Use C++ exception handling.
2970         * rs6000-aix-tdep.c: Use C++ exception handling.
2971         * riscv-tdep.c: Use C++ exception handling.
2972         * remote.c: Use C++ exception handling.
2973         * remote-fileio.c: Use C++ exception handling.
2974         * record-full.c: Use C++ exception handling.
2975         * record-btrace.c: Use C++ exception handling.
2976         * python/python.c: Use C++ exception handling.
2977         * python/py-value.c: Use C++ exception handling.
2978         * python/py-utils.c: Use C++ exception handling.
2979         * python/py-unwind.c: Use C++ exception handling.
2980         * python/py-type.c: Use C++ exception handling.
2981         * python/py-symbol.c: Use C++ exception handling.
2982         * python/py-record.c: Use C++ exception handling.
2983         * python/py-record-btrace.c: Use C++ exception handling.
2984         * python/py-progspace.c: Use C++ exception handling.
2985         * python/py-prettyprint.c: Use C++ exception handling.
2986         * python/py-param.c: Use C++ exception handling.
2987         * python/py-objfile.c: Use C++ exception handling.
2988         * python/py-linetable.c: Use C++ exception handling.
2989         * python/py-lazy-string.c: Use C++ exception handling.
2990         * python/py-infthread.c: Use C++ exception handling.
2991         * python/py-inferior.c: Use C++ exception handling.
2992         * python/py-gdb-readline.c: Use C++ exception handling.
2993         * python/py-framefilter.c: Use C++ exception handling.
2994         * python/py-frame.c: Use C++ exception handling.
2995         * python/py-finishbreakpoint.c: Use C++ exception handling.
2996         * python/py-cmd.c: Use C++ exception handling.
2997         * python/py-breakpoint.c: Use C++ exception handling.
2998         * python/py-arch.c: Use C++ exception handling.
2999         * printcmd.c: Use C++ exception handling.
3000         * ppc-linux-tdep.c: Use C++ exception handling.
3001         * parse.c: Use C++ exception handling.
3002         * p-valprint.c: Use C++ exception handling.
3003         * objc-lang.c: Use C++ exception handling.
3004         * mi/mi-main.c: Use C++ exception handling.
3005         * mi/mi-interp.c: Use C++ exception handling.
3006         * mi/mi-cmd-stack.c: Use C++ exception handling.
3007         * mi/mi-cmd-break.c: Use C++ exception handling.
3008         * main.c: Use C++ exception handling.
3009         * linux-thread-db.c: Use C++ exception handling.
3010         * linux-tdep.c: Use C++ exception handling.
3011         * linux-nat.c: Use C++ exception handling.
3012         * linux-fork.c: Use C++ exception handling.
3013         * linespec.c: Use C++ exception handling.
3014         * language.c: Use C++ exception handling.
3015         * jit.c: Use C++ exception handling.
3016         * infrun.c: Use C++ exception handling.
3017         * infcmd.c: Use C++ exception handling.
3018         * infcall.c: Use C++ exception handling.
3019         * inf-loop.c: Use C++ exception handling.
3020         * i386-tdep.c: Use C++ exception handling.
3021         * i386-linux-tdep.c: Use C++ exception handling.
3022         * guile/scm-value.c: Use C++ exception handling.
3023         * guile/scm-type.c: Use C++ exception handling.
3024         * guile/scm-symtab.c: Use C++ exception handling.
3025         * guile/scm-symbol.c: Use C++ exception handling.
3026         * guile/scm-pretty-print.c: Use C++ exception handling.
3027         * guile/scm-ports.c: Use C++ exception handling.
3028         * guile/scm-param.c: Use C++ exception handling.
3029         * guile/scm-math.c: Use C++ exception handling.
3030         * guile/scm-lazy-string.c: Use C++ exception handling.
3031         * guile/scm-frame.c: Use C++ exception handling.
3032         * guile/scm-disasm.c: Use C++ exception handling.
3033         * guile/scm-cmd.c: Use C++ exception handling.
3034         * guile/scm-breakpoint.c: Use C++ exception handling.
3035         * guile/scm-block.c: Use C++ exception handling.
3036         * guile/guile-internal.h: Use C++ exception handling.
3037         * gnu-v3-abi.c: Use C++ exception handling.
3038         * gdbtypes.c: Use C++ exception handling.
3039         * frame.c: Use C++ exception handling.
3040         * frame-unwind.c: Use C++ exception handling.
3041         * fbsd-tdep.c: Use C++ exception handling.
3042         * f-valprint.c: Use C++ exception handling.
3043         * exec.c: Use C++ exception handling.
3044         * event-top.c: Use C++ exception handling.
3045         * event-loop.c: Use C++ exception handling.
3046         * eval.c: Use C++ exception handling.
3047         * dwarf2read.c: Use C++ exception handling.
3048         * dwarf2loc.c: Use C++ exception handling.
3049         * dwarf2-frame.c: Use C++ exception handling.
3050         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3051         * dwarf-index-write.c: Use C++ exception handling.
3052         * dwarf-index-cache.c: Use C++ exception handling.
3053         * dtrace-probe.c: Use C++ exception handling.
3054         * disasm-selftests.c: Use C++ exception handling.
3055         * darwin-nat.c: Use C++ exception handling.
3056         * cp-valprint.c: Use C++ exception handling.
3057         * cp-support.c: Use C++ exception handling.
3058         * cp-abi.c: Use C++ exception handling.
3059         * corelow.c: Use C++ exception handling.
3060         * completer.c: Use C++ exception handling.
3061         * compile/compile-object-run.c: Use C++ exception handling.
3062         * compile/compile-object-load.c: Use C++ exception handling.
3063         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3064         * compile/compile-c-symbols.c: Use C++ exception handling.
3065         * common/selftest.c: Use C++ exception handling.
3066         * common/new-op.c: Use C++ exception handling.
3067         * cli/cli-script.c: Use C++ exception handling.
3068         * cli/cli-interp.c: Use C++ exception handling.
3069         * cli/cli-cmds.c: Use C++ exception handling.
3070         * c-varobj.c: Use C++ exception handling.
3071         * btrace.c: Use C++ exception handling.
3072         * breakpoint.c: Use C++ exception handling.
3073         * break-catch-throw.c: Use C++ exception handling.
3074         * arch-utils.c: Use C++ exception handling.
3075         * amd64-tdep.c: Use C++ exception handling.
3076         * ada-valprint.c: Use C++ exception handling.
3077         * ada-typeprint.c: Use C++ exception handling.
3078         * ada-lang.c: Use C++ exception handling.
3079         * aarch64-tdep.c: Use C++ exception handling.
3080
3081 2019-04-08  Tom Tromey  <tom@tromey.com>
3082
3083         * xml-support.c (gdb_xml_parser::parse): Update.
3084         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3085         * value.c (show_convenience): Update.
3086         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3087         (test_parse_flags_qcs): Update.
3088         * thread.c (thr_try_catch_cmd): Update.
3089         * target.c (target_translate_tls_address): Update.
3090         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3091         (info_frame_command_core, frame_apply_command_count): Update.
3092         * rust-exp.y (rust_lex_exception_test): Update.
3093         * riscv-tdep.c (riscv_print_one_register_info): Update.
3094         * remote.c (remote_target::enable_btrace): Update.
3095         * record-btrace.c (record_btrace_enable_warn): Update.
3096         * python/py-utils.c (gdbpy_convert_exception): Update.
3097         * printcmd.c (do_one_display, print_variable_and_value): Update.
3098         * mi/mi-main.c (mi_print_exception): Update.
3099         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3100         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3101         * linux-nat.c (linux_nat_target::attach): Update.
3102         * linux-fork.c (class scoped_switch_fork_info): Update.
3103         * infrun.c (displaced_step_prepare): Update.
3104         * infcall.c (call_function_by_hand_dummy): Update.
3105         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3106         * gnu-v3-abi.c (print_one_vtable): Update.
3107         * frame.c (get_prev_frame_always): Update.
3108         * f-valprint.c (info_common_command_for_block): Update.
3109         * exec.c (try_open_exec_file): Update.
3110         * exceptions.c (print_exception, exception_print)
3111         (exception_fprintf, exception_print_same): Update.
3112         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3113         * dwarf-index-cache.c (index_cache::store)
3114         (index_cache::lookup_gdb_index): Update.
3115         * darwin-nat.c (maybe_cache_shell): Update.
3116         * cp-valprint.c (cp_print_value_fields): Update.
3117         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3118         (gcc_cplus_symbol_address): Update.
3119         * compile/compile-c-symbols.c (gcc_convert_symbol)
3120         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3121         * common/selftest.c: Update.
3122         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3123         a std::string.
3124         (exception_try_scope_entry, exception_try_scope_exit): Don't
3125         declare.
3126         (struct exception_try_scope): Remove.
3127         (TRY): Don't use exception_try_scope.
3128         (struct gdb_exception): Add constructor, operator=.
3129         <what>: New method.
3130         (struct gdb_exception_RETURN_MASK_ALL)
3131         (struct gdb_exception_RETURN_MASK_ERROR)
3132         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3133         (struct gdb_quit_bad_alloc): Update.
3134         * common/common-exceptions.c (exception_none): Change
3135         initializer.
3136         (struct catcher) <state, exception>: Initialize inline.
3137         <prev>: Remove member.
3138         (current_catcher): Remove.
3139         (catchers): New global.
3140         (exceptions_state_mc_init): Simplify.
3141         (catcher_pop): Remove.
3142         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3143         (try_scope_depth, exception_try_scope_entry)
3144         (exception_try_scope_exit): Remove.
3145         (throw_exception_sjlj): Update.
3146         (exception_messages, exception_messages_size): Remove.
3147         (throw_it): Simplify.
3148         (gdb_exception_sliced_copy): Remove.
3149         (throw_exception_cxx): Update.
3150         * cli/cli-script.c (script_from_file): Update.
3151         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3152         Update.
3153         * ada-valprint.c (ada_val_print): Update.
3154         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3155         (create_excep_cond_exprs): Update.
3156
3157 2019-04-08  Tom Tromey  <tom@tromey.com>
3158
3159         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3160         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3161         (TRY, CATCH, END_CATCH): Remove some definitions.
3162         * common/common-exceptions.c: Don't use GDB_XCPT.
3163         (catcher_list_size): Remove.
3164         (throw_exception, throw_it): Simplify.
3165
3166 2019-04-05  Tom Tromey  <tom@tromey.com>
3167
3168         Revert the header-sorting patch.
3169         * ft32-tdep.c: Revert.
3170         * frv-tdep.c: Revert.
3171         * frv-linux-tdep.c: Revert.
3172         * frame.c: Revert.
3173         * frame-unwind.c: Revert.
3174         * frame-base.c: Revert.
3175         * fork-child.c: Revert.
3176         * findvar.c: Revert.
3177         * findcmd.c: Revert.
3178         * filesystem.c: Revert.
3179         * filename-seen-cache.h: Revert.
3180         * filename-seen-cache.c: Revert.
3181         * fbsd-tdep.c: Revert.
3182         * fbsd-nat.h: Revert.
3183         * fbsd-nat.c: Revert.
3184         * f-valprint.c: Revert.
3185         * f-typeprint.c: Revert.
3186         * f-lang.c: Revert.
3187         * extension.h: Revert.
3188         * extension.c: Revert.
3189         * extension-priv.h: Revert.
3190         * expprint.c: Revert.
3191         * exec.h: Revert.
3192         * exec.c: Revert.
3193         * exceptions.c: Revert.
3194         * event-top.c: Revert.
3195         * event-loop.c: Revert.
3196         * eval.c: Revert.
3197         * elfread.c: Revert.
3198         * dwarf2read.h: Revert.
3199         * dwarf2read.c: Revert.
3200         * dwarf2loc.c: Revert.
3201         * dwarf2expr.h: Revert.
3202         * dwarf2expr.c: Revert.
3203         * dwarf2-frame.c: Revert.
3204         * dwarf2-frame-tailcall.c: Revert.
3205         * dwarf-index-write.h: Revert.
3206         * dwarf-index-write.c: Revert.
3207         * dwarf-index-common.c: Revert.
3208         * dwarf-index-cache.h: Revert.
3209         * dwarf-index-cache.c: Revert.
3210         * dummy-frame.c: Revert.
3211         * dtrace-probe.c: Revert.
3212         * disasm.h: Revert.
3213         * disasm.c: Revert.
3214         * disasm-selftests.c: Revert.
3215         * dictionary.c: Revert.
3216         * dicos-tdep.c: Revert.
3217         * demangle.c: Revert.
3218         * dcache.h: Revert.
3219         * dcache.c: Revert.
3220         * darwin-nat.h: Revert.
3221         * darwin-nat.c: Revert.
3222         * darwin-nat-info.c: Revert.
3223         * d-valprint.c: Revert.
3224         * d-namespace.c: Revert.
3225         * d-lang.c: Revert.
3226         * ctf.c: Revert.
3227         * csky-tdep.c: Revert.
3228         * csky-linux-tdep.c: Revert.
3229         * cris-tdep.c: Revert.
3230         * cris-linux-tdep.c: Revert.
3231         * cp-valprint.c: Revert.
3232         * cp-support.c: Revert.
3233         * cp-namespace.c: Revert.
3234         * cp-abi.c: Revert.
3235         * corelow.c: Revert.
3236         * corefile.c: Revert.
3237         * continuations.c: Revert.
3238         * completer.h: Revert.
3239         * completer.c: Revert.
3240         * complaints.c: Revert.
3241         * coffread.c: Revert.
3242         * coff-pe-read.c: Revert.
3243         * cli-out.h: Revert.
3244         * cli-out.c: Revert.
3245         * charset.c: Revert.
3246         * c-varobj.c: Revert.
3247         * c-valprint.c: Revert.
3248         * c-typeprint.c: Revert.
3249         * c-lang.c: Revert.
3250         * buildsym.c: Revert.
3251         * buildsym-legacy.c: Revert.
3252         * build-id.h: Revert.
3253         * build-id.c: Revert.
3254         * btrace.c: Revert.
3255         * bsd-uthread.c: Revert.
3256         * breakpoint.h: Revert.
3257         * breakpoint.c: Revert.
3258         * break-catch-throw.c: Revert.
3259         * break-catch-syscall.c: Revert.
3260         * break-catch-sig.c: Revert.
3261         * blockframe.c: Revert.
3262         * block.c: Revert.
3263         * bfin-tdep.c: Revert.
3264         * bfin-linux-tdep.c: Revert.
3265         * bfd-target.c: Revert.
3266         * bcache.c: Revert.
3267         * ax-general.c: Revert.
3268         * ax-gdb.h: Revert.
3269         * ax-gdb.c: Revert.
3270         * avr-tdep.c: Revert.
3271         * auxv.c: Revert.
3272         * auto-load.c: Revert.
3273         * arm-wince-tdep.c: Revert.
3274         * arm-tdep.c: Revert.
3275         * arm-symbian-tdep.c: Revert.
3276         * arm-pikeos-tdep.c: Revert.
3277         * arm-obsd-tdep.c: Revert.
3278         * arm-nbsd-tdep.c: Revert.
3279         * arm-nbsd-nat.c: Revert.
3280         * arm-linux-tdep.c: Revert.
3281         * arm-linux-nat.c: Revert.
3282         * arm-fbsd-tdep.c: Revert.
3283         * arm-fbsd-nat.c: Revert.
3284         * arm-bsd-tdep.c: Revert.
3285         * arch-utils.c: Revert.
3286         * arc-tdep.c: Revert.
3287         * arc-newlib-tdep.c: Revert.
3288         * annotate.h: Revert.
3289         * annotate.c: Revert.
3290         * amd64-windows-tdep.c: Revert.
3291         * amd64-windows-nat.c: Revert.
3292         * amd64-tdep.c: Revert.
3293         * amd64-sol2-tdep.c: Revert.
3294         * amd64-obsd-tdep.c: Revert.
3295         * amd64-obsd-nat.c: Revert.
3296         * amd64-nbsd-tdep.c: Revert.
3297         * amd64-nbsd-nat.c: Revert.
3298         * amd64-nat.c: Revert.
3299         * amd64-linux-tdep.c: Revert.
3300         * amd64-linux-nat.c: Revert.
3301         * amd64-fbsd-tdep.c: Revert.
3302         * amd64-fbsd-nat.c: Revert.
3303         * amd64-dicos-tdep.c: Revert.
3304         * amd64-darwin-tdep.c: Revert.
3305         * amd64-bsd-nat.c: Revert.
3306         * alpha-tdep.c: Revert.
3307         * alpha-obsd-tdep.c: Revert.
3308         * alpha-nbsd-tdep.c: Revert.
3309         * alpha-mdebug-tdep.c: Revert.
3310         * alpha-linux-tdep.c: Revert.
3311         * alpha-linux-nat.c: Revert.
3312         * alpha-bsd-tdep.c: Revert.
3313         * alpha-bsd-nat.c: Revert.
3314         * aix-thread.c: Revert.
3315         * agent.c: Revert.
3316         * addrmap.c: Revert.
3317         * ada-varobj.c: Revert.
3318         * ada-valprint.c: Revert.
3319         * ada-typeprint.c: Revert.
3320         * ada-tasks.c: Revert.
3321         * ada-lang.c: Revert.
3322         * aarch64-tdep.c: Revert.
3323         * aarch64-ravenscar-thread.c: Revert.
3324         * aarch64-newlib-tdep.c: Revert.
3325         * aarch64-linux-tdep.c: Revert.
3326         * aarch64-linux-nat.c: Revert.
3327         * aarch64-fbsd-tdep.c: Revert.
3328         * aarch64-fbsd-nat.c: Revert.
3329         * aarch32-linux-nat.c: Revert.
3330
3331 2019-04-05  Tom Tromey  <tom@tromey.com>
3332
3333         * ft32-tdep.c: Sort headers.
3334         * frv-tdep.c: Sort headers.
3335         * frv-linux-tdep.c: Sort headers.
3336         * frame.c: Sort headers.
3337         * frame-unwind.c: Sort headers.
3338         * frame-base.c: Sort headers.
3339         * fork-child.c: Sort headers.
3340         * findvar.c: Sort headers.
3341         * findcmd.c: Sort headers.
3342         * filesystem.c: Sort headers.
3343         * filename-seen-cache.h: Sort headers.
3344         * filename-seen-cache.c: Sort headers.
3345         * fbsd-tdep.c: Sort headers.
3346         * fbsd-nat.h: Sort headers.
3347         * fbsd-nat.c: Sort headers.
3348         * f-valprint.c: Sort headers.
3349         * f-typeprint.c: Sort headers.
3350         * f-lang.c: Sort headers.
3351         * extension.h: Sort headers.
3352         * extension.c: Sort headers.
3353         * extension-priv.h: Sort headers.
3354         * expprint.c: Sort headers.
3355         * exec.h: Sort headers.
3356         * exec.c: Sort headers.
3357         * exceptions.c: Sort headers.
3358         * event-top.c: Sort headers.
3359         * event-loop.c: Sort headers.
3360         * eval.c: Sort headers.
3361         * elfread.c: Sort headers.
3362         * dwarf2read.h: Sort headers.
3363         * dwarf2read.c: Sort headers.
3364         * dwarf2loc.c: Sort headers.
3365         * dwarf2expr.h: Sort headers.
3366         * dwarf2expr.c: Sort headers.
3367         * dwarf2-frame.c: Sort headers.
3368         * dwarf2-frame-tailcall.c: Sort headers.
3369         * dwarf-index-write.h: Sort headers.
3370         * dwarf-index-write.c: Sort headers.
3371         * dwarf-index-common.c: Sort headers.
3372         * dwarf-index-cache.h: Sort headers.
3373         * dwarf-index-cache.c: Sort headers.
3374         * dummy-frame.c: Sort headers.
3375         * dtrace-probe.c: Sort headers.
3376         * disasm.h: Sort headers.
3377         * disasm.c: Sort headers.
3378         * disasm-selftests.c: Sort headers.
3379         * dictionary.c: Sort headers.
3380         * dicos-tdep.c: Sort headers.
3381         * demangle.c: Sort headers.
3382         * dcache.h: Sort headers.
3383         * dcache.c: Sort headers.
3384         * darwin-nat.h: Sort headers.
3385         * darwin-nat.c: Sort headers.
3386         * darwin-nat-info.c: Sort headers.
3387         * d-valprint.c: Sort headers.
3388         * d-namespace.c: Sort headers.
3389         * d-lang.c: Sort headers.
3390         * ctf.c: Sort headers.
3391         * csky-tdep.c: Sort headers.
3392         * csky-linux-tdep.c: Sort headers.
3393         * cris-tdep.c: Sort headers.
3394         * cris-linux-tdep.c: Sort headers.
3395         * cp-valprint.c: Sort headers.
3396         * cp-support.c: Sort headers.
3397         * cp-namespace.c: Sort headers.
3398         * cp-abi.c: Sort headers.
3399         * corelow.c: Sort headers.
3400         * corefile.c: Sort headers.
3401         * continuations.c: Sort headers.
3402         * completer.h: Sort headers.
3403         * completer.c: Sort headers.
3404         * complaints.c: Sort headers.
3405         * coffread.c: Sort headers.
3406         * coff-pe-read.c: Sort headers.
3407         * cli-out.h: Sort headers.
3408         * cli-out.c: Sort headers.
3409         * charset.c: Sort headers.
3410         * c-varobj.c: Sort headers.
3411         * c-valprint.c: Sort headers.
3412         * c-typeprint.c: Sort headers.
3413         * c-lang.c: Sort headers.
3414         * buildsym.c: Sort headers.
3415         * buildsym-legacy.c: Sort headers.
3416         * build-id.h: Sort headers.
3417         * build-id.c: Sort headers.
3418         * btrace.c: Sort headers.
3419         * bsd-uthread.c: Sort headers.
3420         * breakpoint.h: Sort headers.
3421         * breakpoint.c: Sort headers.
3422         * break-catch-throw.c: Sort headers.
3423         * break-catch-syscall.c: Sort headers.
3424         * break-catch-sig.c: Sort headers.
3425         * blockframe.c: Sort headers.
3426         * block.c: Sort headers.
3427         * bfin-tdep.c: Sort headers.
3428         * bfin-linux-tdep.c: Sort headers.
3429         * bfd-target.c: Sort headers.
3430         * bcache.c: Sort headers.
3431         * ax-general.c: Sort headers.
3432         * ax-gdb.h: Sort headers.
3433         * ax-gdb.c: Sort headers.
3434         * avr-tdep.c: Sort headers.
3435         * auxv.c: Sort headers.
3436         * auto-load.c: Sort headers.
3437         * arm-wince-tdep.c: Sort headers.
3438         * arm-tdep.c: Sort headers.
3439         * arm-symbian-tdep.c: Sort headers.
3440         * arm-pikeos-tdep.c: Sort headers.
3441         * arm-obsd-tdep.c: Sort headers.
3442         * arm-nbsd-tdep.c: Sort headers.
3443         * arm-nbsd-nat.c: Sort headers.
3444         * arm-linux-tdep.c: Sort headers.
3445         * arm-linux-nat.c: Sort headers.
3446         * arm-fbsd-tdep.c: Sort headers.
3447         * arm-fbsd-nat.c: Sort headers.
3448         * arm-bsd-tdep.c: Sort headers.
3449         * arch-utils.c: Sort headers.
3450         * arc-tdep.c: Sort headers.
3451         * arc-newlib-tdep.c: Sort headers.
3452         * annotate.h: Sort headers.
3453         * annotate.c: Sort headers.
3454         * amd64-windows-tdep.c: Sort headers.
3455         * amd64-windows-nat.c: Sort headers.
3456         * amd64-tdep.c: Sort headers.
3457         * amd64-sol2-tdep.c: Sort headers.
3458         * amd64-obsd-tdep.c: Sort headers.
3459         * amd64-obsd-nat.c: Sort headers.
3460         * amd64-nbsd-tdep.c: Sort headers.
3461         * amd64-nbsd-nat.c: Sort headers.
3462         * amd64-nat.c: Sort headers.
3463         * amd64-linux-tdep.c: Sort headers.
3464         * amd64-linux-nat.c: Sort headers.
3465         * amd64-fbsd-tdep.c: Sort headers.
3466         * amd64-fbsd-nat.c: Sort headers.
3467         * amd64-dicos-tdep.c: Sort headers.
3468         * amd64-darwin-tdep.c: Sort headers.
3469         * amd64-bsd-nat.c: Sort headers.
3470         * alpha-tdep.c: Sort headers.
3471         * alpha-obsd-tdep.c: Sort headers.
3472         * alpha-nbsd-tdep.c: Sort headers.
3473         * alpha-mdebug-tdep.c: Sort headers.
3474         * alpha-linux-tdep.c: Sort headers.
3475         * alpha-linux-nat.c: Sort headers.
3476         * alpha-bsd-tdep.c: Sort headers.
3477         * alpha-bsd-nat.c: Sort headers.
3478         * aix-thread.c: Sort headers.
3479         * agent.c: Sort headers.
3480         * addrmap.c: Sort headers.
3481         * ada-varobj.c: Sort headers.
3482         * ada-valprint.c: Sort headers.
3483         * ada-typeprint.c: Sort headers.
3484         * ada-tasks.c: Sort headers.
3485         * ada-lang.c: Sort headers.
3486         * aarch64-tdep.c: Sort headers.
3487         * aarch64-ravenscar-thread.c: Sort headers.
3488         * aarch64-newlib-tdep.c: Sort headers.
3489         * aarch64-linux-tdep.c: Sort headers.
3490         * aarch64-linux-nat.c: Sort headers.
3491         * aarch64-fbsd-tdep.c: Sort headers.
3492         * aarch64-fbsd-nat.c: Sort headers.
3493         * aarch32-linux-nat.c: Sort headers.
3494
3495 2019-04-04  Tom Tromey  <tom@tromey.com>
3496
3497         * varobj.c (varobj_create): Update.
3498         * rust-exp.y (struct rust_parser) <update_innermost_block,
3499         lookup_symbol>: New methods.
3500         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3501         Rename.
3502         (rust_parser::rust_lookup_type)
3503         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3504         * printcmd.c (display_command, do_one_display): Update.
3505         * parser-defs.h (struct parser_state) <parser_state>: Add
3506         "tracker" parameter.
3507         (block_tracker): New member.
3508         (class innermost_block_tracker) <innermost_block_tracker>: Add
3509         "types" parameter.
3510         <reset>: Remove method.
3511         (innermost_block): Don't declare.
3512         (null_post_parser): Update.
3513         * parse.c (innermost_block): Remove global.
3514         (write_dollar_variable): Update.
3515         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3516         Remove "tracker_types" parameter.
3517         (parse_expression): Add "tracker" parameter.
3518         (parse_expression_for_completion): Update.
3519         (null_post_parser): Add "tracker" parameter.
3520         * p-exp.y: Update rules.
3521         * m2-exp.y: Update rules.
3522         * language.h (struct language_defn) <la_post_parser>: Add
3523         "tracker" parameter.
3524         * go-exp.y: Update rules.
3525         * f-exp.y: Update rules.
3526         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3527         parameter.
3528         * d-exp.y: Update rules.
3529         * c-exp.y: Update rules.
3530         * breakpoint.c (set_breakpoint_condition): Create an
3531         innermost_block_tracker.
3532         (watch_command_1): Likewise.
3533         * ada-lang.c (resolve): Add "tracker" parameter.
3534         (resolve_subexp): Likewise.
3535         * ada-exp.y (write_var_from_sym): Update.
3536
3537 2019-04-04  Tom Tromey  <tom@tromey.com>
3538
3539         * type-stack.h: New file.
3540         * type-stack.c: New file.
3541         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3542         type-stack.h.
3543         (insert_into_type_stack, insert_type, push_type, push_type_int)
3544         (insert_type_address_space, pop_type, pop_type_int)
3545         (pop_typelist, pop_type_stack, append_type_stack)
3546         (push_type_stack, get_type_stack, push_typelist)
3547         (follow_type_instance_flags, follow_types): Don't declare.
3548         * parse.c (type_stack): Remove global.
3549         (parse_exp_in_context): Update.
3550         (insert_into_type_stack, insert_type, push_type, push_type_int)
3551         (insert_type_address_space, pop_type, pop_type_int)
3552         (pop_typelist, pop_type_stack, append_type_stack)
3553         (push_type_stack, get_type_stack, push_typelist)
3554         (follow_type_instance_flags, follow_types): Remove (moved to
3555         type-stack.c).
3556         * f-exp.y (type_stack): New global.
3557         Update rules.
3558         (push_kind_type, f_parse): Update.
3559         * d-exp.y (type_stack): New global.
3560         Update rules.
3561         (d_parse): Update.
3562         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3563         Update rules.
3564         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3565         (HFILES_NO_SRCDIR): Add type-stack.h.
3566
3567 2019-04-04  Tom Tromey  <tom@tromey.com>
3568
3569         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3570         (rust_parser::convert_ast_to_expression, rust_parse)
3571         (rust_lex_test_completion, rust_lex_tests): Update.
3572         * parser-defs.h (struct expr_completion_state): New.
3573         (struct parser_state) <parser_state>: Add completion parameter.
3574         <mark_struct_expression, mark_completion_tag>: New methods.
3575         <parse_completion, m_completion_state>: New members.
3576         (prefixify_expression, null_post_parser): Update.
3577         (mark_struct_expression, mark_completion_tag): Don't declare.
3578         * parse.c (parse_completion, expout_last_struct)
3579         (expout_tag_completion_type, expout_completion_name): Remove
3580         globals.
3581         (parser_state::mark_struct_expression)
3582         (parser_state::mark_completion_tag): Now methods.
3583         (prefixify_expression): Add last_struct parameter.
3584         (prefixify_subexp): Likewise.
3585         (parse_exp_1): Update.
3586         (parse_exp_in_context): Add cstate parameter.  Update.
3587         (parse_expression_for_completion): Create an
3588         expr_completion_state.
3589         (null_post_parser): Add "completion" parameter.
3590         * p-exp.y: Update rules.
3591         (yylex): Update.
3592         * language.h (struct language_defn) <la_post_parser>: Add
3593         "completing" parameter.
3594         * go-exp.y: Update rules.
3595         (lex_one_token): Update.
3596         * expression.h (parse_completion): Don't declare.
3597         * d-exp.y: Update rules.
3598         (lex_one_token): Update rules.
3599         * c-exp.y: Update rules.
3600         (lex_one_token): Update.
3601         * ada-lang.c (resolve): Add "parse_completion" parameter.
3602         (resolve_subexp): Likewise.
3603         (ada_resolve_function): Likewise.
3604
3605 2019-04-04  Tom Tromey  <tom@tromey.com>
3606
3607         * parser-defs.h (struct parser_state) <start_arglist,
3608         end_arglist>: New methods.
3609         <arglist_len, m_funcall_chain>: New members.
3610         (arglist_len, start_arglist, end_arglist): Don't declare.
3611         * parse.c (arglist_len, funcall_chain): Remove global.
3612         (start_arglist, end_arglist): Remove functions.
3613         (parse_exp_in_context): Update.
3614         * p-exp.y: Update rules.
3615         * m2-exp.y: Update rules.
3616         * go-exp.y: Update rules.
3617         * f-exp.y: Update rules.
3618         * d-exp.y: Update rules.
3619         * c-exp.y: Update rules.
3620
3621 2019-04-04  Tom Tromey  <tom@tromey.com>
3622
3623         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3624         lex_operator, push_back>: New methods.
3625         Update all rules.
3626         (rust_parser::lex_hex, lex_escape): Rename and update.
3627         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3628         (rust_parser::lex_operator): Rename and update.
3629         (rust_parser::lex_number, rustyylex, rustyyerror)
3630         (rust_lex_test_init, rust_lex_test_sequence)
3631         (rust_lex_test_push_back, rust_lex_tests): Update.
3632         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3633         parameter.
3634         <lexptr, prev_lexptr>: New members.
3635         (lexptr, prev_lexptr): Don't declare.
3636         * parse.c (lexptr, prev_lexptr): Remove globals.
3637         (parse_exp_in_context): Update.
3638         * p-exp.y (yylex, yyerror): Update.
3639         * m2-exp.y (parse_number, yylex, yyerror): Update.
3640         * go-exp.y (lex_one_token, yyerror): Update.
3641         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3642         * d-exp.y (lex_one_token, yyerror): Update.
3643         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3644         (lex_one_token, yyerror): Update.
3645         * ada-lex.l (YY_INPUT): Update.
3646         (rewind_to_char): Update.
3647         * ada-exp.y (yyerror): Update.
3648
3649 2019-04-04  Tom Tromey  <tom@tromey.com>
3650
3651         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3652         * parser-defs.h (struct parser_state) <parser_state>: Add new
3653         parameter.
3654         <comma_terminates>: New member.
3655         (comma_terminates): Don't declare global.
3656         * parse.c (comma_terminates): Remove global.
3657         (parse_exp_in_context): Update.
3658         * p-exp.y (yylex): Update.
3659         * m2-exp.y (yylex): Update.
3660         * go-exp.y (lex_one_token): Update.
3661         * f-exp.y (yylex): Update.
3662         * d-exp.y (lex_one_token): Update.
3663         * c-exp.y (lex_one_token): Update.
3664         * ada-lex.l: Update.
3665
3666 2019-04-04  Tom Tromey  <tom@tromey.com>
3667
3668         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3669         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3670         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3671         * parser-defs.h (paren_depth): Don't declare.
3672         * parse.c (paren_depth): Remove global.
3673         (parse_exp_in_context): Update.
3674         * p-exp.y (paren_depth): New global.
3675         (pascal_parse): Initialize it.
3676         * m2-exp.y (paren_depth): New global.
3677         (m2_parse): Initialize it.
3678         * go-exp.y (paren_depth): New global.
3679         (go_parse): Initialize it.
3680         * f-exp.y (paren_depth): New global.
3681         (f_parse): Initialize it.
3682         * d-exp.y (paren_depth): New global.
3683         (d_parse): Initialize it.
3684         * c-exp.y (paren_depth): New global.
3685         (c_parse): Initialize it.
3686         * ada-lex.l (paren_depth): New global.
3687         (lexer_init): Initialize it.
3688
3689 2019-04-04  Tom Tromey  <tom@tromey.com>
3690
3691         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3692         (rust_parser::convert_ast_to_type)
3693         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3694         * parser-defs.h (struct parser_state) <parser_state>: Add
3695         parameters.  Initialize new members.
3696         <expression_context_block, expression_context_pc>: New members.
3697         * parse.c (expression_context_block, expression_context_pc):
3698         Remove globals.
3699         (parse_exp_in_context): Update.
3700         * p-exp.y: Update all rules.
3701         (yylex): Update.
3702         * m2-exp.y: Update all rules.
3703         (yylex): Update.
3704         * go-exp.y (yylex): Update.
3705         * f-exp.y (yylex): Update.
3706         * d-exp.y: Update all rules.
3707         (yylex): Update.
3708         * c-exp.y: Update all rules.
3709         (lex_one_token, classify_name, yylex, c_parse): Update.
3710         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3711
3712 2019-04-04  Tom Tromey  <tom@tromey.com>
3713
3714         * gdbarch.h, gdbarch.c: Rebuild.
3715         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3716         * stap-probe.h:
3717         (struct stap_parse_info): Replace "parser_state" with
3718         "expr_builder".
3719         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3720         (parser_state): New class.
3721         * parse.c (expr_builder): Rename.
3722         (expr_builder::release): Rename.
3723         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3724         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3725         (write_exp_elt_longcst, write_exp_elt_floatcst)
3726         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3727         (write_exp_string_vector, write_exp_bitstring)
3728         (write_exp_msymbol, mark_struct_expression)
3729         (write_dollar_variable)
3730         (insert_type_address_space, increase_expout_size): Replace
3731         "parser_state" with "expr_builder".
3732         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3733         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3734         "parser_state" with "expr_builder".
3735
3736 2019-04-04  Tom Tromey  <tom@tromey.com>
3737
3738         * rust-exp.y: Replace "parse_language" with method call.
3739         * p-exp.y:
3740         (yylex): Replace "parse_language" with method call.
3741         * m2-exp.y:
3742         (yylex): Replace "parse_language" with method call.
3743         * go-exp.y (classify_name): Replace "parse_language" with method
3744         call.
3745         * f-exp.y (yylex): Replace "parse_language" with method call.
3746         * d-exp.y (lex_one_token): Replace "parse_language" with method
3747         call.
3748         * c-exp.y:
3749         (lex_one_token, classify_name, yylex): Replace "parse_language"
3750         with method call.
3751         * ada-exp.y (find_primitive_type, type_char)
3752         (type_system_address): Replace "parse_language" with method call.
3753
3754 2019-04-04  Tom Tromey  <tom@tromey.com>
3755
3756         * rust-exp.y: Replace "parse_gdbarch" with method call.
3757         * parse.c (write_dollar_variable, insert_type_address_space):
3758         Replace "parse_gdbarch" with method call.
3759         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3760         call.
3761         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3762         call.
3763         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3764         "parse_gdbarch" with method call.
3765         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3766         with method call.
3767         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3768         "parse_gdbarch" with method call.
3769         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3770         "parse_gdbarch" with method call.
3771         * c-exp.y (parse_type, parse_number, classify_name): Replace
3772         "parse_gdbarch" with method call.
3773         * ada-lex.l: Replace "parse_gdbarch" with method call.
3774         * ada-exp.y (parse_type, find_primitive_type, type_char)
3775         (type_system_address): Replace "parse_gdbarch" with method call.
3776
3777 2019-04-04  Tom Tromey  <tom@tromey.com>
3778
3779         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3780         * stap-probe.c (stap_parse_argument): Update.
3781         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3782         initial_size parameter.
3783         * rust-exp.y (rust_lex_tests): Update.
3784         * parse.c (parser_state): Update.
3785         (parse_exp_in_context): Update.
3786         * parser-defs.h (struct parser_state) <parser_state>: Remove
3787         "initial_size" parameter.
3788
3789 2019-04-04  Tom Tromey  <tom@tromey.com>
3790
3791         * parser-defs.h (increase_expout_size): Don't declare.
3792         * parse.c (increase_expout_size): Now static.
3793
3794 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3795
3796         * gnu-nat.c (gnu_nat_target::wait): Fix
3797         target_waitstatus_to_string call.
3798
3799 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3800
3801         * eval.c (evaluate_subexp_standard): Handle internal functions
3802         during Fortran function call handling.
3803
3804 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3805
3806         * NEWS: Mention new internal functions.
3807         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3808         (read_base_type): Use dwarf2_init_complex_target_type.
3809         * value.c (creal_internal_fn): New function.
3810         (cimag_internal_fn): New function.
3811         (_initialize_values): Register new internal functions.
3812
3813 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3814
3815         * infrun.c (stop_all_threads): If debug_infrun, always
3816         trace the wait status after wait_one, using
3817         target_waitstatus_to_string and target_pid_to_str.
3818         (handle_inferior_event): Replace various trace of
3819         wait status kind by a single trace.
3820         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3821         wait status kind image by target_waitstatus_to_string.
3822         * target/waitstatus.c (target_waitstatus_to_string): Fix
3823         obsolete comment.
3824
3825 2019-04-01  Tom Tromey  <tromey@adacore.com>
3826
3827         PR symtab/23331:
3828         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3829
3830 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3831             Pedro Alves  <palves@redhat.com>
3832
3833         * top.c (quit_force): Call 'finalize_values'.
3834         * value.c (finalize_values): New function.
3835         * value.h (finalize_values): Declare.
3836
3837 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3838
3839         * NEWS: Announce $_gdb_major and $_gdb_minor.
3840
3841         * top.c (init_gdb_version_vars): New function.
3842         (gdb_init): Call init_gdb_version_vars.
3843
3844 2019-03-29  Tom Tromey  <tromey@adacore.com>
3845
3846         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3847         help text.  Remove dead code.
3848
3849 2019-03-29  Keith Seitz  <keiths@redhat.com>
3850
3851         From Siddhesh Poyarekar:
3852         * f-lang.h (f77_get_upperbound): Return LONGEST.
3853         (f77_get_lowerbound): Likewise.
3854         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3855         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3856         print them.
3857         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3858         plongest to format print it.
3859         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3860         (f77_get_upperbound): Likewise.
3861         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3862         LOWER_BOUND to LONGEST.
3863         (f77_create_arrayprint_offset_tbl): Likewise.
3864
3865 2019-03-29  Keith Seitz  <keiths@redhat.com>
3866
3867         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3868         %s/pulongest for TYPE_LENGTH instead of %d in format
3869         strings.
3870         * ada-typerint.c (ada_print_type): Likewise.
3871         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3872         * compile/compile-c-support.c (generate_register_struct): Likewise.
3873         * gdbtypes.c (recursive_dump_type): Likewise.
3874         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3875         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3876         instead of %d in format strings.
3877         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3878         to std::min to ULONGEST.
3879         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3880         instead of %d in format strings.
3881         * tracepoint.c (info_scope_command): Likewise.
3882         * typeprint.c (print_offset_data::update)
3883         (print_offset_data::finish): Likewise.
3884         * xtensa-tdep.c (xtensa_store_return_value)
3885         (xtensa_push_dummy_call): Likewise.
3886
3887 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3888
3889         * windows-nat.c (display_selector): Fixed format specifications
3890         for 64-bit Cygwin.
3891
3892 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3893
3894         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3895
3896 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3897
3898         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3899         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3900         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3901         (nios2_linux_init_abi): Install it.
3902
3903 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3904
3905         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3906
3907 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3908
3909         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3910
3911 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3912             Tom Tromey  <tromey@adacore.com>
3913
3914         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3915
3916 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3917
3918         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3919         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3920         method to compute the bounds of range types. Also print "[evaluated]"
3921         if the bounds' values come from a dynamic evaluation.
3922
3923 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3924
3925         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3926         whitespace when pretty printing is on.
3927
3928 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3929
3930         * ppc-linux-nat.c: Add include.
3931
3932 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3933
3934         * NEWS: Mention AArch64 Pointer Authentication.
3935
3936 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3937
3938         * arm-linux-nat.c: Add include.
3939
3940 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3941
3942         * source-cache.c (source_cache::get_source_lines): Re-read
3943         fullname after calling open_source_file.
3944
3945 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3946
3947         * NEWS: Mention TLS support for FreeBSD.
3948
3949 2019-03-25  Tom Tromey  <tromey@adacore.com>
3950
3951         * minsyms.c (BUNCH_SIZE): Update comment.
3952         (~minimal_symbol_reader): Remove old comment.
3953         (compact_minimal_symbols): Update comment.
3954         (minimal_symbol_reader::install): Remove old comment.  Update
3955         other comments.
3956
3957 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3958
3959         * s390-linux-nat.c: Add include.
3960
3961 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3962
3963         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3964         Call linux_get_hwcap.
3965         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3966         Likewise.
3967         (aarch64_linux_get_hwcap): Remove function.
3968         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3969         declaration.
3970         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3971         linux_get_hwcap.
3972         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3973         * linux-tdep.c (linux_get_hwcap): Add function.
3974         (linux_get_hwcap2): Likewise.
3975         * linux-tdep.h (linux_get_hwcap): Add declaration.
3976         (linux_get_hwcap2): Likewise.
3977         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3978         (ppc_linux_get_hwcap2): Likewise.
3979         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3980         linux_get_hwcap.
3981         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3982         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3983         (ppc_linux_nat_target::read_description): Likewise.
3984         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3985         * s390-linux-nat.c: Likewise.
3986         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3987
3988 2019-03-24  Tom Tromey  <tom@tromey.com>
3989
3990         * ada-lang.c (standard_lookup): Simplify initialization.
3991         (ada_lookup_symbol_nonlocal): Simplify return.
3992         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3993         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3994         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3995         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3996         initialization.
3997         * solib.c (solib_global_lookup): Simplify.
3998         * symtab.c (null_block_symbol): Remove.
3999         (symbol_cache_lookup): Simplify returns.
4000         (lookup_language_this): Simplify returns.
4001         (lookup_symbol_aux): Simplify return.
4002         (lookup_local_symbol): Simplify returns.
4003         (lookup_global_symbol_from_objfile): Simplify return.
4004         (lookup_symbol_in_objfile_symtabs)
4005         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4006         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4007         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4008         * cp-namespace.c (cp_lookup_bare_symbol)
4009         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4010         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4011         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4012         (cp_lookup_symbol_via_imports): Simplify initialization.
4013         (find_symbol_in_baseclass): Likewise.
4014         * symtab.h (null_block_symbol): Remove.
4015         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4016         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4017         (d_lookup_symbol_module): Likewise.
4018         (find_symbol_in_baseclass): Simplify initialization.
4019
4020 2019-03-24  Tom Tromey  <tom@tromey.com>
4021
4022         * expression.h: Don't include symtab.h.
4023         (struct block): Forward declare.
4024
4025 2019-03-24  Tom Tromey  <tom@tromey.com>
4026
4027         * c-exp.y (typebase): Remove casts.
4028         * gdbtypes.c (lookup_unsigned_typename, )
4029         (lookup_signed_typename): Remove cast.
4030         * eval.c (parse_to_comma_and_eval): Remove cast.
4031         * parse.c (write_dollar_variable): Remove cast.
4032         * block.h (struct block) <superblock>: Now const.
4033         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4034         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4035         (map_block): Make "block" const.
4036         * symfile.h (struct quick_symbol_functions)
4037         <map_matching_symbols>: Constify block argument to "callback".
4038         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4039         const.
4040         (find_pc_sect_compunit_symtab): Make "b" const.
4041         (find_symbol_at_address): Likewise.
4042         (search_symbols): Likewise.
4043         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4044         (dw2_debug_names_lookup_symbol): Likewise.
4045         (dw2_map_matching_symbols): Update.
4046         * p-valprint.c (pascal_val_print): Remove "block".
4047         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4048         (aux_add_nonlocal_symbols): Make "block" const.
4049         (resolve_subexp): Remove cast.
4050         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4051         const.
4052         (iterate_over_file_blocks): Likewise.
4053         * f-exp.y (%union) <bval>: Remove.
4054         * coffread.c (patch_opaque_types): Make "b" const.
4055         * spu-tdep.c (spu_catch_start): Make "block" const.
4056         * c-valprint.c (print_unpacked_pointer): Remove "block".
4057         * symmisc.c (dump_symtab_1): Make "b" const.
4058         (block_depth): Make "block" const.
4059         * d-exp.y (%union) <bval>: Remove.
4060         * cp-support.h (cp_lookup_rtti_type): Update.
4061         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4062         * psymtab.c (psym_lookup_symbol): Make "block" const.
4063         (maintenance_check_psymtabs): Make "b" const.
4064         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4065         (enumerate_locals, enumerate_args): Update.
4066         * python/py-symtab.c (stpy_global_block): Make "block" const.
4067         (stpy_static_block): Likewise.
4068         * inline-frame.c (block_starting_point_at): Make "new_block"
4069         const.
4070         * block.c (find_block_in_blockvector): Make return type const.
4071         (blockvector_for_pc_sect): Make "b" const.
4072         (find_block_in_blockvector): Make "b" const.
4073
4074 2019-03-23  Tom Tromey  <tom@tromey.com>
4075
4076         * varobj.c (varobj_create): Update.
4077         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4078         * printcmd.c (display_command, do_one_display): Don't reset
4079         innermost_block.
4080         * parser-defs.h (enum innermost_block_tracker_type): Move to
4081         expression.h.
4082         (innermost_block): Update comment.
4083         * parse.c (parse_exp_1): Add tracker_types parameter.
4084         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4085         tracker_types parameter.  Reset innermost_block.
4086         (parse_exp_in_context): Remove.
4087         (parse_expression_for_completion): Update.
4088         * objfiles.c (~objfile): Don't reset expression_context_block or
4089         innermost_block.
4090         * expression.h (enum innermost_block_tracker_type): Move from
4091         parser-defs.h.
4092         (parse_exp_1): Add tracker_types parameter.
4093         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4094         reset innermost_block.
4095
4096 2019-03-23  Tom Tromey  <tom@tromey.com>
4097
4098         * objfiles.h: Include bcache.h.
4099
4100 2019-03-23  Tom Tromey  <tom@tromey.com>
4101
4102         * linespec.c (get_current_search_block): Use
4103         scoped_restore_current_language.
4104         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4105
4106 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4107             Jiong Wang  <jiong.wang@arm.com>
4108
4109         * aarch64-linux-tdep.c
4110         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4111         section.
4112         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4113
4114 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4115             Jiong Wang  <jiong.wang@arm.com>
4116
4117         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4118         instructions.
4119         (aarch64_analyze_prologue_test): Add PACIASP test.
4120         (aarch64_prologue_prev_register): Unmask PC value.
4121
4122 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4123             Jiong Wang  <jiong.wang@arm.com>
4124
4125         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4126         (aarch64_dwarf2_prev_register): Unmask PC value.
4127         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4128         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4129         DW_CFA_AARCH64_negate_ra_state.
4130         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4131
4132 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4133             Jiong Wang  <jiong.wang@arm.com>
4134
4135         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4136         registers.
4137         (aarch64_pseudo_register_name): Likewise.
4138         (aarch64_pseudo_register_type): Likewise.
4139         (aarch64_pseudo_register_reggroup_p): Likewise.
4140         (aarch64_gdbarch_init): Add pauth registers.
4141         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4142         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4143         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4144         (struct gdbarch_tdep): Add regnum for ra_state.
4145
4146 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4147             Jiong Wang  <jiong.wang@arm.com>
4148
4149         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4150
4151 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4152             Jiong Wang  <jiong.wang@arm.com>
4153
4154         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4155         function.
4156         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4157         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4158         (aarch64_gdbarch_init): Add puth registers.
4159         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4160         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4161         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4162
4163 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4164             Jiong Wang  <jiong.wang@arm.com>
4165
4166         * aarch64-linux-nat.c
4167         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4168         * aarch64-linux-tdep.c
4169         (aarch64_linux_core_read_description): Likewise.
4170         (aarch64_linux_get_hwcap): New function.
4171         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4172         (aarch64_linux_get_hwcap): New declaration.
4173
4174 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4175             Jiong Wang  <jiong.wang@arm.com>
4176
4177         * aarch64-linux-nat.c
4178         (aarch64_linux_nat_target::read_description): Add pauth param.
4179         * aarch64-linux-tdep.c
4180         (aarch64_linux_core_read_description): Likewise.
4181         * aarch64-tdep.c (struct target_desc): Add in pauth.
4182         (aarch64_read_description): Add pauth param.
4183         (aarch64_gdbarch_init): Likewise.
4184         * aarch64-tdep.h (aarch64_read_description): Likewise.
4185         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4186         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4187         * features/Makefile: Add new files.
4188         * features/aarch64-pauth.c: New file.
4189         * features/aarch64-pauth.xml: New file.
4190
4191 2019-03-20  Tom Tromey  <tromey@adacore.com>
4192
4193         * infrun.c (handle_inferior_event): Rename from
4194         handle_inferior_event_1.  Create a scoped_value_mark.
4195         (handle_inferior_event): Remove.
4196
4197 2019-03-19  Tom Tromey  <tromey@adacore.com>
4198
4199         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4200         * infrun.h (print_stop_event): Add "displays" parameter.
4201         * infrun.c (print_stop_event): Add "displays" parameter.
4202
4203 2019-03-19  Pedro Alves  <palves@redhat.com>
4204
4205         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4206         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4207         to -1.  Fix TABs vs spaces.
4208         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4209         * tui/tui-out.h (tui_ui_out) Add intro comments.
4210         <m_line, m_start_of_line>: In-class initialize, and add describing
4211         comment.
4212
4213 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4214
4215         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4216         variable names.
4217         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4218
4219 2019-03-18  Pedro Alves  <palves@redhat.com>
4220             Eli Zaretskii <eliz@gnu.org>
4221
4222         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4223         m_line and m_start_of_line.
4224
4225 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4226
4227         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4228         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4229         it returns a newline.  This fixes a regression in TU mode, whereby
4230         the next line is output on the same screen line as the user input.
4231
4232 2019-03-18  Tom Tromey  <tromey@adacore.com>
4233
4234         * minsyms.c (minimal_symbol_reader::install): Remove call to
4235         obstack_blank.
4236
4237 2019-03-18  Pedro Alves  <palves@redhat.com>
4238
4239         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4240         New globals.
4241         (apply_style): New, factored out from ...
4242         (apply_ansi_escape): ... this.  Handle reverse video mode.
4243         (tui_set_reverse_mode): New function.
4244         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4245         * tui/tui-winsource.c (tui_show_source_line): Use
4246         tui_set_reverse_mode instead of setting A_STANDOUT.
4247         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4248         New setter methods.
4249
4250 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4251
4252         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4253         Handle tabs.
4254
4255 2019-03-18  Tom Tromey  <tromey@adacore.com>
4256
4257         * ada-lang.c (empty_array): Add "high" parameter.
4258         (ada_evaluate_subexp): Update.
4259
4260 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4261
4262         * unittests/string_view-selftests.c: Define
4263         _initialize_string_view_selftests unconditionally.
4264
4265 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4266
4267         PR gdb/24350
4268         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4269
4270 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4271
4272         PR gdb/24351
4273         * windows-nat.c (display_selector): Fix format specifiers.
4274
4275 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4276
4277         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4278         tui_refill_source_window instead of tui_refresh_win, to update the
4279         current execution line.  This fixes redisplay of the current line
4280         when stepping through the code with "next" or "step".
4281
4282 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4283
4284         * source-cache.c (source_cache::get_source_lines): Call
4285         find_source_lines to initialize s->nlines.  This fixes vertical
4286         scrolling of TUI source window when the DOWN arrow is pressed.
4287
4288 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4289
4290         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4291         linux-thread-db.c (_initialize_thread_db): Likewise.
4292
4293 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4294
4295         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4296         wclrtoeol in tui_show_source_line".  This reverts changes made in
4297         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4298
4299 2019-03-15  Tom Tromey  <tom@tromey.com>
4300
4301         * symtab.h (struct minimal_symbol): Derive from
4302         general_symbol_info.
4303         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4304         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4305         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4306         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4307         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4308         (MSYMBOL_SEARCH_NAME): Update.
4309         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4310         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4311         * minsyms.c (minimal_symbol_reader::record_full): Update.
4312
4313 2019-03-15  Tom Tromey  <tom@tromey.com>
4314
4315         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4316
4317 2019-03-15  Tom Tromey  <tom@tromey.com>
4318
4319         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4320         unique_xmalloc_ptr.
4321         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4322         Update.
4323         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4324         (build_minimal_symbol_hash_tables)
4325         (minimal_symbol_reader::install): Update.
4326
4327 2019-03-15  Tom Tromey  <tom@tromey.com>
4328
4329         * symtab.c (create_demangled_names_hash): Update.
4330         (symbol_set_names): Update.
4331         * objfiles.h (struct objfile_per_bfd_storage)
4332         <demangled_names_hash>: Now an htab_up.
4333         * objfiles.c (objfile_per_bfd_storage): Simplify.
4334
4335 2019-03-15  Tom Tromey  <tom@tromey.com>
4336
4337         * objfiles.h (struct objfile_per_bfd_storage): Declare
4338         destructor.
4339         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4340         New.
4341         (get_objfile_bfd_data): Use new.  Don't initialize
4342         language_of_main.
4343         (free_objfile_per_bfd_storage): Remove.
4344         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4345
4346 2019-03-15  Tom Tromey  <tom@tromey.com>
4347
4348         * symfile.c (reread_symbols): Update.
4349         * objfiles.c (objfile::objfile): Update.
4350         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4351         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4352         comment.
4353         (minimal_symbol_reader::install): Update.
4354         (terminate_minimal_symbol_table): Remove.
4355         * jit.c (jit_object_close_impl): Update.
4356
4357 2019-03-15  Tom Tromey  <tom@tromey.com>
4358
4359         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4360         initializations.
4361
4362 2019-03-15  Tom Tromey  <tom@tromey.com>
4363
4364         * objfiles.h (struct objfile_per_bfd_storage)
4365         <demangled_hash_languages>: Now a bitset.
4366         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4367         (lookup_minimal_symbol): Update.
4368
4369 2019-03-15  Tom Tromey  <tom@tromey.com>
4370
4371         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4372         Don't return the symbol.
4373         * coffread.c (record_minimal_symbol): Use record_full.
4374
4375 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4376
4377         The MS-Windows port of ncurses fails to switch to a color pair if
4378         one or both of the colors are the implicit default colors.  This
4379         change records the default colors when TUI is initialized, and
4380         then specifies them explicitly when a color pair uses the default
4381         colors.  This allows color styling in TUI mode on MS-Windows.
4382
4383         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4384         ncurses_norm_attr.
4385         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4386         colors in ncurses_norm_attr.
4387         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4388         "none", replace it with the default color recorded in
4389         ncurses_norm_attr.
4390
4391 2019-03-14  Tom Tromey  <tromey@adacore.com>
4392
4393         * source-cache.h (class source_cache) <get_source_lines>: Return
4394         std::string.
4395         * source-cache.c (source_cache::extract_lines): Handle case where
4396         first_pos==npos.  Return std::string.
4397         (source_cache::get_source_lines): Update.
4398
4399 2019-03-14  Tom Tromey  <tromey@adacore.com>
4400
4401         * NEWS: Add item for "style sources" commands.
4402         * source-cache.c (source_cache::get_source_lines): Check
4403         source_styling.
4404         * cli/cli-style.c (source_styling): New global.
4405         (_initialize_cli_style): Add "style sources" commands.
4406         (show_style_sources): New function.
4407         * cli/cli-style.h (source_styling): Declare.
4408
4409 2019-03-14  Pedro Alves  <palves@redhat.com>
4410             Tom Tromey  <tromey@adacore.com>
4411
4412         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4413         * tui/tui-winsource.c (tui_refill_source_window): New function,
4414         from...
4415         (tui_horizontal_source_scroll): ... here.  Move some logic.
4416         * cli/cli-style.c (set_style_enabled): Notify new observable.
4417         * tui/tui-hooks.c (tui_redisplay_source): New function.
4418         (tui_attach_detach_observers): Attach or detach
4419         tui_redisplay_source.
4420         * observable.h (source_styling_changed): New observable.
4421         * observable.c: Define source_styling_changed observable.
4422
4423 2019-03-13  Tom Tromey  <tromey@adacore.com>
4424
4425         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4426         (i386_gnu_nat_target::store_registers): Update.
4427         * target-debug.h (target_debug_print_std_string): New macro.
4428         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4429         * windows-tdep.c (display_one_tib): Update.
4430         * tui/tui-stack.c (tui_make_status_line): Update.
4431         * top.c (print_inferior_quit_action): Update.
4432         * thread.c (thr_try_catch_cmd): Update.
4433         (add_thread_with_info): Update.
4434         (thread_target_id_str): Update.
4435         (thr_try_catch_cmd): Update.
4436         (thread_command): Update.
4437         (thread_find_command): Update.
4438         * record-btrace.c (record_btrace_target::info_record)
4439         (record_btrace_resume_thread, record_btrace_target::resume)
4440         (record_btrace_cancel_resume, record_btrace_step_thread)
4441         (record_btrace_target::wait, record_btrace_target::wait)
4442         (record_btrace_target::wait, record_btrace_target::stop): Update.
4443         * progspace.c (print_program_space): Update.
4444         * process-stratum-target.c
4445         (process_stratum_target::thread_address_space): Update.
4446         * linux-fork.c (linux_fork_mourn_inferior)
4447         (detach_checkpoint_command, info_checkpoints_command)
4448         (linux_fork_context): Update.
4449         (linux_fork_detach): Update.
4450         (class scoped_switch_fork_info): Update.
4451         (delete_checkpoint_command): Update.
4452         * infrun.c (follow_fork_inferior): Update.
4453         (follow_fork_inferior): Update.
4454         (proceed_after_vfork_done): Update.
4455         (handle_vfork_child_exec_or_exit): Update.
4456         (follow_exec): Update.
4457         (displaced_step_prepare_throw): Update.
4458         (displaced_step_restore): Update.
4459         (start_step_over): Update.
4460         (resume_1): Update.
4461         (clear_proceed_status_thread): Update.
4462         (proceed): Update.
4463         (print_target_wait_results): Update.
4464         (do_target_wait): Update.
4465         (context_switch): Update.
4466         (stop_all_threads): Update.
4467         (restart_threads): Update.
4468         (finish_step_over): Update.
4469         (handle_signal_stop): Update.
4470         (switch_back_to_stepped_thread): Update.
4471         (keep_going_pass_signal): Update.
4472         (print_exited_reason): Update.
4473         (normal_stop): Update.
4474         * inferior.c (inferior_pid_to_str): Change return type.
4475         (print_selected_inferior): Update.
4476         (add_inferior): Update.
4477         (detach_inferior): Update.
4478         * dummy-frame.c (fprint_dummy_frames): Update.
4479         * dcache.c (dcache_info_1): Update.
4480         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4481         (btrace_fetch, btrace_clear): Update.
4482         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4483         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4484         type.
4485         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4486         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4487         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4488         * gdbarch.c, gdbarch.h: Rebuild.
4489         * gdbarch.sh (core_pid_to_str): Change return type.
4490         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4491         return type.
4492         (windows_nat_target::pid_to_str): Change return type.
4493         (windows_delete_thread): Update.
4494         (windows_nat_target::attach): Update.
4495         (windows_nat_target::files_info): Update.
4496         * target-delegates.c: Rebuild.
4497         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4498         return type.
4499         (sol_thread_target::pid_to_str): Change return type.
4500         * remote.c (class remote_target) <pid_to_str>: Change return
4501         type.
4502         (remote_target::pid_to_str): Change return type.
4503         (extended_remote_target::attach, remote_target::remote_stop_ns)
4504         (remote_target::remote_notif_remove_queued_reply)
4505         (remote_target::push_stop_reply, remote_target::disable_btrace):
4506         Update.
4507         (extended_remote_target::attach): Update.
4508         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4509         type.
4510         (gdbsim_target::pid_to_str): Change return type.
4511         * ravenscar-thread.c (struct ravenscar_thread_target)
4512         <pid_to_str>: Change return type.
4513         (ravenscar_thread_target::pid_to_str): Change return type.
4514         * procfs.c (class procfs_target) <pid_to_str>: Change return
4515         type.
4516         (procfs_target::pid_to_str): Change return type.
4517         (procfs_target::attach): Update.
4518         (procfs_target::detach): Update.
4519         (procfs_target::fetch_registers): Update.
4520         (procfs_target::store_registers): Update.
4521         (procfs_target::wait): Update.
4522         (procfs_target::files_info): Update.
4523         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4524         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4525         return type.
4526         (nto_procfs_target::pid_to_str): Change return type.
4527         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4528         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4529         return type.
4530         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4531         (exit_lwp): Update.
4532         (attach_proc_task_lwp_callback, get_detach_signal)
4533         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4534         (linux_nat_target::resume, wait_lwp, stop_callback)
4535         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4536         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4537         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4538         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4539         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4540         type.
4541         (inf_ptrace_target::attach): Update.
4542         (inf_ptrace_target::files_info): Update.
4543         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4544         type.
4545         (go32_nat_target::pid_to_str): Change return type.
4546         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4547         (gnu_nat_target::wait): Update.
4548         (gnu_nat_target::wait): Update.
4549         (gnu_nat_target::resume): Update.
4550         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4551         (fbsd_nat_target::wait): Update.
4552         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4553         type.
4554         (darwin_nat_target::attach): Update.
4555         * corelow.c (class core_target) <pid_to_str>: Change return type.
4556         (core_target::pid_to_str): Change return type.
4557         * target.c (normal_pid_to_str): Change return type.
4558         (default_pid_to_str): Likewise.
4559         (target_pid_to_str): Change return type.
4560         (target_translate_tls_address): Update.
4561         (target_announce_detach): Update.
4562         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4563         return type.
4564         (bsd_uthread_target::pid_to_str): Change return type.
4565         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4566         type.
4567         (bsd_kvm_target::pid_to_str): Change return type.
4568         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4569         return type.
4570         (aix_thread_target::pid_to_str): Change return type.
4571         * target.h (struct target_ops) <pid_to_str>: Change return type.
4572         (target_pid_to_str, normal_pid_to_str): Likewise.
4573         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4574         type.
4575         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4576         type.
4577         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4578         return type.
4579         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4580         type.
4581         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4582         type.
4583         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4584         return type.
4585
4586 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4587
4588         * NEWS: Mention that the new default MI version is 3.  Mention
4589         changes to the output of commands and events that deal with
4590         multi-location breakpoints.
4591         * breakpoint.c: Include "mi/mi-out.h".
4592         (print_one_breakpoint): Change output syntax if using MI version
4593         >= 3.
4594         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4595         New.
4596         (mi_multi_location_breakpoint_output_fixed): New.
4597         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4598         (mi_cmd_fix_multi_location_breakpoint_output): New.
4599         (mi_multi_location_breakpoint_output_fixed): New.
4600         * mi/mi-cmds.c (mi_cmds): Register command
4601         -fix-multi-location-breakpoint-output.
4602         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4603         interpreter "mi".
4604
4605 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4606
4607         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4608         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4609         instantiate mi_ui_out based on interpreter name.
4610         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4611         * mi/mi-main.c (mi_load_progress): Likewise.
4612
4613 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4614
4615         * NEWS: Combine separate "New targets" sections for 8.3.
4616
4617 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4618
4619         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4620         (ppcfbsd_init_abi): Install gdbarch
4621         "fetch_tls_load_module_address" and "get_thread_local_address"
4622         methods.
4623
4624 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4625
4626         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4627         (riscv_fbsd_init_abi): Install gdbarch
4628         "fetch_tls_load_module_address" and "get_thread_local_address"
4629         methods.
4630
4631 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4632
4633         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4634         (i386fbsd_init_abi): Install gdbarch
4635         "fetch_tls_load_module_address" and "get_thread_local_address"
4636         methods.
4637
4638 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4639
4640         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4641         (amd64fbsd_init_abi): Install gdbarch
4642         "fetch_tls_load_module_address" and "get_thread_local_address"
4643         methods.
4644
4645 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4646
4647         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4648         (struct fbsd_pspace_data): New type.
4649         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4650         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4651         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4652         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4653         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4654
4655 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4656
4657         * gdbtypes.c (lookup_struct_elt): New function.
4658         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4659         * gdbtypes.h (struct struct_elt): New type.
4660         (lookup_struct_elt): New prototype.
4661
4662 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4663
4664         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4665         remove disabled code block.
4666
4667 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4668
4669         * gdbarch.sh (get_thread_local_address): New method.
4670         * gdbarch.h, gdbarch.c: Regenerate.
4671         * target.c (target_translate_tls_address): Use
4672         gdbarch_get_thread_local_address if present instead of
4673         target::get_thread_local_address.
4674
4675 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4676
4677         * target.h (target::get_thread_local_address): Update comment.
4678
4679 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4680
4681         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4682         objfile->separate_debug_objfile_backlink if not NULL.
4683
4684 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4685
4686         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4687         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4688         (amd64bsd_store_inferior_registers): Likewise.
4689         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4690         Enable segment base registers.
4691         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4692         PT_GETFSBASE and PT_GETGSBASE.
4693         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4694         PT_SETGSBASE.
4695         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4696         segment base registers.
4697         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4698
4699 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4700
4701         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4702         Update calls to i386_target_description to add 'segments'
4703         parameter.
4704         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4705         add segment base registers.
4706         * arch/i386.c (i386_create_target_description): Add 'segments'
4707         parameter to enable segment base registers.
4708         * arch/i386.h (i386_create_target_description): Likewise.
4709         * features/i386/32bit-segments.xml: New file.
4710         * features/i386/32bit-segments.c: Generate.
4711         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4712         call to i386_target_description to add 'segments' parameter.
4713         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4714         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4715         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4716         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4717         if feature is present.
4718         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4719         Add 'segments' parameter to call to i386_target_description.
4720         (i386_target_description): Add 'segments' parameter to enable
4721         segment base registers.
4722         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4723         to call to i386_target_description.
4724         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4725         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4726         Define I386_NUM_REGS.
4727         (i386_target_description): Add 'segments' parameter to enable
4728         segment base registers.
4729
4730 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4731
4732         PR/24325
4733         * source-cache.c: #undef open and close, to avoid unresolved
4734         externals during linking.
4735
4736 2019-03-12  Tom Tromey  <tromey@adacore.com>
4737
4738         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4739         const.  Add initializers.
4740         (_initialize_remote): Don't initialize ptid globals.
4741
4742 2019-03-12  Pedro Alves  <palves@redhat.com>
4743
4744         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4745
4746 2019-03-12  Pedro Alves  <palves@redhat.com>
4747
4748         * cp-name-parser.y (main): Remove unused 'len' variable.
4749
4750 2019-03-12  Tom Tromey  <tromey@adacore.com>
4751
4752         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4753         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4754
4755 2019-03-12  Tom Tromey  <tromey@adacore.com>
4756
4757         * linux-nat.c (iterate_over_lwps): Update.
4758         (stop_callback): Remove parameter.
4759         (stop_wait_callback, detach_callback, resume_set_callback)
4760         (select_singlestep_lwp_callback, set_ignore_sigint)
4761         (status_callback, resumed_callback, resume_clear_callback)
4762         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4763         data parameter.
4764         (linux_nat_target::detach, linux_nat_target::resume)
4765         (linux_stop_and_wait_all_lwps, select_event_lwp)
4766         (linux_nat_filter_event, linux_nat_wait_1)
4767         (linux_nat_target::kill, linux_nat_target::stop)
4768         (linux_nat_target::stop): Update.
4769         (linux_nat_resume_callback): Change type.
4770         (resume_stopped_resumed_lwps, count_events_callback)
4771         (select_event_lwp_callback): Likewise.
4772         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4773         * arm-linux-nat.c (struct update_registers_data): Remove.
4774         (update_registers_callback): Change type.
4775         (arm_linux_insert_hw_breakpoint1): Update.
4776         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4777         parameter.
4778         (x86_linux_dr_set_addr): Update.
4779         (x86_linux_dr_set_control): Update.
4780         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4781         (iterate_over_lwps): Use gdb::function_view.
4782         * nat/aarch64-linux-hw-point.c (struct
4783         aarch64_dr_update_callback_param): Remove.
4784         (debug_reg_change_callback): Change type.
4785         (aarch64_notify_debug_reg_change): Update.
4786         * s390-linux-nat.c (s390_refresh_per_info): Update.
4787
4788 2019-03-11  Tom Tromey  <tromey@adacore.com>
4789
4790         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4791         redundant assignment to "this_cu".
4792
4793 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4794
4795         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4796
4797 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4798
4799         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4800         from...
4801         (rank_one_type): ... this.
4802
4803 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4804
4805         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4806         from...
4807         (rank_one_type): ... this.
4808
4809 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4810
4811         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4812         from...
4813         (rank_one_type): ... this.
4814
4815 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4816
4817         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4818         from...
4819         (rank_one_type): ... this.
4820
4821 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4822
4823         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4824         from...
4825         (rank_one_type): ... this.
4826
4827 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4828
4829         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4830         from...
4831         (rank_one_type): ... this.
4832
4833 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4834
4835         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4836         from...
4837         (rank_one_type): ... this.
4838
4839 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4840
4841         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4842         from...
4843         (rank_one_type): ... this.
4844
4845 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4846
4847         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4848         from...
4849         (rank_one_type): ... this.
4850
4851 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4852
4853         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4854         from...
4855         (rank_one_type): ... this.
4856
4857 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4858
4859         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4860         from...
4861         (rank_one_type): ... this.
4862
4863 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4864
4865         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4866         from...
4867         (rank_one_type): ... this.
4868
4869 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4870
4871         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4872         inferior-events' shows the example events.
4873
4874 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4875
4876         Support styling on native MS-Windows console
4877
4878         PR/24315
4879         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4880         on MS-Windows if $TERM is not defined.
4881
4882         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4883
4884         * posix-hdep.c (gdb_console_fputs):
4885         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4886         functions.
4887         * ui-file.h (gdb_console_fputs): Add prototype.
4888
4889         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4890         back to fputs only if the former returns zero.
4891
4892 2019-03-07  Tom Tromey  <tom@tromey.com>
4893
4894         * symmisc.c (print_symbol_bcache_statistics): Update.
4895         (print_objfile_statistics): Update.
4896         * symfile.c (allocate_symtab): Update.
4897         * stabsread.c: Don't include bcache.h.
4898         * psymtab.h (struct psymbol_bcache): Don't declare.
4899         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4900         (psymbol_bcache_init, psymbol_bcache_free)
4901         (psymbol_bcache_get_bcache): Don't declare.
4902         * psymtab.c (struct psymbol_bcache): Remove.
4903         (psymtab_storage::psymtab_storage): Update.
4904         (psymtab_storage::~psymtab_storage): Update.
4905         (psymbol_bcache_init, psymbol_bcache_free)
4906         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4907         (add_psymbol_to_bcache): Update.
4908         (allocate_psymtab): Update.
4909         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4910         macro_cache>: No longer pointers.
4911         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4912         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4913         * macrotab.c (macro_bcache): Update.
4914         * macroexp.c: Don't include bcache.h.
4915         * gdbtypes.c (check_types_worklist): Update.
4916         (types_deeply_equal): Remove TRY/CATCH.  Update.
4917         * elfread.c (elf_symtab_read): Update.
4918         * dwarf2read.c: Don't include bcache.h.
4919         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4920         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4921         (print_bcache_statistics, bcache_memory_used): Don't declare.
4922         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4923         methods.  Rename all data members.
4924         * bcache.c (struct bcache): Move to bcache.h.
4925         (bcache::expand_hash_table): Rename from expand_hash_table.
4926         (bcache): Remove.
4927         (bcache::insert): Rename from bcache_full.
4928         (bcache::compare): Rename from bcache_compare.
4929         (bcache_xmalloc): Remove.
4930         (bcache::~bcache): Rename from bcache_xfree.
4931         (bcache::print_statistics): Rename from print_bcache_statistics.
4932         (bcache::memory_used): Rename from bcache_memory_used.
4933
4934 2019-03-07  Pedro Alves  <palves@redhat.com>
4935
4936         * infrun.c (normal_stop): Also check for
4937         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4938
4939 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4940
4941         * f-lang.c (value_from_host_double): Moved to...
4942         * value.c (value_from_host_double): ...here.
4943         * value.h (value_from_host_double): Declare.
4944         * guile/scm-math.c (vlscm_convert_typed_number): Use
4945         value_from_host_double.
4946         (vlscm_convert_number): Likewise.
4947         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4948         * python/py-value.c (convert_value_from_python): Likewise.
4949
4950 2019-03-06  Tom Tromey  <tom@tromey.com>
4951
4952         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4953
4954 2019-03-06  Tom Tromey  <tom@tromey.com>
4955
4956         * utils.h (free_current_contents): Don't declare.
4957         * utils.c (free_current_contents): Remove.
4958
4959 2019-03-06  Tom Tromey  <tom@tromey.com>
4960
4961         * top.c (quit_force): Update.
4962         * main.c (captured_command_loop): Update.
4963         * common/new-op.c (operator new): Update.
4964         * common/common-exceptions.c (struct catcher)
4965         <save_cleanup_chain>: Remove member.
4966         (exceptions_state_mc_init): Update.
4967         (exception_try_scope_entry): Return nullptr.
4968         (exception_try_scope_exit, exception_rethrow)
4969         (throw_exception_sjlj, throw_exception_cxx): Update.
4970         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4971         (all_cleanups, do_cleanups, discard_cleanups)
4972         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4973         (restore_cleanups, restore_final_cleanups): Don't declare.
4974         (do_final_cleanups): Remove parameter.
4975         * common/cleanups.c (cleanup_chain, make_cleanup)
4976         (make_cleanup_dtor, all_cleanups, do_cleanups)
4977         (discard_my_cleanups, discard_cleanups)
4978         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4979         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4980         (null_cleanup): Remove.
4981         (do_final_cleanups): Remove parameter.
4982
4983 2019-03-06  Tom Tromey  <tom@tromey.com>
4984
4985         * remote.c (remote_target::remote_parse_stop_reply): Use
4986         unique_xmalloc_ptr.
4987
4988 2019-03-06  Tom Tromey  <tom@tromey.com>
4989
4990         * stabsread.c (struct stabs_field_info): Rename from field_info.
4991         <list, fnlist>: Add initializers.
4992         <obstack>: New member.
4993         (read_member_functions, read_struct_fields, read_baseclasses):
4994         Allocate on obstack.  Don't use cleanups.
4995         (read_one_struct_field, read_member_functions, read_struct_fields)
4996         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4997         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4998         (read_struct_type): Update.
4999
5000 2019-03-06  Tom Tromey  <tom@tromey.com>
5001
5002         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5003         * common/filestuff.h (make_cleanup_close): Don't declare.
5004         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5005         Remove.
5006
5007 2019-03-06  Tom Tromey  <tom@tromey.com>
5008
5009         * solib-aix.c: Use make_scope_exit.
5010
5011 2019-03-06  Tom Tromey  <tom@tromey.com>
5012
5013         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5014         Use make_scope_exit.
5015
5016 2019-03-06  Tom Tromey  <tom@tromey.com>
5017
5018         * solib-svr4.c (disable_probes_interface): Remove parameter.
5019         (svr4_handle_solib_event): Use make_scope_exit.
5020
5021 2019-03-06  Tom Tromey  <tom@tromey.com>
5022
5023         * remote.c (struct stop_reply_deleter): Remove.
5024         (stop_reply_up): Update.
5025         (struct stop_reply): Derive from notif_event.  Don't typedef.
5026         <regcache>: Now a std::vector.
5027         (stop_reply_xfree): Remove.
5028         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5029         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5030         (remote_target::discard_pending_stop_replies): Use delete.
5031         (remote_target::remote_parse_stop_reply): Update.
5032         (remote_target::process_stop_reply): Update.
5033         * remote-notif.h (struct notif_event): Add virtual destructor.
5034         Remove "dtr" member.
5035         (struct notif_client) <alloc_event>: Return a unique_ptr.
5036         (notif_event_xfree): Don't declare.
5037         (notif_event_up): New typedef.
5038         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5039         (notif_event_xfree, do_notif_event_xfree): Remove.
5040         (remote_notif_state_xfree): Update.
5041
5042 2019-03-06  Tom Tromey  <tom@tromey.com>
5043
5044         * infrun.c (displaced_step_clear_cleanup): Now a
5045         forward_scope_exit type.
5046         (displaced_step_prepare_throw): Update.
5047         (displaced_step_fixup): Update.
5048
5049 2019-03-06  Tom Tromey  <tom@tromey.com>
5050
5051         * inferior.h (class inferior): Update comment.
5052         * gdbthread.h (class thread_info): Update comment.
5053
5054 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5055             Tom Tromey  <tom@tromey.com>
5056
5057         * stabsread.h (struct stab_section_list): Remove.
5058         (coffstab_build_psymtabs): Update.
5059         * dbxread.c (symbuf_sections): Now a std::vector.
5060         (sect_idx): New global.
5061         (fill_symbuf): Update.
5062         (coffstab_build_psymtabs): Change type of stabsects parameter.
5063         Update.
5064         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5065         std::vector.
5066         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5067         (coff_locate_sections): Update.
5068         (coff_symfile_read): Remove cleanups.  Update.
5069         (init_stringtab): Add storage parameter.
5070         (free_stringtab, free_stringtab_cleanup): Remove.
5071         (init_lineno): Add storage parameter.
5072         (free_linetab, free_linetab_cleanup): Remove.
5073
5074 2019-03-06  Pedro Alves  <palves@redhat.com>
5075
5076         * linux-fork.c (fork_info::clobber_regs): Delete.
5077         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5078         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5079         comment.  Adjust.
5080         (scoped_switch_fork_info::scoped_switch_fork_info)
5081         (checkpoint_command, linux_fork_context): Adjust
5082         fork_save_infrun_state calls.
5083
5084 2019-03-06  Pedro Alves  <palves@redhat.com>
5085
5086         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5087         (inf_has_multiple_threads): Return 'bool' and rewrite using
5088         inferior_info::threads().
5089
5090 2019-03-06  Pedro Alves  <palves@redhat.com>
5091
5092         * linux-fork.c: Include <list>.
5093         (fork_list): Now a std::list instance.
5094         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5095         (forks_exist_p, find_last_fork): Adjust.
5096         (new_fork): Delete.
5097         (one_fork_p): New.
5098         (add_fork): Adjust.
5099         (free_fork): Delete, folded into fork_info::~fork_info().
5100         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5101         Adjust.
5102         (init_fork_list): Delete.
5103         (linux_fork_killall, linux_fork_mourn_inferior)
5104         (linux_fork_detach, info_checkpoints_command): Adjust.
5105         (_initialize_linux_fork): No longer call init_fork_list.
5106
5107 2019-03-06  Pedro Alves  <palves@redhat.com>
5108
5109         * linux-fork.c (new_fork): New, split out of ...
5110         (add_fork): ... this.  Return void.  Move "first fork" special
5111         case from here, to ...
5112         (checkpoint_command): ... here.
5113         * linux-linux.h (add_fork): Return void.
5114
5115 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5116
5117         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5118
5119 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5120             Chris January  <chris.january@arm.com>
5121             David Lecomber  <david.lecomber@arm.com>
5122
5123         * f-exp.y: New token, UNOP_INTRINSIC.
5124         (exp): New pattern using UNOP_INTRINSIC token.
5125         (f77_keywords): Add 'abs' keyword.
5126         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5127         (value_from_host_double): New function.
5128         (evaluate_subexp_f): Support UNOP_ABS.
5129
5130 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5131
5132         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5133         types.
5134
5135 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5136
5137         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5138         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5139         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5140
5141 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5142
5143         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5144
5145 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5146             Chris January  <chris.january@arm.com>
5147
5148         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5149         * f-exp.y: Define 'KIND' token.
5150         (exp): New pattern for KIND expressions.
5151         (ptype): Handle types with a kind extension.
5152         (direct_abs_decl): Extend to spot kind extensions.
5153         (f77_keywords): Add 'kind' to the list.
5154         (push_kind_type): New function.
5155         (convert_to_kind_type): New function.
5156         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5157         * parse.c (operator_length_standard): Likewise.
5158         * parser-defs.h (enum type_pieces): Add tp_kind.
5159         * std-operator.def: Add UNOP_KIND.
5160
5161 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5162
5163         * f-exp.y (f_parse): Set yydebug.
5164
5165 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5166
5167         * f-lang.c (evaluate_subexp_f): New function.
5168         (exp_descriptor_f): New global.
5169         (f_language_defn): Use exp_descriptor_f instead of
5170         exp_descriptor_standard.
5171
5172 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5173
5174         * f-exp.y (struct token): Add comments.
5175         (dot_ops): Remove uppercase versions and the end marker.
5176         (f77_keywords): Likewise.
5177         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5178         entries in the dot_ops array are case insensitive, and use
5179         strncasecmp to compare strings.  Also some whitespace cleanup in
5180         this area.  Similar for the f77_keywords array, except entries in
5181         this list might be case sensitive.
5182
5183 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5184
5185         * f-exp.y (struct f77_boolean_val): Add comments.
5186         (boolean_values): Remove uppercase versions, and end marker.
5187         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5188         and use strncasecmp to achieve case insensitivity.  Additionally,
5189         perform whitespace cleanup around this code.
5190
5191 2019-03-06  Tom Tromey  <tromey@adacore.com>
5192
5193         * remote-sim.c (gdbsim_target_open): Use result of
5194         gdb_argv::release.
5195
5196 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5197         Dirk Schubert  <dirk.schubert@arm.com>
5198         Chris January  <chris.january@arm.com>
5199
5200         * eval.c (evaluate_subexp_standard): Call Fortran argument
5201         wrapping logic.
5202         * f-lang.c (struct value): A value which can be passed into a
5203         Fortran function call.
5204         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5205         where appropriate.
5206         (struct type): Value ready for a Fortran function call.
5207         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5208         is needed.
5209         * f-lang.h (fortran_argument_convert): Declaration.
5210         (fortran_preserve_arg_pointer): Declaration.
5211         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5212
5213 2019-03-05  Tom Tromey  <tromey@adacore.com>
5214
5215         * python/py-prettyprint.c (print_string_repr): Remove #if.
5216         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5217
5218 2019-03-05  Tom Tromey  <tromey@adacore.com>
5219
5220         * target.c (the_dummy_target): Move later.  Change type to
5221         "dummy_target".
5222         (initialize_targets): Don't initialize the_dummy_target.
5223
5224 2019-03-05  Tom Tromey  <tromey@adacore.com>
5225
5226         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5227         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5228
5229 2019-03-05  Tom Tromey  <tromey@adacore.com>
5230
5231         * windows-nat.c (windows_nat_target::attach)
5232         (windows_nat_target::detach): Don't call gdb_flush.
5233         * valprint.c (generic_val_print, val_print, val_print_string):
5234         Don't call gdb_flush.
5235         * utils.c (defaulted_query): Don't call gdb_flush.
5236         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5237         * target.c (target_announce_detach): Don't call gdb_flush.
5238         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5239         * remote.c (extended_remote_target::attach): Don't call
5240         gdb_flush.
5241         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5242         * printcmd.c (do_examine): Don't call gdb_flush.
5243         (info_display_command): Don't call gdb_flush.
5244         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5245         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5246         * memattr.c (info_mem_command): Don't call gdb_flush.
5247         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5248         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5249         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5250         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5251         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5252         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5253         (gnu_nat_target::detach): Don't call gdb_flush.
5254         * f-valprint.c (f_val_print): Don't call gdb_flush.
5255         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5256         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5257         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5258         gdb_flush.
5259         * c-valprint.c (c_val_print): Don't call gdb_flush.
5260         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5261
5262 2019-03-05  Tom Tromey  <tromey@adacore.com>
5263
5264         * varobj.c (update_dynamic_varobj_children): Update.
5265         (install_default_visualizer): Use reset, not release.
5266         * value.c (set_internalvar): Update.
5267         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5268         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5269         ATTRIBUTE_UNUSED_RESULT.
5270
5271 2019-03-05  Tom Tromey  <tromey@adacore.com>
5272
5273         * remote.c (class scoped_remote_fd) <release>: Add
5274         ATTRIBUTE_UNUSED_RESULT.
5275
5276 2019-03-05  Tom Tromey  <tromey@adacore.com>
5277
5278         * macroexp.c (struct macro_buffer) <release>: Add
5279         ATTRIBUTE_UNUSED_RESULT.
5280
5281 2019-03-05  Tom Tromey  <tromey@adacore.com>
5282
5283         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5284         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5285         ATTRIBUTE_UNUSED_RESULT.
5286
5287 2019-03-05  Tom Tromey  <tromey@adacore.com>
5288
5289         * common/scoped_fd.h (class scoped_fd) <release>: Add
5290         ATTRIBUTE_UNUSED_RESULT.
5291
5292 2019-03-05  Tom Tromey  <tromey@adacore.com>
5293
5294         * parser-defs.h (struct parser_state) <release>: Add
5295         ATTRIBUTE_UNUSED_RESULT.
5296
5297 2019-03-05  Tom Tromey  <tromey@adacore.com>
5298
5299         * utils.h (class gdb_argv) <release>: Add
5300         ATTRIBUTE_UNUSED_RESULT.
5301         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5302
5303 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5304
5305         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5306         for-loop range, to avoid compiler warnings.
5307
5308         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5309         avoid compiler warnings about unused variables.
5310
5311         * NEWS: Mention end of support for native debugging on MS-Windows
5312         before XP.
5313
5314         PR gdb/24292
5315         * common/netstuff.c:
5316         * gdbserver/gdbreplay.c
5317         * gdbserver/remote-utils.c:
5318         * ser-tcp.c:
5319         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5320         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5321         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5322         'getaddrinfo' and 'freeaddrinfo' were not available before
5323         Windows XP, and mingw.org's MinGW headers by default define
5324         _WIN32_WINNT to 0x500.
5325
5326 2019-03-01  Gary Benson <gbenson@redhat.com>
5327
5328         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5329
5330 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5331             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5332
5333         PR gdb/8527
5334         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5335         set_sigint_trap, clear_sigint_trap.
5336
5337 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5338
5339         * target.c (target_detach): Clear the regcache and the
5340         frame cache.
5341
5342 2019-02-27  Pedro Alves  <palves@redhat.com>
5343
5344         * utils.c (set_screen_size): When we cap the height/width sizes,
5345         tweak the corresponding command variable to show "unlimited":
5346
5347 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5348             Pedro Alves  <palves@redhat.com>
5349
5350         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5351         before calling rl_set_screen_size.
5352
5353 2019-02-27  Tom Tromey  <tromey@adacore.com>
5354
5355         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5356         define.
5357         * python/py-value.c: Remove Python 2.4 workaround.
5358         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5359         workaround.
5360         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5361         Python 2.4 workaround.
5362         * python/python-internal.h: Remove Python 2.4 comment.
5363         (Py_ssize_t): Don't define.
5364         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5365         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5366         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5367         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5368         * python/python.c (do_start_initialization): Remove Python 2.4
5369         workaround.
5370         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5371         (print_children): Remove Python 2.4 workaround.
5372         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5373         workaround.
5374         (CHARBUFFERPROC_NAME): Remove.
5375         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5376         Python 2.4 workaround.
5377
5378 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5379
5380         * NEWS: Note minimum Python version.
5381
5382 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5383
5384         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5385         code from these functions.  Remove corresponding ifdefs.  Use
5386         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5387         Remove gotos and target of gotos.
5388         (infpy_search_memory): Likewise.
5389
5390 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5391
5392         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5393         (hppa_gdbarch_init): Don't register deleted functions with
5394         gdbarch.
5395
5396 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5397
5398         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5399         (h8300_unwind_sp): Delete.
5400         (h8300_dummy_id): Delete.
5401         (h8300_gdbarch_init): Don't register deleted functions with
5402         gdbarch.
5403
5404 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5405
5406         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5407         (ft32_unwind_pc): Delete.
5408         (ft32_unwind_sp): Delete.
5409         (ft32_gdbarch_init): Don't register deleted functions with
5410         gdbarch.
5411
5412 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5413
5414         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5415         (frv_unwind_pc): Delete.
5416         (frv_unwind_sp): Delete.
5417         (frv_gdbarch_init): Don't register deleted functions with
5418         gdbarch.
5419
5420 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5421
5422         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5423         (riscv_unwind_pc): Delete.
5424         (riscv_unwind_sp): Delete.
5425         (riscv_gdbarch_init): Don't register deleted functions with
5426         gdbarch.
5427
5428 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5429
5430         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5431         (csky_unwind_pc): Delete.
5432         (csky_unwind_sp): Delete.
5433         (csky_gdbarch_init): Don't register deleted functions with
5434         gdbarch.
5435
5436 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5437
5438         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5439         (cris_unwind_pc): Delete.
5440         (cris_unwind_sp): Delete.
5441         (cris_gdbarch_init): Don't register deleted functions with
5442         gdbarch.
5443
5444 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5445
5446         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5447         (bfin_unwind_pc): Delete.
5448         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5449
5450 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5451
5452         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5453         (arm_unwind_pc): Delete.
5454         (arm_unwind_sp): Delete.
5455         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5456
5457 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5458
5459         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5460         (arc_unwind_pc): Delete.
5461         (arc_unwind_sp): Delete.
5462         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5463
5464 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5465
5466         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5467         (alpha_unwind_pc): Delete.
5468         (alpha_gdbarch_init): Don't register deleted functions with
5469         gdbarch.
5470
5471 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5472
5473         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5474         (aarch64_unwind_pc): Delete.
5475         (aarch64_unwind_sp): Delete.
5476         (aarch64_gdbarch_init): Don't register deleted functions with
5477         gdbarch.
5478
5479 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5480
5481         * gdbtypes.c (type_align): Don't consider static members when
5482         computing structure alignment.
5483
5484 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5485
5486         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5487         return 0 for other types.
5488         * arch-utils.c (default_type_align): Always return 0.
5489         * gdbarch.h: Regenerate.
5490         * gdbarch.sh (type_align): Extend comment.
5491         * gdbtypes.c (type_align): Add additional comments, always call
5492         gdbarch_type_align before applying the default rules.
5493         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5494         generic code will then apply a suitable default.
5495         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5496         types, return 0 for other types.
5497
5498 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5499
5500         * NEWS: Create a new section for the next release branch.
5501         Rename the section of the current branch, now that it has
5502         been cut.
5503
5504 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5505
5506         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5507         * version.in: Bump version to 8.3.50.DATE-git.
5508
5509 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5510
5511         * aix-thread.c (ptid_cmp): Remove unused variable.
5512         (get_signaled_thread): Likewise.
5513         (store_regs_user_thread): Likewise.
5514         (store_regs_kernel_thread): Likewise.
5515         (fetch_regs_kernel_thread): Remove shadowed variable.
5516
5517 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5518
5519         * features/riscv/32bit-cpu.xml: Add register numbers.
5520         * features/riscv/32bit-fpu.c: Regenerate.
5521         * features/riscv/32bit-fpu.xml: Add register numbers.
5522         * features/riscv/64bit-cpu.xml: Add register numbers.
5523         * features/riscv/64bit-fpu.c: Regenerate.
5524         * features/riscv/64bit-fpu.xml: Add register numbers.
5525
5526 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5527
5528         * NEWS: Mention two argument form of gdb.Value constructor.
5529         * python/py-value.c (convert_buffer_and_type_to_value): New
5530         function.
5531         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5532         Add support for handling an optional second argument.  Call
5533         convert_buffer_and_type_to_value as appropriate.
5534         * python/python-internal.h (Py_buffer_deleter): New struct.
5535         (Py_buffer_up): New typedef.
5536
5537 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5538
5539         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5540         instead of releasing ownership.
5541
5542 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5543
5544         * dwarf2read.c (open_and_init_dwp_file): Call
5545         elf_numsections instead of bfd_count_sections to initialize
5546         dwp_file->num_sections.
5547
5548 2019-02-25  Tom Tromey  <tromey@adacore.com>
5549
5550         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5551
5552 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5553
5554         * gcore.in: Add '--readnever' option when invoking GDB.
5555
5556 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5557
5558         * MAINTAINERS: Update my email address.
5559
5560 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5561
5562         * build-id.c (build_id_to_debug_bfd_1): New function.
5563         (build_id_to_debug_bfd): Look for separate debug file in
5564         sysroot.
5565
5566 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5567
5568         * gdbarch.sh: Update the copyright year range that is placed into
5569         generated files.
5570
5571 2019-02-22  Keith Seitz  <keiths@redhat.com>
5572
5573         PR symtab/23853
5574         * linespec.c (create_sals_line_offset): Search for the default
5575         symtab's filename instead of its fullname.
5576
5577 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5578
5579         * NEWS: Update style defaults.
5580
5581 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5582
5583         * main.c (captured_main_1): Disable styling in batch mode.
5584
5585 2019-02-20  Tom Tromey  <tom@tromey.com>
5586
5587         * symtab.c (symtab_symbol_info): Fix typos.
5588
5589 2019-02-20  Tom Tromey  <tromey@adacore.com>
5590
5591         * findcmd.c (_initialize_mem_search): Use upper case for
5592         metasyntactic variables.
5593
5594 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5595
5596         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5597         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5598
5599 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5600
5601         * top.h (source_file_name): Change to std::string.
5602         * top.c (source_file_name): Likewise.
5603         (command_line_input): Adjust.
5604         * cli/cli-script.c (script_from_file): Adjust.
5605
5606 2019-02-19  Tom Tromey  <tromey@adacore.com>
5607
5608         * ravenscar-thread.c
5609         (ravenscar_thread_target::update_thread_list): Don't call
5610         ada_build_task_list.
5611         * ada-lang.h (ada_build_task_list): Don't declare.
5612         * ada-tasks.c (struct ada_tasks_inferior_data)
5613         <task_list_valid_p>: Now bool.
5614         (read_known_tasks, ada_task_list_changed)
5615         (ada_tasks_invalidate_inferior_data): Update.
5616         (read_known_tasks_array): Return bool.
5617         (read_known_tasks_list): Likewise.
5618         (read_known_tasks): Return void.
5619         (ada_build_task_list): Now static.
5620
5621 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5622
5623         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5624         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5625
5626 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5627
5628         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5629         variant for ada_tasks_pspace_data_handle and
5630         ada_tasks_inferior_data_handle.
5631         (ada_tasks_pspace_data_cleanup): New function.
5632         (ada_tasks_inferior_data_cleanup): New function.
5633
5634 2019-02-17  Tom Tromey  <tom@tromey.com>
5635
5636         * macrotab.h (macro_source_fullname): Return a std::string.
5637         * macrotab.c (macro_include, check_for_redefinition)
5638         (macro_undef, macro_lookup_definition, foreach_macro)
5639         (foreach_macro_in_scope): Update.
5640         (macro_source_fullname): Return a std::string.
5641         * macrocmd.c (show_pp_source_pos): Update.
5642
5643 2019-02-17  Tom Tromey  <tom@tromey.com>
5644
5645         * macrocmd.c (show_pp_source_pos): Style the file names.
5646
5647 2019-02-17  Tom Tromey  <tom@tromey.com>
5648
5649         PR tui/24197:
5650         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5651
5652 2019-02-17  Tom Tromey  <tom@tromey.com>
5653
5654         * ada-lang.c (user_select_syms): Use filtered printing.
5655         * utils.c (wrap_style): New global.
5656         (desired_style): Remove.
5657         (emit_style_escape): Add stream parameter.
5658         (set_output_style, reset_terminal_style, prompt_for_continue):
5659         Update.
5660         (flush_wrap_buffer): Only flush gdb_stdout.
5661         (wrap_here): Set wrap_style.
5662         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5663         treat escape sequences as a character.  Change when wrap buffer is
5664         flushed.
5665         (fputs_styled): Do not set the output style when the default is
5666         requested.
5667         * ui-style.h (struct ui_file_style) <is_default>: New method.
5668         * source.c (print_source_lines_base): Emit escape sequences in one
5669         piece.
5670
5671 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5672
5673         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5674         integers and enumeration types.
5675
5676 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5677
5678         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5679         instead of lookup_symbol_in_language
5680         (do_exact_match): New function.
5681         (ada_get_symbol_name_matcher): Return do_exact_match when
5682         doing a verbatim match.
5683
5684 2019-02-15  Tom Tromey  <tromey@adacore.com>
5685
5686         * ravenscar-thread.c (ravenscar_thread_target::resume)
5687         (ravenscar_thread_target::wait): Special case wildcard requests.
5688
5689 2019-02-15  Tom Tromey  <tromey@adacore.com>
5690
5691         * ravenscar-thread.c (base_ptid): Remove.
5692         (struct ravenscar_thread_target) <close>: New method.
5693         <m_base_ptid>: New member.
5694         <update_inferior_ptid, active_task, task_is_currently_active,
5695         runtime_initialized>: Declare methods.
5696         <ravenscar_thread_target>: Add constructor.
5697         (ravenscar_thread_target::task_is_currently_active)
5698         (ravenscar_thread_target::update_inferior_ptid)
5699         (ravenscar_runtime_initialized): Rename.  Now methods.
5700         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5701         (ravenscar_thread_target::update_thread_list): Update.
5702         (ravenscar_thread_target::active_task): Now method.
5703         (ravenscar_thread_target::store_registers)
5704         (ravenscar_thread_target::prepare_to_store)
5705         (ravenscar_thread_target::prepare_to_store)
5706         (ravenscar_thread_target::mourn_inferior): Update.
5707         (ravenscar_inferior_created): Use "new" to create target.
5708         (ravenscar_thread_target::get_ada_task_ptid): Update.
5709         (_initialize_ravenscar): Don't initialize base_ptid.
5710         (ravenscar_ops): Remove global.
5711
5712 2019-02-15  Tom Tromey  <tromey@adacore.com>
5713
5714         * target.h (push_target): Declare new overload.
5715         * target.c (push_target): New overload, taking an rvalue reference.
5716         * remote.c (remote_target::open_1): Use push_target overload.
5717         * corelow.c (core_target_open): Use push_target overload.
5718
5719 2019-02-15  Tom Tromey  <tromey@adacore.com>
5720
5721         * ravenscar-thread.c (is_ravenscar_task)
5722         (ravenscar_task_is_currently_active): Return bool.
5723         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5724         (_initialize_ravenscar): Remove "(void)".
5725         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5726         Return bool.
5727
5728 2019-02-15  Tom Tromey  <tromey@adacore.com>
5729
5730         * ravenscar-thread.c (ravenscar_runtime_initializer)
5731         (has_ravenscar_runtime, get_running_thread_id)
5732         (ravenscar_thread_target::resume): Fix indentation.
5733
5734 2019-02-15  Tom Tromey  <tromey@adacore.com>
5735
5736         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5737         from ravenscar_arch_ops.
5738         (sparc_ravenscar_ops::fetch_registers)
5739         (sparc_ravenscar_ops::store_registers): Now methods.
5740         (sparc_ravenscar_prepare_to_store): Remove.
5741         (sparc_ravenscar_ops): Redefine.
5742         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5743         methods and destructor.  Remove members.
5744         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5745         (ravenscar_thread_target::store_registers)
5746         (ravenscar_thread_target::prepare_to_store): Update.
5747         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5748         Remove.
5749         (struct ppc_ravenscar_powerpc_ops): Derive from
5750         ravenscar_arch_ops.
5751         (ppc_ravenscar_powerpc_ops::fetch_registers)
5752         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5753         (ppc_ravenscar_powerpc_ops): Redefine.
5754         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5755         (ppc_ravenscar_e500_ops::fetch_registers)
5756         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5757         (ppc_ravenscar_e500_ops): Redefine.
5758         * aarch64-ravenscar-thread.c
5759         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5760         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5761         (aarch64_ravenscar_fetch_registers)
5762         (aarch64_ravenscar_store_registers): Now methods.
5763         (aarch64_ravenscar_ops): Redefine.
5764
5765 2019-02-15  Tom Tromey  <tromey@adacore.com>
5766
5767         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5768         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5769         (ravenscar_thread_target::stopped_by_watchpoint)
5770         (ravenscar_thread_target::stopped_data_address)
5771         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5772
5773 2019-02-15  Tom Tromey  <tromey@adacore.com>
5774
5775         * ravenscar-thread.c: Fix some typos.
5776
5777 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5778             Tom Tromey  <tromey@adacore.com>
5779
5780         * ada-lang.c (ada_exception_sal): Change addr_string to a
5781         std::string.
5782         (create_ada_exception_catchpoint): Update.
5783
5784 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5785             Tom Tromey  <tromey@adacore.com>
5786
5787         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5788         (bp_location_ops): Remove.
5789         (base_breakpoint_allocate_location): Update.
5790         (free_bp_location): Update.
5791         * ada-lang.c (class ada_catchpoint_location)
5792         <ada_catchpoint_location>: Remove ops parameter.
5793         (ada_catchpoint_location_dtor): Remove.
5794         (ada_catchpoint_location_ops): Remove.
5795         (allocate_location_exception): Update.
5796         * breakpoint.h (struct bp_location_ops): Remove.
5797         (class bp_location) <bp_location>: Remove bp_location_ops
5798         parameter.
5799         <~bp_location>: Add destructor.
5800         <ops>: Remove.
5801
5802 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5803             Pedro Alves  <palves@redhat.com>
5804
5805         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5806         'PATH_MAX'.
5807
5808 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5809             Samuel Thibault  <samuel.thibault@gnu.org>
5810             Thomas Schwinge  <thomas@codesourcery.com>
5811
5812         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5813         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5814
5815 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5816
5817         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5818         (check_empty): Use "const char *".
5819
5820         * gnu-nat.c (gnu_nat_target::detach): Instead of
5821         'detach_inferior (pid)' call
5822         'detach_inferior (find_inferior_pid (pid))'.
5823
5824         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5825         'nat/fork-inferior.o'.
5826         * gnu-nat.c: #include "nat/fork-inferior.h".
5827
5828         * gnu-nat.c (gnu_nat_target::detach): Instead of
5829         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5830         * gnu-nat.h: #include "inf-child.h".
5831         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5832         'i386_gnu_nat_target::fetch_registers'.
5833         (gnu_store_registers): Rename/move to
5834         'i386_gnu_nat_target::store_registers'.
5835
5836         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5837         * gnu-nat.h (mach_thread_info): New function.
5838         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5839
5840         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5841
5842 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5843
5844         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5845
5846 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5847
5848         * windows-nat.c (windows_add_thread): Add new parameter
5849         "main_thread_p" with default value set to false.  Update
5850         function documentation as well as all callers.
5851         (windows_delete_thread): Likewise.
5852         (fake_create_process): Update call to windows_add_thread.
5853         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5854         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5855         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5856         call to windows_delete_thread.
5857
5858 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5859
5860         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5861
5862 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5863
5864         * symfile.c (find_separate_debug_file): Use canonical path of
5865         sysroot with child_path instead of gdb_sysroot if it is valid.
5866
5867 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5868
5869         * symfile.c (find_separate_debug_file): Use child_path to
5870         determine if an object file is under a sysroot.
5871
5872 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5873
5874         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5875         unittests/child-path-selftests.c.
5876         * common/pathstuff.c (child_path): New function.
5877         * common/pathstuff.h (child_path): New prototype.
5878         * unittests/child-path-selftests.c: New file.
5879
5880 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5881
5882         * symfile.c (find_separate_debug_file): Look for separate debug
5883         files in debug directories under the sysroot.
5884
5885 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5886
5887         * symtab.h (struct minimal_symbol data_p): New const method.
5888         (struct minimal_symbol text_p): Likewise.
5889         * symtab.c (output_source_filename): Use file name style
5890         to print file name.
5891         (print_symbol_info): Likewise.
5892         (print_msymbol_info): Use address style to print addresses.
5893         Use function name style to print executable text symbols.
5894         (expand_symtab_containing_pc): Use data_p.
5895         (find_pc_sect_compunit_symtab): Likewise.
5896
5897 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5898
5899         * breakpoint.c (describe_other_breakpoints): Use address style
5900         to print addresses.
5901         (say_where): Likewise.
5902
5903 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5904
5905         * ada-typeprint.c (print_func_type): Print function name
5906         style to print function name.
5907         * c-typeprint.c (c_print_type_1): Likewise.
5908
5909 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5910
5911         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5912         for execve.
5913
5914 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5915
5916         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5917         type_stack.
5918
5919 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5920
5921         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5922         TYPE_CODE_REF types.
5923
5924 2019-02-08  Jim Wilson  <jimw@sifive.com>
5925
5926         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5927         (riscv_linux_fregset): New.
5928         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5929
5930 2019-02-07  Tom Tromey  <tom@tromey.com>
5931
5932         * thread.c (thread_cancel_execution_command): Update.
5933         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5934         methods.
5935         (struct thread_fsm_ops): Remove.
5936         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5937         (thread_fsm_should_stop, thread_fsm_return_value)
5938         (thread_fsm_set_finished, thread_fsm_finished_p)
5939         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5940         Don't declare.
5941         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5942         * infrun.c (clear_proceed_status_thread)
5943         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5944         (print_stop_event): Update.
5945         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5946         Add constructor.
5947         (step_command_fsm_ops): Remove.
5948         (new_step_command_fsm): Remove.
5949         (step_1): Update.
5950         (step_command_fsm::should_stop): Rename from
5951         step_command_fsm_should_stop.
5952         (step_command_fsm::clean_up): Rename from
5953         step_command_fsm_clean_up.
5954         (step_command_fsm::do_async_reply_reason): Rename from
5955         step_command_fsm_async_reply_reason.
5956         (struct until_next_fsm): Inherit from thread_fsm.  Add
5957         constructor.
5958         (until_next_fsm_ops): Remove.
5959         (new_until_next_fsm): Remove.
5960         (until_next_fsm::should_stop): Rename from
5961         until_next_fsm_should_stop.
5962         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5963         (until_next_fsm::do_async_reply_reason): Rename from
5964         until_next_fsm_async_reply_reason.
5965         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5966         constructor.  Change type of breakpoint.
5967         (finish_command_fsm_ops): Remove.
5968         (new_finish_command_fsm): Remove.
5969         (finish_command_fsm::should_stop): Rename from
5970         finish_command_fsm_should_stop.
5971         (finish_command_fsm::clean_up): Rename from
5972         finish_command_fsm_clean_up.
5973         (finish_command_fsm::return_value): Rename from
5974         finish_command_fsm_return_value.
5975         (finish_command_fsm::do_async_reply_reason): Rename from
5976         finish_command_fsm_async_reply_reason.
5977         (finish_command): Update.
5978         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5979         Add constructor.
5980         (call_thread_fsm_ops): Remove.
5981         (call_thread_fsm::call_thread_fsm): Rename from
5982         new_call_thread_fsm.
5983         (call_thread_fsm::should_stop): Rename from
5984         call_thread_fsm_should_stop.
5985         (call_thread_fsm::should_notify_stop): Rename from
5986         call_thread_fsm_should_notify_stop.
5987         (run_inferior_call, call_function_by_hand_dummy): Update.
5988         * cli/cli-interp.c (should_print_stop_to_console): Update.
5989         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5990         Add constructor.  Change type of location_breakpoint,
5991         caller_breakpoint.
5992         (until_break_fsm_ops): Remove.
5993         (new_until_break_fsm): Remove.
5994         (until_break_fsm::should_stop): Rename from
5995         until_break_fsm_should_stop.
5996         (until_break_fsm::clean_up): Rename from
5997         until_break_fsm_clean_up.
5998         (until_break_fsm::do_async_reply_reason): Rename from
5999         until_break_fsm_async_reply_reason.
6000         (until_break_command): Update.
6001         * thread-fsm.c: Remove.
6002         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6003
6004 2019-02-07  Tom Tromey  <tom@tromey.com>
6005
6006         * yy-remap.h: Add include guard.
6007         * xtensa-tdep.h: Add include guard.
6008         * xcoffread.h: Rename include guard.
6009         * varobj-iter.h: Add include guard.
6010         * tui/tui.h: Rename include guard.
6011         * tui/tui-winsource.h: Rename include guard.
6012         * tui/tui-wingeneral.h: Rename include guard.
6013         * tui/tui-windata.h: Rename include guard.
6014         * tui/tui-win.h: Rename include guard.
6015         * tui/tui-stack.h: Rename include guard.
6016         * tui/tui-source.h: Rename include guard.
6017         * tui/tui-regs.h: Rename include guard.
6018         * tui/tui-out.h: Rename include guard.
6019         * tui/tui-layout.h: Rename include guard.
6020         * tui/tui-io.h: Rename include guard.
6021         * tui/tui-hooks.h: Rename include guard.
6022         * tui/tui-file.h: Rename include guard.
6023         * tui/tui-disasm.h: Rename include guard.
6024         * tui/tui-data.h: Rename include guard.
6025         * tui/tui-command.h: Rename include guard.
6026         * tic6x-tdep.h: Add include guard.
6027         * target/waitstatus.h: Rename include guard.
6028         * target/wait.h: Rename include guard.
6029         * target/target.h: Rename include guard.
6030         * target/resume.h: Rename include guard.
6031         * target-float.h: Rename include guard.
6032         * stabsread.h: Add include guard.
6033         * rs6000-tdep.h: Add include guard.
6034         * riscv-fbsd-tdep.h: Add include guard.
6035         * regformats/regdef.h: Rename include guard.
6036         * record.h: Rename include guard.
6037         * python/python.h: Rename include guard.
6038         * python/python-internal.h: Rename include guard.
6039         * python/py-stopevent.h: Rename include guard.
6040         * python/py-ref.h: Rename include guard.
6041         * python/py-record.h: Rename include guard.
6042         * python/py-record-full.h: Rename include guard.
6043         * python/py-record-btrace.h: Rename include guard.
6044         * python/py-instruction.h: Rename include guard.
6045         * python/py-events.h: Rename include guard.
6046         * python/py-event.h: Rename include guard.
6047         * procfs.h: Add include guard.
6048         * proc-utils.h: Add include guard.
6049         * p-lang.h: Add include guard.
6050         * or1k-tdep.h: Rename include guard.
6051         * observable.h: Rename include guard.
6052         * nto-tdep.h: Rename include guard.
6053         * nat/x86-linux.h: Rename include guard.
6054         * nat/x86-linux-dregs.h: Rename include guard.
6055         * nat/x86-gcc-cpuid.h: Add include guard.
6056         * nat/x86-dregs.h: Rename include guard.
6057         * nat/x86-cpuid.h: Rename include guard.
6058         * nat/ppc-linux.h: Rename include guard.
6059         * nat/mips-linux-watch.h: Rename include guard.
6060         * nat/linux-waitpid.h: Rename include guard.
6061         * nat/linux-ptrace.h: Rename include guard.
6062         * nat/linux-procfs.h: Rename include guard.
6063         * nat/linux-osdata.h: Rename include guard.
6064         * nat/linux-nat.h: Rename include guard.
6065         * nat/linux-namespaces.h: Rename include guard.
6066         * nat/linux-btrace.h: Rename include guard.
6067         * nat/glibc_thread_db.h: Rename include guard.
6068         * nat/gdb_thread_db.h: Rename include guard.
6069         * nat/gdb_ptrace.h: Rename include guard.
6070         * nat/fork-inferior.h: Rename include guard.
6071         * nat/amd64-linux-siginfo.h: Rename include guard.
6072         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6073         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6074         * nat/aarch64-linux.h: Rename include guard.
6075         * nat/aarch64-linux-hw-point.h: Rename include guard.
6076         * mn10300-tdep.h: Add include guard.
6077         * mips-linux-tdep.h: Add include guard.
6078         * mi/mi-parse.h: Rename include guard.
6079         * mi/mi-out.h: Rename include guard.
6080         * mi/mi-main.h: Rename include guard.
6081         * mi/mi-interp.h: Rename include guard.
6082         * mi/mi-getopt.h: Rename include guard.
6083         * mi/mi-console.h: Rename include guard.
6084         * mi/mi-common.h: Rename include guard.
6085         * mi/mi-cmds.h: Rename include guard.
6086         * mi/mi-cmd-break.h: Rename include guard.
6087         * m2-lang.h: Add include guard.
6088         * location.h: Rename include guard.
6089         * linux-record.h: Rename include guard.
6090         * linux-nat.h: Add include guard.
6091         * linux-fork.h: Add include guard.
6092         * i386-darwin-tdep.h: Rename include guard.
6093         * hppa-linux-offsets.h: Add include guard.
6094         * guile/guile.h: Rename include guard.
6095         * guile/guile-internal.h: Rename include guard.
6096         * gnu-nat.h: Rename include guard.
6097         * gdb-stabs.h: Rename include guard.
6098         * frv-tdep.h: Add include guard.
6099         * f-lang.h: Add include guard.
6100         * event-loop.h: Add include guard.
6101         * darwin-nat.h: Rename include guard.
6102         * cp-abi.h: Rename include guard.
6103         * config/sparc/nm-sol2.h: Rename include guard.
6104         * config/nm-nto.h: Rename include guard.
6105         * config/nm-linux.h: Add include guard.
6106         * config/i386/nm-i386gnu.h: Rename include guard.
6107         * config/djgpp/nl_types.h: Rename include guard.
6108         * config/djgpp/langinfo.h: Rename include guard.
6109         * compile/gcc-cp-plugin.h: Add include guard.
6110         * compile/gcc-c-plugin.h: Add include guard.
6111         * compile/compile.h: Rename include guard.
6112         * compile/compile-object-run.h: Rename include guard.
6113         * compile/compile-object-load.h: Rename include guard.
6114         * compile/compile-internal.h: Rename include guard.
6115         * compile/compile-cplus.h: Rename include guard.
6116         * compile/compile-c.h: Rename include guard.
6117         * common/xml-utils.h: Rename include guard.
6118         * common/x86-xstate.h: Rename include guard.
6119         * common/version.h: Rename include guard.
6120         * common/vec.h: Rename include guard.
6121         * common/tdesc.h: Rename include guard.
6122         * common/selftest.h: Rename include guard.
6123         * common/scoped_restore.h: Rename include guard.
6124         * common/scoped_mmap.h: Rename include guard.
6125         * common/scoped_fd.h: Rename include guard.
6126         * common/safe-iterator.h: Rename include guard.
6127         * common/run-time-clock.h: Rename include guard.
6128         * common/refcounted-object.h: Rename include guard.
6129         * common/queue.h: Rename include guard.
6130         * common/ptid.h: Rename include guard.
6131         * common/print-utils.h: Rename include guard.
6132         * common/preprocessor.h: Rename include guard.
6133         * common/pathstuff.h: Rename include guard.
6134         * common/observable.h: Rename include guard.
6135         * common/netstuff.h: Rename include guard.
6136         * common/job-control.h: Rename include guard.
6137         * common/host-defs.h: Rename include guard.
6138         * common/gdb_wait.h: Rename include guard.
6139         * common/gdb_vecs.h: Rename include guard.
6140         * common/gdb_unlinker.h: Rename include guard.
6141         * common/gdb_unique_ptr.h: Rename include guard.
6142         * common/gdb_tilde_expand.h: Rename include guard.
6143         * common/gdb_sys_time.h: Rename include guard.
6144         * common/gdb_string_view.h: Rename include guard.
6145         * common/gdb_splay_tree.h: Rename include guard.
6146         * common/gdb_setjmp.h: Rename include guard.
6147         * common/gdb_ref_ptr.h: Rename include guard.
6148         * common/gdb_optional.h: Rename include guard.
6149         * common/gdb_locale.h: Rename include guard.
6150         * common/gdb_assert.h: Rename include guard.
6151         * common/filtered-iterator.h: Rename include guard.
6152         * common/filestuff.h: Rename include guard.
6153         * common/fileio.h: Rename include guard.
6154         * common/environ.h: Rename include guard.
6155         * common/common-utils.h: Rename include guard.
6156         * common/common-types.h: Rename include guard.
6157         * common/common-regcache.h: Rename include guard.
6158         * common/common-inferior.h: Rename include guard.
6159         * common/common-gdbthread.h: Rename include guard.
6160         * common/common-exceptions.h: Rename include guard.
6161         * common/common-defs.h: Rename include guard.
6162         * common/common-debug.h: Rename include guard.
6163         * common/cleanups.h: Rename include guard.
6164         * common/buffer.h: Rename include guard.
6165         * common/btrace-common.h: Rename include guard.
6166         * common/break-common.h: Rename include guard.
6167         * cli/cli-utils.h: Rename include guard.
6168         * cli/cli-style.h: Rename include guard.
6169         * cli/cli-setshow.h: Rename include guard.
6170         * cli/cli-script.h: Rename include guard.
6171         * cli/cli-interp.h: Rename include guard.
6172         * cli/cli-decode.h: Rename include guard.
6173         * cli/cli-cmds.h: Rename include guard.
6174         * charset-list.h: Add include guard.
6175         * buildsym-legacy.h: Rename include guard.
6176         * bfin-tdep.h: Add include guard.
6177         * ax.h: Rename include guard.
6178         * arm-linux-tdep.h: Add include guard.
6179         * arm-fbsd-tdep.h: Add include guard.
6180         * arch/xtensa.h: Rename include guard.
6181         * arch/tic6x.h: Add include guard.
6182         * arch/i386.h: Add include guard.
6183         * arch/arm.h: Rename include guard.
6184         * arch/arm-linux.h: Rename include guard.
6185         * arch/arm-get-next-pcs.h: Rename include guard.
6186         * arch/amd64.h: Add include guard.
6187         * arch/aarch64-insn.h: Rename include guard.
6188         * arch-utils.h: Rename include guard.
6189         * annotate.h: Add include guard.
6190         * amd64-darwin-tdep.h: Rename include guard.
6191         * aarch64-linux-tdep.h: Add include guard.
6192         * aarch64-fbsd-tdep.h: Add include guard.
6193         * aarch32-linux-nat.h: Add include guard.
6194
6195 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6196
6197         * macrotab.c (macro_define_internal): New function that
6198         factorizes macro_define_object_internal and macro_define_function
6199         code.
6200         (macro_define_object_internal): Use macro_define_internal.
6201         (macro_define_function): Likewise.
6202
6203 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6204
6205         * macrocmd.c (extract_identifier): Return
6206         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6207         callers.
6208
6209 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6210
6211         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6212
6213 2019-02-05  Tom Tromey  <tom@tromey.com>
6214
6215         * target.c (target_stack::unpush): Move assertion earlier.
6216
6217 2019-01-30  Tom Tromey  <tom@tromey.com>
6218
6219         PR python/23615:
6220         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6221         (gdbpy_parse_and_eval): Likewise.
6222         * python/python-internal.h (gdbpy_allow_threads): New class.
6223
6224 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6225
6226         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6227         (aarch64_fbsd_fpregmap): Move earlier.
6228         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6229         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6230         instead of individual calls to trad_frame_set_reg_addr.
6231         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6232         earlier.
6233         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6234         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6235         instead of individual calls to trad_frame_set_reg_addr.
6236
6237 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6238
6239         * CONTRIBUTE: Replace contribution list with wiki link.
6240
6241 2019-01-25  Tom Tromey  <tom@tromey.com>
6242
6243         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6244
6245 2019-01-25  Tom Tromey  <tom@tromey.com>
6246
6247         * xtensa-linux-nat.c: Fix common/ includes.
6248         * xml-support.h: Fix common/ includes.
6249         * xml-support.c: Fix common/ includes.
6250         * x86-linux-nat.c: Fix common/ includes.
6251         * windows-nat.c: Fix common/ includes.
6252         * varobj.h: Fix common/ includes.
6253         * varobj.c: Fix common/ includes.
6254         * value.c: Fix common/ includes.
6255         * valops.c: Fix common/ includes.
6256         * utils.c: Fix common/ includes.
6257         * unittests/xml-utils-selftests.c: Fix common/ includes.
6258         * unittests/utils-selftests.c: Fix common/ includes.
6259         * unittests/unpack-selftests.c: Fix common/ includes.
6260         * unittests/tracepoint-selftests.c: Fix common/ includes.
6261         * unittests/style-selftests.c: Fix common/ includes.
6262         * unittests/string_view-selftests.c: Fix common/ includes.
6263         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6264         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6265         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6266         * unittests/rsp-low-selftests.c: Fix common/ includes.
6267         * unittests/parse-connection-spec-selftests.c: Fix common/
6268         includes.
6269         * unittests/optional-selftests.c: Fix common/ includes.
6270         * unittests/offset-type-selftests.c: Fix common/ includes.
6271         * unittests/observable-selftests.c: Fix common/ includes.
6272         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6273         * unittests/memrange-selftests.c: Fix common/ includes.
6274         * unittests/memory-map-selftests.c: Fix common/ includes.
6275         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6276         * unittests/function-view-selftests.c: Fix common/ includes.
6277         * unittests/environ-selftests.c: Fix common/ includes.
6278         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6279         * unittests/common-utils-selftests.c: Fix common/ includes.
6280         * unittests/cli-utils-selftests.c: Fix common/ includes.
6281         * unittests/array-view-selftests.c: Fix common/ includes.
6282         * ui-file.c: Fix common/ includes.
6283         * tui/tui-io.c: Fix common/ includes.
6284         * tracepoint.h: Fix common/ includes.
6285         * tracepoint.c: Fix common/ includes.
6286         * tracefile-tfile.c: Fix common/ includes.
6287         * top.h: Fix common/ includes.
6288         * top.c: Fix common/ includes.
6289         * thread.c: Fix common/ includes.
6290         * target/waitstatus.h: Fix common/ includes.
6291         * target/waitstatus.c: Fix common/ includes.
6292         * target.h: Fix common/ includes.
6293         * target.c: Fix common/ includes.
6294         * target-memory.c: Fix common/ includes.
6295         * target-descriptions.c: Fix common/ includes.
6296         * symtab.h: Fix common/ includes.
6297         * symfile.c: Fix common/ includes.
6298         * stap-probe.c: Fix common/ includes.
6299         * spu-linux-nat.c: Fix common/ includes.
6300         * sparc-nat.c: Fix common/ includes.
6301         * source.c: Fix common/ includes.
6302         * solib.c: Fix common/ includes.
6303         * solib-target.c: Fix common/ includes.
6304         * ser-unix.c: Fix common/ includes.
6305         * ser-tcp.c: Fix common/ includes.
6306         * ser-pipe.c: Fix common/ includes.
6307         * ser-base.c: Fix common/ includes.
6308         * selftest-arch.c: Fix common/ includes.
6309         * s12z-tdep.c: Fix common/ includes.
6310         * rust-exp.y: Fix common/ includes.
6311         * rs6000-aix-tdep.c: Fix common/ includes.
6312         * riscv-tdep.c: Fix common/ includes.
6313         * remote.c: Fix common/ includes.
6314         * remote-notif.h: Fix common/ includes.
6315         * remote-fileio.h: Fix common/ includes.
6316         * remote-fileio.c: Fix common/ includes.
6317         * regcache.h: Fix common/ includes.
6318         * regcache.c: Fix common/ includes.
6319         * record-btrace.c: Fix common/ includes.
6320         * python/python.c: Fix common/ includes.
6321         * python/py-type.c: Fix common/ includes.
6322         * python/py-inferior.c: Fix common/ includes.
6323         * progspace.h: Fix common/ includes.
6324         * producer.c: Fix common/ includes.
6325         * procfs.c: Fix common/ includes.
6326         * proc-api.c: Fix common/ includes.
6327         * printcmd.c: Fix common/ includes.
6328         * ppc-linux-nat.c: Fix common/ includes.
6329         * parser-defs.h: Fix common/ includes.
6330         * osdata.c: Fix common/ includes.
6331         * obsd-nat.c: Fix common/ includes.
6332         * nat/x86-linux.c: Fix common/ includes.
6333         * nat/x86-linux-dregs.c: Fix common/ includes.
6334         * nat/x86-dregs.h: Fix common/ includes.
6335         * nat/x86-dregs.c: Fix common/ includes.
6336         * nat/ppc-linux.c: Fix common/ includes.
6337         * nat/mips-linux-watch.h: Fix common/ includes.
6338         * nat/mips-linux-watch.c: Fix common/ includes.
6339         * nat/linux-waitpid.c: Fix common/ includes.
6340         * nat/linux-ptrace.h: Fix common/ includes.
6341         * nat/linux-ptrace.c: Fix common/ includes.
6342         * nat/linux-procfs.c: Fix common/ includes.
6343         * nat/linux-personality.c: Fix common/ includes.
6344         * nat/linux-osdata.c: Fix common/ includes.
6345         * nat/linux-namespaces.c: Fix common/ includes.
6346         * nat/linux-btrace.h: Fix common/ includes.
6347         * nat/linux-btrace.c: Fix common/ includes.
6348         * nat/fork-inferior.c: Fix common/ includes.
6349         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6350         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6351         * nat/aarch64-linux.c: Fix common/ includes.
6352         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6353         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6354         * namespace.h: Fix common/ includes.
6355         * mips-linux-tdep.c: Fix common/ includes.
6356         * minsyms.c: Fix common/ includes.
6357         * mi/mi-parse.h: Fix common/ includes.
6358         * mi/mi-main.c: Fix common/ includes.
6359         * mi/mi-cmd-env.c: Fix common/ includes.
6360         * memrange.h: Fix common/ includes.
6361         * memattr.c: Fix common/ includes.
6362         * maint.h: Fix common/ includes.
6363         * maint.c: Fix common/ includes.
6364         * main.c: Fix common/ includes.
6365         * machoread.c: Fix common/ includes.
6366         * location.c: Fix common/ includes.
6367         * linux-thread-db.c: Fix common/ includes.
6368         * linux-nat.c: Fix common/ includes.
6369         * linux-fork.c: Fix common/ includes.
6370         * inline-frame.c: Fix common/ includes.
6371         * infrun.c: Fix common/ includes.
6372         * inflow.c: Fix common/ includes.
6373         * inferior.h: Fix common/ includes.
6374         * inferior.c: Fix common/ includes.
6375         * infcmd.c: Fix common/ includes.
6376         * inf-ptrace.c: Fix common/ includes.
6377         * inf-child.c: Fix common/ includes.
6378         * ia64-linux-nat.c: Fix common/ includes.
6379         * i387-tdep.c: Fix common/ includes.
6380         * i386-tdep.c: Fix common/ includes.
6381         * i386-linux-tdep.c: Fix common/ includes.
6382         * i386-linux-nat.c: Fix common/ includes.
6383         * i386-go32-tdep.c: Fix common/ includes.
6384         * i386-fbsd-tdep.c: Fix common/ includes.
6385         * i386-fbsd-nat.c: Fix common/ includes.
6386         * guile/scm-type.c: Fix common/ includes.
6387         * guile/guile.c: Fix common/ includes.
6388         * go32-nat.c: Fix common/ includes.
6389         * gnu-nat.c: Fix common/ includes.
6390         * gdbthread.h: Fix common/ includes.
6391         * gdbarch-selftests.c: Fix common/ includes.
6392         * gdb_usleep.c: Fix common/ includes.
6393         * gdb_select.h: Fix common/ includes.
6394         * gdb_bfd.c: Fix common/ includes.
6395         * gcore.c: Fix common/ includes.
6396         * fork-child.c: Fix common/ includes.
6397         * findvar.c: Fix common/ includes.
6398         * fbsd-nat.c: Fix common/ includes.
6399         * event-top.c: Fix common/ includes.
6400         * event-loop.c: Fix common/ includes.
6401         * dwarf2read.c: Fix common/ includes.
6402         * dwarf2loc.c: Fix common/ includes.
6403         * dwarf2-frame.c: Fix common/ includes.
6404         * dwarf-index-cache.c: Fix common/ includes.
6405         * dtrace-probe.c: Fix common/ includes.
6406         * disasm-selftests.c: Fix common/ includes.
6407         * defs.h: Fix common/ includes.
6408         * csky-tdep.c: Fix common/ includes.
6409         * cp-valprint.c: Fix common/ includes.
6410         * cp-support.h: Fix common/ includes.
6411         * cp-support.c: Fix common/ includes.
6412         * corelow.c: Fix common/ includes.
6413         * completer.h: Fix common/ includes.
6414         * completer.c: Fix common/ includes.
6415         * compile/compile.c: Fix common/ includes.
6416         * compile/compile-loc2c.c: Fix common/ includes.
6417         * compile/compile-cplus-types.c: Fix common/ includes.
6418         * compile/compile-cplus-symbols.c: Fix common/ includes.
6419         * command.h: Fix common/ includes.
6420         * cli/cli-dump.c: Fix common/ includes.
6421         * cli/cli-cmds.c: Fix common/ includes.
6422         * charset.c: Fix common/ includes.
6423         * build-id.c: Fix common/ includes.
6424         * btrace.h: Fix common/ includes.
6425         * btrace.c: Fix common/ includes.
6426         * breakpoint.h: Fix common/ includes.
6427         * breakpoint.c: Fix common/ includes.
6428         * ax.h:
6429         (enum agent_op): Fix common/ includes.
6430         * ax-general.c (struct aop_map): Fix common/ includes.
6431         * ax-gdb.c: Fix common/ includes.
6432         * auxv.c: Fix common/ includes.
6433         * auto-load.c: Fix common/ includes.
6434         * arm-tdep.c: Fix common/ includes.
6435         * arch/riscv.c: Fix common/ includes.
6436         * arch/ppc-linux-common.c: Fix common/ includes.
6437         * arch/i386.c: Fix common/ includes.
6438         * arch/arm.c: Fix common/ includes.
6439         * arch/arm-linux.c: Fix common/ includes.
6440         * arch/arm-get-next-pcs.c: Fix common/ includes.
6441         * arch/amd64.c: Fix common/ includes.
6442         * arch/aarch64.c: Fix common/ includes.
6443         * arch/aarch64-insn.c: Fix common/ includes.
6444         * arch-utils.c: Fix common/ includes.
6445         * amd64-windows-tdep.c: Fix common/ includes.
6446         * amd64-tdep.c: Fix common/ includes.
6447         * amd64-sol2-tdep.c: Fix common/ includes.
6448         * amd64-obsd-tdep.c: Fix common/ includes.
6449         * amd64-nbsd-tdep.c: Fix common/ includes.
6450         * amd64-linux-tdep.c: Fix common/ includes.
6451         * amd64-linux-nat.c: Fix common/ includes.
6452         * amd64-fbsd-tdep.c: Fix common/ includes.
6453         * amd64-fbsd-nat.c: Fix common/ includes.
6454         * amd64-dicos-tdep.c: Fix common/ includes.
6455         * amd64-darwin-tdep.c: Fix common/ includes.
6456         * agent.c: Fix common/ includes.
6457         * ada-lang.h: Fix common/ includes.
6458         * ada-lang.c: Fix common/ includes.
6459         * aarch64-tdep.c: Fix common/ includes.
6460
6461 2019-01-25  Tom Tromey  <tom@tromey.com>
6462
6463         * common/create-version.sh: Use common/version.h.
6464
6465 2019-01-24  Pedro Alves  <palves@redhat.com>
6466
6467         * infrun.c (signal_stop, signal_print, signal_program)
6468         (signal_catch, signal_pass): Now arrays instead of pointers.
6469         (update_signals_program_target, do_target_resume)
6470         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6471         * linux-nat.c (linux_nat_target::pass_signals)
6472         (linux_nat_target::create_inferior, linux_nat_target::attach):
6473         Adjust.
6474         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6475         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6476         * procfs.c (procfs_target::pass_signals): Adjust.
6477         * record-full.c (record_full_target::resume): Adjust.
6478         * remote.c (remote_target::pass_signals)
6479         (remote_target::program_signals): Adjust.
6480         * target-debug.h (target_debug_print_signals): Now takes a
6481         gdb::array_view as parameter.  Adjust.
6482         * target.h (target_ops) <pass_signals, program_signals>: Replace
6483         pointer and length parameters with gdb::array_view.
6484         (target_pass_signals, target_program_signals): Likewise.
6485         * target-delegates.c: Regenerate.
6486
6487 2019-01-24  Pedro Alves  <palves@redhat.com>
6488
6489         * common/forward-scope-exit.h
6490         (forward_scope_exit::forward_scope_exit): Pass arguments to
6491         m_bind_function directly, instead of creating a std::bind and
6492         copying that.
6493
6494 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6495
6496         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6497         for static members.
6498         (pass_in_v_vfp_candidate): Likewise.
6499
6500 2019-01-23  Tom Tromey  <tom@tromey.com>
6501             Pedro Alves  <palves@redhat.com>
6502
6503         * regcache.c (class regcache_invalidator): Remove.
6504         (regcache::raw_write): Use make_scope_exit.
6505
6506 2019-01-23  Tom Tromey  <tom@tromey.com>
6507
6508         * ui-out.h (class ui_out_emit_type): Update comment.
6509
6510 2019-01-23  Tom Tromey  <tom@tromey.com>
6511
6512         * infrun.c (fetch_inferior_event): Update comment.
6513
6514 2019-01-23  Tom Tromey  <tom@tromey.com>
6515             Pedro Alves  <palves@redhat.com>
6516
6517         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6518         parameter.
6519         (fetch_inferior_event): Use SCOPE_EXIT.
6520
6521
6522 2019-01-23  Tom Tromey  <tom@tromey.com>
6523             Pedro Alves  <palves@redhat.com>
6524
6525         * infrun.c (disable_thread_events): Delete.
6526         (stop_all_threads): Use SCOPE_EXIT.
6527
6528 2019-01-23  Tom Tromey  <tom@tromey.com>
6529             Pedro Alves  <palves@redhat.com>
6530
6531         * symfile.c: Include forward-scope-exit.h.
6532         (clear_symtab_users_cleanup): Replace forward declaration with
6533         a FORWARD_SCOPE_EXIT.
6534         (syms_from_objfile_1): Use the forward_scope_exit and
6535         gdb::optional instead of cleanup_function.
6536         (reread_symbols): Use the forward_scope_exit instead of
6537         cleanup_function.
6538         (clear_symtab_users_cleanup): Remove function.
6539
6540 2019-01-23  Tom Tromey  <tom@tromey.com>
6541             Pedro Alves  <palves@redhat.com>
6542
6543         * linux-nat.c: Include scope-exit.h.
6544         (cleanup_target_stop): Remove.
6545         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6546         SCOPE_EXIT.
6547
6548 2019-01-23  Tom Tromey  <tom@tromey.com>
6549             Pedro Alves  <palves@redhat.com>
6550
6551         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6552         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6553
6554 2019-01-23  Tom Tromey  <tom@tromey.com>
6555             Andrew Burgess  <andrew.burgess@embecosm.com>
6556             Pedro Alves  <palves@redhat.com>
6557
6558         * infrun.c (fetch_inferior_event): Use scope_exit.
6559         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6560         * top.c (execute_command): Use scope_exit.
6561         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6562         * utils.c (do_bpstat_clear_actions_cleanup)
6563         (make_bpstat_clear_actions_cleanup): Remove.
6564
6565 2019-01-23  Tom Tromey  <tom@tromey.com>
6566             Pedro Alves  <palves@redhat.com>
6567
6568         * infrun.c: Include "common/scope-exit.h"
6569         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6570         (wait_for_inferior): Use SCOPE_EXIT.
6571         (fetch_inferior_event): Use scope_exit.
6572
6573 2019-01-23  Tom Tromey  <tom@tromey.com>
6574             Pedro Alves  <palves@redhat.com>
6575
6576         * breakpoint.c (create_breakpoint): Remove cleanup.
6577
6578 2019-01-23  Tom Tromey  <tom@tromey.com>
6579             Andrew Burgess  <andrew.burgess@embecosm.com>
6580             Pedro Alves  <palves@redhat.com>
6581
6582 2019-01-23  Pedro Alves  <palves@redhat.com>
6583
6584         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6585
6586 2019-01-23  Pedro Alves  <palves@redhat.com>
6587             Andrew Burgess  <andrew.burgess@embecosm.com>
6588
6589         * gdbthread.h: Include "common/forward-scope-exit.h".
6590         (scoped_finish_thread_state): Redefine custom class in terms of
6591         forward_scope_exit.
6592
6593 2019-01-23  Pedro Alves  <palves@redhat.com>
6594             Andrew Burgess  <andrew.burgess@embecosm.com>
6595
6596         * common/forward-scope-exit.h: New file.
6597
6598 2019-01-23  Pedro Alves  <palves@redhat.com>
6599             Andrew Burgess  <andrew.burgess@embecosm.com>
6600             Tom Tromey  <tom@tromey.com>
6601
6602         * common/scope-exit.h: New file.
6603
6604 2019-01-23  Pedro Alves  <palves@redhat.com>
6605
6606         * common/preprocessor.h (ESC): Rename to ...
6607         (ESC_PARENS): ... this.
6608         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6609         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6610
6611 2019-01-23  Tom Tromey  <tom@tromey.com>
6612
6613         * language.h (class scoped_switch_to_sym_language_if_auto):
6614         Initialize m_lang in both cases.
6615
6616 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6617
6618         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6619         with XCNEW.
6620
6621 2019-01-22  Tom Tromey  <tom@tromey.com>
6622
6623         * corelow.c: Do not include sys/file.h.
6624
6625 2019-01-22  Tom Tromey  <tom@tromey.com>
6626
6627         * tui/tui-wingeneral.h: Include gdb_curses.h.
6628
6629 2019-01-22  Tom Tromey  <tom@tromey.com>
6630
6631         * source-cache.h (class source_cache) <get_source_lines,
6632         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6633
6634 2019-01-22  Tom Tromey  <tom@tromey.com>
6635
6636         * remote-fileio.h (struct remote_target): Declare.
6637
6638 2019-01-22  Tom Tromey  <tom@tromey.com>
6639
6640         * python/py-arch.c: Do not include py-ref.h.
6641         * python/py-bpevent.c: Do not include py-ref.h.
6642         * python/py-cmd.c: Do not include py-ref.h.
6643         * python/py-continueevent.c: Do not include py-ref.h.
6644         * python/py-event.h: Do not include py-ref.h.
6645         * python/py-evtregistry.c: Do not include py-ref.h.
6646         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6647         * python/py-frame.c: Do not include py-ref.h.
6648         * python/py-framefilter.c: Do not include py-ref.h.
6649         * python/py-function.c: Do not include py-ref.h.
6650         * python/py-infevents.c: Do not include py-ref.h.
6651         * python/py-linetable.c: Do not include py-ref.h.
6652         * python/py-objfile.c: Do not include py-ref.h.
6653         * python/py-param.c: Do not include py-ref.h.
6654         * python/py-prettyprint.c: Do not include py-ref.h.
6655         * python/py-progspace.c: Do not include py-ref.h.
6656         * python/py-symbol.c: Do not include py-ref.h.
6657         * python/py-symtab.c: Do not include py-ref.h.
6658         * python/py-type.c: Do not include py-ref.h.
6659         * python/py-unwind.c: Do not include py-ref.h.
6660         * python/py-utils.c: Do not include py-ref.h.
6661         * python/py-value.c: Do not include py-ref.h.
6662         * python/py-varobj.c: Do not include py-ref.h.
6663         * python/py-xmethods.c: Do not include py-ref.h.
6664         * python/python.c: Do not include py-ref.h.
6665         * varobj.c: Do not include py-ref.h.
6666
6667 2019-01-22  Tom Tromey  <tom@tromey.com>
6668
6669         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6670         keyword for bcache.
6671
6672 2019-01-22  Tom Tromey  <tom@tromey.com>
6673
6674         * compile/compile-cplus-types.c: Remove a comment by #include.
6675
6676 2019-01-22  Tom Tromey  <tom@tromey.com>
6677
6678         * compile/gcc-c-plugin.h: Include compile-internal.h.
6679
6680 2019-01-22  Tom Tromey  <tom@tromey.com>
6681
6682         * stabsread.c (EXTERN): Do not define.
6683         (symnum, next_symbol_text_func, processing_gcc_compilation)
6684         (within_function, global_sym_chain, global_stabs)
6685         (previous_stab_code, this_object_header_files)
6686         (n_this_object_header_files)
6687         (n_allocated_this_object_header_files): Define.
6688         * stabsread.h (EXTERN): Never define.  Use "extern".
6689
6690 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6691
6692         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6693         history_value.
6694
6695 2019-01-21  Tom Tromey  <tom@tromey.com>
6696
6697         * ui-out.c: Fix includes.
6698         * tui/tui-source.c: Fix includes.
6699         * target.c: Fix includes.
6700         * remote.c: Fix includes.
6701         * regcache.c: Fix includes.
6702         * python/py-block.c: Fix includes.
6703         * printcmd.c: Fix includes.
6704         * or1k-tdep.c: Fix includes.
6705         * mi/mi-main.c: Fix includes.
6706         * m32r-tdep.c: Fix includes.
6707         * csky-tdep.c: Fix includes.
6708         * compile/compile-cplus-types.c: Fix includes.
6709         * cli/cli-interp.c: Fix includes.
6710
6711 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6712
6713         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6714         for padding.
6715
6716 2019-01-16  Tom Tromey  <tom@tromey.com>
6717
6718         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6719         earlier.
6720         (struct objfile) <msymbols_range>: Move from top level.
6721         <msymbols>: New method.
6722         (class objfile_msymbols): Remove.
6723         * symtab.c (default_collect_symbol_completion_matches_break_on):
6724         Update.
6725         * symmisc.c (dump_msymbols): Update.
6726         * stabsread.c (scan_file_globals): Update.
6727         * objc-lang.c (info_selectors_command, info_classes_command)
6728         (find_methods): Update.
6729         * minsyms.c (find_solib_trampoline_target): Update.
6730         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6731         * coffread.c (coff_symfile_read): Update.
6732         * ada-lang.c (ada_lookup_simple_minsym)
6733         (ada_collect_symbol_completion_matches): Update.
6734
6735 2019-01-16  Tom Tromey  <tom@tromey.com>
6736
6737         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6738         type.  Remove no-argument constructor.
6739         <iterator::operator++>: Simplify.
6740         <begin>: Update.
6741         <end>: Use minimal_symbol_count.
6742
6743 2019-01-16  Tom Tromey  <tom@tromey.com>
6744
6745         * objfiles.h (struct objfile) <psymtabs>: New method.
6746         (class objfile_psymtabs): Remove.
6747         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6748         typedef.
6749         <range>: New method.
6750         (require_partial_symbols): Change return type.
6751         * psymtab.c (require_partial_symbols)
6752         (psym_expand_symtabs_matching): Update.
6753         * mdebugread.c (parse_partial_symbols): Update.
6754         * dbxread.c (dbx_end_psymtab): Update.
6755
6756 2019-01-15  Tom Tromey  <tom@tromey.com>
6757
6758         * symtab.c (lookup_objfile_from_block)
6759         (lookup_symbol_in_objfile_symtabs)
6760         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6761         (find_line_symtab, info_sources_command)
6762         (default_collect_symbol_completion_matches_break_on)
6763         (make_source_files_completion_list): Update.
6764         * symmisc.c (print_objfile_statistics, dump_objfile)
6765         (maintenance_print_symbols, maintenance_info_symtabs)
6766         (maintenance_check_symtabs, maintenance_info_line_tables):
6767         Update.
6768         * source.c (select_source_symtab)
6769         (forget_cached_source_info_for_objfile): Update.
6770         * objfiles.h (class objfile_compunits): Remove.
6771         (struct objfile) <compunits_range>: New typedef.
6772         (compunits): New method.
6773         * objfiles.c (objfile_relocate1): Update.
6774         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6775         * maint.c (count_symtabs_and_blocks): Update.
6776         * linespec.c (iterate_over_all_matching_symtabs): Update.
6777         * cp-support.c (add_symbol_overload_list_qualified): Update.
6778         * coffread.c (coff_symtab_read): Update.
6779         * ada-lang.c (add_nonlocal_symbols)
6780         (ada_collect_symbol_completion_matches)
6781         (ada_add_global_exceptions): Update.
6782
6783 2019-01-15  Tom Tromey  <tom@tromey.com>
6784
6785         * progspace.h (program_space) <objfiles_safe_range>: New
6786         typedef.
6787         <objfiles_safe>: New method.
6788         * objfiles.h (class all_objfiles_safe): Remove.
6789         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6790         * jit.c (jit_inferior_exit_hook): Update.
6791
6792 2019-01-17  Tom Tromey  <tom@tromey.com>
6793
6794         * progspace.h (program_space) <objfiles_range>: New typedef.
6795         <objfiles>: New method.
6796         <objfiles_head>: Rename from objfiles.
6797         (object_files): Update.
6798         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6799         * guile/scm-pretty-print.c
6800         (ppscm_find_pretty_printer_from_objfiles): Update.
6801         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6802         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6803         Update.
6804         * python/py-progspace.c (pspy_get_objfiles): Update.
6805         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6806         Update.
6807         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6808         (objfpy_lookup_objfile_by_build_id): Update.
6809         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6810         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6811         Update.
6812         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6813         (expand_symtab_containing_pc, lookup_objfile_from_block)
6814         (lookup_static_symbol, basic_lookup_transparent_type)
6815         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6816         (find_line_symtab, info_sources_command)
6817         (default_collect_symbol_completion_matches_break_on)
6818         (make_source_files_completion_list, find_main_name): Update.
6819         * symmisc.c (print_symbol_bcache_statistics)
6820         (print_objfile_statistics, maintenance_print_symbols)
6821         (maintenance_print_msymbols, maintenance_print_objfiles)
6822         (maintenance_info_symtabs, maintenance_check_symtabs)
6823         (maintenance_expand_symtabs, maintenance_info_line_tables):
6824         Update.
6825         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6826         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6827         (map_overlay_command, unmap_overlay_command)
6828         (simple_overlay_update, expand_symtabs_matching)
6829         (map_symbol_filenames): Update.
6830         * symfile-debug.c (set_debug_symfile): Update.
6831         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6832         Update.
6833         * source.c (select_source_symtab, forget_cached_source_info):
6834         Update.
6835         * solib.c (solib_read_symbols): Update.
6836         * solib-spu.c (append_ocl_sos): Update.
6837         * psymtab.c (maintenance_print_psymbols)
6838         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6839         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6840         * printcmd.c (info_symbol_command): Update.
6841         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6842         Update.
6843         * objfiles.h (class all_objfiles): Remove.
6844         * objfiles.c (have_partial_symbols, have_full_symbols)
6845         (have_minimal_symbols, qsort_cmp, update_section_map)
6846         (shared_objfile_contains_address_p)
6847         (default_iterate_over_objfiles_in_search_order): Update.
6848         * objc-lang.c (info_selectors_command, info_classes_command)
6849         (find_methods): Update.
6850         * minsyms.c (find_solib_trampoline_target): Update.
6851         * maint.c (maintenance_info_sections)
6852         (maintenance_translate_address, count_symtabs_and_blocks):
6853         Update.
6854         * main.c (captured_main_1): Update.
6855         * linux-thread-db.c (try_thread_db_load_from_pdir)
6856         (has_libpthread): Update.
6857         * linespec.c (iterate_over_all_matching_symtabs)
6858         (search_minsyms_for_name): Update.
6859         * jit.c (jit_find_objf_with_entry_addr): Update.
6860         * hppa-tdep.c (find_unwind_entry)
6861         (hppa_lookup_stub_minimal_symbol): Update.
6862         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6863         Update.
6864         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6865         (elf_gnu_ifunc_resolve_by_got): Update.
6866         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6867         * dwarf-index-write.c (save_gdb_index_command): Update.
6868         * cp-support.c (add_symbol_overload_list_qualified): Update.
6869         * breakpoint.c (create_overlay_event_breakpoint)
6870         (create_longjmp_master_breakpoint)
6871         (create_std_terminate_master_breakpoint)
6872         (create_exception_master_breakpoint): Update.
6873         * blockframe.c (find_pc_partial_function): Update.
6874         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6875         (ada_collect_symbol_completion_matches)
6876         (ada_add_global_exceptions): Update.
6877
6878 2019-01-17  Tom Tromey  <tom@tromey.com>
6879
6880         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6881         declare VEC.
6882         (solib_target_parse_libraries): Change return type.
6883         (library_list_start_segment, library_list_start_section)
6884         (library_list_end_library, library_list_start_library); Update.
6885         (solib_target_free_library_list): Remove.
6886         (solib_target_parse_libraries): Remove cleanup.  Change return
6887         type.
6888         (solib_target_current_sos): Update.
6889
6890 2019-01-17  Tom Tromey  <tromey@bapiya>
6891
6892         * valprint.c: Replace "the the" with "the".
6893         * symtab.c: Replace "the the" with "the".
6894         * solib.c: Replace "the the" with "the".
6895         * solib-dsbt.c: Replace "the the" with "the".
6896         * linespec.c: Replace "the the" with "the".
6897         * dwarf2loc.h: Replace "the the" with "the".
6898         * amd64-windows-tdep.c: Replace "the the" with "the".
6899         * aarch64-tdep.c: Replace "the the" with "the".
6900
6901 2019-01-16  Keith Seitz  <keiths@redhat.com>
6902
6903         PR gdb/23773
6904         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6905         <builder>: Rename to ..
6906         <m_builder>: ... this and make private.
6907         (dwarf2_cu::get_builder): New method.  Change all users of
6908         `builder' to use this method.
6909         (dwarf2_start_symtab): Move to ...
6910         (dwarf2_cu::start_symtab): ... here.  Update all callers
6911         (setup_type_unit_groups): Move to ...
6912         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6913         callers.
6914         (dwarf2_cu::reset_builder): New method.
6915         (process_full_compunit, process_full_type_unit): Use
6916         dwarf2_cu::reset_builder.
6917         (follow_die_offset): Record the ancestor CU if it is different
6918         from the followed DIE's CU.
6919         (follow_die_sig_1): Likewise.
6920
6921 2019-01-15  Tom Tromey  <tom@tromey.com>
6922
6923         * remote.c (class remote_state) <buf>: Now a char_vector.
6924         <buf_size>: Remove.
6925         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6926         parameter.
6927         (remote_target::getpkt_or_notif_sane_1)
6928         (remote_target::getpkt_sane)
6929         (remote_target::getpkt_or_notif_sane): Likewise.
6930         (class remote_target) <putpkt>: New overload.
6931         (remote_target::read_frame): Change type of "buf_p".  Remove
6932         sizeof_p parameter.
6933         (packet_ok): New overload.
6934         (packet_check_result): New overload.
6935         Update all uses.
6936
6937 2019-01-14  Tom Tromey  <tom@tromey.com>
6938
6939         * remote-notif.c (handle_notification, remote_notif_ack)
6940         (remote_notif_parse): Make "buf" const.
6941         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6942         const.
6943         (remote_notif_parse, remote_notif_ack, handle_notification):
6944         Likewise.
6945         * remote.c (remote_notif_stop_parse): Make "buf" const.
6946         (remote_target::remote_parse_stop_reply): Make "buf" const.
6947         (remote_notif_stop_ack): Make "buf" const.
6948
6949 2019-01-14  Tom Tromey  <tom@tromey.com>
6950
6951         * remote.c (remote_console_output): Make parameter const.
6952
6953 2019-01-14  Tom Tromey  <tom@tromey.com>
6954
6955         * target-debug.h (target_debug_print_signals): Constify.
6956         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6957         * procfs.c (procfs_target::pass_signals): Update.
6958         * linux-nat.c (linux_nat_target::pass_signals): Update.
6959         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6960         * target-delegates.c: Rebuild.
6961         * remote.c (remote_target::program_signals): Update.
6962         (remote_target::pass_signals): Update.
6963         * target.c (target_pass_signals): Constify argument.
6964         (target_program_signals): Likewise.
6965         * target.h (struct target_ops) <pass_signals, program_signals>:
6966         Constify argument.
6967         (target_pass_signals, target_program_signals): Constify argument.
6968
6969 2019-01-14  Tom Tromey  <tom@tromey.com>
6970
6971         PR tui/28819:
6972         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6973
6974 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6975
6976         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6977         field.
6978         * rs6000-tdep.c: Include reggroups.h.
6979         (IS_V_ALIAS_PSEUDOREG): Define.
6980         (rs6000_register_name): Return names for the "vX" aliases.
6981         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6982         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6983         aliases.  Call default_register_reggroup_p for all other
6984         pseudo-registers.
6985         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6986         New functions.
6987         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6988         Handle "vX" aliases.
6989         (v_alias_pseudo_register_collect): New function.
6990         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6991         (rs6000_gdbarch_init): Initialize "vX" aliases as
6992         pseudo-registers.  Restore registration of
6993         rs6000_pseudo_register_reggroup_p with
6994         set_tdesc_pseudo_register_reggroup_p.
6995
6996 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6997
6998         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6999         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7000         set_gdbarch_num_pseudo_regs.
7001
7002 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7003
7004         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7005         Remove arg prefixname, add do_set and do_show.
7006         Add member functions set_list and show_list.
7007         * cli/cli-style.c (class cli_style_option): Update accordingly.
7008         (style_set_list): Move to file scope.
7009         (style_show_list): Likewise.
7010         (set_style): Call help_list.
7011         (show_style): Call cmd_show_list.
7012         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7013         Update to use the new macro.
7014
7015 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7016
7017         * ada-lang.c (_initialize_ada_language): Expand the help text
7018         for the "catch exception" command.
7019
7020 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7021
7022         * symtab.c (matching_obj_sections): Initialize obj,
7023         declare it closer to its usage.
7024
7025 2019-01-10  Tom Tromey  <tom@tromey.com>
7026
7027         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7028         (basic_inf_threads_range): Remove.
7029         (inf_threads_range, inf_non_exited_threads_range)
7030         (safe_inf_threads_range): Use next_adapter.
7031
7032 2019-01-10  Keith Seitz  <keiths@redhat.com>
7033
7034         PR gdb/23712
7035         PR symtab/23010
7036         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7037         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7038
7039 2019-01-10  Keith Seitz  <keiths@redhat.com>
7040
7041         PR gdb/23712
7042         PR symtab/23010
7043         * dictionary.c (pending_to_vector): Remove.
7044         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7045         Remove _1 suffix, replacing functions of the same name.  Update
7046         all callers.
7047         (dict_create_hashed, dict_create_hashed_expandable)
7048         (dict_create_linear, dict_create_linear_expandable, dict_free)
7049         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7050         Make functions static.
7051
7052 2019-01-10  Keith Seitz  <keiths@redhat.com>
7053
7054         PR gdb/23712
7055         PR symtab/23010
7056         * dictionary.h (struct dictionary): Replace declaration with
7057         multidictionary.
7058         (dict_create_hashed, dict_create_hashed_expandable)
7059         (dict_create_linear, dict_create_linear_expandable)
7060         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7061         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7062         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7063         taking multidictionary argument.
7064         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7065         * block.h (struct block) <dict>: Change to multidictionary
7066         and rename `multidict'.
7067         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7068         symmisc.c: Update all dictionary references to multidictionary.
7069
7070 2019-01-10  Keith Seitz  <keiths@redhat.com>
7071
7072         PR gdb/23712
7073         PR symtab/23010
7074         * dictionary.c: Include unordered_map.
7075         (pending_to_vector): New function.
7076         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7077         Rewrite the non-"_1" functions to take vector instead
7078         of linked list.
7079         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7080         "new" _1 versions of the same name.
7081         (multidictionary): Define.
7082         (std::hash<enum language): New definition.
7083         (collate_pending_symbols_by_language, mdict_create_hashed)
7084         (mdict_create_hashed_expandable, mdict_create_linear)
7085         (mdict_create_linear_expandable, mdict_free)
7086         (find_language_dictionary, create_new_language_dictionary)
7087         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7088         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7089         (mdict_size, mdict_empty): New functions.
7090         * dictionary.h (mdict_iterator): Define.
7091
7092 2019-01-10  Pedro Alves  <palves@redhat.com>
7093
7094         * breakpoint.c (read_uploaded_action)
7095         (create_tracepoint_from_upload): Adjust to use
7096         gdb::unique_xmalloc_ptr.
7097         * ctf.c (ctf_write_uploaded_tp):
7098         (SET_ARRAY_FIELD): Use emplace_back.
7099         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7100         * tracefile-tfile.c (tfile_write_uploaded_tp):
7101         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7102         gdb::unique_xmalloc_ptr.
7103         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7104         at_string, cond_string, cmd_strings>: Replace char pointers
7105         with gdb::unique_xmalloc_ptr.
7106
7107 2019-01-10  Pedro Alves  <palves@redhat.com>
7108
7109         * solib-target.c (library_list_start_library): Don't xstrdup name.
7110
7111 2019-01-10  Pedro Alves  <palves@redhat.com>
7112
7113         * mdebugread.c (parse_partial_symbols): Use
7114         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7115
7116 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7117
7118         * linux-fork.c (scoped_switch_fork_info)
7119         <~scoped_switch_fork_info>: Fix incorrect variable name.
7120
7121 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7122
7123         * linux-fork.c (scoped_switch_fork_info)
7124         <scoped_switch_fork_info>: Make explicit.
7125         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7126
7127 2019-01-10  Tom Tromey  <tom@tromey.com>
7128
7129         * objfiles.h (objfile::reset_psymtabs): Update.
7130         * objfiles.c (objfile::objfile): Update.
7131         * psymtab.h (psymtab_storage::obstack): Update.
7132         (psymtab_storage::m_obstack): Use gdb::optional.
7133         (class psymtab_storage): Update comment.  Remove objfile
7134         parameter.
7135         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7136
7137 2019-01-10  Tom Tromey  <tom@tromey.com>
7138
7139         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7140         <free_psymtabs>: Now private.
7141         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7142         (allocate_psymtab): Use new method.
7143
7144 2019-01-10  Tom Tromey  <tom@tromey.com>
7145
7146         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7147         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7148         * mdebugread.c (parse_partial_symbols): Use
7149         allocate_dependencies.
7150         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7151         allocate_dependencies.
7152         (process_psymtab_comp_unit_reader)
7153         (build_type_psymtab_dependencies): Likewise.
7154         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7155
7156 2019-01-10  Tom Tromey  <tom@tromey.com>
7157
7158         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7159         PSYMBOL_SET_LANGUAGE.
7160         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7161
7162 2019-01-10  Tom Tromey  <tom@tromey.com>
7163
7164         * psymtab.h (psymtab_storage::obstack): New method.
7165         <m_obstack>: Rename from obstack; now private.
7166         * psymtab.c (psymtab_storage): Update.
7167         * dwarf2read.c (create_addrmap_from_index)
7168         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7169         Update.
7170
7171 2019-01-10  Tom Tromey  <tom@tromey.com>
7172
7173         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7174         * objfiles.h (objfile::reset_psymtabs): New method.
7175
7176 2019-01-10  Tom Tromey  <tom@tromey.com>
7177
7178         * symmisc.c (print_symbol_bcache_statistics): Update.
7179         (print_objfile_statistics): Update.
7180         * symfile.c (reread_symbols): Update.
7181         * psymtab.h (class psymtab_storage): New.
7182         * psymtab.c (psymtab_storage): New constructor.
7183         (~psymtab_storage): New destructor.
7184         (require_partial_symbols): Update.
7185         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7186         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7187         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7188         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7189         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7190         (start_psymtab_common, end_psymtab_common)
7191         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7192         (allocate_psymtab): Update.
7193         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7194         Update.
7195         (dump_psymtab_addrmap, maintenance_print_psymbols)
7196         (maintenance_check_psymtabs): Update.
7197         (class objfile_psymtabs): Move to objfiles.h.
7198         * psympriv.h (discard_psymtab): Now inline.
7199         (psymtab_discarder::psymtab_discarder): Update.
7200         (psymtab_discarder::~psymtab_discarder): Update.
7201         (ALL_OBJFILE_PSYMTABS): Rewrite.
7202         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7203         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7204         Remove fields.
7205         <partial_symtabs>: New field.
7206         (class objfile_psymtabs): Move from psymtab.h.  Update.
7207         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7208         psymbol_cache.
7209         (objfile::~objfile): Don't destroy psymbol_cache.
7210         * mdebugread.c (parse_partial_symbols): Update.
7211         * dwarf2read.c (create_addrmap_from_index)
7212         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7213         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7214         (add_partial_subprogram, dwarf2_ranges_read): Update.
7215         * dwarf-index-write.c (write_address_map)
7216         (write_one_signatured_type, recursively_write_psymbols)
7217         (class debug_names, class debug_names, write_psymtabs_to_index):
7218         Update.
7219
7220 2019-01-10  Tom Tromey  <tom@tromey.com>
7221
7222         * symtab.h (SYMBOL_SET_NAMES): Update.
7223         (symbol_set_names): Update.
7224         (MSYMBOL_SET_NAMES): Update.
7225         * symtab.c (symbol_set_names): Change argument to be an
7226         objfile_per_bfd_storage.
7227         * psymtab.c (add_psymbol_to_bcache): Update.
7228         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7229
7230 2019-01-10  Tom Tromey  <tom@tromey.com>
7231
7232         * symtab.c (create_demangled_names_hash): Change argument to be an
7233         objfile_per_bfd_storage.
7234         (symbol_set_names): Update.
7235
7236 2019-01-10  Tom Tromey  <tom@tromey.com>
7237
7238         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7239         init_psymbol_list.
7240         * psymtab.c (init_psymbol_list): Do nothing if already called.
7241         * psympriv.h (init_psymbol_list): Add comment.
7242         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7243         init_psymbol_list.
7244         * dbxread.c (dbx_symfile_read): Unconditionally call
7245         init_psymbol_list.
7246
7247 2019-01-10  Tom Tromey  <tom@tromey.com>
7248
7249         * xcoffread.c (scan_xcoff_symtab): Update.
7250         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7251         "where".
7252         * mdebugread.c (parse_partial_symbols)
7253         (handle_psymbol_enumerators): Update.
7254         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7255         * dbxread.c (read_dbx_symtab): Update.
7256         * psympriv.h (psymbol_placement): New enum.
7257         (add_psymbol_to_list): Update.
7258
7259 2019-01-10  Tom Tromey  <tom@tromey.com>
7260
7261         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7262         static_psymbols parameters.
7263         (scan_xcoff_symtab): Update.
7264         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7265         static_psymbols parameters.
7266         * psympriv.h (start_psymtab_common): Update.
7267         * mdebugread.c (parse_partial_symbols): Update.
7268         * dwarf2read.c (create_partial_symtab): Update.
7269         * dbxread.c (read_dbx_symtab): Update.
7270         (start_psymtab): Remove global_psymbols and static_psymbols
7271         parameters.
7272
7273 2019-01-10  Tom Tromey  <tom@tromey.com>
7274
7275         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7276         * psymtab.c (allocate_psymtab): Add comment.
7277         * psympriv.h (allocate_psymtab): Add comment.
7278         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7279         initializations.
7280         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7281
7282 2019-01-10  Tom Tromey  <tom@tromey.com>
7283
7284         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7285         Don't declare.
7286         * mipsread.c: Include mdebugread.h.
7287         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7288         Declare.
7289         * elfread.c: Include mdebugread.h.
7290
7291 2019-01-09  Tom Tromey  <tom@tromey.com>
7292
7293         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7294         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7295         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7296         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7297         (psym_lookup_symbol, psym_find_last_source_symtab)
7298         (psym_forget_cached_source_info, psym_print_stats)
7299         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7300         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7301         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7302         (psym_find_compunit_symtab_by_address)
7303         (maintenance_print_psymbols, maintenance_info_psymtabs)
7304         (maintenance_check_psymtabs): Use ranged for.
7305         * psymtab.h (class objfile_psymtabs): New.
7306         (require_partial_symbols): Return objfile_psymtabs.
7307         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7308
7309 2019-01-09  Tom Tromey  <tom@tromey.com>
7310
7311         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7312         (find_pc_mapped_section, list_overlays_command)
7313         (map_overlay_command, unmap_overlay_command)
7314         (simple_overlay_update): Use all_objfiles.
7315         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7316         * printcmd.c (info_symbol_command): Use all_objfiles.
7317         * objfiles.h (ALL_OBJSECTIONS): Remove.
7318         * maint.c (maintenance_translate_address): Use all_objfiles.
7319         * gcore.c (gcore_create_callback): Use all_objfiles.
7320         (objfile_find_memory_regions): Likewise.
7321
7322 2019-01-09  Tom Tromey  <tom@tromey.com>
7323
7324         * symtab.c (find_line_symtab, info_sources_command)
7325         (make_source_files_completion_list): Use objfile_compunits.
7326         * source.c (select_source_symtab): Use objfile_compunits.
7327         * objfiles.h (struct objfile): Update comment.
7328         (ALL_OBJFILES): Remove.
7329         (ALL_FILETABS): Remove.
7330         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7331         objfile_compunits.
7332
7333 2019-01-09  Tom Tromey  <tom@tromey.com>
7334
7335         * symmisc.c (print_objfile_statistics, dump_objfile)
7336         (maintenance_print_symbols): Use compunit_filetabs.
7337         * source.c (forget_cached_source_info_for_objfile): Use
7338         compunit_filetabs.
7339         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7340         (ALL_FILETABS): Use compunit_filetabs.
7341         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7342         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7343
7344 2019-01-09  Tom Tromey  <tom@tromey.com>
7345
7346         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7347         (compunit_filetabs): New.
7348         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7349         compunit_filetabs.
7350         (info_sources_command, make_source_files_completion_list): Remove
7351         declaration.
7352         * symmisc.c (print_objfile_statistics, dump_objfile)
7353         (maintenance_print_symbols): Remove declaration.
7354         (maintenance_info_symtabs): Use compunit_filetabs.
7355         (maintenance_info_line_tables): Likewise.
7356         * source.c (select_source_symtab): Change local variable name.
7357         (forget_cached_source_info_for_objfile): Remove declaration.
7358         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7359         * objfiles.c (objfile_relocate1): Remove declaration.
7360         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7361         declaration.
7362         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7363         * coffread.c (coff_symtab_read): Remove declaration.
7364         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7365         compunit_filetabs.
7366
7367 2019-01-09  Tom Tromey  <tom@tromey.com>
7368
7369         * symtab.c (lookup_objfile_from_block)
7370         (find_pc_sect_compunit_symtab, search_symbols)
7371         (default_collect_symbol_completion_matches_break_on): Use
7372         objfile_compunits.
7373         * objfiles.h (ALL_COMPUNITS): Remove.
7374         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7375         * cp-support.c (add_symbol_overload_list_qualified): Use
7376         objfile_compunits.
7377         * ada-lang.c (ada_collect_symbol_completion_matches)
7378         (ada_add_global_exceptions): Use objfile_compunits.
7379
7380 2019-01-09  Tom Tromey  <tom@tromey.com>
7381
7382         * source.c (select_source_symtab)
7383         (forget_cached_source_info_for_objfile): Remove declaration.
7384         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7385         declaration.
7386         * maint.c (count_symtabs_and_blocks): Remove declaration.
7387         * cp-support.c (add_symbol_overload_list_qualified): Remove
7388         declaration.
7389         * coffread.c (coff_symtab_read): Remove declaration.
7390         * symtab.c (lookup_symbol_in_objfile_symtabs)
7391         (basic_lookup_transparent_type_1): Use objfile_compunits.
7392         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7393         (info_sources_command, search_symbols)
7394         (default_collect_symbol_completion_matches_break_on)
7395         (make_source_files_completion_list): Remove declaration.
7396         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7397         (ada_collect_symbol_completion_matches)
7398         (ada_add_global_exceptions): Remove declaration.
7399         * linespec.c (iterate_over_all_matching_symtabs): Use
7400         objfile_compunits.
7401         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7402         (class objfile_compunits): New.
7403         (ALL_COMPUNITS): Use objfile_compunits.
7404         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7405         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7406         objfile_compunits.
7407         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7408
7409 2019-01-09  Tom Tromey  <tom@tromey.com>
7410
7411         * symtab.c (search_symbols)
7412         (default_collect_symbol_completion_matches_break_on): Use
7413         objfile_msymbols.
7414         * ada-lang.c (ada_lookup_simple_minsym)
7415         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7416         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7417         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7418         objfile_msymbols.
7419         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7420         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7421         * objc-lang.c (find_methods): Use objfile_msymbols.
7422         (info_selectors_command, info_classes_command): Likewise.
7423         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7424         * objfiles.h (class objfile_msymbols): New.
7425         (ALL_OBJFILE_MSYMBOLS): Remove.
7426         (ALL_MSYMBOLS): Remove.
7427
7428 2019-01-09  Tom Tromey  <tom@tromey.com>
7429
7430         * common/next-iterator.h (next_adapter): Add Iterator template
7431         parameter.
7432         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7433         (class all_objfiles_safe): New.
7434         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7435         * objfiles.c (put_objfile_before): Update comment.
7436         (add_separate_debug_objfile): Likewise.
7437         (free_all_objfiles): Use all_objfiles_safe.
7438         (objfile_purge_solibs): Likewise.
7439
7440 2019-01-09  Tom Tromey  <tom@tromey.com>
7441
7442         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7443         (expand_symtab_containing_pc, lookup_static_symbol)
7444         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7445         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7446         all_objfiles.
7447         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7448         * breakpoint.c (create_overlay_event_breakpoint)
7449         (create_longjmp_master_breakpoint)
7450         (create_std_terminate_master_breakpoint)
7451         (create_exception_master_breakpoint): Use all_objfiles.
7452         * linux-thread-db.c (try_thread_db_load_from_pdir)
7453         (has_libpthread): Use all_objfiles.
7454         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7455         * linespec.c (iterate_over_all_matching_symtabs)
7456         (search_minsyms_for_name): Use all_objfiles.
7457         * maint.c (maintenance_info_sections): Use all_objfiles.
7458         * main.c (captured_main_1): Use all_objfiles.
7459         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7460         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7461         * guile/scm-pretty-print.c
7462         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7463         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7464         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7465         (maintenance_print_msymbols): Use all_objfiles.
7466         * source.c (select_source_symtab): Use all_objfiles.
7467         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7468         * symfile.c (remove_symbol_file_command)
7469         (expand_symtabs_matching, map_symbol_filenames): Use
7470         all_objfiles.
7471         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7472         all_objfiles.
7473         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7474         * objc-lang.c (find_methods): Use all_objfiles.
7475         * objfiles.c (have_partial_symbols, have_full_symbols)
7476         (have_minimal_symbols, qsort_cmp)
7477         (default_iterate_over_objfiles_in_search_order): Use
7478         all_objfiles.
7479         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7480         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7481         (maintenance_check_psymtabs): Use all_objfiles.
7482         (ALL_PSYMTABS): Remove.
7483         * compile/compile-object-run.c (do_module_cleanup): Use
7484         all_objfiles.
7485         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7486         * cp-support.c (add_symbol_overload_list_qualified): Use
7487         all_objfiles.
7488         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7489         Use all_objfiles.
7490         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7491         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7492         all_objfiles.
7493         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7494         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7495         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7496         Uses all_objfiles.
7497         * solib.c (solib_read_symbols): Use all_objfiles
7498
7499 2019-01-09  Tom Tromey  <tom@tromey.com>
7500
7501         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7502         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7503         all_objfiles.
7504         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7505         * symmisc.c (print_symbol_bcache_statistics)
7506         (print_objfile_statistics, maintenance_print_objfiles)
7507         (maintenance_info_symtabs, maintenance_check_symtabs)
7508         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7509         all_objfiles.
7510         * source.c (forget_cached_source_info): Use all_objfiles.
7511         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7512         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7513         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7514         * objfiles.c (update_section_map): Use all_objfiles.
7515         (shared_objfile_contains_address_p): Likewise.
7516         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7517         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7518
7519 2019-01-09  Tom Tromey  <tom@tromey.com>
7520
7521         * common/next-iterator.h: New file.
7522         * objfiles.h (class all_objfiles): New.
7523         (struct objfile_iterator): New.
7524
7525 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7526
7527         * NEWS: Move the description of the changed "frame", "select-frame",
7528          and "info frame" commands to the Changed commands section.
7529
7530 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7531
7532         * gdbtypes.c (check_stub_method_group): Remove handling of old
7533         mangling schemes.
7534         * linespec.c (find_methods): Likewise.
7535         * stabsread.c (read_member_functions): Likewise.
7536         * valops.c (search_struct_method): Likewise.
7537         (value_struct_elt_for_reference): Likewise.
7538         * NEWS: Mention this change.
7539
7540 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7541
7542         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7543         print_source_lines.
7544         * source.c (print_source_lines_base): Update line number check.
7545         (print_source_lines): New function.
7546         (source_lines_range::source_lines_range): New function.
7547         * source.h (class source_lines_range): New class.
7548         (print_source_lines): New declaration.
7549
7550 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7551
7552         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7553
7554 2019-01-08  Tom Tromey  <tom@tromey.com>
7555             Simon Marchi  <simon.marchi@ericsson.com>
7556
7557         PR gdb/24060
7558         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7559         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7560         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7561         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7562         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7563         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7564
7565 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7566
7567         * source.c (select_source_symtab): Move header comment to
7568         declaration in source.h.
7569         (forget_cached_source_info_for_objfile): Likewise.
7570         (forget_cached_source_info): Likewise.
7571         (identify_source_line): Likewise.
7572         * source.h (identify_source_line): Move declaration from symtab.h
7573         and add comment from source.c
7574         (print_source_lines): Likewise.
7575         (forget_cached_source_info_for_objfile): Likewise.
7576         (forget_cached_source_info): Likewise.
7577         (select_source_symtab): Likewise.
7578         (enum print_source_lines_flag): Move definition from symtab.h.
7579         * symtab.h (identify_source_line): Move declaration to source.h.
7580         (print_source_lines): Likewise.
7581         (forget_cached_source_info_for_objfile): Likewise.
7582         (forget_cached_source_info): Likewise.
7583         (select_source_symtab): Likewise.
7584         (enum print_source_lines_flag): Move definition to source.h.
7585         * tui/tui-hooks.c: Add 'source.h' include.
7586
7587 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7588
7589         * source.c (print_source_lines_base): Handle requests to print
7590         reverse line number sequences, and guard against empty lines
7591         string.
7592
7593 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7594
7595         * source.c (print_source_lines_base): Fix skip of '\r' if next
7596         character is '\n'.
7597
7598 2019-01-06  Tom Tromey  <tom@tromey.com>
7599
7600         * c-exp.y (struct c_parse_state) <macro_original_text,
7601         expansion_obstack>: New member.
7602         (macro_original_text, expansion_obstack): Remove globals.
7603         (scan_macro_expansion, scanning_macro_expansion)
7604         (finished_macro_expansion): Update.
7605         (scan_macro_cleanup): Remove.
7606         (yylex, c_parse): Update.
7607
7608 2019-01-06  Tom Tromey  <tom@tromey.com>
7609
7610         * c-exp.y (struct c_parse_state) <strings>: New member.
7611         (operator_stoken): Update.
7612
7613 2019-01-06  Tom Tromey  <tom@tromey.com>
7614
7615         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7616         (union type_stack_elt) <typelist_val>: Now a pointer to
7617         std::vector.
7618         (type_stack_cleanup): Don't declare.
7619         (push_typelist): Update.
7620         * parse.c (pop_typelist): Return a std::vector.
7621         (push_typelist): Take a std::vector.
7622         (follow_types): Update.  Do not free args.
7623         (type_stack_cleanup): Remove.
7624         * c-exp.y (struct c_parse_state): New.
7625         (cpstate): New global.
7626         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7627         (nonempty_typelist): Update.
7628         (func_mod): Create a new vector.
7629         (c_parse): Create a c_parse_state.
7630         (check_parameter_typelist): Do not delete params.
7631         (function_method): Update.  Do not delete type_list.
7632
7633 2019-01-06  Tom Tromey  <tom@tromey.com>
7634
7635         PR gdb/28155:
7636         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7637         check_typedef.
7638         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7639         (print_return_value): Likewise.
7640
7641 2019-01-05  Tom Tromey  <tom@tromey.com>
7642
7643         * contrib/cleanup_check.py: Remove.
7644         * contrib/gcc-with-excheck: Remove.
7645         * contrib/exsummary.py: Remove.
7646         * contrib/excheck.py: Remove.
7647
7648 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7649
7650         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7651         NULL. Initialize tpprev to NULL instead of assigning it
7652         to NULL on the next statement.
7653         * windows-nat.c (windows_delete_thread): Remove check for
7654         main_thread_id before printing thread exit notifications.
7655         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7656         Remove thread ID check against main_thread_id.
7657         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7658         windows_delete_thread.
7659         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7660
7661 2019-01-04  Tom Tromey  <tom@tromey.com>
7662
7663         * compile/compile.c (_initialize_compile): Use upper case for
7664         metasyntactic variables.
7665         * symmisc.c (_initialize_symmisc): Use upper case for
7666         metasyntactic variables.
7667         * psymtab.c (_initialize_psymtab): Use upper case for
7668         metasyntactic variables.
7669         * demangle.c (demangle_command): Use upper case for metasyntactic
7670         variables.
7671         (_initialize_demangler): Likewise.
7672         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7673         variables.
7674
7675 2019-01-03  Tom Tromey  <tom@tromey.com>
7676
7677         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7678
7679 2019-01-03  Tom Tromey  <tom@tromey.com>
7680
7681         * python/py-symtab.c (salpy_str): Update.
7682         (struct salpy_sal_object) <symtab>: Now a PyObject.
7683         (salpy_dealloc): Update.
7684         (del_objfile_sal): Use gdbpy_ref.
7685
7686 2019-01-03  Tom Tromey  <tom@tromey.com>
7687
7688         * python/py-type.c (convert_field): Use new_reference.  Return
7689         gdbpy_ref.
7690         (make_fielditem): Return gdbpy_ref.
7691         (typy_fields): Update.
7692         (typy_getitem): Update.
7693         (field_name): Return gdbpy_ref.  Use new_reference.
7694         (typy_iterator_iternext): Update.
7695
7696 2019-01-03  Tom Tromey  <tom@tromey.com>
7697
7698         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7699
7700 2019-01-03  Tom Tromey  <tom@tromey.com>
7701
7702         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7703         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7704         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7705         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7706         (pspy_set_type_printers): Likewise.
7707         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7708         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7709         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7710         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7711         (objfpy_set_type_printers): Likewise.
7712
7713 2019-01-03  Tom Tromey  <tom@tromey.com>
7714
7715         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7716         (gdbpy_print_stack): Use gdbpy_err_fetch.
7717         * python/python-internal.h (class gdbpy_err_fetch): New class.
7718         (class gdbpy_enter) <m_error_type, m_error_value,
7719         m_error_traceback>: Remove.
7720         <m_error>: New member.
7721         (gdbpy_exception_to_string): Don't declare.
7722         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7723         * python/py-value.c (convert_value_from_python): Use
7724         gdbpy_err_fetch.
7725         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7726         gdbpy_exception_to_string.
7727         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7728         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7729         gdbpy_err_fetch.
7730
7731 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7732
7733         * linux-nat.c (delete_lwp_cleanup): Delete.
7734         (struct lwp_deleter): New struct.
7735         (lwp_info_up): New typedef.
7736         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7737         lwp_info_up.
7738
7739 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7740
7741         * linux-fork.c (class scoped_switch_fork_info): New class.
7742         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7743
7744 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7745
7746         * valops.c (find_overload_match): Remove use of null_cleanup, and
7747         calls to do_cleanups.
7748
7749 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7750
7751         * compile/compile-cplus-types.c
7752         (compile_cplus_instance::decl_name): Handle changes to
7753         cp_func_name.
7754         * cp-support.c (cp_func_name): Update header comment, update
7755         return type.
7756         * cp-support.h (cp_func_name): Update return type in declaration.
7757         * valops.c (find_overload_match): Move temp_func local to top
7758         level of function and change its type.  Use temp_func to hold and
7759         delete temporary string obtained from cp_func_name.
7760
7761 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7762
7763         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7764         gdb::char_vector, remove cleanup, and update uses of `msg`.
7765
7766 2019-01-03  Jim Wilson  <jimw@sifive.com>
7767
7768         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7769
7770 2019-01-02  Tom Tromey  <tom@tromey.com>
7771
7772         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7773         (tdesc_parse_xml): Remove cleanups.
7774         * target-descriptions.h (make_cleanup_free_target_description):
7775         Don't declare.
7776         (target_desc_deleter): New struct.
7777         (target_desc_up): New typedef.
7778         * target-descriptions.c (target_desc_deleter::operator()): Rename
7779         from free_target_description.
7780         (make_cleanup_free_target_description): Remove.
7781
7782 2019-01-02  Tom Tromey  <tom@tromey.com>
7783
7784         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7785         constructor, destructor.
7786         (linespec_parser): Remove typedef.
7787         (~linespec_parser): Rename from linespec_parser_delete.
7788         (linespec_lex_to_end, linespec_complete_label)
7789         (linespec_complete): Update.
7790         (decode_line_full): Remove cleanups.
7791         (decode_line_1): Update.
7792
7793 2019-01-02  Tom Tromey  <tom@tromey.com>
7794
7795         * python/python-internal.h (inferior_to_inferior_object): Change
7796         return type.
7797         * python/py-exitedevent.c (create_exited_event_object): Update.
7798         * python/py-inferior.c (inferior_to_inferior_object): Return
7799         gdbpy_ref.
7800         (python_new_inferior, python_inferior_deleted)
7801         (thread_to_thread_object, delete_thread_object)
7802         (build_inferior_list, gdbpy_selected_inferior): Update.
7803         * python/py-infthread.c (create_thread_object): Update.  Also fail
7804         if inferior_to_inferior_object fails.
7805
7806 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7807
7808         * inferior.h (class inferior) <displaced_step_state>: New field.
7809         * infrun.h (struct displaced_step_state): Move here from
7810         infrun.c.  Initialize fields, add constructor.
7811         <inf>: Remove field.
7812         <reset>: New method.
7813         * infrun.c (struct displaced_step_inferior_state): Move to
7814         infrun.h.
7815         (displaced_step_inferior_states): Remove.
7816         (get_displaced_stepping_state): Adust.
7817         (displaced_step_in_progress_any_inferior): Adjust.
7818         (displaced_step_in_progress_thread): Adjust.
7819         (displaced_step_in_progress): Adjust.
7820         (add_displaced_stepping_state): Remove.
7821         (get_displaced_step_closure_by_addr): Adjust.
7822         (remove_displaced_stepping_state): Remove.
7823         (infrun_inferior_exit): Call displaced_step_state.reset.
7824         (use_displaced_stepping): Don't check for NULL.
7825         (displaced_step_prepare_throw): Call
7826         get_displaced_stepping_state.
7827         (displaced_step_fixup): Don't check for NULL.
7828         (prepare_for_detach): Don't check for NULL.
7829
7830 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7831
7832         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7833          in case of call that did not complete.
7834
7835 2019-01-02  Andrey Utkin  <autkin@undo.io>
7836
7837         * symfile.c (find_separate_debug_file): Fix search of debug files for
7838         remote debuggee.
7839
7840 2019-01-02  Tom Tromey  <tom@tromey.com>
7841
7842         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7843         indentation.
7844         * python/py-frame.c (frapy_older): Remove cast.
7845         (frapy_newer): Likewise.
7846         * python/py-breakpoint.c (local_setattro): Remove cast.
7847         * python/py-arch.c (archpy_name): Remove local variable.
7848         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7849
7850 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7851
7852         * unittests/basic_string_view/element_access/char/empty.cc:
7853         Fix year range in copyright header.
7854
7855 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7856
7857         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7858         Delete.
7859         <operator==>: Update with for removed field.
7860         <hash>: Likewise.
7861         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7862         <isa_features>: ...this.
7863         <abi_features>: New field.
7864         (riscv_isa_flen): Update comment.
7865         (riscv_abi_xlen): New declaration.
7866         (riscv_abi_flen): New declaration.
7867         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7868         isa_features.
7869         (riscv_abi_xlen): New function.
7870         (riscv_isa_flen): Update to get answer from isa_features.
7871         (riscv_abi_flen): New function.
7872         (riscv_has_fp_abi): Update to get answer from abi_features.
7873         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7874         xlen and flen.
7875         (riscv_call_info) <xlen, flen>: Update comment.
7876         (riscv_call_arg_struct): Remove invalid assertions
7877         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7878         is removed.
7879         (riscv_gdbarch_init): Gather isa features and abi features
7880         separately, ensure both match on the gdbarch when reusing an old
7881         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7882         a target with 64-bit float hardware.
7883
7884 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7885
7886         * source.c (search_command_helper): Stop reverse search
7887         when line 1 has been searched.
7888
7889 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7890
7891         * record-full.c (record_full_base_target::close): Rewrite
7892         record_full_core_buf_list free logic.
7893
7894 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7895
7896         * break-catch-syscall.c (print_one_catch_syscall): xfree
7897         the last text.
7898
7899 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7900
7901         * top.c (print_gdb_version): Update Copyright year in version
7902         message.
7903
7904 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7905
7906         Update copyright year range in all GDB files.
7907
7908 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7909
7910         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7911
7912 For older changes see ChangeLog-2018.
7913 \f
7914 Local Variables:
7915 mode: change-log
7916 left-margin: 8
7917 fill-column: 74
7918 version-control: never
7919 coding: utf-8
7920 End:
7921