]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blob - gdb/ChangeLog
Introduce new layout code
[thirdparty/binutils-gdb.git] / gdb / ChangeLog
1 2019-12-11 Tom Tromey <tom@tromey.com>
2
3 * tui/tui-layout.h (class tui_layout_base)
4 (class tui_layout_window, class tui_layout_split): New.
5 * tui/tui-layout.c (tui_get_window_by_name)
6 (tui_layout_window::clone, tui_layout_window::apply)
7 (tui_layout_window::get_sizes, tui_layout_window::add_split)
8 (tui_layout_split::add_window, tui_layout_split::clone)
9 (tui_layout_split::get_sizes)
10 (tui_layout_split::set_weights_from_heights)
11 (tui_layout_split::adjust_size, tui_layout_split::apply): New
12 functions.
13 (tui_layout_split::add_split, tui_layout_split::add_split)
14 (tui_layout_split::set_weights_from_heights)
15 (tui_layout_split::set_weights_from_heights): New functions.
16
17 2019-12-11 Tom Tromey <tom@tromey.com>
18
19 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
20 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
21 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
22 * tui/tui-data.h (struct tui_point): Remove.
23 (struct tui_gen_win_info) <origin>: Remove.
24 <x, y>: New fields.
25 * tui/tui-command.c (tui_cmd_window::resize): Update.
26
27 2019-12-11 Tom Tromey <tom@tromey.com>
28
29 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
30 Implement.
31 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
32 Implement.
33 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
34 method.
35 (struct tui_win_info) <min_height>: Implement.
36
37 2019-12-11 Tom Tromey <tom@tromey.com>
38
39 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
40 (struct tui_win_info) <can_box>: Update.
41
42 2019-12-11 Tom Tromey <tom@tromey.com>
43
44 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
45 method.
46 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
47 method.
48 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
49 method.
50 (struct tui_win_info) <max_height>: Now override.
51
52 2019-12-11 Joel Brobecker <brobecker@adacore.com>
53
54 * NEWS: Create a new section for the next release branch.
55 Rename the section of the current branch, now that it has
56 been cut.
57
58 2019-12-11 Joel Brobecker <brobecker@adacore.com>
59
60 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
61 * version.in: Bump version to 10.0.50.DATE-git.
62
63 2019-12-11 Tom Tromey <tromey@adacore.com>
64
65 PR build/25268:
66 * gdbsupport/thread-pool.c (set_thread_name): New function.
67 (thread_pool::set_thread_count): Don't call pthread_setname_np.
68 (thread_pool::thread_function): Call set_thread_name.
69
70 2019-12-11 Tom Tromey <tromey@adacore.com>
71
72 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
73 bfd_get_signed_8.
74
75 2019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
76
77 * NEWS: Document -raw-values option and the related setting commands.
78 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
79 only set it on when /r is given.
80 * valprint.c (value_print_option_defs): New element raw-values.
81 * Makefile.in: Add the new file.
82
83 2019-12-10 Christian Biesinger <cbiesinger@google.com>
84
85 * gdbsupport/safe-strerror.c: Supress the unused function warning
86 for select_strerror_r.
87
88 2019-12-10 Christian Biesinger <cbiesinger@google.com>
89
90 * config.in: Regenerate.
91 * configure: Regenerate.
92 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
93 safe_strerror instead of strerror.
94 * gdbsupport/common.m4: Don't check for strerror.
95 * gdbsupport/safe-strerror.c: Support both the glibc version
96 of strerror_r and the XSI version.
97
98 2019-12-10 Tom Tromey <tromey@adacore.com>
99
100 * ada-typeprint.c (print_choices): Use a single "?".
101 (print_variant_part): Print "?" if the discriminant name
102 is not known.
103
104 2019-12-10 George Barrett <bob@bob131.so>
105
106 Fix scripted probe breakpoints.
107 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
108 declaration forward.
109 (breakpoint_ops_for_event_location_type)
110 (breakpoint_ops_for_event_location): Add function definitions.
111 (break_command_1, trace_command): Use
112 breakpoint_ops_for_event_location.
113 * breakpoint.h (breakpoint_ops_for_event_location): Add function
114 declarations.
115 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
116 breakpoint_ops_for_event_location.
117 * python/py-breakpoint.c (bppy_init): Use
118 breakpoint_ops_for_event_location.
119
120 2019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
121
122 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
123 when ranking an lvalue argument for an rvalue parameter.
124
125 2019-12-08 Wataru Ashihara <wataash@wataash.com>
126
127 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
128 template argument for scoped_restore_tmpl from bool to int.
129
130 2019-12-07 Keith Seitz <keiths@redhat.com>
131
132 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
133 (build_id_to_debug_bfd): Make static, rewriting to use
134 build_id_to_bfd_suffix.
135 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
136 adding `suffix' parameter. Append SUFFIX to file names
137 when searching for matching files.
138 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
139 (build_id_to_exec_bfd): Likewise.
140 * build-id.h (build_id_to_debug_bfd): Clarify that function
141 searches for BFD of debug info file.
142 (build_id_to_exec_bfd): Declare.
143 * corelow.c: Include build-id.h.
144 (locate_exec_from_corefile_build_id): New function.
145 (core_target_open): If no executable BFD is found,
146 search for a core file BFD using build-id.
147
148 2019-12-06 Christian Biesinger <cbiesinger@google.com>
149
150 * bcache.c: Put in namespace gdb.
151 * bcache.h: Likewise.
152 * gdbtypes.c (check_types_worklist): Update.
153 (types_deeply_equal): Update.
154 * macrotab.c (struct macro_table) <bcache>: Update.
155 (new_macro_table): Update.
156 * macrotab.h (struct bcache): Put this forward declaration
157 inside namespace gdb.
158 (new_macro_table): Update.
159 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
160 Update.
161 <macro_cache>: Update.
162 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
163
164 2019-12-06 Tom de Vries <tdevries@suse.de>
165
166 PR symtab/24971
167 * block.c (best_symbol, better_symbol): New function.
168 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
169 decl.
170
171 2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
172
173 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
174 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
175 for ranking see-through reference cases.
176
177 2019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
178 * stack.c (faas_command): Check a command is provided.
179 * thread.c (taas_command, tfaas_command): Likewise.
180
181 2019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
182 * inferior.c (prune_inferiors): Only call delete_inferior,
183 Do not modify the inferior list.
184
185 2019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
186
187 * c-exp.y: Update calls to lookup_typename,
188 lookup_signed_typename and lookup_unsigned_typename.
189 * c-lang.c (evaluate_subexp_c): Likewise.
190 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
191 Likewise.
192 * eval.c (binop_promote): Likewise.
193 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
194 (lookup_unsigned_typename): Likewise.
195 (lookup_signed_typename): Likewise.
196 * gdbtypes.h (lookup_unsigned_typename): Likewise.
197 (lookup_signed_typename): Likewise.
198 (lookup_typename): Likewise.
199 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
200 lookup_typename, lookup_signed_typename,
201 lookup_unsigned_typename.
202 * m2-exp.y: Likewise.
203 * printcmd.c (printf_wide_c_string): Likewise.
204 (ui_printf): Likewise.
205 * python/py-type.c (typy_lookup_typename): Likewise.
206 * python/py-xmethods.c (python_xmethod_worker::invoke):
207 Likewise.
208 * rust-exp.y: Likewise.
209
210 2019-12-04 Christian Biesinger <cbiesinger@google.com>
211
212 * configure.nat (obsd64): Add missing files x86-nat.o and
213 nat/x86-dregs.o.
214
215 2019-12-04 Tom Tromey <tom@tromey.com>
216
217 * valprint.c (val_print_string): Use metadata_style.
218 * go-valprint.c (print_go_string): Use metadata style.
219 * p-valprint.c (pascal_object_print_static_field): Use metadata
220 style.
221 * cp-valprint.c (cp_print_static_field): Use metadata style.
222
223 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
224 Chris January <chris.january@arm.com>
225
226 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
227 tokens.
228 (typebase): New patterns for complex, single/double precision, and
229 single/double complex.
230 (f77_keywords): Change token for complex keyword, and add single,
231 double, and precision keywords.
232
233 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
234
235 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
236 "info io_registers".
237
238 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
239
240 * regcache.c (cooked_read_test): Initialize thread list of
241 mock_inferior.
242
243 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
244
245 * aarch64-linux-tdep.c: Remove includes.
246
247 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
248
249 * aarch64-tdep.c: Remove includes.
250
251 2019-12-04 Simon Marchi <simon.marchi@efficios.com>
252
253 * filtered-iterator.h (filtered_iterator) <operator==,
254 operator!=>: Compare wrapped iterators, not wrapped pointers.
255 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
256 unittests/filtered_iterator-selftests.c.
257 * unittests/filtered_iterator-selftests.c: New file.
258
259 2019-12-04 Tom Tromey <tromey@adacore.com>
260
261 * gdbtypes.c (create_range_type): Inherit endianity
262 from base type.
263
264 2019-12-04 Tom Tromey <tromey@adacore.com>
265
266 * ada-lang.c (decode_constrained_packed_array)
267 (ada_value_assign, value_assign_to_component): Update.
268 * dwarf2loc.c (rw_pieced_value, access_memory)
269 (dwarf2_compile_expr_to_ax): Update.
270 * dwarf2read.c (dwarf2_add_field): Update.
271 * eval.c (evaluate_subexp_standard): Update.
272 * gdbarch.c, gdbarch.h: Rebuild.
273 * gdbarch.sh (bits_big_endian): Remove.
274 * gdbtypes.h (union field_location): Update comment.
275 * target-descriptions.c (make_gdb_type): Update.
276 * valarith.c (value_bit_index): Update.
277 * value.c (struct value) <bitpos>: Update comment.
278 (unpack_bits_as_long, modify_field): Update.
279 * value.h (value_bitpos): Update comment.
280
281 2019-12-04 Tom Tromey <tromey@adacore.com>
282
283 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
284 endian-ness.
285
286 2019-12-04 Tom Tromey <tromey@adacore.com>
287
288 * dwarf2read.c (dwarf2_init_float_type)
289 (dwarf2_init_complex_target_type): Add byte_order parameter.
290 (read_base_type): Compute byte order earlier.
291 * gdbtypes.c (init_float_type): Add byte_order parameter.
292 * gdbtypes.h (init_float_type): Add byte_order parameter.
293
294 2019-12-04 Tom Tromey <tromey@adacore.com>
295
296 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
297
298 2019-12-04 Tom Tromey <tromey@adacore.com>
299
300 * dwarf2read.c (process_structure_scope): Initialize
301 "discr_offset".
302
303 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
304
305 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
306 add it into the search spec.
307 (parse_max_results_option): New function.
308 (mi_info_functions_or_variables): Parse -max-results flag and pass
309 it to mi_symbol_info.
310 (mi_cmd_symbol_info_modules): Likewise.
311 (mi_cmd_symbol_info_types): Likewise.
312 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
313 return type to bool, change result container into a set, and don't
314 add new results if we have enough already.
315 (global_symbol_searcher::add_matching_msymbols): Change return
316 type to bool, and don't add new results if we have enough already.
317 (sort_search_symbols_remove_dups): Delete.
318 (global_symbol_searcher::search): Early exit from search loop when
319 we have enough results. Use a std::set to collect the results
320 from calling add_matching_symbols.
321 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
322 member function.
323 (global_symbol_searcher) <m_max_search_results>: New member
324 variable.
325 (global_symbol_searcher) <add_matching_symbols>: Update header
326 comment and change return type to bool.
327 (global_symbol_searcher) <add_matching_msymbols>: Update header
328 comment and change return type to bool.
329
330 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
331
332 * symtab.c (symbol_search::compare_search_syms): Update header
333 comment.
334 (global_symbol_searcher::is_suitable_msymbol): New function.
335 (global_symbol_searcher::expand_symtabs): New function.
336 (global_symbol_searcher::add_matching_symbols): New function.
337 (global_symbol_searcher::add_matching_msymbols): New function.
338 (global_symbol_searcher::search): Move most of the content
339 into the new functions above, and call them as needed.
340 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
341 function.
342 (global_symbol_searcher) <add_matching_symbols>: New member
343 function.
344 (global_symbol_searcher) <add_matching_msymbols>: New member
345 function.
346 (global_symbol_searcher) <is_suitable_msymbol>: New member
347 function.
348
349 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
350
351 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
352 -symbol-info-module-variables entries.
353 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
354 (mi_cmd_symbol_info_module_variables): Declare.
355 * mi/mi-symbol-cmds.c
356 (module_symbol_search_iterator): New typedef.
357 (output_module_symbols_in_single_module_and_file): New function.
358 (output_module_symbols_in_single_module): New function.
359 (mi_info_module_functions_or_variables): New function.
360 (mi_cmd_symbol_info_module_functions): New function.
361 (mi_cmd_symbol_info_module_variables): New function.
362 * NEWS: Mention new MI command.
363
364 2019-12-03 Christian Biesinger <cbiesinger@google.com>
365
366 * bcache.c (hash): Remove.
367 (hash_continue): Remove.
368 * bcache.h (hash): Remove.
369 (hash_continue): Remove.
370 (struct bcache) <ctor>: Update.
371 * psymtab.c (psymbol_hash): Update.
372 * stabsread.c (hashname): Update.
373 * utils.h (fast_hash): Add an argument for a start value,
374 defaulting to zero.
375
376 2019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
377 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
378 (destroy_block_symbol_cache): New function.
379 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
380 (resize_symbol_cache): Likewise.
381
382 2019-12-02 Tom Tromey <tom@tromey.com>
383
384 * unittests/tui-selftests.c (run_tests): Make conditional.
385 (_initialize_tui_selftest): Make conditional.
386
387 2019-12-02 Christian Biesinger <cbiesinger@google.com>
388
389 * aix-thread.c (debug_aix_thread): Change type to bool.
390
391 2019-12-02 Luis Machado <luis.machado@linaro.org>
392
393 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
394
395 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
396
397 * dwarf2read.c (read_tag_string_type): Read the fields required to
398 make a dynamic string, and possibly create a dynamic range for the
399 string.
400 (attr_to_dynamic_prop): Setup is_reference based on the type of
401 attribute being processed.
402 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
403 (resolve_dynamic_array): Rename to...
404 (resolve_dynamic_array_or_string): ...this, update header comment,
405 and accept TYPE_CODE_STRING.
406 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
407
408 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
409
410 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
411 of its implementation from...
412 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
413 the new function.
414
415 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
416
417 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
418 create a range with stride where appropriate.
419 * f-valprint.c: Include 'gdbarch.h'.
420 (f77_print_array_1): Take the stride into account when walking the
421 array. Also convert the stride into addressable units.
422 * gdbtypes.c (create_range_type): Initialise the stride to
423 constant zero.
424 (create_range_type_with_stride): New function, initialise the
425 range as normal, and then setup the stride.
426 (has_static_range): Include the stride here. Also change the
427 return type to bool.
428 (create_array_type_with_stride): Consider the range stride if the
429 array isn't given its own stride.
430 (resolve_dynamic_range): Resolve the stride if needed.
431 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
432 (struct range_bounds) <flag_is_byte_stride>: New member variable.
433 (TYPE_BIT_STRIDE): Define.
434 (TYPE_ARRAY_BIT_STRIDE): Define.
435 (create_range_type_with_stride): Declare.
436 * valarith.c (value_subscripted_rvalue): Take range stride into
437 account when walking the array.
438
439 2019-12-01 Tom Tromey <tom@tromey.com>
440
441 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
442 specially.
443
444 2019-12-01 Tom Tromey <tom@tromey.com>
445
446 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
447 \0.
448 * unittests/tui-selftests.c: New file.
449 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
450
451 2019-12-01 Tom Tromey <tom@tromey.com>
452
453 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
454
455 2019-12-01 Tom Tromey <tom@tromey.com>
456
457 * NEWS: Document new settings.
458 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
459 * tui/tui-win.c (_initialize_tui_win): Add border style
460 observers.
461 * tui/tui-io.h (tui_apply_style): Declare.
462 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
463 longer static.
464 (apply_ansi_escape, tui_set_reverse_mode): Update.
465 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
466 Add "skip_intensity" parameter.
467 <changed>: New member.
468 <do_set_value>: Declare.
469 (tui_border_style, tui_active_border_style): Declare.
470 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
471 globals.
472 (cli_style_option): Initialize "changed".
473 (cli_style_option::do_set_value): New function.
474 (cli_style_option::add_setshow_commands): Add "skip_intensity"
475 parameter. Update.
476 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
477 (_initialize_cli_style): Update. Create TUI border style
478 commands.
479
480 2019-12-01 Tom Tromey <tom@tromey.com>
481
482 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
483 parameter.
484 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
485 parameter.
486 * tui/tui-win.h (compact_source): Declare.
487 * tui/tui-win.c (compact_source): New global.
488 (tui_set_compact_source, tui_show_compact_source): New functions.
489 (_initialize_tui_win): Add "compact-source" setting.
490 * tui/tui-source.c (tui_source_window::set_contents): Handle
491 compact_source setting.
492 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
493 * NEWS: Document new setting.
494
495 2019-11-30 Tom Tromey <tom@tromey.com>
496
497 * dwarf2read.c (dwarf2_add_field): Include field offset when
498 computing variant part length.
499
500 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
501 * NEWS: Mention define-prefix. Tell that command names can now
502 contain a . character.
503
504 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
505
506 * command.h (valid_cmd_char_p): Declare.
507 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
508 the check of valid command char.
509 (find_command_name_length, valid_user_defined_cmd_name_p): Use
510 valid_cmd_char_p.
511 * cli/cli-script.c (validate_comname): Likewise.
512 * completer.c (gdb_completer_command_word_break_characters):
513 Do not remove . from the word break char, update comments.
514 (complete_line_internal_1): Use valid_cmd_char_p.
515 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
516 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
517
518 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
519
520 * cli/cli-script.c (do_define_command): Ensure a redefined
521 prefix command is kept as a prefix command.
522 (define_prefix_command): New function.
523 (show_user_1): Report user defined prefixes.
524 (_initialize_cli_script): Create the new 'define-prefix' command.
525 Add completers for 'define' and 'document'.
526 * top.c (execute_command): If command is a user-defined prefix only
527 command, report the list of commands for this prefix command.
528
529 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
530
531 * valops.c (find_oload_champ): Improve debug output.
532
533 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
534
535 * valops.c (find_oload_champ): Print part of debug messages
536 before the badness vector is std::move'd.
537
538 2019-11-28 Tom Tromey <tom@tromey.com>
539
540 * value.c (creal_internal_fn): Fix comment.
541
542 2019-11-28 Tom Tromey <tom@tromey.com>
543
544 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
545 flag_bound_evaluated>: Now unsigned.
546
547 2019-11-28 Tom Tromey <tom@tromey.com>
548
549 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
550 declare.
551
552 2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
553
554 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
555 debug output.
556 * jit.c (jit_unregister_code): Add debug print to match
557 `jit_register_code`.
558
559 2019-11-27 Christian Biesinger <cbiesinger@google.com>
560
561 * NEWS: Mention the new multithreaded symbol loading.
562
563 2019-11-27 Christian Biesinger <cbiesinger@google.com>
564
565 * maint.c (n_worker_threads): Default to 0.
566 (worker_threads_disabled): New function.
567 * maint.h (worker_threads_disabled): New function.
568 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
569 here if worker_threads_disabled () is true.
570 (minimal_symbol_reader::install): Skip all threading if
571 worker_threads_disabled () is true.
572
573 2019-11-27 Christian Biesinger <cbiesinger@google.com>
574
575 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
576 hash code if possible.
577 (add_minsym_to_demangled_hash_table): Likewise.
578 (minimal_symbol_reader::install): Compute the hash codes for msymbol
579 on the background thread.
580 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
581 Add these fields.
582
583 2019-11-27 Christian Biesinger <cbiesinger@google.com>
584
585 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
586 of the mangled name on the background thread.
587 * symtab.c (symbol_set_names): Allow passing in the hash of the
588 linkage_name.
589 * symtab.h (symbol_set_names): Likewise.
590
591 2019-11-27 Kevin Buettner <kevinb@redhat.com>
592
593 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
594 physnames are computed for inherited DIEs.
595
596 2019-11-27 Tom Tromey <tromey@adacore.com>
597
598 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
599 backslashes.
600 * cp-support.c: Remove unnecessary backslashes.
601
602 2019-11-27 Christian Biesinger <cbiesinger@google.com>
603
604 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
605 with sym->set_linkage_name.
606 * coffread.c (coff_read_enum_type): Likewise.
607 * mdebugread.c (parse_symbol): Likewise.
608 * stabsread.c (patch_block_stabs): Likewise.
609 (define_symbol): Likewise.
610 (read_enum_type): Likewise.
611 (common_block_end): Likewise.
612 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
613 function.
614 (SYMBOL_SET_LINKAGE_NAME): Remove.
615 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
616 with sym->set_linkage_name.
617
618 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
619
620 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
621 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
622 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
623 * NEWS: Mention new MI command.
624
625 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
626
627 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
628 '-symbol-info-types', and '-symbol-info-variables'.
629 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
630 (mi_cmd_symbol_info_types): Declare.
631 (mi_cmd_symbol_info_variables): Declare.
632 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
633 (output_debug_symbol): New function.
634 (output_nondebug_symbol): New function.
635 (mi_symbol_info): New function.
636 (mi_info_functions_or_variables): New function.
637 (mi_cmd_symbol_info_functions): New function.
638 (mi_cmd_symbol_info_types): New function.
639 (mi_cmd_symbol_info_variables): New function.
640 * NEWS: Mention new commands.
641
642 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
643
644 * symtab.c (symbol_to_info_string): New function, most content
645 moved from print_symbol_info, but updated to return a std::string.
646 (print_symbol_info): Update to use symbol_to_info_string and print
647 returned string.
648 * symtab.h (symbol_to_info_string): Declare new function.
649
650 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
651
652 * python/python.c (gdbpy_rbreak): Convert to using
653 global_symbol_searcher.
654 * symtab.c (file_matches): Convert return type to bool, change
655 file list to std::vector, update header comment.
656 (search_symbols): Rename to...
657 (global_symbol_searcher::search): ...this and update now its
658 a member function of global_symbol_searcher. Take account of the
659 changes to file_matches.
660 (symtab_symbol_info): Convert to using global_symbol_searcher.
661 (rbreak_command): Likewise.
662 (search_module_symbols): Likewise.
663 * symtab.h (enum symbol_search): Update comment.
664 (search_symbols): Remove declaration.
665 (class global_symbol_searcher): New class.
666
667 2019-11-26 Tom Tromey <tromey@adacore.com>
668
669 * cp-support.c (_initialize_cp_support): Conditionally initialize
670 gdb_demangle_attempt_core_dump.
671
672 2019-11-26 Tom Tromey <tom@tromey.com>
673
674 * python/py-function.c (fnpy_init): Update.
675 * value.h (add_internal_function): Adjust declaration.
676 * value.c (function_destroyer): Remove.
677 (do_add_internal_function): Don't set destroyer or copy name.
678 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
679 Set name_allocated.
680 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
681 (cmdpy_init): Set name_allocated.
682 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
683 member.
684 (~cmd_list_element): Free "name" if needed.
685
686 2019-11-26 Tom Tromey <tom@tromey.com>
687
688 * value.h (add_internal_function): Add new overload. Move
689 documentation from value.h.
690 * value.c (do_add_internal_function): New function.
691 (add_internal_function): Use it. Add new overload.
692 (function_destroyer): Don't free doc.
693 * python/py-function.c (fnpy_init): Update.
694
695 2019-11-26 Tom Tromey <tom@tromey.com>
696
697 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
698 (cmdpy_init): Set "doc_allocated".
699
700 2019-11-26 Tom Tromey <tom@tromey.com>
701
702 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
703 name of worker thread.
704 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
705 pthread_setname_np.
706 * configure, config.in: Rebuild.
707
708 2019-11-26 Tom Tromey <tom@tromey.com>
709
710 * python/python.c (class gdbpy_gil): New.
711 (struct gdbpy_event): Add constructor, destructor, operator().
712 (gdbpy_post_event): Use run_on_main_thread.
713 (gdbpy_initialize_events): Remove.
714 (do_start_initialization): Update.
715
716 2019-11-26 Tom Tromey <tom@tromey.com>
717
718 * NEWS: Add entry.
719 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
720 commands. Call update_thread_pool_size.
721 (update_thread_pool_size, maintenance_set_worker_threads): New
722 functions.
723 (n_worker_threads): New global.
724
725 2019-11-26 Christian Biesinger <cbiesinger@google.com>
726 Tom Tromey <tom@tromey.com>
727
728 * minsyms.c (minimal_symbol_reader::install): Use
729 parallel_for_each.
730 * gdbsupport/parallel-for.h: New file.
731 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
732
733 2019-11-26 Christian Biesinger <cbiesinger@google.com>
734 Tom Tromey <tom@tromey.com>
735
736 * gdbsupport/thread-pool.h: New file.
737 * gdbsupport/thread-pool.c: New file.
738 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
739 (HFILES_NO_SRCDIR): Add thread-pool.h.
740
741 2019-11-26 Tom Tromey <tom@tromey.com>
742
743 * event-top.h (thread_local_segv_handler): Declare.
744 * event-top.c (thread_local_segv_handler): New global.
745 (install_handle_sigsegv, handle_sigsegv): New functions.
746 (async_init_signals): Install SIGSEGV handler.
747 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
748 thread-local.
749 (report_failed_demangle): New function.
750 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
751 handler-setting code, instead use segv_handler. Run warning code
752 on main thread.
753
754 2019-11-26 Tom Tromey <tom@tromey.com>
755
756 * run-on-main-thread.c: New file.
757 * run-on-main-thread.h: New file.
758 * unittests/main-thread-selftests.c: New file.
759 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
760 main-thread-selftests.c.
761 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
762 (COMMON_SFILES): Add run-on-main-thread.c.
763
764 2019-11-26 Tom Tromey <tom@tromey.com>
765
766 * main.c (setup_alternate_signal_stack): Remove.
767 (captured_main_1): Use gdb::alternate_signal_stack.
768 * gdbsupport/alt-stack.h: New file.
769
770 2019-11-26 Tom Tromey <tom@tromey.com>
771
772 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
773 Remove comment.
774 (save_original_signals_state, restore_original_signals_state): Use
775 gdb_sigmask.
776 * linux-nat.c (block_child_signals, restore_child_signals_mask)
777 (_initialize_linux_nat): Use gdb_sigmask.
778 * guile/guile.c (_initialize_guile): Use block_signals.
779 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
780 * gdbsupport/gdb-sigmask.h: New file.
781 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
782 * cp-support.c (gdb_demangle): Use gdb_sigmask.
783 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
784 pthread_sigmask.
785 * configure, config.in: Rebuild.
786 * gdbsupport/block-signals.h: New file.
787
788 2019-11-26 Tom Tromey <tom@tromey.com>
789
790 * acinclude.m4: Include ax_pthread.m4.
791 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
792 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
793 (CLIBS): Use PTHREAD_LIBS.
794 (aclocal_m4_deps): Add ax_pthread.m4.
795 * config.in, configure: Rebuild.
796 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
797
798 2019-11-26 Tom Tromey <tom@tromey.com>
799
800 * symtab.h (struct minimal_symbol) <name_set>: New member.
801 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
802 Don't call symbol_set_names.
803 (minimal_symbol_reader::install): Call symbol_set_names.
804
805 2019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
806
807 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
808 restore_active_ext_lang, as GIL is needed for (indirectly)
809 called PyOS_InterruptOccurred.
810
811 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
812
813 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
814 definition.
815
816 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
817
818 * remote-sim.c (simulator_command): Make static, remove
819 declaration.
820
821 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
822
823 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
824 static.
825 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
826 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
827 (main): Likewise.
828 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
829 (main): Likewise.
830 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
831 (main): Likewise.
832 * unittests/basic_string_view/element_access/char/1.cc (test01):
833 Likewise.
834 (main): Likewise.
835 * unittests/basic_string_view/element_access/char/empty.cc (main):
836 Likewise.
837 * unittests/basic_string_view/element_access/char/front_back.cc
838 (test01): Likewise.
839 (main): Likewise.
840 * unittests/basic_string_view/inserters/char/2.cc (test05):
841 Likewise.
842 (main): Likewise.
843 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
844 (test01): Likewise.
845 (main): Likewise.
846 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
847 (test01): Likewise.
848 (main): Likewise.
849 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
850 Likewise.
851 * unittests/basic_string_view/operations/compare/char/1.cc
852 (test01): Likewise.
853 (main): Likewise.
854 * unittests/basic_string_view/operations/compare/char/13650.cc
855 (test01): Likewise.
856 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
857 Likewise.
858 (main): Likewise.
859 * unittests/basic_string_view/operations/data/char/1.cc (test01):
860 Likewise.
861 (main): Likewise.
862 * unittests/basic_string_view/operations/find/char/1.cc (test01):
863 Likewise.
864 (main): Likewise.
865 * unittests/basic_string_view/operations/find/char/2.cc (test02):
866 Likewise.
867 (main): Likewise.
868 * unittests/basic_string_view/operations/find/char/3.cc (test03):
869 Likewise.
870 (main): Likewise.
871 * unittests/basic_string_view/operations/find/char/4.cc (main):
872 Likewise.
873 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
874 Likewise.
875 (main): Likewise.
876 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
877 Likewise.
878 (main): Likewise.
879 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
880 Likewise.
881 (main): Likewise.
882 * unittests/basic_string_view/operations/substr/char/1.cc
883 (test01): Likewise.
884 (main): Likewise.
885 * unittests/basic_string_view/operators/char/2.cc (main):
886 Likewise.
887 * unittests/optional/assignment/1.cc (test): Likewise.
888 * unittests/optional/assignment/2.cc (test): Likewise.
889 * unittests/optional/assignment/3.cc (test): Likewise.
890 * unittests/optional/assignment/4.cc (test): Likewise.
891 * unittests/optional/assignment/5.cc (test): Likewise.
892 * unittests/optional/assignment/6.cc (test): Likewise.
893 * unittests/optional/assignment/7.cc (test): Likewise.
894 * unittests/optional/cons/copy.cc (test): Likewise.
895 * unittests/optional/cons/default.cc (test): Likewise.
896 * unittests/optional/cons/move.cc (test): Likewise.
897 * unittests/optional/cons/value.cc (test): Likewise.
898 * unittests/optional/in_place.cc (test): Likewise.
899 * unittests/optional/observers/1.cc (test): Likewise.
900 * unittests/optional/observers/2.cc (test): Likewise.
901
902 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
903
904 * tui-win.h (tui_set_var_cmd): Remove.
905 * tui-win.c (tui_set_var_cmd): Make static.
906
907 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
908
909 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
910 rbreak_command_wrapper): Remove.
911 * symtab.c (rbreak_command_wrapper): Remove.
912
913 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
914
915 * inferior.h (info_terminal_command): Remove declaration.
916 * inflow.c (info_terminal_command): Make static.
917
918 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
919
920 * inferior.c (exit_inferior_silent): Remove.
921
922 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
923
924 * dictionary.c (dict_empty, mdict_empty): Remove.
925 * dictionary.c (mdict_empty): Remove.
926
927 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
928
929 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
930 (arc_insn_get_memory_offset): Likewise.
931 (arc_insn_dump): Likewise.
932 * cp-support.c (test_cp_symbol_name_matches): Likewise.
933 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
934 * dictionary.c (dict_iterator_next): Likewise.
935 (dict_iter_match_first): Likewise.
936 (dict_iter_match_next): Likewise.
937 * f-lang.c (evaluate_subexp_f): Likewise.
938 * hppa-tdep.c (hppa_read_pc): Likewise.
939 * i386-tdep.c (i386_floatformat_for_type): Likewise.
940 * parse.c (write_exp_elt_msym): Likewise.
941 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
942 * remote.c (remote_packet_size): Likewise.
943 (remote_notif_stop_parse): Likewise.
944 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
945 * s12z-tdep.c (s12z_disassemble_info): Likewise.
946 * source.c (prepare_path_for_appending): Likewise.
947 * sparc64-linux-tdep.c
948 (sparc64_linux_handle_segmentation_fault); Likewise.
949 * stack.c (frame_selection_by_function_completer): Likewise.
950
951 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
952
953 * completer.c (set_gdb_completion_word_break_characters):
954 Remove.
955
956 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
957
958 * dwarf-index-write.c: Include dwarf-index-write.h.
959 * mi/mi-interp.c: Include mi/mi-interp.h.
960
961 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
962
963 * aarch32-tdep.c: Include aarch32-tdep.h.
964 * aarch32-tdep.h: Forward-declare struct target_desc.
965
966 2019-11-26 Christian Biesinger <cbiesinger@google.com>
967
968 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
969 strerror.
970 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
971 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
972
973 2019-11-25 Tom de Vries <tdevries@suse.de>
974
975 * contrib/words.sh: Add -c option.
976
977 2019-11-25 Christian Biesinger <cbiesinger@google.com>
978
979 * solib.c (solib_find_1): Change int to bool.
980 (exec_file_find): Change int to bool.
981 (solib_find): Change int to bool.
982 (solib_read_symbols): Change int to bool.
983 (solib_used): Change int to bool.
984 (solib_add): Change int to bool.
985 (info_sharedlibrary_command): Change int to bool.
986 (solib_contains_address_p): Change int to bool.
987 (solib_keep_data_in_core): Change int to bool.
988 (in_solib_dynsym_resolve_code): Change int to bool.
989 (reload_shared_libraries_1): Change int to bool.
990 (gdb_sysroot_changed): Change int to bool.
991 * solib.h (solib_read_symbols): Change int to bool.
992 (solib_contains_address_p): Change int to bool.
993 (solib_keep_data_in_core): Change int to bool.
994 (in_solib_dynsym_resolve_code): Change int to bool.
995 (libpthread_name_p): Change int to bool.
996
997 2019-11-25 Luis Machado <luis.machado@linaro.org>
998
999 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1000 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1001 (remote_packet_max_chars): New static global.
1002 (show_remote_packet_max_chars): New function.
1003 (remote_target::putpkt_binary): Adjust to use new
1004 remote_packet_max_chars option.
1005 (remote_target::getpkt_or_notif_sane_1): Likewise.
1006 (_initialize_remote): Register new remote-packet-max-chars option.
1007
1008 2019-11-24 Simon Marchi <simon.marchi@efficios.com>
1009
1010 * m68k-linux-nat.c: Include gdbarch.h.
1011
1012 2019-11-24 Tom Tromey <tom@tromey.com>
1013
1014 * symfile.c (read_symbols): Update.
1015 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1016 bool.
1017 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1018 (psym_lookup_symbol, psym_find_last_source_symtab)
1019 (psym_forget_cached_source_info, psym_print_stats)
1020 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1021 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1022 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1023 (psym_find_compunit_symtab_by_address)
1024 (maintenance_print_psymbols, maintenance_info_psymtabs)
1025 (maintenance_check_psymtabs): Update.
1026 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1027 bool.
1028
1029 2019-11-22 Tom Tromey <tom@tromey.com>
1030
1031 * observable.h: Update comments.
1032
1033 2019-11-22 Tom Tromey <tromey@adacore.com>
1034
1035 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1036 (print_ada_task_info): Don't try to fetch thread id if task is not
1037 alive.
1038
1039 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1040
1041 * ada-exp.y: Update.
1042 * ada-lang.c (sort_choices): Update.
1043 (ada_print_symbol_signature): Update.
1044 (resolve_subexp): Update.
1045 (ada_parse_renaming): Update.
1046 (ada_read_renaming_var_value): Update.
1047 (lesseq_defined_than): Update.
1048 (remove_extra_symbols): Update.
1049 (remove_irrelevant_renamings): Update.
1050 (ada_add_block_symbols): Update.
1051 (ada_collect_symbol_completion_matches): Update.
1052 (ada_is_renaming_symbol): Update.
1053 (aggregate_assign_from_choices): Update.
1054 (ada_evaluate_subexp): Update.
1055 (ada_has_this_exception_support): Update.
1056 (ada_is_non_standard_exception_sym): Update.
1057 (ada_add_exceptions_from_frame): Update.
1058 (ada_add_global_exceptions): Update.
1059 (ada_print_subexp): Update.
1060 * ax-gdb.c (gen_var_ref): Update.
1061 (gen_maybe_namespace_elt): Update.
1062 (gen_expr_for_cast): Update.
1063 (gen_expr): Update.
1064 * block.h: Update.
1065 * blockframe.c (find_pc_partial_function): Update.
1066 * breakpoint.c (print_breakpoint_location): Update.
1067 (update_static_tracepoint): Update.
1068 * btrace.c (ftrace_print_function_name): Update.
1069 (ftrace_function_switched): Update.
1070 * buildsym.c (find_symbol_in_list): Update.
1071 * c-exp.y: Update.
1072 * c-typeprint.c (c_print_typedef): Update.
1073 (c_type_print_template_args): Update.
1074 * cli/cli-cmds.c (edit_command): Update.
1075 (list_command): Update.
1076 (print_sal_location): Update.
1077 * coffread.c (patch_opaque_types): Update.
1078 (process_coff_symbol): Update.
1079 (coff_read_enum_type): Update.
1080 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1081 (convert_one_symbol): Update.
1082 (hash_symname): Update.
1083 (eq_symname): Update.
1084 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1085 * compile/compile-cplus-types.c (debug_print_scope): Update.
1086 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1087 * compile/compile-object-load.c (get_out_value_type): Update.
1088 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1089 (search_symbol_list): Update.
1090 (cp_lookup_symbol_imports_or_template): Update.
1091 * cp-support.c (overload_list_add_symbol): Update.
1092 * ctfread.c (psymtab_to_symtab): Update.
1093 * dbxread.c (cp_set_block_scope): Update.
1094 * dictionary.c (iter_match_first_hashed): Update.
1095 (iter_match_next_hashed): Update.
1096 (insert_symbol_hashed): Update.
1097 (iter_match_next_linear): Update.
1098 * dictionary.h: Update.
1099 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1100 (locexpr_describe_location_piece): Update.
1101 (locexpr_describe_location_1): Update.
1102 (locexpr_generate_c_location): Update.
1103 (loclist_describe_location): Update.
1104 (loclist_generate_c_location): Update.
1105 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1106 (read_func_scope): Update.
1107 (process_enumeration_scope): Update.
1108 (new_symbol): Update.
1109 (dwarf2_const_value): Update.
1110 (dwarf2_symbol_mark_computed): Update.
1111 * eval.c (evaluate_funcall): Update.
1112 (evaluate_subexp_standard): Update.
1113 * expprint.c (print_subexp_standard): Update.
1114 (dump_subexp_body_standard): Update.
1115 * f-valprint.c (info_common_command_for_block): Update.
1116 * findvar.c (get_hosting_frame): Update.
1117 (default_read_var_value): Update.
1118 * go-lang.c (go_symbol_package_name): Update.
1119 * guile/scm-block.c (bkscm_print_block_smob): Update.
1120 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1121 (gdbscm_symbol_name): Update.
1122 (gdbscm_symbol_linkage_name): Update.
1123 (gdbscm_symbol_print_name): Update.
1124 * infcall.c (get_function_name): Update.
1125 * infcmd.c (jump_command): Update.
1126 (finish_command): Update.
1127 * infrun.c (insert_exception_resume_breakpoint): Update.
1128 * linespec.c (canonicalize_linespec): Update.
1129 (create_sals_line_offset): Update.
1130 (convert_linespec_to_sals): Update.
1131 (complete_label): Update.
1132 (find_label_symbols_in_block): Update.
1133 * m2-typeprint.c (m2_print_typedef): Update.
1134 * mdebugread.c (mdebug_reg_to_regnum): Update.
1135 (parse_symbol): Update.
1136 (mylookup_symbol): Update.
1137 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1138 (list_args_or_locals): Update.
1139 * objc-lang.c (compare_selectors): Update.
1140 (info_selectors_command): Update.
1141 (compare_classes): Update.
1142 (info_classes_command): Update.
1143 (find_imps): Update.
1144 * p-typeprint.c (pascal_print_typedef): Update.
1145 * printcmd.c (build_address_symbolic): Update.
1146 (info_address_command): Update.
1147 (print_variable_and_value): Update.
1148 * python/py-framefilter.c (extract_sym): Update.
1149 (py_print_single_arg): Update.
1150 * python/py-symbol.c (sympy_str): Update.
1151 (sympy_get_name): Update.
1152 (sympy_get_linkage_name): Update.
1153 * python/python.c (gdbpy_rbreak): Update.
1154 * record-btrace.c (btrace_get_bfun_name): Update.
1155 (btrace_call_history): Update.
1156 * rust-lang.c (rust_print_typedef): Update.
1157 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1158 * stabsread.c (stab_reg_to_regnum): Update.
1159 (define_symbol): Update.
1160 (read_enum_type): Update.
1161 (common_block_end): Update.
1162 (cleanup_undefined_types_1): Update.
1163 (scan_file_globals): Update.
1164 * stack.c (print_frame_arg): Update.
1165 (print_frame_args): Update.
1166 (find_frame_funname): Update.
1167 (info_frame_command_core): Update.
1168 (iterate_over_block_locals): Update.
1169 (print_block_frame_labels): Update.
1170 (do_print_variable_and_value): Update.
1171 (iterate_over_block_arg_vars): Update.
1172 (return_command): Update.
1173 * symmisc.c (dump_symtab_1): Update.
1174 (print_symbol): Update.
1175 * symtab.c (eq_symbol_entry): Update.
1176 (symbol_cache_dump): Update.
1177 (lookup_language_this): Update.
1178 (find_pc_sect_line): Update.
1179 (skip_prologue_sal): Update.
1180 (symbol_search::compare_search_syms): Update.
1181 (treg_matches_sym_type_name): Update.
1182 (search_symbols): Update.
1183 (print_symbol_info): Update.
1184 (rbreak_command): Update.
1185 (completion_list_add_symbol): Update.
1186 (find_gnu_ifunc): Update.
1187 (get_symbol_address): Update.
1188 (search_module_symbols): Update.
1189 (info_module_subcommand): Update.
1190 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1191 (SYMBOL_LINKAGE_NAME): Remove.
1192 (SYMBOL_DEMANGLED_NAME): Remove.
1193 (SYMBOL_PRINT_NAME): Remove.
1194 (SYMBOL_SEARCH_NAME): Remove.
1195 * tracepoint.c (set_traceframe_context): Update.
1196 (validate_actionline): Update.
1197 (collection_list::collect_symbol): Update.
1198 (encode_actions_1): Update.
1199 (info_scope_command): Update.
1200 (print_one_static_tracepoint_marker): Update.
1201 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1202 * valops.c (address_of_variable): Update.
1203 (find_overload_match): Update.
1204 (find_oload_champ): Update.
1205
1206 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1207
1208 * ada-lang.c (ada_lookup_simple_minsym): Update.
1209 (ada_collect_symbol_completion_matches): Update.
1210 * ada-tasks.c (read_atcb): Update.
1211 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1212 (amd64_windows_skip_trampoline_code): Update.
1213 * arm-tdep.c (skip_prologue_function): Update.
1214 (arm_skip_stack_protector): Update.
1215 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1216 (arm_wince_skip_main_prologue): Update.
1217 * ax-gdb.c (gen_expr): Update.
1218 * block.c (call_site_for_pc): Update.
1219 * blockframe.c (find_pc_partial_function): Update.
1220 * breakpoint.c (set_breakpoint_location_function): Update.
1221 * btrace.c (ftrace_print_function_name): Update.
1222 (ftrace_function_switched): Update.
1223 * c-valprint.c (print_unpacked_pointer): Update.
1224 * coffread.c (coff_symfile_read): Update.
1225 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1226 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1227 * dwarf-index-write.c (write_psymbols): Update.
1228 * dwarf2loc.c (call_site_to_target_addr): Update.
1229 (func_verify_no_selftailcall): Update.
1230 (tailcall_dump): Update.
1231 (call_site_find_chain_1): Update.
1232 (dwarf_expr_reg_to_entry_parameter): Update.
1233 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1234 * eval.c (evaluate_funcall): Update.
1235 (evaluate_subexp_standard): Update.
1236 (evaluate_subexp_for_sizeof): Update.
1237 * expprint.c (print_subexp_standard): Update.
1238 (dump_subexp_body_standard): Update.
1239 * frame.c (get_prev_frame_always_1): Update.
1240 * frv-tdep.c (frv_skip_main_prologue): Update.
1241 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1242 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1243 (gnuv3_get_typename_from_type_info): Update.
1244 (gnuv3_skip_trampoline): Update.
1245 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1246 * i386-tdep.c (i386_skip_main_prologue): Update.
1247 (i386_pe_skip_trampoline_code): Update.
1248 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1249 * infcall.c (get_function_name): Update.
1250 * linespec.c (minsym_found): Update.
1251 * linux-fork.c (info_checkpoints_command): Update.
1252 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1253 (m32c_m16c_pointer_to_address): Update.
1254 * maint.c (maintenance_translate_address): Update.
1255 * minsyms.c (add_minsym_to_hash_table): Update.
1256 (add_minsym_to_demangled_hash_table): Update.
1257 (lookup_minimal_symbol_mangled): Update.
1258 (lookup_minimal_symbol_demangled): Update.
1259 (lookup_minimal_symbol_linkage): Update.
1260 (lookup_minimal_symbol_text): Update.
1261 (lookup_minimal_symbol_by_pc_name): Update.
1262 (minimal_symbol_is_less_than): Update.
1263 (compact_minimal_symbols): Update.
1264 (build_minimal_symbol_hash_tables): Update.
1265 (find_solib_trampoline_target): Update.
1266 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1267 (mips_skip_pic_trampoline_code): Update.
1268 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1269 * objc-lang.c (info_selectors_command): Update.
1270 (info_classes_command): Update.
1271 (find_methods): Update.
1272 (find_imps): Update.
1273 * p-valprint.c (pascal_val_print): Update.
1274 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1275 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1276 * printcmd.c (build_address_symbolic): Update.
1277 (info_symbol_command): Update.
1278 * psymtab.c (psymbol_name_matches): Update.
1279 (match_partial_symbol): Update.
1280 (lookup_partial_symbol): Update.
1281 (print_partial_symbols): Update.
1282 (sort_pst_symbols): Update.
1283 (maintenance_check_psymtabs): Update.
1284 * python/py-framefilter.c (py_print_frame): Update.
1285 * python/python.c (gdbpy_rbreak): Update.
1286 * record-btrace.c (btrace_get_bfun_name): Update.
1287 (btrace_call_history): Update.
1288 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1289 (rs6000_skip_trampoline_code): Update.
1290 * sol-thread.c (info_cb): Update.
1291 * stabsread.c (scan_file_globals): Update.
1292 * stack.c (find_frame_funname): Update.
1293 (info_frame_command_core): Update.
1294 * symmisc.c (dump_msymbols): Update.
1295 * symtab.c (symbol_natural_name): Rename to..,
1296 (general_symbol_info::natural_name): ...this.
1297 (symbol_demangled_name): Rename to...
1298 (general_symbol_info::demangled_name): ...this.
1299 (symbol_search_name): Rename to...
1300 (general_symbol_info::search_name): ...this.
1301 (symbol_matches_search_name): Update.
1302 (find_pc_sect_line): Update.
1303 (skip_prologue_sal): Update.
1304 (search_symbols): Update.
1305 (print_msymbol_info): Update.
1306 (rbreak_command): Update.
1307 (completion_list_add_msymbol): Update.
1308 (completion_list_objc_symbol): Update.
1309 (get_msymbol_address): Update.
1310 * symtab.h (struct general_symbol_info): Add member functions
1311 natural_name (), linkage_name (), print_name (), demangled_name (),
1312 and search_name ().
1313 (SYMBOL_NATURAL_NAME): Update.
1314 (symbol_natural_name): Move to a member function on general_symbol_info.
1315 (SYMBOL_DEMANGLED_NAME): Update.
1316 (symbol_demangled_name): Move to a member function on
1317 general_symbol_info.
1318 (SYMBOL_SEARCH_NAME): Update.
1319 (symbol_search_name): Move to a member function on general_symbol_info.
1320 (MSYMBOL_NATURAL_NAME): Remove.
1321 (MSYMBOL_LINKAGE_NAME): Remove.
1322 (MSYMBOL_PRINT_NAME): Remove.
1323 (MSYMBOL_DEMANGLED_NAME): Remove.
1324 (MSYMBOL_SEARCH_NAME): Remove.
1325 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1326
1327 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1328
1329 * symtab.c (create_demangled_names_hash): Use per_bfd->
1330 minimal_symbol_count for computing the initial size, if greater
1331 than our default size.
1332
1333 2019-11-22 Tom de Vries <tdevries@suse.de>
1334
1335 * contrib/words.sh: Improve words extraction.
1336
1337 2019-11-22 Tom de Vries <tdevries@suse.de>
1338
1339 * contrib/words.sh: Combine sed invocations.
1340
1341 2019-11-21 Christian Biesinger <cbiesinger@google.com>
1342
1343 * Makefile.in: Update.
1344 * demangle.c: Rename to...
1345 * gdb-demangle.c: ..this.
1346 (is_cplus_marker): Change return type to bool.
1347 (_initialize_demangler): Rename to...
1348 (_initialize_gdb_demangle): ...this.
1349 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1350 * symtab.h (demangle): Remove declaration; instead include
1351 gdb-demangle.h.
1352
1353 2019-11-21 Tom Tromey <tromey@adacore.com>
1354
1355 * gdbsupport/format.c (format_pieces): Parse %I64d.
1356 * unittests/format_pieces-selftests.c (test_windows_formats): New
1357 function.
1358 (run_tests): Call it.
1359
1360 2019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1361
1362 Byte reverse display of variables with DW_END_big, DW_END_little
1363 (DW_AT_endianity) dwarf attributes if different than the native
1364 byte order.
1365 * ada-lang.c (ada_value_binop):
1366 Use type_byte_order instead of gdbarch_byte_order.
1367 * ada-valprint.c (printstr):
1368 (ada_val_print_string):
1369 * ada-lang.c (value_pointer):
1370 (ada_value_binop):
1371 Use type_byte_order instead of gdbarch_byte_order.
1372 * c-lang.c (c_get_string):
1373 Use type_byte_order instead of gdbarch_byte_order.
1374 * c-valprint.c (c_val_print_array):
1375 Use type_byte_order instead of gdbarch_byte_order.
1376 * cp-valprint.c (cp_print_class_member):
1377 Use type_byte_order instead of gdbarch_byte_order.
1378 * dwarf2loc.c (rw_pieced_value):
1379 Use type_byte_order instead of gdbarch_byte_order.
1380 * dwarf2read.c (read_base_type): Handle DW_END_big,
1381 DW_END_little
1382 * f-lang.c (f_get_encoding):
1383 Use type_byte_order instead of gdbarch_byte_order.
1384 * findvar.c (default_read_var_value):
1385 Use type_byte_order instead of gdbarch_byte_order.
1386 * gdbtypes.c (check_types_equal):
1387 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1388 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1389 and TYPE_ENDIANITY_LITTLE if set.
1390 (type_byte_order): new function.
1391 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1392 (struct main_type) <flag_endianity_not_default>:
1393 New field.
1394 (type_byte_order): New function.
1395 * infcmd.c (default_print_one_register_info):
1396 Use type_byte_order instead of gdbarch_byte_order.
1397 * p-lang.c (pascal_printstr):
1398 Use type_byte_order instead of gdbarch_byte_order.
1399 * p-valprint.c (pascal_val_print):
1400 Use type_byte_order instead of gdbarch_byte_order.
1401 * printcmd.c (print_scalar_formatted):
1402 Use type_byte_order instead of gdbarch_byte_order.
1403 * solib-darwin.c (darwin_current_sos):
1404 Use type_byte_order instead of gdbarch_byte_order.
1405 * solib-svr4.c (solib_svr4_r_ldsomap):
1406 Use type_byte_order instead of gdbarch_byte_order.
1407 * stap-probe.c (stap_modify_semaphore):
1408 Use type_byte_order instead of gdbarch_byte_order.
1409 * target-float.c (target_float_same_format_p):
1410 Use type_byte_order instead of gdbarch_byte_order.
1411 * valarith.c (scalar_binop):
1412 (value_bit_index):
1413 Use type_byte_order instead of gdbarch_byte_order.
1414 * valops.c (value_cast):
1415 Use type_byte_order instead of gdbarch_byte_order.
1416 * valprint.c (generic_emit_char):
1417 (generic_printstr):
1418 (val_print_string):
1419 Use type_byte_order instead of gdbarch_byte_order.
1420 * value.c (unpack_long):
1421 (unpack_bits_as_long):
1422 (unpack_value_bitfield):
1423 (modify_field):
1424 (pack_long):
1425 (pack_unsigned_long):
1426 Use type_byte_order instead of gdbarch_byte_order.
1427 * findvar.c (unsigned_pointer_to_address):
1428 (signed_pointer_to_address):
1429 (unsigned_address_to_pointer):
1430 (address_to_signed_pointer):
1431 (default_read_var_value):
1432 (default_value_from_register):
1433 Use type_byte_order instead of gdbarch_byte_order.
1434 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1435 Use type_byte_order instead of gdbarch_byte_order.
1436 * riscv-tdep.c (riscv_print_one_register_info):
1437 Use type_byte_order instead of gdbarch_byte_order.
1438
1439 2019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1440
1441 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1442 (current_ui_gdb_stdin_ptr): Likewise.
1443 (current_ui_gdb_stderr_ptr): Likewise.
1444 (current_ui_gdb_stdlog_ptr): Likewise.
1445 (current_ui_current_uiout_ptr): Likewise.
1446 (gen_ret_current_ui_field_ptr): Remove.
1447
1448 2019-11-21 Tom de Vries <tdevries@suse.de>
1449
1450 PR gdb/24956
1451 * cli/cli-script.c (execute_control_command): Only switch to
1452 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1453
1454 2019-11-19 Tom Tromey <tom@tromey.com>
1455
1456 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1457 Now static. Change type of "name".
1458 (tui_set_win_height_command): Don't copy "arg".
1459 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1460 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1461
1462 2019-11-19 Ali Tamur <tamur@google.com>
1463
1464 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1465 "if (attr != nullptr)".
1466 (dwarf2_find_base_address): Likewise.
1467 (dwarf2_build_include_psymtabs): Likewise.
1468 (read_cutu_die_from_dwo): Likewise.
1469 (read_func_scope): Likewise.
1470 (read_call_site_scope): Likewise.
1471 (dwarf2_get_pc_bounds): Likewise.
1472 (dwarf2_record_block_ranges): Likewise.
1473 (dwarf2_add_field): Likewise.
1474 (dwarf2_add_member_fn): Likewise.
1475 (read_structure_type): Likewise.
1476 (read_enumeration_type): Likewise.
1477 (read_array_type): Likewise.
1478 (read_array_order): Likewise.
1479 (read_set_type): Likewise.
1480 (read_common_block): Likewise.
1481 (read_tag_reference_type): Likewise.
1482 (read_tag_string_type): Likewise.
1483 (read_subroutine_type): Likewise.
1484 (read_base_type): Likewise.
1485 (read_subrange_type): Likewise.
1486 (new_symbol): Likewise.
1487 (prepare_one_comp_unit): Likewise.
1488
1489 2019-11-19 Tom Tromey <tromey@adacore.com>
1490
1491 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1492 result in error when DebugActiveProcess fails.
1493
1494 2019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1495 Pedro Alves <palves@redhat.com>
1496
1497 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1498 * target.c (target_stack::push): Call 'unpush' if there's a
1499 target on top of the stack.
1500
1501 2019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1502
1503 * python/py-block.c (blpy_dealloc): Call tp_free.
1504 (blpy_block_syms_dealloc): Likewise.
1505 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1506 * python/py-inferior.c (infpy_dealloc): Likewise.
1507 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1508 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1509 * python/py-symbol.c (sympy_dealloc): Likewise.
1510 * python/py-symtab.c (stpy_dealloc): Likewise.
1511 * python/py-type.c (typy_iterator_dealloc): Likewise.
1512
1513 2019-11-18 Christian Biesinger <cbiesinger@google.com>
1514
1515 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1516 constructor instead of using a class initializer.
1517
1518 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1519
1520 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1521 * configure: Regenerate.
1522 * configure.ac: Don't source common.host.
1523 * gdbsupport/common.host: Remove.
1524 * gdbsupport/mingw-strerror.c: Remove.
1525 * gdbsupport/posix-strerror.c: Rename to...
1526 * gdbsupport/safe-strerror.c: ...this.
1527
1528 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1529
1530 * maint.c (scoped_command_stats::print_time): Use localtime_r
1531 instead of localtime (provided through gnulib if necessary).
1532 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1533 of ctime.
1534
1535 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1536
1537 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1538 avoid compile errors.
1539
1540 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1541
1542 * config.in: Regenerate.
1543 * configure: Regenerate.
1544 * gdbsupport/common.m4: No longer check for strerror_r.
1545 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1546 POSIX version of strerror_r, now that gnulib provides it if
1547 necessary.
1548
1549 2019-11-14 Christian Biesinger <cbiesinger@google.com>
1550
1551 * README (`configure' options): Update.
1552
1553 2019-11-14 Tom Tromey <tromey@adacore.com>
1554
1555 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1556 expected type for the RHS if the LHS is a convenience variable.
1557
1558 2019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1559
1560 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1561 Provide explicit default and copy constructor.
1562
1563 2019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1564
1565 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1566 only call Py_INCREF (newbp) in the bppy_pending_object case.
1567
1568 2019-11-13 Tom Tromey <tromey@adacore.com>
1569
1570 PR build/25182:
1571 * psympriv.h (partial_symbol): Remove static assert.
1572 * symtab.h (general_symbol_info, symbol): Remove static assert.
1573
1574 2019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1575
1576 * gdbsupport/format.c (format_pieces::format_pieces): Support
1577 printf 'z' size modifier.
1578 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1579 * printcmd.c (ui_printf): Handle size_t_arg.
1580 * ui-out.c (ui_out::vmessage): Likewise.
1581 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1582 function.
1583 (run_tests): Call test_format_int_sizes.
1584
1585 2019-11-12 Christian Biesinger <cbiesinger@google.com>
1586
1587 * ada-exp.y (write_ambiguous_var): Update.
1588 * buildsym.c (add_symbol_to_list): Update.
1589 * dwarf2read.c (read_variable): Update.
1590 (new_symbol): Update.
1591 * jit.c (finalize_symtab): Update.
1592 * language.c (language_alloc_type_symbol): Update.
1593 * symtab.c (fixup_symbol_section): Update.
1594 (initialize_objfile_symbol_1): Move code to...
1595 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1596 (allocate_symbol): Update.
1597 (allocate_template_symbol): Update.
1598 (get_symbol_address): Update.
1599 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1600 of having as a field, and add a constructor.
1601 (SYMBOL_VALUE): Update.
1602 (SYMBOL_VALUE_ADDRESS): Update.
1603 (SET_SYMBOL_VALUE_ADDRESS): Update.
1604 (SYMBOL_VALUE_BYTES): Update.
1605 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1606 (SYMBOL_BLOCK_VALUE): Update.
1607 (SYMBOL_VALUE_CHAIN): Update.
1608 (SYMBOL_LANGUAGE): Update.
1609 (SYMBOL_SECTION): Update.
1610 (SYMBOL_OBJ_SECTION): Update.
1611 (SYMBOL_SET_LANGUAGE): Update.
1612 (SYMBOL_SET_LINKAGE_NAME): Update.
1613 (SYMBOL_SET_NAMES): Update.
1614 (SYMBOL_NATURAL_NAME): Update.
1615 (SYMBOL_LINKAGE_NAME): Update.
1616 (SYMBOL_DEMANGLED_NAME): Update.
1617 (SYMBOL_SEARCH_NAME): Update.
1618 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1619 (struct symbol): Update.
1620 (struct template_symbol): Update.
1621 (struct rust_vtable_symbol): Update.
1622 * xcoffread.c (SYMBOL_DUP): Update.
1623
1624 2019-11-12 Tom Tromey <tom@tromey.com>
1625
1626 * tui/tui-layout.c (show_layout): Set current_layout.
1627 (show_source_disasm_command, show_data)
1628 (show_source_or_disasm_and_command): Don't set current_layout.
1629
1630 2019-11-12 Tom Tromey <tom@tromey.com>
1631
1632 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1633
1634 2019-11-12 Tom Tromey <tom@tromey.com>
1635
1636 * tui/tui-win.c (resize_message): New global.
1637 (show_tui_resize_message): New function.
1638 (tui_async_resize_screen): Print message if requested.
1639 (_initialize_tui_win): Add tui-resize-message setting.
1640 * NEWS: Add entry for new commands.
1641
1642 2019-11-11 Tom Tromey <tom@tromey.com>
1643
1644 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1645 functions.
1646
1647 2019-11-11 Christian Biesinger <cbiesinger@google.com>
1648
1649 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1650
1651 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1652
1653 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1654 function.
1655 * python/python-internal.h (gdbpy_lookup_static_symbols):
1656 Declare new function.
1657 * python/python.c (python_GdbMethods): Add
1658 gdb.lookup_static_symbols method.
1659 * NEWS: Mention gdb.lookup_static_symbols.
1660
1661 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1662
1663 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1664 static block of current object file first. Also fix typo in
1665 header comment.
1666
1667 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1668
1669 * stack.c (set_last_displayed_sal): Delete.
1670 (last_displayed_sal_valid): Delete.
1671 (last_displayed_pspace): Delete.
1672 (last_displayed_addr): Delete.
1673 (last_displayed_symtab): Delete.
1674 (last_displayed_line): Delete.
1675 (class last_displayed_symtab_info_type): New.
1676 (last_displayed_symtab_info): New static global variable.
1677 (print_frame_info): Call methods on last_displayed_symtab_info.
1678 (clear_last_displayed_sal): Update header comment, and make use of
1679 last_displayed_symtab_info.
1680 (last_displayed_sal_is_valid): Likewise.
1681 (get_last_displayed_pspace): Likewise.
1682 (get_last_displayed_addr): Likewise.
1683 (get_last_displayed_symtab): Likewise.
1684 (get_last_displayed_line): Likewise.
1685 (get_last_displayed_sal): Likewise.
1686 * stack.h (clear_last_displayed_sal): Update header comment.
1687 (last_displayed_sal_is_valid): Likewise.
1688 (get_last_displayed_pspace): Likewise.
1689 (get_last_displayed_addr): Likewise.
1690 (get_last_displayed_symtab): Likewise.
1691 (get_last_displayed_line): Likewise.
1692 (get_last_displayed_sal): Likewise.
1693
1694 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1695
1696 * stack.c (frame_show_address): Convert return type to bool.
1697 * stack.h (frame_show_address): Likewise, and update header
1698 comment.
1699
1700 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1701
1702 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1703 * unittests/vec-utils-selftests.c: New file.
1704 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1705
1706 2019-11-10 Tom Tromey <tom@tromey.com>
1707
1708 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1709 (tui_highlight_win): Likewise.
1710 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1711 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1712 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1713 Don't set can_highlight.
1714
1715 2019-11-10 Tom Tromey <tom@tromey.com>
1716
1717 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1718 Remove unused declaration.
1719
1720 2019-11-08 Tom Tromey <tromey@adacore.com>
1721
1722 * top.c (read_command_file): Update.
1723 (command_line_input): Make return type const.
1724 * python/py-gdb-readline.c: Update.
1725 * linespec.c (decode_line_2): Update.
1726 * defs.h (command_line_input): Make return type const.
1727 * cli/cli-script.c (read_next_line): Make return type const.
1728 * ada-lang.c (get_selections): Update.
1729
1730 2019-11-06 Christian Biesinger <cbiesinger@google.com>
1731
1732 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1733 * mi/mi-main.c (output_cores): Likewise.
1734 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1735 (linux_xfer_osdata_modules): Likewise.
1736 * remote.c (register_remote_support_xml): Likewise.
1737 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1738 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1739
1740 2019-11-06 Tom Tromey <tom@tromey.com>
1741
1742 * tui/tui-interp.c: Don't include readline.h.
1743 * tui/tui-hooks.c: Don't include readline.h.
1744 * symmisc.c: Include tilde.h, not readline.h.
1745 * symfile.c: Include tilde.h, not readline.h.
1746 * source.c: Include tilde.h, not readline.h.
1747 * solib.c: Include tilde.h, not readline.h.
1748 * psymtab.c: Include tilde.h, not readline.h.
1749 * exec.c: Include tilde.h, not readline.h.
1750 * corelow.c: Include tilde.h, not readline.h.
1751 * cli/cli-dump.c: Include tilde.h, not readline.h.
1752 * cli/cli-cmds.c: Don't include readline.h.
1753
1754 2019-11-05 Tom Tromey <tom@tromey.com>
1755
1756 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1757 (tui_disassemble): Set addr_size.
1758 (tui_disasm_window::set_contents): Use addr_size.
1759
1760 2019-11-05 Tom Tromey <tom@tromey.com>
1761
1762 * rust-lang.c (rust_language_defn): Update.
1763 * python/py-value.c (valpy_string): Call c_get_string.
1764 * p-lang.c (pascal_language_defn): Update.
1765 * opencl-lang.c (opencl_language_defn): Update.
1766 * objc-lang.c (objc_language_defn): Update.
1767 * m2-lang.c (m2_language_defn): Update.
1768 * language.c (unknown_language_defn, auto_language_defn): Update.
1769 (default_get_string): Remove.
1770 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1771 * go-lang.c (go_language_defn): Update.
1772 * f-lang.c (f_language_defn): Update.
1773 * d-lang.c (d_language_defn): Update.
1774 * c-lang.c (c_language_defn, cplus_language_defn)
1775 (asm_language_defn, minimal_language_defn): Update.
1776 * ada-lang.c (ada_language_defn): Update.
1777 * language.h (struct language_defn) <la_get_string>: Remove.
1778 (LA_GET_STRING): Remove.
1779 (default_get_string): Don't declare.
1780
1781 2019-11-05 Tom Tromey <tom@tromey.com>
1782
1783 * tui/tui-source.h (struct tui_source_window): Inline
1784 constructor. Remove destructor.
1785 <style_changed, m_observable>: Move to superclass.
1786 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1787 (struct tui_source_window_base): Move private members to end.
1788 <style_changed, m_observable>: Move from tui_source_window.
1789 * tui/tui-winsource.c (tui_copy_source_line): Move from
1790 tui-source.c. Rename from copy_source_line. Add special handling
1791 for negative line number.
1792 (tui_source_window_base::style_changed): Move from
1793 tui_source_window.
1794 (tui_source_window_base): Register observer.
1795 (~tui_source_window_base): New.
1796 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1797 rename.
1798 (tui_source_window::set_contents): Use tui_copy_source_line.
1799 (tui_source_window::tui_source_window): Move to tui-source.h.
1800 (tui_source_window::~tui_source_window): Remove.
1801 (tui_source_window::style_changed): Move to superclass.
1802 * tui/tui-disasm.c (tui_disassemble): Create string file with
1803 styling, when possible. Add "addr_size" parameter.
1804 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1805 Don't compute maximum size.
1806 (len_without_escapes): New function
1807
1808 2019-11-05 Tom Tromey <tom@tromey.com>
1809
1810 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1811 std::string.
1812 * tui/tui-winsource.c (tui_show_source_line): Update.
1813 * tui/tui-source.c (tui_source_window::set_contents): Update.
1814 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1815
1816 2019-11-05 Christian Biesinger <cbiesinger@google.com>
1817
1818 * symtab.h (gdb_static_assert): Put && operator at the beginning
1819 of the line instead of the end.
1820
1821 2019-11-04 Christian Biesinger <cbiesinger@google.com>
1822
1823 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1824 and sizeof (symbol).
1825 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1826
1827 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1828
1829 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1830 * configure.host: Mark *-*-solaris2.10* obsolete.
1831 * configure.tgt: Mark Solaris < 11 obsolete.
1832 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1833 Update target triplet.
1834
1835 2019-11-01 Tom Tromey <tromey@adacore.com>
1836
1837 * utils.c (print_sys_errmsg): Simplify.
1838
1839 2019-11-01 Tom Tromey <tromey@adacore.com>
1840
1841 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1842
1843 2019-11-01 Christian Biesinger <cbiesinger@google.com>
1844
1845 * configure: Regenerate.
1846 * configure.ac: Remove check for strerror_r.
1847 * gdbsupport/common.m4: Check for strerror_r.
1848
1849 2019-11-01 Luis Machado <luis.machado@linaro.org>
1850
1851 PR gdb/25124
1852
1853 * arm-tdep.c (arm_per_objfile): Rename to ...
1854 (arm_per_bfd): ... this.
1855 (arm_objfile_data_key): Rename to ...
1856 (arm_bfd_data_key): ... this.
1857 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1858 data.
1859 (arm_record_special_symbol): Likewise.
1860
1861 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1862
1863 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1864 end.
1865 * c-typeprint.c (c_print_typedef): Likewise.
1866 * f-typeprint.c (f_print_typedef): Likewise.
1867 * m2-typeprint.c (m2_print_typedef): Likewise.
1868 * p-typeprint.c (pascal_print_typedef): Likewise.
1869 * rust-lang.c (rust_print_typedef): Likewise.
1870 * symtab.c (print_symbol_info): Print a newline after calling
1871 typedef_print.
1872
1873 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1874
1875 * symtab.c (info_module_cmdlist): New variable.
1876 (info_module_command): New function.
1877 (search_module_symbols): New function.
1878 (info_module_subcommand): New function.
1879 (struct info_modules_var_func_options): New struct.
1880 (info_modules_var_func_options_defs): New variable.
1881 (make_info_modules_var_func_options_def_group): New function.
1882 (info_module_functions_command): New function.
1883 (info_module_variables_command): New function.
1884 (info_module_var_func_command_completer): New function.
1885 (_initialize_symtab): Register new 'info module functions' and
1886 'info module variables' commands.
1887 * symtab.h (typedef symbol_search_in_module): New typedef.
1888 (search_module_symbols): Declare new function.
1889 * NEWS: Mention new commands.
1890
1891 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1892
1893 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1894 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1895 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1896 MODULES_DOMAIN.
1897 (scan_partial_symbols): Only create partial module symbols for non
1898 declarations.
1899 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1900 and MODULES_DOMAIN.
1901 * symtab.c (search_domain_name): Likewise.
1902 (search_symbols): Likewise.
1903 (print_symbol_info): Likewise.
1904 (symtab_symbol_info): Likewise.
1905 (info_modules_command): New function.
1906 (_initialize_symtab): Register 'info modules' command.
1907 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1908 * NEWS: Mention new 'info modules' command.
1909
1910 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1911
1912 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1913 and $_gdb_maint_setting_str.
1914
1915 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1916
1917 * cli/cli-cmds.c (setting_cmd, value_from_setting)
1918 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1919 (str_value_from_setting, gdb_setting_str_internal_fn)
1920 (gdb_maint_setting_str_internal_fn): New functions.
1921 (_initialize_cli_cmds): Define the new convenience functions.
1922 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1923 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1924
1925 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1926
1927 * agent.c (set_can_use_agent): When the setting is turned on,
1928 look up agent symbols if we don't have them yet.
1929 (agent_new_objfile): Don't look up agent symbols when the agent
1930 setting is off.
1931
1932 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1933
1934 * config.in: Regenerate.
1935
1936 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1937
1938 * configure: Regenerate.
1939 * configure.ac: Check for strerror_r.
1940 * gdbsupport/common-utils.h (safe_strerror): Change return value
1941 to const char * and document that this function is now threadsafe.
1942 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1943 thread_local and call strerror_r, if available.
1944 * utils.c (perror_string): Update.
1945 (print_sys_errmsg): Update.
1946
1947 2019-10-31 Luis Machado <luis.machado@linaro.org>
1948
1949 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1950 objfile_key.
1951 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1952 objfile to fetch per-bfd data.
1953 (arm_find_exidx_entry): Likewise.
1954
1955 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1956
1957 * gdbsupport/agent.c (debug_agent): Change type to bool.
1958 (use_agent): Likewise.
1959 (all_agent_symbols_look_up): Likewise.
1960 (agent_loaded_p): Change return value to bool.
1961 (agent_look_up_symbols): Update.
1962 (agent_capability_check): Change return value to bool.
1963 * gdbsupport/agent.h (agent_loaded_p): Likewise.
1964 (debug_agent): Change type to bool.
1965 (use_agent): Likewise.
1966 (agent_capability_check): Change return value to bool.
1967
1968 2019-10-30 Christian Biesinger <cbiesinger@google.com>
1969
1970 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1971 (build_minimal_symbol_hash_tables): Code to clear the table moved
1972 to clear_minimal_symbol_hash_tables.
1973 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1974 when needed.
1975
1976 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1977
1978 * infcmd.c: Remove includes.
1979 * infrun.c: Remove includes.
1980
1981 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1982
1983 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1984 (grow_vect): Remove declaration.
1985 (ada_type_of_array): Remove declaration.
1986 (ada_update_initial_language): Remove declaration.
1987 (ada_fold_name): Remove declaration.
1988 (ada_fill_in_ada_prototype): Remove declaration.
1989 (user_select_syms): Remove declaration.
1990 (get_selections): Remove declaration.
1991 (ada_tag_type): Remove declaration.
1992 (ada_value_tag): Remove declaration.
1993 (ada_is_others_clause): Remove declaration.
1994 (ada_in_variant): Remove declaration.
1995 (ada_value_struct_elt): Remove declaration.
1996 (ada_attribute_name): Remove declaration.
1997 (ada_system_address_type): Remove declaration.
1998 * ada-lang.c (ada_watch_location_expression): Make static.
1999 (GROW_VECT): Move here from ada-lang.h.
2000 (grow_vect): Make static.
2001 (ada_update_initial_language): Make static.
2002 (ada_fold_name): Make static.
2003 (ada_type_of_array): Make static.
2004 (encoded_ordered_before): Move up.
2005 (sort_choices): Move up.
2006 (print_signatures): Move up.
2007 (ada_print_symbol_signature): Move up.
2008 (get_selections): Move up and make static.
2009 (user_select_syms): Move up and make static.
2010 (ada_value_struct_elt): Move up and make static.
2011 (ada_tag_type): Make static.
2012 (ada_value_tag): Make static.
2013 (ada_is_others_clause): Make static.
2014 (ada_in_variant): Make static.
2015 (ada_attribute_name): Make static.
2016
2017 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2018
2019 * ada-lang.c: Remove includes.
2020 * ada-typeprint.c: Remove includes.
2021 * ada-valprint.c: Remove includes.
2022
2023 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
2024
2025 * addrmap.c: Add static assertions of type size, moved from
2026 _initialize_addrmap.
2027 (_initialize_addrmap): Remove.
2028
2029 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2030
2031 * coffread.c (record_minimal_symbol): Update.
2032 (process_coff_symbol): Update.
2033 * dbxread.c (read_dbx_symtab): Update.
2034 * dwarf2read.c (add_partial_symbol): Update.
2035 (fixup_go_packaging): Update.
2036 (load_partial_dies): Update.
2037 (new_symbol): Update.
2038 * elfread.c (record_minimal_symbol): Change signature to use
2039 gdb::string_view instead of name+len.
2040 (elf_symtab_read): Update.
2041 (elf_rel_plt_read): Update.
2042 * mdebugread.c (parse_partial_symbols): Update.
2043 (handle_psymbol_enumerators): Update.
2044 (new_symbol): Update.
2045 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2046 to use gdb::string_view instead of name+len.
2047 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2048 * psympriv.h (add_psymbol_to_list): Likewise.
2049 * psymtab.c (add_psymbol_to_bcache): Likewise.
2050 (add_psymbol_to_list): Likewise.
2051 * stabsread.c (define_symbol): Update.
2052 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2053 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2054 (symbol_set_names): Likewise.
2055 * xcoffread.c (scan_xcoff_symtab): Update.
2056
2057 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2058
2059 * symtab.h (symbol_set_names): Document that copy_name must be
2060 set to true for non-nullterminated strings.
2061 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2062 linkage_name if the entry was not found and we need to demangle.
2063
2064 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2065
2066 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2067 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2068 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2069 * gdbsupport/gdb_binary_search.h: New file.
2070
2071 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2072
2073 * NEWS: Mention new --with-system-gdbinit-dir option.
2074 * config.in: Regenerate.
2075 * configure: Regenerate.
2076 * configure.ac: Add new option --with-system-gdbinit-dir.
2077 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2078 for a ".gdb" suffix.
2079 * main.c (get_init_files): Change system_gdbinit argument to
2080 a vector and return the files in SYSTEM_GDBINIT_DIR in
2081 addition to SYSTEM_GDBINIT.
2082 (captured_main_1): Update.
2083 (print_gdb_help): Update.
2084 * top.c (print_gdb_configuration): Also print the value of
2085 SYSTEM_GDBINIT_DIR.
2086
2087 2019-10-28 Christian Biesinger <cbiesinger@google.com>
2088
2089 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2090 that takes gdb::string_view arguments.
2091
2092 2019-10-26 Tom de Vries <tdevries@suse.de>
2093
2094 * aarch64-linux-tdep.c: Fix typos in comments.
2095 * aarch64-tdep.c: Same.
2096 * ada-lang.c: Same.
2097 * amd64-nat.c: Same.
2098 * arc-tdep.c: Same.
2099 * arch/aarch64-insn.c: Same.
2100 * block.c: Same.
2101 * breakpoint.h: Same.
2102 * btrace.h: Same.
2103 * c-varobj.c: Same.
2104 * cli/cli-decode.c: Same.
2105 * cli/cli-script.c: Same.
2106 * cli/cli-utils.h: Same.
2107 * coff-pe-read.c: Same.
2108 * coffread.c: Same.
2109 * compile/compile-cplus-symbols.c: Same.
2110 * compile/compile-object-run.c: Same.
2111 * completer.c: Same.
2112 * corelow.c: Same.
2113 * cp-support.c: Same.
2114 * demangle.c: Same.
2115 * dwarf-index-write.c: Same.
2116 * dwarf2-frame.c: Same.
2117 * dwarf2-frame.h: Same.
2118 * eval.c: Same.
2119 * frame-base.h: Same.
2120 * frame.h: Same.
2121 * gdbcmd.h: Same.
2122 * gdbtypes.h: Same.
2123 * gnu-nat.c: Same.
2124 * guile/scm-objfile.c: Same.
2125 * i386-tdep.c: Same.
2126 * i386-tdep.h: Same.
2127 * infcall.c: Same.
2128 * infcall.h: Same.
2129 * linux-nat.c: Same.
2130 * m68k-tdep.c: Same.
2131 * macroexp.c: Same.
2132 * memattr.c: Same.
2133 * mi/mi-cmd-disas.c: Same.
2134 * mi/mi-getopt.h: Same.
2135 * mi/mi-main.c: Same.
2136 * minsyms.c: Same.
2137 * nat/aarch64-sve-linux-sigcontext.h: Same.
2138 * objfiles.h: Same.
2139 * ppc-linux-nat.c: Same.
2140 * ppc-linux-tdep.c: Same.
2141 * ppc-tdep.h: Same.
2142 * progspace.h: Same.
2143 * prologue-value.h: Same.
2144 * python/py-evtregistry.c: Same.
2145 * python/py-instruction.h: Same.
2146 * record-btrace.c: Same.
2147 * record-full.c: Same.
2148 * remote.c: Same.
2149 * rs6000-tdep.c: Same.
2150 * ser-tcp.c: Same.
2151 * sol-thread.c: Same.
2152 * sparc-sol2-tdep.c: Same.
2153 * sparc64-tdep.c: Same.
2154 * stabsread.c: Same.
2155 * symfile.c: Same.
2156 * symtab.h: Same.
2157 * target.c: Same.
2158 * tracepoint.c: Same.
2159 * tui/tui-data.h: Same.
2160 * tui/tui-io.c: Same.
2161 * tui/tui-win.c: Same.
2162 * tui/tui.c: Same.
2163 * unittests/rsp-low-selftests.c: Same.
2164 * user-regs.h: Same.
2165 * utils.c: Same.
2166 * utils.h: Same.
2167 * valarith.c: Same.
2168 * valops.c: Same.
2169 * valprint.c: Same.
2170 * valprint.h: Same.
2171 * value.c: Same.
2172 * value.h: Same.
2173 * varobj.c: Same.
2174 * x86-nat.h: Same.
2175 * xtensa-tdep.c: Same.
2176
2177 2019-10-25 Ali Tamur <tamur@google.com>
2178
2179 * charset.c (find_charset_names): Reflect API change.
2180
2181 2019-10-25 Christian Biesinger <cbiesinger@google.com>
2182
2183 * symtab.c (struct demangled_name_entry): Change demangled name
2184 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2185 part of the struct anymore.
2186 (symbol_set_names): No longer obstack allocate + copy the demangled
2187 name, just store the allocated name from bfd.
2188
2189 2019-10-25 Tom Tromey <tromey@adacore.com>
2190
2191 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2192 (bsearch_cie_cmp, add_cie): Remove.
2193 (find_cie): Reimplement.
2194 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2195 (dwarf2_build_frame_info): Update.
2196
2197 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2198
2199 PR gdb/25126
2200 * symfile.c (reread_symbols): Call forget_cached_source_info to
2201 clear the stale source cache.
2202
2203 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2204
2205 * configure: Regenerate.
2206 * configure.ac: Remove code that sets python_has_threads.
2207
2208 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2209
2210 * config.in: Regenerate.
2211 * configure: Regenerate.
2212 * configure.ac: Remove the code that uses sed to get the python
2213 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2214
2215 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2216
2217 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2218 error paths.
2219
2220 2019-10-23 Tom Tromey <tom@tromey.com>
2221
2222 * arc-tdep.c: Remove ".." from include.
2223 * frv-tdep.c: Remove ".." from include.
2224 * lm32-tdep.c: Remove ".." from include.
2225 * microblaze-tdep.c: Remove ".." from include.
2226 * or1k-tdep.h: Remove ".." from include.
2227 * s12z-tdep.c: Remove ".." from include.
2228 * Makefile.in (OPCODES_CFLAGS): Add comment.
2229 (TOP_CFLAGS): New variable.
2230 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2231
2232 2019-10-23 Tom Tromey <tom@tromey.com>
2233
2234 * Makefile.in (READLINE_DIR): Update.
2235
2236 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2237
2238 * infcall.c (call_function_by_hand_dummy): Fix the function
2239 comment. And extract out a code section into...
2240 (reserve_stack_space): ...this new function.
2241
2242 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2243
2244 * infcall.c (value_arg_coerce): Remove an unused parameter.
2245 (call_function_by_hand_dummy): Update the call to
2246 'value_arg_coerce'.
2247
2248 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2249
2250 * infcall.c (call_function_by_hand_dummy): Refactor.
2251
2252 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2253
2254 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2255
2256 2019-10-23 Tom Tromey <tom@tromey.com>
2257
2258 * configure: Rebuild.
2259 * configure.ac: Don't check for sigprocmask.
2260 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2261
2262 2019-10-23 Tom Tromey <tom@tromey.com>
2263
2264 * configure: Rebuild.
2265 * acinclude.m4: Use m4_include, not sinclude.
2266
2267 2019-10-23 Tom de Vries <tdevries@suse.de>
2268
2269 PR breakpoints/24687
2270 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2271
2272 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2273
2274 * symtab.c (struct demangled_name_entry) <language>: Change from
2275 bitfield to regular variable.
2276
2277 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2278
2279 * symtab.c (struct demangled_name_entry): Add a constructor.
2280 (free_demangled_name_entry): New function to call the destructor
2281 for demangled_name_entry.
2282 (create_demangled_names_hash): Pass free_demangled_name_entry to
2283 htab_create_alloc.
2284 (symbol_set_names): Call placement new for demangled_name_entry.
2285 * utils.c: No longer include xxhash.h here, now that fast_hash
2286 is inlined in the header.
2287 * utils.h: Instead, include it here.
2288
2289 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2290
2291 * Makefile.in: Link with libxxhash.
2292 * config.in: Regenerate.
2293 * configure: Regenerate.
2294 * configure.ac: Search for libxxhash.
2295 * utils.c (fast_hash): Use xxhash if present.
2296
2297 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2298
2299 * utils.h (fast_hash): New function.
2300 * symtab.c (hash_demangled_name_entry): Call new function
2301 fast_hash.
2302
2303 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2304
2305 * symtab.c (struct demangled_name_entry): Change type of mangled
2306 to gdb::string_view. Also adds a constructor that takes the
2307 mangled name.
2308 (hash_demangled_name_entry): Update.
2309 (eq_demangled_name_entry): Update.
2310 (free_demangled_name_entry): New function to call the destructor
2311 now that this is not a POD anymore.
2312 (create_demangled_names_hash): Pass free_demangled_name_entry to
2313 htab_create_alloc.
2314 (symbol_set_names): Update.
2315
2316 2019-10-21 Ali Tamur <tamu@google.com>
2317
2318 * dwarf2read.c (dir_index): Change type.
2319 (file_name_index): Likewise.
2320 (line_header::include_dir_at): Change comment and implementation on
2321 whether it is DWARF 5.
2322 (line_header::is_valid_file_index): New function.
2323 (line_header::file_name_at): Change comment and implementation on
2324 whether it is DWARF 5.
2325 (line_header::file_names): Change to private field renamed as
2326 m_file_names and introduce a new accessor method.
2327 (line_header::file_names_size): New method.
2328 (line_header::include_dirs): Change to private field and rename as
2329 m_include_dirs.
2330 (dw2_get_file_names_reader): Define local var at a smaller scope and
2331 reflect API change.
2332 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2333 (process_structure_scope): Likewise.
2334 (line_header::add_include_dir): Change message and reflect renaming.
2335 (line_header::add_file_name): Likewise.
2336 (read_formatted_entries): Handle DW_FORM_data16.
2337 (dwarf_decode_line_header): Fix line header length calculation.
2338 (psymtab_include_file_name): Change comment and API.
2339 (lnp_state_machine::m_file): Update comment and reflect type change.
2340 (lnp_state_machine::record_line): Reflect type change.
2341 (dwarf_decode_lines): Reflect API change.
2342 (file_file_name): Likewise.
2343 (file_full_name): Likewise.
2344
2345 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2346
2347 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2348
2349 2019-10-21 Tom Tromey <tom@tromey.com>
2350
2351 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2352
2353 2019-10-21 Tom Tromey <tom@tromey.com>
2354
2355 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2356 NM_H. Use AC_CONFIG_LINKS.
2357 * configure: Rebuild.
2358 * Makefile.in (NM_H): New variable.
2359 (generated_files): Add NM_H. Remove gcore.
2360 (nm.h, stamp-nmh): New targets.
2361
2362 2019-10-20 Tom Tromey <tom@tromey.com>
2363
2364 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2365 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2366 obsolete comment.
2367 (put_objfile_before): Now static.
2368
2369 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2370
2371 * gdbsupport/common-utils.h (startswith): Change return type to
2372 bool.
2373
2374 2019-10-19 Christian Biesinger <cbiesinger@google.com>
2375
2376 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2377 * breakpoint.c (bp_locations_compare): Rename to...
2378 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2379 (update_global_location_list): Use std::sort instead of qsort.
2380 * buildsym.c (compare_line_numbers): Rename to...
2381 (lte_is_less_than): ...this, and change to std::sort semantics.
2382 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2383 instead of qsort.
2384 * disasm.c (compare_lines): Rename to...
2385 (line_is_less_than): ...this, and change to std::sort semantics.
2386 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2387 of qsort.
2388 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2389 (fde_is_less_than): ...this, and change to std::sort semantics.
2390 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2391 * mdebugread.c (compare_blocks):
2392 (block_is_less_than): ...this, and change to std::sort semantics.
2393 (sort_blocks): Call std::sort instead of qsort.
2394 * objfiles.c (qsort_cmp): Rename to...
2395 (sort_cmp): ...this, and change to std::sort semantics.
2396 (update_section_map): Call std::sort instead of qsort.
2397 * remote.c (compare_pnums): Remove.
2398 (map_regcache_remote_table): Call std::sort instead of qsort.
2399 * utils.c (compare_positive_ints): Remove.
2400 * utils.h (compare_positive_ints): Remove.
2401 * xcoffread.c (compare_lte): Remove.
2402 (arrange_linetable): Call std::sort instead of qsort.
2403
2404 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2405
2406 * symfile.c (init_entry_point_info): Fix typo.
2407 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2408
2409 2019-10-18 Tom de Vries <tdevries@suse.de>
2410
2411 * aarch64-tdep.c: Fix typos in comments.
2412 * ada-lang.c: Same.
2413 * ada-tasks.c: Same.
2414 * alpha-tdep.c: Same.
2415 * alpha-tdep.h: Same.
2416 * amd64-nat.c: Same.
2417 * amd64-windows-tdep.c: Same.
2418 * arc-tdep.c: Same.
2419 * arc-tdep.h: Same.
2420 * arch-utils.c: Same.
2421 * arm-nbsd-tdep.c: Same.
2422 * arm-tdep.c: Same.
2423 * ax-gdb.c: Same.
2424 * blockframe.c: Same.
2425 * btrace.c: Same.
2426 * c-varobj.c: Same.
2427 * coff-pe-read.c: Same.
2428 * coffread.c: Same.
2429 * cris-tdep.c: Same.
2430 * darwin-nat.c: Same.
2431 * dbxread.c: Same.
2432 * dcache.c: Same.
2433 * disasm.c: Same.
2434 * dtrace-probe.c: Same.
2435 * dwarf-index-write.c: Same.
2436 * dwarf2-frame-tailcall.c: Same.
2437 * dwarf2-frame.c: Same.
2438 * dwarf2read.c: Same.
2439 * eval.c: Same.
2440 * exceptions.c: Same.
2441 * fbsd-tdep.c: Same.
2442 * findvar.c: Same.
2443 * frame.c: Same.
2444 * frv-tdep.c: Same.
2445 * gnu-v3-abi.c: Same.
2446 * go32-nat.c: Same.
2447 * h8300-tdep.c: Same.
2448 * hppa-tdep.c: Same.
2449 * i386-linux-tdep.c: Same.
2450 * i386-tdep.c: Same.
2451 * ia64-libunwind-tdep.c: Same.
2452 * ia64-tdep.c: Same.
2453 * infcmd.c: Same.
2454 * infrun.c: Same.
2455 * linespec.c: Same.
2456 * linux-nat.c: Same.
2457 * linux-thread-db.c: Same.
2458 * machoread.c: Same.
2459 * mdebugread.c: Same.
2460 * mep-tdep.c: Same.
2461 * mn10300-tdep.c: Same.
2462 * namespace.c: Same.
2463 * objfiles.c: Same.
2464 * opencl-lang.c: Same.
2465 * or1k-tdep.c: Same.
2466 * osabi.c: Same.
2467 * ppc-linux-nat.c: Same.
2468 * ppc-linux-tdep.c: Same.
2469 * ppc-sysv-tdep.c: Same.
2470 * printcmd.c: Same.
2471 * procfs.c: Same.
2472 * record-btrace.c: Same.
2473 * record-full.c: Same.
2474 * remote-fileio.c: Same.
2475 * remote.c: Same.
2476 * rs6000-tdep.c: Same.
2477 * s12z-tdep.c: Same.
2478 * score-tdep.c: Same.
2479 * ser-base.c: Same.
2480 * ser-go32.c: Same.
2481 * skip.c: Same.
2482 * sol-thread.c: Same.
2483 * solib-svr4.c: Same.
2484 * solib.c: Same.
2485 * source.c: Same.
2486 * sparc-nat.c: Same.
2487 * sparc-sol2-tdep.c: Same.
2488 * sparc-tdep.c: Same.
2489 * sparc64-tdep.c: Same.
2490 * stabsread.c: Same.
2491 * stack.c: Same.
2492 * symfile.c: Same.
2493 * symtab.c: Same.
2494 * target-descriptions.c: Same.
2495 * target-float.c: Same.
2496 * thread.c: Same.
2497 * utils.c: Same.
2498 * valops.c: Same.
2499 * valprint.c: Same.
2500 * value.c: Same.
2501 * varobj.c: Same.
2502 * windows-nat.c: Same.
2503 * xcoffread.c: Same.
2504 * xstormy16-tdep.c: Same.
2505 * xtensa-tdep.c: Same.
2506
2507 2019-10-17 Tom Tromey <tromey@adacore.com>
2508
2509 * configure: Rebuild.
2510 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2511 in AC_CONFIG_FILES invocation.
2512 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2513 new-style config.status invocation.
2514
2515 2019-10-17 Tom de Vries <tdevries@suse.de>
2516
2517 * arm-nbsd-nat.c: Fix typos in comments.
2518 * arm-tdep.c: Same.
2519 * darwin-nat-info.c: Same.
2520 * dwarf2read.c: Same.
2521 * elfread.c: Same.
2522 * event-top.c: Same.
2523 * findvar.c: Same.
2524 * gdbtypes.c: Same.
2525 * hppa-tdep.c: Same.
2526 * i386-tdep.c: Same.
2527 * jit.c: Same.
2528 * main.c: Same.
2529 * mdebugread.c: Same.
2530 * moxie-tdep.c: Same.
2531 * nto-procfs.c: Same.
2532 * osabi.c: Same.
2533 * ppc-linux-tdep.c: Same.
2534 * remote.c: Same.
2535 * riscv-tdep.c: Same.
2536 * s390-tdep.c: Same.
2537 * sh-tdep.c: Same.
2538 * sparc-linux-tdep.c: Same.
2539 * sparc-nat.c: Same.
2540 * stack.c: Same.
2541 * target-descriptions.c: Same.
2542 * top.c: Same.
2543 * varobj.c: Same.
2544
2545 2019-10-16 Tom Tromey <tom@tromey.com>
2546
2547 * objfiles.h (struct objfile) <original_name>: Now const.
2548
2549 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2550
2551 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2552 pass on to sigsetjmp's second argument.
2553 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2554
2555 2019-10-16 Keith Seitz <keiths@redhat.com>
2556
2557 PR gdb/23567
2558 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2559 sections whose size is greater than the file size.
2560
2561 2019-10-16 Jim Wilson <jimw@sifive.com>
2562
2563 * riscv-tdep.c (riscv_gcc_target_options): New.
2564 (riscv_gnu_triplet_regexp): New.
2565 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2566 set_gdbarch_gnu_triplet_regexp.
2567
2568 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2569
2570 * Makefile.in: Add xml-builtin.h.
2571 * features/feature_to_c.sh: Add an include for xml-builtin.h
2572 to ensure that the compiler checks that the types match.
2573 * xml-builtin.h: New file.
2574 * xml-support.c (fetch_xml_builtin): Add missing const.
2575 * xml-support.h: Remove declaration of xml_builtins.
2576
2577 2019-10-16 Tom de Vries <tdevries@suse.de>
2578
2579 PR tdep/25096
2580 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2581 (amd64_classify_aggregate): ... here.
2582 (amd64_classify_aggregate_field): Handled fiels of nested structs
2583 recursively.
2584
2585 2019-10-16 Tom de Vries <tdevries@suse.de>
2586
2587 PR tdep/24104
2588 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2589 that handles 'theclass'.
2590
2591 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2592
2593 * linespec.c (decode_digits_ordinary): Update comment.
2594 * make-target-delegates: No longer need to handle VEC case.
2595 * memrange.c (normalize_mem_ranges): Update comment.
2596 * namespace.c (add_using_directive): Update comment.
2597 * objc-lang.c (uniquify_strings): Update comment.
2598 * ppc-linux-nat.c (struct thread_points): Update comment.
2599 * probe.h (find_probes_in_objfile): Update comment.
2600 * target.h (enum flash_preserve_mode): Update comment.
2601 * varobj.c (varobj_restrict_range): Update comment.
2602 * varobj.h (varobj_list_children): Update comment.
2603
2604 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2605
2606 * Makefile.in: Remove references to vec.h and vec.c.
2607 * aarch64-tdep.c: No longer include vec.h.
2608 * ada-lang.c: Likewise.
2609 * ada-lang.h: Likewise.
2610 * arm-tdep.c: Likewise.
2611 * ax.h: Likewise.
2612 * breakpoint.h: Likewise.
2613 * charset.c: Likewise.
2614 * cp-support.h: Likewise.
2615 * dtrace-probe.c: Likewise.
2616 * dwarf2read.c: Likewise.
2617 * extension.h: Likewise.
2618 * gdb_bfd.c: Likewise.
2619 * gdbsupport/gdb_vecs.h: Likewise.
2620 * gdbsupport/vec.c: Remove.
2621 * gdbsupport/vec.h: Remove.
2622 * gdbthread.h: Likewise.
2623 * guile/scm-type.c: Likewise.
2624 * inline-frame.c: Likewise.
2625 * machoread.c: Likewise.
2626 * memattr.c: Likewise.
2627 * memrange.h: Likewise.
2628 * namespace.h: Likewise.
2629 * nat/linux-btrace.h: Likewise.
2630 * osdata.c: Likewise.
2631 * parser-defs.h: Likewise.
2632 * progspace.h: Likewise.
2633 * python/py-type.c: Likewise.
2634 * record-btrace.c: Likewise.
2635 * rust-exp.y: Likewise.
2636 * solib-target.c: Likewise.
2637 * stap-probe.c: Likewise.
2638 * target-descriptions.c: Likewise.
2639 * target-memory.c: Likewise.
2640 * target.h: Likewise.
2641 * varobj.c: Likewise.
2642 * varobj.h: Likewise.
2643 * xml-support.h: Likewise.
2644
2645 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2646
2647 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2648 Update for new std::vector based implementation.
2649 (process_psymtab_comp_unit_reader): Likewise.
2650 (scan_partial_symbols): Likewise.
2651 (recursively_compute_inclusions): Likewise.
2652 (compute_compunit_symtab_includes): Likewise.
2653 (process_imported_unit_die): Likewise.
2654 (queue_and_load_dwo_tu): Likewise.
2655 (follow_die_sig_1): Likewise.
2656 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2657 (typedef dwarf2_per_cu_ptr): Remove.
2658 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2659 function.
2660 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2661 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2662 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2663 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2664 std::vector.
2665
2666 2019-10-15 Tom Tromey <tromey@adacore.com>
2667
2668 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2669 TID.
2670
2671 2019-10-15 Tom Tromey <tromey@adacore.com>
2672
2673 * windows-nat.c (windows_nat_target::fetch_registers)
2674 (windows_nat_target::store_registers): Rename "pid" to "tid".
2675
2676 2019-10-15 Tom Tromey <tromey@adacore.com>
2677
2678 * gdbarch.h, gdbarch.c: Rebuild.
2679 * gdbarch.sh (gcc_target_options): Change return type to
2680 std::string.
2681 * compile/compile.c (get_args): Update.
2682 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2683 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2684 std::string.
2685 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2686 std::string.
2687 * arch-utils.c (default_gcc_target_options): Return std::string.
2688 * arch-utils.h (default_gcc_target_options): Return std::string.
2689 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2690
2691 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2692
2693 * breakpoint.c (breakpoint_chain): Make static.
2694 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2695 of accessing breakpoint_chain.
2696
2697 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2698
2699 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2700 to a gdb::function_view and return value to bool.
2701 * breakpoint.h (iterate_over_breakpoints): Likewise.
2702 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2703 (pop_dummy_frame): Update.
2704 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2705 (gdbscm_breakpoints): Update.
2706 * python/py-breakpoint.c (build_bp_list): Update.
2707 (gdbpy_breakpoints): Update.
2708 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2709 Update.
2710 (bpfinishpy_handle_stop): Update.
2711 (bpfinishpy_handle_exit): Update.
2712 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2713 (svr4_update_solib_event_breakpoints): Update.
2714
2715 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2716
2717 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2718 when unwrapping single-field structs.
2719
2720 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2721
2722 * dwarf2read.c: Remove includes.
2723
2724 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2725
2726 * ui-out.c (ui_out::call_do_message): Silence
2727 -Wformat-nonliteral warning.
2728
2729 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2730
2731 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2732 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2733 include: readline/tilde.h.
2734
2735 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2736
2737 * remote.c (remote_target::get_trace_status): Remove declaration of
2738 trace_regblock_size.
2739
2740 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2741
2742 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2743 (show_user): Remove declaration of cmdlist.
2744 * cli/cli-cmds.h (max_user_call_depth): Declare.
2745 * cli/cli-script.c (execute_user_command): Remove declaration
2746 of max_user_call_depth.
2747
2748 2019-10-11 Jim Wilson <jimw@sifive.com>
2749
2750 * gdbsupport/print-utils.h (pulongest): Fix comment.
2751 (plongest): Likewise.
2752 (phex): Add missing comment, mention leading zeros.
2753 (phex_nz): Add mention of no leading zeros to comment.
2754
2755 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2756 plongest instead of unsigned long long cast.
2757
2758 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2759
2760 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2761 for external_editor_command and gdbtk_test.
2762
2763 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2764
2765 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2766 * varobj.c (varobjdebug): Move comment to...
2767 * varobj.h (varobjdebug): ...here, and declare.
2768
2769 2019-10-09 Tom Tromey <tom@tromey.com>
2770
2771 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2772 erase_data_content.
2773
2774 2019-10-09 Tom Tromey <tom@tromey.com>
2775
2776 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2777 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2778 * tui/tui-command.c (tui_cmd_window::resize)
2779 (tui_refresh_cmd_win): Update.
2780 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2781 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2782 * tui/tui-data.c (~tui_gen_win_info): Remove.
2783 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2784 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2785 (tui_redisplay_readline, tui_mld_flush)
2786 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2787 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2788 (tui_data_window::erase_data_content)
2789 (tui_data_item_window::rerender)
2790 (tui_data_item_window::refresh_window): Update.
2791 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2792 (box_win, tui_gen_win_info::make_window)
2793 (tui_gen_win_info::make_visible): Update.
2794 (tui_delete_win): Remove.
2795 * tui/tui-winsource.c
2796 (tui_source_window_base::do_erase_source_content): Update.
2797 (tui_show_source_line, tui_source_window_base::update_tab_width)
2798 (tui_source_window_base::update_exec_info): Update.
2799 * tui/tui-data.h (struct curses_deleter): New.
2800 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2801 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2802
2803 2019-10-09 Tom Tromey <tom@tromey.com>
2804
2805 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2806
2807 2019-10-09 Tom Tromey <tom@tromey.com>
2808
2809 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2810 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2811
2812 2019-10-09 Tom Tromey <tom@tromey.com>
2813
2814 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2815 window height directly.
2816 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2817 declare.
2818 * tui/tui-layout.c (tui_default_win_height): Remove.
2819 (tui_default_win_viewport_height): Remove.
2820
2821 2019-10-09 Tom Tromey <tom@tromey.com>
2822
2823 * tui/tui.h: Remove comments.
2824
2825 2019-10-09 Tom de Vries <tdevries@suse.de>
2826
2827 * python/lib/gdb/printer/bound_registers.py: Use
2828 '^builtin_type_bound128' as regexp argument for
2829 add_builtin_pretty_printer.
2830
2831 2019-10-09 Christian Biesinger <cbiesinger@google.com>
2832
2833 * guile/guile.c (guile_extension_script_ops): Remove forward
2834 declaration and mark as static.
2835 (guile_script_ops): Likewise.
2836 (extension_language_guile): Move further down in the file so
2837 it can reference the definitions for guile_{extension_,}script_ops.
2838
2839 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
2840
2841 * s390-tdep.c (390_process_record): Handle new arch13 instructions
2842 except SORTL, DFLTCC, and KDSA.
2843
2844 2019-10-08 Tom Tromey <tromey@adacore.com>
2845
2846 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2847 (struct safe_symbol_file_add_args): Remove.
2848
2849 2019-10-08 Tom Tromey <tromey@adacore.com>
2850
2851 * windows-nat.c: Don't include buildsym-legacy.h.
2852
2853 2019-10-08 Tom Tromey <tromey@adacore.com>
2854
2855 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2856
2857 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2858
2859 * gdbtypes.c (overload_debug): Move comment to header.
2860 * gdbtypes.h (overload_debug): Declare.
2861 * valops.c: Remove declaration of overload_debug, instead
2862 include gdbtypes.h.
2863
2864 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2865
2866 * language.c (show_language_command): Pass lang_frame_mismatch_warn
2867 through _().
2868 (lang_frame_mismatch_warn): Make const, mark with N_(), and
2869 move comment...
2870 * language.h (lang_frame_mismatch_warn): ... here. Also add
2871 declaration.
2872 * top.c (lang_frame_mismatch_warn): Remove declaration.
2873 (check_frame_language_change): Pass lang_frame_mismatch_warn
2874 through _().
2875
2876 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2877
2878 * c-lang.h (vtbl_ptr_name): Declare.
2879 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2880 it from the header.
2881 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2882
2883 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2884
2885 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2886 gdb_static_assert.
2887
2888 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2889
2890 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2891 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2892 * ctfread.c: New file.
2893 * ctfread.h: New file.
2894 * elfread.c: Include ctfread.h.
2895 (struct elfinfo text_p): New member ctfsect.
2896 (elf_locate_sections): Mark CTF section.
2897 (elf_symfile_read): Call elfctf_build_psymtabs.
2898 * Makefile.in (LIBCTF): Add.
2899 (CLIBS): Use it.
2900 (CDEPS): Likewise.
2901 (DIST): Add ctfread.c.
2902
2903 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
2904
2905 * ctfread.c (struct nextfield): Renamed to ...
2906 (struct ctf_nextfield): ... this.
2907 (struct field_info): Renamed to ...
2908 (strut ctf_field_info): ... this.
2909 (attach_fields_to_type): Update for renamed structures.
2910 (ctf_add_member_cb): Likewise.
2911 (ctf_add_enum_member_cb): Likewise.
2912 (process_struct_members): Likewise.
2913 (process_enum_type): Likewise.
2914
2915 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2916
2917 * tracectf.h: Rename, was ctf.h.
2918 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2919 * tracefile.c: Likewise.
2920 * tracepoint.c: Remove unused include ctf.h.
2921 * mi/mi-main.c: Likewise.
2922 * Makefile.in Replace ctf.c with tracectf.c.
2923
2924 2019-10-06 Joel Brobecker <brobecker@adacore.com>
2925
2926 * version.in: Change version number to "9.0.50.DATE-git".
2927
2928 2019-10-03 Tom Tromey <tom@tromey.com>
2929
2930 PR rust/24976:
2931 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2932
2933 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2934
2935 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2936 cp_search_name_hash.
2937 * NEWS: Add entry about nested function support.
2938
2939 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
2940 Andrew Burgess <andrew.burgess@embecosm.com>
2941
2942 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2943 for nested static variables when searchin VAR_DOMAIN.
2944 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2945 global scope, update comment.
2946 (add_partial_subprogram): Call add_partial_subprogram recursively
2947 for nested subroutines when processinng Fortran.
2948 (load_partial_dies): Process the child entities of a subprogram
2949 when processing Fortran.
2950 (partial_die_parent_scope): Handle building scope
2951 for Fortran nested functions.
2952 (process_die): Record that nested functions have a scope.
2953 (new_symbol): Always record Fortran subprograms on the global
2954 symbol list.
2955 (determine_prefix): How to build the prefix for Fortran
2956 subprograms.
2957
2958 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2959
2960 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2961 have just sent the thread a SIGSTOP and are waiting for it to
2962 arrive.
2963
2964 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2965
2966 * btrace.c (btrace_add_pc): Remove whitespace before the template
2967 parameter in 'std::vector <...>'.
2968 (parse_xml_btrace_block): Likewise.
2969 (btrace_maint_decode_pt): Likewise.
2970 (btrace_maint_update_packets): Likewise.
2971 (btrace_maint_print_packets): Likewise.
2972 * btrace.h (struct btrace_maint_info): Likewise.
2973 * dwarf2read.c (struct type_unit_group): Likewise.
2974 (build_type_psymtabs_reader): Likewise.
2975 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2976 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2977 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2978
2979 2019-10-03 Tom de Vries <tdevries@suse.de>
2980
2981 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2982 the first line of the help text for set/show style metadata.
2983
2984 2019-10-02 Tom Tromey <tromey@adacore.com>
2985
2986 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2987 * gdbsupport/common-inferior.c: New file.
2988 * infcmd.c (startup_with_shell): Don't define.
2989 * nat/fork-inferior.h (startup_with_shell): Don't declare.
2990 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2991 * inferior.h (startup_with_shell): Don't declare.
2992
2993 2019-10-02 Christian Biesinger <cbiesinger@google.com>
2994
2995 * gdbsupport/gdb_assert.h: Include errors.h.
2996 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2997
2998 2019-10-02 Tom Tromey <tromey@adacore.com>
2999
3000 * NEWS: Add $_ada_exception entry.
3001 * ada-lang.c (struct ada_catchpoint): Add constructor.
3002 <m_kind>: New member.
3003 (allocate_location_exception, re_set_exception): Remove
3004 "ex" parameter.
3005 (should_stop_exception): Compute $_ada_exception.
3006 (check_status_exception, print_it_exception)
3007 (print_one_exception, print_mention_exception): Remove
3008 "ex" parameter.
3009 (allocate_location_catch_exception, re_set_catch_exception)
3010 (check_status_exception, print_it_catch_exception)
3011 (print_one_catch_exception, print_mention_catch_exception)
3012 (print_recreate_catch_exception)
3013 (allocate_location_catch_exception_unhandled)
3014 (re_set_catch_exception_unhandled)
3015 (check_status_exception, print_it_catch_exception_unhandled)
3016 (print_one_catch_exception_unhandled)
3017 (print_mention_catch_exception_unhandled)
3018 (print_recreate_catch_exception_unhandled)
3019 (allocate_location_catch_assert, re_set_catch_assert)
3020 (check_status_assert, print_it_catch_assert)
3021 (print_one_catch_assert, print_mention_catch_assert)
3022 (print_recreate_catch_assert)
3023 (allocate_location_catch_handlers, re_set_catch_handlers)
3024 (check_status_handlers, print_it_catch_handlers)
3025 (print_one_catch_handlers, print_mention_catch_handlers)
3026 (print_recreate_catch_handlers): Remove.
3027 (create_ada_exception_catchpoint): Update.
3028 (initialize_ada_catchpoint_ops): Update.
3029
3030 2019-10-02 Tom Tromey <tromey@adacore.com>
3031
3032 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3033 (create_excep_cond_exprs): Simplify exception string computation.
3034 (ada_exception_catchpoint_cond_string): Likewise.
3035
3036 2019-10-02 Tom Tromey <tromey@adacore.com>
3037
3038 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3039 * ada-lang.c (lesseq_defined_than): Handle
3040 LOC_STATIC.
3041 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3042 parameter.
3043 (dwarf2_has_info): Likewise.
3044 (new_symbol): Set maybe_copied on symbol when
3045 appropriate.
3046 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3047 parameter.
3048 <can_copy>: New member.
3049 * elfread.c (record_minimal_symbol): Set maybe_copied
3050 on symbol when appropriate.
3051 (elf_symfile_read): Update call to dwarf2_has_info.
3052 * minsyms.c (lookup_minimal_symbol_linkage): New
3053 function.
3054 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3055 * symtab.c (get_symbol_address, get_msymbol_address):
3056 New functions.
3057 * symtab.h (get_symbol_address, get_msymbol_address):
3058 Declare.
3059 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3060 maybe_copied.
3061 (struct symbol, struct minimal_symbol) <maybe_copied>:
3062 New member.
3063
3064 2019-10-02 Tom Tromey <tromey@adacore.com>
3065
3066 * source.c (struct current_source_location): New.
3067 (current_source_key): New global.
3068 (current_source_symtab, current_source_line)
3069 (current_source_pspace): Remove.
3070 (get_source_location): New function.
3071 (get_current_source_symtab_and_line)
3072 (set_default_source_symtab_and_line)
3073 (set_current_source_symtab_and_line)
3074 (clear_current_source_symtab_and_line, select_source_symtab)
3075 (info_source_command, print_source_lines_base)
3076 (info_line_command, search_command_helper, _initialize_source):
3077 Update.
3078
3079 2019-10-02 Tom Tromey <tromey@adacore.com>
3080
3081 * source.c (select_source_symtab): Don't call
3082 decode_line_with_current_source.
3083
3084 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3085
3086 * symtab.c (lookup_global_symbol): Search global block.
3087
3088 2019-10-02 Tom Tromey <tromey@adacore.com>
3089
3090 * coffread.c (process_coff_symbol): Update.
3091 * dwarf2read.c (var_decode_location, new_symbol): Update.
3092 * mdebugread.c (parse_symbol): Update.
3093 * objfiles.c (relocate_one_symbol): Update.
3094 * stabsread.c (define_symbol, fix_common_block)
3095 (scan_file_globals): Update.
3096 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3097 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3098 * xcoffread.c (process_xcoff_symbol): Update.
3099
3100 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3101
3102 * MAINTAINERS: Update my email address.
3103
3104 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3105
3106 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3107 std::vector.
3108 (build_type_psymtabs_reader): Update for std::vector.
3109 (build_type_psymtab_dependencies): Likewise.
3110 * dwarf2read.h: Remove use of DEF_VEC_P.
3111 (typedef sig_type_ptr): Delete.
3112
3113 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3114
3115 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3116 to std::vector.
3117 (btrace_maint_decode_pt): Likewise, and move allocation of the
3118 vector outside of the loop.
3119 (btrace_maint_update_packets): Update to handle change from VEC to
3120 std::vector.
3121 (btrace_maint_print_packets): Likewise.
3122 (maint_info_btrace_cmd): Likewise.
3123 * btrace.h: Remove use of DEF_VEC_O.
3124 (typedef btrace_pt_packet_s): Delete.
3125 (struct btrace_maint_info) <packets>: Change fromm VEC to
3126 std::vector.
3127 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3128
3129 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3130
3131 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3132 make accesses into the vector constant references.
3133 (btrace_add_pc): Update for std::vector.
3134 (btrace_stitch_bts): Likewise.
3135 (parse_xml_btrace_block): Likewise.
3136 (btrace_maint_update_packets): Likewise.
3137 (btrace_maint_print_packets): Likewise.
3138 (maint_info_btrace_cmd): Likewise.
3139 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3140 std::vector.
3141 (btrace_data::empty): Likewise.
3142 (btrace_data_append): Likewise.
3143 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3144 (typedef btrace_block_s): Delete.
3145 (struct btrace_block): Add constructor.
3146 (struct btrace_data_bts) <blocks>: Change to std::vector.
3147 * nat/linux-btrace.c (perf_event_read_bts): Update for
3148 std::vector.
3149 (linux_read_bts): Likewise.
3150
3151 2019-10-01 Tom Tromey <tom@tromey.com>
3152
3153 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3154
3155 2019-10-01 Tom Tromey <tom@tromey.com>
3156
3157 * stack.c (print_frame, info_frame_command_core): Use
3158 styled_string.
3159 * linux-thread-db.c (try_thread_db_load_1)
3160 (try_thread_db_load_from_pdir_1): Use styled_string.
3161 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3162 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3163 (maybe_print_unsupported_script_warning)
3164 (maybe_print_script_not_found_warning): Use styled_string.
3165 * ada-lang.c (user_select_syms): Use styled_string.
3166
3167 2019-10-01 Tom Tromey <tom@tromey.com>
3168
3169 * p-lang.c (pascal_printstr): Use metadata style.
3170 * value.c (show_convenience): Use metadata style.
3171 * valprint.c (valprint_check_validity, val_print_optimized_out)
3172 (val_print_not_saved, val_print_unavailable)
3173 (val_print_invalid_address, generic_val_print, val_print)
3174 (value_check_printable, val_print_array_elements): Use metadata
3175 style.
3176 * ui-out.h (class ui_out) <field_fmt>: New overload.
3177 <do_field_fmt>: Add style parameter.
3178 * ui-out.c (ui_out::field_fmt): New overload.
3179 * typeprint.c (type_print_unknown_return_type)
3180 (val_print_not_allocated, val_print_not_associated): Use metadata
3181 style.
3182 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3183 parameter.
3184 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3185 * tracepoint.c (tvariables_info_1): Use metadata style.
3186 * stack.c (print_frame_arg, print_frame_info, print_frame)
3187 (info_frame_command_core): Use metadata style.
3188 * skip.c (info_skip_command): Use metadata style.
3189 * rust-lang.c (rust_print_enum): Use metadata style.
3190 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3191 metadata style.
3192 * python/py-framefilter.c (py_print_single_arg): Use metadata
3193 style.
3194 * printcmd.c (do_one_display, print_variable_and_value): Use
3195 metadata style.
3196 * p-valprint.c (pascal_val_print)
3197 (pascal_object_print_value_fields): Use metadata style.
3198 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3199 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3200 parameter.
3201 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3202 * m2-valprint.c (m2_print_long_set): Use metadata style.
3203 * m2-typeprint.c (m2_print_type): Use metadata style.
3204 * infcmd.c (print_return_value_1): Use metadata style.
3205 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3206 * f-valprint.c (info_common_command_for_block): Use metadata
3207 style.
3208 * f-typeprint.c (f_type_print_base): Use metadata style.
3209 * expprint.c (print_subexp_standard): Use metadata style.
3210 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3211 * cli/cli-style.h (class cli_style_option): Add constructor.
3212 (metadata_style): Declare.
3213 * cli/cli-style.c (metadata_style): New global.
3214 (_initialize_cli_style): Register metadata style.
3215 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3216 parameter.
3217 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3218 * c-typeprint.c (c_type_print_base_struct_union)
3219 (c_type_print_base_1): Use metadata style.
3220 * breakpoint.c (watchpoint_value_print)
3221 (print_one_breakpoint_location): Use metadata style.
3222 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3223 style.
3224 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3225 style.
3226 * ada-valprint.c (val_print_packed_array_elements, printstr)
3227 (print_field_values, ada_val_print_ref, ada_val_print): Use
3228 metadata style.
3229 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3230 style.
3231 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3232 style.
3233 * ada-lang.c (user_select_syms): Use metadata style.
3234
3235 2019-10-01 Tom Tromey <tom@tromey.com>
3236
3237 * cli/cli-cmds.c (pwd_command): Style output.
3238
3239 2019-10-01 Pedro Alves <palves@redhat.com>
3240 Tom Tromey <tom@tromey.com>
3241
3242 * symtab.c (print_symbol_info): Use %ps.
3243 (print_msymbol_info): Use %ps.
3244 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3245 * printcmd.c (print_variable_and_value): Use %ps.
3246 * macrocmd.c (show_pp_source_pos): Use %ps.
3247 * infrun.c (print_exited_reason): Use ui_out::message.
3248 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3249 (describe_other_breakpoints): Use ui_out::message and new
3250 formats.
3251 (say_where): Use new formats.
3252 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3253 and new formats.
3254
3255 2019-10-01 Pedro Alves <palves@redhat.com>
3256 Tom Tromey <tom@tromey.com>
3257
3258 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3259 (test_gdb_formats): New function.
3260 (run_tests): Call it.
3261 (test_format_specifier): Update.
3262 * utils.h (fputs_filtered): Update comment.
3263 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3264 (fputs_styled_unfiltered): Declare.
3265 * utils.c (fputs_styled_unfiltered): New function.
3266 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3267 (vfprintf_filtered): Update.
3268 (vfprintf_unfiltered, vprintf_filtered): Update.
3269 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3270 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3271 disallow_ui_out_field>: New constants.
3272 (enum class field_kind): New.
3273 (struct base_field_s, struct signed_field_s): New.
3274 (signed_field): New function.
3275 (struct string_field_s): New.
3276 (string_field): New function.
3277 (struct styled_string_s): New.
3278 (styled_string): New function.
3279 (class ui_out) <message>: Add comment.
3280 <vmessage, call_do_message>: New methods.
3281 <do_message>: Add style parameter.
3282 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3283 methods.
3284 (ui_out::message): Rewrite.
3285 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3286 parameter.
3287 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3288 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3289 gdb_extensions parameter.
3290 (class format_piece): Add parameter to constructor.
3291 (n_int_args): New field.
3292 * gdbsupport/format.c (format_pieces::format_pieces): Add
3293 gdb_extensions parameter. Handle '*'.
3294 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3295 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3296 vfprintf_styled_no_gdbfmt.
3297 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3298 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3299 unfiltered output.
3300 * ui-style.h (struct ui_file_style) <ptr>: New method.
3301
3302 2019-10-01 Tom Tromey <tom@tromey.com>
3303
3304 * unittests/format_pieces-selftests.c: Update. Add final format.
3305 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3306 empty literal pieces.
3307
3308 2019-10-01 Tom Tromey <tom@tromey.com>
3309
3310 * ui-out.h (enum class ui_out_style_kind): Remove.
3311 (class ui_out) <field_string, field_stsream, do_field_string>:
3312 Change type of "style".
3313 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3314 (ui_out::field_string): Update.
3315 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3316 of "style".
3317 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3318 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3319 * stack.c (print_frame_arg, print_frame_info, print_frame):
3320 Update.
3321 * source.c (print_source_lines_base): Update.
3322 * solib.c (info_sharedlibrary_command): Update.
3323 * skip.c (info_skip_command): Update.
3324 * record-btrace.c (btrace_call_history_src_line)
3325 (btrace_call_history): Update.
3326 * python/py-framefilter.c (py_print_frame): Update.
3327 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3328 "style".
3329 * mi/mi-out.c (mi_ui_out::do_table_header)
3330 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3331 (mi_ui_out::do_field_string): Update.
3332 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3333 Update.
3334 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3335 "style".
3336 * cli-out.c (cli_ui_out::do_table_header)
3337 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3338 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3339 (cli_ui_out::do_field_fmt): Update.
3340 * breakpoint.c (print_breakpoint_location): Update.
3341 (update_static_tracepoint): Update.
3342
3343 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3344
3345 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3346 conversion of gdb_datadir.
3347 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3348 remove not needed c_str ().
3349
3350 2019-09-30 Ali Tamur <tamur@google.com>
3351
3352 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3353 (dwarf2_string_attr): Likewise.
3354
3355 2019-09-30 Ali Tamur <tamur@google.com>
3356
3357 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3358 (process_full_type_unit): Likewise.
3359 (dump_die_shallow): Likewise.
3360 (cu_debug_loc_section): Likewise.
3361
3362 2019-09-28 Christian Biesinger <cbiesinger@google.com>
3363
3364 * minsyms.c (compare_minimal_symbols): Rename to...
3365 (minimal_symbol_is_less_than): ...this, and adjust to STL
3366 conventions (return bool, take arguments as references)
3367 (minimal_symbol_reader::install): Call std::sort instead
3368 of qsort.
3369
3370 2019-09-29 Christian Biesinger <cbiesinger@google.com>
3371
3372 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3373 hash and why.
3374 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3375 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3376
3377 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3378
3379 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3380 * psympriv.h (add_psymbol_to_list): Move comment here and update
3381 it.
3382
3383 2019-09-29 Tom de Vries <tdevries@suse.de>
3384
3385 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3386 Use $tmpdir/$(basename "$output_file").dwz instead of
3387 "${output_file}.dwz".
3388
3389 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3390
3391 PR gdb/25045
3392 * hppa-linux-nat.c: Include gdbarch.h.
3393
3394 2019-09-26 Christian Biesinger <cbiesinger@google.com>
3395
3396 * blockframe.c (find_pc_partial_function): Change return type to bool.
3397 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3398 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3399 (stub_gnu_ifunc_resolve_name): Likewise.
3400 * symtab.c (compare_filenames_for_search): Likewise.
3401 (compare_glob_filenames_for_search): Likewise.
3402 (matching_obj_sections): Likewise.
3403 (symbol_matches_domain): Likewise.
3404 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3405 (find_line_pc): Change return type to bool.
3406 (find_line_pc_range): Likewise.
3407 (producer_is_realview): Likewise.
3408 * symtab.h (symbol_matches_domain): Likewise.
3409 (find_pc_partial_function): Likewise.
3410 (find_pc_line_pc_range): Likewise.
3411 (in_gnu_ifunc_stub): Likewise.
3412 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3413 (find_line_pc): Likewise.
3414 (find_line_pc_range): Likewise.
3415 (matching_obj_sections): Likewise.
3416 (find_line_symtab): Change out parameter to bool.
3417 (producer_is_realview): Change return type to bool.
3418 (compare_filenames_for_search): Likewise.
3419 (compare_glob_filenames_for_search): Likewise.
3420
3421 2019-09-26 Tom Tromey <tom@tromey.com>
3422
3423 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3424 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3425 * gdb_usleep.h: Remove.
3426 * gdb_usleep.c: Remove.
3427 * utils.c: Don't include gdb_usleep.h.
3428
3429 2019-09-26 Tom Tromey <tromey@adacore.com>
3430
3431 * python/py-type.c (type_to_type_object): Call check_typedef
3432 for stub types.
3433
3434 2019-09-26 Tom Tromey <tom@tromey.com>
3435
3436 * utils.h (initialize_utils): Don't declare.
3437 * top.c (gdb_init): Don't call initialize_utils.
3438 * utils.c (initialize_utils): Remove. Move contents...
3439 (_initialize_utils): ... here.
3440
3441 2019-09-25 Tom Tromey <tom@tromey.com>
3442
3443 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3444 * utils.h (make_hex_string): Don't declare.
3445 * utils.c (make_hex_string): Remove.
3446
3447 2019-09-24 Tom de Vries <tdevries@suse.de>
3448
3449 PR gdb/23815
3450 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3451 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3452
3453 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3454
3455 * NEWS: Mention new simulator port for PRU.
3456
3457 2019-09-23 Christian Biesinger <cbiesinger@google.com>
3458
3459 * ada-exp.y (write_object_remaining): Update.
3460 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3461 and eliminate the static buffer.
3462 (ada_decode_symbol): Update.
3463 (ada_la_decode): Update.
3464 (ada_sniff_from_mangled_name): Update.
3465 (is_valid_name_for_wild_match): Update.
3466 (ada_lookup_name_info::matches): Update and simplify.
3467 (name_matches_regex): Update.
3468 (ada_add_global_exceptions): Update.
3469 * ada-lang.h (ada_decode): Update signature.
3470 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3471 * dwarf-index-write.c (debug_names::insert): Update.
3472
3473 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3474
3475 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3476 formatting.
3477
3478 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3479
3480 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3481 Change "nonzero" to "true" in documentation.
3482
3483 2019-09-20 Christian Biesinger <cbiesinger@google.com>
3484
3485 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3486 (_initialize_darwin_solib): Don't set
3487 darwin_so_ops.lookup_lib_global_symbol.
3488 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3489 set_gdbarch_iterate_over_objfiles_in_search_order.
3490 (elf_lookup_lib_symbol): Rename to...
3491 (svr4_iterate_over_objfiles_in_search_order): this, and update
3492 to iterate semantics.
3493 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3494 * solib.c (solib_global_lookup): Remove.
3495 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3496 (solib_global_lookup): Remove.
3497 * symtab.c (lookup_global_or_static_symbol): Remove call to
3498 solib_global_lookup.
3499
3500 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3501
3502 * NEWS: Move entries about default MI version now being
3503 version 3, and about the GDB/MI fix for multi-location
3504 breakpoints to the "since GDB 8.3" section.
3505
3506 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3507
3508 GDB 8.3.1 released.
3509
3510 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3511
3512 * NEWS: Mention that Cell/B.E. debugging support was removed.
3513 * MAINTAINERS: Remove spu target.
3514
3515 * config/djgpp/fnchange.lst: Remove entries for removed files.
3516
3517 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3518 spu-multiarch.o, and spu-tdep.o.
3519 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3520 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3521 spu-multiarch.c, and spu-tdep.c.
3522 * spu-linux-nat.c: Remove file.
3523 * spu-multiarch.c: Remove file.
3524 * spu-tdep.c: Remove file.
3525 * spu-tdep.h: Remove file.
3526 * solib-spu.c: Remove file.
3527 * solib-spu.h: Remove file.
3528
3529 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3530 * configure.nat (spu-linux): Remove.
3531 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3532 solib-multiarch.o from gdb_target_obs.
3533 (spu*-*-*): Remove.
3534
3535 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3536 feature flag.
3537 (ppc_linux_no_features): Update.
3538 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3539 Cell/B.E. support.
3540 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3541 (tdesc_powerpc_cell64l): Likewise.
3542 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3543 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3544 Cell/B.E. support.
3545 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3546 Do not include "features/rs6000/powerpc-cell32l.c" or
3547 "features/rs6000/powerpc-cell64l.c".
3548 (ppc_linux_spu_section): Remove.
3549 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3550 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3551 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3552 (ppc_linux_spe_context_lookup): Remove.
3553 (ppc_linux_spe_context_inferior_created): Remove.
3554 (ppc_linux_spe_context_solib_loaded): Remove.
3555 (ppc_linux_spe_context_solib_unloaded): Remove.
3556 (ppc_linux_spe_context): Remove.
3557 (struct ppu2spu_cache): Remove.
3558 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3559 (struct ppu2spu_data): Remove.
3560 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3561 ppu2spu_unwind): Remove.
3562 (ppc_linux_init_abi): Remove Cell/B.E. support.
3563 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3564
3565 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3566 (rs6000/powerpc-cell64l-expedite): Likewise
3567 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3568 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3569 rs6000/powerpc-cell64l.xml.
3570 * features/rs6000/powerpc-cell32l.xml: Remove.
3571 * features/rs6000/powerpc-cell64l.xml: Likewise.
3572 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3573 * features/rs6000/powerpc-cell64l.c: Likewise.
3574 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3575 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3576 * regformats/reg-spu.dat: Remove.
3577
3578 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3579 * corelow.c (struct spuid_list): Remove.
3580 (add_to_spuid_list): Remove.
3581 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3582 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3583 (remote_protocol_features): Remove associated entries.
3584 (_initialize_remote): No longer initialize them.
3585 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3586 * linux-nat.c (SPUFS_MAGIC): Remove.
3587 (linux_proc_xfer_spu): Remove.
3588 (spu_enumerate_spu_ids): Remove.
3589 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3590 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3591 (linux_make_corefile_notes): No longer call it.
3592
3593 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3594 (cooked_write_test): Likewise.
3595
3596 2019-09-20 Tom Tromey <tom@tromey.com>
3597
3598 * NEWS: Mention case-sensitivity of TUI commands.
3599 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3600 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3601 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3602
3603 2019-09-20 Tom Tromey <tom@tromey.com>
3604
3605 * tui/tui-source.c (tui_source_window::set_contents): Use
3606 make_unique_xstrdup.
3607 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3608 make_unique_xstrdup.
3609
3610 2019-09-20 Tom Tromey <tom@tromey.com>
3611
3612 * tui/tui-data.c: Remove separator comments.
3613 * tui/tui-layout.c: Remove separator comments.
3614 * tui/tui-win.c: Remove separator comments.
3615 * tui/tui-wingeneral.c: Remove separator comments.
3616
3617 2019-09-20 Tom Tromey <tom@tromey.com>
3618
3619 * tui/tui.h (strcat_to_buf): Don't declare.
3620 * tui/tui.c (strcat_to_buf): Remove.
3621
3622 2019-09-20 Tom Tromey <tom@tromey.com>
3623
3624 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3625 from "fullname".
3626 * tui/tui-source.c (tui_source_window::set_contents)
3627 (tui_source_window::location_matches_p)
3628 (tui_source_window::maybe_update): Update.
3629
3630 2019-09-20 Tom Tromey <tom@tromey.com>
3631
3632 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3633 Update.
3634 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3635 prefix.
3636 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3637 (tui_data_window::line_from_reg_element_no)
3638 (tui_data_window::first_reg_element_no_inline)
3639 (tui_data_window::show_registers)
3640 (tui_data_window::show_register_group)
3641 (tui_data_window::display_registers_from)
3642 (tui_data_window::display_registers_from_line)
3643 (tui_data_window::first_data_item_displayed)
3644 (tui_data_window::delete_data_content_windows)
3645 (tui_data_window::erase_data_content)
3646 (tui_data_window::do_scroll_vertical)
3647 (tui_data_window::refresh_window)
3648 (tui_data_window::check_register_values): Update.
3649
3650 2019-09-20 Tom Tromey <tom@tromey.com>
3651
3652 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3653 (struct tui_locator_window) <full_name, proc_name>: Now
3654 std::string.
3655 * tui/tui-stack.c (tui_locator_window::make_status_line)
3656 (tui_locator_window::set_locator_fullname)
3657 (tui_locator_window::set_locator_info): Update.
3658 * tui/tui-source.c (tui_source_window::set_contents)
3659 (tui_source_window::showing_source_p): Update.
3660
3661 2019-09-20 Tom Tromey <tom@tromey.com>
3662
3663 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3664 Don't call tui_locator_win_info_ptr.
3665
3666 2019-09-20 Tom Tromey <tom@tromey.com>
3667
3668 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3669
3670 2019-09-20 Tom Tromey <tom@tromey.com>
3671
3672 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3673 height for locator.
3674 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3675 * tui/tui-layout.c (show_source_disasm_command, show_data)
3676 (show_source_or_disasm_and_command): Use 1 as height for locator.
3677
3678 2019-09-20 Tom Tromey <tom@tromey.com>
3679
3680 * tui/tui.c (tui_enable): Update.
3681 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3682 Update.
3683 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3684 Update.
3685 * tui/tui-data.c (win_resized): Now bool.
3686 (tui_win_resized): Return bool.
3687 (tui_set_win_resized_to): Accept a bool.
3688
3689 2019-09-20 Tom Tromey <tom@tromey.com>
3690
3691 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3692 Change type of "refresh_values_only".
3693 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3694 type of "refresh_values_only".
3695
3696 2019-09-20 Tom Tromey <tom@tromey.com>
3697
3698 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3699 std::string.
3700 (tui_disassemble): Add "pos" parameter.
3701 (tui_disasm_window::set_contents): Simplify.
3702
3703 2019-09-20 Tom Tromey <tom@tromey.com>
3704
3705 * tui/tui-winsource.h (struct tui_source_window_base)
3706 <show_source_content>: Now private.
3707 * tui/tui-winsource.c
3708 (tui_source_window_base::show_source_content): Don't handle empty
3709 content case.
3710
3711 2019-09-20 Tom Tromey <tom@tromey.com>
3712
3713 * tui/tui-layout.c (show_source_disasm_command)
3714 (show_source_or_disasm_and_command): Don't call
3715 show_source_content.
3716
3717 2019-09-20 Tom Tromey <tom@tromey.com>
3718
3719 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3720 Declare.
3721 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3722 from tui_make_status_line.
3723 (tui_locator_window::rerender): Update.
3724
3725 2019-09-20 Tom Tromey <tom@tromey.com>
3726
3727 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3728 (tui_locator_window::rerender): Update.
3729
3730 2019-09-20 Tom Tromey <tom@tromey.com>
3731
3732 * tui/tui-winsource.h (struct tui_source_window_base)
3733 <~tui_source_window_base>: Don't declare.
3734 <fullname>: Remove.
3735 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3736 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3737 member.
3738 * tui/tui-source.c (tui_source_window::set_contents): Update.
3739 (tui_source_window::location_matches_p)
3740 (tui_source_window::maybe_update): Update.
3741
3742 2019-09-20 Tom Tromey <tom@tromey.com>
3743
3744 * tui/tui-winsource.h (~tui_source_element): Remove.
3745 (tui_source_element): Update.
3746 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3747 * tui/tui-winsource.c (tui_show_source_line): Update.
3748 * tui/tui-source.c (tui_source_window::set_contents): Update.
3749 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3750
3751 2019-09-20 Tom Tromey <tom@tromey.com>
3752
3753 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3754 declare.
3755 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3756 tui_clear_source_windows_detail.
3757 * tui/tui-winsource.h (struct tui_source_window_base)
3758 <clear_detail>: Don't declare.
3759 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3760 Remove.
3761 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3762
3763 2019-09-20 Tom Tromey <tromey@adacore.com>
3764
3765 PR ada/24919:
3766 * block.c (contained_in): Fix final return value.
3767
3768 2019-09-20 Alan Modra <amodra@gmail.com>
3769
3770 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3771 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3772 (read_indirect_string_from_dwz): Use bfd accessor.
3773 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3774 * machoread.c (macho_symfile_read_all_oso): Likewise.
3775 * solib.c (solib_bfd_open): Likewise.
3776
3777 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3778
3779 * eval.c: Move declaration of overload_resolution to...
3780 * value.h: ...here.
3781
3782 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3783
3784 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3785 * arm-linux-tdep.c: Likewise.
3786 * arm-nbsd-nat.c: Likewise.
3787 * arm-tdep.h: Declare arm_apcs_32.
3788 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3789
3790 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3791
3792 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3793 * dwarf2read.h: Declare dwarf_always_disassemble.
3794
3795 2019-09-19 Tom de Vries <tdevries@suse.de>
3796
3797 PR gdb/25009
3798 * source-cache.c (source_cache::ensure): Catch exception thrown during
3799 construction of the highlighter.
3800
3801 2019-09-18 Alan Modra <amodra@gmail.com>
3802
3803 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3804 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3805 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3806 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3807 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3808 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3809 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3810 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3811 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3812 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3813 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3814 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3815 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3816 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3817 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3818 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3819 * mi/mi-interp.c: Update throughout for bfd section macro and
3820 function changes.
3821 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3822 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3823
3824 2019-09-18 Tom Tromey <tom@tromey.com>
3825
3826 * NEWS: Add entry.
3827 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3828 call rl_initialize.
3829 (tui_enable): Do not call rl_initialize.
3830
3831 2019-09-18 Christian Groessler <chris@groessler.org>
3832
3833 * alpha-linux-nat.c: Include gdbarch.h.
3834
3835 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3836
3837 * ui-file.c: Include cli/cli-style.h.
3838 (term_cli_styling): Remove cli_styling declaration.
3839
3840 2019-09-18 Alan Modra <amodra@gmail.com>
3841
3842 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3843 to bfd_asymbol_section.
3844
3845 2019-09-18 Alan Modra <amodra@gmail.com>
3846
3847 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3848 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3849 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3850
3851 2019-09-18 Alan Modra <amodra@gmail.com>
3852
3853 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3854 * spu-linux-nat.c (spu_bfd_open): Likewise.
3855
3856 2019-09-18 Christian Biesinger <cbiesinger@google.com>
3857
3858 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3859 to bool to match definition in dwarf2read.c.
3860
3861 2019-09-17 Christian Biesinger <cbiesinger@google.com>
3862
3863 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3864 (print_signatures): Likewise.
3865 (trust_pad_over_xvs): Likewise.
3866 * arch/aarch64-insn.c (aarch64_debug): Likewise.
3867 * arch/aarch64-insn.h (aarch64_debug): Likewise.
3868 * arm-linux-nat.c (arm_apcs_32): Likewise.
3869 * arm-linux-tdep.c (arm_apcs_32): Likewise.
3870 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3871 * arm-tdep.c (arm_debug): Likewise.
3872 (arm_apcs_32): Likewise.
3873 * auto-load.c (debug_auto_load): Likewise.
3874 (auto_load_gdb_scripts): Likewise.
3875 (global_auto_load): Likewise.
3876 (auto_load_local_gdbinit): Likewise.
3877 (auto_load_local_gdbinit_loaded): Likewise.
3878 * auto-load.h (global_auto_load): Likewise.
3879 (auto_load_local_gdbinit): Likewise.
3880 (auto_load_local_gdbinit_loaded): Likewise.
3881 * breakpoint.c (disconnected_dprintf): Likewise.
3882 (breakpoint_proceeded): Likewise.
3883 (automatic_hardware_breakpoints): Likewise.
3884 (always_inserted_mode): Likewise.
3885 (target_exact_watchpoints): Likewise.
3886 (_initialize_breakpoint): Update.
3887 * breakpoint.h (target_exact_watchpoints): Change to bool.
3888 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3889 * cli/cli-cmds.c (trace_commands): Likewise.
3890 * cli/cli-cmds.h (trace_commands): Likewise.
3891 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3892 to bool*.
3893 * cli/cli-logging.c (logging_overwrite): Change to bool.
3894 (logging_redirect): Likewise.
3895 (debug_redirect): Likewise.
3896 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3897 (struct boolean_option_def) <get_var_address_cb_>: Change return type
3898 to bool.
3899 <boolean_option_def>: Update.
3900 (struct flag_option_def): Change default type of Context to bool
3901 from int.
3902 <flag_option_def>: Change return type of var_address_cb_ to bool*.
3903 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3904 (get_setshow_command_value_string): Likewise.
3905 * cli/cli-style.c (cli_styling): Change to bool.
3906 (source_styling): Likewise.
3907 * cli/cli-style.h (source_styling): Likewise.
3908 (cli_styling): Likewise.
3909 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3910 to bool.
3911 * command.h (var_types): Update comment.
3912 (add_setshow_boolean_cmd): Change int* var argument to bool*.
3913 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3914 bool.
3915 (debug_compile_cplus_scopes): Likewise.
3916 * compile/compile-internal.h (compile_debug): Likewise.
3917 * compile/compile.c (compile_debug): Likewise.
3918 (struct compile_options) <raw>: Likewise.
3919 * cp-support.c (catch_demangler_crashes): Likewise.
3920 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3921 (usr_cmd_cris_dwarf2_cfi): Likewise.
3922 * csky-tdep.c (csky_debug): Likewise.
3923 * darwin-nat.c (enable_mach_exceptions): Likewise.
3924 * dcache.c (dcache_enabled_p): Likewise.
3925 * defs.h (info_verbose): Likewise.
3926 * demangle.c (demangle): Likewise.
3927 (asm_demangle): Likewise.
3928 * dwarf-index-cache.c (debug_index_cache): Likewise.
3929 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3930 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3931 * dwarf2read.c (check_physname): Likewise.
3932 (use_deprecated_index_sections): Likewise.
3933 (dwarf_always_disassemble): Likewise.
3934 * eval.c (overload_resolution): Likewise.
3935 * event-top.c (set_editing_cmd_var): Likewise.
3936 (exec_done_display_p): Likewise.
3937 * event-top.h (set_editing_cmd_var): Likewise.
3938 (exec_done_display_p): Likewise.
3939 * exec.c (write_files): Likewise.
3940 * fbsd-nat.c (debug_fbsd_lwp): Likewise
3941 (debug_fbsd_nat): Likewise.
3942 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3943 Likewise.
3944 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3945 <backtrace_past_entry> Likewise.
3946 * gdb-demangle.h (demangle): Likewise.
3947 (asm_demangle): Likewise.
3948 * gdb_bfd.c (bfd_sharing): Likewise.
3949 * gdbcore.h (write_files): Likewise.
3950 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3951 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3952 * gdbthread.h (print_thread_events): Likewise.
3953 * gdbtypes.c (opaque_type_resolution): Likewise.
3954 (strict_type_checking): Likewise.
3955 * gnu-nat.c (gnu_debug_flag): Likewise.
3956 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3957 * guile/scm-param.c (pascm_variable): Add boolval.
3958 (add_setshow_generic): Update.
3959 (pascm_param_value): Update.
3960 (pascm_set_param_value_x): Update.
3961 * hppa-tdep.c (hppa_debug): Change to bool..
3962 * infcall.c (may_call_functions_p): Likewise.
3963 (coerce_float_to_double_p): Likewise.
3964 (unwind_on_signal_p): Likewise.
3965 (unwind_on_terminating_exception_p): Likewise.
3966 * infcmd.c (startup_with_shell): Likewise.
3967 * inferior.c (print_inferior_events): Likewise.
3968 * inferior.h (startup_with_shell): Likewise.
3969 (print_inferior_events): Likewise.
3970 * infrun.c (step_stop_if_no_debug): Likewise.
3971 (detach_fork): Likewise.
3972 (debug_displaced): Likewise.
3973 (disable_randomization): Likewise.
3974 (non_stop): Likewise.
3975 (non_stop_1): Likewise.
3976 (observer_mode): Likewise.
3977 (observer_mode_1): Likewise.
3978 (set_observer_mode): Update.
3979 (sched_multi): Change to bool.
3980 * infrun.h (debug_displaced): Likewise.
3981 (sched_multi): Likewise.
3982 (step_stop_if_no_debug): Likewise.
3983 (non_stop): Likewise.
3984 (disable_randomization): Likewise.
3985 * linux-tdep.c (use_coredump_filter): Likewise.
3986 (dump_excluded_mappings): Likewise.
3987 * linux-thread-db.c (auto_load_thread_db): Likewise.
3988 (check_thread_db_on_load): Likewise.
3989 * main.c (captured_main_1): Update.
3990 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3991 xx2_opt, boolean_opt>: Change to bool.
3992 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3993 * maint.c (maintenance_profile_p): Likewise.
3994 (per_command_time): Likewise.
3995 (per_command_space): Likewise.
3996 (per_command_symtab): Likewise.
3997 * memattr.c (inaccessible_by_default): Likewise.
3998 * mi/mi-main.c (mi_async): Likewise.
3999 (mi_async_1): Likewise.
4000 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4001 * nat/fork-inferior.h (startup_with_shell): Likewise.
4002 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4003 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4004 * nios2-tdep.c (nios2_debug): Likewise.
4005 * or1k-tdep.c (or1k_debug): Likewise.
4006 * parse.c (parser_debug): Likewise.
4007 * parser-defs.h (parser_debug): Likewise.
4008 * printcmd.c (print_symbol_filename): Likewise.
4009 * proc-api.c (procfs_trace): Likewise.
4010 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4011 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4012 (set_parameter_value): Update.
4013 (add_setshow_generic): Update.
4014 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4015 to bool*.
4016 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4017 int*.
4018 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4019 * record-btrace.c (record_btrace_target::store_registers): Update.
4020 * record-full.c (record_full_memory_query): Change to bool.
4021 (record_full_stop_at_limit): Likewise.
4022 * record-full.h (record_full_memory_query): Likewise.
4023 * remote-notif.c (notif_debug): Likewise.
4024 * remote-notif.h (notif_debug): Likewise.
4025 * remote.c (use_range_stepping): Likewise.
4026 (interrupt_on_connect): Likewise.
4027 (remote_break): Likewise.
4028 * ser-tcp.c (tcp_auto_retry): Likewise.
4029 * ser-unix.c (serial_hwflow): Likewise.
4030 * skip.c (debug_skip): Likewise.
4031 * solib-aix.c (solib_aix_debug): Likewise.
4032 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4033 (spu_auto_flush_cache_p): Likewise.
4034 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4035 Likewise.
4036 (struct info_print_options) <quiet>: Likewise.
4037 * symfile-debug.c (debug_symfile): Likewise.
4038 * symfile.c (auto_solib_add): Likewise.
4039 (separate_debug_file_debug): Likewise.
4040 * symfile.h (auto_solib_add): Likewise.
4041 (separate_debug_file_debug): Likewise.
4042 * symtab.c (basenames_may_differ): Likewise.
4043 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4044 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4045 (struct info_types_options) <quiet>: Likewise.
4046 * symtab.h (demangle): Likewise.
4047 (basenames_may_differ): Likewise.
4048 * target-dcache.c (stack_cache_enabled_1): Likewise.
4049 (code_cache_enabled_1): Likewise.
4050 * target.c (trust_readonly): Likewise.
4051 (may_write_registers): Likewise.
4052 (may_write_memory): Likewise.
4053 (may_insert_breakpoints): Likewise.
4054 (may_insert_tracepoints): Likewise.
4055 (may_insert_fast_tracepoints): Likewise.
4056 (may_stop): Likewise.
4057 (auto_connect_native_target): Likewise.
4058 (target_stop_and_wait): Update.
4059 (target_async_permitted): Change to bool.
4060 (target_async_permitted_1): Likewise.
4061 (may_write_registers_1): Likewise.
4062 (may_write_memory_1): Likewise.
4063 (may_insert_breakpoints_1): Likewise.
4064 (may_insert_tracepoints_1): Likewise.
4065 (may_insert_fast_tracepoints_1): Likewise.
4066 (may_stop_1): Likewise.
4067 * target.h (target_async_permitted): Likewise.
4068 (may_write_registers): Likewise.
4069 (may_write_memory): Likewise.
4070 (may_insert_breakpoints): Likewise.
4071 (may_insert_tracepoints): Likewise.
4072 (may_insert_fast_tracepoints): Likewise.
4073 (may_stop): Likewise.
4074 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4075 (make_thread_apply_all_options_def_group): Change argument from int*
4076 to bool*.
4077 (thread_apply_all_command): Update.
4078 (print_thread_events): Change to bool.
4079 * top.c (confirm): Likewise.
4080 (command_editing_p): Likewise.
4081 (history_expansion_p): Likewise.
4082 (write_history_p): Likewise.
4083 (info_verbose): Likewise.
4084 * top.h (confirm): Likewise.
4085 (history_expansion_p): Likewise.
4086 * tracepoint.c (disconnected_tracing): Likewise.
4087 (circular_trace_buffer): Likewise.
4088 * typeprint.c (print_methods): Likewise.
4089 (print_typedefs): Likewise.
4090 * utils.c (debug_timestamp): Likewise.
4091 (sevenbit_strings): Likewise.
4092 (pagination_enabled): Likewise.
4093 * utils.h (sevenbit_strings): Likewise.
4094 (pagination_enabled): Likewise.
4095 * valops.c (overload_resolution): Likewise.
4096 * valprint.h (struct value_print_options) <prettyformat_arrays,
4097 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4098 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4099 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4100 Likewise.
4101 * windows-nat.c (new_console): Likewise.
4102 (cygwin_exceptions): Likewise.
4103 (new_group): Likewise.
4104 (debug_exec): Likewise.
4105 (debug_events): Likewise.
4106 (debug_memory): Likewise.
4107 (debug_exceptions): Likewise.
4108 (useshell): Likewise.
4109 * windows-tdep.c (maint_display_all_tib): Likewise.
4110 * xml-support.c (debug_xml): Likewise.
4111
4112 2019-09-17 Mike Gulick <mgulick@mathworks.com>
4113
4114 * source.c (prepare_path_for_appending): New function.
4115 (openp): Make use of new function.
4116 (find_and_open_source): Search for the compilation directory and
4117 source file as a relative path beneath the directory search path.
4118
4119 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4120
4121 * source-cache.c (source_cache::get_line_charpos): Catch
4122 exceptions and return false, this matches the behaviour documented
4123 in the header file.
4124
4125 2019-09-17 Joel Brobecker <brobecker@adacore.com>
4126
4127 * ada-tasks.c (info_task): Remove quoting of the task's name.
4128
4129 2019-09-16 Christian Biesinger <cbiesinger@google.com>
4130
4131 * symfile.c (auto_solib_add): Replace comment with a reference
4132 to the header file.
4133
4134 2019-09-14 Christian Biesinger <cbiesinger@google.com>
4135
4136 * NEWS: Mention that gdb can now be compiled with Python 3
4137 on Windows.
4138
4139 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4140
4141 * maint.c (maint_print_section_data::maint_print_section_data):
4142 Force use of 'float log10 (float)' by casting the argument to
4143 float.
4144
4145 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4146
4147 * maint.c: Add 'cmath' include.
4148 (struct maint_print_section_data): New structure.
4149 (print_section_index): New function.
4150 (print_bfd_section_info): Add header comment, small whitespace
4151 cleanup, and update to call new print_section_index function.
4152 (print_objfile_section_info): Likewise.
4153 (maint_obj_section_from_bfd_section): New function.
4154 (print_bfd_section_info_maybe_relocated): New function.
4155 (maintenance_info_sections): Add header comment, always use
4156 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4157
4158 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4159
4160 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4161 inner scope, add check that the objfile has psymtabs before
4162 checking psymtabs_addrmap.
4163 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4164
4165 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4166
4167 * NEWS: Announce that Ada task names are now shown at more places,
4168 and between quotes (except in info task output).
4169 * gdb/ada-tasks.c (task_to_str): New function.
4170 (display_current_task_id): Call task_to_str.
4171 (task_command_1): Likewise.
4172 (print_ada_task_info): In non-mi mode, Properly align headers and data
4173 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4174
4175 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4176
4177 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4178 prstatus.pr_lwp.pr_info instead of making it up.
4179
4180 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4181
4182 * auto-load.c (auto_load_expand_dir_vars): Update.
4183 * defs.h (gdb_datadir): Change to std::string.
4184 (python_libdir): Likewise.
4185 (relocate_gdb_directory): Change return type to std::string.
4186 * guile/guile.c (gdbscm_data_directory): Update.
4187 (initialize_scheme_side): Update.
4188 * jit.c (jit_reader_dir): Change to std::string.
4189 (jit_reader_load_command): Update.
4190 * main.c (gdb_datadir): Change to std::string.
4191 (python_libdir): Likewise.
4192 (set_gdb_data_directory): Update.
4193 (relocate_path): Change to return std::string.
4194 (relocate_gdb_directory): Change to return std::string.
4195 (relocate_gdbinit_path_maybe_in_datadir): Update.
4196 (captured_main_1): Update.
4197 * python/python.c (do_start_initialization): Update.
4198 * top.c (show_gdb_datadir): Update.
4199 * xml-syscall.c (xml_init_syscalls_info): Update.
4200 (init_syscalls_info): Update.
4201
4202 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4203
4204 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4205 out of get_init_files.
4206 (get_init_files): Update.
4207
4208 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4209
4210 * main.c (get_init_files): Change to use std::string.
4211 (captured_main_1): Update.
4212 (print_gdb_help): Update.
4213
4214 2019-09-11 Ali Tamur <tamur@google.com>
4215
4216 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4217 implementation.
4218
4219 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4220
4221 * dbxread.c (read_dbx_symtab): Update.
4222 * dwarf2read.c (load_partial_dies): Update.
4223 * mdebugread.c (parse_partial_symbols): Update.
4224 (handle_psymbol_enumerators): Update.
4225 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4226 * psymtab.c (add_psymbol_to_bcache): Likewise.
4227 (add_psymbol_to_list): Likewise.
4228 * symtab.c (symbol_set_names): Likewise.
4229 * symtab.h (symbol_set_names): Likewise.
4230 * xcoffread.c (scan_xcoff_symtab): Update.
4231
4232 2019-09-11 Tom Tromey <tom@tromey.com>
4233
4234 * symfile-mem.c (symbol_file_add_from_memory): Use
4235 bfd_set_filename.
4236 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4237 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4238
4239 2019-09-10 Tom Tromey <tromey@adacore.com>
4240
4241 * dwarf-index-write.c (write_psymbols): Extend error message.
4242 (debug_names::insert): Add Ada code.
4243 (debug_names::write_psymbols): Remove Ada check.
4244 (debug_names) <m_string_obstack>: New member.
4245 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4246 (gdb_index_symbol_name_matcher::matches): Remove.
4247 (mapped_index_base::find_name_components_bounds): Add "lang"
4248 parameter.
4249 (mapped_index_base::build_name_components): Also split names
4250 according to Ada syntax.
4251 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4252 type of "match_callback".
4253 (check_match, check_find_bounds_finds)
4254 (dw2_expand_symtabs_matching): Update.
4255 (dw2_debug_names_iterator): Add new constructor.
4256 (dw2_debug_names_map_matching_symbols): New function.
4257 (dw2_debug_names_expand_symtabs_matching): Update.
4258 (dwarf2_debug_names_functions): Use
4259 dw2_debug_names_map_matching_symbols.
4260
4261 2019-09-10 Tom Tromey <tromey@adacore.com>
4262
4263 * dwarf2read.c (dw2_get_file_names_reader): Add the
4264 CU's file name to the results.
4265
4266 2019-09-10 Tom Tromey <tromey@adacore.com>
4267
4268 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4269 map_matching_symbols. Update.
4270 * dwarf2read.c (dw2_map_matching_symbols): Update.
4271 * psymtab.c (match_partial_symbol): Change type; update.
4272 (psym_map_matching_symbols): Likewise.
4273 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4274 type; update.
4275 * symfile.h (struct quick_symbol_functions)
4276 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4277 Remove "match".
4278
4279 2019-09-10 Tom Tromey <tromey@adacore.com>
4280
4281 * psymtab.c (map_block): Remove.
4282 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4283 * symtab.c (iterate_over_symbols_terminated): New function.
4284 * symtab.c (iterate_over_symbols_terminated): Declare.
4285
4286 2019-09-10 Tom Tromey <tromey@adacore.com>
4287
4288 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4289 * language.h (struct language_defn) <la_iterate_over_symbols>:
4290 Return bool.
4291 * symtab.c (iterate_over_symbols): Return bool.
4292 * symtab.h (iterate_over_symbols): Return bool.
4293
4294 2019-09-10 Tom Tromey <tromey@adacore.com>
4295
4296 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4297 (add_nonlocal_symbols): Update.
4298 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4299 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4300 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4301 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4302 Change type of "callback". Remove "data".
4303
4304
4305 2019-09-09 Ali Tamur <tamur@google.com>
4306
4307 * dwarf2read.c (comp_unit_head): Update comment.
4308 (dwarf2_dwo_name): New function declaration.
4309 (dwarf_unit_type_name): New function declaration.
4310 (read_comp_unit_head): Add support for new compilation units,
4311 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4312 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4313 (currently named as "signature") in their header. Also clarify error
4314 messages.
4315 (lookup_dwo_id): New function. Returns the dwo id of the given
4316 compile unit.
4317 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4318 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4319 functions.
4320 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4321 (dwarf2_dwo_name): Get the dwo name if present.
4322 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4323 purposes.
4324
4325 2019-09-09 Tom Tromey <tom@tromey.com>
4326
4327 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4328
4329 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4330
4331 * python/python.c (do_start_initialization): Make progname_copy static,
4332 to avoid a leak report.
4333
4334 2019-09-08 Tom Tromey <tom@tromey.com>
4335
4336 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4337
4338 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
4339
4340 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4341 Change type to gdb::optional<block_enum>.
4342 (dw2_symtab_iter_init): Change block_index parameter type
4343 to gdb::optional<block_enum>.
4344 (dw2_lookup_symbol): Change block_index parameter
4345 type to block_enum.c
4346 (dw2_debug_names_lookup_symbol): Likewise.
4347 * psymtab.c (psym_lookup_symbol): Likewise.
4348 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4349 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4350 Likewise.
4351
4352 2019-09-06 Christian Biesinger <cbiesinger@google.com>
4353
4354 * defs.h (relocate_gdb_directory): Change int to bool in
4355 signature and rename flag to relocatable.
4356 * main.c (relocate_path): Likewise.
4357 (relocate_gdb_directory): Likewise.
4358
4359 2019-09-06 Alan Modra <amodra@gmail.com>
4360
4361 * coffread.c (coff_symfile_read): Constify filename variable.
4362 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4363 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4364 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4365 * solib.c (reload_shared_libraries_1): Likewise.
4366 * symfile.c (reread_symbols): Likewise.
4367 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4368 * solib-darwin.c (darwin_bfd_open): Likewise.
4369 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4370
4371 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4372
4373 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4374 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4375
4376 2019-09-03 Tom Tromey <tromey@adacore.com>
4377
4378 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4379 types.
4380 (has_negatives): Unbias a range type bound.
4381 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4382 * gdbtypes.c (operator==): Handle new field.
4383 (create_range_type): Add "bias" parameter.
4384 (create_static_range_type, resolve_dynamic_range): Update.
4385 * gdbtypes.h (struct range_bounds) <bias>: New member.
4386 (create_range_type): Add bias parameter.
4387 * printcmd.c (print_scalar_formatted): Unbias range types.
4388 * value.c (unpack_long): Unbias range types.
4389 (pack_long): Bias range types.
4390
4391 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4392
4393 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4394 probe arguments.
4395
4396 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4397
4398 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4399 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4400 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4401 (compile_probe_arg): Likewise.
4402 * probe.h (get_argument_count): Likewise.
4403 * solib-svr4.c (solib_event_probe_action): Likewise.
4404 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4405
4406 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4407
4408 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4409 code to here...
4410 (svr4_create_solib_event_breakpoints): ...from here.
4411
4412 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4413
4414 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4415 suffix from warning message.
4416
4417 2019-08-30 Tom Tromey <tom@tromey.com>
4418
4419 * tui/tui-winsource.h (struct tui_source_window_base)
4420 <refresh_all>: Don't declare.
4421 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4422 Remove.
4423 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4424 tui_show_locator_content.
4425 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4426 declare.
4427 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4428 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4429 declare.
4430
4431 2019-08-30 Tom Tromey <tom@tromey.com>
4432
4433 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4434
4435 2019-08-30 Tom Tromey <tom@tromey.com>
4436
4437 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4438 Remove unnecessary forward declarations.
4439
4440 2019-08-30 Tom Tromey <tom@tromey.com>
4441
4442 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4443 rerender.
4444 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4445 tui_show_locator_content.
4446
4447 2019-08-30 Tom Tromey <tom@tromey.com>
4448
4449 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4450 (tui_locator_window::rerender): Rewrite using body of previous
4451 tui_show_locator_content.
4452
4453 2019-08-30 Tom Tromey <tom@tromey.com>
4454
4455 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4456 set_locator_fullname>: New methods.
4457 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4458 Rename from tui_set_locator_fullname.
4459 (tui_locator_window::set_locator_info): Rename from
4460 tui_set_locator_info. Return bool.
4461 (tui_update_locator_fullname, tui_show_frame_info): Update.
4462
4463 2019-08-30 Tom Tromey <tom@tromey.com>
4464
4465 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4466
4467 2019-08-30 Tom Tromey <tom@tromey.com>
4468
4469 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4470 call touchwin.
4471
4472 2019-08-30 Tom Tromey <tom@tromey.com>
4473
4474 * tui/tui-wingeneral.c (box_win): Assume win_info and
4475 win_info->handle cannot be NULL.
4476
4477 2019-08-30 Tom Tromey <tom@tromey.com>
4478
4479 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4480 refresh_window>: Declare.
4481 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4482 resize.
4483 (tui_data_item_window::rerender): Rename from
4484 tui_display_register.
4485 (tui_data_item_window::refresh_window): New method.
4486 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4487 no-op.
4488
4489 2019-08-30 Tom Tromey <tom@tromey.com>
4490
4491 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4492 regs_column_count, current_group>: Move later. Now private.
4493 <get_current_group>: New method.
4494 * tui/tui-regs.c (tui_reg_command): Update.
4495 * tui/tui-layout.c (tui_set_layout): Update.
4496
4497 2019-08-30 Tom Tromey <tom@tromey.com>
4498
4499 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4500 (tui_data_window::rerender): Don't call
4501 check_and_display_highlight_if_needed.
4502 (tui_data_window::refresh_all): Remove call to
4503 erase_data_content.
4504
4505 2019-08-30 Tom Tromey <tom@tromey.com>
4506
4507 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4508 (tui_data_window::display_registers_from)
4509 (tui_data_window::display_reg_element_at_line)
4510 (tui_data_window::display_registers_from_line): Remove checks of
4511 "empty".
4512
4513 2019-08-30 Tom Tromey <tom@tromey.com>
4514
4515 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4516 Don't declare.
4517 * tui/tui-regs.c (tui_data_window::show_registers): Call
4518 rerender.
4519 (tui_data_window::rerender): Rename from display_all_data.
4520 (tui_data_window::rerender): Remove old implementation.
4521
4522 2019-08-30 Tom Tromey <tom@tromey.com>
4523
4524 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4525 text.
4526 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4527
4528 2019-08-29 Bernhard Wodok <barto@gmx.net>
4529 Sergio Durigan Junior <sergiodj@redhat.com>
4530
4531 PR win32/24284
4532 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4533
4534 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4535
4536 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4537 when searching for types.
4538
4539 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4540
4541 * f-lang.c (f_language_defn): Use f_print_typedef.
4542 * f-lang.h (f_print_typedef): Declare.
4543 * f-typeprint.c (f_print_typedef): Define.
4544
4545 2019-08-27 Christian Biesinger <cbiesinger@google.com>
4546
4547 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4548
4549 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4550
4551 * cli/cli-utils.c (info_print_options_defs): Delete.
4552 (make_info_print_options_def_group): Delete.
4553 (extract_info_print_options): Delete.
4554 (info_print_command_completer): Delete.
4555 (info_print_args_help): Add extra parameter, and optionally
4556 include text about -n flag.
4557 * cli/cli-utils.h (struct info_print_options): Delete.
4558 (extract_info_print_options): Delete declaration.
4559 (info_print_command_completer): Delete declaration.
4560 (info_print_args_help): Add extra parameter, extend header
4561 comment.
4562 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4563 search_symbols.
4564 * stack.c (struct info_print_options): New type.
4565 (info_print_options_defs): New file scoped variable.
4566 (make_info_print_options_def_group): New static function.
4567 (info_print_command_completer): New static function.
4568 (info_locals_command): Update to use new local functions.
4569 (info_args_command): Likewise.
4570 (_initialize_stack): Add extra parameter to calls to
4571 info_print_args_help.
4572 * symtab.c (search_symbols): Add extra parameter, use this to
4573 possibly excluse non-debug symbols.
4574 (symtab_symbol_info): Add extra parameter, which is passed on to
4575 search_symbols.
4576 (struct info_print_options): New type.
4577 (info_print_options_defs): New file scoped variable.
4578 (make_info_print_options_def_group): New static function.
4579 (info_print_command_completer): New static function.
4580 (info_variables_command): Update to use local functions, and pass
4581 extra parameter through to symtab_symbol_info.
4582 (info_functions_command): Likewise.
4583 (info_types_command): Pass additional argument through to
4584 symtab_symbol_info.
4585 (rbreak_command): Pass extra argument to search_symbols.
4586 (_initialize_symtab): Add extra arguments for calls to
4587 info_print_args_help, and update help text for 'info variables',
4588 'whereis', and 'info functions' commands.
4589 * symtab.h (search_symbols): Add extra argument to declaration.
4590 * NEWS: Mention new flags.
4591
4592 2019-08-26 Christian Biesinger <cbiesinger@google.com>
4593
4594 * symtab.c (lookup_static_symbol): Call the new function (and move
4595 it down to be next to lookup_global_symbol).
4596 (struct global_sym_lookup_data): Add block_enum member and rename to...
4597 (struct global_or_static_sym_lookup_data): ...this.
4598 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4599 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4600 (lookup_symbol_global_or_static_iterator_cb): ...this.
4601 (lookup_global_or_static_symbol): New function.
4602 (lookup_global_symbol): Call new function.
4603
4604 2019-08-26 Tom de Vries <tdevries@suse.de>
4605
4606 PR c++/24852
4607 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4608 when pc_probe.prob == NULL.
4609
4610 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4611
4612 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4613 variable symbol_linkage to symbol_linkage_.
4614
4615 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4616
4617 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4618 represent whether the symbol is static, dynamic, or we don't
4619 know.
4620
4621 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4622
4623 * gdb/rx-tdep.c (rx_register_names): New.
4624 (rx_register_name): Delete.
4625 (rx_psw_type): Delete.
4626 (rx_fpsw_type): Delete.
4627 (rx_register_type): Delete.
4628 (rx_gdbarch_init): Convert target-descriptions.
4629 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4630 * gdb/features/Makefile: Add rx.xml.
4631 * gdb/features/rx.xml: New.
4632 * gdb/features/rx.c: Generated.
4633 * gdb/NEWS: Mention target description support.
4634
4635 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4636
4637 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4638 *slot_ptr.
4639
4640 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4641
4642 * configure.ac: Don't check for 'dlfcn.h' (moved to
4643 gdbsupport/common.m4).
4644 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4645 'gdbsupport/'.
4646 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4647 * compile/compile-c-support.c: Include
4648 'gdbsupport/gdb-dlfcn.h'.
4649 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4650 * gdb-dlfcn.c: Move to...
4651 * gdbsupport/gdb-dlfcn.c: ... here.
4652 * gdb-dlfcn.h: Move to...
4653 * gdbsupport/gdb-dlfcn.h: ... here.
4654
4655 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4656
4657 * nios2-tdep.c (struct reg_value): Improve comments. Make
4658 the offset field signed.
4659
4660 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4661
4662 * python/lib/gdb/__init__.py (_execute_file): New function.
4663 * python/python.c (python_run_simple_file): Call gdb._execute_file
4664 on Windows.
4665
4666 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4667
4668 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4669 all uses as this was never set to anything but a zero value.
4670
4671 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4672
4673 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4674
4675 2019-08-21 Christian Biesinger <cbiesinger@google.com>
4676
4677 * tui/tui-data.h (tui_gen_win_info): Add an =default
4678 move constructor, required by some GCC versions.
4679
4680 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
4681
4682 * go32-nat.c (go32_sysinfo): Add hygon_p.
4683
4684 2019-08-20 Tom Tromey <tom@tromey.com>
4685
4686 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4687 line_from_reg_element_no, first_reg_element_no_inline,
4688 display_all_data, delete_data_content_windows,
4689 erase_data_content>: Now private.
4690
4691 2019-08-20 Tom Tromey <tom@tromey.com>
4692
4693 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4694 (tui_unhighlight_win, tui_highlight_win)
4695 (tui_win_info::make_window): Update.
4696 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4697
4698 2019-08-20 Tom Tromey <tom@tromey.com>
4699
4700 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4701 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4702 (MAX_PID_WIDTH): Move to tui-stack.c.
4703 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4704 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4705 (MAX_PID_WIDTH): Move from tui-data.h.
4706
4707 2019-08-20 Tom Tromey <tom@tromey.com>
4708
4709 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4710 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4711 (box_win): Update.
4712 (tui_gen_win_info::make_window): Rename from tui_make_window.
4713 (tui_win_info::make_window): New method.
4714 (tui_gen_win_info::make_visible): Update.
4715 * tui/tui-source.c (tui_source_window::set_contents): Update.
4716 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4717 (tui_data_window::display_registers_from): Update.
4718 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4719 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4720 Declare.
4721 <can_box>: Remove.
4722 <title>: Remove.
4723 (struct tui_win_info) <make_window>: Declare.
4724 <can_box>: Now virtual.
4725 <title>: New member.
4726 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4727 * tui/tui-command.c (tui_cmd_window::resize): Update.
4728
4729 2019-08-20 Tom Tromey <tom@tromey.com>
4730
4731 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4732 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4733 (tui_data_window::check_register_values): Update.
4734
4735 2019-08-20 Tom Tromey <tom@tromey.com>
4736
4737 * tui/tui-regs.h (struct tui_data_window): Use
4738 DISABLE_COPY_AND_ASSIGN.
4739 <regs_content>: Change type, removing unique_ptr.
4740 <tui_data_window>: Add move constructor.
4741 * tui/tui-regs.c (tui_data_window::show_registers)
4742 (tui_data_window::show_register_group)
4743 (tui_data_window::display_registers_from)
4744 (tui_data_window::display_registers_from)
4745 (tui_data_window::first_data_item_displayed)
4746 (tui_data_window::delete_data_content_windows)
4747 (tui_data_window::rerender, tui_data_window::refresh_window)
4748 (tui_data_window::check_register_values): Update.
4749
4750 2019-08-20 Tom Tromey <tom@tromey.com>
4751
4752 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4753 show_register_group>: Declare.
4754 (tui_show_register_group): Don't declare.
4755 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4756 tui_show_registers.
4757 (tui_data_window::show_register_group): Rename from
4758 tui_show_register_group.
4759 (tui_data_window::check_register_values, tui_reg_command):
4760 Update.
4761 * tui/tui-layout.c (tui_set_layout): Update.
4762
4763 2019-08-20 Tom Tromey <tom@tromey.com>
4764
4765 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4766 Declare.
4767 (tui_check_register_values): Don't declare.
4768 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4769 from tui_check_register_values.
4770 * tui/tui-hooks.c (tui_register_changed): Update.
4771
4772 2019-08-20 Tom Tromey <tom@tromey.com>
4773
4774 * tui/tui-regs.c (tui_reg_layout): Move later.
4775 (tui_show_registers): Don't enable TUI mode or change layout.
4776
4777 2019-08-20 Tom Tromey <tom@tromey.com>
4778
4779 * tui/tui-regs.h (struct tui_data_item_window)
4780 <~tui_data_item_window>: Remove.
4781 <content>: Now a unique_xmalloc_ptr.
4782 * tui/tui-regs.c (tui_register_format): Return a
4783 unique_xmalloc_ptr.
4784 (tui_get_register): Update.
4785 (~tui_data_item_window): Remove.
4786 (tui_data_window::display_registers_from, tui_display_register):
4787 Update.
4788 * tui/tui-io.h (tui_expand_tabs): Update.
4789 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4790 Remove "col" parameter.
4791
4792 2019-08-20 Tom Tromey <tom@tromey.com>
4793
4794 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4795 field.
4796 * tui/tui-regs.c (~tui_data_item_window): Update.
4797
4798 2019-08-20 Tom Tromey <tom@tromey.com>
4799
4800 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4801 earlier.
4802
4803 2019-08-20 Tom Tromey <tom@tromey.com>
4804
4805 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4806
4807 2019-08-20 Tom Tromey <tom@tromey.com>
4808
4809 * tui/tui-source.h (struct tui_source_window): Update.
4810 * tui/tui-regs.c (tui_show_registers): Update.
4811 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4812 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4813 (NO_REGS_STRING): Remove defines.
4814
4815 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
4816
4817 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4818 unnecessary thread walk if remote doesn't support the packet.
4819
4820 2019-08-19 Tom Tromey <tromey@adacore.com>
4821
4822 * python/py-value.c (value_has_field): Fix indentation.
4823
4824 2019-08-19 Tom Tromey <tromey@adacore.com>
4825
4826 * printcmd.c (do_one_display, info_display_command): Update.
4827 * block.h (contained_in): Return bool. Add allow_nested
4828 parameter.
4829 * block.c (contained_in): Return bool. Add allow_nested
4830 parameter.
4831
4832 2019-08-19 Tom Tromey <tom@tromey.com>
4833
4834 * configure: Rebuild.
4835 * configure.ac: Disallow the combination of -static-libstdc++ and
4836 source highlight.
4837 * source-cache.c (get_language_name): Handle rust.
4838 (source_cache::get_source_lines): Ignore highlighting exceptions.
4839
4840 2019-08-16 Tom Tromey <tom@tromey.com>
4841
4842 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4843 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4844 (struct tui_source_window_base) <make_visible, refresh_window,
4845 resize>: Remove methods.
4846 <execution_info>: Remove field.
4847 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4848 (tui_show_source_line, tui_source_window_base)
4849 (~tui_source_window_base): Update.
4850 (tui_source_window_base::resize)
4851 (tui_source_window_base::make_visible)
4852 (tui_source_window_base::refresh_window): Remove.
4853 (tui_source_window_base::update_exec_info): Update.
4854 * tui/tui-source.c (tui_source_window::set_contents): Update.
4855 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4856
4857 2019-08-16 Tom Tromey <tom@tromey.com>
4858
4859 * tui/tui-hooks.c (tui_remove_hooks): Don't set
4860 deprecated_query_hook.
4861
4862 2019-08-16 Tom Tromey <tom@tromey.com>
4863
4864 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4865 (tui_update_source_windows_with_line): Update.
4866 * tui/tui-source.h (struct tui_source_window)
4867 <show_symtab_source>: Declare.
4868 (tui_show_symtab_source): Don't declare.
4869 * tui/tui-source.c (tui_show_symtab_source): Rename from
4870 tui_show_symtab_source.
4871
4872 2019-08-16 Tom Tromey <tom@tromey.com>
4873
4874 * tui/tui-winsource.h (struct tui_source_window_base)
4875 <set_contents>: Declare.
4876 * tui/tui-winsource.c
4877 (tui_source_window_base::update_source_window_as_is): Update.
4878 * tui/tui-source.h (struct tui_source_window) <set_contents>:
4879 Declare.
4880 (tui_set_source_content): Don't declare.
4881 * tui/tui-source.c (tui_source_window::set_contents): Rename from
4882 tui_set_source_content.
4883 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4884 Declare.
4885 (tui_set_disassem_content): Don't declare.
4886 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4887 tui_set_disassem_content.
4888
4889 2019-08-16 Tom Tromey <tom@tromey.com>
4890
4891 * tui/tui-winsource.h (struct tui_source_window_base)
4892 <update_breakpoint_info>: Declare.
4893 (tui_update_breakpoint_info): Don't declare.
4894 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4895 (tui_update_all_breakpoint_info): Update.
4896 (tui_source_window_base::update_breakpoint_info): Rename from
4897 tui_update_breakpoint_info.
4898 (tui_source_window_base::update_exec_info): Update.
4899
4900 2019-08-16 Tom Tromey <tom@tromey.com>
4901
4902 * tui/tui-winsource.h (struct tui_source_window_base)
4903 <update_source_window>: Declare.
4904 (tui_update_source_window): Don't declare.
4905 * tui/tui-winsource.c
4906 (tui_source_window_base::update_source_window): Rename from
4907 tui_update_source_window.
4908 (tui_source_window_base::rerender): Update.
4909 * tui/tui-source.c (tui_source_window::maybe_update): Update.
4910 * tui/tui-disasm.c (tui_show_disassem)
4911 (tui_show_disassem_and_update_source)
4912 (tui_disasm_window::maybe_update): Update.
4913
4914 2019-08-16 Tom Tromey <tom@tromey.com>
4915
4916 * tui/tui-winsource.h (struct tui_source_window_base)
4917 <update_source_window_as_is>: Declare.
4918 (tui_update_source_window_as_is): Don't declare.
4919 * tui/tui-winsource.c (tui_update_source_window): Update
4920 (tui_source_window_base::update_source_window_as_is): Rename from
4921 tui_update_source_window_as_is.
4922 (tui_source_window_base::refill): Update.
4923 * tui/tui-source.c (tui_show_symtab_source): Update.
4924 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4925 Update.
4926
4927 2019-08-16 Tom Tromey <tom@tromey.com>
4928
4929 * tui/tui-winsource.h (tui_update_source_window)
4930 (tui_update_source_window_as_is): Remove "noerror" parameter.
4931 * tui/tui-winsource.c (tui_update_source_window)
4932 (tui_update_source_window_as_is): Remove "noerror" parameter.
4933 (tui_update_source_windows_with_addr)
4934 (tui_update_source_windows_with_line)
4935 (tui_source_window_base::rerender)
4936 (tui_source_window_base::refill): Update.
4937 * tui/tui-source.h (tui_set_source_content)
4938 (tui_show_symtab_source): Remove "noerror" parameter.
4939 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4940 parameter.
4941 (tui_show_symtab_source): Likewise.
4942 (tui_source_window::maybe_update): Update.
4943 * tui/tui-disasm.c (tui_show_disassem)
4944 (tui_show_disassem_and_update_source)
4945 (tui_disasm_window::do_scroll_vertical)
4946 (tui_disasm_window::maybe_update): Update.
4947
4948 2019-08-16 Tom Tromey <tom@tromey.com>
4949
4950 * tui/tui.c (tui_is_window_visible): Update.
4951 * tui/tui-wingeneral.c (tui_make_window)
4952 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4953 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4954 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4955 (tui_set_win_height_command, parse_scrolling_args): Update.
4956 * tui/tui-source.c (tui_source_window::style_changed): Update.
4957 * tui/tui-regs.c (tui_show_registers)
4958 (tui_data_window::first_data_item_displayed)
4959 (tui_data_window::delete_data_content_windows)
4960 (tui_check_register_values, tui_reg_command): Update.
4961 * tui/tui-disasm.c (tui_show_disassem): Update.
4962 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4963 method.
4964 <is_visible>: Remove field.
4965 * tui/tui-data.c (tui_next_win, tui_prev_win)
4966 (tui_delete_invisible_windows): Update.
4967
4968 2019-08-16 Tom Tromey <tom@tromey.com>
4969
4970 * tui/tui-winsource.h (struct tui_source_window_base)
4971 <m_has_locator>: Remove.
4972 * tui/tui-layout.c (show_source_disasm_command, show_data)
4973 (show_source_or_disasm_and_command): Update.
4974
4975 2019-08-16 Alan Hayward <alan.hayward@arm.com>
4976
4977 * NEWS (Other MI changes): New subsection.
4978 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4979 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4980 * arch-utils.c (default_get_pc_address_flags): New function.
4981 * arch-utils.h (default_get_pc_address_flags): New declaration.
4982 * gdbarch.sh: Add get_pc_address_flags.
4983 * gdbarch.c: Regenerate.
4984 * gdbarch.h: Likewise.
4985 * stack.c (print_pc): New function.
4986 (print_frame_info) (print_frame): Call print_pc.
4987
4988 2019-08-16 Tom de Vries <tdevries@suse.de>
4989
4990 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4991 print_objfile_section_info.
4992
4993 2019-08-15 Tom Tromey <tom@tromey.com>
4994
4995 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4996 calling update_cmdwin_start_line.
4997 * tui/tui-winsource.h (struct tui_source_window_base)
4998 <do_make_visible_with_new_height, set_new_height>: Don't declare.
4999 <rerender>: Declare.
5000 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5001 Call rerender.
5002 (tui_source_window_base::set_new_height): Remove.
5003 (tui_source_window_base::rerender): Rename from
5004 do_make_visible_with_new_height.
5005 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5006 resize method.
5007 (tui_win_info::make_invisible_and_set_new_height)
5008 (tui_win_info::make_visible_with_new_height): Remove.
5009 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5010 Declare.
5011 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5012 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5013 do_make_visible_with_new_height>: Don't declare.
5014 <rerender>: Declare.
5015 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5016 set_new_height.
5017 (tui_data_window::do_make_visible_with_new_height): Remove.
5018 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5019 call tui_show_locator_content.
5020 (tui_gen_win_info::resize): Call rerender.
5021 (show_source_or_disasm_and_command): Don't call
5022 tui_show_locator_content.
5023 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5024 method.
5025 (struct tui_win_info) <rerender>: Declare.
5026 <set_new_height, make_invisible_and_set_new_height,
5027 make_visible_with_new_height>: Don't declare.
5028 * tui/tui-data.c (tui_win_list::rerender): New method.
5029 * tui/tui-command.h (struct tui_cmd_window)
5030 <do_make_visible_with_new_height>: Don't declare.
5031 * tui/tui-command.c
5032 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5033
5034 2019-08-15 Tom Tromey <tromey@adacore.com>
5035
5036 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5037 * ada-lang.c (ada_enum_name): Likewise.
5038
5039 2019-08-15 Christian Biesinger <cbiesinger@google.com>
5040
5041 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5042 leading underscore.
5043 (GdbOutputErrorFile): Likewise.
5044 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5045 accordingly.
5046 (execute_unwinders): Rename to have a leading underscore.
5047 (auto_load_packages): Likewise.
5048 (global scope): Adjust call to auto_load_packages accordingly.
5049 (GdbSetPythonDirectory): Likewise.
5050 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5051 instead of execute_unwinders.
5052
5053 2019-08-15 Tom Tromey <tom@tromey.com>
5054
5055 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5056 (show_data): Don't change window visibility.
5057 (tui_gen_win_info::resize): Remove special case for command
5058 window. Use wresize, when available.
5059 (show_source_or_disasm_and_command): Don't change window
5060 visibility.
5061 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5062 <make_visible>: New method.
5063 * tui/tui-command.c (tui_cmd_window::resize): New method.
5064
5065 2019-08-15 Tom Tromey <tom@tromey.com>
5066
5067 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5068 (struct tui_source_windows): New.
5069 * tui/tui-winsource.c (tui_display_main): Update.
5070 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5071 (new_height_ok, parse_scrolling_args): Update.
5072 * tui/tui-layout.c (show_layout, show_data): Update.
5073 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5074 (tui_add_to_source_windows): Don't declare.
5075 * tui/tui-data.c (source_windows, tui_source_windows)
5076 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5077
5078 2019-08-15 Tom Tromey <tom@tromey.com>
5079
5080 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5081 Rename from reset.
5082 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5083 * tui/tui-layout.c (show_source_disasm_command, show_data):
5084 Update.
5085 (tui_gen_win_info::resize): Rename.
5086 (show_source_or_disasm_and_command): Update.
5087 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5088 reset.
5089
5090 2019-08-15 Tom Tromey <tom@tromey.com>
5091
5092 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5093 * tui/tui-interp.c (tui_interp::init): Don't call
5094 tui_initialize_static_data.
5095 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5096
5097 2019-08-15 Tom Tromey <tom@tromey.com>
5098
5099 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5100 examine tui_win_list.
5101
5102 2019-08-15 Tom Tromey <tom@tromey.com>
5103
5104 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5105 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5106 tui_clear_source_content.
5107 (tui_clear_source_content): Remove.
5108 (tui_source_window_base::do_erase_source_content): Hoist call to
5109 content.clear().
5110 * tui/tui-stack.c (tui_show_frame_info): Don't call
5111 tui_clear_source_content.
5112
5113 2019-08-15 Tom Tromey <tom@tromey.com>
5114
5115 * tui/tui-winsource.h (struct tui_source_window_base)
5116 <do_erase_source_content>: New method.
5117 <erase_source_content>: New method.
5118 (tui_erase_source_content): Don't declare.
5119 * tui/tui-winsource.c (tui_clear_source_content): Update.
5120 (tui_source_window_base::do_erase_source_content): Rename from
5121 tui_erase_source_content.
5122 (tui_source_window_base::show_source_content): Update.
5123 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5124 * tui/tui-source.h (struct tui_source_window)
5125 <erase_source_content>: New method.
5126 * tui/tui-disasm.h (struct tui_disasm_window)
5127 <erase_source_content>: New method.
5128
5129 2019-08-15 Tom Tromey <tom@tromey.com>
5130
5131 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5132 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5133 constructor.
5134 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5135 * tui/tui-source.c (tui_set_source_content): Update.
5136 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5137
5138 2019-08-15 Tom Tromey <tom@tromey.com>
5139
5140 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5141 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5142 tui-source.c.
5143 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5144 Declare.
5145 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5146 method.
5147 (tui_source_window::maybe_update): Update.
5148
5149 2019-08-15 Tom Tromey <tom@tromey.com>
5150
5151 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5152 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5153 tui-disasm.c.
5154 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5155 Declare.
5156 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5157 method.
5158 (tui_disasm_window::maybe_update): Update.
5159
5160 2019-08-15 Tom Tromey <tom@tromey.com>
5161
5162 * tui/tui-winsource.h (struct tui_source_window_base)
5163 <maybe_update>: Declare.
5164 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5165 method.
5166 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5167 Declare.
5168 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5169 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5170 Declare.
5171 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5172
5173 2019-08-15 Tom Tromey <tom@tromey.com>
5174
5175 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5176
5177 2019-08-15 Tom Tromey <tom@tromey.com>
5178
5179 * tui/tui-wingeneral.c: Include tui-stack.h.
5180 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5181 (struct tui_locator_window): Move from tui-data.h.
5182 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5183 (tui_initialize_static_data): Move from tui-data.c.
5184 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5185 (struct tui_locator_window): Move to tui-stack.c.
5186 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5187 (tui_initialize_static_data): Move to tui-stack.c.
5188
5189 2019-08-15 Tom Tromey <tom@tromey.com>
5190
5191 * tui/tui-layout.c (show_source_disasm_command)
5192 (show_source_or_disasm_and_command): Use make_visible method, not
5193 tui_make_window.
5194 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5195 Remove.
5196
5197 2019-08-15 Tom Tromey <tom@tromey.com>
5198
5199 * tui/tui-wingeneral.h (tui_make_window): Update.
5200 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5201 parameter.
5202 (tui_gen_win_info::make_visible): Update.
5203 * tui/tui-regs.c (tui_data_window::display_registers_from):
5204 Update.
5205 * tui/tui-layout.c (show_source_disasm_command)
5206 (show_source_or_disasm_and_command): Update.
5207 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5208 (enum tui_box): Remove.
5209 (struct tui_win_info) <can_box>: New method.
5210 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5211 method.
5212
5213 2019-08-15 Tom de Vries <tdevries@suse.de>
5214
5215 * linux-nat-trad.c: Include gdbarch.h.
5216
5217 2019-08-14 Alan Hayward <alan.hayward@arm.com>
5218
5219 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5220 register sizes.
5221
5222 2019-08-14 Tom Tromey <tromey@adacore.com>
5223
5224 * darwin-nat.c: Include gdbarch.h.
5225 * darwin-nat-info.c: Include gdbarch.h.
5226
5227 2019-08-13 Tom Tromey <tom@tromey.com>
5228
5229 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5230 Remove.
5231 * tui/tui-data.c (tui_initialize_static_data): Update.
5232
5233 2019-08-13 Tom Tromey <tom@tromey.com>
5234
5235 * tui/tui-winsource.h (struct tui_exec_info_window)
5236 <~tui_exec_info_window, maybe_allocate_content, get_content,
5237 m_content>: Remove.
5238 (struct tui_source_window_base) <set_exec_info_content,
5239 show_exec_info_content>: Don't declare.
5240 * tui/tui-winsource.c
5241 (tui_exec_info_window::maybe_allocate_content): Remove.
5242 (tui_source_window_base::update_exec_info): Rename from
5243 set_exec_info_content.
5244 (tui_source_window_base::show_exec_info_content)
5245 (tui_source_window_base::update_exec_info): Remove.
5246
5247 2019-08-13 Tom Tromey <tom@tromey.com>
5248
5249 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5250 declare.
5251 * tui/tui-winsource.c (tui_update_source_window_as_is)
5252 (tui_update_source_windows_with_addr, tui_erase_source_content):
5253 Update.
5254 (tui_clear_exec_info_content): Remove.
5255
5256 2019-08-13 Tom Tromey <tom@tromey.com>
5257
5258 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5259 declare.
5260 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5261 call tui_erase_exec_info_content.
5262 (tui_clear_exec_info_content): Rename from
5263 tui_erase_exec_info_content.
5264 (tui_clear_exec_info_content): Delete.
5265
5266 2019-08-13 Tom Tromey <tom@tromey.com>
5267
5268 * tui/tui-winsource.h (struct tui_source_window_base)
5269 <show_exec_info_content>: Declare.
5270 (tui_show_exec_info_content): Don't declare.
5271 * tui/tui-winsource.c
5272 (tui_source_window_base::show_exec_info_content): Rename from
5273 tui_show_exec_info_content.
5274 (tui_source_window_base::update_exec_info): Update.
5275
5276 2019-08-13 Tom Tromey <tom@tromey.com>
5277
5278 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5279 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5280 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5281 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5282 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5283 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5284 ... here.
5285
5286 2019-08-13 Tom Tromey <tom@tromey.com>
5287
5288 * tui/tui-winsource.h (struct tui_source_window_base)
5289 <update_exec_info>: Declare.
5290 (tui_update_exec_info): Don't declare.
5291 * tui/tui-winsource.c (tui_update_source_window_as_is)
5292 (tui_source_window_base::refresh_all)
5293 (tui_update_all_breakpoint_info): Update.
5294 (tui_source_window_base::update_exec_info): Rename from
5295 tui_update_exec_info.
5296 * tui/tui-stack.c (tui_show_frame_info): Update.
5297
5298 2019-08-13 Tom Tromey <tom@tromey.com>
5299
5300 * tui/tui-winsource.h (struct tui_source_window_base)
5301 <set_exec_info_content>: Declare.
5302 (tui_set_exec_info_content): Don't declare.
5303 * tui/tui-winsource.c
5304 (tui_source_window_base::set_exec_info_content): Rename from
5305 tui_set_exec_info_content.
5306 (tui_update_exec_info): Update.
5307
5308 2019-08-13 Tom Tromey <tom@tromey.com>
5309
5310 * tui/tui-winsource.h (struct tui_source_window_base)
5311 <show_source_content>: Declare.
5312 (tui_show_source_content): Don't declare.
5313 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5314 (tui_source_window_base::show_source_content): Rename from
5315 tui_show_source_content.
5316 (tui_source_window_base::refresh_all): Update.
5317 * tui/tui-layout.c (show_source_disasm_command)
5318 (show_source_or_disasm_and_command): Update.
5319
5320 2019-08-13 Tom Tromey <tom@tromey.com>
5321
5322 * tui/tui-winsource.c (tui_erase_source_content)
5323 (tui_show_source_content, tui_source_window_base::refresh_all):
5324 Update.
5325 * tui/tui-wingeneral.h
5326 (tui_check_and_display_highlight_if_needed): Don't declare.
5327 * tui/tui-wingeneral.c
5328 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5329 check_and_display_highlight_if_needed.
5330 * tui/tui-win.c (tui_rehighlight_all)
5331 (tui_win_info::make_visible_with_new_height): Update.
5332 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5333 (tui_data_window::erase_data_content)
5334 (tui_data_window::display_all_data): Update.
5335 * tui/tui-data.h (struct tui_win_info)
5336 <check_and_display_highlight_if_needed>: Declare.
5337
5338 2019-08-13 Tom Tromey <tom@tromey.com>
5339
5340 * tui/tui-win.c (tui_resize_all): Call
5341 tui_delete_invisible_windows.
5342 * tui/tui-layout.c (show_layout): Call
5343 tui_delete_invisible_windows.
5344 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5345 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5346
5347 2019-08-13 Tom Tromey <tom@tromey.com>
5348
5349 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5350 tui_add_win_to_layout.
5351
5352 2019-08-13 Tom Tromey <tom@tromey.com>
5353
5354 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5355 * tui/tui-layout.c (tui_default_win_height): Now static.
5356
5357 2019-08-13 Tom Tromey <tom@tromey.com>
5358
5359 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5360 single switch.
5361 (show_source_disasm_command, show_source_or_disasm_and_command):
5362 Don't check current layout.
5363
5364 2019-08-13 Tom Tromey <tom@tromey.com>
5365
5366 * tui/tui-wingeneral.c (make_all_visible): Remove.
5367 (tui_make_all_invisible): Simplify.
5368 * tui/tui-layout.c (tui_make_all_invisible): Move from
5369 tui-wingeneral.c; simplify.
5370 (show_layout): Hoist call to tui_make_all_invisible.
5371 (show_data): Don't call tui_make_all_invisible.
5372
5373 2019-08-13 Tom Tromey <tom@tromey.com>
5374
5375 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5376 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5377
5378 2019-08-13 Tom Tromey <tom@tromey.com>
5379
5380 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5381 tui-data.c.
5382 (show_source_disasm_command, show_data)
5383 (show_source_or_disasm_and_command): Don't use
5384 tui_set_current_layout_to.
5385 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5386 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5387 tui-layout.c.
5388 (tui_set_current_layout_to): Remove.
5389
5390 2019-08-13 Tom Tromey <tom@tromey.com>
5391
5392 * tui/tui-layout.c (tui_set_layout): Update.
5393 * tui/tui-data.h (struct tui_layout_def): Remove.
5394 (tui_layout_def): Don't declare.
5395 * tui/tui-data.c (layout_def): Remove.
5396 (tui_layout_def): Remove.
5397
5398 2019-08-13 Tom Tromey <tom@tromey.com>
5399
5400 * tui/tui-winsource.h (struct tui_source_window_base)
5401 <clear_detail>: No longer "override".
5402 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5403 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5404 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5405 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5406 Remove.
5407 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5408
5409 2019-08-13 Tom Tromey <tromey@adacore.com>
5410
5411 * tracepoint.c: Don't include readline.h or history.h.
5412
5413 2019-08-12 Tom Tromey <tom@tromey.com>
5414
5415 * configure: Rebuild.
5416 * configure.ac: Check for readline 7.
5417 * NEWS: Mention readline 7 requirement.
5418 * README: Update.
5419
5420 2019-08-12 Tom Tromey <tom@tromey.com>
5421
5422 * mingw-hdep.c (gdb_select): Remove readline hack.
5423
5424 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5425
5426 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5427 when the function fails.
5428
5429 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5430
5431 * s390-tdep.c (s390_type_align): New function.
5432 (s390_gdbarch_init): Set it as type_align gdbarch method.
5433
5434 2019-08-09 Tom de Vries <tdevries@suse.de>
5435
5436 PR gdb/24591
5437 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5438 pc_low with relocation offset.
5439
5440 2019-08-07 Tom Tromey <tromey@adacore.com>
5441
5442 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5443 (print_frame_args): Update.
5444 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5445 Update.
5446 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5447 * frame.h (struct frame_arg): Add initializers.
5448 <error>: Now a unique_xmalloc_ptr.
5449
5450 2019-08-07 Alan Hayward <alan.hayward@arm.com>
5451
5452 * NEWS: Expand the Pointer Authentication entry.
5453 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5454 (aarch64_frame_unmask_lr): ... to this.
5455 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5456 Call aarch64_frame_unmask_lr.
5457 * frame.c (struct frame_info): Add "masked" variable.
5458 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5459 (fprint_frame): Check for masked pc.
5460 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5461 declarations.
5462 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5463 * stack.c (print_frame): Check for masked pc.
5464
5465 2019-08-06 Tom Tromey <tom@tromey.com>
5466
5467 * stabsread.c (patch_block_stabs, read_one_struct_field)
5468 (read_enum_type): Use obstack_strndup.
5469 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5470 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5471 * dwarf2read.c (guess_full_die_structure_name)
5472 (anonymous_struct_prefix): Use obstack_strndup.
5473 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5474 * c-exp.y (yylex): Use obstack_strndup.
5475 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5476 (write_var_or_type): Use obstack_strndup.
5477
5478 2019-08-06 Tom Tromey <tom@tromey.com>
5479
5480 * symfile.c (reread_symbols): Use obstack_strdup.
5481 * stabsread.c (read_type): Use obstack_strdup.
5482 * gdb_obstack.h (obstack_strdup): New overload.
5483 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5484 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5485 (dwarf2_canonicalize_name): Use obstack_strdup.
5486 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5487 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5488 Use obstack_strdup.
5489
5490 2019-08-06 Tom Tromey <tom@tromey.com>
5491
5492 * gdb_obstack.h (obstack_strdup): Define.
5493 * gdb_obstack.c (obstack_strdup): Don't define.
5494
5495 2019-08-06 Tom Tromey <tom@tromey.com>
5496
5497 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5498 obstack_strdup.
5499 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5500 obstack_strdup.
5501 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5502 * stabsread.c (common_block_start): Use obstack_strdup.
5503 * objfiles.c (set_objfile_main_name, objfile): Use
5504 obstack_strdup.
5505 * namespace.c (add_using_directive): Use obstack_strdup.
5506 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5507 * jit.c (finalize_symtab): Use obstack_strdup.
5508 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5509 (guess_partial_die_structure_name, partial_die_info::fixup)
5510 (dwarf2_name): Use obstack_strdup.
5511 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5512 obstack_strdup.
5513 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5514 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5515 obstack_strdup.
5516 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5517
5518 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5519
5520 * unittests/help-doc-selftests.c: New file.
5521 * Makefile.in: Add the new file.
5522
5523 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5524
5525 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5526 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5527 the full first line, except when FOR_VALUE_PREFIX. In this case,
5528 the trailing '.' is not output, and the first character is uppercased.
5529 (print_help_for_command): Update call to print_doc_line.
5530 (print_doc_of_command): Likewise.
5531 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5532 * cli/cli-option.c (append_indented_doc): Do not append newline.
5533 (build_help_option): Append newline after first appended_indented_doc
5534 only if a second call is done.
5535 (build_help): Append 2 new lines before each option, except the first
5536 one.
5537 * compile/compile.c (_initialize_compile): Add new lines after
5538 %OPTIONS%, when not at the end of the help.
5539 Change help doc or code
5540 producing the help doc to respect the invariants.
5541 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5542 Also removed the new line after 'Options:', as all other commands
5543 do not put an empty line between 'Options:' and the first option.
5544 * printcmd.c (_initialize_printcmd): Likewise.
5545 * stack.c (_initialize_stack): Likewise.
5546 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5547 incorrectly telling COMMAND is optional.
5548 * ada-lang.c (_initialize_ada_language): Change help doc or code
5549 producing the help doc to respect the invariants.
5550 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5551 * breakpoint.c (_initialize_breakpoint): Likewise.
5552 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5553 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5554 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5555 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5556 _initialize_cli_style): Likewise.
5557 * corelow.c (core_target_info): Likewise.
5558 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5559 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5560 * filesystem.c (_initialize_filesystem): Likewise.
5561 * frame.c (_initialize_frame): Likewise.
5562 * gnu-nat.c (add_task_commands): Likewise.
5563 * infcall.c (_initialize_infcall): Likewise.
5564 * infcmd.c (_initialize_infcmd): Likewise.
5565 * interps.c (_initialize_interpreter): Likewise.
5566 * language.c (_initialize_language): Likewise.
5567 * linux-fork.c (_initialize_linux_fork): Likewise.
5568 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5569 * maint.c (_initialize_maint_cmds): Likewise.
5570 * memattr.c (_initialize_mem): Likewise.
5571 * printcmd.c (_initialize_printcmd): Likewise.
5572 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5573 _RegEx): Likewise.
5574 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5575 * record-btrace.c (_initialize_record_btrace): Likewise.
5576 * record-full.c (_initialize_record_full): Likewise.
5577 * record.c (_initialize_record): Likewise.
5578 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5579 * regcache.c (_initialize_regcache): Likewise.
5580 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5581 _initialize_remote): Likewise.
5582 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5583 * serial.c (_initialize_serial): Likewise.
5584 * skip.c (_initialize_step_skip): Likewise.
5585 * source.c (_initialize_source): Likewise.
5586 * stack.c (_initialize_stack): Likewise.
5587 * symfile.c (_initialize_symfile): Likewise.
5588 * symtab.c (_initialize_symtab): Likewise.
5589 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5590 * top.c (init_main): Likewise.
5591 * tracefile-tfile.c (tfile_target_info): Likewise.
5592 * tracepoint.c (_initialize_tracepoint): Likewise.
5593 * tui/tui-win.c (_initialize_tui_win): Likewise.
5594 * utils.c (add_internal_problem_command): Likewise.
5595 * valprint.c (value_print_option_defs): Likewise.
5596
5597 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
5598
5599 PR build/24886
5600 * configure.ac: Drop enable-libmcheck support.
5601 * configure, config.in: Rebuild.
5602 * libmcheck.m4: Remove.
5603 * acinclude.m4: Don't include it.
5604 * Makefile.in: Don't distribute it.
5605 * top.c (print_gdb_configuration): Don't mention it.
5606
5607 2019-08-06 Tom Tromey <tom@tromey.com>
5608
5609 * utils.c (set_output_style): Sometimes pass stream to
5610 emit_style_escape.
5611 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5612 * record-btrace.c (btrace_insn_history): Update.
5613 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5614 method.
5615 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5616 Update initializers.
5617 <m_uiout>: New field.
5618 <m_di>: Move lower.
5619 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5620 Remove "uiout" parameter.
5621 (dump_insns): Update.
5622 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5623 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5624
5625 2019-08-06 Christian Biesinger <cbiesinger@google.com>
5626
5627 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5628 (error_in_psymtab_expansion): Likewise.
5629 (lookup_symbol_via_quick_fns): Likewise.
5630 (basic_lookup_transparent_type_quick): Likewise.
5631 (basic_lookup_transparent_type_1): Likewise.
5632
5633 2019-08-06 Tom Tromey <tromey@adacore.com>
5634
5635 * source.c (last_source_error): Now bool.
5636 (print_source_lines_base): Make "noprint" bool. Only open
5637 source file when last_source_visited changes.
5638
5639 2019-08-06 Tom Tromey <tromey@adacore.com>
5640
5641 * annotate.c (annotate_source_line): Use g_source_cache.
5642 * source-cache.c (source_cache::get_plain_source_lines): Change
5643 parameters. Populate m_offset_cache.
5644 (source_cache::ensure): New method.
5645 (source_cache::get_line_charpos): New method.
5646 (extract_lines): Move lower. Change parameters.
5647 (source_cache::get_source_lines): Move lower.
5648 * source-cache.h (class source_cache): Update comment.
5649 <get_line_charpos>: New method.
5650 <get_source_lines>: Update comment.
5651 <clear>: Clear m_offset_cache.
5652 <get_plain_source_lines>: Change parameters.
5653 <ensure>: New method
5654 <m_offset_cache>: New member.
5655 * source.c (forget_cached_source_info_for_objfile): Update.
5656 (info_source_command): Use g_source_cache.
5657 (find_source_lines, open_source_file_with_line_charpos): Remove.
5658 (print_source_lines_base, search_command_helper): Use g_source_cache.
5659 * source.h (open_source_file_with_line_charpos): Don't declare.
5660 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5661 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5662 Use g_source_cache.
5663
5664 2019-08-06 Tom Tromey <tromey@adacore.com>
5665
5666 * source-cache.c (source_cache::get_plain_source_lines):
5667 Remove "first_line" and "last_line" parameters.
5668 (source_cache::get_source_lines): Cache plain text.
5669 * source-cache.h (class source_cache)
5670 <get_plain_source_lines>: Update.
5671
5672 2019-08-06 Tom Tromey <tromey@adacore.com>
5673
5674 * source-cache.c (extract_lines): No longer a method.
5675 Changed type of parameter. Include final newline.
5676 (selftests::extract_lines_test): New function.
5677 (_initialize_source_cache): Likewise.
5678 * source-cache.h (class source_cache)
5679 <extract_lines>: Don't declare.
5680
5681 2019-08-06 Tom Tromey <tromey@adacore.com>
5682
5683 * breakpoint.c (init_breakpoint_sal): Update.
5684 (breakpoint): Update.
5685 * breakpoint.h (struct breakpoint) <filter>: Now a
5686 unique_xmalloc_ptr.
5687
5688 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5689
5690 * NEWS: Mention dictionary access on blocks.
5691 * python/py-block.c (blpy_getitem): New function.
5692 (block_object_as_mapping): New struct.
5693 (block_object_type): Use new struct for tp_as_mapping field.
5694
5695 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5696
5697 * objfiles.h (objfile): Add a comment describing partial symbols.
5698
5699 2019-08-05 Tom Tromey <tromey@adacore.com>
5700
5701 * compile/compile.c (_initialize_compile): Use _(), not N_().
5702 * thread.c (_initialize_thread): Use _(), not N_().
5703 * stack.c (_initialize_stack): Use _(), not N_().
5704 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5705
5706 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5707
5708 * dwarf2read.c (struct dw2_symtab_iterator):
5709 <want_specific_block>: Remove.
5710 <block_index>: Change type to gdb::optional.
5711 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5712 change type of BLOCK_INDEX parameter to gdb::optional.
5713 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5714 (dw2_lookup_symbol): Don't pass argument for
5715 WANT_SPECIFIC_BLOCK.
5716 (dw2_expand_symtabs_for_function): Don't pass argument for
5717 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5718 (class dw2_debug_names_iterator)
5719 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5720 parameter, change BLOCK_INDEX type to gdb::optional.
5721 <m_want_specific_block>: Remove.
5722 <m_block_index>: Change type to gdb::optional.
5723 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5724 gdb::optional. Re-write in function of gdb::optional.
5725 (dw2_debug_names_lookup_symbol): Don't pass argument for
5726 WANT_SPECIFIC_BLOCK.
5727 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5728 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5729 BLOCK_INDEX.
5730
5731 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5732
5733 * NEWS: Mention changes to "info sources" command.
5734
5735 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5736
5737 * symtab.c (filename_partial_match_opts): New struct type.
5738 (struct output_source_filename_data): New members
5739 regexp, c_regexp, partial_match.
5740 (output_source_filename): Use new members to decide to print file.
5741 (info_sources_option_defs): New variable.
5742 (make_info_sources_options_def_group, print_info_sources_header,
5743 info_sources_command_completer):
5744 New functions.
5745 (info_sources_command): Read new optional arguments.
5746 (_initialize_symtab): Update info sources help.
5747
5748 2019-08-02 Alexandre Oliva <oliva@adacore.com>
5749
5750 * ada-lang.c (exception_support_info_v0): Renamed from...
5751 (default_exception_support_info): ... this. Create new
5752 definition for v1.
5753 (ada_has_this_exception_support): Look up catch_handlers_sym.
5754 (ada_exception_support_info_sniffer): Try v0 after default.
5755
5756 2019-08-01 Tom Tromey <tromey@adacore.com>
5757
5758 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5759 gdbarch.h.
5760
5761 2019-08-01 Christian Biesinger <cbiesinger@google.com>
5762
5763 * s12z-tdep.c: Fix include path for s12z-opc.h.
5764
5765 2019-08-01 Alan Hayward <alan.hayward@arm.com>
5766
5767 * NEWS: Require GNU make 3.82.
5768
5769 2019-07-16 Tom Tromey <tom@tromey.com>
5770
5771 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5772 declare.
5773
5774 2019-07-30 Tom Tromey <tromey@adacore.com>
5775
5776 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5777
5778 2019-07-30 Kevin Buettner <kevinb@redhat.com>
5779
5780 * printcmd.c (print_address_symbolic): Print negative offsets.
5781 (build_address_symbolic): Force signed arithmetic when computing
5782 offset.
5783
5784 2019-07-30 Christian Biesinger <cbiesinger@google.com>
5785
5786 PR/24474: Add a function to lookup static variables.
5787 * NEWS: Mention this new function.
5788 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5789 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5790 * python/python.c (python_GdbMethods): Add new function.
5791
5792 2019-07-29 Christian Biesinger <cbiesinger@google.com>
5793
5794 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5795 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5796 (objfpy_lookup_static_symbol): New function.
5797 (objfile_object_methods): Add new functions.
5798
5799 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5800
5801 * NEWS: Mention 'set|show print frame-info'. Mention new
5802 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5803 backtrace argument. Mention that python frame filtering code
5804 is now consistent with what 'backtrace' command prints.
5805
5806 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5807
5808 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5809 comments.
5810 (print_frame_info_auto, print_frame_info_source_line,
5811 print_frame_info_location, print_frame_info_source_and_location,
5812 print_frame_info_location_and_address, print_frame_info_short_location):
5813 New declarations.
5814 (struct frame_print_options): New member print_frame_info.
5815 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5816 * stack.h (get_user_print_what_frame_info): New declaration.
5817 (frame_show_address): New declaration.
5818 * stack.c (print_frame_arguments_choices): New value 'presence'.
5819 (print_frame_info_auto, print_frame_info_source_line,
5820 print_frame_info_location, print_frame_info_source_and_location,
5821 print_frame_info_location_and_address, print_frame_info_short_location,
5822 print_frame_info_choices, print_frame_info_print_what): New definitions.
5823 (print_frame_args): Only print dots for args if print frame-arguments
5824 is 'presence'.
5825 (frame_print_option_defs): New element for "frame-info".
5826 (get_user_print_what_frame_info): New function.
5827 (frame_show_address): Make non static. Move comment to stack.h.
5828 (print_frame_info_to_print_what): New function.
5829 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5830 to decide what to print.
5831 (backtrace_command_1): Handle the new print_frame_arguments_presence
5832 value.
5833 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5834 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5835 (py_print_frame): In non-mi mode, use LOCATION as default for
5836 print_what, similarly to frame information printed directly by
5837 backtrace command. Handle frame-info user option in non MI mode.
5838
5839 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5840
5841 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5842 Add case for debugging 32-bit target on 64-bit host. Revise
5843 comment.
5844
5845 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5846
5847 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5848 instead of find_function_entry_range_from_pc.
5849
5850 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5851
5852 * stack.c (find_frame_funname): Remove code which preferred
5853 minsym over symtab sym in "certain pathological cases".
5854
5855 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5856 parameter. Change type of "do_demangle" to bool.
5857 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5858 Pass suitable "prefer_sym_over_minsym" flag to
5859 build_address_symbolic(). Don't output "+" for negative offsets.
5860 * printcmd.c (print_address_symbolic): Update invocation of
5861 build_address_symbolic to include a "prefer_sym_over_minsym"
5862 flag.
5863 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5864 Restrict cases in which use of minimal symbol is preferred to that
5865 of a found symbol. Update comments.
5866
5867 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5868 for entry pc when entry pc is out of range for that FDE.
5869
5870 2019-07-26 Brian Callahan <bcallah@openbsd.org>
5871
5872 PR gdb/24839:
5873 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5874 type.
5875
5876 2019-07-25 Christian Biesinger <cbiesinger@google.com>
5877
5878 * python/py-objfile.c (add_separate_debug_file): Fix comment about
5879 this function's Python signature.
5880
5881
5882 2019-07-24 Christian Biesinger <cbiesinger@google.com>
5883
5884 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5885 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5886 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5887 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5888 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5889
5890
5891 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
5892
5893 * h8300-tdep.c (h8300_register_name_common): New.
5894 h8300_register_name): Use h8300_register_name_common.
5895 (h8300s_register_name): Likewise.
5896 (h8300sx_register_name): Likewise.
5897 (h8300h_register_nam): New.
5898 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5899
5900
5901 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
5902
5903 * arm-tdep.c (arm_skip_cmse_entry): New function.
5904 (arm_is_sgstubs_section): New function.
5905 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5906
5907 2019-07-22 Tom Tromey <tom@tromey.com>
5908
5909 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5910 Don't self-assign.
5911
5912 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5913
5914 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5915 type_print.
5916
5917 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5918
5919 * symtab.c (search_symbols): Adjust msymbol matching type arrays
5920 so that GDB doesn't match any msymbols when searching in the
5921 TYPES_DOMAIN.
5922 (print_symbol_info): Print using typedef_print or type_print based
5923 on the type of the symbol. Add updated FIXME comment moved from...
5924 (_initialize_symtab): ... move and update FIXME comment to above.
5925
5926 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5927
5928 * NEWS: Mention adding -q option to "info types".
5929 * symtab.c (struct info_types_options): New struct.
5930 (info_types_options_defs): New variable.
5931 (make_info_types_options_def_group): New function.
5932 (info_types_command): Use gdb::option framework to parse options.
5933 (info_types_command_completer): New function.
5934 (_initialize_symtab): Extend the help text on "info types" and
5935 register command completer.
5936
5937 2019-07-21 Christian Biesinger <cbiesinger@google.com>
5938
5939 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5940 (lookup_symbol_in_objfile): Change int to block_enum and add a
5941 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5942
5943 2019-07-20 Christian Biesinger <cbiesinger@google.com>
5944
5945 * MAINTAINERS (Write After Approval): Add self.
5946
5947 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
5948
5949 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5950 instruction to the dummy code region.
5951
5952 2019-07-19 Tom Tromey <tromey@adacore.com>
5953
5954 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5955 (ARGSUSED, PARAMS, __func__): Remove rules.
5956
5957 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5958
5959 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5960 * features/arm/arm-with-iwmmxt.c: Remove.
5961 * features/arm/arm-with-iwmmxt.xml: Remove.
5962 * features/arm/arm-with-m-fpa-layout.c: Remove.
5963 * features/arm/arm-with-m-fpa-layout.xml: Remove.
5964 * features/arm/arm-with-m-vfp-d16.c: Remove.
5965 * features/arm/arm-with-m-vfp-d16.xml: Remove.
5966 * features/arm/arm-with-m.c: Remove.
5967 * features/arm/arm-with-m.xml: Remove.
5968 * features/arm/arm-with-neon.c: Remove.
5969 * features/arm/arm-with-neon.xml: Remove.
5970 * features/arm/arm-with-vfpv2.c: Remove.
5971 * features/arm/arm-with-vfpv2.xml: Remove.
5972 * features/arm/arm-with-vfpv3.c: Remove.
5973 * features/arm/arm-with-vfpv3.xml: Remove.
5974
5975 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5976
5977 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5978
5979 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5980
5981 * arch/aarch32.c (aarch32_create_target_description): Create
5982 target descriptions using features.
5983 * arch/arm.c (arm_create_target_description)
5984 (arm_create_mprofile_target_description): Likewise.
5985 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5986
5987 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5988
5989 * Makefile.in: Add new files.
5990 * aarch32-tdep.c: New file.
5991 * aarch32-tdep.h: New file.
5992 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5993 Call aarch32_read_description.
5994 * arch/aarch32.c: New file.
5995 * arch/aarch32.h: New file.
5996 * arch/arm.c (arm_create_target_description)
5997 (arm_create_mprofile_target_description): New function.
5998 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5999 (arm_create_target_description)
6000 (arm_create_mprofile_target_description): New declaration.
6001 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6002 read_description functions.
6003 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6004 Likewise.
6005 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6006 * arm-tdep.c (tdesc_arm_list): New variable.
6007 (arm_register_g_packet_guesses): Call create description functions.
6008 (arm_read_description) (arm_read_mprofile_description): New
6009 function.
6010 * arm-tdep.h (arm_read_description)
6011 (arm_read_mprofile_description): Add declaration.
6012 * configure.tgt: Add new files.
6013
6014 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6015
6016 * top.c (new_ui_command): Open specified terminal just once.
6017
6018 2019-07-18 Tom Tromey <tromey@adacore.com>
6019
6020 * symtab.c (main_name): Constify return type.
6021 * symfile.c (set_initial_language): Update.
6022 * symtab.h (main_name): Constify return type.
6023
6024 2019-07-17 Tom Tromey <tom@tromey.com>
6025
6026 * tui/tui-winsource.c (tui_update_source_window)
6027 (tui_update_source_window_as_is)
6028 (tui_update_source_windows_with_line): Remove return.
6029 * tui/tui-disasm.c (tui_show_disassem)
6030 (tui_show_disassem_and_update_source): Remove return.
6031 * tui/tui.c (tui_reset): Remove return.
6032 * tui/tui-wingeneral.c
6033 (tui_check_and_display_highlight_if_needed): Remove return.
6034
6035 2019-07-17 Tom Tromey <tom@tromey.com>
6036
6037 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6038
6039 2019-07-17 Tom Tromey <tom@tromey.com>
6040
6041 * tui/tui-winsource.h (struct tui_exec_info_window)
6042 (struct tui_source_window_base): Move from tui-data.h.
6043 * tui/tui-winsource.c: Move many method definitions from
6044 elsewhere. Remove "structuring" comments.
6045 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6046 (tui_source_window_base::refresh_window): Move to
6047 tui-winsource.c.
6048 * tui/tui-win.c (tui_source_window_base::refresh_all)
6049 (tui_source_window_base::update_tab_width)
6050 (tui_source_window_base::set_new_height)
6051 (tui_source_window_base::do_make_visible_with_new_height): Move to
6052 tui-winsource.c.
6053 * tui/tui-source.h: Update.
6054 * tui/tui-source.c (tui_source_window_base::reset): Move to
6055 tui-winsource.c.
6056 * tui/tui-disasm.h: Update.
6057 * tui/tui-data.h (struct tui_exec_info_window): Move to
6058 tui-winsource.h.
6059 (struct tui_source_window_base): Likewise.
6060 * tui/tui-data.c (tui_source_window_base::clear_detail)
6061 (tui_source_window_base, ~tui_source_window_base): Move to
6062 tui-winsource.c.
6063
6064 2019-07-17 Tom Tromey <tom@tromey.com>
6065
6066 * tui/tui-win.c (tui_resize_all)
6067 (tui_source_window_base::update_tab_width)
6068 (tui_adjust_win_heights): Update.
6069 (tui_win_info::make_invisible_and_set_new_height): Rename from
6070 make_invisible_and_set_new_height.
6071 * tui/tui-data.h (struct tui_win_info)
6072 <make_invisible_and_set_new_height>: New method.
6073
6074 2019-07-17 Tom Tromey <tom@tromey.com>
6075
6076 * tui/tui.c: Update.
6077 * tui/tui-source.h (struct tui_source_window): Move from
6078 tui-data.h.
6079 * tui/tui-layout.c: Update.
6080 * tui/tui-disasm.c: Update.
6081 * tui/tui-data.h (struct tui_source_window): Move to
6082 tui-source.h.
6083
6084 2019-07-17 Tom Tromey <tom@tromey.com>
6085
6086 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6087 tui-data.h.
6088 * tui/tui-data.h (struct tui_disasm_window): Move to
6089 tui-disasm.h.
6090
6091 2019-07-17 Tom Tromey <tom@tromey.com>
6092
6093 * tui/tui-regs.h (struct tui_data_item_window): Move from
6094 tui-data.h.
6095 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6096 * tui/tui-data.h (struct tui_data_item_window): Move to
6097 tui-regs.h.
6098 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6099
6100 2019-07-17 Tom Tromey <tom@tromey.com>
6101
6102 * tui/tui.c: Update.
6103 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6104 (tui_cmd_window::max_height): Move to tui-command.c.
6105 * tui/tui-layout.c: Update.
6106 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6107 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6108 tui-command.c.
6109 * tui/tui-command.h (struct tui_cmd_window): Move from
6110 tui-data.h.
6111 * tui/tui-command.c: Remove "structuring" comments.
6112 (tui_cmd_window::clear_detail)
6113 (tui_cmd_window::do_make_visible_with_new_height)
6114 (tui_cmd_window::max_height): Move from elsewhere.
6115
6116 2019-07-17 Tom Tromey <tom@tromey.com>
6117
6118 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6119 Now static.
6120 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6121 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6122
6123 2019-07-17 Tom Tromey <tom@tromey.com>
6124
6125 * tui/tui.c: Update.
6126 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6127 tui-regs.c.
6128 * tui/tui-windata.h: Remove file.
6129 * tui/tui-windata.c: Remove file.
6130 * tui/tui-win.c (tui_data_window::set_new_height)
6131 (tui_data_window::do_make_visible_with_new_height): Move to
6132 tui-regs.c.
6133 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6134 * tui/tui-regs.c: Remove "structuring" comments.
6135 (tui_data_window::first_data_item_displayed)
6136 (tui_data_window::delete_data_content_windows)
6137 (tui_data_window::erase_data_content)
6138 (tui_data_window::display_all_data)
6139 (tui_data_window::refresh_all)
6140 (tui_data_window::do_scroll_vertical)
6141 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6142 (tui_data_window::do_make_visible_with_new_height)
6143 (tui_data_window::refresh_window): Move from elsewhere.
6144 (_initialize_tui_regs): Move to end of file.
6145 * tui/tui-layout.c: Update.
6146 * tui/tui-hooks.c: Update.
6147 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6148 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6149 tui-regs.c.
6150 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6151
6152 2019-07-17 Tom Tromey <tom@tromey.com>
6153
6154 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6155 seen.
6156
6157 2019-07-17 Tom Tromey <tom@tromey.com>
6158
6159 * tui/tui-win.c (tui_source_window_base::set_new_height)
6160 (tui_source_window_base::do_make_visible_with_new_height): Use
6161 m_has_locator field directly.
6162 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6163 method.
6164 (struct tui_source_window_base) <has_locator>: Likewise.
6165
6166 2019-07-17 Tom Tromey <tom@tromey.com>
6167
6168 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6169 Don't declare.
6170 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6171 Remove.
6172 * tui/tui-win.c (tui_source_window_base::set_new_height)
6173 (tui_source_window_base::set_new_height)
6174 (make_invisible_and_set_new_height)
6175 (tui_source_window_base::do_make_visible_with_new_height)
6176 (tui_source_window_base::do_make_visible_with_new_height):
6177 Update.
6178 * tui/tui-layout.c (show_source_disasm_command, show_data)
6179 (show_source_or_disasm_and_command): Update.
6180 * tui/tui-layout.c (show_layout): Update.
6181
6182 2019-07-17 Tom Tromey <tom@tromey.com>
6183
6184 * tui/tui-layout.c (make_data_window): Remove.
6185 (show_data): Unify creation and re-initialization cases.
6186
6187 2019-07-17 Tom Tromey <tom@tromey.com>
6188
6189 * tui/tui-layout.c (make_source_window, make_disasm_window):
6190 Remove.
6191 (show_data): Unify creation and re-initialization cases.
6192
6193 2019-07-17 Tom Tromey <tom@tromey.com>
6194
6195 * tui/tui-layout.c (make_command_window): Remove.
6196 (show_source_disasm_command, show_source_or_disasm_and_command):
6197 Unify creation and re-initialization cases.
6198
6199 2019-07-17 Tom Tromey <tom@tromey.com>
6200
6201 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6202 creation and re-initialization cases.
6203
6204 2019-07-17 Tom Tromey <tom@tromey.com>
6205
6206 * tui/tui-regs.c (tui_get_register): Return void.
6207
6208 2019-07-17 Tom Tromey <tom@tromey.com>
6209
6210 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6211 Simplify.
6212
6213 2019-07-17 Tom Tromey <tom@tromey.com>
6214
6215 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6216 resetting.
6217
6218 2019-07-17 Tom Tromey <tom@tromey.com>
6219
6220 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6221 * tui/tui-regs.c (tui_reg_layout): New function.
6222 (tui_show_registers, tui_reg_command): Use it.
6223 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6224 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6225 parameters.
6226 (tui_layout_command): Remove.
6227
6228 2019-07-17 Tom Tromey <tom@tromey.com>
6229
6230 * tui/tui-layout.h (tui/tui-layout): Return void.
6231 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6232
6233 2019-07-17 Tom Tromey <tom@tromey.com>
6234
6235 * tui/tui-layout.c (show_source_disasm_command, show_data):
6236 Update.
6237 (reset_locator): Remove.
6238 (show_source_or_disasm_and_command): Update.
6239
6240 2019-07-17 Tom Tromey <tom@tromey.com>
6241
6242 * tui/tui-source.c (tui_source_window_base::reset): Remove
6243 win_type parameter.
6244 * tui/tui-layout.c (make_command_window, make_source_window)
6245 (make_disasm_window, make_data_window)
6246 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6247 (reset_locator, show_source_or_disasm_and_command): Update.
6248 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6249 win_type parameter.
6250 (struct tui_source_window_base) <reset>: Likewise.
6251
6252 2019-07-17 Tom Tromey <tom@tromey.com>
6253
6254 * tui/tui-layout.c (show_source_disasm_command): Use
6255 reset_locator.
6256 (reset_locator): New function.
6257 (init_and_make_win): Remove.
6258 (show_source_or_disasm_and_command): Use reset_locator.
6259
6260 2019-07-17 Tom Tromey <tom@tromey.com>
6261
6262 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6263 condition.
6264 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6265 Remove condition.
6266 * tui/tui-source.c (tui_source_window_base::reset): New method.
6267 * tui/tui-layout.c (make_command_window): Don't call
6268 init_and_make_win.
6269 (make_source_window, make_disasm_window): Don't call
6270 make_source_or_disasm_window.
6271 (make_data_window): Don't call init_and_make_win. Change calling
6272 convention.
6273 (show_source_disasm_command, show_data): Simplify.
6274 (make_source_or_disasm_window): Remove.
6275 (show_source_or_disasm_and_command): Simplify.
6276 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6277 (struct tui_source_window_base) <reset>: Likewise.
6278 <execution_info>: Remove initializer.
6279 * tui/tui-data.c (tui_source_window_base): Initialize
6280 execution_info.
6281
6282 2019-07-17 Tom Tromey <tom@tromey.com>
6283
6284 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6285 variable.
6286
6287 2019-07-17 Tom Tromey <tom@tromey.com>
6288
6289 * tui/tui.c (tui_rl_other_window): Update.
6290 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6291 superclass method first. Always iterate over regs_content.
6292 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6293 method.
6294 * tui/tui-win.c (tui_set_focus_command): Update.
6295
6296 2019-07-17 Tom Tromey <tom@tromey.com>
6297
6298 * tui/tui-win.c (tui_set_focus_command): Rename from
6299 tui_set_focus. Call tui_enable.
6300 (tui_set_focus_command): Remove.
6301
6302 2019-07-17 Tom Tromey <tom@tromey.com>
6303
6304 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6305 refresh_window.
6306 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6307 touchwin.
6308 (tui_data_window::refresh_window): Call refresh_window on data
6309 items. Always call superclass refresh_window.
6310 (tui_win_info::refresh): Remove.
6311 (tui_source_window_base::refresh_window): Update.
6312 (tui_refresh_all): Update.
6313 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6314 refresh_window.
6315 (show_source_or_disasm_and_command): Likewise.
6316 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6317 (struct tui_source_window_base) <refresh>: Likewise.
6318
6319 2019-07-17 Tom Tromey <tom@tromey.com>
6320
6321 * tui/tui-winsource.c (tui_clear_source_content)
6322 (tui_show_source_content): Update.
6323 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6324 whether content is empty.
6325 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6326 Remove.
6327
6328 2019-07-17 Tom Tromey <tom@tromey.com>
6329
6330 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6331 window's contents.
6332 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6333 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6334
6335 2019-07-17 Tom Tromey <tom@tromey.com>
6336
6337 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6338 (struct tui_data_item_window): Update.
6339
6340 2019-07-17 Tom Tromey <tom@tromey.com>
6341
6342 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6343 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6344 defines.
6345
6346 2019-07-17 Tom Tromey <tom@tromey.com>
6347
6348 * tui/tui-winsource.h (tui_erase_source_content)
6349 (tui_clear_source_content): Remove "display_prompt" parameter.
6350 * tui/tui-winsource.c (tui_update_source_window_as_is)
6351 (tui_update_source_windows_with_addr): Update.
6352 (tui_clear_source_content): Remove "display_prompt" parameter.
6353 (tui_erase_source_content): Likewise. Simplify.
6354 (tui_show_source_content): Update.
6355 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6356 * tui/tui-stack.c (tui_show_frame_info): Update.
6357 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6358 Remove defines.
6359
6360 2019-07-17 Tom Tromey <tom@tromey.com>
6361
6362 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6363 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6364 parameter.
6365 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6366 parameter.
6367
6368 2019-07-17 Tom Tromey <tom@tromey.com>
6369
6370 * tui/tui-winsource.c (tui_clear_source_content)
6371 (tui_show_source_content, tui_show_exec_info_content)
6372 (tui_clear_exec_info_content): Update.
6373 * tui/tui-stack.c (tui_show_locator_content): Update.
6374 (tui_show_frame_info): Update.
6375 * tui/tui-source.h (tui_source_window): Don't declare.
6376 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6377 from tui_source_is_displayed.
6378 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6379 Remove field.
6380 (struct tui_source_window_base) <content_in_use>: New field. Now
6381 bool.
6382 (struct tui_source_window) <showing_source_p>: New method.
6383 (TUI_SRC_WIN): Change cast.
6384 * tui/tui-data.c (tui_initialize_static_data): Update.
6385
6386 2019-07-17 Tom Tromey <tom@tromey.com>
6387
6388 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6389 location_matches_p.
6390 * tui/tui-source.c (tui_source_window::location_matches_p): New
6391 method.
6392 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6393 method.
6394 * tui/tui-data.h (struct tui_source_window_base)
6395 <location_matches_p>: New method.
6396 (struct tui_source_window, struct tui_disasm_window)
6397 <location_matches_p>: Likewise.
6398
6399 2019-07-17 Tom Tromey <tom@tromey.com>
6400
6401 * tui/tui-win.c (tui_set_win_height_command): Rename from
6402 tui_set_win_height.
6403 (tui_set_win_height_command): Remove.
6404
6405 2019-07-17 Tom Tromey <tom@tromey.com>
6406
6407 * tui/tui-source.c (tui_source_window): New constructor. Add
6408 observer.
6409 (~tui_source_window): New destructor.
6410 (tui_source_window::style_changed): New method.
6411 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6412 (tui_attach_detach_observers): Update.
6413 * tui/tui-data.h (struct tui_source_window): Make constructor not
6414 inline. Add destructor.
6415 (struct tui_source_window) <style_changed>: New method.
6416 <m_observable>: New member.
6417
6418 2019-07-17 Tom Tromey <tom@tromey.com>
6419
6420 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6421 * tui/tui-win.c (tui_resize_all): Fix typo.
6422
6423 2019-07-17 Tom Tromey <tom@tromey.com>
6424
6425 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6426 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6427 (tui_refresh_all): Remove "list" parameter. Use foreach.
6428 * tui/tui-win.c (window_name_completer): Use foreach.
6429 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6430 (update_tab_width): Likewise.
6431 * tui/tui-layout.c (show_layout): Update.
6432 * tui/tui-data.h (class tui_window_iterator): New.
6433 (struct all_tui_windows): New.
6434 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6435
6436 2019-07-17 Tom Tromey <tom@tromey.com>
6437
6438 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6439 parameter. Don't reference globals.
6440 (tui_reg_command): Update.
6441
6442 2019-07-17 Tom Tromey <tom@tromey.com>
6443
6444 * tui/tui-regs.c (tui_show_registers): Simplify.
6445
6446 2019-07-17 Tom Tromey <tom@tromey.com>
6447
6448 * tui/tui-regs.c (tui_show_registers): Update.
6449 (tui_show_register_group): Add win_info parameter.
6450
6451 2019-07-17 Tom Tromey <tom@tromey.com>
6452
6453 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6454 Rename from tui_display_reg_element_at_line.
6455 (tui_data_window::display_registers_from_line): Update.
6456 * tui/tui-data.h (struct tui_data_window)
6457 <display_reg_element_at_line>: New method.
6458
6459 2019-07-17 Tom Tromey <tom@tromey.com>
6460
6461 * tui/tui-regs.h (tui_display_registers_from)
6462 (tui_display_registers_from_line): Don't declare.
6463 * tui/tui-windata.c (tui_data_window::display_all_data)
6464 (tui_data_window::refresh_all)
6465 (tui_data_window::do_scroll_vertical): Update.
6466 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6467 from tui_display_registers_from.
6468 (tui_display_reg_element_at_line): Update.
6469 (tui_data_window::display_registers_from_line): Rename from
6470 tui_display_registers_from_line.
6471 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6472 display_registers_from_line>: New methods.
6473
6474 2019-07-17 Tom Tromey <tom@tromey.com>
6475
6476 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6477 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6478 from tui_erase_data_content.
6479 (tui_data_window::display_all_data)
6480 (tui_data_window::refresh_all)
6481 (tui_data_window::do_scroll_vertical): Update.
6482 * tui/tui-regs.c (tui_show_registers): Update.
6483 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6484 New method.
6485
6486 2019-07-17 Tom Tromey <tom@tromey.com>
6487
6488 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6489 declare.
6490 * tui/tui-windata.c
6491 (tui_data_window::delete_data_content_windows): Rename from
6492 tui_delete_data_content_windows.
6493 (tui_data_window::display_all_data)
6494 (tui_data_window::do_scroll_vertical): Update.
6495 * tui/tui-data.h (struct tui_data_window)
6496 <delete_data_content_windows>: New method.
6497
6498 2019-07-17 Tom Tromey <tom@tromey.com>
6499
6500 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6501 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6502
6503 2019-07-17 Tom Tromey <tom@tromey.com>
6504
6505 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6506 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6507 from tui_display_all_data.
6508 * tui/tui-win.c
6509 (tui_data_window::do_make_visible_with_new_height): Update.
6510 * tui/tui-regs.c (tui_show_registers): Update.
6511 * tui/tui-layout.c (tui_set_layout): Update.
6512 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6513 method.
6514
6515 2019-07-17 Tom Tromey <tom@tromey.com>
6516
6517 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6518 * tui/tui-windata.c (tui_display_data_from): Remove.
6519 (tui_data_window::refresh_all): Update.
6520
6521 2019-07-17 Tom Tromey <tom@tromey.com>
6522
6523 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6524 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6525 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6526 tui_display_registers_from_line.
6527 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6528 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6529 "force_display" parameter.
6530
6531 2019-07-17 Tom Tromey <tom@tromey.com>
6532
6533 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6534 declare.
6535 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6536 Rename from tui_first_reg_element_no_inline.
6537 (tui_display_reg_element_at_line)
6538 (tui_display_registers_from_line): Update.
6539 * tui/tui-data.h (struct tui_data_window)
6540 <first_reg_element_no_inline>: New method.
6541
6542 2019-07-17 Tom Tromey <tom@tromey.com>
6543
6544 * tui/tui-windata.c (tui_display_data_from)
6545 (tui_data_window::do_scroll_vertical): Update.
6546 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6547 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6548 Rename from tui_line_from_reg_element_no.
6549 (tui_display_registers_from_line): Update.
6550 * tui/tui-data.h (struct tui_data_window)
6551 <line_from_reg_element_no>: New method.
6552
6553 2019-07-17 Tom Tromey <tom@tromey.com>
6554
6555 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6556 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6557 tui_last_regs_line_no.
6558 (tui_display_reg_element_at_line)
6559 (tui_display_registers_from_line): Update.
6560 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6561 method.
6562
6563 2019-07-17 Tom Tromey <tom@tromey.com>
6564
6565 PR tui/24722:
6566 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6567 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6568 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6569 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6570 (tui_update_breakpoint_info): Likewise.
6571 * tui/tui-hooks.c (tui_event_create_breakpoint)
6572 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6573 Update.
6574
6575 2019-07-17 Tom Tromey <tom@tromey.com>
6576
6577 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6578
6579 2019-07-17 Tom Tromey <tom@tromey.com>
6580
6581 * tui/tui-winsource.c (tui_update_source_window_as_is)
6582 (tui_update_source_windows_with_addr): Update.
6583 * tui/tui-source.h (tui_set_source_content)
6584 (tui_show_symtab_source): Add "win_info" parameter.
6585 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6586 parameter.
6587 (tui_show_symtab_source): Likewise.
6588
6589 2019-07-17 Tom Tromey <tom@tromey.com>
6590
6591 * tui/tui-wingeneral.c
6592 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6593
6594 2019-07-17 Tom Tromey <tom@tromey.com>
6595
6596 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6597 (struct tui_cmd_window) <can_scroll>: New method.
6598 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6599 method.
6600
6601 2019-07-17 Tom Tromey <tromey@adacore.com>
6602
6603 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6604 do_field_signed>: Rename. Change type of "value".
6605 * ui-out.c (ui_out::field_signed): Rename from field_int.
6606 Change type of "value".
6607 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6608 type of "value".
6609 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6610 do_field_int. Change type of "value".
6611 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6612 do_field_int. Change type of "value".
6613 * tracepoint.c (trace_status_mi, tfind_1)
6614 (print_one_static_tracepoint_marker): Update.
6615 * thread.c (print_thread_info_1, print_selected_thread_frame):
6616 Update.
6617 * stack.c (print_frame, print_frame_info): Update.
6618 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6619 Update.
6620 * source.c (print_source_lines_base): Update.
6621 * skip.c (info_skip_command): Update.
6622 * record-btrace.c (btrace_ui_out_decode_error)
6623 (btrace_call_history_src_line): Update.
6624 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6625 Update.
6626 * progspace.c (print_program_space): Update.
6627 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6628 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6629 do_field_int. Change type of "value".
6630 * mi/mi-out.c (mi_ui_out::do_table_begin)
6631 (mi_ui_out::do_table_header): Update.
6632 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6633 type of "value".
6634 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6635 (mi_cmd_data_list_changed_registers, output_register)
6636 (mi_cmd_data_read_memory, mi_load_progress)
6637 (mi_cmd_trace_frame_collected): Update.
6638 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6639 Update.
6640 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6641 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6642 (mi_cmd_var_list_children, varobj_update_one): Update.
6643 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6644 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6645 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6646 * inferior.c (print_inferior): Update.
6647 * gdb_bfd.c (print_one_bfd): Update.
6648 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6649 Update.
6650 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6651 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6652 do_field_int. Change type of "value".
6653 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6654 do_field_int. Change type of "value".
6655 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6656 (print_one_breakpoint_location, print_it_catch_fork)
6657 (print_one_catch_fork, print_it_catch_vfork)
6658 (print_one_catch_vfork, print_it_catch_solib)
6659 (print_it_catch_exec, print_it_ranged_breakpoint)
6660 (print_mention_watchpoint, print_mention_masked_watchpoint)
6661 (bkpt_print_it, update_static_tracepoint): Update.
6662 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6663 * break-catch-syscall.c (print_it_catch_syscall): Update.
6664 * ada-tasks.c (print_ada_task_info): Update.
6665 * ada-lang.c (print_it_exception, print_mention_exception):
6666 Update.
6667
6668 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6669
6670 PR breakpoints/24541
6671 * gdbarch.c: Regenerate.
6672 * gdbarch.h: Regenerate.
6673 * gdbarch.sh: Adjust return type and parameter types for
6674 'stap_adjust_register'.
6675 (i386_stap_adjust_register): Adjust signature and return new
6676 register name.
6677 * stap-probe.c (stap_parse_register_operand): Adjust use of
6678 'gdbarch_stap_adjust_register'.
6679
6680 2019-07-17 Tom Tromey <tromey@adacore.com>
6681
6682 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6683 declare VEC.
6684 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6685 std::vector.
6686 (struct s390_process_info): Add initializers.
6687 (s390_add_process): Use new.
6688 (s390_linux_nat_target::low_forget_process): Use delete.
6689 (s390_linux_nat_target::low_new_fork)
6690 (s390_linux_nat_target::stopped_by_watchpoint)
6691 (s390_linux_nat_target::low_prepare_to_resume)
6692 (s390_linux_nat_target::insert_watchpoint)
6693 (s390_linux_nat_target::insert_hw_breakpoint)
6694 (s390_linux_nat_target::remove_watchpoint)
6695 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6696
6697 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6698
6699 * aarch64-fbsd-nat.c: Include regcache.h.
6700 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6701 argument.
6702 (aarch64_fbsd_nat_target::fetch_registers)
6703 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6704 variable.
6705 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6706
6707 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6708
6709 * fbsd-nat.c: Include gdbarch.h.
6710
6711 2019-07-15 Tom Tromey <tromey@adacore.com>
6712
6713 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6714
6715 2019-07-15 Tom Tromey <tromey@adacore.com>
6716
6717 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6718 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6719 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6720 * cli-out.c (cli_ui_out::do_field_int): New method.
6721 * ui-out.c (ui_out::field_unsigned): New method.
6722 * symfile.c (generic_load): Use field_unsigned.
6723 (print_transfer_performance): Likewise.
6724 * record-btrace.c (ui_out_field_uint): Remove.
6725 (btrace_call_history_insn_range, btrace_call_history): Use
6726 field_unsigned.
6727 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6728 field_unsigned.
6729 * ui-out.h (class ui_out) <field_unsigned>: New method.
6730 <do_field_unsigned>: Likewise.
6731
6732 2019-07-15 Tom Tromey <tromey@adacore.com>
6733
6734 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6735 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6736 * target.c (flash_erase_command): Use field_string.
6737 * infrun.c (print_signal_received_reason): Use field_string.
6738 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6739 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6740 field_string.
6741 * ada-tasks.c (print_ada_task_info): Use field_string.
6742
6743 2019-07-15 Tom Tromey <tromey@adacore.com>
6744
6745 * target.c (flash_erase_command): Use field_core_addr.
6746 * symfile.c (generic_load): Use field_core_addr.
6747 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6748 Use field_core_addr.
6749 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6750 field_core_addr.
6751
6752 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6753
6754 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6755 value if its desired type is smaller than a CORE_ADDR and signed.
6756
6757 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6758
6759 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6760 of changes to field names, and use new is_reference field to
6761 decide if a property is a reference or not.
6762 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6763 field.
6764 (struct dwarf2_property_baton): Update header comment, rename
6765 'referenced_type' to 'property_type' and update comments.
6766 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6767 default property type, store in property baton, update to take
6768 accound of renamed field.
6769 (read_func_scope): Update call to attr_to_dynamic_prop.
6770 (read_array_type): Likewise.
6771 (dwarf2_per_cu_addr_sized_int_type): New function.
6772 (read_subrange_index_type): Move type finding code to
6773 dwarf2_per_cu_addr_sized_int_type.
6774 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6775 (dwarf2_per_cu_addr_type): New function.
6776 (set_die_type): Update calls to attr_to_dynamic_prop.
6777
6778 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6779
6780 * dwarf2read.c (read_subrange_index_type): New function.
6781 (read_subrange_type): Move code into new function and call it.
6782 * gdbtypes.c (create_range_type): Add some asserts.
6783
6784 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6785
6786 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6787 update return statements.
6788 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6789 declaration, and update comment to match.
6790 * gdbtypes.c (resolve_dynamic_array): Update call to
6791 dwarf2_evaluate_property to match new return type.
6792
6793 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6794
6795 * valarith.c (value_subscripted_rvalue): Change lowerbound
6796 parameter type from int to LONGEST.
6797 * value.h (value_subscripted_rvalue): Likewise in declaration.
6798
6799 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6800
6801 * cli/cli-utils.c (info_print_command_completer): New function.
6802 * cli/cli-utils.h: Add 'completer.h' include, and forward
6803 declaration for 'struct cmd_list_element'.
6804 (info_print_command_completer): Declare.
6805 * stack.c (_initialize_stack): Add completer for 'info locals' and
6806 'info args'.
6807 * symtab.c (_initialize_symtab): Add completer for 'info
6808 variables' and 'info functions'.
6809 * NEWS: Mention completion for additional info commands.
6810
6811 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6812
6813 * cli/cli-utils.c (extract_info_print_args): Delete.
6814 (extract_arg_maybe_quoted): Delete.
6815 (info_print_options_defs): New variable.
6816 (make_info_print_options_def_group): New function.
6817 (extract_info_print_options): Define new function.
6818 * cli/cli-utils.h (extract_info_print_args): Delete.
6819 (struct info_print_options): New structure.
6820 (extract_info_print_options): Declare new function.
6821 * stack.c (info_locals_command): Update to use new
6822 extract_info_print_options, also add a header comment.
6823 (info_args_command): Likewise.
6824 * symtab.c (info_variables_command): Likewise.
6825 (info_functions_command): Likewise.
6826
6827 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6828
6829 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6830 to extract string arguments.
6831 * common/common-utils.c (extract_string_maybe_quoted): New function.
6832 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6833
6834 2019-07-11 Tom Tromey <tromey@adacore.com>
6835
6836 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6837 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6838 * top.h (gdbinit): Don't declare.
6839 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6840 into...
6841 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
6842 * top.c (gdb_init): Don't call init_cli_cmds.
6843 (gdbinit): Remove.
6844 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6845
6846 2019-07-11 Tom Tromey <tromey@adacore.com>
6847
6848 * python/py-inferior.c (add_thread_object): Don't use thread_obj
6849 after it has been moved.
6850
6851 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6852
6853 * valops.c (value_must_coerce_to_target): Change return type to
6854 bool.
6855 * value.h (value_must_coerce_to_target): Likewise.
6856
6857 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
6858
6859 * breakpoint.c (is_hardware_watchpoint): Remove
6860 forward-declaration.
6861 (is_masked_watchpoint): Change return type to bool.
6862 (is_tracepoint): Likewise.
6863 (is_breakpoint): Likewise.
6864 (is_hardware_watchpoint): Likewise.
6865 (is_watchpoint): Likewise.
6866 (is_no_memory_software_watchpoint): Likewise.
6867 (is_catchpoint): Likewise.
6868 (breakpoint_1): Make FILTER parameter's return type bool.
6869 is_masked_watchpoint): Change return type to bool.
6870 (save_breakpoints): Make FILTER parameter's return type bool.
6871 * breakpoint.h (is_breakpoint): Change return type to bool.
6872 (is_watchpoint): Likewise.
6873 (is_catchpoint): Likewise.
6874 (is_tracepoint): Likewise.
6875
6876 2019-07-10 Tom Tromey <tom@tromey.com>
6877
6878 * defs.h: Don't include gdbarch.h.
6879 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6880 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6881 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6882 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6883 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6884 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6885 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6886 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6887 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6888 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6889 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6890 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6891 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6892 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6893 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6894 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6895 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6896 record-btrace.c, record.h, regcache-dump.c, regcache.h,
6897 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6898 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6899 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6900 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6901 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6902 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6903 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6904 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6905 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6906
6907 2019-07-10 Tom Tromey <tromey@adacore.com>
6908
6909 * ada-lang.h (is_ada_exception_catchpoint): Declare.
6910 * breakpoint.c (init_ada_exception_breakpoint): Register as
6911 bp_catchpoint.
6912 (print_one_breakpoint_location, print_one_breakpoint): Use
6913 is_ada_exception_catchpoint.
6914 * ada-lang.c (class ada_catchpoint_location): Pass
6915 bp_loc_software_breakpoint to bp_location constructor.
6916 (is_ada_exception_catchpoint): New function.
6917
6918 2019-07-10 Tom Tromey <tromey@adacore.com>
6919
6920 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
6921 VEC.
6922 (struct arm_exidx_entry): New method operator<.
6923 (struct arm_exidx_data) <section_maps>: Change type.
6924 (arm_exidx_data_free): Remove.
6925 (arm_exidx_data_key): Change type. Move lower.
6926 (arm_exidx_new_objfile): Update.
6927 (arm_compare_exidx_entries): Remove.
6928 (arm_find_exidx_entry, _initialize_arm_tdep)
6929
6930 2019-07-10 Tom Tromey <tromey@adacore.com>
6931
6932 * solib-spu.c (ocl_program_data_key): Change type.
6933 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6934 Update.
6935
6936 2019-07-10 Tom Tromey <tromey@adacore.com>
6937
6938 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
6939 (struct solib_aix_inferior_data) <library_list>: Change type.
6940 (solib_aix_inferior_data_handle): Change type.
6941 (get_solib_aix_inferior_data): Update.
6942 (solib_aix_free_library_list): Remove.
6943 (library_list_start_library): Update.
6944 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6945 return type.
6946 (solib_aix_get_library_list)
6947 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6948 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6949
6950 2019-07-10 Tom Tromey <tromey@adacore.com>
6951
6952 * solib-dsbt.c (struct dsbt_info): Add initializers.
6953 (solib_dsbt_pspace_data): Change type.
6954 (dsbt_pspace_data_cleanup): Remove.
6955 (get_dsbt_info, _initialize_dsbt_solib): Update.
6956
6957 2019-07-10 Tom Tromey <tromey@adacore.com>
6958
6959 * spu-tdep.c (spu_overlay_data): Change type.
6960 (spu_get_overlay_table, spu_overlay_new_objfile)
6961 (_initialize_spu_tdep): Update.
6962
6963 2019-07-10 Tom Tromey <tromey@adacore.com>
6964
6965 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6966 destructor.
6967 (dbx_objfile_data_key): Change type and declare later.
6968 (DBX_SYMFILE_INFO): Rewrite.
6969 * dbxread.c (dbx_objfile_data_key): Change type.
6970 (dbx_symfile_init): Update.
6971 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
6972 (coffstab_build_psymtabs, elfstab_build_psymtabs)
6973 (stabsect_build_psymtabs, _initialize_dbxread): Update.
6974
6975 2019-07-10 Tom Tromey <tromey@adacore.com>
6976
6977 * jit.c (jit_program_space_key): Change type. Move lower.
6978 (get_jit_program_space_data): Update.
6979 (jit_program_space_data_cleanup): Remove.
6980 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6981 Update.
6982 (struct jit_program_space_data): Add initializers.
6983
6984 2019-07-10 Tom Tromey <tromey@adacore.com>
6985
6986 * solib-darwin.c (struct darwin_info): Add initializers.
6987 (solib_darwin_pspace_data): Change type.
6988 (darwin_pspace_data_cleanup): Remove.
6989 (get_darwin_info, _initialize_darwin_solib): Update.
6990
6991 2019-07-10 Tom Tromey <tromey@adacore.com>
6992
6993 * remote-sim.c (struct sim_inferior_data): Add initializers,
6994 constructor, and destructor.
6995 (sim_inferior_data_key): Change type. Move lower.
6996 (check_for_duplicate_sim_descriptor): Update.
6997 (get_sim_inferior_data): Use new. Update.
6998 (~sim_inferior_data_cleanup): Rename from
6999 sim_inferior_data_cleanup. Simplify.
7000 (gdbsim_close_inferior, simulator_command)
7001 (sim_command_completer, _initialize_remote_sim): Update.
7002 (next_pid, INITIAL_PID): Move earlier.
7003
7004 2019-07-10 Tom Tromey <tromey@adacore.com>
7005
7006 * python/python-internal.h (create_thread_object): Return
7007 gdbpy_ref.
7008 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7009 * python/py-inferior.c (struct threadlist_entry): Add
7010 constructor.
7011 <thread_obj>: Now a gdbpy_ref.
7012 (thread_to_thread_object): Update.
7013 (add_thread_object): Use new.
7014 (delete_thread_object): Use delete.
7015 (infpy_threads): Update.
7016 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7017 GIL.
7018
7019 2019-07-10 Tom Tromey <tromey@adacore.com>
7020
7021 * valops.c (value_cast): Specialize error message for Ada.
7022
7023 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7024
7025 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7026
7027 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7028
7029 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7030 bpstat_should_step): Return bool, adjust comments.
7031 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7032 bpstat_should_step): Likewise.
7033
7034 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7035
7036 * features/Makefile: Use feature target descriptions for Arm.
7037 * features/arm/arm-core.c: Generate new file.
7038 * features/arm/arm-fpa.c: Likewise.
7039 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7040 * features/arm/arm-m-profile.c: Likewise.
7041 * features/arm/arm-vfpv2.c: Likewise.
7042 * features/arm/arm-vfpv3.c: Likewise.
7043 * features/arm/xscale-iwmmxt.c: Likewise.
7044 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7045
7046 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7047
7048 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7049 ptrace earlier.
7050
7051 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7052
7053 * features/aarch64-pauth.c: Regenerate.
7054
7055 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7056
7057 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7058 bool.
7059 (bpstat_what): Use false instead of 0.
7060
7061 2019-07-09 Pedro Alves <palves@redhat.com>
7062
7063 * break-catch-throw.c (is_exception_catchpoint): New.
7064 * breakpoint.c (print_one_breakpoint_location): New parameter
7065 'raw_loc'. Handle it. Use
7066 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7067 looking at the breakpoint's type.
7068 (print_one_breakpoint): If handling "maint info breakpoints", also
7069 print locations of exception catchpoints.
7070 * breakpoint.h (is_exception_catchpoint): Declare.
7071
7072 2019-07-09 Pedro Alves <palves@redhat.com>
7073
7074 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7075 "addr" field.
7076 (allocate_location_exception_catchpoint): New.
7077 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7078 (initialize_throw_catchpoint_ops): Install
7079 allocate_location_exception_catchpoint as allocate_location
7080 method.
7081 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7082 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7083 bp_loc_other.
7084 (breakpoint_address_is_meaningful): Delete.
7085 (bl_address_is_meaningful): New.
7086 (breakpoint_locations_match): Adjust comment.
7087 (bp_location_from_bp_type): New, factored out of...
7088 (bp_location::bp_location(breakpoint *)): ... this.
7089 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7090 factored out of...
7091 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7092 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7093 breakpoint_address_is_meaningful.
7094 (bp_locations_compare): Adjust comment.
7095 (update_global_location_list): Use bl_address_is_meaningful
7096 instead of breakpoint_address_is_meaningful.
7097 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7098 explicit.
7099 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7100 * python/py-breakpoint.c (bppy_get_location): No longer check
7101 whether location is null.
7102
7103 2019-07-09 Pedro Alves <palves@redhat.com>
7104
7105 PR c++/15468
7106 * breakpoint.c (print_one_breakpoint_location): Remove
7107 single-location assert.
7108
7109 2019-07-09 Tom Tromey <tom@tromey.com>
7110
7111 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7112 * configure: Rebuild.
7113 * configure.ac: Change common to gdbsupport.
7114 * gdbsupport: Rename from common.
7115 * acinclude.m4: Change common to gdbsupport.
7116 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7117 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7118 gdbsupport.
7119 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7120 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7121 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7122 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7123 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7124 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7125 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7126 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7127 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7128 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7129 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7130 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7131 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7132 coff-pe-read.c, command.h, compile/compile-c-support.c,
7133 compile/compile-c.h, compile/compile-cplus-symbols.c,
7134 compile/compile-cplus-types.c, compile/compile-cplus.h,
7135 compile/compile-loc2c.c, compile/compile.c, completer.c,
7136 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7137 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7138 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7139 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7140 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7141 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7142 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7143 features/aarch64-core.c, features/aarch64-fpu.c,
7144 features/aarch64-pauth.c, features/aarch64-sve.c,
7145 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7146 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7147 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7148 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7149 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7150 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7151 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7152 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7153 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7154 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7155 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7156 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7157 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7158 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7159 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7160 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7161 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7162 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7163 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7164 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7165 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7166 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7167 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7168 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7169 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7170 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7171 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7172 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7173 minsyms.c, mips-linux-tdep.c, namespace.h,
7174 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7175 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7176 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7177 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7178 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7179 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7180 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7181 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7182 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7183 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7184 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7185 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7186 procfs.c, producer.c, progspace.h, psymtab.h,
7187 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7188 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7189 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7190 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7191 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7192 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7193 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7194 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7195 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7196 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7197 target-memory.c, target.c, target.h, target/waitstatus.c,
7198 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7199 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7200 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7201 unittests/array-view-selftests.c,
7202 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7203 unittests/common-utils-selftests.c,
7204 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7205 unittests/format_pieces-selftests.c,
7206 unittests/function-view-selftests.c,
7207 unittests/lookup_name_info-selftests.c,
7208 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7209 unittests/mkdir-recursive-selftests.c,
7210 unittests/observable-selftests.c,
7211 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7212 unittests/parse-connection-spec-selftests.c,
7213 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7214 unittests/scoped_fd-selftests.c,
7215 unittests/scoped_mmap-selftests.c,
7216 unittests/scoped_restore-selftests.c,
7217 unittests/string_view-selftests.c, unittests/style-selftests.c,
7218 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7219 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7220 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7221 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7222 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7223 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7224
7225 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7226
7227 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7228 bool value.
7229 (decode_digits_ordinary): Set explicit_line field in sal.
7230 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7231 symtab_and_line that was set on an explicit line number in
7232 assembler code. Do always update the recorded symtab and line if
7233 we do skip the prologue.
7234
7235 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7236
7237 * breakpoint.c (set_breakpoint_location_function): Remove
7238 explicit_loc parameter.
7239 (momentary_breakpoint_from_master): Update call to
7240 set_breakpoint_location_function.
7241 (add_location_to_breakpoint): Likewise.
7242
7243 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7244
7245 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7246 required features based on default bfd type when no specific bfd
7247 is present.
7248
7249 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7250
7251 * NEWS: Mention that GDB printf and eval commands can now print
7252 C-style and Ada-style convenience var strings without
7253 calling the inferior.
7254 * printcmd.c (printf_c_string): Locally print GDB internal var
7255 instead of transiting via the inferior.
7256 (printf_wide_c_string): Likewise.
7257
7258 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7259
7260 PR breakpoints/25011
7261 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7262
7263 2019-07-04 Tom Tromey <tom@tromey.com>
7264
7265 PR tui/24724:
7266 * tui/tui-winsource.c (tui_clear_source_content): Update.
7267 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7268 (tui_update_breakpoint_info): Update.
7269 (tui_set_exec_info_content): Update.
7270 * tui/tui-source.c (tui_set_source_content_nil): Update.
7271 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7272 has_break.
7273 * tui/tui-data.h (enum tui_bp_flag): New.
7274 (tui_bp_flags): New enum flags type.
7275 (struct tui_source_element) <break_mode>: Change type. Rename
7276 from has_break.
7277 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7278 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7279 constants.
7280 * tui/tui-winsource.h: Fix comment.
7281
7282 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7283
7284 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7285 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7286 (store_fpregs_to_thread)
7287 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7288 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7289 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7290 (IWMMXT_REGS_SIZE): Add define.
7291 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7292 (fetch_vfp_regs, store_vfp_regs)
7293 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7294 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7295
7296 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7297
7298 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7299 defines.
7300 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7301 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7302 (ARM_INT_REGISTER_SIZE): ...to this.
7303 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7304 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7305 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7306 (arm_linux_collect_gregset, supply_nwfpe_register)
7307 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7308 defines.
7309 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7310 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7311 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7312 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7313 (arm_return_in_memory, arm_store_return_value)
7314 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7315 (arm_record_ld_st_multiple): Likewise.
7316 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7317 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7318
7319 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7320
7321 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7322 AARCH64_DISPLACED_MODIFIED_INSNS.
7323 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7324 (aarch64_displaced_step_copy_insn): Likewise.
7325 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7326 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7327 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7328 ARM_DISPLACED_MODIFIED_INSNS.
7329 * arm-tdep.c (arm_gdbarch_init): Likewise.
7330 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7331 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7332 (struct arm_displaced_step_closure): Use
7333 ARM_DISPLACED_MODIFIED_INSNS.
7334
7335 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7336
7337 * features/Makefile: Remove unused xml files.
7338 * features/aarch64.xml: Remove.
7339 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7340 * features/i386/amd64-avx-avx512.xml: Remove.
7341 * features/i386/amd64-avx-linux.xml: Remove.
7342 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7343 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7344 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7345 * features/i386/amd64-avx-mpx.xml: Remove.
7346 * features/i386/amd64-avx.xml: Remove.
7347 * features/i386/amd64-linux.xml: Remove.
7348 * features/i386/amd64-mpx-linux.xml: Remove.
7349 * features/i386/amd64-mpx.xml: Remove.
7350 * features/i386/amd64.xml: Remove.
7351 * features/i386/i386-avx-avx512-linux.xml: Remove.
7352 * features/i386/i386-avx-avx512.xml: Remove.
7353 * features/i386/i386-avx-linux.xml: Remove.
7354 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7355 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7356 * features/i386/i386-avx-mpx-linux.xml: Remove.
7357 * features/i386/i386-avx-mpx.xml: Remove.
7358 * features/i386/i386-avx.xml: Remove.
7359 * features/i386/i386-linux.xml: Remove.
7360 * features/i386/i386-mmx-linux.xml: Remove.
7361 * features/i386/i386-mmx.xml: Remove.
7362 * features/i386/i386-mpx-linux.xml: Remove.
7363 * features/i386/i386-mpx.xml: Remove.
7364 * features/i386/i386.xml: Remove.
7365 * features/i386/x32-avx-avx512-linux.xml: Remove.
7366 * features/i386/x32-avx-linux.xml: Remove.
7367 * features/i386/x32-linux.xml: Remove.
7368
7369 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7370
7371 * regformats/aarch64.dat: Remove.
7372 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7373 * regformats/i386/amd64-avx-linux.dat: Remove.
7374 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7375 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7376 * regformats/i386/amd64-linux.dat: Remove.
7377 * regformats/i386/amd64-mpx-linux.dat: Remove.
7378 * regformats/i386/amd64.dat: Remove.
7379 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7380 * regformats/i386/i386-avx-linux.dat: Remove.
7381 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7382 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7383 * regformats/i386/i386-linux.dat: Remove.
7384 * regformats/i386/i386-mmx-linux.dat: Remove.
7385 * regformats/i386/i386-mpx-linux.dat: Remove.
7386 * regformats/i386/i386.dat: Remove.
7387 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7388 * regformats/i386/x32-avx-linux.dat: Remove.
7389 * regformats/i386/x32-linux.dat: Remove.
7390
7391 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7392
7393 * aarch64-tdep.c: Remove xml self tests.
7394 * amd64-linux-tdep.c: Likewise.
7395 * amd64-tdep.c: Likewise.
7396 * i386-linux-tdep.c: Likewise.
7397 * i386-tdep.c: Likewise.
7398
7399 2019-07-03 Pedro Alves <palves@redhat.com>
7400
7401 PR cli/24732
7402 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7403 (pipe_cmd_option_defs): New.
7404 (make_pipe_cmd_options_def_group): New.
7405 (pipe_command): Use gdb::option::process_options.
7406 (pipe_command_completer): New function.
7407 (_initialize_cli_cmds): Install completer for "pipe" command.
7408
7409 2019-07-03 Pedro Alves <palves@redhat.com>
7410
7411 * cli/cli-option.c (union option_value) <string>: New field.
7412 (struct option_def_and_value): Add ctor, move ctor, dtor and
7413 use DISABLE_COPY_AND_ASSIGN.
7414 (option_def_and_value::clear_value): New.
7415 (parse_option, save_option_value_in_ctx, get_val_type_str)
7416 (add_setshow_cmds_for_options): Handle var_string.
7417 * cli-option.h (union option_def::var_address) <string>: New
7418 field.
7419 (struct string_option_def): New.
7420 * maint-test-options.c (struct test_options_opts): Add default
7421 ctor and use DISABLE_COPY_AND_ASSIGN.
7422 <string_opt>: New field.
7423 (test_options_opts::~test_options_opts): New.
7424 (test_options_opts::dump): Also dump "-string".
7425 (test_options_option_defs): Install "string.
7426
7427 2019-07-03 Pedro Alves <palves@redhat.com>
7428
7429 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7430 option_value with a null enumeration.
7431 (complete_options): Save the option values in the context.
7432 (save_option_value_in_ctx): New, factored out from ...
7433 (process_options): ... here.
7434 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7435 of the function.
7436 * maint-test-options.c (test_options_opts::dump): New, factored
7437 out from ...
7438 (maintenance_test_options_command_mode): ... here.
7439 (maintenance_test_options_command_completion_result): Delete.
7440 (maintenance_test_options_command_completion_text): Update
7441 comment.
7442 (maintenance_show_test_options_completion_result): Change
7443 prototype. Just print
7444 maintenance_test_options_command_completion_text.
7445 (save_completion_result): New.
7446 (maintenance_test_options_completer_mode): Pass options context to
7447 complete_options, and then save a dump.
7448 (_initialize_maint_test_options): Use add_cmd to install "maint
7449 show test-options-completion-result".
7450
7451 2019-07-03 Pedro Alves <palves@redhat.com>
7452
7453 * NEWS (New commands): Mention "with" and "maint with".
7454 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7455 (with_command, with_command_completer): New.
7456 (pipe_command): Adjust to new repeat_previous
7457 interface.
7458 (_initialize_cli_cmds): Install the "with" command and its "w"
7459 alias.
7460 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7461 declarations.
7462 * cli/cli-setshow.c (parse_cli_var_uinteger)
7463 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7464 argument strings for all var_types.
7465 (get_setshow_command_value_string): New, factored out from ...
7466 (do_show_command): ... this.
7467 * cli/cli-setshow.h: Include <string>.
7468 (get_setshow_command_value_string): Declare.
7469 * command.h (repeat_previous): Now returns const char *. Adjust
7470 comment.
7471 * maint.c: Include "cli/cli-cmds.h".
7472 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7473 (_initialize_maint_cmds): Register the "maintenance with" command.
7474 * top.c (repeat_previous): Move bits from pipe_command here:
7475 Return the saved command line, if any; error out if there's no
7476 command to relaunch.
7477
7478 2019-07-03 Pedro Alves <palves@redhat.com>
7479
7480 * NEWS (New commands): Mention "maint set/show test-settings"
7481 instead of "maint test-settings".
7482 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7483 (maintenance_test_settings_set_list): Rename to ...
7484 (maintenance_set_test_settings_list): ... this.
7485 (maintenance_test_settings_show_list): Rename to ...
7486 (maintenance_show_test_settings_list): ... this.
7487 (maintenance_test_settings_cmd): Delete.
7488 (maintenance_test_settings_set_cmd): ...
7489 (maintenance_set_test_settings_cmd): ... this.
7490 (maintenance_test_settings_show_cmd): ...
7491 (maintenance_show_test_settings_cmd): ... this.
7492 (maintenance_test_settings_show_value_cmd):
7493 (maintenance_show_test_settings_value_cmd): ... this.
7494 (_initialize_maint_test_settings): No longer install the "maint
7495 test-settings" prefix command. Rename "maint test-settings set"
7496 to "maint set test-settings", and "maint test-settings show" to
7497 "maint show test-settings". Adjust all subcommands.
7498
7499 2019-07-03 Pedro Alves <palves@redhat.com>
7500
7501 * maint-test-settings.c: Fix file's intro comment. Replace all
7502 references to "test-options" with references to "test-settings",
7503 in comments.
7504
7505 2019-07-03 Pedro Alves <palves@redhat.com>
7506
7507 * maint-test-settings.c (maintenance_test_settings_xxx)
7508 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7509 New.
7510 (maintenance_test_settings_enums): Use them.
7511 (maintenance_test_settings_enum): Default to
7512 maintenance_test_settings_xxx.
7513 (_initialize_maint_test_settings): Initialize
7514 MAINTENANCE_TEST_SETTINGS_FILENAME.
7515
7516 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7517
7518 * breakpoint.h (remove_breakpoints_inf): Change return type to
7519 void, move function documentation here.
7520 * breakpoint.c (remove_breakpoints_inf): Change return type to
7521 void, move function documentation to header.
7522
7523 2019-07-02 Pedro Alves <palves@redhat.com>
7524
7525 * NEWS (Completion improvements): Mention "info threads".
7526 * thread.c (struct info_threads_opts, info_threads_option_defs)
7527 (make_info_threads_options_def_group): New.
7528 (info_threads_command): Use gdb::option::process_options.
7529 (info_threads_command_completer): New.
7530 (_initialize_thread): Use gdb::option::build_help to build the
7531 help text for "info threads".
7532
7533 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7534
7535 * defs.h (generic_load): Move from here...
7536 * symfile.h (generic_load): ... to here. Rename name parameter
7537 to args.
7538 * symfile.c (generic_load): Add comment.
7539
7540 2019-07-01 Tom Tromey <tromey@adacore.com>
7541
7542 * dwarf2read.c
7543 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7544 declaration of without_params. Fix formatting.
7545
7546 2019-07-01 Tom Tromey <tromey@adacore.com>
7547
7548 * ada-exp.y (find_primitive_type): Update.
7549 * ada-lang.h (ada_lookup_symbol): Update.
7550 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7551 parameter.
7552 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7553
7554 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7555
7556 PR breakpoints/24541
7557 * gdbarch.c: Regenerate.
7558 * gdbarch.h: Regenerate.
7559 * gdbarch.sh: Add 'stap_adjust_register'.
7560 * i386-tdep.c: Include '<unordered_set>'.
7561 (i386_stap_adjust_register): New function.
7562 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7563 * stap-probe.c (stap_parse_register_operand): Call
7564 'gdbarch_stap_adjust_register'.
7565
7566 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7567
7568 PR python/24742
7569 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7570 * python/python.c (do_start_initialization): Use 'xmalloc'
7571 instead of 'PyMem_Malloc'.
7572
7573 2019-06-28 Tom Tromey <tromey@adacore.com>
7574
7575 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7576 for Ada.
7577
7578 2019-06-27 Tom Tromey <tromey@adacore.com>
7579
7580 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7581 objfile_key.
7582 (arm_find_mapping_symbol, arm_record_special_symbol)
7583 (_initialize_arm_tdep): Update.
7584 (arm_objfile_data_free): Remove.
7585
7586 2019-06-27 Tom Tromey <tromey@adacore.com>
7587
7588 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7589 to cp_print_static_field.
7590
7591 2019-06-26 Tom Tromey <tromey@adacore.com>
7592
7593 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7594 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7595 declare.
7596
7597 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7598
7599 * features/aarch64-core.c (create_feature_aarch64_core):
7600 Regenerate.
7601 * features/aarch64-core.xml: Add cpsr flags.
7602
7603 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7604
7605 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7606 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7607
7608 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7609
7610 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7611 field.
7612 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7613 use.
7614 (arm_record_special_symbol): Don't insert new symbol in sorted
7615 position, push it at the end.
7616
7617 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7618
7619 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7620 (arm_mapping_symbol_s): Remove.
7621 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7622 (arm_mapping_symbol_vec): New typedef.
7623 (struct arm_per_objfile): Add constructor.
7624 <section_maps>: Change type to
7625 std::unique_ptr<arm_mapping_symbol_vec[]>.
7626 (arm_compare_mapping_symbols): Remove.
7627 (arm_find_mapping_symbol): Adjust to section_maps type change.
7628 (arm_objfile_data_free): Call delete on arm_per_objfile.
7629 (arm_record_special_symbol): Adjust to section_maps type change.
7630 Allocate arm_per_objfile with new.
7631
7632 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7633
7634 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7635 with the command prefix.
7636
7637 2019-06-25 Tom Tromey <tom@tromey.com>
7638
7639 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7640 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7641
7642 2019-06-25 Tom Tromey <tom@tromey.com>
7643
7644 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7645 type.
7646 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7647 protected.
7648
7649 2019-06-25 Tom Tromey <tom@tromey.com>
7650
7651 * tui/tui-winsource.c
7652 (tui_source_window_base::set_is_exec_point_at): Add check against
7653 LOA_ADDRESS.
7654
7655 2019-06-25 Tom Tromey <tom@tromey.com>
7656
7657 * tui/tui-source.c (tui_set_source_content): Don't check before
7658 xfree.
7659 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7660
7661 2019-06-25 Tom Tromey <tom@tromey.com>
7662
7663 * tui/tui-winsource.h (tui_update_source_window_as_is)
7664 (tui_alloc_source_buffer, tui_line_is_displayed)
7665 (tui_addr_is_displayed): Change type of win_info.
7666 * tui/tui-winsource.c (tui_update_source_window_as_is)
7667 (tui_clear_source_content, tui_show_source_line)
7668 (tui_show_source_content, tui_source_window_base::refill)
7669 (tui_source_window_base::set_is_exec_point_at)
7670 (tui_source_window_base::set_is_exec_point_at)
7671 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7672 (tui_alloc_source_buffer, tui_line_is_displayed)
7673 (tui_addr_is_displayed): Change type of win_info. Update.
7674 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7675 (tui_source_window_base::do_make_visible_with_new_height):
7676 Update.
7677 * tui/tui-source.c (tui_set_source_content)
7678 (tui_set_source_content_nil)
7679 (tui_source_window::do_scroll_vertical): Update.
7680 * tui/tui-layout.c (show_layout): Update.
7681 * tui/tui-disasm.c (tui_set_disassem_content)
7682 (tui_disasm_window::do_scroll_vertical): Update.
7683 * tui/tui-data.h (tui_win_content): Remove.
7684 (struct tui_gen_win_info) <content, content_size>: Remove.
7685 (struct tui_source_element): Add initializers and destructor.
7686 (union tui_which_element, struct tui_win_element): Remove.
7687 (struct tui_source_window_base) <content>: New field.
7688 (struct tui_data_window): Remove destructor.
7689 (tui_alloc_content, tui_free_win_content)
7690 (tui_free_all_source_wins_content): Don't declare.
7691 * tui/tui-data.c (tui_initialize_static_data): Update.
7692 (init_content_element, tui_alloc_content): Remove.
7693 (~tui_gen_win_info): Update.
7694 (~tui_data_window, tui_free_all_source_wins_content)
7695 (tui_free_win_content, free_content, free_content_elements):
7696 Remove.
7697
7698 2019-06-25 Tom Tromey <tom@tromey.com>
7699
7700 * tui/tui-winsource.h (tui_clear_source_content)
7701 (tui_erase_source_content, tui_show_source_content): Change type
7702 of win_info.
7703 * tui/tui-winsource.c (tui_clear_source_content)
7704 (tui_erase_source_content, tui_show_source_content): Change type
7705 of win_info.
7706 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7707 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7708 win_info.
7709 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7710 win_info.
7711 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7712
7713 2019-06-25 Tom Tromey <tom@tromey.com>
7714
7715 * tui/tui-winsource.c (tui_clear_source_content)
7716 (tui_source_window_base::set_is_exec_point_at): Update.
7717 * tui/tui-source.c (tui_set_source_content_nil): Update.
7718 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7719 a bool.
7720 * tui/tui-data.c (init_content_element): Update.
7721
7722 2019-06-25 Tom Tromey <tom@tromey.com>
7723
7724 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7725 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7726 * tui/tui-layout.c (init_and_make_win): Update.
7727 * tui/tui.h (enum tui_win_type): Update.
7728 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7729 tui_win_is_auxillary.
7730 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7731 tui_win_is_auxillary.
7732
7733 2019-06-25 Tom Tromey <tom@tromey.com>
7734
7735 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7736 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7737 (tui_delete_data_content_windows, tui_display_all_data)
7738 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7739 Update.
7740 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7741 * tui/tui-regs.c (tui_last_regs_line_no)
7742 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7743 (tui_show_registers): Update.
7744 (tui_show_register_group): Return void. Update.
7745 (tui_display_registers_from, tui_display_reg_element_at_line)
7746 (tui_display_registers_from_line, tui_check_register_values):
7747 Update.
7748 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7749 member.
7750 (struct tui_data_window) <regs_content>: Now a std::vector.
7751 <regs_content_count>: Remove.
7752 (tui_add_content_elements, tui_free_data_content): Don't declare.
7753 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7754 (init_content_element): Remove DATA_WIN case. Add assert.
7755 (tui_add_content_elements): Remove.
7756 (tui_data_window): Update.
7757 (tui_free_data_content): Remove.
7758 (free_content_elements): Remove DATA_WIN case.
7759
7760 2019-06-25 Tom Tromey <tom@tromey.com>
7761
7762 * tui/tui-data.c (tui_data_item_window): Update.
7763 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7764 * tui/tui-windata.c (tui_display_all_data)
7765 (tui_display_data_from_line): Update.
7766 (tui_check_data_values): Remove.
7767 * tui/tui-regs.c (tui_show_register_group)
7768 (tui_display_reg_element_at_line): Update.
7769 * tui/tui-hooks.c (tui_register_changed)
7770 (tui_refresh_frame_and_register_information): Call
7771 tui_check_register_values.
7772 * tui/tui-data.h (struct tui_data_window) <data_content,
7773 data_content_count, data_type>: Remove.
7774 (enum tui_data_type): Remove.
7775
7776 * tui/tui-data.c (tui_data_window::clear_detail)
7777 (~tui_data_window): Update.
7778
7779 2019-06-25 Tom Tromey <tom@tromey.com>
7780
7781 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7782 declare.
7783 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7784 Rename from tui_first_data_item_displayed. Update.
7785 (tui_data_window::refresh_all)
7786 (tui_data_window::do_scroll_vertical): Update.
7787 * tui/tui-data.h (struct tui_data_window)
7788 <first_data_item_displayed>: Declare new method.
7789
7790 2019-06-25 Tom Tromey <tom@tromey.com>
7791
7792 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7793 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7794 contents...
7795 (tui_initialize_static_data): ...here.
7796
7797 2019-06-25 Tom Tromey <tom@tromey.com>
7798
7799 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7800 (tui_display_registers_from, tui_check_register_values): Update.
7801 (tui_display_register): Remove win_info parameter; update.
7802 (tui_get_register): Change type of parameters.
7803 * tui/tui-data.h (struct tui_data_element): Remove.
7804 (union tui_which_element) <data>: Remove.
7805 <data_window>: Change type.
7806 (struct tui_data_item_window): New.
7807 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7808 case. Add assert.
7809 (~tui_data_item_window): New destructor.
7810 (free_content_elements): Remove DATA_ITEM_WIN case.
7811
7812 2019-06-25 Tom Tromey <tom@tromey.com>
7813
7814 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7815 Remove.
7816
7817 2019-06-25 Tom Tromey <tom@tromey.com>
7818
7819 * tui/tui-data.h (struct tui_command_element): Remove.
7820 (union tui_which_element) <command>: Remove.
7821 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7822 assert.
7823 (free_content_elements): Remove CMD_WIN case.
7824
7825 2019-06-25 Tom Tromey <tom@tromey.com>
7826
7827 * tui/tui-layout.c (tui_set_layout): Update.
7828 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7829 * tui/tui-data.c (layout_def): Update.
7830
7831 2019-06-25 Tom Tromey <tom@tromey.com>
7832
7833 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7834 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7835 (tui_source_window_base::set_new_height): Update.
7836 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7837 Update.
7838 (tui_set_locator_fullname, tui_set_locator_info)
7839 (tui_show_frame_info): Update.
7840 * tui/tui-source.c (tui_set_source_content)
7841 (tui_source_is_displayed): Update.
7842 * tui/tui-layout.c (show_source_disasm_command, show_data)
7843 (show_source_or_disasm_and_command): Update.
7844 * tui/tui-disasm.c (tui_set_disassem_content)
7845 (tui_get_begin_asm_address): Update.
7846 * tui/tui-data.h (struct tui_locator_element): Remove.
7847 (union tui_which_element) <locator>: Remove.
7848 (struct tui_locator_window): New.
7849 (tui_locator_win_info_ptr): Change return type.
7850 * tui/tui-data.c (_locator): Change type.
7851 (tui_locator_win_info_ptr): Change return type.
7852 (init_content_element): Remove LOCATOR_WIN case. Add assert.
7853 (tui_alloc_content): Add assert.
7854
7855 2019-06-25 Tom Tromey <tom@tromey.com>
7856
7857 * tui/tui-winsource.c
7858 (tui_exec_info_window::maybe_allocate_content): New method.
7859 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7860 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7861 (make_source_or_disasm_window): Add cast.
7862 * tui/tui-data.h (union tui_which_element) <simple_string>:
7863 Remove.
7864 (struct tui_source_info): New.
7865 (struct tui_source_window_base) <execution_info>: Change type.
7866 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7867 case, and add assert.
7868 (tui_alloc_content): Add assert.
7869
7870 2019-06-25 Tom Tromey <tom@tromey.com>
7871
7872 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7873 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7874 * tui/tui-data.c (tui_alloc_win_info): Remove.
7875
7876 2019-06-25 Tom Tromey <tom@tromey.com>
7877
7878 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7879 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7880 can_highlight.
7881
7882 2019-06-25 Tom Tromey <tom@tromey.com>
7883
7884 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7885 make_visible_with_new_height method.
7886 (tui_win_info::make_visible_with_new_height): New method.
7887 (tui_source_window_base::do_make_visible_with_new_height)
7888 (tui_data_window::do_make_visible_with_new_height)
7889 (tui_cmd_window::do_make_visible_with_new_height): New methods.
7890 (make_visible_with_new_height): Remove.
7891 (tui_resize_all, tui_adjust_win_heights): Use
7892 make_visible_with_new_height method.
7893 * tui/tui-data.h (struct tui_win_info)
7894 <do_make_visible_with_new_height, make_visible_with_new_height>:
7895 New methods.
7896 (struct tui_source_window_base, struct tui_data_window)
7897 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7898 methods.
7899
7900 2019-06-25 Tom Tromey <tom@tromey.com>
7901
7902 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7903 method.
7904 (update_tab_width): Call update_tab_width method.
7905 * tui/tui-data.h (struct tui_win_info)
7906 (struct tui_source_window_base) <update_tab_width>: New methods.
7907
7908 2019-06-25 Tom Tromey <tom@tromey.com>
7909
7910 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7911 parameter.
7912 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7913 parameter.
7914 (tui_gen_win_info::make_visible): Update.
7915 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7916 parameter.
7917 * tui/tui-data.h (enum tui_box): New enum.
7918 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7919
7920 2019-06-25 Tom Tromey <tom@tromey.com>
7921
7922 * tui/tui-layout.c (make_source_or_disasm_window): Always use
7923 init_and_make_win for EXEC_INFO_WIN.
7924 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7925 longer inline.
7926 (struct tui_win_info) <~tui_win_info>: Inline.
7927 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7928 Don't declare.
7929 * tui/tui-data.c (source_win, disasm_win): Remove globals.
7930 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7931 Remove.
7932 (tui_initialize_static_data): Update.
7933 (~tui_gen_win_info): Handle more cleanup here.
7934 (~tui_source_window_base): Delete "execution_info".
7935 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7936
7937 2019-06-25 Tom Tromey <tom@tromey.com>
7938
7939 * tui/tui-layout.c (make_command_window): Don't set
7940 can_highlight.
7941 (show_source_disasm_command): Call the reset method.
7942 (show_data): Don't set can_highlight. Call the reset method.
7943 (tui_gen_win_info::reset): Rename from init_gen_win_info
7944 (init_and_make_win): Simplify. Return tui_gen_win_info.
7945 (show_source_or_disasm_and_command): Call the reset method.
7946 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7947 (struct tui_cmd_window): Set can_highlight.
7948
7949 2019-06-25 Tom Tromey <tom@tromey.com>
7950
7951 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7952 from make_visible.
7953 (tui_make_visible, tui_make_invisible): Rewrite.
7954 (tui_win_info::make_visible): Remove.
7955 (tui_source_window_base::make_visible): Update.
7956 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7957 method. Moved from...
7958 (struct tui_win_info) <make_visible>: ...here.
7959
7960 2019-06-25 Tom Tromey <tom@tromey.com>
7961
7962 * tui/tui-winsource.c
7963 (tui_source_window_base::do_scroll_horizontal): Remove direction
7964 parameter.
7965 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7966 direction parameter.
7967 * tui/tui-win.c (tui_win_info::forward_scroll)
7968 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7969 (tui_win_info::right_scroll): Update.
7970 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7971 direction parameter.
7972 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7973 direction parameter.
7974 * tui/tui-data.h (enum tui_scroll_direction): Remove.
7975 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7976 Remove direction parameter.
7977 (struct tui_source_window_base, struct tui_source_window)
7978 (struct tui_disasm_window, struct tui_data_window)
7979 (struct tui_cmd_window): Update.
7980
7981 2019-06-25 Tom Tromey <tom@tromey.com>
7982
7983 * tui/tui-winsource.h (tui_set_exec_info_content)
7984 (tui_show_exec_info_content, tui_erase_exec_info_content)
7985 (tui_clear_exec_info_content, tui_update_exec_info): Change
7986 argument to tui_source_window_base.
7987 * tui/tui-winsource.c (tui_set_exec_info_content)
7988 (tui_show_exec_info_content, tui_erase_exec_info_content)
7989 (tui_clear_exec_info_content, tui_update_exec_info): Change
7990 argument to tui_source_window_base.
7991
7992 2019-06-25 Tom Tromey <tom@tromey.com>
7993
7994 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7995 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7996
7997 2019-06-25 Tom Tromey <tom@tromey.com>
7998
7999 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8000 check.
8001
8002 2019-06-25 Tom Tromey <tom@tromey.com>
8003
8004 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8005 type to void.
8006 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8007 type to void.
8008 * tui/tui-source.c (tui_set_source_content): Update.
8009 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8010
8011 2019-06-25 Tom Tromey <tom@tromey.com>
8012
8013 * tui/tui-win.c (window_name_completer, tui_set_focus)
8014 (tui_all_windows_info): Use name method.
8015 * tui/tui-data.h (struct tui_gen_win_info)
8016 (struct tui_source_window, struct tui_disasm_window)
8017 (struct tui_data_window, struct tui_cmd_window) <name>: New
8018 method.
8019 (tui_win_name): Don't declare.
8020 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8021 (tui_win_name): Remove.
8022
8023 2019-06-25 Tom Tromey <tom@tromey.com>
8024
8025 * tui/tui-winsource.h (tui_update_source_window)
8026 (tui_update_source_window_as_is): Change parameter type.
8027 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8028 to be a tui_source_window_base.
8029 (tui_update_source_window_as_is): Likewise.
8030 * tui/tui-win.c (make_visible_with_new_height): Update.
8031
8032 2019-06-25 Tom Tromey <tom@tromey.com>
8033
8034 * tui/tui-winsource.c (tui_erase_source_content)
8035 (tui_show_source_content, tui_show_exec_info_content)
8036 (tui_erase_exec_info_content): Use refresh_window method.
8037 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8038 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8039 from tui_refresh_win.
8040 (tui_data_window::refresh_window): New method.
8041 (tui_win_info::refresh, tui_source_window_base::refresh)
8042 (tui_refresh_all): Use refresh_window method.
8043 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8044 method.
8045 * tui/tui-regs.c (tui_display_register): Call refresh_window
8046 method.
8047 * tui/tui-layout.c (show_source_disasm_command)
8048 (show_source_or_disasm_and_command): Call refresh_window method.
8049 * tui/tui-data.h (struct tui_gen_win_info)
8050 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8051 New method.
8052
8053 2019-06-25 Tom Tromey <tom@tromey.com>
8054
8055 * tui/tui.c (tui_rl_other_window, tui_enable)
8056 (tui_is_window_visible, tui_get_command_dimension): Update.
8057 * tui/tui-winsource.c (tui_update_source_window_as_is)
8058 (tui_clear_source_content, tui_erase_source_content)
8059 (tui_show_source_line, tui_source_window_base::refill)
8060 (tui_source_window_base::do_scroll_horizontal)
8061 (tui_source_window_base::set_is_exec_point_at)
8062 (tui_update_breakpoint_info, tui_set_exec_info_content)
8063 (tui_alloc_source_buffer, tui_line_is_displayed)
8064 (tui_addr_is_displayed): Update.
8065 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8066 (tui_check_and_display_highlight_if_needed)
8067 (tui_win_info::make_visible, tui_win_info::refresh)
8068 (tui_refresh_all): Update.
8069 * tui/tui-windata.c (tui_first_data_item_displayed)
8070 (tui_delete_data_content_windows, tui_erase_data_content)
8071 (tui_display_all_data, tui_data_window::refresh_all)
8072 (tui_check_data_values): Update.
8073 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8074 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8075 (tui_win_info::backward_scroll, tui_refresh_all_win)
8076 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8077 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8078 (tui_source_window_base::set_new_height)
8079 (tui_data_window::set_new_height)
8080 (make_invisible_and_set_new_height)
8081 (make_visible_with_new_height, new_height_ok)
8082 (parse_scrolling_args): Update.
8083 * tui/tui-stack.c (tui_show_frame_info): Update.
8084 * tui/tui-source.c (tui_set_source_content)
8085 (tui_set_source_content_nil, tui_source_is_displayed)
8086 (tui_source_window::do_scroll_vertical): Update.
8087 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8088 (tui_display_registers_from, tui_display_reg_element_at_line)
8089 (tui_check_register_values, tui_reg_command): Update.
8090 * tui/tui-layout.c (tui_default_win_height)
8091 (show_source_disasm_command, show_data, init_and_make_win)
8092 (show_source_or_disasm_and_command): Update.
8093 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8094 (tui_redisplay_readline, tui_mld_flush)
8095 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8096 (tui_getc): Update.
8097 * tui/tui-disasm.c (tui_set_disassem_content)
8098 (tui_disasm_window::do_scroll_vertical): Update.
8099 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8100 Now virtual.
8101 (struct tui_win_info): Derive from tui_gen_win_info.
8102 <~tui_win_info>: Mark as override.
8103 <generic>: Remove member.
8104 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8105 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8106 (~tui_data_window, ~tui_win_info)
8107 (tui_free_all_source_wins_content): Update.
8108 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8109
8110 2019-06-25 Tom Tromey <tom@tromey.com>
8111
8112 * tui/tui-layout.c (init_and_make_win): Use new.
8113 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8114 destructor, initializers.
8115 (tui_alloc_generic_win_info): Don't declare.
8116 * tui/tui-data.c (_locator): Add argument to constructor.
8117 (source_win, disasm_win): New globals.
8118 (exec_info): Remove.
8119 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8120 Update.
8121 (tui_alloc_generic_win_info): Remove.
8122 (init_content_element): Use new.
8123 (tui_win_info::tui_win_info): Update.
8124 (free_content_elements) <case DATA_WIN>: Use delete.
8125
8126 2019-06-25 Tom Tromey <tom@tromey.com>
8127
8128 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8129 * tui/tui-windata.c (tui_first_data_item_displayed)
8130 (tui_delete_data_content_windows): Update.
8131 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8132 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8133 (tui_display_registers_from, tui_check_register_values): Update.
8134 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8135 pointer.
8136 * tui/tui-data.c (init_content_element): Update. Allocate the new
8137 window.
8138 (tui_free_data_content): Update.
8139 (free_content_elements) <case DATA_WIN>: Free the window.
8140
8141 2019-06-25 Tom Tromey <tom@tromey.com>
8142
8143 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8144 Update.
8145 * tui/tui-layout.c (make_command_window)
8146 (show_source_disasm_command, show_data, init_and_make_win)
8147 (show_source_or_disasm_and_command): Update.
8148 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8149 method.
8150 <can_highight, is_highlighted>: Now bool.
8151 (tui_set_win_highlight): Don't declare.
8152 * tui/tui-data.c (tui_set_win_highlight): Remove.
8153
8154 2019-06-25 Tom Tromey <tom@tromey.com>
8155
8156 * tui/tui-wingeneral.c (make_visible): Remove check of window
8157 type.
8158
8159 2019-06-25 Tom Tromey <tom@tromey.com>
8160
8161 * tui/tui-win.c (tui_win_info::max_height)
8162 (tui_cmd_window::max_height): New methods.
8163 (new_height_ok): Call max_height.
8164 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8165 <max_height>: New method.
8166
8167 2019-06-25 Tom Tromey <tom@tromey.com>
8168
8169 * tui/tui-win.c (tui_source_window_base::set_new_height)
8170 (tui_data_window::set_new_height): New methods.
8171 (make_invisible_and_set_new_height): Call set_new_height method.
8172 * tui/tui-data.h (struct tui_win_info)
8173 (struct tui_source_window_base, struct tui_data_window)
8174 <set_new_height>: New method.
8175
8176 2019-06-25 Tom Tromey <tom@tromey.com>
8177
8178 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8179 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8180 tui_refresh_data_win.
8181 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8182 method.
8183 (tui_refresh_all_win): Call the refresh_all method.
8184 (tui_set_focus): Likewise.
8185 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8186 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8187 Likewise.
8188
8189 2019-06-25 Tom Tromey <tom@tromey.com>
8190
8191 * tui/tui-winsource.h (tui_refill_source_window)
8192 (tui_set_is_exec_point_at): Don't declare.
8193 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8194 (tui_source_window_base::refill): Rename from
8195 tui_refill_source_window.
8196 (tui_source_window_base::do_scroll_horizontal): Update.
8197 (tui_source_window_base::set_is_exec_point_at): Rename from
8198 tui_set_is_exec_point_at.
8199 (tui_update_all_breakpoint_info): Update.
8200 * tui/tui-stack.c (tui_show_frame_info): Update.
8201 * tui/tui-layout.c (show_data): Add cast.
8202 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8203 * tui/tui-data.h (struct tui_source_window_base) <refill,
8204 set_is_exec_point_at>: New methods.
8205 (tui_source_windows, tui_add_to_source_windows): Update types.
8206 (tui_add_to_source_windows): Remove redundant declaration.
8207 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8208 (tui_source_windows): Change return type.
8209 (tui_clear_source_windows_detail): Update.
8210 (tui_add_to_source_windows): Change type of parameter.
8211 (tui_free_all_source_wins_content): Update.
8212
8213 2019-06-25 Tom Tromey <tom@tromey.com>
8214
8215 * tui/tui-wingeneral.c (tui_win_info::refresh)
8216 (tui_source_window_base::refresh): New methods.
8217 (tui_refresh_all): Call the refresh method.
8218 * tui/tui-data.h (struct tui_win_info)
8219 (struct tui_source_window_base) <refresh>: New method.
8220
8221 2019-06-25 Tom Tromey <tom@tromey.com>
8222
8223 * tui/tui.h (tui_is_window_visible): Return bool.
8224 * tui/tui.c (tui_is_window_visible): Return bool.
8225 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8226 (tui_make_visible, tui_make_invisible)
8227 (tui_win_info::make_visible)
8228 (tui_source_window_base::make_visible, make_all_visible)
8229 (tui_make_all_visible, tui_make_all_invisible): Update.
8230 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8231 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8232 bool.
8233 (struct tui_win_info, struct tui_source_window_base)
8234 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8235 * tui/tui-data.c (tui_init_generic_part): Update.
8236
8237 2019-06-25 Tom Tromey <tom@tromey.com>
8238
8239 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8240 (tui_source_window_base::make_visible): New methods.
8241 (make_all_visible): Make method call.
8242 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8243 (struct tui_source_window_base, struct tui_cmd_window): Override
8244 make_visible.
8245 (tui_win_is_source_type): Don't declare.
8246 * tui/tui-data.c (tui_win_is_source_type): Remove.
8247
8248 2019-06-25 Tom Tromey <tom@tromey.com>
8249
8250 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8251 NULL check.
8252
8253 2019-06-25 Tom Tromey <tom@tromey.com>
8254
8255 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8256 Inline constructor. Add initializers for members.
8257 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8258 constructors; now inline in class.
8259
8260 2019-06-25 Tom Tromey <tom@tromey.com>
8261
8262 * tui/tui-regs.c (tui_show_registers): Update.
8263 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8264 bool.
8265 * tui/tui-data.c (tui_data_window::clear_detail)
8266 (tui_data_window): Update.
8267
8268 2019-06-25 Tom Tromey <tom@tromey.com>
8269
8270 * tui/tui-windata.c (tui_display_all_data)
8271 (tui_display_data_from_line, tui_display_data_from)
8272 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8273 Update.
8274 * tui/tui-regs.c (tui_last_regs_line_no)
8275 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8276 (tui_show_registers, tui_show_register_group)
8277 (tui_display_registers_from, tui_display_reg_element_at_line)
8278 (tui_display_registers_from_line, tui_check_register_values)
8279 (tui_reg_next, tui_reg_prev): Update.
8280 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8281 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8282 tui_data_window.
8283 (struct tui_win_info) <detail>: Remove. Add new fields from
8284 tui_data_info.
8285 (TUI_DATA_WIN): Add cast.
8286 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8287 (~tui_data_window): Simplify.
8288
8289 2019-06-25 Tom Tromey <tom@tromey.com>
8290
8291 * tui/tui-layout.c (show_source_disasm_command)
8292 (show_source_or_disasm_and_command): Update.
8293 * tui/tui-io.c (update_cmdwin_start_line)
8294 (tui_redisplay_readline): Update.
8295 * tui/tui-data.h (struct tui_command_info): Remove.
8296 (struct tui_win_info) <detail>: Remove command_info member.
8297 (struct tui_data_window) <start_line>: New member, from
8298 tui_command_info.
8299 (TUI_CMD_WIN): Add casts.
8300
8301 2019-06-25 Tom Tromey <tom@tromey.com>
8302
8303 * tui/tui-winsource.c (tui_update_source_window)
8304 (tui_refill_source_window)
8305 (tui_source_window_base::do_scroll_horizontal)
8306 (tui_update_breakpoint_info, tui_set_exec_info_content)
8307 (tui_show_exec_info_content, tui_erase_exec_info_content)
8308 (tui_clear_exec_info_content): Update.
8309 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8310 Update.
8311 * tui/tui-win.c (make_invisible_and_set_new_height)
8312 (make_visible_with_new_height): Update.
8313 * tui/tui-source.c (tui_set_source_content)
8314 (tui_show_symtab_source): Update.
8315 * tui/tui-layout.c (extract_display_start_addr)
8316 (show_source_disasm_command, show_data)
8317 (make_source_or_disasm_window)
8318 (show_source_or_disasm_and_command): Update.
8319 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8320 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8321 "gdbarch".
8322 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8323 to tui_source_window_base.
8324 (struct tui_win_info) <detail>: Remove source_info member.
8325 (struct tui_source_window_base) <has_locator>: Inline.
8326 Move contents from tui_source_info; rename has_locator member to
8327 m_has_locator.
8328 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8329 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8330 header file.
8331 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8332 Simplify.
8333 (tui_free_all_source_wins_content): Cast to
8334 tui_source_window_base.
8335
8336 2019-06-25 Tom Tromey <tom@tromey.com>
8337
8338 * tui/tui-win.c (make_invisible_and_set_new_height)
8339 (make_visible_with_new_height): Call has_locator method.
8340 * tui/tui-layout.c (show_source_disasm_command, show_data)
8341 (show_source_or_disasm_and_command): Update for bool change.
8342 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8343 (tui_win_info) <has_locator>: New method.
8344 (struct tui_source_window_base) <has_locator>: New method.
8345 (tui_win_has_locator): Don't declare.
8346 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8347 from tui_win_has_locator.
8348 (tui_source_window_base): Use false, not FALSE.
8349
8350 2019-06-25 Tom Tromey <tom@tromey.com>
8351
8352 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8353 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8354 clear_detail method directly.
8355 (tui_clear_win_detail): Remove.
8356
8357 2019-06-25 Tom Tromey <tom@tromey.com>
8358
8359 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8360 "this", not TUI_DISASM_WIN.
8361
8362 2019-06-25 Tom Tromey <tom@tromey.com>
8363
8364 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8365 declare.
8366 * tui/tui-winsource.c
8367 (tui_source_window_base::do_scroll_horizontal): Rename from
8368 tui_horizontal_source_scroll.
8369 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8370 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8371 from tui_vertical_data_scroll.
8372 * tui/tui-win.h (tui_scroll): Don't declare.
8373 * tui/tui-win.c (tui_win_info::forward_scroll)
8374 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8375 (tui_win_info::right_scroll): Rename and update.
8376 (tui_scroll_forward_command, tui_scroll_backward_command)
8377 (tui_scroll_left_command, tui_scroll_right_command): Update.
8378 (tui_scroll): Remove.
8379 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8380 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8381 from tui_vertical_source_scroll.
8382 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8383 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8384 from tui_vertical_disassem_scroll.
8385 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8386 do_scroll_horizontal>: New methods.
8387 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8388 Likewise.
8389 (struct tui_source_window_base): Add do_scroll_horizontal.
8390 (struct tui_source_window, struct tui_disasm_window): Add
8391 do_scroll_vertical.
8392 (struct tui_data_window, struct tui_cmd_window): Add
8393 do_scroll_horizontal and do_scroll_vertical.
8394 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8395
8396 2019-06-25 Tom Tromey <tom@tromey.com>
8397
8398 * tui/tui-data.h (struct tui_source_window_base): New struct.
8399 (struct tui_source_window): Derive from tui_source_window_base.
8400 (struct tui_disasm_window): New struct.
8401 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8402 from tui_source_window::clear_detail.
8403 (tui_source_window_base): Rename from tui_source_window.
8404 (~tui_source_window_base): Rename from ~tui_source_window.
8405 (tui_alloc_win_info): Create a tui_disasm_window.
8406
8407 2019-06-25 Tom Tromey <tom@tromey.com>
8408
8409 * tui/tui-data.h (struct tui_source_window)
8410 (struct tui_data_window): Declare destructors.
8411 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8412 destructors.
8413 (tui_win_info): Simplify.
8414
8415 2019-06-25 Tom Tromey <tom@tromey.com>
8416
8417 * tui/tui-winsource.c (tui_display_main)
8418 (tui_update_source_windows_with_addr)
8419 (tui_update_all_breakpoint_info): Update.
8420 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8421 (new_height_ok, parse_scrolling_args): Update.
8422 * tui/tui-stack.c (tui_show_frame_info): Update.
8423 * tui/tui-data.h (struct tui_list): Remove.
8424 (tui_source_windows): Return a reference to a std::vector.
8425 * tui/tui-data.c (source_windows): Now a std::vector.
8426 (tui_source_windows): Change return type.
8427 (tui_clear_source_windows): Rewrite.
8428 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8429 (tui_free_all_source_wins_content): Rewrite.
8430
8431 2019-06-25 Tom Tromey <tom@tromey.com>
8432
8433 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8434 (struct tui_data_window, struct tui_cmd_window): Declare
8435 clear_detail method.
8436 * tui/tui-data.c (tui_source_window::clear_detail)
8437 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8438 methods.
8439 (tui_clear_win_detail): Simplify.
8440
8441 2019-06-25 Tom Tromey <tom@tromey.com>
8442
8443 * tui/tui-layout.c (make_source_window, make_disasm_window)
8444 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8445 Return the new window.
8446 (show_source_disasm_command, show_data)
8447 (show_source_or_disasm_and_command): Update.
8448
8449 2019-06-25 Tom Tromey <tom@tromey.com>
8450
8451 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8452 parameter. Return the new window.
8453 (show_source_disasm_command): Update and remove NULL check.
8454 (show_source_or_disasm_and_command): Update.
8455
8456 2019-06-25 Tom Tromey <tom@tromey.com>
8457
8458 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8459
8460 2019-06-25 Tom Tromey <tom@tromey.com>
8461
8462 * tui/tui-data.h (struct tui_win_info): Make constructor
8463 protected. Make destructor virtual. Add initializers.
8464 (tui_source_window, tui_data_window, tui_cmd_window): New
8465 classes.
8466 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8467 constructor. Add "type" parameter.
8468 (tui_source_window, tui_data_window, tui_cmd_window): New
8469 constructors.
8470 (tui_alloc_win_info): Instantiate the appropriate subclass.
8471
8472 2019-06-25 Tom Tromey <tom@tromey.com>
8473
8474 * tui/tui-win.c (tui_resize_all): Use delete.
8475 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8476 destructor.
8477 (tui_free_window): Don't declare.
8478 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8479 Update.
8480
8481 2019-06-25 Tom Tromey <tom@tromey.com>
8482
8483 * tui/tui-data.h (struct tui_win_info): Add constructor.
8484 * tui/tui-data.c (tui_alloc_win_info): Use new.
8485 (tui_free_window): Use delete.
8486
8487 2019-06-22 Tom Tromey <tom@tromey.com>
8488
8489 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8490 declare.
8491 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8492
8493 2019-06-22 Tom Tromey <tom@tromey.com>
8494
8495 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8496 declare.
8497 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8498
8499 2019-06-22 Tom de Vries <tdevries@suse.de>
8500
8501 * dwarf2read.c (create_addrmap_from_aranges)
8502 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8503 instead of '%zu'.
8504
8505 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
8506
8507 * dwarf2read.h (dwarf2_section_info_def): Remove.
8508 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8509 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8510 std::vector<dwarf2_section_info>.
8511 (struct dwo_file) <~dwo_file>: Remove.
8512 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8513 types field.
8514 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8515 (dwarf2_read_debug_names): Likewise.
8516 (create_debug_types_hash_table): Change parameter type to
8517 array_view, adjust code accordingly.
8518 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8519 (partial_die_info::fixup): Likewise.
8520 (determine_prefix): Likewise.
8521 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8522
8523 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8524
8525 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8526 gdb_bfd_ref_ptr.
8527 <~dwo_file>: Remove call to gdb_bfd_unref.
8528 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8529 gdb_bfd_ref_ptr::get.
8530
8531 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8532
8533 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8534 type to htab_up.
8535 * dwarf2read.c (struct dwo_file): Initialize fields.
8536 <~dwo_file>: New.
8537 (free_dwo_file): Remove, move content to ~dwo_file.
8538 (struct dwo_file_deleter): Remove.
8539 (dwo_file_up>: Remove custom deleter.
8540 (free_dwo_files): Remove.
8541 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8542 dwo_files.
8543 (process_skeletonless_type_units): Call unique_ptr::get.
8544 (allocate_dwo_file_hash_table): Add deleter to created hash
8545 table. Change return type to htab_up.
8546 (lookup_dwo_file_slot): Don't memset dwo_file, call
8547 unique_ptr::get.
8548 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8549 (create_dwo_unit_in_dwp_v2): Likewise.
8550 (open_and_init_dwo_file): Likewise.
8551 (free_dwo_file_from_slot): Remove.
8552
8553 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8554
8555 * dwarf2read.h (struct dwarf2_section_info) <readin,
8556 is_virtual>: Change type to bool.
8557 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8558 true instead of 1.
8559
8560 2019-06-19 Tom Tromey <tom@tromey.com>
8561
8562 * tui/tui-data.h (tui_init_content_element): Don't declare.
8563
8564 2019-06-19 Tom Tromey <tom@tromey.com>
8565
8566 * tui/tui-data.h (tui_init_win_info): Don't declare.
8567
8568 2019-06-19 Tom de Vries <tdevries@suse.de>
8569
8570 * dwarf2read.h (abstract_to_concrete): Change type to
8571 std::unordered_map<sect_offset, std::vector<sect_offset>,
8572 gdb::hash_enum<sect_offset>>.
8573
8574 2019-06-19 Tom Tromey <tromey@adacore.com>
8575
8576 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8577 EVAL_AVOID_SIDE_EFFECTS specially.
8578
8579 2019-06-19 Tom Tromey <tromey@adacore.com>
8580
8581 * source-cache.c (highlighter): New global.
8582 (source_cache::get_source_lines): Create a highlighter on demand.
8583
8584 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8585
8586 * defs.h (deprecated_interactive_hook): Delete declaration.
8587 * interps.c (clear_interpreter_hooks): Remove use of
8588 deprecated_interactive_hook.
8589 * top.c (deprecated_interactive_hook): Delete definition.
8590 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8591
8592 2019-06-18 Tom de Vries <tdevries@suse.de>
8593
8594 PR gdb/24515
8595 * dwarf2read.h (abstract_to_concrete): Change type from
8596 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8597 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8598 * dwarf2read.c (read_variable): Update.
8599 (dwarf2_fetch_die_loc_sect_off): Update.
8600
8601 2019-06-17 Tom de Vries <tdevries@suse.de>
8602
8603 PR gdb/24617
8604 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8605 accessing parent[parent_len - 1].
8606
8607 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8608
8609 PR gdb/24364
8610 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8611 call dtrace_process_dof with NULL dof.
8612
8613 2019-06-16 Tom de Vries <tdevries@suse.de>
8614
8615 PR gdb/24445
8616 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8617
8618 2019-06-16 Tom Tromey <tom@tromey.com>
8619
8620 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8621 (make_all_visible): Use address of member.
8622
8623 2019-06-16 Tom Tromey <tom@tromey.com>
8624
8625 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8626 (tui_free_window, free_content, free_content_elements): Remove
8627 unnecessary cast.
8628 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8629 cast.
8630 * tui/tui-regs.c (tui_show_register_group)
8631 (tui_display_registers_from, tui_display_reg_element_at_line):
8632 Remove unnecessary cast.
8633
8634 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8635
8636 * linux-nat.c (normal_mask): Delete.
8637 (_initialize_linux_nat): Don't initialise normal_mask.
8638
8639 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8640
8641 PR gdb/24445
8642 * dwarf-index-write.h (write_psymtabs_to_index): Add
8643 dwz_basename parameter.
8644 * dwarf-index-write.c (write_gdbindex): Move file writing to
8645 write_gdbindex_1. Change return type void.
8646 (assert_file_size): Move up, remove filename parameter.
8647 (write_gdbindex_1): New function.
8648 (write_debug_names): Change return type to void, call
8649 assert_file_size.
8650 (struct index_wip_file): New struct.
8651 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8652 file logic to index_wip_file. Write index for dwz file if
8653 needed.
8654 (save_gdb_index_command): Pass basename of dwz file, if present.
8655 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8656 build-id of dwz file, if present.
8657 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8658 (dwarf2_get_dwz_file): Likewise.
8659 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8660 (dwarf2_get_dwz_file): Likewise.
8661
8662 2019-06-16 Tom Tromey <tom@tromey.com>
8663
8664 * coffread.c (process_coff_symbol): Use xstrdup.
8665 * value.c (create_internalvar): Use xstrdup.
8666
8667 2019-06-16 Tom Tromey <tom@tromey.com>
8668
8669 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8670 * breakpoint.c (stopin_command, stopat_command)
8671 (until_break_command, decode_location_default): Remove unnecessary
8672 cast.
8673 * utils.c (subset_compare): Remove unnecessary cast.
8674 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8675 cast.
8676 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8677 cast.
8678 * infcmd.c (path_command): Remove unnecessary cast.
8679 * coffread.c (decode_type): Remove unnecessary cast.
8680 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8681 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8682 * tui/tui-stack.c (tui_show_locator_content)
8683 (tui_show_frame_info): Remove unnecessary cast.
8684 * tui/tui-win.c (tui_scroll_forward_command)
8685 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8686 (parse_scrolling_args): Remove unnecessary cast.
8687 * tui/tui-data.c (init_win_info, tui_del_window)
8688 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8689 (free_content_elements): Remove unnecessary cast.
8690 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8691 unnecessary cast.
8692 * tui/tui-source.c (tui_set_source_content)
8693 (tui_vertical_source_scroll): Remove unnecessary cast.
8694 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8695 cast.
8696 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8697 * tui/tui-regs.c (tui_display_registers_from)
8698 (tui_display_register): Remove unnecessary cast.
8699 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8700 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8701 (make_visible): Remove unnecessary cast.
8702 * tui/tui-winsource.c (tui_erase_source_content)
8703 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8704 unnecessary cast.
8705 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8706 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8707 * stabsread.c (read_type, read_array_type, read_range_type):
8708 Remove unnecessary cast.
8709 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8710 (parse_symbol, parse_type, upgrade_type, parse_external)
8711 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8712 unnecessary cast.
8713 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8714
8715 2019-06-16 Tom Tromey <tom@tromey.com>
8716
8717 * tui/tui-data.c (tui_alloc_generic_win_info)
8718 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8719 checks.
8720
8721 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8722 Andrew Burgess <andrew.burgess@embecosm.com>
8723
8724 * f-typeprint.c (f_print_type): Don't return early for not
8725 associated or not allocated types.
8726 (f_type_print_varspec_suffix): Add print_rank parameter and print
8727 ranks of array types in case they dangling.
8728 (f_type_print_base): Add print_rank parameter.
8729
8730 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8731
8732 * NEWS: Mention new MI commands.
8733 * break-catch-throw.c (enum exception_event_kind): Move to
8734 breakpoint.h.
8735 (print_mention_exception_catchpoint): Output text as a single
8736 message.
8737 (catch_exception_command_1): Rename to...
8738 (catch_exception_event): ...this, make non-static, update header
8739 command, and change some parameter types.
8740 (catch_catch_command): Update for changes to
8741 catch_exception_command_1.
8742 (catch_throw_command): Likewise.
8743 (catch_rethrow_command): Likewise.
8744 * breakpoint.c (enum exception_event_kind): Delete.
8745 * breakpoint.h (enum exception_event_kind): Moved here from
8746 break-catch-throw.c.
8747 (catch_exception_event): Declare.
8748 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8749 (mi_cmd_catch_throw): New function.
8750 (mi_cmd_catch_rethrow): New function.
8751 (mi_cmd_catch_catch): New function.
8752 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8753 'catch-catch' entries.
8754 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8755 (mi_cmd_catch_rethrow): Declare.
8756 (mi_cmd_catch_catch): Declare.
8757
8758 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8759
8760 * annotate.c (annotate_source_line): Change return type to void,
8761 update implementation to match.
8762 * annotate.h (annotate_source_line): Change return type to void,
8763 update header comment.
8764 * stack.c (print_frame_info): Don't change what frame information
8765 is printed based on whether annotations are on or not.
8766
8767 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8768
8769 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8770 (annotate_source): Make static.
8771 (annotate_source_line): Moved from source.c and renamed from
8772 identify_source_line. Update the return type.
8773 * annotate.h (annotate_source): Delete declaration.
8774 (annotate_source_line): Declaration moved from source.h, and
8775 renamed from identify_source_line. Return type updated.
8776 * source.c (identify_source_line): Moved to annotate.c and renamed
8777 to annotate_source_line.
8778 (info_line_command): Remove check of annotation_level.
8779 * source.h (identify_source_line): Move declaration to annotate.h
8780 and rename to annotate_source_line.
8781 * stack.c: Add 'annotate.h' include.
8782 (print_frame_info): Remove check of annotation_level before
8783 calling annotate_source_line.
8784
8785 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8786
8787 * source-cache.c (source_cache::get_plain_source_lines): Use
8788 open_source_file_with_line_charpos instead of just
8789 open_source_file, remove call to find_source_lines.
8790 (source_cache::get_source_lines): Likewise.
8791 * source.c (find_source_lines): Make static.
8792 (get_filename_and_charpos): Renamed into...
8793 (open_source_file_with_line_charpos): ..this along with changes to
8794 return a scoped_fd, and some other minor clean ups.
8795 (identify_source_line): Use open_source_file_with_line_charpos.
8796 (search_command_helper): Use open_source_file_with_line_charpos
8797 instead of just open_source_file, remove call to
8798 find_source_lines.
8799 * source.h (open_source_file_with_line_charpos): Declare new
8800 function.
8801 (find_source_lines): Delete declaration.
8802
8803 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8804
8805 * source.c (get_filename_and_charpos): Remove fullname
8806 parameter.
8807 (identify_source_line): Update call to get_filename_and_charpos.
8808
8809 2019-06-14 Tom Tromey <tromey@adacore.com>
8810
8811 PR gdb/24502:
8812 * ui-style.h (skip_ansi_escape): Update comment.
8813 * ui-file.h (class no_terminal_escape_file): New class.
8814 * ui-file.c (no_terminal_escape_file::write)
8815 (no_terminal_escape_file::puts): New methods.
8816 * cli/cli-logging.c (handle_redirections): Use
8817 no_terminal_escape_file.
8818
8819 2019-06-14 Tom Tromey <tromey@adacore.com>
8820
8821 * NEWS: Move convenience variable news above Python news.
8822
8823 2019-06-14 Tom Tromey <tom@tromey.com>
8824
8825 * gnulib: Move directory to top-level.
8826 * configure.ac: Don't configure gnulib.
8827 * configure: Rebuild.
8828 * common/common-defs.h: Use new path to gnulib.
8829 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8830 (GNULIB_H): Remove.
8831 (INCGNU): Look in new gnulib location.
8832 (HFILES_NO_SRCDIR): Remove gnulib files.
8833 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8834 (generated_files): Remove GNULIB_H.
8835 ($(LIBGNU), all-lib): Remove targets.
8836 (distclean): Don't mention GNULIB_BUILDDIR.
8837 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8838
8839 2019-06-14 Tom Tromey <tromey@adacore.com>
8840
8841 * symfile.c (add_symbol_file_command): Remove obsolete comment.
8842 Warn if symbol file does not provide any symbols.
8843
8844 2019-06-14 Tom Tromey <tromey@adacore.com>
8845
8846 * source.c (find_and_open_source): Respect basenames_may_differ.
8847
8848 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
8849
8850 * annotate.c (annotate_breakpoints_invalid): Make use of
8851 scoped_restore_terminal_state.
8852 (annotate_frames_invalid): Likewise.
8853
8854 2019-06-14 Tom Tromey <tromey@adacore.com>
8855
8856 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8857 allow assignment to an internalvar.
8858
8859 2019-06-14 Tom Tromey <tromey@adacore.com>
8860
8861 * ada-lex.l: Allow "_" in attribute names.
8862
8863 2019-06-14 Tom Tromey <tromey@adacore.com>
8864
8865 PR gdb/24653:
8866 * regcache.c (registers_changed): Don't call alloca.
8867 * top.c (execute_command): Don't call alloca.
8868
8869 2019-06-13 Pedro Alves <palves@redhat.com>
8870
8871 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8872 'expression'. When parsing an expression, error out if there's
8873 junk after "unlimited".
8874 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8875 (do_set_command): Adjust calls to is_unlimited_literal.
8876
8877 2019-06-13 Pedro Alves <palves@redhat.com>
8878
8879 * compile/compile.c (make_compile_options_def_group): Add braces
8880 around array_view initializer.
8881 * thread.c (make_thread_apply_all_options_def_group)
8882 (make_thread_apply_all_options_def_group): Likewise.
8883
8884 2019-06-13 Pedro Alves <palves@redhat.com>
8885
8886 * NEWS (New commands): Mention "maint test-options
8887 require-delimiter", "maint test-options unknown-is-error", "maint
8888 test-options unknown-is-operand" and "maint show
8889 test-options-completion-result".
8890 (New command options, command completion): New section.
8891 (Completion improvements): New section.
8892 Mention that you can abbreviate "unlimited".
8893
8894 2019-06-13 Pedro Alves <palves@redhat.com>
8895
8896 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8897 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8898 * unittests/cli-utils-selftests.c (test_parse_flags)
8899 (test_parse_flags_qcs): Delete.
8900 (test_cli_utils): Don't call deleted functions.
8901
8902 2019-06-13 Pedro Alves <palves@redhat.com>
8903
8904 * thread.c: Include "cli/cli-option.h".
8905 (tp_array_compar_ascending): Global.
8906 (tp_array_compar): Delete function.
8907 (tp_array_compar_ascending, tp_array_compar_descending): New
8908 functions.
8909 (ascending_option_def, qcs_flag_option_def)
8910 (thr_qcs_flags_option_defs)
8911 (make_thread_apply_all_options_def_group)
8912 (make_thread_apply_options_def_group): New.
8913 (thread_apply_all_command): Use gdb::option::process_options.
8914 (thread_apply_command_completer)
8915 (thread_apply_all_command_completer): New.
8916 (thread_apply_command): Use gdb::option::process_options.
8917 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8918 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
8919 to generate help text of "thread apply". Adjust "taas"'s help.
8920 * tid-parse.c (tid_range_parser::in_thread_range): New method.
8921 * tid-parse.h (tid_range_parser::in_thread_range): New method.
8922
8923 2019-06-13 Pedro Alves <palves@redhat.com>
8924
8925 * thread.c (thread_apply_command): Check for invalid TID with
8926 isdigit instead of !isalpha.
8927
8928 2019-06-13 Pedro Alves <palves@redhat.com>
8929
8930 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8931 (validate_flags_qcs): New.
8932 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8933 (validate_flags_qcs): Declare.
8934 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8935 (make_frame_apply_options_def_group): New.
8936 (frame_apply_command_count): Process options with
8937 gdb::option::process_options.
8938 (frame_apply_completer): New.
8939 (frame_apply_level_completer, frame_apply_all_completer)
8940 (frame_apply_completer): New.
8941 (_initialize_stack): Update help of "frame apply", "frame apply
8942 level", "frame apply all" and "faas" to mention supported options
8943 and install command completers.
8944 * stack.h (frame_apply_all_completer): Declare.
8945 * thread.c: Include "stack.h".
8946 (tfaas_command): Add "--".
8947 (_initialize_thread): Update help "tfaas" to mention supported
8948 options and install command completer.
8949
8950 2019-06-13 Pedro Alves <palves@redhat.com>
8951
8952 * completer.c (complete_nested_command_line): New.
8953 (gdb_completion_word_break_characters_throw): Add assertion.
8954 * completer.h (complete_nested_command_line): Declare.
8955
8956 2019-06-13 Pedro Alves <palves@redhat.com>
8957
8958 * stack.c (parse_backtrace_qualifiers): New.
8959 (backtrace_command): Use it.
8960 (backtrace_command_completer): Complete on qualifiers.
8961
8962 2019-06-13 Pedro Alves <palves@redhat.com>
8963
8964 * frame.c: Include "cli/cli-option.h.
8965 (user_set_backtrace_options): New.
8966 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8967 Delete.
8968 (get_prev_frame): Adjust.
8969 (boolean_option_def, uinteger_option_def)
8970 (set_backtrace_option_defs): New.
8971 (_initialize_frame): Adjust and use
8972 gdb::option::add_setshow_cmds_for_options to install "set
8973 backtrace past-main" and "set backtrace past-entry".
8974 * frame.h: Include "cli/cli-option.h".
8975 (struct frame_print_options): Forward declare.
8976 (print_frame_arguments_all, print_frame_arguments_scalars)
8977 (print_frame_arguments_none): Declare.
8978 (print_entry_values): Delete declaration.
8979 (struct frame_print_options, user_frame_print_options): New.
8980 (struct set_backtrace_options): New.
8981 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8982 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8983 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8984 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8985 (list_args_or_locals): Add frame_print_options parameter.
8986 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8987 * python/py-framefilter.c (enumerate_args): Pass down
8988 USER_FRAME_PRINT_OPTIONS.
8989 * stack.c: Include "cli/cli-option.h".
8990 (print_frame_arguments_all, print_frame_arguments_scalars)
8991 (print_frame_arguments_none): Declare.
8992 (print_raw_frame_arguments, print_entry_values): Delete.
8993 (user_frame_print_options): New.
8994 (boolean_option_def, enum_option_def, frame_print_option_defs):
8995 New.
8996 (struct backtrace_cmd_options): New.
8997 (bt_flag_option_def): New.
8998 (backtrace_command_option_defs): New.
8999 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9000 (print_frame_arg, read_frame_arg, print_frame_args)
9001 (print_frame_info, print_frame): Add frame_print_options parameter
9002 and use it.
9003 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9004 (backtrace_command_1): Add frame_print_options and
9005 backtrace_cmd_options parameters and use them.
9006 (make_backtrace_options_def_group): New.
9007 (backtrace_command): Process command options with
9008 gdb::option::process_options.
9009 (backtrace_command_completer): New.
9010 (_initialize_stack): Extend "backtrace"'s help to mention
9011 supported options. Install completer for "backtrace".
9012 Install some settings commands with add_setshow_cmds_for_options.
9013
9014 2019-06-13 Pedro Alves <palves@redhat.com>
9015
9016 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9017 and that "set/show print raw frame-arguments" are now deprecated.
9018
9019 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9020 command.
9021 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9022 * stack.c (_initialize_stack): Install "set/show print
9023 raw-frame-arguments", and deprecate "set/show print raw
9024 frame-arguments".
9025 * valprint.c (_initialize_valprint): Deprecate "set/show print
9026 raw".
9027
9028 2019-06-13 Pedro Alves <palves@redhat.com>
9029
9030 * compile/compile.c (struct compile_options): New.
9031 (compile_flag_option_def, compile_command_option_defs)
9032 (make_compile_options_def_group): New.
9033 (compile_file_command): Handle options with
9034 gdb::option::process_options.
9035 (compile_file_command_completer): New function.
9036 (compile_code_command): Handle options with
9037 gdb::option::process_options.
9038 (compile_code_command_completer): New function.
9039 (_initialize_compiler): Install completers for "compile code" and
9040 "compile file". Mention available options in "compile code" and
9041 "compile code"'s help.
9042 * completer.c (advance_to_completion_word): New, factored out from
9043 ...
9044 (advance_to_expression_complete_word_point): ... this.
9045 (advance_to_filename_complete_word_point): New.
9046 * completer.h (advance_to_filename_complete_word_point): New
9047 declaration.
9048
9049 2019-06-13 Pedro Alves <palves@redhat.com>
9050
9051 * compile/compile.c: Include "cli/cli-option.h".
9052 (compile_print_value): Scope data pointer is now a
9053 value_print_options pointer; adjust.
9054 (compile_print_command): Process options. Scope data pointer is
9055 now a value_print_options pointer; adjust.
9056 (_initialize_compile): Update "compile print"'s help to include
9057 supported options. Install a completer for "compile print".
9058 * cp-valprint.c (show_vtblprint, show_objectprint)
9059 (show_static_field_print): Delete.
9060 (_initialize_cp_valprint): Don't install "set print
9061 static-members", "set print vtbl", "set print object" here.
9062 * printcmd.c: Include "cli/cli-option.h" and
9063 "common/gdb_optional.h".
9064 (print_command_parse_format): Rework to fill in a
9065 value_print_options instead of a format_data.
9066 (print_value): Change parameter type from format_data pointer to
9067 value_print_options reference. Adjust.
9068 (print_command_1): Process options. Adjust to pass down a
9069 value_print_options.
9070 (print_command_completer): New.
9071 (_initialize_printcmd): Install print_command_completer as
9072 handle_brkchars completer for the "print" command. Update
9073 "print"'s help to include supported options.
9074 * valprint.c: Include "cli/cli-option.h".
9075 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9076 here from cp-valprint.c.
9077 (boolean_option_def, uinteger_option_def)
9078 (value_print_option_defs, make_value_print_options_def_group):
9079 New. Use gdb::option::add_setshow_cmds_for_options to install
9080 "set print elements", "set print null-stop", "set print repeats",
9081 "set print pretty", "set print union", "set print array", "set
9082 print address", "set print symbol", "set print array-indexes".
9083 * valprint.h: Include <string> and "cli/cli-option.h".
9084 (make_value_print_options_def_group): Declare.
9085 (print_value): Change parameter type from format_data pointer to
9086 value_print_options reference.
9087 (print_command_completer): Declare.
9088
9089 2019-06-13 Pedro Alves <palves@redhat.com>
9090
9091 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9092 (COMMON_SFILES): Add maint-test-settings.c.
9093 * cli/cli-decode.c (boolean_enums): New global, factored out from
9094 ...
9095 (add_setshow_boolean_cmd): ... here.
9096 * cli/cli-decode.h (boolean_enums): Declare.
9097 * cli/cli-option.c: New file.
9098 * cli/cli-option.h: New file.
9099 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9100 factored out from ...
9101 (parse_cli_boolean_value(const char *)): ... this.
9102 (is_unlimited_literal): Change parameter type to pointer to
9103 pointer. Adjust and advance ARG pointer.
9104 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9105 (parse_cli_var_enum): New, factored out from ...
9106 (do_set_command): ... this. Adjust.
9107 * cli/cli-setshow.h (parse_cli_boolean_value)
9108 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9109 (parse_cli_var_enum): Declare.
9110 * cli/cli-utils.c: Include "cli/cli-option.h".
9111 (get_ulongest): New.
9112 * cli/cli-utils.h (get_ulongest): Declare.
9113 (check_for_argument): New overloads.
9114 * maint-test-options.c: New file.
9115
9116 2019-06-13 Pedro Alves <palves@redhat.com>
9117
9118 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9119 parse a range if "-" is at the end of the string.
9120
9121 2019-06-13 Pedro Alves <palves@redhat.com>
9122
9123 * cli/cli-setshow.c (parse_auto_binary_operation)
9124 (parse_cli_boolean_value): Don't allow "o".
9125
9126 2019-06-13 Pedro Alves <palves@redhat.com>
9127
9128 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9129 * NEWS: Mention maint test-settings KIND.
9130 * maint-test-settings.c: New file.
9131
9132 2019-06-13 Pedro Alves <palves@redhat.com>
9133
9134 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9135 completer.
9136 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9137 "set" completers.
9138
9139 2019-06-13 Pedro Alves <palves@redhat.com>
9140
9141 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9142 after item.
9143
9144 2019-06-13 Pedro Alves <palves@redhat.com>
9145
9146 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9147
9148 2019-06-13 Pedro Alves <palves@redhat.com>
9149
9150 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9151 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9152 call.
9153 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9154 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9155 calls.
9156 (check_for_argument): Skip spaces after argument.
9157
9158 2019-06-13 Pedro Alves <palves@redhat.com>
9159
9160 * thread.c (thread_apply_command): Adjust TID parsing.
9161 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9162 detected before end of string.
9163 (tid_is_in_list): Error out if LIST is invalid.
9164
9165 2019-06-13 Pedro Alves <palves@redhat.com>
9166
9167 * completer.c (complete_line_internal_1): Rewind completion word
9168 point.
9169 (completion_tracker::advance_custom_word_point_by): Change
9170 parameter type to int.
9171 * completer.h (completion_tracker::advance_custom_word_point_by):
9172 Likewise.
9173
9174 2019-06-13 Pedro Alves <palves@redhat.com>
9175
9176 * completer.c (advance_to_completion_word): Handle delimiters.
9177
9178 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9179
9180 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9181
9182 2019-06-11 Tom Tromey <tom@tromey.com>
9183
9184 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9185 (xmalloc_failed): Move to alloc.c.
9186 * alloc.c: New file.
9187 * Makefile.in (COMMON_SFILES): Add alloc.c.
9188
9189 2019-06-11 Tom Tromey <tom@tromey.com>
9190
9191 * nat/linux-waitpid.c: Don't include server.h.
9192 (linux_debug): Remove.
9193 (my_waitpid): Update.
9194
9195 2019-06-11 Tom Tromey <tromey@adacore.com>
9196
9197 * infcall.c (_initialize_infcall): Remove trailing newline from
9198 help.
9199 * user-regs.c (_initialize_user_regs): Remove trailing newline
9200 from help.
9201 * typeprint.c (_initialize_typeprint): Remove trailing newline
9202 from help.
9203 * reverse.c (_initialize_reverse): Remove trailing newlines from
9204 help.
9205 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9206 from help.
9207 * language.c (add_set_language_command): Remove trailing newline
9208 from help.
9209 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9210 help.
9211 * disasm.c (_initialize_disasm): Remove trailing newline from
9212 help.
9213 * top.c (init_main): Remove trailing newline from help.
9214 * interps.c (_initialize_interpreter): Remove trailing newline
9215 from help.
9216 * btrace.c (_initialize_btrace): Remove trailing newlines from
9217 help.
9218 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9219 from help.
9220 * python/python.c (_initialize_python): Remove trailing newline
9221 from help.
9222 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9223 help.
9224 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9225 from help. Reformat some text.
9226 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9227 from help.
9228 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9229 newline from help.
9230
9231 2019-06-11 Tom Tromey <tromey@adacore.com>
9232
9233 * darwin-nat.c (darwin_decode_exception_message)
9234 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9235
9236 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9237
9238 * valops.c (value_slice): Check for not allocated or not
9239 associated values.
9240
9241 2019-06-10 Tom de Vries <tdevries@suse.de>
9242
9243 PR gdb/24618
9244 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9245 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9246 invalid.
9247
9248 2019-06-10 Tom de Vries <tdevries@suse.de>
9249
9250 PR gdb/24611
9251 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9252 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9253
9254 2019-06-10 Tom de Vries <tdevries@suse.de>
9255
9256 PR symtab/24545
9257 * symtab.c (struct demangled_name_entry): Add language field.
9258 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9259 static minimal symbol". Set and use language field.
9260
9261 2019-06-10 Tom Tromey <tromey@adacore.com>
9262
9263 * ada-lang.c (_initialize_ada_language): Update help text.
9264
9265 2019-06-10 Tom Tromey <tromey@adacore.com>
9266
9267 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9268 with a newline.
9269 * guile/guile.c (handle_boot_error): Don't end warning with a
9270 newline.
9271 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9272 warning with a newline.
9273 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9274 newline.
9275 (s12z_frame_cache): Likewise.
9276 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9277 a newline.
9278 * solib-svr4.c (disable_probes_interface): Don't end warning with
9279 a newline.
9280 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9281 newline.
9282 * python/python.c (do_finish_initialization): Don't end warning
9283 with a newline.
9284
9285 2019-06-10 Tom Tromey <tom@tromey.com>
9286
9287 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9288 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9289 gdbpy_enter.
9290
9291 2019-06-10 Tom Tromey <tromey@adacore.com>
9292
9293 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9294 data.
9295 (elf_new_init): Don't call stabsread_new_init.
9296 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9297 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9298 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9299
9300 2019-06-10 Tom de Vries <tdevries@suse.de>
9301
9302 PR symtab/16264
9303 PR symtab/24517
9304 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9305
9306 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9307
9308 * source.c (find_and_open_source): Also rewrite relative file
9309 names.
9310
9311 2019-04-26 Amos Bird <amosbird@gmail.com>
9312
9313 * annotate.c (annotate_thread_exited): Add "thread-exited"
9314 annotation.
9315
9316 2019-06-06 Tom Tromey <tromey@adacore.com>
9317
9318 * maint.h (class scoped_command_stats): Use
9319 DISABLE_COPY_AND_ASSIGN.
9320 <print_time>: New method.
9321 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9322 print_time.
9323 (scoped_command_stats::print_time): New method.
9324
9325 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9326
9327 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9328 instructions of lengths 6 or 8 bytes.
9329
9330 2019-06-04 Pedro Alves <palves@redhat.com>
9331
9332 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9333
9334 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9335 * breakpoint.c (condition_completer): Likewise.
9336 * cli/cli-dump.c (scan_expression): Likewise.
9337 * common/filestuff.c (mkdir_recursive): Likewise.
9338 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9339 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9340 (gdb_abspath): Likewise.
9341 * compile/compile-cplus-types.c
9342 (compile_cplus_instance::decl_name): Likewise.
9343 * completer.c (complete_explicit_location):
9344 (signal_completer, reg_or_group_completer_1): Likewise.
9345 * cp-support.c (cp_remove_params_if_any): Likewise.
9346 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9347 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9348 * infcmd.c (strip_bg_char): Likewise.
9349 * linespec.c (copy_token_string): Likewise.
9350 * mi/mi-main.c (output_cores): Likewise.
9351 * psymtab.c (psymtab_search_name):
9352 * symfile.c (test_set_ext_lang_command): Likewise.
9353 * target.c (target_fileio_read_stralloc): Likewise.
9354 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9355 * value.c (complete_internalvar): Likewise.
9356
9357 2019-06-04 Christian Biesinger <cbiesinger@google.com>
9358
9359 Add objfile property to gdb.Type.
9360 * NEWS: Mention Python API addition.
9361 * python/py-type.c (typy_get_objfile): New method.
9362
9363 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9364
9365 * NEWS: Mention the new set|show style [title|highlight].
9366 Mention changes to "show style", "help" and "apropos".
9367
9368 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9369
9370 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9371 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9372 instead of print_help_for_command.
9373 (print_doc_of_command): New function.
9374 (help_list): Add 'apropos -v word' suggestion.
9375 (print_help_for_command): Style the command name using title style.
9376 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9377 (_initialize_cli_cmds): Describe -v in apropos_command help.
9378
9379 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9380
9381 * cli/cli-style.h (cli_style_option): Add name in constructor,
9382 add m_name class member, add constructor with intensity,
9383 add name class function.
9384 (cli_style_option::add_setshow_commands): Remove name argument.
9385 (highlight_style, title_style): New styles.
9386 * cli/cli-style.c (do_show): New function that shows a style
9387 characteristic styling the style name with itself.
9388 (set_style_name): New function.
9389 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9390 Update all callers according to the changes in cli/cli-style.h.
9391 * utils.h (fputs_highlighted): New function.
9392 * utils.c (fputs_highlighted): Likewise.
9393
9394 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9395
9396 * NEWS: Mention new pipe command and new convenience variables.
9397
9398 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9399
9400 * cli/cli-cmds.c (pipe_command): New function.
9401 (_initialize_cli_cmds): Call add_com for pipe_command.
9402 Define | as an alias for pipe.
9403 (exit_status_set_internal_vars): New function.
9404 (shell_escape): Call exit_status_set_internal_vars.
9405 cli/cli-decode.c (find_command_name_length): Recognize | as
9406 a single character command.
9407
9408 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9409
9410 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9411 top.c (execute_command_to_ui_file): New function, mostly a copy
9412 of execute_command_to_string.
9413 (execute_command_to_string): Implement by calling
9414 execute_command_to_ui_file.
9415
9416 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9417
9418 * top.h (saved_command_line): Remove declaration.
9419 * top.c (previous_saved_command_line, previous_repeat_arguments):
9420 New variables.
9421 (saved_command_line): Make static, define together with other
9422 'repeat variables'.
9423 (dont_repeat): Clear repeat_arguments.
9424 (repeat_previous, get_saved_command_line, save_command_line):
9425 New functions.
9426 (gdb_init): Initialize saved_command_line
9427 and previous_saved_command_line.
9428 * main.c (captured_main_1): Remove saved_command_line initialization.
9429 * event-top.c (handle_line_of_input): Update to use
9430 the new 'repeat' related functions instead of direct access to
9431 saved_command_line.
9432 * command.h (repeat_previous, get_saved_command_line,
9433 save_command_line): New declarations.
9434 (dont_repeat): Add comment.
9435
9436 2019-05-30 Tom Tromey <tromey@adacore.com>
9437
9438 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9439 Fix comment.
9440 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9441
9442 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9443
9444 PR cli/24587
9445 * completer.c (complete): Initialize variable word.
9446
9447 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9448
9449 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9450 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9451 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9452 'body' is NULL to the outter 'if', protecting the '!is_define'
9453 situation as well.
9454
9455 2019-05-29 Tom Tromey <tromey@adacore.com>
9456
9457 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9458 (dwarf_unknown): New function.
9459 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9460 (dwarf_type_encoding_name): Use dwarf_unknown.
9461
9462 2019-05-29 Tom Tromey <tromey@adacore.com>
9463
9464 PR c++/20020:
9465 * cp-valprint.c (cp_print_value_fields): Call
9466 cp_print_static_field inside "try".
9467
9468 2019-05-29 Tom Tromey <tromey@adacore.com>
9469
9470 * inflow.c (struct terminal_info): Add default operator=.
9471 * configure: Rebuild.
9472 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9473 -Wdeprecated-copy-dtor, -Wredundant-move.
9474
9475 2019-05-29 Tom Tromey <tromey@adacore.com>
9476
9477 * NEWS: Add entry.
9478 * infcmd.c (print_return_value_1): Handle finish_print
9479 option.
9480 (show_print_finish): New function.
9481 (_initialize_infcmd): Add "set/show print finish" commands.
9482 * valprint.c (user_print_options): Initialize new member.
9483 * valprint.h (struct value_print_options) <finish_print>: New
9484 member.
9485
9486 2019-05-28 Tom Tromey <tromey@adacore.com>
9487
9488 * ada-lang.c (ada_remove_Xbn_suffix)
9489 (find_old_style_renaming_symbol)
9490 (parse_old_style_renaming): Remove.
9491 (ada_find_renaming_symbol): Don't call
9492 find_old_style_renaming_symbol.
9493 (ada_is_renaming_symbol): Rename from
9494 ada_find_renaming_symbol. Remove "block" parameter. Return
9495 bool. Now static.
9496 (ada_read_var_value): Update and simplify.
9497 * ada-exp.y (write_var_or_type): Remove old code.
9498
9499 2019-05-28 Alan Hayward <alan.hayward@arm.com>
9500
9501 PR gdb/25010
9502 * event-top.c: Remove include comment.
9503 * inflow.c (class scoped_ignore_sigttou): Move from here...
9504 * inflow.h (class scoped_ignore_sigttou): ...to here.
9505 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9506 * top.c: Remove include comment.
9507
9508 2019-05-27 Tom Tromey <tom@tromey.com>
9509
9510 * NEWS: Fix typo.
9511
9512 2019-05-22 Tom Tromey <tromey@adacore.com>
9513
9514 * target.c (target_follow_exec): Constify parameter.
9515 * target-delegates.c: Rebuild.
9516 * remote.c (remote_target::follow_exec): Constify parameter.
9517 * infrun.c (follow_exec): Constify parameter.
9518 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9519 (target_follow_exec): Likewise.
9520
9521 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9522
9523 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9524 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9525
9526 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9527
9528 * NEWS: Add debugredirect and testsuite sections.
9529
9530 2019-05-22 Simon Cook <simon.cook@embecosm.com>
9531
9532 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9533 target descriptions using exclusively floating point register name
9534 aliases.
9535
9536 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9537
9538 PR gdb/18644:
9539 * f-lang.c (build_fortran_types): Handle the case where
9540 gdbarch_floatformat_for_type returns a nullptr.
9541
9542 2019-05-21 Tom de Vries <tdevries@suse.de>
9543
9544 PR cli/24587
9545 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9546
9547 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9548
9549 PR gdb/18644:
9550 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9551 16-byte floats.
9552 * i386-tdep.c (i386_floatformat_for_type): Use
9553 floatformats_ia64_quad for the 16-byte floating point component
9554 within a fortran 32-byte complex number.
9555
9556 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9557
9558 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9559 delete default constructor.
9560 (find_partial_die): Update to return const struct.
9561 (partial_die_parent_scope): Move variable declaration into scope
9562 of its use and change its type to auto.
9563 (guess_partial_die_structure_name): Likewise.
9564 (partial_die_info::fixup): Likewise.
9565
9566 2019-05-17 Tom Tromey <tromey@adacore.com>
9567
9568 * source.c (find_and_open_source): Remove cast.
9569
9570 2019-05-17 Tom Tromey <tromey@adacore.com>
9571
9572 * annotate.c (annotate_source): Make "filename" const.
9573 * annotate.h (annotate_source): Use const.
9574
9575 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9576
9577 * disasm.c (set_disassembler_options): Send errors to stderr.
9578
9579 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9580
9581 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9582 (cli_interp_base::set_logging): Check debug_redirect.
9583 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9584 * cli/cli-logging.c (debug_redirect): Add static variable.
9585 (pop_output_files): Add default param.
9586 (handle_redirections): Print debug setting.
9587 (show_logging_command): Likewise.
9588 (_initialize_cli_logging): Add debugredirect command.
9589 * interps.c (current_interp_set_logging): Add debug_redirect
9590 parameter.
9591 * interps.h (set_logging): Add debug_redirect parameter.
9592 (current_interp_set_logging): Likewise.
9593 * mi/mi-common.h: Likewise.
9594 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9595
9596 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9597 Tom Tromey <tromey@adacore.com>
9598
9599 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9600 directly.
9601 * cli/cli-interp.h (make_logging_output): Remove declaration.
9602 * cli/cli-logging.c (make_logging_output): Remove function.
9603 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9604 directly.
9605 * ui-file.c (tee_file::tee_file): Remove bools.
9606 (tee_file::~tee_file): Remove deletes.
9607 * ui-file.h (tee_file): Remove bools.
9608
9609 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9610
9611 * mi/mi-cmds.h (mi_cmd_complete): New function.
9612 * mi/mi-main.c (mi_cmd_complete): Likewise.
9613 * mi/mi-cmds.c: Define new MI command -complete.
9614 * NEWS: Mention new -complete command.
9615
9616 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9617
9618 * completer.h (complete): New function.
9619 * completer.c (complete): Likewise.
9620 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9621 function defined in completer.h.
9622
9623 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9624
9625 * MAINTAINERS (Write After Approval): Add myself.
9626
9627 2019-05-17 Tom de Vries <tdevries@suse.de>
9628
9629 PR gdb/24094
9630 * dwarf2read.c (struct cu_partial_die_info): New struct.
9631 (find_partial_die): Return cu_partial_die_info.
9632 (partial_die_parent_scope, guess_partial_die_structure_name)
9633 (partial_die_info::fixup): Handle new return type of find_partial_die.
9634
9635 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9636
9637 PR breakpoints/24541
9638 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9639 "std::string", simplifying the algorithm.
9640
9641 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9642
9643 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9644 (stap_static_probe_ops::get_probes): Likewise.
9645
9646 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9647
9648 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9649 '-')" and "else if".
9650 (stap_parse_single_operand): Join checks for
9651 "gdbarch_stap_parse_special_token_p" and
9652 "gdbarch_stap_parse_special_token" in the same "if" statement.
9653 Invert check when verifying for operation on register
9654 displacement.
9655
9656 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9657
9658 * stap-probe.c (stap_get_opcode): Update comment.
9659 (stap_get_expected_argument_type): Likewise.
9660 (handle_stap_probe): Likewise.
9661
9662 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9663
9664 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9665 return type to 'bool'. Adjust comment. Use 'bool' when
9666 appropriate.
9667 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9668 * stap-probe.c (stap_parse_argument_1): Likewise.
9669 (stap_is_operator): Likewise.
9670 (stap_is_generic_prefix): Likewise.
9671 (stap_is_register_prefix): Likewise.
9672 (stap_is_register_indirection_prefix): Likewise.
9673 (stap_is_integer_prefix): Likewise.
9674 (stap_generic_check_suffix): Likewise.
9675 (stap_check_integer_suffix): Likewise.
9676 (stap_check_register_suffix): Likewise.
9677 (stap_check_register_indirection_suffix): Likewise.
9678 (stap_parse_register_operand): Likewise.
9679 (stap_parse_single_operand): Likewise.
9680 (stap_parse_argument_1): Likewise.
9681 (stap_probe::get_argument_count): Likewise.
9682 (stap_is_operator): Likewise.
9683
9684 2019-05-16 Tom Tromey <tromey@adacore.com>
9685
9686 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9687 keyword to foreach.
9688
9689 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
9690
9691 * linux-thread-db.c (try_thread_db_load_1): Change return type
9692 to bool.
9693 (try_thread_db_load): Likewise.
9694 (try_thread_db_load_from_pdir_1): Likewise.
9695 (try_thread_db_load_from_pdir): Likewise.
9696 (try_thread_db_load_from_sdir): Likewise.
9697 (try_thread_db_load_from_dir): Likewise.
9698 (thread_db_load_search): Likewise.
9699 (has_libpthread): Likewise.
9700 (thread_db_load): Likewise.
9701
9702 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9703
9704 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9705 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9706 NULL, and complain/return if that's the case.
9707
9708 2019-05-15 John Darrington <john@darrington.wattle.id.au>
9709
9710 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9711 (advance, posn, abstract_read_memory): New functions.
9712 [struct mem_read_abstraction]: New struct.
9713 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9714
9715 2019-05-14 Tom Tromey <tromey@adacore.com>
9716
9717 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9718 value is not lval_memory.
9719
9720 2019-05-14 Tom Tromey <tromey@adacore.com>
9721
9722 * solib.c (info_sharedlibrary_command): Style the file name.
9723
9724 2019-05-14 Alan Hayward <alan.hayward@arm.com>
9725
9726 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9727 (aarch64_vnv_type): Likewise.
9728 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9729 * common/tdesc.c: Likewise.
9730 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9731 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9732 * features/aarch64-fpu.xml: Add ieee half view.
9733 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9734 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9735 * gdbtypes.h (struct builtin_type): Likewise.
9736 (struct objfile_type): Likewise.
9737
9738 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
9739
9740 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9741 typo.
9742 * location.h (string_to_event_location): Likewise.
9743
9744 2019-05-11 Joel Brobecker <brobecker@adacore.com>
9745
9746 GDB 8.3 released.
9747
9748 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9749
9750 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9751 New variable declaration.
9752 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9753 New variable.
9754 (print_one_breakpoint): Use ui_out::test_flags and new global
9755 variable to compute use_fixed_output.
9756 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9757 Remove.
9758 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9759 (mi_multi_location_breakpoint_output_fixed): Remove.
9760 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9761 new variable.
9762 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9763 fix_multi_location_breakpoint_output flag if version >= 3.
9764 * ui-out.h (enum ui_out_flag)
9765 <fix_multi_location_breakpoint_output>: New enumerator.
9766
9767 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9768
9769 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9770
9771 2019-05-10 Tom Tromey <tromey@adacore.com>
9772
9773 * ada-lang.c (catch_ada_completer): New function.
9774 (_initialize_ada_language): Use it.
9775
9776 2019-05-10 Tom Tromey <tromey@adacore.com>
9777
9778 * thread.c (print_thread_info): Make "requested_threads" const.
9779 * gdbthread.h (print_thread_info): Make "requested_threads"
9780 const.
9781 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9782 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9783
9784 2019-05-08 Tom Tromey <tom@tromey.com>
9785
9786 * gdbtypes.c (objfile_type_data): Change type.
9787 (objfile_type, _initialize_gdbtypes): Update.
9788
9789 2019-05-08 Tom Tromey <tom@tromey.com>
9790
9791 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9792 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9793 (_initialize_dwarf2_frame): Update.
9794
9795 2019-05-08 Tom Tromey <tom@tromey.com>
9796
9797 * objc-lang.c (objc_objfile_data): Change type.
9798 (find_methods): Update.
9799 (_initialize_objc_lang): Remove.
9800
9801 2019-05-08 Tom Tromey <tom@tromey.com>
9802
9803 * stabsread.c (rs6000_builtin_type_data): Change type.
9804 (rs6000_builtin_type, _initialize_stabsread): Update.
9805
9806 2019-05-08 Tom Tromey <tom@tromey.com>
9807
9808 * mips-tdep.c (mips_pdr_data): Remove.
9809 (_initialize_mips_tdep): Update.
9810
9811 2019-05-08 Tom Tromey <tom@tromey.com>
9812
9813 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9814 (hppa_init_objfile_priv_data, read_unwind_info)
9815 (find_unwind_entry, _initialize_hppa_tdep): Update.
9816
9817 2019-05-08 Tom Tromey <tom@tromey.com>
9818
9819 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9820 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9821 on obstack.
9822 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9823
9824 2019-05-08 Tom Tromey <tom@tromey.com>
9825
9826 * mdebugread.c (basic_type_data): Change type.
9827 (basic_type, _initialize_mdebugread): Update.
9828
9829 2019-05-08 Tom Tromey <tom@tromey.com>
9830
9831 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9832
9833 2019-05-08 Tom Tromey <tom@tromey.com>
9834
9835 * nto-tdep.c (nto_inferior_data_reg): Change type.
9836 (nto_inferior_data): Update.
9837 (nto_inferior_data_cleanup, nto_new_inferior_data)
9838 (_initialize_nto_tdep): Remove.
9839 * nto-tdep.h (struct nto_inferior_data): Add initializers.
9840
9841 2019-05-08 Tom Tromey <tom@tromey.com>
9842
9843 * ada-lang.c (struct ada_inferior_data): Add initializers.
9844 (ada_inferior_data): Change type.
9845 (ada_inferior_data_cleanup): Remove.
9846 (get_ada_inferior_data, ada_inferior_exit)
9847 (struct ada_pspace_data): Add initializers, destructor.
9848 (ada_pspace_data_handle): Change type.
9849 (get_ada_pspace_data): Update.
9850 (ada_pspace_data_cleanup): Remove.
9851
9852 2019-05-08 Tom Tromey <tom@tromey.com>
9853
9854 * coffread.c (struct coff_symfile_info): Add initializers.
9855 (coff_objfile_data_key): Move lower. Change type.
9856 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9857 Update.
9858 (coff_free_info): Remove.
9859
9860 2019-05-08 Tom Tromey <tom@tromey.com>
9861
9862 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9863 (fbsd_pspace_data_handle): Move lower. Change type.
9864 (get_fbsd_pspace_data): Update.
9865 (fbsd_pspace_data_cleanup): Remove.
9866 (_initialize_fbsd_tdep): Update.
9867
9868 2019-05-08 Tom Tromey <tom@tromey.com>
9869
9870 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9871 (get_ada_tasks_pspace_data): Update.
9872 (ada_tasks_pspace_data_cleanup): Remove.
9873 (_initialize_tasks): Update.
9874 (ada_tasks_inferior_data_handle): Change type.
9875 (get_ada_tasks_inferior_data): Update.
9876 (ada_tasks_inferior_data_cleanup): Remove.
9877 (struct ada_tasks_pspace_data): Add initializers.
9878
9879 2019-05-08 Tom Tromey <tom@tromey.com>
9880
9881 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9882 * symfile-debug.c (debug_sym_get_probes): Change type.
9883 * stap-probe.c (handle_stap_probe):
9884 (stap_static_probe_ops::get_probes): Change type.
9885 * probe.h (class static_probe_ops) <get_probes>: Change type.
9886 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9887 (parse_probes_in_pspace): Update.
9888 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9889 Update.
9890 (any_static_probe_ops::get_probes): Change type.
9891 * elfread.c (elfread_data): New typedef.
9892 (probe_key): Change type.
9893 (elf_get_probes): Likewise. Update.
9894 (probe_key_free): Remove.
9895 (_initialize_elfread): Update.
9896 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9897 Change type.
9898 (dtrace_process_dof_probe, dtrace_process_dof)
9899 (dtrace_static_probe_ops::get_probe): Change type.
9900
9901 2019-05-08 Tom Tromey <tom@tromey.com>
9902
9903 * xcoffread.c (struct xcoff_symfile_info): Rename from
9904 coff_symfile_info. Add initializers.
9905 (xcoff_objfile_data_key): Move lower. Change type.
9906 (XCOFF_DATA): Rewrite.
9907 (xcoff_free_info): Remove.
9908 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9909 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9910 (xcoff_initial_scan): Update.
9911
9912 2019-05-08 Tom Tromey <tom@tromey.com>
9913
9914 * solib-svr4.c (struct svr4_info): Add initializers and
9915 destructor.
9916 <probes_table>: Now an htab_up.
9917 (solib_svr4_pspace_data): Change type.
9918 (free_probes_table): Simplify.
9919 (~svr4_info): Rename from svr4_pspace_data_cleanup.
9920 (get_svr4_info, probes_table_htab_remove_objfile_probes)
9921 (probes_table_remove_objfile_probes, register_solib_event_probe)
9922 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9923 (_initialize_svr4_solib): Update.
9924
9925 2019-05-08 Tom Tromey <tom@tromey.com>
9926
9927 * remote.c (remote_pspace_data): Change type.
9928 (remote_pspace_data_cleanup): Remove.
9929 (get_remote_exec_file, set_pspace_remote_exec_file)
9930 (_initialize_remote): Update.
9931
9932 2019-05-08 Tom Tromey <tom@tromey.com>
9933
9934 * breakpoint.c (breakpoint_objfile_key): Change type.
9935 (get_breakpoint_objfile_data): Update.
9936 (free_breakpoint_objfile_data): Remove.
9937 (_initialize_breakpoint): Update.
9938
9939 2019-05-08 Tom Tromey <tom@tromey.com>
9940
9941 * linux-tdep.c (struct linux_info): Add initializers.
9942 (linux_inferior_data): Move. Change type.
9943 (invalidate_linux_cache_inf): Update.
9944 (linux_inferior_data_cleanup): Remove.
9945 (get_linux_inferior_data, _initialize_linux_tdep): Update.
9946
9947 2019-05-08 Tom Tromey <tom@tromey.com>
9948
9949 * auxv.c (auxv_inferior_data): Move. Change type.
9950 (auxv_inferior_data_cleanup): Remove.
9951 (invalidate_auxv_cache_inf): Rewrite.
9952 (get_auxv_inferior_data, _initialize_auxv): Update.
9953
9954 2019-05-08 Tom Tromey <tom@tromey.com>
9955
9956 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9957 (symfile_debug_objfile_data_key): Change type.
9958 (symfile_debug_installed, debug_qf_has_symbols)
9959 (debug_qf_find_last_source_symtab)
9960 (debug_qf_forget_cached_source_info)
9961 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9962 (debug_qf_print_stats, debug_qf_dump)
9963 (debug_qf_expand_symtabs_for_function)
9964 (debug_qf_expand_all_symtabs)
9965 (debug_qf_expand_symtabs_with_fullname)
9966 (debug_qf_map_matching_symbols)
9967 (debug_qf_expand_symtabs_matching)
9968 (debug_qf_find_pc_sect_compunit_symtab)
9969 (debug_qf_map_symbol_filenames)
9970 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9971 (debug_sym_new_init, debug_sym_init, debug_sym_read)
9972 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9973 (debug_sym_read_linetable, debug_sym_relocate): Update.
9974 (symfile_debug_free_objfile): Remove.
9975 (install_symfile_debug_logging, _initialize_symfile_debug):
9976 Update.
9977
9978 2019-05-08 Tom Tromey <tom@tromey.com>
9979
9980 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9981 allocate_on_obstack.
9982 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9983 (get_dwarf2_per_objfile): Update.
9984 (set_dwarf2_per_objfile): Remove.
9985 (dwarf2_has_info, dwarf2_get_section_info): Update.
9986 (dwarf2_free_objfile): Remove.
9987 (_initialize_dwarf2_read): Update.
9988
9989 2019-05-08 Tom Tromey <tom@tromey.com>
9990
9991 * auto-load.c (struct auto_load_pspace_info): Add destructor and
9992 initializers.
9993 <unsupported_script_warning_printed,
9994 script_not_found_warning_printed>: Now bool.
9995 (auto_load_pspace_data): Change type.
9996 (~auto_load_pspace_info): Rename from
9997 auto_load_pspace_data_cleanup.
9998 (get_auto_load_pspace_data, init_loaded_scripts_info)
9999 (clear_section_scripts, maybe_print_unsupported_script_warning)
10000 (maybe_print_script_not_found_warning, _initialize_auto_load):
10001 Update.
10002
10003 2019-05-08 Tom Tromey <tom@tromey.com>
10004
10005 * objfiles.c (objfile_pspace_info): Add destructor and
10006 initializers.
10007 (objfiles_pspace_data): Change type.
10008 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10009 (get_objfile_pspace_data): Update.
10010 (objfiles_bfd_data): Change type.
10011 (get_objfile_bfd_data): Update.
10012 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10013
10014 2019-05-08 Tom Tromey <tom@tromey.com>
10015
10016 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10017 Change type.
10018 (get_catch_syscall_inferior_data): Update.
10019 (catch_syscall_inferior_data_cleanup): Remove.
10020 (_initialize_break_catch_syscall): Update.
10021
10022 2019-05-08 Tom Tromey <tom@tromey.com>
10023
10024 * inflow.c (struct terminal_info): Add destructor and
10025 initializers.
10026 (inflow_inferior_data): Change type.
10027 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10028 (get_inflow_inferior_data, inflow_inferior_exit)
10029 (swap_terminal_info, _initialize_inflow): Update.
10030
10031 2019-05-08 Tom Tromey <tom@tromey.com>
10032
10033 * target-dcache.c (target_dcache_cleanup): Remove.
10034 (target_dcache_aspace_key): Change type.
10035 (target_dcache_init_p, target_dcache_invalidate)
10036 (target_dcache_get, target_dcache_get_or_init)
10037 (_initialize_target_dcache): Update.
10038 * dcache.h (struct dcache_deleter): New.
10039
10040 2019-05-08 Tom Tromey <tom@tromey.com>
10041
10042 * symtab.c (struct symbol_cache): Add destructor and
10043 initializers.
10044 (symbol_cache_key): Move. Change type.
10045 (make_symbol_cache, free_symbol_cache): Remove.
10046 (get_symbol_cache): Update.
10047 (symbol_cache_cleanup): Remove.
10048 (ALL_PSPACES, symbol_cache_flush)
10049 (maintenance_print_symbol_cache)
10050 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10051 Update.
10052
10053 2019-05-08 Tom Tromey <tom@tromey.com>
10054
10055 * symtab.c (struct main_info): Add destructor and initializers.
10056 (main_progspace_key): Move. Change type.
10057 (get_main_info): Update.
10058 (main_info_cleanup): Remove.
10059 (_initialize_symtab): Update.
10060
10061 2019-05-08 Tom Tromey <tom@tromey.com>
10062
10063 * registry.h (DECLARE_REGISTRY): Define the _key class.
10064
10065 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10066
10067 * NEWS: Merge two 'New commands' sections.
10068
10069 2019-05-08 Joel Brobecker <brobecker@adacore.com>
10070
10071 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10072 parameter and use Ada language definition instead.
10073 (ada_val_print_ptr): Remove unused language parameter.
10074 (ada_val_print_num): Remove language parameter and use Ada language
10075 definition instead.
10076 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10077 parameter.
10078 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10079 parameter and use Ada language definition instead.
10080 (ada_val_print_1): Update all ada_val_print_xxx calls.
10081 Remove language parameter.
10082 (ada_val_print): Update ada_val_print_1 call.
10083
10084 2019-05-08 Tom Tromey <tromey@adacore.com>
10085
10086 * remote.c (remote_hw_watchpoint_limit)
10087 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10088 Now static.
10089
10090 2019-05-08 Tom Tromey <tromey@adacore.com>
10091
10092 * maint.c (_initialize_maint_cmds): Move initialization code to
10093 remote.c.
10094 (watchdog, show_watchdog): Move to remote.c.
10095 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10096 "watchdog" static.
10097 (_initialize_remote): Move initialization code from maint.c.
10098 * defs.h (watchdog): Don't declare.
10099
10100 2019-05-08 Tom Tromey <tromey@adacore.com>
10101
10102 * tui/tui-interp.c: Include main.h.
10103 * interps.c: Include main.h.
10104 * main.h (interpreter_p): Declare.
10105 * defs.h (interpreter_p): Don't declare.
10106
10107 2019-05-08 Tom Tromey <tromey@adacore.com>
10108
10109 * dwarf2loc.c: Include dwarf2read.h.
10110 * defs.h (read_unsigned_leb128): Don't declare.
10111 * dwarf2read.h (read_unsigned_leb128): Declare.
10112
10113 2019-05-08 Tom Tromey <tromey@adacore.com>
10114
10115 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10116 method.
10117
10118 2019-05-08 Tom Tromey <tromey@adacore.com>
10119
10120 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10121 when no wrap column is set.
10122
10123 2019-05-08 Tom Tromey <tromey@adacore.com>
10124
10125 * c-lang.c (c_get_string): Handle non-C-style arrays.
10126
10127 2019-05-08 Tom Tromey <tromey@adacore.com>
10128
10129 * typeprint.c (print_offset_data::update): Print the bit offset,
10130 not the number of bits remaining.
10131
10132 2019-05-08 Tom Tromey <tromey@adacore.com>
10133
10134 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10135 padding at end of comment.
10136
10137 2019-05-08 Tom Tromey <tromey@adacore.com>
10138
10139 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10140 Compare main types.
10141
10142 2019-05-06 Tom Tromey <tom@tromey.com>
10143
10144 * common/scoped_mmap.c: Include common-defs.h.
10145 * common/scoped_mmap.h: Don't include config.h.
10146
10147 2019-05-04 Tom Tromey <tom@tromey.com>
10148
10149 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10150 (struct aarch64_call_info): Add initializers.
10151 <si>: Now a std::vector.
10152 (pass_on_stack, aarch64_push_dummy_call): Update.
10153
10154 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
10155 Tom Tromey <tom@tromey.com>
10156
10157 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10158 (ppc_threads): Now a std::vector. Now static.
10159 (hwdebug_find_thread_points_by_tid)
10160 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10161 Update.
10162
10163 2019-05-04 Tom Tromey <tom@tromey.com>
10164
10165 * arc-tdep.c (arc_tdesc_init): Return bool.
10166
10167 2019-05-04 Tom Tromey <tom@tromey.com>
10168
10169 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10170 Use gdb_assert_not_reached.
10171
10172 2019-05-04 Tom Tromey <tom@tromey.com>
10173
10174 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10175 "false".
10176
10177 2019-05-04 Tom Tromey <tom@tromey.com>
10178
10179 * arc-tdep.c (arc_tdesc_init): Use bool.
10180
10181 2019-05-04 Tom Tromey <tom@tromey.com>
10182
10183 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10184
10185 2019-05-04 Tom Tromey <tom@tromey.com>
10186
10187 * cli/cli-cmds.c (valid_command_p): Return bool.
10188
10189 2019-05-04 Tom Tromey <tom@tromey.com>
10190
10191 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10192 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10193
10194 2019-05-04 Raul Tambre <raul@tambre.ee>
10195
10196 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10197 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10198 operator for comparison.
10199
10200 2019-05-04 Tom Tromey <tom@tromey.com>
10201
10202 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10203 (lookup_partial_symbol, print_partial_symbols)
10204 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10205 (psymbol_compare): Update.
10206 (add_psymbol_to_bcache): Clear the entire psymbol.
10207 (maintenance_check_psymtabs): Update.
10208 * psympriv.h (struct partial_symbol): Don't derive from
10209 general_symbol_info.
10210 <obj_section, unrelocated_address, address,
10211 set_unrelocated_address>: Update.
10212 <ginfo>: New member.
10213 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10214 (debug_names::write_psymbols): Update.
10215
10216 2019-05-04 Tom de Vries <tdevries@suse.de>
10217
10218 * contrib/cc-with-tweaks.sh: Support -n arg.
10219
10220 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10221
10222 * corelow.c (core_target::detach): Ensure frame cache and
10223 register caches are cleared.
10224 inferior.c (exit_inferior_1): Likewise.
10225
10226 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10227 Tom Tromey <tom@tromey.com>
10228
10229 * dictionary.c (collate_pending_symbols_by_language): Remove
10230 "struct" from foreach.
10231 * symtab.c (lookup_global_symbol_from_objfile)
10232 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10233 foreach.
10234 * ser-tcp.c (net_open): Remove "struct" from foreach.
10235 * objfiles.c (objfile_relocate, objfile_rebase)
10236 (objfile_has_symbols): Remove "struct" from foreach.
10237 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10238 from foreach.
10239 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10240 foreach.
10241 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10242 "struct" from foreach.
10243 * ada-lang.c (create_excep_cond_exprs)
10244 (ada_exception_catchpoint_cond_string): Remove "struct" from
10245 foreach.
10246
10247 2019-05-03 Tom Tromey <tromey@adacore.com>
10248
10249 * ada-exp.y (convert_char_literal): Check suffix of each
10250 enumerator.
10251
10252 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10253
10254 PR ada/21406:
10255 * ada-exp.y (yywrap): Don't define.
10256 * ada-lex.l (%option): Add noyywrap
10257 (yywrap): Remove.
10258
10259 2019-05-03 Eli Zaretskii <eliz@gnu.org>
10260
10261 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10262 _WIN32_WINNT to the XP level, unless already defined to a higher
10263 level.
10264
10265 * unittests/parse-connection-spec-selftests.c:
10266 * ser-tcp.c:
10267 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10268 override.
10269
10270 * symfile.c (find_separate_debug_file): Remove colon from the
10271 drive spec of DOS/Windows file names of the target, so that the
10272 file name produced from DEBUGDIR and the target's directory will
10273 be valid on DOS/Windows systems.
10274
10275 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10276
10277 * rust-lang.c (val_print_struct): Handle printing structures
10278 containing strings.
10279
10280 2019-05-02 Tom Tromey <tromey@adacore.com>
10281
10282 * valarith.c (_initialize_valarith): Remove.
10283
10284 2019-05-01 Tom Tromey <tromey@adacore.com>
10285
10286 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10287 bitfields.
10288
10289 2019-05-01 Tom Tromey <tromey@adacore.com>
10290
10291 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10292 for big-endian copies.
10293
10294 2019-04-30 Ali Tamur <tamur@google.com>
10295 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10296 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10297 (read_3_bytes): New function.
10298
10299 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10300
10301 * windows-nat.c (main_thread_id): Delete.
10302 (handle_output_debug_string): Replace main_thread_id by
10303 current_event.dwThreadId.
10304 (fake_create_process): Likewise.
10305 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10306 Do not set main_thread_id.
10307 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10308 current_event.dwThreadId.
10309 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10310
10311 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10312
10313 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10314 Use current_event.dwThreadId instead of main_thread_id.
10315
10316 2019-04-30 Tom Tromey <tromey@adacore.com>
10317
10318 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10319 (create_excep_cond_exprs): Iterate over program spaces.
10320 (ada_exception_catchpoint_cond_string): Examine all minimal
10321 symbols for exception types.
10322
10323 2019-04-30 Tom Tromey <tromey@adacore.com>
10324
10325 PR c++/24470:
10326 * dwarf2read.c (process_structure_scope): Handle case where type
10327 has template parameters but no symbol was created.
10328
10329 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10330 Chris January <chris.january@arm.com>
10331
10332 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10333 qualifier.
10334 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10335
10336 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10337
10338 * f-typeprint.c (f_print_type): Update rules for printing
10339 whitespace.
10340 (f_type_print_varspec_suffix): Likewise.
10341
10342 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10343 Chris January <chris.january@arm.com>
10344
10345 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10346 function arguments.
10347
10348 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10349
10350 * f-lang.c (build_fortran_types): Change name of void type to
10351 lower case.
10352 * f-typeprint.c (f_type_print_base): Print the name of the void
10353 type, rather than a fixed string.
10354 * f-valprint.c (f_decorations): Use lower case void string.
10355
10356 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10357 Chris January <chris.january@arm.com>
10358
10359 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10360 types for Fortran.
10361
10362 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10363 Chris January <chris.january@arm.com>
10364 David Lecomber <david.lecomber@arm.com>
10365
10366 * f-exp.y (BINOP_INTRINSIC): New token.
10367 (exp): New parser rule handling BINOP_INTRINSIC.
10368 (f77_keywords): Add new builtin procedures.
10369 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10370 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10371 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10372 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10373 (print_unop_subexp_f): New function.
10374 (print_binop_subexp_f): New function.
10375 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10376 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10377 (dump_subexp_body_f): Likewise.
10378 (operator_check_f): Likewise.
10379 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10380 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10381
10382 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10383
10384 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10385 UNOP_KIND.
10386 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10387 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10388 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10389 (operator_length_f): New fuction.
10390 (print_subexp_f): New function.
10391 (op_name_f): New function.
10392 (dump_subexp_body_f): New function.
10393 (operator_check_f): New function.
10394 (exp_descriptor_f): Replace standard expression handling functions
10395 with new functions.
10396 * gdb/fortran-operator.def: New file.
10397 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10398 * gdb/std-operator.def: Remove UNOP_KIND.
10399
10400 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10401
10402 * std-operator.def: Remove unbalanced, stray double quote
10403 character.
10404
10405 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10406 Chris January <chris.january@arm.com>
10407 Daniel Everett <daniel.everett@arm.com>
10408 Nick Forrington <nick.forrington@arm.com>
10409 Richard Bunt <richard.bunt@arm.com>
10410
10411 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10412 of depth when printing anonymous structs or unions.
10413 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10414 Don't print either the top-level value, or the children if the
10415 max-depth is exceeded.
10416 (ppscm_print_children): When printing the key of a map, allow one
10417 extra level of depth.
10418 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10419 print either the top-level value, or the children if the max-depth
10420 is exceeded.
10421 (print_children): When printing the key of a map, allow one extra
10422 level of depth.
10423 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10424 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10425 (user_print_options): Initialise max_depth field.
10426 (val_print_scalar_or_string_type_p): New function.
10427 (val_print): Check to see if the max depth has been reached.
10428 (val_print_check_max_depth): Define new function.
10429 (show_print_max_depth): New function.
10430 (_initialize_valprint): Add 'print max-depth' option.
10431 * valprint.h (struct value_print_options) <max_depth>: New field.
10432 (val_print_check_max_depth): Declare new function.
10433 * NEWS: Document new feature.
10434
10435 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10436
10437 * ada-lang.c (ada_language_defn): Initialise new field.
10438 * c-lang.c (c_is_string_type_p): New function.
10439 (c_language_defn): Initialise new field.
10440 (cplus_language_defn): Initialise new field.
10441 (asm_language_defn): Initialise new field.
10442 (minimal_language_defn): Initialise new field.
10443 * c-lang.h (c_is_string_type_p): Declare new function.
10444 * d-lang.c (d_language_defn): Initialise new field.
10445 * f-lang.c (f_is_string_type_p): New function.
10446 (f_language_defn): Initialise new field.
10447 * go-lang.c (go_is_string_type_p): New function.
10448 (go_language_defn): Initialise new field.
10449 * language.c (default_is_string_type_p): New function.
10450 (unknown_language_defn): Initialise new field.
10451 (auto_language_defn): Initialise new field.
10452 * language.h (struct language_defn) <la_is_string_type_p>: New
10453 member variable.
10454 (default_is_string_type_p): Declare new function.
10455 * m2-lang.c (m2_language_defn): Initialise new field.
10456 * objc-lang.c (objc_language_defn): Initialise new field.
10457 * opencl-lang.c (opencl_language_defn): Initialise new field.
10458 * p-lang.c (pascal_is_string_type_p): New function.
10459 (pascal_language_defn): Initialise new field.
10460 * rust-lang.c (rust_is_string_type_p): New function.
10461 (rust_language_defn): Initialise new field.
10462
10463 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10464
10465 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10466 New field.
10467 * ada-lang.c (ada_language_defn): Initialise new field.
10468 * c-lang.c (c_language_defn): Likewise.
10469 (cplus_language_defn): Likewise.
10470 (asm_language_defn): Likewise.
10471 (minimal_language_defn): Likewise.
10472 * d-lang.c (d_language_defn): Likewise.
10473 * f-lang.c (f_language_defn): Likewise.
10474 * go-lang.c (go_language_defn): Likewise.
10475 * language.c (unknown_language_defn): Likewise.
10476 (auto_language_defn): Likewise.
10477 * m2-lang.c (m2_language_defn): Likewise.
10478 * objc-lang.c (objc_language_defn): Likewise.
10479 * opencl-lang.c (opencl_language_defn): Likewise.
10480 * p-lang.c (pascal_language_defn): Likewise.
10481 * rust-lang.c (rust_language_defn): Likewise.
10482
10483 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10484
10485 * ada-lang.c (ada_is_character_type): Change return type to bool.
10486 (ada_is_string_type): Likewise.
10487 * ada-lang.h (ada_is_character_type): Update declaration
10488 (ada_is_string_type): Likewise.
10489
10490 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10491
10492 Support style in 'frame|thread apply'
10493
10494 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10495 * record.c (record_start, record_stop): Update callers of
10496 execute_command_to_string with false.
10497 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10498 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10499 methods.
10500 (class string_file): New constructor with term_out parameter.
10501 Override methods term_out and can_emit_style_escape. New member
10502 term_out.
10503 (class stdio_file): Override can_emit_style_escape.
10504 (class tee_file): Override term_out and can_emit_style_escape.
10505 * utils.h (can_emit_style_escape): Remove.
10506 * utils.c (can_emit_style_escape): Likewise.
10507 Update all callers of can_emit_style_escape (SOMESTREAM) to
10508 SOMESTREAM->can_emit_style_escape.
10509 * source-cache.c (source_cache::get_source_lines): Likewise.
10510 * stack.c (frame_apply_command_count): Call execute_command_to_string
10511 passing the term_out characteristic of the current gdb_stdout.
10512 * thread.c (thr_try_catch_cmd): Likewise.
10513 * top.c (execute_command_to_string): pass term_out parameter
10514 to construct the string_file for the command output.
10515 * ui-file.c (term_cli_styling): New function (most code moved
10516 from utils.c can_emit_style_escape).
10517 (string_file::string_file, string_file::can_emit_style_escape,
10518 stdio_file::can_emit_style_escape, tee_file::term_out,
10519 tee_file::can_emit_style_escape): New functions.
10520
10521 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10522
10523 * NEWS: Mention the new set|show may-call-functions.
10524 * infcall.c (may_call_functions_p): New variable.
10525 (show_may_call_functions_p): New function.
10526 (call_function_by_hand_dummy): Throws an error if not
10527 may-call-functions.
10528 (_initialize_infcall): Call add_setshow_boolean_cmd for
10529 may-call-functions.
10530
10531 2019-04-25 Keith Seitz <keiths@redhat.com>
10532
10533 PR c++/24367
10534 * cp-support.c (inspect_type): Don't attempt substitutions
10535 of symbol with the same name.
10536
10537 2019-04-25 Tom Tromey <tromey@adacore.com>
10538
10539 PR gdb/24475:
10540 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10541 static.
10542
10543 2019-04-25 Tom Tromey <tromey@adacore.com>
10544
10545 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10546 rvalue reference.
10547 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10548 (gdb_xml_parser::parse): Use std::move.
10549 * python/python-internal.h (gdbpy_convert_exception): Take a const
10550 reference.
10551 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10552 std::move.
10553 * python/py-utils.c (gdbpy_convert_exception): Take a const
10554 reference.
10555 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10556 Use std::move.
10557 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10558 Use std::move.
10559 * mi/mi-main.c (mi_print_exception): Take a const reference.
10560 * main.c (handle_command_errors): Take a const reference.
10561 * linespec.c (parse_linespec): Use std::move.
10562 * infcall.c (run_inferior_call): Use std::move.
10563 (call_function_by_hand_dummy): Use std::move.
10564 * exec.c (try_open_exec_file): Use std::move.
10565 * exceptions.h (exception_print, exception_fprintf)
10566 (exception_print_same): Update.
10567 * exceptions.c (print_exception, exception_print)
10568 (exception_fprintf, exception_print_same): Change parameters to
10569 const reference.
10570 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10571 * common/new-op.c: Use std::move.
10572 * common/common-exceptions.h (struct gdb_exception): Add move
10573 constructor.
10574 (struct gdb_exception_error, struct gdb_exception_quit, struct
10575 gdb_quit_bad_alloc): Change constructor to move constructor.
10576 (throw_exception): Change parameter to rvalue reference.
10577 * common/common-exceptions.c (throw_exception): Take rvalue
10578 reference.
10579 * cli/cli-interp.c (safe_execute_command): Use std::move.
10580 * breakpoint.c (insert_bp_location, location_to_sals): Use
10581 std::move.
10582
10583 2019-04-25 Tom Tromey <tromey@adacore.com>
10584
10585 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10586 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10587 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10588 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10589 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10590 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10591 guile/scm-value.c: Use unpack.
10592 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10593 gdbscm_gdb_exception.
10594 (gdbscm_throw_gdb_exception): Likewise.
10595 (struct gdbscm_gdb_exception): New.
10596 (unpack): New function.
10597 (gdbscm_wrap): Use unpack.
10598
10599 2019-04-25 Tom Tromey <tromey@adacore.com>
10600
10601 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10602 (gdb_rl_callback_handler): Use std::move.
10603 * common/common-exceptions.h (struct gdb_exception): Add move
10604 assignment operator.
10605 (throw_exception_sjlj): Change "exception" to const reference.
10606 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10607 (throw_exception_sjlj): Change "exception" to const reference.
10608
10609 2019-04-25 Tom Tromey <tromey@adacore.com>
10610
10611 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10612 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10613 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10614 Update.
10615 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10616 Update.
10617 * mi/mi-interp.c (mi_interp::exec): Update.
10618 * linespec.c (parse_linespec): Update.
10619 * infcall.c (run_inferior_call): Update.
10620 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10621 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10622 (gdbscm_lookup_global_symbol): Update.
10623 * guile/scm-param.c (gdbscm_parameter_value): Update.
10624 * guile/scm-frame.c (gdbscm_frame_read_register)
10625 (gdbscm_frame_read_var): Update.
10626 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10627 * exec.c (try_open_exec_file): Update.
10628 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10629 (gdb_rl_callback_handler): Update.
10630 * common/common-exceptions.h (exception_none): Don't declare.
10631 * common/common-exceptions.c (exception_none): Don't define.
10632 (struct catcher) <exception>: Update.
10633 * cli/cli-interp.c (safe_execute_command): Update.
10634 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10635
10636 2019-04-25 Ali Tamur <tamur@google.com>
10637
10638 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10639 (read_attribute_value): Likewise.
10640 (dwarf2_read_addr_index): Update comment.
10641 (read_str_index): Add DW_FORM_strx.
10642 (dwarf2_string_attr): Likewise.
10643 (dwarf2_const_value_attr): Likewise.
10644 (dump_die_shallow): Likewise.
10645 (dwarf2_fetch_constant_bytes): Likewise.
10646 (skip_form_bytes): Likewise.
10647 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10648
10649 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10650
10651 PR corefiles/11608
10652 PR corefiles/18187
10653 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10654 OFFSET. Verify if current mapping contains an ELF header.
10655 (linux_find_memory_regions_full): Adjust call to
10656 dump_mapping_p.
10657
10658 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10659 Kang Li <kanglictf@gmail.com>
10660
10661 PR gdb/21600
10662
10663 * dwarf2-frame.c (read_initial_length): Be consistent about using
10664 unsigned representation of length.
10665 (decode_frame_entry_1): Likewise. Check for wraparound of
10666 end pointer as well as buffer overflow.
10667
10668 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10669
10670 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10671 "vq".
10672
10673 2019-04-24 Tom Tromey <tromey@adacore.com>
10674
10675 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10676
10677 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10678
10679 * s12z-tdep.c (s12z_unwind_pc): Delete.
10680 (s12z_unwind_sp): Delete.
10681 (s12z_gdbarch_init): Don't register deleted functions with
10682 gdbarch.
10683
10684 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10685
10686 * rl78-tdep.c (rl78_unwind_sp): Delete.
10687 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10688
10689 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10690
10691 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10692 (xstormy16_unwind_pc): Delete.
10693 (xstormy16_dummy_id): Delete.
10694 (xstormy16_gdbarch_init): Don't register deleted functions with
10695 gdbarch.
10696
10697 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10698
10699 * vax-tdep.c (vax_unwind_pc): Delete.
10700 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10701
10702 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10703
10704 * v850-tdep.c (v850_unwind_sp): Delete.
10705 (v850_unwind_pc): Delete.
10706 (v850_dummy_id): Delete.
10707 (v850_gdbarch_init): Don't register deleted functions with
10708 gdbarch.
10709
10710 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10711
10712 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10713 (tilegx_unwind_pc): Delete.
10714 (tilegx_unwind_dummy_id): Delete.
10715 (tilegx_gdbarch_init): Don't register deleted functions with
10716 gdbarch.
10717
10718 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10719
10720 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10721 (tic6x_dummy_id): Delete.
10722 (tic6x_gdbarch_init): Don't register deleted functions with
10723 gdbarch.
10724
10725 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10726
10727 * sparc-tdep.c (sparc_unwind_pc): Delete.
10728 (sparc32_gdbarch_init): Don't register deleted function with
10729 gdbarch.
10730
10731 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10732
10733 * sh-tdep.c (sh_unwind_sp): Delete.
10734 (sh_unwind_pc): Delete.
10735 (sh_dummy_id): Delete.
10736 (sh_gdbarch_init): Don't register deleted functions with
10737 gdbarch.
10738
10739 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10740
10741 * score-tdep.c (score_unwind_sp): Delete.
10742 (score_unwind_pc): Delete.
10743 (score_dummy_id): Delete.
10744 (score_gdbarch_init): Don't register deleted functions with
10745 gdbarch.
10746
10747 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10748
10749 * rx-tdep.c (rx_unwind_pc): Delete.
10750 (rx_unwind_sp): Delete.
10751 (rx_dummy_id): Delete.
10752 (rx_gdbarch_init): Don't register deleted functions with
10753 gdbarch. Update comment.
10754
10755 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10756
10757 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10758 (rs6000_dummy_id): Delete.
10759 (rs6000_gdbarch_init): Don't register deleted functions with
10760 gdbarch.
10761
10762 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10763
10764 * or1k-tdep.c (or1k_dummy_id): Delete.
10765 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10766
10767 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10768
10769 * nios2-tdep.c (nios2_dummy_id): Delete.
10770 (nios2_unwind_sp): Delete.
10771 (nios2_gdbarch_init): Don't register deleted functions with
10772 gdbarch.
10773
10774 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10775
10776 * nds32-tdep.c (nds32_dummy_id): Delete.
10777 (nds32_unwind_pc): Delete.
10778 (nds32_unwind_sp): Delete.
10779 (nds32_gdbarch_init): Don't register deleted functions with
10780 gdbarch.
10781
10782 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10783
10784 * msp430-tdep.c (msp430_unwind_pc): Delete.
10785 (msp430_unwind_sp): Delete.
10786 (msp430_dummy_id): Delete.
10787 (msp430_gdbarch_init): Don't register deleted functions with
10788 gdbarch.
10789
10790 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10791
10792 * moxie-tdep.c (moxie_unwind_sp): Delete.
10793 (moxie_unwind_pc): Delete.
10794 (moxie_dummy_id): Delete.
10795 (moxie_gdbarch_init): Don't register deleted functions with
10796 gdbarch.
10797
10798 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10799
10800 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10801 (mn10300_unwind_pc): Delete.
10802 (mn10300_unwind_sp): Delete.
10803 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10804 mn10300_unwind_sp.
10805 (mn10300_frame_unwind_init): Don't register deleted functions with
10806 gdbarch.
10807
10808 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10809
10810 * mep-tdep.c (mep_unwind_pc): Delete.
10811 (mep_unwind_sp): Delete.
10812 (mep_dummy_id): Delete.
10813 (mep_gdbarch_init): Don't register deleted functions with
10814 gdbarch.
10815
10816 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10817
10818 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10819 (m68hc11_unwind_sp): Delete.
10820 (m68hc11_gdbarch_init): Don't register deleted functions with
10821 gdbarch.
10822
10823 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10824
10825 * m32r-tdep.c (m32r_unwind_sp): Delete.
10826 (m32r_unwind_pc): Delete.
10827 (m32r_dummy_id): Delete.
10828 (m32r_gdbarch_init): Don't register deleted functions with
10829 gdbarch.
10830
10831 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10832
10833 * m32c-tdep.c (m32c_unwind_pc): Delete.
10834 (m32c_unwind_sp): Delete.
10835 (m32c_dummy_id): Delete.
10836 (m32c_gdbarch_init): Don't register deleted functions with
10837 gdbarch.
10838
10839 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10840
10841 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10842 (lm32_unwind_pc): Delete.
10843 (lm32_dummy_id): Delete.
10844 (lm32_gdbarch_init): Don't register deleted functions with
10845 gdbarch.
10846
10847 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10848
10849 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10850 (iq2000_unwind_pc): Delete.
10851 (iq2000_dummy_id): Delete.
10852 (iq2000_gdbarch_init): Don't register deleted functions with
10853 gdbarch.
10854
10855 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10856
10857 * nds32-tdep.c (nds32_type_align): Delete.
10858 (nds32_push_dummy_call): Use type_align instead.
10859
10860 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10861
10862 * arm-tdep.c (arm_type_align): Only handle vector override case.
10863 (arm_push_dummy_call): Use type_align.
10864 (arm_gdbarch_init): Register arm_type_align gdbarch function.
10865
10866 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10867
10868 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10869 case.
10870 (pass_on_stack): Use type_align.
10871 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10872 function.
10873
10874 2019-04-23 Tom Tromey <tromey@adacore.com>
10875
10876 * dwarf2read.c (line_header::file_name_at): Remove unused
10877 overload.
10878
10879 2019-04-23 Tom de Vries <tdevries@suse.de>
10880
10881 PR gdb/24438
10882 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10883 invocation.
10884
10885
10886 2019-03-27 Ali Tamur <tamur@google.com>
10887
10888 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10889 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10890 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10891 (dwarf_expr_context::get_addr_index): Likewise
10892 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10893 (symbol_needs_eval_context::get_addr_index): Likewise
10894 (disassemble_dwarf_expression): Add DW_OP_addrx
10895 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10896 (read_cutu_die_from_dwo): Update comment
10897 (skip_one_die): Add DW_FORM_addrx
10898 (read_attribute_value): Likewise
10899 (var_decode_location): Add DW_OP_addrx
10900 (dwarf2_const_value_attr): Add DW_FORM_addrx
10901 (dump_die_shallow): Likewise
10902 (dwarf2_fetch_constant_bytes): Likewise
10903 (decode_locdesc): Add DW_OP_addrx
10904 (skip_form_bytes): Add DW_FORM_addrx
10905
10906 2019-04-22 Ali Tamur <tamur@google.com>
10907
10908 * MAINTAINERS (Write After Approval): Add self.
10909
10910 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
10911
10912 * solib-svr4.c (get_svr4_info): Add pspace parameter.
10913 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10914 (open_symbol_file_object): Likewise.
10915 (svr4_default_sos): Add info parameter.
10916 (svr4_read_so_list): Likewise.
10917 (svr4_current_sos_direct): Adjust functions calls to pass down
10918 info.
10919 (svr4_current_sos_1): Add info parameter.
10920 (svr4_current_sos): Call get_svr4_info, pass info down to
10921 svr4_current_sos_1.
10922 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10923 get_svr4_info.
10924 (svr4_in_dynsym_resolve_code): Pass current_program_space to
10925 get_svr4_info.
10926 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10927 to get_svr4_info.
10928 (probes_table_remove_objfile_probes): Likewise.
10929 (register_solib_event_probe): Add info parameter.
10930 (solist_update_incremental): Pass info parameter down to
10931 svr4_read_so_list.
10932 (disable_probes_interface): Add info parameter.
10933 (svr4_handle_solib_event): Pass current_program_space to
10934 get_svr4_info. Adjust disable_probes_interface cleanup.
10935 (svr4_create_probe_breakpoints): Add info parameter, pass it
10936 down to register_solib_event_probe.
10937 (svr4_create_solib_event_breakpoints): Add info parameter,
10938 pass it down to svr4_create_probe_breakpoints.
10939 (enable_break): Pass info down to
10940 svr4_create_solib_event_breakpoints.
10941 (svr4_solib_create_inferior_hook): Pass current_program_space to
10942 get_svr4_info.
10943 (svr4_clear_solib): Likewise.
10944
10945 2019-04-22 Pedro Alves <palves@redhat.com>
10946
10947 * solib-svr4.c (svr4_free_objfile_observer): New.
10948 (probe_and_action::objfile): New field.
10949 (probes_table_htab_remove_objfile_probes)
10950 (probes_table_remove_objfile_probes): New functions.
10951 (register_solib_event_probe): Add 'objfile' parameter. Store it
10952 in the new probe_and_action. Don't store the probe in 'lookup'.
10953 (svr4_create_probe_breakpoints): Pass objfile to
10954 register_solib_event_probe.
10955 (_initialize_svr4_solib): Register a free_objfile observer.
10956
10957 2019-04-19 Tom Tromey <tom@tromey.com>
10958
10959 * common/queue.h: Remove.
10960
10961 2019-04-19 Tom Tromey <tom@tromey.com>
10962
10963 * event-loop.c: Don't include "common/queue.h".
10964
10965 2019-04-19 Tom Tromey <tom@tromey.com>
10966
10967 * remote.c (remote_target): Use delete.
10968 * remote-notif.h: Include <list>, not "common/queue.h".
10969 (notif_client_p): Remove typedef.
10970 (remote_notif_state): Add constructor, destructor, initializer.
10971 <notif_queue>: Now a std::list.
10972 (remote_notif_state_xfree): Don't declare.
10973 * remote-notif.c (remote_notif_process, handle_notification)
10974 (remote_notif_state_allocate): Update.
10975 (~remote_notif_state): Rename from remote_notif_state_xfree.
10976
10977 2019-04-19 Tom Tromey <tom@tromey.com>
10978
10979 * symfile.c (reread_symbols): Update.
10980 * objfiles.c (objfile_register_static_link)
10981 (objfile_lookup_static_link): Update
10982 (~objfile) Don't delete static_links.
10983 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10984
10985 2019-04-19 Tom Tromey <tom@tromey.com>
10986
10987 * type-stack.h (struct type_stack) <insert>: Constify string.
10988 * type-stack.c (type_stack::insert): Constify string.
10989 * gdbtypes.h (lookup_template_type): Update.
10990 (address_space_name_to_int): Update.
10991 * gdbtypes.c (address_space_name_to_int): Make space_identifier
10992 const.
10993 (lookup_template_type): Make name const.
10994 * c-exp.y: Update rules.
10995 (lex_one_token, classify_name, classify_inner_name)
10996 (c_print_token): Update.
10997 * p-exp.y: Update rules.
10998 (yylex): Update.
10999 * f-exp.y: Update rules.
11000 (yylex): Update.
11001 * d-exp.y: Update rules.
11002 (lex_one_token, classify_name, classify_inner_name): Update.
11003 * parse.c (write_dollar_variable, copy_name): Return std::string.
11004 * parser-defs.h (copy_name): Change return type.
11005 * m2-exp.y: Update rules.
11006 (yylex): Update.
11007 * go-exp.y (lex_one_token): Update.
11008 Update rules.
11009 (classify_unsafe_function, classify_packaged_name)
11010 (classify_name, yylex): Update.
11011
11012 2019-04-19 Sergei Trofimovich <siarheit@google.com>
11013
11014 * configure.ac: add --enable-source-highlight switch.
11015 * configure: Regenerate.
11016 * top.c (print_gdb_version): plumb --enable-source-highlight
11017 status to "show configuration".
11018
11019 2019-04-19 Tom Tromey <tromey@adacore.com>
11020
11021 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11022 Check ADA_TYPE_P.
11023 (empty_record, ada_template_to_fixed_record_type_1)
11024 (template_to_static_fixed_type)
11025 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11026 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11027 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11028 macros.
11029
11030 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11031
11032 PR symtab/24423:
11033 * source.c (print_source_lines_base): Advance "iter" when a
11034 control character is seen.
11035
11036 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11037
11038 * inferior.h (struct infcall_suspend_state_deleter):
11039 Catch exception in destructor to avoid crash.
11040
11041 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11042
11043 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11044 close to the add_com "shell".
11045
11046 2019-04-18 Tom Tromey <tromey@adacore.com>
11047
11048 * process-stratum-target.h (class process_stratum_target)
11049 <stratum>: Add "final".
11050
11051 2019-04-17 Tom Tromey <tromey@adacore.com>
11052
11053 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11054 against nullptr before use.
11055
11056 2019-04-17 Alan Hayward <alan.hayward@arm.com>
11057
11058 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11059
11060 2019-04-17 Jim Wilson <jimw@sifive.com>
11061 Andrew Burgess <andrew.burgess@embecosm.com>
11062
11063 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11064 code read might fail, assume 4-byte breakpoint in that case.
11065
11066 2019-04-15 Leszek Swirski <leszeks@google.com>
11067
11068 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11069 rather than a hand-rolled POD check when checking for forced MEMORY
11070 classification.
11071
11072 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11073
11074 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11075 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11076 function.
11077 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11078 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11079 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11080 declaration.
11081
11082 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11083
11084 * aarch64-linux-nat.c
11085 (aarch64_linux_nat_target::thread_architecture): Add override.
11086 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11087 each VQ.
11088
11089 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11090
11091 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11092
11093 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11094
11095 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11096 target types of size 96-bits, add some additional comments, and
11097 check that the builtin type we found was the correct size.
11098
11099 2019-04-12 Eli Zaretskii <eliz@gnu.org>
11100
11101 * utils.c (prompt_for_continue): Don't restore the styling at the
11102 end, as applied_style has the wrong value. This fixes styling in
11103 long lists of file names that are interrupted by the "Continue?"
11104 prompt.
11105
11106 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11107
11108 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11109 * c-lang.c (c_language_defn): Likewise.
11110 (cplus_language_defn): Likewise.
11111 (asm_language_defn): Likewise.
11112 (minimal_language_defn): Likewise.
11113 * d-lang.c (d_language_defn): Likewise.
11114 * f-lang.c (f_language_defn): Likewise.
11115 * go-lang.c (go_language_defn): Likewise.
11116 * language.c (unknown_language_defn): Likewise.
11117 (auto_language_defn): Likewise.
11118 * language.h (struct language_defn): Remove la_magic field.
11119 (LANG_MAGIC): Delete.
11120 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11121 * objc-lang.c (objc_language_defn): Likewise.
11122 * opencl-lang.c (opencl_language_defn): Likewise.
11123 * p-lang.c (pascal_language_defn): Likewise.
11124 * rust-lang.c (rust_language_defn): Likewise.
11125
11126 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11127
11128 * riscv-tdep.c (riscv_type_align): New function.
11129 (riscv_type_alignment): Delete.
11130 (riscv_arg_location): Use 'type_align'.
11131 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11132
11133 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11134
11135 * gdbtypes.c (type_align): A struct with no non-static fields also
11136 has alignment of 1.
11137
11138 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11139
11140 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11141 component to 0.
11142 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11143 member.
11144 (riscv_struct_info::analyse): New implementation using new
11145 analyse_inner member function.
11146 (riscv_struct_info::field_offset): New member function.
11147 (riscv_struct_info::m_offsets): New member variable.
11148 (riscv_struct_info::analyse_inner): New private member function,
11149 takes the old implementation of riscv_struct_info::analyse but
11150 extended to track field offsets.
11151 (riscv_call_arg_struct): Update the struct folding special cases
11152 to handle cases where empty C++ structs, which are non-zero
11153 length, are found.
11154 (riscv_arg_location): Initialise the length of each location, a
11155 non-zero length now indicates the location is in use.
11156 (riscv_push_dummy_call): Allow for the first location having a
11157 non-zero offset when setting up arguments.
11158 (riscv_return_value): Likewise, but for return values.
11159
11160 2019-04-11 Tom Tromey <tromey@adacore.com>
11161
11162 * utils.c (internal_vproblem): Make "msg" const.
11163
11164 2019-04-11 Alan Hayward <alan.hayward@arm.com>
11165
11166 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11167 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11168 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11169 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11170
11171 2019-04-10 Kevin Buettner <kevinb@redhat.com>
11172
11173 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11174 function.
11175 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11176 of amd64_collect_native_gregset.
11177 (amd64_linux_nat_target::store_registers): Likewise.
11178
11179 2019-04-10 Tom Tromey <tom@tromey.com>
11180
11181 * symtab.c (lookup_global_symbol_from_objfile)
11182 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11183 * objfiles.h (class separate_debug_iterator): New.
11184 (class separate_debug_range): New.
11185 (struct objfile) <separate_debug_objfiles>: New method.
11186 (objfile_separate_debug_iterate): Don't declare.
11187 * objfiles.c (separate_debug_iterator::operator++): Rename from
11188 objfile_separate_debug_iterate.
11189 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11190 iterator.
11191 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11192 iterator.
11193
11194 2019-04-10 Tom Tromey <tom@tromey.com>
11195
11196 * symfile.c (reread_symbols): Remove old comment.
11197 * objfiles.c (free_all_objfiles): Fix a typo.
11198
11199 2019-04-10 Tom Tromey <tom@tromey.com>
11200
11201 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11202 * minsyms.c (lookup_minimal_symbol): Use foreach.
11203 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11204 (lookup_minimal_symbol_solib_trampoline): Likewise.
11205 * symfile.c (reread_symbols): Use foreach.
11206
11207 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
11208 Tom Tromey <tromey@adacore.com>
11209
11210 PR rust/24414:
11211 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11212 (rust_lex_int_test): Change "value" to be LONGEST.
11213 (rust_lex_tests): Add test for long integer literal.
11214
11215 2019-04-09 Tom Tromey <tromey@adacore.com>
11216
11217 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11218 to bool.
11219 (extended_remote_target::attach): Update.
11220 (remote_target::remote_notice_new_inferior): Update.
11221 (remote_target::add_current_inferior_and_thread): Update.
11222 * inferior.c (exit_inferior_1): Use "false".
11223 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11224
11225 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
11226
11227 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11228 the "start" command.
11229
11230 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11231
11232 * python/py-inferior.c (infpy_thread_from_thread_handle):
11233 Adjust comments to reflect renaming of thread_from_thread_handle
11234 to thread_from_handle. Adjust keywords. Fix type error message.
11235 (inferior_object_methods): Add thread_from_handle. Retain
11236 thread_from_thread_handle, but mark it as deprecated.
11237
11238 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11239
11240 * gdbthread.h (find_thread_by_handle): Revise declaration.
11241 * thread.c (find_thread_by_handle): Likewise. Adjust
11242 implementation too.
11243 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11244 support for buffer objects as handles.
11245
11246 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11247
11248 * python/py-infthread.c (thpy_thread_handle): New function.
11249 (thread_object_methods): Register thpy_thread_handle.
11250
11251 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11252
11253 * gdbthread.h (thread_to_thread_handle): Declare.
11254 * thread.c (gdbtypes.h): Include.
11255 (thread_to_thread_handle): New function.
11256
11257 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11258 (target_thread_info_to_thread_handle): Declare.
11259 * target.c (target_thread_info_to_thread_handle): New function.
11260 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11261 * target-delegates.c: Regenerate.
11262
11263 * linux-thread-db.c (class thread_db_target): Add method
11264 thread_info_to_thread_handle.
11265 (thread_db_target::thread_info_to_thread_handle): Define.
11266 * remote.c (class remote_target): Add new method
11267 thread_info_to_thread_handle.
11268 (remote_target::thread_info_to_thread_handle): Define.
11269
11270 2019-04-08 Pedro Alves <palves@redhat.com>
11271
11272 * common/common-exceptions.c (throw_exception): Don't create
11273 named object to throw; throw directly.
11274 (throw_it): Likewise. Don't initialize gdb_exception::message
11275 here, with new; pass FMT and AP to the ctor instead.
11276 * common/common-exceptions.h: Include <string>.
11277 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11278 const char *, va_list)): New ctor. Use std::make_shared.
11279 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11280 errors)): Delete.
11281 (gdb_exception_error::gdb_exception_error(enum errors, const char
11282 *, va_list)): New.
11283 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11284 Add assertion.
11285 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11286 errors)): Delete.
11287 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11288 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11289 Add assertion.
11290
11291 2019-04-08 Tom Tromey <tom@tromey.com>
11292
11293 * valops.c (value_rtti_indirect_type): Replace throw_exception
11294 with throw.
11295 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11296 with throw.
11297 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11298 throw.
11299 * target.c (target_translate_tls_address): Replace throw_exception
11300 with throw.
11301 * stack.c (frame_apply_command_count): Replace throw_exception
11302 with throw.
11303 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11304 throw.
11305 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11306 with throw.
11307 * rs6000-tdep.c (rs6000_frame_cache)
11308 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11309 * remote.c: Replace throw_exception with throw.
11310 * record-full.c (record_full_message, record_full_wait_1)
11311 (record_full_restore): Replace throw_exception with throw.
11312 * record-btrace.c:
11313 (get_thread_current_frame_id, record_btrace_start_replaying)
11314 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11315 (cmd_record_btrace_start): Replace throw_exception with throw.
11316 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11317 throw.
11318 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11319 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11320 * linespec.c:
11321 (find_linespec_symbols): Replace throw_exception with throw.
11322 * infrun.c (displaced_step_prepare, resume): Replace
11323 throw_exception with throw.
11324 * infcmd.c (post_create_inferior): Replace throw_exception with
11325 throw.
11326 * inf-loop.c (inferior_event_handler): Replace throw_exception
11327 with throw.
11328 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11329 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11330 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11331 (get_prev_frame_always, get_frame_pc_if_available)
11332 (get_frame_address_in_block_if_available, get_frame_language):
11333 Replace throw_exception with throw.
11334 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11335 throw_exception with throw.
11336 * eval.c (fetch_subexp_value, evaluate_var_value)
11337 (evaluate_funcall, evaluate_subexp_standard): Replace
11338 throw_exception with throw.
11339 * dwarf2loc.c (call_site_find_chain)
11340 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11341 Replace throw_exception with throw.
11342 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11343 with throw.
11344 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11345 throw.
11346 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11347 * completer.c (complete_line_internal): Replace throw_exception
11348 with throw.
11349 * compile/compile-object-run.c (compile_object_run): Replace
11350 throw_exception with throw.
11351 * cli/cli-script.c (process_next_line): Replace throw_exception
11352 with throw.
11353 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11354 (btrace_enable, btrace_maint_update_pt_packets): Replace
11355 throw_exception with throw.
11356 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11357 throw_exception with throw.
11358 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11359 throw_exception with throw.
11360 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11361 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11362 * aarch64-tdep.c (aarch64_make_prologue_cache)
11363 (aarch64_make_stub_cache): Replace throw_exception with throw.
11364
11365 2019-04-08 Tom Tromey <tom@tromey.com>
11366
11367 * common/common-exceptions.c (throw_exception): Rename from
11368 throw_exception_cxx. Remove old copy. Make argument const.
11369 (throw_it): Create and throw exception objects directly.
11370 * common/common-exceptions.h (throw_exception): Make argument
11371 const.
11372 (struct gdb_exception_error): Add constructor.
11373 (struct gdb_exception_quit): Add constructor.
11374
11375 2019-04-08 Tom Tromey <tom@tromey.com>
11376
11377 * common/common-exceptions.h (exception_rethrow): Don't declare.
11378 (TRY_SJLJ): Update comment.
11379 (TRY, CATCH, END_CATCH): Remove.
11380 * common/common-exceptions.c (exception_rethrow): Remove.
11381
11382 2019-04-08 Tom Tromey <tom@tromey.com>
11383
11384 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11385 Remove.
11386 (gdb_exception_error): Rename from
11387 gdb_exception_RETURN_MASK_ERROR.
11388 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11389 (gdb_quit_bad_alloc): Update.
11390 * aarch64-tdep.c: Update.
11391 * ada-lang.c: Update.
11392 * ada-typeprint.c: Update.
11393 * ada-valprint.c: Update.
11394 * amd64-tdep.c: Update.
11395 * arch-utils.c: Update.
11396 * break-catch-throw.c: Update.
11397 * breakpoint.c: Update.
11398 * btrace.c: Update.
11399 * c-varobj.c: Update.
11400 * cli/cli-cmds.c: Update.
11401 * cli/cli-interp.c: Update.
11402 * cli/cli-script.c: Update.
11403 * common/common-exceptions.c: Update.
11404 * common/new-op.c: Update.
11405 * common/selftest.c: Update.
11406 * compile/compile-c-symbols.c: Update.
11407 * compile/compile-cplus-symbols.c: Update.
11408 * compile/compile-object-load.c: Update.
11409 * compile/compile-object-run.c: Update.
11410 * completer.c: Update.
11411 * corelow.c: Update.
11412 * cp-abi.c: Update.
11413 * cp-support.c: Update.
11414 * cp-valprint.c: Update.
11415 * darwin-nat.c: Update.
11416 * disasm-selftests.c: Update.
11417 * dtrace-probe.c: Update.
11418 * dwarf-index-cache.c: Update.
11419 * dwarf-index-write.c: Update.
11420 * dwarf2-frame-tailcall.c: Update.
11421 * dwarf2-frame.c: Update.
11422 * dwarf2loc.c: Update.
11423 * dwarf2read.c: Update.
11424 * eval.c: Update.
11425 * event-loop.c: Update.
11426 * event-top.c: Update.
11427 * exec.c: Update.
11428 * f-valprint.c: Update.
11429 * fbsd-tdep.c: Update.
11430 * frame-unwind.c: Update.
11431 * frame.c: Update.
11432 * gdbtypes.c: Update.
11433 * gnu-v3-abi.c: Update.
11434 * guile/guile-internal.h: Update.
11435 * guile/scm-block.c: Update.
11436 * guile/scm-breakpoint.c: Update.
11437 * guile/scm-cmd.c: Update.
11438 * guile/scm-disasm.c: Update.
11439 * guile/scm-frame.c: Update.
11440 * guile/scm-lazy-string.c: Update.
11441 * guile/scm-math.c: Update.
11442 * guile/scm-param.c: Update.
11443 * guile/scm-ports.c: Update.
11444 * guile/scm-pretty-print.c: Update.
11445 * guile/scm-symbol.c: Update.
11446 * guile/scm-symtab.c: Update.
11447 * guile/scm-type.c: Update.
11448 * guile/scm-value.c: Update.
11449 * i386-linux-tdep.c: Update.
11450 * i386-tdep.c: Update.
11451 * inf-loop.c: Update.
11452 * infcall.c: Update.
11453 * infcmd.c: Update.
11454 * infrun.c: Update.
11455 * jit.c: Update.
11456 * language.c: Update.
11457 * linespec.c: Update.
11458 * linux-fork.c: Update.
11459 * linux-nat.c: Update.
11460 * linux-tdep.c: Update.
11461 * linux-thread-db.c: Update.
11462 * main.c: Update.
11463 * mi/mi-cmd-break.c: Update.
11464 * mi/mi-cmd-stack.c: Update.
11465 * mi/mi-interp.c: Update.
11466 * mi/mi-main.c: Update.
11467 * objc-lang.c: Update.
11468 * p-valprint.c: Update.
11469 * parse.c: Update.
11470 * ppc-linux-tdep.c: Update.
11471 * printcmd.c: Update.
11472 * python/py-arch.c: Update.
11473 * python/py-breakpoint.c: Update.
11474 * python/py-cmd.c: Update.
11475 * python/py-finishbreakpoint.c: Update.
11476 * python/py-frame.c: Update.
11477 * python/py-framefilter.c: Update.
11478 * python/py-gdb-readline.c: Update.
11479 * python/py-inferior.c: Update.
11480 * python/py-infthread.c: Update.
11481 * python/py-lazy-string.c: Update.
11482 * python/py-linetable.c: Update.
11483 * python/py-objfile.c: Update.
11484 * python/py-param.c: Update.
11485 * python/py-prettyprint.c: Update.
11486 * python/py-progspace.c: Update.
11487 * python/py-record-btrace.c: Update.
11488 * python/py-record.c: Update.
11489 * python/py-symbol.c: Update.
11490 * python/py-type.c: Update.
11491 * python/py-unwind.c: Update.
11492 * python/py-utils.c: Update.
11493 * python/py-value.c: Update.
11494 * python/python.c: Update.
11495 * record-btrace.c: Update.
11496 * record-full.c: Update.
11497 * remote-fileio.c: Update.
11498 * remote.c: Update.
11499 * riscv-tdep.c: Update.
11500 * rs6000-aix-tdep.c: Update.
11501 * rs6000-tdep.c: Update.
11502 * rust-exp.y: Update.
11503 * rust-lang.c: Update.
11504 * s390-tdep.c: Update.
11505 * selftest-arch.c: Update.
11506 * solib-dsbt.c: Update.
11507 * solib-frv.c: Update.
11508 * solib-spu.c: Update.
11509 * solib-svr4.c: Update.
11510 * solib.c: Update.
11511 * sparc64-linux-tdep.c: Update.
11512 * stack.c: Update.
11513 * symfile-mem.c: Update.
11514 * symmisc.c: Update.
11515 * target.c: Update.
11516 * thread.c: Update.
11517 * top.c: Update.
11518 * tracefile-tfile.c: Update.
11519 * tui/tui.c: Update.
11520 * typeprint.c: Update.
11521 * unittests/cli-utils-selftests.c: Update.
11522 * unittests/parse-connection-spec-selftests.c: Update.
11523 * valops.c: Update.
11524 * valprint.c: Update.
11525 * value.c: Update.
11526 * varobj.c: Update.
11527 * windows-nat.c: Update.
11528 * x86-linux-nat.c: Update.
11529 * xml-support.c: Update.
11530
11531 2019-04-08 Tom Tromey <tom@tromey.com>
11532
11533 * xml-support.c: Use C++ exception handling.
11534 * x86-linux-nat.c: Use C++ exception handling.
11535 * windows-nat.c: Use C++ exception handling.
11536 * varobj.c: Use C++ exception handling.
11537 * value.c: Use C++ exception handling.
11538 * valprint.c: Use C++ exception handling.
11539 * valops.c: Use C++ exception handling.
11540 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11541 handling.
11542 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11543 * typeprint.c: Use C++ exception handling.
11544 * tui/tui.c: Use C++ exception handling.
11545 * tracefile-tfile.c: Use C++ exception handling.
11546 * top.c: Use C++ exception handling.
11547 * thread.c: Use C++ exception handling.
11548 * target.c: Use C++ exception handling.
11549 * symmisc.c: Use C++ exception handling.
11550 * symfile-mem.c: Use C++ exception handling.
11551 * stack.c: Use C++ exception handling.
11552 * sparc64-linux-tdep.c: Use C++ exception handling.
11553 * solib.c: Use C++ exception handling.
11554 * solib-svr4.c: Use C++ exception handling.
11555 * solib-spu.c: Use C++ exception handling.
11556 * solib-frv.c: Use C++ exception handling.
11557 * solib-dsbt.c: Use C++ exception handling.
11558 * selftest-arch.c: Use C++ exception handling.
11559 * s390-tdep.c: Use C++ exception handling.
11560 * rust-lang.c: Use C++ exception handling.
11561 * rust-exp.y: Use C++ exception handling.
11562 * rs6000-tdep.c: Use C++ exception handling.
11563 * rs6000-aix-tdep.c: Use C++ exception handling.
11564 * riscv-tdep.c: Use C++ exception handling.
11565 * remote.c: Use C++ exception handling.
11566 * remote-fileio.c: Use C++ exception handling.
11567 * record-full.c: Use C++ exception handling.
11568 * record-btrace.c: Use C++ exception handling.
11569 * python/python.c: Use C++ exception handling.
11570 * python/py-value.c: Use C++ exception handling.
11571 * python/py-utils.c: Use C++ exception handling.
11572 * python/py-unwind.c: Use C++ exception handling.
11573 * python/py-type.c: Use C++ exception handling.
11574 * python/py-symbol.c: Use C++ exception handling.
11575 * python/py-record.c: Use C++ exception handling.
11576 * python/py-record-btrace.c: Use C++ exception handling.
11577 * python/py-progspace.c: Use C++ exception handling.
11578 * python/py-prettyprint.c: Use C++ exception handling.
11579 * python/py-param.c: Use C++ exception handling.
11580 * python/py-objfile.c: Use C++ exception handling.
11581 * python/py-linetable.c: Use C++ exception handling.
11582 * python/py-lazy-string.c: Use C++ exception handling.
11583 * python/py-infthread.c: Use C++ exception handling.
11584 * python/py-inferior.c: Use C++ exception handling.
11585 * python/py-gdb-readline.c: Use C++ exception handling.
11586 * python/py-framefilter.c: Use C++ exception handling.
11587 * python/py-frame.c: Use C++ exception handling.
11588 * python/py-finishbreakpoint.c: Use C++ exception handling.
11589 * python/py-cmd.c: Use C++ exception handling.
11590 * python/py-breakpoint.c: Use C++ exception handling.
11591 * python/py-arch.c: Use C++ exception handling.
11592 * printcmd.c: Use C++ exception handling.
11593 * ppc-linux-tdep.c: Use C++ exception handling.
11594 * parse.c: Use C++ exception handling.
11595 * p-valprint.c: Use C++ exception handling.
11596 * objc-lang.c: Use C++ exception handling.
11597 * mi/mi-main.c: Use C++ exception handling.
11598 * mi/mi-interp.c: Use C++ exception handling.
11599 * mi/mi-cmd-stack.c: Use C++ exception handling.
11600 * mi/mi-cmd-break.c: Use C++ exception handling.
11601 * main.c: Use C++ exception handling.
11602 * linux-thread-db.c: Use C++ exception handling.
11603 * linux-tdep.c: Use C++ exception handling.
11604 * linux-nat.c: Use C++ exception handling.
11605 * linux-fork.c: Use C++ exception handling.
11606 * linespec.c: Use C++ exception handling.
11607 * language.c: Use C++ exception handling.
11608 * jit.c: Use C++ exception handling.
11609 * infrun.c: Use C++ exception handling.
11610 * infcmd.c: Use C++ exception handling.
11611 * infcall.c: Use C++ exception handling.
11612 * inf-loop.c: Use C++ exception handling.
11613 * i386-tdep.c: Use C++ exception handling.
11614 * i386-linux-tdep.c: Use C++ exception handling.
11615 * guile/scm-value.c: Use C++ exception handling.
11616 * guile/scm-type.c: Use C++ exception handling.
11617 * guile/scm-symtab.c: Use C++ exception handling.
11618 * guile/scm-symbol.c: Use C++ exception handling.
11619 * guile/scm-pretty-print.c: Use C++ exception handling.
11620 * guile/scm-ports.c: Use C++ exception handling.
11621 * guile/scm-param.c: Use C++ exception handling.
11622 * guile/scm-math.c: Use C++ exception handling.
11623 * guile/scm-lazy-string.c: Use C++ exception handling.
11624 * guile/scm-frame.c: Use C++ exception handling.
11625 * guile/scm-disasm.c: Use C++ exception handling.
11626 * guile/scm-cmd.c: Use C++ exception handling.
11627 * guile/scm-breakpoint.c: Use C++ exception handling.
11628 * guile/scm-block.c: Use C++ exception handling.
11629 * guile/guile-internal.h: Use C++ exception handling.
11630 * gnu-v3-abi.c: Use C++ exception handling.
11631 * gdbtypes.c: Use C++ exception handling.
11632 * frame.c: Use C++ exception handling.
11633 * frame-unwind.c: Use C++ exception handling.
11634 * fbsd-tdep.c: Use C++ exception handling.
11635 * f-valprint.c: Use C++ exception handling.
11636 * exec.c: Use C++ exception handling.
11637 * event-top.c: Use C++ exception handling.
11638 * event-loop.c: Use C++ exception handling.
11639 * eval.c: Use C++ exception handling.
11640 * dwarf2read.c: Use C++ exception handling.
11641 * dwarf2loc.c: Use C++ exception handling.
11642 * dwarf2-frame.c: Use C++ exception handling.
11643 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11644 * dwarf-index-write.c: Use C++ exception handling.
11645 * dwarf-index-cache.c: Use C++ exception handling.
11646 * dtrace-probe.c: Use C++ exception handling.
11647 * disasm-selftests.c: Use C++ exception handling.
11648 * darwin-nat.c: Use C++ exception handling.
11649 * cp-valprint.c: Use C++ exception handling.
11650 * cp-support.c: Use C++ exception handling.
11651 * cp-abi.c: Use C++ exception handling.
11652 * corelow.c: Use C++ exception handling.
11653 * completer.c: Use C++ exception handling.
11654 * compile/compile-object-run.c: Use C++ exception handling.
11655 * compile/compile-object-load.c: Use C++ exception handling.
11656 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11657 * compile/compile-c-symbols.c: Use C++ exception handling.
11658 * common/selftest.c: Use C++ exception handling.
11659 * common/new-op.c: Use C++ exception handling.
11660 * cli/cli-script.c: Use C++ exception handling.
11661 * cli/cli-interp.c: Use C++ exception handling.
11662 * cli/cli-cmds.c: Use C++ exception handling.
11663 * c-varobj.c: Use C++ exception handling.
11664 * btrace.c: Use C++ exception handling.
11665 * breakpoint.c: Use C++ exception handling.
11666 * break-catch-throw.c: Use C++ exception handling.
11667 * arch-utils.c: Use C++ exception handling.
11668 * amd64-tdep.c: Use C++ exception handling.
11669 * ada-valprint.c: Use C++ exception handling.
11670 * ada-typeprint.c: Use C++ exception handling.
11671 * ada-lang.c: Use C++ exception handling.
11672 * aarch64-tdep.c: Use C++ exception handling.
11673
11674 2019-04-08 Tom Tromey <tom@tromey.com>
11675
11676 * xml-support.c (gdb_xml_parser::parse): Update.
11677 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11678 * value.c (show_convenience): Update.
11679 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11680 (test_parse_flags_qcs): Update.
11681 * thread.c (thr_try_catch_cmd): Update.
11682 * target.c (target_translate_tls_address): Update.
11683 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11684 (info_frame_command_core, frame_apply_command_count): Update.
11685 * rust-exp.y (rust_lex_exception_test): Update.
11686 * riscv-tdep.c (riscv_print_one_register_info): Update.
11687 * remote.c (remote_target::enable_btrace): Update.
11688 * record-btrace.c (record_btrace_enable_warn): Update.
11689 * python/py-utils.c (gdbpy_convert_exception): Update.
11690 * printcmd.c (do_one_display, print_variable_and_value): Update.
11691 * mi/mi-main.c (mi_print_exception): Update.
11692 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11693 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11694 * linux-nat.c (linux_nat_target::attach): Update.
11695 * linux-fork.c (class scoped_switch_fork_info): Update.
11696 * infrun.c (displaced_step_prepare): Update.
11697 * infcall.c (call_function_by_hand_dummy): Update.
11698 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11699 * gnu-v3-abi.c (print_one_vtable): Update.
11700 * frame.c (get_prev_frame_always): Update.
11701 * f-valprint.c (info_common_command_for_block): Update.
11702 * exec.c (try_open_exec_file): Update.
11703 * exceptions.c (print_exception, exception_print)
11704 (exception_fprintf, exception_print_same): Update.
11705 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11706 * dwarf-index-cache.c (index_cache::store)
11707 (index_cache::lookup_gdb_index): Update.
11708 * darwin-nat.c (maybe_cache_shell): Update.
11709 * cp-valprint.c (cp_print_value_fields): Update.
11710 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11711 (gcc_cplus_symbol_address): Update.
11712 * compile/compile-c-symbols.c (gcc_convert_symbol)
11713 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11714 * common/selftest.c: Update.
11715 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11716 a std::string.
11717 (exception_try_scope_entry, exception_try_scope_exit): Don't
11718 declare.
11719 (struct exception_try_scope): Remove.
11720 (TRY): Don't use exception_try_scope.
11721 (struct gdb_exception): Add constructor, operator=.
11722 <what>: New method.
11723 (struct gdb_exception_RETURN_MASK_ALL)
11724 (struct gdb_exception_RETURN_MASK_ERROR)
11725 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11726 (struct gdb_quit_bad_alloc): Update.
11727 * common/common-exceptions.c (exception_none): Change
11728 initializer.
11729 (struct catcher) <state, exception>: Initialize inline.
11730 <prev>: Remove member.
11731 (current_catcher): Remove.
11732 (catchers): New global.
11733 (exceptions_state_mc_init): Simplify.
11734 (catcher_pop): Remove.
11735 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11736 (try_scope_depth, exception_try_scope_entry)
11737 (exception_try_scope_exit): Remove.
11738 (throw_exception_sjlj): Update.
11739 (exception_messages, exception_messages_size): Remove.
11740 (throw_it): Simplify.
11741 (gdb_exception_sliced_copy): Remove.
11742 (throw_exception_cxx): Update.
11743 * cli/cli-script.c (script_from_file): Update.
11744 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11745 Update.
11746 * ada-valprint.c (ada_val_print): Update.
11747 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11748 (create_excep_cond_exprs): Update.
11749
11750 2019-04-08 Tom Tromey <tom@tromey.com>
11751
11752 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11753 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11754 (TRY, CATCH, END_CATCH): Remove some definitions.
11755 * common/common-exceptions.c: Don't use GDB_XCPT.
11756 (catcher_list_size): Remove.
11757 (throw_exception, throw_it): Simplify.
11758
11759 2019-04-05 Tom Tromey <tom@tromey.com>
11760
11761 Revert the header-sorting patch.
11762 * ft32-tdep.c: Revert.
11763 * frv-tdep.c: Revert.
11764 * frv-linux-tdep.c: Revert.
11765 * frame.c: Revert.
11766 * frame-unwind.c: Revert.
11767 * frame-base.c: Revert.
11768 * fork-child.c: Revert.
11769 * findvar.c: Revert.
11770 * findcmd.c: Revert.
11771 * filesystem.c: Revert.
11772 * filename-seen-cache.h: Revert.
11773 * filename-seen-cache.c: Revert.
11774 * fbsd-tdep.c: Revert.
11775 * fbsd-nat.h: Revert.
11776 * fbsd-nat.c: Revert.
11777 * f-valprint.c: Revert.
11778 * f-typeprint.c: Revert.
11779 * f-lang.c: Revert.
11780 * extension.h: Revert.
11781 * extension.c: Revert.
11782 * extension-priv.h: Revert.
11783 * expprint.c: Revert.
11784 * exec.h: Revert.
11785 * exec.c: Revert.
11786 * exceptions.c: Revert.
11787 * event-top.c: Revert.
11788 * event-loop.c: Revert.
11789 * eval.c: Revert.
11790 * elfread.c: Revert.
11791 * dwarf2read.h: Revert.
11792 * dwarf2read.c: Revert.
11793 * dwarf2loc.c: Revert.
11794 * dwarf2expr.h: Revert.
11795 * dwarf2expr.c: Revert.
11796 * dwarf2-frame.c: Revert.
11797 * dwarf2-frame-tailcall.c: Revert.
11798 * dwarf-index-write.h: Revert.
11799 * dwarf-index-write.c: Revert.
11800 * dwarf-index-common.c: Revert.
11801 * dwarf-index-cache.h: Revert.
11802 * dwarf-index-cache.c: Revert.
11803 * dummy-frame.c: Revert.
11804 * dtrace-probe.c: Revert.
11805 * disasm.h: Revert.
11806 * disasm.c: Revert.
11807 * disasm-selftests.c: Revert.
11808 * dictionary.c: Revert.
11809 * dicos-tdep.c: Revert.
11810 * demangle.c: Revert.
11811 * dcache.h: Revert.
11812 * dcache.c: Revert.
11813 * darwin-nat.h: Revert.
11814 * darwin-nat.c: Revert.
11815 * darwin-nat-info.c: Revert.
11816 * d-valprint.c: Revert.
11817 * d-namespace.c: Revert.
11818 * d-lang.c: Revert.
11819 * ctf.c: Revert.
11820 * csky-tdep.c: Revert.
11821 * csky-linux-tdep.c: Revert.
11822 * cris-tdep.c: Revert.
11823 * cris-linux-tdep.c: Revert.
11824 * cp-valprint.c: Revert.
11825 * cp-support.c: Revert.
11826 * cp-namespace.c: Revert.
11827 * cp-abi.c: Revert.
11828 * corelow.c: Revert.
11829 * corefile.c: Revert.
11830 * continuations.c: Revert.
11831 * completer.h: Revert.
11832 * completer.c: Revert.
11833 * complaints.c: Revert.
11834 * coffread.c: Revert.
11835 * coff-pe-read.c: Revert.
11836 * cli-out.h: Revert.
11837 * cli-out.c: Revert.
11838 * charset.c: Revert.
11839 * c-varobj.c: Revert.
11840 * c-valprint.c: Revert.
11841 * c-typeprint.c: Revert.
11842 * c-lang.c: Revert.
11843 * buildsym.c: Revert.
11844 * buildsym-legacy.c: Revert.
11845 * build-id.h: Revert.
11846 * build-id.c: Revert.
11847 * btrace.c: Revert.
11848 * bsd-uthread.c: Revert.
11849 * breakpoint.h: Revert.
11850 * breakpoint.c: Revert.
11851 * break-catch-throw.c: Revert.
11852 * break-catch-syscall.c: Revert.
11853 * break-catch-sig.c: Revert.
11854 * blockframe.c: Revert.
11855 * block.c: Revert.
11856 * bfin-tdep.c: Revert.
11857 * bfin-linux-tdep.c: Revert.
11858 * bfd-target.c: Revert.
11859 * bcache.c: Revert.
11860 * ax-general.c: Revert.
11861 * ax-gdb.h: Revert.
11862 * ax-gdb.c: Revert.
11863 * avr-tdep.c: Revert.
11864 * auxv.c: Revert.
11865 * auto-load.c: Revert.
11866 * arm-wince-tdep.c: Revert.
11867 * arm-tdep.c: Revert.
11868 * arm-symbian-tdep.c: Revert.
11869 * arm-pikeos-tdep.c: Revert.
11870 * arm-obsd-tdep.c: Revert.
11871 * arm-nbsd-tdep.c: Revert.
11872 * arm-nbsd-nat.c: Revert.
11873 * arm-linux-tdep.c: Revert.
11874 * arm-linux-nat.c: Revert.
11875 * arm-fbsd-tdep.c: Revert.
11876 * arm-fbsd-nat.c: Revert.
11877 * arm-bsd-tdep.c: Revert.
11878 * arch-utils.c: Revert.
11879 * arc-tdep.c: Revert.
11880 * arc-newlib-tdep.c: Revert.
11881 * annotate.h: Revert.
11882 * annotate.c: Revert.
11883 * amd64-windows-tdep.c: Revert.
11884 * amd64-windows-nat.c: Revert.
11885 * amd64-tdep.c: Revert.
11886 * amd64-sol2-tdep.c: Revert.
11887 * amd64-obsd-tdep.c: Revert.
11888 * amd64-obsd-nat.c: Revert.
11889 * amd64-nbsd-tdep.c: Revert.
11890 * amd64-nbsd-nat.c: Revert.
11891 * amd64-nat.c: Revert.
11892 * amd64-linux-tdep.c: Revert.
11893 * amd64-linux-nat.c: Revert.
11894 * amd64-fbsd-tdep.c: Revert.
11895 * amd64-fbsd-nat.c: Revert.
11896 * amd64-dicos-tdep.c: Revert.
11897 * amd64-darwin-tdep.c: Revert.
11898 * amd64-bsd-nat.c: Revert.
11899 * alpha-tdep.c: Revert.
11900 * alpha-obsd-tdep.c: Revert.
11901 * alpha-nbsd-tdep.c: Revert.
11902 * alpha-mdebug-tdep.c: Revert.
11903 * alpha-linux-tdep.c: Revert.
11904 * alpha-linux-nat.c: Revert.
11905 * alpha-bsd-tdep.c: Revert.
11906 * alpha-bsd-nat.c: Revert.
11907 * aix-thread.c: Revert.
11908 * agent.c: Revert.
11909 * addrmap.c: Revert.
11910 * ada-varobj.c: Revert.
11911 * ada-valprint.c: Revert.
11912 * ada-typeprint.c: Revert.
11913 * ada-tasks.c: Revert.
11914 * ada-lang.c: Revert.
11915 * aarch64-tdep.c: Revert.
11916 * aarch64-ravenscar-thread.c: Revert.
11917 * aarch64-newlib-tdep.c: Revert.
11918 * aarch64-linux-tdep.c: Revert.
11919 * aarch64-linux-nat.c: Revert.
11920 * aarch64-fbsd-tdep.c: Revert.
11921 * aarch64-fbsd-nat.c: Revert.
11922 * aarch32-linux-nat.c: Revert.
11923
11924 2019-04-05 Tom Tromey <tom@tromey.com>
11925
11926 * ft32-tdep.c: Sort headers.
11927 * frv-tdep.c: Sort headers.
11928 * frv-linux-tdep.c: Sort headers.
11929 * frame.c: Sort headers.
11930 * frame-unwind.c: Sort headers.
11931 * frame-base.c: Sort headers.
11932 * fork-child.c: Sort headers.
11933 * findvar.c: Sort headers.
11934 * findcmd.c: Sort headers.
11935 * filesystem.c: Sort headers.
11936 * filename-seen-cache.h: Sort headers.
11937 * filename-seen-cache.c: Sort headers.
11938 * fbsd-tdep.c: Sort headers.
11939 * fbsd-nat.h: Sort headers.
11940 * fbsd-nat.c: Sort headers.
11941 * f-valprint.c: Sort headers.
11942 * f-typeprint.c: Sort headers.
11943 * f-lang.c: Sort headers.
11944 * extension.h: Sort headers.
11945 * extension.c: Sort headers.
11946 * extension-priv.h: Sort headers.
11947 * expprint.c: Sort headers.
11948 * exec.h: Sort headers.
11949 * exec.c: Sort headers.
11950 * exceptions.c: Sort headers.
11951 * event-top.c: Sort headers.
11952 * event-loop.c: Sort headers.
11953 * eval.c: Sort headers.
11954 * elfread.c: Sort headers.
11955 * dwarf2read.h: Sort headers.
11956 * dwarf2read.c: Sort headers.
11957 * dwarf2loc.c: Sort headers.
11958 * dwarf2expr.h: Sort headers.
11959 * dwarf2expr.c: Sort headers.
11960 * dwarf2-frame.c: Sort headers.
11961 * dwarf2-frame-tailcall.c: Sort headers.
11962 * dwarf-index-write.h: Sort headers.
11963 * dwarf-index-write.c: Sort headers.
11964 * dwarf-index-common.c: Sort headers.
11965 * dwarf-index-cache.h: Sort headers.
11966 * dwarf-index-cache.c: Sort headers.
11967 * dummy-frame.c: Sort headers.
11968 * dtrace-probe.c: Sort headers.
11969 * disasm.h: Sort headers.
11970 * disasm.c: Sort headers.
11971 * disasm-selftests.c: Sort headers.
11972 * dictionary.c: Sort headers.
11973 * dicos-tdep.c: Sort headers.
11974 * demangle.c: Sort headers.
11975 * dcache.h: Sort headers.
11976 * dcache.c: Sort headers.
11977 * darwin-nat.h: Sort headers.
11978 * darwin-nat.c: Sort headers.
11979 * darwin-nat-info.c: Sort headers.
11980 * d-valprint.c: Sort headers.
11981 * d-namespace.c: Sort headers.
11982 * d-lang.c: Sort headers.
11983 * ctf.c: Sort headers.
11984 * csky-tdep.c: Sort headers.
11985 * csky-linux-tdep.c: Sort headers.
11986 * cris-tdep.c: Sort headers.
11987 * cris-linux-tdep.c: Sort headers.
11988 * cp-valprint.c: Sort headers.
11989 * cp-support.c: Sort headers.
11990 * cp-namespace.c: Sort headers.
11991 * cp-abi.c: Sort headers.
11992 * corelow.c: Sort headers.
11993 * corefile.c: Sort headers.
11994 * continuations.c: Sort headers.
11995 * completer.h: Sort headers.
11996 * completer.c: Sort headers.
11997 * complaints.c: Sort headers.
11998 * coffread.c: Sort headers.
11999 * coff-pe-read.c: Sort headers.
12000 * cli-out.h: Sort headers.
12001 * cli-out.c: Sort headers.
12002 * charset.c: Sort headers.
12003 * c-varobj.c: Sort headers.
12004 * c-valprint.c: Sort headers.
12005 * c-typeprint.c: Sort headers.
12006 * c-lang.c: Sort headers.
12007 * buildsym.c: Sort headers.
12008 * buildsym-legacy.c: Sort headers.
12009 * build-id.h: Sort headers.
12010 * build-id.c: Sort headers.
12011 * btrace.c: Sort headers.
12012 * bsd-uthread.c: Sort headers.
12013 * breakpoint.h: Sort headers.
12014 * breakpoint.c: Sort headers.
12015 * break-catch-throw.c: Sort headers.
12016 * break-catch-syscall.c: Sort headers.
12017 * break-catch-sig.c: Sort headers.
12018 * blockframe.c: Sort headers.
12019 * block.c: Sort headers.
12020 * bfin-tdep.c: Sort headers.
12021 * bfin-linux-tdep.c: Sort headers.
12022 * bfd-target.c: Sort headers.
12023 * bcache.c: Sort headers.
12024 * ax-general.c: Sort headers.
12025 * ax-gdb.h: Sort headers.
12026 * ax-gdb.c: Sort headers.
12027 * avr-tdep.c: Sort headers.
12028 * auxv.c: Sort headers.
12029 * auto-load.c: Sort headers.
12030 * arm-wince-tdep.c: Sort headers.
12031 * arm-tdep.c: Sort headers.
12032 * arm-symbian-tdep.c: Sort headers.
12033 * arm-pikeos-tdep.c: Sort headers.
12034 * arm-obsd-tdep.c: Sort headers.
12035 * arm-nbsd-tdep.c: Sort headers.
12036 * arm-nbsd-nat.c: Sort headers.
12037 * arm-linux-tdep.c: Sort headers.
12038 * arm-linux-nat.c: Sort headers.
12039 * arm-fbsd-tdep.c: Sort headers.
12040 * arm-fbsd-nat.c: Sort headers.
12041 * arm-bsd-tdep.c: Sort headers.
12042 * arch-utils.c: Sort headers.
12043 * arc-tdep.c: Sort headers.
12044 * arc-newlib-tdep.c: Sort headers.
12045 * annotate.h: Sort headers.
12046 * annotate.c: Sort headers.
12047 * amd64-windows-tdep.c: Sort headers.
12048 * amd64-windows-nat.c: Sort headers.
12049 * amd64-tdep.c: Sort headers.
12050 * amd64-sol2-tdep.c: Sort headers.
12051 * amd64-obsd-tdep.c: Sort headers.
12052 * amd64-obsd-nat.c: Sort headers.
12053 * amd64-nbsd-tdep.c: Sort headers.
12054 * amd64-nbsd-nat.c: Sort headers.
12055 * amd64-nat.c: Sort headers.
12056 * amd64-linux-tdep.c: Sort headers.
12057 * amd64-linux-nat.c: Sort headers.
12058 * amd64-fbsd-tdep.c: Sort headers.
12059 * amd64-fbsd-nat.c: Sort headers.
12060 * amd64-dicos-tdep.c: Sort headers.
12061 * amd64-darwin-tdep.c: Sort headers.
12062 * amd64-bsd-nat.c: Sort headers.
12063 * alpha-tdep.c: Sort headers.
12064 * alpha-obsd-tdep.c: Sort headers.
12065 * alpha-nbsd-tdep.c: Sort headers.
12066 * alpha-mdebug-tdep.c: Sort headers.
12067 * alpha-linux-tdep.c: Sort headers.
12068 * alpha-linux-nat.c: Sort headers.
12069 * alpha-bsd-tdep.c: Sort headers.
12070 * alpha-bsd-nat.c: Sort headers.
12071 * aix-thread.c: Sort headers.
12072 * agent.c: Sort headers.
12073 * addrmap.c: Sort headers.
12074 * ada-varobj.c: Sort headers.
12075 * ada-valprint.c: Sort headers.
12076 * ada-typeprint.c: Sort headers.
12077 * ada-tasks.c: Sort headers.
12078 * ada-lang.c: Sort headers.
12079 * aarch64-tdep.c: Sort headers.
12080 * aarch64-ravenscar-thread.c: Sort headers.
12081 * aarch64-newlib-tdep.c: Sort headers.
12082 * aarch64-linux-tdep.c: Sort headers.
12083 * aarch64-linux-nat.c: Sort headers.
12084 * aarch64-fbsd-tdep.c: Sort headers.
12085 * aarch64-fbsd-nat.c: Sort headers.
12086 * aarch32-linux-nat.c: Sort headers.
12087
12088 2019-04-04 Tom Tromey <tom@tromey.com>
12089
12090 * varobj.c (varobj_create): Update.
12091 * rust-exp.y (struct rust_parser) <update_innermost_block,
12092 lookup_symbol>: New methods.
12093 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12094 Rename.
12095 (rust_parser::rust_lookup_type)
12096 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12097 * printcmd.c (display_command, do_one_display): Update.
12098 * parser-defs.h (struct parser_state) <parser_state>: Add
12099 "tracker" parameter.
12100 (block_tracker): New member.
12101 (class innermost_block_tracker) <innermost_block_tracker>: Add
12102 "types" parameter.
12103 <reset>: Remove method.
12104 (innermost_block): Don't declare.
12105 (null_post_parser): Update.
12106 * parse.c (innermost_block): Remove global.
12107 (write_dollar_variable): Update.
12108 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12109 Remove "tracker_types" parameter.
12110 (parse_expression): Add "tracker" parameter.
12111 (parse_expression_for_completion): Update.
12112 (null_post_parser): Add "tracker" parameter.
12113 * p-exp.y: Update rules.
12114 * m2-exp.y: Update rules.
12115 * language.h (struct language_defn) <la_post_parser>: Add
12116 "tracker" parameter.
12117 * go-exp.y: Update rules.
12118 * f-exp.y: Update rules.
12119 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12120 parameter.
12121 * d-exp.y: Update rules.
12122 * c-exp.y: Update rules.
12123 * breakpoint.c (set_breakpoint_condition): Create an
12124 innermost_block_tracker.
12125 (watch_command_1): Likewise.
12126 * ada-lang.c (resolve): Add "tracker" parameter.
12127 (resolve_subexp): Likewise.
12128 * ada-exp.y (write_var_from_sym): Update.
12129
12130 2019-04-04 Tom Tromey <tom@tromey.com>
12131
12132 * type-stack.h: New file.
12133 * type-stack.c: New file.
12134 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12135 type-stack.h.
12136 (insert_into_type_stack, insert_type, push_type, push_type_int)
12137 (insert_type_address_space, pop_type, pop_type_int)
12138 (pop_typelist, pop_type_stack, append_type_stack)
12139 (push_type_stack, get_type_stack, push_typelist)
12140 (follow_type_instance_flags, follow_types): Don't declare.
12141 * parse.c (type_stack): Remove global.
12142 (parse_exp_in_context): Update.
12143 (insert_into_type_stack, insert_type, push_type, push_type_int)
12144 (insert_type_address_space, pop_type, pop_type_int)
12145 (pop_typelist, pop_type_stack, append_type_stack)
12146 (push_type_stack, get_type_stack, push_typelist)
12147 (follow_type_instance_flags, follow_types): Remove (moved to
12148 type-stack.c).
12149 * f-exp.y (type_stack): New global.
12150 Update rules.
12151 (push_kind_type, f_parse): Update.
12152 * d-exp.y (type_stack): New global.
12153 Update rules.
12154 (d_parse): Update.
12155 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12156 Update rules.
12157 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12158 (HFILES_NO_SRCDIR): Add type-stack.h.
12159
12160 2019-04-04 Tom Tromey <tom@tromey.com>
12161
12162 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12163 (rust_parser::convert_ast_to_expression, rust_parse)
12164 (rust_lex_test_completion, rust_lex_tests): Update.
12165 * parser-defs.h (struct expr_completion_state): New.
12166 (struct parser_state) <parser_state>: Add completion parameter.
12167 <mark_struct_expression, mark_completion_tag>: New methods.
12168 <parse_completion, m_completion_state>: New members.
12169 (prefixify_expression, null_post_parser): Update.
12170 (mark_struct_expression, mark_completion_tag): Don't declare.
12171 * parse.c (parse_completion, expout_last_struct)
12172 (expout_tag_completion_type, expout_completion_name): Remove
12173 globals.
12174 (parser_state::mark_struct_expression)
12175 (parser_state::mark_completion_tag): Now methods.
12176 (prefixify_expression): Add last_struct parameter.
12177 (prefixify_subexp): Likewise.
12178 (parse_exp_1): Update.
12179 (parse_exp_in_context): Add cstate parameter. Update.
12180 (parse_expression_for_completion): Create an
12181 expr_completion_state.
12182 (null_post_parser): Add "completion" parameter.
12183 * p-exp.y: Update rules.
12184 (yylex): Update.
12185 * language.h (struct language_defn) <la_post_parser>: Add
12186 "completing" parameter.
12187 * go-exp.y: Update rules.
12188 (lex_one_token): Update.
12189 * expression.h (parse_completion): Don't declare.
12190 * d-exp.y: Update rules.
12191 (lex_one_token): Update rules.
12192 * c-exp.y: Update rules.
12193 (lex_one_token): Update.
12194 * ada-lang.c (resolve): Add "parse_completion" parameter.
12195 (resolve_subexp): Likewise.
12196 (ada_resolve_function): Likewise.
12197
12198 2019-04-04 Tom Tromey <tom@tromey.com>
12199
12200 * parser-defs.h (struct parser_state) <start_arglist,
12201 end_arglist>: New methods.
12202 <arglist_len, m_funcall_chain>: New members.
12203 (arglist_len, start_arglist, end_arglist): Don't declare.
12204 * parse.c (arglist_len, funcall_chain): Remove global.
12205 (start_arglist, end_arglist): Remove functions.
12206 (parse_exp_in_context): Update.
12207 * p-exp.y: Update rules.
12208 * m2-exp.y: Update rules.
12209 * go-exp.y: Update rules.
12210 * f-exp.y: Update rules.
12211 * d-exp.y: Update rules.
12212 * c-exp.y: Update rules.
12213
12214 2019-04-04 Tom Tromey <tom@tromey.com>
12215
12216 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12217 lex_operator, push_back>: New methods.
12218 Update all rules.
12219 (rust_parser::lex_hex, lex_escape): Rename and update.
12220 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12221 (rust_parser::lex_operator): Rename and update.
12222 (rust_parser::lex_number, rustyylex, rustyyerror)
12223 (rust_lex_test_init, rust_lex_test_sequence)
12224 (rust_lex_test_push_back, rust_lex_tests): Update.
12225 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12226 parameter.
12227 <lexptr, prev_lexptr>: New members.
12228 (lexptr, prev_lexptr): Don't declare.
12229 * parse.c (lexptr, prev_lexptr): Remove globals.
12230 (parse_exp_in_context): Update.
12231 * p-exp.y (yylex, yyerror): Update.
12232 * m2-exp.y (parse_number, yylex, yyerror): Update.
12233 * go-exp.y (lex_one_token, yyerror): Update.
12234 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12235 * d-exp.y (lex_one_token, yyerror): Update.
12236 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12237 (lex_one_token, yyerror): Update.
12238 * ada-lex.l (YY_INPUT): Update.
12239 (rewind_to_char): Update.
12240 * ada-exp.y (yyerror): Update.
12241
12242 2019-04-04 Tom Tromey <tom@tromey.com>
12243
12244 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12245 * parser-defs.h (struct parser_state) <parser_state>: Add new
12246 parameter.
12247 <comma_terminates>: New member.
12248 (comma_terminates): Don't declare global.
12249 * parse.c (comma_terminates): Remove global.
12250 (parse_exp_in_context): Update.
12251 * p-exp.y (yylex): Update.
12252 * m2-exp.y (yylex): Update.
12253 * go-exp.y (lex_one_token): Update.
12254 * f-exp.y (yylex): Update.
12255 * d-exp.y (lex_one_token): Update.
12256 * c-exp.y (lex_one_token): Update.
12257 * ada-lex.l: Update.
12258
12259 2019-04-04 Tom Tromey <tom@tromey.com>
12260
12261 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12262 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12263 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12264 * parser-defs.h (paren_depth): Don't declare.
12265 * parse.c (paren_depth): Remove global.
12266 (parse_exp_in_context): Update.
12267 * p-exp.y (paren_depth): New global.
12268 (pascal_parse): Initialize it.
12269 * m2-exp.y (paren_depth): New global.
12270 (m2_parse): Initialize it.
12271 * go-exp.y (paren_depth): New global.
12272 (go_parse): Initialize it.
12273 * f-exp.y (paren_depth): New global.
12274 (f_parse): Initialize it.
12275 * d-exp.y (paren_depth): New global.
12276 (d_parse): Initialize it.
12277 * c-exp.y (paren_depth): New global.
12278 (c_parse): Initialize it.
12279 * ada-lex.l (paren_depth): New global.
12280 (lexer_init): Initialize it.
12281
12282 2019-04-04 Tom Tromey <tom@tromey.com>
12283
12284 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12285 (rust_parser::convert_ast_to_type)
12286 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12287 * parser-defs.h (struct parser_state) <parser_state>: Add
12288 parameters. Initialize new members.
12289 <expression_context_block, expression_context_pc>: New members.
12290 * parse.c (expression_context_block, expression_context_pc):
12291 Remove globals.
12292 (parse_exp_in_context): Update.
12293 * p-exp.y: Update all rules.
12294 (yylex): Update.
12295 * m2-exp.y: Update all rules.
12296 (yylex): Update.
12297 * go-exp.y (yylex): Update.
12298 * f-exp.y (yylex): Update.
12299 * d-exp.y: Update all rules.
12300 (yylex): Update.
12301 * c-exp.y: Update all rules.
12302 (lex_one_token, classify_name, yylex, c_parse): Update.
12303 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12304
12305 2019-04-04 Tom Tromey <tom@tromey.com>
12306
12307 * gdbarch.h, gdbarch.c: Rebuild.
12308 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12309 * stap-probe.h:
12310 (struct stap_parse_info): Replace "parser_state" with
12311 "expr_builder".
12312 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12313 (parser_state): New class.
12314 * parse.c (expr_builder): Rename.
12315 (expr_builder::release): Rename.
12316 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12317 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12318 (write_exp_elt_longcst, write_exp_elt_floatcst)
12319 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12320 (write_exp_string_vector, write_exp_bitstring)
12321 (write_exp_msymbol, mark_struct_expression)
12322 (write_dollar_variable)
12323 (insert_type_address_space, increase_expout_size): Replace
12324 "parser_state" with "expr_builder".
12325 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12326 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12327 "parser_state" with "expr_builder".
12328
12329 2019-04-04 Tom Tromey <tom@tromey.com>
12330
12331 * rust-exp.y: Replace "parse_language" with method call.
12332 * p-exp.y:
12333 (yylex): Replace "parse_language" with method call.
12334 * m2-exp.y:
12335 (yylex): Replace "parse_language" with method call.
12336 * go-exp.y (classify_name): Replace "parse_language" with method
12337 call.
12338 * f-exp.y (yylex): Replace "parse_language" with method call.
12339 * d-exp.y (lex_one_token): Replace "parse_language" with method
12340 call.
12341 * c-exp.y:
12342 (lex_one_token, classify_name, yylex): Replace "parse_language"
12343 with method call.
12344 * ada-exp.y (find_primitive_type, type_char)
12345 (type_system_address): Replace "parse_language" with method call.
12346
12347 2019-04-04 Tom Tromey <tom@tromey.com>
12348
12349 * rust-exp.y: Replace "parse_gdbarch" with method call.
12350 * parse.c (write_dollar_variable, insert_type_address_space):
12351 Replace "parse_gdbarch" with method call.
12352 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12353 call.
12354 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12355 call.
12356 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12357 "parse_gdbarch" with method call.
12358 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12359 with method call.
12360 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12361 "parse_gdbarch" with method call.
12362 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12363 "parse_gdbarch" with method call.
12364 * c-exp.y (parse_type, parse_number, classify_name): Replace
12365 "parse_gdbarch" with method call.
12366 * ada-lex.l: Replace "parse_gdbarch" with method call.
12367 * ada-exp.y (parse_type, find_primitive_type, type_char)
12368 (type_system_address): Replace "parse_gdbarch" with method call.
12369
12370 2019-04-04 Tom Tromey <tom@tromey.com>
12371
12372 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12373 * stap-probe.c (stap_parse_argument): Update.
12374 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12375 initial_size parameter.
12376 * rust-exp.y (rust_lex_tests): Update.
12377 * parse.c (parser_state): Update.
12378 (parse_exp_in_context): Update.
12379 * parser-defs.h (struct parser_state) <parser_state>: Remove
12380 "initial_size" parameter.
12381
12382 2019-04-04 Tom Tromey <tom@tromey.com>
12383
12384 * parser-defs.h (increase_expout_size): Don't declare.
12385 * parse.c (increase_expout_size): Now static.
12386
12387 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12388
12389 * gnu-nat.c (gnu_nat_target::wait): Fix
12390 target_waitstatus_to_string call.
12391
12392 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12393
12394 * eval.c (evaluate_subexp_standard): Handle internal functions
12395 during Fortran function call handling.
12396
12397 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12398
12399 * NEWS: Mention new internal functions.
12400 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12401 (read_base_type): Use dwarf2_init_complex_target_type.
12402 * value.c (creal_internal_fn): New function.
12403 (cimag_internal_fn): New function.
12404 (_initialize_values): Register new internal functions.
12405
12406 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12407
12408 * infrun.c (stop_all_threads): If debug_infrun, always
12409 trace the wait status after wait_one, using
12410 target_waitstatus_to_string and target_pid_to_str.
12411 (handle_inferior_event): Replace various trace of
12412 wait status kind by a single trace.
12413 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12414 wait status kind image by target_waitstatus_to_string.
12415 * target/waitstatus.c (target_waitstatus_to_string): Fix
12416 obsolete comment.
12417
12418 2019-04-01 Tom Tromey <tromey@adacore.com>
12419
12420 PR symtab/23331:
12421 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12422
12423 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12424 Pedro Alves <palves@redhat.com>
12425
12426 * top.c (quit_force): Call 'finalize_values'.
12427 * value.c (finalize_values): New function.
12428 * value.h (finalize_values): Declare.
12429
12430 2019-03-30 Eli Zaretskii <eliz@gnu.org>
12431
12432 * NEWS: Announce $_gdb_major and $_gdb_minor.
12433
12434 * top.c (init_gdb_version_vars): New function.
12435 (gdb_init): Call init_gdb_version_vars.
12436
12437 2019-03-29 Tom Tromey <tromey@adacore.com>
12438
12439 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12440 help text. Remove dead code.
12441
12442 2019-03-29 Keith Seitz <keiths@redhat.com>
12443
12444 From Siddhesh Poyarekar:
12445 * f-lang.h (f77_get_upperbound): Return LONGEST.
12446 (f77_get_lowerbound): Likewise.
12447 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12448 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12449 print them.
12450 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12451 plongest to format print it.
12452 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12453 (f77_get_upperbound): Likewise.
12454 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12455 LOWER_BOUND to LONGEST.
12456 (f77_create_arrayprint_offset_tbl): Likewise.
12457
12458 2019-03-29 Keith Seitz <keiths@redhat.com>
12459
12460 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12461 %s/pulongest for TYPE_LENGTH instead of %d in format
12462 strings.
12463 * ada-typerint.c (ada_print_type): Likewise.
12464 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12465 * compile/compile-c-support.c (generate_register_struct): Likewise.
12466 * gdbtypes.c (recursive_dump_type): Likewise.
12467 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12468 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12469 instead of %d in format strings.
12470 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12471 to std::min to ULONGEST.
12472 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12473 instead of %d in format strings.
12474 * tracepoint.c (info_scope_command): Likewise.
12475 * typeprint.c (print_offset_data::update)
12476 (print_offset_data::finish): Likewise.
12477 * xtensa-tdep.c (xtensa_store_return_value)
12478 (xtensa_push_dummy_call): Likewise.
12479
12480 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12481
12482 * windows-nat.c (display_selector): Fixed format specifications
12483 for 64-bit Cygwin.
12484
12485 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12486
12487 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12488
12489 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12490
12491 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12492 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12493 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12494 (nios2_linux_init_abi): Install it.
12495
12496 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12497
12498 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12499
12500 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12501
12502 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12503
12504 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12505 Tom Tromey <tromey@adacore.com>
12506
12507 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12508
12509 2019-03-26 Joel Brobecker <brobecker@adacore.com>
12510
12511 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12512 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12513 method to compute the bounds of range types. Also print "[evaluated]"
12514 if the bounds' values come from a dynamic evaluation.
12515
12516 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12517
12518 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12519 whitespace when pretty printing is on.
12520
12521 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12522
12523 * ppc-linux-nat.c: Add include.
12524
12525 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12526
12527 * NEWS: Mention AArch64 Pointer Authentication.
12528
12529 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12530
12531 * arm-linux-nat.c: Add include.
12532
12533 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12534
12535 * source-cache.c (source_cache::get_source_lines): Re-read
12536 fullname after calling open_source_file.
12537
12538 2019-03-25 John Baldwin <jhb@FreeBSD.org>
12539
12540 * NEWS: Mention TLS support for FreeBSD.
12541
12542 2019-03-25 Tom Tromey <tromey@adacore.com>
12543
12544 * minsyms.c (BUNCH_SIZE): Update comment.
12545 (~minimal_symbol_reader): Remove old comment.
12546 (compact_minimal_symbols): Update comment.
12547 (minimal_symbol_reader::install): Remove old comment. Update
12548 other comments.
12549
12550 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12551
12552 * s390-linux-nat.c: Add include.
12553
12554 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12555
12556 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12557 Call linux_get_hwcap.
12558 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12559 Likewise.
12560 (aarch64_linux_get_hwcap): Remove function.
12561 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12562 declaration.
12563 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12564 linux_get_hwcap.
12565 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12566 * linux-tdep.c (linux_get_hwcap): Add function.
12567 (linux_get_hwcap2): Likewise.
12568 * linux-tdep.h (linux_get_hwcap): Add declaration.
12569 (linux_get_hwcap2): Likewise.
12570 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12571 (ppc_linux_get_hwcap2): Likewise.
12572 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12573 linux_get_hwcap.
12574 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12575 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12576 (ppc_linux_nat_target::read_description): Likewise.
12577 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12578 * s390-linux-nat.c: Likewise.
12579 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12580
12581 2019-03-24 Tom Tromey <tom@tromey.com>
12582
12583 * ada-lang.c (standard_lookup): Simplify initialization.
12584 (ada_lookup_symbol_nonlocal): Simplify return.
12585 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12586 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12587 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12588 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12589 initialization.
12590 * solib.c (solib_global_lookup): Simplify.
12591 * symtab.c (null_block_symbol): Remove.
12592 (symbol_cache_lookup): Simplify returns.
12593 (lookup_language_this): Simplify returns.
12594 (lookup_symbol_aux): Simplify return.
12595 (lookup_local_symbol): Simplify returns.
12596 (lookup_global_symbol_from_objfile): Simplify return.
12597 (lookup_symbol_in_objfile_symtabs)
12598 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12599 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12600 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12601 * cp-namespace.c (cp_lookup_bare_symbol)
12602 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12603 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12604 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12605 (cp_lookup_symbol_via_imports): Simplify initialization.
12606 (find_symbol_in_baseclass): Likewise.
12607 * symtab.h (null_block_symbol): Remove.
12608 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12609 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12610 (d_lookup_symbol_module): Likewise.
12611 (find_symbol_in_baseclass): Simplify initialization.
12612
12613 2019-03-24 Tom Tromey <tom@tromey.com>
12614
12615 * expression.h: Don't include symtab.h.
12616 (struct block): Forward declare.
12617
12618 2019-03-24 Tom Tromey <tom@tromey.com>
12619
12620 * c-exp.y (typebase): Remove casts.
12621 * gdbtypes.c (lookup_unsigned_typename, )
12622 (lookup_signed_typename): Remove cast.
12623 * eval.c (parse_to_comma_and_eval): Remove cast.
12624 * parse.c (write_dollar_variable): Remove cast.
12625 * block.h (struct block) <superblock>: Now const.
12626 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12627 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12628 (map_block): Make "block" const.
12629 * symfile.h (struct quick_symbol_functions)
12630 <map_matching_symbols>: Constify block argument to "callback".
12631 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12632 const.
12633 (find_pc_sect_compunit_symtab): Make "b" const.
12634 (find_symbol_at_address): Likewise.
12635 (search_symbols): Likewise.
12636 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12637 (dw2_debug_names_lookup_symbol): Likewise.
12638 (dw2_map_matching_symbols): Update.
12639 * p-valprint.c (pascal_val_print): Remove "block".
12640 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12641 (aux_add_nonlocal_symbols): Make "block" const.
12642 (resolve_subexp): Remove cast.
12643 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12644 const.
12645 (iterate_over_file_blocks): Likewise.
12646 * f-exp.y (%union) <bval>: Remove.
12647 * coffread.c (patch_opaque_types): Make "b" const.
12648 * spu-tdep.c (spu_catch_start): Make "block" const.
12649 * c-valprint.c (print_unpacked_pointer): Remove "block".
12650 * symmisc.c (dump_symtab_1): Make "b" const.
12651 (block_depth): Make "block" const.
12652 * d-exp.y (%union) <bval>: Remove.
12653 * cp-support.h (cp_lookup_rtti_type): Update.
12654 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12655 * psymtab.c (psym_lookup_symbol): Make "block" const.
12656 (maintenance_check_psymtabs): Make "b" const.
12657 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12658 (enumerate_locals, enumerate_args): Update.
12659 * python/py-symtab.c (stpy_global_block): Make "block" const.
12660 (stpy_static_block): Likewise.
12661 * inline-frame.c (block_starting_point_at): Make "new_block"
12662 const.
12663 * block.c (find_block_in_blockvector): Make return type const.
12664 (blockvector_for_pc_sect): Make "b" const.
12665 (find_block_in_blockvector): Make "b" const.
12666
12667 2019-03-23 Tom Tromey <tom@tromey.com>
12668
12669 * varobj.c (varobj_create): Update.
12670 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12671 * printcmd.c (display_command, do_one_display): Don't reset
12672 innermost_block.
12673 * parser-defs.h (enum innermost_block_tracker_type): Move to
12674 expression.h.
12675 (innermost_block): Update comment.
12676 * parse.c (parse_exp_1): Add tracker_types parameter.
12677 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12678 tracker_types parameter. Reset innermost_block.
12679 (parse_exp_in_context): Remove.
12680 (parse_expression_for_completion): Update.
12681 * objfiles.c (~objfile): Don't reset expression_context_block or
12682 innermost_block.
12683 * expression.h (enum innermost_block_tracker_type): Move from
12684 parser-defs.h.
12685 (parse_exp_1): Add tracker_types parameter.
12686 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12687 reset innermost_block.
12688
12689 2019-03-23 Tom Tromey <tom@tromey.com>
12690
12691 * objfiles.h: Include bcache.h.
12692
12693 2019-03-23 Tom Tromey <tom@tromey.com>
12694
12695 * linespec.c (get_current_search_block): Use
12696 scoped_restore_current_language.
12697 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12698
12699 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12700 Jiong Wang <jiong.wang@arm.com>
12701
12702 * aarch64-linux-tdep.c
12703 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12704 section.
12705 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12706
12707 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12708 Jiong Wang <jiong.wang@arm.com>
12709
12710 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12711 instructions.
12712 (aarch64_analyze_prologue_test): Add PACIASP test.
12713 (aarch64_prologue_prev_register): Unmask PC value.
12714
12715 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12716 Jiong Wang <jiong.wang@arm.com>
12717
12718 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12719 (aarch64_dwarf2_prev_register): Unmask PC value.
12720 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12721 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12722 DW_CFA_AARCH64_negate_ra_state.
12723 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12724
12725 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12726 Jiong Wang <jiong.wang@arm.com>
12727
12728 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12729 registers.
12730 (aarch64_pseudo_register_name): Likewise.
12731 (aarch64_pseudo_register_type): Likewise.
12732 (aarch64_pseudo_register_reggroup_p): Likewise.
12733 (aarch64_gdbarch_init): Add pauth registers.
12734 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12735 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12736 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12737 (struct gdbarch_tdep): Add regnum for ra_state.
12738
12739 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12740 Jiong Wang <jiong.wang@arm.com>
12741
12742 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12743
12744 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12745 Jiong Wang <jiong.wang@arm.com>
12746
12747 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12748 function.
12749 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12750 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12751 (aarch64_gdbarch_init): Add puth registers.
12752 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12753 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12754 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12755
12756 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12757 Jiong Wang <jiong.wang@arm.com>
12758
12759 * aarch64-linux-nat.c
12760 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12761 * aarch64-linux-tdep.c
12762 (aarch64_linux_core_read_description): Likewise.
12763 (aarch64_linux_get_hwcap): New function.
12764 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12765 (aarch64_linux_get_hwcap): New declaration.
12766
12767 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12768 Jiong Wang <jiong.wang@arm.com>
12769
12770 * aarch64-linux-nat.c
12771 (aarch64_linux_nat_target::read_description): Add pauth param.
12772 * aarch64-linux-tdep.c
12773 (aarch64_linux_core_read_description): Likewise.
12774 * aarch64-tdep.c (struct target_desc): Add in pauth.
12775 (aarch64_read_description): Add pauth param.
12776 (aarch64_gdbarch_init): Likewise.
12777 * aarch64-tdep.h (aarch64_read_description): Likewise.
12778 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12779 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12780 * features/Makefile: Add new files.
12781 * features/aarch64-pauth.c: New file.
12782 * features/aarch64-pauth.xml: New file.
12783
12784 2019-03-20 Tom Tromey <tromey@adacore.com>
12785
12786 * infrun.c (handle_inferior_event): Rename from
12787 handle_inferior_event_1. Create a scoped_value_mark.
12788 (handle_inferior_event): Remove.
12789
12790 2019-03-19 Tom Tromey <tromey@adacore.com>
12791
12792 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12793 * infrun.h (print_stop_event): Add "displays" parameter.
12794 * infrun.c (print_stop_event): Add "displays" parameter.
12795
12796 2019-03-19 Pedro Alves <palves@redhat.com>
12797
12798 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12799 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12800 to -1. Fix TABs vs spaces.
12801 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12802 * tui/tui-out.h (tui_ui_out) Add intro comments.
12803 <m_line, m_start_of_line>: In-class initialize, and add describing
12804 comment.
12805
12806 2019-03-18 Alan Hayward <alan.hayward@arm.com>
12807
12808 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12809 variable names.
12810 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12811
12812 2019-03-18 Pedro Alves <palves@redhat.com>
12813 Eli Zaretskii <eliz@gnu.org>
12814
12815 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12816 m_line and m_start_of_line.
12817
12818 2019-03-18 Eli Zaretskii <eliz@gnu.org>
12819
12820 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12821 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12822 it returns a newline. This fixes a regression in TU mode, whereby
12823 the next line is output on the same screen line as the user input.
12824
12825 2019-03-18 Tom Tromey <tromey@adacore.com>
12826
12827 * minsyms.c (minimal_symbol_reader::install): Remove call to
12828 obstack_blank.
12829
12830 2019-03-18 Pedro Alves <palves@redhat.com>
12831
12832 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12833 New globals.
12834 (apply_style): New, factored out from ...
12835 (apply_ansi_escape): ... this. Handle reverse video mode.
12836 (tui_set_reverse_mode): New function.
12837 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12838 * tui/tui-winsource.c (tui_show_source_line): Use
12839 tui_set_reverse_mode instead of setting A_STANDOUT.
12840 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12841 New setter methods.
12842
12843 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
12844
12845 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12846 Handle tabs.
12847
12848 2019-03-18 Tom Tromey <tromey@adacore.com>
12849
12850 * ada-lang.c (empty_array): Add "high" parameter.
12851 (ada_evaluate_subexp): Update.
12852
12853 2019-03-17 Sergei Trofimovich <siarheit@google.com>
12854
12855 * unittests/string_view-selftests.c: Define
12856 _initialize_string_view_selftests unconditionally.
12857
12858 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12859
12860 PR gdb/24350
12861 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12862
12863 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12864
12865 PR gdb/24351
12866 * windows-nat.c (display_selector): Fix format specifiers.
12867
12868 2019-03-17 Eli Zaretskii <eliz@gnu.org>
12869
12870 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12871 tui_refill_source_window instead of tui_refresh_win, to update the
12872 current execution line. This fixes redisplay of the current line
12873 when stepping through the code with "next" or "step".
12874
12875 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12876
12877 * source-cache.c (source_cache::get_source_lines): Call
12878 find_source_lines to initialize s->nlines. This fixes vertical
12879 scrolling of TUI source window when the DOWN arrow is pressed.
12880
12881 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12882
12883 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12884 linux-thread-db.c (_initialize_thread_db): Likewise.
12885
12886 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12887
12888 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12889 wclrtoeol in tui_show_source_line". This reverts changes made in
12890 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12891
12892 2019-03-15 Tom Tromey <tom@tromey.com>
12893
12894 * symtab.h (struct minimal_symbol): Derive from
12895 general_symbol_info.
12896 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12897 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12898 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12899 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12900 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12901 (MSYMBOL_SEARCH_NAME): Update.
12902 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12903 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12904 * minsyms.c (minimal_symbol_reader::record_full): Update.
12905
12906 2019-03-15 Tom Tromey <tom@tromey.com>
12907
12908 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12909
12910 2019-03-15 Tom Tromey <tom@tromey.com>
12911
12912 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12913 unique_xmalloc_ptr.
12914 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12915 Update.
12916 * minsyms.c (lookup_minimal_symbol_by_pc_section)
12917 (build_minimal_symbol_hash_tables)
12918 (minimal_symbol_reader::install): Update.
12919
12920 2019-03-15 Tom Tromey <tom@tromey.com>
12921
12922 * symtab.c (create_demangled_names_hash): Update.
12923 (symbol_set_names): Update.
12924 * objfiles.h (struct objfile_per_bfd_storage)
12925 <demangled_names_hash>: Now an htab_up.
12926 * objfiles.c (objfile_per_bfd_storage): Simplify.
12927
12928 2019-03-15 Tom Tromey <tom@tromey.com>
12929
12930 * objfiles.h (struct objfile_per_bfd_storage): Declare
12931 destructor.
12932 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12933 New.
12934 (get_objfile_bfd_data): Use new. Don't initialize
12935 language_of_main.
12936 (free_objfile_per_bfd_storage): Remove.
12937 (objfile_bfd_data_free, objfile::~objfile): Use delete.
12938
12939 2019-03-15 Tom Tromey <tom@tromey.com>
12940
12941 * symfile.c (reread_symbols): Update.
12942 * objfiles.c (objfile::objfile): Update.
12943 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12944 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12945 comment.
12946 (minimal_symbol_reader::install): Update.
12947 (terminate_minimal_symbol_table): Remove.
12948 * jit.c (jit_object_close_impl): Update.
12949
12950 2019-03-15 Tom Tromey <tom@tromey.com>
12951
12952 * minsyms.c (minimal_symbol_reader::record_full): Remove some
12953 initializations.
12954
12955 2019-03-15 Tom Tromey <tom@tromey.com>
12956
12957 * objfiles.h (struct objfile_per_bfd_storage)
12958 <demangled_hash_languages>: Now a bitset.
12959 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12960 (lookup_minimal_symbol): Update.
12961
12962 2019-03-15 Tom Tromey <tom@tromey.com>
12963
12964 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12965 Don't return the symbol.
12966 * coffread.c (record_minimal_symbol): Use record_full.
12967
12968 2019-03-14 Eli Zaretskii <eliz@gnu.org>
12969
12970 The MS-Windows port of ncurses fails to switch to a color pair if
12971 one or both of the colors are the implicit default colors. This
12972 change records the default colors when TUI is initialized, and
12973 then specifies them explicitly when a color pair uses the default
12974 colors. This allows color styling in TUI mode on MS-Windows.
12975
12976 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
12977 ncurses_norm_attr.
12978 (tui_initialize_io) [__MINGW32__]: Record the default terminal
12979 colors in ncurses_norm_attr.
12980 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12981 "none", replace it with the default color recorded in
12982 ncurses_norm_attr.
12983
12984 2019-03-14 Tom Tromey <tromey@adacore.com>
12985
12986 * source-cache.h (class source_cache) <get_source_lines>: Return
12987 std::string.
12988 * source-cache.c (source_cache::extract_lines): Handle case where
12989 first_pos==npos. Return std::string.
12990 (source_cache::get_source_lines): Update.
12991
12992 2019-03-14 Tom Tromey <tromey@adacore.com>
12993
12994 * NEWS: Add item for "style sources" commands.
12995 * source-cache.c (source_cache::get_source_lines): Check
12996 source_styling.
12997 * cli/cli-style.c (source_styling): New global.
12998 (_initialize_cli_style): Add "style sources" commands.
12999 (show_style_sources): New function.
13000 * cli/cli-style.h (source_styling): Declare.
13001
13002 2019-03-14 Pedro Alves <palves@redhat.com>
13003 Tom Tromey <tromey@adacore.com>
13004
13005 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13006 * tui/tui-winsource.c (tui_refill_source_window): New function,
13007 from...
13008 (tui_horizontal_source_scroll): ... here. Move some logic.
13009 * cli/cli-style.c (set_style_enabled): Notify new observable.
13010 * tui/tui-hooks.c (tui_redisplay_source): New function.
13011 (tui_attach_detach_observers): Attach or detach
13012 tui_redisplay_source.
13013 * observable.h (source_styling_changed): New observable.
13014 * observable.c: Define source_styling_changed observable.
13015
13016 2019-03-13 Tom Tromey <tromey@adacore.com>
13017
13018 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13019 (i386_gnu_nat_target::store_registers): Update.
13020 * target-debug.h (target_debug_print_std_string): New macro.
13021 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13022 * windows-tdep.c (display_one_tib): Update.
13023 * tui/tui-stack.c (tui_make_status_line): Update.
13024 * top.c (print_inferior_quit_action): Update.
13025 * thread.c (thr_try_catch_cmd): Update.
13026 (add_thread_with_info): Update.
13027 (thread_target_id_str): Update.
13028 (thr_try_catch_cmd): Update.
13029 (thread_command): Update.
13030 (thread_find_command): Update.
13031 * record-btrace.c (record_btrace_target::info_record)
13032 (record_btrace_resume_thread, record_btrace_target::resume)
13033 (record_btrace_cancel_resume, record_btrace_step_thread)
13034 (record_btrace_target::wait, record_btrace_target::wait)
13035 (record_btrace_target::wait, record_btrace_target::stop): Update.
13036 * progspace.c (print_program_space): Update.
13037 * process-stratum-target.c
13038 (process_stratum_target::thread_address_space): Update.
13039 * linux-fork.c (linux_fork_mourn_inferior)
13040 (detach_checkpoint_command, info_checkpoints_command)
13041 (linux_fork_context): Update.
13042 (linux_fork_detach): Update.
13043 (class scoped_switch_fork_info): Update.
13044 (delete_checkpoint_command): Update.
13045 * infrun.c (follow_fork_inferior): Update.
13046 (follow_fork_inferior): Update.
13047 (proceed_after_vfork_done): Update.
13048 (handle_vfork_child_exec_or_exit): Update.
13049 (follow_exec): Update.
13050 (displaced_step_prepare_throw): Update.
13051 (displaced_step_restore): Update.
13052 (start_step_over): Update.
13053 (resume_1): Update.
13054 (clear_proceed_status_thread): Update.
13055 (proceed): Update.
13056 (print_target_wait_results): Update.
13057 (do_target_wait): Update.
13058 (context_switch): Update.
13059 (stop_all_threads): Update.
13060 (restart_threads): Update.
13061 (finish_step_over): Update.
13062 (handle_signal_stop): Update.
13063 (switch_back_to_stepped_thread): Update.
13064 (keep_going_pass_signal): Update.
13065 (print_exited_reason): Update.
13066 (normal_stop): Update.
13067 * inferior.c (inferior_pid_to_str): Change return type.
13068 (print_selected_inferior): Update.
13069 (add_inferior): Update.
13070 (detach_inferior): Update.
13071 * dummy-frame.c (fprint_dummy_frames): Update.
13072 * dcache.c (dcache_info_1): Update.
13073 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13074 (btrace_fetch, btrace_clear): Update.
13075 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13076 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13077 type.
13078 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13079 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13080 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13081 * gdbarch.c, gdbarch.h: Rebuild.
13082 * gdbarch.sh (core_pid_to_str): Change return type.
13083 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13084 return type.
13085 (windows_nat_target::pid_to_str): Change return type.
13086 (windows_delete_thread): Update.
13087 (windows_nat_target::attach): Update.
13088 (windows_nat_target::files_info): Update.
13089 * target-delegates.c: Rebuild.
13090 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13091 return type.
13092 (sol_thread_target::pid_to_str): Change return type.
13093 * remote.c (class remote_target) <pid_to_str>: Change return
13094 type.
13095 (remote_target::pid_to_str): Change return type.
13096 (extended_remote_target::attach, remote_target::remote_stop_ns)
13097 (remote_target::remote_notif_remove_queued_reply)
13098 (remote_target::push_stop_reply, remote_target::disable_btrace):
13099 Update.
13100 (extended_remote_target::attach): Update.
13101 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13102 type.
13103 (gdbsim_target::pid_to_str): Change return type.
13104 * ravenscar-thread.c (struct ravenscar_thread_target)
13105 <pid_to_str>: Change return type.
13106 (ravenscar_thread_target::pid_to_str): Change return type.
13107 * procfs.c (class procfs_target) <pid_to_str>: Change return
13108 type.
13109 (procfs_target::pid_to_str): Change return type.
13110 (procfs_target::attach): Update.
13111 (procfs_target::detach): Update.
13112 (procfs_target::fetch_registers): Update.
13113 (procfs_target::store_registers): Update.
13114 (procfs_target::wait): Update.
13115 (procfs_target::files_info): Update.
13116 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13117 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13118 return type.
13119 (nto_procfs_target::pid_to_str): Change return type.
13120 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13121 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13122 return type.
13123 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13124 (exit_lwp): Update.
13125 (attach_proc_task_lwp_callback, get_detach_signal)
13126 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13127 (linux_nat_target::resume, wait_lwp, stop_callback)
13128 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13129 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13130 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13131 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13132 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13133 type.
13134 (inf_ptrace_target::attach): Update.
13135 (inf_ptrace_target::files_info): Update.
13136 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13137 type.
13138 (go32_nat_target::pid_to_str): Change return type.
13139 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13140 (gnu_nat_target::wait): Update.
13141 (gnu_nat_target::wait): Update.
13142 (gnu_nat_target::resume): Update.
13143 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13144 (fbsd_nat_target::wait): Update.
13145 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13146 type.
13147 (darwin_nat_target::attach): Update.
13148 * corelow.c (class core_target) <pid_to_str>: Change return type.
13149 (core_target::pid_to_str): Change return type.
13150 * target.c (normal_pid_to_str): Change return type.
13151 (default_pid_to_str): Likewise.
13152 (target_pid_to_str): Change return type.
13153 (target_translate_tls_address): Update.
13154 (target_announce_detach): Update.
13155 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13156 return type.
13157 (bsd_uthread_target::pid_to_str): Change return type.
13158 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13159 type.
13160 (bsd_kvm_target::pid_to_str): Change return type.
13161 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13162 return type.
13163 (aix_thread_target::pid_to_str): Change return type.
13164 * target.h (struct target_ops) <pid_to_str>: Change return type.
13165 (target_pid_to_str, normal_pid_to_str): Likewise.
13166 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13167 type.
13168 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13169 type.
13170 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13171 return type.
13172 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13173 type.
13174 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13175 type.
13176 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13177 return type.
13178
13179 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13180
13181 * NEWS: Mention that the new default MI version is 3. Mention
13182 changes to the output of commands and events that deal with
13183 multi-location breakpoints.
13184 * breakpoint.c: Include "mi/mi-out.h".
13185 (print_one_breakpoint): Change output syntax if using MI version
13186 >= 3.
13187 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13188 New.
13189 (mi_multi_location_breakpoint_output_fixed): New.
13190 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13191 (mi_cmd_fix_multi_location_breakpoint_output): New.
13192 (mi_multi_location_breakpoint_output_fixed): New.
13193 * mi/mi-cmds.c (mi_cmds): Register command
13194 -fix-multi-location-breakpoint-output.
13195 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13196 interpreter "mi".
13197
13198 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13199
13200 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13201 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13202 instantiate mi_ui_out based on interpreter name.
13203 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13204 * mi/mi-main.c (mi_load_progress): Likewise.
13205
13206 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13207
13208 * NEWS: Combine separate "New targets" sections for 8.3.
13209
13210 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13211
13212 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13213 (ppcfbsd_init_abi): Install gdbarch
13214 "fetch_tls_load_module_address" and "get_thread_local_address"
13215 methods.
13216
13217 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13218
13219 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13220 (riscv_fbsd_init_abi): Install gdbarch
13221 "fetch_tls_load_module_address" and "get_thread_local_address"
13222 methods.
13223
13224 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13225
13226 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13227 (i386fbsd_init_abi): Install gdbarch
13228 "fetch_tls_load_module_address" and "get_thread_local_address"
13229 methods.
13230
13231 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13232
13233 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13234 (amd64fbsd_init_abi): Install gdbarch
13235 "fetch_tls_load_module_address" and "get_thread_local_address"
13236 methods.
13237
13238 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13239
13240 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13241 (struct fbsd_pspace_data): New type.
13242 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13243 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13244 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13245 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13246 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13247
13248 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13249
13250 * gdbtypes.c (lookup_struct_elt): New function.
13251 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13252 * gdbtypes.h (struct struct_elt): New type.
13253 (lookup_struct_elt): New prototype.
13254
13255 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13256
13257 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13258 remove disabled code block.
13259
13260 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13261
13262 * gdbarch.sh (get_thread_local_address): New method.
13263 * gdbarch.h, gdbarch.c: Regenerate.
13264 * target.c (target_translate_tls_address): Use
13265 gdbarch_get_thread_local_address if present instead of
13266 target::get_thread_local_address.
13267
13268 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13269
13270 * target.h (target::get_thread_local_address): Update comment.
13271
13272 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13273
13274 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13275 objfile->separate_debug_objfile_backlink if not NULL.
13276
13277 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13278
13279 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13280 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13281 (amd64bsd_store_inferior_registers): Likewise.
13282 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13283 Enable segment base registers.
13284 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13285 PT_GETFSBASE and PT_GETGSBASE.
13286 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13287 PT_SETGSBASE.
13288 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13289 segment base registers.
13290 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13291
13292 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13293
13294 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13295 Update calls to i386_target_description to add 'segments'
13296 parameter.
13297 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13298 add segment base registers.
13299 * arch/i386.c (i386_create_target_description): Add 'segments'
13300 parameter to enable segment base registers.
13301 * arch/i386.h (i386_create_target_description): Likewise.
13302 * features/i386/32bit-segments.xml: New file.
13303 * features/i386/32bit-segments.c: Generate.
13304 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13305 call to i386_target_description to add 'segments' parameter.
13306 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13307 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13308 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13309 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13310 if feature is present.
13311 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13312 Add 'segments' parameter to call to i386_target_description.
13313 (i386_target_description): Add 'segments' parameter to enable
13314 segment base registers.
13315 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13316 to call to i386_target_description.
13317 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13318 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13319 Define I386_NUM_REGS.
13320 (i386_target_description): Add 'segments' parameter to enable
13321 segment base registers.
13322
13323 2019-03-12 Eli Zaretskii <eliz@gnu.org>
13324
13325 PR/24325
13326 * source-cache.c: #undef open and close, to avoid unresolved
13327 externals during linking.
13328
13329 2019-03-12 Tom Tromey <tromey@adacore.com>
13330
13331 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13332 const. Add initializers.
13333 (_initialize_remote): Don't initialize ptid globals.
13334
13335 2019-03-12 Pedro Alves <palves@redhat.com>
13336
13337 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13338
13339 2019-03-12 Pedro Alves <palves@redhat.com>
13340
13341 * cp-name-parser.y (main): Remove unused 'len' variable.
13342
13343 2019-03-12 Tom Tromey <tromey@adacore.com>
13344
13345 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13346 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13347
13348 2019-03-12 Tom Tromey <tromey@adacore.com>
13349
13350 * linux-nat.c (iterate_over_lwps): Update.
13351 (stop_callback): Remove parameter.
13352 (stop_wait_callback, detach_callback, resume_set_callback)
13353 (select_singlestep_lwp_callback, set_ignore_sigint)
13354 (status_callback, resumed_callback, resume_clear_callback)
13355 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13356 data parameter.
13357 (linux_nat_target::detach, linux_nat_target::resume)
13358 (linux_stop_and_wait_all_lwps, select_event_lwp)
13359 (linux_nat_filter_event, linux_nat_wait_1)
13360 (linux_nat_target::kill, linux_nat_target::stop)
13361 (linux_nat_target::stop): Update.
13362 (linux_nat_resume_callback): Change type.
13363 (resume_stopped_resumed_lwps, count_events_callback)
13364 (select_event_lwp_callback): Likewise.
13365 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13366 * arm-linux-nat.c (struct update_registers_data): Remove.
13367 (update_registers_callback): Change type.
13368 (arm_linux_insert_hw_breakpoint1): Update.
13369 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13370 parameter.
13371 (x86_linux_dr_set_addr): Update.
13372 (x86_linux_dr_set_control): Update.
13373 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13374 (iterate_over_lwps): Use gdb::function_view.
13375 * nat/aarch64-linux-hw-point.c (struct
13376 aarch64_dr_update_callback_param): Remove.
13377 (debug_reg_change_callback): Change type.
13378 (aarch64_notify_debug_reg_change): Update.
13379 * s390-linux-nat.c (s390_refresh_per_info): Update.
13380
13381 2019-03-11 Tom Tromey <tromey@adacore.com>
13382
13383 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13384 redundant assignment to "this_cu".
13385
13386 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13387
13388 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13389
13390 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13391
13392 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13393 from...
13394 (rank_one_type): ... this.
13395
13396 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13397
13398 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13399 from...
13400 (rank_one_type): ... this.
13401
13402 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13403
13404 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13405 from...
13406 (rank_one_type): ... this.
13407
13408 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13409
13410 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13411 from...
13412 (rank_one_type): ... this.
13413
13414 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13415
13416 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13417 from...
13418 (rank_one_type): ... this.
13419
13420 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13421
13422 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13423 from...
13424 (rank_one_type): ... this.
13425
13426 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13427
13428 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13429 from...
13430 (rank_one_type): ... this.
13431
13432 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13433
13434 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13435 from...
13436 (rank_one_type): ... this.
13437
13438 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13439
13440 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13441 from...
13442 (rank_one_type): ... this.
13443
13444 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13445
13446 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13447 from...
13448 (rank_one_type): ... this.
13449
13450 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13451
13452 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13453 from...
13454 (rank_one_type): ... this.
13455
13456 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13457
13458 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13459 from...
13460 (rank_one_type): ... this.
13461
13462 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13463
13464 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13465 inferior-events' shows the example events.
13466
13467 2019-03-08 Eli Zaretskii <eliz@gnu.org>
13468
13469 Support styling on native MS-Windows console
13470
13471 PR/24315
13472 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13473 on MS-Windows if $TERM is not defined.
13474
13475 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13476
13477 * posix-hdep.c (gdb_console_fputs):
13478 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13479 functions.
13480 * ui-file.h (gdb_console_fputs): Add prototype.
13481
13482 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13483 back to fputs only if the former returns zero.
13484
13485 2019-03-07 Tom Tromey <tom@tromey.com>
13486
13487 * symmisc.c (print_symbol_bcache_statistics): Update.
13488 (print_objfile_statistics): Update.
13489 * symfile.c (allocate_symtab): Update.
13490 * stabsread.c: Don't include bcache.h.
13491 * psymtab.h (struct psymbol_bcache): Don't declare.
13492 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13493 (psymbol_bcache_init, psymbol_bcache_free)
13494 (psymbol_bcache_get_bcache): Don't declare.
13495 * psymtab.c (struct psymbol_bcache): Remove.
13496 (psymtab_storage::psymtab_storage): Update.
13497 (psymtab_storage::~psymtab_storage): Update.
13498 (psymbol_bcache_init, psymbol_bcache_free)
13499 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13500 (add_psymbol_to_bcache): Update.
13501 (allocate_psymtab): Update.
13502 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13503 macro_cache>: No longer pointers.
13504 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13505 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13506 * macrotab.c (macro_bcache): Update.
13507 * macroexp.c: Don't include bcache.h.
13508 * gdbtypes.c (check_types_worklist): Update.
13509 (types_deeply_equal): Remove TRY/CATCH. Update.
13510 * elfread.c (elf_symtab_read): Update.
13511 * dwarf2read.c: Don't include bcache.h.
13512 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13513 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13514 (print_bcache_statistics, bcache_memory_used): Don't declare.
13515 (struct bcache): Move from bcache.c. Add constructor, destructor,
13516 methods. Rename all data members.
13517 * bcache.c (struct bcache): Move to bcache.h.
13518 (bcache::expand_hash_table): Rename from expand_hash_table.
13519 (bcache): Remove.
13520 (bcache::insert): Rename from bcache_full.
13521 (bcache::compare): Rename from bcache_compare.
13522 (bcache_xmalloc): Remove.
13523 (bcache::~bcache): Rename from bcache_xfree.
13524 (bcache::print_statistics): Rename from print_bcache_statistics.
13525 (bcache::memory_used): Rename from bcache_memory_used.
13526
13527 2019-03-07 Pedro Alves <palves@redhat.com>
13528
13529 * infrun.c (normal_stop): Also check for
13530 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13531
13532 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13533
13534 * f-lang.c (value_from_host_double): Moved to...
13535 * value.c (value_from_host_double): ...here.
13536 * value.h (value_from_host_double): Declare.
13537 * guile/scm-math.c (vlscm_convert_typed_number): Use
13538 value_from_host_double.
13539 (vlscm_convert_number): Likewise.
13540 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13541 * python/py-value.c (convert_value_from_python): Likewise.
13542
13543 2019-03-06 Tom Tromey <tom@tromey.com>
13544
13545 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13546
13547 2019-03-06 Tom Tromey <tom@tromey.com>
13548
13549 * utils.h (free_current_contents): Don't declare.
13550 * utils.c (free_current_contents): Remove.
13551
13552 2019-03-06 Tom Tromey <tom@tromey.com>
13553
13554 * top.c (quit_force): Update.
13555 * main.c (captured_command_loop): Update.
13556 * common/new-op.c (operator new): Update.
13557 * common/common-exceptions.c (struct catcher)
13558 <save_cleanup_chain>: Remove member.
13559 (exceptions_state_mc_init): Update.
13560 (exception_try_scope_entry): Return nullptr.
13561 (exception_try_scope_exit, exception_rethrow)
13562 (throw_exception_sjlj, throw_exception_cxx): Update.
13563 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13564 (all_cleanups, do_cleanups, discard_cleanups)
13565 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13566 (restore_cleanups, restore_final_cleanups): Don't declare.
13567 (do_final_cleanups): Remove parameter.
13568 * common/cleanups.c (cleanup_chain, make_cleanup)
13569 (make_cleanup_dtor, all_cleanups, do_cleanups)
13570 (discard_my_cleanups, discard_cleanups)
13571 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13572 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13573 (null_cleanup): Remove.
13574 (do_final_cleanups): Remove parameter.
13575
13576 2019-03-06 Tom Tromey <tom@tromey.com>
13577
13578 * remote.c (remote_target::remote_parse_stop_reply): Use
13579 unique_xmalloc_ptr.
13580
13581 2019-03-06 Tom Tromey <tom@tromey.com>
13582
13583 * stabsread.c (struct stabs_field_info): Rename from field_info.
13584 <list, fnlist>: Add initializers.
13585 <obstack>: New member.
13586 (read_member_functions, read_struct_fields, read_baseclasses):
13587 Allocate on obstack. Don't use cleanups.
13588 (read_one_struct_field, read_member_functions, read_struct_fields)
13589 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13590 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13591 (read_struct_type): Update.
13592
13593 2019-03-06 Tom Tromey <tom@tromey.com>
13594
13595 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13596 * common/filestuff.h (make_cleanup_close): Don't declare.
13597 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13598 Remove.
13599
13600 2019-03-06 Tom Tromey <tom@tromey.com>
13601
13602 * solib-aix.c: Use make_scope_exit.
13603
13604 2019-03-06 Tom Tromey <tom@tromey.com>
13605
13606 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13607 Use make_scope_exit.
13608
13609 2019-03-06 Tom Tromey <tom@tromey.com>
13610
13611 * solib-svr4.c (disable_probes_interface): Remove parameter.
13612 (svr4_handle_solib_event): Use make_scope_exit.
13613
13614 2019-03-06 Tom Tromey <tom@tromey.com>
13615
13616 * remote.c (struct stop_reply_deleter): Remove.
13617 (stop_reply_up): Update.
13618 (struct stop_reply): Derive from notif_event. Don't typedef.
13619 <regcache>: Now a std::vector.
13620 (stop_reply_xfree): Remove.
13621 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13622 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13623 (remote_target::discard_pending_stop_replies): Use delete.
13624 (remote_target::remote_parse_stop_reply): Update.
13625 (remote_target::process_stop_reply): Update.
13626 * remote-notif.h (struct notif_event): Add virtual destructor.
13627 Remove "dtr" member.
13628 (struct notif_client) <alloc_event>: Return a unique_ptr.
13629 (notif_event_xfree): Don't declare.
13630 (notif_event_up): New typedef.
13631 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13632 (notif_event_xfree, do_notif_event_xfree): Remove.
13633 (remote_notif_state_xfree): Update.
13634
13635 2019-03-06 Tom Tromey <tom@tromey.com>
13636
13637 * infrun.c (displaced_step_clear_cleanup): Now a
13638 forward_scope_exit type.
13639 (displaced_step_prepare_throw): Update.
13640 (displaced_step_fixup): Update.
13641
13642 2019-03-06 Tom Tromey <tom@tromey.com>
13643
13644 * inferior.h (class inferior): Update comment.
13645 * gdbthread.h (class thread_info): Update comment.
13646
13647 2019-03-06 Joel Brobecker <brobecker@adacore.com>
13648 Tom Tromey <tom@tromey.com>
13649
13650 * stabsread.h (struct stab_section_list): Remove.
13651 (coffstab_build_psymtabs): Update.
13652 * dbxread.c (symbuf_sections): Now a std::vector.
13653 (sect_idx): New global.
13654 (fill_symbuf): Update.
13655 (coffstab_build_psymtabs): Change type of stabsects parameter.
13656 Update.
13657 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13658 std::vector.
13659 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13660 (coff_locate_sections): Update.
13661 (coff_symfile_read): Remove cleanups. Update.
13662 (init_stringtab): Add storage parameter.
13663 (free_stringtab, free_stringtab_cleanup): Remove.
13664 (init_lineno): Add storage parameter.
13665 (free_linetab, free_linetab_cleanup): Remove.
13666
13667 2019-03-06 Pedro Alves <palves@redhat.com>
13668
13669 * linux-fork.c (fork_info::clobber_regs): Delete.
13670 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13671 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13672 comment. Adjust.
13673 (scoped_switch_fork_info::scoped_switch_fork_info)
13674 (checkpoint_command, linux_fork_context): Adjust
13675 fork_save_infrun_state calls.
13676
13677 2019-03-06 Pedro Alves <palves@redhat.com>
13678
13679 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13680 (inf_has_multiple_threads): Return 'bool' and rewrite using
13681 inferior_info::threads().
13682
13683 2019-03-06 Pedro Alves <palves@redhat.com>
13684
13685 * linux-fork.c: Include <list>.
13686 (fork_list): Now a std::list instance.
13687 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13688 (forks_exist_p, find_last_fork): Adjust.
13689 (new_fork): Delete.
13690 (one_fork_p): New.
13691 (add_fork): Adjust.
13692 (free_fork): Delete, folded into fork_info::~fork_info().
13693 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13694 Adjust.
13695 (init_fork_list): Delete.
13696 (linux_fork_killall, linux_fork_mourn_inferior)
13697 (linux_fork_detach, info_checkpoints_command): Adjust.
13698 (_initialize_linux_fork): No longer call init_fork_list.
13699
13700 2019-03-06 Pedro Alves <palves@redhat.com>
13701
13702 * linux-fork.c (new_fork): New, split out of ...
13703 (add_fork): ... this. Return void. Move "first fork" special
13704 case from here, to ...
13705 (checkpoint_command): ... here.
13706 * linux-linux.h (add_fork): Return void.
13707
13708 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13709
13710 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13711
13712 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13713 Chris January <chris.january@arm.com>
13714 David Lecomber <david.lecomber@arm.com>
13715
13716 * f-exp.y: New token, UNOP_INTRINSIC.
13717 (exp): New pattern using UNOP_INTRINSIC token.
13718 (f77_keywords): Add 'abs' keyword.
13719 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13720 (value_from_host_double): New function.
13721 (evaluate_subexp_f): Support UNOP_ABS.
13722
13723 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13724
13725 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13726 types.
13727
13728 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13729
13730 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13731 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13732 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13733
13734 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13735
13736 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13737
13738 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13739 Chris January <chris.january@arm.com>
13740
13741 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13742 * f-exp.y: Define 'KIND' token.
13743 (exp): New pattern for KIND expressions.
13744 (ptype): Handle types with a kind extension.
13745 (direct_abs_decl): Extend to spot kind extensions.
13746 (f77_keywords): Add 'kind' to the list.
13747 (push_kind_type): New function.
13748 (convert_to_kind_type): New function.
13749 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13750 * parse.c (operator_length_standard): Likewise.
13751 * parser-defs.h (enum type_pieces): Add tp_kind.
13752 * std-operator.def: Add UNOP_KIND.
13753
13754 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13755
13756 * f-exp.y (f_parse): Set yydebug.
13757
13758 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13759
13760 * f-lang.c (evaluate_subexp_f): New function.
13761 (exp_descriptor_f): New global.
13762 (f_language_defn): Use exp_descriptor_f instead of
13763 exp_descriptor_standard.
13764
13765 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13766
13767 * f-exp.y (struct token): Add comments.
13768 (dot_ops): Remove uppercase versions and the end marker.
13769 (f77_keywords): Likewise.
13770 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13771 entries in the dot_ops array are case insensitive, and use
13772 strncasecmp to compare strings. Also some whitespace cleanup in
13773 this area. Similar for the f77_keywords array, except entries in
13774 this list might be case sensitive.
13775
13776 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13777
13778 * f-exp.y (struct f77_boolean_val): Add comments.
13779 (boolean_values): Remove uppercase versions, and end marker.
13780 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13781 and use strncasecmp to achieve case insensitivity. Additionally,
13782 perform whitespace cleanup around this code.
13783
13784 2019-03-06 Tom Tromey <tromey@adacore.com>
13785
13786 * remote-sim.c (gdbsim_target_open): Use result of
13787 gdb_argv::release.
13788
13789 2019-03-06 Richard Bunt <richard.bunt@arm.com>
13790 Dirk Schubert <dirk.schubert@arm.com>
13791 Chris January <chris.january@arm.com>
13792
13793 * eval.c (evaluate_subexp_standard): Call Fortran argument
13794 wrapping logic.
13795 * f-lang.c (struct value): A value which can be passed into a
13796 Fortran function call.
13797 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13798 where appropriate.
13799 (struct type): Value ready for a Fortran function call.
13800 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13801 is needed.
13802 * f-lang.h (fortran_argument_convert): Declaration.
13803 (fortran_preserve_arg_pointer): Declaration.
13804 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13805
13806 2019-03-05 Tom Tromey <tromey@adacore.com>
13807
13808 * python/py-prettyprint.c (print_string_repr): Remove #if.
13809 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13810
13811 2019-03-05 Tom Tromey <tromey@adacore.com>
13812
13813 * target.c (the_dummy_target): Move later. Change type to
13814 "dummy_target".
13815 (initialize_targets): Don't initialize the_dummy_target.
13816
13817 2019-03-05 Tom Tromey <tromey@adacore.com>
13818
13819 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13820 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13821
13822 2019-03-05 Tom Tromey <tromey@adacore.com>
13823
13824 * windows-nat.c (windows_nat_target::attach)
13825 (windows_nat_target::detach): Don't call gdb_flush.
13826 * valprint.c (generic_val_print, val_print, val_print_string):
13827 Don't call gdb_flush.
13828 * utils.c (defaulted_query): Don't call gdb_flush.
13829 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13830 * target.c (target_announce_detach): Don't call gdb_flush.
13831 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13832 * remote.c (extended_remote_target::attach): Don't call
13833 gdb_flush.
13834 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13835 * printcmd.c (do_examine): Don't call gdb_flush.
13836 (info_display_command): Don't call gdb_flush.
13837 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13838 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13839 * memattr.c (info_mem_command): Don't call gdb_flush.
13840 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13841 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13842 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13843 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13844 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13845 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13846 (gnu_nat_target::detach): Don't call gdb_flush.
13847 * f-valprint.c (f_val_print): Don't call gdb_flush.
13848 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13849 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13850 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13851 gdb_flush.
13852 * c-valprint.c (c_val_print): Don't call gdb_flush.
13853 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13854
13855 2019-03-05 Tom Tromey <tromey@adacore.com>
13856
13857 * varobj.c (update_dynamic_varobj_children): Update.
13858 (install_default_visualizer): Use reset, not release.
13859 * value.c (set_internalvar): Update.
13860 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13861 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13862 ATTRIBUTE_UNUSED_RESULT.
13863
13864 2019-03-05 Tom Tromey <tromey@adacore.com>
13865
13866 * remote.c (class scoped_remote_fd) <release>: Add
13867 ATTRIBUTE_UNUSED_RESULT.
13868
13869 2019-03-05 Tom Tromey <tromey@adacore.com>
13870
13871 * macroexp.c (struct macro_buffer) <release>: Add
13872 ATTRIBUTE_UNUSED_RESULT.
13873
13874 2019-03-05 Tom Tromey <tromey@adacore.com>
13875
13876 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13877 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13878 ATTRIBUTE_UNUSED_RESULT.
13879
13880 2019-03-05 Tom Tromey <tromey@adacore.com>
13881
13882 * common/scoped_fd.h (class scoped_fd) <release>: Add
13883 ATTRIBUTE_UNUSED_RESULT.
13884
13885 2019-03-05 Tom Tromey <tromey@adacore.com>
13886
13887 * parser-defs.h (struct parser_state) <release>: Add
13888 ATTRIBUTE_UNUSED_RESULT.
13889
13890 2019-03-05 Tom Tromey <tromey@adacore.com>
13891
13892 * utils.h (class gdb_argv) <release>: Add
13893 ATTRIBUTE_UNUSED_RESULT.
13894 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13895
13896 2019-03-02 Eli Zaretskii <eliz@gnu.org>
13897
13898 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13899 for-loop range, to avoid compiler warnings.
13900
13901 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13902 avoid compiler warnings about unused variables.
13903
13904 * NEWS: Mention end of support for native debugging on MS-Windows
13905 before XP.
13906
13907 PR gdb/24292
13908 * common/netstuff.c:
13909 * gdbserver/gdbreplay.c
13910 * gdbserver/remote-utils.c:
13911 * ser-tcp.c:
13912 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13913 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
13914 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13915 'getaddrinfo' and 'freeaddrinfo' were not available before
13916 Windows XP, and mingw.org's MinGW headers by default define
13917 _WIN32_WINNT to 0x500.
13918
13919 2019-03-01 Gary Benson <gbenson@redhat.com>
13920
13921 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13922
13923 2019-02-28 Brian Vandenberg <phantall@gmail.com>
13924 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
13925
13926 PR gdb/8527
13927 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13928 set_sigint_trap, clear_sigint_trap.
13929
13930 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13931
13932 * target.c (target_detach): Clear the regcache and the
13933 frame cache.
13934
13935 2019-02-27 Pedro Alves <palves@redhat.com>
13936
13937 * utils.c (set_screen_size): When we cap the height/width sizes,
13938 tweak the corresponding command variable to show "unlimited":
13939
13940 2019-02-27 Saagar Jha <saagar@saagarjha.com>
13941 Pedro Alves <palves@redhat.com>
13942
13943 * utils.c (set_screen_size): Reduce "infinite" rows and columns
13944 before calling rl_set_screen_size.
13945
13946 2019-02-27 Tom Tromey <tromey@adacore.com>
13947
13948 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13949 define.
13950 * python/py-value.c: Remove Python 2.4 workaround.
13951 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13952 workaround.
13953 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13954 Python 2.4 workaround.
13955 * python/python-internal.h: Remove Python 2.4 comment.
13956 (Py_ssize_t): Don't define.
13957 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13958 (gdb_Py_DECREF): Remove Python 2.4 workaround.
13959 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13960 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13961 * python/python.c (do_start_initialization): Remove Python 2.4
13962 workaround.
13963 * python/py-prettyprint.c (class dummy_python_frame): Remove.
13964 (print_children): Remove Python 2.4 workaround.
13965 * python/py-inferior.c (buffer_procs): Remove Python 2.4
13966 workaround.
13967 (CHARBUFFERPROC_NAME): Remove.
13968 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13969 Python 2.4 workaround.
13970
13971 2019-02-27 Kevin Buettner <kevinb@redhat.com>
13972
13973 * NEWS: Note minimum Python version.
13974
13975 2019-02-27 Kevin Buettner <kevinb@redhat.com>
13976
13977 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13978 code from these functions. Remove corresponding ifdefs. Use
13979 Py_buffer_up instead of explicit calls to PyBuffer_Release.
13980 Remove gotos and target of gotos.
13981 (infpy_search_memory): Likewise.
13982
13983 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13984
13985 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13986 (hppa_gdbarch_init): Don't register deleted functions with
13987 gdbarch.
13988
13989 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13990
13991 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13992 (h8300_unwind_sp): Delete.
13993 (h8300_dummy_id): Delete.
13994 (h8300_gdbarch_init): Don't register deleted functions with
13995 gdbarch.
13996
13997 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13998
13999 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14000 (ft32_unwind_pc): Delete.
14001 (ft32_unwind_sp): Delete.
14002 (ft32_gdbarch_init): Don't register deleted functions with
14003 gdbarch.
14004
14005 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14006
14007 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14008 (frv_unwind_pc): Delete.
14009 (frv_unwind_sp): Delete.
14010 (frv_gdbarch_init): Don't register deleted functions with
14011 gdbarch.
14012
14013 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14014
14015 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14016 (riscv_unwind_pc): Delete.
14017 (riscv_unwind_sp): Delete.
14018 (riscv_gdbarch_init): Don't register deleted functions with
14019 gdbarch.
14020
14021 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14022
14023 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14024 (csky_unwind_pc): Delete.
14025 (csky_unwind_sp): Delete.
14026 (csky_gdbarch_init): Don't register deleted functions with
14027 gdbarch.
14028
14029 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14030
14031 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14032 (cris_unwind_pc): Delete.
14033 (cris_unwind_sp): Delete.
14034 (cris_gdbarch_init): Don't register deleted functions with
14035 gdbarch.
14036
14037 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14038
14039 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14040 (bfin_unwind_pc): Delete.
14041 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14042
14043 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14044
14045 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14046 (arm_unwind_pc): Delete.
14047 (arm_unwind_sp): Delete.
14048 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14049
14050 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14051
14052 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14053 (arc_unwind_pc): Delete.
14054 (arc_unwind_sp): Delete.
14055 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14056
14057 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14058
14059 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14060 (alpha_unwind_pc): Delete.
14061 (alpha_gdbarch_init): Don't register deleted functions with
14062 gdbarch.
14063
14064 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14065
14066 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14067 (aarch64_unwind_pc): Delete.
14068 (aarch64_unwind_sp): Delete.
14069 (aarch64_gdbarch_init): Don't register deleted functions with
14070 gdbarch.
14071
14072 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14073
14074 * gdbtypes.c (type_align): Don't consider static members when
14075 computing structure alignment.
14076
14077 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14078
14079 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14080 return 0 for other types.
14081 * arch-utils.c (default_type_align): Always return 0.
14082 * gdbarch.h: Regenerate.
14083 * gdbarch.sh (type_align): Extend comment.
14084 * gdbtypes.c (type_align): Add additional comments, always call
14085 gdbarch_type_align before applying the default rules.
14086 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14087 generic code will then apply a suitable default.
14088 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14089 types, return 0 for other types.
14090
14091 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14092
14093 * NEWS: Create a new section for the next release branch.
14094 Rename the section of the current branch, now that it has
14095 been cut.
14096
14097 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14098
14099 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14100 * version.in: Bump version to 8.3.50.DATE-git.
14101
14102 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
14103
14104 * aix-thread.c (ptid_cmp): Remove unused variable.
14105 (get_signaled_thread): Likewise.
14106 (store_regs_user_thread): Likewise.
14107 (store_regs_kernel_thread): Likewise.
14108 (fetch_regs_kernel_thread): Remove shadowed variable.
14109
14110 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14111
14112 * features/riscv/32bit-cpu.xml: Add register numbers.
14113 * features/riscv/32bit-fpu.c: Regenerate.
14114 * features/riscv/32bit-fpu.xml: Add register numbers.
14115 * features/riscv/64bit-cpu.xml: Add register numbers.
14116 * features/riscv/64bit-fpu.c: Regenerate.
14117 * features/riscv/64bit-fpu.xml: Add register numbers.
14118
14119 2019-02-26 Kevin Buettner <kevinb@redhat.com>
14120
14121 * NEWS: Mention two argument form of gdb.Value constructor.
14122 * python/py-value.c (convert_buffer_and_type_to_value): New
14123 function.
14124 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14125 Add support for handling an optional second argument. Call
14126 convert_buffer_and_type_to_value as appropriate.
14127 * python/python-internal.h (Py_buffer_deleter): New struct.
14128 (Py_buffer_up): New typedef.
14129
14130 2019-02-25 John Baldwin <jhb@FreeBSD.org>
14131
14132 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14133 instead of releasing ownership.
14134
14135 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
14136
14137 * dwarf2read.c (open_and_init_dwp_file): Call
14138 elf_numsections instead of bfd_count_sections to initialize
14139 dwp_file->num_sections.
14140
14141 2019-02-25 Tom Tromey <tromey@adacore.com>
14142
14143 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14144
14145 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14146
14147 * gcore.in: Add '--readnever' option when invoking GDB.
14148
14149 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14150
14151 * MAINTAINERS: Update my email address.
14152
14153 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14154
14155 * build-id.c (build_id_to_debug_bfd_1): New function.
14156 (build_id_to_debug_bfd): Look for separate debug file in
14157 sysroot.
14158
14159 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14160
14161 * gdbarch.sh: Update the copyright year range that is placed into
14162 generated files.
14163
14164 2019-02-22 Keith Seitz <keiths@redhat.com>
14165
14166 PR symtab/23853
14167 * linespec.c (create_sals_line_offset): Search for the default
14168 symtab's filename instead of its fullname.
14169
14170 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14171
14172 * NEWS: Update style defaults.
14173
14174 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14175
14176 * main.c (captured_main_1): Disable styling in batch mode.
14177
14178 2019-02-20 Tom Tromey <tom@tromey.com>
14179
14180 * symtab.c (symtab_symbol_info): Fix typos.
14181
14182 2019-02-20 Tom Tromey <tromey@adacore.com>
14183
14184 * findcmd.c (_initialize_mem_search): Use upper case for
14185 metasyntactic variables.
14186
14187 2019-02-20 Alan Hayward <alan.hayward@arm.com>
14188
14189 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14190 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14191
14192 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14193
14194 * top.h (source_file_name): Change to std::string.
14195 * top.c (source_file_name): Likewise.
14196 (command_line_input): Adjust.
14197 * cli/cli-script.c (script_from_file): Adjust.
14198
14199 2019-02-19 Tom Tromey <tromey@adacore.com>
14200
14201 * ravenscar-thread.c
14202 (ravenscar_thread_target::update_thread_list): Don't call
14203 ada_build_task_list.
14204 * ada-lang.h (ada_build_task_list): Don't declare.
14205 * ada-tasks.c (struct ada_tasks_inferior_data)
14206 <task_list_valid_p>: Now bool.
14207 (read_known_tasks, ada_task_list_changed)
14208 (ada_tasks_invalidate_inferior_data): Update.
14209 (read_known_tasks_array): Return bool.
14210 (read_known_tasks_list): Likewise.
14211 (read_known_tasks): Return void.
14212 (ada_build_task_list): Now static.
14213
14214 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14215
14216 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14217 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14218
14219 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14220
14221 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14222 variant for ada_tasks_pspace_data_handle and
14223 ada_tasks_inferior_data_handle.
14224 (ada_tasks_pspace_data_cleanup): New function.
14225 (ada_tasks_inferior_data_cleanup): New function.
14226
14227 2019-02-17 Tom Tromey <tom@tromey.com>
14228
14229 * macrotab.h (macro_source_fullname): Return a std::string.
14230 * macrotab.c (macro_include, check_for_redefinition)
14231 (macro_undef, macro_lookup_definition, foreach_macro)
14232 (foreach_macro_in_scope): Update.
14233 (macro_source_fullname): Return a std::string.
14234 * macrocmd.c (show_pp_source_pos): Update.
14235
14236 2019-02-17 Tom Tromey <tom@tromey.com>
14237
14238 * macrocmd.c (show_pp_source_pos): Style the file names.
14239
14240 2019-02-17 Tom Tromey <tom@tromey.com>
14241
14242 PR tui/24197:
14243 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14244
14245 2019-02-17 Tom Tromey <tom@tromey.com>
14246
14247 * ada-lang.c (user_select_syms): Use filtered printing.
14248 * utils.c (wrap_style): New global.
14249 (desired_style): Remove.
14250 (emit_style_escape): Add stream parameter.
14251 (set_output_style, reset_terminal_style, prompt_for_continue):
14252 Update.
14253 (flush_wrap_buffer): Only flush gdb_stdout.
14254 (wrap_here): Set wrap_style.
14255 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14256 treat escape sequences as a character. Change when wrap buffer is
14257 flushed.
14258 (fputs_styled): Do not set the output style when the default is
14259 requested.
14260 * ui-style.h (struct ui_file_style) <is_default>: New method.
14261 * source.c (print_source_lines_base): Emit escape sequences in one
14262 piece.
14263
14264 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14265
14266 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14267 integers and enumeration types.
14268
14269 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14270
14271 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14272 instead of lookup_symbol_in_language
14273 (do_exact_match): New function.
14274 (ada_get_symbol_name_matcher): Return do_exact_match when
14275 doing a verbatim match.
14276
14277 2019-02-15 Tom Tromey <tromey@adacore.com>
14278
14279 * ravenscar-thread.c (ravenscar_thread_target::resume)
14280 (ravenscar_thread_target::wait): Special case wildcard requests.
14281
14282 2019-02-15 Tom Tromey <tromey@adacore.com>
14283
14284 * ravenscar-thread.c (base_ptid): Remove.
14285 (struct ravenscar_thread_target) <close>: New method.
14286 <m_base_ptid>: New member.
14287 <update_inferior_ptid, active_task, task_is_currently_active,
14288 runtime_initialized>: Declare methods.
14289 <ravenscar_thread_target>: Add constructor.
14290 (ravenscar_thread_target::task_is_currently_active)
14291 (ravenscar_thread_target::update_inferior_ptid)
14292 (ravenscar_runtime_initialized): Rename. Now methods.
14293 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14294 (ravenscar_thread_target::update_thread_list): Update.
14295 (ravenscar_thread_target::active_task): Now method.
14296 (ravenscar_thread_target::store_registers)
14297 (ravenscar_thread_target::prepare_to_store)
14298 (ravenscar_thread_target::prepare_to_store)
14299 (ravenscar_thread_target::mourn_inferior): Update.
14300 (ravenscar_inferior_created): Use "new" to create target.
14301 (ravenscar_thread_target::get_ada_task_ptid): Update.
14302 (_initialize_ravenscar): Don't initialize base_ptid.
14303 (ravenscar_ops): Remove global.
14304
14305 2019-02-15 Tom Tromey <tromey@adacore.com>
14306
14307 * target.h (push_target): Declare new overload.
14308 * target.c (push_target): New overload, taking an rvalue reference.
14309 * remote.c (remote_target::open_1): Use push_target overload.
14310 * corelow.c (core_target_open): Use push_target overload.
14311
14312 2019-02-15 Tom Tromey <tromey@adacore.com>
14313
14314 * ravenscar-thread.c (is_ravenscar_task)
14315 (ravenscar_task_is_currently_active): Return bool.
14316 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14317 (_initialize_ravenscar): Remove "(void)".
14318 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14319 Return bool.
14320
14321 2019-02-15 Tom Tromey <tromey@adacore.com>
14322
14323 * ravenscar-thread.c (ravenscar_runtime_initializer)
14324 (has_ravenscar_runtime, get_running_thread_id)
14325 (ravenscar_thread_target::resume): Fix indentation.
14326
14327 2019-02-15 Tom Tromey <tromey@adacore.com>
14328
14329 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14330 from ravenscar_arch_ops.
14331 (sparc_ravenscar_ops::fetch_registers)
14332 (sparc_ravenscar_ops::store_registers): Now methods.
14333 (sparc_ravenscar_prepare_to_store): Remove.
14334 (sparc_ravenscar_ops): Redefine.
14335 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14336 methods and destructor. Remove members.
14337 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14338 (ravenscar_thread_target::store_registers)
14339 (ravenscar_thread_target::prepare_to_store): Update.
14340 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14341 Remove.
14342 (struct ppc_ravenscar_powerpc_ops): Derive from
14343 ravenscar_arch_ops.
14344 (ppc_ravenscar_powerpc_ops::fetch_registers)
14345 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14346 (ppc_ravenscar_powerpc_ops): Redefine.
14347 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14348 (ppc_ravenscar_e500_ops::fetch_registers)
14349 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14350 (ppc_ravenscar_e500_ops): Redefine.
14351 * aarch64-ravenscar-thread.c
14352 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14353 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14354 (aarch64_ravenscar_fetch_registers)
14355 (aarch64_ravenscar_store_registers): Now methods.
14356 (aarch64_ravenscar_ops): Redefine.
14357
14358 2019-02-15 Tom Tromey <tromey@adacore.com>
14359
14360 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14361 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14362 (ravenscar_thread_target::stopped_by_watchpoint)
14363 (ravenscar_thread_target::stopped_data_address)
14364 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14365
14366 2019-02-15 Tom Tromey <tromey@adacore.com>
14367
14368 * ravenscar-thread.c: Fix some typos.
14369
14370 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14371 Tom Tromey <tromey@adacore.com>
14372
14373 * ada-lang.c (ada_exception_sal): Change addr_string to a
14374 std::string.
14375 (create_ada_exception_catchpoint): Update.
14376
14377 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14378 Tom Tromey <tromey@adacore.com>
14379
14380 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14381 (bp_location_ops): Remove.
14382 (base_breakpoint_allocate_location): Update.
14383 (free_bp_location): Update.
14384 * ada-lang.c (class ada_catchpoint_location)
14385 <ada_catchpoint_location>: Remove ops parameter.
14386 (ada_catchpoint_location_dtor): Remove.
14387 (ada_catchpoint_location_ops): Remove.
14388 (allocate_location_exception): Update.
14389 * breakpoint.h (struct bp_location_ops): Remove.
14390 (class bp_location) <bp_location>: Remove bp_location_ops
14391 parameter.
14392 <~bp_location>: Add destructor.
14393 <ops>: Remove.
14394
14395 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14396 Pedro Alves <palves@redhat.com>
14397
14398 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14399 'PATH_MAX'.
14400
14401 2019-02-14 David Michael <fedora.dm0@gmail.com>
14402 Samuel Thibault <samuel.thibault@gnu.org>
14403 Thomas Schwinge <thomas@codesourcery.com>
14404
14405 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14406 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14407
14408 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14409
14410 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14411 (check_empty): Use "const char *".
14412
14413 * gnu-nat.c (gnu_nat_target::detach): Instead of
14414 'detach_inferior (pid)' call
14415 'detach_inferior (find_inferior_pid (pid))'.
14416
14417 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14418 'nat/fork-inferior.o'.
14419 * gnu-nat.c: #include "nat/fork-inferior.h".
14420
14421 * gnu-nat.c (gnu_nat_target::detach): Instead of
14422 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14423 * gnu-nat.h: #include "inf-child.h".
14424 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14425 'i386_gnu_nat_target::fetch_registers'.
14426 (gnu_store_registers): Rename/move to
14427 'i386_gnu_nat_target::store_registers'.
14428
14429 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14430 * gnu-nat.h (mach_thread_info): New function.
14431 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14432
14433 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14434
14435 2019-02-14 Frederic Konrad <konrad@adacore.com>
14436
14437 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14438
14439 2019-02-14 Joel Brobecker <brobecker@adacore.com>
14440
14441 * windows-nat.c (windows_add_thread): Add new parameter
14442 "main_thread_p" with default value set to false. Update
14443 function documentation as well as all callers.
14444 (windows_delete_thread): Likewise.
14445 (fake_create_process): Update call to windows_add_thread.
14446 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14447 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14448 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14449 call to windows_delete_thread.
14450
14451 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14452
14453 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14454
14455 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14456
14457 * symfile.c (find_separate_debug_file): Use canonical path of
14458 sysroot with child_path instead of gdb_sysroot if it is valid.
14459
14460 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14461
14462 * symfile.c (find_separate_debug_file): Use child_path to
14463 determine if an object file is under a sysroot.
14464
14465 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14466
14467 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14468 unittests/child-path-selftests.c.
14469 * common/pathstuff.c (child_path): New function.
14470 * common/pathstuff.h (child_path): New prototype.
14471 * unittests/child-path-selftests.c: New file.
14472
14473 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14474
14475 * symfile.c (find_separate_debug_file): Look for separate debug
14476 files in debug directories under the sysroot.
14477
14478 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14479
14480 * symtab.h (struct minimal_symbol data_p): New const method.
14481 (struct minimal_symbol text_p): Likewise.
14482 * symtab.c (output_source_filename): Use file name style
14483 to print file name.
14484 (print_symbol_info): Likewise.
14485 (print_msymbol_info): Use address style to print addresses.
14486 Use function name style to print executable text symbols.
14487 (expand_symtab_containing_pc): Use data_p.
14488 (find_pc_sect_compunit_symtab): Likewise.
14489
14490 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14491
14492 * breakpoint.c (describe_other_breakpoints): Use address style
14493 to print addresses.
14494 (say_where): Likewise.
14495
14496 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14497
14498 * ada-typeprint.c (print_func_type): Print function name
14499 style to print function name.
14500 * c-typeprint.c (c_print_type_1): Likewise.
14501
14502 2019-02-11 Alan Hayward <alan.hayward@arm.com>
14503
14504 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14505 for execve.
14506
14507 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14508
14509 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14510 type_stack.
14511
14512 2019-02-10 Joel Brobecker <brobecker@adacore.com>
14513
14514 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14515 TYPE_CODE_REF types.
14516
14517 2019-02-08 Jim Wilson <jimw@sifive.com>
14518
14519 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14520 (riscv_linux_fregset): New.
14521 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14522
14523 2019-02-07 Tom Tromey <tom@tromey.com>
14524
14525 * thread.c (thread_cancel_execution_command): Update.
14526 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14527 methods.
14528 (struct thread_fsm_ops): Remove.
14529 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14530 (thread_fsm_should_stop, thread_fsm_return_value)
14531 (thread_fsm_set_finished, thread_fsm_finished_p)
14532 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14533 Don't declare.
14534 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14535 * infrun.c (clear_proceed_status_thread)
14536 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14537 (print_stop_event): Update.
14538 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14539 Add constructor.
14540 (step_command_fsm_ops): Remove.
14541 (new_step_command_fsm): Remove.
14542 (step_1): Update.
14543 (step_command_fsm::should_stop): Rename from
14544 step_command_fsm_should_stop.
14545 (step_command_fsm::clean_up): Rename from
14546 step_command_fsm_clean_up.
14547 (step_command_fsm::do_async_reply_reason): Rename from
14548 step_command_fsm_async_reply_reason.
14549 (struct until_next_fsm): Inherit from thread_fsm. Add
14550 constructor.
14551 (until_next_fsm_ops): Remove.
14552 (new_until_next_fsm): Remove.
14553 (until_next_fsm::should_stop): Rename from
14554 until_next_fsm_should_stop.
14555 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14556 (until_next_fsm::do_async_reply_reason): Rename from
14557 until_next_fsm_async_reply_reason.
14558 (struct finish_command_fsm): Inherit from thread_fsm. Add
14559 constructor. Change type of breakpoint.
14560 (finish_command_fsm_ops): Remove.
14561 (new_finish_command_fsm): Remove.
14562 (finish_command_fsm::should_stop): Rename from
14563 finish_command_fsm_should_stop.
14564 (finish_command_fsm::clean_up): Rename from
14565 finish_command_fsm_clean_up.
14566 (finish_command_fsm::return_value): Rename from
14567 finish_command_fsm_return_value.
14568 (finish_command_fsm::do_async_reply_reason): Rename from
14569 finish_command_fsm_async_reply_reason.
14570 (finish_command): Update.
14571 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14572 Add constructor.
14573 (call_thread_fsm_ops): Remove.
14574 (call_thread_fsm::call_thread_fsm): Rename from
14575 new_call_thread_fsm.
14576 (call_thread_fsm::should_stop): Rename from
14577 call_thread_fsm_should_stop.
14578 (call_thread_fsm::should_notify_stop): Rename from
14579 call_thread_fsm_should_notify_stop.
14580 (run_inferior_call, call_function_by_hand_dummy): Update.
14581 * cli/cli-interp.c (should_print_stop_to_console): Update.
14582 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14583 Add constructor. Change type of location_breakpoint,
14584 caller_breakpoint.
14585 (until_break_fsm_ops): Remove.
14586 (new_until_break_fsm): Remove.
14587 (until_break_fsm::should_stop): Rename from
14588 until_break_fsm_should_stop.
14589 (until_break_fsm::clean_up): Rename from
14590 until_break_fsm_clean_up.
14591 (until_break_fsm::do_async_reply_reason): Rename from
14592 until_break_fsm_async_reply_reason.
14593 (until_break_command): Update.
14594 * thread-fsm.c: Remove.
14595 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14596
14597 2019-02-07 Tom Tromey <tom@tromey.com>
14598
14599 * yy-remap.h: Add include guard.
14600 * xtensa-tdep.h: Add include guard.
14601 * xcoffread.h: Rename include guard.
14602 * varobj-iter.h: Add include guard.
14603 * tui/tui.h: Rename include guard.
14604 * tui/tui-winsource.h: Rename include guard.
14605 * tui/tui-wingeneral.h: Rename include guard.
14606 * tui/tui-windata.h: Rename include guard.
14607 * tui/tui-win.h: Rename include guard.
14608 * tui/tui-stack.h: Rename include guard.
14609 * tui/tui-source.h: Rename include guard.
14610 * tui/tui-regs.h: Rename include guard.
14611 * tui/tui-out.h: Rename include guard.
14612 * tui/tui-layout.h: Rename include guard.
14613 * tui/tui-io.h: Rename include guard.
14614 * tui/tui-hooks.h: Rename include guard.
14615 * tui/tui-file.h: Rename include guard.
14616 * tui/tui-disasm.h: Rename include guard.
14617 * tui/tui-data.h: Rename include guard.
14618 * tui/tui-command.h: Rename include guard.
14619 * tic6x-tdep.h: Add include guard.
14620 * target/waitstatus.h: Rename include guard.
14621 * target/wait.h: Rename include guard.
14622 * target/target.h: Rename include guard.
14623 * target/resume.h: Rename include guard.
14624 * target-float.h: Rename include guard.
14625 * stabsread.h: Add include guard.
14626 * rs6000-tdep.h: Add include guard.
14627 * riscv-fbsd-tdep.h: Add include guard.
14628 * regformats/regdef.h: Rename include guard.
14629 * record.h: Rename include guard.
14630 * python/python.h: Rename include guard.
14631 * python/python-internal.h: Rename include guard.
14632 * python/py-stopevent.h: Rename include guard.
14633 * python/py-ref.h: Rename include guard.
14634 * python/py-record.h: Rename include guard.
14635 * python/py-record-full.h: Rename include guard.
14636 * python/py-record-btrace.h: Rename include guard.
14637 * python/py-instruction.h: Rename include guard.
14638 * python/py-events.h: Rename include guard.
14639 * python/py-event.h: Rename include guard.
14640 * procfs.h: Add include guard.
14641 * proc-utils.h: Add include guard.
14642 * p-lang.h: Add include guard.
14643 * or1k-tdep.h: Rename include guard.
14644 * observable.h: Rename include guard.
14645 * nto-tdep.h: Rename include guard.
14646 * nat/x86-linux.h: Rename include guard.
14647 * nat/x86-linux-dregs.h: Rename include guard.
14648 * nat/x86-gcc-cpuid.h: Add include guard.
14649 * nat/x86-dregs.h: Rename include guard.
14650 * nat/x86-cpuid.h: Rename include guard.
14651 * nat/ppc-linux.h: Rename include guard.
14652 * nat/mips-linux-watch.h: Rename include guard.
14653 * nat/linux-waitpid.h: Rename include guard.
14654 * nat/linux-ptrace.h: Rename include guard.
14655 * nat/linux-procfs.h: Rename include guard.
14656 * nat/linux-osdata.h: Rename include guard.
14657 * nat/linux-nat.h: Rename include guard.
14658 * nat/linux-namespaces.h: Rename include guard.
14659 * nat/linux-btrace.h: Rename include guard.
14660 * nat/glibc_thread_db.h: Rename include guard.
14661 * nat/gdb_thread_db.h: Rename include guard.
14662 * nat/gdb_ptrace.h: Rename include guard.
14663 * nat/fork-inferior.h: Rename include guard.
14664 * nat/amd64-linux-siginfo.h: Rename include guard.
14665 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14666 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14667 * nat/aarch64-linux.h: Rename include guard.
14668 * nat/aarch64-linux-hw-point.h: Rename include guard.
14669 * mn10300-tdep.h: Add include guard.
14670 * mips-linux-tdep.h: Add include guard.
14671 * mi/mi-parse.h: Rename include guard.
14672 * mi/mi-out.h: Rename include guard.
14673 * mi/mi-main.h: Rename include guard.
14674 * mi/mi-interp.h: Rename include guard.
14675 * mi/mi-getopt.h: Rename include guard.
14676 * mi/mi-console.h: Rename include guard.
14677 * mi/mi-common.h: Rename include guard.
14678 * mi/mi-cmds.h: Rename include guard.
14679 * mi/mi-cmd-break.h: Rename include guard.
14680 * m2-lang.h: Add include guard.
14681 * location.h: Rename include guard.
14682 * linux-record.h: Rename include guard.
14683 * linux-nat.h: Add include guard.
14684 * linux-fork.h: Add include guard.
14685 * i386-darwin-tdep.h: Rename include guard.
14686 * hppa-linux-offsets.h: Add include guard.
14687 * guile/guile.h: Rename include guard.
14688 * guile/guile-internal.h: Rename include guard.
14689 * gnu-nat.h: Rename include guard.
14690 * gdb-stabs.h: Rename include guard.
14691 * frv-tdep.h: Add include guard.
14692 * f-lang.h: Add include guard.
14693 * event-loop.h: Add include guard.
14694 * darwin-nat.h: Rename include guard.
14695 * cp-abi.h: Rename include guard.
14696 * config/sparc/nm-sol2.h: Rename include guard.
14697 * config/nm-nto.h: Rename include guard.
14698 * config/nm-linux.h: Add include guard.
14699 * config/i386/nm-i386gnu.h: Rename include guard.
14700 * config/djgpp/nl_types.h: Rename include guard.
14701 * config/djgpp/langinfo.h: Rename include guard.
14702 * compile/gcc-cp-plugin.h: Add include guard.
14703 * compile/gcc-c-plugin.h: Add include guard.
14704 * compile/compile.h: Rename include guard.
14705 * compile/compile-object-run.h: Rename include guard.
14706 * compile/compile-object-load.h: Rename include guard.
14707 * compile/compile-internal.h: Rename include guard.
14708 * compile/compile-cplus.h: Rename include guard.
14709 * compile/compile-c.h: Rename include guard.
14710 * common/xml-utils.h: Rename include guard.
14711 * common/x86-xstate.h: Rename include guard.
14712 * common/version.h: Rename include guard.
14713 * common/vec.h: Rename include guard.
14714 * common/tdesc.h: Rename include guard.
14715 * common/selftest.h: Rename include guard.
14716 * common/scoped_restore.h: Rename include guard.
14717 * common/scoped_mmap.h: Rename include guard.
14718 * common/scoped_fd.h: Rename include guard.
14719 * common/safe-iterator.h: Rename include guard.
14720 * common/run-time-clock.h: Rename include guard.
14721 * common/refcounted-object.h: Rename include guard.
14722 * common/queue.h: Rename include guard.
14723 * common/ptid.h: Rename include guard.
14724 * common/print-utils.h: Rename include guard.
14725 * common/preprocessor.h: Rename include guard.
14726 * common/pathstuff.h: Rename include guard.
14727 * common/observable.h: Rename include guard.
14728 * common/netstuff.h: Rename include guard.
14729 * common/job-control.h: Rename include guard.
14730 * common/host-defs.h: Rename include guard.
14731 * common/gdb_wait.h: Rename include guard.
14732 * common/gdb_vecs.h: Rename include guard.
14733 * common/gdb_unlinker.h: Rename include guard.
14734 * common/gdb_unique_ptr.h: Rename include guard.
14735 * common/gdb_tilde_expand.h: Rename include guard.
14736 * common/gdb_sys_time.h: Rename include guard.
14737 * common/gdb_string_view.h: Rename include guard.
14738 * common/gdb_splay_tree.h: Rename include guard.
14739 * common/gdb_setjmp.h: Rename include guard.
14740 * common/gdb_ref_ptr.h: Rename include guard.
14741 * common/gdb_optional.h: Rename include guard.
14742 * common/gdb_locale.h: Rename include guard.
14743 * common/gdb_assert.h: Rename include guard.
14744 * common/filtered-iterator.h: Rename include guard.
14745 * common/filestuff.h: Rename include guard.
14746 * common/fileio.h: Rename include guard.
14747 * common/environ.h: Rename include guard.
14748 * common/common-utils.h: Rename include guard.
14749 * common/common-types.h: Rename include guard.
14750 * common/common-regcache.h: Rename include guard.
14751 * common/common-inferior.h: Rename include guard.
14752 * common/common-gdbthread.h: Rename include guard.
14753 * common/common-exceptions.h: Rename include guard.
14754 * common/common-defs.h: Rename include guard.
14755 * common/common-debug.h: Rename include guard.
14756 * common/cleanups.h: Rename include guard.
14757 * common/buffer.h: Rename include guard.
14758 * common/btrace-common.h: Rename include guard.
14759 * common/break-common.h: Rename include guard.
14760 * cli/cli-utils.h: Rename include guard.
14761 * cli/cli-style.h: Rename include guard.
14762 * cli/cli-setshow.h: Rename include guard.
14763 * cli/cli-script.h: Rename include guard.
14764 * cli/cli-interp.h: Rename include guard.
14765 * cli/cli-decode.h: Rename include guard.
14766 * cli/cli-cmds.h: Rename include guard.
14767 * charset-list.h: Add include guard.
14768 * buildsym-legacy.h: Rename include guard.
14769 * bfin-tdep.h: Add include guard.
14770 * ax.h: Rename include guard.
14771 * arm-linux-tdep.h: Add include guard.
14772 * arm-fbsd-tdep.h: Add include guard.
14773 * arch/xtensa.h: Rename include guard.
14774 * arch/tic6x.h: Add include guard.
14775 * arch/i386.h: Add include guard.
14776 * arch/arm.h: Rename include guard.
14777 * arch/arm-linux.h: Rename include guard.
14778 * arch/arm-get-next-pcs.h: Rename include guard.
14779 * arch/amd64.h: Add include guard.
14780 * arch/aarch64-insn.h: Rename include guard.
14781 * arch-utils.h: Rename include guard.
14782 * annotate.h: Add include guard.
14783 * amd64-darwin-tdep.h: Rename include guard.
14784 * aarch64-linux-tdep.h: Add include guard.
14785 * aarch64-fbsd-tdep.h: Add include guard.
14786 * aarch32-linux-nat.h: Add include guard.
14787
14788 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14789
14790 * macrotab.c (macro_define_internal): New function that
14791 factorizes macro_define_object_internal and macro_define_function
14792 code.
14793 (macro_define_object_internal): Use macro_define_internal.
14794 (macro_define_function): Likewise.
14795
14796 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14797
14798 * macrocmd.c (extract_identifier): Return
14799 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14800 callers.
14801
14802 2019-02-06 John Baldwin <jhb@FreeBSD.org>
14803
14804 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14805
14806 2019-02-05 Tom Tromey <tom@tromey.com>
14807
14808 * target.c (target_stack::unpush): Move assertion earlier.
14809
14810 2019-01-30 Tom Tromey <tom@tromey.com>
14811
14812 PR python/23615:
14813 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14814 (gdbpy_parse_and_eval): Likewise.
14815 * python/python-internal.h (gdbpy_allow_threads): New class.
14816
14817 2019-01-28 John Baldwin <jhb@FreeBSD.org>
14818
14819 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14820 (aarch64_fbsd_fpregmap): Move earlier.
14821 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14822 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14823 instead of individual calls to trad_frame_set_reg_addr.
14824 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14825 earlier.
14826 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14827 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14828 instead of individual calls to trad_frame_set_reg_addr.
14829
14830 2019-01-28 Alan Hayward <alan.hayward@arm.com>
14831
14832 * CONTRIBUTE: Replace contribution list with wiki link.
14833
14834 2019-01-25 Tom Tromey <tom@tromey.com>
14835
14836 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14837
14838 2019-01-25 Tom Tromey <tom@tromey.com>
14839
14840 * xtensa-linux-nat.c: Fix common/ includes.
14841 * xml-support.h: Fix common/ includes.
14842 * xml-support.c: Fix common/ includes.
14843 * x86-linux-nat.c: Fix common/ includes.
14844 * windows-nat.c: Fix common/ includes.
14845 * varobj.h: Fix common/ includes.
14846 * varobj.c: Fix common/ includes.
14847 * value.c: Fix common/ includes.
14848 * valops.c: Fix common/ includes.
14849 * utils.c: Fix common/ includes.
14850 * unittests/xml-utils-selftests.c: Fix common/ includes.
14851 * unittests/utils-selftests.c: Fix common/ includes.
14852 * unittests/unpack-selftests.c: Fix common/ includes.
14853 * unittests/tracepoint-selftests.c: Fix common/ includes.
14854 * unittests/style-selftests.c: Fix common/ includes.
14855 * unittests/string_view-selftests.c: Fix common/ includes.
14856 * unittests/scoped_restore-selftests.c: Fix common/ includes.
14857 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14858 * unittests/scoped_fd-selftests.c: Fix common/ includes.
14859 * unittests/rsp-low-selftests.c: Fix common/ includes.
14860 * unittests/parse-connection-spec-selftests.c: Fix common/
14861 includes.
14862 * unittests/optional-selftests.c: Fix common/ includes.
14863 * unittests/offset-type-selftests.c: Fix common/ includes.
14864 * unittests/observable-selftests.c: Fix common/ includes.
14865 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14866 * unittests/memrange-selftests.c: Fix common/ includes.
14867 * unittests/memory-map-selftests.c: Fix common/ includes.
14868 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14869 * unittests/function-view-selftests.c: Fix common/ includes.
14870 * unittests/environ-selftests.c: Fix common/ includes.
14871 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14872 * unittests/common-utils-selftests.c: Fix common/ includes.
14873 * unittests/cli-utils-selftests.c: Fix common/ includes.
14874 * unittests/array-view-selftests.c: Fix common/ includes.
14875 * ui-file.c: Fix common/ includes.
14876 * tui/tui-io.c: Fix common/ includes.
14877 * tracepoint.h: Fix common/ includes.
14878 * tracepoint.c: Fix common/ includes.
14879 * tracefile-tfile.c: Fix common/ includes.
14880 * top.h: Fix common/ includes.
14881 * top.c: Fix common/ includes.
14882 * thread.c: Fix common/ includes.
14883 * target/waitstatus.h: Fix common/ includes.
14884 * target/waitstatus.c: Fix common/ includes.
14885 * target.h: Fix common/ includes.
14886 * target.c: Fix common/ includes.
14887 * target-memory.c: Fix common/ includes.
14888 * target-descriptions.c: Fix common/ includes.
14889 * symtab.h: Fix common/ includes.
14890 * symfile.c: Fix common/ includes.
14891 * stap-probe.c: Fix common/ includes.
14892 * spu-linux-nat.c: Fix common/ includes.
14893 * sparc-nat.c: Fix common/ includes.
14894 * source.c: Fix common/ includes.
14895 * solib.c: Fix common/ includes.
14896 * solib-target.c: Fix common/ includes.
14897 * ser-unix.c: Fix common/ includes.
14898 * ser-tcp.c: Fix common/ includes.
14899 * ser-pipe.c: Fix common/ includes.
14900 * ser-base.c: Fix common/ includes.
14901 * selftest-arch.c: Fix common/ includes.
14902 * s12z-tdep.c: Fix common/ includes.
14903 * rust-exp.y: Fix common/ includes.
14904 * rs6000-aix-tdep.c: Fix common/ includes.
14905 * riscv-tdep.c: Fix common/ includes.
14906 * remote.c: Fix common/ includes.
14907 * remote-notif.h: Fix common/ includes.
14908 * remote-fileio.h: Fix common/ includes.
14909 * remote-fileio.c: Fix common/ includes.
14910 * regcache.h: Fix common/ includes.
14911 * regcache.c: Fix common/ includes.
14912 * record-btrace.c: Fix common/ includes.
14913 * python/python.c: Fix common/ includes.
14914 * python/py-type.c: Fix common/ includes.
14915 * python/py-inferior.c: Fix common/ includes.
14916 * progspace.h: Fix common/ includes.
14917 * producer.c: Fix common/ includes.
14918 * procfs.c: Fix common/ includes.
14919 * proc-api.c: Fix common/ includes.
14920 * printcmd.c: Fix common/ includes.
14921 * ppc-linux-nat.c: Fix common/ includes.
14922 * parser-defs.h: Fix common/ includes.
14923 * osdata.c: Fix common/ includes.
14924 * obsd-nat.c: Fix common/ includes.
14925 * nat/x86-linux.c: Fix common/ includes.
14926 * nat/x86-linux-dregs.c: Fix common/ includes.
14927 * nat/x86-dregs.h: Fix common/ includes.
14928 * nat/x86-dregs.c: Fix common/ includes.
14929 * nat/ppc-linux.c: Fix common/ includes.
14930 * nat/mips-linux-watch.h: Fix common/ includes.
14931 * nat/mips-linux-watch.c: Fix common/ includes.
14932 * nat/linux-waitpid.c: Fix common/ includes.
14933 * nat/linux-ptrace.h: Fix common/ includes.
14934 * nat/linux-ptrace.c: Fix common/ includes.
14935 * nat/linux-procfs.c: Fix common/ includes.
14936 * nat/linux-personality.c: Fix common/ includes.
14937 * nat/linux-osdata.c: Fix common/ includes.
14938 * nat/linux-namespaces.c: Fix common/ includes.
14939 * nat/linux-btrace.h: Fix common/ includes.
14940 * nat/linux-btrace.c: Fix common/ includes.
14941 * nat/fork-inferior.c: Fix common/ includes.
14942 * nat/amd64-linux-siginfo.c: Fix common/ includes.
14943 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14944 * nat/aarch64-linux.c: Fix common/ includes.
14945 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14946 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14947 * namespace.h: Fix common/ includes.
14948 * mips-linux-tdep.c: Fix common/ includes.
14949 * minsyms.c: Fix common/ includes.
14950 * mi/mi-parse.h: Fix common/ includes.
14951 * mi/mi-main.c: Fix common/ includes.
14952 * mi/mi-cmd-env.c: Fix common/ includes.
14953 * memrange.h: Fix common/ includes.
14954 * memattr.c: Fix common/ includes.
14955 * maint.h: Fix common/ includes.
14956 * maint.c: Fix common/ includes.
14957 * main.c: Fix common/ includes.
14958 * machoread.c: Fix common/ includes.
14959 * location.c: Fix common/ includes.
14960 * linux-thread-db.c: Fix common/ includes.
14961 * linux-nat.c: Fix common/ includes.
14962 * linux-fork.c: Fix common/ includes.
14963 * inline-frame.c: Fix common/ includes.
14964 * infrun.c: Fix common/ includes.
14965 * inflow.c: Fix common/ includes.
14966 * inferior.h: Fix common/ includes.
14967 * inferior.c: Fix common/ includes.
14968 * infcmd.c: Fix common/ includes.
14969 * inf-ptrace.c: Fix common/ includes.
14970 * inf-child.c: Fix common/ includes.
14971 * ia64-linux-nat.c: Fix common/ includes.
14972 * i387-tdep.c: Fix common/ includes.
14973 * i386-tdep.c: Fix common/ includes.
14974 * i386-linux-tdep.c: Fix common/ includes.
14975 * i386-linux-nat.c: Fix common/ includes.
14976 * i386-go32-tdep.c: Fix common/ includes.
14977 * i386-fbsd-tdep.c: Fix common/ includes.
14978 * i386-fbsd-nat.c: Fix common/ includes.
14979 * guile/scm-type.c: Fix common/ includes.
14980 * guile/guile.c: Fix common/ includes.
14981 * go32-nat.c: Fix common/ includes.
14982 * gnu-nat.c: Fix common/ includes.
14983 * gdbthread.h: Fix common/ includes.
14984 * gdbarch-selftests.c: Fix common/ includes.
14985 * gdb_usleep.c: Fix common/ includes.
14986 * gdb_select.h: Fix common/ includes.
14987 * gdb_bfd.c: Fix common/ includes.
14988 * gcore.c: Fix common/ includes.
14989 * fork-child.c: Fix common/ includes.
14990 * findvar.c: Fix common/ includes.
14991 * fbsd-nat.c: Fix common/ includes.
14992 * event-top.c: Fix common/ includes.
14993 * event-loop.c: Fix common/ includes.
14994 * dwarf2read.c: Fix common/ includes.
14995 * dwarf2loc.c: Fix common/ includes.
14996 * dwarf2-frame.c: Fix common/ includes.
14997 * dwarf-index-cache.c: Fix common/ includes.
14998 * dtrace-probe.c: Fix common/ includes.
14999 * disasm-selftests.c: Fix common/ includes.
15000 * defs.h: Fix common/ includes.
15001 * csky-tdep.c: Fix common/ includes.
15002 * cp-valprint.c: Fix common/ includes.
15003 * cp-support.h: Fix common/ includes.
15004 * cp-support.c: Fix common/ includes.
15005 * corelow.c: Fix common/ includes.
15006 * completer.h: Fix common/ includes.
15007 * completer.c: Fix common/ includes.
15008 * compile/compile.c: Fix common/ includes.
15009 * compile/compile-loc2c.c: Fix common/ includes.
15010 * compile/compile-cplus-types.c: Fix common/ includes.
15011 * compile/compile-cplus-symbols.c: Fix common/ includes.
15012 * command.h: Fix common/ includes.
15013 * cli/cli-dump.c: Fix common/ includes.
15014 * cli/cli-cmds.c: Fix common/ includes.
15015 * charset.c: Fix common/ includes.
15016 * build-id.c: Fix common/ includes.
15017 * btrace.h: Fix common/ includes.
15018 * btrace.c: Fix common/ includes.
15019 * breakpoint.h: Fix common/ includes.
15020 * breakpoint.c: Fix common/ includes.
15021 * ax.h:
15022 (enum agent_op): Fix common/ includes.
15023 * ax-general.c (struct aop_map): Fix common/ includes.
15024 * ax-gdb.c: Fix common/ includes.
15025 * auxv.c: Fix common/ includes.
15026 * auto-load.c: Fix common/ includes.
15027 * arm-tdep.c: Fix common/ includes.
15028 * arch/riscv.c: Fix common/ includes.
15029 * arch/ppc-linux-common.c: Fix common/ includes.
15030 * arch/i386.c: Fix common/ includes.
15031 * arch/arm.c: Fix common/ includes.
15032 * arch/arm-linux.c: Fix common/ includes.
15033 * arch/arm-get-next-pcs.c: Fix common/ includes.
15034 * arch/amd64.c: Fix common/ includes.
15035 * arch/aarch64.c: Fix common/ includes.
15036 * arch/aarch64-insn.c: Fix common/ includes.
15037 * arch-utils.c: Fix common/ includes.
15038 * amd64-windows-tdep.c: Fix common/ includes.
15039 * amd64-tdep.c: Fix common/ includes.
15040 * amd64-sol2-tdep.c: Fix common/ includes.
15041 * amd64-obsd-tdep.c: Fix common/ includes.
15042 * amd64-nbsd-tdep.c: Fix common/ includes.
15043 * amd64-linux-tdep.c: Fix common/ includes.
15044 * amd64-linux-nat.c: Fix common/ includes.
15045 * amd64-fbsd-tdep.c: Fix common/ includes.
15046 * amd64-fbsd-nat.c: Fix common/ includes.
15047 * amd64-dicos-tdep.c: Fix common/ includes.
15048 * amd64-darwin-tdep.c: Fix common/ includes.
15049 * agent.c: Fix common/ includes.
15050 * ada-lang.h: Fix common/ includes.
15051 * ada-lang.c: Fix common/ includes.
15052 * aarch64-tdep.c: Fix common/ includes.
15053
15054 2019-01-25 Tom Tromey <tom@tromey.com>
15055
15056 * common/create-version.sh: Use common/version.h.
15057
15058 2019-01-24 Pedro Alves <palves@redhat.com>
15059
15060 * infrun.c (signal_stop, signal_print, signal_program)
15061 (signal_catch, signal_pass): Now arrays instead of pointers.
15062 (update_signals_program_target, do_target_resume)
15063 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15064 * linux-nat.c (linux_nat_target::pass_signals)
15065 (linux_nat_target::create_inferior, linux_nat_target::attach):
15066 Adjust.
15067 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15068 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15069 * procfs.c (procfs_target::pass_signals): Adjust.
15070 * record-full.c (record_full_target::resume): Adjust.
15071 * remote.c (remote_target::pass_signals)
15072 (remote_target::program_signals): Adjust.
15073 * target-debug.h (target_debug_print_signals): Now takes a
15074 gdb::array_view as parameter. Adjust.
15075 * target.h (target_ops) <pass_signals, program_signals>: Replace
15076 pointer and length parameters with gdb::array_view.
15077 (target_pass_signals, target_program_signals): Likewise.
15078 * target-delegates.c: Regenerate.
15079
15080 2019-01-24 Pedro Alves <palves@redhat.com>
15081
15082 * common/forward-scope-exit.h
15083 (forward_scope_exit::forward_scope_exit): Pass arguments to
15084 m_bind_function directly, instead of creating a std::bind and
15085 copying that.
15086
15087 2019-01-24 Alan Hayward <alan.hayward@arm.com>
15088
15089 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15090 for static members.
15091 (pass_in_v_vfp_candidate): Likewise.
15092
15093 2019-01-23 Tom Tromey <tom@tromey.com>
15094 Pedro Alves <palves@redhat.com>
15095
15096 * regcache.c (class regcache_invalidator): Remove.
15097 (regcache::raw_write): Use make_scope_exit.
15098
15099 2019-01-23 Tom Tromey <tom@tromey.com>
15100
15101 * ui-out.h (class ui_out_emit_type): Update comment.
15102
15103 2019-01-23 Tom Tromey <tom@tromey.com>
15104
15105 * infrun.c (fetch_inferior_event): Update comment.
15106
15107 2019-01-23 Tom Tromey <tom@tromey.com>
15108 Pedro Alves <palves@redhat.com>
15109
15110 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15111 parameter.
15112 (fetch_inferior_event): Use SCOPE_EXIT.
15113
15114
15115 2019-01-23 Tom Tromey <tom@tromey.com>
15116 Pedro Alves <palves@redhat.com>
15117
15118 * infrun.c (disable_thread_events): Delete.
15119 (stop_all_threads): Use SCOPE_EXIT.
15120
15121 2019-01-23 Tom Tromey <tom@tromey.com>
15122 Pedro Alves <palves@redhat.com>
15123
15124 * symfile.c: Include forward-scope-exit.h.
15125 (clear_symtab_users_cleanup): Replace forward declaration with
15126 a FORWARD_SCOPE_EXIT.
15127 (syms_from_objfile_1): Use the forward_scope_exit and
15128 gdb::optional instead of cleanup_function.
15129 (reread_symbols): Use the forward_scope_exit instead of
15130 cleanup_function.
15131 (clear_symtab_users_cleanup): Remove function.
15132
15133 2019-01-23 Tom Tromey <tom@tromey.com>
15134 Pedro Alves <palves@redhat.com>
15135
15136 * linux-nat.c: Include scope-exit.h.
15137 (cleanup_target_stop): Remove.
15138 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15139 SCOPE_EXIT.
15140
15141 2019-01-23 Tom Tromey <tom@tromey.com>
15142 Pedro Alves <palves@redhat.com>
15143
15144 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15145 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15146
15147 2019-01-23 Tom Tromey <tom@tromey.com>
15148 Andrew Burgess <andrew.burgess@embecosm.com>
15149 Pedro Alves <palves@redhat.com>
15150
15151 * infrun.c (fetch_inferior_event): Use scope_exit.
15152 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15153 * top.c (execute_command): Use scope_exit.
15154 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15155 * utils.c (do_bpstat_clear_actions_cleanup)
15156 (make_bpstat_clear_actions_cleanup): Remove.
15157
15158 2019-01-23 Tom Tromey <tom@tromey.com>
15159 Pedro Alves <palves@redhat.com>
15160
15161 * infrun.c: Include "common/scope-exit.h"
15162 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15163 (wait_for_inferior): Use SCOPE_EXIT.
15164 (fetch_inferior_event): Use scope_exit.
15165
15166 2019-01-23 Tom Tromey <tom@tromey.com>
15167 Pedro Alves <palves@redhat.com>
15168
15169 * breakpoint.c (create_breakpoint): Remove cleanup.
15170
15171 2019-01-23 Tom Tromey <tom@tromey.com>
15172 Andrew Burgess <andrew.burgess@embecosm.com>
15173 Pedro Alves <palves@redhat.com>
15174
15175 2019-01-23 Pedro Alves <palves@redhat.com>
15176
15177 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15178
15179 2019-01-23 Pedro Alves <palves@redhat.com>
15180 Andrew Burgess <andrew.burgess@embecosm.com>
15181
15182 * gdbthread.h: Include "common/forward-scope-exit.h".
15183 (scoped_finish_thread_state): Redefine custom class in terms of
15184 forward_scope_exit.
15185
15186 2019-01-23 Pedro Alves <palves@redhat.com>
15187 Andrew Burgess <andrew.burgess@embecosm.com>
15188
15189 * common/forward-scope-exit.h: New file.
15190
15191 2019-01-23 Pedro Alves <palves@redhat.com>
15192 Andrew Burgess <andrew.burgess@embecosm.com>
15193 Tom Tromey <tom@tromey.com>
15194
15195 * common/scope-exit.h: New file.
15196
15197 2019-01-23 Pedro Alves <palves@redhat.com>
15198
15199 * common/preprocessor.h (ESC): Rename to ...
15200 (ESC_PARENS): ... this.
15201 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15202 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15203
15204 2019-01-23 Tom Tromey <tom@tromey.com>
15205
15206 * language.h (class scoped_switch_to_sym_language_if_auto):
15207 Initialize m_lang in both cases.
15208
15209 2019-01-23 Alan Hayward <alan.hayward@arm.com>
15210
15211 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15212 with XCNEW.
15213
15214 2019-01-22 Tom Tromey <tom@tromey.com>
15215
15216 * corelow.c: Do not include sys/file.h.
15217
15218 2019-01-22 Tom Tromey <tom@tromey.com>
15219
15220 * tui/tui-wingeneral.h: Include gdb_curses.h.
15221
15222 2019-01-22 Tom Tromey <tom@tromey.com>
15223
15224 * source-cache.h (class source_cache) <get_source_lines,
15225 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15226
15227 2019-01-22 Tom Tromey <tom@tromey.com>
15228
15229 * remote-fileio.h (struct remote_target): Declare.
15230
15231 2019-01-22 Tom Tromey <tom@tromey.com>
15232
15233 * python/py-arch.c: Do not include py-ref.h.
15234 * python/py-bpevent.c: Do not include py-ref.h.
15235 * python/py-cmd.c: Do not include py-ref.h.
15236 * python/py-continueevent.c: Do not include py-ref.h.
15237 * python/py-event.h: Do not include py-ref.h.
15238 * python/py-evtregistry.c: Do not include py-ref.h.
15239 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15240 * python/py-frame.c: Do not include py-ref.h.
15241 * python/py-framefilter.c: Do not include py-ref.h.
15242 * python/py-function.c: Do not include py-ref.h.
15243 * python/py-infevents.c: Do not include py-ref.h.
15244 * python/py-linetable.c: Do not include py-ref.h.
15245 * python/py-objfile.c: Do not include py-ref.h.
15246 * python/py-param.c: Do not include py-ref.h.
15247 * python/py-prettyprint.c: Do not include py-ref.h.
15248 * python/py-progspace.c: Do not include py-ref.h.
15249 * python/py-symbol.c: Do not include py-ref.h.
15250 * python/py-symtab.c: Do not include py-ref.h.
15251 * python/py-type.c: Do not include py-ref.h.
15252 * python/py-unwind.c: Do not include py-ref.h.
15253 * python/py-utils.c: Do not include py-ref.h.
15254 * python/py-value.c: Do not include py-ref.h.
15255 * python/py-varobj.c: Do not include py-ref.h.
15256 * python/py-xmethods.c: Do not include py-ref.h.
15257 * python/python.c: Do not include py-ref.h.
15258 * varobj.c: Do not include py-ref.h.
15259
15260 2019-01-22 Tom Tromey <tom@tromey.com>
15261
15262 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15263 keyword for bcache.
15264
15265 2019-01-22 Tom Tromey <tom@tromey.com>
15266
15267 * compile/compile-cplus-types.c: Remove a comment by #include.
15268
15269 2019-01-22 Tom Tromey <tom@tromey.com>
15270
15271 * compile/gcc-c-plugin.h: Include compile-internal.h.
15272
15273 2019-01-22 Tom Tromey <tom@tromey.com>
15274
15275 * stabsread.c (EXTERN): Do not define.
15276 (symnum, next_symbol_text_func, processing_gcc_compilation)
15277 (within_function, global_sym_chain, global_stabs)
15278 (previous_stab_code, this_object_header_files)
15279 (n_this_object_header_files)
15280 (n_allocated_this_object_header_files): Define.
15281 * stabsread.h (EXTERN): Never define. Use "extern".
15282
15283 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15284
15285 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15286 history_value.
15287
15288 2019-01-21 Tom Tromey <tom@tromey.com>
15289
15290 * ui-out.c: Fix includes.
15291 * tui/tui-source.c: Fix includes.
15292 * target.c: Fix includes.
15293 * remote.c: Fix includes.
15294 * regcache.c: Fix includes.
15295 * python/py-block.c: Fix includes.
15296 * printcmd.c: Fix includes.
15297 * or1k-tdep.c: Fix includes.
15298 * mi/mi-main.c: Fix includes.
15299 * m32r-tdep.c: Fix includes.
15300 * csky-tdep.c: Fix includes.
15301 * compile/compile-cplus-types.c: Fix includes.
15302 * cli/cli-interp.c: Fix includes.
15303
15304 2019-01-21 Alan Hayward <alan.hayward@arm.com>
15305
15306 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15307 for padding.
15308
15309 2019-01-16 Tom Tromey <tom@tromey.com>
15310
15311 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15312 earlier.
15313 (struct objfile) <msymbols_range>: Move from top level.
15314 <msymbols>: New method.
15315 (class objfile_msymbols): Remove.
15316 * symtab.c (default_collect_symbol_completion_matches_break_on):
15317 Update.
15318 * symmisc.c (dump_msymbols): Update.
15319 * stabsread.c (scan_file_globals): Update.
15320 * objc-lang.c (info_selectors_command, info_classes_command)
15321 (find_methods): Update.
15322 * minsyms.c (find_solib_trampoline_target): Update.
15323 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15324 * coffread.c (coff_symfile_read): Update.
15325 * ada-lang.c (ada_lookup_simple_minsym)
15326 (ada_collect_symbol_completion_matches): Update.
15327
15328 2019-01-16 Tom Tromey <tom@tromey.com>
15329
15330 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15331 type. Remove no-argument constructor.
15332 <iterator::operator++>: Simplify.
15333 <begin>: Update.
15334 <end>: Use minimal_symbol_count.
15335
15336 2019-01-16 Tom Tromey <tom@tromey.com>
15337
15338 * objfiles.h (struct objfile) <psymtabs>: New method.
15339 (class objfile_psymtabs): Remove.
15340 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15341 typedef.
15342 <range>: New method.
15343 (require_partial_symbols): Change return type.
15344 * psymtab.c (require_partial_symbols)
15345 (psym_expand_symtabs_matching): Update.
15346 * mdebugread.c (parse_partial_symbols): Update.
15347 * dbxread.c (dbx_end_psymtab): Update.
15348
15349 2019-01-15 Tom Tromey <tom@tromey.com>
15350
15351 * symtab.c (lookup_objfile_from_block)
15352 (lookup_symbol_in_objfile_symtabs)
15353 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15354 (find_line_symtab, info_sources_command)
15355 (default_collect_symbol_completion_matches_break_on)
15356 (make_source_files_completion_list): Update.
15357 * symmisc.c (print_objfile_statistics, dump_objfile)
15358 (maintenance_print_symbols, maintenance_info_symtabs)
15359 (maintenance_check_symtabs, maintenance_info_line_tables):
15360 Update.
15361 * source.c (select_source_symtab)
15362 (forget_cached_source_info_for_objfile): Update.
15363 * objfiles.h (class objfile_compunits): Remove.
15364 (struct objfile) <compunits_range>: New typedef.
15365 (compunits): New method.
15366 * objfiles.c (objfile_relocate1): Update.
15367 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15368 * maint.c (count_symtabs_and_blocks): Update.
15369 * linespec.c (iterate_over_all_matching_symtabs): Update.
15370 * cp-support.c (add_symbol_overload_list_qualified): Update.
15371 * coffread.c (coff_symtab_read): Update.
15372 * ada-lang.c (add_nonlocal_symbols)
15373 (ada_collect_symbol_completion_matches)
15374 (ada_add_global_exceptions): Update.
15375
15376 2019-01-15 Tom Tromey <tom@tromey.com>
15377
15378 * progspace.h (program_space) <objfiles_safe_range>: New
15379 typedef.
15380 <objfiles_safe>: New method.
15381 * objfiles.h (class all_objfiles_safe): Remove.
15382 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15383 * jit.c (jit_inferior_exit_hook): Update.
15384
15385 2019-01-17 Tom Tromey <tom@tromey.com>
15386
15387 * progspace.h (program_space) <objfiles_range>: New typedef.
15388 <objfiles>: New method.
15389 <objfiles_head>: Rename from objfiles.
15390 (object_files): Update.
15391 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15392 * guile/scm-pretty-print.c
15393 (ppscm_find_pretty_printer_from_objfiles): Update.
15394 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15395 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15396 Update.
15397 * python/py-progspace.c (pspy_get_objfiles): Update.
15398 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15399 Update.
15400 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15401 (objfpy_lookup_objfile_by_build_id): Update.
15402 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15403 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15404 Update.
15405 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15406 (expand_symtab_containing_pc, lookup_objfile_from_block)
15407 (lookup_static_symbol, basic_lookup_transparent_type)
15408 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15409 (find_line_symtab, info_sources_command)
15410 (default_collect_symbol_completion_matches_break_on)
15411 (make_source_files_completion_list, find_main_name): Update.
15412 * symmisc.c (print_symbol_bcache_statistics)
15413 (print_objfile_statistics, maintenance_print_symbols)
15414 (maintenance_print_msymbols, maintenance_print_objfiles)
15415 (maintenance_info_symtabs, maintenance_check_symtabs)
15416 (maintenance_expand_symtabs, maintenance_info_line_tables):
15417 Update.
15418 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15419 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15420 (map_overlay_command, unmap_overlay_command)
15421 (simple_overlay_update, expand_symtabs_matching)
15422 (map_symbol_filenames): Update.
15423 * symfile-debug.c (set_debug_symfile): Update.
15424 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15425 Update.
15426 * source.c (select_source_symtab, forget_cached_source_info):
15427 Update.
15428 * solib.c (solib_read_symbols): Update.
15429 * solib-spu.c (append_ocl_sos): Update.
15430 * psymtab.c (maintenance_print_psymbols)
15431 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15432 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15433 * printcmd.c (info_symbol_command): Update.
15434 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15435 Update.
15436 * objfiles.h (class all_objfiles): Remove.
15437 * objfiles.c (have_partial_symbols, have_full_symbols)
15438 (have_minimal_symbols, qsort_cmp, update_section_map)
15439 (shared_objfile_contains_address_p)
15440 (default_iterate_over_objfiles_in_search_order): Update.
15441 * objc-lang.c (info_selectors_command, info_classes_command)
15442 (find_methods): Update.
15443 * minsyms.c (find_solib_trampoline_target): Update.
15444 * maint.c (maintenance_info_sections)
15445 (maintenance_translate_address, count_symtabs_and_blocks):
15446 Update.
15447 * main.c (captured_main_1): Update.
15448 * linux-thread-db.c (try_thread_db_load_from_pdir)
15449 (has_libpthread): Update.
15450 * linespec.c (iterate_over_all_matching_symtabs)
15451 (search_minsyms_for_name): Update.
15452 * jit.c (jit_find_objf_with_entry_addr): Update.
15453 * hppa-tdep.c (find_unwind_entry)
15454 (hppa_lookup_stub_minimal_symbol): Update.
15455 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15456 Update.
15457 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15458 (elf_gnu_ifunc_resolve_by_got): Update.
15459 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15460 * dwarf-index-write.c (save_gdb_index_command): Update.
15461 * cp-support.c (add_symbol_overload_list_qualified): Update.
15462 * breakpoint.c (create_overlay_event_breakpoint)
15463 (create_longjmp_master_breakpoint)
15464 (create_std_terminate_master_breakpoint)
15465 (create_exception_master_breakpoint): Update.
15466 * blockframe.c (find_pc_partial_function): Update.
15467 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15468 (ada_collect_symbol_completion_matches)
15469 (ada_add_global_exceptions): Update.
15470
15471 2019-01-17 Tom Tromey <tom@tromey.com>
15472
15473 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15474 declare VEC.
15475 (solib_target_parse_libraries): Change return type.
15476 (library_list_start_segment, library_list_start_section)
15477 (library_list_end_library, library_list_start_library); Update.
15478 (solib_target_free_library_list): Remove.
15479 (solib_target_parse_libraries): Remove cleanup. Change return
15480 type.
15481 (solib_target_current_sos): Update.
15482
15483 2019-01-17 Tom Tromey <tromey@bapiya>
15484
15485 * valprint.c: Replace "the the" with "the".
15486 * symtab.c: Replace "the the" with "the".
15487 * solib.c: Replace "the the" with "the".
15488 * solib-dsbt.c: Replace "the the" with "the".
15489 * linespec.c: Replace "the the" with "the".
15490 * dwarf2loc.h: Replace "the the" with "the".
15491 * amd64-windows-tdep.c: Replace "the the" with "the".
15492 * aarch64-tdep.c: Replace "the the" with "the".
15493
15494 2019-01-16 Keith Seitz <keiths@redhat.com>
15495
15496 PR gdb/23773
15497 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15498 <builder>: Rename to ..
15499 <m_builder>: ... this and make private.
15500 (dwarf2_cu::get_builder): New method. Change all users of
15501 `builder' to use this method.
15502 (dwarf2_start_symtab): Move to ...
15503 (dwarf2_cu::start_symtab): ... here. Update all callers
15504 (setup_type_unit_groups): Move to ...
15505 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15506 callers.
15507 (dwarf2_cu::reset_builder): New method.
15508 (process_full_compunit, process_full_type_unit): Use
15509 dwarf2_cu::reset_builder.
15510 (follow_die_offset): Record the ancestor CU if it is different
15511 from the followed DIE's CU.
15512 (follow_die_sig_1): Likewise.
15513
15514 2019-01-15 Tom Tromey <tom@tromey.com>
15515
15516 * remote.c (class remote_state) <buf>: Now a char_vector.
15517 <buf_size>: Remove.
15518 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15519 parameter.
15520 (remote_target::getpkt_or_notif_sane_1)
15521 (remote_target::getpkt_sane)
15522 (remote_target::getpkt_or_notif_sane): Likewise.
15523 (class remote_target) <putpkt>: New overload.
15524 (remote_target::read_frame): Change type of "buf_p". Remove
15525 sizeof_p parameter.
15526 (packet_ok): New overload.
15527 (packet_check_result): New overload.
15528 Update all uses.
15529
15530 2019-01-14 Tom Tromey <tom@tromey.com>
15531
15532 * remote-notif.c (handle_notification, remote_notif_ack)
15533 (remote_notif_parse): Make "buf" const.
15534 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15535 const.
15536 (remote_notif_parse, remote_notif_ack, handle_notification):
15537 Likewise.
15538 * remote.c (remote_notif_stop_parse): Make "buf" const.
15539 (remote_target::remote_parse_stop_reply): Make "buf" const.
15540 (remote_notif_stop_ack): Make "buf" const.
15541
15542 2019-01-14 Tom Tromey <tom@tromey.com>
15543
15544 * remote.c (remote_console_output): Make parameter const.
15545
15546 2019-01-14 Tom Tromey <tom@tromey.com>
15547
15548 * target-debug.h (target_debug_print_signals): Constify.
15549 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15550 * procfs.c (procfs_target::pass_signals): Update.
15551 * linux-nat.c (linux_nat_target::pass_signals): Update.
15552 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15553 * target-delegates.c: Rebuild.
15554 * remote.c (remote_target::program_signals): Update.
15555 (remote_target::pass_signals): Update.
15556 * target.c (target_pass_signals): Constify argument.
15557 (target_program_signals): Likewise.
15558 * target.h (struct target_ops) <pass_signals, program_signals>:
15559 Constify argument.
15560 (target_pass_signals, target_program_signals): Constify argument.
15561
15562 2019-01-14 Tom Tromey <tom@tromey.com>
15563
15564 PR tui/28819:
15565 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15566
15567 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15568
15569 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15570 field.
15571 * rs6000-tdep.c: Include reggroups.h.
15572 (IS_V_ALIAS_PSEUDOREG): Define.
15573 (rs6000_register_name): Return names for the "vX" aliases.
15574 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15575 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15576 aliases. Call default_register_reggroup_p for all other
15577 pseudo-registers.
15578 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15579 New functions.
15580 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15581 Handle "vX" aliases.
15582 (v_alias_pseudo_register_collect): New function.
15583 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15584 (rs6000_gdbarch_init): Initialize "vX" aliases as
15585 pseudo-registers. Restore registration of
15586 rs6000_pseudo_register_reggroup_p with
15587 set_tdesc_pseudo_register_reggroup_p.
15588
15589 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15590
15591 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15592 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15593 set_gdbarch_num_pseudo_regs.
15594
15595 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15596
15597 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15598 Remove arg prefixname, add do_set and do_show.
15599 Add member functions set_list and show_list.
15600 * cli/cli-style.c (class cli_style_option): Update accordingly.
15601 (style_set_list): Move to file scope.
15602 (style_show_list): Likewise.
15603 (set_style): Call help_list.
15604 (show_style): Call cmd_show_list.
15605 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15606 Update to use the new macro.
15607
15608 2019-10-12 Joel Brobecker <brobecker@adacore.com>
15609
15610 * ada-lang.c (_initialize_ada_language): Expand the help text
15611 for the "catch exception" command.
15612
15613 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15614
15615 * symtab.c (matching_obj_sections): Initialize obj,
15616 declare it closer to its usage.
15617
15618 2019-01-10 Tom Tromey <tom@tromey.com>
15619
15620 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15621 (basic_inf_threads_range): Remove.
15622 (inf_threads_range, inf_non_exited_threads_range)
15623 (safe_inf_threads_range): Use next_adapter.
15624
15625 2019-01-10 Keith Seitz <keiths@redhat.com>
15626
15627 PR gdb/23712
15628 PR symtab/23010
15629 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15630 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15631
15632 2019-01-10 Keith Seitz <keiths@redhat.com>
15633
15634 PR gdb/23712
15635 PR symtab/23010
15636 * dictionary.c (pending_to_vector): Remove.
15637 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15638 Remove _1 suffix, replacing functions of the same name. Update
15639 all callers.
15640 (dict_create_hashed, dict_create_hashed_expandable)
15641 (dict_create_linear, dict_create_linear_expandable, dict_free)
15642 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15643 Make functions static.
15644
15645 2019-01-10 Keith Seitz <keiths@redhat.com>
15646
15647 PR gdb/23712
15648 PR symtab/23010
15649 * dictionary.h (struct dictionary): Replace declaration with
15650 multidictionary.
15651 (dict_create_hashed, dict_create_hashed_expandable)
15652 (dict_create_linear, dict_create_linear_expandable)
15653 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15654 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15655 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15656 taking multidictionary argument.
15657 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15658 * block.h (struct block) <dict>: Change to multidictionary
15659 and rename `multidict'.
15660 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15661 symmisc.c: Update all dictionary references to multidictionary.
15662
15663 2019-01-10 Keith Seitz <keiths@redhat.com>
15664
15665 PR gdb/23712
15666 PR symtab/23010
15667 * dictionary.c: Include unordered_map.
15668 (pending_to_vector): New function.
15669 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15670 Rewrite the non-"_1" functions to take vector instead
15671 of linked list.
15672 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15673 "new" _1 versions of the same name.
15674 (multidictionary): Define.
15675 (std::hash<enum language): New definition.
15676 (collate_pending_symbols_by_language, mdict_create_hashed)
15677 (mdict_create_hashed_expandable, mdict_create_linear)
15678 (mdict_create_linear_expandable, mdict_free)
15679 (find_language_dictionary, create_new_language_dictionary)
15680 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15681 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15682 (mdict_size, mdict_empty): New functions.
15683 * dictionary.h (mdict_iterator): Define.
15684
15685 2019-01-10 Pedro Alves <palves@redhat.com>
15686
15687 * breakpoint.c (read_uploaded_action)
15688 (create_tracepoint_from_upload): Adjust to use
15689 gdb::unique_xmalloc_ptr.
15690 * ctf.c (ctf_write_uploaded_tp):
15691 (SET_ARRAY_FIELD): Use emplace_back.
15692 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15693 * tracefile-tfile.c (tfile_write_uploaded_tp):
15694 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15695 gdb::unique_xmalloc_ptr.
15696 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15697 at_string, cond_string, cmd_strings>: Replace char pointers
15698 with gdb::unique_xmalloc_ptr.
15699
15700 2019-01-10 Pedro Alves <palves@redhat.com>
15701
15702 * solib-target.c (library_list_start_library): Don't xstrdup name.
15703
15704 2019-01-10 Pedro Alves <palves@redhat.com>
15705
15706 * mdebugread.c (parse_partial_symbols): Use
15707 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15708
15709 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15710
15711 * linux-fork.c (scoped_switch_fork_info)
15712 <~scoped_switch_fork_info>: Fix incorrect variable name.
15713
15714 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15715
15716 * linux-fork.c (scoped_switch_fork_info)
15717 <scoped_switch_fork_info>: Make explicit.
15718 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15719
15720 2019-01-10 Tom Tromey <tom@tromey.com>
15721
15722 * objfiles.h (objfile::reset_psymtabs): Update.
15723 * objfiles.c (objfile::objfile): Update.
15724 * psymtab.h (psymtab_storage::obstack): Update.
15725 (psymtab_storage::m_obstack): Use gdb::optional.
15726 (class psymtab_storage): Update comment. Remove objfile
15727 parameter.
15728 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15729
15730 2019-01-10 Tom Tromey <tom@tromey.com>
15731
15732 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15733 <free_psymtabs>: Now private.
15734 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15735 (allocate_psymtab): Use new method.
15736
15737 2019-01-10 Tom Tromey <tom@tromey.com>
15738
15739 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15740 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15741 * mdebugread.c (parse_partial_symbols): Use
15742 allocate_dependencies.
15743 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15744 allocate_dependencies.
15745 (process_psymtab_comp_unit_reader)
15746 (build_type_psymtab_dependencies): Likewise.
15747 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15748
15749 2019-01-10 Tom Tromey <tom@tromey.com>
15750
15751 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15752 PSYMBOL_SET_LANGUAGE.
15753 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15754
15755 2019-01-10 Tom Tromey <tom@tromey.com>
15756
15757 * psymtab.h (psymtab_storage::obstack): New method.
15758 <m_obstack>: Rename from obstack; now private.
15759 * psymtab.c (psymtab_storage): Update.
15760 * dwarf2read.c (create_addrmap_from_index)
15761 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15762 Update.
15763
15764 2019-01-10 Tom Tromey <tom@tromey.com>
15765
15766 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15767 * objfiles.h (objfile::reset_psymtabs): New method.
15768
15769 2019-01-10 Tom Tromey <tom@tromey.com>
15770
15771 * symmisc.c (print_symbol_bcache_statistics): Update.
15772 (print_objfile_statistics): Update.
15773 * symfile.c (reread_symbols): Update.
15774 * psymtab.h (class psymtab_storage): New.
15775 * psymtab.c (psymtab_storage): New constructor.
15776 (~psymtab_storage): New destructor.
15777 (require_partial_symbols): Update.
15778 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15779 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15780 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15781 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15782 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15783 (start_psymtab_common, end_psymtab_common)
15784 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15785 (allocate_psymtab): Update.
15786 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15787 Update.
15788 (dump_psymtab_addrmap, maintenance_print_psymbols)
15789 (maintenance_check_psymtabs): Update.
15790 (class objfile_psymtabs): Move to objfiles.h.
15791 * psympriv.h (discard_psymtab): Now inline.
15792 (psymtab_discarder::psymtab_discarder): Update.
15793 (psymtab_discarder::~psymtab_discarder): Update.
15794 (ALL_OBJFILE_PSYMTABS): Rewrite.
15795 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15796 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15797 Remove fields.
15798 <partial_symtabs>: New field.
15799 (class objfile_psymtabs): Move from psymtab.h. Update.
15800 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15801 psymbol_cache.
15802 (objfile::~objfile): Don't destroy psymbol_cache.
15803 * mdebugread.c (parse_partial_symbols): Update.
15804 * dwarf2read.c (create_addrmap_from_index)
15805 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15806 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15807 (add_partial_subprogram, dwarf2_ranges_read): Update.
15808 * dwarf-index-write.c (write_address_map)
15809 (write_one_signatured_type, recursively_write_psymbols)
15810 (class debug_names, class debug_names, write_psymtabs_to_index):
15811 Update.
15812
15813 2019-01-10 Tom Tromey <tom@tromey.com>
15814
15815 * symtab.h (SYMBOL_SET_NAMES): Update.
15816 (symbol_set_names): Update.
15817 (MSYMBOL_SET_NAMES): Update.
15818 * symtab.c (symbol_set_names): Change argument to be an
15819 objfile_per_bfd_storage.
15820 * psymtab.c (add_psymbol_to_bcache): Update.
15821 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15822
15823 2019-01-10 Tom Tromey <tom@tromey.com>
15824
15825 * symtab.c (create_demangled_names_hash): Change argument to be an
15826 objfile_per_bfd_storage.
15827 (symbol_set_names): Update.
15828
15829 2019-01-10 Tom Tromey <tom@tromey.com>
15830
15831 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15832 init_psymbol_list.
15833 * psymtab.c (init_psymbol_list): Do nothing if already called.
15834 * psympriv.h (init_psymbol_list): Add comment.
15835 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15836 init_psymbol_list.
15837 * dbxread.c (dbx_symfile_read): Unconditionally call
15838 init_psymbol_list.
15839
15840 2019-01-10 Tom Tromey <tom@tromey.com>
15841
15842 * xcoffread.c (scan_xcoff_symtab): Update.
15843 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15844 "where".
15845 * mdebugread.c (parse_partial_symbols)
15846 (handle_psymbol_enumerators): Update.
15847 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15848 * dbxread.c (read_dbx_symtab): Update.
15849 * psympriv.h (psymbol_placement): New enum.
15850 (add_psymbol_to_list): Update.
15851
15852 2019-01-10 Tom Tromey <tom@tromey.com>
15853
15854 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15855 static_psymbols parameters.
15856 (scan_xcoff_symtab): Update.
15857 * psymtab.c (start_psymtab_common): Remove global_psymbols and
15858 static_psymbols parameters.
15859 * psympriv.h (start_psymtab_common): Update.
15860 * mdebugread.c (parse_partial_symbols): Update.
15861 * dwarf2read.c (create_partial_symtab): Update.
15862 * dbxread.c (read_dbx_symtab): Update.
15863 (start_psymtab): Remove global_psymbols and static_psymbols
15864 parameters.
15865
15866 2019-01-10 Tom Tromey <tom@tromey.com>
15867
15868 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15869 * psymtab.c (allocate_psymtab): Add comment.
15870 * psympriv.h (allocate_psymtab): Add comment.
15871 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15872 initializations.
15873 * dbxread.c (dbx_end_psymtab): Remove some initializations.
15874
15875 2019-01-10 Tom Tromey <tom@tromey.com>
15876
15877 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15878 Don't declare.
15879 * mipsread.c: Include mdebugread.h.
15880 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15881 Declare.
15882 * elfread.c: Include mdebugread.h.
15883
15884 2019-01-09 Tom Tromey <tom@tromey.com>
15885
15886 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15887 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15888 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15889 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15890 (psym_lookup_symbol, psym_find_last_source_symtab)
15891 (psym_forget_cached_source_info, psym_print_stats)
15892 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15893 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15894 (psym_map_matching_symbols, psym_expand_symtabs_matching)
15895 (psym_find_compunit_symtab_by_address)
15896 (maintenance_print_psymbols, maintenance_info_psymtabs)
15897 (maintenance_check_psymtabs): Use ranged for.
15898 * psymtab.h (class objfile_psymtabs): New.
15899 (require_partial_symbols): Return objfile_psymtabs.
15900 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15901
15902 2019-01-09 Tom Tromey <tom@tromey.com>
15903
15904 * symfile.c (overlay_invalidate_all, find_pc_overlay)
15905 (find_pc_mapped_section, list_overlays_command)
15906 (map_overlay_command, unmap_overlay_command)
15907 (simple_overlay_update): Use all_objfiles.
15908 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15909 * printcmd.c (info_symbol_command): Use all_objfiles.
15910 * objfiles.h (ALL_OBJSECTIONS): Remove.
15911 * maint.c (maintenance_translate_address): Use all_objfiles.
15912 * gcore.c (gcore_create_callback): Use all_objfiles.
15913 (objfile_find_memory_regions): Likewise.
15914
15915 2019-01-09 Tom Tromey <tom@tromey.com>
15916
15917 * symtab.c (find_line_symtab, info_sources_command)
15918 (make_source_files_completion_list): Use objfile_compunits.
15919 * source.c (select_source_symtab): Use objfile_compunits.
15920 * objfiles.h (struct objfile): Update comment.
15921 (ALL_OBJFILES): Remove.
15922 (ALL_FILETABS): Remove.
15923 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15924 objfile_compunits.
15925
15926 2019-01-09 Tom Tromey <tom@tromey.com>
15927
15928 * symmisc.c (print_objfile_statistics, dump_objfile)
15929 (maintenance_print_symbols): Use compunit_filetabs.
15930 * source.c (forget_cached_source_info_for_objfile): Use
15931 compunit_filetabs.
15932 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15933 (ALL_FILETABS): Use compunit_filetabs.
15934 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15935 * coffread.c (coff_symtab_read): Use compunit_filetabs.
15936
15937 2019-01-09 Tom Tromey <tom@tromey.com>
15938
15939 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15940 (compunit_filetabs): New.
15941 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15942 compunit_filetabs.
15943 (info_sources_command, make_source_files_completion_list): Remove
15944 declaration.
15945 * symmisc.c (print_objfile_statistics, dump_objfile)
15946 (maintenance_print_symbols): Remove declaration.
15947 (maintenance_info_symtabs): Use compunit_filetabs.
15948 (maintenance_info_line_tables): Likewise.
15949 * source.c (select_source_symtab): Change local variable name.
15950 (forget_cached_source_info_for_objfile): Remove declaration.
15951 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15952 * objfiles.c (objfile_relocate1): Remove declaration.
15953 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15954 declaration.
15955 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15956 * coffread.c (coff_symtab_read): Remove declaration.
15957 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15958 compunit_filetabs.
15959
15960 2019-01-09 Tom Tromey <tom@tromey.com>
15961
15962 * symtab.c (lookup_objfile_from_block)
15963 (find_pc_sect_compunit_symtab, search_symbols)
15964 (default_collect_symbol_completion_matches_break_on): Use
15965 objfile_compunits.
15966 * objfiles.h (ALL_COMPUNITS): Remove.
15967 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15968 * cp-support.c (add_symbol_overload_list_qualified): Use
15969 objfile_compunits.
15970 * ada-lang.c (ada_collect_symbol_completion_matches)
15971 (ada_add_global_exceptions): Use objfile_compunits.
15972
15973 2019-01-09 Tom Tromey <tom@tromey.com>
15974
15975 * source.c (select_source_symtab)
15976 (forget_cached_source_info_for_objfile): Remove declaration.
15977 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15978 declaration.
15979 * maint.c (count_symtabs_and_blocks): Remove declaration.
15980 * cp-support.c (add_symbol_overload_list_qualified): Remove
15981 declaration.
15982 * coffread.c (coff_symtab_read): Remove declaration.
15983 * symtab.c (lookup_symbol_in_objfile_symtabs)
15984 (basic_lookup_transparent_type_1): Use objfile_compunits.
15985 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15986 (info_sources_command, search_symbols)
15987 (default_collect_symbol_completion_matches_break_on)
15988 (make_source_files_completion_list): Remove declaration.
15989 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15990 (ada_collect_symbol_completion_matches)
15991 (ada_add_global_exceptions): Remove declaration.
15992 * linespec.c (iterate_over_all_matching_symtabs): Use
15993 objfile_compunits.
15994 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15995 (class objfile_compunits): New.
15996 (ALL_COMPUNITS): Use objfile_compunits.
15997 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15998 (maintenance_check_symtabs, maintenance_info_line_tables): Use
15999 objfile_compunits.
16000 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16001
16002 2019-01-09 Tom Tromey <tom@tromey.com>
16003
16004 * symtab.c (search_symbols)
16005 (default_collect_symbol_completion_matches_break_on): Use
16006 objfile_msymbols.
16007 * ada-lang.c (ada_lookup_simple_minsym)
16008 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16009 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16010 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16011 objfile_msymbols.
16012 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16013 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16014 * objc-lang.c (find_methods): Use objfile_msymbols.
16015 (info_selectors_command, info_classes_command): Likewise.
16016 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16017 * objfiles.h (class objfile_msymbols): New.
16018 (ALL_OBJFILE_MSYMBOLS): Remove.
16019 (ALL_MSYMBOLS): Remove.
16020
16021 2019-01-09 Tom Tromey <tom@tromey.com>
16022
16023 * common/next-iterator.h (next_adapter): Add Iterator template
16024 parameter.
16025 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16026 (class all_objfiles_safe): New.
16027 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16028 * objfiles.c (put_objfile_before): Update comment.
16029 (add_separate_debug_objfile): Likewise.
16030 (free_all_objfiles): Use all_objfiles_safe.
16031 (objfile_purge_solibs): Likewise.
16032
16033 2019-01-09 Tom Tromey <tom@tromey.com>
16034
16035 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16036 (expand_symtab_containing_pc, lookup_static_symbol)
16037 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16038 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16039 all_objfiles.
16040 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16041 * breakpoint.c (create_overlay_event_breakpoint)
16042 (create_longjmp_master_breakpoint)
16043 (create_std_terminate_master_breakpoint)
16044 (create_exception_master_breakpoint): Use all_objfiles.
16045 * linux-thread-db.c (try_thread_db_load_from_pdir)
16046 (has_libpthread): Use all_objfiles.
16047 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16048 * linespec.c (iterate_over_all_matching_symtabs)
16049 (search_minsyms_for_name): Use all_objfiles.
16050 * maint.c (maintenance_info_sections): Use all_objfiles.
16051 * main.c (captured_main_1): Use all_objfiles.
16052 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16053 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16054 * guile/scm-pretty-print.c
16055 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16056 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16057 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16058 (maintenance_print_msymbols): Use all_objfiles.
16059 * source.c (select_source_symtab): Use all_objfiles.
16060 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16061 * symfile.c (remove_symbol_file_command)
16062 (expand_symtabs_matching, map_symbol_filenames): Use
16063 all_objfiles.
16064 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16065 all_objfiles.
16066 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16067 * objc-lang.c (find_methods): Use all_objfiles.
16068 * objfiles.c (have_partial_symbols, have_full_symbols)
16069 (have_minimal_symbols, qsort_cmp)
16070 (default_iterate_over_objfiles_in_search_order): Use
16071 all_objfiles.
16072 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16073 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16074 (maintenance_check_psymtabs): Use all_objfiles.
16075 (ALL_PSYMTABS): Remove.
16076 * compile/compile-object-run.c (do_module_cleanup): Use
16077 all_objfiles.
16078 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16079 * cp-support.c (add_symbol_overload_list_qualified): Use
16080 all_objfiles.
16081 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16082 Use all_objfiles.
16083 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16084 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16085 all_objfiles.
16086 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16087 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16088 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16089 Uses all_objfiles.
16090 * solib.c (solib_read_symbols): Use all_objfiles
16091
16092 2019-01-09 Tom Tromey <tom@tromey.com>
16093
16094 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16095 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16096 all_objfiles.
16097 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16098 * symmisc.c (print_symbol_bcache_statistics)
16099 (print_objfile_statistics, maintenance_print_objfiles)
16100 (maintenance_info_symtabs, maintenance_check_symtabs)
16101 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16102 all_objfiles.
16103 * source.c (forget_cached_source_info): Use all_objfiles.
16104 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16105 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16106 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16107 * objfiles.c (update_section_map): Use all_objfiles.
16108 (shared_objfile_contains_address_p): Likewise.
16109 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16110 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16111
16112 2019-01-09 Tom Tromey <tom@tromey.com>
16113
16114 * common/next-iterator.h: New file.
16115 * objfiles.h (class all_objfiles): New.
16116 (struct objfile_iterator): New.
16117
16118 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16119
16120 * NEWS: Move the description of the changed "frame", "select-frame",
16121 and "info frame" commands to the Changed commands section.
16122
16123 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16124
16125 * gdbtypes.c (check_stub_method_group): Remove handling of old
16126 mangling schemes.
16127 * linespec.c (find_methods): Likewise.
16128 * stabsread.c (read_member_functions): Likewise.
16129 * valops.c (search_struct_method): Likewise.
16130 (value_struct_elt_for_reference): Likewise.
16131 * NEWS: Mention this change.
16132
16133 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16134
16135 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16136 print_source_lines.
16137 * source.c (print_source_lines_base): Update line number check.
16138 (print_source_lines): New function.
16139 (source_lines_range::source_lines_range): New function.
16140 * source.h (class source_lines_range): New class.
16141 (print_source_lines): New declaration.
16142
16143 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16144
16145 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16146
16147 2019-01-08 Tom Tromey <tom@tromey.com>
16148 Simon Marchi <simon.marchi@ericsson.com>
16149
16150 PR gdb/24060
16151 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16152 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16153 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16154 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16155 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16156 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16157
16158 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16159
16160 * source.c (select_source_symtab): Move header comment to
16161 declaration in source.h.
16162 (forget_cached_source_info_for_objfile): Likewise.
16163 (forget_cached_source_info): Likewise.
16164 (identify_source_line): Likewise.
16165 * source.h (identify_source_line): Move declaration from symtab.h
16166 and add comment from source.c
16167 (print_source_lines): Likewise.
16168 (forget_cached_source_info_for_objfile): Likewise.
16169 (forget_cached_source_info): Likewise.
16170 (select_source_symtab): Likewise.
16171 (enum print_source_lines_flag): Move definition from symtab.h.
16172 * symtab.h (identify_source_line): Move declaration to source.h.
16173 (print_source_lines): Likewise.
16174 (forget_cached_source_info_for_objfile): Likewise.
16175 (forget_cached_source_info): Likewise.
16176 (select_source_symtab): Likewise.
16177 (enum print_source_lines_flag): Move definition to source.h.
16178 * tui/tui-hooks.c: Add 'source.h' include.
16179
16180 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16181
16182 * source.c (print_source_lines_base): Handle requests to print
16183 reverse line number sequences, and guard against empty lines
16184 string.
16185
16186 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16187
16188 * source.c (print_source_lines_base): Fix skip of '\r' if next
16189 character is '\n'.
16190
16191 2019-01-06 Tom Tromey <tom@tromey.com>
16192
16193 * c-exp.y (struct c_parse_state) <macro_original_text,
16194 expansion_obstack>: New member.
16195 (macro_original_text, expansion_obstack): Remove globals.
16196 (scan_macro_expansion, scanning_macro_expansion)
16197 (finished_macro_expansion): Update.
16198 (scan_macro_cleanup): Remove.
16199 (yylex, c_parse): Update.
16200
16201 2019-01-06 Tom Tromey <tom@tromey.com>
16202
16203 * c-exp.y (struct c_parse_state) <strings>: New member.
16204 (operator_stoken): Update.
16205
16206 2019-01-06 Tom Tromey <tom@tromey.com>
16207
16208 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16209 (union type_stack_elt) <typelist_val>: Now a pointer to
16210 std::vector.
16211 (type_stack_cleanup): Don't declare.
16212 (push_typelist): Update.
16213 * parse.c (pop_typelist): Return a std::vector.
16214 (push_typelist): Take a std::vector.
16215 (follow_types): Update. Do not free args.
16216 (type_stack_cleanup): Remove.
16217 * c-exp.y (struct c_parse_state): New.
16218 (cpstate): New global.
16219 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16220 (nonempty_typelist): Update.
16221 (func_mod): Create a new vector.
16222 (c_parse): Create a c_parse_state.
16223 (check_parameter_typelist): Do not delete params.
16224 (function_method): Update. Do not delete type_list.
16225
16226 2019-01-06 Tom Tromey <tom@tromey.com>
16227
16228 PR gdb/28155:
16229 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16230 check_typedef.
16231 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16232 (print_return_value): Likewise.
16233
16234 2019-01-05 Tom Tromey <tom@tromey.com>
16235
16236 * contrib/cleanup_check.py: Remove.
16237 * contrib/gcc-with-excheck: Remove.
16238 * contrib/exsummary.py: Remove.
16239 * contrib/excheck.py: Remove.
16240
16241 2019-01-05 Joel Brobecker <brobecker@adacore.com>
16242
16243 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16244 NULL. Initialize tpprev to NULL instead of assigning it
16245 to NULL on the next statement.
16246 * windows-nat.c (windows_delete_thread): Remove check for
16247 main_thread_id before printing thread exit notifications.
16248 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16249 Remove thread ID check against main_thread_id.
16250 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16251 windows_delete_thread.
16252 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16253
16254 2019-01-04 Tom Tromey <tom@tromey.com>
16255
16256 * compile/compile.c (_initialize_compile): Use upper case for
16257 metasyntactic variables.
16258 * symmisc.c (_initialize_symmisc): Use upper case for
16259 metasyntactic variables.
16260 * psymtab.c (_initialize_psymtab): Use upper case for
16261 metasyntactic variables.
16262 * demangle.c (demangle_command): Use upper case for metasyntactic
16263 variables.
16264 (_initialize_demangler): Likewise.
16265 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16266 variables.
16267
16268 2019-01-03 Tom Tromey <tom@tromey.com>
16269
16270 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16271
16272 2019-01-03 Tom Tromey <tom@tromey.com>
16273
16274 * python/py-symtab.c (salpy_str): Update.
16275 (struct salpy_sal_object) <symtab>: Now a PyObject.
16276 (salpy_dealloc): Update.
16277 (del_objfile_sal): Use gdbpy_ref.
16278
16279 2019-01-03 Tom Tromey <tom@tromey.com>
16280
16281 * python/py-type.c (convert_field): Use new_reference. Return
16282 gdbpy_ref.
16283 (make_fielditem): Return gdbpy_ref.
16284 (typy_fields): Update.
16285 (typy_getitem): Update.
16286 (field_name): Return gdbpy_ref. Use new_reference.
16287 (typy_iterator_iternext): Update.
16288
16289 2019-01-03 Tom Tromey <tom@tromey.com>
16290
16291 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16292
16293 2019-01-03 Tom Tromey <tom@tromey.com>
16294
16295 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16296 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16297 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16298 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16299 (pspy_set_type_printers): Likewise.
16300 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16301 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16302 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16303 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16304 (objfpy_set_type_printers): Likewise.
16305
16306 2019-01-03 Tom Tromey <tom@tromey.com>
16307
16308 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16309 (gdbpy_print_stack): Use gdbpy_err_fetch.
16310 * python/python-internal.h (class gdbpy_err_fetch): New class.
16311 (class gdbpy_enter) <m_error_type, m_error_value,
16312 m_error_traceback>: Remove.
16313 <m_error>: New member.
16314 (gdbpy_exception_to_string): Don't declare.
16315 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16316 * python/py-value.c (convert_value_from_python): Use
16317 gdbpy_err_fetch.
16318 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16319 gdbpy_exception_to_string.
16320 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16321 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16322 gdbpy_err_fetch.
16323
16324 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16325
16326 * linux-nat.c (delete_lwp_cleanup): Delete.
16327 (struct lwp_deleter): New struct.
16328 (lwp_info_up): New typedef.
16329 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16330 lwp_info_up.
16331
16332 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16333
16334 * linux-fork.c (class scoped_switch_fork_info): New class.
16335 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16336
16337 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16338
16339 * valops.c (find_overload_match): Remove use of null_cleanup, and
16340 calls to do_cleanups.
16341
16342 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16343
16344 * compile/compile-cplus-types.c
16345 (compile_cplus_instance::decl_name): Handle changes to
16346 cp_func_name.
16347 * cp-support.c (cp_func_name): Update header comment, update
16348 return type.
16349 * cp-support.h (cp_func_name): Update return type in declaration.
16350 * valops.c (find_overload_match): Move temp_func local to top
16351 level of function and change its type. Use temp_func to hold and
16352 delete temporary string obtained from cp_func_name.
16353
16354 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16355
16356 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16357 gdb::char_vector, remove cleanup, and update uses of `msg`.
16358
16359 2019-01-03 Jim Wilson <jimw@sifive.com>
16360
16361 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16362
16363 2019-01-02 Tom Tromey <tom@tromey.com>
16364
16365 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16366 (tdesc_parse_xml): Remove cleanups.
16367 * target-descriptions.h (make_cleanup_free_target_description):
16368 Don't declare.
16369 (target_desc_deleter): New struct.
16370 (target_desc_up): New typedef.
16371 * target-descriptions.c (target_desc_deleter::operator()): Rename
16372 from free_target_description.
16373 (make_cleanup_free_target_description): Remove.
16374
16375 2019-01-02 Tom Tromey <tom@tromey.com>
16376
16377 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16378 constructor, destructor.
16379 (linespec_parser): Remove typedef.
16380 (~linespec_parser): Rename from linespec_parser_delete.
16381 (linespec_lex_to_end, linespec_complete_label)
16382 (linespec_complete): Update.
16383 (decode_line_full): Remove cleanups.
16384 (decode_line_1): Update.
16385
16386 2019-01-02 Tom Tromey <tom@tromey.com>
16387
16388 * python/python-internal.h (inferior_to_inferior_object): Change
16389 return type.
16390 * python/py-exitedevent.c (create_exited_event_object): Update.
16391 * python/py-inferior.c (inferior_to_inferior_object): Return
16392 gdbpy_ref.
16393 (python_new_inferior, python_inferior_deleted)
16394 (thread_to_thread_object, delete_thread_object)
16395 (build_inferior_list, gdbpy_selected_inferior): Update.
16396 * python/py-infthread.c (create_thread_object): Update. Also fail
16397 if inferior_to_inferior_object fails.
16398
16399 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16400
16401 * inferior.h (class inferior) <displaced_step_state>: New field.
16402 * infrun.h (struct displaced_step_state): Move here from
16403 infrun.c. Initialize fields, add constructor.
16404 <inf>: Remove field.
16405 <reset>: New method.
16406 * infrun.c (struct displaced_step_inferior_state): Move to
16407 infrun.h.
16408 (displaced_step_inferior_states): Remove.
16409 (get_displaced_stepping_state): Adust.
16410 (displaced_step_in_progress_any_inferior): Adjust.
16411 (displaced_step_in_progress_thread): Adjust.
16412 (displaced_step_in_progress): Adjust.
16413 (add_displaced_stepping_state): Remove.
16414 (get_displaced_step_closure_by_addr): Adjust.
16415 (remove_displaced_stepping_state): Remove.
16416 (infrun_inferior_exit): Call displaced_step_state.reset.
16417 (use_displaced_stepping): Don't check for NULL.
16418 (displaced_step_prepare_throw): Call
16419 get_displaced_stepping_state.
16420 (displaced_step_fixup): Don't check for NULL.
16421 (prepare_for_detach): Don't check for NULL.
16422
16423 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16424
16425 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16426 in case of call that did not complete.
16427
16428 2019-01-02 Andrey Utkin <autkin@undo.io>
16429
16430 * symfile.c (find_separate_debug_file): Fix search of debug files for
16431 remote debuggee.
16432
16433 2019-01-02 Tom Tromey <tom@tromey.com>
16434
16435 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16436 indentation.
16437 * python/py-frame.c (frapy_older): Remove cast.
16438 (frapy_newer): Likewise.
16439 * python/py-breakpoint.c (local_setattro): Remove cast.
16440 * python/py-arch.c (archpy_name): Remove local variable.
16441 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16442
16443 2019-01-02 Joel Brobecker <brobecker@adacore.com>
16444
16445 * unittests/basic_string_view/element_access/char/empty.cc:
16446 Fix year range in copyright header.
16447
16448 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16449
16450 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16451 Delete.
16452 <operator==>: Update with for removed field.
16453 <hash>: Likewise.
16454 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16455 <isa_features>: ...this.
16456 <abi_features>: New field.
16457 (riscv_isa_flen): Update comment.
16458 (riscv_abi_xlen): New declaration.
16459 (riscv_abi_flen): New declaration.
16460 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16461 isa_features.
16462 (riscv_abi_xlen): New function.
16463 (riscv_isa_flen): Update to get answer from isa_features.
16464 (riscv_abi_flen): New function.
16465 (riscv_has_fp_abi): Update to get answer from abi_features.
16466 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16467 xlen and flen.
16468 (riscv_call_info) <xlen, flen>: Update comment.
16469 (riscv_call_arg_struct): Remove invalid assertions
16470 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16471 is removed.
16472 (riscv_gdbarch_init): Gather isa features and abi features
16473 separately, ensure both match on the gdbarch when reusing an old
16474 gdbarch. Relax an error check to allow 32-bit abi float to run on
16475 a target with 64-bit float hardware.
16476
16477 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16478
16479 * source.c (search_command_helper): Stop reverse search
16480 when line 1 has been searched.
16481
16482 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16483
16484 * record-full.c (record_full_base_target::close): Rewrite
16485 record_full_core_buf_list free logic.
16486
16487 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16488
16489 * break-catch-syscall.c (print_one_catch_syscall): xfree
16490 the last text.
16491
16492 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16493
16494 * top.c (print_gdb_version): Update Copyright year in version
16495 message.
16496
16497 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16498
16499 Update copyright year range in all GDB files.
16500
16501 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
16502
16503 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16504
16505 For older changes see ChangeLog-2018.
16506 \f
16507 Local Variables:
16508 mode: change-log
16509 left-margin: 8
16510 fill-column: 74
16511 version-control: never
16512 coding: utf-8
16513 End:
16514