gdb/ChangeLog

   1 2019-08-15  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-stack.c (tui_initialize_static_data): Remove.
   4         * tui/tui-interp.c (tui_interp::init): Don't call
   5         tui_initialize_static_data.
   6         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
   7
   8 2019-08-15  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
  11         examine tui_win_list.
  12
  13 2019-08-15  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
  16         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
  17         tui_clear_source_content.
  18         (tui_clear_source_content): Remove.
  19         (tui_source_window_base::do_erase_source_content): Hoist call to
  20         content.clear().
  21         * tui/tui-stack.c (tui_show_frame_info): Don't call
  22         tui_clear_source_content.
  23
  24 2019-08-15  Tom Tromey  <tom@tromey.com>
  25
  26         * tui/tui-winsource.h (struct tui_source_window_base)
  27         <do_erase_source_content>: New method.
  28         <erase_source_content>: New method.
  29         (tui_erase_source_content): Don't declare.
  30         * tui/tui-winsource.c (tui_clear_source_content): Update.
  31         (tui_source_window_base::do_erase_source_content): Rename from
  32         tui_erase_source_content.
  33         (tui_source_window_base::show_source_content): Update.
  34         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  35         * tui/tui-source.h (struct tui_source_window)
  36         <erase_source_content>: New method.
  37         * tui/tui-disasm.h (struct tui_disasm_window)
  38         <erase_source_content>: New method.
  39
  40 2019-08-15  Tom Tromey  <tom@tromey.com>
  41
  42         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
  43         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
  44         constructor.
  45         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
  46         * tui/tui-source.c (tui_set_source_content): Update.
  47         * tui/tui-disasm.c (tui_set_disassem_content): Update.
  48
  49 2019-08-15  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
  52         * tui/tui-winsource.c (tui_line_is_displayed): Move to
  53         tui-source.c.
  54         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
  55         Declare.
  56         * tui/tui-source.c (tui_source_window::line_is_displayed): New
  57         method.
  58         (tui_source_window::maybe_update): Update.
  59
  60 2019-08-15  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
  63         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
  64         tui-disasm.c.
  65         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
  66         Declare.
  67         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
  68         method.
  69         (tui_disasm_window::maybe_update): Update.
  70
  71 2019-08-15  Tom Tromey  <tom@tromey.com>
  72
  73         * tui/tui-winsource.h (struct tui_source_window_base)
  74         <maybe_update>: Declare.
  75         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
  76         method.
  77         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
  78         Declare.
  79         * tui/tui-source.c (tui_source_window::maybe_update): New method.
  80         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
  81         Declare.
  82         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
  83
  84 2019-08-15  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
  87
  88 2019-08-15  Tom Tromey  <tom@tromey.com>
  89
  90         * tui/tui-wingeneral.c: Include tui-stack.h.
  91         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
  92         (struct tui_locator_window): Move from tui-data.h.
  93         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
  94         (tui_initialize_static_data): Move from tui-data.c.
  95         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
  96         (struct tui_locator_window): Move to tui-stack.c.
  97         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
  98         (tui_initialize_static_data): Move to tui-stack.c.
  99
 100 2019-08-15  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui-layout.c (show_source_disasm_command)
 103         (show_source_or_disasm_and_command): Use make_visible method, not
 104         tui_make_window.
 105         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 106         Remove.
 107
 108 2019-08-15  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui-wingeneral.h (tui_make_window): Update.
 111         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 112         parameter.
 113         (tui_gen_win_info::make_visible): Update.
 114         * tui/tui-regs.c (tui_data_window::display_registers_from):
 115         Update.
 116         * tui/tui-layout.c (show_source_disasm_command)
 117         (show_source_or_disasm_and_command): Update.
 118         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 119         (enum tui_box): Remove.
 120         (struct tui_win_info) <can_box>: New method.
 121         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 122         method.
 123
 124 2019-08-15  Tom de Vries  <tdevries@suse.de>
 125
 126         * linux-nat-trad.c: Include gdbarch.h.
 127
 128 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 129
 130         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 131         register sizes.
 132
 133 2019-08-14  Tom Tromey  <tromey@adacore.com>
 134
 135         * darwin-nat.c: Include gdbarch.h.
 136         * darwin-nat-info.c: Include gdbarch.h.
 137
 138 2019-08-13  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 141         Remove.
 142         * tui/tui-data.c (tui_initialize_static_data): Update.
 143
 144 2019-08-13  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-winsource.h (struct tui_exec_info_window)
 147         <~tui_exec_info_window, maybe_allocate_content, get_content,
 148         m_content>: Remove.
 149         (struct tui_source_window_base) <set_exec_info_content,
 150         show_exec_info_content>: Don't declare.
 151         * tui/tui-winsource.c
 152         (tui_exec_info_window::maybe_allocate_content): Remove.
 153         (tui_source_window_base::update_exec_info): Rename from
 154         set_exec_info_content.
 155         (tui_source_window_base::show_exec_info_content)
 156         (tui_source_window_base::update_exec_info): Remove.
 157
 158 2019-08-13  Tom Tromey  <tom@tromey.com>
 159
 160         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 161         declare.
 162         * tui/tui-winsource.c (tui_update_source_window_as_is)
 163         (tui_update_source_windows_with_addr, tui_erase_source_content):
 164         Update.
 165         (tui_clear_exec_info_content): Remove.
 166
 167 2019-08-13  Tom Tromey  <tom@tromey.com>
 168
 169         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 170         declare.
 171         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 172         call tui_erase_exec_info_content.
 173         (tui_clear_exec_info_content): Rename from
 174         tui_erase_exec_info_content.
 175         (tui_clear_exec_info_content): Delete.
 176
 177 2019-08-13  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui-winsource.h (struct tui_source_window_base)
 180         <show_exec_info_content>: Declare.
 181         (tui_show_exec_info_content): Don't declare.
 182         * tui/tui-winsource.c
 183         (tui_source_window_base::show_exec_info_content): Rename from
 184         tui_show_exec_info_content.
 185         (tui_source_window_base::update_exec_info): Update.
 186
 187 2019-08-13  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 190         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 191         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 192         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 193         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 194         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 195         ... here.
 196
 197 2019-08-13  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-winsource.h (struct tui_source_window_base)
 200         <update_exec_info>: Declare.
 201         (tui_update_exec_info): Don't declare.
 202         * tui/tui-winsource.c (tui_update_source_window_as_is)
 203         (tui_source_window_base::refresh_all)
 204         (tui_update_all_breakpoint_info): Update.
 205         (tui_source_window_base::update_exec_info): Rename from
 206         tui_update_exec_info.
 207         * tui/tui-stack.c (tui_show_frame_info): Update.
 208
 209 2019-08-13  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-winsource.h (struct tui_source_window_base)
 212         <set_exec_info_content>: Declare.
 213         (tui_set_exec_info_content): Don't declare.
 214         * tui/tui-winsource.c
 215         (tui_source_window_base::set_exec_info_content): Rename from
 216         tui_set_exec_info_content.
 217         (tui_update_exec_info): Update.
 218
 219 2019-08-13  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-winsource.h (struct tui_source_window_base)
 222         <show_source_content>: Declare.
 223         (tui_show_source_content): Don't declare.
 224         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 225         (tui_source_window_base::show_source_content): Rename from
 226         tui_show_source_content.
 227         (tui_source_window_base::refresh_all): Update.
 228         * tui/tui-layout.c (show_source_disasm_command)
 229         (show_source_or_disasm_and_command): Update.
 230
 231 2019-08-13  Tom Tromey  <tom@tromey.com>
 232
 233         * tui/tui-winsource.c (tui_erase_source_content)
 234         (tui_show_source_content, tui_source_window_base::refresh_all):
 235         Update.
 236         * tui/tui-wingeneral.h
 237         (tui_check_and_display_highlight_if_needed): Don't declare.
 238         * tui/tui-wingeneral.c
 239         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 240         check_and_display_highlight_if_needed.
 241         * tui/tui-win.c (tui_rehighlight_all)
 242         (tui_win_info::make_visible_with_new_height): Update.
 243         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 244         (tui_data_window::erase_data_content)
 245         (tui_data_window::display_all_data): Update.
 246         * tui/tui-data.h (struct tui_win_info)
 247         <check_and_display_highlight_if_needed>: Declare.
 248
 249 2019-08-13  Tom Tromey  <tom@tromey.com>
 250
 251         * tui/tui-win.c (tui_resize_all): Call
 252         tui_delete_invisible_windows.
 253         * tui/tui-layout.c (show_layout): Call
 254         tui_delete_invisible_windows.
 255         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 256         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 257
 258 2019-08-13  Tom Tromey  <tom@tromey.com>
 259
 260         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 261         tui_add_win_to_layout.
 262
 263 2019-08-13  Tom Tromey  <tom@tromey.com>
 264
 265         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 266         * tui/tui-layout.c (tui_default_win_height): Now static.
 267
 268 2019-08-13  Tom Tromey  <tom@tromey.com>
 269
 270         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 271         single switch.
 272         (show_source_disasm_command, show_source_or_disasm_and_command):
 273         Don't check current layout.
 274
 275 2019-08-13  Tom Tromey  <tom@tromey.com>
 276
 277         * tui/tui-wingeneral.c (make_all_visible): Remove.
 278         (tui_make_all_invisible): Simplify.
 279         * tui/tui-layout.c (tui_make_all_invisible): Move from
 280         tui-wingeneral.c; simplify.
 281         (show_layout): Hoist call to tui_make_all_invisible.
 282         (show_data): Don't call tui_make_all_invisible.
 283
 284 2019-08-13  Tom Tromey  <tom@tromey.com>
 285
 286         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 287         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 288
 289 2019-08-13  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 292         tui-data.c.
 293         (show_source_disasm_command, show_data)
 294         (show_source_or_disasm_and_command): Don't use
 295         tui_set_current_layout_to.
 296         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 297         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 298         tui-layout.c.
 299         (tui_set_current_layout_to): Remove.
 300
 301 2019-08-13  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-layout.c (tui_set_layout): Update.
 304         * tui/tui-data.h (struct tui_layout_def): Remove.
 305         (tui_layout_def): Don't declare.
 306         * tui/tui-data.c (layout_def): Remove.
 307         (tui_layout_def): Remove.
 308
 309 2019-08-13  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-winsource.h (struct tui_source_window_base)
 312         <clear_detail>: No longer "override".
 313         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 314         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 315         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 316         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 317         Remove.
 318         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 319
 320 2019-08-13  Tom Tromey  <tromey@adacore.com>
 321
 322         * tracepoint.c: Don't include readline.h or history.h.
 323
 324 2019-08-12  Tom Tromey  <tom@tromey.com>
 325
 326         * configure: Rebuild.
 327         * configure.ac: Check for readline 7.
 328         * NEWS: Mention readline 7 requirement.
 329         * README: Update.
 330
 331 2019-08-12  Tom Tromey  <tom@tromey.com>
 332
 333         * mingw-hdep.c (gdb_select): Remove readline hack.
 334
 335 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 336
 337         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 338         when the function fails.
 339
 340 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 341
 342         * s390-tdep.c (s390_type_align): New function.
 343         (s390_gdbarch_init): Set it as type_align gdbarch method.
 344
 345 2019-08-09  Tom de Vries  <tdevries@suse.de>
 346
 347         PR gdb/24591
 348         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 349         pc_low with relocation offset.
 350
 351 2019-08-07  Tom Tromey  <tromey@adacore.com>
 352
 353         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 354         (print_frame_args): Update.
 355         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 356         Update.
 357         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 358         * frame.h (struct frame_arg): Add initializers.
 359         <error>: Now a unique_xmalloc_ptr.
 360
 361 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 362
 363         * NEWS: Expand the Pointer Authentication entry.
 364         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 365         (aarch64_frame_unmask_lr): ... to this.
 366         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 367         Call aarch64_frame_unmask_lr.
 368         * frame.c (struct frame_info): Add "masked" variable.
 369         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 370         (fprint_frame): Check for masked pc.
 371         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 372         declarations.
 373         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 374         * stack.c (print_frame): Check for masked pc.
 375
 376 2019-08-06  Tom Tromey  <tom@tromey.com>
 377
 378         * stabsread.c (patch_block_stabs, read_one_struct_field)
 379         (read_enum_type): Use obstack_strndup.
 380         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 381         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 382         * dwarf2read.c (guess_full_die_structure_name)
 383         (anonymous_struct_prefix): Use obstack_strndup.
 384         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 385         * c-exp.y (yylex): Use obstack_strndup.
 386         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 387         (write_var_or_type): Use obstack_strndup.
 388
 389 2019-08-06  Tom Tromey  <tom@tromey.com>
 390
 391         * symfile.c (reread_symbols): Use obstack_strdup.
 392         * stabsread.c (read_type): Use obstack_strdup.
 393         * gdb_obstack.h (obstack_strdup): New overload.
 394         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 395         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 396         (dwarf2_canonicalize_name): Use obstack_strdup.
 397         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 398         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 399         Use obstack_strdup.
 400
 401 2019-08-06  Tom Tromey  <tom@tromey.com>
 402
 403         * gdb_obstack.h (obstack_strdup): Define.
 404         * gdb_obstack.c (obstack_strdup): Don't define.
 405
 406 2019-08-06  Tom Tromey  <tom@tromey.com>
 407
 408         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 409         obstack_strdup.
 410         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 411         obstack_strdup.
 412         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 413         * stabsread.c (common_block_start): Use obstack_strdup.
 414         * objfiles.c (set_objfile_main_name, objfile): Use
 415         obstack_strdup.
 416         * namespace.c (add_using_directive): Use obstack_strdup.
 417         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 418         * jit.c (finalize_symtab): Use obstack_strdup.
 419         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 420         (guess_partial_die_structure_name, partial_die_info::fixup)
 421         (dwarf2_name): Use obstack_strdup.
 422         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 423         obstack_strdup.
 424         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 425         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 426         obstack_strdup.
 427         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 428
 429 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 430
 431         * unittests/help-doc-selftests.c: New file.
 432         * Makefile.in: Add the new file.
 433
 434 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 435
 436         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 437         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 438         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 439         the trailing '.' is not output, and the first character is uppercased.
 440         (print_help_for_command): Update call to print_doc_line.
 441         (print_doc_of_command): Likewise.
 442         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 443         * cli/cli-option.c (append_indented_doc): Do not append newline.
 444         (build_help_option): Append newline after first appended_indented_doc
 445         only if a second call is done.
 446         (build_help): Append 2 new lines before each option, except the first
 447         one.
 448         * compile/compile.c (_initialize_compile): Add new lines after
 449         %OPTIONS%, when not at the end of the help.
 450         Change help doc or code
 451         producing the help doc to respect the invariants.
 452         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 453         Also removed the new line after 'Options:', as all other commands
 454         do not put an empty line between 'Options:' and the first option.
 455         * printcmd.c (_initialize_printcmd): Likewise.
 456         * stack.c (_initialize_stack): Likewise.
 457         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 458         incorrectly telling COMMAND is optional.
 459         * ada-lang.c (_initialize_ada_language): Change help doc or code
 460         producing the help doc to respect the invariants.
 461         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 462         * breakpoint.c (_initialize_breakpoint): Likewise.
 463         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 464         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 465         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 466         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 467         _initialize_cli_style): Likewise.
 468         * corelow.c (core_target_info): Likewise.
 469         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 470         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 471         * filesystem.c (_initialize_filesystem): Likewise.
 472         * frame.c (_initialize_frame): Likewise.
 473         * gnu-nat.c (add_task_commands): Likewise.
 474         * infcall.c (_initialize_infcall): Likewise.
 475         * infcmd.c (_initialize_infcmd): Likewise.
 476         * interps.c (_initialize_interpreter): Likewise.
 477         * language.c (_initialize_language): Likewise.
 478         * linux-fork.c (_initialize_linux_fork): Likewise.
 479         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 480         * maint.c (_initialize_maint_cmds): Likewise.
 481         * memattr.c (_initialize_mem): Likewise.
 482         * printcmd.c (_initialize_printcmd): Likewise.
 483         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 484         _RegEx): Likewise.
 485         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 486         * record-btrace.c (_initialize_record_btrace): Likewise.
 487         * record-full.c (_initialize_record_full): Likewise.
 488         * record.c (_initialize_record): Likewise.
 489         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 490         * regcache.c (_initialize_regcache): Likewise.
 491         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 492         _initialize_remote): Likewise.
 493         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 494         * serial.c (_initialize_serial): Likewise.
 495         * skip.c (_initialize_step_skip): Likewise.
 496         * source.c (_initialize_source): Likewise.
 497         * stack.c (_initialize_stack): Likewise.
 498         * symfile.c (_initialize_symfile): Likewise.
 499         * symtab.c (_initialize_symtab): Likewise.
 500         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 501         * top.c (init_main): Likewise.
 502         * tracefile-tfile.c (tfile_target_info): Likewise.
 503         * tracepoint.c (_initialize_tracepoint): Likewise.
 504         * tui/tui-win.c (_initialize_tui_win): Likewise.
 505         * utils.c (add_internal_problem_command): Likewise.
 506         * valprint.c (value_print_option_defs): Likewise.
 507
 508 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 509
 510         PR build/24886
 511         * configure.ac: Drop enable-libmcheck support.
 512         * configure, config.in: Rebuild.
 513         * libmcheck.m4: Remove.
 514         * acinclude.m4: Don't include it.
 515         * Makefile.in: Don't distribute it.
 516         * top.c (print_gdb_configuration): Don't mention it.
 517
 518 2019-08-06  Tom Tromey  <tom@tromey.com>
 519
 520         * utils.c (set_output_style): Sometimes pass stream to
 521         emit_style_escape.
 522         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 523         * record-btrace.c (btrace_insn_history): Update.
 524         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 525         method.
 526         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 527         Update initializers.
 528         <m_uiout>: New field.
 529         <m_di>: Move lower.
 530         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 531         Remove "uiout" parameter.
 532         (dump_insns): Update.
 533         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 534         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 535
 536 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 537
 538         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 539         (error_in_psymtab_expansion): Likewise.
 540         (lookup_symbol_via_quick_fns): Likewise.
 541         (basic_lookup_transparent_type_quick): Likewise.
 542         (basic_lookup_transparent_type_1): Likewise.
 543
 544 2019-08-06  Tom Tromey  <tromey@adacore.com>
 545
 546         * source.c (last_source_error): Now bool.
 547         (print_source_lines_base): Make "noprint" bool.  Only open
 548         source file when last_source_visited changes.
 549
 550 2019-08-06  Tom Tromey  <tromey@adacore.com>
 551
 552         * annotate.c (annotate_source_line): Use g_source_cache.
 553         * source-cache.c (source_cache::get_plain_source_lines): Change
 554         parameters.  Populate m_offset_cache.
 555         (source_cache::ensure): New method.
 556         (source_cache::get_line_charpos): New method.
 557         (extract_lines): Move lower.  Change parameters.
 558         (source_cache::get_source_lines): Move lower.
 559         * source-cache.h (class source_cache): Update comment.
 560         <get_line_charpos>: New method.
 561         <get_source_lines>: Update comment.
 562         <clear>: Clear m_offset_cache.
 563         <get_plain_source_lines>: Change parameters.
 564         <ensure>: New method
 565         <m_offset_cache>: New member.
 566         * source.c (forget_cached_source_info_for_objfile): Update.
 567         (info_source_command): Use g_source_cache.
 568         (find_source_lines, open_source_file_with_line_charpos): Remove.
 569         (print_source_lines_base, search_command_helper): Use g_source_cache.
 570         * source.h (open_source_file_with_line_charpos): Don't declare.
 571         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 572         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 573         Use g_source_cache.
 574
 575 2019-08-06  Tom Tromey  <tromey@adacore.com>
 576
 577         * source-cache.c (source_cache::get_plain_source_lines):
 578         Remove "first_line" and "last_line" parameters.
 579         (source_cache::get_source_lines): Cache plain text.
 580         * source-cache.h (class source_cache)
 581         <get_plain_source_lines>: Update.
 582
 583 2019-08-06  Tom Tromey  <tromey@adacore.com>
 584
 585         * source-cache.c (extract_lines): No longer a method.
 586         Changed type of parameter.  Include final newline.
 587         (selftests::extract_lines_test): New function.
 588         (_initialize_source_cache): Likewise.
 589         * source-cache.h (class source_cache)
 590         <extract_lines>: Don't declare.
 591
 592 2019-08-06  Tom Tromey  <tromey@adacore.com>
 593
 594         * breakpoint.c (init_breakpoint_sal): Update.
 595         (breakpoint): Update.
 596         * breakpoint.h (struct breakpoint) <filter>: Now a
 597         unique_xmalloc_ptr.
 598
 599 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 600
 601         * NEWS: Mention dictionary access on blocks.
 602         * python/py-block.c (blpy_getitem): New function.
 603         (block_object_as_mapping): New struct.
 604         (block_object_type): Use new struct for tp_as_mapping field.
 605
 606 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 607
 608         * objfiles.h (objfile): Add a comment describing partial symbols.
 609
 610 2019-08-05  Tom Tromey  <tromey@adacore.com>
 611
 612         * compile/compile.c (_initialize_compile): Use _(), not N_().
 613         * thread.c (_initialize_thread): Use _(), not N_().
 614         * stack.c (_initialize_stack): Use _(), not N_().
 615         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 616
 617 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 618
 619         * dwarf2read.c (struct dw2_symtab_iterator):
 620         <want_specific_block>: Remove.
 621         <block_index>: Change type to gdb::optional.
 622         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 623         change type of BLOCK_INDEX parameter to gdb::optional.
 624         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 625         (dw2_lookup_symbol): Don't pass argument for
 626         WANT_SPECIFIC_BLOCK.
 627         (dw2_expand_symtabs_for_function): Don't pass argument for
 628         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 629         (class dw2_debug_names_iterator)
 630         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 631         parameter, change BLOCK_INDEX type to gdb::optional.
 632         <m_want_specific_block>: Remove.
 633         <m_block_index>: Change type to gdb::optional.
 634         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 635         gdb::optional.  Re-write in function of gdb::optional.
 636         (dw2_debug_names_lookup_symbol): Don't pass argument for
 637         WANT_SPECIFIC_BLOCK.
 638         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 639         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 640         BLOCK_INDEX.
 641
 642 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 643
 644         * NEWS: Mention changes to "info sources" command.
 645
 646 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 647
 648         * symtab.c (filename_partial_match_opts): New struct type.
 649         (struct output_source_filename_data): New members
 650         regexp, c_regexp, partial_match.
 651         (output_source_filename): Use new members to decide to print file.
 652         (info_sources_option_defs): New variable.
 653         (make_info_sources_options_def_group, print_info_sources_header,
 654         info_sources_command_completer):
 655         New functions.
 656         (info_sources_command): Read new optional arguments.
 657         (_initialize_symtab): Update info sources help.
 658
 659 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 660
 661         * ada-lang.c (exception_support_info_v0): Renamed from...
 662         (default_exception_support_info): ... this.  Create new
 663         definition for v1.
 664         (ada_has_this_exception_support): Look up catch_handlers_sym.
 665         (ada_exception_support_info_sniffer): Try v0 after default.
 666
 667 2019-08-01  Tom Tromey  <tromey@adacore.com>
 668
 669         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 670         gdbarch.h.
 671
 672 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 673
 674         * s12z-tdep.c: Fix include path for s12z-opc.h.
 675
 676 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 677
 678         * NEWS: Require GNU make 3.82.
 679
 680 2019-07-16  Tom Tromey  <tom@tromey.com>
 681
 682         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 683         declare.
 684
 685 2019-07-30  Tom Tromey  <tromey@adacore.com>
 686
 687         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 688
 689 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 690
 691         * printcmd.c (print_address_symbolic): Print negative offsets.
 692         (build_address_symbolic): Force signed arithmetic when computing
 693         offset.
 694
 695 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 696
 697         PR/24474: Add a function to lookup static variables.
 698         * NEWS: Mention this new function.
 699         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 700         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 701         * python/python.c (python_GdbMethods): Add new function.
 702
 703 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 704
 705         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 706         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 707         (objfpy_lookup_static_symbol): New function.
 708         (objfile_object_methods): Add new functions.
 709
 710 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 711
 712         * NEWS: Mention 'set|show print frame-info'.  Mention new
 713         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 714         backtrace argument.  Mention that python frame filtering code
 715         is now consistent with what 'backtrace' command prints.
 716
 717 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 718
 719         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 720         comments.
 721         (print_frame_info_auto, print_frame_info_source_line,
 722         print_frame_info_location, print_frame_info_source_and_location,
 723         print_frame_info_location_and_address, print_frame_info_short_location):
 724         New declarations.
 725         (struct frame_print_options): New member print_frame_info.
 726         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 727         * stack.h (get_user_print_what_frame_info): New declaration.
 728         (frame_show_address): New declaration.
 729         * stack.c (print_frame_arguments_choices): New value 'presence'.
 730         (print_frame_info_auto, print_frame_info_source_line,
 731         print_frame_info_location, print_frame_info_source_and_location,
 732         print_frame_info_location_and_address, print_frame_info_short_location,
 733         print_frame_info_choices, print_frame_info_print_what): New definitions.
 734         (print_frame_args): Only print dots for args if print frame-arguments
 735         is 'presence'.
 736         (frame_print_option_defs): New element for "frame-info".
 737         (get_user_print_what_frame_info): New function.
 738         (frame_show_address): Make non static.  Move comment to stack.h.
 739         (print_frame_info_to_print_what): New function.
 740         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 741         to decide what to print.
 742         (backtrace_command_1): Handle the new print_frame_arguments_presence
 743         value.
 744         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 745         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 746         (py_print_frame): In non-mi mode, use LOCATION as default for
 747         print_what, similarly to frame information printed directly by
 748         backtrace command. Handle frame-info user option in non MI mode.
 749
 750 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 751
 752         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 753         Add case for debugging 32-bit target on 64-bit host.  Revise
 754         comment.
 755
 756 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 757
 758         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 759         instead of find_function_entry_range_from_pc.
 760
 761 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 762
 763         * stack.c (find_frame_funname): Remove code which preferred
 764         minsym over symtab sym in "certain pathological cases".
 765
 766         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 767         parameter.  Change type of "do_demangle" to bool.
 768         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 769         Pass suitable "prefer_sym_over_minsym" flag to
 770         build_address_symbolic().  Don't output "+" for negative offsets.
 771         * printcmd.c (print_address_symbolic): Update invocation of
 772         build_address_symbolic to include a "prefer_sym_over_minsym"
 773         flag.
 774         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 775         Restrict cases in which use of minimal symbol is preferred to that
 776         of a found symbol.  Update comments.
 777
 778         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 779         for entry pc when entry pc is out of range for that FDE.
 780
 781 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 782
 783         PR gdb/24839:
 784         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 785         type.
 786
 787 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 788
 789         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 790         this function's Python signature.
 791
 792
 793 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 794
 795         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 796         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 797         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 798         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 799         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 800
 801
 802 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 803
 804         * h8300-tdep.c (h8300_register_name_common): New.
 805         h8300_register_name): Use h8300_register_name_common.
 806         (h8300s_register_name): Likewise.
 807         (h8300sx_register_name): Likewise.
 808         (h8300h_register_nam): New.
 809         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 810
 811
 812 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 813
 814         * arm-tdep.c (arm_skip_cmse_entry): New function.
 815         (arm_is_sgstubs_section): New function.
 816         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 817
 818 2019-07-22  Tom Tromey  <tom@tromey.com>
 819
 820         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 821         Don't self-assign.
 822
 823 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 824
 825         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 826         type_print.
 827
 828 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 829
 830         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 831         so that GDB doesn't match any msymbols when searching in the
 832         TYPES_DOMAIN.
 833         (print_symbol_info): Print using typedef_print or type_print based
 834         on the type of the symbol.  Add updated FIXME comment moved from...
 835         (_initialize_symtab): ... move and update FIXME comment to above.
 836
 837 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 838
 839         * NEWS: Mention adding -q option to "info types".
 840         * symtab.c (struct info_types_options): New struct.
 841         (info_types_options_defs): New variable.
 842         (make_info_types_options_def_group): New function.
 843         (info_types_command): Use gdb::option framework to parse options.
 844         (info_types_command_completer): New function.
 845         (_initialize_symtab): Extend the help text on "info types" and
 846         register command completer.
 847
 848 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 849
 850         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 851         (lookup_symbol_in_objfile): Change int to block_enum and add a
 852         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 853
 854 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 855
 856         * MAINTAINERS (Write After Approval): Add self.
 857
 858 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 859
 860         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 861         instruction to the dummy code region.
 862
 863 2019-07-19  Tom Tromey  <tromey@adacore.com>
 864
 865         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 866         (ARGSUSED, PARAMS, __func__): Remove rules.
 867
 868 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 869
 870         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 871         * features/arm/arm-with-iwmmxt.c: Remove.
 872         * features/arm/arm-with-iwmmxt.xml: Remove.
 873         * features/arm/arm-with-m-fpa-layout.c: Remove.
 874         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 875         * features/arm/arm-with-m-vfp-d16.c: Remove.
 876         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 877         * features/arm/arm-with-m.c: Remove.
 878         * features/arm/arm-with-m.xml: Remove.
 879         * features/arm/arm-with-neon.c: Remove.
 880         * features/arm/arm-with-neon.xml: Remove.
 881         * features/arm/arm-with-vfpv2.c: Remove.
 882         * features/arm/arm-with-vfpv2.xml: Remove.
 883         * features/arm/arm-with-vfpv3.c: Remove.
 884         * features/arm/arm-with-vfpv3.xml: Remove.
 885
 886 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 887
 888         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 889
 890 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 891
 892         * arch/aarch32.c (aarch32_create_target_description): Create
 893         target descriptions using features.
 894         * arch/arm.c (arm_create_target_description)
 895         (arm_create_mprofile_target_description): Likewise.
 896         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 897
 898 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 899
 900         * Makefile.in: Add new files.
 901         * aarch32-tdep.c: New file.
 902         * aarch32-tdep.h: New file.
 903         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 904         Call aarch32_read_description.
 905         * arch/aarch32.c: New file.
 906         * arch/aarch32.h: New file.
 907         * arch/arm.c (arm_create_target_description)
 908         (arm_create_mprofile_target_description): New function.
 909         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 910         (arm_create_target_description)
 911         (arm_create_mprofile_target_description): New declaration.
 912         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 913         read_description functions.
 914         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 915         Likewise.
 916         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 917         * arm-tdep.c (tdesc_arm_list): New variable.
 918         (arm_register_g_packet_guesses): Call create description functions.
 919         (arm_read_description) (arm_read_mprofile_description): New
 920         function.
 921         * arm-tdep.h (arm_read_description)
 922         (arm_read_mprofile_description): Add declaration.
 923         * configure.tgt: Add new files.
 924
 925 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 926
 927         * top.c (new_ui_command): Open specified terminal just once.
 928
 929 2019-07-18  Tom Tromey  <tromey@adacore.com>
 930
 931         * symtab.c (main_name): Constify return type.
 932         * symfile.c (set_initial_language): Update.
 933         * symtab.h (main_name): Constify return type.
 934
 935 2019-07-17  Tom Tromey  <tom@tromey.com>
 936
 937         * tui/tui-winsource.c (tui_update_source_window)
 938         (tui_update_source_window_as_is)
 939         (tui_update_source_windows_with_line): Remove return.
 940         * tui/tui-disasm.c (tui_show_disassem)
 941         (tui_show_disassem_and_update_source): Remove return.
 942         * tui/tui.c (tui_reset): Remove return.
 943         * tui/tui-wingeneral.c
 944         (tui_check_and_display_highlight_if_needed): Remove return.
 945
 946 2019-07-17  Tom Tromey  <tom@tromey.com>
 947
 948         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 949
 950 2019-07-17  Tom Tromey  <tom@tromey.com>
 951
 952         * tui/tui-winsource.h (struct tui_exec_info_window)
 953         (struct tui_source_window_base): Move from tui-data.h.
 954         * tui/tui-winsource.c: Move many method definitions from
 955         elsewhere.  Remove "structuring" comments.
 956         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 957         (tui_source_window_base::refresh_window): Move to
 958         tui-winsource.c.
 959         * tui/tui-win.c (tui_source_window_base::refresh_all)
 960         (tui_source_window_base::update_tab_width)
 961         (tui_source_window_base::set_new_height)
 962         (tui_source_window_base::do_make_visible_with_new_height): Move to
 963         tui-winsource.c.
 964         * tui/tui-source.h: Update.
 965         * tui/tui-source.c (tui_source_window_base::reset): Move to
 966         tui-winsource.c.
 967         * tui/tui-disasm.h: Update.
 968         * tui/tui-data.h (struct tui_exec_info_window): Move to
 969         tui-winsource.h.
 970         (struct tui_source_window_base): Likewise.
 971         * tui/tui-data.c (tui_source_window_base::clear_detail)
 972         (tui_source_window_base, ~tui_source_window_base): Move to
 973         tui-winsource.c.
 974
 975 2019-07-17  Tom Tromey  <tom@tromey.com>
 976
 977         * tui/tui-win.c (tui_resize_all)
 978         (tui_source_window_base::update_tab_width)
 979         (tui_adjust_win_heights): Update.
 980         (tui_win_info::make_invisible_and_set_new_height): Rename from
 981         make_invisible_and_set_new_height.
 982         * tui/tui-data.h (struct tui_win_info)
 983         <make_invisible_and_set_new_height>: New method.
 984
 985 2019-07-17  Tom Tromey  <tom@tromey.com>
 986
 987         * tui/tui.c: Update.
 988         * tui/tui-source.h (struct tui_source_window): Move from
 989         tui-data.h.
 990         * tui/tui-layout.c: Update.
 991         * tui/tui-disasm.c: Update.
 992         * tui/tui-data.h (struct tui_source_window): Move to
 993         tui-source.h.
 994
 995 2019-07-17  Tom Tromey  <tom@tromey.com>
 996
 997         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 998         tui-data.h.
 999         * tui/tui-data.h (struct tui_disasm_window): Move to
1000         tui-disasm.h.
1001
1002 2019-07-17  Tom Tromey  <tom@tromey.com>
1003
1004         * tui/tui-regs.h (struct tui_data_item_window): Move from
1005         tui-data.h.
1006         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1007         * tui/tui-data.h (struct tui_data_item_window): Move to
1008         tui-regs.h.
1009         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1010
1011 2019-07-17  Tom Tromey  <tom@tromey.com>
1012
1013         * tui/tui.c: Update.
1014         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1015         (tui_cmd_window::max_height): Move to tui-command.c.
1016         * tui/tui-layout.c: Update.
1017         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1018         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1019         tui-command.c.
1020         * tui/tui-command.h (struct tui_cmd_window): Move from
1021         tui-data.h.
1022         * tui/tui-command.c: Remove "structuring" comments.
1023         (tui_cmd_window::clear_detail)
1024         (tui_cmd_window::do_make_visible_with_new_height)
1025         (tui_cmd_window::max_height): Move from elsewhere.
1026
1027 2019-07-17  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1030         Now static.
1031         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1032         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1033
1034 2019-07-17  Tom Tromey  <tom@tromey.com>
1035
1036         * tui/tui.c: Update.
1037         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1038         tui-regs.c.
1039         * tui/tui-windata.h: Remove file.
1040         * tui/tui-windata.c: Remove file.
1041         * tui/tui-win.c (tui_data_window::set_new_height)
1042         (tui_data_window::do_make_visible_with_new_height): Move to
1043         tui-regs.c.
1044         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1045         * tui/tui-regs.c: Remove "structuring" comments.
1046         (tui_data_window::first_data_item_displayed)
1047         (tui_data_window::delete_data_content_windows)
1048         (tui_data_window::erase_data_content)
1049         (tui_data_window::display_all_data)
1050         (tui_data_window::refresh_all)
1051         (tui_data_window::do_scroll_vertical)
1052         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1053         (tui_data_window::do_make_visible_with_new_height)
1054         (tui_data_window::refresh_window): Move from elsewhere.
1055         (_initialize_tui_regs): Move to end of file.
1056         * tui/tui-layout.c: Update.
1057         * tui/tui-hooks.c: Update.
1058         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1059         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1060         tui-regs.c.
1061         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1062
1063 2019-07-17  Tom Tromey  <tom@tromey.com>
1064
1065         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1066         seen.
1067
1068 2019-07-17  Tom Tromey  <tom@tromey.com>
1069
1070         * tui/tui-win.c (tui_source_window_base::set_new_height)
1071         (tui_source_window_base::do_make_visible_with_new_height): Use
1072         m_has_locator field directly.
1073         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1074         method.
1075         (struct tui_source_window_base) <has_locator>: Likewise.
1076
1077 2019-07-17  Tom Tromey  <tom@tromey.com>
1078
1079         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1080         Don't declare.
1081         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1082         Remove.
1083         * tui/tui-win.c (tui_source_window_base::set_new_height)
1084         (tui_source_window_base::set_new_height)
1085         (make_invisible_and_set_new_height)
1086         (tui_source_window_base::do_make_visible_with_new_height)
1087         (tui_source_window_base::do_make_visible_with_new_height):
1088         Update.
1089         * tui/tui-layout.c (show_source_disasm_command, show_data)
1090         (show_source_or_disasm_and_command): Update.
1091         * tui/tui-layout.c (show_layout): Update.
1092
1093 2019-07-17  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-layout.c (make_data_window): Remove.
1096         (show_data): Unify creation and re-initialization cases.
1097
1098 2019-07-17  Tom Tromey  <tom@tromey.com>
1099
1100         * tui/tui-layout.c (make_source_window, make_disasm_window):
1101         Remove.
1102         (show_data): Unify creation and re-initialization cases.
1103
1104 2019-07-17  Tom Tromey  <tom@tromey.com>
1105
1106         * tui/tui-layout.c (make_command_window): Remove.
1107         (show_source_disasm_command, show_source_or_disasm_and_command):
1108         Unify creation and re-initialization cases.
1109
1110 2019-07-17  Tom Tromey  <tom@tromey.com>
1111
1112         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1113         creation and re-initialization cases.
1114
1115 2019-07-17  Tom Tromey  <tom@tromey.com>
1116
1117         * tui/tui-regs.c (tui_get_register): Return void.
1118
1119 2019-07-17  Tom Tromey  <tom@tromey.com>
1120
1121         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1122         Simplify.
1123
1124 2019-07-17  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1127         resetting.
1128
1129 2019-07-17  Tom Tromey  <tom@tromey.com>
1130
1131         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1132         * tui/tui-regs.c (tui_reg_layout): New function.
1133         (tui_show_registers, tui_reg_command): Use it.
1134         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1135         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1136         parameters.
1137         (tui_layout_command): Remove.
1138
1139 2019-07-17  Tom Tromey  <tom@tromey.com>
1140
1141         * tui/tui-layout.h (tui/tui-layout): Return void.
1142         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1143
1144 2019-07-17  Tom Tromey  <tom@tromey.com>
1145
1146         * tui/tui-layout.c (show_source_disasm_command, show_data):
1147         Update.
1148         (reset_locator): Remove.
1149         (show_source_or_disasm_and_command): Update.
1150
1151 2019-07-17  Tom Tromey  <tom@tromey.com>
1152
1153         * tui/tui-source.c (tui_source_window_base::reset): Remove
1154         win_type parameter.
1155         * tui/tui-layout.c (make_command_window, make_source_window)
1156         (make_disasm_window, make_data_window)
1157         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1158         (reset_locator, show_source_or_disasm_and_command): Update.
1159         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1160         win_type parameter.
1161         (struct tui_source_window_base) <reset>: Likewise.
1162
1163 2019-07-17  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-layout.c (show_source_disasm_command): Use
1166         reset_locator.
1167         (reset_locator): New function.
1168         (init_and_make_win): Remove.
1169         (show_source_or_disasm_and_command): Use reset_locator.
1170
1171 2019-07-17  Tom Tromey  <tom@tromey.com>
1172
1173         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1174         condition.
1175         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1176         Remove condition.
1177         * tui/tui-source.c (tui_source_window_base::reset): New method.
1178         * tui/tui-layout.c (make_command_window): Don't call
1179         init_and_make_win.
1180         (make_source_window, make_disasm_window): Don't call
1181         make_source_or_disasm_window.
1182         (make_data_window): Don't call init_and_make_win.  Change calling
1183         convention.
1184         (show_source_disasm_command, show_data): Simplify.
1185         (make_source_or_disasm_window): Remove.
1186         (show_source_or_disasm_and_command): Simplify.
1187         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1188         (struct tui_source_window_base) <reset>: Likewise.
1189         <execution_info>: Remove initializer.
1190         * tui/tui-data.c (tui_source_window_base): Initialize
1191         execution_info.
1192
1193 2019-07-17  Tom Tromey  <tom@tromey.com>
1194
1195         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1196         variable.
1197
1198 2019-07-17  Tom Tromey  <tom@tromey.com>
1199
1200         * tui/tui.c (tui_rl_other_window): Update.
1201         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1202         superclass method first.  Always iterate over regs_content.
1203         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1204         method.
1205         * tui/tui-win.c (tui_set_focus_command): Update.
1206
1207 2019-07-17  Tom Tromey  <tom@tromey.com>
1208
1209         * tui/tui-win.c (tui_set_focus_command): Rename from
1210         tui_set_focus.  Call tui_enable.
1211         (tui_set_focus_command): Remove.
1212
1213 2019-07-17  Tom Tromey  <tom@tromey.com>
1214
1215         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1216         refresh_window.
1217         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1218         touchwin.
1219         (tui_data_window::refresh_window): Call refresh_window on data
1220         items.  Always call superclass refresh_window.
1221         (tui_win_info::refresh): Remove.
1222         (tui_source_window_base::refresh_window): Update.
1223         (tui_refresh_all): Update.
1224         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1225         refresh_window.
1226         (show_source_or_disasm_and_command): Likewise.
1227         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1228         (struct tui_source_window_base) <refresh>: Likewise.
1229
1230 2019-07-17  Tom Tromey  <tom@tromey.com>
1231
1232         * tui/tui-winsource.c (tui_clear_source_content)
1233         (tui_show_source_content): Update.
1234         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1235         whether content is empty.
1236         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1237         Remove.
1238
1239 2019-07-17  Tom Tromey  <tom@tromey.com>
1240
1241         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1242         window's contents.
1243         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1244         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1245
1246 2019-07-17  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1249         (struct tui_data_item_window): Update.
1250
1251 2019-07-17  Tom Tromey  <tom@tromey.com>
1252
1253         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1254         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1255         defines.
1256
1257 2019-07-17  Tom Tromey  <tom@tromey.com>
1258
1259         * tui/tui-winsource.h (tui_erase_source_content)
1260         (tui_clear_source_content): Remove "display_prompt" parameter.
1261         * tui/tui-winsource.c (tui_update_source_window_as_is)
1262         (tui_update_source_windows_with_addr): Update.
1263         (tui_clear_source_content): Remove "display_prompt" parameter.
1264         (tui_erase_source_content): Likewise.  Simplify.
1265         (tui_show_source_content): Update.
1266         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1267         * tui/tui-stack.c (tui_show_frame_info): Update.
1268         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1269         Remove defines.
1270
1271 2019-07-17  Tom Tromey  <tom@tromey.com>
1272
1273         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1274         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1275         parameter.
1276         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1277         parameter.
1278
1279 2019-07-17  Tom Tromey  <tom@tromey.com>
1280
1281         * tui/tui-winsource.c (tui_clear_source_content)
1282         (tui_show_source_content, tui_show_exec_info_content)
1283         (tui_clear_exec_info_content): Update.
1284         * tui/tui-stack.c (tui_show_locator_content): Update.
1285         (tui_show_frame_info): Update.
1286         * tui/tui-source.h (tui_source_window): Don't declare.
1287         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1288         from tui_source_is_displayed.
1289         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1290         Remove field.
1291         (struct tui_source_window_base) <content_in_use>: New field.  Now
1292         bool.
1293         (struct tui_source_window) <showing_source_p>: New method.
1294         (TUI_SRC_WIN): Change cast.
1295         * tui/tui-data.c (tui_initialize_static_data): Update.
1296
1297 2019-07-17  Tom Tromey  <tom@tromey.com>
1298
1299         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1300         location_matches_p.
1301         * tui/tui-source.c (tui_source_window::location_matches_p): New
1302         method.
1303         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1304         method.
1305         * tui/tui-data.h (struct tui_source_window_base)
1306         <location_matches_p>: New method.
1307         (struct tui_source_window, struct tui_disasm_window)
1308         <location_matches_p>: Likewise.
1309
1310 2019-07-17  Tom Tromey  <tom@tromey.com>
1311
1312         * tui/tui-win.c (tui_set_win_height_command): Rename from
1313         tui_set_win_height.
1314         (tui_set_win_height_command): Remove.
1315
1316 2019-07-17  Tom Tromey  <tom@tromey.com>
1317
1318         * tui/tui-source.c (tui_source_window): New constructor.  Add
1319         observer.
1320         (~tui_source_window): New destructor.
1321         (tui_source_window::style_changed): New method.
1322         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1323         (tui_attach_detach_observers): Update.
1324         * tui/tui-data.h (struct tui_source_window): Make constructor not
1325         inline.  Add destructor.
1326         (struct tui_source_window) <style_changed>: New method.
1327         <m_observable>: New member.
1328
1329 2019-07-17  Tom Tromey  <tom@tromey.com>
1330
1331         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1332         * tui/tui-win.c (tui_resize_all): Fix typo.
1333
1334 2019-07-17  Tom Tromey  <tom@tromey.com>
1335
1336         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1337         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1338         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1339         * tui/tui-win.c (window_name_completer): Use foreach.
1340         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1341         (update_tab_width): Likewise.
1342         * tui/tui-layout.c (show_layout): Update.
1343         * tui/tui-data.h (class tui_window_iterator): New.
1344         (struct all_tui_windows): New.
1345         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1346
1347 2019-07-17  Tom Tromey  <tom@tromey.com>
1348
1349         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1350         parameter.  Don't reference globals.
1351         (tui_reg_command): Update.
1352
1353 2019-07-17  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-regs.c (tui_show_registers): Simplify.
1356
1357 2019-07-17  Tom Tromey  <tom@tromey.com>
1358
1359         * tui/tui-regs.c (tui_show_registers): Update.
1360         (tui_show_register_group): Add win_info parameter.
1361
1362 2019-07-17  Tom Tromey  <tom@tromey.com>
1363
1364         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1365         Rename from tui_display_reg_element_at_line.
1366         (tui_data_window::display_registers_from_line): Update.
1367         * tui/tui-data.h (struct tui_data_window)
1368         <display_reg_element_at_line>: New method.
1369
1370 2019-07-17  Tom Tromey  <tom@tromey.com>
1371
1372         * tui/tui-regs.h (tui_display_registers_from)
1373         (tui_display_registers_from_line): Don't declare.
1374         * tui/tui-windata.c (tui_data_window::display_all_data)
1375         (tui_data_window::refresh_all)
1376         (tui_data_window::do_scroll_vertical): Update.
1377         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1378         from tui_display_registers_from.
1379         (tui_display_reg_element_at_line): Update.
1380         (tui_data_window::display_registers_from_line): Rename from
1381         tui_display_registers_from_line.
1382         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1383         display_registers_from_line>: New methods.
1384
1385 2019-07-17  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1388         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1389         from tui_erase_data_content.
1390         (tui_data_window::display_all_data)
1391         (tui_data_window::refresh_all)
1392         (tui_data_window::do_scroll_vertical): Update.
1393         * tui/tui-regs.c (tui_show_registers): Update.
1394         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1395         New method.
1396
1397 2019-07-17  Tom Tromey  <tom@tromey.com>
1398
1399         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1400         declare.
1401         * tui/tui-windata.c
1402         (tui_data_window::delete_data_content_windows): Rename from
1403         tui_delete_data_content_windows.
1404         (tui_data_window::display_all_data)
1405         (tui_data_window::do_scroll_vertical): Update.
1406         * tui/tui-data.h (struct tui_data_window)
1407         <delete_data_content_windows>: New method.
1408
1409 2019-07-17  Tom Tromey  <tom@tromey.com>
1410
1411         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1412         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1413
1414 2019-07-17  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1417         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1418         from tui_display_all_data.
1419         * tui/tui-win.c
1420         (tui_data_window::do_make_visible_with_new_height): Update.
1421         * tui/tui-regs.c (tui_show_registers): Update.
1422         * tui/tui-layout.c (tui_set_layout): Update.
1423         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1424         method.
1425
1426 2019-07-17  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1429         * tui/tui-windata.c (tui_display_data_from): Remove.
1430         (tui_data_window::refresh_all): Update.
1431
1432 2019-07-17  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1435         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1436         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1437         tui_display_registers_from_line.
1438         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1439         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1440         "force_display" parameter.
1441
1442 2019-07-17  Tom Tromey  <tom@tromey.com>
1443
1444         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1445         declare.
1446         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1447         Rename from tui_first_reg_element_no_inline.
1448         (tui_display_reg_element_at_line)
1449         (tui_display_registers_from_line): Update.
1450         * tui/tui-data.h (struct tui_data_window)
1451         <first_reg_element_no_inline>: New method.
1452
1453 2019-07-17  Tom Tromey  <tom@tromey.com>
1454
1455         * tui/tui-windata.c (tui_display_data_from)
1456         (tui_data_window::do_scroll_vertical): Update.
1457         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1458         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1459         Rename from tui_line_from_reg_element_no.
1460         (tui_display_registers_from_line): Update.
1461         * tui/tui-data.h (struct tui_data_window)
1462         <line_from_reg_element_no>: New method.
1463
1464 2019-07-17  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1467         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1468         tui_last_regs_line_no.
1469         (tui_display_reg_element_at_line)
1470         (tui_display_registers_from_line): Update.
1471         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1472         method.
1473
1474 2019-07-17  Tom Tromey  <tom@tromey.com>
1475
1476         PR tui/24722:
1477         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1478         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1479         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1480         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1481         (tui_update_breakpoint_info): Likewise.
1482         * tui/tui-hooks.c (tui_event_create_breakpoint)
1483         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1484         Update.
1485
1486 2019-07-17  Tom Tromey  <tom@tromey.com>
1487
1488         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1489
1490 2019-07-17  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-winsource.c (tui_update_source_window_as_is)
1493         (tui_update_source_windows_with_addr): Update.
1494         * tui/tui-source.h (tui_set_source_content)
1495         (tui_show_symtab_source): Add "win_info" parameter.
1496         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1497         parameter.
1498         (tui_show_symtab_source): Likewise.
1499
1500 2019-07-17  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-wingeneral.c
1503         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1504
1505 2019-07-17  Tom Tromey  <tom@tromey.com>
1506
1507         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1508         (struct tui_cmd_window) <can_scroll>: New method.
1509         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1510         method.
1511
1512 2019-07-17  Tom Tromey  <tromey@adacore.com>
1513
1514         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1515         do_field_signed>: Rename.  Change type of "value".
1516         * ui-out.c (ui_out::field_signed): Rename from field_int.
1517         Change type of "value".
1518         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1519         type of "value".
1520         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1521         do_field_int.  Change type of "value".
1522         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1523         do_field_int.  Change type of "value".
1524         * tracepoint.c (trace_status_mi, tfind_1)
1525         (print_one_static_tracepoint_marker): Update.
1526         * thread.c (print_thread_info_1, print_selected_thread_frame):
1527         Update.
1528         * stack.c (print_frame, print_frame_info): Update.
1529         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1530         Update.
1531         * source.c (print_source_lines_base): Update.
1532         * skip.c (info_skip_command): Update.
1533         * record-btrace.c (btrace_ui_out_decode_error)
1534         (btrace_call_history_src_line): Update.
1535         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1536         Update.
1537         * progspace.c (print_program_space): Update.
1538         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1539         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1540         do_field_int.  Change type of "value".
1541         * mi/mi-out.c (mi_ui_out::do_table_begin)
1542         (mi_ui_out::do_table_header): Update.
1543         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1544         type of "value".
1545         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1546         (mi_cmd_data_list_changed_registers, output_register)
1547         (mi_cmd_data_read_memory, mi_load_progress)
1548         (mi_cmd_trace_frame_collected): Update.
1549         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1550         Update.
1551         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1552         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1553         (mi_cmd_var_list_children, varobj_update_one): Update.
1554         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1555         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1556         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1557         * inferior.c (print_inferior): Update.
1558         * gdb_bfd.c (print_one_bfd): Update.
1559         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1560         Update.
1561         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1562         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1563         do_field_int.  Change type of "value".
1564         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1565         do_field_int.  Change type of "value".
1566         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1567         (print_one_breakpoint_location, print_it_catch_fork)
1568         (print_one_catch_fork, print_it_catch_vfork)
1569         (print_one_catch_vfork, print_it_catch_solib)
1570         (print_it_catch_exec, print_it_ranged_breakpoint)
1571         (print_mention_watchpoint, print_mention_masked_watchpoint)
1572         (bkpt_print_it, update_static_tracepoint): Update.
1573         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1574         * break-catch-syscall.c (print_it_catch_syscall): Update.
1575         * ada-tasks.c (print_ada_task_info): Update.
1576         * ada-lang.c (print_it_exception, print_mention_exception):
1577         Update.
1578
1579 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1580
1581         PR breakpoints/24541
1582         * gdbarch.c: Regenerate.
1583         * gdbarch.h: Regenerate.
1584         * gdbarch.sh: Adjust return type and parameter types for
1585         'stap_adjust_register'.
1586         (i386_stap_adjust_register): Adjust signature and return new
1587         register name.
1588         * stap-probe.c (stap_parse_register_operand): Adjust use of
1589         'gdbarch_stap_adjust_register'.
1590
1591 2019-07-17  Tom Tromey  <tromey@adacore.com>
1592
1593         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1594         declare VEC.
1595         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1596         std::vector.
1597         (struct s390_process_info): Add initializers.
1598         (s390_add_process): Use new.
1599         (s390_linux_nat_target::low_forget_process): Use delete.
1600         (s390_linux_nat_target::low_new_fork)
1601         (s390_linux_nat_target::stopped_by_watchpoint)
1602         (s390_linux_nat_target::low_prepare_to_resume)
1603         (s390_linux_nat_target::insert_watchpoint)
1604         (s390_linux_nat_target::insert_hw_breakpoint)
1605         (s390_linux_nat_target::remove_watchpoint)
1606         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1607
1608 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1609
1610         * aarch64-fbsd-nat.c: Include regcache.h.
1611         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1612         argument.
1613         (aarch64_fbsd_nat_target::fetch_registers)
1614         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1615         variable.
1616         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1617
1618 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1619
1620         * fbsd-nat.c: Include gdbarch.h.
1621
1622 2019-07-15  Tom Tromey  <tromey@adacore.com>
1623
1624         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1625
1626 2019-07-15  Tom Tromey  <tromey@adacore.com>
1627
1628         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1629         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1630         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1631         * cli-out.c (cli_ui_out::do_field_int): New method.
1632         * ui-out.c (ui_out::field_unsigned): New method.
1633         * symfile.c (generic_load): Use field_unsigned.
1634         (print_transfer_performance): Likewise.
1635         * record-btrace.c (ui_out_field_uint): Remove.
1636         (btrace_call_history_insn_range, btrace_call_history): Use
1637         field_unsigned.
1638         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1639         field_unsigned.
1640         * ui-out.h (class ui_out) <field_unsigned>: New method.
1641         <do_field_unsigned>: Likewise.
1642
1643 2019-07-15  Tom Tromey  <tromey@adacore.com>
1644
1645         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1646         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1647         * target.c (flash_erase_command): Use field_string.
1648         * infrun.c (print_signal_received_reason): Use field_string.
1649         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1650         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1651         field_string.
1652         * ada-tasks.c (print_ada_task_info): Use field_string.
1653
1654 2019-07-15  Tom Tromey  <tromey@adacore.com>
1655
1656         * target.c (flash_erase_command): Use field_core_addr.
1657         * symfile.c (generic_load): Use field_core_addr.
1658         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1659         Use field_core_addr.
1660         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1661         field_core_addr.
1662
1663 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1664
1665         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1666         value if its desired type is smaller than a CORE_ADDR and signed.
1667
1668 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1669
1670         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1671         of changes to field names, and use new is_reference field to
1672         decide if a property is a reference or not.
1673         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1674         field.
1675         (struct dwarf2_property_baton): Update header comment, rename
1676         'referenced_type' to 'property_type' and update comments.
1677         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1678         default property type, store in property baton, update to take
1679         accound of renamed field.
1680         (read_func_scope): Update call to attr_to_dynamic_prop.
1681         (read_array_type): Likewise.
1682         (dwarf2_per_cu_addr_sized_int_type): New function.
1683         (read_subrange_index_type): Move type finding code to
1684         dwarf2_per_cu_addr_sized_int_type.
1685         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1686         (dwarf2_per_cu_addr_type): New function.
1687         (set_die_type): Update calls to attr_to_dynamic_prop.
1688
1689 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1690
1691         * dwarf2read.c (read_subrange_index_type): New function.
1692         (read_subrange_type): Move code into new function and call it.
1693         * gdbtypes.c (create_range_type): Add some asserts.
1694
1695 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1696
1697         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1698         update return statements.
1699         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1700         declaration, and update comment to match.
1701         * gdbtypes.c (resolve_dynamic_array): Update call to
1702         dwarf2_evaluate_property to match new return type.
1703
1704 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1705
1706         * valarith.c (value_subscripted_rvalue): Change lowerbound
1707         parameter type from int to LONGEST.
1708         * value.h (value_subscripted_rvalue): Likewise in declaration.
1709
1710 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1711
1712         * cli/cli-utils.c (info_print_command_completer): New function.
1713         * cli/cli-utils.h: Add 'completer.h' include, and forward
1714         declaration for 'struct cmd_list_element'.
1715         (info_print_command_completer): Declare.
1716         * stack.c (_initialize_stack): Add completer for 'info locals' and
1717         'info args'.
1718         * symtab.c (_initialize_symtab): Add completer for 'info
1719         variables' and 'info functions'.
1720         * NEWS: Mention completion for additional info commands.
1721
1722 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1723
1724         * cli/cli-utils.c (extract_info_print_args): Delete.
1725         (extract_arg_maybe_quoted): Delete.
1726         (info_print_options_defs): New variable.
1727         (make_info_print_options_def_group): New function.
1728         (extract_info_print_options): Define new function.
1729         * cli/cli-utils.h (extract_info_print_args): Delete.
1730         (struct info_print_options): New structure.
1731         (extract_info_print_options): Declare new function.
1732         * stack.c (info_locals_command): Update to use new
1733         extract_info_print_options, also add a header comment.
1734         (info_args_command): Likewise.
1735         * symtab.c (info_variables_command): Likewise.
1736         (info_functions_command): Likewise.
1737
1738 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1739
1740         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1741         to extract string arguments.
1742         * common/common-utils.c (extract_string_maybe_quoted): New function.
1743         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1744
1745 2019-07-11  Tom Tromey  <tromey@adacore.com>
1746
1747         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1748         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1749         * top.h (gdbinit): Don't declare.
1750         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1751         into...
1752         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1753         * top.c (gdb_init): Don't call init_cli_cmds.
1754         (gdbinit): Remove.
1755         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1756
1757 2019-07-11  Tom Tromey  <tromey@adacore.com>
1758
1759         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1760         after it has been moved.
1761
1762 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1763
1764         * valops.c (value_must_coerce_to_target): Change return type to
1765         bool.
1766         * value.h (value_must_coerce_to_target): Likewise.
1767
1768 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1769
1770         * breakpoint.c (is_hardware_watchpoint): Remove
1771         forward-declaration.
1772         (is_masked_watchpoint): Change return type to bool.
1773         (is_tracepoint): Likewise.
1774         (is_breakpoint): Likewise.
1775         (is_hardware_watchpoint): Likewise.
1776         (is_watchpoint): Likewise.
1777         (is_no_memory_software_watchpoint): Likewise.
1778         (is_catchpoint): Likewise.
1779         (breakpoint_1): Make FILTER parameter's return type bool.
1780         is_masked_watchpoint): Change return type to bool.
1781         (save_breakpoints): Make FILTER parameter's return type bool.
1782         * breakpoint.h (is_breakpoint): Change return type to bool.
1783         (is_watchpoint): Likewise.
1784         (is_catchpoint): Likewise.
1785         (is_tracepoint): Likewise.
1786
1787 2019-07-10  Tom Tromey  <tom@tromey.com>
1788
1789         * defs.h: Don't include gdbarch.h.
1790         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1791         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1792         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1793         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1794         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1795         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1796         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1797         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1798         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1799         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1800         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1801         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1802         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1803         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1804         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1805         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1806         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1807         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1808         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1809         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1810         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1811         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1812         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1813         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1814         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1815         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1816         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1817
1818 2019-07-10  Tom Tromey  <tromey@adacore.com>
1819
1820         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1821         * breakpoint.c (init_ada_exception_breakpoint): Register as
1822         bp_catchpoint.
1823         (print_one_breakpoint_location, print_one_breakpoint): Use
1824         is_ada_exception_catchpoint.
1825         * ada-lang.c (class ada_catchpoint_location): Pass
1826         bp_loc_software_breakpoint to bp_location constructor.
1827         (is_ada_exception_catchpoint): New function.
1828
1829 2019-07-10  Tom Tromey  <tromey@adacore.com>
1830
1831         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1832         VEC.
1833         (struct arm_exidx_entry): New method operator<.
1834         (struct arm_exidx_data) <section_maps>: Change type.
1835         (arm_exidx_data_free): Remove.
1836         (arm_exidx_data_key): Change type.  Move lower.
1837         (arm_exidx_new_objfile): Update.
1838         (arm_compare_exidx_entries): Remove.
1839         (arm_find_exidx_entry, _initialize_arm_tdep)
1840
1841 2019-07-10  Tom Tromey  <tromey@adacore.com>
1842
1843         * solib-spu.c (ocl_program_data_key): Change type.
1844         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1845         Update.
1846
1847 2019-07-10  Tom Tromey  <tromey@adacore.com>
1848
1849         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1850         (struct solib_aix_inferior_data) <library_list>: Change type.
1851         (solib_aix_inferior_data_handle): Change type.
1852         (get_solib_aix_inferior_data): Update.
1853         (solib_aix_free_library_list): Remove.
1854         (library_list_start_library): Update.
1855         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1856         return type.
1857         (solib_aix_get_library_list)
1858         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1859         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1860
1861 2019-07-10  Tom Tromey  <tromey@adacore.com>
1862
1863         * solib-dsbt.c (struct dsbt_info): Add initializers.
1864         (solib_dsbt_pspace_data): Change type.
1865         (dsbt_pspace_data_cleanup): Remove.
1866         (get_dsbt_info, _initialize_dsbt_solib): Update.
1867
1868 2019-07-10  Tom Tromey  <tromey@adacore.com>
1869
1870         * spu-tdep.c (spu_overlay_data): Change type.
1871         (spu_get_overlay_table, spu_overlay_new_objfile)
1872         (_initialize_spu_tdep): Update.
1873
1874 2019-07-10  Tom Tromey  <tromey@adacore.com>
1875
1876         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1877         destructor.
1878         (dbx_objfile_data_key): Change type and declare later.
1879         (DBX_SYMFILE_INFO): Rewrite.
1880         * dbxread.c (dbx_objfile_data_key): Change type.
1881         (dbx_symfile_init): Update.
1882         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1883         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1884         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1885
1886 2019-07-10  Tom Tromey  <tromey@adacore.com>
1887
1888         * jit.c (jit_program_space_key): Change type.  Move lower.
1889         (get_jit_program_space_data): Update.
1890         (jit_program_space_data_cleanup): Remove.
1891         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1892         Update.
1893         (struct jit_program_space_data): Add initializers.
1894
1895 2019-07-10  Tom Tromey  <tromey@adacore.com>
1896
1897         * solib-darwin.c (struct darwin_info): Add initializers.
1898         (solib_darwin_pspace_data): Change type.
1899         (darwin_pspace_data_cleanup): Remove.
1900         (get_darwin_info, _initialize_darwin_solib): Update.
1901
1902 2019-07-10  Tom Tromey  <tromey@adacore.com>
1903
1904         * remote-sim.c (struct sim_inferior_data): Add initializers,
1905         constructor, and destructor.
1906         (sim_inferior_data_key): Change type.  Move lower.
1907         (check_for_duplicate_sim_descriptor): Update.
1908         (get_sim_inferior_data): Use new.  Update.
1909         (~sim_inferior_data_cleanup): Rename from
1910         sim_inferior_data_cleanup.  Simplify.
1911         (gdbsim_close_inferior, simulator_command)
1912         (sim_command_completer, _initialize_remote_sim): Update.
1913         (next_pid, INITIAL_PID): Move earlier.
1914
1915 2019-07-10  Tom Tromey  <tromey@adacore.com>
1916
1917         * python/python-internal.h (create_thread_object): Return
1918         gdbpy_ref.
1919         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1920         * python/py-inferior.c (struct threadlist_entry): Add
1921         constructor.
1922         <thread_obj>: Now a gdbpy_ref.
1923         (thread_to_thread_object): Update.
1924         (add_thread_object): Use new.
1925         (delete_thread_object): Use delete.
1926         (infpy_threads): Update.
1927         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1928         GIL.
1929
1930 2019-07-10  Tom Tromey  <tromey@adacore.com>
1931
1932         * valops.c (value_cast): Specialize error message for Ada.
1933
1934 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1935
1936         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1937
1938 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1939
1940         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1941         bpstat_should_step): Return bool, adjust comments.
1942         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1943         bpstat_should_step): Likewise.
1944
1945 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1946
1947         * features/Makefile: Use feature target descriptions for Arm.
1948         * features/arm/arm-core.c: Generate new file.
1949         * features/arm/arm-fpa.c: Likewise.
1950         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1951         * features/arm/arm-m-profile.c: Likewise.
1952         * features/arm/arm-vfpv2.c: Likewise.
1953         * features/arm/arm-vfpv3.c: Likewise.
1954         * features/arm/xscale-iwmmxt.c: Likewise.
1955         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1956
1957 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1958
1959         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1960         ptrace earlier.
1961
1962 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1963
1964         * features/aarch64-pauth.c: Regenerate.
1965
1966 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1967
1968         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1969         bool.
1970         (bpstat_what): Use false instead of 0.
1971
1972 2019-07-09  Pedro Alves  <palves@redhat.com>
1973
1974         * break-catch-throw.c (is_exception_catchpoint): New.
1975         * breakpoint.c (print_one_breakpoint_location): New parameter
1976         'raw_loc'.  Handle it.  Use
1977         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1978         looking at the breakpoint's type.
1979         (print_one_breakpoint): If handling "maint info breakpoints", also
1980         print locations of exception catchpoints.
1981         * breakpoint.h (is_exception_catchpoint): Declare.
1982
1983 2019-07-09  Pedro Alves  <palves@redhat.com>
1984
1985         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1986         "addr" field.
1987         (allocate_location_exception_catchpoint): New.
1988         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1989         (initialize_throw_catchpoint_ops): Install
1990         allocate_location_exception_catchpoint as allocate_location
1991         method.
1992         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1993         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1994         bp_loc_other.
1995         (breakpoint_address_is_meaningful): Delete.
1996         (bl_address_is_meaningful): New.
1997         (breakpoint_locations_match): Adjust comment.
1998         (bp_location_from_bp_type): New, factored out of...
1999         (bp_location::bp_location(breakpoint *)): ... this.
2000         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2001         factored out of...
2002         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2003         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2004         breakpoint_address_is_meaningful.
2005         (bp_locations_compare): Adjust comment.
2006         (update_global_location_list): Use bl_address_is_meaningful
2007         instead of breakpoint_address_is_meaningful.
2008         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2009         explicit.
2010         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2011         * python/py-breakpoint.c (bppy_get_location): No longer check
2012         whether location is null.
2013
2014 2019-07-09  Pedro Alves  <palves@redhat.com>
2015
2016         PR c++/15468
2017         * breakpoint.c (print_one_breakpoint_location): Remove
2018         single-location assert.
2019
2020 2019-07-09  Tom Tromey  <tom@tromey.com>
2021
2022         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2023         * configure: Rebuild.
2024         * configure.ac: Change common to gdbsupport.
2025         * gdbsupport: Rename from common.
2026         * acinclude.m4: Change common to gdbsupport.
2027         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2028         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2029         gdbsupport.
2030         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2031         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2032         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2033         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2034         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2035         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2036         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2037         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2038         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2039         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2040         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2041         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2042         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2043         coff-pe-read.c, command.h, compile/compile-c-support.c,
2044         compile/compile-c.h, compile/compile-cplus-symbols.c,
2045         compile/compile-cplus-types.c, compile/compile-cplus.h,
2046         compile/compile-loc2c.c, compile/compile.c, completer.c,
2047         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2048         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2049         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2050         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2051         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2052         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2053         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2054         features/aarch64-core.c, features/aarch64-fpu.c,
2055         features/aarch64-pauth.c, features/aarch64-sve.c,
2056         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2057         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2058         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2059         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2060         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2061         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2062         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2063         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2064         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2065         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2066         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2067         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2068         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2069         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2070         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2071         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2072         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2073         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2074         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2075         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2076         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2077         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2078         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2079         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2080         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2081         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2082         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2083         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2084         minsyms.c, mips-linux-tdep.c, namespace.h,
2085         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2086         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2087         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2088         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2089         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2090         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2091         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2092         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2093         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2094         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2095         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2096         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2097         procfs.c, producer.c, progspace.h, psymtab.h,
2098         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2099         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2100         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2101         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2102         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2103         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2104         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2105         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2106         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2107         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2108         target-memory.c, target.c, target.h, target/waitstatus.c,
2109         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2110         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2111         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2112         unittests/array-view-selftests.c,
2113         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2114         unittests/common-utils-selftests.c,
2115         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2116         unittests/format_pieces-selftests.c,
2117         unittests/function-view-selftests.c,
2118         unittests/lookup_name_info-selftests.c,
2119         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2120         unittests/mkdir-recursive-selftests.c,
2121         unittests/observable-selftests.c,
2122         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2123         unittests/parse-connection-spec-selftests.c,
2124         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2125         unittests/scoped_fd-selftests.c,
2126         unittests/scoped_mmap-selftests.c,
2127         unittests/scoped_restore-selftests.c,
2128         unittests/string_view-selftests.c, unittests/style-selftests.c,
2129         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2130         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2131         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2132         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2133         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2134         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2135
2136 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2137
2138         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2139         bool value.
2140         (decode_digits_ordinary): Set explicit_line field in sal.
2141         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2142         symtab_and_line that was set on an explicit line number in
2143         assembler code.  Do always update the recorded symtab and line if
2144         we do skip the prologue.
2145
2146 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2147
2148         * breakpoint.c (set_breakpoint_location_function): Remove
2149         explicit_loc parameter.
2150         (momentary_breakpoint_from_master): Update call to
2151         set_breakpoint_location_function.
2152         (add_location_to_breakpoint): Likewise.
2153
2154 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2155
2156         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2157         required features based on default bfd type when no specific bfd
2158         is present.
2159
2160 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2161
2162         * NEWS: Mention that GDB printf and eval commands can now print
2163         C-style and Ada-style convenience var strings without
2164         calling the inferior.
2165         * printcmd.c (printf_c_string): Locally print GDB internal var
2166         instead of transiting via the inferior.
2167         (printf_wide_c_string): Likewise.
2168
2169 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2170
2171         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2172
2173 2019-07-04  Tom Tromey  <tom@tromey.com>
2174
2175         PR tui/24724:
2176         * tui/tui-winsource.c (tui_clear_source_content): Update.
2177         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2178         (tui_update_breakpoint_info): Update.
2179         (tui_set_exec_info_content): Update.
2180         * tui/tui-source.c (tui_set_source_content_nil): Update.
2181         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2182         has_break.
2183         * tui/tui-data.h (enum tui_bp_flag): New.
2184         (tui_bp_flags): New enum flags type.
2185         (struct tui_source_element) <break_mode>: Change type.  Rename
2186         from has_break.
2187         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2188         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2189         constants.
2190         * tui/tui-winsource.h: Fix comment.
2191
2192 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2193
2194         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2195         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2196         (store_fpregs_to_thread)
2197         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2198         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2199         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2200         (IWMMXT_REGS_SIZE): Add define.
2201         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2202         (fetch_vfp_regs, store_vfp_regs)
2203         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2204         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2205
2206 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2207
2208         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2209         defines.
2210         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2211         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2212         (ARM_INT_REGISTER_SIZE): ...to this.
2213         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2214         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2215         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2216         (arm_linux_collect_gregset, supply_nwfpe_register)
2217         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2218         defines.
2219         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2220         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2221         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2222         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2223         (arm_return_in_memory, arm_store_return_value)
2224         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2225         (arm_record_ld_st_multiple): Likewise.
2226         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2227         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2228
2229 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2230
2231         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2232         AARCH64_DISPLACED_MODIFIED_INSNS.
2233         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2234         (aarch64_displaced_step_copy_insn): Likewise.
2235         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2236         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2237         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2238         ARM_DISPLACED_MODIFIED_INSNS.
2239         * arm-tdep.c (arm_gdbarch_init): Likewise.
2240         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2241         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2242         (struct arm_displaced_step_closure): Use
2243         ARM_DISPLACED_MODIFIED_INSNS.
2244
2245 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2246
2247         * features/Makefile: Remove unused xml files.
2248         * features/aarch64.xml: Remove.
2249         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2250         * features/i386/amd64-avx-avx512.xml: Remove.
2251         * features/i386/amd64-avx-linux.xml: Remove.
2252         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2253         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2254         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2255         * features/i386/amd64-avx-mpx.xml: Remove.
2256         * features/i386/amd64-avx.xml: Remove.
2257         * features/i386/amd64-linux.xml: Remove.
2258         * features/i386/amd64-mpx-linux.xml: Remove.
2259         * features/i386/amd64-mpx.xml: Remove.
2260         * features/i386/amd64.xml: Remove.
2261         * features/i386/i386-avx-avx512-linux.xml: Remove.
2262         * features/i386/i386-avx-avx512.xml: Remove.
2263         * features/i386/i386-avx-linux.xml: Remove.
2264         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2265         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2266         * features/i386/i386-avx-mpx-linux.xml: Remove.
2267         * features/i386/i386-avx-mpx.xml: Remove.
2268         * features/i386/i386-avx.xml: Remove.
2269         * features/i386/i386-linux.xml: Remove.
2270         * features/i386/i386-mmx-linux.xml: Remove.
2271         * features/i386/i386-mmx.xml: Remove.
2272         * features/i386/i386-mpx-linux.xml: Remove.
2273         * features/i386/i386-mpx.xml: Remove.
2274         * features/i386/i386.xml: Remove.
2275         * features/i386/x32-avx-avx512-linux.xml: Remove.
2276         * features/i386/x32-avx-linux.xml: Remove.
2277         * features/i386/x32-linux.xml: Remove.
2278
2279 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2280
2281         * regformats/aarch64.dat: Remove.
2282         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2283         * regformats/i386/amd64-avx-linux.dat: Remove.
2284         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2285         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2286         * regformats/i386/amd64-linux.dat: Remove.
2287         * regformats/i386/amd64-mpx-linux.dat: Remove.
2288         * regformats/i386/amd64.dat: Remove.
2289         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2290         * regformats/i386/i386-avx-linux.dat: Remove.
2291         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2292         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2293         * regformats/i386/i386-linux.dat: Remove.
2294         * regformats/i386/i386-mmx-linux.dat: Remove.
2295         * regformats/i386/i386-mpx-linux.dat: Remove.
2296         * regformats/i386/i386.dat: Remove.
2297         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2298         * regformats/i386/x32-avx-linux.dat: Remove.
2299         * regformats/i386/x32-linux.dat: Remove.
2300
2301 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2302
2303         * aarch64-tdep.c: Remove xml self tests.
2304         * amd64-linux-tdep.c: Likewise.
2305         * amd64-tdep.c: Likewise.
2306         * i386-linux-tdep.c: Likewise.
2307         * i386-tdep.c: Likewise.
2308
2309 2019-07-03  Pedro Alves  <palves@redhat.com>
2310
2311         PR cli/24732
2312         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2313         (pipe_cmd_option_defs): New.
2314         (make_pipe_cmd_options_def_group): New.
2315         (pipe_command): Use gdb::option::process_options.
2316         (pipe_command_completer): New function.
2317         (_initialize_cli_cmds): Install completer for "pipe" command.
2318
2319 2019-07-03  Pedro Alves  <palves@redhat.com>
2320
2321         * cli/cli-option.c (union option_value) <string>: New field.
2322         (struct option_def_and_value): Add ctor, move ctor, dtor and
2323         use DISABLE_COPY_AND_ASSIGN.
2324         (option_def_and_value::clear_value): New.
2325         (parse_option, save_option_value_in_ctx, get_val_type_str)
2326         (add_setshow_cmds_for_options): Handle var_string.
2327         * cli-option.h (union option_def::var_address) <string>: New
2328         field.
2329         (struct string_option_def): New.
2330         * maint-test-options.c (struct test_options_opts): Add default
2331         ctor and use DISABLE_COPY_AND_ASSIGN.
2332         <string_opt>: New field.
2333         (test_options_opts::~test_options_opts): New.
2334         (test_options_opts::dump): Also dump "-string".
2335         (test_options_option_defs): Install "string.
2336
2337 2019-07-03  Pedro Alves  <palves@redhat.com>
2338
2339         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2340         option_value with a null enumeration.
2341         (complete_options): Save the option values in the context.
2342         (save_option_value_in_ctx): New, factored out from ...
2343         (process_options): ... here.
2344         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2345         of the function.
2346         * maint-test-options.c (test_options_opts::dump): New, factored
2347         out from ...
2348         (maintenance_test_options_command_mode): ... here.
2349         (maintenance_test_options_command_completion_result): Delete.
2350         (maintenance_test_options_command_completion_text): Update
2351         comment.
2352         (maintenance_show_test_options_completion_result): Change
2353         prototype.  Just print
2354         maintenance_test_options_command_completion_text.
2355         (save_completion_result): New.
2356         (maintenance_test_options_completer_mode): Pass options context to
2357         complete_options, and then save a dump.
2358         (_initialize_maint_test_options): Use add_cmd to install "maint
2359         show test-options-completion-result".
2360
2361 2019-07-03  Pedro Alves  <palves@redhat.com>
2362
2363         * NEWS (New commands): Mention "with" and "maint with".
2364         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2365         (with_command, with_command_completer): New.
2366         (pipe_command): Adjust to new repeat_previous
2367         interface.
2368         (_initialize_cli_cmds): Install the "with" command and its "w"
2369         alias.
2370         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2371         declarations.
2372         * cli/cli-setshow.c (parse_cli_var_uinteger)
2373         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2374         argument strings for all var_types.
2375         (get_setshow_command_value_string): New, factored out from ...
2376         (do_show_command): ... this.
2377         * cli/cli-setshow.h: Include <string>.
2378         (get_setshow_command_value_string): Declare.
2379         * command.h (repeat_previous): Now returns const char *.  Adjust
2380         comment.
2381         * maint.c: Include "cli/cli-cmds.h".
2382         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2383         (_initialize_maint_cmds): Register the "maintenance with" command.
2384         * top.c (repeat_previous): Move bits from pipe_command here:
2385         Return the saved command line, if any; error out if there's no
2386         command to relaunch.
2387
2388 2019-07-03  Pedro Alves  <palves@redhat.com>
2389
2390         * NEWS (New commands): Mention "maint set/show test-settings"
2391         instead of "maint test-settings".
2392         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2393         (maintenance_test_settings_set_list): Rename to ...
2394         (maintenance_set_test_settings_list): ... this.
2395         (maintenance_test_settings_show_list): Rename to  ...
2396         (maintenance_show_test_settings_list): ... this.
2397         (maintenance_test_settings_cmd): Delete.
2398         (maintenance_test_settings_set_cmd): ...
2399         (maintenance_set_test_settings_cmd): ... this.
2400         (maintenance_test_settings_show_cmd): ...
2401         (maintenance_show_test_settings_cmd): ... this.
2402         (maintenance_test_settings_show_value_cmd):
2403         (maintenance_show_test_settings_value_cmd): ... this.
2404         (_initialize_maint_test_settings): No longer install the "maint
2405         test-settings" prefix command.  Rename "maint test-settings set"
2406         to "maint set test-settings", and "maint test-settings show" to
2407         "maint show test-settings".  Adjust all subcommands.
2408
2409 2019-07-03  Pedro Alves  <palves@redhat.com>
2410
2411         * maint-test-settings.c: Fix file's intro comment.  Replace all
2412         references to "test-options" with references to "test-settings",
2413         in comments.
2414
2415 2019-07-03  Pedro Alves  <palves@redhat.com>
2416
2417         * maint-test-settings.c (maintenance_test_settings_xxx)
2418         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2419         New.
2420         (maintenance_test_settings_enums): Use them.
2421         (maintenance_test_settings_enum): Default to
2422         maintenance_test_settings_xxx.
2423         (_initialize_maint_test_settings): Initialize
2424         MAINTENANCE_TEST_SETTINGS_FILENAME.
2425
2426 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2427
2428         * breakpoint.h (remove_breakpoints_inf): Change return type to
2429         void, move function documentation here.
2430         * breakpoint.c (remove_breakpoints_inf): Change return type to
2431         void, move function documentation to header.
2432
2433 2019-07-02  Pedro Alves  <palves@redhat.com>
2434
2435         * NEWS (Completion improvements): Mention "info threads".
2436         * thread.c (struct info_threads_opts, info_threads_option_defs)
2437         (make_info_threads_options_def_group): New.
2438         (info_threads_command): Use gdb::option::process_options.
2439         (info_threads_command_completer): New.
2440         (_initialize_thread): Use gdb::option::build_help to build the
2441         help text for "info threads".
2442
2443 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2444
2445         * defs.h (generic_load): Move from here...
2446         * symfile.h (generic_load): ... to here.  Rename name parameter
2447         to args.
2448         * symfile.c (generic_load): Add comment.
2449
2450 2019-07-01  Tom Tromey  <tromey@adacore.com>
2451
2452         * dwarf2read.c
2453         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2454         declaration of without_params.  Fix formatting.
2455
2456 2019-07-01  Tom Tromey  <tromey@adacore.com>
2457
2458         * ada-exp.y (find_primitive_type): Update.
2459         * ada-lang.h (ada_lookup_symbol): Update.
2460         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2461         parameter.
2462         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2463
2464 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2465
2466         PR breakpoints/24541
2467         * gdbarch.c: Regenerate.
2468         * gdbarch.h: Regenerate.
2469         * gdbarch.sh: Add 'stap_adjust_register'.
2470         * i386-tdep.c: Include '<unordered_set>'.
2471         (i386_stap_adjust_register): New function.
2472         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2473         * stap-probe.c (stap_parse_register_operand): Call
2474         'gdbarch_stap_adjust_register'.
2475
2476 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2477
2478         PR python/24742
2479         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2480         * python/python.c (do_start_initialization): Use 'xmalloc'
2481         instead of 'PyMem_Malloc'.
2482
2483 2019-06-28  Tom Tromey  <tromey@adacore.com>
2484
2485         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2486         for Ada.
2487
2488 2019-06-27  Tom Tromey  <tromey@adacore.com>
2489
2490         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2491         objfile_key.
2492         (arm_find_mapping_symbol, arm_record_special_symbol)
2493         (_initialize_arm_tdep): Update.
2494         (arm_objfile_data_free): Remove.
2495
2496 2019-06-27  Tom Tromey  <tromey@adacore.com>
2497
2498         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2499         to cp_print_static_field.
2500
2501 2019-06-26  Tom Tromey  <tromey@adacore.com>
2502
2503         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2504         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2505         declare.
2506
2507 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2508
2509         * features/aarch64-core.c (create_feature_aarch64_core):
2510         Regenerate.
2511         * features/aarch64-core.xml: Add cpsr flags.
2512
2513 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2514
2515         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2516         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2517
2518 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2519
2520         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2521         field.
2522         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2523         use.
2524         (arm_record_special_symbol): Don't insert new symbol in sorted
2525         position, push it at the end.
2526
2527 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2528
2529         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2530         (arm_mapping_symbol_s): Remove.
2531         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2532         (arm_mapping_symbol_vec): New typedef.
2533         (struct arm_per_objfile): Add constructor.
2534         <section_maps>: Change type to
2535         std::unique_ptr<arm_mapping_symbol_vec[]>.
2536         (arm_compare_mapping_symbols): Remove.
2537         (arm_find_mapping_symbol): Adjust to section_maps type change.
2538         (arm_objfile_data_free): Call delete on arm_per_objfile.
2539         (arm_record_special_symbol): Adjust to section_maps type change.
2540         Allocate arm_per_objfile with new.
2541
2542 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2543
2544         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2545         with the command prefix.
2546
2547 2019-06-25  Tom Tromey  <tom@tromey.com>
2548
2549         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2550         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2551
2552 2019-06-25  Tom Tromey  <tom@tromey.com>
2553
2554         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2555         type.
2556         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2557         protected.
2558
2559 2019-06-25  Tom Tromey  <tom@tromey.com>
2560
2561         * tui/tui-winsource.c
2562         (tui_source_window_base::set_is_exec_point_at): Add check against
2563         LOA_ADDRESS.
2564
2565 2019-06-25  Tom Tromey  <tom@tromey.com>
2566
2567         * tui/tui-source.c (tui_set_source_content): Don't check before
2568         xfree.
2569         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2570
2571 2019-06-25  Tom Tromey  <tom@tromey.com>
2572
2573         * tui/tui-winsource.h (tui_update_source_window_as_is)
2574         (tui_alloc_source_buffer, tui_line_is_displayed)
2575         (tui_addr_is_displayed): Change type of win_info.
2576         * tui/tui-winsource.c (tui_update_source_window_as_is)
2577         (tui_clear_source_content, tui_show_source_line)
2578         (tui_show_source_content, tui_source_window_base::refill)
2579         (tui_source_window_base::set_is_exec_point_at)
2580         (tui_source_window_base::set_is_exec_point_at)
2581         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2582         (tui_alloc_source_buffer, tui_line_is_displayed)
2583         (tui_addr_is_displayed): Change type of win_info.  Update.
2584         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2585         (tui_source_window_base::do_make_visible_with_new_height):
2586         Update.
2587         * tui/tui-source.c (tui_set_source_content)
2588         (tui_set_source_content_nil)
2589         (tui_source_window::do_scroll_vertical): Update.
2590         * tui/tui-layout.c (show_layout): Update.
2591         * tui/tui-disasm.c (tui_set_disassem_content)
2592         (tui_disasm_window::do_scroll_vertical): Update.
2593         * tui/tui-data.h (tui_win_content): Remove.
2594         (struct tui_gen_win_info) <content, content_size>: Remove.
2595         (struct tui_source_element): Add initializers and destructor.
2596         (union tui_which_element, struct tui_win_element): Remove.
2597         (struct tui_source_window_base) <content>: New field.
2598         (struct tui_data_window): Remove destructor.
2599         (tui_alloc_content, tui_free_win_content)
2600         (tui_free_all_source_wins_content): Don't declare.
2601         * tui/tui-data.c (tui_initialize_static_data): Update.
2602         (init_content_element, tui_alloc_content): Remove.
2603         (~tui_gen_win_info): Update.
2604         (~tui_data_window, tui_free_all_source_wins_content)
2605         (tui_free_win_content, free_content, free_content_elements):
2606         Remove.
2607
2608 2019-06-25  Tom Tromey  <tom@tromey.com>
2609
2610         * tui/tui-winsource.h (tui_clear_source_content)
2611         (tui_erase_source_content, tui_show_source_content): Change type
2612         of win_info.
2613         * tui/tui-winsource.c (tui_clear_source_content)
2614         (tui_erase_source_content, tui_show_source_content): Change type
2615         of win_info.
2616         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2617         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2618         win_info.
2619         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2620         win_info.
2621         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2622
2623 2019-06-25  Tom Tromey  <tom@tromey.com>
2624
2625         * tui/tui-winsource.c (tui_clear_source_content)
2626         (tui_source_window_base::set_is_exec_point_at): Update.
2627         * tui/tui-source.c (tui_set_source_content_nil): Update.
2628         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2629         a bool.
2630         * tui/tui-data.c (init_content_element): Update.
2631
2632 2019-06-25  Tom Tromey  <tom@tromey.com>
2633
2634         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2635         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2636         * tui/tui-layout.c (init_and_make_win): Update.
2637         * tui/tui.h (enum tui_win_type): Update.
2638         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2639         tui_win_is_auxillary.
2640         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2641         tui_win_is_auxillary.
2642
2643 2019-06-25  Tom Tromey  <tom@tromey.com>
2644
2645         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2646         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2647         (tui_delete_data_content_windows, tui_display_all_data)
2648         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2649         Update.
2650         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2651         * tui/tui-regs.c (tui_last_regs_line_no)
2652         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2653         (tui_show_registers): Update.
2654         (tui_show_register_group): Return void.  Update.
2655         (tui_display_registers_from, tui_display_reg_element_at_line)
2656         (tui_display_registers_from_line, tui_check_register_values):
2657         Update.
2658         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2659         member.
2660         (struct tui_data_window) <regs_content>: Now a std::vector.
2661         <regs_content_count>: Remove.
2662         (tui_add_content_elements, tui_free_data_content): Don't declare.
2663         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2664         (init_content_element): Remove DATA_WIN case.  Add assert.
2665         (tui_add_content_elements): Remove.
2666         (tui_data_window): Update.
2667         (tui_free_data_content): Remove.
2668         (free_content_elements): Remove DATA_WIN case.
2669
2670 2019-06-25  Tom Tromey  <tom@tromey.com>
2671
2672         * tui/tui-data.c (tui_data_item_window): Update.
2673         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2674         * tui/tui-windata.c (tui_display_all_data)
2675         (tui_display_data_from_line): Update.
2676         (tui_check_data_values): Remove.
2677         * tui/tui-regs.c (tui_show_register_group)
2678         (tui_display_reg_element_at_line): Update.
2679         * tui/tui-hooks.c (tui_register_changed)
2680         (tui_refresh_frame_and_register_information): Call
2681         tui_check_register_values.
2682         * tui/tui-data.h (struct tui_data_window) <data_content,
2683         data_content_count, data_type>: Remove.
2684         (enum tui_data_type): Remove.
2685
2686         * tui/tui-data.c (tui_data_window::clear_detail)
2687         (~tui_data_window): Update.
2688
2689 2019-06-25  Tom Tromey  <tom@tromey.com>
2690
2691         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2692         declare.
2693         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2694         Rename from tui_first_data_item_displayed.  Update.
2695         (tui_data_window::refresh_all)
2696         (tui_data_window::do_scroll_vertical): Update.
2697         * tui/tui-data.h (struct tui_data_window)
2698         <first_data_item_displayed>: Declare new method.
2699
2700 2019-06-25  Tom Tromey  <tom@tromey.com>
2701
2702         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2703         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2704         contents...
2705         (tui_initialize_static_data): ...here.
2706
2707 2019-06-25  Tom Tromey  <tom@tromey.com>
2708
2709         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2710         (tui_display_registers_from, tui_check_register_values): Update.
2711         (tui_display_register): Remove win_info parameter; update.
2712         (tui_get_register): Change type of parameters.
2713         * tui/tui-data.h (struct tui_data_element): Remove.
2714         (union tui_which_element) <data>: Remove.
2715         <data_window>: Change type.
2716         (struct tui_data_item_window): New.
2717         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2718         case.  Add assert.
2719         (~tui_data_item_window): New destructor.
2720         (free_content_elements): Remove DATA_ITEM_WIN case.
2721
2722 2019-06-25  Tom Tromey  <tom@tromey.com>
2723
2724         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2725         Remove.
2726
2727 2019-06-25  Tom Tromey  <tom@tromey.com>
2728
2729         * tui/tui-data.h (struct tui_command_element): Remove.
2730         (union tui_which_element) <command>: Remove.
2731         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2732         assert.
2733         (free_content_elements): Remove CMD_WIN case.
2734
2735 2019-06-25  Tom Tromey  <tom@tromey.com>
2736
2737         * tui/tui-layout.c (tui_set_layout): Update.
2738         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2739         * tui/tui-data.c (layout_def): Update.
2740
2741 2019-06-25  Tom Tromey  <tom@tromey.com>
2742
2743         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2744         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2745         (tui_source_window_base::set_new_height): Update.
2746         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2747         Update.
2748         (tui_set_locator_fullname, tui_set_locator_info)
2749         (tui_show_frame_info): Update.
2750         * tui/tui-source.c (tui_set_source_content)
2751         (tui_source_is_displayed): Update.
2752         * tui/tui-layout.c (show_source_disasm_command, show_data)
2753         (show_source_or_disasm_and_command): Update.
2754         * tui/tui-disasm.c (tui_set_disassem_content)
2755         (tui_get_begin_asm_address): Update.
2756         * tui/tui-data.h (struct tui_locator_element): Remove.
2757         (union tui_which_element) <locator>: Remove.
2758         (struct tui_locator_window): New.
2759         (tui_locator_win_info_ptr): Change return type.
2760         * tui/tui-data.c (_locator): Change type.
2761         (tui_locator_win_info_ptr): Change return type.
2762         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2763         (tui_alloc_content): Add assert.
2764
2765 2019-06-25  Tom Tromey  <tom@tromey.com>
2766
2767         * tui/tui-winsource.c
2768         (tui_exec_info_window::maybe_allocate_content): New method.
2769         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2770         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2771         (make_source_or_disasm_window): Add cast.
2772         * tui/tui-data.h (union tui_which_element) <simple_string>:
2773         Remove.
2774         (struct tui_source_info): New.
2775         (struct tui_source_window_base) <execution_info>: Change type.
2776         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2777         case, and add assert.
2778         (tui_alloc_content): Add assert.
2779
2780 2019-06-25  Tom Tromey  <tom@tromey.com>
2781
2782         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2783         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2784         * tui/tui-data.c (tui_alloc_win_info): Remove.
2785
2786 2019-06-25  Tom Tromey  <tom@tromey.com>
2787
2788         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2789         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2790         can_highlight.
2791
2792 2019-06-25  Tom Tromey  <tom@tromey.com>
2793
2794         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2795         make_visible_with_new_height method.
2796         (tui_win_info::make_visible_with_new_height): New method.
2797         (tui_source_window_base::do_make_visible_with_new_height)
2798         (tui_data_window::do_make_visible_with_new_height)
2799         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2800         (make_visible_with_new_height): Remove.
2801         (tui_resize_all, tui_adjust_win_heights): Use
2802         make_visible_with_new_height method.
2803         * tui/tui-data.h (struct tui_win_info)
2804         <do_make_visible_with_new_height, make_visible_with_new_height>:
2805         New methods.
2806         (struct tui_source_window_base, struct tui_data_window)
2807         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2808         methods.
2809
2810 2019-06-25  Tom Tromey  <tom@tromey.com>
2811
2812         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2813         method.
2814         (update_tab_width): Call update_tab_width method.
2815         * tui/tui-data.h (struct tui_win_info)
2816         (struct tui_source_window_base) <update_tab_width>: New methods.
2817
2818 2019-06-25  Tom Tromey  <tom@tromey.com>
2819
2820         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2821         parameter.
2822         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2823         parameter.
2824         (tui_gen_win_info::make_visible): Update.
2825         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2826         parameter.
2827         * tui/tui-data.h (enum tui_box): New enum.
2828         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2829
2830 2019-06-25  Tom Tromey  <tom@tromey.com>
2831
2832         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2833         init_and_make_win for EXEC_INFO_WIN.
2834         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2835         longer inline.
2836         (struct tui_win_info) <~tui_win_info>: Inline.
2837         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2838         Don't declare.
2839         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2840         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2841         Remove.
2842         (tui_initialize_static_data): Update.
2843         (~tui_gen_win_info): Handle more cleanup here.
2844         (~tui_source_window_base): Delete "execution_info".
2845         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2846
2847 2019-06-25  Tom Tromey  <tom@tromey.com>
2848
2849         * tui/tui-layout.c (make_command_window): Don't set
2850         can_highlight.
2851         (show_source_disasm_command): Call the reset method.
2852         (show_data): Don't set can_highlight.  Call the reset method.
2853         (tui_gen_win_info::reset): Rename from init_gen_win_info
2854         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2855         (show_source_or_disasm_and_command): Call the reset method.
2856         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2857         (struct tui_cmd_window): Set can_highlight.
2858
2859 2019-06-25  Tom Tromey  <tom@tromey.com>
2860
2861         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2862         from make_visible.
2863         (tui_make_visible, tui_make_invisible): Rewrite.
2864         (tui_win_info::make_visible): Remove.
2865         (tui_source_window_base::make_visible): Update.
2866         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2867         method.  Moved from...
2868         (struct tui_win_info) <make_visible>: ...here.
2869
2870 2019-06-25  Tom Tromey  <tom@tromey.com>
2871
2872         * tui/tui-winsource.c
2873         (tui_source_window_base::do_scroll_horizontal): Remove direction
2874         parameter.
2875         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2876         direction parameter.
2877         * tui/tui-win.c (tui_win_info::forward_scroll)
2878         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2879         (tui_win_info::right_scroll): Update.
2880         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2881         direction parameter.
2882         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2883         direction parameter.
2884         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2885         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2886         Remove direction parameter.
2887         (struct tui_source_window_base, struct tui_source_window)
2888         (struct tui_disasm_window, struct tui_data_window)
2889         (struct tui_cmd_window): Update.
2890
2891 2019-06-25  Tom Tromey  <tom@tromey.com>
2892
2893         * tui/tui-winsource.h (tui_set_exec_info_content)
2894         (tui_show_exec_info_content, tui_erase_exec_info_content)
2895         (tui_clear_exec_info_content, tui_update_exec_info): Change
2896         argument to tui_source_window_base.
2897         * tui/tui-winsource.c (tui_set_exec_info_content)
2898         (tui_show_exec_info_content, tui_erase_exec_info_content)
2899         (tui_clear_exec_info_content, tui_update_exec_info): Change
2900         argument to tui_source_window_base.
2901
2902 2019-06-25  Tom Tromey  <tom@tromey.com>
2903
2904         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2905         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2906
2907 2019-06-25  Tom Tromey  <tom@tromey.com>
2908
2909         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2910         check.
2911
2912 2019-06-25  Tom Tromey  <tom@tromey.com>
2913
2914         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2915         type to void.
2916         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2917         type to void.
2918         * tui/tui-source.c (tui_set_source_content): Update.
2919         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2920
2921 2019-06-25  Tom Tromey  <tom@tromey.com>
2922
2923         * tui/tui-win.c (window_name_completer, tui_set_focus)
2924         (tui_all_windows_info): Use name method.
2925         * tui/tui-data.h (struct tui_gen_win_info)
2926         (struct tui_source_window, struct tui_disasm_window)
2927         (struct tui_data_window, struct tui_cmd_window) <name>: New
2928         method.
2929         (tui_win_name): Don't declare.
2930         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2931         (tui_win_name): Remove.
2932
2933 2019-06-25  Tom Tromey  <tom@tromey.com>
2934
2935         * tui/tui-winsource.h (tui_update_source_window)
2936         (tui_update_source_window_as_is): Change parameter type.
2937         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2938         to be a tui_source_window_base.
2939         (tui_update_source_window_as_is): Likewise.
2940         * tui/tui-win.c (make_visible_with_new_height): Update.
2941
2942 2019-06-25  Tom Tromey  <tom@tromey.com>
2943
2944         * tui/tui-winsource.c (tui_erase_source_content)
2945         (tui_show_source_content, tui_show_exec_info_content)
2946         (tui_erase_exec_info_content): Use refresh_window method.
2947         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2948         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2949         from tui_refresh_win.
2950         (tui_data_window::refresh_window): New method.
2951         (tui_win_info::refresh, tui_source_window_base::refresh)
2952         (tui_refresh_all): Use refresh_window method.
2953         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2954         method.
2955         * tui/tui-regs.c (tui_display_register): Call refresh_window
2956         method.
2957         * tui/tui-layout.c (show_source_disasm_command)
2958         (show_source_or_disasm_and_command): Call refresh_window method.
2959         * tui/tui-data.h (struct tui_gen_win_info)
2960         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2961         New method.
2962
2963 2019-06-25  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui.c (tui_rl_other_window, tui_enable)
2966         (tui_is_window_visible, tui_get_command_dimension): Update.
2967         * tui/tui-winsource.c (tui_update_source_window_as_is)
2968         (tui_clear_source_content, tui_erase_source_content)
2969         (tui_show_source_line, tui_source_window_base::refill)
2970         (tui_source_window_base::do_scroll_horizontal)
2971         (tui_source_window_base::set_is_exec_point_at)
2972         (tui_update_breakpoint_info, tui_set_exec_info_content)
2973         (tui_alloc_source_buffer, tui_line_is_displayed)
2974         (tui_addr_is_displayed): Update.
2975         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2976         (tui_check_and_display_highlight_if_needed)
2977         (tui_win_info::make_visible, tui_win_info::refresh)
2978         (tui_refresh_all): Update.
2979         * tui/tui-windata.c (tui_first_data_item_displayed)
2980         (tui_delete_data_content_windows, tui_erase_data_content)
2981         (tui_display_all_data, tui_data_window::refresh_all)
2982         (tui_check_data_values): Update.
2983         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2984         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2985         (tui_win_info::backward_scroll, tui_refresh_all_win)
2986         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2987         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2988         (tui_source_window_base::set_new_height)
2989         (tui_data_window::set_new_height)
2990         (make_invisible_and_set_new_height)
2991         (make_visible_with_new_height, new_height_ok)
2992         (parse_scrolling_args): Update.
2993         * tui/tui-stack.c (tui_show_frame_info): Update.
2994         * tui/tui-source.c (tui_set_source_content)
2995         (tui_set_source_content_nil, tui_source_is_displayed)
2996         (tui_source_window::do_scroll_vertical): Update.
2997         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2998         (tui_display_registers_from, tui_display_reg_element_at_line)
2999         (tui_check_register_values, tui_reg_command): Update.
3000         * tui/tui-layout.c (tui_default_win_height)
3001         (show_source_disasm_command, show_data, init_and_make_win)
3002         (show_source_or_disasm_and_command): Update.
3003         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3004         (tui_redisplay_readline, tui_mld_flush)
3005         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3006         (tui_getc): Update.
3007         * tui/tui-disasm.c (tui_set_disassem_content)
3008         (tui_disasm_window::do_scroll_vertical): Update.
3009         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3010         Now virtual.
3011         (struct tui_win_info): Derive from tui_gen_win_info.
3012         <~tui_win_info>: Mark as override.
3013         <generic>: Remove member.
3014         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3015         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3016         (~tui_data_window, ~tui_win_info)
3017         (tui_free_all_source_wins_content): Update.
3018         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3019
3020 2019-06-25  Tom Tromey  <tom@tromey.com>
3021
3022         * tui/tui-layout.c (init_and_make_win): Use new.
3023         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3024         destructor, initializers.
3025         (tui_alloc_generic_win_info): Don't declare.
3026         * tui/tui-data.c (_locator): Add argument to constructor.
3027         (source_win, disasm_win): New globals.
3028         (exec_info): Remove.
3029         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3030         Update.
3031         (tui_alloc_generic_win_info): Remove.
3032         (init_content_element): Use new.
3033         (tui_win_info::tui_win_info): Update.
3034         (free_content_elements) <case DATA_WIN>: Use delete.
3035
3036 2019-06-25  Tom Tromey  <tom@tromey.com>
3037
3038         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3039         * tui/tui-windata.c (tui_first_data_item_displayed)
3040         (tui_delete_data_content_windows): Update.
3041         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3042         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3043         (tui_display_registers_from, tui_check_register_values): Update.
3044         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3045         pointer.
3046         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3047         window.
3048         (tui_free_data_content): Update.
3049         (free_content_elements) <case DATA_WIN>: Free the window.
3050
3051 2019-06-25  Tom Tromey  <tom@tromey.com>
3052
3053         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3054         Update.
3055         * tui/tui-layout.c (make_command_window)
3056         (show_source_disasm_command, show_data, init_and_make_win)
3057         (show_source_or_disasm_and_command): Update.
3058         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3059         method.
3060         <can_highight, is_highlighted>: Now bool.
3061         (tui_set_win_highlight): Don't declare.
3062         * tui/tui-data.c (tui_set_win_highlight): Remove.
3063
3064 2019-06-25  Tom Tromey  <tom@tromey.com>
3065
3066         * tui/tui-wingeneral.c (make_visible): Remove check of window
3067         type.
3068
3069 2019-06-25  Tom Tromey  <tom@tromey.com>
3070
3071         * tui/tui-win.c (tui_win_info::max_height)
3072         (tui_cmd_window::max_height): New methods.
3073         (new_height_ok): Call max_height.
3074         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3075         <max_height>: New method.
3076
3077 2019-06-25  Tom Tromey  <tom@tromey.com>
3078
3079         * tui/tui-win.c (tui_source_window_base::set_new_height)
3080         (tui_data_window::set_new_height): New methods.
3081         (make_invisible_and_set_new_height): Call set_new_height method.
3082         * tui/tui-data.h (struct tui_win_info)
3083         (struct tui_source_window_base, struct tui_data_window)
3084         <set_new_height>: New method.
3085
3086 2019-06-25  Tom Tromey  <tom@tromey.com>
3087
3088         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3089         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3090         tui_refresh_data_win.
3091         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3092         method.
3093         (tui_refresh_all_win): Call the refresh_all method.
3094         (tui_set_focus): Likewise.
3095         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3096         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3097         Likewise.
3098
3099 2019-06-25  Tom Tromey  <tom@tromey.com>
3100
3101         * tui/tui-winsource.h (tui_refill_source_window)
3102         (tui_set_is_exec_point_at): Don't declare.
3103         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3104         (tui_source_window_base::refill): Rename from
3105         tui_refill_source_window.
3106         (tui_source_window_base::do_scroll_horizontal): Update.
3107         (tui_source_window_base::set_is_exec_point_at): Rename from
3108         tui_set_is_exec_point_at.
3109         (tui_update_all_breakpoint_info): Update.
3110         * tui/tui-stack.c (tui_show_frame_info): Update.
3111         * tui/tui-layout.c (show_data): Add cast.
3112         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3113         * tui/tui-data.h (struct tui_source_window_base) <refill,
3114         set_is_exec_point_at>: New methods.
3115         (tui_source_windows, tui_add_to_source_windows): Update types.
3116         (tui_add_to_source_windows): Remove redundant declaration.
3117         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3118         (tui_source_windows): Change return type.
3119         (tui_clear_source_windows_detail): Update.
3120         (tui_add_to_source_windows): Change type of parameter.
3121         (tui_free_all_source_wins_content): Update.
3122
3123 2019-06-25  Tom Tromey  <tom@tromey.com>
3124
3125         * tui/tui-wingeneral.c (tui_win_info::refresh)
3126         (tui_source_window_base::refresh): New methods.
3127         (tui_refresh_all): Call the refresh method.
3128         * tui/tui-data.h (struct tui_win_info)
3129         (struct tui_source_window_base) <refresh>: New method.
3130
3131 2019-06-25  Tom Tromey  <tom@tromey.com>
3132
3133         * tui/tui.h (tui_is_window_visible): Return bool.
3134         * tui/tui.c (tui_is_window_visible): Return bool.
3135         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3136         (tui_make_visible, tui_make_invisible)
3137         (tui_win_info::make_visible)
3138         (tui_source_window_base::make_visible, make_all_visible)
3139         (tui_make_all_visible, tui_make_all_invisible): Update.
3140         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3141         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3142         bool.
3143         (struct tui_win_info, struct tui_source_window_base)
3144         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3145         * tui/tui-data.c (tui_init_generic_part): Update.
3146
3147 2019-06-25  Tom Tromey  <tom@tromey.com>
3148
3149         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3150         (tui_source_window_base::make_visible): New methods.
3151         (make_all_visible): Make method call.
3152         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3153         (struct tui_source_window_base, struct tui_cmd_window): Override
3154         make_visible.
3155         (tui_win_is_source_type): Don't declare.
3156         * tui/tui-data.c (tui_win_is_source_type): Remove.
3157
3158 2019-06-25  Tom Tromey  <tom@tromey.com>
3159
3160         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3161         NULL check.
3162
3163 2019-06-25  Tom Tromey  <tom@tromey.com>
3164
3165         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3166         Inline constructor.  Add initializers for members.
3167         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3168         constructors; now inline in class.
3169
3170 2019-06-25  Tom Tromey  <tom@tromey.com>
3171
3172         * tui/tui-regs.c (tui_show_registers): Update.
3173         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3174         bool.
3175         * tui/tui-data.c (tui_data_window::clear_detail)
3176         (tui_data_window): Update.
3177
3178 2019-06-25  Tom Tromey  <tom@tromey.com>
3179
3180         * tui/tui-windata.c (tui_display_all_data)
3181         (tui_display_data_from_line, tui_display_data_from)
3182         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3183         Update.
3184         * tui/tui-regs.c (tui_last_regs_line_no)
3185         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3186         (tui_show_registers, tui_show_register_group)
3187         (tui_display_registers_from, tui_display_reg_element_at_line)
3188         (tui_display_registers_from_line, tui_check_register_values)
3189         (tui_reg_next, tui_reg_prev): Update.
3190         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3191         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3192         tui_data_window.
3193         (struct tui_win_info) <detail>: Remove.  Add new fields from
3194         tui_data_info.
3195         (TUI_DATA_WIN): Add cast.
3196         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3197         (~tui_data_window): Simplify.
3198
3199 2019-06-25  Tom Tromey  <tom@tromey.com>
3200
3201         * tui/tui-layout.c (show_source_disasm_command)
3202         (show_source_or_disasm_and_command): Update.
3203         * tui/tui-io.c (update_cmdwin_start_line)
3204         (tui_redisplay_readline): Update.
3205         * tui/tui-data.h (struct tui_command_info): Remove.
3206         (struct tui_win_info) <detail>: Remove command_info member.
3207         (struct tui_data_window) <start_line>: New member, from
3208         tui_command_info.
3209         (TUI_CMD_WIN): Add casts.
3210
3211 2019-06-25  Tom Tromey  <tom@tromey.com>
3212
3213         * tui/tui-winsource.c (tui_update_source_window)
3214         (tui_refill_source_window)
3215         (tui_source_window_base::do_scroll_horizontal)
3216         (tui_update_breakpoint_info, tui_set_exec_info_content)
3217         (tui_show_exec_info_content, tui_erase_exec_info_content)
3218         (tui_clear_exec_info_content): Update.
3219         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3220         Update.
3221         * tui/tui-win.c (make_invisible_and_set_new_height)
3222         (make_visible_with_new_height): Update.
3223         * tui/tui-source.c (tui_set_source_content)
3224         (tui_show_symtab_source): Update.
3225         * tui/tui-layout.c (extract_display_start_addr)
3226         (show_source_disasm_command, show_data)
3227         (make_source_or_disasm_window)
3228         (show_source_or_disasm_and_command): Update.
3229         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3230         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3231         "gdbarch".
3232         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3233         to tui_source_window_base.
3234         (struct tui_win_info) <detail>: Remove source_info member.
3235         (struct tui_source_window_base) <has_locator>: Inline.
3236         Move contents from tui_source_info; rename has_locator member to
3237         m_has_locator.
3238         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3239         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3240         header file.
3241         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3242         Simplify.
3243         (tui_free_all_source_wins_content): Cast to
3244         tui_source_window_base.
3245
3246 2019-06-25  Tom Tromey  <tom@tromey.com>
3247
3248         * tui/tui-win.c (make_invisible_and_set_new_height)
3249         (make_visible_with_new_height): Call has_locator method.
3250         * tui/tui-layout.c (show_source_disasm_command, show_data)
3251         (show_source_or_disasm_and_command): Update for bool change.
3252         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3253         (tui_win_info) <has_locator>: New method.
3254         (struct tui_source_window_base) <has_locator>: New method.
3255         (tui_win_has_locator): Don't declare.
3256         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3257         from tui_win_has_locator.
3258         (tui_source_window_base): Use false, not FALSE.
3259
3260 2019-06-25  Tom Tromey  <tom@tromey.com>
3261
3262         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3263         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3264         clear_detail method directly.
3265         (tui_clear_win_detail): Remove.
3266
3267 2019-06-25  Tom Tromey  <tom@tromey.com>
3268
3269         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3270         "this", not TUI_DISASM_WIN.
3271
3272 2019-06-25  Tom Tromey  <tom@tromey.com>
3273
3274         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3275         declare.
3276         * tui/tui-winsource.c
3277         (tui_source_window_base::do_scroll_horizontal): Rename from
3278         tui_horizontal_source_scroll.
3279         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3280         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3281         from tui_vertical_data_scroll.
3282         * tui/tui-win.h (tui_scroll): Don't declare.
3283         * tui/tui-win.c (tui_win_info::forward_scroll)
3284         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3285         (tui_win_info::right_scroll): Rename and update.
3286         (tui_scroll_forward_command, tui_scroll_backward_command)
3287         (tui_scroll_left_command, tui_scroll_right_command): Update.
3288         (tui_scroll): Remove.
3289         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3290         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3291         from tui_vertical_source_scroll.
3292         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3293         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3294         from tui_vertical_disassem_scroll.
3295         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3296         do_scroll_horizontal>: New methods.
3297         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3298         Likewise.
3299         (struct tui_source_window_base): Add do_scroll_horizontal.
3300         (struct tui_source_window, struct tui_disasm_window): Add
3301         do_scroll_vertical.
3302         (struct tui_data_window, struct tui_cmd_window): Add
3303         do_scroll_horizontal and do_scroll_vertical.
3304         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3305
3306 2019-06-25  Tom Tromey  <tom@tromey.com>
3307
3308         * tui/tui-data.h (struct tui_source_window_base): New struct.
3309         (struct tui_source_window): Derive from tui_source_window_base.
3310         (struct tui_disasm_window): New struct.
3311         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3312         from tui_source_window::clear_detail.
3313         (tui_source_window_base): Rename from tui_source_window.
3314         (~tui_source_window_base): Rename from ~tui_source_window.
3315         (tui_alloc_win_info): Create a tui_disasm_window.
3316
3317 2019-06-25  Tom Tromey  <tom@tromey.com>
3318
3319         * tui/tui-data.h (struct tui_source_window)
3320         (struct tui_data_window): Declare destructors.
3321         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3322         destructors.
3323         (tui_win_info): Simplify.
3324
3325 2019-06-25  Tom Tromey  <tom@tromey.com>
3326
3327         * tui/tui-winsource.c (tui_display_main)
3328         (tui_update_source_windows_with_addr)
3329         (tui_update_all_breakpoint_info): Update.
3330         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3331         (new_height_ok, parse_scrolling_args): Update.
3332         * tui/tui-stack.c (tui_show_frame_info): Update.
3333         * tui/tui-data.h (struct tui_list): Remove.
3334         (tui_source_windows): Return a reference to a std::vector.
3335         * tui/tui-data.c (source_windows): Now a std::vector.
3336         (tui_source_windows): Change return type.
3337         (tui_clear_source_windows): Rewrite.
3338         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3339         (tui_free_all_source_wins_content): Rewrite.
3340
3341 2019-06-25  Tom Tromey  <tom@tromey.com>
3342
3343         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3344         (struct tui_data_window, struct tui_cmd_window): Declare
3345         clear_detail method.
3346         * tui/tui-data.c (tui_source_window::clear_detail)
3347         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3348         methods.
3349         (tui_clear_win_detail): Simplify.
3350
3351 2019-06-25  Tom Tromey  <tom@tromey.com>
3352
3353         * tui/tui-layout.c (make_source_window, make_disasm_window)
3354         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3355         Return the new window.
3356         (show_source_disasm_command, show_data)
3357         (show_source_or_disasm_and_command): Update.
3358
3359 2019-06-25  Tom Tromey  <tom@tromey.com>
3360
3361         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3362         parameter.  Return the new window.
3363         (show_source_disasm_command): Update and remove NULL check.
3364         (show_source_or_disasm_and_command): Update.
3365
3366 2019-06-25  Tom Tromey  <tom@tromey.com>
3367
3368         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3369
3370 2019-06-25  Tom Tromey  <tom@tromey.com>
3371
3372         * tui/tui-data.h (struct tui_win_info): Make constructor
3373         protected.  Make destructor virtual.  Add initializers.
3374         (tui_source_window, tui_data_window, tui_cmd_window): New
3375         classes.
3376         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3377         constructor.  Add "type" parameter.
3378         (tui_source_window, tui_data_window, tui_cmd_window): New
3379         constructors.
3380         (tui_alloc_win_info): Instantiate the appropriate subclass.
3381
3382 2019-06-25  Tom Tromey  <tom@tromey.com>
3383
3384         * tui/tui-win.c (tui_resize_all): Use delete.
3385         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3386         destructor.
3387         (tui_free_window): Don't declare.
3388         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3389         Update.
3390
3391 2019-06-25  Tom Tromey  <tom@tromey.com>
3392
3393         * tui/tui-data.h (struct tui_win_info): Add constructor.
3394         * tui/tui-data.c (tui_alloc_win_info): Use new.
3395         (tui_free_window): Use delete.
3396
3397 2019-06-22  Tom Tromey  <tom@tromey.com>
3398
3399         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3400         declare.
3401         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3402
3403 2019-06-22  Tom Tromey  <tom@tromey.com>
3404
3405         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3406         declare.
3407         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3408
3409 2019-06-22  Tom de Vries  <tdevries@suse.de>
3410
3411         * dwarf2read.c (create_addrmap_from_aranges)
3412         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3413         instead of '%zu'.
3414
3415 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3416
3417         * dwarf2read.h (dwarf2_section_info_def): Remove.
3418         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3419         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3420         std::vector<dwarf2_section_info>.
3421         (struct dwo_file) <~dwo_file>: Remove.
3422         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3423         types field.
3424         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3425         (dwarf2_read_debug_names): Likewise.
3426         (create_debug_types_hash_table): Change parameter type to
3427         array_view, adjust code accordingly.
3428         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3429         (partial_die_info::fixup): Likewise.
3430         (determine_prefix): Likewise.
3431         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3432
3433 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3434
3435         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3436         gdb_bfd_ref_ptr.
3437         <~dwo_file>: Remove call to gdb_bfd_unref.
3438         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3439         gdb_bfd_ref_ptr::get.
3440
3441 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3442
3443         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3444         type to htab_up.
3445         * dwarf2read.c (struct dwo_file): Initialize fields.
3446         <~dwo_file>: New.
3447         (free_dwo_file): Remove, move content to ~dwo_file.
3448         (struct dwo_file_deleter): Remove.
3449         (dwo_file_up>: Remove custom deleter.
3450         (free_dwo_files): Remove.
3451         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3452         dwo_files.
3453         (process_skeletonless_type_units): Call unique_ptr::get.
3454         (allocate_dwo_file_hash_table): Add deleter to created hash
3455         table.  Change return type to htab_up.
3456         (lookup_dwo_file_slot): Don't memset dwo_file, call
3457         unique_ptr::get.
3458         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3459         (create_dwo_unit_in_dwp_v2): Likewise.
3460         (open_and_init_dwo_file): Likewise.
3461         (free_dwo_file_from_slot): Remove.
3462
3463 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3464
3465         * dwarf2read.h (struct dwarf2_section_info) <readin,
3466         is_virtual>: Change type to bool.
3467         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3468         true instead of 1.
3469
3470 2019-06-19  Tom Tromey  <tom@tromey.com>
3471
3472         * tui/tui-data.h (tui_init_content_element): Don't declare.
3473
3474 2019-06-19  Tom Tromey  <tom@tromey.com>
3475
3476         * tui/tui-data.h (tui_init_win_info): Don't declare.
3477
3478 2019-06-19  Tom de Vries  <tdevries@suse.de>
3479
3480         * dwarf2read.h (abstract_to_concrete): Change type to
3481         std::unordered_map<sect_offset, std::vector<sect_offset>,
3482         gdb::hash_enum<sect_offset>>.
3483
3484 2019-06-19  Tom Tromey  <tromey@adacore.com>
3485
3486         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3487         EVAL_AVOID_SIDE_EFFECTS specially.
3488
3489 2019-06-19  Tom Tromey  <tromey@adacore.com>
3490
3491         * source-cache.c (highlighter): New global.
3492         (source_cache::get_source_lines): Create a highlighter on demand.
3493
3494 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3495
3496         * defs.h (deprecated_interactive_hook): Delete declaration.
3497         * interps.c (clear_interpreter_hooks): Remove use of
3498         deprecated_interactive_hook.
3499         * top.c (deprecated_interactive_hook): Delete definition.
3500         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3501
3502 2019-06-18  Tom de Vries  <tdevries@suse.de>
3503
3504         PR gdb/24515
3505         * dwarf2read.h (abstract_to_concrete): Change type from
3506         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3507         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3508         * dwarf2read.c (read_variable): Update.
3509         (dwarf2_fetch_die_loc_sect_off): Update.
3510
3511 2019-06-17  Tom de Vries  <tdevries@suse.de>
3512
3513         PR gdb/24617
3514         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3515         accessing parent[parent_len - 1].
3516
3517 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3518
3519         PR gdb/24364
3520         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3521         call dtrace_process_dof with NULL dof.
3522
3523 2019-06-16  Tom de Vries  <tdevries@suse.de>
3524
3525         PR gdb/24445
3526         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3527
3528 2019-06-16  Tom Tromey  <tom@tromey.com>
3529
3530         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3531         (make_all_visible): Use address of member.
3532
3533 2019-06-16  Tom Tromey  <tom@tromey.com>
3534
3535         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3536         (tui_free_window, free_content, free_content_elements): Remove
3537         unnecessary cast.
3538         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3539         cast.
3540         * tui/tui-regs.c (tui_show_register_group)
3541         (tui_display_registers_from, tui_display_reg_element_at_line):
3542         Remove unnecessary cast.
3543
3544 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3545
3546         * linux-nat.c (normal_mask): Delete.
3547         (_initialize_linux_nat): Don't initialise normal_mask.
3548
3549 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3550
3551         PR gdb/24445
3552         * dwarf-index-write.h (write_psymtabs_to_index): Add
3553         dwz_basename parameter.
3554         * dwarf-index-write.c (write_gdbindex): Move file writing to
3555         write_gdbindex_1.  Change return type void.
3556         (assert_file_size): Move up, remove filename parameter.
3557         (write_gdbindex_1): New function.
3558         (write_debug_names): Change return type to void, call
3559         assert_file_size.
3560         (struct index_wip_file): New struct.
3561         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3562         file logic to index_wip_file.  Write index for dwz file if
3563         needed.
3564         (save_gdb_index_command): Pass basename of dwz file, if present.
3565         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3566         build-id of dwz file, if present.
3567         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3568         (dwarf2_get_dwz_file): Likewise.
3569         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3570         (dwarf2_get_dwz_file): Likewise.
3571
3572 2019-06-16  Tom Tromey  <tom@tromey.com>
3573
3574         * coffread.c (process_coff_symbol): Use xstrdup.
3575         * value.c (create_internalvar): Use xstrdup.
3576
3577 2019-06-16  Tom Tromey  <tom@tromey.com>
3578
3579         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3580         * breakpoint.c (stopin_command, stopat_command)
3581         (until_break_command, decode_location_default): Remove unnecessary
3582         cast.
3583         * utils.c (subset_compare): Remove unnecessary cast.
3584         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3585         cast.
3586         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3587         cast.
3588         * infcmd.c (path_command): Remove unnecessary cast.
3589         * coffread.c (decode_type): Remove unnecessary cast.
3590         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3591         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3592         * tui/tui-stack.c (tui_show_locator_content)
3593         (tui_show_frame_info): Remove unnecessary cast.
3594         * tui/tui-win.c (tui_scroll_forward_command)
3595         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3596         (parse_scrolling_args): Remove unnecessary cast.
3597         * tui/tui-data.c (init_win_info, tui_del_window)
3598         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3599         (free_content_elements): Remove unnecessary cast.
3600         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3601         unnecessary cast.
3602         * tui/tui-source.c (tui_set_source_content)
3603         (tui_vertical_source_scroll): Remove unnecessary cast.
3604         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3605         cast.
3606         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3607         * tui/tui-regs.c (tui_display_registers_from)
3608         (tui_display_register): Remove unnecessary cast.
3609         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3610         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3611         (make_visible): Remove unnecessary cast.
3612         * tui/tui-winsource.c (tui_erase_source_content)
3613         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3614         unnecessary cast.
3615         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3616         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3617         * stabsread.c (read_type, read_array_type, read_range_type):
3618         Remove unnecessary cast.
3619         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3620         (parse_symbol, parse_type, upgrade_type, parse_external)
3621         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3622         unnecessary cast.
3623         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3624
3625 2019-06-16  Tom Tromey  <tom@tromey.com>
3626
3627         * tui/tui-data.c (tui_alloc_generic_win_info)
3628         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3629         checks.
3630
3631 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3632             Andrew Burgess  <andrew.burgess@embecosm.com>
3633
3634         * f-typeprint.c (f_print_type): Don't return early for not
3635         associated or not allocated types.
3636         (f_type_print_varspec_suffix): Add print_rank parameter and print
3637         ranks of array types in case they dangling.
3638         (f_type_print_base): Add print_rank parameter.
3639
3640 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3641
3642         * NEWS: Mention new MI commands.
3643         * break-catch-throw.c (enum exception_event_kind): Move to
3644         breakpoint.h.
3645         (print_mention_exception_catchpoint): Output text as a single
3646         message.
3647         (catch_exception_command_1): Rename to...
3648         (catch_exception_event): ...this, make non-static, update header
3649         command, and change some parameter types.
3650         (catch_catch_command): Update for changes to
3651         catch_exception_command_1.
3652         (catch_throw_command): Likewise.
3653         (catch_rethrow_command): Likewise.
3654         * breakpoint.c (enum exception_event_kind): Delete.
3655         * breakpoint.h (enum exception_event_kind): Moved here from
3656         break-catch-throw.c.
3657         (catch_exception_event): Declare.
3658         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3659         (mi_cmd_catch_throw): New function.
3660         (mi_cmd_catch_rethrow): New function.
3661         (mi_cmd_catch_catch): New function.
3662         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3663         'catch-catch' entries.
3664         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3665         (mi_cmd_catch_rethrow): Declare.
3666         (mi_cmd_catch_catch): Declare.
3667
3668 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3669
3670         * annotate.c (annotate_source_line): Change return type to void,
3671         update implementation to match.
3672         * annotate.h (annotate_source_line): Change return type to void,
3673         update header comment.
3674         * stack.c (print_frame_info): Don't change what frame information
3675         is printed based on whether annotations are on or not.
3676
3677 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3678
3679         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3680         (annotate_source): Make static.
3681         (annotate_source_line): Moved from source.c and renamed from
3682         identify_source_line.  Update the return type.
3683         * annotate.h (annotate_source): Delete declaration.
3684         (annotate_source_line): Declaration moved from source.h, and
3685         renamed from identify_source_line.  Return type updated.
3686         * source.c (identify_source_line): Moved to annotate.c and renamed
3687         to annotate_source_line.
3688         (info_line_command): Remove check of annotation_level.
3689         * source.h (identify_source_line): Move declaration to annotate.h
3690         and rename to annotate_source_line.
3691         * stack.c: Add 'annotate.h' include.
3692         (print_frame_info): Remove check of annotation_level before
3693         calling annotate_source_line.
3694
3695 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3696
3697         * source-cache.c (source_cache::get_plain_source_lines): Use
3698         open_source_file_with_line_charpos instead of just
3699         open_source_file, remove call to find_source_lines.
3700         (source_cache::get_source_lines): Likewise.
3701         * source.c (find_source_lines): Make static.
3702         (get_filename_and_charpos): Renamed into...
3703         (open_source_file_with_line_charpos): ..this along with changes to
3704         return a scoped_fd, and some other minor clean ups.
3705         (identify_source_line): Use open_source_file_with_line_charpos.
3706         (search_command_helper): Use open_source_file_with_line_charpos
3707         instead of just open_source_file, remove call to
3708         find_source_lines.
3709         * source.h (open_source_file_with_line_charpos): Declare new
3710         function.
3711         (find_source_lines): Delete declaration.
3712
3713 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3714
3715         * source.c (get_filename_and_charpos): Remove fullname
3716         parameter.
3717         (identify_source_line): Update call to get_filename_and_charpos.
3718
3719 2019-06-14  Tom Tromey  <tromey@adacore.com>
3720
3721         PR gdb/24502:
3722         * ui-style.h (skip_ansi_escape): Update comment.
3723         * ui-file.h (class no_terminal_escape_file): New class.
3724         * ui-file.c (no_terminal_escape_file::write)
3725         (no_terminal_escape_file::puts): New methods.
3726         * cli/cli-logging.c (handle_redirections): Use
3727         no_terminal_escape_file.
3728
3729 2019-06-14  Tom Tromey  <tromey@adacore.com>
3730
3731         * NEWS: Move convenience variable news above Python news.
3732
3733 2019-06-14  Tom Tromey  <tom@tromey.com>
3734
3735         * gnulib: Move directory to top-level.
3736         * configure.ac: Don't configure gnulib.
3737         * configure: Rebuild.
3738         * common/common-defs.h: Use new path to gnulib.
3739         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3740         (GNULIB_H): Remove.
3741         (INCGNU): Look in new gnulib location.
3742         (HFILES_NO_SRCDIR): Remove gnulib files.
3743         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3744         (generated_files): Remove GNULIB_H.
3745         ($(LIBGNU), all-lib): Remove targets.
3746         (distclean): Don't mention GNULIB_BUILDDIR.
3747         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3748
3749 2019-06-14  Tom Tromey  <tromey@adacore.com>
3750
3751         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3752         Warn if symbol file does not provide any symbols.
3753
3754 2019-06-14  Tom Tromey  <tromey@adacore.com>
3755
3756         * source.c (find_and_open_source): Respect basenames_may_differ.
3757
3758 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3759
3760         * annotate.c (annotate_breakpoints_invalid): Make use of
3761         scoped_restore_terminal_state.
3762         (annotate_frames_invalid): Likewise.
3763
3764 2019-06-14  Tom Tromey  <tromey@adacore.com>
3765
3766         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3767         allow assignment to an internalvar.
3768
3769 2019-06-14  Tom Tromey  <tromey@adacore.com>
3770
3771         * ada-lex.l: Allow "_" in attribute names.
3772
3773 2019-06-14  Tom Tromey  <tromey@adacore.com>
3774
3775         PR gdb/24653:
3776         * regcache.c (registers_changed): Don't call alloca.
3777         * top.c (execute_command): Don't call alloca.
3778
3779 2019-06-13  Pedro Alves  <palves@redhat.com>
3780
3781         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3782         'expression'.  When parsing an expression, error out if there's
3783         junk after "unlimited".
3784         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3785         (do_set_command): Adjust calls to is_unlimited_literal.
3786
3787 2019-06-13  Pedro Alves  <palves@redhat.com>
3788
3789         * compile/compile.c (make_compile_options_def_group): Add braces
3790         around array_view initializer.
3791         * thread.c (make_thread_apply_all_options_def_group)
3792         (make_thread_apply_all_options_def_group): Likewise.
3793
3794 2019-06-13  Pedro Alves  <palves@redhat.com>
3795
3796         * NEWS (New commands): Mention "maint test-options
3797         require-delimiter", "maint test-options unknown-is-error", "maint
3798         test-options unknown-is-operand" and "maint show
3799         test-options-completion-result".
3800         (New command options, command completion): New section.
3801         (Completion improvements): New section.
3802         Mention that you can abbreviate "unlimited".
3803
3804 2019-06-13  Pedro Alves  <palves@redhat.com>
3805
3806         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3807         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3808         * unittests/cli-utils-selftests.c (test_parse_flags)
3809         (test_parse_flags_qcs): Delete.
3810         (test_cli_utils): Don't call deleted functions.
3811
3812 2019-06-13  Pedro Alves  <palves@redhat.com>
3813
3814         * thread.c: Include "cli/cli-option.h".
3815         (tp_array_compar_ascending): Global.
3816         (tp_array_compar): Delete function.
3817         (tp_array_compar_ascending, tp_array_compar_descending): New
3818         functions.
3819         (ascending_option_def, qcs_flag_option_def)
3820         (thr_qcs_flags_option_defs)
3821         (make_thread_apply_all_options_def_group)
3822         (make_thread_apply_options_def_group): New.
3823         (thread_apply_all_command): Use gdb::option::process_options.
3824         (thread_apply_command_completer)
3825         (thread_apply_all_command_completer): New.
3826         (thread_apply_command): Use gdb::option::process_options.
3827         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3828         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3829         to generate help text of "thread apply".  Adjust "taas"'s help.
3830         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3831         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3832
3833 2019-06-13  Pedro Alves  <palves@redhat.com>
3834
3835         * thread.c (thread_apply_command): Check for invalid TID with
3836         isdigit instead of !isalpha.
3837
3838 2019-06-13  Pedro Alves  <palves@redhat.com>
3839
3840         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3841         (validate_flags_qcs): New.
3842         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3843         (validate_flags_qcs): Declare.
3844         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3845         (make_frame_apply_options_def_group): New.
3846         (frame_apply_command_count): Process options with
3847         gdb::option::process_options.
3848         (frame_apply_completer): New.
3849         (frame_apply_level_completer, frame_apply_all_completer)
3850         (frame_apply_completer): New.
3851         (_initialize_stack): Update help of "frame apply", "frame apply
3852         level", "frame apply all" and "faas" to mention supported options
3853         and install command completers.
3854         * stack.h (frame_apply_all_completer): Declare.
3855         * thread.c: Include "stack.h".
3856         (tfaas_command): Add "--".
3857         (_initialize_thread): Update help "tfaas" to mention supported
3858         options and install command completer.
3859
3860 2019-06-13  Pedro Alves  <palves@redhat.com>
3861
3862         * completer.c (complete_nested_command_line): New.
3863         (gdb_completion_word_break_characters_throw): Add assertion.
3864         * completer.h (complete_nested_command_line): Declare.
3865
3866 2019-06-13  Pedro Alves  <palves@redhat.com>
3867
3868         * stack.c (parse_backtrace_qualifiers): New.
3869         (backtrace_command): Use it.
3870         (backtrace_command_completer): Complete on qualifiers.
3871
3872 2019-06-13  Pedro Alves  <palves@redhat.com>
3873
3874         * frame.c: Include "cli/cli-option.h.
3875         (user_set_backtrace_options): New.
3876         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3877         Delete.
3878         (get_prev_frame): Adjust.
3879         (boolean_option_def, uinteger_option_def)
3880         (set_backtrace_option_defs): New.
3881         (_initialize_frame): Adjust and use
3882         gdb::option::add_setshow_cmds_for_options to install "set
3883         backtrace past-main" and "set backtrace past-entry".
3884         * frame.h: Include "cli/cli-option.h".
3885         (struct frame_print_options): Forward declare.
3886         (print_frame_arguments_all, print_frame_arguments_scalars)
3887         (print_frame_arguments_none): Declare.
3888         (print_entry_values): Delete declaration.
3889         (struct frame_print_options, user_frame_print_options): New.
3890         (struct set_backtrace_options): New.
3891         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3892         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3893         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3894         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3895         (list_args_or_locals): Add frame_print_options parameter.
3896         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3897         * python/py-framefilter.c (enumerate_args): Pass down
3898         USER_FRAME_PRINT_OPTIONS.
3899         * stack.c: Include "cli/cli-option.h".
3900         (print_frame_arguments_all, print_frame_arguments_scalars)
3901         (print_frame_arguments_none): Declare.
3902         (print_raw_frame_arguments, print_entry_values): Delete.
3903         (user_frame_print_options): New.
3904         (boolean_option_def, enum_option_def, frame_print_option_defs):
3905         New.
3906         (struct backtrace_cmd_options): New.
3907         (bt_flag_option_def): New.
3908         (backtrace_command_option_defs): New.
3909         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3910         (print_frame_arg, read_frame_arg, print_frame_args)
3911         (print_frame_info, print_frame): Add frame_print_options parameter
3912         and use it.
3913         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3914         (backtrace_command_1): Add frame_print_options and
3915         backtrace_cmd_options parameters and use them.
3916         (make_backtrace_options_def_group): New.
3917         (backtrace_command): Process command options with
3918         gdb::option::process_options.
3919         (backtrace_command_completer): New.
3920         (_initialize_stack): Extend "backtrace"'s help to mention
3921         supported options.  Install completer for "backtrace".
3922         Install some settings commands with add_setshow_cmds_for_options.
3923
3924 2019-06-13  Pedro Alves  <palves@redhat.com>
3925
3926         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3927         and that "set/show print raw frame-arguments" are now deprecated.
3928
3929         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3930         command.
3931         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3932         * stack.c (_initialize_stack): Install "set/show print
3933         raw-frame-arguments", and deprecate "set/show print raw
3934         frame-arguments".
3935         * valprint.c (_initialize_valprint): Deprecate "set/show print
3936         raw".
3937
3938 2019-06-13  Pedro Alves  <palves@redhat.com>
3939
3940         * compile/compile.c (struct compile_options): New.
3941         (compile_flag_option_def, compile_command_option_defs)
3942         (make_compile_options_def_group): New.
3943         (compile_file_command): Handle options with
3944         gdb::option::process_options.
3945         (compile_file_command_completer): New function.
3946         (compile_code_command): Handle options with
3947         gdb::option::process_options.
3948         (compile_code_command_completer): New function.
3949         (_initialize_compiler): Install completers for "compile code" and
3950         "compile file".  Mention available options in "compile code" and
3951         "compile code"'s help.
3952         * completer.c (advance_to_completion_word): New, factored out from
3953         ...
3954         (advance_to_expression_complete_word_point): ... this.
3955         (advance_to_filename_complete_word_point): New.
3956         * completer.h (advance_to_filename_complete_word_point): New
3957         declaration.
3958
3959 2019-06-13  Pedro Alves  <palves@redhat.com>
3960
3961         * compile/compile.c: Include "cli/cli-option.h".
3962         (compile_print_value): Scope data pointer is now a
3963         value_print_options pointer; adjust.
3964         (compile_print_command): Process options.  Scope data pointer is
3965         now a value_print_options pointer; adjust.
3966         (_initialize_compile): Update "compile print"'s help to include
3967         supported options.  Install a completer for "compile print".
3968         * cp-valprint.c (show_vtblprint, show_objectprint)
3969         (show_static_field_print): Delete.
3970         (_initialize_cp_valprint): Don't install "set print
3971         static-members", "set print vtbl", "set print object" here.
3972         * printcmd.c: Include "cli/cli-option.h" and
3973         "common/gdb_optional.h".
3974         (print_command_parse_format): Rework to fill in a
3975         value_print_options instead of a format_data.
3976         (print_value): Change parameter type from format_data pointer to
3977         value_print_options reference.  Adjust.
3978         (print_command_1): Process options.  Adjust to pass down a
3979         value_print_options.
3980         (print_command_completer): New.
3981         (_initialize_printcmd): Install print_command_completer as
3982         handle_brkchars completer for the "print" command.  Update
3983         "print"'s help to include supported options.
3984         * valprint.c: Include "cli/cli-option.h".
3985         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3986         here from cp-valprint.c.
3987         (boolean_option_def, uinteger_option_def)
3988         (value_print_option_defs, make_value_print_options_def_group):
3989         New.  Use gdb::option::add_setshow_cmds_for_options to install
3990         "set print elements", "set print null-stop", "set print repeats",
3991         "set print pretty", "set print union", "set print array", "set
3992         print address", "set print symbol", "set print array-indexes".
3993         * valprint.h: Include <string> and "cli/cli-option.h".
3994         (make_value_print_options_def_group): Declare.
3995         (print_value): Change parameter type from format_data pointer to
3996         value_print_options reference.
3997         (print_command_completer): Declare.
3998
3999 2019-06-13  Pedro Alves  <palves@redhat.com>
4000
4001         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4002         (COMMON_SFILES): Add maint-test-settings.c.
4003         * cli/cli-decode.c (boolean_enums): New global, factored out from
4004         ...
4005         (add_setshow_boolean_cmd): ... here.
4006         * cli/cli-decode.h (boolean_enums): Declare.
4007         * cli/cli-option.c: New file.
4008         * cli/cli-option.h: New file.
4009         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4010         factored out from ...
4011         (parse_cli_boolean_value(const char *)): ... this.
4012         (is_unlimited_literal): Change parameter type to pointer to
4013         pointer.  Adjust and advance ARG pointer.
4014         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4015         (parse_cli_var_enum): New, factored out from ...
4016         (do_set_command): ... this.  Adjust.
4017         * cli/cli-setshow.h (parse_cli_boolean_value)
4018         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4019         (parse_cli_var_enum): Declare.
4020         * cli/cli-utils.c: Include "cli/cli-option.h".
4021         (get_ulongest): New.
4022         * cli/cli-utils.h (get_ulongest): Declare.
4023         (check_for_argument): New overloads.
4024         * maint-test-options.c: New file.
4025
4026 2019-06-13  Pedro Alves  <palves@redhat.com>
4027
4028         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4029         parse a range if "-" is at the end of the string.
4030
4031 2019-06-13  Pedro Alves  <palves@redhat.com>
4032
4033         * cli/cli-setshow.c (parse_auto_binary_operation)
4034         (parse_cli_boolean_value): Don't allow "o".
4035
4036 2019-06-13  Pedro Alves  <palves@redhat.com>
4037
4038         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4039         * NEWS: Mention maint test-settings KIND.
4040         * maint-test-settings.c: New file.
4041
4042 2019-06-13  Pedro Alves  <palves@redhat.com>
4043
4044         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4045         completer.
4046         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4047         "set" completers.
4048
4049 2019-06-13  Pedro Alves  <palves@redhat.com>
4050
4051         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4052         after item.
4053
4054 2019-06-13  Pedro Alves  <palves@redhat.com>
4055
4056         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4057
4058 2019-06-13  Pedro Alves <palves@redhat.com>
4059
4060         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4061         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4062         call.
4063         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4064         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4065         calls.
4066         (check_for_argument): Skip spaces after argument.
4067
4068 2019-06-13  Pedro Alves  <palves@redhat.com>
4069
4070         * thread.c (thread_apply_command): Adjust TID parsing.
4071         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4072         detected before end of string.
4073         (tid_is_in_list): Error out if LIST is invalid.
4074
4075 2019-06-13  Pedro Alves  <palves@redhat.com>
4076
4077         * completer.c (complete_line_internal_1): Rewind completion word
4078         point.
4079         (completion_tracker::advance_custom_word_point_by): Change
4080         parameter type to int.
4081         * completer.h (completion_tracker::advance_custom_word_point_by):
4082         Likewise.
4083
4084 2019-06-13  Pedro Alves  <palves@redhat.com>
4085
4086         * completer.c (advance_to_completion_word): Handle delimiters.
4087
4088 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4089
4090         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4091
4092 2019-06-11  Tom Tromey  <tom@tromey.com>
4093
4094         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4095         (xmalloc_failed): Move to alloc.c.
4096         * alloc.c: New file.
4097         * Makefile.in (COMMON_SFILES): Add alloc.c.
4098
4099 2019-06-11  Tom Tromey  <tom@tromey.com>
4100
4101         * nat/linux-waitpid.c: Don't include server.h.
4102         (linux_debug): Remove.
4103         (my_waitpid): Update.
4104
4105 2019-06-11  Tom Tromey  <tromey@adacore.com>
4106
4107         * infcall.c (_initialize_infcall): Remove trailing newline from
4108         help.
4109         * user-regs.c (_initialize_user_regs): Remove trailing newline
4110         from help.
4111         * typeprint.c (_initialize_typeprint): Remove trailing newline
4112         from help.
4113         * reverse.c (_initialize_reverse): Remove trailing newlines from
4114         help.
4115         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4116         from help.
4117         * language.c (add_set_language_command): Remove trailing newline
4118         from help.
4119         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4120         help.
4121         * disasm.c (_initialize_disasm): Remove trailing newline from
4122         help.
4123         * top.c (init_main): Remove trailing newline from help.
4124         * interps.c (_initialize_interpreter): Remove trailing newline
4125         from help.
4126         * btrace.c (_initialize_btrace): Remove trailing newlines from
4127         help.
4128         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4129         from help.
4130         * python/python.c (_initialize_python): Remove trailing newline
4131         from help.
4132         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4133         help.
4134         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4135         from help.  Reformat some text.
4136         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4137         from help.
4138         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4139         newline from help.
4140
4141 2019-06-11  Tom Tromey  <tromey@adacore.com>
4142
4143         * darwin-nat.c (darwin_decode_exception_message)
4144         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4145
4146 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * valops.c (value_slice): Check for not allocated or not
4149         associated values.
4150
4151 2019-06-10  Tom de Vries  <tdevries@suse.de>
4152
4153         PR gdb/24618
4154         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4155         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4156         invalid.
4157
4158 2019-06-10  Tom de Vries  <tdevries@suse.de>
4159
4160         PR gdb/24611
4161         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4162         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4163
4164 2019-06-10  Tom de Vries  <tdevries@suse.de>
4165
4166         PR symtab/24545
4167         * symtab.c (struct demangled_name_entry): Add language field.
4168         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4169         static minimal symbol".  Set and use language field.
4170
4171 2019-06-10  Tom Tromey  <tromey@adacore.com>
4172
4173         * ada-lang.c (_initialize_ada_language): Update help text.
4174
4175 2019-06-10  Tom Tromey  <tromey@adacore.com>
4176
4177         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4178         with a newline.
4179         * guile/guile.c (handle_boot_error): Don't end warning with a
4180         newline.
4181         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4182         warning with a newline.
4183         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4184         newline.
4185         (s12z_frame_cache): Likewise.
4186         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4187         a newline.
4188         * solib-svr4.c (disable_probes_interface): Don't end warning with
4189         a newline.
4190         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4191         newline.
4192         * python/python.c (do_finish_initialization): Don't end warning
4193         with a newline.
4194
4195 2019-06-10  Tom Tromey  <tom@tromey.com>
4196
4197         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4198         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4199         gdbpy_enter.
4200
4201 2019-06-10  Tom Tromey  <tromey@adacore.com>
4202
4203         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4204         data.
4205         (elf_new_init): Don't call stabsread_new_init.
4206         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4207         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4208         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4209
4210 2019-06-10  Tom de Vries  <tdevries@suse.de>
4211
4212         PR symtab/16264
4213         PR symtab/24517
4214         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4215
4216 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4217
4218         * source.c (find_and_open_source): Also rewrite relative file
4219         names.
4220
4221 2019-04-26  Amos Bird  <amosbird@gmail.com>
4222
4223         * annotate.c (annotate_thread_exited): Add "thread-exited"
4224         annotation.
4225
4226 2019-06-06  Tom Tromey  <tromey@adacore.com>
4227
4228         * maint.h (class scoped_command_stats): Use
4229         DISABLE_COPY_AND_ASSIGN.
4230         <print_time>: New method.
4231         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4232         print_time.
4233         (scoped_command_stats::print_time): New method.
4234
4235 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4236
4237         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4238         instructions of lengths 6 or 8 bytes.
4239
4240 2019-06-04  Pedro Alves  <palves@redhat.com>
4241
4242         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4243
4244         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4245         * breakpoint.c (condition_completer): Likewise.
4246         * cli/cli-dump.c (scan_expression): Likewise.
4247         * common/filestuff.c (mkdir_recursive): Likewise.
4248         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4249         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4250         (gdb_abspath): Likewise.
4251         * compile/compile-cplus-types.c
4252         (compile_cplus_instance::decl_name): Likewise.
4253         * completer.c (complete_explicit_location):
4254         (signal_completer, reg_or_group_completer_1): Likewise.
4255         * cp-support.c (cp_remove_params_if_any): Likewise.
4256         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4257         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4258         * infcmd.c (strip_bg_char): Likewise.
4259         * linespec.c (copy_token_string): Likewise.
4260         * mi/mi-main.c (output_cores): Likewise.
4261         * psymtab.c (psymtab_search_name):
4262         * symfile.c (test_set_ext_lang_command): Likewise.
4263         * target.c (target_fileio_read_stralloc): Likewise.
4264         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4265         * value.c (complete_internalvar): Likewise.
4266
4267 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4268
4269         Add objfile property to gdb.Type.
4270         * NEWS: Mention Python API addition.
4271         * python/py-type.c (typy_get_objfile): New method.
4272
4273 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4274
4275         * NEWS: Mention the new set|show style [title|highlight].
4276         Mention changes to "show style", "help" and "apropos".
4277
4278 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4279
4280         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4281         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4282         instead of print_help_for_command.
4283         (print_doc_of_command): New function.
4284         (help_list): Add 'apropos -v word' suggestion.
4285         (print_help_for_command): Style the command name using title style.
4286         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4287         (_initialize_cli_cmds): Describe -v in apropos_command help.
4288
4289 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4290
4291         * cli/cli-style.h (cli_style_option): Add name in constructor,
4292         add m_name class member, add constructor with intensity,
4293         add name class function.
4294         (cli_style_option::add_setshow_commands): Remove name argument.
4295         (highlight_style, title_style): New styles.
4296         * cli/cli-style.c (do_show): New function that shows a style
4297         characteristic styling the style name with itself.
4298         (set_style_name): New function.
4299         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4300         Update all callers according to the changes in cli/cli-style.h.
4301         * utils.h (fputs_highlighted): New function.
4302         * utils.c (fputs_highlighted): Likewise.
4303
4304 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4305
4306         * NEWS: Mention new pipe command and new convenience variables.
4307
4308 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4309
4310         * cli/cli-cmds.c (pipe_command): New function.
4311         (_initialize_cli_cmds): Call add_com for pipe_command.
4312         Define | as an alias for pipe.
4313         (exit_status_set_internal_vars): New function.
4314         (shell_escape): Call exit_status_set_internal_vars.
4315         cli/cli-decode.c (find_command_name_length): Recognize | as
4316         a single character command.
4317
4318 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4319
4320         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4321         top.c (execute_command_to_ui_file): New function, mostly a copy
4322         of execute_command_to_string.
4323         (execute_command_to_string): Implement by calling
4324         execute_command_to_ui_file.
4325
4326 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4327
4328         * top.h (saved_command_line): Remove declaration.
4329         * top.c (previous_saved_command_line, previous_repeat_arguments):
4330         New variables.
4331         (saved_command_line): Make static, define together with other
4332         'repeat variables'.
4333         (dont_repeat): Clear repeat_arguments.
4334         (repeat_previous, get_saved_command_line, save_command_line):
4335         New functions.
4336         (gdb_init): Initialize saved_command_line
4337         and previous_saved_command_line.
4338         * main.c (captured_main_1): Remove saved_command_line initialization.
4339         * event-top.c (handle_line_of_input): Update to use
4340         the new 'repeat' related functions instead of direct access to
4341         saved_command_line.
4342         * command.h (repeat_previous, get_saved_command_line,
4343         save_command_line): New declarations.
4344         (dont_repeat): Add comment.
4345
4346 2019-05-30  Tom Tromey  <tromey@adacore.com>
4347
4348         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4349         Fix comment.
4350         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4351
4352 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4353
4354         PR cli/24587
4355         * completer.c (complete): Initialize variable word.
4356
4357 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4358
4359         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4360         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4361         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4362         'body' is NULL to the outter 'if', protecting the '!is_define'
4363         situation as well.
4364
4365 2019-05-29  Tom Tromey  <tromey@adacore.com>
4366
4367         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4368         (dwarf_unknown): New function.
4369         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4370         (dwarf_type_encoding_name): Use dwarf_unknown.
4371
4372 2019-05-29  Tom Tromey  <tromey@adacore.com>
4373
4374         PR c++/20020:
4375         * cp-valprint.c (cp_print_value_fields): Call
4376         cp_print_static_field inside "try".
4377
4378 2019-05-29  Tom Tromey  <tromey@adacore.com>
4379
4380         * inflow.c (struct terminal_info): Add default operator=.
4381         * configure: Rebuild.
4382         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4383         -Wdeprecated-copy-dtor, -Wredundant-move.
4384
4385 2019-05-29  Tom Tromey  <tromey@adacore.com>
4386
4387         * NEWS: Add entry.
4388         * infcmd.c (print_return_value_1): Handle finish_print
4389         option.
4390         (show_print_finish): New function.
4391         (_initialize_infcmd): Add "set/show print finish" commands.
4392         * valprint.c (user_print_options): Initialize new member.
4393         * valprint.h (struct value_print_options) <finish_print>: New
4394         member.
4395
4396 2019-05-28  Tom Tromey  <tromey@adacore.com>
4397
4398         * ada-lang.c (ada_remove_Xbn_suffix)
4399         (find_old_style_renaming_symbol)
4400         (parse_old_style_renaming): Remove.
4401         (ada_find_renaming_symbol): Don't call
4402         find_old_style_renaming_symbol.
4403         (ada_is_renaming_symbol): Rename from
4404         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4405         bool.  Now static.
4406         (ada_read_var_value): Update and simplify.
4407         * ada-exp.y (write_var_or_type): Remove old code.
4408
4409 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4410
4411         * event-top.c: Remove include comment.
4412         * inflow.c (class scoped_ignore_sigttou): Move from here...
4413         * inflow.h (class scoped_ignore_sigttou): ...to here.
4414         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4415         * top.c:  Remove include comment.
4416
4417 2019-05-27  Tom Tromey  <tom@tromey.com>
4418
4419         * NEWS: Fix typo.
4420
4421 2019-05-22  Tom Tromey  <tromey@adacore.com>
4422
4423         * target.c (target_follow_exec): Constify parameter.
4424         * target-delegates.c: Rebuild.
4425         * remote.c (remote_target::follow_exec): Constify parameter.
4426         * infrun.c (follow_exec): Constify parameter.
4427         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4428         (target_follow_exec): Likewise.
4429
4430 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4431
4432         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4433         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4434
4435 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4436
4437         * NEWS: Add debugredirect and testsuite sections.
4438
4439 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4440
4441         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4442         target descriptions using exclusively floating point register name
4443         aliases.
4444
4445 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4446
4447         PR gdb/18644:
4448         * f-lang.c (build_fortran_types): Handle the case where
4449         gdbarch_floatformat_for_type returns a nullptr.
4450
4451 2019-05-21  Tom de Vries  <tdevries@suse.de>
4452
4453         PR cli/24587
4454         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4455
4456 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4457
4458         PR gdb/18644:
4459         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4460         16-byte floats.
4461         * i386-tdep.c (i386_floatformat_for_type): Use
4462         floatformats_ia64_quad for the 16-byte floating point component
4463         within a fortran 32-byte complex number.
4464
4465 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4466
4467         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4468         delete default constructor.
4469         (find_partial_die): Update to return const struct.
4470         (partial_die_parent_scope): Move variable declaration into scope
4471         of its use and change its type to auto.
4472         (guess_partial_die_structure_name): Likewise.
4473         (partial_die_info::fixup): Likewise.
4474
4475 2019-05-17  Tom Tromey  <tromey@adacore.com>
4476
4477         * source.c (find_and_open_source): Remove cast.
4478
4479 2019-05-17  Tom Tromey  <tromey@adacore.com>
4480
4481         * annotate.c (annotate_source): Make "filename" const.
4482         * annotate.h (annotate_source): Use const.
4483
4484 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4485
4486         * disasm.c (set_disassembler_options): Send errors to stderr.
4487
4488 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4489
4490         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4491         (cli_interp_base::set_logging): Check debug_redirect.
4492         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4493         * cli/cli-logging.c (debug_redirect): Add static variable.
4494         (pop_output_files): Add default param.
4495         (handle_redirections): Print debug setting.
4496         (show_logging_command): Likewise.
4497         (_initialize_cli_logging): Add debugredirect command.
4498         * interps.c (current_interp_set_logging): Add debug_redirect
4499         parameter.
4500         * interps.h (set_logging): Add debug_redirect parameter.
4501         (current_interp_set_logging): Likewise.
4502         * mi/mi-common.h: Likewise.
4503         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4504
4505 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4506             Tom Tromey  <tromey@adacore.com>
4507
4508         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4509         directly.
4510         * cli/cli-interp.h (make_logging_output): Remove declaration.
4511         * cli/cli-logging.c (make_logging_output): Remove function.
4512         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4513         directly.
4514         * ui-file.c (tee_file::tee_file): Remove bools.
4515         (tee_file::~tee_file): Remove deletes.
4516         * ui-file.h (tee_file): Remove bools.
4517
4518 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4519
4520         * mi/mi-cmds.h (mi_cmd_complete): New function.
4521         * mi/mi-main.c (mi_cmd_complete): Likewise.
4522         * mi/mi-cmds.c: Define new MI command -complete.
4523         * NEWS: Mention new -complete command.
4524
4525 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4526
4527         * completer.h (complete): New function.
4528         * completer.c (complete): Likewise.
4529         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4530         function defined in completer.h.
4531
4532 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4533
4534         * MAINTAINERS (Write After Approval): Add myself.
4535
4536 2019-05-17  Tom de Vries  <tdevries@suse.de>
4537
4538         PR gdb/24094
4539         * dwarf2read.c (struct cu_partial_die_info): New struct.
4540         (find_partial_die): Return cu_partial_die_info.
4541         (partial_die_parent_scope, guess_partial_die_structure_name)
4542         (partial_die_info::fixup): Handle new return type of find_partial_die.
4543
4544 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4545
4546         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4547         "std::string", simplifying the algorithm.
4548
4549 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4550
4551         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4552         (stap_static_probe_ops::get_probes): Likewise.
4553
4554 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4555
4556         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4557         '-')" and "else if".
4558         (stap_parse_single_operand): Join checks for
4559         "gdbarch_stap_parse_special_token_p" and
4560         "gdbarch_stap_parse_special_token" in the same "if" statement.
4561         Invert check when verifying for operation on register
4562         displacement.
4563
4564 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4565
4566         * stap-probe.c (stap_get_opcode): Update comment.
4567         (stap_get_expected_argument_type): Likewise.
4568         (handle_stap_probe): Likewise.
4569
4570 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4571
4572         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4573         return type to 'bool'.  Adjust comment.  Use 'bool' when
4574         appropriate.
4575         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4576         * stap-probe.c (stap_parse_argument_1): Likewise.
4577         (stap_is_operator): Likewise.
4578         (stap_is_generic_prefix): Likewise.
4579         (stap_is_register_prefix): Likewise.
4580         (stap_is_register_indirection_prefix): Likewise.
4581         (stap_is_integer_prefix): Likewise.
4582         (stap_generic_check_suffix): Likewise.
4583         (stap_check_integer_suffix): Likewise.
4584         (stap_check_register_suffix): Likewise.
4585         (stap_check_register_indirection_suffix): Likewise.
4586         (stap_parse_register_operand): Likewise.
4587         (stap_parse_single_operand): Likewise.
4588         (stap_parse_argument_1): Likewise.
4589         (stap_probe::get_argument_count): Likewise.
4590         (stap_is_operator): Likewise.
4591
4592 2019-05-16  Tom Tromey  <tromey@adacore.com>
4593
4594         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4595         keyword to foreach.
4596
4597 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4598
4599         * linux-thread-db.c (try_thread_db_load_1): Change return type
4600         to bool.
4601         (try_thread_db_load): Likewise.
4602         (try_thread_db_load_from_pdir_1): Likewise.
4603         (try_thread_db_load_from_pdir): Likewise.
4604         (try_thread_db_load_from_sdir): Likewise.
4605         (try_thread_db_load_from_dir): Likewise.
4606         (thread_db_load_search): Likewise.
4607         (has_libpthread): Likewise.
4608         (thread_db_load): Likewise.
4609
4610 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4611
4612         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4613         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4614         NULL, and complain/return if that's the case.
4615
4616 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4617
4618         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4619         (advance, posn, abstract_read_memory): New functions.
4620         [struct mem_read_abstraction]: New struct.
4621         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4622
4623 2019-05-14  Tom Tromey  <tromey@adacore.com>
4624
4625         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4626         value is not lval_memory.
4627
4628 2019-05-14  Tom Tromey  <tromey@adacore.com>
4629
4630         * solib.c (info_sharedlibrary_command): Style the file name.
4631
4632 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4633
4634         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4635         (aarch64_vnv_type): Likewise.
4636         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4637         * common/tdesc.c: Likewise.
4638         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4639         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4640         * features/aarch64-fpu.xml: Add ieee half view.
4641         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4642         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4643         * gdbtypes.h (struct builtin_type): Likewise.
4644         (struct objfile_type): Likewise.
4645
4646 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4647
4648         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4649         typo.
4650         * location.h (string_to_event_location): Likewise.
4651
4652 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4653
4654         GDB 8.3 released.
4655
4656 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4657
4658         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4659         New variable declaration.
4660         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4661         New variable.
4662         (print_one_breakpoint): Use ui_out::test_flags and new global
4663         variable to compute use_fixed_output.
4664         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4665         Remove.
4666         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4667         (mi_multi_location_breakpoint_output_fixed): Remove.
4668         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4669         new variable.
4670         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4671         fix_multi_location_breakpoint_output flag if version >= 3.
4672         * ui-out.h (enum ui_out_flag)
4673         <fix_multi_location_breakpoint_output>: New enumerator.
4674
4675 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4676
4677         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4678
4679 2019-05-10  Tom Tromey  <tromey@adacore.com>
4680
4681         * ada-lang.c (catch_ada_completer): New function.
4682         (_initialize_ada_language): Use it.
4683
4684 2019-05-10  Tom Tromey  <tromey@adacore.com>
4685
4686         * thread.c (print_thread_info): Make "requested_threads" const.
4687         * gdbthread.h (print_thread_info): Make "requested_threads"
4688         const.
4689         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4690         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4691
4692 2019-05-08  Tom Tromey  <tom@tromey.com>
4693
4694         * gdbtypes.c (objfile_type_data): Change type.
4695         (objfile_type, _initialize_gdbtypes): Update.
4696
4697 2019-05-08  Tom Tromey  <tom@tromey.com>
4698
4699         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4700         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4701         (_initialize_dwarf2_frame): Update.
4702
4703 2019-05-08  Tom Tromey  <tom@tromey.com>
4704
4705         * objc-lang.c (objc_objfile_data): Change type.
4706         (find_methods): Update.
4707         (_initialize_objc_lang): Remove.
4708
4709 2019-05-08  Tom Tromey  <tom@tromey.com>
4710
4711         * stabsread.c (rs6000_builtin_type_data): Change type.
4712         (rs6000_builtin_type, _initialize_stabsread): Update.
4713
4714 2019-05-08  Tom Tromey  <tom@tromey.com>
4715
4716         * mips-tdep.c (mips_pdr_data): Remove.
4717         (_initialize_mips_tdep): Update.
4718
4719 2019-05-08  Tom Tromey  <tom@tromey.com>
4720
4721         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4722         (hppa_init_objfile_priv_data, read_unwind_info)
4723         (find_unwind_entry, _initialize_hppa_tdep): Update.
4724
4725 2019-05-08  Tom Tromey  <tom@tromey.com>
4726
4727         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4728         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4729         on obstack.
4730         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4731
4732 2019-05-08  Tom Tromey  <tom@tromey.com>
4733
4734         * mdebugread.c (basic_type_data): Change type.
4735         (basic_type, _initialize_mdebugread): Update.
4736
4737 2019-05-08  Tom Tromey  <tom@tromey.com>
4738
4739         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4740
4741 2019-05-08  Tom Tromey  <tom@tromey.com>
4742
4743         * nto-tdep.c (nto_inferior_data_reg): Change type.
4744         (nto_inferior_data): Update.
4745         (nto_inferior_data_cleanup, nto_new_inferior_data)
4746         (_initialize_nto_tdep): Remove.
4747         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4748
4749 2019-05-08  Tom Tromey  <tom@tromey.com>
4750
4751         * ada-lang.c (struct ada_inferior_data): Add initializers.
4752         (ada_inferior_data): Change type.
4753         (ada_inferior_data_cleanup): Remove.
4754         (get_ada_inferior_data, ada_inferior_exit)
4755         (struct ada_pspace_data): Add initializers, destructor.
4756         (ada_pspace_data_handle): Change type.
4757         (get_ada_pspace_data): Update.
4758         (ada_pspace_data_cleanup): Remove.
4759
4760 2019-05-08  Tom Tromey  <tom@tromey.com>
4761
4762         * coffread.c (struct coff_symfile_info): Add initializers.
4763         (coff_objfile_data_key): Move lower.  Change type.
4764         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4765         Update.
4766         (coff_free_info): Remove.
4767
4768 2019-05-08  Tom Tromey  <tom@tromey.com>
4769
4770         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4771         (fbsd_pspace_data_handle): Move lower.  Change type.
4772         (get_fbsd_pspace_data): Update.
4773         (fbsd_pspace_data_cleanup): Remove.
4774         (_initialize_fbsd_tdep): Update.
4775
4776 2019-05-08  Tom Tromey  <tom@tromey.com>
4777
4778         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4779         (get_ada_tasks_pspace_data): Update.
4780         (ada_tasks_pspace_data_cleanup): Remove.
4781         (_initialize_tasks): Update.
4782         (ada_tasks_inferior_data_handle): Change type.
4783         (get_ada_tasks_inferior_data): Update.
4784         (ada_tasks_inferior_data_cleanup): Remove.
4785         (struct ada_tasks_pspace_data): Add initializers.
4786
4787 2019-05-08  Tom Tromey  <tom@tromey.com>
4788
4789         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4790         * symfile-debug.c (debug_sym_get_probes): Change type.
4791         * stap-probe.c (handle_stap_probe):
4792         (stap_static_probe_ops::get_probes): Change type.
4793         * probe.h (class static_probe_ops) <get_probes>: Change type.
4794         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4795         (parse_probes_in_pspace): Update.
4796         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4797         Update.
4798         (any_static_probe_ops::get_probes): Change type.
4799         * elfread.c (elfread_data): New typedef.
4800         (probe_key): Change type.
4801         (elf_get_probes): Likewise.  Update.
4802         (probe_key_free): Remove.
4803         (_initialize_elfread): Update.
4804         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4805         Change type.
4806         (dtrace_process_dof_probe, dtrace_process_dof)
4807         (dtrace_static_probe_ops::get_probe): Change type.
4808
4809 2019-05-08  Tom Tromey  <tom@tromey.com>
4810
4811         * xcoffread.c (struct xcoff_symfile_info): Rename from
4812         coff_symfile_info.  Add initializers.
4813         (xcoff_objfile_data_key): Move lower.  Change type.
4814         (XCOFF_DATA): Rewrite.
4815         (xcoff_free_info): Remove.
4816         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4817         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4818         (xcoff_initial_scan): Update.
4819
4820 2019-05-08  Tom Tromey  <tom@tromey.com>
4821
4822         * solib-svr4.c (struct svr4_info): Add initializers and
4823         destructor.
4824         <probes_table>: Now an htab_up.
4825         (solib_svr4_pspace_data): Change type.
4826         (free_probes_table): Simplify.
4827         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4828         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4829         (probes_table_remove_objfile_probes, register_solib_event_probe)
4830         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4831         (_initialize_svr4_solib): Update.
4832
4833 2019-05-08  Tom Tromey  <tom@tromey.com>
4834
4835         * remote.c (remote_pspace_data): Change type.
4836         (remote_pspace_data_cleanup): Remove.
4837         (get_remote_exec_file, set_pspace_remote_exec_file)
4838         (_initialize_remote): Update.
4839
4840 2019-05-08  Tom Tromey  <tom@tromey.com>
4841
4842         * breakpoint.c (breakpoint_objfile_key): Change type.
4843         (get_breakpoint_objfile_data): Update.
4844         (free_breakpoint_objfile_data): Remove.
4845         (_initialize_breakpoint): Update.
4846
4847 2019-05-08  Tom Tromey  <tom@tromey.com>
4848
4849         * linux-tdep.c (struct linux_info): Add initializers.
4850         (linux_inferior_data): Move.  Change type.
4851         (invalidate_linux_cache_inf): Update.
4852         (linux_inferior_data_cleanup): Remove.
4853         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4854
4855 2019-05-08  Tom Tromey  <tom@tromey.com>
4856
4857         * auxv.c (auxv_inferior_data): Move.  Change type.
4858         (auxv_inferior_data_cleanup): Remove.
4859         (invalidate_auxv_cache_inf): Rewrite.
4860         (get_auxv_inferior_data, _initialize_auxv): Update.
4861
4862 2019-05-08  Tom Tromey  <tom@tromey.com>
4863
4864         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4865         (symfile_debug_objfile_data_key): Change type.
4866         (symfile_debug_installed, debug_qf_has_symbols)
4867         (debug_qf_find_last_source_symtab)
4868         (debug_qf_forget_cached_source_info)
4869         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4870         (debug_qf_print_stats, debug_qf_dump)
4871         (debug_qf_expand_symtabs_for_function)
4872         (debug_qf_expand_all_symtabs)
4873         (debug_qf_expand_symtabs_with_fullname)
4874         (debug_qf_map_matching_symbols)
4875         (debug_qf_expand_symtabs_matching)
4876         (debug_qf_find_pc_sect_compunit_symtab)
4877         (debug_qf_map_symbol_filenames)
4878         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4879         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4880         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4881         (debug_sym_read_linetable, debug_sym_relocate): Update.
4882         (symfile_debug_free_objfile): Remove.
4883         (install_symfile_debug_logging, _initialize_symfile_debug):
4884         Update.
4885
4886 2019-05-08  Tom Tromey  <tom@tromey.com>
4887
4888         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4889         allocate_on_obstack.
4890         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4891         (get_dwarf2_per_objfile): Update.
4892         (set_dwarf2_per_objfile): Remove.
4893         (dwarf2_has_info, dwarf2_get_section_info): Update.
4894         (dwarf2_free_objfile): Remove.
4895         (_initialize_dwarf2_read): Update.
4896
4897 2019-05-08  Tom Tromey  <tom@tromey.com>
4898
4899         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4900         initializers.
4901         <unsupported_script_warning_printed,
4902         script_not_found_warning_printed>: Now bool.
4903         (auto_load_pspace_data): Change type.
4904         (~auto_load_pspace_info): Rename from
4905         auto_load_pspace_data_cleanup.
4906         (get_auto_load_pspace_data, init_loaded_scripts_info)
4907         (clear_section_scripts, maybe_print_unsupported_script_warning)
4908         (maybe_print_script_not_found_warning, _initialize_auto_load):
4909         Update.
4910
4911 2019-05-08  Tom Tromey  <tom@tromey.com>
4912
4913         * objfiles.c (objfile_pspace_info): Add destructor and
4914         initializers.
4915         (objfiles_pspace_data): Change type.
4916         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4917         (get_objfile_pspace_data): Update.
4918         (objfiles_bfd_data): Change type.
4919         (get_objfile_bfd_data): Update.
4920         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4921
4922 2019-05-08  Tom Tromey  <tom@tromey.com>
4923
4924         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4925         Change type.
4926         (get_catch_syscall_inferior_data): Update.
4927         (catch_syscall_inferior_data_cleanup): Remove.
4928         (_initialize_break_catch_syscall): Update.
4929
4930 2019-05-08  Tom Tromey  <tom@tromey.com>
4931
4932         * inflow.c (struct terminal_info): Add destructor and
4933         initializers.
4934         (inflow_inferior_data): Change type.
4935         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4936         (get_inflow_inferior_data, inflow_inferior_exit)
4937         (swap_terminal_info, _initialize_inflow): Update.
4938
4939 2019-05-08  Tom Tromey  <tom@tromey.com>
4940
4941         * target-dcache.c (target_dcache_cleanup): Remove.
4942         (target_dcache_aspace_key): Change type.
4943         (target_dcache_init_p, target_dcache_invalidate)
4944         (target_dcache_get, target_dcache_get_or_init)
4945         (_initialize_target_dcache): Update.
4946         * dcache.h (struct dcache_deleter): New.
4947
4948 2019-05-08  Tom Tromey  <tom@tromey.com>
4949
4950         * symtab.c (struct symbol_cache): Add destructor and
4951         initializers.
4952         (symbol_cache_key): Move.  Change type.
4953         (make_symbol_cache, free_symbol_cache): Remove.
4954         (get_symbol_cache): Update.
4955         (symbol_cache_cleanup): Remove.
4956         (ALL_PSPACES, symbol_cache_flush)
4957         (maintenance_print_symbol_cache)
4958         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4959         Update.
4960
4961 2019-05-08  Tom Tromey  <tom@tromey.com>
4962
4963         * symtab.c (struct main_info): Add destructor and initializers.
4964         (main_progspace_key): Move.  Change type.
4965         (get_main_info): Update.
4966         (main_info_cleanup): Remove.
4967         (_initialize_symtab): Update.
4968
4969 2019-05-08  Tom Tromey  <tom@tromey.com>
4970
4971         * registry.h (DECLARE_REGISTRY): Define the _key class.
4972
4973 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4974
4975         * NEWS: Merge two 'New commands' sections.
4976
4977 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4978
4979         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4980         parameter and use Ada language definition instead.
4981         (ada_val_print_ptr): Remove unused language parameter.
4982         (ada_val_print_num): Remove language parameter and use Ada language
4983         definition instead.
4984         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4985         parameter.
4986         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4987         parameter and use Ada language definition instead.
4988         (ada_val_print_1): Update all ada_val_print_xxx calls.
4989         Remove language parameter.
4990         (ada_val_print): Update ada_val_print_1 call.
4991
4992 2019-05-08  Tom Tromey  <tromey@adacore.com>
4993
4994         * remote.c (remote_hw_watchpoint_limit)
4995         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4996         Now static.
4997
4998 2019-05-08  Tom Tromey  <tromey@adacore.com>
4999
5000         * maint.c (_initialize_maint_cmds): Move initialization code to
5001         remote.c.
5002         (watchdog, show_watchdog): Move to remote.c.
5003         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5004         "watchdog" static.
5005         (_initialize_remote): Move initialization code from maint.c.
5006         * defs.h (watchdog): Don't declare.
5007
5008 2019-05-08  Tom Tromey  <tromey@adacore.com>
5009
5010         * tui/tui-interp.c: Include main.h.
5011         * interps.c: Include main.h.
5012         * main.h (interpreter_p): Declare.
5013         * defs.h (interpreter_p): Don't declare.
5014
5015 2019-05-08  Tom Tromey  <tromey@adacore.com>
5016
5017         * dwarf2loc.c: Include dwarf2read.h.
5018         * defs.h (read_unsigned_leb128): Don't declare.
5019         * dwarf2read.h (read_unsigned_leb128): Declare.
5020
5021 2019-05-08  Tom Tromey  <tromey@adacore.com>
5022
5023         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5024         method.
5025
5026 2019-05-08  Tom Tromey  <tromey@adacore.com>
5027
5028         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5029         when no wrap column is set.
5030
5031 2019-05-08  Tom Tromey  <tromey@adacore.com>
5032
5033         * c-lang.c (c_get_string): Handle non-C-style arrays.
5034
5035 2019-05-08  Tom Tromey  <tromey@adacore.com>
5036
5037         * typeprint.c (print_offset_data::update): Print the bit offset,
5038         not the number of bits remaining.
5039
5040 2019-05-08  Tom Tromey  <tromey@adacore.com>
5041
5042         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5043         padding at end of comment.
5044
5045 2019-05-08  Tom Tromey  <tromey@adacore.com>
5046
5047         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5048         Compare main types.
5049
5050 2019-05-06  Tom Tromey  <tom@tromey.com>
5051
5052         * common/scoped_mmap.c: Include common-defs.h.
5053         * common/scoped_mmap.h: Don't include config.h.
5054
5055 2019-05-04  Tom Tromey  <tom@tromey.com>
5056
5057         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5058         (struct aarch64_call_info): Add initializers.
5059         <si>: Now a std::vector.
5060         (pass_on_stack, aarch64_push_dummy_call): Update.
5061
5062 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5063             Tom Tromey  <tom@tromey.com>
5064
5065         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5066         (ppc_threads): Now a std::vector.  Now static.
5067         (hwdebug_find_thread_points_by_tid)
5068         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5069         Update.
5070
5071 2019-05-04  Tom Tromey  <tom@tromey.com>
5072
5073         * arc-tdep.c (arc_tdesc_init): Return bool.
5074
5075 2019-05-04  Tom Tromey  <tom@tromey.com>
5076
5077         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5078         Use gdb_assert_not_reached.
5079
5080 2019-05-04  Tom Tromey  <tom@tromey.com>
5081
5082         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5083         "false".
5084
5085 2019-05-04  Tom Tromey  <tom@tromey.com>
5086
5087         * arc-tdep.c (arc_tdesc_init): Use bool.
5088
5089 2019-05-04  Tom Tromey  <tom@tromey.com>
5090
5091         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5092
5093 2019-05-04  Tom Tromey  <tom@tromey.com>
5094
5095         * cli/cli-cmds.c (valid_command_p): Return bool.
5096
5097 2019-05-04  Tom Tromey  <tom@tromey.com>
5098
5099         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5100         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5101
5102 2019-05-04  Raul Tambre  <raul@tambre.ee>
5103
5104         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5105         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5106         operator for comparison.
5107
5108 2019-05-04  Tom Tromey  <tom@tromey.com>
5109
5110         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5111         (lookup_partial_symbol, print_partial_symbols)
5112         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5113         (psymbol_compare): Update.
5114         (add_psymbol_to_bcache): Clear the entire psymbol.
5115         (maintenance_check_psymtabs): Update.
5116         * psympriv.h (struct partial_symbol): Don't derive from
5117         general_symbol_info.
5118         <obj_section, unrelocated_address, address,
5119         set_unrelocated_address>: Update.
5120         <ginfo>: New member.
5121         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5122         (debug_names::write_psymbols): Update.
5123
5124 2019-05-04  Tom de Vries  <tdevries@suse.de>
5125
5126         * contrib/cc-with-tweaks.sh: Support -n arg.
5127
5128 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5129
5130         * corelow.c (core_target::detach): Ensure frame cache and
5131         register caches are cleared.
5132         inferior.c (exit_inferior_1): Likewise.
5133
5134 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5135             Tom Tromey  <tom@tromey.com>
5136
5137         * dictionary.c (collate_pending_symbols_by_language): Remove
5138         "struct" from foreach.
5139         * symtab.c (lookup_global_symbol_from_objfile)
5140         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5141         foreach.
5142         * ser-tcp.c (net_open): Remove "struct" from foreach.
5143         * objfiles.c (objfile_relocate, objfile_rebase)
5144         (objfile_has_symbols): Remove "struct" from foreach.
5145         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5146         from foreach.
5147         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5148         foreach.
5149         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5150         "struct" from foreach.
5151         * ada-lang.c (create_excep_cond_exprs)
5152         (ada_exception_catchpoint_cond_string): Remove "struct" from
5153         foreach.
5154
5155 2019-05-03  Tom Tromey  <tromey@adacore.com>
5156
5157         * ada-exp.y (convert_char_literal): Check suffix of each
5158         enumerator.
5159
5160 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5161
5162         PR ada/21406:
5163         * ada-exp.y (yywrap): Don't define.
5164         * ada-lex.l (%option): Add noyywrap
5165         (yywrap): Remove.
5166
5167 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5168
5169         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5170         _WIN32_WINNT to the XP level, unless already defined to a higher
5171         level.
5172
5173         * unittests/parse-connection-spec-selftests.c:
5174         * ser-tcp.c:
5175         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5176         override.
5177
5178         * symfile.c (find_separate_debug_file): Remove colon from the
5179         drive spec of DOS/Windows file names of the target, so that the
5180         file name produced from DEBUGDIR and the target's directory will
5181         be valid on DOS/Windows systems.
5182
5183 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5184
5185         * rust-lang.c (val_print_struct): Handle printing structures
5186         containing strings.
5187
5188 2019-05-02  Tom Tromey  <tromey@adacore.com>
5189
5190         * valarith.c (_initialize_valarith): Remove.
5191
5192 2019-05-01  Tom Tromey  <tromey@adacore.com>
5193
5194         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5195         bitfields.
5196
5197 2019-05-01  Tom Tromey  <tromey@adacore.com>
5198
5199         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5200         for big-endian copies.
5201
5202 2019-04-30  Ali Tamur  <tamur@google.com>
5203         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5204         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5205         (read_3_bytes): New function.
5206
5207 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5208
5209         * windows-nat.c (main_thread_id): Delete.
5210         (handle_output_debug_string): Replace main_thread_id by
5211         current_event.dwThreadId.
5212         (fake_create_process): Likewise.
5213         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5214         Do not set main_thread_id.
5215         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5216         current_event.dwThreadId.
5217         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5218
5219 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5220
5221         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5222         Use current_event.dwThreadId instead of main_thread_id.
5223
5224 2019-04-30  Tom Tromey  <tromey@adacore.com>
5225
5226         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5227         (create_excep_cond_exprs): Iterate over program spaces.
5228         (ada_exception_catchpoint_cond_string): Examine all minimal
5229         symbols for exception types.
5230
5231 2019-04-30  Tom Tromey  <tromey@adacore.com>
5232
5233         PR c++/24470:
5234         * dwarf2read.c (process_structure_scope): Handle case where type
5235         has template parameters but no symbol was created.
5236
5237 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5238             Chris January  <chris.january@arm.com>
5239
5240         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5241         qualifier.
5242         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5243
5244 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5245
5246         * f-typeprint.c (f_print_type): Update rules for printing
5247         whitespace.
5248         (f_type_print_varspec_suffix): Likewise.
5249
5250 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5251             Chris January  <chris.january@arm.com>
5252
5253         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5254         function arguments.
5255
5256 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5257
5258         * f-lang.c (build_fortran_types): Change name of void type to
5259         lower case.
5260         * f-typeprint.c (f_type_print_base): Print the name of the void
5261         type, rather than a fixed string.
5262         * f-valprint.c (f_decorations): Use lower case void string.
5263
5264 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5265             Chris January  <chris.january@arm.com>
5266
5267         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5268         types for Fortran.
5269
5270 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5271             Chris January  <chris.january@arm.com>
5272             David Lecomber  <david.lecomber@arm.com>
5273
5274         * f-exp.y (BINOP_INTRINSIC): New token.
5275         (exp): New parser rule handling BINOP_INTRINSIC.
5276         (f77_keywords): Add new builtin procedures.
5277         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5278         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5279         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5280         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5281         (print_unop_subexp_f): New function.
5282         (print_binop_subexp_f): New function.
5283         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5284         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5285         (dump_subexp_body_f): Likewise.
5286         (operator_check_f): Likewise.
5287         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5288         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5289
5290 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5291
5292         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5293         UNOP_KIND.
5294         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5295         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5296         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5297         (operator_length_f): New fuction.
5298         (print_subexp_f): New function.
5299         (op_name_f): New function.
5300         (dump_subexp_body_f): New function.
5301         (operator_check_f): New function.
5302         (exp_descriptor_f): Replace standard expression handling functions
5303         with new functions.
5304         * gdb/fortran-operator.def: New file.
5305         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5306         * gdb/std-operator.def: Remove UNOP_KIND.
5307
5308 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5309
5310         * std-operator.def: Remove unbalanced, stray double quote
5311         character.
5312
5313 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5314             Chris January  <chris.january@arm.com>
5315             Daniel Everett  <daniel.everett@arm.com>
5316             Nick Forrington  <nick.forrington@arm.com>
5317             Richard Bunt  <richard.bunt@arm.com>
5318
5319         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5320         of depth when printing anonymous structs or unions.
5321         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5322         Don't print either the top-level value, or the children if the
5323         max-depth is exceeded.
5324         (ppscm_print_children): When printing the key of a map, allow one
5325         extra level of depth.
5326         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5327         print either the top-level value, or the children if the max-depth
5328         is exceeded.
5329         (print_children): When printing the key of a map, allow one extra
5330         level of depth.
5331         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5332         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5333         (user_print_options): Initialise max_depth field.
5334         (val_print_scalar_or_string_type_p): New function.
5335         (val_print): Check to see if the max depth has been reached.
5336         (val_print_check_max_depth): Define new function.
5337         (show_print_max_depth): New function.
5338         (_initialize_valprint): Add 'print max-depth' option.
5339         * valprint.h (struct value_print_options) <max_depth>: New field.
5340         (val_print_check_max_depth): Declare new function.
5341         * NEWS: Document new feature.
5342
5343 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5344
5345         * ada-lang.c (ada_language_defn): Initialise new field.
5346         * c-lang.c (c_is_string_type_p): New function.
5347         (c_language_defn): Initialise new field.
5348         (cplus_language_defn): Initialise new field.
5349         (asm_language_defn): Initialise new field.
5350         (minimal_language_defn): Initialise new field.
5351         * c-lang.h (c_is_string_type_p): Declare new function.
5352         * d-lang.c (d_language_defn): Initialise new field.
5353         * f-lang.c (f_is_string_type_p): New function.
5354         (f_language_defn): Initialise new field.
5355         * go-lang.c (go_is_string_type_p): New function.
5356         (go_language_defn): Initialise new field.
5357         * language.c (default_is_string_type_p): New function.
5358         (unknown_language_defn): Initialise new field.
5359         (auto_language_defn): Initialise new field.
5360         * language.h (struct language_defn) <la_is_string_type_p>: New
5361         member variable.
5362         (default_is_string_type_p): Declare new function.
5363         * m2-lang.c (m2_language_defn): Initialise new field.
5364         * objc-lang.c (objc_language_defn): Initialise new field.
5365         * opencl-lang.c (opencl_language_defn): Initialise new field.
5366         * p-lang.c (pascal_is_string_type_p): New function.
5367         (pascal_language_defn): Initialise new field.
5368         * rust-lang.c (rust_is_string_type_p): New function.
5369         (rust_language_defn): Initialise new field.
5370
5371 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5372
5373         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5374         New field.
5375         * ada-lang.c (ada_language_defn): Initialise new field.
5376         * c-lang.c (c_language_defn): Likewise.
5377         (cplus_language_defn): Likewise.
5378         (asm_language_defn): Likewise.
5379         (minimal_language_defn): Likewise.
5380         * d-lang.c (d_language_defn): Likewise.
5381         * f-lang.c (f_language_defn): Likewise.
5382         * go-lang.c (go_language_defn): Likewise.
5383         * language.c (unknown_language_defn): Likewise.
5384         (auto_language_defn): Likewise.
5385         * m2-lang.c (m2_language_defn): Likewise.
5386         * objc-lang.c (objc_language_defn): Likewise.
5387         * opencl-lang.c (opencl_language_defn): Likewise.
5388         * p-lang.c (pascal_language_defn): Likewise.
5389         * rust-lang.c (rust_language_defn): Likewise.
5390
5391 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5392
5393         * ada-lang.c (ada_is_character_type): Change return type to bool.
5394         (ada_is_string_type): Likewise.
5395         * ada-lang.h (ada_is_character_type): Update declaration
5396         (ada_is_string_type): Likewise.
5397
5398 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5399
5400         Support style in 'frame|thread apply'
5401
5402         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5403         * record.c (record_start, record_stop): Update callers of
5404         execute_command_to_string with false.
5405         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5406         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5407         methods.
5408         (class string_file): New constructor with term_out parameter.
5409         Override methods term_out and can_emit_style_escape.  New member
5410         term_out.
5411         (class stdio_file): Override can_emit_style_escape.
5412         (class tee_file): Override term_out and can_emit_style_escape.
5413         * utils.h (can_emit_style_escape): Remove.
5414         * utils.c (can_emit_style_escape): Likewise.
5415         Update all callers of can_emit_style_escape (SOMESTREAM) to
5416         SOMESTREAM->can_emit_style_escape.
5417         * source-cache.c (source_cache::get_source_lines): Likewise.
5418         * stack.c (frame_apply_command_count): Call execute_command_to_string
5419         passing the term_out characteristic of the current gdb_stdout.
5420         * thread.c (thr_try_catch_cmd): Likewise.
5421         * top.c (execute_command_to_string): pass term_out parameter
5422         to construct the string_file for the command output.
5423         * ui-file.c (term_cli_styling): New function (most code moved
5424         from utils.c can_emit_style_escape).
5425         (string_file::string_file, string_file::can_emit_style_escape,
5426         stdio_file::can_emit_style_escape, tee_file::term_out,
5427         tee_file::can_emit_style_escape): New functions.
5428
5429 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5430
5431         * NEWS: Mention the new set|show may-call-functions.
5432         * infcall.c (may_call_functions_p): New variable.
5433         (show_may_call_functions_p): New function.
5434         (call_function_by_hand_dummy): Throws an error if not
5435         may-call-functions.
5436         (_initialize_infcall): Call add_setshow_boolean_cmd for
5437         may-call-functions.
5438
5439 2019-04-25  Keith Seitz  <keiths@redhat.com>
5440
5441         PR c++/24367
5442         * cp-support.c (inspect_type): Don't attempt substitutions
5443         of symbol with the same name.
5444
5445 2019-04-25  Tom Tromey  <tromey@adacore.com>
5446
5447         PR gdb/24475:
5448         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5449         static.
5450
5451 2019-04-25  Tom Tromey  <tromey@adacore.com>
5452
5453         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5454         rvalue reference.
5455         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5456         (gdb_xml_parser::parse): Use std::move.
5457         * python/python-internal.h (gdbpy_convert_exception): Take a const
5458         reference.
5459         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5460         std::move.
5461         * python/py-utils.c (gdbpy_convert_exception): Take a const
5462         reference.
5463         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5464         Use std::move.
5465         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5466         Use std::move.
5467         * mi/mi-main.c (mi_print_exception): Take a const reference.
5468         * main.c (handle_command_errors): Take a const reference.
5469         * linespec.c (parse_linespec): Use std::move.
5470         * infcall.c (run_inferior_call): Use std::move.
5471         (call_function_by_hand_dummy): Use std::move.
5472         * exec.c (try_open_exec_file): Use std::move.
5473         * exceptions.h (exception_print, exception_fprintf)
5474         (exception_print_same): Update.
5475         * exceptions.c (print_exception, exception_print)
5476         (exception_fprintf, exception_print_same): Change parameters to
5477         const reference.
5478         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5479         * common/new-op.c: Use std::move.
5480         * common/common-exceptions.h (struct gdb_exception): Add move
5481         constructor.
5482         (struct gdb_exception_error, struct gdb_exception_quit, struct
5483         gdb_quit_bad_alloc): Change constructor to move constructor.
5484         (throw_exception): Change parameter to rvalue reference.
5485         * common/common-exceptions.c (throw_exception): Take rvalue
5486         reference.
5487         * cli/cli-interp.c (safe_execute_command): Use std::move.
5488         * breakpoint.c (insert_bp_location, location_to_sals): Use
5489         std::move.
5490
5491 2019-04-25  Tom Tromey  <tromey@adacore.com>
5492
5493         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5494         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5495         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5496         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5497         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5498         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5499         guile/scm-value.c: Use unpack.
5500         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5501         gdbscm_gdb_exception.
5502         (gdbscm_throw_gdb_exception): Likewise.
5503         (struct gdbscm_gdb_exception): New.
5504         (unpack): New function.
5505         (gdbscm_wrap): Use unpack.
5506
5507 2019-04-25  Tom Tromey  <tromey@adacore.com>
5508
5509         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5510         (gdb_rl_callback_handler): Use std::move.
5511         * common/common-exceptions.h (struct gdb_exception): Add move
5512         assignment operator.
5513         (throw_exception_sjlj): Change "exception" to const reference.
5514         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5515         (throw_exception_sjlj): Change "exception" to const reference.
5516
5517 2019-04-25  Tom Tromey  <tromey@adacore.com>
5518
5519         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5520         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5521         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5522         Update.
5523         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5524         Update.
5525         * mi/mi-interp.c (mi_interp::exec): Update.
5526         * linespec.c (parse_linespec): Update.
5527         * infcall.c (run_inferior_call): Update.
5528         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5529         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5530         (gdbscm_lookup_global_symbol): Update.
5531         * guile/scm-param.c (gdbscm_parameter_value): Update.
5532         * guile/scm-frame.c (gdbscm_frame_read_register)
5533         (gdbscm_frame_read_var): Update.
5534         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5535         * exec.c (try_open_exec_file): Update.
5536         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5537         (gdb_rl_callback_handler): Update.
5538         * common/common-exceptions.h (exception_none): Don't declare.
5539         * common/common-exceptions.c (exception_none): Don't define.
5540         (struct catcher) <exception>: Update.
5541         * cli/cli-interp.c (safe_execute_command): Update.
5542         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5543
5544 2019-04-25  Ali Tamur  <tamur@google.com>
5545
5546         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5547         (read_attribute_value): Likewise.
5548         (dwarf2_read_addr_index): Update comment.
5549         (read_str_index): Add DW_FORM_strx.
5550         (dwarf2_string_attr): Likewise.
5551         (dwarf2_const_value_attr): Likewise.
5552         (dump_die_shallow): Likewise.
5553         (dwarf2_fetch_constant_bytes): Likewise.
5554         (skip_form_bytes): Likewise.
5555         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5556
5557 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5558
5559         PR corefiles/11608
5560         PR corefiles/18187
5561         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5562         OFFSET.  Verify if current mapping contains an ELF header.
5563         (linux_find_memory_regions_full): Adjust call to
5564         dump_mapping_p.
5565
5566 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5567             Kang Li <kanglictf@gmail.com>
5568
5569         PR gdb/21600
5570
5571         * dwarf2-frame.c (read_initial_length): Be consistent about using
5572         unsigned representation of length.
5573         (decode_frame_entry_1): Likewise.  Check for wraparound of
5574         end pointer as well as buffer overflow.
5575
5576 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5577
5578         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5579         "vq".
5580
5581 2019-04-24  Tom Tromey  <tromey@adacore.com>
5582
5583         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5584
5585 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5586
5587         * s12z-tdep.c (s12z_unwind_pc): Delete.
5588         (s12z_unwind_sp): Delete.
5589         (s12z_gdbarch_init): Don't register deleted functions with
5590         gdbarch.
5591
5592 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5593
5594         * rl78-tdep.c (rl78_unwind_sp): Delete.
5595         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5596
5597 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5598
5599         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5600         (xstormy16_unwind_pc): Delete.
5601         (xstormy16_dummy_id): Delete.
5602         (xstormy16_gdbarch_init): Don't register deleted functions with
5603         gdbarch.
5604
5605 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5606
5607         * vax-tdep.c (vax_unwind_pc): Delete.
5608         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5609
5610 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5611
5612         * v850-tdep.c (v850_unwind_sp): Delete.
5613         (v850_unwind_pc): Delete.
5614         (v850_dummy_id): Delete.
5615         (v850_gdbarch_init): Don't register deleted functions with
5616         gdbarch.
5617
5618 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5619
5620         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5621         (tilegx_unwind_pc): Delete.
5622         (tilegx_unwind_dummy_id): Delete.
5623         (tilegx_gdbarch_init): Don't register deleted functions with
5624         gdbarch.
5625
5626 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5627
5628         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5629         (tic6x_dummy_id): Delete.
5630         (tic6x_gdbarch_init): Don't register deleted functions with
5631         gdbarch.
5632
5633 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5634
5635         * sparc-tdep.c (sparc_unwind_pc): Delete.
5636         (sparc32_gdbarch_init): Don't register deleted function with
5637         gdbarch.
5638
5639 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5640
5641         * sh-tdep.c (sh_unwind_sp): Delete.
5642         (sh_unwind_pc): Delete.
5643         (sh_dummy_id): Delete.
5644         (sh_gdbarch_init): Don't register deleted functions with
5645         gdbarch.
5646
5647 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5648
5649         * score-tdep.c (score_unwind_sp): Delete.
5650         (score_unwind_pc): Delete.
5651         (score_dummy_id): Delete.
5652         (score_gdbarch_init): Don't register deleted functions with
5653         gdbarch.
5654
5655 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5656
5657         * rx-tdep.c (rx_unwind_pc): Delete.
5658         (rx_unwind_sp): Delete.
5659         (rx_dummy_id): Delete.
5660         (rx_gdbarch_init): Don't register deleted functions with
5661         gdbarch.  Update comment.
5662
5663 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5664
5665         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5666         (rs6000_dummy_id): Delete.
5667         (rs6000_gdbarch_init): Don't register deleted functions with
5668         gdbarch.
5669
5670 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5671
5672         * or1k-tdep.c (or1k_dummy_id): Delete.
5673         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5674
5675 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5676
5677         * nios2-tdep.c (nios2_dummy_id): Delete.
5678         (nios2_unwind_sp): Delete.
5679         (nios2_gdbarch_init): Don't register deleted functions with
5680         gdbarch.
5681
5682 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5683
5684         * nds32-tdep.c (nds32_dummy_id): Delete.
5685         (nds32_unwind_pc): Delete.
5686         (nds32_unwind_sp): Delete.
5687         (nds32_gdbarch_init): Don't register deleted functions with
5688         gdbarch.
5689
5690 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5691
5692         * msp430-tdep.c (msp430_unwind_pc): Delete.
5693         (msp430_unwind_sp): Delete.
5694         (msp430_dummy_id): Delete.
5695         (msp430_gdbarch_init): Don't register deleted functions with
5696         gdbarch.
5697
5698 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5699
5700         * moxie-tdep.c (moxie_unwind_sp): Delete.
5701         (moxie_unwind_pc): Delete.
5702         (moxie_dummy_id): Delete.
5703         (moxie_gdbarch_init): Don't register deleted functions with
5704         gdbarch.
5705
5706 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5707
5708         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5709         (mn10300_unwind_pc): Delete.
5710         (mn10300_unwind_sp): Delete.
5711         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5712         mn10300_unwind_sp.
5713         (mn10300_frame_unwind_init): Don't register deleted functions with
5714         gdbarch.
5715
5716 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5717
5718         * mep-tdep.c (mep_unwind_pc): Delete.
5719         (mep_unwind_sp): Delete.
5720         (mep_dummy_id): Delete.
5721         (mep_gdbarch_init): Don't register deleted functions with
5722         gdbarch.
5723
5724 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5725
5726         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5727         (m68hc11_unwind_sp): Delete.
5728         (m68hc11_gdbarch_init): Don't register deleted functions with
5729         gdbarch.
5730
5731 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5732
5733         * m32r-tdep.c (m32r_unwind_sp): Delete.
5734         (m32r_unwind_pc): Delete.
5735         (m32r_dummy_id): Delete.
5736         (m32r_gdbarch_init): Don't register deleted functions with
5737         gdbarch.
5738
5739 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5740
5741         * m32c-tdep.c (m32c_unwind_pc): Delete.
5742         (m32c_unwind_sp): Delete.
5743         (m32c_dummy_id): Delete.
5744         (m32c_gdbarch_init): Don't register deleted functions with
5745         gdbarch.
5746
5747 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5748
5749         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5750         (lm32_unwind_pc): Delete.
5751         (lm32_dummy_id): Delete.
5752         (lm32_gdbarch_init): Don't register deleted functions with
5753         gdbarch.
5754
5755 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5756
5757         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5758         (iq2000_unwind_pc): Delete.
5759         (iq2000_dummy_id): Delete.
5760         (iq2000_gdbarch_init): Don't register deleted functions with
5761         gdbarch.
5762
5763 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5764
5765         * nds32-tdep.c (nds32_type_align): Delete.
5766         (nds32_push_dummy_call): Use type_align instead.
5767
5768 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5769
5770         * arm-tdep.c (arm_type_align): Only handle vector override case.
5771         (arm_push_dummy_call): Use type_align.
5772         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5773
5774 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5775
5776         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5777         case.
5778         (pass_on_stack): Use type_align.
5779         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5780         function.
5781
5782 2019-04-23  Tom Tromey  <tromey@adacore.com>
5783
5784         * dwarf2read.c (line_header::file_name_at): Remove unused
5785         overload.
5786
5787 2019-04-23  Tom de Vries  <tdevries@suse.de>
5788
5789         PR gdb/24438
5790         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5791         invocation.
5792
5793
5794 2019-03-27  Ali Tamur  <tamur@google.com>
5795
5796         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5797         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5798         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5799         (dwarf_expr_context::get_addr_index): Likewise
5800         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5801         (symbol_needs_eval_context::get_addr_index): Likewise
5802         (disassemble_dwarf_expression): Add DW_OP_addrx
5803         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5804         (read_cutu_die_from_dwo): Update comment
5805         (skip_one_die): Add DW_FORM_addrx
5806         (read_attribute_value): Likewise
5807         (var_decode_location): Add DW_OP_addrx
5808         (dwarf2_const_value_attr): Add DW_FORM_addrx
5809         (dump_die_shallow): Likewise
5810         (dwarf2_fetch_constant_bytes): Likewise
5811         (decode_locdesc): Add DW_OP_addrx
5812         (skip_form_bytes): Add DW_FORM_addrx
5813
5814 2019-04-22  Ali Tamur  <tamur@google.com>
5815
5816         * MAINTAINERS (Write After Approval): Add self.
5817
5818 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5819
5820         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5821         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5822         (open_symbol_file_object): Likewise.
5823         (svr4_default_sos): Add info parameter.
5824         (svr4_read_so_list): Likewise.
5825         (svr4_current_sos_direct): Adjust functions calls to pass down
5826         info.
5827         (svr4_current_sos_1): Add info parameter.
5828         (svr4_current_sos): Call get_svr4_info, pass info down to
5829         svr4_current_sos_1.
5830         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5831         get_svr4_info.
5832         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5833         get_svr4_info.
5834         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5835         to get_svr4_info.
5836         (probes_table_remove_objfile_probes): Likewise.
5837         (register_solib_event_probe): Add info parameter.
5838         (solist_update_incremental): Pass info parameter down to
5839         svr4_read_so_list.
5840         (disable_probes_interface): Add info parameter.
5841         (svr4_handle_solib_event): Pass current_program_space to
5842         get_svr4_info.  Adjust disable_probes_interface cleanup.
5843         (svr4_create_probe_breakpoints): Add info parameter, pass it
5844         down to register_solib_event_probe.
5845         (svr4_create_solib_event_breakpoints): Add info parameter,
5846         pass it down to svr4_create_probe_breakpoints.
5847         (enable_break): Pass info down to
5848         svr4_create_solib_event_breakpoints.
5849         (svr4_solib_create_inferior_hook): Pass current_program_space to
5850         get_svr4_info.
5851         (svr4_clear_solib): Likewise.
5852
5853 2019-04-22  Pedro Alves  <palves@redhat.com>
5854
5855         * solib-svr4.c (svr4_free_objfile_observer): New.
5856         (probe_and_action::objfile): New field.
5857         (probes_table_htab_remove_objfile_probes)
5858         (probes_table_remove_objfile_probes): New functions.
5859         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5860         in the new probe_and_action.  Don't store the probe in 'lookup'.
5861         (svr4_create_probe_breakpoints): Pass objfile to
5862         register_solib_event_probe.
5863         (_initialize_svr4_solib): Register a free_objfile observer.
5864
5865 2019-04-19  Tom Tromey  <tom@tromey.com>
5866
5867         * common/queue.h: Remove.
5868
5869 2019-04-19  Tom Tromey  <tom@tromey.com>
5870
5871         * event-loop.c: Don't include "common/queue.h".
5872
5873 2019-04-19  Tom Tromey  <tom@tromey.com>
5874
5875         * remote.c (remote_target): Use delete.
5876         * remote-notif.h: Include <list>, not "common/queue.h".
5877         (notif_client_p): Remove typedef.
5878         (remote_notif_state): Add constructor, destructor, initializer.
5879         <notif_queue>: Now a std::list.
5880         (remote_notif_state_xfree): Don't declare.
5881         * remote-notif.c (remote_notif_process, handle_notification)
5882         (remote_notif_state_allocate): Update.
5883         (~remote_notif_state): Rename from remote_notif_state_xfree.
5884
5885 2019-04-19  Tom Tromey  <tom@tromey.com>
5886
5887         * symfile.c (reread_symbols): Update.
5888         * objfiles.c (objfile_register_static_link)
5889         (objfile_lookup_static_link): Update
5890         (~objfile) Don't delete static_links.
5891         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5892
5893 2019-04-19  Tom Tromey  <tom@tromey.com>
5894
5895         * type-stack.h (struct type_stack) <insert>: Constify string.
5896         * type-stack.c (type_stack::insert): Constify string.
5897         * gdbtypes.h (lookup_template_type): Update.
5898         (address_space_name_to_int): Update.
5899         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5900         const.
5901         (lookup_template_type): Make name const.
5902         * c-exp.y: Update rules.
5903         (lex_one_token, classify_name, classify_inner_name)
5904         (c_print_token): Update.
5905         * p-exp.y: Update rules.
5906         (yylex): Update.
5907         * f-exp.y: Update rules.
5908         (yylex): Update.
5909         * d-exp.y: Update rules.
5910         (lex_one_token, classify_name, classify_inner_name): Update.
5911         * parse.c (write_dollar_variable, copy_name): Return std::string.
5912         * parser-defs.h (copy_name): Change return type.
5913         * m2-exp.y: Update rules.
5914         (yylex): Update.
5915         * go-exp.y (lex_one_token): Update.
5916         Update rules.
5917         (classify_unsafe_function, classify_packaged_name)
5918         (classify_name, yylex): Update.
5919
5920 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5921
5922         * configure.ac: add --enable-source-highlight switch.
5923         * configure: Regenerate.
5924         * top.c (print_gdb_version): plumb --enable-source-highlight
5925         status to "show configuration".
5926
5927 2019-04-19  Tom Tromey  <tromey@adacore.com>
5928
5929         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5930         Check ADA_TYPE_P.
5931         (empty_record, ada_template_to_fixed_record_type_1)
5932         (template_to_static_fixed_type)
5933         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5934         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5935         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5936         macros.
5937
5938 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5939
5940         PR symtab/24423:
5941         * source.c (print_source_lines_base): Advance "iter" when a
5942         control character is seen.
5943
5944 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5945
5946         * inferior.h (struct infcall_suspend_state_deleter):
5947         Catch exception in destructor to avoid crash.
5948
5949 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5950
5951         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5952         close to the add_com "shell".
5953
5954 2019-04-18  Tom Tromey  <tromey@adacore.com>
5955
5956         * process-stratum-target.h (class process_stratum_target)
5957         <stratum>: Add "final".
5958
5959 2019-04-17  Tom Tromey  <tromey@adacore.com>
5960
5961         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5962         against nullptr before use.
5963
5964 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5965
5966         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5967
5968 2019-04-17  Jim Wilson  <jimw@sifive.com>
5969             Andrew Burgess  <andrew.burgess@embecosm.com>
5970
5971         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5972         code read might fail, assume 4-byte breakpoint in that case.
5973
5974 2019-04-15  Leszek Swirski  <leszeks@google.com>
5975
5976         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5977         rather than a hand-rolled POD check when checking for forced MEMORY
5978         classification.
5979
5980 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5981
5982         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5983         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5984         function.
5985         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5986         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5987         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5988         declaration.
5989
5990 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5991
5992         * aarch64-linux-nat.c
5993         (aarch64_linux_nat_target::thread_architecture): Add override.
5994         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5995         each VQ.
5996
5997 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5998
5999         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6000
6001 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6002
6003         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6004         target types of size 96-bits, add some additional comments, and
6005         check that the builtin type we found was the correct size.
6006
6007 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6008
6009         * utils.c (prompt_for_continue): Don't restore the styling at the
6010         end, as applied_style has the wrong value.  This fixes styling in
6011         long lists of file names that are interrupted by the "Continue?"
6012         prompt.
6013
6014 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6015
6016         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6017         * c-lang.c (c_language_defn): Likewise.
6018         (cplus_language_defn): Likewise.
6019         (asm_language_defn): Likewise.
6020         (minimal_language_defn): Likewise.
6021         * d-lang.c (d_language_defn): Likewise.
6022         * f-lang.c (f_language_defn): Likewise.
6023         * go-lang.c (go_language_defn): Likewise.
6024         * language.c (unknown_language_defn): Likewise.
6025         (auto_language_defn): Likewise.
6026         * language.h (struct language_defn): Remove la_magic field.
6027         (LANG_MAGIC): Delete.
6028         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6029         * objc-lang.c (objc_language_defn): Likewise.
6030         * opencl-lang.c (opencl_language_defn): Likewise.
6031         * p-lang.c (pascal_language_defn): Likewise.
6032         * rust-lang.c (rust_language_defn): Likewise.
6033
6034 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6035
6036         * riscv-tdep.c (riscv_type_align): New function.
6037         (riscv_type_alignment): Delete.
6038         (riscv_arg_location): Use 'type_align'.
6039         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6040
6041 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6042
6043         * gdbtypes.c (type_align): A struct with no non-static fields also
6044         has alignment of 1.
6045
6046 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6047
6048         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6049         component to 0.
6050         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6051         member.
6052         (riscv_struct_info::analyse): New implementation using new
6053         analyse_inner member function.
6054         (riscv_struct_info::field_offset): New member function.
6055         (riscv_struct_info::m_offsets): New member variable.
6056         (riscv_struct_info::analyse_inner): New private member function,
6057         takes the old implementation of riscv_struct_info::analyse but
6058         extended to track field offsets.
6059         (riscv_call_arg_struct): Update the struct folding special cases
6060         to handle cases where empty C++ structs, which are non-zero
6061         length, are found.
6062         (riscv_arg_location): Initialise the length of each location, a
6063         non-zero length now indicates the location is in use.
6064         (riscv_push_dummy_call): Allow for the first location having a
6065         non-zero offset when setting up arguments.
6066         (riscv_return_value): Likewise, but for return values.
6067
6068 2019-04-11  Tom Tromey  <tromey@adacore.com>
6069
6070         * utils.c (internal_vproblem): Make "msg" const.
6071
6072 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6073
6074         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6075         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6076         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6077         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6078
6079 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6080
6081         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6082         function.
6083         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6084         of amd64_collect_native_gregset.
6085         (amd64_linux_nat_target::store_registers): Likewise.
6086
6087 2019-04-10  Tom Tromey  <tom@tromey.com>
6088
6089         * symtab.c (lookup_global_symbol_from_objfile)
6090         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6091         * objfiles.h (class separate_debug_iterator): New.
6092         (class separate_debug_range): New.
6093         (struct objfile) <separate_debug_objfiles>: New method.
6094         (objfile_separate_debug_iterate): Don't declare.
6095         * objfiles.c (separate_debug_iterator::operator++): Rename from
6096         objfile_separate_debug_iterate.
6097         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6098         iterator.
6099         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6100         iterator.
6101
6102 2019-04-10  Tom Tromey  <tom@tromey.com>
6103
6104         * symfile.c (reread_symbols): Remove old comment.
6105         * objfiles.c (free_all_objfiles): Fix a typo.
6106
6107 2019-04-10  Tom Tromey  <tom@tromey.com>
6108
6109         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6110         * minsyms.c (lookup_minimal_symbol): Use foreach.
6111         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6112         (lookup_minimal_symbol_solib_trampoline): Likewise.
6113         * symfile.c (reread_symbols): Use foreach.
6114
6115 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6116             Tom Tromey  <tromey@adacore.com>
6117
6118         PR rust/24414:
6119         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6120         (rust_lex_int_test): Change "value" to be LONGEST.
6121         (rust_lex_tests): Add test for long integer literal.
6122
6123 2019-04-09  Tom Tromey  <tromey@adacore.com>
6124
6125         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6126         to bool.
6127         (extended_remote_target::attach): Update.
6128         (remote_target::remote_notice_new_inferior): Update.
6129         (remote_target::add_current_inferior_and_thread): Update.
6130         * inferior.c (exit_inferior_1): Use "false".
6131         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6132
6133 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6134
6135         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6136         the "start" command.
6137
6138 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6139
6140         * python/py-inferior.c (infpy_thread_from_thread_handle):
6141         Adjust comments to reflect renaming of thread_from_thread_handle
6142         to thread_from_handle.  Adjust keywords.  Fix type error message.
6143         (inferior_object_methods): Add thread_from_handle.  Retain
6144         thread_from_thread_handle, but mark it as deprecated.
6145
6146 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6147
6148         * gdbthread.h (find_thread_by_handle): Revise declaration.
6149         * thread.c (find_thread_by_handle): Likewise.  Adjust
6150         implementation too.
6151         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6152         support for buffer objects as handles.
6153
6154 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6155
6156         * python/py-infthread.c (thpy_thread_handle): New function.
6157         (thread_object_methods): Register thpy_thread_handle.
6158
6159 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6160
6161         * gdbthread.h (thread_to_thread_handle): Declare.
6162         * thread.c (gdbtypes.h): Include.
6163         (thread_to_thread_handle): New function.
6164
6165         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6166         (target_thread_info_to_thread_handle): Declare.
6167         * target.c (target_thread_info_to_thread_handle): New function.
6168         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6169         * target-delegates.c: Regenerate.
6170
6171         * linux-thread-db.c (class thread_db_target): Add method
6172         thread_info_to_thread_handle.
6173         (thread_db_target::thread_info_to_thread_handle): Define.
6174         * remote.c (class remote_target): Add new method
6175         thread_info_to_thread_handle.
6176         (remote_target::thread_info_to_thread_handle): Define.
6177
6178 2019-04-08  Pedro Alves  <palves@redhat.com>
6179
6180         * common/common-exceptions.c (throw_exception): Don't create
6181         named object to throw; throw directly.
6182         (throw_it): Likewise.  Don't initialize gdb_exception::message
6183         here, with new; pass FMT and AP to the ctor instead.
6184         * common/common-exceptions.h: Include <string>.
6185         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6186         const char *, va_list)): New ctor.  Use std::make_shared.
6187         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6188         errors)): Delete.
6189         (gdb_exception_error::gdb_exception_error(enum errors, const char
6190         *, va_list)): New.
6191         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6192         Add assertion.
6193         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6194         errors)): Delete.
6195         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6196         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6197         Add assertion.
6198
6199 2019-04-08  Tom Tromey  <tom@tromey.com>
6200
6201         * valops.c (value_rtti_indirect_type): Replace throw_exception
6202         with throw.
6203         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6204         with throw.
6205         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6206         throw.
6207         * target.c (target_translate_tls_address): Replace throw_exception
6208         with throw.
6209         * stack.c (frame_apply_command_count): Replace throw_exception
6210         with throw.
6211         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6212         throw.
6213         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6214         with throw.
6215         * rs6000-tdep.c (rs6000_frame_cache)
6216         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6217         * remote.c: Replace throw_exception with throw.
6218         * record-full.c (record_full_message, record_full_wait_1)
6219         (record_full_restore): Replace throw_exception with throw.
6220         * record-btrace.c:
6221         (get_thread_current_frame_id, record_btrace_start_replaying)
6222         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6223         (cmd_record_btrace_start): Replace throw_exception with throw.
6224         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6225         throw.
6226         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6227         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6228         * linespec.c:
6229         (find_linespec_symbols): Replace throw_exception with throw.
6230         * infrun.c (displaced_step_prepare, resume): Replace
6231         throw_exception with throw.
6232         * infcmd.c (post_create_inferior): Replace throw_exception with
6233         throw.
6234         * inf-loop.c (inferior_event_handler): Replace throw_exception
6235         with throw.
6236         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6237         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6238         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6239         (get_prev_frame_always, get_frame_pc_if_available)
6240         (get_frame_address_in_block_if_available, get_frame_language):
6241         Replace throw_exception with throw.
6242         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6243         throw_exception with throw.
6244         * eval.c (fetch_subexp_value, evaluate_var_value)
6245         (evaluate_funcall, evaluate_subexp_standard): Replace
6246         throw_exception with throw.
6247         * dwarf2loc.c (call_site_find_chain)
6248         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6249         Replace throw_exception with throw.
6250         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6251         with throw.
6252         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6253         throw.
6254         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6255         * completer.c (complete_line_internal): Replace throw_exception
6256         with throw.
6257         * compile/compile-object-run.c (compile_object_run): Replace
6258         throw_exception with throw.
6259         * cli/cli-script.c (process_next_line): Replace throw_exception
6260         with throw.
6261         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6262         (btrace_enable, btrace_maint_update_pt_packets): Replace
6263         throw_exception with throw.
6264         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6265         throw_exception with throw.
6266         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6267         throw_exception with throw.
6268         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6269         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6270         * aarch64-tdep.c (aarch64_make_prologue_cache)
6271         (aarch64_make_stub_cache): Replace throw_exception with throw.
6272
6273 2019-04-08  Tom Tromey  <tom@tromey.com>
6274
6275         * common/common-exceptions.c (throw_exception): Rename from
6276         throw_exception_cxx.  Remove old copy.  Make argument const.
6277         (throw_it): Create and throw exception objects directly.
6278         * common/common-exceptions.h (throw_exception): Make argument
6279         const.
6280         (struct gdb_exception_error): Add constructor.
6281         (struct gdb_exception_quit): Add constructor.
6282
6283 2019-04-08  Tom Tromey  <tom@tromey.com>
6284
6285         * common/common-exceptions.h (exception_rethrow): Don't declare.
6286         (TRY_SJLJ): Update comment.
6287         (TRY, CATCH, END_CATCH): Remove.
6288         * common/common-exceptions.c (exception_rethrow): Remove.
6289
6290 2019-04-08  Tom Tromey  <tom@tromey.com>
6291
6292         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6293         Remove.
6294         (gdb_exception_error): Rename from
6295         gdb_exception_RETURN_MASK_ERROR.
6296         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6297         (gdb_quit_bad_alloc): Update.
6298         * aarch64-tdep.c: Update.
6299         * ada-lang.c: Update.
6300         * ada-typeprint.c: Update.
6301         * ada-valprint.c: Update.
6302         * amd64-tdep.c: Update.
6303         * arch-utils.c: Update.
6304         * break-catch-throw.c: Update.
6305         * breakpoint.c: Update.
6306         * btrace.c: Update.
6307         * c-varobj.c: Update.
6308         * cli/cli-cmds.c: Update.
6309         * cli/cli-interp.c: Update.
6310         * cli/cli-script.c: Update.
6311         * common/common-exceptions.c: Update.
6312         * common/new-op.c: Update.
6313         * common/selftest.c: Update.
6314         * compile/compile-c-symbols.c: Update.
6315         * compile/compile-cplus-symbols.c: Update.
6316         * compile/compile-object-load.c: Update.
6317         * compile/compile-object-run.c: Update.
6318         * completer.c: Update.
6319         * corelow.c: Update.
6320         * cp-abi.c: Update.
6321         * cp-support.c: Update.
6322         * cp-valprint.c: Update.
6323         * darwin-nat.c: Update.
6324         * disasm-selftests.c: Update.
6325         * dtrace-probe.c: Update.
6326         * dwarf-index-cache.c: Update.
6327         * dwarf-index-write.c: Update.
6328         * dwarf2-frame-tailcall.c: Update.
6329         * dwarf2-frame.c: Update.
6330         * dwarf2loc.c: Update.
6331         * dwarf2read.c: Update.
6332         * eval.c: Update.
6333         * event-loop.c: Update.
6334         * event-top.c: Update.
6335         * exec.c: Update.
6336         * f-valprint.c: Update.
6337         * fbsd-tdep.c: Update.
6338         * frame-unwind.c: Update.
6339         * frame.c: Update.
6340         * gdbtypes.c: Update.
6341         * gnu-v3-abi.c: Update.
6342         * guile/guile-internal.h: Update.
6343         * guile/scm-block.c: Update.
6344         * guile/scm-breakpoint.c: Update.
6345         * guile/scm-cmd.c: Update.
6346         * guile/scm-disasm.c: Update.
6347         * guile/scm-frame.c: Update.
6348         * guile/scm-lazy-string.c: Update.
6349         * guile/scm-math.c: Update.
6350         * guile/scm-param.c: Update.
6351         * guile/scm-ports.c: Update.
6352         * guile/scm-pretty-print.c: Update.
6353         * guile/scm-symbol.c: Update.
6354         * guile/scm-symtab.c: Update.
6355         * guile/scm-type.c: Update.
6356         * guile/scm-value.c: Update.
6357         * i386-linux-tdep.c: Update.
6358         * i386-tdep.c: Update.
6359         * inf-loop.c: Update.
6360         * infcall.c: Update.
6361         * infcmd.c: Update.
6362         * infrun.c: Update.
6363         * jit.c: Update.
6364         * language.c: Update.
6365         * linespec.c: Update.
6366         * linux-fork.c: Update.
6367         * linux-nat.c: Update.
6368         * linux-tdep.c: Update.
6369         * linux-thread-db.c: Update.
6370         * main.c: Update.
6371         * mi/mi-cmd-break.c: Update.
6372         * mi/mi-cmd-stack.c: Update.
6373         * mi/mi-interp.c: Update.
6374         * mi/mi-main.c: Update.
6375         * objc-lang.c: Update.
6376         * p-valprint.c: Update.
6377         * parse.c: Update.
6378         * ppc-linux-tdep.c: Update.
6379         * printcmd.c: Update.
6380         * python/py-arch.c: Update.
6381         * python/py-breakpoint.c: Update.
6382         * python/py-cmd.c: Update.
6383         * python/py-finishbreakpoint.c: Update.
6384         * python/py-frame.c: Update.
6385         * python/py-framefilter.c: Update.
6386         * python/py-gdb-readline.c: Update.
6387         * python/py-inferior.c: Update.
6388         * python/py-infthread.c: Update.
6389         * python/py-lazy-string.c: Update.
6390         * python/py-linetable.c: Update.
6391         * python/py-objfile.c: Update.
6392         * python/py-param.c: Update.
6393         * python/py-prettyprint.c: Update.
6394         * python/py-progspace.c: Update.
6395         * python/py-record-btrace.c: Update.
6396         * python/py-record.c: Update.
6397         * python/py-symbol.c: Update.
6398         * python/py-type.c: Update.
6399         * python/py-unwind.c: Update.
6400         * python/py-utils.c: Update.
6401         * python/py-value.c: Update.
6402         * python/python.c: Update.
6403         * record-btrace.c: Update.
6404         * record-full.c: Update.
6405         * remote-fileio.c: Update.
6406         * remote.c: Update.
6407         * riscv-tdep.c: Update.
6408         * rs6000-aix-tdep.c: Update.
6409         * rs6000-tdep.c: Update.
6410         * rust-exp.y: Update.
6411         * rust-lang.c: Update.
6412         * s390-tdep.c: Update.
6413         * selftest-arch.c: Update.
6414         * solib-dsbt.c: Update.
6415         * solib-frv.c: Update.
6416         * solib-spu.c: Update.
6417         * solib-svr4.c: Update.
6418         * solib.c: Update.
6419         * sparc64-linux-tdep.c: Update.
6420         * stack.c: Update.
6421         * symfile-mem.c: Update.
6422         * symmisc.c: Update.
6423         * target.c: Update.
6424         * thread.c: Update.
6425         * top.c: Update.
6426         * tracefile-tfile.c: Update.
6427         * tui/tui.c: Update.
6428         * typeprint.c: Update.
6429         * unittests/cli-utils-selftests.c: Update.
6430         * unittests/parse-connection-spec-selftests.c: Update.
6431         * valops.c: Update.
6432         * valprint.c: Update.
6433         * value.c: Update.
6434         * varobj.c: Update.
6435         * windows-nat.c: Update.
6436         * x86-linux-nat.c: Update.
6437         * xml-support.c: Update.
6438
6439 2019-04-08  Tom Tromey  <tom@tromey.com>
6440
6441         * xml-support.c: Use C++ exception handling.
6442         * x86-linux-nat.c: Use C++ exception handling.
6443         * windows-nat.c: Use C++ exception handling.
6444         * varobj.c: Use C++ exception handling.
6445         * value.c: Use C++ exception handling.
6446         * valprint.c: Use C++ exception handling.
6447         * valops.c: Use C++ exception handling.
6448         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6449         handling.
6450         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6451         * typeprint.c: Use C++ exception handling.
6452         * tui/tui.c: Use C++ exception handling.
6453         * tracefile-tfile.c: Use C++ exception handling.
6454         * top.c: Use C++ exception handling.
6455         * thread.c: Use C++ exception handling.
6456         * target.c: Use C++ exception handling.
6457         * symmisc.c: Use C++ exception handling.
6458         * symfile-mem.c: Use C++ exception handling.
6459         * stack.c: Use C++ exception handling.
6460         * sparc64-linux-tdep.c: Use C++ exception handling.
6461         * solib.c: Use C++ exception handling.
6462         * solib-svr4.c: Use C++ exception handling.
6463         * solib-spu.c: Use C++ exception handling.
6464         * solib-frv.c: Use C++ exception handling.
6465         * solib-dsbt.c: Use C++ exception handling.
6466         * selftest-arch.c: Use C++ exception handling.
6467         * s390-tdep.c: Use C++ exception handling.
6468         * rust-lang.c: Use C++ exception handling.
6469         * rust-exp.y: Use C++ exception handling.
6470         * rs6000-tdep.c: Use C++ exception handling.
6471         * rs6000-aix-tdep.c: Use C++ exception handling.
6472         * riscv-tdep.c: Use C++ exception handling.
6473         * remote.c: Use C++ exception handling.
6474         * remote-fileio.c: Use C++ exception handling.
6475         * record-full.c: Use C++ exception handling.
6476         * record-btrace.c: Use C++ exception handling.
6477         * python/python.c: Use C++ exception handling.
6478         * python/py-value.c: Use C++ exception handling.
6479         * python/py-utils.c: Use C++ exception handling.
6480         * python/py-unwind.c: Use C++ exception handling.
6481         * python/py-type.c: Use C++ exception handling.
6482         * python/py-symbol.c: Use C++ exception handling.
6483         * python/py-record.c: Use C++ exception handling.
6484         * python/py-record-btrace.c: Use C++ exception handling.
6485         * python/py-progspace.c: Use C++ exception handling.
6486         * python/py-prettyprint.c: Use C++ exception handling.
6487         * python/py-param.c: Use C++ exception handling.
6488         * python/py-objfile.c: Use C++ exception handling.
6489         * python/py-linetable.c: Use C++ exception handling.
6490         * python/py-lazy-string.c: Use C++ exception handling.
6491         * python/py-infthread.c: Use C++ exception handling.
6492         * python/py-inferior.c: Use C++ exception handling.
6493         * python/py-gdb-readline.c: Use C++ exception handling.
6494         * python/py-framefilter.c: Use C++ exception handling.
6495         * python/py-frame.c: Use C++ exception handling.
6496         * python/py-finishbreakpoint.c: Use C++ exception handling.
6497         * python/py-cmd.c: Use C++ exception handling.
6498         * python/py-breakpoint.c: Use C++ exception handling.
6499         * python/py-arch.c: Use C++ exception handling.
6500         * printcmd.c: Use C++ exception handling.
6501         * ppc-linux-tdep.c: Use C++ exception handling.
6502         * parse.c: Use C++ exception handling.
6503         * p-valprint.c: Use C++ exception handling.
6504         * objc-lang.c: Use C++ exception handling.
6505         * mi/mi-main.c: Use C++ exception handling.
6506         * mi/mi-interp.c: Use C++ exception handling.
6507         * mi/mi-cmd-stack.c: Use C++ exception handling.
6508         * mi/mi-cmd-break.c: Use C++ exception handling.
6509         * main.c: Use C++ exception handling.
6510         * linux-thread-db.c: Use C++ exception handling.
6511         * linux-tdep.c: Use C++ exception handling.
6512         * linux-nat.c: Use C++ exception handling.
6513         * linux-fork.c: Use C++ exception handling.
6514         * linespec.c: Use C++ exception handling.
6515         * language.c: Use C++ exception handling.
6516         * jit.c: Use C++ exception handling.
6517         * infrun.c: Use C++ exception handling.
6518         * infcmd.c: Use C++ exception handling.
6519         * infcall.c: Use C++ exception handling.
6520         * inf-loop.c: Use C++ exception handling.
6521         * i386-tdep.c: Use C++ exception handling.
6522         * i386-linux-tdep.c: Use C++ exception handling.
6523         * guile/scm-value.c: Use C++ exception handling.
6524         * guile/scm-type.c: Use C++ exception handling.
6525         * guile/scm-symtab.c: Use C++ exception handling.
6526         * guile/scm-symbol.c: Use C++ exception handling.
6527         * guile/scm-pretty-print.c: Use C++ exception handling.
6528         * guile/scm-ports.c: Use C++ exception handling.
6529         * guile/scm-param.c: Use C++ exception handling.
6530         * guile/scm-math.c: Use C++ exception handling.
6531         * guile/scm-lazy-string.c: Use C++ exception handling.
6532         * guile/scm-frame.c: Use C++ exception handling.
6533         * guile/scm-disasm.c: Use C++ exception handling.
6534         * guile/scm-cmd.c: Use C++ exception handling.
6535         * guile/scm-breakpoint.c: Use C++ exception handling.
6536         * guile/scm-block.c: Use C++ exception handling.
6537         * guile/guile-internal.h: Use C++ exception handling.
6538         * gnu-v3-abi.c: Use C++ exception handling.
6539         * gdbtypes.c: Use C++ exception handling.
6540         * frame.c: Use C++ exception handling.
6541         * frame-unwind.c: Use C++ exception handling.
6542         * fbsd-tdep.c: Use C++ exception handling.
6543         * f-valprint.c: Use C++ exception handling.
6544         * exec.c: Use C++ exception handling.
6545         * event-top.c: Use C++ exception handling.
6546         * event-loop.c: Use C++ exception handling.
6547         * eval.c: Use C++ exception handling.
6548         * dwarf2read.c: Use C++ exception handling.
6549         * dwarf2loc.c: Use C++ exception handling.
6550         * dwarf2-frame.c: Use C++ exception handling.
6551         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6552         * dwarf-index-write.c: Use C++ exception handling.
6553         * dwarf-index-cache.c: Use C++ exception handling.
6554         * dtrace-probe.c: Use C++ exception handling.
6555         * disasm-selftests.c: Use C++ exception handling.
6556         * darwin-nat.c: Use C++ exception handling.
6557         * cp-valprint.c: Use C++ exception handling.
6558         * cp-support.c: Use C++ exception handling.
6559         * cp-abi.c: Use C++ exception handling.
6560         * corelow.c: Use C++ exception handling.
6561         * completer.c: Use C++ exception handling.
6562         * compile/compile-object-run.c: Use C++ exception handling.
6563         * compile/compile-object-load.c: Use C++ exception handling.
6564         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6565         * compile/compile-c-symbols.c: Use C++ exception handling.
6566         * common/selftest.c: Use C++ exception handling.
6567         * common/new-op.c: Use C++ exception handling.
6568         * cli/cli-script.c: Use C++ exception handling.
6569         * cli/cli-interp.c: Use C++ exception handling.
6570         * cli/cli-cmds.c: Use C++ exception handling.
6571         * c-varobj.c: Use C++ exception handling.
6572         * btrace.c: Use C++ exception handling.
6573         * breakpoint.c: Use C++ exception handling.
6574         * break-catch-throw.c: Use C++ exception handling.
6575         * arch-utils.c: Use C++ exception handling.
6576         * amd64-tdep.c: Use C++ exception handling.
6577         * ada-valprint.c: Use C++ exception handling.
6578         * ada-typeprint.c: Use C++ exception handling.
6579         * ada-lang.c: Use C++ exception handling.
6580         * aarch64-tdep.c: Use C++ exception handling.
6581
6582 2019-04-08  Tom Tromey  <tom@tromey.com>
6583
6584         * xml-support.c (gdb_xml_parser::parse): Update.
6585         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6586         * value.c (show_convenience): Update.
6587         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6588         (test_parse_flags_qcs): Update.
6589         * thread.c (thr_try_catch_cmd): Update.
6590         * target.c (target_translate_tls_address): Update.
6591         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6592         (info_frame_command_core, frame_apply_command_count): Update.
6593         * rust-exp.y (rust_lex_exception_test): Update.
6594         * riscv-tdep.c (riscv_print_one_register_info): Update.
6595         * remote.c (remote_target::enable_btrace): Update.
6596         * record-btrace.c (record_btrace_enable_warn): Update.
6597         * python/py-utils.c (gdbpy_convert_exception): Update.
6598         * printcmd.c (do_one_display, print_variable_and_value): Update.
6599         * mi/mi-main.c (mi_print_exception): Update.
6600         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6601         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6602         * linux-nat.c (linux_nat_target::attach): Update.
6603         * linux-fork.c (class scoped_switch_fork_info): Update.
6604         * infrun.c (displaced_step_prepare): Update.
6605         * infcall.c (call_function_by_hand_dummy): Update.
6606         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6607         * gnu-v3-abi.c (print_one_vtable): Update.
6608         * frame.c (get_prev_frame_always): Update.
6609         * f-valprint.c (info_common_command_for_block): Update.
6610         * exec.c (try_open_exec_file): Update.
6611         * exceptions.c (print_exception, exception_print)
6612         (exception_fprintf, exception_print_same): Update.
6613         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6614         * dwarf-index-cache.c (index_cache::store)
6615         (index_cache::lookup_gdb_index): Update.
6616         * darwin-nat.c (maybe_cache_shell): Update.
6617         * cp-valprint.c (cp_print_value_fields): Update.
6618         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6619         (gcc_cplus_symbol_address): Update.
6620         * compile/compile-c-symbols.c (gcc_convert_symbol)
6621         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6622         * common/selftest.c: Update.
6623         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6624         a std::string.
6625         (exception_try_scope_entry, exception_try_scope_exit): Don't
6626         declare.
6627         (struct exception_try_scope): Remove.
6628         (TRY): Don't use exception_try_scope.
6629         (struct gdb_exception): Add constructor, operator=.
6630         <what>: New method.
6631         (struct gdb_exception_RETURN_MASK_ALL)
6632         (struct gdb_exception_RETURN_MASK_ERROR)
6633         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6634         (struct gdb_quit_bad_alloc): Update.
6635         * common/common-exceptions.c (exception_none): Change
6636         initializer.
6637         (struct catcher) <state, exception>: Initialize inline.
6638         <prev>: Remove member.
6639         (current_catcher): Remove.
6640         (catchers): New global.
6641         (exceptions_state_mc_init): Simplify.
6642         (catcher_pop): Remove.
6643         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6644         (try_scope_depth, exception_try_scope_entry)
6645         (exception_try_scope_exit): Remove.
6646         (throw_exception_sjlj): Update.
6647         (exception_messages, exception_messages_size): Remove.
6648         (throw_it): Simplify.
6649         (gdb_exception_sliced_copy): Remove.
6650         (throw_exception_cxx): Update.
6651         * cli/cli-script.c (script_from_file): Update.
6652         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6653         Update.
6654         * ada-valprint.c (ada_val_print): Update.
6655         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6656         (create_excep_cond_exprs): Update.
6657
6658 2019-04-08  Tom Tromey  <tom@tromey.com>
6659
6660         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6661         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6662         (TRY, CATCH, END_CATCH): Remove some definitions.
6663         * common/common-exceptions.c: Don't use GDB_XCPT.
6664         (catcher_list_size): Remove.
6665         (throw_exception, throw_it): Simplify.
6666
6667 2019-04-05  Tom Tromey  <tom@tromey.com>
6668
6669         Revert the header-sorting patch.
6670         * ft32-tdep.c: Revert.
6671         * frv-tdep.c: Revert.
6672         * frv-linux-tdep.c: Revert.
6673         * frame.c: Revert.
6674         * frame-unwind.c: Revert.
6675         * frame-base.c: Revert.
6676         * fork-child.c: Revert.
6677         * findvar.c: Revert.
6678         * findcmd.c: Revert.
6679         * filesystem.c: Revert.
6680         * filename-seen-cache.h: Revert.
6681         * filename-seen-cache.c: Revert.
6682         * fbsd-tdep.c: Revert.
6683         * fbsd-nat.h: Revert.
6684         * fbsd-nat.c: Revert.
6685         * f-valprint.c: Revert.
6686         * f-typeprint.c: Revert.
6687         * f-lang.c: Revert.
6688         * extension.h: Revert.
6689         * extension.c: Revert.
6690         * extension-priv.h: Revert.
6691         * expprint.c: Revert.
6692         * exec.h: Revert.
6693         * exec.c: Revert.
6694         * exceptions.c: Revert.
6695         * event-top.c: Revert.
6696         * event-loop.c: Revert.
6697         * eval.c: Revert.
6698         * elfread.c: Revert.
6699         * dwarf2read.h: Revert.
6700         * dwarf2read.c: Revert.
6701         * dwarf2loc.c: Revert.
6702         * dwarf2expr.h: Revert.
6703         * dwarf2expr.c: Revert.
6704         * dwarf2-frame.c: Revert.
6705         * dwarf2-frame-tailcall.c: Revert.
6706         * dwarf-index-write.h: Revert.
6707         * dwarf-index-write.c: Revert.
6708         * dwarf-index-common.c: Revert.
6709         * dwarf-index-cache.h: Revert.
6710         * dwarf-index-cache.c: Revert.
6711         * dummy-frame.c: Revert.
6712         * dtrace-probe.c: Revert.
6713         * disasm.h: Revert.
6714         * disasm.c: Revert.
6715         * disasm-selftests.c: Revert.
6716         * dictionary.c: Revert.
6717         * dicos-tdep.c: Revert.
6718         * demangle.c: Revert.
6719         * dcache.h: Revert.
6720         * dcache.c: Revert.
6721         * darwin-nat.h: Revert.
6722         * darwin-nat.c: Revert.
6723         * darwin-nat-info.c: Revert.
6724         * d-valprint.c: Revert.
6725         * d-namespace.c: Revert.
6726         * d-lang.c: Revert.
6727         * ctf.c: Revert.
6728         * csky-tdep.c: Revert.
6729         * csky-linux-tdep.c: Revert.
6730         * cris-tdep.c: Revert.
6731         * cris-linux-tdep.c: Revert.
6732         * cp-valprint.c: Revert.
6733         * cp-support.c: Revert.
6734         * cp-namespace.c: Revert.
6735         * cp-abi.c: Revert.
6736         * corelow.c: Revert.
6737         * corefile.c: Revert.
6738         * continuations.c: Revert.
6739         * completer.h: Revert.
6740         * completer.c: Revert.
6741         * complaints.c: Revert.
6742         * coffread.c: Revert.
6743         * coff-pe-read.c: Revert.
6744         * cli-out.h: Revert.
6745         * cli-out.c: Revert.
6746         * charset.c: Revert.
6747         * c-varobj.c: Revert.
6748         * c-valprint.c: Revert.
6749         * c-typeprint.c: Revert.
6750         * c-lang.c: Revert.
6751         * buildsym.c: Revert.
6752         * buildsym-legacy.c: Revert.
6753         * build-id.h: Revert.
6754         * build-id.c: Revert.
6755         * btrace.c: Revert.
6756         * bsd-uthread.c: Revert.
6757         * breakpoint.h: Revert.
6758         * breakpoint.c: Revert.
6759         * break-catch-throw.c: Revert.
6760         * break-catch-syscall.c: Revert.
6761         * break-catch-sig.c: Revert.
6762         * blockframe.c: Revert.
6763         * block.c: Revert.
6764         * bfin-tdep.c: Revert.
6765         * bfin-linux-tdep.c: Revert.
6766         * bfd-target.c: Revert.
6767         * bcache.c: Revert.
6768         * ax-general.c: Revert.
6769         * ax-gdb.h: Revert.
6770         * ax-gdb.c: Revert.
6771         * avr-tdep.c: Revert.
6772         * auxv.c: Revert.
6773         * auto-load.c: Revert.
6774         * arm-wince-tdep.c: Revert.
6775         * arm-tdep.c: Revert.
6776         * arm-symbian-tdep.c: Revert.
6777         * arm-pikeos-tdep.c: Revert.
6778         * arm-obsd-tdep.c: Revert.
6779         * arm-nbsd-tdep.c: Revert.
6780         * arm-nbsd-nat.c: Revert.
6781         * arm-linux-tdep.c: Revert.
6782         * arm-linux-nat.c: Revert.
6783         * arm-fbsd-tdep.c: Revert.
6784         * arm-fbsd-nat.c: Revert.
6785         * arm-bsd-tdep.c: Revert.
6786         * arch-utils.c: Revert.
6787         * arc-tdep.c: Revert.
6788         * arc-newlib-tdep.c: Revert.
6789         * annotate.h: Revert.
6790         * annotate.c: Revert.
6791         * amd64-windows-tdep.c: Revert.
6792         * amd64-windows-nat.c: Revert.
6793         * amd64-tdep.c: Revert.
6794         * amd64-sol2-tdep.c: Revert.
6795         * amd64-obsd-tdep.c: Revert.
6796         * amd64-obsd-nat.c: Revert.
6797         * amd64-nbsd-tdep.c: Revert.
6798         * amd64-nbsd-nat.c: Revert.
6799         * amd64-nat.c: Revert.
6800         * amd64-linux-tdep.c: Revert.
6801         * amd64-linux-nat.c: Revert.
6802         * amd64-fbsd-tdep.c: Revert.
6803         * amd64-fbsd-nat.c: Revert.
6804         * amd64-dicos-tdep.c: Revert.
6805         * amd64-darwin-tdep.c: Revert.
6806         * amd64-bsd-nat.c: Revert.
6807         * alpha-tdep.c: Revert.
6808         * alpha-obsd-tdep.c: Revert.
6809         * alpha-nbsd-tdep.c: Revert.
6810         * alpha-mdebug-tdep.c: Revert.
6811         * alpha-linux-tdep.c: Revert.
6812         * alpha-linux-nat.c: Revert.
6813         * alpha-bsd-tdep.c: Revert.
6814         * alpha-bsd-nat.c: Revert.
6815         * aix-thread.c: Revert.
6816         * agent.c: Revert.
6817         * addrmap.c: Revert.
6818         * ada-varobj.c: Revert.
6819         * ada-valprint.c: Revert.
6820         * ada-typeprint.c: Revert.
6821         * ada-tasks.c: Revert.
6822         * ada-lang.c: Revert.
6823         * aarch64-tdep.c: Revert.
6824         * aarch64-ravenscar-thread.c: Revert.
6825         * aarch64-newlib-tdep.c: Revert.
6826         * aarch64-linux-tdep.c: Revert.
6827         * aarch64-linux-nat.c: Revert.
6828         * aarch64-fbsd-tdep.c: Revert.
6829         * aarch64-fbsd-nat.c: Revert.
6830         * aarch32-linux-nat.c: Revert.
6831
6832 2019-04-05  Tom Tromey  <tom@tromey.com>
6833
6834         * ft32-tdep.c: Sort headers.
6835         * frv-tdep.c: Sort headers.
6836         * frv-linux-tdep.c: Sort headers.
6837         * frame.c: Sort headers.
6838         * frame-unwind.c: Sort headers.
6839         * frame-base.c: Sort headers.
6840         * fork-child.c: Sort headers.
6841         * findvar.c: Sort headers.
6842         * findcmd.c: Sort headers.
6843         * filesystem.c: Sort headers.
6844         * filename-seen-cache.h: Sort headers.
6845         * filename-seen-cache.c: Sort headers.
6846         * fbsd-tdep.c: Sort headers.
6847         * fbsd-nat.h: Sort headers.
6848         * fbsd-nat.c: Sort headers.
6849         * f-valprint.c: Sort headers.
6850         * f-typeprint.c: Sort headers.
6851         * f-lang.c: Sort headers.
6852         * extension.h: Sort headers.
6853         * extension.c: Sort headers.
6854         * extension-priv.h: Sort headers.
6855         * expprint.c: Sort headers.
6856         * exec.h: Sort headers.
6857         * exec.c: Sort headers.
6858         * exceptions.c: Sort headers.
6859         * event-top.c: Sort headers.
6860         * event-loop.c: Sort headers.
6861         * eval.c: Sort headers.
6862         * elfread.c: Sort headers.
6863         * dwarf2read.h: Sort headers.
6864         * dwarf2read.c: Sort headers.
6865         * dwarf2loc.c: Sort headers.
6866         * dwarf2expr.h: Sort headers.
6867         * dwarf2expr.c: Sort headers.
6868         * dwarf2-frame.c: Sort headers.
6869         * dwarf2-frame-tailcall.c: Sort headers.
6870         * dwarf-index-write.h: Sort headers.
6871         * dwarf-index-write.c: Sort headers.
6872         * dwarf-index-common.c: Sort headers.
6873         * dwarf-index-cache.h: Sort headers.
6874         * dwarf-index-cache.c: Sort headers.
6875         * dummy-frame.c: Sort headers.
6876         * dtrace-probe.c: Sort headers.
6877         * disasm.h: Sort headers.
6878         * disasm.c: Sort headers.
6879         * disasm-selftests.c: Sort headers.
6880         * dictionary.c: Sort headers.
6881         * dicos-tdep.c: Sort headers.
6882         * demangle.c: Sort headers.
6883         * dcache.h: Sort headers.
6884         * dcache.c: Sort headers.
6885         * darwin-nat.h: Sort headers.
6886         * darwin-nat.c: Sort headers.
6887         * darwin-nat-info.c: Sort headers.
6888         * d-valprint.c: Sort headers.
6889         * d-namespace.c: Sort headers.
6890         * d-lang.c: Sort headers.
6891         * ctf.c: Sort headers.
6892         * csky-tdep.c: Sort headers.
6893         * csky-linux-tdep.c: Sort headers.
6894         * cris-tdep.c: Sort headers.
6895         * cris-linux-tdep.c: Sort headers.
6896         * cp-valprint.c: Sort headers.
6897         * cp-support.c: Sort headers.
6898         * cp-namespace.c: Sort headers.
6899         * cp-abi.c: Sort headers.
6900         * corelow.c: Sort headers.
6901         * corefile.c: Sort headers.
6902         * continuations.c: Sort headers.
6903         * completer.h: Sort headers.
6904         * completer.c: Sort headers.
6905         * complaints.c: Sort headers.
6906         * coffread.c: Sort headers.
6907         * coff-pe-read.c: Sort headers.
6908         * cli-out.h: Sort headers.
6909         * cli-out.c: Sort headers.
6910         * charset.c: Sort headers.
6911         * c-varobj.c: Sort headers.
6912         * c-valprint.c: Sort headers.
6913         * c-typeprint.c: Sort headers.
6914         * c-lang.c: Sort headers.
6915         * buildsym.c: Sort headers.
6916         * buildsym-legacy.c: Sort headers.
6917         * build-id.h: Sort headers.
6918         * build-id.c: Sort headers.
6919         * btrace.c: Sort headers.
6920         * bsd-uthread.c: Sort headers.
6921         * breakpoint.h: Sort headers.
6922         * breakpoint.c: Sort headers.
6923         * break-catch-throw.c: Sort headers.
6924         * break-catch-syscall.c: Sort headers.
6925         * break-catch-sig.c: Sort headers.
6926         * blockframe.c: Sort headers.
6927         * block.c: Sort headers.
6928         * bfin-tdep.c: Sort headers.
6929         * bfin-linux-tdep.c: Sort headers.
6930         * bfd-target.c: Sort headers.
6931         * bcache.c: Sort headers.
6932         * ax-general.c: Sort headers.
6933         * ax-gdb.h: Sort headers.
6934         * ax-gdb.c: Sort headers.
6935         * avr-tdep.c: Sort headers.
6936         * auxv.c: Sort headers.
6937         * auto-load.c: Sort headers.
6938         * arm-wince-tdep.c: Sort headers.
6939         * arm-tdep.c: Sort headers.
6940         * arm-symbian-tdep.c: Sort headers.
6941         * arm-pikeos-tdep.c: Sort headers.
6942         * arm-obsd-tdep.c: Sort headers.
6943         * arm-nbsd-tdep.c: Sort headers.
6944         * arm-nbsd-nat.c: Sort headers.
6945         * arm-linux-tdep.c: Sort headers.
6946         * arm-linux-nat.c: Sort headers.
6947         * arm-fbsd-tdep.c: Sort headers.
6948         * arm-fbsd-nat.c: Sort headers.
6949         * arm-bsd-tdep.c: Sort headers.
6950         * arch-utils.c: Sort headers.
6951         * arc-tdep.c: Sort headers.
6952         * arc-newlib-tdep.c: Sort headers.
6953         * annotate.h: Sort headers.
6954         * annotate.c: Sort headers.
6955         * amd64-windows-tdep.c: Sort headers.
6956         * amd64-windows-nat.c: Sort headers.
6957         * amd64-tdep.c: Sort headers.
6958         * amd64-sol2-tdep.c: Sort headers.
6959         * amd64-obsd-tdep.c: Sort headers.
6960         * amd64-obsd-nat.c: Sort headers.
6961         * amd64-nbsd-tdep.c: Sort headers.
6962         * amd64-nbsd-nat.c: Sort headers.
6963         * amd64-nat.c: Sort headers.
6964         * amd64-linux-tdep.c: Sort headers.
6965         * amd64-linux-nat.c: Sort headers.
6966         * amd64-fbsd-tdep.c: Sort headers.
6967         * amd64-fbsd-nat.c: Sort headers.
6968         * amd64-dicos-tdep.c: Sort headers.
6969         * amd64-darwin-tdep.c: Sort headers.
6970         * amd64-bsd-nat.c: Sort headers.
6971         * alpha-tdep.c: Sort headers.
6972         * alpha-obsd-tdep.c: Sort headers.
6973         * alpha-nbsd-tdep.c: Sort headers.
6974         * alpha-mdebug-tdep.c: Sort headers.
6975         * alpha-linux-tdep.c: Sort headers.
6976         * alpha-linux-nat.c: Sort headers.
6977         * alpha-bsd-tdep.c: Sort headers.
6978         * alpha-bsd-nat.c: Sort headers.
6979         * aix-thread.c: Sort headers.
6980         * agent.c: Sort headers.
6981         * addrmap.c: Sort headers.
6982         * ada-varobj.c: Sort headers.
6983         * ada-valprint.c: Sort headers.
6984         * ada-typeprint.c: Sort headers.
6985         * ada-tasks.c: Sort headers.
6986         * ada-lang.c: Sort headers.
6987         * aarch64-tdep.c: Sort headers.
6988         * aarch64-ravenscar-thread.c: Sort headers.
6989         * aarch64-newlib-tdep.c: Sort headers.
6990         * aarch64-linux-tdep.c: Sort headers.
6991         * aarch64-linux-nat.c: Sort headers.
6992         * aarch64-fbsd-tdep.c: Sort headers.
6993         * aarch64-fbsd-nat.c: Sort headers.
6994         * aarch32-linux-nat.c: Sort headers.
6995
6996 2019-04-04  Tom Tromey  <tom@tromey.com>
6997
6998         * varobj.c (varobj_create): Update.
6999         * rust-exp.y (struct rust_parser) <update_innermost_block,
7000         lookup_symbol>: New methods.
7001         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7002         Rename.
7003         (rust_parser::rust_lookup_type)
7004         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7005         * printcmd.c (display_command, do_one_display): Update.
7006         * parser-defs.h (struct parser_state) <parser_state>: Add
7007         "tracker" parameter.
7008         (block_tracker): New member.
7009         (class innermost_block_tracker) <innermost_block_tracker>: Add
7010         "types" parameter.
7011         <reset>: Remove method.
7012         (innermost_block): Don't declare.
7013         (null_post_parser): Update.
7014         * parse.c (innermost_block): Remove global.
7015         (write_dollar_variable): Update.
7016         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7017         Remove "tracker_types" parameter.
7018         (parse_expression): Add "tracker" parameter.
7019         (parse_expression_for_completion): Update.
7020         (null_post_parser): Add "tracker" parameter.
7021         * p-exp.y: Update rules.
7022         * m2-exp.y: Update rules.
7023         * language.h (struct language_defn) <la_post_parser>: Add
7024         "tracker" parameter.
7025         * go-exp.y: Update rules.
7026         * f-exp.y: Update rules.
7027         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7028         parameter.
7029         * d-exp.y: Update rules.
7030         * c-exp.y: Update rules.
7031         * breakpoint.c (set_breakpoint_condition): Create an
7032         innermost_block_tracker.
7033         (watch_command_1): Likewise.
7034         * ada-lang.c (resolve): Add "tracker" parameter.
7035         (resolve_subexp): Likewise.
7036         * ada-exp.y (write_var_from_sym): Update.
7037
7038 2019-04-04  Tom Tromey  <tom@tromey.com>
7039
7040         * type-stack.h: New file.
7041         * type-stack.c: New file.
7042         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7043         type-stack.h.
7044         (insert_into_type_stack, insert_type, push_type, push_type_int)
7045         (insert_type_address_space, pop_type, pop_type_int)
7046         (pop_typelist, pop_type_stack, append_type_stack)
7047         (push_type_stack, get_type_stack, push_typelist)
7048         (follow_type_instance_flags, follow_types): Don't declare.
7049         * parse.c (type_stack): Remove global.
7050         (parse_exp_in_context): Update.
7051         (insert_into_type_stack, insert_type, push_type, push_type_int)
7052         (insert_type_address_space, pop_type, pop_type_int)
7053         (pop_typelist, pop_type_stack, append_type_stack)
7054         (push_type_stack, get_type_stack, push_typelist)
7055         (follow_type_instance_flags, follow_types): Remove (moved to
7056         type-stack.c).
7057         * f-exp.y (type_stack): New global.
7058         Update rules.
7059         (push_kind_type, f_parse): Update.
7060         * d-exp.y (type_stack): New global.
7061         Update rules.
7062         (d_parse): Update.
7063         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7064         Update rules.
7065         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7066         (HFILES_NO_SRCDIR): Add type-stack.h.
7067
7068 2019-04-04  Tom Tromey  <tom@tromey.com>
7069
7070         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7071         (rust_parser::convert_ast_to_expression, rust_parse)
7072         (rust_lex_test_completion, rust_lex_tests): Update.
7073         * parser-defs.h (struct expr_completion_state): New.
7074         (struct parser_state) <parser_state>: Add completion parameter.
7075         <mark_struct_expression, mark_completion_tag>: New methods.
7076         <parse_completion, m_completion_state>: New members.
7077         (prefixify_expression, null_post_parser): Update.
7078         (mark_struct_expression, mark_completion_tag): Don't declare.
7079         * parse.c (parse_completion, expout_last_struct)
7080         (expout_tag_completion_type, expout_completion_name): Remove
7081         globals.
7082         (parser_state::mark_struct_expression)
7083         (parser_state::mark_completion_tag): Now methods.
7084         (prefixify_expression): Add last_struct parameter.
7085         (prefixify_subexp): Likewise.
7086         (parse_exp_1): Update.
7087         (parse_exp_in_context): Add cstate parameter.  Update.
7088         (parse_expression_for_completion): Create an
7089         expr_completion_state.
7090         (null_post_parser): Add "completion" parameter.
7091         * p-exp.y: Update rules.
7092         (yylex): Update.
7093         * language.h (struct language_defn) <la_post_parser>: Add
7094         "completing" parameter.
7095         * go-exp.y: Update rules.
7096         (lex_one_token): Update.
7097         * expression.h (parse_completion): Don't declare.
7098         * d-exp.y: Update rules.
7099         (lex_one_token): Update rules.
7100         * c-exp.y: Update rules.
7101         (lex_one_token): Update.
7102         * ada-lang.c (resolve): Add "parse_completion" parameter.
7103         (resolve_subexp): Likewise.
7104         (ada_resolve_function): Likewise.
7105
7106 2019-04-04  Tom Tromey  <tom@tromey.com>
7107
7108         * parser-defs.h (struct parser_state) <start_arglist,
7109         end_arglist>: New methods.
7110         <arglist_len, m_funcall_chain>: New members.
7111         (arglist_len, start_arglist, end_arglist): Don't declare.
7112         * parse.c (arglist_len, funcall_chain): Remove global.
7113         (start_arglist, end_arglist): Remove functions.
7114         (parse_exp_in_context): Update.
7115         * p-exp.y: Update rules.
7116         * m2-exp.y: Update rules.
7117         * go-exp.y: Update rules.
7118         * f-exp.y: Update rules.
7119         * d-exp.y: Update rules.
7120         * c-exp.y: Update rules.
7121
7122 2019-04-04  Tom Tromey  <tom@tromey.com>
7123
7124         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7125         lex_operator, push_back>: New methods.
7126         Update all rules.
7127         (rust_parser::lex_hex, lex_escape): Rename and update.
7128         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7129         (rust_parser::lex_operator): Rename and update.
7130         (rust_parser::lex_number, rustyylex, rustyyerror)
7131         (rust_lex_test_init, rust_lex_test_sequence)
7132         (rust_lex_test_push_back, rust_lex_tests): Update.
7133         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7134         parameter.
7135         <lexptr, prev_lexptr>: New members.
7136         (lexptr, prev_lexptr): Don't declare.
7137         * parse.c (lexptr, prev_lexptr): Remove globals.
7138         (parse_exp_in_context): Update.
7139         * p-exp.y (yylex, yyerror): Update.
7140         * m2-exp.y (parse_number, yylex, yyerror): Update.
7141         * go-exp.y (lex_one_token, yyerror): Update.
7142         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7143         * d-exp.y (lex_one_token, yyerror): Update.
7144         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7145         (lex_one_token, yyerror): Update.
7146         * ada-lex.l (YY_INPUT): Update.
7147         (rewind_to_char): Update.
7148         * ada-exp.y (yyerror): Update.
7149
7150 2019-04-04  Tom Tromey  <tom@tromey.com>
7151
7152         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7153         * parser-defs.h (struct parser_state) <parser_state>: Add new
7154         parameter.
7155         <comma_terminates>: New member.
7156         (comma_terminates): Don't declare global.
7157         * parse.c (comma_terminates): Remove global.
7158         (parse_exp_in_context): Update.
7159         * p-exp.y (yylex): Update.
7160         * m2-exp.y (yylex): Update.
7161         * go-exp.y (lex_one_token): Update.
7162         * f-exp.y (yylex): Update.
7163         * d-exp.y (lex_one_token): Update.
7164         * c-exp.y (lex_one_token): Update.
7165         * ada-lex.l: Update.
7166
7167 2019-04-04  Tom Tromey  <tom@tromey.com>
7168
7169         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7170         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7171         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7172         * parser-defs.h (paren_depth): Don't declare.
7173         * parse.c (paren_depth): Remove global.
7174         (parse_exp_in_context): Update.
7175         * p-exp.y (paren_depth): New global.
7176         (pascal_parse): Initialize it.
7177         * m2-exp.y (paren_depth): New global.
7178         (m2_parse): Initialize it.
7179         * go-exp.y (paren_depth): New global.
7180         (go_parse): Initialize it.
7181         * f-exp.y (paren_depth): New global.
7182         (f_parse): Initialize it.
7183         * d-exp.y (paren_depth): New global.
7184         (d_parse): Initialize it.
7185         * c-exp.y (paren_depth): New global.
7186         (c_parse): Initialize it.
7187         * ada-lex.l (paren_depth): New global.
7188         (lexer_init): Initialize it.
7189
7190 2019-04-04  Tom Tromey  <tom@tromey.com>
7191
7192         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7193         (rust_parser::convert_ast_to_type)
7194         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7195         * parser-defs.h (struct parser_state) <parser_state>: Add
7196         parameters.  Initialize new members.
7197         <expression_context_block, expression_context_pc>: New members.
7198         * parse.c (expression_context_block, expression_context_pc):
7199         Remove globals.
7200         (parse_exp_in_context): Update.
7201         * p-exp.y: Update all rules.
7202         (yylex): Update.
7203         * m2-exp.y: Update all rules.
7204         (yylex): Update.
7205         * go-exp.y (yylex): Update.
7206         * f-exp.y (yylex): Update.
7207         * d-exp.y: Update all rules.
7208         (yylex): Update.
7209         * c-exp.y: Update all rules.
7210         (lex_one_token, classify_name, yylex, c_parse): Update.
7211         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7212
7213 2019-04-04  Tom Tromey  <tom@tromey.com>
7214
7215         * gdbarch.h, gdbarch.c: Rebuild.
7216         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7217         * stap-probe.h:
7218         (struct stap_parse_info): Replace "parser_state" with
7219         "expr_builder".
7220         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7221         (parser_state): New class.
7222         * parse.c (expr_builder): Rename.
7223         (expr_builder::release): Rename.
7224         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7225         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7226         (write_exp_elt_longcst, write_exp_elt_floatcst)
7227         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7228         (write_exp_string_vector, write_exp_bitstring)
7229         (write_exp_msymbol, mark_struct_expression)
7230         (write_dollar_variable)
7231         (insert_type_address_space, increase_expout_size): Replace
7232         "parser_state" with "expr_builder".
7233         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7234         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7235         "parser_state" with "expr_builder".
7236
7237 2019-04-04  Tom Tromey  <tom@tromey.com>
7238
7239         * rust-exp.y: Replace "parse_language" with method call.
7240         * p-exp.y:
7241         (yylex): Replace "parse_language" with method call.
7242         * m2-exp.y:
7243         (yylex): Replace "parse_language" with method call.
7244         * go-exp.y (classify_name): Replace "parse_language" with method
7245         call.
7246         * f-exp.y (yylex): Replace "parse_language" with method call.
7247         * d-exp.y (lex_one_token): Replace "parse_language" with method
7248         call.
7249         * c-exp.y:
7250         (lex_one_token, classify_name, yylex): Replace "parse_language"
7251         with method call.
7252         * ada-exp.y (find_primitive_type, type_char)
7253         (type_system_address): Replace "parse_language" with method call.
7254
7255 2019-04-04  Tom Tromey  <tom@tromey.com>
7256
7257         * rust-exp.y: Replace "parse_gdbarch" with method call.
7258         * parse.c (write_dollar_variable, insert_type_address_space):
7259         Replace "parse_gdbarch" with method call.
7260         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7261         call.
7262         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7263         call.
7264         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7265         "parse_gdbarch" with method call.
7266         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7267         with method call.
7268         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7269         "parse_gdbarch" with method call.
7270         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7271         "parse_gdbarch" with method call.
7272         * c-exp.y (parse_type, parse_number, classify_name): Replace
7273         "parse_gdbarch" with method call.
7274         * ada-lex.l: Replace "parse_gdbarch" with method call.
7275         * ada-exp.y (parse_type, find_primitive_type, type_char)
7276         (type_system_address): Replace "parse_gdbarch" with method call.
7277
7278 2019-04-04  Tom Tromey  <tom@tromey.com>
7279
7280         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7281         * stap-probe.c (stap_parse_argument): Update.
7282         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7283         initial_size parameter.
7284         * rust-exp.y (rust_lex_tests): Update.
7285         * parse.c (parser_state): Update.
7286         (parse_exp_in_context): Update.
7287         * parser-defs.h (struct parser_state) <parser_state>: Remove
7288         "initial_size" parameter.
7289
7290 2019-04-04  Tom Tromey  <tom@tromey.com>
7291
7292         * parser-defs.h (increase_expout_size): Don't declare.
7293         * parse.c (increase_expout_size): Now static.
7294
7295 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7296
7297         * gnu-nat.c (gnu_nat_target::wait): Fix
7298         target_waitstatus_to_string call.
7299
7300 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7301
7302         * eval.c (evaluate_subexp_standard): Handle internal functions
7303         during Fortran function call handling.
7304
7305 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7306
7307         * NEWS: Mention new internal functions.
7308         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7309         (read_base_type): Use dwarf2_init_complex_target_type.
7310         * value.c (creal_internal_fn): New function.
7311         (cimag_internal_fn): New function.
7312         (_initialize_values): Register new internal functions.
7313
7314 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7315
7316         * infrun.c (stop_all_threads): If debug_infrun, always
7317         trace the wait status after wait_one, using
7318         target_waitstatus_to_string and target_pid_to_str.
7319         (handle_inferior_event): Replace various trace of
7320         wait status kind by a single trace.
7321         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7322         wait status kind image by target_waitstatus_to_string.
7323         * target/waitstatus.c (target_waitstatus_to_string): Fix
7324         obsolete comment.
7325
7326 2019-04-01  Tom Tromey  <tromey@adacore.com>
7327
7328         PR symtab/23331:
7329         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7330
7331 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7332             Pedro Alves  <palves@redhat.com>
7333
7334         * top.c (quit_force): Call 'finalize_values'.
7335         * value.c (finalize_values): New function.
7336         * value.h (finalize_values): Declare.
7337
7338 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7339
7340         * NEWS: Announce $_gdb_major and $_gdb_minor.
7341
7342         * top.c (init_gdb_version_vars): New function.
7343         (gdb_init): Call init_gdb_version_vars.
7344
7345 2019-03-29  Tom Tromey  <tromey@adacore.com>
7346
7347         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7348         help text.  Remove dead code.
7349
7350 2019-03-29  Keith Seitz  <keiths@redhat.com>
7351
7352         From Siddhesh Poyarekar:
7353         * f-lang.h (f77_get_upperbound): Return LONGEST.
7354         (f77_get_lowerbound): Likewise.
7355         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7356         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7357         print them.
7358         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7359         plongest to format print it.
7360         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7361         (f77_get_upperbound): Likewise.
7362         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7363         LOWER_BOUND to LONGEST.
7364         (f77_create_arrayprint_offset_tbl): Likewise.
7365
7366 2019-03-29  Keith Seitz  <keiths@redhat.com>
7367
7368         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7369         %s/pulongest for TYPE_LENGTH instead of %d in format
7370         strings.
7371         * ada-typerint.c (ada_print_type): Likewise.
7372         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7373         * compile/compile-c-support.c (generate_register_struct): Likewise.
7374         * gdbtypes.c (recursive_dump_type): Likewise.
7375         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7376         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7377         instead of %d in format strings.
7378         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7379         to std::min to ULONGEST.
7380         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7381         instead of %d in format strings.
7382         * tracepoint.c (info_scope_command): Likewise.
7383         * typeprint.c (print_offset_data::update)
7384         (print_offset_data::finish): Likewise.
7385         * xtensa-tdep.c (xtensa_store_return_value)
7386         (xtensa_push_dummy_call): Likewise.
7387
7388 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7389
7390         * windows-nat.c (display_selector): Fixed format specifications
7391         for 64-bit Cygwin.
7392
7393 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7394
7395         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7396
7397 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7398
7399         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7400         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7401         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7402         (nios2_linux_init_abi): Install it.
7403
7404 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7405
7406         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7407
7408 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7409
7410         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7411
7412 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7413             Tom Tromey  <tromey@adacore.com>
7414
7415         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7416
7417 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7418
7419         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7420         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7421         method to compute the bounds of range types. Also print "[evaluated]"
7422         if the bounds' values come from a dynamic evaluation.
7423
7424 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7425
7426         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7427         whitespace when pretty printing is on.
7428
7429 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7430
7431         * ppc-linux-nat.c: Add include.
7432
7433 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7434
7435         * NEWS: Mention AArch64 Pointer Authentication.
7436
7437 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7438
7439         * arm-linux-nat.c: Add include.
7440
7441 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7442
7443         * source-cache.c (source_cache::get_source_lines): Re-read
7444         fullname after calling open_source_file.
7445
7446 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7447
7448         * NEWS: Mention TLS support for FreeBSD.
7449
7450 2019-03-25  Tom Tromey  <tromey@adacore.com>
7451
7452         * minsyms.c (BUNCH_SIZE): Update comment.
7453         (~minimal_symbol_reader): Remove old comment.
7454         (compact_minimal_symbols): Update comment.
7455         (minimal_symbol_reader::install): Remove old comment.  Update
7456         other comments.
7457
7458 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7459
7460         * s390-linux-nat.c: Add include.
7461
7462 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7463
7464         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7465         Call linux_get_hwcap.
7466         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7467         Likewise.
7468         (aarch64_linux_get_hwcap): Remove function.
7469         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7470         declaration.
7471         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7472         linux_get_hwcap.
7473         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7474         * linux-tdep.c (linux_get_hwcap): Add function.
7475         (linux_get_hwcap2): Likewise.
7476         * linux-tdep.h (linux_get_hwcap): Add declaration.
7477         (linux_get_hwcap2): Likewise.
7478         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7479         (ppc_linux_get_hwcap2): Likewise.
7480         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7481         linux_get_hwcap.
7482         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7483         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7484         (ppc_linux_nat_target::read_description): Likewise.
7485         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7486         * s390-linux-nat.c: Likewise.
7487         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7488
7489 2019-03-24  Tom Tromey  <tom@tromey.com>
7490
7491         * ada-lang.c (standard_lookup): Simplify initialization.
7492         (ada_lookup_symbol_nonlocal): Simplify return.
7493         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7494         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7495         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7496         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7497         initialization.
7498         * solib.c (solib_global_lookup): Simplify.
7499         * symtab.c (null_block_symbol): Remove.
7500         (symbol_cache_lookup): Simplify returns.
7501         (lookup_language_this): Simplify returns.
7502         (lookup_symbol_aux): Simplify return.
7503         (lookup_local_symbol): Simplify returns.
7504         (lookup_global_symbol_from_objfile): Simplify return.
7505         (lookup_symbol_in_objfile_symtabs)
7506         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7507         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7508         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7509         * cp-namespace.c (cp_lookup_bare_symbol)
7510         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7511         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7512         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7513         (cp_lookup_symbol_via_imports): Simplify initialization.
7514         (find_symbol_in_baseclass): Likewise.
7515         * symtab.h (null_block_symbol): Remove.
7516         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7517         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7518         (d_lookup_symbol_module): Likewise.
7519         (find_symbol_in_baseclass): Simplify initialization.
7520
7521 2019-03-24  Tom Tromey  <tom@tromey.com>
7522
7523         * expression.h: Don't include symtab.h.
7524         (struct block): Forward declare.
7525
7526 2019-03-24  Tom Tromey  <tom@tromey.com>
7527
7528         * c-exp.y (typebase): Remove casts.
7529         * gdbtypes.c (lookup_unsigned_typename, )
7530         (lookup_signed_typename): Remove cast.
7531         * eval.c (parse_to_comma_and_eval): Remove cast.
7532         * parse.c (write_dollar_variable): Remove cast.
7533         * block.h (struct block) <superblock>: Now const.
7534         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7535         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7536         (map_block): Make "block" const.
7537         * symfile.h (struct quick_symbol_functions)
7538         <map_matching_symbols>: Constify block argument to "callback".
7539         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7540         const.
7541         (find_pc_sect_compunit_symtab): Make "b" const.
7542         (find_symbol_at_address): Likewise.
7543         (search_symbols): Likewise.
7544         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7545         (dw2_debug_names_lookup_symbol): Likewise.
7546         (dw2_map_matching_symbols): Update.
7547         * p-valprint.c (pascal_val_print): Remove "block".
7548         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7549         (aux_add_nonlocal_symbols): Make "block" const.
7550         (resolve_subexp): Remove cast.
7551         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7552         const.
7553         (iterate_over_file_blocks): Likewise.
7554         * f-exp.y (%union) <bval>: Remove.
7555         * coffread.c (patch_opaque_types): Make "b" const.
7556         * spu-tdep.c (spu_catch_start): Make "block" const.
7557         * c-valprint.c (print_unpacked_pointer): Remove "block".
7558         * symmisc.c (dump_symtab_1): Make "b" const.
7559         (block_depth): Make "block" const.
7560         * d-exp.y (%union) <bval>: Remove.
7561         * cp-support.h (cp_lookup_rtti_type): Update.
7562         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7563         * psymtab.c (psym_lookup_symbol): Make "block" const.
7564         (maintenance_check_psymtabs): Make "b" const.
7565         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7566         (enumerate_locals, enumerate_args): Update.
7567         * python/py-symtab.c (stpy_global_block): Make "block" const.
7568         (stpy_static_block): Likewise.
7569         * inline-frame.c (block_starting_point_at): Make "new_block"
7570         const.
7571         * block.c (find_block_in_blockvector): Make return type const.
7572         (blockvector_for_pc_sect): Make "b" const.
7573         (find_block_in_blockvector): Make "b" const.
7574
7575 2019-03-23  Tom Tromey  <tom@tromey.com>
7576
7577         * varobj.c (varobj_create): Update.
7578         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7579         * printcmd.c (display_command, do_one_display): Don't reset
7580         innermost_block.
7581         * parser-defs.h (enum innermost_block_tracker_type): Move to
7582         expression.h.
7583         (innermost_block): Update comment.
7584         * parse.c (parse_exp_1): Add tracker_types parameter.
7585         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7586         tracker_types parameter.  Reset innermost_block.
7587         (parse_exp_in_context): Remove.
7588         (parse_expression_for_completion): Update.
7589         * objfiles.c (~objfile): Don't reset expression_context_block or
7590         innermost_block.
7591         * expression.h (enum innermost_block_tracker_type): Move from
7592         parser-defs.h.
7593         (parse_exp_1): Add tracker_types parameter.
7594         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7595         reset innermost_block.
7596
7597 2019-03-23  Tom Tromey  <tom@tromey.com>
7598
7599         * objfiles.h: Include bcache.h.
7600
7601 2019-03-23  Tom Tromey  <tom@tromey.com>
7602
7603         * linespec.c (get_current_search_block): Use
7604         scoped_restore_current_language.
7605         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7606
7607 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7608             Jiong Wang  <jiong.wang@arm.com>
7609
7610         * aarch64-linux-tdep.c
7611         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7612         section.
7613         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7614
7615 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7616             Jiong Wang  <jiong.wang@arm.com>
7617
7618         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7619         instructions.
7620         (aarch64_analyze_prologue_test): Add PACIASP test.
7621         (aarch64_prologue_prev_register): Unmask PC value.
7622
7623 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7624             Jiong Wang  <jiong.wang@arm.com>
7625
7626         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7627         (aarch64_dwarf2_prev_register): Unmask PC value.
7628         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7629         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7630         DW_CFA_AARCH64_negate_ra_state.
7631         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7632
7633 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7634             Jiong Wang  <jiong.wang@arm.com>
7635
7636         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7637         registers.
7638         (aarch64_pseudo_register_name): Likewise.
7639         (aarch64_pseudo_register_type): Likewise.
7640         (aarch64_pseudo_register_reggroup_p): Likewise.
7641         (aarch64_gdbarch_init): Add pauth registers.
7642         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7643         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7644         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7645         (struct gdbarch_tdep): Add regnum for ra_state.
7646
7647 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7648             Jiong Wang  <jiong.wang@arm.com>
7649
7650         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7651
7652 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7653             Jiong Wang  <jiong.wang@arm.com>
7654
7655         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7656         function.
7657         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7658         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7659         (aarch64_gdbarch_init): Add puth registers.
7660         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7661         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7662         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7663
7664 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7665             Jiong Wang  <jiong.wang@arm.com>
7666
7667         * aarch64-linux-nat.c
7668         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7669         * aarch64-linux-tdep.c
7670         (aarch64_linux_core_read_description): Likewise.
7671         (aarch64_linux_get_hwcap): New function.
7672         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7673         (aarch64_linux_get_hwcap): New declaration.
7674
7675 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7676             Jiong Wang  <jiong.wang@arm.com>
7677
7678         * aarch64-linux-nat.c
7679         (aarch64_linux_nat_target::read_description): Add pauth param.
7680         * aarch64-linux-tdep.c
7681         (aarch64_linux_core_read_description): Likewise.
7682         * aarch64-tdep.c (struct target_desc): Add in pauth.
7683         (aarch64_read_description): Add pauth param.
7684         (aarch64_gdbarch_init): Likewise.
7685         * aarch64-tdep.h (aarch64_read_description): Likewise.
7686         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7687         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7688         * features/Makefile: Add new files.
7689         * features/aarch64-pauth.c: New file.
7690         * features/aarch64-pauth.xml: New file.
7691
7692 2019-03-20  Tom Tromey  <tromey@adacore.com>
7693
7694         * infrun.c (handle_inferior_event): Rename from
7695         handle_inferior_event_1.  Create a scoped_value_mark.
7696         (handle_inferior_event): Remove.
7697
7698 2019-03-19  Tom Tromey  <tromey@adacore.com>
7699
7700         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7701         * infrun.h (print_stop_event): Add "displays" parameter.
7702         * infrun.c (print_stop_event): Add "displays" parameter.
7703
7704 2019-03-19  Pedro Alves  <palves@redhat.com>
7705
7706         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7707         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7708         to -1.  Fix TABs vs spaces.
7709         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7710         * tui/tui-out.h (tui_ui_out) Add intro comments.
7711         <m_line, m_start_of_line>: In-class initialize, and add describing
7712         comment.
7713
7714 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7715
7716         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7717         variable names.
7718         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7719
7720 2019-03-18  Pedro Alves  <palves@redhat.com>
7721             Eli Zaretskii <eliz@gnu.org>
7722
7723         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7724         m_line and m_start_of_line.
7725
7726 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7727
7728         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7729         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7730         it returns a newline.  This fixes a regression in TU mode, whereby
7731         the next line is output on the same screen line as the user input.
7732
7733 2019-03-18  Tom Tromey  <tromey@adacore.com>
7734
7735         * minsyms.c (minimal_symbol_reader::install): Remove call to
7736         obstack_blank.
7737
7738 2019-03-18  Pedro Alves  <palves@redhat.com>
7739
7740         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7741         New globals.
7742         (apply_style): New, factored out from ...
7743         (apply_ansi_escape): ... this.  Handle reverse video mode.
7744         (tui_set_reverse_mode): New function.
7745         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7746         * tui/tui-winsource.c (tui_show_source_line): Use
7747         tui_set_reverse_mode instead of setting A_STANDOUT.
7748         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7749         New setter methods.
7750
7751 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7752
7753         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7754         Handle tabs.
7755
7756 2019-03-18  Tom Tromey  <tromey@adacore.com>
7757
7758         * ada-lang.c (empty_array): Add "high" parameter.
7759         (ada_evaluate_subexp): Update.
7760
7761 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7762
7763         * unittests/string_view-selftests.c: Define
7764         _initialize_string_view_selftests unconditionally.
7765
7766 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7767
7768         PR gdb/24350
7769         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7770
7771 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7772
7773         PR gdb/24351
7774         * windows-nat.c (display_selector): Fix format specifiers.
7775
7776 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7777
7778         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7779         tui_refill_source_window instead of tui_refresh_win, to update the
7780         current execution line.  This fixes redisplay of the current line
7781         when stepping through the code with "next" or "step".
7782
7783 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7784
7785         * source-cache.c (source_cache::get_source_lines): Call
7786         find_source_lines to initialize s->nlines.  This fixes vertical
7787         scrolling of TUI source window when the DOWN arrow is pressed.
7788
7789 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7790
7791         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7792         linux-thread-db.c (_initialize_thread_db): Likewise.
7793
7794 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7795
7796         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7797         wclrtoeol in tui_show_source_line".  This reverts changes made in
7798         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7799
7800 2019-03-15  Tom Tromey  <tom@tromey.com>
7801
7802         * symtab.h (struct minimal_symbol): Derive from
7803         general_symbol_info.
7804         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7805         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7806         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7807         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7808         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7809         (MSYMBOL_SEARCH_NAME): Update.
7810         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7811         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7812         * minsyms.c (minimal_symbol_reader::record_full): Update.
7813
7814 2019-03-15  Tom Tromey  <tom@tromey.com>
7815
7816         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7817
7818 2019-03-15  Tom Tromey  <tom@tromey.com>
7819
7820         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7821         unique_xmalloc_ptr.
7822         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7823         Update.
7824         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7825         (build_minimal_symbol_hash_tables)
7826         (minimal_symbol_reader::install): Update.
7827
7828 2019-03-15  Tom Tromey  <tom@tromey.com>
7829
7830         * symtab.c (create_demangled_names_hash): Update.
7831         (symbol_set_names): Update.
7832         * objfiles.h (struct objfile_per_bfd_storage)
7833         <demangled_names_hash>: Now an htab_up.
7834         * objfiles.c (objfile_per_bfd_storage): Simplify.
7835
7836 2019-03-15  Tom Tromey  <tom@tromey.com>
7837
7838         * objfiles.h (struct objfile_per_bfd_storage): Declare
7839         destructor.
7840         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7841         New.
7842         (get_objfile_bfd_data): Use new.  Don't initialize
7843         language_of_main.
7844         (free_objfile_per_bfd_storage): Remove.
7845         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7846
7847 2019-03-15  Tom Tromey  <tom@tromey.com>
7848
7849         * symfile.c (reread_symbols): Update.
7850         * objfiles.c (objfile::objfile): Update.
7851         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7852         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7853         comment.
7854         (minimal_symbol_reader::install): Update.
7855         (terminate_minimal_symbol_table): Remove.
7856         * jit.c (jit_object_close_impl): Update.
7857
7858 2019-03-15  Tom Tromey  <tom@tromey.com>
7859
7860         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7861         initializations.
7862
7863 2019-03-15  Tom Tromey  <tom@tromey.com>
7864
7865         * objfiles.h (struct objfile_per_bfd_storage)
7866         <demangled_hash_languages>: Now a bitset.
7867         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7868         (lookup_minimal_symbol): Update.
7869
7870 2019-03-15  Tom Tromey  <tom@tromey.com>
7871
7872         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7873         Don't return the symbol.
7874         * coffread.c (record_minimal_symbol): Use record_full.
7875
7876 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7877
7878         The MS-Windows port of ncurses fails to switch to a color pair if
7879         one or both of the colors are the implicit default colors.  This
7880         change records the default colors when TUI is initialized, and
7881         then specifies them explicitly when a color pair uses the default
7882         colors.  This allows color styling in TUI mode on MS-Windows.
7883
7884         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7885         ncurses_norm_attr.
7886         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7887         colors in ncurses_norm_attr.
7888         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7889         "none", replace it with the default color recorded in
7890         ncurses_norm_attr.
7891
7892 2019-03-14  Tom Tromey  <tromey@adacore.com>
7893
7894         * source-cache.h (class source_cache) <get_source_lines>: Return
7895         std::string.
7896         * source-cache.c (source_cache::extract_lines): Handle case where
7897         first_pos==npos.  Return std::string.
7898         (source_cache::get_source_lines): Update.
7899
7900 2019-03-14  Tom Tromey  <tromey@adacore.com>
7901
7902         * NEWS: Add item for "style sources" commands.
7903         * source-cache.c (source_cache::get_source_lines): Check
7904         source_styling.
7905         * cli/cli-style.c (source_styling): New global.
7906         (_initialize_cli_style): Add "style sources" commands.
7907         (show_style_sources): New function.
7908         * cli/cli-style.h (source_styling): Declare.
7909
7910 2019-03-14  Pedro Alves  <palves@redhat.com>
7911             Tom Tromey  <tromey@adacore.com>
7912
7913         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7914         * tui/tui-winsource.c (tui_refill_source_window): New function,
7915         from...
7916         (tui_horizontal_source_scroll): ... here.  Move some logic.
7917         * cli/cli-style.c (set_style_enabled): Notify new observable.
7918         * tui/tui-hooks.c (tui_redisplay_source): New function.
7919         (tui_attach_detach_observers): Attach or detach
7920         tui_redisplay_source.
7921         * observable.h (source_styling_changed): New observable.
7922         * observable.c: Define source_styling_changed observable.
7923
7924 2019-03-13  Tom Tromey  <tromey@adacore.com>
7925
7926         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7927         (i386_gnu_nat_target::store_registers): Update.
7928         * target-debug.h (target_debug_print_std_string): New macro.
7929         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7930         * windows-tdep.c (display_one_tib): Update.
7931         * tui/tui-stack.c (tui_make_status_line): Update.
7932         * top.c (print_inferior_quit_action): Update.
7933         * thread.c (thr_try_catch_cmd): Update.
7934         (add_thread_with_info): Update.
7935         (thread_target_id_str): Update.
7936         (thr_try_catch_cmd): Update.
7937         (thread_command): Update.
7938         (thread_find_command): Update.
7939         * record-btrace.c (record_btrace_target::info_record)
7940         (record_btrace_resume_thread, record_btrace_target::resume)
7941         (record_btrace_cancel_resume, record_btrace_step_thread)
7942         (record_btrace_target::wait, record_btrace_target::wait)
7943         (record_btrace_target::wait, record_btrace_target::stop): Update.
7944         * progspace.c (print_program_space): Update.
7945         * process-stratum-target.c
7946         (process_stratum_target::thread_address_space): Update.
7947         * linux-fork.c (linux_fork_mourn_inferior)
7948         (detach_checkpoint_command, info_checkpoints_command)
7949         (linux_fork_context): Update.
7950         (linux_fork_detach): Update.
7951         (class scoped_switch_fork_info): Update.
7952         (delete_checkpoint_command): Update.
7953         * infrun.c (follow_fork_inferior): Update.
7954         (follow_fork_inferior): Update.
7955         (proceed_after_vfork_done): Update.
7956         (handle_vfork_child_exec_or_exit): Update.
7957         (follow_exec): Update.
7958         (displaced_step_prepare_throw): Update.
7959         (displaced_step_restore): Update.
7960         (start_step_over): Update.
7961         (resume_1): Update.
7962         (clear_proceed_status_thread): Update.
7963         (proceed): Update.
7964         (print_target_wait_results): Update.
7965         (do_target_wait): Update.
7966         (context_switch): Update.
7967         (stop_all_threads): Update.
7968         (restart_threads): Update.
7969         (finish_step_over): Update.
7970         (handle_signal_stop): Update.
7971         (switch_back_to_stepped_thread): Update.
7972         (keep_going_pass_signal): Update.
7973         (print_exited_reason): Update.
7974         (normal_stop): Update.
7975         * inferior.c (inferior_pid_to_str): Change return type.
7976         (print_selected_inferior): Update.
7977         (add_inferior): Update.
7978         (detach_inferior): Update.
7979         * dummy-frame.c (fprint_dummy_frames): Update.
7980         * dcache.c (dcache_info_1): Update.
7981         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7982         (btrace_fetch, btrace_clear): Update.
7983         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7984         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7985         type.
7986         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7987         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7988         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7989         * gdbarch.c, gdbarch.h: Rebuild.
7990         * gdbarch.sh (core_pid_to_str): Change return type.
7991         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7992         return type.
7993         (windows_nat_target::pid_to_str): Change return type.
7994         (windows_delete_thread): Update.
7995         (windows_nat_target::attach): Update.
7996         (windows_nat_target::files_info): Update.
7997         * target-delegates.c: Rebuild.
7998         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7999         return type.
8000         (sol_thread_target::pid_to_str): Change return type.
8001         * remote.c (class remote_target) <pid_to_str>: Change return
8002         type.
8003         (remote_target::pid_to_str): Change return type.
8004         (extended_remote_target::attach, remote_target::remote_stop_ns)
8005         (remote_target::remote_notif_remove_queued_reply)
8006         (remote_target::push_stop_reply, remote_target::disable_btrace):
8007         Update.
8008         (extended_remote_target::attach): Update.
8009         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8010         type.
8011         (gdbsim_target::pid_to_str): Change return type.
8012         * ravenscar-thread.c (struct ravenscar_thread_target)
8013         <pid_to_str>: Change return type.
8014         (ravenscar_thread_target::pid_to_str): Change return type.
8015         * procfs.c (class procfs_target) <pid_to_str>: Change return
8016         type.
8017         (procfs_target::pid_to_str): Change return type.
8018         (procfs_target::attach): Update.
8019         (procfs_target::detach): Update.
8020         (procfs_target::fetch_registers): Update.
8021         (procfs_target::store_registers): Update.
8022         (procfs_target::wait): Update.
8023         (procfs_target::files_info): Update.
8024         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8025         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8026         return type.
8027         (nto_procfs_target::pid_to_str): Change return type.
8028         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8029         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8030         return type.
8031         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8032         (exit_lwp): Update.
8033         (attach_proc_task_lwp_callback, get_detach_signal)
8034         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8035         (linux_nat_target::resume, wait_lwp, stop_callback)
8036         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8037         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8038         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8039         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8040         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8041         type.
8042         (inf_ptrace_target::attach): Update.
8043         (inf_ptrace_target::files_info): Update.
8044         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8045         type.
8046         (go32_nat_target::pid_to_str): Change return type.
8047         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8048         (gnu_nat_target::wait): Update.
8049         (gnu_nat_target::wait): Update.
8050         (gnu_nat_target::resume): Update.
8051         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8052         (fbsd_nat_target::wait): Update.
8053         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8054         type.
8055         (darwin_nat_target::attach): Update.
8056         * corelow.c (class core_target) <pid_to_str>: Change return type.
8057         (core_target::pid_to_str): Change return type.
8058         * target.c (normal_pid_to_str): Change return type.
8059         (default_pid_to_str): Likewise.
8060         (target_pid_to_str): Change return type.
8061         (target_translate_tls_address): Update.
8062         (target_announce_detach): Update.
8063         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8064         return type.
8065         (bsd_uthread_target::pid_to_str): Change return type.
8066         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8067         type.
8068         (bsd_kvm_target::pid_to_str): Change return type.
8069         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8070         return type.
8071         (aix_thread_target::pid_to_str): Change return type.
8072         * target.h (struct target_ops) <pid_to_str>: Change return type.
8073         (target_pid_to_str, normal_pid_to_str): Likewise.
8074         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8075         type.
8076         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8077         type.
8078         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8079         return type.
8080         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8081         type.
8082         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8083         type.
8084         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8085         return type.
8086
8087 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8088
8089         * NEWS: Mention that the new default MI version is 3.  Mention
8090         changes to the output of commands and events that deal with
8091         multi-location breakpoints.
8092         * breakpoint.c: Include "mi/mi-out.h".
8093         (print_one_breakpoint): Change output syntax if using MI version
8094         >= 3.
8095         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8096         New.
8097         (mi_multi_location_breakpoint_output_fixed): New.
8098         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8099         (mi_cmd_fix_multi_location_breakpoint_output): New.
8100         (mi_multi_location_breakpoint_output_fixed): New.
8101         * mi/mi-cmds.c (mi_cmds): Register command
8102         -fix-multi-location-breakpoint-output.
8103         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8104         interpreter "mi".
8105
8106 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8107
8108         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8109         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8110         instantiate mi_ui_out based on interpreter name.
8111         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8112         * mi/mi-main.c (mi_load_progress): Likewise.
8113
8114 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8115
8116         * NEWS: Combine separate "New targets" sections for 8.3.
8117
8118 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8119
8120         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8121         (ppcfbsd_init_abi): Install gdbarch
8122         "fetch_tls_load_module_address" and "get_thread_local_address"
8123         methods.
8124
8125 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8126
8127         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8128         (riscv_fbsd_init_abi): Install gdbarch
8129         "fetch_tls_load_module_address" and "get_thread_local_address"
8130         methods.
8131
8132 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8133
8134         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8135         (i386fbsd_init_abi): Install gdbarch
8136         "fetch_tls_load_module_address" and "get_thread_local_address"
8137         methods.
8138
8139 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8140
8141         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8142         (amd64fbsd_init_abi): Install gdbarch
8143         "fetch_tls_load_module_address" and "get_thread_local_address"
8144         methods.
8145
8146 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8147
8148         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8149         (struct fbsd_pspace_data): New type.
8150         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8151         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8152         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8153         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8154         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8155
8156 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8157
8158         * gdbtypes.c (lookup_struct_elt): New function.
8159         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8160         * gdbtypes.h (struct struct_elt): New type.
8161         (lookup_struct_elt): New prototype.
8162
8163 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8164
8165         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8166         remove disabled code block.
8167
8168 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8169
8170         * gdbarch.sh (get_thread_local_address): New method.
8171         * gdbarch.h, gdbarch.c: Regenerate.
8172         * target.c (target_translate_tls_address): Use
8173         gdbarch_get_thread_local_address if present instead of
8174         target::get_thread_local_address.
8175
8176 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8177
8178         * target.h (target::get_thread_local_address): Update comment.
8179
8180 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8181
8182         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8183         objfile->separate_debug_objfile_backlink if not NULL.
8184
8185 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8186
8187         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8188         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8189         (amd64bsd_store_inferior_registers): Likewise.
8190         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8191         Enable segment base registers.
8192         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8193         PT_GETFSBASE and PT_GETGSBASE.
8194         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8195         PT_SETGSBASE.
8196         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8197         segment base registers.
8198         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8199
8200 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8201
8202         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8203         Update calls to i386_target_description to add 'segments'
8204         parameter.
8205         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8206         add segment base registers.
8207         * arch/i386.c (i386_create_target_description): Add 'segments'
8208         parameter to enable segment base registers.
8209         * arch/i386.h (i386_create_target_description): Likewise.
8210         * features/i386/32bit-segments.xml: New file.
8211         * features/i386/32bit-segments.c: Generate.
8212         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8213         call to i386_target_description to add 'segments' parameter.
8214         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8215         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8216         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8217         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8218         if feature is present.
8219         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8220         Add 'segments' parameter to call to i386_target_description.
8221         (i386_target_description): Add 'segments' parameter to enable
8222         segment base registers.
8223         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8224         to call to i386_target_description.
8225         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8226         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8227         Define I386_NUM_REGS.
8228         (i386_target_description): Add 'segments' parameter to enable
8229         segment base registers.
8230
8231 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8232
8233         PR/24325
8234         * source-cache.c: #undef open and close, to avoid unresolved
8235         externals during linking.
8236
8237 2019-03-12  Tom Tromey  <tromey@adacore.com>
8238
8239         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8240         const.  Add initializers.
8241         (_initialize_remote): Don't initialize ptid globals.
8242
8243 2019-03-12  Pedro Alves  <palves@redhat.com>
8244
8245         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8246
8247 2019-03-12  Pedro Alves  <palves@redhat.com>
8248
8249         * cp-name-parser.y (main): Remove unused 'len' variable.
8250
8251 2019-03-12  Tom Tromey  <tromey@adacore.com>
8252
8253         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8254         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8255
8256 2019-03-12  Tom Tromey  <tromey@adacore.com>
8257
8258         * linux-nat.c (iterate_over_lwps): Update.
8259         (stop_callback): Remove parameter.
8260         (stop_wait_callback, detach_callback, resume_set_callback)
8261         (select_singlestep_lwp_callback, set_ignore_sigint)
8262         (status_callback, resumed_callback, resume_clear_callback)
8263         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8264         data parameter.
8265         (linux_nat_target::detach, linux_nat_target::resume)
8266         (linux_stop_and_wait_all_lwps, select_event_lwp)
8267         (linux_nat_filter_event, linux_nat_wait_1)
8268         (linux_nat_target::kill, linux_nat_target::stop)
8269         (linux_nat_target::stop): Update.
8270         (linux_nat_resume_callback): Change type.
8271         (resume_stopped_resumed_lwps, count_events_callback)
8272         (select_event_lwp_callback): Likewise.
8273         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8274         * arm-linux-nat.c (struct update_registers_data): Remove.
8275         (update_registers_callback): Change type.
8276         (arm_linux_insert_hw_breakpoint1): Update.
8277         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8278         parameter.
8279         (x86_linux_dr_set_addr): Update.
8280         (x86_linux_dr_set_control): Update.
8281         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8282         (iterate_over_lwps): Use gdb::function_view.
8283         * nat/aarch64-linux-hw-point.c (struct
8284         aarch64_dr_update_callback_param): Remove.
8285         (debug_reg_change_callback): Change type.
8286         (aarch64_notify_debug_reg_change): Update.
8287         * s390-linux-nat.c (s390_refresh_per_info): Update.
8288
8289 2019-03-11  Tom Tromey  <tromey@adacore.com>
8290
8291         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8292         redundant assignment to "this_cu".
8293
8294 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8295
8296         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8297
8298 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8299
8300         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8301         from...
8302         (rank_one_type): ... this.
8303
8304 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8305
8306         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8307         from...
8308         (rank_one_type): ... this.
8309
8310 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8311
8312         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8313         from...
8314         (rank_one_type): ... this.
8315
8316 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8317
8318         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8319         from...
8320         (rank_one_type): ... this.
8321
8322 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8323
8324         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8325         from...
8326         (rank_one_type): ... this.
8327
8328 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8329
8330         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8331         from...
8332         (rank_one_type): ... this.
8333
8334 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8335
8336         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8337         from...
8338         (rank_one_type): ... this.
8339
8340 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8341
8342         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8343         from...
8344         (rank_one_type): ... this.
8345
8346 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8347
8348         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8349         from...
8350         (rank_one_type): ... this.
8351
8352 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8353
8354         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8355         from...
8356         (rank_one_type): ... this.
8357
8358 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8359
8360         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8361         from...
8362         (rank_one_type): ... this.
8363
8364 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8365
8366         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8367         from...
8368         (rank_one_type): ... this.
8369
8370 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8371
8372         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8373         inferior-events' shows the example events.
8374
8375 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8376
8377         Support styling on native MS-Windows console
8378
8379         PR/24315
8380         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8381         on MS-Windows if $TERM is not defined.
8382
8383         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8384
8385         * posix-hdep.c (gdb_console_fputs):
8386         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8387         functions.
8388         * ui-file.h (gdb_console_fputs): Add prototype.
8389
8390         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8391         back to fputs only if the former returns zero.
8392
8393 2019-03-07  Tom Tromey  <tom@tromey.com>
8394
8395         * symmisc.c (print_symbol_bcache_statistics): Update.
8396         (print_objfile_statistics): Update.
8397         * symfile.c (allocate_symtab): Update.
8398         * stabsread.c: Don't include bcache.h.
8399         * psymtab.h (struct psymbol_bcache): Don't declare.
8400         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8401         (psymbol_bcache_init, psymbol_bcache_free)
8402         (psymbol_bcache_get_bcache): Don't declare.
8403         * psymtab.c (struct psymbol_bcache): Remove.
8404         (psymtab_storage::psymtab_storage): Update.
8405         (psymtab_storage::~psymtab_storage): Update.
8406         (psymbol_bcache_init, psymbol_bcache_free)
8407         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8408         (add_psymbol_to_bcache): Update.
8409         (allocate_psymtab): Update.
8410         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8411         macro_cache>: No longer pointers.
8412         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8413         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8414         * macrotab.c (macro_bcache): Update.
8415         * macroexp.c: Don't include bcache.h.
8416         * gdbtypes.c (check_types_worklist): Update.
8417         (types_deeply_equal): Remove TRY/CATCH.  Update.
8418         * elfread.c (elf_symtab_read): Update.
8419         * dwarf2read.c: Don't include bcache.h.
8420         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8421         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8422         (print_bcache_statistics, bcache_memory_used): Don't declare.
8423         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8424         methods.  Rename all data members.
8425         * bcache.c (struct bcache): Move to bcache.h.
8426         (bcache::expand_hash_table): Rename from expand_hash_table.
8427         (bcache): Remove.
8428         (bcache::insert): Rename from bcache_full.
8429         (bcache::compare): Rename from bcache_compare.
8430         (bcache_xmalloc): Remove.
8431         (bcache::~bcache): Rename from bcache_xfree.
8432         (bcache::print_statistics): Rename from print_bcache_statistics.
8433         (bcache::memory_used): Rename from bcache_memory_used.
8434
8435 2019-03-07  Pedro Alves  <palves@redhat.com>
8436
8437         * infrun.c (normal_stop): Also check for
8438         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8439
8440 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8441
8442         * f-lang.c (value_from_host_double): Moved to...
8443         * value.c (value_from_host_double): ...here.
8444         * value.h (value_from_host_double): Declare.
8445         * guile/scm-math.c (vlscm_convert_typed_number): Use
8446         value_from_host_double.
8447         (vlscm_convert_number): Likewise.
8448         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8449         * python/py-value.c (convert_value_from_python): Likewise.
8450
8451 2019-03-06  Tom Tromey  <tom@tromey.com>
8452
8453         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8454
8455 2019-03-06  Tom Tromey  <tom@tromey.com>
8456
8457         * utils.h (free_current_contents): Don't declare.
8458         * utils.c (free_current_contents): Remove.
8459
8460 2019-03-06  Tom Tromey  <tom@tromey.com>
8461
8462         * top.c (quit_force): Update.
8463         * main.c (captured_command_loop): Update.
8464         * common/new-op.c (operator new): Update.
8465         * common/common-exceptions.c (struct catcher)
8466         <save_cleanup_chain>: Remove member.
8467         (exceptions_state_mc_init): Update.
8468         (exception_try_scope_entry): Return nullptr.
8469         (exception_try_scope_exit, exception_rethrow)
8470         (throw_exception_sjlj, throw_exception_cxx): Update.
8471         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8472         (all_cleanups, do_cleanups, discard_cleanups)
8473         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8474         (restore_cleanups, restore_final_cleanups): Don't declare.
8475         (do_final_cleanups): Remove parameter.
8476         * common/cleanups.c (cleanup_chain, make_cleanup)
8477         (make_cleanup_dtor, all_cleanups, do_cleanups)
8478         (discard_my_cleanups, discard_cleanups)
8479         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8480         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8481         (null_cleanup): Remove.
8482         (do_final_cleanups): Remove parameter.
8483
8484 2019-03-06  Tom Tromey  <tom@tromey.com>
8485
8486         * remote.c (remote_target::remote_parse_stop_reply): Use
8487         unique_xmalloc_ptr.
8488
8489 2019-03-06  Tom Tromey  <tom@tromey.com>
8490
8491         * stabsread.c (struct stabs_field_info): Rename from field_info.
8492         <list, fnlist>: Add initializers.
8493         <obstack>: New member.
8494         (read_member_functions, read_struct_fields, read_baseclasses):
8495         Allocate on obstack.  Don't use cleanups.
8496         (read_one_struct_field, read_member_functions, read_struct_fields)
8497         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8498         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8499         (read_struct_type): Update.
8500
8501 2019-03-06  Tom Tromey  <tom@tromey.com>
8502
8503         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8504         * common/filestuff.h (make_cleanup_close): Don't declare.
8505         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8506         Remove.
8507
8508 2019-03-06  Tom Tromey  <tom@tromey.com>
8509
8510         * solib-aix.c: Use make_scope_exit.
8511
8512 2019-03-06  Tom Tromey  <tom@tromey.com>
8513
8514         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8515         Use make_scope_exit.
8516
8517 2019-03-06  Tom Tromey  <tom@tromey.com>
8518
8519         * solib-svr4.c (disable_probes_interface): Remove parameter.
8520         (svr4_handle_solib_event): Use make_scope_exit.
8521
8522 2019-03-06  Tom Tromey  <tom@tromey.com>
8523
8524         * remote.c (struct stop_reply_deleter): Remove.
8525         (stop_reply_up): Update.
8526         (struct stop_reply): Derive from notif_event.  Don't typedef.
8527         <regcache>: Now a std::vector.
8528         (stop_reply_xfree): Remove.
8529         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8530         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8531         (remote_target::discard_pending_stop_replies): Use delete.
8532         (remote_target::remote_parse_stop_reply): Update.
8533         (remote_target::process_stop_reply): Update.
8534         * remote-notif.h (struct notif_event): Add virtual destructor.
8535         Remove "dtr" member.
8536         (struct notif_client) <alloc_event>: Return a unique_ptr.
8537         (notif_event_xfree): Don't declare.
8538         (notif_event_up): New typedef.
8539         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8540         (notif_event_xfree, do_notif_event_xfree): Remove.
8541         (remote_notif_state_xfree): Update.
8542
8543 2019-03-06  Tom Tromey  <tom@tromey.com>
8544
8545         * infrun.c (displaced_step_clear_cleanup): Now a
8546         forward_scope_exit type.
8547         (displaced_step_prepare_throw): Update.
8548         (displaced_step_fixup): Update.
8549
8550 2019-03-06  Tom Tromey  <tom@tromey.com>
8551
8552         * inferior.h (class inferior): Update comment.
8553         * gdbthread.h (class thread_info): Update comment.
8554
8555 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8556             Tom Tromey  <tom@tromey.com>
8557
8558         * stabsread.h (struct stab_section_list): Remove.
8559         (coffstab_build_psymtabs): Update.
8560         * dbxread.c (symbuf_sections): Now a std::vector.
8561         (sect_idx): New global.
8562         (fill_symbuf): Update.
8563         (coffstab_build_psymtabs): Change type of stabsects parameter.
8564         Update.
8565         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8566         std::vector.
8567         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8568         (coff_locate_sections): Update.
8569         (coff_symfile_read): Remove cleanups.  Update.
8570         (init_stringtab): Add storage parameter.
8571         (free_stringtab, free_stringtab_cleanup): Remove.
8572         (init_lineno): Add storage parameter.
8573         (free_linetab, free_linetab_cleanup): Remove.
8574
8575 2019-03-06  Pedro Alves  <palves@redhat.com>
8576
8577         * linux-fork.c (fork_info::clobber_regs): Delete.
8578         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8579         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8580         comment.  Adjust.
8581         (scoped_switch_fork_info::scoped_switch_fork_info)
8582         (checkpoint_command, linux_fork_context): Adjust
8583         fork_save_infrun_state calls.
8584
8585 2019-03-06  Pedro Alves  <palves@redhat.com>
8586
8587         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8588         (inf_has_multiple_threads): Return 'bool' and rewrite using
8589         inferior_info::threads().
8590
8591 2019-03-06  Pedro Alves  <palves@redhat.com>
8592
8593         * linux-fork.c: Include <list>.
8594         (fork_list): Now a std::list instance.
8595         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8596         (forks_exist_p, find_last_fork): Adjust.
8597         (new_fork): Delete.
8598         (one_fork_p): New.
8599         (add_fork): Adjust.
8600         (free_fork): Delete, folded into fork_info::~fork_info().
8601         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8602         Adjust.
8603         (init_fork_list): Delete.
8604         (linux_fork_killall, linux_fork_mourn_inferior)
8605         (linux_fork_detach, info_checkpoints_command): Adjust.
8606         (_initialize_linux_fork): No longer call init_fork_list.
8607
8608 2019-03-06  Pedro Alves  <palves@redhat.com>
8609
8610         * linux-fork.c (new_fork): New, split out of ...
8611         (add_fork): ... this.  Return void.  Move "first fork" special
8612         case from here, to ...
8613         (checkpoint_command): ... here.
8614         * linux-linux.h (add_fork): Return void.
8615
8616 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8617
8618         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8619
8620 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8621             Chris January  <chris.january@arm.com>
8622             David Lecomber  <david.lecomber@arm.com>
8623
8624         * f-exp.y: New token, UNOP_INTRINSIC.
8625         (exp): New pattern using UNOP_INTRINSIC token.
8626         (f77_keywords): Add 'abs' keyword.
8627         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8628         (value_from_host_double): New function.
8629         (evaluate_subexp_f): Support UNOP_ABS.
8630
8631 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8632
8633         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8634         types.
8635
8636 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8637
8638         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8639         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8640         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8641
8642 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8643
8644         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8645
8646 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8647             Chris January  <chris.january@arm.com>
8648
8649         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8650         * f-exp.y: Define 'KIND' token.
8651         (exp): New pattern for KIND expressions.
8652         (ptype): Handle types with a kind extension.
8653         (direct_abs_decl): Extend to spot kind extensions.
8654         (f77_keywords): Add 'kind' to the list.
8655         (push_kind_type): New function.
8656         (convert_to_kind_type): New function.
8657         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8658         * parse.c (operator_length_standard): Likewise.
8659         * parser-defs.h (enum type_pieces): Add tp_kind.
8660         * std-operator.def: Add UNOP_KIND.
8661
8662 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8663
8664         * f-exp.y (f_parse): Set yydebug.
8665
8666 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8667
8668         * f-lang.c (evaluate_subexp_f): New function.
8669         (exp_descriptor_f): New global.
8670         (f_language_defn): Use exp_descriptor_f instead of
8671         exp_descriptor_standard.
8672
8673 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8674
8675         * f-exp.y (struct token): Add comments.
8676         (dot_ops): Remove uppercase versions and the end marker.
8677         (f77_keywords): Likewise.
8678         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8679         entries in the dot_ops array are case insensitive, and use
8680         strncasecmp to compare strings.  Also some whitespace cleanup in
8681         this area.  Similar for the f77_keywords array, except entries in
8682         this list might be case sensitive.
8683
8684 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8685
8686         * f-exp.y (struct f77_boolean_val): Add comments.
8687         (boolean_values): Remove uppercase versions, and end marker.
8688         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8689         and use strncasecmp to achieve case insensitivity.  Additionally,
8690         perform whitespace cleanup around this code.
8691
8692 2019-03-06  Tom Tromey  <tromey@adacore.com>
8693
8694         * remote-sim.c (gdbsim_target_open): Use result of
8695         gdb_argv::release.
8696
8697 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8698         Dirk Schubert  <dirk.schubert@arm.com>
8699         Chris January  <chris.january@arm.com>
8700
8701         * eval.c (evaluate_subexp_standard): Call Fortran argument
8702         wrapping logic.
8703         * f-lang.c (struct value): A value which can be passed into a
8704         Fortran function call.
8705         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8706         where appropriate.
8707         (struct type): Value ready for a Fortran function call.
8708         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8709         is needed.
8710         * f-lang.h (fortran_argument_convert): Declaration.
8711         (fortran_preserve_arg_pointer): Declaration.
8712         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8713
8714 2019-03-05  Tom Tromey  <tromey@adacore.com>
8715
8716         * python/py-prettyprint.c (print_string_repr): Remove #if.
8717         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8718
8719 2019-03-05  Tom Tromey  <tromey@adacore.com>
8720
8721         * target.c (the_dummy_target): Move later.  Change type to
8722         "dummy_target".
8723         (initialize_targets): Don't initialize the_dummy_target.
8724
8725 2019-03-05  Tom Tromey  <tromey@adacore.com>
8726
8727         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8728         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8729
8730 2019-03-05  Tom Tromey  <tromey@adacore.com>
8731
8732         * windows-nat.c (windows_nat_target::attach)
8733         (windows_nat_target::detach): Don't call gdb_flush.
8734         * valprint.c (generic_val_print, val_print, val_print_string):
8735         Don't call gdb_flush.
8736         * utils.c (defaulted_query): Don't call gdb_flush.
8737         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8738         * target.c (target_announce_detach): Don't call gdb_flush.
8739         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8740         * remote.c (extended_remote_target::attach): Don't call
8741         gdb_flush.
8742         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8743         * printcmd.c (do_examine): Don't call gdb_flush.
8744         (info_display_command): Don't call gdb_flush.
8745         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8746         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8747         * memattr.c (info_mem_command): Don't call gdb_flush.
8748         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8749         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8750         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8751         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8752         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8753         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8754         (gnu_nat_target::detach): Don't call gdb_flush.
8755         * f-valprint.c (f_val_print): Don't call gdb_flush.
8756         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8757         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8758         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8759         gdb_flush.
8760         * c-valprint.c (c_val_print): Don't call gdb_flush.
8761         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8762
8763 2019-03-05  Tom Tromey  <tromey@adacore.com>
8764
8765         * varobj.c (update_dynamic_varobj_children): Update.
8766         (install_default_visualizer): Use reset, not release.
8767         * value.c (set_internalvar): Update.
8768         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8769         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8770         ATTRIBUTE_UNUSED_RESULT.
8771
8772 2019-03-05  Tom Tromey  <tromey@adacore.com>
8773
8774         * remote.c (class scoped_remote_fd) <release>: Add
8775         ATTRIBUTE_UNUSED_RESULT.
8776
8777 2019-03-05  Tom Tromey  <tromey@adacore.com>
8778
8779         * macroexp.c (struct macro_buffer) <release>: Add
8780         ATTRIBUTE_UNUSED_RESULT.
8781
8782 2019-03-05  Tom Tromey  <tromey@adacore.com>
8783
8784         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8785         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8786         ATTRIBUTE_UNUSED_RESULT.
8787
8788 2019-03-05  Tom Tromey  <tromey@adacore.com>
8789
8790         * common/scoped_fd.h (class scoped_fd) <release>: Add
8791         ATTRIBUTE_UNUSED_RESULT.
8792
8793 2019-03-05  Tom Tromey  <tromey@adacore.com>
8794
8795         * parser-defs.h (struct parser_state) <release>: Add
8796         ATTRIBUTE_UNUSED_RESULT.
8797
8798 2019-03-05  Tom Tromey  <tromey@adacore.com>
8799
8800         * utils.h (class gdb_argv) <release>: Add
8801         ATTRIBUTE_UNUSED_RESULT.
8802         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8803
8804 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8805
8806         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8807         for-loop range, to avoid compiler warnings.
8808
8809         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8810         avoid compiler warnings about unused variables.
8811
8812         * NEWS: Mention end of support for native debugging on MS-Windows
8813         before XP.
8814
8815         PR gdb/24292
8816         * common/netstuff.c:
8817         * gdbserver/gdbreplay.c
8818         * gdbserver/remote-utils.c:
8819         * ser-tcp.c:
8820         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8821         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8822         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8823         'getaddrinfo' and 'freeaddrinfo' were not available before
8824         Windows XP, and mingw.org's MinGW headers by default define
8825         _WIN32_WINNT to 0x500.
8826
8827 2019-03-01  Gary Benson <gbenson@redhat.com>
8828
8829         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8830
8831 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8832             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8833
8834         PR gdb/8527
8835         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8836         set_sigint_trap, clear_sigint_trap.
8837
8838 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8839
8840         * target.c (target_detach): Clear the regcache and the
8841         frame cache.
8842
8843 2019-02-27  Pedro Alves  <palves@redhat.com>
8844
8845         * utils.c (set_screen_size): When we cap the height/width sizes,
8846         tweak the corresponding command variable to show "unlimited":
8847
8848 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8849             Pedro Alves  <palves@redhat.com>
8850
8851         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8852         before calling rl_set_screen_size.
8853
8854 2019-02-27  Tom Tromey  <tromey@adacore.com>
8855
8856         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8857         define.
8858         * python/py-value.c: Remove Python 2.4 workaround.
8859         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8860         workaround.
8861         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8862         Python 2.4 workaround.
8863         * python/python-internal.h: Remove Python 2.4 comment.
8864         (Py_ssize_t): Don't define.
8865         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8866         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8867         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8868         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8869         * python/python.c (do_start_initialization): Remove Python 2.4
8870         workaround.
8871         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8872         (print_children): Remove Python 2.4 workaround.
8873         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8874         workaround.
8875         (CHARBUFFERPROC_NAME): Remove.
8876         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8877         Python 2.4 workaround.
8878
8879 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8880
8881         * NEWS: Note minimum Python version.
8882
8883 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8884
8885         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8886         code from these functions.  Remove corresponding ifdefs.  Use
8887         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8888         Remove gotos and target of gotos.
8889         (infpy_search_memory): Likewise.
8890
8891 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8892
8893         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8894         (hppa_gdbarch_init): Don't register deleted functions with
8895         gdbarch.
8896
8897 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8898
8899         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8900         (h8300_unwind_sp): Delete.
8901         (h8300_dummy_id): Delete.
8902         (h8300_gdbarch_init): Don't register deleted functions with
8903         gdbarch.
8904
8905 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8906
8907         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8908         (ft32_unwind_pc): Delete.
8909         (ft32_unwind_sp): Delete.
8910         (ft32_gdbarch_init): Don't register deleted functions with
8911         gdbarch.
8912
8913 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8914
8915         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8916         (frv_unwind_pc): Delete.
8917         (frv_unwind_sp): Delete.
8918         (frv_gdbarch_init): Don't register deleted functions with
8919         gdbarch.
8920
8921 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8922
8923         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8924         (riscv_unwind_pc): Delete.
8925         (riscv_unwind_sp): Delete.
8926         (riscv_gdbarch_init): Don't register deleted functions with
8927         gdbarch.
8928
8929 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8930
8931         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8932         (csky_unwind_pc): Delete.
8933         (csky_unwind_sp): Delete.
8934         (csky_gdbarch_init): Don't register deleted functions with
8935         gdbarch.
8936
8937 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8938
8939         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8940         (cris_unwind_pc): Delete.
8941         (cris_unwind_sp): Delete.
8942         (cris_gdbarch_init): Don't register deleted functions with
8943         gdbarch.
8944
8945 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8946
8947         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8948         (bfin_unwind_pc): Delete.
8949         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8950
8951 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8952
8953         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8954         (arm_unwind_pc): Delete.
8955         (arm_unwind_sp): Delete.
8956         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8957
8958 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8959
8960         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8961         (arc_unwind_pc): Delete.
8962         (arc_unwind_sp): Delete.
8963         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8964
8965 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8966
8967         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8968         (alpha_unwind_pc): Delete.
8969         (alpha_gdbarch_init): Don't register deleted functions with
8970         gdbarch.
8971
8972 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8973
8974         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8975         (aarch64_unwind_pc): Delete.
8976         (aarch64_unwind_sp): Delete.
8977         (aarch64_gdbarch_init): Don't register deleted functions with
8978         gdbarch.
8979
8980 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8981
8982         * gdbtypes.c (type_align): Don't consider static members when
8983         computing structure alignment.
8984
8985 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8986
8987         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8988         return 0 for other types.
8989         * arch-utils.c (default_type_align): Always return 0.
8990         * gdbarch.h: Regenerate.
8991         * gdbarch.sh (type_align): Extend comment.
8992         * gdbtypes.c (type_align): Add additional comments, always call
8993         gdbarch_type_align before applying the default rules.
8994         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8995         generic code will then apply a suitable default.
8996         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8997         types, return 0 for other types.
8998
8999 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9000
9001         * NEWS: Create a new section for the next release branch.
9002         Rename the section of the current branch, now that it has
9003         been cut.
9004
9005 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9006
9007         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9008         * version.in: Bump version to 8.3.50.DATE-git.
9009
9010 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9011
9012         * aix-thread.c (ptid_cmp): Remove unused variable.
9013         (get_signaled_thread): Likewise.
9014         (store_regs_user_thread): Likewise.
9015         (store_regs_kernel_thread): Likewise.
9016         (fetch_regs_kernel_thread): Remove shadowed variable.
9017
9018 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9019
9020         * features/riscv/32bit-cpu.xml: Add register numbers.
9021         * features/riscv/32bit-fpu.c: Regenerate.
9022         * features/riscv/32bit-fpu.xml: Add register numbers.
9023         * features/riscv/64bit-cpu.xml: Add register numbers.
9024         * features/riscv/64bit-fpu.c: Regenerate.
9025         * features/riscv/64bit-fpu.xml: Add register numbers.
9026
9027 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9028
9029         * NEWS: Mention two argument form of gdb.Value constructor.
9030         * python/py-value.c (convert_buffer_and_type_to_value): New
9031         function.
9032         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9033         Add support for handling an optional second argument.  Call
9034         convert_buffer_and_type_to_value as appropriate.
9035         * python/python-internal.h (Py_buffer_deleter): New struct.
9036         (Py_buffer_up): New typedef.
9037
9038 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9039
9040         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9041         instead of releasing ownership.
9042
9043 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9044
9045         * dwarf2read.c (open_and_init_dwp_file): Call
9046         elf_numsections instead of bfd_count_sections to initialize
9047         dwp_file->num_sections.
9048
9049 2019-02-25  Tom Tromey  <tromey@adacore.com>
9050
9051         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9052
9053 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9054
9055         * gcore.in: Add '--readnever' option when invoking GDB.
9056
9057 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9058
9059         * MAINTAINERS: Update my email address.
9060
9061 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9062
9063         * build-id.c (build_id_to_debug_bfd_1): New function.
9064         (build_id_to_debug_bfd): Look for separate debug file in
9065         sysroot.
9066
9067 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9068
9069         * gdbarch.sh: Update the copyright year range that is placed into
9070         generated files.
9071
9072 2019-02-22  Keith Seitz  <keiths@redhat.com>
9073
9074         PR symtab/23853
9075         * linespec.c (create_sals_line_offset): Search for the default
9076         symtab's filename instead of its fullname.
9077
9078 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9079
9080         * NEWS: Update style defaults.
9081
9082 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9083
9084         * main.c (captured_main_1): Disable styling in batch mode.
9085
9086 2019-02-20  Tom Tromey  <tom@tromey.com>
9087
9088         * symtab.c (symtab_symbol_info): Fix typos.
9089
9090 2019-02-20  Tom Tromey  <tromey@adacore.com>
9091
9092         * findcmd.c (_initialize_mem_search): Use upper case for
9093         metasyntactic variables.
9094
9095 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9096
9097         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9098         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9099
9100 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9101
9102         * top.h (source_file_name): Change to std::string.
9103         * top.c (source_file_name): Likewise.
9104         (command_line_input): Adjust.
9105         * cli/cli-script.c (script_from_file): Adjust.
9106
9107 2019-02-19  Tom Tromey  <tromey@adacore.com>
9108
9109         * ravenscar-thread.c
9110         (ravenscar_thread_target::update_thread_list): Don't call
9111         ada_build_task_list.
9112         * ada-lang.h (ada_build_task_list): Don't declare.
9113         * ada-tasks.c (struct ada_tasks_inferior_data)
9114         <task_list_valid_p>: Now bool.
9115         (read_known_tasks, ada_task_list_changed)
9116         (ada_tasks_invalidate_inferior_data): Update.
9117         (read_known_tasks_array): Return bool.
9118         (read_known_tasks_list): Likewise.
9119         (read_known_tasks): Return void.
9120         (ada_build_task_list): Now static.
9121
9122 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9123
9124         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9125         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9126
9127 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9128
9129         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9130         variant for ada_tasks_pspace_data_handle and
9131         ada_tasks_inferior_data_handle.
9132         (ada_tasks_pspace_data_cleanup): New function.
9133         (ada_tasks_inferior_data_cleanup): New function.
9134
9135 2019-02-17  Tom Tromey  <tom@tromey.com>
9136
9137         * macrotab.h (macro_source_fullname): Return a std::string.
9138         * macrotab.c (macro_include, check_for_redefinition)
9139         (macro_undef, macro_lookup_definition, foreach_macro)
9140         (foreach_macro_in_scope): Update.
9141         (macro_source_fullname): Return a std::string.
9142         * macrocmd.c (show_pp_source_pos): Update.
9143
9144 2019-02-17  Tom Tromey  <tom@tromey.com>
9145
9146         * macrocmd.c (show_pp_source_pos): Style the file names.
9147
9148 2019-02-17  Tom Tromey  <tom@tromey.com>
9149
9150         PR tui/24197:
9151         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9152
9153 2019-02-17  Tom Tromey  <tom@tromey.com>
9154
9155         * ada-lang.c (user_select_syms): Use filtered printing.
9156         * utils.c (wrap_style): New global.
9157         (desired_style): Remove.
9158         (emit_style_escape): Add stream parameter.
9159         (set_output_style, reset_terminal_style, prompt_for_continue):
9160         Update.
9161         (flush_wrap_buffer): Only flush gdb_stdout.
9162         (wrap_here): Set wrap_style.
9163         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9164         treat escape sequences as a character.  Change when wrap buffer is
9165         flushed.
9166         (fputs_styled): Do not set the output style when the default is
9167         requested.
9168         * ui-style.h (struct ui_file_style) <is_default>: New method.
9169         * source.c (print_source_lines_base): Emit escape sequences in one
9170         piece.
9171
9172 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9173
9174         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9175         integers and enumeration types.
9176
9177 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9178
9179         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9180         instead of lookup_symbol_in_language
9181         (do_exact_match): New function.
9182         (ada_get_symbol_name_matcher): Return do_exact_match when
9183         doing a verbatim match.
9184
9185 2019-02-15  Tom Tromey  <tromey@adacore.com>
9186
9187         * ravenscar-thread.c (ravenscar_thread_target::resume)
9188         (ravenscar_thread_target::wait): Special case wildcard requests.
9189
9190 2019-02-15  Tom Tromey  <tromey@adacore.com>
9191
9192         * ravenscar-thread.c (base_ptid): Remove.
9193         (struct ravenscar_thread_target) <close>: New method.
9194         <m_base_ptid>: New member.
9195         <update_inferior_ptid, active_task, task_is_currently_active,
9196         runtime_initialized>: Declare methods.
9197         <ravenscar_thread_target>: Add constructor.
9198         (ravenscar_thread_target::task_is_currently_active)
9199         (ravenscar_thread_target::update_inferior_ptid)
9200         (ravenscar_runtime_initialized): Rename.  Now methods.
9201         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9202         (ravenscar_thread_target::update_thread_list): Update.
9203         (ravenscar_thread_target::active_task): Now method.
9204         (ravenscar_thread_target::store_registers)
9205         (ravenscar_thread_target::prepare_to_store)
9206         (ravenscar_thread_target::prepare_to_store)
9207         (ravenscar_thread_target::mourn_inferior): Update.
9208         (ravenscar_inferior_created): Use "new" to create target.
9209         (ravenscar_thread_target::get_ada_task_ptid): Update.
9210         (_initialize_ravenscar): Don't initialize base_ptid.
9211         (ravenscar_ops): Remove global.
9212
9213 2019-02-15  Tom Tromey  <tromey@adacore.com>
9214
9215         * target.h (push_target): Declare new overload.
9216         * target.c (push_target): New overload, taking an rvalue reference.
9217         * remote.c (remote_target::open_1): Use push_target overload.
9218         * corelow.c (core_target_open): Use push_target overload.
9219
9220 2019-02-15  Tom Tromey  <tromey@adacore.com>
9221
9222         * ravenscar-thread.c (is_ravenscar_task)
9223         (ravenscar_task_is_currently_active): Return bool.
9224         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9225         (_initialize_ravenscar): Remove "(void)".
9226         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9227         Return bool.
9228
9229 2019-02-15  Tom Tromey  <tromey@adacore.com>
9230
9231         * ravenscar-thread.c (ravenscar_runtime_initializer)
9232         (has_ravenscar_runtime, get_running_thread_id)
9233         (ravenscar_thread_target::resume): Fix indentation.
9234
9235 2019-02-15  Tom Tromey  <tromey@adacore.com>
9236
9237         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9238         from ravenscar_arch_ops.
9239         (sparc_ravenscar_ops::fetch_registers)
9240         (sparc_ravenscar_ops::store_registers): Now methods.
9241         (sparc_ravenscar_prepare_to_store): Remove.
9242         (sparc_ravenscar_ops): Redefine.
9243         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9244         methods and destructor.  Remove members.
9245         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9246         (ravenscar_thread_target::store_registers)
9247         (ravenscar_thread_target::prepare_to_store): Update.
9248         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9249         Remove.
9250         (struct ppc_ravenscar_powerpc_ops): Derive from
9251         ravenscar_arch_ops.
9252         (ppc_ravenscar_powerpc_ops::fetch_registers)
9253         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9254         (ppc_ravenscar_powerpc_ops): Redefine.
9255         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9256         (ppc_ravenscar_e500_ops::fetch_registers)
9257         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9258         (ppc_ravenscar_e500_ops): Redefine.
9259         * aarch64-ravenscar-thread.c
9260         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9261         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9262         (aarch64_ravenscar_fetch_registers)
9263         (aarch64_ravenscar_store_registers): Now methods.
9264         (aarch64_ravenscar_ops): Redefine.
9265
9266 2019-02-15  Tom Tromey  <tromey@adacore.com>
9267
9268         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9269         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9270         (ravenscar_thread_target::stopped_by_watchpoint)
9271         (ravenscar_thread_target::stopped_data_address)
9272         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9273
9274 2019-02-15  Tom Tromey  <tromey@adacore.com>
9275
9276         * ravenscar-thread.c: Fix some typos.
9277
9278 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9279             Tom Tromey  <tromey@adacore.com>
9280
9281         * ada-lang.c (ada_exception_sal): Change addr_string to a
9282         std::string.
9283         (create_ada_exception_catchpoint): Update.
9284
9285 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9286             Tom Tromey  <tromey@adacore.com>
9287
9288         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9289         (bp_location_ops): Remove.
9290         (base_breakpoint_allocate_location): Update.
9291         (free_bp_location): Update.
9292         * ada-lang.c (class ada_catchpoint_location)
9293         <ada_catchpoint_location>: Remove ops parameter.
9294         (ada_catchpoint_location_dtor): Remove.
9295         (ada_catchpoint_location_ops): Remove.
9296         (allocate_location_exception): Update.
9297         * breakpoint.h (struct bp_location_ops): Remove.
9298         (class bp_location) <bp_location>: Remove bp_location_ops
9299         parameter.
9300         <~bp_location>: Add destructor.
9301         <ops>: Remove.
9302
9303 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9304             Pedro Alves  <palves@redhat.com>
9305
9306         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9307         'PATH_MAX'.
9308
9309 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9310             Samuel Thibault  <samuel.thibault@gnu.org>
9311             Thomas Schwinge  <thomas@codesourcery.com>
9312
9313         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9314         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9315
9316 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9317
9318         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9319         (check_empty): Use "const char *".
9320
9321         * gnu-nat.c (gnu_nat_target::detach): Instead of
9322         'detach_inferior (pid)' call
9323         'detach_inferior (find_inferior_pid (pid))'.
9324
9325         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9326         'nat/fork-inferior.o'.
9327         * gnu-nat.c: #include "nat/fork-inferior.h".
9328
9329         * gnu-nat.c (gnu_nat_target::detach): Instead of
9330         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9331         * gnu-nat.h: #include "inf-child.h".
9332         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9333         'i386_gnu_nat_target::fetch_registers'.
9334         (gnu_store_registers): Rename/move to
9335         'i386_gnu_nat_target::store_registers'.
9336
9337         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9338         * gnu-nat.h (mach_thread_info): New function.
9339         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9340
9341         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9342
9343 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9344
9345         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9346
9347 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9348
9349         * windows-nat.c (windows_add_thread): Add new parameter
9350         "main_thread_p" with default value set to false.  Update
9351         function documentation as well as all callers.
9352         (windows_delete_thread): Likewise.
9353         (fake_create_process): Update call to windows_add_thread.
9354         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9355         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9356         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9357         call to windows_delete_thread.
9358
9359 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9360
9361         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9362
9363 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9364
9365         * symfile.c (find_separate_debug_file): Use canonical path of
9366         sysroot with child_path instead of gdb_sysroot if it is valid.
9367
9368 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9369
9370         * symfile.c (find_separate_debug_file): Use child_path to
9371         determine if an object file is under a sysroot.
9372
9373 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9374
9375         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9376         unittests/child-path-selftests.c.
9377         * common/pathstuff.c (child_path): New function.
9378         * common/pathstuff.h (child_path): New prototype.
9379         * unittests/child-path-selftests.c: New file.
9380
9381 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9382
9383         * symfile.c (find_separate_debug_file): Look for separate debug
9384         files in debug directories under the sysroot.
9385
9386 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9387
9388         * symtab.h (struct minimal_symbol data_p): New const method.
9389         (struct minimal_symbol text_p): Likewise.
9390         * symtab.c (output_source_filename): Use file name style
9391         to print file name.
9392         (print_symbol_info): Likewise.
9393         (print_msymbol_info): Use address style to print addresses.
9394         Use function name style to print executable text symbols.
9395         (expand_symtab_containing_pc): Use data_p.
9396         (find_pc_sect_compunit_symtab): Likewise.
9397
9398 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9399
9400         * breakpoint.c (describe_other_breakpoints): Use address style
9401         to print addresses.
9402         (say_where): Likewise.
9403
9404 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9405
9406         * ada-typeprint.c (print_func_type): Print function name
9407         style to print function name.
9408         * c-typeprint.c (c_print_type_1): Likewise.
9409
9410 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9411
9412         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9413         for execve.
9414
9415 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9416
9417         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9418         type_stack.
9419
9420 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9421
9422         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9423         TYPE_CODE_REF types.
9424
9425 2019-02-08  Jim Wilson  <jimw@sifive.com>
9426
9427         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9428         (riscv_linux_fregset): New.
9429         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9430
9431 2019-02-07  Tom Tromey  <tom@tromey.com>
9432
9433         * thread.c (thread_cancel_execution_command): Update.
9434         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9435         methods.
9436         (struct thread_fsm_ops): Remove.
9437         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9438         (thread_fsm_should_stop, thread_fsm_return_value)
9439         (thread_fsm_set_finished, thread_fsm_finished_p)
9440         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9441         Don't declare.
9442         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9443         * infrun.c (clear_proceed_status_thread)
9444         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9445         (print_stop_event): Update.
9446         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9447         Add constructor.
9448         (step_command_fsm_ops): Remove.
9449         (new_step_command_fsm): Remove.
9450         (step_1): Update.
9451         (step_command_fsm::should_stop): Rename from
9452         step_command_fsm_should_stop.
9453         (step_command_fsm::clean_up): Rename from
9454         step_command_fsm_clean_up.
9455         (step_command_fsm::do_async_reply_reason): Rename from
9456         step_command_fsm_async_reply_reason.
9457         (struct until_next_fsm): Inherit from thread_fsm.  Add
9458         constructor.
9459         (until_next_fsm_ops): Remove.
9460         (new_until_next_fsm): Remove.
9461         (until_next_fsm::should_stop): Rename from
9462         until_next_fsm_should_stop.
9463         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9464         (until_next_fsm::do_async_reply_reason): Rename from
9465         until_next_fsm_async_reply_reason.
9466         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9467         constructor.  Change type of breakpoint.
9468         (finish_command_fsm_ops): Remove.
9469         (new_finish_command_fsm): Remove.
9470         (finish_command_fsm::should_stop): Rename from
9471         finish_command_fsm_should_stop.
9472         (finish_command_fsm::clean_up): Rename from
9473         finish_command_fsm_clean_up.
9474         (finish_command_fsm::return_value): Rename from
9475         finish_command_fsm_return_value.
9476         (finish_command_fsm::do_async_reply_reason): Rename from
9477         finish_command_fsm_async_reply_reason.
9478         (finish_command): Update.
9479         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9480         Add constructor.
9481         (call_thread_fsm_ops): Remove.
9482         (call_thread_fsm::call_thread_fsm): Rename from
9483         new_call_thread_fsm.
9484         (call_thread_fsm::should_stop): Rename from
9485         call_thread_fsm_should_stop.
9486         (call_thread_fsm::should_notify_stop): Rename from
9487         call_thread_fsm_should_notify_stop.
9488         (run_inferior_call, call_function_by_hand_dummy): Update.
9489         * cli/cli-interp.c (should_print_stop_to_console): Update.
9490         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9491         Add constructor.  Change type of location_breakpoint,
9492         caller_breakpoint.
9493         (until_break_fsm_ops): Remove.
9494         (new_until_break_fsm): Remove.
9495         (until_break_fsm::should_stop): Rename from
9496         until_break_fsm_should_stop.
9497         (until_break_fsm::clean_up): Rename from
9498         until_break_fsm_clean_up.
9499         (until_break_fsm::do_async_reply_reason): Rename from
9500         until_break_fsm_async_reply_reason.
9501         (until_break_command): Update.
9502         * thread-fsm.c: Remove.
9503         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9504
9505 2019-02-07  Tom Tromey  <tom@tromey.com>
9506
9507         * yy-remap.h: Add include guard.
9508         * xtensa-tdep.h: Add include guard.
9509         * xcoffread.h: Rename include guard.
9510         * varobj-iter.h: Add include guard.
9511         * tui/tui.h: Rename include guard.
9512         * tui/tui-winsource.h: Rename include guard.
9513         * tui/tui-wingeneral.h: Rename include guard.
9514         * tui/tui-windata.h: Rename include guard.
9515         * tui/tui-win.h: Rename include guard.
9516         * tui/tui-stack.h: Rename include guard.
9517         * tui/tui-source.h: Rename include guard.
9518         * tui/tui-regs.h: Rename include guard.
9519         * tui/tui-out.h: Rename include guard.
9520         * tui/tui-layout.h: Rename include guard.
9521         * tui/tui-io.h: Rename include guard.
9522         * tui/tui-hooks.h: Rename include guard.
9523         * tui/tui-file.h: Rename include guard.
9524         * tui/tui-disasm.h: Rename include guard.
9525         * tui/tui-data.h: Rename include guard.
9526         * tui/tui-command.h: Rename include guard.
9527         * tic6x-tdep.h: Add include guard.
9528         * target/waitstatus.h: Rename include guard.
9529         * target/wait.h: Rename include guard.
9530         * target/target.h: Rename include guard.
9531         * target/resume.h: Rename include guard.
9532         * target-float.h: Rename include guard.
9533         * stabsread.h: Add include guard.
9534         * rs6000-tdep.h: Add include guard.
9535         * riscv-fbsd-tdep.h: Add include guard.
9536         * regformats/regdef.h: Rename include guard.
9537         * record.h: Rename include guard.
9538         * python/python.h: Rename include guard.
9539         * python/python-internal.h: Rename include guard.
9540         * python/py-stopevent.h: Rename include guard.
9541         * python/py-ref.h: Rename include guard.
9542         * python/py-record.h: Rename include guard.
9543         * python/py-record-full.h: Rename include guard.
9544         * python/py-record-btrace.h: Rename include guard.
9545         * python/py-instruction.h: Rename include guard.
9546         * python/py-events.h: Rename include guard.
9547         * python/py-event.h: Rename include guard.
9548         * procfs.h: Add include guard.
9549         * proc-utils.h: Add include guard.
9550         * p-lang.h: Add include guard.
9551         * or1k-tdep.h: Rename include guard.
9552         * observable.h: Rename include guard.
9553         * nto-tdep.h: Rename include guard.
9554         * nat/x86-linux.h: Rename include guard.
9555         * nat/x86-linux-dregs.h: Rename include guard.
9556         * nat/x86-gcc-cpuid.h: Add include guard.
9557         * nat/x86-dregs.h: Rename include guard.
9558         * nat/x86-cpuid.h: Rename include guard.
9559         * nat/ppc-linux.h: Rename include guard.
9560         * nat/mips-linux-watch.h: Rename include guard.
9561         * nat/linux-waitpid.h: Rename include guard.
9562         * nat/linux-ptrace.h: Rename include guard.
9563         * nat/linux-procfs.h: Rename include guard.
9564         * nat/linux-osdata.h: Rename include guard.
9565         * nat/linux-nat.h: Rename include guard.
9566         * nat/linux-namespaces.h: Rename include guard.
9567         * nat/linux-btrace.h: Rename include guard.
9568         * nat/glibc_thread_db.h: Rename include guard.
9569         * nat/gdb_thread_db.h: Rename include guard.
9570         * nat/gdb_ptrace.h: Rename include guard.
9571         * nat/fork-inferior.h: Rename include guard.
9572         * nat/amd64-linux-siginfo.h: Rename include guard.
9573         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9574         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9575         * nat/aarch64-linux.h: Rename include guard.
9576         * nat/aarch64-linux-hw-point.h: Rename include guard.
9577         * mn10300-tdep.h: Add include guard.
9578         * mips-linux-tdep.h: Add include guard.
9579         * mi/mi-parse.h: Rename include guard.
9580         * mi/mi-out.h: Rename include guard.
9581         * mi/mi-main.h: Rename include guard.
9582         * mi/mi-interp.h: Rename include guard.
9583         * mi/mi-getopt.h: Rename include guard.
9584         * mi/mi-console.h: Rename include guard.
9585         * mi/mi-common.h: Rename include guard.
9586         * mi/mi-cmds.h: Rename include guard.
9587         * mi/mi-cmd-break.h: Rename include guard.
9588         * m2-lang.h: Add include guard.
9589         * location.h: Rename include guard.
9590         * linux-record.h: Rename include guard.
9591         * linux-nat.h: Add include guard.
9592         * linux-fork.h: Add include guard.
9593         * i386-darwin-tdep.h: Rename include guard.
9594         * hppa-linux-offsets.h: Add include guard.
9595         * guile/guile.h: Rename include guard.
9596         * guile/guile-internal.h: Rename include guard.
9597         * gnu-nat.h: Rename include guard.
9598         * gdb-stabs.h: Rename include guard.
9599         * frv-tdep.h: Add include guard.
9600         * f-lang.h: Add include guard.
9601         * event-loop.h: Add include guard.
9602         * darwin-nat.h: Rename include guard.
9603         * cp-abi.h: Rename include guard.
9604         * config/sparc/nm-sol2.h: Rename include guard.
9605         * config/nm-nto.h: Rename include guard.
9606         * config/nm-linux.h: Add include guard.
9607         * config/i386/nm-i386gnu.h: Rename include guard.
9608         * config/djgpp/nl_types.h: Rename include guard.
9609         * config/djgpp/langinfo.h: Rename include guard.
9610         * compile/gcc-cp-plugin.h: Add include guard.
9611         * compile/gcc-c-plugin.h: Add include guard.
9612         * compile/compile.h: Rename include guard.
9613         * compile/compile-object-run.h: Rename include guard.
9614         * compile/compile-object-load.h: Rename include guard.
9615         * compile/compile-internal.h: Rename include guard.
9616         * compile/compile-cplus.h: Rename include guard.
9617         * compile/compile-c.h: Rename include guard.
9618         * common/xml-utils.h: Rename include guard.
9619         * common/x86-xstate.h: Rename include guard.
9620         * common/version.h: Rename include guard.
9621         * common/vec.h: Rename include guard.
9622         * common/tdesc.h: Rename include guard.
9623         * common/selftest.h: Rename include guard.
9624         * common/scoped_restore.h: Rename include guard.
9625         * common/scoped_mmap.h: Rename include guard.
9626         * common/scoped_fd.h: Rename include guard.
9627         * common/safe-iterator.h: Rename include guard.
9628         * common/run-time-clock.h: Rename include guard.
9629         * common/refcounted-object.h: Rename include guard.
9630         * common/queue.h: Rename include guard.
9631         * common/ptid.h: Rename include guard.
9632         * common/print-utils.h: Rename include guard.
9633         * common/preprocessor.h: Rename include guard.
9634         * common/pathstuff.h: Rename include guard.
9635         * common/observable.h: Rename include guard.
9636         * common/netstuff.h: Rename include guard.
9637         * common/job-control.h: Rename include guard.
9638         * common/host-defs.h: Rename include guard.
9639         * common/gdb_wait.h: Rename include guard.
9640         * common/gdb_vecs.h: Rename include guard.
9641         * common/gdb_unlinker.h: Rename include guard.
9642         * common/gdb_unique_ptr.h: Rename include guard.
9643         * common/gdb_tilde_expand.h: Rename include guard.
9644         * common/gdb_sys_time.h: Rename include guard.
9645         * common/gdb_string_view.h: Rename include guard.
9646         * common/gdb_splay_tree.h: Rename include guard.
9647         * common/gdb_setjmp.h: Rename include guard.
9648         * common/gdb_ref_ptr.h: Rename include guard.
9649         * common/gdb_optional.h: Rename include guard.
9650         * common/gdb_locale.h: Rename include guard.
9651         * common/gdb_assert.h: Rename include guard.
9652         * common/filtered-iterator.h: Rename include guard.
9653         * common/filestuff.h: Rename include guard.
9654         * common/fileio.h: Rename include guard.
9655         * common/environ.h: Rename include guard.
9656         * common/common-utils.h: Rename include guard.
9657         * common/common-types.h: Rename include guard.
9658         * common/common-regcache.h: Rename include guard.
9659         * common/common-inferior.h: Rename include guard.
9660         * common/common-gdbthread.h: Rename include guard.
9661         * common/common-exceptions.h: Rename include guard.
9662         * common/common-defs.h: Rename include guard.
9663         * common/common-debug.h: Rename include guard.
9664         * common/cleanups.h: Rename include guard.
9665         * common/buffer.h: Rename include guard.
9666         * common/btrace-common.h: Rename include guard.
9667         * common/break-common.h: Rename include guard.
9668         * cli/cli-utils.h: Rename include guard.
9669         * cli/cli-style.h: Rename include guard.
9670         * cli/cli-setshow.h: Rename include guard.
9671         * cli/cli-script.h: Rename include guard.
9672         * cli/cli-interp.h: Rename include guard.
9673         * cli/cli-decode.h: Rename include guard.
9674         * cli/cli-cmds.h: Rename include guard.
9675         * charset-list.h: Add include guard.
9676         * buildsym-legacy.h: Rename include guard.
9677         * bfin-tdep.h: Add include guard.
9678         * ax.h: Rename include guard.
9679         * arm-linux-tdep.h: Add include guard.
9680         * arm-fbsd-tdep.h: Add include guard.
9681         * arch/xtensa.h: Rename include guard.
9682         * arch/tic6x.h: Add include guard.
9683         * arch/i386.h: Add include guard.
9684         * arch/arm.h: Rename include guard.
9685         * arch/arm-linux.h: Rename include guard.
9686         * arch/arm-get-next-pcs.h: Rename include guard.
9687         * arch/amd64.h: Add include guard.
9688         * arch/aarch64-insn.h: Rename include guard.
9689         * arch-utils.h: Rename include guard.
9690         * annotate.h: Add include guard.
9691         * amd64-darwin-tdep.h: Rename include guard.
9692         * aarch64-linux-tdep.h: Add include guard.
9693         * aarch64-fbsd-tdep.h: Add include guard.
9694         * aarch32-linux-nat.h: Add include guard.
9695
9696 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9697
9698         * macrotab.c (macro_define_internal): New function that
9699         factorizes macro_define_object_internal and macro_define_function
9700         code.
9701         (macro_define_object_internal): Use macro_define_internal.
9702         (macro_define_function): Likewise.
9703
9704 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9705
9706         * macrocmd.c (extract_identifier): Return
9707         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9708         callers.
9709
9710 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9711
9712         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9713
9714 2019-02-05  Tom Tromey  <tom@tromey.com>
9715
9716         * target.c (target_stack::unpush): Move assertion earlier.
9717
9718 2019-01-30  Tom Tromey  <tom@tromey.com>
9719
9720         PR python/23615:
9721         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9722         (gdbpy_parse_and_eval): Likewise.
9723         * python/python-internal.h (gdbpy_allow_threads): New class.
9724
9725 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9726
9727         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9728         (aarch64_fbsd_fpregmap): Move earlier.
9729         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9730         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9731         instead of individual calls to trad_frame_set_reg_addr.
9732         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9733         earlier.
9734         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9735         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9736         instead of individual calls to trad_frame_set_reg_addr.
9737
9738 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9739
9740         * CONTRIBUTE: Replace contribution list with wiki link.
9741
9742 2019-01-25  Tom Tromey  <tom@tromey.com>
9743
9744         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9745
9746 2019-01-25  Tom Tromey  <tom@tromey.com>
9747
9748         * xtensa-linux-nat.c: Fix common/ includes.
9749         * xml-support.h: Fix common/ includes.
9750         * xml-support.c: Fix common/ includes.
9751         * x86-linux-nat.c: Fix common/ includes.
9752         * windows-nat.c: Fix common/ includes.
9753         * varobj.h: Fix common/ includes.
9754         * varobj.c: Fix common/ includes.
9755         * value.c: Fix common/ includes.
9756         * valops.c: Fix common/ includes.
9757         * utils.c: Fix common/ includes.
9758         * unittests/xml-utils-selftests.c: Fix common/ includes.
9759         * unittests/utils-selftests.c: Fix common/ includes.
9760         * unittests/unpack-selftests.c: Fix common/ includes.
9761         * unittests/tracepoint-selftests.c: Fix common/ includes.
9762         * unittests/style-selftests.c: Fix common/ includes.
9763         * unittests/string_view-selftests.c: Fix common/ includes.
9764         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9765         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9766         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9767         * unittests/rsp-low-selftests.c: Fix common/ includes.
9768         * unittests/parse-connection-spec-selftests.c: Fix common/
9769         includes.
9770         * unittests/optional-selftests.c: Fix common/ includes.
9771         * unittests/offset-type-selftests.c: Fix common/ includes.
9772         * unittests/observable-selftests.c: Fix common/ includes.
9773         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9774         * unittests/memrange-selftests.c: Fix common/ includes.
9775         * unittests/memory-map-selftests.c: Fix common/ includes.
9776         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9777         * unittests/function-view-selftests.c: Fix common/ includes.
9778         * unittests/environ-selftests.c: Fix common/ includes.
9779         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9780         * unittests/common-utils-selftests.c: Fix common/ includes.
9781         * unittests/cli-utils-selftests.c: Fix common/ includes.
9782         * unittests/array-view-selftests.c: Fix common/ includes.
9783         * ui-file.c: Fix common/ includes.
9784         * tui/tui-io.c: Fix common/ includes.
9785         * tracepoint.h: Fix common/ includes.
9786         * tracepoint.c: Fix common/ includes.
9787         * tracefile-tfile.c: Fix common/ includes.
9788         * top.h: Fix common/ includes.
9789         * top.c: Fix common/ includes.
9790         * thread.c: Fix common/ includes.
9791         * target/waitstatus.h: Fix common/ includes.
9792         * target/waitstatus.c: Fix common/ includes.
9793         * target.h: Fix common/ includes.
9794         * target.c: Fix common/ includes.
9795         * target-memory.c: Fix common/ includes.
9796         * target-descriptions.c: Fix common/ includes.
9797         * symtab.h: Fix common/ includes.
9798         * symfile.c: Fix common/ includes.
9799         * stap-probe.c: Fix common/ includes.
9800         * spu-linux-nat.c: Fix common/ includes.
9801         * sparc-nat.c: Fix common/ includes.
9802         * source.c: Fix common/ includes.
9803         * solib.c: Fix common/ includes.
9804         * solib-target.c: Fix common/ includes.
9805         * ser-unix.c: Fix common/ includes.
9806         * ser-tcp.c: Fix common/ includes.
9807         * ser-pipe.c: Fix common/ includes.
9808         * ser-base.c: Fix common/ includes.
9809         * selftest-arch.c: Fix common/ includes.
9810         * s12z-tdep.c: Fix common/ includes.
9811         * rust-exp.y: Fix common/ includes.
9812         * rs6000-aix-tdep.c: Fix common/ includes.
9813         * riscv-tdep.c: Fix common/ includes.
9814         * remote.c: Fix common/ includes.
9815         * remote-notif.h: Fix common/ includes.
9816         * remote-fileio.h: Fix common/ includes.
9817         * remote-fileio.c: Fix common/ includes.
9818         * regcache.h: Fix common/ includes.
9819         * regcache.c: Fix common/ includes.
9820         * record-btrace.c: Fix common/ includes.
9821         * python/python.c: Fix common/ includes.
9822         * python/py-type.c: Fix common/ includes.
9823         * python/py-inferior.c: Fix common/ includes.
9824         * progspace.h: Fix common/ includes.
9825         * producer.c: Fix common/ includes.
9826         * procfs.c: Fix common/ includes.
9827         * proc-api.c: Fix common/ includes.
9828         * printcmd.c: Fix common/ includes.
9829         * ppc-linux-nat.c: Fix common/ includes.
9830         * parser-defs.h: Fix common/ includes.
9831         * osdata.c: Fix common/ includes.
9832         * obsd-nat.c: Fix common/ includes.
9833         * nat/x86-linux.c: Fix common/ includes.
9834         * nat/x86-linux-dregs.c: Fix common/ includes.
9835         * nat/x86-dregs.h: Fix common/ includes.
9836         * nat/x86-dregs.c: Fix common/ includes.
9837         * nat/ppc-linux.c: Fix common/ includes.
9838         * nat/mips-linux-watch.h: Fix common/ includes.
9839         * nat/mips-linux-watch.c: Fix common/ includes.
9840         * nat/linux-waitpid.c: Fix common/ includes.
9841         * nat/linux-ptrace.h: Fix common/ includes.
9842         * nat/linux-ptrace.c: Fix common/ includes.
9843         * nat/linux-procfs.c: Fix common/ includes.
9844         * nat/linux-personality.c: Fix common/ includes.
9845         * nat/linux-osdata.c: Fix common/ includes.
9846         * nat/linux-namespaces.c: Fix common/ includes.
9847         * nat/linux-btrace.h: Fix common/ includes.
9848         * nat/linux-btrace.c: Fix common/ includes.
9849         * nat/fork-inferior.c: Fix common/ includes.
9850         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9851         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9852         * nat/aarch64-linux.c: Fix common/ includes.
9853         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9854         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9855         * namespace.h: Fix common/ includes.
9856         * mips-linux-tdep.c: Fix common/ includes.
9857         * minsyms.c: Fix common/ includes.
9858         * mi/mi-parse.h: Fix common/ includes.
9859         * mi/mi-main.c: Fix common/ includes.
9860         * mi/mi-cmd-env.c: Fix common/ includes.
9861         * memrange.h: Fix common/ includes.
9862         * memattr.c: Fix common/ includes.
9863         * maint.h: Fix common/ includes.
9864         * maint.c: Fix common/ includes.
9865         * main.c: Fix common/ includes.
9866         * machoread.c: Fix common/ includes.
9867         * location.c: Fix common/ includes.
9868         * linux-thread-db.c: Fix common/ includes.
9869         * linux-nat.c: Fix common/ includes.
9870         * linux-fork.c: Fix common/ includes.
9871         * inline-frame.c: Fix common/ includes.
9872         * infrun.c: Fix common/ includes.
9873         * inflow.c: Fix common/ includes.
9874         * inferior.h: Fix common/ includes.
9875         * inferior.c: Fix common/ includes.
9876         * infcmd.c: Fix common/ includes.
9877         * inf-ptrace.c: Fix common/ includes.
9878         * inf-child.c: Fix common/ includes.
9879         * ia64-linux-nat.c: Fix common/ includes.
9880         * i387-tdep.c: Fix common/ includes.
9881         * i386-tdep.c: Fix common/ includes.
9882         * i386-linux-tdep.c: Fix common/ includes.
9883         * i386-linux-nat.c: Fix common/ includes.
9884         * i386-go32-tdep.c: Fix common/ includes.
9885         * i386-fbsd-tdep.c: Fix common/ includes.
9886         * i386-fbsd-nat.c: Fix common/ includes.
9887         * guile/scm-type.c: Fix common/ includes.
9888         * guile/guile.c: Fix common/ includes.
9889         * go32-nat.c: Fix common/ includes.
9890         * gnu-nat.c: Fix common/ includes.
9891         * gdbthread.h: Fix common/ includes.
9892         * gdbarch-selftests.c: Fix common/ includes.
9893         * gdb_usleep.c: Fix common/ includes.
9894         * gdb_select.h: Fix common/ includes.
9895         * gdb_bfd.c: Fix common/ includes.
9896         * gcore.c: Fix common/ includes.
9897         * fork-child.c: Fix common/ includes.
9898         * findvar.c: Fix common/ includes.
9899         * fbsd-nat.c: Fix common/ includes.
9900         * event-top.c: Fix common/ includes.
9901         * event-loop.c: Fix common/ includes.
9902         * dwarf2read.c: Fix common/ includes.
9903         * dwarf2loc.c: Fix common/ includes.
9904         * dwarf2-frame.c: Fix common/ includes.
9905         * dwarf-index-cache.c: Fix common/ includes.
9906         * dtrace-probe.c: Fix common/ includes.
9907         * disasm-selftests.c: Fix common/ includes.
9908         * defs.h: Fix common/ includes.
9909         * csky-tdep.c: Fix common/ includes.
9910         * cp-valprint.c: Fix common/ includes.
9911         * cp-support.h: Fix common/ includes.
9912         * cp-support.c: Fix common/ includes.
9913         * corelow.c: Fix common/ includes.
9914         * completer.h: Fix common/ includes.
9915         * completer.c: Fix common/ includes.
9916         * compile/compile.c: Fix common/ includes.
9917         * compile/compile-loc2c.c: Fix common/ includes.
9918         * compile/compile-cplus-types.c: Fix common/ includes.
9919         * compile/compile-cplus-symbols.c: Fix common/ includes.
9920         * command.h: Fix common/ includes.
9921         * cli/cli-dump.c: Fix common/ includes.
9922         * cli/cli-cmds.c: Fix common/ includes.
9923         * charset.c: Fix common/ includes.
9924         * build-id.c: Fix common/ includes.
9925         * btrace.h: Fix common/ includes.
9926         * btrace.c: Fix common/ includes.
9927         * breakpoint.h: Fix common/ includes.
9928         * breakpoint.c: Fix common/ includes.
9929         * ax.h:
9930         (enum agent_op): Fix common/ includes.
9931         * ax-general.c (struct aop_map): Fix common/ includes.
9932         * ax-gdb.c: Fix common/ includes.
9933         * auxv.c: Fix common/ includes.
9934         * auto-load.c: Fix common/ includes.
9935         * arm-tdep.c: Fix common/ includes.
9936         * arch/riscv.c: Fix common/ includes.
9937         * arch/ppc-linux-common.c: Fix common/ includes.
9938         * arch/i386.c: Fix common/ includes.
9939         * arch/arm.c: Fix common/ includes.
9940         * arch/arm-linux.c: Fix common/ includes.
9941         * arch/arm-get-next-pcs.c: Fix common/ includes.
9942         * arch/amd64.c: Fix common/ includes.
9943         * arch/aarch64.c: Fix common/ includes.
9944         * arch/aarch64-insn.c: Fix common/ includes.
9945         * arch-utils.c: Fix common/ includes.
9946         * amd64-windows-tdep.c: Fix common/ includes.
9947         * amd64-tdep.c: Fix common/ includes.
9948         * amd64-sol2-tdep.c: Fix common/ includes.
9949         * amd64-obsd-tdep.c: Fix common/ includes.
9950         * amd64-nbsd-tdep.c: Fix common/ includes.
9951         * amd64-linux-tdep.c: Fix common/ includes.
9952         * amd64-linux-nat.c: Fix common/ includes.
9953         * amd64-fbsd-tdep.c: Fix common/ includes.
9954         * amd64-fbsd-nat.c: Fix common/ includes.
9955         * amd64-dicos-tdep.c: Fix common/ includes.
9956         * amd64-darwin-tdep.c: Fix common/ includes.
9957         * agent.c: Fix common/ includes.
9958         * ada-lang.h: Fix common/ includes.
9959         * ada-lang.c: Fix common/ includes.
9960         * aarch64-tdep.c: Fix common/ includes.
9961
9962 2019-01-25  Tom Tromey  <tom@tromey.com>
9963
9964         * common/create-version.sh: Use common/version.h.
9965
9966 2019-01-24  Pedro Alves  <palves@redhat.com>
9967
9968         * infrun.c (signal_stop, signal_print, signal_program)
9969         (signal_catch, signal_pass): Now arrays instead of pointers.
9970         (update_signals_program_target, do_target_resume)
9971         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9972         * linux-nat.c (linux_nat_target::pass_signals)
9973         (linux_nat_target::create_inferior, linux_nat_target::attach):
9974         Adjust.
9975         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9976         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9977         * procfs.c (procfs_target::pass_signals): Adjust.
9978         * record-full.c (record_full_target::resume): Adjust.
9979         * remote.c (remote_target::pass_signals)
9980         (remote_target::program_signals): Adjust.
9981         * target-debug.h (target_debug_print_signals): Now takes a
9982         gdb::array_view as parameter.  Adjust.
9983         * target.h (target_ops) <pass_signals, program_signals>: Replace
9984         pointer and length parameters with gdb::array_view.
9985         (target_pass_signals, target_program_signals): Likewise.
9986         * target-delegates.c: Regenerate.
9987
9988 2019-01-24  Pedro Alves  <palves@redhat.com>
9989
9990         * common/forward-scope-exit.h
9991         (forward_scope_exit::forward_scope_exit): Pass arguments to
9992         m_bind_function directly, instead of creating a std::bind and
9993         copying that.
9994
9995 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9996
9997         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9998         for static members.
9999         (pass_in_v_vfp_candidate): Likewise.
10000
10001 2019-01-23  Tom Tromey  <tom@tromey.com>
10002             Pedro Alves  <palves@redhat.com>
10003
10004         * regcache.c (class regcache_invalidator): Remove.
10005         (regcache::raw_write): Use make_scope_exit.
10006
10007 2019-01-23  Tom Tromey  <tom@tromey.com>
10008
10009         * ui-out.h (class ui_out_emit_type): Update comment.
10010
10011 2019-01-23  Tom Tromey  <tom@tromey.com>
10012
10013         * infrun.c (fetch_inferior_event): Update comment.
10014
10015 2019-01-23  Tom Tromey  <tom@tromey.com>
10016             Pedro Alves  <palves@redhat.com>
10017
10018         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10019         parameter.
10020         (fetch_inferior_event): Use SCOPE_EXIT.
10021
10022
10023 2019-01-23  Tom Tromey  <tom@tromey.com>
10024             Pedro Alves  <palves@redhat.com>
10025
10026         * infrun.c (disable_thread_events): Delete.
10027         (stop_all_threads): Use SCOPE_EXIT.
10028
10029 2019-01-23  Tom Tromey  <tom@tromey.com>
10030             Pedro Alves  <palves@redhat.com>
10031
10032         * symfile.c: Include forward-scope-exit.h.
10033         (clear_symtab_users_cleanup): Replace forward declaration with
10034         a FORWARD_SCOPE_EXIT.
10035         (syms_from_objfile_1): Use the forward_scope_exit and
10036         gdb::optional instead of cleanup_function.
10037         (reread_symbols): Use the forward_scope_exit instead of
10038         cleanup_function.
10039         (clear_symtab_users_cleanup): Remove function.
10040
10041 2019-01-23  Tom Tromey  <tom@tromey.com>
10042             Pedro Alves  <palves@redhat.com>
10043
10044         * linux-nat.c: Include scope-exit.h.
10045         (cleanup_target_stop): Remove.
10046         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10047         SCOPE_EXIT.
10048
10049 2019-01-23  Tom Tromey  <tom@tromey.com>
10050             Pedro Alves  <palves@redhat.com>
10051
10052         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10053         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10054
10055 2019-01-23  Tom Tromey  <tom@tromey.com>
10056             Andrew Burgess  <andrew.burgess@embecosm.com>
10057             Pedro Alves  <palves@redhat.com>
10058
10059         * infrun.c (fetch_inferior_event): Use scope_exit.
10060         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10061         * top.c (execute_command): Use scope_exit.
10062         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10063         * utils.c (do_bpstat_clear_actions_cleanup)
10064         (make_bpstat_clear_actions_cleanup): Remove.
10065
10066 2019-01-23  Tom Tromey  <tom@tromey.com>
10067             Pedro Alves  <palves@redhat.com>
10068
10069         * infrun.c: Include "common/scope-exit.h"
10070         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10071         (wait_for_inferior): Use SCOPE_EXIT.
10072         (fetch_inferior_event): Use scope_exit.
10073
10074 2019-01-23  Tom Tromey  <tom@tromey.com>
10075             Pedro Alves  <palves@redhat.com>
10076
10077         * breakpoint.c (create_breakpoint): Remove cleanup.
10078
10079 2019-01-23  Tom Tromey  <tom@tromey.com>
10080             Andrew Burgess  <andrew.burgess@embecosm.com>
10081             Pedro Alves  <palves@redhat.com>
10082
10083 2019-01-23  Pedro Alves  <palves@redhat.com>
10084
10085         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10086
10087 2019-01-23  Pedro Alves  <palves@redhat.com>
10088             Andrew Burgess  <andrew.burgess@embecosm.com>
10089
10090         * gdbthread.h: Include "common/forward-scope-exit.h".
10091         (scoped_finish_thread_state): Redefine custom class in terms of
10092         forward_scope_exit.
10093
10094 2019-01-23  Pedro Alves  <palves@redhat.com>
10095             Andrew Burgess  <andrew.burgess@embecosm.com>
10096
10097         * common/forward-scope-exit.h: New file.
10098
10099 2019-01-23  Pedro Alves  <palves@redhat.com>
10100             Andrew Burgess  <andrew.burgess@embecosm.com>
10101             Tom Tromey  <tom@tromey.com>
10102
10103         * common/scope-exit.h: New file.
10104
10105 2019-01-23  Pedro Alves  <palves@redhat.com>
10106
10107         * common/preprocessor.h (ESC): Rename to ...
10108         (ESC_PARENS): ... this.
10109         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10110         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10111
10112 2019-01-23  Tom Tromey  <tom@tromey.com>
10113
10114         * language.h (class scoped_switch_to_sym_language_if_auto):
10115         Initialize m_lang in both cases.
10116
10117 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10118
10119         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10120         with XCNEW.
10121
10122 2019-01-22  Tom Tromey  <tom@tromey.com>
10123
10124         * corelow.c: Do not include sys/file.h.
10125
10126 2019-01-22  Tom Tromey  <tom@tromey.com>
10127
10128         * tui/tui-wingeneral.h: Include gdb_curses.h.
10129
10130 2019-01-22  Tom Tromey  <tom@tromey.com>
10131
10132         * source-cache.h (class source_cache) <get_source_lines,
10133         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10134
10135 2019-01-22  Tom Tromey  <tom@tromey.com>
10136
10137         * remote-fileio.h (struct remote_target): Declare.
10138
10139 2019-01-22  Tom Tromey  <tom@tromey.com>
10140
10141         * python/py-arch.c: Do not include py-ref.h.
10142         * python/py-bpevent.c: Do not include py-ref.h.
10143         * python/py-cmd.c: Do not include py-ref.h.
10144         * python/py-continueevent.c: Do not include py-ref.h.
10145         * python/py-event.h: Do not include py-ref.h.
10146         * python/py-evtregistry.c: Do not include py-ref.h.
10147         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10148         * python/py-frame.c: Do not include py-ref.h.
10149         * python/py-framefilter.c: Do not include py-ref.h.
10150         * python/py-function.c: Do not include py-ref.h.
10151         * python/py-infevents.c: Do not include py-ref.h.
10152         * python/py-linetable.c: Do not include py-ref.h.
10153         * python/py-objfile.c: Do not include py-ref.h.
10154         * python/py-param.c: Do not include py-ref.h.
10155         * python/py-prettyprint.c: Do not include py-ref.h.
10156         * python/py-progspace.c: Do not include py-ref.h.
10157         * python/py-symbol.c: Do not include py-ref.h.
10158         * python/py-symtab.c: Do not include py-ref.h.
10159         * python/py-type.c: Do not include py-ref.h.
10160         * python/py-unwind.c: Do not include py-ref.h.
10161         * python/py-utils.c: Do not include py-ref.h.
10162         * python/py-value.c: Do not include py-ref.h.
10163         * python/py-varobj.c: Do not include py-ref.h.
10164         * python/py-xmethods.c: Do not include py-ref.h.
10165         * python/python.c: Do not include py-ref.h.
10166         * varobj.c: Do not include py-ref.h.
10167
10168 2019-01-22  Tom Tromey  <tom@tromey.com>
10169
10170         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10171         keyword for bcache.
10172
10173 2019-01-22  Tom Tromey  <tom@tromey.com>
10174
10175         * compile/compile-cplus-types.c: Remove a comment by #include.
10176
10177 2019-01-22  Tom Tromey  <tom@tromey.com>
10178
10179         * compile/gcc-c-plugin.h: Include compile-internal.h.
10180
10181 2019-01-22  Tom Tromey  <tom@tromey.com>
10182
10183         * stabsread.c (EXTERN): Do not define.
10184         (symnum, next_symbol_text_func, processing_gcc_compilation)
10185         (within_function, global_sym_chain, global_stabs)
10186         (previous_stab_code, this_object_header_files)
10187         (n_this_object_header_files)
10188         (n_allocated_this_object_header_files): Define.
10189         * stabsread.h (EXTERN): Never define.  Use "extern".
10190
10191 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10192
10193         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10194         history_value.
10195
10196 2019-01-21  Tom Tromey  <tom@tromey.com>
10197
10198         * ui-out.c: Fix includes.
10199         * tui/tui-source.c: Fix includes.
10200         * target.c: Fix includes.
10201         * remote.c: Fix includes.
10202         * regcache.c: Fix includes.
10203         * python/py-block.c: Fix includes.
10204         * printcmd.c: Fix includes.
10205         * or1k-tdep.c: Fix includes.
10206         * mi/mi-main.c: Fix includes.
10207         * m32r-tdep.c: Fix includes.
10208         * csky-tdep.c: Fix includes.
10209         * compile/compile-cplus-types.c: Fix includes.
10210         * cli/cli-interp.c: Fix includes.
10211
10212 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10213
10214         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10215         for padding.
10216
10217 2019-01-16  Tom Tromey  <tom@tromey.com>
10218
10219         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10220         earlier.
10221         (struct objfile) <msymbols_range>: Move from top level.
10222         <msymbols>: New method.
10223         (class objfile_msymbols): Remove.
10224         * symtab.c (default_collect_symbol_completion_matches_break_on):
10225         Update.
10226         * symmisc.c (dump_msymbols): Update.
10227         * stabsread.c (scan_file_globals): Update.
10228         * objc-lang.c (info_selectors_command, info_classes_command)
10229         (find_methods): Update.
10230         * minsyms.c (find_solib_trampoline_target): Update.
10231         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10232         * coffread.c (coff_symfile_read): Update.
10233         * ada-lang.c (ada_lookup_simple_minsym)
10234         (ada_collect_symbol_completion_matches): Update.
10235
10236 2019-01-16  Tom Tromey  <tom@tromey.com>
10237
10238         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10239         type.  Remove no-argument constructor.
10240         <iterator::operator++>: Simplify.
10241         <begin>: Update.
10242         <end>: Use minimal_symbol_count.
10243
10244 2019-01-16  Tom Tromey  <tom@tromey.com>
10245
10246         * objfiles.h (struct objfile) <psymtabs>: New method.
10247         (class objfile_psymtabs): Remove.
10248         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10249         typedef.
10250         <range>: New method.
10251         (require_partial_symbols): Change return type.
10252         * psymtab.c (require_partial_symbols)
10253         (psym_expand_symtabs_matching): Update.
10254         * mdebugread.c (parse_partial_symbols): Update.
10255         * dbxread.c (dbx_end_psymtab): Update.
10256
10257 2019-01-15  Tom Tromey  <tom@tromey.com>
10258
10259         * symtab.c (lookup_objfile_from_block)
10260         (lookup_symbol_in_objfile_symtabs)
10261         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10262         (find_line_symtab, info_sources_command)
10263         (default_collect_symbol_completion_matches_break_on)
10264         (make_source_files_completion_list): Update.
10265         * symmisc.c (print_objfile_statistics, dump_objfile)
10266         (maintenance_print_symbols, maintenance_info_symtabs)
10267         (maintenance_check_symtabs, maintenance_info_line_tables):
10268         Update.
10269         * source.c (select_source_symtab)
10270         (forget_cached_source_info_for_objfile): Update.
10271         * objfiles.h (class objfile_compunits): Remove.
10272         (struct objfile) <compunits_range>: New typedef.
10273         (compunits): New method.
10274         * objfiles.c (objfile_relocate1): Update.
10275         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10276         * maint.c (count_symtabs_and_blocks): Update.
10277         * linespec.c (iterate_over_all_matching_symtabs): Update.
10278         * cp-support.c (add_symbol_overload_list_qualified): Update.
10279         * coffread.c (coff_symtab_read): Update.
10280         * ada-lang.c (add_nonlocal_symbols)
10281         (ada_collect_symbol_completion_matches)
10282         (ada_add_global_exceptions): Update.
10283
10284 2019-01-15  Tom Tromey  <tom@tromey.com>
10285
10286         * progspace.h (program_space) <objfiles_safe_range>: New
10287         typedef.
10288         <objfiles_safe>: New method.
10289         * objfiles.h (class all_objfiles_safe): Remove.
10290         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10291         * jit.c (jit_inferior_exit_hook): Update.
10292
10293 2019-01-17  Tom Tromey  <tom@tromey.com>
10294
10295         * progspace.h (program_space) <objfiles_range>: New typedef.
10296         <objfiles>: New method.
10297         <objfiles_head>: Rename from objfiles.
10298         (object_files): Update.
10299         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10300         * guile/scm-pretty-print.c
10301         (ppscm_find_pretty_printer_from_objfiles): Update.
10302         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10303         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10304         Update.
10305         * python/py-progspace.c (pspy_get_objfiles): Update.
10306         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10307         Update.
10308         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10309         (objfpy_lookup_objfile_by_build_id): Update.
10310         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10311         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10312         Update.
10313         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10314         (expand_symtab_containing_pc, lookup_objfile_from_block)
10315         (lookup_static_symbol, basic_lookup_transparent_type)
10316         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10317         (find_line_symtab, info_sources_command)
10318         (default_collect_symbol_completion_matches_break_on)
10319         (make_source_files_completion_list, find_main_name): Update.
10320         * symmisc.c (print_symbol_bcache_statistics)
10321         (print_objfile_statistics, maintenance_print_symbols)
10322         (maintenance_print_msymbols, maintenance_print_objfiles)
10323         (maintenance_info_symtabs, maintenance_check_symtabs)
10324         (maintenance_expand_symtabs, maintenance_info_line_tables):
10325         Update.
10326         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10327         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10328         (map_overlay_command, unmap_overlay_command)
10329         (simple_overlay_update, expand_symtabs_matching)
10330         (map_symbol_filenames): Update.
10331         * symfile-debug.c (set_debug_symfile): Update.
10332         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10333         Update.
10334         * source.c (select_source_symtab, forget_cached_source_info):
10335         Update.
10336         * solib.c (solib_read_symbols): Update.
10337         * solib-spu.c (append_ocl_sos): Update.
10338         * psymtab.c (maintenance_print_psymbols)
10339         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10340         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10341         * printcmd.c (info_symbol_command): Update.
10342         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10343         Update.
10344         * objfiles.h (class all_objfiles): Remove.
10345         * objfiles.c (have_partial_symbols, have_full_symbols)
10346         (have_minimal_symbols, qsort_cmp, update_section_map)
10347         (shared_objfile_contains_address_p)
10348         (default_iterate_over_objfiles_in_search_order): Update.
10349         * objc-lang.c (info_selectors_command, info_classes_command)
10350         (find_methods): Update.
10351         * minsyms.c (find_solib_trampoline_target): Update.
10352         * maint.c (maintenance_info_sections)
10353         (maintenance_translate_address, count_symtabs_and_blocks):
10354         Update.
10355         * main.c (captured_main_1): Update.
10356         * linux-thread-db.c (try_thread_db_load_from_pdir)
10357         (has_libpthread): Update.
10358         * linespec.c (iterate_over_all_matching_symtabs)
10359         (search_minsyms_for_name): Update.
10360         * jit.c (jit_find_objf_with_entry_addr): Update.
10361         * hppa-tdep.c (find_unwind_entry)
10362         (hppa_lookup_stub_minimal_symbol): Update.
10363         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10364         Update.
10365         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10366         (elf_gnu_ifunc_resolve_by_got): Update.
10367         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10368         * dwarf-index-write.c (save_gdb_index_command): Update.
10369         * cp-support.c (add_symbol_overload_list_qualified): Update.
10370         * breakpoint.c (create_overlay_event_breakpoint)
10371         (create_longjmp_master_breakpoint)
10372         (create_std_terminate_master_breakpoint)
10373         (create_exception_master_breakpoint): Update.
10374         * blockframe.c (find_pc_partial_function): Update.
10375         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10376         (ada_collect_symbol_completion_matches)
10377         (ada_add_global_exceptions): Update.
10378
10379 2019-01-17  Tom Tromey  <tom@tromey.com>
10380
10381         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10382         declare VEC.
10383         (solib_target_parse_libraries): Change return type.
10384         (library_list_start_segment, library_list_start_section)
10385         (library_list_end_library, library_list_start_library); Update.
10386         (solib_target_free_library_list): Remove.
10387         (solib_target_parse_libraries): Remove cleanup.  Change return
10388         type.
10389         (solib_target_current_sos): Update.
10390
10391 2019-01-17  Tom Tromey  <tromey@bapiya>
10392
10393         * valprint.c: Replace "the the" with "the".
10394         * symtab.c: Replace "the the" with "the".
10395         * solib.c: Replace "the the" with "the".
10396         * solib-dsbt.c: Replace "the the" with "the".
10397         * linespec.c: Replace "the the" with "the".
10398         * dwarf2loc.h: Replace "the the" with "the".
10399         * amd64-windows-tdep.c: Replace "the the" with "the".
10400         * aarch64-tdep.c: Replace "the the" with "the".
10401
10402 2019-01-16  Keith Seitz  <keiths@redhat.com>
10403
10404         PR gdb/23773
10405         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10406         <builder>: Rename to ..
10407         <m_builder>: ... this and make private.
10408         (dwarf2_cu::get_builder): New method.  Change all users of
10409         `builder' to use this method.
10410         (dwarf2_start_symtab): Move to ...
10411         (dwarf2_cu::start_symtab): ... here.  Update all callers
10412         (setup_type_unit_groups): Move to ...
10413         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10414         callers.
10415         (dwarf2_cu::reset_builder): New method.
10416         (process_full_compunit, process_full_type_unit): Use
10417         dwarf2_cu::reset_builder.
10418         (follow_die_offset): Record the ancestor CU if it is different
10419         from the followed DIE's CU.
10420         (follow_die_sig_1): Likewise.
10421
10422 2019-01-15  Tom Tromey  <tom@tromey.com>
10423
10424         * remote.c (class remote_state) <buf>: Now a char_vector.
10425         <buf_size>: Remove.
10426         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10427         parameter.
10428         (remote_target::getpkt_or_notif_sane_1)
10429         (remote_target::getpkt_sane)
10430         (remote_target::getpkt_or_notif_sane): Likewise.
10431         (class remote_target) <putpkt>: New overload.
10432         (remote_target::read_frame): Change type of "buf_p".  Remove
10433         sizeof_p parameter.
10434         (packet_ok): New overload.
10435         (packet_check_result): New overload.
10436         Update all uses.
10437
10438 2019-01-14  Tom Tromey  <tom@tromey.com>
10439
10440         * remote-notif.c (handle_notification, remote_notif_ack)
10441         (remote_notif_parse): Make "buf" const.
10442         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10443         const.
10444         (remote_notif_parse, remote_notif_ack, handle_notification):
10445         Likewise.
10446         * remote.c (remote_notif_stop_parse): Make "buf" const.
10447         (remote_target::remote_parse_stop_reply): Make "buf" const.
10448         (remote_notif_stop_ack): Make "buf" const.
10449
10450 2019-01-14  Tom Tromey  <tom@tromey.com>
10451
10452         * remote.c (remote_console_output): Make parameter const.
10453
10454 2019-01-14  Tom Tromey  <tom@tromey.com>
10455
10456         * target-debug.h (target_debug_print_signals): Constify.
10457         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10458         * procfs.c (procfs_target::pass_signals): Update.
10459         * linux-nat.c (linux_nat_target::pass_signals): Update.
10460         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10461         * target-delegates.c: Rebuild.
10462         * remote.c (remote_target::program_signals): Update.
10463         (remote_target::pass_signals): Update.
10464         * target.c (target_pass_signals): Constify argument.
10465         (target_program_signals): Likewise.
10466         * target.h (struct target_ops) <pass_signals, program_signals>:
10467         Constify argument.
10468         (target_pass_signals, target_program_signals): Constify argument.
10469
10470 2019-01-14  Tom Tromey  <tom@tromey.com>
10471
10472         PR tui/28819:
10473         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10474
10475 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10476
10477         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10478         field.
10479         * rs6000-tdep.c: Include reggroups.h.
10480         (IS_V_ALIAS_PSEUDOREG): Define.
10481         (rs6000_register_name): Return names for the "vX" aliases.
10482         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10483         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10484         aliases.  Call default_register_reggroup_p for all other
10485         pseudo-registers.
10486         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10487         New functions.
10488         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10489         Handle "vX" aliases.
10490         (v_alias_pseudo_register_collect): New function.
10491         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10492         (rs6000_gdbarch_init): Initialize "vX" aliases as
10493         pseudo-registers.  Restore registration of
10494         rs6000_pseudo_register_reggroup_p with
10495         set_tdesc_pseudo_register_reggroup_p.
10496
10497 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10498
10499         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10500         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10501         set_gdbarch_num_pseudo_regs.
10502
10503 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10504
10505         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10506         Remove arg prefixname, add do_set and do_show.
10507         Add member functions set_list and show_list.
10508         * cli/cli-style.c (class cli_style_option): Update accordingly.
10509         (style_set_list): Move to file scope.
10510         (style_show_list): Likewise.
10511         (set_style): Call help_list.
10512         (show_style): Call cmd_show_list.
10513         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10514         Update to use the new macro.
10515
10516 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10517
10518         * ada-lang.c (_initialize_ada_language): Expand the help text
10519         for the "catch exception" command.
10520
10521 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10522
10523         * symtab.c (matching_obj_sections): Initialize obj,
10524         declare it closer to its usage.
10525
10526 2019-01-10  Tom Tromey  <tom@tromey.com>
10527
10528         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10529         (basic_inf_threads_range): Remove.
10530         (inf_threads_range, inf_non_exited_threads_range)
10531         (safe_inf_threads_range): Use next_adapter.
10532
10533 2019-01-10  Keith Seitz  <keiths@redhat.com>
10534
10535         PR gdb/23712
10536         PR symtab/23010
10537         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10538         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10539
10540 2019-01-10  Keith Seitz  <keiths@redhat.com>
10541
10542         PR gdb/23712
10543         PR symtab/23010
10544         * dictionary.c (pending_to_vector): Remove.
10545         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10546         Remove _1 suffix, replacing functions of the same name.  Update
10547         all callers.
10548         (dict_create_hashed, dict_create_hashed_expandable)
10549         (dict_create_linear, dict_create_linear_expandable, dict_free)
10550         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10551         Make functions static.
10552
10553 2019-01-10  Keith Seitz  <keiths@redhat.com>
10554
10555         PR gdb/23712
10556         PR symtab/23010
10557         * dictionary.h (struct dictionary): Replace declaration with
10558         multidictionary.
10559         (dict_create_hashed, dict_create_hashed_expandable)
10560         (dict_create_linear, dict_create_linear_expandable)
10561         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10562         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10563         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10564         taking multidictionary argument.
10565         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10566         * block.h (struct block) <dict>: Change to multidictionary
10567         and rename `multidict'.
10568         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10569         symmisc.c: Update all dictionary references to multidictionary.
10570
10571 2019-01-10  Keith Seitz  <keiths@redhat.com>
10572
10573         PR gdb/23712
10574         PR symtab/23010
10575         * dictionary.c: Include unordered_map.
10576         (pending_to_vector): New function.
10577         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10578         Rewrite the non-"_1" functions to take vector instead
10579         of linked list.
10580         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10581         "new" _1 versions of the same name.
10582         (multidictionary): Define.
10583         (std::hash<enum language): New definition.
10584         (collate_pending_symbols_by_language, mdict_create_hashed)
10585         (mdict_create_hashed_expandable, mdict_create_linear)
10586         (mdict_create_linear_expandable, mdict_free)
10587         (find_language_dictionary, create_new_language_dictionary)
10588         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10589         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10590         (mdict_size, mdict_empty): New functions.
10591         * dictionary.h (mdict_iterator): Define.
10592
10593 2019-01-10  Pedro Alves  <palves@redhat.com>
10594
10595         * breakpoint.c (read_uploaded_action)
10596         (create_tracepoint_from_upload): Adjust to use
10597         gdb::unique_xmalloc_ptr.
10598         * ctf.c (ctf_write_uploaded_tp):
10599         (SET_ARRAY_FIELD): Use emplace_back.
10600         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10601         * tracefile-tfile.c (tfile_write_uploaded_tp):
10602         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10603         gdb::unique_xmalloc_ptr.
10604         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10605         at_string, cond_string, cmd_strings>: Replace char pointers
10606         with gdb::unique_xmalloc_ptr.
10607
10608 2019-01-10  Pedro Alves  <palves@redhat.com>
10609
10610         * solib-target.c (library_list_start_library): Don't xstrdup name.
10611
10612 2019-01-10  Pedro Alves  <palves@redhat.com>
10613
10614         * mdebugread.c (parse_partial_symbols): Use
10615         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10616
10617 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10618
10619         * linux-fork.c (scoped_switch_fork_info)
10620         <~scoped_switch_fork_info>: Fix incorrect variable name.
10621
10622 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10623
10624         * linux-fork.c (scoped_switch_fork_info)
10625         <scoped_switch_fork_info>: Make explicit.
10626         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10627
10628 2019-01-10  Tom Tromey  <tom@tromey.com>
10629
10630         * objfiles.h (objfile::reset_psymtabs): Update.
10631         * objfiles.c (objfile::objfile): Update.
10632         * psymtab.h (psymtab_storage::obstack): Update.
10633         (psymtab_storage::m_obstack): Use gdb::optional.
10634         (class psymtab_storage): Update comment.  Remove objfile
10635         parameter.
10636         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10637
10638 2019-01-10  Tom Tromey  <tom@tromey.com>
10639
10640         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10641         <free_psymtabs>: Now private.
10642         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10643         (allocate_psymtab): Use new method.
10644
10645 2019-01-10  Tom Tromey  <tom@tromey.com>
10646
10647         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10648         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10649         * mdebugread.c (parse_partial_symbols): Use
10650         allocate_dependencies.
10651         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10652         allocate_dependencies.
10653         (process_psymtab_comp_unit_reader)
10654         (build_type_psymtab_dependencies): Likewise.
10655         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10656
10657 2019-01-10  Tom Tromey  <tom@tromey.com>
10658
10659         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10660         PSYMBOL_SET_LANGUAGE.
10661         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10662
10663 2019-01-10  Tom Tromey  <tom@tromey.com>
10664
10665         * psymtab.h (psymtab_storage::obstack): New method.
10666         <m_obstack>: Rename from obstack; now private.
10667         * psymtab.c (psymtab_storage): Update.
10668         * dwarf2read.c (create_addrmap_from_index)
10669         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10670         Update.
10671
10672 2019-01-10  Tom Tromey  <tom@tromey.com>
10673
10674         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10675         * objfiles.h (objfile::reset_psymtabs): New method.
10676
10677 2019-01-10  Tom Tromey  <tom@tromey.com>
10678
10679         * symmisc.c (print_symbol_bcache_statistics): Update.
10680         (print_objfile_statistics): Update.
10681         * symfile.c (reread_symbols): Update.
10682         * psymtab.h (class psymtab_storage): New.
10683         * psymtab.c (psymtab_storage): New constructor.
10684         (~psymtab_storage): New destructor.
10685         (require_partial_symbols): Update.
10686         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10687         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10688         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10689         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10690         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10691         (start_psymtab_common, end_psymtab_common)
10692         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10693         (allocate_psymtab): Update.
10694         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10695         Update.
10696         (dump_psymtab_addrmap, maintenance_print_psymbols)
10697         (maintenance_check_psymtabs): Update.
10698         (class objfile_psymtabs): Move to objfiles.h.
10699         * psympriv.h (discard_psymtab): Now inline.
10700         (psymtab_discarder::psymtab_discarder): Update.
10701         (psymtab_discarder::~psymtab_discarder): Update.
10702         (ALL_OBJFILE_PSYMTABS): Rewrite.
10703         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10704         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10705         Remove fields.
10706         <partial_symtabs>: New field.
10707         (class objfile_psymtabs): Move from psymtab.h.  Update.
10708         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10709         psymbol_cache.
10710         (objfile::~objfile): Don't destroy psymbol_cache.
10711         * mdebugread.c (parse_partial_symbols): Update.
10712         * dwarf2read.c (create_addrmap_from_index)
10713         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10714         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10715         (add_partial_subprogram, dwarf2_ranges_read): Update.
10716         * dwarf-index-write.c (write_address_map)
10717         (write_one_signatured_type, recursively_write_psymbols)
10718         (class debug_names, class debug_names, write_psymtabs_to_index):
10719         Update.
10720
10721 2019-01-10  Tom Tromey  <tom@tromey.com>
10722
10723         * symtab.h (SYMBOL_SET_NAMES): Update.
10724         (symbol_set_names): Update.
10725         (MSYMBOL_SET_NAMES): Update.
10726         * symtab.c (symbol_set_names): Change argument to be an
10727         objfile_per_bfd_storage.
10728         * psymtab.c (add_psymbol_to_bcache): Update.
10729         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10730
10731 2019-01-10  Tom Tromey  <tom@tromey.com>
10732
10733         * symtab.c (create_demangled_names_hash): Change argument to be an
10734         objfile_per_bfd_storage.
10735         (symbol_set_names): Update.
10736
10737 2019-01-10  Tom Tromey  <tom@tromey.com>
10738
10739         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10740         init_psymbol_list.
10741         * psymtab.c (init_psymbol_list): Do nothing if already called.
10742         * psympriv.h (init_psymbol_list): Add comment.
10743         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10744         init_psymbol_list.
10745         * dbxread.c (dbx_symfile_read): Unconditionally call
10746         init_psymbol_list.
10747
10748 2019-01-10  Tom Tromey  <tom@tromey.com>
10749
10750         * xcoffread.c (scan_xcoff_symtab): Update.
10751         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10752         "where".
10753         * mdebugread.c (parse_partial_symbols)
10754         (handle_psymbol_enumerators): Update.
10755         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10756         * dbxread.c (read_dbx_symtab): Update.
10757         * psympriv.h (psymbol_placement): New enum.
10758         (add_psymbol_to_list): Update.
10759
10760 2019-01-10  Tom Tromey  <tom@tromey.com>
10761
10762         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10763         static_psymbols parameters.
10764         (scan_xcoff_symtab): Update.
10765         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10766         static_psymbols parameters.
10767         * psympriv.h (start_psymtab_common): Update.
10768         * mdebugread.c (parse_partial_symbols): Update.
10769         * dwarf2read.c (create_partial_symtab): Update.
10770         * dbxread.c (read_dbx_symtab): Update.
10771         (start_psymtab): Remove global_psymbols and static_psymbols
10772         parameters.
10773
10774 2019-01-10  Tom Tromey  <tom@tromey.com>
10775
10776         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10777         * psymtab.c (allocate_psymtab): Add comment.
10778         * psympriv.h (allocate_psymtab): Add comment.
10779         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10780         initializations.
10781         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10782
10783 2019-01-10  Tom Tromey  <tom@tromey.com>
10784
10785         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10786         Don't declare.
10787         * mipsread.c: Include mdebugread.h.
10788         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10789         Declare.
10790         * elfread.c: Include mdebugread.h.
10791
10792 2019-01-09  Tom Tromey  <tom@tromey.com>
10793
10794         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10795         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10796         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10797         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10798         (psym_lookup_symbol, psym_find_last_source_symtab)
10799         (psym_forget_cached_source_info, psym_print_stats)
10800         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10801         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10802         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10803         (psym_find_compunit_symtab_by_address)
10804         (maintenance_print_psymbols, maintenance_info_psymtabs)
10805         (maintenance_check_psymtabs): Use ranged for.
10806         * psymtab.h (class objfile_psymtabs): New.
10807         (require_partial_symbols): Return objfile_psymtabs.
10808         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10809
10810 2019-01-09  Tom Tromey  <tom@tromey.com>
10811
10812         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10813         (find_pc_mapped_section, list_overlays_command)
10814         (map_overlay_command, unmap_overlay_command)
10815         (simple_overlay_update): Use all_objfiles.
10816         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10817         * printcmd.c (info_symbol_command): Use all_objfiles.
10818         * objfiles.h (ALL_OBJSECTIONS): Remove.
10819         * maint.c (maintenance_translate_address): Use all_objfiles.
10820         * gcore.c (gcore_create_callback): Use all_objfiles.
10821         (objfile_find_memory_regions): Likewise.
10822
10823 2019-01-09  Tom Tromey  <tom@tromey.com>
10824
10825         * symtab.c (find_line_symtab, info_sources_command)
10826         (make_source_files_completion_list): Use objfile_compunits.
10827         * source.c (select_source_symtab): Use objfile_compunits.
10828         * objfiles.h (struct objfile): Update comment.
10829         (ALL_OBJFILES): Remove.
10830         (ALL_FILETABS): Remove.
10831         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10832         objfile_compunits.
10833
10834 2019-01-09  Tom Tromey  <tom@tromey.com>
10835
10836         * symmisc.c (print_objfile_statistics, dump_objfile)
10837         (maintenance_print_symbols): Use compunit_filetabs.
10838         * source.c (forget_cached_source_info_for_objfile): Use
10839         compunit_filetabs.
10840         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10841         (ALL_FILETABS): Use compunit_filetabs.
10842         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10843         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10844
10845 2019-01-09  Tom Tromey  <tom@tromey.com>
10846
10847         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10848         (compunit_filetabs): New.
10849         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10850         compunit_filetabs.
10851         (info_sources_command, make_source_files_completion_list): Remove
10852         declaration.
10853         * symmisc.c (print_objfile_statistics, dump_objfile)
10854         (maintenance_print_symbols): Remove declaration.
10855         (maintenance_info_symtabs): Use compunit_filetabs.
10856         (maintenance_info_line_tables): Likewise.
10857         * source.c (select_source_symtab): Change local variable name.
10858         (forget_cached_source_info_for_objfile): Remove declaration.
10859         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10860         * objfiles.c (objfile_relocate1): Remove declaration.
10861         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10862         declaration.
10863         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10864         * coffread.c (coff_symtab_read): Remove declaration.
10865         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10866         compunit_filetabs.
10867
10868 2019-01-09  Tom Tromey  <tom@tromey.com>
10869
10870         * symtab.c (lookup_objfile_from_block)
10871         (find_pc_sect_compunit_symtab, search_symbols)
10872         (default_collect_symbol_completion_matches_break_on): Use
10873         objfile_compunits.
10874         * objfiles.h (ALL_COMPUNITS): Remove.
10875         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10876         * cp-support.c (add_symbol_overload_list_qualified): Use
10877         objfile_compunits.
10878         * ada-lang.c (ada_collect_symbol_completion_matches)
10879         (ada_add_global_exceptions): Use objfile_compunits.
10880
10881 2019-01-09  Tom Tromey  <tom@tromey.com>
10882
10883         * source.c (select_source_symtab)
10884         (forget_cached_source_info_for_objfile): Remove declaration.
10885         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10886         declaration.
10887         * maint.c (count_symtabs_and_blocks): Remove declaration.
10888         * cp-support.c (add_symbol_overload_list_qualified): Remove
10889         declaration.
10890         * coffread.c (coff_symtab_read): Remove declaration.
10891         * symtab.c (lookup_symbol_in_objfile_symtabs)
10892         (basic_lookup_transparent_type_1): Use objfile_compunits.
10893         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10894         (info_sources_command, search_symbols)
10895         (default_collect_symbol_completion_matches_break_on)
10896         (make_source_files_completion_list): Remove declaration.
10897         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10898         (ada_collect_symbol_completion_matches)
10899         (ada_add_global_exceptions): Remove declaration.
10900         * linespec.c (iterate_over_all_matching_symtabs): Use
10901         objfile_compunits.
10902         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10903         (class objfile_compunits): New.
10904         (ALL_COMPUNITS): Use objfile_compunits.
10905         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10906         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10907         objfile_compunits.
10908         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10909
10910 2019-01-09  Tom Tromey  <tom@tromey.com>
10911
10912         * symtab.c (search_symbols)
10913         (default_collect_symbol_completion_matches_break_on): Use
10914         objfile_msymbols.
10915         * ada-lang.c (ada_lookup_simple_minsym)
10916         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10917         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10918         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10919         objfile_msymbols.
10920         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10921         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10922         * objc-lang.c (find_methods): Use objfile_msymbols.
10923         (info_selectors_command, info_classes_command): Likewise.
10924         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10925         * objfiles.h (class objfile_msymbols): New.
10926         (ALL_OBJFILE_MSYMBOLS): Remove.
10927         (ALL_MSYMBOLS): Remove.
10928
10929 2019-01-09  Tom Tromey  <tom@tromey.com>
10930
10931         * common/next-iterator.h (next_adapter): Add Iterator template
10932         parameter.
10933         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10934         (class all_objfiles_safe): New.
10935         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10936         * objfiles.c (put_objfile_before): Update comment.
10937         (add_separate_debug_objfile): Likewise.
10938         (free_all_objfiles): Use all_objfiles_safe.
10939         (objfile_purge_solibs): Likewise.
10940
10941 2019-01-09  Tom Tromey  <tom@tromey.com>
10942
10943         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10944         (expand_symtab_containing_pc, lookup_static_symbol)
10945         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10946         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10947         all_objfiles.
10948         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10949         * breakpoint.c (create_overlay_event_breakpoint)
10950         (create_longjmp_master_breakpoint)
10951         (create_std_terminate_master_breakpoint)
10952         (create_exception_master_breakpoint): Use all_objfiles.
10953         * linux-thread-db.c (try_thread_db_load_from_pdir)
10954         (has_libpthread): Use all_objfiles.
10955         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10956         * linespec.c (iterate_over_all_matching_symtabs)
10957         (search_minsyms_for_name): Use all_objfiles.
10958         * maint.c (maintenance_info_sections): Use all_objfiles.
10959         * main.c (captured_main_1): Use all_objfiles.
10960         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10961         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10962         * guile/scm-pretty-print.c
10963         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10964         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10965         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10966         (maintenance_print_msymbols): Use all_objfiles.
10967         * source.c (select_source_symtab): Use all_objfiles.
10968         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10969         * symfile.c (remove_symbol_file_command)
10970         (expand_symtabs_matching, map_symbol_filenames): Use
10971         all_objfiles.
10972         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10973         all_objfiles.
10974         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10975         * objc-lang.c (find_methods): Use all_objfiles.
10976         * objfiles.c (have_partial_symbols, have_full_symbols)
10977         (have_minimal_symbols, qsort_cmp)
10978         (default_iterate_over_objfiles_in_search_order): Use
10979         all_objfiles.
10980         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10981         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10982         (maintenance_check_psymtabs): Use all_objfiles.
10983         (ALL_PSYMTABS): Remove.
10984         * compile/compile-object-run.c (do_module_cleanup): Use
10985         all_objfiles.
10986         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10987         * cp-support.c (add_symbol_overload_list_qualified): Use
10988         all_objfiles.
10989         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10990         Use all_objfiles.
10991         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10992         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10993         all_objfiles.
10994         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10995         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10996         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10997         Uses all_objfiles.
10998         * solib.c (solib_read_symbols): Use all_objfiles
10999
11000 2019-01-09  Tom Tromey  <tom@tromey.com>
11001
11002         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11003         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11004         all_objfiles.
11005         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11006         * symmisc.c (print_symbol_bcache_statistics)
11007         (print_objfile_statistics, maintenance_print_objfiles)
11008         (maintenance_info_symtabs, maintenance_check_symtabs)
11009         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11010         all_objfiles.
11011         * source.c (forget_cached_source_info): Use all_objfiles.
11012         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11013         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11014         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11015         * objfiles.c (update_section_map): Use all_objfiles.
11016         (shared_objfile_contains_address_p): Likewise.
11017         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11018         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11019
11020 2019-01-09  Tom Tromey  <tom@tromey.com>
11021
11022         * common/next-iterator.h: New file.
11023         * objfiles.h (class all_objfiles): New.
11024         (struct objfile_iterator): New.
11025
11026 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11027
11028         * NEWS: Move the description of the changed "frame", "select-frame",
11029          and "info frame" commands to the Changed commands section.
11030
11031 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11032
11033         * gdbtypes.c (check_stub_method_group): Remove handling of old
11034         mangling schemes.
11035         * linespec.c (find_methods): Likewise.
11036         * stabsread.c (read_member_functions): Likewise.
11037         * valops.c (search_struct_method): Likewise.
11038         (value_struct_elt_for_reference): Likewise.
11039         * NEWS: Mention this change.
11040
11041 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11042
11043         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11044         print_source_lines.
11045         * source.c (print_source_lines_base): Update line number check.
11046         (print_source_lines): New function.
11047         (source_lines_range::source_lines_range): New function.
11048         * source.h (class source_lines_range): New class.
11049         (print_source_lines): New declaration.
11050
11051 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11052
11053         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11054
11055 2019-01-08  Tom Tromey  <tom@tromey.com>
11056             Simon Marchi  <simon.marchi@ericsson.com>
11057
11058         PR gdb/24060
11059         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11060         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11061         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11062         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11063         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11064         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11065
11066 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11067
11068         * source.c (select_source_symtab): Move header comment to
11069         declaration in source.h.
11070         (forget_cached_source_info_for_objfile): Likewise.
11071         (forget_cached_source_info): Likewise.
11072         (identify_source_line): Likewise.
11073         * source.h (identify_source_line): Move declaration from symtab.h
11074         and add comment from source.c
11075         (print_source_lines): Likewise.
11076         (forget_cached_source_info_for_objfile): Likewise.
11077         (forget_cached_source_info): Likewise.
11078         (select_source_symtab): Likewise.
11079         (enum print_source_lines_flag): Move definition from symtab.h.
11080         * symtab.h (identify_source_line): Move declaration to source.h.
11081         (print_source_lines): Likewise.
11082         (forget_cached_source_info_for_objfile): Likewise.
11083         (forget_cached_source_info): Likewise.
11084         (select_source_symtab): Likewise.
11085         (enum print_source_lines_flag): Move definition to source.h.
11086         * tui/tui-hooks.c: Add 'source.h' include.
11087
11088 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11089
11090         * source.c (print_source_lines_base): Handle requests to print
11091         reverse line number sequences, and guard against empty lines
11092         string.
11093
11094 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11095
11096         * source.c (print_source_lines_base): Fix skip of '\r' if next
11097         character is '\n'.
11098
11099 2019-01-06  Tom Tromey  <tom@tromey.com>
11100
11101         * c-exp.y (struct c_parse_state) <macro_original_text,
11102         expansion_obstack>: New member.
11103         (macro_original_text, expansion_obstack): Remove globals.
11104         (scan_macro_expansion, scanning_macro_expansion)
11105         (finished_macro_expansion): Update.
11106         (scan_macro_cleanup): Remove.
11107         (yylex, c_parse): Update.
11108
11109 2019-01-06  Tom Tromey  <tom@tromey.com>
11110
11111         * c-exp.y (struct c_parse_state) <strings>: New member.
11112         (operator_stoken): Update.
11113
11114 2019-01-06  Tom Tromey  <tom@tromey.com>
11115
11116         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11117         (union type_stack_elt) <typelist_val>: Now a pointer to
11118         std::vector.
11119         (type_stack_cleanup): Don't declare.
11120         (push_typelist): Update.
11121         * parse.c (pop_typelist): Return a std::vector.
11122         (push_typelist): Take a std::vector.
11123         (follow_types): Update.  Do not free args.
11124         (type_stack_cleanup): Remove.
11125         * c-exp.y (struct c_parse_state): New.
11126         (cpstate): New global.
11127         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11128         (nonempty_typelist): Update.
11129         (func_mod): Create a new vector.
11130         (c_parse): Create a c_parse_state.
11131         (check_parameter_typelist): Do not delete params.
11132         (function_method): Update.  Do not delete type_list.
11133
11134 2019-01-06  Tom Tromey  <tom@tromey.com>
11135
11136         PR gdb/28155:
11137         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11138         check_typedef.
11139         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11140         (print_return_value): Likewise.
11141
11142 2019-01-05  Tom Tromey  <tom@tromey.com>
11143
11144         * contrib/cleanup_check.py: Remove.
11145         * contrib/gcc-with-excheck: Remove.
11146         * contrib/exsummary.py: Remove.
11147         * contrib/excheck.py: Remove.
11148
11149 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11150
11151         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11152         NULL. Initialize tpprev to NULL instead of assigning it
11153         to NULL on the next statement.
11154         * windows-nat.c (windows_delete_thread): Remove check for
11155         main_thread_id before printing thread exit notifications.
11156         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11157         Remove thread ID check against main_thread_id.
11158         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11159         windows_delete_thread.
11160         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11161
11162 2019-01-04  Tom Tromey  <tom@tromey.com>
11163
11164         * compile/compile.c (_initialize_compile): Use upper case for
11165         metasyntactic variables.
11166         * symmisc.c (_initialize_symmisc): Use upper case for
11167         metasyntactic variables.
11168         * psymtab.c (_initialize_psymtab): Use upper case for
11169         metasyntactic variables.
11170         * demangle.c (demangle_command): Use upper case for metasyntactic
11171         variables.
11172         (_initialize_demangler): Likewise.
11173         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11174         variables.
11175
11176 2019-01-03  Tom Tromey  <tom@tromey.com>
11177
11178         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11179
11180 2019-01-03  Tom Tromey  <tom@tromey.com>
11181
11182         * python/py-symtab.c (salpy_str): Update.
11183         (struct salpy_sal_object) <symtab>: Now a PyObject.
11184         (salpy_dealloc): Update.
11185         (del_objfile_sal): Use gdbpy_ref.
11186
11187 2019-01-03  Tom Tromey  <tom@tromey.com>
11188
11189         * python/py-type.c (convert_field): Use new_reference.  Return
11190         gdbpy_ref.
11191         (make_fielditem): Return gdbpy_ref.
11192         (typy_fields): Update.
11193         (typy_getitem): Update.
11194         (field_name): Return gdbpy_ref.  Use new_reference.
11195         (typy_iterator_iternext): Update.
11196
11197 2019-01-03  Tom Tromey  <tom@tromey.com>
11198
11199         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11200
11201 2019-01-03  Tom Tromey  <tom@tromey.com>
11202
11203         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11204         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11205         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11206         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11207         (pspy_set_type_printers): Likewise.
11208         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11209         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11210         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11211         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11212         (objfpy_set_type_printers): Likewise.
11213
11214 2019-01-03  Tom Tromey  <tom@tromey.com>
11215
11216         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11217         (gdbpy_print_stack): Use gdbpy_err_fetch.
11218         * python/python-internal.h (class gdbpy_err_fetch): New class.
11219         (class gdbpy_enter) <m_error_type, m_error_value,
11220         m_error_traceback>: Remove.
11221         <m_error>: New member.
11222         (gdbpy_exception_to_string): Don't declare.
11223         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11224         * python/py-value.c (convert_value_from_python): Use
11225         gdbpy_err_fetch.
11226         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11227         gdbpy_exception_to_string.
11228         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11229         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11230         gdbpy_err_fetch.
11231
11232 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11233
11234         * linux-nat.c (delete_lwp_cleanup): Delete.
11235         (struct lwp_deleter): New struct.
11236         (lwp_info_up): New typedef.
11237         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11238         lwp_info_up.
11239
11240 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11241
11242         * linux-fork.c (class scoped_switch_fork_info): New class.
11243         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11244
11245 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11246
11247         * valops.c (find_overload_match): Remove use of null_cleanup, and
11248         calls to do_cleanups.
11249
11250 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11251
11252         * compile/compile-cplus-types.c
11253         (compile_cplus_instance::decl_name): Handle changes to
11254         cp_func_name.
11255         * cp-support.c (cp_func_name): Update header comment, update
11256         return type.
11257         * cp-support.h (cp_func_name): Update return type in declaration.
11258         * valops.c (find_overload_match): Move temp_func local to top
11259         level of function and change its type.  Use temp_func to hold and
11260         delete temporary string obtained from cp_func_name.
11261
11262 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11263
11264         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11265         gdb::char_vector, remove cleanup, and update uses of `msg`.
11266
11267 2019-01-03  Jim Wilson  <jimw@sifive.com>
11268
11269         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11270
11271 2019-01-02  Tom Tromey  <tom@tromey.com>
11272
11273         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11274         (tdesc_parse_xml): Remove cleanups.
11275         * target-descriptions.h (make_cleanup_free_target_description):
11276         Don't declare.
11277         (target_desc_deleter): New struct.
11278         (target_desc_up): New typedef.
11279         * target-descriptions.c (target_desc_deleter::operator()): Rename
11280         from free_target_description.
11281         (make_cleanup_free_target_description): Remove.
11282
11283 2019-01-02  Tom Tromey  <tom@tromey.com>
11284
11285         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11286         constructor, destructor.
11287         (linespec_parser): Remove typedef.
11288         (~linespec_parser): Rename from linespec_parser_delete.
11289         (linespec_lex_to_end, linespec_complete_label)
11290         (linespec_complete): Update.
11291         (decode_line_full): Remove cleanups.
11292         (decode_line_1): Update.
11293
11294 2019-01-02  Tom Tromey  <tom@tromey.com>
11295
11296         * python/python-internal.h (inferior_to_inferior_object): Change
11297         return type.
11298         * python/py-exitedevent.c (create_exited_event_object): Update.
11299         * python/py-inferior.c (inferior_to_inferior_object): Return
11300         gdbpy_ref.
11301         (python_new_inferior, python_inferior_deleted)
11302         (thread_to_thread_object, delete_thread_object)
11303         (build_inferior_list, gdbpy_selected_inferior): Update.
11304         * python/py-infthread.c (create_thread_object): Update.  Also fail
11305         if inferior_to_inferior_object fails.
11306
11307 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11308
11309         * inferior.h (class inferior) <displaced_step_state>: New field.
11310         * infrun.h (struct displaced_step_state): Move here from
11311         infrun.c.  Initialize fields, add constructor.
11312         <inf>: Remove field.
11313         <reset>: New method.
11314         * infrun.c (struct displaced_step_inferior_state): Move to
11315         infrun.h.
11316         (displaced_step_inferior_states): Remove.
11317         (get_displaced_stepping_state): Adust.
11318         (displaced_step_in_progress_any_inferior): Adjust.
11319         (displaced_step_in_progress_thread): Adjust.
11320         (displaced_step_in_progress): Adjust.
11321         (add_displaced_stepping_state): Remove.
11322         (get_displaced_step_closure_by_addr): Adjust.
11323         (remove_displaced_stepping_state): Remove.
11324         (infrun_inferior_exit): Call displaced_step_state.reset.
11325         (use_displaced_stepping): Don't check for NULL.
11326         (displaced_step_prepare_throw): Call
11327         get_displaced_stepping_state.
11328         (displaced_step_fixup): Don't check for NULL.
11329         (prepare_for_detach): Don't check for NULL.
11330
11331 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11332
11333         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11334          in case of call that did not complete.
11335
11336 2019-01-02  Andrey Utkin  <autkin@undo.io>
11337
11338         * symfile.c (find_separate_debug_file): Fix search of debug files for
11339         remote debuggee.
11340
11341 2019-01-02  Tom Tromey  <tom@tromey.com>
11342
11343         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11344         indentation.
11345         * python/py-frame.c (frapy_older): Remove cast.
11346         (frapy_newer): Likewise.
11347         * python/py-breakpoint.c (local_setattro): Remove cast.
11348         * python/py-arch.c (archpy_name): Remove local variable.
11349         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11350
11351 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11352
11353         * unittests/basic_string_view/element_access/char/empty.cc:
11354         Fix year range in copyright header.
11355
11356 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11357
11358         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11359         Delete.
11360         <operator==>: Update with for removed field.
11361         <hash>: Likewise.
11362         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11363         <isa_features>: ...this.
11364         <abi_features>: New field.
11365         (riscv_isa_flen): Update comment.
11366         (riscv_abi_xlen): New declaration.
11367         (riscv_abi_flen): New declaration.
11368         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11369         isa_features.
11370         (riscv_abi_xlen): New function.
11371         (riscv_isa_flen): Update to get answer from isa_features.
11372         (riscv_abi_flen): New function.
11373         (riscv_has_fp_abi): Update to get answer from abi_features.
11374         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11375         xlen and flen.
11376         (riscv_call_info) <xlen, flen>: Update comment.
11377         (riscv_call_arg_struct): Remove invalid assertions
11378         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11379         is removed.
11380         (riscv_gdbarch_init): Gather isa features and abi features
11381         separately, ensure both match on the gdbarch when reusing an old
11382         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11383         a target with 64-bit float hardware.
11384
11385 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11386
11387         * source.c (search_command_helper): Stop reverse search
11388         when line 1 has been searched.
11389
11390 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11391
11392         * record-full.c (record_full_base_target::close): Rewrite
11393         record_full_core_buf_list free logic.
11394
11395 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11396
11397         * break-catch-syscall.c (print_one_catch_syscall): xfree
11398         the last text.
11399
11400 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11401
11402         * top.c (print_gdb_version): Update Copyright year in version
11403         message.
11404
11405 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11406
11407         Update copyright year range in all GDB files.
11408
11409 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11410
11411         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11412
11413 For older changes see ChangeLog-2018.
11414 \f
11415 Local Variables:
11416 mode: change-log
11417 left-margin: 8
11418 fill-column: 74
11419 version-control: never
11420 coding: utf-8
11421 End:
11422