gdb/ChangeLog

   1 2019-03-19  Tom Tromey  <tromey@adacore.com>
   2
   3         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
   4         * infrun.h (print_stop_event): Add "displays" parameter.
   5         * infrun.c (print_stop_event): Add "displays" parameter.
   6
   7 2019-03-19  Pedro Alves  <palves@redhat.com>
   8
   9         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
  10         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
  11         to -1.  Fix TABs vs spaces.
  12         (tui_ui_out::tui_ui_out): Don't initialize fields here.
  13         * tui/tui-out.h (tui_ui_out) Add intro comments.
  14         <m_line, m_start_of_line>: In-class initialize, and add describing
  15         comment.
  16
  17 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
  18
  19         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
  20         variable names.
  21         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
  22
  23 2019-03-18  Pedro Alves  <palves@redhat.com>
  24             Eli Zaretskii <eliz@gnu.org>
  25
  26         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
  27         m_line and m_start_of_line.
  28
  29 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
  30
  31         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
  32         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
  33         it returns a newline.  This fixes a regression in TU mode, whereby
  34         the next line is output on the same screen line as the user input.
  35
  36 2019-03-18  Tom Tromey  <tromey@adacore.com>
  37
  38         * minsyms.c (minimal_symbol_reader::install): Remove call to
  39         obstack_blank.
  40
  41 2019-03-18  Pedro Alves  <palves@redhat.com>
  42
  43         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
  44         New globals.
  45         (apply_style): New, factored out from ...
  46         (apply_ansi_escape): ... this.  Handle reverse video mode.
  47         (tui_set_reverse_mode): New function.
  48         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
  49         * tui/tui-winsource.c (tui_show_source_line): Use
  50         tui_set_reverse_mode instead of setting A_STANDOUT.
  51         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
  52         New setter methods.
  53
  54 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
  55
  56         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
  57         Handle tabs.
  58
  59 2019-03-18  Tom Tromey  <tromey@adacore.com>
  60
  61         * ada-lang.c (empty_array): Add "high" parameter.
  62         (ada_evaluate_subexp): Update.
  63
  64 2019-03-17  Sergei Trofimovich <siarheit@google.com>
  65
  66         * unittests/string_view-selftests.c: Define
  67         _initialize_string_view_selftests unconditionally.
  68
  69 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
  70
  71         PR gdb/24350
  72         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
  73
  74 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
  75
  76         PR gdb/24351
  77         * windows-nat.c (display_selector): Fix format specifiers.
  78
  79 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
  80
  81         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
  82         tui_refill_source_window instead of tui_refresh_win, to update the
  83         current execution line.  This fixes redisplay of the current line
  84         when stepping through the code with "next" or "step".
  85
  86 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  87
  88         * source-cache.c (source_cache::get_source_lines): Call
  89         find_source_lines to initialize s->nlines.  This fixes vertical
  90         scrolling of TUI source window when the DOWN arrow is pressed.
  91
  92 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  93
  94         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
  95         linux-thread-db.c (_initialize_thread_db): Likewise.
  96
  97 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  98
  99         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 100         wclrtoeol in tui_show_source_line".  This reverts changes made in
 101         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 102
 103 2019-03-15  Tom Tromey  <tom@tromey.com>
 104
 105         * symtab.h (struct minimal_symbol): Derive from
 106         general_symbol_info.
 107         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 108         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 109         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 110         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 111         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 112         (MSYMBOL_SEARCH_NAME): Update.
 113         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 114         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 115         * minsyms.c (minimal_symbol_reader::record_full): Update.
 116
 117 2019-03-15  Tom Tromey  <tom@tromey.com>
 118
 119         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 120
 121 2019-03-15  Tom Tromey  <tom@tromey.com>
 122
 123         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 124         unique_xmalloc_ptr.
 125         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 126         Update.
 127         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 128         (build_minimal_symbol_hash_tables)
 129         (minimal_symbol_reader::install): Update.
 130
 131 2019-03-15  Tom Tromey  <tom@tromey.com>
 132
 133         * symtab.c (create_demangled_names_hash): Update.
 134         (symbol_set_names): Update.
 135         * objfiles.h (struct objfile_per_bfd_storage)
 136         <demangled_names_hash>: Now an htab_up.
 137         * objfiles.c (objfile_per_bfd_storage): Simplify.
 138
 139 2019-03-15  Tom Tromey  <tom@tromey.com>
 140
 141         * objfiles.h (struct objfile_per_bfd_storage): Declare
 142         destructor.
 143         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 144         New.
 145         (get_objfile_bfd_data): Use new.  Don't initialize
 146         language_of_main.
 147         (free_objfile_per_bfd_storage): Remove.
 148         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 149
 150 2019-03-15  Tom Tromey  <tom@tromey.com>
 151
 152         * symfile.c (reread_symbols): Update.
 153         * objfiles.c (objfile::objfile): Update.
 154         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 155         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 156         comment.
 157         (minimal_symbol_reader::install): Update.
 158         (terminate_minimal_symbol_table): Remove.
 159         * jit.c (jit_object_close_impl): Update.
 160
 161 2019-03-15  Tom Tromey  <tom@tromey.com>
 162
 163         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 164         initializations.
 165
 166 2019-03-15  Tom Tromey  <tom@tromey.com>
 167
 168         * objfiles.h (struct objfile_per_bfd_storage)
 169         <demangled_hash_languages>: Now a bitset.
 170         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 171         (lookup_minimal_symbol): Update.
 172
 173 2019-03-15  Tom Tromey  <tom@tromey.com>
 174
 175         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 176         Don't return the symbol.
 177         * coffread.c (record_minimal_symbol): Use record_full.
 178
 179 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 180
 181         The MS-Windows port of ncurses fails to switch to a color pair if
 182         one or both of the colors are the implicit default colors.  This
 183         change records the default colors when TUI is initialized, and
 184         then specifies them explicitly when a color pair uses the default
 185         colors.  This allows color styling in TUI mode on MS-Windows.
 186
 187         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 188         ncurses_norm_attr.
 189         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 190         colors in ncurses_norm_attr.
 191         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 192         "none", replace it with the default color recorded in
 193         ncurses_norm_attr.
 194
 195 2019-03-14  Tom Tromey  <tromey@adacore.com>
 196
 197         * source-cache.h (class source_cache) <get_source_lines>: Return
 198         std::string.
 199         * source-cache.c (source_cache::extract_lines): Handle case where
 200         first_pos==npos.  Return std::string.
 201         (source_cache::get_source_lines): Update.
 202
 203 2019-03-14  Tom Tromey  <tromey@adacore.com>
 204
 205         * NEWS: Add item for "style sources" commands.
 206         * source-cache.c (source_cache::get_source_lines): Check
 207         source_styling.
 208         * cli/cli-style.c (source_styling): New global.
 209         (_initialize_cli_style): Add "style sources" commands.
 210         (show_style_sources): New function.
 211         * cli/cli-style.h (source_styling): Declare.
 212
 213 2019-03-14  Pedro Alves  <palves@redhat.com>
 214             Tom Tromey  <tromey@adacore.com>
 215
 216         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 217         * tui/tui-winsource.c (tui_refill_source_window): New function,
 218         from...
 219         (tui_horizontal_source_scroll): ... here.  Move some logic.
 220         * cli/cli-style.c (set_style_enabled): Notify new observable.
 221         * tui/tui-hooks.c (tui_redisplay_source): New function.
 222         (tui_attach_detach_observers): Attach or detach
 223         tui_redisplay_source.
 224         * observable.h (source_styling_changed): New observable.
 225         * observable.c: Define source_styling_changed observable.
 226
 227 2019-03-13  Tom Tromey  <tromey@adacore.com>
 228
 229         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 230         (i386_gnu_nat_target::store_registers): Update.
 231         * target-debug.h (target_debug_print_std_string): New macro.
 232         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 233         * windows-tdep.c (display_one_tib): Update.
 234         * tui/tui-stack.c (tui_make_status_line): Update.
 235         * top.c (print_inferior_quit_action): Update.
 236         * thread.c (thr_try_catch_cmd): Update.
 237         (add_thread_with_info): Update.
 238         (thread_target_id_str): Update.
 239         (thr_try_catch_cmd): Update.
 240         (thread_command): Update.
 241         (thread_find_command): Update.
 242         * record-btrace.c (record_btrace_target::info_record)
 243         (record_btrace_resume_thread, record_btrace_target::resume)
 244         (record_btrace_cancel_resume, record_btrace_step_thread)
 245         (record_btrace_target::wait, record_btrace_target::wait)
 246         (record_btrace_target::wait, record_btrace_target::stop): Update.
 247         * progspace.c (print_program_space): Update.
 248         * process-stratum-target.c
 249         (process_stratum_target::thread_address_space): Update.
 250         * linux-fork.c (linux_fork_mourn_inferior)
 251         (detach_checkpoint_command, info_checkpoints_command)
 252         (linux_fork_context): Update.
 253         (linux_fork_detach): Update.
 254         (class scoped_switch_fork_info): Update.
 255         (delete_checkpoint_command): Update.
 256         * infrun.c (follow_fork_inferior): Update.
 257         (follow_fork_inferior): Update.
 258         (proceed_after_vfork_done): Update.
 259         (handle_vfork_child_exec_or_exit): Update.
 260         (follow_exec): Update.
 261         (displaced_step_prepare_throw): Update.
 262         (displaced_step_restore): Update.
 263         (start_step_over): Update.
 264         (resume_1): Update.
 265         (clear_proceed_status_thread): Update.
 266         (proceed): Update.
 267         (print_target_wait_results): Update.
 268         (do_target_wait): Update.
 269         (context_switch): Update.
 270         (stop_all_threads): Update.
 271         (restart_threads): Update.
 272         (finish_step_over): Update.
 273         (handle_signal_stop): Update.
 274         (switch_back_to_stepped_thread): Update.
 275         (keep_going_pass_signal): Update.
 276         (print_exited_reason): Update.
 277         (normal_stop): Update.
 278         * inferior.c (inferior_pid_to_str): Change return type.
 279         (print_selected_inferior): Update.
 280         (add_inferior): Update.
 281         (detach_inferior): Update.
 282         * dummy-frame.c (fprint_dummy_frames): Update.
 283         * dcache.c (dcache_info_1): Update.
 284         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 285         (btrace_fetch, btrace_clear): Update.
 286         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 287         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 288         type.
 289         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 290         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 291         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 292         * gdbarch.c, gdbarch.h: Rebuild.
 293         * gdbarch.sh (core_pid_to_str): Change return type.
 294         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 295         return type.
 296         (windows_nat_target::pid_to_str): Change return type.
 297         (windows_delete_thread): Update.
 298         (windows_nat_target::attach): Update.
 299         (windows_nat_target::files_info): Update.
 300         * target-delegates.c: Rebuild.
 301         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 302         return type.
 303         (sol_thread_target::pid_to_str): Change return type.
 304         * remote.c (class remote_target) <pid_to_str>: Change return
 305         type.
 306         (remote_target::pid_to_str): Change return type.
 307         (extended_remote_target::attach, remote_target::remote_stop_ns)
 308         (remote_target::remote_notif_remove_queued_reply)
 309         (remote_target::push_stop_reply, remote_target::disable_btrace):
 310         Update.
 311         (extended_remote_target::attach): Update.
 312         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 313         type.
 314         (gdbsim_target::pid_to_str): Change return type.
 315         * ravenscar-thread.c (struct ravenscar_thread_target)
 316         <pid_to_str>: Change return type.
 317         (ravenscar_thread_target::pid_to_str): Change return type.
 318         * procfs.c (class procfs_target) <pid_to_str>: Change return
 319         type.
 320         (procfs_target::pid_to_str): Change return type.
 321         (procfs_target::attach): Update.
 322         (procfs_target::detach): Update.
 323         (procfs_target::fetch_registers): Update.
 324         (procfs_target::store_registers): Update.
 325         (procfs_target::wait): Update.
 326         (procfs_target::files_info): Update.
 327         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 328         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 329         return type.
 330         (nto_procfs_target::pid_to_str): Change return type.
 331         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 332         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 333         return type.
 334         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 335         (exit_lwp): Update.
 336         (attach_proc_task_lwp_callback, get_detach_signal)
 337         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 338         (linux_nat_target::resume, wait_lwp, stop_callback)
 339         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 340         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 341         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 342         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 343         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 344         type.
 345         (inf_ptrace_target::attach): Update.
 346         (inf_ptrace_target::files_info): Update.
 347         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 348         type.
 349         (go32_nat_target::pid_to_str): Change return type.
 350         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 351         (gnu_nat_target::wait): Update.
 352         (gnu_nat_target::wait): Update.
 353         (gnu_nat_target::resume): Update.
 354         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 355         (fbsd_nat_target::wait): Update.
 356         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 357         type.
 358         (darwin_nat_target::attach): Update.
 359         * corelow.c (class core_target) <pid_to_str>: Change return type.
 360         (core_target::pid_to_str): Change return type.
 361         * target.c (normal_pid_to_str): Change return type.
 362         (default_pid_to_str): Likewise.
 363         (target_pid_to_str): Change return type.
 364         (target_translate_tls_address): Update.
 365         (target_announce_detach): Update.
 366         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 367         return type.
 368         (bsd_uthread_target::pid_to_str): Change return type.
 369         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 370         type.
 371         (bsd_kvm_target::pid_to_str): Change return type.
 372         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 373         return type.
 374         (aix_thread_target::pid_to_str): Change return type.
 375         * target.h (struct target_ops) <pid_to_str>: Change return type.
 376         (target_pid_to_str, normal_pid_to_str): Likewise.
 377         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 378         type.
 379         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 380         type.
 381         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 382         return type.
 383         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 384         type.
 385         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 386         type.
 387         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 388         return type.
 389
 390 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 391
 392         * NEWS: Mention that the new default MI version is 3.  Mention
 393         changes to the output of commands and events that deal with
 394         multi-location breakpoints.
 395         * breakpoint.c: Include "mi/mi-out.h".
 396         (print_one_breakpoint): Change output syntax if using MI version
 397         >= 3.
 398         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 399         New.
 400         (mi_multi_location_breakpoint_output_fixed): New.
 401         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 402         (mi_cmd_fix_multi_location_breakpoint_output): New.
 403         (mi_multi_location_breakpoint_output_fixed): New.
 404         * mi/mi-cmds.c (mi_cmds): Register command
 405         -fix-multi-location-breakpoint-output.
 406         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 407         interpreter "mi".
 408
 409 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 410
 411         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 412         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 413         instantiate mi_ui_out based on interpreter name.
 414         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 415         * mi/mi-main.c (mi_load_progress): Likewise.
 416
 417 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 418
 419         * NEWS: Combine separate "New targets" sections for 8.3.
 420
 421 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 422
 423         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 424         (ppcfbsd_init_abi): Install gdbarch
 425         "fetch_tls_load_module_address" and "get_thread_local_address"
 426         methods.
 427
 428 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 429
 430         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 431         (riscv_fbsd_init_abi): Install gdbarch
 432         "fetch_tls_load_module_address" and "get_thread_local_address"
 433         methods.
 434
 435 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 436
 437         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 438         (i386fbsd_init_abi): Install gdbarch
 439         "fetch_tls_load_module_address" and "get_thread_local_address"
 440         methods.
 441
 442 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 443
 444         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 445         (amd64fbsd_init_abi): Install gdbarch
 446         "fetch_tls_load_module_address" and "get_thread_local_address"
 447         methods.
 448
 449 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 450
 451         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 452         (struct fbsd_pspace_data): New type.
 453         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 454         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 455         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 456         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 457         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 458
 459 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 460
 461         * gdbtypes.c (lookup_struct_elt): New function.
 462         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 463         * gdbtypes.h (struct struct_elt): New type.
 464         (lookup_struct_elt): New prototype.
 465
 466 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 467
 468         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 469         remove disabled code block.
 470
 471 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 472
 473         * gdbarch.sh (get_thread_local_address): New method.
 474         * gdbarch.h, gdbarch.c: Regenerate.
 475         * target.c (target_translate_tls_address): Use
 476         gdbarch_get_thread_local_address if present instead of
 477         target::get_thread_local_address.
 478
 479 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 480
 481         * target.h (target::get_thread_local_address): Update comment.
 482
 483 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 484
 485         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 486         objfile->separate_debug_objfile_backlink if not NULL.
 487
 488 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 489
 490         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 491         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 492         (amd64bsd_store_inferior_registers): Likewise.
 493         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 494         Enable segment base registers.
 495         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 496         PT_GETFSBASE and PT_GETGSBASE.
 497         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 498         PT_SETGSBASE.
 499         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 500         segment base registers.
 501         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 502
 503 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 504
 505         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 506         Update calls to i386_target_description to add 'segments'
 507         parameter.
 508         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 509         add segment base registers.
 510         * arch/i386.c (i386_create_target_description): Add 'segments'
 511         parameter to enable segment base registers.
 512         * arch/i386.h (i386_create_target_description): Likewise.
 513         * features/i386/32bit-segments.xml: New file.
 514         * features/i386/32bit-segments.c: Generate.
 515         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 516         call to i386_target_description to add 'segments' parameter.
 517         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 518         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 519         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 520         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 521         if feature is present.
 522         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 523         Add 'segments' parameter to call to i386_target_description.
 524         (i386_target_description): Add 'segments' parameter to enable
 525         segment base registers.
 526         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 527         to call to i386_target_description.
 528         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 529         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 530         Define I386_NUM_REGS.
 531         (i386_target_description): Add 'segments' parameter to enable
 532         segment base registers.
 533
 534 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 535
 536         PR/24325
 537         * source-cache.c: #undef open and close, to avoid unresolved
 538         externals during linking.
 539
 540 2019-03-12  Tom Tromey  <tromey@adacore.com>
 541
 542         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 543         const.  Add initializers.
 544         (_initialize_remote): Don't initialize ptid globals.
 545
 546 2019-03-12  Pedro Alves  <palves@redhat.com>
 547
 548         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 549
 550 2019-03-12  Pedro Alves  <palves@redhat.com>
 551
 552         * cp-name-parser.y (main): Remove unused 'len' variable.
 553
 554 2019-03-12  Tom Tromey  <tromey@adacore.com>
 555
 556         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 557         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 558
 559 2019-03-12  Tom Tromey  <tromey@adacore.com>
 560
 561         * linux-nat.c (iterate_over_lwps): Update.
 562         (stop_callback): Remove parameter.
 563         (stop_wait_callback, detach_callback, resume_set_callback)
 564         (select_singlestep_lwp_callback, set_ignore_sigint)
 565         (status_callback, resumed_callback, resume_clear_callback)
 566         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 567         data parameter.
 568         (linux_nat_target::detach, linux_nat_target::resume)
 569         (linux_stop_and_wait_all_lwps, select_event_lwp)
 570         (linux_nat_filter_event, linux_nat_wait_1)
 571         (linux_nat_target::kill, linux_nat_target::stop)
 572         (linux_nat_target::stop): Update.
 573         (linux_nat_resume_callback): Change type.
 574         (resume_stopped_resumed_lwps, count_events_callback)
 575         (select_event_lwp_callback): Likewise.
 576         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 577         * arm-linux-nat.c (struct update_registers_data): Remove.
 578         (update_registers_callback): Change type.
 579         (arm_linux_insert_hw_breakpoint1): Update.
 580         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 581         parameter.
 582         (x86_linux_dr_set_addr): Update.
 583         (x86_linux_dr_set_control): Update.
 584         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 585         (iterate_over_lwps): Use gdb::function_view.
 586         * nat/aarch64-linux-hw-point.c (struct
 587         aarch64_dr_update_callback_param): Remove.
 588         (debug_reg_change_callback): Change type.
 589         (aarch64_notify_debug_reg_change): Update.
 590         * s390-linux-nat.c (s390_refresh_per_info): Update.
 591
 592 2019-03-11  Tom Tromey  <tromey@adacore.com>
 593
 594         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 595         redundant assignment to "this_cu".
 596
 597 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 598
 599         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 600
 601 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 602
 603         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 604         from...
 605         (rank_one_type): ... this.
 606
 607 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 608
 609         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 610         from...
 611         (rank_one_type): ... this.
 612
 613 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 614
 615         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 616         from...
 617         (rank_one_type): ... this.
 618
 619 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 620
 621         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 622         from...
 623         (rank_one_type): ... this.
 624
 625 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 626
 627         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 628         from...
 629         (rank_one_type): ... this.
 630
 631 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 632
 633         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 634         from...
 635         (rank_one_type): ... this.
 636
 637 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 638
 639         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 640         from...
 641         (rank_one_type): ... this.
 642
 643 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 644
 645         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 646         from...
 647         (rank_one_type): ... this.
 648
 649 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 650
 651         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 652         from...
 653         (rank_one_type): ... this.
 654
 655 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 656
 657         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 658         from...
 659         (rank_one_type): ... this.
 660
 661 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 662
 663         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 664         from...
 665         (rank_one_type): ... this.
 666
 667 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 668
 669         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 670         from...
 671         (rank_one_type): ... this.
 672
 673 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 674
 675         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 676         inferior-events' shows the example events.
 677
 678 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 679
 680         Support styling on native MS-Windows console
 681
 682         PR/24315
 683         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 684         on MS-Windows if $TERM is not defined.
 685
 686         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 687
 688         * posix-hdep.c (gdb_console_fputs):
 689         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 690         functions.
 691         * ui-file.h (gdb_console_fputs): Add prototype.
 692
 693         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 694         back to fputs only if the former returns zero.
 695
 696 2019-03-07  Tom Tromey  <tom@tromey.com>
 697
 698         * symmisc.c (print_symbol_bcache_statistics): Update.
 699         (print_objfile_statistics): Update.
 700         * symfile.c (allocate_symtab): Update.
 701         * stabsread.c: Don't include bcache.h.
 702         * psymtab.h (struct psymbol_bcache): Don't declare.
 703         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 704         (psymbol_bcache_init, psymbol_bcache_free)
 705         (psymbol_bcache_get_bcache): Don't declare.
 706         * psymtab.c (struct psymbol_bcache): Remove.
 707         (psymtab_storage::psymtab_storage): Update.
 708         (psymtab_storage::~psymtab_storage): Update.
 709         (psymbol_bcache_init, psymbol_bcache_free)
 710         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 711         (add_psymbol_to_bcache): Update.
 712         (allocate_psymtab): Update.
 713         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 714         macro_cache>: No longer pointers.
 715         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 716         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 717         * macrotab.c (macro_bcache): Update.
 718         * macroexp.c: Don't include bcache.h.
 719         * gdbtypes.c (check_types_worklist): Update.
 720         (types_deeply_equal): Remove TRY/CATCH.  Update.
 721         * elfread.c (elf_symtab_read): Update.
 722         * dwarf2read.c: Don't include bcache.h.
 723         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 724         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 725         (print_bcache_statistics, bcache_memory_used): Don't declare.
 726         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 727         methods.  Rename all data members.
 728         * bcache.c (struct bcache): Move to bcache.h.
 729         (bcache::expand_hash_table): Rename from expand_hash_table.
 730         (bcache): Remove.
 731         (bcache::insert): Rename from bcache_full.
 732         (bcache::compare): Rename from bcache_compare.
 733         (bcache_xmalloc): Remove.
 734         (bcache::~bcache): Rename from bcache_xfree.
 735         (bcache::print_statistics): Rename from print_bcache_statistics.
 736         (bcache::memory_used): Rename from bcache_memory_used.
 737
 738 2019-03-07  Pedro Alves  <palves@redhat.com>
 739
 740         * infrun.c (normal_stop): Also check for
 741         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 742
 743 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 744
 745         * f-lang.c (value_from_host_double): Moved to...
 746         * value.c (value_from_host_double): ...here.
 747         * value.h (value_from_host_double): Declare.
 748         * guile/scm-math.c (vlscm_convert_typed_number): Use
 749         value_from_host_double.
 750         (vlscm_convert_number): Likewise.
 751         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 752         * python/py-value.c (convert_value_from_python): Likewise.
 753
 754 2019-03-06  Tom Tromey  <tom@tromey.com>
 755
 756         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 757
 758 2019-03-06  Tom Tromey  <tom@tromey.com>
 759
 760         * utils.h (free_current_contents): Don't declare.
 761         * utils.c (free_current_contents): Remove.
 762
 763 2019-03-06  Tom Tromey  <tom@tromey.com>
 764
 765         * top.c (quit_force): Update.
 766         * main.c (captured_command_loop): Update.
 767         * common/new-op.c (operator new): Update.
 768         * common/common-exceptions.c (struct catcher)
 769         <save_cleanup_chain>: Remove member.
 770         (exceptions_state_mc_init): Update.
 771         (exception_try_scope_entry): Return nullptr.
 772         (exception_try_scope_exit, exception_rethrow)
 773         (throw_exception_sjlj, throw_exception_cxx): Update.
 774         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 775         (all_cleanups, do_cleanups, discard_cleanups)
 776         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 777         (restore_cleanups, restore_final_cleanups): Don't declare.
 778         (do_final_cleanups): Remove parameter.
 779         * common/cleanups.c (cleanup_chain, make_cleanup)
 780         (make_cleanup_dtor, all_cleanups, do_cleanups)
 781         (discard_my_cleanups, discard_cleanups)
 782         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 783         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 784         (null_cleanup): Remove.
 785         (do_final_cleanups): Remove parameter.
 786
 787 2019-03-06  Tom Tromey  <tom@tromey.com>
 788
 789         * remote.c (remote_target::remote_parse_stop_reply): Use
 790         unique_xmalloc_ptr.
 791
 792 2019-03-06  Tom Tromey  <tom@tromey.com>
 793
 794         * stabsread.c (struct stabs_field_info): Rename from field_info.
 795         <list, fnlist>: Add initializers.
 796         <obstack>: New member.
 797         (read_member_functions, read_struct_fields, read_baseclasses):
 798         Allocate on obstack.  Don't use cleanups.
 799         (read_one_struct_field, read_member_functions, read_struct_fields)
 800         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 801         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 802         (read_struct_type): Update.
 803
 804 2019-03-06  Tom Tromey  <tom@tromey.com>
 805
 806         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 807         * common/filestuff.h (make_cleanup_close): Don't declare.
 808         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 809         Remove.
 810
 811 2019-03-06  Tom Tromey  <tom@tromey.com>
 812
 813         * solib-aix.c: Use make_scope_exit.
 814
 815 2019-03-06  Tom Tromey  <tom@tromey.com>
 816
 817         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 818         Use make_scope_exit.
 819
 820 2019-03-06  Tom Tromey  <tom@tromey.com>
 821
 822         * solib-svr4.c (disable_probes_interface): Remove parameter.
 823         (svr4_handle_solib_event): Use make_scope_exit.
 824
 825 2019-03-06  Tom Tromey  <tom@tromey.com>
 826
 827         * remote.c (struct stop_reply_deleter): Remove.
 828         (stop_reply_up): Update.
 829         (struct stop_reply): Derive from notif_event.  Don't typedef.
 830         <regcache>: Now a std::vector.
 831         (stop_reply_xfree): Remove.
 832         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 833         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 834         (remote_target::discard_pending_stop_replies): Use delete.
 835         (remote_target::remote_parse_stop_reply): Update.
 836         (remote_target::process_stop_reply): Update.
 837         * remote-notif.h (struct notif_event): Add virtual destructor.
 838         Remove "dtr" member.
 839         (struct notif_client) <alloc_event>: Return a unique_ptr.
 840         (notif_event_xfree): Don't declare.
 841         (notif_event_up): New typedef.
 842         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 843         (notif_event_xfree, do_notif_event_xfree): Remove.
 844         (remote_notif_state_xfree): Update.
 845
 846 2019-03-06  Tom Tromey  <tom@tromey.com>
 847
 848         * infrun.c (displaced_step_clear_cleanup): Now a
 849         forward_scope_exit type.
 850         (displaced_step_prepare_throw): Update.
 851         (displaced_step_fixup): Update.
 852
 853 2019-03-06  Tom Tromey  <tom@tromey.com>
 854
 855         * inferior.h (class inferior): Update comment.
 856         * gdbthread.h (class thread_info): Update comment.
 857
 858 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 859             Tom Tromey  <tom@tromey.com>
 860
 861         * stabsread.h (struct stab_section_list): Remove.
 862         (coffstab_build_psymtabs): Update.
 863         * dbxread.c (symbuf_sections): Now a std::vector.
 864         (sect_idx): New global.
 865         (fill_symbuf): Update.
 866         (coffstab_build_psymtabs): Change type of stabsects parameter.
 867         Update.
 868         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 869         std::vector.
 870         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 871         (coff_locate_sections): Update.
 872         (coff_symfile_read): Remove cleanups.  Update.
 873         (init_stringtab): Add storage parameter.
 874         (free_stringtab, free_stringtab_cleanup): Remove.
 875         (init_lineno): Add storage parameter.
 876         (free_linetab, free_linetab_cleanup): Remove.
 877
 878 2019-03-06  Pedro Alves  <palves@redhat.com>
 879
 880         * linux-fork.c (fork_info::clobber_regs): Delete.
 881         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 882         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 883         comment.  Adjust.
 884         (scoped_switch_fork_info::scoped_switch_fork_info)
 885         (checkpoint_command, linux_fork_context): Adjust
 886         fork_save_infrun_state calls.
 887
 888 2019-03-06  Pedro Alves  <palves@redhat.com>
 889
 890         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 891         (inf_has_multiple_threads): Return 'bool' and rewrite using
 892         inferior_info::threads().
 893
 894 2019-03-06  Pedro Alves  <palves@redhat.com>
 895
 896         * linux-fork.c: Include <list>.
 897         (fork_list): Now a std::list instance.
 898         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 899         (forks_exist_p, find_last_fork): Adjust.
 900         (new_fork): Delete.
 901         (one_fork_p): New.
 902         (add_fork): Adjust.
 903         (free_fork): Delete, folded into fork_info::~fork_info().
 904         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 905         Adjust.
 906         (init_fork_list): Delete.
 907         (linux_fork_killall, linux_fork_mourn_inferior)
 908         (linux_fork_detach, info_checkpoints_command): Adjust.
 909         (_initialize_linux_fork): No longer call init_fork_list.
 910
 911 2019-03-06  Pedro Alves  <palves@redhat.com>
 912
 913         * linux-fork.c (new_fork): New, split out of ...
 914         (add_fork): ... this.  Return void.  Move "first fork" special
 915         case from here, to ...
 916         (checkpoint_command): ... here.
 917         * linux-linux.h (add_fork): Return void.
 918
 919 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 920
 921         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 922
 923 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 924             Chris January  <chris.january@arm.com>
 925             David Lecomber  <david.lecomber@arm.com>
 926
 927         * f-exp.y: New token, UNOP_INTRINSIC.
 928         (exp): New pattern using UNOP_INTRINSIC token.
 929         (f77_keywords): Add 'abs' keyword.
 930         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 931         (value_from_host_double): New function.
 932         (evaluate_subexp_f): Support UNOP_ABS.
 933
 934 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 935
 936         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 937         types.
 938
 939 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 940
 941         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 942         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 943         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 944
 945 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 946
 947         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 948
 949 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 950             Chris January  <chris.january@arm.com>
 951
 952         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 953         * f-exp.y: Define 'KIND' token.
 954         (exp): New pattern for KIND expressions.
 955         (ptype): Handle types with a kind extension.
 956         (direct_abs_decl): Extend to spot kind extensions.
 957         (f77_keywords): Add 'kind' to the list.
 958         (push_kind_type): New function.
 959         (convert_to_kind_type): New function.
 960         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 961         * parse.c (operator_length_standard): Likewise.
 962         * parser-defs.h (enum type_pieces): Add tp_kind.
 963         * std-operator.def: Add UNOP_KIND.
 964
 965 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 966
 967         * f-exp.y (f_parse): Set yydebug.
 968
 969 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 970
 971         * f-lang.c (evaluate_subexp_f): New function.
 972         (exp_descriptor_f): New global.
 973         (f_language_defn): Use exp_descriptor_f instead of
 974         exp_descriptor_standard.
 975
 976 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 977
 978         * f-exp.y (struct token): Add comments.
 979         (dot_ops): Remove uppercase versions and the end marker.
 980         (f77_keywords): Likewise.
 981         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 982         entries in the dot_ops array are case insensitive, and use
 983         strncasecmp to compare strings.  Also some whitespace cleanup in
 984         this area.  Similar for the f77_keywords array, except entries in
 985         this list might be case sensitive.
 986
 987 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 988
 989         * f-exp.y (struct f77_boolean_val): Add comments.
 990         (boolean_values): Remove uppercase versions, and end marker.
 991         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 992         and use strncasecmp to achieve case insensitivity.  Additionally,
 993         perform whitespace cleanup around this code.
 994
 995 2019-03-06  Tom Tromey  <tromey@adacore.com>
 996
 997         * remote-sim.c (gdbsim_target_open): Use result of
 998         gdb_argv::release.
 999
1000 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1001         Dirk Schubert  <dirk.schubert@arm.com>
1002         Chris January  <chris.january@arm.com>
1003
1004         * eval.c (evaluate_subexp_standard): Call Fortran argument
1005         wrapping logic.
1006         * f-lang.c (struct value): A value which can be passed into a
1007         Fortran function call.
1008         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1009         where appropriate.
1010         (struct type): Value ready for a Fortran function call.
1011         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1012         is needed.
1013         * f-lang.h (fortran_argument_convert): Declaration.
1014         (fortran_preserve_arg_pointer): Declaration.
1015         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1016
1017 2019-03-05  Tom Tromey  <tromey@adacore.com>
1018
1019         * python/py-prettyprint.c (print_string_repr): Remove #if.
1020         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1021
1022 2019-03-05  Tom Tromey  <tromey@adacore.com>
1023
1024         * target.c (the_dummy_target): Move later.  Change type to
1025         "dummy_target".
1026         (initialize_targets): Don't initialize the_dummy_target.
1027
1028 2019-03-05  Tom Tromey  <tromey@adacore.com>
1029
1030         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1031         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1032
1033 2019-03-05  Tom Tromey  <tromey@adacore.com>
1034
1035         * windows-nat.c (windows_nat_target::attach)
1036         (windows_nat_target::detach): Don't call gdb_flush.
1037         * valprint.c (generic_val_print, val_print, val_print_string):
1038         Don't call gdb_flush.
1039         * utils.c (defaulted_query): Don't call gdb_flush.
1040         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1041         * target.c (target_announce_detach): Don't call gdb_flush.
1042         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1043         * remote.c (extended_remote_target::attach): Don't call
1044         gdb_flush.
1045         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1046         * printcmd.c (do_examine): Don't call gdb_flush.
1047         (info_display_command): Don't call gdb_flush.
1048         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1049         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1050         * memattr.c (info_mem_command): Don't call gdb_flush.
1051         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1052         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1053         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1054         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1055         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1056         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1057         (gnu_nat_target::detach): Don't call gdb_flush.
1058         * f-valprint.c (f_val_print): Don't call gdb_flush.
1059         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1060         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1061         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1062         gdb_flush.
1063         * c-valprint.c (c_val_print): Don't call gdb_flush.
1064         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1065
1066 2019-03-05  Tom Tromey  <tromey@adacore.com>
1067
1068         * varobj.c (update_dynamic_varobj_children): Update.
1069         (install_default_visualizer): Use reset, not release.
1070         * value.c (set_internalvar): Update.
1071         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1072         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1073         ATTRIBUTE_UNUSED_RESULT.
1074
1075 2019-03-05  Tom Tromey  <tromey@adacore.com>
1076
1077         * remote.c (class scoped_remote_fd) <release>: Add
1078         ATTRIBUTE_UNUSED_RESULT.
1079
1080 2019-03-05  Tom Tromey  <tromey@adacore.com>
1081
1082         * macroexp.c (struct macro_buffer) <release>: Add
1083         ATTRIBUTE_UNUSED_RESULT.
1084
1085 2019-03-05  Tom Tromey  <tromey@adacore.com>
1086
1087         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1088         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1089         ATTRIBUTE_UNUSED_RESULT.
1090
1091 2019-03-05  Tom Tromey  <tromey@adacore.com>
1092
1093         * common/scoped_fd.h (class scoped_fd) <release>: Add
1094         ATTRIBUTE_UNUSED_RESULT.
1095
1096 2019-03-05  Tom Tromey  <tromey@adacore.com>
1097
1098         * parser-defs.h (struct parser_state) <release>: Add
1099         ATTRIBUTE_UNUSED_RESULT.
1100
1101 2019-03-05  Tom Tromey  <tromey@adacore.com>
1102
1103         * utils.h (class gdb_argv) <release>: Add
1104         ATTRIBUTE_UNUSED_RESULT.
1105         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1106
1107 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1108
1109         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1110         for-loop range, to avoid compiler warnings.
1111
1112         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1113         avoid compiler warnings about unused variables.
1114
1115         * NEWS: Mention end of support for native debugging on MS-Windows
1116         before XP.
1117
1118         PR gdb/24292
1119         * common/netstuff.c:
1120         * gdbserver/gdbreplay.c
1121         * gdbserver/remote-utils.c:
1122         * ser-tcp.c:
1123         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1124         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1125         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1126         'getaddrinfo' and 'freeaddrinfo' were not available before
1127         Windows XP, and mingw.org's MinGW headers by default define
1128         _WIN32_WINNT to 0x500.
1129
1130 2019-03-01  Gary Benson <gbenson@redhat.com>
1131
1132         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1133
1134 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1135             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1136
1137         PR gdb/8527
1138         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1139         set_sigint_trap, clear_sigint_trap.
1140
1141 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1142
1143         * target.c (target_detach): Clear the regcache and the
1144         frame cache.
1145
1146 2019-02-27  Pedro Alves  <palves@redhat.com>
1147
1148         * utils.c (set_screen_size): When we cap the height/width sizes,
1149         tweak the corresponding command variable to show "unlimited":
1150
1151 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1152             Pedro Alves  <palves@redhat.com>
1153
1154         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1155         before calling rl_set_screen_size.
1156
1157 2019-02-27  Tom Tromey  <tromey@adacore.com>
1158
1159         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1160         define.
1161         * python/py-value.c: Remove Python 2.4 workaround.
1162         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1163         workaround.
1164         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1165         Python 2.4 workaround.
1166         * python/python-internal.h: Remove Python 2.4 comment.
1167         (Py_ssize_t): Don't define.
1168         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1169         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1170         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1171         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1172         * python/python.c (do_start_initialization): Remove Python 2.4
1173         workaround.
1174         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1175         (print_children): Remove Python 2.4 workaround.
1176         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1177         workaround.
1178         (CHARBUFFERPROC_NAME): Remove.
1179         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1180         Python 2.4 workaround.
1181
1182 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1183
1184         * NEWS: Note minimum Python version.
1185
1186 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1187
1188         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1189         code from these functions.  Remove corresponding ifdefs.  Use
1190         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1191         Remove gotos and target of gotos.
1192         (infpy_search_memory): Likewise.
1193
1194 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1195
1196         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1197         (hppa_gdbarch_init): Don't register deleted functions with
1198         gdbarch.
1199
1200 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1201
1202         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1203         (h8300_unwind_sp): Delete.
1204         (h8300_dummy_id): Delete.
1205         (h8300_gdbarch_init): Don't register deleted functions with
1206         gdbarch.
1207
1208 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1209
1210         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1211         (ft32_unwind_pc): Delete.
1212         (ft32_unwind_sp): Delete.
1213         (ft32_gdbarch_init): Don't register deleted functions with
1214         gdbarch.
1215
1216 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1217
1218         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1219         (frv_unwind_pc): Delete.
1220         (frv_unwind_sp): Delete.
1221         (frv_gdbarch_init): Don't register deleted functions with
1222         gdbarch.
1223
1224 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1225
1226         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1227         (riscv_unwind_pc): Delete.
1228         (riscv_unwind_sp): Delete.
1229         (riscv_gdbarch_init): Don't register deleted functions with
1230         gdbarch.
1231
1232 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1233
1234         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1235         (csky_unwind_pc): Delete.
1236         (csky_unwind_sp): Delete.
1237         (csky_gdbarch_init): Don't register deleted functions with
1238         gdbarch.
1239
1240 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1241
1242         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1243         (cris_unwind_pc): Delete.
1244         (cris_unwind_sp): Delete.
1245         (cris_gdbarch_init): Don't register deleted functions with
1246         gdbarch.
1247
1248 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1249
1250         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1251         (bfin_unwind_pc): Delete.
1252         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1253
1254 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1255
1256         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1257         (arm_unwind_pc): Delete.
1258         (arm_unwind_sp): Delete.
1259         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1260
1261 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1262
1263         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1264         (arc_unwind_pc): Delete.
1265         (arc_unwind_sp): Delete.
1266         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1267
1268 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1269
1270         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1271         (alpha_unwind_pc): Delete.
1272         (alpha_gdbarch_init): Don't register deleted functions with
1273         gdbarch.
1274
1275 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1276
1277         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1278         (aarch64_unwind_pc): Delete.
1279         (aarch64_unwind_sp): Delete.
1280         (aarch64_gdbarch_init): Don't register deleted functions with
1281         gdbarch.
1282
1283 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1284
1285         * gdbtypes.c (type_align): Don't consider static members when
1286         computing structure alignment.
1287
1288 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1289
1290         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1291         return 0 for other types.
1292         * arch-utils.c (default_type_align): Always return 0.
1293         * gdbarch.h: Regenerate.
1294         * gdbarch.sh (type_align): Extend comment.
1295         * gdbtypes.c (type_align): Add additional comments, always call
1296         gdbarch_type_align before applying the default rules.
1297         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1298         generic code will then apply a suitable default.
1299         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1300         types, return 0 for other types.
1301
1302 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1303
1304         * NEWS: Create a new section for the next release branch.
1305         Rename the section of the current branch, now that it has
1306         been cut.
1307
1308 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1309
1310         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1311         * version.in: Bump version to 8.3.50.DATE-git.
1312
1313 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1314
1315         * aix-thread.c (ptid_cmp): Remove unused variable.
1316         (get_signaled_thread): Likewise.
1317         (store_regs_user_thread): Likewise.
1318         (store_regs_kernel_thread): Likewise.
1319         (fetch_regs_kernel_thread): Remove shadowed variable.
1320
1321 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1322
1323         * features/riscv/32bit-cpu.xml: Add register numbers.
1324         * features/riscv/32bit-fpu.c: Regenerate.
1325         * features/riscv/32bit-fpu.xml: Add register numbers.
1326         * features/riscv/64bit-cpu.xml: Add register numbers.
1327         * features/riscv/64bit-fpu.c: Regenerate.
1328         * features/riscv/64bit-fpu.xml: Add register numbers.
1329
1330 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1331
1332         * NEWS: Mention two argument form of gdb.Value constructor.
1333         * python/py-value.c (convert_buffer_and_type_to_value): New
1334         function.
1335         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1336         Add support for handling an optional second argument.  Call
1337         convert_buffer_and_type_to_value as appropriate.
1338         * python/python-internal.h (Py_buffer_deleter): New struct.
1339         (Py_buffer_up): New typedef.
1340
1341 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1342
1343         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1344         instead of releasing ownership.
1345
1346 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1347
1348         * dwarf2read.c (open_and_init_dwp_file): Call
1349         elf_numsections instead of bfd_count_sections to initialize
1350         dwp_file->num_sections.
1351
1352 2019-02-25  Tom Tromey  <tromey@adacore.com>
1353
1354         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1355
1356 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1357
1358         * gcore.in: Add '--readnever' option when invoking GDB.
1359
1360 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1361
1362         * MAINTAINERS: Update my email address.
1363
1364 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1365
1366         * build-id.c (build_id_to_debug_bfd_1): New function.
1367         (build_id_to_debug_bfd): Look for separate debug file in
1368         sysroot.
1369
1370 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1371
1372         * gdbarch.sh: Update the copyright year range that is placed into
1373         generated files.
1374
1375 2019-02-22  Keith Seitz  <keiths@redhat.com>
1376
1377         PR symtab/23853
1378         * linespec.c (create_sals_line_offset): Search for the default
1379         symtab's filename instead of its fullname.
1380
1381 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1382
1383         * NEWS: Update style defaults.
1384
1385 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1386
1387         * main.c (captured_main_1): Disable styling in batch mode.
1388
1389 2019-02-20  Tom Tromey  <tom@tromey.com>
1390
1391         * symtab.c (symtab_symbol_info): Fix typos.
1392
1393 2019-02-20  Tom Tromey  <tromey@adacore.com>
1394
1395         * findcmd.c (_initialize_mem_search): Use upper case for
1396         metasyntactic variables.
1397
1398 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1399
1400         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1401         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1402
1403 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1404
1405         * top.h (source_file_name): Change to std::string.
1406         * top.c (source_file_name): Likewise.
1407         (command_line_input): Adjust.
1408         * cli/cli-script.c (script_from_file): Adjust.
1409
1410 2019-02-19  Tom Tromey  <tromey@adacore.com>
1411
1412         * ravenscar-thread.c
1413         (ravenscar_thread_target::update_thread_list): Don't call
1414         ada_build_task_list.
1415         * ada-lang.h (ada_build_task_list): Don't declare.
1416         * ada-tasks.c (struct ada_tasks_inferior_data)
1417         <task_list_valid_p>: Now bool.
1418         (read_known_tasks, ada_task_list_changed)
1419         (ada_tasks_invalidate_inferior_data): Update.
1420         (read_known_tasks_array): Return bool.
1421         (read_known_tasks_list): Likewise.
1422         (read_known_tasks): Return void.
1423         (ada_build_task_list): Now static.
1424
1425 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1426
1427         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1428         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1429
1430 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1431
1432         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1433         variant for ada_tasks_pspace_data_handle and
1434         ada_tasks_inferior_data_handle.
1435         (ada_tasks_pspace_data_cleanup): New function.
1436         (ada_tasks_inferior_data_cleanup): New function.
1437
1438 2019-02-17  Tom Tromey  <tom@tromey.com>
1439
1440         * macrotab.h (macro_source_fullname): Return a std::string.
1441         * macrotab.c (macro_include, check_for_redefinition)
1442         (macro_undef, macro_lookup_definition, foreach_macro)
1443         (foreach_macro_in_scope): Update.
1444         (macro_source_fullname): Return a std::string.
1445         * macrocmd.c (show_pp_source_pos): Update.
1446
1447 2019-02-17  Tom Tromey  <tom@tromey.com>
1448
1449         * macrocmd.c (show_pp_source_pos): Style the file names.
1450
1451 2019-02-17  Tom Tromey  <tom@tromey.com>
1452
1453         PR tui/24197:
1454         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1455
1456 2019-02-17  Tom Tromey  <tom@tromey.com>
1457
1458         * ada-lang.c (user_select_syms): Use filtered printing.
1459         * utils.c (wrap_style): New global.
1460         (desired_style): Remove.
1461         (emit_style_escape): Add stream parameter.
1462         (set_output_style, reset_terminal_style, prompt_for_continue):
1463         Update.
1464         (flush_wrap_buffer): Only flush gdb_stdout.
1465         (wrap_here): Set wrap_style.
1466         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1467         treat escape sequences as a character.  Change when wrap buffer is
1468         flushed.
1469         (fputs_styled): Do not set the output style when the default is
1470         requested.
1471         * ui-style.h (struct ui_file_style) <is_default>: New method.
1472         * source.c (print_source_lines_base): Emit escape sequences in one
1473         piece.
1474
1475 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1476
1477         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1478         integers and enumeration types.
1479
1480 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1481
1482         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1483         instead of lookup_symbol_in_language
1484         (do_exact_match): New function.
1485         (ada_get_symbol_name_matcher): Return do_exact_match when
1486         doing a verbatim match.
1487
1488 2019-02-15  Tom Tromey  <tromey@adacore.com>
1489
1490         * ravenscar-thread.c (ravenscar_thread_target::resume)
1491         (ravenscar_thread_target::wait): Special case wildcard requests.
1492
1493 2019-02-15  Tom Tromey  <tromey@adacore.com>
1494
1495         * ravenscar-thread.c (base_ptid): Remove.
1496         (struct ravenscar_thread_target) <close>: New method.
1497         <m_base_ptid>: New member.
1498         <update_inferior_ptid, active_task, task_is_currently_active,
1499         runtime_initialized>: Declare methods.
1500         <ravenscar_thread_target>: Add constructor.
1501         (ravenscar_thread_target::task_is_currently_active)
1502         (ravenscar_thread_target::update_inferior_ptid)
1503         (ravenscar_runtime_initialized): Rename.  Now methods.
1504         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1505         (ravenscar_thread_target::update_thread_list): Update.
1506         (ravenscar_thread_target::active_task): Now method.
1507         (ravenscar_thread_target::store_registers)
1508         (ravenscar_thread_target::prepare_to_store)
1509         (ravenscar_thread_target::prepare_to_store)
1510         (ravenscar_thread_target::mourn_inferior): Update.
1511         (ravenscar_inferior_created): Use "new" to create target.
1512         (ravenscar_thread_target::get_ada_task_ptid): Update.
1513         (_initialize_ravenscar): Don't initialize base_ptid.
1514         (ravenscar_ops): Remove global.
1515
1516 2019-02-15  Tom Tromey  <tromey@adacore.com>
1517
1518         * target.h (push_target): Declare new overload.
1519         * target.c (push_target): New overload, taking an rvalue reference.
1520         * remote.c (remote_target::open_1): Use push_target overload.
1521         * corelow.c (core_target_open): Use push_target overload.
1522
1523 2019-02-15  Tom Tromey  <tromey@adacore.com>
1524
1525         * ravenscar-thread.c (is_ravenscar_task)
1526         (ravenscar_task_is_currently_active): Return bool.
1527         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1528         (_initialize_ravenscar): Remove "(void)".
1529         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1530         Return bool.
1531
1532 2019-02-15  Tom Tromey  <tromey@adacore.com>
1533
1534         * ravenscar-thread.c (ravenscar_runtime_initializer)
1535         (has_ravenscar_runtime, get_running_thread_id)
1536         (ravenscar_thread_target::resume): Fix indentation.
1537
1538 2019-02-15  Tom Tromey  <tromey@adacore.com>
1539
1540         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1541         from ravenscar_arch_ops.
1542         (sparc_ravenscar_ops::fetch_registers)
1543         (sparc_ravenscar_ops::store_registers): Now methods.
1544         (sparc_ravenscar_prepare_to_store): Remove.
1545         (sparc_ravenscar_ops): Redefine.
1546         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1547         methods and destructor.  Remove members.
1548         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1549         (ravenscar_thread_target::store_registers)
1550         (ravenscar_thread_target::prepare_to_store): Update.
1551         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1552         Remove.
1553         (struct ppc_ravenscar_powerpc_ops): Derive from
1554         ravenscar_arch_ops.
1555         (ppc_ravenscar_powerpc_ops::fetch_registers)
1556         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1557         (ppc_ravenscar_powerpc_ops): Redefine.
1558         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1559         (ppc_ravenscar_e500_ops::fetch_registers)
1560         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1561         (ppc_ravenscar_e500_ops): Redefine.
1562         * aarch64-ravenscar-thread.c
1563         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1564         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1565         (aarch64_ravenscar_fetch_registers)
1566         (aarch64_ravenscar_store_registers): Now methods.
1567         (aarch64_ravenscar_ops): Redefine.
1568
1569 2019-02-15  Tom Tromey  <tromey@adacore.com>
1570
1571         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1572         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1573         (ravenscar_thread_target::stopped_by_watchpoint)
1574         (ravenscar_thread_target::stopped_data_address)
1575         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1576
1577 2019-02-15  Tom Tromey  <tromey@adacore.com>
1578
1579         * ravenscar-thread.c: Fix some typos.
1580
1581 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1582             Tom Tromey  <tromey@adacore.com>
1583
1584         * ada-lang.c (ada_exception_sal): Change addr_string to a
1585         std::string.
1586         (create_ada_exception_catchpoint): Update.
1587
1588 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1589             Tom Tromey  <tromey@adacore.com>
1590
1591         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1592         (bp_location_ops): Remove.
1593         (base_breakpoint_allocate_location): Update.
1594         (free_bp_location): Update.
1595         * ada-lang.c (class ada_catchpoint_location)
1596         <ada_catchpoint_location>: Remove ops parameter.
1597         (ada_catchpoint_location_dtor): Remove.
1598         (ada_catchpoint_location_ops): Remove.
1599         (allocate_location_exception): Update.
1600         * breakpoint.h (struct bp_location_ops): Remove.
1601         (class bp_location) <bp_location>: Remove bp_location_ops
1602         parameter.
1603         <~bp_location>: Add destructor.
1604         <ops>: Remove.
1605
1606 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1607             Pedro Alves  <palves@redhat.com>
1608
1609         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1610         'PATH_MAX'.
1611
1612 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1613             Samuel Thibault  <samuel.thibault@gnu.org>
1614             Thomas Schwinge  <thomas@codesourcery.com>
1615
1616         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1617         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1618
1619 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1620
1621         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1622         (check_empty): Use "const char *".
1623
1624         * gnu-nat.c (gnu_nat_target::detach): Instead of
1625         'detach_inferior (pid)' call
1626         'detach_inferior (find_inferior_pid (pid))'.
1627
1628         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1629         'nat/fork-inferior.o'.
1630         * gnu-nat.c: #include "nat/fork-inferior.h".
1631
1632         * gnu-nat.c (gnu_nat_target::detach): Instead of
1633         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1634         * gnu-nat.h: #include "inf-child.h".
1635         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1636         'i386_gnu_nat_target::fetch_registers'.
1637         (gnu_store_registers): Rename/move to
1638         'i386_gnu_nat_target::store_registers'.
1639
1640         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1641         * gnu-nat.h (mach_thread_info): New function.
1642         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1643
1644         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1645
1646 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1647
1648         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1649
1650 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1651
1652         * windows-nat.c (windows_add_thread): Add new parameter
1653         "main_thread_p" with default value set to false.  Update
1654         function documentation as well as all callers.
1655         (windows_delete_thread): Likewise.
1656         (fake_create_process): Update call to windows_add_thread.
1657         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1658         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1659         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1660         call to windows_delete_thread.
1661
1662 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1663
1664         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1665
1666 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1667
1668         * symfile.c (find_separate_debug_file): Use canonical path of
1669         sysroot with child_path instead of gdb_sysroot if it is valid.
1670
1671 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1672
1673         * symfile.c (find_separate_debug_file): Use child_path to
1674         determine if an object file is under a sysroot.
1675
1676 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1677
1678         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1679         unittests/child-path-selftests.c.
1680         * common/pathstuff.c (child_path): New function.
1681         * common/pathstuff.h (child_path): New prototype.
1682         * unittests/child-path-selftests.c: New file.
1683
1684 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1685
1686         * symfile.c (find_separate_debug_file): Look for separate debug
1687         files in debug directories under the sysroot.
1688
1689 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1690
1691         * symtab.h (struct minimal_symbol data_p): New const method.
1692         (struct minimal_symbol text_p): Likewise.
1693         * symtab.c (output_source_filename): Use file name style
1694         to print file name.
1695         (print_symbol_info): Likewise.
1696         (print_msymbol_info): Use address style to print addresses.
1697         Use function name style to print executable text symbols.
1698         (expand_symtab_containing_pc): Use data_p.
1699         (find_pc_sect_compunit_symtab): Likewise.
1700
1701 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1702
1703         * breakpoint.c (describe_other_breakpoints): Use address style
1704         to print addresses.
1705         (say_where): Likewise.
1706
1707 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1708
1709         * ada-typeprint.c (print_func_type): Print function name
1710         style to print function name.
1711         * c-typeprint.c (c_print_type_1): Likewise.
1712
1713 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1714
1715         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1716         for execve.
1717
1718 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1719
1720         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1721         type_stack.
1722
1723 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1724
1725         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1726         TYPE_CODE_REF types.
1727
1728 2019-02-08  Jim Wilson  <jimw@sifive.com>
1729
1730         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1731         (riscv_linux_fregset): New.
1732         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1733
1734 2019-02-07  Tom Tromey  <tom@tromey.com>
1735
1736         * thread.c (thread_cancel_execution_command): Update.
1737         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1738         methods.
1739         (struct thread_fsm_ops): Remove.
1740         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1741         (thread_fsm_should_stop, thread_fsm_return_value)
1742         (thread_fsm_set_finished, thread_fsm_finished_p)
1743         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1744         Don't declare.
1745         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1746         * infrun.c (clear_proceed_status_thread)
1747         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1748         (print_stop_event): Update.
1749         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1750         Add constructor.
1751         (step_command_fsm_ops): Remove.
1752         (new_step_command_fsm): Remove.
1753         (step_1): Update.
1754         (step_command_fsm::should_stop): Rename from
1755         step_command_fsm_should_stop.
1756         (step_command_fsm::clean_up): Rename from
1757         step_command_fsm_clean_up.
1758         (step_command_fsm::do_async_reply_reason): Rename from
1759         step_command_fsm_async_reply_reason.
1760         (struct until_next_fsm): Inherit from thread_fsm.  Add
1761         constructor.
1762         (until_next_fsm_ops): Remove.
1763         (new_until_next_fsm): Remove.
1764         (until_next_fsm::should_stop): Rename from
1765         until_next_fsm_should_stop.
1766         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1767         (until_next_fsm::do_async_reply_reason): Rename from
1768         until_next_fsm_async_reply_reason.
1769         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1770         constructor.  Change type of breakpoint.
1771         (finish_command_fsm_ops): Remove.
1772         (new_finish_command_fsm): Remove.
1773         (finish_command_fsm::should_stop): Rename from
1774         finish_command_fsm_should_stop.
1775         (finish_command_fsm::clean_up): Rename from
1776         finish_command_fsm_clean_up.
1777         (finish_command_fsm::return_value): Rename from
1778         finish_command_fsm_return_value.
1779         (finish_command_fsm::do_async_reply_reason): Rename from
1780         finish_command_fsm_async_reply_reason.
1781         (finish_command): Update.
1782         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1783         Add constructor.
1784         (call_thread_fsm_ops): Remove.
1785         (call_thread_fsm::call_thread_fsm): Rename from
1786         new_call_thread_fsm.
1787         (call_thread_fsm::should_stop): Rename from
1788         call_thread_fsm_should_stop.
1789         (call_thread_fsm::should_notify_stop): Rename from
1790         call_thread_fsm_should_notify_stop.
1791         (run_inferior_call, call_function_by_hand_dummy): Update.
1792         * cli/cli-interp.c (should_print_stop_to_console): Update.
1793         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1794         Add constructor.  Change type of location_breakpoint,
1795         caller_breakpoint.
1796         (until_break_fsm_ops): Remove.
1797         (new_until_break_fsm): Remove.
1798         (until_break_fsm::should_stop): Rename from
1799         until_break_fsm_should_stop.
1800         (until_break_fsm::clean_up): Rename from
1801         until_break_fsm_clean_up.
1802         (until_break_fsm::do_async_reply_reason): Rename from
1803         until_break_fsm_async_reply_reason.
1804         (until_break_command): Update.
1805         * thread-fsm.c: Remove.
1806         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1807
1808 2019-02-07  Tom Tromey  <tom@tromey.com>
1809
1810         * yy-remap.h: Add include guard.
1811         * xtensa-tdep.h: Add include guard.
1812         * xcoffread.h: Rename include guard.
1813         * varobj-iter.h: Add include guard.
1814         * tui/tui.h: Rename include guard.
1815         * tui/tui-winsource.h: Rename include guard.
1816         * tui/tui-wingeneral.h: Rename include guard.
1817         * tui/tui-windata.h: Rename include guard.
1818         * tui/tui-win.h: Rename include guard.
1819         * tui/tui-stack.h: Rename include guard.
1820         * tui/tui-source.h: Rename include guard.
1821         * tui/tui-regs.h: Rename include guard.
1822         * tui/tui-out.h: Rename include guard.
1823         * tui/tui-layout.h: Rename include guard.
1824         * tui/tui-io.h: Rename include guard.
1825         * tui/tui-hooks.h: Rename include guard.
1826         * tui/tui-file.h: Rename include guard.
1827         * tui/tui-disasm.h: Rename include guard.
1828         * tui/tui-data.h: Rename include guard.
1829         * tui/tui-command.h: Rename include guard.
1830         * tic6x-tdep.h: Add include guard.
1831         * target/waitstatus.h: Rename include guard.
1832         * target/wait.h: Rename include guard.
1833         * target/target.h: Rename include guard.
1834         * target/resume.h: Rename include guard.
1835         * target-float.h: Rename include guard.
1836         * stabsread.h: Add include guard.
1837         * rs6000-tdep.h: Add include guard.
1838         * riscv-fbsd-tdep.h: Add include guard.
1839         * regformats/regdef.h: Rename include guard.
1840         * record.h: Rename include guard.
1841         * python/python.h: Rename include guard.
1842         * python/python-internal.h: Rename include guard.
1843         * python/py-stopevent.h: Rename include guard.
1844         * python/py-ref.h: Rename include guard.
1845         * python/py-record.h: Rename include guard.
1846         * python/py-record-full.h: Rename include guard.
1847         * python/py-record-btrace.h: Rename include guard.
1848         * python/py-instruction.h: Rename include guard.
1849         * python/py-events.h: Rename include guard.
1850         * python/py-event.h: Rename include guard.
1851         * procfs.h: Add include guard.
1852         * proc-utils.h: Add include guard.
1853         * p-lang.h: Add include guard.
1854         * or1k-tdep.h: Rename include guard.
1855         * observable.h: Rename include guard.
1856         * nto-tdep.h: Rename include guard.
1857         * nat/x86-linux.h: Rename include guard.
1858         * nat/x86-linux-dregs.h: Rename include guard.
1859         * nat/x86-gcc-cpuid.h: Add include guard.
1860         * nat/x86-dregs.h: Rename include guard.
1861         * nat/x86-cpuid.h: Rename include guard.
1862         * nat/ppc-linux.h: Rename include guard.
1863         * nat/mips-linux-watch.h: Rename include guard.
1864         * nat/linux-waitpid.h: Rename include guard.
1865         * nat/linux-ptrace.h: Rename include guard.
1866         * nat/linux-procfs.h: Rename include guard.
1867         * nat/linux-osdata.h: Rename include guard.
1868         * nat/linux-nat.h: Rename include guard.
1869         * nat/linux-namespaces.h: Rename include guard.
1870         * nat/linux-btrace.h: Rename include guard.
1871         * nat/glibc_thread_db.h: Rename include guard.
1872         * nat/gdb_thread_db.h: Rename include guard.
1873         * nat/gdb_ptrace.h: Rename include guard.
1874         * nat/fork-inferior.h: Rename include guard.
1875         * nat/amd64-linux-siginfo.h: Rename include guard.
1876         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1877         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1878         * nat/aarch64-linux.h: Rename include guard.
1879         * nat/aarch64-linux-hw-point.h: Rename include guard.
1880         * mn10300-tdep.h: Add include guard.
1881         * mips-linux-tdep.h: Add include guard.
1882         * mi/mi-parse.h: Rename include guard.
1883         * mi/mi-out.h: Rename include guard.
1884         * mi/mi-main.h: Rename include guard.
1885         * mi/mi-interp.h: Rename include guard.
1886         * mi/mi-getopt.h: Rename include guard.
1887         * mi/mi-console.h: Rename include guard.
1888         * mi/mi-common.h: Rename include guard.
1889         * mi/mi-cmds.h: Rename include guard.
1890         * mi/mi-cmd-break.h: Rename include guard.
1891         * m2-lang.h: Add include guard.
1892         * location.h: Rename include guard.
1893         * linux-record.h: Rename include guard.
1894         * linux-nat.h: Add include guard.
1895         * linux-fork.h: Add include guard.
1896         * i386-darwin-tdep.h: Rename include guard.
1897         * hppa-linux-offsets.h: Add include guard.
1898         * guile/guile.h: Rename include guard.
1899         * guile/guile-internal.h: Rename include guard.
1900         * gnu-nat.h: Rename include guard.
1901         * gdb-stabs.h: Rename include guard.
1902         * frv-tdep.h: Add include guard.
1903         * f-lang.h: Add include guard.
1904         * event-loop.h: Add include guard.
1905         * darwin-nat.h: Rename include guard.
1906         * cp-abi.h: Rename include guard.
1907         * config/sparc/nm-sol2.h: Rename include guard.
1908         * config/nm-nto.h: Rename include guard.
1909         * config/nm-linux.h: Add include guard.
1910         * config/i386/nm-i386gnu.h: Rename include guard.
1911         * config/djgpp/nl_types.h: Rename include guard.
1912         * config/djgpp/langinfo.h: Rename include guard.
1913         * compile/gcc-cp-plugin.h: Add include guard.
1914         * compile/gcc-c-plugin.h: Add include guard.
1915         * compile/compile.h: Rename include guard.
1916         * compile/compile-object-run.h: Rename include guard.
1917         * compile/compile-object-load.h: Rename include guard.
1918         * compile/compile-internal.h: Rename include guard.
1919         * compile/compile-cplus.h: Rename include guard.
1920         * compile/compile-c.h: Rename include guard.
1921         * common/xml-utils.h: Rename include guard.
1922         * common/x86-xstate.h: Rename include guard.
1923         * common/version.h: Rename include guard.
1924         * common/vec.h: Rename include guard.
1925         * common/tdesc.h: Rename include guard.
1926         * common/selftest.h: Rename include guard.
1927         * common/scoped_restore.h: Rename include guard.
1928         * common/scoped_mmap.h: Rename include guard.
1929         * common/scoped_fd.h: Rename include guard.
1930         * common/safe-iterator.h: Rename include guard.
1931         * common/run-time-clock.h: Rename include guard.
1932         * common/refcounted-object.h: Rename include guard.
1933         * common/queue.h: Rename include guard.
1934         * common/ptid.h: Rename include guard.
1935         * common/print-utils.h: Rename include guard.
1936         * common/preprocessor.h: Rename include guard.
1937         * common/pathstuff.h: Rename include guard.
1938         * common/observable.h: Rename include guard.
1939         * common/netstuff.h: Rename include guard.
1940         * common/job-control.h: Rename include guard.
1941         * common/host-defs.h: Rename include guard.
1942         * common/gdb_wait.h: Rename include guard.
1943         * common/gdb_vecs.h: Rename include guard.
1944         * common/gdb_unlinker.h: Rename include guard.
1945         * common/gdb_unique_ptr.h: Rename include guard.
1946         * common/gdb_tilde_expand.h: Rename include guard.
1947         * common/gdb_sys_time.h: Rename include guard.
1948         * common/gdb_string_view.h: Rename include guard.
1949         * common/gdb_splay_tree.h: Rename include guard.
1950         * common/gdb_setjmp.h: Rename include guard.
1951         * common/gdb_ref_ptr.h: Rename include guard.
1952         * common/gdb_optional.h: Rename include guard.
1953         * common/gdb_locale.h: Rename include guard.
1954         * common/gdb_assert.h: Rename include guard.
1955         * common/filtered-iterator.h: Rename include guard.
1956         * common/filestuff.h: Rename include guard.
1957         * common/fileio.h: Rename include guard.
1958         * common/environ.h: Rename include guard.
1959         * common/common-utils.h: Rename include guard.
1960         * common/common-types.h: Rename include guard.
1961         * common/common-regcache.h: Rename include guard.
1962         * common/common-inferior.h: Rename include guard.
1963         * common/common-gdbthread.h: Rename include guard.
1964         * common/common-exceptions.h: Rename include guard.
1965         * common/common-defs.h: Rename include guard.
1966         * common/common-debug.h: Rename include guard.
1967         * common/cleanups.h: Rename include guard.
1968         * common/buffer.h: Rename include guard.
1969         * common/btrace-common.h: Rename include guard.
1970         * common/break-common.h: Rename include guard.
1971         * cli/cli-utils.h: Rename include guard.
1972         * cli/cli-style.h: Rename include guard.
1973         * cli/cli-setshow.h: Rename include guard.
1974         * cli/cli-script.h: Rename include guard.
1975         * cli/cli-interp.h: Rename include guard.
1976         * cli/cli-decode.h: Rename include guard.
1977         * cli/cli-cmds.h: Rename include guard.
1978         * charset-list.h: Add include guard.
1979         * buildsym-legacy.h: Rename include guard.
1980         * bfin-tdep.h: Add include guard.
1981         * ax.h: Rename include guard.
1982         * arm-linux-tdep.h: Add include guard.
1983         * arm-fbsd-tdep.h: Add include guard.
1984         * arch/xtensa.h: Rename include guard.
1985         * arch/tic6x.h: Add include guard.
1986         * arch/i386.h: Add include guard.
1987         * arch/arm.h: Rename include guard.
1988         * arch/arm-linux.h: Rename include guard.
1989         * arch/arm-get-next-pcs.h: Rename include guard.
1990         * arch/amd64.h: Add include guard.
1991         * arch/aarch64-insn.h: Rename include guard.
1992         * arch-utils.h: Rename include guard.
1993         * annotate.h: Add include guard.
1994         * amd64-darwin-tdep.h: Rename include guard.
1995         * aarch64-linux-tdep.h: Add include guard.
1996         * aarch64-fbsd-tdep.h: Add include guard.
1997         * aarch32-linux-nat.h: Add include guard.
1998
1999 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2000
2001         * macrotab.c (macro_define_internal): New function that
2002         factorizes macro_define_object_internal and macro_define_function
2003         code.
2004         (macro_define_object_internal): Use macro_define_internal.
2005         (macro_define_function): Likewise.
2006
2007 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2008
2009         * macrocmd.c (extract_identifier): Return
2010         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2011         callers.
2012
2013 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2014
2015         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2016
2017 2019-02-05  Tom Tromey  <tom@tromey.com>
2018
2019         * target.c (target_stack::unpush): Move assertion earlier.
2020
2021 2019-01-30  Tom Tromey  <tom@tromey.com>
2022
2023         PR python/23615:
2024         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2025         (gdbpy_parse_and_eval): Likewise.
2026         * python/python-internal.h (gdbpy_allow_threads): New class.
2027
2028 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2029
2030         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2031         (aarch64_fbsd_fpregmap): Move earlier.
2032         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2033         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2034         instead of individual calls to trad_frame_set_reg_addr.
2035         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2036         earlier.
2037         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2038         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2039         instead of individual calls to trad_frame_set_reg_addr.
2040
2041 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2042
2043         * CONTRIBUTE: Replace contribution list with wiki link.
2044
2045 2019-01-25  Tom Tromey  <tom@tromey.com>
2046
2047         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2048
2049 2019-01-25  Tom Tromey  <tom@tromey.com>
2050
2051         * xtensa-linux-nat.c: Fix common/ includes.
2052         * xml-support.h: Fix common/ includes.
2053         * xml-support.c: Fix common/ includes.
2054         * x86-linux-nat.c: Fix common/ includes.
2055         * windows-nat.c: Fix common/ includes.
2056         * varobj.h: Fix common/ includes.
2057         * varobj.c: Fix common/ includes.
2058         * value.c: Fix common/ includes.
2059         * valops.c: Fix common/ includes.
2060         * utils.c: Fix common/ includes.
2061         * unittests/xml-utils-selftests.c: Fix common/ includes.
2062         * unittests/utils-selftests.c: Fix common/ includes.
2063         * unittests/unpack-selftests.c: Fix common/ includes.
2064         * unittests/tracepoint-selftests.c: Fix common/ includes.
2065         * unittests/style-selftests.c: Fix common/ includes.
2066         * unittests/string_view-selftests.c: Fix common/ includes.
2067         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2068         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2069         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2070         * unittests/rsp-low-selftests.c: Fix common/ includes.
2071         * unittests/parse-connection-spec-selftests.c: Fix common/
2072         includes.
2073         * unittests/optional-selftests.c: Fix common/ includes.
2074         * unittests/offset-type-selftests.c: Fix common/ includes.
2075         * unittests/observable-selftests.c: Fix common/ includes.
2076         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2077         * unittests/memrange-selftests.c: Fix common/ includes.
2078         * unittests/memory-map-selftests.c: Fix common/ includes.
2079         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2080         * unittests/function-view-selftests.c: Fix common/ includes.
2081         * unittests/environ-selftests.c: Fix common/ includes.
2082         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2083         * unittests/common-utils-selftests.c: Fix common/ includes.
2084         * unittests/cli-utils-selftests.c: Fix common/ includes.
2085         * unittests/array-view-selftests.c: Fix common/ includes.
2086         * ui-file.c: Fix common/ includes.
2087         * tui/tui-io.c: Fix common/ includes.
2088         * tracepoint.h: Fix common/ includes.
2089         * tracepoint.c: Fix common/ includes.
2090         * tracefile-tfile.c: Fix common/ includes.
2091         * top.h: Fix common/ includes.
2092         * top.c: Fix common/ includes.
2093         * thread.c: Fix common/ includes.
2094         * target/waitstatus.h: Fix common/ includes.
2095         * target/waitstatus.c: Fix common/ includes.
2096         * target.h: Fix common/ includes.
2097         * target.c: Fix common/ includes.
2098         * target-memory.c: Fix common/ includes.
2099         * target-descriptions.c: Fix common/ includes.
2100         * symtab.h: Fix common/ includes.
2101         * symfile.c: Fix common/ includes.
2102         * stap-probe.c: Fix common/ includes.
2103         * spu-linux-nat.c: Fix common/ includes.
2104         * sparc-nat.c: Fix common/ includes.
2105         * source.c: Fix common/ includes.
2106         * solib.c: Fix common/ includes.
2107         * solib-target.c: Fix common/ includes.
2108         * ser-unix.c: Fix common/ includes.
2109         * ser-tcp.c: Fix common/ includes.
2110         * ser-pipe.c: Fix common/ includes.
2111         * ser-base.c: Fix common/ includes.
2112         * selftest-arch.c: Fix common/ includes.
2113         * s12z-tdep.c: Fix common/ includes.
2114         * rust-exp.y: Fix common/ includes.
2115         * rs6000-aix-tdep.c: Fix common/ includes.
2116         * riscv-tdep.c: Fix common/ includes.
2117         * remote.c: Fix common/ includes.
2118         * remote-notif.h: Fix common/ includes.
2119         * remote-fileio.h: Fix common/ includes.
2120         * remote-fileio.c: Fix common/ includes.
2121         * regcache.h: Fix common/ includes.
2122         * regcache.c: Fix common/ includes.
2123         * record-btrace.c: Fix common/ includes.
2124         * python/python.c: Fix common/ includes.
2125         * python/py-type.c: Fix common/ includes.
2126         * python/py-inferior.c: Fix common/ includes.
2127         * progspace.h: Fix common/ includes.
2128         * producer.c: Fix common/ includes.
2129         * procfs.c: Fix common/ includes.
2130         * proc-api.c: Fix common/ includes.
2131         * printcmd.c: Fix common/ includes.
2132         * ppc-linux-nat.c: Fix common/ includes.
2133         * parser-defs.h: Fix common/ includes.
2134         * osdata.c: Fix common/ includes.
2135         * obsd-nat.c: Fix common/ includes.
2136         * nat/x86-linux.c: Fix common/ includes.
2137         * nat/x86-linux-dregs.c: Fix common/ includes.
2138         * nat/x86-dregs.h: Fix common/ includes.
2139         * nat/x86-dregs.c: Fix common/ includes.
2140         * nat/ppc-linux.c: Fix common/ includes.
2141         * nat/mips-linux-watch.h: Fix common/ includes.
2142         * nat/mips-linux-watch.c: Fix common/ includes.
2143         * nat/linux-waitpid.c: Fix common/ includes.
2144         * nat/linux-ptrace.h: Fix common/ includes.
2145         * nat/linux-ptrace.c: Fix common/ includes.
2146         * nat/linux-procfs.c: Fix common/ includes.
2147         * nat/linux-personality.c: Fix common/ includes.
2148         * nat/linux-osdata.c: Fix common/ includes.
2149         * nat/linux-namespaces.c: Fix common/ includes.
2150         * nat/linux-btrace.h: Fix common/ includes.
2151         * nat/linux-btrace.c: Fix common/ includes.
2152         * nat/fork-inferior.c: Fix common/ includes.
2153         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2154         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2155         * nat/aarch64-linux.c: Fix common/ includes.
2156         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2157         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2158         * namespace.h: Fix common/ includes.
2159         * mips-linux-tdep.c: Fix common/ includes.
2160         * minsyms.c: Fix common/ includes.
2161         * mi/mi-parse.h: Fix common/ includes.
2162         * mi/mi-main.c: Fix common/ includes.
2163         * mi/mi-cmd-env.c: Fix common/ includes.
2164         * memrange.h: Fix common/ includes.
2165         * memattr.c: Fix common/ includes.
2166         * maint.h: Fix common/ includes.
2167         * maint.c: Fix common/ includes.
2168         * main.c: Fix common/ includes.
2169         * machoread.c: Fix common/ includes.
2170         * location.c: Fix common/ includes.
2171         * linux-thread-db.c: Fix common/ includes.
2172         * linux-nat.c: Fix common/ includes.
2173         * linux-fork.c: Fix common/ includes.
2174         * inline-frame.c: Fix common/ includes.
2175         * infrun.c: Fix common/ includes.
2176         * inflow.c: Fix common/ includes.
2177         * inferior.h: Fix common/ includes.
2178         * inferior.c: Fix common/ includes.
2179         * infcmd.c: Fix common/ includes.
2180         * inf-ptrace.c: Fix common/ includes.
2181         * inf-child.c: Fix common/ includes.
2182         * ia64-linux-nat.c: Fix common/ includes.
2183         * i387-tdep.c: Fix common/ includes.
2184         * i386-tdep.c: Fix common/ includes.
2185         * i386-linux-tdep.c: Fix common/ includes.
2186         * i386-linux-nat.c: Fix common/ includes.
2187         * i386-go32-tdep.c: Fix common/ includes.
2188         * i386-fbsd-tdep.c: Fix common/ includes.
2189         * i386-fbsd-nat.c: Fix common/ includes.
2190         * guile/scm-type.c: Fix common/ includes.
2191         * guile/guile.c: Fix common/ includes.
2192         * go32-nat.c: Fix common/ includes.
2193         * gnu-nat.c: Fix common/ includes.
2194         * gdbthread.h: Fix common/ includes.
2195         * gdbarch-selftests.c: Fix common/ includes.
2196         * gdb_usleep.c: Fix common/ includes.
2197         * gdb_select.h: Fix common/ includes.
2198         * gdb_bfd.c: Fix common/ includes.
2199         * gcore.c: Fix common/ includes.
2200         * fork-child.c: Fix common/ includes.
2201         * findvar.c: Fix common/ includes.
2202         * fbsd-nat.c: Fix common/ includes.
2203         * event-top.c: Fix common/ includes.
2204         * event-loop.c: Fix common/ includes.
2205         * dwarf2read.c: Fix common/ includes.
2206         * dwarf2loc.c: Fix common/ includes.
2207         * dwarf2-frame.c: Fix common/ includes.
2208         * dwarf-index-cache.c: Fix common/ includes.
2209         * dtrace-probe.c: Fix common/ includes.
2210         * disasm-selftests.c: Fix common/ includes.
2211         * defs.h: Fix common/ includes.
2212         * csky-tdep.c: Fix common/ includes.
2213         * cp-valprint.c: Fix common/ includes.
2214         * cp-support.h: Fix common/ includes.
2215         * cp-support.c: Fix common/ includes.
2216         * corelow.c: Fix common/ includes.
2217         * completer.h: Fix common/ includes.
2218         * completer.c: Fix common/ includes.
2219         * compile/compile.c: Fix common/ includes.
2220         * compile/compile-loc2c.c: Fix common/ includes.
2221         * compile/compile-cplus-types.c: Fix common/ includes.
2222         * compile/compile-cplus-symbols.c: Fix common/ includes.
2223         * command.h: Fix common/ includes.
2224         * cli/cli-dump.c: Fix common/ includes.
2225         * cli/cli-cmds.c: Fix common/ includes.
2226         * charset.c: Fix common/ includes.
2227         * build-id.c: Fix common/ includes.
2228         * btrace.h: Fix common/ includes.
2229         * btrace.c: Fix common/ includes.
2230         * breakpoint.h: Fix common/ includes.
2231         * breakpoint.c: Fix common/ includes.
2232         * ax.h:
2233         (enum agent_op): Fix common/ includes.
2234         * ax-general.c (struct aop_map): Fix common/ includes.
2235         * ax-gdb.c: Fix common/ includes.
2236         * auxv.c: Fix common/ includes.
2237         * auto-load.c: Fix common/ includes.
2238         * arm-tdep.c: Fix common/ includes.
2239         * arch/riscv.c: Fix common/ includes.
2240         * arch/ppc-linux-common.c: Fix common/ includes.
2241         * arch/i386.c: Fix common/ includes.
2242         * arch/arm.c: Fix common/ includes.
2243         * arch/arm-linux.c: Fix common/ includes.
2244         * arch/arm-get-next-pcs.c: Fix common/ includes.
2245         * arch/amd64.c: Fix common/ includes.
2246         * arch/aarch64.c: Fix common/ includes.
2247         * arch/aarch64-insn.c: Fix common/ includes.
2248         * arch-utils.c: Fix common/ includes.
2249         * amd64-windows-tdep.c: Fix common/ includes.
2250         * amd64-tdep.c: Fix common/ includes.
2251         * amd64-sol2-tdep.c: Fix common/ includes.
2252         * amd64-obsd-tdep.c: Fix common/ includes.
2253         * amd64-nbsd-tdep.c: Fix common/ includes.
2254         * amd64-linux-tdep.c: Fix common/ includes.
2255         * amd64-linux-nat.c: Fix common/ includes.
2256         * amd64-fbsd-tdep.c: Fix common/ includes.
2257         * amd64-fbsd-nat.c: Fix common/ includes.
2258         * amd64-dicos-tdep.c: Fix common/ includes.
2259         * amd64-darwin-tdep.c: Fix common/ includes.
2260         * agent.c: Fix common/ includes.
2261         * ada-lang.h: Fix common/ includes.
2262         * ada-lang.c: Fix common/ includes.
2263         * aarch64-tdep.c: Fix common/ includes.
2264
2265 2019-01-25  Tom Tromey  <tom@tromey.com>
2266
2267         * common/create-version.sh: Use common/version.h.
2268
2269 2019-01-24  Pedro Alves  <palves@redhat.com>
2270
2271         * infrun.c (signal_stop, signal_print, signal_program)
2272         (signal_catch, signal_pass): Now arrays instead of pointers.
2273         (update_signals_program_target, do_target_resume)
2274         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2275         * linux-nat.c (linux_nat_target::pass_signals)
2276         (linux_nat_target::create_inferior, linux_nat_target::attach):
2277         Adjust.
2278         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2279         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2280         * procfs.c (procfs_target::pass_signals): Adjust.
2281         * record-full.c (record_full_target::resume): Adjust.
2282         * remote.c (remote_target::pass_signals)
2283         (remote_target::program_signals): Adjust.
2284         * target-debug.h (target_debug_print_signals): Now takes a
2285         gdb::array_view as parameter.  Adjust.
2286         * target.h (target_ops) <pass_signals, program_signals>: Replace
2287         pointer and length parameters with gdb::array_view.
2288         (target_pass_signals, target_program_signals): Likewise.
2289         * target-delegates.c: Regenerate.
2290
2291 2019-01-24  Pedro Alves  <palves@redhat.com>
2292
2293         * common/forward-scope-exit.h
2294         (forward_scope_exit::forward_scope_exit): Pass arguments to
2295         m_bind_function directly, instead of creating a std::bind and
2296         copying that.
2297
2298 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2299
2300         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2301         for static members.
2302         (pass_in_v_vfp_candidate): Likewise.
2303
2304 2019-01-23  Tom Tromey  <tom@tromey.com>
2305             Pedro Alves  <palves@redhat.com>
2306
2307         * regcache.c (class regcache_invalidator): Remove.
2308         (regcache::raw_write): Use make_scope_exit.
2309
2310 2019-01-23  Tom Tromey  <tom@tromey.com>
2311
2312         * ui-out.h (class ui_out_emit_type): Update comment.
2313
2314 2019-01-23  Tom Tromey  <tom@tromey.com>
2315
2316         * infrun.c (fetch_inferior_event): Update comment.
2317
2318 2019-01-23  Tom Tromey  <tom@tromey.com>
2319             Pedro Alves  <palves@redhat.com>
2320
2321         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2322         parameter.
2323         (fetch_inferior_event): Use SCOPE_EXIT.
2324
2325
2326 2019-01-23  Tom Tromey  <tom@tromey.com>
2327             Pedro Alves  <palves@redhat.com>
2328
2329         * infrun.c (disable_thread_events): Delete.
2330         (stop_all_threads): Use SCOPE_EXIT.
2331
2332 2019-01-23  Tom Tromey  <tom@tromey.com>
2333             Pedro Alves  <palves@redhat.com>
2334
2335         * symfile.c: Include forward-scope-exit.h.
2336         (clear_symtab_users_cleanup): Replace forward declaration with
2337         a FORWARD_SCOPE_EXIT.
2338         (syms_from_objfile_1): Use the forward_scope_exit and
2339         gdb::optional instead of cleanup_function.
2340         (reread_symbols): Use the forward_scope_exit instead of
2341         cleanup_function.
2342         (clear_symtab_users_cleanup): Remove function.
2343
2344 2019-01-23  Tom Tromey  <tom@tromey.com>
2345             Pedro Alves  <palves@redhat.com>
2346
2347         * linux-nat.c: Include scope-exit.h.
2348         (cleanup_target_stop): Remove.
2349         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2350         SCOPE_EXIT.
2351
2352 2019-01-23  Tom Tromey  <tom@tromey.com>
2353             Pedro Alves  <palves@redhat.com>
2354
2355         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2356         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2357
2358 2019-01-23  Tom Tromey  <tom@tromey.com>
2359             Andrew Burgess  <andrew.burgess@embecosm.com>
2360             Pedro Alves  <palves@redhat.com>
2361
2362         * infrun.c (fetch_inferior_event): Use scope_exit.
2363         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2364         * top.c (execute_command): Use scope_exit.
2365         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2366         * utils.c (do_bpstat_clear_actions_cleanup)
2367         (make_bpstat_clear_actions_cleanup): Remove.
2368
2369 2019-01-23  Tom Tromey  <tom@tromey.com>
2370             Pedro Alves  <palves@redhat.com>
2371
2372         * infrun.c: Include "common/scope-exit.h"
2373         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2374         (wait_for_inferior): Use SCOPE_EXIT.
2375         (fetch_inferior_event): Use scope_exit.
2376
2377 2019-01-23  Tom Tromey  <tom@tromey.com>
2378             Pedro Alves  <palves@redhat.com>
2379
2380         * breakpoint.c (create_breakpoint): Remove cleanup.
2381
2382 2019-01-23  Tom Tromey  <tom@tromey.com>
2383             Andrew Burgess  <andrew.burgess@embecosm.com>
2384             Pedro Alves  <palves@redhat.com>
2385
2386 2019-01-23  Pedro Alves  <palves@redhat.com>
2387
2388         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2389
2390 2019-01-23  Pedro Alves  <palves@redhat.com>
2391             Andrew Burgess  <andrew.burgess@embecosm.com>
2392
2393         * gdbthread.h: Include "common/forward-scope-exit.h".
2394         (scoped_finish_thread_state): Redefine custom class in terms of
2395         forward_scope_exit.
2396
2397 2019-01-23  Pedro Alves  <palves@redhat.com>
2398             Andrew Burgess  <andrew.burgess@embecosm.com>
2399
2400         * common/forward-scope-exit.h: New file.
2401
2402 2019-01-23  Pedro Alves  <palves@redhat.com>
2403             Andrew Burgess  <andrew.burgess@embecosm.com>
2404             Tom Tromey  <tom@tromey.com>
2405
2406         * common/scope-exit.h: New file.
2407
2408 2019-01-23  Pedro Alves  <palves@redhat.com>
2409
2410         * common/preprocessor.h (ESC): Rename to ...
2411         (ESC_PARENS): ... this.
2412         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2413         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2414
2415 2019-01-23  Tom Tromey  <tom@tromey.com>
2416
2417         * language.h (class scoped_switch_to_sym_language_if_auto):
2418         Initialize m_lang in both cases.
2419
2420 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2421
2422         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2423         with XCNEW.
2424
2425 2019-01-22  Tom Tromey  <tom@tromey.com>
2426
2427         * corelow.c: Do not include sys/file.h.
2428
2429 2019-01-22  Tom Tromey  <tom@tromey.com>
2430
2431         * tui/tui-wingeneral.h: Include gdb_curses.h.
2432
2433 2019-01-22  Tom Tromey  <tom@tromey.com>
2434
2435         * source-cache.h (class source_cache) <get_source_lines,
2436         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2437
2438 2019-01-22  Tom Tromey  <tom@tromey.com>
2439
2440         * remote-fileio.h (struct remote_target): Declare.
2441
2442 2019-01-22  Tom Tromey  <tom@tromey.com>
2443
2444         * python/py-arch.c: Do not include py-ref.h.
2445         * python/py-bpevent.c: Do not include py-ref.h.
2446         * python/py-cmd.c: Do not include py-ref.h.
2447         * python/py-continueevent.c: Do not include py-ref.h.
2448         * python/py-event.h: Do not include py-ref.h.
2449         * python/py-evtregistry.c: Do not include py-ref.h.
2450         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2451         * python/py-frame.c: Do not include py-ref.h.
2452         * python/py-framefilter.c: Do not include py-ref.h.
2453         * python/py-function.c: Do not include py-ref.h.
2454         * python/py-infevents.c: Do not include py-ref.h.
2455         * python/py-linetable.c: Do not include py-ref.h.
2456         * python/py-objfile.c: Do not include py-ref.h.
2457         * python/py-param.c: Do not include py-ref.h.
2458         * python/py-prettyprint.c: Do not include py-ref.h.
2459         * python/py-progspace.c: Do not include py-ref.h.
2460         * python/py-symbol.c: Do not include py-ref.h.
2461         * python/py-symtab.c: Do not include py-ref.h.
2462         * python/py-type.c: Do not include py-ref.h.
2463         * python/py-unwind.c: Do not include py-ref.h.
2464         * python/py-utils.c: Do not include py-ref.h.
2465         * python/py-value.c: Do not include py-ref.h.
2466         * python/py-varobj.c: Do not include py-ref.h.
2467         * python/py-xmethods.c: Do not include py-ref.h.
2468         * python/python.c: Do not include py-ref.h.
2469         * varobj.c: Do not include py-ref.h.
2470
2471 2019-01-22  Tom Tromey  <tom@tromey.com>
2472
2473         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2474         keyword for bcache.
2475
2476 2019-01-22  Tom Tromey  <tom@tromey.com>
2477
2478         * compile/compile-cplus-types.c: Remove a comment by #include.
2479
2480 2019-01-22  Tom Tromey  <tom@tromey.com>
2481
2482         * compile/gcc-c-plugin.h: Include compile-internal.h.
2483
2484 2019-01-22  Tom Tromey  <tom@tromey.com>
2485
2486         * stabsread.c (EXTERN): Do not define.
2487         (symnum, next_symbol_text_func, processing_gcc_compilation)
2488         (within_function, global_sym_chain, global_stabs)
2489         (previous_stab_code, this_object_header_files)
2490         (n_this_object_header_files)
2491         (n_allocated_this_object_header_files): Define.
2492         * stabsread.h (EXTERN): Never define.  Use "extern".
2493
2494 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2495
2496         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2497         history_value.
2498
2499 2019-01-21  Tom Tromey  <tom@tromey.com>
2500
2501         * ui-out.c: Fix includes.
2502         * tui/tui-source.c: Fix includes.
2503         * target.c: Fix includes.
2504         * remote.c: Fix includes.
2505         * regcache.c: Fix includes.
2506         * python/py-block.c: Fix includes.
2507         * printcmd.c: Fix includes.
2508         * or1k-tdep.c: Fix includes.
2509         * mi/mi-main.c: Fix includes.
2510         * m32r-tdep.c: Fix includes.
2511         * csky-tdep.c: Fix includes.
2512         * compile/compile-cplus-types.c: Fix includes.
2513         * cli/cli-interp.c: Fix includes.
2514
2515 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2516
2517         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2518         for padding.
2519
2520 2019-01-16  Tom Tromey  <tom@tromey.com>
2521
2522         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2523         earlier.
2524         (struct objfile) <msymbols_range>: Move from top level.
2525         <msymbols>: New method.
2526         (class objfile_msymbols): Remove.
2527         * symtab.c (default_collect_symbol_completion_matches_break_on):
2528         Update.
2529         * symmisc.c (dump_msymbols): Update.
2530         * stabsread.c (scan_file_globals): Update.
2531         * objc-lang.c (info_selectors_command, info_classes_command)
2532         (find_methods): Update.
2533         * minsyms.c (find_solib_trampoline_target): Update.
2534         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2535         * coffread.c (coff_symfile_read): Update.
2536         * ada-lang.c (ada_lookup_simple_minsym)
2537         (ada_collect_symbol_completion_matches): Update.
2538
2539 2019-01-16  Tom Tromey  <tom@tromey.com>
2540
2541         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2542         type.  Remove no-argument constructor.
2543         <iterator::operator++>: Simplify.
2544         <begin>: Update.
2545         <end>: Use minimal_symbol_count.
2546
2547 2019-01-16  Tom Tromey  <tom@tromey.com>
2548
2549         * objfiles.h (struct objfile) <psymtabs>: New method.
2550         (class objfile_psymtabs): Remove.
2551         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2552         typedef.
2553         <range>: New method.
2554         (require_partial_symbols): Change return type.
2555         * psymtab.c (require_partial_symbols)
2556         (psym_expand_symtabs_matching): Update.
2557         * mdebugread.c (parse_partial_symbols): Update.
2558         * dbxread.c (dbx_end_psymtab): Update.
2559
2560 2019-01-15  Tom Tromey  <tom@tromey.com>
2561
2562         * symtab.c (lookup_objfile_from_block)
2563         (lookup_symbol_in_objfile_symtabs)
2564         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2565         (find_line_symtab, info_sources_command)
2566         (default_collect_symbol_completion_matches_break_on)
2567         (make_source_files_completion_list): Update.
2568         * symmisc.c (print_objfile_statistics, dump_objfile)
2569         (maintenance_print_symbols, maintenance_info_symtabs)
2570         (maintenance_check_symtabs, maintenance_info_line_tables):
2571         Update.
2572         * source.c (select_source_symtab)
2573         (forget_cached_source_info_for_objfile): Update.
2574         * objfiles.h (class objfile_compunits): Remove.
2575         (struct objfile) <compunits_range>: New typedef.
2576         (compunits): New method.
2577         * objfiles.c (objfile_relocate1): Update.
2578         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2579         * maint.c (count_symtabs_and_blocks): Update.
2580         * linespec.c (iterate_over_all_matching_symtabs): Update.
2581         * cp-support.c (add_symbol_overload_list_qualified): Update.
2582         * coffread.c (coff_symtab_read): Update.
2583         * ada-lang.c (add_nonlocal_symbols)
2584         (ada_collect_symbol_completion_matches)
2585         (ada_add_global_exceptions): Update.
2586
2587 2019-01-15  Tom Tromey  <tom@tromey.com>
2588
2589         * progspace.h (program_space) <objfiles_safe_range>: New
2590         typedef.
2591         <objfiles_safe>: New method.
2592         * objfiles.h (class all_objfiles_safe): Remove.
2593         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2594         * jit.c (jit_inferior_exit_hook): Update.
2595
2596 2019-01-17  Tom Tromey  <tom@tromey.com>
2597
2598         * progspace.h (program_space) <objfiles_range>: New typedef.
2599         <objfiles>: New method.
2600         <objfiles_head>: Rename from objfiles.
2601         (object_files): Update.
2602         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2603         * guile/scm-pretty-print.c
2604         (ppscm_find_pretty_printer_from_objfiles): Update.
2605         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2606         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2607         Update.
2608         * python/py-progspace.c (pspy_get_objfiles): Update.
2609         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2610         Update.
2611         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2612         (objfpy_lookup_objfile_by_build_id): Update.
2613         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2614         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2615         Update.
2616         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2617         (expand_symtab_containing_pc, lookup_objfile_from_block)
2618         (lookup_static_symbol, basic_lookup_transparent_type)
2619         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2620         (find_line_symtab, info_sources_command)
2621         (default_collect_symbol_completion_matches_break_on)
2622         (make_source_files_completion_list, find_main_name): Update.
2623         * symmisc.c (print_symbol_bcache_statistics)
2624         (print_objfile_statistics, maintenance_print_symbols)
2625         (maintenance_print_msymbols, maintenance_print_objfiles)
2626         (maintenance_info_symtabs, maintenance_check_symtabs)
2627         (maintenance_expand_symtabs, maintenance_info_line_tables):
2628         Update.
2629         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2630         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2631         (map_overlay_command, unmap_overlay_command)
2632         (simple_overlay_update, expand_symtabs_matching)
2633         (map_symbol_filenames): Update.
2634         * symfile-debug.c (set_debug_symfile): Update.
2635         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2636         Update.
2637         * source.c (select_source_symtab, forget_cached_source_info):
2638         Update.
2639         * solib.c (solib_read_symbols): Update.
2640         * solib-spu.c (append_ocl_sos): Update.
2641         * psymtab.c (maintenance_print_psymbols)
2642         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2643         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2644         * printcmd.c (info_symbol_command): Update.
2645         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2646         Update.
2647         * objfiles.h (class all_objfiles): Remove.
2648         * objfiles.c (have_partial_symbols, have_full_symbols)
2649         (have_minimal_symbols, qsort_cmp, update_section_map)
2650         (shared_objfile_contains_address_p)
2651         (default_iterate_over_objfiles_in_search_order): Update.
2652         * objc-lang.c (info_selectors_command, info_classes_command)
2653         (find_methods): Update.
2654         * minsyms.c (find_solib_trampoline_target): Update.
2655         * maint.c (maintenance_info_sections)
2656         (maintenance_translate_address, count_symtabs_and_blocks):
2657         Update.
2658         * main.c (captured_main_1): Update.
2659         * linux-thread-db.c (try_thread_db_load_from_pdir)
2660         (has_libpthread): Update.
2661         * linespec.c (iterate_over_all_matching_symtabs)
2662         (search_minsyms_for_name): Update.
2663         * jit.c (jit_find_objf_with_entry_addr): Update.
2664         * hppa-tdep.c (find_unwind_entry)
2665         (hppa_lookup_stub_minimal_symbol): Update.
2666         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2667         Update.
2668         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2669         (elf_gnu_ifunc_resolve_by_got): Update.
2670         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2671         * dwarf-index-write.c (save_gdb_index_command): Update.
2672         * cp-support.c (add_symbol_overload_list_qualified): Update.
2673         * breakpoint.c (create_overlay_event_breakpoint)
2674         (create_longjmp_master_breakpoint)
2675         (create_std_terminate_master_breakpoint)
2676         (create_exception_master_breakpoint): Update.
2677         * blockframe.c (find_pc_partial_function): Update.
2678         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2679         (ada_collect_symbol_completion_matches)
2680         (ada_add_global_exceptions): Update.
2681
2682 2019-01-17  Tom Tromey  <tom@tromey.com>
2683
2684         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2685         declare VEC.
2686         (solib_target_parse_libraries): Change return type.
2687         (library_list_start_segment, library_list_start_section)
2688         (library_list_end_library, library_list_start_library); Update.
2689         (solib_target_free_library_list): Remove.
2690         (solib_target_parse_libraries): Remove cleanup.  Change return
2691         type.
2692         (solib_target_current_sos): Update.
2693
2694 2019-01-17  Tom Tromey  <tromey@bapiya>
2695
2696         * valprint.c: Replace "the the" with "the".
2697         * symtab.c: Replace "the the" with "the".
2698         * solib.c: Replace "the the" with "the".
2699         * solib-dsbt.c: Replace "the the" with "the".
2700         * linespec.c: Replace "the the" with "the".
2701         * dwarf2loc.h: Replace "the the" with "the".
2702         * amd64-windows-tdep.c: Replace "the the" with "the".
2703         * aarch64-tdep.c: Replace "the the" with "the".
2704
2705 2019-01-16  Keith Seitz  <keiths@redhat.com>
2706
2707         PR gdb/23773
2708         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2709         <builder>: Rename to ..
2710         <m_builder>: ... this and make private.
2711         (dwarf2_cu::get_builder): New method.  Change all users of
2712         `builder' to use this method.
2713         (dwarf2_start_symtab): Move to ...
2714         (dwarf2_cu::start_symtab): ... here.  Update all callers
2715         (setup_type_unit_groups): Move to ...
2716         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2717         callers.
2718         (dwarf2_cu::reset_builder): New method.
2719         (process_full_compunit, process_full_type_unit): Use
2720         dwarf2_cu::reset_builder.
2721         (follow_die_offset): Record the ancestor CU if it is different
2722         from the followed DIE's CU.
2723         (follow_die_sig_1): Likewise.
2724
2725 2019-01-15  Tom Tromey  <tom@tromey.com>
2726
2727         * remote.c (class remote_state) <buf>: Now a char_vector.
2728         <buf_size>: Remove.
2729         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2730         parameter.
2731         (remote_target::getpkt_or_notif_sane_1)
2732         (remote_target::getpkt_sane)
2733         (remote_target::getpkt_or_notif_sane): Likewise.
2734         (class remote_target) <putpkt>: New overload.
2735         (remote_target::read_frame): Change type of "buf_p".  Remove
2736         sizeof_p parameter.
2737         (packet_ok): New overload.
2738         (packet_check_result): New overload.
2739         Update all uses.
2740
2741 2019-01-14  Tom Tromey  <tom@tromey.com>
2742
2743         * remote-notif.c (handle_notification, remote_notif_ack)
2744         (remote_notif_parse): Make "buf" const.
2745         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2746         const.
2747         (remote_notif_parse, remote_notif_ack, handle_notification):
2748         Likewise.
2749         * remote.c (remote_notif_stop_parse): Make "buf" const.
2750         (remote_target::remote_parse_stop_reply): Make "buf" const.
2751         (remote_notif_stop_ack): Make "buf" const.
2752
2753 2019-01-14  Tom Tromey  <tom@tromey.com>
2754
2755         * remote.c (remote_console_output): Make parameter const.
2756
2757 2019-01-14  Tom Tromey  <tom@tromey.com>
2758
2759         * target-debug.h (target_debug_print_signals): Constify.
2760         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2761         * procfs.c (procfs_target::pass_signals): Update.
2762         * linux-nat.c (linux_nat_target::pass_signals): Update.
2763         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2764         * target-delegates.c: Rebuild.
2765         * remote.c (remote_target::program_signals): Update.
2766         (remote_target::pass_signals): Update.
2767         * target.c (target_pass_signals): Constify argument.
2768         (target_program_signals): Likewise.
2769         * target.h (struct target_ops) <pass_signals, program_signals>:
2770         Constify argument.
2771         (target_pass_signals, target_program_signals): Constify argument.
2772
2773 2019-01-14  Tom Tromey  <tom@tromey.com>
2774
2775         PR tui/28819:
2776         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2777
2778 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2779
2780         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2781         field.
2782         * rs6000-tdep.c: Include reggroups.h.
2783         (IS_V_ALIAS_PSEUDOREG): Define.
2784         (rs6000_register_name): Return names for the "vX" aliases.
2785         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2786         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2787         aliases.  Call default_register_reggroup_p for all other
2788         pseudo-registers.
2789         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2790         New functions.
2791         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2792         Handle "vX" aliases.
2793         (v_alias_pseudo_register_collect): New function.
2794         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2795         (rs6000_gdbarch_init): Initialize "vX" aliases as
2796         pseudo-registers.  Restore registration of
2797         rs6000_pseudo_register_reggroup_p with
2798         set_tdesc_pseudo_register_reggroup_p.
2799
2800 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2801
2802         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2803         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2804         set_gdbarch_num_pseudo_regs.
2805
2806 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2807
2808         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2809         Remove arg prefixname, add do_set and do_show.
2810         Add member functions set_list and show_list.
2811         * cli/cli-style.c (class cli_style_option): Update accordingly.
2812         (style_set_list): Move to file scope.
2813         (style_show_list): Likewise.
2814         (set_style): Call help_list.
2815         (show_style): Call cmd_show_list.
2816         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2817         Update to use the new macro.
2818
2819 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2820
2821         * ada-lang.c (_initialize_ada_language): Expand the help text
2822         for the "catch exception" command.
2823
2824 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2825
2826         * symtab.c (matching_obj_sections): Initialize obj,
2827         declare it closer to its usage.
2828
2829 2019-01-10  Tom Tromey  <tom@tromey.com>
2830
2831         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2832         (basic_inf_threads_range): Remove.
2833         (inf_threads_range, inf_non_exited_threads_range)
2834         (safe_inf_threads_range): Use next_adapter.
2835
2836 2019-01-10  Keith Seitz  <keiths@redhat.com>
2837
2838         PR gdb/23712
2839         PR symtab/23010
2840         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2841         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2842
2843 2019-01-10  Keith Seitz  <keiths@redhat.com>
2844
2845         PR gdb/23712
2846         PR symtab/23010
2847         * dictionary.c (pending_to_vector): Remove.
2848         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2849         Remove _1 suffix, replacing functions of the same name.  Update
2850         all callers.
2851         (dict_create_hashed, dict_create_hashed_expandable)
2852         (dict_create_linear, dict_create_linear_expandable, dict_free)
2853         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2854         Make functions static.
2855
2856 2019-01-10  Keith Seitz  <keiths@redhat.com>
2857
2858         PR gdb/23712
2859         PR symtab/23010
2860         * dictionary.h (struct dictionary): Replace declaration with
2861         multidictionary.
2862         (dict_create_hashed, dict_create_hashed_expandable)
2863         (dict_create_linear, dict_create_linear_expandable)
2864         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2865         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2866         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2867         taking multidictionary argument.
2868         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2869         * block.h (struct block) <dict>: Change to multidictionary
2870         and rename `multidict'.
2871         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2872         symmisc.c: Update all dictionary references to multidictionary.
2873
2874 2019-01-10  Keith Seitz  <keiths@redhat.com>
2875
2876         PR gdb/23712
2877         PR symtab/23010
2878         * dictionary.c: Include unordered_map.
2879         (pending_to_vector): New function.
2880         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2881         Rewrite the non-"_1" functions to take vector instead
2882         of linked list.
2883         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2884         "new" _1 versions of the same name.
2885         (multidictionary): Define.
2886         (std::hash<enum language): New definition.
2887         (collate_pending_symbols_by_language, mdict_create_hashed)
2888         (mdict_create_hashed_expandable, mdict_create_linear)
2889         (mdict_create_linear_expandable, mdict_free)
2890         (find_language_dictionary, create_new_language_dictionary)
2891         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2892         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2893         (mdict_size, mdict_empty): New functions.
2894         * dictionary.h (mdict_iterator): Define.
2895
2896 2019-01-10  Pedro Alves  <palves@redhat.com>
2897
2898         * breakpoint.c (read_uploaded_action)
2899         (create_tracepoint_from_upload): Adjust to use
2900         gdb::unique_xmalloc_ptr.
2901         * ctf.c (ctf_write_uploaded_tp):
2902         (SET_ARRAY_FIELD): Use emplace_back.
2903         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2904         * tracefile-tfile.c (tfile_write_uploaded_tp):
2905         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2906         gdb::unique_xmalloc_ptr.
2907         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2908         at_string, cond_string, cmd_strings>: Replace char pointers
2909         with gdb::unique_xmalloc_ptr.
2910
2911 2019-01-10  Pedro Alves  <palves@redhat.com>
2912
2913         * solib-target.c (library_list_start_library): Don't xstrdup name.
2914
2915 2019-01-10  Pedro Alves  <palves@redhat.com>
2916
2917         * mdebugread.c (parse_partial_symbols): Use
2918         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2919
2920 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2921
2922         * linux-fork.c (scoped_switch_fork_info)
2923         <~scoped_switch_fork_info>: Fix incorrect variable name.
2924
2925 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2926
2927         * linux-fork.c (scoped_switch_fork_info)
2928         <scoped_switch_fork_info>: Make explicit.
2929         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2930
2931 2019-01-10  Tom Tromey  <tom@tromey.com>
2932
2933         * objfiles.h (objfile::reset_psymtabs): Update.
2934         * objfiles.c (objfile::objfile): Update.
2935         * psymtab.h (psymtab_storage::obstack): Update.
2936         (psymtab_storage::m_obstack): Use gdb::optional.
2937         (class psymtab_storage): Update comment.  Remove objfile
2938         parameter.
2939         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2940
2941 2019-01-10  Tom Tromey  <tom@tromey.com>
2942
2943         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2944         <free_psymtabs>: Now private.
2945         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2946         (allocate_psymtab): Use new method.
2947
2948 2019-01-10  Tom Tromey  <tom@tromey.com>
2949
2950         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2951         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2952         * mdebugread.c (parse_partial_symbols): Use
2953         allocate_dependencies.
2954         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2955         allocate_dependencies.
2956         (process_psymtab_comp_unit_reader)
2957         (build_type_psymtab_dependencies): Likewise.
2958         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2959
2960 2019-01-10  Tom Tromey  <tom@tromey.com>
2961
2962         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2963         PSYMBOL_SET_LANGUAGE.
2964         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2965
2966 2019-01-10  Tom Tromey  <tom@tromey.com>
2967
2968         * psymtab.h (psymtab_storage::obstack): New method.
2969         <m_obstack>: Rename from obstack; now private.
2970         * psymtab.c (psymtab_storage): Update.
2971         * dwarf2read.c (create_addrmap_from_index)
2972         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2973         Update.
2974
2975 2019-01-10  Tom Tromey  <tom@tromey.com>
2976
2977         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2978         * objfiles.h (objfile::reset_psymtabs): New method.
2979
2980 2019-01-10  Tom Tromey  <tom@tromey.com>
2981
2982         * symmisc.c (print_symbol_bcache_statistics): Update.
2983         (print_objfile_statistics): Update.
2984         * symfile.c (reread_symbols): Update.
2985         * psymtab.h (class psymtab_storage): New.
2986         * psymtab.c (psymtab_storage): New constructor.
2987         (~psymtab_storage): New destructor.
2988         (require_partial_symbols): Update.
2989         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2990         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2991         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2992         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2993         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2994         (start_psymtab_common, end_psymtab_common)
2995         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2996         (allocate_psymtab): Update.
2997         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2998         Update.
2999         (dump_psymtab_addrmap, maintenance_print_psymbols)
3000         (maintenance_check_psymtabs): Update.
3001         (class objfile_psymtabs): Move to objfiles.h.
3002         * psympriv.h (discard_psymtab): Now inline.
3003         (psymtab_discarder::psymtab_discarder): Update.
3004         (psymtab_discarder::~psymtab_discarder): Update.
3005         (ALL_OBJFILE_PSYMTABS): Rewrite.
3006         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3007         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3008         Remove fields.
3009         <partial_symtabs>: New field.
3010         (class objfile_psymtabs): Move from psymtab.h.  Update.
3011         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3012         psymbol_cache.
3013         (objfile::~objfile): Don't destroy psymbol_cache.
3014         * mdebugread.c (parse_partial_symbols): Update.
3015         * dwarf2read.c (create_addrmap_from_index)
3016         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3017         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3018         (add_partial_subprogram, dwarf2_ranges_read): Update.
3019         * dwarf-index-write.c (write_address_map)
3020         (write_one_signatured_type, recursively_write_psymbols)
3021         (class debug_names, class debug_names, write_psymtabs_to_index):
3022         Update.
3023
3024 2019-01-10  Tom Tromey  <tom@tromey.com>
3025
3026         * symtab.h (SYMBOL_SET_NAMES): Update.
3027         (symbol_set_names): Update.
3028         (MSYMBOL_SET_NAMES): Update.
3029         * symtab.c (symbol_set_names): Change argument to be an
3030         objfile_per_bfd_storage.
3031         * psymtab.c (add_psymbol_to_bcache): Update.
3032         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3033
3034 2019-01-10  Tom Tromey  <tom@tromey.com>
3035
3036         * symtab.c (create_demangled_names_hash): Change argument to be an
3037         objfile_per_bfd_storage.
3038         (symbol_set_names): Update.
3039
3040 2019-01-10  Tom Tromey  <tom@tromey.com>
3041
3042         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3043         init_psymbol_list.
3044         * psymtab.c (init_psymbol_list): Do nothing if already called.
3045         * psympriv.h (init_psymbol_list): Add comment.
3046         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3047         init_psymbol_list.
3048         * dbxread.c (dbx_symfile_read): Unconditionally call
3049         init_psymbol_list.
3050
3051 2019-01-10  Tom Tromey  <tom@tromey.com>
3052
3053         * xcoffread.c (scan_xcoff_symtab): Update.
3054         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3055         "where".
3056         * mdebugread.c (parse_partial_symbols)
3057         (handle_psymbol_enumerators): Update.
3058         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3059         * dbxread.c (read_dbx_symtab): Update.
3060         * psympriv.h (psymbol_placement): New enum.
3061         (add_psymbol_to_list): Update.
3062
3063 2019-01-10  Tom Tromey  <tom@tromey.com>
3064
3065         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3066         static_psymbols parameters.
3067         (scan_xcoff_symtab): Update.
3068         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3069         static_psymbols parameters.
3070         * psympriv.h (start_psymtab_common): Update.
3071         * mdebugread.c (parse_partial_symbols): Update.
3072         * dwarf2read.c (create_partial_symtab): Update.
3073         * dbxread.c (read_dbx_symtab): Update.
3074         (start_psymtab): Remove global_psymbols and static_psymbols
3075         parameters.
3076
3077 2019-01-10  Tom Tromey  <tom@tromey.com>
3078
3079         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3080         * psymtab.c (allocate_psymtab): Add comment.
3081         * psympriv.h (allocate_psymtab): Add comment.
3082         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3083         initializations.
3084         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3085
3086 2019-01-10  Tom Tromey  <tom@tromey.com>
3087
3088         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3089         Don't declare.
3090         * mipsread.c: Include mdebugread.h.
3091         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3092         Declare.
3093         * elfread.c: Include mdebugread.h.
3094
3095 2019-01-09  Tom Tromey  <tom@tromey.com>
3096
3097         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3098         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3099         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3100         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3101         (psym_lookup_symbol, psym_find_last_source_symtab)
3102         (psym_forget_cached_source_info, psym_print_stats)
3103         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3104         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3105         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3106         (psym_find_compunit_symtab_by_address)
3107         (maintenance_print_psymbols, maintenance_info_psymtabs)
3108         (maintenance_check_psymtabs): Use ranged for.
3109         * psymtab.h (class objfile_psymtabs): New.
3110         (require_partial_symbols): Return objfile_psymtabs.
3111         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3112
3113 2019-01-09  Tom Tromey  <tom@tromey.com>
3114
3115         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3116         (find_pc_mapped_section, list_overlays_command)
3117         (map_overlay_command, unmap_overlay_command)
3118         (simple_overlay_update): Use all_objfiles.
3119         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3120         * printcmd.c (info_symbol_command): Use all_objfiles.
3121         * objfiles.h (ALL_OBJSECTIONS): Remove.
3122         * maint.c (maintenance_translate_address): Use all_objfiles.
3123         * gcore.c (gcore_create_callback): Use all_objfiles.
3124         (objfile_find_memory_regions): Likewise.
3125
3126 2019-01-09  Tom Tromey  <tom@tromey.com>
3127
3128         * symtab.c (find_line_symtab, info_sources_command)
3129         (make_source_files_completion_list): Use objfile_compunits.
3130         * source.c (select_source_symtab): Use objfile_compunits.
3131         * objfiles.h (struct objfile): Update comment.
3132         (ALL_OBJFILES): Remove.
3133         (ALL_FILETABS): Remove.
3134         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3135         objfile_compunits.
3136
3137 2019-01-09  Tom Tromey  <tom@tromey.com>
3138
3139         * symmisc.c (print_objfile_statistics, dump_objfile)
3140         (maintenance_print_symbols): Use compunit_filetabs.
3141         * source.c (forget_cached_source_info_for_objfile): Use
3142         compunit_filetabs.
3143         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3144         (ALL_FILETABS): Use compunit_filetabs.
3145         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3146         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3147
3148 2019-01-09  Tom Tromey  <tom@tromey.com>
3149
3150         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3151         (compunit_filetabs): New.
3152         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3153         compunit_filetabs.
3154         (info_sources_command, make_source_files_completion_list): Remove
3155         declaration.
3156         * symmisc.c (print_objfile_statistics, dump_objfile)
3157         (maintenance_print_symbols): Remove declaration.
3158         (maintenance_info_symtabs): Use compunit_filetabs.
3159         (maintenance_info_line_tables): Likewise.
3160         * source.c (select_source_symtab): Change local variable name.
3161         (forget_cached_source_info_for_objfile): Remove declaration.
3162         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3163         * objfiles.c (objfile_relocate1): Remove declaration.
3164         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3165         declaration.
3166         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3167         * coffread.c (coff_symtab_read): Remove declaration.
3168         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3169         compunit_filetabs.
3170
3171 2019-01-09  Tom Tromey  <tom@tromey.com>
3172
3173         * symtab.c (lookup_objfile_from_block)
3174         (find_pc_sect_compunit_symtab, search_symbols)
3175         (default_collect_symbol_completion_matches_break_on): Use
3176         objfile_compunits.
3177         * objfiles.h (ALL_COMPUNITS): Remove.
3178         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3179         * cp-support.c (add_symbol_overload_list_qualified): Use
3180         objfile_compunits.
3181         * ada-lang.c (ada_collect_symbol_completion_matches)
3182         (ada_add_global_exceptions): Use objfile_compunits.
3183
3184 2019-01-09  Tom Tromey  <tom@tromey.com>
3185
3186         * source.c (select_source_symtab)
3187         (forget_cached_source_info_for_objfile): Remove declaration.
3188         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3189         declaration.
3190         * maint.c (count_symtabs_and_blocks): Remove declaration.
3191         * cp-support.c (add_symbol_overload_list_qualified): Remove
3192         declaration.
3193         * coffread.c (coff_symtab_read): Remove declaration.
3194         * symtab.c (lookup_symbol_in_objfile_symtabs)
3195         (basic_lookup_transparent_type_1): Use objfile_compunits.
3196         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3197         (info_sources_command, search_symbols)
3198         (default_collect_symbol_completion_matches_break_on)
3199         (make_source_files_completion_list): Remove declaration.
3200         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3201         (ada_collect_symbol_completion_matches)
3202         (ada_add_global_exceptions): Remove declaration.
3203         * linespec.c (iterate_over_all_matching_symtabs): Use
3204         objfile_compunits.
3205         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3206         (class objfile_compunits): New.
3207         (ALL_COMPUNITS): Use objfile_compunits.
3208         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3209         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3210         objfile_compunits.
3211         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3212
3213 2019-01-09  Tom Tromey  <tom@tromey.com>
3214
3215         * symtab.c (search_symbols)
3216         (default_collect_symbol_completion_matches_break_on): Use
3217         objfile_msymbols.
3218         * ada-lang.c (ada_lookup_simple_minsym)
3219         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3220         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3221         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3222         objfile_msymbols.
3223         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3224         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3225         * objc-lang.c (find_methods): Use objfile_msymbols.
3226         (info_selectors_command, info_classes_command): Likewise.
3227         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3228         * objfiles.h (class objfile_msymbols): New.
3229         (ALL_OBJFILE_MSYMBOLS): Remove.
3230         (ALL_MSYMBOLS): Remove.
3231
3232 2019-01-09  Tom Tromey  <tom@tromey.com>
3233
3234         * common/next-iterator.h (next_adapter): Add Iterator template
3235         parameter.
3236         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3237         (class all_objfiles_safe): New.
3238         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3239         * objfiles.c (put_objfile_before): Update comment.
3240         (add_separate_debug_objfile): Likewise.
3241         (free_all_objfiles): Use all_objfiles_safe.
3242         (objfile_purge_solibs): Likewise.
3243
3244 2019-01-09  Tom Tromey  <tom@tromey.com>
3245
3246         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3247         (expand_symtab_containing_pc, lookup_static_symbol)
3248         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3249         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3250         all_objfiles.
3251         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3252         * breakpoint.c (create_overlay_event_breakpoint)
3253         (create_longjmp_master_breakpoint)
3254         (create_std_terminate_master_breakpoint)
3255         (create_exception_master_breakpoint): Use all_objfiles.
3256         * linux-thread-db.c (try_thread_db_load_from_pdir)
3257         (has_libpthread): Use all_objfiles.
3258         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3259         * linespec.c (iterate_over_all_matching_symtabs)
3260         (search_minsyms_for_name): Use all_objfiles.
3261         * maint.c (maintenance_info_sections): Use all_objfiles.
3262         * main.c (captured_main_1): Use all_objfiles.
3263         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3264         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3265         * guile/scm-pretty-print.c
3266         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3267         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3268         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3269         (maintenance_print_msymbols): Use all_objfiles.
3270         * source.c (select_source_symtab): Use all_objfiles.
3271         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3272         * symfile.c (remove_symbol_file_command)
3273         (expand_symtabs_matching, map_symbol_filenames): Use
3274         all_objfiles.
3275         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3276         all_objfiles.
3277         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3278         * objc-lang.c (find_methods): Use all_objfiles.
3279         * objfiles.c (have_partial_symbols, have_full_symbols)
3280         (have_minimal_symbols, qsort_cmp)
3281         (default_iterate_over_objfiles_in_search_order): Use
3282         all_objfiles.
3283         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3284         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3285         (maintenance_check_psymtabs): Use all_objfiles.
3286         (ALL_PSYMTABS): Remove.
3287         * compile/compile-object-run.c (do_module_cleanup): Use
3288         all_objfiles.
3289         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3290         * cp-support.c (add_symbol_overload_list_qualified): Use
3291         all_objfiles.
3292         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3293         Use all_objfiles.
3294         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3295         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3296         all_objfiles.
3297         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3298         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3299         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3300         Uses all_objfiles.
3301         * solib.c (solib_read_symbols): Use all_objfiles
3302
3303 2019-01-09  Tom Tromey  <tom@tromey.com>
3304
3305         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3306         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3307         all_objfiles.
3308         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3309         * symmisc.c (print_symbol_bcache_statistics)
3310         (print_objfile_statistics, maintenance_print_objfiles)
3311         (maintenance_info_symtabs, maintenance_check_symtabs)
3312         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3313         all_objfiles.
3314         * source.c (forget_cached_source_info): Use all_objfiles.
3315         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3316         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3317         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3318         * objfiles.c (update_section_map): Use all_objfiles.
3319         (shared_objfile_contains_address_p): Likewise.
3320         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3321         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3322
3323 2019-01-09  Tom Tromey  <tom@tromey.com>
3324
3325         * common/next-iterator.h: New file.
3326         * objfiles.h (class all_objfiles): New.
3327         (struct objfile_iterator): New.
3328
3329 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3330
3331         * NEWS: Move the description of the changed "frame", "select-frame",
3332          and "info frame" commands to the Changed commands section.
3333
3334 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3335
3336         * gdbtypes.c (check_stub_method_group): Remove handling of old
3337         mangling schemes.
3338         * linespec.c (find_methods): Likewise.
3339         * stabsread.c (read_member_functions): Likewise.
3340         * valops.c (search_struct_method): Likewise.
3341         (value_struct_elt_for_reference): Likewise.
3342         * NEWS: Mention this change.
3343
3344 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3345
3346         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3347         print_source_lines.
3348         * source.c (print_source_lines_base): Update line number check.
3349         (print_source_lines): New function.
3350         (source_lines_range::source_lines_range): New function.
3351         * source.h (class source_lines_range): New class.
3352         (print_source_lines): New declaration.
3353
3354 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3355
3356         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3357
3358 2019-01-08  Tom Tromey  <tom@tromey.com>
3359             Simon Marchi  <simon.marchi@ericsson.com>
3360
3361         PR gdb/24060
3362         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3363         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3364         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3365         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3366         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3367         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3368
3369 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3370
3371         * source.c (select_source_symtab): Move header comment to
3372         declaration in source.h.
3373         (forget_cached_source_info_for_objfile): Likewise.
3374         (forget_cached_source_info): Likewise.
3375         (identify_source_line): Likewise.
3376         * source.h (identify_source_line): Move declaration from symtab.h
3377         and add comment from source.c
3378         (print_source_lines): Likewise.
3379         (forget_cached_source_info_for_objfile): Likewise.
3380         (forget_cached_source_info): Likewise.
3381         (select_source_symtab): Likewise.
3382         (enum print_source_lines_flag): Move definition from symtab.h.
3383         * symtab.h (identify_source_line): Move declaration to source.h.
3384         (print_source_lines): Likewise.
3385         (forget_cached_source_info_for_objfile): Likewise.
3386         (forget_cached_source_info): Likewise.
3387         (select_source_symtab): Likewise.
3388         (enum print_source_lines_flag): Move definition to source.h.
3389         * tui/tui-hooks.c: Add 'source.h' include.
3390
3391 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3392
3393         * source.c (print_source_lines_base): Handle requests to print
3394         reverse line number sequences, and guard against empty lines
3395         string.
3396
3397 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3398
3399         * source.c (print_source_lines_base): Fix skip of '\r' if next
3400         character is '\n'.
3401
3402 2019-01-06  Tom Tromey  <tom@tromey.com>
3403
3404         * c-exp.y (struct c_parse_state) <macro_original_text,
3405         expansion_obstack>: New member.
3406         (macro_original_text, expansion_obstack): Remove globals.
3407         (scan_macro_expansion, scanning_macro_expansion)
3408         (finished_macro_expansion): Update.
3409         (scan_macro_cleanup): Remove.
3410         (yylex, c_parse): Update.
3411
3412 2019-01-06  Tom Tromey  <tom@tromey.com>
3413
3414         * c-exp.y (struct c_parse_state) <strings>: New member.
3415         (operator_stoken): Update.
3416
3417 2019-01-06  Tom Tromey  <tom@tromey.com>
3418
3419         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3420         (union type_stack_elt) <typelist_val>: Now a pointer to
3421         std::vector.
3422         (type_stack_cleanup): Don't declare.
3423         (push_typelist): Update.
3424         * parse.c (pop_typelist): Return a std::vector.
3425         (push_typelist): Take a std::vector.
3426         (follow_types): Update.  Do not free args.
3427         (type_stack_cleanup): Remove.
3428         * c-exp.y (struct c_parse_state): New.
3429         (cpstate): New global.
3430         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3431         (nonempty_typelist): Update.
3432         (func_mod): Create a new vector.
3433         (c_parse): Create a c_parse_state.
3434         (check_parameter_typelist): Do not delete params.
3435         (function_method): Update.  Do not delete type_list.
3436
3437 2019-01-06  Tom Tromey  <tom@tromey.com>
3438
3439         PR gdb/28155:
3440         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3441         check_typedef.
3442         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3443         (print_return_value): Likewise.
3444
3445 2019-01-05  Tom Tromey  <tom@tromey.com>
3446
3447         * contrib/cleanup_check.py: Remove.
3448         * contrib/gcc-with-excheck: Remove.
3449         * contrib/exsummary.py: Remove.
3450         * contrib/excheck.py: Remove.
3451
3452 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3453
3454         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3455         NULL. Initialize tpprev to NULL instead of assigning it
3456         to NULL on the next statement.
3457         * windows-nat.c (windows_delete_thread): Remove check for
3458         main_thread_id before printing thread exit notifications.
3459         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3460         Remove thread ID check against main_thread_id.
3461         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3462         windows_delete_thread.
3463         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3464
3465 2019-01-04  Tom Tromey  <tom@tromey.com>
3466
3467         * compile/compile.c (_initialize_compile): Use upper case for
3468         metasyntactic variables.
3469         * symmisc.c (_initialize_symmisc): Use upper case for
3470         metasyntactic variables.
3471         * psymtab.c (_initialize_psymtab): Use upper case for
3472         metasyntactic variables.
3473         * demangle.c (demangle_command): Use upper case for metasyntactic
3474         variables.
3475         (_initialize_demangler): Likewise.
3476         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3477         variables.
3478
3479 2019-01-03  Tom Tromey  <tom@tromey.com>
3480
3481         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3482
3483 2019-01-03  Tom Tromey  <tom@tromey.com>
3484
3485         * python/py-symtab.c (salpy_str): Update.
3486         (struct salpy_sal_object) <symtab>: Now a PyObject.
3487         (salpy_dealloc): Update.
3488         (del_objfile_sal): Use gdbpy_ref.
3489
3490 2019-01-03  Tom Tromey  <tom@tromey.com>
3491
3492         * python/py-type.c (convert_field): Use new_reference.  Return
3493         gdbpy_ref.
3494         (make_fielditem): Return gdbpy_ref.
3495         (typy_fields): Update.
3496         (typy_getitem): Update.
3497         (field_name): Return gdbpy_ref.  Use new_reference.
3498         (typy_iterator_iternext): Update.
3499
3500 2019-01-03  Tom Tromey  <tom@tromey.com>
3501
3502         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3503
3504 2019-01-03  Tom Tromey  <tom@tromey.com>
3505
3506         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3507         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3508         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3509         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3510         (pspy_set_type_printers): Likewise.
3511         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3512         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3513         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3514         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3515         (objfpy_set_type_printers): Likewise.
3516
3517 2019-01-03  Tom Tromey  <tom@tromey.com>
3518
3519         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3520         (gdbpy_print_stack): Use gdbpy_err_fetch.
3521         * python/python-internal.h (class gdbpy_err_fetch): New class.
3522         (class gdbpy_enter) <m_error_type, m_error_value,
3523         m_error_traceback>: Remove.
3524         <m_error>: New member.
3525         (gdbpy_exception_to_string): Don't declare.
3526         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3527         * python/py-value.c (convert_value_from_python): Use
3528         gdbpy_err_fetch.
3529         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3530         gdbpy_exception_to_string.
3531         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3532         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3533         gdbpy_err_fetch.
3534
3535 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3536
3537         * linux-nat.c (delete_lwp_cleanup): Delete.
3538         (struct lwp_deleter): New struct.
3539         (lwp_info_up): New typedef.
3540         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3541         lwp_info_up.
3542
3543 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3544
3545         * linux-fork.c (class scoped_switch_fork_info): New class.
3546         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3547
3548 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3549
3550         * valops.c (find_overload_match): Remove use of null_cleanup, and
3551         calls to do_cleanups.
3552
3553 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3554
3555         * compile/compile-cplus-types.c
3556         (compile_cplus_instance::decl_name): Handle changes to
3557         cp_func_name.
3558         * cp-support.c (cp_func_name): Update header comment, update
3559         return type.
3560         * cp-support.h (cp_func_name): Update return type in declaration.
3561         * valops.c (find_overload_match): Move temp_func local to top
3562         level of function and change its type.  Use temp_func to hold and
3563         delete temporary string obtained from cp_func_name.
3564
3565 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3566
3567         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3568         gdb::char_vector, remove cleanup, and update uses of `msg`.
3569
3570 2019-01-03  Jim Wilson  <jimw@sifive.com>
3571
3572         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3573
3574 2019-01-02  Tom Tromey  <tom@tromey.com>
3575
3576         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3577         (tdesc_parse_xml): Remove cleanups.
3578         * target-descriptions.h (make_cleanup_free_target_description):
3579         Don't declare.
3580         (target_desc_deleter): New struct.
3581         (target_desc_up): New typedef.
3582         * target-descriptions.c (target_desc_deleter::operator()): Rename
3583         from free_target_description.
3584         (make_cleanup_free_target_description): Remove.
3585
3586 2019-01-02  Tom Tromey  <tom@tromey.com>
3587
3588         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3589         constructor, destructor.
3590         (linespec_parser): Remove typedef.
3591         (~linespec_parser): Rename from linespec_parser_delete.
3592         (linespec_lex_to_end, linespec_complete_label)
3593         (linespec_complete): Update.
3594         (decode_line_full): Remove cleanups.
3595         (decode_line_1): Update.
3596
3597 2019-01-02  Tom Tromey  <tom@tromey.com>
3598
3599         * python/python-internal.h (inferior_to_inferior_object): Change
3600         return type.
3601         * python/py-exitedevent.c (create_exited_event_object): Update.
3602         * python/py-inferior.c (inferior_to_inferior_object): Return
3603         gdbpy_ref.
3604         (python_new_inferior, python_inferior_deleted)
3605         (thread_to_thread_object, delete_thread_object)
3606         (build_inferior_list, gdbpy_selected_inferior): Update.
3607         * python/py-infthread.c (create_thread_object): Update.  Also fail
3608         if inferior_to_inferior_object fails.
3609
3610 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3611
3612         * inferior.h (class inferior) <displaced_step_state>: New field.
3613         * infrun.h (struct displaced_step_state): Move here from
3614         infrun.c.  Initialize fields, add constructor.
3615         <inf>: Remove field.
3616         <reset>: New method.
3617         * infrun.c (struct displaced_step_inferior_state): Move to
3618         infrun.h.
3619         (displaced_step_inferior_states): Remove.
3620         (get_displaced_stepping_state): Adust.
3621         (displaced_step_in_progress_any_inferior): Adjust.
3622         (displaced_step_in_progress_thread): Adjust.
3623         (displaced_step_in_progress): Adjust.
3624         (add_displaced_stepping_state): Remove.
3625         (get_displaced_step_closure_by_addr): Adjust.
3626         (remove_displaced_stepping_state): Remove.
3627         (infrun_inferior_exit): Call displaced_step_state.reset.
3628         (use_displaced_stepping): Don't check for NULL.
3629         (displaced_step_prepare_throw): Call
3630         get_displaced_stepping_state.
3631         (displaced_step_fixup): Don't check for NULL.
3632         (prepare_for_detach): Don't check for NULL.
3633
3634 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3635
3636         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3637          in case of call that did not complete.
3638
3639 2019-01-02  Andrey Utkin  <autkin@undo.io>
3640
3641         * symfile.c (find_separate_debug_file): Fix search of debug files for
3642         remote debuggee.
3643
3644 2019-01-02  Tom Tromey  <tom@tromey.com>
3645
3646         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3647         indentation.
3648         * python/py-frame.c (frapy_older): Remove cast.
3649         (frapy_newer): Likewise.
3650         * python/py-breakpoint.c (local_setattro): Remove cast.
3651         * python/py-arch.c (archpy_name): Remove local variable.
3652         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3653
3654 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3655
3656         * unittests/basic_string_view/element_access/char/empty.cc:
3657         Fix year range in copyright header.
3658
3659 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3660
3661         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3662         Delete.
3663         <operator==>: Update with for removed field.
3664         <hash>: Likewise.
3665         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3666         <isa_features>: ...this.
3667         <abi_features>: New field.
3668         (riscv_isa_flen): Update comment.
3669         (riscv_abi_xlen): New declaration.
3670         (riscv_abi_flen): New declaration.
3671         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3672         isa_features.
3673         (riscv_abi_xlen): New function.
3674         (riscv_isa_flen): Update to get answer from isa_features.
3675         (riscv_abi_flen): New function.
3676         (riscv_has_fp_abi): Update to get answer from abi_features.
3677         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3678         xlen and flen.
3679         (riscv_call_info) <xlen, flen>: Update comment.
3680         (riscv_call_arg_struct): Remove invalid assertions
3681         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3682         is removed.
3683         (riscv_gdbarch_init): Gather isa features and abi features
3684         separately, ensure both match on the gdbarch when reusing an old
3685         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3686         a target with 64-bit float hardware.
3687
3688 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3689
3690         * source.c (search_command_helper): Stop reverse search
3691         when line 1 has been searched.
3692
3693 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3694
3695         * record-full.c (record_full_base_target::close): Rewrite
3696         record_full_core_buf_list free logic.
3697
3698 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3699
3700         * break-catch-syscall.c (print_one_catch_syscall): xfree
3701         the last text.
3702
3703 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3704
3705         * top.c (print_gdb_version): Update Copyright year in version
3706         message.
3707
3708 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3709
3710         Update copyright year range in all GDB files.
3711
3712 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3713
3714         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3715
3716 For older changes see ChangeLog-2018.
3717 \f
3718 Local Variables:
3719 mode: change-log
3720 left-margin: 8
3721 fill-column: 74
3722 version-control: never
3723 coding: utf-8
3724 End:
3725