Merge handle_inferior_event and handle_inferior_event_1

[thirdparty/binutils-gdb.git] / gdb / ChangeLog

2019-03-20  Tom Tromey  <tromey@adacore.com>

        * infrun.c (handle_inferior_event): Rename from
        handle_inferior_event_1.  Create a scoped_value_mark.
        (handle_inferior_event): Remove.

2019-03-19  Tom Tromey  <tromey@adacore.com>

        * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
        * infrun.h (print_stop_event): Add "displays" parameter.
        * infrun.c (print_stop_event): Add "displays" parameter.

2019-03-19  Pedro Alves  <palves@redhat.com>

        * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
        (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
        to -1.  Fix TABs vs spaces.
        (tui_ui_out::tui_ui_out): Don't initialize fields here.
        * tui/tui-out.h (tui_ui_out) Add intro comments.
        <m_line, m_start_of_line>: In-class initialize, and add describing
        comment.

2019-03-18  Alan Hayward  <alan.hayward@arm.com>

        * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
        variable names.
        (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.

2019-03-18  Pedro Alves  <palves@redhat.com>
            Eli Zaretskii <eliz@gnu.org>

        * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
        m_line and m_start_of_line.

2019-03-18  Eli Zaretskii  <eliz@gnu.org>

        * tui/tui-io.c (gdb_wgetch): Don't echo CR.
        (tui_getc): When gdb_wgetch returns a CR, behave the same as when
        it returns a newline.  This fixes a regression in TU mode, whereby
        the next line is output on the same screen line as the user input.

2019-03-18  Tom Tromey  <tromey@adacore.com>

        * minsyms.c (minimal_symbol_reader::install): Remove call to
        obstack_blank.

2019-03-18  Pedro Alves  <palves@redhat.com>

        * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
        New globals.
        (apply_style): New, factored out from ...
        (apply_ansi_escape): ... this.  Handle reverse video mode.
        (tui_set_reverse_mode): New function.
        * tui/tui-io.h (tui_set_reverse_mode): New declaration.
        * tui/tui-winsource.c (tui_show_source_line): Use
        tui_set_reverse_mode instead of setting A_STANDOUT.
        * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
        New setter methods.

2019-03-18  Hannes Domani  <ssbssa@yahoo.de>

        * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
        Handle tabs.

2019-03-18  Tom Tromey  <tromey@adacore.com>

        * ada-lang.c (empty_array): Add "high" parameter.
        (ada_evaluate_subexp): Update.

2019-03-17  Sergei Trofimovich <siarheit@google.com>

        * unittests/string_view-selftests.c: Define
        _initialize_string_view_selftests unconditionally.

2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>

        PR gdb/24350
        * windows-nat.c (windows_make_so): Remove unused text_vma variable.

2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>

        PR gdb/24351
        * windows-nat.c (display_selector): Fix format specifiers.

2019-03-17  Eli Zaretskii  <eliz@gnu.org>

        * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
        tui_refill_source_window instead of tui_refresh_win, to update the
        current execution line.  This fixes redisplay of the current line
        when stepping through the code with "next" or "step".

2019-03-16  Eli Zaretskii  <eliz@gnu.org>

        * source-cache.c (source_cache::get_source_lines): Call
        find_source_lines to initialize s->nlines.  This fixes vertical
        scrolling of TUI source window when the DOWN arrow is pressed.

2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * auto-load.c (_initialize_auto_load): Fix 'This options has'.
        linux-thread-db.c (_initialize_thread_db): Likewise.

2019-03-16  Eli Zaretskii  <eliz@gnu.org>

        * tui/tui-winsource.c (tui_show_source_line): Revert "Use
        wclrtoeol in tui_show_source_line".  This reverts changes made in
        commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.

2019-03-15  Tom Tromey  <tom@tromey.com>

        * symtab.h (struct minimal_symbol): Derive from
        general_symbol_info.
        (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
        (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
        (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
        (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
        (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
        (MSYMBOL_SEARCH_NAME): Update.
        (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
        * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
        * minsyms.c (minimal_symbol_reader::record_full): Update.

2019-03-15  Tom Tromey  <tom@tromey.com>

        * minsyms.c (minimal_symbol_reader::install): Use memcpy.

2019-03-15  Tom Tromey  <tom@tromey.com>

        * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
        unique_xmalloc_ptr.
        (objfile::msymbols_range::begin, objfile::msymbols_range::end):
        Update.
        * minsyms.c (lookup_minimal_symbol_by_pc_section)
        (build_minimal_symbol_hash_tables)
        (minimal_symbol_reader::install): Update.

2019-03-15  Tom Tromey  <tom@tromey.com>

        * symtab.c (create_demangled_names_hash): Update.
        (symbol_set_names): Update.
        * objfiles.h (struct objfile_per_bfd_storage)
        <demangled_names_hash>: Now an htab_up.
        * objfiles.c (objfile_per_bfd_storage): Simplify.

2019-03-15  Tom Tromey  <tom@tromey.com>

        * objfiles.h (struct objfile_per_bfd_storage): Declare
        destructor.
        * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
        New.
        (get_objfile_bfd_data): Use new.  Don't initialize
        language_of_main.
        (free_objfile_per_bfd_storage): Remove.
        (objfile_bfd_data_free, objfile::~objfile): Use delete.

2019-03-15  Tom Tromey  <tom@tromey.com>

        * symfile.c (reread_symbols): Update.
        * objfiles.c (objfile::objfile): Update.
        * minsyms.h (terminate_minimal_symbol_table): Don't declare.
        * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
        comment.
        (minimal_symbol_reader::install): Update.
        (terminate_minimal_symbol_table): Remove.
        * jit.c (jit_object_close_impl): Update.

2019-03-15  Tom Tromey  <tom@tromey.com>

        * minsyms.c (minimal_symbol_reader::record_full): Remove some
        initializations.

2019-03-15  Tom Tromey  <tom@tromey.com>

        * objfiles.h (struct objfile_per_bfd_storage)
        <demangled_hash_languages>: Now a bitset.
        * minsyms.c (add_minsym_to_demangled_hash_table): Update.
        (lookup_minimal_symbol): Update.

2019-03-15  Tom Tromey  <tom@tromey.com>

        * minsyms.h (class minimal_symbol_reader) <record_with_info>:
        Don't return the symbol.
        * coffread.c (record_minimal_symbol): Use record_full.

2019-03-14  Eli Zaretskii  <eliz@gnu.org>

        The MS-Windows port of ncurses fails to switch to a color pair if
        one or both of the colors are the implicit default colors.  This
        change records the default colors when TUI is initialized, and
        then specifies them explicitly when a color pair uses the default
        colors.  This allows color styling in TUI mode on MS-Windows.

        * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
        ncurses_norm_attr.
        (tui_initialize_io) [__MINGW32__]: Record the default terminal
        colors in ncurses_norm_attr.
        (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
        "none", replace it with the default color recorded in
        ncurses_norm_attr.

2019-03-14  Tom Tromey  <tromey@adacore.com>

        * source-cache.h (class source_cache) <get_source_lines>: Return
        std::string.
        * source-cache.c (source_cache::extract_lines): Handle case where
        first_pos==npos.  Return std::string.
        (source_cache::get_source_lines): Update.

2019-03-14  Tom Tromey  <tromey@adacore.com>

        * NEWS: Add item for "style sources" commands.
        * source-cache.c (source_cache::get_source_lines): Check
        source_styling.
        * cli/cli-style.c (source_styling): New global.
        (_initialize_cli_style): Add "style sources" commands.
        (show_style_sources): New function.
        * cli/cli-style.h (source_styling): Declare.

2019-03-14  Pedro Alves  <palves@redhat.com>
            Tom Tromey  <tromey@adacore.com>

        * tui/tui-winsource.h (tui_refill_source_window): Declare.
        * tui/tui-winsource.c (tui_refill_source_window): New function,
        from...
        (tui_horizontal_source_scroll): ... here.  Move some logic.
        * cli/cli-style.c (set_style_enabled): Notify new observable.
        * tui/tui-hooks.c (tui_redisplay_source): New function.
        (tui_attach_detach_observers): Attach or detach
        tui_redisplay_source.
        * observable.h (source_styling_changed): New observable.
        * observable.c: Define source_styling_changed observable.

2019-03-13  Tom Tromey  <tromey@adacore.com>

        * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
        (i386_gnu_nat_target::store_registers): Update.
        * target-debug.h (target_debug_print_std_string): New macro.
        * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
        * windows-tdep.c (display_one_tib): Update.
        * tui/tui-stack.c (tui_make_status_line): Update.
        * top.c (print_inferior_quit_action): Update.
        * thread.c (thr_try_catch_cmd): Update.
        (add_thread_with_info): Update.
        (thread_target_id_str): Update.
        (thr_try_catch_cmd): Update.
        (thread_command): Update.
        (thread_find_command): Update.
        * record-btrace.c (record_btrace_target::info_record)
        (record_btrace_resume_thread, record_btrace_target::resume)
        (record_btrace_cancel_resume, record_btrace_step_thread)
        (record_btrace_target::wait, record_btrace_target::wait)
        (record_btrace_target::wait, record_btrace_target::stop): Update.
        * progspace.c (print_program_space): Update.
        * process-stratum-target.c
        (process_stratum_target::thread_address_space): Update.
        * linux-fork.c (linux_fork_mourn_inferior)
        (detach_checkpoint_command, info_checkpoints_command)
        (linux_fork_context): Update.
        (linux_fork_detach): Update.
        (class scoped_switch_fork_info): Update.
        (delete_checkpoint_command): Update.
        * infrun.c (follow_fork_inferior): Update.
        (follow_fork_inferior): Update.
        (proceed_after_vfork_done): Update.
        (handle_vfork_child_exec_or_exit): Update.
        (follow_exec): Update.
        (displaced_step_prepare_throw): Update.
        (displaced_step_restore): Update.
        (start_step_over): Update.
        (resume_1): Update.
        (clear_proceed_status_thread): Update.
        (proceed): Update.
        (print_target_wait_results): Update.
        (do_target_wait): Update.
        (context_switch): Update.
        (stop_all_threads): Update.
        (restart_threads): Update.
        (finish_step_over): Update.
        (handle_signal_stop): Update.
        (switch_back_to_stepped_thread): Update.
        (keep_going_pass_signal): Update.
        (print_exited_reason): Update.
        (normal_stop): Update.
        * inferior.c (inferior_pid_to_str): Change return type.
        (print_selected_inferior): Update.
        (add_inferior): Update.
        (detach_inferior): Update.
        * dummy-frame.c (fprint_dummy_frames): Update.
        * dcache.c (dcache_info_1): Update.
        * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
        (btrace_fetch, btrace_clear): Update.
        * linux-tdep.c (linux_core_pid_to_str): Change return type.
        * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
        type.
        * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
        * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
        * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
        * gdbarch.c, gdbarch.h: Rebuild.
        * gdbarch.sh (core_pid_to_str): Change return type.
        * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
        return type.
        (windows_nat_target::pid_to_str): Change return type.
        (windows_delete_thread): Update.
        (windows_nat_target::attach): Update.
        (windows_nat_target::files_info): Update.
        * target-delegates.c: Rebuild.
        * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
        return type.
        (sol_thread_target::pid_to_str): Change return type.
        * remote.c (class remote_target) <pid_to_str>: Change return
        type.
        (remote_target::pid_to_str): Change return type.
        (extended_remote_target::attach, remote_target::remote_stop_ns)
        (remote_target::remote_notif_remove_queued_reply)
        (remote_target::push_stop_reply, remote_target::disable_btrace):
        Update.
        (extended_remote_target::attach): Update.
        * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
        type.
        (gdbsim_target::pid_to_str): Change return type.
        * ravenscar-thread.c (struct ravenscar_thread_target)
        <pid_to_str>: Change return type.
        (ravenscar_thread_target::pid_to_str): Change return type.
        * procfs.c (class procfs_target) <pid_to_str>: Change return
        type.
        (procfs_target::pid_to_str): Change return type.
        (procfs_target::attach): Update.
        (procfs_target::detach): Update.
        (procfs_target::fetch_registers): Update.
        (procfs_target::store_registers): Update.
        (procfs_target::wait): Update.
        (procfs_target::files_info): Update.
        * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
        * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
        return type.
        (nto_procfs_target::pid_to_str): Change return type.
        (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
        * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
        return type.
        * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
        (exit_lwp): Update.
        (attach_proc_task_lwp_callback, get_detach_signal)
        (detach_one_lwp, resume_lwp, linux_nat_target::resume)
        (linux_nat_target::resume, wait_lwp, stop_callback)
        (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
        (save_stop_reason, select_event_lwp, linux_nat_filter_event)
        (linux_nat_wait_1, resume_stopped_resumed_lwps)
        (linux_nat_target::wait, linux_nat_stop_lwp): Update.
        * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
        type.
        (inf_ptrace_target::attach): Update.
        (inf_ptrace_target::files_info): Update.
        * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
        type.
        (go32_nat_target::pid_to_str): Change return type.
        * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
        (gnu_nat_target::wait): Update.
        (gnu_nat_target::wait): Update.
        (gnu_nat_target::resume): Update.
        * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
        (fbsd_nat_target::wait): Update.
        * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
        type.
        (darwin_nat_target::attach): Update.
        * corelow.c (class core_target) <pid_to_str>: Change return type.
        (core_target::pid_to_str): Change return type.
        * target.c (normal_pid_to_str): Change return type.
        (default_pid_to_str): Likewise.
        (target_pid_to_str): Change return type.
        (target_translate_tls_address): Update.
        (target_announce_detach): Update.
        * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
        return type.
        (bsd_uthread_target::pid_to_str): Change return type.
        * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
        type.
        (bsd_kvm_target::pid_to_str): Change return type.
        * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
        return type.
        (aix_thread_target::pid_to_str): Change return type.
        * target.h (struct target_ops) <pid_to_str>: Change return type.
        (target_pid_to_str, normal_pid_to_str): Likewise.
        * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
        type.
        * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
        type.
        * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
        return type.
        * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
        type.
        * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
        type.
        * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
        return type.

2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>

        * NEWS: Mention that the new default MI version is 3.  Mention
        changes to the output of commands and events that deal with
        multi-location breakpoints.
        * breakpoint.c: Include "mi/mi-out.h".
        (print_one_breakpoint): Change output syntax if using MI version
        >= 3.
        * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
        New.
        (mi_multi_location_breakpoint_output_fixed): New.
        * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
        (mi_cmd_fix_multi_location_breakpoint_output): New.
        (mi_multi_location_breakpoint_output_fixed): New.
        * mi/mi-cmds.c (mi_cmds): Register command
        -fix-multi-location-breakpoint-output.
        * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
        interpreter "mi".

2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>

        * mi/mi-out.h (mi_out_new): Change parameter to const char *.
        * mi/mi-out.c (mi_out_new): Change parameter to const char *,
        instantiate mi_ui_out based on interpreter name.
        * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
        * mi/mi-main.c (mi_load_progress): Likewise.

2019-03-12  John Baldwin  <jhb@FreeBSD.org>

        * NEWS: Combine separate "New targets" sections for 8.3.

2019-03-12  John Baldwin  <jhb@FreeBSD.org>

        * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
        (ppcfbsd_init_abi): Install gdbarch
        "fetch_tls_load_module_address" and "get_thread_local_address"
        methods.

2019-03-12  John Baldwin  <jhb@FreeBSD.org>

        * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
        (riscv_fbsd_init_abi): Install gdbarch
        "fetch_tls_load_module_address" and "get_thread_local_address"
        methods.

2019-03-12  John Baldwin  <jhb@FreeBSD.org>

        * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
        (i386fbsd_init_abi): Install gdbarch
        "fetch_tls_load_module_address" and "get_thread_local_address"
        methods.

2019-03-12  John Baldwin  <jhb@FreeBSD.org>

        * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
        (amd64fbsd_init_abi): Install gdbarch
        "fetch_tls_load_module_address" and "get_thread_local_address"
        methods.

2019-03-12  John Baldwin  <jhb@FreeBSD.org>

        * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
        (struct fbsd_pspace_data): New type.
        (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
        (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
        (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
        (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
        * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.

2019-03-12  John Baldwin  <jhb@FreeBSD.org>

        * gdbtypes.c (lookup_struct_elt): New function.
        (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
        * gdbtypes.h (struct struct_elt): New type.
        (lookup_struct_elt): New prototype.

2019-03-12  John Baldwin  <jhb@FreeBSD.org>

        * gdbtypes.c (lookup_struct_elt_type): Update comment and
        remove disabled code block.

2019-03-12  John Baldwin  <jhb@FreeBSD.org>

        * gdbarch.sh (get_thread_local_address): New method.
        * gdbarch.h, gdbarch.c: Regenerate.
        * target.c (target_translate_tls_address): Use
        gdbarch_get_thread_local_address if present instead of
        target::get_thread_local_address.

2019-03-12  John Baldwin  <jhb@FreeBSD.org>

        * target.h (target::get_thread_local_address): Update comment.

2019-03-12  John Baldwin  <jhb@FreeBSD.org>

        * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
        objfile->separate_debug_objfile_backlink if not NULL.

2019-03-12  John Baldwin  <jhb@FreeBSD.org>

        * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
        tdep->fsbase_regnum instead of constants for fs_base and gs_base.
        (amd64bsd_store_inferior_registers): Likewise.
        * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
        Enable segment base registers.
        * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
        PT_GETFSBASE and PT_GETGSBASE.
        (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
        PT_SETGSBASE.
        * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
        segment base registers.
        * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.

2019-03-12  John Baldwin  <jhb@FreeBSD.org>

        * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
        Update calls to i386_target_description to add 'segments'
        parameter.
        * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
        add segment base registers.
        * arch/i386.c (i386_create_target_description): Add 'segments'
        parameter to enable segment base registers.
        * arch/i386.h (i386_create_target_description): Likewise.
        * features/i386/32bit-segments.xml: New file.
        * features/i386/32bit-segments.c: Generate.
        * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
        call to i386_target_description to add 'segments' parameter.
        * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
        * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
        * i386-linux-tdep.c (i386_linux_read_description): Likewise.
        * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
        if feature is present.
        (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
        Add 'segments' parameter to call to i386_target_description.
        (i386_target_description): Add 'segments' parameter to enable
        segment base registers.
        (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
        to call to i386_target_description.
        * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
        (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
        Define I386_NUM_REGS.
        (i386_target_description): Add 'segments' parameter to enable
        segment base registers.

2019-03-12  Eli Zaretskii  <eliz@gnu.org>

        PR/24325
        * source-cache.c: #undef open and close, to avoid unresolved
        externals during linking.

2019-03-12  Tom Tromey  <tromey@adacore.com>

        * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
        const.  Add initializers.
        (_initialize_remote): Don't initialize ptid globals.

2019-03-12  Pedro Alves  <palves@redhat.com>

        * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.

2019-03-12  Pedro Alves  <palves@redhat.com>

        * cp-name-parser.y (main): Remove unused 'len' variable.

2019-03-12  Tom Tromey  <tromey@adacore.com>

        * common/ptid.c (null_ptid, minus_one_ptid): Now const.
        * common/ptid.h (null_ptid, minus_one_ptid): Now const.

2019-03-12  Tom Tromey  <tromey@adacore.com>

        * linux-nat.c (iterate_over_lwps): Update.
        (stop_callback): Remove parameter.
        (stop_wait_callback, detach_callback, resume_set_callback)
        (select_singlestep_lwp_callback, set_ignore_sigint)
        (status_callback, resumed_callback, resume_clear_callback)
        (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
        data parameter.
        (linux_nat_target::detach, linux_nat_target::resume)
        (linux_stop_and_wait_all_lwps, select_event_lwp)
        (linux_nat_filter_event, linux_nat_wait_1)
        (linux_nat_target::kill, linux_nat_target::stop)
        (linux_nat_target::stop): Update.
        (linux_nat_resume_callback): Change type.
        (resume_stopped_resumed_lwps, count_events_callback)
        (select_event_lwp_callback): Likewise.
        (linux_stop_lwp, linux_nat_stop_lwp): Update.
        * arm-linux-nat.c (struct update_registers_data): Remove.
        (update_registers_callback): Change type.
        (arm_linux_insert_hw_breakpoint1): Update.
        * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
        parameter.
        (x86_linux_dr_set_addr): Update.
        (x86_linux_dr_set_control): Update.
        * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
        (iterate_over_lwps): Use gdb::function_view.
        * nat/aarch64-linux-hw-point.c (struct
        aarch64_dr_update_callback_param): Remove.
        (debug_reg_change_callback): Change type.
        (aarch64_notify_debug_reg_change): Update.
        * s390-linux-nat.c (s390_refresh_per_info): Update.

2019-03-11  Tom Tromey  <tromey@adacore.com>

        * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
        redundant assignment to "this_cu".

2019-03-08  Simon Marchi  <simon.marchi@efficios.com>

        * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.

2019-03-08  Simon Marchi  <simon.marchi@efficios.com>

        * gdbtypes.c (rank_one_type_parm_set): New function extracted
        from...
        (rank_one_type): ... this.

2019-03-08  Simon Marchi  <simon.marchi@efficios.com>

        * gdbtypes.c (rank_one_type_parm_struct): New function extracted
        from...
        (rank_one_type): ... this.

2019-03-08  Simon Marchi  <simon.marchi@efficios.com>

        * gdbtypes.c (rank_one_type_parm_complex): New function extracted
        from...
        (rank_one_type): ... this.

2019-03-08  Simon Marchi  <simon.marchi@efficios.com>

        * gdbtypes.c (rank_one_type_parm_float): New function extracted
        from...
        (rank_one_type): ... this.

2019-03-08  Simon Marchi  <simon.marchi@efficios.com>

        * gdbtypes.c (rank_one_type_parm_bool): New function extracted
        from...
        (rank_one_type): ... this.

2019-03-08  Simon Marchi  <simon.marchi@efficios.com>

        * gdbtypes.c (rank_one_type_parm_range): New function extracted
        from...
        (rank_one_type): ... this.

2019-03-08  Simon Marchi  <simon.marchi@efficios.com>

        * gdbtypes.c (rank_one_type_parm_char): New function extracted
        from...
        (rank_one_type): ... this.

2019-03-08  Simon Marchi  <simon.marchi@efficios.com>

        * gdbtypes.c (rank_one_type_parm_enum): New function extracted
        from...
        (rank_one_type): ... this.

2019-03-08  Simon Marchi  <simon.marchi@efficios.com>

        * gdbtypes.c (rank_one_type_parm_int): New function extracted
        from...
        (rank_one_type): ... this.

2019-03-08  Simon Marchi  <simon.marchi@efficios.com>

        * gdbtypes.c (rank_one_type_parm_func): New function extracted
        from...
        (rank_one_type): ... this.

2019-03-08  Simon Marchi  <simon.marchi@efficios.com>

        * gdbtypes.c (rank_one_type_parm_array): New function extracted
        from...
        (rank_one_type): ... this.

2019-03-08  Simon Marchi  <simon.marchi@efficios.com>

        * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
        from...
        (rank_one_type): ... this.

2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * inferior.c (initialize_inferiors): Ensure 'help set/show print
        inferior-events' shows the example events.

2019-03-08  Eli Zaretskii  <eliz@gnu.org>

        Support styling on native MS-Windows console

        PR/24315
        * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
        on MS-Windows if $TERM is not defined.

        * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.

        * posix-hdep.c (gdb_console_fputs):
        * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
        functions.
        * ui-file.h (gdb_console_fputs): Add prototype.

        * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
        back to fputs only if the former returns zero.

2019-03-07  Tom Tromey  <tom@tromey.com>

        * symmisc.c (print_symbol_bcache_statistics): Update.
        (print_objfile_statistics): Update.
        * symfile.c (allocate_symtab): Update.
        * stabsread.c: Don't include bcache.h.
        * psymtab.h (struct psymbol_bcache): Don't declare.
        (class psymtab_storage) <psymbol_cache>: Now a bcache.
        (psymbol_bcache_init, psymbol_bcache_free)
        (psymbol_bcache_get_bcache): Don't declare.
        * psymtab.c (struct psymbol_bcache): Remove.
        (psymtab_storage::psymtab_storage): Update.
        (psymtab_storage::~psymtab_storage): Update.
        (psymbol_bcache_init, psymbol_bcache_free)
        (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
        (add_psymbol_to_bcache): Update.
        (allocate_psymtab): Update.
        * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
        macro_cache>: No longer pointers.
        * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
        (free_objfile_per_bfd_storage): Don't call bcache_xfree.
        * macrotab.c (macro_bcache): Update.
        * macroexp.c: Don't include bcache.h.
        * gdbtypes.c (check_types_worklist): Update.
        (types_deeply_equal): Remove TRY/CATCH.  Update.
        * elfread.c (elf_symtab_read): Update.
        * dwarf2read.c: Don't include bcache.h.
        * buildsym.c (buildsym_compunit::get_macro_table): Update.
        * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
        (print_bcache_statistics, bcache_memory_used): Don't declare.
        (struct bcache): Move from bcache.c.  Add constructor, destructor,
        methods.  Rename all data members.
        * bcache.c (struct bcache): Move to bcache.h.
        (bcache::expand_hash_table): Rename from expand_hash_table.
        (bcache): Remove.
        (bcache::insert): Rename from bcache_full.
        (bcache::compare): Rename from bcache_compare.
        (bcache_xmalloc): Remove.
        (bcache::~bcache): Rename from bcache_xfree.
        (bcache::print_statistics): Rename from print_bcache_statistics.
        (bcache::memory_used): Rename from bcache_memory_used.

2019-03-07  Pedro Alves  <palves@redhat.com>

        * infrun.c (normal_stop): Also check for
        TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().

2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>

        * f-lang.c (value_from_host_double): Moved to...
        * value.c (value_from_host_double): ...here.
        * value.h (value_from_host_double): Declare.
        * guile/scm-math.c (vlscm_convert_typed_number): Use
        value_from_host_double.
        (vlscm_convert_number): Likewise.
        * guile/scm-value.c (gdbscm_value_to_real): Likewise.
        * python/py-value.c (convert_value_from_python): Likewise.

2019-03-06  Tom Tromey  <tom@tromey.com>

        * gcore.c (write_gcore_file): Use SCOPE_EXIT.

2019-03-06  Tom Tromey  <tom@tromey.com>

        * utils.h (free_current_contents): Don't declare.
        * utils.c (free_current_contents): Remove.

2019-03-06  Tom Tromey  <tom@tromey.com>

        * top.c (quit_force): Update.
        * main.c (captured_command_loop): Update.
        * common/new-op.c (operator new): Update.
        * common/common-exceptions.c (struct catcher)
        <save_cleanup_chain>: Remove member.
        (exceptions_state_mc_init): Update.
        (exception_try_scope_entry): Return nullptr.
        (exception_try_scope_exit, exception_rethrow)
        (throw_exception_sjlj, throw_exception_cxx): Update.
        * common/cleanups.h (make_cleanup, make_cleanup_dtor)
        (all_cleanups, do_cleanups, discard_cleanups)
        (discard_final_cleanups, save_cleanups, save_final_cleanups)
        (restore_cleanups, restore_final_cleanups): Don't declare.
        (do_final_cleanups): Remove parameter.
        * common/cleanups.c (cleanup_chain, make_cleanup)
        (make_cleanup_dtor, all_cleanups, do_cleanups)
        (discard_my_cleanups, discard_cleanups)
        (discard_final_cleanups, save_my_cleanups, save_cleanups)
        (save_final_cleanups, restore_my_cleanups, restore_cleanups)
        (null_cleanup): Remove.
        (do_final_cleanups): Remove parameter.

2019-03-06  Tom Tromey  <tom@tromey.com>

        * remote.c (remote_target::remote_parse_stop_reply): Use
        unique_xmalloc_ptr.

2019-03-06  Tom Tromey  <tom@tromey.com>

        * stabsread.c (struct stabs_field_info): Rename from field_info.
        <list, fnlist>: Add initializers.
        <obstack>: New member.
        (read_member_functions, read_struct_fields, read_baseclasses):
        Allocate on obstack.  Don't use cleanups.
        (read_one_struct_field, read_member_functions, read_struct_fields)
        (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
        (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
        (read_struct_type): Update.

2019-03-06  Tom Tromey  <tom@tromey.com>

        * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
        * common/filestuff.h (make_cleanup_close): Don't declare.
        * common/filestuff.c (do_close_cleanup, make_cleanup_close):
        Remove.

2019-03-06  Tom Tromey  <tom@tromey.com>

        * solib-aix.c: Use make_scope_exit.

2019-03-06  Tom Tromey  <tom@tromey.com>

        * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
        Use make_scope_exit.

2019-03-06  Tom Tromey  <tom@tromey.com>

        * solib-svr4.c (disable_probes_interface): Remove parameter.
        (svr4_handle_solib_event): Use make_scope_exit.

2019-03-06  Tom Tromey  <tom@tromey.com>

        * remote.c (struct stop_reply_deleter): Remove.
        (stop_reply_up): Update.
        (struct stop_reply): Derive from notif_event.  Don't typedef.
        <regcache>: Now a std::vector.
        (stop_reply_xfree): Remove.
        (stop_reply::~stop_reply): Rename from stop_reply_dtr.
        (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
        (remote_target::discard_pending_stop_replies): Use delete.
        (remote_target::remote_parse_stop_reply): Update.
        (remote_target::process_stop_reply): Update.
        * remote-notif.h (struct notif_event): Add virtual destructor.
        Remove "dtr" member.
        (struct notif_client) <alloc_event>: Return a unique_ptr.
        (notif_event_xfree): Don't declare.
        (notif_event_up): New typedef.
        * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
        (notif_event_xfree, do_notif_event_xfree): Remove.
        (remote_notif_state_xfree): Update.

2019-03-06  Tom Tromey  <tom@tromey.com>

        * infrun.c (displaced_step_clear_cleanup): Now a
        forward_scope_exit type.
        (displaced_step_prepare_throw): Update.
        (displaced_step_fixup): Update.

2019-03-06  Tom Tromey  <tom@tromey.com>

        * inferior.h (class inferior): Update comment.
        * gdbthread.h (class thread_info): Update comment.

2019-03-06  Joel Brobecker  <brobecker@adacore.com>
            Tom Tromey  <tom@tromey.com>

        * stabsread.h (struct stab_section_list): Remove.
        (coffstab_build_psymtabs): Update.
        * dbxread.c (symbuf_sections): Now a std::vector.
        (sect_idx): New global.
        (fill_symbuf): Update.
        (coffstab_build_psymtabs): Change type of stabsects parameter.
        Update.
        * coffread.c (struct coff_symfile_info) <stabsects>: Now a
        std::vector.
        (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
        (coff_locate_sections): Update.
        (coff_symfile_read): Remove cleanups.  Update.
        (init_stringtab): Add storage parameter.
        (free_stringtab, free_stringtab_cleanup): Remove.
        (init_lineno): Add storage parameter.
        (free_linetab, free_linetab_cleanup): Remove.

2019-03-06  Pedro Alves  <palves@redhat.com>

        * linux-fork.c (fork_info::clobber_regs): Delete.
        (fork_load_infrun_state): Remove reference to 'clobber_regs'.
        (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
        comment.  Adjust.
        (scoped_switch_fork_info::scoped_switch_fork_info)
        (checkpoint_command, linux_fork_context): Adjust
        fork_save_infrun_state calls.

2019-03-06  Pedro Alves  <palves@redhat.com>

        * linux-fork.c (inf_has_multiple_thread_cb): Delete.
        (inf_has_multiple_threads): Return 'bool' and rewrite using
        inferior_info::threads().

2019-03-06  Pedro Alves  <palves@redhat.com>

        * linux-fork.c: Include <list>.
        (fork_list): Now a std::list instance.
        (fork_info): Add ctor, dtor, and in-class initialize all fields.
        (forks_exist_p, find_last_fork): Adjust.
        (new_fork): Delete.
        (one_fork_p): New.
        (add_fork): Adjust.
        (free_fork): Delete, folded into fork_info::~fork_info().
        (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
        Adjust.
        (init_fork_list): Delete.
        (linux_fork_killall, linux_fork_mourn_inferior)
        (linux_fork_detach, info_checkpoints_command): Adjust.
        (_initialize_linux_fork): No longer call init_fork_list.

2019-03-06  Pedro Alves  <palves@redhat.com>

        * linux-fork.c (new_fork): New, split out of ...
        (add_fork): ... this.  Return void.  Move "first fork" special
        case from here, to ...
        (checkpoint_command): ... here.
        * linux-linux.h (add_fork): Return void.

2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>

        * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.

2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
            Chris January  <chris.january@arm.com>
            David Lecomber  <david.lecomber@arm.com>

        * f-exp.y: New token, UNOP_INTRINSIC.
        (exp): New pattern using UNOP_INTRINSIC token.
        (f77_keywords): Add 'abs' keyword.
        * f-lang.c: Add 'target-float.h' and 'math.h' includes.
        (value_from_host_double): New function.
        (evaluate_subexp_f): Support UNOP_ABS.

2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>

        * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
        types.

2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>

        * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
        * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
        * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.

2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>

        * f-exp.y (convert_to_kind_type): Handle more type kinds.

2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
            Chris January  <chris.january@arm.com>

        * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
        * f-exp.y: Define 'KIND' token.
        (exp): New pattern for KIND expressions.
        (ptype): Handle types with a kind extension.
        (direct_abs_decl): Extend to spot kind extensions.
        (f77_keywords): Add 'kind' to the list.
        (push_kind_type): New function.
        (convert_to_kind_type): New function.
        * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
        * parse.c (operator_length_standard): Likewise.
        * parser-defs.h (enum type_pieces): Add tp_kind.
        * std-operator.def: Add UNOP_KIND.

2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>

        * f-exp.y (f_parse): Set yydebug.

2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>

        * f-lang.c (evaluate_subexp_f): New function.
        (exp_descriptor_f): New global.
        (f_language_defn): Use exp_descriptor_f instead of
        exp_descriptor_standard.

2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>

        * f-exp.y (struct token): Add comments.
        (dot_ops): Remove uppercase versions and the end marker.
        (f77_keywords): Likewise.
        (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
        entries in the dot_ops array are case insensitive, and use
        strncasecmp to compare strings.  Also some whitespace cleanup in
        this area.  Similar for the f77_keywords array, except entries in
        this list might be case sensitive.

2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>

        * f-exp.y (struct f77_boolean_val): Add comments.
        (boolean_values): Remove uppercase versions, and end marker.
        (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
        and use strncasecmp to achieve case insensitivity.  Additionally,
        perform whitespace cleanup around this code.

2019-03-06  Tom Tromey  <tromey@adacore.com>

        * remote-sim.c (gdbsim_target_open): Use result of
        gdb_argv::release.

2019-03-06  Richard Bunt  <richard.bunt@arm.com>
        Dirk Schubert  <dirk.schubert@arm.com>
        Chris January  <chris.january@arm.com>

        * eval.c (evaluate_subexp_standard): Call Fortran argument
        wrapping logic.
        * f-lang.c (struct value): A value which can be passed into a
        Fortran function call.
        (fortran_argument_convert): Wrap Fortran arguments in a pointer
        where appropriate.
        (struct type): Value ready for a Fortran function call.
        (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
        is needed.
        * f-lang.h (fortran_argument_convert): Declaration.
        (fortran_preserve_arg_pointer): Declaration.
        * infcall.c (value_arg_coerce): Call Fortran argument logic.

2019-03-05  Tom Tromey  <tromey@adacore.com>

        * python/py-prettyprint.c (print_string_repr): Remove #if.
        * python/py-utils.c (unicode_to_encoded_string): Remove #if.

2019-03-05  Tom Tromey  <tromey@adacore.com>

        * target.c (the_dummy_target): Move later.  Change type to
        "dummy_target".
        (initialize_targets): Don't initialize the_dummy_target.

2019-03-05  Tom Tromey  <tromey@adacore.com>

        * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
        * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.

2019-03-05  Tom Tromey  <tromey@adacore.com>

        * windows-nat.c (windows_nat_target::attach)
        (windows_nat_target::detach): Don't call gdb_flush.
        * valprint.c (generic_val_print, val_print, val_print_string):
        Don't call gdb_flush.
        * utils.c (defaulted_query): Don't call gdb_flush.
        * typeprint.c (print_type_scalar): Don't call gdb_flush.
        * target.c (target_announce_detach): Don't call gdb_flush.
        * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
        * remote.c (extended_remote_target::attach): Don't call
        gdb_flush.
        * procfs.c (procfs_target::detach): Don't call gdb_flush.
        * printcmd.c (do_examine): Don't call gdb_flush.
        (info_display_command): Don't call gdb_flush.
        * p-valprint.c (pascal_val_print): Don't call gdb_flush.
        * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
        * memattr.c (info_mem_command): Don't call gdb_flush.
        * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
        * m2-valprint.c (m2_val_print): Don't call gdb_flush.
        * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
        * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
        * hppa-tdep.c (unwind_command): Don't call gdb_flush.
        * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
        (gnu_nat_target::detach): Don't call gdb_flush.
        * f-valprint.c (f_val_print): Don't call gdb_flush.
        * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
        * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
        * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
        gdb_flush.
        * c-valprint.c (c_val_print): Don't call gdb_flush.
        * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.

2019-03-05  Tom Tromey  <tromey@adacore.com>

        * varobj.c (update_dynamic_varobj_children): Update.
        (install_default_visualizer): Use reset, not release.
        * value.c (set_internalvar): Update.
        * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
        * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
        ATTRIBUTE_UNUSED_RESULT.

2019-03-05  Tom Tromey  <tromey@adacore.com>

        * remote.c (class scoped_remote_fd) <release>: Add
        ATTRIBUTE_UNUSED_RESULT.

2019-03-05  Tom Tromey  <tromey@adacore.com>

        * macroexp.c (struct macro_buffer) <release>: Add
        ATTRIBUTE_UNUSED_RESULT.

2019-03-05  Tom Tromey  <tromey@adacore.com>

        * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
        * common/scoped_mmap.h (class scoped_mmap) <release>: Add
        ATTRIBUTE_UNUSED_RESULT.

2019-03-05  Tom Tromey  <tromey@adacore.com>

        * common/scoped_fd.h (class scoped_fd) <release>: Add
        ATTRIBUTE_UNUSED_RESULT.

2019-03-05  Tom Tromey  <tromey@adacore.com>

        * parser-defs.h (struct parser_state) <release>: Add
        ATTRIBUTE_UNUSED_RESULT.

2019-03-05  Tom Tromey  <tromey@adacore.com>

        * utils.h (class gdb_argv) <release>: Add
        ATTRIBUTE_UNUSED_RESULT.
        * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.

2019-03-02  Eli Zaretskii  <eliz@gnu.org>

        * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
        for-loop range, to avoid compiler warnings.

        * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
        avoid compiler warnings about unused variables.

        * NEWS: Mention end of support for native debugging on MS-Windows
        before XP.

        PR gdb/24292
        * common/netstuff.c:
        * gdbserver/gdbreplay.c
        * gdbserver/remote-utils.c:
        * ser-tcp.c:
        * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
        Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
        _WIN32_WINNT to 0x0501 if defined to a smaller value, as
        'getaddrinfo' and 'freeaddrinfo' were not available before
        Windows XP, and mingw.org's MinGW headers by default define
        _WIN32_WINNT to 0x500.

2019-03-01  Gary Benson <gbenson@redhat.com>

        * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.

2019-02-28  Brian Vandenberg  <phantall@gmail.com>
            Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

        PR gdb/8527
        * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
        set_sigint_trap, clear_sigint_trap.

2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * target.c (target_detach): Clear the regcache and the
        frame cache.

2019-02-27  Pedro Alves  <palves@redhat.com>

        * utils.c (set_screen_size): When we cap the height/width sizes,
        tweak the corresponding command variable to show "unlimited":

2019-02-27  Saagar Jha  <saagar@saagarjha.com>
            Pedro Alves  <palves@redhat.com>

        * utils.c (set_screen_size): Reduce "infinite" rows and columns
        before calling rl_set_screen_size.

2019-02-27  Tom Tromey  <tromey@adacore.com>

        * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
        define.
        * python/py-value.c: Remove Python 2.4 workaround.
        * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
        workaround.
        * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
        Python 2.4 workaround.
        * python/python-internal.h: Remove Python 2.4 comment.
        (Py_ssize_t): Don't define.
        (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
        (gdb_Py_DECREF): Remove Python 2.4 workaround.
        (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
        (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
        * python/python.c (do_start_initialization): Remove Python 2.4
        workaround.
        * python/py-prettyprint.c (class dummy_python_frame): Remove.
        (print_children): Remove Python 2.4 workaround.
        * python/py-inferior.c (buffer_procs): Remove Python 2.4
        workaround.
        (CHARBUFFERPROC_NAME): Remove.
        * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
        Python 2.4 workaround.

2019-02-27  Kevin Buettner  <kevinb@redhat.com>

        * NEWS: Note minimum Python version.

2019-02-27  Kevin Buettner  <kevinb@redhat.com>

        * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
        code from these functions.  Remove corresponding ifdefs.  Use
        Py_buffer_up instead of explicit calls to PyBuffer_Release.
        Remove gotos and target of gotos.
        (infpy_search_memory): Likewise.

2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>

        * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
        (hppa_gdbarch_init): Don't register deleted functions with
        gdbarch.

2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>

        * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
        (h8300_unwind_sp): Delete.
        (h8300_dummy_id): Delete.
        (h8300_gdbarch_init): Don't register deleted functions with
        gdbarch.

2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>

        * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
        (ft32_unwind_pc): Delete.
        (ft32_unwind_sp): Delete.
        (ft32_gdbarch_init): Don't register deleted functions with
        gdbarch.

2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>

        * gdb/frv-tdep.c (frv_dummy_id): Delete.
        (frv_unwind_pc): Delete.
        (frv_unwind_sp): Delete.
        (frv_gdbarch_init): Don't register deleted functions with
        gdbarch.

2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>

        * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
        (riscv_unwind_pc): Delete.
        (riscv_unwind_sp): Delete.
        (riscv_gdbarch_init): Don't register deleted functions with
        gdbarch.

2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>

        * gdb/csky-tdep.c (csky_dummy_id): Delete.
        (csky_unwind_pc): Delete.
        (csky_unwind_sp): Delete.
        (csky_gdbarch_init): Don't register deleted functions with
        gdbarch.

2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>

        * gdb/cris-tdep.c (cris_dummy_id): Delete.
        (cris_unwind_pc): Delete.
        (cris_unwind_sp): Delete.
        (cris_gdbarch_init): Don't register deleted functions with
        gdbarch.

2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>

        * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
        (bfin_unwind_pc): Delete.
        (bfin_gdbarch_init): Don't register deleted functions with gdbarch.

2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>

        * gdb/arm-tdep.c (arm_dummy_id): Delete.
        (arm_unwind_pc): Delete.
        (arm_unwind_sp): Delete.
        (arm_gdbarch_init): Don't register deleted functions with gdbarch.

2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>

        * gdb/arc-tdep.c (arc_dummy_id): Delete.
        (arc_unwind_pc): Delete.
        (arc_unwind_sp): Delete.
        (arc_gdbarch_init): Don't register deleted functions with gdbarch.

2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>

        * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
        (alpha_unwind_pc): Delete.
        (alpha_gdbarch_init): Don't register deleted functions with
        gdbarch.

2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>

        * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
        (aarch64_unwind_pc): Delete.
        (aarch64_unwind_sp): Delete.
        (aarch64_gdbarch_init): Don't register deleted functions with
        gdbarch.

2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>

        * gdbtypes.c (type_align): Don't consider static members when
        computing structure alignment.

2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>

        * arc-tdep.c (arc_type_align): Provide alignment for basic types,
        return 0 for other types.
        * arch-utils.c (default_type_align): Always return 0.
        * gdbarch.h: Regenerate.
        * gdbarch.sh (type_align): Extend comment.
        * gdbtypes.c (type_align): Add additional comments, always call
        gdbarch_type_align before applying the default rules.
        * i386-tdep.c (i386_type_align): Return 0 as the default rule,
        generic code will then apply a suitable default.
        * nios2-tdep.c (nios2_type_align): Provide alignment for basic
        types, return 0 for other types.

2019-02-27  Joel Brobecker  <brobecker@adacore.com>

        * NEWS: Create a new section for the next release branch.
        Rename the section of the current branch, now that it has
        been cut.

2019-02-27  Joel Brobecker  <brobecker@adacore.com>

        GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
        * version.in: Bump version to 8.3.50.DATE-git.

2019-02-26  Simon Marchi  <simon.marchi@efficios.com>

        * aix-thread.c (ptid_cmp): Remove unused variable.
        (get_signaled_thread): Likewise.
        (store_regs_user_thread): Likewise.
        (store_regs_kernel_thread): Likewise.
        (fetch_regs_kernel_thread): Remove shadowed variable.

2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>

        * features/riscv/32bit-cpu.xml: Add register numbers.
        * features/riscv/32bit-fpu.c: Regenerate.
        * features/riscv/32bit-fpu.xml: Add register numbers.
        * features/riscv/64bit-cpu.xml: Add register numbers.
        * features/riscv/64bit-fpu.c: Regenerate.
        * features/riscv/64bit-fpu.xml: Add register numbers.

2019-02-26  Kevin Buettner  <kevinb@redhat.com>

        * NEWS: Mention two argument form of gdb.Value constructor.
        * python/py-value.c (convert_buffer_and_type_to_value): New
        function.
        (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
        Add support for handling an optional second argument.  Call
        convert_buffer_and_type_to_value as appropriate.
        * python/python-internal.h (Py_buffer_deleter): New struct.
        (Py_buffer_up): New typedef.

2019-02-25  John Baldwin  <jhb@FreeBSD.org>

        * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
        instead of releasing ownership.

2019-02-25  Jordan Rupprecht  <rupprecht@google.com>

        * dwarf2read.c (open_and_init_dwp_file): Call
        elf_numsections instead of bfd_count_sections to initialize
        dwp_file->num_sections.

2019-02-25  Tom Tromey  <tromey@adacore.com>

        * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.

2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>

        * gcore.in: Add '--readnever' option when invoking GDB.

2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>

        * MAINTAINERS: Update my email address.

2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>

        * build-id.c (build_id_to_debug_bfd_1): New function.
        (build_id_to_debug_bfd): Look for separate debug file in
        sysroot.

2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>

        * gdbarch.sh: Update the copyright year range that is placed into
        generated files.

2019-02-22  Keith Seitz  <keiths@redhat.com>

        PR symtab/23853
        * linespec.c (create_sals_line_offset): Search for the default
        symtab's filename instead of its fullname.

2019-02-21  Alan Hayward  <alan.hayward@arm.com>

        * NEWS: Update style defaults.

2019-02-21  Alan Hayward  <alan.hayward@arm.com>

        * main.c (captured_main_1): Disable styling in batch mode.

2019-02-20  Tom Tromey  <tom@tromey.com>

        * symtab.c (symtab_symbol_info): Fix typos.

2019-02-20  Tom Tromey  <tromey@adacore.com>

        * findcmd.c (_initialize_mem_search): Use upper case for
        metasyntactic variables.

2019-02-20  Alan Hayward  <alan.hayward@arm.com>

        * aarch64-tdep.c (aarch64_add_reggroups): New function.
        (aarch64_gdbarch_init): Call aarch64_add_reggroups.

2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>

        * top.h (source_file_name): Change to std::string.
        * top.c (source_file_name): Likewise.
        (command_line_input): Adjust.
        * cli/cli-script.c (script_from_file): Adjust.

2019-02-19  Tom Tromey  <tromey@adacore.com>

        * ravenscar-thread.c
        (ravenscar_thread_target::update_thread_list): Don't call
        ada_build_task_list.
        * ada-lang.h (ada_build_task_list): Don't declare.
        * ada-tasks.c (struct ada_tasks_inferior_data)
        <task_list_valid_p>: Now bool.
        (read_known_tasks, ada_task_list_changed)
        (ada_tasks_invalidate_inferior_data): Update.
        (read_known_tasks_array): Return bool.
        (read_known_tasks_list): Likewise.
        (read_known_tasks): Return void.
        (ada_build_task_list): Now static.

2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>

        * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
        and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.

2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
        variant for ada_tasks_pspace_data_handle and
        ada_tasks_inferior_data_handle.
        (ada_tasks_pspace_data_cleanup): New function.
        (ada_tasks_inferior_data_cleanup): New function.

2019-02-17  Tom Tromey  <tom@tromey.com>

        * macrotab.h (macro_source_fullname): Return a std::string.
        * macrotab.c (macro_include, check_for_redefinition)
        (macro_undef, macro_lookup_definition, foreach_macro)
        (foreach_macro_in_scope): Update.
        (macro_source_fullname): Return a std::string.
        * macrocmd.c (show_pp_source_pos): Update.

2019-02-17  Tom Tromey  <tom@tromey.com>

        * macrocmd.c (show_pp_source_pos): Style the file names.

2019-02-17  Tom Tromey  <tom@tromey.com>

        PR tui/24197:
        * tui/tui-source.c (tui_set_source_content_nil): Rewrite.

2019-02-17  Tom Tromey  <tom@tromey.com>

        * ada-lang.c (user_select_syms): Use filtered printing.
        * utils.c (wrap_style): New global.
        (desired_style): Remove.
        (emit_style_escape): Add stream parameter.
        (set_output_style, reset_terminal_style, prompt_for_continue):
        Update.
        (flush_wrap_buffer): Only flush gdb_stdout.
        (wrap_here): Set wrap_style.
        (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
        treat escape sequences as a character.  Change when wrap buffer is
        flushed.
        (fputs_styled): Do not set the output style when the default is
        requested.
        * ui-style.h (struct ui_file_style) <is_default>: New method.
        * source.c (print_source_lines_base): Emit escape sequences in one
        piece.

2019-02-17  Joel Brobecker  <brobecker@adacore.com>

        * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
        integers and enumeration types.

2019-02-17  Joel Brobecker  <brobecker@adacore.com>

        * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
        instead of lookup_symbol_in_language
        (do_exact_match): New function.
        (ada_get_symbol_name_matcher): Return do_exact_match when
        doing a verbatim match.

2019-02-15  Tom Tromey  <tromey@adacore.com>

        * ravenscar-thread.c (ravenscar_thread_target::resume)
        (ravenscar_thread_target::wait): Special case wildcard requests.

2019-02-15  Tom Tromey  <tromey@adacore.com>

        * ravenscar-thread.c (base_ptid): Remove.
        (struct ravenscar_thread_target) <close>: New method.
        <m_base_ptid>: New member.
        <update_inferior_ptid, active_task, task_is_currently_active,
        runtime_initialized>: Declare methods.
        <ravenscar_thread_target>: Add constructor.
        (ravenscar_thread_target::task_is_currently_active)
        (ravenscar_thread_target::update_inferior_ptid)
        (ravenscar_runtime_initialized): Rename.  Now methods.
        (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
        (ravenscar_thread_target::update_thread_list): Update.
        (ravenscar_thread_target::active_task): Now method.
        (ravenscar_thread_target::store_registers)
        (ravenscar_thread_target::prepare_to_store)
        (ravenscar_thread_target::prepare_to_store)
        (ravenscar_thread_target::mourn_inferior): Update.
        (ravenscar_inferior_created): Use "new" to create target.
        (ravenscar_thread_target::get_ada_task_ptid): Update.
        (_initialize_ravenscar): Don't initialize base_ptid.
        (ravenscar_ops): Remove global.

2019-02-15  Tom Tromey  <tromey@adacore.com>

        * target.h (push_target): Declare new overload.
        * target.c (push_target): New overload, taking an rvalue reference.
        * remote.c (remote_target::open_1): Use push_target overload.
        * corelow.c (core_target_open): Use push_target overload.

2019-02-15  Tom Tromey  <tromey@adacore.com>

        * ravenscar-thread.c (is_ravenscar_task)
        (ravenscar_task_is_currently_active): Return bool.
        (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
        (_initialize_ravenscar): Remove "(void)".
        (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
        Return bool.

2019-02-15  Tom Tromey  <tromey@adacore.com>

        * ravenscar-thread.c (ravenscar_runtime_initializer)
        (has_ravenscar_runtime, get_running_thread_id)
        (ravenscar_thread_target::resume): Fix indentation.

2019-02-15  Tom Tromey  <tromey@adacore.com>

        * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
        from ravenscar_arch_ops.
        (sparc_ravenscar_ops::fetch_registers)
        (sparc_ravenscar_ops::store_registers): Now methods.
        (sparc_ravenscar_prepare_to_store): Remove.
        (sparc_ravenscar_ops): Redefine.
        * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
        methods and destructor.  Remove members.
        * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
        (ravenscar_thread_target::store_registers)
        (ravenscar_thread_target::prepare_to_store): Update.
        * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
        Remove.
        (struct ppc_ravenscar_powerpc_ops): Derive from
        ravenscar_arch_ops.
        (ppc_ravenscar_powerpc_ops::fetch_registers)
        (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
        (ppc_ravenscar_powerpc_ops): Redefine.
        (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
        (ppc_ravenscar_e500_ops::fetch_registers)
        (ppc_ravenscar_e500_ops::store_registers): Now methods.
        (ppc_ravenscar_e500_ops): Redefine.
        * aarch64-ravenscar-thread.c
        (aarch64_ravenscar_generic_prepare_to_store): Remove.
        (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
        (aarch64_ravenscar_fetch_registers)
        (aarch64_ravenscar_store_registers): Now methods.
        (aarch64_ravenscar_ops): Redefine.

2019-02-15  Tom Tromey  <tromey@adacore.com>

        * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
        (ravenscar_thread_target::stopped_by_hw_breakpoint)
        (ravenscar_thread_target::stopped_by_watchpoint)
        (ravenscar_thread_target::stopped_data_address)
        (ravenscar_thread_target::core_of_thread): Use scoped_restore.

2019-02-15  Tom Tromey  <tromey@adacore.com>

        * ravenscar-thread.c: Fix some typos.

2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
            Tom Tromey  <tromey@adacore.com>

        * ada-lang.c (ada_exception_sal): Change addr_string to a
        std::string.
        (create_ada_exception_catchpoint): Update.

2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
            Tom Tromey  <tromey@adacore.com>

        * breakpoint.c (~bp_location): Rename from bp_location_dtor.
        (bp_location_ops): Remove.
        (base_breakpoint_allocate_location): Update.
        (free_bp_location): Update.
        * ada-lang.c (class ada_catchpoint_location)
        <ada_catchpoint_location>: Remove ops parameter.
        (ada_catchpoint_location_dtor): Remove.
        (ada_catchpoint_location_ops): Remove.
        (allocate_location_exception): Update.
        * breakpoint.h (struct bp_location_ops): Remove.
        (class bp_location) <bp_location>: Remove bp_location_ops
        parameter.
        <~bp_location>: Add destructor.
        <ops>: Remove.

2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
            Pedro Alves  <palves@redhat.com>

        * remote.c (remote_target::remote_parse_stop_reply): Avoid using
        'PATH_MAX'.

2019-02-14  David Michael  <fedora.dm0@gmail.com>
            Samuel Thibault  <samuel.thibault@gnu.org>
            Thomas Schwinge  <thomas@codesourcery.com>

        * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
        (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.

2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>

        * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
        (check_empty): Use "const char *".

        * gnu-nat.c (gnu_nat_target::detach): Instead of
        'detach_inferior (pid)' call
        'detach_inferior (find_inferior_pid (pid))'.

        * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
        'nat/fork-inferior.o'.
        * gnu-nat.c: #include "nat/fork-inferior.h".

        * gnu-nat.c (gnu_nat_target::detach): Instead of
        'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
        * gnu-nat.h: #include "inf-child.h".
        * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
        'i386_gnu_nat_target::fetch_registers'.
        (gnu_store_registers): Rename/move to
        'i386_gnu_nat_target::store_registers'.

        * config/i386/nm-i386gnu.h: Don't "#include" any files.
        * gnu-nat.h (mach_thread_info): New function.
        * gnu-nat.c (thread_takeover_sc_cmd): Use it.

        * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.

2019-02-14  Frederic Konrad  <konrad@adacore.com>

        * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.

2019-02-14  Joel Brobecker  <brobecker@adacore.com>

        * windows-nat.c (windows_add_thread): Add new parameter
        "main_thread_p" with default value set to false.  Update
        function documentation as well as all callers.
        (windows_delete_thread): Likewise.
        (fake_create_process): Update call to windows_add_thread.
        (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
        <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
        <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
        call to windows_delete_thread.

2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>

        * MAINTAINERS: Add Andrew Burgess as global maintainer.

2019-02-12  John Baldwin  <jhb@FreeBSD.org>

        * symfile.c (find_separate_debug_file): Use canonical path of
        sysroot with child_path instead of gdb_sysroot if it is valid.

2019-02-12  John Baldwin  <jhb@FreeBSD.org>

        * symfile.c (find_separate_debug_file): Use child_path to
        determine if an object file is under a sysroot.

2019-02-12  John Baldwin  <jhb@FreeBSD.org>

        * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
        unittests/child-path-selftests.c.
        * common/pathstuff.c (child_path): New function.
        * common/pathstuff.h (child_path): New prototype.
        * unittests/child-path-selftests.c: New file.

2019-02-12  John Baldwin  <jhb@FreeBSD.org>

        * symfile.c (find_separate_debug_file): Look for separate debug
        files in debug directories under the sysroot.

2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * symtab.h (struct minimal_symbol data_p): New const method.
        (struct minimal_symbol text_p): Likewise.
        * symtab.c (output_source_filename): Use file name style
        to print file name.
        (print_symbol_info): Likewise.
        (print_msymbol_info): Use address style to print addresses.
        Use function name style to print executable text symbols.
        (expand_symtab_containing_pc): Use data_p.
        (find_pc_sect_compunit_symtab): Likewise.

2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * breakpoint.c (describe_other_breakpoints): Use address style
        to print addresses.
        (say_where): Likewise.

2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * ada-typeprint.c (print_func_type): Print function name
        style to print function name.
        * c-typeprint.c (c_print_type_1): Likewise.

2019-02-11  Alan Hayward  <alan.hayward@arm.com>

        * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
        for execve.

2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * c-exp.y (direct_abs_decl): Use emplace_back to record the
        type_stack.

2019-02-10  Joel Brobecker  <brobecker@adacore.com>

        * ada-varobj.c (ada_value_is_changeable_p): Add handling of
        TYPE_CODE_REF types.

2019-02-08  Jim Wilson  <jimw@sifive.com>

        * riscv-linux-tdep.c (riscv_linux_fregmap): New.
        (riscv_linux_fregset): New.
        (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.

2019-02-07  Tom Tromey  <tom@tromey.com>

        * thread.c (thread_cancel_execution_command): Update.
        * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
        methods.
        (struct thread_fsm_ops): Remove.
        (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
        (thread_fsm_should_stop, thread_fsm_return_value)
        (thread_fsm_set_finished, thread_fsm_finished_p)
        (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
        Don't declare.
        * mi/mi-interp.c (mi_on_normal_stop_1): Update.
        * infrun.c (clear_proceed_status_thread)
        (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
        (print_stop_event): Update.
        * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
        Add constructor.
        (step_command_fsm_ops): Remove.
        (new_step_command_fsm): Remove.
        (step_1): Update.
        (step_command_fsm::should_stop): Rename from
        step_command_fsm_should_stop.
        (step_command_fsm::clean_up): Rename from
        step_command_fsm_clean_up.
        (step_command_fsm::do_async_reply_reason): Rename from
        step_command_fsm_async_reply_reason.
        (struct until_next_fsm): Inherit from thread_fsm.  Add
        constructor.
        (until_next_fsm_ops): Remove.
        (new_until_next_fsm): Remove.
        (until_next_fsm::should_stop): Rename from
        until_next_fsm_should_stop.
        (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
        (until_next_fsm::do_async_reply_reason): Rename from
        until_next_fsm_async_reply_reason.
        (struct finish_command_fsm): Inherit from thread_fsm.  Add
        constructor.  Change type of breakpoint.
        (finish_command_fsm_ops): Remove.
        (new_finish_command_fsm): Remove.
        (finish_command_fsm::should_stop): Rename from
        finish_command_fsm_should_stop.
        (finish_command_fsm::clean_up): Rename from
        finish_command_fsm_clean_up.
        (finish_command_fsm::return_value): Rename from
        finish_command_fsm_return_value.
        (finish_command_fsm::do_async_reply_reason): Rename from
        finish_command_fsm_async_reply_reason.
        (finish_command): Update.
        * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
        Add constructor.
        (call_thread_fsm_ops): Remove.
        (call_thread_fsm::call_thread_fsm): Rename from
        new_call_thread_fsm.
        (call_thread_fsm::should_stop): Rename from
        call_thread_fsm_should_stop.
        (call_thread_fsm::should_notify_stop): Rename from
        call_thread_fsm_should_notify_stop.
        (run_inferior_call, call_function_by_hand_dummy): Update.
        * cli/cli-interp.c (should_print_stop_to_console): Update.
        * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
        Add constructor.  Change type of location_breakpoint,
        caller_breakpoint.
        (until_break_fsm_ops): Remove.
        (new_until_break_fsm): Remove.
        (until_break_fsm::should_stop): Rename from
        until_break_fsm_should_stop.
        (until_break_fsm::clean_up): Rename from
        until_break_fsm_clean_up.
        (until_break_fsm::do_async_reply_reason): Rename from
        until_break_fsm_async_reply_reason.
        (until_break_command): Update.
        * thread-fsm.c: Remove.
        * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.

2019-02-07  Tom Tromey  <tom@tromey.com>

        * yy-remap.h: Add include guard.
        * xtensa-tdep.h: Add include guard.
        * xcoffread.h: Rename include guard.
        * varobj-iter.h: Add include guard.
        * tui/tui.h: Rename include guard.
        * tui/tui-winsource.h: Rename include guard.
        * tui/tui-wingeneral.h: Rename include guard.
        * tui/tui-windata.h: Rename include guard.
        * tui/tui-win.h: Rename include guard.
        * tui/tui-stack.h: Rename include guard.
        * tui/tui-source.h: Rename include guard.
        * tui/tui-regs.h: Rename include guard.
        * tui/tui-out.h: Rename include guard.
        * tui/tui-layout.h: Rename include guard.
        * tui/tui-io.h: Rename include guard.
        * tui/tui-hooks.h: Rename include guard.
        * tui/tui-file.h: Rename include guard.
        * tui/tui-disasm.h: Rename include guard.
        * tui/tui-data.h: Rename include guard.
        * tui/tui-command.h: Rename include guard.
        * tic6x-tdep.h: Add include guard.
        * target/waitstatus.h: Rename include guard.
        * target/wait.h: Rename include guard.
        * target/target.h: Rename include guard.
        * target/resume.h: Rename include guard.
        * target-float.h: Rename include guard.
        * stabsread.h: Add include guard.
        * rs6000-tdep.h: Add include guard.
        * riscv-fbsd-tdep.h: Add include guard.
        * regformats/regdef.h: Rename include guard.
        * record.h: Rename include guard.
        * python/python.h: Rename include guard.
        * python/python-internal.h: Rename include guard.
        * python/py-stopevent.h: Rename include guard.
        * python/py-ref.h: Rename include guard.
        * python/py-record.h: Rename include guard.
        * python/py-record-full.h: Rename include guard.
        * python/py-record-btrace.h: Rename include guard.
        * python/py-instruction.h: Rename include guard.
        * python/py-events.h: Rename include guard.
        * python/py-event.h: Rename include guard.
        * procfs.h: Add include guard.
        * proc-utils.h: Add include guard.
        * p-lang.h: Add include guard.
        * or1k-tdep.h: Rename include guard.
        * observable.h: Rename include guard.
        * nto-tdep.h: Rename include guard.
        * nat/x86-linux.h: Rename include guard.
        * nat/x86-linux-dregs.h: Rename include guard.
        * nat/x86-gcc-cpuid.h: Add include guard.
        * nat/x86-dregs.h: Rename include guard.
        * nat/x86-cpuid.h: Rename include guard.
        * nat/ppc-linux.h: Rename include guard.
        * nat/mips-linux-watch.h: Rename include guard.
        * nat/linux-waitpid.h: Rename include guard.
        * nat/linux-ptrace.h: Rename include guard.
        * nat/linux-procfs.h: Rename include guard.
        * nat/linux-osdata.h: Rename include guard.
        * nat/linux-nat.h: Rename include guard.
        * nat/linux-namespaces.h: Rename include guard.
        * nat/linux-btrace.h: Rename include guard.
        * nat/glibc_thread_db.h: Rename include guard.
        * nat/gdb_thread_db.h: Rename include guard.
        * nat/gdb_ptrace.h: Rename include guard.
        * nat/fork-inferior.h: Rename include guard.
        * nat/amd64-linux-siginfo.h: Rename include guard.
        * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
        * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
        * nat/aarch64-linux.h: Rename include guard.
        * nat/aarch64-linux-hw-point.h: Rename include guard.
        * mn10300-tdep.h: Add include guard.
        * mips-linux-tdep.h: Add include guard.
        * mi/mi-parse.h: Rename include guard.
        * mi/mi-out.h: Rename include guard.
        * mi/mi-main.h: Rename include guard.
        * mi/mi-interp.h: Rename include guard.
        * mi/mi-getopt.h: Rename include guard.
        * mi/mi-console.h: Rename include guard.
        * mi/mi-common.h: Rename include guard.
        * mi/mi-cmds.h: Rename include guard.
        * mi/mi-cmd-break.h: Rename include guard.
        * m2-lang.h: Add include guard.
        * location.h: Rename include guard.
        * linux-record.h: Rename include guard.
        * linux-nat.h: Add include guard.
        * linux-fork.h: Add include guard.
        * i386-darwin-tdep.h: Rename include guard.
        * hppa-linux-offsets.h: Add include guard.
        * guile/guile.h: Rename include guard.
        * guile/guile-internal.h: Rename include guard.
        * gnu-nat.h: Rename include guard.
        * gdb-stabs.h: Rename include guard.
        * frv-tdep.h: Add include guard.
        * f-lang.h: Add include guard.
        * event-loop.h: Add include guard.
        * darwin-nat.h: Rename include guard.
        * cp-abi.h: Rename include guard.
        * config/sparc/nm-sol2.h: Rename include guard.
        * config/nm-nto.h: Rename include guard.
        * config/nm-linux.h: Add include guard.
        * config/i386/nm-i386gnu.h: Rename include guard.
        * config/djgpp/nl_types.h: Rename include guard.
        * config/djgpp/langinfo.h: Rename include guard.
        * compile/gcc-cp-plugin.h: Add include guard.
        * compile/gcc-c-plugin.h: Add include guard.
        * compile/compile.h: Rename include guard.
        * compile/compile-object-run.h: Rename include guard.
        * compile/compile-object-load.h: Rename include guard.
        * compile/compile-internal.h: Rename include guard.
        * compile/compile-cplus.h: Rename include guard.
        * compile/compile-c.h: Rename include guard.
        * common/xml-utils.h: Rename include guard.
        * common/x86-xstate.h: Rename include guard.
        * common/version.h: Rename include guard.
        * common/vec.h: Rename include guard.
        * common/tdesc.h: Rename include guard.
        * common/selftest.h: Rename include guard.
        * common/scoped_restore.h: Rename include guard.
        * common/scoped_mmap.h: Rename include guard.
        * common/scoped_fd.h: Rename include guard.
        * common/safe-iterator.h: Rename include guard.
        * common/run-time-clock.h: Rename include guard.
        * common/refcounted-object.h: Rename include guard.
        * common/queue.h: Rename include guard.
        * common/ptid.h: Rename include guard.
        * common/print-utils.h: Rename include guard.
        * common/preprocessor.h: Rename include guard.
        * common/pathstuff.h: Rename include guard.
        * common/observable.h: Rename include guard.
        * common/netstuff.h: Rename include guard.
        * common/job-control.h: Rename include guard.
        * common/host-defs.h: Rename include guard.
        * common/gdb_wait.h: Rename include guard.
        * common/gdb_vecs.h: Rename include guard.
        * common/gdb_unlinker.h: Rename include guard.
        * common/gdb_unique_ptr.h: Rename include guard.
        * common/gdb_tilde_expand.h: Rename include guard.
        * common/gdb_sys_time.h: Rename include guard.
        * common/gdb_string_view.h: Rename include guard.
        * common/gdb_splay_tree.h: Rename include guard.
        * common/gdb_setjmp.h: Rename include guard.
        * common/gdb_ref_ptr.h: Rename include guard.
        * common/gdb_optional.h: Rename include guard.
        * common/gdb_locale.h: Rename include guard.
        * common/gdb_assert.h: Rename include guard.
        * common/filtered-iterator.h: Rename include guard.
        * common/filestuff.h: Rename include guard.
        * common/fileio.h: Rename include guard.
        * common/environ.h: Rename include guard.
        * common/common-utils.h: Rename include guard.
        * common/common-types.h: Rename include guard.
        * common/common-regcache.h: Rename include guard.
        * common/common-inferior.h: Rename include guard.
        * common/common-gdbthread.h: Rename include guard.
        * common/common-exceptions.h: Rename include guard.
        * common/common-defs.h: Rename include guard.
        * common/common-debug.h: Rename include guard.
        * common/cleanups.h: Rename include guard.
        * common/buffer.h: Rename include guard.
        * common/btrace-common.h: Rename include guard.
        * common/break-common.h: Rename include guard.
        * cli/cli-utils.h: Rename include guard.
        * cli/cli-style.h: Rename include guard.
        * cli/cli-setshow.h: Rename include guard.
        * cli/cli-script.h: Rename include guard.
        * cli/cli-interp.h: Rename include guard.
        * cli/cli-decode.h: Rename include guard.
        * cli/cli-cmds.h: Rename include guard.
        * charset-list.h: Add include guard.
        * buildsym-legacy.h: Rename include guard.
        * bfin-tdep.h: Add include guard.
        * ax.h: Rename include guard.
        * arm-linux-tdep.h: Add include guard.
        * arm-fbsd-tdep.h: Add include guard.
        * arch/xtensa.h: Rename include guard.
        * arch/tic6x.h: Add include guard.
        * arch/i386.h: Add include guard.
        * arch/arm.h: Rename include guard.
        * arch/arm-linux.h: Rename include guard.
        * arch/arm-get-next-pcs.h: Rename include guard.
        * arch/amd64.h: Add include guard.
        * arch/aarch64-insn.h: Rename include guard.
        * arch-utils.h: Rename include guard.
        * annotate.h: Add include guard.
        * amd64-darwin-tdep.h: Rename include guard.
        * aarch64-linux-tdep.h: Add include guard.
        * aarch64-fbsd-tdep.h: Add include guard.
        * aarch32-linux-nat.h: Add include guard.

2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * macrotab.c (macro_define_internal): New function that
        factorizes macro_define_object_internal and macro_define_function
        code.
        (macro_define_object_internal): Use macro_define_internal.
        (macro_define_function): Likewise.

2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * macrocmd.c (extract_identifier): Return
        a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
        callers.

2019-02-06  John Baldwin  <jhb@FreeBSD.org>

        * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.

2019-02-05  Tom Tromey  <tom@tromey.com>

        * target.c (target_stack::unpush): Move assertion earlier.

2019-01-30  Tom Tromey  <tom@tromey.com>

        PR python/23615:
        * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
        (gdbpy_parse_and_eval): Likewise.
        * python/python-internal.h (gdbpy_allow_threads): New class.

2019-01-28  John Baldwin  <jhb@FreeBSD.org>

        * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
        (aarch64_fbsd_fpregmap): Move earlier.
        (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
        (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
        instead of individual calls to trad_frame_set_reg_addr.
        * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
        earlier.
        (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
        (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
        instead of individual calls to trad_frame_set_reg_addr.

2019-01-28  Alan Hayward  <alan.hayward@arm.com>

        * CONTRIBUTE: Replace contribution list with wiki link.

2019-01-25  Tom Tromey  <tom@tromey.com>

        * Makefile.in (GDB_CFLAGS): Don't add -I for common.

2019-01-25  Tom Tromey  <tom@tromey.com>

        * xtensa-linux-nat.c: Fix common/ includes.
        * xml-support.h: Fix common/ includes.
        * xml-support.c: Fix common/ includes.
        * x86-linux-nat.c: Fix common/ includes.
        * windows-nat.c: Fix common/ includes.
        * varobj.h: Fix common/ includes.
        * varobj.c: Fix common/ includes.
        * value.c: Fix common/ includes.
        * valops.c: Fix common/ includes.
        * utils.c: Fix common/ includes.
        * unittests/xml-utils-selftests.c: Fix common/ includes.
        * unittests/utils-selftests.c: Fix common/ includes.
        * unittests/unpack-selftests.c: Fix common/ includes.
        * unittests/tracepoint-selftests.c: Fix common/ includes.
        * unittests/style-selftests.c: Fix common/ includes.
        * unittests/string_view-selftests.c: Fix common/ includes.
        * unittests/scoped_restore-selftests.c: Fix common/ includes.
        * unittests/scoped_mmap-selftests.c: Fix common/ includes.
        * unittests/scoped_fd-selftests.c: Fix common/ includes.
        * unittests/rsp-low-selftests.c: Fix common/ includes.
        * unittests/parse-connection-spec-selftests.c: Fix common/
        includes.
        * unittests/optional-selftests.c: Fix common/ includes.
        * unittests/offset-type-selftests.c: Fix common/ includes.
        * unittests/observable-selftests.c: Fix common/ includes.
        * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
        * unittests/memrange-selftests.c: Fix common/ includes.
        * unittests/memory-map-selftests.c: Fix common/ includes.
        * unittests/lookup_name_info-selftests.c: Fix common/ includes.
        * unittests/function-view-selftests.c: Fix common/ includes.
        * unittests/environ-selftests.c: Fix common/ includes.
        * unittests/copy_bitwise-selftests.c: Fix common/ includes.
        * unittests/common-utils-selftests.c: Fix common/ includes.
        * unittests/cli-utils-selftests.c: Fix common/ includes.
        * unittests/array-view-selftests.c: Fix common/ includes.
        * ui-file.c: Fix common/ includes.
        * tui/tui-io.c: Fix common/ includes.
        * tracepoint.h: Fix common/ includes.
        * tracepoint.c: Fix common/ includes.
        * tracefile-tfile.c: Fix common/ includes.
        * top.h: Fix common/ includes.
        * top.c: Fix common/ includes.
        * thread.c: Fix common/ includes.
        * target/waitstatus.h: Fix common/ includes.
        * target/waitstatus.c: Fix common/ includes.
        * target.h: Fix common/ includes.
        * target.c: Fix common/ includes.
        * target-memory.c: Fix common/ includes.
        * target-descriptions.c: Fix common/ includes.
        * symtab.h: Fix common/ includes.
        * symfile.c: Fix common/ includes.
        * stap-probe.c: Fix common/ includes.
        * spu-linux-nat.c: Fix common/ includes.
        * sparc-nat.c: Fix common/ includes.
        * source.c: Fix common/ includes.
        * solib.c: Fix common/ includes.
        * solib-target.c: Fix common/ includes.
        * ser-unix.c: Fix common/ includes.
        * ser-tcp.c: Fix common/ includes.
        * ser-pipe.c: Fix common/ includes.
        * ser-base.c: Fix common/ includes.
        * selftest-arch.c: Fix common/ includes.
        * s12z-tdep.c: Fix common/ includes.
        * rust-exp.y: Fix common/ includes.
        * rs6000-aix-tdep.c: Fix common/ includes.
        * riscv-tdep.c: Fix common/ includes.
        * remote.c: Fix common/ includes.
        * remote-notif.h: Fix common/ includes.
        * remote-fileio.h: Fix common/ includes.
        * remote-fileio.c: Fix common/ includes.
        * regcache.h: Fix common/ includes.
        * regcache.c: Fix common/ includes.
        * record-btrace.c: Fix common/ includes.
        * python/python.c: Fix common/ includes.
        * python/py-type.c: Fix common/ includes.
        * python/py-inferior.c: Fix common/ includes.
        * progspace.h: Fix common/ includes.
        * producer.c: Fix common/ includes.
        * procfs.c: Fix common/ includes.
        * proc-api.c: Fix common/ includes.
        * printcmd.c: Fix common/ includes.
        * ppc-linux-nat.c: Fix common/ includes.
        * parser-defs.h: Fix common/ includes.
        * osdata.c: Fix common/ includes.
        * obsd-nat.c: Fix common/ includes.
        * nat/x86-linux.c: Fix common/ includes.
        * nat/x86-linux-dregs.c: Fix common/ includes.
        * nat/x86-dregs.h: Fix common/ includes.
        * nat/x86-dregs.c: Fix common/ includes.
        * nat/ppc-linux.c: Fix common/ includes.
        * nat/mips-linux-watch.h: Fix common/ includes.
        * nat/mips-linux-watch.c: Fix common/ includes.
        * nat/linux-waitpid.c: Fix common/ includes.
        * nat/linux-ptrace.h: Fix common/ includes.
        * nat/linux-ptrace.c: Fix common/ includes.
        * nat/linux-procfs.c: Fix common/ includes.
        * nat/linux-personality.c: Fix common/ includes.
        * nat/linux-osdata.c: Fix common/ includes.
        * nat/linux-namespaces.c: Fix common/ includes.
        * nat/linux-btrace.h: Fix common/ includes.
        * nat/linux-btrace.c: Fix common/ includes.
        * nat/fork-inferior.c: Fix common/ includes.
        * nat/amd64-linux-siginfo.c: Fix common/ includes.
        * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
        * nat/aarch64-linux.c: Fix common/ includes.
        * nat/aarch64-linux-hw-point.h: Fix common/ includes.
        * nat/aarch64-linux-hw-point.c: Fix common/ includes.
        * namespace.h: Fix common/ includes.
        * mips-linux-tdep.c: Fix common/ includes.
        * minsyms.c: Fix common/ includes.
        * mi/mi-parse.h: Fix common/ includes.
        * mi/mi-main.c: Fix common/ includes.
        * mi/mi-cmd-env.c: Fix common/ includes.
        * memrange.h: Fix common/ includes.
        * memattr.c: Fix common/ includes.
        * maint.h: Fix common/ includes.
        * maint.c: Fix common/ includes.
        * main.c: Fix common/ includes.
        * machoread.c: Fix common/ includes.
        * location.c: Fix common/ includes.
        * linux-thread-db.c: Fix common/ includes.
        * linux-nat.c: Fix common/ includes.
        * linux-fork.c: Fix common/ includes.
        * inline-frame.c: Fix common/ includes.
        * infrun.c: Fix common/ includes.
        * inflow.c: Fix common/ includes.
        * inferior.h: Fix common/ includes.
        * inferior.c: Fix common/ includes.
        * infcmd.c: Fix common/ includes.
        * inf-ptrace.c: Fix common/ includes.
        * inf-child.c: Fix common/ includes.
        * ia64-linux-nat.c: Fix common/ includes.
        * i387-tdep.c: Fix common/ includes.
        * i386-tdep.c: Fix common/ includes.
        * i386-linux-tdep.c: Fix common/ includes.
        * i386-linux-nat.c: Fix common/ includes.
        * i386-go32-tdep.c: Fix common/ includes.
        * i386-fbsd-tdep.c: Fix common/ includes.
        * i386-fbsd-nat.c: Fix common/ includes.
        * guile/scm-type.c: Fix common/ includes.
        * guile/guile.c: Fix common/ includes.
        * go32-nat.c: Fix common/ includes.
        * gnu-nat.c: Fix common/ includes.
        * gdbthread.h: Fix common/ includes.
        * gdbarch-selftests.c: Fix common/ includes.
        * gdb_usleep.c: Fix common/ includes.
        * gdb_select.h: Fix common/ includes.
        * gdb_bfd.c: Fix common/ includes.
        * gcore.c: Fix common/ includes.
        * fork-child.c: Fix common/ includes.
        * findvar.c: Fix common/ includes.
        * fbsd-nat.c: Fix common/ includes.
        * event-top.c: Fix common/ includes.
        * event-loop.c: Fix common/ includes.
        * dwarf2read.c: Fix common/ includes.
        * dwarf2loc.c: Fix common/ includes.
        * dwarf2-frame.c: Fix common/ includes.
        * dwarf-index-cache.c: Fix common/ includes.
        * dtrace-probe.c: Fix common/ includes.
        * disasm-selftests.c: Fix common/ includes.
        * defs.h: Fix common/ includes.
        * csky-tdep.c: Fix common/ includes.
        * cp-valprint.c: Fix common/ includes.
        * cp-support.h: Fix common/ includes.
        * cp-support.c: Fix common/ includes.
        * corelow.c: Fix common/ includes.
        * completer.h: Fix common/ includes.
        * completer.c: Fix common/ includes.
        * compile/compile.c: Fix common/ includes.
        * compile/compile-loc2c.c: Fix common/ includes.
        * compile/compile-cplus-types.c: Fix common/ includes.
        * compile/compile-cplus-symbols.c: Fix common/ includes.
        * command.h: Fix common/ includes.
        * cli/cli-dump.c: Fix common/ includes.
        * cli/cli-cmds.c: Fix common/ includes.
        * charset.c: Fix common/ includes.
        * build-id.c: Fix common/ includes.
        * btrace.h: Fix common/ includes.
        * btrace.c: Fix common/ includes.
        * breakpoint.h: Fix common/ includes.
        * breakpoint.c: Fix common/ includes.
        * ax.h: 
        (enum agent_op): Fix common/ includes.
        * ax-general.c (struct aop_map): Fix common/ includes.
        * ax-gdb.c: Fix common/ includes.
        * auxv.c: Fix common/ includes.
        * auto-load.c: Fix common/ includes.
        * arm-tdep.c: Fix common/ includes.
        * arch/riscv.c: Fix common/ includes.
        * arch/ppc-linux-common.c: Fix common/ includes.
        * arch/i386.c: Fix common/ includes.
        * arch/arm.c: Fix common/ includes.
        * arch/arm-linux.c: Fix common/ includes.
        * arch/arm-get-next-pcs.c: Fix common/ includes.
        * arch/amd64.c: Fix common/ includes.
        * arch/aarch64.c: Fix common/ includes.
        * arch/aarch64-insn.c: Fix common/ includes.
        * arch-utils.c: Fix common/ includes.
        * amd64-windows-tdep.c: Fix common/ includes.
        * amd64-tdep.c: Fix common/ includes.
        * amd64-sol2-tdep.c: Fix common/ includes.
        * amd64-obsd-tdep.c: Fix common/ includes.
        * amd64-nbsd-tdep.c: Fix common/ includes.
        * amd64-linux-tdep.c: Fix common/ includes.
        * amd64-linux-nat.c: Fix common/ includes.
        * amd64-fbsd-tdep.c: Fix common/ includes.
        * amd64-fbsd-nat.c: Fix common/ includes.
        * amd64-dicos-tdep.c: Fix common/ includes.
        * amd64-darwin-tdep.c: Fix common/ includes.
        * agent.c: Fix common/ includes.
        * ada-lang.h: Fix common/ includes.
        * ada-lang.c: Fix common/ includes.
        * aarch64-tdep.c: Fix common/ includes.

2019-01-25  Tom Tromey  <tom@tromey.com>

        * common/create-version.sh: Use common/version.h.

2019-01-24  Pedro Alves  <palves@redhat.com>

        * infrun.c (signal_stop, signal_print, signal_program)
        (signal_catch, signal_pass): Now arrays instead of pointers.
        (update_signals_program_target, do_target_resume)
        (signal_catch_update, handle_command, _initialize_infrun): Adjust.
        * linux-nat.c (linux_nat_target::pass_signals)
        (linux_nat_target::create_inferior, linux_nat_target::attach):
        Adjust.
        * linux-nat.h (linux_nat_target::pass_signals): Adjust.
        * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
        * procfs.c (procfs_target::pass_signals): Adjust.
        * record-full.c (record_full_target::resume): Adjust.
        * remote.c (remote_target::pass_signals)
        (remote_target::program_signals): Adjust.
        * target-debug.h (target_debug_print_signals): Now takes a
        gdb::array_view as parameter.  Adjust.
        * target.h (target_ops) <pass_signals, program_signals>: Replace
        pointer and length parameters with gdb::array_view.
        (target_pass_signals, target_program_signals): Likewise.
        * target-delegates.c: Regenerate.

2019-01-24  Pedro Alves  <palves@redhat.com>

        * common/forward-scope-exit.h
        (forward_scope_exit::forward_scope_exit): Pass arguments to
        m_bind_function directly, instead of creating a std::bind and
        copying that.

2019-01-24  Alan Hayward  <alan.hayward@arm.com>

        * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
        for static members.
        (pass_in_v_vfp_candidate): Likewise.

2019-01-23  Tom Tromey  <tom@tromey.com>
            Pedro Alves  <palves@redhat.com>

        * regcache.c (class regcache_invalidator): Remove.
        (regcache::raw_write): Use make_scope_exit.

2019-01-23  Tom Tromey  <tom@tromey.com>

        * ui-out.h (class ui_out_emit_type): Update comment.

2019-01-23  Tom Tromey  <tom@tromey.com>

        * infrun.c (fetch_inferior_event): Update comment.

2019-01-23  Tom Tromey  <tom@tromey.com>
            Pedro Alves  <palves@redhat.com>

        * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
        parameter.
        (fetch_inferior_event): Use SCOPE_EXIT.


2019-01-23  Tom Tromey  <tom@tromey.com>
            Pedro Alves  <palves@redhat.com>

        * infrun.c (disable_thread_events): Delete.
        (stop_all_threads): Use SCOPE_EXIT.

2019-01-23  Tom Tromey  <tom@tromey.com>
            Pedro Alves  <palves@redhat.com>

        * symfile.c: Include forward-scope-exit.h.
        (clear_symtab_users_cleanup): Replace forward declaration with
        a FORWARD_SCOPE_EXIT.
        (syms_from_objfile_1): Use the forward_scope_exit and
        gdb::optional instead of cleanup_function.
        (reread_symbols): Use the forward_scope_exit instead of
        cleanup_function.
        (clear_symtab_users_cleanup): Remove function.

2019-01-23  Tom Tromey  <tom@tromey.com>
            Pedro Alves  <palves@redhat.com>

        * linux-nat.c: Include scope-exit.h.
        (cleanup_target_stop): Remove.
        (linux_nat_target::static_tracepoint_markers_by_strid): Use
        SCOPE_EXIT.

2019-01-23  Tom Tromey  <tom@tromey.com>
            Pedro Alves  <palves@redhat.com>

        * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
        (call_function_by_hand_dummy): Use SCOPE_EXIT.

2019-01-23  Tom Tromey  <tom@tromey.com>
            Andrew Burgess  <andrew.burgess@embecosm.com>
            Pedro Alves  <palves@redhat.com>

        * infrun.c (fetch_inferior_event): Use scope_exit.
        * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
        * top.c (execute_command): Use scope_exit.
        * breakpoint.c (bpstat_do_actions): Use scope_exit.
        * utils.c (do_bpstat_clear_actions_cleanup)
        (make_bpstat_clear_actions_cleanup): Remove.

2019-01-23  Tom Tromey  <tom@tromey.com>
            Pedro Alves  <palves@redhat.com>

        * infrun.c: Include "common/scope-exit.h"
        (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
        (wait_for_inferior): Use SCOPE_EXIT.
        (fetch_inferior_event): Use scope_exit.

2019-01-23  Tom Tromey  <tom@tromey.com>
            Pedro Alves  <palves@redhat.com>

        * breakpoint.c (create_breakpoint): Remove cleanup.

2019-01-23  Tom Tromey  <tom@tromey.com>
            Andrew Burgess  <andrew.burgess@embecosm.com>
            Pedro Alves  <palves@redhat.com>

2019-01-23  Pedro Alves  <palves@redhat.com>

        * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.

2019-01-23  Pedro Alves  <palves@redhat.com>
            Andrew Burgess  <andrew.burgess@embecosm.com>

        * gdbthread.h: Include "common/forward-scope-exit.h".
        (scoped_finish_thread_state): Redefine custom class in terms of
        forward_scope_exit.

2019-01-23  Pedro Alves  <palves@redhat.com>
            Andrew Burgess  <andrew.burgess@embecosm.com>

        * common/forward-scope-exit.h: New file.

2019-01-23  Pedro Alves  <palves@redhat.com>
            Andrew Burgess  <andrew.burgess@embecosm.com>
            Tom Tromey  <tom@tromey.com>

        * common/scope-exit.h: New file.

2019-01-23  Pedro Alves  <palves@redhat.com>

        * common/preprocessor.h (ESC): Rename to ...
        (ESC_PARENS): ... this.
        * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
        (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.

2019-01-23  Tom Tromey  <tom@tromey.com>

        * language.h (class scoped_switch_to_sym_language_if_auto):
        Initialize m_lang in both cases.

2019-01-23  Alan Hayward  <alan.hayward@arm.com>

        * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
        with XCNEW.

2019-01-22  Tom Tromey  <tom@tromey.com>

        * corelow.c: Do not include sys/file.h.

2019-01-22  Tom Tromey  <tom@tromey.com>

        * tui/tui-wingeneral.h: Include gdb_curses.h.

2019-01-22  Tom Tromey  <tom@tromey.com>

        * source-cache.h (class source_cache) <get_source_lines,
        get_plain_source_lines, extract_lines>: Rename "lines" parameter.

2019-01-22  Tom Tromey  <tom@tromey.com>

        * remote-fileio.h (struct remote_target): Declare.

2019-01-22  Tom Tromey  <tom@tromey.com>

        * python/py-arch.c: Do not include py-ref.h.
        * python/py-bpevent.c: Do not include py-ref.h.
        * python/py-cmd.c: Do not include py-ref.h.
        * python/py-continueevent.c: Do not include py-ref.h.
        * python/py-event.h: Do not include py-ref.h.
        * python/py-evtregistry.c: Do not include py-ref.h.
        * python/py-finishbreakpoint.c: Do not include py-ref.h.
        * python/py-frame.c: Do not include py-ref.h.
        * python/py-framefilter.c: Do not include py-ref.h.
        * python/py-function.c: Do not include py-ref.h.
        * python/py-infevents.c: Do not include py-ref.h.
        * python/py-linetable.c: Do not include py-ref.h.
        * python/py-objfile.c: Do not include py-ref.h.
        * python/py-param.c: Do not include py-ref.h.
        * python/py-prettyprint.c: Do not include py-ref.h.
        * python/py-progspace.c: Do not include py-ref.h.
        * python/py-symbol.c: Do not include py-ref.h.
        * python/py-symtab.c: Do not include py-ref.h.
        * python/py-type.c: Do not include py-ref.h.
        * python/py-unwind.c: Do not include py-ref.h.
        * python/py-utils.c: Do not include py-ref.h.
        * python/py-value.c: Do not include py-ref.h.
        * python/py-varobj.c: Do not include py-ref.h.
        * python/py-xmethods.c: Do not include py-ref.h.
        * python/python.c: Do not include py-ref.h.
        * varobj.c: Do not include py-ref.h.

2019-01-22  Tom Tromey  <tom@tromey.com>

        * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
        keyword for bcache.

2019-01-22  Tom Tromey  <tom@tromey.com>

        * compile/compile-cplus-types.c: Remove a comment by #include.

2019-01-22  Tom Tromey  <tom@tromey.com>

        * compile/gcc-c-plugin.h: Include compile-internal.h.

2019-01-22  Tom Tromey  <tom@tromey.com>

        * stabsread.c (EXTERN): Do not define.
        (symnum, next_symbol_text_func, processing_gcc_compilation)
        (within_function, global_sym_chain, global_stabs)
        (previous_stab_code, this_object_header_files)
        (n_this_object_header_files)
        (n_allocated_this_object_header_files): Define.
        * stabsread.h (EXTERN): Never define.  Use "extern".

2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
        history_value.

2019-01-21  Tom Tromey  <tom@tromey.com>

        * ui-out.c: Fix includes.
        * tui/tui-source.c: Fix includes.
        * target.c: Fix includes.
        * remote.c: Fix includes.
        * regcache.c: Fix includes.
        * python/py-block.c: Fix includes.
        * printcmd.c: Fix includes.
        * or1k-tdep.c: Fix includes.
        * mi/mi-main.c: Fix includes.
        * m32r-tdep.c: Fix includes.
        * csky-tdep.c: Fix includes.
        * compile/compile-cplus-types.c: Fix includes.
        * cli/cli-interp.c: Fix includes.

2019-01-21  Alan Hayward  <alan.hayward@arm.com>

        * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
        for padding.

2019-01-16  Tom Tromey  <tom@tromey.com>

        * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
        earlier.
        (struct objfile) <msymbols_range>: Move from top level.
        <msymbols>: New method.
        (class objfile_msymbols): Remove.
        * symtab.c (default_collect_symbol_completion_matches_break_on):
        Update.
        * symmisc.c (dump_msymbols): Update.
        * stabsread.c (scan_file_globals): Update.
        * objc-lang.c (info_selectors_command, info_classes_command)
        (find_methods): Update.
        * minsyms.c (find_solib_trampoline_target): Update.
        * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
        * coffread.c (coff_symfile_read): Update.
        * ada-lang.c (ada_lookup_simple_minsym)
        (ada_collect_symbol_completion_matches): Update.

2019-01-16  Tom Tromey  <tom@tromey.com>

        * objfiles.h (class objfile_msymbols) <iterator>: Change argument
        type.  Remove no-argument constructor.
        <iterator::operator++>: Simplify.
        <begin>: Update.
        <end>: Use minimal_symbol_count.

2019-01-16  Tom Tromey  <tom@tromey.com>

        * objfiles.h (struct objfile) <psymtabs>: New method.
        (class objfile_psymtabs): Remove.
        * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
        typedef.
        <range>: New method.
        (require_partial_symbols): Change return type.
        * psymtab.c (require_partial_symbols)
        (psym_expand_symtabs_matching): Update.
        * mdebugread.c (parse_partial_symbols): Update.
        * dbxread.c (dbx_end_psymtab): Update.

2019-01-15  Tom Tromey  <tom@tromey.com>

        * symtab.c (lookup_objfile_from_block)
        (lookup_symbol_in_objfile_symtabs)
        (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
        (find_line_symtab, info_sources_command)
        (default_collect_symbol_completion_matches_break_on)
        (make_source_files_completion_list): Update.
        * symmisc.c (print_objfile_statistics, dump_objfile)
        (maintenance_print_symbols, maintenance_info_symtabs)
        (maintenance_check_symtabs, maintenance_info_line_tables):
        Update.
        * source.c (select_source_symtab)
        (forget_cached_source_info_for_objfile): Update.
        * objfiles.h (class objfile_compunits): Remove.
        (struct objfile) <compunits_range>: New typedef.
        (compunits): New method.
        * objfiles.c (objfile_relocate1): Update.
        * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
        * maint.c (count_symtabs_and_blocks): Update.
        * linespec.c (iterate_over_all_matching_symtabs): Update.
        * cp-support.c (add_symbol_overload_list_qualified): Update.
        * coffread.c (coff_symtab_read): Update.
        * ada-lang.c (add_nonlocal_symbols)
        (ada_collect_symbol_completion_matches)
        (ada_add_global_exceptions): Update.

2019-01-15  Tom Tromey  <tom@tromey.com>

        * progspace.h (program_space) <objfiles_safe_range>: New
        typedef.
        <objfiles_safe>: New method.
        * objfiles.h (class all_objfiles_safe): Remove.
        * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
        * jit.c (jit_inferior_exit_hook): Update.

2019-01-17  Tom Tromey  <tom@tromey.com>

        * progspace.h (program_space) <objfiles_range>: New typedef.
        <objfiles>: New method.
        <objfiles_head>: Rename from objfiles.
        (object_files): Update.
        * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
        * guile/scm-pretty-print.c
        (ppscm_find_pretty_printer_from_objfiles): Update.
        * guile/scm-objfile.c (gdbscm_objfiles): Update.
        * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
        Update.
        * python/py-progspace.c (pspy_get_objfiles): Update.
        * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
        Update.
        * python/py-objfile.c (objfpy_lookup_objfile_by_name)
        (objfpy_lookup_objfile_by_build_id): Update.
        * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
        * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
        Update.
        * symtab.c (iterate_over_symtabs, matching_obj_sections)
        (expand_symtab_containing_pc, lookup_objfile_from_block)
        (lookup_static_symbol, basic_lookup_transparent_type)
        (find_pc_sect_compunit_symtab, find_symbol_at_address)
        (find_line_symtab, info_sources_command)
        (default_collect_symbol_completion_matches_break_on)
        (make_source_files_completion_list, find_main_name): Update.
        * symmisc.c (print_symbol_bcache_statistics)
        (print_objfile_statistics, maintenance_print_symbols)
        (maintenance_print_msymbols, maintenance_print_objfiles)
        (maintenance_info_symtabs, maintenance_check_symtabs)
        (maintenance_expand_symtabs, maintenance_info_line_tables):
        Update.
        * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
        (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
        (map_overlay_command, unmap_overlay_command)
        (simple_overlay_update, expand_symtabs_matching)
        (map_symbol_filenames): Update.
        * symfile-debug.c (set_debug_symfile): Update.
        * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
        Update.
        * source.c (select_source_symtab, forget_cached_source_info):
        Update.
        * solib.c (solib_read_symbols): Update.
        * solib-spu.c (append_ocl_sos): Update.
        * psymtab.c (maintenance_print_psymbols)
        (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
        * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
        * printcmd.c (info_symbol_command): Update.
        * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
        Update.
        * objfiles.h (class all_objfiles): Remove.
        * objfiles.c (have_partial_symbols, have_full_symbols)
        (have_minimal_symbols, qsort_cmp, update_section_map)
        (shared_objfile_contains_address_p)
        (default_iterate_over_objfiles_in_search_order): Update.
        * objc-lang.c (info_selectors_command, info_classes_command)
        (find_methods): Update.
        * minsyms.c (find_solib_trampoline_target): Update.
        * maint.c (maintenance_info_sections)
        (maintenance_translate_address, count_symtabs_and_blocks):
        Update.
        * main.c (captured_main_1): Update.
        * linux-thread-db.c (try_thread_db_load_from_pdir)
        (has_libpthread): Update.
        * linespec.c (iterate_over_all_matching_symtabs)
        (search_minsyms_for_name): Update.
        * jit.c (jit_find_objf_with_entry_addr): Update.
        * hppa-tdep.c (find_unwind_entry)
        (hppa_lookup_stub_minimal_symbol): Update.
        * gcore.c (gcore_create_callback, objfile_find_memory_regions):
        Update.
        * elfread.c (elf_gnu_ifunc_resolve_by_cache)
        (elf_gnu_ifunc_resolve_by_got): Update.
        * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
        * dwarf-index-write.c (save_gdb_index_command): Update.
        * cp-support.c (add_symbol_overload_list_qualified): Update.
        * breakpoint.c (create_overlay_event_breakpoint)
        (create_longjmp_master_breakpoint)
        (create_std_terminate_master_breakpoint)
        (create_exception_master_breakpoint): Update.
        * blockframe.c (find_pc_partial_function): Update.
        * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
        (ada_collect_symbol_completion_matches)
        (ada_add_global_exceptions): Update.

2019-01-17  Tom Tromey  <tom@tromey.com>

        * solib-target.c (lm_info_target_p): Remove typedef.  Don't
        declare VEC.
        (solib_target_parse_libraries): Change return type.
        (library_list_start_segment, library_list_start_section)
        (library_list_end_library, library_list_start_library); Update.
        (solib_target_free_library_list): Remove.
        (solib_target_parse_libraries): Remove cleanup.  Change return
        type.
        (solib_target_current_sos): Update.

2019-01-17  Tom Tromey  <tromey@bapiya>

        * valprint.c: Replace "the the" with "the".
        * symtab.c: Replace "the the" with "the".
        * solib.c: Replace "the the" with "the".
        * solib-dsbt.c: Replace "the the" with "the".
        * linespec.c: Replace "the the" with "the".
        * dwarf2loc.h: Replace "the the" with "the".
        * amd64-windows-tdep.c: Replace "the the" with "the".
        * aarch64-tdep.c: Replace "the the" with "the".

2019-01-16  Keith Seitz  <keiths@redhat.com>

        PR gdb/23773
        * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
        <builder>: Rename to ..
        <m_builder>: ... this and make private.
        (dwarf2_cu::get_builder): New method.  Change all users of
        `builder' to use this method.
        (dwarf2_start_symtab): Move to ...
        (dwarf2_cu::start_symtab): ... here.  Update all callers
        (setup_type_unit_groups): Move to ...
        (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
        callers.
        (dwarf2_cu::reset_builder): New method.
        (process_full_compunit, process_full_type_unit): Use
        dwarf2_cu::reset_builder.
        (follow_die_offset): Record the ancestor CU if it is different
        from the followed DIE's CU.
        (follow_die_sig_1): Likewise.

2019-01-15  Tom Tromey  <tom@tromey.com>

        * remote.c (class remote_state) <buf>: Now a char_vector.
        <buf_size>: Remove.
        (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
        parameter.
        (remote_target::getpkt_or_notif_sane_1)
        (remote_target::getpkt_sane)
        (remote_target::getpkt_or_notif_sane): Likewise.
        (class remote_target) <putpkt>: New overload.
        (remote_target::read_frame): Change type of "buf_p".  Remove
        sizeof_p parameter.
        (packet_ok): New overload.
        (packet_check_result): New overload.
        Update all uses.

2019-01-14  Tom Tromey  <tom@tromey.com>

        * remote-notif.c (handle_notification, remote_notif_ack)
        (remote_notif_parse): Make "buf" const.
        * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
        const.
        (remote_notif_parse, remote_notif_ack, handle_notification):
        Likewise.
        * remote.c (remote_notif_stop_parse): Make "buf" const.
        (remote_target::remote_parse_stop_reply): Make "buf" const.
        (remote_notif_stop_ack): Make "buf" const.

2019-01-14  Tom Tromey  <tom@tromey.com>

        * remote.c (remote_console_output): Make parameter const.

2019-01-14  Tom Tromey  <tom@tromey.com>

        * target-debug.h (target_debug_print_signals): Constify.
        * nto-procfs.c (nto_procfs_target::pass_signals): Update.
        * procfs.c (procfs_target::pass_signals): Update.
        * linux-nat.c (linux_nat_target::pass_signals): Update.
        * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
        * target-delegates.c: Rebuild.
        * remote.c (remote_target::program_signals): Update.
        (remote_target::pass_signals): Update.
        * target.c (target_pass_signals): Constify argument.
        (target_program_signals): Likewise.
        * target.h (struct target_ops) <pass_signals, program_signals>:
        Constify argument.
        (target_pass_signals, target_program_signals): Constify argument.

2019-01-14  Tom Tromey  <tom@tromey.com>

        PR tui/28819:
        * tui/tui-io.c (gdb_wgetch): Print \r when needed.

2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>

        * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
        field.
        * rs6000-tdep.c: Include reggroups.h.
        (IS_V_ALIAS_PSEUDOREG): Define.
        (rs6000_register_name): Return names for the "vX" aliases.
        (rs6000_pseudo_register_type): Return type for the "vX" aliases.
        (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
        aliases.  Call default_register_reggroup_p for all other
        pseudo-registers.
        (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
        New functions.
        (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
        Handle "vX" aliases.
        (v_alias_pseudo_register_collect): New function.
        (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
        (rs6000_gdbarch_init): Initialize "vX" aliases as
        pseudo-registers.  Restore registration of
        rs6000_pseudo_register_reggroup_p with
        set_tdesc_pseudo_register_reggroup_p.

2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>

        * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
        tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
        set_gdbarch_num_pseudo_regs.

2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
        Remove arg prefixname, add do_set and do_show.
        Add member functions set_list and show_list.
        * cli/cli-style.c (class cli_style_option): Update accordingly.
        (style_set_list): Move to file scope.
        (style_show_list): Likewise.
        (set_style): Call help_list.
        (show_style): Call cmd_show_list.
        (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
        Update to use the new macro.

2019-10-12  Joel Brobecker  <brobecker@adacore.com>

        * ada-lang.c (_initialize_ada_language): Expand the help text
        for the "catch exception" command.

2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * symtab.c (matching_obj_sections): Initialize obj,
        declare it closer to its usage.

2019-01-10  Tom Tromey  <tom@tromey.com>

        * thread-iter.h (inf_threads_iterator): Use next_iterator.
        (basic_inf_threads_range): Remove.
        (inf_threads_range, inf_non_exited_threads_range)
        (safe_inf_threads_range): Use next_adapter.

2019-01-10  Keith Seitz  <keiths@redhat.com>

        PR gdb/23712
        PR symtab/23010
        * dwarf2read.c (dw2_add_symbol_to_list): Remove.
        (fixup_go_packaging, new_symbol): Use add_symbol_to_list.

2019-01-10  Keith Seitz  <keiths@redhat.com>

        PR gdb/23712
        PR symtab/23010
        * dictionary.c (pending_to_vector): Remove.
        (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
        Remove _1 suffix, replacing functions of the same name.  Update
        all callers.
        (dict_create_hashed, dict_create_hashed_expandable)
        (dict_create_linear, dict_create_linear_expandable, dict_free)
        (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
        Make functions static.

2019-01-10  Keith Seitz  <keiths@redhat.com>

        PR gdb/23712
        PR symtab/23010
        * dictionary.h (struct dictionary): Replace declaration with
        multidictionary.
        (dict_create_hashed, dict_create_hashed_expandable)
        (dict_create_linear, dict_create_linear_expandable)
        (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
        (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
        (dict_iter_match_next, dict_size): Rename to "mdict_" versions
        taking multidictionary argument.
        [ALL_DICT_SYMBOLS]: Update for multidictionary.
        * block.h (struct block) <dict>: Change to multidictionary
        and rename `multidict'.
        * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
        symmisc.c: Update all dictionary references to multidictionary.

2019-01-10  Keith Seitz  <keiths@redhat.com>

        PR gdb/23712
        PR symtab/23010
        * dictionary.c: Include unordered_map.
        (pending_to_vector): New function.
        (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
        Rewrite the non-"_1" functions to take vector instead
        of linked list.
        (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
        "new" _1 versions of the same name.
        (multidictionary): Define.
        (std::hash<enum language): New definition.
        (collate_pending_symbols_by_language, mdict_create_hashed)
        (mdict_create_hashed_expandable, mdict_create_linear)
        (mdict_create_linear_expandable, mdict_free)
        (find_language_dictionary, create_new_language_dictionary)
        (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
        (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
        (mdict_size, mdict_empty): New functions.
        * dictionary.h (mdict_iterator): Define.

2019-01-10  Pedro Alves  <palves@redhat.com>

        * breakpoint.c (read_uploaded_action)
        (create_tracepoint_from_upload): Adjust to use
        gdb::unique_xmalloc_ptr.
        * ctf.c (ctf_write_uploaded_tp):
        (SET_ARRAY_FIELD): Use emplace_back.
        (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
        * tracefile-tfile.c (tfile_write_uploaded_tp):
        * tracepoint.c (parse_tracepoint_definition): Adjust to use
        gdb::unique_xmalloc_ptr.
        * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
        at_string, cond_string, cmd_strings>: Replace char pointers
        with gdb::unique_xmalloc_ptr.

2019-01-10  Pedro Alves  <palves@redhat.com>

        * solib-target.c (library_list_start_library): Don't xstrdup name.

2019-01-10  Pedro Alves  <palves@redhat.com>

        * mdebugread.c (parse_partial_symbols): Use
        gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.

2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>

        * linux-fork.c (scoped_switch_fork_info)
        <~scoped_switch_fork_info>: Fix incorrect variable name.

2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>

        * linux-fork.c (scoped_switch_fork_info)
        <scoped_switch_fork_info>: Make explicit.
        <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.

2019-01-10  Tom Tromey  <tom@tromey.com>

        * objfiles.h (objfile::reset_psymtabs): Update.
        * objfiles.c (objfile::objfile): Update.
        * psymtab.h (psymtab_storage::obstack): Update.
        (psymtab_storage::m_obstack): Use gdb::optional.
        (class psymtab_storage): Update comment.  Remove objfile
        parameter.
        * psymtab.c (psymtab_storage::psymtab_storage): Update.

2019-01-10  Tom Tromey  <tom@tromey.com>

        * psymtab.h (psymtab_storage::allocate_psymtab): New method.
        <free_psymtabs>: Now private.
        * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
        (allocate_psymtab): Use new method.

2019-01-10  Tom Tromey  <tom@tromey.com>

        * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
        * psymtab.h (psymtab_storage::allocate_dependencies): New method.
        * mdebugread.c (parse_partial_symbols): Use
        allocate_dependencies.
        * dwarf2read.c (dwarf2_create_include_psymtab): Use
        allocate_dependencies.
        (process_psymtab_comp_unit_reader)
        (build_type_psymtab_dependencies): Likewise.
        * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.

2019-01-10  Tom Tromey  <tom@tromey.com>

        * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
        PSYMBOL_SET_LANGUAGE.
        (allocate_psymtab): Allocate psymtab on the psymtab obstack.

2019-01-10  Tom Tromey  <tom@tromey.com>

        * psymtab.h (psymtab_storage::obstack): New method.
        <m_obstack>: Rename from obstack; now private.
        * psymtab.c (psymtab_storage): Update.
        * dwarf2read.c (create_addrmap_from_index)
        (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
        Update.

2019-01-10  Tom Tromey  <tom@tromey.com>

        * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
        * objfiles.h (objfile::reset_psymtabs): New method.

2019-01-10  Tom Tromey  <tom@tromey.com>

        * symmisc.c (print_symbol_bcache_statistics): Update.
        (print_objfile_statistics): Update.
        * symfile.c (reread_symbols): Update.
        * psymtab.h (class psymtab_storage): New.
        * psymtab.c (psymtab_storage): New constructor.
        (~psymtab_storage): New destructor.
        (require_partial_symbols): Update.
        (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
        (find_pc_sect_psymtab, find_pc_sect_psymbol)
        (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
        (psym_dump, recursively_search_psymtabs, psym_has_symbols)
        (psym_find_compunit_symtab_by_address, sort_pst_symbols)
        (start_psymtab_common, end_psymtab_common)
        (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
        (allocate_psymtab): Update.
        (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
        Update.
        (dump_psymtab_addrmap, maintenance_print_psymbols)
        (maintenance_check_psymtabs): Update.
        (class objfile_psymtabs): Move to objfiles.h.
        * psympriv.h (discard_psymtab): Now inline.
        (psymtab_discarder::psymtab_discarder): Update.
        (psymtab_discarder::~psymtab_discarder): Update.
        (ALL_OBJFILE_PSYMTABS): Rewrite.
        * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
        free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
        Remove fields.
        <partial_symtabs>: New field.
        (class objfile_psymtabs): Move from psymtab.h.  Update.
        * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
        psymbol_cache.
        (objfile::~objfile): Don't destroy psymbol_cache.
        * mdebugread.c (parse_partial_symbols): Update.
        * dwarf2read.c (create_addrmap_from_index)
        (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
        (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
        (add_partial_subprogram, dwarf2_ranges_read): Update.
        * dwarf-index-write.c (write_address_map)
        (write_one_signatured_type, recursively_write_psymbols)
        (class debug_names, class debug_names, write_psymtabs_to_index):
        Update.

2019-01-10  Tom Tromey  <tom@tromey.com>

        * symtab.h (SYMBOL_SET_NAMES): Update.
        (symbol_set_names): Update.
        (MSYMBOL_SET_NAMES): Update.
        * symtab.c (symbol_set_names): Change argument to be an
        objfile_per_bfd_storage.
        * psymtab.c (add_psymbol_to_bcache): Update.
        * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.

2019-01-10  Tom Tromey  <tom@tromey.com>

        * symtab.c (create_demangled_names_hash): Change argument to be an
        objfile_per_bfd_storage.
        (symbol_set_names): Update.

2019-01-10  Tom Tromey  <tom@tromey.com>

        * xcoffread.c (xcoff_initial_scan): Unconditionally call
        init_psymbol_list.
        * psymtab.c (init_psymbol_list): Do nothing if already called.
        * psympriv.h (init_psymbol_list): Add comment.
        * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
        init_psymbol_list.
        * dbxread.c (dbx_symfile_read): Unconditionally call
        init_psymbol_list.

2019-01-10  Tom Tromey  <tom@tromey.com>

        * xcoffread.c (scan_xcoff_symtab): Update.
        * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
        "where".
        * mdebugread.c (parse_partial_symbols)
        (handle_psymbol_enumerators): Update.
        * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
        * dbxread.c (read_dbx_symtab): Update.
        * psympriv.h (psymbol_placement): New enum.
        (add_psymbol_to_list): Update.

2019-01-10  Tom Tromey  <tom@tromey.com>

        * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
        static_psymbols parameters.
        (scan_xcoff_symtab): Update.
        * psymtab.c (start_psymtab_common): Remove global_psymbols and
        static_psymbols parameters.
        * psympriv.h (start_psymtab_common): Update.
        * mdebugread.c (parse_partial_symbols): Update.
        * dwarf2read.c (create_partial_symtab): Update.
        * dbxread.c (read_dbx_symtab): Update.
        (start_psymtab): Remove global_psymbols and static_psymbols
        parameters.

2019-01-10  Tom Tromey  <tom@tromey.com>

        * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
        * psymtab.c (allocate_psymtab): Add comment.
        * psympriv.h (allocate_psymtab): Add comment.
        * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
        initializations.
        * dbxread.c (dbx_end_psymtab): Remove some initializations.

2019-01-10  Tom Tromey  <tom@tromey.com>

        * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
        Don't declare.
        * mipsread.c: Include mdebugread.h.
        * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
        Declare.
        * elfread.c: Include mdebugread.h.

2019-01-09  Tom Tromey  <tom@tromey.com>

        * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
        * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
        * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
        (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
        (psym_lookup_symbol, psym_find_last_source_symtab)
        (psym_forget_cached_source_info, psym_print_stats)
        (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
        (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
        (psym_map_matching_symbols, psym_expand_symtabs_matching)
        (psym_find_compunit_symtab_by_address)
        (maintenance_print_psymbols, maintenance_info_psymtabs)
        (maintenance_check_psymtabs): Use ranged for.
        * psymtab.h (class objfile_psymtabs): New.
        (require_partial_symbols): Return objfile_psymtabs.
        * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.

2019-01-09  Tom Tromey  <tom@tromey.com>

        * symfile.c (overlay_invalidate_all, find_pc_overlay)
        (find_pc_mapped_section, list_overlays_command)
        (map_overlay_command, unmap_overlay_command)
        (simple_overlay_update): Use all_objfiles.
        * spu-tdep.c (spu_overlay_update): Use all_objfiles.
        * printcmd.c (info_symbol_command): Use all_objfiles.
        * objfiles.h (ALL_OBJSECTIONS): Remove.
        * maint.c (maintenance_translate_address): Use all_objfiles.
        * gcore.c (gcore_create_callback): Use all_objfiles.
        (objfile_find_memory_regions): Likewise.

2019-01-09  Tom Tromey  <tom@tromey.com>

        * symtab.c (find_line_symtab, info_sources_command)
        (make_source_files_completion_list): Use objfile_compunits.
        * source.c (select_source_symtab): Use objfile_compunits.
        * objfiles.h (struct objfile): Update comment.
        (ALL_OBJFILES): Remove.
        (ALL_FILETABS): Remove.
        * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
        objfile_compunits.

2019-01-09  Tom Tromey  <tom@tromey.com>

        * symmisc.c (print_objfile_statistics, dump_objfile)
        (maintenance_print_symbols): Use compunit_filetabs.
        * source.c (forget_cached_source_info_for_objfile): Use
        compunit_filetabs.
        * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
        (ALL_FILETABS): Use compunit_filetabs.
        * objfiles.c (objfile_relocate1): Use compunit_filetabs.
        * coffread.c (coff_symtab_read): Use compunit_filetabs.

2019-01-09  Tom Tromey  <tom@tromey.com>

        * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
        (compunit_filetabs): New.
        * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
        compunit_filetabs.
        (info_sources_command, make_source_files_completion_list): Remove
        declaration.
        * symmisc.c (print_objfile_statistics, dump_objfile)
        (maintenance_print_symbols): Remove declaration.
        (maintenance_info_symtabs): Use compunit_filetabs.
        (maintenance_info_line_tables): Likewise.
        * source.c (select_source_symtab): Change local variable name.
        (forget_cached_source_info_for_objfile): Remove declaration.
        * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
        * objfiles.c (objfile_relocate1): Remove declaration.
        * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
        declaration.
        * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
        * coffread.c (coff_symtab_read): Remove declaration.
        * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
        compunit_filetabs.

2019-01-09  Tom Tromey  <tom@tromey.com>

        * symtab.c (lookup_objfile_from_block)
        (find_pc_sect_compunit_symtab, search_symbols)
        (default_collect_symbol_completion_matches_break_on): Use
        objfile_compunits.
        * objfiles.h (ALL_COMPUNITS): Remove.
        * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
        * cp-support.c (add_symbol_overload_list_qualified): Use
        objfile_compunits.
        * ada-lang.c (ada_collect_symbol_completion_matches)
        (ada_add_global_exceptions): Use objfile_compunits.

2019-01-09  Tom Tromey  <tom@tromey.com>

        * source.c (select_source_symtab)
        (forget_cached_source_info_for_objfile): Remove declaration.
        * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
        declaration.
        * maint.c (count_symtabs_and_blocks): Remove declaration.
        * cp-support.c (add_symbol_overload_list_qualified): Remove
        declaration.
        * coffread.c (coff_symtab_read): Remove declaration.
        * symtab.c (lookup_symbol_in_objfile_symtabs)
        (basic_lookup_transparent_type_1): Use objfile_compunits.
        (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
        (info_sources_command, search_symbols)
        (default_collect_symbol_completion_matches_break_on)
        (make_source_files_completion_list): Remove declaration.
        * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
        (ada_collect_symbol_completion_matches)
        (ada_add_global_exceptions): Remove declaration.
        * linespec.c (iterate_over_all_matching_symtabs): Use
        objfile_compunits.
        * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
        (class objfile_compunits): New.
        (ALL_COMPUNITS): Use objfile_compunits.
        * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
        (maintenance_check_symtabs, maintenance_info_line_tables): Use
        objfile_compunits.
        * objfiles.c (objfile_relocate1): Use objfile_compunits.

2019-01-09  Tom Tromey  <tom@tromey.com>

        * symtab.c (search_symbols)
        (default_collect_symbol_completion_matches_break_on): Use
        objfile_msymbols.
        * ada-lang.c (ada_lookup_simple_minsym)
        (ada_collect_symbol_completion_matches): Use objfile_msymbols.
        * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
        * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
        objfile_msymbols.
        * coffread.c (coff_symfile_read): Use objfile_msymbols.
        * symmisc.c (dump_msymbols): Use objfile_msymbols.
        * objc-lang.c (find_methods): Use objfile_msymbols.
        (info_selectors_command, info_classes_command): Likewise.
        * stabsread.c (scan_file_globals): Use objfile_msymbols.
        * objfiles.h (class objfile_msymbols): New.
        (ALL_OBJFILE_MSYMBOLS): Remove.
        (ALL_MSYMBOLS): Remove.

2019-01-09  Tom Tromey  <tom@tromey.com>

        * common/next-iterator.h (next_adapter): Add Iterator template
        parameter.
        * objfiles.h (ALL_OBJFILES_SAFE): Remove.
        (class all_objfiles_safe): New.
        * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
        * objfiles.c (put_objfile_before): Update comment.
        (add_separate_debug_objfile): Likewise.
        (free_all_objfiles): Use all_objfiles_safe.
        (objfile_purge_solibs): Likewise.

2019-01-09  Tom Tromey  <tom@tromey.com>

        * symtab.c (iterate_over_symtabs, matching_obj_sections)
        (expand_symtab_containing_pc, lookup_static_symbol)
        (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
        (find_symbol_at_address, find_line_symtab, find_main_name): Use
        all_objfiles.
        * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
        * breakpoint.c (create_overlay_event_breakpoint)
        (create_longjmp_master_breakpoint)
        (create_std_terminate_master_breakpoint)
        (create_exception_master_breakpoint): Use all_objfiles.
        * linux-thread-db.c (try_thread_db_load_from_pdir)
        (has_libpthread): Use all_objfiles.
        * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
        * linespec.c (iterate_over_all_matching_symtabs)
        (search_minsyms_for_name): Use all_objfiles.
        * maint.c (maintenance_info_sections): Use all_objfiles.
        * main.c (captured_main_1): Use all_objfiles.
        * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
        * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
        * guile/scm-pretty-print.c
        (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
        * solib-spu.c (append_ocl_sos): Use all_objfiles.
        * symmisc.c (maintenance_print_symbols): Use all_objfiles.
        (maintenance_print_msymbols): Use all_objfiles.
        * source.c (select_source_symtab): Use all_objfiles.
        * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
        * symfile.c (remove_symbol_file_command)
        (expand_symtabs_matching, map_symbol_filenames): Use
        all_objfiles.
        * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
        all_objfiles.
        * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
        * objc-lang.c (find_methods): Use all_objfiles.
        * objfiles.c (have_partial_symbols, have_full_symbols)
        (have_minimal_symbols, qsort_cmp)
        (default_iterate_over_objfiles_in_search_order): Use
        all_objfiles.
        * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
        * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
        (maintenance_check_psymtabs): Use all_objfiles.
        (ALL_PSYMTABS): Remove.
        * compile/compile-object-run.c (do_module_cleanup): Use
        all_objfiles.
        * blockframe.c (find_pc_partial_function): Use all_objfiles.
        * cp-support.c (add_symbol_overload_list_qualified): Use
        all_objfiles.
        * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
        Use all_objfiles.
        * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
        * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
        all_objfiles.
        * python/py-objfile.c (objfpy_lookup_objfile_by_name)
        (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
        * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
        Uses all_objfiles.
        * solib.c (solib_read_symbols): Use all_objfiles

2019-01-09  Tom Tromey  <tom@tromey.com>

        * probe.c (parse_probes_in_pspace): Use all_objfiles.
        * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
        all_objfiles.
        * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
        * symmisc.c (print_symbol_bcache_statistics)
        (print_objfile_statistics, maintenance_print_objfiles)
        (maintenance_info_symtabs, maintenance_check_symtabs)
        (maintenance_expand_symtabs, maintenance_info_line_tables): Use
        all_objfiles.
        * source.c (forget_cached_source_info): Use all_objfiles.
        * symfile-debug.c (set_debug_symfile): Use all_objfiles.
        * elfread.c (elf_gnu_ifunc_resolve_by_cache)
        (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
        * objfiles.c (update_section_map): Use all_objfiles.
        (shared_objfile_contains_address_p): Likewise.
        * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
        * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.

2019-01-09  Tom Tromey  <tom@tromey.com>

        * common/next-iterator.h: New file.
        * objfiles.h (class all_objfiles): New.
        (struct objfile_iterator): New.

2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * NEWS: Move the description of the changed "frame", "select-frame",
         and "info frame" commands to the Changed commands section.

2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>

        * gdbtypes.c (check_stub_method_group): Remove handling of old
        mangling schemes.
        * linespec.c (find_methods): Likewise.
        * stabsread.c (read_member_functions): Likewise.
        * valops.c (search_struct_method): Likewise.
        (value_struct_elt_for_reference): Likewise.
        * NEWS: Mention this change.

2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>

        * cli/cli-cmds.c (list_command): Pass a source_lines_range to
        print_source_lines.
        * source.c (print_source_lines_base): Update line number check.
        (print_source_lines): New function.
        (source_lines_range::source_lines_range): New function.
        * source.h (class source_lines_range): New class.
        (print_source_lines): New declaration.

2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * linespec.c (linespec_state_destructor): Free self->canonical_names.

2019-01-08  Tom Tromey  <tom@tromey.com>
            Simon Marchi  <simon.marchi@ericsson.com>

        PR gdb/24060
        * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
        * ada-lex.l (DOLLAR_VARIABLE): Likewise.
        * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
        * f-exp.y (DOLLAR_VARIABLE): Likewise.
        * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
        * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.

2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>

        * source.c (select_source_symtab): Move header comment to
        declaration in source.h.
        (forget_cached_source_info_for_objfile): Likewise.
        (forget_cached_source_info): Likewise.
        (identify_source_line): Likewise.
        * source.h (identify_source_line): Move declaration from symtab.h
        and add comment from source.c
        (print_source_lines): Likewise.
        (forget_cached_source_info_for_objfile): Likewise.
        (forget_cached_source_info): Likewise.
        (select_source_symtab): Likewise.
        (enum print_source_lines_flag): Move definition from symtab.h.
        * symtab.h (identify_source_line): Move declaration to source.h.
        (print_source_lines): Likewise.
        (forget_cached_source_info_for_objfile): Likewise.
        (forget_cached_source_info): Likewise.
        (select_source_symtab): Likewise.
        (enum print_source_lines_flag): Move definition to source.h.
        * tui/tui-hooks.c: Add 'source.h' include.

2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>

        * source.c (print_source_lines_base): Handle requests to print
        reverse line number sequences, and guard against empty lines
        string.

2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>

        * source.c (print_source_lines_base): Fix skip of '\r' if next
        character is '\n'.

2019-01-06  Tom Tromey  <tom@tromey.com>

        * c-exp.y (struct c_parse_state) <macro_original_text,
        expansion_obstack>: New member.
        (macro_original_text, expansion_obstack): Remove globals.
        (scan_macro_expansion, scanning_macro_expansion)
        (finished_macro_expansion): Update.
        (scan_macro_cleanup): Remove.
        (yylex, c_parse): Update.

2019-01-06  Tom Tromey  <tom@tromey.com>

        * c-exp.y (struct c_parse_state) <strings>: New member.
        (operator_stoken): Update.

2019-01-06  Tom Tromey  <tom@tromey.com>

        * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
        (union type_stack_elt) <typelist_val>: Now a pointer to
        std::vector.
        (type_stack_cleanup): Don't declare.
        (push_typelist): Update.
        * parse.c (pop_typelist): Return a std::vector.
        (push_typelist): Take a std::vector.
        (follow_types): Update.  Do not free args.
        (type_stack_cleanup): Remove.
        * c-exp.y (struct c_parse_state): New.
        (cpstate): New global.
        (type_aggregate_p, exp, ptr_operator, parameter_typelist)
        (nonempty_typelist): Update.
        (func_mod): Create a new vector.
        (c_parse): Create a c_parse_state.
        (check_parameter_typelist): Do not delete params.
        (function_method): Update.  Do not delete type_list.

2019-01-06  Tom Tromey  <tom@tromey.com>

        PR gdb/28155:
        * python/py-finishbreakpoint.c (bpfinishpy_init): Use
        check_typedef.
        * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
        (print_return_value): Likewise.

2019-01-05  Tom Tromey  <tom@tromey.com>

        * contrib/cleanup_check.py: Remove.
        * contrib/gcc-with-excheck: Remove.
        * contrib/exsummary.py: Remove.
        * contrib/excheck.py: Remove.

2019-01-05  Joel Brobecker  <brobecker@adacore.com>

        * thread.c (delete_thread_1): Add gdb_assert that THR is not
        NULL. Initialize tpprev to NULL instead of assigning it
        to NULL on the next statement.
        * windows-nat.c (windows_delete_thread): Remove check for
        main_thread_id before printing thread exit notifications.
        (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
        Remove thread ID check against main_thread_id.
        <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
        windows_delete_thread.
        <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.

2019-01-04  Tom Tromey  <tom@tromey.com>

        * compile/compile.c (_initialize_compile): Use upper case for
        metasyntactic variables.
        * symmisc.c (_initialize_symmisc): Use upper case for
        metasyntactic variables.
        * psymtab.c (_initialize_psymtab): Use upper case for
        metasyntactic variables.
        * demangle.c (demangle_command): Use upper case for metasyntactic
        variables.
        (_initialize_demangler): Likewise.
        * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
        variables.

2019-01-03  Tom Tromey  <tom@tromey.com>

        * tui/tui-source.c (tui_set_source_content): Use xstrdup.

2019-01-03  Tom Tromey  <tom@tromey.com>

        * python/py-symtab.c (salpy_str): Update.
        (struct salpy_sal_object) <symtab>: Now a PyObject.
        (salpy_dealloc): Update.
        (del_objfile_sal): Use gdbpy_ref.

2019-01-03  Tom Tromey  <tom@tromey.com>

        * python/py-type.c (convert_field): Use new_reference.  Return
        gdbpy_ref.
        (make_fielditem): Return gdbpy_ref.
        (typy_fields): Update.
        (typy_getitem): Update.
        (field_name): Return gdbpy_ref.  Use new_reference.
        (typy_iterator_iternext): Update.

2019-01-03  Tom Tromey  <tom@tromey.com>

        * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.

2019-01-03  Tom Tromey  <tom@tromey.com>

        * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
        * python/py-type.c (typy_fields_items): Use gdbpy_ref.
        * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
        (pspy_set_frame_filters, pspy_set_frame_unwinders)
        (pspy_set_type_printers): Likewise.
        * python/py-function.c (fnpy_init): Use gdbpy_ref.
        * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
        * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
        (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
        (objfpy_set_type_printers): Likewise.

2019-01-03  Tom Tromey  <tom@tromey.com>

        * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
        (gdbpy_print_stack): Use gdbpy_err_fetch.
        * python/python-internal.h (class gdbpy_err_fetch): New class.
        (class gdbpy_enter) <m_error_type, m_error_value,
        m_error_traceback>: Remove.
        <m_error>: New member.
        (gdbpy_exception_to_string): Don't declare.
        * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
        * python/py-value.c (convert_value_from_python): Use
        gdbpy_err_fetch.
        * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
        gdbpy_exception_to_string.
        (gdbpy_handle_exception): Use gdbpy_err_fetch.
        * python/py-prettyprint.c (print_stack_unless_memory_error): Use
        gdbpy_err_fetch.

2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>

        * linux-nat.c (delete_lwp_cleanup): Delete.
        (struct lwp_deleter): New struct.
        (lwp_info_up): New typedef.
        (linux_nat_target::follow_fork): Delete cleanup, and make use of
        lwp_info_up.

2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>

        * linux-fork.c (class scoped_switch_fork_info): New class.
        (inferior_call_waitpid): Update to use scoped_switch_fork_info.

2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>

        * valops.c (find_overload_match): Remove use of null_cleanup, and
        calls to do_cleanups.

2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>

        * compile/compile-cplus-types.c
        (compile_cplus_instance::decl_name): Handle changes to
        cp_func_name.
        * cp-support.c (cp_func_name): Update header comment, update
        return type.
        * cp-support.h (cp_func_name): Update return type in declaration.
        * valops.c (find_overload_match): Move temp_func local to top
        level of function and change its type.  Use temp_func to hold and
        delete temporary string obtained from cp_func_name.

2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>

        * remote.c (remote_target::remote_check_symbols): Convert `msg` to
        gdb::char_vector, remove cleanup, and update uses of `msg`.

2019-01-03  Jim Wilson  <jimw@sifive.com>

        * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.

2019-01-02  Tom Tromey  <tom@tromey.com>

        * xml-tdesc.c (xml_cache): Hold a target_desc_up.
        (tdesc_parse_xml): Remove cleanups.
        * target-descriptions.h (make_cleanup_free_target_description):
        Don't declare.
        (target_desc_deleter): New struct.
        (target_desc_up): New typedef.
        * target-descriptions.c (target_desc_deleter::operator()): Rename
        from free_target_description.
        (make_cleanup_free_target_description): Remove.

2019-01-02  Tom Tromey  <tom@tromey.com>

        * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
        constructor, destructor.
        (linespec_parser): Remove typedef.
        (~linespec_parser): Rename from linespec_parser_delete.
        (linespec_lex_to_end, linespec_complete_label)
        (linespec_complete): Update.
        (decode_line_full): Remove cleanups.
        (decode_line_1): Update.

2019-01-02  Tom Tromey  <tom@tromey.com>

        * python/python-internal.h (inferior_to_inferior_object): Change
        return type.
        * python/py-exitedevent.c (create_exited_event_object): Update.
        * python/py-inferior.c (inferior_to_inferior_object): Return
        gdbpy_ref.
        (python_new_inferior, python_inferior_deleted)
        (thread_to_thread_object, delete_thread_object)
        (build_inferior_list, gdbpy_selected_inferior): Update.
        * python/py-infthread.c (create_thread_object): Update.  Also fail
        if inferior_to_inferior_object fails.

2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>

        * inferior.h (class inferior) <displaced_step_state>: New field.
        * infrun.h (struct displaced_step_state): Move here from
        infrun.c.  Initialize fields, add constructor.
        <inf>: Remove field.
        <reset>: New method.
        * infrun.c (struct displaced_step_inferior_state): Move to
        infrun.h.
        (displaced_step_inferior_states): Remove.
        (get_displaced_stepping_state): Adust.
        (displaced_step_in_progress_any_inferior): Adjust.
        (displaced_step_in_progress_thread): Adjust.
        (displaced_step_in_progress): Adjust.
        (add_displaced_stepping_state): Remove.
        (get_displaced_step_closure_by_addr): Adjust.
        (remove_displaced_stepping_state): Remove.
        (infrun_inferior_exit): Call displaced_step_state.reset.
        (use_displaced_stepping): Don't check for NULL.
        (displaced_step_prepare_throw): Call
        get_displaced_stepping_state.
        (displaced_step_fixup): Don't check for NULL.
        (prepare_for_detach): Don't check for NULL.

2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
         in case of call that did not complete.

2019-01-02  Andrey Utkin  <autkin@undo.io>

        * symfile.c (find_separate_debug_file): Fix search of debug files for
        remote debuggee.

2019-01-02  Tom Tromey  <tom@tromey.com>

        * python/py-inferior.c (gdbpy_initialize_inferior): Fix
        indentation.
        * python/py-frame.c (frapy_older): Remove cast.
        (frapy_newer): Likewise.
        * python/py-breakpoint.c (local_setattro): Remove cast.
        * python/py-arch.c (archpy_name): Remove local variable.
        * python/py-type.c (gdbpy_lookup_type): Remove cast.

2019-01-02  Joel Brobecker  <brobecker@adacore.com>

        * unittests/basic_string_view/element_access/char/empty.cc:
        Fix year range in copyright header.

2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>

        * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
        Delete.
        <operator==>: Update with for removed field.
        <hash>: Likewise.
        * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
        <isa_features>: ...this.
        <abi_features>: New field.
        (riscv_isa_flen): Update comment.
        (riscv_abi_xlen): New declaration.
        (riscv_abi_flen): New declaration.
        * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
        isa_features.
        (riscv_abi_xlen): New function.
        (riscv_isa_flen): Update to get answer from isa_features.
        (riscv_abi_flen): New function.
        (riscv_has_fp_abi): Update to get answer from abi_features.
        (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
        xlen and flen.
        (riscv_call_info) <xlen, flen>: Update comment.
        (riscv_call_arg_struct): Remove invalid assertions
        (riscv_features_from_gdbarch_info): Update now hw_float_abi field
        is removed.
        (riscv_gdbarch_init): Gather isa features and abi features
        separately, ensure both match on the gdbarch when reusing an old
        gdbarch.  Relax an error check to allow 32-bit abi float to run on
        a target with 64-bit float hardware.

2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * source.c (search_command_helper): Stop reverse search
        when line 1 has been searched.

2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * record-full.c (record_full_base_target::close): Rewrite
        record_full_core_buf_list free logic.

2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * break-catch-syscall.c (print_one_catch_syscall): xfree
        the last text.

2019-01-01  Joel Brobecker  <brobecker@adacore.com>

        * top.c (print_gdb_version): Update Copyright year in version
        message.

2019-01-01  Joel Brobecker  <brobecker@adacore.com>

        Update copyright year range in all GDB files.

2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>

        * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.

For older changes see ChangeLog-2018.
\f
Local Variables:
mode: change-log
left-margin: 8
fill-column: 74
version-control: never
coding: utf-8
End: