gdb/ChangeLog

   1 2019-08-16  Tom de Vries  <tdevries@suse.de>
   2
   3         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
   4         print_objfile_section_info.
   5
   6 2019-08-15  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
   9         calling update_cmdwin_start_line.
  10         * tui/tui-winsource.h (struct tui_source_window_base)
  11         <do_make_visible_with_new_height, set_new_height>: Don't declare.
  12         <rerender>: Declare.
  13         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
  14         Call rerender.
  15         (tui_source_window_base::set_new_height): Remove.
  16         (tui_source_window_base::rerender): Rename from
  17         do_make_visible_with_new_height.
  18         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
  19         resize method.
  20         (tui_win_info::make_invisible_and_set_new_height)
  21         (tui_win_info::make_visible_with_new_height): Remove.
  22         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
  23         Declare.
  24         * tui/tui-stack.c (tui_locator_window::rerender): New method.
  25         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
  26         do_make_visible_with_new_height>: Don't declare.
  27         <rerender>: Declare.
  28         * tui/tui-regs.c (tui_data_window::rerender): Rename from
  29         set_new_height.
  30         (tui_data_window::do_make_visible_with_new_height): Remove.
  31         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
  32         call tui_show_locator_content.
  33         (tui_gen_win_info::resize): Call rerender.
  34         (show_source_or_disasm_and_command): Don't call
  35         tui_show_locator_content.
  36         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
  37         method.
  38         (struct tui_win_info) <rerender>: Declare.
  39         <set_new_height, make_invisible_and_set_new_height,
  40         make_visible_with_new_height>: Don't declare.
  41         * tui/tui-data.c (tui_win_list::rerender): New method.
  42         * tui/tui-command.h (struct tui_cmd_window)
  43         <do_make_visible_with_new_height>: Don't declare.
  44         * tui/tui-command.c
  45         (tui_cmd_window::do_make_visible_with_new_height): Remove.
  46
  47 2019-08-15  Tom Tromey  <tromey@adacore.com>
  48
  49         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
  50         * ada-lang.c (ada_enum_name): Likewise.
  51
  52 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
  53
  54         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
  55         leading underscore.
  56         (GdbOutputErrorFile): Likewise.
  57         (global scope): Adjust constructor calls to GdbOutput{,Error}File
  58         accordingly.
  59         (execute_unwinders): Rename to have a leading underscore.
  60         (auto_load_packages): Likewise.
  61         (global scope): Adjust call to auto_load_packages accordingly.
  62         (GdbSetPythonDirectory): Likewise.
  63         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
  64         instead of execute_unwinders.
  65
  66 2019-08-15  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-layout.c (show_layout, show_source_disasm_command)
  69         (show_data): Don't change window visibility.
  70         (tui_gen_win_info::resize): Remove special case for command
  71         window.  Use wresize, when available.
  72         (show_source_or_disasm_and_command): Don't change window
  73         visibility.
  74         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
  75         <make_visible>: New method.
  76         * tui/tui-command.c (tui_cmd_window::resize): New method.
  77
  78 2019-08-15  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
  81         (struct tui_source_windows): New.
  82         * tui/tui-winsource.c (tui_display_main): Update.
  83         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  84         (new_height_ok, parse_scrolling_args): Update.
  85         * tui/tui-layout.c (show_layout, show_data): Update.
  86         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
  87         (tui_add_to_source_windows): Don't declare.
  88         * tui/tui-data.c (source_windows, tui_source_windows)
  89         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
  90
  91 2019-08-15  Tom Tromey  <tom@tromey.com>
  92
  93         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
  94         Rename from reset.
  95         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
  96         * tui/tui-layout.c (show_source_disasm_command, show_data):
  97         Update.
  98         (tui_gen_win_info::resize): Rename.
  99         (show_source_or_disasm_and_command): Update.
 100         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 101         reset.
 102
 103 2019-08-15  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 106         * tui/tui-interp.c (tui_interp::init): Don't call
 107         tui_initialize_static_data.
 108         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 109
 110 2019-08-15  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 113         examine tui_win_list.
 114
 115 2019-08-15  Tom Tromey  <tom@tromey.com>
 116
 117         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 118         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 119         tui_clear_source_content.
 120         (tui_clear_source_content): Remove.
 121         (tui_source_window_base::do_erase_source_content): Hoist call to
 122         content.clear().
 123         * tui/tui-stack.c (tui_show_frame_info): Don't call
 124         tui_clear_source_content.
 125
 126 2019-08-15  Tom Tromey  <tom@tromey.com>
 127
 128         * tui/tui-winsource.h (struct tui_source_window_base)
 129         <do_erase_source_content>: New method.
 130         <erase_source_content>: New method.
 131         (tui_erase_source_content): Don't declare.
 132         * tui/tui-winsource.c (tui_clear_source_content): Update.
 133         (tui_source_window_base::do_erase_source_content): Rename from
 134         tui_erase_source_content.
 135         (tui_source_window_base::show_source_content): Update.
 136         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 137         * tui/tui-source.h (struct tui_source_window)
 138         <erase_source_content>: New method.
 139         * tui/tui-disasm.h (struct tui_disasm_window)
 140         <erase_source_content>: New method.
 141
 142 2019-08-15  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 145         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 146         constructor.
 147         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 148         * tui/tui-source.c (tui_set_source_content): Update.
 149         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 150
 151 2019-08-15  Tom Tromey  <tom@tromey.com>
 152
 153         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 154         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 155         tui-source.c.
 156         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 157         Declare.
 158         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 159         method.
 160         (tui_source_window::maybe_update): Update.
 161
 162 2019-08-15  Tom Tromey  <tom@tromey.com>
 163
 164         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 165         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 166         tui-disasm.c.
 167         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 168         Declare.
 169         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 170         method.
 171         (tui_disasm_window::maybe_update): Update.
 172
 173 2019-08-15  Tom Tromey  <tom@tromey.com>
 174
 175         * tui/tui-winsource.h (struct tui_source_window_base)
 176         <maybe_update>: Declare.
 177         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 178         method.
 179         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 180         Declare.
 181         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 182         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 183         Declare.
 184         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 185
 186 2019-08-15  Tom Tromey  <tom@tromey.com>
 187
 188         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 189
 190 2019-08-15  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-wingeneral.c: Include tui-stack.h.
 193         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 194         (struct tui_locator_window): Move from tui-data.h.
 195         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 196         (tui_initialize_static_data): Move from tui-data.c.
 197         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 198         (struct tui_locator_window): Move to tui-stack.c.
 199         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 200         (tui_initialize_static_data): Move to tui-stack.c.
 201
 202 2019-08-15  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-layout.c (show_source_disasm_command)
 205         (show_source_or_disasm_and_command): Use make_visible method, not
 206         tui_make_window.
 207         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 208         Remove.
 209
 210 2019-08-15  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-wingeneral.h (tui_make_window): Update.
 213         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 214         parameter.
 215         (tui_gen_win_info::make_visible): Update.
 216         * tui/tui-regs.c (tui_data_window::display_registers_from):
 217         Update.
 218         * tui/tui-layout.c (show_source_disasm_command)
 219         (show_source_or_disasm_and_command): Update.
 220         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 221         (enum tui_box): Remove.
 222         (struct tui_win_info) <can_box>: New method.
 223         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 224         method.
 225
 226 2019-08-15  Tom de Vries  <tdevries@suse.de>
 227
 228         * linux-nat-trad.c: Include gdbarch.h.
 229
 230 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 231
 232         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 233         register sizes.
 234
 235 2019-08-14  Tom Tromey  <tromey@adacore.com>
 236
 237         * darwin-nat.c: Include gdbarch.h.
 238         * darwin-nat-info.c: Include gdbarch.h.
 239
 240 2019-08-13  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 243         Remove.
 244         * tui/tui-data.c (tui_initialize_static_data): Update.
 245
 246 2019-08-13  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-winsource.h (struct tui_exec_info_window)
 249         <~tui_exec_info_window, maybe_allocate_content, get_content,
 250         m_content>: Remove.
 251         (struct tui_source_window_base) <set_exec_info_content,
 252         show_exec_info_content>: Don't declare.
 253         * tui/tui-winsource.c
 254         (tui_exec_info_window::maybe_allocate_content): Remove.
 255         (tui_source_window_base::update_exec_info): Rename from
 256         set_exec_info_content.
 257         (tui_source_window_base::show_exec_info_content)
 258         (tui_source_window_base::update_exec_info): Remove.
 259
 260 2019-08-13  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 263         declare.
 264         * tui/tui-winsource.c (tui_update_source_window_as_is)
 265         (tui_update_source_windows_with_addr, tui_erase_source_content):
 266         Update.
 267         (tui_clear_exec_info_content): Remove.
 268
 269 2019-08-13  Tom Tromey  <tom@tromey.com>
 270
 271         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 272         declare.
 273         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 274         call tui_erase_exec_info_content.
 275         (tui_clear_exec_info_content): Rename from
 276         tui_erase_exec_info_content.
 277         (tui_clear_exec_info_content): Delete.
 278
 279 2019-08-13  Tom Tromey  <tom@tromey.com>
 280
 281         * tui/tui-winsource.h (struct tui_source_window_base)
 282         <show_exec_info_content>: Declare.
 283         (tui_show_exec_info_content): Don't declare.
 284         * tui/tui-winsource.c
 285         (tui_source_window_base::show_exec_info_content): Rename from
 286         tui_show_exec_info_content.
 287         (tui_source_window_base::update_exec_info): Update.
 288
 289 2019-08-13  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 292         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 293         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 294         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 295         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 296         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 297         ... here.
 298
 299 2019-08-13  Tom Tromey  <tom@tromey.com>
 300
 301         * tui/tui-winsource.h (struct tui_source_window_base)
 302         <update_exec_info>: Declare.
 303         (tui_update_exec_info): Don't declare.
 304         * tui/tui-winsource.c (tui_update_source_window_as_is)
 305         (tui_source_window_base::refresh_all)
 306         (tui_update_all_breakpoint_info): Update.
 307         (tui_source_window_base::update_exec_info): Rename from
 308         tui_update_exec_info.
 309         * tui/tui-stack.c (tui_show_frame_info): Update.
 310
 311 2019-08-13  Tom Tromey  <tom@tromey.com>
 312
 313         * tui/tui-winsource.h (struct tui_source_window_base)
 314         <set_exec_info_content>: Declare.
 315         (tui_set_exec_info_content): Don't declare.
 316         * tui/tui-winsource.c
 317         (tui_source_window_base::set_exec_info_content): Rename from
 318         tui_set_exec_info_content.
 319         (tui_update_exec_info): Update.
 320
 321 2019-08-13  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-winsource.h (struct tui_source_window_base)
 324         <show_source_content>: Declare.
 325         (tui_show_source_content): Don't declare.
 326         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 327         (tui_source_window_base::show_source_content): Rename from
 328         tui_show_source_content.
 329         (tui_source_window_base::refresh_all): Update.
 330         * tui/tui-layout.c (show_source_disasm_command)
 331         (show_source_or_disasm_and_command): Update.
 332
 333 2019-08-13  Tom Tromey  <tom@tromey.com>
 334
 335         * tui/tui-winsource.c (tui_erase_source_content)
 336         (tui_show_source_content, tui_source_window_base::refresh_all):
 337         Update.
 338         * tui/tui-wingeneral.h
 339         (tui_check_and_display_highlight_if_needed): Don't declare.
 340         * tui/tui-wingeneral.c
 341         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 342         check_and_display_highlight_if_needed.
 343         * tui/tui-win.c (tui_rehighlight_all)
 344         (tui_win_info::make_visible_with_new_height): Update.
 345         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 346         (tui_data_window::erase_data_content)
 347         (tui_data_window::display_all_data): Update.
 348         * tui/tui-data.h (struct tui_win_info)
 349         <check_and_display_highlight_if_needed>: Declare.
 350
 351 2019-08-13  Tom Tromey  <tom@tromey.com>
 352
 353         * tui/tui-win.c (tui_resize_all): Call
 354         tui_delete_invisible_windows.
 355         * tui/tui-layout.c (show_layout): Call
 356         tui_delete_invisible_windows.
 357         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 358         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 359
 360 2019-08-13  Tom Tromey  <tom@tromey.com>
 361
 362         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 363         tui_add_win_to_layout.
 364
 365 2019-08-13  Tom Tromey  <tom@tromey.com>
 366
 367         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 368         * tui/tui-layout.c (tui_default_win_height): Now static.
 369
 370 2019-08-13  Tom Tromey  <tom@tromey.com>
 371
 372         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 373         single switch.
 374         (show_source_disasm_command, show_source_or_disasm_and_command):
 375         Don't check current layout.
 376
 377 2019-08-13  Tom Tromey  <tom@tromey.com>
 378
 379         * tui/tui-wingeneral.c (make_all_visible): Remove.
 380         (tui_make_all_invisible): Simplify.
 381         * tui/tui-layout.c (tui_make_all_invisible): Move from
 382         tui-wingeneral.c; simplify.
 383         (show_layout): Hoist call to tui_make_all_invisible.
 384         (show_data): Don't call tui_make_all_invisible.
 385
 386 2019-08-13  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 389         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 390
 391 2019-08-13  Tom Tromey  <tom@tromey.com>
 392
 393         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 394         tui-data.c.
 395         (show_source_disasm_command, show_data)
 396         (show_source_or_disasm_and_command): Don't use
 397         tui_set_current_layout_to.
 398         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 399         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 400         tui-layout.c.
 401         (tui_set_current_layout_to): Remove.
 402
 403 2019-08-13  Tom Tromey  <tom@tromey.com>
 404
 405         * tui/tui-layout.c (tui_set_layout): Update.
 406         * tui/tui-data.h (struct tui_layout_def): Remove.
 407         (tui_layout_def): Don't declare.
 408         * tui/tui-data.c (layout_def): Remove.
 409         (tui_layout_def): Remove.
 410
 411 2019-08-13  Tom Tromey  <tom@tromey.com>
 412
 413         * tui/tui-winsource.h (struct tui_source_window_base)
 414         <clear_detail>: No longer "override".
 415         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 416         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 417         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 418         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 419         Remove.
 420         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 421
 422 2019-08-13  Tom Tromey  <tromey@adacore.com>
 423
 424         * tracepoint.c: Don't include readline.h or history.h.
 425
 426 2019-08-12  Tom Tromey  <tom@tromey.com>
 427
 428         * configure: Rebuild.
 429         * configure.ac: Check for readline 7.
 430         * NEWS: Mention readline 7 requirement.
 431         * README: Update.
 432
 433 2019-08-12  Tom Tromey  <tom@tromey.com>
 434
 435         * mingw-hdep.c (gdb_select): Remove readline hack.
 436
 437 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 438
 439         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 440         when the function fails.
 441
 442 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 443
 444         * s390-tdep.c (s390_type_align): New function.
 445         (s390_gdbarch_init): Set it as type_align gdbarch method.
 446
 447 2019-08-09  Tom de Vries  <tdevries@suse.de>
 448
 449         PR gdb/24591
 450         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 451         pc_low with relocation offset.
 452
 453 2019-08-07  Tom Tromey  <tromey@adacore.com>
 454
 455         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 456         (print_frame_args): Update.
 457         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 458         Update.
 459         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 460         * frame.h (struct frame_arg): Add initializers.
 461         <error>: Now a unique_xmalloc_ptr.
 462
 463 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 464
 465         * NEWS: Expand the Pointer Authentication entry.
 466         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 467         (aarch64_frame_unmask_lr): ... to this.
 468         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 469         Call aarch64_frame_unmask_lr.
 470         * frame.c (struct frame_info): Add "masked" variable.
 471         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 472         (fprint_frame): Check for masked pc.
 473         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 474         declarations.
 475         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 476         * stack.c (print_frame): Check for masked pc.
 477
 478 2019-08-06  Tom Tromey  <tom@tromey.com>
 479
 480         * stabsread.c (patch_block_stabs, read_one_struct_field)
 481         (read_enum_type): Use obstack_strndup.
 482         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 483         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 484         * dwarf2read.c (guess_full_die_structure_name)
 485         (anonymous_struct_prefix): Use obstack_strndup.
 486         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 487         * c-exp.y (yylex): Use obstack_strndup.
 488         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 489         (write_var_or_type): Use obstack_strndup.
 490
 491 2019-08-06  Tom Tromey  <tom@tromey.com>
 492
 493         * symfile.c (reread_symbols): Use obstack_strdup.
 494         * stabsread.c (read_type): Use obstack_strdup.
 495         * gdb_obstack.h (obstack_strdup): New overload.
 496         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 497         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 498         (dwarf2_canonicalize_name): Use obstack_strdup.
 499         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 500         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 501         Use obstack_strdup.
 502
 503 2019-08-06  Tom Tromey  <tom@tromey.com>
 504
 505         * gdb_obstack.h (obstack_strdup): Define.
 506         * gdb_obstack.c (obstack_strdup): Don't define.
 507
 508 2019-08-06  Tom Tromey  <tom@tromey.com>
 509
 510         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 511         obstack_strdup.
 512         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 513         obstack_strdup.
 514         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 515         * stabsread.c (common_block_start): Use obstack_strdup.
 516         * objfiles.c (set_objfile_main_name, objfile): Use
 517         obstack_strdup.
 518         * namespace.c (add_using_directive): Use obstack_strdup.
 519         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 520         * jit.c (finalize_symtab): Use obstack_strdup.
 521         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 522         (guess_partial_die_structure_name, partial_die_info::fixup)
 523         (dwarf2_name): Use obstack_strdup.
 524         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 525         obstack_strdup.
 526         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 527         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 528         obstack_strdup.
 529         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 530
 531 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 532
 533         * unittests/help-doc-selftests.c: New file.
 534         * Makefile.in: Add the new file.
 535
 536 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 537
 538         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 539         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 540         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 541         the trailing '.' is not output, and the first character is uppercased.
 542         (print_help_for_command): Update call to print_doc_line.
 543         (print_doc_of_command): Likewise.
 544         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 545         * cli/cli-option.c (append_indented_doc): Do not append newline.
 546         (build_help_option): Append newline after first appended_indented_doc
 547         only if a second call is done.
 548         (build_help): Append 2 new lines before each option, except the first
 549         one.
 550         * compile/compile.c (_initialize_compile): Add new lines after
 551         %OPTIONS%, when not at the end of the help.
 552         Change help doc or code
 553         producing the help doc to respect the invariants.
 554         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 555         Also removed the new line after 'Options:', as all other commands
 556         do not put an empty line between 'Options:' and the first option.
 557         * printcmd.c (_initialize_printcmd): Likewise.
 558         * stack.c (_initialize_stack): Likewise.
 559         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 560         incorrectly telling COMMAND is optional.
 561         * ada-lang.c (_initialize_ada_language): Change help doc or code
 562         producing the help doc to respect the invariants.
 563         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 564         * breakpoint.c (_initialize_breakpoint): Likewise.
 565         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 566         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 567         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 568         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 569         _initialize_cli_style): Likewise.
 570         * corelow.c (core_target_info): Likewise.
 571         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 572         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 573         * filesystem.c (_initialize_filesystem): Likewise.
 574         * frame.c (_initialize_frame): Likewise.
 575         * gnu-nat.c (add_task_commands): Likewise.
 576         * infcall.c (_initialize_infcall): Likewise.
 577         * infcmd.c (_initialize_infcmd): Likewise.
 578         * interps.c (_initialize_interpreter): Likewise.
 579         * language.c (_initialize_language): Likewise.
 580         * linux-fork.c (_initialize_linux_fork): Likewise.
 581         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 582         * maint.c (_initialize_maint_cmds): Likewise.
 583         * memattr.c (_initialize_mem): Likewise.
 584         * printcmd.c (_initialize_printcmd): Likewise.
 585         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 586         _RegEx): Likewise.
 587         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 588         * record-btrace.c (_initialize_record_btrace): Likewise.
 589         * record-full.c (_initialize_record_full): Likewise.
 590         * record.c (_initialize_record): Likewise.
 591         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 592         * regcache.c (_initialize_regcache): Likewise.
 593         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 594         _initialize_remote): Likewise.
 595         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 596         * serial.c (_initialize_serial): Likewise.
 597         * skip.c (_initialize_step_skip): Likewise.
 598         * source.c (_initialize_source): Likewise.
 599         * stack.c (_initialize_stack): Likewise.
 600         * symfile.c (_initialize_symfile): Likewise.
 601         * symtab.c (_initialize_symtab): Likewise.
 602         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 603         * top.c (init_main): Likewise.
 604         * tracefile-tfile.c (tfile_target_info): Likewise.
 605         * tracepoint.c (_initialize_tracepoint): Likewise.
 606         * tui/tui-win.c (_initialize_tui_win): Likewise.
 607         * utils.c (add_internal_problem_command): Likewise.
 608         * valprint.c (value_print_option_defs): Likewise.
 609
 610 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 611
 612         PR build/24886
 613         * configure.ac: Drop enable-libmcheck support.
 614         * configure, config.in: Rebuild.
 615         * libmcheck.m4: Remove.
 616         * acinclude.m4: Don't include it.
 617         * Makefile.in: Don't distribute it.
 618         * top.c (print_gdb_configuration): Don't mention it.
 619
 620 2019-08-06  Tom Tromey  <tom@tromey.com>
 621
 622         * utils.c (set_output_style): Sometimes pass stream to
 623         emit_style_escape.
 624         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 625         * record-btrace.c (btrace_insn_history): Update.
 626         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 627         method.
 628         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 629         Update initializers.
 630         <m_uiout>: New field.
 631         <m_di>: Move lower.
 632         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 633         Remove "uiout" parameter.
 634         (dump_insns): Update.
 635         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 636         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 637
 638 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 639
 640         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 641         (error_in_psymtab_expansion): Likewise.
 642         (lookup_symbol_via_quick_fns): Likewise.
 643         (basic_lookup_transparent_type_quick): Likewise.
 644         (basic_lookup_transparent_type_1): Likewise.
 645
 646 2019-08-06  Tom Tromey  <tromey@adacore.com>
 647
 648         * source.c (last_source_error): Now bool.
 649         (print_source_lines_base): Make "noprint" bool.  Only open
 650         source file when last_source_visited changes.
 651
 652 2019-08-06  Tom Tromey  <tromey@adacore.com>
 653
 654         * annotate.c (annotate_source_line): Use g_source_cache.
 655         * source-cache.c (source_cache::get_plain_source_lines): Change
 656         parameters.  Populate m_offset_cache.
 657         (source_cache::ensure): New method.
 658         (source_cache::get_line_charpos): New method.
 659         (extract_lines): Move lower.  Change parameters.
 660         (source_cache::get_source_lines): Move lower.
 661         * source-cache.h (class source_cache): Update comment.
 662         <get_line_charpos>: New method.
 663         <get_source_lines>: Update comment.
 664         <clear>: Clear m_offset_cache.
 665         <get_plain_source_lines>: Change parameters.
 666         <ensure>: New method
 667         <m_offset_cache>: New member.
 668         * source.c (forget_cached_source_info_for_objfile): Update.
 669         (info_source_command): Use g_source_cache.
 670         (find_source_lines, open_source_file_with_line_charpos): Remove.
 671         (print_source_lines_base, search_command_helper): Use g_source_cache.
 672         * source.h (open_source_file_with_line_charpos): Don't declare.
 673         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 674         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 675         Use g_source_cache.
 676
 677 2019-08-06  Tom Tromey  <tromey@adacore.com>
 678
 679         * source-cache.c (source_cache::get_plain_source_lines):
 680         Remove "first_line" and "last_line" parameters.
 681         (source_cache::get_source_lines): Cache plain text.
 682         * source-cache.h (class source_cache)
 683         <get_plain_source_lines>: Update.
 684
 685 2019-08-06  Tom Tromey  <tromey@adacore.com>
 686
 687         * source-cache.c (extract_lines): No longer a method.
 688         Changed type of parameter.  Include final newline.
 689         (selftests::extract_lines_test): New function.
 690         (_initialize_source_cache): Likewise.
 691         * source-cache.h (class source_cache)
 692         <extract_lines>: Don't declare.
 693
 694 2019-08-06  Tom Tromey  <tromey@adacore.com>
 695
 696         * breakpoint.c (init_breakpoint_sal): Update.
 697         (breakpoint): Update.
 698         * breakpoint.h (struct breakpoint) <filter>: Now a
 699         unique_xmalloc_ptr.
 700
 701 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 702
 703         * NEWS: Mention dictionary access on blocks.
 704         * python/py-block.c (blpy_getitem): New function.
 705         (block_object_as_mapping): New struct.
 706         (block_object_type): Use new struct for tp_as_mapping field.
 707
 708 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 709
 710         * objfiles.h (objfile): Add a comment describing partial symbols.
 711
 712 2019-08-05  Tom Tromey  <tromey@adacore.com>
 713
 714         * compile/compile.c (_initialize_compile): Use _(), not N_().
 715         * thread.c (_initialize_thread): Use _(), not N_().
 716         * stack.c (_initialize_stack): Use _(), not N_().
 717         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 718
 719 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 720
 721         * dwarf2read.c (struct dw2_symtab_iterator):
 722         <want_specific_block>: Remove.
 723         <block_index>: Change type to gdb::optional.
 724         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 725         change type of BLOCK_INDEX parameter to gdb::optional.
 726         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 727         (dw2_lookup_symbol): Don't pass argument for
 728         WANT_SPECIFIC_BLOCK.
 729         (dw2_expand_symtabs_for_function): Don't pass argument for
 730         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 731         (class dw2_debug_names_iterator)
 732         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 733         parameter, change BLOCK_INDEX type to gdb::optional.
 734         <m_want_specific_block>: Remove.
 735         <m_block_index>: Change type to gdb::optional.
 736         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 737         gdb::optional.  Re-write in function of gdb::optional.
 738         (dw2_debug_names_lookup_symbol): Don't pass argument for
 739         WANT_SPECIFIC_BLOCK.
 740         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 741         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 742         BLOCK_INDEX.
 743
 744 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 745
 746         * NEWS: Mention changes to "info sources" command.
 747
 748 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 749
 750         * symtab.c (filename_partial_match_opts): New struct type.
 751         (struct output_source_filename_data): New members
 752         regexp, c_regexp, partial_match.
 753         (output_source_filename): Use new members to decide to print file.
 754         (info_sources_option_defs): New variable.
 755         (make_info_sources_options_def_group, print_info_sources_header,
 756         info_sources_command_completer):
 757         New functions.
 758         (info_sources_command): Read new optional arguments.
 759         (_initialize_symtab): Update info sources help.
 760
 761 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 762
 763         * ada-lang.c (exception_support_info_v0): Renamed from...
 764         (default_exception_support_info): ... this.  Create new
 765         definition for v1.
 766         (ada_has_this_exception_support): Look up catch_handlers_sym.
 767         (ada_exception_support_info_sniffer): Try v0 after default.
 768
 769 2019-08-01  Tom Tromey  <tromey@adacore.com>
 770
 771         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 772         gdbarch.h.
 773
 774 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 775
 776         * s12z-tdep.c: Fix include path for s12z-opc.h.
 777
 778 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 779
 780         * NEWS: Require GNU make 3.82.
 781
 782 2019-07-16  Tom Tromey  <tom@tromey.com>
 783
 784         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 785         declare.
 786
 787 2019-07-30  Tom Tromey  <tromey@adacore.com>
 788
 789         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 790
 791 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 792
 793         * printcmd.c (print_address_symbolic): Print negative offsets.
 794         (build_address_symbolic): Force signed arithmetic when computing
 795         offset.
 796
 797 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 798
 799         PR/24474: Add a function to lookup static variables.
 800         * NEWS: Mention this new function.
 801         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 802         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 803         * python/python.c (python_GdbMethods): Add new function.
 804
 805 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 806
 807         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 808         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 809         (objfpy_lookup_static_symbol): New function.
 810         (objfile_object_methods): Add new functions.
 811
 812 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 813
 814         * NEWS: Mention 'set|show print frame-info'.  Mention new
 815         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 816         backtrace argument.  Mention that python frame filtering code
 817         is now consistent with what 'backtrace' command prints.
 818
 819 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 820
 821         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 822         comments.
 823         (print_frame_info_auto, print_frame_info_source_line,
 824         print_frame_info_location, print_frame_info_source_and_location,
 825         print_frame_info_location_and_address, print_frame_info_short_location):
 826         New declarations.
 827         (struct frame_print_options): New member print_frame_info.
 828         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 829         * stack.h (get_user_print_what_frame_info): New declaration.
 830         (frame_show_address): New declaration.
 831         * stack.c (print_frame_arguments_choices): New value 'presence'.
 832         (print_frame_info_auto, print_frame_info_source_line,
 833         print_frame_info_location, print_frame_info_source_and_location,
 834         print_frame_info_location_and_address, print_frame_info_short_location,
 835         print_frame_info_choices, print_frame_info_print_what): New definitions.
 836         (print_frame_args): Only print dots for args if print frame-arguments
 837         is 'presence'.
 838         (frame_print_option_defs): New element for "frame-info".
 839         (get_user_print_what_frame_info): New function.
 840         (frame_show_address): Make non static.  Move comment to stack.h.
 841         (print_frame_info_to_print_what): New function.
 842         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 843         to decide what to print.
 844         (backtrace_command_1): Handle the new print_frame_arguments_presence
 845         value.
 846         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 847         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 848         (py_print_frame): In non-mi mode, use LOCATION as default for
 849         print_what, similarly to frame information printed directly by
 850         backtrace command. Handle frame-info user option in non MI mode.
 851
 852 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 853
 854         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 855         Add case for debugging 32-bit target on 64-bit host.  Revise
 856         comment.
 857
 858 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 859
 860         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 861         instead of find_function_entry_range_from_pc.
 862
 863 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 864
 865         * stack.c (find_frame_funname): Remove code which preferred
 866         minsym over symtab sym in "certain pathological cases".
 867
 868         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 869         parameter.  Change type of "do_demangle" to bool.
 870         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 871         Pass suitable "prefer_sym_over_minsym" flag to
 872         build_address_symbolic().  Don't output "+" for negative offsets.
 873         * printcmd.c (print_address_symbolic): Update invocation of
 874         build_address_symbolic to include a "prefer_sym_over_minsym"
 875         flag.
 876         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 877         Restrict cases in which use of minimal symbol is preferred to that
 878         of a found symbol.  Update comments.
 879
 880         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 881         for entry pc when entry pc is out of range for that FDE.
 882
 883 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 884
 885         PR gdb/24839:
 886         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 887         type.
 888
 889 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 890
 891         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 892         this function's Python signature.
 893
 894
 895 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 896
 897         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 898         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 899         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 900         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 901         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 902
 903
 904 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 905
 906         * h8300-tdep.c (h8300_register_name_common): New.
 907         h8300_register_name): Use h8300_register_name_common.
 908         (h8300s_register_name): Likewise.
 909         (h8300sx_register_name): Likewise.
 910         (h8300h_register_nam): New.
 911         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 912
 913
 914 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 915
 916         * arm-tdep.c (arm_skip_cmse_entry): New function.
 917         (arm_is_sgstubs_section): New function.
 918         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 919
 920 2019-07-22  Tom Tromey  <tom@tromey.com>
 921
 922         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 923         Don't self-assign.
 924
 925 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 926
 927         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 928         type_print.
 929
 930 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 931
 932         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 933         so that GDB doesn't match any msymbols when searching in the
 934         TYPES_DOMAIN.
 935         (print_symbol_info): Print using typedef_print or type_print based
 936         on the type of the symbol.  Add updated FIXME comment moved from...
 937         (_initialize_symtab): ... move and update FIXME comment to above.
 938
 939 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 940
 941         * NEWS: Mention adding -q option to "info types".
 942         * symtab.c (struct info_types_options): New struct.
 943         (info_types_options_defs): New variable.
 944         (make_info_types_options_def_group): New function.
 945         (info_types_command): Use gdb::option framework to parse options.
 946         (info_types_command_completer): New function.
 947         (_initialize_symtab): Extend the help text on "info types" and
 948         register command completer.
 949
 950 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 951
 952         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 953         (lookup_symbol_in_objfile): Change int to block_enum and add a
 954         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 955
 956 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 957
 958         * MAINTAINERS (Write After Approval): Add self.
 959
 960 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 961
 962         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 963         instruction to the dummy code region.
 964
 965 2019-07-19  Tom Tromey  <tromey@adacore.com>
 966
 967         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 968         (ARGSUSED, PARAMS, __func__): Remove rules.
 969
 970 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 971
 972         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 973         * features/arm/arm-with-iwmmxt.c: Remove.
 974         * features/arm/arm-with-iwmmxt.xml: Remove.
 975         * features/arm/arm-with-m-fpa-layout.c: Remove.
 976         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 977         * features/arm/arm-with-m-vfp-d16.c: Remove.
 978         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 979         * features/arm/arm-with-m.c: Remove.
 980         * features/arm/arm-with-m.xml: Remove.
 981         * features/arm/arm-with-neon.c: Remove.
 982         * features/arm/arm-with-neon.xml: Remove.
 983         * features/arm/arm-with-vfpv2.c: Remove.
 984         * features/arm/arm-with-vfpv2.xml: Remove.
 985         * features/arm/arm-with-vfpv3.c: Remove.
 986         * features/arm/arm-with-vfpv3.xml: Remove.
 987
 988 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 989
 990         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 991
 992 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 993
 994         * arch/aarch32.c (aarch32_create_target_description): Create
 995         target descriptions using features.
 996         * arch/arm.c (arm_create_target_description)
 997         (arm_create_mprofile_target_description): Likewise.
 998         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 999
1000 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1001
1002         * Makefile.in: Add new files.
1003         * aarch32-tdep.c: New file.
1004         * aarch32-tdep.h: New file.
1005         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1006         Call aarch32_read_description.
1007         * arch/aarch32.c: New file.
1008         * arch/aarch32.h: New file.
1009         * arch/arm.c (arm_create_target_description)
1010         (arm_create_mprofile_target_description): New function.
1011         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1012         (arm_create_target_description)
1013         (arm_create_mprofile_target_description): New declaration.
1014         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1015         read_description functions.
1016         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1017         Likewise.
1018         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1019         * arm-tdep.c (tdesc_arm_list): New variable.
1020         (arm_register_g_packet_guesses): Call create description functions.
1021         (arm_read_description) (arm_read_mprofile_description): New
1022         function.
1023         * arm-tdep.h (arm_read_description)
1024         (arm_read_mprofile_description): Add declaration.
1025         * configure.tgt: Add new files.
1026
1027 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1028
1029         * top.c (new_ui_command): Open specified terminal just once.
1030
1031 2019-07-18  Tom Tromey  <tromey@adacore.com>
1032
1033         * symtab.c (main_name): Constify return type.
1034         * symfile.c (set_initial_language): Update.
1035         * symtab.h (main_name): Constify return type.
1036
1037 2019-07-17  Tom Tromey  <tom@tromey.com>
1038
1039         * tui/tui-winsource.c (tui_update_source_window)
1040         (tui_update_source_window_as_is)
1041         (tui_update_source_windows_with_line): Remove return.
1042         * tui/tui-disasm.c (tui_show_disassem)
1043         (tui_show_disassem_and_update_source): Remove return.
1044         * tui/tui.c (tui_reset): Remove return.
1045         * tui/tui-wingeneral.c
1046         (tui_check_and_display_highlight_if_needed): Remove return.
1047
1048 2019-07-17  Tom Tromey  <tom@tromey.com>
1049
1050         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1051
1052 2019-07-17  Tom Tromey  <tom@tromey.com>
1053
1054         * tui/tui-winsource.h (struct tui_exec_info_window)
1055         (struct tui_source_window_base): Move from tui-data.h.
1056         * tui/tui-winsource.c: Move many method definitions from
1057         elsewhere.  Remove "structuring" comments.
1058         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1059         (tui_source_window_base::refresh_window): Move to
1060         tui-winsource.c.
1061         * tui/tui-win.c (tui_source_window_base::refresh_all)
1062         (tui_source_window_base::update_tab_width)
1063         (tui_source_window_base::set_new_height)
1064         (tui_source_window_base::do_make_visible_with_new_height): Move to
1065         tui-winsource.c.
1066         * tui/tui-source.h: Update.
1067         * tui/tui-source.c (tui_source_window_base::reset): Move to
1068         tui-winsource.c.
1069         * tui/tui-disasm.h: Update.
1070         * tui/tui-data.h (struct tui_exec_info_window): Move to
1071         tui-winsource.h.
1072         (struct tui_source_window_base): Likewise.
1073         * tui/tui-data.c (tui_source_window_base::clear_detail)
1074         (tui_source_window_base, ~tui_source_window_base): Move to
1075         tui-winsource.c.
1076
1077 2019-07-17  Tom Tromey  <tom@tromey.com>
1078
1079         * tui/tui-win.c (tui_resize_all)
1080         (tui_source_window_base::update_tab_width)
1081         (tui_adjust_win_heights): Update.
1082         (tui_win_info::make_invisible_and_set_new_height): Rename from
1083         make_invisible_and_set_new_height.
1084         * tui/tui-data.h (struct tui_win_info)
1085         <make_invisible_and_set_new_height>: New method.
1086
1087 2019-07-17  Tom Tromey  <tom@tromey.com>
1088
1089         * tui/tui.c: Update.
1090         * tui/tui-source.h (struct tui_source_window): Move from
1091         tui-data.h.
1092         * tui/tui-layout.c: Update.
1093         * tui/tui-disasm.c: Update.
1094         * tui/tui-data.h (struct tui_source_window): Move to
1095         tui-source.h.
1096
1097 2019-07-17  Tom Tromey  <tom@tromey.com>
1098
1099         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1100         tui-data.h.
1101         * tui/tui-data.h (struct tui_disasm_window): Move to
1102         tui-disasm.h.
1103
1104 2019-07-17  Tom Tromey  <tom@tromey.com>
1105
1106         * tui/tui-regs.h (struct tui_data_item_window): Move from
1107         tui-data.h.
1108         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1109         * tui/tui-data.h (struct tui_data_item_window): Move to
1110         tui-regs.h.
1111         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1112
1113 2019-07-17  Tom Tromey  <tom@tromey.com>
1114
1115         * tui/tui.c: Update.
1116         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1117         (tui_cmd_window::max_height): Move to tui-command.c.
1118         * tui/tui-layout.c: Update.
1119         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1120         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1121         tui-command.c.
1122         * tui/tui-command.h (struct tui_cmd_window): Move from
1123         tui-data.h.
1124         * tui/tui-command.c: Remove "structuring" comments.
1125         (tui_cmd_window::clear_detail)
1126         (tui_cmd_window::do_make_visible_with_new_height)
1127         (tui_cmd_window::max_height): Move from elsewhere.
1128
1129 2019-07-17  Tom Tromey  <tom@tromey.com>
1130
1131         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1132         Now static.
1133         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1134         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1135
1136 2019-07-17  Tom Tromey  <tom@tromey.com>
1137
1138         * tui/tui.c: Update.
1139         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1140         tui-regs.c.
1141         * tui/tui-windata.h: Remove file.
1142         * tui/tui-windata.c: Remove file.
1143         * tui/tui-win.c (tui_data_window::set_new_height)
1144         (tui_data_window::do_make_visible_with_new_height): Move to
1145         tui-regs.c.
1146         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1147         * tui/tui-regs.c: Remove "structuring" comments.
1148         (tui_data_window::first_data_item_displayed)
1149         (tui_data_window::delete_data_content_windows)
1150         (tui_data_window::erase_data_content)
1151         (tui_data_window::display_all_data)
1152         (tui_data_window::refresh_all)
1153         (tui_data_window::do_scroll_vertical)
1154         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1155         (tui_data_window::do_make_visible_with_new_height)
1156         (tui_data_window::refresh_window): Move from elsewhere.
1157         (_initialize_tui_regs): Move to end of file.
1158         * tui/tui-layout.c: Update.
1159         * tui/tui-hooks.c: Update.
1160         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1161         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1162         tui-regs.c.
1163         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1164
1165 2019-07-17  Tom Tromey  <tom@tromey.com>
1166
1167         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1168         seen.
1169
1170 2019-07-17  Tom Tromey  <tom@tromey.com>
1171
1172         * tui/tui-win.c (tui_source_window_base::set_new_height)
1173         (tui_source_window_base::do_make_visible_with_new_height): Use
1174         m_has_locator field directly.
1175         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1176         method.
1177         (struct tui_source_window_base) <has_locator>: Likewise.
1178
1179 2019-07-17  Tom Tromey  <tom@tromey.com>
1180
1181         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1182         Don't declare.
1183         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1184         Remove.
1185         * tui/tui-win.c (tui_source_window_base::set_new_height)
1186         (tui_source_window_base::set_new_height)
1187         (make_invisible_and_set_new_height)
1188         (tui_source_window_base::do_make_visible_with_new_height)
1189         (tui_source_window_base::do_make_visible_with_new_height):
1190         Update.
1191         * tui/tui-layout.c (show_source_disasm_command, show_data)
1192         (show_source_or_disasm_and_command): Update.
1193         * tui/tui-layout.c (show_layout): Update.
1194
1195 2019-07-17  Tom Tromey  <tom@tromey.com>
1196
1197         * tui/tui-layout.c (make_data_window): Remove.
1198         (show_data): Unify creation and re-initialization cases.
1199
1200 2019-07-17  Tom Tromey  <tom@tromey.com>
1201
1202         * tui/tui-layout.c (make_source_window, make_disasm_window):
1203         Remove.
1204         (show_data): Unify creation and re-initialization cases.
1205
1206 2019-07-17  Tom Tromey  <tom@tromey.com>
1207
1208         * tui/tui-layout.c (make_command_window): Remove.
1209         (show_source_disasm_command, show_source_or_disasm_and_command):
1210         Unify creation and re-initialization cases.
1211
1212 2019-07-17  Tom Tromey  <tom@tromey.com>
1213
1214         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1215         creation and re-initialization cases.
1216
1217 2019-07-17  Tom Tromey  <tom@tromey.com>
1218
1219         * tui/tui-regs.c (tui_get_register): Return void.
1220
1221 2019-07-17  Tom Tromey  <tom@tromey.com>
1222
1223         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1224         Simplify.
1225
1226 2019-07-17  Tom Tromey  <tom@tromey.com>
1227
1228         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1229         resetting.
1230
1231 2019-07-17  Tom Tromey  <tom@tromey.com>
1232
1233         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1234         * tui/tui-regs.c (tui_reg_layout): New function.
1235         (tui_show_registers, tui_reg_command): Use it.
1236         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1237         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1238         parameters.
1239         (tui_layout_command): Remove.
1240
1241 2019-07-17  Tom Tromey  <tom@tromey.com>
1242
1243         * tui/tui-layout.h (tui/tui-layout): Return void.
1244         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1245
1246 2019-07-17  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui-layout.c (show_source_disasm_command, show_data):
1249         Update.
1250         (reset_locator): Remove.
1251         (show_source_or_disasm_and_command): Update.
1252
1253 2019-07-17  Tom Tromey  <tom@tromey.com>
1254
1255         * tui/tui-source.c (tui_source_window_base::reset): Remove
1256         win_type parameter.
1257         * tui/tui-layout.c (make_command_window, make_source_window)
1258         (make_disasm_window, make_data_window)
1259         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1260         (reset_locator, show_source_or_disasm_and_command): Update.
1261         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1262         win_type parameter.
1263         (struct tui_source_window_base) <reset>: Likewise.
1264
1265 2019-07-17  Tom Tromey  <tom@tromey.com>
1266
1267         * tui/tui-layout.c (show_source_disasm_command): Use
1268         reset_locator.
1269         (reset_locator): New function.
1270         (init_and_make_win): Remove.
1271         (show_source_or_disasm_and_command): Use reset_locator.
1272
1273 2019-07-17  Tom Tromey  <tom@tromey.com>
1274
1275         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1276         condition.
1277         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1278         Remove condition.
1279         * tui/tui-source.c (tui_source_window_base::reset): New method.
1280         * tui/tui-layout.c (make_command_window): Don't call
1281         init_and_make_win.
1282         (make_source_window, make_disasm_window): Don't call
1283         make_source_or_disasm_window.
1284         (make_data_window): Don't call init_and_make_win.  Change calling
1285         convention.
1286         (show_source_disasm_command, show_data): Simplify.
1287         (make_source_or_disasm_window): Remove.
1288         (show_source_or_disasm_and_command): Simplify.
1289         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1290         (struct tui_source_window_base) <reset>: Likewise.
1291         <execution_info>: Remove initializer.
1292         * tui/tui-data.c (tui_source_window_base): Initialize
1293         execution_info.
1294
1295 2019-07-17  Tom Tromey  <tom@tromey.com>
1296
1297         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1298         variable.
1299
1300 2019-07-17  Tom Tromey  <tom@tromey.com>
1301
1302         * tui/tui.c (tui_rl_other_window): Update.
1303         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1304         superclass method first.  Always iterate over regs_content.
1305         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1306         method.
1307         * tui/tui-win.c (tui_set_focus_command): Update.
1308
1309 2019-07-17  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui-win.c (tui_set_focus_command): Rename from
1312         tui_set_focus.  Call tui_enable.
1313         (tui_set_focus_command): Remove.
1314
1315 2019-07-17  Tom Tromey  <tom@tromey.com>
1316
1317         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1318         refresh_window.
1319         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1320         touchwin.
1321         (tui_data_window::refresh_window): Call refresh_window on data
1322         items.  Always call superclass refresh_window.
1323         (tui_win_info::refresh): Remove.
1324         (tui_source_window_base::refresh_window): Update.
1325         (tui_refresh_all): Update.
1326         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1327         refresh_window.
1328         (show_source_or_disasm_and_command): Likewise.
1329         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1330         (struct tui_source_window_base) <refresh>: Likewise.
1331
1332 2019-07-17  Tom Tromey  <tom@tromey.com>
1333
1334         * tui/tui-winsource.c (tui_clear_source_content)
1335         (tui_show_source_content): Update.
1336         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1337         whether content is empty.
1338         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1339         Remove.
1340
1341 2019-07-17  Tom Tromey  <tom@tromey.com>
1342
1343         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1344         window's contents.
1345         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1346         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1347
1348 2019-07-17  Tom Tromey  <tom@tromey.com>
1349
1350         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1351         (struct tui_data_item_window): Update.
1352
1353 2019-07-17  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1356         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1357         defines.
1358
1359 2019-07-17  Tom Tromey  <tom@tromey.com>
1360
1361         * tui/tui-winsource.h (tui_erase_source_content)
1362         (tui_clear_source_content): Remove "display_prompt" parameter.
1363         * tui/tui-winsource.c (tui_update_source_window_as_is)
1364         (tui_update_source_windows_with_addr): Update.
1365         (tui_clear_source_content): Remove "display_prompt" parameter.
1366         (tui_erase_source_content): Likewise.  Simplify.
1367         (tui_show_source_content): Update.
1368         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1369         * tui/tui-stack.c (tui_show_frame_info): Update.
1370         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1371         Remove defines.
1372
1373 2019-07-17  Tom Tromey  <tom@tromey.com>
1374
1375         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1376         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1377         parameter.
1378         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1379         parameter.
1380
1381 2019-07-17  Tom Tromey  <tom@tromey.com>
1382
1383         * tui/tui-winsource.c (tui_clear_source_content)
1384         (tui_show_source_content, tui_show_exec_info_content)
1385         (tui_clear_exec_info_content): Update.
1386         * tui/tui-stack.c (tui_show_locator_content): Update.
1387         (tui_show_frame_info): Update.
1388         * tui/tui-source.h (tui_source_window): Don't declare.
1389         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1390         from tui_source_is_displayed.
1391         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1392         Remove field.
1393         (struct tui_source_window_base) <content_in_use>: New field.  Now
1394         bool.
1395         (struct tui_source_window) <showing_source_p>: New method.
1396         (TUI_SRC_WIN): Change cast.
1397         * tui/tui-data.c (tui_initialize_static_data): Update.
1398
1399 2019-07-17  Tom Tromey  <tom@tromey.com>
1400
1401         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1402         location_matches_p.
1403         * tui/tui-source.c (tui_source_window::location_matches_p): New
1404         method.
1405         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1406         method.
1407         * tui/tui-data.h (struct tui_source_window_base)
1408         <location_matches_p>: New method.
1409         (struct tui_source_window, struct tui_disasm_window)
1410         <location_matches_p>: Likewise.
1411
1412 2019-07-17  Tom Tromey  <tom@tromey.com>
1413
1414         * tui/tui-win.c (tui_set_win_height_command): Rename from
1415         tui_set_win_height.
1416         (tui_set_win_height_command): Remove.
1417
1418 2019-07-17  Tom Tromey  <tom@tromey.com>
1419
1420         * tui/tui-source.c (tui_source_window): New constructor.  Add
1421         observer.
1422         (~tui_source_window): New destructor.
1423         (tui_source_window::style_changed): New method.
1424         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1425         (tui_attach_detach_observers): Update.
1426         * tui/tui-data.h (struct tui_source_window): Make constructor not
1427         inline.  Add destructor.
1428         (struct tui_source_window) <style_changed>: New method.
1429         <m_observable>: New member.
1430
1431 2019-07-17  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1434         * tui/tui-win.c (tui_resize_all): Fix typo.
1435
1436 2019-07-17  Tom Tromey  <tom@tromey.com>
1437
1438         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1439         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1440         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1441         * tui/tui-win.c (window_name_completer): Use foreach.
1442         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1443         (update_tab_width): Likewise.
1444         * tui/tui-layout.c (show_layout): Update.
1445         * tui/tui-data.h (class tui_window_iterator): New.
1446         (struct all_tui_windows): New.
1447         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1448
1449 2019-07-17  Tom Tromey  <tom@tromey.com>
1450
1451         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1452         parameter.  Don't reference globals.
1453         (tui_reg_command): Update.
1454
1455 2019-07-17  Tom Tromey  <tom@tromey.com>
1456
1457         * tui/tui-regs.c (tui_show_registers): Simplify.
1458
1459 2019-07-17  Tom Tromey  <tom@tromey.com>
1460
1461         * tui/tui-regs.c (tui_show_registers): Update.
1462         (tui_show_register_group): Add win_info parameter.
1463
1464 2019-07-17  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1467         Rename from tui_display_reg_element_at_line.
1468         (tui_data_window::display_registers_from_line): Update.
1469         * tui/tui-data.h (struct tui_data_window)
1470         <display_reg_element_at_line>: New method.
1471
1472 2019-07-17  Tom Tromey  <tom@tromey.com>
1473
1474         * tui/tui-regs.h (tui_display_registers_from)
1475         (tui_display_registers_from_line): Don't declare.
1476         * tui/tui-windata.c (tui_data_window::display_all_data)
1477         (tui_data_window::refresh_all)
1478         (tui_data_window::do_scroll_vertical): Update.
1479         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1480         from tui_display_registers_from.
1481         (tui_display_reg_element_at_line): Update.
1482         (tui_data_window::display_registers_from_line): Rename from
1483         tui_display_registers_from_line.
1484         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1485         display_registers_from_line>: New methods.
1486
1487 2019-07-17  Tom Tromey  <tom@tromey.com>
1488
1489         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1490         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1491         from tui_erase_data_content.
1492         (tui_data_window::display_all_data)
1493         (tui_data_window::refresh_all)
1494         (tui_data_window::do_scroll_vertical): Update.
1495         * tui/tui-regs.c (tui_show_registers): Update.
1496         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1497         New method.
1498
1499 2019-07-17  Tom Tromey  <tom@tromey.com>
1500
1501         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1502         declare.
1503         * tui/tui-windata.c
1504         (tui_data_window::delete_data_content_windows): Rename from
1505         tui_delete_data_content_windows.
1506         (tui_data_window::display_all_data)
1507         (tui_data_window::do_scroll_vertical): Update.
1508         * tui/tui-data.h (struct tui_data_window)
1509         <delete_data_content_windows>: New method.
1510
1511 2019-07-17  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1514         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1515
1516 2019-07-17  Tom Tromey  <tom@tromey.com>
1517
1518         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1519         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1520         from tui_display_all_data.
1521         * tui/tui-win.c
1522         (tui_data_window::do_make_visible_with_new_height): Update.
1523         * tui/tui-regs.c (tui_show_registers): Update.
1524         * tui/tui-layout.c (tui_set_layout): Update.
1525         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1526         method.
1527
1528 2019-07-17  Tom Tromey  <tom@tromey.com>
1529
1530         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1531         * tui/tui-windata.c (tui_display_data_from): Remove.
1532         (tui_data_window::refresh_all): Update.
1533
1534 2019-07-17  Tom Tromey  <tom@tromey.com>
1535
1536         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1537         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1538         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1539         tui_display_registers_from_line.
1540         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1541         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1542         "force_display" parameter.
1543
1544 2019-07-17  Tom Tromey  <tom@tromey.com>
1545
1546         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1547         declare.
1548         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1549         Rename from tui_first_reg_element_no_inline.
1550         (tui_display_reg_element_at_line)
1551         (tui_display_registers_from_line): Update.
1552         * tui/tui-data.h (struct tui_data_window)
1553         <first_reg_element_no_inline>: New method.
1554
1555 2019-07-17  Tom Tromey  <tom@tromey.com>
1556
1557         * tui/tui-windata.c (tui_display_data_from)
1558         (tui_data_window::do_scroll_vertical): Update.
1559         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1560         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1561         Rename from tui_line_from_reg_element_no.
1562         (tui_display_registers_from_line): Update.
1563         * tui/tui-data.h (struct tui_data_window)
1564         <line_from_reg_element_no>: New method.
1565
1566 2019-07-17  Tom Tromey  <tom@tromey.com>
1567
1568         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1569         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1570         tui_last_regs_line_no.
1571         (tui_display_reg_element_at_line)
1572         (tui_display_registers_from_line): Update.
1573         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1574         method.
1575
1576 2019-07-17  Tom Tromey  <tom@tromey.com>
1577
1578         PR tui/24722:
1579         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1580         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1581         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1582         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1583         (tui_update_breakpoint_info): Likewise.
1584         * tui/tui-hooks.c (tui_event_create_breakpoint)
1585         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1586         Update.
1587
1588 2019-07-17  Tom Tromey  <tom@tromey.com>
1589
1590         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1591
1592 2019-07-17  Tom Tromey  <tom@tromey.com>
1593
1594         * tui/tui-winsource.c (tui_update_source_window_as_is)
1595         (tui_update_source_windows_with_addr): Update.
1596         * tui/tui-source.h (tui_set_source_content)
1597         (tui_show_symtab_source): Add "win_info" parameter.
1598         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1599         parameter.
1600         (tui_show_symtab_source): Likewise.
1601
1602 2019-07-17  Tom Tromey  <tom@tromey.com>
1603
1604         * tui/tui-wingeneral.c
1605         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1606
1607 2019-07-17  Tom Tromey  <tom@tromey.com>
1608
1609         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1610         (struct tui_cmd_window) <can_scroll>: New method.
1611         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1612         method.
1613
1614 2019-07-17  Tom Tromey  <tromey@adacore.com>
1615
1616         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1617         do_field_signed>: Rename.  Change type of "value".
1618         * ui-out.c (ui_out::field_signed): Rename from field_int.
1619         Change type of "value".
1620         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1621         type of "value".
1622         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1623         do_field_int.  Change type of "value".
1624         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1625         do_field_int.  Change type of "value".
1626         * tracepoint.c (trace_status_mi, tfind_1)
1627         (print_one_static_tracepoint_marker): Update.
1628         * thread.c (print_thread_info_1, print_selected_thread_frame):
1629         Update.
1630         * stack.c (print_frame, print_frame_info): Update.
1631         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1632         Update.
1633         * source.c (print_source_lines_base): Update.
1634         * skip.c (info_skip_command): Update.
1635         * record-btrace.c (btrace_ui_out_decode_error)
1636         (btrace_call_history_src_line): Update.
1637         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1638         Update.
1639         * progspace.c (print_program_space): Update.
1640         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1641         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1642         do_field_int.  Change type of "value".
1643         * mi/mi-out.c (mi_ui_out::do_table_begin)
1644         (mi_ui_out::do_table_header): Update.
1645         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1646         type of "value".
1647         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1648         (mi_cmd_data_list_changed_registers, output_register)
1649         (mi_cmd_data_read_memory, mi_load_progress)
1650         (mi_cmd_trace_frame_collected): Update.
1651         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1652         Update.
1653         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1654         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1655         (mi_cmd_var_list_children, varobj_update_one): Update.
1656         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1657         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1658         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1659         * inferior.c (print_inferior): Update.
1660         * gdb_bfd.c (print_one_bfd): Update.
1661         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1662         Update.
1663         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1664         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1665         do_field_int.  Change type of "value".
1666         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1667         do_field_int.  Change type of "value".
1668         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1669         (print_one_breakpoint_location, print_it_catch_fork)
1670         (print_one_catch_fork, print_it_catch_vfork)
1671         (print_one_catch_vfork, print_it_catch_solib)
1672         (print_it_catch_exec, print_it_ranged_breakpoint)
1673         (print_mention_watchpoint, print_mention_masked_watchpoint)
1674         (bkpt_print_it, update_static_tracepoint): Update.
1675         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1676         * break-catch-syscall.c (print_it_catch_syscall): Update.
1677         * ada-tasks.c (print_ada_task_info): Update.
1678         * ada-lang.c (print_it_exception, print_mention_exception):
1679         Update.
1680
1681 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1682
1683         PR breakpoints/24541
1684         * gdbarch.c: Regenerate.
1685         * gdbarch.h: Regenerate.
1686         * gdbarch.sh: Adjust return type and parameter types for
1687         'stap_adjust_register'.
1688         (i386_stap_adjust_register): Adjust signature and return new
1689         register name.
1690         * stap-probe.c (stap_parse_register_operand): Adjust use of
1691         'gdbarch_stap_adjust_register'.
1692
1693 2019-07-17  Tom Tromey  <tromey@adacore.com>
1694
1695         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1696         declare VEC.
1697         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1698         std::vector.
1699         (struct s390_process_info): Add initializers.
1700         (s390_add_process): Use new.
1701         (s390_linux_nat_target::low_forget_process): Use delete.
1702         (s390_linux_nat_target::low_new_fork)
1703         (s390_linux_nat_target::stopped_by_watchpoint)
1704         (s390_linux_nat_target::low_prepare_to_resume)
1705         (s390_linux_nat_target::insert_watchpoint)
1706         (s390_linux_nat_target::insert_hw_breakpoint)
1707         (s390_linux_nat_target::remove_watchpoint)
1708         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1709
1710 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1711
1712         * aarch64-fbsd-nat.c: Include regcache.h.
1713         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1714         argument.
1715         (aarch64_fbsd_nat_target::fetch_registers)
1716         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1717         variable.
1718         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1719
1720 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1721
1722         * fbsd-nat.c: Include gdbarch.h.
1723
1724 2019-07-15  Tom Tromey  <tromey@adacore.com>
1725
1726         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1727
1728 2019-07-15  Tom Tromey  <tromey@adacore.com>
1729
1730         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1731         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1732         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1733         * cli-out.c (cli_ui_out::do_field_int): New method.
1734         * ui-out.c (ui_out::field_unsigned): New method.
1735         * symfile.c (generic_load): Use field_unsigned.
1736         (print_transfer_performance): Likewise.
1737         * record-btrace.c (ui_out_field_uint): Remove.
1738         (btrace_call_history_insn_range, btrace_call_history): Use
1739         field_unsigned.
1740         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1741         field_unsigned.
1742         * ui-out.h (class ui_out) <field_unsigned>: New method.
1743         <do_field_unsigned>: Likewise.
1744
1745 2019-07-15  Tom Tromey  <tromey@adacore.com>
1746
1747         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1748         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1749         * target.c (flash_erase_command): Use field_string.
1750         * infrun.c (print_signal_received_reason): Use field_string.
1751         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1752         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1753         field_string.
1754         * ada-tasks.c (print_ada_task_info): Use field_string.
1755
1756 2019-07-15  Tom Tromey  <tromey@adacore.com>
1757
1758         * target.c (flash_erase_command): Use field_core_addr.
1759         * symfile.c (generic_load): Use field_core_addr.
1760         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1761         Use field_core_addr.
1762         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1763         field_core_addr.
1764
1765 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1766
1767         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1768         value if its desired type is smaller than a CORE_ADDR and signed.
1769
1770 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1771
1772         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1773         of changes to field names, and use new is_reference field to
1774         decide if a property is a reference or not.
1775         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1776         field.
1777         (struct dwarf2_property_baton): Update header comment, rename
1778         'referenced_type' to 'property_type' and update comments.
1779         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1780         default property type, store in property baton, update to take
1781         accound of renamed field.
1782         (read_func_scope): Update call to attr_to_dynamic_prop.
1783         (read_array_type): Likewise.
1784         (dwarf2_per_cu_addr_sized_int_type): New function.
1785         (read_subrange_index_type): Move type finding code to
1786         dwarf2_per_cu_addr_sized_int_type.
1787         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1788         (dwarf2_per_cu_addr_type): New function.
1789         (set_die_type): Update calls to attr_to_dynamic_prop.
1790
1791 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1792
1793         * dwarf2read.c (read_subrange_index_type): New function.
1794         (read_subrange_type): Move code into new function and call it.
1795         * gdbtypes.c (create_range_type): Add some asserts.
1796
1797 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1798
1799         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1800         update return statements.
1801         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1802         declaration, and update comment to match.
1803         * gdbtypes.c (resolve_dynamic_array): Update call to
1804         dwarf2_evaluate_property to match new return type.
1805
1806 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1807
1808         * valarith.c (value_subscripted_rvalue): Change lowerbound
1809         parameter type from int to LONGEST.
1810         * value.h (value_subscripted_rvalue): Likewise in declaration.
1811
1812 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1813
1814         * cli/cli-utils.c (info_print_command_completer): New function.
1815         * cli/cli-utils.h: Add 'completer.h' include, and forward
1816         declaration for 'struct cmd_list_element'.
1817         (info_print_command_completer): Declare.
1818         * stack.c (_initialize_stack): Add completer for 'info locals' and
1819         'info args'.
1820         * symtab.c (_initialize_symtab): Add completer for 'info
1821         variables' and 'info functions'.
1822         * NEWS: Mention completion for additional info commands.
1823
1824 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1825
1826         * cli/cli-utils.c (extract_info_print_args): Delete.
1827         (extract_arg_maybe_quoted): Delete.
1828         (info_print_options_defs): New variable.
1829         (make_info_print_options_def_group): New function.
1830         (extract_info_print_options): Define new function.
1831         * cli/cli-utils.h (extract_info_print_args): Delete.
1832         (struct info_print_options): New structure.
1833         (extract_info_print_options): Declare new function.
1834         * stack.c (info_locals_command): Update to use new
1835         extract_info_print_options, also add a header comment.
1836         (info_args_command): Likewise.
1837         * symtab.c (info_variables_command): Likewise.
1838         (info_functions_command): Likewise.
1839
1840 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1841
1842         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1843         to extract string arguments.
1844         * common/common-utils.c (extract_string_maybe_quoted): New function.
1845         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1846
1847 2019-07-11  Tom Tromey  <tromey@adacore.com>
1848
1849         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1850         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1851         * top.h (gdbinit): Don't declare.
1852         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1853         into...
1854         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1855         * top.c (gdb_init): Don't call init_cli_cmds.
1856         (gdbinit): Remove.
1857         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1858
1859 2019-07-11  Tom Tromey  <tromey@adacore.com>
1860
1861         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1862         after it has been moved.
1863
1864 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1865
1866         * valops.c (value_must_coerce_to_target): Change return type to
1867         bool.
1868         * value.h (value_must_coerce_to_target): Likewise.
1869
1870 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1871
1872         * breakpoint.c (is_hardware_watchpoint): Remove
1873         forward-declaration.
1874         (is_masked_watchpoint): Change return type to bool.
1875         (is_tracepoint): Likewise.
1876         (is_breakpoint): Likewise.
1877         (is_hardware_watchpoint): Likewise.
1878         (is_watchpoint): Likewise.
1879         (is_no_memory_software_watchpoint): Likewise.
1880         (is_catchpoint): Likewise.
1881         (breakpoint_1): Make FILTER parameter's return type bool.
1882         is_masked_watchpoint): Change return type to bool.
1883         (save_breakpoints): Make FILTER parameter's return type bool.
1884         * breakpoint.h (is_breakpoint): Change return type to bool.
1885         (is_watchpoint): Likewise.
1886         (is_catchpoint): Likewise.
1887         (is_tracepoint): Likewise.
1888
1889 2019-07-10  Tom Tromey  <tom@tromey.com>
1890
1891         * defs.h: Don't include gdbarch.h.
1892         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1893         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1894         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1895         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1896         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1897         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1898         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1899         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1900         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1901         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1902         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1903         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1904         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1905         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1906         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1907         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1908         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1909         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1910         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1911         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1912         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1913         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1914         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1915         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1916         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1917         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1918         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1919
1920 2019-07-10  Tom Tromey  <tromey@adacore.com>
1921
1922         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1923         * breakpoint.c (init_ada_exception_breakpoint): Register as
1924         bp_catchpoint.
1925         (print_one_breakpoint_location, print_one_breakpoint): Use
1926         is_ada_exception_catchpoint.
1927         * ada-lang.c (class ada_catchpoint_location): Pass
1928         bp_loc_software_breakpoint to bp_location constructor.
1929         (is_ada_exception_catchpoint): New function.
1930
1931 2019-07-10  Tom Tromey  <tromey@adacore.com>
1932
1933         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1934         VEC.
1935         (struct arm_exidx_entry): New method operator<.
1936         (struct arm_exidx_data) <section_maps>: Change type.
1937         (arm_exidx_data_free): Remove.
1938         (arm_exidx_data_key): Change type.  Move lower.
1939         (arm_exidx_new_objfile): Update.
1940         (arm_compare_exidx_entries): Remove.
1941         (arm_find_exidx_entry, _initialize_arm_tdep)
1942
1943 2019-07-10  Tom Tromey  <tromey@adacore.com>
1944
1945         * solib-spu.c (ocl_program_data_key): Change type.
1946         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1947         Update.
1948
1949 2019-07-10  Tom Tromey  <tromey@adacore.com>
1950
1951         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1952         (struct solib_aix_inferior_data) <library_list>: Change type.
1953         (solib_aix_inferior_data_handle): Change type.
1954         (get_solib_aix_inferior_data): Update.
1955         (solib_aix_free_library_list): Remove.
1956         (library_list_start_library): Update.
1957         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1958         return type.
1959         (solib_aix_get_library_list)
1960         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1961         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1962
1963 2019-07-10  Tom Tromey  <tromey@adacore.com>
1964
1965         * solib-dsbt.c (struct dsbt_info): Add initializers.
1966         (solib_dsbt_pspace_data): Change type.
1967         (dsbt_pspace_data_cleanup): Remove.
1968         (get_dsbt_info, _initialize_dsbt_solib): Update.
1969
1970 2019-07-10  Tom Tromey  <tromey@adacore.com>
1971
1972         * spu-tdep.c (spu_overlay_data): Change type.
1973         (spu_get_overlay_table, spu_overlay_new_objfile)
1974         (_initialize_spu_tdep): Update.
1975
1976 2019-07-10  Tom Tromey  <tromey@adacore.com>
1977
1978         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1979         destructor.
1980         (dbx_objfile_data_key): Change type and declare later.
1981         (DBX_SYMFILE_INFO): Rewrite.
1982         * dbxread.c (dbx_objfile_data_key): Change type.
1983         (dbx_symfile_init): Update.
1984         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1985         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1986         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1987
1988 2019-07-10  Tom Tromey  <tromey@adacore.com>
1989
1990         * jit.c (jit_program_space_key): Change type.  Move lower.
1991         (get_jit_program_space_data): Update.
1992         (jit_program_space_data_cleanup): Remove.
1993         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1994         Update.
1995         (struct jit_program_space_data): Add initializers.
1996
1997 2019-07-10  Tom Tromey  <tromey@adacore.com>
1998
1999         * solib-darwin.c (struct darwin_info): Add initializers.
2000         (solib_darwin_pspace_data): Change type.
2001         (darwin_pspace_data_cleanup): Remove.
2002         (get_darwin_info, _initialize_darwin_solib): Update.
2003
2004 2019-07-10  Tom Tromey  <tromey@adacore.com>
2005
2006         * remote-sim.c (struct sim_inferior_data): Add initializers,
2007         constructor, and destructor.
2008         (sim_inferior_data_key): Change type.  Move lower.
2009         (check_for_duplicate_sim_descriptor): Update.
2010         (get_sim_inferior_data): Use new.  Update.
2011         (~sim_inferior_data_cleanup): Rename from
2012         sim_inferior_data_cleanup.  Simplify.
2013         (gdbsim_close_inferior, simulator_command)
2014         (sim_command_completer, _initialize_remote_sim): Update.
2015         (next_pid, INITIAL_PID): Move earlier.
2016
2017 2019-07-10  Tom Tromey  <tromey@adacore.com>
2018
2019         * python/python-internal.h (create_thread_object): Return
2020         gdbpy_ref.
2021         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2022         * python/py-inferior.c (struct threadlist_entry): Add
2023         constructor.
2024         <thread_obj>: Now a gdbpy_ref.
2025         (thread_to_thread_object): Update.
2026         (add_thread_object): Use new.
2027         (delete_thread_object): Use delete.
2028         (infpy_threads): Update.
2029         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2030         GIL.
2031
2032 2019-07-10  Tom Tromey  <tromey@adacore.com>
2033
2034         * valops.c (value_cast): Specialize error message for Ada.
2035
2036 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2037
2038         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2039
2040 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2041
2042         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2043         bpstat_should_step): Return bool, adjust comments.
2044         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2045         bpstat_should_step): Likewise.
2046
2047 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2048
2049         * features/Makefile: Use feature target descriptions for Arm.
2050         * features/arm/arm-core.c: Generate new file.
2051         * features/arm/arm-fpa.c: Likewise.
2052         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2053         * features/arm/arm-m-profile.c: Likewise.
2054         * features/arm/arm-vfpv2.c: Likewise.
2055         * features/arm/arm-vfpv3.c: Likewise.
2056         * features/arm/xscale-iwmmxt.c: Likewise.
2057         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2058
2059 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2060
2061         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2062         ptrace earlier.
2063
2064 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2065
2066         * features/aarch64-pauth.c: Regenerate.
2067
2068 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2069
2070         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2071         bool.
2072         (bpstat_what): Use false instead of 0.
2073
2074 2019-07-09  Pedro Alves  <palves@redhat.com>
2075
2076         * break-catch-throw.c (is_exception_catchpoint): New.
2077         * breakpoint.c (print_one_breakpoint_location): New parameter
2078         'raw_loc'.  Handle it.  Use
2079         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2080         looking at the breakpoint's type.
2081         (print_one_breakpoint): If handling "maint info breakpoints", also
2082         print locations of exception catchpoints.
2083         * breakpoint.h (is_exception_catchpoint): Declare.
2084
2085 2019-07-09  Pedro Alves  <palves@redhat.com>
2086
2087         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2088         "addr" field.
2089         (allocate_location_exception_catchpoint): New.
2090         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2091         (initialize_throw_catchpoint_ops): Install
2092         allocate_location_exception_catchpoint as allocate_location
2093         method.
2094         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2095         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2096         bp_loc_other.
2097         (breakpoint_address_is_meaningful): Delete.
2098         (bl_address_is_meaningful): New.
2099         (breakpoint_locations_match): Adjust comment.
2100         (bp_location_from_bp_type): New, factored out of...
2101         (bp_location::bp_location(breakpoint *)): ... this.
2102         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2103         factored out of...
2104         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2105         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2106         breakpoint_address_is_meaningful.
2107         (bp_locations_compare): Adjust comment.
2108         (update_global_location_list): Use bl_address_is_meaningful
2109         instead of breakpoint_address_is_meaningful.
2110         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2111         explicit.
2112         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2113         * python/py-breakpoint.c (bppy_get_location): No longer check
2114         whether location is null.
2115
2116 2019-07-09  Pedro Alves  <palves@redhat.com>
2117
2118         PR c++/15468
2119         * breakpoint.c (print_one_breakpoint_location): Remove
2120         single-location assert.
2121
2122 2019-07-09  Tom Tromey  <tom@tromey.com>
2123
2124         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2125         * configure: Rebuild.
2126         * configure.ac: Change common to gdbsupport.
2127         * gdbsupport: Rename from common.
2128         * acinclude.m4: Change common to gdbsupport.
2129         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2130         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2131         gdbsupport.
2132         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2133         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2134         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2135         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2136         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2137         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2138         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2139         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2140         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2141         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2142         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2143         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2144         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2145         coff-pe-read.c, command.h, compile/compile-c-support.c,
2146         compile/compile-c.h, compile/compile-cplus-symbols.c,
2147         compile/compile-cplus-types.c, compile/compile-cplus.h,
2148         compile/compile-loc2c.c, compile/compile.c, completer.c,
2149         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2150         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2151         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2152         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2153         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2154         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2155         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2156         features/aarch64-core.c, features/aarch64-fpu.c,
2157         features/aarch64-pauth.c, features/aarch64-sve.c,
2158         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2159         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2160         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2161         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2162         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2163         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2164         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2165         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2166         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2167         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2168         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2169         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2170         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2171         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2172         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2173         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2174         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2175         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2176         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2177         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2178         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2179         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2180         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2181         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2182         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2183         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2184         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2185         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2186         minsyms.c, mips-linux-tdep.c, namespace.h,
2187         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2188         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2189         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2190         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2191         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2192         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2193         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2194         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2195         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2196         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2197         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2198         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2199         procfs.c, producer.c, progspace.h, psymtab.h,
2200         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2201         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2202         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2203         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2204         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2205         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2206         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2207         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2208         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2209         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2210         target-memory.c, target.c, target.h, target/waitstatus.c,
2211         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2212         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2213         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2214         unittests/array-view-selftests.c,
2215         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2216         unittests/common-utils-selftests.c,
2217         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2218         unittests/format_pieces-selftests.c,
2219         unittests/function-view-selftests.c,
2220         unittests/lookup_name_info-selftests.c,
2221         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2222         unittests/mkdir-recursive-selftests.c,
2223         unittests/observable-selftests.c,
2224         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2225         unittests/parse-connection-spec-selftests.c,
2226         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2227         unittests/scoped_fd-selftests.c,
2228         unittests/scoped_mmap-selftests.c,
2229         unittests/scoped_restore-selftests.c,
2230         unittests/string_view-selftests.c, unittests/style-selftests.c,
2231         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2232         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2233         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2234         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2235         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2236         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2237
2238 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2239
2240         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2241         bool value.
2242         (decode_digits_ordinary): Set explicit_line field in sal.
2243         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2244         symtab_and_line that was set on an explicit line number in
2245         assembler code.  Do always update the recorded symtab and line if
2246         we do skip the prologue.
2247
2248 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2249
2250         * breakpoint.c (set_breakpoint_location_function): Remove
2251         explicit_loc parameter.
2252         (momentary_breakpoint_from_master): Update call to
2253         set_breakpoint_location_function.
2254         (add_location_to_breakpoint): Likewise.
2255
2256 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2257
2258         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2259         required features based on default bfd type when no specific bfd
2260         is present.
2261
2262 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2263
2264         * NEWS: Mention that GDB printf and eval commands can now print
2265         C-style and Ada-style convenience var strings without
2266         calling the inferior.
2267         * printcmd.c (printf_c_string): Locally print GDB internal var
2268         instead of transiting via the inferior.
2269         (printf_wide_c_string): Likewise.
2270
2271 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2272
2273         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2274
2275 2019-07-04  Tom Tromey  <tom@tromey.com>
2276
2277         PR tui/24724:
2278         * tui/tui-winsource.c (tui_clear_source_content): Update.
2279         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2280         (tui_update_breakpoint_info): Update.
2281         (tui_set_exec_info_content): Update.
2282         * tui/tui-source.c (tui_set_source_content_nil): Update.
2283         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2284         has_break.
2285         * tui/tui-data.h (enum tui_bp_flag): New.
2286         (tui_bp_flags): New enum flags type.
2287         (struct tui_source_element) <break_mode>: Change type.  Rename
2288         from has_break.
2289         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2290         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2291         constants.
2292         * tui/tui-winsource.h: Fix comment.
2293
2294 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2295
2296         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2297         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2298         (store_fpregs_to_thread)
2299         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2300         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2301         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2302         (IWMMXT_REGS_SIZE): Add define.
2303         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2304         (fetch_vfp_regs, store_vfp_regs)
2305         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2306         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2307
2308 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2309
2310         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2311         defines.
2312         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2313         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2314         (ARM_INT_REGISTER_SIZE): ...to this.
2315         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2316         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2317         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2318         (arm_linux_collect_gregset, supply_nwfpe_register)
2319         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2320         defines.
2321         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2322         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2323         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2324         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2325         (arm_return_in_memory, arm_store_return_value)
2326         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2327         (arm_record_ld_st_multiple): Likewise.
2328         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2329         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2330
2331 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2332
2333         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2334         AARCH64_DISPLACED_MODIFIED_INSNS.
2335         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2336         (aarch64_displaced_step_copy_insn): Likewise.
2337         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2338         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2339         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2340         ARM_DISPLACED_MODIFIED_INSNS.
2341         * arm-tdep.c (arm_gdbarch_init): Likewise.
2342         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2343         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2344         (struct arm_displaced_step_closure): Use
2345         ARM_DISPLACED_MODIFIED_INSNS.
2346
2347 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2348
2349         * features/Makefile: Remove unused xml files.
2350         * features/aarch64.xml: Remove.
2351         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2352         * features/i386/amd64-avx-avx512.xml: Remove.
2353         * features/i386/amd64-avx-linux.xml: Remove.
2354         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2355         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2356         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2357         * features/i386/amd64-avx-mpx.xml: Remove.
2358         * features/i386/amd64-avx.xml: Remove.
2359         * features/i386/amd64-linux.xml: Remove.
2360         * features/i386/amd64-mpx-linux.xml: Remove.
2361         * features/i386/amd64-mpx.xml: Remove.
2362         * features/i386/amd64.xml: Remove.
2363         * features/i386/i386-avx-avx512-linux.xml: Remove.
2364         * features/i386/i386-avx-avx512.xml: Remove.
2365         * features/i386/i386-avx-linux.xml: Remove.
2366         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2367         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2368         * features/i386/i386-avx-mpx-linux.xml: Remove.
2369         * features/i386/i386-avx-mpx.xml: Remove.
2370         * features/i386/i386-avx.xml: Remove.
2371         * features/i386/i386-linux.xml: Remove.
2372         * features/i386/i386-mmx-linux.xml: Remove.
2373         * features/i386/i386-mmx.xml: Remove.
2374         * features/i386/i386-mpx-linux.xml: Remove.
2375         * features/i386/i386-mpx.xml: Remove.
2376         * features/i386/i386.xml: Remove.
2377         * features/i386/x32-avx-avx512-linux.xml: Remove.
2378         * features/i386/x32-avx-linux.xml: Remove.
2379         * features/i386/x32-linux.xml: Remove.
2380
2381 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2382
2383         * regformats/aarch64.dat: Remove.
2384         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2385         * regformats/i386/amd64-avx-linux.dat: Remove.
2386         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2387         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2388         * regformats/i386/amd64-linux.dat: Remove.
2389         * regformats/i386/amd64-mpx-linux.dat: Remove.
2390         * regformats/i386/amd64.dat: Remove.
2391         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2392         * regformats/i386/i386-avx-linux.dat: Remove.
2393         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2394         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2395         * regformats/i386/i386-linux.dat: Remove.
2396         * regformats/i386/i386-mmx-linux.dat: Remove.
2397         * regformats/i386/i386-mpx-linux.dat: Remove.
2398         * regformats/i386/i386.dat: Remove.
2399         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2400         * regformats/i386/x32-avx-linux.dat: Remove.
2401         * regformats/i386/x32-linux.dat: Remove.
2402
2403 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2404
2405         * aarch64-tdep.c: Remove xml self tests.
2406         * amd64-linux-tdep.c: Likewise.
2407         * amd64-tdep.c: Likewise.
2408         * i386-linux-tdep.c: Likewise.
2409         * i386-tdep.c: Likewise.
2410
2411 2019-07-03  Pedro Alves  <palves@redhat.com>
2412
2413         PR cli/24732
2414         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2415         (pipe_cmd_option_defs): New.
2416         (make_pipe_cmd_options_def_group): New.
2417         (pipe_command): Use gdb::option::process_options.
2418         (pipe_command_completer): New function.
2419         (_initialize_cli_cmds): Install completer for "pipe" command.
2420
2421 2019-07-03  Pedro Alves  <palves@redhat.com>
2422
2423         * cli/cli-option.c (union option_value) <string>: New field.
2424         (struct option_def_and_value): Add ctor, move ctor, dtor and
2425         use DISABLE_COPY_AND_ASSIGN.
2426         (option_def_and_value::clear_value): New.
2427         (parse_option, save_option_value_in_ctx, get_val_type_str)
2428         (add_setshow_cmds_for_options): Handle var_string.
2429         * cli-option.h (union option_def::var_address) <string>: New
2430         field.
2431         (struct string_option_def): New.
2432         * maint-test-options.c (struct test_options_opts): Add default
2433         ctor and use DISABLE_COPY_AND_ASSIGN.
2434         <string_opt>: New field.
2435         (test_options_opts::~test_options_opts): New.
2436         (test_options_opts::dump): Also dump "-string".
2437         (test_options_option_defs): Install "string.
2438
2439 2019-07-03  Pedro Alves  <palves@redhat.com>
2440
2441         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2442         option_value with a null enumeration.
2443         (complete_options): Save the option values in the context.
2444         (save_option_value_in_ctx): New, factored out from ...
2445         (process_options): ... here.
2446         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2447         of the function.
2448         * maint-test-options.c (test_options_opts::dump): New, factored
2449         out from ...
2450         (maintenance_test_options_command_mode): ... here.
2451         (maintenance_test_options_command_completion_result): Delete.
2452         (maintenance_test_options_command_completion_text): Update
2453         comment.
2454         (maintenance_show_test_options_completion_result): Change
2455         prototype.  Just print
2456         maintenance_test_options_command_completion_text.
2457         (save_completion_result): New.
2458         (maintenance_test_options_completer_mode): Pass options context to
2459         complete_options, and then save a dump.
2460         (_initialize_maint_test_options): Use add_cmd to install "maint
2461         show test-options-completion-result".
2462
2463 2019-07-03  Pedro Alves  <palves@redhat.com>
2464
2465         * NEWS (New commands): Mention "with" and "maint with".
2466         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2467         (with_command, with_command_completer): New.
2468         (pipe_command): Adjust to new repeat_previous
2469         interface.
2470         (_initialize_cli_cmds): Install the "with" command and its "w"
2471         alias.
2472         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2473         declarations.
2474         * cli/cli-setshow.c (parse_cli_var_uinteger)
2475         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2476         argument strings for all var_types.
2477         (get_setshow_command_value_string): New, factored out from ...
2478         (do_show_command): ... this.
2479         * cli/cli-setshow.h: Include <string>.
2480         (get_setshow_command_value_string): Declare.
2481         * command.h (repeat_previous): Now returns const char *.  Adjust
2482         comment.
2483         * maint.c: Include "cli/cli-cmds.h".
2484         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2485         (_initialize_maint_cmds): Register the "maintenance with" command.
2486         * top.c (repeat_previous): Move bits from pipe_command here:
2487         Return the saved command line, if any; error out if there's no
2488         command to relaunch.
2489
2490 2019-07-03  Pedro Alves  <palves@redhat.com>
2491
2492         * NEWS (New commands): Mention "maint set/show test-settings"
2493         instead of "maint test-settings".
2494         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2495         (maintenance_test_settings_set_list): Rename to ...
2496         (maintenance_set_test_settings_list): ... this.
2497         (maintenance_test_settings_show_list): Rename to  ...
2498         (maintenance_show_test_settings_list): ... this.
2499         (maintenance_test_settings_cmd): Delete.
2500         (maintenance_test_settings_set_cmd): ...
2501         (maintenance_set_test_settings_cmd): ... this.
2502         (maintenance_test_settings_show_cmd): ...
2503         (maintenance_show_test_settings_cmd): ... this.
2504         (maintenance_test_settings_show_value_cmd):
2505         (maintenance_show_test_settings_value_cmd): ... this.
2506         (_initialize_maint_test_settings): No longer install the "maint
2507         test-settings" prefix command.  Rename "maint test-settings set"
2508         to "maint set test-settings", and "maint test-settings show" to
2509         "maint show test-settings".  Adjust all subcommands.
2510
2511 2019-07-03  Pedro Alves  <palves@redhat.com>
2512
2513         * maint-test-settings.c: Fix file's intro comment.  Replace all
2514         references to "test-options" with references to "test-settings",
2515         in comments.
2516
2517 2019-07-03  Pedro Alves  <palves@redhat.com>
2518
2519         * maint-test-settings.c (maintenance_test_settings_xxx)
2520         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2521         New.
2522         (maintenance_test_settings_enums): Use them.
2523         (maintenance_test_settings_enum): Default to
2524         maintenance_test_settings_xxx.
2525         (_initialize_maint_test_settings): Initialize
2526         MAINTENANCE_TEST_SETTINGS_FILENAME.
2527
2528 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2529
2530         * breakpoint.h (remove_breakpoints_inf): Change return type to
2531         void, move function documentation here.
2532         * breakpoint.c (remove_breakpoints_inf): Change return type to
2533         void, move function documentation to header.
2534
2535 2019-07-02  Pedro Alves  <palves@redhat.com>
2536
2537         * NEWS (Completion improvements): Mention "info threads".
2538         * thread.c (struct info_threads_opts, info_threads_option_defs)
2539         (make_info_threads_options_def_group): New.
2540         (info_threads_command): Use gdb::option::process_options.
2541         (info_threads_command_completer): New.
2542         (_initialize_thread): Use gdb::option::build_help to build the
2543         help text for "info threads".
2544
2545 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2546
2547         * defs.h (generic_load): Move from here...
2548         * symfile.h (generic_load): ... to here.  Rename name parameter
2549         to args.
2550         * symfile.c (generic_load): Add comment.
2551
2552 2019-07-01  Tom Tromey  <tromey@adacore.com>
2553
2554         * dwarf2read.c
2555         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2556         declaration of without_params.  Fix formatting.
2557
2558 2019-07-01  Tom Tromey  <tromey@adacore.com>
2559
2560         * ada-exp.y (find_primitive_type): Update.
2561         * ada-lang.h (ada_lookup_symbol): Update.
2562         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2563         parameter.
2564         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2565
2566 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2567
2568         PR breakpoints/24541
2569         * gdbarch.c: Regenerate.
2570         * gdbarch.h: Regenerate.
2571         * gdbarch.sh: Add 'stap_adjust_register'.
2572         * i386-tdep.c: Include '<unordered_set>'.
2573         (i386_stap_adjust_register): New function.
2574         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2575         * stap-probe.c (stap_parse_register_operand): Call
2576         'gdbarch_stap_adjust_register'.
2577
2578 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2579
2580         PR python/24742
2581         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2582         * python/python.c (do_start_initialization): Use 'xmalloc'
2583         instead of 'PyMem_Malloc'.
2584
2585 2019-06-28  Tom Tromey  <tromey@adacore.com>
2586
2587         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2588         for Ada.
2589
2590 2019-06-27  Tom Tromey  <tromey@adacore.com>
2591
2592         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2593         objfile_key.
2594         (arm_find_mapping_symbol, arm_record_special_symbol)
2595         (_initialize_arm_tdep): Update.
2596         (arm_objfile_data_free): Remove.
2597
2598 2019-06-27  Tom Tromey  <tromey@adacore.com>
2599
2600         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2601         to cp_print_static_field.
2602
2603 2019-06-26  Tom Tromey  <tromey@adacore.com>
2604
2605         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2606         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2607         declare.
2608
2609 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2610
2611         * features/aarch64-core.c (create_feature_aarch64_core):
2612         Regenerate.
2613         * features/aarch64-core.xml: Add cpsr flags.
2614
2615 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2616
2617         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2618         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2619
2620 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2621
2622         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2623         field.
2624         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2625         use.
2626         (arm_record_special_symbol): Don't insert new symbol in sorted
2627         position, push it at the end.
2628
2629 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2630
2631         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2632         (arm_mapping_symbol_s): Remove.
2633         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2634         (arm_mapping_symbol_vec): New typedef.
2635         (struct arm_per_objfile): Add constructor.
2636         <section_maps>: Change type to
2637         std::unique_ptr<arm_mapping_symbol_vec[]>.
2638         (arm_compare_mapping_symbols): Remove.
2639         (arm_find_mapping_symbol): Adjust to section_maps type change.
2640         (arm_objfile_data_free): Call delete on arm_per_objfile.
2641         (arm_record_special_symbol): Adjust to section_maps type change.
2642         Allocate arm_per_objfile with new.
2643
2644 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2645
2646         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2647         with the command prefix.
2648
2649 2019-06-25  Tom Tromey  <tom@tromey.com>
2650
2651         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2652         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2653
2654 2019-06-25  Tom Tromey  <tom@tromey.com>
2655
2656         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2657         type.
2658         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2659         protected.
2660
2661 2019-06-25  Tom Tromey  <tom@tromey.com>
2662
2663         * tui/tui-winsource.c
2664         (tui_source_window_base::set_is_exec_point_at): Add check against
2665         LOA_ADDRESS.
2666
2667 2019-06-25  Tom Tromey  <tom@tromey.com>
2668
2669         * tui/tui-source.c (tui_set_source_content): Don't check before
2670         xfree.
2671         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2672
2673 2019-06-25  Tom Tromey  <tom@tromey.com>
2674
2675         * tui/tui-winsource.h (tui_update_source_window_as_is)
2676         (tui_alloc_source_buffer, tui_line_is_displayed)
2677         (tui_addr_is_displayed): Change type of win_info.
2678         * tui/tui-winsource.c (tui_update_source_window_as_is)
2679         (tui_clear_source_content, tui_show_source_line)
2680         (tui_show_source_content, tui_source_window_base::refill)
2681         (tui_source_window_base::set_is_exec_point_at)
2682         (tui_source_window_base::set_is_exec_point_at)
2683         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2684         (tui_alloc_source_buffer, tui_line_is_displayed)
2685         (tui_addr_is_displayed): Change type of win_info.  Update.
2686         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2687         (tui_source_window_base::do_make_visible_with_new_height):
2688         Update.
2689         * tui/tui-source.c (tui_set_source_content)
2690         (tui_set_source_content_nil)
2691         (tui_source_window::do_scroll_vertical): Update.
2692         * tui/tui-layout.c (show_layout): Update.
2693         * tui/tui-disasm.c (tui_set_disassem_content)
2694         (tui_disasm_window::do_scroll_vertical): Update.
2695         * tui/tui-data.h (tui_win_content): Remove.
2696         (struct tui_gen_win_info) <content, content_size>: Remove.
2697         (struct tui_source_element): Add initializers and destructor.
2698         (union tui_which_element, struct tui_win_element): Remove.
2699         (struct tui_source_window_base) <content>: New field.
2700         (struct tui_data_window): Remove destructor.
2701         (tui_alloc_content, tui_free_win_content)
2702         (tui_free_all_source_wins_content): Don't declare.
2703         * tui/tui-data.c (tui_initialize_static_data): Update.
2704         (init_content_element, tui_alloc_content): Remove.
2705         (~tui_gen_win_info): Update.
2706         (~tui_data_window, tui_free_all_source_wins_content)
2707         (tui_free_win_content, free_content, free_content_elements):
2708         Remove.
2709
2710 2019-06-25  Tom Tromey  <tom@tromey.com>
2711
2712         * tui/tui-winsource.h (tui_clear_source_content)
2713         (tui_erase_source_content, tui_show_source_content): Change type
2714         of win_info.
2715         * tui/tui-winsource.c (tui_clear_source_content)
2716         (tui_erase_source_content, tui_show_source_content): Change type
2717         of win_info.
2718         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2719         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2720         win_info.
2721         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2722         win_info.
2723         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2724
2725 2019-06-25  Tom Tromey  <tom@tromey.com>
2726
2727         * tui/tui-winsource.c (tui_clear_source_content)
2728         (tui_source_window_base::set_is_exec_point_at): Update.
2729         * tui/tui-source.c (tui_set_source_content_nil): Update.
2730         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2731         a bool.
2732         * tui/tui-data.c (init_content_element): Update.
2733
2734 2019-06-25  Tom Tromey  <tom@tromey.com>
2735
2736         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2737         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2738         * tui/tui-layout.c (init_and_make_win): Update.
2739         * tui/tui.h (enum tui_win_type): Update.
2740         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2741         tui_win_is_auxillary.
2742         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2743         tui_win_is_auxillary.
2744
2745 2019-06-25  Tom Tromey  <tom@tromey.com>
2746
2747         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2748         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2749         (tui_delete_data_content_windows, tui_display_all_data)
2750         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2751         Update.
2752         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2753         * tui/tui-regs.c (tui_last_regs_line_no)
2754         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2755         (tui_show_registers): Update.
2756         (tui_show_register_group): Return void.  Update.
2757         (tui_display_registers_from, tui_display_reg_element_at_line)
2758         (tui_display_registers_from_line, tui_check_register_values):
2759         Update.
2760         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2761         member.
2762         (struct tui_data_window) <regs_content>: Now a std::vector.
2763         <regs_content_count>: Remove.
2764         (tui_add_content_elements, tui_free_data_content): Don't declare.
2765         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2766         (init_content_element): Remove DATA_WIN case.  Add assert.
2767         (tui_add_content_elements): Remove.
2768         (tui_data_window): Update.
2769         (tui_free_data_content): Remove.
2770         (free_content_elements): Remove DATA_WIN case.
2771
2772 2019-06-25  Tom Tromey  <tom@tromey.com>
2773
2774         * tui/tui-data.c (tui_data_item_window): Update.
2775         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2776         * tui/tui-windata.c (tui_display_all_data)
2777         (tui_display_data_from_line): Update.
2778         (tui_check_data_values): Remove.
2779         * tui/tui-regs.c (tui_show_register_group)
2780         (tui_display_reg_element_at_line): Update.
2781         * tui/tui-hooks.c (tui_register_changed)
2782         (tui_refresh_frame_and_register_information): Call
2783         tui_check_register_values.
2784         * tui/tui-data.h (struct tui_data_window) <data_content,
2785         data_content_count, data_type>: Remove.
2786         (enum tui_data_type): Remove.
2787
2788         * tui/tui-data.c (tui_data_window::clear_detail)
2789         (~tui_data_window): Update.
2790
2791 2019-06-25  Tom Tromey  <tom@tromey.com>
2792
2793         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2794         declare.
2795         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2796         Rename from tui_first_data_item_displayed.  Update.
2797         (tui_data_window::refresh_all)
2798         (tui_data_window::do_scroll_vertical): Update.
2799         * tui/tui-data.h (struct tui_data_window)
2800         <first_data_item_displayed>: Declare new method.
2801
2802 2019-06-25  Tom Tromey  <tom@tromey.com>
2803
2804         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2805         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2806         contents...
2807         (tui_initialize_static_data): ...here.
2808
2809 2019-06-25  Tom Tromey  <tom@tromey.com>
2810
2811         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2812         (tui_display_registers_from, tui_check_register_values): Update.
2813         (tui_display_register): Remove win_info parameter; update.
2814         (tui_get_register): Change type of parameters.
2815         * tui/tui-data.h (struct tui_data_element): Remove.
2816         (union tui_which_element) <data>: Remove.
2817         <data_window>: Change type.
2818         (struct tui_data_item_window): New.
2819         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2820         case.  Add assert.
2821         (~tui_data_item_window): New destructor.
2822         (free_content_elements): Remove DATA_ITEM_WIN case.
2823
2824 2019-06-25  Tom Tromey  <tom@tromey.com>
2825
2826         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2827         Remove.
2828
2829 2019-06-25  Tom Tromey  <tom@tromey.com>
2830
2831         * tui/tui-data.h (struct tui_command_element): Remove.
2832         (union tui_which_element) <command>: Remove.
2833         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2834         assert.
2835         (free_content_elements): Remove CMD_WIN case.
2836
2837 2019-06-25  Tom Tromey  <tom@tromey.com>
2838
2839         * tui/tui-layout.c (tui_set_layout): Update.
2840         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2841         * tui/tui-data.c (layout_def): Update.
2842
2843 2019-06-25  Tom Tromey  <tom@tromey.com>
2844
2845         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2846         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2847         (tui_source_window_base::set_new_height): Update.
2848         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2849         Update.
2850         (tui_set_locator_fullname, tui_set_locator_info)
2851         (tui_show_frame_info): Update.
2852         * tui/tui-source.c (tui_set_source_content)
2853         (tui_source_is_displayed): Update.
2854         * tui/tui-layout.c (show_source_disasm_command, show_data)
2855         (show_source_or_disasm_and_command): Update.
2856         * tui/tui-disasm.c (tui_set_disassem_content)
2857         (tui_get_begin_asm_address): Update.
2858         * tui/tui-data.h (struct tui_locator_element): Remove.
2859         (union tui_which_element) <locator>: Remove.
2860         (struct tui_locator_window): New.
2861         (tui_locator_win_info_ptr): Change return type.
2862         * tui/tui-data.c (_locator): Change type.
2863         (tui_locator_win_info_ptr): Change return type.
2864         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2865         (tui_alloc_content): Add assert.
2866
2867 2019-06-25  Tom Tromey  <tom@tromey.com>
2868
2869         * tui/tui-winsource.c
2870         (tui_exec_info_window::maybe_allocate_content): New method.
2871         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2872         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2873         (make_source_or_disasm_window): Add cast.
2874         * tui/tui-data.h (union tui_which_element) <simple_string>:
2875         Remove.
2876         (struct tui_source_info): New.
2877         (struct tui_source_window_base) <execution_info>: Change type.
2878         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2879         case, and add assert.
2880         (tui_alloc_content): Add assert.
2881
2882 2019-06-25  Tom Tromey  <tom@tromey.com>
2883
2884         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2885         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2886         * tui/tui-data.c (tui_alloc_win_info): Remove.
2887
2888 2019-06-25  Tom Tromey  <tom@tromey.com>
2889
2890         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2891         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2892         can_highlight.
2893
2894 2019-06-25  Tom Tromey  <tom@tromey.com>
2895
2896         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2897         make_visible_with_new_height method.
2898         (tui_win_info::make_visible_with_new_height): New method.
2899         (tui_source_window_base::do_make_visible_with_new_height)
2900         (tui_data_window::do_make_visible_with_new_height)
2901         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2902         (make_visible_with_new_height): Remove.
2903         (tui_resize_all, tui_adjust_win_heights): Use
2904         make_visible_with_new_height method.
2905         * tui/tui-data.h (struct tui_win_info)
2906         <do_make_visible_with_new_height, make_visible_with_new_height>:
2907         New methods.
2908         (struct tui_source_window_base, struct tui_data_window)
2909         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2910         methods.
2911
2912 2019-06-25  Tom Tromey  <tom@tromey.com>
2913
2914         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2915         method.
2916         (update_tab_width): Call update_tab_width method.
2917         * tui/tui-data.h (struct tui_win_info)
2918         (struct tui_source_window_base) <update_tab_width>: New methods.
2919
2920 2019-06-25  Tom Tromey  <tom@tromey.com>
2921
2922         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2923         parameter.
2924         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2925         parameter.
2926         (tui_gen_win_info::make_visible): Update.
2927         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2928         parameter.
2929         * tui/tui-data.h (enum tui_box): New enum.
2930         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2931
2932 2019-06-25  Tom Tromey  <tom@tromey.com>
2933
2934         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2935         init_and_make_win for EXEC_INFO_WIN.
2936         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2937         longer inline.
2938         (struct tui_win_info) <~tui_win_info>: Inline.
2939         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2940         Don't declare.
2941         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2942         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2943         Remove.
2944         (tui_initialize_static_data): Update.
2945         (~tui_gen_win_info): Handle more cleanup here.
2946         (~tui_source_window_base): Delete "execution_info".
2947         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2948
2949 2019-06-25  Tom Tromey  <tom@tromey.com>
2950
2951         * tui/tui-layout.c (make_command_window): Don't set
2952         can_highlight.
2953         (show_source_disasm_command): Call the reset method.
2954         (show_data): Don't set can_highlight.  Call the reset method.
2955         (tui_gen_win_info::reset): Rename from init_gen_win_info
2956         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2957         (show_source_or_disasm_and_command): Call the reset method.
2958         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2959         (struct tui_cmd_window): Set can_highlight.
2960
2961 2019-06-25  Tom Tromey  <tom@tromey.com>
2962
2963         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2964         from make_visible.
2965         (tui_make_visible, tui_make_invisible): Rewrite.
2966         (tui_win_info::make_visible): Remove.
2967         (tui_source_window_base::make_visible): Update.
2968         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2969         method.  Moved from...
2970         (struct tui_win_info) <make_visible>: ...here.
2971
2972 2019-06-25  Tom Tromey  <tom@tromey.com>
2973
2974         * tui/tui-winsource.c
2975         (tui_source_window_base::do_scroll_horizontal): Remove direction
2976         parameter.
2977         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2978         direction parameter.
2979         * tui/tui-win.c (tui_win_info::forward_scroll)
2980         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2981         (tui_win_info::right_scroll): Update.
2982         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2983         direction parameter.
2984         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2985         direction parameter.
2986         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2987         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2988         Remove direction parameter.
2989         (struct tui_source_window_base, struct tui_source_window)
2990         (struct tui_disasm_window, struct tui_data_window)
2991         (struct tui_cmd_window): Update.
2992
2993 2019-06-25  Tom Tromey  <tom@tromey.com>
2994
2995         * tui/tui-winsource.h (tui_set_exec_info_content)
2996         (tui_show_exec_info_content, tui_erase_exec_info_content)
2997         (tui_clear_exec_info_content, tui_update_exec_info): Change
2998         argument to tui_source_window_base.
2999         * tui/tui-winsource.c (tui_set_exec_info_content)
3000         (tui_show_exec_info_content, tui_erase_exec_info_content)
3001         (tui_clear_exec_info_content, tui_update_exec_info): Change
3002         argument to tui_source_window_base.
3003
3004 2019-06-25  Tom Tromey  <tom@tromey.com>
3005
3006         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3007         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3008
3009 2019-06-25  Tom Tromey  <tom@tromey.com>
3010
3011         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3012         check.
3013
3014 2019-06-25  Tom Tromey  <tom@tromey.com>
3015
3016         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3017         type to void.
3018         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3019         type to void.
3020         * tui/tui-source.c (tui_set_source_content): Update.
3021         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3022
3023 2019-06-25  Tom Tromey  <tom@tromey.com>
3024
3025         * tui/tui-win.c (window_name_completer, tui_set_focus)
3026         (tui_all_windows_info): Use name method.
3027         * tui/tui-data.h (struct tui_gen_win_info)
3028         (struct tui_source_window, struct tui_disasm_window)
3029         (struct tui_data_window, struct tui_cmd_window) <name>: New
3030         method.
3031         (tui_win_name): Don't declare.
3032         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3033         (tui_win_name): Remove.
3034
3035 2019-06-25  Tom Tromey  <tom@tromey.com>
3036
3037         * tui/tui-winsource.h (tui_update_source_window)
3038         (tui_update_source_window_as_is): Change parameter type.
3039         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3040         to be a tui_source_window_base.
3041         (tui_update_source_window_as_is): Likewise.
3042         * tui/tui-win.c (make_visible_with_new_height): Update.
3043
3044 2019-06-25  Tom Tromey  <tom@tromey.com>
3045
3046         * tui/tui-winsource.c (tui_erase_source_content)
3047         (tui_show_source_content, tui_show_exec_info_content)
3048         (tui_erase_exec_info_content): Use refresh_window method.
3049         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3050         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3051         from tui_refresh_win.
3052         (tui_data_window::refresh_window): New method.
3053         (tui_win_info::refresh, tui_source_window_base::refresh)
3054         (tui_refresh_all): Use refresh_window method.
3055         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3056         method.
3057         * tui/tui-regs.c (tui_display_register): Call refresh_window
3058         method.
3059         * tui/tui-layout.c (show_source_disasm_command)
3060         (show_source_or_disasm_and_command): Call refresh_window method.
3061         * tui/tui-data.h (struct tui_gen_win_info)
3062         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3063         New method.
3064
3065 2019-06-25  Tom Tromey  <tom@tromey.com>
3066
3067         * tui/tui.c (tui_rl_other_window, tui_enable)
3068         (tui_is_window_visible, tui_get_command_dimension): Update.
3069         * tui/tui-winsource.c (tui_update_source_window_as_is)
3070         (tui_clear_source_content, tui_erase_source_content)
3071         (tui_show_source_line, tui_source_window_base::refill)
3072         (tui_source_window_base::do_scroll_horizontal)
3073         (tui_source_window_base::set_is_exec_point_at)
3074         (tui_update_breakpoint_info, tui_set_exec_info_content)
3075         (tui_alloc_source_buffer, tui_line_is_displayed)
3076         (tui_addr_is_displayed): Update.
3077         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3078         (tui_check_and_display_highlight_if_needed)
3079         (tui_win_info::make_visible, tui_win_info::refresh)
3080         (tui_refresh_all): Update.
3081         * tui/tui-windata.c (tui_first_data_item_displayed)
3082         (tui_delete_data_content_windows, tui_erase_data_content)
3083         (tui_display_all_data, tui_data_window::refresh_all)
3084         (tui_check_data_values): Update.
3085         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3086         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3087         (tui_win_info::backward_scroll, tui_refresh_all_win)
3088         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3089         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3090         (tui_source_window_base::set_new_height)
3091         (tui_data_window::set_new_height)
3092         (make_invisible_and_set_new_height)
3093         (make_visible_with_new_height, new_height_ok)
3094         (parse_scrolling_args): Update.
3095         * tui/tui-stack.c (tui_show_frame_info): Update.
3096         * tui/tui-source.c (tui_set_source_content)
3097         (tui_set_source_content_nil, tui_source_is_displayed)
3098         (tui_source_window::do_scroll_vertical): Update.
3099         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3100         (tui_display_registers_from, tui_display_reg_element_at_line)
3101         (tui_check_register_values, tui_reg_command): Update.
3102         * tui/tui-layout.c (tui_default_win_height)
3103         (show_source_disasm_command, show_data, init_and_make_win)
3104         (show_source_or_disasm_and_command): Update.
3105         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3106         (tui_redisplay_readline, tui_mld_flush)
3107         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3108         (tui_getc): Update.
3109         * tui/tui-disasm.c (tui_set_disassem_content)
3110         (tui_disasm_window::do_scroll_vertical): Update.
3111         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3112         Now virtual.
3113         (struct tui_win_info): Derive from tui_gen_win_info.
3114         <~tui_win_info>: Mark as override.
3115         <generic>: Remove member.
3116         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3117         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3118         (~tui_data_window, ~tui_win_info)
3119         (tui_free_all_source_wins_content): Update.
3120         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3121
3122 2019-06-25  Tom Tromey  <tom@tromey.com>
3123
3124         * tui/tui-layout.c (init_and_make_win): Use new.
3125         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3126         destructor, initializers.
3127         (tui_alloc_generic_win_info): Don't declare.
3128         * tui/tui-data.c (_locator): Add argument to constructor.
3129         (source_win, disasm_win): New globals.
3130         (exec_info): Remove.
3131         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3132         Update.
3133         (tui_alloc_generic_win_info): Remove.
3134         (init_content_element): Use new.
3135         (tui_win_info::tui_win_info): Update.
3136         (free_content_elements) <case DATA_WIN>: Use delete.
3137
3138 2019-06-25  Tom Tromey  <tom@tromey.com>
3139
3140         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3141         * tui/tui-windata.c (tui_first_data_item_displayed)
3142         (tui_delete_data_content_windows): Update.
3143         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3144         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3145         (tui_display_registers_from, tui_check_register_values): Update.
3146         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3147         pointer.
3148         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3149         window.
3150         (tui_free_data_content): Update.
3151         (free_content_elements) <case DATA_WIN>: Free the window.
3152
3153 2019-06-25  Tom Tromey  <tom@tromey.com>
3154
3155         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3156         Update.
3157         * tui/tui-layout.c (make_command_window)
3158         (show_source_disasm_command, show_data, init_and_make_win)
3159         (show_source_or_disasm_and_command): Update.
3160         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3161         method.
3162         <can_highight, is_highlighted>: Now bool.
3163         (tui_set_win_highlight): Don't declare.
3164         * tui/tui-data.c (tui_set_win_highlight): Remove.
3165
3166 2019-06-25  Tom Tromey  <tom@tromey.com>
3167
3168         * tui/tui-wingeneral.c (make_visible): Remove check of window
3169         type.
3170
3171 2019-06-25  Tom Tromey  <tom@tromey.com>
3172
3173         * tui/tui-win.c (tui_win_info::max_height)
3174         (tui_cmd_window::max_height): New methods.
3175         (new_height_ok): Call max_height.
3176         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3177         <max_height>: New method.
3178
3179 2019-06-25  Tom Tromey  <tom@tromey.com>
3180
3181         * tui/tui-win.c (tui_source_window_base::set_new_height)
3182         (tui_data_window::set_new_height): New methods.
3183         (make_invisible_and_set_new_height): Call set_new_height method.
3184         * tui/tui-data.h (struct tui_win_info)
3185         (struct tui_source_window_base, struct tui_data_window)
3186         <set_new_height>: New method.
3187
3188 2019-06-25  Tom Tromey  <tom@tromey.com>
3189
3190         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3191         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3192         tui_refresh_data_win.
3193         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3194         method.
3195         (tui_refresh_all_win): Call the refresh_all method.
3196         (tui_set_focus): Likewise.
3197         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3198         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3199         Likewise.
3200
3201 2019-06-25  Tom Tromey  <tom@tromey.com>
3202
3203         * tui/tui-winsource.h (tui_refill_source_window)
3204         (tui_set_is_exec_point_at): Don't declare.
3205         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3206         (tui_source_window_base::refill): Rename from
3207         tui_refill_source_window.
3208         (tui_source_window_base::do_scroll_horizontal): Update.
3209         (tui_source_window_base::set_is_exec_point_at): Rename from
3210         tui_set_is_exec_point_at.
3211         (tui_update_all_breakpoint_info): Update.
3212         * tui/tui-stack.c (tui_show_frame_info): Update.
3213         * tui/tui-layout.c (show_data): Add cast.
3214         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3215         * tui/tui-data.h (struct tui_source_window_base) <refill,
3216         set_is_exec_point_at>: New methods.
3217         (tui_source_windows, tui_add_to_source_windows): Update types.
3218         (tui_add_to_source_windows): Remove redundant declaration.
3219         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3220         (tui_source_windows): Change return type.
3221         (tui_clear_source_windows_detail): Update.
3222         (tui_add_to_source_windows): Change type of parameter.
3223         (tui_free_all_source_wins_content): Update.
3224
3225 2019-06-25  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-wingeneral.c (tui_win_info::refresh)
3228         (tui_source_window_base::refresh): New methods.
3229         (tui_refresh_all): Call the refresh method.
3230         * tui/tui-data.h (struct tui_win_info)
3231         (struct tui_source_window_base) <refresh>: New method.
3232
3233 2019-06-25  Tom Tromey  <tom@tromey.com>
3234
3235         * tui/tui.h (tui_is_window_visible): Return bool.
3236         * tui/tui.c (tui_is_window_visible): Return bool.
3237         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3238         (tui_make_visible, tui_make_invisible)
3239         (tui_win_info::make_visible)
3240         (tui_source_window_base::make_visible, make_all_visible)
3241         (tui_make_all_visible, tui_make_all_invisible): Update.
3242         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3243         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3244         bool.
3245         (struct tui_win_info, struct tui_source_window_base)
3246         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3247         * tui/tui-data.c (tui_init_generic_part): Update.
3248
3249 2019-06-25  Tom Tromey  <tom@tromey.com>
3250
3251         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3252         (tui_source_window_base::make_visible): New methods.
3253         (make_all_visible): Make method call.
3254         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3255         (struct tui_source_window_base, struct tui_cmd_window): Override
3256         make_visible.
3257         (tui_win_is_source_type): Don't declare.
3258         * tui/tui-data.c (tui_win_is_source_type): Remove.
3259
3260 2019-06-25  Tom Tromey  <tom@tromey.com>
3261
3262         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3263         NULL check.
3264
3265 2019-06-25  Tom Tromey  <tom@tromey.com>
3266
3267         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3268         Inline constructor.  Add initializers for members.
3269         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3270         constructors; now inline in class.
3271
3272 2019-06-25  Tom Tromey  <tom@tromey.com>
3273
3274         * tui/tui-regs.c (tui_show_registers): Update.
3275         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3276         bool.
3277         * tui/tui-data.c (tui_data_window::clear_detail)
3278         (tui_data_window): Update.
3279
3280 2019-06-25  Tom Tromey  <tom@tromey.com>
3281
3282         * tui/tui-windata.c (tui_display_all_data)
3283         (tui_display_data_from_line, tui_display_data_from)
3284         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3285         Update.
3286         * tui/tui-regs.c (tui_last_regs_line_no)
3287         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3288         (tui_show_registers, tui_show_register_group)
3289         (tui_display_registers_from, tui_display_reg_element_at_line)
3290         (tui_display_registers_from_line, tui_check_register_values)
3291         (tui_reg_next, tui_reg_prev): Update.
3292         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3293         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3294         tui_data_window.
3295         (struct tui_win_info) <detail>: Remove.  Add new fields from
3296         tui_data_info.
3297         (TUI_DATA_WIN): Add cast.
3298         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3299         (~tui_data_window): Simplify.
3300
3301 2019-06-25  Tom Tromey  <tom@tromey.com>
3302
3303         * tui/tui-layout.c (show_source_disasm_command)
3304         (show_source_or_disasm_and_command): Update.
3305         * tui/tui-io.c (update_cmdwin_start_line)
3306         (tui_redisplay_readline): Update.
3307         * tui/tui-data.h (struct tui_command_info): Remove.
3308         (struct tui_win_info) <detail>: Remove command_info member.
3309         (struct tui_data_window) <start_line>: New member, from
3310         tui_command_info.
3311         (TUI_CMD_WIN): Add casts.
3312
3313 2019-06-25  Tom Tromey  <tom@tromey.com>
3314
3315         * tui/tui-winsource.c (tui_update_source_window)
3316         (tui_refill_source_window)
3317         (tui_source_window_base::do_scroll_horizontal)
3318         (tui_update_breakpoint_info, tui_set_exec_info_content)
3319         (tui_show_exec_info_content, tui_erase_exec_info_content)
3320         (tui_clear_exec_info_content): Update.
3321         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3322         Update.
3323         * tui/tui-win.c (make_invisible_and_set_new_height)
3324         (make_visible_with_new_height): Update.
3325         * tui/tui-source.c (tui_set_source_content)
3326         (tui_show_symtab_source): Update.
3327         * tui/tui-layout.c (extract_display_start_addr)
3328         (show_source_disasm_command, show_data)
3329         (make_source_or_disasm_window)
3330         (show_source_or_disasm_and_command): Update.
3331         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3332         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3333         "gdbarch".
3334         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3335         to tui_source_window_base.
3336         (struct tui_win_info) <detail>: Remove source_info member.
3337         (struct tui_source_window_base) <has_locator>: Inline.
3338         Move contents from tui_source_info; rename has_locator member to
3339         m_has_locator.
3340         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3341         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3342         header file.
3343         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3344         Simplify.
3345         (tui_free_all_source_wins_content): Cast to
3346         tui_source_window_base.
3347
3348 2019-06-25  Tom Tromey  <tom@tromey.com>
3349
3350         * tui/tui-win.c (make_invisible_and_set_new_height)
3351         (make_visible_with_new_height): Call has_locator method.
3352         * tui/tui-layout.c (show_source_disasm_command, show_data)
3353         (show_source_or_disasm_and_command): Update for bool change.
3354         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3355         (tui_win_info) <has_locator>: New method.
3356         (struct tui_source_window_base) <has_locator>: New method.
3357         (tui_win_has_locator): Don't declare.
3358         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3359         from tui_win_has_locator.
3360         (tui_source_window_base): Use false, not FALSE.
3361
3362 2019-06-25  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3365         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3366         clear_detail method directly.
3367         (tui_clear_win_detail): Remove.
3368
3369 2019-06-25  Tom Tromey  <tom@tromey.com>
3370
3371         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3372         "this", not TUI_DISASM_WIN.
3373
3374 2019-06-25  Tom Tromey  <tom@tromey.com>
3375
3376         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3377         declare.
3378         * tui/tui-winsource.c
3379         (tui_source_window_base::do_scroll_horizontal): Rename from
3380         tui_horizontal_source_scroll.
3381         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3382         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3383         from tui_vertical_data_scroll.
3384         * tui/tui-win.h (tui_scroll): Don't declare.
3385         * tui/tui-win.c (tui_win_info::forward_scroll)
3386         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3387         (tui_win_info::right_scroll): Rename and update.
3388         (tui_scroll_forward_command, tui_scroll_backward_command)
3389         (tui_scroll_left_command, tui_scroll_right_command): Update.
3390         (tui_scroll): Remove.
3391         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3392         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3393         from tui_vertical_source_scroll.
3394         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3395         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3396         from tui_vertical_disassem_scroll.
3397         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3398         do_scroll_horizontal>: New methods.
3399         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3400         Likewise.
3401         (struct tui_source_window_base): Add do_scroll_horizontal.
3402         (struct tui_source_window, struct tui_disasm_window): Add
3403         do_scroll_vertical.
3404         (struct tui_data_window, struct tui_cmd_window): Add
3405         do_scroll_horizontal and do_scroll_vertical.
3406         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3407
3408 2019-06-25  Tom Tromey  <tom@tromey.com>
3409
3410         * tui/tui-data.h (struct tui_source_window_base): New struct.
3411         (struct tui_source_window): Derive from tui_source_window_base.
3412         (struct tui_disasm_window): New struct.
3413         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3414         from tui_source_window::clear_detail.
3415         (tui_source_window_base): Rename from tui_source_window.
3416         (~tui_source_window_base): Rename from ~tui_source_window.
3417         (tui_alloc_win_info): Create a tui_disasm_window.
3418
3419 2019-06-25  Tom Tromey  <tom@tromey.com>
3420
3421         * tui/tui-data.h (struct tui_source_window)
3422         (struct tui_data_window): Declare destructors.
3423         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3424         destructors.
3425         (tui_win_info): Simplify.
3426
3427 2019-06-25  Tom Tromey  <tom@tromey.com>
3428
3429         * tui/tui-winsource.c (tui_display_main)
3430         (tui_update_source_windows_with_addr)
3431         (tui_update_all_breakpoint_info): Update.
3432         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3433         (new_height_ok, parse_scrolling_args): Update.
3434         * tui/tui-stack.c (tui_show_frame_info): Update.
3435         * tui/tui-data.h (struct tui_list): Remove.
3436         (tui_source_windows): Return a reference to a std::vector.
3437         * tui/tui-data.c (source_windows): Now a std::vector.
3438         (tui_source_windows): Change return type.
3439         (tui_clear_source_windows): Rewrite.
3440         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3441         (tui_free_all_source_wins_content): Rewrite.
3442
3443 2019-06-25  Tom Tromey  <tom@tromey.com>
3444
3445         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3446         (struct tui_data_window, struct tui_cmd_window): Declare
3447         clear_detail method.
3448         * tui/tui-data.c (tui_source_window::clear_detail)
3449         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3450         methods.
3451         (tui_clear_win_detail): Simplify.
3452
3453 2019-06-25  Tom Tromey  <tom@tromey.com>
3454
3455         * tui/tui-layout.c (make_source_window, make_disasm_window)
3456         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3457         Return the new window.
3458         (show_source_disasm_command, show_data)
3459         (show_source_or_disasm_and_command): Update.
3460
3461 2019-06-25  Tom Tromey  <tom@tromey.com>
3462
3463         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3464         parameter.  Return the new window.
3465         (show_source_disasm_command): Update and remove NULL check.
3466         (show_source_or_disasm_and_command): Update.
3467
3468 2019-06-25  Tom Tromey  <tom@tromey.com>
3469
3470         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3471
3472 2019-06-25  Tom Tromey  <tom@tromey.com>
3473
3474         * tui/tui-data.h (struct tui_win_info): Make constructor
3475         protected.  Make destructor virtual.  Add initializers.
3476         (tui_source_window, tui_data_window, tui_cmd_window): New
3477         classes.
3478         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3479         constructor.  Add "type" parameter.
3480         (tui_source_window, tui_data_window, tui_cmd_window): New
3481         constructors.
3482         (tui_alloc_win_info): Instantiate the appropriate subclass.
3483
3484 2019-06-25  Tom Tromey  <tom@tromey.com>
3485
3486         * tui/tui-win.c (tui_resize_all): Use delete.
3487         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3488         destructor.
3489         (tui_free_window): Don't declare.
3490         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3491         Update.
3492
3493 2019-06-25  Tom Tromey  <tom@tromey.com>
3494
3495         * tui/tui-data.h (struct tui_win_info): Add constructor.
3496         * tui/tui-data.c (tui_alloc_win_info): Use new.
3497         (tui_free_window): Use delete.
3498
3499 2019-06-22  Tom Tromey  <tom@tromey.com>
3500
3501         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3502         declare.
3503         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3504
3505 2019-06-22  Tom Tromey  <tom@tromey.com>
3506
3507         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3508         declare.
3509         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3510
3511 2019-06-22  Tom de Vries  <tdevries@suse.de>
3512
3513         * dwarf2read.c (create_addrmap_from_aranges)
3514         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3515         instead of '%zu'.
3516
3517 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3518
3519         * dwarf2read.h (dwarf2_section_info_def): Remove.
3520         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3521         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3522         std::vector<dwarf2_section_info>.
3523         (struct dwo_file) <~dwo_file>: Remove.
3524         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3525         types field.
3526         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3527         (dwarf2_read_debug_names): Likewise.
3528         (create_debug_types_hash_table): Change parameter type to
3529         array_view, adjust code accordingly.
3530         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3531         (partial_die_info::fixup): Likewise.
3532         (determine_prefix): Likewise.
3533         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3534
3535 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3536
3537         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3538         gdb_bfd_ref_ptr.
3539         <~dwo_file>: Remove call to gdb_bfd_unref.
3540         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3541         gdb_bfd_ref_ptr::get.
3542
3543 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3544
3545         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3546         type to htab_up.
3547         * dwarf2read.c (struct dwo_file): Initialize fields.
3548         <~dwo_file>: New.
3549         (free_dwo_file): Remove, move content to ~dwo_file.
3550         (struct dwo_file_deleter): Remove.
3551         (dwo_file_up>: Remove custom deleter.
3552         (free_dwo_files): Remove.
3553         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3554         dwo_files.
3555         (process_skeletonless_type_units): Call unique_ptr::get.
3556         (allocate_dwo_file_hash_table): Add deleter to created hash
3557         table.  Change return type to htab_up.
3558         (lookup_dwo_file_slot): Don't memset dwo_file, call
3559         unique_ptr::get.
3560         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3561         (create_dwo_unit_in_dwp_v2): Likewise.
3562         (open_and_init_dwo_file): Likewise.
3563         (free_dwo_file_from_slot): Remove.
3564
3565 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3566
3567         * dwarf2read.h (struct dwarf2_section_info) <readin,
3568         is_virtual>: Change type to bool.
3569         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3570         true instead of 1.
3571
3572 2019-06-19  Tom Tromey  <tom@tromey.com>
3573
3574         * tui/tui-data.h (tui_init_content_element): Don't declare.
3575
3576 2019-06-19  Tom Tromey  <tom@tromey.com>
3577
3578         * tui/tui-data.h (tui_init_win_info): Don't declare.
3579
3580 2019-06-19  Tom de Vries  <tdevries@suse.de>
3581
3582         * dwarf2read.h (abstract_to_concrete): Change type to
3583         std::unordered_map<sect_offset, std::vector<sect_offset>,
3584         gdb::hash_enum<sect_offset>>.
3585
3586 2019-06-19  Tom Tromey  <tromey@adacore.com>
3587
3588         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3589         EVAL_AVOID_SIDE_EFFECTS specially.
3590
3591 2019-06-19  Tom Tromey  <tromey@adacore.com>
3592
3593         * source-cache.c (highlighter): New global.
3594         (source_cache::get_source_lines): Create a highlighter on demand.
3595
3596 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3597
3598         * defs.h (deprecated_interactive_hook): Delete declaration.
3599         * interps.c (clear_interpreter_hooks): Remove use of
3600         deprecated_interactive_hook.
3601         * top.c (deprecated_interactive_hook): Delete definition.
3602         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3603
3604 2019-06-18  Tom de Vries  <tdevries@suse.de>
3605
3606         PR gdb/24515
3607         * dwarf2read.h (abstract_to_concrete): Change type from
3608         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3609         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3610         * dwarf2read.c (read_variable): Update.
3611         (dwarf2_fetch_die_loc_sect_off): Update.
3612
3613 2019-06-17  Tom de Vries  <tdevries@suse.de>
3614
3615         PR gdb/24617
3616         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3617         accessing parent[parent_len - 1].
3618
3619 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3620
3621         PR gdb/24364
3622         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3623         call dtrace_process_dof with NULL dof.
3624
3625 2019-06-16  Tom de Vries  <tdevries@suse.de>
3626
3627         PR gdb/24445
3628         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3629
3630 2019-06-16  Tom Tromey  <tom@tromey.com>
3631
3632         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3633         (make_all_visible): Use address of member.
3634
3635 2019-06-16  Tom Tromey  <tom@tromey.com>
3636
3637         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3638         (tui_free_window, free_content, free_content_elements): Remove
3639         unnecessary cast.
3640         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3641         cast.
3642         * tui/tui-regs.c (tui_show_register_group)
3643         (tui_display_registers_from, tui_display_reg_element_at_line):
3644         Remove unnecessary cast.
3645
3646 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3647
3648         * linux-nat.c (normal_mask): Delete.
3649         (_initialize_linux_nat): Don't initialise normal_mask.
3650
3651 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3652
3653         PR gdb/24445
3654         * dwarf-index-write.h (write_psymtabs_to_index): Add
3655         dwz_basename parameter.
3656         * dwarf-index-write.c (write_gdbindex): Move file writing to
3657         write_gdbindex_1.  Change return type void.
3658         (assert_file_size): Move up, remove filename parameter.
3659         (write_gdbindex_1): New function.
3660         (write_debug_names): Change return type to void, call
3661         assert_file_size.
3662         (struct index_wip_file): New struct.
3663         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3664         file logic to index_wip_file.  Write index for dwz file if
3665         needed.
3666         (save_gdb_index_command): Pass basename of dwz file, if present.
3667         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3668         build-id of dwz file, if present.
3669         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3670         (dwarf2_get_dwz_file): Likewise.
3671         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3672         (dwarf2_get_dwz_file): Likewise.
3673
3674 2019-06-16  Tom Tromey  <tom@tromey.com>
3675
3676         * coffread.c (process_coff_symbol): Use xstrdup.
3677         * value.c (create_internalvar): Use xstrdup.
3678
3679 2019-06-16  Tom Tromey  <tom@tromey.com>
3680
3681         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3682         * breakpoint.c (stopin_command, stopat_command)
3683         (until_break_command, decode_location_default): Remove unnecessary
3684         cast.
3685         * utils.c (subset_compare): Remove unnecessary cast.
3686         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3687         cast.
3688         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3689         cast.
3690         * infcmd.c (path_command): Remove unnecessary cast.
3691         * coffread.c (decode_type): Remove unnecessary cast.
3692         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3693         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3694         * tui/tui-stack.c (tui_show_locator_content)
3695         (tui_show_frame_info): Remove unnecessary cast.
3696         * tui/tui-win.c (tui_scroll_forward_command)
3697         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3698         (parse_scrolling_args): Remove unnecessary cast.
3699         * tui/tui-data.c (init_win_info, tui_del_window)
3700         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3701         (free_content_elements): Remove unnecessary cast.
3702         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3703         unnecessary cast.
3704         * tui/tui-source.c (tui_set_source_content)
3705         (tui_vertical_source_scroll): Remove unnecessary cast.
3706         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3707         cast.
3708         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3709         * tui/tui-regs.c (tui_display_registers_from)
3710         (tui_display_register): Remove unnecessary cast.
3711         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3712         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3713         (make_visible): Remove unnecessary cast.
3714         * tui/tui-winsource.c (tui_erase_source_content)
3715         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3716         unnecessary cast.
3717         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3718         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3719         * stabsread.c (read_type, read_array_type, read_range_type):
3720         Remove unnecessary cast.
3721         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3722         (parse_symbol, parse_type, upgrade_type, parse_external)
3723         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3724         unnecessary cast.
3725         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3726
3727 2019-06-16  Tom Tromey  <tom@tromey.com>
3728
3729         * tui/tui-data.c (tui_alloc_generic_win_info)
3730         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3731         checks.
3732
3733 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3734             Andrew Burgess  <andrew.burgess@embecosm.com>
3735
3736         * f-typeprint.c (f_print_type): Don't return early for not
3737         associated or not allocated types.
3738         (f_type_print_varspec_suffix): Add print_rank parameter and print
3739         ranks of array types in case they dangling.
3740         (f_type_print_base): Add print_rank parameter.
3741
3742 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3743
3744         * NEWS: Mention new MI commands.
3745         * break-catch-throw.c (enum exception_event_kind): Move to
3746         breakpoint.h.
3747         (print_mention_exception_catchpoint): Output text as a single
3748         message.
3749         (catch_exception_command_1): Rename to...
3750         (catch_exception_event): ...this, make non-static, update header
3751         command, and change some parameter types.
3752         (catch_catch_command): Update for changes to
3753         catch_exception_command_1.
3754         (catch_throw_command): Likewise.
3755         (catch_rethrow_command): Likewise.
3756         * breakpoint.c (enum exception_event_kind): Delete.
3757         * breakpoint.h (enum exception_event_kind): Moved here from
3758         break-catch-throw.c.
3759         (catch_exception_event): Declare.
3760         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3761         (mi_cmd_catch_throw): New function.
3762         (mi_cmd_catch_rethrow): New function.
3763         (mi_cmd_catch_catch): New function.
3764         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3765         'catch-catch' entries.
3766         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3767         (mi_cmd_catch_rethrow): Declare.
3768         (mi_cmd_catch_catch): Declare.
3769
3770 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3771
3772         * annotate.c (annotate_source_line): Change return type to void,
3773         update implementation to match.
3774         * annotate.h (annotate_source_line): Change return type to void,
3775         update header comment.
3776         * stack.c (print_frame_info): Don't change what frame information
3777         is printed based on whether annotations are on or not.
3778
3779 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3780
3781         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3782         (annotate_source): Make static.
3783         (annotate_source_line): Moved from source.c and renamed from
3784         identify_source_line.  Update the return type.
3785         * annotate.h (annotate_source): Delete declaration.
3786         (annotate_source_line): Declaration moved from source.h, and
3787         renamed from identify_source_line.  Return type updated.
3788         * source.c (identify_source_line): Moved to annotate.c and renamed
3789         to annotate_source_line.
3790         (info_line_command): Remove check of annotation_level.
3791         * source.h (identify_source_line): Move declaration to annotate.h
3792         and rename to annotate_source_line.
3793         * stack.c: Add 'annotate.h' include.
3794         (print_frame_info): Remove check of annotation_level before
3795         calling annotate_source_line.
3796
3797 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3798
3799         * source-cache.c (source_cache::get_plain_source_lines): Use
3800         open_source_file_with_line_charpos instead of just
3801         open_source_file, remove call to find_source_lines.
3802         (source_cache::get_source_lines): Likewise.
3803         * source.c (find_source_lines): Make static.
3804         (get_filename_and_charpos): Renamed into...
3805         (open_source_file_with_line_charpos): ..this along with changes to
3806         return a scoped_fd, and some other minor clean ups.
3807         (identify_source_line): Use open_source_file_with_line_charpos.
3808         (search_command_helper): Use open_source_file_with_line_charpos
3809         instead of just open_source_file, remove call to
3810         find_source_lines.
3811         * source.h (open_source_file_with_line_charpos): Declare new
3812         function.
3813         (find_source_lines): Delete declaration.
3814
3815 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3816
3817         * source.c (get_filename_and_charpos): Remove fullname
3818         parameter.
3819         (identify_source_line): Update call to get_filename_and_charpos.
3820
3821 2019-06-14  Tom Tromey  <tromey@adacore.com>
3822
3823         PR gdb/24502:
3824         * ui-style.h (skip_ansi_escape): Update comment.
3825         * ui-file.h (class no_terminal_escape_file): New class.
3826         * ui-file.c (no_terminal_escape_file::write)
3827         (no_terminal_escape_file::puts): New methods.
3828         * cli/cli-logging.c (handle_redirections): Use
3829         no_terminal_escape_file.
3830
3831 2019-06-14  Tom Tromey  <tromey@adacore.com>
3832
3833         * NEWS: Move convenience variable news above Python news.
3834
3835 2019-06-14  Tom Tromey  <tom@tromey.com>
3836
3837         * gnulib: Move directory to top-level.
3838         * configure.ac: Don't configure gnulib.
3839         * configure: Rebuild.
3840         * common/common-defs.h: Use new path to gnulib.
3841         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3842         (GNULIB_H): Remove.
3843         (INCGNU): Look in new gnulib location.
3844         (HFILES_NO_SRCDIR): Remove gnulib files.
3845         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3846         (generated_files): Remove GNULIB_H.
3847         ($(LIBGNU), all-lib): Remove targets.
3848         (distclean): Don't mention GNULIB_BUILDDIR.
3849         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3850
3851 2019-06-14  Tom Tromey  <tromey@adacore.com>
3852
3853         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3854         Warn if symbol file does not provide any symbols.
3855
3856 2019-06-14  Tom Tromey  <tromey@adacore.com>
3857
3858         * source.c (find_and_open_source): Respect basenames_may_differ.
3859
3860 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3861
3862         * annotate.c (annotate_breakpoints_invalid): Make use of
3863         scoped_restore_terminal_state.
3864         (annotate_frames_invalid): Likewise.
3865
3866 2019-06-14  Tom Tromey  <tromey@adacore.com>
3867
3868         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3869         allow assignment to an internalvar.
3870
3871 2019-06-14  Tom Tromey  <tromey@adacore.com>
3872
3873         * ada-lex.l: Allow "_" in attribute names.
3874
3875 2019-06-14  Tom Tromey  <tromey@adacore.com>
3876
3877         PR gdb/24653:
3878         * regcache.c (registers_changed): Don't call alloca.
3879         * top.c (execute_command): Don't call alloca.
3880
3881 2019-06-13  Pedro Alves  <palves@redhat.com>
3882
3883         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3884         'expression'.  When parsing an expression, error out if there's
3885         junk after "unlimited".
3886         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3887         (do_set_command): Adjust calls to is_unlimited_literal.
3888
3889 2019-06-13  Pedro Alves  <palves@redhat.com>
3890
3891         * compile/compile.c (make_compile_options_def_group): Add braces
3892         around array_view initializer.
3893         * thread.c (make_thread_apply_all_options_def_group)
3894         (make_thread_apply_all_options_def_group): Likewise.
3895
3896 2019-06-13  Pedro Alves  <palves@redhat.com>
3897
3898         * NEWS (New commands): Mention "maint test-options
3899         require-delimiter", "maint test-options unknown-is-error", "maint
3900         test-options unknown-is-operand" and "maint show
3901         test-options-completion-result".
3902         (New command options, command completion): New section.
3903         (Completion improvements): New section.
3904         Mention that you can abbreviate "unlimited".
3905
3906 2019-06-13  Pedro Alves  <palves@redhat.com>
3907
3908         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3909         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3910         * unittests/cli-utils-selftests.c (test_parse_flags)
3911         (test_parse_flags_qcs): Delete.
3912         (test_cli_utils): Don't call deleted functions.
3913
3914 2019-06-13  Pedro Alves  <palves@redhat.com>
3915
3916         * thread.c: Include "cli/cli-option.h".
3917         (tp_array_compar_ascending): Global.
3918         (tp_array_compar): Delete function.
3919         (tp_array_compar_ascending, tp_array_compar_descending): New
3920         functions.
3921         (ascending_option_def, qcs_flag_option_def)
3922         (thr_qcs_flags_option_defs)
3923         (make_thread_apply_all_options_def_group)
3924         (make_thread_apply_options_def_group): New.
3925         (thread_apply_all_command): Use gdb::option::process_options.
3926         (thread_apply_command_completer)
3927         (thread_apply_all_command_completer): New.
3928         (thread_apply_command): Use gdb::option::process_options.
3929         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3930         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3931         to generate help text of "thread apply".  Adjust "taas"'s help.
3932         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3933         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3934
3935 2019-06-13  Pedro Alves  <palves@redhat.com>
3936
3937         * thread.c (thread_apply_command): Check for invalid TID with
3938         isdigit instead of !isalpha.
3939
3940 2019-06-13  Pedro Alves  <palves@redhat.com>
3941
3942         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3943         (validate_flags_qcs): New.
3944         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3945         (validate_flags_qcs): Declare.
3946         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3947         (make_frame_apply_options_def_group): New.
3948         (frame_apply_command_count): Process options with
3949         gdb::option::process_options.
3950         (frame_apply_completer): New.
3951         (frame_apply_level_completer, frame_apply_all_completer)
3952         (frame_apply_completer): New.
3953         (_initialize_stack): Update help of "frame apply", "frame apply
3954         level", "frame apply all" and "faas" to mention supported options
3955         and install command completers.
3956         * stack.h (frame_apply_all_completer): Declare.
3957         * thread.c: Include "stack.h".
3958         (tfaas_command): Add "--".
3959         (_initialize_thread): Update help "tfaas" to mention supported
3960         options and install command completer.
3961
3962 2019-06-13  Pedro Alves  <palves@redhat.com>
3963
3964         * completer.c (complete_nested_command_line): New.
3965         (gdb_completion_word_break_characters_throw): Add assertion.
3966         * completer.h (complete_nested_command_line): Declare.
3967
3968 2019-06-13  Pedro Alves  <palves@redhat.com>
3969
3970         * stack.c (parse_backtrace_qualifiers): New.
3971         (backtrace_command): Use it.
3972         (backtrace_command_completer): Complete on qualifiers.
3973
3974 2019-06-13  Pedro Alves  <palves@redhat.com>
3975
3976         * frame.c: Include "cli/cli-option.h.
3977         (user_set_backtrace_options): New.
3978         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3979         Delete.
3980         (get_prev_frame): Adjust.
3981         (boolean_option_def, uinteger_option_def)
3982         (set_backtrace_option_defs): New.
3983         (_initialize_frame): Adjust and use
3984         gdb::option::add_setshow_cmds_for_options to install "set
3985         backtrace past-main" and "set backtrace past-entry".
3986         * frame.h: Include "cli/cli-option.h".
3987         (struct frame_print_options): Forward declare.
3988         (print_frame_arguments_all, print_frame_arguments_scalars)
3989         (print_frame_arguments_none): Declare.
3990         (print_entry_values): Delete declaration.
3991         (struct frame_print_options, user_frame_print_options): New.
3992         (struct set_backtrace_options): New.
3993         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3994         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3995         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3996         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3997         (list_args_or_locals): Add frame_print_options parameter.
3998         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3999         * python/py-framefilter.c (enumerate_args): Pass down
4000         USER_FRAME_PRINT_OPTIONS.
4001         * stack.c: Include "cli/cli-option.h".
4002         (print_frame_arguments_all, print_frame_arguments_scalars)
4003         (print_frame_arguments_none): Declare.
4004         (print_raw_frame_arguments, print_entry_values): Delete.
4005         (user_frame_print_options): New.
4006         (boolean_option_def, enum_option_def, frame_print_option_defs):
4007         New.
4008         (struct backtrace_cmd_options): New.
4009         (bt_flag_option_def): New.
4010         (backtrace_command_option_defs): New.
4011         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4012         (print_frame_arg, read_frame_arg, print_frame_args)
4013         (print_frame_info, print_frame): Add frame_print_options parameter
4014         and use it.
4015         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4016         (backtrace_command_1): Add frame_print_options and
4017         backtrace_cmd_options parameters and use them.
4018         (make_backtrace_options_def_group): New.
4019         (backtrace_command): Process command options with
4020         gdb::option::process_options.
4021         (backtrace_command_completer): New.
4022         (_initialize_stack): Extend "backtrace"'s help to mention
4023         supported options.  Install completer for "backtrace".
4024         Install some settings commands with add_setshow_cmds_for_options.
4025
4026 2019-06-13  Pedro Alves  <palves@redhat.com>
4027
4028         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4029         and that "set/show print raw frame-arguments" are now deprecated.
4030
4031         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4032         command.
4033         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4034         * stack.c (_initialize_stack): Install "set/show print
4035         raw-frame-arguments", and deprecate "set/show print raw
4036         frame-arguments".
4037         * valprint.c (_initialize_valprint): Deprecate "set/show print
4038         raw".
4039
4040 2019-06-13  Pedro Alves  <palves@redhat.com>
4041
4042         * compile/compile.c (struct compile_options): New.
4043         (compile_flag_option_def, compile_command_option_defs)
4044         (make_compile_options_def_group): New.
4045         (compile_file_command): Handle options with
4046         gdb::option::process_options.
4047         (compile_file_command_completer): New function.
4048         (compile_code_command): Handle options with
4049         gdb::option::process_options.
4050         (compile_code_command_completer): New function.
4051         (_initialize_compiler): Install completers for "compile code" and
4052         "compile file".  Mention available options in "compile code" and
4053         "compile code"'s help.
4054         * completer.c (advance_to_completion_word): New, factored out from
4055         ...
4056         (advance_to_expression_complete_word_point): ... this.
4057         (advance_to_filename_complete_word_point): New.
4058         * completer.h (advance_to_filename_complete_word_point): New
4059         declaration.
4060
4061 2019-06-13  Pedro Alves  <palves@redhat.com>
4062
4063         * compile/compile.c: Include "cli/cli-option.h".
4064         (compile_print_value): Scope data pointer is now a
4065         value_print_options pointer; adjust.
4066         (compile_print_command): Process options.  Scope data pointer is
4067         now a value_print_options pointer; adjust.
4068         (_initialize_compile): Update "compile print"'s help to include
4069         supported options.  Install a completer for "compile print".
4070         * cp-valprint.c (show_vtblprint, show_objectprint)
4071         (show_static_field_print): Delete.
4072         (_initialize_cp_valprint): Don't install "set print
4073         static-members", "set print vtbl", "set print object" here.
4074         * printcmd.c: Include "cli/cli-option.h" and
4075         "common/gdb_optional.h".
4076         (print_command_parse_format): Rework to fill in a
4077         value_print_options instead of a format_data.
4078         (print_value): Change parameter type from format_data pointer to
4079         value_print_options reference.  Adjust.
4080         (print_command_1): Process options.  Adjust to pass down a
4081         value_print_options.
4082         (print_command_completer): New.
4083         (_initialize_printcmd): Install print_command_completer as
4084         handle_brkchars completer for the "print" command.  Update
4085         "print"'s help to include supported options.
4086         * valprint.c: Include "cli/cli-option.h".
4087         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4088         here from cp-valprint.c.
4089         (boolean_option_def, uinteger_option_def)
4090         (value_print_option_defs, make_value_print_options_def_group):
4091         New.  Use gdb::option::add_setshow_cmds_for_options to install
4092         "set print elements", "set print null-stop", "set print repeats",
4093         "set print pretty", "set print union", "set print array", "set
4094         print address", "set print symbol", "set print array-indexes".
4095         * valprint.h: Include <string> and "cli/cli-option.h".
4096         (make_value_print_options_def_group): Declare.
4097         (print_value): Change parameter type from format_data pointer to
4098         value_print_options reference.
4099         (print_command_completer): Declare.
4100
4101 2019-06-13  Pedro Alves  <palves@redhat.com>
4102
4103         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4104         (COMMON_SFILES): Add maint-test-settings.c.
4105         * cli/cli-decode.c (boolean_enums): New global, factored out from
4106         ...
4107         (add_setshow_boolean_cmd): ... here.
4108         * cli/cli-decode.h (boolean_enums): Declare.
4109         * cli/cli-option.c: New file.
4110         * cli/cli-option.h: New file.
4111         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4112         factored out from ...
4113         (parse_cli_boolean_value(const char *)): ... this.
4114         (is_unlimited_literal): Change parameter type to pointer to
4115         pointer.  Adjust and advance ARG pointer.
4116         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4117         (parse_cli_var_enum): New, factored out from ...
4118         (do_set_command): ... this.  Adjust.
4119         * cli/cli-setshow.h (parse_cli_boolean_value)
4120         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4121         (parse_cli_var_enum): Declare.
4122         * cli/cli-utils.c: Include "cli/cli-option.h".
4123         (get_ulongest): New.
4124         * cli/cli-utils.h (get_ulongest): Declare.
4125         (check_for_argument): New overloads.
4126         * maint-test-options.c: New file.
4127
4128 2019-06-13  Pedro Alves  <palves@redhat.com>
4129
4130         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4131         parse a range if "-" is at the end of the string.
4132
4133 2019-06-13  Pedro Alves  <palves@redhat.com>
4134
4135         * cli/cli-setshow.c (parse_auto_binary_operation)
4136         (parse_cli_boolean_value): Don't allow "o".
4137
4138 2019-06-13  Pedro Alves  <palves@redhat.com>
4139
4140         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4141         * NEWS: Mention maint test-settings KIND.
4142         * maint-test-settings.c: New file.
4143
4144 2019-06-13  Pedro Alves  <palves@redhat.com>
4145
4146         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4147         completer.
4148         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4149         "set" completers.
4150
4151 2019-06-13  Pedro Alves  <palves@redhat.com>
4152
4153         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4154         after item.
4155
4156 2019-06-13  Pedro Alves  <palves@redhat.com>
4157
4158         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4159
4160 2019-06-13  Pedro Alves <palves@redhat.com>
4161
4162         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4163         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4164         call.
4165         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4166         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4167         calls.
4168         (check_for_argument): Skip spaces after argument.
4169
4170 2019-06-13  Pedro Alves  <palves@redhat.com>
4171
4172         * thread.c (thread_apply_command): Adjust TID parsing.
4173         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4174         detected before end of string.
4175         (tid_is_in_list): Error out if LIST is invalid.
4176
4177 2019-06-13  Pedro Alves  <palves@redhat.com>
4178
4179         * completer.c (complete_line_internal_1): Rewind completion word
4180         point.
4181         (completion_tracker::advance_custom_word_point_by): Change
4182         parameter type to int.
4183         * completer.h (completion_tracker::advance_custom_word_point_by):
4184         Likewise.
4185
4186 2019-06-13  Pedro Alves  <palves@redhat.com>
4187
4188         * completer.c (advance_to_completion_word): Handle delimiters.
4189
4190 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4191
4192         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4193
4194 2019-06-11  Tom Tromey  <tom@tromey.com>
4195
4196         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4197         (xmalloc_failed): Move to alloc.c.
4198         * alloc.c: New file.
4199         * Makefile.in (COMMON_SFILES): Add alloc.c.
4200
4201 2019-06-11  Tom Tromey  <tom@tromey.com>
4202
4203         * nat/linux-waitpid.c: Don't include server.h.
4204         (linux_debug): Remove.
4205         (my_waitpid): Update.
4206
4207 2019-06-11  Tom Tromey  <tromey@adacore.com>
4208
4209         * infcall.c (_initialize_infcall): Remove trailing newline from
4210         help.
4211         * user-regs.c (_initialize_user_regs): Remove trailing newline
4212         from help.
4213         * typeprint.c (_initialize_typeprint): Remove trailing newline
4214         from help.
4215         * reverse.c (_initialize_reverse): Remove trailing newlines from
4216         help.
4217         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4218         from help.
4219         * language.c (add_set_language_command): Remove trailing newline
4220         from help.
4221         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4222         help.
4223         * disasm.c (_initialize_disasm): Remove trailing newline from
4224         help.
4225         * top.c (init_main): Remove trailing newline from help.
4226         * interps.c (_initialize_interpreter): Remove trailing newline
4227         from help.
4228         * btrace.c (_initialize_btrace): Remove trailing newlines from
4229         help.
4230         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4231         from help.
4232         * python/python.c (_initialize_python): Remove trailing newline
4233         from help.
4234         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4235         help.
4236         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4237         from help.  Reformat some text.
4238         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4239         from help.
4240         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4241         newline from help.
4242
4243 2019-06-11  Tom Tromey  <tromey@adacore.com>
4244
4245         * darwin-nat.c (darwin_decode_exception_message)
4246         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4247
4248 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4249
4250         * valops.c (value_slice): Check for not allocated or not
4251         associated values.
4252
4253 2019-06-10  Tom de Vries  <tdevries@suse.de>
4254
4255         PR gdb/24618
4256         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4257         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4258         invalid.
4259
4260 2019-06-10  Tom de Vries  <tdevries@suse.de>
4261
4262         PR gdb/24611
4263         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4264         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4265
4266 2019-06-10  Tom de Vries  <tdevries@suse.de>
4267
4268         PR symtab/24545
4269         * symtab.c (struct demangled_name_entry): Add language field.
4270         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4271         static minimal symbol".  Set and use language field.
4272
4273 2019-06-10  Tom Tromey  <tromey@adacore.com>
4274
4275         * ada-lang.c (_initialize_ada_language): Update help text.
4276
4277 2019-06-10  Tom Tromey  <tromey@adacore.com>
4278
4279         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4280         with a newline.
4281         * guile/guile.c (handle_boot_error): Don't end warning with a
4282         newline.
4283         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4284         warning with a newline.
4285         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4286         newline.
4287         (s12z_frame_cache): Likewise.
4288         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4289         a newline.
4290         * solib-svr4.c (disable_probes_interface): Don't end warning with
4291         a newline.
4292         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4293         newline.
4294         * python/python.c (do_finish_initialization): Don't end warning
4295         with a newline.
4296
4297 2019-06-10  Tom Tromey  <tom@tromey.com>
4298
4299         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4300         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4301         gdbpy_enter.
4302
4303 2019-06-10  Tom Tromey  <tromey@adacore.com>
4304
4305         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4306         data.
4307         (elf_new_init): Don't call stabsread_new_init.
4308         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4309         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4310         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4311
4312 2019-06-10  Tom de Vries  <tdevries@suse.de>
4313
4314         PR symtab/16264
4315         PR symtab/24517
4316         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4317
4318 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4319
4320         * source.c (find_and_open_source): Also rewrite relative file
4321         names.
4322
4323 2019-04-26  Amos Bird  <amosbird@gmail.com>
4324
4325         * annotate.c (annotate_thread_exited): Add "thread-exited"
4326         annotation.
4327
4328 2019-06-06  Tom Tromey  <tromey@adacore.com>
4329
4330         * maint.h (class scoped_command_stats): Use
4331         DISABLE_COPY_AND_ASSIGN.
4332         <print_time>: New method.
4333         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4334         print_time.
4335         (scoped_command_stats::print_time): New method.
4336
4337 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4338
4339         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4340         instructions of lengths 6 or 8 bytes.
4341
4342 2019-06-04  Pedro Alves  <palves@redhat.com>
4343
4344         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4345
4346         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4347         * breakpoint.c (condition_completer): Likewise.
4348         * cli/cli-dump.c (scan_expression): Likewise.
4349         * common/filestuff.c (mkdir_recursive): Likewise.
4350         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4351         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4352         (gdb_abspath): Likewise.
4353         * compile/compile-cplus-types.c
4354         (compile_cplus_instance::decl_name): Likewise.
4355         * completer.c (complete_explicit_location):
4356         (signal_completer, reg_or_group_completer_1): Likewise.
4357         * cp-support.c (cp_remove_params_if_any): Likewise.
4358         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4359         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4360         * infcmd.c (strip_bg_char): Likewise.
4361         * linespec.c (copy_token_string): Likewise.
4362         * mi/mi-main.c (output_cores): Likewise.
4363         * psymtab.c (psymtab_search_name):
4364         * symfile.c (test_set_ext_lang_command): Likewise.
4365         * target.c (target_fileio_read_stralloc): Likewise.
4366         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4367         * value.c (complete_internalvar): Likewise.
4368
4369 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4370
4371         Add objfile property to gdb.Type.
4372         * NEWS: Mention Python API addition.
4373         * python/py-type.c (typy_get_objfile): New method.
4374
4375 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4376
4377         * NEWS: Mention the new set|show style [title|highlight].
4378         Mention changes to "show style", "help" and "apropos".
4379
4380 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4381
4382         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4383         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4384         instead of print_help_for_command.
4385         (print_doc_of_command): New function.
4386         (help_list): Add 'apropos -v word' suggestion.
4387         (print_help_for_command): Style the command name using title style.
4388         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4389         (_initialize_cli_cmds): Describe -v in apropos_command help.
4390
4391 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4392
4393         * cli/cli-style.h (cli_style_option): Add name in constructor,
4394         add m_name class member, add constructor with intensity,
4395         add name class function.
4396         (cli_style_option::add_setshow_commands): Remove name argument.
4397         (highlight_style, title_style): New styles.
4398         * cli/cli-style.c (do_show): New function that shows a style
4399         characteristic styling the style name with itself.
4400         (set_style_name): New function.
4401         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4402         Update all callers according to the changes in cli/cli-style.h.
4403         * utils.h (fputs_highlighted): New function.
4404         * utils.c (fputs_highlighted): Likewise.
4405
4406 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4407
4408         * NEWS: Mention new pipe command and new convenience variables.
4409
4410 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4411
4412         * cli/cli-cmds.c (pipe_command): New function.
4413         (_initialize_cli_cmds): Call add_com for pipe_command.
4414         Define | as an alias for pipe.
4415         (exit_status_set_internal_vars): New function.
4416         (shell_escape): Call exit_status_set_internal_vars.
4417         cli/cli-decode.c (find_command_name_length): Recognize | as
4418         a single character command.
4419
4420 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4421
4422         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4423         top.c (execute_command_to_ui_file): New function, mostly a copy
4424         of execute_command_to_string.
4425         (execute_command_to_string): Implement by calling
4426         execute_command_to_ui_file.
4427
4428 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4429
4430         * top.h (saved_command_line): Remove declaration.
4431         * top.c (previous_saved_command_line, previous_repeat_arguments):
4432         New variables.
4433         (saved_command_line): Make static, define together with other
4434         'repeat variables'.
4435         (dont_repeat): Clear repeat_arguments.
4436         (repeat_previous, get_saved_command_line, save_command_line):
4437         New functions.
4438         (gdb_init): Initialize saved_command_line
4439         and previous_saved_command_line.
4440         * main.c (captured_main_1): Remove saved_command_line initialization.
4441         * event-top.c (handle_line_of_input): Update to use
4442         the new 'repeat' related functions instead of direct access to
4443         saved_command_line.
4444         * command.h (repeat_previous, get_saved_command_line,
4445         save_command_line): New declarations.
4446         (dont_repeat): Add comment.
4447
4448 2019-05-30  Tom Tromey  <tromey@adacore.com>
4449
4450         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4451         Fix comment.
4452         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4453
4454 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4455
4456         PR cli/24587
4457         * completer.c (complete): Initialize variable word.
4458
4459 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4460
4461         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4462         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4463         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4464         'body' is NULL to the outter 'if', protecting the '!is_define'
4465         situation as well.
4466
4467 2019-05-29  Tom Tromey  <tromey@adacore.com>
4468
4469         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4470         (dwarf_unknown): New function.
4471         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4472         (dwarf_type_encoding_name): Use dwarf_unknown.
4473
4474 2019-05-29  Tom Tromey  <tromey@adacore.com>
4475
4476         PR c++/20020:
4477         * cp-valprint.c (cp_print_value_fields): Call
4478         cp_print_static_field inside "try".
4479
4480 2019-05-29  Tom Tromey  <tromey@adacore.com>
4481
4482         * inflow.c (struct terminal_info): Add default operator=.
4483         * configure: Rebuild.
4484         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4485         -Wdeprecated-copy-dtor, -Wredundant-move.
4486
4487 2019-05-29  Tom Tromey  <tromey@adacore.com>
4488
4489         * NEWS: Add entry.
4490         * infcmd.c (print_return_value_1): Handle finish_print
4491         option.
4492         (show_print_finish): New function.
4493         (_initialize_infcmd): Add "set/show print finish" commands.
4494         * valprint.c (user_print_options): Initialize new member.
4495         * valprint.h (struct value_print_options) <finish_print>: New
4496         member.
4497
4498 2019-05-28  Tom Tromey  <tromey@adacore.com>
4499
4500         * ada-lang.c (ada_remove_Xbn_suffix)
4501         (find_old_style_renaming_symbol)
4502         (parse_old_style_renaming): Remove.
4503         (ada_find_renaming_symbol): Don't call
4504         find_old_style_renaming_symbol.
4505         (ada_is_renaming_symbol): Rename from
4506         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4507         bool.  Now static.
4508         (ada_read_var_value): Update and simplify.
4509         * ada-exp.y (write_var_or_type): Remove old code.
4510
4511 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4512
4513         * event-top.c: Remove include comment.
4514         * inflow.c (class scoped_ignore_sigttou): Move from here...
4515         * inflow.h (class scoped_ignore_sigttou): ...to here.
4516         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4517         * top.c:  Remove include comment.
4518
4519 2019-05-27  Tom Tromey  <tom@tromey.com>
4520
4521         * NEWS: Fix typo.
4522
4523 2019-05-22  Tom Tromey  <tromey@adacore.com>
4524
4525         * target.c (target_follow_exec): Constify parameter.
4526         * target-delegates.c: Rebuild.
4527         * remote.c (remote_target::follow_exec): Constify parameter.
4528         * infrun.c (follow_exec): Constify parameter.
4529         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4530         (target_follow_exec): Likewise.
4531
4532 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4533
4534         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4535         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4536
4537 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4538
4539         * NEWS: Add debugredirect and testsuite sections.
4540
4541 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4542
4543         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4544         target descriptions using exclusively floating point register name
4545         aliases.
4546
4547 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4548
4549         PR gdb/18644:
4550         * f-lang.c (build_fortran_types): Handle the case where
4551         gdbarch_floatformat_for_type returns a nullptr.
4552
4553 2019-05-21  Tom de Vries  <tdevries@suse.de>
4554
4555         PR cli/24587
4556         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4557
4558 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4559
4560         PR gdb/18644:
4561         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4562         16-byte floats.
4563         * i386-tdep.c (i386_floatformat_for_type): Use
4564         floatformats_ia64_quad for the 16-byte floating point component
4565         within a fortran 32-byte complex number.
4566
4567 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4568
4569         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4570         delete default constructor.
4571         (find_partial_die): Update to return const struct.
4572         (partial_die_parent_scope): Move variable declaration into scope
4573         of its use and change its type to auto.
4574         (guess_partial_die_structure_name): Likewise.
4575         (partial_die_info::fixup): Likewise.
4576
4577 2019-05-17  Tom Tromey  <tromey@adacore.com>
4578
4579         * source.c (find_and_open_source): Remove cast.
4580
4581 2019-05-17  Tom Tromey  <tromey@adacore.com>
4582
4583         * annotate.c (annotate_source): Make "filename" const.
4584         * annotate.h (annotate_source): Use const.
4585
4586 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4587
4588         * disasm.c (set_disassembler_options): Send errors to stderr.
4589
4590 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4591
4592         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4593         (cli_interp_base::set_logging): Check debug_redirect.
4594         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4595         * cli/cli-logging.c (debug_redirect): Add static variable.
4596         (pop_output_files): Add default param.
4597         (handle_redirections): Print debug setting.
4598         (show_logging_command): Likewise.
4599         (_initialize_cli_logging): Add debugredirect command.
4600         * interps.c (current_interp_set_logging): Add debug_redirect
4601         parameter.
4602         * interps.h (set_logging): Add debug_redirect parameter.
4603         (current_interp_set_logging): Likewise.
4604         * mi/mi-common.h: Likewise.
4605         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4606
4607 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4608             Tom Tromey  <tromey@adacore.com>
4609
4610         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4611         directly.
4612         * cli/cli-interp.h (make_logging_output): Remove declaration.
4613         * cli/cli-logging.c (make_logging_output): Remove function.
4614         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4615         directly.
4616         * ui-file.c (tee_file::tee_file): Remove bools.
4617         (tee_file::~tee_file): Remove deletes.
4618         * ui-file.h (tee_file): Remove bools.
4619
4620 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4621
4622         * mi/mi-cmds.h (mi_cmd_complete): New function.
4623         * mi/mi-main.c (mi_cmd_complete): Likewise.
4624         * mi/mi-cmds.c: Define new MI command -complete.
4625         * NEWS: Mention new -complete command.
4626
4627 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4628
4629         * completer.h (complete): New function.
4630         * completer.c (complete): Likewise.
4631         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4632         function defined in completer.h.
4633
4634 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4635
4636         * MAINTAINERS (Write After Approval): Add myself.
4637
4638 2019-05-17  Tom de Vries  <tdevries@suse.de>
4639
4640         PR gdb/24094
4641         * dwarf2read.c (struct cu_partial_die_info): New struct.
4642         (find_partial_die): Return cu_partial_die_info.
4643         (partial_die_parent_scope, guess_partial_die_structure_name)
4644         (partial_die_info::fixup): Handle new return type of find_partial_die.
4645
4646 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4647
4648         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4649         "std::string", simplifying the algorithm.
4650
4651 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4652
4653         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4654         (stap_static_probe_ops::get_probes): Likewise.
4655
4656 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4657
4658         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4659         '-')" and "else if".
4660         (stap_parse_single_operand): Join checks for
4661         "gdbarch_stap_parse_special_token_p" and
4662         "gdbarch_stap_parse_special_token" in the same "if" statement.
4663         Invert check when verifying for operation on register
4664         displacement.
4665
4666 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4667
4668         * stap-probe.c (stap_get_opcode): Update comment.
4669         (stap_get_expected_argument_type): Likewise.
4670         (handle_stap_probe): Likewise.
4671
4672 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4673
4674         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4675         return type to 'bool'.  Adjust comment.  Use 'bool' when
4676         appropriate.
4677         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4678         * stap-probe.c (stap_parse_argument_1): Likewise.
4679         (stap_is_operator): Likewise.
4680         (stap_is_generic_prefix): Likewise.
4681         (stap_is_register_prefix): Likewise.
4682         (stap_is_register_indirection_prefix): Likewise.
4683         (stap_is_integer_prefix): Likewise.
4684         (stap_generic_check_suffix): Likewise.
4685         (stap_check_integer_suffix): Likewise.
4686         (stap_check_register_suffix): Likewise.
4687         (stap_check_register_indirection_suffix): Likewise.
4688         (stap_parse_register_operand): Likewise.
4689         (stap_parse_single_operand): Likewise.
4690         (stap_parse_argument_1): Likewise.
4691         (stap_probe::get_argument_count): Likewise.
4692         (stap_is_operator): Likewise.
4693
4694 2019-05-16  Tom Tromey  <tromey@adacore.com>
4695
4696         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4697         keyword to foreach.
4698
4699 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4700
4701         * linux-thread-db.c (try_thread_db_load_1): Change return type
4702         to bool.
4703         (try_thread_db_load): Likewise.
4704         (try_thread_db_load_from_pdir_1): Likewise.
4705         (try_thread_db_load_from_pdir): Likewise.
4706         (try_thread_db_load_from_sdir): Likewise.
4707         (try_thread_db_load_from_dir): Likewise.
4708         (thread_db_load_search): Likewise.
4709         (has_libpthread): Likewise.
4710         (thread_db_load): Likewise.
4711
4712 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4713
4714         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4715         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4716         NULL, and complain/return if that's the case.
4717
4718 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4719
4720         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4721         (advance, posn, abstract_read_memory): New functions.
4722         [struct mem_read_abstraction]: New struct.
4723         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4724
4725 2019-05-14  Tom Tromey  <tromey@adacore.com>
4726
4727         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4728         value is not lval_memory.
4729
4730 2019-05-14  Tom Tromey  <tromey@adacore.com>
4731
4732         * solib.c (info_sharedlibrary_command): Style the file name.
4733
4734 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4735
4736         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4737         (aarch64_vnv_type): Likewise.
4738         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4739         * common/tdesc.c: Likewise.
4740         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4741         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4742         * features/aarch64-fpu.xml: Add ieee half view.
4743         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4744         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4745         * gdbtypes.h (struct builtin_type): Likewise.
4746         (struct objfile_type): Likewise.
4747
4748 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4749
4750         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4751         typo.
4752         * location.h (string_to_event_location): Likewise.
4753
4754 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4755
4756         GDB 8.3 released.
4757
4758 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4759
4760         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4761         New variable declaration.
4762         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4763         New variable.
4764         (print_one_breakpoint): Use ui_out::test_flags and new global
4765         variable to compute use_fixed_output.
4766         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4767         Remove.
4768         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4769         (mi_multi_location_breakpoint_output_fixed): Remove.
4770         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4771         new variable.
4772         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4773         fix_multi_location_breakpoint_output flag if version >= 3.
4774         * ui-out.h (enum ui_out_flag)
4775         <fix_multi_location_breakpoint_output>: New enumerator.
4776
4777 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4778
4779         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4780
4781 2019-05-10  Tom Tromey  <tromey@adacore.com>
4782
4783         * ada-lang.c (catch_ada_completer): New function.
4784         (_initialize_ada_language): Use it.
4785
4786 2019-05-10  Tom Tromey  <tromey@adacore.com>
4787
4788         * thread.c (print_thread_info): Make "requested_threads" const.
4789         * gdbthread.h (print_thread_info): Make "requested_threads"
4790         const.
4791         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4792         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4793
4794 2019-05-08  Tom Tromey  <tom@tromey.com>
4795
4796         * gdbtypes.c (objfile_type_data): Change type.
4797         (objfile_type, _initialize_gdbtypes): Update.
4798
4799 2019-05-08  Tom Tromey  <tom@tromey.com>
4800
4801         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4802         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4803         (_initialize_dwarf2_frame): Update.
4804
4805 2019-05-08  Tom Tromey  <tom@tromey.com>
4806
4807         * objc-lang.c (objc_objfile_data): Change type.
4808         (find_methods): Update.
4809         (_initialize_objc_lang): Remove.
4810
4811 2019-05-08  Tom Tromey  <tom@tromey.com>
4812
4813         * stabsread.c (rs6000_builtin_type_data): Change type.
4814         (rs6000_builtin_type, _initialize_stabsread): Update.
4815
4816 2019-05-08  Tom Tromey  <tom@tromey.com>
4817
4818         * mips-tdep.c (mips_pdr_data): Remove.
4819         (_initialize_mips_tdep): Update.
4820
4821 2019-05-08  Tom Tromey  <tom@tromey.com>
4822
4823         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4824         (hppa_init_objfile_priv_data, read_unwind_info)
4825         (find_unwind_entry, _initialize_hppa_tdep): Update.
4826
4827 2019-05-08  Tom Tromey  <tom@tromey.com>
4828
4829         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4830         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4831         on obstack.
4832         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4833
4834 2019-05-08  Tom Tromey  <tom@tromey.com>
4835
4836         * mdebugread.c (basic_type_data): Change type.
4837         (basic_type, _initialize_mdebugread): Update.
4838
4839 2019-05-08  Tom Tromey  <tom@tromey.com>
4840
4841         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4842
4843 2019-05-08  Tom Tromey  <tom@tromey.com>
4844
4845         * nto-tdep.c (nto_inferior_data_reg): Change type.
4846         (nto_inferior_data): Update.
4847         (nto_inferior_data_cleanup, nto_new_inferior_data)
4848         (_initialize_nto_tdep): Remove.
4849         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4850
4851 2019-05-08  Tom Tromey  <tom@tromey.com>
4852
4853         * ada-lang.c (struct ada_inferior_data): Add initializers.
4854         (ada_inferior_data): Change type.
4855         (ada_inferior_data_cleanup): Remove.
4856         (get_ada_inferior_data, ada_inferior_exit)
4857         (struct ada_pspace_data): Add initializers, destructor.
4858         (ada_pspace_data_handle): Change type.
4859         (get_ada_pspace_data): Update.
4860         (ada_pspace_data_cleanup): Remove.
4861
4862 2019-05-08  Tom Tromey  <tom@tromey.com>
4863
4864         * coffread.c (struct coff_symfile_info): Add initializers.
4865         (coff_objfile_data_key): Move lower.  Change type.
4866         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4867         Update.
4868         (coff_free_info): Remove.
4869
4870 2019-05-08  Tom Tromey  <tom@tromey.com>
4871
4872         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4873         (fbsd_pspace_data_handle): Move lower.  Change type.
4874         (get_fbsd_pspace_data): Update.
4875         (fbsd_pspace_data_cleanup): Remove.
4876         (_initialize_fbsd_tdep): Update.
4877
4878 2019-05-08  Tom Tromey  <tom@tromey.com>
4879
4880         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4881         (get_ada_tasks_pspace_data): Update.
4882         (ada_tasks_pspace_data_cleanup): Remove.
4883         (_initialize_tasks): Update.
4884         (ada_tasks_inferior_data_handle): Change type.
4885         (get_ada_tasks_inferior_data): Update.
4886         (ada_tasks_inferior_data_cleanup): Remove.
4887         (struct ada_tasks_pspace_data): Add initializers.
4888
4889 2019-05-08  Tom Tromey  <tom@tromey.com>
4890
4891         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4892         * symfile-debug.c (debug_sym_get_probes): Change type.
4893         * stap-probe.c (handle_stap_probe):
4894         (stap_static_probe_ops::get_probes): Change type.
4895         * probe.h (class static_probe_ops) <get_probes>: Change type.
4896         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4897         (parse_probes_in_pspace): Update.
4898         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4899         Update.
4900         (any_static_probe_ops::get_probes): Change type.
4901         * elfread.c (elfread_data): New typedef.
4902         (probe_key): Change type.
4903         (elf_get_probes): Likewise.  Update.
4904         (probe_key_free): Remove.
4905         (_initialize_elfread): Update.
4906         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4907         Change type.
4908         (dtrace_process_dof_probe, dtrace_process_dof)
4909         (dtrace_static_probe_ops::get_probe): Change type.
4910
4911 2019-05-08  Tom Tromey  <tom@tromey.com>
4912
4913         * xcoffread.c (struct xcoff_symfile_info): Rename from
4914         coff_symfile_info.  Add initializers.
4915         (xcoff_objfile_data_key): Move lower.  Change type.
4916         (XCOFF_DATA): Rewrite.
4917         (xcoff_free_info): Remove.
4918         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4919         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4920         (xcoff_initial_scan): Update.
4921
4922 2019-05-08  Tom Tromey  <tom@tromey.com>
4923
4924         * solib-svr4.c (struct svr4_info): Add initializers and
4925         destructor.
4926         <probes_table>: Now an htab_up.
4927         (solib_svr4_pspace_data): Change type.
4928         (free_probes_table): Simplify.
4929         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4930         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4931         (probes_table_remove_objfile_probes, register_solib_event_probe)
4932         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4933         (_initialize_svr4_solib): Update.
4934
4935 2019-05-08  Tom Tromey  <tom@tromey.com>
4936
4937         * remote.c (remote_pspace_data): Change type.
4938         (remote_pspace_data_cleanup): Remove.
4939         (get_remote_exec_file, set_pspace_remote_exec_file)
4940         (_initialize_remote): Update.
4941
4942 2019-05-08  Tom Tromey  <tom@tromey.com>
4943
4944         * breakpoint.c (breakpoint_objfile_key): Change type.
4945         (get_breakpoint_objfile_data): Update.
4946         (free_breakpoint_objfile_data): Remove.
4947         (_initialize_breakpoint): Update.
4948
4949 2019-05-08  Tom Tromey  <tom@tromey.com>
4950
4951         * linux-tdep.c (struct linux_info): Add initializers.
4952         (linux_inferior_data): Move.  Change type.
4953         (invalidate_linux_cache_inf): Update.
4954         (linux_inferior_data_cleanup): Remove.
4955         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4956
4957 2019-05-08  Tom Tromey  <tom@tromey.com>
4958
4959         * auxv.c (auxv_inferior_data): Move.  Change type.
4960         (auxv_inferior_data_cleanup): Remove.
4961         (invalidate_auxv_cache_inf): Rewrite.
4962         (get_auxv_inferior_data, _initialize_auxv): Update.
4963
4964 2019-05-08  Tom Tromey  <tom@tromey.com>
4965
4966         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4967         (symfile_debug_objfile_data_key): Change type.
4968         (symfile_debug_installed, debug_qf_has_symbols)
4969         (debug_qf_find_last_source_symtab)
4970         (debug_qf_forget_cached_source_info)
4971         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4972         (debug_qf_print_stats, debug_qf_dump)
4973         (debug_qf_expand_symtabs_for_function)
4974         (debug_qf_expand_all_symtabs)
4975         (debug_qf_expand_symtabs_with_fullname)
4976         (debug_qf_map_matching_symbols)
4977         (debug_qf_expand_symtabs_matching)
4978         (debug_qf_find_pc_sect_compunit_symtab)
4979         (debug_qf_map_symbol_filenames)
4980         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4981         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4982         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4983         (debug_sym_read_linetable, debug_sym_relocate): Update.
4984         (symfile_debug_free_objfile): Remove.
4985         (install_symfile_debug_logging, _initialize_symfile_debug):
4986         Update.
4987
4988 2019-05-08  Tom Tromey  <tom@tromey.com>
4989
4990         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4991         allocate_on_obstack.
4992         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4993         (get_dwarf2_per_objfile): Update.
4994         (set_dwarf2_per_objfile): Remove.
4995         (dwarf2_has_info, dwarf2_get_section_info): Update.
4996         (dwarf2_free_objfile): Remove.
4997         (_initialize_dwarf2_read): Update.
4998
4999 2019-05-08  Tom Tromey  <tom@tromey.com>
5000
5001         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5002         initializers.
5003         <unsupported_script_warning_printed,
5004         script_not_found_warning_printed>: Now bool.
5005         (auto_load_pspace_data): Change type.
5006         (~auto_load_pspace_info): Rename from
5007         auto_load_pspace_data_cleanup.
5008         (get_auto_load_pspace_data, init_loaded_scripts_info)
5009         (clear_section_scripts, maybe_print_unsupported_script_warning)
5010         (maybe_print_script_not_found_warning, _initialize_auto_load):
5011         Update.
5012
5013 2019-05-08  Tom Tromey  <tom@tromey.com>
5014
5015         * objfiles.c (objfile_pspace_info): Add destructor and
5016         initializers.
5017         (objfiles_pspace_data): Change type.
5018         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5019         (get_objfile_pspace_data): Update.
5020         (objfiles_bfd_data): Change type.
5021         (get_objfile_bfd_data): Update.
5022         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5023
5024 2019-05-08  Tom Tromey  <tom@tromey.com>
5025
5026         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5027         Change type.
5028         (get_catch_syscall_inferior_data): Update.
5029         (catch_syscall_inferior_data_cleanup): Remove.
5030         (_initialize_break_catch_syscall): Update.
5031
5032 2019-05-08  Tom Tromey  <tom@tromey.com>
5033
5034         * inflow.c (struct terminal_info): Add destructor and
5035         initializers.
5036         (inflow_inferior_data): Change type.
5037         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5038         (get_inflow_inferior_data, inflow_inferior_exit)
5039         (swap_terminal_info, _initialize_inflow): Update.
5040
5041 2019-05-08  Tom Tromey  <tom@tromey.com>
5042
5043         * target-dcache.c (target_dcache_cleanup): Remove.
5044         (target_dcache_aspace_key): Change type.
5045         (target_dcache_init_p, target_dcache_invalidate)
5046         (target_dcache_get, target_dcache_get_or_init)
5047         (_initialize_target_dcache): Update.
5048         * dcache.h (struct dcache_deleter): New.
5049
5050 2019-05-08  Tom Tromey  <tom@tromey.com>
5051
5052         * symtab.c (struct symbol_cache): Add destructor and
5053         initializers.
5054         (symbol_cache_key): Move.  Change type.
5055         (make_symbol_cache, free_symbol_cache): Remove.
5056         (get_symbol_cache): Update.
5057         (symbol_cache_cleanup): Remove.
5058         (ALL_PSPACES, symbol_cache_flush)
5059         (maintenance_print_symbol_cache)
5060         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5061         Update.
5062
5063 2019-05-08  Tom Tromey  <tom@tromey.com>
5064
5065         * symtab.c (struct main_info): Add destructor and initializers.
5066         (main_progspace_key): Move.  Change type.
5067         (get_main_info): Update.
5068         (main_info_cleanup): Remove.
5069         (_initialize_symtab): Update.
5070
5071 2019-05-08  Tom Tromey  <tom@tromey.com>
5072
5073         * registry.h (DECLARE_REGISTRY): Define the _key class.
5074
5075 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5076
5077         * NEWS: Merge two 'New commands' sections.
5078
5079 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5080
5081         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5082         parameter and use Ada language definition instead.
5083         (ada_val_print_ptr): Remove unused language parameter.
5084         (ada_val_print_num): Remove language parameter and use Ada language
5085         definition instead.
5086         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5087         parameter.
5088         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5089         parameter and use Ada language definition instead.
5090         (ada_val_print_1): Update all ada_val_print_xxx calls.
5091         Remove language parameter.
5092         (ada_val_print): Update ada_val_print_1 call.
5093
5094 2019-05-08  Tom Tromey  <tromey@adacore.com>
5095
5096         * remote.c (remote_hw_watchpoint_limit)
5097         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5098         Now static.
5099
5100 2019-05-08  Tom Tromey  <tromey@adacore.com>
5101
5102         * maint.c (_initialize_maint_cmds): Move initialization code to
5103         remote.c.
5104         (watchdog, show_watchdog): Move to remote.c.
5105         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5106         "watchdog" static.
5107         (_initialize_remote): Move initialization code from maint.c.
5108         * defs.h (watchdog): Don't declare.
5109
5110 2019-05-08  Tom Tromey  <tromey@adacore.com>
5111
5112         * tui/tui-interp.c: Include main.h.
5113         * interps.c: Include main.h.
5114         * main.h (interpreter_p): Declare.
5115         * defs.h (interpreter_p): Don't declare.
5116
5117 2019-05-08  Tom Tromey  <tromey@adacore.com>
5118
5119         * dwarf2loc.c: Include dwarf2read.h.
5120         * defs.h (read_unsigned_leb128): Don't declare.
5121         * dwarf2read.h (read_unsigned_leb128): Declare.
5122
5123 2019-05-08  Tom Tromey  <tromey@adacore.com>
5124
5125         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5126         method.
5127
5128 2019-05-08  Tom Tromey  <tromey@adacore.com>
5129
5130         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5131         when no wrap column is set.
5132
5133 2019-05-08  Tom Tromey  <tromey@adacore.com>
5134
5135         * c-lang.c (c_get_string): Handle non-C-style arrays.
5136
5137 2019-05-08  Tom Tromey  <tromey@adacore.com>
5138
5139         * typeprint.c (print_offset_data::update): Print the bit offset,
5140         not the number of bits remaining.
5141
5142 2019-05-08  Tom Tromey  <tromey@adacore.com>
5143
5144         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5145         padding at end of comment.
5146
5147 2019-05-08  Tom Tromey  <tromey@adacore.com>
5148
5149         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5150         Compare main types.
5151
5152 2019-05-06  Tom Tromey  <tom@tromey.com>
5153
5154         * common/scoped_mmap.c: Include common-defs.h.
5155         * common/scoped_mmap.h: Don't include config.h.
5156
5157 2019-05-04  Tom Tromey  <tom@tromey.com>
5158
5159         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5160         (struct aarch64_call_info): Add initializers.
5161         <si>: Now a std::vector.
5162         (pass_on_stack, aarch64_push_dummy_call): Update.
5163
5164 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5165             Tom Tromey  <tom@tromey.com>
5166
5167         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5168         (ppc_threads): Now a std::vector.  Now static.
5169         (hwdebug_find_thread_points_by_tid)
5170         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5171         Update.
5172
5173 2019-05-04  Tom Tromey  <tom@tromey.com>
5174
5175         * arc-tdep.c (arc_tdesc_init): Return bool.
5176
5177 2019-05-04  Tom Tromey  <tom@tromey.com>
5178
5179         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5180         Use gdb_assert_not_reached.
5181
5182 2019-05-04  Tom Tromey  <tom@tromey.com>
5183
5184         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5185         "false".
5186
5187 2019-05-04  Tom Tromey  <tom@tromey.com>
5188
5189         * arc-tdep.c (arc_tdesc_init): Use bool.
5190
5191 2019-05-04  Tom Tromey  <tom@tromey.com>
5192
5193         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5194
5195 2019-05-04  Tom Tromey  <tom@tromey.com>
5196
5197         * cli/cli-cmds.c (valid_command_p): Return bool.
5198
5199 2019-05-04  Tom Tromey  <tom@tromey.com>
5200
5201         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5202         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5203
5204 2019-05-04  Raul Tambre  <raul@tambre.ee>
5205
5206         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5207         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5208         operator for comparison.
5209
5210 2019-05-04  Tom Tromey  <tom@tromey.com>
5211
5212         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5213         (lookup_partial_symbol, print_partial_symbols)
5214         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5215         (psymbol_compare): Update.
5216         (add_psymbol_to_bcache): Clear the entire psymbol.
5217         (maintenance_check_psymtabs): Update.
5218         * psympriv.h (struct partial_symbol): Don't derive from
5219         general_symbol_info.
5220         <obj_section, unrelocated_address, address,
5221         set_unrelocated_address>: Update.
5222         <ginfo>: New member.
5223         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5224         (debug_names::write_psymbols): Update.
5225
5226 2019-05-04  Tom de Vries  <tdevries@suse.de>
5227
5228         * contrib/cc-with-tweaks.sh: Support -n arg.
5229
5230 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5231
5232         * corelow.c (core_target::detach): Ensure frame cache and
5233         register caches are cleared.
5234         inferior.c (exit_inferior_1): Likewise.
5235
5236 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5237             Tom Tromey  <tom@tromey.com>
5238
5239         * dictionary.c (collate_pending_symbols_by_language): Remove
5240         "struct" from foreach.
5241         * symtab.c (lookup_global_symbol_from_objfile)
5242         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5243         foreach.
5244         * ser-tcp.c (net_open): Remove "struct" from foreach.
5245         * objfiles.c (objfile_relocate, objfile_rebase)
5246         (objfile_has_symbols): Remove "struct" from foreach.
5247         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5248         from foreach.
5249         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5250         foreach.
5251         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5252         "struct" from foreach.
5253         * ada-lang.c (create_excep_cond_exprs)
5254         (ada_exception_catchpoint_cond_string): Remove "struct" from
5255         foreach.
5256
5257 2019-05-03  Tom Tromey  <tromey@adacore.com>
5258
5259         * ada-exp.y (convert_char_literal): Check suffix of each
5260         enumerator.
5261
5262 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5263
5264         PR ada/21406:
5265         * ada-exp.y (yywrap): Don't define.
5266         * ada-lex.l (%option): Add noyywrap
5267         (yywrap): Remove.
5268
5269 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5270
5271         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5272         _WIN32_WINNT to the XP level, unless already defined to a higher
5273         level.
5274
5275         * unittests/parse-connection-spec-selftests.c:
5276         * ser-tcp.c:
5277         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5278         override.
5279
5280         * symfile.c (find_separate_debug_file): Remove colon from the
5281         drive spec of DOS/Windows file names of the target, so that the
5282         file name produced from DEBUGDIR and the target's directory will
5283         be valid on DOS/Windows systems.
5284
5285 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5286
5287         * rust-lang.c (val_print_struct): Handle printing structures
5288         containing strings.
5289
5290 2019-05-02  Tom Tromey  <tromey@adacore.com>
5291
5292         * valarith.c (_initialize_valarith): Remove.
5293
5294 2019-05-01  Tom Tromey  <tromey@adacore.com>
5295
5296         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5297         bitfields.
5298
5299 2019-05-01  Tom Tromey  <tromey@adacore.com>
5300
5301         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5302         for big-endian copies.
5303
5304 2019-04-30  Ali Tamur  <tamur@google.com>
5305         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5306         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5307         (read_3_bytes): New function.
5308
5309 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5310
5311         * windows-nat.c (main_thread_id): Delete.
5312         (handle_output_debug_string): Replace main_thread_id by
5313         current_event.dwThreadId.
5314         (fake_create_process): Likewise.
5315         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5316         Do not set main_thread_id.
5317         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5318         current_event.dwThreadId.
5319         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5320
5321 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5322
5323         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5324         Use current_event.dwThreadId instead of main_thread_id.
5325
5326 2019-04-30  Tom Tromey  <tromey@adacore.com>
5327
5328         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5329         (create_excep_cond_exprs): Iterate over program spaces.
5330         (ada_exception_catchpoint_cond_string): Examine all minimal
5331         symbols for exception types.
5332
5333 2019-04-30  Tom Tromey  <tromey@adacore.com>
5334
5335         PR c++/24470:
5336         * dwarf2read.c (process_structure_scope): Handle case where type
5337         has template parameters but no symbol was created.
5338
5339 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5340             Chris January  <chris.january@arm.com>
5341
5342         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5343         qualifier.
5344         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5345
5346 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5347
5348         * f-typeprint.c (f_print_type): Update rules for printing
5349         whitespace.
5350         (f_type_print_varspec_suffix): Likewise.
5351
5352 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5353             Chris January  <chris.january@arm.com>
5354
5355         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5356         function arguments.
5357
5358 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5359
5360         * f-lang.c (build_fortran_types): Change name of void type to
5361         lower case.
5362         * f-typeprint.c (f_type_print_base): Print the name of the void
5363         type, rather than a fixed string.
5364         * f-valprint.c (f_decorations): Use lower case void string.
5365
5366 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5367             Chris January  <chris.january@arm.com>
5368
5369         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5370         types for Fortran.
5371
5372 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5373             Chris January  <chris.january@arm.com>
5374             David Lecomber  <david.lecomber@arm.com>
5375
5376         * f-exp.y (BINOP_INTRINSIC): New token.
5377         (exp): New parser rule handling BINOP_INTRINSIC.
5378         (f77_keywords): Add new builtin procedures.
5379         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5380         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5381         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5382         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5383         (print_unop_subexp_f): New function.
5384         (print_binop_subexp_f): New function.
5385         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5386         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5387         (dump_subexp_body_f): Likewise.
5388         (operator_check_f): Likewise.
5389         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5390         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5391
5392 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5393
5394         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5395         UNOP_KIND.
5396         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5397         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5398         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5399         (operator_length_f): New fuction.
5400         (print_subexp_f): New function.
5401         (op_name_f): New function.
5402         (dump_subexp_body_f): New function.
5403         (operator_check_f): New function.
5404         (exp_descriptor_f): Replace standard expression handling functions
5405         with new functions.
5406         * gdb/fortran-operator.def: New file.
5407         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5408         * gdb/std-operator.def: Remove UNOP_KIND.
5409
5410 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5411
5412         * std-operator.def: Remove unbalanced, stray double quote
5413         character.
5414
5415 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5416             Chris January  <chris.january@arm.com>
5417             Daniel Everett  <daniel.everett@arm.com>
5418             Nick Forrington  <nick.forrington@arm.com>
5419             Richard Bunt  <richard.bunt@arm.com>
5420
5421         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5422         of depth when printing anonymous structs or unions.
5423         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5424         Don't print either the top-level value, or the children if the
5425         max-depth is exceeded.
5426         (ppscm_print_children): When printing the key of a map, allow one
5427         extra level of depth.
5428         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5429         print either the top-level value, or the children if the max-depth
5430         is exceeded.
5431         (print_children): When printing the key of a map, allow one extra
5432         level of depth.
5433         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5434         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5435         (user_print_options): Initialise max_depth field.
5436         (val_print_scalar_or_string_type_p): New function.
5437         (val_print): Check to see if the max depth has been reached.
5438         (val_print_check_max_depth): Define new function.
5439         (show_print_max_depth): New function.
5440         (_initialize_valprint): Add 'print max-depth' option.
5441         * valprint.h (struct value_print_options) <max_depth>: New field.
5442         (val_print_check_max_depth): Declare new function.
5443         * NEWS: Document new feature.
5444
5445 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5446
5447         * ada-lang.c (ada_language_defn): Initialise new field.
5448         * c-lang.c (c_is_string_type_p): New function.
5449         (c_language_defn): Initialise new field.
5450         (cplus_language_defn): Initialise new field.
5451         (asm_language_defn): Initialise new field.
5452         (minimal_language_defn): Initialise new field.
5453         * c-lang.h (c_is_string_type_p): Declare new function.
5454         * d-lang.c (d_language_defn): Initialise new field.
5455         * f-lang.c (f_is_string_type_p): New function.
5456         (f_language_defn): Initialise new field.
5457         * go-lang.c (go_is_string_type_p): New function.
5458         (go_language_defn): Initialise new field.
5459         * language.c (default_is_string_type_p): New function.
5460         (unknown_language_defn): Initialise new field.
5461         (auto_language_defn): Initialise new field.
5462         * language.h (struct language_defn) <la_is_string_type_p>: New
5463         member variable.
5464         (default_is_string_type_p): Declare new function.
5465         * m2-lang.c (m2_language_defn): Initialise new field.
5466         * objc-lang.c (objc_language_defn): Initialise new field.
5467         * opencl-lang.c (opencl_language_defn): Initialise new field.
5468         * p-lang.c (pascal_is_string_type_p): New function.
5469         (pascal_language_defn): Initialise new field.
5470         * rust-lang.c (rust_is_string_type_p): New function.
5471         (rust_language_defn): Initialise new field.
5472
5473 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5474
5475         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5476         New field.
5477         * ada-lang.c (ada_language_defn): Initialise new field.
5478         * c-lang.c (c_language_defn): Likewise.
5479         (cplus_language_defn): Likewise.
5480         (asm_language_defn): Likewise.
5481         (minimal_language_defn): Likewise.
5482         * d-lang.c (d_language_defn): Likewise.
5483         * f-lang.c (f_language_defn): Likewise.
5484         * go-lang.c (go_language_defn): Likewise.
5485         * language.c (unknown_language_defn): Likewise.
5486         (auto_language_defn): Likewise.
5487         * m2-lang.c (m2_language_defn): Likewise.
5488         * objc-lang.c (objc_language_defn): Likewise.
5489         * opencl-lang.c (opencl_language_defn): Likewise.
5490         * p-lang.c (pascal_language_defn): Likewise.
5491         * rust-lang.c (rust_language_defn): Likewise.
5492
5493 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5494
5495         * ada-lang.c (ada_is_character_type): Change return type to bool.
5496         (ada_is_string_type): Likewise.
5497         * ada-lang.h (ada_is_character_type): Update declaration
5498         (ada_is_string_type): Likewise.
5499
5500 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5501
5502         Support style in 'frame|thread apply'
5503
5504         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5505         * record.c (record_start, record_stop): Update callers of
5506         execute_command_to_string with false.
5507         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5508         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5509         methods.
5510         (class string_file): New constructor with term_out parameter.
5511         Override methods term_out and can_emit_style_escape.  New member
5512         term_out.
5513         (class stdio_file): Override can_emit_style_escape.
5514         (class tee_file): Override term_out and can_emit_style_escape.
5515         * utils.h (can_emit_style_escape): Remove.
5516         * utils.c (can_emit_style_escape): Likewise.
5517         Update all callers of can_emit_style_escape (SOMESTREAM) to
5518         SOMESTREAM->can_emit_style_escape.
5519         * source-cache.c (source_cache::get_source_lines): Likewise.
5520         * stack.c (frame_apply_command_count): Call execute_command_to_string
5521         passing the term_out characteristic of the current gdb_stdout.
5522         * thread.c (thr_try_catch_cmd): Likewise.
5523         * top.c (execute_command_to_string): pass term_out parameter
5524         to construct the string_file for the command output.
5525         * ui-file.c (term_cli_styling): New function (most code moved
5526         from utils.c can_emit_style_escape).
5527         (string_file::string_file, string_file::can_emit_style_escape,
5528         stdio_file::can_emit_style_escape, tee_file::term_out,
5529         tee_file::can_emit_style_escape): New functions.
5530
5531 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5532
5533         * NEWS: Mention the new set|show may-call-functions.
5534         * infcall.c (may_call_functions_p): New variable.
5535         (show_may_call_functions_p): New function.
5536         (call_function_by_hand_dummy): Throws an error if not
5537         may-call-functions.
5538         (_initialize_infcall): Call add_setshow_boolean_cmd for
5539         may-call-functions.
5540
5541 2019-04-25  Keith Seitz  <keiths@redhat.com>
5542
5543         PR c++/24367
5544         * cp-support.c (inspect_type): Don't attempt substitutions
5545         of symbol with the same name.
5546
5547 2019-04-25  Tom Tromey  <tromey@adacore.com>
5548
5549         PR gdb/24475:
5550         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5551         static.
5552
5553 2019-04-25  Tom Tromey  <tromey@adacore.com>
5554
5555         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5556         rvalue reference.
5557         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5558         (gdb_xml_parser::parse): Use std::move.
5559         * python/python-internal.h (gdbpy_convert_exception): Take a const
5560         reference.
5561         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5562         std::move.
5563         * python/py-utils.c (gdbpy_convert_exception): Take a const
5564         reference.
5565         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5566         Use std::move.
5567         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5568         Use std::move.
5569         * mi/mi-main.c (mi_print_exception): Take a const reference.
5570         * main.c (handle_command_errors): Take a const reference.
5571         * linespec.c (parse_linespec): Use std::move.
5572         * infcall.c (run_inferior_call): Use std::move.
5573         (call_function_by_hand_dummy): Use std::move.
5574         * exec.c (try_open_exec_file): Use std::move.
5575         * exceptions.h (exception_print, exception_fprintf)
5576         (exception_print_same): Update.
5577         * exceptions.c (print_exception, exception_print)
5578         (exception_fprintf, exception_print_same): Change parameters to
5579         const reference.
5580         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5581         * common/new-op.c: Use std::move.
5582         * common/common-exceptions.h (struct gdb_exception): Add move
5583         constructor.
5584         (struct gdb_exception_error, struct gdb_exception_quit, struct
5585         gdb_quit_bad_alloc): Change constructor to move constructor.
5586         (throw_exception): Change parameter to rvalue reference.
5587         * common/common-exceptions.c (throw_exception): Take rvalue
5588         reference.
5589         * cli/cli-interp.c (safe_execute_command): Use std::move.
5590         * breakpoint.c (insert_bp_location, location_to_sals): Use
5591         std::move.
5592
5593 2019-04-25  Tom Tromey  <tromey@adacore.com>
5594
5595         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5596         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5597         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5598         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5599         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5600         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5601         guile/scm-value.c: Use unpack.
5602         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5603         gdbscm_gdb_exception.
5604         (gdbscm_throw_gdb_exception): Likewise.
5605         (struct gdbscm_gdb_exception): New.
5606         (unpack): New function.
5607         (gdbscm_wrap): Use unpack.
5608
5609 2019-04-25  Tom Tromey  <tromey@adacore.com>
5610
5611         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5612         (gdb_rl_callback_handler): Use std::move.
5613         * common/common-exceptions.h (struct gdb_exception): Add move
5614         assignment operator.
5615         (throw_exception_sjlj): Change "exception" to const reference.
5616         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5617         (throw_exception_sjlj): Change "exception" to const reference.
5618
5619 2019-04-25  Tom Tromey  <tromey@adacore.com>
5620
5621         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5622         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5623         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5624         Update.
5625         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5626         Update.
5627         * mi/mi-interp.c (mi_interp::exec): Update.
5628         * linespec.c (parse_linespec): Update.
5629         * infcall.c (run_inferior_call): Update.
5630         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5631         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5632         (gdbscm_lookup_global_symbol): Update.
5633         * guile/scm-param.c (gdbscm_parameter_value): Update.
5634         * guile/scm-frame.c (gdbscm_frame_read_register)
5635         (gdbscm_frame_read_var): Update.
5636         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5637         * exec.c (try_open_exec_file): Update.
5638         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5639         (gdb_rl_callback_handler): Update.
5640         * common/common-exceptions.h (exception_none): Don't declare.
5641         * common/common-exceptions.c (exception_none): Don't define.
5642         (struct catcher) <exception>: Update.
5643         * cli/cli-interp.c (safe_execute_command): Update.
5644         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5645
5646 2019-04-25  Ali Tamur  <tamur@google.com>
5647
5648         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5649         (read_attribute_value): Likewise.
5650         (dwarf2_read_addr_index): Update comment.
5651         (read_str_index): Add DW_FORM_strx.
5652         (dwarf2_string_attr): Likewise.
5653         (dwarf2_const_value_attr): Likewise.
5654         (dump_die_shallow): Likewise.
5655         (dwarf2_fetch_constant_bytes): Likewise.
5656         (skip_form_bytes): Likewise.
5657         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5658
5659 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5660
5661         PR corefiles/11608
5662         PR corefiles/18187
5663         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5664         OFFSET.  Verify if current mapping contains an ELF header.
5665         (linux_find_memory_regions_full): Adjust call to
5666         dump_mapping_p.
5667
5668 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5669             Kang Li <kanglictf@gmail.com>
5670
5671         PR gdb/21600
5672
5673         * dwarf2-frame.c (read_initial_length): Be consistent about using
5674         unsigned representation of length.
5675         (decode_frame_entry_1): Likewise.  Check for wraparound of
5676         end pointer as well as buffer overflow.
5677
5678 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5679
5680         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5681         "vq".
5682
5683 2019-04-24  Tom Tromey  <tromey@adacore.com>
5684
5685         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5686
5687 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5688
5689         * s12z-tdep.c (s12z_unwind_pc): Delete.
5690         (s12z_unwind_sp): Delete.
5691         (s12z_gdbarch_init): Don't register deleted functions with
5692         gdbarch.
5693
5694 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5695
5696         * rl78-tdep.c (rl78_unwind_sp): Delete.
5697         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5698
5699 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5700
5701         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5702         (xstormy16_unwind_pc): Delete.
5703         (xstormy16_dummy_id): Delete.
5704         (xstormy16_gdbarch_init): Don't register deleted functions with
5705         gdbarch.
5706
5707 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5708
5709         * vax-tdep.c (vax_unwind_pc): Delete.
5710         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5711
5712 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5713
5714         * v850-tdep.c (v850_unwind_sp): Delete.
5715         (v850_unwind_pc): Delete.
5716         (v850_dummy_id): Delete.
5717         (v850_gdbarch_init): Don't register deleted functions with
5718         gdbarch.
5719
5720 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5721
5722         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5723         (tilegx_unwind_pc): Delete.
5724         (tilegx_unwind_dummy_id): Delete.
5725         (tilegx_gdbarch_init): Don't register deleted functions with
5726         gdbarch.
5727
5728 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5729
5730         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5731         (tic6x_dummy_id): Delete.
5732         (tic6x_gdbarch_init): Don't register deleted functions with
5733         gdbarch.
5734
5735 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5736
5737         * sparc-tdep.c (sparc_unwind_pc): Delete.
5738         (sparc32_gdbarch_init): Don't register deleted function with
5739         gdbarch.
5740
5741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5742
5743         * sh-tdep.c (sh_unwind_sp): Delete.
5744         (sh_unwind_pc): Delete.
5745         (sh_dummy_id): Delete.
5746         (sh_gdbarch_init): Don't register deleted functions with
5747         gdbarch.
5748
5749 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5750
5751         * score-tdep.c (score_unwind_sp): Delete.
5752         (score_unwind_pc): Delete.
5753         (score_dummy_id): Delete.
5754         (score_gdbarch_init): Don't register deleted functions with
5755         gdbarch.
5756
5757 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5758
5759         * rx-tdep.c (rx_unwind_pc): Delete.
5760         (rx_unwind_sp): Delete.
5761         (rx_dummy_id): Delete.
5762         (rx_gdbarch_init): Don't register deleted functions with
5763         gdbarch.  Update comment.
5764
5765 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5766
5767         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5768         (rs6000_dummy_id): Delete.
5769         (rs6000_gdbarch_init): Don't register deleted functions with
5770         gdbarch.
5771
5772 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5773
5774         * or1k-tdep.c (or1k_dummy_id): Delete.
5775         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5776
5777 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5778
5779         * nios2-tdep.c (nios2_dummy_id): Delete.
5780         (nios2_unwind_sp): Delete.
5781         (nios2_gdbarch_init): Don't register deleted functions with
5782         gdbarch.
5783
5784 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5785
5786         * nds32-tdep.c (nds32_dummy_id): Delete.
5787         (nds32_unwind_pc): Delete.
5788         (nds32_unwind_sp): Delete.
5789         (nds32_gdbarch_init): Don't register deleted functions with
5790         gdbarch.
5791
5792 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5793
5794         * msp430-tdep.c (msp430_unwind_pc): Delete.
5795         (msp430_unwind_sp): Delete.
5796         (msp430_dummy_id): Delete.
5797         (msp430_gdbarch_init): Don't register deleted functions with
5798         gdbarch.
5799
5800 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5801
5802         * moxie-tdep.c (moxie_unwind_sp): Delete.
5803         (moxie_unwind_pc): Delete.
5804         (moxie_dummy_id): Delete.
5805         (moxie_gdbarch_init): Don't register deleted functions with
5806         gdbarch.
5807
5808 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5809
5810         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5811         (mn10300_unwind_pc): Delete.
5812         (mn10300_unwind_sp): Delete.
5813         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5814         mn10300_unwind_sp.
5815         (mn10300_frame_unwind_init): Don't register deleted functions with
5816         gdbarch.
5817
5818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5819
5820         * mep-tdep.c (mep_unwind_pc): Delete.
5821         (mep_unwind_sp): Delete.
5822         (mep_dummy_id): Delete.
5823         (mep_gdbarch_init): Don't register deleted functions with
5824         gdbarch.
5825
5826 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5827
5828         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5829         (m68hc11_unwind_sp): Delete.
5830         (m68hc11_gdbarch_init): Don't register deleted functions with
5831         gdbarch.
5832
5833 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5834
5835         * m32r-tdep.c (m32r_unwind_sp): Delete.
5836         (m32r_unwind_pc): Delete.
5837         (m32r_dummy_id): Delete.
5838         (m32r_gdbarch_init): Don't register deleted functions with
5839         gdbarch.
5840
5841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5842
5843         * m32c-tdep.c (m32c_unwind_pc): Delete.
5844         (m32c_unwind_sp): Delete.
5845         (m32c_dummy_id): Delete.
5846         (m32c_gdbarch_init): Don't register deleted functions with
5847         gdbarch.
5848
5849 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5850
5851         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5852         (lm32_unwind_pc): Delete.
5853         (lm32_dummy_id): Delete.
5854         (lm32_gdbarch_init): Don't register deleted functions with
5855         gdbarch.
5856
5857 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5858
5859         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5860         (iq2000_unwind_pc): Delete.
5861         (iq2000_dummy_id): Delete.
5862         (iq2000_gdbarch_init): Don't register deleted functions with
5863         gdbarch.
5864
5865 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5866
5867         * nds32-tdep.c (nds32_type_align): Delete.
5868         (nds32_push_dummy_call): Use type_align instead.
5869
5870 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5871
5872         * arm-tdep.c (arm_type_align): Only handle vector override case.
5873         (arm_push_dummy_call): Use type_align.
5874         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5875
5876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5877
5878         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5879         case.
5880         (pass_on_stack): Use type_align.
5881         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5882         function.
5883
5884 2019-04-23  Tom Tromey  <tromey@adacore.com>
5885
5886         * dwarf2read.c (line_header::file_name_at): Remove unused
5887         overload.
5888
5889 2019-04-23  Tom de Vries  <tdevries@suse.de>
5890
5891         PR gdb/24438
5892         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5893         invocation.
5894
5895
5896 2019-03-27  Ali Tamur  <tamur@google.com>
5897
5898         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5899         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5900         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5901         (dwarf_expr_context::get_addr_index): Likewise
5902         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5903         (symbol_needs_eval_context::get_addr_index): Likewise
5904         (disassemble_dwarf_expression): Add DW_OP_addrx
5905         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5906         (read_cutu_die_from_dwo): Update comment
5907         (skip_one_die): Add DW_FORM_addrx
5908         (read_attribute_value): Likewise
5909         (var_decode_location): Add DW_OP_addrx
5910         (dwarf2_const_value_attr): Add DW_FORM_addrx
5911         (dump_die_shallow): Likewise
5912         (dwarf2_fetch_constant_bytes): Likewise
5913         (decode_locdesc): Add DW_OP_addrx
5914         (skip_form_bytes): Add DW_FORM_addrx
5915
5916 2019-04-22  Ali Tamur  <tamur@google.com>
5917
5918         * MAINTAINERS (Write After Approval): Add self.
5919
5920 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5921
5922         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5923         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5924         (open_symbol_file_object): Likewise.
5925         (svr4_default_sos): Add info parameter.
5926         (svr4_read_so_list): Likewise.
5927         (svr4_current_sos_direct): Adjust functions calls to pass down
5928         info.
5929         (svr4_current_sos_1): Add info parameter.
5930         (svr4_current_sos): Call get_svr4_info, pass info down to
5931         svr4_current_sos_1.
5932         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5933         get_svr4_info.
5934         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5935         get_svr4_info.
5936         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5937         to get_svr4_info.
5938         (probes_table_remove_objfile_probes): Likewise.
5939         (register_solib_event_probe): Add info parameter.
5940         (solist_update_incremental): Pass info parameter down to
5941         svr4_read_so_list.
5942         (disable_probes_interface): Add info parameter.
5943         (svr4_handle_solib_event): Pass current_program_space to
5944         get_svr4_info.  Adjust disable_probes_interface cleanup.
5945         (svr4_create_probe_breakpoints): Add info parameter, pass it
5946         down to register_solib_event_probe.
5947         (svr4_create_solib_event_breakpoints): Add info parameter,
5948         pass it down to svr4_create_probe_breakpoints.
5949         (enable_break): Pass info down to
5950         svr4_create_solib_event_breakpoints.
5951         (svr4_solib_create_inferior_hook): Pass current_program_space to
5952         get_svr4_info.
5953         (svr4_clear_solib): Likewise.
5954
5955 2019-04-22  Pedro Alves  <palves@redhat.com>
5956
5957         * solib-svr4.c (svr4_free_objfile_observer): New.
5958         (probe_and_action::objfile): New field.
5959         (probes_table_htab_remove_objfile_probes)
5960         (probes_table_remove_objfile_probes): New functions.
5961         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5962         in the new probe_and_action.  Don't store the probe in 'lookup'.
5963         (svr4_create_probe_breakpoints): Pass objfile to
5964         register_solib_event_probe.
5965         (_initialize_svr4_solib): Register a free_objfile observer.
5966
5967 2019-04-19  Tom Tromey  <tom@tromey.com>
5968
5969         * common/queue.h: Remove.
5970
5971 2019-04-19  Tom Tromey  <tom@tromey.com>
5972
5973         * event-loop.c: Don't include "common/queue.h".
5974
5975 2019-04-19  Tom Tromey  <tom@tromey.com>
5976
5977         * remote.c (remote_target): Use delete.
5978         * remote-notif.h: Include <list>, not "common/queue.h".
5979         (notif_client_p): Remove typedef.
5980         (remote_notif_state): Add constructor, destructor, initializer.
5981         <notif_queue>: Now a std::list.
5982         (remote_notif_state_xfree): Don't declare.
5983         * remote-notif.c (remote_notif_process, handle_notification)
5984         (remote_notif_state_allocate): Update.
5985         (~remote_notif_state): Rename from remote_notif_state_xfree.
5986
5987 2019-04-19  Tom Tromey  <tom@tromey.com>
5988
5989         * symfile.c (reread_symbols): Update.
5990         * objfiles.c (objfile_register_static_link)
5991         (objfile_lookup_static_link): Update
5992         (~objfile) Don't delete static_links.
5993         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5994
5995 2019-04-19  Tom Tromey  <tom@tromey.com>
5996
5997         * type-stack.h (struct type_stack) <insert>: Constify string.
5998         * type-stack.c (type_stack::insert): Constify string.
5999         * gdbtypes.h (lookup_template_type): Update.
6000         (address_space_name_to_int): Update.
6001         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6002         const.
6003         (lookup_template_type): Make name const.
6004         * c-exp.y: Update rules.
6005         (lex_one_token, classify_name, classify_inner_name)
6006         (c_print_token): Update.
6007         * p-exp.y: Update rules.
6008         (yylex): Update.
6009         * f-exp.y: Update rules.
6010         (yylex): Update.
6011         * d-exp.y: Update rules.
6012         (lex_one_token, classify_name, classify_inner_name): Update.
6013         * parse.c (write_dollar_variable, copy_name): Return std::string.
6014         * parser-defs.h (copy_name): Change return type.
6015         * m2-exp.y: Update rules.
6016         (yylex): Update.
6017         * go-exp.y (lex_one_token): Update.
6018         Update rules.
6019         (classify_unsafe_function, classify_packaged_name)
6020         (classify_name, yylex): Update.
6021
6022 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6023
6024         * configure.ac: add --enable-source-highlight switch.
6025         * configure: Regenerate.
6026         * top.c (print_gdb_version): plumb --enable-source-highlight
6027         status to "show configuration".
6028
6029 2019-04-19  Tom Tromey  <tromey@adacore.com>
6030
6031         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6032         Check ADA_TYPE_P.
6033         (empty_record, ada_template_to_fixed_record_type_1)
6034         (template_to_static_fixed_type)
6035         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6036         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6037         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6038         macros.
6039
6040 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6041
6042         PR symtab/24423:
6043         * source.c (print_source_lines_base): Advance "iter" when a
6044         control character is seen.
6045
6046 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6047
6048         * inferior.h (struct infcall_suspend_state_deleter):
6049         Catch exception in destructor to avoid crash.
6050
6051 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6052
6053         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6054         close to the add_com "shell".
6055
6056 2019-04-18  Tom Tromey  <tromey@adacore.com>
6057
6058         * process-stratum-target.h (class process_stratum_target)
6059         <stratum>: Add "final".
6060
6061 2019-04-17  Tom Tromey  <tromey@adacore.com>
6062
6063         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6064         against nullptr before use.
6065
6066 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6067
6068         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6069
6070 2019-04-17  Jim Wilson  <jimw@sifive.com>
6071             Andrew Burgess  <andrew.burgess@embecosm.com>
6072
6073         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6074         code read might fail, assume 4-byte breakpoint in that case.
6075
6076 2019-04-15  Leszek Swirski  <leszeks@google.com>
6077
6078         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6079         rather than a hand-rolled POD check when checking for forced MEMORY
6080         classification.
6081
6082 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6083
6084         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6085         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6086         function.
6087         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6088         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6089         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6090         declaration.
6091
6092 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6093
6094         * aarch64-linux-nat.c
6095         (aarch64_linux_nat_target::thread_architecture): Add override.
6096         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6097         each VQ.
6098
6099 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6100
6101         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6102
6103 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6104
6105         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6106         target types of size 96-bits, add some additional comments, and
6107         check that the builtin type we found was the correct size.
6108
6109 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6110
6111         * utils.c (prompt_for_continue): Don't restore the styling at the
6112         end, as applied_style has the wrong value.  This fixes styling in
6113         long lists of file names that are interrupted by the "Continue?"
6114         prompt.
6115
6116 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6117
6118         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6119         * c-lang.c (c_language_defn): Likewise.
6120         (cplus_language_defn): Likewise.
6121         (asm_language_defn): Likewise.
6122         (minimal_language_defn): Likewise.
6123         * d-lang.c (d_language_defn): Likewise.
6124         * f-lang.c (f_language_defn): Likewise.
6125         * go-lang.c (go_language_defn): Likewise.
6126         * language.c (unknown_language_defn): Likewise.
6127         (auto_language_defn): Likewise.
6128         * language.h (struct language_defn): Remove la_magic field.
6129         (LANG_MAGIC): Delete.
6130         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6131         * objc-lang.c (objc_language_defn): Likewise.
6132         * opencl-lang.c (opencl_language_defn): Likewise.
6133         * p-lang.c (pascal_language_defn): Likewise.
6134         * rust-lang.c (rust_language_defn): Likewise.
6135
6136 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6137
6138         * riscv-tdep.c (riscv_type_align): New function.
6139         (riscv_type_alignment): Delete.
6140         (riscv_arg_location): Use 'type_align'.
6141         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6142
6143 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6144
6145         * gdbtypes.c (type_align): A struct with no non-static fields also
6146         has alignment of 1.
6147
6148 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6149
6150         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6151         component to 0.
6152         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6153         member.
6154         (riscv_struct_info::analyse): New implementation using new
6155         analyse_inner member function.
6156         (riscv_struct_info::field_offset): New member function.
6157         (riscv_struct_info::m_offsets): New member variable.
6158         (riscv_struct_info::analyse_inner): New private member function,
6159         takes the old implementation of riscv_struct_info::analyse but
6160         extended to track field offsets.
6161         (riscv_call_arg_struct): Update the struct folding special cases
6162         to handle cases where empty C++ structs, which are non-zero
6163         length, are found.
6164         (riscv_arg_location): Initialise the length of each location, a
6165         non-zero length now indicates the location is in use.
6166         (riscv_push_dummy_call): Allow for the first location having a
6167         non-zero offset when setting up arguments.
6168         (riscv_return_value): Likewise, but for return values.
6169
6170 2019-04-11  Tom Tromey  <tromey@adacore.com>
6171
6172         * utils.c (internal_vproblem): Make "msg" const.
6173
6174 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6175
6176         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6177         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6178         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6179         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6180
6181 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6182
6183         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6184         function.
6185         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6186         of amd64_collect_native_gregset.
6187         (amd64_linux_nat_target::store_registers): Likewise.
6188
6189 2019-04-10  Tom Tromey  <tom@tromey.com>
6190
6191         * symtab.c (lookup_global_symbol_from_objfile)
6192         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6193         * objfiles.h (class separate_debug_iterator): New.
6194         (class separate_debug_range): New.
6195         (struct objfile) <separate_debug_objfiles>: New method.
6196         (objfile_separate_debug_iterate): Don't declare.
6197         * objfiles.c (separate_debug_iterator::operator++): Rename from
6198         objfile_separate_debug_iterate.
6199         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6200         iterator.
6201         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6202         iterator.
6203
6204 2019-04-10  Tom Tromey  <tom@tromey.com>
6205
6206         * symfile.c (reread_symbols): Remove old comment.
6207         * objfiles.c (free_all_objfiles): Fix a typo.
6208
6209 2019-04-10  Tom Tromey  <tom@tromey.com>
6210
6211         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6212         * minsyms.c (lookup_minimal_symbol): Use foreach.
6213         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6214         (lookup_minimal_symbol_solib_trampoline): Likewise.
6215         * symfile.c (reread_symbols): Use foreach.
6216
6217 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6218             Tom Tromey  <tromey@adacore.com>
6219
6220         PR rust/24414:
6221         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6222         (rust_lex_int_test): Change "value" to be LONGEST.
6223         (rust_lex_tests): Add test for long integer literal.
6224
6225 2019-04-09  Tom Tromey  <tromey@adacore.com>
6226
6227         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6228         to bool.
6229         (extended_remote_target::attach): Update.
6230         (remote_target::remote_notice_new_inferior): Update.
6231         (remote_target::add_current_inferior_and_thread): Update.
6232         * inferior.c (exit_inferior_1): Use "false".
6233         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6234
6235 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6236
6237         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6238         the "start" command.
6239
6240 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6241
6242         * python/py-inferior.c (infpy_thread_from_thread_handle):
6243         Adjust comments to reflect renaming of thread_from_thread_handle
6244         to thread_from_handle.  Adjust keywords.  Fix type error message.
6245         (inferior_object_methods): Add thread_from_handle.  Retain
6246         thread_from_thread_handle, but mark it as deprecated.
6247
6248 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6249
6250         * gdbthread.h (find_thread_by_handle): Revise declaration.
6251         * thread.c (find_thread_by_handle): Likewise.  Adjust
6252         implementation too.
6253         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6254         support for buffer objects as handles.
6255
6256 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6257
6258         * python/py-infthread.c (thpy_thread_handle): New function.
6259         (thread_object_methods): Register thpy_thread_handle.
6260
6261 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6262
6263         * gdbthread.h (thread_to_thread_handle): Declare.
6264         * thread.c (gdbtypes.h): Include.
6265         (thread_to_thread_handle): New function.
6266
6267         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6268         (target_thread_info_to_thread_handle): Declare.
6269         * target.c (target_thread_info_to_thread_handle): New function.
6270         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6271         * target-delegates.c: Regenerate.
6272
6273         * linux-thread-db.c (class thread_db_target): Add method
6274         thread_info_to_thread_handle.
6275         (thread_db_target::thread_info_to_thread_handle): Define.
6276         * remote.c (class remote_target): Add new method
6277         thread_info_to_thread_handle.
6278         (remote_target::thread_info_to_thread_handle): Define.
6279
6280 2019-04-08  Pedro Alves  <palves@redhat.com>
6281
6282         * common/common-exceptions.c (throw_exception): Don't create
6283         named object to throw; throw directly.
6284         (throw_it): Likewise.  Don't initialize gdb_exception::message
6285         here, with new; pass FMT and AP to the ctor instead.
6286         * common/common-exceptions.h: Include <string>.
6287         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6288         const char *, va_list)): New ctor.  Use std::make_shared.
6289         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6290         errors)): Delete.
6291         (gdb_exception_error::gdb_exception_error(enum errors, const char
6292         *, va_list)): New.
6293         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6294         Add assertion.
6295         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6296         errors)): Delete.
6297         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6298         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6299         Add assertion.
6300
6301 2019-04-08  Tom Tromey  <tom@tromey.com>
6302
6303         * valops.c (value_rtti_indirect_type): Replace throw_exception
6304         with throw.
6305         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6306         with throw.
6307         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6308         throw.
6309         * target.c (target_translate_tls_address): Replace throw_exception
6310         with throw.
6311         * stack.c (frame_apply_command_count): Replace throw_exception
6312         with throw.
6313         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6314         throw.
6315         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6316         with throw.
6317         * rs6000-tdep.c (rs6000_frame_cache)
6318         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6319         * remote.c: Replace throw_exception with throw.
6320         * record-full.c (record_full_message, record_full_wait_1)
6321         (record_full_restore): Replace throw_exception with throw.
6322         * record-btrace.c:
6323         (get_thread_current_frame_id, record_btrace_start_replaying)
6324         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6325         (cmd_record_btrace_start): Replace throw_exception with throw.
6326         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6327         throw.
6328         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6329         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6330         * linespec.c:
6331         (find_linespec_symbols): Replace throw_exception with throw.
6332         * infrun.c (displaced_step_prepare, resume): Replace
6333         throw_exception with throw.
6334         * infcmd.c (post_create_inferior): Replace throw_exception with
6335         throw.
6336         * inf-loop.c (inferior_event_handler): Replace throw_exception
6337         with throw.
6338         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6339         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6340         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6341         (get_prev_frame_always, get_frame_pc_if_available)
6342         (get_frame_address_in_block_if_available, get_frame_language):
6343         Replace throw_exception with throw.
6344         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6345         throw_exception with throw.
6346         * eval.c (fetch_subexp_value, evaluate_var_value)
6347         (evaluate_funcall, evaluate_subexp_standard): Replace
6348         throw_exception with throw.
6349         * dwarf2loc.c (call_site_find_chain)
6350         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6351         Replace throw_exception with throw.
6352         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6353         with throw.
6354         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6355         throw.
6356         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6357         * completer.c (complete_line_internal): Replace throw_exception
6358         with throw.
6359         * compile/compile-object-run.c (compile_object_run): Replace
6360         throw_exception with throw.
6361         * cli/cli-script.c (process_next_line): Replace throw_exception
6362         with throw.
6363         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6364         (btrace_enable, btrace_maint_update_pt_packets): Replace
6365         throw_exception with throw.
6366         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6367         throw_exception with throw.
6368         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6369         throw_exception with throw.
6370         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6371         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6372         * aarch64-tdep.c (aarch64_make_prologue_cache)
6373         (aarch64_make_stub_cache): Replace throw_exception with throw.
6374
6375 2019-04-08  Tom Tromey  <tom@tromey.com>
6376
6377         * common/common-exceptions.c (throw_exception): Rename from
6378         throw_exception_cxx.  Remove old copy.  Make argument const.
6379         (throw_it): Create and throw exception objects directly.
6380         * common/common-exceptions.h (throw_exception): Make argument
6381         const.
6382         (struct gdb_exception_error): Add constructor.
6383         (struct gdb_exception_quit): Add constructor.
6384
6385 2019-04-08  Tom Tromey  <tom@tromey.com>
6386
6387         * common/common-exceptions.h (exception_rethrow): Don't declare.
6388         (TRY_SJLJ): Update comment.
6389         (TRY, CATCH, END_CATCH): Remove.
6390         * common/common-exceptions.c (exception_rethrow): Remove.
6391
6392 2019-04-08  Tom Tromey  <tom@tromey.com>
6393
6394         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6395         Remove.
6396         (gdb_exception_error): Rename from
6397         gdb_exception_RETURN_MASK_ERROR.
6398         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6399         (gdb_quit_bad_alloc): Update.
6400         * aarch64-tdep.c: Update.
6401         * ada-lang.c: Update.
6402         * ada-typeprint.c: Update.
6403         * ada-valprint.c: Update.
6404         * amd64-tdep.c: Update.
6405         * arch-utils.c: Update.
6406         * break-catch-throw.c: Update.
6407         * breakpoint.c: Update.
6408         * btrace.c: Update.
6409         * c-varobj.c: Update.
6410         * cli/cli-cmds.c: Update.
6411         * cli/cli-interp.c: Update.
6412         * cli/cli-script.c: Update.
6413         * common/common-exceptions.c: Update.
6414         * common/new-op.c: Update.
6415         * common/selftest.c: Update.
6416         * compile/compile-c-symbols.c: Update.
6417         * compile/compile-cplus-symbols.c: Update.
6418         * compile/compile-object-load.c: Update.
6419         * compile/compile-object-run.c: Update.
6420         * completer.c: Update.
6421         * corelow.c: Update.
6422         * cp-abi.c: Update.
6423         * cp-support.c: Update.
6424         * cp-valprint.c: Update.
6425         * darwin-nat.c: Update.
6426         * disasm-selftests.c: Update.
6427         * dtrace-probe.c: Update.
6428         * dwarf-index-cache.c: Update.
6429         * dwarf-index-write.c: Update.
6430         * dwarf2-frame-tailcall.c: Update.
6431         * dwarf2-frame.c: Update.
6432         * dwarf2loc.c: Update.
6433         * dwarf2read.c: Update.
6434         * eval.c: Update.
6435         * event-loop.c: Update.
6436         * event-top.c: Update.
6437         * exec.c: Update.
6438         * f-valprint.c: Update.
6439         * fbsd-tdep.c: Update.
6440         * frame-unwind.c: Update.
6441         * frame.c: Update.
6442         * gdbtypes.c: Update.
6443         * gnu-v3-abi.c: Update.
6444         * guile/guile-internal.h: Update.
6445         * guile/scm-block.c: Update.
6446         * guile/scm-breakpoint.c: Update.
6447         * guile/scm-cmd.c: Update.
6448         * guile/scm-disasm.c: Update.
6449         * guile/scm-frame.c: Update.
6450         * guile/scm-lazy-string.c: Update.
6451         * guile/scm-math.c: Update.
6452         * guile/scm-param.c: Update.
6453         * guile/scm-ports.c: Update.
6454         * guile/scm-pretty-print.c: Update.
6455         * guile/scm-symbol.c: Update.
6456         * guile/scm-symtab.c: Update.
6457         * guile/scm-type.c: Update.
6458         * guile/scm-value.c: Update.
6459         * i386-linux-tdep.c: Update.
6460         * i386-tdep.c: Update.
6461         * inf-loop.c: Update.
6462         * infcall.c: Update.
6463         * infcmd.c: Update.
6464         * infrun.c: Update.
6465         * jit.c: Update.
6466         * language.c: Update.
6467         * linespec.c: Update.
6468         * linux-fork.c: Update.
6469         * linux-nat.c: Update.
6470         * linux-tdep.c: Update.
6471         * linux-thread-db.c: Update.
6472         * main.c: Update.
6473         * mi/mi-cmd-break.c: Update.
6474         * mi/mi-cmd-stack.c: Update.
6475         * mi/mi-interp.c: Update.
6476         * mi/mi-main.c: Update.
6477         * objc-lang.c: Update.
6478         * p-valprint.c: Update.
6479         * parse.c: Update.
6480         * ppc-linux-tdep.c: Update.
6481         * printcmd.c: Update.
6482         * python/py-arch.c: Update.
6483         * python/py-breakpoint.c: Update.
6484         * python/py-cmd.c: Update.
6485         * python/py-finishbreakpoint.c: Update.
6486         * python/py-frame.c: Update.
6487         * python/py-framefilter.c: Update.
6488         * python/py-gdb-readline.c: Update.
6489         * python/py-inferior.c: Update.
6490         * python/py-infthread.c: Update.
6491         * python/py-lazy-string.c: Update.
6492         * python/py-linetable.c: Update.
6493         * python/py-objfile.c: Update.
6494         * python/py-param.c: Update.
6495         * python/py-prettyprint.c: Update.
6496         * python/py-progspace.c: Update.
6497         * python/py-record-btrace.c: Update.
6498         * python/py-record.c: Update.
6499         * python/py-symbol.c: Update.
6500         * python/py-type.c: Update.
6501         * python/py-unwind.c: Update.
6502         * python/py-utils.c: Update.
6503         * python/py-value.c: Update.
6504         * python/python.c: Update.
6505         * record-btrace.c: Update.
6506         * record-full.c: Update.
6507         * remote-fileio.c: Update.
6508         * remote.c: Update.
6509         * riscv-tdep.c: Update.
6510         * rs6000-aix-tdep.c: Update.
6511         * rs6000-tdep.c: Update.
6512         * rust-exp.y: Update.
6513         * rust-lang.c: Update.
6514         * s390-tdep.c: Update.
6515         * selftest-arch.c: Update.
6516         * solib-dsbt.c: Update.
6517         * solib-frv.c: Update.
6518         * solib-spu.c: Update.
6519         * solib-svr4.c: Update.
6520         * solib.c: Update.
6521         * sparc64-linux-tdep.c: Update.
6522         * stack.c: Update.
6523         * symfile-mem.c: Update.
6524         * symmisc.c: Update.
6525         * target.c: Update.
6526         * thread.c: Update.
6527         * top.c: Update.
6528         * tracefile-tfile.c: Update.
6529         * tui/tui.c: Update.
6530         * typeprint.c: Update.
6531         * unittests/cli-utils-selftests.c: Update.
6532         * unittests/parse-connection-spec-selftests.c: Update.
6533         * valops.c: Update.
6534         * valprint.c: Update.
6535         * value.c: Update.
6536         * varobj.c: Update.
6537         * windows-nat.c: Update.
6538         * x86-linux-nat.c: Update.
6539         * xml-support.c: Update.
6540
6541 2019-04-08  Tom Tromey  <tom@tromey.com>
6542
6543         * xml-support.c: Use C++ exception handling.
6544         * x86-linux-nat.c: Use C++ exception handling.
6545         * windows-nat.c: Use C++ exception handling.
6546         * varobj.c: Use C++ exception handling.
6547         * value.c: Use C++ exception handling.
6548         * valprint.c: Use C++ exception handling.
6549         * valops.c: Use C++ exception handling.
6550         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6551         handling.
6552         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6553         * typeprint.c: Use C++ exception handling.
6554         * tui/tui.c: Use C++ exception handling.
6555         * tracefile-tfile.c: Use C++ exception handling.
6556         * top.c: Use C++ exception handling.
6557         * thread.c: Use C++ exception handling.
6558         * target.c: Use C++ exception handling.
6559         * symmisc.c: Use C++ exception handling.
6560         * symfile-mem.c: Use C++ exception handling.
6561         * stack.c: Use C++ exception handling.
6562         * sparc64-linux-tdep.c: Use C++ exception handling.
6563         * solib.c: Use C++ exception handling.
6564         * solib-svr4.c: Use C++ exception handling.
6565         * solib-spu.c: Use C++ exception handling.
6566         * solib-frv.c: Use C++ exception handling.
6567         * solib-dsbt.c: Use C++ exception handling.
6568         * selftest-arch.c: Use C++ exception handling.
6569         * s390-tdep.c: Use C++ exception handling.
6570         * rust-lang.c: Use C++ exception handling.
6571         * rust-exp.y: Use C++ exception handling.
6572         * rs6000-tdep.c: Use C++ exception handling.
6573         * rs6000-aix-tdep.c: Use C++ exception handling.
6574         * riscv-tdep.c: Use C++ exception handling.
6575         * remote.c: Use C++ exception handling.
6576         * remote-fileio.c: Use C++ exception handling.
6577         * record-full.c: Use C++ exception handling.
6578         * record-btrace.c: Use C++ exception handling.
6579         * python/python.c: Use C++ exception handling.
6580         * python/py-value.c: Use C++ exception handling.
6581         * python/py-utils.c: Use C++ exception handling.
6582         * python/py-unwind.c: Use C++ exception handling.
6583         * python/py-type.c: Use C++ exception handling.
6584         * python/py-symbol.c: Use C++ exception handling.
6585         * python/py-record.c: Use C++ exception handling.
6586         * python/py-record-btrace.c: Use C++ exception handling.
6587         * python/py-progspace.c: Use C++ exception handling.
6588         * python/py-prettyprint.c: Use C++ exception handling.
6589         * python/py-param.c: Use C++ exception handling.
6590         * python/py-objfile.c: Use C++ exception handling.
6591         * python/py-linetable.c: Use C++ exception handling.
6592         * python/py-lazy-string.c: Use C++ exception handling.
6593         * python/py-infthread.c: Use C++ exception handling.
6594         * python/py-inferior.c: Use C++ exception handling.
6595         * python/py-gdb-readline.c: Use C++ exception handling.
6596         * python/py-framefilter.c: Use C++ exception handling.
6597         * python/py-frame.c: Use C++ exception handling.
6598         * python/py-finishbreakpoint.c: Use C++ exception handling.
6599         * python/py-cmd.c: Use C++ exception handling.
6600         * python/py-breakpoint.c: Use C++ exception handling.
6601         * python/py-arch.c: Use C++ exception handling.
6602         * printcmd.c: Use C++ exception handling.
6603         * ppc-linux-tdep.c: Use C++ exception handling.
6604         * parse.c: Use C++ exception handling.
6605         * p-valprint.c: Use C++ exception handling.
6606         * objc-lang.c: Use C++ exception handling.
6607         * mi/mi-main.c: Use C++ exception handling.
6608         * mi/mi-interp.c: Use C++ exception handling.
6609         * mi/mi-cmd-stack.c: Use C++ exception handling.
6610         * mi/mi-cmd-break.c: Use C++ exception handling.
6611         * main.c: Use C++ exception handling.
6612         * linux-thread-db.c: Use C++ exception handling.
6613         * linux-tdep.c: Use C++ exception handling.
6614         * linux-nat.c: Use C++ exception handling.
6615         * linux-fork.c: Use C++ exception handling.
6616         * linespec.c: Use C++ exception handling.
6617         * language.c: Use C++ exception handling.
6618         * jit.c: Use C++ exception handling.
6619         * infrun.c: Use C++ exception handling.
6620         * infcmd.c: Use C++ exception handling.
6621         * infcall.c: Use C++ exception handling.
6622         * inf-loop.c: Use C++ exception handling.
6623         * i386-tdep.c: Use C++ exception handling.
6624         * i386-linux-tdep.c: Use C++ exception handling.
6625         * guile/scm-value.c: Use C++ exception handling.
6626         * guile/scm-type.c: Use C++ exception handling.
6627         * guile/scm-symtab.c: Use C++ exception handling.
6628         * guile/scm-symbol.c: Use C++ exception handling.
6629         * guile/scm-pretty-print.c: Use C++ exception handling.
6630         * guile/scm-ports.c: Use C++ exception handling.
6631         * guile/scm-param.c: Use C++ exception handling.
6632         * guile/scm-math.c: Use C++ exception handling.
6633         * guile/scm-lazy-string.c: Use C++ exception handling.
6634         * guile/scm-frame.c: Use C++ exception handling.
6635         * guile/scm-disasm.c: Use C++ exception handling.
6636         * guile/scm-cmd.c: Use C++ exception handling.
6637         * guile/scm-breakpoint.c: Use C++ exception handling.
6638         * guile/scm-block.c: Use C++ exception handling.
6639         * guile/guile-internal.h: Use C++ exception handling.
6640         * gnu-v3-abi.c: Use C++ exception handling.
6641         * gdbtypes.c: Use C++ exception handling.
6642         * frame.c: Use C++ exception handling.
6643         * frame-unwind.c: Use C++ exception handling.
6644         * fbsd-tdep.c: Use C++ exception handling.
6645         * f-valprint.c: Use C++ exception handling.
6646         * exec.c: Use C++ exception handling.
6647         * event-top.c: Use C++ exception handling.
6648         * event-loop.c: Use C++ exception handling.
6649         * eval.c: Use C++ exception handling.
6650         * dwarf2read.c: Use C++ exception handling.
6651         * dwarf2loc.c: Use C++ exception handling.
6652         * dwarf2-frame.c: Use C++ exception handling.
6653         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6654         * dwarf-index-write.c: Use C++ exception handling.
6655         * dwarf-index-cache.c: Use C++ exception handling.
6656         * dtrace-probe.c: Use C++ exception handling.
6657         * disasm-selftests.c: Use C++ exception handling.
6658         * darwin-nat.c: Use C++ exception handling.
6659         * cp-valprint.c: Use C++ exception handling.
6660         * cp-support.c: Use C++ exception handling.
6661         * cp-abi.c: Use C++ exception handling.
6662         * corelow.c: Use C++ exception handling.
6663         * completer.c: Use C++ exception handling.
6664         * compile/compile-object-run.c: Use C++ exception handling.
6665         * compile/compile-object-load.c: Use C++ exception handling.
6666         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6667         * compile/compile-c-symbols.c: Use C++ exception handling.
6668         * common/selftest.c: Use C++ exception handling.
6669         * common/new-op.c: Use C++ exception handling.
6670         * cli/cli-script.c: Use C++ exception handling.
6671         * cli/cli-interp.c: Use C++ exception handling.
6672         * cli/cli-cmds.c: Use C++ exception handling.
6673         * c-varobj.c: Use C++ exception handling.
6674         * btrace.c: Use C++ exception handling.
6675         * breakpoint.c: Use C++ exception handling.
6676         * break-catch-throw.c: Use C++ exception handling.
6677         * arch-utils.c: Use C++ exception handling.
6678         * amd64-tdep.c: Use C++ exception handling.
6679         * ada-valprint.c: Use C++ exception handling.
6680         * ada-typeprint.c: Use C++ exception handling.
6681         * ada-lang.c: Use C++ exception handling.
6682         * aarch64-tdep.c: Use C++ exception handling.
6683
6684 2019-04-08  Tom Tromey  <tom@tromey.com>
6685
6686         * xml-support.c (gdb_xml_parser::parse): Update.
6687         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6688         * value.c (show_convenience): Update.
6689         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6690         (test_parse_flags_qcs): Update.
6691         * thread.c (thr_try_catch_cmd): Update.
6692         * target.c (target_translate_tls_address): Update.
6693         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6694         (info_frame_command_core, frame_apply_command_count): Update.
6695         * rust-exp.y (rust_lex_exception_test): Update.
6696         * riscv-tdep.c (riscv_print_one_register_info): Update.
6697         * remote.c (remote_target::enable_btrace): Update.
6698         * record-btrace.c (record_btrace_enable_warn): Update.
6699         * python/py-utils.c (gdbpy_convert_exception): Update.
6700         * printcmd.c (do_one_display, print_variable_and_value): Update.
6701         * mi/mi-main.c (mi_print_exception): Update.
6702         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6703         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6704         * linux-nat.c (linux_nat_target::attach): Update.
6705         * linux-fork.c (class scoped_switch_fork_info): Update.
6706         * infrun.c (displaced_step_prepare): Update.
6707         * infcall.c (call_function_by_hand_dummy): Update.
6708         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6709         * gnu-v3-abi.c (print_one_vtable): Update.
6710         * frame.c (get_prev_frame_always): Update.
6711         * f-valprint.c (info_common_command_for_block): Update.
6712         * exec.c (try_open_exec_file): Update.
6713         * exceptions.c (print_exception, exception_print)
6714         (exception_fprintf, exception_print_same): Update.
6715         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6716         * dwarf-index-cache.c (index_cache::store)
6717         (index_cache::lookup_gdb_index): Update.
6718         * darwin-nat.c (maybe_cache_shell): Update.
6719         * cp-valprint.c (cp_print_value_fields): Update.
6720         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6721         (gcc_cplus_symbol_address): Update.
6722         * compile/compile-c-symbols.c (gcc_convert_symbol)
6723         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6724         * common/selftest.c: Update.
6725         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6726         a std::string.
6727         (exception_try_scope_entry, exception_try_scope_exit): Don't
6728         declare.
6729         (struct exception_try_scope): Remove.
6730         (TRY): Don't use exception_try_scope.
6731         (struct gdb_exception): Add constructor, operator=.
6732         <what>: New method.
6733         (struct gdb_exception_RETURN_MASK_ALL)
6734         (struct gdb_exception_RETURN_MASK_ERROR)
6735         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6736         (struct gdb_quit_bad_alloc): Update.
6737         * common/common-exceptions.c (exception_none): Change
6738         initializer.
6739         (struct catcher) <state, exception>: Initialize inline.
6740         <prev>: Remove member.
6741         (current_catcher): Remove.
6742         (catchers): New global.
6743         (exceptions_state_mc_init): Simplify.
6744         (catcher_pop): Remove.
6745         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6746         (try_scope_depth, exception_try_scope_entry)
6747         (exception_try_scope_exit): Remove.
6748         (throw_exception_sjlj): Update.
6749         (exception_messages, exception_messages_size): Remove.
6750         (throw_it): Simplify.
6751         (gdb_exception_sliced_copy): Remove.
6752         (throw_exception_cxx): Update.
6753         * cli/cli-script.c (script_from_file): Update.
6754         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6755         Update.
6756         * ada-valprint.c (ada_val_print): Update.
6757         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6758         (create_excep_cond_exprs): Update.
6759
6760 2019-04-08  Tom Tromey  <tom@tromey.com>
6761
6762         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6763         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6764         (TRY, CATCH, END_CATCH): Remove some definitions.
6765         * common/common-exceptions.c: Don't use GDB_XCPT.
6766         (catcher_list_size): Remove.
6767         (throw_exception, throw_it): Simplify.
6768
6769 2019-04-05  Tom Tromey  <tom@tromey.com>
6770
6771         Revert the header-sorting patch.
6772         * ft32-tdep.c: Revert.
6773         * frv-tdep.c: Revert.
6774         * frv-linux-tdep.c: Revert.
6775         * frame.c: Revert.
6776         * frame-unwind.c: Revert.
6777         * frame-base.c: Revert.
6778         * fork-child.c: Revert.
6779         * findvar.c: Revert.
6780         * findcmd.c: Revert.
6781         * filesystem.c: Revert.
6782         * filename-seen-cache.h: Revert.
6783         * filename-seen-cache.c: Revert.
6784         * fbsd-tdep.c: Revert.
6785         * fbsd-nat.h: Revert.
6786         * fbsd-nat.c: Revert.
6787         * f-valprint.c: Revert.
6788         * f-typeprint.c: Revert.
6789         * f-lang.c: Revert.
6790         * extension.h: Revert.
6791         * extension.c: Revert.
6792         * extension-priv.h: Revert.
6793         * expprint.c: Revert.
6794         * exec.h: Revert.
6795         * exec.c: Revert.
6796         * exceptions.c: Revert.
6797         * event-top.c: Revert.
6798         * event-loop.c: Revert.
6799         * eval.c: Revert.
6800         * elfread.c: Revert.
6801         * dwarf2read.h: Revert.
6802         * dwarf2read.c: Revert.
6803         * dwarf2loc.c: Revert.
6804         * dwarf2expr.h: Revert.
6805         * dwarf2expr.c: Revert.
6806         * dwarf2-frame.c: Revert.
6807         * dwarf2-frame-tailcall.c: Revert.
6808         * dwarf-index-write.h: Revert.
6809         * dwarf-index-write.c: Revert.
6810         * dwarf-index-common.c: Revert.
6811         * dwarf-index-cache.h: Revert.
6812         * dwarf-index-cache.c: Revert.
6813         * dummy-frame.c: Revert.
6814         * dtrace-probe.c: Revert.
6815         * disasm.h: Revert.
6816         * disasm.c: Revert.
6817         * disasm-selftests.c: Revert.
6818         * dictionary.c: Revert.
6819         * dicos-tdep.c: Revert.
6820         * demangle.c: Revert.
6821         * dcache.h: Revert.
6822         * dcache.c: Revert.
6823         * darwin-nat.h: Revert.
6824         * darwin-nat.c: Revert.
6825         * darwin-nat-info.c: Revert.
6826         * d-valprint.c: Revert.
6827         * d-namespace.c: Revert.
6828         * d-lang.c: Revert.
6829         * ctf.c: Revert.
6830         * csky-tdep.c: Revert.
6831         * csky-linux-tdep.c: Revert.
6832         * cris-tdep.c: Revert.
6833         * cris-linux-tdep.c: Revert.
6834         * cp-valprint.c: Revert.
6835         * cp-support.c: Revert.
6836         * cp-namespace.c: Revert.
6837         * cp-abi.c: Revert.
6838         * corelow.c: Revert.
6839         * corefile.c: Revert.
6840         * continuations.c: Revert.
6841         * completer.h: Revert.
6842         * completer.c: Revert.
6843         * complaints.c: Revert.
6844         * coffread.c: Revert.
6845         * coff-pe-read.c: Revert.
6846         * cli-out.h: Revert.
6847         * cli-out.c: Revert.
6848         * charset.c: Revert.
6849         * c-varobj.c: Revert.
6850         * c-valprint.c: Revert.
6851         * c-typeprint.c: Revert.
6852         * c-lang.c: Revert.
6853         * buildsym.c: Revert.
6854         * buildsym-legacy.c: Revert.
6855         * build-id.h: Revert.
6856         * build-id.c: Revert.
6857         * btrace.c: Revert.
6858         * bsd-uthread.c: Revert.
6859         * breakpoint.h: Revert.
6860         * breakpoint.c: Revert.
6861         * break-catch-throw.c: Revert.
6862         * break-catch-syscall.c: Revert.
6863         * break-catch-sig.c: Revert.
6864         * blockframe.c: Revert.
6865         * block.c: Revert.
6866         * bfin-tdep.c: Revert.
6867         * bfin-linux-tdep.c: Revert.
6868         * bfd-target.c: Revert.
6869         * bcache.c: Revert.
6870         * ax-general.c: Revert.
6871         * ax-gdb.h: Revert.
6872         * ax-gdb.c: Revert.
6873         * avr-tdep.c: Revert.
6874         * auxv.c: Revert.
6875         * auto-load.c: Revert.
6876         * arm-wince-tdep.c: Revert.
6877         * arm-tdep.c: Revert.
6878         * arm-symbian-tdep.c: Revert.
6879         * arm-pikeos-tdep.c: Revert.
6880         * arm-obsd-tdep.c: Revert.
6881         * arm-nbsd-tdep.c: Revert.
6882         * arm-nbsd-nat.c: Revert.
6883         * arm-linux-tdep.c: Revert.
6884         * arm-linux-nat.c: Revert.
6885         * arm-fbsd-tdep.c: Revert.
6886         * arm-fbsd-nat.c: Revert.
6887         * arm-bsd-tdep.c: Revert.
6888         * arch-utils.c: Revert.
6889         * arc-tdep.c: Revert.
6890         * arc-newlib-tdep.c: Revert.
6891         * annotate.h: Revert.
6892         * annotate.c: Revert.
6893         * amd64-windows-tdep.c: Revert.
6894         * amd64-windows-nat.c: Revert.
6895         * amd64-tdep.c: Revert.
6896         * amd64-sol2-tdep.c: Revert.
6897         * amd64-obsd-tdep.c: Revert.
6898         * amd64-obsd-nat.c: Revert.
6899         * amd64-nbsd-tdep.c: Revert.
6900         * amd64-nbsd-nat.c: Revert.
6901         * amd64-nat.c: Revert.
6902         * amd64-linux-tdep.c: Revert.
6903         * amd64-linux-nat.c: Revert.
6904         * amd64-fbsd-tdep.c: Revert.
6905         * amd64-fbsd-nat.c: Revert.
6906         * amd64-dicos-tdep.c: Revert.
6907         * amd64-darwin-tdep.c: Revert.
6908         * amd64-bsd-nat.c: Revert.
6909         * alpha-tdep.c: Revert.
6910         * alpha-obsd-tdep.c: Revert.
6911         * alpha-nbsd-tdep.c: Revert.
6912         * alpha-mdebug-tdep.c: Revert.
6913         * alpha-linux-tdep.c: Revert.
6914         * alpha-linux-nat.c: Revert.
6915         * alpha-bsd-tdep.c: Revert.
6916         * alpha-bsd-nat.c: Revert.
6917         * aix-thread.c: Revert.
6918         * agent.c: Revert.
6919         * addrmap.c: Revert.
6920         * ada-varobj.c: Revert.
6921         * ada-valprint.c: Revert.
6922         * ada-typeprint.c: Revert.
6923         * ada-tasks.c: Revert.
6924         * ada-lang.c: Revert.
6925         * aarch64-tdep.c: Revert.
6926         * aarch64-ravenscar-thread.c: Revert.
6927         * aarch64-newlib-tdep.c: Revert.
6928         * aarch64-linux-tdep.c: Revert.
6929         * aarch64-linux-nat.c: Revert.
6930         * aarch64-fbsd-tdep.c: Revert.
6931         * aarch64-fbsd-nat.c: Revert.
6932         * aarch32-linux-nat.c: Revert.
6933
6934 2019-04-05  Tom Tromey  <tom@tromey.com>
6935
6936         * ft32-tdep.c: Sort headers.
6937         * frv-tdep.c: Sort headers.
6938         * frv-linux-tdep.c: Sort headers.
6939         * frame.c: Sort headers.
6940         * frame-unwind.c: Sort headers.
6941         * frame-base.c: Sort headers.
6942         * fork-child.c: Sort headers.
6943         * findvar.c: Sort headers.
6944         * findcmd.c: Sort headers.
6945         * filesystem.c: Sort headers.
6946         * filename-seen-cache.h: Sort headers.
6947         * filename-seen-cache.c: Sort headers.
6948         * fbsd-tdep.c: Sort headers.
6949         * fbsd-nat.h: Sort headers.
6950         * fbsd-nat.c: Sort headers.
6951         * f-valprint.c: Sort headers.
6952         * f-typeprint.c: Sort headers.
6953         * f-lang.c: Sort headers.
6954         * extension.h: Sort headers.
6955         * extension.c: Sort headers.
6956         * extension-priv.h: Sort headers.
6957         * expprint.c: Sort headers.
6958         * exec.h: Sort headers.
6959         * exec.c: Sort headers.
6960         * exceptions.c: Sort headers.
6961         * event-top.c: Sort headers.
6962         * event-loop.c: Sort headers.
6963         * eval.c: Sort headers.
6964         * elfread.c: Sort headers.
6965         * dwarf2read.h: Sort headers.
6966         * dwarf2read.c: Sort headers.
6967         * dwarf2loc.c: Sort headers.
6968         * dwarf2expr.h: Sort headers.
6969         * dwarf2expr.c: Sort headers.
6970         * dwarf2-frame.c: Sort headers.
6971         * dwarf2-frame-tailcall.c: Sort headers.
6972         * dwarf-index-write.h: Sort headers.
6973         * dwarf-index-write.c: Sort headers.
6974         * dwarf-index-common.c: Sort headers.
6975         * dwarf-index-cache.h: Sort headers.
6976         * dwarf-index-cache.c: Sort headers.
6977         * dummy-frame.c: Sort headers.
6978         * dtrace-probe.c: Sort headers.
6979         * disasm.h: Sort headers.
6980         * disasm.c: Sort headers.
6981         * disasm-selftests.c: Sort headers.
6982         * dictionary.c: Sort headers.
6983         * dicos-tdep.c: Sort headers.
6984         * demangle.c: Sort headers.
6985         * dcache.h: Sort headers.
6986         * dcache.c: Sort headers.
6987         * darwin-nat.h: Sort headers.
6988         * darwin-nat.c: Sort headers.
6989         * darwin-nat-info.c: Sort headers.
6990         * d-valprint.c: Sort headers.
6991         * d-namespace.c: Sort headers.
6992         * d-lang.c: Sort headers.
6993         * ctf.c: Sort headers.
6994         * csky-tdep.c: Sort headers.
6995         * csky-linux-tdep.c: Sort headers.
6996         * cris-tdep.c: Sort headers.
6997         * cris-linux-tdep.c: Sort headers.
6998         * cp-valprint.c: Sort headers.
6999         * cp-support.c: Sort headers.
7000         * cp-namespace.c: Sort headers.
7001         * cp-abi.c: Sort headers.
7002         * corelow.c: Sort headers.
7003         * corefile.c: Sort headers.
7004         * continuations.c: Sort headers.
7005         * completer.h: Sort headers.
7006         * completer.c: Sort headers.
7007         * complaints.c: Sort headers.
7008         * coffread.c: Sort headers.
7009         * coff-pe-read.c: Sort headers.
7010         * cli-out.h: Sort headers.
7011         * cli-out.c: Sort headers.
7012         * charset.c: Sort headers.
7013         * c-varobj.c: Sort headers.
7014         * c-valprint.c: Sort headers.
7015         * c-typeprint.c: Sort headers.
7016         * c-lang.c: Sort headers.
7017         * buildsym.c: Sort headers.
7018         * buildsym-legacy.c: Sort headers.
7019         * build-id.h: Sort headers.
7020         * build-id.c: Sort headers.
7021         * btrace.c: Sort headers.
7022         * bsd-uthread.c: Sort headers.
7023         * breakpoint.h: Sort headers.
7024         * breakpoint.c: Sort headers.
7025         * break-catch-throw.c: Sort headers.
7026         * break-catch-syscall.c: Sort headers.
7027         * break-catch-sig.c: Sort headers.
7028         * blockframe.c: Sort headers.
7029         * block.c: Sort headers.
7030         * bfin-tdep.c: Sort headers.
7031         * bfin-linux-tdep.c: Sort headers.
7032         * bfd-target.c: Sort headers.
7033         * bcache.c: Sort headers.
7034         * ax-general.c: Sort headers.
7035         * ax-gdb.h: Sort headers.
7036         * ax-gdb.c: Sort headers.
7037         * avr-tdep.c: Sort headers.
7038         * auxv.c: Sort headers.
7039         * auto-load.c: Sort headers.
7040         * arm-wince-tdep.c: Sort headers.
7041         * arm-tdep.c: Sort headers.
7042         * arm-symbian-tdep.c: Sort headers.
7043         * arm-pikeos-tdep.c: Sort headers.
7044         * arm-obsd-tdep.c: Sort headers.
7045         * arm-nbsd-tdep.c: Sort headers.
7046         * arm-nbsd-nat.c: Sort headers.
7047         * arm-linux-tdep.c: Sort headers.
7048         * arm-linux-nat.c: Sort headers.
7049         * arm-fbsd-tdep.c: Sort headers.
7050         * arm-fbsd-nat.c: Sort headers.
7051         * arm-bsd-tdep.c: Sort headers.
7052         * arch-utils.c: Sort headers.
7053         * arc-tdep.c: Sort headers.
7054         * arc-newlib-tdep.c: Sort headers.
7055         * annotate.h: Sort headers.
7056         * annotate.c: Sort headers.
7057         * amd64-windows-tdep.c: Sort headers.
7058         * amd64-windows-nat.c: Sort headers.
7059         * amd64-tdep.c: Sort headers.
7060         * amd64-sol2-tdep.c: Sort headers.
7061         * amd64-obsd-tdep.c: Sort headers.
7062         * amd64-obsd-nat.c: Sort headers.
7063         * amd64-nbsd-tdep.c: Sort headers.
7064         * amd64-nbsd-nat.c: Sort headers.
7065         * amd64-nat.c: Sort headers.
7066         * amd64-linux-tdep.c: Sort headers.
7067         * amd64-linux-nat.c: Sort headers.
7068         * amd64-fbsd-tdep.c: Sort headers.
7069         * amd64-fbsd-nat.c: Sort headers.
7070         * amd64-dicos-tdep.c: Sort headers.
7071         * amd64-darwin-tdep.c: Sort headers.
7072         * amd64-bsd-nat.c: Sort headers.
7073         * alpha-tdep.c: Sort headers.
7074         * alpha-obsd-tdep.c: Sort headers.
7075         * alpha-nbsd-tdep.c: Sort headers.
7076         * alpha-mdebug-tdep.c: Sort headers.
7077         * alpha-linux-tdep.c: Sort headers.
7078         * alpha-linux-nat.c: Sort headers.
7079         * alpha-bsd-tdep.c: Sort headers.
7080         * alpha-bsd-nat.c: Sort headers.
7081         * aix-thread.c: Sort headers.
7082         * agent.c: Sort headers.
7083         * addrmap.c: Sort headers.
7084         * ada-varobj.c: Sort headers.
7085         * ada-valprint.c: Sort headers.
7086         * ada-typeprint.c: Sort headers.
7087         * ada-tasks.c: Sort headers.
7088         * ada-lang.c: Sort headers.
7089         * aarch64-tdep.c: Sort headers.
7090         * aarch64-ravenscar-thread.c: Sort headers.
7091         * aarch64-newlib-tdep.c: Sort headers.
7092         * aarch64-linux-tdep.c: Sort headers.
7093         * aarch64-linux-nat.c: Sort headers.
7094         * aarch64-fbsd-tdep.c: Sort headers.
7095         * aarch64-fbsd-nat.c: Sort headers.
7096         * aarch32-linux-nat.c: Sort headers.
7097
7098 2019-04-04  Tom Tromey  <tom@tromey.com>
7099
7100         * varobj.c (varobj_create): Update.
7101         * rust-exp.y (struct rust_parser) <update_innermost_block,
7102         lookup_symbol>: New methods.
7103         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7104         Rename.
7105         (rust_parser::rust_lookup_type)
7106         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7107         * printcmd.c (display_command, do_one_display): Update.
7108         * parser-defs.h (struct parser_state) <parser_state>: Add
7109         "tracker" parameter.
7110         (block_tracker): New member.
7111         (class innermost_block_tracker) <innermost_block_tracker>: Add
7112         "types" parameter.
7113         <reset>: Remove method.
7114         (innermost_block): Don't declare.
7115         (null_post_parser): Update.
7116         * parse.c (innermost_block): Remove global.
7117         (write_dollar_variable): Update.
7118         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7119         Remove "tracker_types" parameter.
7120         (parse_expression): Add "tracker" parameter.
7121         (parse_expression_for_completion): Update.
7122         (null_post_parser): Add "tracker" parameter.
7123         * p-exp.y: Update rules.
7124         * m2-exp.y: Update rules.
7125         * language.h (struct language_defn) <la_post_parser>: Add
7126         "tracker" parameter.
7127         * go-exp.y: Update rules.
7128         * f-exp.y: Update rules.
7129         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7130         parameter.
7131         * d-exp.y: Update rules.
7132         * c-exp.y: Update rules.
7133         * breakpoint.c (set_breakpoint_condition): Create an
7134         innermost_block_tracker.
7135         (watch_command_1): Likewise.
7136         * ada-lang.c (resolve): Add "tracker" parameter.
7137         (resolve_subexp): Likewise.
7138         * ada-exp.y (write_var_from_sym): Update.
7139
7140 2019-04-04  Tom Tromey  <tom@tromey.com>
7141
7142         * type-stack.h: New file.
7143         * type-stack.c: New file.
7144         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7145         type-stack.h.
7146         (insert_into_type_stack, insert_type, push_type, push_type_int)
7147         (insert_type_address_space, pop_type, pop_type_int)
7148         (pop_typelist, pop_type_stack, append_type_stack)
7149         (push_type_stack, get_type_stack, push_typelist)
7150         (follow_type_instance_flags, follow_types): Don't declare.
7151         * parse.c (type_stack): Remove global.
7152         (parse_exp_in_context): Update.
7153         (insert_into_type_stack, insert_type, push_type, push_type_int)
7154         (insert_type_address_space, pop_type, pop_type_int)
7155         (pop_typelist, pop_type_stack, append_type_stack)
7156         (push_type_stack, get_type_stack, push_typelist)
7157         (follow_type_instance_flags, follow_types): Remove (moved to
7158         type-stack.c).
7159         * f-exp.y (type_stack): New global.
7160         Update rules.
7161         (push_kind_type, f_parse): Update.
7162         * d-exp.y (type_stack): New global.
7163         Update rules.
7164         (d_parse): Update.
7165         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7166         Update rules.
7167         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7168         (HFILES_NO_SRCDIR): Add type-stack.h.
7169
7170 2019-04-04  Tom Tromey  <tom@tromey.com>
7171
7172         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7173         (rust_parser::convert_ast_to_expression, rust_parse)
7174         (rust_lex_test_completion, rust_lex_tests): Update.
7175         * parser-defs.h (struct expr_completion_state): New.
7176         (struct parser_state) <parser_state>: Add completion parameter.
7177         <mark_struct_expression, mark_completion_tag>: New methods.
7178         <parse_completion, m_completion_state>: New members.
7179         (prefixify_expression, null_post_parser): Update.
7180         (mark_struct_expression, mark_completion_tag): Don't declare.
7181         * parse.c (parse_completion, expout_last_struct)
7182         (expout_tag_completion_type, expout_completion_name): Remove
7183         globals.
7184         (parser_state::mark_struct_expression)
7185         (parser_state::mark_completion_tag): Now methods.
7186         (prefixify_expression): Add last_struct parameter.
7187         (prefixify_subexp): Likewise.
7188         (parse_exp_1): Update.
7189         (parse_exp_in_context): Add cstate parameter.  Update.
7190         (parse_expression_for_completion): Create an
7191         expr_completion_state.
7192         (null_post_parser): Add "completion" parameter.
7193         * p-exp.y: Update rules.
7194         (yylex): Update.
7195         * language.h (struct language_defn) <la_post_parser>: Add
7196         "completing" parameter.
7197         * go-exp.y: Update rules.
7198         (lex_one_token): Update.
7199         * expression.h (parse_completion): Don't declare.
7200         * d-exp.y: Update rules.
7201         (lex_one_token): Update rules.
7202         * c-exp.y: Update rules.
7203         (lex_one_token): Update.
7204         * ada-lang.c (resolve): Add "parse_completion" parameter.
7205         (resolve_subexp): Likewise.
7206         (ada_resolve_function): Likewise.
7207
7208 2019-04-04  Tom Tromey  <tom@tromey.com>
7209
7210         * parser-defs.h (struct parser_state) <start_arglist,
7211         end_arglist>: New methods.
7212         <arglist_len, m_funcall_chain>: New members.
7213         (arglist_len, start_arglist, end_arglist): Don't declare.
7214         * parse.c (arglist_len, funcall_chain): Remove global.
7215         (start_arglist, end_arglist): Remove functions.
7216         (parse_exp_in_context): Update.
7217         * p-exp.y: Update rules.
7218         * m2-exp.y: Update rules.
7219         * go-exp.y: Update rules.
7220         * f-exp.y: Update rules.
7221         * d-exp.y: Update rules.
7222         * c-exp.y: Update rules.
7223
7224 2019-04-04  Tom Tromey  <tom@tromey.com>
7225
7226         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7227         lex_operator, push_back>: New methods.
7228         Update all rules.
7229         (rust_parser::lex_hex, lex_escape): Rename and update.
7230         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7231         (rust_parser::lex_operator): Rename and update.
7232         (rust_parser::lex_number, rustyylex, rustyyerror)
7233         (rust_lex_test_init, rust_lex_test_sequence)
7234         (rust_lex_test_push_back, rust_lex_tests): Update.
7235         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7236         parameter.
7237         <lexptr, prev_lexptr>: New members.
7238         (lexptr, prev_lexptr): Don't declare.
7239         * parse.c (lexptr, prev_lexptr): Remove globals.
7240         (parse_exp_in_context): Update.
7241         * p-exp.y (yylex, yyerror): Update.
7242         * m2-exp.y (parse_number, yylex, yyerror): Update.
7243         * go-exp.y (lex_one_token, yyerror): Update.
7244         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7245         * d-exp.y (lex_one_token, yyerror): Update.
7246         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7247         (lex_one_token, yyerror): Update.
7248         * ada-lex.l (YY_INPUT): Update.
7249         (rewind_to_char): Update.
7250         * ada-exp.y (yyerror): Update.
7251
7252 2019-04-04  Tom Tromey  <tom@tromey.com>
7253
7254         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7255         * parser-defs.h (struct parser_state) <parser_state>: Add new
7256         parameter.
7257         <comma_terminates>: New member.
7258         (comma_terminates): Don't declare global.
7259         * parse.c (comma_terminates): Remove global.
7260         (parse_exp_in_context): Update.
7261         * p-exp.y (yylex): Update.
7262         * m2-exp.y (yylex): Update.
7263         * go-exp.y (lex_one_token): Update.
7264         * f-exp.y (yylex): Update.
7265         * d-exp.y (lex_one_token): Update.
7266         * c-exp.y (lex_one_token): Update.
7267         * ada-lex.l: Update.
7268
7269 2019-04-04  Tom Tromey  <tom@tromey.com>
7270
7271         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7272         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7273         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7274         * parser-defs.h (paren_depth): Don't declare.
7275         * parse.c (paren_depth): Remove global.
7276         (parse_exp_in_context): Update.
7277         * p-exp.y (paren_depth): New global.
7278         (pascal_parse): Initialize it.
7279         * m2-exp.y (paren_depth): New global.
7280         (m2_parse): Initialize it.
7281         * go-exp.y (paren_depth): New global.
7282         (go_parse): Initialize it.
7283         * f-exp.y (paren_depth): New global.
7284         (f_parse): Initialize it.
7285         * d-exp.y (paren_depth): New global.
7286         (d_parse): Initialize it.
7287         * c-exp.y (paren_depth): New global.
7288         (c_parse): Initialize it.
7289         * ada-lex.l (paren_depth): New global.
7290         (lexer_init): Initialize it.
7291
7292 2019-04-04  Tom Tromey  <tom@tromey.com>
7293
7294         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7295         (rust_parser::convert_ast_to_type)
7296         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7297         * parser-defs.h (struct parser_state) <parser_state>: Add
7298         parameters.  Initialize new members.
7299         <expression_context_block, expression_context_pc>: New members.
7300         * parse.c (expression_context_block, expression_context_pc):
7301         Remove globals.
7302         (parse_exp_in_context): Update.
7303         * p-exp.y: Update all rules.
7304         (yylex): Update.
7305         * m2-exp.y: Update all rules.
7306         (yylex): Update.
7307         * go-exp.y (yylex): Update.
7308         * f-exp.y (yylex): Update.
7309         * d-exp.y: Update all rules.
7310         (yylex): Update.
7311         * c-exp.y: Update all rules.
7312         (lex_one_token, classify_name, yylex, c_parse): Update.
7313         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7314
7315 2019-04-04  Tom Tromey  <tom@tromey.com>
7316
7317         * gdbarch.h, gdbarch.c: Rebuild.
7318         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7319         * stap-probe.h:
7320         (struct stap_parse_info): Replace "parser_state" with
7321         "expr_builder".
7322         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7323         (parser_state): New class.
7324         * parse.c (expr_builder): Rename.
7325         (expr_builder::release): Rename.
7326         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7327         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7328         (write_exp_elt_longcst, write_exp_elt_floatcst)
7329         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7330         (write_exp_string_vector, write_exp_bitstring)
7331         (write_exp_msymbol, mark_struct_expression)
7332         (write_dollar_variable)
7333         (insert_type_address_space, increase_expout_size): Replace
7334         "parser_state" with "expr_builder".
7335         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7336         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7337         "parser_state" with "expr_builder".
7338
7339 2019-04-04  Tom Tromey  <tom@tromey.com>
7340
7341         * rust-exp.y: Replace "parse_language" with method call.
7342         * p-exp.y:
7343         (yylex): Replace "parse_language" with method call.
7344         * m2-exp.y:
7345         (yylex): Replace "parse_language" with method call.
7346         * go-exp.y (classify_name): Replace "parse_language" with method
7347         call.
7348         * f-exp.y (yylex): Replace "parse_language" with method call.
7349         * d-exp.y (lex_one_token): Replace "parse_language" with method
7350         call.
7351         * c-exp.y:
7352         (lex_one_token, classify_name, yylex): Replace "parse_language"
7353         with method call.
7354         * ada-exp.y (find_primitive_type, type_char)
7355         (type_system_address): Replace "parse_language" with method call.
7356
7357 2019-04-04  Tom Tromey  <tom@tromey.com>
7358
7359         * rust-exp.y: Replace "parse_gdbarch" with method call.
7360         * parse.c (write_dollar_variable, insert_type_address_space):
7361         Replace "parse_gdbarch" with method call.
7362         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7363         call.
7364         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7365         call.
7366         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7367         "parse_gdbarch" with method call.
7368         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7369         with method call.
7370         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7371         "parse_gdbarch" with method call.
7372         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7373         "parse_gdbarch" with method call.
7374         * c-exp.y (parse_type, parse_number, classify_name): Replace
7375         "parse_gdbarch" with method call.
7376         * ada-lex.l: Replace "parse_gdbarch" with method call.
7377         * ada-exp.y (parse_type, find_primitive_type, type_char)
7378         (type_system_address): Replace "parse_gdbarch" with method call.
7379
7380 2019-04-04  Tom Tromey  <tom@tromey.com>
7381
7382         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7383         * stap-probe.c (stap_parse_argument): Update.
7384         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7385         initial_size parameter.
7386         * rust-exp.y (rust_lex_tests): Update.
7387         * parse.c (parser_state): Update.
7388         (parse_exp_in_context): Update.
7389         * parser-defs.h (struct parser_state) <parser_state>: Remove
7390         "initial_size" parameter.
7391
7392 2019-04-04  Tom Tromey  <tom@tromey.com>
7393
7394         * parser-defs.h (increase_expout_size): Don't declare.
7395         * parse.c (increase_expout_size): Now static.
7396
7397 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7398
7399         * gnu-nat.c (gnu_nat_target::wait): Fix
7400         target_waitstatus_to_string call.
7401
7402 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7403
7404         * eval.c (evaluate_subexp_standard): Handle internal functions
7405         during Fortran function call handling.
7406
7407 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7408
7409         * NEWS: Mention new internal functions.
7410         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7411         (read_base_type): Use dwarf2_init_complex_target_type.
7412         * value.c (creal_internal_fn): New function.
7413         (cimag_internal_fn): New function.
7414         (_initialize_values): Register new internal functions.
7415
7416 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7417
7418         * infrun.c (stop_all_threads): If debug_infrun, always
7419         trace the wait status after wait_one, using
7420         target_waitstatus_to_string and target_pid_to_str.
7421         (handle_inferior_event): Replace various trace of
7422         wait status kind by a single trace.
7423         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7424         wait status kind image by target_waitstatus_to_string.
7425         * target/waitstatus.c (target_waitstatus_to_string): Fix
7426         obsolete comment.
7427
7428 2019-04-01  Tom Tromey  <tromey@adacore.com>
7429
7430         PR symtab/23331:
7431         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7432
7433 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7434             Pedro Alves  <palves@redhat.com>
7435
7436         * top.c (quit_force): Call 'finalize_values'.
7437         * value.c (finalize_values): New function.
7438         * value.h (finalize_values): Declare.
7439
7440 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7441
7442         * NEWS: Announce $_gdb_major and $_gdb_minor.
7443
7444         * top.c (init_gdb_version_vars): New function.
7445         (gdb_init): Call init_gdb_version_vars.
7446
7447 2019-03-29  Tom Tromey  <tromey@adacore.com>
7448
7449         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7450         help text.  Remove dead code.
7451
7452 2019-03-29  Keith Seitz  <keiths@redhat.com>
7453
7454         From Siddhesh Poyarekar:
7455         * f-lang.h (f77_get_upperbound): Return LONGEST.
7456         (f77_get_lowerbound): Likewise.
7457         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7458         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7459         print them.
7460         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7461         plongest to format print it.
7462         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7463         (f77_get_upperbound): Likewise.
7464         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7465         LOWER_BOUND to LONGEST.
7466         (f77_create_arrayprint_offset_tbl): Likewise.
7467
7468 2019-03-29  Keith Seitz  <keiths@redhat.com>
7469
7470         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7471         %s/pulongest for TYPE_LENGTH instead of %d in format
7472         strings.
7473         * ada-typerint.c (ada_print_type): Likewise.
7474         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7475         * compile/compile-c-support.c (generate_register_struct): Likewise.
7476         * gdbtypes.c (recursive_dump_type): Likewise.
7477         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7478         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7479         instead of %d in format strings.
7480         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7481         to std::min to ULONGEST.
7482         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7483         instead of %d in format strings.
7484         * tracepoint.c (info_scope_command): Likewise.
7485         * typeprint.c (print_offset_data::update)
7486         (print_offset_data::finish): Likewise.
7487         * xtensa-tdep.c (xtensa_store_return_value)
7488         (xtensa_push_dummy_call): Likewise.
7489
7490 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7491
7492         * windows-nat.c (display_selector): Fixed format specifications
7493         for 64-bit Cygwin.
7494
7495 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7496
7497         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7498
7499 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7500
7501         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7502         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7503         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7504         (nios2_linux_init_abi): Install it.
7505
7506 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7507
7508         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7509
7510 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7511
7512         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7513
7514 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7515             Tom Tromey  <tromey@adacore.com>
7516
7517         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7518
7519 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7520
7521         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7522         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7523         method to compute the bounds of range types. Also print "[evaluated]"
7524         if the bounds' values come from a dynamic evaluation.
7525
7526 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7527
7528         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7529         whitespace when pretty printing is on.
7530
7531 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7532
7533         * ppc-linux-nat.c: Add include.
7534
7535 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7536
7537         * NEWS: Mention AArch64 Pointer Authentication.
7538
7539 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7540
7541         * arm-linux-nat.c: Add include.
7542
7543 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7544
7545         * source-cache.c (source_cache::get_source_lines): Re-read
7546         fullname after calling open_source_file.
7547
7548 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7549
7550         * NEWS: Mention TLS support for FreeBSD.
7551
7552 2019-03-25  Tom Tromey  <tromey@adacore.com>
7553
7554         * minsyms.c (BUNCH_SIZE): Update comment.
7555         (~minimal_symbol_reader): Remove old comment.
7556         (compact_minimal_symbols): Update comment.
7557         (minimal_symbol_reader::install): Remove old comment.  Update
7558         other comments.
7559
7560 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7561
7562         * s390-linux-nat.c: Add include.
7563
7564 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7565
7566         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7567         Call linux_get_hwcap.
7568         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7569         Likewise.
7570         (aarch64_linux_get_hwcap): Remove function.
7571         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7572         declaration.
7573         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7574         linux_get_hwcap.
7575         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7576         * linux-tdep.c (linux_get_hwcap): Add function.
7577         (linux_get_hwcap2): Likewise.
7578         * linux-tdep.h (linux_get_hwcap): Add declaration.
7579         (linux_get_hwcap2): Likewise.
7580         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7581         (ppc_linux_get_hwcap2): Likewise.
7582         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7583         linux_get_hwcap.
7584         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7585         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7586         (ppc_linux_nat_target::read_description): Likewise.
7587         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7588         * s390-linux-nat.c: Likewise.
7589         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7590
7591 2019-03-24  Tom Tromey  <tom@tromey.com>
7592
7593         * ada-lang.c (standard_lookup): Simplify initialization.
7594         (ada_lookup_symbol_nonlocal): Simplify return.
7595         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7596         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7597         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7598         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7599         initialization.
7600         * solib.c (solib_global_lookup): Simplify.
7601         * symtab.c (null_block_symbol): Remove.
7602         (symbol_cache_lookup): Simplify returns.
7603         (lookup_language_this): Simplify returns.
7604         (lookup_symbol_aux): Simplify return.
7605         (lookup_local_symbol): Simplify returns.
7606         (lookup_global_symbol_from_objfile): Simplify return.
7607         (lookup_symbol_in_objfile_symtabs)
7608         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7609         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7610         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7611         * cp-namespace.c (cp_lookup_bare_symbol)
7612         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7613         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7614         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7615         (cp_lookup_symbol_via_imports): Simplify initialization.
7616         (find_symbol_in_baseclass): Likewise.
7617         * symtab.h (null_block_symbol): Remove.
7618         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7619         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7620         (d_lookup_symbol_module): Likewise.
7621         (find_symbol_in_baseclass): Simplify initialization.
7622
7623 2019-03-24  Tom Tromey  <tom@tromey.com>
7624
7625         * expression.h: Don't include symtab.h.
7626         (struct block): Forward declare.
7627
7628 2019-03-24  Tom Tromey  <tom@tromey.com>
7629
7630         * c-exp.y (typebase): Remove casts.
7631         * gdbtypes.c (lookup_unsigned_typename, )
7632         (lookup_signed_typename): Remove cast.
7633         * eval.c (parse_to_comma_and_eval): Remove cast.
7634         * parse.c (write_dollar_variable): Remove cast.
7635         * block.h (struct block) <superblock>: Now const.
7636         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7637         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7638         (map_block): Make "block" const.
7639         * symfile.h (struct quick_symbol_functions)
7640         <map_matching_symbols>: Constify block argument to "callback".
7641         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7642         const.
7643         (find_pc_sect_compunit_symtab): Make "b" const.
7644         (find_symbol_at_address): Likewise.
7645         (search_symbols): Likewise.
7646         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7647         (dw2_debug_names_lookup_symbol): Likewise.
7648         (dw2_map_matching_symbols): Update.
7649         * p-valprint.c (pascal_val_print): Remove "block".
7650         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7651         (aux_add_nonlocal_symbols): Make "block" const.
7652         (resolve_subexp): Remove cast.
7653         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7654         const.
7655         (iterate_over_file_blocks): Likewise.
7656         * f-exp.y (%union) <bval>: Remove.
7657         * coffread.c (patch_opaque_types): Make "b" const.
7658         * spu-tdep.c (spu_catch_start): Make "block" const.
7659         * c-valprint.c (print_unpacked_pointer): Remove "block".
7660         * symmisc.c (dump_symtab_1): Make "b" const.
7661         (block_depth): Make "block" const.
7662         * d-exp.y (%union) <bval>: Remove.
7663         * cp-support.h (cp_lookup_rtti_type): Update.
7664         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7665         * psymtab.c (psym_lookup_symbol): Make "block" const.
7666         (maintenance_check_psymtabs): Make "b" const.
7667         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7668         (enumerate_locals, enumerate_args): Update.
7669         * python/py-symtab.c (stpy_global_block): Make "block" const.
7670         (stpy_static_block): Likewise.
7671         * inline-frame.c (block_starting_point_at): Make "new_block"
7672         const.
7673         * block.c (find_block_in_blockvector): Make return type const.
7674         (blockvector_for_pc_sect): Make "b" const.
7675         (find_block_in_blockvector): Make "b" const.
7676
7677 2019-03-23  Tom Tromey  <tom@tromey.com>
7678
7679         * varobj.c (varobj_create): Update.
7680         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7681         * printcmd.c (display_command, do_one_display): Don't reset
7682         innermost_block.
7683         * parser-defs.h (enum innermost_block_tracker_type): Move to
7684         expression.h.
7685         (innermost_block): Update comment.
7686         * parse.c (parse_exp_1): Add tracker_types parameter.
7687         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7688         tracker_types parameter.  Reset innermost_block.
7689         (parse_exp_in_context): Remove.
7690         (parse_expression_for_completion): Update.
7691         * objfiles.c (~objfile): Don't reset expression_context_block or
7692         innermost_block.
7693         * expression.h (enum innermost_block_tracker_type): Move from
7694         parser-defs.h.
7695         (parse_exp_1): Add tracker_types parameter.
7696         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7697         reset innermost_block.
7698
7699 2019-03-23  Tom Tromey  <tom@tromey.com>
7700
7701         * objfiles.h: Include bcache.h.
7702
7703 2019-03-23  Tom Tromey  <tom@tromey.com>
7704
7705         * linespec.c (get_current_search_block): Use
7706         scoped_restore_current_language.
7707         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7708
7709 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7710             Jiong Wang  <jiong.wang@arm.com>
7711
7712         * aarch64-linux-tdep.c
7713         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7714         section.
7715         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7716
7717 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7718             Jiong Wang  <jiong.wang@arm.com>
7719
7720         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7721         instructions.
7722         (aarch64_analyze_prologue_test): Add PACIASP test.
7723         (aarch64_prologue_prev_register): Unmask PC value.
7724
7725 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7726             Jiong Wang  <jiong.wang@arm.com>
7727
7728         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7729         (aarch64_dwarf2_prev_register): Unmask PC value.
7730         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7731         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7732         DW_CFA_AARCH64_negate_ra_state.
7733         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7734
7735 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7736             Jiong Wang  <jiong.wang@arm.com>
7737
7738         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7739         registers.
7740         (aarch64_pseudo_register_name): Likewise.
7741         (aarch64_pseudo_register_type): Likewise.
7742         (aarch64_pseudo_register_reggroup_p): Likewise.
7743         (aarch64_gdbarch_init): Add pauth registers.
7744         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7745         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7746         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7747         (struct gdbarch_tdep): Add regnum for ra_state.
7748
7749 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7750             Jiong Wang  <jiong.wang@arm.com>
7751
7752         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7753
7754 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7755             Jiong Wang  <jiong.wang@arm.com>
7756
7757         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7758         function.
7759         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7760         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7761         (aarch64_gdbarch_init): Add puth registers.
7762         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7763         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7764         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7765
7766 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7767             Jiong Wang  <jiong.wang@arm.com>
7768
7769         * aarch64-linux-nat.c
7770         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7771         * aarch64-linux-tdep.c
7772         (aarch64_linux_core_read_description): Likewise.
7773         (aarch64_linux_get_hwcap): New function.
7774         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7775         (aarch64_linux_get_hwcap): New declaration.
7776
7777 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7778             Jiong Wang  <jiong.wang@arm.com>
7779
7780         * aarch64-linux-nat.c
7781         (aarch64_linux_nat_target::read_description): Add pauth param.
7782         * aarch64-linux-tdep.c
7783         (aarch64_linux_core_read_description): Likewise.
7784         * aarch64-tdep.c (struct target_desc): Add in pauth.
7785         (aarch64_read_description): Add pauth param.
7786         (aarch64_gdbarch_init): Likewise.
7787         * aarch64-tdep.h (aarch64_read_description): Likewise.
7788         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7789         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7790         * features/Makefile: Add new files.
7791         * features/aarch64-pauth.c: New file.
7792         * features/aarch64-pauth.xml: New file.
7793
7794 2019-03-20  Tom Tromey  <tromey@adacore.com>
7795
7796         * infrun.c (handle_inferior_event): Rename from
7797         handle_inferior_event_1.  Create a scoped_value_mark.
7798         (handle_inferior_event): Remove.
7799
7800 2019-03-19  Tom Tromey  <tromey@adacore.com>
7801
7802         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7803         * infrun.h (print_stop_event): Add "displays" parameter.
7804         * infrun.c (print_stop_event): Add "displays" parameter.
7805
7806 2019-03-19  Pedro Alves  <palves@redhat.com>
7807
7808         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7809         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7810         to -1.  Fix TABs vs spaces.
7811         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7812         * tui/tui-out.h (tui_ui_out) Add intro comments.
7813         <m_line, m_start_of_line>: In-class initialize, and add describing
7814         comment.
7815
7816 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7817
7818         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7819         variable names.
7820         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7821
7822 2019-03-18  Pedro Alves  <palves@redhat.com>
7823             Eli Zaretskii <eliz@gnu.org>
7824
7825         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7826         m_line and m_start_of_line.
7827
7828 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7829
7830         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7831         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7832         it returns a newline.  This fixes a regression in TU mode, whereby
7833         the next line is output on the same screen line as the user input.
7834
7835 2019-03-18  Tom Tromey  <tromey@adacore.com>
7836
7837         * minsyms.c (minimal_symbol_reader::install): Remove call to
7838         obstack_blank.
7839
7840 2019-03-18  Pedro Alves  <palves@redhat.com>
7841
7842         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7843         New globals.
7844         (apply_style): New, factored out from ...
7845         (apply_ansi_escape): ... this.  Handle reverse video mode.
7846         (tui_set_reverse_mode): New function.
7847         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7848         * tui/tui-winsource.c (tui_show_source_line): Use
7849         tui_set_reverse_mode instead of setting A_STANDOUT.
7850         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7851         New setter methods.
7852
7853 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7854
7855         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7856         Handle tabs.
7857
7858 2019-03-18  Tom Tromey  <tromey@adacore.com>
7859
7860         * ada-lang.c (empty_array): Add "high" parameter.
7861         (ada_evaluate_subexp): Update.
7862
7863 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7864
7865         * unittests/string_view-selftests.c: Define
7866         _initialize_string_view_selftests unconditionally.
7867
7868 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7869
7870         PR gdb/24350
7871         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7872
7873 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7874
7875         PR gdb/24351
7876         * windows-nat.c (display_selector): Fix format specifiers.
7877
7878 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7879
7880         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7881         tui_refill_source_window instead of tui_refresh_win, to update the
7882         current execution line.  This fixes redisplay of the current line
7883         when stepping through the code with "next" or "step".
7884
7885 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7886
7887         * source-cache.c (source_cache::get_source_lines): Call
7888         find_source_lines to initialize s->nlines.  This fixes vertical
7889         scrolling of TUI source window when the DOWN arrow is pressed.
7890
7891 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7892
7893         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7894         linux-thread-db.c (_initialize_thread_db): Likewise.
7895
7896 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7897
7898         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7899         wclrtoeol in tui_show_source_line".  This reverts changes made in
7900         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7901
7902 2019-03-15  Tom Tromey  <tom@tromey.com>
7903
7904         * symtab.h (struct minimal_symbol): Derive from
7905         general_symbol_info.
7906         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7907         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7908         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7909         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7910         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7911         (MSYMBOL_SEARCH_NAME): Update.
7912         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7913         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7914         * minsyms.c (minimal_symbol_reader::record_full): Update.
7915
7916 2019-03-15  Tom Tromey  <tom@tromey.com>
7917
7918         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7919
7920 2019-03-15  Tom Tromey  <tom@tromey.com>
7921
7922         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7923         unique_xmalloc_ptr.
7924         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7925         Update.
7926         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7927         (build_minimal_symbol_hash_tables)
7928         (minimal_symbol_reader::install): Update.
7929
7930 2019-03-15  Tom Tromey  <tom@tromey.com>
7931
7932         * symtab.c (create_demangled_names_hash): Update.
7933         (symbol_set_names): Update.
7934         * objfiles.h (struct objfile_per_bfd_storage)
7935         <demangled_names_hash>: Now an htab_up.
7936         * objfiles.c (objfile_per_bfd_storage): Simplify.
7937
7938 2019-03-15  Tom Tromey  <tom@tromey.com>
7939
7940         * objfiles.h (struct objfile_per_bfd_storage): Declare
7941         destructor.
7942         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7943         New.
7944         (get_objfile_bfd_data): Use new.  Don't initialize
7945         language_of_main.
7946         (free_objfile_per_bfd_storage): Remove.
7947         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7948
7949 2019-03-15  Tom Tromey  <tom@tromey.com>
7950
7951         * symfile.c (reread_symbols): Update.
7952         * objfiles.c (objfile::objfile): Update.
7953         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7954         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7955         comment.
7956         (minimal_symbol_reader::install): Update.
7957         (terminate_minimal_symbol_table): Remove.
7958         * jit.c (jit_object_close_impl): Update.
7959
7960 2019-03-15  Tom Tromey  <tom@tromey.com>
7961
7962         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7963         initializations.
7964
7965 2019-03-15  Tom Tromey  <tom@tromey.com>
7966
7967         * objfiles.h (struct objfile_per_bfd_storage)
7968         <demangled_hash_languages>: Now a bitset.
7969         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7970         (lookup_minimal_symbol): Update.
7971
7972 2019-03-15  Tom Tromey  <tom@tromey.com>
7973
7974         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7975         Don't return the symbol.
7976         * coffread.c (record_minimal_symbol): Use record_full.
7977
7978 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7979
7980         The MS-Windows port of ncurses fails to switch to a color pair if
7981         one or both of the colors are the implicit default colors.  This
7982         change records the default colors when TUI is initialized, and
7983         then specifies them explicitly when a color pair uses the default
7984         colors.  This allows color styling in TUI mode on MS-Windows.
7985
7986         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7987         ncurses_norm_attr.
7988         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7989         colors in ncurses_norm_attr.
7990         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7991         "none", replace it with the default color recorded in
7992         ncurses_norm_attr.
7993
7994 2019-03-14  Tom Tromey  <tromey@adacore.com>
7995
7996         * source-cache.h (class source_cache) <get_source_lines>: Return
7997         std::string.
7998         * source-cache.c (source_cache::extract_lines): Handle case where
7999         first_pos==npos.  Return std::string.
8000         (source_cache::get_source_lines): Update.
8001
8002 2019-03-14  Tom Tromey  <tromey@adacore.com>
8003
8004         * NEWS: Add item for "style sources" commands.
8005         * source-cache.c (source_cache::get_source_lines): Check
8006         source_styling.
8007         * cli/cli-style.c (source_styling): New global.
8008         (_initialize_cli_style): Add "style sources" commands.
8009         (show_style_sources): New function.
8010         * cli/cli-style.h (source_styling): Declare.
8011
8012 2019-03-14  Pedro Alves  <palves@redhat.com>
8013             Tom Tromey  <tromey@adacore.com>
8014
8015         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8016         * tui/tui-winsource.c (tui_refill_source_window): New function,
8017         from...
8018         (tui_horizontal_source_scroll): ... here.  Move some logic.
8019         * cli/cli-style.c (set_style_enabled): Notify new observable.
8020         * tui/tui-hooks.c (tui_redisplay_source): New function.
8021         (tui_attach_detach_observers): Attach or detach
8022         tui_redisplay_source.
8023         * observable.h (source_styling_changed): New observable.
8024         * observable.c: Define source_styling_changed observable.
8025
8026 2019-03-13  Tom Tromey  <tromey@adacore.com>
8027
8028         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8029         (i386_gnu_nat_target::store_registers): Update.
8030         * target-debug.h (target_debug_print_std_string): New macro.
8031         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8032         * windows-tdep.c (display_one_tib): Update.
8033         * tui/tui-stack.c (tui_make_status_line): Update.
8034         * top.c (print_inferior_quit_action): Update.
8035         * thread.c (thr_try_catch_cmd): Update.
8036         (add_thread_with_info): Update.
8037         (thread_target_id_str): Update.
8038         (thr_try_catch_cmd): Update.
8039         (thread_command): Update.
8040         (thread_find_command): Update.
8041         * record-btrace.c (record_btrace_target::info_record)
8042         (record_btrace_resume_thread, record_btrace_target::resume)
8043         (record_btrace_cancel_resume, record_btrace_step_thread)
8044         (record_btrace_target::wait, record_btrace_target::wait)
8045         (record_btrace_target::wait, record_btrace_target::stop): Update.
8046         * progspace.c (print_program_space): Update.
8047         * process-stratum-target.c
8048         (process_stratum_target::thread_address_space): Update.
8049         * linux-fork.c (linux_fork_mourn_inferior)
8050         (detach_checkpoint_command, info_checkpoints_command)
8051         (linux_fork_context): Update.
8052         (linux_fork_detach): Update.
8053         (class scoped_switch_fork_info): Update.
8054         (delete_checkpoint_command): Update.
8055         * infrun.c (follow_fork_inferior): Update.
8056         (follow_fork_inferior): Update.
8057         (proceed_after_vfork_done): Update.
8058         (handle_vfork_child_exec_or_exit): Update.
8059         (follow_exec): Update.
8060         (displaced_step_prepare_throw): Update.
8061         (displaced_step_restore): Update.
8062         (start_step_over): Update.
8063         (resume_1): Update.
8064         (clear_proceed_status_thread): Update.
8065         (proceed): Update.
8066         (print_target_wait_results): Update.
8067         (do_target_wait): Update.
8068         (context_switch): Update.
8069         (stop_all_threads): Update.
8070         (restart_threads): Update.
8071         (finish_step_over): Update.
8072         (handle_signal_stop): Update.
8073         (switch_back_to_stepped_thread): Update.
8074         (keep_going_pass_signal): Update.
8075         (print_exited_reason): Update.
8076         (normal_stop): Update.
8077         * inferior.c (inferior_pid_to_str): Change return type.
8078         (print_selected_inferior): Update.
8079         (add_inferior): Update.
8080         (detach_inferior): Update.
8081         * dummy-frame.c (fprint_dummy_frames): Update.
8082         * dcache.c (dcache_info_1): Update.
8083         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8084         (btrace_fetch, btrace_clear): Update.
8085         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8086         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8087         type.
8088         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8089         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8090         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8091         * gdbarch.c, gdbarch.h: Rebuild.
8092         * gdbarch.sh (core_pid_to_str): Change return type.
8093         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8094         return type.
8095         (windows_nat_target::pid_to_str): Change return type.
8096         (windows_delete_thread): Update.
8097         (windows_nat_target::attach): Update.
8098         (windows_nat_target::files_info): Update.
8099         * target-delegates.c: Rebuild.
8100         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8101         return type.
8102         (sol_thread_target::pid_to_str): Change return type.
8103         * remote.c (class remote_target) <pid_to_str>: Change return
8104         type.
8105         (remote_target::pid_to_str): Change return type.
8106         (extended_remote_target::attach, remote_target::remote_stop_ns)
8107         (remote_target::remote_notif_remove_queued_reply)
8108         (remote_target::push_stop_reply, remote_target::disable_btrace):
8109         Update.
8110         (extended_remote_target::attach): Update.
8111         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8112         type.
8113         (gdbsim_target::pid_to_str): Change return type.
8114         * ravenscar-thread.c (struct ravenscar_thread_target)
8115         <pid_to_str>: Change return type.
8116         (ravenscar_thread_target::pid_to_str): Change return type.
8117         * procfs.c (class procfs_target) <pid_to_str>: Change return
8118         type.
8119         (procfs_target::pid_to_str): Change return type.
8120         (procfs_target::attach): Update.
8121         (procfs_target::detach): Update.
8122         (procfs_target::fetch_registers): Update.
8123         (procfs_target::store_registers): Update.
8124         (procfs_target::wait): Update.
8125         (procfs_target::files_info): Update.
8126         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8127         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8128         return type.
8129         (nto_procfs_target::pid_to_str): Change return type.
8130         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8131         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8132         return type.
8133         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8134         (exit_lwp): Update.
8135         (attach_proc_task_lwp_callback, get_detach_signal)
8136         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8137         (linux_nat_target::resume, wait_lwp, stop_callback)
8138         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8139         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8140         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8141         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8142         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8143         type.
8144         (inf_ptrace_target::attach): Update.
8145         (inf_ptrace_target::files_info): Update.
8146         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8147         type.
8148         (go32_nat_target::pid_to_str): Change return type.
8149         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8150         (gnu_nat_target::wait): Update.
8151         (gnu_nat_target::wait): Update.
8152         (gnu_nat_target::resume): Update.
8153         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8154         (fbsd_nat_target::wait): Update.
8155         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8156         type.
8157         (darwin_nat_target::attach): Update.
8158         * corelow.c (class core_target) <pid_to_str>: Change return type.
8159         (core_target::pid_to_str): Change return type.
8160         * target.c (normal_pid_to_str): Change return type.
8161         (default_pid_to_str): Likewise.
8162         (target_pid_to_str): Change return type.
8163         (target_translate_tls_address): Update.
8164         (target_announce_detach): Update.
8165         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8166         return type.
8167         (bsd_uthread_target::pid_to_str): Change return type.
8168         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8169         type.
8170         (bsd_kvm_target::pid_to_str): Change return type.
8171         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8172         return type.
8173         (aix_thread_target::pid_to_str): Change return type.
8174         * target.h (struct target_ops) <pid_to_str>: Change return type.
8175         (target_pid_to_str, normal_pid_to_str): Likewise.
8176         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8177         type.
8178         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8179         type.
8180         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8181         return type.
8182         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8183         type.
8184         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8185         type.
8186         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8187         return type.
8188
8189 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8190
8191         * NEWS: Mention that the new default MI version is 3.  Mention
8192         changes to the output of commands and events that deal with
8193         multi-location breakpoints.
8194         * breakpoint.c: Include "mi/mi-out.h".
8195         (print_one_breakpoint): Change output syntax if using MI version
8196         >= 3.
8197         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8198         New.
8199         (mi_multi_location_breakpoint_output_fixed): New.
8200         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8201         (mi_cmd_fix_multi_location_breakpoint_output): New.
8202         (mi_multi_location_breakpoint_output_fixed): New.
8203         * mi/mi-cmds.c (mi_cmds): Register command
8204         -fix-multi-location-breakpoint-output.
8205         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8206         interpreter "mi".
8207
8208 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8209
8210         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8211         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8212         instantiate mi_ui_out based on interpreter name.
8213         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8214         * mi/mi-main.c (mi_load_progress): Likewise.
8215
8216 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8217
8218         * NEWS: Combine separate "New targets" sections for 8.3.
8219
8220 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8221
8222         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8223         (ppcfbsd_init_abi): Install gdbarch
8224         "fetch_tls_load_module_address" and "get_thread_local_address"
8225         methods.
8226
8227 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8228
8229         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8230         (riscv_fbsd_init_abi): Install gdbarch
8231         "fetch_tls_load_module_address" and "get_thread_local_address"
8232         methods.
8233
8234 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8235
8236         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8237         (i386fbsd_init_abi): Install gdbarch
8238         "fetch_tls_load_module_address" and "get_thread_local_address"
8239         methods.
8240
8241 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8242
8243         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8244         (amd64fbsd_init_abi): Install gdbarch
8245         "fetch_tls_load_module_address" and "get_thread_local_address"
8246         methods.
8247
8248 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8249
8250         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8251         (struct fbsd_pspace_data): New type.
8252         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8253         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8254         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8255         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8256         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8257
8258 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8259
8260         * gdbtypes.c (lookup_struct_elt): New function.
8261         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8262         * gdbtypes.h (struct struct_elt): New type.
8263         (lookup_struct_elt): New prototype.
8264
8265 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8266
8267         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8268         remove disabled code block.
8269
8270 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8271
8272         * gdbarch.sh (get_thread_local_address): New method.
8273         * gdbarch.h, gdbarch.c: Regenerate.
8274         * target.c (target_translate_tls_address): Use
8275         gdbarch_get_thread_local_address if present instead of
8276         target::get_thread_local_address.
8277
8278 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8279
8280         * target.h (target::get_thread_local_address): Update comment.
8281
8282 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8283
8284         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8285         objfile->separate_debug_objfile_backlink if not NULL.
8286
8287 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8288
8289         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8290         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8291         (amd64bsd_store_inferior_registers): Likewise.
8292         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8293         Enable segment base registers.
8294         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8295         PT_GETFSBASE and PT_GETGSBASE.
8296         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8297         PT_SETGSBASE.
8298         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8299         segment base registers.
8300         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8301
8302 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8303
8304         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8305         Update calls to i386_target_description to add 'segments'
8306         parameter.
8307         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8308         add segment base registers.
8309         * arch/i386.c (i386_create_target_description): Add 'segments'
8310         parameter to enable segment base registers.
8311         * arch/i386.h (i386_create_target_description): Likewise.
8312         * features/i386/32bit-segments.xml: New file.
8313         * features/i386/32bit-segments.c: Generate.
8314         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8315         call to i386_target_description to add 'segments' parameter.
8316         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8317         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8318         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8319         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8320         if feature is present.
8321         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8322         Add 'segments' parameter to call to i386_target_description.
8323         (i386_target_description): Add 'segments' parameter to enable
8324         segment base registers.
8325         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8326         to call to i386_target_description.
8327         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8328         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8329         Define I386_NUM_REGS.
8330         (i386_target_description): Add 'segments' parameter to enable
8331         segment base registers.
8332
8333 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8334
8335         PR/24325
8336         * source-cache.c: #undef open and close, to avoid unresolved
8337         externals during linking.
8338
8339 2019-03-12  Tom Tromey  <tromey@adacore.com>
8340
8341         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8342         const.  Add initializers.
8343         (_initialize_remote): Don't initialize ptid globals.
8344
8345 2019-03-12  Pedro Alves  <palves@redhat.com>
8346
8347         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8348
8349 2019-03-12  Pedro Alves  <palves@redhat.com>
8350
8351         * cp-name-parser.y (main): Remove unused 'len' variable.
8352
8353 2019-03-12  Tom Tromey  <tromey@adacore.com>
8354
8355         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8356         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8357
8358 2019-03-12  Tom Tromey  <tromey@adacore.com>
8359
8360         * linux-nat.c (iterate_over_lwps): Update.
8361         (stop_callback): Remove parameter.
8362         (stop_wait_callback, detach_callback, resume_set_callback)
8363         (select_singlestep_lwp_callback, set_ignore_sigint)
8364         (status_callback, resumed_callback, resume_clear_callback)
8365         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8366         data parameter.
8367         (linux_nat_target::detach, linux_nat_target::resume)
8368         (linux_stop_and_wait_all_lwps, select_event_lwp)
8369         (linux_nat_filter_event, linux_nat_wait_1)
8370         (linux_nat_target::kill, linux_nat_target::stop)
8371         (linux_nat_target::stop): Update.
8372         (linux_nat_resume_callback): Change type.
8373         (resume_stopped_resumed_lwps, count_events_callback)
8374         (select_event_lwp_callback): Likewise.
8375         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8376         * arm-linux-nat.c (struct update_registers_data): Remove.
8377         (update_registers_callback): Change type.
8378         (arm_linux_insert_hw_breakpoint1): Update.
8379         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8380         parameter.
8381         (x86_linux_dr_set_addr): Update.
8382         (x86_linux_dr_set_control): Update.
8383         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8384         (iterate_over_lwps): Use gdb::function_view.
8385         * nat/aarch64-linux-hw-point.c (struct
8386         aarch64_dr_update_callback_param): Remove.
8387         (debug_reg_change_callback): Change type.
8388         (aarch64_notify_debug_reg_change): Update.
8389         * s390-linux-nat.c (s390_refresh_per_info): Update.
8390
8391 2019-03-11  Tom Tromey  <tromey@adacore.com>
8392
8393         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8394         redundant assignment to "this_cu".
8395
8396 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8397
8398         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8399
8400 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8401
8402         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8403         from...
8404         (rank_one_type): ... this.
8405
8406 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8407
8408         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8409         from...
8410         (rank_one_type): ... this.
8411
8412 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8413
8414         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8415         from...
8416         (rank_one_type): ... this.
8417
8418 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8419
8420         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8421         from...
8422         (rank_one_type): ... this.
8423
8424 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8425
8426         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8427         from...
8428         (rank_one_type): ... this.
8429
8430 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8431
8432         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8433         from...
8434         (rank_one_type): ... this.
8435
8436 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8437
8438         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8439         from...
8440         (rank_one_type): ... this.
8441
8442 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8443
8444         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8445         from...
8446         (rank_one_type): ... this.
8447
8448 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8449
8450         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8451         from...
8452         (rank_one_type): ... this.
8453
8454 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8455
8456         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8457         from...
8458         (rank_one_type): ... this.
8459
8460 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8461
8462         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8463         from...
8464         (rank_one_type): ... this.
8465
8466 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8467
8468         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8469         from...
8470         (rank_one_type): ... this.
8471
8472 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8473
8474         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8475         inferior-events' shows the example events.
8476
8477 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8478
8479         Support styling on native MS-Windows console
8480
8481         PR/24315
8482         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8483         on MS-Windows if $TERM is not defined.
8484
8485         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8486
8487         * posix-hdep.c (gdb_console_fputs):
8488         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8489         functions.
8490         * ui-file.h (gdb_console_fputs): Add prototype.
8491
8492         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8493         back to fputs only if the former returns zero.
8494
8495 2019-03-07  Tom Tromey  <tom@tromey.com>
8496
8497         * symmisc.c (print_symbol_bcache_statistics): Update.
8498         (print_objfile_statistics): Update.
8499         * symfile.c (allocate_symtab): Update.
8500         * stabsread.c: Don't include bcache.h.
8501         * psymtab.h (struct psymbol_bcache): Don't declare.
8502         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8503         (psymbol_bcache_init, psymbol_bcache_free)
8504         (psymbol_bcache_get_bcache): Don't declare.
8505         * psymtab.c (struct psymbol_bcache): Remove.
8506         (psymtab_storage::psymtab_storage): Update.
8507         (psymtab_storage::~psymtab_storage): Update.
8508         (psymbol_bcache_init, psymbol_bcache_free)
8509         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8510         (add_psymbol_to_bcache): Update.
8511         (allocate_psymtab): Update.
8512         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8513         macro_cache>: No longer pointers.
8514         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8515         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8516         * macrotab.c (macro_bcache): Update.
8517         * macroexp.c: Don't include bcache.h.
8518         * gdbtypes.c (check_types_worklist): Update.
8519         (types_deeply_equal): Remove TRY/CATCH.  Update.
8520         * elfread.c (elf_symtab_read): Update.
8521         * dwarf2read.c: Don't include bcache.h.
8522         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8523         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8524         (print_bcache_statistics, bcache_memory_used): Don't declare.
8525         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8526         methods.  Rename all data members.
8527         * bcache.c (struct bcache): Move to bcache.h.
8528         (bcache::expand_hash_table): Rename from expand_hash_table.
8529         (bcache): Remove.
8530         (bcache::insert): Rename from bcache_full.
8531         (bcache::compare): Rename from bcache_compare.
8532         (bcache_xmalloc): Remove.
8533         (bcache::~bcache): Rename from bcache_xfree.
8534         (bcache::print_statistics): Rename from print_bcache_statistics.
8535         (bcache::memory_used): Rename from bcache_memory_used.
8536
8537 2019-03-07  Pedro Alves  <palves@redhat.com>
8538
8539         * infrun.c (normal_stop): Also check for
8540         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8541
8542 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8543
8544         * f-lang.c (value_from_host_double): Moved to...
8545         * value.c (value_from_host_double): ...here.
8546         * value.h (value_from_host_double): Declare.
8547         * guile/scm-math.c (vlscm_convert_typed_number): Use
8548         value_from_host_double.
8549         (vlscm_convert_number): Likewise.
8550         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8551         * python/py-value.c (convert_value_from_python): Likewise.
8552
8553 2019-03-06  Tom Tromey  <tom@tromey.com>
8554
8555         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8556
8557 2019-03-06  Tom Tromey  <tom@tromey.com>
8558
8559         * utils.h (free_current_contents): Don't declare.
8560         * utils.c (free_current_contents): Remove.
8561
8562 2019-03-06  Tom Tromey  <tom@tromey.com>
8563
8564         * top.c (quit_force): Update.
8565         * main.c (captured_command_loop): Update.
8566         * common/new-op.c (operator new): Update.
8567         * common/common-exceptions.c (struct catcher)
8568         <save_cleanup_chain>: Remove member.
8569         (exceptions_state_mc_init): Update.
8570         (exception_try_scope_entry): Return nullptr.
8571         (exception_try_scope_exit, exception_rethrow)
8572         (throw_exception_sjlj, throw_exception_cxx): Update.
8573         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8574         (all_cleanups, do_cleanups, discard_cleanups)
8575         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8576         (restore_cleanups, restore_final_cleanups): Don't declare.
8577         (do_final_cleanups): Remove parameter.
8578         * common/cleanups.c (cleanup_chain, make_cleanup)
8579         (make_cleanup_dtor, all_cleanups, do_cleanups)
8580         (discard_my_cleanups, discard_cleanups)
8581         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8582         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8583         (null_cleanup): Remove.
8584         (do_final_cleanups): Remove parameter.
8585
8586 2019-03-06  Tom Tromey  <tom@tromey.com>
8587
8588         * remote.c (remote_target::remote_parse_stop_reply): Use
8589         unique_xmalloc_ptr.
8590
8591 2019-03-06  Tom Tromey  <tom@tromey.com>
8592
8593         * stabsread.c (struct stabs_field_info): Rename from field_info.
8594         <list, fnlist>: Add initializers.
8595         <obstack>: New member.
8596         (read_member_functions, read_struct_fields, read_baseclasses):
8597         Allocate on obstack.  Don't use cleanups.
8598         (read_one_struct_field, read_member_functions, read_struct_fields)
8599         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8600         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8601         (read_struct_type): Update.
8602
8603 2019-03-06  Tom Tromey  <tom@tromey.com>
8604
8605         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8606         * common/filestuff.h (make_cleanup_close): Don't declare.
8607         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8608         Remove.
8609
8610 2019-03-06  Tom Tromey  <tom@tromey.com>
8611
8612         * solib-aix.c: Use make_scope_exit.
8613
8614 2019-03-06  Tom Tromey  <tom@tromey.com>
8615
8616         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8617         Use make_scope_exit.
8618
8619 2019-03-06  Tom Tromey  <tom@tromey.com>
8620
8621         * solib-svr4.c (disable_probes_interface): Remove parameter.
8622         (svr4_handle_solib_event): Use make_scope_exit.
8623
8624 2019-03-06  Tom Tromey  <tom@tromey.com>
8625
8626         * remote.c (struct stop_reply_deleter): Remove.
8627         (stop_reply_up): Update.
8628         (struct stop_reply): Derive from notif_event.  Don't typedef.
8629         <regcache>: Now a std::vector.
8630         (stop_reply_xfree): Remove.
8631         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8632         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8633         (remote_target::discard_pending_stop_replies): Use delete.
8634         (remote_target::remote_parse_stop_reply): Update.
8635         (remote_target::process_stop_reply): Update.
8636         * remote-notif.h (struct notif_event): Add virtual destructor.
8637         Remove "dtr" member.
8638         (struct notif_client) <alloc_event>: Return a unique_ptr.
8639         (notif_event_xfree): Don't declare.
8640         (notif_event_up): New typedef.
8641         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8642         (notif_event_xfree, do_notif_event_xfree): Remove.
8643         (remote_notif_state_xfree): Update.
8644
8645 2019-03-06  Tom Tromey  <tom@tromey.com>
8646
8647         * infrun.c (displaced_step_clear_cleanup): Now a
8648         forward_scope_exit type.
8649         (displaced_step_prepare_throw): Update.
8650         (displaced_step_fixup): Update.
8651
8652 2019-03-06  Tom Tromey  <tom@tromey.com>
8653
8654         * inferior.h (class inferior): Update comment.
8655         * gdbthread.h (class thread_info): Update comment.
8656
8657 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8658             Tom Tromey  <tom@tromey.com>
8659
8660         * stabsread.h (struct stab_section_list): Remove.
8661         (coffstab_build_psymtabs): Update.
8662         * dbxread.c (symbuf_sections): Now a std::vector.
8663         (sect_idx): New global.
8664         (fill_symbuf): Update.
8665         (coffstab_build_psymtabs): Change type of stabsects parameter.
8666         Update.
8667         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8668         std::vector.
8669         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8670         (coff_locate_sections): Update.
8671         (coff_symfile_read): Remove cleanups.  Update.
8672         (init_stringtab): Add storage parameter.
8673         (free_stringtab, free_stringtab_cleanup): Remove.
8674         (init_lineno): Add storage parameter.
8675         (free_linetab, free_linetab_cleanup): Remove.
8676
8677 2019-03-06  Pedro Alves  <palves@redhat.com>
8678
8679         * linux-fork.c (fork_info::clobber_regs): Delete.
8680         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8681         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8682         comment.  Adjust.
8683         (scoped_switch_fork_info::scoped_switch_fork_info)
8684         (checkpoint_command, linux_fork_context): Adjust
8685         fork_save_infrun_state calls.
8686
8687 2019-03-06  Pedro Alves  <palves@redhat.com>
8688
8689         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8690         (inf_has_multiple_threads): Return 'bool' and rewrite using
8691         inferior_info::threads().
8692
8693 2019-03-06  Pedro Alves  <palves@redhat.com>
8694
8695         * linux-fork.c: Include <list>.
8696         (fork_list): Now a std::list instance.
8697         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8698         (forks_exist_p, find_last_fork): Adjust.
8699         (new_fork): Delete.
8700         (one_fork_p): New.
8701         (add_fork): Adjust.
8702         (free_fork): Delete, folded into fork_info::~fork_info().
8703         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8704         Adjust.
8705         (init_fork_list): Delete.
8706         (linux_fork_killall, linux_fork_mourn_inferior)
8707         (linux_fork_detach, info_checkpoints_command): Adjust.
8708         (_initialize_linux_fork): No longer call init_fork_list.
8709
8710 2019-03-06  Pedro Alves  <palves@redhat.com>
8711
8712         * linux-fork.c (new_fork): New, split out of ...
8713         (add_fork): ... this.  Return void.  Move "first fork" special
8714         case from here, to ...
8715         (checkpoint_command): ... here.
8716         * linux-linux.h (add_fork): Return void.
8717
8718 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8719
8720         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8721
8722 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8723             Chris January  <chris.january@arm.com>
8724             David Lecomber  <david.lecomber@arm.com>
8725
8726         * f-exp.y: New token, UNOP_INTRINSIC.
8727         (exp): New pattern using UNOP_INTRINSIC token.
8728         (f77_keywords): Add 'abs' keyword.
8729         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8730         (value_from_host_double): New function.
8731         (evaluate_subexp_f): Support UNOP_ABS.
8732
8733 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8734
8735         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8736         types.
8737
8738 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8739
8740         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8741         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8742         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8743
8744 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8745
8746         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8747
8748 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8749             Chris January  <chris.january@arm.com>
8750
8751         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8752         * f-exp.y: Define 'KIND' token.
8753         (exp): New pattern for KIND expressions.
8754         (ptype): Handle types with a kind extension.
8755         (direct_abs_decl): Extend to spot kind extensions.
8756         (f77_keywords): Add 'kind' to the list.
8757         (push_kind_type): New function.
8758         (convert_to_kind_type): New function.
8759         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8760         * parse.c (operator_length_standard): Likewise.
8761         * parser-defs.h (enum type_pieces): Add tp_kind.
8762         * std-operator.def: Add UNOP_KIND.
8763
8764 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8765
8766         * f-exp.y (f_parse): Set yydebug.
8767
8768 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8769
8770         * f-lang.c (evaluate_subexp_f): New function.
8771         (exp_descriptor_f): New global.
8772         (f_language_defn): Use exp_descriptor_f instead of
8773         exp_descriptor_standard.
8774
8775 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8776
8777         * f-exp.y (struct token): Add comments.
8778         (dot_ops): Remove uppercase versions and the end marker.
8779         (f77_keywords): Likewise.
8780         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8781         entries in the dot_ops array are case insensitive, and use
8782         strncasecmp to compare strings.  Also some whitespace cleanup in
8783         this area.  Similar for the f77_keywords array, except entries in
8784         this list might be case sensitive.
8785
8786 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8787
8788         * f-exp.y (struct f77_boolean_val): Add comments.
8789         (boolean_values): Remove uppercase versions, and end marker.
8790         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8791         and use strncasecmp to achieve case insensitivity.  Additionally,
8792         perform whitespace cleanup around this code.
8793
8794 2019-03-06  Tom Tromey  <tromey@adacore.com>
8795
8796         * remote-sim.c (gdbsim_target_open): Use result of
8797         gdb_argv::release.
8798
8799 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8800         Dirk Schubert  <dirk.schubert@arm.com>
8801         Chris January  <chris.january@arm.com>
8802
8803         * eval.c (evaluate_subexp_standard): Call Fortran argument
8804         wrapping logic.
8805         * f-lang.c (struct value): A value which can be passed into a
8806         Fortran function call.
8807         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8808         where appropriate.
8809         (struct type): Value ready for a Fortran function call.
8810         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8811         is needed.
8812         * f-lang.h (fortran_argument_convert): Declaration.
8813         (fortran_preserve_arg_pointer): Declaration.
8814         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8815
8816 2019-03-05  Tom Tromey  <tromey@adacore.com>
8817
8818         * python/py-prettyprint.c (print_string_repr): Remove #if.
8819         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8820
8821 2019-03-05  Tom Tromey  <tromey@adacore.com>
8822
8823         * target.c (the_dummy_target): Move later.  Change type to
8824         "dummy_target".
8825         (initialize_targets): Don't initialize the_dummy_target.
8826
8827 2019-03-05  Tom Tromey  <tromey@adacore.com>
8828
8829         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8830         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8831
8832 2019-03-05  Tom Tromey  <tromey@adacore.com>
8833
8834         * windows-nat.c (windows_nat_target::attach)
8835         (windows_nat_target::detach): Don't call gdb_flush.
8836         * valprint.c (generic_val_print, val_print, val_print_string):
8837         Don't call gdb_flush.
8838         * utils.c (defaulted_query): Don't call gdb_flush.
8839         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8840         * target.c (target_announce_detach): Don't call gdb_flush.
8841         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8842         * remote.c (extended_remote_target::attach): Don't call
8843         gdb_flush.
8844         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8845         * printcmd.c (do_examine): Don't call gdb_flush.
8846         (info_display_command): Don't call gdb_flush.
8847         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8848         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8849         * memattr.c (info_mem_command): Don't call gdb_flush.
8850         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8851         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8852         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8853         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8854         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8855         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8856         (gnu_nat_target::detach): Don't call gdb_flush.
8857         * f-valprint.c (f_val_print): Don't call gdb_flush.
8858         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8859         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8860         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8861         gdb_flush.
8862         * c-valprint.c (c_val_print): Don't call gdb_flush.
8863         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8864
8865 2019-03-05  Tom Tromey  <tromey@adacore.com>
8866
8867         * varobj.c (update_dynamic_varobj_children): Update.
8868         (install_default_visualizer): Use reset, not release.
8869         * value.c (set_internalvar): Update.
8870         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8871         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8872         ATTRIBUTE_UNUSED_RESULT.
8873
8874 2019-03-05  Tom Tromey  <tromey@adacore.com>
8875
8876         * remote.c (class scoped_remote_fd) <release>: Add
8877         ATTRIBUTE_UNUSED_RESULT.
8878
8879 2019-03-05  Tom Tromey  <tromey@adacore.com>
8880
8881         * macroexp.c (struct macro_buffer) <release>: Add
8882         ATTRIBUTE_UNUSED_RESULT.
8883
8884 2019-03-05  Tom Tromey  <tromey@adacore.com>
8885
8886         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8887         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8888         ATTRIBUTE_UNUSED_RESULT.
8889
8890 2019-03-05  Tom Tromey  <tromey@adacore.com>
8891
8892         * common/scoped_fd.h (class scoped_fd) <release>: Add
8893         ATTRIBUTE_UNUSED_RESULT.
8894
8895 2019-03-05  Tom Tromey  <tromey@adacore.com>
8896
8897         * parser-defs.h (struct parser_state) <release>: Add
8898         ATTRIBUTE_UNUSED_RESULT.
8899
8900 2019-03-05  Tom Tromey  <tromey@adacore.com>
8901
8902         * utils.h (class gdb_argv) <release>: Add
8903         ATTRIBUTE_UNUSED_RESULT.
8904         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8905
8906 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8907
8908         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8909         for-loop range, to avoid compiler warnings.
8910
8911         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8912         avoid compiler warnings about unused variables.
8913
8914         * NEWS: Mention end of support for native debugging on MS-Windows
8915         before XP.
8916
8917         PR gdb/24292
8918         * common/netstuff.c:
8919         * gdbserver/gdbreplay.c
8920         * gdbserver/remote-utils.c:
8921         * ser-tcp.c:
8922         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8923         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8924         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8925         'getaddrinfo' and 'freeaddrinfo' were not available before
8926         Windows XP, and mingw.org's MinGW headers by default define
8927         _WIN32_WINNT to 0x500.
8928
8929 2019-03-01  Gary Benson <gbenson@redhat.com>
8930
8931         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8932
8933 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8934             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8935
8936         PR gdb/8527
8937         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8938         set_sigint_trap, clear_sigint_trap.
8939
8940 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8941
8942         * target.c (target_detach): Clear the regcache and the
8943         frame cache.
8944
8945 2019-02-27  Pedro Alves  <palves@redhat.com>
8946
8947         * utils.c (set_screen_size): When we cap the height/width sizes,
8948         tweak the corresponding command variable to show "unlimited":
8949
8950 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8951             Pedro Alves  <palves@redhat.com>
8952
8953         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8954         before calling rl_set_screen_size.
8955
8956 2019-02-27  Tom Tromey  <tromey@adacore.com>
8957
8958         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8959         define.
8960         * python/py-value.c: Remove Python 2.4 workaround.
8961         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8962         workaround.
8963         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8964         Python 2.4 workaround.
8965         * python/python-internal.h: Remove Python 2.4 comment.
8966         (Py_ssize_t): Don't define.
8967         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8968         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8969         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8970         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8971         * python/python.c (do_start_initialization): Remove Python 2.4
8972         workaround.
8973         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8974         (print_children): Remove Python 2.4 workaround.
8975         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8976         workaround.
8977         (CHARBUFFERPROC_NAME): Remove.
8978         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8979         Python 2.4 workaround.
8980
8981 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8982
8983         * NEWS: Note minimum Python version.
8984
8985 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8986
8987         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8988         code from these functions.  Remove corresponding ifdefs.  Use
8989         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8990         Remove gotos and target of gotos.
8991         (infpy_search_memory): Likewise.
8992
8993 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8994
8995         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8996         (hppa_gdbarch_init): Don't register deleted functions with
8997         gdbarch.
8998
8999 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9000
9001         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9002         (h8300_unwind_sp): Delete.
9003         (h8300_dummy_id): Delete.
9004         (h8300_gdbarch_init): Don't register deleted functions with
9005         gdbarch.
9006
9007 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9008
9009         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9010         (ft32_unwind_pc): Delete.
9011         (ft32_unwind_sp): Delete.
9012         (ft32_gdbarch_init): Don't register deleted functions with
9013         gdbarch.
9014
9015 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9016
9017         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9018         (frv_unwind_pc): Delete.
9019         (frv_unwind_sp): Delete.
9020         (frv_gdbarch_init): Don't register deleted functions with
9021         gdbarch.
9022
9023 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9024
9025         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9026         (riscv_unwind_pc): Delete.
9027         (riscv_unwind_sp): Delete.
9028         (riscv_gdbarch_init): Don't register deleted functions with
9029         gdbarch.
9030
9031 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9032
9033         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9034         (csky_unwind_pc): Delete.
9035         (csky_unwind_sp): Delete.
9036         (csky_gdbarch_init): Don't register deleted functions with
9037         gdbarch.
9038
9039 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9040
9041         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9042         (cris_unwind_pc): Delete.
9043         (cris_unwind_sp): Delete.
9044         (cris_gdbarch_init): Don't register deleted functions with
9045         gdbarch.
9046
9047 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9048
9049         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9050         (bfin_unwind_pc): Delete.
9051         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9052
9053 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9054
9055         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9056         (arm_unwind_pc): Delete.
9057         (arm_unwind_sp): Delete.
9058         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9059
9060 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9061
9062         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9063         (arc_unwind_pc): Delete.
9064         (arc_unwind_sp): Delete.
9065         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9066
9067 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9068
9069         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9070         (alpha_unwind_pc): Delete.
9071         (alpha_gdbarch_init): Don't register deleted functions with
9072         gdbarch.
9073
9074 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9075
9076         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9077         (aarch64_unwind_pc): Delete.
9078         (aarch64_unwind_sp): Delete.
9079         (aarch64_gdbarch_init): Don't register deleted functions with
9080         gdbarch.
9081
9082 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9083
9084         * gdbtypes.c (type_align): Don't consider static members when
9085         computing structure alignment.
9086
9087 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9088
9089         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9090         return 0 for other types.
9091         * arch-utils.c (default_type_align): Always return 0.
9092         * gdbarch.h: Regenerate.
9093         * gdbarch.sh (type_align): Extend comment.
9094         * gdbtypes.c (type_align): Add additional comments, always call
9095         gdbarch_type_align before applying the default rules.
9096         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9097         generic code will then apply a suitable default.
9098         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9099         types, return 0 for other types.
9100
9101 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9102
9103         * NEWS: Create a new section for the next release branch.
9104         Rename the section of the current branch, now that it has
9105         been cut.
9106
9107 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9108
9109         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9110         * version.in: Bump version to 8.3.50.DATE-git.
9111
9112 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9113
9114         * aix-thread.c (ptid_cmp): Remove unused variable.
9115         (get_signaled_thread): Likewise.
9116         (store_regs_user_thread): Likewise.
9117         (store_regs_kernel_thread): Likewise.
9118         (fetch_regs_kernel_thread): Remove shadowed variable.
9119
9120 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9121
9122         * features/riscv/32bit-cpu.xml: Add register numbers.
9123         * features/riscv/32bit-fpu.c: Regenerate.
9124         * features/riscv/32bit-fpu.xml: Add register numbers.
9125         * features/riscv/64bit-cpu.xml: Add register numbers.
9126         * features/riscv/64bit-fpu.c: Regenerate.
9127         * features/riscv/64bit-fpu.xml: Add register numbers.
9128
9129 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9130
9131         * NEWS: Mention two argument form of gdb.Value constructor.
9132         * python/py-value.c (convert_buffer_and_type_to_value): New
9133         function.
9134         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9135         Add support for handling an optional second argument.  Call
9136         convert_buffer_and_type_to_value as appropriate.
9137         * python/python-internal.h (Py_buffer_deleter): New struct.
9138         (Py_buffer_up): New typedef.
9139
9140 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9141
9142         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9143         instead of releasing ownership.
9144
9145 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9146
9147         * dwarf2read.c (open_and_init_dwp_file): Call
9148         elf_numsections instead of bfd_count_sections to initialize
9149         dwp_file->num_sections.
9150
9151 2019-02-25  Tom Tromey  <tromey@adacore.com>
9152
9153         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9154
9155 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9156
9157         * gcore.in: Add '--readnever' option when invoking GDB.
9158
9159 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9160
9161         * MAINTAINERS: Update my email address.
9162
9163 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9164
9165         * build-id.c (build_id_to_debug_bfd_1): New function.
9166         (build_id_to_debug_bfd): Look for separate debug file in
9167         sysroot.
9168
9169 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9170
9171         * gdbarch.sh: Update the copyright year range that is placed into
9172         generated files.
9173
9174 2019-02-22  Keith Seitz  <keiths@redhat.com>
9175
9176         PR symtab/23853
9177         * linespec.c (create_sals_line_offset): Search for the default
9178         symtab's filename instead of its fullname.
9179
9180 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9181
9182         * NEWS: Update style defaults.
9183
9184 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9185
9186         * main.c (captured_main_1): Disable styling in batch mode.
9187
9188 2019-02-20  Tom Tromey  <tom@tromey.com>
9189
9190         * symtab.c (symtab_symbol_info): Fix typos.
9191
9192 2019-02-20  Tom Tromey  <tromey@adacore.com>
9193
9194         * findcmd.c (_initialize_mem_search): Use upper case for
9195         metasyntactic variables.
9196
9197 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9198
9199         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9200         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9201
9202 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9203
9204         * top.h (source_file_name): Change to std::string.
9205         * top.c (source_file_name): Likewise.
9206         (command_line_input): Adjust.
9207         * cli/cli-script.c (script_from_file): Adjust.
9208
9209 2019-02-19  Tom Tromey  <tromey@adacore.com>
9210
9211         * ravenscar-thread.c
9212         (ravenscar_thread_target::update_thread_list): Don't call
9213         ada_build_task_list.
9214         * ada-lang.h (ada_build_task_list): Don't declare.
9215         * ada-tasks.c (struct ada_tasks_inferior_data)
9216         <task_list_valid_p>: Now bool.
9217         (read_known_tasks, ada_task_list_changed)
9218         (ada_tasks_invalidate_inferior_data): Update.
9219         (read_known_tasks_array): Return bool.
9220         (read_known_tasks_list): Likewise.
9221         (read_known_tasks): Return void.
9222         (ada_build_task_list): Now static.
9223
9224 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9225
9226         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9227         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9228
9229 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9230
9231         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9232         variant for ada_tasks_pspace_data_handle and
9233         ada_tasks_inferior_data_handle.
9234         (ada_tasks_pspace_data_cleanup): New function.
9235         (ada_tasks_inferior_data_cleanup): New function.
9236
9237 2019-02-17  Tom Tromey  <tom@tromey.com>
9238
9239         * macrotab.h (macro_source_fullname): Return a std::string.
9240         * macrotab.c (macro_include, check_for_redefinition)
9241         (macro_undef, macro_lookup_definition, foreach_macro)
9242         (foreach_macro_in_scope): Update.
9243         (macro_source_fullname): Return a std::string.
9244         * macrocmd.c (show_pp_source_pos): Update.
9245
9246 2019-02-17  Tom Tromey  <tom@tromey.com>
9247
9248         * macrocmd.c (show_pp_source_pos): Style the file names.
9249
9250 2019-02-17  Tom Tromey  <tom@tromey.com>
9251
9252         PR tui/24197:
9253         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9254
9255 2019-02-17  Tom Tromey  <tom@tromey.com>
9256
9257         * ada-lang.c (user_select_syms): Use filtered printing.
9258         * utils.c (wrap_style): New global.
9259         (desired_style): Remove.
9260         (emit_style_escape): Add stream parameter.
9261         (set_output_style, reset_terminal_style, prompt_for_continue):
9262         Update.
9263         (flush_wrap_buffer): Only flush gdb_stdout.
9264         (wrap_here): Set wrap_style.
9265         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9266         treat escape sequences as a character.  Change when wrap buffer is
9267         flushed.
9268         (fputs_styled): Do not set the output style when the default is
9269         requested.
9270         * ui-style.h (struct ui_file_style) <is_default>: New method.
9271         * source.c (print_source_lines_base): Emit escape sequences in one
9272         piece.
9273
9274 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9275
9276         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9277         integers and enumeration types.
9278
9279 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9280
9281         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9282         instead of lookup_symbol_in_language
9283         (do_exact_match): New function.
9284         (ada_get_symbol_name_matcher): Return do_exact_match when
9285         doing a verbatim match.
9286
9287 2019-02-15  Tom Tromey  <tromey@adacore.com>
9288
9289         * ravenscar-thread.c (ravenscar_thread_target::resume)
9290         (ravenscar_thread_target::wait): Special case wildcard requests.
9291
9292 2019-02-15  Tom Tromey  <tromey@adacore.com>
9293
9294         * ravenscar-thread.c (base_ptid): Remove.
9295         (struct ravenscar_thread_target) <close>: New method.
9296         <m_base_ptid>: New member.
9297         <update_inferior_ptid, active_task, task_is_currently_active,
9298         runtime_initialized>: Declare methods.
9299         <ravenscar_thread_target>: Add constructor.
9300         (ravenscar_thread_target::task_is_currently_active)
9301         (ravenscar_thread_target::update_inferior_ptid)
9302         (ravenscar_runtime_initialized): Rename.  Now methods.
9303         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9304         (ravenscar_thread_target::update_thread_list): Update.
9305         (ravenscar_thread_target::active_task): Now method.
9306         (ravenscar_thread_target::store_registers)
9307         (ravenscar_thread_target::prepare_to_store)
9308         (ravenscar_thread_target::prepare_to_store)
9309         (ravenscar_thread_target::mourn_inferior): Update.
9310         (ravenscar_inferior_created): Use "new" to create target.
9311         (ravenscar_thread_target::get_ada_task_ptid): Update.
9312         (_initialize_ravenscar): Don't initialize base_ptid.
9313         (ravenscar_ops): Remove global.
9314
9315 2019-02-15  Tom Tromey  <tromey@adacore.com>
9316
9317         * target.h (push_target): Declare new overload.
9318         * target.c (push_target): New overload, taking an rvalue reference.
9319         * remote.c (remote_target::open_1): Use push_target overload.
9320         * corelow.c (core_target_open): Use push_target overload.
9321
9322 2019-02-15  Tom Tromey  <tromey@adacore.com>
9323
9324         * ravenscar-thread.c (is_ravenscar_task)
9325         (ravenscar_task_is_currently_active): Return bool.
9326         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9327         (_initialize_ravenscar): Remove "(void)".
9328         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9329         Return bool.
9330
9331 2019-02-15  Tom Tromey  <tromey@adacore.com>
9332
9333         * ravenscar-thread.c (ravenscar_runtime_initializer)
9334         (has_ravenscar_runtime, get_running_thread_id)
9335         (ravenscar_thread_target::resume): Fix indentation.
9336
9337 2019-02-15  Tom Tromey  <tromey@adacore.com>
9338
9339         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9340         from ravenscar_arch_ops.
9341         (sparc_ravenscar_ops::fetch_registers)
9342         (sparc_ravenscar_ops::store_registers): Now methods.
9343         (sparc_ravenscar_prepare_to_store): Remove.
9344         (sparc_ravenscar_ops): Redefine.
9345         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9346         methods and destructor.  Remove members.
9347         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9348         (ravenscar_thread_target::store_registers)
9349         (ravenscar_thread_target::prepare_to_store): Update.
9350         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9351         Remove.
9352         (struct ppc_ravenscar_powerpc_ops): Derive from
9353         ravenscar_arch_ops.
9354         (ppc_ravenscar_powerpc_ops::fetch_registers)
9355         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9356         (ppc_ravenscar_powerpc_ops): Redefine.
9357         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9358         (ppc_ravenscar_e500_ops::fetch_registers)
9359         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9360         (ppc_ravenscar_e500_ops): Redefine.
9361         * aarch64-ravenscar-thread.c
9362         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9363         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9364         (aarch64_ravenscar_fetch_registers)
9365         (aarch64_ravenscar_store_registers): Now methods.
9366         (aarch64_ravenscar_ops): Redefine.
9367
9368 2019-02-15  Tom Tromey  <tromey@adacore.com>
9369
9370         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9371         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9372         (ravenscar_thread_target::stopped_by_watchpoint)
9373         (ravenscar_thread_target::stopped_data_address)
9374         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9375
9376 2019-02-15  Tom Tromey  <tromey@adacore.com>
9377
9378         * ravenscar-thread.c: Fix some typos.
9379
9380 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9381             Tom Tromey  <tromey@adacore.com>
9382
9383         * ada-lang.c (ada_exception_sal): Change addr_string to a
9384         std::string.
9385         (create_ada_exception_catchpoint): Update.
9386
9387 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9388             Tom Tromey  <tromey@adacore.com>
9389
9390         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9391         (bp_location_ops): Remove.
9392         (base_breakpoint_allocate_location): Update.
9393         (free_bp_location): Update.
9394         * ada-lang.c (class ada_catchpoint_location)
9395         <ada_catchpoint_location>: Remove ops parameter.
9396         (ada_catchpoint_location_dtor): Remove.
9397         (ada_catchpoint_location_ops): Remove.
9398         (allocate_location_exception): Update.
9399         * breakpoint.h (struct bp_location_ops): Remove.
9400         (class bp_location) <bp_location>: Remove bp_location_ops
9401         parameter.
9402         <~bp_location>: Add destructor.
9403         <ops>: Remove.
9404
9405 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9406             Pedro Alves  <palves@redhat.com>
9407
9408         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9409         'PATH_MAX'.
9410
9411 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9412             Samuel Thibault  <samuel.thibault@gnu.org>
9413             Thomas Schwinge  <thomas@codesourcery.com>
9414
9415         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9416         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9417
9418 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9419
9420         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9421         (check_empty): Use "const char *".
9422
9423         * gnu-nat.c (gnu_nat_target::detach): Instead of
9424         'detach_inferior (pid)' call
9425         'detach_inferior (find_inferior_pid (pid))'.
9426
9427         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9428         'nat/fork-inferior.o'.
9429         * gnu-nat.c: #include "nat/fork-inferior.h".
9430
9431         * gnu-nat.c (gnu_nat_target::detach): Instead of
9432         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9433         * gnu-nat.h: #include "inf-child.h".
9434         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9435         'i386_gnu_nat_target::fetch_registers'.
9436         (gnu_store_registers): Rename/move to
9437         'i386_gnu_nat_target::store_registers'.
9438
9439         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9440         * gnu-nat.h (mach_thread_info): New function.
9441         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9442
9443         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9444
9445 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9446
9447         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9448
9449 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9450
9451         * windows-nat.c (windows_add_thread): Add new parameter
9452         "main_thread_p" with default value set to false.  Update
9453         function documentation as well as all callers.
9454         (windows_delete_thread): Likewise.
9455         (fake_create_process): Update call to windows_add_thread.
9456         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9457         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9458         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9459         call to windows_delete_thread.
9460
9461 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9462
9463         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9464
9465 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9466
9467         * symfile.c (find_separate_debug_file): Use canonical path of
9468         sysroot with child_path instead of gdb_sysroot if it is valid.
9469
9470 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9471
9472         * symfile.c (find_separate_debug_file): Use child_path to
9473         determine if an object file is under a sysroot.
9474
9475 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9476
9477         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9478         unittests/child-path-selftests.c.
9479         * common/pathstuff.c (child_path): New function.
9480         * common/pathstuff.h (child_path): New prototype.
9481         * unittests/child-path-selftests.c: New file.
9482
9483 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9484
9485         * symfile.c (find_separate_debug_file): Look for separate debug
9486         files in debug directories under the sysroot.
9487
9488 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9489
9490         * symtab.h (struct minimal_symbol data_p): New const method.
9491         (struct minimal_symbol text_p): Likewise.
9492         * symtab.c (output_source_filename): Use file name style
9493         to print file name.
9494         (print_symbol_info): Likewise.
9495         (print_msymbol_info): Use address style to print addresses.
9496         Use function name style to print executable text symbols.
9497         (expand_symtab_containing_pc): Use data_p.
9498         (find_pc_sect_compunit_symtab): Likewise.
9499
9500 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9501
9502         * breakpoint.c (describe_other_breakpoints): Use address style
9503         to print addresses.
9504         (say_where): Likewise.
9505
9506 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9507
9508         * ada-typeprint.c (print_func_type): Print function name
9509         style to print function name.
9510         * c-typeprint.c (c_print_type_1): Likewise.
9511
9512 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9513
9514         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9515         for execve.
9516
9517 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9518
9519         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9520         type_stack.
9521
9522 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9523
9524         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9525         TYPE_CODE_REF types.
9526
9527 2019-02-08  Jim Wilson  <jimw@sifive.com>
9528
9529         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9530         (riscv_linux_fregset): New.
9531         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9532
9533 2019-02-07  Tom Tromey  <tom@tromey.com>
9534
9535         * thread.c (thread_cancel_execution_command): Update.
9536         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9537         methods.
9538         (struct thread_fsm_ops): Remove.
9539         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9540         (thread_fsm_should_stop, thread_fsm_return_value)
9541         (thread_fsm_set_finished, thread_fsm_finished_p)
9542         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9543         Don't declare.
9544         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9545         * infrun.c (clear_proceed_status_thread)
9546         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9547         (print_stop_event): Update.
9548         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9549         Add constructor.
9550         (step_command_fsm_ops): Remove.
9551         (new_step_command_fsm): Remove.
9552         (step_1): Update.
9553         (step_command_fsm::should_stop): Rename from
9554         step_command_fsm_should_stop.
9555         (step_command_fsm::clean_up): Rename from
9556         step_command_fsm_clean_up.
9557         (step_command_fsm::do_async_reply_reason): Rename from
9558         step_command_fsm_async_reply_reason.
9559         (struct until_next_fsm): Inherit from thread_fsm.  Add
9560         constructor.
9561         (until_next_fsm_ops): Remove.
9562         (new_until_next_fsm): Remove.
9563         (until_next_fsm::should_stop): Rename from
9564         until_next_fsm_should_stop.
9565         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9566         (until_next_fsm::do_async_reply_reason): Rename from
9567         until_next_fsm_async_reply_reason.
9568         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9569         constructor.  Change type of breakpoint.
9570         (finish_command_fsm_ops): Remove.
9571         (new_finish_command_fsm): Remove.
9572         (finish_command_fsm::should_stop): Rename from
9573         finish_command_fsm_should_stop.
9574         (finish_command_fsm::clean_up): Rename from
9575         finish_command_fsm_clean_up.
9576         (finish_command_fsm::return_value): Rename from
9577         finish_command_fsm_return_value.
9578         (finish_command_fsm::do_async_reply_reason): Rename from
9579         finish_command_fsm_async_reply_reason.
9580         (finish_command): Update.
9581         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9582         Add constructor.
9583         (call_thread_fsm_ops): Remove.
9584         (call_thread_fsm::call_thread_fsm): Rename from
9585         new_call_thread_fsm.
9586         (call_thread_fsm::should_stop): Rename from
9587         call_thread_fsm_should_stop.
9588         (call_thread_fsm::should_notify_stop): Rename from
9589         call_thread_fsm_should_notify_stop.
9590         (run_inferior_call, call_function_by_hand_dummy): Update.
9591         * cli/cli-interp.c (should_print_stop_to_console): Update.
9592         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9593         Add constructor.  Change type of location_breakpoint,
9594         caller_breakpoint.
9595         (until_break_fsm_ops): Remove.
9596         (new_until_break_fsm): Remove.
9597         (until_break_fsm::should_stop): Rename from
9598         until_break_fsm_should_stop.
9599         (until_break_fsm::clean_up): Rename from
9600         until_break_fsm_clean_up.
9601         (until_break_fsm::do_async_reply_reason): Rename from
9602         until_break_fsm_async_reply_reason.
9603         (until_break_command): Update.
9604         * thread-fsm.c: Remove.
9605         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9606
9607 2019-02-07  Tom Tromey  <tom@tromey.com>
9608
9609         * yy-remap.h: Add include guard.
9610         * xtensa-tdep.h: Add include guard.
9611         * xcoffread.h: Rename include guard.
9612         * varobj-iter.h: Add include guard.
9613         * tui/tui.h: Rename include guard.
9614         * tui/tui-winsource.h: Rename include guard.
9615         * tui/tui-wingeneral.h: Rename include guard.
9616         * tui/tui-windata.h: Rename include guard.
9617         * tui/tui-win.h: Rename include guard.
9618         * tui/tui-stack.h: Rename include guard.
9619         * tui/tui-source.h: Rename include guard.
9620         * tui/tui-regs.h: Rename include guard.
9621         * tui/tui-out.h: Rename include guard.
9622         * tui/tui-layout.h: Rename include guard.
9623         * tui/tui-io.h: Rename include guard.
9624         * tui/tui-hooks.h: Rename include guard.
9625         * tui/tui-file.h: Rename include guard.
9626         * tui/tui-disasm.h: Rename include guard.
9627         * tui/tui-data.h: Rename include guard.
9628         * tui/tui-command.h: Rename include guard.
9629         * tic6x-tdep.h: Add include guard.
9630         * target/waitstatus.h: Rename include guard.
9631         * target/wait.h: Rename include guard.
9632         * target/target.h: Rename include guard.
9633         * target/resume.h: Rename include guard.
9634         * target-float.h: Rename include guard.
9635         * stabsread.h: Add include guard.
9636         * rs6000-tdep.h: Add include guard.
9637         * riscv-fbsd-tdep.h: Add include guard.
9638         * regformats/regdef.h: Rename include guard.
9639         * record.h: Rename include guard.
9640         * python/python.h: Rename include guard.
9641         * python/python-internal.h: Rename include guard.
9642         * python/py-stopevent.h: Rename include guard.
9643         * python/py-ref.h: Rename include guard.
9644         * python/py-record.h: Rename include guard.
9645         * python/py-record-full.h: Rename include guard.
9646         * python/py-record-btrace.h: Rename include guard.
9647         * python/py-instruction.h: Rename include guard.
9648         * python/py-events.h: Rename include guard.
9649         * python/py-event.h: Rename include guard.
9650         * procfs.h: Add include guard.
9651         * proc-utils.h: Add include guard.
9652         * p-lang.h: Add include guard.
9653         * or1k-tdep.h: Rename include guard.
9654         * observable.h: Rename include guard.
9655         * nto-tdep.h: Rename include guard.
9656         * nat/x86-linux.h: Rename include guard.
9657         * nat/x86-linux-dregs.h: Rename include guard.
9658         * nat/x86-gcc-cpuid.h: Add include guard.
9659         * nat/x86-dregs.h: Rename include guard.
9660         * nat/x86-cpuid.h: Rename include guard.
9661         * nat/ppc-linux.h: Rename include guard.
9662         * nat/mips-linux-watch.h: Rename include guard.
9663         * nat/linux-waitpid.h: Rename include guard.
9664         * nat/linux-ptrace.h: Rename include guard.
9665         * nat/linux-procfs.h: Rename include guard.
9666         * nat/linux-osdata.h: Rename include guard.
9667         * nat/linux-nat.h: Rename include guard.
9668         * nat/linux-namespaces.h: Rename include guard.
9669         * nat/linux-btrace.h: Rename include guard.
9670         * nat/glibc_thread_db.h: Rename include guard.
9671         * nat/gdb_thread_db.h: Rename include guard.
9672         * nat/gdb_ptrace.h: Rename include guard.
9673         * nat/fork-inferior.h: Rename include guard.
9674         * nat/amd64-linux-siginfo.h: Rename include guard.
9675         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9676         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9677         * nat/aarch64-linux.h: Rename include guard.
9678         * nat/aarch64-linux-hw-point.h: Rename include guard.
9679         * mn10300-tdep.h: Add include guard.
9680         * mips-linux-tdep.h: Add include guard.
9681         * mi/mi-parse.h: Rename include guard.
9682         * mi/mi-out.h: Rename include guard.
9683         * mi/mi-main.h: Rename include guard.
9684         * mi/mi-interp.h: Rename include guard.
9685         * mi/mi-getopt.h: Rename include guard.
9686         * mi/mi-console.h: Rename include guard.
9687         * mi/mi-common.h: Rename include guard.
9688         * mi/mi-cmds.h: Rename include guard.
9689         * mi/mi-cmd-break.h: Rename include guard.
9690         * m2-lang.h: Add include guard.
9691         * location.h: Rename include guard.
9692         * linux-record.h: Rename include guard.
9693         * linux-nat.h: Add include guard.
9694         * linux-fork.h: Add include guard.
9695         * i386-darwin-tdep.h: Rename include guard.
9696         * hppa-linux-offsets.h: Add include guard.
9697         * guile/guile.h: Rename include guard.
9698         * guile/guile-internal.h: Rename include guard.
9699         * gnu-nat.h: Rename include guard.
9700         * gdb-stabs.h: Rename include guard.
9701         * frv-tdep.h: Add include guard.
9702         * f-lang.h: Add include guard.
9703         * event-loop.h: Add include guard.
9704         * darwin-nat.h: Rename include guard.
9705         * cp-abi.h: Rename include guard.
9706         * config/sparc/nm-sol2.h: Rename include guard.
9707         * config/nm-nto.h: Rename include guard.
9708         * config/nm-linux.h: Add include guard.
9709         * config/i386/nm-i386gnu.h: Rename include guard.
9710         * config/djgpp/nl_types.h: Rename include guard.
9711         * config/djgpp/langinfo.h: Rename include guard.
9712         * compile/gcc-cp-plugin.h: Add include guard.
9713         * compile/gcc-c-plugin.h: Add include guard.
9714         * compile/compile.h: Rename include guard.
9715         * compile/compile-object-run.h: Rename include guard.
9716         * compile/compile-object-load.h: Rename include guard.
9717         * compile/compile-internal.h: Rename include guard.
9718         * compile/compile-cplus.h: Rename include guard.
9719         * compile/compile-c.h: Rename include guard.
9720         * common/xml-utils.h: Rename include guard.
9721         * common/x86-xstate.h: Rename include guard.
9722         * common/version.h: Rename include guard.
9723         * common/vec.h: Rename include guard.
9724         * common/tdesc.h: Rename include guard.
9725         * common/selftest.h: Rename include guard.
9726         * common/scoped_restore.h: Rename include guard.
9727         * common/scoped_mmap.h: Rename include guard.
9728         * common/scoped_fd.h: Rename include guard.
9729         * common/safe-iterator.h: Rename include guard.
9730         * common/run-time-clock.h: Rename include guard.
9731         * common/refcounted-object.h: Rename include guard.
9732         * common/queue.h: Rename include guard.
9733         * common/ptid.h: Rename include guard.
9734         * common/print-utils.h: Rename include guard.
9735         * common/preprocessor.h: Rename include guard.
9736         * common/pathstuff.h: Rename include guard.
9737         * common/observable.h: Rename include guard.
9738         * common/netstuff.h: Rename include guard.
9739         * common/job-control.h: Rename include guard.
9740         * common/host-defs.h: Rename include guard.
9741         * common/gdb_wait.h: Rename include guard.
9742         * common/gdb_vecs.h: Rename include guard.
9743         * common/gdb_unlinker.h: Rename include guard.
9744         * common/gdb_unique_ptr.h: Rename include guard.
9745         * common/gdb_tilde_expand.h: Rename include guard.
9746         * common/gdb_sys_time.h: Rename include guard.
9747         * common/gdb_string_view.h: Rename include guard.
9748         * common/gdb_splay_tree.h: Rename include guard.
9749         * common/gdb_setjmp.h: Rename include guard.
9750         * common/gdb_ref_ptr.h: Rename include guard.
9751         * common/gdb_optional.h: Rename include guard.
9752         * common/gdb_locale.h: Rename include guard.
9753         * common/gdb_assert.h: Rename include guard.
9754         * common/filtered-iterator.h: Rename include guard.
9755         * common/filestuff.h: Rename include guard.
9756         * common/fileio.h: Rename include guard.
9757         * common/environ.h: Rename include guard.
9758         * common/common-utils.h: Rename include guard.
9759         * common/common-types.h: Rename include guard.
9760         * common/common-regcache.h: Rename include guard.
9761         * common/common-inferior.h: Rename include guard.
9762         * common/common-gdbthread.h: Rename include guard.
9763         * common/common-exceptions.h: Rename include guard.
9764         * common/common-defs.h: Rename include guard.
9765         * common/common-debug.h: Rename include guard.
9766         * common/cleanups.h: Rename include guard.
9767         * common/buffer.h: Rename include guard.
9768         * common/btrace-common.h: Rename include guard.
9769         * common/break-common.h: Rename include guard.
9770         * cli/cli-utils.h: Rename include guard.
9771         * cli/cli-style.h: Rename include guard.
9772         * cli/cli-setshow.h: Rename include guard.
9773         * cli/cli-script.h: Rename include guard.
9774         * cli/cli-interp.h: Rename include guard.
9775         * cli/cli-decode.h: Rename include guard.
9776         * cli/cli-cmds.h: Rename include guard.
9777         * charset-list.h: Add include guard.
9778         * buildsym-legacy.h: Rename include guard.
9779         * bfin-tdep.h: Add include guard.
9780         * ax.h: Rename include guard.
9781         * arm-linux-tdep.h: Add include guard.
9782         * arm-fbsd-tdep.h: Add include guard.
9783         * arch/xtensa.h: Rename include guard.
9784         * arch/tic6x.h: Add include guard.
9785         * arch/i386.h: Add include guard.
9786         * arch/arm.h: Rename include guard.
9787         * arch/arm-linux.h: Rename include guard.
9788         * arch/arm-get-next-pcs.h: Rename include guard.
9789         * arch/amd64.h: Add include guard.
9790         * arch/aarch64-insn.h: Rename include guard.
9791         * arch-utils.h: Rename include guard.
9792         * annotate.h: Add include guard.
9793         * amd64-darwin-tdep.h: Rename include guard.
9794         * aarch64-linux-tdep.h: Add include guard.
9795         * aarch64-fbsd-tdep.h: Add include guard.
9796         * aarch32-linux-nat.h: Add include guard.
9797
9798 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9799
9800         * macrotab.c (macro_define_internal): New function that
9801         factorizes macro_define_object_internal and macro_define_function
9802         code.
9803         (macro_define_object_internal): Use macro_define_internal.
9804         (macro_define_function): Likewise.
9805
9806 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9807
9808         * macrocmd.c (extract_identifier): Return
9809         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9810         callers.
9811
9812 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9813
9814         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9815
9816 2019-02-05  Tom Tromey  <tom@tromey.com>
9817
9818         * target.c (target_stack::unpush): Move assertion earlier.
9819
9820 2019-01-30  Tom Tromey  <tom@tromey.com>
9821
9822         PR python/23615:
9823         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9824         (gdbpy_parse_and_eval): Likewise.
9825         * python/python-internal.h (gdbpy_allow_threads): New class.
9826
9827 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9828
9829         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9830         (aarch64_fbsd_fpregmap): Move earlier.
9831         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9832         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9833         instead of individual calls to trad_frame_set_reg_addr.
9834         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9835         earlier.
9836         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9837         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9838         instead of individual calls to trad_frame_set_reg_addr.
9839
9840 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9841
9842         * CONTRIBUTE: Replace contribution list with wiki link.
9843
9844 2019-01-25  Tom Tromey  <tom@tromey.com>
9845
9846         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9847
9848 2019-01-25  Tom Tromey  <tom@tromey.com>
9849
9850         * xtensa-linux-nat.c: Fix common/ includes.
9851         * xml-support.h: Fix common/ includes.
9852         * xml-support.c: Fix common/ includes.
9853         * x86-linux-nat.c: Fix common/ includes.
9854         * windows-nat.c: Fix common/ includes.
9855         * varobj.h: Fix common/ includes.
9856         * varobj.c: Fix common/ includes.
9857         * value.c: Fix common/ includes.
9858         * valops.c: Fix common/ includes.
9859         * utils.c: Fix common/ includes.
9860         * unittests/xml-utils-selftests.c: Fix common/ includes.
9861         * unittests/utils-selftests.c: Fix common/ includes.
9862         * unittests/unpack-selftests.c: Fix common/ includes.
9863         * unittests/tracepoint-selftests.c: Fix common/ includes.
9864         * unittests/style-selftests.c: Fix common/ includes.
9865         * unittests/string_view-selftests.c: Fix common/ includes.
9866         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9867         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9868         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9869         * unittests/rsp-low-selftests.c: Fix common/ includes.
9870         * unittests/parse-connection-spec-selftests.c: Fix common/
9871         includes.
9872         * unittests/optional-selftests.c: Fix common/ includes.
9873         * unittests/offset-type-selftests.c: Fix common/ includes.
9874         * unittests/observable-selftests.c: Fix common/ includes.
9875         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9876         * unittests/memrange-selftests.c: Fix common/ includes.
9877         * unittests/memory-map-selftests.c: Fix common/ includes.
9878         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9879         * unittests/function-view-selftests.c: Fix common/ includes.
9880         * unittests/environ-selftests.c: Fix common/ includes.
9881         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9882         * unittests/common-utils-selftests.c: Fix common/ includes.
9883         * unittests/cli-utils-selftests.c: Fix common/ includes.
9884         * unittests/array-view-selftests.c: Fix common/ includes.
9885         * ui-file.c: Fix common/ includes.
9886         * tui/tui-io.c: Fix common/ includes.
9887         * tracepoint.h: Fix common/ includes.
9888         * tracepoint.c: Fix common/ includes.
9889         * tracefile-tfile.c: Fix common/ includes.
9890         * top.h: Fix common/ includes.
9891         * top.c: Fix common/ includes.
9892         * thread.c: Fix common/ includes.
9893         * target/waitstatus.h: Fix common/ includes.
9894         * target/waitstatus.c: Fix common/ includes.
9895         * target.h: Fix common/ includes.
9896         * target.c: Fix common/ includes.
9897         * target-memory.c: Fix common/ includes.
9898         * target-descriptions.c: Fix common/ includes.
9899         * symtab.h: Fix common/ includes.
9900         * symfile.c: Fix common/ includes.
9901         * stap-probe.c: Fix common/ includes.
9902         * spu-linux-nat.c: Fix common/ includes.
9903         * sparc-nat.c: Fix common/ includes.
9904         * source.c: Fix common/ includes.
9905         * solib.c: Fix common/ includes.
9906         * solib-target.c: Fix common/ includes.
9907         * ser-unix.c: Fix common/ includes.
9908         * ser-tcp.c: Fix common/ includes.
9909         * ser-pipe.c: Fix common/ includes.
9910         * ser-base.c: Fix common/ includes.
9911         * selftest-arch.c: Fix common/ includes.
9912         * s12z-tdep.c: Fix common/ includes.
9913         * rust-exp.y: Fix common/ includes.
9914         * rs6000-aix-tdep.c: Fix common/ includes.
9915         * riscv-tdep.c: Fix common/ includes.
9916         * remote.c: Fix common/ includes.
9917         * remote-notif.h: Fix common/ includes.
9918         * remote-fileio.h: Fix common/ includes.
9919         * remote-fileio.c: Fix common/ includes.
9920         * regcache.h: Fix common/ includes.
9921         * regcache.c: Fix common/ includes.
9922         * record-btrace.c: Fix common/ includes.
9923         * python/python.c: Fix common/ includes.
9924         * python/py-type.c: Fix common/ includes.
9925         * python/py-inferior.c: Fix common/ includes.
9926         * progspace.h: Fix common/ includes.
9927         * producer.c: Fix common/ includes.
9928         * procfs.c: Fix common/ includes.
9929         * proc-api.c: Fix common/ includes.
9930         * printcmd.c: Fix common/ includes.
9931         * ppc-linux-nat.c: Fix common/ includes.
9932         * parser-defs.h: Fix common/ includes.
9933         * osdata.c: Fix common/ includes.
9934         * obsd-nat.c: Fix common/ includes.
9935         * nat/x86-linux.c: Fix common/ includes.
9936         * nat/x86-linux-dregs.c: Fix common/ includes.
9937         * nat/x86-dregs.h: Fix common/ includes.
9938         * nat/x86-dregs.c: Fix common/ includes.
9939         * nat/ppc-linux.c: Fix common/ includes.
9940         * nat/mips-linux-watch.h: Fix common/ includes.
9941         * nat/mips-linux-watch.c: Fix common/ includes.
9942         * nat/linux-waitpid.c: Fix common/ includes.
9943         * nat/linux-ptrace.h: Fix common/ includes.
9944         * nat/linux-ptrace.c: Fix common/ includes.
9945         * nat/linux-procfs.c: Fix common/ includes.
9946         * nat/linux-personality.c: Fix common/ includes.
9947         * nat/linux-osdata.c: Fix common/ includes.
9948         * nat/linux-namespaces.c: Fix common/ includes.
9949         * nat/linux-btrace.h: Fix common/ includes.
9950         * nat/linux-btrace.c: Fix common/ includes.
9951         * nat/fork-inferior.c: Fix common/ includes.
9952         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9953         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9954         * nat/aarch64-linux.c: Fix common/ includes.
9955         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9956         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9957         * namespace.h: Fix common/ includes.
9958         * mips-linux-tdep.c: Fix common/ includes.
9959         * minsyms.c: Fix common/ includes.
9960         * mi/mi-parse.h: Fix common/ includes.
9961         * mi/mi-main.c: Fix common/ includes.
9962         * mi/mi-cmd-env.c: Fix common/ includes.
9963         * memrange.h: Fix common/ includes.
9964         * memattr.c: Fix common/ includes.
9965         * maint.h: Fix common/ includes.
9966         * maint.c: Fix common/ includes.
9967         * main.c: Fix common/ includes.
9968         * machoread.c: Fix common/ includes.
9969         * location.c: Fix common/ includes.
9970         * linux-thread-db.c: Fix common/ includes.
9971         * linux-nat.c: Fix common/ includes.
9972         * linux-fork.c: Fix common/ includes.
9973         * inline-frame.c: Fix common/ includes.
9974         * infrun.c: Fix common/ includes.
9975         * inflow.c: Fix common/ includes.
9976         * inferior.h: Fix common/ includes.
9977         * inferior.c: Fix common/ includes.
9978         * infcmd.c: Fix common/ includes.
9979         * inf-ptrace.c: Fix common/ includes.
9980         * inf-child.c: Fix common/ includes.
9981         * ia64-linux-nat.c: Fix common/ includes.
9982         * i387-tdep.c: Fix common/ includes.
9983         * i386-tdep.c: Fix common/ includes.
9984         * i386-linux-tdep.c: Fix common/ includes.
9985         * i386-linux-nat.c: Fix common/ includes.
9986         * i386-go32-tdep.c: Fix common/ includes.
9987         * i386-fbsd-tdep.c: Fix common/ includes.
9988         * i386-fbsd-nat.c: Fix common/ includes.
9989         * guile/scm-type.c: Fix common/ includes.
9990         * guile/guile.c: Fix common/ includes.
9991         * go32-nat.c: Fix common/ includes.
9992         * gnu-nat.c: Fix common/ includes.
9993         * gdbthread.h: Fix common/ includes.
9994         * gdbarch-selftests.c: Fix common/ includes.
9995         * gdb_usleep.c: Fix common/ includes.
9996         * gdb_select.h: Fix common/ includes.
9997         * gdb_bfd.c: Fix common/ includes.
9998         * gcore.c: Fix common/ includes.
9999         * fork-child.c: Fix common/ includes.
10000         * findvar.c: Fix common/ includes.
10001         * fbsd-nat.c: Fix common/ includes.
10002         * event-top.c: Fix common/ includes.
10003         * event-loop.c: Fix common/ includes.
10004         * dwarf2read.c: Fix common/ includes.
10005         * dwarf2loc.c: Fix common/ includes.
10006         * dwarf2-frame.c: Fix common/ includes.
10007         * dwarf-index-cache.c: Fix common/ includes.
10008         * dtrace-probe.c: Fix common/ includes.
10009         * disasm-selftests.c: Fix common/ includes.
10010         * defs.h: Fix common/ includes.
10011         * csky-tdep.c: Fix common/ includes.
10012         * cp-valprint.c: Fix common/ includes.
10013         * cp-support.h: Fix common/ includes.
10014         * cp-support.c: Fix common/ includes.
10015         * corelow.c: Fix common/ includes.
10016         * completer.h: Fix common/ includes.
10017         * completer.c: Fix common/ includes.
10018         * compile/compile.c: Fix common/ includes.
10019         * compile/compile-loc2c.c: Fix common/ includes.
10020         * compile/compile-cplus-types.c: Fix common/ includes.
10021         * compile/compile-cplus-symbols.c: Fix common/ includes.
10022         * command.h: Fix common/ includes.
10023         * cli/cli-dump.c: Fix common/ includes.
10024         * cli/cli-cmds.c: Fix common/ includes.
10025         * charset.c: Fix common/ includes.
10026         * build-id.c: Fix common/ includes.
10027         * btrace.h: Fix common/ includes.
10028         * btrace.c: Fix common/ includes.
10029         * breakpoint.h: Fix common/ includes.
10030         * breakpoint.c: Fix common/ includes.
10031         * ax.h:
10032         (enum agent_op): Fix common/ includes.
10033         * ax-general.c (struct aop_map): Fix common/ includes.
10034         * ax-gdb.c: Fix common/ includes.
10035         * auxv.c: Fix common/ includes.
10036         * auto-load.c: Fix common/ includes.
10037         * arm-tdep.c: Fix common/ includes.
10038         * arch/riscv.c: Fix common/ includes.
10039         * arch/ppc-linux-common.c: Fix common/ includes.
10040         * arch/i386.c: Fix common/ includes.
10041         * arch/arm.c: Fix common/ includes.
10042         * arch/arm-linux.c: Fix common/ includes.
10043         * arch/arm-get-next-pcs.c: Fix common/ includes.
10044         * arch/amd64.c: Fix common/ includes.
10045         * arch/aarch64.c: Fix common/ includes.
10046         * arch/aarch64-insn.c: Fix common/ includes.
10047         * arch-utils.c: Fix common/ includes.
10048         * amd64-windows-tdep.c: Fix common/ includes.
10049         * amd64-tdep.c: Fix common/ includes.
10050         * amd64-sol2-tdep.c: Fix common/ includes.
10051         * amd64-obsd-tdep.c: Fix common/ includes.
10052         * amd64-nbsd-tdep.c: Fix common/ includes.
10053         * amd64-linux-tdep.c: Fix common/ includes.
10054         * amd64-linux-nat.c: Fix common/ includes.
10055         * amd64-fbsd-tdep.c: Fix common/ includes.
10056         * amd64-fbsd-nat.c: Fix common/ includes.
10057         * amd64-dicos-tdep.c: Fix common/ includes.
10058         * amd64-darwin-tdep.c: Fix common/ includes.
10059         * agent.c: Fix common/ includes.
10060         * ada-lang.h: Fix common/ includes.
10061         * ada-lang.c: Fix common/ includes.
10062         * aarch64-tdep.c: Fix common/ includes.
10063
10064 2019-01-25  Tom Tromey  <tom@tromey.com>
10065
10066         * common/create-version.sh: Use common/version.h.
10067
10068 2019-01-24  Pedro Alves  <palves@redhat.com>
10069
10070         * infrun.c (signal_stop, signal_print, signal_program)
10071         (signal_catch, signal_pass): Now arrays instead of pointers.
10072         (update_signals_program_target, do_target_resume)
10073         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10074         * linux-nat.c (linux_nat_target::pass_signals)
10075         (linux_nat_target::create_inferior, linux_nat_target::attach):
10076         Adjust.
10077         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10078         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10079         * procfs.c (procfs_target::pass_signals): Adjust.
10080         * record-full.c (record_full_target::resume): Adjust.
10081         * remote.c (remote_target::pass_signals)
10082         (remote_target::program_signals): Adjust.
10083         * target-debug.h (target_debug_print_signals): Now takes a
10084         gdb::array_view as parameter.  Adjust.
10085         * target.h (target_ops) <pass_signals, program_signals>: Replace
10086         pointer and length parameters with gdb::array_view.
10087         (target_pass_signals, target_program_signals): Likewise.
10088         * target-delegates.c: Regenerate.
10089
10090 2019-01-24  Pedro Alves  <palves@redhat.com>
10091
10092         * common/forward-scope-exit.h
10093         (forward_scope_exit::forward_scope_exit): Pass arguments to
10094         m_bind_function directly, instead of creating a std::bind and
10095         copying that.
10096
10097 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10098
10099         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10100         for static members.
10101         (pass_in_v_vfp_candidate): Likewise.
10102
10103 2019-01-23  Tom Tromey  <tom@tromey.com>
10104             Pedro Alves  <palves@redhat.com>
10105
10106         * regcache.c (class regcache_invalidator): Remove.
10107         (regcache::raw_write): Use make_scope_exit.
10108
10109 2019-01-23  Tom Tromey  <tom@tromey.com>
10110
10111         * ui-out.h (class ui_out_emit_type): Update comment.
10112
10113 2019-01-23  Tom Tromey  <tom@tromey.com>
10114
10115         * infrun.c (fetch_inferior_event): Update comment.
10116
10117 2019-01-23  Tom Tromey  <tom@tromey.com>
10118             Pedro Alves  <palves@redhat.com>
10119
10120         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10121         parameter.
10122         (fetch_inferior_event): Use SCOPE_EXIT.
10123
10124
10125 2019-01-23  Tom Tromey  <tom@tromey.com>
10126             Pedro Alves  <palves@redhat.com>
10127
10128         * infrun.c (disable_thread_events): Delete.
10129         (stop_all_threads): Use SCOPE_EXIT.
10130
10131 2019-01-23  Tom Tromey  <tom@tromey.com>
10132             Pedro Alves  <palves@redhat.com>
10133
10134         * symfile.c: Include forward-scope-exit.h.
10135         (clear_symtab_users_cleanup): Replace forward declaration with
10136         a FORWARD_SCOPE_EXIT.
10137         (syms_from_objfile_1): Use the forward_scope_exit and
10138         gdb::optional instead of cleanup_function.
10139         (reread_symbols): Use the forward_scope_exit instead of
10140         cleanup_function.
10141         (clear_symtab_users_cleanup): Remove function.
10142
10143 2019-01-23  Tom Tromey  <tom@tromey.com>
10144             Pedro Alves  <palves@redhat.com>
10145
10146         * linux-nat.c: Include scope-exit.h.
10147         (cleanup_target_stop): Remove.
10148         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10149         SCOPE_EXIT.
10150
10151 2019-01-23  Tom Tromey  <tom@tromey.com>
10152             Pedro Alves  <palves@redhat.com>
10153
10154         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10155         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10156
10157 2019-01-23  Tom Tromey  <tom@tromey.com>
10158             Andrew Burgess  <andrew.burgess@embecosm.com>
10159             Pedro Alves  <palves@redhat.com>
10160
10161         * infrun.c (fetch_inferior_event): Use scope_exit.
10162         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10163         * top.c (execute_command): Use scope_exit.
10164         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10165         * utils.c (do_bpstat_clear_actions_cleanup)
10166         (make_bpstat_clear_actions_cleanup): Remove.
10167
10168 2019-01-23  Tom Tromey  <tom@tromey.com>
10169             Pedro Alves  <palves@redhat.com>
10170
10171         * infrun.c: Include "common/scope-exit.h"
10172         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10173         (wait_for_inferior): Use SCOPE_EXIT.
10174         (fetch_inferior_event): Use scope_exit.
10175
10176 2019-01-23  Tom Tromey  <tom@tromey.com>
10177             Pedro Alves  <palves@redhat.com>
10178
10179         * breakpoint.c (create_breakpoint): Remove cleanup.
10180
10181 2019-01-23  Tom Tromey  <tom@tromey.com>
10182             Andrew Burgess  <andrew.burgess@embecosm.com>
10183             Pedro Alves  <palves@redhat.com>
10184
10185 2019-01-23  Pedro Alves  <palves@redhat.com>
10186
10187         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10188
10189 2019-01-23  Pedro Alves  <palves@redhat.com>
10190             Andrew Burgess  <andrew.burgess@embecosm.com>
10191
10192         * gdbthread.h: Include "common/forward-scope-exit.h".
10193         (scoped_finish_thread_state): Redefine custom class in terms of
10194         forward_scope_exit.
10195
10196 2019-01-23  Pedro Alves  <palves@redhat.com>
10197             Andrew Burgess  <andrew.burgess@embecosm.com>
10198
10199         * common/forward-scope-exit.h: New file.
10200
10201 2019-01-23  Pedro Alves  <palves@redhat.com>
10202             Andrew Burgess  <andrew.burgess@embecosm.com>
10203             Tom Tromey  <tom@tromey.com>
10204
10205         * common/scope-exit.h: New file.
10206
10207 2019-01-23  Pedro Alves  <palves@redhat.com>
10208
10209         * common/preprocessor.h (ESC): Rename to ...
10210         (ESC_PARENS): ... this.
10211         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10212         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10213
10214 2019-01-23  Tom Tromey  <tom@tromey.com>
10215
10216         * language.h (class scoped_switch_to_sym_language_if_auto):
10217         Initialize m_lang in both cases.
10218
10219 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10220
10221         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10222         with XCNEW.
10223
10224 2019-01-22  Tom Tromey  <tom@tromey.com>
10225
10226         * corelow.c: Do not include sys/file.h.
10227
10228 2019-01-22  Tom Tromey  <tom@tromey.com>
10229
10230         * tui/tui-wingeneral.h: Include gdb_curses.h.
10231
10232 2019-01-22  Tom Tromey  <tom@tromey.com>
10233
10234         * source-cache.h (class source_cache) <get_source_lines,
10235         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10236
10237 2019-01-22  Tom Tromey  <tom@tromey.com>
10238
10239         * remote-fileio.h (struct remote_target): Declare.
10240
10241 2019-01-22  Tom Tromey  <tom@tromey.com>
10242
10243         * python/py-arch.c: Do not include py-ref.h.
10244         * python/py-bpevent.c: Do not include py-ref.h.
10245         * python/py-cmd.c: Do not include py-ref.h.
10246         * python/py-continueevent.c: Do not include py-ref.h.
10247         * python/py-event.h: Do not include py-ref.h.
10248         * python/py-evtregistry.c: Do not include py-ref.h.
10249         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10250         * python/py-frame.c: Do not include py-ref.h.
10251         * python/py-framefilter.c: Do not include py-ref.h.
10252         * python/py-function.c: Do not include py-ref.h.
10253         * python/py-infevents.c: Do not include py-ref.h.
10254         * python/py-linetable.c: Do not include py-ref.h.
10255         * python/py-objfile.c: Do not include py-ref.h.
10256         * python/py-param.c: Do not include py-ref.h.
10257         * python/py-prettyprint.c: Do not include py-ref.h.
10258         * python/py-progspace.c: Do not include py-ref.h.
10259         * python/py-symbol.c: Do not include py-ref.h.
10260         * python/py-symtab.c: Do not include py-ref.h.
10261         * python/py-type.c: Do not include py-ref.h.
10262         * python/py-unwind.c: Do not include py-ref.h.
10263         * python/py-utils.c: Do not include py-ref.h.
10264         * python/py-value.c: Do not include py-ref.h.
10265         * python/py-varobj.c: Do not include py-ref.h.
10266         * python/py-xmethods.c: Do not include py-ref.h.
10267         * python/python.c: Do not include py-ref.h.
10268         * varobj.c: Do not include py-ref.h.
10269
10270 2019-01-22  Tom Tromey  <tom@tromey.com>
10271
10272         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10273         keyword for bcache.
10274
10275 2019-01-22  Tom Tromey  <tom@tromey.com>
10276
10277         * compile/compile-cplus-types.c: Remove a comment by #include.
10278
10279 2019-01-22  Tom Tromey  <tom@tromey.com>
10280
10281         * compile/gcc-c-plugin.h: Include compile-internal.h.
10282
10283 2019-01-22  Tom Tromey  <tom@tromey.com>
10284
10285         * stabsread.c (EXTERN): Do not define.
10286         (symnum, next_symbol_text_func, processing_gcc_compilation)
10287         (within_function, global_sym_chain, global_stabs)
10288         (previous_stab_code, this_object_header_files)
10289         (n_this_object_header_files)
10290         (n_allocated_this_object_header_files): Define.
10291         * stabsread.h (EXTERN): Never define.  Use "extern".
10292
10293 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10294
10295         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10296         history_value.
10297
10298 2019-01-21  Tom Tromey  <tom@tromey.com>
10299
10300         * ui-out.c: Fix includes.
10301         * tui/tui-source.c: Fix includes.
10302         * target.c: Fix includes.
10303         * remote.c: Fix includes.
10304         * regcache.c: Fix includes.
10305         * python/py-block.c: Fix includes.
10306         * printcmd.c: Fix includes.
10307         * or1k-tdep.c: Fix includes.
10308         * mi/mi-main.c: Fix includes.
10309         * m32r-tdep.c: Fix includes.
10310         * csky-tdep.c: Fix includes.
10311         * compile/compile-cplus-types.c: Fix includes.
10312         * cli/cli-interp.c: Fix includes.
10313
10314 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10315
10316         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10317         for padding.
10318
10319 2019-01-16  Tom Tromey  <tom@tromey.com>
10320
10321         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10322         earlier.
10323         (struct objfile) <msymbols_range>: Move from top level.
10324         <msymbols>: New method.
10325         (class objfile_msymbols): Remove.
10326         * symtab.c (default_collect_symbol_completion_matches_break_on):
10327         Update.
10328         * symmisc.c (dump_msymbols): Update.
10329         * stabsread.c (scan_file_globals): Update.
10330         * objc-lang.c (info_selectors_command, info_classes_command)
10331         (find_methods): Update.
10332         * minsyms.c (find_solib_trampoline_target): Update.
10333         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10334         * coffread.c (coff_symfile_read): Update.
10335         * ada-lang.c (ada_lookup_simple_minsym)
10336         (ada_collect_symbol_completion_matches): Update.
10337
10338 2019-01-16  Tom Tromey  <tom@tromey.com>
10339
10340         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10341         type.  Remove no-argument constructor.
10342         <iterator::operator++>: Simplify.
10343         <begin>: Update.
10344         <end>: Use minimal_symbol_count.
10345
10346 2019-01-16  Tom Tromey  <tom@tromey.com>
10347
10348         * objfiles.h (struct objfile) <psymtabs>: New method.
10349         (class objfile_psymtabs): Remove.
10350         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10351         typedef.
10352         <range>: New method.
10353         (require_partial_symbols): Change return type.
10354         * psymtab.c (require_partial_symbols)
10355         (psym_expand_symtabs_matching): Update.
10356         * mdebugread.c (parse_partial_symbols): Update.
10357         * dbxread.c (dbx_end_psymtab): Update.
10358
10359 2019-01-15  Tom Tromey  <tom@tromey.com>
10360
10361         * symtab.c (lookup_objfile_from_block)
10362         (lookup_symbol_in_objfile_symtabs)
10363         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10364         (find_line_symtab, info_sources_command)
10365         (default_collect_symbol_completion_matches_break_on)
10366         (make_source_files_completion_list): Update.
10367         * symmisc.c (print_objfile_statistics, dump_objfile)
10368         (maintenance_print_symbols, maintenance_info_symtabs)
10369         (maintenance_check_symtabs, maintenance_info_line_tables):
10370         Update.
10371         * source.c (select_source_symtab)
10372         (forget_cached_source_info_for_objfile): Update.
10373         * objfiles.h (class objfile_compunits): Remove.
10374         (struct objfile) <compunits_range>: New typedef.
10375         (compunits): New method.
10376         * objfiles.c (objfile_relocate1): Update.
10377         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10378         * maint.c (count_symtabs_and_blocks): Update.
10379         * linespec.c (iterate_over_all_matching_symtabs): Update.
10380         * cp-support.c (add_symbol_overload_list_qualified): Update.
10381         * coffread.c (coff_symtab_read): Update.
10382         * ada-lang.c (add_nonlocal_symbols)
10383         (ada_collect_symbol_completion_matches)
10384         (ada_add_global_exceptions): Update.
10385
10386 2019-01-15  Tom Tromey  <tom@tromey.com>
10387
10388         * progspace.h (program_space) <objfiles_safe_range>: New
10389         typedef.
10390         <objfiles_safe>: New method.
10391         * objfiles.h (class all_objfiles_safe): Remove.
10392         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10393         * jit.c (jit_inferior_exit_hook): Update.
10394
10395 2019-01-17  Tom Tromey  <tom@tromey.com>
10396
10397         * progspace.h (program_space) <objfiles_range>: New typedef.
10398         <objfiles>: New method.
10399         <objfiles_head>: Rename from objfiles.
10400         (object_files): Update.
10401         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10402         * guile/scm-pretty-print.c
10403         (ppscm_find_pretty_printer_from_objfiles): Update.
10404         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10405         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10406         Update.
10407         * python/py-progspace.c (pspy_get_objfiles): Update.
10408         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10409         Update.
10410         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10411         (objfpy_lookup_objfile_by_build_id): Update.
10412         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10413         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10414         Update.
10415         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10416         (expand_symtab_containing_pc, lookup_objfile_from_block)
10417         (lookup_static_symbol, basic_lookup_transparent_type)
10418         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10419         (find_line_symtab, info_sources_command)
10420         (default_collect_symbol_completion_matches_break_on)
10421         (make_source_files_completion_list, find_main_name): Update.
10422         * symmisc.c (print_symbol_bcache_statistics)
10423         (print_objfile_statistics, maintenance_print_symbols)
10424         (maintenance_print_msymbols, maintenance_print_objfiles)
10425         (maintenance_info_symtabs, maintenance_check_symtabs)
10426         (maintenance_expand_symtabs, maintenance_info_line_tables):
10427         Update.
10428         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10429         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10430         (map_overlay_command, unmap_overlay_command)
10431         (simple_overlay_update, expand_symtabs_matching)
10432         (map_symbol_filenames): Update.
10433         * symfile-debug.c (set_debug_symfile): Update.
10434         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10435         Update.
10436         * source.c (select_source_symtab, forget_cached_source_info):
10437         Update.
10438         * solib.c (solib_read_symbols): Update.
10439         * solib-spu.c (append_ocl_sos): Update.
10440         * psymtab.c (maintenance_print_psymbols)
10441         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10442         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10443         * printcmd.c (info_symbol_command): Update.
10444         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10445         Update.
10446         * objfiles.h (class all_objfiles): Remove.
10447         * objfiles.c (have_partial_symbols, have_full_symbols)
10448         (have_minimal_symbols, qsort_cmp, update_section_map)
10449         (shared_objfile_contains_address_p)
10450         (default_iterate_over_objfiles_in_search_order): Update.
10451         * objc-lang.c (info_selectors_command, info_classes_command)
10452         (find_methods): Update.
10453         * minsyms.c (find_solib_trampoline_target): Update.
10454         * maint.c (maintenance_info_sections)
10455         (maintenance_translate_address, count_symtabs_and_blocks):
10456         Update.
10457         * main.c (captured_main_1): Update.
10458         * linux-thread-db.c (try_thread_db_load_from_pdir)
10459         (has_libpthread): Update.
10460         * linespec.c (iterate_over_all_matching_symtabs)
10461         (search_minsyms_for_name): Update.
10462         * jit.c (jit_find_objf_with_entry_addr): Update.
10463         * hppa-tdep.c (find_unwind_entry)
10464         (hppa_lookup_stub_minimal_symbol): Update.
10465         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10466         Update.
10467         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10468         (elf_gnu_ifunc_resolve_by_got): Update.
10469         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10470         * dwarf-index-write.c (save_gdb_index_command): Update.
10471         * cp-support.c (add_symbol_overload_list_qualified): Update.
10472         * breakpoint.c (create_overlay_event_breakpoint)
10473         (create_longjmp_master_breakpoint)
10474         (create_std_terminate_master_breakpoint)
10475         (create_exception_master_breakpoint): Update.
10476         * blockframe.c (find_pc_partial_function): Update.
10477         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10478         (ada_collect_symbol_completion_matches)
10479         (ada_add_global_exceptions): Update.
10480
10481 2019-01-17  Tom Tromey  <tom@tromey.com>
10482
10483         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10484         declare VEC.
10485         (solib_target_parse_libraries): Change return type.
10486         (library_list_start_segment, library_list_start_section)
10487         (library_list_end_library, library_list_start_library); Update.
10488         (solib_target_free_library_list): Remove.
10489         (solib_target_parse_libraries): Remove cleanup.  Change return
10490         type.
10491         (solib_target_current_sos): Update.
10492
10493 2019-01-17  Tom Tromey  <tromey@bapiya>
10494
10495         * valprint.c: Replace "the the" with "the".
10496         * symtab.c: Replace "the the" with "the".
10497         * solib.c: Replace "the the" with "the".
10498         * solib-dsbt.c: Replace "the the" with "the".
10499         * linespec.c: Replace "the the" with "the".
10500         * dwarf2loc.h: Replace "the the" with "the".
10501         * amd64-windows-tdep.c: Replace "the the" with "the".
10502         * aarch64-tdep.c: Replace "the the" with "the".
10503
10504 2019-01-16  Keith Seitz  <keiths@redhat.com>
10505
10506         PR gdb/23773
10507         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10508         <builder>: Rename to ..
10509         <m_builder>: ... this and make private.
10510         (dwarf2_cu::get_builder): New method.  Change all users of
10511         `builder' to use this method.
10512         (dwarf2_start_symtab): Move to ...
10513         (dwarf2_cu::start_symtab): ... here.  Update all callers
10514         (setup_type_unit_groups): Move to ...
10515         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10516         callers.
10517         (dwarf2_cu::reset_builder): New method.
10518         (process_full_compunit, process_full_type_unit): Use
10519         dwarf2_cu::reset_builder.
10520         (follow_die_offset): Record the ancestor CU if it is different
10521         from the followed DIE's CU.
10522         (follow_die_sig_1): Likewise.
10523
10524 2019-01-15  Tom Tromey  <tom@tromey.com>
10525
10526         * remote.c (class remote_state) <buf>: Now a char_vector.
10527         <buf_size>: Remove.
10528         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10529         parameter.
10530         (remote_target::getpkt_or_notif_sane_1)
10531         (remote_target::getpkt_sane)
10532         (remote_target::getpkt_or_notif_sane): Likewise.
10533         (class remote_target) <putpkt>: New overload.
10534         (remote_target::read_frame): Change type of "buf_p".  Remove
10535         sizeof_p parameter.
10536         (packet_ok): New overload.
10537         (packet_check_result): New overload.
10538         Update all uses.
10539
10540 2019-01-14  Tom Tromey  <tom@tromey.com>
10541
10542         * remote-notif.c (handle_notification, remote_notif_ack)
10543         (remote_notif_parse): Make "buf" const.
10544         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10545         const.
10546         (remote_notif_parse, remote_notif_ack, handle_notification):
10547         Likewise.
10548         * remote.c (remote_notif_stop_parse): Make "buf" const.
10549         (remote_target::remote_parse_stop_reply): Make "buf" const.
10550         (remote_notif_stop_ack): Make "buf" const.
10551
10552 2019-01-14  Tom Tromey  <tom@tromey.com>
10553
10554         * remote.c (remote_console_output): Make parameter const.
10555
10556 2019-01-14  Tom Tromey  <tom@tromey.com>
10557
10558         * target-debug.h (target_debug_print_signals): Constify.
10559         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10560         * procfs.c (procfs_target::pass_signals): Update.
10561         * linux-nat.c (linux_nat_target::pass_signals): Update.
10562         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10563         * target-delegates.c: Rebuild.
10564         * remote.c (remote_target::program_signals): Update.
10565         (remote_target::pass_signals): Update.
10566         * target.c (target_pass_signals): Constify argument.
10567         (target_program_signals): Likewise.
10568         * target.h (struct target_ops) <pass_signals, program_signals>:
10569         Constify argument.
10570         (target_pass_signals, target_program_signals): Constify argument.
10571
10572 2019-01-14  Tom Tromey  <tom@tromey.com>
10573
10574         PR tui/28819:
10575         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10576
10577 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10578
10579         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10580         field.
10581         * rs6000-tdep.c: Include reggroups.h.
10582         (IS_V_ALIAS_PSEUDOREG): Define.
10583         (rs6000_register_name): Return names for the "vX" aliases.
10584         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10585         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10586         aliases.  Call default_register_reggroup_p for all other
10587         pseudo-registers.
10588         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10589         New functions.
10590         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10591         Handle "vX" aliases.
10592         (v_alias_pseudo_register_collect): New function.
10593         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10594         (rs6000_gdbarch_init): Initialize "vX" aliases as
10595         pseudo-registers.  Restore registration of
10596         rs6000_pseudo_register_reggroup_p with
10597         set_tdesc_pseudo_register_reggroup_p.
10598
10599 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10600
10601         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10602         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10603         set_gdbarch_num_pseudo_regs.
10604
10605 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10606
10607         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10608         Remove arg prefixname, add do_set and do_show.
10609         Add member functions set_list and show_list.
10610         * cli/cli-style.c (class cli_style_option): Update accordingly.
10611         (style_set_list): Move to file scope.
10612         (style_show_list): Likewise.
10613         (set_style): Call help_list.
10614         (show_style): Call cmd_show_list.
10615         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10616         Update to use the new macro.
10617
10618 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10619
10620         * ada-lang.c (_initialize_ada_language): Expand the help text
10621         for the "catch exception" command.
10622
10623 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10624
10625         * symtab.c (matching_obj_sections): Initialize obj,
10626         declare it closer to its usage.
10627
10628 2019-01-10  Tom Tromey  <tom@tromey.com>
10629
10630         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10631         (basic_inf_threads_range): Remove.
10632         (inf_threads_range, inf_non_exited_threads_range)
10633         (safe_inf_threads_range): Use next_adapter.
10634
10635 2019-01-10  Keith Seitz  <keiths@redhat.com>
10636
10637         PR gdb/23712
10638         PR symtab/23010
10639         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10640         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10641
10642 2019-01-10  Keith Seitz  <keiths@redhat.com>
10643
10644         PR gdb/23712
10645         PR symtab/23010
10646         * dictionary.c (pending_to_vector): Remove.
10647         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10648         Remove _1 suffix, replacing functions of the same name.  Update
10649         all callers.
10650         (dict_create_hashed, dict_create_hashed_expandable)
10651         (dict_create_linear, dict_create_linear_expandable, dict_free)
10652         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10653         Make functions static.
10654
10655 2019-01-10  Keith Seitz  <keiths@redhat.com>
10656
10657         PR gdb/23712
10658         PR symtab/23010
10659         * dictionary.h (struct dictionary): Replace declaration with
10660         multidictionary.
10661         (dict_create_hashed, dict_create_hashed_expandable)
10662         (dict_create_linear, dict_create_linear_expandable)
10663         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10664         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10665         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10666         taking multidictionary argument.
10667         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10668         * block.h (struct block) <dict>: Change to multidictionary
10669         and rename `multidict'.
10670         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10671         symmisc.c: Update all dictionary references to multidictionary.
10672
10673 2019-01-10  Keith Seitz  <keiths@redhat.com>
10674
10675         PR gdb/23712
10676         PR symtab/23010
10677         * dictionary.c: Include unordered_map.
10678         (pending_to_vector): New function.
10679         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10680         Rewrite the non-"_1" functions to take vector instead
10681         of linked list.
10682         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10683         "new" _1 versions of the same name.
10684         (multidictionary): Define.
10685         (std::hash<enum language): New definition.
10686         (collate_pending_symbols_by_language, mdict_create_hashed)
10687         (mdict_create_hashed_expandable, mdict_create_linear)
10688         (mdict_create_linear_expandable, mdict_free)
10689         (find_language_dictionary, create_new_language_dictionary)
10690         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10691         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10692         (mdict_size, mdict_empty): New functions.
10693         * dictionary.h (mdict_iterator): Define.
10694
10695 2019-01-10  Pedro Alves  <palves@redhat.com>
10696
10697         * breakpoint.c (read_uploaded_action)
10698         (create_tracepoint_from_upload): Adjust to use
10699         gdb::unique_xmalloc_ptr.
10700         * ctf.c (ctf_write_uploaded_tp):
10701         (SET_ARRAY_FIELD): Use emplace_back.
10702         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10703         * tracefile-tfile.c (tfile_write_uploaded_tp):
10704         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10705         gdb::unique_xmalloc_ptr.
10706         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10707         at_string, cond_string, cmd_strings>: Replace char pointers
10708         with gdb::unique_xmalloc_ptr.
10709
10710 2019-01-10  Pedro Alves  <palves@redhat.com>
10711
10712         * solib-target.c (library_list_start_library): Don't xstrdup name.
10713
10714 2019-01-10  Pedro Alves  <palves@redhat.com>
10715
10716         * mdebugread.c (parse_partial_symbols): Use
10717         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10718
10719 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10720
10721         * linux-fork.c (scoped_switch_fork_info)
10722         <~scoped_switch_fork_info>: Fix incorrect variable name.
10723
10724 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10725
10726         * linux-fork.c (scoped_switch_fork_info)
10727         <scoped_switch_fork_info>: Make explicit.
10728         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10729
10730 2019-01-10  Tom Tromey  <tom@tromey.com>
10731
10732         * objfiles.h (objfile::reset_psymtabs): Update.
10733         * objfiles.c (objfile::objfile): Update.
10734         * psymtab.h (psymtab_storage::obstack): Update.
10735         (psymtab_storage::m_obstack): Use gdb::optional.
10736         (class psymtab_storage): Update comment.  Remove objfile
10737         parameter.
10738         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10739
10740 2019-01-10  Tom Tromey  <tom@tromey.com>
10741
10742         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10743         <free_psymtabs>: Now private.
10744         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10745         (allocate_psymtab): Use new method.
10746
10747 2019-01-10  Tom Tromey  <tom@tromey.com>
10748
10749         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10750         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10751         * mdebugread.c (parse_partial_symbols): Use
10752         allocate_dependencies.
10753         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10754         allocate_dependencies.
10755         (process_psymtab_comp_unit_reader)
10756         (build_type_psymtab_dependencies): Likewise.
10757         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10758
10759 2019-01-10  Tom Tromey  <tom@tromey.com>
10760
10761         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10762         PSYMBOL_SET_LANGUAGE.
10763         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10764
10765 2019-01-10  Tom Tromey  <tom@tromey.com>
10766
10767         * psymtab.h (psymtab_storage::obstack): New method.
10768         <m_obstack>: Rename from obstack; now private.
10769         * psymtab.c (psymtab_storage): Update.
10770         * dwarf2read.c (create_addrmap_from_index)
10771         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10772         Update.
10773
10774 2019-01-10  Tom Tromey  <tom@tromey.com>
10775
10776         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10777         * objfiles.h (objfile::reset_psymtabs): New method.
10778
10779 2019-01-10  Tom Tromey  <tom@tromey.com>
10780
10781         * symmisc.c (print_symbol_bcache_statistics): Update.
10782         (print_objfile_statistics): Update.
10783         * symfile.c (reread_symbols): Update.
10784         * psymtab.h (class psymtab_storage): New.
10785         * psymtab.c (psymtab_storage): New constructor.
10786         (~psymtab_storage): New destructor.
10787         (require_partial_symbols): Update.
10788         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10789         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10790         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10791         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10792         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10793         (start_psymtab_common, end_psymtab_common)
10794         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10795         (allocate_psymtab): Update.
10796         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10797         Update.
10798         (dump_psymtab_addrmap, maintenance_print_psymbols)
10799         (maintenance_check_psymtabs): Update.
10800         (class objfile_psymtabs): Move to objfiles.h.
10801         * psympriv.h (discard_psymtab): Now inline.
10802         (psymtab_discarder::psymtab_discarder): Update.
10803         (psymtab_discarder::~psymtab_discarder): Update.
10804         (ALL_OBJFILE_PSYMTABS): Rewrite.
10805         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10806         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10807         Remove fields.
10808         <partial_symtabs>: New field.
10809         (class objfile_psymtabs): Move from psymtab.h.  Update.
10810         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10811         psymbol_cache.
10812         (objfile::~objfile): Don't destroy psymbol_cache.
10813         * mdebugread.c (parse_partial_symbols): Update.
10814         * dwarf2read.c (create_addrmap_from_index)
10815         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10816         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10817         (add_partial_subprogram, dwarf2_ranges_read): Update.
10818         * dwarf-index-write.c (write_address_map)
10819         (write_one_signatured_type, recursively_write_psymbols)
10820         (class debug_names, class debug_names, write_psymtabs_to_index):
10821         Update.
10822
10823 2019-01-10  Tom Tromey  <tom@tromey.com>
10824
10825         * symtab.h (SYMBOL_SET_NAMES): Update.
10826         (symbol_set_names): Update.
10827         (MSYMBOL_SET_NAMES): Update.
10828         * symtab.c (symbol_set_names): Change argument to be an
10829         objfile_per_bfd_storage.
10830         * psymtab.c (add_psymbol_to_bcache): Update.
10831         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10832
10833 2019-01-10  Tom Tromey  <tom@tromey.com>
10834
10835         * symtab.c (create_demangled_names_hash): Change argument to be an
10836         objfile_per_bfd_storage.
10837         (symbol_set_names): Update.
10838
10839 2019-01-10  Tom Tromey  <tom@tromey.com>
10840
10841         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10842         init_psymbol_list.
10843         * psymtab.c (init_psymbol_list): Do nothing if already called.
10844         * psympriv.h (init_psymbol_list): Add comment.
10845         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10846         init_psymbol_list.
10847         * dbxread.c (dbx_symfile_read): Unconditionally call
10848         init_psymbol_list.
10849
10850 2019-01-10  Tom Tromey  <tom@tromey.com>
10851
10852         * xcoffread.c (scan_xcoff_symtab): Update.
10853         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10854         "where".
10855         * mdebugread.c (parse_partial_symbols)
10856         (handle_psymbol_enumerators): Update.
10857         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10858         * dbxread.c (read_dbx_symtab): Update.
10859         * psympriv.h (psymbol_placement): New enum.
10860         (add_psymbol_to_list): Update.
10861
10862 2019-01-10  Tom Tromey  <tom@tromey.com>
10863
10864         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10865         static_psymbols parameters.
10866         (scan_xcoff_symtab): Update.
10867         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10868         static_psymbols parameters.
10869         * psympriv.h (start_psymtab_common): Update.
10870         * mdebugread.c (parse_partial_symbols): Update.
10871         * dwarf2read.c (create_partial_symtab): Update.
10872         * dbxread.c (read_dbx_symtab): Update.
10873         (start_psymtab): Remove global_psymbols and static_psymbols
10874         parameters.
10875
10876 2019-01-10  Tom Tromey  <tom@tromey.com>
10877
10878         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10879         * psymtab.c (allocate_psymtab): Add comment.
10880         * psympriv.h (allocate_psymtab): Add comment.
10881         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10882         initializations.
10883         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10884
10885 2019-01-10  Tom Tromey  <tom@tromey.com>
10886
10887         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10888         Don't declare.
10889         * mipsread.c: Include mdebugread.h.
10890         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10891         Declare.
10892         * elfread.c: Include mdebugread.h.
10893
10894 2019-01-09  Tom Tromey  <tom@tromey.com>
10895
10896         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10897         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10898         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10899         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10900         (psym_lookup_symbol, psym_find_last_source_symtab)
10901         (psym_forget_cached_source_info, psym_print_stats)
10902         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10903         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10904         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10905         (psym_find_compunit_symtab_by_address)
10906         (maintenance_print_psymbols, maintenance_info_psymtabs)
10907         (maintenance_check_psymtabs): Use ranged for.
10908         * psymtab.h (class objfile_psymtabs): New.
10909         (require_partial_symbols): Return objfile_psymtabs.
10910         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10911
10912 2019-01-09  Tom Tromey  <tom@tromey.com>
10913
10914         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10915         (find_pc_mapped_section, list_overlays_command)
10916         (map_overlay_command, unmap_overlay_command)
10917         (simple_overlay_update): Use all_objfiles.
10918         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10919         * printcmd.c (info_symbol_command): Use all_objfiles.
10920         * objfiles.h (ALL_OBJSECTIONS): Remove.
10921         * maint.c (maintenance_translate_address): Use all_objfiles.
10922         * gcore.c (gcore_create_callback): Use all_objfiles.
10923         (objfile_find_memory_regions): Likewise.
10924
10925 2019-01-09  Tom Tromey  <tom@tromey.com>
10926
10927         * symtab.c (find_line_symtab, info_sources_command)
10928         (make_source_files_completion_list): Use objfile_compunits.
10929         * source.c (select_source_symtab): Use objfile_compunits.
10930         * objfiles.h (struct objfile): Update comment.
10931         (ALL_OBJFILES): Remove.
10932         (ALL_FILETABS): Remove.
10933         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10934         objfile_compunits.
10935
10936 2019-01-09  Tom Tromey  <tom@tromey.com>
10937
10938         * symmisc.c (print_objfile_statistics, dump_objfile)
10939         (maintenance_print_symbols): Use compunit_filetabs.
10940         * source.c (forget_cached_source_info_for_objfile): Use
10941         compunit_filetabs.
10942         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10943         (ALL_FILETABS): Use compunit_filetabs.
10944         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10945         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10946
10947 2019-01-09  Tom Tromey  <tom@tromey.com>
10948
10949         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10950         (compunit_filetabs): New.
10951         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10952         compunit_filetabs.
10953         (info_sources_command, make_source_files_completion_list): Remove
10954         declaration.
10955         * symmisc.c (print_objfile_statistics, dump_objfile)
10956         (maintenance_print_symbols): Remove declaration.
10957         (maintenance_info_symtabs): Use compunit_filetabs.
10958         (maintenance_info_line_tables): Likewise.
10959         * source.c (select_source_symtab): Change local variable name.
10960         (forget_cached_source_info_for_objfile): Remove declaration.
10961         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10962         * objfiles.c (objfile_relocate1): Remove declaration.
10963         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10964         declaration.
10965         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10966         * coffread.c (coff_symtab_read): Remove declaration.
10967         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10968         compunit_filetabs.
10969
10970 2019-01-09  Tom Tromey  <tom@tromey.com>
10971
10972         * symtab.c (lookup_objfile_from_block)
10973         (find_pc_sect_compunit_symtab, search_symbols)
10974         (default_collect_symbol_completion_matches_break_on): Use
10975         objfile_compunits.
10976         * objfiles.h (ALL_COMPUNITS): Remove.
10977         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10978         * cp-support.c (add_symbol_overload_list_qualified): Use
10979         objfile_compunits.
10980         * ada-lang.c (ada_collect_symbol_completion_matches)
10981         (ada_add_global_exceptions): Use objfile_compunits.
10982
10983 2019-01-09  Tom Tromey  <tom@tromey.com>
10984
10985         * source.c (select_source_symtab)
10986         (forget_cached_source_info_for_objfile): Remove declaration.
10987         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10988         declaration.
10989         * maint.c (count_symtabs_and_blocks): Remove declaration.
10990         * cp-support.c (add_symbol_overload_list_qualified): Remove
10991         declaration.
10992         * coffread.c (coff_symtab_read): Remove declaration.
10993         * symtab.c (lookup_symbol_in_objfile_symtabs)
10994         (basic_lookup_transparent_type_1): Use objfile_compunits.
10995         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10996         (info_sources_command, search_symbols)
10997         (default_collect_symbol_completion_matches_break_on)
10998         (make_source_files_completion_list): Remove declaration.
10999         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11000         (ada_collect_symbol_completion_matches)
11001         (ada_add_global_exceptions): Remove declaration.
11002         * linespec.c (iterate_over_all_matching_symtabs): Use
11003         objfile_compunits.
11004         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11005         (class objfile_compunits): New.
11006         (ALL_COMPUNITS): Use objfile_compunits.
11007         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11008         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11009         objfile_compunits.
11010         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11011
11012 2019-01-09  Tom Tromey  <tom@tromey.com>
11013
11014         * symtab.c (search_symbols)
11015         (default_collect_symbol_completion_matches_break_on): Use
11016         objfile_msymbols.
11017         * ada-lang.c (ada_lookup_simple_minsym)
11018         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11019         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11020         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11021         objfile_msymbols.
11022         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11023         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11024         * objc-lang.c (find_methods): Use objfile_msymbols.
11025         (info_selectors_command, info_classes_command): Likewise.
11026         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11027         * objfiles.h (class objfile_msymbols): New.
11028         (ALL_OBJFILE_MSYMBOLS): Remove.
11029         (ALL_MSYMBOLS): Remove.
11030
11031 2019-01-09  Tom Tromey  <tom@tromey.com>
11032
11033         * common/next-iterator.h (next_adapter): Add Iterator template
11034         parameter.
11035         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11036         (class all_objfiles_safe): New.
11037         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11038         * objfiles.c (put_objfile_before): Update comment.
11039         (add_separate_debug_objfile): Likewise.
11040         (free_all_objfiles): Use all_objfiles_safe.
11041         (objfile_purge_solibs): Likewise.
11042
11043 2019-01-09  Tom Tromey  <tom@tromey.com>
11044
11045         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11046         (expand_symtab_containing_pc, lookup_static_symbol)
11047         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11048         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11049         all_objfiles.
11050         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11051         * breakpoint.c (create_overlay_event_breakpoint)
11052         (create_longjmp_master_breakpoint)
11053         (create_std_terminate_master_breakpoint)
11054         (create_exception_master_breakpoint): Use all_objfiles.
11055         * linux-thread-db.c (try_thread_db_load_from_pdir)
11056         (has_libpthread): Use all_objfiles.
11057         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11058         * linespec.c (iterate_over_all_matching_symtabs)
11059         (search_minsyms_for_name): Use all_objfiles.
11060         * maint.c (maintenance_info_sections): Use all_objfiles.
11061         * main.c (captured_main_1): Use all_objfiles.
11062         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11063         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11064         * guile/scm-pretty-print.c
11065         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11066         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11067         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11068         (maintenance_print_msymbols): Use all_objfiles.
11069         * source.c (select_source_symtab): Use all_objfiles.
11070         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11071         * symfile.c (remove_symbol_file_command)
11072         (expand_symtabs_matching, map_symbol_filenames): Use
11073         all_objfiles.
11074         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11075         all_objfiles.
11076         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11077         * objc-lang.c (find_methods): Use all_objfiles.
11078         * objfiles.c (have_partial_symbols, have_full_symbols)
11079         (have_minimal_symbols, qsort_cmp)
11080         (default_iterate_over_objfiles_in_search_order): Use
11081         all_objfiles.
11082         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11083         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11084         (maintenance_check_psymtabs): Use all_objfiles.
11085         (ALL_PSYMTABS): Remove.
11086         * compile/compile-object-run.c (do_module_cleanup): Use
11087         all_objfiles.
11088         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11089         * cp-support.c (add_symbol_overload_list_qualified): Use
11090         all_objfiles.
11091         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11092         Use all_objfiles.
11093         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11094         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11095         all_objfiles.
11096         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11097         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11098         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11099         Uses all_objfiles.
11100         * solib.c (solib_read_symbols): Use all_objfiles
11101
11102 2019-01-09  Tom Tromey  <tom@tromey.com>
11103
11104         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11105         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11106         all_objfiles.
11107         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11108         * symmisc.c (print_symbol_bcache_statistics)
11109         (print_objfile_statistics, maintenance_print_objfiles)
11110         (maintenance_info_symtabs, maintenance_check_symtabs)
11111         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11112         all_objfiles.
11113         * source.c (forget_cached_source_info): Use all_objfiles.
11114         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11115         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11116         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11117         * objfiles.c (update_section_map): Use all_objfiles.
11118         (shared_objfile_contains_address_p): Likewise.
11119         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11120         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11121
11122 2019-01-09  Tom Tromey  <tom@tromey.com>
11123
11124         * common/next-iterator.h: New file.
11125         * objfiles.h (class all_objfiles): New.
11126         (struct objfile_iterator): New.
11127
11128 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11129
11130         * NEWS: Move the description of the changed "frame", "select-frame",
11131          and "info frame" commands to the Changed commands section.
11132
11133 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11134
11135         * gdbtypes.c (check_stub_method_group): Remove handling of old
11136         mangling schemes.
11137         * linespec.c (find_methods): Likewise.
11138         * stabsread.c (read_member_functions): Likewise.
11139         * valops.c (search_struct_method): Likewise.
11140         (value_struct_elt_for_reference): Likewise.
11141         * NEWS: Mention this change.
11142
11143 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11144
11145         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11146         print_source_lines.
11147         * source.c (print_source_lines_base): Update line number check.
11148         (print_source_lines): New function.
11149         (source_lines_range::source_lines_range): New function.
11150         * source.h (class source_lines_range): New class.
11151         (print_source_lines): New declaration.
11152
11153 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11154
11155         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11156
11157 2019-01-08  Tom Tromey  <tom@tromey.com>
11158             Simon Marchi  <simon.marchi@ericsson.com>
11159
11160         PR gdb/24060
11161         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11162         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11163         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11164         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11165         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11166         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11167
11168 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11169
11170         * source.c (select_source_symtab): Move header comment to
11171         declaration in source.h.
11172         (forget_cached_source_info_for_objfile): Likewise.
11173         (forget_cached_source_info): Likewise.
11174         (identify_source_line): Likewise.
11175         * source.h (identify_source_line): Move declaration from symtab.h
11176         and add comment from source.c
11177         (print_source_lines): Likewise.
11178         (forget_cached_source_info_for_objfile): Likewise.
11179         (forget_cached_source_info): Likewise.
11180         (select_source_symtab): Likewise.
11181         (enum print_source_lines_flag): Move definition from symtab.h.
11182         * symtab.h (identify_source_line): Move declaration to source.h.
11183         (print_source_lines): Likewise.
11184         (forget_cached_source_info_for_objfile): Likewise.
11185         (forget_cached_source_info): Likewise.
11186         (select_source_symtab): Likewise.
11187         (enum print_source_lines_flag): Move definition to source.h.
11188         * tui/tui-hooks.c: Add 'source.h' include.
11189
11190 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11191
11192         * source.c (print_source_lines_base): Handle requests to print
11193         reverse line number sequences, and guard against empty lines
11194         string.
11195
11196 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11197
11198         * source.c (print_source_lines_base): Fix skip of '\r' if next
11199         character is '\n'.
11200
11201 2019-01-06  Tom Tromey  <tom@tromey.com>
11202
11203         * c-exp.y (struct c_parse_state) <macro_original_text,
11204         expansion_obstack>: New member.
11205         (macro_original_text, expansion_obstack): Remove globals.
11206         (scan_macro_expansion, scanning_macro_expansion)
11207         (finished_macro_expansion): Update.
11208         (scan_macro_cleanup): Remove.
11209         (yylex, c_parse): Update.
11210
11211 2019-01-06  Tom Tromey  <tom@tromey.com>
11212
11213         * c-exp.y (struct c_parse_state) <strings>: New member.
11214         (operator_stoken): Update.
11215
11216 2019-01-06  Tom Tromey  <tom@tromey.com>
11217
11218         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11219         (union type_stack_elt) <typelist_val>: Now a pointer to
11220         std::vector.
11221         (type_stack_cleanup): Don't declare.
11222         (push_typelist): Update.
11223         * parse.c (pop_typelist): Return a std::vector.
11224         (push_typelist): Take a std::vector.
11225         (follow_types): Update.  Do not free args.
11226         (type_stack_cleanup): Remove.
11227         * c-exp.y (struct c_parse_state): New.
11228         (cpstate): New global.
11229         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11230         (nonempty_typelist): Update.
11231         (func_mod): Create a new vector.
11232         (c_parse): Create a c_parse_state.
11233         (check_parameter_typelist): Do not delete params.
11234         (function_method): Update.  Do not delete type_list.
11235
11236 2019-01-06  Tom Tromey  <tom@tromey.com>
11237
11238         PR gdb/28155:
11239         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11240         check_typedef.
11241         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11242         (print_return_value): Likewise.
11243
11244 2019-01-05  Tom Tromey  <tom@tromey.com>
11245
11246         * contrib/cleanup_check.py: Remove.
11247         * contrib/gcc-with-excheck: Remove.
11248         * contrib/exsummary.py: Remove.
11249         * contrib/excheck.py: Remove.
11250
11251 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11252
11253         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11254         NULL. Initialize tpprev to NULL instead of assigning it
11255         to NULL on the next statement.
11256         * windows-nat.c (windows_delete_thread): Remove check for
11257         main_thread_id before printing thread exit notifications.
11258         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11259         Remove thread ID check against main_thread_id.
11260         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11261         windows_delete_thread.
11262         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11263
11264 2019-01-04  Tom Tromey  <tom@tromey.com>
11265
11266         * compile/compile.c (_initialize_compile): Use upper case for
11267         metasyntactic variables.
11268         * symmisc.c (_initialize_symmisc): Use upper case for
11269         metasyntactic variables.
11270         * psymtab.c (_initialize_psymtab): Use upper case for
11271         metasyntactic variables.
11272         * demangle.c (demangle_command): Use upper case for metasyntactic
11273         variables.
11274         (_initialize_demangler): Likewise.
11275         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11276         variables.
11277
11278 2019-01-03  Tom Tromey  <tom@tromey.com>
11279
11280         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11281
11282 2019-01-03  Tom Tromey  <tom@tromey.com>
11283
11284         * python/py-symtab.c (salpy_str): Update.
11285         (struct salpy_sal_object) <symtab>: Now a PyObject.
11286         (salpy_dealloc): Update.
11287         (del_objfile_sal): Use gdbpy_ref.
11288
11289 2019-01-03  Tom Tromey  <tom@tromey.com>
11290
11291         * python/py-type.c (convert_field): Use new_reference.  Return
11292         gdbpy_ref.
11293         (make_fielditem): Return gdbpy_ref.
11294         (typy_fields): Update.
11295         (typy_getitem): Update.
11296         (field_name): Return gdbpy_ref.  Use new_reference.
11297         (typy_iterator_iternext): Update.
11298
11299 2019-01-03  Tom Tromey  <tom@tromey.com>
11300
11301         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11302
11303 2019-01-03  Tom Tromey  <tom@tromey.com>
11304
11305         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11306         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11307         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11308         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11309         (pspy_set_type_printers): Likewise.
11310         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11311         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11312         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11313         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11314         (objfpy_set_type_printers): Likewise.
11315
11316 2019-01-03  Tom Tromey  <tom@tromey.com>
11317
11318         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11319         (gdbpy_print_stack): Use gdbpy_err_fetch.
11320         * python/python-internal.h (class gdbpy_err_fetch): New class.
11321         (class gdbpy_enter) <m_error_type, m_error_value,
11322         m_error_traceback>: Remove.
11323         <m_error>: New member.
11324         (gdbpy_exception_to_string): Don't declare.
11325         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11326         * python/py-value.c (convert_value_from_python): Use
11327         gdbpy_err_fetch.
11328         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11329         gdbpy_exception_to_string.
11330         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11331         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11332         gdbpy_err_fetch.
11333
11334 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11335
11336         * linux-nat.c (delete_lwp_cleanup): Delete.
11337         (struct lwp_deleter): New struct.
11338         (lwp_info_up): New typedef.
11339         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11340         lwp_info_up.
11341
11342 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11343
11344         * linux-fork.c (class scoped_switch_fork_info): New class.
11345         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11346
11347 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11348
11349         * valops.c (find_overload_match): Remove use of null_cleanup, and
11350         calls to do_cleanups.
11351
11352 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11353
11354         * compile/compile-cplus-types.c
11355         (compile_cplus_instance::decl_name): Handle changes to
11356         cp_func_name.
11357         * cp-support.c (cp_func_name): Update header comment, update
11358         return type.
11359         * cp-support.h (cp_func_name): Update return type in declaration.
11360         * valops.c (find_overload_match): Move temp_func local to top
11361         level of function and change its type.  Use temp_func to hold and
11362         delete temporary string obtained from cp_func_name.
11363
11364 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11365
11366         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11367         gdb::char_vector, remove cleanup, and update uses of `msg`.
11368
11369 2019-01-03  Jim Wilson  <jimw@sifive.com>
11370
11371         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11372
11373 2019-01-02  Tom Tromey  <tom@tromey.com>
11374
11375         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11376         (tdesc_parse_xml): Remove cleanups.
11377         * target-descriptions.h (make_cleanup_free_target_description):
11378         Don't declare.
11379         (target_desc_deleter): New struct.
11380         (target_desc_up): New typedef.
11381         * target-descriptions.c (target_desc_deleter::operator()): Rename
11382         from free_target_description.
11383         (make_cleanup_free_target_description): Remove.
11384
11385 2019-01-02  Tom Tromey  <tom@tromey.com>
11386
11387         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11388         constructor, destructor.
11389         (linespec_parser): Remove typedef.
11390         (~linespec_parser): Rename from linespec_parser_delete.
11391         (linespec_lex_to_end, linespec_complete_label)
11392         (linespec_complete): Update.
11393         (decode_line_full): Remove cleanups.
11394         (decode_line_1): Update.
11395
11396 2019-01-02  Tom Tromey  <tom@tromey.com>
11397
11398         * python/python-internal.h (inferior_to_inferior_object): Change
11399         return type.
11400         * python/py-exitedevent.c (create_exited_event_object): Update.
11401         * python/py-inferior.c (inferior_to_inferior_object): Return
11402         gdbpy_ref.
11403         (python_new_inferior, python_inferior_deleted)
11404         (thread_to_thread_object, delete_thread_object)
11405         (build_inferior_list, gdbpy_selected_inferior): Update.
11406         * python/py-infthread.c (create_thread_object): Update.  Also fail
11407         if inferior_to_inferior_object fails.
11408
11409 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11410
11411         * inferior.h (class inferior) <displaced_step_state>: New field.
11412         * infrun.h (struct displaced_step_state): Move here from
11413         infrun.c.  Initialize fields, add constructor.
11414         <inf>: Remove field.
11415         <reset>: New method.
11416         * infrun.c (struct displaced_step_inferior_state): Move to
11417         infrun.h.
11418         (displaced_step_inferior_states): Remove.
11419         (get_displaced_stepping_state): Adust.
11420         (displaced_step_in_progress_any_inferior): Adjust.
11421         (displaced_step_in_progress_thread): Adjust.
11422         (displaced_step_in_progress): Adjust.
11423         (add_displaced_stepping_state): Remove.
11424         (get_displaced_step_closure_by_addr): Adjust.
11425         (remove_displaced_stepping_state): Remove.
11426         (infrun_inferior_exit): Call displaced_step_state.reset.
11427         (use_displaced_stepping): Don't check for NULL.
11428         (displaced_step_prepare_throw): Call
11429         get_displaced_stepping_state.
11430         (displaced_step_fixup): Don't check for NULL.
11431         (prepare_for_detach): Don't check for NULL.
11432
11433 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11434
11435         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11436          in case of call that did not complete.
11437
11438 2019-01-02  Andrey Utkin  <autkin@undo.io>
11439
11440         * symfile.c (find_separate_debug_file): Fix search of debug files for
11441         remote debuggee.
11442
11443 2019-01-02  Tom Tromey  <tom@tromey.com>
11444
11445         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11446         indentation.
11447         * python/py-frame.c (frapy_older): Remove cast.
11448         (frapy_newer): Likewise.
11449         * python/py-breakpoint.c (local_setattro): Remove cast.
11450         * python/py-arch.c (archpy_name): Remove local variable.
11451         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11452
11453 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11454
11455         * unittests/basic_string_view/element_access/char/empty.cc:
11456         Fix year range in copyright header.
11457
11458 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11459
11460         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11461         Delete.
11462         <operator==>: Update with for removed field.
11463         <hash>: Likewise.
11464         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11465         <isa_features>: ...this.
11466         <abi_features>: New field.
11467         (riscv_isa_flen): Update comment.
11468         (riscv_abi_xlen): New declaration.
11469         (riscv_abi_flen): New declaration.
11470         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11471         isa_features.
11472         (riscv_abi_xlen): New function.
11473         (riscv_isa_flen): Update to get answer from isa_features.
11474         (riscv_abi_flen): New function.
11475         (riscv_has_fp_abi): Update to get answer from abi_features.
11476         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11477         xlen and flen.
11478         (riscv_call_info) <xlen, flen>: Update comment.
11479         (riscv_call_arg_struct): Remove invalid assertions
11480         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11481         is removed.
11482         (riscv_gdbarch_init): Gather isa features and abi features
11483         separately, ensure both match on the gdbarch when reusing an old
11484         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11485         a target with 64-bit float hardware.
11486
11487 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11488
11489         * source.c (search_command_helper): Stop reverse search
11490         when line 1 has been searched.
11491
11492 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11493
11494         * record-full.c (record_full_base_target::close): Rewrite
11495         record_full_core_buf_list free logic.
11496
11497 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11498
11499         * break-catch-syscall.c (print_one_catch_syscall): xfree
11500         the last text.
11501
11502 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11503
11504         * top.c (print_gdb_version): Update Copyright year in version
11505         message.
11506
11507 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11508
11509         Update copyright year range in all GDB files.
11510
11511 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11512
11513         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11514
11515 For older changes see ChangeLog-2018.
11516 \f
11517 Local Variables:
11518 mode: change-log
11519 left-margin: 8
11520 fill-column: 74
11521 version-control: never
11522 coding: utf-8
11523 End:
11524