gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.h (struct tui_data_item_window): Move from
   4         tui-data.h.
   5         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
   6         * tui/tui-data.h (struct tui_data_item_window): Move to
   7         tui-regs.h.
   8         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
   9
  10 2019-07-17  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui.c: Update.
  13         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
  14         (tui_cmd_window::max_height): Move to tui-command.c.
  15         * tui/tui-layout.c: Update.
  16         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
  17         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
  18         tui-command.c.
  19         * tui/tui-command.h (struct tui_cmd_window): Move from
  20         tui-data.h.
  21         * tui/tui-command.c: Remove "structuring" comments.
  22         (tui_cmd_window::clear_detail)
  23         (tui_cmd_window::do_make_visible_with_new_height)
  24         (tui_cmd_window::max_height): Move from elsewhere.
  25
  26 2019-07-17  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
  29         Now static.
  30         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
  31         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
  32
  33 2019-07-17  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui.c: Update.
  36         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
  37         tui-regs.c.
  38         * tui/tui-windata.h: Remove file.
  39         * tui/tui-windata.c: Remove file.
  40         * tui/tui-win.c (tui_data_window::set_new_height)
  41         (tui_data_window::do_make_visible_with_new_height): Move to
  42         tui-regs.c.
  43         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
  44         * tui/tui-regs.c: Remove "structuring" comments.
  45         (tui_data_window::first_data_item_displayed)
  46         (tui_data_window::delete_data_content_windows)
  47         (tui_data_window::erase_data_content)
  48         (tui_data_window::display_all_data)
  49         (tui_data_window::refresh_all)
  50         (tui_data_window::do_scroll_vertical)
  51         (tui_data_window::clear_detail, tui_data_window::set_new_height)
  52         (tui_data_window::do_make_visible_with_new_height)
  53         (tui_data_window::refresh_window): Move from elsewhere.
  54         (_initialize_tui_regs): Move to end of file.
  55         * tui/tui-layout.c: Update.
  56         * tui/tui-hooks.c: Update.
  57         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
  58         * tui/tui-data.c (tui_data_window::clear_detail): Move to
  59         tui-regs.c.
  60         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
  61
  62 2019-07-17  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
  65         seen.
  66
  67 2019-07-17  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui-win.c (tui_source_window_base::set_new_height)
  70         (tui_source_window_base::do_make_visible_with_new_height): Use
  71         m_has_locator field directly.
  72         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
  73         method.
  74         (struct tui_source_window_base) <has_locator>: Likewise.
  75
  76 2019-07-17  Tom Tromey  <tom@tromey.com>
  77
  78         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
  79         Don't declare.
  80         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
  81         Remove.
  82         * tui/tui-win.c (tui_source_window_base::set_new_height)
  83         (tui_source_window_base::set_new_height)
  84         (make_invisible_and_set_new_height)
  85         (tui_source_window_base::do_make_visible_with_new_height)
  86         (tui_source_window_base::do_make_visible_with_new_height):
  87         Update.
  88         * tui/tui-layout.c (show_source_disasm_command, show_data)
  89         (show_source_or_disasm_and_command): Update.
  90         * tui/tui-layout.c (show_layout): Update.
  91
  92 2019-07-17  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-layout.c (make_data_window): Remove.
  95         (show_data): Unify creation and re-initialization cases.
  96
  97 2019-07-17  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-layout.c (make_source_window, make_disasm_window):
 100         Remove.
 101         (show_data): Unify creation and re-initialization cases.
 102
 103 2019-07-17  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui-layout.c (make_command_window): Remove.
 106         (show_source_disasm_command, show_source_or_disasm_and_command):
 107         Unify creation and re-initialization cases.
 108
 109 2019-07-17  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 112         creation and re-initialization cases.
 113
 114 2019-07-17  Tom Tromey  <tom@tromey.com>
 115
 116         * tui/tui-regs.c (tui_get_register): Return void.
 117
 118 2019-07-17  Tom Tromey  <tom@tromey.com>
 119
 120         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 121         Simplify.
 122
 123 2019-07-17  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 126         resetting.
 127
 128 2019-07-17  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 131         * tui/tui-regs.c (tui_reg_layout): New function.
 132         (tui_show_registers, tui_reg_command): Use it.
 133         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 134         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 135         parameters.
 136         (tui_layout_command): Remove.
 137
 138 2019-07-17  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-layout.h (tui/tui-layout): Return void.
 141         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 142
 143 2019-07-17  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-layout.c (show_source_disasm_command, show_data):
 146         Update.
 147         (reset_locator): Remove.
 148         (show_source_or_disasm_and_command): Update.
 149
 150 2019-07-17  Tom Tromey  <tom@tromey.com>
 151
 152         * tui/tui-source.c (tui_source_window_base::reset): Remove
 153         win_type parameter.
 154         * tui/tui-layout.c (make_command_window, make_source_window)
 155         (make_disasm_window, make_data_window)
 156         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 157         (reset_locator, show_source_or_disasm_and_command): Update.
 158         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 159         win_type parameter.
 160         (struct tui_source_window_base) <reset>: Likewise.
 161
 162 2019-07-17  Tom Tromey  <tom@tromey.com>
 163
 164         * tui/tui-layout.c (show_source_disasm_command): Use
 165         reset_locator.
 166         (reset_locator): New function.
 167         (init_and_make_win): Remove.
 168         (show_source_or_disasm_and_command): Use reset_locator.
 169
 170 2019-07-17  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 173         condition.
 174         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 175         Remove condition.
 176         * tui/tui-source.c (tui_source_window_base::reset): New method.
 177         * tui/tui-layout.c (make_command_window): Don't call
 178         init_and_make_win.
 179         (make_source_window, make_disasm_window): Don't call
 180         make_source_or_disasm_window.
 181         (make_data_window): Don't call init_and_make_win.  Change calling
 182         convention.
 183         (show_source_disasm_command, show_data): Simplify.
 184         (make_source_or_disasm_window): Remove.
 185         (show_source_or_disasm_and_command): Simplify.
 186         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 187         (struct tui_source_window_base) <reset>: Likewise.
 188         <execution_info>: Remove initializer.
 189         * tui/tui-data.c (tui_source_window_base): Initialize
 190         execution_info.
 191
 192 2019-07-17  Tom Tromey  <tom@tromey.com>
 193
 194         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 195         variable.
 196
 197 2019-07-17  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui.c (tui_rl_other_window): Update.
 200         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 201         superclass method first.  Always iterate over regs_content.
 202         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 203         method.
 204         * tui/tui-win.c (tui_set_focus_command): Update.
 205
 206 2019-07-17  Tom Tromey  <tom@tromey.com>
 207
 208         * tui/tui-win.c (tui_set_focus_command): Rename from
 209         tui_set_focus.  Call tui_enable.
 210         (tui_set_focus_command): Remove.
 211
 212 2019-07-17  Tom Tromey  <tom@tromey.com>
 213
 214         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 215         refresh_window.
 216         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 217         touchwin.
 218         (tui_data_window::refresh_window): Call refresh_window on data
 219         items.  Always call superclass refresh_window.
 220         (tui_win_info::refresh): Remove.
 221         (tui_source_window_base::refresh_window): Update.
 222         (tui_refresh_all): Update.
 223         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 224         refresh_window.
 225         (show_source_or_disasm_and_command): Likewise.
 226         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 227         (struct tui_source_window_base) <refresh>: Likewise.
 228
 229 2019-07-17  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-winsource.c (tui_clear_source_content)
 232         (tui_show_source_content): Update.
 233         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 234         whether content is empty.
 235         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 236         Remove.
 237
 238 2019-07-17  Tom Tromey  <tom@tromey.com>
 239
 240         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 241         window's contents.
 242         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 243         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 244
 245 2019-07-17  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 248         (struct tui_data_item_window): Update.
 249
 250 2019-07-17  Tom Tromey  <tom@tromey.com>
 251
 252         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 253         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 254         defines.
 255
 256 2019-07-17  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-winsource.h (tui_erase_source_content)
 259         (tui_clear_source_content): Remove "display_prompt" parameter.
 260         * tui/tui-winsource.c (tui_update_source_window_as_is)
 261         (tui_update_source_windows_with_addr): Update.
 262         (tui_clear_source_content): Remove "display_prompt" parameter.
 263         (tui_erase_source_content): Likewise.  Simplify.
 264         (tui_show_source_content): Update.
 265         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 266         * tui/tui-stack.c (tui_show_frame_info): Update.
 267         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 268         Remove defines.
 269
 270 2019-07-17  Tom Tromey  <tom@tromey.com>
 271
 272         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 273         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 274         parameter.
 275         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 276         parameter.
 277
 278 2019-07-17  Tom Tromey  <tom@tromey.com>
 279
 280         * tui/tui-winsource.c (tui_clear_source_content)
 281         (tui_show_source_content, tui_show_exec_info_content)
 282         (tui_clear_exec_info_content): Update.
 283         * tui/tui-stack.c (tui_show_locator_content): Update.
 284         (tui_show_frame_info): Update.
 285         * tui/tui-source.h (tui_source_window): Don't declare.
 286         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 287         from tui_source_is_displayed.
 288         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 289         Remove field.
 290         (struct tui_source_window_base) <content_in_use>: New field.  Now
 291         bool.
 292         (struct tui_source_window) <showing_source_p>: New method.
 293         (TUI_SRC_WIN): Change cast.
 294         * tui/tui-data.c (tui_initialize_static_data): Update.
 295
 296 2019-07-17  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 299         location_matches_p.
 300         * tui/tui-source.c (tui_source_window::location_matches_p): New
 301         method.
 302         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 303         method.
 304         * tui/tui-data.h (struct tui_source_window_base)
 305         <location_matches_p>: New method.
 306         (struct tui_source_window, struct tui_disasm_window)
 307         <location_matches_p>: Likewise.
 308
 309 2019-07-17  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-win.c (tui_set_win_height_command): Rename from
 312         tui_set_win_height.
 313         (tui_set_win_height_command): Remove.
 314
 315 2019-07-17  Tom Tromey  <tom@tromey.com>
 316
 317         * tui/tui-source.c (tui_source_window): New constructor.  Add
 318         observer.
 319         (~tui_source_window): New destructor.
 320         (tui_source_window::style_changed): New method.
 321         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 322         (tui_attach_detach_observers): Update.
 323         * tui/tui-data.h (struct tui_source_window): Make constructor not
 324         inline.  Add destructor.
 325         (struct tui_source_window) <style_changed>: New method.
 326         <m_observable>: New member.
 327
 328 2019-07-17  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 331         * tui/tui-win.c (tui_resize_all): Fix typo.
 332
 333 2019-07-17  Tom Tromey  <tom@tromey.com>
 334
 335         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 336         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 337         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 338         * tui/tui-win.c (window_name_completer): Use foreach.
 339         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 340         (update_tab_width): Likewise.
 341         * tui/tui-layout.c (show_layout): Update.
 342         * tui/tui-data.h (class tui_window_iterator): New.
 343         (struct all_tui_windows): New.
 344         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 345
 346 2019-07-17  Tom Tromey  <tom@tromey.com>
 347
 348         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 349         parameter.  Don't reference globals.
 350         (tui_reg_command): Update.
 351
 352 2019-07-17  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-regs.c (tui_show_registers): Simplify.
 355
 356 2019-07-17  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-regs.c (tui_show_registers): Update.
 359         (tui_show_register_group): Add win_info parameter.
 360
 361 2019-07-17  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 364         Rename from tui_display_reg_element_at_line.
 365         (tui_data_window::display_registers_from_line): Update.
 366         * tui/tui-data.h (struct tui_data_window)
 367         <display_reg_element_at_line>: New method.
 368
 369 2019-07-17  Tom Tromey  <tom@tromey.com>
 370
 371         * tui/tui-regs.h (tui_display_registers_from)
 372         (tui_display_registers_from_line): Don't declare.
 373         * tui/tui-windata.c (tui_data_window::display_all_data)
 374         (tui_data_window::refresh_all)
 375         (tui_data_window::do_scroll_vertical): Update.
 376         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 377         from tui_display_registers_from.
 378         (tui_display_reg_element_at_line): Update.
 379         (tui_data_window::display_registers_from_line): Rename from
 380         tui_display_registers_from_line.
 381         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 382         display_registers_from_line>: New methods.
 383
 384 2019-07-17  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 387         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 388         from tui_erase_data_content.
 389         (tui_data_window::display_all_data)
 390         (tui_data_window::refresh_all)
 391         (tui_data_window::do_scroll_vertical): Update.
 392         * tui/tui-regs.c (tui_show_registers): Update.
 393         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 394         New method.
 395
 396 2019-07-17  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 399         declare.
 400         * tui/tui-windata.c
 401         (tui_data_window::delete_data_content_windows): Rename from
 402         tui_delete_data_content_windows.
 403         (tui_data_window::display_all_data)
 404         (tui_data_window::do_scroll_vertical): Update.
 405         * tui/tui-data.h (struct tui_data_window)
 406         <delete_data_content_windows>: New method.
 407
 408 2019-07-17  Tom Tromey  <tom@tromey.com>
 409
 410         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 411         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 412
 413 2019-07-17  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 416         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 417         from tui_display_all_data.
 418         * tui/tui-win.c
 419         (tui_data_window::do_make_visible_with_new_height): Update.
 420         * tui/tui-regs.c (tui_show_registers): Update.
 421         * tui/tui-layout.c (tui_set_layout): Update.
 422         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 423         method.
 424
 425 2019-07-17  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 428         * tui/tui-windata.c (tui_display_data_from): Remove.
 429         (tui_data_window::refresh_all): Update.
 430
 431 2019-07-17  Tom Tromey  <tom@tromey.com>
 432
 433         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 434         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 435         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 436         tui_display_registers_from_line.
 437         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 438         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 439         "force_display" parameter.
 440
 441 2019-07-17  Tom Tromey  <tom@tromey.com>
 442
 443         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 444         declare.
 445         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 446         Rename from tui_first_reg_element_no_inline.
 447         (tui_display_reg_element_at_line)
 448         (tui_display_registers_from_line): Update.
 449         * tui/tui-data.h (struct tui_data_window)
 450         <first_reg_element_no_inline>: New method.
 451
 452 2019-07-17  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui-windata.c (tui_display_data_from)
 455         (tui_data_window::do_scroll_vertical): Update.
 456         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 457         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 458         Rename from tui_line_from_reg_element_no.
 459         (tui_display_registers_from_line): Update.
 460         * tui/tui-data.h (struct tui_data_window)
 461         <line_from_reg_element_no>: New method.
 462
 463 2019-07-17  Tom Tromey  <tom@tromey.com>
 464
 465         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 466         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 467         tui_last_regs_line_no.
 468         (tui_display_reg_element_at_line)
 469         (tui_display_registers_from_line): Update.
 470         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 471         method.
 472
 473 2019-07-17  Tom Tromey  <tom@tromey.com>
 474
 475         PR tui/24722:
 476         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 477         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 478         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 479         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 480         (tui_update_breakpoint_info): Likewise.
 481         * tui/tui-hooks.c (tui_event_create_breakpoint)
 482         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 483         Update.
 484
 485 2019-07-17  Tom Tromey  <tom@tromey.com>
 486
 487         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 488
 489 2019-07-17  Tom Tromey  <tom@tromey.com>
 490
 491         * tui/tui-winsource.c (tui_update_source_window_as_is)
 492         (tui_update_source_windows_with_addr): Update.
 493         * tui/tui-source.h (tui_set_source_content)
 494         (tui_show_symtab_source): Add "win_info" parameter.
 495         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 496         parameter.
 497         (tui_show_symtab_source): Likewise.
 498
 499 2019-07-17  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-wingeneral.c
 502         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 503
 504 2019-07-17  Tom Tromey  <tom@tromey.com>
 505
 506         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 507         (struct tui_cmd_window) <can_scroll>: New method.
 508         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 509         method.
 510
 511 2019-07-17  Tom Tromey  <tromey@adacore.com>
 512
 513         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 514         do_field_signed>: Rename.  Change type of "value".
 515         * ui-out.c (ui_out::field_signed): Rename from field_int.
 516         Change type of "value".
 517         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 518         type of "value".
 519         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 520         do_field_int.  Change type of "value".
 521         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 522         do_field_int.  Change type of "value".
 523         * tracepoint.c (trace_status_mi, tfind_1)
 524         (print_one_static_tracepoint_marker): Update.
 525         * thread.c (print_thread_info_1, print_selected_thread_frame):
 526         Update.
 527         * stack.c (print_frame, print_frame_info): Update.
 528         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 529         Update.
 530         * source.c (print_source_lines_base): Update.
 531         * skip.c (info_skip_command): Update.
 532         * record-btrace.c (btrace_ui_out_decode_error)
 533         (btrace_call_history_src_line): Update.
 534         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 535         Update.
 536         * progspace.c (print_program_space): Update.
 537         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 538         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 539         do_field_int.  Change type of "value".
 540         * mi/mi-out.c (mi_ui_out::do_table_begin)
 541         (mi_ui_out::do_table_header): Update.
 542         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 543         type of "value".
 544         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 545         (mi_cmd_data_list_changed_registers, output_register)
 546         (mi_cmd_data_read_memory, mi_load_progress)
 547         (mi_cmd_trace_frame_collected): Update.
 548         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 549         Update.
 550         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 551         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 552         (mi_cmd_var_list_children, varobj_update_one): Update.
 553         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 554         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 555         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 556         * inferior.c (print_inferior): Update.
 557         * gdb_bfd.c (print_one_bfd): Update.
 558         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 559         Update.
 560         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 561         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 562         do_field_int.  Change type of "value".
 563         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 564         do_field_int.  Change type of "value".
 565         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 566         (print_one_breakpoint_location, print_it_catch_fork)
 567         (print_one_catch_fork, print_it_catch_vfork)
 568         (print_one_catch_vfork, print_it_catch_solib)
 569         (print_it_catch_exec, print_it_ranged_breakpoint)
 570         (print_mention_watchpoint, print_mention_masked_watchpoint)
 571         (bkpt_print_it, update_static_tracepoint): Update.
 572         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 573         * break-catch-syscall.c (print_it_catch_syscall): Update.
 574         * ada-tasks.c (print_ada_task_info): Update.
 575         * ada-lang.c (print_it_exception, print_mention_exception):
 576         Update.
 577
 578 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 579
 580         PR breakpoints/24541
 581         * gdbarch.c: Regenerate.
 582         * gdbarch.h: Regenerate.
 583         * gdbarch.sh: Adjust return type and parameter types for
 584         'stap_adjust_register'.
 585         (i386_stap_adjust_register): Adjust signature and return new
 586         register name.
 587         * stap-probe.c (stap_parse_register_operand): Adjust use of
 588         'gdbarch_stap_adjust_register'.
 589
 590 2019-07-17  Tom Tromey  <tromey@adacore.com>
 591
 592         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 593         declare VEC.
 594         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 595         std::vector.
 596         (struct s390_process_info): Add initializers.
 597         (s390_add_process): Use new.
 598         (s390_linux_nat_target::low_forget_process): Use delete.
 599         (s390_linux_nat_target::low_new_fork)
 600         (s390_linux_nat_target::stopped_by_watchpoint)
 601         (s390_linux_nat_target::low_prepare_to_resume)
 602         (s390_linux_nat_target::insert_watchpoint)
 603         (s390_linux_nat_target::insert_hw_breakpoint)
 604         (s390_linux_nat_target::remove_watchpoint)
 605         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 606
 607 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 608
 609         * aarch64-fbsd-nat.c: Include regcache.h.
 610         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 611         argument.
 612         (aarch64_fbsd_nat_target::fetch_registers)
 613         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 614         variable.
 615         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 616
 617 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 618
 619         * fbsd-nat.c: Include gdbarch.h.
 620
 621 2019-07-15  Tom Tromey  <tromey@adacore.com>
 622
 623         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 624
 625 2019-07-15  Tom Tromey  <tromey@adacore.com>
 626
 627         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 628         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 629         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 630         * cli-out.c (cli_ui_out::do_field_int): New method.
 631         * ui-out.c (ui_out::field_unsigned): New method.
 632         * symfile.c (generic_load): Use field_unsigned.
 633         (print_transfer_performance): Likewise.
 634         * record-btrace.c (ui_out_field_uint): Remove.
 635         (btrace_call_history_insn_range, btrace_call_history): Use
 636         field_unsigned.
 637         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 638         field_unsigned.
 639         * ui-out.h (class ui_out) <field_unsigned>: New method.
 640         <do_field_unsigned>: Likewise.
 641
 642 2019-07-15  Tom Tromey  <tromey@adacore.com>
 643
 644         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 645         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 646         * target.c (flash_erase_command): Use field_string.
 647         * infrun.c (print_signal_received_reason): Use field_string.
 648         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 649         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 650         field_string.
 651         * ada-tasks.c (print_ada_task_info): Use field_string.
 652
 653 2019-07-15  Tom Tromey  <tromey@adacore.com>
 654
 655         * target.c (flash_erase_command): Use field_core_addr.
 656         * symfile.c (generic_load): Use field_core_addr.
 657         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 658         Use field_core_addr.
 659         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 660         field_core_addr.
 661
 662 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 663
 664         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 665         value if its desired type is smaller than a CORE_ADDR and signed.
 666
 667 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 668
 669         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 670         of changes to field names, and use new is_reference field to
 671         decide if a property is a reference or not.
 672         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 673         field.
 674         (struct dwarf2_property_baton): Update header comment, rename
 675         'referenced_type' to 'property_type' and update comments.
 676         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 677         default property type, store in property baton, update to take
 678         accound of renamed field.
 679         (read_func_scope): Update call to attr_to_dynamic_prop.
 680         (read_array_type): Likewise.
 681         (dwarf2_per_cu_addr_sized_int_type): New function.
 682         (read_subrange_index_type): Move type finding code to
 683         dwarf2_per_cu_addr_sized_int_type.
 684         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 685         (dwarf2_per_cu_addr_type): New function.
 686         (set_die_type): Update calls to attr_to_dynamic_prop.
 687
 688 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 689
 690         * dwarf2read.c (read_subrange_index_type): New function.
 691         (read_subrange_type): Move code into new function and call it.
 692         * gdbtypes.c (create_range_type): Add some asserts.
 693
 694 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 695
 696         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 697         update return statements.
 698         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 699         declaration, and update comment to match.
 700         * gdbtypes.c (resolve_dynamic_array): Update call to
 701         dwarf2_evaluate_property to match new return type.
 702
 703 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 704
 705         * valarith.c (value_subscripted_rvalue): Change lowerbound
 706         parameter type from int to LONGEST.
 707         * value.h (value_subscripted_rvalue): Likewise in declaration.
 708
 709 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 710
 711         * cli/cli-utils.c (info_print_command_completer): New function.
 712         * cli/cli-utils.h: Add 'completer.h' include, and forward
 713         declaration for 'struct cmd_list_element'.
 714         (info_print_command_completer): Declare.
 715         * stack.c (_initialize_stack): Add completer for 'info locals' and
 716         'info args'.
 717         * symtab.c (_initialize_symtab): Add completer for 'info
 718         variables' and 'info functions'.
 719         * NEWS: Mention completion for additional info commands.
 720
 721 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 722
 723         * cli/cli-utils.c (extract_info_print_args): Delete.
 724         (extract_arg_maybe_quoted): Delete.
 725         (info_print_options_defs): New variable.
 726         (make_info_print_options_def_group): New function.
 727         (extract_info_print_options): Define new function.
 728         * cli/cli-utils.h (extract_info_print_args): Delete.
 729         (struct info_print_options): New structure.
 730         (extract_info_print_options): Declare new function.
 731         * stack.c (info_locals_command): Update to use new
 732         extract_info_print_options, also add a header comment.
 733         (info_args_command): Likewise.
 734         * symtab.c (info_variables_command): Likewise.
 735         (info_functions_command): Likewise.
 736
 737 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 738
 739         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 740         to extract string arguments.
 741         * common/common-utils.c (extract_string_maybe_quoted): New function.
 742         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 743
 744 2019-07-11  Tom Tromey  <tromey@adacore.com>
 745
 746         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 747         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 748         * top.h (gdbinit): Don't declare.
 749         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 750         into...
 751         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 752         * top.c (gdb_init): Don't call init_cli_cmds.
 753         (gdbinit): Remove.
 754         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 755
 756 2019-07-11  Tom Tromey  <tromey@adacore.com>
 757
 758         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 759         after it has been moved.
 760
 761 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 762
 763         * valops.c (value_must_coerce_to_target): Change return type to
 764         bool.
 765         * value.h (value_must_coerce_to_target): Likewise.
 766
 767 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 768
 769         * breakpoint.c (is_hardware_watchpoint): Remove
 770         forward-declaration.
 771         (is_masked_watchpoint): Change return type to bool.
 772         (is_tracepoint): Likewise.
 773         (is_breakpoint): Likewise.
 774         (is_hardware_watchpoint): Likewise.
 775         (is_watchpoint): Likewise.
 776         (is_no_memory_software_watchpoint): Likewise.
 777         (is_catchpoint): Likewise.
 778         (breakpoint_1): Make FILTER parameter's return type bool.
 779         is_masked_watchpoint): Change return type to bool.
 780         (save_breakpoints): Make FILTER parameter's return type bool.
 781         * breakpoint.h (is_breakpoint): Change return type to bool.
 782         (is_watchpoint): Likewise.
 783         (is_catchpoint): Likewise.
 784         (is_tracepoint): Likewise.
 785
 786 2019-07-10  Tom Tromey  <tom@tromey.com>
 787
 788         * defs.h: Don't include gdbarch.h.
 789         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 790         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 791         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 792         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 793         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 794         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 795         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 796         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 797         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 798         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 799         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 800         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 801         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 802         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 803         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 804         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 805         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 806         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 807         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 808         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 809         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 810         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 811         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 812         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 813         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 814         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 815         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 816
 817 2019-07-10  Tom Tromey  <tromey@adacore.com>
 818
 819         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 820         * breakpoint.c (init_ada_exception_breakpoint): Register as
 821         bp_catchpoint.
 822         (print_one_breakpoint_location, print_one_breakpoint): Use
 823         is_ada_exception_catchpoint.
 824         * ada-lang.c (class ada_catchpoint_location): Pass
 825         bp_loc_software_breakpoint to bp_location constructor.
 826         (is_ada_exception_catchpoint): New function.
 827
 828 2019-07-10  Tom Tromey  <tromey@adacore.com>
 829
 830         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 831         VEC.
 832         (struct arm_exidx_entry): New method operator<.
 833         (struct arm_exidx_data) <section_maps>: Change type.
 834         (arm_exidx_data_free): Remove.
 835         (arm_exidx_data_key): Change type.  Move lower.
 836         (arm_exidx_new_objfile): Update.
 837         (arm_compare_exidx_entries): Remove.
 838         (arm_find_exidx_entry, _initialize_arm_tdep)
 839
 840 2019-07-10  Tom Tromey  <tromey@adacore.com>
 841
 842         * solib-spu.c (ocl_program_data_key): Change type.
 843         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 844         Update.
 845
 846 2019-07-10  Tom Tromey  <tromey@adacore.com>
 847
 848         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 849         (struct solib_aix_inferior_data) <library_list>: Change type.
 850         (solib_aix_inferior_data_handle): Change type.
 851         (get_solib_aix_inferior_data): Update.
 852         (solib_aix_free_library_list): Remove.
 853         (library_list_start_library): Update.
 854         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 855         return type.
 856         (solib_aix_get_library_list)
 857         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 858         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 859
 860 2019-07-10  Tom Tromey  <tromey@adacore.com>
 861
 862         * solib-dsbt.c (struct dsbt_info): Add initializers.
 863         (solib_dsbt_pspace_data): Change type.
 864         (dsbt_pspace_data_cleanup): Remove.
 865         (get_dsbt_info, _initialize_dsbt_solib): Update.
 866
 867 2019-07-10  Tom Tromey  <tromey@adacore.com>
 868
 869         * spu-tdep.c (spu_overlay_data): Change type.
 870         (spu_get_overlay_table, spu_overlay_new_objfile)
 871         (_initialize_spu_tdep): Update.
 872
 873 2019-07-10  Tom Tromey  <tromey@adacore.com>
 874
 875         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 876         destructor.
 877         (dbx_objfile_data_key): Change type and declare later.
 878         (DBX_SYMFILE_INFO): Rewrite.
 879         * dbxread.c (dbx_objfile_data_key): Change type.
 880         (dbx_symfile_init): Update.
 881         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 882         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 883         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 884
 885 2019-07-10  Tom Tromey  <tromey@adacore.com>
 886
 887         * jit.c (jit_program_space_key): Change type.  Move lower.
 888         (get_jit_program_space_data): Update.
 889         (jit_program_space_data_cleanup): Remove.
 890         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 891         Update.
 892         (struct jit_program_space_data): Add initializers.
 893
 894 2019-07-10  Tom Tromey  <tromey@adacore.com>
 895
 896         * solib-darwin.c (struct darwin_info): Add initializers.
 897         (solib_darwin_pspace_data): Change type.
 898         (darwin_pspace_data_cleanup): Remove.
 899         (get_darwin_info, _initialize_darwin_solib): Update.
 900
 901 2019-07-10  Tom Tromey  <tromey@adacore.com>
 902
 903         * remote-sim.c (struct sim_inferior_data): Add initializers,
 904         constructor, and destructor.
 905         (sim_inferior_data_key): Change type.  Move lower.
 906         (check_for_duplicate_sim_descriptor): Update.
 907         (get_sim_inferior_data): Use new.  Update.
 908         (~sim_inferior_data_cleanup): Rename from
 909         sim_inferior_data_cleanup.  Simplify.
 910         (gdbsim_close_inferior, simulator_command)
 911         (sim_command_completer, _initialize_remote_sim): Update.
 912         (next_pid, INITIAL_PID): Move earlier.
 913
 914 2019-07-10  Tom Tromey  <tromey@adacore.com>
 915
 916         * python/python-internal.h (create_thread_object): Return
 917         gdbpy_ref.
 918         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 919         * python/py-inferior.c (struct threadlist_entry): Add
 920         constructor.
 921         <thread_obj>: Now a gdbpy_ref.
 922         (thread_to_thread_object): Update.
 923         (add_thread_object): Use new.
 924         (delete_thread_object): Use delete.
 925         (infpy_threads): Update.
 926         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 927         GIL.
 928
 929 2019-07-10  Tom Tromey  <tromey@adacore.com>
 930
 931         * valops.c (value_cast): Specialize error message for Ada.
 932
 933 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 934
 935         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 936
 937 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 938
 939         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 940         bpstat_should_step): Return bool, adjust comments.
 941         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 942         bpstat_should_step): Likewise.
 943
 944 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 945
 946         * features/Makefile: Use feature target descriptions for Arm.
 947         * features/arm/arm-core.c: Generate new file.
 948         * features/arm/arm-fpa.c: Likewise.
 949         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 950         * features/arm/arm-m-profile.c: Likewise.
 951         * features/arm/arm-vfpv2.c: Likewise.
 952         * features/arm/arm-vfpv3.c: Likewise.
 953         * features/arm/xscale-iwmmxt.c: Likewise.
 954         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 955
 956 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 957
 958         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 959         ptrace earlier.
 960
 961 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 962
 963         * features/aarch64-pauth.c: Regenerate.
 964
 965 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 966
 967         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 968         bool.
 969         (bpstat_what): Use false instead of 0.
 970
 971 2019-07-09  Pedro Alves  <palves@redhat.com>
 972
 973         * break-catch-throw.c (is_exception_catchpoint): New.
 974         * breakpoint.c (print_one_breakpoint_location): New parameter
 975         'raw_loc'.  Handle it.  Use
 976         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 977         looking at the breakpoint's type.
 978         (print_one_breakpoint): If handling "maint info breakpoints", also
 979         print locations of exception catchpoints.
 980         * breakpoint.h (is_exception_catchpoint): Declare.
 981
 982 2019-07-09  Pedro Alves  <palves@redhat.com>
 983
 984         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 985         "addr" field.
 986         (allocate_location_exception_catchpoint): New.
 987         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 988         (initialize_throw_catchpoint_ops): Install
 989         allocate_location_exception_catchpoint as allocate_location
 990         method.
 991         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 992         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 993         bp_loc_other.
 994         (breakpoint_address_is_meaningful): Delete.
 995         (bl_address_is_meaningful): New.
 996         (breakpoint_locations_match): Adjust comment.
 997         (bp_location_from_bp_type): New, factored out of...
 998         (bp_location::bp_location(breakpoint *)): ... this.
 999         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1000         factored out of...
1001         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1002         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1003         breakpoint_address_is_meaningful.
1004         (bp_locations_compare): Adjust comment.
1005         (update_global_location_list): Use bl_address_is_meaningful
1006         instead of breakpoint_address_is_meaningful.
1007         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1008         explicit.
1009         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1010         * python/py-breakpoint.c (bppy_get_location): No longer check
1011         whether location is null.
1012
1013 2019-07-09  Pedro Alves  <palves@redhat.com>
1014
1015         PR c++/15468
1016         * breakpoint.c (print_one_breakpoint_location): Remove
1017         single-location assert.
1018
1019 2019-07-09  Tom Tromey  <tom@tromey.com>
1020
1021         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1022         * configure: Rebuild.
1023         * configure.ac: Change common to gdbsupport.
1024         * gdbsupport: Rename from common.
1025         * acinclude.m4: Change common to gdbsupport.
1026         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1027         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1028         gdbsupport.
1029         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1030         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1031         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1032         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1033         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1034         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1035         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1036         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1037         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1038         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1039         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1040         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1041         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1042         coff-pe-read.c, command.h, compile/compile-c-support.c,
1043         compile/compile-c.h, compile/compile-cplus-symbols.c,
1044         compile/compile-cplus-types.c, compile/compile-cplus.h,
1045         compile/compile-loc2c.c, compile/compile.c, completer.c,
1046         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1047         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1048         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1049         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1050         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1051         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1052         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1053         features/aarch64-core.c, features/aarch64-fpu.c,
1054         features/aarch64-pauth.c, features/aarch64-sve.c,
1055         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1056         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1057         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1058         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1059         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1060         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1061         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1062         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1063         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1064         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1065         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1066         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1067         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1068         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1069         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1070         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1071         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1072         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1073         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1074         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1075         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1076         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1077         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1078         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1079         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1080         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1081         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1082         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1083         minsyms.c, mips-linux-tdep.c, namespace.h,
1084         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1085         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1086         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1087         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1088         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1089         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1090         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1091         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1092         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1093         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1094         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1095         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1096         procfs.c, producer.c, progspace.h, psymtab.h,
1097         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1098         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1099         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1100         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1101         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1102         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1103         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1104         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1105         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1106         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1107         target-memory.c, target.c, target.h, target/waitstatus.c,
1108         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1109         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1110         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1111         unittests/array-view-selftests.c,
1112         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1113         unittests/common-utils-selftests.c,
1114         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1115         unittests/format_pieces-selftests.c,
1116         unittests/function-view-selftests.c,
1117         unittests/lookup_name_info-selftests.c,
1118         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1119         unittests/mkdir-recursive-selftests.c,
1120         unittests/observable-selftests.c,
1121         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1122         unittests/parse-connection-spec-selftests.c,
1123         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1124         unittests/scoped_fd-selftests.c,
1125         unittests/scoped_mmap-selftests.c,
1126         unittests/scoped_restore-selftests.c,
1127         unittests/string_view-selftests.c, unittests/style-selftests.c,
1128         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1129         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1130         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1131         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1132         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1133         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1134
1135 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1136
1137         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1138         bool value.
1139         (decode_digits_ordinary): Set explicit_line field in sal.
1140         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1141         symtab_and_line that was set on an explicit line number in
1142         assembler code.  Do always update the recorded symtab and line if
1143         we do skip the prologue.
1144
1145 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1146
1147         * breakpoint.c (set_breakpoint_location_function): Remove
1148         explicit_loc parameter.
1149         (momentary_breakpoint_from_master): Update call to
1150         set_breakpoint_location_function.
1151         (add_location_to_breakpoint): Likewise.
1152
1153 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1154
1155         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1156         required features based on default bfd type when no specific bfd
1157         is present.
1158
1159 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1160
1161         * NEWS: Mention that GDB printf and eval commands can now print
1162         C-style and Ada-style convenience var strings without
1163         calling the inferior.
1164         * printcmd.c (printf_c_string): Locally print GDB internal var
1165         instead of transiting via the inferior.
1166         (printf_wide_c_string): Likewise.
1167
1168 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1169
1170         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1171
1172 2019-07-04  Tom Tromey  <tom@tromey.com>
1173
1174         PR tui/24724:
1175         * tui/tui-winsource.c (tui_clear_source_content): Update.
1176         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1177         (tui_update_breakpoint_info): Update.
1178         (tui_set_exec_info_content): Update.
1179         * tui/tui-source.c (tui_set_source_content_nil): Update.
1180         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1181         has_break.
1182         * tui/tui-data.h (enum tui_bp_flag): New.
1183         (tui_bp_flags): New enum flags type.
1184         (struct tui_source_element) <break_mode>: Change type.  Rename
1185         from has_break.
1186         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1187         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1188         constants.
1189         * tui/tui-winsource.h: Fix comment.
1190
1191 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1192
1193         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1194         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1195         (store_fpregs_to_thread)
1196         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1197         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1198         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1199         (IWMMXT_REGS_SIZE): Add define.
1200         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1201         (fetch_vfp_regs, store_vfp_regs)
1202         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1203         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1204
1205 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1206
1207         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1208         defines.
1209         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1210         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1211         (ARM_INT_REGISTER_SIZE): ...to this.
1212         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1213         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1214         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1215         (arm_linux_collect_gregset, supply_nwfpe_register)
1216         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1217         defines.
1218         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1219         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1220         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1221         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1222         (arm_return_in_memory, arm_store_return_value)
1223         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1224         (arm_record_ld_st_multiple): Likewise.
1225         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1226         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1227
1228 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1229
1230         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1231         AARCH64_DISPLACED_MODIFIED_INSNS.
1232         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1233         (aarch64_displaced_step_copy_insn): Likewise.
1234         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1235         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1236         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1237         ARM_DISPLACED_MODIFIED_INSNS.
1238         * arm-tdep.c (arm_gdbarch_init): Likewise.
1239         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1240         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1241         (struct arm_displaced_step_closure): Use
1242         ARM_DISPLACED_MODIFIED_INSNS.
1243
1244 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1245
1246         * features/Makefile: Remove unused xml files.
1247         * features/aarch64.xml: Remove.
1248         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1249         * features/i386/amd64-avx-avx512.xml: Remove.
1250         * features/i386/amd64-avx-linux.xml: Remove.
1251         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1252         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1253         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1254         * features/i386/amd64-avx-mpx.xml: Remove.
1255         * features/i386/amd64-avx.xml: Remove.
1256         * features/i386/amd64-linux.xml: Remove.
1257         * features/i386/amd64-mpx-linux.xml: Remove.
1258         * features/i386/amd64-mpx.xml: Remove.
1259         * features/i386/amd64.xml: Remove.
1260         * features/i386/i386-avx-avx512-linux.xml: Remove.
1261         * features/i386/i386-avx-avx512.xml: Remove.
1262         * features/i386/i386-avx-linux.xml: Remove.
1263         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1264         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1265         * features/i386/i386-avx-mpx-linux.xml: Remove.
1266         * features/i386/i386-avx-mpx.xml: Remove.
1267         * features/i386/i386-avx.xml: Remove.
1268         * features/i386/i386-linux.xml: Remove.
1269         * features/i386/i386-mmx-linux.xml: Remove.
1270         * features/i386/i386-mmx.xml: Remove.
1271         * features/i386/i386-mpx-linux.xml: Remove.
1272         * features/i386/i386-mpx.xml: Remove.
1273         * features/i386/i386.xml: Remove.
1274         * features/i386/x32-avx-avx512-linux.xml: Remove.
1275         * features/i386/x32-avx-linux.xml: Remove.
1276         * features/i386/x32-linux.xml: Remove.
1277
1278 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1279
1280         * regformats/aarch64.dat: Remove.
1281         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1282         * regformats/i386/amd64-avx-linux.dat: Remove.
1283         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1284         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1285         * regformats/i386/amd64-linux.dat: Remove.
1286         * regformats/i386/amd64-mpx-linux.dat: Remove.
1287         * regformats/i386/amd64.dat: Remove.
1288         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1289         * regformats/i386/i386-avx-linux.dat: Remove.
1290         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1291         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1292         * regformats/i386/i386-linux.dat: Remove.
1293         * regformats/i386/i386-mmx-linux.dat: Remove.
1294         * regformats/i386/i386-mpx-linux.dat: Remove.
1295         * regformats/i386/i386.dat: Remove.
1296         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1297         * regformats/i386/x32-avx-linux.dat: Remove.
1298         * regformats/i386/x32-linux.dat: Remove.
1299
1300 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1301
1302         * aarch64-tdep.c: Remove xml self tests.
1303         * amd64-linux-tdep.c: Likewise.
1304         * amd64-tdep.c: Likewise.
1305         * i386-linux-tdep.c: Likewise.
1306         * i386-tdep.c: Likewise.
1307
1308 2019-07-03  Pedro Alves  <palves@redhat.com>
1309
1310         PR cli/24732
1311         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1312         (pipe_cmd_option_defs): New.
1313         (make_pipe_cmd_options_def_group): New.
1314         (pipe_command): Use gdb::option::process_options.
1315         (pipe_command_completer): New function.
1316         (_initialize_cli_cmds): Install completer for "pipe" command.
1317
1318 2019-07-03  Pedro Alves  <palves@redhat.com>
1319
1320         * cli/cli-option.c (union option_value) <string>: New field.
1321         (struct option_def_and_value): Add ctor, move ctor, dtor and
1322         use DISABLE_COPY_AND_ASSIGN.
1323         (option_def_and_value::clear_value): New.
1324         (parse_option, save_option_value_in_ctx, get_val_type_str)
1325         (add_setshow_cmds_for_options): Handle var_string.
1326         * cli-option.h (union option_def::var_address) <string>: New
1327         field.
1328         (struct string_option_def): New.
1329         * maint-test-options.c (struct test_options_opts): Add default
1330         ctor and use DISABLE_COPY_AND_ASSIGN.
1331         <string_opt>: New field.
1332         (test_options_opts::~test_options_opts): New.
1333         (test_options_opts::dump): Also dump "-string".
1334         (test_options_option_defs): Install "string.
1335
1336 2019-07-03  Pedro Alves  <palves@redhat.com>
1337
1338         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1339         option_value with a null enumeration.
1340         (complete_options): Save the option values in the context.
1341         (save_option_value_in_ctx): New, factored out from ...
1342         (process_options): ... here.
1343         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1344         of the function.
1345         * maint-test-options.c (test_options_opts::dump): New, factored
1346         out from ...
1347         (maintenance_test_options_command_mode): ... here.
1348         (maintenance_test_options_command_completion_result): Delete.
1349         (maintenance_test_options_command_completion_text): Update
1350         comment.
1351         (maintenance_show_test_options_completion_result): Change
1352         prototype.  Just print
1353         maintenance_test_options_command_completion_text.
1354         (save_completion_result): New.
1355         (maintenance_test_options_completer_mode): Pass options context to
1356         complete_options, and then save a dump.
1357         (_initialize_maint_test_options): Use add_cmd to install "maint
1358         show test-options-completion-result".
1359
1360 2019-07-03  Pedro Alves  <palves@redhat.com>
1361
1362         * NEWS (New commands): Mention "with" and "maint with".
1363         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1364         (with_command, with_command_completer): New.
1365         (pipe_command): Adjust to new repeat_previous
1366         interface.
1367         (_initialize_cli_cmds): Install the "with" command and its "w"
1368         alias.
1369         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1370         declarations.
1371         * cli/cli-setshow.c (parse_cli_var_uinteger)
1372         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1373         argument strings for all var_types.
1374         (get_setshow_command_value_string): New, factored out from ...
1375         (do_show_command): ... this.
1376         * cli/cli-setshow.h: Include <string>.
1377         (get_setshow_command_value_string): Declare.
1378         * command.h (repeat_previous): Now returns const char *.  Adjust
1379         comment.
1380         * maint.c: Include "cli/cli-cmds.h".
1381         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1382         (_initialize_maint_cmds): Register the "maintenance with" command.
1383         * top.c (repeat_previous): Move bits from pipe_command here:
1384         Return the saved command line, if any; error out if there's no
1385         command to relaunch.
1386
1387 2019-07-03  Pedro Alves  <palves@redhat.com>
1388
1389         * NEWS (New commands): Mention "maint set/show test-settings"
1390         instead of "maint test-settings".
1391         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1392         (maintenance_test_settings_set_list): Rename to ...
1393         (maintenance_set_test_settings_list): ... this.
1394         (maintenance_test_settings_show_list): Rename to  ...
1395         (maintenance_show_test_settings_list): ... this.
1396         (maintenance_test_settings_cmd): Delete.
1397         (maintenance_test_settings_set_cmd): ...
1398         (maintenance_set_test_settings_cmd): ... this.
1399         (maintenance_test_settings_show_cmd): ...
1400         (maintenance_show_test_settings_cmd): ... this.
1401         (maintenance_test_settings_show_value_cmd):
1402         (maintenance_show_test_settings_value_cmd): ... this.
1403         (_initialize_maint_test_settings): No longer install the "maint
1404         test-settings" prefix command.  Rename "maint test-settings set"
1405         to "maint set test-settings", and "maint test-settings show" to
1406         "maint show test-settings".  Adjust all subcommands.
1407
1408 2019-07-03  Pedro Alves  <palves@redhat.com>
1409
1410         * maint-test-settings.c: Fix file's intro comment.  Replace all
1411         references to "test-options" with references to "test-settings",
1412         in comments.
1413
1414 2019-07-03  Pedro Alves  <palves@redhat.com>
1415
1416         * maint-test-settings.c (maintenance_test_settings_xxx)
1417         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1418         New.
1419         (maintenance_test_settings_enums): Use them.
1420         (maintenance_test_settings_enum): Default to
1421         maintenance_test_settings_xxx.
1422         (_initialize_maint_test_settings): Initialize
1423         MAINTENANCE_TEST_SETTINGS_FILENAME.
1424
1425 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1426
1427         * breakpoint.h (remove_breakpoints_inf): Change return type to
1428         void, move function documentation here.
1429         * breakpoint.c (remove_breakpoints_inf): Change return type to
1430         void, move function documentation to header.
1431
1432 2019-07-02  Pedro Alves  <palves@redhat.com>
1433
1434         * NEWS (Completion improvements): Mention "info threads".
1435         * thread.c (struct info_threads_opts, info_threads_option_defs)
1436         (make_info_threads_options_def_group): New.
1437         (info_threads_command): Use gdb::option::process_options.
1438         (info_threads_command_completer): New.
1439         (_initialize_thread): Use gdb::option::build_help to build the
1440         help text for "info threads".
1441
1442 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1443
1444         * defs.h (generic_load): Move from here...
1445         * symfile.h (generic_load): ... to here.  Rename name parameter
1446         to args.
1447         * symfile.c (generic_load): Add comment.
1448
1449 2019-07-01  Tom Tromey  <tromey@adacore.com>
1450
1451         * dwarf2read.c
1452         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1453         declaration of without_params.  Fix formatting.
1454
1455 2019-07-01  Tom Tromey  <tromey@adacore.com>
1456
1457         * ada-exp.y (find_primitive_type): Update.
1458         * ada-lang.h (ada_lookup_symbol): Update.
1459         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1460         parameter.
1461         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1462
1463 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1464
1465         PR breakpoints/24541
1466         * gdbarch.c: Regenerate.
1467         * gdbarch.h: Regenerate.
1468         * gdbarch.sh: Add 'stap_adjust_register'.
1469         * i386-tdep.c: Include '<unordered_set>'.
1470         (i386_stap_adjust_register): New function.
1471         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1472         * stap-probe.c (stap_parse_register_operand): Call
1473         'gdbarch_stap_adjust_register'.
1474
1475 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1476
1477         PR python/24742
1478         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1479         * python/python.c (do_start_initialization): Use 'xmalloc'
1480         instead of 'PyMem_Malloc'.
1481
1482 2019-06-28  Tom Tromey  <tromey@adacore.com>
1483
1484         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1485         for Ada.
1486
1487 2019-06-27  Tom Tromey  <tromey@adacore.com>
1488
1489         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1490         objfile_key.
1491         (arm_find_mapping_symbol, arm_record_special_symbol)
1492         (_initialize_arm_tdep): Update.
1493         (arm_objfile_data_free): Remove.
1494
1495 2019-06-27  Tom Tromey  <tromey@adacore.com>
1496
1497         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1498         to cp_print_static_field.
1499
1500 2019-06-26  Tom Tromey  <tromey@adacore.com>
1501
1502         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1503         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1504         declare.
1505
1506 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1507
1508         * features/aarch64-core.c (create_feature_aarch64_core):
1509         Regenerate.
1510         * features/aarch64-core.xml: Add cpsr flags.
1511
1512 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1513
1514         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1515         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1516
1517 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1518
1519         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1520         field.
1521         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1522         use.
1523         (arm_record_special_symbol): Don't insert new symbol in sorted
1524         position, push it at the end.
1525
1526 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1527
1528         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1529         (arm_mapping_symbol_s): Remove.
1530         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1531         (arm_mapping_symbol_vec): New typedef.
1532         (struct arm_per_objfile): Add constructor.
1533         <section_maps>: Change type to
1534         std::unique_ptr<arm_mapping_symbol_vec[]>.
1535         (arm_compare_mapping_symbols): Remove.
1536         (arm_find_mapping_symbol): Adjust to section_maps type change.
1537         (arm_objfile_data_free): Call delete on arm_per_objfile.
1538         (arm_record_special_symbol): Adjust to section_maps type change.
1539         Allocate arm_per_objfile with new.
1540
1541 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1542
1543         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1544         with the command prefix.
1545
1546 2019-06-25  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1549         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1550
1551 2019-06-25  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1554         type.
1555         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1556         protected.
1557
1558 2019-06-25  Tom Tromey  <tom@tromey.com>
1559
1560         * tui/tui-winsource.c
1561         (tui_source_window_base::set_is_exec_point_at): Add check against
1562         LOA_ADDRESS.
1563
1564 2019-06-25  Tom Tromey  <tom@tromey.com>
1565
1566         * tui/tui-source.c (tui_set_source_content): Don't check before
1567         xfree.
1568         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1569
1570 2019-06-25  Tom Tromey  <tom@tromey.com>
1571
1572         * tui/tui-winsource.h (tui_update_source_window_as_is)
1573         (tui_alloc_source_buffer, tui_line_is_displayed)
1574         (tui_addr_is_displayed): Change type of win_info.
1575         * tui/tui-winsource.c (tui_update_source_window_as_is)
1576         (tui_clear_source_content, tui_show_source_line)
1577         (tui_show_source_content, tui_source_window_base::refill)
1578         (tui_source_window_base::set_is_exec_point_at)
1579         (tui_source_window_base::set_is_exec_point_at)
1580         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1581         (tui_alloc_source_buffer, tui_line_is_displayed)
1582         (tui_addr_is_displayed): Change type of win_info.  Update.
1583         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1584         (tui_source_window_base::do_make_visible_with_new_height):
1585         Update.
1586         * tui/tui-source.c (tui_set_source_content)
1587         (tui_set_source_content_nil)
1588         (tui_source_window::do_scroll_vertical): Update.
1589         * tui/tui-layout.c (show_layout): Update.
1590         * tui/tui-disasm.c (tui_set_disassem_content)
1591         (tui_disasm_window::do_scroll_vertical): Update.
1592         * tui/tui-data.h (tui_win_content): Remove.
1593         (struct tui_gen_win_info) <content, content_size>: Remove.
1594         (struct tui_source_element): Add initializers and destructor.
1595         (union tui_which_element, struct tui_win_element): Remove.
1596         (struct tui_source_window_base) <content>: New field.
1597         (struct tui_data_window): Remove destructor.
1598         (tui_alloc_content, tui_free_win_content)
1599         (tui_free_all_source_wins_content): Don't declare.
1600         * tui/tui-data.c (tui_initialize_static_data): Update.
1601         (init_content_element, tui_alloc_content): Remove.
1602         (~tui_gen_win_info): Update.
1603         (~tui_data_window, tui_free_all_source_wins_content)
1604         (tui_free_win_content, free_content, free_content_elements):
1605         Remove.
1606
1607 2019-06-25  Tom Tromey  <tom@tromey.com>
1608
1609         * tui/tui-winsource.h (tui_clear_source_content)
1610         (tui_erase_source_content, tui_show_source_content): Change type
1611         of win_info.
1612         * tui/tui-winsource.c (tui_clear_source_content)
1613         (tui_erase_source_content, tui_show_source_content): Change type
1614         of win_info.
1615         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1616         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1617         win_info.
1618         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1619         win_info.
1620         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1621
1622 2019-06-25  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-winsource.c (tui_clear_source_content)
1625         (tui_source_window_base::set_is_exec_point_at): Update.
1626         * tui/tui-source.c (tui_set_source_content_nil): Update.
1627         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1628         a bool.
1629         * tui/tui-data.c (init_content_element): Update.
1630
1631 2019-06-25  Tom Tromey  <tom@tromey.com>
1632
1633         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1634         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1635         * tui/tui-layout.c (init_and_make_win): Update.
1636         * tui/tui.h (enum tui_win_type): Update.
1637         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1638         tui_win_is_auxillary.
1639         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1640         tui_win_is_auxillary.
1641
1642 2019-06-25  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1645         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1646         (tui_delete_data_content_windows, tui_display_all_data)
1647         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1648         Update.
1649         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1650         * tui/tui-regs.c (tui_last_regs_line_no)
1651         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1652         (tui_show_registers): Update.
1653         (tui_show_register_group): Return void.  Update.
1654         (tui_display_registers_from, tui_display_reg_element_at_line)
1655         (tui_display_registers_from_line, tui_check_register_values):
1656         Update.
1657         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1658         member.
1659         (struct tui_data_window) <regs_content>: Now a std::vector.
1660         <regs_content_count>: Remove.
1661         (tui_add_content_elements, tui_free_data_content): Don't declare.
1662         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1663         (init_content_element): Remove DATA_WIN case.  Add assert.
1664         (tui_add_content_elements): Remove.
1665         (tui_data_window): Update.
1666         (tui_free_data_content): Remove.
1667         (free_content_elements): Remove DATA_WIN case.
1668
1669 2019-06-25  Tom Tromey  <tom@tromey.com>
1670
1671         * tui/tui-data.c (tui_data_item_window): Update.
1672         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1673         * tui/tui-windata.c (tui_display_all_data)
1674         (tui_display_data_from_line): Update.
1675         (tui_check_data_values): Remove.
1676         * tui/tui-regs.c (tui_show_register_group)
1677         (tui_display_reg_element_at_line): Update.
1678         * tui/tui-hooks.c (tui_register_changed)
1679         (tui_refresh_frame_and_register_information): Call
1680         tui_check_register_values.
1681         * tui/tui-data.h (struct tui_data_window) <data_content,
1682         data_content_count, data_type>: Remove.
1683         (enum tui_data_type): Remove.
1684
1685         * tui/tui-data.c (tui_data_window::clear_detail)
1686         (~tui_data_window): Update.
1687
1688 2019-06-25  Tom Tromey  <tom@tromey.com>
1689
1690         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1691         declare.
1692         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1693         Rename from tui_first_data_item_displayed.  Update.
1694         (tui_data_window::refresh_all)
1695         (tui_data_window::do_scroll_vertical): Update.
1696         * tui/tui-data.h (struct tui_data_window)
1697         <first_data_item_displayed>: Declare new method.
1698
1699 2019-06-25  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1702         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1703         contents...
1704         (tui_initialize_static_data): ...here.
1705
1706 2019-06-25  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1709         (tui_display_registers_from, tui_check_register_values): Update.
1710         (tui_display_register): Remove win_info parameter; update.
1711         (tui_get_register): Change type of parameters.
1712         * tui/tui-data.h (struct tui_data_element): Remove.
1713         (union tui_which_element) <data>: Remove.
1714         <data_window>: Change type.
1715         (struct tui_data_item_window): New.
1716         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1717         case.  Add assert.
1718         (~tui_data_item_window): New destructor.
1719         (free_content_elements): Remove DATA_ITEM_WIN case.
1720
1721 2019-06-25  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1724         Remove.
1725
1726 2019-06-25  Tom Tromey  <tom@tromey.com>
1727
1728         * tui/tui-data.h (struct tui_command_element): Remove.
1729         (union tui_which_element) <command>: Remove.
1730         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1731         assert.
1732         (free_content_elements): Remove CMD_WIN case.
1733
1734 2019-06-25  Tom Tromey  <tom@tromey.com>
1735
1736         * tui/tui-layout.c (tui_set_layout): Update.
1737         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1738         * tui/tui-data.c (layout_def): Update.
1739
1740 2019-06-25  Tom Tromey  <tom@tromey.com>
1741
1742         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1743         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1744         (tui_source_window_base::set_new_height): Update.
1745         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1746         Update.
1747         (tui_set_locator_fullname, tui_set_locator_info)
1748         (tui_show_frame_info): Update.
1749         * tui/tui-source.c (tui_set_source_content)
1750         (tui_source_is_displayed): Update.
1751         * tui/tui-layout.c (show_source_disasm_command, show_data)
1752         (show_source_or_disasm_and_command): Update.
1753         * tui/tui-disasm.c (tui_set_disassem_content)
1754         (tui_get_begin_asm_address): Update.
1755         * tui/tui-data.h (struct tui_locator_element): Remove.
1756         (union tui_which_element) <locator>: Remove.
1757         (struct tui_locator_window): New.
1758         (tui_locator_win_info_ptr): Change return type.
1759         * tui/tui-data.c (_locator): Change type.
1760         (tui_locator_win_info_ptr): Change return type.
1761         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1762         (tui_alloc_content): Add assert.
1763
1764 2019-06-25  Tom Tromey  <tom@tromey.com>
1765
1766         * tui/tui-winsource.c
1767         (tui_exec_info_window::maybe_allocate_content): New method.
1768         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1769         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1770         (make_source_or_disasm_window): Add cast.
1771         * tui/tui-data.h (union tui_which_element) <simple_string>:
1772         Remove.
1773         (struct tui_source_info): New.
1774         (struct tui_source_window_base) <execution_info>: Change type.
1775         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1776         case, and add assert.
1777         (tui_alloc_content): Add assert.
1778
1779 2019-06-25  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1782         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1783         * tui/tui-data.c (tui_alloc_win_info): Remove.
1784
1785 2019-06-25  Tom Tromey  <tom@tromey.com>
1786
1787         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1788         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1789         can_highlight.
1790
1791 2019-06-25  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1794         make_visible_with_new_height method.
1795         (tui_win_info::make_visible_with_new_height): New method.
1796         (tui_source_window_base::do_make_visible_with_new_height)
1797         (tui_data_window::do_make_visible_with_new_height)
1798         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1799         (make_visible_with_new_height): Remove.
1800         (tui_resize_all, tui_adjust_win_heights): Use
1801         make_visible_with_new_height method.
1802         * tui/tui-data.h (struct tui_win_info)
1803         <do_make_visible_with_new_height, make_visible_with_new_height>:
1804         New methods.
1805         (struct tui_source_window_base, struct tui_data_window)
1806         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1807         methods.
1808
1809 2019-06-25  Tom Tromey  <tom@tromey.com>
1810
1811         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1812         method.
1813         (update_tab_width): Call update_tab_width method.
1814         * tui/tui-data.h (struct tui_win_info)
1815         (struct tui_source_window_base) <update_tab_width>: New methods.
1816
1817 2019-06-25  Tom Tromey  <tom@tromey.com>
1818
1819         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1820         parameter.
1821         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1822         parameter.
1823         (tui_gen_win_info::make_visible): Update.
1824         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1825         parameter.
1826         * tui/tui-data.h (enum tui_box): New enum.
1827         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1828
1829 2019-06-25  Tom Tromey  <tom@tromey.com>
1830
1831         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1832         init_and_make_win for EXEC_INFO_WIN.
1833         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1834         longer inline.
1835         (struct tui_win_info) <~tui_win_info>: Inline.
1836         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1837         Don't declare.
1838         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1839         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1840         Remove.
1841         (tui_initialize_static_data): Update.
1842         (~tui_gen_win_info): Handle more cleanup here.
1843         (~tui_source_window_base): Delete "execution_info".
1844         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1845
1846 2019-06-25  Tom Tromey  <tom@tromey.com>
1847
1848         * tui/tui-layout.c (make_command_window): Don't set
1849         can_highlight.
1850         (show_source_disasm_command): Call the reset method.
1851         (show_data): Don't set can_highlight.  Call the reset method.
1852         (tui_gen_win_info::reset): Rename from init_gen_win_info
1853         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1854         (show_source_or_disasm_and_command): Call the reset method.
1855         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1856         (struct tui_cmd_window): Set can_highlight.
1857
1858 2019-06-25  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1861         from make_visible.
1862         (tui_make_visible, tui_make_invisible): Rewrite.
1863         (tui_win_info::make_visible): Remove.
1864         (tui_source_window_base::make_visible): Update.
1865         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1866         method.  Moved from...
1867         (struct tui_win_info) <make_visible>: ...here.
1868
1869 2019-06-25  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-winsource.c
1872         (tui_source_window_base::do_scroll_horizontal): Remove direction
1873         parameter.
1874         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1875         direction parameter.
1876         * tui/tui-win.c (tui_win_info::forward_scroll)
1877         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1878         (tui_win_info::right_scroll): Update.
1879         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1880         direction parameter.
1881         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1882         direction parameter.
1883         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1884         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1885         Remove direction parameter.
1886         (struct tui_source_window_base, struct tui_source_window)
1887         (struct tui_disasm_window, struct tui_data_window)
1888         (struct tui_cmd_window): Update.
1889
1890 2019-06-25  Tom Tromey  <tom@tromey.com>
1891
1892         * tui/tui-winsource.h (tui_set_exec_info_content)
1893         (tui_show_exec_info_content, tui_erase_exec_info_content)
1894         (tui_clear_exec_info_content, tui_update_exec_info): Change
1895         argument to tui_source_window_base.
1896         * tui/tui-winsource.c (tui_set_exec_info_content)
1897         (tui_show_exec_info_content, tui_erase_exec_info_content)
1898         (tui_clear_exec_info_content, tui_update_exec_info): Change
1899         argument to tui_source_window_base.
1900
1901 2019-06-25  Tom Tromey  <tom@tromey.com>
1902
1903         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1904         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1905
1906 2019-06-25  Tom Tromey  <tom@tromey.com>
1907
1908         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1909         check.
1910
1911 2019-06-25  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1914         type to void.
1915         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1916         type to void.
1917         * tui/tui-source.c (tui_set_source_content): Update.
1918         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1919
1920 2019-06-25  Tom Tromey  <tom@tromey.com>
1921
1922         * tui/tui-win.c (window_name_completer, tui_set_focus)
1923         (tui_all_windows_info): Use name method.
1924         * tui/tui-data.h (struct tui_gen_win_info)
1925         (struct tui_source_window, struct tui_disasm_window)
1926         (struct tui_data_window, struct tui_cmd_window) <name>: New
1927         method.
1928         (tui_win_name): Don't declare.
1929         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1930         (tui_win_name): Remove.
1931
1932 2019-06-25  Tom Tromey  <tom@tromey.com>
1933
1934         * tui/tui-winsource.h (tui_update_source_window)
1935         (tui_update_source_window_as_is): Change parameter type.
1936         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1937         to be a tui_source_window_base.
1938         (tui_update_source_window_as_is): Likewise.
1939         * tui/tui-win.c (make_visible_with_new_height): Update.
1940
1941 2019-06-25  Tom Tromey  <tom@tromey.com>
1942
1943         * tui/tui-winsource.c (tui_erase_source_content)
1944         (tui_show_source_content, tui_show_exec_info_content)
1945         (tui_erase_exec_info_content): Use refresh_window method.
1946         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1947         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1948         from tui_refresh_win.
1949         (tui_data_window::refresh_window): New method.
1950         (tui_win_info::refresh, tui_source_window_base::refresh)
1951         (tui_refresh_all): Use refresh_window method.
1952         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1953         method.
1954         * tui/tui-regs.c (tui_display_register): Call refresh_window
1955         method.
1956         * tui/tui-layout.c (show_source_disasm_command)
1957         (show_source_or_disasm_and_command): Call refresh_window method.
1958         * tui/tui-data.h (struct tui_gen_win_info)
1959         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1960         New method.
1961
1962 2019-06-25  Tom Tromey  <tom@tromey.com>
1963
1964         * tui/tui.c (tui_rl_other_window, tui_enable)
1965         (tui_is_window_visible, tui_get_command_dimension): Update.
1966         * tui/tui-winsource.c (tui_update_source_window_as_is)
1967         (tui_clear_source_content, tui_erase_source_content)
1968         (tui_show_source_line, tui_source_window_base::refill)
1969         (tui_source_window_base::do_scroll_horizontal)
1970         (tui_source_window_base::set_is_exec_point_at)
1971         (tui_update_breakpoint_info, tui_set_exec_info_content)
1972         (tui_alloc_source_buffer, tui_line_is_displayed)
1973         (tui_addr_is_displayed): Update.
1974         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1975         (tui_check_and_display_highlight_if_needed)
1976         (tui_win_info::make_visible, tui_win_info::refresh)
1977         (tui_refresh_all): Update.
1978         * tui/tui-windata.c (tui_first_data_item_displayed)
1979         (tui_delete_data_content_windows, tui_erase_data_content)
1980         (tui_display_all_data, tui_data_window::refresh_all)
1981         (tui_check_data_values): Update.
1982         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1983         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1984         (tui_win_info::backward_scroll, tui_refresh_all_win)
1985         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1986         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1987         (tui_source_window_base::set_new_height)
1988         (tui_data_window::set_new_height)
1989         (make_invisible_and_set_new_height)
1990         (make_visible_with_new_height, new_height_ok)
1991         (parse_scrolling_args): Update.
1992         * tui/tui-stack.c (tui_show_frame_info): Update.
1993         * tui/tui-source.c (tui_set_source_content)
1994         (tui_set_source_content_nil, tui_source_is_displayed)
1995         (tui_source_window::do_scroll_vertical): Update.
1996         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1997         (tui_display_registers_from, tui_display_reg_element_at_line)
1998         (tui_check_register_values, tui_reg_command): Update.
1999         * tui/tui-layout.c (tui_default_win_height)
2000         (show_source_disasm_command, show_data, init_and_make_win)
2001         (show_source_or_disasm_and_command): Update.
2002         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2003         (tui_redisplay_readline, tui_mld_flush)
2004         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2005         (tui_getc): Update.
2006         * tui/tui-disasm.c (tui_set_disassem_content)
2007         (tui_disasm_window::do_scroll_vertical): Update.
2008         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2009         Now virtual.
2010         (struct tui_win_info): Derive from tui_gen_win_info.
2011         <~tui_win_info>: Mark as override.
2012         <generic>: Remove member.
2013         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2014         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2015         (~tui_data_window, ~tui_win_info)
2016         (tui_free_all_source_wins_content): Update.
2017         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2018
2019 2019-06-25  Tom Tromey  <tom@tromey.com>
2020
2021         * tui/tui-layout.c (init_and_make_win): Use new.
2022         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2023         destructor, initializers.
2024         (tui_alloc_generic_win_info): Don't declare.
2025         * tui/tui-data.c (_locator): Add argument to constructor.
2026         (source_win, disasm_win): New globals.
2027         (exec_info): Remove.
2028         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2029         Update.
2030         (tui_alloc_generic_win_info): Remove.
2031         (init_content_element): Use new.
2032         (tui_win_info::tui_win_info): Update.
2033         (free_content_elements) <case DATA_WIN>: Use delete.
2034
2035 2019-06-25  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2038         * tui/tui-windata.c (tui_first_data_item_displayed)
2039         (tui_delete_data_content_windows): Update.
2040         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2041         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2042         (tui_display_registers_from, tui_check_register_values): Update.
2043         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2044         pointer.
2045         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2046         window.
2047         (tui_free_data_content): Update.
2048         (free_content_elements) <case DATA_WIN>: Free the window.
2049
2050 2019-06-25  Tom Tromey  <tom@tromey.com>
2051
2052         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2053         Update.
2054         * tui/tui-layout.c (make_command_window)
2055         (show_source_disasm_command, show_data, init_and_make_win)
2056         (show_source_or_disasm_and_command): Update.
2057         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2058         method.
2059         <can_highight, is_highlighted>: Now bool.
2060         (tui_set_win_highlight): Don't declare.
2061         * tui/tui-data.c (tui_set_win_highlight): Remove.
2062
2063 2019-06-25  Tom Tromey  <tom@tromey.com>
2064
2065         * tui/tui-wingeneral.c (make_visible): Remove check of window
2066         type.
2067
2068 2019-06-25  Tom Tromey  <tom@tromey.com>
2069
2070         * tui/tui-win.c (tui_win_info::max_height)
2071         (tui_cmd_window::max_height): New methods.
2072         (new_height_ok): Call max_height.
2073         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2074         <max_height>: New method.
2075
2076 2019-06-25  Tom Tromey  <tom@tromey.com>
2077
2078         * tui/tui-win.c (tui_source_window_base::set_new_height)
2079         (tui_data_window::set_new_height): New methods.
2080         (make_invisible_and_set_new_height): Call set_new_height method.
2081         * tui/tui-data.h (struct tui_win_info)
2082         (struct tui_source_window_base, struct tui_data_window)
2083         <set_new_height>: New method.
2084
2085 2019-06-25  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2088         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2089         tui_refresh_data_win.
2090         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2091         method.
2092         (tui_refresh_all_win): Call the refresh_all method.
2093         (tui_set_focus): Likewise.
2094         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2095         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2096         Likewise.
2097
2098 2019-06-25  Tom Tromey  <tom@tromey.com>
2099
2100         * tui/tui-winsource.h (tui_refill_source_window)
2101         (tui_set_is_exec_point_at): Don't declare.
2102         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2103         (tui_source_window_base::refill): Rename from
2104         tui_refill_source_window.
2105         (tui_source_window_base::do_scroll_horizontal): Update.
2106         (tui_source_window_base::set_is_exec_point_at): Rename from
2107         tui_set_is_exec_point_at.
2108         (tui_update_all_breakpoint_info): Update.
2109         * tui/tui-stack.c (tui_show_frame_info): Update.
2110         * tui/tui-layout.c (show_data): Add cast.
2111         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2112         * tui/tui-data.h (struct tui_source_window_base) <refill,
2113         set_is_exec_point_at>: New methods.
2114         (tui_source_windows, tui_add_to_source_windows): Update types.
2115         (tui_add_to_source_windows): Remove redundant declaration.
2116         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2117         (tui_source_windows): Change return type.
2118         (tui_clear_source_windows_detail): Update.
2119         (tui_add_to_source_windows): Change type of parameter.
2120         (tui_free_all_source_wins_content): Update.
2121
2122 2019-06-25  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-wingeneral.c (tui_win_info::refresh)
2125         (tui_source_window_base::refresh): New methods.
2126         (tui_refresh_all): Call the refresh method.
2127         * tui/tui-data.h (struct tui_win_info)
2128         (struct tui_source_window_base) <refresh>: New method.
2129
2130 2019-06-25  Tom Tromey  <tom@tromey.com>
2131
2132         * tui/tui.h (tui_is_window_visible): Return bool.
2133         * tui/tui.c (tui_is_window_visible): Return bool.
2134         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2135         (tui_make_visible, tui_make_invisible)
2136         (tui_win_info::make_visible)
2137         (tui_source_window_base::make_visible, make_all_visible)
2138         (tui_make_all_visible, tui_make_all_invisible): Update.
2139         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2140         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2141         bool.
2142         (struct tui_win_info, struct tui_source_window_base)
2143         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2144         * tui/tui-data.c (tui_init_generic_part): Update.
2145
2146 2019-06-25  Tom Tromey  <tom@tromey.com>
2147
2148         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2149         (tui_source_window_base::make_visible): New methods.
2150         (make_all_visible): Make method call.
2151         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2152         (struct tui_source_window_base, struct tui_cmd_window): Override
2153         make_visible.
2154         (tui_win_is_source_type): Don't declare.
2155         * tui/tui-data.c (tui_win_is_source_type): Remove.
2156
2157 2019-06-25  Tom Tromey  <tom@tromey.com>
2158
2159         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2160         NULL check.
2161
2162 2019-06-25  Tom Tromey  <tom@tromey.com>
2163
2164         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2165         Inline constructor.  Add initializers for members.
2166         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2167         constructors; now inline in class.
2168
2169 2019-06-25  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-regs.c (tui_show_registers): Update.
2172         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2173         bool.
2174         * tui/tui-data.c (tui_data_window::clear_detail)
2175         (tui_data_window): Update.
2176
2177 2019-06-25  Tom Tromey  <tom@tromey.com>
2178
2179         * tui/tui-windata.c (tui_display_all_data)
2180         (tui_display_data_from_line, tui_display_data_from)
2181         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2182         Update.
2183         * tui/tui-regs.c (tui_last_regs_line_no)
2184         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2185         (tui_show_registers, tui_show_register_group)
2186         (tui_display_registers_from, tui_display_reg_element_at_line)
2187         (tui_display_registers_from_line, tui_check_register_values)
2188         (tui_reg_next, tui_reg_prev): Update.
2189         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2190         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2191         tui_data_window.
2192         (struct tui_win_info) <detail>: Remove.  Add new fields from
2193         tui_data_info.
2194         (TUI_DATA_WIN): Add cast.
2195         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2196         (~tui_data_window): Simplify.
2197
2198 2019-06-25  Tom Tromey  <tom@tromey.com>
2199
2200         * tui/tui-layout.c (show_source_disasm_command)
2201         (show_source_or_disasm_and_command): Update.
2202         * tui/tui-io.c (update_cmdwin_start_line)
2203         (tui_redisplay_readline): Update.
2204         * tui/tui-data.h (struct tui_command_info): Remove.
2205         (struct tui_win_info) <detail>: Remove command_info member.
2206         (struct tui_data_window) <start_line>: New member, from
2207         tui_command_info.
2208         (TUI_CMD_WIN): Add casts.
2209
2210 2019-06-25  Tom Tromey  <tom@tromey.com>
2211
2212         * tui/tui-winsource.c (tui_update_source_window)
2213         (tui_refill_source_window)
2214         (tui_source_window_base::do_scroll_horizontal)
2215         (tui_update_breakpoint_info, tui_set_exec_info_content)
2216         (tui_show_exec_info_content, tui_erase_exec_info_content)
2217         (tui_clear_exec_info_content): Update.
2218         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2219         Update.
2220         * tui/tui-win.c (make_invisible_and_set_new_height)
2221         (make_visible_with_new_height): Update.
2222         * tui/tui-source.c (tui_set_source_content)
2223         (tui_show_symtab_source): Update.
2224         * tui/tui-layout.c (extract_display_start_addr)
2225         (show_source_disasm_command, show_data)
2226         (make_source_or_disasm_window)
2227         (show_source_or_disasm_and_command): Update.
2228         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2229         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2230         "gdbarch".
2231         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2232         to tui_source_window_base.
2233         (struct tui_win_info) <detail>: Remove source_info member.
2234         (struct tui_source_window_base) <has_locator>: Inline.
2235         Move contents from tui_source_info; rename has_locator member to
2236         m_has_locator.
2237         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2238         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2239         header file.
2240         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2241         Simplify.
2242         (tui_free_all_source_wins_content): Cast to
2243         tui_source_window_base.
2244
2245 2019-06-25  Tom Tromey  <tom@tromey.com>
2246
2247         * tui/tui-win.c (make_invisible_and_set_new_height)
2248         (make_visible_with_new_height): Call has_locator method.
2249         * tui/tui-layout.c (show_source_disasm_command, show_data)
2250         (show_source_or_disasm_and_command): Update for bool change.
2251         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2252         (tui_win_info) <has_locator>: New method.
2253         (struct tui_source_window_base) <has_locator>: New method.
2254         (tui_win_has_locator): Don't declare.
2255         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2256         from tui_win_has_locator.
2257         (tui_source_window_base): Use false, not FALSE.
2258
2259 2019-06-25  Tom Tromey  <tom@tromey.com>
2260
2261         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2262         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2263         clear_detail method directly.
2264         (tui_clear_win_detail): Remove.
2265
2266 2019-06-25  Tom Tromey  <tom@tromey.com>
2267
2268         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2269         "this", not TUI_DISASM_WIN.
2270
2271 2019-06-25  Tom Tromey  <tom@tromey.com>
2272
2273         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2274         declare.
2275         * tui/tui-winsource.c
2276         (tui_source_window_base::do_scroll_horizontal): Rename from
2277         tui_horizontal_source_scroll.
2278         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2279         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2280         from tui_vertical_data_scroll.
2281         * tui/tui-win.h (tui_scroll): Don't declare.
2282         * tui/tui-win.c (tui_win_info::forward_scroll)
2283         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2284         (tui_win_info::right_scroll): Rename and update.
2285         (tui_scroll_forward_command, tui_scroll_backward_command)
2286         (tui_scroll_left_command, tui_scroll_right_command): Update.
2287         (tui_scroll): Remove.
2288         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2289         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2290         from tui_vertical_source_scroll.
2291         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2292         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2293         from tui_vertical_disassem_scroll.
2294         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2295         do_scroll_horizontal>: New methods.
2296         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2297         Likewise.
2298         (struct tui_source_window_base): Add do_scroll_horizontal.
2299         (struct tui_source_window, struct tui_disasm_window): Add
2300         do_scroll_vertical.
2301         (struct tui_data_window, struct tui_cmd_window): Add
2302         do_scroll_horizontal and do_scroll_vertical.
2303         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2304
2305 2019-06-25  Tom Tromey  <tom@tromey.com>
2306
2307         * tui/tui-data.h (struct tui_source_window_base): New struct.
2308         (struct tui_source_window): Derive from tui_source_window_base.
2309         (struct tui_disasm_window): New struct.
2310         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2311         from tui_source_window::clear_detail.
2312         (tui_source_window_base): Rename from tui_source_window.
2313         (~tui_source_window_base): Rename from ~tui_source_window.
2314         (tui_alloc_win_info): Create a tui_disasm_window.
2315
2316 2019-06-25  Tom Tromey  <tom@tromey.com>
2317
2318         * tui/tui-data.h (struct tui_source_window)
2319         (struct tui_data_window): Declare destructors.
2320         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2321         destructors.
2322         (tui_win_info): Simplify.
2323
2324 2019-06-25  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-winsource.c (tui_display_main)
2327         (tui_update_source_windows_with_addr)
2328         (tui_update_all_breakpoint_info): Update.
2329         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2330         (new_height_ok, parse_scrolling_args): Update.
2331         * tui/tui-stack.c (tui_show_frame_info): Update.
2332         * tui/tui-data.h (struct tui_list): Remove.
2333         (tui_source_windows): Return a reference to a std::vector.
2334         * tui/tui-data.c (source_windows): Now a std::vector.
2335         (tui_source_windows): Change return type.
2336         (tui_clear_source_windows): Rewrite.
2337         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2338         (tui_free_all_source_wins_content): Rewrite.
2339
2340 2019-06-25  Tom Tromey  <tom@tromey.com>
2341
2342         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2343         (struct tui_data_window, struct tui_cmd_window): Declare
2344         clear_detail method.
2345         * tui/tui-data.c (tui_source_window::clear_detail)
2346         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2347         methods.
2348         (tui_clear_win_detail): Simplify.
2349
2350 2019-06-25  Tom Tromey  <tom@tromey.com>
2351
2352         * tui/tui-layout.c (make_source_window, make_disasm_window)
2353         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2354         Return the new window.
2355         (show_source_disasm_command, show_data)
2356         (show_source_or_disasm_and_command): Update.
2357
2358 2019-06-25  Tom Tromey  <tom@tromey.com>
2359
2360         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2361         parameter.  Return the new window.
2362         (show_source_disasm_command): Update and remove NULL check.
2363         (show_source_or_disasm_and_command): Update.
2364
2365 2019-06-25  Tom Tromey  <tom@tromey.com>
2366
2367         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2368
2369 2019-06-25  Tom Tromey  <tom@tromey.com>
2370
2371         * tui/tui-data.h (struct tui_win_info): Make constructor
2372         protected.  Make destructor virtual.  Add initializers.
2373         (tui_source_window, tui_data_window, tui_cmd_window): New
2374         classes.
2375         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2376         constructor.  Add "type" parameter.
2377         (tui_source_window, tui_data_window, tui_cmd_window): New
2378         constructors.
2379         (tui_alloc_win_info): Instantiate the appropriate subclass.
2380
2381 2019-06-25  Tom Tromey  <tom@tromey.com>
2382
2383         * tui/tui-win.c (tui_resize_all): Use delete.
2384         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2385         destructor.
2386         (tui_free_window): Don't declare.
2387         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2388         Update.
2389
2390 2019-06-25  Tom Tromey  <tom@tromey.com>
2391
2392         * tui/tui-data.h (struct tui_win_info): Add constructor.
2393         * tui/tui-data.c (tui_alloc_win_info): Use new.
2394         (tui_free_window): Use delete.
2395
2396 2019-06-22  Tom Tromey  <tom@tromey.com>
2397
2398         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2399         declare.
2400         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2401
2402 2019-06-22  Tom Tromey  <tom@tromey.com>
2403
2404         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2405         declare.
2406         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2407
2408 2019-06-22  Tom de Vries  <tdevries@suse.de>
2409
2410         * dwarf2read.c (create_addrmap_from_aranges)
2411         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2412         instead of '%zu'.
2413
2414 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2415
2416         * dwarf2read.h (dwarf2_section_info_def): Remove.
2417         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2418         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2419         std::vector<dwarf2_section_info>.
2420         (struct dwo_file) <~dwo_file>: Remove.
2421         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2422         types field.
2423         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2424         (dwarf2_read_debug_names): Likewise.
2425         (create_debug_types_hash_table): Change parameter type to
2426         array_view, adjust code accordingly.
2427         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2428         (partial_die_info::fixup): Likewise.
2429         (determine_prefix): Likewise.
2430         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2431
2432 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2433
2434         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2435         gdb_bfd_ref_ptr.
2436         <~dwo_file>: Remove call to gdb_bfd_unref.
2437         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2438         gdb_bfd_ref_ptr::get.
2439
2440 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2441
2442         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2443         type to htab_up.
2444         * dwarf2read.c (struct dwo_file): Initialize fields.
2445         <~dwo_file>: New.
2446         (free_dwo_file): Remove, move content to ~dwo_file.
2447         (struct dwo_file_deleter): Remove.
2448         (dwo_file_up>: Remove custom deleter.
2449         (free_dwo_files): Remove.
2450         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2451         dwo_files.
2452         (process_skeletonless_type_units): Call unique_ptr::get.
2453         (allocate_dwo_file_hash_table): Add deleter to created hash
2454         table.  Change return type to htab_up.
2455         (lookup_dwo_file_slot): Don't memset dwo_file, call
2456         unique_ptr::get.
2457         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2458         (create_dwo_unit_in_dwp_v2): Likewise.
2459         (open_and_init_dwo_file): Likewise.
2460         (free_dwo_file_from_slot): Remove.
2461
2462 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2463
2464         * dwarf2read.h (struct dwarf2_section_info) <readin,
2465         is_virtual>: Change type to bool.
2466         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2467         true instead of 1.
2468
2469 2019-06-19  Tom Tromey  <tom@tromey.com>
2470
2471         * tui/tui-data.h (tui_init_content_element): Don't declare.
2472
2473 2019-06-19  Tom Tromey  <tom@tromey.com>
2474
2475         * tui/tui-data.h (tui_init_win_info): Don't declare.
2476
2477 2019-06-19  Tom de Vries  <tdevries@suse.de>
2478
2479         * dwarf2read.h (abstract_to_concrete): Change type to
2480         std::unordered_map<sect_offset, std::vector<sect_offset>,
2481         gdb::hash_enum<sect_offset>>.
2482
2483 2019-06-19  Tom Tromey  <tromey@adacore.com>
2484
2485         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2486         EVAL_AVOID_SIDE_EFFECTS specially.
2487
2488 2019-06-19  Tom Tromey  <tromey@adacore.com>
2489
2490         * source-cache.c (highlighter): New global.
2491         (source_cache::get_source_lines): Create a highlighter on demand.
2492
2493 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2494
2495         * defs.h (deprecated_interactive_hook): Delete declaration.
2496         * interps.c (clear_interpreter_hooks): Remove use of
2497         deprecated_interactive_hook.
2498         * top.c (deprecated_interactive_hook): Delete definition.
2499         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2500
2501 2019-06-18  Tom de Vries  <tdevries@suse.de>
2502
2503         PR gdb/24515
2504         * dwarf2read.h (abstract_to_concrete): Change type from
2505         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2506         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2507         * dwarf2read.c (read_variable): Update.
2508         (dwarf2_fetch_die_loc_sect_off): Update.
2509
2510 2019-06-17  Tom de Vries  <tdevries@suse.de>
2511
2512         PR gdb/24617
2513         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2514         accessing parent[parent_len - 1].
2515
2516 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2517
2518         PR gdb/24364
2519         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2520         call dtrace_process_dof with NULL dof.
2521
2522 2019-06-16  Tom de Vries  <tdevries@suse.de>
2523
2524         PR gdb/24445
2525         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2526
2527 2019-06-16  Tom Tromey  <tom@tromey.com>
2528
2529         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2530         (make_all_visible): Use address of member.
2531
2532 2019-06-16  Tom Tromey  <tom@tromey.com>
2533
2534         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2535         (tui_free_window, free_content, free_content_elements): Remove
2536         unnecessary cast.
2537         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2538         cast.
2539         * tui/tui-regs.c (tui_show_register_group)
2540         (tui_display_registers_from, tui_display_reg_element_at_line):
2541         Remove unnecessary cast.
2542
2543 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2544
2545         * linux-nat.c (normal_mask): Delete.
2546         (_initialize_linux_nat): Don't initialise normal_mask.
2547
2548 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2549
2550         PR gdb/24445
2551         * dwarf-index-write.h (write_psymtabs_to_index): Add
2552         dwz_basename parameter.
2553         * dwarf-index-write.c (write_gdbindex): Move file writing to
2554         write_gdbindex_1.  Change return type void.
2555         (assert_file_size): Move up, remove filename parameter.
2556         (write_gdbindex_1): New function.
2557         (write_debug_names): Change return type to void, call
2558         assert_file_size.
2559         (struct index_wip_file): New struct.
2560         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2561         file logic to index_wip_file.  Write index for dwz file if
2562         needed.
2563         (save_gdb_index_command): Pass basename of dwz file, if present.
2564         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2565         build-id of dwz file, if present.
2566         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2567         (dwarf2_get_dwz_file): Likewise.
2568         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2569         (dwarf2_get_dwz_file): Likewise.
2570
2571 2019-06-16  Tom Tromey  <tom@tromey.com>
2572
2573         * coffread.c (process_coff_symbol): Use xstrdup.
2574         * value.c (create_internalvar): Use xstrdup.
2575
2576 2019-06-16  Tom Tromey  <tom@tromey.com>
2577
2578         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2579         * breakpoint.c (stopin_command, stopat_command)
2580         (until_break_command, decode_location_default): Remove unnecessary
2581         cast.
2582         * utils.c (subset_compare): Remove unnecessary cast.
2583         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2584         cast.
2585         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2586         cast.
2587         * infcmd.c (path_command): Remove unnecessary cast.
2588         * coffread.c (decode_type): Remove unnecessary cast.
2589         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2590         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2591         * tui/tui-stack.c (tui_show_locator_content)
2592         (tui_show_frame_info): Remove unnecessary cast.
2593         * tui/tui-win.c (tui_scroll_forward_command)
2594         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2595         (parse_scrolling_args): Remove unnecessary cast.
2596         * tui/tui-data.c (init_win_info, tui_del_window)
2597         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2598         (free_content_elements): Remove unnecessary cast.
2599         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2600         unnecessary cast.
2601         * tui/tui-source.c (tui_set_source_content)
2602         (tui_vertical_source_scroll): Remove unnecessary cast.
2603         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2604         cast.
2605         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2606         * tui/tui-regs.c (tui_display_registers_from)
2607         (tui_display_register): Remove unnecessary cast.
2608         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2609         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2610         (make_visible): Remove unnecessary cast.
2611         * tui/tui-winsource.c (tui_erase_source_content)
2612         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2613         unnecessary cast.
2614         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2615         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2616         * stabsread.c (read_type, read_array_type, read_range_type):
2617         Remove unnecessary cast.
2618         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2619         (parse_symbol, parse_type, upgrade_type, parse_external)
2620         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2621         unnecessary cast.
2622         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2623
2624 2019-06-16  Tom Tromey  <tom@tromey.com>
2625
2626         * tui/tui-data.c (tui_alloc_generic_win_info)
2627         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2628         checks.
2629
2630 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2631             Andrew Burgess  <andrew.burgess@embecosm.com>
2632
2633         * f-typeprint.c (f_print_type): Don't return early for not
2634         associated or not allocated types.
2635         (f_type_print_varspec_suffix): Add print_rank parameter and print
2636         ranks of array types in case they dangling.
2637         (f_type_print_base): Add print_rank parameter.
2638
2639 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2640
2641         * NEWS: Mention new MI commands.
2642         * break-catch-throw.c (enum exception_event_kind): Move to
2643         breakpoint.h.
2644         (print_mention_exception_catchpoint): Output text as a single
2645         message.
2646         (catch_exception_command_1): Rename to...
2647         (catch_exception_event): ...this, make non-static, update header
2648         command, and change some parameter types.
2649         (catch_catch_command): Update for changes to
2650         catch_exception_command_1.
2651         (catch_throw_command): Likewise.
2652         (catch_rethrow_command): Likewise.
2653         * breakpoint.c (enum exception_event_kind): Delete.
2654         * breakpoint.h (enum exception_event_kind): Moved here from
2655         break-catch-throw.c.
2656         (catch_exception_event): Declare.
2657         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2658         (mi_cmd_catch_throw): New function.
2659         (mi_cmd_catch_rethrow): New function.
2660         (mi_cmd_catch_catch): New function.
2661         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2662         'catch-catch' entries.
2663         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2664         (mi_cmd_catch_rethrow): Declare.
2665         (mi_cmd_catch_catch): Declare.
2666
2667 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2668
2669         * annotate.c (annotate_source_line): Change return type to void,
2670         update implementation to match.
2671         * annotate.h (annotate_source_line): Change return type to void,
2672         update header comment.
2673         * stack.c (print_frame_info): Don't change what frame information
2674         is printed based on whether annotations are on or not.
2675
2676 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2677
2678         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2679         (annotate_source): Make static.
2680         (annotate_source_line): Moved from source.c and renamed from
2681         identify_source_line.  Update the return type.
2682         * annotate.h (annotate_source): Delete declaration.
2683         (annotate_source_line): Declaration moved from source.h, and
2684         renamed from identify_source_line.  Return type updated.
2685         * source.c (identify_source_line): Moved to annotate.c and renamed
2686         to annotate_source_line.
2687         (info_line_command): Remove check of annotation_level.
2688         * source.h (identify_source_line): Move declaration to annotate.h
2689         and rename to annotate_source_line.
2690         * stack.c: Add 'annotate.h' include.
2691         (print_frame_info): Remove check of annotation_level before
2692         calling annotate_source_line.
2693
2694 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2695
2696         * source-cache.c (source_cache::get_plain_source_lines): Use
2697         open_source_file_with_line_charpos instead of just
2698         open_source_file, remove call to find_source_lines.
2699         (source_cache::get_source_lines): Likewise.
2700         * source.c (find_source_lines): Make static.
2701         (get_filename_and_charpos): Renamed into...
2702         (open_source_file_with_line_charpos): ..this along with changes to
2703         return a scoped_fd, and some other minor clean ups.
2704         (identify_source_line): Use open_source_file_with_line_charpos.
2705         (search_command_helper): Use open_source_file_with_line_charpos
2706         instead of just open_source_file, remove call to
2707         find_source_lines.
2708         * source.h (open_source_file_with_line_charpos): Declare new
2709         function.
2710         (find_source_lines): Delete declaration.
2711
2712 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2713
2714         * source.c (get_filename_and_charpos): Remove fullname
2715         parameter.
2716         (identify_source_line): Update call to get_filename_and_charpos.
2717
2718 2019-06-14  Tom Tromey  <tromey@adacore.com>
2719
2720         PR gdb/24502:
2721         * ui-style.h (skip_ansi_escape): Update comment.
2722         * ui-file.h (class no_terminal_escape_file): New class.
2723         * ui-file.c (no_terminal_escape_file::write)
2724         (no_terminal_escape_file::puts): New methods.
2725         * cli/cli-logging.c (handle_redirections): Use
2726         no_terminal_escape_file.
2727
2728 2019-06-14  Tom Tromey  <tromey@adacore.com>
2729
2730         * NEWS: Move convenience variable news above Python news.
2731
2732 2019-06-14  Tom Tromey  <tom@tromey.com>
2733
2734         * gnulib: Move directory to top-level.
2735         * configure.ac: Don't configure gnulib.
2736         * configure: Rebuild.
2737         * common/common-defs.h: Use new path to gnulib.
2738         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2739         (GNULIB_H): Remove.
2740         (INCGNU): Look in new gnulib location.
2741         (HFILES_NO_SRCDIR): Remove gnulib files.
2742         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2743         (generated_files): Remove GNULIB_H.
2744         ($(LIBGNU), all-lib): Remove targets.
2745         (distclean): Don't mention GNULIB_BUILDDIR.
2746         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2747
2748 2019-06-14  Tom Tromey  <tromey@adacore.com>
2749
2750         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2751         Warn if symbol file does not provide any symbols.
2752
2753 2019-06-14  Tom Tromey  <tromey@adacore.com>
2754
2755         * source.c (find_and_open_source): Respect basenames_may_differ.
2756
2757 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2758
2759         * annotate.c (annotate_breakpoints_invalid): Make use of
2760         scoped_restore_terminal_state.
2761         (annotate_frames_invalid): Likewise.
2762
2763 2019-06-14  Tom Tromey  <tromey@adacore.com>
2764
2765         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2766         allow assignment to an internalvar.
2767
2768 2019-06-14  Tom Tromey  <tromey@adacore.com>
2769
2770         * ada-lex.l: Allow "_" in attribute names.
2771
2772 2019-06-14  Tom Tromey  <tromey@adacore.com>
2773
2774         PR gdb/24653:
2775         * regcache.c (registers_changed): Don't call alloca.
2776         * top.c (execute_command): Don't call alloca.
2777
2778 2019-06-13  Pedro Alves  <palves@redhat.com>
2779
2780         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2781         'expression'.  When parsing an expression, error out if there's
2782         junk after "unlimited".
2783         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2784         (do_set_command): Adjust calls to is_unlimited_literal.
2785
2786 2019-06-13  Pedro Alves  <palves@redhat.com>
2787
2788         * compile/compile.c (make_compile_options_def_group): Add braces
2789         around array_view initializer.
2790         * thread.c (make_thread_apply_all_options_def_group)
2791         (make_thread_apply_all_options_def_group): Likewise.
2792
2793 2019-06-13  Pedro Alves  <palves@redhat.com>
2794
2795         * NEWS (New commands): Mention "maint test-options
2796         require-delimiter", "maint test-options unknown-is-error", "maint
2797         test-options unknown-is-operand" and "maint show
2798         test-options-completion-result".
2799         (New command options, command completion): New section.
2800         (Completion improvements): New section.
2801         Mention that you can abbreviate "unlimited".
2802
2803 2019-06-13  Pedro Alves  <palves@redhat.com>
2804
2805         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2806         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2807         * unittests/cli-utils-selftests.c (test_parse_flags)
2808         (test_parse_flags_qcs): Delete.
2809         (test_cli_utils): Don't call deleted functions.
2810
2811 2019-06-13  Pedro Alves  <palves@redhat.com>
2812
2813         * thread.c: Include "cli/cli-option.h".
2814         (tp_array_compar_ascending): Global.
2815         (tp_array_compar): Delete function.
2816         (tp_array_compar_ascending, tp_array_compar_descending): New
2817         functions.
2818         (ascending_option_def, qcs_flag_option_def)
2819         (thr_qcs_flags_option_defs)
2820         (make_thread_apply_all_options_def_group)
2821         (make_thread_apply_options_def_group): New.
2822         (thread_apply_all_command): Use gdb::option::process_options.
2823         (thread_apply_command_completer)
2824         (thread_apply_all_command_completer): New.
2825         (thread_apply_command): Use gdb::option::process_options.
2826         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2827         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2828         to generate help text of "thread apply".  Adjust "taas"'s help.
2829         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2830         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2831
2832 2019-06-13  Pedro Alves  <palves@redhat.com>
2833
2834         * thread.c (thread_apply_command): Check for invalid TID with
2835         isdigit instead of !isalpha.
2836
2837 2019-06-13  Pedro Alves  <palves@redhat.com>
2838
2839         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2840         (validate_flags_qcs): New.
2841         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2842         (validate_flags_qcs): Declare.
2843         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2844         (make_frame_apply_options_def_group): New.
2845         (frame_apply_command_count): Process options with
2846         gdb::option::process_options.
2847         (frame_apply_completer): New.
2848         (frame_apply_level_completer, frame_apply_all_completer)
2849         (frame_apply_completer): New.
2850         (_initialize_stack): Update help of "frame apply", "frame apply
2851         level", "frame apply all" and "faas" to mention supported options
2852         and install command completers.
2853         * stack.h (frame_apply_all_completer): Declare.
2854         * thread.c: Include "stack.h".
2855         (tfaas_command): Add "--".
2856         (_initialize_thread): Update help "tfaas" to mention supported
2857         options and install command completer.
2858
2859 2019-06-13  Pedro Alves  <palves@redhat.com>
2860
2861         * completer.c (complete_nested_command_line): New.
2862         (gdb_completion_word_break_characters_throw): Add assertion.
2863         * completer.h (complete_nested_command_line): Declare.
2864
2865 2019-06-13  Pedro Alves  <palves@redhat.com>
2866
2867         * stack.c (parse_backtrace_qualifiers): New.
2868         (backtrace_command): Use it.
2869         (backtrace_command_completer): Complete on qualifiers.
2870
2871 2019-06-13  Pedro Alves  <palves@redhat.com>
2872
2873         * frame.c: Include "cli/cli-option.h.
2874         (user_set_backtrace_options): New.
2875         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2876         Delete.
2877         (get_prev_frame): Adjust.
2878         (boolean_option_def, uinteger_option_def)
2879         (set_backtrace_option_defs): New.
2880         (_initialize_frame): Adjust and use
2881         gdb::option::add_setshow_cmds_for_options to install "set
2882         backtrace past-main" and "set backtrace past-entry".
2883         * frame.h: Include "cli/cli-option.h".
2884         (struct frame_print_options): Forward declare.
2885         (print_frame_arguments_all, print_frame_arguments_scalars)
2886         (print_frame_arguments_none): Declare.
2887         (print_entry_values): Delete declaration.
2888         (struct frame_print_options, user_frame_print_options): New.
2889         (struct set_backtrace_options): New.
2890         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2891         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2892         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2893         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2894         (list_args_or_locals): Add frame_print_options parameter.
2895         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2896         * python/py-framefilter.c (enumerate_args): Pass down
2897         USER_FRAME_PRINT_OPTIONS.
2898         * stack.c: Include "cli/cli-option.h".
2899         (print_frame_arguments_all, print_frame_arguments_scalars)
2900         (print_frame_arguments_none): Declare.
2901         (print_raw_frame_arguments, print_entry_values): Delete.
2902         (user_frame_print_options): New.
2903         (boolean_option_def, enum_option_def, frame_print_option_defs):
2904         New.
2905         (struct backtrace_cmd_options): New.
2906         (bt_flag_option_def): New.
2907         (backtrace_command_option_defs): New.
2908         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2909         (print_frame_arg, read_frame_arg, print_frame_args)
2910         (print_frame_info, print_frame): Add frame_print_options parameter
2911         and use it.
2912         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2913         (backtrace_command_1): Add frame_print_options and
2914         backtrace_cmd_options parameters and use them.
2915         (make_backtrace_options_def_group): New.
2916         (backtrace_command): Process command options with
2917         gdb::option::process_options.
2918         (backtrace_command_completer): New.
2919         (_initialize_stack): Extend "backtrace"'s help to mention
2920         supported options.  Install completer for "backtrace".
2921         Install some settings commands with add_setshow_cmds_for_options.
2922
2923 2019-06-13  Pedro Alves  <palves@redhat.com>
2924
2925         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2926         and that "set/show print raw frame-arguments" are now deprecated.
2927
2928         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2929         command.
2930         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2931         * stack.c (_initialize_stack): Install "set/show print
2932         raw-frame-arguments", and deprecate "set/show print raw
2933         frame-arguments".
2934         * valprint.c (_initialize_valprint): Deprecate "set/show print
2935         raw".
2936
2937 2019-06-13  Pedro Alves  <palves@redhat.com>
2938
2939         * compile/compile.c (struct compile_options): New.
2940         (compile_flag_option_def, compile_command_option_defs)
2941         (make_compile_options_def_group): New.
2942         (compile_file_command): Handle options with
2943         gdb::option::process_options.
2944         (compile_file_command_completer): New function.
2945         (compile_code_command): Handle options with
2946         gdb::option::process_options.
2947         (compile_code_command_completer): New function.
2948         (_initialize_compiler): Install completers for "compile code" and
2949         "compile file".  Mention available options in "compile code" and
2950         "compile code"'s help.
2951         * completer.c (advance_to_completion_word): New, factored out from
2952         ...
2953         (advance_to_expression_complete_word_point): ... this.
2954         (advance_to_filename_complete_word_point): New.
2955         * completer.h (advance_to_filename_complete_word_point): New
2956         declaration.
2957
2958 2019-06-13  Pedro Alves  <palves@redhat.com>
2959
2960         * compile/compile.c: Include "cli/cli-option.h".
2961         (compile_print_value): Scope data pointer is now a
2962         value_print_options pointer; adjust.
2963         (compile_print_command): Process options.  Scope data pointer is
2964         now a value_print_options pointer; adjust.
2965         (_initialize_compile): Update "compile print"'s help to include
2966         supported options.  Install a completer for "compile print".
2967         * cp-valprint.c (show_vtblprint, show_objectprint)
2968         (show_static_field_print): Delete.
2969         (_initialize_cp_valprint): Don't install "set print
2970         static-members", "set print vtbl", "set print object" here.
2971         * printcmd.c: Include "cli/cli-option.h" and
2972         "common/gdb_optional.h".
2973         (print_command_parse_format): Rework to fill in a
2974         value_print_options instead of a format_data.
2975         (print_value): Change parameter type from format_data pointer to
2976         value_print_options reference.  Adjust.
2977         (print_command_1): Process options.  Adjust to pass down a
2978         value_print_options.
2979         (print_command_completer): New.
2980         (_initialize_printcmd): Install print_command_completer as
2981         handle_brkchars completer for the "print" command.  Update
2982         "print"'s help to include supported options.
2983         * valprint.c: Include "cli/cli-option.h".
2984         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2985         here from cp-valprint.c.
2986         (boolean_option_def, uinteger_option_def)
2987         (value_print_option_defs, make_value_print_options_def_group):
2988         New.  Use gdb::option::add_setshow_cmds_for_options to install
2989         "set print elements", "set print null-stop", "set print repeats",
2990         "set print pretty", "set print union", "set print array", "set
2991         print address", "set print symbol", "set print array-indexes".
2992         * valprint.h: Include <string> and "cli/cli-option.h".
2993         (make_value_print_options_def_group): Declare.
2994         (print_value): Change parameter type from format_data pointer to
2995         value_print_options reference.
2996         (print_command_completer): Declare.
2997
2998 2019-06-13  Pedro Alves  <palves@redhat.com>
2999
3000         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3001         (COMMON_SFILES): Add maint-test-settings.c.
3002         * cli/cli-decode.c (boolean_enums): New global, factored out from
3003         ...
3004         (add_setshow_boolean_cmd): ... here.
3005         * cli/cli-decode.h (boolean_enums): Declare.
3006         * cli/cli-option.c: New file.
3007         * cli/cli-option.h: New file.
3008         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3009         factored out from ...
3010         (parse_cli_boolean_value(const char *)): ... this.
3011         (is_unlimited_literal): Change parameter type to pointer to
3012         pointer.  Adjust and advance ARG pointer.
3013         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3014         (parse_cli_var_enum): New, factored out from ...
3015         (do_set_command): ... this.  Adjust.
3016         * cli/cli-setshow.h (parse_cli_boolean_value)
3017         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3018         (parse_cli_var_enum): Declare.
3019         * cli/cli-utils.c: Include "cli/cli-option.h".
3020         (get_ulongest): New.
3021         * cli/cli-utils.h (get_ulongest): Declare.
3022         (check_for_argument): New overloads.
3023         * maint-test-options.c: New file.
3024
3025 2019-06-13  Pedro Alves  <palves@redhat.com>
3026
3027         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3028         parse a range if "-" is at the end of the string.
3029
3030 2019-06-13  Pedro Alves  <palves@redhat.com>
3031
3032         * cli/cli-setshow.c (parse_auto_binary_operation)
3033         (parse_cli_boolean_value): Don't allow "o".
3034
3035 2019-06-13  Pedro Alves  <palves@redhat.com>
3036
3037         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3038         * NEWS: Mention maint test-settings KIND.
3039         * maint-test-settings.c: New file.
3040
3041 2019-06-13  Pedro Alves  <palves@redhat.com>
3042
3043         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3044         completer.
3045         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3046         "set" completers.
3047
3048 2019-06-13  Pedro Alves  <palves@redhat.com>
3049
3050         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3051         after item.
3052
3053 2019-06-13  Pedro Alves  <palves@redhat.com>
3054
3055         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3056
3057 2019-06-13  Pedro Alves <palves@redhat.com>
3058
3059         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3060         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3061         call.
3062         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3063         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3064         calls.
3065         (check_for_argument): Skip spaces after argument.
3066
3067 2019-06-13  Pedro Alves  <palves@redhat.com>
3068
3069         * thread.c (thread_apply_command): Adjust TID parsing.
3070         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3071         detected before end of string.
3072         (tid_is_in_list): Error out if LIST is invalid.
3073
3074 2019-06-13  Pedro Alves  <palves@redhat.com>
3075
3076         * completer.c (complete_line_internal_1): Rewind completion word
3077         point.
3078         (completion_tracker::advance_custom_word_point_by): Change
3079         parameter type to int.
3080         * completer.h (completion_tracker::advance_custom_word_point_by):
3081         Likewise.
3082
3083 2019-06-13  Pedro Alves  <palves@redhat.com>
3084
3085         * completer.c (advance_to_completion_word): Handle delimiters.
3086
3087 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3088
3089         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3090
3091 2019-06-11  Tom Tromey  <tom@tromey.com>
3092
3093         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3094         (xmalloc_failed): Move to alloc.c.
3095         * alloc.c: New file.
3096         * Makefile.in (COMMON_SFILES): Add alloc.c.
3097
3098 2019-06-11  Tom Tromey  <tom@tromey.com>
3099
3100         * nat/linux-waitpid.c: Don't include server.h.
3101         (linux_debug): Remove.
3102         (my_waitpid): Update.
3103
3104 2019-06-11  Tom Tromey  <tromey@adacore.com>
3105
3106         * infcall.c (_initialize_infcall): Remove trailing newline from
3107         help.
3108         * user-regs.c (_initialize_user_regs): Remove trailing newline
3109         from help.
3110         * typeprint.c (_initialize_typeprint): Remove trailing newline
3111         from help.
3112         * reverse.c (_initialize_reverse): Remove trailing newlines from
3113         help.
3114         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3115         from help.
3116         * language.c (add_set_language_command): Remove trailing newline
3117         from help.
3118         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3119         help.
3120         * disasm.c (_initialize_disasm): Remove trailing newline from
3121         help.
3122         * top.c (init_main): Remove trailing newline from help.
3123         * interps.c (_initialize_interpreter): Remove trailing newline
3124         from help.
3125         * btrace.c (_initialize_btrace): Remove trailing newlines from
3126         help.
3127         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3128         from help.
3129         * python/python.c (_initialize_python): Remove trailing newline
3130         from help.
3131         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3132         help.
3133         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3134         from help.  Reformat some text.
3135         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3136         from help.
3137         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3138         newline from help.
3139
3140 2019-06-11  Tom Tromey  <tromey@adacore.com>
3141
3142         * darwin-nat.c (darwin_decode_exception_message)
3143         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3144
3145 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3146
3147         * valops.c (value_slice): Check for not allocated or not
3148         associated values.
3149
3150 2019-06-10  Tom de Vries  <tdevries@suse.de>
3151
3152         PR gdb/24618
3153         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3154         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3155         invalid.
3156
3157 2019-06-10  Tom de Vries  <tdevries@suse.de>
3158
3159         PR gdb/24611
3160         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3161         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3162
3163 2019-06-10  Tom de Vries  <tdevries@suse.de>
3164
3165         PR symtab/24545
3166         * symtab.c (struct demangled_name_entry): Add language field.
3167         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3168         static minimal symbol".  Set and use language field.
3169
3170 2019-06-10  Tom Tromey  <tromey@adacore.com>
3171
3172         * ada-lang.c (_initialize_ada_language): Update help text.
3173
3174 2019-06-10  Tom Tromey  <tromey@adacore.com>
3175
3176         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3177         with a newline.
3178         * guile/guile.c (handle_boot_error): Don't end warning with a
3179         newline.
3180         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3181         warning with a newline.
3182         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3183         newline.
3184         (s12z_frame_cache): Likewise.
3185         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3186         a newline.
3187         * solib-svr4.c (disable_probes_interface): Don't end warning with
3188         a newline.
3189         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3190         newline.
3191         * python/python.c (do_finish_initialization): Don't end warning
3192         with a newline.
3193
3194 2019-06-10  Tom Tromey  <tom@tromey.com>
3195
3196         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3197         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3198         gdbpy_enter.
3199
3200 2019-06-10  Tom Tromey  <tromey@adacore.com>
3201
3202         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3203         data.
3204         (elf_new_init): Don't call stabsread_new_init.
3205         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3206         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3207         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3208
3209 2019-06-10  Tom de Vries  <tdevries@suse.de>
3210
3211         PR symtab/16264
3212         PR symtab/24517
3213         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3214
3215 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3216
3217         * source.c (find_and_open_source): Also rewrite relative file
3218         names.
3219
3220 2019-04-26  Amos Bird  <amosbird@gmail.com>
3221
3222         * annotate.c (annotate_thread_exited): Add "thread-exited"
3223         annotation.
3224
3225 2019-06-06  Tom Tromey  <tromey@adacore.com>
3226
3227         * maint.h (class scoped_command_stats): Use
3228         DISABLE_COPY_AND_ASSIGN.
3229         <print_time>: New method.
3230         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3231         print_time.
3232         (scoped_command_stats::print_time): New method.
3233
3234 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3235
3236         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3237         instructions of lengths 6 or 8 bytes.
3238
3239 2019-06-04  Pedro Alves  <palves@redhat.com>
3240
3241         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3242
3243         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3244         * breakpoint.c (condition_completer): Likewise.
3245         * cli/cli-dump.c (scan_expression): Likewise.
3246         * common/filestuff.c (mkdir_recursive): Likewise.
3247         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3248         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3249         (gdb_abspath): Likewise.
3250         * compile/compile-cplus-types.c
3251         (compile_cplus_instance::decl_name): Likewise.
3252         * completer.c (complete_explicit_location):
3253         (signal_completer, reg_or_group_completer_1): Likewise.
3254         * cp-support.c (cp_remove_params_if_any): Likewise.
3255         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3256         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3257         * infcmd.c (strip_bg_char): Likewise.
3258         * linespec.c (copy_token_string): Likewise.
3259         * mi/mi-main.c (output_cores): Likewise.
3260         * psymtab.c (psymtab_search_name):
3261         * symfile.c (test_set_ext_lang_command): Likewise.
3262         * target.c (target_fileio_read_stralloc): Likewise.
3263         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3264         * value.c (complete_internalvar): Likewise.
3265
3266 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3267
3268         Add objfile property to gdb.Type.
3269         * NEWS: Mention Python API addition.
3270         * python/py-type.c (typy_get_objfile): New method.
3271
3272 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3273
3274         * NEWS: Mention the new set|show style [title|highlight].
3275         Mention changes to "show style", "help" and "apropos".
3276
3277 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3278
3279         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3280         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3281         instead of print_help_for_command.
3282         (print_doc_of_command): New function.
3283         (help_list): Add 'apropos -v word' suggestion.
3284         (print_help_for_command): Style the command name using title style.
3285         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3286         (_initialize_cli_cmds): Describe -v in apropos_command help.
3287
3288 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3289
3290         * cli/cli-style.h (cli_style_option): Add name in constructor,
3291         add m_name class member, add constructor with intensity,
3292         add name class function.
3293         (cli_style_option::add_setshow_commands): Remove name argument.
3294         (highlight_style, title_style): New styles.
3295         * cli/cli-style.c (do_show): New function that shows a style
3296         characteristic styling the style name with itself.
3297         (set_style_name): New function.
3298         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3299         Update all callers according to the changes in cli/cli-style.h.
3300         * utils.h (fputs_highlighted): New function.
3301         * utils.c (fputs_highlighted): Likewise.
3302
3303 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3304
3305         * NEWS: Mention new pipe command and new convenience variables.
3306
3307 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3308
3309         * cli/cli-cmds.c (pipe_command): New function.
3310         (_initialize_cli_cmds): Call add_com for pipe_command.
3311         Define | as an alias for pipe.
3312         (exit_status_set_internal_vars): New function.
3313         (shell_escape): Call exit_status_set_internal_vars.
3314         cli/cli-decode.c (find_command_name_length): Recognize | as
3315         a single character command.
3316
3317 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3318
3319         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3320         top.c (execute_command_to_ui_file): New function, mostly a copy
3321         of execute_command_to_string.
3322         (execute_command_to_string): Implement by calling
3323         execute_command_to_ui_file.
3324
3325 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3326
3327         * top.h (saved_command_line): Remove declaration.
3328         * top.c (previous_saved_command_line, previous_repeat_arguments):
3329         New variables.
3330         (saved_command_line): Make static, define together with other
3331         'repeat variables'.
3332         (dont_repeat): Clear repeat_arguments.
3333         (repeat_previous, get_saved_command_line, save_command_line):
3334         New functions.
3335         (gdb_init): Initialize saved_command_line
3336         and previous_saved_command_line.
3337         * main.c (captured_main_1): Remove saved_command_line initialization.
3338         * event-top.c (handle_line_of_input): Update to use
3339         the new 'repeat' related functions instead of direct access to
3340         saved_command_line.
3341         * command.h (repeat_previous, get_saved_command_line,
3342         save_command_line): New declarations.
3343         (dont_repeat): Add comment.
3344
3345 2019-05-30  Tom Tromey  <tromey@adacore.com>
3346
3347         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3348         Fix comment.
3349         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3350
3351 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3352
3353         PR cli/24587
3354         * completer.c (complete): Initialize variable word.
3355
3356 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3357
3358         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3359         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3360         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3361         'body' is NULL to the outter 'if', protecting the '!is_define'
3362         situation as well.
3363
3364 2019-05-29  Tom Tromey  <tromey@adacore.com>
3365
3366         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3367         (dwarf_unknown): New function.
3368         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3369         (dwarf_type_encoding_name): Use dwarf_unknown.
3370
3371 2019-05-29  Tom Tromey  <tromey@adacore.com>
3372
3373         PR c++/20020:
3374         * cp-valprint.c (cp_print_value_fields): Call
3375         cp_print_static_field inside "try".
3376
3377 2019-05-29  Tom Tromey  <tromey@adacore.com>
3378
3379         * inflow.c (struct terminal_info): Add default operator=.
3380         * configure: Rebuild.
3381         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3382         -Wdeprecated-copy-dtor, -Wredundant-move.
3383
3384 2019-05-29  Tom Tromey  <tromey@adacore.com>
3385
3386         * NEWS: Add entry.
3387         * infcmd.c (print_return_value_1): Handle finish_print
3388         option.
3389         (show_print_finish): New function.
3390         (_initialize_infcmd): Add "set/show print finish" commands.
3391         * valprint.c (user_print_options): Initialize new member.
3392         * valprint.h (struct value_print_options) <finish_print>: New
3393         member.
3394
3395 2019-05-28  Tom Tromey  <tromey@adacore.com>
3396
3397         * ada-lang.c (ada_remove_Xbn_suffix)
3398         (find_old_style_renaming_symbol)
3399         (parse_old_style_renaming): Remove.
3400         (ada_find_renaming_symbol): Don't call
3401         find_old_style_renaming_symbol.
3402         (ada_is_renaming_symbol): Rename from
3403         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3404         bool.  Now static.
3405         (ada_read_var_value): Update and simplify.
3406         * ada-exp.y (write_var_or_type): Remove old code.
3407
3408 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3409
3410         * event-top.c: Remove include comment.
3411         * inflow.c (class scoped_ignore_sigttou): Move from here...
3412         * inflow.h (class scoped_ignore_sigttou): ...to here.
3413         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3414         * top.c:  Remove include comment.
3415
3416 2019-05-27  Tom Tromey  <tom@tromey.com>
3417
3418         * NEWS: Fix typo.
3419
3420 2019-05-22  Tom Tromey  <tromey@adacore.com>
3421
3422         * target.c (target_follow_exec): Constify parameter.
3423         * target-delegates.c: Rebuild.
3424         * remote.c (remote_target::follow_exec): Constify parameter.
3425         * infrun.c (follow_exec): Constify parameter.
3426         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3427         (target_follow_exec): Likewise.
3428
3429 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3430
3431         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3432         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3433
3434 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3435
3436         * NEWS: Add debugredirect and testsuite sections.
3437
3438 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3439
3440         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3441         target descriptions using exclusively floating point register name
3442         aliases.
3443
3444 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3445
3446         PR gdb/18644:
3447         * f-lang.c (build_fortran_types): Handle the case where
3448         gdbarch_floatformat_for_type returns a nullptr.
3449
3450 2019-05-21  Tom de Vries  <tdevries@suse.de>
3451
3452         PR cli/24587
3453         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3454
3455 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3456
3457         PR gdb/18644:
3458         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3459         16-byte floats.
3460         * i386-tdep.c (i386_floatformat_for_type): Use
3461         floatformats_ia64_quad for the 16-byte floating point component
3462         within a fortran 32-byte complex number.
3463
3464 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3465
3466         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3467         delete default constructor.
3468         (find_partial_die): Update to return const struct.
3469         (partial_die_parent_scope): Move variable declaration into scope
3470         of its use and change its type to auto.
3471         (guess_partial_die_structure_name): Likewise.
3472         (partial_die_info::fixup): Likewise.
3473
3474 2019-05-17  Tom Tromey  <tromey@adacore.com>
3475
3476         * source.c (find_and_open_source): Remove cast.
3477
3478 2019-05-17  Tom Tromey  <tromey@adacore.com>
3479
3480         * annotate.c (annotate_source): Make "filename" const.
3481         * annotate.h (annotate_source): Use const.
3482
3483 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3484
3485         * disasm.c (set_disassembler_options): Send errors to stderr.
3486
3487 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3488
3489         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3490         (cli_interp_base::set_logging): Check debug_redirect.
3491         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3492         * cli/cli-logging.c (debug_redirect): Add static variable.
3493         (pop_output_files): Add default param.
3494         (handle_redirections): Print debug setting.
3495         (show_logging_command): Likewise.
3496         (_initialize_cli_logging): Add debugredirect command.
3497         * interps.c (current_interp_set_logging): Add debug_redirect
3498         parameter.
3499         * interps.h (set_logging): Add debug_redirect parameter.
3500         (current_interp_set_logging): Likewise.
3501         * mi/mi-common.h: Likewise.
3502         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3503
3504 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3505             Tom Tromey  <tromey@adacore.com>
3506
3507         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3508         directly.
3509         * cli/cli-interp.h (make_logging_output): Remove declaration.
3510         * cli/cli-logging.c (make_logging_output): Remove function.
3511         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3512         directly.
3513         * ui-file.c (tee_file::tee_file): Remove bools.
3514         (tee_file::~tee_file): Remove deletes.
3515         * ui-file.h (tee_file): Remove bools.
3516
3517 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3518
3519         * mi/mi-cmds.h (mi_cmd_complete): New function.
3520         * mi/mi-main.c (mi_cmd_complete): Likewise.
3521         * mi/mi-cmds.c: Define new MI command -complete.
3522         * NEWS: Mention new -complete command.
3523
3524 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3525
3526         * completer.h (complete): New function.
3527         * completer.c (complete): Likewise.
3528         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3529         function defined in completer.h.
3530
3531 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3532
3533         * MAINTAINERS (Write After Approval): Add myself.
3534
3535 2019-05-17  Tom de Vries  <tdevries@suse.de>
3536
3537         PR gdb/24094
3538         * dwarf2read.c (struct cu_partial_die_info): New struct.
3539         (find_partial_die): Return cu_partial_die_info.
3540         (partial_die_parent_scope, guess_partial_die_structure_name)
3541         (partial_die_info::fixup): Handle new return type of find_partial_die.
3542
3543 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3544
3545         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3546         "std::string", simplifying the algorithm.
3547
3548 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3549
3550         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3551         (stap_static_probe_ops::get_probes): Likewise.
3552
3553 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3554
3555         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3556         '-')" and "else if".
3557         (stap_parse_single_operand): Join checks for
3558         "gdbarch_stap_parse_special_token_p" and
3559         "gdbarch_stap_parse_special_token" in the same "if" statement.
3560         Invert check when verifying for operation on register
3561         displacement.
3562
3563 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3564
3565         * stap-probe.c (stap_get_opcode): Update comment.
3566         (stap_get_expected_argument_type): Likewise.
3567         (handle_stap_probe): Likewise.
3568
3569 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3570
3571         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3572         return type to 'bool'.  Adjust comment.  Use 'bool' when
3573         appropriate.
3574         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3575         * stap-probe.c (stap_parse_argument_1): Likewise.
3576         (stap_is_operator): Likewise.
3577         (stap_is_generic_prefix): Likewise.
3578         (stap_is_register_prefix): Likewise.
3579         (stap_is_register_indirection_prefix): Likewise.
3580         (stap_is_integer_prefix): Likewise.
3581         (stap_generic_check_suffix): Likewise.
3582         (stap_check_integer_suffix): Likewise.
3583         (stap_check_register_suffix): Likewise.
3584         (stap_check_register_indirection_suffix): Likewise.
3585         (stap_parse_register_operand): Likewise.
3586         (stap_parse_single_operand): Likewise.
3587         (stap_parse_argument_1): Likewise.
3588         (stap_probe::get_argument_count): Likewise.
3589         (stap_is_operator): Likewise.
3590
3591 2019-05-16  Tom Tromey  <tromey@adacore.com>
3592
3593         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3594         keyword to foreach.
3595
3596 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3597
3598         * linux-thread-db.c (try_thread_db_load_1): Change return type
3599         to bool.
3600         (try_thread_db_load): Likewise.
3601         (try_thread_db_load_from_pdir_1): Likewise.
3602         (try_thread_db_load_from_pdir): Likewise.
3603         (try_thread_db_load_from_sdir): Likewise.
3604         (try_thread_db_load_from_dir): Likewise.
3605         (thread_db_load_search): Likewise.
3606         (has_libpthread): Likewise.
3607         (thread_db_load): Likewise.
3608
3609 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3610
3611         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3612         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3613         NULL, and complain/return if that's the case.
3614
3615 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3616
3617         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3618         (advance, posn, abstract_read_memory): New functions.
3619         [struct mem_read_abstraction]: New struct.
3620         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3621
3622 2019-05-14  Tom Tromey  <tromey@adacore.com>
3623
3624         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3625         value is not lval_memory.
3626
3627 2019-05-14  Tom Tromey  <tromey@adacore.com>
3628
3629         * solib.c (info_sharedlibrary_command): Style the file name.
3630
3631 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3632
3633         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3634         (aarch64_vnv_type): Likewise.
3635         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3636         * common/tdesc.c: Likewise.
3637         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3638         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3639         * features/aarch64-fpu.xml: Add ieee half view.
3640         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3641         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3642         * gdbtypes.h (struct builtin_type): Likewise.
3643         (struct objfile_type): Likewise.
3644
3645 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3646
3647         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3648         typo.
3649         * location.h (string_to_event_location): Likewise.
3650
3651 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3652
3653         GDB 8.3 released.
3654
3655 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3656
3657         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3658         New variable declaration.
3659         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3660         New variable.
3661         (print_one_breakpoint): Use ui_out::test_flags and new global
3662         variable to compute use_fixed_output.
3663         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3664         Remove.
3665         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3666         (mi_multi_location_breakpoint_output_fixed): Remove.
3667         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3668         new variable.
3669         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3670         fix_multi_location_breakpoint_output flag if version >= 3.
3671         * ui-out.h (enum ui_out_flag)
3672         <fix_multi_location_breakpoint_output>: New enumerator.
3673
3674 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3675
3676         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3677
3678 2019-05-10  Tom Tromey  <tromey@adacore.com>
3679
3680         * ada-lang.c (catch_ada_completer): New function.
3681         (_initialize_ada_language): Use it.
3682
3683 2019-05-10  Tom Tromey  <tromey@adacore.com>
3684
3685         * thread.c (print_thread_info): Make "requested_threads" const.
3686         * gdbthread.h (print_thread_info): Make "requested_threads"
3687         const.
3688         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3689         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3690
3691 2019-05-08  Tom Tromey  <tom@tromey.com>
3692
3693         * gdbtypes.c (objfile_type_data): Change type.
3694         (objfile_type, _initialize_gdbtypes): Update.
3695
3696 2019-05-08  Tom Tromey  <tom@tromey.com>
3697
3698         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3699         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3700         (_initialize_dwarf2_frame): Update.
3701
3702 2019-05-08  Tom Tromey  <tom@tromey.com>
3703
3704         * objc-lang.c (objc_objfile_data): Change type.
3705         (find_methods): Update.
3706         (_initialize_objc_lang): Remove.
3707
3708 2019-05-08  Tom Tromey  <tom@tromey.com>
3709
3710         * stabsread.c (rs6000_builtin_type_data): Change type.
3711         (rs6000_builtin_type, _initialize_stabsread): Update.
3712
3713 2019-05-08  Tom Tromey  <tom@tromey.com>
3714
3715         * mips-tdep.c (mips_pdr_data): Remove.
3716         (_initialize_mips_tdep): Update.
3717
3718 2019-05-08  Tom Tromey  <tom@tromey.com>
3719
3720         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3721         (hppa_init_objfile_priv_data, read_unwind_info)
3722         (find_unwind_entry, _initialize_hppa_tdep): Update.
3723
3724 2019-05-08  Tom Tromey  <tom@tromey.com>
3725
3726         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3727         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3728         on obstack.
3729         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3730
3731 2019-05-08  Tom Tromey  <tom@tromey.com>
3732
3733         * mdebugread.c (basic_type_data): Change type.
3734         (basic_type, _initialize_mdebugread): Update.
3735
3736 2019-05-08  Tom Tromey  <tom@tromey.com>
3737
3738         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3739
3740 2019-05-08  Tom Tromey  <tom@tromey.com>
3741
3742         * nto-tdep.c (nto_inferior_data_reg): Change type.
3743         (nto_inferior_data): Update.
3744         (nto_inferior_data_cleanup, nto_new_inferior_data)
3745         (_initialize_nto_tdep): Remove.
3746         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3747
3748 2019-05-08  Tom Tromey  <tom@tromey.com>
3749
3750         * ada-lang.c (struct ada_inferior_data): Add initializers.
3751         (ada_inferior_data): Change type.
3752         (ada_inferior_data_cleanup): Remove.
3753         (get_ada_inferior_data, ada_inferior_exit)
3754         (struct ada_pspace_data): Add initializers, destructor.
3755         (ada_pspace_data_handle): Change type.
3756         (get_ada_pspace_data): Update.
3757         (ada_pspace_data_cleanup): Remove.
3758
3759 2019-05-08  Tom Tromey  <tom@tromey.com>
3760
3761         * coffread.c (struct coff_symfile_info): Add initializers.
3762         (coff_objfile_data_key): Move lower.  Change type.
3763         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3764         Update.
3765         (coff_free_info): Remove.
3766
3767 2019-05-08  Tom Tromey  <tom@tromey.com>
3768
3769         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3770         (fbsd_pspace_data_handle): Move lower.  Change type.
3771         (get_fbsd_pspace_data): Update.
3772         (fbsd_pspace_data_cleanup): Remove.
3773         (_initialize_fbsd_tdep): Update.
3774
3775 2019-05-08  Tom Tromey  <tom@tromey.com>
3776
3777         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3778         (get_ada_tasks_pspace_data): Update.
3779         (ada_tasks_pspace_data_cleanup): Remove.
3780         (_initialize_tasks): Update.
3781         (ada_tasks_inferior_data_handle): Change type.
3782         (get_ada_tasks_inferior_data): Update.
3783         (ada_tasks_inferior_data_cleanup): Remove.
3784         (struct ada_tasks_pspace_data): Add initializers.
3785
3786 2019-05-08  Tom Tromey  <tom@tromey.com>
3787
3788         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3789         * symfile-debug.c (debug_sym_get_probes): Change type.
3790         * stap-probe.c (handle_stap_probe):
3791         (stap_static_probe_ops::get_probes): Change type.
3792         * probe.h (class static_probe_ops) <get_probes>: Change type.
3793         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3794         (parse_probes_in_pspace): Update.
3795         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3796         Update.
3797         (any_static_probe_ops::get_probes): Change type.
3798         * elfread.c (elfread_data): New typedef.
3799         (probe_key): Change type.
3800         (elf_get_probes): Likewise.  Update.
3801         (probe_key_free): Remove.
3802         (_initialize_elfread): Update.
3803         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3804         Change type.
3805         (dtrace_process_dof_probe, dtrace_process_dof)
3806         (dtrace_static_probe_ops::get_probe): Change type.
3807
3808 2019-05-08  Tom Tromey  <tom@tromey.com>
3809
3810         * xcoffread.c (struct xcoff_symfile_info): Rename from
3811         coff_symfile_info.  Add initializers.
3812         (xcoff_objfile_data_key): Move lower.  Change type.
3813         (XCOFF_DATA): Rewrite.
3814         (xcoff_free_info): Remove.
3815         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3816         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3817         (xcoff_initial_scan): Update.
3818
3819 2019-05-08  Tom Tromey  <tom@tromey.com>
3820
3821         * solib-svr4.c (struct svr4_info): Add initializers and
3822         destructor.
3823         <probes_table>: Now an htab_up.
3824         (solib_svr4_pspace_data): Change type.
3825         (free_probes_table): Simplify.
3826         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3827         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3828         (probes_table_remove_objfile_probes, register_solib_event_probe)
3829         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3830         (_initialize_svr4_solib): Update.
3831
3832 2019-05-08  Tom Tromey  <tom@tromey.com>
3833
3834         * remote.c (remote_pspace_data): Change type.
3835         (remote_pspace_data_cleanup): Remove.
3836         (get_remote_exec_file, set_pspace_remote_exec_file)
3837         (_initialize_remote): Update.
3838
3839 2019-05-08  Tom Tromey  <tom@tromey.com>
3840
3841         * breakpoint.c (breakpoint_objfile_key): Change type.
3842         (get_breakpoint_objfile_data): Update.
3843         (free_breakpoint_objfile_data): Remove.
3844         (_initialize_breakpoint): Update.
3845
3846 2019-05-08  Tom Tromey  <tom@tromey.com>
3847
3848         * linux-tdep.c (struct linux_info): Add initializers.
3849         (linux_inferior_data): Move.  Change type.
3850         (invalidate_linux_cache_inf): Update.
3851         (linux_inferior_data_cleanup): Remove.
3852         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3853
3854 2019-05-08  Tom Tromey  <tom@tromey.com>
3855
3856         * auxv.c (auxv_inferior_data): Move.  Change type.
3857         (auxv_inferior_data_cleanup): Remove.
3858         (invalidate_auxv_cache_inf): Rewrite.
3859         (get_auxv_inferior_data, _initialize_auxv): Update.
3860
3861 2019-05-08  Tom Tromey  <tom@tromey.com>
3862
3863         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3864         (symfile_debug_objfile_data_key): Change type.
3865         (symfile_debug_installed, debug_qf_has_symbols)
3866         (debug_qf_find_last_source_symtab)
3867         (debug_qf_forget_cached_source_info)
3868         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3869         (debug_qf_print_stats, debug_qf_dump)
3870         (debug_qf_expand_symtabs_for_function)
3871         (debug_qf_expand_all_symtabs)
3872         (debug_qf_expand_symtabs_with_fullname)
3873         (debug_qf_map_matching_symbols)
3874         (debug_qf_expand_symtabs_matching)
3875         (debug_qf_find_pc_sect_compunit_symtab)
3876         (debug_qf_map_symbol_filenames)
3877         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3878         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3879         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3880         (debug_sym_read_linetable, debug_sym_relocate): Update.
3881         (symfile_debug_free_objfile): Remove.
3882         (install_symfile_debug_logging, _initialize_symfile_debug):
3883         Update.
3884
3885 2019-05-08  Tom Tromey  <tom@tromey.com>
3886
3887         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3888         allocate_on_obstack.
3889         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3890         (get_dwarf2_per_objfile): Update.
3891         (set_dwarf2_per_objfile): Remove.
3892         (dwarf2_has_info, dwarf2_get_section_info): Update.
3893         (dwarf2_free_objfile): Remove.
3894         (_initialize_dwarf2_read): Update.
3895
3896 2019-05-08  Tom Tromey  <tom@tromey.com>
3897
3898         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3899         initializers.
3900         <unsupported_script_warning_printed,
3901         script_not_found_warning_printed>: Now bool.
3902         (auto_load_pspace_data): Change type.
3903         (~auto_load_pspace_info): Rename from
3904         auto_load_pspace_data_cleanup.
3905         (get_auto_load_pspace_data, init_loaded_scripts_info)
3906         (clear_section_scripts, maybe_print_unsupported_script_warning)
3907         (maybe_print_script_not_found_warning, _initialize_auto_load):
3908         Update.
3909
3910 2019-05-08  Tom Tromey  <tom@tromey.com>
3911
3912         * objfiles.c (objfile_pspace_info): Add destructor and
3913         initializers.
3914         (objfiles_pspace_data): Change type.
3915         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3916         (get_objfile_pspace_data): Update.
3917         (objfiles_bfd_data): Change type.
3918         (get_objfile_bfd_data): Update.
3919         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3920
3921 2019-05-08  Tom Tromey  <tom@tromey.com>
3922
3923         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3924         Change type.
3925         (get_catch_syscall_inferior_data): Update.
3926         (catch_syscall_inferior_data_cleanup): Remove.
3927         (_initialize_break_catch_syscall): Update.
3928
3929 2019-05-08  Tom Tromey  <tom@tromey.com>
3930
3931         * inflow.c (struct terminal_info): Add destructor and
3932         initializers.
3933         (inflow_inferior_data): Change type.
3934         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3935         (get_inflow_inferior_data, inflow_inferior_exit)
3936         (swap_terminal_info, _initialize_inflow): Update.
3937
3938 2019-05-08  Tom Tromey  <tom@tromey.com>
3939
3940         * target-dcache.c (target_dcache_cleanup): Remove.
3941         (target_dcache_aspace_key): Change type.
3942         (target_dcache_init_p, target_dcache_invalidate)
3943         (target_dcache_get, target_dcache_get_or_init)
3944         (_initialize_target_dcache): Update.
3945         * dcache.h (struct dcache_deleter): New.
3946
3947 2019-05-08  Tom Tromey  <tom@tromey.com>
3948
3949         * symtab.c (struct symbol_cache): Add destructor and
3950         initializers.
3951         (symbol_cache_key): Move.  Change type.
3952         (make_symbol_cache, free_symbol_cache): Remove.
3953         (get_symbol_cache): Update.
3954         (symbol_cache_cleanup): Remove.
3955         (ALL_PSPACES, symbol_cache_flush)
3956         (maintenance_print_symbol_cache)
3957         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3958         Update.
3959
3960 2019-05-08  Tom Tromey  <tom@tromey.com>
3961
3962         * symtab.c (struct main_info): Add destructor and initializers.
3963         (main_progspace_key): Move.  Change type.
3964         (get_main_info): Update.
3965         (main_info_cleanup): Remove.
3966         (_initialize_symtab): Update.
3967
3968 2019-05-08  Tom Tromey  <tom@tromey.com>
3969
3970         * registry.h (DECLARE_REGISTRY): Define the _key class.
3971
3972 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3973
3974         * NEWS: Merge two 'New commands' sections.
3975
3976 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3977
3978         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3979         parameter and use Ada language definition instead.
3980         (ada_val_print_ptr): Remove unused language parameter.
3981         (ada_val_print_num): Remove language parameter and use Ada language
3982         definition instead.
3983         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3984         parameter.
3985         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3986         parameter and use Ada language definition instead.
3987         (ada_val_print_1): Update all ada_val_print_xxx calls.
3988         Remove language parameter.
3989         (ada_val_print): Update ada_val_print_1 call.
3990
3991 2019-05-08  Tom Tromey  <tromey@adacore.com>
3992
3993         * remote.c (remote_hw_watchpoint_limit)
3994         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3995         Now static.
3996
3997 2019-05-08  Tom Tromey  <tromey@adacore.com>
3998
3999         * maint.c (_initialize_maint_cmds): Move initialization code to
4000         remote.c.
4001         (watchdog, show_watchdog): Move to remote.c.
4002         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4003         "watchdog" static.
4004         (_initialize_remote): Move initialization code from maint.c.
4005         * defs.h (watchdog): Don't declare.
4006
4007 2019-05-08  Tom Tromey  <tromey@adacore.com>
4008
4009         * tui/tui-interp.c: Include main.h.
4010         * interps.c: Include main.h.
4011         * main.h (interpreter_p): Declare.
4012         * defs.h (interpreter_p): Don't declare.
4013
4014 2019-05-08  Tom Tromey  <tromey@adacore.com>
4015
4016         * dwarf2loc.c: Include dwarf2read.h.
4017         * defs.h (read_unsigned_leb128): Don't declare.
4018         * dwarf2read.h (read_unsigned_leb128): Declare.
4019
4020 2019-05-08  Tom Tromey  <tromey@adacore.com>
4021
4022         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4023         method.
4024
4025 2019-05-08  Tom Tromey  <tromey@adacore.com>
4026
4027         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4028         when no wrap column is set.
4029
4030 2019-05-08  Tom Tromey  <tromey@adacore.com>
4031
4032         * c-lang.c (c_get_string): Handle non-C-style arrays.
4033
4034 2019-05-08  Tom Tromey  <tromey@adacore.com>
4035
4036         * typeprint.c (print_offset_data::update): Print the bit offset,
4037         not the number of bits remaining.
4038
4039 2019-05-08  Tom Tromey  <tromey@adacore.com>
4040
4041         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4042         padding at end of comment.
4043
4044 2019-05-08  Tom Tromey  <tromey@adacore.com>
4045
4046         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4047         Compare main types.
4048
4049 2019-05-06  Tom Tromey  <tom@tromey.com>
4050
4051         * common/scoped_mmap.c: Include common-defs.h.
4052         * common/scoped_mmap.h: Don't include config.h.
4053
4054 2019-05-04  Tom Tromey  <tom@tromey.com>
4055
4056         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4057         (struct aarch64_call_info): Add initializers.
4058         <si>: Now a std::vector.
4059         (pass_on_stack, aarch64_push_dummy_call): Update.
4060
4061 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4062             Tom Tromey  <tom@tromey.com>
4063
4064         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4065         (ppc_threads): Now a std::vector.  Now static.
4066         (hwdebug_find_thread_points_by_tid)
4067         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4068         Update.
4069
4070 2019-05-04  Tom Tromey  <tom@tromey.com>
4071
4072         * arc-tdep.c (arc_tdesc_init): Return bool.
4073
4074 2019-05-04  Tom Tromey  <tom@tromey.com>
4075
4076         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4077         Use gdb_assert_not_reached.
4078
4079 2019-05-04  Tom Tromey  <tom@tromey.com>
4080
4081         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4082         "false".
4083
4084 2019-05-04  Tom Tromey  <tom@tromey.com>
4085
4086         * arc-tdep.c (arc_tdesc_init): Use bool.
4087
4088 2019-05-04  Tom Tromey  <tom@tromey.com>
4089
4090         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4091
4092 2019-05-04  Tom Tromey  <tom@tromey.com>
4093
4094         * cli/cli-cmds.c (valid_command_p): Return bool.
4095
4096 2019-05-04  Tom Tromey  <tom@tromey.com>
4097
4098         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4099         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4100
4101 2019-05-04  Raul Tambre  <raul@tambre.ee>
4102
4103         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4104         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4105         operator for comparison.
4106
4107 2019-05-04  Tom Tromey  <tom@tromey.com>
4108
4109         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4110         (lookup_partial_symbol, print_partial_symbols)
4111         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4112         (psymbol_compare): Update.
4113         (add_psymbol_to_bcache): Clear the entire psymbol.
4114         (maintenance_check_psymtabs): Update.
4115         * psympriv.h (struct partial_symbol): Don't derive from
4116         general_symbol_info.
4117         <obj_section, unrelocated_address, address,
4118         set_unrelocated_address>: Update.
4119         <ginfo>: New member.
4120         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4121         (debug_names::write_psymbols): Update.
4122
4123 2019-05-04  Tom de Vries  <tdevries@suse.de>
4124
4125         * contrib/cc-with-tweaks.sh: Support -n arg.
4126
4127 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4128
4129         * corelow.c (core_target::detach): Ensure frame cache and
4130         register caches are cleared.
4131         inferior.c (exit_inferior_1): Likewise.
4132
4133 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4134             Tom Tromey  <tom@tromey.com>
4135
4136         * dictionary.c (collate_pending_symbols_by_language): Remove
4137         "struct" from foreach.
4138         * symtab.c (lookup_global_symbol_from_objfile)
4139         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4140         foreach.
4141         * ser-tcp.c (net_open): Remove "struct" from foreach.
4142         * objfiles.c (objfile_relocate, objfile_rebase)
4143         (objfile_has_symbols): Remove "struct" from foreach.
4144         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4145         from foreach.
4146         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4147         foreach.
4148         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4149         "struct" from foreach.
4150         * ada-lang.c (create_excep_cond_exprs)
4151         (ada_exception_catchpoint_cond_string): Remove "struct" from
4152         foreach.
4153
4154 2019-05-03  Tom Tromey  <tromey@adacore.com>
4155
4156         * ada-exp.y (convert_char_literal): Check suffix of each
4157         enumerator.
4158
4159 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4160
4161         PR ada/21406:
4162         * ada-exp.y (yywrap): Don't define.
4163         * ada-lex.l (%option): Add noyywrap
4164         (yywrap): Remove.
4165
4166 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4167
4168         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4169         _WIN32_WINNT to the XP level, unless already defined to a higher
4170         level.
4171
4172         * unittests/parse-connection-spec-selftests.c:
4173         * ser-tcp.c:
4174         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4175         override.
4176
4177         * symfile.c (find_separate_debug_file): Remove colon from the
4178         drive spec of DOS/Windows file names of the target, so that the
4179         file name produced from DEBUGDIR and the target's directory will
4180         be valid on DOS/Windows systems.
4181
4182 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4183
4184         * rust-lang.c (val_print_struct): Handle printing structures
4185         containing strings.
4186
4187 2019-05-02  Tom Tromey  <tromey@adacore.com>
4188
4189         * valarith.c (_initialize_valarith): Remove.
4190
4191 2019-05-01  Tom Tromey  <tromey@adacore.com>
4192
4193         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4194         bitfields.
4195
4196 2019-05-01  Tom Tromey  <tromey@adacore.com>
4197
4198         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4199         for big-endian copies.
4200
4201 2019-04-30  Ali Tamur  <tamur@google.com>
4202         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4203         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4204         (read_3_bytes): New function.
4205
4206 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4207
4208         * windows-nat.c (main_thread_id): Delete.
4209         (handle_output_debug_string): Replace main_thread_id by
4210         current_event.dwThreadId.
4211         (fake_create_process): Likewise.
4212         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4213         Do not set main_thread_id.
4214         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4215         current_event.dwThreadId.
4216         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4217
4218 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4219
4220         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4221         Use current_event.dwThreadId instead of main_thread_id.
4222
4223 2019-04-30  Tom Tromey  <tromey@adacore.com>
4224
4225         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4226         (create_excep_cond_exprs): Iterate over program spaces.
4227         (ada_exception_catchpoint_cond_string): Examine all minimal
4228         symbols for exception types.
4229
4230 2019-04-30  Tom Tromey  <tromey@adacore.com>
4231
4232         PR c++/24470:
4233         * dwarf2read.c (process_structure_scope): Handle case where type
4234         has template parameters but no symbol was created.
4235
4236 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4237             Chris January  <chris.january@arm.com>
4238
4239         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4240         qualifier.
4241         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4242
4243 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4244
4245         * f-typeprint.c (f_print_type): Update rules for printing
4246         whitespace.
4247         (f_type_print_varspec_suffix): Likewise.
4248
4249 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4250             Chris January  <chris.january@arm.com>
4251
4252         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4253         function arguments.
4254
4255 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4256
4257         * f-lang.c (build_fortran_types): Change name of void type to
4258         lower case.
4259         * f-typeprint.c (f_type_print_base): Print the name of the void
4260         type, rather than a fixed string.
4261         * f-valprint.c (f_decorations): Use lower case void string.
4262
4263 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4264             Chris January  <chris.january@arm.com>
4265
4266         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4267         types for Fortran.
4268
4269 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4270             Chris January  <chris.january@arm.com>
4271             David Lecomber  <david.lecomber@arm.com>
4272
4273         * f-exp.y (BINOP_INTRINSIC): New token.
4274         (exp): New parser rule handling BINOP_INTRINSIC.
4275         (f77_keywords): Add new builtin procedures.
4276         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4277         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4278         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4279         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4280         (print_unop_subexp_f): New function.
4281         (print_binop_subexp_f): New function.
4282         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4283         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4284         (dump_subexp_body_f): Likewise.
4285         (operator_check_f): Likewise.
4286         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4287         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4288
4289 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4290
4291         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4292         UNOP_KIND.
4293         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4294         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4295         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4296         (operator_length_f): New fuction.
4297         (print_subexp_f): New function.
4298         (op_name_f): New function.
4299         (dump_subexp_body_f): New function.
4300         (operator_check_f): New function.
4301         (exp_descriptor_f): Replace standard expression handling functions
4302         with new functions.
4303         * gdb/fortran-operator.def: New file.
4304         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4305         * gdb/std-operator.def: Remove UNOP_KIND.
4306
4307 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4308
4309         * std-operator.def: Remove unbalanced, stray double quote
4310         character.
4311
4312 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4313             Chris January  <chris.january@arm.com>
4314             Daniel Everett  <daniel.everett@arm.com>
4315             Nick Forrington  <nick.forrington@arm.com>
4316             Richard Bunt  <richard.bunt@arm.com>
4317
4318         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4319         of depth when printing anonymous structs or unions.
4320         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4321         Don't print either the top-level value, or the children if the
4322         max-depth is exceeded.
4323         (ppscm_print_children): When printing the key of a map, allow one
4324         extra level of depth.
4325         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4326         print either the top-level value, or the children if the max-depth
4327         is exceeded.
4328         (print_children): When printing the key of a map, allow one extra
4329         level of depth.
4330         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4331         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4332         (user_print_options): Initialise max_depth field.
4333         (val_print_scalar_or_string_type_p): New function.
4334         (val_print): Check to see if the max depth has been reached.
4335         (val_print_check_max_depth): Define new function.
4336         (show_print_max_depth): New function.
4337         (_initialize_valprint): Add 'print max-depth' option.
4338         * valprint.h (struct value_print_options) <max_depth>: New field.
4339         (val_print_check_max_depth): Declare new function.
4340         * NEWS: Document new feature.
4341
4342 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4343
4344         * ada-lang.c (ada_language_defn): Initialise new field.
4345         * c-lang.c (c_is_string_type_p): New function.
4346         (c_language_defn): Initialise new field.
4347         (cplus_language_defn): Initialise new field.
4348         (asm_language_defn): Initialise new field.
4349         (minimal_language_defn): Initialise new field.
4350         * c-lang.h (c_is_string_type_p): Declare new function.
4351         * d-lang.c (d_language_defn): Initialise new field.
4352         * f-lang.c (f_is_string_type_p): New function.
4353         (f_language_defn): Initialise new field.
4354         * go-lang.c (go_is_string_type_p): New function.
4355         (go_language_defn): Initialise new field.
4356         * language.c (default_is_string_type_p): New function.
4357         (unknown_language_defn): Initialise new field.
4358         (auto_language_defn): Initialise new field.
4359         * language.h (struct language_defn) <la_is_string_type_p>: New
4360         member variable.
4361         (default_is_string_type_p): Declare new function.
4362         * m2-lang.c (m2_language_defn): Initialise new field.
4363         * objc-lang.c (objc_language_defn): Initialise new field.
4364         * opencl-lang.c (opencl_language_defn): Initialise new field.
4365         * p-lang.c (pascal_is_string_type_p): New function.
4366         (pascal_language_defn): Initialise new field.
4367         * rust-lang.c (rust_is_string_type_p): New function.
4368         (rust_language_defn): Initialise new field.
4369
4370 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4371
4372         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4373         New field.
4374         * ada-lang.c (ada_language_defn): Initialise new field.
4375         * c-lang.c (c_language_defn): Likewise.
4376         (cplus_language_defn): Likewise.
4377         (asm_language_defn): Likewise.
4378         (minimal_language_defn): Likewise.
4379         * d-lang.c (d_language_defn): Likewise.
4380         * f-lang.c (f_language_defn): Likewise.
4381         * go-lang.c (go_language_defn): Likewise.
4382         * language.c (unknown_language_defn): Likewise.
4383         (auto_language_defn): Likewise.
4384         * m2-lang.c (m2_language_defn): Likewise.
4385         * objc-lang.c (objc_language_defn): Likewise.
4386         * opencl-lang.c (opencl_language_defn): Likewise.
4387         * p-lang.c (pascal_language_defn): Likewise.
4388         * rust-lang.c (rust_language_defn): Likewise.
4389
4390 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4391
4392         * ada-lang.c (ada_is_character_type): Change return type to bool.
4393         (ada_is_string_type): Likewise.
4394         * ada-lang.h (ada_is_character_type): Update declaration
4395         (ada_is_string_type): Likewise.
4396
4397 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4398
4399         Support style in 'frame|thread apply'
4400
4401         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4402         * record.c (record_start, record_stop): Update callers of
4403         execute_command_to_string with false.
4404         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4405         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4406         methods.
4407         (class string_file): New constructor with term_out parameter.
4408         Override methods term_out and can_emit_style_escape.  New member
4409         term_out.
4410         (class stdio_file): Override can_emit_style_escape.
4411         (class tee_file): Override term_out and can_emit_style_escape.
4412         * utils.h (can_emit_style_escape): Remove.
4413         * utils.c (can_emit_style_escape): Likewise.
4414         Update all callers of can_emit_style_escape (SOMESTREAM) to
4415         SOMESTREAM->can_emit_style_escape.
4416         * source-cache.c (source_cache::get_source_lines): Likewise.
4417         * stack.c (frame_apply_command_count): Call execute_command_to_string
4418         passing the term_out characteristic of the current gdb_stdout.
4419         * thread.c (thr_try_catch_cmd): Likewise.
4420         * top.c (execute_command_to_string): pass term_out parameter
4421         to construct the string_file for the command output.
4422         * ui-file.c (term_cli_styling): New function (most code moved
4423         from utils.c can_emit_style_escape).
4424         (string_file::string_file, string_file::can_emit_style_escape,
4425         stdio_file::can_emit_style_escape, tee_file::term_out,
4426         tee_file::can_emit_style_escape): New functions.
4427
4428 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4429
4430         * NEWS: Mention the new set|show may-call-functions.
4431         * infcall.c (may_call_functions_p): New variable.
4432         (show_may_call_functions_p): New function.
4433         (call_function_by_hand_dummy): Throws an error if not
4434         may-call-functions.
4435         (_initialize_infcall): Call add_setshow_boolean_cmd for
4436         may-call-functions.
4437
4438 2019-04-25  Keith Seitz  <keiths@redhat.com>
4439
4440         PR c++/24367
4441         * cp-support.c (inspect_type): Don't attempt substitutions
4442         of symbol with the same name.
4443
4444 2019-04-25  Tom Tromey  <tromey@adacore.com>
4445
4446         PR gdb/24475:
4447         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4448         static.
4449
4450 2019-04-25  Tom Tromey  <tromey@adacore.com>
4451
4452         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4453         rvalue reference.
4454         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4455         (gdb_xml_parser::parse): Use std::move.
4456         * python/python-internal.h (gdbpy_convert_exception): Take a const
4457         reference.
4458         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4459         std::move.
4460         * python/py-utils.c (gdbpy_convert_exception): Take a const
4461         reference.
4462         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4463         Use std::move.
4464         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4465         Use std::move.
4466         * mi/mi-main.c (mi_print_exception): Take a const reference.
4467         * main.c (handle_command_errors): Take a const reference.
4468         * linespec.c (parse_linespec): Use std::move.
4469         * infcall.c (run_inferior_call): Use std::move.
4470         (call_function_by_hand_dummy): Use std::move.
4471         * exec.c (try_open_exec_file): Use std::move.
4472         * exceptions.h (exception_print, exception_fprintf)
4473         (exception_print_same): Update.
4474         * exceptions.c (print_exception, exception_print)
4475         (exception_fprintf, exception_print_same): Change parameters to
4476         const reference.
4477         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4478         * common/new-op.c: Use std::move.
4479         * common/common-exceptions.h (struct gdb_exception): Add move
4480         constructor.
4481         (struct gdb_exception_error, struct gdb_exception_quit, struct
4482         gdb_quit_bad_alloc): Change constructor to move constructor.
4483         (throw_exception): Change parameter to rvalue reference.
4484         * common/common-exceptions.c (throw_exception): Take rvalue
4485         reference.
4486         * cli/cli-interp.c (safe_execute_command): Use std::move.
4487         * breakpoint.c (insert_bp_location, location_to_sals): Use
4488         std::move.
4489
4490 2019-04-25  Tom Tromey  <tromey@adacore.com>
4491
4492         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4493         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4494         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4495         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4496         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4497         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4498         guile/scm-value.c: Use unpack.
4499         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4500         gdbscm_gdb_exception.
4501         (gdbscm_throw_gdb_exception): Likewise.
4502         (struct gdbscm_gdb_exception): New.
4503         (unpack): New function.
4504         (gdbscm_wrap): Use unpack.
4505
4506 2019-04-25  Tom Tromey  <tromey@adacore.com>
4507
4508         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4509         (gdb_rl_callback_handler): Use std::move.
4510         * common/common-exceptions.h (struct gdb_exception): Add move
4511         assignment operator.
4512         (throw_exception_sjlj): Change "exception" to const reference.
4513         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4514         (throw_exception_sjlj): Change "exception" to const reference.
4515
4516 2019-04-25  Tom Tromey  <tromey@adacore.com>
4517
4518         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4519         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4520         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4521         Update.
4522         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4523         Update.
4524         * mi/mi-interp.c (mi_interp::exec): Update.
4525         * linespec.c (parse_linespec): Update.
4526         * infcall.c (run_inferior_call): Update.
4527         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4528         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4529         (gdbscm_lookup_global_symbol): Update.
4530         * guile/scm-param.c (gdbscm_parameter_value): Update.
4531         * guile/scm-frame.c (gdbscm_frame_read_register)
4532         (gdbscm_frame_read_var): Update.
4533         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4534         * exec.c (try_open_exec_file): Update.
4535         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4536         (gdb_rl_callback_handler): Update.
4537         * common/common-exceptions.h (exception_none): Don't declare.
4538         * common/common-exceptions.c (exception_none): Don't define.
4539         (struct catcher) <exception>: Update.
4540         * cli/cli-interp.c (safe_execute_command): Update.
4541         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4542
4543 2019-04-25  Ali Tamur  <tamur@google.com>
4544
4545         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4546         (read_attribute_value): Likewise.
4547         (dwarf2_read_addr_index): Update comment.
4548         (read_str_index): Add DW_FORM_strx.
4549         (dwarf2_string_attr): Likewise.
4550         (dwarf2_const_value_attr): Likewise.
4551         (dump_die_shallow): Likewise.
4552         (dwarf2_fetch_constant_bytes): Likewise.
4553         (skip_form_bytes): Likewise.
4554         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4555
4556 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4557
4558         PR corefiles/11608
4559         PR corefiles/18187
4560         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4561         OFFSET.  Verify if current mapping contains an ELF header.
4562         (linux_find_memory_regions_full): Adjust call to
4563         dump_mapping_p.
4564
4565 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4566             Kang Li <kanglictf@gmail.com>
4567
4568         PR gdb/21600
4569
4570         * dwarf2-frame.c (read_initial_length): Be consistent about using
4571         unsigned representation of length.
4572         (decode_frame_entry_1): Likewise.  Check for wraparound of
4573         end pointer as well as buffer overflow.
4574
4575 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4576
4577         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4578         "vq".
4579
4580 2019-04-24  Tom Tromey  <tromey@adacore.com>
4581
4582         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4583
4584 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4585
4586         * s12z-tdep.c (s12z_unwind_pc): Delete.
4587         (s12z_unwind_sp): Delete.
4588         (s12z_gdbarch_init): Don't register deleted functions with
4589         gdbarch.
4590
4591 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4592
4593         * rl78-tdep.c (rl78_unwind_sp): Delete.
4594         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4595
4596 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4597
4598         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4599         (xstormy16_unwind_pc): Delete.
4600         (xstormy16_dummy_id): Delete.
4601         (xstormy16_gdbarch_init): Don't register deleted functions with
4602         gdbarch.
4603
4604 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4605
4606         * vax-tdep.c (vax_unwind_pc): Delete.
4607         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4608
4609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4610
4611         * v850-tdep.c (v850_unwind_sp): Delete.
4612         (v850_unwind_pc): Delete.
4613         (v850_dummy_id): Delete.
4614         (v850_gdbarch_init): Don't register deleted functions with
4615         gdbarch.
4616
4617 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4618
4619         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4620         (tilegx_unwind_pc): Delete.
4621         (tilegx_unwind_dummy_id): Delete.
4622         (tilegx_gdbarch_init): Don't register deleted functions with
4623         gdbarch.
4624
4625 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4626
4627         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4628         (tic6x_dummy_id): Delete.
4629         (tic6x_gdbarch_init): Don't register deleted functions with
4630         gdbarch.
4631
4632 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4633
4634         * sparc-tdep.c (sparc_unwind_pc): Delete.
4635         (sparc32_gdbarch_init): Don't register deleted function with
4636         gdbarch.
4637
4638 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4639
4640         * sh-tdep.c (sh_unwind_sp): Delete.
4641         (sh_unwind_pc): Delete.
4642         (sh_dummy_id): Delete.
4643         (sh_gdbarch_init): Don't register deleted functions with
4644         gdbarch.
4645
4646 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4647
4648         * score-tdep.c (score_unwind_sp): Delete.
4649         (score_unwind_pc): Delete.
4650         (score_dummy_id): Delete.
4651         (score_gdbarch_init): Don't register deleted functions with
4652         gdbarch.
4653
4654 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4655
4656         * rx-tdep.c (rx_unwind_pc): Delete.
4657         (rx_unwind_sp): Delete.
4658         (rx_dummy_id): Delete.
4659         (rx_gdbarch_init): Don't register deleted functions with
4660         gdbarch.  Update comment.
4661
4662 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4663
4664         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4665         (rs6000_dummy_id): Delete.
4666         (rs6000_gdbarch_init): Don't register deleted functions with
4667         gdbarch.
4668
4669 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4670
4671         * or1k-tdep.c (or1k_dummy_id): Delete.
4672         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4673
4674 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4675
4676         * nios2-tdep.c (nios2_dummy_id): Delete.
4677         (nios2_unwind_sp): Delete.
4678         (nios2_gdbarch_init): Don't register deleted functions with
4679         gdbarch.
4680
4681 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4682
4683         * nds32-tdep.c (nds32_dummy_id): Delete.
4684         (nds32_unwind_pc): Delete.
4685         (nds32_unwind_sp): Delete.
4686         (nds32_gdbarch_init): Don't register deleted functions with
4687         gdbarch.
4688
4689 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4690
4691         * msp430-tdep.c (msp430_unwind_pc): Delete.
4692         (msp430_unwind_sp): Delete.
4693         (msp430_dummy_id): Delete.
4694         (msp430_gdbarch_init): Don't register deleted functions with
4695         gdbarch.
4696
4697 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4698
4699         * moxie-tdep.c (moxie_unwind_sp): Delete.
4700         (moxie_unwind_pc): Delete.
4701         (moxie_dummy_id): Delete.
4702         (moxie_gdbarch_init): Don't register deleted functions with
4703         gdbarch.
4704
4705 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4706
4707         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4708         (mn10300_unwind_pc): Delete.
4709         (mn10300_unwind_sp): Delete.
4710         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4711         mn10300_unwind_sp.
4712         (mn10300_frame_unwind_init): Don't register deleted functions with
4713         gdbarch.
4714
4715 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4716
4717         * mep-tdep.c (mep_unwind_pc): Delete.
4718         (mep_unwind_sp): Delete.
4719         (mep_dummy_id): Delete.
4720         (mep_gdbarch_init): Don't register deleted functions with
4721         gdbarch.
4722
4723 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4724
4725         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4726         (m68hc11_unwind_sp): Delete.
4727         (m68hc11_gdbarch_init): Don't register deleted functions with
4728         gdbarch.
4729
4730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4731
4732         * m32r-tdep.c (m32r_unwind_sp): Delete.
4733         (m32r_unwind_pc): Delete.
4734         (m32r_dummy_id): Delete.
4735         (m32r_gdbarch_init): Don't register deleted functions with
4736         gdbarch.
4737
4738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4739
4740         * m32c-tdep.c (m32c_unwind_pc): Delete.
4741         (m32c_unwind_sp): Delete.
4742         (m32c_dummy_id): Delete.
4743         (m32c_gdbarch_init): Don't register deleted functions with
4744         gdbarch.
4745
4746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4747
4748         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4749         (lm32_unwind_pc): Delete.
4750         (lm32_dummy_id): Delete.
4751         (lm32_gdbarch_init): Don't register deleted functions with
4752         gdbarch.
4753
4754 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4755
4756         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4757         (iq2000_unwind_pc): Delete.
4758         (iq2000_dummy_id): Delete.
4759         (iq2000_gdbarch_init): Don't register deleted functions with
4760         gdbarch.
4761
4762 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4763
4764         * nds32-tdep.c (nds32_type_align): Delete.
4765         (nds32_push_dummy_call): Use type_align instead.
4766
4767 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4768
4769         * arm-tdep.c (arm_type_align): Only handle vector override case.
4770         (arm_push_dummy_call): Use type_align.
4771         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4772
4773 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4774
4775         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4776         case.
4777         (pass_on_stack): Use type_align.
4778         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4779         function.
4780
4781 2019-04-23  Tom Tromey  <tromey@adacore.com>
4782
4783         * dwarf2read.c (line_header::file_name_at): Remove unused
4784         overload.
4785
4786 2019-04-23  Tom de Vries  <tdevries@suse.de>
4787
4788         PR gdb/24438
4789         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4790         invocation.
4791
4792
4793 2019-03-27  Ali Tamur  <tamur@google.com>
4794
4795         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4796         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4797         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4798         (dwarf_expr_context::get_addr_index): Likewise
4799         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4800         (symbol_needs_eval_context::get_addr_index): Likewise
4801         (disassemble_dwarf_expression): Add DW_OP_addrx
4802         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4803         (read_cutu_die_from_dwo): Update comment
4804         (skip_one_die): Add DW_FORM_addrx
4805         (read_attribute_value): Likewise
4806         (var_decode_location): Add DW_OP_addrx
4807         (dwarf2_const_value_attr): Add DW_FORM_addrx
4808         (dump_die_shallow): Likewise
4809         (dwarf2_fetch_constant_bytes): Likewise
4810         (decode_locdesc): Add DW_OP_addrx
4811         (skip_form_bytes): Add DW_FORM_addrx
4812
4813 2019-04-22  Ali Tamur  <tamur@google.com>
4814
4815         * MAINTAINERS (Write After Approval): Add self.
4816
4817 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4818
4819         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4820         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4821         (open_symbol_file_object): Likewise.
4822         (svr4_default_sos): Add info parameter.
4823         (svr4_read_so_list): Likewise.
4824         (svr4_current_sos_direct): Adjust functions calls to pass down
4825         info.
4826         (svr4_current_sos_1): Add info parameter.
4827         (svr4_current_sos): Call get_svr4_info, pass info down to
4828         svr4_current_sos_1.
4829         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4830         get_svr4_info.
4831         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4832         get_svr4_info.
4833         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4834         to get_svr4_info.
4835         (probes_table_remove_objfile_probes): Likewise.
4836         (register_solib_event_probe): Add info parameter.
4837         (solist_update_incremental): Pass info parameter down to
4838         svr4_read_so_list.
4839         (disable_probes_interface): Add info parameter.
4840         (svr4_handle_solib_event): Pass current_program_space to
4841         get_svr4_info.  Adjust disable_probes_interface cleanup.
4842         (svr4_create_probe_breakpoints): Add info parameter, pass it
4843         down to register_solib_event_probe.
4844         (svr4_create_solib_event_breakpoints): Add info parameter,
4845         pass it down to svr4_create_probe_breakpoints.
4846         (enable_break): Pass info down to
4847         svr4_create_solib_event_breakpoints.
4848         (svr4_solib_create_inferior_hook): Pass current_program_space to
4849         get_svr4_info.
4850         (svr4_clear_solib): Likewise.
4851
4852 2019-04-22  Pedro Alves  <palves@redhat.com>
4853
4854         * solib-svr4.c (svr4_free_objfile_observer): New.
4855         (probe_and_action::objfile): New field.
4856         (probes_table_htab_remove_objfile_probes)
4857         (probes_table_remove_objfile_probes): New functions.
4858         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4859         in the new probe_and_action.  Don't store the probe in 'lookup'.
4860         (svr4_create_probe_breakpoints): Pass objfile to
4861         register_solib_event_probe.
4862         (_initialize_svr4_solib): Register a free_objfile observer.
4863
4864 2019-04-19  Tom Tromey  <tom@tromey.com>
4865
4866         * common/queue.h: Remove.
4867
4868 2019-04-19  Tom Tromey  <tom@tromey.com>
4869
4870         * event-loop.c: Don't include "common/queue.h".
4871
4872 2019-04-19  Tom Tromey  <tom@tromey.com>
4873
4874         * remote.c (remote_target): Use delete.
4875         * remote-notif.h: Include <list>, not "common/queue.h".
4876         (notif_client_p): Remove typedef.
4877         (remote_notif_state): Add constructor, destructor, initializer.
4878         <notif_queue>: Now a std::list.
4879         (remote_notif_state_xfree): Don't declare.
4880         * remote-notif.c (remote_notif_process, handle_notification)
4881         (remote_notif_state_allocate): Update.
4882         (~remote_notif_state): Rename from remote_notif_state_xfree.
4883
4884 2019-04-19  Tom Tromey  <tom@tromey.com>
4885
4886         * symfile.c (reread_symbols): Update.
4887         * objfiles.c (objfile_register_static_link)
4888         (objfile_lookup_static_link): Update
4889         (~objfile) Don't delete static_links.
4890         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4891
4892 2019-04-19  Tom Tromey  <tom@tromey.com>
4893
4894         * type-stack.h (struct type_stack) <insert>: Constify string.
4895         * type-stack.c (type_stack::insert): Constify string.
4896         * gdbtypes.h (lookup_template_type): Update.
4897         (address_space_name_to_int): Update.
4898         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4899         const.
4900         (lookup_template_type): Make name const.
4901         * c-exp.y: Update rules.
4902         (lex_one_token, classify_name, classify_inner_name)
4903         (c_print_token): Update.
4904         * p-exp.y: Update rules.
4905         (yylex): Update.
4906         * f-exp.y: Update rules.
4907         (yylex): Update.
4908         * d-exp.y: Update rules.
4909         (lex_one_token, classify_name, classify_inner_name): Update.
4910         * parse.c (write_dollar_variable, copy_name): Return std::string.
4911         * parser-defs.h (copy_name): Change return type.
4912         * m2-exp.y: Update rules.
4913         (yylex): Update.
4914         * go-exp.y (lex_one_token): Update.
4915         Update rules.
4916         (classify_unsafe_function, classify_packaged_name)
4917         (classify_name, yylex): Update.
4918
4919 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4920
4921         * configure.ac: add --enable-source-highlight switch.
4922         * configure: Regenerate.
4923         * top.c (print_gdb_version): plumb --enable-source-highlight
4924         status to "show configuration".
4925
4926 2019-04-19  Tom Tromey  <tromey@adacore.com>
4927
4928         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4929         Check ADA_TYPE_P.
4930         (empty_record, ada_template_to_fixed_record_type_1)
4931         (template_to_static_fixed_type)
4932         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4933         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4934         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4935         macros.
4936
4937 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4938
4939         PR symtab/24423:
4940         * source.c (print_source_lines_base): Advance "iter" when a
4941         control character is seen.
4942
4943 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4944
4945         * inferior.h (struct infcall_suspend_state_deleter):
4946         Catch exception in destructor to avoid crash.
4947
4948 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4949
4950         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4951         close to the add_com "shell".
4952
4953 2019-04-18  Tom Tromey  <tromey@adacore.com>
4954
4955         * process-stratum-target.h (class process_stratum_target)
4956         <stratum>: Add "final".
4957
4958 2019-04-17  Tom Tromey  <tromey@adacore.com>
4959
4960         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4961         against nullptr before use.
4962
4963 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4964
4965         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4966
4967 2019-04-17  Jim Wilson  <jimw@sifive.com>
4968             Andrew Burgess  <andrew.burgess@embecosm.com>
4969
4970         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4971         code read might fail, assume 4-byte breakpoint in that case.
4972
4973 2019-04-15  Leszek Swirski  <leszeks@google.com>
4974
4975         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4976         rather than a hand-rolled POD check when checking for forced MEMORY
4977         classification.
4978
4979 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4980
4981         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4982         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4983         function.
4984         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4985         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4986         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4987         declaration.
4988
4989 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4990
4991         * aarch64-linux-nat.c
4992         (aarch64_linux_nat_target::thread_architecture): Add override.
4993         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4994         each VQ.
4995
4996 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4997
4998         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4999
5000 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5001
5002         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5003         target types of size 96-bits, add some additional comments, and
5004         check that the builtin type we found was the correct size.
5005
5006 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5007
5008         * utils.c (prompt_for_continue): Don't restore the styling at the
5009         end, as applied_style has the wrong value.  This fixes styling in
5010         long lists of file names that are interrupted by the "Continue?"
5011         prompt.
5012
5013 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5014
5015         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5016         * c-lang.c (c_language_defn): Likewise.
5017         (cplus_language_defn): Likewise.
5018         (asm_language_defn): Likewise.
5019         (minimal_language_defn): Likewise.
5020         * d-lang.c (d_language_defn): Likewise.
5021         * f-lang.c (f_language_defn): Likewise.
5022         * go-lang.c (go_language_defn): Likewise.
5023         * language.c (unknown_language_defn): Likewise.
5024         (auto_language_defn): Likewise.
5025         * language.h (struct language_defn): Remove la_magic field.
5026         (LANG_MAGIC): Delete.
5027         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5028         * objc-lang.c (objc_language_defn): Likewise.
5029         * opencl-lang.c (opencl_language_defn): Likewise.
5030         * p-lang.c (pascal_language_defn): Likewise.
5031         * rust-lang.c (rust_language_defn): Likewise.
5032
5033 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5034
5035         * riscv-tdep.c (riscv_type_align): New function.
5036         (riscv_type_alignment): Delete.
5037         (riscv_arg_location): Use 'type_align'.
5038         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5039
5040 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5041
5042         * gdbtypes.c (type_align): A struct with no non-static fields also
5043         has alignment of 1.
5044
5045 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5046
5047         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5048         component to 0.
5049         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5050         member.
5051         (riscv_struct_info::analyse): New implementation using new
5052         analyse_inner member function.
5053         (riscv_struct_info::field_offset): New member function.
5054         (riscv_struct_info::m_offsets): New member variable.
5055         (riscv_struct_info::analyse_inner): New private member function,
5056         takes the old implementation of riscv_struct_info::analyse but
5057         extended to track field offsets.
5058         (riscv_call_arg_struct): Update the struct folding special cases
5059         to handle cases where empty C++ structs, which are non-zero
5060         length, are found.
5061         (riscv_arg_location): Initialise the length of each location, a
5062         non-zero length now indicates the location is in use.
5063         (riscv_push_dummy_call): Allow for the first location having a
5064         non-zero offset when setting up arguments.
5065         (riscv_return_value): Likewise, but for return values.
5066
5067 2019-04-11  Tom Tromey  <tromey@adacore.com>
5068
5069         * utils.c (internal_vproblem): Make "msg" const.
5070
5071 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5072
5073         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5074         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5075         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5076         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5077
5078 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5079
5080         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5081         function.
5082         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5083         of amd64_collect_native_gregset.
5084         (amd64_linux_nat_target::store_registers): Likewise.
5085
5086 2019-04-10  Tom Tromey  <tom@tromey.com>
5087
5088         * symtab.c (lookup_global_symbol_from_objfile)
5089         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5090         * objfiles.h (class separate_debug_iterator): New.
5091         (class separate_debug_range): New.
5092         (struct objfile) <separate_debug_objfiles>: New method.
5093         (objfile_separate_debug_iterate): Don't declare.
5094         * objfiles.c (separate_debug_iterator::operator++): Rename from
5095         objfile_separate_debug_iterate.
5096         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5097         iterator.
5098         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5099         iterator.
5100
5101 2019-04-10  Tom Tromey  <tom@tromey.com>
5102
5103         * symfile.c (reread_symbols): Remove old comment.
5104         * objfiles.c (free_all_objfiles): Fix a typo.
5105
5106 2019-04-10  Tom Tromey  <tom@tromey.com>
5107
5108         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5109         * minsyms.c (lookup_minimal_symbol): Use foreach.
5110         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5111         (lookup_minimal_symbol_solib_trampoline): Likewise.
5112         * symfile.c (reread_symbols): Use foreach.
5113
5114 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5115             Tom Tromey  <tromey@adacore.com>
5116
5117         PR rust/24414:
5118         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5119         (rust_lex_int_test): Change "value" to be LONGEST.
5120         (rust_lex_tests): Add test for long integer literal.
5121
5122 2019-04-09  Tom Tromey  <tromey@adacore.com>
5123
5124         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5125         to bool.
5126         (extended_remote_target::attach): Update.
5127         (remote_target::remote_notice_new_inferior): Update.
5128         (remote_target::add_current_inferior_and_thread): Update.
5129         * inferior.c (exit_inferior_1): Use "false".
5130         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5131
5132 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5133
5134         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5135         the "start" command.
5136
5137 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5138
5139         * python/py-inferior.c (infpy_thread_from_thread_handle):
5140         Adjust comments to reflect renaming of thread_from_thread_handle
5141         to thread_from_handle.  Adjust keywords.  Fix type error message.
5142         (inferior_object_methods): Add thread_from_handle.  Retain
5143         thread_from_thread_handle, but mark it as deprecated.
5144
5145 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5146
5147         * gdbthread.h (find_thread_by_handle): Revise declaration.
5148         * thread.c (find_thread_by_handle): Likewise.  Adjust
5149         implementation too.
5150         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5151         support for buffer objects as handles.
5152
5153 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5154
5155         * python/py-infthread.c (thpy_thread_handle): New function.
5156         (thread_object_methods): Register thpy_thread_handle.
5157
5158 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5159
5160         * gdbthread.h (thread_to_thread_handle): Declare.
5161         * thread.c (gdbtypes.h): Include.
5162         (thread_to_thread_handle): New function.
5163
5164         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5165         (target_thread_info_to_thread_handle): Declare.
5166         * target.c (target_thread_info_to_thread_handle): New function.
5167         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5168         * target-delegates.c: Regenerate.
5169
5170         * linux-thread-db.c (class thread_db_target): Add method
5171         thread_info_to_thread_handle.
5172         (thread_db_target::thread_info_to_thread_handle): Define.
5173         * remote.c (class remote_target): Add new method
5174         thread_info_to_thread_handle.
5175         (remote_target::thread_info_to_thread_handle): Define.
5176
5177 2019-04-08  Pedro Alves  <palves@redhat.com>
5178
5179         * common/common-exceptions.c (throw_exception): Don't create
5180         named object to throw; throw directly.
5181         (throw_it): Likewise.  Don't initialize gdb_exception::message
5182         here, with new; pass FMT and AP to the ctor instead.
5183         * common/common-exceptions.h: Include <string>.
5184         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5185         const char *, va_list)): New ctor.  Use std::make_shared.
5186         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5187         errors)): Delete.
5188         (gdb_exception_error::gdb_exception_error(enum errors, const char
5189         *, va_list)): New.
5190         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5191         Add assertion.
5192         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5193         errors)): Delete.
5194         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5195         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5196         Add assertion.
5197
5198 2019-04-08  Tom Tromey  <tom@tromey.com>
5199
5200         * valops.c (value_rtti_indirect_type): Replace throw_exception
5201         with throw.
5202         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5203         with throw.
5204         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5205         throw.
5206         * target.c (target_translate_tls_address): Replace throw_exception
5207         with throw.
5208         * stack.c (frame_apply_command_count): Replace throw_exception
5209         with throw.
5210         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5211         throw.
5212         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5213         with throw.
5214         * rs6000-tdep.c (rs6000_frame_cache)
5215         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5216         * remote.c: Replace throw_exception with throw.
5217         * record-full.c (record_full_message, record_full_wait_1)
5218         (record_full_restore): Replace throw_exception with throw.
5219         * record-btrace.c:
5220         (get_thread_current_frame_id, record_btrace_start_replaying)
5221         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5222         (cmd_record_btrace_start): Replace throw_exception with throw.
5223         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5224         throw.
5225         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5226         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5227         * linespec.c:
5228         (find_linespec_symbols): Replace throw_exception with throw.
5229         * infrun.c (displaced_step_prepare, resume): Replace
5230         throw_exception with throw.
5231         * infcmd.c (post_create_inferior): Replace throw_exception with
5232         throw.
5233         * inf-loop.c (inferior_event_handler): Replace throw_exception
5234         with throw.
5235         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5236         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5237         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5238         (get_prev_frame_always, get_frame_pc_if_available)
5239         (get_frame_address_in_block_if_available, get_frame_language):
5240         Replace throw_exception with throw.
5241         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5242         throw_exception with throw.
5243         * eval.c (fetch_subexp_value, evaluate_var_value)
5244         (evaluate_funcall, evaluate_subexp_standard): Replace
5245         throw_exception with throw.
5246         * dwarf2loc.c (call_site_find_chain)
5247         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5248         Replace throw_exception with throw.
5249         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5250         with throw.
5251         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5252         throw.
5253         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5254         * completer.c (complete_line_internal): Replace throw_exception
5255         with throw.
5256         * compile/compile-object-run.c (compile_object_run): Replace
5257         throw_exception with throw.
5258         * cli/cli-script.c (process_next_line): Replace throw_exception
5259         with throw.
5260         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5261         (btrace_enable, btrace_maint_update_pt_packets): Replace
5262         throw_exception with throw.
5263         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5264         throw_exception with throw.
5265         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5266         throw_exception with throw.
5267         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5268         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5269         * aarch64-tdep.c (aarch64_make_prologue_cache)
5270         (aarch64_make_stub_cache): Replace throw_exception with throw.
5271
5272 2019-04-08  Tom Tromey  <tom@tromey.com>
5273
5274         * common/common-exceptions.c (throw_exception): Rename from
5275         throw_exception_cxx.  Remove old copy.  Make argument const.
5276         (throw_it): Create and throw exception objects directly.
5277         * common/common-exceptions.h (throw_exception): Make argument
5278         const.
5279         (struct gdb_exception_error): Add constructor.
5280         (struct gdb_exception_quit): Add constructor.
5281
5282 2019-04-08  Tom Tromey  <tom@tromey.com>
5283
5284         * common/common-exceptions.h (exception_rethrow): Don't declare.
5285         (TRY_SJLJ): Update comment.
5286         (TRY, CATCH, END_CATCH): Remove.
5287         * common/common-exceptions.c (exception_rethrow): Remove.
5288
5289 2019-04-08  Tom Tromey  <tom@tromey.com>
5290
5291         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5292         Remove.
5293         (gdb_exception_error): Rename from
5294         gdb_exception_RETURN_MASK_ERROR.
5295         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5296         (gdb_quit_bad_alloc): Update.
5297         * aarch64-tdep.c: Update.
5298         * ada-lang.c: Update.
5299         * ada-typeprint.c: Update.
5300         * ada-valprint.c: Update.
5301         * amd64-tdep.c: Update.
5302         * arch-utils.c: Update.
5303         * break-catch-throw.c: Update.
5304         * breakpoint.c: Update.
5305         * btrace.c: Update.
5306         * c-varobj.c: Update.
5307         * cli/cli-cmds.c: Update.
5308         * cli/cli-interp.c: Update.
5309         * cli/cli-script.c: Update.
5310         * common/common-exceptions.c: Update.
5311         * common/new-op.c: Update.
5312         * common/selftest.c: Update.
5313         * compile/compile-c-symbols.c: Update.
5314         * compile/compile-cplus-symbols.c: Update.
5315         * compile/compile-object-load.c: Update.
5316         * compile/compile-object-run.c: Update.
5317         * completer.c: Update.
5318         * corelow.c: Update.
5319         * cp-abi.c: Update.
5320         * cp-support.c: Update.
5321         * cp-valprint.c: Update.
5322         * darwin-nat.c: Update.
5323         * disasm-selftests.c: Update.
5324         * dtrace-probe.c: Update.
5325         * dwarf-index-cache.c: Update.
5326         * dwarf-index-write.c: Update.
5327         * dwarf2-frame-tailcall.c: Update.
5328         * dwarf2-frame.c: Update.
5329         * dwarf2loc.c: Update.
5330         * dwarf2read.c: Update.
5331         * eval.c: Update.
5332         * event-loop.c: Update.
5333         * event-top.c: Update.
5334         * exec.c: Update.
5335         * f-valprint.c: Update.
5336         * fbsd-tdep.c: Update.
5337         * frame-unwind.c: Update.
5338         * frame.c: Update.
5339         * gdbtypes.c: Update.
5340         * gnu-v3-abi.c: Update.
5341         * guile/guile-internal.h: Update.
5342         * guile/scm-block.c: Update.
5343         * guile/scm-breakpoint.c: Update.
5344         * guile/scm-cmd.c: Update.
5345         * guile/scm-disasm.c: Update.
5346         * guile/scm-frame.c: Update.
5347         * guile/scm-lazy-string.c: Update.
5348         * guile/scm-math.c: Update.
5349         * guile/scm-param.c: Update.
5350         * guile/scm-ports.c: Update.
5351         * guile/scm-pretty-print.c: Update.
5352         * guile/scm-symbol.c: Update.
5353         * guile/scm-symtab.c: Update.
5354         * guile/scm-type.c: Update.
5355         * guile/scm-value.c: Update.
5356         * i386-linux-tdep.c: Update.
5357         * i386-tdep.c: Update.
5358         * inf-loop.c: Update.
5359         * infcall.c: Update.
5360         * infcmd.c: Update.
5361         * infrun.c: Update.
5362         * jit.c: Update.
5363         * language.c: Update.
5364         * linespec.c: Update.
5365         * linux-fork.c: Update.
5366         * linux-nat.c: Update.
5367         * linux-tdep.c: Update.
5368         * linux-thread-db.c: Update.
5369         * main.c: Update.
5370         * mi/mi-cmd-break.c: Update.
5371         * mi/mi-cmd-stack.c: Update.
5372         * mi/mi-interp.c: Update.
5373         * mi/mi-main.c: Update.
5374         * objc-lang.c: Update.
5375         * p-valprint.c: Update.
5376         * parse.c: Update.
5377         * ppc-linux-tdep.c: Update.
5378         * printcmd.c: Update.
5379         * python/py-arch.c: Update.
5380         * python/py-breakpoint.c: Update.
5381         * python/py-cmd.c: Update.
5382         * python/py-finishbreakpoint.c: Update.
5383         * python/py-frame.c: Update.
5384         * python/py-framefilter.c: Update.
5385         * python/py-gdb-readline.c: Update.
5386         * python/py-inferior.c: Update.
5387         * python/py-infthread.c: Update.
5388         * python/py-lazy-string.c: Update.
5389         * python/py-linetable.c: Update.
5390         * python/py-objfile.c: Update.
5391         * python/py-param.c: Update.
5392         * python/py-prettyprint.c: Update.
5393         * python/py-progspace.c: Update.
5394         * python/py-record-btrace.c: Update.
5395         * python/py-record.c: Update.
5396         * python/py-symbol.c: Update.
5397         * python/py-type.c: Update.
5398         * python/py-unwind.c: Update.
5399         * python/py-utils.c: Update.
5400         * python/py-value.c: Update.
5401         * python/python.c: Update.
5402         * record-btrace.c: Update.
5403         * record-full.c: Update.
5404         * remote-fileio.c: Update.
5405         * remote.c: Update.
5406         * riscv-tdep.c: Update.
5407         * rs6000-aix-tdep.c: Update.
5408         * rs6000-tdep.c: Update.
5409         * rust-exp.y: Update.
5410         * rust-lang.c: Update.
5411         * s390-tdep.c: Update.
5412         * selftest-arch.c: Update.
5413         * solib-dsbt.c: Update.
5414         * solib-frv.c: Update.
5415         * solib-spu.c: Update.
5416         * solib-svr4.c: Update.
5417         * solib.c: Update.
5418         * sparc64-linux-tdep.c: Update.
5419         * stack.c: Update.
5420         * symfile-mem.c: Update.
5421         * symmisc.c: Update.
5422         * target.c: Update.
5423         * thread.c: Update.
5424         * top.c: Update.
5425         * tracefile-tfile.c: Update.
5426         * tui/tui.c: Update.
5427         * typeprint.c: Update.
5428         * unittests/cli-utils-selftests.c: Update.
5429         * unittests/parse-connection-spec-selftests.c: Update.
5430         * valops.c: Update.
5431         * valprint.c: Update.
5432         * value.c: Update.
5433         * varobj.c: Update.
5434         * windows-nat.c: Update.
5435         * x86-linux-nat.c: Update.
5436         * xml-support.c: Update.
5437
5438 2019-04-08  Tom Tromey  <tom@tromey.com>
5439
5440         * xml-support.c: Use C++ exception handling.
5441         * x86-linux-nat.c: Use C++ exception handling.
5442         * windows-nat.c: Use C++ exception handling.
5443         * varobj.c: Use C++ exception handling.
5444         * value.c: Use C++ exception handling.
5445         * valprint.c: Use C++ exception handling.
5446         * valops.c: Use C++ exception handling.
5447         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5448         handling.
5449         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5450         * typeprint.c: Use C++ exception handling.
5451         * tui/tui.c: Use C++ exception handling.
5452         * tracefile-tfile.c: Use C++ exception handling.
5453         * top.c: Use C++ exception handling.
5454         * thread.c: Use C++ exception handling.
5455         * target.c: Use C++ exception handling.
5456         * symmisc.c: Use C++ exception handling.
5457         * symfile-mem.c: Use C++ exception handling.
5458         * stack.c: Use C++ exception handling.
5459         * sparc64-linux-tdep.c: Use C++ exception handling.
5460         * solib.c: Use C++ exception handling.
5461         * solib-svr4.c: Use C++ exception handling.
5462         * solib-spu.c: Use C++ exception handling.
5463         * solib-frv.c: Use C++ exception handling.
5464         * solib-dsbt.c: Use C++ exception handling.
5465         * selftest-arch.c: Use C++ exception handling.
5466         * s390-tdep.c: Use C++ exception handling.
5467         * rust-lang.c: Use C++ exception handling.
5468         * rust-exp.y: Use C++ exception handling.
5469         * rs6000-tdep.c: Use C++ exception handling.
5470         * rs6000-aix-tdep.c: Use C++ exception handling.
5471         * riscv-tdep.c: Use C++ exception handling.
5472         * remote.c: Use C++ exception handling.
5473         * remote-fileio.c: Use C++ exception handling.
5474         * record-full.c: Use C++ exception handling.
5475         * record-btrace.c: Use C++ exception handling.
5476         * python/python.c: Use C++ exception handling.
5477         * python/py-value.c: Use C++ exception handling.
5478         * python/py-utils.c: Use C++ exception handling.
5479         * python/py-unwind.c: Use C++ exception handling.
5480         * python/py-type.c: Use C++ exception handling.
5481         * python/py-symbol.c: Use C++ exception handling.
5482         * python/py-record.c: Use C++ exception handling.
5483         * python/py-record-btrace.c: Use C++ exception handling.
5484         * python/py-progspace.c: Use C++ exception handling.
5485         * python/py-prettyprint.c: Use C++ exception handling.
5486         * python/py-param.c: Use C++ exception handling.
5487         * python/py-objfile.c: Use C++ exception handling.
5488         * python/py-linetable.c: Use C++ exception handling.
5489         * python/py-lazy-string.c: Use C++ exception handling.
5490         * python/py-infthread.c: Use C++ exception handling.
5491         * python/py-inferior.c: Use C++ exception handling.
5492         * python/py-gdb-readline.c: Use C++ exception handling.
5493         * python/py-framefilter.c: Use C++ exception handling.
5494         * python/py-frame.c: Use C++ exception handling.
5495         * python/py-finishbreakpoint.c: Use C++ exception handling.
5496         * python/py-cmd.c: Use C++ exception handling.
5497         * python/py-breakpoint.c: Use C++ exception handling.
5498         * python/py-arch.c: Use C++ exception handling.
5499         * printcmd.c: Use C++ exception handling.
5500         * ppc-linux-tdep.c: Use C++ exception handling.
5501         * parse.c: Use C++ exception handling.
5502         * p-valprint.c: Use C++ exception handling.
5503         * objc-lang.c: Use C++ exception handling.
5504         * mi/mi-main.c: Use C++ exception handling.
5505         * mi/mi-interp.c: Use C++ exception handling.
5506         * mi/mi-cmd-stack.c: Use C++ exception handling.
5507         * mi/mi-cmd-break.c: Use C++ exception handling.
5508         * main.c: Use C++ exception handling.
5509         * linux-thread-db.c: Use C++ exception handling.
5510         * linux-tdep.c: Use C++ exception handling.
5511         * linux-nat.c: Use C++ exception handling.
5512         * linux-fork.c: Use C++ exception handling.
5513         * linespec.c: Use C++ exception handling.
5514         * language.c: Use C++ exception handling.
5515         * jit.c: Use C++ exception handling.
5516         * infrun.c: Use C++ exception handling.
5517         * infcmd.c: Use C++ exception handling.
5518         * infcall.c: Use C++ exception handling.
5519         * inf-loop.c: Use C++ exception handling.
5520         * i386-tdep.c: Use C++ exception handling.
5521         * i386-linux-tdep.c: Use C++ exception handling.
5522         * guile/scm-value.c: Use C++ exception handling.
5523         * guile/scm-type.c: Use C++ exception handling.
5524         * guile/scm-symtab.c: Use C++ exception handling.
5525         * guile/scm-symbol.c: Use C++ exception handling.
5526         * guile/scm-pretty-print.c: Use C++ exception handling.
5527         * guile/scm-ports.c: Use C++ exception handling.
5528         * guile/scm-param.c: Use C++ exception handling.
5529         * guile/scm-math.c: Use C++ exception handling.
5530         * guile/scm-lazy-string.c: Use C++ exception handling.
5531         * guile/scm-frame.c: Use C++ exception handling.
5532         * guile/scm-disasm.c: Use C++ exception handling.
5533         * guile/scm-cmd.c: Use C++ exception handling.
5534         * guile/scm-breakpoint.c: Use C++ exception handling.
5535         * guile/scm-block.c: Use C++ exception handling.
5536         * guile/guile-internal.h: Use C++ exception handling.
5537         * gnu-v3-abi.c: Use C++ exception handling.
5538         * gdbtypes.c: Use C++ exception handling.
5539         * frame.c: Use C++ exception handling.
5540         * frame-unwind.c: Use C++ exception handling.
5541         * fbsd-tdep.c: Use C++ exception handling.
5542         * f-valprint.c: Use C++ exception handling.
5543         * exec.c: Use C++ exception handling.
5544         * event-top.c: Use C++ exception handling.
5545         * event-loop.c: Use C++ exception handling.
5546         * eval.c: Use C++ exception handling.
5547         * dwarf2read.c: Use C++ exception handling.
5548         * dwarf2loc.c: Use C++ exception handling.
5549         * dwarf2-frame.c: Use C++ exception handling.
5550         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5551         * dwarf-index-write.c: Use C++ exception handling.
5552         * dwarf-index-cache.c: Use C++ exception handling.
5553         * dtrace-probe.c: Use C++ exception handling.
5554         * disasm-selftests.c: Use C++ exception handling.
5555         * darwin-nat.c: Use C++ exception handling.
5556         * cp-valprint.c: Use C++ exception handling.
5557         * cp-support.c: Use C++ exception handling.
5558         * cp-abi.c: Use C++ exception handling.
5559         * corelow.c: Use C++ exception handling.
5560         * completer.c: Use C++ exception handling.
5561         * compile/compile-object-run.c: Use C++ exception handling.
5562         * compile/compile-object-load.c: Use C++ exception handling.
5563         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5564         * compile/compile-c-symbols.c: Use C++ exception handling.
5565         * common/selftest.c: Use C++ exception handling.
5566         * common/new-op.c: Use C++ exception handling.
5567         * cli/cli-script.c: Use C++ exception handling.
5568         * cli/cli-interp.c: Use C++ exception handling.
5569         * cli/cli-cmds.c: Use C++ exception handling.
5570         * c-varobj.c: Use C++ exception handling.
5571         * btrace.c: Use C++ exception handling.
5572         * breakpoint.c: Use C++ exception handling.
5573         * break-catch-throw.c: Use C++ exception handling.
5574         * arch-utils.c: Use C++ exception handling.
5575         * amd64-tdep.c: Use C++ exception handling.
5576         * ada-valprint.c: Use C++ exception handling.
5577         * ada-typeprint.c: Use C++ exception handling.
5578         * ada-lang.c: Use C++ exception handling.
5579         * aarch64-tdep.c: Use C++ exception handling.
5580
5581 2019-04-08  Tom Tromey  <tom@tromey.com>
5582
5583         * xml-support.c (gdb_xml_parser::parse): Update.
5584         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5585         * value.c (show_convenience): Update.
5586         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5587         (test_parse_flags_qcs): Update.
5588         * thread.c (thr_try_catch_cmd): Update.
5589         * target.c (target_translate_tls_address): Update.
5590         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5591         (info_frame_command_core, frame_apply_command_count): Update.
5592         * rust-exp.y (rust_lex_exception_test): Update.
5593         * riscv-tdep.c (riscv_print_one_register_info): Update.
5594         * remote.c (remote_target::enable_btrace): Update.
5595         * record-btrace.c (record_btrace_enable_warn): Update.
5596         * python/py-utils.c (gdbpy_convert_exception): Update.
5597         * printcmd.c (do_one_display, print_variable_and_value): Update.
5598         * mi/mi-main.c (mi_print_exception): Update.
5599         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5600         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5601         * linux-nat.c (linux_nat_target::attach): Update.
5602         * linux-fork.c (class scoped_switch_fork_info): Update.
5603         * infrun.c (displaced_step_prepare): Update.
5604         * infcall.c (call_function_by_hand_dummy): Update.
5605         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5606         * gnu-v3-abi.c (print_one_vtable): Update.
5607         * frame.c (get_prev_frame_always): Update.
5608         * f-valprint.c (info_common_command_for_block): Update.
5609         * exec.c (try_open_exec_file): Update.
5610         * exceptions.c (print_exception, exception_print)
5611         (exception_fprintf, exception_print_same): Update.
5612         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5613         * dwarf-index-cache.c (index_cache::store)
5614         (index_cache::lookup_gdb_index): Update.
5615         * darwin-nat.c (maybe_cache_shell): Update.
5616         * cp-valprint.c (cp_print_value_fields): Update.
5617         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5618         (gcc_cplus_symbol_address): Update.
5619         * compile/compile-c-symbols.c (gcc_convert_symbol)
5620         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5621         * common/selftest.c: Update.
5622         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5623         a std::string.
5624         (exception_try_scope_entry, exception_try_scope_exit): Don't
5625         declare.
5626         (struct exception_try_scope): Remove.
5627         (TRY): Don't use exception_try_scope.
5628         (struct gdb_exception): Add constructor, operator=.
5629         <what>: New method.
5630         (struct gdb_exception_RETURN_MASK_ALL)
5631         (struct gdb_exception_RETURN_MASK_ERROR)
5632         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5633         (struct gdb_quit_bad_alloc): Update.
5634         * common/common-exceptions.c (exception_none): Change
5635         initializer.
5636         (struct catcher) <state, exception>: Initialize inline.
5637         <prev>: Remove member.
5638         (current_catcher): Remove.
5639         (catchers): New global.
5640         (exceptions_state_mc_init): Simplify.
5641         (catcher_pop): Remove.
5642         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5643         (try_scope_depth, exception_try_scope_entry)
5644         (exception_try_scope_exit): Remove.
5645         (throw_exception_sjlj): Update.
5646         (exception_messages, exception_messages_size): Remove.
5647         (throw_it): Simplify.
5648         (gdb_exception_sliced_copy): Remove.
5649         (throw_exception_cxx): Update.
5650         * cli/cli-script.c (script_from_file): Update.
5651         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5652         Update.
5653         * ada-valprint.c (ada_val_print): Update.
5654         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5655         (create_excep_cond_exprs): Update.
5656
5657 2019-04-08  Tom Tromey  <tom@tromey.com>
5658
5659         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5660         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5661         (TRY, CATCH, END_CATCH): Remove some definitions.
5662         * common/common-exceptions.c: Don't use GDB_XCPT.
5663         (catcher_list_size): Remove.
5664         (throw_exception, throw_it): Simplify.
5665
5666 2019-04-05  Tom Tromey  <tom@tromey.com>
5667
5668         Revert the header-sorting patch.
5669         * ft32-tdep.c: Revert.
5670         * frv-tdep.c: Revert.
5671         * frv-linux-tdep.c: Revert.
5672         * frame.c: Revert.
5673         * frame-unwind.c: Revert.
5674         * frame-base.c: Revert.
5675         * fork-child.c: Revert.
5676         * findvar.c: Revert.
5677         * findcmd.c: Revert.
5678         * filesystem.c: Revert.
5679         * filename-seen-cache.h: Revert.
5680         * filename-seen-cache.c: Revert.
5681         * fbsd-tdep.c: Revert.
5682         * fbsd-nat.h: Revert.
5683         * fbsd-nat.c: Revert.
5684         * f-valprint.c: Revert.
5685         * f-typeprint.c: Revert.
5686         * f-lang.c: Revert.
5687         * extension.h: Revert.
5688         * extension.c: Revert.
5689         * extension-priv.h: Revert.
5690         * expprint.c: Revert.
5691         * exec.h: Revert.
5692         * exec.c: Revert.
5693         * exceptions.c: Revert.
5694         * event-top.c: Revert.
5695         * event-loop.c: Revert.
5696         * eval.c: Revert.
5697         * elfread.c: Revert.
5698         * dwarf2read.h: Revert.
5699         * dwarf2read.c: Revert.
5700         * dwarf2loc.c: Revert.
5701         * dwarf2expr.h: Revert.
5702         * dwarf2expr.c: Revert.
5703         * dwarf2-frame.c: Revert.
5704         * dwarf2-frame-tailcall.c: Revert.
5705         * dwarf-index-write.h: Revert.
5706         * dwarf-index-write.c: Revert.
5707         * dwarf-index-common.c: Revert.
5708         * dwarf-index-cache.h: Revert.
5709         * dwarf-index-cache.c: Revert.
5710         * dummy-frame.c: Revert.
5711         * dtrace-probe.c: Revert.
5712         * disasm.h: Revert.
5713         * disasm.c: Revert.
5714         * disasm-selftests.c: Revert.
5715         * dictionary.c: Revert.
5716         * dicos-tdep.c: Revert.
5717         * demangle.c: Revert.
5718         * dcache.h: Revert.
5719         * dcache.c: Revert.
5720         * darwin-nat.h: Revert.
5721         * darwin-nat.c: Revert.
5722         * darwin-nat-info.c: Revert.
5723         * d-valprint.c: Revert.
5724         * d-namespace.c: Revert.
5725         * d-lang.c: Revert.
5726         * ctf.c: Revert.
5727         * csky-tdep.c: Revert.
5728         * csky-linux-tdep.c: Revert.
5729         * cris-tdep.c: Revert.
5730         * cris-linux-tdep.c: Revert.
5731         * cp-valprint.c: Revert.
5732         * cp-support.c: Revert.
5733         * cp-namespace.c: Revert.
5734         * cp-abi.c: Revert.
5735         * corelow.c: Revert.
5736         * corefile.c: Revert.
5737         * continuations.c: Revert.
5738         * completer.h: Revert.
5739         * completer.c: Revert.
5740         * complaints.c: Revert.
5741         * coffread.c: Revert.
5742         * coff-pe-read.c: Revert.
5743         * cli-out.h: Revert.
5744         * cli-out.c: Revert.
5745         * charset.c: Revert.
5746         * c-varobj.c: Revert.
5747         * c-valprint.c: Revert.
5748         * c-typeprint.c: Revert.
5749         * c-lang.c: Revert.
5750         * buildsym.c: Revert.
5751         * buildsym-legacy.c: Revert.
5752         * build-id.h: Revert.
5753         * build-id.c: Revert.
5754         * btrace.c: Revert.
5755         * bsd-uthread.c: Revert.
5756         * breakpoint.h: Revert.
5757         * breakpoint.c: Revert.
5758         * break-catch-throw.c: Revert.
5759         * break-catch-syscall.c: Revert.
5760         * break-catch-sig.c: Revert.
5761         * blockframe.c: Revert.
5762         * block.c: Revert.
5763         * bfin-tdep.c: Revert.
5764         * bfin-linux-tdep.c: Revert.
5765         * bfd-target.c: Revert.
5766         * bcache.c: Revert.
5767         * ax-general.c: Revert.
5768         * ax-gdb.h: Revert.
5769         * ax-gdb.c: Revert.
5770         * avr-tdep.c: Revert.
5771         * auxv.c: Revert.
5772         * auto-load.c: Revert.
5773         * arm-wince-tdep.c: Revert.
5774         * arm-tdep.c: Revert.
5775         * arm-symbian-tdep.c: Revert.
5776         * arm-pikeos-tdep.c: Revert.
5777         * arm-obsd-tdep.c: Revert.
5778         * arm-nbsd-tdep.c: Revert.
5779         * arm-nbsd-nat.c: Revert.
5780         * arm-linux-tdep.c: Revert.
5781         * arm-linux-nat.c: Revert.
5782         * arm-fbsd-tdep.c: Revert.
5783         * arm-fbsd-nat.c: Revert.
5784         * arm-bsd-tdep.c: Revert.
5785         * arch-utils.c: Revert.
5786         * arc-tdep.c: Revert.
5787         * arc-newlib-tdep.c: Revert.
5788         * annotate.h: Revert.
5789         * annotate.c: Revert.
5790         * amd64-windows-tdep.c: Revert.
5791         * amd64-windows-nat.c: Revert.
5792         * amd64-tdep.c: Revert.
5793         * amd64-sol2-tdep.c: Revert.
5794         * amd64-obsd-tdep.c: Revert.
5795         * amd64-obsd-nat.c: Revert.
5796         * amd64-nbsd-tdep.c: Revert.
5797         * amd64-nbsd-nat.c: Revert.
5798         * amd64-nat.c: Revert.
5799         * amd64-linux-tdep.c: Revert.
5800         * amd64-linux-nat.c: Revert.
5801         * amd64-fbsd-tdep.c: Revert.
5802         * amd64-fbsd-nat.c: Revert.
5803         * amd64-dicos-tdep.c: Revert.
5804         * amd64-darwin-tdep.c: Revert.
5805         * amd64-bsd-nat.c: Revert.
5806         * alpha-tdep.c: Revert.
5807         * alpha-obsd-tdep.c: Revert.
5808         * alpha-nbsd-tdep.c: Revert.
5809         * alpha-mdebug-tdep.c: Revert.
5810         * alpha-linux-tdep.c: Revert.
5811         * alpha-linux-nat.c: Revert.
5812         * alpha-bsd-tdep.c: Revert.
5813         * alpha-bsd-nat.c: Revert.
5814         * aix-thread.c: Revert.
5815         * agent.c: Revert.
5816         * addrmap.c: Revert.
5817         * ada-varobj.c: Revert.
5818         * ada-valprint.c: Revert.
5819         * ada-typeprint.c: Revert.
5820         * ada-tasks.c: Revert.
5821         * ada-lang.c: Revert.
5822         * aarch64-tdep.c: Revert.
5823         * aarch64-ravenscar-thread.c: Revert.
5824         * aarch64-newlib-tdep.c: Revert.
5825         * aarch64-linux-tdep.c: Revert.
5826         * aarch64-linux-nat.c: Revert.
5827         * aarch64-fbsd-tdep.c: Revert.
5828         * aarch64-fbsd-nat.c: Revert.
5829         * aarch32-linux-nat.c: Revert.
5830
5831 2019-04-05  Tom Tromey  <tom@tromey.com>
5832
5833         * ft32-tdep.c: Sort headers.
5834         * frv-tdep.c: Sort headers.
5835         * frv-linux-tdep.c: Sort headers.
5836         * frame.c: Sort headers.
5837         * frame-unwind.c: Sort headers.
5838         * frame-base.c: Sort headers.
5839         * fork-child.c: Sort headers.
5840         * findvar.c: Sort headers.
5841         * findcmd.c: Sort headers.
5842         * filesystem.c: Sort headers.
5843         * filename-seen-cache.h: Sort headers.
5844         * filename-seen-cache.c: Sort headers.
5845         * fbsd-tdep.c: Sort headers.
5846         * fbsd-nat.h: Sort headers.
5847         * fbsd-nat.c: Sort headers.
5848         * f-valprint.c: Sort headers.
5849         * f-typeprint.c: Sort headers.
5850         * f-lang.c: Sort headers.
5851         * extension.h: Sort headers.
5852         * extension.c: Sort headers.
5853         * extension-priv.h: Sort headers.
5854         * expprint.c: Sort headers.
5855         * exec.h: Sort headers.
5856         * exec.c: Sort headers.
5857         * exceptions.c: Sort headers.
5858         * event-top.c: Sort headers.
5859         * event-loop.c: Sort headers.
5860         * eval.c: Sort headers.
5861         * elfread.c: Sort headers.
5862         * dwarf2read.h: Sort headers.
5863         * dwarf2read.c: Sort headers.
5864         * dwarf2loc.c: Sort headers.
5865         * dwarf2expr.h: Sort headers.
5866         * dwarf2expr.c: Sort headers.
5867         * dwarf2-frame.c: Sort headers.
5868         * dwarf2-frame-tailcall.c: Sort headers.
5869         * dwarf-index-write.h: Sort headers.
5870         * dwarf-index-write.c: Sort headers.
5871         * dwarf-index-common.c: Sort headers.
5872         * dwarf-index-cache.h: Sort headers.
5873         * dwarf-index-cache.c: Sort headers.
5874         * dummy-frame.c: Sort headers.
5875         * dtrace-probe.c: Sort headers.
5876         * disasm.h: Sort headers.
5877         * disasm.c: Sort headers.
5878         * disasm-selftests.c: Sort headers.
5879         * dictionary.c: Sort headers.
5880         * dicos-tdep.c: Sort headers.
5881         * demangle.c: Sort headers.
5882         * dcache.h: Sort headers.
5883         * dcache.c: Sort headers.
5884         * darwin-nat.h: Sort headers.
5885         * darwin-nat.c: Sort headers.
5886         * darwin-nat-info.c: Sort headers.
5887         * d-valprint.c: Sort headers.
5888         * d-namespace.c: Sort headers.
5889         * d-lang.c: Sort headers.
5890         * ctf.c: Sort headers.
5891         * csky-tdep.c: Sort headers.
5892         * csky-linux-tdep.c: Sort headers.
5893         * cris-tdep.c: Sort headers.
5894         * cris-linux-tdep.c: Sort headers.
5895         * cp-valprint.c: Sort headers.
5896         * cp-support.c: Sort headers.
5897         * cp-namespace.c: Sort headers.
5898         * cp-abi.c: Sort headers.
5899         * corelow.c: Sort headers.
5900         * corefile.c: Sort headers.
5901         * continuations.c: Sort headers.
5902         * completer.h: Sort headers.
5903         * completer.c: Sort headers.
5904         * complaints.c: Sort headers.
5905         * coffread.c: Sort headers.
5906         * coff-pe-read.c: Sort headers.
5907         * cli-out.h: Sort headers.
5908         * cli-out.c: Sort headers.
5909         * charset.c: Sort headers.
5910         * c-varobj.c: Sort headers.
5911         * c-valprint.c: Sort headers.
5912         * c-typeprint.c: Sort headers.
5913         * c-lang.c: Sort headers.
5914         * buildsym.c: Sort headers.
5915         * buildsym-legacy.c: Sort headers.
5916         * build-id.h: Sort headers.
5917         * build-id.c: Sort headers.
5918         * btrace.c: Sort headers.
5919         * bsd-uthread.c: Sort headers.
5920         * breakpoint.h: Sort headers.
5921         * breakpoint.c: Sort headers.
5922         * break-catch-throw.c: Sort headers.
5923         * break-catch-syscall.c: Sort headers.
5924         * break-catch-sig.c: Sort headers.
5925         * blockframe.c: Sort headers.
5926         * block.c: Sort headers.
5927         * bfin-tdep.c: Sort headers.
5928         * bfin-linux-tdep.c: Sort headers.
5929         * bfd-target.c: Sort headers.
5930         * bcache.c: Sort headers.
5931         * ax-general.c: Sort headers.
5932         * ax-gdb.h: Sort headers.
5933         * ax-gdb.c: Sort headers.
5934         * avr-tdep.c: Sort headers.
5935         * auxv.c: Sort headers.
5936         * auto-load.c: Sort headers.
5937         * arm-wince-tdep.c: Sort headers.
5938         * arm-tdep.c: Sort headers.
5939         * arm-symbian-tdep.c: Sort headers.
5940         * arm-pikeos-tdep.c: Sort headers.
5941         * arm-obsd-tdep.c: Sort headers.
5942         * arm-nbsd-tdep.c: Sort headers.
5943         * arm-nbsd-nat.c: Sort headers.
5944         * arm-linux-tdep.c: Sort headers.
5945         * arm-linux-nat.c: Sort headers.
5946         * arm-fbsd-tdep.c: Sort headers.
5947         * arm-fbsd-nat.c: Sort headers.
5948         * arm-bsd-tdep.c: Sort headers.
5949         * arch-utils.c: Sort headers.
5950         * arc-tdep.c: Sort headers.
5951         * arc-newlib-tdep.c: Sort headers.
5952         * annotate.h: Sort headers.
5953         * annotate.c: Sort headers.
5954         * amd64-windows-tdep.c: Sort headers.
5955         * amd64-windows-nat.c: Sort headers.
5956         * amd64-tdep.c: Sort headers.
5957         * amd64-sol2-tdep.c: Sort headers.
5958         * amd64-obsd-tdep.c: Sort headers.
5959         * amd64-obsd-nat.c: Sort headers.
5960         * amd64-nbsd-tdep.c: Sort headers.
5961         * amd64-nbsd-nat.c: Sort headers.
5962         * amd64-nat.c: Sort headers.
5963         * amd64-linux-tdep.c: Sort headers.
5964         * amd64-linux-nat.c: Sort headers.
5965         * amd64-fbsd-tdep.c: Sort headers.
5966         * amd64-fbsd-nat.c: Sort headers.
5967         * amd64-dicos-tdep.c: Sort headers.
5968         * amd64-darwin-tdep.c: Sort headers.
5969         * amd64-bsd-nat.c: Sort headers.
5970         * alpha-tdep.c: Sort headers.
5971         * alpha-obsd-tdep.c: Sort headers.
5972         * alpha-nbsd-tdep.c: Sort headers.
5973         * alpha-mdebug-tdep.c: Sort headers.
5974         * alpha-linux-tdep.c: Sort headers.
5975         * alpha-linux-nat.c: Sort headers.
5976         * alpha-bsd-tdep.c: Sort headers.
5977         * alpha-bsd-nat.c: Sort headers.
5978         * aix-thread.c: Sort headers.
5979         * agent.c: Sort headers.
5980         * addrmap.c: Sort headers.
5981         * ada-varobj.c: Sort headers.
5982         * ada-valprint.c: Sort headers.
5983         * ada-typeprint.c: Sort headers.
5984         * ada-tasks.c: Sort headers.
5985         * ada-lang.c: Sort headers.
5986         * aarch64-tdep.c: Sort headers.
5987         * aarch64-ravenscar-thread.c: Sort headers.
5988         * aarch64-newlib-tdep.c: Sort headers.
5989         * aarch64-linux-tdep.c: Sort headers.
5990         * aarch64-linux-nat.c: Sort headers.
5991         * aarch64-fbsd-tdep.c: Sort headers.
5992         * aarch64-fbsd-nat.c: Sort headers.
5993         * aarch32-linux-nat.c: Sort headers.
5994
5995 2019-04-04  Tom Tromey  <tom@tromey.com>
5996
5997         * varobj.c (varobj_create): Update.
5998         * rust-exp.y (struct rust_parser) <update_innermost_block,
5999         lookup_symbol>: New methods.
6000         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6001         Rename.
6002         (rust_parser::rust_lookup_type)
6003         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6004         * printcmd.c (display_command, do_one_display): Update.
6005         * parser-defs.h (struct parser_state) <parser_state>: Add
6006         "tracker" parameter.
6007         (block_tracker): New member.
6008         (class innermost_block_tracker) <innermost_block_tracker>: Add
6009         "types" parameter.
6010         <reset>: Remove method.
6011         (innermost_block): Don't declare.
6012         (null_post_parser): Update.
6013         * parse.c (innermost_block): Remove global.
6014         (write_dollar_variable): Update.
6015         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6016         Remove "tracker_types" parameter.
6017         (parse_expression): Add "tracker" parameter.
6018         (parse_expression_for_completion): Update.
6019         (null_post_parser): Add "tracker" parameter.
6020         * p-exp.y: Update rules.
6021         * m2-exp.y: Update rules.
6022         * language.h (struct language_defn) <la_post_parser>: Add
6023         "tracker" parameter.
6024         * go-exp.y: Update rules.
6025         * f-exp.y: Update rules.
6026         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6027         parameter.
6028         * d-exp.y: Update rules.
6029         * c-exp.y: Update rules.
6030         * breakpoint.c (set_breakpoint_condition): Create an
6031         innermost_block_tracker.
6032         (watch_command_1): Likewise.
6033         * ada-lang.c (resolve): Add "tracker" parameter.
6034         (resolve_subexp): Likewise.
6035         * ada-exp.y (write_var_from_sym): Update.
6036
6037 2019-04-04  Tom Tromey  <tom@tromey.com>
6038
6039         * type-stack.h: New file.
6040         * type-stack.c: New file.
6041         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6042         type-stack.h.
6043         (insert_into_type_stack, insert_type, push_type, push_type_int)
6044         (insert_type_address_space, pop_type, pop_type_int)
6045         (pop_typelist, pop_type_stack, append_type_stack)
6046         (push_type_stack, get_type_stack, push_typelist)
6047         (follow_type_instance_flags, follow_types): Don't declare.
6048         * parse.c (type_stack): Remove global.
6049         (parse_exp_in_context): Update.
6050         (insert_into_type_stack, insert_type, push_type, push_type_int)
6051         (insert_type_address_space, pop_type, pop_type_int)
6052         (pop_typelist, pop_type_stack, append_type_stack)
6053         (push_type_stack, get_type_stack, push_typelist)
6054         (follow_type_instance_flags, follow_types): Remove (moved to
6055         type-stack.c).
6056         * f-exp.y (type_stack): New global.
6057         Update rules.
6058         (push_kind_type, f_parse): Update.
6059         * d-exp.y (type_stack): New global.
6060         Update rules.
6061         (d_parse): Update.
6062         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6063         Update rules.
6064         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6065         (HFILES_NO_SRCDIR): Add type-stack.h.
6066
6067 2019-04-04  Tom Tromey  <tom@tromey.com>
6068
6069         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6070         (rust_parser::convert_ast_to_expression, rust_parse)
6071         (rust_lex_test_completion, rust_lex_tests): Update.
6072         * parser-defs.h (struct expr_completion_state): New.
6073         (struct parser_state) <parser_state>: Add completion parameter.
6074         <mark_struct_expression, mark_completion_tag>: New methods.
6075         <parse_completion, m_completion_state>: New members.
6076         (prefixify_expression, null_post_parser): Update.
6077         (mark_struct_expression, mark_completion_tag): Don't declare.
6078         * parse.c (parse_completion, expout_last_struct)
6079         (expout_tag_completion_type, expout_completion_name): Remove
6080         globals.
6081         (parser_state::mark_struct_expression)
6082         (parser_state::mark_completion_tag): Now methods.
6083         (prefixify_expression): Add last_struct parameter.
6084         (prefixify_subexp): Likewise.
6085         (parse_exp_1): Update.
6086         (parse_exp_in_context): Add cstate parameter.  Update.
6087         (parse_expression_for_completion): Create an
6088         expr_completion_state.
6089         (null_post_parser): Add "completion" parameter.
6090         * p-exp.y: Update rules.
6091         (yylex): Update.
6092         * language.h (struct language_defn) <la_post_parser>: Add
6093         "completing" parameter.
6094         * go-exp.y: Update rules.
6095         (lex_one_token): Update.
6096         * expression.h (parse_completion): Don't declare.
6097         * d-exp.y: Update rules.
6098         (lex_one_token): Update rules.
6099         * c-exp.y: Update rules.
6100         (lex_one_token): Update.
6101         * ada-lang.c (resolve): Add "parse_completion" parameter.
6102         (resolve_subexp): Likewise.
6103         (ada_resolve_function): Likewise.
6104
6105 2019-04-04  Tom Tromey  <tom@tromey.com>
6106
6107         * parser-defs.h (struct parser_state) <start_arglist,
6108         end_arglist>: New methods.
6109         <arglist_len, m_funcall_chain>: New members.
6110         (arglist_len, start_arglist, end_arglist): Don't declare.
6111         * parse.c (arglist_len, funcall_chain): Remove global.
6112         (start_arglist, end_arglist): Remove functions.
6113         (parse_exp_in_context): Update.
6114         * p-exp.y: Update rules.
6115         * m2-exp.y: Update rules.
6116         * go-exp.y: Update rules.
6117         * f-exp.y: Update rules.
6118         * d-exp.y: Update rules.
6119         * c-exp.y: Update rules.
6120
6121 2019-04-04  Tom Tromey  <tom@tromey.com>
6122
6123         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6124         lex_operator, push_back>: New methods.
6125         Update all rules.
6126         (rust_parser::lex_hex, lex_escape): Rename and update.
6127         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6128         (rust_parser::lex_operator): Rename and update.
6129         (rust_parser::lex_number, rustyylex, rustyyerror)
6130         (rust_lex_test_init, rust_lex_test_sequence)
6131         (rust_lex_test_push_back, rust_lex_tests): Update.
6132         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6133         parameter.
6134         <lexptr, prev_lexptr>: New members.
6135         (lexptr, prev_lexptr): Don't declare.
6136         * parse.c (lexptr, prev_lexptr): Remove globals.
6137         (parse_exp_in_context): Update.
6138         * p-exp.y (yylex, yyerror): Update.
6139         * m2-exp.y (parse_number, yylex, yyerror): Update.
6140         * go-exp.y (lex_one_token, yyerror): Update.
6141         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6142         * d-exp.y (lex_one_token, yyerror): Update.
6143         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6144         (lex_one_token, yyerror): Update.
6145         * ada-lex.l (YY_INPUT): Update.
6146         (rewind_to_char): Update.
6147         * ada-exp.y (yyerror): Update.
6148
6149 2019-04-04  Tom Tromey  <tom@tromey.com>
6150
6151         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6152         * parser-defs.h (struct parser_state) <parser_state>: Add new
6153         parameter.
6154         <comma_terminates>: New member.
6155         (comma_terminates): Don't declare global.
6156         * parse.c (comma_terminates): Remove global.
6157         (parse_exp_in_context): Update.
6158         * p-exp.y (yylex): Update.
6159         * m2-exp.y (yylex): Update.
6160         * go-exp.y (lex_one_token): Update.
6161         * f-exp.y (yylex): Update.
6162         * d-exp.y (lex_one_token): Update.
6163         * c-exp.y (lex_one_token): Update.
6164         * ada-lex.l: Update.
6165
6166 2019-04-04  Tom Tromey  <tom@tromey.com>
6167
6168         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6169         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6170         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6171         * parser-defs.h (paren_depth): Don't declare.
6172         * parse.c (paren_depth): Remove global.
6173         (parse_exp_in_context): Update.
6174         * p-exp.y (paren_depth): New global.
6175         (pascal_parse): Initialize it.
6176         * m2-exp.y (paren_depth): New global.
6177         (m2_parse): Initialize it.
6178         * go-exp.y (paren_depth): New global.
6179         (go_parse): Initialize it.
6180         * f-exp.y (paren_depth): New global.
6181         (f_parse): Initialize it.
6182         * d-exp.y (paren_depth): New global.
6183         (d_parse): Initialize it.
6184         * c-exp.y (paren_depth): New global.
6185         (c_parse): Initialize it.
6186         * ada-lex.l (paren_depth): New global.
6187         (lexer_init): Initialize it.
6188
6189 2019-04-04  Tom Tromey  <tom@tromey.com>
6190
6191         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6192         (rust_parser::convert_ast_to_type)
6193         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6194         * parser-defs.h (struct parser_state) <parser_state>: Add
6195         parameters.  Initialize new members.
6196         <expression_context_block, expression_context_pc>: New members.
6197         * parse.c (expression_context_block, expression_context_pc):
6198         Remove globals.
6199         (parse_exp_in_context): Update.
6200         * p-exp.y: Update all rules.
6201         (yylex): Update.
6202         * m2-exp.y: Update all rules.
6203         (yylex): Update.
6204         * go-exp.y (yylex): Update.
6205         * f-exp.y (yylex): Update.
6206         * d-exp.y: Update all rules.
6207         (yylex): Update.
6208         * c-exp.y: Update all rules.
6209         (lex_one_token, classify_name, yylex, c_parse): Update.
6210         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6211
6212 2019-04-04  Tom Tromey  <tom@tromey.com>
6213
6214         * gdbarch.h, gdbarch.c: Rebuild.
6215         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6216         * stap-probe.h:
6217         (struct stap_parse_info): Replace "parser_state" with
6218         "expr_builder".
6219         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6220         (parser_state): New class.
6221         * parse.c (expr_builder): Rename.
6222         (expr_builder::release): Rename.
6223         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6224         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6225         (write_exp_elt_longcst, write_exp_elt_floatcst)
6226         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6227         (write_exp_string_vector, write_exp_bitstring)
6228         (write_exp_msymbol, mark_struct_expression)
6229         (write_dollar_variable)
6230         (insert_type_address_space, increase_expout_size): Replace
6231         "parser_state" with "expr_builder".
6232         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6233         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6234         "parser_state" with "expr_builder".
6235
6236 2019-04-04  Tom Tromey  <tom@tromey.com>
6237
6238         * rust-exp.y: Replace "parse_language" with method call.
6239         * p-exp.y:
6240         (yylex): Replace "parse_language" with method call.
6241         * m2-exp.y:
6242         (yylex): Replace "parse_language" with method call.
6243         * go-exp.y (classify_name): Replace "parse_language" with method
6244         call.
6245         * f-exp.y (yylex): Replace "parse_language" with method call.
6246         * d-exp.y (lex_one_token): Replace "parse_language" with method
6247         call.
6248         * c-exp.y:
6249         (lex_one_token, classify_name, yylex): Replace "parse_language"
6250         with method call.
6251         * ada-exp.y (find_primitive_type, type_char)
6252         (type_system_address): Replace "parse_language" with method call.
6253
6254 2019-04-04  Tom Tromey  <tom@tromey.com>
6255
6256         * rust-exp.y: Replace "parse_gdbarch" with method call.
6257         * parse.c (write_dollar_variable, insert_type_address_space):
6258         Replace "parse_gdbarch" with method call.
6259         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6260         call.
6261         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6262         call.
6263         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6264         "parse_gdbarch" with method call.
6265         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6266         with method call.
6267         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6268         "parse_gdbarch" with method call.
6269         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6270         "parse_gdbarch" with method call.
6271         * c-exp.y (parse_type, parse_number, classify_name): Replace
6272         "parse_gdbarch" with method call.
6273         * ada-lex.l: Replace "parse_gdbarch" with method call.
6274         * ada-exp.y (parse_type, find_primitive_type, type_char)
6275         (type_system_address): Replace "parse_gdbarch" with method call.
6276
6277 2019-04-04  Tom Tromey  <tom@tromey.com>
6278
6279         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6280         * stap-probe.c (stap_parse_argument): Update.
6281         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6282         initial_size parameter.
6283         * rust-exp.y (rust_lex_tests): Update.
6284         * parse.c (parser_state): Update.
6285         (parse_exp_in_context): Update.
6286         * parser-defs.h (struct parser_state) <parser_state>: Remove
6287         "initial_size" parameter.
6288
6289 2019-04-04  Tom Tromey  <tom@tromey.com>
6290
6291         * parser-defs.h (increase_expout_size): Don't declare.
6292         * parse.c (increase_expout_size): Now static.
6293
6294 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6295
6296         * gnu-nat.c (gnu_nat_target::wait): Fix
6297         target_waitstatus_to_string call.
6298
6299 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6300
6301         * eval.c (evaluate_subexp_standard): Handle internal functions
6302         during Fortran function call handling.
6303
6304 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6305
6306         * NEWS: Mention new internal functions.
6307         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6308         (read_base_type): Use dwarf2_init_complex_target_type.
6309         * value.c (creal_internal_fn): New function.
6310         (cimag_internal_fn): New function.
6311         (_initialize_values): Register new internal functions.
6312
6313 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6314
6315         * infrun.c (stop_all_threads): If debug_infrun, always
6316         trace the wait status after wait_one, using
6317         target_waitstatus_to_string and target_pid_to_str.
6318         (handle_inferior_event): Replace various trace of
6319         wait status kind by a single trace.
6320         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6321         wait status kind image by target_waitstatus_to_string.
6322         * target/waitstatus.c (target_waitstatus_to_string): Fix
6323         obsolete comment.
6324
6325 2019-04-01  Tom Tromey  <tromey@adacore.com>
6326
6327         PR symtab/23331:
6328         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6329
6330 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6331             Pedro Alves  <palves@redhat.com>
6332
6333         * top.c (quit_force): Call 'finalize_values'.
6334         * value.c (finalize_values): New function.
6335         * value.h (finalize_values): Declare.
6336
6337 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6338
6339         * NEWS: Announce $_gdb_major and $_gdb_minor.
6340
6341         * top.c (init_gdb_version_vars): New function.
6342         (gdb_init): Call init_gdb_version_vars.
6343
6344 2019-03-29  Tom Tromey  <tromey@adacore.com>
6345
6346         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6347         help text.  Remove dead code.
6348
6349 2019-03-29  Keith Seitz  <keiths@redhat.com>
6350
6351         From Siddhesh Poyarekar:
6352         * f-lang.h (f77_get_upperbound): Return LONGEST.
6353         (f77_get_lowerbound): Likewise.
6354         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6355         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6356         print them.
6357         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6358         plongest to format print it.
6359         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6360         (f77_get_upperbound): Likewise.
6361         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6362         LOWER_BOUND to LONGEST.
6363         (f77_create_arrayprint_offset_tbl): Likewise.
6364
6365 2019-03-29  Keith Seitz  <keiths@redhat.com>
6366
6367         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6368         %s/pulongest for TYPE_LENGTH instead of %d in format
6369         strings.
6370         * ada-typerint.c (ada_print_type): Likewise.
6371         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6372         * compile/compile-c-support.c (generate_register_struct): Likewise.
6373         * gdbtypes.c (recursive_dump_type): Likewise.
6374         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6375         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6376         instead of %d in format strings.
6377         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6378         to std::min to ULONGEST.
6379         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6380         instead of %d in format strings.
6381         * tracepoint.c (info_scope_command): Likewise.
6382         * typeprint.c (print_offset_data::update)
6383         (print_offset_data::finish): Likewise.
6384         * xtensa-tdep.c (xtensa_store_return_value)
6385         (xtensa_push_dummy_call): Likewise.
6386
6387 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6388
6389         * windows-nat.c (display_selector): Fixed format specifications
6390         for 64-bit Cygwin.
6391
6392 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6393
6394         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6395
6396 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6397
6398         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6399         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6400         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6401         (nios2_linux_init_abi): Install it.
6402
6403 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6404
6405         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6406
6407 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6408
6409         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6410
6411 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6412             Tom Tromey  <tromey@adacore.com>
6413
6414         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6415
6416 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6417
6418         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6419         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6420         method to compute the bounds of range types. Also print "[evaluated]"
6421         if the bounds' values come from a dynamic evaluation.
6422
6423 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6424
6425         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6426         whitespace when pretty printing is on.
6427
6428 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6429
6430         * ppc-linux-nat.c: Add include.
6431
6432 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6433
6434         * NEWS: Mention AArch64 Pointer Authentication.
6435
6436 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6437
6438         * arm-linux-nat.c: Add include.
6439
6440 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6441
6442         * source-cache.c (source_cache::get_source_lines): Re-read
6443         fullname after calling open_source_file.
6444
6445 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6446
6447         * NEWS: Mention TLS support for FreeBSD.
6448
6449 2019-03-25  Tom Tromey  <tromey@adacore.com>
6450
6451         * minsyms.c (BUNCH_SIZE): Update comment.
6452         (~minimal_symbol_reader): Remove old comment.
6453         (compact_minimal_symbols): Update comment.
6454         (minimal_symbol_reader::install): Remove old comment.  Update
6455         other comments.
6456
6457 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6458
6459         * s390-linux-nat.c: Add include.
6460
6461 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6462
6463         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6464         Call linux_get_hwcap.
6465         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6466         Likewise.
6467         (aarch64_linux_get_hwcap): Remove function.
6468         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6469         declaration.
6470         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6471         linux_get_hwcap.
6472         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6473         * linux-tdep.c (linux_get_hwcap): Add function.
6474         (linux_get_hwcap2): Likewise.
6475         * linux-tdep.h (linux_get_hwcap): Add declaration.
6476         (linux_get_hwcap2): Likewise.
6477         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6478         (ppc_linux_get_hwcap2): Likewise.
6479         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6480         linux_get_hwcap.
6481         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6482         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6483         (ppc_linux_nat_target::read_description): Likewise.
6484         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6485         * s390-linux-nat.c: Likewise.
6486         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6487
6488 2019-03-24  Tom Tromey  <tom@tromey.com>
6489
6490         * ada-lang.c (standard_lookup): Simplify initialization.
6491         (ada_lookup_symbol_nonlocal): Simplify return.
6492         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6493         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6494         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6495         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6496         initialization.
6497         * solib.c (solib_global_lookup): Simplify.
6498         * symtab.c (null_block_symbol): Remove.
6499         (symbol_cache_lookup): Simplify returns.
6500         (lookup_language_this): Simplify returns.
6501         (lookup_symbol_aux): Simplify return.
6502         (lookup_local_symbol): Simplify returns.
6503         (lookup_global_symbol_from_objfile): Simplify return.
6504         (lookup_symbol_in_objfile_symtabs)
6505         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6506         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6507         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6508         * cp-namespace.c (cp_lookup_bare_symbol)
6509         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6510         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6511         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6512         (cp_lookup_symbol_via_imports): Simplify initialization.
6513         (find_symbol_in_baseclass): Likewise.
6514         * symtab.h (null_block_symbol): Remove.
6515         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6516         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6517         (d_lookup_symbol_module): Likewise.
6518         (find_symbol_in_baseclass): Simplify initialization.
6519
6520 2019-03-24  Tom Tromey  <tom@tromey.com>
6521
6522         * expression.h: Don't include symtab.h.
6523         (struct block): Forward declare.
6524
6525 2019-03-24  Tom Tromey  <tom@tromey.com>
6526
6527         * c-exp.y (typebase): Remove casts.
6528         * gdbtypes.c (lookup_unsigned_typename, )
6529         (lookup_signed_typename): Remove cast.
6530         * eval.c (parse_to_comma_and_eval): Remove cast.
6531         * parse.c (write_dollar_variable): Remove cast.
6532         * block.h (struct block) <superblock>: Now const.
6533         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6534         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6535         (map_block): Make "block" const.
6536         * symfile.h (struct quick_symbol_functions)
6537         <map_matching_symbols>: Constify block argument to "callback".
6538         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6539         const.
6540         (find_pc_sect_compunit_symtab): Make "b" const.
6541         (find_symbol_at_address): Likewise.
6542         (search_symbols): Likewise.
6543         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6544         (dw2_debug_names_lookup_symbol): Likewise.
6545         (dw2_map_matching_symbols): Update.
6546         * p-valprint.c (pascal_val_print): Remove "block".
6547         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6548         (aux_add_nonlocal_symbols): Make "block" const.
6549         (resolve_subexp): Remove cast.
6550         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6551         const.
6552         (iterate_over_file_blocks): Likewise.
6553         * f-exp.y (%union) <bval>: Remove.
6554         * coffread.c (patch_opaque_types): Make "b" const.
6555         * spu-tdep.c (spu_catch_start): Make "block" const.
6556         * c-valprint.c (print_unpacked_pointer): Remove "block".
6557         * symmisc.c (dump_symtab_1): Make "b" const.
6558         (block_depth): Make "block" const.
6559         * d-exp.y (%union) <bval>: Remove.
6560         * cp-support.h (cp_lookup_rtti_type): Update.
6561         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6562         * psymtab.c (psym_lookup_symbol): Make "block" const.
6563         (maintenance_check_psymtabs): Make "b" const.
6564         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6565         (enumerate_locals, enumerate_args): Update.
6566         * python/py-symtab.c (stpy_global_block): Make "block" const.
6567         (stpy_static_block): Likewise.
6568         * inline-frame.c (block_starting_point_at): Make "new_block"
6569         const.
6570         * block.c (find_block_in_blockvector): Make return type const.
6571         (blockvector_for_pc_sect): Make "b" const.
6572         (find_block_in_blockvector): Make "b" const.
6573
6574 2019-03-23  Tom Tromey  <tom@tromey.com>
6575
6576         * varobj.c (varobj_create): Update.
6577         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6578         * printcmd.c (display_command, do_one_display): Don't reset
6579         innermost_block.
6580         * parser-defs.h (enum innermost_block_tracker_type): Move to
6581         expression.h.
6582         (innermost_block): Update comment.
6583         * parse.c (parse_exp_1): Add tracker_types parameter.
6584         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6585         tracker_types parameter.  Reset innermost_block.
6586         (parse_exp_in_context): Remove.
6587         (parse_expression_for_completion): Update.
6588         * objfiles.c (~objfile): Don't reset expression_context_block or
6589         innermost_block.
6590         * expression.h (enum innermost_block_tracker_type): Move from
6591         parser-defs.h.
6592         (parse_exp_1): Add tracker_types parameter.
6593         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6594         reset innermost_block.
6595
6596 2019-03-23  Tom Tromey  <tom@tromey.com>
6597
6598         * objfiles.h: Include bcache.h.
6599
6600 2019-03-23  Tom Tromey  <tom@tromey.com>
6601
6602         * linespec.c (get_current_search_block): Use
6603         scoped_restore_current_language.
6604         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6605
6606 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6607             Jiong Wang  <jiong.wang@arm.com>
6608
6609         * aarch64-linux-tdep.c
6610         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6611         section.
6612         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6613
6614 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6615             Jiong Wang  <jiong.wang@arm.com>
6616
6617         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6618         instructions.
6619         (aarch64_analyze_prologue_test): Add PACIASP test.
6620         (aarch64_prologue_prev_register): Unmask PC value.
6621
6622 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6623             Jiong Wang  <jiong.wang@arm.com>
6624
6625         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6626         (aarch64_dwarf2_prev_register): Unmask PC value.
6627         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6628         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6629         DW_CFA_AARCH64_negate_ra_state.
6630         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6631
6632 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6633             Jiong Wang  <jiong.wang@arm.com>
6634
6635         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6636         registers.
6637         (aarch64_pseudo_register_name): Likewise.
6638         (aarch64_pseudo_register_type): Likewise.
6639         (aarch64_pseudo_register_reggroup_p): Likewise.
6640         (aarch64_gdbarch_init): Add pauth registers.
6641         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6642         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6643         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6644         (struct gdbarch_tdep): Add regnum for ra_state.
6645
6646 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6647             Jiong Wang  <jiong.wang@arm.com>
6648
6649         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6650
6651 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6652             Jiong Wang  <jiong.wang@arm.com>
6653
6654         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6655         function.
6656         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6657         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6658         (aarch64_gdbarch_init): Add puth registers.
6659         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6660         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6661         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6662
6663 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6664             Jiong Wang  <jiong.wang@arm.com>
6665
6666         * aarch64-linux-nat.c
6667         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6668         * aarch64-linux-tdep.c
6669         (aarch64_linux_core_read_description): Likewise.
6670         (aarch64_linux_get_hwcap): New function.
6671         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6672         (aarch64_linux_get_hwcap): New declaration.
6673
6674 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6675             Jiong Wang  <jiong.wang@arm.com>
6676
6677         * aarch64-linux-nat.c
6678         (aarch64_linux_nat_target::read_description): Add pauth param.
6679         * aarch64-linux-tdep.c
6680         (aarch64_linux_core_read_description): Likewise.
6681         * aarch64-tdep.c (struct target_desc): Add in pauth.
6682         (aarch64_read_description): Add pauth param.
6683         (aarch64_gdbarch_init): Likewise.
6684         * aarch64-tdep.h (aarch64_read_description): Likewise.
6685         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6686         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6687         * features/Makefile: Add new files.
6688         * features/aarch64-pauth.c: New file.
6689         * features/aarch64-pauth.xml: New file.
6690
6691 2019-03-20  Tom Tromey  <tromey@adacore.com>
6692
6693         * infrun.c (handle_inferior_event): Rename from
6694         handle_inferior_event_1.  Create a scoped_value_mark.
6695         (handle_inferior_event): Remove.
6696
6697 2019-03-19  Tom Tromey  <tromey@adacore.com>
6698
6699         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6700         * infrun.h (print_stop_event): Add "displays" parameter.
6701         * infrun.c (print_stop_event): Add "displays" parameter.
6702
6703 2019-03-19  Pedro Alves  <palves@redhat.com>
6704
6705         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6706         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6707         to -1.  Fix TABs vs spaces.
6708         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6709         * tui/tui-out.h (tui_ui_out) Add intro comments.
6710         <m_line, m_start_of_line>: In-class initialize, and add describing
6711         comment.
6712
6713 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6714
6715         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6716         variable names.
6717         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6718
6719 2019-03-18  Pedro Alves  <palves@redhat.com>
6720             Eli Zaretskii <eliz@gnu.org>
6721
6722         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6723         m_line and m_start_of_line.
6724
6725 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6726
6727         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6728         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6729         it returns a newline.  This fixes a regression in TU mode, whereby
6730         the next line is output on the same screen line as the user input.
6731
6732 2019-03-18  Tom Tromey  <tromey@adacore.com>
6733
6734         * minsyms.c (minimal_symbol_reader::install): Remove call to
6735         obstack_blank.
6736
6737 2019-03-18  Pedro Alves  <palves@redhat.com>
6738
6739         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6740         New globals.
6741         (apply_style): New, factored out from ...
6742         (apply_ansi_escape): ... this.  Handle reverse video mode.
6743         (tui_set_reverse_mode): New function.
6744         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6745         * tui/tui-winsource.c (tui_show_source_line): Use
6746         tui_set_reverse_mode instead of setting A_STANDOUT.
6747         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6748         New setter methods.
6749
6750 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6751
6752         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6753         Handle tabs.
6754
6755 2019-03-18  Tom Tromey  <tromey@adacore.com>
6756
6757         * ada-lang.c (empty_array): Add "high" parameter.
6758         (ada_evaluate_subexp): Update.
6759
6760 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6761
6762         * unittests/string_view-selftests.c: Define
6763         _initialize_string_view_selftests unconditionally.
6764
6765 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6766
6767         PR gdb/24350
6768         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6769
6770 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6771
6772         PR gdb/24351
6773         * windows-nat.c (display_selector): Fix format specifiers.
6774
6775 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6776
6777         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6778         tui_refill_source_window instead of tui_refresh_win, to update the
6779         current execution line.  This fixes redisplay of the current line
6780         when stepping through the code with "next" or "step".
6781
6782 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6783
6784         * source-cache.c (source_cache::get_source_lines): Call
6785         find_source_lines to initialize s->nlines.  This fixes vertical
6786         scrolling of TUI source window when the DOWN arrow is pressed.
6787
6788 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6789
6790         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6791         linux-thread-db.c (_initialize_thread_db): Likewise.
6792
6793 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6794
6795         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6796         wclrtoeol in tui_show_source_line".  This reverts changes made in
6797         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6798
6799 2019-03-15  Tom Tromey  <tom@tromey.com>
6800
6801         * symtab.h (struct minimal_symbol): Derive from
6802         general_symbol_info.
6803         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6804         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6805         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6806         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6807         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6808         (MSYMBOL_SEARCH_NAME): Update.
6809         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6810         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6811         * minsyms.c (minimal_symbol_reader::record_full): Update.
6812
6813 2019-03-15  Tom Tromey  <tom@tromey.com>
6814
6815         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6816
6817 2019-03-15  Tom Tromey  <tom@tromey.com>
6818
6819         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6820         unique_xmalloc_ptr.
6821         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6822         Update.
6823         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6824         (build_minimal_symbol_hash_tables)
6825         (minimal_symbol_reader::install): Update.
6826
6827 2019-03-15  Tom Tromey  <tom@tromey.com>
6828
6829         * symtab.c (create_demangled_names_hash): Update.
6830         (symbol_set_names): Update.
6831         * objfiles.h (struct objfile_per_bfd_storage)
6832         <demangled_names_hash>: Now an htab_up.
6833         * objfiles.c (objfile_per_bfd_storage): Simplify.
6834
6835 2019-03-15  Tom Tromey  <tom@tromey.com>
6836
6837         * objfiles.h (struct objfile_per_bfd_storage): Declare
6838         destructor.
6839         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6840         New.
6841         (get_objfile_bfd_data): Use new.  Don't initialize
6842         language_of_main.
6843         (free_objfile_per_bfd_storage): Remove.
6844         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6845
6846 2019-03-15  Tom Tromey  <tom@tromey.com>
6847
6848         * symfile.c (reread_symbols): Update.
6849         * objfiles.c (objfile::objfile): Update.
6850         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6851         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6852         comment.
6853         (minimal_symbol_reader::install): Update.
6854         (terminate_minimal_symbol_table): Remove.
6855         * jit.c (jit_object_close_impl): Update.
6856
6857 2019-03-15  Tom Tromey  <tom@tromey.com>
6858
6859         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6860         initializations.
6861
6862 2019-03-15  Tom Tromey  <tom@tromey.com>
6863
6864         * objfiles.h (struct objfile_per_bfd_storage)
6865         <demangled_hash_languages>: Now a bitset.
6866         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6867         (lookup_minimal_symbol): Update.
6868
6869 2019-03-15  Tom Tromey  <tom@tromey.com>
6870
6871         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6872         Don't return the symbol.
6873         * coffread.c (record_minimal_symbol): Use record_full.
6874
6875 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6876
6877         The MS-Windows port of ncurses fails to switch to a color pair if
6878         one or both of the colors are the implicit default colors.  This
6879         change records the default colors when TUI is initialized, and
6880         then specifies them explicitly when a color pair uses the default
6881         colors.  This allows color styling in TUI mode on MS-Windows.
6882
6883         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6884         ncurses_norm_attr.
6885         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6886         colors in ncurses_norm_attr.
6887         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6888         "none", replace it with the default color recorded in
6889         ncurses_norm_attr.
6890
6891 2019-03-14  Tom Tromey  <tromey@adacore.com>
6892
6893         * source-cache.h (class source_cache) <get_source_lines>: Return
6894         std::string.
6895         * source-cache.c (source_cache::extract_lines): Handle case where
6896         first_pos==npos.  Return std::string.
6897         (source_cache::get_source_lines): Update.
6898
6899 2019-03-14  Tom Tromey  <tromey@adacore.com>
6900
6901         * NEWS: Add item for "style sources" commands.
6902         * source-cache.c (source_cache::get_source_lines): Check
6903         source_styling.
6904         * cli/cli-style.c (source_styling): New global.
6905         (_initialize_cli_style): Add "style sources" commands.
6906         (show_style_sources): New function.
6907         * cli/cli-style.h (source_styling): Declare.
6908
6909 2019-03-14  Pedro Alves  <palves@redhat.com>
6910             Tom Tromey  <tromey@adacore.com>
6911
6912         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6913         * tui/tui-winsource.c (tui_refill_source_window): New function,
6914         from...
6915         (tui_horizontal_source_scroll): ... here.  Move some logic.
6916         * cli/cli-style.c (set_style_enabled): Notify new observable.
6917         * tui/tui-hooks.c (tui_redisplay_source): New function.
6918         (tui_attach_detach_observers): Attach or detach
6919         tui_redisplay_source.
6920         * observable.h (source_styling_changed): New observable.
6921         * observable.c: Define source_styling_changed observable.
6922
6923 2019-03-13  Tom Tromey  <tromey@adacore.com>
6924
6925         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6926         (i386_gnu_nat_target::store_registers): Update.
6927         * target-debug.h (target_debug_print_std_string): New macro.
6928         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6929         * windows-tdep.c (display_one_tib): Update.
6930         * tui/tui-stack.c (tui_make_status_line): Update.
6931         * top.c (print_inferior_quit_action): Update.
6932         * thread.c (thr_try_catch_cmd): Update.
6933         (add_thread_with_info): Update.
6934         (thread_target_id_str): Update.
6935         (thr_try_catch_cmd): Update.
6936         (thread_command): Update.
6937         (thread_find_command): Update.
6938         * record-btrace.c (record_btrace_target::info_record)
6939         (record_btrace_resume_thread, record_btrace_target::resume)
6940         (record_btrace_cancel_resume, record_btrace_step_thread)
6941         (record_btrace_target::wait, record_btrace_target::wait)
6942         (record_btrace_target::wait, record_btrace_target::stop): Update.
6943         * progspace.c (print_program_space): Update.
6944         * process-stratum-target.c
6945         (process_stratum_target::thread_address_space): Update.
6946         * linux-fork.c (linux_fork_mourn_inferior)
6947         (detach_checkpoint_command, info_checkpoints_command)
6948         (linux_fork_context): Update.
6949         (linux_fork_detach): Update.
6950         (class scoped_switch_fork_info): Update.
6951         (delete_checkpoint_command): Update.
6952         * infrun.c (follow_fork_inferior): Update.
6953         (follow_fork_inferior): Update.
6954         (proceed_after_vfork_done): Update.
6955         (handle_vfork_child_exec_or_exit): Update.
6956         (follow_exec): Update.
6957         (displaced_step_prepare_throw): Update.
6958         (displaced_step_restore): Update.
6959         (start_step_over): Update.
6960         (resume_1): Update.
6961         (clear_proceed_status_thread): Update.
6962         (proceed): Update.
6963         (print_target_wait_results): Update.
6964         (do_target_wait): Update.
6965         (context_switch): Update.
6966         (stop_all_threads): Update.
6967         (restart_threads): Update.
6968         (finish_step_over): Update.
6969         (handle_signal_stop): Update.
6970         (switch_back_to_stepped_thread): Update.
6971         (keep_going_pass_signal): Update.
6972         (print_exited_reason): Update.
6973         (normal_stop): Update.
6974         * inferior.c (inferior_pid_to_str): Change return type.
6975         (print_selected_inferior): Update.
6976         (add_inferior): Update.
6977         (detach_inferior): Update.
6978         * dummy-frame.c (fprint_dummy_frames): Update.
6979         * dcache.c (dcache_info_1): Update.
6980         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6981         (btrace_fetch, btrace_clear): Update.
6982         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6983         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6984         type.
6985         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6986         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6987         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6988         * gdbarch.c, gdbarch.h: Rebuild.
6989         * gdbarch.sh (core_pid_to_str): Change return type.
6990         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6991         return type.
6992         (windows_nat_target::pid_to_str): Change return type.
6993         (windows_delete_thread): Update.
6994         (windows_nat_target::attach): Update.
6995         (windows_nat_target::files_info): Update.
6996         * target-delegates.c: Rebuild.
6997         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6998         return type.
6999         (sol_thread_target::pid_to_str): Change return type.
7000         * remote.c (class remote_target) <pid_to_str>: Change return
7001         type.
7002         (remote_target::pid_to_str): Change return type.
7003         (extended_remote_target::attach, remote_target::remote_stop_ns)
7004         (remote_target::remote_notif_remove_queued_reply)
7005         (remote_target::push_stop_reply, remote_target::disable_btrace):
7006         Update.
7007         (extended_remote_target::attach): Update.
7008         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7009         type.
7010         (gdbsim_target::pid_to_str): Change return type.
7011         * ravenscar-thread.c (struct ravenscar_thread_target)
7012         <pid_to_str>: Change return type.
7013         (ravenscar_thread_target::pid_to_str): Change return type.
7014         * procfs.c (class procfs_target) <pid_to_str>: Change return
7015         type.
7016         (procfs_target::pid_to_str): Change return type.
7017         (procfs_target::attach): Update.
7018         (procfs_target::detach): Update.
7019         (procfs_target::fetch_registers): Update.
7020         (procfs_target::store_registers): Update.
7021         (procfs_target::wait): Update.
7022         (procfs_target::files_info): Update.
7023         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7024         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7025         return type.
7026         (nto_procfs_target::pid_to_str): Change return type.
7027         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7028         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7029         return type.
7030         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7031         (exit_lwp): Update.
7032         (attach_proc_task_lwp_callback, get_detach_signal)
7033         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7034         (linux_nat_target::resume, wait_lwp, stop_callback)
7035         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7036         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7037         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7038         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7039         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7040         type.
7041         (inf_ptrace_target::attach): Update.
7042         (inf_ptrace_target::files_info): Update.
7043         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7044         type.
7045         (go32_nat_target::pid_to_str): Change return type.
7046         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7047         (gnu_nat_target::wait): Update.
7048         (gnu_nat_target::wait): Update.
7049         (gnu_nat_target::resume): Update.
7050         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7051         (fbsd_nat_target::wait): Update.
7052         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7053         type.
7054         (darwin_nat_target::attach): Update.
7055         * corelow.c (class core_target) <pid_to_str>: Change return type.
7056         (core_target::pid_to_str): Change return type.
7057         * target.c (normal_pid_to_str): Change return type.
7058         (default_pid_to_str): Likewise.
7059         (target_pid_to_str): Change return type.
7060         (target_translate_tls_address): Update.
7061         (target_announce_detach): Update.
7062         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7063         return type.
7064         (bsd_uthread_target::pid_to_str): Change return type.
7065         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7066         type.
7067         (bsd_kvm_target::pid_to_str): Change return type.
7068         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7069         return type.
7070         (aix_thread_target::pid_to_str): Change return type.
7071         * target.h (struct target_ops) <pid_to_str>: Change return type.
7072         (target_pid_to_str, normal_pid_to_str): Likewise.
7073         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7074         type.
7075         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7076         type.
7077         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7078         return type.
7079         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7080         type.
7081         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7082         type.
7083         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7084         return type.
7085
7086 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7087
7088         * NEWS: Mention that the new default MI version is 3.  Mention
7089         changes to the output of commands and events that deal with
7090         multi-location breakpoints.
7091         * breakpoint.c: Include "mi/mi-out.h".
7092         (print_one_breakpoint): Change output syntax if using MI version
7093         >= 3.
7094         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7095         New.
7096         (mi_multi_location_breakpoint_output_fixed): New.
7097         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7098         (mi_cmd_fix_multi_location_breakpoint_output): New.
7099         (mi_multi_location_breakpoint_output_fixed): New.
7100         * mi/mi-cmds.c (mi_cmds): Register command
7101         -fix-multi-location-breakpoint-output.
7102         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7103         interpreter "mi".
7104
7105 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7106
7107         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7108         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7109         instantiate mi_ui_out based on interpreter name.
7110         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7111         * mi/mi-main.c (mi_load_progress): Likewise.
7112
7113 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7114
7115         * NEWS: Combine separate "New targets" sections for 8.3.
7116
7117 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7118
7119         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7120         (ppcfbsd_init_abi): Install gdbarch
7121         "fetch_tls_load_module_address" and "get_thread_local_address"
7122         methods.
7123
7124 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7125
7126         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7127         (riscv_fbsd_init_abi): Install gdbarch
7128         "fetch_tls_load_module_address" and "get_thread_local_address"
7129         methods.
7130
7131 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7132
7133         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7134         (i386fbsd_init_abi): Install gdbarch
7135         "fetch_tls_load_module_address" and "get_thread_local_address"
7136         methods.
7137
7138 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7139
7140         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7141         (amd64fbsd_init_abi): Install gdbarch
7142         "fetch_tls_load_module_address" and "get_thread_local_address"
7143         methods.
7144
7145 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7146
7147         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7148         (struct fbsd_pspace_data): New type.
7149         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7150         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7151         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7152         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7153         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7154
7155 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7156
7157         * gdbtypes.c (lookup_struct_elt): New function.
7158         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7159         * gdbtypes.h (struct struct_elt): New type.
7160         (lookup_struct_elt): New prototype.
7161
7162 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7163
7164         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7165         remove disabled code block.
7166
7167 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7168
7169         * gdbarch.sh (get_thread_local_address): New method.
7170         * gdbarch.h, gdbarch.c: Regenerate.
7171         * target.c (target_translate_tls_address): Use
7172         gdbarch_get_thread_local_address if present instead of
7173         target::get_thread_local_address.
7174
7175 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7176
7177         * target.h (target::get_thread_local_address): Update comment.
7178
7179 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7180
7181         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7182         objfile->separate_debug_objfile_backlink if not NULL.
7183
7184 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7185
7186         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7187         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7188         (amd64bsd_store_inferior_registers): Likewise.
7189         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7190         Enable segment base registers.
7191         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7192         PT_GETFSBASE and PT_GETGSBASE.
7193         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7194         PT_SETGSBASE.
7195         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7196         segment base registers.
7197         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7198
7199 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7200
7201         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7202         Update calls to i386_target_description to add 'segments'
7203         parameter.
7204         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7205         add segment base registers.
7206         * arch/i386.c (i386_create_target_description): Add 'segments'
7207         parameter to enable segment base registers.
7208         * arch/i386.h (i386_create_target_description): Likewise.
7209         * features/i386/32bit-segments.xml: New file.
7210         * features/i386/32bit-segments.c: Generate.
7211         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7212         call to i386_target_description to add 'segments' parameter.
7213         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7214         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7215         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7216         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7217         if feature is present.
7218         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7219         Add 'segments' parameter to call to i386_target_description.
7220         (i386_target_description): Add 'segments' parameter to enable
7221         segment base registers.
7222         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7223         to call to i386_target_description.
7224         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7225         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7226         Define I386_NUM_REGS.
7227         (i386_target_description): Add 'segments' parameter to enable
7228         segment base registers.
7229
7230 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7231
7232         PR/24325
7233         * source-cache.c: #undef open and close, to avoid unresolved
7234         externals during linking.
7235
7236 2019-03-12  Tom Tromey  <tromey@adacore.com>
7237
7238         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7239         const.  Add initializers.
7240         (_initialize_remote): Don't initialize ptid globals.
7241
7242 2019-03-12  Pedro Alves  <palves@redhat.com>
7243
7244         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7245
7246 2019-03-12  Pedro Alves  <palves@redhat.com>
7247
7248         * cp-name-parser.y (main): Remove unused 'len' variable.
7249
7250 2019-03-12  Tom Tromey  <tromey@adacore.com>
7251
7252         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7253         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7254
7255 2019-03-12  Tom Tromey  <tromey@adacore.com>
7256
7257         * linux-nat.c (iterate_over_lwps): Update.
7258         (stop_callback): Remove parameter.
7259         (stop_wait_callback, detach_callback, resume_set_callback)
7260         (select_singlestep_lwp_callback, set_ignore_sigint)
7261         (status_callback, resumed_callback, resume_clear_callback)
7262         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7263         data parameter.
7264         (linux_nat_target::detach, linux_nat_target::resume)
7265         (linux_stop_and_wait_all_lwps, select_event_lwp)
7266         (linux_nat_filter_event, linux_nat_wait_1)
7267         (linux_nat_target::kill, linux_nat_target::stop)
7268         (linux_nat_target::stop): Update.
7269         (linux_nat_resume_callback): Change type.
7270         (resume_stopped_resumed_lwps, count_events_callback)
7271         (select_event_lwp_callback): Likewise.
7272         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7273         * arm-linux-nat.c (struct update_registers_data): Remove.
7274         (update_registers_callback): Change type.
7275         (arm_linux_insert_hw_breakpoint1): Update.
7276         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7277         parameter.
7278         (x86_linux_dr_set_addr): Update.
7279         (x86_linux_dr_set_control): Update.
7280         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7281         (iterate_over_lwps): Use gdb::function_view.
7282         * nat/aarch64-linux-hw-point.c (struct
7283         aarch64_dr_update_callback_param): Remove.
7284         (debug_reg_change_callback): Change type.
7285         (aarch64_notify_debug_reg_change): Update.
7286         * s390-linux-nat.c (s390_refresh_per_info): Update.
7287
7288 2019-03-11  Tom Tromey  <tromey@adacore.com>
7289
7290         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7291         redundant assignment to "this_cu".
7292
7293 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7294
7295         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7296
7297 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7298
7299         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7300         from...
7301         (rank_one_type): ... this.
7302
7303 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7304
7305         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7306         from...
7307         (rank_one_type): ... this.
7308
7309 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7310
7311         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7312         from...
7313         (rank_one_type): ... this.
7314
7315 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7316
7317         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7318         from...
7319         (rank_one_type): ... this.
7320
7321 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7322
7323         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7324         from...
7325         (rank_one_type): ... this.
7326
7327 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7328
7329         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7330         from...
7331         (rank_one_type): ... this.
7332
7333 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7334
7335         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7336         from...
7337         (rank_one_type): ... this.
7338
7339 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7340
7341         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7342         from...
7343         (rank_one_type): ... this.
7344
7345 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7346
7347         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7348         from...
7349         (rank_one_type): ... this.
7350
7351 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7352
7353         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7354         from...
7355         (rank_one_type): ... this.
7356
7357 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7358
7359         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7360         from...
7361         (rank_one_type): ... this.
7362
7363 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7364
7365         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7366         from...
7367         (rank_one_type): ... this.
7368
7369 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7370
7371         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7372         inferior-events' shows the example events.
7373
7374 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7375
7376         Support styling on native MS-Windows console
7377
7378         PR/24315
7379         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7380         on MS-Windows if $TERM is not defined.
7381
7382         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7383
7384         * posix-hdep.c (gdb_console_fputs):
7385         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7386         functions.
7387         * ui-file.h (gdb_console_fputs): Add prototype.
7388
7389         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7390         back to fputs only if the former returns zero.
7391
7392 2019-03-07  Tom Tromey  <tom@tromey.com>
7393
7394         * symmisc.c (print_symbol_bcache_statistics): Update.
7395         (print_objfile_statistics): Update.
7396         * symfile.c (allocate_symtab): Update.
7397         * stabsread.c: Don't include bcache.h.
7398         * psymtab.h (struct psymbol_bcache): Don't declare.
7399         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7400         (psymbol_bcache_init, psymbol_bcache_free)
7401         (psymbol_bcache_get_bcache): Don't declare.
7402         * psymtab.c (struct psymbol_bcache): Remove.
7403         (psymtab_storage::psymtab_storage): Update.
7404         (psymtab_storage::~psymtab_storage): Update.
7405         (psymbol_bcache_init, psymbol_bcache_free)
7406         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7407         (add_psymbol_to_bcache): Update.
7408         (allocate_psymtab): Update.
7409         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7410         macro_cache>: No longer pointers.
7411         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7412         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7413         * macrotab.c (macro_bcache): Update.
7414         * macroexp.c: Don't include bcache.h.
7415         * gdbtypes.c (check_types_worklist): Update.
7416         (types_deeply_equal): Remove TRY/CATCH.  Update.
7417         * elfread.c (elf_symtab_read): Update.
7418         * dwarf2read.c: Don't include bcache.h.
7419         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7420         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7421         (print_bcache_statistics, bcache_memory_used): Don't declare.
7422         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7423         methods.  Rename all data members.
7424         * bcache.c (struct bcache): Move to bcache.h.
7425         (bcache::expand_hash_table): Rename from expand_hash_table.
7426         (bcache): Remove.
7427         (bcache::insert): Rename from bcache_full.
7428         (bcache::compare): Rename from bcache_compare.
7429         (bcache_xmalloc): Remove.
7430         (bcache::~bcache): Rename from bcache_xfree.
7431         (bcache::print_statistics): Rename from print_bcache_statistics.
7432         (bcache::memory_used): Rename from bcache_memory_used.
7433
7434 2019-03-07  Pedro Alves  <palves@redhat.com>
7435
7436         * infrun.c (normal_stop): Also check for
7437         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7438
7439 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7440
7441         * f-lang.c (value_from_host_double): Moved to...
7442         * value.c (value_from_host_double): ...here.
7443         * value.h (value_from_host_double): Declare.
7444         * guile/scm-math.c (vlscm_convert_typed_number): Use
7445         value_from_host_double.
7446         (vlscm_convert_number): Likewise.
7447         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7448         * python/py-value.c (convert_value_from_python): Likewise.
7449
7450 2019-03-06  Tom Tromey  <tom@tromey.com>
7451
7452         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7453
7454 2019-03-06  Tom Tromey  <tom@tromey.com>
7455
7456         * utils.h (free_current_contents): Don't declare.
7457         * utils.c (free_current_contents): Remove.
7458
7459 2019-03-06  Tom Tromey  <tom@tromey.com>
7460
7461         * top.c (quit_force): Update.
7462         * main.c (captured_command_loop): Update.
7463         * common/new-op.c (operator new): Update.
7464         * common/common-exceptions.c (struct catcher)
7465         <save_cleanup_chain>: Remove member.
7466         (exceptions_state_mc_init): Update.
7467         (exception_try_scope_entry): Return nullptr.
7468         (exception_try_scope_exit, exception_rethrow)
7469         (throw_exception_sjlj, throw_exception_cxx): Update.
7470         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7471         (all_cleanups, do_cleanups, discard_cleanups)
7472         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7473         (restore_cleanups, restore_final_cleanups): Don't declare.
7474         (do_final_cleanups): Remove parameter.
7475         * common/cleanups.c (cleanup_chain, make_cleanup)
7476         (make_cleanup_dtor, all_cleanups, do_cleanups)
7477         (discard_my_cleanups, discard_cleanups)
7478         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7479         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7480         (null_cleanup): Remove.
7481         (do_final_cleanups): Remove parameter.
7482
7483 2019-03-06  Tom Tromey  <tom@tromey.com>
7484
7485         * remote.c (remote_target::remote_parse_stop_reply): Use
7486         unique_xmalloc_ptr.
7487
7488 2019-03-06  Tom Tromey  <tom@tromey.com>
7489
7490         * stabsread.c (struct stabs_field_info): Rename from field_info.
7491         <list, fnlist>: Add initializers.
7492         <obstack>: New member.
7493         (read_member_functions, read_struct_fields, read_baseclasses):
7494         Allocate on obstack.  Don't use cleanups.
7495         (read_one_struct_field, read_member_functions, read_struct_fields)
7496         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7497         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7498         (read_struct_type): Update.
7499
7500 2019-03-06  Tom Tromey  <tom@tromey.com>
7501
7502         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7503         * common/filestuff.h (make_cleanup_close): Don't declare.
7504         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7505         Remove.
7506
7507 2019-03-06  Tom Tromey  <tom@tromey.com>
7508
7509         * solib-aix.c: Use make_scope_exit.
7510
7511 2019-03-06  Tom Tromey  <tom@tromey.com>
7512
7513         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7514         Use make_scope_exit.
7515
7516 2019-03-06  Tom Tromey  <tom@tromey.com>
7517
7518         * solib-svr4.c (disable_probes_interface): Remove parameter.
7519         (svr4_handle_solib_event): Use make_scope_exit.
7520
7521 2019-03-06  Tom Tromey  <tom@tromey.com>
7522
7523         * remote.c (struct stop_reply_deleter): Remove.
7524         (stop_reply_up): Update.
7525         (struct stop_reply): Derive from notif_event.  Don't typedef.
7526         <regcache>: Now a std::vector.
7527         (stop_reply_xfree): Remove.
7528         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7529         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7530         (remote_target::discard_pending_stop_replies): Use delete.
7531         (remote_target::remote_parse_stop_reply): Update.
7532         (remote_target::process_stop_reply): Update.
7533         * remote-notif.h (struct notif_event): Add virtual destructor.
7534         Remove "dtr" member.
7535         (struct notif_client) <alloc_event>: Return a unique_ptr.
7536         (notif_event_xfree): Don't declare.
7537         (notif_event_up): New typedef.
7538         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7539         (notif_event_xfree, do_notif_event_xfree): Remove.
7540         (remote_notif_state_xfree): Update.
7541
7542 2019-03-06  Tom Tromey  <tom@tromey.com>
7543
7544         * infrun.c (displaced_step_clear_cleanup): Now a
7545         forward_scope_exit type.
7546         (displaced_step_prepare_throw): Update.
7547         (displaced_step_fixup): Update.
7548
7549 2019-03-06  Tom Tromey  <tom@tromey.com>
7550
7551         * inferior.h (class inferior): Update comment.
7552         * gdbthread.h (class thread_info): Update comment.
7553
7554 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7555             Tom Tromey  <tom@tromey.com>
7556
7557         * stabsread.h (struct stab_section_list): Remove.
7558         (coffstab_build_psymtabs): Update.
7559         * dbxread.c (symbuf_sections): Now a std::vector.
7560         (sect_idx): New global.
7561         (fill_symbuf): Update.
7562         (coffstab_build_psymtabs): Change type of stabsects parameter.
7563         Update.
7564         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7565         std::vector.
7566         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7567         (coff_locate_sections): Update.
7568         (coff_symfile_read): Remove cleanups.  Update.
7569         (init_stringtab): Add storage parameter.
7570         (free_stringtab, free_stringtab_cleanup): Remove.
7571         (init_lineno): Add storage parameter.
7572         (free_linetab, free_linetab_cleanup): Remove.
7573
7574 2019-03-06  Pedro Alves  <palves@redhat.com>
7575
7576         * linux-fork.c (fork_info::clobber_regs): Delete.
7577         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7578         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7579         comment.  Adjust.
7580         (scoped_switch_fork_info::scoped_switch_fork_info)
7581         (checkpoint_command, linux_fork_context): Adjust
7582         fork_save_infrun_state calls.
7583
7584 2019-03-06  Pedro Alves  <palves@redhat.com>
7585
7586         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7587         (inf_has_multiple_threads): Return 'bool' and rewrite using
7588         inferior_info::threads().
7589
7590 2019-03-06  Pedro Alves  <palves@redhat.com>
7591
7592         * linux-fork.c: Include <list>.
7593         (fork_list): Now a std::list instance.
7594         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7595         (forks_exist_p, find_last_fork): Adjust.
7596         (new_fork): Delete.
7597         (one_fork_p): New.
7598         (add_fork): Adjust.
7599         (free_fork): Delete, folded into fork_info::~fork_info().
7600         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7601         Adjust.
7602         (init_fork_list): Delete.
7603         (linux_fork_killall, linux_fork_mourn_inferior)
7604         (linux_fork_detach, info_checkpoints_command): Adjust.
7605         (_initialize_linux_fork): No longer call init_fork_list.
7606
7607 2019-03-06  Pedro Alves  <palves@redhat.com>
7608
7609         * linux-fork.c (new_fork): New, split out of ...
7610         (add_fork): ... this.  Return void.  Move "first fork" special
7611         case from here, to ...
7612         (checkpoint_command): ... here.
7613         * linux-linux.h (add_fork): Return void.
7614
7615 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7616
7617         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7618
7619 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7620             Chris January  <chris.january@arm.com>
7621             David Lecomber  <david.lecomber@arm.com>
7622
7623         * f-exp.y: New token, UNOP_INTRINSIC.
7624         (exp): New pattern using UNOP_INTRINSIC token.
7625         (f77_keywords): Add 'abs' keyword.
7626         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7627         (value_from_host_double): New function.
7628         (evaluate_subexp_f): Support UNOP_ABS.
7629
7630 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7631
7632         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7633         types.
7634
7635 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7636
7637         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7638         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7639         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7640
7641 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7642
7643         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7644
7645 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7646             Chris January  <chris.january@arm.com>
7647
7648         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7649         * f-exp.y: Define 'KIND' token.
7650         (exp): New pattern for KIND expressions.
7651         (ptype): Handle types with a kind extension.
7652         (direct_abs_decl): Extend to spot kind extensions.
7653         (f77_keywords): Add 'kind' to the list.
7654         (push_kind_type): New function.
7655         (convert_to_kind_type): New function.
7656         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7657         * parse.c (operator_length_standard): Likewise.
7658         * parser-defs.h (enum type_pieces): Add tp_kind.
7659         * std-operator.def: Add UNOP_KIND.
7660
7661 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7662
7663         * f-exp.y (f_parse): Set yydebug.
7664
7665 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7666
7667         * f-lang.c (evaluate_subexp_f): New function.
7668         (exp_descriptor_f): New global.
7669         (f_language_defn): Use exp_descriptor_f instead of
7670         exp_descriptor_standard.
7671
7672 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7673
7674         * f-exp.y (struct token): Add comments.
7675         (dot_ops): Remove uppercase versions and the end marker.
7676         (f77_keywords): Likewise.
7677         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7678         entries in the dot_ops array are case insensitive, and use
7679         strncasecmp to compare strings.  Also some whitespace cleanup in
7680         this area.  Similar for the f77_keywords array, except entries in
7681         this list might be case sensitive.
7682
7683 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7684
7685         * f-exp.y (struct f77_boolean_val): Add comments.
7686         (boolean_values): Remove uppercase versions, and end marker.
7687         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7688         and use strncasecmp to achieve case insensitivity.  Additionally,
7689         perform whitespace cleanup around this code.
7690
7691 2019-03-06  Tom Tromey  <tromey@adacore.com>
7692
7693         * remote-sim.c (gdbsim_target_open): Use result of
7694         gdb_argv::release.
7695
7696 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7697         Dirk Schubert  <dirk.schubert@arm.com>
7698         Chris January  <chris.january@arm.com>
7699
7700         * eval.c (evaluate_subexp_standard): Call Fortran argument
7701         wrapping logic.
7702         * f-lang.c (struct value): A value which can be passed into a
7703         Fortran function call.
7704         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7705         where appropriate.
7706         (struct type): Value ready for a Fortran function call.
7707         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7708         is needed.
7709         * f-lang.h (fortran_argument_convert): Declaration.
7710         (fortran_preserve_arg_pointer): Declaration.
7711         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7712
7713 2019-03-05  Tom Tromey  <tromey@adacore.com>
7714
7715         * python/py-prettyprint.c (print_string_repr): Remove #if.
7716         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7717
7718 2019-03-05  Tom Tromey  <tromey@adacore.com>
7719
7720         * target.c (the_dummy_target): Move later.  Change type to
7721         "dummy_target".
7722         (initialize_targets): Don't initialize the_dummy_target.
7723
7724 2019-03-05  Tom Tromey  <tromey@adacore.com>
7725
7726         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7727         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7728
7729 2019-03-05  Tom Tromey  <tromey@adacore.com>
7730
7731         * windows-nat.c (windows_nat_target::attach)
7732         (windows_nat_target::detach): Don't call gdb_flush.
7733         * valprint.c (generic_val_print, val_print, val_print_string):
7734         Don't call gdb_flush.
7735         * utils.c (defaulted_query): Don't call gdb_flush.
7736         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7737         * target.c (target_announce_detach): Don't call gdb_flush.
7738         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7739         * remote.c (extended_remote_target::attach): Don't call
7740         gdb_flush.
7741         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7742         * printcmd.c (do_examine): Don't call gdb_flush.
7743         (info_display_command): Don't call gdb_flush.
7744         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7745         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7746         * memattr.c (info_mem_command): Don't call gdb_flush.
7747         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7748         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7749         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7750         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7751         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7752         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7753         (gnu_nat_target::detach): Don't call gdb_flush.
7754         * f-valprint.c (f_val_print): Don't call gdb_flush.
7755         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7756         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7757         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7758         gdb_flush.
7759         * c-valprint.c (c_val_print): Don't call gdb_flush.
7760         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7761
7762 2019-03-05  Tom Tromey  <tromey@adacore.com>
7763
7764         * varobj.c (update_dynamic_varobj_children): Update.
7765         (install_default_visualizer): Use reset, not release.
7766         * value.c (set_internalvar): Update.
7767         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7768         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7769         ATTRIBUTE_UNUSED_RESULT.
7770
7771 2019-03-05  Tom Tromey  <tromey@adacore.com>
7772
7773         * remote.c (class scoped_remote_fd) <release>: Add
7774         ATTRIBUTE_UNUSED_RESULT.
7775
7776 2019-03-05  Tom Tromey  <tromey@adacore.com>
7777
7778         * macroexp.c (struct macro_buffer) <release>: Add
7779         ATTRIBUTE_UNUSED_RESULT.
7780
7781 2019-03-05  Tom Tromey  <tromey@adacore.com>
7782
7783         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7784         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7785         ATTRIBUTE_UNUSED_RESULT.
7786
7787 2019-03-05  Tom Tromey  <tromey@adacore.com>
7788
7789         * common/scoped_fd.h (class scoped_fd) <release>: Add
7790         ATTRIBUTE_UNUSED_RESULT.
7791
7792 2019-03-05  Tom Tromey  <tromey@adacore.com>
7793
7794         * parser-defs.h (struct parser_state) <release>: Add
7795         ATTRIBUTE_UNUSED_RESULT.
7796
7797 2019-03-05  Tom Tromey  <tromey@adacore.com>
7798
7799         * utils.h (class gdb_argv) <release>: Add
7800         ATTRIBUTE_UNUSED_RESULT.
7801         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7802
7803 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7804
7805         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7806         for-loop range, to avoid compiler warnings.
7807
7808         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7809         avoid compiler warnings about unused variables.
7810
7811         * NEWS: Mention end of support for native debugging on MS-Windows
7812         before XP.
7813
7814         PR gdb/24292
7815         * common/netstuff.c:
7816         * gdbserver/gdbreplay.c
7817         * gdbserver/remote-utils.c:
7818         * ser-tcp.c:
7819         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7820         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7821         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7822         'getaddrinfo' and 'freeaddrinfo' were not available before
7823         Windows XP, and mingw.org's MinGW headers by default define
7824         _WIN32_WINNT to 0x500.
7825
7826 2019-03-01  Gary Benson <gbenson@redhat.com>
7827
7828         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7829
7830 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7831             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7832
7833         PR gdb/8527
7834         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7835         set_sigint_trap, clear_sigint_trap.
7836
7837 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7838
7839         * target.c (target_detach): Clear the regcache and the
7840         frame cache.
7841
7842 2019-02-27  Pedro Alves  <palves@redhat.com>
7843
7844         * utils.c (set_screen_size): When we cap the height/width sizes,
7845         tweak the corresponding command variable to show "unlimited":
7846
7847 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7848             Pedro Alves  <palves@redhat.com>
7849
7850         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7851         before calling rl_set_screen_size.
7852
7853 2019-02-27  Tom Tromey  <tromey@adacore.com>
7854
7855         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7856         define.
7857         * python/py-value.c: Remove Python 2.4 workaround.
7858         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7859         workaround.
7860         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7861         Python 2.4 workaround.
7862         * python/python-internal.h: Remove Python 2.4 comment.
7863         (Py_ssize_t): Don't define.
7864         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7865         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7866         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7867         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7868         * python/python.c (do_start_initialization): Remove Python 2.4
7869         workaround.
7870         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7871         (print_children): Remove Python 2.4 workaround.
7872         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7873         workaround.
7874         (CHARBUFFERPROC_NAME): Remove.
7875         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7876         Python 2.4 workaround.
7877
7878 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7879
7880         * NEWS: Note minimum Python version.
7881
7882 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7883
7884         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7885         code from these functions.  Remove corresponding ifdefs.  Use
7886         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7887         Remove gotos and target of gotos.
7888         (infpy_search_memory): Likewise.
7889
7890 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7891
7892         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7893         (hppa_gdbarch_init): Don't register deleted functions with
7894         gdbarch.
7895
7896 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7897
7898         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7899         (h8300_unwind_sp): Delete.
7900         (h8300_dummy_id): Delete.
7901         (h8300_gdbarch_init): Don't register deleted functions with
7902         gdbarch.
7903
7904 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7905
7906         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7907         (ft32_unwind_pc): Delete.
7908         (ft32_unwind_sp): Delete.
7909         (ft32_gdbarch_init): Don't register deleted functions with
7910         gdbarch.
7911
7912 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7913
7914         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7915         (frv_unwind_pc): Delete.
7916         (frv_unwind_sp): Delete.
7917         (frv_gdbarch_init): Don't register deleted functions with
7918         gdbarch.
7919
7920 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7921
7922         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7923         (riscv_unwind_pc): Delete.
7924         (riscv_unwind_sp): Delete.
7925         (riscv_gdbarch_init): Don't register deleted functions with
7926         gdbarch.
7927
7928 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7929
7930         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7931         (csky_unwind_pc): Delete.
7932         (csky_unwind_sp): Delete.
7933         (csky_gdbarch_init): Don't register deleted functions with
7934         gdbarch.
7935
7936 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7937
7938         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7939         (cris_unwind_pc): Delete.
7940         (cris_unwind_sp): Delete.
7941         (cris_gdbarch_init): Don't register deleted functions with
7942         gdbarch.
7943
7944 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7945
7946         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7947         (bfin_unwind_pc): Delete.
7948         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7949
7950 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7951
7952         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7953         (arm_unwind_pc): Delete.
7954         (arm_unwind_sp): Delete.
7955         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7956
7957 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7958
7959         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7960         (arc_unwind_pc): Delete.
7961         (arc_unwind_sp): Delete.
7962         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7963
7964 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7965
7966         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7967         (alpha_unwind_pc): Delete.
7968         (alpha_gdbarch_init): Don't register deleted functions with
7969         gdbarch.
7970
7971 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7972
7973         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7974         (aarch64_unwind_pc): Delete.
7975         (aarch64_unwind_sp): Delete.
7976         (aarch64_gdbarch_init): Don't register deleted functions with
7977         gdbarch.
7978
7979 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7980
7981         * gdbtypes.c (type_align): Don't consider static members when
7982         computing structure alignment.
7983
7984 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7985
7986         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7987         return 0 for other types.
7988         * arch-utils.c (default_type_align): Always return 0.
7989         * gdbarch.h: Regenerate.
7990         * gdbarch.sh (type_align): Extend comment.
7991         * gdbtypes.c (type_align): Add additional comments, always call
7992         gdbarch_type_align before applying the default rules.
7993         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7994         generic code will then apply a suitable default.
7995         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7996         types, return 0 for other types.
7997
7998 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7999
8000         * NEWS: Create a new section for the next release branch.
8001         Rename the section of the current branch, now that it has
8002         been cut.
8003
8004 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8005
8006         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8007         * version.in: Bump version to 8.3.50.DATE-git.
8008
8009 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8010
8011         * aix-thread.c (ptid_cmp): Remove unused variable.
8012         (get_signaled_thread): Likewise.
8013         (store_regs_user_thread): Likewise.
8014         (store_regs_kernel_thread): Likewise.
8015         (fetch_regs_kernel_thread): Remove shadowed variable.
8016
8017 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8018
8019         * features/riscv/32bit-cpu.xml: Add register numbers.
8020         * features/riscv/32bit-fpu.c: Regenerate.
8021         * features/riscv/32bit-fpu.xml: Add register numbers.
8022         * features/riscv/64bit-cpu.xml: Add register numbers.
8023         * features/riscv/64bit-fpu.c: Regenerate.
8024         * features/riscv/64bit-fpu.xml: Add register numbers.
8025
8026 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8027
8028         * NEWS: Mention two argument form of gdb.Value constructor.
8029         * python/py-value.c (convert_buffer_and_type_to_value): New
8030         function.
8031         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8032         Add support for handling an optional second argument.  Call
8033         convert_buffer_and_type_to_value as appropriate.
8034         * python/python-internal.h (Py_buffer_deleter): New struct.
8035         (Py_buffer_up): New typedef.
8036
8037 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8038
8039         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8040         instead of releasing ownership.
8041
8042 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8043
8044         * dwarf2read.c (open_and_init_dwp_file): Call
8045         elf_numsections instead of bfd_count_sections to initialize
8046         dwp_file->num_sections.
8047
8048 2019-02-25  Tom Tromey  <tromey@adacore.com>
8049
8050         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8051
8052 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8053
8054         * gcore.in: Add '--readnever' option when invoking GDB.
8055
8056 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8057
8058         * MAINTAINERS: Update my email address.
8059
8060 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8061
8062         * build-id.c (build_id_to_debug_bfd_1): New function.
8063         (build_id_to_debug_bfd): Look for separate debug file in
8064         sysroot.
8065
8066 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8067
8068         * gdbarch.sh: Update the copyright year range that is placed into
8069         generated files.
8070
8071 2019-02-22  Keith Seitz  <keiths@redhat.com>
8072
8073         PR symtab/23853
8074         * linespec.c (create_sals_line_offset): Search for the default
8075         symtab's filename instead of its fullname.
8076
8077 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8078
8079         * NEWS: Update style defaults.
8080
8081 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8082
8083         * main.c (captured_main_1): Disable styling in batch mode.
8084
8085 2019-02-20  Tom Tromey  <tom@tromey.com>
8086
8087         * symtab.c (symtab_symbol_info): Fix typos.
8088
8089 2019-02-20  Tom Tromey  <tromey@adacore.com>
8090
8091         * findcmd.c (_initialize_mem_search): Use upper case for
8092         metasyntactic variables.
8093
8094 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8095
8096         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8097         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8098
8099 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8100
8101         * top.h (source_file_name): Change to std::string.
8102         * top.c (source_file_name): Likewise.
8103         (command_line_input): Adjust.
8104         * cli/cli-script.c (script_from_file): Adjust.
8105
8106 2019-02-19  Tom Tromey  <tromey@adacore.com>
8107
8108         * ravenscar-thread.c
8109         (ravenscar_thread_target::update_thread_list): Don't call
8110         ada_build_task_list.
8111         * ada-lang.h (ada_build_task_list): Don't declare.
8112         * ada-tasks.c (struct ada_tasks_inferior_data)
8113         <task_list_valid_p>: Now bool.
8114         (read_known_tasks, ada_task_list_changed)
8115         (ada_tasks_invalidate_inferior_data): Update.
8116         (read_known_tasks_array): Return bool.
8117         (read_known_tasks_list): Likewise.
8118         (read_known_tasks): Return void.
8119         (ada_build_task_list): Now static.
8120
8121 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8122
8123         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8124         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8125
8126 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8127
8128         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8129         variant for ada_tasks_pspace_data_handle and
8130         ada_tasks_inferior_data_handle.
8131         (ada_tasks_pspace_data_cleanup): New function.
8132         (ada_tasks_inferior_data_cleanup): New function.
8133
8134 2019-02-17  Tom Tromey  <tom@tromey.com>
8135
8136         * macrotab.h (macro_source_fullname): Return a std::string.
8137         * macrotab.c (macro_include, check_for_redefinition)
8138         (macro_undef, macro_lookup_definition, foreach_macro)
8139         (foreach_macro_in_scope): Update.
8140         (macro_source_fullname): Return a std::string.
8141         * macrocmd.c (show_pp_source_pos): Update.
8142
8143 2019-02-17  Tom Tromey  <tom@tromey.com>
8144
8145         * macrocmd.c (show_pp_source_pos): Style the file names.
8146
8147 2019-02-17  Tom Tromey  <tom@tromey.com>
8148
8149         PR tui/24197:
8150         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8151
8152 2019-02-17  Tom Tromey  <tom@tromey.com>
8153
8154         * ada-lang.c (user_select_syms): Use filtered printing.
8155         * utils.c (wrap_style): New global.
8156         (desired_style): Remove.
8157         (emit_style_escape): Add stream parameter.
8158         (set_output_style, reset_terminal_style, prompt_for_continue):
8159         Update.
8160         (flush_wrap_buffer): Only flush gdb_stdout.
8161         (wrap_here): Set wrap_style.
8162         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8163         treat escape sequences as a character.  Change when wrap buffer is
8164         flushed.
8165         (fputs_styled): Do not set the output style when the default is
8166         requested.
8167         * ui-style.h (struct ui_file_style) <is_default>: New method.
8168         * source.c (print_source_lines_base): Emit escape sequences in one
8169         piece.
8170
8171 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8172
8173         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8174         integers and enumeration types.
8175
8176 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8177
8178         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8179         instead of lookup_symbol_in_language
8180         (do_exact_match): New function.
8181         (ada_get_symbol_name_matcher): Return do_exact_match when
8182         doing a verbatim match.
8183
8184 2019-02-15  Tom Tromey  <tromey@adacore.com>
8185
8186         * ravenscar-thread.c (ravenscar_thread_target::resume)
8187         (ravenscar_thread_target::wait): Special case wildcard requests.
8188
8189 2019-02-15  Tom Tromey  <tromey@adacore.com>
8190
8191         * ravenscar-thread.c (base_ptid): Remove.
8192         (struct ravenscar_thread_target) <close>: New method.
8193         <m_base_ptid>: New member.
8194         <update_inferior_ptid, active_task, task_is_currently_active,
8195         runtime_initialized>: Declare methods.
8196         <ravenscar_thread_target>: Add constructor.
8197         (ravenscar_thread_target::task_is_currently_active)
8198         (ravenscar_thread_target::update_inferior_ptid)
8199         (ravenscar_runtime_initialized): Rename.  Now methods.
8200         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8201         (ravenscar_thread_target::update_thread_list): Update.
8202         (ravenscar_thread_target::active_task): Now method.
8203         (ravenscar_thread_target::store_registers)
8204         (ravenscar_thread_target::prepare_to_store)
8205         (ravenscar_thread_target::prepare_to_store)
8206         (ravenscar_thread_target::mourn_inferior): Update.
8207         (ravenscar_inferior_created): Use "new" to create target.
8208         (ravenscar_thread_target::get_ada_task_ptid): Update.
8209         (_initialize_ravenscar): Don't initialize base_ptid.
8210         (ravenscar_ops): Remove global.
8211
8212 2019-02-15  Tom Tromey  <tromey@adacore.com>
8213
8214         * target.h (push_target): Declare new overload.
8215         * target.c (push_target): New overload, taking an rvalue reference.
8216         * remote.c (remote_target::open_1): Use push_target overload.
8217         * corelow.c (core_target_open): Use push_target overload.
8218
8219 2019-02-15  Tom Tromey  <tromey@adacore.com>
8220
8221         * ravenscar-thread.c (is_ravenscar_task)
8222         (ravenscar_task_is_currently_active): Return bool.
8223         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8224         (_initialize_ravenscar): Remove "(void)".
8225         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8226         Return bool.
8227
8228 2019-02-15  Tom Tromey  <tromey@adacore.com>
8229
8230         * ravenscar-thread.c (ravenscar_runtime_initializer)
8231         (has_ravenscar_runtime, get_running_thread_id)
8232         (ravenscar_thread_target::resume): Fix indentation.
8233
8234 2019-02-15  Tom Tromey  <tromey@adacore.com>
8235
8236         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8237         from ravenscar_arch_ops.
8238         (sparc_ravenscar_ops::fetch_registers)
8239         (sparc_ravenscar_ops::store_registers): Now methods.
8240         (sparc_ravenscar_prepare_to_store): Remove.
8241         (sparc_ravenscar_ops): Redefine.
8242         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8243         methods and destructor.  Remove members.
8244         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8245         (ravenscar_thread_target::store_registers)
8246         (ravenscar_thread_target::prepare_to_store): Update.
8247         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8248         Remove.
8249         (struct ppc_ravenscar_powerpc_ops): Derive from
8250         ravenscar_arch_ops.
8251         (ppc_ravenscar_powerpc_ops::fetch_registers)
8252         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8253         (ppc_ravenscar_powerpc_ops): Redefine.
8254         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8255         (ppc_ravenscar_e500_ops::fetch_registers)
8256         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8257         (ppc_ravenscar_e500_ops): Redefine.
8258         * aarch64-ravenscar-thread.c
8259         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8260         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8261         (aarch64_ravenscar_fetch_registers)
8262         (aarch64_ravenscar_store_registers): Now methods.
8263         (aarch64_ravenscar_ops): Redefine.
8264
8265 2019-02-15  Tom Tromey  <tromey@adacore.com>
8266
8267         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8268         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8269         (ravenscar_thread_target::stopped_by_watchpoint)
8270         (ravenscar_thread_target::stopped_data_address)
8271         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8272
8273 2019-02-15  Tom Tromey  <tromey@adacore.com>
8274
8275         * ravenscar-thread.c: Fix some typos.
8276
8277 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8278             Tom Tromey  <tromey@adacore.com>
8279
8280         * ada-lang.c (ada_exception_sal): Change addr_string to a
8281         std::string.
8282         (create_ada_exception_catchpoint): Update.
8283
8284 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8285             Tom Tromey  <tromey@adacore.com>
8286
8287         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8288         (bp_location_ops): Remove.
8289         (base_breakpoint_allocate_location): Update.
8290         (free_bp_location): Update.
8291         * ada-lang.c (class ada_catchpoint_location)
8292         <ada_catchpoint_location>: Remove ops parameter.
8293         (ada_catchpoint_location_dtor): Remove.
8294         (ada_catchpoint_location_ops): Remove.
8295         (allocate_location_exception): Update.
8296         * breakpoint.h (struct bp_location_ops): Remove.
8297         (class bp_location) <bp_location>: Remove bp_location_ops
8298         parameter.
8299         <~bp_location>: Add destructor.
8300         <ops>: Remove.
8301
8302 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8303             Pedro Alves  <palves@redhat.com>
8304
8305         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8306         'PATH_MAX'.
8307
8308 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8309             Samuel Thibault  <samuel.thibault@gnu.org>
8310             Thomas Schwinge  <thomas@codesourcery.com>
8311
8312         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8313         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8314
8315 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8316
8317         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8318         (check_empty): Use "const char *".
8319
8320         * gnu-nat.c (gnu_nat_target::detach): Instead of
8321         'detach_inferior (pid)' call
8322         'detach_inferior (find_inferior_pid (pid))'.
8323
8324         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8325         'nat/fork-inferior.o'.
8326         * gnu-nat.c: #include "nat/fork-inferior.h".
8327
8328         * gnu-nat.c (gnu_nat_target::detach): Instead of
8329         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8330         * gnu-nat.h: #include "inf-child.h".
8331         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8332         'i386_gnu_nat_target::fetch_registers'.
8333         (gnu_store_registers): Rename/move to
8334         'i386_gnu_nat_target::store_registers'.
8335
8336         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8337         * gnu-nat.h (mach_thread_info): New function.
8338         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8339
8340         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8341
8342 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8343
8344         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8345
8346 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8347
8348         * windows-nat.c (windows_add_thread): Add new parameter
8349         "main_thread_p" with default value set to false.  Update
8350         function documentation as well as all callers.
8351         (windows_delete_thread): Likewise.
8352         (fake_create_process): Update call to windows_add_thread.
8353         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8354         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8355         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8356         call to windows_delete_thread.
8357
8358 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8359
8360         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8361
8362 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8363
8364         * symfile.c (find_separate_debug_file): Use canonical path of
8365         sysroot with child_path instead of gdb_sysroot if it is valid.
8366
8367 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8368
8369         * symfile.c (find_separate_debug_file): Use child_path to
8370         determine if an object file is under a sysroot.
8371
8372 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8373
8374         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8375         unittests/child-path-selftests.c.
8376         * common/pathstuff.c (child_path): New function.
8377         * common/pathstuff.h (child_path): New prototype.
8378         * unittests/child-path-selftests.c: New file.
8379
8380 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8381
8382         * symfile.c (find_separate_debug_file): Look for separate debug
8383         files in debug directories under the sysroot.
8384
8385 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8386
8387         * symtab.h (struct minimal_symbol data_p): New const method.
8388         (struct minimal_symbol text_p): Likewise.
8389         * symtab.c (output_source_filename): Use file name style
8390         to print file name.
8391         (print_symbol_info): Likewise.
8392         (print_msymbol_info): Use address style to print addresses.
8393         Use function name style to print executable text symbols.
8394         (expand_symtab_containing_pc): Use data_p.
8395         (find_pc_sect_compunit_symtab): Likewise.
8396
8397 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8398
8399         * breakpoint.c (describe_other_breakpoints): Use address style
8400         to print addresses.
8401         (say_where): Likewise.
8402
8403 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8404
8405         * ada-typeprint.c (print_func_type): Print function name
8406         style to print function name.
8407         * c-typeprint.c (c_print_type_1): Likewise.
8408
8409 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8410
8411         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8412         for execve.
8413
8414 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8415
8416         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8417         type_stack.
8418
8419 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8420
8421         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8422         TYPE_CODE_REF types.
8423
8424 2019-02-08  Jim Wilson  <jimw@sifive.com>
8425
8426         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8427         (riscv_linux_fregset): New.
8428         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8429
8430 2019-02-07  Tom Tromey  <tom@tromey.com>
8431
8432         * thread.c (thread_cancel_execution_command): Update.
8433         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8434         methods.
8435         (struct thread_fsm_ops): Remove.
8436         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8437         (thread_fsm_should_stop, thread_fsm_return_value)
8438         (thread_fsm_set_finished, thread_fsm_finished_p)
8439         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8440         Don't declare.
8441         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8442         * infrun.c (clear_proceed_status_thread)
8443         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8444         (print_stop_event): Update.
8445         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8446         Add constructor.
8447         (step_command_fsm_ops): Remove.
8448         (new_step_command_fsm): Remove.
8449         (step_1): Update.
8450         (step_command_fsm::should_stop): Rename from
8451         step_command_fsm_should_stop.
8452         (step_command_fsm::clean_up): Rename from
8453         step_command_fsm_clean_up.
8454         (step_command_fsm::do_async_reply_reason): Rename from
8455         step_command_fsm_async_reply_reason.
8456         (struct until_next_fsm): Inherit from thread_fsm.  Add
8457         constructor.
8458         (until_next_fsm_ops): Remove.
8459         (new_until_next_fsm): Remove.
8460         (until_next_fsm::should_stop): Rename from
8461         until_next_fsm_should_stop.
8462         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8463         (until_next_fsm::do_async_reply_reason): Rename from
8464         until_next_fsm_async_reply_reason.
8465         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8466         constructor.  Change type of breakpoint.
8467         (finish_command_fsm_ops): Remove.
8468         (new_finish_command_fsm): Remove.
8469         (finish_command_fsm::should_stop): Rename from
8470         finish_command_fsm_should_stop.
8471         (finish_command_fsm::clean_up): Rename from
8472         finish_command_fsm_clean_up.
8473         (finish_command_fsm::return_value): Rename from
8474         finish_command_fsm_return_value.
8475         (finish_command_fsm::do_async_reply_reason): Rename from
8476         finish_command_fsm_async_reply_reason.
8477         (finish_command): Update.
8478         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8479         Add constructor.
8480         (call_thread_fsm_ops): Remove.
8481         (call_thread_fsm::call_thread_fsm): Rename from
8482         new_call_thread_fsm.
8483         (call_thread_fsm::should_stop): Rename from
8484         call_thread_fsm_should_stop.
8485         (call_thread_fsm::should_notify_stop): Rename from
8486         call_thread_fsm_should_notify_stop.
8487         (run_inferior_call, call_function_by_hand_dummy): Update.
8488         * cli/cli-interp.c (should_print_stop_to_console): Update.
8489         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8490         Add constructor.  Change type of location_breakpoint,
8491         caller_breakpoint.
8492         (until_break_fsm_ops): Remove.
8493         (new_until_break_fsm): Remove.
8494         (until_break_fsm::should_stop): Rename from
8495         until_break_fsm_should_stop.
8496         (until_break_fsm::clean_up): Rename from
8497         until_break_fsm_clean_up.
8498         (until_break_fsm::do_async_reply_reason): Rename from
8499         until_break_fsm_async_reply_reason.
8500         (until_break_command): Update.
8501         * thread-fsm.c: Remove.
8502         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8503
8504 2019-02-07  Tom Tromey  <tom@tromey.com>
8505
8506         * yy-remap.h: Add include guard.
8507         * xtensa-tdep.h: Add include guard.
8508         * xcoffread.h: Rename include guard.
8509         * varobj-iter.h: Add include guard.
8510         * tui/tui.h: Rename include guard.
8511         * tui/tui-winsource.h: Rename include guard.
8512         * tui/tui-wingeneral.h: Rename include guard.
8513         * tui/tui-windata.h: Rename include guard.
8514         * tui/tui-win.h: Rename include guard.
8515         * tui/tui-stack.h: Rename include guard.
8516         * tui/tui-source.h: Rename include guard.
8517         * tui/tui-regs.h: Rename include guard.
8518         * tui/tui-out.h: Rename include guard.
8519         * tui/tui-layout.h: Rename include guard.
8520         * tui/tui-io.h: Rename include guard.
8521         * tui/tui-hooks.h: Rename include guard.
8522         * tui/tui-file.h: Rename include guard.
8523         * tui/tui-disasm.h: Rename include guard.
8524         * tui/tui-data.h: Rename include guard.
8525         * tui/tui-command.h: Rename include guard.
8526         * tic6x-tdep.h: Add include guard.
8527         * target/waitstatus.h: Rename include guard.
8528         * target/wait.h: Rename include guard.
8529         * target/target.h: Rename include guard.
8530         * target/resume.h: Rename include guard.
8531         * target-float.h: Rename include guard.
8532         * stabsread.h: Add include guard.
8533         * rs6000-tdep.h: Add include guard.
8534         * riscv-fbsd-tdep.h: Add include guard.
8535         * regformats/regdef.h: Rename include guard.
8536         * record.h: Rename include guard.
8537         * python/python.h: Rename include guard.
8538         * python/python-internal.h: Rename include guard.
8539         * python/py-stopevent.h: Rename include guard.
8540         * python/py-ref.h: Rename include guard.
8541         * python/py-record.h: Rename include guard.
8542         * python/py-record-full.h: Rename include guard.
8543         * python/py-record-btrace.h: Rename include guard.
8544         * python/py-instruction.h: Rename include guard.
8545         * python/py-events.h: Rename include guard.
8546         * python/py-event.h: Rename include guard.
8547         * procfs.h: Add include guard.
8548         * proc-utils.h: Add include guard.
8549         * p-lang.h: Add include guard.
8550         * or1k-tdep.h: Rename include guard.
8551         * observable.h: Rename include guard.
8552         * nto-tdep.h: Rename include guard.
8553         * nat/x86-linux.h: Rename include guard.
8554         * nat/x86-linux-dregs.h: Rename include guard.
8555         * nat/x86-gcc-cpuid.h: Add include guard.
8556         * nat/x86-dregs.h: Rename include guard.
8557         * nat/x86-cpuid.h: Rename include guard.
8558         * nat/ppc-linux.h: Rename include guard.
8559         * nat/mips-linux-watch.h: Rename include guard.
8560         * nat/linux-waitpid.h: Rename include guard.
8561         * nat/linux-ptrace.h: Rename include guard.
8562         * nat/linux-procfs.h: Rename include guard.
8563         * nat/linux-osdata.h: Rename include guard.
8564         * nat/linux-nat.h: Rename include guard.
8565         * nat/linux-namespaces.h: Rename include guard.
8566         * nat/linux-btrace.h: Rename include guard.
8567         * nat/glibc_thread_db.h: Rename include guard.
8568         * nat/gdb_thread_db.h: Rename include guard.
8569         * nat/gdb_ptrace.h: Rename include guard.
8570         * nat/fork-inferior.h: Rename include guard.
8571         * nat/amd64-linux-siginfo.h: Rename include guard.
8572         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8573         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8574         * nat/aarch64-linux.h: Rename include guard.
8575         * nat/aarch64-linux-hw-point.h: Rename include guard.
8576         * mn10300-tdep.h: Add include guard.
8577         * mips-linux-tdep.h: Add include guard.
8578         * mi/mi-parse.h: Rename include guard.
8579         * mi/mi-out.h: Rename include guard.
8580         * mi/mi-main.h: Rename include guard.
8581         * mi/mi-interp.h: Rename include guard.
8582         * mi/mi-getopt.h: Rename include guard.
8583         * mi/mi-console.h: Rename include guard.
8584         * mi/mi-common.h: Rename include guard.
8585         * mi/mi-cmds.h: Rename include guard.
8586         * mi/mi-cmd-break.h: Rename include guard.
8587         * m2-lang.h: Add include guard.
8588         * location.h: Rename include guard.
8589         * linux-record.h: Rename include guard.
8590         * linux-nat.h: Add include guard.
8591         * linux-fork.h: Add include guard.
8592         * i386-darwin-tdep.h: Rename include guard.
8593         * hppa-linux-offsets.h: Add include guard.
8594         * guile/guile.h: Rename include guard.
8595         * guile/guile-internal.h: Rename include guard.
8596         * gnu-nat.h: Rename include guard.
8597         * gdb-stabs.h: Rename include guard.
8598         * frv-tdep.h: Add include guard.
8599         * f-lang.h: Add include guard.
8600         * event-loop.h: Add include guard.
8601         * darwin-nat.h: Rename include guard.
8602         * cp-abi.h: Rename include guard.
8603         * config/sparc/nm-sol2.h: Rename include guard.
8604         * config/nm-nto.h: Rename include guard.
8605         * config/nm-linux.h: Add include guard.
8606         * config/i386/nm-i386gnu.h: Rename include guard.
8607         * config/djgpp/nl_types.h: Rename include guard.
8608         * config/djgpp/langinfo.h: Rename include guard.
8609         * compile/gcc-cp-plugin.h: Add include guard.
8610         * compile/gcc-c-plugin.h: Add include guard.
8611         * compile/compile.h: Rename include guard.
8612         * compile/compile-object-run.h: Rename include guard.
8613         * compile/compile-object-load.h: Rename include guard.
8614         * compile/compile-internal.h: Rename include guard.
8615         * compile/compile-cplus.h: Rename include guard.
8616         * compile/compile-c.h: Rename include guard.
8617         * common/xml-utils.h: Rename include guard.
8618         * common/x86-xstate.h: Rename include guard.
8619         * common/version.h: Rename include guard.
8620         * common/vec.h: Rename include guard.
8621         * common/tdesc.h: Rename include guard.
8622         * common/selftest.h: Rename include guard.
8623         * common/scoped_restore.h: Rename include guard.
8624         * common/scoped_mmap.h: Rename include guard.
8625         * common/scoped_fd.h: Rename include guard.
8626         * common/safe-iterator.h: Rename include guard.
8627         * common/run-time-clock.h: Rename include guard.
8628         * common/refcounted-object.h: Rename include guard.
8629         * common/queue.h: Rename include guard.
8630         * common/ptid.h: Rename include guard.
8631         * common/print-utils.h: Rename include guard.
8632         * common/preprocessor.h: Rename include guard.
8633         * common/pathstuff.h: Rename include guard.
8634         * common/observable.h: Rename include guard.
8635         * common/netstuff.h: Rename include guard.
8636         * common/job-control.h: Rename include guard.
8637         * common/host-defs.h: Rename include guard.
8638         * common/gdb_wait.h: Rename include guard.
8639         * common/gdb_vecs.h: Rename include guard.
8640         * common/gdb_unlinker.h: Rename include guard.
8641         * common/gdb_unique_ptr.h: Rename include guard.
8642         * common/gdb_tilde_expand.h: Rename include guard.
8643         * common/gdb_sys_time.h: Rename include guard.
8644         * common/gdb_string_view.h: Rename include guard.
8645         * common/gdb_splay_tree.h: Rename include guard.
8646         * common/gdb_setjmp.h: Rename include guard.
8647         * common/gdb_ref_ptr.h: Rename include guard.
8648         * common/gdb_optional.h: Rename include guard.
8649         * common/gdb_locale.h: Rename include guard.
8650         * common/gdb_assert.h: Rename include guard.
8651         * common/filtered-iterator.h: Rename include guard.
8652         * common/filestuff.h: Rename include guard.
8653         * common/fileio.h: Rename include guard.
8654         * common/environ.h: Rename include guard.
8655         * common/common-utils.h: Rename include guard.
8656         * common/common-types.h: Rename include guard.
8657         * common/common-regcache.h: Rename include guard.
8658         * common/common-inferior.h: Rename include guard.
8659         * common/common-gdbthread.h: Rename include guard.
8660         * common/common-exceptions.h: Rename include guard.
8661         * common/common-defs.h: Rename include guard.
8662         * common/common-debug.h: Rename include guard.
8663         * common/cleanups.h: Rename include guard.
8664         * common/buffer.h: Rename include guard.
8665         * common/btrace-common.h: Rename include guard.
8666         * common/break-common.h: Rename include guard.
8667         * cli/cli-utils.h: Rename include guard.
8668         * cli/cli-style.h: Rename include guard.
8669         * cli/cli-setshow.h: Rename include guard.
8670         * cli/cli-script.h: Rename include guard.
8671         * cli/cli-interp.h: Rename include guard.
8672         * cli/cli-decode.h: Rename include guard.
8673         * cli/cli-cmds.h: Rename include guard.
8674         * charset-list.h: Add include guard.
8675         * buildsym-legacy.h: Rename include guard.
8676         * bfin-tdep.h: Add include guard.
8677         * ax.h: Rename include guard.
8678         * arm-linux-tdep.h: Add include guard.
8679         * arm-fbsd-tdep.h: Add include guard.
8680         * arch/xtensa.h: Rename include guard.
8681         * arch/tic6x.h: Add include guard.
8682         * arch/i386.h: Add include guard.
8683         * arch/arm.h: Rename include guard.
8684         * arch/arm-linux.h: Rename include guard.
8685         * arch/arm-get-next-pcs.h: Rename include guard.
8686         * arch/amd64.h: Add include guard.
8687         * arch/aarch64-insn.h: Rename include guard.
8688         * arch-utils.h: Rename include guard.
8689         * annotate.h: Add include guard.
8690         * amd64-darwin-tdep.h: Rename include guard.
8691         * aarch64-linux-tdep.h: Add include guard.
8692         * aarch64-fbsd-tdep.h: Add include guard.
8693         * aarch32-linux-nat.h: Add include guard.
8694
8695 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8696
8697         * macrotab.c (macro_define_internal): New function that
8698         factorizes macro_define_object_internal and macro_define_function
8699         code.
8700         (macro_define_object_internal): Use macro_define_internal.
8701         (macro_define_function): Likewise.
8702
8703 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8704
8705         * macrocmd.c (extract_identifier): Return
8706         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8707         callers.
8708
8709 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8710
8711         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8712
8713 2019-02-05  Tom Tromey  <tom@tromey.com>
8714
8715         * target.c (target_stack::unpush): Move assertion earlier.
8716
8717 2019-01-30  Tom Tromey  <tom@tromey.com>
8718
8719         PR python/23615:
8720         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8721         (gdbpy_parse_and_eval): Likewise.
8722         * python/python-internal.h (gdbpy_allow_threads): New class.
8723
8724 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8725
8726         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8727         (aarch64_fbsd_fpregmap): Move earlier.
8728         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8729         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8730         instead of individual calls to trad_frame_set_reg_addr.
8731         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8732         earlier.
8733         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8734         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8735         instead of individual calls to trad_frame_set_reg_addr.
8736
8737 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8738
8739         * CONTRIBUTE: Replace contribution list with wiki link.
8740
8741 2019-01-25  Tom Tromey  <tom@tromey.com>
8742
8743         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8744
8745 2019-01-25  Tom Tromey  <tom@tromey.com>
8746
8747         * xtensa-linux-nat.c: Fix common/ includes.
8748         * xml-support.h: Fix common/ includes.
8749         * xml-support.c: Fix common/ includes.
8750         * x86-linux-nat.c: Fix common/ includes.
8751         * windows-nat.c: Fix common/ includes.
8752         * varobj.h: Fix common/ includes.
8753         * varobj.c: Fix common/ includes.
8754         * value.c: Fix common/ includes.
8755         * valops.c: Fix common/ includes.
8756         * utils.c: Fix common/ includes.
8757         * unittests/xml-utils-selftests.c: Fix common/ includes.
8758         * unittests/utils-selftests.c: Fix common/ includes.
8759         * unittests/unpack-selftests.c: Fix common/ includes.
8760         * unittests/tracepoint-selftests.c: Fix common/ includes.
8761         * unittests/style-selftests.c: Fix common/ includes.
8762         * unittests/string_view-selftests.c: Fix common/ includes.
8763         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8764         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8765         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8766         * unittests/rsp-low-selftests.c: Fix common/ includes.
8767         * unittests/parse-connection-spec-selftests.c: Fix common/
8768         includes.
8769         * unittests/optional-selftests.c: Fix common/ includes.
8770         * unittests/offset-type-selftests.c: Fix common/ includes.
8771         * unittests/observable-selftests.c: Fix common/ includes.
8772         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8773         * unittests/memrange-selftests.c: Fix common/ includes.
8774         * unittests/memory-map-selftests.c: Fix common/ includes.
8775         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8776         * unittests/function-view-selftests.c: Fix common/ includes.
8777         * unittests/environ-selftests.c: Fix common/ includes.
8778         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8779         * unittests/common-utils-selftests.c: Fix common/ includes.
8780         * unittests/cli-utils-selftests.c: Fix common/ includes.
8781         * unittests/array-view-selftests.c: Fix common/ includes.
8782         * ui-file.c: Fix common/ includes.
8783         * tui/tui-io.c: Fix common/ includes.
8784         * tracepoint.h: Fix common/ includes.
8785         * tracepoint.c: Fix common/ includes.
8786         * tracefile-tfile.c: Fix common/ includes.
8787         * top.h: Fix common/ includes.
8788         * top.c: Fix common/ includes.
8789         * thread.c: Fix common/ includes.
8790         * target/waitstatus.h: Fix common/ includes.
8791         * target/waitstatus.c: Fix common/ includes.
8792         * target.h: Fix common/ includes.
8793         * target.c: Fix common/ includes.
8794         * target-memory.c: Fix common/ includes.
8795         * target-descriptions.c: Fix common/ includes.
8796         * symtab.h: Fix common/ includes.
8797         * symfile.c: Fix common/ includes.
8798         * stap-probe.c: Fix common/ includes.
8799         * spu-linux-nat.c: Fix common/ includes.
8800         * sparc-nat.c: Fix common/ includes.
8801         * source.c: Fix common/ includes.
8802         * solib.c: Fix common/ includes.
8803         * solib-target.c: Fix common/ includes.
8804         * ser-unix.c: Fix common/ includes.
8805         * ser-tcp.c: Fix common/ includes.
8806         * ser-pipe.c: Fix common/ includes.
8807         * ser-base.c: Fix common/ includes.
8808         * selftest-arch.c: Fix common/ includes.
8809         * s12z-tdep.c: Fix common/ includes.
8810         * rust-exp.y: Fix common/ includes.
8811         * rs6000-aix-tdep.c: Fix common/ includes.
8812         * riscv-tdep.c: Fix common/ includes.
8813         * remote.c: Fix common/ includes.
8814         * remote-notif.h: Fix common/ includes.
8815         * remote-fileio.h: Fix common/ includes.
8816         * remote-fileio.c: Fix common/ includes.
8817         * regcache.h: Fix common/ includes.
8818         * regcache.c: Fix common/ includes.
8819         * record-btrace.c: Fix common/ includes.
8820         * python/python.c: Fix common/ includes.
8821         * python/py-type.c: Fix common/ includes.
8822         * python/py-inferior.c: Fix common/ includes.
8823         * progspace.h: Fix common/ includes.
8824         * producer.c: Fix common/ includes.
8825         * procfs.c: Fix common/ includes.
8826         * proc-api.c: Fix common/ includes.
8827         * printcmd.c: Fix common/ includes.
8828         * ppc-linux-nat.c: Fix common/ includes.
8829         * parser-defs.h: Fix common/ includes.
8830         * osdata.c: Fix common/ includes.
8831         * obsd-nat.c: Fix common/ includes.
8832         * nat/x86-linux.c: Fix common/ includes.
8833         * nat/x86-linux-dregs.c: Fix common/ includes.
8834         * nat/x86-dregs.h: Fix common/ includes.
8835         * nat/x86-dregs.c: Fix common/ includes.
8836         * nat/ppc-linux.c: Fix common/ includes.
8837         * nat/mips-linux-watch.h: Fix common/ includes.
8838         * nat/mips-linux-watch.c: Fix common/ includes.
8839         * nat/linux-waitpid.c: Fix common/ includes.
8840         * nat/linux-ptrace.h: Fix common/ includes.
8841         * nat/linux-ptrace.c: Fix common/ includes.
8842         * nat/linux-procfs.c: Fix common/ includes.
8843         * nat/linux-personality.c: Fix common/ includes.
8844         * nat/linux-osdata.c: Fix common/ includes.
8845         * nat/linux-namespaces.c: Fix common/ includes.
8846         * nat/linux-btrace.h: Fix common/ includes.
8847         * nat/linux-btrace.c: Fix common/ includes.
8848         * nat/fork-inferior.c: Fix common/ includes.
8849         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8850         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8851         * nat/aarch64-linux.c: Fix common/ includes.
8852         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8853         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8854         * namespace.h: Fix common/ includes.
8855         * mips-linux-tdep.c: Fix common/ includes.
8856         * minsyms.c: Fix common/ includes.
8857         * mi/mi-parse.h: Fix common/ includes.
8858         * mi/mi-main.c: Fix common/ includes.
8859         * mi/mi-cmd-env.c: Fix common/ includes.
8860         * memrange.h: Fix common/ includes.
8861         * memattr.c: Fix common/ includes.
8862         * maint.h: Fix common/ includes.
8863         * maint.c: Fix common/ includes.
8864         * main.c: Fix common/ includes.
8865         * machoread.c: Fix common/ includes.
8866         * location.c: Fix common/ includes.
8867         * linux-thread-db.c: Fix common/ includes.
8868         * linux-nat.c: Fix common/ includes.
8869         * linux-fork.c: Fix common/ includes.
8870         * inline-frame.c: Fix common/ includes.
8871         * infrun.c: Fix common/ includes.
8872         * inflow.c: Fix common/ includes.
8873         * inferior.h: Fix common/ includes.
8874         * inferior.c: Fix common/ includes.
8875         * infcmd.c: Fix common/ includes.
8876         * inf-ptrace.c: Fix common/ includes.
8877         * inf-child.c: Fix common/ includes.
8878         * ia64-linux-nat.c: Fix common/ includes.
8879         * i387-tdep.c: Fix common/ includes.
8880         * i386-tdep.c: Fix common/ includes.
8881         * i386-linux-tdep.c: Fix common/ includes.
8882         * i386-linux-nat.c: Fix common/ includes.
8883         * i386-go32-tdep.c: Fix common/ includes.
8884         * i386-fbsd-tdep.c: Fix common/ includes.
8885         * i386-fbsd-nat.c: Fix common/ includes.
8886         * guile/scm-type.c: Fix common/ includes.
8887         * guile/guile.c: Fix common/ includes.
8888         * go32-nat.c: Fix common/ includes.
8889         * gnu-nat.c: Fix common/ includes.
8890         * gdbthread.h: Fix common/ includes.
8891         * gdbarch-selftests.c: Fix common/ includes.
8892         * gdb_usleep.c: Fix common/ includes.
8893         * gdb_select.h: Fix common/ includes.
8894         * gdb_bfd.c: Fix common/ includes.
8895         * gcore.c: Fix common/ includes.
8896         * fork-child.c: Fix common/ includes.
8897         * findvar.c: Fix common/ includes.
8898         * fbsd-nat.c: Fix common/ includes.
8899         * event-top.c: Fix common/ includes.
8900         * event-loop.c: Fix common/ includes.
8901         * dwarf2read.c: Fix common/ includes.
8902         * dwarf2loc.c: Fix common/ includes.
8903         * dwarf2-frame.c: Fix common/ includes.
8904         * dwarf-index-cache.c: Fix common/ includes.
8905         * dtrace-probe.c: Fix common/ includes.
8906         * disasm-selftests.c: Fix common/ includes.
8907         * defs.h: Fix common/ includes.
8908         * csky-tdep.c: Fix common/ includes.
8909         * cp-valprint.c: Fix common/ includes.
8910         * cp-support.h: Fix common/ includes.
8911         * cp-support.c: Fix common/ includes.
8912         * corelow.c: Fix common/ includes.
8913         * completer.h: Fix common/ includes.
8914         * completer.c: Fix common/ includes.
8915         * compile/compile.c: Fix common/ includes.
8916         * compile/compile-loc2c.c: Fix common/ includes.
8917         * compile/compile-cplus-types.c: Fix common/ includes.
8918         * compile/compile-cplus-symbols.c: Fix common/ includes.
8919         * command.h: Fix common/ includes.
8920         * cli/cli-dump.c: Fix common/ includes.
8921         * cli/cli-cmds.c: Fix common/ includes.
8922         * charset.c: Fix common/ includes.
8923         * build-id.c: Fix common/ includes.
8924         * btrace.h: Fix common/ includes.
8925         * btrace.c: Fix common/ includes.
8926         * breakpoint.h: Fix common/ includes.
8927         * breakpoint.c: Fix common/ includes.
8928         * ax.h:
8929         (enum agent_op): Fix common/ includes.
8930         * ax-general.c (struct aop_map): Fix common/ includes.
8931         * ax-gdb.c: Fix common/ includes.
8932         * auxv.c: Fix common/ includes.
8933         * auto-load.c: Fix common/ includes.
8934         * arm-tdep.c: Fix common/ includes.
8935         * arch/riscv.c: Fix common/ includes.
8936         * arch/ppc-linux-common.c: Fix common/ includes.
8937         * arch/i386.c: Fix common/ includes.
8938         * arch/arm.c: Fix common/ includes.
8939         * arch/arm-linux.c: Fix common/ includes.
8940         * arch/arm-get-next-pcs.c: Fix common/ includes.
8941         * arch/amd64.c: Fix common/ includes.
8942         * arch/aarch64.c: Fix common/ includes.
8943         * arch/aarch64-insn.c: Fix common/ includes.
8944         * arch-utils.c: Fix common/ includes.
8945         * amd64-windows-tdep.c: Fix common/ includes.
8946         * amd64-tdep.c: Fix common/ includes.
8947         * amd64-sol2-tdep.c: Fix common/ includes.
8948         * amd64-obsd-tdep.c: Fix common/ includes.
8949         * amd64-nbsd-tdep.c: Fix common/ includes.
8950         * amd64-linux-tdep.c: Fix common/ includes.
8951         * amd64-linux-nat.c: Fix common/ includes.
8952         * amd64-fbsd-tdep.c: Fix common/ includes.
8953         * amd64-fbsd-nat.c: Fix common/ includes.
8954         * amd64-dicos-tdep.c: Fix common/ includes.
8955         * amd64-darwin-tdep.c: Fix common/ includes.
8956         * agent.c: Fix common/ includes.
8957         * ada-lang.h: Fix common/ includes.
8958         * ada-lang.c: Fix common/ includes.
8959         * aarch64-tdep.c: Fix common/ includes.
8960
8961 2019-01-25  Tom Tromey  <tom@tromey.com>
8962
8963         * common/create-version.sh: Use common/version.h.
8964
8965 2019-01-24  Pedro Alves  <palves@redhat.com>
8966
8967         * infrun.c (signal_stop, signal_print, signal_program)
8968         (signal_catch, signal_pass): Now arrays instead of pointers.
8969         (update_signals_program_target, do_target_resume)
8970         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8971         * linux-nat.c (linux_nat_target::pass_signals)
8972         (linux_nat_target::create_inferior, linux_nat_target::attach):
8973         Adjust.
8974         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8975         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8976         * procfs.c (procfs_target::pass_signals): Adjust.
8977         * record-full.c (record_full_target::resume): Adjust.
8978         * remote.c (remote_target::pass_signals)
8979         (remote_target::program_signals): Adjust.
8980         * target-debug.h (target_debug_print_signals): Now takes a
8981         gdb::array_view as parameter.  Adjust.
8982         * target.h (target_ops) <pass_signals, program_signals>: Replace
8983         pointer and length parameters with gdb::array_view.
8984         (target_pass_signals, target_program_signals): Likewise.
8985         * target-delegates.c: Regenerate.
8986
8987 2019-01-24  Pedro Alves  <palves@redhat.com>
8988
8989         * common/forward-scope-exit.h
8990         (forward_scope_exit::forward_scope_exit): Pass arguments to
8991         m_bind_function directly, instead of creating a std::bind and
8992         copying that.
8993
8994 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8995
8996         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8997         for static members.
8998         (pass_in_v_vfp_candidate): Likewise.
8999
9000 2019-01-23  Tom Tromey  <tom@tromey.com>
9001             Pedro Alves  <palves@redhat.com>
9002
9003         * regcache.c (class regcache_invalidator): Remove.
9004         (regcache::raw_write): Use make_scope_exit.
9005
9006 2019-01-23  Tom Tromey  <tom@tromey.com>
9007
9008         * ui-out.h (class ui_out_emit_type): Update comment.
9009
9010 2019-01-23  Tom Tromey  <tom@tromey.com>
9011
9012         * infrun.c (fetch_inferior_event): Update comment.
9013
9014 2019-01-23  Tom Tromey  <tom@tromey.com>
9015             Pedro Alves  <palves@redhat.com>
9016
9017         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9018         parameter.
9019         (fetch_inferior_event): Use SCOPE_EXIT.
9020
9021
9022 2019-01-23  Tom Tromey  <tom@tromey.com>
9023             Pedro Alves  <palves@redhat.com>
9024
9025         * infrun.c (disable_thread_events): Delete.
9026         (stop_all_threads): Use SCOPE_EXIT.
9027
9028 2019-01-23  Tom Tromey  <tom@tromey.com>
9029             Pedro Alves  <palves@redhat.com>
9030
9031         * symfile.c: Include forward-scope-exit.h.
9032         (clear_symtab_users_cleanup): Replace forward declaration with
9033         a FORWARD_SCOPE_EXIT.
9034         (syms_from_objfile_1): Use the forward_scope_exit and
9035         gdb::optional instead of cleanup_function.
9036         (reread_symbols): Use the forward_scope_exit instead of
9037         cleanup_function.
9038         (clear_symtab_users_cleanup): Remove function.
9039
9040 2019-01-23  Tom Tromey  <tom@tromey.com>
9041             Pedro Alves  <palves@redhat.com>
9042
9043         * linux-nat.c: Include scope-exit.h.
9044         (cleanup_target_stop): Remove.
9045         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9046         SCOPE_EXIT.
9047
9048 2019-01-23  Tom Tromey  <tom@tromey.com>
9049             Pedro Alves  <palves@redhat.com>
9050
9051         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9052         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9053
9054 2019-01-23  Tom Tromey  <tom@tromey.com>
9055             Andrew Burgess  <andrew.burgess@embecosm.com>
9056             Pedro Alves  <palves@redhat.com>
9057
9058         * infrun.c (fetch_inferior_event): Use scope_exit.
9059         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9060         * top.c (execute_command): Use scope_exit.
9061         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9062         * utils.c (do_bpstat_clear_actions_cleanup)
9063         (make_bpstat_clear_actions_cleanup): Remove.
9064
9065 2019-01-23  Tom Tromey  <tom@tromey.com>
9066             Pedro Alves  <palves@redhat.com>
9067
9068         * infrun.c: Include "common/scope-exit.h"
9069         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9070         (wait_for_inferior): Use SCOPE_EXIT.
9071         (fetch_inferior_event): Use scope_exit.
9072
9073 2019-01-23  Tom Tromey  <tom@tromey.com>
9074             Pedro Alves  <palves@redhat.com>
9075
9076         * breakpoint.c (create_breakpoint): Remove cleanup.
9077
9078 2019-01-23  Tom Tromey  <tom@tromey.com>
9079             Andrew Burgess  <andrew.burgess@embecosm.com>
9080             Pedro Alves  <palves@redhat.com>
9081
9082 2019-01-23  Pedro Alves  <palves@redhat.com>
9083
9084         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9085
9086 2019-01-23  Pedro Alves  <palves@redhat.com>
9087             Andrew Burgess  <andrew.burgess@embecosm.com>
9088
9089         * gdbthread.h: Include "common/forward-scope-exit.h".
9090         (scoped_finish_thread_state): Redefine custom class in terms of
9091         forward_scope_exit.
9092
9093 2019-01-23  Pedro Alves  <palves@redhat.com>
9094             Andrew Burgess  <andrew.burgess@embecosm.com>
9095
9096         * common/forward-scope-exit.h: New file.
9097
9098 2019-01-23  Pedro Alves  <palves@redhat.com>
9099             Andrew Burgess  <andrew.burgess@embecosm.com>
9100             Tom Tromey  <tom@tromey.com>
9101
9102         * common/scope-exit.h: New file.
9103
9104 2019-01-23  Pedro Alves  <palves@redhat.com>
9105
9106         * common/preprocessor.h (ESC): Rename to ...
9107         (ESC_PARENS): ... this.
9108         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9109         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9110
9111 2019-01-23  Tom Tromey  <tom@tromey.com>
9112
9113         * language.h (class scoped_switch_to_sym_language_if_auto):
9114         Initialize m_lang in both cases.
9115
9116 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9117
9118         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9119         with XCNEW.
9120
9121 2019-01-22  Tom Tromey  <tom@tromey.com>
9122
9123         * corelow.c: Do not include sys/file.h.
9124
9125 2019-01-22  Tom Tromey  <tom@tromey.com>
9126
9127         * tui/tui-wingeneral.h: Include gdb_curses.h.
9128
9129 2019-01-22  Tom Tromey  <tom@tromey.com>
9130
9131         * source-cache.h (class source_cache) <get_source_lines,
9132         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9133
9134 2019-01-22  Tom Tromey  <tom@tromey.com>
9135
9136         * remote-fileio.h (struct remote_target): Declare.
9137
9138 2019-01-22  Tom Tromey  <tom@tromey.com>
9139
9140         * python/py-arch.c: Do not include py-ref.h.
9141         * python/py-bpevent.c: Do not include py-ref.h.
9142         * python/py-cmd.c: Do not include py-ref.h.
9143         * python/py-continueevent.c: Do not include py-ref.h.
9144         * python/py-event.h: Do not include py-ref.h.
9145         * python/py-evtregistry.c: Do not include py-ref.h.
9146         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9147         * python/py-frame.c: Do not include py-ref.h.
9148         * python/py-framefilter.c: Do not include py-ref.h.
9149         * python/py-function.c: Do not include py-ref.h.
9150         * python/py-infevents.c: Do not include py-ref.h.
9151         * python/py-linetable.c: Do not include py-ref.h.
9152         * python/py-objfile.c: Do not include py-ref.h.
9153         * python/py-param.c: Do not include py-ref.h.
9154         * python/py-prettyprint.c: Do not include py-ref.h.
9155         * python/py-progspace.c: Do not include py-ref.h.
9156         * python/py-symbol.c: Do not include py-ref.h.
9157         * python/py-symtab.c: Do not include py-ref.h.
9158         * python/py-type.c: Do not include py-ref.h.
9159         * python/py-unwind.c: Do not include py-ref.h.
9160         * python/py-utils.c: Do not include py-ref.h.
9161         * python/py-value.c: Do not include py-ref.h.
9162         * python/py-varobj.c: Do not include py-ref.h.
9163         * python/py-xmethods.c: Do not include py-ref.h.
9164         * python/python.c: Do not include py-ref.h.
9165         * varobj.c: Do not include py-ref.h.
9166
9167 2019-01-22  Tom Tromey  <tom@tromey.com>
9168
9169         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9170         keyword for bcache.
9171
9172 2019-01-22  Tom Tromey  <tom@tromey.com>
9173
9174         * compile/compile-cplus-types.c: Remove a comment by #include.
9175
9176 2019-01-22  Tom Tromey  <tom@tromey.com>
9177
9178         * compile/gcc-c-plugin.h: Include compile-internal.h.
9179
9180 2019-01-22  Tom Tromey  <tom@tromey.com>
9181
9182         * stabsread.c (EXTERN): Do not define.
9183         (symnum, next_symbol_text_func, processing_gcc_compilation)
9184         (within_function, global_sym_chain, global_stabs)
9185         (previous_stab_code, this_object_header_files)
9186         (n_this_object_header_files)
9187         (n_allocated_this_object_header_files): Define.
9188         * stabsread.h (EXTERN): Never define.  Use "extern".
9189
9190 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9191
9192         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9193         history_value.
9194
9195 2019-01-21  Tom Tromey  <tom@tromey.com>
9196
9197         * ui-out.c: Fix includes.
9198         * tui/tui-source.c: Fix includes.
9199         * target.c: Fix includes.
9200         * remote.c: Fix includes.
9201         * regcache.c: Fix includes.
9202         * python/py-block.c: Fix includes.
9203         * printcmd.c: Fix includes.
9204         * or1k-tdep.c: Fix includes.
9205         * mi/mi-main.c: Fix includes.
9206         * m32r-tdep.c: Fix includes.
9207         * csky-tdep.c: Fix includes.
9208         * compile/compile-cplus-types.c: Fix includes.
9209         * cli/cli-interp.c: Fix includes.
9210
9211 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9212
9213         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9214         for padding.
9215
9216 2019-01-16  Tom Tromey  <tom@tromey.com>
9217
9218         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9219         earlier.
9220         (struct objfile) <msymbols_range>: Move from top level.
9221         <msymbols>: New method.
9222         (class objfile_msymbols): Remove.
9223         * symtab.c (default_collect_symbol_completion_matches_break_on):
9224         Update.
9225         * symmisc.c (dump_msymbols): Update.
9226         * stabsread.c (scan_file_globals): Update.
9227         * objc-lang.c (info_selectors_command, info_classes_command)
9228         (find_methods): Update.
9229         * minsyms.c (find_solib_trampoline_target): Update.
9230         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9231         * coffread.c (coff_symfile_read): Update.
9232         * ada-lang.c (ada_lookup_simple_minsym)
9233         (ada_collect_symbol_completion_matches): Update.
9234
9235 2019-01-16  Tom Tromey  <tom@tromey.com>
9236
9237         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9238         type.  Remove no-argument constructor.
9239         <iterator::operator++>: Simplify.
9240         <begin>: Update.
9241         <end>: Use minimal_symbol_count.
9242
9243 2019-01-16  Tom Tromey  <tom@tromey.com>
9244
9245         * objfiles.h (struct objfile) <psymtabs>: New method.
9246         (class objfile_psymtabs): Remove.
9247         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9248         typedef.
9249         <range>: New method.
9250         (require_partial_symbols): Change return type.
9251         * psymtab.c (require_partial_symbols)
9252         (psym_expand_symtabs_matching): Update.
9253         * mdebugread.c (parse_partial_symbols): Update.
9254         * dbxread.c (dbx_end_psymtab): Update.
9255
9256 2019-01-15  Tom Tromey  <tom@tromey.com>
9257
9258         * symtab.c (lookup_objfile_from_block)
9259         (lookup_symbol_in_objfile_symtabs)
9260         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9261         (find_line_symtab, info_sources_command)
9262         (default_collect_symbol_completion_matches_break_on)
9263         (make_source_files_completion_list): Update.
9264         * symmisc.c (print_objfile_statistics, dump_objfile)
9265         (maintenance_print_symbols, maintenance_info_symtabs)
9266         (maintenance_check_symtabs, maintenance_info_line_tables):
9267         Update.
9268         * source.c (select_source_symtab)
9269         (forget_cached_source_info_for_objfile): Update.
9270         * objfiles.h (class objfile_compunits): Remove.
9271         (struct objfile) <compunits_range>: New typedef.
9272         (compunits): New method.
9273         * objfiles.c (objfile_relocate1): Update.
9274         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9275         * maint.c (count_symtabs_and_blocks): Update.
9276         * linespec.c (iterate_over_all_matching_symtabs): Update.
9277         * cp-support.c (add_symbol_overload_list_qualified): Update.
9278         * coffread.c (coff_symtab_read): Update.
9279         * ada-lang.c (add_nonlocal_symbols)
9280         (ada_collect_symbol_completion_matches)
9281         (ada_add_global_exceptions): Update.
9282
9283 2019-01-15  Tom Tromey  <tom@tromey.com>
9284
9285         * progspace.h (program_space) <objfiles_safe_range>: New
9286         typedef.
9287         <objfiles_safe>: New method.
9288         * objfiles.h (class all_objfiles_safe): Remove.
9289         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9290         * jit.c (jit_inferior_exit_hook): Update.
9291
9292 2019-01-17  Tom Tromey  <tom@tromey.com>
9293
9294         * progspace.h (program_space) <objfiles_range>: New typedef.
9295         <objfiles>: New method.
9296         <objfiles_head>: Rename from objfiles.
9297         (object_files): Update.
9298         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9299         * guile/scm-pretty-print.c
9300         (ppscm_find_pretty_printer_from_objfiles): Update.
9301         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9302         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9303         Update.
9304         * python/py-progspace.c (pspy_get_objfiles): Update.
9305         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9306         Update.
9307         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9308         (objfpy_lookup_objfile_by_build_id): Update.
9309         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9310         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9311         Update.
9312         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9313         (expand_symtab_containing_pc, lookup_objfile_from_block)
9314         (lookup_static_symbol, basic_lookup_transparent_type)
9315         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9316         (find_line_symtab, info_sources_command)
9317         (default_collect_symbol_completion_matches_break_on)
9318         (make_source_files_completion_list, find_main_name): Update.
9319         * symmisc.c (print_symbol_bcache_statistics)
9320         (print_objfile_statistics, maintenance_print_symbols)
9321         (maintenance_print_msymbols, maintenance_print_objfiles)
9322         (maintenance_info_symtabs, maintenance_check_symtabs)
9323         (maintenance_expand_symtabs, maintenance_info_line_tables):
9324         Update.
9325         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9326         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9327         (map_overlay_command, unmap_overlay_command)
9328         (simple_overlay_update, expand_symtabs_matching)
9329         (map_symbol_filenames): Update.
9330         * symfile-debug.c (set_debug_symfile): Update.
9331         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9332         Update.
9333         * source.c (select_source_symtab, forget_cached_source_info):
9334         Update.
9335         * solib.c (solib_read_symbols): Update.
9336         * solib-spu.c (append_ocl_sos): Update.
9337         * psymtab.c (maintenance_print_psymbols)
9338         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9339         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9340         * printcmd.c (info_symbol_command): Update.
9341         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9342         Update.
9343         * objfiles.h (class all_objfiles): Remove.
9344         * objfiles.c (have_partial_symbols, have_full_symbols)
9345         (have_minimal_symbols, qsort_cmp, update_section_map)
9346         (shared_objfile_contains_address_p)
9347         (default_iterate_over_objfiles_in_search_order): Update.
9348         * objc-lang.c (info_selectors_command, info_classes_command)
9349         (find_methods): Update.
9350         * minsyms.c (find_solib_trampoline_target): Update.
9351         * maint.c (maintenance_info_sections)
9352         (maintenance_translate_address, count_symtabs_and_blocks):
9353         Update.
9354         * main.c (captured_main_1): Update.
9355         * linux-thread-db.c (try_thread_db_load_from_pdir)
9356         (has_libpthread): Update.
9357         * linespec.c (iterate_over_all_matching_symtabs)
9358         (search_minsyms_for_name): Update.
9359         * jit.c (jit_find_objf_with_entry_addr): Update.
9360         * hppa-tdep.c (find_unwind_entry)
9361         (hppa_lookup_stub_minimal_symbol): Update.
9362         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9363         Update.
9364         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9365         (elf_gnu_ifunc_resolve_by_got): Update.
9366         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9367         * dwarf-index-write.c (save_gdb_index_command): Update.
9368         * cp-support.c (add_symbol_overload_list_qualified): Update.
9369         * breakpoint.c (create_overlay_event_breakpoint)
9370         (create_longjmp_master_breakpoint)
9371         (create_std_terminate_master_breakpoint)
9372         (create_exception_master_breakpoint): Update.
9373         * blockframe.c (find_pc_partial_function): Update.
9374         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9375         (ada_collect_symbol_completion_matches)
9376         (ada_add_global_exceptions): Update.
9377
9378 2019-01-17  Tom Tromey  <tom@tromey.com>
9379
9380         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9381         declare VEC.
9382         (solib_target_parse_libraries): Change return type.
9383         (library_list_start_segment, library_list_start_section)
9384         (library_list_end_library, library_list_start_library); Update.
9385         (solib_target_free_library_list): Remove.
9386         (solib_target_parse_libraries): Remove cleanup.  Change return
9387         type.
9388         (solib_target_current_sos): Update.
9389
9390 2019-01-17  Tom Tromey  <tromey@bapiya>
9391
9392         * valprint.c: Replace "the the" with "the".
9393         * symtab.c: Replace "the the" with "the".
9394         * solib.c: Replace "the the" with "the".
9395         * solib-dsbt.c: Replace "the the" with "the".
9396         * linespec.c: Replace "the the" with "the".
9397         * dwarf2loc.h: Replace "the the" with "the".
9398         * amd64-windows-tdep.c: Replace "the the" with "the".
9399         * aarch64-tdep.c: Replace "the the" with "the".
9400
9401 2019-01-16  Keith Seitz  <keiths@redhat.com>
9402
9403         PR gdb/23773
9404         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9405         <builder>: Rename to ..
9406         <m_builder>: ... this and make private.
9407         (dwarf2_cu::get_builder): New method.  Change all users of
9408         `builder' to use this method.
9409         (dwarf2_start_symtab): Move to ...
9410         (dwarf2_cu::start_symtab): ... here.  Update all callers
9411         (setup_type_unit_groups): Move to ...
9412         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9413         callers.
9414         (dwarf2_cu::reset_builder): New method.
9415         (process_full_compunit, process_full_type_unit): Use
9416         dwarf2_cu::reset_builder.
9417         (follow_die_offset): Record the ancestor CU if it is different
9418         from the followed DIE's CU.
9419         (follow_die_sig_1): Likewise.
9420
9421 2019-01-15  Tom Tromey  <tom@tromey.com>
9422
9423         * remote.c (class remote_state) <buf>: Now a char_vector.
9424         <buf_size>: Remove.
9425         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9426         parameter.
9427         (remote_target::getpkt_or_notif_sane_1)
9428         (remote_target::getpkt_sane)
9429         (remote_target::getpkt_or_notif_sane): Likewise.
9430         (class remote_target) <putpkt>: New overload.
9431         (remote_target::read_frame): Change type of "buf_p".  Remove
9432         sizeof_p parameter.
9433         (packet_ok): New overload.
9434         (packet_check_result): New overload.
9435         Update all uses.
9436
9437 2019-01-14  Tom Tromey  <tom@tromey.com>
9438
9439         * remote-notif.c (handle_notification, remote_notif_ack)
9440         (remote_notif_parse): Make "buf" const.
9441         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9442         const.
9443         (remote_notif_parse, remote_notif_ack, handle_notification):
9444         Likewise.
9445         * remote.c (remote_notif_stop_parse): Make "buf" const.
9446         (remote_target::remote_parse_stop_reply): Make "buf" const.
9447         (remote_notif_stop_ack): Make "buf" const.
9448
9449 2019-01-14  Tom Tromey  <tom@tromey.com>
9450
9451         * remote.c (remote_console_output): Make parameter const.
9452
9453 2019-01-14  Tom Tromey  <tom@tromey.com>
9454
9455         * target-debug.h (target_debug_print_signals): Constify.
9456         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9457         * procfs.c (procfs_target::pass_signals): Update.
9458         * linux-nat.c (linux_nat_target::pass_signals): Update.
9459         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9460         * target-delegates.c: Rebuild.
9461         * remote.c (remote_target::program_signals): Update.
9462         (remote_target::pass_signals): Update.
9463         * target.c (target_pass_signals): Constify argument.
9464         (target_program_signals): Likewise.
9465         * target.h (struct target_ops) <pass_signals, program_signals>:
9466         Constify argument.
9467         (target_pass_signals, target_program_signals): Constify argument.
9468
9469 2019-01-14  Tom Tromey  <tom@tromey.com>
9470
9471         PR tui/28819:
9472         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9473
9474 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9475
9476         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9477         field.
9478         * rs6000-tdep.c: Include reggroups.h.
9479         (IS_V_ALIAS_PSEUDOREG): Define.
9480         (rs6000_register_name): Return names for the "vX" aliases.
9481         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9482         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9483         aliases.  Call default_register_reggroup_p for all other
9484         pseudo-registers.
9485         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9486         New functions.
9487         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9488         Handle "vX" aliases.
9489         (v_alias_pseudo_register_collect): New function.
9490         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9491         (rs6000_gdbarch_init): Initialize "vX" aliases as
9492         pseudo-registers.  Restore registration of
9493         rs6000_pseudo_register_reggroup_p with
9494         set_tdesc_pseudo_register_reggroup_p.
9495
9496 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9497
9498         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9499         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9500         set_gdbarch_num_pseudo_regs.
9501
9502 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9503
9504         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9505         Remove arg prefixname, add do_set and do_show.
9506         Add member functions set_list and show_list.
9507         * cli/cli-style.c (class cli_style_option): Update accordingly.
9508         (style_set_list): Move to file scope.
9509         (style_show_list): Likewise.
9510         (set_style): Call help_list.
9511         (show_style): Call cmd_show_list.
9512         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9513         Update to use the new macro.
9514
9515 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9516
9517         * ada-lang.c (_initialize_ada_language): Expand the help text
9518         for the "catch exception" command.
9519
9520 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9521
9522         * symtab.c (matching_obj_sections): Initialize obj,
9523         declare it closer to its usage.
9524
9525 2019-01-10  Tom Tromey  <tom@tromey.com>
9526
9527         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9528         (basic_inf_threads_range): Remove.
9529         (inf_threads_range, inf_non_exited_threads_range)
9530         (safe_inf_threads_range): Use next_adapter.
9531
9532 2019-01-10  Keith Seitz  <keiths@redhat.com>
9533
9534         PR gdb/23712
9535         PR symtab/23010
9536         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9537         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9538
9539 2019-01-10  Keith Seitz  <keiths@redhat.com>
9540
9541         PR gdb/23712
9542         PR symtab/23010
9543         * dictionary.c (pending_to_vector): Remove.
9544         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9545         Remove _1 suffix, replacing functions of the same name.  Update
9546         all callers.
9547         (dict_create_hashed, dict_create_hashed_expandable)
9548         (dict_create_linear, dict_create_linear_expandable, dict_free)
9549         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9550         Make functions static.
9551
9552 2019-01-10  Keith Seitz  <keiths@redhat.com>
9553
9554         PR gdb/23712
9555         PR symtab/23010
9556         * dictionary.h (struct dictionary): Replace declaration with
9557         multidictionary.
9558         (dict_create_hashed, dict_create_hashed_expandable)
9559         (dict_create_linear, dict_create_linear_expandable)
9560         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9561         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9562         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9563         taking multidictionary argument.
9564         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9565         * block.h (struct block) <dict>: Change to multidictionary
9566         and rename `multidict'.
9567         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9568         symmisc.c: Update all dictionary references to multidictionary.
9569
9570 2019-01-10  Keith Seitz  <keiths@redhat.com>
9571
9572         PR gdb/23712
9573         PR symtab/23010
9574         * dictionary.c: Include unordered_map.
9575         (pending_to_vector): New function.
9576         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9577         Rewrite the non-"_1" functions to take vector instead
9578         of linked list.
9579         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9580         "new" _1 versions of the same name.
9581         (multidictionary): Define.
9582         (std::hash<enum language): New definition.
9583         (collate_pending_symbols_by_language, mdict_create_hashed)
9584         (mdict_create_hashed_expandable, mdict_create_linear)
9585         (mdict_create_linear_expandable, mdict_free)
9586         (find_language_dictionary, create_new_language_dictionary)
9587         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9588         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9589         (mdict_size, mdict_empty): New functions.
9590         * dictionary.h (mdict_iterator): Define.
9591
9592 2019-01-10  Pedro Alves  <palves@redhat.com>
9593
9594         * breakpoint.c (read_uploaded_action)
9595         (create_tracepoint_from_upload): Adjust to use
9596         gdb::unique_xmalloc_ptr.
9597         * ctf.c (ctf_write_uploaded_tp):
9598         (SET_ARRAY_FIELD): Use emplace_back.
9599         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9600         * tracefile-tfile.c (tfile_write_uploaded_tp):
9601         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9602         gdb::unique_xmalloc_ptr.
9603         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9604         at_string, cond_string, cmd_strings>: Replace char pointers
9605         with gdb::unique_xmalloc_ptr.
9606
9607 2019-01-10  Pedro Alves  <palves@redhat.com>
9608
9609         * solib-target.c (library_list_start_library): Don't xstrdup name.
9610
9611 2019-01-10  Pedro Alves  <palves@redhat.com>
9612
9613         * mdebugread.c (parse_partial_symbols): Use
9614         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9615
9616 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9617
9618         * linux-fork.c (scoped_switch_fork_info)
9619         <~scoped_switch_fork_info>: Fix incorrect variable name.
9620
9621 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9622
9623         * linux-fork.c (scoped_switch_fork_info)
9624         <scoped_switch_fork_info>: Make explicit.
9625         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9626
9627 2019-01-10  Tom Tromey  <tom@tromey.com>
9628
9629         * objfiles.h (objfile::reset_psymtabs): Update.
9630         * objfiles.c (objfile::objfile): Update.
9631         * psymtab.h (psymtab_storage::obstack): Update.
9632         (psymtab_storage::m_obstack): Use gdb::optional.
9633         (class psymtab_storage): Update comment.  Remove objfile
9634         parameter.
9635         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9636
9637 2019-01-10  Tom Tromey  <tom@tromey.com>
9638
9639         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9640         <free_psymtabs>: Now private.
9641         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9642         (allocate_psymtab): Use new method.
9643
9644 2019-01-10  Tom Tromey  <tom@tromey.com>
9645
9646         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9647         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9648         * mdebugread.c (parse_partial_symbols): Use
9649         allocate_dependencies.
9650         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9651         allocate_dependencies.
9652         (process_psymtab_comp_unit_reader)
9653         (build_type_psymtab_dependencies): Likewise.
9654         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9655
9656 2019-01-10  Tom Tromey  <tom@tromey.com>
9657
9658         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9659         PSYMBOL_SET_LANGUAGE.
9660         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9661
9662 2019-01-10  Tom Tromey  <tom@tromey.com>
9663
9664         * psymtab.h (psymtab_storage::obstack): New method.
9665         <m_obstack>: Rename from obstack; now private.
9666         * psymtab.c (psymtab_storage): Update.
9667         * dwarf2read.c (create_addrmap_from_index)
9668         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9669         Update.
9670
9671 2019-01-10  Tom Tromey  <tom@tromey.com>
9672
9673         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9674         * objfiles.h (objfile::reset_psymtabs): New method.
9675
9676 2019-01-10  Tom Tromey  <tom@tromey.com>
9677
9678         * symmisc.c (print_symbol_bcache_statistics): Update.
9679         (print_objfile_statistics): Update.
9680         * symfile.c (reread_symbols): Update.
9681         * psymtab.h (class psymtab_storage): New.
9682         * psymtab.c (psymtab_storage): New constructor.
9683         (~psymtab_storage): New destructor.
9684         (require_partial_symbols): Update.
9685         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9686         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9687         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9688         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9689         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9690         (start_psymtab_common, end_psymtab_common)
9691         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9692         (allocate_psymtab): Update.
9693         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9694         Update.
9695         (dump_psymtab_addrmap, maintenance_print_psymbols)
9696         (maintenance_check_psymtabs): Update.
9697         (class objfile_psymtabs): Move to objfiles.h.
9698         * psympriv.h (discard_psymtab): Now inline.
9699         (psymtab_discarder::psymtab_discarder): Update.
9700         (psymtab_discarder::~psymtab_discarder): Update.
9701         (ALL_OBJFILE_PSYMTABS): Rewrite.
9702         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9703         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9704         Remove fields.
9705         <partial_symtabs>: New field.
9706         (class objfile_psymtabs): Move from psymtab.h.  Update.
9707         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9708         psymbol_cache.
9709         (objfile::~objfile): Don't destroy psymbol_cache.
9710         * mdebugread.c (parse_partial_symbols): Update.
9711         * dwarf2read.c (create_addrmap_from_index)
9712         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9713         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9714         (add_partial_subprogram, dwarf2_ranges_read): Update.
9715         * dwarf-index-write.c (write_address_map)
9716         (write_one_signatured_type, recursively_write_psymbols)
9717         (class debug_names, class debug_names, write_psymtabs_to_index):
9718         Update.
9719
9720 2019-01-10  Tom Tromey  <tom@tromey.com>
9721
9722         * symtab.h (SYMBOL_SET_NAMES): Update.
9723         (symbol_set_names): Update.
9724         (MSYMBOL_SET_NAMES): Update.
9725         * symtab.c (symbol_set_names): Change argument to be an
9726         objfile_per_bfd_storage.
9727         * psymtab.c (add_psymbol_to_bcache): Update.
9728         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9729
9730 2019-01-10  Tom Tromey  <tom@tromey.com>
9731
9732         * symtab.c (create_demangled_names_hash): Change argument to be an
9733         objfile_per_bfd_storage.
9734         (symbol_set_names): Update.
9735
9736 2019-01-10  Tom Tromey  <tom@tromey.com>
9737
9738         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9739         init_psymbol_list.
9740         * psymtab.c (init_psymbol_list): Do nothing if already called.
9741         * psympriv.h (init_psymbol_list): Add comment.
9742         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9743         init_psymbol_list.
9744         * dbxread.c (dbx_symfile_read): Unconditionally call
9745         init_psymbol_list.
9746
9747 2019-01-10  Tom Tromey  <tom@tromey.com>
9748
9749         * xcoffread.c (scan_xcoff_symtab): Update.
9750         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9751         "where".
9752         * mdebugread.c (parse_partial_symbols)
9753         (handle_psymbol_enumerators): Update.
9754         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9755         * dbxread.c (read_dbx_symtab): Update.
9756         * psympriv.h (psymbol_placement): New enum.
9757         (add_psymbol_to_list): Update.
9758
9759 2019-01-10  Tom Tromey  <tom@tromey.com>
9760
9761         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9762         static_psymbols parameters.
9763         (scan_xcoff_symtab): Update.
9764         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9765         static_psymbols parameters.
9766         * psympriv.h (start_psymtab_common): Update.
9767         * mdebugread.c (parse_partial_symbols): Update.
9768         * dwarf2read.c (create_partial_symtab): Update.
9769         * dbxread.c (read_dbx_symtab): Update.
9770         (start_psymtab): Remove global_psymbols and static_psymbols
9771         parameters.
9772
9773 2019-01-10  Tom Tromey  <tom@tromey.com>
9774
9775         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9776         * psymtab.c (allocate_psymtab): Add comment.
9777         * psympriv.h (allocate_psymtab): Add comment.
9778         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9779         initializations.
9780         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9781
9782 2019-01-10  Tom Tromey  <tom@tromey.com>
9783
9784         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9785         Don't declare.
9786         * mipsread.c: Include mdebugread.h.
9787         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9788         Declare.
9789         * elfread.c: Include mdebugread.h.
9790
9791 2019-01-09  Tom Tromey  <tom@tromey.com>
9792
9793         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9794         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9795         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9796         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9797         (psym_lookup_symbol, psym_find_last_source_symtab)
9798         (psym_forget_cached_source_info, psym_print_stats)
9799         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9800         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9801         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9802         (psym_find_compunit_symtab_by_address)
9803         (maintenance_print_psymbols, maintenance_info_psymtabs)
9804         (maintenance_check_psymtabs): Use ranged for.
9805         * psymtab.h (class objfile_psymtabs): New.
9806         (require_partial_symbols): Return objfile_psymtabs.
9807         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9808
9809 2019-01-09  Tom Tromey  <tom@tromey.com>
9810
9811         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9812         (find_pc_mapped_section, list_overlays_command)
9813         (map_overlay_command, unmap_overlay_command)
9814         (simple_overlay_update): Use all_objfiles.
9815         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9816         * printcmd.c (info_symbol_command): Use all_objfiles.
9817         * objfiles.h (ALL_OBJSECTIONS): Remove.
9818         * maint.c (maintenance_translate_address): Use all_objfiles.
9819         * gcore.c (gcore_create_callback): Use all_objfiles.
9820         (objfile_find_memory_regions): Likewise.
9821
9822 2019-01-09  Tom Tromey  <tom@tromey.com>
9823
9824         * symtab.c (find_line_symtab, info_sources_command)
9825         (make_source_files_completion_list): Use objfile_compunits.
9826         * source.c (select_source_symtab): Use objfile_compunits.
9827         * objfiles.h (struct objfile): Update comment.
9828         (ALL_OBJFILES): Remove.
9829         (ALL_FILETABS): Remove.
9830         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9831         objfile_compunits.
9832
9833 2019-01-09  Tom Tromey  <tom@tromey.com>
9834
9835         * symmisc.c (print_objfile_statistics, dump_objfile)
9836         (maintenance_print_symbols): Use compunit_filetabs.
9837         * source.c (forget_cached_source_info_for_objfile): Use
9838         compunit_filetabs.
9839         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9840         (ALL_FILETABS): Use compunit_filetabs.
9841         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9842         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9843
9844 2019-01-09  Tom Tromey  <tom@tromey.com>
9845
9846         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9847         (compunit_filetabs): New.
9848         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9849         compunit_filetabs.
9850         (info_sources_command, make_source_files_completion_list): Remove
9851         declaration.
9852         * symmisc.c (print_objfile_statistics, dump_objfile)
9853         (maintenance_print_symbols): Remove declaration.
9854         (maintenance_info_symtabs): Use compunit_filetabs.
9855         (maintenance_info_line_tables): Likewise.
9856         * source.c (select_source_symtab): Change local variable name.
9857         (forget_cached_source_info_for_objfile): Remove declaration.
9858         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9859         * objfiles.c (objfile_relocate1): Remove declaration.
9860         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9861         declaration.
9862         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9863         * coffread.c (coff_symtab_read): Remove declaration.
9864         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9865         compunit_filetabs.
9866
9867 2019-01-09  Tom Tromey  <tom@tromey.com>
9868
9869         * symtab.c (lookup_objfile_from_block)
9870         (find_pc_sect_compunit_symtab, search_symbols)
9871         (default_collect_symbol_completion_matches_break_on): Use
9872         objfile_compunits.
9873         * objfiles.h (ALL_COMPUNITS): Remove.
9874         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9875         * cp-support.c (add_symbol_overload_list_qualified): Use
9876         objfile_compunits.
9877         * ada-lang.c (ada_collect_symbol_completion_matches)
9878         (ada_add_global_exceptions): Use objfile_compunits.
9879
9880 2019-01-09  Tom Tromey  <tom@tromey.com>
9881
9882         * source.c (select_source_symtab)
9883         (forget_cached_source_info_for_objfile): Remove declaration.
9884         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9885         declaration.
9886         * maint.c (count_symtabs_and_blocks): Remove declaration.
9887         * cp-support.c (add_symbol_overload_list_qualified): Remove
9888         declaration.
9889         * coffread.c (coff_symtab_read): Remove declaration.
9890         * symtab.c (lookup_symbol_in_objfile_symtabs)
9891         (basic_lookup_transparent_type_1): Use objfile_compunits.
9892         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9893         (info_sources_command, search_symbols)
9894         (default_collect_symbol_completion_matches_break_on)
9895         (make_source_files_completion_list): Remove declaration.
9896         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9897         (ada_collect_symbol_completion_matches)
9898         (ada_add_global_exceptions): Remove declaration.
9899         * linespec.c (iterate_over_all_matching_symtabs): Use
9900         objfile_compunits.
9901         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9902         (class objfile_compunits): New.
9903         (ALL_COMPUNITS): Use objfile_compunits.
9904         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9905         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9906         objfile_compunits.
9907         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9908
9909 2019-01-09  Tom Tromey  <tom@tromey.com>
9910
9911         * symtab.c (search_symbols)
9912         (default_collect_symbol_completion_matches_break_on): Use
9913         objfile_msymbols.
9914         * ada-lang.c (ada_lookup_simple_minsym)
9915         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9916         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9917         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9918         objfile_msymbols.
9919         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9920         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9921         * objc-lang.c (find_methods): Use objfile_msymbols.
9922         (info_selectors_command, info_classes_command): Likewise.
9923         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9924         * objfiles.h (class objfile_msymbols): New.
9925         (ALL_OBJFILE_MSYMBOLS): Remove.
9926         (ALL_MSYMBOLS): Remove.
9927
9928 2019-01-09  Tom Tromey  <tom@tromey.com>
9929
9930         * common/next-iterator.h (next_adapter): Add Iterator template
9931         parameter.
9932         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9933         (class all_objfiles_safe): New.
9934         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9935         * objfiles.c (put_objfile_before): Update comment.
9936         (add_separate_debug_objfile): Likewise.
9937         (free_all_objfiles): Use all_objfiles_safe.
9938         (objfile_purge_solibs): Likewise.
9939
9940 2019-01-09  Tom Tromey  <tom@tromey.com>
9941
9942         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9943         (expand_symtab_containing_pc, lookup_static_symbol)
9944         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9945         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9946         all_objfiles.
9947         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9948         * breakpoint.c (create_overlay_event_breakpoint)
9949         (create_longjmp_master_breakpoint)
9950         (create_std_terminate_master_breakpoint)
9951         (create_exception_master_breakpoint): Use all_objfiles.
9952         * linux-thread-db.c (try_thread_db_load_from_pdir)
9953         (has_libpthread): Use all_objfiles.
9954         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9955         * linespec.c (iterate_over_all_matching_symtabs)
9956         (search_minsyms_for_name): Use all_objfiles.
9957         * maint.c (maintenance_info_sections): Use all_objfiles.
9958         * main.c (captured_main_1): Use all_objfiles.
9959         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9960         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9961         * guile/scm-pretty-print.c
9962         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9963         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9964         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9965         (maintenance_print_msymbols): Use all_objfiles.
9966         * source.c (select_source_symtab): Use all_objfiles.
9967         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9968         * symfile.c (remove_symbol_file_command)
9969         (expand_symtabs_matching, map_symbol_filenames): Use
9970         all_objfiles.
9971         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9972         all_objfiles.
9973         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9974         * objc-lang.c (find_methods): Use all_objfiles.
9975         * objfiles.c (have_partial_symbols, have_full_symbols)
9976         (have_minimal_symbols, qsort_cmp)
9977         (default_iterate_over_objfiles_in_search_order): Use
9978         all_objfiles.
9979         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9980         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9981         (maintenance_check_psymtabs): Use all_objfiles.
9982         (ALL_PSYMTABS): Remove.
9983         * compile/compile-object-run.c (do_module_cleanup): Use
9984         all_objfiles.
9985         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9986         * cp-support.c (add_symbol_overload_list_qualified): Use
9987         all_objfiles.
9988         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9989         Use all_objfiles.
9990         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9991         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9992         all_objfiles.
9993         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9994         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9995         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9996         Uses all_objfiles.
9997         * solib.c (solib_read_symbols): Use all_objfiles
9998
9999 2019-01-09  Tom Tromey  <tom@tromey.com>
10000
10001         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10002         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10003         all_objfiles.
10004         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10005         * symmisc.c (print_symbol_bcache_statistics)
10006         (print_objfile_statistics, maintenance_print_objfiles)
10007         (maintenance_info_symtabs, maintenance_check_symtabs)
10008         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10009         all_objfiles.
10010         * source.c (forget_cached_source_info): Use all_objfiles.
10011         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10012         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10013         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10014         * objfiles.c (update_section_map): Use all_objfiles.
10015         (shared_objfile_contains_address_p): Likewise.
10016         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10017         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10018
10019 2019-01-09  Tom Tromey  <tom@tromey.com>
10020
10021         * common/next-iterator.h: New file.
10022         * objfiles.h (class all_objfiles): New.
10023         (struct objfile_iterator): New.
10024
10025 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10026
10027         * NEWS: Move the description of the changed "frame", "select-frame",
10028          and "info frame" commands to the Changed commands section.
10029
10030 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10031
10032         * gdbtypes.c (check_stub_method_group): Remove handling of old
10033         mangling schemes.
10034         * linespec.c (find_methods): Likewise.
10035         * stabsread.c (read_member_functions): Likewise.
10036         * valops.c (search_struct_method): Likewise.
10037         (value_struct_elt_for_reference): Likewise.
10038         * NEWS: Mention this change.
10039
10040 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10041
10042         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10043         print_source_lines.
10044         * source.c (print_source_lines_base): Update line number check.
10045         (print_source_lines): New function.
10046         (source_lines_range::source_lines_range): New function.
10047         * source.h (class source_lines_range): New class.
10048         (print_source_lines): New declaration.
10049
10050 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10051
10052         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10053
10054 2019-01-08  Tom Tromey  <tom@tromey.com>
10055             Simon Marchi  <simon.marchi@ericsson.com>
10056
10057         PR gdb/24060
10058         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10059         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10060         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10061         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10062         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10063         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10064
10065 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10066
10067         * source.c (select_source_symtab): Move header comment to
10068         declaration in source.h.
10069         (forget_cached_source_info_for_objfile): Likewise.
10070         (forget_cached_source_info): Likewise.
10071         (identify_source_line): Likewise.
10072         * source.h (identify_source_line): Move declaration from symtab.h
10073         and add comment from source.c
10074         (print_source_lines): Likewise.
10075         (forget_cached_source_info_for_objfile): Likewise.
10076         (forget_cached_source_info): Likewise.
10077         (select_source_symtab): Likewise.
10078         (enum print_source_lines_flag): Move definition from symtab.h.
10079         * symtab.h (identify_source_line): Move declaration to source.h.
10080         (print_source_lines): Likewise.
10081         (forget_cached_source_info_for_objfile): Likewise.
10082         (forget_cached_source_info): Likewise.
10083         (select_source_symtab): Likewise.
10084         (enum print_source_lines_flag): Move definition to source.h.
10085         * tui/tui-hooks.c: Add 'source.h' include.
10086
10087 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10088
10089         * source.c (print_source_lines_base): Handle requests to print
10090         reverse line number sequences, and guard against empty lines
10091         string.
10092
10093 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10094
10095         * source.c (print_source_lines_base): Fix skip of '\r' if next
10096         character is '\n'.
10097
10098 2019-01-06  Tom Tromey  <tom@tromey.com>
10099
10100         * c-exp.y (struct c_parse_state) <macro_original_text,
10101         expansion_obstack>: New member.
10102         (macro_original_text, expansion_obstack): Remove globals.
10103         (scan_macro_expansion, scanning_macro_expansion)
10104         (finished_macro_expansion): Update.
10105         (scan_macro_cleanup): Remove.
10106         (yylex, c_parse): Update.
10107
10108 2019-01-06  Tom Tromey  <tom@tromey.com>
10109
10110         * c-exp.y (struct c_parse_state) <strings>: New member.
10111         (operator_stoken): Update.
10112
10113 2019-01-06  Tom Tromey  <tom@tromey.com>
10114
10115         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10116         (union type_stack_elt) <typelist_val>: Now a pointer to
10117         std::vector.
10118         (type_stack_cleanup): Don't declare.
10119         (push_typelist): Update.
10120         * parse.c (pop_typelist): Return a std::vector.
10121         (push_typelist): Take a std::vector.
10122         (follow_types): Update.  Do not free args.
10123         (type_stack_cleanup): Remove.
10124         * c-exp.y (struct c_parse_state): New.
10125         (cpstate): New global.
10126         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10127         (nonempty_typelist): Update.
10128         (func_mod): Create a new vector.
10129         (c_parse): Create a c_parse_state.
10130         (check_parameter_typelist): Do not delete params.
10131         (function_method): Update.  Do not delete type_list.
10132
10133 2019-01-06  Tom Tromey  <tom@tromey.com>
10134
10135         PR gdb/28155:
10136         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10137         check_typedef.
10138         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10139         (print_return_value): Likewise.
10140
10141 2019-01-05  Tom Tromey  <tom@tromey.com>
10142
10143         * contrib/cleanup_check.py: Remove.
10144         * contrib/gcc-with-excheck: Remove.
10145         * contrib/exsummary.py: Remove.
10146         * contrib/excheck.py: Remove.
10147
10148 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10149
10150         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10151         NULL. Initialize tpprev to NULL instead of assigning it
10152         to NULL on the next statement.
10153         * windows-nat.c (windows_delete_thread): Remove check for
10154         main_thread_id before printing thread exit notifications.
10155         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10156         Remove thread ID check against main_thread_id.
10157         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10158         windows_delete_thread.
10159         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10160
10161 2019-01-04  Tom Tromey  <tom@tromey.com>
10162
10163         * compile/compile.c (_initialize_compile): Use upper case for
10164         metasyntactic variables.
10165         * symmisc.c (_initialize_symmisc): Use upper case for
10166         metasyntactic variables.
10167         * psymtab.c (_initialize_psymtab): Use upper case for
10168         metasyntactic variables.
10169         * demangle.c (demangle_command): Use upper case for metasyntactic
10170         variables.
10171         (_initialize_demangler): Likewise.
10172         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10173         variables.
10174
10175 2019-01-03  Tom Tromey  <tom@tromey.com>
10176
10177         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10178
10179 2019-01-03  Tom Tromey  <tom@tromey.com>
10180
10181         * python/py-symtab.c (salpy_str): Update.
10182         (struct salpy_sal_object) <symtab>: Now a PyObject.
10183         (salpy_dealloc): Update.
10184         (del_objfile_sal): Use gdbpy_ref.
10185
10186 2019-01-03  Tom Tromey  <tom@tromey.com>
10187
10188         * python/py-type.c (convert_field): Use new_reference.  Return
10189         gdbpy_ref.
10190         (make_fielditem): Return gdbpy_ref.
10191         (typy_fields): Update.
10192         (typy_getitem): Update.
10193         (field_name): Return gdbpy_ref.  Use new_reference.
10194         (typy_iterator_iternext): Update.
10195
10196 2019-01-03  Tom Tromey  <tom@tromey.com>
10197
10198         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10199
10200 2019-01-03  Tom Tromey  <tom@tromey.com>
10201
10202         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10203         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10204         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10205         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10206         (pspy_set_type_printers): Likewise.
10207         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10208         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10209         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10210         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10211         (objfpy_set_type_printers): Likewise.
10212
10213 2019-01-03  Tom Tromey  <tom@tromey.com>
10214
10215         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10216         (gdbpy_print_stack): Use gdbpy_err_fetch.
10217         * python/python-internal.h (class gdbpy_err_fetch): New class.
10218         (class gdbpy_enter) <m_error_type, m_error_value,
10219         m_error_traceback>: Remove.
10220         <m_error>: New member.
10221         (gdbpy_exception_to_string): Don't declare.
10222         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10223         * python/py-value.c (convert_value_from_python): Use
10224         gdbpy_err_fetch.
10225         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10226         gdbpy_exception_to_string.
10227         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10228         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10229         gdbpy_err_fetch.
10230
10231 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10232
10233         * linux-nat.c (delete_lwp_cleanup): Delete.
10234         (struct lwp_deleter): New struct.
10235         (lwp_info_up): New typedef.
10236         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10237         lwp_info_up.
10238
10239 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10240
10241         * linux-fork.c (class scoped_switch_fork_info): New class.
10242         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10243
10244 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10245
10246         * valops.c (find_overload_match): Remove use of null_cleanup, and
10247         calls to do_cleanups.
10248
10249 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10250
10251         * compile/compile-cplus-types.c
10252         (compile_cplus_instance::decl_name): Handle changes to
10253         cp_func_name.
10254         * cp-support.c (cp_func_name): Update header comment, update
10255         return type.
10256         * cp-support.h (cp_func_name): Update return type in declaration.
10257         * valops.c (find_overload_match): Move temp_func local to top
10258         level of function and change its type.  Use temp_func to hold and
10259         delete temporary string obtained from cp_func_name.
10260
10261 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10262
10263         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10264         gdb::char_vector, remove cleanup, and update uses of `msg`.
10265
10266 2019-01-03  Jim Wilson  <jimw@sifive.com>
10267
10268         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10269
10270 2019-01-02  Tom Tromey  <tom@tromey.com>
10271
10272         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10273         (tdesc_parse_xml): Remove cleanups.
10274         * target-descriptions.h (make_cleanup_free_target_description):
10275         Don't declare.
10276         (target_desc_deleter): New struct.
10277         (target_desc_up): New typedef.
10278         * target-descriptions.c (target_desc_deleter::operator()): Rename
10279         from free_target_description.
10280         (make_cleanup_free_target_description): Remove.
10281
10282 2019-01-02  Tom Tromey  <tom@tromey.com>
10283
10284         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10285         constructor, destructor.
10286         (linespec_parser): Remove typedef.
10287         (~linespec_parser): Rename from linespec_parser_delete.
10288         (linespec_lex_to_end, linespec_complete_label)
10289         (linespec_complete): Update.
10290         (decode_line_full): Remove cleanups.
10291         (decode_line_1): Update.
10292
10293 2019-01-02  Tom Tromey  <tom@tromey.com>
10294
10295         * python/python-internal.h (inferior_to_inferior_object): Change
10296         return type.
10297         * python/py-exitedevent.c (create_exited_event_object): Update.
10298         * python/py-inferior.c (inferior_to_inferior_object): Return
10299         gdbpy_ref.
10300         (python_new_inferior, python_inferior_deleted)
10301         (thread_to_thread_object, delete_thread_object)
10302         (build_inferior_list, gdbpy_selected_inferior): Update.
10303         * python/py-infthread.c (create_thread_object): Update.  Also fail
10304         if inferior_to_inferior_object fails.
10305
10306 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10307
10308         * inferior.h (class inferior) <displaced_step_state>: New field.
10309         * infrun.h (struct displaced_step_state): Move here from
10310         infrun.c.  Initialize fields, add constructor.
10311         <inf>: Remove field.
10312         <reset>: New method.
10313         * infrun.c (struct displaced_step_inferior_state): Move to
10314         infrun.h.
10315         (displaced_step_inferior_states): Remove.
10316         (get_displaced_stepping_state): Adust.
10317         (displaced_step_in_progress_any_inferior): Adjust.
10318         (displaced_step_in_progress_thread): Adjust.
10319         (displaced_step_in_progress): Adjust.
10320         (add_displaced_stepping_state): Remove.
10321         (get_displaced_step_closure_by_addr): Adjust.
10322         (remove_displaced_stepping_state): Remove.
10323         (infrun_inferior_exit): Call displaced_step_state.reset.
10324         (use_displaced_stepping): Don't check for NULL.
10325         (displaced_step_prepare_throw): Call
10326         get_displaced_stepping_state.
10327         (displaced_step_fixup): Don't check for NULL.
10328         (prepare_for_detach): Don't check for NULL.
10329
10330 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10331
10332         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10333          in case of call that did not complete.
10334
10335 2019-01-02  Andrey Utkin  <autkin@undo.io>
10336
10337         * symfile.c (find_separate_debug_file): Fix search of debug files for
10338         remote debuggee.
10339
10340 2019-01-02  Tom Tromey  <tom@tromey.com>
10341
10342         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10343         indentation.
10344         * python/py-frame.c (frapy_older): Remove cast.
10345         (frapy_newer): Likewise.
10346         * python/py-breakpoint.c (local_setattro): Remove cast.
10347         * python/py-arch.c (archpy_name): Remove local variable.
10348         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10349
10350 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10351
10352         * unittests/basic_string_view/element_access/char/empty.cc:
10353         Fix year range in copyright header.
10354
10355 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10356
10357         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10358         Delete.
10359         <operator==>: Update with for removed field.
10360         <hash>: Likewise.
10361         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10362         <isa_features>: ...this.
10363         <abi_features>: New field.
10364         (riscv_isa_flen): Update comment.
10365         (riscv_abi_xlen): New declaration.
10366         (riscv_abi_flen): New declaration.
10367         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10368         isa_features.
10369         (riscv_abi_xlen): New function.
10370         (riscv_isa_flen): Update to get answer from isa_features.
10371         (riscv_abi_flen): New function.
10372         (riscv_has_fp_abi): Update to get answer from abi_features.
10373         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10374         xlen and flen.
10375         (riscv_call_info) <xlen, flen>: Update comment.
10376         (riscv_call_arg_struct): Remove invalid assertions
10377         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10378         is removed.
10379         (riscv_gdbarch_init): Gather isa features and abi features
10380         separately, ensure both match on the gdbarch when reusing an old
10381         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10382         a target with 64-bit float hardware.
10383
10384 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10385
10386         * source.c (search_command_helper): Stop reverse search
10387         when line 1 has been searched.
10388
10389 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10390
10391         * record-full.c (record_full_base_target::close): Rewrite
10392         record_full_core_buf_list free logic.
10393
10394 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10395
10396         * break-catch-syscall.c (print_one_catch_syscall): xfree
10397         the last text.
10398
10399 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10400
10401         * top.c (print_gdb_version): Update Copyright year in version
10402         message.
10403
10404 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10405
10406         Update copyright year range in all GDB files.
10407
10408 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10409
10410         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10411
10412 For older changes see ChangeLog-2018.
10413 \f
10414 Local Variables:
10415 mode: change-log
10416 left-margin: 8
10417 fill-column: 74
10418 version-control: never
10419 coding: utf-8
10420 End:
10421