gdb/ChangeLog

   1 2019-08-16  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (struct tui_source_window_base)
   4         <m_has_locator>: Remove.
   5         * tui/tui-layout.c (show_source_disasm_command, show_data)
   6         (show_source_or_disasm_and_command): Update.
   7
   8 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
   9
  10         * NEWS (Other MI changes): New subsection.
  11         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
  12         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
  13         * arch-utils.c (default_get_pc_address_flags): New function.
  14         * arch-utils.h (default_get_pc_address_flags): New declaration.
  15         * gdbarch.sh: Add get_pc_address_flags.
  16         * gdbarch.c: Regenerate.
  17         * gdbarch.h: Likewise.
  18         * stack.c (print_pc): New function.
  19         (print_frame_info) (print_frame): Call print_pc.
  20
  21 2019-08-16  Tom de Vries  <tdevries@suse.de>
  22
  23         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
  24         print_objfile_section_info.
  25
  26 2019-08-15  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
  29         calling update_cmdwin_start_line.
  30         * tui/tui-winsource.h (struct tui_source_window_base)
  31         <do_make_visible_with_new_height, set_new_height>: Don't declare.
  32         <rerender>: Declare.
  33         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
  34         Call rerender.
  35         (tui_source_window_base::set_new_height): Remove.
  36         (tui_source_window_base::rerender): Rename from
  37         do_make_visible_with_new_height.
  38         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
  39         resize method.
  40         (tui_win_info::make_invisible_and_set_new_height)
  41         (tui_win_info::make_visible_with_new_height): Remove.
  42         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
  43         Declare.
  44         * tui/tui-stack.c (tui_locator_window::rerender): New method.
  45         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
  46         do_make_visible_with_new_height>: Don't declare.
  47         <rerender>: Declare.
  48         * tui/tui-regs.c (tui_data_window::rerender): Rename from
  49         set_new_height.
  50         (tui_data_window::do_make_visible_with_new_height): Remove.
  51         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
  52         call tui_show_locator_content.
  53         (tui_gen_win_info::resize): Call rerender.
  54         (show_source_or_disasm_and_command): Don't call
  55         tui_show_locator_content.
  56         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
  57         method.
  58         (struct tui_win_info) <rerender>: Declare.
  59         <set_new_height, make_invisible_and_set_new_height,
  60         make_visible_with_new_height>: Don't declare.
  61         * tui/tui-data.c (tui_win_list::rerender): New method.
  62         * tui/tui-command.h (struct tui_cmd_window)
  63         <do_make_visible_with_new_height>: Don't declare.
  64         * tui/tui-command.c
  65         (tui_cmd_window::do_make_visible_with_new_height): Remove.
  66
  67 2019-08-15  Tom Tromey  <tromey@adacore.com>
  68
  69         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
  70         * ada-lang.c (ada_enum_name): Likewise.
  71
  72 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
  73
  74         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
  75         leading underscore.
  76         (GdbOutputErrorFile): Likewise.
  77         (global scope): Adjust constructor calls to GdbOutput{,Error}File
  78         accordingly.
  79         (execute_unwinders): Rename to have a leading underscore.
  80         (auto_load_packages): Likewise.
  81         (global scope): Adjust call to auto_load_packages accordingly.
  82         (GdbSetPythonDirectory): Likewise.
  83         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
  84         instead of execute_unwinders.
  85
  86 2019-08-15  Tom Tromey  <tom@tromey.com>
  87
  88         * tui/tui-layout.c (show_layout, show_source_disasm_command)
  89         (show_data): Don't change window visibility.
  90         (tui_gen_win_info::resize): Remove special case for command
  91         window.  Use wresize, when available.
  92         (show_source_or_disasm_and_command): Don't change window
  93         visibility.
  94         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
  95         <make_visible>: New method.
  96         * tui/tui-command.c (tui_cmd_window::resize): New method.
  97
  98 2019-08-15  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 101         (struct tui_source_windows): New.
 102         * tui/tui-winsource.c (tui_display_main): Update.
 103         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 104         (new_height_ok, parse_scrolling_args): Update.
 105         * tui/tui-layout.c (show_layout, show_data): Update.
 106         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 107         (tui_add_to_source_windows): Don't declare.
 108         * tui/tui-data.c (source_windows, tui_source_windows)
 109         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 110
 111 2019-08-15  Tom Tromey  <tom@tromey.com>
 112
 113         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 114         Rename from reset.
 115         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 116         * tui/tui-layout.c (show_source_disasm_command, show_data):
 117         Update.
 118         (tui_gen_win_info::resize): Rename.
 119         (show_source_or_disasm_and_command): Update.
 120         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 121         reset.
 122
 123 2019-08-15  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 126         * tui/tui-interp.c (tui_interp::init): Don't call
 127         tui_initialize_static_data.
 128         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 129
 130 2019-08-15  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 133         examine tui_win_list.
 134
 135 2019-08-15  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 138         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 139         tui_clear_source_content.
 140         (tui_clear_source_content): Remove.
 141         (tui_source_window_base::do_erase_source_content): Hoist call to
 142         content.clear().
 143         * tui/tui-stack.c (tui_show_frame_info): Don't call
 144         tui_clear_source_content.
 145
 146 2019-08-15  Tom Tromey  <tom@tromey.com>
 147
 148         * tui/tui-winsource.h (struct tui_source_window_base)
 149         <do_erase_source_content>: New method.
 150         <erase_source_content>: New method.
 151         (tui_erase_source_content): Don't declare.
 152         * tui/tui-winsource.c (tui_clear_source_content): Update.
 153         (tui_source_window_base::do_erase_source_content): Rename from
 154         tui_erase_source_content.
 155         (tui_source_window_base::show_source_content): Update.
 156         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 157         * tui/tui-source.h (struct tui_source_window)
 158         <erase_source_content>: New method.
 159         * tui/tui-disasm.h (struct tui_disasm_window)
 160         <erase_source_content>: New method.
 161
 162 2019-08-15  Tom Tromey  <tom@tromey.com>
 163
 164         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 165         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 166         constructor.
 167         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 168         * tui/tui-source.c (tui_set_source_content): Update.
 169         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 170
 171 2019-08-15  Tom Tromey  <tom@tromey.com>
 172
 173         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 174         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 175         tui-source.c.
 176         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 177         Declare.
 178         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 179         method.
 180         (tui_source_window::maybe_update): Update.
 181
 182 2019-08-15  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 185         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 186         tui-disasm.c.
 187         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 188         Declare.
 189         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 190         method.
 191         (tui_disasm_window::maybe_update): Update.
 192
 193 2019-08-15  Tom Tromey  <tom@tromey.com>
 194
 195         * tui/tui-winsource.h (struct tui_source_window_base)
 196         <maybe_update>: Declare.
 197         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 198         method.
 199         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 200         Declare.
 201         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 202         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 203         Declare.
 204         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 205
 206 2019-08-15  Tom Tromey  <tom@tromey.com>
 207
 208         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 209
 210 2019-08-15  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-wingeneral.c: Include tui-stack.h.
 213         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 214         (struct tui_locator_window): Move from tui-data.h.
 215         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 216         (tui_initialize_static_data): Move from tui-data.c.
 217         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 218         (struct tui_locator_window): Move to tui-stack.c.
 219         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 220         (tui_initialize_static_data): Move to tui-stack.c.
 221
 222 2019-08-15  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-layout.c (show_source_disasm_command)
 225         (show_source_or_disasm_and_command): Use make_visible method, not
 226         tui_make_window.
 227         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 228         Remove.
 229
 230 2019-08-15  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui-wingeneral.h (tui_make_window): Update.
 233         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 234         parameter.
 235         (tui_gen_win_info::make_visible): Update.
 236         * tui/tui-regs.c (tui_data_window::display_registers_from):
 237         Update.
 238         * tui/tui-layout.c (show_source_disasm_command)
 239         (show_source_or_disasm_and_command): Update.
 240         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 241         (enum tui_box): Remove.
 242         (struct tui_win_info) <can_box>: New method.
 243         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 244         method.
 245
 246 2019-08-15  Tom de Vries  <tdevries@suse.de>
 247
 248         * linux-nat-trad.c: Include gdbarch.h.
 249
 250 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 251
 252         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 253         register sizes.
 254
 255 2019-08-14  Tom Tromey  <tromey@adacore.com>
 256
 257         * darwin-nat.c: Include gdbarch.h.
 258         * darwin-nat-info.c: Include gdbarch.h.
 259
 260 2019-08-13  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 263         Remove.
 264         * tui/tui-data.c (tui_initialize_static_data): Update.
 265
 266 2019-08-13  Tom Tromey  <tom@tromey.com>
 267
 268         * tui/tui-winsource.h (struct tui_exec_info_window)
 269         <~tui_exec_info_window, maybe_allocate_content, get_content,
 270         m_content>: Remove.
 271         (struct tui_source_window_base) <set_exec_info_content,
 272         show_exec_info_content>: Don't declare.
 273         * tui/tui-winsource.c
 274         (tui_exec_info_window::maybe_allocate_content): Remove.
 275         (tui_source_window_base::update_exec_info): Rename from
 276         set_exec_info_content.
 277         (tui_source_window_base::show_exec_info_content)
 278         (tui_source_window_base::update_exec_info): Remove.
 279
 280 2019-08-13  Tom Tromey  <tom@tromey.com>
 281
 282         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 283         declare.
 284         * tui/tui-winsource.c (tui_update_source_window_as_is)
 285         (tui_update_source_windows_with_addr, tui_erase_source_content):
 286         Update.
 287         (tui_clear_exec_info_content): Remove.
 288
 289 2019-08-13  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 292         declare.
 293         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 294         call tui_erase_exec_info_content.
 295         (tui_clear_exec_info_content): Rename from
 296         tui_erase_exec_info_content.
 297         (tui_clear_exec_info_content): Delete.
 298
 299 2019-08-13  Tom Tromey  <tom@tromey.com>
 300
 301         * tui/tui-winsource.h (struct tui_source_window_base)
 302         <show_exec_info_content>: Declare.
 303         (tui_show_exec_info_content): Don't declare.
 304         * tui/tui-winsource.c
 305         (tui_source_window_base::show_exec_info_content): Rename from
 306         tui_show_exec_info_content.
 307         (tui_source_window_base::update_exec_info): Update.
 308
 309 2019-08-13  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 312         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 313         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 314         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 315         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 316         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 317         ... here.
 318
 319 2019-08-13  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-winsource.h (struct tui_source_window_base)
 322         <update_exec_info>: Declare.
 323         (tui_update_exec_info): Don't declare.
 324         * tui/tui-winsource.c (tui_update_source_window_as_is)
 325         (tui_source_window_base::refresh_all)
 326         (tui_update_all_breakpoint_info): Update.
 327         (tui_source_window_base::update_exec_info): Rename from
 328         tui_update_exec_info.
 329         * tui/tui-stack.c (tui_show_frame_info): Update.
 330
 331 2019-08-13  Tom Tromey  <tom@tromey.com>
 332
 333         * tui/tui-winsource.h (struct tui_source_window_base)
 334         <set_exec_info_content>: Declare.
 335         (tui_set_exec_info_content): Don't declare.
 336         * tui/tui-winsource.c
 337         (tui_source_window_base::set_exec_info_content): Rename from
 338         tui_set_exec_info_content.
 339         (tui_update_exec_info): Update.
 340
 341 2019-08-13  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-winsource.h (struct tui_source_window_base)
 344         <show_source_content>: Declare.
 345         (tui_show_source_content): Don't declare.
 346         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 347         (tui_source_window_base::show_source_content): Rename from
 348         tui_show_source_content.
 349         (tui_source_window_base::refresh_all): Update.
 350         * tui/tui-layout.c (show_source_disasm_command)
 351         (show_source_or_disasm_and_command): Update.
 352
 353 2019-08-13  Tom Tromey  <tom@tromey.com>
 354
 355         * tui/tui-winsource.c (tui_erase_source_content)
 356         (tui_show_source_content, tui_source_window_base::refresh_all):
 357         Update.
 358         * tui/tui-wingeneral.h
 359         (tui_check_and_display_highlight_if_needed): Don't declare.
 360         * tui/tui-wingeneral.c
 361         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 362         check_and_display_highlight_if_needed.
 363         * tui/tui-win.c (tui_rehighlight_all)
 364         (tui_win_info::make_visible_with_new_height): Update.
 365         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 366         (tui_data_window::erase_data_content)
 367         (tui_data_window::display_all_data): Update.
 368         * tui/tui-data.h (struct tui_win_info)
 369         <check_and_display_highlight_if_needed>: Declare.
 370
 371 2019-08-13  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-win.c (tui_resize_all): Call
 374         tui_delete_invisible_windows.
 375         * tui/tui-layout.c (show_layout): Call
 376         tui_delete_invisible_windows.
 377         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 378         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 379
 380 2019-08-13  Tom Tromey  <tom@tromey.com>
 381
 382         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 383         tui_add_win_to_layout.
 384
 385 2019-08-13  Tom Tromey  <tom@tromey.com>
 386
 387         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 388         * tui/tui-layout.c (tui_default_win_height): Now static.
 389
 390 2019-08-13  Tom Tromey  <tom@tromey.com>
 391
 392         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 393         single switch.
 394         (show_source_disasm_command, show_source_or_disasm_and_command):
 395         Don't check current layout.
 396
 397 2019-08-13  Tom Tromey  <tom@tromey.com>
 398
 399         * tui/tui-wingeneral.c (make_all_visible): Remove.
 400         (tui_make_all_invisible): Simplify.
 401         * tui/tui-layout.c (tui_make_all_invisible): Move from
 402         tui-wingeneral.c; simplify.
 403         (show_layout): Hoist call to tui_make_all_invisible.
 404         (show_data): Don't call tui_make_all_invisible.
 405
 406 2019-08-13  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 409         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 410
 411 2019-08-13  Tom Tromey  <tom@tromey.com>
 412
 413         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 414         tui-data.c.
 415         (show_source_disasm_command, show_data)
 416         (show_source_or_disasm_and_command): Don't use
 417         tui_set_current_layout_to.
 418         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 419         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 420         tui-layout.c.
 421         (tui_set_current_layout_to): Remove.
 422
 423 2019-08-13  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-layout.c (tui_set_layout): Update.
 426         * tui/tui-data.h (struct tui_layout_def): Remove.
 427         (tui_layout_def): Don't declare.
 428         * tui/tui-data.c (layout_def): Remove.
 429         (tui_layout_def): Remove.
 430
 431 2019-08-13  Tom Tromey  <tom@tromey.com>
 432
 433         * tui/tui-winsource.h (struct tui_source_window_base)
 434         <clear_detail>: No longer "override".
 435         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 436         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 437         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 438         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 439         Remove.
 440         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 441
 442 2019-08-13  Tom Tromey  <tromey@adacore.com>
 443
 444         * tracepoint.c: Don't include readline.h or history.h.
 445
 446 2019-08-12  Tom Tromey  <tom@tromey.com>
 447
 448         * configure: Rebuild.
 449         * configure.ac: Check for readline 7.
 450         * NEWS: Mention readline 7 requirement.
 451         * README: Update.
 452
 453 2019-08-12  Tom Tromey  <tom@tromey.com>
 454
 455         * mingw-hdep.c (gdb_select): Remove readline hack.
 456
 457 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 458
 459         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 460         when the function fails.
 461
 462 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 463
 464         * s390-tdep.c (s390_type_align): New function.
 465         (s390_gdbarch_init): Set it as type_align gdbarch method.
 466
 467 2019-08-09  Tom de Vries  <tdevries@suse.de>
 468
 469         PR gdb/24591
 470         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 471         pc_low with relocation offset.
 472
 473 2019-08-07  Tom Tromey  <tromey@adacore.com>
 474
 475         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 476         (print_frame_args): Update.
 477         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 478         Update.
 479         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 480         * frame.h (struct frame_arg): Add initializers.
 481         <error>: Now a unique_xmalloc_ptr.
 482
 483 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 484
 485         * NEWS: Expand the Pointer Authentication entry.
 486         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 487         (aarch64_frame_unmask_lr): ... to this.
 488         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 489         Call aarch64_frame_unmask_lr.
 490         * frame.c (struct frame_info): Add "masked" variable.
 491         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 492         (fprint_frame): Check for masked pc.
 493         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 494         declarations.
 495         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 496         * stack.c (print_frame): Check for masked pc.
 497
 498 2019-08-06  Tom Tromey  <tom@tromey.com>
 499
 500         * stabsread.c (patch_block_stabs, read_one_struct_field)
 501         (read_enum_type): Use obstack_strndup.
 502         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 503         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 504         * dwarf2read.c (guess_full_die_structure_name)
 505         (anonymous_struct_prefix): Use obstack_strndup.
 506         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 507         * c-exp.y (yylex): Use obstack_strndup.
 508         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 509         (write_var_or_type): Use obstack_strndup.
 510
 511 2019-08-06  Tom Tromey  <tom@tromey.com>
 512
 513         * symfile.c (reread_symbols): Use obstack_strdup.
 514         * stabsread.c (read_type): Use obstack_strdup.
 515         * gdb_obstack.h (obstack_strdup): New overload.
 516         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 517         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 518         (dwarf2_canonicalize_name): Use obstack_strdup.
 519         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 520         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 521         Use obstack_strdup.
 522
 523 2019-08-06  Tom Tromey  <tom@tromey.com>
 524
 525         * gdb_obstack.h (obstack_strdup): Define.
 526         * gdb_obstack.c (obstack_strdup): Don't define.
 527
 528 2019-08-06  Tom Tromey  <tom@tromey.com>
 529
 530         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 531         obstack_strdup.
 532         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 533         obstack_strdup.
 534         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 535         * stabsread.c (common_block_start): Use obstack_strdup.
 536         * objfiles.c (set_objfile_main_name, objfile): Use
 537         obstack_strdup.
 538         * namespace.c (add_using_directive): Use obstack_strdup.
 539         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 540         * jit.c (finalize_symtab): Use obstack_strdup.
 541         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 542         (guess_partial_die_structure_name, partial_die_info::fixup)
 543         (dwarf2_name): Use obstack_strdup.
 544         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 545         obstack_strdup.
 546         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 547         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 548         obstack_strdup.
 549         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 550
 551 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 552
 553         * unittests/help-doc-selftests.c: New file.
 554         * Makefile.in: Add the new file.
 555
 556 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 557
 558         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 559         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 560         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 561         the trailing '.' is not output, and the first character is uppercased.
 562         (print_help_for_command): Update call to print_doc_line.
 563         (print_doc_of_command): Likewise.
 564         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 565         * cli/cli-option.c (append_indented_doc): Do not append newline.
 566         (build_help_option): Append newline after first appended_indented_doc
 567         only if a second call is done.
 568         (build_help): Append 2 new lines before each option, except the first
 569         one.
 570         * compile/compile.c (_initialize_compile): Add new lines after
 571         %OPTIONS%, when not at the end of the help.
 572         Change help doc or code
 573         producing the help doc to respect the invariants.
 574         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 575         Also removed the new line after 'Options:', as all other commands
 576         do not put an empty line between 'Options:' and the first option.
 577         * printcmd.c (_initialize_printcmd): Likewise.
 578         * stack.c (_initialize_stack): Likewise.
 579         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 580         incorrectly telling COMMAND is optional.
 581         * ada-lang.c (_initialize_ada_language): Change help doc or code
 582         producing the help doc to respect the invariants.
 583         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 584         * breakpoint.c (_initialize_breakpoint): Likewise.
 585         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 586         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 587         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 588         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 589         _initialize_cli_style): Likewise.
 590         * corelow.c (core_target_info): Likewise.
 591         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 592         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 593         * filesystem.c (_initialize_filesystem): Likewise.
 594         * frame.c (_initialize_frame): Likewise.
 595         * gnu-nat.c (add_task_commands): Likewise.
 596         * infcall.c (_initialize_infcall): Likewise.
 597         * infcmd.c (_initialize_infcmd): Likewise.
 598         * interps.c (_initialize_interpreter): Likewise.
 599         * language.c (_initialize_language): Likewise.
 600         * linux-fork.c (_initialize_linux_fork): Likewise.
 601         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 602         * maint.c (_initialize_maint_cmds): Likewise.
 603         * memattr.c (_initialize_mem): Likewise.
 604         * printcmd.c (_initialize_printcmd): Likewise.
 605         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 606         _RegEx): Likewise.
 607         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 608         * record-btrace.c (_initialize_record_btrace): Likewise.
 609         * record-full.c (_initialize_record_full): Likewise.
 610         * record.c (_initialize_record): Likewise.
 611         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 612         * regcache.c (_initialize_regcache): Likewise.
 613         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 614         _initialize_remote): Likewise.
 615         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 616         * serial.c (_initialize_serial): Likewise.
 617         * skip.c (_initialize_step_skip): Likewise.
 618         * source.c (_initialize_source): Likewise.
 619         * stack.c (_initialize_stack): Likewise.
 620         * symfile.c (_initialize_symfile): Likewise.
 621         * symtab.c (_initialize_symtab): Likewise.
 622         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 623         * top.c (init_main): Likewise.
 624         * tracefile-tfile.c (tfile_target_info): Likewise.
 625         * tracepoint.c (_initialize_tracepoint): Likewise.
 626         * tui/tui-win.c (_initialize_tui_win): Likewise.
 627         * utils.c (add_internal_problem_command): Likewise.
 628         * valprint.c (value_print_option_defs): Likewise.
 629
 630 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 631
 632         PR build/24886
 633         * configure.ac: Drop enable-libmcheck support.
 634         * configure, config.in: Rebuild.
 635         * libmcheck.m4: Remove.
 636         * acinclude.m4: Don't include it.
 637         * Makefile.in: Don't distribute it.
 638         * top.c (print_gdb_configuration): Don't mention it.
 639
 640 2019-08-06  Tom Tromey  <tom@tromey.com>
 641
 642         * utils.c (set_output_style): Sometimes pass stream to
 643         emit_style_escape.
 644         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 645         * record-btrace.c (btrace_insn_history): Update.
 646         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 647         method.
 648         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 649         Update initializers.
 650         <m_uiout>: New field.
 651         <m_di>: Move lower.
 652         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 653         Remove "uiout" parameter.
 654         (dump_insns): Update.
 655         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 656         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 657
 658 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 659
 660         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 661         (error_in_psymtab_expansion): Likewise.
 662         (lookup_symbol_via_quick_fns): Likewise.
 663         (basic_lookup_transparent_type_quick): Likewise.
 664         (basic_lookup_transparent_type_1): Likewise.
 665
 666 2019-08-06  Tom Tromey  <tromey@adacore.com>
 667
 668         * source.c (last_source_error): Now bool.
 669         (print_source_lines_base): Make "noprint" bool.  Only open
 670         source file when last_source_visited changes.
 671
 672 2019-08-06  Tom Tromey  <tromey@adacore.com>
 673
 674         * annotate.c (annotate_source_line): Use g_source_cache.
 675         * source-cache.c (source_cache::get_plain_source_lines): Change
 676         parameters.  Populate m_offset_cache.
 677         (source_cache::ensure): New method.
 678         (source_cache::get_line_charpos): New method.
 679         (extract_lines): Move lower.  Change parameters.
 680         (source_cache::get_source_lines): Move lower.
 681         * source-cache.h (class source_cache): Update comment.
 682         <get_line_charpos>: New method.
 683         <get_source_lines>: Update comment.
 684         <clear>: Clear m_offset_cache.
 685         <get_plain_source_lines>: Change parameters.
 686         <ensure>: New method
 687         <m_offset_cache>: New member.
 688         * source.c (forget_cached_source_info_for_objfile): Update.
 689         (info_source_command): Use g_source_cache.
 690         (find_source_lines, open_source_file_with_line_charpos): Remove.
 691         (print_source_lines_base, search_command_helper): Use g_source_cache.
 692         * source.h (open_source_file_with_line_charpos): Don't declare.
 693         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 694         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 695         Use g_source_cache.
 696
 697 2019-08-06  Tom Tromey  <tromey@adacore.com>
 698
 699         * source-cache.c (source_cache::get_plain_source_lines):
 700         Remove "first_line" and "last_line" parameters.
 701         (source_cache::get_source_lines): Cache plain text.
 702         * source-cache.h (class source_cache)
 703         <get_plain_source_lines>: Update.
 704
 705 2019-08-06  Tom Tromey  <tromey@adacore.com>
 706
 707         * source-cache.c (extract_lines): No longer a method.
 708         Changed type of parameter.  Include final newline.
 709         (selftests::extract_lines_test): New function.
 710         (_initialize_source_cache): Likewise.
 711         * source-cache.h (class source_cache)
 712         <extract_lines>: Don't declare.
 713
 714 2019-08-06  Tom Tromey  <tromey@adacore.com>
 715
 716         * breakpoint.c (init_breakpoint_sal): Update.
 717         (breakpoint): Update.
 718         * breakpoint.h (struct breakpoint) <filter>: Now a
 719         unique_xmalloc_ptr.
 720
 721 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 722
 723         * NEWS: Mention dictionary access on blocks.
 724         * python/py-block.c (blpy_getitem): New function.
 725         (block_object_as_mapping): New struct.
 726         (block_object_type): Use new struct for tp_as_mapping field.
 727
 728 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 729
 730         * objfiles.h (objfile): Add a comment describing partial symbols.
 731
 732 2019-08-05  Tom Tromey  <tromey@adacore.com>
 733
 734         * compile/compile.c (_initialize_compile): Use _(), not N_().
 735         * thread.c (_initialize_thread): Use _(), not N_().
 736         * stack.c (_initialize_stack): Use _(), not N_().
 737         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 738
 739 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 740
 741         * dwarf2read.c (struct dw2_symtab_iterator):
 742         <want_specific_block>: Remove.
 743         <block_index>: Change type to gdb::optional.
 744         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 745         change type of BLOCK_INDEX parameter to gdb::optional.
 746         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 747         (dw2_lookup_symbol): Don't pass argument for
 748         WANT_SPECIFIC_BLOCK.
 749         (dw2_expand_symtabs_for_function): Don't pass argument for
 750         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 751         (class dw2_debug_names_iterator)
 752         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 753         parameter, change BLOCK_INDEX type to gdb::optional.
 754         <m_want_specific_block>: Remove.
 755         <m_block_index>: Change type to gdb::optional.
 756         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 757         gdb::optional.  Re-write in function of gdb::optional.
 758         (dw2_debug_names_lookup_symbol): Don't pass argument for
 759         WANT_SPECIFIC_BLOCK.
 760         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 761         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 762         BLOCK_INDEX.
 763
 764 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 765
 766         * NEWS: Mention changes to "info sources" command.
 767
 768 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 769
 770         * symtab.c (filename_partial_match_opts): New struct type.
 771         (struct output_source_filename_data): New members
 772         regexp, c_regexp, partial_match.
 773         (output_source_filename): Use new members to decide to print file.
 774         (info_sources_option_defs): New variable.
 775         (make_info_sources_options_def_group, print_info_sources_header,
 776         info_sources_command_completer):
 777         New functions.
 778         (info_sources_command): Read new optional arguments.
 779         (_initialize_symtab): Update info sources help.
 780
 781 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 782
 783         * ada-lang.c (exception_support_info_v0): Renamed from...
 784         (default_exception_support_info): ... this.  Create new
 785         definition for v1.
 786         (ada_has_this_exception_support): Look up catch_handlers_sym.
 787         (ada_exception_support_info_sniffer): Try v0 after default.
 788
 789 2019-08-01  Tom Tromey  <tromey@adacore.com>
 790
 791         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 792         gdbarch.h.
 793
 794 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 795
 796         * s12z-tdep.c: Fix include path for s12z-opc.h.
 797
 798 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 799
 800         * NEWS: Require GNU make 3.82.
 801
 802 2019-07-16  Tom Tromey  <tom@tromey.com>
 803
 804         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 805         declare.
 806
 807 2019-07-30  Tom Tromey  <tromey@adacore.com>
 808
 809         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 810
 811 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 812
 813         * printcmd.c (print_address_symbolic): Print negative offsets.
 814         (build_address_symbolic): Force signed arithmetic when computing
 815         offset.
 816
 817 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 818
 819         PR/24474: Add a function to lookup static variables.
 820         * NEWS: Mention this new function.
 821         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 822         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 823         * python/python.c (python_GdbMethods): Add new function.
 824
 825 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 826
 827         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 828         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 829         (objfpy_lookup_static_symbol): New function.
 830         (objfile_object_methods): Add new functions.
 831
 832 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 833
 834         * NEWS: Mention 'set|show print frame-info'.  Mention new
 835         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 836         backtrace argument.  Mention that python frame filtering code
 837         is now consistent with what 'backtrace' command prints.
 838
 839 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 840
 841         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 842         comments.
 843         (print_frame_info_auto, print_frame_info_source_line,
 844         print_frame_info_location, print_frame_info_source_and_location,
 845         print_frame_info_location_and_address, print_frame_info_short_location):
 846         New declarations.
 847         (struct frame_print_options): New member print_frame_info.
 848         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 849         * stack.h (get_user_print_what_frame_info): New declaration.
 850         (frame_show_address): New declaration.
 851         * stack.c (print_frame_arguments_choices): New value 'presence'.
 852         (print_frame_info_auto, print_frame_info_source_line,
 853         print_frame_info_location, print_frame_info_source_and_location,
 854         print_frame_info_location_and_address, print_frame_info_short_location,
 855         print_frame_info_choices, print_frame_info_print_what): New definitions.
 856         (print_frame_args): Only print dots for args if print frame-arguments
 857         is 'presence'.
 858         (frame_print_option_defs): New element for "frame-info".
 859         (get_user_print_what_frame_info): New function.
 860         (frame_show_address): Make non static.  Move comment to stack.h.
 861         (print_frame_info_to_print_what): New function.
 862         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 863         to decide what to print.
 864         (backtrace_command_1): Handle the new print_frame_arguments_presence
 865         value.
 866         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 867         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 868         (py_print_frame): In non-mi mode, use LOCATION as default for
 869         print_what, similarly to frame information printed directly by
 870         backtrace command. Handle frame-info user option in non MI mode.
 871
 872 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 873
 874         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 875         Add case for debugging 32-bit target on 64-bit host.  Revise
 876         comment.
 877
 878 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 879
 880         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 881         instead of find_function_entry_range_from_pc.
 882
 883 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 884
 885         * stack.c (find_frame_funname): Remove code which preferred
 886         minsym over symtab sym in "certain pathological cases".
 887
 888         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 889         parameter.  Change type of "do_demangle" to bool.
 890         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 891         Pass suitable "prefer_sym_over_minsym" flag to
 892         build_address_symbolic().  Don't output "+" for negative offsets.
 893         * printcmd.c (print_address_symbolic): Update invocation of
 894         build_address_symbolic to include a "prefer_sym_over_minsym"
 895         flag.
 896         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 897         Restrict cases in which use of minimal symbol is preferred to that
 898         of a found symbol.  Update comments.
 899
 900         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 901         for entry pc when entry pc is out of range for that FDE.
 902
 903 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 904
 905         PR gdb/24839:
 906         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 907         type.
 908
 909 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 910
 911         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 912         this function's Python signature.
 913
 914
 915 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 916
 917         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 918         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 919         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 920         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 921         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 922
 923
 924 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 925
 926         * h8300-tdep.c (h8300_register_name_common): New.
 927         h8300_register_name): Use h8300_register_name_common.
 928         (h8300s_register_name): Likewise.
 929         (h8300sx_register_name): Likewise.
 930         (h8300h_register_nam): New.
 931         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 932
 933
 934 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 935
 936         * arm-tdep.c (arm_skip_cmse_entry): New function.
 937         (arm_is_sgstubs_section): New function.
 938         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 939
 940 2019-07-22  Tom Tromey  <tom@tromey.com>
 941
 942         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 943         Don't self-assign.
 944
 945 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 946
 947         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 948         type_print.
 949
 950 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 951
 952         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 953         so that GDB doesn't match any msymbols when searching in the
 954         TYPES_DOMAIN.
 955         (print_symbol_info): Print using typedef_print or type_print based
 956         on the type of the symbol.  Add updated FIXME comment moved from...
 957         (_initialize_symtab): ... move and update FIXME comment to above.
 958
 959 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 960
 961         * NEWS: Mention adding -q option to "info types".
 962         * symtab.c (struct info_types_options): New struct.
 963         (info_types_options_defs): New variable.
 964         (make_info_types_options_def_group): New function.
 965         (info_types_command): Use gdb::option framework to parse options.
 966         (info_types_command_completer): New function.
 967         (_initialize_symtab): Extend the help text on "info types" and
 968         register command completer.
 969
 970 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 971
 972         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 973         (lookup_symbol_in_objfile): Change int to block_enum and add a
 974         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 975
 976 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 977
 978         * MAINTAINERS (Write After Approval): Add self.
 979
 980 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 981
 982         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 983         instruction to the dummy code region.
 984
 985 2019-07-19  Tom Tromey  <tromey@adacore.com>
 986
 987         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 988         (ARGSUSED, PARAMS, __func__): Remove rules.
 989
 990 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 991
 992         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 993         * features/arm/arm-with-iwmmxt.c: Remove.
 994         * features/arm/arm-with-iwmmxt.xml: Remove.
 995         * features/arm/arm-with-m-fpa-layout.c: Remove.
 996         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 997         * features/arm/arm-with-m-vfp-d16.c: Remove.
 998         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 999         * features/arm/arm-with-m.c: Remove.
1000         * features/arm/arm-with-m.xml: Remove.
1001         * features/arm/arm-with-neon.c: Remove.
1002         * features/arm/arm-with-neon.xml: Remove.
1003         * features/arm/arm-with-vfpv2.c: Remove.
1004         * features/arm/arm-with-vfpv2.xml: Remove.
1005         * features/arm/arm-with-vfpv3.c: Remove.
1006         * features/arm/arm-with-vfpv3.xml: Remove.
1007
1008 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1009
1010         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1011
1012 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1013
1014         * arch/aarch32.c (aarch32_create_target_description): Create
1015         target descriptions using features.
1016         * arch/arm.c (arm_create_target_description)
1017         (arm_create_mprofile_target_description): Likewise.
1018         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1019
1020 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1021
1022         * Makefile.in: Add new files.
1023         * aarch32-tdep.c: New file.
1024         * aarch32-tdep.h: New file.
1025         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1026         Call aarch32_read_description.
1027         * arch/aarch32.c: New file.
1028         * arch/aarch32.h: New file.
1029         * arch/arm.c (arm_create_target_description)
1030         (arm_create_mprofile_target_description): New function.
1031         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1032         (arm_create_target_description)
1033         (arm_create_mprofile_target_description): New declaration.
1034         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1035         read_description functions.
1036         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1037         Likewise.
1038         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1039         * arm-tdep.c (tdesc_arm_list): New variable.
1040         (arm_register_g_packet_guesses): Call create description functions.
1041         (arm_read_description) (arm_read_mprofile_description): New
1042         function.
1043         * arm-tdep.h (arm_read_description)
1044         (arm_read_mprofile_description): Add declaration.
1045         * configure.tgt: Add new files.
1046
1047 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1048
1049         * top.c (new_ui_command): Open specified terminal just once.
1050
1051 2019-07-18  Tom Tromey  <tromey@adacore.com>
1052
1053         * symtab.c (main_name): Constify return type.
1054         * symfile.c (set_initial_language): Update.
1055         * symtab.h (main_name): Constify return type.
1056
1057 2019-07-17  Tom Tromey  <tom@tromey.com>
1058
1059         * tui/tui-winsource.c (tui_update_source_window)
1060         (tui_update_source_window_as_is)
1061         (tui_update_source_windows_with_line): Remove return.
1062         * tui/tui-disasm.c (tui_show_disassem)
1063         (tui_show_disassem_and_update_source): Remove return.
1064         * tui/tui.c (tui_reset): Remove return.
1065         * tui/tui-wingeneral.c
1066         (tui_check_and_display_highlight_if_needed): Remove return.
1067
1068 2019-07-17  Tom Tromey  <tom@tromey.com>
1069
1070         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1071
1072 2019-07-17  Tom Tromey  <tom@tromey.com>
1073
1074         * tui/tui-winsource.h (struct tui_exec_info_window)
1075         (struct tui_source_window_base): Move from tui-data.h.
1076         * tui/tui-winsource.c: Move many method definitions from
1077         elsewhere.  Remove "structuring" comments.
1078         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1079         (tui_source_window_base::refresh_window): Move to
1080         tui-winsource.c.
1081         * tui/tui-win.c (tui_source_window_base::refresh_all)
1082         (tui_source_window_base::update_tab_width)
1083         (tui_source_window_base::set_new_height)
1084         (tui_source_window_base::do_make_visible_with_new_height): Move to
1085         tui-winsource.c.
1086         * tui/tui-source.h: Update.
1087         * tui/tui-source.c (tui_source_window_base::reset): Move to
1088         tui-winsource.c.
1089         * tui/tui-disasm.h: Update.
1090         * tui/tui-data.h (struct tui_exec_info_window): Move to
1091         tui-winsource.h.
1092         (struct tui_source_window_base): Likewise.
1093         * tui/tui-data.c (tui_source_window_base::clear_detail)
1094         (tui_source_window_base, ~tui_source_window_base): Move to
1095         tui-winsource.c.
1096
1097 2019-07-17  Tom Tromey  <tom@tromey.com>
1098
1099         * tui/tui-win.c (tui_resize_all)
1100         (tui_source_window_base::update_tab_width)
1101         (tui_adjust_win_heights): Update.
1102         (tui_win_info::make_invisible_and_set_new_height): Rename from
1103         make_invisible_and_set_new_height.
1104         * tui/tui-data.h (struct tui_win_info)
1105         <make_invisible_and_set_new_height>: New method.
1106
1107 2019-07-17  Tom Tromey  <tom@tromey.com>
1108
1109         * tui/tui.c: Update.
1110         * tui/tui-source.h (struct tui_source_window): Move from
1111         tui-data.h.
1112         * tui/tui-layout.c: Update.
1113         * tui/tui-disasm.c: Update.
1114         * tui/tui-data.h (struct tui_source_window): Move to
1115         tui-source.h.
1116
1117 2019-07-17  Tom Tromey  <tom@tromey.com>
1118
1119         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1120         tui-data.h.
1121         * tui/tui-data.h (struct tui_disasm_window): Move to
1122         tui-disasm.h.
1123
1124 2019-07-17  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui-regs.h (struct tui_data_item_window): Move from
1127         tui-data.h.
1128         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1129         * tui/tui-data.h (struct tui_data_item_window): Move to
1130         tui-regs.h.
1131         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1132
1133 2019-07-17  Tom Tromey  <tom@tromey.com>
1134
1135         * tui/tui.c: Update.
1136         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1137         (tui_cmd_window::max_height): Move to tui-command.c.
1138         * tui/tui-layout.c: Update.
1139         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1140         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1141         tui-command.c.
1142         * tui/tui-command.h (struct tui_cmd_window): Move from
1143         tui-data.h.
1144         * tui/tui-command.c: Remove "structuring" comments.
1145         (tui_cmd_window::clear_detail)
1146         (tui_cmd_window::do_make_visible_with_new_height)
1147         (tui_cmd_window::max_height): Move from elsewhere.
1148
1149 2019-07-17  Tom Tromey  <tom@tromey.com>
1150
1151         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1152         Now static.
1153         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1154         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1155
1156 2019-07-17  Tom Tromey  <tom@tromey.com>
1157
1158         * tui/tui.c: Update.
1159         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1160         tui-regs.c.
1161         * tui/tui-windata.h: Remove file.
1162         * tui/tui-windata.c: Remove file.
1163         * tui/tui-win.c (tui_data_window::set_new_height)
1164         (tui_data_window::do_make_visible_with_new_height): Move to
1165         tui-regs.c.
1166         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1167         * tui/tui-regs.c: Remove "structuring" comments.
1168         (tui_data_window::first_data_item_displayed)
1169         (tui_data_window::delete_data_content_windows)
1170         (tui_data_window::erase_data_content)
1171         (tui_data_window::display_all_data)
1172         (tui_data_window::refresh_all)
1173         (tui_data_window::do_scroll_vertical)
1174         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1175         (tui_data_window::do_make_visible_with_new_height)
1176         (tui_data_window::refresh_window): Move from elsewhere.
1177         (_initialize_tui_regs): Move to end of file.
1178         * tui/tui-layout.c: Update.
1179         * tui/tui-hooks.c: Update.
1180         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1181         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1182         tui-regs.c.
1183         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1184
1185 2019-07-17  Tom Tromey  <tom@tromey.com>
1186
1187         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1188         seen.
1189
1190 2019-07-17  Tom Tromey  <tom@tromey.com>
1191
1192         * tui/tui-win.c (tui_source_window_base::set_new_height)
1193         (tui_source_window_base::do_make_visible_with_new_height): Use
1194         m_has_locator field directly.
1195         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1196         method.
1197         (struct tui_source_window_base) <has_locator>: Likewise.
1198
1199 2019-07-17  Tom Tromey  <tom@tromey.com>
1200
1201         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1202         Don't declare.
1203         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1204         Remove.
1205         * tui/tui-win.c (tui_source_window_base::set_new_height)
1206         (tui_source_window_base::set_new_height)
1207         (make_invisible_and_set_new_height)
1208         (tui_source_window_base::do_make_visible_with_new_height)
1209         (tui_source_window_base::do_make_visible_with_new_height):
1210         Update.
1211         * tui/tui-layout.c (show_source_disasm_command, show_data)
1212         (show_source_or_disasm_and_command): Update.
1213         * tui/tui-layout.c (show_layout): Update.
1214
1215 2019-07-17  Tom Tromey  <tom@tromey.com>
1216
1217         * tui/tui-layout.c (make_data_window): Remove.
1218         (show_data): Unify creation and re-initialization cases.
1219
1220 2019-07-17  Tom Tromey  <tom@tromey.com>
1221
1222         * tui/tui-layout.c (make_source_window, make_disasm_window):
1223         Remove.
1224         (show_data): Unify creation and re-initialization cases.
1225
1226 2019-07-17  Tom Tromey  <tom@tromey.com>
1227
1228         * tui/tui-layout.c (make_command_window): Remove.
1229         (show_source_disasm_command, show_source_or_disasm_and_command):
1230         Unify creation and re-initialization cases.
1231
1232 2019-07-17  Tom Tromey  <tom@tromey.com>
1233
1234         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1235         creation and re-initialization cases.
1236
1237 2019-07-17  Tom Tromey  <tom@tromey.com>
1238
1239         * tui/tui-regs.c (tui_get_register): Return void.
1240
1241 2019-07-17  Tom Tromey  <tom@tromey.com>
1242
1243         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1244         Simplify.
1245
1246 2019-07-17  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1249         resetting.
1250
1251 2019-07-17  Tom Tromey  <tom@tromey.com>
1252
1253         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1254         * tui/tui-regs.c (tui_reg_layout): New function.
1255         (tui_show_registers, tui_reg_command): Use it.
1256         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1257         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1258         parameters.
1259         (tui_layout_command): Remove.
1260
1261 2019-07-17  Tom Tromey  <tom@tromey.com>
1262
1263         * tui/tui-layout.h (tui/tui-layout): Return void.
1264         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1265
1266 2019-07-17  Tom Tromey  <tom@tromey.com>
1267
1268         * tui/tui-layout.c (show_source_disasm_command, show_data):
1269         Update.
1270         (reset_locator): Remove.
1271         (show_source_or_disasm_and_command): Update.
1272
1273 2019-07-17  Tom Tromey  <tom@tromey.com>
1274
1275         * tui/tui-source.c (tui_source_window_base::reset): Remove
1276         win_type parameter.
1277         * tui/tui-layout.c (make_command_window, make_source_window)
1278         (make_disasm_window, make_data_window)
1279         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1280         (reset_locator, show_source_or_disasm_and_command): Update.
1281         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1282         win_type parameter.
1283         (struct tui_source_window_base) <reset>: Likewise.
1284
1285 2019-07-17  Tom Tromey  <tom@tromey.com>
1286
1287         * tui/tui-layout.c (show_source_disasm_command): Use
1288         reset_locator.
1289         (reset_locator): New function.
1290         (init_and_make_win): Remove.
1291         (show_source_or_disasm_and_command): Use reset_locator.
1292
1293 2019-07-17  Tom Tromey  <tom@tromey.com>
1294
1295         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1296         condition.
1297         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1298         Remove condition.
1299         * tui/tui-source.c (tui_source_window_base::reset): New method.
1300         * tui/tui-layout.c (make_command_window): Don't call
1301         init_and_make_win.
1302         (make_source_window, make_disasm_window): Don't call
1303         make_source_or_disasm_window.
1304         (make_data_window): Don't call init_and_make_win.  Change calling
1305         convention.
1306         (show_source_disasm_command, show_data): Simplify.
1307         (make_source_or_disasm_window): Remove.
1308         (show_source_or_disasm_and_command): Simplify.
1309         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1310         (struct tui_source_window_base) <reset>: Likewise.
1311         <execution_info>: Remove initializer.
1312         * tui/tui-data.c (tui_source_window_base): Initialize
1313         execution_info.
1314
1315 2019-07-17  Tom Tromey  <tom@tromey.com>
1316
1317         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1318         variable.
1319
1320 2019-07-17  Tom Tromey  <tom@tromey.com>
1321
1322         * tui/tui.c (tui_rl_other_window): Update.
1323         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1324         superclass method first.  Always iterate over regs_content.
1325         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1326         method.
1327         * tui/tui-win.c (tui_set_focus_command): Update.
1328
1329 2019-07-17  Tom Tromey  <tom@tromey.com>
1330
1331         * tui/tui-win.c (tui_set_focus_command): Rename from
1332         tui_set_focus.  Call tui_enable.
1333         (tui_set_focus_command): Remove.
1334
1335 2019-07-17  Tom Tromey  <tom@tromey.com>
1336
1337         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1338         refresh_window.
1339         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1340         touchwin.
1341         (tui_data_window::refresh_window): Call refresh_window on data
1342         items.  Always call superclass refresh_window.
1343         (tui_win_info::refresh): Remove.
1344         (tui_source_window_base::refresh_window): Update.
1345         (tui_refresh_all): Update.
1346         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1347         refresh_window.
1348         (show_source_or_disasm_and_command): Likewise.
1349         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1350         (struct tui_source_window_base) <refresh>: Likewise.
1351
1352 2019-07-17  Tom Tromey  <tom@tromey.com>
1353
1354         * tui/tui-winsource.c (tui_clear_source_content)
1355         (tui_show_source_content): Update.
1356         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1357         whether content is empty.
1358         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1359         Remove.
1360
1361 2019-07-17  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1364         window's contents.
1365         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1366         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1367
1368 2019-07-17  Tom Tromey  <tom@tromey.com>
1369
1370         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1371         (struct tui_data_item_window): Update.
1372
1373 2019-07-17  Tom Tromey  <tom@tromey.com>
1374
1375         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1376         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1377         defines.
1378
1379 2019-07-17  Tom Tromey  <tom@tromey.com>
1380
1381         * tui/tui-winsource.h (tui_erase_source_content)
1382         (tui_clear_source_content): Remove "display_prompt" parameter.
1383         * tui/tui-winsource.c (tui_update_source_window_as_is)
1384         (tui_update_source_windows_with_addr): Update.
1385         (tui_clear_source_content): Remove "display_prompt" parameter.
1386         (tui_erase_source_content): Likewise.  Simplify.
1387         (tui_show_source_content): Update.
1388         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1389         * tui/tui-stack.c (tui_show_frame_info): Update.
1390         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1391         Remove defines.
1392
1393 2019-07-17  Tom Tromey  <tom@tromey.com>
1394
1395         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1396         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1397         parameter.
1398         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1399         parameter.
1400
1401 2019-07-17  Tom Tromey  <tom@tromey.com>
1402
1403         * tui/tui-winsource.c (tui_clear_source_content)
1404         (tui_show_source_content, tui_show_exec_info_content)
1405         (tui_clear_exec_info_content): Update.
1406         * tui/tui-stack.c (tui_show_locator_content): Update.
1407         (tui_show_frame_info): Update.
1408         * tui/tui-source.h (tui_source_window): Don't declare.
1409         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1410         from tui_source_is_displayed.
1411         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1412         Remove field.
1413         (struct tui_source_window_base) <content_in_use>: New field.  Now
1414         bool.
1415         (struct tui_source_window) <showing_source_p>: New method.
1416         (TUI_SRC_WIN): Change cast.
1417         * tui/tui-data.c (tui_initialize_static_data): Update.
1418
1419 2019-07-17  Tom Tromey  <tom@tromey.com>
1420
1421         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1422         location_matches_p.
1423         * tui/tui-source.c (tui_source_window::location_matches_p): New
1424         method.
1425         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1426         method.
1427         * tui/tui-data.h (struct tui_source_window_base)
1428         <location_matches_p>: New method.
1429         (struct tui_source_window, struct tui_disasm_window)
1430         <location_matches_p>: Likewise.
1431
1432 2019-07-17  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-win.c (tui_set_win_height_command): Rename from
1435         tui_set_win_height.
1436         (tui_set_win_height_command): Remove.
1437
1438 2019-07-17  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-source.c (tui_source_window): New constructor.  Add
1441         observer.
1442         (~tui_source_window): New destructor.
1443         (tui_source_window::style_changed): New method.
1444         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1445         (tui_attach_detach_observers): Update.
1446         * tui/tui-data.h (struct tui_source_window): Make constructor not
1447         inline.  Add destructor.
1448         (struct tui_source_window) <style_changed>: New method.
1449         <m_observable>: New member.
1450
1451 2019-07-17  Tom Tromey  <tom@tromey.com>
1452
1453         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1454         * tui/tui-win.c (tui_resize_all): Fix typo.
1455
1456 2019-07-17  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1459         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1460         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1461         * tui/tui-win.c (window_name_completer): Use foreach.
1462         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1463         (update_tab_width): Likewise.
1464         * tui/tui-layout.c (show_layout): Update.
1465         * tui/tui-data.h (class tui_window_iterator): New.
1466         (struct all_tui_windows): New.
1467         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1468
1469 2019-07-17  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1472         parameter.  Don't reference globals.
1473         (tui_reg_command): Update.
1474
1475 2019-07-17  Tom Tromey  <tom@tromey.com>
1476
1477         * tui/tui-regs.c (tui_show_registers): Simplify.
1478
1479 2019-07-17  Tom Tromey  <tom@tromey.com>
1480
1481         * tui/tui-regs.c (tui_show_registers): Update.
1482         (tui_show_register_group): Add win_info parameter.
1483
1484 2019-07-17  Tom Tromey  <tom@tromey.com>
1485
1486         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1487         Rename from tui_display_reg_element_at_line.
1488         (tui_data_window::display_registers_from_line): Update.
1489         * tui/tui-data.h (struct tui_data_window)
1490         <display_reg_element_at_line>: New method.
1491
1492 2019-07-17  Tom Tromey  <tom@tromey.com>
1493
1494         * tui/tui-regs.h (tui_display_registers_from)
1495         (tui_display_registers_from_line): Don't declare.
1496         * tui/tui-windata.c (tui_data_window::display_all_data)
1497         (tui_data_window::refresh_all)
1498         (tui_data_window::do_scroll_vertical): Update.
1499         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1500         from tui_display_registers_from.
1501         (tui_display_reg_element_at_line): Update.
1502         (tui_data_window::display_registers_from_line): Rename from
1503         tui_display_registers_from_line.
1504         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1505         display_registers_from_line>: New methods.
1506
1507 2019-07-17  Tom Tromey  <tom@tromey.com>
1508
1509         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1510         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1511         from tui_erase_data_content.
1512         (tui_data_window::display_all_data)
1513         (tui_data_window::refresh_all)
1514         (tui_data_window::do_scroll_vertical): Update.
1515         * tui/tui-regs.c (tui_show_registers): Update.
1516         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1517         New method.
1518
1519 2019-07-17  Tom Tromey  <tom@tromey.com>
1520
1521         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1522         declare.
1523         * tui/tui-windata.c
1524         (tui_data_window::delete_data_content_windows): Rename from
1525         tui_delete_data_content_windows.
1526         (tui_data_window::display_all_data)
1527         (tui_data_window::do_scroll_vertical): Update.
1528         * tui/tui-data.h (struct tui_data_window)
1529         <delete_data_content_windows>: New method.
1530
1531 2019-07-17  Tom Tromey  <tom@tromey.com>
1532
1533         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1534         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1535
1536 2019-07-17  Tom Tromey  <tom@tromey.com>
1537
1538         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1539         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1540         from tui_display_all_data.
1541         * tui/tui-win.c
1542         (tui_data_window::do_make_visible_with_new_height): Update.
1543         * tui/tui-regs.c (tui_show_registers): Update.
1544         * tui/tui-layout.c (tui_set_layout): Update.
1545         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1546         method.
1547
1548 2019-07-17  Tom Tromey  <tom@tromey.com>
1549
1550         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1551         * tui/tui-windata.c (tui_display_data_from): Remove.
1552         (tui_data_window::refresh_all): Update.
1553
1554 2019-07-17  Tom Tromey  <tom@tromey.com>
1555
1556         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1557         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1558         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1559         tui_display_registers_from_line.
1560         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1561         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1562         "force_display" parameter.
1563
1564 2019-07-17  Tom Tromey  <tom@tromey.com>
1565
1566         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1567         declare.
1568         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1569         Rename from tui_first_reg_element_no_inline.
1570         (tui_display_reg_element_at_line)
1571         (tui_display_registers_from_line): Update.
1572         * tui/tui-data.h (struct tui_data_window)
1573         <first_reg_element_no_inline>: New method.
1574
1575 2019-07-17  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui-windata.c (tui_display_data_from)
1578         (tui_data_window::do_scroll_vertical): Update.
1579         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1580         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1581         Rename from tui_line_from_reg_element_no.
1582         (tui_display_registers_from_line): Update.
1583         * tui/tui-data.h (struct tui_data_window)
1584         <line_from_reg_element_no>: New method.
1585
1586 2019-07-17  Tom Tromey  <tom@tromey.com>
1587
1588         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1589         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1590         tui_last_regs_line_no.
1591         (tui_display_reg_element_at_line)
1592         (tui_display_registers_from_line): Update.
1593         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1594         method.
1595
1596 2019-07-17  Tom Tromey  <tom@tromey.com>
1597
1598         PR tui/24722:
1599         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1600         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1601         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1602         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1603         (tui_update_breakpoint_info): Likewise.
1604         * tui/tui-hooks.c (tui_event_create_breakpoint)
1605         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1606         Update.
1607
1608 2019-07-17  Tom Tromey  <tom@tromey.com>
1609
1610         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1611
1612 2019-07-17  Tom Tromey  <tom@tromey.com>
1613
1614         * tui/tui-winsource.c (tui_update_source_window_as_is)
1615         (tui_update_source_windows_with_addr): Update.
1616         * tui/tui-source.h (tui_set_source_content)
1617         (tui_show_symtab_source): Add "win_info" parameter.
1618         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1619         parameter.
1620         (tui_show_symtab_source): Likewise.
1621
1622 2019-07-17  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-wingeneral.c
1625         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1626
1627 2019-07-17  Tom Tromey  <tom@tromey.com>
1628
1629         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1630         (struct tui_cmd_window) <can_scroll>: New method.
1631         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1632         method.
1633
1634 2019-07-17  Tom Tromey  <tromey@adacore.com>
1635
1636         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1637         do_field_signed>: Rename.  Change type of "value".
1638         * ui-out.c (ui_out::field_signed): Rename from field_int.
1639         Change type of "value".
1640         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1641         type of "value".
1642         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1643         do_field_int.  Change type of "value".
1644         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1645         do_field_int.  Change type of "value".
1646         * tracepoint.c (trace_status_mi, tfind_1)
1647         (print_one_static_tracepoint_marker): Update.
1648         * thread.c (print_thread_info_1, print_selected_thread_frame):
1649         Update.
1650         * stack.c (print_frame, print_frame_info): Update.
1651         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1652         Update.
1653         * source.c (print_source_lines_base): Update.
1654         * skip.c (info_skip_command): Update.
1655         * record-btrace.c (btrace_ui_out_decode_error)
1656         (btrace_call_history_src_line): Update.
1657         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1658         Update.
1659         * progspace.c (print_program_space): Update.
1660         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1661         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1662         do_field_int.  Change type of "value".
1663         * mi/mi-out.c (mi_ui_out::do_table_begin)
1664         (mi_ui_out::do_table_header): Update.
1665         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1666         type of "value".
1667         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1668         (mi_cmd_data_list_changed_registers, output_register)
1669         (mi_cmd_data_read_memory, mi_load_progress)
1670         (mi_cmd_trace_frame_collected): Update.
1671         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1672         Update.
1673         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1674         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1675         (mi_cmd_var_list_children, varobj_update_one): Update.
1676         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1677         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1678         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1679         * inferior.c (print_inferior): Update.
1680         * gdb_bfd.c (print_one_bfd): Update.
1681         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1682         Update.
1683         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1684         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1685         do_field_int.  Change type of "value".
1686         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1687         do_field_int.  Change type of "value".
1688         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1689         (print_one_breakpoint_location, print_it_catch_fork)
1690         (print_one_catch_fork, print_it_catch_vfork)
1691         (print_one_catch_vfork, print_it_catch_solib)
1692         (print_it_catch_exec, print_it_ranged_breakpoint)
1693         (print_mention_watchpoint, print_mention_masked_watchpoint)
1694         (bkpt_print_it, update_static_tracepoint): Update.
1695         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1696         * break-catch-syscall.c (print_it_catch_syscall): Update.
1697         * ada-tasks.c (print_ada_task_info): Update.
1698         * ada-lang.c (print_it_exception, print_mention_exception):
1699         Update.
1700
1701 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1702
1703         PR breakpoints/24541
1704         * gdbarch.c: Regenerate.
1705         * gdbarch.h: Regenerate.
1706         * gdbarch.sh: Adjust return type and parameter types for
1707         'stap_adjust_register'.
1708         (i386_stap_adjust_register): Adjust signature and return new
1709         register name.
1710         * stap-probe.c (stap_parse_register_operand): Adjust use of
1711         'gdbarch_stap_adjust_register'.
1712
1713 2019-07-17  Tom Tromey  <tromey@adacore.com>
1714
1715         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1716         declare VEC.
1717         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1718         std::vector.
1719         (struct s390_process_info): Add initializers.
1720         (s390_add_process): Use new.
1721         (s390_linux_nat_target::low_forget_process): Use delete.
1722         (s390_linux_nat_target::low_new_fork)
1723         (s390_linux_nat_target::stopped_by_watchpoint)
1724         (s390_linux_nat_target::low_prepare_to_resume)
1725         (s390_linux_nat_target::insert_watchpoint)
1726         (s390_linux_nat_target::insert_hw_breakpoint)
1727         (s390_linux_nat_target::remove_watchpoint)
1728         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1729
1730 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1731
1732         * aarch64-fbsd-nat.c: Include regcache.h.
1733         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1734         argument.
1735         (aarch64_fbsd_nat_target::fetch_registers)
1736         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1737         variable.
1738         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1739
1740 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1741
1742         * fbsd-nat.c: Include gdbarch.h.
1743
1744 2019-07-15  Tom Tromey  <tromey@adacore.com>
1745
1746         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1747
1748 2019-07-15  Tom Tromey  <tromey@adacore.com>
1749
1750         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1751         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1752         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1753         * cli-out.c (cli_ui_out::do_field_int): New method.
1754         * ui-out.c (ui_out::field_unsigned): New method.
1755         * symfile.c (generic_load): Use field_unsigned.
1756         (print_transfer_performance): Likewise.
1757         * record-btrace.c (ui_out_field_uint): Remove.
1758         (btrace_call_history_insn_range, btrace_call_history): Use
1759         field_unsigned.
1760         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1761         field_unsigned.
1762         * ui-out.h (class ui_out) <field_unsigned>: New method.
1763         <do_field_unsigned>: Likewise.
1764
1765 2019-07-15  Tom Tromey  <tromey@adacore.com>
1766
1767         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1768         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1769         * target.c (flash_erase_command): Use field_string.
1770         * infrun.c (print_signal_received_reason): Use field_string.
1771         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1772         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1773         field_string.
1774         * ada-tasks.c (print_ada_task_info): Use field_string.
1775
1776 2019-07-15  Tom Tromey  <tromey@adacore.com>
1777
1778         * target.c (flash_erase_command): Use field_core_addr.
1779         * symfile.c (generic_load): Use field_core_addr.
1780         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1781         Use field_core_addr.
1782         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1783         field_core_addr.
1784
1785 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1786
1787         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1788         value if its desired type is smaller than a CORE_ADDR and signed.
1789
1790 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1791
1792         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1793         of changes to field names, and use new is_reference field to
1794         decide if a property is a reference or not.
1795         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1796         field.
1797         (struct dwarf2_property_baton): Update header comment, rename
1798         'referenced_type' to 'property_type' and update comments.
1799         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1800         default property type, store in property baton, update to take
1801         accound of renamed field.
1802         (read_func_scope): Update call to attr_to_dynamic_prop.
1803         (read_array_type): Likewise.
1804         (dwarf2_per_cu_addr_sized_int_type): New function.
1805         (read_subrange_index_type): Move type finding code to
1806         dwarf2_per_cu_addr_sized_int_type.
1807         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1808         (dwarf2_per_cu_addr_type): New function.
1809         (set_die_type): Update calls to attr_to_dynamic_prop.
1810
1811 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1812
1813         * dwarf2read.c (read_subrange_index_type): New function.
1814         (read_subrange_type): Move code into new function and call it.
1815         * gdbtypes.c (create_range_type): Add some asserts.
1816
1817 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1818
1819         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1820         update return statements.
1821         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1822         declaration, and update comment to match.
1823         * gdbtypes.c (resolve_dynamic_array): Update call to
1824         dwarf2_evaluate_property to match new return type.
1825
1826 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1827
1828         * valarith.c (value_subscripted_rvalue): Change lowerbound
1829         parameter type from int to LONGEST.
1830         * value.h (value_subscripted_rvalue): Likewise in declaration.
1831
1832 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1833
1834         * cli/cli-utils.c (info_print_command_completer): New function.
1835         * cli/cli-utils.h: Add 'completer.h' include, and forward
1836         declaration for 'struct cmd_list_element'.
1837         (info_print_command_completer): Declare.
1838         * stack.c (_initialize_stack): Add completer for 'info locals' and
1839         'info args'.
1840         * symtab.c (_initialize_symtab): Add completer for 'info
1841         variables' and 'info functions'.
1842         * NEWS: Mention completion for additional info commands.
1843
1844 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1845
1846         * cli/cli-utils.c (extract_info_print_args): Delete.
1847         (extract_arg_maybe_quoted): Delete.
1848         (info_print_options_defs): New variable.
1849         (make_info_print_options_def_group): New function.
1850         (extract_info_print_options): Define new function.
1851         * cli/cli-utils.h (extract_info_print_args): Delete.
1852         (struct info_print_options): New structure.
1853         (extract_info_print_options): Declare new function.
1854         * stack.c (info_locals_command): Update to use new
1855         extract_info_print_options, also add a header comment.
1856         (info_args_command): Likewise.
1857         * symtab.c (info_variables_command): Likewise.
1858         (info_functions_command): Likewise.
1859
1860 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1861
1862         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1863         to extract string arguments.
1864         * common/common-utils.c (extract_string_maybe_quoted): New function.
1865         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1866
1867 2019-07-11  Tom Tromey  <tromey@adacore.com>
1868
1869         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1870         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1871         * top.h (gdbinit): Don't declare.
1872         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1873         into...
1874         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1875         * top.c (gdb_init): Don't call init_cli_cmds.
1876         (gdbinit): Remove.
1877         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1878
1879 2019-07-11  Tom Tromey  <tromey@adacore.com>
1880
1881         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1882         after it has been moved.
1883
1884 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1885
1886         * valops.c (value_must_coerce_to_target): Change return type to
1887         bool.
1888         * value.h (value_must_coerce_to_target): Likewise.
1889
1890 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1891
1892         * breakpoint.c (is_hardware_watchpoint): Remove
1893         forward-declaration.
1894         (is_masked_watchpoint): Change return type to bool.
1895         (is_tracepoint): Likewise.
1896         (is_breakpoint): Likewise.
1897         (is_hardware_watchpoint): Likewise.
1898         (is_watchpoint): Likewise.
1899         (is_no_memory_software_watchpoint): Likewise.
1900         (is_catchpoint): Likewise.
1901         (breakpoint_1): Make FILTER parameter's return type bool.
1902         is_masked_watchpoint): Change return type to bool.
1903         (save_breakpoints): Make FILTER parameter's return type bool.
1904         * breakpoint.h (is_breakpoint): Change return type to bool.
1905         (is_watchpoint): Likewise.
1906         (is_catchpoint): Likewise.
1907         (is_tracepoint): Likewise.
1908
1909 2019-07-10  Tom Tromey  <tom@tromey.com>
1910
1911         * defs.h: Don't include gdbarch.h.
1912         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1913         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1914         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1915         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1916         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1917         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1918         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1919         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1920         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1921         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1922         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1923         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1924         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1925         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1926         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1927         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1928         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1929         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1930         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1931         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1932         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1933         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1934         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1935         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1936         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1937         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1938         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1939
1940 2019-07-10  Tom Tromey  <tromey@adacore.com>
1941
1942         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1943         * breakpoint.c (init_ada_exception_breakpoint): Register as
1944         bp_catchpoint.
1945         (print_one_breakpoint_location, print_one_breakpoint): Use
1946         is_ada_exception_catchpoint.
1947         * ada-lang.c (class ada_catchpoint_location): Pass
1948         bp_loc_software_breakpoint to bp_location constructor.
1949         (is_ada_exception_catchpoint): New function.
1950
1951 2019-07-10  Tom Tromey  <tromey@adacore.com>
1952
1953         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1954         VEC.
1955         (struct arm_exidx_entry): New method operator<.
1956         (struct arm_exidx_data) <section_maps>: Change type.
1957         (arm_exidx_data_free): Remove.
1958         (arm_exidx_data_key): Change type.  Move lower.
1959         (arm_exidx_new_objfile): Update.
1960         (arm_compare_exidx_entries): Remove.
1961         (arm_find_exidx_entry, _initialize_arm_tdep)
1962
1963 2019-07-10  Tom Tromey  <tromey@adacore.com>
1964
1965         * solib-spu.c (ocl_program_data_key): Change type.
1966         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1967         Update.
1968
1969 2019-07-10  Tom Tromey  <tromey@adacore.com>
1970
1971         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1972         (struct solib_aix_inferior_data) <library_list>: Change type.
1973         (solib_aix_inferior_data_handle): Change type.
1974         (get_solib_aix_inferior_data): Update.
1975         (solib_aix_free_library_list): Remove.
1976         (library_list_start_library): Update.
1977         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1978         return type.
1979         (solib_aix_get_library_list)
1980         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1981         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1982
1983 2019-07-10  Tom Tromey  <tromey@adacore.com>
1984
1985         * solib-dsbt.c (struct dsbt_info): Add initializers.
1986         (solib_dsbt_pspace_data): Change type.
1987         (dsbt_pspace_data_cleanup): Remove.
1988         (get_dsbt_info, _initialize_dsbt_solib): Update.
1989
1990 2019-07-10  Tom Tromey  <tromey@adacore.com>
1991
1992         * spu-tdep.c (spu_overlay_data): Change type.
1993         (spu_get_overlay_table, spu_overlay_new_objfile)
1994         (_initialize_spu_tdep): Update.
1995
1996 2019-07-10  Tom Tromey  <tromey@adacore.com>
1997
1998         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1999         destructor.
2000         (dbx_objfile_data_key): Change type and declare later.
2001         (DBX_SYMFILE_INFO): Rewrite.
2002         * dbxread.c (dbx_objfile_data_key): Change type.
2003         (dbx_symfile_init): Update.
2004         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2005         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2006         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2007
2008 2019-07-10  Tom Tromey  <tromey@adacore.com>
2009
2010         * jit.c (jit_program_space_key): Change type.  Move lower.
2011         (get_jit_program_space_data): Update.
2012         (jit_program_space_data_cleanup): Remove.
2013         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2014         Update.
2015         (struct jit_program_space_data): Add initializers.
2016
2017 2019-07-10  Tom Tromey  <tromey@adacore.com>
2018
2019         * solib-darwin.c (struct darwin_info): Add initializers.
2020         (solib_darwin_pspace_data): Change type.
2021         (darwin_pspace_data_cleanup): Remove.
2022         (get_darwin_info, _initialize_darwin_solib): Update.
2023
2024 2019-07-10  Tom Tromey  <tromey@adacore.com>
2025
2026         * remote-sim.c (struct sim_inferior_data): Add initializers,
2027         constructor, and destructor.
2028         (sim_inferior_data_key): Change type.  Move lower.
2029         (check_for_duplicate_sim_descriptor): Update.
2030         (get_sim_inferior_data): Use new.  Update.
2031         (~sim_inferior_data_cleanup): Rename from
2032         sim_inferior_data_cleanup.  Simplify.
2033         (gdbsim_close_inferior, simulator_command)
2034         (sim_command_completer, _initialize_remote_sim): Update.
2035         (next_pid, INITIAL_PID): Move earlier.
2036
2037 2019-07-10  Tom Tromey  <tromey@adacore.com>
2038
2039         * python/python-internal.h (create_thread_object): Return
2040         gdbpy_ref.
2041         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2042         * python/py-inferior.c (struct threadlist_entry): Add
2043         constructor.
2044         <thread_obj>: Now a gdbpy_ref.
2045         (thread_to_thread_object): Update.
2046         (add_thread_object): Use new.
2047         (delete_thread_object): Use delete.
2048         (infpy_threads): Update.
2049         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2050         GIL.
2051
2052 2019-07-10  Tom Tromey  <tromey@adacore.com>
2053
2054         * valops.c (value_cast): Specialize error message for Ada.
2055
2056 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2057
2058         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2059
2060 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2061
2062         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2063         bpstat_should_step): Return bool, adjust comments.
2064         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2065         bpstat_should_step): Likewise.
2066
2067 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2068
2069         * features/Makefile: Use feature target descriptions for Arm.
2070         * features/arm/arm-core.c: Generate new file.
2071         * features/arm/arm-fpa.c: Likewise.
2072         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2073         * features/arm/arm-m-profile.c: Likewise.
2074         * features/arm/arm-vfpv2.c: Likewise.
2075         * features/arm/arm-vfpv3.c: Likewise.
2076         * features/arm/xscale-iwmmxt.c: Likewise.
2077         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2078
2079 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2080
2081         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2082         ptrace earlier.
2083
2084 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2085
2086         * features/aarch64-pauth.c: Regenerate.
2087
2088 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2089
2090         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2091         bool.
2092         (bpstat_what): Use false instead of 0.
2093
2094 2019-07-09  Pedro Alves  <palves@redhat.com>
2095
2096         * break-catch-throw.c (is_exception_catchpoint): New.
2097         * breakpoint.c (print_one_breakpoint_location): New parameter
2098         'raw_loc'.  Handle it.  Use
2099         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2100         looking at the breakpoint's type.
2101         (print_one_breakpoint): If handling "maint info breakpoints", also
2102         print locations of exception catchpoints.
2103         * breakpoint.h (is_exception_catchpoint): Declare.
2104
2105 2019-07-09  Pedro Alves  <palves@redhat.com>
2106
2107         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2108         "addr" field.
2109         (allocate_location_exception_catchpoint): New.
2110         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2111         (initialize_throw_catchpoint_ops): Install
2112         allocate_location_exception_catchpoint as allocate_location
2113         method.
2114         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2115         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2116         bp_loc_other.
2117         (breakpoint_address_is_meaningful): Delete.
2118         (bl_address_is_meaningful): New.
2119         (breakpoint_locations_match): Adjust comment.
2120         (bp_location_from_bp_type): New, factored out of...
2121         (bp_location::bp_location(breakpoint *)): ... this.
2122         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2123         factored out of...
2124         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2125         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2126         breakpoint_address_is_meaningful.
2127         (bp_locations_compare): Adjust comment.
2128         (update_global_location_list): Use bl_address_is_meaningful
2129         instead of breakpoint_address_is_meaningful.
2130         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2131         explicit.
2132         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2133         * python/py-breakpoint.c (bppy_get_location): No longer check
2134         whether location is null.
2135
2136 2019-07-09  Pedro Alves  <palves@redhat.com>
2137
2138         PR c++/15468
2139         * breakpoint.c (print_one_breakpoint_location): Remove
2140         single-location assert.
2141
2142 2019-07-09  Tom Tromey  <tom@tromey.com>
2143
2144         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2145         * configure: Rebuild.
2146         * configure.ac: Change common to gdbsupport.
2147         * gdbsupport: Rename from common.
2148         * acinclude.m4: Change common to gdbsupport.
2149         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2150         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2151         gdbsupport.
2152         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2153         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2154         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2155         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2156         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2157         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2158         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2159         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2160         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2161         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2162         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2163         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2164         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2165         coff-pe-read.c, command.h, compile/compile-c-support.c,
2166         compile/compile-c.h, compile/compile-cplus-symbols.c,
2167         compile/compile-cplus-types.c, compile/compile-cplus.h,
2168         compile/compile-loc2c.c, compile/compile.c, completer.c,
2169         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2170         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2171         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2172         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2173         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2174         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2175         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2176         features/aarch64-core.c, features/aarch64-fpu.c,
2177         features/aarch64-pauth.c, features/aarch64-sve.c,
2178         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2179         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2180         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2181         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2182         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2183         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2184         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2185         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2186         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2187         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2188         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2189         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2190         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2191         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2192         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2193         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2194         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2195         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2196         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2197         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2198         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2199         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2200         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2201         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2202         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2203         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2204         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2205         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2206         minsyms.c, mips-linux-tdep.c, namespace.h,
2207         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2208         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2209         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2210         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2211         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2212         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2213         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2214         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2215         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2216         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2217         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2218         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2219         procfs.c, producer.c, progspace.h, psymtab.h,
2220         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2221         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2222         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2223         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2224         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2225         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2226         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2227         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2228         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2229         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2230         target-memory.c, target.c, target.h, target/waitstatus.c,
2231         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2232         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2233         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2234         unittests/array-view-selftests.c,
2235         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2236         unittests/common-utils-selftests.c,
2237         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2238         unittests/format_pieces-selftests.c,
2239         unittests/function-view-selftests.c,
2240         unittests/lookup_name_info-selftests.c,
2241         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2242         unittests/mkdir-recursive-selftests.c,
2243         unittests/observable-selftests.c,
2244         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2245         unittests/parse-connection-spec-selftests.c,
2246         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2247         unittests/scoped_fd-selftests.c,
2248         unittests/scoped_mmap-selftests.c,
2249         unittests/scoped_restore-selftests.c,
2250         unittests/string_view-selftests.c, unittests/style-selftests.c,
2251         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2252         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2253         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2254         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2255         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2256         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2257
2258 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2259
2260         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2261         bool value.
2262         (decode_digits_ordinary): Set explicit_line field in sal.
2263         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2264         symtab_and_line that was set on an explicit line number in
2265         assembler code.  Do always update the recorded symtab and line if
2266         we do skip the prologue.
2267
2268 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2269
2270         * breakpoint.c (set_breakpoint_location_function): Remove
2271         explicit_loc parameter.
2272         (momentary_breakpoint_from_master): Update call to
2273         set_breakpoint_location_function.
2274         (add_location_to_breakpoint): Likewise.
2275
2276 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2277
2278         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2279         required features based on default bfd type when no specific bfd
2280         is present.
2281
2282 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2283
2284         * NEWS: Mention that GDB printf and eval commands can now print
2285         C-style and Ada-style convenience var strings without
2286         calling the inferior.
2287         * printcmd.c (printf_c_string): Locally print GDB internal var
2288         instead of transiting via the inferior.
2289         (printf_wide_c_string): Likewise.
2290
2291 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2292
2293         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2294
2295 2019-07-04  Tom Tromey  <tom@tromey.com>
2296
2297         PR tui/24724:
2298         * tui/tui-winsource.c (tui_clear_source_content): Update.
2299         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2300         (tui_update_breakpoint_info): Update.
2301         (tui_set_exec_info_content): Update.
2302         * tui/tui-source.c (tui_set_source_content_nil): Update.
2303         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2304         has_break.
2305         * tui/tui-data.h (enum tui_bp_flag): New.
2306         (tui_bp_flags): New enum flags type.
2307         (struct tui_source_element) <break_mode>: Change type.  Rename
2308         from has_break.
2309         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2310         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2311         constants.
2312         * tui/tui-winsource.h: Fix comment.
2313
2314 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2315
2316         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2317         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2318         (store_fpregs_to_thread)
2319         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2320         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2321         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2322         (IWMMXT_REGS_SIZE): Add define.
2323         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2324         (fetch_vfp_regs, store_vfp_regs)
2325         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2326         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2327
2328 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2329
2330         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2331         defines.
2332         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2333         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2334         (ARM_INT_REGISTER_SIZE): ...to this.
2335         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2336         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2337         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2338         (arm_linux_collect_gregset, supply_nwfpe_register)
2339         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2340         defines.
2341         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2342         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2343         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2344         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2345         (arm_return_in_memory, arm_store_return_value)
2346         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2347         (arm_record_ld_st_multiple): Likewise.
2348         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2349         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2350
2351 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2352
2353         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2354         AARCH64_DISPLACED_MODIFIED_INSNS.
2355         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2356         (aarch64_displaced_step_copy_insn): Likewise.
2357         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2358         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2359         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2360         ARM_DISPLACED_MODIFIED_INSNS.
2361         * arm-tdep.c (arm_gdbarch_init): Likewise.
2362         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2363         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2364         (struct arm_displaced_step_closure): Use
2365         ARM_DISPLACED_MODIFIED_INSNS.
2366
2367 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2368
2369         * features/Makefile: Remove unused xml files.
2370         * features/aarch64.xml: Remove.
2371         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2372         * features/i386/amd64-avx-avx512.xml: Remove.
2373         * features/i386/amd64-avx-linux.xml: Remove.
2374         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2375         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2376         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2377         * features/i386/amd64-avx-mpx.xml: Remove.
2378         * features/i386/amd64-avx.xml: Remove.
2379         * features/i386/amd64-linux.xml: Remove.
2380         * features/i386/amd64-mpx-linux.xml: Remove.
2381         * features/i386/amd64-mpx.xml: Remove.
2382         * features/i386/amd64.xml: Remove.
2383         * features/i386/i386-avx-avx512-linux.xml: Remove.
2384         * features/i386/i386-avx-avx512.xml: Remove.
2385         * features/i386/i386-avx-linux.xml: Remove.
2386         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2387         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2388         * features/i386/i386-avx-mpx-linux.xml: Remove.
2389         * features/i386/i386-avx-mpx.xml: Remove.
2390         * features/i386/i386-avx.xml: Remove.
2391         * features/i386/i386-linux.xml: Remove.
2392         * features/i386/i386-mmx-linux.xml: Remove.
2393         * features/i386/i386-mmx.xml: Remove.
2394         * features/i386/i386-mpx-linux.xml: Remove.
2395         * features/i386/i386-mpx.xml: Remove.
2396         * features/i386/i386.xml: Remove.
2397         * features/i386/x32-avx-avx512-linux.xml: Remove.
2398         * features/i386/x32-avx-linux.xml: Remove.
2399         * features/i386/x32-linux.xml: Remove.
2400
2401 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2402
2403         * regformats/aarch64.dat: Remove.
2404         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2405         * regformats/i386/amd64-avx-linux.dat: Remove.
2406         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2407         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2408         * regformats/i386/amd64-linux.dat: Remove.
2409         * regformats/i386/amd64-mpx-linux.dat: Remove.
2410         * regformats/i386/amd64.dat: Remove.
2411         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2412         * regformats/i386/i386-avx-linux.dat: Remove.
2413         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2414         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2415         * regformats/i386/i386-linux.dat: Remove.
2416         * regformats/i386/i386-mmx-linux.dat: Remove.
2417         * regformats/i386/i386-mpx-linux.dat: Remove.
2418         * regformats/i386/i386.dat: Remove.
2419         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2420         * regformats/i386/x32-avx-linux.dat: Remove.
2421         * regformats/i386/x32-linux.dat: Remove.
2422
2423 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2424
2425         * aarch64-tdep.c: Remove xml self tests.
2426         * amd64-linux-tdep.c: Likewise.
2427         * amd64-tdep.c: Likewise.
2428         * i386-linux-tdep.c: Likewise.
2429         * i386-tdep.c: Likewise.
2430
2431 2019-07-03  Pedro Alves  <palves@redhat.com>
2432
2433         PR cli/24732
2434         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2435         (pipe_cmd_option_defs): New.
2436         (make_pipe_cmd_options_def_group): New.
2437         (pipe_command): Use gdb::option::process_options.
2438         (pipe_command_completer): New function.
2439         (_initialize_cli_cmds): Install completer for "pipe" command.
2440
2441 2019-07-03  Pedro Alves  <palves@redhat.com>
2442
2443         * cli/cli-option.c (union option_value) <string>: New field.
2444         (struct option_def_and_value): Add ctor, move ctor, dtor and
2445         use DISABLE_COPY_AND_ASSIGN.
2446         (option_def_and_value::clear_value): New.
2447         (parse_option, save_option_value_in_ctx, get_val_type_str)
2448         (add_setshow_cmds_for_options): Handle var_string.
2449         * cli-option.h (union option_def::var_address) <string>: New
2450         field.
2451         (struct string_option_def): New.
2452         * maint-test-options.c (struct test_options_opts): Add default
2453         ctor and use DISABLE_COPY_AND_ASSIGN.
2454         <string_opt>: New field.
2455         (test_options_opts::~test_options_opts): New.
2456         (test_options_opts::dump): Also dump "-string".
2457         (test_options_option_defs): Install "string.
2458
2459 2019-07-03  Pedro Alves  <palves@redhat.com>
2460
2461         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2462         option_value with a null enumeration.
2463         (complete_options): Save the option values in the context.
2464         (save_option_value_in_ctx): New, factored out from ...
2465         (process_options): ... here.
2466         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2467         of the function.
2468         * maint-test-options.c (test_options_opts::dump): New, factored
2469         out from ...
2470         (maintenance_test_options_command_mode): ... here.
2471         (maintenance_test_options_command_completion_result): Delete.
2472         (maintenance_test_options_command_completion_text): Update
2473         comment.
2474         (maintenance_show_test_options_completion_result): Change
2475         prototype.  Just print
2476         maintenance_test_options_command_completion_text.
2477         (save_completion_result): New.
2478         (maintenance_test_options_completer_mode): Pass options context to
2479         complete_options, and then save a dump.
2480         (_initialize_maint_test_options): Use add_cmd to install "maint
2481         show test-options-completion-result".
2482
2483 2019-07-03  Pedro Alves  <palves@redhat.com>
2484
2485         * NEWS (New commands): Mention "with" and "maint with".
2486         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2487         (with_command, with_command_completer): New.
2488         (pipe_command): Adjust to new repeat_previous
2489         interface.
2490         (_initialize_cli_cmds): Install the "with" command and its "w"
2491         alias.
2492         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2493         declarations.
2494         * cli/cli-setshow.c (parse_cli_var_uinteger)
2495         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2496         argument strings for all var_types.
2497         (get_setshow_command_value_string): New, factored out from ...
2498         (do_show_command): ... this.
2499         * cli/cli-setshow.h: Include <string>.
2500         (get_setshow_command_value_string): Declare.
2501         * command.h (repeat_previous): Now returns const char *.  Adjust
2502         comment.
2503         * maint.c: Include "cli/cli-cmds.h".
2504         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2505         (_initialize_maint_cmds): Register the "maintenance with" command.
2506         * top.c (repeat_previous): Move bits from pipe_command here:
2507         Return the saved command line, if any; error out if there's no
2508         command to relaunch.
2509
2510 2019-07-03  Pedro Alves  <palves@redhat.com>
2511
2512         * NEWS (New commands): Mention "maint set/show test-settings"
2513         instead of "maint test-settings".
2514         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2515         (maintenance_test_settings_set_list): Rename to ...
2516         (maintenance_set_test_settings_list): ... this.
2517         (maintenance_test_settings_show_list): Rename to  ...
2518         (maintenance_show_test_settings_list): ... this.
2519         (maintenance_test_settings_cmd): Delete.
2520         (maintenance_test_settings_set_cmd): ...
2521         (maintenance_set_test_settings_cmd): ... this.
2522         (maintenance_test_settings_show_cmd): ...
2523         (maintenance_show_test_settings_cmd): ... this.
2524         (maintenance_test_settings_show_value_cmd):
2525         (maintenance_show_test_settings_value_cmd): ... this.
2526         (_initialize_maint_test_settings): No longer install the "maint
2527         test-settings" prefix command.  Rename "maint test-settings set"
2528         to "maint set test-settings", and "maint test-settings show" to
2529         "maint show test-settings".  Adjust all subcommands.
2530
2531 2019-07-03  Pedro Alves  <palves@redhat.com>
2532
2533         * maint-test-settings.c: Fix file's intro comment.  Replace all
2534         references to "test-options" with references to "test-settings",
2535         in comments.
2536
2537 2019-07-03  Pedro Alves  <palves@redhat.com>
2538
2539         * maint-test-settings.c (maintenance_test_settings_xxx)
2540         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2541         New.
2542         (maintenance_test_settings_enums): Use them.
2543         (maintenance_test_settings_enum): Default to
2544         maintenance_test_settings_xxx.
2545         (_initialize_maint_test_settings): Initialize
2546         MAINTENANCE_TEST_SETTINGS_FILENAME.
2547
2548 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2549
2550         * breakpoint.h (remove_breakpoints_inf): Change return type to
2551         void, move function documentation here.
2552         * breakpoint.c (remove_breakpoints_inf): Change return type to
2553         void, move function documentation to header.
2554
2555 2019-07-02  Pedro Alves  <palves@redhat.com>
2556
2557         * NEWS (Completion improvements): Mention "info threads".
2558         * thread.c (struct info_threads_opts, info_threads_option_defs)
2559         (make_info_threads_options_def_group): New.
2560         (info_threads_command): Use gdb::option::process_options.
2561         (info_threads_command_completer): New.
2562         (_initialize_thread): Use gdb::option::build_help to build the
2563         help text for "info threads".
2564
2565 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2566
2567         * defs.h (generic_load): Move from here...
2568         * symfile.h (generic_load): ... to here.  Rename name parameter
2569         to args.
2570         * symfile.c (generic_load): Add comment.
2571
2572 2019-07-01  Tom Tromey  <tromey@adacore.com>
2573
2574         * dwarf2read.c
2575         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2576         declaration of without_params.  Fix formatting.
2577
2578 2019-07-01  Tom Tromey  <tromey@adacore.com>
2579
2580         * ada-exp.y (find_primitive_type): Update.
2581         * ada-lang.h (ada_lookup_symbol): Update.
2582         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2583         parameter.
2584         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2585
2586 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2587
2588         PR breakpoints/24541
2589         * gdbarch.c: Regenerate.
2590         * gdbarch.h: Regenerate.
2591         * gdbarch.sh: Add 'stap_adjust_register'.
2592         * i386-tdep.c: Include '<unordered_set>'.
2593         (i386_stap_adjust_register): New function.
2594         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2595         * stap-probe.c (stap_parse_register_operand): Call
2596         'gdbarch_stap_adjust_register'.
2597
2598 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2599
2600         PR python/24742
2601         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2602         * python/python.c (do_start_initialization): Use 'xmalloc'
2603         instead of 'PyMem_Malloc'.
2604
2605 2019-06-28  Tom Tromey  <tromey@adacore.com>
2606
2607         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2608         for Ada.
2609
2610 2019-06-27  Tom Tromey  <tromey@adacore.com>
2611
2612         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2613         objfile_key.
2614         (arm_find_mapping_symbol, arm_record_special_symbol)
2615         (_initialize_arm_tdep): Update.
2616         (arm_objfile_data_free): Remove.
2617
2618 2019-06-27  Tom Tromey  <tromey@adacore.com>
2619
2620         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2621         to cp_print_static_field.
2622
2623 2019-06-26  Tom Tromey  <tromey@adacore.com>
2624
2625         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2626         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2627         declare.
2628
2629 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2630
2631         * features/aarch64-core.c (create_feature_aarch64_core):
2632         Regenerate.
2633         * features/aarch64-core.xml: Add cpsr flags.
2634
2635 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2636
2637         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2638         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2639
2640 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2641
2642         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2643         field.
2644         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2645         use.
2646         (arm_record_special_symbol): Don't insert new symbol in sorted
2647         position, push it at the end.
2648
2649 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2650
2651         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2652         (arm_mapping_symbol_s): Remove.
2653         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2654         (arm_mapping_symbol_vec): New typedef.
2655         (struct arm_per_objfile): Add constructor.
2656         <section_maps>: Change type to
2657         std::unique_ptr<arm_mapping_symbol_vec[]>.
2658         (arm_compare_mapping_symbols): Remove.
2659         (arm_find_mapping_symbol): Adjust to section_maps type change.
2660         (arm_objfile_data_free): Call delete on arm_per_objfile.
2661         (arm_record_special_symbol): Adjust to section_maps type change.
2662         Allocate arm_per_objfile with new.
2663
2664 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2665
2666         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2667         with the command prefix.
2668
2669 2019-06-25  Tom Tromey  <tom@tromey.com>
2670
2671         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2672         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2673
2674 2019-06-25  Tom Tromey  <tom@tromey.com>
2675
2676         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2677         type.
2678         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2679         protected.
2680
2681 2019-06-25  Tom Tromey  <tom@tromey.com>
2682
2683         * tui/tui-winsource.c
2684         (tui_source_window_base::set_is_exec_point_at): Add check against
2685         LOA_ADDRESS.
2686
2687 2019-06-25  Tom Tromey  <tom@tromey.com>
2688
2689         * tui/tui-source.c (tui_set_source_content): Don't check before
2690         xfree.
2691         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2692
2693 2019-06-25  Tom Tromey  <tom@tromey.com>
2694
2695         * tui/tui-winsource.h (tui_update_source_window_as_is)
2696         (tui_alloc_source_buffer, tui_line_is_displayed)
2697         (tui_addr_is_displayed): Change type of win_info.
2698         * tui/tui-winsource.c (tui_update_source_window_as_is)
2699         (tui_clear_source_content, tui_show_source_line)
2700         (tui_show_source_content, tui_source_window_base::refill)
2701         (tui_source_window_base::set_is_exec_point_at)
2702         (tui_source_window_base::set_is_exec_point_at)
2703         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2704         (tui_alloc_source_buffer, tui_line_is_displayed)
2705         (tui_addr_is_displayed): Change type of win_info.  Update.
2706         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2707         (tui_source_window_base::do_make_visible_with_new_height):
2708         Update.
2709         * tui/tui-source.c (tui_set_source_content)
2710         (tui_set_source_content_nil)
2711         (tui_source_window::do_scroll_vertical): Update.
2712         * tui/tui-layout.c (show_layout): Update.
2713         * tui/tui-disasm.c (tui_set_disassem_content)
2714         (tui_disasm_window::do_scroll_vertical): Update.
2715         * tui/tui-data.h (tui_win_content): Remove.
2716         (struct tui_gen_win_info) <content, content_size>: Remove.
2717         (struct tui_source_element): Add initializers and destructor.
2718         (union tui_which_element, struct tui_win_element): Remove.
2719         (struct tui_source_window_base) <content>: New field.
2720         (struct tui_data_window): Remove destructor.
2721         (tui_alloc_content, tui_free_win_content)
2722         (tui_free_all_source_wins_content): Don't declare.
2723         * tui/tui-data.c (tui_initialize_static_data): Update.
2724         (init_content_element, tui_alloc_content): Remove.
2725         (~tui_gen_win_info): Update.
2726         (~tui_data_window, tui_free_all_source_wins_content)
2727         (tui_free_win_content, free_content, free_content_elements):
2728         Remove.
2729
2730 2019-06-25  Tom Tromey  <tom@tromey.com>
2731
2732         * tui/tui-winsource.h (tui_clear_source_content)
2733         (tui_erase_source_content, tui_show_source_content): Change type
2734         of win_info.
2735         * tui/tui-winsource.c (tui_clear_source_content)
2736         (tui_erase_source_content, tui_show_source_content): Change type
2737         of win_info.
2738         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2739         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2740         win_info.
2741         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2742         win_info.
2743         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2744
2745 2019-06-25  Tom Tromey  <tom@tromey.com>
2746
2747         * tui/tui-winsource.c (tui_clear_source_content)
2748         (tui_source_window_base::set_is_exec_point_at): Update.
2749         * tui/tui-source.c (tui_set_source_content_nil): Update.
2750         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2751         a bool.
2752         * tui/tui-data.c (init_content_element): Update.
2753
2754 2019-06-25  Tom Tromey  <tom@tromey.com>
2755
2756         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2757         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2758         * tui/tui-layout.c (init_and_make_win): Update.
2759         * tui/tui.h (enum tui_win_type): Update.
2760         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2761         tui_win_is_auxillary.
2762         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2763         tui_win_is_auxillary.
2764
2765 2019-06-25  Tom Tromey  <tom@tromey.com>
2766
2767         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2768         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2769         (tui_delete_data_content_windows, tui_display_all_data)
2770         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2771         Update.
2772         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2773         * tui/tui-regs.c (tui_last_regs_line_no)
2774         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2775         (tui_show_registers): Update.
2776         (tui_show_register_group): Return void.  Update.
2777         (tui_display_registers_from, tui_display_reg_element_at_line)
2778         (tui_display_registers_from_line, tui_check_register_values):
2779         Update.
2780         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2781         member.
2782         (struct tui_data_window) <regs_content>: Now a std::vector.
2783         <regs_content_count>: Remove.
2784         (tui_add_content_elements, tui_free_data_content): Don't declare.
2785         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2786         (init_content_element): Remove DATA_WIN case.  Add assert.
2787         (tui_add_content_elements): Remove.
2788         (tui_data_window): Update.
2789         (tui_free_data_content): Remove.
2790         (free_content_elements): Remove DATA_WIN case.
2791
2792 2019-06-25  Tom Tromey  <tom@tromey.com>
2793
2794         * tui/tui-data.c (tui_data_item_window): Update.
2795         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2796         * tui/tui-windata.c (tui_display_all_data)
2797         (tui_display_data_from_line): Update.
2798         (tui_check_data_values): Remove.
2799         * tui/tui-regs.c (tui_show_register_group)
2800         (tui_display_reg_element_at_line): Update.
2801         * tui/tui-hooks.c (tui_register_changed)
2802         (tui_refresh_frame_and_register_information): Call
2803         tui_check_register_values.
2804         * tui/tui-data.h (struct tui_data_window) <data_content,
2805         data_content_count, data_type>: Remove.
2806         (enum tui_data_type): Remove.
2807
2808         * tui/tui-data.c (tui_data_window::clear_detail)
2809         (~tui_data_window): Update.
2810
2811 2019-06-25  Tom Tromey  <tom@tromey.com>
2812
2813         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2814         declare.
2815         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2816         Rename from tui_first_data_item_displayed.  Update.
2817         (tui_data_window::refresh_all)
2818         (tui_data_window::do_scroll_vertical): Update.
2819         * tui/tui-data.h (struct tui_data_window)
2820         <first_data_item_displayed>: Declare new method.
2821
2822 2019-06-25  Tom Tromey  <tom@tromey.com>
2823
2824         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2825         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2826         contents...
2827         (tui_initialize_static_data): ...here.
2828
2829 2019-06-25  Tom Tromey  <tom@tromey.com>
2830
2831         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2832         (tui_display_registers_from, tui_check_register_values): Update.
2833         (tui_display_register): Remove win_info parameter; update.
2834         (tui_get_register): Change type of parameters.
2835         * tui/tui-data.h (struct tui_data_element): Remove.
2836         (union tui_which_element) <data>: Remove.
2837         <data_window>: Change type.
2838         (struct tui_data_item_window): New.
2839         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2840         case.  Add assert.
2841         (~tui_data_item_window): New destructor.
2842         (free_content_elements): Remove DATA_ITEM_WIN case.
2843
2844 2019-06-25  Tom Tromey  <tom@tromey.com>
2845
2846         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2847         Remove.
2848
2849 2019-06-25  Tom Tromey  <tom@tromey.com>
2850
2851         * tui/tui-data.h (struct tui_command_element): Remove.
2852         (union tui_which_element) <command>: Remove.
2853         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2854         assert.
2855         (free_content_elements): Remove CMD_WIN case.
2856
2857 2019-06-25  Tom Tromey  <tom@tromey.com>
2858
2859         * tui/tui-layout.c (tui_set_layout): Update.
2860         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2861         * tui/tui-data.c (layout_def): Update.
2862
2863 2019-06-25  Tom Tromey  <tom@tromey.com>
2864
2865         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2866         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2867         (tui_source_window_base::set_new_height): Update.
2868         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2869         Update.
2870         (tui_set_locator_fullname, tui_set_locator_info)
2871         (tui_show_frame_info): Update.
2872         * tui/tui-source.c (tui_set_source_content)
2873         (tui_source_is_displayed): Update.
2874         * tui/tui-layout.c (show_source_disasm_command, show_data)
2875         (show_source_or_disasm_and_command): Update.
2876         * tui/tui-disasm.c (tui_set_disassem_content)
2877         (tui_get_begin_asm_address): Update.
2878         * tui/tui-data.h (struct tui_locator_element): Remove.
2879         (union tui_which_element) <locator>: Remove.
2880         (struct tui_locator_window): New.
2881         (tui_locator_win_info_ptr): Change return type.
2882         * tui/tui-data.c (_locator): Change type.
2883         (tui_locator_win_info_ptr): Change return type.
2884         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2885         (tui_alloc_content): Add assert.
2886
2887 2019-06-25  Tom Tromey  <tom@tromey.com>
2888
2889         * tui/tui-winsource.c
2890         (tui_exec_info_window::maybe_allocate_content): New method.
2891         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2892         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2893         (make_source_or_disasm_window): Add cast.
2894         * tui/tui-data.h (union tui_which_element) <simple_string>:
2895         Remove.
2896         (struct tui_source_info): New.
2897         (struct tui_source_window_base) <execution_info>: Change type.
2898         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2899         case, and add assert.
2900         (tui_alloc_content): Add assert.
2901
2902 2019-06-25  Tom Tromey  <tom@tromey.com>
2903
2904         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2905         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2906         * tui/tui-data.c (tui_alloc_win_info): Remove.
2907
2908 2019-06-25  Tom Tromey  <tom@tromey.com>
2909
2910         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2911         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2912         can_highlight.
2913
2914 2019-06-25  Tom Tromey  <tom@tromey.com>
2915
2916         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2917         make_visible_with_new_height method.
2918         (tui_win_info::make_visible_with_new_height): New method.
2919         (tui_source_window_base::do_make_visible_with_new_height)
2920         (tui_data_window::do_make_visible_with_new_height)
2921         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2922         (make_visible_with_new_height): Remove.
2923         (tui_resize_all, tui_adjust_win_heights): Use
2924         make_visible_with_new_height method.
2925         * tui/tui-data.h (struct tui_win_info)
2926         <do_make_visible_with_new_height, make_visible_with_new_height>:
2927         New methods.
2928         (struct tui_source_window_base, struct tui_data_window)
2929         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2930         methods.
2931
2932 2019-06-25  Tom Tromey  <tom@tromey.com>
2933
2934         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2935         method.
2936         (update_tab_width): Call update_tab_width method.
2937         * tui/tui-data.h (struct tui_win_info)
2938         (struct tui_source_window_base) <update_tab_width>: New methods.
2939
2940 2019-06-25  Tom Tromey  <tom@tromey.com>
2941
2942         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2943         parameter.
2944         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2945         parameter.
2946         (tui_gen_win_info::make_visible): Update.
2947         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2948         parameter.
2949         * tui/tui-data.h (enum tui_box): New enum.
2950         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2951
2952 2019-06-25  Tom Tromey  <tom@tromey.com>
2953
2954         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2955         init_and_make_win for EXEC_INFO_WIN.
2956         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2957         longer inline.
2958         (struct tui_win_info) <~tui_win_info>: Inline.
2959         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2960         Don't declare.
2961         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2962         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2963         Remove.
2964         (tui_initialize_static_data): Update.
2965         (~tui_gen_win_info): Handle more cleanup here.
2966         (~tui_source_window_base): Delete "execution_info".
2967         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2968
2969 2019-06-25  Tom Tromey  <tom@tromey.com>
2970
2971         * tui/tui-layout.c (make_command_window): Don't set
2972         can_highlight.
2973         (show_source_disasm_command): Call the reset method.
2974         (show_data): Don't set can_highlight.  Call the reset method.
2975         (tui_gen_win_info::reset): Rename from init_gen_win_info
2976         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2977         (show_source_or_disasm_and_command): Call the reset method.
2978         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2979         (struct tui_cmd_window): Set can_highlight.
2980
2981 2019-06-25  Tom Tromey  <tom@tromey.com>
2982
2983         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2984         from make_visible.
2985         (tui_make_visible, tui_make_invisible): Rewrite.
2986         (tui_win_info::make_visible): Remove.
2987         (tui_source_window_base::make_visible): Update.
2988         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2989         method.  Moved from...
2990         (struct tui_win_info) <make_visible>: ...here.
2991
2992 2019-06-25  Tom Tromey  <tom@tromey.com>
2993
2994         * tui/tui-winsource.c
2995         (tui_source_window_base::do_scroll_horizontal): Remove direction
2996         parameter.
2997         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2998         direction parameter.
2999         * tui/tui-win.c (tui_win_info::forward_scroll)
3000         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3001         (tui_win_info::right_scroll): Update.
3002         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3003         direction parameter.
3004         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3005         direction parameter.
3006         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3007         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3008         Remove direction parameter.
3009         (struct tui_source_window_base, struct tui_source_window)
3010         (struct tui_disasm_window, struct tui_data_window)
3011         (struct tui_cmd_window): Update.
3012
3013 2019-06-25  Tom Tromey  <tom@tromey.com>
3014
3015         * tui/tui-winsource.h (tui_set_exec_info_content)
3016         (tui_show_exec_info_content, tui_erase_exec_info_content)
3017         (tui_clear_exec_info_content, tui_update_exec_info): Change
3018         argument to tui_source_window_base.
3019         * tui/tui-winsource.c (tui_set_exec_info_content)
3020         (tui_show_exec_info_content, tui_erase_exec_info_content)
3021         (tui_clear_exec_info_content, tui_update_exec_info): Change
3022         argument to tui_source_window_base.
3023
3024 2019-06-25  Tom Tromey  <tom@tromey.com>
3025
3026         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3027         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3028
3029 2019-06-25  Tom Tromey  <tom@tromey.com>
3030
3031         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3032         check.
3033
3034 2019-06-25  Tom Tromey  <tom@tromey.com>
3035
3036         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3037         type to void.
3038         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3039         type to void.
3040         * tui/tui-source.c (tui_set_source_content): Update.
3041         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3042
3043 2019-06-25  Tom Tromey  <tom@tromey.com>
3044
3045         * tui/tui-win.c (window_name_completer, tui_set_focus)
3046         (tui_all_windows_info): Use name method.
3047         * tui/tui-data.h (struct tui_gen_win_info)
3048         (struct tui_source_window, struct tui_disasm_window)
3049         (struct tui_data_window, struct tui_cmd_window) <name>: New
3050         method.
3051         (tui_win_name): Don't declare.
3052         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3053         (tui_win_name): Remove.
3054
3055 2019-06-25  Tom Tromey  <tom@tromey.com>
3056
3057         * tui/tui-winsource.h (tui_update_source_window)
3058         (tui_update_source_window_as_is): Change parameter type.
3059         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3060         to be a tui_source_window_base.
3061         (tui_update_source_window_as_is): Likewise.
3062         * tui/tui-win.c (make_visible_with_new_height): Update.
3063
3064 2019-06-25  Tom Tromey  <tom@tromey.com>
3065
3066         * tui/tui-winsource.c (tui_erase_source_content)
3067         (tui_show_source_content, tui_show_exec_info_content)
3068         (tui_erase_exec_info_content): Use refresh_window method.
3069         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3070         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3071         from tui_refresh_win.
3072         (tui_data_window::refresh_window): New method.
3073         (tui_win_info::refresh, tui_source_window_base::refresh)
3074         (tui_refresh_all): Use refresh_window method.
3075         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3076         method.
3077         * tui/tui-regs.c (tui_display_register): Call refresh_window
3078         method.
3079         * tui/tui-layout.c (show_source_disasm_command)
3080         (show_source_or_disasm_and_command): Call refresh_window method.
3081         * tui/tui-data.h (struct tui_gen_win_info)
3082         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3083         New method.
3084
3085 2019-06-25  Tom Tromey  <tom@tromey.com>
3086
3087         * tui/tui.c (tui_rl_other_window, tui_enable)
3088         (tui_is_window_visible, tui_get_command_dimension): Update.
3089         * tui/tui-winsource.c (tui_update_source_window_as_is)
3090         (tui_clear_source_content, tui_erase_source_content)
3091         (tui_show_source_line, tui_source_window_base::refill)
3092         (tui_source_window_base::do_scroll_horizontal)
3093         (tui_source_window_base::set_is_exec_point_at)
3094         (tui_update_breakpoint_info, tui_set_exec_info_content)
3095         (tui_alloc_source_buffer, tui_line_is_displayed)
3096         (tui_addr_is_displayed): Update.
3097         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3098         (tui_check_and_display_highlight_if_needed)
3099         (tui_win_info::make_visible, tui_win_info::refresh)
3100         (tui_refresh_all): Update.
3101         * tui/tui-windata.c (tui_first_data_item_displayed)
3102         (tui_delete_data_content_windows, tui_erase_data_content)
3103         (tui_display_all_data, tui_data_window::refresh_all)
3104         (tui_check_data_values): Update.
3105         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3106         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3107         (tui_win_info::backward_scroll, tui_refresh_all_win)
3108         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3109         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3110         (tui_source_window_base::set_new_height)
3111         (tui_data_window::set_new_height)
3112         (make_invisible_and_set_new_height)
3113         (make_visible_with_new_height, new_height_ok)
3114         (parse_scrolling_args): Update.
3115         * tui/tui-stack.c (tui_show_frame_info): Update.
3116         * tui/tui-source.c (tui_set_source_content)
3117         (tui_set_source_content_nil, tui_source_is_displayed)
3118         (tui_source_window::do_scroll_vertical): Update.
3119         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3120         (tui_display_registers_from, tui_display_reg_element_at_line)
3121         (tui_check_register_values, tui_reg_command): Update.
3122         * tui/tui-layout.c (tui_default_win_height)
3123         (show_source_disasm_command, show_data, init_and_make_win)
3124         (show_source_or_disasm_and_command): Update.
3125         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3126         (tui_redisplay_readline, tui_mld_flush)
3127         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3128         (tui_getc): Update.
3129         * tui/tui-disasm.c (tui_set_disassem_content)
3130         (tui_disasm_window::do_scroll_vertical): Update.
3131         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3132         Now virtual.
3133         (struct tui_win_info): Derive from tui_gen_win_info.
3134         <~tui_win_info>: Mark as override.
3135         <generic>: Remove member.
3136         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3137         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3138         (~tui_data_window, ~tui_win_info)
3139         (tui_free_all_source_wins_content): Update.
3140         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3141
3142 2019-06-25  Tom Tromey  <tom@tromey.com>
3143
3144         * tui/tui-layout.c (init_and_make_win): Use new.
3145         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3146         destructor, initializers.
3147         (tui_alloc_generic_win_info): Don't declare.
3148         * tui/tui-data.c (_locator): Add argument to constructor.
3149         (source_win, disasm_win): New globals.
3150         (exec_info): Remove.
3151         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3152         Update.
3153         (tui_alloc_generic_win_info): Remove.
3154         (init_content_element): Use new.
3155         (tui_win_info::tui_win_info): Update.
3156         (free_content_elements) <case DATA_WIN>: Use delete.
3157
3158 2019-06-25  Tom Tromey  <tom@tromey.com>
3159
3160         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3161         * tui/tui-windata.c (tui_first_data_item_displayed)
3162         (tui_delete_data_content_windows): Update.
3163         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3164         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3165         (tui_display_registers_from, tui_check_register_values): Update.
3166         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3167         pointer.
3168         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3169         window.
3170         (tui_free_data_content): Update.
3171         (free_content_elements) <case DATA_WIN>: Free the window.
3172
3173 2019-06-25  Tom Tromey  <tom@tromey.com>
3174
3175         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3176         Update.
3177         * tui/tui-layout.c (make_command_window)
3178         (show_source_disasm_command, show_data, init_and_make_win)
3179         (show_source_or_disasm_and_command): Update.
3180         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3181         method.
3182         <can_highight, is_highlighted>: Now bool.
3183         (tui_set_win_highlight): Don't declare.
3184         * tui/tui-data.c (tui_set_win_highlight): Remove.
3185
3186 2019-06-25  Tom Tromey  <tom@tromey.com>
3187
3188         * tui/tui-wingeneral.c (make_visible): Remove check of window
3189         type.
3190
3191 2019-06-25  Tom Tromey  <tom@tromey.com>
3192
3193         * tui/tui-win.c (tui_win_info::max_height)
3194         (tui_cmd_window::max_height): New methods.
3195         (new_height_ok): Call max_height.
3196         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3197         <max_height>: New method.
3198
3199 2019-06-25  Tom Tromey  <tom@tromey.com>
3200
3201         * tui/tui-win.c (tui_source_window_base::set_new_height)
3202         (tui_data_window::set_new_height): New methods.
3203         (make_invisible_and_set_new_height): Call set_new_height method.
3204         * tui/tui-data.h (struct tui_win_info)
3205         (struct tui_source_window_base, struct tui_data_window)
3206         <set_new_height>: New method.
3207
3208 2019-06-25  Tom Tromey  <tom@tromey.com>
3209
3210         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3211         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3212         tui_refresh_data_win.
3213         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3214         method.
3215         (tui_refresh_all_win): Call the refresh_all method.
3216         (tui_set_focus): Likewise.
3217         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3218         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3219         Likewise.
3220
3221 2019-06-25  Tom Tromey  <tom@tromey.com>
3222
3223         * tui/tui-winsource.h (tui_refill_source_window)
3224         (tui_set_is_exec_point_at): Don't declare.
3225         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3226         (tui_source_window_base::refill): Rename from
3227         tui_refill_source_window.
3228         (tui_source_window_base::do_scroll_horizontal): Update.
3229         (tui_source_window_base::set_is_exec_point_at): Rename from
3230         tui_set_is_exec_point_at.
3231         (tui_update_all_breakpoint_info): Update.
3232         * tui/tui-stack.c (tui_show_frame_info): Update.
3233         * tui/tui-layout.c (show_data): Add cast.
3234         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3235         * tui/tui-data.h (struct tui_source_window_base) <refill,
3236         set_is_exec_point_at>: New methods.
3237         (tui_source_windows, tui_add_to_source_windows): Update types.
3238         (tui_add_to_source_windows): Remove redundant declaration.
3239         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3240         (tui_source_windows): Change return type.
3241         (tui_clear_source_windows_detail): Update.
3242         (tui_add_to_source_windows): Change type of parameter.
3243         (tui_free_all_source_wins_content): Update.
3244
3245 2019-06-25  Tom Tromey  <tom@tromey.com>
3246
3247         * tui/tui-wingeneral.c (tui_win_info::refresh)
3248         (tui_source_window_base::refresh): New methods.
3249         (tui_refresh_all): Call the refresh method.
3250         * tui/tui-data.h (struct tui_win_info)
3251         (struct tui_source_window_base) <refresh>: New method.
3252
3253 2019-06-25  Tom Tromey  <tom@tromey.com>
3254
3255         * tui/tui.h (tui_is_window_visible): Return bool.
3256         * tui/tui.c (tui_is_window_visible): Return bool.
3257         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3258         (tui_make_visible, tui_make_invisible)
3259         (tui_win_info::make_visible)
3260         (tui_source_window_base::make_visible, make_all_visible)
3261         (tui_make_all_visible, tui_make_all_invisible): Update.
3262         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3263         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3264         bool.
3265         (struct tui_win_info, struct tui_source_window_base)
3266         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3267         * tui/tui-data.c (tui_init_generic_part): Update.
3268
3269 2019-06-25  Tom Tromey  <tom@tromey.com>
3270
3271         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3272         (tui_source_window_base::make_visible): New methods.
3273         (make_all_visible): Make method call.
3274         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3275         (struct tui_source_window_base, struct tui_cmd_window): Override
3276         make_visible.
3277         (tui_win_is_source_type): Don't declare.
3278         * tui/tui-data.c (tui_win_is_source_type): Remove.
3279
3280 2019-06-25  Tom Tromey  <tom@tromey.com>
3281
3282         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3283         NULL check.
3284
3285 2019-06-25  Tom Tromey  <tom@tromey.com>
3286
3287         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3288         Inline constructor.  Add initializers for members.
3289         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3290         constructors; now inline in class.
3291
3292 2019-06-25  Tom Tromey  <tom@tromey.com>
3293
3294         * tui/tui-regs.c (tui_show_registers): Update.
3295         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3296         bool.
3297         * tui/tui-data.c (tui_data_window::clear_detail)
3298         (tui_data_window): Update.
3299
3300 2019-06-25  Tom Tromey  <tom@tromey.com>
3301
3302         * tui/tui-windata.c (tui_display_all_data)
3303         (tui_display_data_from_line, tui_display_data_from)
3304         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3305         Update.
3306         * tui/tui-regs.c (tui_last_regs_line_no)
3307         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3308         (tui_show_registers, tui_show_register_group)
3309         (tui_display_registers_from, tui_display_reg_element_at_line)
3310         (tui_display_registers_from_line, tui_check_register_values)
3311         (tui_reg_next, tui_reg_prev): Update.
3312         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3313         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3314         tui_data_window.
3315         (struct tui_win_info) <detail>: Remove.  Add new fields from
3316         tui_data_info.
3317         (TUI_DATA_WIN): Add cast.
3318         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3319         (~tui_data_window): Simplify.
3320
3321 2019-06-25  Tom Tromey  <tom@tromey.com>
3322
3323         * tui/tui-layout.c (show_source_disasm_command)
3324         (show_source_or_disasm_and_command): Update.
3325         * tui/tui-io.c (update_cmdwin_start_line)
3326         (tui_redisplay_readline): Update.
3327         * tui/tui-data.h (struct tui_command_info): Remove.
3328         (struct tui_win_info) <detail>: Remove command_info member.
3329         (struct tui_data_window) <start_line>: New member, from
3330         tui_command_info.
3331         (TUI_CMD_WIN): Add casts.
3332
3333 2019-06-25  Tom Tromey  <tom@tromey.com>
3334
3335         * tui/tui-winsource.c (tui_update_source_window)
3336         (tui_refill_source_window)
3337         (tui_source_window_base::do_scroll_horizontal)
3338         (tui_update_breakpoint_info, tui_set_exec_info_content)
3339         (tui_show_exec_info_content, tui_erase_exec_info_content)
3340         (tui_clear_exec_info_content): Update.
3341         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3342         Update.
3343         * tui/tui-win.c (make_invisible_and_set_new_height)
3344         (make_visible_with_new_height): Update.
3345         * tui/tui-source.c (tui_set_source_content)
3346         (tui_show_symtab_source): Update.
3347         * tui/tui-layout.c (extract_display_start_addr)
3348         (show_source_disasm_command, show_data)
3349         (make_source_or_disasm_window)
3350         (show_source_or_disasm_and_command): Update.
3351         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3352         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3353         "gdbarch".
3354         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3355         to tui_source_window_base.
3356         (struct tui_win_info) <detail>: Remove source_info member.
3357         (struct tui_source_window_base) <has_locator>: Inline.
3358         Move contents from tui_source_info; rename has_locator member to
3359         m_has_locator.
3360         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3361         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3362         header file.
3363         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3364         Simplify.
3365         (tui_free_all_source_wins_content): Cast to
3366         tui_source_window_base.
3367
3368 2019-06-25  Tom Tromey  <tom@tromey.com>
3369
3370         * tui/tui-win.c (make_invisible_and_set_new_height)
3371         (make_visible_with_new_height): Call has_locator method.
3372         * tui/tui-layout.c (show_source_disasm_command, show_data)
3373         (show_source_or_disasm_and_command): Update for bool change.
3374         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3375         (tui_win_info) <has_locator>: New method.
3376         (struct tui_source_window_base) <has_locator>: New method.
3377         (tui_win_has_locator): Don't declare.
3378         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3379         from tui_win_has_locator.
3380         (tui_source_window_base): Use false, not FALSE.
3381
3382 2019-06-25  Tom Tromey  <tom@tromey.com>
3383
3384         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3385         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3386         clear_detail method directly.
3387         (tui_clear_win_detail): Remove.
3388
3389 2019-06-25  Tom Tromey  <tom@tromey.com>
3390
3391         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3392         "this", not TUI_DISASM_WIN.
3393
3394 2019-06-25  Tom Tromey  <tom@tromey.com>
3395
3396         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3397         declare.
3398         * tui/tui-winsource.c
3399         (tui_source_window_base::do_scroll_horizontal): Rename from
3400         tui_horizontal_source_scroll.
3401         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3402         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3403         from tui_vertical_data_scroll.
3404         * tui/tui-win.h (tui_scroll): Don't declare.
3405         * tui/tui-win.c (tui_win_info::forward_scroll)
3406         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3407         (tui_win_info::right_scroll): Rename and update.
3408         (tui_scroll_forward_command, tui_scroll_backward_command)
3409         (tui_scroll_left_command, tui_scroll_right_command): Update.
3410         (tui_scroll): Remove.
3411         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3412         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3413         from tui_vertical_source_scroll.
3414         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3415         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3416         from tui_vertical_disassem_scroll.
3417         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3418         do_scroll_horizontal>: New methods.
3419         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3420         Likewise.
3421         (struct tui_source_window_base): Add do_scroll_horizontal.
3422         (struct tui_source_window, struct tui_disasm_window): Add
3423         do_scroll_vertical.
3424         (struct tui_data_window, struct tui_cmd_window): Add
3425         do_scroll_horizontal and do_scroll_vertical.
3426         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3427
3428 2019-06-25  Tom Tromey  <tom@tromey.com>
3429
3430         * tui/tui-data.h (struct tui_source_window_base): New struct.
3431         (struct tui_source_window): Derive from tui_source_window_base.
3432         (struct tui_disasm_window): New struct.
3433         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3434         from tui_source_window::clear_detail.
3435         (tui_source_window_base): Rename from tui_source_window.
3436         (~tui_source_window_base): Rename from ~tui_source_window.
3437         (tui_alloc_win_info): Create a tui_disasm_window.
3438
3439 2019-06-25  Tom Tromey  <tom@tromey.com>
3440
3441         * tui/tui-data.h (struct tui_source_window)
3442         (struct tui_data_window): Declare destructors.
3443         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3444         destructors.
3445         (tui_win_info): Simplify.
3446
3447 2019-06-25  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-winsource.c (tui_display_main)
3450         (tui_update_source_windows_with_addr)
3451         (tui_update_all_breakpoint_info): Update.
3452         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3453         (new_height_ok, parse_scrolling_args): Update.
3454         * tui/tui-stack.c (tui_show_frame_info): Update.
3455         * tui/tui-data.h (struct tui_list): Remove.
3456         (tui_source_windows): Return a reference to a std::vector.
3457         * tui/tui-data.c (source_windows): Now a std::vector.
3458         (tui_source_windows): Change return type.
3459         (tui_clear_source_windows): Rewrite.
3460         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3461         (tui_free_all_source_wins_content): Rewrite.
3462
3463 2019-06-25  Tom Tromey  <tom@tromey.com>
3464
3465         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3466         (struct tui_data_window, struct tui_cmd_window): Declare
3467         clear_detail method.
3468         * tui/tui-data.c (tui_source_window::clear_detail)
3469         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3470         methods.
3471         (tui_clear_win_detail): Simplify.
3472
3473 2019-06-25  Tom Tromey  <tom@tromey.com>
3474
3475         * tui/tui-layout.c (make_source_window, make_disasm_window)
3476         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3477         Return the new window.
3478         (show_source_disasm_command, show_data)
3479         (show_source_or_disasm_and_command): Update.
3480
3481 2019-06-25  Tom Tromey  <tom@tromey.com>
3482
3483         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3484         parameter.  Return the new window.
3485         (show_source_disasm_command): Update and remove NULL check.
3486         (show_source_or_disasm_and_command): Update.
3487
3488 2019-06-25  Tom Tromey  <tom@tromey.com>
3489
3490         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3491
3492 2019-06-25  Tom Tromey  <tom@tromey.com>
3493
3494         * tui/tui-data.h (struct tui_win_info): Make constructor
3495         protected.  Make destructor virtual.  Add initializers.
3496         (tui_source_window, tui_data_window, tui_cmd_window): New
3497         classes.
3498         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3499         constructor.  Add "type" parameter.
3500         (tui_source_window, tui_data_window, tui_cmd_window): New
3501         constructors.
3502         (tui_alloc_win_info): Instantiate the appropriate subclass.
3503
3504 2019-06-25  Tom Tromey  <tom@tromey.com>
3505
3506         * tui/tui-win.c (tui_resize_all): Use delete.
3507         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3508         destructor.
3509         (tui_free_window): Don't declare.
3510         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3511         Update.
3512
3513 2019-06-25  Tom Tromey  <tom@tromey.com>
3514
3515         * tui/tui-data.h (struct tui_win_info): Add constructor.
3516         * tui/tui-data.c (tui_alloc_win_info): Use new.
3517         (tui_free_window): Use delete.
3518
3519 2019-06-22  Tom Tromey  <tom@tromey.com>
3520
3521         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3522         declare.
3523         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3524
3525 2019-06-22  Tom Tromey  <tom@tromey.com>
3526
3527         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3528         declare.
3529         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3530
3531 2019-06-22  Tom de Vries  <tdevries@suse.de>
3532
3533         * dwarf2read.c (create_addrmap_from_aranges)
3534         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3535         instead of '%zu'.
3536
3537 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3538
3539         * dwarf2read.h (dwarf2_section_info_def): Remove.
3540         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3541         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3542         std::vector<dwarf2_section_info>.
3543         (struct dwo_file) <~dwo_file>: Remove.
3544         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3545         types field.
3546         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3547         (dwarf2_read_debug_names): Likewise.
3548         (create_debug_types_hash_table): Change parameter type to
3549         array_view, adjust code accordingly.
3550         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3551         (partial_die_info::fixup): Likewise.
3552         (determine_prefix): Likewise.
3553         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3554
3555 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3556
3557         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3558         gdb_bfd_ref_ptr.
3559         <~dwo_file>: Remove call to gdb_bfd_unref.
3560         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3561         gdb_bfd_ref_ptr::get.
3562
3563 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3564
3565         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3566         type to htab_up.
3567         * dwarf2read.c (struct dwo_file): Initialize fields.
3568         <~dwo_file>: New.
3569         (free_dwo_file): Remove, move content to ~dwo_file.
3570         (struct dwo_file_deleter): Remove.
3571         (dwo_file_up>: Remove custom deleter.
3572         (free_dwo_files): Remove.
3573         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3574         dwo_files.
3575         (process_skeletonless_type_units): Call unique_ptr::get.
3576         (allocate_dwo_file_hash_table): Add deleter to created hash
3577         table.  Change return type to htab_up.
3578         (lookup_dwo_file_slot): Don't memset dwo_file, call
3579         unique_ptr::get.
3580         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3581         (create_dwo_unit_in_dwp_v2): Likewise.
3582         (open_and_init_dwo_file): Likewise.
3583         (free_dwo_file_from_slot): Remove.
3584
3585 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3586
3587         * dwarf2read.h (struct dwarf2_section_info) <readin,
3588         is_virtual>: Change type to bool.
3589         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3590         true instead of 1.
3591
3592 2019-06-19  Tom Tromey  <tom@tromey.com>
3593
3594         * tui/tui-data.h (tui_init_content_element): Don't declare.
3595
3596 2019-06-19  Tom Tromey  <tom@tromey.com>
3597
3598         * tui/tui-data.h (tui_init_win_info): Don't declare.
3599
3600 2019-06-19  Tom de Vries  <tdevries@suse.de>
3601
3602         * dwarf2read.h (abstract_to_concrete): Change type to
3603         std::unordered_map<sect_offset, std::vector<sect_offset>,
3604         gdb::hash_enum<sect_offset>>.
3605
3606 2019-06-19  Tom Tromey  <tromey@adacore.com>
3607
3608         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3609         EVAL_AVOID_SIDE_EFFECTS specially.
3610
3611 2019-06-19  Tom Tromey  <tromey@adacore.com>
3612
3613         * source-cache.c (highlighter): New global.
3614         (source_cache::get_source_lines): Create a highlighter on demand.
3615
3616 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3617
3618         * defs.h (deprecated_interactive_hook): Delete declaration.
3619         * interps.c (clear_interpreter_hooks): Remove use of
3620         deprecated_interactive_hook.
3621         * top.c (deprecated_interactive_hook): Delete definition.
3622         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3623
3624 2019-06-18  Tom de Vries  <tdevries@suse.de>
3625
3626         PR gdb/24515
3627         * dwarf2read.h (abstract_to_concrete): Change type from
3628         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3629         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3630         * dwarf2read.c (read_variable): Update.
3631         (dwarf2_fetch_die_loc_sect_off): Update.
3632
3633 2019-06-17  Tom de Vries  <tdevries@suse.de>
3634
3635         PR gdb/24617
3636         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3637         accessing parent[parent_len - 1].
3638
3639 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3640
3641         PR gdb/24364
3642         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3643         call dtrace_process_dof with NULL dof.
3644
3645 2019-06-16  Tom de Vries  <tdevries@suse.de>
3646
3647         PR gdb/24445
3648         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3649
3650 2019-06-16  Tom Tromey  <tom@tromey.com>
3651
3652         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3653         (make_all_visible): Use address of member.
3654
3655 2019-06-16  Tom Tromey  <tom@tromey.com>
3656
3657         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3658         (tui_free_window, free_content, free_content_elements): Remove
3659         unnecessary cast.
3660         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3661         cast.
3662         * tui/tui-regs.c (tui_show_register_group)
3663         (tui_display_registers_from, tui_display_reg_element_at_line):
3664         Remove unnecessary cast.
3665
3666 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3667
3668         * linux-nat.c (normal_mask): Delete.
3669         (_initialize_linux_nat): Don't initialise normal_mask.
3670
3671 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3672
3673         PR gdb/24445
3674         * dwarf-index-write.h (write_psymtabs_to_index): Add
3675         dwz_basename parameter.
3676         * dwarf-index-write.c (write_gdbindex): Move file writing to
3677         write_gdbindex_1.  Change return type void.
3678         (assert_file_size): Move up, remove filename parameter.
3679         (write_gdbindex_1): New function.
3680         (write_debug_names): Change return type to void, call
3681         assert_file_size.
3682         (struct index_wip_file): New struct.
3683         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3684         file logic to index_wip_file.  Write index for dwz file if
3685         needed.
3686         (save_gdb_index_command): Pass basename of dwz file, if present.
3687         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3688         build-id of dwz file, if present.
3689         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3690         (dwarf2_get_dwz_file): Likewise.
3691         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3692         (dwarf2_get_dwz_file): Likewise.
3693
3694 2019-06-16  Tom Tromey  <tom@tromey.com>
3695
3696         * coffread.c (process_coff_symbol): Use xstrdup.
3697         * value.c (create_internalvar): Use xstrdup.
3698
3699 2019-06-16  Tom Tromey  <tom@tromey.com>
3700
3701         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3702         * breakpoint.c (stopin_command, stopat_command)
3703         (until_break_command, decode_location_default): Remove unnecessary
3704         cast.
3705         * utils.c (subset_compare): Remove unnecessary cast.
3706         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3707         cast.
3708         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3709         cast.
3710         * infcmd.c (path_command): Remove unnecessary cast.
3711         * coffread.c (decode_type): Remove unnecessary cast.
3712         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3713         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3714         * tui/tui-stack.c (tui_show_locator_content)
3715         (tui_show_frame_info): Remove unnecessary cast.
3716         * tui/tui-win.c (tui_scroll_forward_command)
3717         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3718         (parse_scrolling_args): Remove unnecessary cast.
3719         * tui/tui-data.c (init_win_info, tui_del_window)
3720         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3721         (free_content_elements): Remove unnecessary cast.
3722         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3723         unnecessary cast.
3724         * tui/tui-source.c (tui_set_source_content)
3725         (tui_vertical_source_scroll): Remove unnecessary cast.
3726         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3727         cast.
3728         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3729         * tui/tui-regs.c (tui_display_registers_from)
3730         (tui_display_register): Remove unnecessary cast.
3731         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3732         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3733         (make_visible): Remove unnecessary cast.
3734         * tui/tui-winsource.c (tui_erase_source_content)
3735         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3736         unnecessary cast.
3737         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3738         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3739         * stabsread.c (read_type, read_array_type, read_range_type):
3740         Remove unnecessary cast.
3741         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3742         (parse_symbol, parse_type, upgrade_type, parse_external)
3743         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3744         unnecessary cast.
3745         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3746
3747 2019-06-16  Tom Tromey  <tom@tromey.com>
3748
3749         * tui/tui-data.c (tui_alloc_generic_win_info)
3750         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3751         checks.
3752
3753 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3754             Andrew Burgess  <andrew.burgess@embecosm.com>
3755
3756         * f-typeprint.c (f_print_type): Don't return early for not
3757         associated or not allocated types.
3758         (f_type_print_varspec_suffix): Add print_rank parameter and print
3759         ranks of array types in case they dangling.
3760         (f_type_print_base): Add print_rank parameter.
3761
3762 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3763
3764         * NEWS: Mention new MI commands.
3765         * break-catch-throw.c (enum exception_event_kind): Move to
3766         breakpoint.h.
3767         (print_mention_exception_catchpoint): Output text as a single
3768         message.
3769         (catch_exception_command_1): Rename to...
3770         (catch_exception_event): ...this, make non-static, update header
3771         command, and change some parameter types.
3772         (catch_catch_command): Update for changes to
3773         catch_exception_command_1.
3774         (catch_throw_command): Likewise.
3775         (catch_rethrow_command): Likewise.
3776         * breakpoint.c (enum exception_event_kind): Delete.
3777         * breakpoint.h (enum exception_event_kind): Moved here from
3778         break-catch-throw.c.
3779         (catch_exception_event): Declare.
3780         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3781         (mi_cmd_catch_throw): New function.
3782         (mi_cmd_catch_rethrow): New function.
3783         (mi_cmd_catch_catch): New function.
3784         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3785         'catch-catch' entries.
3786         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3787         (mi_cmd_catch_rethrow): Declare.
3788         (mi_cmd_catch_catch): Declare.
3789
3790 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3791
3792         * annotate.c (annotate_source_line): Change return type to void,
3793         update implementation to match.
3794         * annotate.h (annotate_source_line): Change return type to void,
3795         update header comment.
3796         * stack.c (print_frame_info): Don't change what frame information
3797         is printed based on whether annotations are on or not.
3798
3799 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3800
3801         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3802         (annotate_source): Make static.
3803         (annotate_source_line): Moved from source.c and renamed from
3804         identify_source_line.  Update the return type.
3805         * annotate.h (annotate_source): Delete declaration.
3806         (annotate_source_line): Declaration moved from source.h, and
3807         renamed from identify_source_line.  Return type updated.
3808         * source.c (identify_source_line): Moved to annotate.c and renamed
3809         to annotate_source_line.
3810         (info_line_command): Remove check of annotation_level.
3811         * source.h (identify_source_line): Move declaration to annotate.h
3812         and rename to annotate_source_line.
3813         * stack.c: Add 'annotate.h' include.
3814         (print_frame_info): Remove check of annotation_level before
3815         calling annotate_source_line.
3816
3817 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3818
3819         * source-cache.c (source_cache::get_plain_source_lines): Use
3820         open_source_file_with_line_charpos instead of just
3821         open_source_file, remove call to find_source_lines.
3822         (source_cache::get_source_lines): Likewise.
3823         * source.c (find_source_lines): Make static.
3824         (get_filename_and_charpos): Renamed into...
3825         (open_source_file_with_line_charpos): ..this along with changes to
3826         return a scoped_fd, and some other minor clean ups.
3827         (identify_source_line): Use open_source_file_with_line_charpos.
3828         (search_command_helper): Use open_source_file_with_line_charpos
3829         instead of just open_source_file, remove call to
3830         find_source_lines.
3831         * source.h (open_source_file_with_line_charpos): Declare new
3832         function.
3833         (find_source_lines): Delete declaration.
3834
3835 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3836
3837         * source.c (get_filename_and_charpos): Remove fullname
3838         parameter.
3839         (identify_source_line): Update call to get_filename_and_charpos.
3840
3841 2019-06-14  Tom Tromey  <tromey@adacore.com>
3842
3843         PR gdb/24502:
3844         * ui-style.h (skip_ansi_escape): Update comment.
3845         * ui-file.h (class no_terminal_escape_file): New class.
3846         * ui-file.c (no_terminal_escape_file::write)
3847         (no_terminal_escape_file::puts): New methods.
3848         * cli/cli-logging.c (handle_redirections): Use
3849         no_terminal_escape_file.
3850
3851 2019-06-14  Tom Tromey  <tromey@adacore.com>
3852
3853         * NEWS: Move convenience variable news above Python news.
3854
3855 2019-06-14  Tom Tromey  <tom@tromey.com>
3856
3857         * gnulib: Move directory to top-level.
3858         * configure.ac: Don't configure gnulib.
3859         * configure: Rebuild.
3860         * common/common-defs.h: Use new path to gnulib.
3861         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3862         (GNULIB_H): Remove.
3863         (INCGNU): Look in new gnulib location.
3864         (HFILES_NO_SRCDIR): Remove gnulib files.
3865         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3866         (generated_files): Remove GNULIB_H.
3867         ($(LIBGNU), all-lib): Remove targets.
3868         (distclean): Don't mention GNULIB_BUILDDIR.
3869         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3870
3871 2019-06-14  Tom Tromey  <tromey@adacore.com>
3872
3873         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3874         Warn if symbol file does not provide any symbols.
3875
3876 2019-06-14  Tom Tromey  <tromey@adacore.com>
3877
3878         * source.c (find_and_open_source): Respect basenames_may_differ.
3879
3880 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3881
3882         * annotate.c (annotate_breakpoints_invalid): Make use of
3883         scoped_restore_terminal_state.
3884         (annotate_frames_invalid): Likewise.
3885
3886 2019-06-14  Tom Tromey  <tromey@adacore.com>
3887
3888         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3889         allow assignment to an internalvar.
3890
3891 2019-06-14  Tom Tromey  <tromey@adacore.com>
3892
3893         * ada-lex.l: Allow "_" in attribute names.
3894
3895 2019-06-14  Tom Tromey  <tromey@adacore.com>
3896
3897         PR gdb/24653:
3898         * regcache.c (registers_changed): Don't call alloca.
3899         * top.c (execute_command): Don't call alloca.
3900
3901 2019-06-13  Pedro Alves  <palves@redhat.com>
3902
3903         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3904         'expression'.  When parsing an expression, error out if there's
3905         junk after "unlimited".
3906         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3907         (do_set_command): Adjust calls to is_unlimited_literal.
3908
3909 2019-06-13  Pedro Alves  <palves@redhat.com>
3910
3911         * compile/compile.c (make_compile_options_def_group): Add braces
3912         around array_view initializer.
3913         * thread.c (make_thread_apply_all_options_def_group)
3914         (make_thread_apply_all_options_def_group): Likewise.
3915
3916 2019-06-13  Pedro Alves  <palves@redhat.com>
3917
3918         * NEWS (New commands): Mention "maint test-options
3919         require-delimiter", "maint test-options unknown-is-error", "maint
3920         test-options unknown-is-operand" and "maint show
3921         test-options-completion-result".
3922         (New command options, command completion): New section.
3923         (Completion improvements): New section.
3924         Mention that you can abbreviate "unlimited".
3925
3926 2019-06-13  Pedro Alves  <palves@redhat.com>
3927
3928         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3929         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3930         * unittests/cli-utils-selftests.c (test_parse_flags)
3931         (test_parse_flags_qcs): Delete.
3932         (test_cli_utils): Don't call deleted functions.
3933
3934 2019-06-13  Pedro Alves  <palves@redhat.com>
3935
3936         * thread.c: Include "cli/cli-option.h".
3937         (tp_array_compar_ascending): Global.
3938         (tp_array_compar): Delete function.
3939         (tp_array_compar_ascending, tp_array_compar_descending): New
3940         functions.
3941         (ascending_option_def, qcs_flag_option_def)
3942         (thr_qcs_flags_option_defs)
3943         (make_thread_apply_all_options_def_group)
3944         (make_thread_apply_options_def_group): New.
3945         (thread_apply_all_command): Use gdb::option::process_options.
3946         (thread_apply_command_completer)
3947         (thread_apply_all_command_completer): New.
3948         (thread_apply_command): Use gdb::option::process_options.
3949         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3950         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3951         to generate help text of "thread apply".  Adjust "taas"'s help.
3952         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3953         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3954
3955 2019-06-13  Pedro Alves  <palves@redhat.com>
3956
3957         * thread.c (thread_apply_command): Check for invalid TID with
3958         isdigit instead of !isalpha.
3959
3960 2019-06-13  Pedro Alves  <palves@redhat.com>
3961
3962         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3963         (validate_flags_qcs): New.
3964         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3965         (validate_flags_qcs): Declare.
3966         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3967         (make_frame_apply_options_def_group): New.
3968         (frame_apply_command_count): Process options with
3969         gdb::option::process_options.
3970         (frame_apply_completer): New.
3971         (frame_apply_level_completer, frame_apply_all_completer)
3972         (frame_apply_completer): New.
3973         (_initialize_stack): Update help of "frame apply", "frame apply
3974         level", "frame apply all" and "faas" to mention supported options
3975         and install command completers.
3976         * stack.h (frame_apply_all_completer): Declare.
3977         * thread.c: Include "stack.h".
3978         (tfaas_command): Add "--".
3979         (_initialize_thread): Update help "tfaas" to mention supported
3980         options and install command completer.
3981
3982 2019-06-13  Pedro Alves  <palves@redhat.com>
3983
3984         * completer.c (complete_nested_command_line): New.
3985         (gdb_completion_word_break_characters_throw): Add assertion.
3986         * completer.h (complete_nested_command_line): Declare.
3987
3988 2019-06-13  Pedro Alves  <palves@redhat.com>
3989
3990         * stack.c (parse_backtrace_qualifiers): New.
3991         (backtrace_command): Use it.
3992         (backtrace_command_completer): Complete on qualifiers.
3993
3994 2019-06-13  Pedro Alves  <palves@redhat.com>
3995
3996         * frame.c: Include "cli/cli-option.h.
3997         (user_set_backtrace_options): New.
3998         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3999         Delete.
4000         (get_prev_frame): Adjust.
4001         (boolean_option_def, uinteger_option_def)
4002         (set_backtrace_option_defs): New.
4003         (_initialize_frame): Adjust and use
4004         gdb::option::add_setshow_cmds_for_options to install "set
4005         backtrace past-main" and "set backtrace past-entry".
4006         * frame.h: Include "cli/cli-option.h".
4007         (struct frame_print_options): Forward declare.
4008         (print_frame_arguments_all, print_frame_arguments_scalars)
4009         (print_frame_arguments_none): Declare.
4010         (print_entry_values): Delete declaration.
4011         (struct frame_print_options, user_frame_print_options): New.
4012         (struct set_backtrace_options): New.
4013         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4014         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4015         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4016         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4017         (list_args_or_locals): Add frame_print_options parameter.
4018         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4019         * python/py-framefilter.c (enumerate_args): Pass down
4020         USER_FRAME_PRINT_OPTIONS.
4021         * stack.c: Include "cli/cli-option.h".
4022         (print_frame_arguments_all, print_frame_arguments_scalars)
4023         (print_frame_arguments_none): Declare.
4024         (print_raw_frame_arguments, print_entry_values): Delete.
4025         (user_frame_print_options): New.
4026         (boolean_option_def, enum_option_def, frame_print_option_defs):
4027         New.
4028         (struct backtrace_cmd_options): New.
4029         (bt_flag_option_def): New.
4030         (backtrace_command_option_defs): New.
4031         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4032         (print_frame_arg, read_frame_arg, print_frame_args)
4033         (print_frame_info, print_frame): Add frame_print_options parameter
4034         and use it.
4035         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4036         (backtrace_command_1): Add frame_print_options and
4037         backtrace_cmd_options parameters and use them.
4038         (make_backtrace_options_def_group): New.
4039         (backtrace_command): Process command options with
4040         gdb::option::process_options.
4041         (backtrace_command_completer): New.
4042         (_initialize_stack): Extend "backtrace"'s help to mention
4043         supported options.  Install completer for "backtrace".
4044         Install some settings commands with add_setshow_cmds_for_options.
4045
4046 2019-06-13  Pedro Alves  <palves@redhat.com>
4047
4048         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4049         and that "set/show print raw frame-arguments" are now deprecated.
4050
4051         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4052         command.
4053         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4054         * stack.c (_initialize_stack): Install "set/show print
4055         raw-frame-arguments", and deprecate "set/show print raw
4056         frame-arguments".
4057         * valprint.c (_initialize_valprint): Deprecate "set/show print
4058         raw".
4059
4060 2019-06-13  Pedro Alves  <palves@redhat.com>
4061
4062         * compile/compile.c (struct compile_options): New.
4063         (compile_flag_option_def, compile_command_option_defs)
4064         (make_compile_options_def_group): New.
4065         (compile_file_command): Handle options with
4066         gdb::option::process_options.
4067         (compile_file_command_completer): New function.
4068         (compile_code_command): Handle options with
4069         gdb::option::process_options.
4070         (compile_code_command_completer): New function.
4071         (_initialize_compiler): Install completers for "compile code" and
4072         "compile file".  Mention available options in "compile code" and
4073         "compile code"'s help.
4074         * completer.c (advance_to_completion_word): New, factored out from
4075         ...
4076         (advance_to_expression_complete_word_point): ... this.
4077         (advance_to_filename_complete_word_point): New.
4078         * completer.h (advance_to_filename_complete_word_point): New
4079         declaration.
4080
4081 2019-06-13  Pedro Alves  <palves@redhat.com>
4082
4083         * compile/compile.c: Include "cli/cli-option.h".
4084         (compile_print_value): Scope data pointer is now a
4085         value_print_options pointer; adjust.
4086         (compile_print_command): Process options.  Scope data pointer is
4087         now a value_print_options pointer; adjust.
4088         (_initialize_compile): Update "compile print"'s help to include
4089         supported options.  Install a completer for "compile print".
4090         * cp-valprint.c (show_vtblprint, show_objectprint)
4091         (show_static_field_print): Delete.
4092         (_initialize_cp_valprint): Don't install "set print
4093         static-members", "set print vtbl", "set print object" here.
4094         * printcmd.c: Include "cli/cli-option.h" and
4095         "common/gdb_optional.h".
4096         (print_command_parse_format): Rework to fill in a
4097         value_print_options instead of a format_data.
4098         (print_value): Change parameter type from format_data pointer to
4099         value_print_options reference.  Adjust.
4100         (print_command_1): Process options.  Adjust to pass down a
4101         value_print_options.
4102         (print_command_completer): New.
4103         (_initialize_printcmd): Install print_command_completer as
4104         handle_brkchars completer for the "print" command.  Update
4105         "print"'s help to include supported options.
4106         * valprint.c: Include "cli/cli-option.h".
4107         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4108         here from cp-valprint.c.
4109         (boolean_option_def, uinteger_option_def)
4110         (value_print_option_defs, make_value_print_options_def_group):
4111         New.  Use gdb::option::add_setshow_cmds_for_options to install
4112         "set print elements", "set print null-stop", "set print repeats",
4113         "set print pretty", "set print union", "set print array", "set
4114         print address", "set print symbol", "set print array-indexes".
4115         * valprint.h: Include <string> and "cli/cli-option.h".
4116         (make_value_print_options_def_group): Declare.
4117         (print_value): Change parameter type from format_data pointer to
4118         value_print_options reference.
4119         (print_command_completer): Declare.
4120
4121 2019-06-13  Pedro Alves  <palves@redhat.com>
4122
4123         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4124         (COMMON_SFILES): Add maint-test-settings.c.
4125         * cli/cli-decode.c (boolean_enums): New global, factored out from
4126         ...
4127         (add_setshow_boolean_cmd): ... here.
4128         * cli/cli-decode.h (boolean_enums): Declare.
4129         * cli/cli-option.c: New file.
4130         * cli/cli-option.h: New file.
4131         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4132         factored out from ...
4133         (parse_cli_boolean_value(const char *)): ... this.
4134         (is_unlimited_literal): Change parameter type to pointer to
4135         pointer.  Adjust and advance ARG pointer.
4136         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4137         (parse_cli_var_enum): New, factored out from ...
4138         (do_set_command): ... this.  Adjust.
4139         * cli/cli-setshow.h (parse_cli_boolean_value)
4140         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4141         (parse_cli_var_enum): Declare.
4142         * cli/cli-utils.c: Include "cli/cli-option.h".
4143         (get_ulongest): New.
4144         * cli/cli-utils.h (get_ulongest): Declare.
4145         (check_for_argument): New overloads.
4146         * maint-test-options.c: New file.
4147
4148 2019-06-13  Pedro Alves  <palves@redhat.com>
4149
4150         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4151         parse a range if "-" is at the end of the string.
4152
4153 2019-06-13  Pedro Alves  <palves@redhat.com>
4154
4155         * cli/cli-setshow.c (parse_auto_binary_operation)
4156         (parse_cli_boolean_value): Don't allow "o".
4157
4158 2019-06-13  Pedro Alves  <palves@redhat.com>
4159
4160         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4161         * NEWS: Mention maint test-settings KIND.
4162         * maint-test-settings.c: New file.
4163
4164 2019-06-13  Pedro Alves  <palves@redhat.com>
4165
4166         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4167         completer.
4168         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4169         "set" completers.
4170
4171 2019-06-13  Pedro Alves  <palves@redhat.com>
4172
4173         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4174         after item.
4175
4176 2019-06-13  Pedro Alves  <palves@redhat.com>
4177
4178         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4179
4180 2019-06-13  Pedro Alves <palves@redhat.com>
4181
4182         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4183         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4184         call.
4185         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4186         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4187         calls.
4188         (check_for_argument): Skip spaces after argument.
4189
4190 2019-06-13  Pedro Alves  <palves@redhat.com>
4191
4192         * thread.c (thread_apply_command): Adjust TID parsing.
4193         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4194         detected before end of string.
4195         (tid_is_in_list): Error out if LIST is invalid.
4196
4197 2019-06-13  Pedro Alves  <palves@redhat.com>
4198
4199         * completer.c (complete_line_internal_1): Rewind completion word
4200         point.
4201         (completion_tracker::advance_custom_word_point_by): Change
4202         parameter type to int.
4203         * completer.h (completion_tracker::advance_custom_word_point_by):
4204         Likewise.
4205
4206 2019-06-13  Pedro Alves  <palves@redhat.com>
4207
4208         * completer.c (advance_to_completion_word): Handle delimiters.
4209
4210 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4211
4212         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4213
4214 2019-06-11  Tom Tromey  <tom@tromey.com>
4215
4216         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4217         (xmalloc_failed): Move to alloc.c.
4218         * alloc.c: New file.
4219         * Makefile.in (COMMON_SFILES): Add alloc.c.
4220
4221 2019-06-11  Tom Tromey  <tom@tromey.com>
4222
4223         * nat/linux-waitpid.c: Don't include server.h.
4224         (linux_debug): Remove.
4225         (my_waitpid): Update.
4226
4227 2019-06-11  Tom Tromey  <tromey@adacore.com>
4228
4229         * infcall.c (_initialize_infcall): Remove trailing newline from
4230         help.
4231         * user-regs.c (_initialize_user_regs): Remove trailing newline
4232         from help.
4233         * typeprint.c (_initialize_typeprint): Remove trailing newline
4234         from help.
4235         * reverse.c (_initialize_reverse): Remove trailing newlines from
4236         help.
4237         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4238         from help.
4239         * language.c (add_set_language_command): Remove trailing newline
4240         from help.
4241         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4242         help.
4243         * disasm.c (_initialize_disasm): Remove trailing newline from
4244         help.
4245         * top.c (init_main): Remove trailing newline from help.
4246         * interps.c (_initialize_interpreter): Remove trailing newline
4247         from help.
4248         * btrace.c (_initialize_btrace): Remove trailing newlines from
4249         help.
4250         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4251         from help.
4252         * python/python.c (_initialize_python): Remove trailing newline
4253         from help.
4254         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4255         help.
4256         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4257         from help.  Reformat some text.
4258         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4259         from help.
4260         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4261         newline from help.
4262
4263 2019-06-11  Tom Tromey  <tromey@adacore.com>
4264
4265         * darwin-nat.c (darwin_decode_exception_message)
4266         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4267
4268 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4269
4270         * valops.c (value_slice): Check for not allocated or not
4271         associated values.
4272
4273 2019-06-10  Tom de Vries  <tdevries@suse.de>
4274
4275         PR gdb/24618
4276         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4277         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4278         invalid.
4279
4280 2019-06-10  Tom de Vries  <tdevries@suse.de>
4281
4282         PR gdb/24611
4283         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4284         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4285
4286 2019-06-10  Tom de Vries  <tdevries@suse.de>
4287
4288         PR symtab/24545
4289         * symtab.c (struct demangled_name_entry): Add language field.
4290         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4291         static minimal symbol".  Set and use language field.
4292
4293 2019-06-10  Tom Tromey  <tromey@adacore.com>
4294
4295         * ada-lang.c (_initialize_ada_language): Update help text.
4296
4297 2019-06-10  Tom Tromey  <tromey@adacore.com>
4298
4299         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4300         with a newline.
4301         * guile/guile.c (handle_boot_error): Don't end warning with a
4302         newline.
4303         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4304         warning with a newline.
4305         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4306         newline.
4307         (s12z_frame_cache): Likewise.
4308         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4309         a newline.
4310         * solib-svr4.c (disable_probes_interface): Don't end warning with
4311         a newline.
4312         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4313         newline.
4314         * python/python.c (do_finish_initialization): Don't end warning
4315         with a newline.
4316
4317 2019-06-10  Tom Tromey  <tom@tromey.com>
4318
4319         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4320         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4321         gdbpy_enter.
4322
4323 2019-06-10  Tom Tromey  <tromey@adacore.com>
4324
4325         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4326         data.
4327         (elf_new_init): Don't call stabsread_new_init.
4328         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4329         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4330         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4331
4332 2019-06-10  Tom de Vries  <tdevries@suse.de>
4333
4334         PR symtab/16264
4335         PR symtab/24517
4336         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4337
4338 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4339
4340         * source.c (find_and_open_source): Also rewrite relative file
4341         names.
4342
4343 2019-04-26  Amos Bird  <amosbird@gmail.com>
4344
4345         * annotate.c (annotate_thread_exited): Add "thread-exited"
4346         annotation.
4347
4348 2019-06-06  Tom Tromey  <tromey@adacore.com>
4349
4350         * maint.h (class scoped_command_stats): Use
4351         DISABLE_COPY_AND_ASSIGN.
4352         <print_time>: New method.
4353         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4354         print_time.
4355         (scoped_command_stats::print_time): New method.
4356
4357 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4358
4359         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4360         instructions of lengths 6 or 8 bytes.
4361
4362 2019-06-04  Pedro Alves  <palves@redhat.com>
4363
4364         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4365
4366         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4367         * breakpoint.c (condition_completer): Likewise.
4368         * cli/cli-dump.c (scan_expression): Likewise.
4369         * common/filestuff.c (mkdir_recursive): Likewise.
4370         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4371         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4372         (gdb_abspath): Likewise.
4373         * compile/compile-cplus-types.c
4374         (compile_cplus_instance::decl_name): Likewise.
4375         * completer.c (complete_explicit_location):
4376         (signal_completer, reg_or_group_completer_1): Likewise.
4377         * cp-support.c (cp_remove_params_if_any): Likewise.
4378         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4379         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4380         * infcmd.c (strip_bg_char): Likewise.
4381         * linespec.c (copy_token_string): Likewise.
4382         * mi/mi-main.c (output_cores): Likewise.
4383         * psymtab.c (psymtab_search_name):
4384         * symfile.c (test_set_ext_lang_command): Likewise.
4385         * target.c (target_fileio_read_stralloc): Likewise.
4386         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4387         * value.c (complete_internalvar): Likewise.
4388
4389 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4390
4391         Add objfile property to gdb.Type.
4392         * NEWS: Mention Python API addition.
4393         * python/py-type.c (typy_get_objfile): New method.
4394
4395 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4396
4397         * NEWS: Mention the new set|show style [title|highlight].
4398         Mention changes to "show style", "help" and "apropos".
4399
4400 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4401
4402         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4403         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4404         instead of print_help_for_command.
4405         (print_doc_of_command): New function.
4406         (help_list): Add 'apropos -v word' suggestion.
4407         (print_help_for_command): Style the command name using title style.
4408         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4409         (_initialize_cli_cmds): Describe -v in apropos_command help.
4410
4411 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4412
4413         * cli/cli-style.h (cli_style_option): Add name in constructor,
4414         add m_name class member, add constructor with intensity,
4415         add name class function.
4416         (cli_style_option::add_setshow_commands): Remove name argument.
4417         (highlight_style, title_style): New styles.
4418         * cli/cli-style.c (do_show): New function that shows a style
4419         characteristic styling the style name with itself.
4420         (set_style_name): New function.
4421         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4422         Update all callers according to the changes in cli/cli-style.h.
4423         * utils.h (fputs_highlighted): New function.
4424         * utils.c (fputs_highlighted): Likewise.
4425
4426 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4427
4428         * NEWS: Mention new pipe command and new convenience variables.
4429
4430 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4431
4432         * cli/cli-cmds.c (pipe_command): New function.
4433         (_initialize_cli_cmds): Call add_com for pipe_command.
4434         Define | as an alias for pipe.
4435         (exit_status_set_internal_vars): New function.
4436         (shell_escape): Call exit_status_set_internal_vars.
4437         cli/cli-decode.c (find_command_name_length): Recognize | as
4438         a single character command.
4439
4440 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4441
4442         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4443         top.c (execute_command_to_ui_file): New function, mostly a copy
4444         of execute_command_to_string.
4445         (execute_command_to_string): Implement by calling
4446         execute_command_to_ui_file.
4447
4448 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4449
4450         * top.h (saved_command_line): Remove declaration.
4451         * top.c (previous_saved_command_line, previous_repeat_arguments):
4452         New variables.
4453         (saved_command_line): Make static, define together with other
4454         'repeat variables'.
4455         (dont_repeat): Clear repeat_arguments.
4456         (repeat_previous, get_saved_command_line, save_command_line):
4457         New functions.
4458         (gdb_init): Initialize saved_command_line
4459         and previous_saved_command_line.
4460         * main.c (captured_main_1): Remove saved_command_line initialization.
4461         * event-top.c (handle_line_of_input): Update to use
4462         the new 'repeat' related functions instead of direct access to
4463         saved_command_line.
4464         * command.h (repeat_previous, get_saved_command_line,
4465         save_command_line): New declarations.
4466         (dont_repeat): Add comment.
4467
4468 2019-05-30  Tom Tromey  <tromey@adacore.com>
4469
4470         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4471         Fix comment.
4472         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4473
4474 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4475
4476         PR cli/24587
4477         * completer.c (complete): Initialize variable word.
4478
4479 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4480
4481         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4482         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4483         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4484         'body' is NULL to the outter 'if', protecting the '!is_define'
4485         situation as well.
4486
4487 2019-05-29  Tom Tromey  <tromey@adacore.com>
4488
4489         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4490         (dwarf_unknown): New function.
4491         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4492         (dwarf_type_encoding_name): Use dwarf_unknown.
4493
4494 2019-05-29  Tom Tromey  <tromey@adacore.com>
4495
4496         PR c++/20020:
4497         * cp-valprint.c (cp_print_value_fields): Call
4498         cp_print_static_field inside "try".
4499
4500 2019-05-29  Tom Tromey  <tromey@adacore.com>
4501
4502         * inflow.c (struct terminal_info): Add default operator=.
4503         * configure: Rebuild.
4504         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4505         -Wdeprecated-copy-dtor, -Wredundant-move.
4506
4507 2019-05-29  Tom Tromey  <tromey@adacore.com>
4508
4509         * NEWS: Add entry.
4510         * infcmd.c (print_return_value_1): Handle finish_print
4511         option.
4512         (show_print_finish): New function.
4513         (_initialize_infcmd): Add "set/show print finish" commands.
4514         * valprint.c (user_print_options): Initialize new member.
4515         * valprint.h (struct value_print_options) <finish_print>: New
4516         member.
4517
4518 2019-05-28  Tom Tromey  <tromey@adacore.com>
4519
4520         * ada-lang.c (ada_remove_Xbn_suffix)
4521         (find_old_style_renaming_symbol)
4522         (parse_old_style_renaming): Remove.
4523         (ada_find_renaming_symbol): Don't call
4524         find_old_style_renaming_symbol.
4525         (ada_is_renaming_symbol): Rename from
4526         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4527         bool.  Now static.
4528         (ada_read_var_value): Update and simplify.
4529         * ada-exp.y (write_var_or_type): Remove old code.
4530
4531 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4532
4533         * event-top.c: Remove include comment.
4534         * inflow.c (class scoped_ignore_sigttou): Move from here...
4535         * inflow.h (class scoped_ignore_sigttou): ...to here.
4536         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4537         * top.c:  Remove include comment.
4538
4539 2019-05-27  Tom Tromey  <tom@tromey.com>
4540
4541         * NEWS: Fix typo.
4542
4543 2019-05-22  Tom Tromey  <tromey@adacore.com>
4544
4545         * target.c (target_follow_exec): Constify parameter.
4546         * target-delegates.c: Rebuild.
4547         * remote.c (remote_target::follow_exec): Constify parameter.
4548         * infrun.c (follow_exec): Constify parameter.
4549         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4550         (target_follow_exec): Likewise.
4551
4552 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4553
4554         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4555         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4556
4557 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4558
4559         * NEWS: Add debugredirect and testsuite sections.
4560
4561 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4562
4563         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4564         target descriptions using exclusively floating point register name
4565         aliases.
4566
4567 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4568
4569         PR gdb/18644:
4570         * f-lang.c (build_fortran_types): Handle the case where
4571         gdbarch_floatformat_for_type returns a nullptr.
4572
4573 2019-05-21  Tom de Vries  <tdevries@suse.de>
4574
4575         PR cli/24587
4576         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4577
4578 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4579
4580         PR gdb/18644:
4581         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4582         16-byte floats.
4583         * i386-tdep.c (i386_floatformat_for_type): Use
4584         floatformats_ia64_quad for the 16-byte floating point component
4585         within a fortran 32-byte complex number.
4586
4587 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4588
4589         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4590         delete default constructor.
4591         (find_partial_die): Update to return const struct.
4592         (partial_die_parent_scope): Move variable declaration into scope
4593         of its use and change its type to auto.
4594         (guess_partial_die_structure_name): Likewise.
4595         (partial_die_info::fixup): Likewise.
4596
4597 2019-05-17  Tom Tromey  <tromey@adacore.com>
4598
4599         * source.c (find_and_open_source): Remove cast.
4600
4601 2019-05-17  Tom Tromey  <tromey@adacore.com>
4602
4603         * annotate.c (annotate_source): Make "filename" const.
4604         * annotate.h (annotate_source): Use const.
4605
4606 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4607
4608         * disasm.c (set_disassembler_options): Send errors to stderr.
4609
4610 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4611
4612         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4613         (cli_interp_base::set_logging): Check debug_redirect.
4614         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4615         * cli/cli-logging.c (debug_redirect): Add static variable.
4616         (pop_output_files): Add default param.
4617         (handle_redirections): Print debug setting.
4618         (show_logging_command): Likewise.
4619         (_initialize_cli_logging): Add debugredirect command.
4620         * interps.c (current_interp_set_logging): Add debug_redirect
4621         parameter.
4622         * interps.h (set_logging): Add debug_redirect parameter.
4623         (current_interp_set_logging): Likewise.
4624         * mi/mi-common.h: Likewise.
4625         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4626
4627 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4628             Tom Tromey  <tromey@adacore.com>
4629
4630         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4631         directly.
4632         * cli/cli-interp.h (make_logging_output): Remove declaration.
4633         * cli/cli-logging.c (make_logging_output): Remove function.
4634         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4635         directly.
4636         * ui-file.c (tee_file::tee_file): Remove bools.
4637         (tee_file::~tee_file): Remove deletes.
4638         * ui-file.h (tee_file): Remove bools.
4639
4640 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4641
4642         * mi/mi-cmds.h (mi_cmd_complete): New function.
4643         * mi/mi-main.c (mi_cmd_complete): Likewise.
4644         * mi/mi-cmds.c: Define new MI command -complete.
4645         * NEWS: Mention new -complete command.
4646
4647 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4648
4649         * completer.h (complete): New function.
4650         * completer.c (complete): Likewise.
4651         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4652         function defined in completer.h.
4653
4654 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4655
4656         * MAINTAINERS (Write After Approval): Add myself.
4657
4658 2019-05-17  Tom de Vries  <tdevries@suse.de>
4659
4660         PR gdb/24094
4661         * dwarf2read.c (struct cu_partial_die_info): New struct.
4662         (find_partial_die): Return cu_partial_die_info.
4663         (partial_die_parent_scope, guess_partial_die_structure_name)
4664         (partial_die_info::fixup): Handle new return type of find_partial_die.
4665
4666 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4667
4668         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4669         "std::string", simplifying the algorithm.
4670
4671 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4672
4673         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4674         (stap_static_probe_ops::get_probes): Likewise.
4675
4676 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4677
4678         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4679         '-')" and "else if".
4680         (stap_parse_single_operand): Join checks for
4681         "gdbarch_stap_parse_special_token_p" and
4682         "gdbarch_stap_parse_special_token" in the same "if" statement.
4683         Invert check when verifying for operation on register
4684         displacement.
4685
4686 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4687
4688         * stap-probe.c (stap_get_opcode): Update comment.
4689         (stap_get_expected_argument_type): Likewise.
4690         (handle_stap_probe): Likewise.
4691
4692 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4693
4694         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4695         return type to 'bool'.  Adjust comment.  Use 'bool' when
4696         appropriate.
4697         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4698         * stap-probe.c (stap_parse_argument_1): Likewise.
4699         (stap_is_operator): Likewise.
4700         (stap_is_generic_prefix): Likewise.
4701         (stap_is_register_prefix): Likewise.
4702         (stap_is_register_indirection_prefix): Likewise.
4703         (stap_is_integer_prefix): Likewise.
4704         (stap_generic_check_suffix): Likewise.
4705         (stap_check_integer_suffix): Likewise.
4706         (stap_check_register_suffix): Likewise.
4707         (stap_check_register_indirection_suffix): Likewise.
4708         (stap_parse_register_operand): Likewise.
4709         (stap_parse_single_operand): Likewise.
4710         (stap_parse_argument_1): Likewise.
4711         (stap_probe::get_argument_count): Likewise.
4712         (stap_is_operator): Likewise.
4713
4714 2019-05-16  Tom Tromey  <tromey@adacore.com>
4715
4716         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4717         keyword to foreach.
4718
4719 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4720
4721         * linux-thread-db.c (try_thread_db_load_1): Change return type
4722         to bool.
4723         (try_thread_db_load): Likewise.
4724         (try_thread_db_load_from_pdir_1): Likewise.
4725         (try_thread_db_load_from_pdir): Likewise.
4726         (try_thread_db_load_from_sdir): Likewise.
4727         (try_thread_db_load_from_dir): Likewise.
4728         (thread_db_load_search): Likewise.
4729         (has_libpthread): Likewise.
4730         (thread_db_load): Likewise.
4731
4732 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4733
4734         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4735         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4736         NULL, and complain/return if that's the case.
4737
4738 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4739
4740         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4741         (advance, posn, abstract_read_memory): New functions.
4742         [struct mem_read_abstraction]: New struct.
4743         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4744
4745 2019-05-14  Tom Tromey  <tromey@adacore.com>
4746
4747         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4748         value is not lval_memory.
4749
4750 2019-05-14  Tom Tromey  <tromey@adacore.com>
4751
4752         * solib.c (info_sharedlibrary_command): Style the file name.
4753
4754 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4755
4756         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4757         (aarch64_vnv_type): Likewise.
4758         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4759         * common/tdesc.c: Likewise.
4760         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4761         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4762         * features/aarch64-fpu.xml: Add ieee half view.
4763         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4764         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4765         * gdbtypes.h (struct builtin_type): Likewise.
4766         (struct objfile_type): Likewise.
4767
4768 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4769
4770         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4771         typo.
4772         * location.h (string_to_event_location): Likewise.
4773
4774 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4775
4776         GDB 8.3 released.
4777
4778 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4779
4780         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4781         New variable declaration.
4782         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4783         New variable.
4784         (print_one_breakpoint): Use ui_out::test_flags and new global
4785         variable to compute use_fixed_output.
4786         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4787         Remove.
4788         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4789         (mi_multi_location_breakpoint_output_fixed): Remove.
4790         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4791         new variable.
4792         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4793         fix_multi_location_breakpoint_output flag if version >= 3.
4794         * ui-out.h (enum ui_out_flag)
4795         <fix_multi_location_breakpoint_output>: New enumerator.
4796
4797 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4798
4799         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4800
4801 2019-05-10  Tom Tromey  <tromey@adacore.com>
4802
4803         * ada-lang.c (catch_ada_completer): New function.
4804         (_initialize_ada_language): Use it.
4805
4806 2019-05-10  Tom Tromey  <tromey@adacore.com>
4807
4808         * thread.c (print_thread_info): Make "requested_threads" const.
4809         * gdbthread.h (print_thread_info): Make "requested_threads"
4810         const.
4811         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4812         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4813
4814 2019-05-08  Tom Tromey  <tom@tromey.com>
4815
4816         * gdbtypes.c (objfile_type_data): Change type.
4817         (objfile_type, _initialize_gdbtypes): Update.
4818
4819 2019-05-08  Tom Tromey  <tom@tromey.com>
4820
4821         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4822         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4823         (_initialize_dwarf2_frame): Update.
4824
4825 2019-05-08  Tom Tromey  <tom@tromey.com>
4826
4827         * objc-lang.c (objc_objfile_data): Change type.
4828         (find_methods): Update.
4829         (_initialize_objc_lang): Remove.
4830
4831 2019-05-08  Tom Tromey  <tom@tromey.com>
4832
4833         * stabsread.c (rs6000_builtin_type_data): Change type.
4834         (rs6000_builtin_type, _initialize_stabsread): Update.
4835
4836 2019-05-08  Tom Tromey  <tom@tromey.com>
4837
4838         * mips-tdep.c (mips_pdr_data): Remove.
4839         (_initialize_mips_tdep): Update.
4840
4841 2019-05-08  Tom Tromey  <tom@tromey.com>
4842
4843         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4844         (hppa_init_objfile_priv_data, read_unwind_info)
4845         (find_unwind_entry, _initialize_hppa_tdep): Update.
4846
4847 2019-05-08  Tom Tromey  <tom@tromey.com>
4848
4849         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4850         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4851         on obstack.
4852         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4853
4854 2019-05-08  Tom Tromey  <tom@tromey.com>
4855
4856         * mdebugread.c (basic_type_data): Change type.
4857         (basic_type, _initialize_mdebugread): Update.
4858
4859 2019-05-08  Tom Tromey  <tom@tromey.com>
4860
4861         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4862
4863 2019-05-08  Tom Tromey  <tom@tromey.com>
4864
4865         * nto-tdep.c (nto_inferior_data_reg): Change type.
4866         (nto_inferior_data): Update.
4867         (nto_inferior_data_cleanup, nto_new_inferior_data)
4868         (_initialize_nto_tdep): Remove.
4869         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4870
4871 2019-05-08  Tom Tromey  <tom@tromey.com>
4872
4873         * ada-lang.c (struct ada_inferior_data): Add initializers.
4874         (ada_inferior_data): Change type.
4875         (ada_inferior_data_cleanup): Remove.
4876         (get_ada_inferior_data, ada_inferior_exit)
4877         (struct ada_pspace_data): Add initializers, destructor.
4878         (ada_pspace_data_handle): Change type.
4879         (get_ada_pspace_data): Update.
4880         (ada_pspace_data_cleanup): Remove.
4881
4882 2019-05-08  Tom Tromey  <tom@tromey.com>
4883
4884         * coffread.c (struct coff_symfile_info): Add initializers.
4885         (coff_objfile_data_key): Move lower.  Change type.
4886         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4887         Update.
4888         (coff_free_info): Remove.
4889
4890 2019-05-08  Tom Tromey  <tom@tromey.com>
4891
4892         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4893         (fbsd_pspace_data_handle): Move lower.  Change type.
4894         (get_fbsd_pspace_data): Update.
4895         (fbsd_pspace_data_cleanup): Remove.
4896         (_initialize_fbsd_tdep): Update.
4897
4898 2019-05-08  Tom Tromey  <tom@tromey.com>
4899
4900         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4901         (get_ada_tasks_pspace_data): Update.
4902         (ada_tasks_pspace_data_cleanup): Remove.
4903         (_initialize_tasks): Update.
4904         (ada_tasks_inferior_data_handle): Change type.
4905         (get_ada_tasks_inferior_data): Update.
4906         (ada_tasks_inferior_data_cleanup): Remove.
4907         (struct ada_tasks_pspace_data): Add initializers.
4908
4909 2019-05-08  Tom Tromey  <tom@tromey.com>
4910
4911         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4912         * symfile-debug.c (debug_sym_get_probes): Change type.
4913         * stap-probe.c (handle_stap_probe):
4914         (stap_static_probe_ops::get_probes): Change type.
4915         * probe.h (class static_probe_ops) <get_probes>: Change type.
4916         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4917         (parse_probes_in_pspace): Update.
4918         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4919         Update.
4920         (any_static_probe_ops::get_probes): Change type.
4921         * elfread.c (elfread_data): New typedef.
4922         (probe_key): Change type.
4923         (elf_get_probes): Likewise.  Update.
4924         (probe_key_free): Remove.
4925         (_initialize_elfread): Update.
4926         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4927         Change type.
4928         (dtrace_process_dof_probe, dtrace_process_dof)
4929         (dtrace_static_probe_ops::get_probe): Change type.
4930
4931 2019-05-08  Tom Tromey  <tom@tromey.com>
4932
4933         * xcoffread.c (struct xcoff_symfile_info): Rename from
4934         coff_symfile_info.  Add initializers.
4935         (xcoff_objfile_data_key): Move lower.  Change type.
4936         (XCOFF_DATA): Rewrite.
4937         (xcoff_free_info): Remove.
4938         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4939         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4940         (xcoff_initial_scan): Update.
4941
4942 2019-05-08  Tom Tromey  <tom@tromey.com>
4943
4944         * solib-svr4.c (struct svr4_info): Add initializers and
4945         destructor.
4946         <probes_table>: Now an htab_up.
4947         (solib_svr4_pspace_data): Change type.
4948         (free_probes_table): Simplify.
4949         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4950         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4951         (probes_table_remove_objfile_probes, register_solib_event_probe)
4952         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4953         (_initialize_svr4_solib): Update.
4954
4955 2019-05-08  Tom Tromey  <tom@tromey.com>
4956
4957         * remote.c (remote_pspace_data): Change type.
4958         (remote_pspace_data_cleanup): Remove.
4959         (get_remote_exec_file, set_pspace_remote_exec_file)
4960         (_initialize_remote): Update.
4961
4962 2019-05-08  Tom Tromey  <tom@tromey.com>
4963
4964         * breakpoint.c (breakpoint_objfile_key): Change type.
4965         (get_breakpoint_objfile_data): Update.
4966         (free_breakpoint_objfile_data): Remove.
4967         (_initialize_breakpoint): Update.
4968
4969 2019-05-08  Tom Tromey  <tom@tromey.com>
4970
4971         * linux-tdep.c (struct linux_info): Add initializers.
4972         (linux_inferior_data): Move.  Change type.
4973         (invalidate_linux_cache_inf): Update.
4974         (linux_inferior_data_cleanup): Remove.
4975         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4976
4977 2019-05-08  Tom Tromey  <tom@tromey.com>
4978
4979         * auxv.c (auxv_inferior_data): Move.  Change type.
4980         (auxv_inferior_data_cleanup): Remove.
4981         (invalidate_auxv_cache_inf): Rewrite.
4982         (get_auxv_inferior_data, _initialize_auxv): Update.
4983
4984 2019-05-08  Tom Tromey  <tom@tromey.com>
4985
4986         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4987         (symfile_debug_objfile_data_key): Change type.
4988         (symfile_debug_installed, debug_qf_has_symbols)
4989         (debug_qf_find_last_source_symtab)
4990         (debug_qf_forget_cached_source_info)
4991         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4992         (debug_qf_print_stats, debug_qf_dump)
4993         (debug_qf_expand_symtabs_for_function)
4994         (debug_qf_expand_all_symtabs)
4995         (debug_qf_expand_symtabs_with_fullname)
4996         (debug_qf_map_matching_symbols)
4997         (debug_qf_expand_symtabs_matching)
4998         (debug_qf_find_pc_sect_compunit_symtab)
4999         (debug_qf_map_symbol_filenames)
5000         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5001         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5002         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5003         (debug_sym_read_linetable, debug_sym_relocate): Update.
5004         (symfile_debug_free_objfile): Remove.
5005         (install_symfile_debug_logging, _initialize_symfile_debug):
5006         Update.
5007
5008 2019-05-08  Tom Tromey  <tom@tromey.com>
5009
5010         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5011         allocate_on_obstack.
5012         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5013         (get_dwarf2_per_objfile): Update.
5014         (set_dwarf2_per_objfile): Remove.
5015         (dwarf2_has_info, dwarf2_get_section_info): Update.
5016         (dwarf2_free_objfile): Remove.
5017         (_initialize_dwarf2_read): Update.
5018
5019 2019-05-08  Tom Tromey  <tom@tromey.com>
5020
5021         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5022         initializers.
5023         <unsupported_script_warning_printed,
5024         script_not_found_warning_printed>: Now bool.
5025         (auto_load_pspace_data): Change type.
5026         (~auto_load_pspace_info): Rename from
5027         auto_load_pspace_data_cleanup.
5028         (get_auto_load_pspace_data, init_loaded_scripts_info)
5029         (clear_section_scripts, maybe_print_unsupported_script_warning)
5030         (maybe_print_script_not_found_warning, _initialize_auto_load):
5031         Update.
5032
5033 2019-05-08  Tom Tromey  <tom@tromey.com>
5034
5035         * objfiles.c (objfile_pspace_info): Add destructor and
5036         initializers.
5037         (objfiles_pspace_data): Change type.
5038         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5039         (get_objfile_pspace_data): Update.
5040         (objfiles_bfd_data): Change type.
5041         (get_objfile_bfd_data): Update.
5042         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5043
5044 2019-05-08  Tom Tromey  <tom@tromey.com>
5045
5046         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5047         Change type.
5048         (get_catch_syscall_inferior_data): Update.
5049         (catch_syscall_inferior_data_cleanup): Remove.
5050         (_initialize_break_catch_syscall): Update.
5051
5052 2019-05-08  Tom Tromey  <tom@tromey.com>
5053
5054         * inflow.c (struct terminal_info): Add destructor and
5055         initializers.
5056         (inflow_inferior_data): Change type.
5057         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5058         (get_inflow_inferior_data, inflow_inferior_exit)
5059         (swap_terminal_info, _initialize_inflow): Update.
5060
5061 2019-05-08  Tom Tromey  <tom@tromey.com>
5062
5063         * target-dcache.c (target_dcache_cleanup): Remove.
5064         (target_dcache_aspace_key): Change type.
5065         (target_dcache_init_p, target_dcache_invalidate)
5066         (target_dcache_get, target_dcache_get_or_init)
5067         (_initialize_target_dcache): Update.
5068         * dcache.h (struct dcache_deleter): New.
5069
5070 2019-05-08  Tom Tromey  <tom@tromey.com>
5071
5072         * symtab.c (struct symbol_cache): Add destructor and
5073         initializers.
5074         (symbol_cache_key): Move.  Change type.
5075         (make_symbol_cache, free_symbol_cache): Remove.
5076         (get_symbol_cache): Update.
5077         (symbol_cache_cleanup): Remove.
5078         (ALL_PSPACES, symbol_cache_flush)
5079         (maintenance_print_symbol_cache)
5080         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5081         Update.
5082
5083 2019-05-08  Tom Tromey  <tom@tromey.com>
5084
5085         * symtab.c (struct main_info): Add destructor and initializers.
5086         (main_progspace_key): Move.  Change type.
5087         (get_main_info): Update.
5088         (main_info_cleanup): Remove.
5089         (_initialize_symtab): Update.
5090
5091 2019-05-08  Tom Tromey  <tom@tromey.com>
5092
5093         * registry.h (DECLARE_REGISTRY): Define the _key class.
5094
5095 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5096
5097         * NEWS: Merge two 'New commands' sections.
5098
5099 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5100
5101         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5102         parameter and use Ada language definition instead.
5103         (ada_val_print_ptr): Remove unused language parameter.
5104         (ada_val_print_num): Remove language parameter and use Ada language
5105         definition instead.
5106         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5107         parameter.
5108         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5109         parameter and use Ada language definition instead.
5110         (ada_val_print_1): Update all ada_val_print_xxx calls.
5111         Remove language parameter.
5112         (ada_val_print): Update ada_val_print_1 call.
5113
5114 2019-05-08  Tom Tromey  <tromey@adacore.com>
5115
5116         * remote.c (remote_hw_watchpoint_limit)
5117         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5118         Now static.
5119
5120 2019-05-08  Tom Tromey  <tromey@adacore.com>
5121
5122         * maint.c (_initialize_maint_cmds): Move initialization code to
5123         remote.c.
5124         (watchdog, show_watchdog): Move to remote.c.
5125         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5126         "watchdog" static.
5127         (_initialize_remote): Move initialization code from maint.c.
5128         * defs.h (watchdog): Don't declare.
5129
5130 2019-05-08  Tom Tromey  <tromey@adacore.com>
5131
5132         * tui/tui-interp.c: Include main.h.
5133         * interps.c: Include main.h.
5134         * main.h (interpreter_p): Declare.
5135         * defs.h (interpreter_p): Don't declare.
5136
5137 2019-05-08  Tom Tromey  <tromey@adacore.com>
5138
5139         * dwarf2loc.c: Include dwarf2read.h.
5140         * defs.h (read_unsigned_leb128): Don't declare.
5141         * dwarf2read.h (read_unsigned_leb128): Declare.
5142
5143 2019-05-08  Tom Tromey  <tromey@adacore.com>
5144
5145         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5146         method.
5147
5148 2019-05-08  Tom Tromey  <tromey@adacore.com>
5149
5150         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5151         when no wrap column is set.
5152
5153 2019-05-08  Tom Tromey  <tromey@adacore.com>
5154
5155         * c-lang.c (c_get_string): Handle non-C-style arrays.
5156
5157 2019-05-08  Tom Tromey  <tromey@adacore.com>
5158
5159         * typeprint.c (print_offset_data::update): Print the bit offset,
5160         not the number of bits remaining.
5161
5162 2019-05-08  Tom Tromey  <tromey@adacore.com>
5163
5164         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5165         padding at end of comment.
5166
5167 2019-05-08  Tom Tromey  <tromey@adacore.com>
5168
5169         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5170         Compare main types.
5171
5172 2019-05-06  Tom Tromey  <tom@tromey.com>
5173
5174         * common/scoped_mmap.c: Include common-defs.h.
5175         * common/scoped_mmap.h: Don't include config.h.
5176
5177 2019-05-04  Tom Tromey  <tom@tromey.com>
5178
5179         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5180         (struct aarch64_call_info): Add initializers.
5181         <si>: Now a std::vector.
5182         (pass_on_stack, aarch64_push_dummy_call): Update.
5183
5184 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5185             Tom Tromey  <tom@tromey.com>
5186
5187         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5188         (ppc_threads): Now a std::vector.  Now static.
5189         (hwdebug_find_thread_points_by_tid)
5190         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5191         Update.
5192
5193 2019-05-04  Tom Tromey  <tom@tromey.com>
5194
5195         * arc-tdep.c (arc_tdesc_init): Return bool.
5196
5197 2019-05-04  Tom Tromey  <tom@tromey.com>
5198
5199         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5200         Use gdb_assert_not_reached.
5201
5202 2019-05-04  Tom Tromey  <tom@tromey.com>
5203
5204         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5205         "false".
5206
5207 2019-05-04  Tom Tromey  <tom@tromey.com>
5208
5209         * arc-tdep.c (arc_tdesc_init): Use bool.
5210
5211 2019-05-04  Tom Tromey  <tom@tromey.com>
5212
5213         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5214
5215 2019-05-04  Tom Tromey  <tom@tromey.com>
5216
5217         * cli/cli-cmds.c (valid_command_p): Return bool.
5218
5219 2019-05-04  Tom Tromey  <tom@tromey.com>
5220
5221         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5222         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5223
5224 2019-05-04  Raul Tambre  <raul@tambre.ee>
5225
5226         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5227         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5228         operator for comparison.
5229
5230 2019-05-04  Tom Tromey  <tom@tromey.com>
5231
5232         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5233         (lookup_partial_symbol, print_partial_symbols)
5234         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5235         (psymbol_compare): Update.
5236         (add_psymbol_to_bcache): Clear the entire psymbol.
5237         (maintenance_check_psymtabs): Update.
5238         * psympriv.h (struct partial_symbol): Don't derive from
5239         general_symbol_info.
5240         <obj_section, unrelocated_address, address,
5241         set_unrelocated_address>: Update.
5242         <ginfo>: New member.
5243         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5244         (debug_names::write_psymbols): Update.
5245
5246 2019-05-04  Tom de Vries  <tdevries@suse.de>
5247
5248         * contrib/cc-with-tweaks.sh: Support -n arg.
5249
5250 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5251
5252         * corelow.c (core_target::detach): Ensure frame cache and
5253         register caches are cleared.
5254         inferior.c (exit_inferior_1): Likewise.
5255
5256 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5257             Tom Tromey  <tom@tromey.com>
5258
5259         * dictionary.c (collate_pending_symbols_by_language): Remove
5260         "struct" from foreach.
5261         * symtab.c (lookup_global_symbol_from_objfile)
5262         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5263         foreach.
5264         * ser-tcp.c (net_open): Remove "struct" from foreach.
5265         * objfiles.c (objfile_relocate, objfile_rebase)
5266         (objfile_has_symbols): Remove "struct" from foreach.
5267         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5268         from foreach.
5269         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5270         foreach.
5271         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5272         "struct" from foreach.
5273         * ada-lang.c (create_excep_cond_exprs)
5274         (ada_exception_catchpoint_cond_string): Remove "struct" from
5275         foreach.
5276
5277 2019-05-03  Tom Tromey  <tromey@adacore.com>
5278
5279         * ada-exp.y (convert_char_literal): Check suffix of each
5280         enumerator.
5281
5282 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5283
5284         PR ada/21406:
5285         * ada-exp.y (yywrap): Don't define.
5286         * ada-lex.l (%option): Add noyywrap
5287         (yywrap): Remove.
5288
5289 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5290
5291         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5292         _WIN32_WINNT to the XP level, unless already defined to a higher
5293         level.
5294
5295         * unittests/parse-connection-spec-selftests.c:
5296         * ser-tcp.c:
5297         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5298         override.
5299
5300         * symfile.c (find_separate_debug_file): Remove colon from the
5301         drive spec of DOS/Windows file names of the target, so that the
5302         file name produced from DEBUGDIR and the target's directory will
5303         be valid on DOS/Windows systems.
5304
5305 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5306
5307         * rust-lang.c (val_print_struct): Handle printing structures
5308         containing strings.
5309
5310 2019-05-02  Tom Tromey  <tromey@adacore.com>
5311
5312         * valarith.c (_initialize_valarith): Remove.
5313
5314 2019-05-01  Tom Tromey  <tromey@adacore.com>
5315
5316         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5317         bitfields.
5318
5319 2019-05-01  Tom Tromey  <tromey@adacore.com>
5320
5321         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5322         for big-endian copies.
5323
5324 2019-04-30  Ali Tamur  <tamur@google.com>
5325         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5326         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5327         (read_3_bytes): New function.
5328
5329 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5330
5331         * windows-nat.c (main_thread_id): Delete.
5332         (handle_output_debug_string): Replace main_thread_id by
5333         current_event.dwThreadId.
5334         (fake_create_process): Likewise.
5335         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5336         Do not set main_thread_id.
5337         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5338         current_event.dwThreadId.
5339         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5340
5341 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5342
5343         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5344         Use current_event.dwThreadId instead of main_thread_id.
5345
5346 2019-04-30  Tom Tromey  <tromey@adacore.com>
5347
5348         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5349         (create_excep_cond_exprs): Iterate over program spaces.
5350         (ada_exception_catchpoint_cond_string): Examine all minimal
5351         symbols for exception types.
5352
5353 2019-04-30  Tom Tromey  <tromey@adacore.com>
5354
5355         PR c++/24470:
5356         * dwarf2read.c (process_structure_scope): Handle case where type
5357         has template parameters but no symbol was created.
5358
5359 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5360             Chris January  <chris.january@arm.com>
5361
5362         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5363         qualifier.
5364         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5365
5366 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5367
5368         * f-typeprint.c (f_print_type): Update rules for printing
5369         whitespace.
5370         (f_type_print_varspec_suffix): Likewise.
5371
5372 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5373             Chris January  <chris.january@arm.com>
5374
5375         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5376         function arguments.
5377
5378 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5379
5380         * f-lang.c (build_fortran_types): Change name of void type to
5381         lower case.
5382         * f-typeprint.c (f_type_print_base): Print the name of the void
5383         type, rather than a fixed string.
5384         * f-valprint.c (f_decorations): Use lower case void string.
5385
5386 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5387             Chris January  <chris.january@arm.com>
5388
5389         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5390         types for Fortran.
5391
5392 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5393             Chris January  <chris.january@arm.com>
5394             David Lecomber  <david.lecomber@arm.com>
5395
5396         * f-exp.y (BINOP_INTRINSIC): New token.
5397         (exp): New parser rule handling BINOP_INTRINSIC.
5398         (f77_keywords): Add new builtin procedures.
5399         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5400         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5401         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5402         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5403         (print_unop_subexp_f): New function.
5404         (print_binop_subexp_f): New function.
5405         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5406         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5407         (dump_subexp_body_f): Likewise.
5408         (operator_check_f): Likewise.
5409         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5410         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5411
5412 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5413
5414         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5415         UNOP_KIND.
5416         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5417         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5418         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5419         (operator_length_f): New fuction.
5420         (print_subexp_f): New function.
5421         (op_name_f): New function.
5422         (dump_subexp_body_f): New function.
5423         (operator_check_f): New function.
5424         (exp_descriptor_f): Replace standard expression handling functions
5425         with new functions.
5426         * gdb/fortran-operator.def: New file.
5427         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5428         * gdb/std-operator.def: Remove UNOP_KIND.
5429
5430 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5431
5432         * std-operator.def: Remove unbalanced, stray double quote
5433         character.
5434
5435 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5436             Chris January  <chris.january@arm.com>
5437             Daniel Everett  <daniel.everett@arm.com>
5438             Nick Forrington  <nick.forrington@arm.com>
5439             Richard Bunt  <richard.bunt@arm.com>
5440
5441         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5442         of depth when printing anonymous structs or unions.
5443         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5444         Don't print either the top-level value, or the children if the
5445         max-depth is exceeded.
5446         (ppscm_print_children): When printing the key of a map, allow one
5447         extra level of depth.
5448         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5449         print either the top-level value, or the children if the max-depth
5450         is exceeded.
5451         (print_children): When printing the key of a map, allow one extra
5452         level of depth.
5453         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5454         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5455         (user_print_options): Initialise max_depth field.
5456         (val_print_scalar_or_string_type_p): New function.
5457         (val_print): Check to see if the max depth has been reached.
5458         (val_print_check_max_depth): Define new function.
5459         (show_print_max_depth): New function.
5460         (_initialize_valprint): Add 'print max-depth' option.
5461         * valprint.h (struct value_print_options) <max_depth>: New field.
5462         (val_print_check_max_depth): Declare new function.
5463         * NEWS: Document new feature.
5464
5465 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5466
5467         * ada-lang.c (ada_language_defn): Initialise new field.
5468         * c-lang.c (c_is_string_type_p): New function.
5469         (c_language_defn): Initialise new field.
5470         (cplus_language_defn): Initialise new field.
5471         (asm_language_defn): Initialise new field.
5472         (minimal_language_defn): Initialise new field.
5473         * c-lang.h (c_is_string_type_p): Declare new function.
5474         * d-lang.c (d_language_defn): Initialise new field.
5475         * f-lang.c (f_is_string_type_p): New function.
5476         (f_language_defn): Initialise new field.
5477         * go-lang.c (go_is_string_type_p): New function.
5478         (go_language_defn): Initialise new field.
5479         * language.c (default_is_string_type_p): New function.
5480         (unknown_language_defn): Initialise new field.
5481         (auto_language_defn): Initialise new field.
5482         * language.h (struct language_defn) <la_is_string_type_p>: New
5483         member variable.
5484         (default_is_string_type_p): Declare new function.
5485         * m2-lang.c (m2_language_defn): Initialise new field.
5486         * objc-lang.c (objc_language_defn): Initialise new field.
5487         * opencl-lang.c (opencl_language_defn): Initialise new field.
5488         * p-lang.c (pascal_is_string_type_p): New function.
5489         (pascal_language_defn): Initialise new field.
5490         * rust-lang.c (rust_is_string_type_p): New function.
5491         (rust_language_defn): Initialise new field.
5492
5493 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5494
5495         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5496         New field.
5497         * ada-lang.c (ada_language_defn): Initialise new field.
5498         * c-lang.c (c_language_defn): Likewise.
5499         (cplus_language_defn): Likewise.
5500         (asm_language_defn): Likewise.
5501         (minimal_language_defn): Likewise.
5502         * d-lang.c (d_language_defn): Likewise.
5503         * f-lang.c (f_language_defn): Likewise.
5504         * go-lang.c (go_language_defn): Likewise.
5505         * language.c (unknown_language_defn): Likewise.
5506         (auto_language_defn): Likewise.
5507         * m2-lang.c (m2_language_defn): Likewise.
5508         * objc-lang.c (objc_language_defn): Likewise.
5509         * opencl-lang.c (opencl_language_defn): Likewise.
5510         * p-lang.c (pascal_language_defn): Likewise.
5511         * rust-lang.c (rust_language_defn): Likewise.
5512
5513 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5514
5515         * ada-lang.c (ada_is_character_type): Change return type to bool.
5516         (ada_is_string_type): Likewise.
5517         * ada-lang.h (ada_is_character_type): Update declaration
5518         (ada_is_string_type): Likewise.
5519
5520 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5521
5522         Support style in 'frame|thread apply'
5523
5524         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5525         * record.c (record_start, record_stop): Update callers of
5526         execute_command_to_string with false.
5527         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5528         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5529         methods.
5530         (class string_file): New constructor with term_out parameter.
5531         Override methods term_out and can_emit_style_escape.  New member
5532         term_out.
5533         (class stdio_file): Override can_emit_style_escape.
5534         (class tee_file): Override term_out and can_emit_style_escape.
5535         * utils.h (can_emit_style_escape): Remove.
5536         * utils.c (can_emit_style_escape): Likewise.
5537         Update all callers of can_emit_style_escape (SOMESTREAM) to
5538         SOMESTREAM->can_emit_style_escape.
5539         * source-cache.c (source_cache::get_source_lines): Likewise.
5540         * stack.c (frame_apply_command_count): Call execute_command_to_string
5541         passing the term_out characteristic of the current gdb_stdout.
5542         * thread.c (thr_try_catch_cmd): Likewise.
5543         * top.c (execute_command_to_string): pass term_out parameter
5544         to construct the string_file for the command output.
5545         * ui-file.c (term_cli_styling): New function (most code moved
5546         from utils.c can_emit_style_escape).
5547         (string_file::string_file, string_file::can_emit_style_escape,
5548         stdio_file::can_emit_style_escape, tee_file::term_out,
5549         tee_file::can_emit_style_escape): New functions.
5550
5551 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5552
5553         * NEWS: Mention the new set|show may-call-functions.
5554         * infcall.c (may_call_functions_p): New variable.
5555         (show_may_call_functions_p): New function.
5556         (call_function_by_hand_dummy): Throws an error if not
5557         may-call-functions.
5558         (_initialize_infcall): Call add_setshow_boolean_cmd for
5559         may-call-functions.
5560
5561 2019-04-25  Keith Seitz  <keiths@redhat.com>
5562
5563         PR c++/24367
5564         * cp-support.c (inspect_type): Don't attempt substitutions
5565         of symbol with the same name.
5566
5567 2019-04-25  Tom Tromey  <tromey@adacore.com>
5568
5569         PR gdb/24475:
5570         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5571         static.
5572
5573 2019-04-25  Tom Tromey  <tromey@adacore.com>
5574
5575         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5576         rvalue reference.
5577         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5578         (gdb_xml_parser::parse): Use std::move.
5579         * python/python-internal.h (gdbpy_convert_exception): Take a const
5580         reference.
5581         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5582         std::move.
5583         * python/py-utils.c (gdbpy_convert_exception): Take a const
5584         reference.
5585         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5586         Use std::move.
5587         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5588         Use std::move.
5589         * mi/mi-main.c (mi_print_exception): Take a const reference.
5590         * main.c (handle_command_errors): Take a const reference.
5591         * linespec.c (parse_linespec): Use std::move.
5592         * infcall.c (run_inferior_call): Use std::move.
5593         (call_function_by_hand_dummy): Use std::move.
5594         * exec.c (try_open_exec_file): Use std::move.
5595         * exceptions.h (exception_print, exception_fprintf)
5596         (exception_print_same): Update.
5597         * exceptions.c (print_exception, exception_print)
5598         (exception_fprintf, exception_print_same): Change parameters to
5599         const reference.
5600         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5601         * common/new-op.c: Use std::move.
5602         * common/common-exceptions.h (struct gdb_exception): Add move
5603         constructor.
5604         (struct gdb_exception_error, struct gdb_exception_quit, struct
5605         gdb_quit_bad_alloc): Change constructor to move constructor.
5606         (throw_exception): Change parameter to rvalue reference.
5607         * common/common-exceptions.c (throw_exception): Take rvalue
5608         reference.
5609         * cli/cli-interp.c (safe_execute_command): Use std::move.
5610         * breakpoint.c (insert_bp_location, location_to_sals): Use
5611         std::move.
5612
5613 2019-04-25  Tom Tromey  <tromey@adacore.com>
5614
5615         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5616         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5617         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5618         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5619         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5620         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5621         guile/scm-value.c: Use unpack.
5622         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5623         gdbscm_gdb_exception.
5624         (gdbscm_throw_gdb_exception): Likewise.
5625         (struct gdbscm_gdb_exception): New.
5626         (unpack): New function.
5627         (gdbscm_wrap): Use unpack.
5628
5629 2019-04-25  Tom Tromey  <tromey@adacore.com>
5630
5631         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5632         (gdb_rl_callback_handler): Use std::move.
5633         * common/common-exceptions.h (struct gdb_exception): Add move
5634         assignment operator.
5635         (throw_exception_sjlj): Change "exception" to const reference.
5636         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5637         (throw_exception_sjlj): Change "exception" to const reference.
5638
5639 2019-04-25  Tom Tromey  <tromey@adacore.com>
5640
5641         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5642         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5643         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5644         Update.
5645         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5646         Update.
5647         * mi/mi-interp.c (mi_interp::exec): Update.
5648         * linespec.c (parse_linespec): Update.
5649         * infcall.c (run_inferior_call): Update.
5650         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5651         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5652         (gdbscm_lookup_global_symbol): Update.
5653         * guile/scm-param.c (gdbscm_parameter_value): Update.
5654         * guile/scm-frame.c (gdbscm_frame_read_register)
5655         (gdbscm_frame_read_var): Update.
5656         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5657         * exec.c (try_open_exec_file): Update.
5658         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5659         (gdb_rl_callback_handler): Update.
5660         * common/common-exceptions.h (exception_none): Don't declare.
5661         * common/common-exceptions.c (exception_none): Don't define.
5662         (struct catcher) <exception>: Update.
5663         * cli/cli-interp.c (safe_execute_command): Update.
5664         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5665
5666 2019-04-25  Ali Tamur  <tamur@google.com>
5667
5668         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5669         (read_attribute_value): Likewise.
5670         (dwarf2_read_addr_index): Update comment.
5671         (read_str_index): Add DW_FORM_strx.
5672         (dwarf2_string_attr): Likewise.
5673         (dwarf2_const_value_attr): Likewise.
5674         (dump_die_shallow): Likewise.
5675         (dwarf2_fetch_constant_bytes): Likewise.
5676         (skip_form_bytes): Likewise.
5677         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5678
5679 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5680
5681         PR corefiles/11608
5682         PR corefiles/18187
5683         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5684         OFFSET.  Verify if current mapping contains an ELF header.
5685         (linux_find_memory_regions_full): Adjust call to
5686         dump_mapping_p.
5687
5688 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5689             Kang Li <kanglictf@gmail.com>
5690
5691         PR gdb/21600
5692
5693         * dwarf2-frame.c (read_initial_length): Be consistent about using
5694         unsigned representation of length.
5695         (decode_frame_entry_1): Likewise.  Check for wraparound of
5696         end pointer as well as buffer overflow.
5697
5698 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5699
5700         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5701         "vq".
5702
5703 2019-04-24  Tom Tromey  <tromey@adacore.com>
5704
5705         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5706
5707 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5708
5709         * s12z-tdep.c (s12z_unwind_pc): Delete.
5710         (s12z_unwind_sp): Delete.
5711         (s12z_gdbarch_init): Don't register deleted functions with
5712         gdbarch.
5713
5714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5715
5716         * rl78-tdep.c (rl78_unwind_sp): Delete.
5717         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5718
5719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5720
5721         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5722         (xstormy16_unwind_pc): Delete.
5723         (xstormy16_dummy_id): Delete.
5724         (xstormy16_gdbarch_init): Don't register deleted functions with
5725         gdbarch.
5726
5727 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5728
5729         * vax-tdep.c (vax_unwind_pc): Delete.
5730         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5731
5732 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5733
5734         * v850-tdep.c (v850_unwind_sp): Delete.
5735         (v850_unwind_pc): Delete.
5736         (v850_dummy_id): Delete.
5737         (v850_gdbarch_init): Don't register deleted functions with
5738         gdbarch.
5739
5740 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5741
5742         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5743         (tilegx_unwind_pc): Delete.
5744         (tilegx_unwind_dummy_id): Delete.
5745         (tilegx_gdbarch_init): Don't register deleted functions with
5746         gdbarch.
5747
5748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5749
5750         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5751         (tic6x_dummy_id): Delete.
5752         (tic6x_gdbarch_init): Don't register deleted functions with
5753         gdbarch.
5754
5755 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5756
5757         * sparc-tdep.c (sparc_unwind_pc): Delete.
5758         (sparc32_gdbarch_init): Don't register deleted function with
5759         gdbarch.
5760
5761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5762
5763         * sh-tdep.c (sh_unwind_sp): Delete.
5764         (sh_unwind_pc): Delete.
5765         (sh_dummy_id): Delete.
5766         (sh_gdbarch_init): Don't register deleted functions with
5767         gdbarch.
5768
5769 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5770
5771         * score-tdep.c (score_unwind_sp): Delete.
5772         (score_unwind_pc): Delete.
5773         (score_dummy_id): Delete.
5774         (score_gdbarch_init): Don't register deleted functions with
5775         gdbarch.
5776
5777 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5778
5779         * rx-tdep.c (rx_unwind_pc): Delete.
5780         (rx_unwind_sp): Delete.
5781         (rx_dummy_id): Delete.
5782         (rx_gdbarch_init): Don't register deleted functions with
5783         gdbarch.  Update comment.
5784
5785 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5786
5787         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5788         (rs6000_dummy_id): Delete.
5789         (rs6000_gdbarch_init): Don't register deleted functions with
5790         gdbarch.
5791
5792 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5793
5794         * or1k-tdep.c (or1k_dummy_id): Delete.
5795         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5796
5797 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5798
5799         * nios2-tdep.c (nios2_dummy_id): Delete.
5800         (nios2_unwind_sp): Delete.
5801         (nios2_gdbarch_init): Don't register deleted functions with
5802         gdbarch.
5803
5804 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5805
5806         * nds32-tdep.c (nds32_dummy_id): Delete.
5807         (nds32_unwind_pc): Delete.
5808         (nds32_unwind_sp): Delete.
5809         (nds32_gdbarch_init): Don't register deleted functions with
5810         gdbarch.
5811
5812 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5813
5814         * msp430-tdep.c (msp430_unwind_pc): Delete.
5815         (msp430_unwind_sp): Delete.
5816         (msp430_dummy_id): Delete.
5817         (msp430_gdbarch_init): Don't register deleted functions with
5818         gdbarch.
5819
5820 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5821
5822         * moxie-tdep.c (moxie_unwind_sp): Delete.
5823         (moxie_unwind_pc): Delete.
5824         (moxie_dummy_id): Delete.
5825         (moxie_gdbarch_init): Don't register deleted functions with
5826         gdbarch.
5827
5828 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5829
5830         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5831         (mn10300_unwind_pc): Delete.
5832         (mn10300_unwind_sp): Delete.
5833         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5834         mn10300_unwind_sp.
5835         (mn10300_frame_unwind_init): Don't register deleted functions with
5836         gdbarch.
5837
5838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5839
5840         * mep-tdep.c (mep_unwind_pc): Delete.
5841         (mep_unwind_sp): Delete.
5842         (mep_dummy_id): Delete.
5843         (mep_gdbarch_init): Don't register deleted functions with
5844         gdbarch.
5845
5846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5847
5848         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5849         (m68hc11_unwind_sp): Delete.
5850         (m68hc11_gdbarch_init): Don't register deleted functions with
5851         gdbarch.
5852
5853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5854
5855         * m32r-tdep.c (m32r_unwind_sp): Delete.
5856         (m32r_unwind_pc): Delete.
5857         (m32r_dummy_id): Delete.
5858         (m32r_gdbarch_init): Don't register deleted functions with
5859         gdbarch.
5860
5861 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5862
5863         * m32c-tdep.c (m32c_unwind_pc): Delete.
5864         (m32c_unwind_sp): Delete.
5865         (m32c_dummy_id): Delete.
5866         (m32c_gdbarch_init): Don't register deleted functions with
5867         gdbarch.
5868
5869 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5870
5871         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5872         (lm32_unwind_pc): Delete.
5873         (lm32_dummy_id): Delete.
5874         (lm32_gdbarch_init): Don't register deleted functions with
5875         gdbarch.
5876
5877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5878
5879         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5880         (iq2000_unwind_pc): Delete.
5881         (iq2000_dummy_id): Delete.
5882         (iq2000_gdbarch_init): Don't register deleted functions with
5883         gdbarch.
5884
5885 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5886
5887         * nds32-tdep.c (nds32_type_align): Delete.
5888         (nds32_push_dummy_call): Use type_align instead.
5889
5890 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5891
5892         * arm-tdep.c (arm_type_align): Only handle vector override case.
5893         (arm_push_dummy_call): Use type_align.
5894         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5895
5896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5897
5898         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5899         case.
5900         (pass_on_stack): Use type_align.
5901         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5902         function.
5903
5904 2019-04-23  Tom Tromey  <tromey@adacore.com>
5905
5906         * dwarf2read.c (line_header::file_name_at): Remove unused
5907         overload.
5908
5909 2019-04-23  Tom de Vries  <tdevries@suse.de>
5910
5911         PR gdb/24438
5912         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5913         invocation.
5914
5915
5916 2019-03-27  Ali Tamur  <tamur@google.com>
5917
5918         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5919         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5920         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5921         (dwarf_expr_context::get_addr_index): Likewise
5922         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5923         (symbol_needs_eval_context::get_addr_index): Likewise
5924         (disassemble_dwarf_expression): Add DW_OP_addrx
5925         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5926         (read_cutu_die_from_dwo): Update comment
5927         (skip_one_die): Add DW_FORM_addrx
5928         (read_attribute_value): Likewise
5929         (var_decode_location): Add DW_OP_addrx
5930         (dwarf2_const_value_attr): Add DW_FORM_addrx
5931         (dump_die_shallow): Likewise
5932         (dwarf2_fetch_constant_bytes): Likewise
5933         (decode_locdesc): Add DW_OP_addrx
5934         (skip_form_bytes): Add DW_FORM_addrx
5935
5936 2019-04-22  Ali Tamur  <tamur@google.com>
5937
5938         * MAINTAINERS (Write After Approval): Add self.
5939
5940 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5941
5942         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5943         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5944         (open_symbol_file_object): Likewise.
5945         (svr4_default_sos): Add info parameter.
5946         (svr4_read_so_list): Likewise.
5947         (svr4_current_sos_direct): Adjust functions calls to pass down
5948         info.
5949         (svr4_current_sos_1): Add info parameter.
5950         (svr4_current_sos): Call get_svr4_info, pass info down to
5951         svr4_current_sos_1.
5952         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5953         get_svr4_info.
5954         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5955         get_svr4_info.
5956         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5957         to get_svr4_info.
5958         (probes_table_remove_objfile_probes): Likewise.
5959         (register_solib_event_probe): Add info parameter.
5960         (solist_update_incremental): Pass info parameter down to
5961         svr4_read_so_list.
5962         (disable_probes_interface): Add info parameter.
5963         (svr4_handle_solib_event): Pass current_program_space to
5964         get_svr4_info.  Adjust disable_probes_interface cleanup.
5965         (svr4_create_probe_breakpoints): Add info parameter, pass it
5966         down to register_solib_event_probe.
5967         (svr4_create_solib_event_breakpoints): Add info parameter,
5968         pass it down to svr4_create_probe_breakpoints.
5969         (enable_break): Pass info down to
5970         svr4_create_solib_event_breakpoints.
5971         (svr4_solib_create_inferior_hook): Pass current_program_space to
5972         get_svr4_info.
5973         (svr4_clear_solib): Likewise.
5974
5975 2019-04-22  Pedro Alves  <palves@redhat.com>
5976
5977         * solib-svr4.c (svr4_free_objfile_observer): New.
5978         (probe_and_action::objfile): New field.
5979         (probes_table_htab_remove_objfile_probes)
5980         (probes_table_remove_objfile_probes): New functions.
5981         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5982         in the new probe_and_action.  Don't store the probe in 'lookup'.
5983         (svr4_create_probe_breakpoints): Pass objfile to
5984         register_solib_event_probe.
5985         (_initialize_svr4_solib): Register a free_objfile observer.
5986
5987 2019-04-19  Tom Tromey  <tom@tromey.com>
5988
5989         * common/queue.h: Remove.
5990
5991 2019-04-19  Tom Tromey  <tom@tromey.com>
5992
5993         * event-loop.c: Don't include "common/queue.h".
5994
5995 2019-04-19  Tom Tromey  <tom@tromey.com>
5996
5997         * remote.c (remote_target): Use delete.
5998         * remote-notif.h: Include <list>, not "common/queue.h".
5999         (notif_client_p): Remove typedef.
6000         (remote_notif_state): Add constructor, destructor, initializer.
6001         <notif_queue>: Now a std::list.
6002         (remote_notif_state_xfree): Don't declare.
6003         * remote-notif.c (remote_notif_process, handle_notification)
6004         (remote_notif_state_allocate): Update.
6005         (~remote_notif_state): Rename from remote_notif_state_xfree.
6006
6007 2019-04-19  Tom Tromey  <tom@tromey.com>
6008
6009         * symfile.c (reread_symbols): Update.
6010         * objfiles.c (objfile_register_static_link)
6011         (objfile_lookup_static_link): Update
6012         (~objfile) Don't delete static_links.
6013         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6014
6015 2019-04-19  Tom Tromey  <tom@tromey.com>
6016
6017         * type-stack.h (struct type_stack) <insert>: Constify string.
6018         * type-stack.c (type_stack::insert): Constify string.
6019         * gdbtypes.h (lookup_template_type): Update.
6020         (address_space_name_to_int): Update.
6021         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6022         const.
6023         (lookup_template_type): Make name const.
6024         * c-exp.y: Update rules.
6025         (lex_one_token, classify_name, classify_inner_name)
6026         (c_print_token): Update.
6027         * p-exp.y: Update rules.
6028         (yylex): Update.
6029         * f-exp.y: Update rules.
6030         (yylex): Update.
6031         * d-exp.y: Update rules.
6032         (lex_one_token, classify_name, classify_inner_name): Update.
6033         * parse.c (write_dollar_variable, copy_name): Return std::string.
6034         * parser-defs.h (copy_name): Change return type.
6035         * m2-exp.y: Update rules.
6036         (yylex): Update.
6037         * go-exp.y (lex_one_token): Update.
6038         Update rules.
6039         (classify_unsafe_function, classify_packaged_name)
6040         (classify_name, yylex): Update.
6041
6042 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6043
6044         * configure.ac: add --enable-source-highlight switch.
6045         * configure: Regenerate.
6046         * top.c (print_gdb_version): plumb --enable-source-highlight
6047         status to "show configuration".
6048
6049 2019-04-19  Tom Tromey  <tromey@adacore.com>
6050
6051         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6052         Check ADA_TYPE_P.
6053         (empty_record, ada_template_to_fixed_record_type_1)
6054         (template_to_static_fixed_type)
6055         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6056         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6057         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6058         macros.
6059
6060 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6061
6062         PR symtab/24423:
6063         * source.c (print_source_lines_base): Advance "iter" when a
6064         control character is seen.
6065
6066 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6067
6068         * inferior.h (struct infcall_suspend_state_deleter):
6069         Catch exception in destructor to avoid crash.
6070
6071 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6072
6073         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6074         close to the add_com "shell".
6075
6076 2019-04-18  Tom Tromey  <tromey@adacore.com>
6077
6078         * process-stratum-target.h (class process_stratum_target)
6079         <stratum>: Add "final".
6080
6081 2019-04-17  Tom Tromey  <tromey@adacore.com>
6082
6083         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6084         against nullptr before use.
6085
6086 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6087
6088         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6089
6090 2019-04-17  Jim Wilson  <jimw@sifive.com>
6091             Andrew Burgess  <andrew.burgess@embecosm.com>
6092
6093         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6094         code read might fail, assume 4-byte breakpoint in that case.
6095
6096 2019-04-15  Leszek Swirski  <leszeks@google.com>
6097
6098         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6099         rather than a hand-rolled POD check when checking for forced MEMORY
6100         classification.
6101
6102 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6103
6104         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6105         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6106         function.
6107         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6108         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6109         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6110         declaration.
6111
6112 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6113
6114         * aarch64-linux-nat.c
6115         (aarch64_linux_nat_target::thread_architecture): Add override.
6116         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6117         each VQ.
6118
6119 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6120
6121         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6122
6123 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6124
6125         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6126         target types of size 96-bits, add some additional comments, and
6127         check that the builtin type we found was the correct size.
6128
6129 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6130
6131         * utils.c (prompt_for_continue): Don't restore the styling at the
6132         end, as applied_style has the wrong value.  This fixes styling in
6133         long lists of file names that are interrupted by the "Continue?"
6134         prompt.
6135
6136 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6137
6138         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6139         * c-lang.c (c_language_defn): Likewise.
6140         (cplus_language_defn): Likewise.
6141         (asm_language_defn): Likewise.
6142         (minimal_language_defn): Likewise.
6143         * d-lang.c (d_language_defn): Likewise.
6144         * f-lang.c (f_language_defn): Likewise.
6145         * go-lang.c (go_language_defn): Likewise.
6146         * language.c (unknown_language_defn): Likewise.
6147         (auto_language_defn): Likewise.
6148         * language.h (struct language_defn): Remove la_magic field.
6149         (LANG_MAGIC): Delete.
6150         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6151         * objc-lang.c (objc_language_defn): Likewise.
6152         * opencl-lang.c (opencl_language_defn): Likewise.
6153         * p-lang.c (pascal_language_defn): Likewise.
6154         * rust-lang.c (rust_language_defn): Likewise.
6155
6156 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6157
6158         * riscv-tdep.c (riscv_type_align): New function.
6159         (riscv_type_alignment): Delete.
6160         (riscv_arg_location): Use 'type_align'.
6161         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6162
6163 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6164
6165         * gdbtypes.c (type_align): A struct with no non-static fields also
6166         has alignment of 1.
6167
6168 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6169
6170         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6171         component to 0.
6172         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6173         member.
6174         (riscv_struct_info::analyse): New implementation using new
6175         analyse_inner member function.
6176         (riscv_struct_info::field_offset): New member function.
6177         (riscv_struct_info::m_offsets): New member variable.
6178         (riscv_struct_info::analyse_inner): New private member function,
6179         takes the old implementation of riscv_struct_info::analyse but
6180         extended to track field offsets.
6181         (riscv_call_arg_struct): Update the struct folding special cases
6182         to handle cases where empty C++ structs, which are non-zero
6183         length, are found.
6184         (riscv_arg_location): Initialise the length of each location, a
6185         non-zero length now indicates the location is in use.
6186         (riscv_push_dummy_call): Allow for the first location having a
6187         non-zero offset when setting up arguments.
6188         (riscv_return_value): Likewise, but for return values.
6189
6190 2019-04-11  Tom Tromey  <tromey@adacore.com>
6191
6192         * utils.c (internal_vproblem): Make "msg" const.
6193
6194 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6195
6196         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6197         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6198         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6199         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6200
6201 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6202
6203         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6204         function.
6205         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6206         of amd64_collect_native_gregset.
6207         (amd64_linux_nat_target::store_registers): Likewise.
6208
6209 2019-04-10  Tom Tromey  <tom@tromey.com>
6210
6211         * symtab.c (lookup_global_symbol_from_objfile)
6212         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6213         * objfiles.h (class separate_debug_iterator): New.
6214         (class separate_debug_range): New.
6215         (struct objfile) <separate_debug_objfiles>: New method.
6216         (objfile_separate_debug_iterate): Don't declare.
6217         * objfiles.c (separate_debug_iterator::operator++): Rename from
6218         objfile_separate_debug_iterate.
6219         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6220         iterator.
6221         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6222         iterator.
6223
6224 2019-04-10  Tom Tromey  <tom@tromey.com>
6225
6226         * symfile.c (reread_symbols): Remove old comment.
6227         * objfiles.c (free_all_objfiles): Fix a typo.
6228
6229 2019-04-10  Tom Tromey  <tom@tromey.com>
6230
6231         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6232         * minsyms.c (lookup_minimal_symbol): Use foreach.
6233         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6234         (lookup_minimal_symbol_solib_trampoline): Likewise.
6235         * symfile.c (reread_symbols): Use foreach.
6236
6237 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6238             Tom Tromey  <tromey@adacore.com>
6239
6240         PR rust/24414:
6241         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6242         (rust_lex_int_test): Change "value" to be LONGEST.
6243         (rust_lex_tests): Add test for long integer literal.
6244
6245 2019-04-09  Tom Tromey  <tromey@adacore.com>
6246
6247         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6248         to bool.
6249         (extended_remote_target::attach): Update.
6250         (remote_target::remote_notice_new_inferior): Update.
6251         (remote_target::add_current_inferior_and_thread): Update.
6252         * inferior.c (exit_inferior_1): Use "false".
6253         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6254
6255 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6256
6257         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6258         the "start" command.
6259
6260 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6261
6262         * python/py-inferior.c (infpy_thread_from_thread_handle):
6263         Adjust comments to reflect renaming of thread_from_thread_handle
6264         to thread_from_handle.  Adjust keywords.  Fix type error message.
6265         (inferior_object_methods): Add thread_from_handle.  Retain
6266         thread_from_thread_handle, but mark it as deprecated.
6267
6268 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6269
6270         * gdbthread.h (find_thread_by_handle): Revise declaration.
6271         * thread.c (find_thread_by_handle): Likewise.  Adjust
6272         implementation too.
6273         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6274         support for buffer objects as handles.
6275
6276 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6277
6278         * python/py-infthread.c (thpy_thread_handle): New function.
6279         (thread_object_methods): Register thpy_thread_handle.
6280
6281 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6282
6283         * gdbthread.h (thread_to_thread_handle): Declare.
6284         * thread.c (gdbtypes.h): Include.
6285         (thread_to_thread_handle): New function.
6286
6287         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6288         (target_thread_info_to_thread_handle): Declare.
6289         * target.c (target_thread_info_to_thread_handle): New function.
6290         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6291         * target-delegates.c: Regenerate.
6292
6293         * linux-thread-db.c (class thread_db_target): Add method
6294         thread_info_to_thread_handle.
6295         (thread_db_target::thread_info_to_thread_handle): Define.
6296         * remote.c (class remote_target): Add new method
6297         thread_info_to_thread_handle.
6298         (remote_target::thread_info_to_thread_handle): Define.
6299
6300 2019-04-08  Pedro Alves  <palves@redhat.com>
6301
6302         * common/common-exceptions.c (throw_exception): Don't create
6303         named object to throw; throw directly.
6304         (throw_it): Likewise.  Don't initialize gdb_exception::message
6305         here, with new; pass FMT and AP to the ctor instead.
6306         * common/common-exceptions.h: Include <string>.
6307         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6308         const char *, va_list)): New ctor.  Use std::make_shared.
6309         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6310         errors)): Delete.
6311         (gdb_exception_error::gdb_exception_error(enum errors, const char
6312         *, va_list)): New.
6313         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6314         Add assertion.
6315         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6316         errors)): Delete.
6317         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6318         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6319         Add assertion.
6320
6321 2019-04-08  Tom Tromey  <tom@tromey.com>
6322
6323         * valops.c (value_rtti_indirect_type): Replace throw_exception
6324         with throw.
6325         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6326         with throw.
6327         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6328         throw.
6329         * target.c (target_translate_tls_address): Replace throw_exception
6330         with throw.
6331         * stack.c (frame_apply_command_count): Replace throw_exception
6332         with throw.
6333         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6334         throw.
6335         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6336         with throw.
6337         * rs6000-tdep.c (rs6000_frame_cache)
6338         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6339         * remote.c: Replace throw_exception with throw.
6340         * record-full.c (record_full_message, record_full_wait_1)
6341         (record_full_restore): Replace throw_exception with throw.
6342         * record-btrace.c:
6343         (get_thread_current_frame_id, record_btrace_start_replaying)
6344         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6345         (cmd_record_btrace_start): Replace throw_exception with throw.
6346         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6347         throw.
6348         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6349         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6350         * linespec.c:
6351         (find_linespec_symbols): Replace throw_exception with throw.
6352         * infrun.c (displaced_step_prepare, resume): Replace
6353         throw_exception with throw.
6354         * infcmd.c (post_create_inferior): Replace throw_exception with
6355         throw.
6356         * inf-loop.c (inferior_event_handler): Replace throw_exception
6357         with throw.
6358         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6359         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6360         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6361         (get_prev_frame_always, get_frame_pc_if_available)
6362         (get_frame_address_in_block_if_available, get_frame_language):
6363         Replace throw_exception with throw.
6364         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6365         throw_exception with throw.
6366         * eval.c (fetch_subexp_value, evaluate_var_value)
6367         (evaluate_funcall, evaluate_subexp_standard): Replace
6368         throw_exception with throw.
6369         * dwarf2loc.c (call_site_find_chain)
6370         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6371         Replace throw_exception with throw.
6372         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6373         with throw.
6374         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6375         throw.
6376         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6377         * completer.c (complete_line_internal): Replace throw_exception
6378         with throw.
6379         * compile/compile-object-run.c (compile_object_run): Replace
6380         throw_exception with throw.
6381         * cli/cli-script.c (process_next_line): Replace throw_exception
6382         with throw.
6383         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6384         (btrace_enable, btrace_maint_update_pt_packets): Replace
6385         throw_exception with throw.
6386         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6387         throw_exception with throw.
6388         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6389         throw_exception with throw.
6390         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6391         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6392         * aarch64-tdep.c (aarch64_make_prologue_cache)
6393         (aarch64_make_stub_cache): Replace throw_exception with throw.
6394
6395 2019-04-08  Tom Tromey  <tom@tromey.com>
6396
6397         * common/common-exceptions.c (throw_exception): Rename from
6398         throw_exception_cxx.  Remove old copy.  Make argument const.
6399         (throw_it): Create and throw exception objects directly.
6400         * common/common-exceptions.h (throw_exception): Make argument
6401         const.
6402         (struct gdb_exception_error): Add constructor.
6403         (struct gdb_exception_quit): Add constructor.
6404
6405 2019-04-08  Tom Tromey  <tom@tromey.com>
6406
6407         * common/common-exceptions.h (exception_rethrow): Don't declare.
6408         (TRY_SJLJ): Update comment.
6409         (TRY, CATCH, END_CATCH): Remove.
6410         * common/common-exceptions.c (exception_rethrow): Remove.
6411
6412 2019-04-08  Tom Tromey  <tom@tromey.com>
6413
6414         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6415         Remove.
6416         (gdb_exception_error): Rename from
6417         gdb_exception_RETURN_MASK_ERROR.
6418         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6419         (gdb_quit_bad_alloc): Update.
6420         * aarch64-tdep.c: Update.
6421         * ada-lang.c: Update.
6422         * ada-typeprint.c: Update.
6423         * ada-valprint.c: Update.
6424         * amd64-tdep.c: Update.
6425         * arch-utils.c: Update.
6426         * break-catch-throw.c: Update.
6427         * breakpoint.c: Update.
6428         * btrace.c: Update.
6429         * c-varobj.c: Update.
6430         * cli/cli-cmds.c: Update.
6431         * cli/cli-interp.c: Update.
6432         * cli/cli-script.c: Update.
6433         * common/common-exceptions.c: Update.
6434         * common/new-op.c: Update.
6435         * common/selftest.c: Update.
6436         * compile/compile-c-symbols.c: Update.
6437         * compile/compile-cplus-symbols.c: Update.
6438         * compile/compile-object-load.c: Update.
6439         * compile/compile-object-run.c: Update.
6440         * completer.c: Update.
6441         * corelow.c: Update.
6442         * cp-abi.c: Update.
6443         * cp-support.c: Update.
6444         * cp-valprint.c: Update.
6445         * darwin-nat.c: Update.
6446         * disasm-selftests.c: Update.
6447         * dtrace-probe.c: Update.
6448         * dwarf-index-cache.c: Update.
6449         * dwarf-index-write.c: Update.
6450         * dwarf2-frame-tailcall.c: Update.
6451         * dwarf2-frame.c: Update.
6452         * dwarf2loc.c: Update.
6453         * dwarf2read.c: Update.
6454         * eval.c: Update.
6455         * event-loop.c: Update.
6456         * event-top.c: Update.
6457         * exec.c: Update.
6458         * f-valprint.c: Update.
6459         * fbsd-tdep.c: Update.
6460         * frame-unwind.c: Update.
6461         * frame.c: Update.
6462         * gdbtypes.c: Update.
6463         * gnu-v3-abi.c: Update.
6464         * guile/guile-internal.h: Update.
6465         * guile/scm-block.c: Update.
6466         * guile/scm-breakpoint.c: Update.
6467         * guile/scm-cmd.c: Update.
6468         * guile/scm-disasm.c: Update.
6469         * guile/scm-frame.c: Update.
6470         * guile/scm-lazy-string.c: Update.
6471         * guile/scm-math.c: Update.
6472         * guile/scm-param.c: Update.
6473         * guile/scm-ports.c: Update.
6474         * guile/scm-pretty-print.c: Update.
6475         * guile/scm-symbol.c: Update.
6476         * guile/scm-symtab.c: Update.
6477         * guile/scm-type.c: Update.
6478         * guile/scm-value.c: Update.
6479         * i386-linux-tdep.c: Update.
6480         * i386-tdep.c: Update.
6481         * inf-loop.c: Update.
6482         * infcall.c: Update.
6483         * infcmd.c: Update.
6484         * infrun.c: Update.
6485         * jit.c: Update.
6486         * language.c: Update.
6487         * linespec.c: Update.
6488         * linux-fork.c: Update.
6489         * linux-nat.c: Update.
6490         * linux-tdep.c: Update.
6491         * linux-thread-db.c: Update.
6492         * main.c: Update.
6493         * mi/mi-cmd-break.c: Update.
6494         * mi/mi-cmd-stack.c: Update.
6495         * mi/mi-interp.c: Update.
6496         * mi/mi-main.c: Update.
6497         * objc-lang.c: Update.
6498         * p-valprint.c: Update.
6499         * parse.c: Update.
6500         * ppc-linux-tdep.c: Update.
6501         * printcmd.c: Update.
6502         * python/py-arch.c: Update.
6503         * python/py-breakpoint.c: Update.
6504         * python/py-cmd.c: Update.
6505         * python/py-finishbreakpoint.c: Update.
6506         * python/py-frame.c: Update.
6507         * python/py-framefilter.c: Update.
6508         * python/py-gdb-readline.c: Update.
6509         * python/py-inferior.c: Update.
6510         * python/py-infthread.c: Update.
6511         * python/py-lazy-string.c: Update.
6512         * python/py-linetable.c: Update.
6513         * python/py-objfile.c: Update.
6514         * python/py-param.c: Update.
6515         * python/py-prettyprint.c: Update.
6516         * python/py-progspace.c: Update.
6517         * python/py-record-btrace.c: Update.
6518         * python/py-record.c: Update.
6519         * python/py-symbol.c: Update.
6520         * python/py-type.c: Update.
6521         * python/py-unwind.c: Update.
6522         * python/py-utils.c: Update.
6523         * python/py-value.c: Update.
6524         * python/python.c: Update.
6525         * record-btrace.c: Update.
6526         * record-full.c: Update.
6527         * remote-fileio.c: Update.
6528         * remote.c: Update.
6529         * riscv-tdep.c: Update.
6530         * rs6000-aix-tdep.c: Update.
6531         * rs6000-tdep.c: Update.
6532         * rust-exp.y: Update.
6533         * rust-lang.c: Update.
6534         * s390-tdep.c: Update.
6535         * selftest-arch.c: Update.
6536         * solib-dsbt.c: Update.
6537         * solib-frv.c: Update.
6538         * solib-spu.c: Update.
6539         * solib-svr4.c: Update.
6540         * solib.c: Update.
6541         * sparc64-linux-tdep.c: Update.
6542         * stack.c: Update.
6543         * symfile-mem.c: Update.
6544         * symmisc.c: Update.
6545         * target.c: Update.
6546         * thread.c: Update.
6547         * top.c: Update.
6548         * tracefile-tfile.c: Update.
6549         * tui/tui.c: Update.
6550         * typeprint.c: Update.
6551         * unittests/cli-utils-selftests.c: Update.
6552         * unittests/parse-connection-spec-selftests.c: Update.
6553         * valops.c: Update.
6554         * valprint.c: Update.
6555         * value.c: Update.
6556         * varobj.c: Update.
6557         * windows-nat.c: Update.
6558         * x86-linux-nat.c: Update.
6559         * xml-support.c: Update.
6560
6561 2019-04-08  Tom Tromey  <tom@tromey.com>
6562
6563         * xml-support.c: Use C++ exception handling.
6564         * x86-linux-nat.c: Use C++ exception handling.
6565         * windows-nat.c: Use C++ exception handling.
6566         * varobj.c: Use C++ exception handling.
6567         * value.c: Use C++ exception handling.
6568         * valprint.c: Use C++ exception handling.
6569         * valops.c: Use C++ exception handling.
6570         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6571         handling.
6572         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6573         * typeprint.c: Use C++ exception handling.
6574         * tui/tui.c: Use C++ exception handling.
6575         * tracefile-tfile.c: Use C++ exception handling.
6576         * top.c: Use C++ exception handling.
6577         * thread.c: Use C++ exception handling.
6578         * target.c: Use C++ exception handling.
6579         * symmisc.c: Use C++ exception handling.
6580         * symfile-mem.c: Use C++ exception handling.
6581         * stack.c: Use C++ exception handling.
6582         * sparc64-linux-tdep.c: Use C++ exception handling.
6583         * solib.c: Use C++ exception handling.
6584         * solib-svr4.c: Use C++ exception handling.
6585         * solib-spu.c: Use C++ exception handling.
6586         * solib-frv.c: Use C++ exception handling.
6587         * solib-dsbt.c: Use C++ exception handling.
6588         * selftest-arch.c: Use C++ exception handling.
6589         * s390-tdep.c: Use C++ exception handling.
6590         * rust-lang.c: Use C++ exception handling.
6591         * rust-exp.y: Use C++ exception handling.
6592         * rs6000-tdep.c: Use C++ exception handling.
6593         * rs6000-aix-tdep.c: Use C++ exception handling.
6594         * riscv-tdep.c: Use C++ exception handling.
6595         * remote.c: Use C++ exception handling.
6596         * remote-fileio.c: Use C++ exception handling.
6597         * record-full.c: Use C++ exception handling.
6598         * record-btrace.c: Use C++ exception handling.
6599         * python/python.c: Use C++ exception handling.
6600         * python/py-value.c: Use C++ exception handling.
6601         * python/py-utils.c: Use C++ exception handling.
6602         * python/py-unwind.c: Use C++ exception handling.
6603         * python/py-type.c: Use C++ exception handling.
6604         * python/py-symbol.c: Use C++ exception handling.
6605         * python/py-record.c: Use C++ exception handling.
6606         * python/py-record-btrace.c: Use C++ exception handling.
6607         * python/py-progspace.c: Use C++ exception handling.
6608         * python/py-prettyprint.c: Use C++ exception handling.
6609         * python/py-param.c: Use C++ exception handling.
6610         * python/py-objfile.c: Use C++ exception handling.
6611         * python/py-linetable.c: Use C++ exception handling.
6612         * python/py-lazy-string.c: Use C++ exception handling.
6613         * python/py-infthread.c: Use C++ exception handling.
6614         * python/py-inferior.c: Use C++ exception handling.
6615         * python/py-gdb-readline.c: Use C++ exception handling.
6616         * python/py-framefilter.c: Use C++ exception handling.
6617         * python/py-frame.c: Use C++ exception handling.
6618         * python/py-finishbreakpoint.c: Use C++ exception handling.
6619         * python/py-cmd.c: Use C++ exception handling.
6620         * python/py-breakpoint.c: Use C++ exception handling.
6621         * python/py-arch.c: Use C++ exception handling.
6622         * printcmd.c: Use C++ exception handling.
6623         * ppc-linux-tdep.c: Use C++ exception handling.
6624         * parse.c: Use C++ exception handling.
6625         * p-valprint.c: Use C++ exception handling.
6626         * objc-lang.c: Use C++ exception handling.
6627         * mi/mi-main.c: Use C++ exception handling.
6628         * mi/mi-interp.c: Use C++ exception handling.
6629         * mi/mi-cmd-stack.c: Use C++ exception handling.
6630         * mi/mi-cmd-break.c: Use C++ exception handling.
6631         * main.c: Use C++ exception handling.
6632         * linux-thread-db.c: Use C++ exception handling.
6633         * linux-tdep.c: Use C++ exception handling.
6634         * linux-nat.c: Use C++ exception handling.
6635         * linux-fork.c: Use C++ exception handling.
6636         * linespec.c: Use C++ exception handling.
6637         * language.c: Use C++ exception handling.
6638         * jit.c: Use C++ exception handling.
6639         * infrun.c: Use C++ exception handling.
6640         * infcmd.c: Use C++ exception handling.
6641         * infcall.c: Use C++ exception handling.
6642         * inf-loop.c: Use C++ exception handling.
6643         * i386-tdep.c: Use C++ exception handling.
6644         * i386-linux-tdep.c: Use C++ exception handling.
6645         * guile/scm-value.c: Use C++ exception handling.
6646         * guile/scm-type.c: Use C++ exception handling.
6647         * guile/scm-symtab.c: Use C++ exception handling.
6648         * guile/scm-symbol.c: Use C++ exception handling.
6649         * guile/scm-pretty-print.c: Use C++ exception handling.
6650         * guile/scm-ports.c: Use C++ exception handling.
6651         * guile/scm-param.c: Use C++ exception handling.
6652         * guile/scm-math.c: Use C++ exception handling.
6653         * guile/scm-lazy-string.c: Use C++ exception handling.
6654         * guile/scm-frame.c: Use C++ exception handling.
6655         * guile/scm-disasm.c: Use C++ exception handling.
6656         * guile/scm-cmd.c: Use C++ exception handling.
6657         * guile/scm-breakpoint.c: Use C++ exception handling.
6658         * guile/scm-block.c: Use C++ exception handling.
6659         * guile/guile-internal.h: Use C++ exception handling.
6660         * gnu-v3-abi.c: Use C++ exception handling.
6661         * gdbtypes.c: Use C++ exception handling.
6662         * frame.c: Use C++ exception handling.
6663         * frame-unwind.c: Use C++ exception handling.
6664         * fbsd-tdep.c: Use C++ exception handling.
6665         * f-valprint.c: Use C++ exception handling.
6666         * exec.c: Use C++ exception handling.
6667         * event-top.c: Use C++ exception handling.
6668         * event-loop.c: Use C++ exception handling.
6669         * eval.c: Use C++ exception handling.
6670         * dwarf2read.c: Use C++ exception handling.
6671         * dwarf2loc.c: Use C++ exception handling.
6672         * dwarf2-frame.c: Use C++ exception handling.
6673         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6674         * dwarf-index-write.c: Use C++ exception handling.
6675         * dwarf-index-cache.c: Use C++ exception handling.
6676         * dtrace-probe.c: Use C++ exception handling.
6677         * disasm-selftests.c: Use C++ exception handling.
6678         * darwin-nat.c: Use C++ exception handling.
6679         * cp-valprint.c: Use C++ exception handling.
6680         * cp-support.c: Use C++ exception handling.
6681         * cp-abi.c: Use C++ exception handling.
6682         * corelow.c: Use C++ exception handling.
6683         * completer.c: Use C++ exception handling.
6684         * compile/compile-object-run.c: Use C++ exception handling.
6685         * compile/compile-object-load.c: Use C++ exception handling.
6686         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6687         * compile/compile-c-symbols.c: Use C++ exception handling.
6688         * common/selftest.c: Use C++ exception handling.
6689         * common/new-op.c: Use C++ exception handling.
6690         * cli/cli-script.c: Use C++ exception handling.
6691         * cli/cli-interp.c: Use C++ exception handling.
6692         * cli/cli-cmds.c: Use C++ exception handling.
6693         * c-varobj.c: Use C++ exception handling.
6694         * btrace.c: Use C++ exception handling.
6695         * breakpoint.c: Use C++ exception handling.
6696         * break-catch-throw.c: Use C++ exception handling.
6697         * arch-utils.c: Use C++ exception handling.
6698         * amd64-tdep.c: Use C++ exception handling.
6699         * ada-valprint.c: Use C++ exception handling.
6700         * ada-typeprint.c: Use C++ exception handling.
6701         * ada-lang.c: Use C++ exception handling.
6702         * aarch64-tdep.c: Use C++ exception handling.
6703
6704 2019-04-08  Tom Tromey  <tom@tromey.com>
6705
6706         * xml-support.c (gdb_xml_parser::parse): Update.
6707         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6708         * value.c (show_convenience): Update.
6709         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6710         (test_parse_flags_qcs): Update.
6711         * thread.c (thr_try_catch_cmd): Update.
6712         * target.c (target_translate_tls_address): Update.
6713         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6714         (info_frame_command_core, frame_apply_command_count): Update.
6715         * rust-exp.y (rust_lex_exception_test): Update.
6716         * riscv-tdep.c (riscv_print_one_register_info): Update.
6717         * remote.c (remote_target::enable_btrace): Update.
6718         * record-btrace.c (record_btrace_enable_warn): Update.
6719         * python/py-utils.c (gdbpy_convert_exception): Update.
6720         * printcmd.c (do_one_display, print_variable_and_value): Update.
6721         * mi/mi-main.c (mi_print_exception): Update.
6722         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6723         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6724         * linux-nat.c (linux_nat_target::attach): Update.
6725         * linux-fork.c (class scoped_switch_fork_info): Update.
6726         * infrun.c (displaced_step_prepare): Update.
6727         * infcall.c (call_function_by_hand_dummy): Update.
6728         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6729         * gnu-v3-abi.c (print_one_vtable): Update.
6730         * frame.c (get_prev_frame_always): Update.
6731         * f-valprint.c (info_common_command_for_block): Update.
6732         * exec.c (try_open_exec_file): Update.
6733         * exceptions.c (print_exception, exception_print)
6734         (exception_fprintf, exception_print_same): Update.
6735         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6736         * dwarf-index-cache.c (index_cache::store)
6737         (index_cache::lookup_gdb_index): Update.
6738         * darwin-nat.c (maybe_cache_shell): Update.
6739         * cp-valprint.c (cp_print_value_fields): Update.
6740         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6741         (gcc_cplus_symbol_address): Update.
6742         * compile/compile-c-symbols.c (gcc_convert_symbol)
6743         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6744         * common/selftest.c: Update.
6745         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6746         a std::string.
6747         (exception_try_scope_entry, exception_try_scope_exit): Don't
6748         declare.
6749         (struct exception_try_scope): Remove.
6750         (TRY): Don't use exception_try_scope.
6751         (struct gdb_exception): Add constructor, operator=.
6752         <what>: New method.
6753         (struct gdb_exception_RETURN_MASK_ALL)
6754         (struct gdb_exception_RETURN_MASK_ERROR)
6755         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6756         (struct gdb_quit_bad_alloc): Update.
6757         * common/common-exceptions.c (exception_none): Change
6758         initializer.
6759         (struct catcher) <state, exception>: Initialize inline.
6760         <prev>: Remove member.
6761         (current_catcher): Remove.
6762         (catchers): New global.
6763         (exceptions_state_mc_init): Simplify.
6764         (catcher_pop): Remove.
6765         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6766         (try_scope_depth, exception_try_scope_entry)
6767         (exception_try_scope_exit): Remove.
6768         (throw_exception_sjlj): Update.
6769         (exception_messages, exception_messages_size): Remove.
6770         (throw_it): Simplify.
6771         (gdb_exception_sliced_copy): Remove.
6772         (throw_exception_cxx): Update.
6773         * cli/cli-script.c (script_from_file): Update.
6774         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6775         Update.
6776         * ada-valprint.c (ada_val_print): Update.
6777         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6778         (create_excep_cond_exprs): Update.
6779
6780 2019-04-08  Tom Tromey  <tom@tromey.com>
6781
6782         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6783         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6784         (TRY, CATCH, END_CATCH): Remove some definitions.
6785         * common/common-exceptions.c: Don't use GDB_XCPT.
6786         (catcher_list_size): Remove.
6787         (throw_exception, throw_it): Simplify.
6788
6789 2019-04-05  Tom Tromey  <tom@tromey.com>
6790
6791         Revert the header-sorting patch.
6792         * ft32-tdep.c: Revert.
6793         * frv-tdep.c: Revert.
6794         * frv-linux-tdep.c: Revert.
6795         * frame.c: Revert.
6796         * frame-unwind.c: Revert.
6797         * frame-base.c: Revert.
6798         * fork-child.c: Revert.
6799         * findvar.c: Revert.
6800         * findcmd.c: Revert.
6801         * filesystem.c: Revert.
6802         * filename-seen-cache.h: Revert.
6803         * filename-seen-cache.c: Revert.
6804         * fbsd-tdep.c: Revert.
6805         * fbsd-nat.h: Revert.
6806         * fbsd-nat.c: Revert.
6807         * f-valprint.c: Revert.
6808         * f-typeprint.c: Revert.
6809         * f-lang.c: Revert.
6810         * extension.h: Revert.
6811         * extension.c: Revert.
6812         * extension-priv.h: Revert.
6813         * expprint.c: Revert.
6814         * exec.h: Revert.
6815         * exec.c: Revert.
6816         * exceptions.c: Revert.
6817         * event-top.c: Revert.
6818         * event-loop.c: Revert.
6819         * eval.c: Revert.
6820         * elfread.c: Revert.
6821         * dwarf2read.h: Revert.
6822         * dwarf2read.c: Revert.
6823         * dwarf2loc.c: Revert.
6824         * dwarf2expr.h: Revert.
6825         * dwarf2expr.c: Revert.
6826         * dwarf2-frame.c: Revert.
6827         * dwarf2-frame-tailcall.c: Revert.
6828         * dwarf-index-write.h: Revert.
6829         * dwarf-index-write.c: Revert.
6830         * dwarf-index-common.c: Revert.
6831         * dwarf-index-cache.h: Revert.
6832         * dwarf-index-cache.c: Revert.
6833         * dummy-frame.c: Revert.
6834         * dtrace-probe.c: Revert.
6835         * disasm.h: Revert.
6836         * disasm.c: Revert.
6837         * disasm-selftests.c: Revert.
6838         * dictionary.c: Revert.
6839         * dicos-tdep.c: Revert.
6840         * demangle.c: Revert.
6841         * dcache.h: Revert.
6842         * dcache.c: Revert.
6843         * darwin-nat.h: Revert.
6844         * darwin-nat.c: Revert.
6845         * darwin-nat-info.c: Revert.
6846         * d-valprint.c: Revert.
6847         * d-namespace.c: Revert.
6848         * d-lang.c: Revert.
6849         * ctf.c: Revert.
6850         * csky-tdep.c: Revert.
6851         * csky-linux-tdep.c: Revert.
6852         * cris-tdep.c: Revert.
6853         * cris-linux-tdep.c: Revert.
6854         * cp-valprint.c: Revert.
6855         * cp-support.c: Revert.
6856         * cp-namespace.c: Revert.
6857         * cp-abi.c: Revert.
6858         * corelow.c: Revert.
6859         * corefile.c: Revert.
6860         * continuations.c: Revert.
6861         * completer.h: Revert.
6862         * completer.c: Revert.
6863         * complaints.c: Revert.
6864         * coffread.c: Revert.
6865         * coff-pe-read.c: Revert.
6866         * cli-out.h: Revert.
6867         * cli-out.c: Revert.
6868         * charset.c: Revert.
6869         * c-varobj.c: Revert.
6870         * c-valprint.c: Revert.
6871         * c-typeprint.c: Revert.
6872         * c-lang.c: Revert.
6873         * buildsym.c: Revert.
6874         * buildsym-legacy.c: Revert.
6875         * build-id.h: Revert.
6876         * build-id.c: Revert.
6877         * btrace.c: Revert.
6878         * bsd-uthread.c: Revert.
6879         * breakpoint.h: Revert.
6880         * breakpoint.c: Revert.
6881         * break-catch-throw.c: Revert.
6882         * break-catch-syscall.c: Revert.
6883         * break-catch-sig.c: Revert.
6884         * blockframe.c: Revert.
6885         * block.c: Revert.
6886         * bfin-tdep.c: Revert.
6887         * bfin-linux-tdep.c: Revert.
6888         * bfd-target.c: Revert.
6889         * bcache.c: Revert.
6890         * ax-general.c: Revert.
6891         * ax-gdb.h: Revert.
6892         * ax-gdb.c: Revert.
6893         * avr-tdep.c: Revert.
6894         * auxv.c: Revert.
6895         * auto-load.c: Revert.
6896         * arm-wince-tdep.c: Revert.
6897         * arm-tdep.c: Revert.
6898         * arm-symbian-tdep.c: Revert.
6899         * arm-pikeos-tdep.c: Revert.
6900         * arm-obsd-tdep.c: Revert.
6901         * arm-nbsd-tdep.c: Revert.
6902         * arm-nbsd-nat.c: Revert.
6903         * arm-linux-tdep.c: Revert.
6904         * arm-linux-nat.c: Revert.
6905         * arm-fbsd-tdep.c: Revert.
6906         * arm-fbsd-nat.c: Revert.
6907         * arm-bsd-tdep.c: Revert.
6908         * arch-utils.c: Revert.
6909         * arc-tdep.c: Revert.
6910         * arc-newlib-tdep.c: Revert.
6911         * annotate.h: Revert.
6912         * annotate.c: Revert.
6913         * amd64-windows-tdep.c: Revert.
6914         * amd64-windows-nat.c: Revert.
6915         * amd64-tdep.c: Revert.
6916         * amd64-sol2-tdep.c: Revert.
6917         * amd64-obsd-tdep.c: Revert.
6918         * amd64-obsd-nat.c: Revert.
6919         * amd64-nbsd-tdep.c: Revert.
6920         * amd64-nbsd-nat.c: Revert.
6921         * amd64-nat.c: Revert.
6922         * amd64-linux-tdep.c: Revert.
6923         * amd64-linux-nat.c: Revert.
6924         * amd64-fbsd-tdep.c: Revert.
6925         * amd64-fbsd-nat.c: Revert.
6926         * amd64-dicos-tdep.c: Revert.
6927         * amd64-darwin-tdep.c: Revert.
6928         * amd64-bsd-nat.c: Revert.
6929         * alpha-tdep.c: Revert.
6930         * alpha-obsd-tdep.c: Revert.
6931         * alpha-nbsd-tdep.c: Revert.
6932         * alpha-mdebug-tdep.c: Revert.
6933         * alpha-linux-tdep.c: Revert.
6934         * alpha-linux-nat.c: Revert.
6935         * alpha-bsd-tdep.c: Revert.
6936         * alpha-bsd-nat.c: Revert.
6937         * aix-thread.c: Revert.
6938         * agent.c: Revert.
6939         * addrmap.c: Revert.
6940         * ada-varobj.c: Revert.
6941         * ada-valprint.c: Revert.
6942         * ada-typeprint.c: Revert.
6943         * ada-tasks.c: Revert.
6944         * ada-lang.c: Revert.
6945         * aarch64-tdep.c: Revert.
6946         * aarch64-ravenscar-thread.c: Revert.
6947         * aarch64-newlib-tdep.c: Revert.
6948         * aarch64-linux-tdep.c: Revert.
6949         * aarch64-linux-nat.c: Revert.
6950         * aarch64-fbsd-tdep.c: Revert.
6951         * aarch64-fbsd-nat.c: Revert.
6952         * aarch32-linux-nat.c: Revert.
6953
6954 2019-04-05  Tom Tromey  <tom@tromey.com>
6955
6956         * ft32-tdep.c: Sort headers.
6957         * frv-tdep.c: Sort headers.
6958         * frv-linux-tdep.c: Sort headers.
6959         * frame.c: Sort headers.
6960         * frame-unwind.c: Sort headers.
6961         * frame-base.c: Sort headers.
6962         * fork-child.c: Sort headers.
6963         * findvar.c: Sort headers.
6964         * findcmd.c: Sort headers.
6965         * filesystem.c: Sort headers.
6966         * filename-seen-cache.h: Sort headers.
6967         * filename-seen-cache.c: Sort headers.
6968         * fbsd-tdep.c: Sort headers.
6969         * fbsd-nat.h: Sort headers.
6970         * fbsd-nat.c: Sort headers.
6971         * f-valprint.c: Sort headers.
6972         * f-typeprint.c: Sort headers.
6973         * f-lang.c: Sort headers.
6974         * extension.h: Sort headers.
6975         * extension.c: Sort headers.
6976         * extension-priv.h: Sort headers.
6977         * expprint.c: Sort headers.
6978         * exec.h: Sort headers.
6979         * exec.c: Sort headers.
6980         * exceptions.c: Sort headers.
6981         * event-top.c: Sort headers.
6982         * event-loop.c: Sort headers.
6983         * eval.c: Sort headers.
6984         * elfread.c: Sort headers.
6985         * dwarf2read.h: Sort headers.
6986         * dwarf2read.c: Sort headers.
6987         * dwarf2loc.c: Sort headers.
6988         * dwarf2expr.h: Sort headers.
6989         * dwarf2expr.c: Sort headers.
6990         * dwarf2-frame.c: Sort headers.
6991         * dwarf2-frame-tailcall.c: Sort headers.
6992         * dwarf-index-write.h: Sort headers.
6993         * dwarf-index-write.c: Sort headers.
6994         * dwarf-index-common.c: Sort headers.
6995         * dwarf-index-cache.h: Sort headers.
6996         * dwarf-index-cache.c: Sort headers.
6997         * dummy-frame.c: Sort headers.
6998         * dtrace-probe.c: Sort headers.
6999         * disasm.h: Sort headers.
7000         * disasm.c: Sort headers.
7001         * disasm-selftests.c: Sort headers.
7002         * dictionary.c: Sort headers.
7003         * dicos-tdep.c: Sort headers.
7004         * demangle.c: Sort headers.
7005         * dcache.h: Sort headers.
7006         * dcache.c: Sort headers.
7007         * darwin-nat.h: Sort headers.
7008         * darwin-nat.c: Sort headers.
7009         * darwin-nat-info.c: Sort headers.
7010         * d-valprint.c: Sort headers.
7011         * d-namespace.c: Sort headers.
7012         * d-lang.c: Sort headers.
7013         * ctf.c: Sort headers.
7014         * csky-tdep.c: Sort headers.
7015         * csky-linux-tdep.c: Sort headers.
7016         * cris-tdep.c: Sort headers.
7017         * cris-linux-tdep.c: Sort headers.
7018         * cp-valprint.c: Sort headers.
7019         * cp-support.c: Sort headers.
7020         * cp-namespace.c: Sort headers.
7021         * cp-abi.c: Sort headers.
7022         * corelow.c: Sort headers.
7023         * corefile.c: Sort headers.
7024         * continuations.c: Sort headers.
7025         * completer.h: Sort headers.
7026         * completer.c: Sort headers.
7027         * complaints.c: Sort headers.
7028         * coffread.c: Sort headers.
7029         * coff-pe-read.c: Sort headers.
7030         * cli-out.h: Sort headers.
7031         * cli-out.c: Sort headers.
7032         * charset.c: Sort headers.
7033         * c-varobj.c: Sort headers.
7034         * c-valprint.c: Sort headers.
7035         * c-typeprint.c: Sort headers.
7036         * c-lang.c: Sort headers.
7037         * buildsym.c: Sort headers.
7038         * buildsym-legacy.c: Sort headers.
7039         * build-id.h: Sort headers.
7040         * build-id.c: Sort headers.
7041         * btrace.c: Sort headers.
7042         * bsd-uthread.c: Sort headers.
7043         * breakpoint.h: Sort headers.
7044         * breakpoint.c: Sort headers.
7045         * break-catch-throw.c: Sort headers.
7046         * break-catch-syscall.c: Sort headers.
7047         * break-catch-sig.c: Sort headers.
7048         * blockframe.c: Sort headers.
7049         * block.c: Sort headers.
7050         * bfin-tdep.c: Sort headers.
7051         * bfin-linux-tdep.c: Sort headers.
7052         * bfd-target.c: Sort headers.
7053         * bcache.c: Sort headers.
7054         * ax-general.c: Sort headers.
7055         * ax-gdb.h: Sort headers.
7056         * ax-gdb.c: Sort headers.
7057         * avr-tdep.c: Sort headers.
7058         * auxv.c: Sort headers.
7059         * auto-load.c: Sort headers.
7060         * arm-wince-tdep.c: Sort headers.
7061         * arm-tdep.c: Sort headers.
7062         * arm-symbian-tdep.c: Sort headers.
7063         * arm-pikeos-tdep.c: Sort headers.
7064         * arm-obsd-tdep.c: Sort headers.
7065         * arm-nbsd-tdep.c: Sort headers.
7066         * arm-nbsd-nat.c: Sort headers.
7067         * arm-linux-tdep.c: Sort headers.
7068         * arm-linux-nat.c: Sort headers.
7069         * arm-fbsd-tdep.c: Sort headers.
7070         * arm-fbsd-nat.c: Sort headers.
7071         * arm-bsd-tdep.c: Sort headers.
7072         * arch-utils.c: Sort headers.
7073         * arc-tdep.c: Sort headers.
7074         * arc-newlib-tdep.c: Sort headers.
7075         * annotate.h: Sort headers.
7076         * annotate.c: Sort headers.
7077         * amd64-windows-tdep.c: Sort headers.
7078         * amd64-windows-nat.c: Sort headers.
7079         * amd64-tdep.c: Sort headers.
7080         * amd64-sol2-tdep.c: Sort headers.
7081         * amd64-obsd-tdep.c: Sort headers.
7082         * amd64-obsd-nat.c: Sort headers.
7083         * amd64-nbsd-tdep.c: Sort headers.
7084         * amd64-nbsd-nat.c: Sort headers.
7085         * amd64-nat.c: Sort headers.
7086         * amd64-linux-tdep.c: Sort headers.
7087         * amd64-linux-nat.c: Sort headers.
7088         * amd64-fbsd-tdep.c: Sort headers.
7089         * amd64-fbsd-nat.c: Sort headers.
7090         * amd64-dicos-tdep.c: Sort headers.
7091         * amd64-darwin-tdep.c: Sort headers.
7092         * amd64-bsd-nat.c: Sort headers.
7093         * alpha-tdep.c: Sort headers.
7094         * alpha-obsd-tdep.c: Sort headers.
7095         * alpha-nbsd-tdep.c: Sort headers.
7096         * alpha-mdebug-tdep.c: Sort headers.
7097         * alpha-linux-tdep.c: Sort headers.
7098         * alpha-linux-nat.c: Sort headers.
7099         * alpha-bsd-tdep.c: Sort headers.
7100         * alpha-bsd-nat.c: Sort headers.
7101         * aix-thread.c: Sort headers.
7102         * agent.c: Sort headers.
7103         * addrmap.c: Sort headers.
7104         * ada-varobj.c: Sort headers.
7105         * ada-valprint.c: Sort headers.
7106         * ada-typeprint.c: Sort headers.
7107         * ada-tasks.c: Sort headers.
7108         * ada-lang.c: Sort headers.
7109         * aarch64-tdep.c: Sort headers.
7110         * aarch64-ravenscar-thread.c: Sort headers.
7111         * aarch64-newlib-tdep.c: Sort headers.
7112         * aarch64-linux-tdep.c: Sort headers.
7113         * aarch64-linux-nat.c: Sort headers.
7114         * aarch64-fbsd-tdep.c: Sort headers.
7115         * aarch64-fbsd-nat.c: Sort headers.
7116         * aarch32-linux-nat.c: Sort headers.
7117
7118 2019-04-04  Tom Tromey  <tom@tromey.com>
7119
7120         * varobj.c (varobj_create): Update.
7121         * rust-exp.y (struct rust_parser) <update_innermost_block,
7122         lookup_symbol>: New methods.
7123         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7124         Rename.
7125         (rust_parser::rust_lookup_type)
7126         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7127         * printcmd.c (display_command, do_one_display): Update.
7128         * parser-defs.h (struct parser_state) <parser_state>: Add
7129         "tracker" parameter.
7130         (block_tracker): New member.
7131         (class innermost_block_tracker) <innermost_block_tracker>: Add
7132         "types" parameter.
7133         <reset>: Remove method.
7134         (innermost_block): Don't declare.
7135         (null_post_parser): Update.
7136         * parse.c (innermost_block): Remove global.
7137         (write_dollar_variable): Update.
7138         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7139         Remove "tracker_types" parameter.
7140         (parse_expression): Add "tracker" parameter.
7141         (parse_expression_for_completion): Update.
7142         (null_post_parser): Add "tracker" parameter.
7143         * p-exp.y: Update rules.
7144         * m2-exp.y: Update rules.
7145         * language.h (struct language_defn) <la_post_parser>: Add
7146         "tracker" parameter.
7147         * go-exp.y: Update rules.
7148         * f-exp.y: Update rules.
7149         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7150         parameter.
7151         * d-exp.y: Update rules.
7152         * c-exp.y: Update rules.
7153         * breakpoint.c (set_breakpoint_condition): Create an
7154         innermost_block_tracker.
7155         (watch_command_1): Likewise.
7156         * ada-lang.c (resolve): Add "tracker" parameter.
7157         (resolve_subexp): Likewise.
7158         * ada-exp.y (write_var_from_sym): Update.
7159
7160 2019-04-04  Tom Tromey  <tom@tromey.com>
7161
7162         * type-stack.h: New file.
7163         * type-stack.c: New file.
7164         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7165         type-stack.h.
7166         (insert_into_type_stack, insert_type, push_type, push_type_int)
7167         (insert_type_address_space, pop_type, pop_type_int)
7168         (pop_typelist, pop_type_stack, append_type_stack)
7169         (push_type_stack, get_type_stack, push_typelist)
7170         (follow_type_instance_flags, follow_types): Don't declare.
7171         * parse.c (type_stack): Remove global.
7172         (parse_exp_in_context): Update.
7173         (insert_into_type_stack, insert_type, push_type, push_type_int)
7174         (insert_type_address_space, pop_type, pop_type_int)
7175         (pop_typelist, pop_type_stack, append_type_stack)
7176         (push_type_stack, get_type_stack, push_typelist)
7177         (follow_type_instance_flags, follow_types): Remove (moved to
7178         type-stack.c).
7179         * f-exp.y (type_stack): New global.
7180         Update rules.
7181         (push_kind_type, f_parse): Update.
7182         * d-exp.y (type_stack): New global.
7183         Update rules.
7184         (d_parse): Update.
7185         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7186         Update rules.
7187         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7188         (HFILES_NO_SRCDIR): Add type-stack.h.
7189
7190 2019-04-04  Tom Tromey  <tom@tromey.com>
7191
7192         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7193         (rust_parser::convert_ast_to_expression, rust_parse)
7194         (rust_lex_test_completion, rust_lex_tests): Update.
7195         * parser-defs.h (struct expr_completion_state): New.
7196         (struct parser_state) <parser_state>: Add completion parameter.
7197         <mark_struct_expression, mark_completion_tag>: New methods.
7198         <parse_completion, m_completion_state>: New members.
7199         (prefixify_expression, null_post_parser): Update.
7200         (mark_struct_expression, mark_completion_tag): Don't declare.
7201         * parse.c (parse_completion, expout_last_struct)
7202         (expout_tag_completion_type, expout_completion_name): Remove
7203         globals.
7204         (parser_state::mark_struct_expression)
7205         (parser_state::mark_completion_tag): Now methods.
7206         (prefixify_expression): Add last_struct parameter.
7207         (prefixify_subexp): Likewise.
7208         (parse_exp_1): Update.
7209         (parse_exp_in_context): Add cstate parameter.  Update.
7210         (parse_expression_for_completion): Create an
7211         expr_completion_state.
7212         (null_post_parser): Add "completion" parameter.
7213         * p-exp.y: Update rules.
7214         (yylex): Update.
7215         * language.h (struct language_defn) <la_post_parser>: Add
7216         "completing" parameter.
7217         * go-exp.y: Update rules.
7218         (lex_one_token): Update.
7219         * expression.h (parse_completion): Don't declare.
7220         * d-exp.y: Update rules.
7221         (lex_one_token): Update rules.
7222         * c-exp.y: Update rules.
7223         (lex_one_token): Update.
7224         * ada-lang.c (resolve): Add "parse_completion" parameter.
7225         (resolve_subexp): Likewise.
7226         (ada_resolve_function): Likewise.
7227
7228 2019-04-04  Tom Tromey  <tom@tromey.com>
7229
7230         * parser-defs.h (struct parser_state) <start_arglist,
7231         end_arglist>: New methods.
7232         <arglist_len, m_funcall_chain>: New members.
7233         (arglist_len, start_arglist, end_arglist): Don't declare.
7234         * parse.c (arglist_len, funcall_chain): Remove global.
7235         (start_arglist, end_arglist): Remove functions.
7236         (parse_exp_in_context): Update.
7237         * p-exp.y: Update rules.
7238         * m2-exp.y: Update rules.
7239         * go-exp.y: Update rules.
7240         * f-exp.y: Update rules.
7241         * d-exp.y: Update rules.
7242         * c-exp.y: Update rules.
7243
7244 2019-04-04  Tom Tromey  <tom@tromey.com>
7245
7246         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7247         lex_operator, push_back>: New methods.
7248         Update all rules.
7249         (rust_parser::lex_hex, lex_escape): Rename and update.
7250         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7251         (rust_parser::lex_operator): Rename and update.
7252         (rust_parser::lex_number, rustyylex, rustyyerror)
7253         (rust_lex_test_init, rust_lex_test_sequence)
7254         (rust_lex_test_push_back, rust_lex_tests): Update.
7255         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7256         parameter.
7257         <lexptr, prev_lexptr>: New members.
7258         (lexptr, prev_lexptr): Don't declare.
7259         * parse.c (lexptr, prev_lexptr): Remove globals.
7260         (parse_exp_in_context): Update.
7261         * p-exp.y (yylex, yyerror): Update.
7262         * m2-exp.y (parse_number, yylex, yyerror): Update.
7263         * go-exp.y (lex_one_token, yyerror): Update.
7264         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7265         * d-exp.y (lex_one_token, yyerror): Update.
7266         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7267         (lex_one_token, yyerror): Update.
7268         * ada-lex.l (YY_INPUT): Update.
7269         (rewind_to_char): Update.
7270         * ada-exp.y (yyerror): Update.
7271
7272 2019-04-04  Tom Tromey  <tom@tromey.com>
7273
7274         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7275         * parser-defs.h (struct parser_state) <parser_state>: Add new
7276         parameter.
7277         <comma_terminates>: New member.
7278         (comma_terminates): Don't declare global.
7279         * parse.c (comma_terminates): Remove global.
7280         (parse_exp_in_context): Update.
7281         * p-exp.y (yylex): Update.
7282         * m2-exp.y (yylex): Update.
7283         * go-exp.y (lex_one_token): Update.
7284         * f-exp.y (yylex): Update.
7285         * d-exp.y (lex_one_token): Update.
7286         * c-exp.y (lex_one_token): Update.
7287         * ada-lex.l: Update.
7288
7289 2019-04-04  Tom Tromey  <tom@tromey.com>
7290
7291         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7292         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7293         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7294         * parser-defs.h (paren_depth): Don't declare.
7295         * parse.c (paren_depth): Remove global.
7296         (parse_exp_in_context): Update.
7297         * p-exp.y (paren_depth): New global.
7298         (pascal_parse): Initialize it.
7299         * m2-exp.y (paren_depth): New global.
7300         (m2_parse): Initialize it.
7301         * go-exp.y (paren_depth): New global.
7302         (go_parse): Initialize it.
7303         * f-exp.y (paren_depth): New global.
7304         (f_parse): Initialize it.
7305         * d-exp.y (paren_depth): New global.
7306         (d_parse): Initialize it.
7307         * c-exp.y (paren_depth): New global.
7308         (c_parse): Initialize it.
7309         * ada-lex.l (paren_depth): New global.
7310         (lexer_init): Initialize it.
7311
7312 2019-04-04  Tom Tromey  <tom@tromey.com>
7313
7314         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7315         (rust_parser::convert_ast_to_type)
7316         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7317         * parser-defs.h (struct parser_state) <parser_state>: Add
7318         parameters.  Initialize new members.
7319         <expression_context_block, expression_context_pc>: New members.
7320         * parse.c (expression_context_block, expression_context_pc):
7321         Remove globals.
7322         (parse_exp_in_context): Update.
7323         * p-exp.y: Update all rules.
7324         (yylex): Update.
7325         * m2-exp.y: Update all rules.
7326         (yylex): Update.
7327         * go-exp.y (yylex): Update.
7328         * f-exp.y (yylex): Update.
7329         * d-exp.y: Update all rules.
7330         (yylex): Update.
7331         * c-exp.y: Update all rules.
7332         (lex_one_token, classify_name, yylex, c_parse): Update.
7333         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7334
7335 2019-04-04  Tom Tromey  <tom@tromey.com>
7336
7337         * gdbarch.h, gdbarch.c: Rebuild.
7338         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7339         * stap-probe.h:
7340         (struct stap_parse_info): Replace "parser_state" with
7341         "expr_builder".
7342         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7343         (parser_state): New class.
7344         * parse.c (expr_builder): Rename.
7345         (expr_builder::release): Rename.
7346         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7347         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7348         (write_exp_elt_longcst, write_exp_elt_floatcst)
7349         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7350         (write_exp_string_vector, write_exp_bitstring)
7351         (write_exp_msymbol, mark_struct_expression)
7352         (write_dollar_variable)
7353         (insert_type_address_space, increase_expout_size): Replace
7354         "parser_state" with "expr_builder".
7355         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7356         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7357         "parser_state" with "expr_builder".
7358
7359 2019-04-04  Tom Tromey  <tom@tromey.com>
7360
7361         * rust-exp.y: Replace "parse_language" with method call.
7362         * p-exp.y:
7363         (yylex): Replace "parse_language" with method call.
7364         * m2-exp.y:
7365         (yylex): Replace "parse_language" with method call.
7366         * go-exp.y (classify_name): Replace "parse_language" with method
7367         call.
7368         * f-exp.y (yylex): Replace "parse_language" with method call.
7369         * d-exp.y (lex_one_token): Replace "parse_language" with method
7370         call.
7371         * c-exp.y:
7372         (lex_one_token, classify_name, yylex): Replace "parse_language"
7373         with method call.
7374         * ada-exp.y (find_primitive_type, type_char)
7375         (type_system_address): Replace "parse_language" with method call.
7376
7377 2019-04-04  Tom Tromey  <tom@tromey.com>
7378
7379         * rust-exp.y: Replace "parse_gdbarch" with method call.
7380         * parse.c (write_dollar_variable, insert_type_address_space):
7381         Replace "parse_gdbarch" with method call.
7382         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7383         call.
7384         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7385         call.
7386         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7387         "parse_gdbarch" with method call.
7388         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7389         with method call.
7390         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7391         "parse_gdbarch" with method call.
7392         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7393         "parse_gdbarch" with method call.
7394         * c-exp.y (parse_type, parse_number, classify_name): Replace
7395         "parse_gdbarch" with method call.
7396         * ada-lex.l: Replace "parse_gdbarch" with method call.
7397         * ada-exp.y (parse_type, find_primitive_type, type_char)
7398         (type_system_address): Replace "parse_gdbarch" with method call.
7399
7400 2019-04-04  Tom Tromey  <tom@tromey.com>
7401
7402         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7403         * stap-probe.c (stap_parse_argument): Update.
7404         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7405         initial_size parameter.
7406         * rust-exp.y (rust_lex_tests): Update.
7407         * parse.c (parser_state): Update.
7408         (parse_exp_in_context): Update.
7409         * parser-defs.h (struct parser_state) <parser_state>: Remove
7410         "initial_size" parameter.
7411
7412 2019-04-04  Tom Tromey  <tom@tromey.com>
7413
7414         * parser-defs.h (increase_expout_size): Don't declare.
7415         * parse.c (increase_expout_size): Now static.
7416
7417 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7418
7419         * gnu-nat.c (gnu_nat_target::wait): Fix
7420         target_waitstatus_to_string call.
7421
7422 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7423
7424         * eval.c (evaluate_subexp_standard): Handle internal functions
7425         during Fortran function call handling.
7426
7427 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7428
7429         * NEWS: Mention new internal functions.
7430         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7431         (read_base_type): Use dwarf2_init_complex_target_type.
7432         * value.c (creal_internal_fn): New function.
7433         (cimag_internal_fn): New function.
7434         (_initialize_values): Register new internal functions.
7435
7436 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7437
7438         * infrun.c (stop_all_threads): If debug_infrun, always
7439         trace the wait status after wait_one, using
7440         target_waitstatus_to_string and target_pid_to_str.
7441         (handle_inferior_event): Replace various trace of
7442         wait status kind by a single trace.
7443         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7444         wait status kind image by target_waitstatus_to_string.
7445         * target/waitstatus.c (target_waitstatus_to_string): Fix
7446         obsolete comment.
7447
7448 2019-04-01  Tom Tromey  <tromey@adacore.com>
7449
7450         PR symtab/23331:
7451         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7452
7453 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7454             Pedro Alves  <palves@redhat.com>
7455
7456         * top.c (quit_force): Call 'finalize_values'.
7457         * value.c (finalize_values): New function.
7458         * value.h (finalize_values): Declare.
7459
7460 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7461
7462         * NEWS: Announce $_gdb_major and $_gdb_minor.
7463
7464         * top.c (init_gdb_version_vars): New function.
7465         (gdb_init): Call init_gdb_version_vars.
7466
7467 2019-03-29  Tom Tromey  <tromey@adacore.com>
7468
7469         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7470         help text.  Remove dead code.
7471
7472 2019-03-29  Keith Seitz  <keiths@redhat.com>
7473
7474         From Siddhesh Poyarekar:
7475         * f-lang.h (f77_get_upperbound): Return LONGEST.
7476         (f77_get_lowerbound): Likewise.
7477         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7478         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7479         print them.
7480         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7481         plongest to format print it.
7482         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7483         (f77_get_upperbound): Likewise.
7484         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7485         LOWER_BOUND to LONGEST.
7486         (f77_create_arrayprint_offset_tbl): Likewise.
7487
7488 2019-03-29  Keith Seitz  <keiths@redhat.com>
7489
7490         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7491         %s/pulongest for TYPE_LENGTH instead of %d in format
7492         strings.
7493         * ada-typerint.c (ada_print_type): Likewise.
7494         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7495         * compile/compile-c-support.c (generate_register_struct): Likewise.
7496         * gdbtypes.c (recursive_dump_type): Likewise.
7497         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7498         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7499         instead of %d in format strings.
7500         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7501         to std::min to ULONGEST.
7502         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7503         instead of %d in format strings.
7504         * tracepoint.c (info_scope_command): Likewise.
7505         * typeprint.c (print_offset_data::update)
7506         (print_offset_data::finish): Likewise.
7507         * xtensa-tdep.c (xtensa_store_return_value)
7508         (xtensa_push_dummy_call): Likewise.
7509
7510 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7511
7512         * windows-nat.c (display_selector): Fixed format specifications
7513         for 64-bit Cygwin.
7514
7515 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7516
7517         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7518
7519 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7520
7521         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7522         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7523         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7524         (nios2_linux_init_abi): Install it.
7525
7526 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7527
7528         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7529
7530 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7531
7532         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7533
7534 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7535             Tom Tromey  <tromey@adacore.com>
7536
7537         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7538
7539 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7540
7541         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7542         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7543         method to compute the bounds of range types. Also print "[evaluated]"
7544         if the bounds' values come from a dynamic evaluation.
7545
7546 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7547
7548         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7549         whitespace when pretty printing is on.
7550
7551 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7552
7553         * ppc-linux-nat.c: Add include.
7554
7555 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7556
7557         * NEWS: Mention AArch64 Pointer Authentication.
7558
7559 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7560
7561         * arm-linux-nat.c: Add include.
7562
7563 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7564
7565         * source-cache.c (source_cache::get_source_lines): Re-read
7566         fullname after calling open_source_file.
7567
7568 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7569
7570         * NEWS: Mention TLS support for FreeBSD.
7571
7572 2019-03-25  Tom Tromey  <tromey@adacore.com>
7573
7574         * minsyms.c (BUNCH_SIZE): Update comment.
7575         (~minimal_symbol_reader): Remove old comment.
7576         (compact_minimal_symbols): Update comment.
7577         (minimal_symbol_reader::install): Remove old comment.  Update
7578         other comments.
7579
7580 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7581
7582         * s390-linux-nat.c: Add include.
7583
7584 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7585
7586         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7587         Call linux_get_hwcap.
7588         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7589         Likewise.
7590         (aarch64_linux_get_hwcap): Remove function.
7591         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7592         declaration.
7593         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7594         linux_get_hwcap.
7595         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7596         * linux-tdep.c (linux_get_hwcap): Add function.
7597         (linux_get_hwcap2): Likewise.
7598         * linux-tdep.h (linux_get_hwcap): Add declaration.
7599         (linux_get_hwcap2): Likewise.
7600         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7601         (ppc_linux_get_hwcap2): Likewise.
7602         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7603         linux_get_hwcap.
7604         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7605         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7606         (ppc_linux_nat_target::read_description): Likewise.
7607         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7608         * s390-linux-nat.c: Likewise.
7609         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7610
7611 2019-03-24  Tom Tromey  <tom@tromey.com>
7612
7613         * ada-lang.c (standard_lookup): Simplify initialization.
7614         (ada_lookup_symbol_nonlocal): Simplify return.
7615         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7616         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7617         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7618         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7619         initialization.
7620         * solib.c (solib_global_lookup): Simplify.
7621         * symtab.c (null_block_symbol): Remove.
7622         (symbol_cache_lookup): Simplify returns.
7623         (lookup_language_this): Simplify returns.
7624         (lookup_symbol_aux): Simplify return.
7625         (lookup_local_symbol): Simplify returns.
7626         (lookup_global_symbol_from_objfile): Simplify return.
7627         (lookup_symbol_in_objfile_symtabs)
7628         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7629         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7630         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7631         * cp-namespace.c (cp_lookup_bare_symbol)
7632         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7633         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7634         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7635         (cp_lookup_symbol_via_imports): Simplify initialization.
7636         (find_symbol_in_baseclass): Likewise.
7637         * symtab.h (null_block_symbol): Remove.
7638         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7639         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7640         (d_lookup_symbol_module): Likewise.
7641         (find_symbol_in_baseclass): Simplify initialization.
7642
7643 2019-03-24  Tom Tromey  <tom@tromey.com>
7644
7645         * expression.h: Don't include symtab.h.
7646         (struct block): Forward declare.
7647
7648 2019-03-24  Tom Tromey  <tom@tromey.com>
7649
7650         * c-exp.y (typebase): Remove casts.
7651         * gdbtypes.c (lookup_unsigned_typename, )
7652         (lookup_signed_typename): Remove cast.
7653         * eval.c (parse_to_comma_and_eval): Remove cast.
7654         * parse.c (write_dollar_variable): Remove cast.
7655         * block.h (struct block) <superblock>: Now const.
7656         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7657         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7658         (map_block): Make "block" const.
7659         * symfile.h (struct quick_symbol_functions)
7660         <map_matching_symbols>: Constify block argument to "callback".
7661         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7662         const.
7663         (find_pc_sect_compunit_symtab): Make "b" const.
7664         (find_symbol_at_address): Likewise.
7665         (search_symbols): Likewise.
7666         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7667         (dw2_debug_names_lookup_symbol): Likewise.
7668         (dw2_map_matching_symbols): Update.
7669         * p-valprint.c (pascal_val_print): Remove "block".
7670         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7671         (aux_add_nonlocal_symbols): Make "block" const.
7672         (resolve_subexp): Remove cast.
7673         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7674         const.
7675         (iterate_over_file_blocks): Likewise.
7676         * f-exp.y (%union) <bval>: Remove.
7677         * coffread.c (patch_opaque_types): Make "b" const.
7678         * spu-tdep.c (spu_catch_start): Make "block" const.
7679         * c-valprint.c (print_unpacked_pointer): Remove "block".
7680         * symmisc.c (dump_symtab_1): Make "b" const.
7681         (block_depth): Make "block" const.
7682         * d-exp.y (%union) <bval>: Remove.
7683         * cp-support.h (cp_lookup_rtti_type): Update.
7684         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7685         * psymtab.c (psym_lookup_symbol): Make "block" const.
7686         (maintenance_check_psymtabs): Make "b" const.
7687         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7688         (enumerate_locals, enumerate_args): Update.
7689         * python/py-symtab.c (stpy_global_block): Make "block" const.
7690         (stpy_static_block): Likewise.
7691         * inline-frame.c (block_starting_point_at): Make "new_block"
7692         const.
7693         * block.c (find_block_in_blockvector): Make return type const.
7694         (blockvector_for_pc_sect): Make "b" const.
7695         (find_block_in_blockvector): Make "b" const.
7696
7697 2019-03-23  Tom Tromey  <tom@tromey.com>
7698
7699         * varobj.c (varobj_create): Update.
7700         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7701         * printcmd.c (display_command, do_one_display): Don't reset
7702         innermost_block.
7703         * parser-defs.h (enum innermost_block_tracker_type): Move to
7704         expression.h.
7705         (innermost_block): Update comment.
7706         * parse.c (parse_exp_1): Add tracker_types parameter.
7707         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7708         tracker_types parameter.  Reset innermost_block.
7709         (parse_exp_in_context): Remove.
7710         (parse_expression_for_completion): Update.
7711         * objfiles.c (~objfile): Don't reset expression_context_block or
7712         innermost_block.
7713         * expression.h (enum innermost_block_tracker_type): Move from
7714         parser-defs.h.
7715         (parse_exp_1): Add tracker_types parameter.
7716         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7717         reset innermost_block.
7718
7719 2019-03-23  Tom Tromey  <tom@tromey.com>
7720
7721         * objfiles.h: Include bcache.h.
7722
7723 2019-03-23  Tom Tromey  <tom@tromey.com>
7724
7725         * linespec.c (get_current_search_block): Use
7726         scoped_restore_current_language.
7727         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7728
7729 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7730             Jiong Wang  <jiong.wang@arm.com>
7731
7732         * aarch64-linux-tdep.c
7733         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7734         section.
7735         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7736
7737 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7738             Jiong Wang  <jiong.wang@arm.com>
7739
7740         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7741         instructions.
7742         (aarch64_analyze_prologue_test): Add PACIASP test.
7743         (aarch64_prologue_prev_register): Unmask PC value.
7744
7745 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7746             Jiong Wang  <jiong.wang@arm.com>
7747
7748         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7749         (aarch64_dwarf2_prev_register): Unmask PC value.
7750         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7751         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7752         DW_CFA_AARCH64_negate_ra_state.
7753         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7754
7755 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7756             Jiong Wang  <jiong.wang@arm.com>
7757
7758         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7759         registers.
7760         (aarch64_pseudo_register_name): Likewise.
7761         (aarch64_pseudo_register_type): Likewise.
7762         (aarch64_pseudo_register_reggroup_p): Likewise.
7763         (aarch64_gdbarch_init): Add pauth registers.
7764         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7765         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7766         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7767         (struct gdbarch_tdep): Add regnum for ra_state.
7768
7769 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7770             Jiong Wang  <jiong.wang@arm.com>
7771
7772         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7773
7774 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7775             Jiong Wang  <jiong.wang@arm.com>
7776
7777         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7778         function.
7779         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7780         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7781         (aarch64_gdbarch_init): Add puth registers.
7782         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7783         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7784         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7785
7786 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7787             Jiong Wang  <jiong.wang@arm.com>
7788
7789         * aarch64-linux-nat.c
7790         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7791         * aarch64-linux-tdep.c
7792         (aarch64_linux_core_read_description): Likewise.
7793         (aarch64_linux_get_hwcap): New function.
7794         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7795         (aarch64_linux_get_hwcap): New declaration.
7796
7797 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7798             Jiong Wang  <jiong.wang@arm.com>
7799
7800         * aarch64-linux-nat.c
7801         (aarch64_linux_nat_target::read_description): Add pauth param.
7802         * aarch64-linux-tdep.c
7803         (aarch64_linux_core_read_description): Likewise.
7804         * aarch64-tdep.c (struct target_desc): Add in pauth.
7805         (aarch64_read_description): Add pauth param.
7806         (aarch64_gdbarch_init): Likewise.
7807         * aarch64-tdep.h (aarch64_read_description): Likewise.
7808         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7809         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7810         * features/Makefile: Add new files.
7811         * features/aarch64-pauth.c: New file.
7812         * features/aarch64-pauth.xml: New file.
7813
7814 2019-03-20  Tom Tromey  <tromey@adacore.com>
7815
7816         * infrun.c (handle_inferior_event): Rename from
7817         handle_inferior_event_1.  Create a scoped_value_mark.
7818         (handle_inferior_event): Remove.
7819
7820 2019-03-19  Tom Tromey  <tromey@adacore.com>
7821
7822         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7823         * infrun.h (print_stop_event): Add "displays" parameter.
7824         * infrun.c (print_stop_event): Add "displays" parameter.
7825
7826 2019-03-19  Pedro Alves  <palves@redhat.com>
7827
7828         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7829         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7830         to -1.  Fix TABs vs spaces.
7831         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7832         * tui/tui-out.h (tui_ui_out) Add intro comments.
7833         <m_line, m_start_of_line>: In-class initialize, and add describing
7834         comment.
7835
7836 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7837
7838         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7839         variable names.
7840         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7841
7842 2019-03-18  Pedro Alves  <palves@redhat.com>
7843             Eli Zaretskii <eliz@gnu.org>
7844
7845         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7846         m_line and m_start_of_line.
7847
7848 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7849
7850         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7851         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7852         it returns a newline.  This fixes a regression in TU mode, whereby
7853         the next line is output on the same screen line as the user input.
7854
7855 2019-03-18  Tom Tromey  <tromey@adacore.com>
7856
7857         * minsyms.c (minimal_symbol_reader::install): Remove call to
7858         obstack_blank.
7859
7860 2019-03-18  Pedro Alves  <palves@redhat.com>
7861
7862         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7863         New globals.
7864         (apply_style): New, factored out from ...
7865         (apply_ansi_escape): ... this.  Handle reverse video mode.
7866         (tui_set_reverse_mode): New function.
7867         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7868         * tui/tui-winsource.c (tui_show_source_line): Use
7869         tui_set_reverse_mode instead of setting A_STANDOUT.
7870         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7871         New setter methods.
7872
7873 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7874
7875         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7876         Handle tabs.
7877
7878 2019-03-18  Tom Tromey  <tromey@adacore.com>
7879
7880         * ada-lang.c (empty_array): Add "high" parameter.
7881         (ada_evaluate_subexp): Update.
7882
7883 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7884
7885         * unittests/string_view-selftests.c: Define
7886         _initialize_string_view_selftests unconditionally.
7887
7888 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7889
7890         PR gdb/24350
7891         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7892
7893 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7894
7895         PR gdb/24351
7896         * windows-nat.c (display_selector): Fix format specifiers.
7897
7898 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7899
7900         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7901         tui_refill_source_window instead of tui_refresh_win, to update the
7902         current execution line.  This fixes redisplay of the current line
7903         when stepping through the code with "next" or "step".
7904
7905 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7906
7907         * source-cache.c (source_cache::get_source_lines): Call
7908         find_source_lines to initialize s->nlines.  This fixes vertical
7909         scrolling of TUI source window when the DOWN arrow is pressed.
7910
7911 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7912
7913         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7914         linux-thread-db.c (_initialize_thread_db): Likewise.
7915
7916 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7917
7918         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7919         wclrtoeol in tui_show_source_line".  This reverts changes made in
7920         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7921
7922 2019-03-15  Tom Tromey  <tom@tromey.com>
7923
7924         * symtab.h (struct minimal_symbol): Derive from
7925         general_symbol_info.
7926         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7927         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7928         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7929         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7930         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7931         (MSYMBOL_SEARCH_NAME): Update.
7932         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7933         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7934         * minsyms.c (minimal_symbol_reader::record_full): Update.
7935
7936 2019-03-15  Tom Tromey  <tom@tromey.com>
7937
7938         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7939
7940 2019-03-15  Tom Tromey  <tom@tromey.com>
7941
7942         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7943         unique_xmalloc_ptr.
7944         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7945         Update.
7946         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7947         (build_minimal_symbol_hash_tables)
7948         (minimal_symbol_reader::install): Update.
7949
7950 2019-03-15  Tom Tromey  <tom@tromey.com>
7951
7952         * symtab.c (create_demangled_names_hash): Update.
7953         (symbol_set_names): Update.
7954         * objfiles.h (struct objfile_per_bfd_storage)
7955         <demangled_names_hash>: Now an htab_up.
7956         * objfiles.c (objfile_per_bfd_storage): Simplify.
7957
7958 2019-03-15  Tom Tromey  <tom@tromey.com>
7959
7960         * objfiles.h (struct objfile_per_bfd_storage): Declare
7961         destructor.
7962         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7963         New.
7964         (get_objfile_bfd_data): Use new.  Don't initialize
7965         language_of_main.
7966         (free_objfile_per_bfd_storage): Remove.
7967         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7968
7969 2019-03-15  Tom Tromey  <tom@tromey.com>
7970
7971         * symfile.c (reread_symbols): Update.
7972         * objfiles.c (objfile::objfile): Update.
7973         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7974         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7975         comment.
7976         (minimal_symbol_reader::install): Update.
7977         (terminate_minimal_symbol_table): Remove.
7978         * jit.c (jit_object_close_impl): Update.
7979
7980 2019-03-15  Tom Tromey  <tom@tromey.com>
7981
7982         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7983         initializations.
7984
7985 2019-03-15  Tom Tromey  <tom@tromey.com>
7986
7987         * objfiles.h (struct objfile_per_bfd_storage)
7988         <demangled_hash_languages>: Now a bitset.
7989         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7990         (lookup_minimal_symbol): Update.
7991
7992 2019-03-15  Tom Tromey  <tom@tromey.com>
7993
7994         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7995         Don't return the symbol.
7996         * coffread.c (record_minimal_symbol): Use record_full.
7997
7998 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7999
8000         The MS-Windows port of ncurses fails to switch to a color pair if
8001         one or both of the colors are the implicit default colors.  This
8002         change records the default colors when TUI is initialized, and
8003         then specifies them explicitly when a color pair uses the default
8004         colors.  This allows color styling in TUI mode on MS-Windows.
8005
8006         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8007         ncurses_norm_attr.
8008         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8009         colors in ncurses_norm_attr.
8010         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8011         "none", replace it with the default color recorded in
8012         ncurses_norm_attr.
8013
8014 2019-03-14  Tom Tromey  <tromey@adacore.com>
8015
8016         * source-cache.h (class source_cache) <get_source_lines>: Return
8017         std::string.
8018         * source-cache.c (source_cache::extract_lines): Handle case where
8019         first_pos==npos.  Return std::string.
8020         (source_cache::get_source_lines): Update.
8021
8022 2019-03-14  Tom Tromey  <tromey@adacore.com>
8023
8024         * NEWS: Add item for "style sources" commands.
8025         * source-cache.c (source_cache::get_source_lines): Check
8026         source_styling.
8027         * cli/cli-style.c (source_styling): New global.
8028         (_initialize_cli_style): Add "style sources" commands.
8029         (show_style_sources): New function.
8030         * cli/cli-style.h (source_styling): Declare.
8031
8032 2019-03-14  Pedro Alves  <palves@redhat.com>
8033             Tom Tromey  <tromey@adacore.com>
8034
8035         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8036         * tui/tui-winsource.c (tui_refill_source_window): New function,
8037         from...
8038         (tui_horizontal_source_scroll): ... here.  Move some logic.
8039         * cli/cli-style.c (set_style_enabled): Notify new observable.
8040         * tui/tui-hooks.c (tui_redisplay_source): New function.
8041         (tui_attach_detach_observers): Attach or detach
8042         tui_redisplay_source.
8043         * observable.h (source_styling_changed): New observable.
8044         * observable.c: Define source_styling_changed observable.
8045
8046 2019-03-13  Tom Tromey  <tromey@adacore.com>
8047
8048         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8049         (i386_gnu_nat_target::store_registers): Update.
8050         * target-debug.h (target_debug_print_std_string): New macro.
8051         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8052         * windows-tdep.c (display_one_tib): Update.
8053         * tui/tui-stack.c (tui_make_status_line): Update.
8054         * top.c (print_inferior_quit_action): Update.
8055         * thread.c (thr_try_catch_cmd): Update.
8056         (add_thread_with_info): Update.
8057         (thread_target_id_str): Update.
8058         (thr_try_catch_cmd): Update.
8059         (thread_command): Update.
8060         (thread_find_command): Update.
8061         * record-btrace.c (record_btrace_target::info_record)
8062         (record_btrace_resume_thread, record_btrace_target::resume)
8063         (record_btrace_cancel_resume, record_btrace_step_thread)
8064         (record_btrace_target::wait, record_btrace_target::wait)
8065         (record_btrace_target::wait, record_btrace_target::stop): Update.
8066         * progspace.c (print_program_space): Update.
8067         * process-stratum-target.c
8068         (process_stratum_target::thread_address_space): Update.
8069         * linux-fork.c (linux_fork_mourn_inferior)
8070         (detach_checkpoint_command, info_checkpoints_command)
8071         (linux_fork_context): Update.
8072         (linux_fork_detach): Update.
8073         (class scoped_switch_fork_info): Update.
8074         (delete_checkpoint_command): Update.
8075         * infrun.c (follow_fork_inferior): Update.
8076         (follow_fork_inferior): Update.
8077         (proceed_after_vfork_done): Update.
8078         (handle_vfork_child_exec_or_exit): Update.
8079         (follow_exec): Update.
8080         (displaced_step_prepare_throw): Update.
8081         (displaced_step_restore): Update.
8082         (start_step_over): Update.
8083         (resume_1): Update.
8084         (clear_proceed_status_thread): Update.
8085         (proceed): Update.
8086         (print_target_wait_results): Update.
8087         (do_target_wait): Update.
8088         (context_switch): Update.
8089         (stop_all_threads): Update.
8090         (restart_threads): Update.
8091         (finish_step_over): Update.
8092         (handle_signal_stop): Update.
8093         (switch_back_to_stepped_thread): Update.
8094         (keep_going_pass_signal): Update.
8095         (print_exited_reason): Update.
8096         (normal_stop): Update.
8097         * inferior.c (inferior_pid_to_str): Change return type.
8098         (print_selected_inferior): Update.
8099         (add_inferior): Update.
8100         (detach_inferior): Update.
8101         * dummy-frame.c (fprint_dummy_frames): Update.
8102         * dcache.c (dcache_info_1): Update.
8103         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8104         (btrace_fetch, btrace_clear): Update.
8105         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8106         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8107         type.
8108         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8109         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8110         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8111         * gdbarch.c, gdbarch.h: Rebuild.
8112         * gdbarch.sh (core_pid_to_str): Change return type.
8113         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8114         return type.
8115         (windows_nat_target::pid_to_str): Change return type.
8116         (windows_delete_thread): Update.
8117         (windows_nat_target::attach): Update.
8118         (windows_nat_target::files_info): Update.
8119         * target-delegates.c: Rebuild.
8120         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8121         return type.
8122         (sol_thread_target::pid_to_str): Change return type.
8123         * remote.c (class remote_target) <pid_to_str>: Change return
8124         type.
8125         (remote_target::pid_to_str): Change return type.
8126         (extended_remote_target::attach, remote_target::remote_stop_ns)
8127         (remote_target::remote_notif_remove_queued_reply)
8128         (remote_target::push_stop_reply, remote_target::disable_btrace):
8129         Update.
8130         (extended_remote_target::attach): Update.
8131         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8132         type.
8133         (gdbsim_target::pid_to_str): Change return type.
8134         * ravenscar-thread.c (struct ravenscar_thread_target)
8135         <pid_to_str>: Change return type.
8136         (ravenscar_thread_target::pid_to_str): Change return type.
8137         * procfs.c (class procfs_target) <pid_to_str>: Change return
8138         type.
8139         (procfs_target::pid_to_str): Change return type.
8140         (procfs_target::attach): Update.
8141         (procfs_target::detach): Update.
8142         (procfs_target::fetch_registers): Update.
8143         (procfs_target::store_registers): Update.
8144         (procfs_target::wait): Update.
8145         (procfs_target::files_info): Update.
8146         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8147         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8148         return type.
8149         (nto_procfs_target::pid_to_str): Change return type.
8150         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8151         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8152         return type.
8153         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8154         (exit_lwp): Update.
8155         (attach_proc_task_lwp_callback, get_detach_signal)
8156         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8157         (linux_nat_target::resume, wait_lwp, stop_callback)
8158         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8159         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8160         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8161         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8162         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8163         type.
8164         (inf_ptrace_target::attach): Update.
8165         (inf_ptrace_target::files_info): Update.
8166         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8167         type.
8168         (go32_nat_target::pid_to_str): Change return type.
8169         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8170         (gnu_nat_target::wait): Update.
8171         (gnu_nat_target::wait): Update.
8172         (gnu_nat_target::resume): Update.
8173         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8174         (fbsd_nat_target::wait): Update.
8175         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8176         type.
8177         (darwin_nat_target::attach): Update.
8178         * corelow.c (class core_target) <pid_to_str>: Change return type.
8179         (core_target::pid_to_str): Change return type.
8180         * target.c (normal_pid_to_str): Change return type.
8181         (default_pid_to_str): Likewise.
8182         (target_pid_to_str): Change return type.
8183         (target_translate_tls_address): Update.
8184         (target_announce_detach): Update.
8185         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8186         return type.
8187         (bsd_uthread_target::pid_to_str): Change return type.
8188         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8189         type.
8190         (bsd_kvm_target::pid_to_str): Change return type.
8191         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8192         return type.
8193         (aix_thread_target::pid_to_str): Change return type.
8194         * target.h (struct target_ops) <pid_to_str>: Change return type.
8195         (target_pid_to_str, normal_pid_to_str): Likewise.
8196         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8197         type.
8198         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8199         type.
8200         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8201         return type.
8202         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8203         type.
8204         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8205         type.
8206         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8207         return type.
8208
8209 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8210
8211         * NEWS: Mention that the new default MI version is 3.  Mention
8212         changes to the output of commands and events that deal with
8213         multi-location breakpoints.
8214         * breakpoint.c: Include "mi/mi-out.h".
8215         (print_one_breakpoint): Change output syntax if using MI version
8216         >= 3.
8217         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8218         New.
8219         (mi_multi_location_breakpoint_output_fixed): New.
8220         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8221         (mi_cmd_fix_multi_location_breakpoint_output): New.
8222         (mi_multi_location_breakpoint_output_fixed): New.
8223         * mi/mi-cmds.c (mi_cmds): Register command
8224         -fix-multi-location-breakpoint-output.
8225         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8226         interpreter "mi".
8227
8228 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8229
8230         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8231         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8232         instantiate mi_ui_out based on interpreter name.
8233         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8234         * mi/mi-main.c (mi_load_progress): Likewise.
8235
8236 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8237
8238         * NEWS: Combine separate "New targets" sections for 8.3.
8239
8240 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8241
8242         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8243         (ppcfbsd_init_abi): Install gdbarch
8244         "fetch_tls_load_module_address" and "get_thread_local_address"
8245         methods.
8246
8247 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8248
8249         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8250         (riscv_fbsd_init_abi): Install gdbarch
8251         "fetch_tls_load_module_address" and "get_thread_local_address"
8252         methods.
8253
8254 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8255
8256         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8257         (i386fbsd_init_abi): Install gdbarch
8258         "fetch_tls_load_module_address" and "get_thread_local_address"
8259         methods.
8260
8261 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8262
8263         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8264         (amd64fbsd_init_abi): Install gdbarch
8265         "fetch_tls_load_module_address" and "get_thread_local_address"
8266         methods.
8267
8268 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8269
8270         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8271         (struct fbsd_pspace_data): New type.
8272         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8273         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8274         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8275         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8276         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8277
8278 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8279
8280         * gdbtypes.c (lookup_struct_elt): New function.
8281         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8282         * gdbtypes.h (struct struct_elt): New type.
8283         (lookup_struct_elt): New prototype.
8284
8285 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8286
8287         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8288         remove disabled code block.
8289
8290 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8291
8292         * gdbarch.sh (get_thread_local_address): New method.
8293         * gdbarch.h, gdbarch.c: Regenerate.
8294         * target.c (target_translate_tls_address): Use
8295         gdbarch_get_thread_local_address if present instead of
8296         target::get_thread_local_address.
8297
8298 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8299
8300         * target.h (target::get_thread_local_address): Update comment.
8301
8302 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8303
8304         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8305         objfile->separate_debug_objfile_backlink if not NULL.
8306
8307 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8308
8309         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8310         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8311         (amd64bsd_store_inferior_registers): Likewise.
8312         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8313         Enable segment base registers.
8314         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8315         PT_GETFSBASE and PT_GETGSBASE.
8316         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8317         PT_SETGSBASE.
8318         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8319         segment base registers.
8320         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8321
8322 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8323
8324         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8325         Update calls to i386_target_description to add 'segments'
8326         parameter.
8327         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8328         add segment base registers.
8329         * arch/i386.c (i386_create_target_description): Add 'segments'
8330         parameter to enable segment base registers.
8331         * arch/i386.h (i386_create_target_description): Likewise.
8332         * features/i386/32bit-segments.xml: New file.
8333         * features/i386/32bit-segments.c: Generate.
8334         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8335         call to i386_target_description to add 'segments' parameter.
8336         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8337         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8338         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8339         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8340         if feature is present.
8341         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8342         Add 'segments' parameter to call to i386_target_description.
8343         (i386_target_description): Add 'segments' parameter to enable
8344         segment base registers.
8345         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8346         to call to i386_target_description.
8347         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8348         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8349         Define I386_NUM_REGS.
8350         (i386_target_description): Add 'segments' parameter to enable
8351         segment base registers.
8352
8353 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8354
8355         PR/24325
8356         * source-cache.c: #undef open and close, to avoid unresolved
8357         externals during linking.
8358
8359 2019-03-12  Tom Tromey  <tromey@adacore.com>
8360
8361         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8362         const.  Add initializers.
8363         (_initialize_remote): Don't initialize ptid globals.
8364
8365 2019-03-12  Pedro Alves  <palves@redhat.com>
8366
8367         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8368
8369 2019-03-12  Pedro Alves  <palves@redhat.com>
8370
8371         * cp-name-parser.y (main): Remove unused 'len' variable.
8372
8373 2019-03-12  Tom Tromey  <tromey@adacore.com>
8374
8375         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8376         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8377
8378 2019-03-12  Tom Tromey  <tromey@adacore.com>
8379
8380         * linux-nat.c (iterate_over_lwps): Update.
8381         (stop_callback): Remove parameter.
8382         (stop_wait_callback, detach_callback, resume_set_callback)
8383         (select_singlestep_lwp_callback, set_ignore_sigint)
8384         (status_callback, resumed_callback, resume_clear_callback)
8385         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8386         data parameter.
8387         (linux_nat_target::detach, linux_nat_target::resume)
8388         (linux_stop_and_wait_all_lwps, select_event_lwp)
8389         (linux_nat_filter_event, linux_nat_wait_1)
8390         (linux_nat_target::kill, linux_nat_target::stop)
8391         (linux_nat_target::stop): Update.
8392         (linux_nat_resume_callback): Change type.
8393         (resume_stopped_resumed_lwps, count_events_callback)
8394         (select_event_lwp_callback): Likewise.
8395         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8396         * arm-linux-nat.c (struct update_registers_data): Remove.
8397         (update_registers_callback): Change type.
8398         (arm_linux_insert_hw_breakpoint1): Update.
8399         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8400         parameter.
8401         (x86_linux_dr_set_addr): Update.
8402         (x86_linux_dr_set_control): Update.
8403         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8404         (iterate_over_lwps): Use gdb::function_view.
8405         * nat/aarch64-linux-hw-point.c (struct
8406         aarch64_dr_update_callback_param): Remove.
8407         (debug_reg_change_callback): Change type.
8408         (aarch64_notify_debug_reg_change): Update.
8409         * s390-linux-nat.c (s390_refresh_per_info): Update.
8410
8411 2019-03-11  Tom Tromey  <tromey@adacore.com>
8412
8413         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8414         redundant assignment to "this_cu".
8415
8416 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8417
8418         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8419
8420 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8421
8422         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8423         from...
8424         (rank_one_type): ... this.
8425
8426 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8427
8428         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8429         from...
8430         (rank_one_type): ... this.
8431
8432 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8433
8434         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8435         from...
8436         (rank_one_type): ... this.
8437
8438 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8439
8440         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8441         from...
8442         (rank_one_type): ... this.
8443
8444 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8445
8446         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8447         from...
8448         (rank_one_type): ... this.
8449
8450 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8451
8452         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8453         from...
8454         (rank_one_type): ... this.
8455
8456 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8457
8458         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8459         from...
8460         (rank_one_type): ... this.
8461
8462 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8463
8464         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8465         from...
8466         (rank_one_type): ... this.
8467
8468 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8469
8470         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8471         from...
8472         (rank_one_type): ... this.
8473
8474 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8475
8476         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8477         from...
8478         (rank_one_type): ... this.
8479
8480 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8481
8482         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8483         from...
8484         (rank_one_type): ... this.
8485
8486 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8487
8488         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8489         from...
8490         (rank_one_type): ... this.
8491
8492 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8493
8494         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8495         inferior-events' shows the example events.
8496
8497 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8498
8499         Support styling on native MS-Windows console
8500
8501         PR/24315
8502         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8503         on MS-Windows if $TERM is not defined.
8504
8505         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8506
8507         * posix-hdep.c (gdb_console_fputs):
8508         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8509         functions.
8510         * ui-file.h (gdb_console_fputs): Add prototype.
8511
8512         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8513         back to fputs only if the former returns zero.
8514
8515 2019-03-07  Tom Tromey  <tom@tromey.com>
8516
8517         * symmisc.c (print_symbol_bcache_statistics): Update.
8518         (print_objfile_statistics): Update.
8519         * symfile.c (allocate_symtab): Update.
8520         * stabsread.c: Don't include bcache.h.
8521         * psymtab.h (struct psymbol_bcache): Don't declare.
8522         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8523         (psymbol_bcache_init, psymbol_bcache_free)
8524         (psymbol_bcache_get_bcache): Don't declare.
8525         * psymtab.c (struct psymbol_bcache): Remove.
8526         (psymtab_storage::psymtab_storage): Update.
8527         (psymtab_storage::~psymtab_storage): Update.
8528         (psymbol_bcache_init, psymbol_bcache_free)
8529         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8530         (add_psymbol_to_bcache): Update.
8531         (allocate_psymtab): Update.
8532         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8533         macro_cache>: No longer pointers.
8534         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8535         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8536         * macrotab.c (macro_bcache): Update.
8537         * macroexp.c: Don't include bcache.h.
8538         * gdbtypes.c (check_types_worklist): Update.
8539         (types_deeply_equal): Remove TRY/CATCH.  Update.
8540         * elfread.c (elf_symtab_read): Update.
8541         * dwarf2read.c: Don't include bcache.h.
8542         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8543         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8544         (print_bcache_statistics, bcache_memory_used): Don't declare.
8545         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8546         methods.  Rename all data members.
8547         * bcache.c (struct bcache): Move to bcache.h.
8548         (bcache::expand_hash_table): Rename from expand_hash_table.
8549         (bcache): Remove.
8550         (bcache::insert): Rename from bcache_full.
8551         (bcache::compare): Rename from bcache_compare.
8552         (bcache_xmalloc): Remove.
8553         (bcache::~bcache): Rename from bcache_xfree.
8554         (bcache::print_statistics): Rename from print_bcache_statistics.
8555         (bcache::memory_used): Rename from bcache_memory_used.
8556
8557 2019-03-07  Pedro Alves  <palves@redhat.com>
8558
8559         * infrun.c (normal_stop): Also check for
8560         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8561
8562 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8563
8564         * f-lang.c (value_from_host_double): Moved to...
8565         * value.c (value_from_host_double): ...here.
8566         * value.h (value_from_host_double): Declare.
8567         * guile/scm-math.c (vlscm_convert_typed_number): Use
8568         value_from_host_double.
8569         (vlscm_convert_number): Likewise.
8570         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8571         * python/py-value.c (convert_value_from_python): Likewise.
8572
8573 2019-03-06  Tom Tromey  <tom@tromey.com>
8574
8575         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8576
8577 2019-03-06  Tom Tromey  <tom@tromey.com>
8578
8579         * utils.h (free_current_contents): Don't declare.
8580         * utils.c (free_current_contents): Remove.
8581
8582 2019-03-06  Tom Tromey  <tom@tromey.com>
8583
8584         * top.c (quit_force): Update.
8585         * main.c (captured_command_loop): Update.
8586         * common/new-op.c (operator new): Update.
8587         * common/common-exceptions.c (struct catcher)
8588         <save_cleanup_chain>: Remove member.
8589         (exceptions_state_mc_init): Update.
8590         (exception_try_scope_entry): Return nullptr.
8591         (exception_try_scope_exit, exception_rethrow)
8592         (throw_exception_sjlj, throw_exception_cxx): Update.
8593         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8594         (all_cleanups, do_cleanups, discard_cleanups)
8595         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8596         (restore_cleanups, restore_final_cleanups): Don't declare.
8597         (do_final_cleanups): Remove parameter.
8598         * common/cleanups.c (cleanup_chain, make_cleanup)
8599         (make_cleanup_dtor, all_cleanups, do_cleanups)
8600         (discard_my_cleanups, discard_cleanups)
8601         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8602         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8603         (null_cleanup): Remove.
8604         (do_final_cleanups): Remove parameter.
8605
8606 2019-03-06  Tom Tromey  <tom@tromey.com>
8607
8608         * remote.c (remote_target::remote_parse_stop_reply): Use
8609         unique_xmalloc_ptr.
8610
8611 2019-03-06  Tom Tromey  <tom@tromey.com>
8612
8613         * stabsread.c (struct stabs_field_info): Rename from field_info.
8614         <list, fnlist>: Add initializers.
8615         <obstack>: New member.
8616         (read_member_functions, read_struct_fields, read_baseclasses):
8617         Allocate on obstack.  Don't use cleanups.
8618         (read_one_struct_field, read_member_functions, read_struct_fields)
8619         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8620         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8621         (read_struct_type): Update.
8622
8623 2019-03-06  Tom Tromey  <tom@tromey.com>
8624
8625         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8626         * common/filestuff.h (make_cleanup_close): Don't declare.
8627         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8628         Remove.
8629
8630 2019-03-06  Tom Tromey  <tom@tromey.com>
8631
8632         * solib-aix.c: Use make_scope_exit.
8633
8634 2019-03-06  Tom Tromey  <tom@tromey.com>
8635
8636         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8637         Use make_scope_exit.
8638
8639 2019-03-06  Tom Tromey  <tom@tromey.com>
8640
8641         * solib-svr4.c (disable_probes_interface): Remove parameter.
8642         (svr4_handle_solib_event): Use make_scope_exit.
8643
8644 2019-03-06  Tom Tromey  <tom@tromey.com>
8645
8646         * remote.c (struct stop_reply_deleter): Remove.
8647         (stop_reply_up): Update.
8648         (struct stop_reply): Derive from notif_event.  Don't typedef.
8649         <regcache>: Now a std::vector.
8650         (stop_reply_xfree): Remove.
8651         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8652         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8653         (remote_target::discard_pending_stop_replies): Use delete.
8654         (remote_target::remote_parse_stop_reply): Update.
8655         (remote_target::process_stop_reply): Update.
8656         * remote-notif.h (struct notif_event): Add virtual destructor.
8657         Remove "dtr" member.
8658         (struct notif_client) <alloc_event>: Return a unique_ptr.
8659         (notif_event_xfree): Don't declare.
8660         (notif_event_up): New typedef.
8661         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8662         (notif_event_xfree, do_notif_event_xfree): Remove.
8663         (remote_notif_state_xfree): Update.
8664
8665 2019-03-06  Tom Tromey  <tom@tromey.com>
8666
8667         * infrun.c (displaced_step_clear_cleanup): Now a
8668         forward_scope_exit type.
8669         (displaced_step_prepare_throw): Update.
8670         (displaced_step_fixup): Update.
8671
8672 2019-03-06  Tom Tromey  <tom@tromey.com>
8673
8674         * inferior.h (class inferior): Update comment.
8675         * gdbthread.h (class thread_info): Update comment.
8676
8677 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8678             Tom Tromey  <tom@tromey.com>
8679
8680         * stabsread.h (struct stab_section_list): Remove.
8681         (coffstab_build_psymtabs): Update.
8682         * dbxread.c (symbuf_sections): Now a std::vector.
8683         (sect_idx): New global.
8684         (fill_symbuf): Update.
8685         (coffstab_build_psymtabs): Change type of stabsects parameter.
8686         Update.
8687         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8688         std::vector.
8689         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8690         (coff_locate_sections): Update.
8691         (coff_symfile_read): Remove cleanups.  Update.
8692         (init_stringtab): Add storage parameter.
8693         (free_stringtab, free_stringtab_cleanup): Remove.
8694         (init_lineno): Add storage parameter.
8695         (free_linetab, free_linetab_cleanup): Remove.
8696
8697 2019-03-06  Pedro Alves  <palves@redhat.com>
8698
8699         * linux-fork.c (fork_info::clobber_regs): Delete.
8700         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8701         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8702         comment.  Adjust.
8703         (scoped_switch_fork_info::scoped_switch_fork_info)
8704         (checkpoint_command, linux_fork_context): Adjust
8705         fork_save_infrun_state calls.
8706
8707 2019-03-06  Pedro Alves  <palves@redhat.com>
8708
8709         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8710         (inf_has_multiple_threads): Return 'bool' and rewrite using
8711         inferior_info::threads().
8712
8713 2019-03-06  Pedro Alves  <palves@redhat.com>
8714
8715         * linux-fork.c: Include <list>.
8716         (fork_list): Now a std::list instance.
8717         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8718         (forks_exist_p, find_last_fork): Adjust.
8719         (new_fork): Delete.
8720         (one_fork_p): New.
8721         (add_fork): Adjust.
8722         (free_fork): Delete, folded into fork_info::~fork_info().
8723         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8724         Adjust.
8725         (init_fork_list): Delete.
8726         (linux_fork_killall, linux_fork_mourn_inferior)
8727         (linux_fork_detach, info_checkpoints_command): Adjust.
8728         (_initialize_linux_fork): No longer call init_fork_list.
8729
8730 2019-03-06  Pedro Alves  <palves@redhat.com>
8731
8732         * linux-fork.c (new_fork): New, split out of ...
8733         (add_fork): ... this.  Return void.  Move "first fork" special
8734         case from here, to ...
8735         (checkpoint_command): ... here.
8736         * linux-linux.h (add_fork): Return void.
8737
8738 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8739
8740         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8741
8742 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8743             Chris January  <chris.january@arm.com>
8744             David Lecomber  <david.lecomber@arm.com>
8745
8746         * f-exp.y: New token, UNOP_INTRINSIC.
8747         (exp): New pattern using UNOP_INTRINSIC token.
8748         (f77_keywords): Add 'abs' keyword.
8749         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8750         (value_from_host_double): New function.
8751         (evaluate_subexp_f): Support UNOP_ABS.
8752
8753 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8754
8755         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8756         types.
8757
8758 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8759
8760         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8761         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8762         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8763
8764 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8765
8766         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8767
8768 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8769             Chris January  <chris.january@arm.com>
8770
8771         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8772         * f-exp.y: Define 'KIND' token.
8773         (exp): New pattern for KIND expressions.
8774         (ptype): Handle types with a kind extension.
8775         (direct_abs_decl): Extend to spot kind extensions.
8776         (f77_keywords): Add 'kind' to the list.
8777         (push_kind_type): New function.
8778         (convert_to_kind_type): New function.
8779         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8780         * parse.c (operator_length_standard): Likewise.
8781         * parser-defs.h (enum type_pieces): Add tp_kind.
8782         * std-operator.def: Add UNOP_KIND.
8783
8784 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8785
8786         * f-exp.y (f_parse): Set yydebug.
8787
8788 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8789
8790         * f-lang.c (evaluate_subexp_f): New function.
8791         (exp_descriptor_f): New global.
8792         (f_language_defn): Use exp_descriptor_f instead of
8793         exp_descriptor_standard.
8794
8795 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8796
8797         * f-exp.y (struct token): Add comments.
8798         (dot_ops): Remove uppercase versions and the end marker.
8799         (f77_keywords): Likewise.
8800         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8801         entries in the dot_ops array are case insensitive, and use
8802         strncasecmp to compare strings.  Also some whitespace cleanup in
8803         this area.  Similar for the f77_keywords array, except entries in
8804         this list might be case sensitive.
8805
8806 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8807
8808         * f-exp.y (struct f77_boolean_val): Add comments.
8809         (boolean_values): Remove uppercase versions, and end marker.
8810         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8811         and use strncasecmp to achieve case insensitivity.  Additionally,
8812         perform whitespace cleanup around this code.
8813
8814 2019-03-06  Tom Tromey  <tromey@adacore.com>
8815
8816         * remote-sim.c (gdbsim_target_open): Use result of
8817         gdb_argv::release.
8818
8819 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8820         Dirk Schubert  <dirk.schubert@arm.com>
8821         Chris January  <chris.january@arm.com>
8822
8823         * eval.c (evaluate_subexp_standard): Call Fortran argument
8824         wrapping logic.
8825         * f-lang.c (struct value): A value which can be passed into a
8826         Fortran function call.
8827         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8828         where appropriate.
8829         (struct type): Value ready for a Fortran function call.
8830         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8831         is needed.
8832         * f-lang.h (fortran_argument_convert): Declaration.
8833         (fortran_preserve_arg_pointer): Declaration.
8834         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8835
8836 2019-03-05  Tom Tromey  <tromey@adacore.com>
8837
8838         * python/py-prettyprint.c (print_string_repr): Remove #if.
8839         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8840
8841 2019-03-05  Tom Tromey  <tromey@adacore.com>
8842
8843         * target.c (the_dummy_target): Move later.  Change type to
8844         "dummy_target".
8845         (initialize_targets): Don't initialize the_dummy_target.
8846
8847 2019-03-05  Tom Tromey  <tromey@adacore.com>
8848
8849         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8850         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8851
8852 2019-03-05  Tom Tromey  <tromey@adacore.com>
8853
8854         * windows-nat.c (windows_nat_target::attach)
8855         (windows_nat_target::detach): Don't call gdb_flush.
8856         * valprint.c (generic_val_print, val_print, val_print_string):
8857         Don't call gdb_flush.
8858         * utils.c (defaulted_query): Don't call gdb_flush.
8859         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8860         * target.c (target_announce_detach): Don't call gdb_flush.
8861         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8862         * remote.c (extended_remote_target::attach): Don't call
8863         gdb_flush.
8864         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8865         * printcmd.c (do_examine): Don't call gdb_flush.
8866         (info_display_command): Don't call gdb_flush.
8867         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8868         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8869         * memattr.c (info_mem_command): Don't call gdb_flush.
8870         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8871         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8872         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8873         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8874         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8875         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8876         (gnu_nat_target::detach): Don't call gdb_flush.
8877         * f-valprint.c (f_val_print): Don't call gdb_flush.
8878         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8879         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8880         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8881         gdb_flush.
8882         * c-valprint.c (c_val_print): Don't call gdb_flush.
8883         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8884
8885 2019-03-05  Tom Tromey  <tromey@adacore.com>
8886
8887         * varobj.c (update_dynamic_varobj_children): Update.
8888         (install_default_visualizer): Use reset, not release.
8889         * value.c (set_internalvar): Update.
8890         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8891         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8892         ATTRIBUTE_UNUSED_RESULT.
8893
8894 2019-03-05  Tom Tromey  <tromey@adacore.com>
8895
8896         * remote.c (class scoped_remote_fd) <release>: Add
8897         ATTRIBUTE_UNUSED_RESULT.
8898
8899 2019-03-05  Tom Tromey  <tromey@adacore.com>
8900
8901         * macroexp.c (struct macro_buffer) <release>: Add
8902         ATTRIBUTE_UNUSED_RESULT.
8903
8904 2019-03-05  Tom Tromey  <tromey@adacore.com>
8905
8906         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8907         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8908         ATTRIBUTE_UNUSED_RESULT.
8909
8910 2019-03-05  Tom Tromey  <tromey@adacore.com>
8911
8912         * common/scoped_fd.h (class scoped_fd) <release>: Add
8913         ATTRIBUTE_UNUSED_RESULT.
8914
8915 2019-03-05  Tom Tromey  <tromey@adacore.com>
8916
8917         * parser-defs.h (struct parser_state) <release>: Add
8918         ATTRIBUTE_UNUSED_RESULT.
8919
8920 2019-03-05  Tom Tromey  <tromey@adacore.com>
8921
8922         * utils.h (class gdb_argv) <release>: Add
8923         ATTRIBUTE_UNUSED_RESULT.
8924         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8925
8926 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8927
8928         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8929         for-loop range, to avoid compiler warnings.
8930
8931         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8932         avoid compiler warnings about unused variables.
8933
8934         * NEWS: Mention end of support for native debugging on MS-Windows
8935         before XP.
8936
8937         PR gdb/24292
8938         * common/netstuff.c:
8939         * gdbserver/gdbreplay.c
8940         * gdbserver/remote-utils.c:
8941         * ser-tcp.c:
8942         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8943         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8944         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8945         'getaddrinfo' and 'freeaddrinfo' were not available before
8946         Windows XP, and mingw.org's MinGW headers by default define
8947         _WIN32_WINNT to 0x500.
8948
8949 2019-03-01  Gary Benson <gbenson@redhat.com>
8950
8951         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8952
8953 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8954             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8955
8956         PR gdb/8527
8957         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8958         set_sigint_trap, clear_sigint_trap.
8959
8960 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8961
8962         * target.c (target_detach): Clear the regcache and the
8963         frame cache.
8964
8965 2019-02-27  Pedro Alves  <palves@redhat.com>
8966
8967         * utils.c (set_screen_size): When we cap the height/width sizes,
8968         tweak the corresponding command variable to show "unlimited":
8969
8970 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8971             Pedro Alves  <palves@redhat.com>
8972
8973         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8974         before calling rl_set_screen_size.
8975
8976 2019-02-27  Tom Tromey  <tromey@adacore.com>
8977
8978         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8979         define.
8980         * python/py-value.c: Remove Python 2.4 workaround.
8981         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8982         workaround.
8983         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8984         Python 2.4 workaround.
8985         * python/python-internal.h: Remove Python 2.4 comment.
8986         (Py_ssize_t): Don't define.
8987         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8988         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8989         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8990         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8991         * python/python.c (do_start_initialization): Remove Python 2.4
8992         workaround.
8993         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8994         (print_children): Remove Python 2.4 workaround.
8995         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8996         workaround.
8997         (CHARBUFFERPROC_NAME): Remove.
8998         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8999         Python 2.4 workaround.
9000
9001 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9002
9003         * NEWS: Note minimum Python version.
9004
9005 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9006
9007         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9008         code from these functions.  Remove corresponding ifdefs.  Use
9009         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9010         Remove gotos and target of gotos.
9011         (infpy_search_memory): Likewise.
9012
9013 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9014
9015         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9016         (hppa_gdbarch_init): Don't register deleted functions with
9017         gdbarch.
9018
9019 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9020
9021         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9022         (h8300_unwind_sp): Delete.
9023         (h8300_dummy_id): Delete.
9024         (h8300_gdbarch_init): Don't register deleted functions with
9025         gdbarch.
9026
9027 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9028
9029         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9030         (ft32_unwind_pc): Delete.
9031         (ft32_unwind_sp): Delete.
9032         (ft32_gdbarch_init): Don't register deleted functions with
9033         gdbarch.
9034
9035 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9036
9037         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9038         (frv_unwind_pc): Delete.
9039         (frv_unwind_sp): Delete.
9040         (frv_gdbarch_init): Don't register deleted functions with
9041         gdbarch.
9042
9043 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9044
9045         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9046         (riscv_unwind_pc): Delete.
9047         (riscv_unwind_sp): Delete.
9048         (riscv_gdbarch_init): Don't register deleted functions with
9049         gdbarch.
9050
9051 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9052
9053         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9054         (csky_unwind_pc): Delete.
9055         (csky_unwind_sp): Delete.
9056         (csky_gdbarch_init): Don't register deleted functions with
9057         gdbarch.
9058
9059 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9060
9061         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9062         (cris_unwind_pc): Delete.
9063         (cris_unwind_sp): Delete.
9064         (cris_gdbarch_init): Don't register deleted functions with
9065         gdbarch.
9066
9067 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9068
9069         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9070         (bfin_unwind_pc): Delete.
9071         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9072
9073 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9074
9075         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9076         (arm_unwind_pc): Delete.
9077         (arm_unwind_sp): Delete.
9078         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9079
9080 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9081
9082         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9083         (arc_unwind_pc): Delete.
9084         (arc_unwind_sp): Delete.
9085         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9086
9087 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9088
9089         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9090         (alpha_unwind_pc): Delete.
9091         (alpha_gdbarch_init): Don't register deleted functions with
9092         gdbarch.
9093
9094 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9095
9096         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9097         (aarch64_unwind_pc): Delete.
9098         (aarch64_unwind_sp): Delete.
9099         (aarch64_gdbarch_init): Don't register deleted functions with
9100         gdbarch.
9101
9102 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9103
9104         * gdbtypes.c (type_align): Don't consider static members when
9105         computing structure alignment.
9106
9107 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9108
9109         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9110         return 0 for other types.
9111         * arch-utils.c (default_type_align): Always return 0.
9112         * gdbarch.h: Regenerate.
9113         * gdbarch.sh (type_align): Extend comment.
9114         * gdbtypes.c (type_align): Add additional comments, always call
9115         gdbarch_type_align before applying the default rules.
9116         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9117         generic code will then apply a suitable default.
9118         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9119         types, return 0 for other types.
9120
9121 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9122
9123         * NEWS: Create a new section for the next release branch.
9124         Rename the section of the current branch, now that it has
9125         been cut.
9126
9127 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9128
9129         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9130         * version.in: Bump version to 8.3.50.DATE-git.
9131
9132 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9133
9134         * aix-thread.c (ptid_cmp): Remove unused variable.
9135         (get_signaled_thread): Likewise.
9136         (store_regs_user_thread): Likewise.
9137         (store_regs_kernel_thread): Likewise.
9138         (fetch_regs_kernel_thread): Remove shadowed variable.
9139
9140 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9141
9142         * features/riscv/32bit-cpu.xml: Add register numbers.
9143         * features/riscv/32bit-fpu.c: Regenerate.
9144         * features/riscv/32bit-fpu.xml: Add register numbers.
9145         * features/riscv/64bit-cpu.xml: Add register numbers.
9146         * features/riscv/64bit-fpu.c: Regenerate.
9147         * features/riscv/64bit-fpu.xml: Add register numbers.
9148
9149 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9150
9151         * NEWS: Mention two argument form of gdb.Value constructor.
9152         * python/py-value.c (convert_buffer_and_type_to_value): New
9153         function.
9154         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9155         Add support for handling an optional second argument.  Call
9156         convert_buffer_and_type_to_value as appropriate.
9157         * python/python-internal.h (Py_buffer_deleter): New struct.
9158         (Py_buffer_up): New typedef.
9159
9160 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9161
9162         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9163         instead of releasing ownership.
9164
9165 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9166
9167         * dwarf2read.c (open_and_init_dwp_file): Call
9168         elf_numsections instead of bfd_count_sections to initialize
9169         dwp_file->num_sections.
9170
9171 2019-02-25  Tom Tromey  <tromey@adacore.com>
9172
9173         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9174
9175 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9176
9177         * gcore.in: Add '--readnever' option when invoking GDB.
9178
9179 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9180
9181         * MAINTAINERS: Update my email address.
9182
9183 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9184
9185         * build-id.c (build_id_to_debug_bfd_1): New function.
9186         (build_id_to_debug_bfd): Look for separate debug file in
9187         sysroot.
9188
9189 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9190
9191         * gdbarch.sh: Update the copyright year range that is placed into
9192         generated files.
9193
9194 2019-02-22  Keith Seitz  <keiths@redhat.com>
9195
9196         PR symtab/23853
9197         * linespec.c (create_sals_line_offset): Search for the default
9198         symtab's filename instead of its fullname.
9199
9200 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9201
9202         * NEWS: Update style defaults.
9203
9204 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9205
9206         * main.c (captured_main_1): Disable styling in batch mode.
9207
9208 2019-02-20  Tom Tromey  <tom@tromey.com>
9209
9210         * symtab.c (symtab_symbol_info): Fix typos.
9211
9212 2019-02-20  Tom Tromey  <tromey@adacore.com>
9213
9214         * findcmd.c (_initialize_mem_search): Use upper case for
9215         metasyntactic variables.
9216
9217 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9218
9219         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9220         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9221
9222 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9223
9224         * top.h (source_file_name): Change to std::string.
9225         * top.c (source_file_name): Likewise.
9226         (command_line_input): Adjust.
9227         * cli/cli-script.c (script_from_file): Adjust.
9228
9229 2019-02-19  Tom Tromey  <tromey@adacore.com>
9230
9231         * ravenscar-thread.c
9232         (ravenscar_thread_target::update_thread_list): Don't call
9233         ada_build_task_list.
9234         * ada-lang.h (ada_build_task_list): Don't declare.
9235         * ada-tasks.c (struct ada_tasks_inferior_data)
9236         <task_list_valid_p>: Now bool.
9237         (read_known_tasks, ada_task_list_changed)
9238         (ada_tasks_invalidate_inferior_data): Update.
9239         (read_known_tasks_array): Return bool.
9240         (read_known_tasks_list): Likewise.
9241         (read_known_tasks): Return void.
9242         (ada_build_task_list): Now static.
9243
9244 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9245
9246         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9247         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9248
9249 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9250
9251         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9252         variant for ada_tasks_pspace_data_handle and
9253         ada_tasks_inferior_data_handle.
9254         (ada_tasks_pspace_data_cleanup): New function.
9255         (ada_tasks_inferior_data_cleanup): New function.
9256
9257 2019-02-17  Tom Tromey  <tom@tromey.com>
9258
9259         * macrotab.h (macro_source_fullname): Return a std::string.
9260         * macrotab.c (macro_include, check_for_redefinition)
9261         (macro_undef, macro_lookup_definition, foreach_macro)
9262         (foreach_macro_in_scope): Update.
9263         (macro_source_fullname): Return a std::string.
9264         * macrocmd.c (show_pp_source_pos): Update.
9265
9266 2019-02-17  Tom Tromey  <tom@tromey.com>
9267
9268         * macrocmd.c (show_pp_source_pos): Style the file names.
9269
9270 2019-02-17  Tom Tromey  <tom@tromey.com>
9271
9272         PR tui/24197:
9273         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9274
9275 2019-02-17  Tom Tromey  <tom@tromey.com>
9276
9277         * ada-lang.c (user_select_syms): Use filtered printing.
9278         * utils.c (wrap_style): New global.
9279         (desired_style): Remove.
9280         (emit_style_escape): Add stream parameter.
9281         (set_output_style, reset_terminal_style, prompt_for_continue):
9282         Update.
9283         (flush_wrap_buffer): Only flush gdb_stdout.
9284         (wrap_here): Set wrap_style.
9285         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9286         treat escape sequences as a character.  Change when wrap buffer is
9287         flushed.
9288         (fputs_styled): Do not set the output style when the default is
9289         requested.
9290         * ui-style.h (struct ui_file_style) <is_default>: New method.
9291         * source.c (print_source_lines_base): Emit escape sequences in one
9292         piece.
9293
9294 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9295
9296         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9297         integers and enumeration types.
9298
9299 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9300
9301         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9302         instead of lookup_symbol_in_language
9303         (do_exact_match): New function.
9304         (ada_get_symbol_name_matcher): Return do_exact_match when
9305         doing a verbatim match.
9306
9307 2019-02-15  Tom Tromey  <tromey@adacore.com>
9308
9309         * ravenscar-thread.c (ravenscar_thread_target::resume)
9310         (ravenscar_thread_target::wait): Special case wildcard requests.
9311
9312 2019-02-15  Tom Tromey  <tromey@adacore.com>
9313
9314         * ravenscar-thread.c (base_ptid): Remove.
9315         (struct ravenscar_thread_target) <close>: New method.
9316         <m_base_ptid>: New member.
9317         <update_inferior_ptid, active_task, task_is_currently_active,
9318         runtime_initialized>: Declare methods.
9319         <ravenscar_thread_target>: Add constructor.
9320         (ravenscar_thread_target::task_is_currently_active)
9321         (ravenscar_thread_target::update_inferior_ptid)
9322         (ravenscar_runtime_initialized): Rename.  Now methods.
9323         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9324         (ravenscar_thread_target::update_thread_list): Update.
9325         (ravenscar_thread_target::active_task): Now method.
9326         (ravenscar_thread_target::store_registers)
9327         (ravenscar_thread_target::prepare_to_store)
9328         (ravenscar_thread_target::prepare_to_store)
9329         (ravenscar_thread_target::mourn_inferior): Update.
9330         (ravenscar_inferior_created): Use "new" to create target.
9331         (ravenscar_thread_target::get_ada_task_ptid): Update.
9332         (_initialize_ravenscar): Don't initialize base_ptid.
9333         (ravenscar_ops): Remove global.
9334
9335 2019-02-15  Tom Tromey  <tromey@adacore.com>
9336
9337         * target.h (push_target): Declare new overload.
9338         * target.c (push_target): New overload, taking an rvalue reference.
9339         * remote.c (remote_target::open_1): Use push_target overload.
9340         * corelow.c (core_target_open): Use push_target overload.
9341
9342 2019-02-15  Tom Tromey  <tromey@adacore.com>
9343
9344         * ravenscar-thread.c (is_ravenscar_task)
9345         (ravenscar_task_is_currently_active): Return bool.
9346         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9347         (_initialize_ravenscar): Remove "(void)".
9348         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9349         Return bool.
9350
9351 2019-02-15  Tom Tromey  <tromey@adacore.com>
9352
9353         * ravenscar-thread.c (ravenscar_runtime_initializer)
9354         (has_ravenscar_runtime, get_running_thread_id)
9355         (ravenscar_thread_target::resume): Fix indentation.
9356
9357 2019-02-15  Tom Tromey  <tromey@adacore.com>
9358
9359         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9360         from ravenscar_arch_ops.
9361         (sparc_ravenscar_ops::fetch_registers)
9362         (sparc_ravenscar_ops::store_registers): Now methods.
9363         (sparc_ravenscar_prepare_to_store): Remove.
9364         (sparc_ravenscar_ops): Redefine.
9365         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9366         methods and destructor.  Remove members.
9367         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9368         (ravenscar_thread_target::store_registers)
9369         (ravenscar_thread_target::prepare_to_store): Update.
9370         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9371         Remove.
9372         (struct ppc_ravenscar_powerpc_ops): Derive from
9373         ravenscar_arch_ops.
9374         (ppc_ravenscar_powerpc_ops::fetch_registers)
9375         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9376         (ppc_ravenscar_powerpc_ops): Redefine.
9377         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9378         (ppc_ravenscar_e500_ops::fetch_registers)
9379         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9380         (ppc_ravenscar_e500_ops): Redefine.
9381         * aarch64-ravenscar-thread.c
9382         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9383         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9384         (aarch64_ravenscar_fetch_registers)
9385         (aarch64_ravenscar_store_registers): Now methods.
9386         (aarch64_ravenscar_ops): Redefine.
9387
9388 2019-02-15  Tom Tromey  <tromey@adacore.com>
9389
9390         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9391         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9392         (ravenscar_thread_target::stopped_by_watchpoint)
9393         (ravenscar_thread_target::stopped_data_address)
9394         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9395
9396 2019-02-15  Tom Tromey  <tromey@adacore.com>
9397
9398         * ravenscar-thread.c: Fix some typos.
9399
9400 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9401             Tom Tromey  <tromey@adacore.com>
9402
9403         * ada-lang.c (ada_exception_sal): Change addr_string to a
9404         std::string.
9405         (create_ada_exception_catchpoint): Update.
9406
9407 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9408             Tom Tromey  <tromey@adacore.com>
9409
9410         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9411         (bp_location_ops): Remove.
9412         (base_breakpoint_allocate_location): Update.
9413         (free_bp_location): Update.
9414         * ada-lang.c (class ada_catchpoint_location)
9415         <ada_catchpoint_location>: Remove ops parameter.
9416         (ada_catchpoint_location_dtor): Remove.
9417         (ada_catchpoint_location_ops): Remove.
9418         (allocate_location_exception): Update.
9419         * breakpoint.h (struct bp_location_ops): Remove.
9420         (class bp_location) <bp_location>: Remove bp_location_ops
9421         parameter.
9422         <~bp_location>: Add destructor.
9423         <ops>: Remove.
9424
9425 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9426             Pedro Alves  <palves@redhat.com>
9427
9428         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9429         'PATH_MAX'.
9430
9431 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9432             Samuel Thibault  <samuel.thibault@gnu.org>
9433             Thomas Schwinge  <thomas@codesourcery.com>
9434
9435         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9436         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9437
9438 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9439
9440         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9441         (check_empty): Use "const char *".
9442
9443         * gnu-nat.c (gnu_nat_target::detach): Instead of
9444         'detach_inferior (pid)' call
9445         'detach_inferior (find_inferior_pid (pid))'.
9446
9447         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9448         'nat/fork-inferior.o'.
9449         * gnu-nat.c: #include "nat/fork-inferior.h".
9450
9451         * gnu-nat.c (gnu_nat_target::detach): Instead of
9452         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9453         * gnu-nat.h: #include "inf-child.h".
9454         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9455         'i386_gnu_nat_target::fetch_registers'.
9456         (gnu_store_registers): Rename/move to
9457         'i386_gnu_nat_target::store_registers'.
9458
9459         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9460         * gnu-nat.h (mach_thread_info): New function.
9461         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9462
9463         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9464
9465 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9466
9467         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9468
9469 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9470
9471         * windows-nat.c (windows_add_thread): Add new parameter
9472         "main_thread_p" with default value set to false.  Update
9473         function documentation as well as all callers.
9474         (windows_delete_thread): Likewise.
9475         (fake_create_process): Update call to windows_add_thread.
9476         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9477         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9478         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9479         call to windows_delete_thread.
9480
9481 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9482
9483         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9484
9485 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9486
9487         * symfile.c (find_separate_debug_file): Use canonical path of
9488         sysroot with child_path instead of gdb_sysroot if it is valid.
9489
9490 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9491
9492         * symfile.c (find_separate_debug_file): Use child_path to
9493         determine if an object file is under a sysroot.
9494
9495 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9496
9497         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9498         unittests/child-path-selftests.c.
9499         * common/pathstuff.c (child_path): New function.
9500         * common/pathstuff.h (child_path): New prototype.
9501         * unittests/child-path-selftests.c: New file.
9502
9503 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9504
9505         * symfile.c (find_separate_debug_file): Look for separate debug
9506         files in debug directories under the sysroot.
9507
9508 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9509
9510         * symtab.h (struct minimal_symbol data_p): New const method.
9511         (struct minimal_symbol text_p): Likewise.
9512         * symtab.c (output_source_filename): Use file name style
9513         to print file name.
9514         (print_symbol_info): Likewise.
9515         (print_msymbol_info): Use address style to print addresses.
9516         Use function name style to print executable text symbols.
9517         (expand_symtab_containing_pc): Use data_p.
9518         (find_pc_sect_compunit_symtab): Likewise.
9519
9520 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9521
9522         * breakpoint.c (describe_other_breakpoints): Use address style
9523         to print addresses.
9524         (say_where): Likewise.
9525
9526 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9527
9528         * ada-typeprint.c (print_func_type): Print function name
9529         style to print function name.
9530         * c-typeprint.c (c_print_type_1): Likewise.
9531
9532 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9533
9534         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9535         for execve.
9536
9537 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9538
9539         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9540         type_stack.
9541
9542 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9543
9544         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9545         TYPE_CODE_REF types.
9546
9547 2019-02-08  Jim Wilson  <jimw@sifive.com>
9548
9549         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9550         (riscv_linux_fregset): New.
9551         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9552
9553 2019-02-07  Tom Tromey  <tom@tromey.com>
9554
9555         * thread.c (thread_cancel_execution_command): Update.
9556         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9557         methods.
9558         (struct thread_fsm_ops): Remove.
9559         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9560         (thread_fsm_should_stop, thread_fsm_return_value)
9561         (thread_fsm_set_finished, thread_fsm_finished_p)
9562         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9563         Don't declare.
9564         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9565         * infrun.c (clear_proceed_status_thread)
9566         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9567         (print_stop_event): Update.
9568         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9569         Add constructor.
9570         (step_command_fsm_ops): Remove.
9571         (new_step_command_fsm): Remove.
9572         (step_1): Update.
9573         (step_command_fsm::should_stop): Rename from
9574         step_command_fsm_should_stop.
9575         (step_command_fsm::clean_up): Rename from
9576         step_command_fsm_clean_up.
9577         (step_command_fsm::do_async_reply_reason): Rename from
9578         step_command_fsm_async_reply_reason.
9579         (struct until_next_fsm): Inherit from thread_fsm.  Add
9580         constructor.
9581         (until_next_fsm_ops): Remove.
9582         (new_until_next_fsm): Remove.
9583         (until_next_fsm::should_stop): Rename from
9584         until_next_fsm_should_stop.
9585         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9586         (until_next_fsm::do_async_reply_reason): Rename from
9587         until_next_fsm_async_reply_reason.
9588         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9589         constructor.  Change type of breakpoint.
9590         (finish_command_fsm_ops): Remove.
9591         (new_finish_command_fsm): Remove.
9592         (finish_command_fsm::should_stop): Rename from
9593         finish_command_fsm_should_stop.
9594         (finish_command_fsm::clean_up): Rename from
9595         finish_command_fsm_clean_up.
9596         (finish_command_fsm::return_value): Rename from
9597         finish_command_fsm_return_value.
9598         (finish_command_fsm::do_async_reply_reason): Rename from
9599         finish_command_fsm_async_reply_reason.
9600         (finish_command): Update.
9601         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9602         Add constructor.
9603         (call_thread_fsm_ops): Remove.
9604         (call_thread_fsm::call_thread_fsm): Rename from
9605         new_call_thread_fsm.
9606         (call_thread_fsm::should_stop): Rename from
9607         call_thread_fsm_should_stop.
9608         (call_thread_fsm::should_notify_stop): Rename from
9609         call_thread_fsm_should_notify_stop.
9610         (run_inferior_call, call_function_by_hand_dummy): Update.
9611         * cli/cli-interp.c (should_print_stop_to_console): Update.
9612         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9613         Add constructor.  Change type of location_breakpoint,
9614         caller_breakpoint.
9615         (until_break_fsm_ops): Remove.
9616         (new_until_break_fsm): Remove.
9617         (until_break_fsm::should_stop): Rename from
9618         until_break_fsm_should_stop.
9619         (until_break_fsm::clean_up): Rename from
9620         until_break_fsm_clean_up.
9621         (until_break_fsm::do_async_reply_reason): Rename from
9622         until_break_fsm_async_reply_reason.
9623         (until_break_command): Update.
9624         * thread-fsm.c: Remove.
9625         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9626
9627 2019-02-07  Tom Tromey  <tom@tromey.com>
9628
9629         * yy-remap.h: Add include guard.
9630         * xtensa-tdep.h: Add include guard.
9631         * xcoffread.h: Rename include guard.
9632         * varobj-iter.h: Add include guard.
9633         * tui/tui.h: Rename include guard.
9634         * tui/tui-winsource.h: Rename include guard.
9635         * tui/tui-wingeneral.h: Rename include guard.
9636         * tui/tui-windata.h: Rename include guard.
9637         * tui/tui-win.h: Rename include guard.
9638         * tui/tui-stack.h: Rename include guard.
9639         * tui/tui-source.h: Rename include guard.
9640         * tui/tui-regs.h: Rename include guard.
9641         * tui/tui-out.h: Rename include guard.
9642         * tui/tui-layout.h: Rename include guard.
9643         * tui/tui-io.h: Rename include guard.
9644         * tui/tui-hooks.h: Rename include guard.
9645         * tui/tui-file.h: Rename include guard.
9646         * tui/tui-disasm.h: Rename include guard.
9647         * tui/tui-data.h: Rename include guard.
9648         * tui/tui-command.h: Rename include guard.
9649         * tic6x-tdep.h: Add include guard.
9650         * target/waitstatus.h: Rename include guard.
9651         * target/wait.h: Rename include guard.
9652         * target/target.h: Rename include guard.
9653         * target/resume.h: Rename include guard.
9654         * target-float.h: Rename include guard.
9655         * stabsread.h: Add include guard.
9656         * rs6000-tdep.h: Add include guard.
9657         * riscv-fbsd-tdep.h: Add include guard.
9658         * regformats/regdef.h: Rename include guard.
9659         * record.h: Rename include guard.
9660         * python/python.h: Rename include guard.
9661         * python/python-internal.h: Rename include guard.
9662         * python/py-stopevent.h: Rename include guard.
9663         * python/py-ref.h: Rename include guard.
9664         * python/py-record.h: Rename include guard.
9665         * python/py-record-full.h: Rename include guard.
9666         * python/py-record-btrace.h: Rename include guard.
9667         * python/py-instruction.h: Rename include guard.
9668         * python/py-events.h: Rename include guard.
9669         * python/py-event.h: Rename include guard.
9670         * procfs.h: Add include guard.
9671         * proc-utils.h: Add include guard.
9672         * p-lang.h: Add include guard.
9673         * or1k-tdep.h: Rename include guard.
9674         * observable.h: Rename include guard.
9675         * nto-tdep.h: Rename include guard.
9676         * nat/x86-linux.h: Rename include guard.
9677         * nat/x86-linux-dregs.h: Rename include guard.
9678         * nat/x86-gcc-cpuid.h: Add include guard.
9679         * nat/x86-dregs.h: Rename include guard.
9680         * nat/x86-cpuid.h: Rename include guard.
9681         * nat/ppc-linux.h: Rename include guard.
9682         * nat/mips-linux-watch.h: Rename include guard.
9683         * nat/linux-waitpid.h: Rename include guard.
9684         * nat/linux-ptrace.h: Rename include guard.
9685         * nat/linux-procfs.h: Rename include guard.
9686         * nat/linux-osdata.h: Rename include guard.
9687         * nat/linux-nat.h: Rename include guard.
9688         * nat/linux-namespaces.h: Rename include guard.
9689         * nat/linux-btrace.h: Rename include guard.
9690         * nat/glibc_thread_db.h: Rename include guard.
9691         * nat/gdb_thread_db.h: Rename include guard.
9692         * nat/gdb_ptrace.h: Rename include guard.
9693         * nat/fork-inferior.h: Rename include guard.
9694         * nat/amd64-linux-siginfo.h: Rename include guard.
9695         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9696         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9697         * nat/aarch64-linux.h: Rename include guard.
9698         * nat/aarch64-linux-hw-point.h: Rename include guard.
9699         * mn10300-tdep.h: Add include guard.
9700         * mips-linux-tdep.h: Add include guard.
9701         * mi/mi-parse.h: Rename include guard.
9702         * mi/mi-out.h: Rename include guard.
9703         * mi/mi-main.h: Rename include guard.
9704         * mi/mi-interp.h: Rename include guard.
9705         * mi/mi-getopt.h: Rename include guard.
9706         * mi/mi-console.h: Rename include guard.
9707         * mi/mi-common.h: Rename include guard.
9708         * mi/mi-cmds.h: Rename include guard.
9709         * mi/mi-cmd-break.h: Rename include guard.
9710         * m2-lang.h: Add include guard.
9711         * location.h: Rename include guard.
9712         * linux-record.h: Rename include guard.
9713         * linux-nat.h: Add include guard.
9714         * linux-fork.h: Add include guard.
9715         * i386-darwin-tdep.h: Rename include guard.
9716         * hppa-linux-offsets.h: Add include guard.
9717         * guile/guile.h: Rename include guard.
9718         * guile/guile-internal.h: Rename include guard.
9719         * gnu-nat.h: Rename include guard.
9720         * gdb-stabs.h: Rename include guard.
9721         * frv-tdep.h: Add include guard.
9722         * f-lang.h: Add include guard.
9723         * event-loop.h: Add include guard.
9724         * darwin-nat.h: Rename include guard.
9725         * cp-abi.h: Rename include guard.
9726         * config/sparc/nm-sol2.h: Rename include guard.
9727         * config/nm-nto.h: Rename include guard.
9728         * config/nm-linux.h: Add include guard.
9729         * config/i386/nm-i386gnu.h: Rename include guard.
9730         * config/djgpp/nl_types.h: Rename include guard.
9731         * config/djgpp/langinfo.h: Rename include guard.
9732         * compile/gcc-cp-plugin.h: Add include guard.
9733         * compile/gcc-c-plugin.h: Add include guard.
9734         * compile/compile.h: Rename include guard.
9735         * compile/compile-object-run.h: Rename include guard.
9736         * compile/compile-object-load.h: Rename include guard.
9737         * compile/compile-internal.h: Rename include guard.
9738         * compile/compile-cplus.h: Rename include guard.
9739         * compile/compile-c.h: Rename include guard.
9740         * common/xml-utils.h: Rename include guard.
9741         * common/x86-xstate.h: Rename include guard.
9742         * common/version.h: Rename include guard.
9743         * common/vec.h: Rename include guard.
9744         * common/tdesc.h: Rename include guard.
9745         * common/selftest.h: Rename include guard.
9746         * common/scoped_restore.h: Rename include guard.
9747         * common/scoped_mmap.h: Rename include guard.
9748         * common/scoped_fd.h: Rename include guard.
9749         * common/safe-iterator.h: Rename include guard.
9750         * common/run-time-clock.h: Rename include guard.
9751         * common/refcounted-object.h: Rename include guard.
9752         * common/queue.h: Rename include guard.
9753         * common/ptid.h: Rename include guard.
9754         * common/print-utils.h: Rename include guard.
9755         * common/preprocessor.h: Rename include guard.
9756         * common/pathstuff.h: Rename include guard.
9757         * common/observable.h: Rename include guard.
9758         * common/netstuff.h: Rename include guard.
9759         * common/job-control.h: Rename include guard.
9760         * common/host-defs.h: Rename include guard.
9761         * common/gdb_wait.h: Rename include guard.
9762         * common/gdb_vecs.h: Rename include guard.
9763         * common/gdb_unlinker.h: Rename include guard.
9764         * common/gdb_unique_ptr.h: Rename include guard.
9765         * common/gdb_tilde_expand.h: Rename include guard.
9766         * common/gdb_sys_time.h: Rename include guard.
9767         * common/gdb_string_view.h: Rename include guard.
9768         * common/gdb_splay_tree.h: Rename include guard.
9769         * common/gdb_setjmp.h: Rename include guard.
9770         * common/gdb_ref_ptr.h: Rename include guard.
9771         * common/gdb_optional.h: Rename include guard.
9772         * common/gdb_locale.h: Rename include guard.
9773         * common/gdb_assert.h: Rename include guard.
9774         * common/filtered-iterator.h: Rename include guard.
9775         * common/filestuff.h: Rename include guard.
9776         * common/fileio.h: Rename include guard.
9777         * common/environ.h: Rename include guard.
9778         * common/common-utils.h: Rename include guard.
9779         * common/common-types.h: Rename include guard.
9780         * common/common-regcache.h: Rename include guard.
9781         * common/common-inferior.h: Rename include guard.
9782         * common/common-gdbthread.h: Rename include guard.
9783         * common/common-exceptions.h: Rename include guard.
9784         * common/common-defs.h: Rename include guard.
9785         * common/common-debug.h: Rename include guard.
9786         * common/cleanups.h: Rename include guard.
9787         * common/buffer.h: Rename include guard.
9788         * common/btrace-common.h: Rename include guard.
9789         * common/break-common.h: Rename include guard.
9790         * cli/cli-utils.h: Rename include guard.
9791         * cli/cli-style.h: Rename include guard.
9792         * cli/cli-setshow.h: Rename include guard.
9793         * cli/cli-script.h: Rename include guard.
9794         * cli/cli-interp.h: Rename include guard.
9795         * cli/cli-decode.h: Rename include guard.
9796         * cli/cli-cmds.h: Rename include guard.
9797         * charset-list.h: Add include guard.
9798         * buildsym-legacy.h: Rename include guard.
9799         * bfin-tdep.h: Add include guard.
9800         * ax.h: Rename include guard.
9801         * arm-linux-tdep.h: Add include guard.
9802         * arm-fbsd-tdep.h: Add include guard.
9803         * arch/xtensa.h: Rename include guard.
9804         * arch/tic6x.h: Add include guard.
9805         * arch/i386.h: Add include guard.
9806         * arch/arm.h: Rename include guard.
9807         * arch/arm-linux.h: Rename include guard.
9808         * arch/arm-get-next-pcs.h: Rename include guard.
9809         * arch/amd64.h: Add include guard.
9810         * arch/aarch64-insn.h: Rename include guard.
9811         * arch-utils.h: Rename include guard.
9812         * annotate.h: Add include guard.
9813         * amd64-darwin-tdep.h: Rename include guard.
9814         * aarch64-linux-tdep.h: Add include guard.
9815         * aarch64-fbsd-tdep.h: Add include guard.
9816         * aarch32-linux-nat.h: Add include guard.
9817
9818 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9819
9820         * macrotab.c (macro_define_internal): New function that
9821         factorizes macro_define_object_internal and macro_define_function
9822         code.
9823         (macro_define_object_internal): Use macro_define_internal.
9824         (macro_define_function): Likewise.
9825
9826 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9827
9828         * macrocmd.c (extract_identifier): Return
9829         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9830         callers.
9831
9832 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9833
9834         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9835
9836 2019-02-05  Tom Tromey  <tom@tromey.com>
9837
9838         * target.c (target_stack::unpush): Move assertion earlier.
9839
9840 2019-01-30  Tom Tromey  <tom@tromey.com>
9841
9842         PR python/23615:
9843         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9844         (gdbpy_parse_and_eval): Likewise.
9845         * python/python-internal.h (gdbpy_allow_threads): New class.
9846
9847 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9848
9849         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9850         (aarch64_fbsd_fpregmap): Move earlier.
9851         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9852         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9853         instead of individual calls to trad_frame_set_reg_addr.
9854         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9855         earlier.
9856         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9857         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9858         instead of individual calls to trad_frame_set_reg_addr.
9859
9860 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9861
9862         * CONTRIBUTE: Replace contribution list with wiki link.
9863
9864 2019-01-25  Tom Tromey  <tom@tromey.com>
9865
9866         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9867
9868 2019-01-25  Tom Tromey  <tom@tromey.com>
9869
9870         * xtensa-linux-nat.c: Fix common/ includes.
9871         * xml-support.h: Fix common/ includes.
9872         * xml-support.c: Fix common/ includes.
9873         * x86-linux-nat.c: Fix common/ includes.
9874         * windows-nat.c: Fix common/ includes.
9875         * varobj.h: Fix common/ includes.
9876         * varobj.c: Fix common/ includes.
9877         * value.c: Fix common/ includes.
9878         * valops.c: Fix common/ includes.
9879         * utils.c: Fix common/ includes.
9880         * unittests/xml-utils-selftests.c: Fix common/ includes.
9881         * unittests/utils-selftests.c: Fix common/ includes.
9882         * unittests/unpack-selftests.c: Fix common/ includes.
9883         * unittests/tracepoint-selftests.c: Fix common/ includes.
9884         * unittests/style-selftests.c: Fix common/ includes.
9885         * unittests/string_view-selftests.c: Fix common/ includes.
9886         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9887         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9888         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9889         * unittests/rsp-low-selftests.c: Fix common/ includes.
9890         * unittests/parse-connection-spec-selftests.c: Fix common/
9891         includes.
9892         * unittests/optional-selftests.c: Fix common/ includes.
9893         * unittests/offset-type-selftests.c: Fix common/ includes.
9894         * unittests/observable-selftests.c: Fix common/ includes.
9895         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9896         * unittests/memrange-selftests.c: Fix common/ includes.
9897         * unittests/memory-map-selftests.c: Fix common/ includes.
9898         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9899         * unittests/function-view-selftests.c: Fix common/ includes.
9900         * unittests/environ-selftests.c: Fix common/ includes.
9901         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9902         * unittests/common-utils-selftests.c: Fix common/ includes.
9903         * unittests/cli-utils-selftests.c: Fix common/ includes.
9904         * unittests/array-view-selftests.c: Fix common/ includes.
9905         * ui-file.c: Fix common/ includes.
9906         * tui/tui-io.c: Fix common/ includes.
9907         * tracepoint.h: Fix common/ includes.
9908         * tracepoint.c: Fix common/ includes.
9909         * tracefile-tfile.c: Fix common/ includes.
9910         * top.h: Fix common/ includes.
9911         * top.c: Fix common/ includes.
9912         * thread.c: Fix common/ includes.
9913         * target/waitstatus.h: Fix common/ includes.
9914         * target/waitstatus.c: Fix common/ includes.
9915         * target.h: Fix common/ includes.
9916         * target.c: Fix common/ includes.
9917         * target-memory.c: Fix common/ includes.
9918         * target-descriptions.c: Fix common/ includes.
9919         * symtab.h: Fix common/ includes.
9920         * symfile.c: Fix common/ includes.
9921         * stap-probe.c: Fix common/ includes.
9922         * spu-linux-nat.c: Fix common/ includes.
9923         * sparc-nat.c: Fix common/ includes.
9924         * source.c: Fix common/ includes.
9925         * solib.c: Fix common/ includes.
9926         * solib-target.c: Fix common/ includes.
9927         * ser-unix.c: Fix common/ includes.
9928         * ser-tcp.c: Fix common/ includes.
9929         * ser-pipe.c: Fix common/ includes.
9930         * ser-base.c: Fix common/ includes.
9931         * selftest-arch.c: Fix common/ includes.
9932         * s12z-tdep.c: Fix common/ includes.
9933         * rust-exp.y: Fix common/ includes.
9934         * rs6000-aix-tdep.c: Fix common/ includes.
9935         * riscv-tdep.c: Fix common/ includes.
9936         * remote.c: Fix common/ includes.
9937         * remote-notif.h: Fix common/ includes.
9938         * remote-fileio.h: Fix common/ includes.
9939         * remote-fileio.c: Fix common/ includes.
9940         * regcache.h: Fix common/ includes.
9941         * regcache.c: Fix common/ includes.
9942         * record-btrace.c: Fix common/ includes.
9943         * python/python.c: Fix common/ includes.
9944         * python/py-type.c: Fix common/ includes.
9945         * python/py-inferior.c: Fix common/ includes.
9946         * progspace.h: Fix common/ includes.
9947         * producer.c: Fix common/ includes.
9948         * procfs.c: Fix common/ includes.
9949         * proc-api.c: Fix common/ includes.
9950         * printcmd.c: Fix common/ includes.
9951         * ppc-linux-nat.c: Fix common/ includes.
9952         * parser-defs.h: Fix common/ includes.
9953         * osdata.c: Fix common/ includes.
9954         * obsd-nat.c: Fix common/ includes.
9955         * nat/x86-linux.c: Fix common/ includes.
9956         * nat/x86-linux-dregs.c: Fix common/ includes.
9957         * nat/x86-dregs.h: Fix common/ includes.
9958         * nat/x86-dregs.c: Fix common/ includes.
9959         * nat/ppc-linux.c: Fix common/ includes.
9960         * nat/mips-linux-watch.h: Fix common/ includes.
9961         * nat/mips-linux-watch.c: Fix common/ includes.
9962         * nat/linux-waitpid.c: Fix common/ includes.
9963         * nat/linux-ptrace.h: Fix common/ includes.
9964         * nat/linux-ptrace.c: Fix common/ includes.
9965         * nat/linux-procfs.c: Fix common/ includes.
9966         * nat/linux-personality.c: Fix common/ includes.
9967         * nat/linux-osdata.c: Fix common/ includes.
9968         * nat/linux-namespaces.c: Fix common/ includes.
9969         * nat/linux-btrace.h: Fix common/ includes.
9970         * nat/linux-btrace.c: Fix common/ includes.
9971         * nat/fork-inferior.c: Fix common/ includes.
9972         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9973         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9974         * nat/aarch64-linux.c: Fix common/ includes.
9975         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9976         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9977         * namespace.h: Fix common/ includes.
9978         * mips-linux-tdep.c: Fix common/ includes.
9979         * minsyms.c: Fix common/ includes.
9980         * mi/mi-parse.h: Fix common/ includes.
9981         * mi/mi-main.c: Fix common/ includes.
9982         * mi/mi-cmd-env.c: Fix common/ includes.
9983         * memrange.h: Fix common/ includes.
9984         * memattr.c: Fix common/ includes.
9985         * maint.h: Fix common/ includes.
9986         * maint.c: Fix common/ includes.
9987         * main.c: Fix common/ includes.
9988         * machoread.c: Fix common/ includes.
9989         * location.c: Fix common/ includes.
9990         * linux-thread-db.c: Fix common/ includes.
9991         * linux-nat.c: Fix common/ includes.
9992         * linux-fork.c: Fix common/ includes.
9993         * inline-frame.c: Fix common/ includes.
9994         * infrun.c: Fix common/ includes.
9995         * inflow.c: Fix common/ includes.
9996         * inferior.h: Fix common/ includes.
9997         * inferior.c: Fix common/ includes.
9998         * infcmd.c: Fix common/ includes.
9999         * inf-ptrace.c: Fix common/ includes.
10000         * inf-child.c: Fix common/ includes.
10001         * ia64-linux-nat.c: Fix common/ includes.
10002         * i387-tdep.c: Fix common/ includes.
10003         * i386-tdep.c: Fix common/ includes.
10004         * i386-linux-tdep.c: Fix common/ includes.
10005         * i386-linux-nat.c: Fix common/ includes.
10006         * i386-go32-tdep.c: Fix common/ includes.
10007         * i386-fbsd-tdep.c: Fix common/ includes.
10008         * i386-fbsd-nat.c: Fix common/ includes.
10009         * guile/scm-type.c: Fix common/ includes.
10010         * guile/guile.c: Fix common/ includes.
10011         * go32-nat.c: Fix common/ includes.
10012         * gnu-nat.c: Fix common/ includes.
10013         * gdbthread.h: Fix common/ includes.
10014         * gdbarch-selftests.c: Fix common/ includes.
10015         * gdb_usleep.c: Fix common/ includes.
10016         * gdb_select.h: Fix common/ includes.
10017         * gdb_bfd.c: Fix common/ includes.
10018         * gcore.c: Fix common/ includes.
10019         * fork-child.c: Fix common/ includes.
10020         * findvar.c: Fix common/ includes.
10021         * fbsd-nat.c: Fix common/ includes.
10022         * event-top.c: Fix common/ includes.
10023         * event-loop.c: Fix common/ includes.
10024         * dwarf2read.c: Fix common/ includes.
10025         * dwarf2loc.c: Fix common/ includes.
10026         * dwarf2-frame.c: Fix common/ includes.
10027         * dwarf-index-cache.c: Fix common/ includes.
10028         * dtrace-probe.c: Fix common/ includes.
10029         * disasm-selftests.c: Fix common/ includes.
10030         * defs.h: Fix common/ includes.
10031         * csky-tdep.c: Fix common/ includes.
10032         * cp-valprint.c: Fix common/ includes.
10033         * cp-support.h: Fix common/ includes.
10034         * cp-support.c: Fix common/ includes.
10035         * corelow.c: Fix common/ includes.
10036         * completer.h: Fix common/ includes.
10037         * completer.c: Fix common/ includes.
10038         * compile/compile.c: Fix common/ includes.
10039         * compile/compile-loc2c.c: Fix common/ includes.
10040         * compile/compile-cplus-types.c: Fix common/ includes.
10041         * compile/compile-cplus-symbols.c: Fix common/ includes.
10042         * command.h: Fix common/ includes.
10043         * cli/cli-dump.c: Fix common/ includes.
10044         * cli/cli-cmds.c: Fix common/ includes.
10045         * charset.c: Fix common/ includes.
10046         * build-id.c: Fix common/ includes.
10047         * btrace.h: Fix common/ includes.
10048         * btrace.c: Fix common/ includes.
10049         * breakpoint.h: Fix common/ includes.
10050         * breakpoint.c: Fix common/ includes.
10051         * ax.h:
10052         (enum agent_op): Fix common/ includes.
10053         * ax-general.c (struct aop_map): Fix common/ includes.
10054         * ax-gdb.c: Fix common/ includes.
10055         * auxv.c: Fix common/ includes.
10056         * auto-load.c: Fix common/ includes.
10057         * arm-tdep.c: Fix common/ includes.
10058         * arch/riscv.c: Fix common/ includes.
10059         * arch/ppc-linux-common.c: Fix common/ includes.
10060         * arch/i386.c: Fix common/ includes.
10061         * arch/arm.c: Fix common/ includes.
10062         * arch/arm-linux.c: Fix common/ includes.
10063         * arch/arm-get-next-pcs.c: Fix common/ includes.
10064         * arch/amd64.c: Fix common/ includes.
10065         * arch/aarch64.c: Fix common/ includes.
10066         * arch/aarch64-insn.c: Fix common/ includes.
10067         * arch-utils.c: Fix common/ includes.
10068         * amd64-windows-tdep.c: Fix common/ includes.
10069         * amd64-tdep.c: Fix common/ includes.
10070         * amd64-sol2-tdep.c: Fix common/ includes.
10071         * amd64-obsd-tdep.c: Fix common/ includes.
10072         * amd64-nbsd-tdep.c: Fix common/ includes.
10073         * amd64-linux-tdep.c: Fix common/ includes.
10074         * amd64-linux-nat.c: Fix common/ includes.
10075         * amd64-fbsd-tdep.c: Fix common/ includes.
10076         * amd64-fbsd-nat.c: Fix common/ includes.
10077         * amd64-dicos-tdep.c: Fix common/ includes.
10078         * amd64-darwin-tdep.c: Fix common/ includes.
10079         * agent.c: Fix common/ includes.
10080         * ada-lang.h: Fix common/ includes.
10081         * ada-lang.c: Fix common/ includes.
10082         * aarch64-tdep.c: Fix common/ includes.
10083
10084 2019-01-25  Tom Tromey  <tom@tromey.com>
10085
10086         * common/create-version.sh: Use common/version.h.
10087
10088 2019-01-24  Pedro Alves  <palves@redhat.com>
10089
10090         * infrun.c (signal_stop, signal_print, signal_program)
10091         (signal_catch, signal_pass): Now arrays instead of pointers.
10092         (update_signals_program_target, do_target_resume)
10093         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10094         * linux-nat.c (linux_nat_target::pass_signals)
10095         (linux_nat_target::create_inferior, linux_nat_target::attach):
10096         Adjust.
10097         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10098         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10099         * procfs.c (procfs_target::pass_signals): Adjust.
10100         * record-full.c (record_full_target::resume): Adjust.
10101         * remote.c (remote_target::pass_signals)
10102         (remote_target::program_signals): Adjust.
10103         * target-debug.h (target_debug_print_signals): Now takes a
10104         gdb::array_view as parameter.  Adjust.
10105         * target.h (target_ops) <pass_signals, program_signals>: Replace
10106         pointer and length parameters with gdb::array_view.
10107         (target_pass_signals, target_program_signals): Likewise.
10108         * target-delegates.c: Regenerate.
10109
10110 2019-01-24  Pedro Alves  <palves@redhat.com>
10111
10112         * common/forward-scope-exit.h
10113         (forward_scope_exit::forward_scope_exit): Pass arguments to
10114         m_bind_function directly, instead of creating a std::bind and
10115         copying that.
10116
10117 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10118
10119         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10120         for static members.
10121         (pass_in_v_vfp_candidate): Likewise.
10122
10123 2019-01-23  Tom Tromey  <tom@tromey.com>
10124             Pedro Alves  <palves@redhat.com>
10125
10126         * regcache.c (class regcache_invalidator): Remove.
10127         (regcache::raw_write): Use make_scope_exit.
10128
10129 2019-01-23  Tom Tromey  <tom@tromey.com>
10130
10131         * ui-out.h (class ui_out_emit_type): Update comment.
10132
10133 2019-01-23  Tom Tromey  <tom@tromey.com>
10134
10135         * infrun.c (fetch_inferior_event): Update comment.
10136
10137 2019-01-23  Tom Tromey  <tom@tromey.com>
10138             Pedro Alves  <palves@redhat.com>
10139
10140         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10141         parameter.
10142         (fetch_inferior_event): Use SCOPE_EXIT.
10143
10144
10145 2019-01-23  Tom Tromey  <tom@tromey.com>
10146             Pedro Alves  <palves@redhat.com>
10147
10148         * infrun.c (disable_thread_events): Delete.
10149         (stop_all_threads): Use SCOPE_EXIT.
10150
10151 2019-01-23  Tom Tromey  <tom@tromey.com>
10152             Pedro Alves  <palves@redhat.com>
10153
10154         * symfile.c: Include forward-scope-exit.h.
10155         (clear_symtab_users_cleanup): Replace forward declaration with
10156         a FORWARD_SCOPE_EXIT.
10157         (syms_from_objfile_1): Use the forward_scope_exit and
10158         gdb::optional instead of cleanup_function.
10159         (reread_symbols): Use the forward_scope_exit instead of
10160         cleanup_function.
10161         (clear_symtab_users_cleanup): Remove function.
10162
10163 2019-01-23  Tom Tromey  <tom@tromey.com>
10164             Pedro Alves  <palves@redhat.com>
10165
10166         * linux-nat.c: Include scope-exit.h.
10167         (cleanup_target_stop): Remove.
10168         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10169         SCOPE_EXIT.
10170
10171 2019-01-23  Tom Tromey  <tom@tromey.com>
10172             Pedro Alves  <palves@redhat.com>
10173
10174         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10175         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10176
10177 2019-01-23  Tom Tromey  <tom@tromey.com>
10178             Andrew Burgess  <andrew.burgess@embecosm.com>
10179             Pedro Alves  <palves@redhat.com>
10180
10181         * infrun.c (fetch_inferior_event): Use scope_exit.
10182         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10183         * top.c (execute_command): Use scope_exit.
10184         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10185         * utils.c (do_bpstat_clear_actions_cleanup)
10186         (make_bpstat_clear_actions_cleanup): Remove.
10187
10188 2019-01-23  Tom Tromey  <tom@tromey.com>
10189             Pedro Alves  <palves@redhat.com>
10190
10191         * infrun.c: Include "common/scope-exit.h"
10192         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10193         (wait_for_inferior): Use SCOPE_EXIT.
10194         (fetch_inferior_event): Use scope_exit.
10195
10196 2019-01-23  Tom Tromey  <tom@tromey.com>
10197             Pedro Alves  <palves@redhat.com>
10198
10199         * breakpoint.c (create_breakpoint): Remove cleanup.
10200
10201 2019-01-23  Tom Tromey  <tom@tromey.com>
10202             Andrew Burgess  <andrew.burgess@embecosm.com>
10203             Pedro Alves  <palves@redhat.com>
10204
10205 2019-01-23  Pedro Alves  <palves@redhat.com>
10206
10207         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10208
10209 2019-01-23  Pedro Alves  <palves@redhat.com>
10210             Andrew Burgess  <andrew.burgess@embecosm.com>
10211
10212         * gdbthread.h: Include "common/forward-scope-exit.h".
10213         (scoped_finish_thread_state): Redefine custom class in terms of
10214         forward_scope_exit.
10215
10216 2019-01-23  Pedro Alves  <palves@redhat.com>
10217             Andrew Burgess  <andrew.burgess@embecosm.com>
10218
10219         * common/forward-scope-exit.h: New file.
10220
10221 2019-01-23  Pedro Alves  <palves@redhat.com>
10222             Andrew Burgess  <andrew.burgess@embecosm.com>
10223             Tom Tromey  <tom@tromey.com>
10224
10225         * common/scope-exit.h: New file.
10226
10227 2019-01-23  Pedro Alves  <palves@redhat.com>
10228
10229         * common/preprocessor.h (ESC): Rename to ...
10230         (ESC_PARENS): ... this.
10231         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10232         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10233
10234 2019-01-23  Tom Tromey  <tom@tromey.com>
10235
10236         * language.h (class scoped_switch_to_sym_language_if_auto):
10237         Initialize m_lang in both cases.
10238
10239 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10240
10241         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10242         with XCNEW.
10243
10244 2019-01-22  Tom Tromey  <tom@tromey.com>
10245
10246         * corelow.c: Do not include sys/file.h.
10247
10248 2019-01-22  Tom Tromey  <tom@tromey.com>
10249
10250         * tui/tui-wingeneral.h: Include gdb_curses.h.
10251
10252 2019-01-22  Tom Tromey  <tom@tromey.com>
10253
10254         * source-cache.h (class source_cache) <get_source_lines,
10255         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10256
10257 2019-01-22  Tom Tromey  <tom@tromey.com>
10258
10259         * remote-fileio.h (struct remote_target): Declare.
10260
10261 2019-01-22  Tom Tromey  <tom@tromey.com>
10262
10263         * python/py-arch.c: Do not include py-ref.h.
10264         * python/py-bpevent.c: Do not include py-ref.h.
10265         * python/py-cmd.c: Do not include py-ref.h.
10266         * python/py-continueevent.c: Do not include py-ref.h.
10267         * python/py-event.h: Do not include py-ref.h.
10268         * python/py-evtregistry.c: Do not include py-ref.h.
10269         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10270         * python/py-frame.c: Do not include py-ref.h.
10271         * python/py-framefilter.c: Do not include py-ref.h.
10272         * python/py-function.c: Do not include py-ref.h.
10273         * python/py-infevents.c: Do not include py-ref.h.
10274         * python/py-linetable.c: Do not include py-ref.h.
10275         * python/py-objfile.c: Do not include py-ref.h.
10276         * python/py-param.c: Do not include py-ref.h.
10277         * python/py-prettyprint.c: Do not include py-ref.h.
10278         * python/py-progspace.c: Do not include py-ref.h.
10279         * python/py-symbol.c: Do not include py-ref.h.
10280         * python/py-symtab.c: Do not include py-ref.h.
10281         * python/py-type.c: Do not include py-ref.h.
10282         * python/py-unwind.c: Do not include py-ref.h.
10283         * python/py-utils.c: Do not include py-ref.h.
10284         * python/py-value.c: Do not include py-ref.h.
10285         * python/py-varobj.c: Do not include py-ref.h.
10286         * python/py-xmethods.c: Do not include py-ref.h.
10287         * python/python.c: Do not include py-ref.h.
10288         * varobj.c: Do not include py-ref.h.
10289
10290 2019-01-22  Tom Tromey  <tom@tromey.com>
10291
10292         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10293         keyword for bcache.
10294
10295 2019-01-22  Tom Tromey  <tom@tromey.com>
10296
10297         * compile/compile-cplus-types.c: Remove a comment by #include.
10298
10299 2019-01-22  Tom Tromey  <tom@tromey.com>
10300
10301         * compile/gcc-c-plugin.h: Include compile-internal.h.
10302
10303 2019-01-22  Tom Tromey  <tom@tromey.com>
10304
10305         * stabsread.c (EXTERN): Do not define.
10306         (symnum, next_symbol_text_func, processing_gcc_compilation)
10307         (within_function, global_sym_chain, global_stabs)
10308         (previous_stab_code, this_object_header_files)
10309         (n_this_object_header_files)
10310         (n_allocated_this_object_header_files): Define.
10311         * stabsread.h (EXTERN): Never define.  Use "extern".
10312
10313 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10314
10315         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10316         history_value.
10317
10318 2019-01-21  Tom Tromey  <tom@tromey.com>
10319
10320         * ui-out.c: Fix includes.
10321         * tui/tui-source.c: Fix includes.
10322         * target.c: Fix includes.
10323         * remote.c: Fix includes.
10324         * regcache.c: Fix includes.
10325         * python/py-block.c: Fix includes.
10326         * printcmd.c: Fix includes.
10327         * or1k-tdep.c: Fix includes.
10328         * mi/mi-main.c: Fix includes.
10329         * m32r-tdep.c: Fix includes.
10330         * csky-tdep.c: Fix includes.
10331         * compile/compile-cplus-types.c: Fix includes.
10332         * cli/cli-interp.c: Fix includes.
10333
10334 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10335
10336         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10337         for padding.
10338
10339 2019-01-16  Tom Tromey  <tom@tromey.com>
10340
10341         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10342         earlier.
10343         (struct objfile) <msymbols_range>: Move from top level.
10344         <msymbols>: New method.
10345         (class objfile_msymbols): Remove.
10346         * symtab.c (default_collect_symbol_completion_matches_break_on):
10347         Update.
10348         * symmisc.c (dump_msymbols): Update.
10349         * stabsread.c (scan_file_globals): Update.
10350         * objc-lang.c (info_selectors_command, info_classes_command)
10351         (find_methods): Update.
10352         * minsyms.c (find_solib_trampoline_target): Update.
10353         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10354         * coffread.c (coff_symfile_read): Update.
10355         * ada-lang.c (ada_lookup_simple_minsym)
10356         (ada_collect_symbol_completion_matches): Update.
10357
10358 2019-01-16  Tom Tromey  <tom@tromey.com>
10359
10360         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10361         type.  Remove no-argument constructor.
10362         <iterator::operator++>: Simplify.
10363         <begin>: Update.
10364         <end>: Use minimal_symbol_count.
10365
10366 2019-01-16  Tom Tromey  <tom@tromey.com>
10367
10368         * objfiles.h (struct objfile) <psymtabs>: New method.
10369         (class objfile_psymtabs): Remove.
10370         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10371         typedef.
10372         <range>: New method.
10373         (require_partial_symbols): Change return type.
10374         * psymtab.c (require_partial_symbols)
10375         (psym_expand_symtabs_matching): Update.
10376         * mdebugread.c (parse_partial_symbols): Update.
10377         * dbxread.c (dbx_end_psymtab): Update.
10378
10379 2019-01-15  Tom Tromey  <tom@tromey.com>
10380
10381         * symtab.c (lookup_objfile_from_block)
10382         (lookup_symbol_in_objfile_symtabs)
10383         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10384         (find_line_symtab, info_sources_command)
10385         (default_collect_symbol_completion_matches_break_on)
10386         (make_source_files_completion_list): Update.
10387         * symmisc.c (print_objfile_statistics, dump_objfile)
10388         (maintenance_print_symbols, maintenance_info_symtabs)
10389         (maintenance_check_symtabs, maintenance_info_line_tables):
10390         Update.
10391         * source.c (select_source_symtab)
10392         (forget_cached_source_info_for_objfile): Update.
10393         * objfiles.h (class objfile_compunits): Remove.
10394         (struct objfile) <compunits_range>: New typedef.
10395         (compunits): New method.
10396         * objfiles.c (objfile_relocate1): Update.
10397         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10398         * maint.c (count_symtabs_and_blocks): Update.
10399         * linespec.c (iterate_over_all_matching_symtabs): Update.
10400         * cp-support.c (add_symbol_overload_list_qualified): Update.
10401         * coffread.c (coff_symtab_read): Update.
10402         * ada-lang.c (add_nonlocal_symbols)
10403         (ada_collect_symbol_completion_matches)
10404         (ada_add_global_exceptions): Update.
10405
10406 2019-01-15  Tom Tromey  <tom@tromey.com>
10407
10408         * progspace.h (program_space) <objfiles_safe_range>: New
10409         typedef.
10410         <objfiles_safe>: New method.
10411         * objfiles.h (class all_objfiles_safe): Remove.
10412         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10413         * jit.c (jit_inferior_exit_hook): Update.
10414
10415 2019-01-17  Tom Tromey  <tom@tromey.com>
10416
10417         * progspace.h (program_space) <objfiles_range>: New typedef.
10418         <objfiles>: New method.
10419         <objfiles_head>: Rename from objfiles.
10420         (object_files): Update.
10421         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10422         * guile/scm-pretty-print.c
10423         (ppscm_find_pretty_printer_from_objfiles): Update.
10424         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10425         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10426         Update.
10427         * python/py-progspace.c (pspy_get_objfiles): Update.
10428         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10429         Update.
10430         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10431         (objfpy_lookup_objfile_by_build_id): Update.
10432         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10433         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10434         Update.
10435         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10436         (expand_symtab_containing_pc, lookup_objfile_from_block)
10437         (lookup_static_symbol, basic_lookup_transparent_type)
10438         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10439         (find_line_symtab, info_sources_command)
10440         (default_collect_symbol_completion_matches_break_on)
10441         (make_source_files_completion_list, find_main_name): Update.
10442         * symmisc.c (print_symbol_bcache_statistics)
10443         (print_objfile_statistics, maintenance_print_symbols)
10444         (maintenance_print_msymbols, maintenance_print_objfiles)
10445         (maintenance_info_symtabs, maintenance_check_symtabs)
10446         (maintenance_expand_symtabs, maintenance_info_line_tables):
10447         Update.
10448         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10449         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10450         (map_overlay_command, unmap_overlay_command)
10451         (simple_overlay_update, expand_symtabs_matching)
10452         (map_symbol_filenames): Update.
10453         * symfile-debug.c (set_debug_symfile): Update.
10454         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10455         Update.
10456         * source.c (select_source_symtab, forget_cached_source_info):
10457         Update.
10458         * solib.c (solib_read_symbols): Update.
10459         * solib-spu.c (append_ocl_sos): Update.
10460         * psymtab.c (maintenance_print_psymbols)
10461         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10462         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10463         * printcmd.c (info_symbol_command): Update.
10464         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10465         Update.
10466         * objfiles.h (class all_objfiles): Remove.
10467         * objfiles.c (have_partial_symbols, have_full_symbols)
10468         (have_minimal_symbols, qsort_cmp, update_section_map)
10469         (shared_objfile_contains_address_p)
10470         (default_iterate_over_objfiles_in_search_order): Update.
10471         * objc-lang.c (info_selectors_command, info_classes_command)
10472         (find_methods): Update.
10473         * minsyms.c (find_solib_trampoline_target): Update.
10474         * maint.c (maintenance_info_sections)
10475         (maintenance_translate_address, count_symtabs_and_blocks):
10476         Update.
10477         * main.c (captured_main_1): Update.
10478         * linux-thread-db.c (try_thread_db_load_from_pdir)
10479         (has_libpthread): Update.
10480         * linespec.c (iterate_over_all_matching_symtabs)
10481         (search_minsyms_for_name): Update.
10482         * jit.c (jit_find_objf_with_entry_addr): Update.
10483         * hppa-tdep.c (find_unwind_entry)
10484         (hppa_lookup_stub_minimal_symbol): Update.
10485         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10486         Update.
10487         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10488         (elf_gnu_ifunc_resolve_by_got): Update.
10489         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10490         * dwarf-index-write.c (save_gdb_index_command): Update.
10491         * cp-support.c (add_symbol_overload_list_qualified): Update.
10492         * breakpoint.c (create_overlay_event_breakpoint)
10493         (create_longjmp_master_breakpoint)
10494         (create_std_terminate_master_breakpoint)
10495         (create_exception_master_breakpoint): Update.
10496         * blockframe.c (find_pc_partial_function): Update.
10497         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10498         (ada_collect_symbol_completion_matches)
10499         (ada_add_global_exceptions): Update.
10500
10501 2019-01-17  Tom Tromey  <tom@tromey.com>
10502
10503         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10504         declare VEC.
10505         (solib_target_parse_libraries): Change return type.
10506         (library_list_start_segment, library_list_start_section)
10507         (library_list_end_library, library_list_start_library); Update.
10508         (solib_target_free_library_list): Remove.
10509         (solib_target_parse_libraries): Remove cleanup.  Change return
10510         type.
10511         (solib_target_current_sos): Update.
10512
10513 2019-01-17  Tom Tromey  <tromey@bapiya>
10514
10515         * valprint.c: Replace "the the" with "the".
10516         * symtab.c: Replace "the the" with "the".
10517         * solib.c: Replace "the the" with "the".
10518         * solib-dsbt.c: Replace "the the" with "the".
10519         * linespec.c: Replace "the the" with "the".
10520         * dwarf2loc.h: Replace "the the" with "the".
10521         * amd64-windows-tdep.c: Replace "the the" with "the".
10522         * aarch64-tdep.c: Replace "the the" with "the".
10523
10524 2019-01-16  Keith Seitz  <keiths@redhat.com>
10525
10526         PR gdb/23773
10527         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10528         <builder>: Rename to ..
10529         <m_builder>: ... this and make private.
10530         (dwarf2_cu::get_builder): New method.  Change all users of
10531         `builder' to use this method.
10532         (dwarf2_start_symtab): Move to ...
10533         (dwarf2_cu::start_symtab): ... here.  Update all callers
10534         (setup_type_unit_groups): Move to ...
10535         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10536         callers.
10537         (dwarf2_cu::reset_builder): New method.
10538         (process_full_compunit, process_full_type_unit): Use
10539         dwarf2_cu::reset_builder.
10540         (follow_die_offset): Record the ancestor CU if it is different
10541         from the followed DIE's CU.
10542         (follow_die_sig_1): Likewise.
10543
10544 2019-01-15  Tom Tromey  <tom@tromey.com>
10545
10546         * remote.c (class remote_state) <buf>: Now a char_vector.
10547         <buf_size>: Remove.
10548         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10549         parameter.
10550         (remote_target::getpkt_or_notif_sane_1)
10551         (remote_target::getpkt_sane)
10552         (remote_target::getpkt_or_notif_sane): Likewise.
10553         (class remote_target) <putpkt>: New overload.
10554         (remote_target::read_frame): Change type of "buf_p".  Remove
10555         sizeof_p parameter.
10556         (packet_ok): New overload.
10557         (packet_check_result): New overload.
10558         Update all uses.
10559
10560 2019-01-14  Tom Tromey  <tom@tromey.com>
10561
10562         * remote-notif.c (handle_notification, remote_notif_ack)
10563         (remote_notif_parse): Make "buf" const.
10564         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10565         const.
10566         (remote_notif_parse, remote_notif_ack, handle_notification):
10567         Likewise.
10568         * remote.c (remote_notif_stop_parse): Make "buf" const.
10569         (remote_target::remote_parse_stop_reply): Make "buf" const.
10570         (remote_notif_stop_ack): Make "buf" const.
10571
10572 2019-01-14  Tom Tromey  <tom@tromey.com>
10573
10574         * remote.c (remote_console_output): Make parameter const.
10575
10576 2019-01-14  Tom Tromey  <tom@tromey.com>
10577
10578         * target-debug.h (target_debug_print_signals): Constify.
10579         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10580         * procfs.c (procfs_target::pass_signals): Update.
10581         * linux-nat.c (linux_nat_target::pass_signals): Update.
10582         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10583         * target-delegates.c: Rebuild.
10584         * remote.c (remote_target::program_signals): Update.
10585         (remote_target::pass_signals): Update.
10586         * target.c (target_pass_signals): Constify argument.
10587         (target_program_signals): Likewise.
10588         * target.h (struct target_ops) <pass_signals, program_signals>:
10589         Constify argument.
10590         (target_pass_signals, target_program_signals): Constify argument.
10591
10592 2019-01-14  Tom Tromey  <tom@tromey.com>
10593
10594         PR tui/28819:
10595         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10596
10597 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10598
10599         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10600         field.
10601         * rs6000-tdep.c: Include reggroups.h.
10602         (IS_V_ALIAS_PSEUDOREG): Define.
10603         (rs6000_register_name): Return names for the "vX" aliases.
10604         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10605         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10606         aliases.  Call default_register_reggroup_p for all other
10607         pseudo-registers.
10608         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10609         New functions.
10610         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10611         Handle "vX" aliases.
10612         (v_alias_pseudo_register_collect): New function.
10613         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10614         (rs6000_gdbarch_init): Initialize "vX" aliases as
10615         pseudo-registers.  Restore registration of
10616         rs6000_pseudo_register_reggroup_p with
10617         set_tdesc_pseudo_register_reggroup_p.
10618
10619 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10620
10621         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10622         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10623         set_gdbarch_num_pseudo_regs.
10624
10625 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10626
10627         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10628         Remove arg prefixname, add do_set and do_show.
10629         Add member functions set_list and show_list.
10630         * cli/cli-style.c (class cli_style_option): Update accordingly.
10631         (style_set_list): Move to file scope.
10632         (style_show_list): Likewise.
10633         (set_style): Call help_list.
10634         (show_style): Call cmd_show_list.
10635         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10636         Update to use the new macro.
10637
10638 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10639
10640         * ada-lang.c (_initialize_ada_language): Expand the help text
10641         for the "catch exception" command.
10642
10643 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10644
10645         * symtab.c (matching_obj_sections): Initialize obj,
10646         declare it closer to its usage.
10647
10648 2019-01-10  Tom Tromey  <tom@tromey.com>
10649
10650         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10651         (basic_inf_threads_range): Remove.
10652         (inf_threads_range, inf_non_exited_threads_range)
10653         (safe_inf_threads_range): Use next_adapter.
10654
10655 2019-01-10  Keith Seitz  <keiths@redhat.com>
10656
10657         PR gdb/23712
10658         PR symtab/23010
10659         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10660         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10661
10662 2019-01-10  Keith Seitz  <keiths@redhat.com>
10663
10664         PR gdb/23712
10665         PR symtab/23010
10666         * dictionary.c (pending_to_vector): Remove.
10667         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10668         Remove _1 suffix, replacing functions of the same name.  Update
10669         all callers.
10670         (dict_create_hashed, dict_create_hashed_expandable)
10671         (dict_create_linear, dict_create_linear_expandable, dict_free)
10672         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10673         Make functions static.
10674
10675 2019-01-10  Keith Seitz  <keiths@redhat.com>
10676
10677         PR gdb/23712
10678         PR symtab/23010
10679         * dictionary.h (struct dictionary): Replace declaration with
10680         multidictionary.
10681         (dict_create_hashed, dict_create_hashed_expandable)
10682         (dict_create_linear, dict_create_linear_expandable)
10683         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10684         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10685         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10686         taking multidictionary argument.
10687         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10688         * block.h (struct block) <dict>: Change to multidictionary
10689         and rename `multidict'.
10690         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10691         symmisc.c: Update all dictionary references to multidictionary.
10692
10693 2019-01-10  Keith Seitz  <keiths@redhat.com>
10694
10695         PR gdb/23712
10696         PR symtab/23010
10697         * dictionary.c: Include unordered_map.
10698         (pending_to_vector): New function.
10699         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10700         Rewrite the non-"_1" functions to take vector instead
10701         of linked list.
10702         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10703         "new" _1 versions of the same name.
10704         (multidictionary): Define.
10705         (std::hash<enum language): New definition.
10706         (collate_pending_symbols_by_language, mdict_create_hashed)
10707         (mdict_create_hashed_expandable, mdict_create_linear)
10708         (mdict_create_linear_expandable, mdict_free)
10709         (find_language_dictionary, create_new_language_dictionary)
10710         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10711         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10712         (mdict_size, mdict_empty): New functions.
10713         * dictionary.h (mdict_iterator): Define.
10714
10715 2019-01-10  Pedro Alves  <palves@redhat.com>
10716
10717         * breakpoint.c (read_uploaded_action)
10718         (create_tracepoint_from_upload): Adjust to use
10719         gdb::unique_xmalloc_ptr.
10720         * ctf.c (ctf_write_uploaded_tp):
10721         (SET_ARRAY_FIELD): Use emplace_back.
10722         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10723         * tracefile-tfile.c (tfile_write_uploaded_tp):
10724         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10725         gdb::unique_xmalloc_ptr.
10726         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10727         at_string, cond_string, cmd_strings>: Replace char pointers
10728         with gdb::unique_xmalloc_ptr.
10729
10730 2019-01-10  Pedro Alves  <palves@redhat.com>
10731
10732         * solib-target.c (library_list_start_library): Don't xstrdup name.
10733
10734 2019-01-10  Pedro Alves  <palves@redhat.com>
10735
10736         * mdebugread.c (parse_partial_symbols): Use
10737         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10738
10739 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10740
10741         * linux-fork.c (scoped_switch_fork_info)
10742         <~scoped_switch_fork_info>: Fix incorrect variable name.
10743
10744 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10745
10746         * linux-fork.c (scoped_switch_fork_info)
10747         <scoped_switch_fork_info>: Make explicit.
10748         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10749
10750 2019-01-10  Tom Tromey  <tom@tromey.com>
10751
10752         * objfiles.h (objfile::reset_psymtabs): Update.
10753         * objfiles.c (objfile::objfile): Update.
10754         * psymtab.h (psymtab_storage::obstack): Update.
10755         (psymtab_storage::m_obstack): Use gdb::optional.
10756         (class psymtab_storage): Update comment.  Remove objfile
10757         parameter.
10758         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10759
10760 2019-01-10  Tom Tromey  <tom@tromey.com>
10761
10762         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10763         <free_psymtabs>: Now private.
10764         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10765         (allocate_psymtab): Use new method.
10766
10767 2019-01-10  Tom Tromey  <tom@tromey.com>
10768
10769         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10770         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10771         * mdebugread.c (parse_partial_symbols): Use
10772         allocate_dependencies.
10773         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10774         allocate_dependencies.
10775         (process_psymtab_comp_unit_reader)
10776         (build_type_psymtab_dependencies): Likewise.
10777         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10778
10779 2019-01-10  Tom Tromey  <tom@tromey.com>
10780
10781         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10782         PSYMBOL_SET_LANGUAGE.
10783         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10784
10785 2019-01-10  Tom Tromey  <tom@tromey.com>
10786
10787         * psymtab.h (psymtab_storage::obstack): New method.
10788         <m_obstack>: Rename from obstack; now private.
10789         * psymtab.c (psymtab_storage): Update.
10790         * dwarf2read.c (create_addrmap_from_index)
10791         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10792         Update.
10793
10794 2019-01-10  Tom Tromey  <tom@tromey.com>
10795
10796         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10797         * objfiles.h (objfile::reset_psymtabs): New method.
10798
10799 2019-01-10  Tom Tromey  <tom@tromey.com>
10800
10801         * symmisc.c (print_symbol_bcache_statistics): Update.
10802         (print_objfile_statistics): Update.
10803         * symfile.c (reread_symbols): Update.
10804         * psymtab.h (class psymtab_storage): New.
10805         * psymtab.c (psymtab_storage): New constructor.
10806         (~psymtab_storage): New destructor.
10807         (require_partial_symbols): Update.
10808         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10809         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10810         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10811         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10812         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10813         (start_psymtab_common, end_psymtab_common)
10814         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10815         (allocate_psymtab): Update.
10816         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10817         Update.
10818         (dump_psymtab_addrmap, maintenance_print_psymbols)
10819         (maintenance_check_psymtabs): Update.
10820         (class objfile_psymtabs): Move to objfiles.h.
10821         * psympriv.h (discard_psymtab): Now inline.
10822         (psymtab_discarder::psymtab_discarder): Update.
10823         (psymtab_discarder::~psymtab_discarder): Update.
10824         (ALL_OBJFILE_PSYMTABS): Rewrite.
10825         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10826         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10827         Remove fields.
10828         <partial_symtabs>: New field.
10829         (class objfile_psymtabs): Move from psymtab.h.  Update.
10830         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10831         psymbol_cache.
10832         (objfile::~objfile): Don't destroy psymbol_cache.
10833         * mdebugread.c (parse_partial_symbols): Update.
10834         * dwarf2read.c (create_addrmap_from_index)
10835         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10836         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10837         (add_partial_subprogram, dwarf2_ranges_read): Update.
10838         * dwarf-index-write.c (write_address_map)
10839         (write_one_signatured_type, recursively_write_psymbols)
10840         (class debug_names, class debug_names, write_psymtabs_to_index):
10841         Update.
10842
10843 2019-01-10  Tom Tromey  <tom@tromey.com>
10844
10845         * symtab.h (SYMBOL_SET_NAMES): Update.
10846         (symbol_set_names): Update.
10847         (MSYMBOL_SET_NAMES): Update.
10848         * symtab.c (symbol_set_names): Change argument to be an
10849         objfile_per_bfd_storage.
10850         * psymtab.c (add_psymbol_to_bcache): Update.
10851         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10852
10853 2019-01-10  Tom Tromey  <tom@tromey.com>
10854
10855         * symtab.c (create_demangled_names_hash): Change argument to be an
10856         objfile_per_bfd_storage.
10857         (symbol_set_names): Update.
10858
10859 2019-01-10  Tom Tromey  <tom@tromey.com>
10860
10861         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10862         init_psymbol_list.
10863         * psymtab.c (init_psymbol_list): Do nothing if already called.
10864         * psympriv.h (init_psymbol_list): Add comment.
10865         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10866         init_psymbol_list.
10867         * dbxread.c (dbx_symfile_read): Unconditionally call
10868         init_psymbol_list.
10869
10870 2019-01-10  Tom Tromey  <tom@tromey.com>
10871
10872         * xcoffread.c (scan_xcoff_symtab): Update.
10873         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10874         "where".
10875         * mdebugread.c (parse_partial_symbols)
10876         (handle_psymbol_enumerators): Update.
10877         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10878         * dbxread.c (read_dbx_symtab): Update.
10879         * psympriv.h (psymbol_placement): New enum.
10880         (add_psymbol_to_list): Update.
10881
10882 2019-01-10  Tom Tromey  <tom@tromey.com>
10883
10884         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10885         static_psymbols parameters.
10886         (scan_xcoff_symtab): Update.
10887         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10888         static_psymbols parameters.
10889         * psympriv.h (start_psymtab_common): Update.
10890         * mdebugread.c (parse_partial_symbols): Update.
10891         * dwarf2read.c (create_partial_symtab): Update.
10892         * dbxread.c (read_dbx_symtab): Update.
10893         (start_psymtab): Remove global_psymbols and static_psymbols
10894         parameters.
10895
10896 2019-01-10  Tom Tromey  <tom@tromey.com>
10897
10898         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10899         * psymtab.c (allocate_psymtab): Add comment.
10900         * psympriv.h (allocate_psymtab): Add comment.
10901         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10902         initializations.
10903         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10904
10905 2019-01-10  Tom Tromey  <tom@tromey.com>
10906
10907         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10908         Don't declare.
10909         * mipsread.c: Include mdebugread.h.
10910         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10911         Declare.
10912         * elfread.c: Include mdebugread.h.
10913
10914 2019-01-09  Tom Tromey  <tom@tromey.com>
10915
10916         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10917         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10918         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10919         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10920         (psym_lookup_symbol, psym_find_last_source_symtab)
10921         (psym_forget_cached_source_info, psym_print_stats)
10922         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10923         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10924         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10925         (psym_find_compunit_symtab_by_address)
10926         (maintenance_print_psymbols, maintenance_info_psymtabs)
10927         (maintenance_check_psymtabs): Use ranged for.
10928         * psymtab.h (class objfile_psymtabs): New.
10929         (require_partial_symbols): Return objfile_psymtabs.
10930         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10931
10932 2019-01-09  Tom Tromey  <tom@tromey.com>
10933
10934         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10935         (find_pc_mapped_section, list_overlays_command)
10936         (map_overlay_command, unmap_overlay_command)
10937         (simple_overlay_update): Use all_objfiles.
10938         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10939         * printcmd.c (info_symbol_command): Use all_objfiles.
10940         * objfiles.h (ALL_OBJSECTIONS): Remove.
10941         * maint.c (maintenance_translate_address): Use all_objfiles.
10942         * gcore.c (gcore_create_callback): Use all_objfiles.
10943         (objfile_find_memory_regions): Likewise.
10944
10945 2019-01-09  Tom Tromey  <tom@tromey.com>
10946
10947         * symtab.c (find_line_symtab, info_sources_command)
10948         (make_source_files_completion_list): Use objfile_compunits.
10949         * source.c (select_source_symtab): Use objfile_compunits.
10950         * objfiles.h (struct objfile): Update comment.
10951         (ALL_OBJFILES): Remove.
10952         (ALL_FILETABS): Remove.
10953         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10954         objfile_compunits.
10955
10956 2019-01-09  Tom Tromey  <tom@tromey.com>
10957
10958         * symmisc.c (print_objfile_statistics, dump_objfile)
10959         (maintenance_print_symbols): Use compunit_filetabs.
10960         * source.c (forget_cached_source_info_for_objfile): Use
10961         compunit_filetabs.
10962         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10963         (ALL_FILETABS): Use compunit_filetabs.
10964         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10965         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10966
10967 2019-01-09  Tom Tromey  <tom@tromey.com>
10968
10969         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10970         (compunit_filetabs): New.
10971         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10972         compunit_filetabs.
10973         (info_sources_command, make_source_files_completion_list): Remove
10974         declaration.
10975         * symmisc.c (print_objfile_statistics, dump_objfile)
10976         (maintenance_print_symbols): Remove declaration.
10977         (maintenance_info_symtabs): Use compunit_filetabs.
10978         (maintenance_info_line_tables): Likewise.
10979         * source.c (select_source_symtab): Change local variable name.
10980         (forget_cached_source_info_for_objfile): Remove declaration.
10981         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10982         * objfiles.c (objfile_relocate1): Remove declaration.
10983         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10984         declaration.
10985         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10986         * coffread.c (coff_symtab_read): Remove declaration.
10987         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10988         compunit_filetabs.
10989
10990 2019-01-09  Tom Tromey  <tom@tromey.com>
10991
10992         * symtab.c (lookup_objfile_from_block)
10993         (find_pc_sect_compunit_symtab, search_symbols)
10994         (default_collect_symbol_completion_matches_break_on): Use
10995         objfile_compunits.
10996         * objfiles.h (ALL_COMPUNITS): Remove.
10997         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10998         * cp-support.c (add_symbol_overload_list_qualified): Use
10999         objfile_compunits.
11000         * ada-lang.c (ada_collect_symbol_completion_matches)
11001         (ada_add_global_exceptions): Use objfile_compunits.
11002
11003 2019-01-09  Tom Tromey  <tom@tromey.com>
11004
11005         * source.c (select_source_symtab)
11006         (forget_cached_source_info_for_objfile): Remove declaration.
11007         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11008         declaration.
11009         * maint.c (count_symtabs_and_blocks): Remove declaration.
11010         * cp-support.c (add_symbol_overload_list_qualified): Remove
11011         declaration.
11012         * coffread.c (coff_symtab_read): Remove declaration.
11013         * symtab.c (lookup_symbol_in_objfile_symtabs)
11014         (basic_lookup_transparent_type_1): Use objfile_compunits.
11015         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11016         (info_sources_command, search_symbols)
11017         (default_collect_symbol_completion_matches_break_on)
11018         (make_source_files_completion_list): Remove declaration.
11019         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11020         (ada_collect_symbol_completion_matches)
11021         (ada_add_global_exceptions): Remove declaration.
11022         * linespec.c (iterate_over_all_matching_symtabs): Use
11023         objfile_compunits.
11024         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11025         (class objfile_compunits): New.
11026         (ALL_COMPUNITS): Use objfile_compunits.
11027         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11028         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11029         objfile_compunits.
11030         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11031
11032 2019-01-09  Tom Tromey  <tom@tromey.com>
11033
11034         * symtab.c (search_symbols)
11035         (default_collect_symbol_completion_matches_break_on): Use
11036         objfile_msymbols.
11037         * ada-lang.c (ada_lookup_simple_minsym)
11038         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11039         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11040         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11041         objfile_msymbols.
11042         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11043         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11044         * objc-lang.c (find_methods): Use objfile_msymbols.
11045         (info_selectors_command, info_classes_command): Likewise.
11046         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11047         * objfiles.h (class objfile_msymbols): New.
11048         (ALL_OBJFILE_MSYMBOLS): Remove.
11049         (ALL_MSYMBOLS): Remove.
11050
11051 2019-01-09  Tom Tromey  <tom@tromey.com>
11052
11053         * common/next-iterator.h (next_adapter): Add Iterator template
11054         parameter.
11055         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11056         (class all_objfiles_safe): New.
11057         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11058         * objfiles.c (put_objfile_before): Update comment.
11059         (add_separate_debug_objfile): Likewise.
11060         (free_all_objfiles): Use all_objfiles_safe.
11061         (objfile_purge_solibs): Likewise.
11062
11063 2019-01-09  Tom Tromey  <tom@tromey.com>
11064
11065         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11066         (expand_symtab_containing_pc, lookup_static_symbol)
11067         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11068         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11069         all_objfiles.
11070         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11071         * breakpoint.c (create_overlay_event_breakpoint)
11072         (create_longjmp_master_breakpoint)
11073         (create_std_terminate_master_breakpoint)
11074         (create_exception_master_breakpoint): Use all_objfiles.
11075         * linux-thread-db.c (try_thread_db_load_from_pdir)
11076         (has_libpthread): Use all_objfiles.
11077         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11078         * linespec.c (iterate_over_all_matching_symtabs)
11079         (search_minsyms_for_name): Use all_objfiles.
11080         * maint.c (maintenance_info_sections): Use all_objfiles.
11081         * main.c (captured_main_1): Use all_objfiles.
11082         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11083         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11084         * guile/scm-pretty-print.c
11085         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11086         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11087         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11088         (maintenance_print_msymbols): Use all_objfiles.
11089         * source.c (select_source_symtab): Use all_objfiles.
11090         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11091         * symfile.c (remove_symbol_file_command)
11092         (expand_symtabs_matching, map_symbol_filenames): Use
11093         all_objfiles.
11094         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11095         all_objfiles.
11096         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11097         * objc-lang.c (find_methods): Use all_objfiles.
11098         * objfiles.c (have_partial_symbols, have_full_symbols)
11099         (have_minimal_symbols, qsort_cmp)
11100         (default_iterate_over_objfiles_in_search_order): Use
11101         all_objfiles.
11102         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11103         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11104         (maintenance_check_psymtabs): Use all_objfiles.
11105         (ALL_PSYMTABS): Remove.
11106         * compile/compile-object-run.c (do_module_cleanup): Use
11107         all_objfiles.
11108         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11109         * cp-support.c (add_symbol_overload_list_qualified): Use
11110         all_objfiles.
11111         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11112         Use all_objfiles.
11113         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11114         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11115         all_objfiles.
11116         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11117         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11118         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11119         Uses all_objfiles.
11120         * solib.c (solib_read_symbols): Use all_objfiles
11121
11122 2019-01-09  Tom Tromey  <tom@tromey.com>
11123
11124         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11125         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11126         all_objfiles.
11127         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11128         * symmisc.c (print_symbol_bcache_statistics)
11129         (print_objfile_statistics, maintenance_print_objfiles)
11130         (maintenance_info_symtabs, maintenance_check_symtabs)
11131         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11132         all_objfiles.
11133         * source.c (forget_cached_source_info): Use all_objfiles.
11134         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11135         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11136         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11137         * objfiles.c (update_section_map): Use all_objfiles.
11138         (shared_objfile_contains_address_p): Likewise.
11139         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11140         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11141
11142 2019-01-09  Tom Tromey  <tom@tromey.com>
11143
11144         * common/next-iterator.h: New file.
11145         * objfiles.h (class all_objfiles): New.
11146         (struct objfile_iterator): New.
11147
11148 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11149
11150         * NEWS: Move the description of the changed "frame", "select-frame",
11151          and "info frame" commands to the Changed commands section.
11152
11153 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11154
11155         * gdbtypes.c (check_stub_method_group): Remove handling of old
11156         mangling schemes.
11157         * linespec.c (find_methods): Likewise.
11158         * stabsread.c (read_member_functions): Likewise.
11159         * valops.c (search_struct_method): Likewise.
11160         (value_struct_elt_for_reference): Likewise.
11161         * NEWS: Mention this change.
11162
11163 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11164
11165         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11166         print_source_lines.
11167         * source.c (print_source_lines_base): Update line number check.
11168         (print_source_lines): New function.
11169         (source_lines_range::source_lines_range): New function.
11170         * source.h (class source_lines_range): New class.
11171         (print_source_lines): New declaration.
11172
11173 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11174
11175         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11176
11177 2019-01-08  Tom Tromey  <tom@tromey.com>
11178             Simon Marchi  <simon.marchi@ericsson.com>
11179
11180         PR gdb/24060
11181         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11182         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11183         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11184         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11185         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11186         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11187
11188 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11189
11190         * source.c (select_source_symtab): Move header comment to
11191         declaration in source.h.
11192         (forget_cached_source_info_for_objfile): Likewise.
11193         (forget_cached_source_info): Likewise.
11194         (identify_source_line): Likewise.
11195         * source.h (identify_source_line): Move declaration from symtab.h
11196         and add comment from source.c
11197         (print_source_lines): Likewise.
11198         (forget_cached_source_info_for_objfile): Likewise.
11199         (forget_cached_source_info): Likewise.
11200         (select_source_symtab): Likewise.
11201         (enum print_source_lines_flag): Move definition from symtab.h.
11202         * symtab.h (identify_source_line): Move declaration to source.h.
11203         (print_source_lines): Likewise.
11204         (forget_cached_source_info_for_objfile): Likewise.
11205         (forget_cached_source_info): Likewise.
11206         (select_source_symtab): Likewise.
11207         (enum print_source_lines_flag): Move definition to source.h.
11208         * tui/tui-hooks.c: Add 'source.h' include.
11209
11210 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11211
11212         * source.c (print_source_lines_base): Handle requests to print
11213         reverse line number sequences, and guard against empty lines
11214         string.
11215
11216 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11217
11218         * source.c (print_source_lines_base): Fix skip of '\r' if next
11219         character is '\n'.
11220
11221 2019-01-06  Tom Tromey  <tom@tromey.com>
11222
11223         * c-exp.y (struct c_parse_state) <macro_original_text,
11224         expansion_obstack>: New member.
11225         (macro_original_text, expansion_obstack): Remove globals.
11226         (scan_macro_expansion, scanning_macro_expansion)
11227         (finished_macro_expansion): Update.
11228         (scan_macro_cleanup): Remove.
11229         (yylex, c_parse): Update.
11230
11231 2019-01-06  Tom Tromey  <tom@tromey.com>
11232
11233         * c-exp.y (struct c_parse_state) <strings>: New member.
11234         (operator_stoken): Update.
11235
11236 2019-01-06  Tom Tromey  <tom@tromey.com>
11237
11238         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11239         (union type_stack_elt) <typelist_val>: Now a pointer to
11240         std::vector.
11241         (type_stack_cleanup): Don't declare.
11242         (push_typelist): Update.
11243         * parse.c (pop_typelist): Return a std::vector.
11244         (push_typelist): Take a std::vector.
11245         (follow_types): Update.  Do not free args.
11246         (type_stack_cleanup): Remove.
11247         * c-exp.y (struct c_parse_state): New.
11248         (cpstate): New global.
11249         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11250         (nonempty_typelist): Update.
11251         (func_mod): Create a new vector.
11252         (c_parse): Create a c_parse_state.
11253         (check_parameter_typelist): Do not delete params.
11254         (function_method): Update.  Do not delete type_list.
11255
11256 2019-01-06  Tom Tromey  <tom@tromey.com>
11257
11258         PR gdb/28155:
11259         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11260         check_typedef.
11261         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11262         (print_return_value): Likewise.
11263
11264 2019-01-05  Tom Tromey  <tom@tromey.com>
11265
11266         * contrib/cleanup_check.py: Remove.
11267         * contrib/gcc-with-excheck: Remove.
11268         * contrib/exsummary.py: Remove.
11269         * contrib/excheck.py: Remove.
11270
11271 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11272
11273         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11274         NULL. Initialize tpprev to NULL instead of assigning it
11275         to NULL on the next statement.
11276         * windows-nat.c (windows_delete_thread): Remove check for
11277         main_thread_id before printing thread exit notifications.
11278         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11279         Remove thread ID check against main_thread_id.
11280         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11281         windows_delete_thread.
11282         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11283
11284 2019-01-04  Tom Tromey  <tom@tromey.com>
11285
11286         * compile/compile.c (_initialize_compile): Use upper case for
11287         metasyntactic variables.
11288         * symmisc.c (_initialize_symmisc): Use upper case for
11289         metasyntactic variables.
11290         * psymtab.c (_initialize_psymtab): Use upper case for
11291         metasyntactic variables.
11292         * demangle.c (demangle_command): Use upper case for metasyntactic
11293         variables.
11294         (_initialize_demangler): Likewise.
11295         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11296         variables.
11297
11298 2019-01-03  Tom Tromey  <tom@tromey.com>
11299
11300         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11301
11302 2019-01-03  Tom Tromey  <tom@tromey.com>
11303
11304         * python/py-symtab.c (salpy_str): Update.
11305         (struct salpy_sal_object) <symtab>: Now a PyObject.
11306         (salpy_dealloc): Update.
11307         (del_objfile_sal): Use gdbpy_ref.
11308
11309 2019-01-03  Tom Tromey  <tom@tromey.com>
11310
11311         * python/py-type.c (convert_field): Use new_reference.  Return
11312         gdbpy_ref.
11313         (make_fielditem): Return gdbpy_ref.
11314         (typy_fields): Update.
11315         (typy_getitem): Update.
11316         (field_name): Return gdbpy_ref.  Use new_reference.
11317         (typy_iterator_iternext): Update.
11318
11319 2019-01-03  Tom Tromey  <tom@tromey.com>
11320
11321         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11322
11323 2019-01-03  Tom Tromey  <tom@tromey.com>
11324
11325         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11326         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11327         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11328         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11329         (pspy_set_type_printers): Likewise.
11330         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11331         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11332         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11333         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11334         (objfpy_set_type_printers): Likewise.
11335
11336 2019-01-03  Tom Tromey  <tom@tromey.com>
11337
11338         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11339         (gdbpy_print_stack): Use gdbpy_err_fetch.
11340         * python/python-internal.h (class gdbpy_err_fetch): New class.
11341         (class gdbpy_enter) <m_error_type, m_error_value,
11342         m_error_traceback>: Remove.
11343         <m_error>: New member.
11344         (gdbpy_exception_to_string): Don't declare.
11345         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11346         * python/py-value.c (convert_value_from_python): Use
11347         gdbpy_err_fetch.
11348         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11349         gdbpy_exception_to_string.
11350         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11351         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11352         gdbpy_err_fetch.
11353
11354 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11355
11356         * linux-nat.c (delete_lwp_cleanup): Delete.
11357         (struct lwp_deleter): New struct.
11358         (lwp_info_up): New typedef.
11359         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11360         lwp_info_up.
11361
11362 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11363
11364         * linux-fork.c (class scoped_switch_fork_info): New class.
11365         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11366
11367 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11368
11369         * valops.c (find_overload_match): Remove use of null_cleanup, and
11370         calls to do_cleanups.
11371
11372 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11373
11374         * compile/compile-cplus-types.c
11375         (compile_cplus_instance::decl_name): Handle changes to
11376         cp_func_name.
11377         * cp-support.c (cp_func_name): Update header comment, update
11378         return type.
11379         * cp-support.h (cp_func_name): Update return type in declaration.
11380         * valops.c (find_overload_match): Move temp_func local to top
11381         level of function and change its type.  Use temp_func to hold and
11382         delete temporary string obtained from cp_func_name.
11383
11384 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11385
11386         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11387         gdb::char_vector, remove cleanup, and update uses of `msg`.
11388
11389 2019-01-03  Jim Wilson  <jimw@sifive.com>
11390
11391         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11392
11393 2019-01-02  Tom Tromey  <tom@tromey.com>
11394
11395         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11396         (tdesc_parse_xml): Remove cleanups.
11397         * target-descriptions.h (make_cleanup_free_target_description):
11398         Don't declare.
11399         (target_desc_deleter): New struct.
11400         (target_desc_up): New typedef.
11401         * target-descriptions.c (target_desc_deleter::operator()): Rename
11402         from free_target_description.
11403         (make_cleanup_free_target_description): Remove.
11404
11405 2019-01-02  Tom Tromey  <tom@tromey.com>
11406
11407         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11408         constructor, destructor.
11409         (linespec_parser): Remove typedef.
11410         (~linespec_parser): Rename from linespec_parser_delete.
11411         (linespec_lex_to_end, linespec_complete_label)
11412         (linespec_complete): Update.
11413         (decode_line_full): Remove cleanups.
11414         (decode_line_1): Update.
11415
11416 2019-01-02  Tom Tromey  <tom@tromey.com>
11417
11418         * python/python-internal.h (inferior_to_inferior_object): Change
11419         return type.
11420         * python/py-exitedevent.c (create_exited_event_object): Update.
11421         * python/py-inferior.c (inferior_to_inferior_object): Return
11422         gdbpy_ref.
11423         (python_new_inferior, python_inferior_deleted)
11424         (thread_to_thread_object, delete_thread_object)
11425         (build_inferior_list, gdbpy_selected_inferior): Update.
11426         * python/py-infthread.c (create_thread_object): Update.  Also fail
11427         if inferior_to_inferior_object fails.
11428
11429 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11430
11431         * inferior.h (class inferior) <displaced_step_state>: New field.
11432         * infrun.h (struct displaced_step_state): Move here from
11433         infrun.c.  Initialize fields, add constructor.
11434         <inf>: Remove field.
11435         <reset>: New method.
11436         * infrun.c (struct displaced_step_inferior_state): Move to
11437         infrun.h.
11438         (displaced_step_inferior_states): Remove.
11439         (get_displaced_stepping_state): Adust.
11440         (displaced_step_in_progress_any_inferior): Adjust.
11441         (displaced_step_in_progress_thread): Adjust.
11442         (displaced_step_in_progress): Adjust.
11443         (add_displaced_stepping_state): Remove.
11444         (get_displaced_step_closure_by_addr): Adjust.
11445         (remove_displaced_stepping_state): Remove.
11446         (infrun_inferior_exit): Call displaced_step_state.reset.
11447         (use_displaced_stepping): Don't check for NULL.
11448         (displaced_step_prepare_throw): Call
11449         get_displaced_stepping_state.
11450         (displaced_step_fixup): Don't check for NULL.
11451         (prepare_for_detach): Don't check for NULL.
11452
11453 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11454
11455         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11456          in case of call that did not complete.
11457
11458 2019-01-02  Andrey Utkin  <autkin@undo.io>
11459
11460         * symfile.c (find_separate_debug_file): Fix search of debug files for
11461         remote debuggee.
11462
11463 2019-01-02  Tom Tromey  <tom@tromey.com>
11464
11465         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11466         indentation.
11467         * python/py-frame.c (frapy_older): Remove cast.
11468         (frapy_newer): Likewise.
11469         * python/py-breakpoint.c (local_setattro): Remove cast.
11470         * python/py-arch.c (archpy_name): Remove local variable.
11471         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11472
11473 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11474
11475         * unittests/basic_string_view/element_access/char/empty.cc:
11476         Fix year range in copyright header.
11477
11478 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11479
11480         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11481         Delete.
11482         <operator==>: Update with for removed field.
11483         <hash>: Likewise.
11484         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11485         <isa_features>: ...this.
11486         <abi_features>: New field.
11487         (riscv_isa_flen): Update comment.
11488         (riscv_abi_xlen): New declaration.
11489         (riscv_abi_flen): New declaration.
11490         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11491         isa_features.
11492         (riscv_abi_xlen): New function.
11493         (riscv_isa_flen): Update to get answer from isa_features.
11494         (riscv_abi_flen): New function.
11495         (riscv_has_fp_abi): Update to get answer from abi_features.
11496         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11497         xlen and flen.
11498         (riscv_call_info) <xlen, flen>: Update comment.
11499         (riscv_call_arg_struct): Remove invalid assertions
11500         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11501         is removed.
11502         (riscv_gdbarch_init): Gather isa features and abi features
11503         separately, ensure both match on the gdbarch when reusing an old
11504         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11505         a target with 64-bit float hardware.
11506
11507 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11508
11509         * source.c (search_command_helper): Stop reverse search
11510         when line 1 has been searched.
11511
11512 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11513
11514         * record-full.c (record_full_base_target::close): Rewrite
11515         record_full_core_buf_list free logic.
11516
11517 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11518
11519         * break-catch-syscall.c (print_one_catch_syscall): xfree
11520         the last text.
11521
11522 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11523
11524         * top.c (print_gdb_version): Update Copyright year in version
11525         message.
11526
11527 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11528
11529         Update copyright year range in all GDB files.
11530
11531 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11532
11533         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11534
11535 For older changes see ChangeLog-2018.
11536 \f
11537 Local Variables:
11538 mode: change-log
11539 left-margin: 8
11540 fill-column: 74
11541 version-control: never
11542 coding: utf-8
11543 End:
11544