gdb/ChangeLog

   1 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * eval.c (evaluate_subexp_standard): Handle internal functions
   4         during Fortran function call handling.
   5
   6 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
   7
   8         * NEWS: Mention new internal functions.
   9         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
  10         (read_base_type): Use dwarf2_init_complex_target_type.
  11         * value.c (creal_internal_fn): New function.
  12         (cimag_internal_fn): New function.
  13         (_initialize_values): Register new internal functions.
  14
  15 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  16
  17         * infrun.c (stop_all_threads): If debug_infrun, always
  18         trace the wait status after wait_one, using
  19         target_waitstatus_to_string and target_pid_to_str.
  20         (handle_inferior_event): Replace various trace of
  21         wait status kind by a single trace.
  22         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
  23         wait status kind image by target_waitstatus_to_string.
  24         * target/waitstatus.c (target_waitstatus_to_string): Fix
  25         obsolete comment.
  26
  27 2019-04-01  Tom Tromey  <tromey@adacore.com>
  28
  29         PR symtab/23331:
  30         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
  31
  32 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
  33             Pedro Alves  <palves@redhat.com>
  34
  35         * top.c (quit_force): Call 'finalize_values'.
  36         * value.c (finalize_values): New function.
  37         * value.h (finalize_values): Declare.
  38
  39 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
  40
  41         * NEWS: Announce $_gdb_major and $_gdb_minor.
  42
  43         * top.c (init_gdb_version_vars): New function.
  44         (gdb_init): Call init_gdb_version_vars.
  45
  46 2019-03-29  Tom Tromey  <tromey@adacore.com>
  47
  48         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
  49         help text.  Remove dead code.
  50
  51 2019-03-29  Keith Seitz  <keiths@redhat.com>
  52
  53         From Siddhesh Poyarekar:
  54         * f-lang.h (f77_get_upperbound): Return LONGEST.
  55         (f77_get_lowerbound): Likewise.
  56         * f-typeprint.c (f_type_print_varspec_suffix): Expand
  57         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
  58         print them.
  59         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
  60         plongest to format print it.
  61         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
  62         (f77_get_upperbound): Likewise.
  63         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
  64         LOWER_BOUND to LONGEST.
  65         (f77_create_arrayprint_offset_tbl): Likewise.
  66
  67 2019-03-29  Keith Seitz  <keiths@redhat.com>
  68
  69         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
  70         %s/pulongest for TYPE_LENGTH instead of %d in format
  71         strings.
  72         * ada-typerint.c (ada_print_type): Likewise.
  73         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
  74         * compile/compile-c-support.c (generate_register_struct): Likewise.
  75         * gdbtypes.c (recursive_dump_type): Likewise.
  76         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
  77         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
  78         instead of %d in format strings.
  79         * riscv-tdep.c (riscv_type_alignment): Cast second argument
  80         to std::min to ULONGEST.
  81         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
  82         instead of %d in format strings.
  83         * tracepoint.c (info_scope_command): Likewise.
  84         * typeprint.c (print_offset_data::update)
  85         (print_offset_data::finish): Likewise.
  86         * xtensa-tdep.c (xtensa_store_return_value)
  87         (xtensa_push_dummy_call): Likewise.
  88
  89 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
  90
  91         * windows-nat.c (display_selector): Fixed format specifications
  92         for 64-bit Cygwin.
  93
  94 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  95
  96         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
  97
  98 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
  99
 100         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
 101         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
 102         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
 103         (nios2_linux_init_abi): Install it.
 104
 105 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 106
 107         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
 108
 109 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 110
 111         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
 112
 113 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 114             Tom Tromey  <tromey@adacore.com>
 115
 116         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
 117
 118 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 119
 120         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
 121         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
 122         method to compute the bounds of range types. Also print "[evaluated]"
 123         if the bounds' values come from a dynamic evaluation.
 124
 125 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 126
 127         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 128         whitespace when pretty printing is on.
 129
 130 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 131
 132         * ppc-linux-nat.c: Add include.
 133
 134 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 135
 136         * NEWS: Mention AArch64 Pointer Authentication.
 137
 138 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 139
 140         * arm-linux-nat.c: Add include.
 141
 142 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 143
 144         * source-cache.c (source_cache::get_source_lines): Re-read
 145         fullname after calling open_source_file.
 146
 147 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 148
 149         * NEWS: Mention TLS support for FreeBSD.
 150
 151 2019-03-25  Tom Tromey  <tromey@adacore.com>
 152
 153         * minsyms.c (BUNCH_SIZE): Update comment.
 154         (~minimal_symbol_reader): Remove old comment.
 155         (compact_minimal_symbols): Update comment.
 156         (minimal_symbol_reader::install): Remove old comment.  Update
 157         other comments.
 158
 159 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 160
 161         * s390-linux-nat.c: Add include.
 162
 163 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 164
 165         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 166         Call linux_get_hwcap.
 167         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 168         Likewise.
 169         (aarch64_linux_get_hwcap): Remove function.
 170         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 171         declaration.
 172         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 173         linux_get_hwcap.
 174         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 175         * linux-tdep.c (linux_get_hwcap): Add function.
 176         (linux_get_hwcap2): Likewise.
 177         * linux-tdep.h (linux_get_hwcap): Add declaration.
 178         (linux_get_hwcap2): Likewise.
 179         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 180         (ppc_linux_get_hwcap2): Likewise.
 181         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 182         linux_get_hwcap.
 183         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 184         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 185         (ppc_linux_nat_target::read_description): Likewise.
 186         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 187         * s390-linux-nat.c: Likewise.
 188         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 189
 190 2019-03-24  Tom Tromey  <tom@tromey.com>
 191
 192         * ada-lang.c (standard_lookup): Simplify initialization.
 193         (ada_lookup_symbol_nonlocal): Simplify return.
 194         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 195         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 196         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 197         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 198         initialization.
 199         * solib.c (solib_global_lookup): Simplify.
 200         * symtab.c (null_block_symbol): Remove.
 201         (symbol_cache_lookup): Simplify returns.
 202         (lookup_language_this): Simplify returns.
 203         (lookup_symbol_aux): Simplify return.
 204         (lookup_local_symbol): Simplify returns.
 205         (lookup_global_symbol_from_objfile): Simplify return.
 206         (lookup_symbol_in_objfile_symtabs)
 207         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 208         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 209         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 210         * cp-namespace.c (cp_lookup_bare_symbol)
 211         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 212         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 213         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 214         (cp_lookup_symbol_via_imports): Simplify initialization.
 215         (find_symbol_in_baseclass): Likewise.
 216         * symtab.h (null_block_symbol): Remove.
 217         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 218         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 219         (d_lookup_symbol_module): Likewise.
 220         (find_symbol_in_baseclass): Simplify initialization.
 221
 222 2019-03-24  Tom Tromey  <tom@tromey.com>
 223
 224         * expression.h: Don't include symtab.h.
 225         (struct block): Forward declare.
 226
 227 2019-03-24  Tom Tromey  <tom@tromey.com>
 228
 229         * c-exp.y (typebase): Remove casts.
 230         * gdbtypes.c (lookup_unsigned_typename, )
 231         (lookup_signed_typename): Remove cast.
 232         * eval.c (parse_to_comma_and_eval): Remove cast.
 233         * parse.c (write_dollar_variable): Remove cast.
 234         * block.h (struct block) <superblock>: Now const.
 235         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 236         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 237         (map_block): Make "block" const.
 238         * symfile.h (struct quick_symbol_functions)
 239         <map_matching_symbols>: Constify block argument to "callback".
 240         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 241         const.
 242         (find_pc_sect_compunit_symtab): Make "b" const.
 243         (find_symbol_at_address): Likewise.
 244         (search_symbols): Likewise.
 245         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 246         (dw2_debug_names_lookup_symbol): Likewise.
 247         (dw2_map_matching_symbols): Update.
 248         * p-valprint.c (pascal_val_print): Remove "block".
 249         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 250         (aux_add_nonlocal_symbols): Make "block" const.
 251         (resolve_subexp): Remove cast.
 252         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 253         const.
 254         (iterate_over_file_blocks): Likewise.
 255         * f-exp.y (%union) <bval>: Remove.
 256         * coffread.c (patch_opaque_types): Make "b" const.
 257         * spu-tdep.c (spu_catch_start): Make "block" const.
 258         * c-valprint.c (print_unpacked_pointer): Remove "block".
 259         * symmisc.c (dump_symtab_1): Make "b" const.
 260         (block_depth): Make "block" const.
 261         * d-exp.y (%union) <bval>: Remove.
 262         * cp-support.h (cp_lookup_rtti_type): Update.
 263         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 264         * psymtab.c (psym_lookup_symbol): Make "block" const.
 265         (maintenance_check_psymtabs): Make "b" const.
 266         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 267         (enumerate_locals, enumerate_args): Update.
 268         * python/py-symtab.c (stpy_global_block): Make "block" const.
 269         (stpy_static_block): Likewise.
 270         * inline-frame.c (block_starting_point_at): Make "new_block"
 271         const.
 272         * block.c (find_block_in_blockvector): Make return type const.
 273         (blockvector_for_pc_sect): Make "b" const.
 274         (find_block_in_blockvector): Make "b" const.
 275
 276 2019-03-23  Tom Tromey  <tom@tromey.com>
 277
 278         * varobj.c (varobj_create): Update.
 279         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 280         * printcmd.c (display_command, do_one_display): Don't reset
 281         innermost_block.
 282         * parser-defs.h (enum innermost_block_tracker_type): Move to
 283         expression.h.
 284         (innermost_block): Update comment.
 285         * parse.c (parse_exp_1): Add tracker_types parameter.
 286         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 287         tracker_types parameter.  Reset innermost_block.
 288         (parse_exp_in_context): Remove.
 289         (parse_expression_for_completion): Update.
 290         * objfiles.c (~objfile): Don't reset expression_context_block or
 291         innermost_block.
 292         * expression.h (enum innermost_block_tracker_type): Move from
 293         parser-defs.h.
 294         (parse_exp_1): Add tracker_types parameter.
 295         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 296         reset innermost_block.
 297
 298 2019-03-23  Tom Tromey  <tom@tromey.com>
 299
 300         * objfiles.h: Include bcache.h.
 301
 302 2019-03-23  Tom Tromey  <tom@tromey.com>
 303
 304         * linespec.c (get_current_search_block): Use
 305         scoped_restore_current_language.
 306         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 307
 308 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 309             Jiong Wang  <jiong.wang@arm.com>
 310
 311         * aarch64-linux-tdep.c
 312         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 313         section.
 314         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 315
 316 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 317             Jiong Wang  <jiong.wang@arm.com>
 318
 319         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 320         instructions.
 321         (aarch64_analyze_prologue_test): Add PACIASP test.
 322         (aarch64_prologue_prev_register): Unmask PC value.
 323
 324 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 325             Jiong Wang  <jiong.wang@arm.com>
 326
 327         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 328         (aarch64_dwarf2_prev_register): Unmask PC value.
 329         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 330         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 331         DW_CFA_AARCH64_negate_ra_state.
 332         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 333
 334 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 335             Jiong Wang  <jiong.wang@arm.com>
 336
 337         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 338         registers.
 339         (aarch64_pseudo_register_name): Likewise.
 340         (aarch64_pseudo_register_type): Likewise.
 341         (aarch64_pseudo_register_reggroup_p): Likewise.
 342         (aarch64_gdbarch_init): Add pauth registers.
 343         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 344         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 345         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 346         (struct gdbarch_tdep): Add regnum for ra_state.
 347
 348 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 349             Jiong Wang  <jiong.wang@arm.com>
 350
 351         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 352
 353 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 354             Jiong Wang  <jiong.wang@arm.com>
 355
 356         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 357         function.
 358         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 359         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 360         (aarch64_gdbarch_init): Add puth registers.
 361         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 362         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 363         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 364
 365 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 366             Jiong Wang  <jiong.wang@arm.com>
 367
 368         * aarch64-linux-nat.c
 369         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 370         * aarch64-linux-tdep.c
 371         (aarch64_linux_core_read_description): Likewise.
 372         (aarch64_linux_get_hwcap): New function.
 373         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 374         (aarch64_linux_get_hwcap): New declaration.
 375
 376 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 377             Jiong Wang  <jiong.wang@arm.com>
 378
 379         * aarch64-linux-nat.c
 380         (aarch64_linux_nat_target::read_description): Add pauth param.
 381         * aarch64-linux-tdep.c
 382         (aarch64_linux_core_read_description): Likewise.
 383         * aarch64-tdep.c (struct target_desc): Add in pauth.
 384         (aarch64_read_description): Add pauth param.
 385         (aarch64_gdbarch_init): Likewise.
 386         * aarch64-tdep.h (aarch64_read_description): Likewise.
 387         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 388         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 389         * features/Makefile: Add new files.
 390         * features/aarch64-pauth.c: New file.
 391         * features/aarch64-pauth.xml: New file.
 392
 393 2019-03-20  Tom Tromey  <tromey@adacore.com>
 394
 395         * infrun.c (handle_inferior_event): Rename from
 396         handle_inferior_event_1.  Create a scoped_value_mark.
 397         (handle_inferior_event): Remove.
 398
 399 2019-03-19  Tom Tromey  <tromey@adacore.com>
 400
 401         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 402         * infrun.h (print_stop_event): Add "displays" parameter.
 403         * infrun.c (print_stop_event): Add "displays" parameter.
 404
 405 2019-03-19  Pedro Alves  <palves@redhat.com>
 406
 407         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 408         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 409         to -1.  Fix TABs vs spaces.
 410         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 411         * tui/tui-out.h (tui_ui_out) Add intro comments.
 412         <m_line, m_start_of_line>: In-class initialize, and add describing
 413         comment.
 414
 415 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 416
 417         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 418         variable names.
 419         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 420
 421 2019-03-18  Pedro Alves  <palves@redhat.com>
 422             Eli Zaretskii <eliz@gnu.org>
 423
 424         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 425         m_line and m_start_of_line.
 426
 427 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 428
 429         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 430         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 431         it returns a newline.  This fixes a regression in TU mode, whereby
 432         the next line is output on the same screen line as the user input.
 433
 434 2019-03-18  Tom Tromey  <tromey@adacore.com>
 435
 436         * minsyms.c (minimal_symbol_reader::install): Remove call to
 437         obstack_blank.
 438
 439 2019-03-18  Pedro Alves  <palves@redhat.com>
 440
 441         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 442         New globals.
 443         (apply_style): New, factored out from ...
 444         (apply_ansi_escape): ... this.  Handle reverse video mode.
 445         (tui_set_reverse_mode): New function.
 446         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 447         * tui/tui-winsource.c (tui_show_source_line): Use
 448         tui_set_reverse_mode instead of setting A_STANDOUT.
 449         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 450         New setter methods.
 451
 452 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 453
 454         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 455         Handle tabs.
 456
 457 2019-03-18  Tom Tromey  <tromey@adacore.com>
 458
 459         * ada-lang.c (empty_array): Add "high" parameter.
 460         (ada_evaluate_subexp): Update.
 461
 462 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 463
 464         * unittests/string_view-selftests.c: Define
 465         _initialize_string_view_selftests unconditionally.
 466
 467 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 468
 469         PR gdb/24350
 470         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 471
 472 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 473
 474         PR gdb/24351
 475         * windows-nat.c (display_selector): Fix format specifiers.
 476
 477 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 478
 479         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 480         tui_refill_source_window instead of tui_refresh_win, to update the
 481         current execution line.  This fixes redisplay of the current line
 482         when stepping through the code with "next" or "step".
 483
 484 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 485
 486         * source-cache.c (source_cache::get_source_lines): Call
 487         find_source_lines to initialize s->nlines.  This fixes vertical
 488         scrolling of TUI source window when the DOWN arrow is pressed.
 489
 490 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 491
 492         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 493         linux-thread-db.c (_initialize_thread_db): Likewise.
 494
 495 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 496
 497         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 498         wclrtoeol in tui_show_source_line".  This reverts changes made in
 499         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 500
 501 2019-03-15  Tom Tromey  <tom@tromey.com>
 502
 503         * symtab.h (struct minimal_symbol): Derive from
 504         general_symbol_info.
 505         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 506         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 507         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 508         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 509         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 510         (MSYMBOL_SEARCH_NAME): Update.
 511         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 512         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 513         * minsyms.c (minimal_symbol_reader::record_full): Update.
 514
 515 2019-03-15  Tom Tromey  <tom@tromey.com>
 516
 517         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 518
 519 2019-03-15  Tom Tromey  <tom@tromey.com>
 520
 521         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 522         unique_xmalloc_ptr.
 523         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 524         Update.
 525         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 526         (build_minimal_symbol_hash_tables)
 527         (minimal_symbol_reader::install): Update.
 528
 529 2019-03-15  Tom Tromey  <tom@tromey.com>
 530
 531         * symtab.c (create_demangled_names_hash): Update.
 532         (symbol_set_names): Update.
 533         * objfiles.h (struct objfile_per_bfd_storage)
 534         <demangled_names_hash>: Now an htab_up.
 535         * objfiles.c (objfile_per_bfd_storage): Simplify.
 536
 537 2019-03-15  Tom Tromey  <tom@tromey.com>
 538
 539         * objfiles.h (struct objfile_per_bfd_storage): Declare
 540         destructor.
 541         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 542         New.
 543         (get_objfile_bfd_data): Use new.  Don't initialize
 544         language_of_main.
 545         (free_objfile_per_bfd_storage): Remove.
 546         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 547
 548 2019-03-15  Tom Tromey  <tom@tromey.com>
 549
 550         * symfile.c (reread_symbols): Update.
 551         * objfiles.c (objfile::objfile): Update.
 552         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 553         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 554         comment.
 555         (minimal_symbol_reader::install): Update.
 556         (terminate_minimal_symbol_table): Remove.
 557         * jit.c (jit_object_close_impl): Update.
 558
 559 2019-03-15  Tom Tromey  <tom@tromey.com>
 560
 561         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 562         initializations.
 563
 564 2019-03-15  Tom Tromey  <tom@tromey.com>
 565
 566         * objfiles.h (struct objfile_per_bfd_storage)
 567         <demangled_hash_languages>: Now a bitset.
 568         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 569         (lookup_minimal_symbol): Update.
 570
 571 2019-03-15  Tom Tromey  <tom@tromey.com>
 572
 573         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 574         Don't return the symbol.
 575         * coffread.c (record_minimal_symbol): Use record_full.
 576
 577 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 578
 579         The MS-Windows port of ncurses fails to switch to a color pair if
 580         one or both of the colors are the implicit default colors.  This
 581         change records the default colors when TUI is initialized, and
 582         then specifies them explicitly when a color pair uses the default
 583         colors.  This allows color styling in TUI mode on MS-Windows.
 584
 585         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 586         ncurses_norm_attr.
 587         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 588         colors in ncurses_norm_attr.
 589         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 590         "none", replace it with the default color recorded in
 591         ncurses_norm_attr.
 592
 593 2019-03-14  Tom Tromey  <tromey@adacore.com>
 594
 595         * source-cache.h (class source_cache) <get_source_lines>: Return
 596         std::string.
 597         * source-cache.c (source_cache::extract_lines): Handle case where
 598         first_pos==npos.  Return std::string.
 599         (source_cache::get_source_lines): Update.
 600
 601 2019-03-14  Tom Tromey  <tromey@adacore.com>
 602
 603         * NEWS: Add item for "style sources" commands.
 604         * source-cache.c (source_cache::get_source_lines): Check
 605         source_styling.
 606         * cli/cli-style.c (source_styling): New global.
 607         (_initialize_cli_style): Add "style sources" commands.
 608         (show_style_sources): New function.
 609         * cli/cli-style.h (source_styling): Declare.
 610
 611 2019-03-14  Pedro Alves  <palves@redhat.com>
 612             Tom Tromey  <tromey@adacore.com>
 613
 614         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 615         * tui/tui-winsource.c (tui_refill_source_window): New function,
 616         from...
 617         (tui_horizontal_source_scroll): ... here.  Move some logic.
 618         * cli/cli-style.c (set_style_enabled): Notify new observable.
 619         * tui/tui-hooks.c (tui_redisplay_source): New function.
 620         (tui_attach_detach_observers): Attach or detach
 621         tui_redisplay_source.
 622         * observable.h (source_styling_changed): New observable.
 623         * observable.c: Define source_styling_changed observable.
 624
 625 2019-03-13  Tom Tromey  <tromey@adacore.com>
 626
 627         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 628         (i386_gnu_nat_target::store_registers): Update.
 629         * target-debug.h (target_debug_print_std_string): New macro.
 630         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 631         * windows-tdep.c (display_one_tib): Update.
 632         * tui/tui-stack.c (tui_make_status_line): Update.
 633         * top.c (print_inferior_quit_action): Update.
 634         * thread.c (thr_try_catch_cmd): Update.
 635         (add_thread_with_info): Update.
 636         (thread_target_id_str): Update.
 637         (thr_try_catch_cmd): Update.
 638         (thread_command): Update.
 639         (thread_find_command): Update.
 640         * record-btrace.c (record_btrace_target::info_record)
 641         (record_btrace_resume_thread, record_btrace_target::resume)
 642         (record_btrace_cancel_resume, record_btrace_step_thread)
 643         (record_btrace_target::wait, record_btrace_target::wait)
 644         (record_btrace_target::wait, record_btrace_target::stop): Update.
 645         * progspace.c (print_program_space): Update.
 646         * process-stratum-target.c
 647         (process_stratum_target::thread_address_space): Update.
 648         * linux-fork.c (linux_fork_mourn_inferior)
 649         (detach_checkpoint_command, info_checkpoints_command)
 650         (linux_fork_context): Update.
 651         (linux_fork_detach): Update.
 652         (class scoped_switch_fork_info): Update.
 653         (delete_checkpoint_command): Update.
 654         * infrun.c (follow_fork_inferior): Update.
 655         (follow_fork_inferior): Update.
 656         (proceed_after_vfork_done): Update.
 657         (handle_vfork_child_exec_or_exit): Update.
 658         (follow_exec): Update.
 659         (displaced_step_prepare_throw): Update.
 660         (displaced_step_restore): Update.
 661         (start_step_over): Update.
 662         (resume_1): Update.
 663         (clear_proceed_status_thread): Update.
 664         (proceed): Update.
 665         (print_target_wait_results): Update.
 666         (do_target_wait): Update.
 667         (context_switch): Update.
 668         (stop_all_threads): Update.
 669         (restart_threads): Update.
 670         (finish_step_over): Update.
 671         (handle_signal_stop): Update.
 672         (switch_back_to_stepped_thread): Update.
 673         (keep_going_pass_signal): Update.
 674         (print_exited_reason): Update.
 675         (normal_stop): Update.
 676         * inferior.c (inferior_pid_to_str): Change return type.
 677         (print_selected_inferior): Update.
 678         (add_inferior): Update.
 679         (detach_inferior): Update.
 680         * dummy-frame.c (fprint_dummy_frames): Update.
 681         * dcache.c (dcache_info_1): Update.
 682         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 683         (btrace_fetch, btrace_clear): Update.
 684         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 685         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 686         type.
 687         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 688         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 689         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 690         * gdbarch.c, gdbarch.h: Rebuild.
 691         * gdbarch.sh (core_pid_to_str): Change return type.
 692         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 693         return type.
 694         (windows_nat_target::pid_to_str): Change return type.
 695         (windows_delete_thread): Update.
 696         (windows_nat_target::attach): Update.
 697         (windows_nat_target::files_info): Update.
 698         * target-delegates.c: Rebuild.
 699         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 700         return type.
 701         (sol_thread_target::pid_to_str): Change return type.
 702         * remote.c (class remote_target) <pid_to_str>: Change return
 703         type.
 704         (remote_target::pid_to_str): Change return type.
 705         (extended_remote_target::attach, remote_target::remote_stop_ns)
 706         (remote_target::remote_notif_remove_queued_reply)
 707         (remote_target::push_stop_reply, remote_target::disable_btrace):
 708         Update.
 709         (extended_remote_target::attach): Update.
 710         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 711         type.
 712         (gdbsim_target::pid_to_str): Change return type.
 713         * ravenscar-thread.c (struct ravenscar_thread_target)
 714         <pid_to_str>: Change return type.
 715         (ravenscar_thread_target::pid_to_str): Change return type.
 716         * procfs.c (class procfs_target) <pid_to_str>: Change return
 717         type.
 718         (procfs_target::pid_to_str): Change return type.
 719         (procfs_target::attach): Update.
 720         (procfs_target::detach): Update.
 721         (procfs_target::fetch_registers): Update.
 722         (procfs_target::store_registers): Update.
 723         (procfs_target::wait): Update.
 724         (procfs_target::files_info): Update.
 725         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 726         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 727         return type.
 728         (nto_procfs_target::pid_to_str): Change return type.
 729         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 730         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 731         return type.
 732         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 733         (exit_lwp): Update.
 734         (attach_proc_task_lwp_callback, get_detach_signal)
 735         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 736         (linux_nat_target::resume, wait_lwp, stop_callback)
 737         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 738         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 739         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 740         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 741         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 742         type.
 743         (inf_ptrace_target::attach): Update.
 744         (inf_ptrace_target::files_info): Update.
 745         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 746         type.
 747         (go32_nat_target::pid_to_str): Change return type.
 748         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 749         (gnu_nat_target::wait): Update.
 750         (gnu_nat_target::wait): Update.
 751         (gnu_nat_target::resume): Update.
 752         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 753         (fbsd_nat_target::wait): Update.
 754         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 755         type.
 756         (darwin_nat_target::attach): Update.
 757         * corelow.c (class core_target) <pid_to_str>: Change return type.
 758         (core_target::pid_to_str): Change return type.
 759         * target.c (normal_pid_to_str): Change return type.
 760         (default_pid_to_str): Likewise.
 761         (target_pid_to_str): Change return type.
 762         (target_translate_tls_address): Update.
 763         (target_announce_detach): Update.
 764         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 765         return type.
 766         (bsd_uthread_target::pid_to_str): Change return type.
 767         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 768         type.
 769         (bsd_kvm_target::pid_to_str): Change return type.
 770         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 771         return type.
 772         (aix_thread_target::pid_to_str): Change return type.
 773         * target.h (struct target_ops) <pid_to_str>: Change return type.
 774         (target_pid_to_str, normal_pid_to_str): Likewise.
 775         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 776         type.
 777         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 778         type.
 779         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 780         return type.
 781         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 782         type.
 783         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 784         type.
 785         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 786         return type.
 787
 788 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 789
 790         * NEWS: Mention that the new default MI version is 3.  Mention
 791         changes to the output of commands and events that deal with
 792         multi-location breakpoints.
 793         * breakpoint.c: Include "mi/mi-out.h".
 794         (print_one_breakpoint): Change output syntax if using MI version
 795         >= 3.
 796         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 797         New.
 798         (mi_multi_location_breakpoint_output_fixed): New.
 799         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 800         (mi_cmd_fix_multi_location_breakpoint_output): New.
 801         (mi_multi_location_breakpoint_output_fixed): New.
 802         * mi/mi-cmds.c (mi_cmds): Register command
 803         -fix-multi-location-breakpoint-output.
 804         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 805         interpreter "mi".
 806
 807 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 808
 809         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 810         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 811         instantiate mi_ui_out based on interpreter name.
 812         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 813         * mi/mi-main.c (mi_load_progress): Likewise.
 814
 815 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 816
 817         * NEWS: Combine separate "New targets" sections for 8.3.
 818
 819 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 820
 821         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 822         (ppcfbsd_init_abi): Install gdbarch
 823         "fetch_tls_load_module_address" and "get_thread_local_address"
 824         methods.
 825
 826 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 827
 828         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 829         (riscv_fbsd_init_abi): Install gdbarch
 830         "fetch_tls_load_module_address" and "get_thread_local_address"
 831         methods.
 832
 833 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 834
 835         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 836         (i386fbsd_init_abi): Install gdbarch
 837         "fetch_tls_load_module_address" and "get_thread_local_address"
 838         methods.
 839
 840 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 841
 842         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 843         (amd64fbsd_init_abi): Install gdbarch
 844         "fetch_tls_load_module_address" and "get_thread_local_address"
 845         methods.
 846
 847 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 848
 849         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 850         (struct fbsd_pspace_data): New type.
 851         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 852         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 853         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 854         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 855         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 856
 857 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 858
 859         * gdbtypes.c (lookup_struct_elt): New function.
 860         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 861         * gdbtypes.h (struct struct_elt): New type.
 862         (lookup_struct_elt): New prototype.
 863
 864 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 865
 866         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 867         remove disabled code block.
 868
 869 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 870
 871         * gdbarch.sh (get_thread_local_address): New method.
 872         * gdbarch.h, gdbarch.c: Regenerate.
 873         * target.c (target_translate_tls_address): Use
 874         gdbarch_get_thread_local_address if present instead of
 875         target::get_thread_local_address.
 876
 877 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 878
 879         * target.h (target::get_thread_local_address): Update comment.
 880
 881 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 882
 883         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 884         objfile->separate_debug_objfile_backlink if not NULL.
 885
 886 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 887
 888         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 889         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 890         (amd64bsd_store_inferior_registers): Likewise.
 891         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 892         Enable segment base registers.
 893         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 894         PT_GETFSBASE and PT_GETGSBASE.
 895         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 896         PT_SETGSBASE.
 897         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 898         segment base registers.
 899         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 900
 901 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 902
 903         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 904         Update calls to i386_target_description to add 'segments'
 905         parameter.
 906         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 907         add segment base registers.
 908         * arch/i386.c (i386_create_target_description): Add 'segments'
 909         parameter to enable segment base registers.
 910         * arch/i386.h (i386_create_target_description): Likewise.
 911         * features/i386/32bit-segments.xml: New file.
 912         * features/i386/32bit-segments.c: Generate.
 913         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 914         call to i386_target_description to add 'segments' parameter.
 915         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 916         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 917         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 918         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 919         if feature is present.
 920         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 921         Add 'segments' parameter to call to i386_target_description.
 922         (i386_target_description): Add 'segments' parameter to enable
 923         segment base registers.
 924         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 925         to call to i386_target_description.
 926         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 927         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 928         Define I386_NUM_REGS.
 929         (i386_target_description): Add 'segments' parameter to enable
 930         segment base registers.
 931
 932 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 933
 934         PR/24325
 935         * source-cache.c: #undef open and close, to avoid unresolved
 936         externals during linking.
 937
 938 2019-03-12  Tom Tromey  <tromey@adacore.com>
 939
 940         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 941         const.  Add initializers.
 942         (_initialize_remote): Don't initialize ptid globals.
 943
 944 2019-03-12  Pedro Alves  <palves@redhat.com>
 945
 946         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 947
 948 2019-03-12  Pedro Alves  <palves@redhat.com>
 949
 950         * cp-name-parser.y (main): Remove unused 'len' variable.
 951
 952 2019-03-12  Tom Tromey  <tromey@adacore.com>
 953
 954         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 955         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 956
 957 2019-03-12  Tom Tromey  <tromey@adacore.com>
 958
 959         * linux-nat.c (iterate_over_lwps): Update.
 960         (stop_callback): Remove parameter.
 961         (stop_wait_callback, detach_callback, resume_set_callback)
 962         (select_singlestep_lwp_callback, set_ignore_sigint)
 963         (status_callback, resumed_callback, resume_clear_callback)
 964         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 965         data parameter.
 966         (linux_nat_target::detach, linux_nat_target::resume)
 967         (linux_stop_and_wait_all_lwps, select_event_lwp)
 968         (linux_nat_filter_event, linux_nat_wait_1)
 969         (linux_nat_target::kill, linux_nat_target::stop)
 970         (linux_nat_target::stop): Update.
 971         (linux_nat_resume_callback): Change type.
 972         (resume_stopped_resumed_lwps, count_events_callback)
 973         (select_event_lwp_callback): Likewise.
 974         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 975         * arm-linux-nat.c (struct update_registers_data): Remove.
 976         (update_registers_callback): Change type.
 977         (arm_linux_insert_hw_breakpoint1): Update.
 978         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 979         parameter.
 980         (x86_linux_dr_set_addr): Update.
 981         (x86_linux_dr_set_control): Update.
 982         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 983         (iterate_over_lwps): Use gdb::function_view.
 984         * nat/aarch64-linux-hw-point.c (struct
 985         aarch64_dr_update_callback_param): Remove.
 986         (debug_reg_change_callback): Change type.
 987         (aarch64_notify_debug_reg_change): Update.
 988         * s390-linux-nat.c (s390_refresh_per_info): Update.
 989
 990 2019-03-11  Tom Tromey  <tromey@adacore.com>
 991
 992         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 993         redundant assignment to "this_cu".
 994
 995 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 996
 997         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 998
 999 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1000
1001         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1002         from...
1003         (rank_one_type): ... this.
1004
1005 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1006
1007         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1008         from...
1009         (rank_one_type): ... this.
1010
1011 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1012
1013         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1014         from...
1015         (rank_one_type): ... this.
1016
1017 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1018
1019         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1020         from...
1021         (rank_one_type): ... this.
1022
1023 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1024
1025         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1026         from...
1027         (rank_one_type): ... this.
1028
1029 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1030
1031         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1032         from...
1033         (rank_one_type): ... this.
1034
1035 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1036
1037         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1038         from...
1039         (rank_one_type): ... this.
1040
1041 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1042
1043         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1044         from...
1045         (rank_one_type): ... this.
1046
1047 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1048
1049         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1050         from...
1051         (rank_one_type): ... this.
1052
1053 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1054
1055         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1056         from...
1057         (rank_one_type): ... this.
1058
1059 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1060
1061         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1062         from...
1063         (rank_one_type): ... this.
1064
1065 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1066
1067         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1068         from...
1069         (rank_one_type): ... this.
1070
1071 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1072
1073         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1074         inferior-events' shows the example events.
1075
1076 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1077
1078         Support styling on native MS-Windows console
1079
1080         PR/24315
1081         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1082         on MS-Windows if $TERM is not defined.
1083
1084         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1085
1086         * posix-hdep.c (gdb_console_fputs):
1087         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1088         functions.
1089         * ui-file.h (gdb_console_fputs): Add prototype.
1090
1091         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1092         back to fputs only if the former returns zero.
1093
1094 2019-03-07  Tom Tromey  <tom@tromey.com>
1095
1096         * symmisc.c (print_symbol_bcache_statistics): Update.
1097         (print_objfile_statistics): Update.
1098         * symfile.c (allocate_symtab): Update.
1099         * stabsread.c: Don't include bcache.h.
1100         * psymtab.h (struct psymbol_bcache): Don't declare.
1101         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1102         (psymbol_bcache_init, psymbol_bcache_free)
1103         (psymbol_bcache_get_bcache): Don't declare.
1104         * psymtab.c (struct psymbol_bcache): Remove.
1105         (psymtab_storage::psymtab_storage): Update.
1106         (psymtab_storage::~psymtab_storage): Update.
1107         (psymbol_bcache_init, psymbol_bcache_free)
1108         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1109         (add_psymbol_to_bcache): Update.
1110         (allocate_psymtab): Update.
1111         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1112         macro_cache>: No longer pointers.
1113         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1114         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1115         * macrotab.c (macro_bcache): Update.
1116         * macroexp.c: Don't include bcache.h.
1117         * gdbtypes.c (check_types_worklist): Update.
1118         (types_deeply_equal): Remove TRY/CATCH.  Update.
1119         * elfread.c (elf_symtab_read): Update.
1120         * dwarf2read.c: Don't include bcache.h.
1121         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1122         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1123         (print_bcache_statistics, bcache_memory_used): Don't declare.
1124         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1125         methods.  Rename all data members.
1126         * bcache.c (struct bcache): Move to bcache.h.
1127         (bcache::expand_hash_table): Rename from expand_hash_table.
1128         (bcache): Remove.
1129         (bcache::insert): Rename from bcache_full.
1130         (bcache::compare): Rename from bcache_compare.
1131         (bcache_xmalloc): Remove.
1132         (bcache::~bcache): Rename from bcache_xfree.
1133         (bcache::print_statistics): Rename from print_bcache_statistics.
1134         (bcache::memory_used): Rename from bcache_memory_used.
1135
1136 2019-03-07  Pedro Alves  <palves@redhat.com>
1137
1138         * infrun.c (normal_stop): Also check for
1139         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1140
1141 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1142
1143         * f-lang.c (value_from_host_double): Moved to...
1144         * value.c (value_from_host_double): ...here.
1145         * value.h (value_from_host_double): Declare.
1146         * guile/scm-math.c (vlscm_convert_typed_number): Use
1147         value_from_host_double.
1148         (vlscm_convert_number): Likewise.
1149         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1150         * python/py-value.c (convert_value_from_python): Likewise.
1151
1152 2019-03-06  Tom Tromey  <tom@tromey.com>
1153
1154         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1155
1156 2019-03-06  Tom Tromey  <tom@tromey.com>
1157
1158         * utils.h (free_current_contents): Don't declare.
1159         * utils.c (free_current_contents): Remove.
1160
1161 2019-03-06  Tom Tromey  <tom@tromey.com>
1162
1163         * top.c (quit_force): Update.
1164         * main.c (captured_command_loop): Update.
1165         * common/new-op.c (operator new): Update.
1166         * common/common-exceptions.c (struct catcher)
1167         <save_cleanup_chain>: Remove member.
1168         (exceptions_state_mc_init): Update.
1169         (exception_try_scope_entry): Return nullptr.
1170         (exception_try_scope_exit, exception_rethrow)
1171         (throw_exception_sjlj, throw_exception_cxx): Update.
1172         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1173         (all_cleanups, do_cleanups, discard_cleanups)
1174         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1175         (restore_cleanups, restore_final_cleanups): Don't declare.
1176         (do_final_cleanups): Remove parameter.
1177         * common/cleanups.c (cleanup_chain, make_cleanup)
1178         (make_cleanup_dtor, all_cleanups, do_cleanups)
1179         (discard_my_cleanups, discard_cleanups)
1180         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1181         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1182         (null_cleanup): Remove.
1183         (do_final_cleanups): Remove parameter.
1184
1185 2019-03-06  Tom Tromey  <tom@tromey.com>
1186
1187         * remote.c (remote_target::remote_parse_stop_reply): Use
1188         unique_xmalloc_ptr.
1189
1190 2019-03-06  Tom Tromey  <tom@tromey.com>
1191
1192         * stabsread.c (struct stabs_field_info): Rename from field_info.
1193         <list, fnlist>: Add initializers.
1194         <obstack>: New member.
1195         (read_member_functions, read_struct_fields, read_baseclasses):
1196         Allocate on obstack.  Don't use cleanups.
1197         (read_one_struct_field, read_member_functions, read_struct_fields)
1198         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1199         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1200         (read_struct_type): Update.
1201
1202 2019-03-06  Tom Tromey  <tom@tromey.com>
1203
1204         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1205         * common/filestuff.h (make_cleanup_close): Don't declare.
1206         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1207         Remove.
1208
1209 2019-03-06  Tom Tromey  <tom@tromey.com>
1210
1211         * solib-aix.c: Use make_scope_exit.
1212
1213 2019-03-06  Tom Tromey  <tom@tromey.com>
1214
1215         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1216         Use make_scope_exit.
1217
1218 2019-03-06  Tom Tromey  <tom@tromey.com>
1219
1220         * solib-svr4.c (disable_probes_interface): Remove parameter.
1221         (svr4_handle_solib_event): Use make_scope_exit.
1222
1223 2019-03-06  Tom Tromey  <tom@tromey.com>
1224
1225         * remote.c (struct stop_reply_deleter): Remove.
1226         (stop_reply_up): Update.
1227         (struct stop_reply): Derive from notif_event.  Don't typedef.
1228         <regcache>: Now a std::vector.
1229         (stop_reply_xfree): Remove.
1230         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1231         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1232         (remote_target::discard_pending_stop_replies): Use delete.
1233         (remote_target::remote_parse_stop_reply): Update.
1234         (remote_target::process_stop_reply): Update.
1235         * remote-notif.h (struct notif_event): Add virtual destructor.
1236         Remove "dtr" member.
1237         (struct notif_client) <alloc_event>: Return a unique_ptr.
1238         (notif_event_xfree): Don't declare.
1239         (notif_event_up): New typedef.
1240         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1241         (notif_event_xfree, do_notif_event_xfree): Remove.
1242         (remote_notif_state_xfree): Update.
1243
1244 2019-03-06  Tom Tromey  <tom@tromey.com>
1245
1246         * infrun.c (displaced_step_clear_cleanup): Now a
1247         forward_scope_exit type.
1248         (displaced_step_prepare_throw): Update.
1249         (displaced_step_fixup): Update.
1250
1251 2019-03-06  Tom Tromey  <tom@tromey.com>
1252
1253         * inferior.h (class inferior): Update comment.
1254         * gdbthread.h (class thread_info): Update comment.
1255
1256 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1257             Tom Tromey  <tom@tromey.com>
1258
1259         * stabsread.h (struct stab_section_list): Remove.
1260         (coffstab_build_psymtabs): Update.
1261         * dbxread.c (symbuf_sections): Now a std::vector.
1262         (sect_idx): New global.
1263         (fill_symbuf): Update.
1264         (coffstab_build_psymtabs): Change type of stabsects parameter.
1265         Update.
1266         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1267         std::vector.
1268         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1269         (coff_locate_sections): Update.
1270         (coff_symfile_read): Remove cleanups.  Update.
1271         (init_stringtab): Add storage parameter.
1272         (free_stringtab, free_stringtab_cleanup): Remove.
1273         (init_lineno): Add storage parameter.
1274         (free_linetab, free_linetab_cleanup): Remove.
1275
1276 2019-03-06  Pedro Alves  <palves@redhat.com>
1277
1278         * linux-fork.c (fork_info::clobber_regs): Delete.
1279         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1280         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1281         comment.  Adjust.
1282         (scoped_switch_fork_info::scoped_switch_fork_info)
1283         (checkpoint_command, linux_fork_context): Adjust
1284         fork_save_infrun_state calls.
1285
1286 2019-03-06  Pedro Alves  <palves@redhat.com>
1287
1288         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1289         (inf_has_multiple_threads): Return 'bool' and rewrite using
1290         inferior_info::threads().
1291
1292 2019-03-06  Pedro Alves  <palves@redhat.com>
1293
1294         * linux-fork.c: Include <list>.
1295         (fork_list): Now a std::list instance.
1296         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1297         (forks_exist_p, find_last_fork): Adjust.
1298         (new_fork): Delete.
1299         (one_fork_p): New.
1300         (add_fork): Adjust.
1301         (free_fork): Delete, folded into fork_info::~fork_info().
1302         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1303         Adjust.
1304         (init_fork_list): Delete.
1305         (linux_fork_killall, linux_fork_mourn_inferior)
1306         (linux_fork_detach, info_checkpoints_command): Adjust.
1307         (_initialize_linux_fork): No longer call init_fork_list.
1308
1309 2019-03-06  Pedro Alves  <palves@redhat.com>
1310
1311         * linux-fork.c (new_fork): New, split out of ...
1312         (add_fork): ... this.  Return void.  Move "first fork" special
1313         case from here, to ...
1314         (checkpoint_command): ... here.
1315         * linux-linux.h (add_fork): Return void.
1316
1317 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1318
1319         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1320
1321 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1322             Chris January  <chris.january@arm.com>
1323             David Lecomber  <david.lecomber@arm.com>
1324
1325         * f-exp.y: New token, UNOP_INTRINSIC.
1326         (exp): New pattern using UNOP_INTRINSIC token.
1327         (f77_keywords): Add 'abs' keyword.
1328         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1329         (value_from_host_double): New function.
1330         (evaluate_subexp_f): Support UNOP_ABS.
1331
1332 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1333
1334         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1335         types.
1336
1337 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1338
1339         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1340         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1341         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1342
1343 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1344
1345         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1346
1347 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1348             Chris January  <chris.january@arm.com>
1349
1350         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1351         * f-exp.y: Define 'KIND' token.
1352         (exp): New pattern for KIND expressions.
1353         (ptype): Handle types with a kind extension.
1354         (direct_abs_decl): Extend to spot kind extensions.
1355         (f77_keywords): Add 'kind' to the list.
1356         (push_kind_type): New function.
1357         (convert_to_kind_type): New function.
1358         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1359         * parse.c (operator_length_standard): Likewise.
1360         * parser-defs.h (enum type_pieces): Add tp_kind.
1361         * std-operator.def: Add UNOP_KIND.
1362
1363 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1364
1365         * f-exp.y (f_parse): Set yydebug.
1366
1367 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1368
1369         * f-lang.c (evaluate_subexp_f): New function.
1370         (exp_descriptor_f): New global.
1371         (f_language_defn): Use exp_descriptor_f instead of
1372         exp_descriptor_standard.
1373
1374 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1375
1376         * f-exp.y (struct token): Add comments.
1377         (dot_ops): Remove uppercase versions and the end marker.
1378         (f77_keywords): Likewise.
1379         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1380         entries in the dot_ops array are case insensitive, and use
1381         strncasecmp to compare strings.  Also some whitespace cleanup in
1382         this area.  Similar for the f77_keywords array, except entries in
1383         this list might be case sensitive.
1384
1385 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * f-exp.y (struct f77_boolean_val): Add comments.
1388         (boolean_values): Remove uppercase versions, and end marker.
1389         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1390         and use strncasecmp to achieve case insensitivity.  Additionally,
1391         perform whitespace cleanup around this code.
1392
1393 2019-03-06  Tom Tromey  <tromey@adacore.com>
1394
1395         * remote-sim.c (gdbsim_target_open): Use result of
1396         gdb_argv::release.
1397
1398 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1399         Dirk Schubert  <dirk.schubert@arm.com>
1400         Chris January  <chris.january@arm.com>
1401
1402         * eval.c (evaluate_subexp_standard): Call Fortran argument
1403         wrapping logic.
1404         * f-lang.c (struct value): A value which can be passed into a
1405         Fortran function call.
1406         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1407         where appropriate.
1408         (struct type): Value ready for a Fortran function call.
1409         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1410         is needed.
1411         * f-lang.h (fortran_argument_convert): Declaration.
1412         (fortran_preserve_arg_pointer): Declaration.
1413         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1414
1415 2019-03-05  Tom Tromey  <tromey@adacore.com>
1416
1417         * python/py-prettyprint.c (print_string_repr): Remove #if.
1418         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1419
1420 2019-03-05  Tom Tromey  <tromey@adacore.com>
1421
1422         * target.c (the_dummy_target): Move later.  Change type to
1423         "dummy_target".
1424         (initialize_targets): Don't initialize the_dummy_target.
1425
1426 2019-03-05  Tom Tromey  <tromey@adacore.com>
1427
1428         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1429         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1430
1431 2019-03-05  Tom Tromey  <tromey@adacore.com>
1432
1433         * windows-nat.c (windows_nat_target::attach)
1434         (windows_nat_target::detach): Don't call gdb_flush.
1435         * valprint.c (generic_val_print, val_print, val_print_string):
1436         Don't call gdb_flush.
1437         * utils.c (defaulted_query): Don't call gdb_flush.
1438         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1439         * target.c (target_announce_detach): Don't call gdb_flush.
1440         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1441         * remote.c (extended_remote_target::attach): Don't call
1442         gdb_flush.
1443         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1444         * printcmd.c (do_examine): Don't call gdb_flush.
1445         (info_display_command): Don't call gdb_flush.
1446         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1447         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1448         * memattr.c (info_mem_command): Don't call gdb_flush.
1449         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1450         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1451         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1452         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1453         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1454         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1455         (gnu_nat_target::detach): Don't call gdb_flush.
1456         * f-valprint.c (f_val_print): Don't call gdb_flush.
1457         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1458         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1459         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1460         gdb_flush.
1461         * c-valprint.c (c_val_print): Don't call gdb_flush.
1462         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1463
1464 2019-03-05  Tom Tromey  <tromey@adacore.com>
1465
1466         * varobj.c (update_dynamic_varobj_children): Update.
1467         (install_default_visualizer): Use reset, not release.
1468         * value.c (set_internalvar): Update.
1469         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1470         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1471         ATTRIBUTE_UNUSED_RESULT.
1472
1473 2019-03-05  Tom Tromey  <tromey@adacore.com>
1474
1475         * remote.c (class scoped_remote_fd) <release>: Add
1476         ATTRIBUTE_UNUSED_RESULT.
1477
1478 2019-03-05  Tom Tromey  <tromey@adacore.com>
1479
1480         * macroexp.c (struct macro_buffer) <release>: Add
1481         ATTRIBUTE_UNUSED_RESULT.
1482
1483 2019-03-05  Tom Tromey  <tromey@adacore.com>
1484
1485         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1486         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1487         ATTRIBUTE_UNUSED_RESULT.
1488
1489 2019-03-05  Tom Tromey  <tromey@adacore.com>
1490
1491         * common/scoped_fd.h (class scoped_fd) <release>: Add
1492         ATTRIBUTE_UNUSED_RESULT.
1493
1494 2019-03-05  Tom Tromey  <tromey@adacore.com>
1495
1496         * parser-defs.h (struct parser_state) <release>: Add
1497         ATTRIBUTE_UNUSED_RESULT.
1498
1499 2019-03-05  Tom Tromey  <tromey@adacore.com>
1500
1501         * utils.h (class gdb_argv) <release>: Add
1502         ATTRIBUTE_UNUSED_RESULT.
1503         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1504
1505 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1506
1507         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1508         for-loop range, to avoid compiler warnings.
1509
1510         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1511         avoid compiler warnings about unused variables.
1512
1513         * NEWS: Mention end of support for native debugging on MS-Windows
1514         before XP.
1515
1516         PR gdb/24292
1517         * common/netstuff.c:
1518         * gdbserver/gdbreplay.c
1519         * gdbserver/remote-utils.c:
1520         * ser-tcp.c:
1521         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1522         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1523         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1524         'getaddrinfo' and 'freeaddrinfo' were not available before
1525         Windows XP, and mingw.org's MinGW headers by default define
1526         _WIN32_WINNT to 0x500.
1527
1528 2019-03-01  Gary Benson <gbenson@redhat.com>
1529
1530         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1531
1532 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1533             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1534
1535         PR gdb/8527
1536         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1537         set_sigint_trap, clear_sigint_trap.
1538
1539 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1540
1541         * target.c (target_detach): Clear the regcache and the
1542         frame cache.
1543
1544 2019-02-27  Pedro Alves  <palves@redhat.com>
1545
1546         * utils.c (set_screen_size): When we cap the height/width sizes,
1547         tweak the corresponding command variable to show "unlimited":
1548
1549 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1550             Pedro Alves  <palves@redhat.com>
1551
1552         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1553         before calling rl_set_screen_size.
1554
1555 2019-02-27  Tom Tromey  <tromey@adacore.com>
1556
1557         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1558         define.
1559         * python/py-value.c: Remove Python 2.4 workaround.
1560         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1561         workaround.
1562         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1563         Python 2.4 workaround.
1564         * python/python-internal.h: Remove Python 2.4 comment.
1565         (Py_ssize_t): Don't define.
1566         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1567         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1568         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1569         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1570         * python/python.c (do_start_initialization): Remove Python 2.4
1571         workaround.
1572         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1573         (print_children): Remove Python 2.4 workaround.
1574         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1575         workaround.
1576         (CHARBUFFERPROC_NAME): Remove.
1577         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1578         Python 2.4 workaround.
1579
1580 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1581
1582         * NEWS: Note minimum Python version.
1583
1584 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1585
1586         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1587         code from these functions.  Remove corresponding ifdefs.  Use
1588         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1589         Remove gotos and target of gotos.
1590         (infpy_search_memory): Likewise.
1591
1592 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1593
1594         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1595         (hppa_gdbarch_init): Don't register deleted functions with
1596         gdbarch.
1597
1598 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1599
1600         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1601         (h8300_unwind_sp): Delete.
1602         (h8300_dummy_id): Delete.
1603         (h8300_gdbarch_init): Don't register deleted functions with
1604         gdbarch.
1605
1606 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1607
1608         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1609         (ft32_unwind_pc): Delete.
1610         (ft32_unwind_sp): Delete.
1611         (ft32_gdbarch_init): Don't register deleted functions with
1612         gdbarch.
1613
1614 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1615
1616         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1617         (frv_unwind_pc): Delete.
1618         (frv_unwind_sp): Delete.
1619         (frv_gdbarch_init): Don't register deleted functions with
1620         gdbarch.
1621
1622 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1623
1624         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1625         (riscv_unwind_pc): Delete.
1626         (riscv_unwind_sp): Delete.
1627         (riscv_gdbarch_init): Don't register deleted functions with
1628         gdbarch.
1629
1630 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1631
1632         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1633         (csky_unwind_pc): Delete.
1634         (csky_unwind_sp): Delete.
1635         (csky_gdbarch_init): Don't register deleted functions with
1636         gdbarch.
1637
1638 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1639
1640         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1641         (cris_unwind_pc): Delete.
1642         (cris_unwind_sp): Delete.
1643         (cris_gdbarch_init): Don't register deleted functions with
1644         gdbarch.
1645
1646 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1647
1648         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1649         (bfin_unwind_pc): Delete.
1650         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1651
1652 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1653
1654         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1655         (arm_unwind_pc): Delete.
1656         (arm_unwind_sp): Delete.
1657         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1658
1659 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1660
1661         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1662         (arc_unwind_pc): Delete.
1663         (arc_unwind_sp): Delete.
1664         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1665
1666 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1667
1668         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1669         (alpha_unwind_pc): Delete.
1670         (alpha_gdbarch_init): Don't register deleted functions with
1671         gdbarch.
1672
1673 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1674
1675         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1676         (aarch64_unwind_pc): Delete.
1677         (aarch64_unwind_sp): Delete.
1678         (aarch64_gdbarch_init): Don't register deleted functions with
1679         gdbarch.
1680
1681 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1682
1683         * gdbtypes.c (type_align): Don't consider static members when
1684         computing structure alignment.
1685
1686 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1687
1688         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1689         return 0 for other types.
1690         * arch-utils.c (default_type_align): Always return 0.
1691         * gdbarch.h: Regenerate.
1692         * gdbarch.sh (type_align): Extend comment.
1693         * gdbtypes.c (type_align): Add additional comments, always call
1694         gdbarch_type_align before applying the default rules.
1695         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1696         generic code will then apply a suitable default.
1697         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1698         types, return 0 for other types.
1699
1700 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1701
1702         * NEWS: Create a new section for the next release branch.
1703         Rename the section of the current branch, now that it has
1704         been cut.
1705
1706 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1707
1708         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1709         * version.in: Bump version to 8.3.50.DATE-git.
1710
1711 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1712
1713         * aix-thread.c (ptid_cmp): Remove unused variable.
1714         (get_signaled_thread): Likewise.
1715         (store_regs_user_thread): Likewise.
1716         (store_regs_kernel_thread): Likewise.
1717         (fetch_regs_kernel_thread): Remove shadowed variable.
1718
1719 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1720
1721         * features/riscv/32bit-cpu.xml: Add register numbers.
1722         * features/riscv/32bit-fpu.c: Regenerate.
1723         * features/riscv/32bit-fpu.xml: Add register numbers.
1724         * features/riscv/64bit-cpu.xml: Add register numbers.
1725         * features/riscv/64bit-fpu.c: Regenerate.
1726         * features/riscv/64bit-fpu.xml: Add register numbers.
1727
1728 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1729
1730         * NEWS: Mention two argument form of gdb.Value constructor.
1731         * python/py-value.c (convert_buffer_and_type_to_value): New
1732         function.
1733         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1734         Add support for handling an optional second argument.  Call
1735         convert_buffer_and_type_to_value as appropriate.
1736         * python/python-internal.h (Py_buffer_deleter): New struct.
1737         (Py_buffer_up): New typedef.
1738
1739 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1740
1741         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1742         instead of releasing ownership.
1743
1744 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1745
1746         * dwarf2read.c (open_and_init_dwp_file): Call
1747         elf_numsections instead of bfd_count_sections to initialize
1748         dwp_file->num_sections.
1749
1750 2019-02-25  Tom Tromey  <tromey@adacore.com>
1751
1752         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1753
1754 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1755
1756         * gcore.in: Add '--readnever' option when invoking GDB.
1757
1758 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1759
1760         * MAINTAINERS: Update my email address.
1761
1762 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1763
1764         * build-id.c (build_id_to_debug_bfd_1): New function.
1765         (build_id_to_debug_bfd): Look for separate debug file in
1766         sysroot.
1767
1768 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1769
1770         * gdbarch.sh: Update the copyright year range that is placed into
1771         generated files.
1772
1773 2019-02-22  Keith Seitz  <keiths@redhat.com>
1774
1775         PR symtab/23853
1776         * linespec.c (create_sals_line_offset): Search for the default
1777         symtab's filename instead of its fullname.
1778
1779 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1780
1781         * NEWS: Update style defaults.
1782
1783 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1784
1785         * main.c (captured_main_1): Disable styling in batch mode.
1786
1787 2019-02-20  Tom Tromey  <tom@tromey.com>
1788
1789         * symtab.c (symtab_symbol_info): Fix typos.
1790
1791 2019-02-20  Tom Tromey  <tromey@adacore.com>
1792
1793         * findcmd.c (_initialize_mem_search): Use upper case for
1794         metasyntactic variables.
1795
1796 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1797
1798         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1799         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1800
1801 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1802
1803         * top.h (source_file_name): Change to std::string.
1804         * top.c (source_file_name): Likewise.
1805         (command_line_input): Adjust.
1806         * cli/cli-script.c (script_from_file): Adjust.
1807
1808 2019-02-19  Tom Tromey  <tromey@adacore.com>
1809
1810         * ravenscar-thread.c
1811         (ravenscar_thread_target::update_thread_list): Don't call
1812         ada_build_task_list.
1813         * ada-lang.h (ada_build_task_list): Don't declare.
1814         * ada-tasks.c (struct ada_tasks_inferior_data)
1815         <task_list_valid_p>: Now bool.
1816         (read_known_tasks, ada_task_list_changed)
1817         (ada_tasks_invalidate_inferior_data): Update.
1818         (read_known_tasks_array): Return bool.
1819         (read_known_tasks_list): Likewise.
1820         (read_known_tasks): Return void.
1821         (ada_build_task_list): Now static.
1822
1823 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1824
1825         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1826         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1827
1828 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1829
1830         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1831         variant for ada_tasks_pspace_data_handle and
1832         ada_tasks_inferior_data_handle.
1833         (ada_tasks_pspace_data_cleanup): New function.
1834         (ada_tasks_inferior_data_cleanup): New function.
1835
1836 2019-02-17  Tom Tromey  <tom@tromey.com>
1837
1838         * macrotab.h (macro_source_fullname): Return a std::string.
1839         * macrotab.c (macro_include, check_for_redefinition)
1840         (macro_undef, macro_lookup_definition, foreach_macro)
1841         (foreach_macro_in_scope): Update.
1842         (macro_source_fullname): Return a std::string.
1843         * macrocmd.c (show_pp_source_pos): Update.
1844
1845 2019-02-17  Tom Tromey  <tom@tromey.com>
1846
1847         * macrocmd.c (show_pp_source_pos): Style the file names.
1848
1849 2019-02-17  Tom Tromey  <tom@tromey.com>
1850
1851         PR tui/24197:
1852         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1853
1854 2019-02-17  Tom Tromey  <tom@tromey.com>
1855
1856         * ada-lang.c (user_select_syms): Use filtered printing.
1857         * utils.c (wrap_style): New global.
1858         (desired_style): Remove.
1859         (emit_style_escape): Add stream parameter.
1860         (set_output_style, reset_terminal_style, prompt_for_continue):
1861         Update.
1862         (flush_wrap_buffer): Only flush gdb_stdout.
1863         (wrap_here): Set wrap_style.
1864         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1865         treat escape sequences as a character.  Change when wrap buffer is
1866         flushed.
1867         (fputs_styled): Do not set the output style when the default is
1868         requested.
1869         * ui-style.h (struct ui_file_style) <is_default>: New method.
1870         * source.c (print_source_lines_base): Emit escape sequences in one
1871         piece.
1872
1873 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1874
1875         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1876         integers and enumeration types.
1877
1878 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1879
1880         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1881         instead of lookup_symbol_in_language
1882         (do_exact_match): New function.
1883         (ada_get_symbol_name_matcher): Return do_exact_match when
1884         doing a verbatim match.
1885
1886 2019-02-15  Tom Tromey  <tromey@adacore.com>
1887
1888         * ravenscar-thread.c (ravenscar_thread_target::resume)
1889         (ravenscar_thread_target::wait): Special case wildcard requests.
1890
1891 2019-02-15  Tom Tromey  <tromey@adacore.com>
1892
1893         * ravenscar-thread.c (base_ptid): Remove.
1894         (struct ravenscar_thread_target) <close>: New method.
1895         <m_base_ptid>: New member.
1896         <update_inferior_ptid, active_task, task_is_currently_active,
1897         runtime_initialized>: Declare methods.
1898         <ravenscar_thread_target>: Add constructor.
1899         (ravenscar_thread_target::task_is_currently_active)
1900         (ravenscar_thread_target::update_inferior_ptid)
1901         (ravenscar_runtime_initialized): Rename.  Now methods.
1902         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1903         (ravenscar_thread_target::update_thread_list): Update.
1904         (ravenscar_thread_target::active_task): Now method.
1905         (ravenscar_thread_target::store_registers)
1906         (ravenscar_thread_target::prepare_to_store)
1907         (ravenscar_thread_target::prepare_to_store)
1908         (ravenscar_thread_target::mourn_inferior): Update.
1909         (ravenscar_inferior_created): Use "new" to create target.
1910         (ravenscar_thread_target::get_ada_task_ptid): Update.
1911         (_initialize_ravenscar): Don't initialize base_ptid.
1912         (ravenscar_ops): Remove global.
1913
1914 2019-02-15  Tom Tromey  <tromey@adacore.com>
1915
1916         * target.h (push_target): Declare new overload.
1917         * target.c (push_target): New overload, taking an rvalue reference.
1918         * remote.c (remote_target::open_1): Use push_target overload.
1919         * corelow.c (core_target_open): Use push_target overload.
1920
1921 2019-02-15  Tom Tromey  <tromey@adacore.com>
1922
1923         * ravenscar-thread.c (is_ravenscar_task)
1924         (ravenscar_task_is_currently_active): Return bool.
1925         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1926         (_initialize_ravenscar): Remove "(void)".
1927         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1928         Return bool.
1929
1930 2019-02-15  Tom Tromey  <tromey@adacore.com>
1931
1932         * ravenscar-thread.c (ravenscar_runtime_initializer)
1933         (has_ravenscar_runtime, get_running_thread_id)
1934         (ravenscar_thread_target::resume): Fix indentation.
1935
1936 2019-02-15  Tom Tromey  <tromey@adacore.com>
1937
1938         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1939         from ravenscar_arch_ops.
1940         (sparc_ravenscar_ops::fetch_registers)
1941         (sparc_ravenscar_ops::store_registers): Now methods.
1942         (sparc_ravenscar_prepare_to_store): Remove.
1943         (sparc_ravenscar_ops): Redefine.
1944         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1945         methods and destructor.  Remove members.
1946         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1947         (ravenscar_thread_target::store_registers)
1948         (ravenscar_thread_target::prepare_to_store): Update.
1949         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1950         Remove.
1951         (struct ppc_ravenscar_powerpc_ops): Derive from
1952         ravenscar_arch_ops.
1953         (ppc_ravenscar_powerpc_ops::fetch_registers)
1954         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1955         (ppc_ravenscar_powerpc_ops): Redefine.
1956         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1957         (ppc_ravenscar_e500_ops::fetch_registers)
1958         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1959         (ppc_ravenscar_e500_ops): Redefine.
1960         * aarch64-ravenscar-thread.c
1961         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1962         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1963         (aarch64_ravenscar_fetch_registers)
1964         (aarch64_ravenscar_store_registers): Now methods.
1965         (aarch64_ravenscar_ops): Redefine.
1966
1967 2019-02-15  Tom Tromey  <tromey@adacore.com>
1968
1969         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1970         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1971         (ravenscar_thread_target::stopped_by_watchpoint)
1972         (ravenscar_thread_target::stopped_data_address)
1973         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1974
1975 2019-02-15  Tom Tromey  <tromey@adacore.com>
1976
1977         * ravenscar-thread.c: Fix some typos.
1978
1979 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1980             Tom Tromey  <tromey@adacore.com>
1981
1982         * ada-lang.c (ada_exception_sal): Change addr_string to a
1983         std::string.
1984         (create_ada_exception_catchpoint): Update.
1985
1986 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1987             Tom Tromey  <tromey@adacore.com>
1988
1989         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1990         (bp_location_ops): Remove.
1991         (base_breakpoint_allocate_location): Update.
1992         (free_bp_location): Update.
1993         * ada-lang.c (class ada_catchpoint_location)
1994         <ada_catchpoint_location>: Remove ops parameter.
1995         (ada_catchpoint_location_dtor): Remove.
1996         (ada_catchpoint_location_ops): Remove.
1997         (allocate_location_exception): Update.
1998         * breakpoint.h (struct bp_location_ops): Remove.
1999         (class bp_location) <bp_location>: Remove bp_location_ops
2000         parameter.
2001         <~bp_location>: Add destructor.
2002         <ops>: Remove.
2003
2004 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2005             Pedro Alves  <palves@redhat.com>
2006
2007         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2008         'PATH_MAX'.
2009
2010 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2011             Samuel Thibault  <samuel.thibault@gnu.org>
2012             Thomas Schwinge  <thomas@codesourcery.com>
2013
2014         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2015         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2016
2017 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2018
2019         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2020         (check_empty): Use "const char *".
2021
2022         * gnu-nat.c (gnu_nat_target::detach): Instead of
2023         'detach_inferior (pid)' call
2024         'detach_inferior (find_inferior_pid (pid))'.
2025
2026         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2027         'nat/fork-inferior.o'.
2028         * gnu-nat.c: #include "nat/fork-inferior.h".
2029
2030         * gnu-nat.c (gnu_nat_target::detach): Instead of
2031         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2032         * gnu-nat.h: #include "inf-child.h".
2033         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2034         'i386_gnu_nat_target::fetch_registers'.
2035         (gnu_store_registers): Rename/move to
2036         'i386_gnu_nat_target::store_registers'.
2037
2038         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2039         * gnu-nat.h (mach_thread_info): New function.
2040         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2041
2042         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2043
2044 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2045
2046         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2047
2048 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2049
2050         * windows-nat.c (windows_add_thread): Add new parameter
2051         "main_thread_p" with default value set to false.  Update
2052         function documentation as well as all callers.
2053         (windows_delete_thread): Likewise.
2054         (fake_create_process): Update call to windows_add_thread.
2055         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2056         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2057         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2058         call to windows_delete_thread.
2059
2060 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2061
2062         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2063
2064 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2065
2066         * symfile.c (find_separate_debug_file): Use canonical path of
2067         sysroot with child_path instead of gdb_sysroot if it is valid.
2068
2069 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2070
2071         * symfile.c (find_separate_debug_file): Use child_path to
2072         determine if an object file is under a sysroot.
2073
2074 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2075
2076         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2077         unittests/child-path-selftests.c.
2078         * common/pathstuff.c (child_path): New function.
2079         * common/pathstuff.h (child_path): New prototype.
2080         * unittests/child-path-selftests.c: New file.
2081
2082 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2083
2084         * symfile.c (find_separate_debug_file): Look for separate debug
2085         files in debug directories under the sysroot.
2086
2087 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2088
2089         * symtab.h (struct minimal_symbol data_p): New const method.
2090         (struct minimal_symbol text_p): Likewise.
2091         * symtab.c (output_source_filename): Use file name style
2092         to print file name.
2093         (print_symbol_info): Likewise.
2094         (print_msymbol_info): Use address style to print addresses.
2095         Use function name style to print executable text symbols.
2096         (expand_symtab_containing_pc): Use data_p.
2097         (find_pc_sect_compunit_symtab): Likewise.
2098
2099 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2100
2101         * breakpoint.c (describe_other_breakpoints): Use address style
2102         to print addresses.
2103         (say_where): Likewise.
2104
2105 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2106
2107         * ada-typeprint.c (print_func_type): Print function name
2108         style to print function name.
2109         * c-typeprint.c (c_print_type_1): Likewise.
2110
2111 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2112
2113         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2114         for execve.
2115
2116 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2117
2118         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2119         type_stack.
2120
2121 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2122
2123         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2124         TYPE_CODE_REF types.
2125
2126 2019-02-08  Jim Wilson  <jimw@sifive.com>
2127
2128         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2129         (riscv_linux_fregset): New.
2130         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2131
2132 2019-02-07  Tom Tromey  <tom@tromey.com>
2133
2134         * thread.c (thread_cancel_execution_command): Update.
2135         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2136         methods.
2137         (struct thread_fsm_ops): Remove.
2138         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2139         (thread_fsm_should_stop, thread_fsm_return_value)
2140         (thread_fsm_set_finished, thread_fsm_finished_p)
2141         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2142         Don't declare.
2143         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2144         * infrun.c (clear_proceed_status_thread)
2145         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2146         (print_stop_event): Update.
2147         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2148         Add constructor.
2149         (step_command_fsm_ops): Remove.
2150         (new_step_command_fsm): Remove.
2151         (step_1): Update.
2152         (step_command_fsm::should_stop): Rename from
2153         step_command_fsm_should_stop.
2154         (step_command_fsm::clean_up): Rename from
2155         step_command_fsm_clean_up.
2156         (step_command_fsm::do_async_reply_reason): Rename from
2157         step_command_fsm_async_reply_reason.
2158         (struct until_next_fsm): Inherit from thread_fsm.  Add
2159         constructor.
2160         (until_next_fsm_ops): Remove.
2161         (new_until_next_fsm): Remove.
2162         (until_next_fsm::should_stop): Rename from
2163         until_next_fsm_should_stop.
2164         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2165         (until_next_fsm::do_async_reply_reason): Rename from
2166         until_next_fsm_async_reply_reason.
2167         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2168         constructor.  Change type of breakpoint.
2169         (finish_command_fsm_ops): Remove.
2170         (new_finish_command_fsm): Remove.
2171         (finish_command_fsm::should_stop): Rename from
2172         finish_command_fsm_should_stop.
2173         (finish_command_fsm::clean_up): Rename from
2174         finish_command_fsm_clean_up.
2175         (finish_command_fsm::return_value): Rename from
2176         finish_command_fsm_return_value.
2177         (finish_command_fsm::do_async_reply_reason): Rename from
2178         finish_command_fsm_async_reply_reason.
2179         (finish_command): Update.
2180         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2181         Add constructor.
2182         (call_thread_fsm_ops): Remove.
2183         (call_thread_fsm::call_thread_fsm): Rename from
2184         new_call_thread_fsm.
2185         (call_thread_fsm::should_stop): Rename from
2186         call_thread_fsm_should_stop.
2187         (call_thread_fsm::should_notify_stop): Rename from
2188         call_thread_fsm_should_notify_stop.
2189         (run_inferior_call, call_function_by_hand_dummy): Update.
2190         * cli/cli-interp.c (should_print_stop_to_console): Update.
2191         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2192         Add constructor.  Change type of location_breakpoint,
2193         caller_breakpoint.
2194         (until_break_fsm_ops): Remove.
2195         (new_until_break_fsm): Remove.
2196         (until_break_fsm::should_stop): Rename from
2197         until_break_fsm_should_stop.
2198         (until_break_fsm::clean_up): Rename from
2199         until_break_fsm_clean_up.
2200         (until_break_fsm::do_async_reply_reason): Rename from
2201         until_break_fsm_async_reply_reason.
2202         (until_break_command): Update.
2203         * thread-fsm.c: Remove.
2204         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2205
2206 2019-02-07  Tom Tromey  <tom@tromey.com>
2207
2208         * yy-remap.h: Add include guard.
2209         * xtensa-tdep.h: Add include guard.
2210         * xcoffread.h: Rename include guard.
2211         * varobj-iter.h: Add include guard.
2212         * tui/tui.h: Rename include guard.
2213         * tui/tui-winsource.h: Rename include guard.
2214         * tui/tui-wingeneral.h: Rename include guard.
2215         * tui/tui-windata.h: Rename include guard.
2216         * tui/tui-win.h: Rename include guard.
2217         * tui/tui-stack.h: Rename include guard.
2218         * tui/tui-source.h: Rename include guard.
2219         * tui/tui-regs.h: Rename include guard.
2220         * tui/tui-out.h: Rename include guard.
2221         * tui/tui-layout.h: Rename include guard.
2222         * tui/tui-io.h: Rename include guard.
2223         * tui/tui-hooks.h: Rename include guard.
2224         * tui/tui-file.h: Rename include guard.
2225         * tui/tui-disasm.h: Rename include guard.
2226         * tui/tui-data.h: Rename include guard.
2227         * tui/tui-command.h: Rename include guard.
2228         * tic6x-tdep.h: Add include guard.
2229         * target/waitstatus.h: Rename include guard.
2230         * target/wait.h: Rename include guard.
2231         * target/target.h: Rename include guard.
2232         * target/resume.h: Rename include guard.
2233         * target-float.h: Rename include guard.
2234         * stabsread.h: Add include guard.
2235         * rs6000-tdep.h: Add include guard.
2236         * riscv-fbsd-tdep.h: Add include guard.
2237         * regformats/regdef.h: Rename include guard.
2238         * record.h: Rename include guard.
2239         * python/python.h: Rename include guard.
2240         * python/python-internal.h: Rename include guard.
2241         * python/py-stopevent.h: Rename include guard.
2242         * python/py-ref.h: Rename include guard.
2243         * python/py-record.h: Rename include guard.
2244         * python/py-record-full.h: Rename include guard.
2245         * python/py-record-btrace.h: Rename include guard.
2246         * python/py-instruction.h: Rename include guard.
2247         * python/py-events.h: Rename include guard.
2248         * python/py-event.h: Rename include guard.
2249         * procfs.h: Add include guard.
2250         * proc-utils.h: Add include guard.
2251         * p-lang.h: Add include guard.
2252         * or1k-tdep.h: Rename include guard.
2253         * observable.h: Rename include guard.
2254         * nto-tdep.h: Rename include guard.
2255         * nat/x86-linux.h: Rename include guard.
2256         * nat/x86-linux-dregs.h: Rename include guard.
2257         * nat/x86-gcc-cpuid.h: Add include guard.
2258         * nat/x86-dregs.h: Rename include guard.
2259         * nat/x86-cpuid.h: Rename include guard.
2260         * nat/ppc-linux.h: Rename include guard.
2261         * nat/mips-linux-watch.h: Rename include guard.
2262         * nat/linux-waitpid.h: Rename include guard.
2263         * nat/linux-ptrace.h: Rename include guard.
2264         * nat/linux-procfs.h: Rename include guard.
2265         * nat/linux-osdata.h: Rename include guard.
2266         * nat/linux-nat.h: Rename include guard.
2267         * nat/linux-namespaces.h: Rename include guard.
2268         * nat/linux-btrace.h: Rename include guard.
2269         * nat/glibc_thread_db.h: Rename include guard.
2270         * nat/gdb_thread_db.h: Rename include guard.
2271         * nat/gdb_ptrace.h: Rename include guard.
2272         * nat/fork-inferior.h: Rename include guard.
2273         * nat/amd64-linux-siginfo.h: Rename include guard.
2274         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2275         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2276         * nat/aarch64-linux.h: Rename include guard.
2277         * nat/aarch64-linux-hw-point.h: Rename include guard.
2278         * mn10300-tdep.h: Add include guard.
2279         * mips-linux-tdep.h: Add include guard.
2280         * mi/mi-parse.h: Rename include guard.
2281         * mi/mi-out.h: Rename include guard.
2282         * mi/mi-main.h: Rename include guard.
2283         * mi/mi-interp.h: Rename include guard.
2284         * mi/mi-getopt.h: Rename include guard.
2285         * mi/mi-console.h: Rename include guard.
2286         * mi/mi-common.h: Rename include guard.
2287         * mi/mi-cmds.h: Rename include guard.
2288         * mi/mi-cmd-break.h: Rename include guard.
2289         * m2-lang.h: Add include guard.
2290         * location.h: Rename include guard.
2291         * linux-record.h: Rename include guard.
2292         * linux-nat.h: Add include guard.
2293         * linux-fork.h: Add include guard.
2294         * i386-darwin-tdep.h: Rename include guard.
2295         * hppa-linux-offsets.h: Add include guard.
2296         * guile/guile.h: Rename include guard.
2297         * guile/guile-internal.h: Rename include guard.
2298         * gnu-nat.h: Rename include guard.
2299         * gdb-stabs.h: Rename include guard.
2300         * frv-tdep.h: Add include guard.
2301         * f-lang.h: Add include guard.
2302         * event-loop.h: Add include guard.
2303         * darwin-nat.h: Rename include guard.
2304         * cp-abi.h: Rename include guard.
2305         * config/sparc/nm-sol2.h: Rename include guard.
2306         * config/nm-nto.h: Rename include guard.
2307         * config/nm-linux.h: Add include guard.
2308         * config/i386/nm-i386gnu.h: Rename include guard.
2309         * config/djgpp/nl_types.h: Rename include guard.
2310         * config/djgpp/langinfo.h: Rename include guard.
2311         * compile/gcc-cp-plugin.h: Add include guard.
2312         * compile/gcc-c-plugin.h: Add include guard.
2313         * compile/compile.h: Rename include guard.
2314         * compile/compile-object-run.h: Rename include guard.
2315         * compile/compile-object-load.h: Rename include guard.
2316         * compile/compile-internal.h: Rename include guard.
2317         * compile/compile-cplus.h: Rename include guard.
2318         * compile/compile-c.h: Rename include guard.
2319         * common/xml-utils.h: Rename include guard.
2320         * common/x86-xstate.h: Rename include guard.
2321         * common/version.h: Rename include guard.
2322         * common/vec.h: Rename include guard.
2323         * common/tdesc.h: Rename include guard.
2324         * common/selftest.h: Rename include guard.
2325         * common/scoped_restore.h: Rename include guard.
2326         * common/scoped_mmap.h: Rename include guard.
2327         * common/scoped_fd.h: Rename include guard.
2328         * common/safe-iterator.h: Rename include guard.
2329         * common/run-time-clock.h: Rename include guard.
2330         * common/refcounted-object.h: Rename include guard.
2331         * common/queue.h: Rename include guard.
2332         * common/ptid.h: Rename include guard.
2333         * common/print-utils.h: Rename include guard.
2334         * common/preprocessor.h: Rename include guard.
2335         * common/pathstuff.h: Rename include guard.
2336         * common/observable.h: Rename include guard.
2337         * common/netstuff.h: Rename include guard.
2338         * common/job-control.h: Rename include guard.
2339         * common/host-defs.h: Rename include guard.
2340         * common/gdb_wait.h: Rename include guard.
2341         * common/gdb_vecs.h: Rename include guard.
2342         * common/gdb_unlinker.h: Rename include guard.
2343         * common/gdb_unique_ptr.h: Rename include guard.
2344         * common/gdb_tilde_expand.h: Rename include guard.
2345         * common/gdb_sys_time.h: Rename include guard.
2346         * common/gdb_string_view.h: Rename include guard.
2347         * common/gdb_splay_tree.h: Rename include guard.
2348         * common/gdb_setjmp.h: Rename include guard.
2349         * common/gdb_ref_ptr.h: Rename include guard.
2350         * common/gdb_optional.h: Rename include guard.
2351         * common/gdb_locale.h: Rename include guard.
2352         * common/gdb_assert.h: Rename include guard.
2353         * common/filtered-iterator.h: Rename include guard.
2354         * common/filestuff.h: Rename include guard.
2355         * common/fileio.h: Rename include guard.
2356         * common/environ.h: Rename include guard.
2357         * common/common-utils.h: Rename include guard.
2358         * common/common-types.h: Rename include guard.
2359         * common/common-regcache.h: Rename include guard.
2360         * common/common-inferior.h: Rename include guard.
2361         * common/common-gdbthread.h: Rename include guard.
2362         * common/common-exceptions.h: Rename include guard.
2363         * common/common-defs.h: Rename include guard.
2364         * common/common-debug.h: Rename include guard.
2365         * common/cleanups.h: Rename include guard.
2366         * common/buffer.h: Rename include guard.
2367         * common/btrace-common.h: Rename include guard.
2368         * common/break-common.h: Rename include guard.
2369         * cli/cli-utils.h: Rename include guard.
2370         * cli/cli-style.h: Rename include guard.
2371         * cli/cli-setshow.h: Rename include guard.
2372         * cli/cli-script.h: Rename include guard.
2373         * cli/cli-interp.h: Rename include guard.
2374         * cli/cli-decode.h: Rename include guard.
2375         * cli/cli-cmds.h: Rename include guard.
2376         * charset-list.h: Add include guard.
2377         * buildsym-legacy.h: Rename include guard.
2378         * bfin-tdep.h: Add include guard.
2379         * ax.h: Rename include guard.
2380         * arm-linux-tdep.h: Add include guard.
2381         * arm-fbsd-tdep.h: Add include guard.
2382         * arch/xtensa.h: Rename include guard.
2383         * arch/tic6x.h: Add include guard.
2384         * arch/i386.h: Add include guard.
2385         * arch/arm.h: Rename include guard.
2386         * arch/arm-linux.h: Rename include guard.
2387         * arch/arm-get-next-pcs.h: Rename include guard.
2388         * arch/amd64.h: Add include guard.
2389         * arch/aarch64-insn.h: Rename include guard.
2390         * arch-utils.h: Rename include guard.
2391         * annotate.h: Add include guard.
2392         * amd64-darwin-tdep.h: Rename include guard.
2393         * aarch64-linux-tdep.h: Add include guard.
2394         * aarch64-fbsd-tdep.h: Add include guard.
2395         * aarch32-linux-nat.h: Add include guard.
2396
2397 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2398
2399         * macrotab.c (macro_define_internal): New function that
2400         factorizes macro_define_object_internal and macro_define_function
2401         code.
2402         (macro_define_object_internal): Use macro_define_internal.
2403         (macro_define_function): Likewise.
2404
2405 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2406
2407         * macrocmd.c (extract_identifier): Return
2408         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2409         callers.
2410
2411 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2412
2413         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2414
2415 2019-02-05  Tom Tromey  <tom@tromey.com>
2416
2417         * target.c (target_stack::unpush): Move assertion earlier.
2418
2419 2019-01-30  Tom Tromey  <tom@tromey.com>
2420
2421         PR python/23615:
2422         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2423         (gdbpy_parse_and_eval): Likewise.
2424         * python/python-internal.h (gdbpy_allow_threads): New class.
2425
2426 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2427
2428         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2429         (aarch64_fbsd_fpregmap): Move earlier.
2430         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2431         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2432         instead of individual calls to trad_frame_set_reg_addr.
2433         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2434         earlier.
2435         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2436         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2437         instead of individual calls to trad_frame_set_reg_addr.
2438
2439 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2440
2441         * CONTRIBUTE: Replace contribution list with wiki link.
2442
2443 2019-01-25  Tom Tromey  <tom@tromey.com>
2444
2445         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2446
2447 2019-01-25  Tom Tromey  <tom@tromey.com>
2448
2449         * xtensa-linux-nat.c: Fix common/ includes.
2450         * xml-support.h: Fix common/ includes.
2451         * xml-support.c: Fix common/ includes.
2452         * x86-linux-nat.c: Fix common/ includes.
2453         * windows-nat.c: Fix common/ includes.
2454         * varobj.h: Fix common/ includes.
2455         * varobj.c: Fix common/ includes.
2456         * value.c: Fix common/ includes.
2457         * valops.c: Fix common/ includes.
2458         * utils.c: Fix common/ includes.
2459         * unittests/xml-utils-selftests.c: Fix common/ includes.
2460         * unittests/utils-selftests.c: Fix common/ includes.
2461         * unittests/unpack-selftests.c: Fix common/ includes.
2462         * unittests/tracepoint-selftests.c: Fix common/ includes.
2463         * unittests/style-selftests.c: Fix common/ includes.
2464         * unittests/string_view-selftests.c: Fix common/ includes.
2465         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2466         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2467         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2468         * unittests/rsp-low-selftests.c: Fix common/ includes.
2469         * unittests/parse-connection-spec-selftests.c: Fix common/
2470         includes.
2471         * unittests/optional-selftests.c: Fix common/ includes.
2472         * unittests/offset-type-selftests.c: Fix common/ includes.
2473         * unittests/observable-selftests.c: Fix common/ includes.
2474         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2475         * unittests/memrange-selftests.c: Fix common/ includes.
2476         * unittests/memory-map-selftests.c: Fix common/ includes.
2477         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2478         * unittests/function-view-selftests.c: Fix common/ includes.
2479         * unittests/environ-selftests.c: Fix common/ includes.
2480         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2481         * unittests/common-utils-selftests.c: Fix common/ includes.
2482         * unittests/cli-utils-selftests.c: Fix common/ includes.
2483         * unittests/array-view-selftests.c: Fix common/ includes.
2484         * ui-file.c: Fix common/ includes.
2485         * tui/tui-io.c: Fix common/ includes.
2486         * tracepoint.h: Fix common/ includes.
2487         * tracepoint.c: Fix common/ includes.
2488         * tracefile-tfile.c: Fix common/ includes.
2489         * top.h: Fix common/ includes.
2490         * top.c: Fix common/ includes.
2491         * thread.c: Fix common/ includes.
2492         * target/waitstatus.h: Fix common/ includes.
2493         * target/waitstatus.c: Fix common/ includes.
2494         * target.h: Fix common/ includes.
2495         * target.c: Fix common/ includes.
2496         * target-memory.c: Fix common/ includes.
2497         * target-descriptions.c: Fix common/ includes.
2498         * symtab.h: Fix common/ includes.
2499         * symfile.c: Fix common/ includes.
2500         * stap-probe.c: Fix common/ includes.
2501         * spu-linux-nat.c: Fix common/ includes.
2502         * sparc-nat.c: Fix common/ includes.
2503         * source.c: Fix common/ includes.
2504         * solib.c: Fix common/ includes.
2505         * solib-target.c: Fix common/ includes.
2506         * ser-unix.c: Fix common/ includes.
2507         * ser-tcp.c: Fix common/ includes.
2508         * ser-pipe.c: Fix common/ includes.
2509         * ser-base.c: Fix common/ includes.
2510         * selftest-arch.c: Fix common/ includes.
2511         * s12z-tdep.c: Fix common/ includes.
2512         * rust-exp.y: Fix common/ includes.
2513         * rs6000-aix-tdep.c: Fix common/ includes.
2514         * riscv-tdep.c: Fix common/ includes.
2515         * remote.c: Fix common/ includes.
2516         * remote-notif.h: Fix common/ includes.
2517         * remote-fileio.h: Fix common/ includes.
2518         * remote-fileio.c: Fix common/ includes.
2519         * regcache.h: Fix common/ includes.
2520         * regcache.c: Fix common/ includes.
2521         * record-btrace.c: Fix common/ includes.
2522         * python/python.c: Fix common/ includes.
2523         * python/py-type.c: Fix common/ includes.
2524         * python/py-inferior.c: Fix common/ includes.
2525         * progspace.h: Fix common/ includes.
2526         * producer.c: Fix common/ includes.
2527         * procfs.c: Fix common/ includes.
2528         * proc-api.c: Fix common/ includes.
2529         * printcmd.c: Fix common/ includes.
2530         * ppc-linux-nat.c: Fix common/ includes.
2531         * parser-defs.h: Fix common/ includes.
2532         * osdata.c: Fix common/ includes.
2533         * obsd-nat.c: Fix common/ includes.
2534         * nat/x86-linux.c: Fix common/ includes.
2535         * nat/x86-linux-dregs.c: Fix common/ includes.
2536         * nat/x86-dregs.h: Fix common/ includes.
2537         * nat/x86-dregs.c: Fix common/ includes.
2538         * nat/ppc-linux.c: Fix common/ includes.
2539         * nat/mips-linux-watch.h: Fix common/ includes.
2540         * nat/mips-linux-watch.c: Fix common/ includes.
2541         * nat/linux-waitpid.c: Fix common/ includes.
2542         * nat/linux-ptrace.h: Fix common/ includes.
2543         * nat/linux-ptrace.c: Fix common/ includes.
2544         * nat/linux-procfs.c: Fix common/ includes.
2545         * nat/linux-personality.c: Fix common/ includes.
2546         * nat/linux-osdata.c: Fix common/ includes.
2547         * nat/linux-namespaces.c: Fix common/ includes.
2548         * nat/linux-btrace.h: Fix common/ includes.
2549         * nat/linux-btrace.c: Fix common/ includes.
2550         * nat/fork-inferior.c: Fix common/ includes.
2551         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2552         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2553         * nat/aarch64-linux.c: Fix common/ includes.
2554         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2555         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2556         * namespace.h: Fix common/ includes.
2557         * mips-linux-tdep.c: Fix common/ includes.
2558         * minsyms.c: Fix common/ includes.
2559         * mi/mi-parse.h: Fix common/ includes.
2560         * mi/mi-main.c: Fix common/ includes.
2561         * mi/mi-cmd-env.c: Fix common/ includes.
2562         * memrange.h: Fix common/ includes.
2563         * memattr.c: Fix common/ includes.
2564         * maint.h: Fix common/ includes.
2565         * maint.c: Fix common/ includes.
2566         * main.c: Fix common/ includes.
2567         * machoread.c: Fix common/ includes.
2568         * location.c: Fix common/ includes.
2569         * linux-thread-db.c: Fix common/ includes.
2570         * linux-nat.c: Fix common/ includes.
2571         * linux-fork.c: Fix common/ includes.
2572         * inline-frame.c: Fix common/ includes.
2573         * infrun.c: Fix common/ includes.
2574         * inflow.c: Fix common/ includes.
2575         * inferior.h: Fix common/ includes.
2576         * inferior.c: Fix common/ includes.
2577         * infcmd.c: Fix common/ includes.
2578         * inf-ptrace.c: Fix common/ includes.
2579         * inf-child.c: Fix common/ includes.
2580         * ia64-linux-nat.c: Fix common/ includes.
2581         * i387-tdep.c: Fix common/ includes.
2582         * i386-tdep.c: Fix common/ includes.
2583         * i386-linux-tdep.c: Fix common/ includes.
2584         * i386-linux-nat.c: Fix common/ includes.
2585         * i386-go32-tdep.c: Fix common/ includes.
2586         * i386-fbsd-tdep.c: Fix common/ includes.
2587         * i386-fbsd-nat.c: Fix common/ includes.
2588         * guile/scm-type.c: Fix common/ includes.
2589         * guile/guile.c: Fix common/ includes.
2590         * go32-nat.c: Fix common/ includes.
2591         * gnu-nat.c: Fix common/ includes.
2592         * gdbthread.h: Fix common/ includes.
2593         * gdbarch-selftests.c: Fix common/ includes.
2594         * gdb_usleep.c: Fix common/ includes.
2595         * gdb_select.h: Fix common/ includes.
2596         * gdb_bfd.c: Fix common/ includes.
2597         * gcore.c: Fix common/ includes.
2598         * fork-child.c: Fix common/ includes.
2599         * findvar.c: Fix common/ includes.
2600         * fbsd-nat.c: Fix common/ includes.
2601         * event-top.c: Fix common/ includes.
2602         * event-loop.c: Fix common/ includes.
2603         * dwarf2read.c: Fix common/ includes.
2604         * dwarf2loc.c: Fix common/ includes.
2605         * dwarf2-frame.c: Fix common/ includes.
2606         * dwarf-index-cache.c: Fix common/ includes.
2607         * dtrace-probe.c: Fix common/ includes.
2608         * disasm-selftests.c: Fix common/ includes.
2609         * defs.h: Fix common/ includes.
2610         * csky-tdep.c: Fix common/ includes.
2611         * cp-valprint.c: Fix common/ includes.
2612         * cp-support.h: Fix common/ includes.
2613         * cp-support.c: Fix common/ includes.
2614         * corelow.c: Fix common/ includes.
2615         * completer.h: Fix common/ includes.
2616         * completer.c: Fix common/ includes.
2617         * compile/compile.c: Fix common/ includes.
2618         * compile/compile-loc2c.c: Fix common/ includes.
2619         * compile/compile-cplus-types.c: Fix common/ includes.
2620         * compile/compile-cplus-symbols.c: Fix common/ includes.
2621         * command.h: Fix common/ includes.
2622         * cli/cli-dump.c: Fix common/ includes.
2623         * cli/cli-cmds.c: Fix common/ includes.
2624         * charset.c: Fix common/ includes.
2625         * build-id.c: Fix common/ includes.
2626         * btrace.h: Fix common/ includes.
2627         * btrace.c: Fix common/ includes.
2628         * breakpoint.h: Fix common/ includes.
2629         * breakpoint.c: Fix common/ includes.
2630         * ax.h:
2631         (enum agent_op): Fix common/ includes.
2632         * ax-general.c (struct aop_map): Fix common/ includes.
2633         * ax-gdb.c: Fix common/ includes.
2634         * auxv.c: Fix common/ includes.
2635         * auto-load.c: Fix common/ includes.
2636         * arm-tdep.c: Fix common/ includes.
2637         * arch/riscv.c: Fix common/ includes.
2638         * arch/ppc-linux-common.c: Fix common/ includes.
2639         * arch/i386.c: Fix common/ includes.
2640         * arch/arm.c: Fix common/ includes.
2641         * arch/arm-linux.c: Fix common/ includes.
2642         * arch/arm-get-next-pcs.c: Fix common/ includes.
2643         * arch/amd64.c: Fix common/ includes.
2644         * arch/aarch64.c: Fix common/ includes.
2645         * arch/aarch64-insn.c: Fix common/ includes.
2646         * arch-utils.c: Fix common/ includes.
2647         * amd64-windows-tdep.c: Fix common/ includes.
2648         * amd64-tdep.c: Fix common/ includes.
2649         * amd64-sol2-tdep.c: Fix common/ includes.
2650         * amd64-obsd-tdep.c: Fix common/ includes.
2651         * amd64-nbsd-tdep.c: Fix common/ includes.
2652         * amd64-linux-tdep.c: Fix common/ includes.
2653         * amd64-linux-nat.c: Fix common/ includes.
2654         * amd64-fbsd-tdep.c: Fix common/ includes.
2655         * amd64-fbsd-nat.c: Fix common/ includes.
2656         * amd64-dicos-tdep.c: Fix common/ includes.
2657         * amd64-darwin-tdep.c: Fix common/ includes.
2658         * agent.c: Fix common/ includes.
2659         * ada-lang.h: Fix common/ includes.
2660         * ada-lang.c: Fix common/ includes.
2661         * aarch64-tdep.c: Fix common/ includes.
2662
2663 2019-01-25  Tom Tromey  <tom@tromey.com>
2664
2665         * common/create-version.sh: Use common/version.h.
2666
2667 2019-01-24  Pedro Alves  <palves@redhat.com>
2668
2669         * infrun.c (signal_stop, signal_print, signal_program)
2670         (signal_catch, signal_pass): Now arrays instead of pointers.
2671         (update_signals_program_target, do_target_resume)
2672         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2673         * linux-nat.c (linux_nat_target::pass_signals)
2674         (linux_nat_target::create_inferior, linux_nat_target::attach):
2675         Adjust.
2676         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2677         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2678         * procfs.c (procfs_target::pass_signals): Adjust.
2679         * record-full.c (record_full_target::resume): Adjust.
2680         * remote.c (remote_target::pass_signals)
2681         (remote_target::program_signals): Adjust.
2682         * target-debug.h (target_debug_print_signals): Now takes a
2683         gdb::array_view as parameter.  Adjust.
2684         * target.h (target_ops) <pass_signals, program_signals>: Replace
2685         pointer and length parameters with gdb::array_view.
2686         (target_pass_signals, target_program_signals): Likewise.
2687         * target-delegates.c: Regenerate.
2688
2689 2019-01-24  Pedro Alves  <palves@redhat.com>
2690
2691         * common/forward-scope-exit.h
2692         (forward_scope_exit::forward_scope_exit): Pass arguments to
2693         m_bind_function directly, instead of creating a std::bind and
2694         copying that.
2695
2696 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2697
2698         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2699         for static members.
2700         (pass_in_v_vfp_candidate): Likewise.
2701
2702 2019-01-23  Tom Tromey  <tom@tromey.com>
2703             Pedro Alves  <palves@redhat.com>
2704
2705         * regcache.c (class regcache_invalidator): Remove.
2706         (regcache::raw_write): Use make_scope_exit.
2707
2708 2019-01-23  Tom Tromey  <tom@tromey.com>
2709
2710         * ui-out.h (class ui_out_emit_type): Update comment.
2711
2712 2019-01-23  Tom Tromey  <tom@tromey.com>
2713
2714         * infrun.c (fetch_inferior_event): Update comment.
2715
2716 2019-01-23  Tom Tromey  <tom@tromey.com>
2717             Pedro Alves  <palves@redhat.com>
2718
2719         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2720         parameter.
2721         (fetch_inferior_event): Use SCOPE_EXIT.
2722
2723
2724 2019-01-23  Tom Tromey  <tom@tromey.com>
2725             Pedro Alves  <palves@redhat.com>
2726
2727         * infrun.c (disable_thread_events): Delete.
2728         (stop_all_threads): Use SCOPE_EXIT.
2729
2730 2019-01-23  Tom Tromey  <tom@tromey.com>
2731             Pedro Alves  <palves@redhat.com>
2732
2733         * symfile.c: Include forward-scope-exit.h.
2734         (clear_symtab_users_cleanup): Replace forward declaration with
2735         a FORWARD_SCOPE_EXIT.
2736         (syms_from_objfile_1): Use the forward_scope_exit and
2737         gdb::optional instead of cleanup_function.
2738         (reread_symbols): Use the forward_scope_exit instead of
2739         cleanup_function.
2740         (clear_symtab_users_cleanup): Remove function.
2741
2742 2019-01-23  Tom Tromey  <tom@tromey.com>
2743             Pedro Alves  <palves@redhat.com>
2744
2745         * linux-nat.c: Include scope-exit.h.
2746         (cleanup_target_stop): Remove.
2747         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2748         SCOPE_EXIT.
2749
2750 2019-01-23  Tom Tromey  <tom@tromey.com>
2751             Pedro Alves  <palves@redhat.com>
2752
2753         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2754         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2755
2756 2019-01-23  Tom Tromey  <tom@tromey.com>
2757             Andrew Burgess  <andrew.burgess@embecosm.com>
2758             Pedro Alves  <palves@redhat.com>
2759
2760         * infrun.c (fetch_inferior_event): Use scope_exit.
2761         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2762         * top.c (execute_command): Use scope_exit.
2763         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2764         * utils.c (do_bpstat_clear_actions_cleanup)
2765         (make_bpstat_clear_actions_cleanup): Remove.
2766
2767 2019-01-23  Tom Tromey  <tom@tromey.com>
2768             Pedro Alves  <palves@redhat.com>
2769
2770         * infrun.c: Include "common/scope-exit.h"
2771         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2772         (wait_for_inferior): Use SCOPE_EXIT.
2773         (fetch_inferior_event): Use scope_exit.
2774
2775 2019-01-23  Tom Tromey  <tom@tromey.com>
2776             Pedro Alves  <palves@redhat.com>
2777
2778         * breakpoint.c (create_breakpoint): Remove cleanup.
2779
2780 2019-01-23  Tom Tromey  <tom@tromey.com>
2781             Andrew Burgess  <andrew.burgess@embecosm.com>
2782             Pedro Alves  <palves@redhat.com>
2783
2784 2019-01-23  Pedro Alves  <palves@redhat.com>
2785
2786         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2787
2788 2019-01-23  Pedro Alves  <palves@redhat.com>
2789             Andrew Burgess  <andrew.burgess@embecosm.com>
2790
2791         * gdbthread.h: Include "common/forward-scope-exit.h".
2792         (scoped_finish_thread_state): Redefine custom class in terms of
2793         forward_scope_exit.
2794
2795 2019-01-23  Pedro Alves  <palves@redhat.com>
2796             Andrew Burgess  <andrew.burgess@embecosm.com>
2797
2798         * common/forward-scope-exit.h: New file.
2799
2800 2019-01-23  Pedro Alves  <palves@redhat.com>
2801             Andrew Burgess  <andrew.burgess@embecosm.com>
2802             Tom Tromey  <tom@tromey.com>
2803
2804         * common/scope-exit.h: New file.
2805
2806 2019-01-23  Pedro Alves  <palves@redhat.com>
2807
2808         * common/preprocessor.h (ESC): Rename to ...
2809         (ESC_PARENS): ... this.
2810         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2811         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2812
2813 2019-01-23  Tom Tromey  <tom@tromey.com>
2814
2815         * language.h (class scoped_switch_to_sym_language_if_auto):
2816         Initialize m_lang in both cases.
2817
2818 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2819
2820         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2821         with XCNEW.
2822
2823 2019-01-22  Tom Tromey  <tom@tromey.com>
2824
2825         * corelow.c: Do not include sys/file.h.
2826
2827 2019-01-22  Tom Tromey  <tom@tromey.com>
2828
2829         * tui/tui-wingeneral.h: Include gdb_curses.h.
2830
2831 2019-01-22  Tom Tromey  <tom@tromey.com>
2832
2833         * source-cache.h (class source_cache) <get_source_lines,
2834         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2835
2836 2019-01-22  Tom Tromey  <tom@tromey.com>
2837
2838         * remote-fileio.h (struct remote_target): Declare.
2839
2840 2019-01-22  Tom Tromey  <tom@tromey.com>
2841
2842         * python/py-arch.c: Do not include py-ref.h.
2843         * python/py-bpevent.c: Do not include py-ref.h.
2844         * python/py-cmd.c: Do not include py-ref.h.
2845         * python/py-continueevent.c: Do not include py-ref.h.
2846         * python/py-event.h: Do not include py-ref.h.
2847         * python/py-evtregistry.c: Do not include py-ref.h.
2848         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2849         * python/py-frame.c: Do not include py-ref.h.
2850         * python/py-framefilter.c: Do not include py-ref.h.
2851         * python/py-function.c: Do not include py-ref.h.
2852         * python/py-infevents.c: Do not include py-ref.h.
2853         * python/py-linetable.c: Do not include py-ref.h.
2854         * python/py-objfile.c: Do not include py-ref.h.
2855         * python/py-param.c: Do not include py-ref.h.
2856         * python/py-prettyprint.c: Do not include py-ref.h.
2857         * python/py-progspace.c: Do not include py-ref.h.
2858         * python/py-symbol.c: Do not include py-ref.h.
2859         * python/py-symtab.c: Do not include py-ref.h.
2860         * python/py-type.c: Do not include py-ref.h.
2861         * python/py-unwind.c: Do not include py-ref.h.
2862         * python/py-utils.c: Do not include py-ref.h.
2863         * python/py-value.c: Do not include py-ref.h.
2864         * python/py-varobj.c: Do not include py-ref.h.
2865         * python/py-xmethods.c: Do not include py-ref.h.
2866         * python/python.c: Do not include py-ref.h.
2867         * varobj.c: Do not include py-ref.h.
2868
2869 2019-01-22  Tom Tromey  <tom@tromey.com>
2870
2871         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2872         keyword for bcache.
2873
2874 2019-01-22  Tom Tromey  <tom@tromey.com>
2875
2876         * compile/compile-cplus-types.c: Remove a comment by #include.
2877
2878 2019-01-22  Tom Tromey  <tom@tromey.com>
2879
2880         * compile/gcc-c-plugin.h: Include compile-internal.h.
2881
2882 2019-01-22  Tom Tromey  <tom@tromey.com>
2883
2884         * stabsread.c (EXTERN): Do not define.
2885         (symnum, next_symbol_text_func, processing_gcc_compilation)
2886         (within_function, global_sym_chain, global_stabs)
2887         (previous_stab_code, this_object_header_files)
2888         (n_this_object_header_files)
2889         (n_allocated_this_object_header_files): Define.
2890         * stabsread.h (EXTERN): Never define.  Use "extern".
2891
2892 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2893
2894         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2895         history_value.
2896
2897 2019-01-21  Tom Tromey  <tom@tromey.com>
2898
2899         * ui-out.c: Fix includes.
2900         * tui/tui-source.c: Fix includes.
2901         * target.c: Fix includes.
2902         * remote.c: Fix includes.
2903         * regcache.c: Fix includes.
2904         * python/py-block.c: Fix includes.
2905         * printcmd.c: Fix includes.
2906         * or1k-tdep.c: Fix includes.
2907         * mi/mi-main.c: Fix includes.
2908         * m32r-tdep.c: Fix includes.
2909         * csky-tdep.c: Fix includes.
2910         * compile/compile-cplus-types.c: Fix includes.
2911         * cli/cli-interp.c: Fix includes.
2912
2913 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2914
2915         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2916         for padding.
2917
2918 2019-01-16  Tom Tromey  <tom@tromey.com>
2919
2920         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2921         earlier.
2922         (struct objfile) <msymbols_range>: Move from top level.
2923         <msymbols>: New method.
2924         (class objfile_msymbols): Remove.
2925         * symtab.c (default_collect_symbol_completion_matches_break_on):
2926         Update.
2927         * symmisc.c (dump_msymbols): Update.
2928         * stabsread.c (scan_file_globals): Update.
2929         * objc-lang.c (info_selectors_command, info_classes_command)
2930         (find_methods): Update.
2931         * minsyms.c (find_solib_trampoline_target): Update.
2932         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2933         * coffread.c (coff_symfile_read): Update.
2934         * ada-lang.c (ada_lookup_simple_minsym)
2935         (ada_collect_symbol_completion_matches): Update.
2936
2937 2019-01-16  Tom Tromey  <tom@tromey.com>
2938
2939         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2940         type.  Remove no-argument constructor.
2941         <iterator::operator++>: Simplify.
2942         <begin>: Update.
2943         <end>: Use minimal_symbol_count.
2944
2945 2019-01-16  Tom Tromey  <tom@tromey.com>
2946
2947         * objfiles.h (struct objfile) <psymtabs>: New method.
2948         (class objfile_psymtabs): Remove.
2949         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2950         typedef.
2951         <range>: New method.
2952         (require_partial_symbols): Change return type.
2953         * psymtab.c (require_partial_symbols)
2954         (psym_expand_symtabs_matching): Update.
2955         * mdebugread.c (parse_partial_symbols): Update.
2956         * dbxread.c (dbx_end_psymtab): Update.
2957
2958 2019-01-15  Tom Tromey  <tom@tromey.com>
2959
2960         * symtab.c (lookup_objfile_from_block)
2961         (lookup_symbol_in_objfile_symtabs)
2962         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2963         (find_line_symtab, info_sources_command)
2964         (default_collect_symbol_completion_matches_break_on)
2965         (make_source_files_completion_list): Update.
2966         * symmisc.c (print_objfile_statistics, dump_objfile)
2967         (maintenance_print_symbols, maintenance_info_symtabs)
2968         (maintenance_check_symtabs, maintenance_info_line_tables):
2969         Update.
2970         * source.c (select_source_symtab)
2971         (forget_cached_source_info_for_objfile): Update.
2972         * objfiles.h (class objfile_compunits): Remove.
2973         (struct objfile) <compunits_range>: New typedef.
2974         (compunits): New method.
2975         * objfiles.c (objfile_relocate1): Update.
2976         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2977         * maint.c (count_symtabs_and_blocks): Update.
2978         * linespec.c (iterate_over_all_matching_symtabs): Update.
2979         * cp-support.c (add_symbol_overload_list_qualified): Update.
2980         * coffread.c (coff_symtab_read): Update.
2981         * ada-lang.c (add_nonlocal_symbols)
2982         (ada_collect_symbol_completion_matches)
2983         (ada_add_global_exceptions): Update.
2984
2985 2019-01-15  Tom Tromey  <tom@tromey.com>
2986
2987         * progspace.h (program_space) <objfiles_safe_range>: New
2988         typedef.
2989         <objfiles_safe>: New method.
2990         * objfiles.h (class all_objfiles_safe): Remove.
2991         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2992         * jit.c (jit_inferior_exit_hook): Update.
2993
2994 2019-01-17  Tom Tromey  <tom@tromey.com>
2995
2996         * progspace.h (program_space) <objfiles_range>: New typedef.
2997         <objfiles>: New method.
2998         <objfiles_head>: Rename from objfiles.
2999         (object_files): Update.
3000         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3001         * guile/scm-pretty-print.c
3002         (ppscm_find_pretty_printer_from_objfiles): Update.
3003         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3004         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3005         Update.
3006         * python/py-progspace.c (pspy_get_objfiles): Update.
3007         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3008         Update.
3009         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3010         (objfpy_lookup_objfile_by_build_id): Update.
3011         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3012         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3013         Update.
3014         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3015         (expand_symtab_containing_pc, lookup_objfile_from_block)
3016         (lookup_static_symbol, basic_lookup_transparent_type)
3017         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3018         (find_line_symtab, info_sources_command)
3019         (default_collect_symbol_completion_matches_break_on)
3020         (make_source_files_completion_list, find_main_name): Update.
3021         * symmisc.c (print_symbol_bcache_statistics)
3022         (print_objfile_statistics, maintenance_print_symbols)
3023         (maintenance_print_msymbols, maintenance_print_objfiles)
3024         (maintenance_info_symtabs, maintenance_check_symtabs)
3025         (maintenance_expand_symtabs, maintenance_info_line_tables):
3026         Update.
3027         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3028         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3029         (map_overlay_command, unmap_overlay_command)
3030         (simple_overlay_update, expand_symtabs_matching)
3031         (map_symbol_filenames): Update.
3032         * symfile-debug.c (set_debug_symfile): Update.
3033         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3034         Update.
3035         * source.c (select_source_symtab, forget_cached_source_info):
3036         Update.
3037         * solib.c (solib_read_symbols): Update.
3038         * solib-spu.c (append_ocl_sos): Update.
3039         * psymtab.c (maintenance_print_psymbols)
3040         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3041         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3042         * printcmd.c (info_symbol_command): Update.
3043         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3044         Update.
3045         * objfiles.h (class all_objfiles): Remove.
3046         * objfiles.c (have_partial_symbols, have_full_symbols)
3047         (have_minimal_symbols, qsort_cmp, update_section_map)
3048         (shared_objfile_contains_address_p)
3049         (default_iterate_over_objfiles_in_search_order): Update.
3050         * objc-lang.c (info_selectors_command, info_classes_command)
3051         (find_methods): Update.
3052         * minsyms.c (find_solib_trampoline_target): Update.
3053         * maint.c (maintenance_info_sections)
3054         (maintenance_translate_address, count_symtabs_and_blocks):
3055         Update.
3056         * main.c (captured_main_1): Update.
3057         * linux-thread-db.c (try_thread_db_load_from_pdir)
3058         (has_libpthread): Update.
3059         * linespec.c (iterate_over_all_matching_symtabs)
3060         (search_minsyms_for_name): Update.
3061         * jit.c (jit_find_objf_with_entry_addr): Update.
3062         * hppa-tdep.c (find_unwind_entry)
3063         (hppa_lookup_stub_minimal_symbol): Update.
3064         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3065         Update.
3066         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3067         (elf_gnu_ifunc_resolve_by_got): Update.
3068         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3069         * dwarf-index-write.c (save_gdb_index_command): Update.
3070         * cp-support.c (add_symbol_overload_list_qualified): Update.
3071         * breakpoint.c (create_overlay_event_breakpoint)
3072         (create_longjmp_master_breakpoint)
3073         (create_std_terminate_master_breakpoint)
3074         (create_exception_master_breakpoint): Update.
3075         * blockframe.c (find_pc_partial_function): Update.
3076         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3077         (ada_collect_symbol_completion_matches)
3078         (ada_add_global_exceptions): Update.
3079
3080 2019-01-17  Tom Tromey  <tom@tromey.com>
3081
3082         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3083         declare VEC.
3084         (solib_target_parse_libraries): Change return type.
3085         (library_list_start_segment, library_list_start_section)
3086         (library_list_end_library, library_list_start_library); Update.
3087         (solib_target_free_library_list): Remove.
3088         (solib_target_parse_libraries): Remove cleanup.  Change return
3089         type.
3090         (solib_target_current_sos): Update.
3091
3092 2019-01-17  Tom Tromey  <tromey@bapiya>
3093
3094         * valprint.c: Replace "the the" with "the".
3095         * symtab.c: Replace "the the" with "the".
3096         * solib.c: Replace "the the" with "the".
3097         * solib-dsbt.c: Replace "the the" with "the".
3098         * linespec.c: Replace "the the" with "the".
3099         * dwarf2loc.h: Replace "the the" with "the".
3100         * amd64-windows-tdep.c: Replace "the the" with "the".
3101         * aarch64-tdep.c: Replace "the the" with "the".
3102
3103 2019-01-16  Keith Seitz  <keiths@redhat.com>
3104
3105         PR gdb/23773
3106         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3107         <builder>: Rename to ..
3108         <m_builder>: ... this and make private.
3109         (dwarf2_cu::get_builder): New method.  Change all users of
3110         `builder' to use this method.
3111         (dwarf2_start_symtab): Move to ...
3112         (dwarf2_cu::start_symtab): ... here.  Update all callers
3113         (setup_type_unit_groups): Move to ...
3114         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3115         callers.
3116         (dwarf2_cu::reset_builder): New method.
3117         (process_full_compunit, process_full_type_unit): Use
3118         dwarf2_cu::reset_builder.
3119         (follow_die_offset): Record the ancestor CU if it is different
3120         from the followed DIE's CU.
3121         (follow_die_sig_1): Likewise.
3122
3123 2019-01-15  Tom Tromey  <tom@tromey.com>
3124
3125         * remote.c (class remote_state) <buf>: Now a char_vector.
3126         <buf_size>: Remove.
3127         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3128         parameter.
3129         (remote_target::getpkt_or_notif_sane_1)
3130         (remote_target::getpkt_sane)
3131         (remote_target::getpkt_or_notif_sane): Likewise.
3132         (class remote_target) <putpkt>: New overload.
3133         (remote_target::read_frame): Change type of "buf_p".  Remove
3134         sizeof_p parameter.
3135         (packet_ok): New overload.
3136         (packet_check_result): New overload.
3137         Update all uses.
3138
3139 2019-01-14  Tom Tromey  <tom@tromey.com>
3140
3141         * remote-notif.c (handle_notification, remote_notif_ack)
3142         (remote_notif_parse): Make "buf" const.
3143         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3144         const.
3145         (remote_notif_parse, remote_notif_ack, handle_notification):
3146         Likewise.
3147         * remote.c (remote_notif_stop_parse): Make "buf" const.
3148         (remote_target::remote_parse_stop_reply): Make "buf" const.
3149         (remote_notif_stop_ack): Make "buf" const.
3150
3151 2019-01-14  Tom Tromey  <tom@tromey.com>
3152
3153         * remote.c (remote_console_output): Make parameter const.
3154
3155 2019-01-14  Tom Tromey  <tom@tromey.com>
3156
3157         * target-debug.h (target_debug_print_signals): Constify.
3158         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3159         * procfs.c (procfs_target::pass_signals): Update.
3160         * linux-nat.c (linux_nat_target::pass_signals): Update.
3161         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3162         * target-delegates.c: Rebuild.
3163         * remote.c (remote_target::program_signals): Update.
3164         (remote_target::pass_signals): Update.
3165         * target.c (target_pass_signals): Constify argument.
3166         (target_program_signals): Likewise.
3167         * target.h (struct target_ops) <pass_signals, program_signals>:
3168         Constify argument.
3169         (target_pass_signals, target_program_signals): Constify argument.
3170
3171 2019-01-14  Tom Tromey  <tom@tromey.com>
3172
3173         PR tui/28819:
3174         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3175
3176 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3177
3178         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3179         field.
3180         * rs6000-tdep.c: Include reggroups.h.
3181         (IS_V_ALIAS_PSEUDOREG): Define.
3182         (rs6000_register_name): Return names for the "vX" aliases.
3183         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3184         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3185         aliases.  Call default_register_reggroup_p for all other
3186         pseudo-registers.
3187         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3188         New functions.
3189         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3190         Handle "vX" aliases.
3191         (v_alias_pseudo_register_collect): New function.
3192         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3193         (rs6000_gdbarch_init): Initialize "vX" aliases as
3194         pseudo-registers.  Restore registration of
3195         rs6000_pseudo_register_reggroup_p with
3196         set_tdesc_pseudo_register_reggroup_p.
3197
3198 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3199
3200         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3201         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3202         set_gdbarch_num_pseudo_regs.
3203
3204 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3205
3206         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3207         Remove arg prefixname, add do_set and do_show.
3208         Add member functions set_list and show_list.
3209         * cli/cli-style.c (class cli_style_option): Update accordingly.
3210         (style_set_list): Move to file scope.
3211         (style_show_list): Likewise.
3212         (set_style): Call help_list.
3213         (show_style): Call cmd_show_list.
3214         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3215         Update to use the new macro.
3216
3217 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3218
3219         * ada-lang.c (_initialize_ada_language): Expand the help text
3220         for the "catch exception" command.
3221
3222 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3223
3224         * symtab.c (matching_obj_sections): Initialize obj,
3225         declare it closer to its usage.
3226
3227 2019-01-10  Tom Tromey  <tom@tromey.com>
3228
3229         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3230         (basic_inf_threads_range): Remove.
3231         (inf_threads_range, inf_non_exited_threads_range)
3232         (safe_inf_threads_range): Use next_adapter.
3233
3234 2019-01-10  Keith Seitz  <keiths@redhat.com>
3235
3236         PR gdb/23712
3237         PR symtab/23010
3238         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3239         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3240
3241 2019-01-10  Keith Seitz  <keiths@redhat.com>
3242
3243         PR gdb/23712
3244         PR symtab/23010
3245         * dictionary.c (pending_to_vector): Remove.
3246         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3247         Remove _1 suffix, replacing functions of the same name.  Update
3248         all callers.
3249         (dict_create_hashed, dict_create_hashed_expandable)
3250         (dict_create_linear, dict_create_linear_expandable, dict_free)
3251         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3252         Make functions static.
3253
3254 2019-01-10  Keith Seitz  <keiths@redhat.com>
3255
3256         PR gdb/23712
3257         PR symtab/23010
3258         * dictionary.h (struct dictionary): Replace declaration with
3259         multidictionary.
3260         (dict_create_hashed, dict_create_hashed_expandable)
3261         (dict_create_linear, dict_create_linear_expandable)
3262         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3263         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3264         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3265         taking multidictionary argument.
3266         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3267         * block.h (struct block) <dict>: Change to multidictionary
3268         and rename `multidict'.
3269         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3270         symmisc.c: Update all dictionary references to multidictionary.
3271
3272 2019-01-10  Keith Seitz  <keiths@redhat.com>
3273
3274         PR gdb/23712
3275         PR symtab/23010
3276         * dictionary.c: Include unordered_map.
3277         (pending_to_vector): New function.
3278         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3279         Rewrite the non-"_1" functions to take vector instead
3280         of linked list.
3281         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3282         "new" _1 versions of the same name.
3283         (multidictionary): Define.
3284         (std::hash<enum language): New definition.
3285         (collate_pending_symbols_by_language, mdict_create_hashed)
3286         (mdict_create_hashed_expandable, mdict_create_linear)
3287         (mdict_create_linear_expandable, mdict_free)
3288         (find_language_dictionary, create_new_language_dictionary)
3289         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3290         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3291         (mdict_size, mdict_empty): New functions.
3292         * dictionary.h (mdict_iterator): Define.
3293
3294 2019-01-10  Pedro Alves  <palves@redhat.com>
3295
3296         * breakpoint.c (read_uploaded_action)
3297         (create_tracepoint_from_upload): Adjust to use
3298         gdb::unique_xmalloc_ptr.
3299         * ctf.c (ctf_write_uploaded_tp):
3300         (SET_ARRAY_FIELD): Use emplace_back.
3301         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3302         * tracefile-tfile.c (tfile_write_uploaded_tp):
3303         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3304         gdb::unique_xmalloc_ptr.
3305         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3306         at_string, cond_string, cmd_strings>: Replace char pointers
3307         with gdb::unique_xmalloc_ptr.
3308
3309 2019-01-10  Pedro Alves  <palves@redhat.com>
3310
3311         * solib-target.c (library_list_start_library): Don't xstrdup name.
3312
3313 2019-01-10  Pedro Alves  <palves@redhat.com>
3314
3315         * mdebugread.c (parse_partial_symbols): Use
3316         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3317
3318 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3319
3320         * linux-fork.c (scoped_switch_fork_info)
3321         <~scoped_switch_fork_info>: Fix incorrect variable name.
3322
3323 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3324
3325         * linux-fork.c (scoped_switch_fork_info)
3326         <scoped_switch_fork_info>: Make explicit.
3327         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3328
3329 2019-01-10  Tom Tromey  <tom@tromey.com>
3330
3331         * objfiles.h (objfile::reset_psymtabs): Update.
3332         * objfiles.c (objfile::objfile): Update.
3333         * psymtab.h (psymtab_storage::obstack): Update.
3334         (psymtab_storage::m_obstack): Use gdb::optional.
3335         (class psymtab_storage): Update comment.  Remove objfile
3336         parameter.
3337         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3338
3339 2019-01-10  Tom Tromey  <tom@tromey.com>
3340
3341         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3342         <free_psymtabs>: Now private.
3343         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3344         (allocate_psymtab): Use new method.
3345
3346 2019-01-10  Tom Tromey  <tom@tromey.com>
3347
3348         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3349         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3350         * mdebugread.c (parse_partial_symbols): Use
3351         allocate_dependencies.
3352         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3353         allocate_dependencies.
3354         (process_psymtab_comp_unit_reader)
3355         (build_type_psymtab_dependencies): Likewise.
3356         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3357
3358 2019-01-10  Tom Tromey  <tom@tromey.com>
3359
3360         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3361         PSYMBOL_SET_LANGUAGE.
3362         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3363
3364 2019-01-10  Tom Tromey  <tom@tromey.com>
3365
3366         * psymtab.h (psymtab_storage::obstack): New method.
3367         <m_obstack>: Rename from obstack; now private.
3368         * psymtab.c (psymtab_storage): Update.
3369         * dwarf2read.c (create_addrmap_from_index)
3370         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3371         Update.
3372
3373 2019-01-10  Tom Tromey  <tom@tromey.com>
3374
3375         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3376         * objfiles.h (objfile::reset_psymtabs): New method.
3377
3378 2019-01-10  Tom Tromey  <tom@tromey.com>
3379
3380         * symmisc.c (print_symbol_bcache_statistics): Update.
3381         (print_objfile_statistics): Update.
3382         * symfile.c (reread_symbols): Update.
3383         * psymtab.h (class psymtab_storage): New.
3384         * psymtab.c (psymtab_storage): New constructor.
3385         (~psymtab_storage): New destructor.
3386         (require_partial_symbols): Update.
3387         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3388         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3389         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3390         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3391         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3392         (start_psymtab_common, end_psymtab_common)
3393         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3394         (allocate_psymtab): Update.
3395         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3396         Update.
3397         (dump_psymtab_addrmap, maintenance_print_psymbols)
3398         (maintenance_check_psymtabs): Update.
3399         (class objfile_psymtabs): Move to objfiles.h.
3400         * psympriv.h (discard_psymtab): Now inline.
3401         (psymtab_discarder::psymtab_discarder): Update.
3402         (psymtab_discarder::~psymtab_discarder): Update.
3403         (ALL_OBJFILE_PSYMTABS): Rewrite.
3404         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3405         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3406         Remove fields.
3407         <partial_symtabs>: New field.
3408         (class objfile_psymtabs): Move from psymtab.h.  Update.
3409         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3410         psymbol_cache.
3411         (objfile::~objfile): Don't destroy psymbol_cache.
3412         * mdebugread.c (parse_partial_symbols): Update.
3413         * dwarf2read.c (create_addrmap_from_index)
3414         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3415         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3416         (add_partial_subprogram, dwarf2_ranges_read): Update.
3417         * dwarf-index-write.c (write_address_map)
3418         (write_one_signatured_type, recursively_write_psymbols)
3419         (class debug_names, class debug_names, write_psymtabs_to_index):
3420         Update.
3421
3422 2019-01-10  Tom Tromey  <tom@tromey.com>
3423
3424         * symtab.h (SYMBOL_SET_NAMES): Update.
3425         (symbol_set_names): Update.
3426         (MSYMBOL_SET_NAMES): Update.
3427         * symtab.c (symbol_set_names): Change argument to be an
3428         objfile_per_bfd_storage.
3429         * psymtab.c (add_psymbol_to_bcache): Update.
3430         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3431
3432 2019-01-10  Tom Tromey  <tom@tromey.com>
3433
3434         * symtab.c (create_demangled_names_hash): Change argument to be an
3435         objfile_per_bfd_storage.
3436         (symbol_set_names): Update.
3437
3438 2019-01-10  Tom Tromey  <tom@tromey.com>
3439
3440         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3441         init_psymbol_list.
3442         * psymtab.c (init_psymbol_list): Do nothing if already called.
3443         * psympriv.h (init_psymbol_list): Add comment.
3444         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3445         init_psymbol_list.
3446         * dbxread.c (dbx_symfile_read): Unconditionally call
3447         init_psymbol_list.
3448
3449 2019-01-10  Tom Tromey  <tom@tromey.com>
3450
3451         * xcoffread.c (scan_xcoff_symtab): Update.
3452         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3453         "where".
3454         * mdebugread.c (parse_partial_symbols)
3455         (handle_psymbol_enumerators): Update.
3456         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3457         * dbxread.c (read_dbx_symtab): Update.
3458         * psympriv.h (psymbol_placement): New enum.
3459         (add_psymbol_to_list): Update.
3460
3461 2019-01-10  Tom Tromey  <tom@tromey.com>
3462
3463         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3464         static_psymbols parameters.
3465         (scan_xcoff_symtab): Update.
3466         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3467         static_psymbols parameters.
3468         * psympriv.h (start_psymtab_common): Update.
3469         * mdebugread.c (parse_partial_symbols): Update.
3470         * dwarf2read.c (create_partial_symtab): Update.
3471         * dbxread.c (read_dbx_symtab): Update.
3472         (start_psymtab): Remove global_psymbols and static_psymbols
3473         parameters.
3474
3475 2019-01-10  Tom Tromey  <tom@tromey.com>
3476
3477         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3478         * psymtab.c (allocate_psymtab): Add comment.
3479         * psympriv.h (allocate_psymtab): Add comment.
3480         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3481         initializations.
3482         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3483
3484 2019-01-10  Tom Tromey  <tom@tromey.com>
3485
3486         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3487         Don't declare.
3488         * mipsread.c: Include mdebugread.h.
3489         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3490         Declare.
3491         * elfread.c: Include mdebugread.h.
3492
3493 2019-01-09  Tom Tromey  <tom@tromey.com>
3494
3495         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3496         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3497         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3498         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3499         (psym_lookup_symbol, psym_find_last_source_symtab)
3500         (psym_forget_cached_source_info, psym_print_stats)
3501         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3502         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3503         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3504         (psym_find_compunit_symtab_by_address)
3505         (maintenance_print_psymbols, maintenance_info_psymtabs)
3506         (maintenance_check_psymtabs): Use ranged for.
3507         * psymtab.h (class objfile_psymtabs): New.
3508         (require_partial_symbols): Return objfile_psymtabs.
3509         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3510
3511 2019-01-09  Tom Tromey  <tom@tromey.com>
3512
3513         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3514         (find_pc_mapped_section, list_overlays_command)
3515         (map_overlay_command, unmap_overlay_command)
3516         (simple_overlay_update): Use all_objfiles.
3517         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3518         * printcmd.c (info_symbol_command): Use all_objfiles.
3519         * objfiles.h (ALL_OBJSECTIONS): Remove.
3520         * maint.c (maintenance_translate_address): Use all_objfiles.
3521         * gcore.c (gcore_create_callback): Use all_objfiles.
3522         (objfile_find_memory_regions): Likewise.
3523
3524 2019-01-09  Tom Tromey  <tom@tromey.com>
3525
3526         * symtab.c (find_line_symtab, info_sources_command)
3527         (make_source_files_completion_list): Use objfile_compunits.
3528         * source.c (select_source_symtab): Use objfile_compunits.
3529         * objfiles.h (struct objfile): Update comment.
3530         (ALL_OBJFILES): Remove.
3531         (ALL_FILETABS): Remove.
3532         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3533         objfile_compunits.
3534
3535 2019-01-09  Tom Tromey  <tom@tromey.com>
3536
3537         * symmisc.c (print_objfile_statistics, dump_objfile)
3538         (maintenance_print_symbols): Use compunit_filetabs.
3539         * source.c (forget_cached_source_info_for_objfile): Use
3540         compunit_filetabs.
3541         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3542         (ALL_FILETABS): Use compunit_filetabs.
3543         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3544         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3545
3546 2019-01-09  Tom Tromey  <tom@tromey.com>
3547
3548         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3549         (compunit_filetabs): New.
3550         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3551         compunit_filetabs.
3552         (info_sources_command, make_source_files_completion_list): Remove
3553         declaration.
3554         * symmisc.c (print_objfile_statistics, dump_objfile)
3555         (maintenance_print_symbols): Remove declaration.
3556         (maintenance_info_symtabs): Use compunit_filetabs.
3557         (maintenance_info_line_tables): Likewise.
3558         * source.c (select_source_symtab): Change local variable name.
3559         (forget_cached_source_info_for_objfile): Remove declaration.
3560         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3561         * objfiles.c (objfile_relocate1): Remove declaration.
3562         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3563         declaration.
3564         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3565         * coffread.c (coff_symtab_read): Remove declaration.
3566         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3567         compunit_filetabs.
3568
3569 2019-01-09  Tom Tromey  <tom@tromey.com>
3570
3571         * symtab.c (lookup_objfile_from_block)
3572         (find_pc_sect_compunit_symtab, search_symbols)
3573         (default_collect_symbol_completion_matches_break_on): Use
3574         objfile_compunits.
3575         * objfiles.h (ALL_COMPUNITS): Remove.
3576         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3577         * cp-support.c (add_symbol_overload_list_qualified): Use
3578         objfile_compunits.
3579         * ada-lang.c (ada_collect_symbol_completion_matches)
3580         (ada_add_global_exceptions): Use objfile_compunits.
3581
3582 2019-01-09  Tom Tromey  <tom@tromey.com>
3583
3584         * source.c (select_source_symtab)
3585         (forget_cached_source_info_for_objfile): Remove declaration.
3586         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3587         declaration.
3588         * maint.c (count_symtabs_and_blocks): Remove declaration.
3589         * cp-support.c (add_symbol_overload_list_qualified): Remove
3590         declaration.
3591         * coffread.c (coff_symtab_read): Remove declaration.
3592         * symtab.c (lookup_symbol_in_objfile_symtabs)
3593         (basic_lookup_transparent_type_1): Use objfile_compunits.
3594         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3595         (info_sources_command, search_symbols)
3596         (default_collect_symbol_completion_matches_break_on)
3597         (make_source_files_completion_list): Remove declaration.
3598         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3599         (ada_collect_symbol_completion_matches)
3600         (ada_add_global_exceptions): Remove declaration.
3601         * linespec.c (iterate_over_all_matching_symtabs): Use
3602         objfile_compunits.
3603         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3604         (class objfile_compunits): New.
3605         (ALL_COMPUNITS): Use objfile_compunits.
3606         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3607         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3608         objfile_compunits.
3609         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3610
3611 2019-01-09  Tom Tromey  <tom@tromey.com>
3612
3613         * symtab.c (search_symbols)
3614         (default_collect_symbol_completion_matches_break_on): Use
3615         objfile_msymbols.
3616         * ada-lang.c (ada_lookup_simple_minsym)
3617         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3618         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3619         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3620         objfile_msymbols.
3621         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3622         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3623         * objc-lang.c (find_methods): Use objfile_msymbols.
3624         (info_selectors_command, info_classes_command): Likewise.
3625         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3626         * objfiles.h (class objfile_msymbols): New.
3627         (ALL_OBJFILE_MSYMBOLS): Remove.
3628         (ALL_MSYMBOLS): Remove.
3629
3630 2019-01-09  Tom Tromey  <tom@tromey.com>
3631
3632         * common/next-iterator.h (next_adapter): Add Iterator template
3633         parameter.
3634         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3635         (class all_objfiles_safe): New.
3636         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3637         * objfiles.c (put_objfile_before): Update comment.
3638         (add_separate_debug_objfile): Likewise.
3639         (free_all_objfiles): Use all_objfiles_safe.
3640         (objfile_purge_solibs): Likewise.
3641
3642 2019-01-09  Tom Tromey  <tom@tromey.com>
3643
3644         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3645         (expand_symtab_containing_pc, lookup_static_symbol)
3646         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3647         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3648         all_objfiles.
3649         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3650         * breakpoint.c (create_overlay_event_breakpoint)
3651         (create_longjmp_master_breakpoint)
3652         (create_std_terminate_master_breakpoint)
3653         (create_exception_master_breakpoint): Use all_objfiles.
3654         * linux-thread-db.c (try_thread_db_load_from_pdir)
3655         (has_libpthread): Use all_objfiles.
3656         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3657         * linespec.c (iterate_over_all_matching_symtabs)
3658         (search_minsyms_for_name): Use all_objfiles.
3659         * maint.c (maintenance_info_sections): Use all_objfiles.
3660         * main.c (captured_main_1): Use all_objfiles.
3661         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3662         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3663         * guile/scm-pretty-print.c
3664         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3665         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3666         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3667         (maintenance_print_msymbols): Use all_objfiles.
3668         * source.c (select_source_symtab): Use all_objfiles.
3669         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3670         * symfile.c (remove_symbol_file_command)
3671         (expand_symtabs_matching, map_symbol_filenames): Use
3672         all_objfiles.
3673         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3674         all_objfiles.
3675         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3676         * objc-lang.c (find_methods): Use all_objfiles.
3677         * objfiles.c (have_partial_symbols, have_full_symbols)
3678         (have_minimal_symbols, qsort_cmp)
3679         (default_iterate_over_objfiles_in_search_order): Use
3680         all_objfiles.
3681         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3682         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3683         (maintenance_check_psymtabs): Use all_objfiles.
3684         (ALL_PSYMTABS): Remove.
3685         * compile/compile-object-run.c (do_module_cleanup): Use
3686         all_objfiles.
3687         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3688         * cp-support.c (add_symbol_overload_list_qualified): Use
3689         all_objfiles.
3690         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3691         Use all_objfiles.
3692         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3693         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3694         all_objfiles.
3695         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3696         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3697         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3698         Uses all_objfiles.
3699         * solib.c (solib_read_symbols): Use all_objfiles
3700
3701 2019-01-09  Tom Tromey  <tom@tromey.com>
3702
3703         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3704         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3705         all_objfiles.
3706         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3707         * symmisc.c (print_symbol_bcache_statistics)
3708         (print_objfile_statistics, maintenance_print_objfiles)
3709         (maintenance_info_symtabs, maintenance_check_symtabs)
3710         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3711         all_objfiles.
3712         * source.c (forget_cached_source_info): Use all_objfiles.
3713         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3714         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3715         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3716         * objfiles.c (update_section_map): Use all_objfiles.
3717         (shared_objfile_contains_address_p): Likewise.
3718         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3719         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3720
3721 2019-01-09  Tom Tromey  <tom@tromey.com>
3722
3723         * common/next-iterator.h: New file.
3724         * objfiles.h (class all_objfiles): New.
3725         (struct objfile_iterator): New.
3726
3727 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3728
3729         * NEWS: Move the description of the changed "frame", "select-frame",
3730          and "info frame" commands to the Changed commands section.
3731
3732 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3733
3734         * gdbtypes.c (check_stub_method_group): Remove handling of old
3735         mangling schemes.
3736         * linespec.c (find_methods): Likewise.
3737         * stabsread.c (read_member_functions): Likewise.
3738         * valops.c (search_struct_method): Likewise.
3739         (value_struct_elt_for_reference): Likewise.
3740         * NEWS: Mention this change.
3741
3742 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3743
3744         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3745         print_source_lines.
3746         * source.c (print_source_lines_base): Update line number check.
3747         (print_source_lines): New function.
3748         (source_lines_range::source_lines_range): New function.
3749         * source.h (class source_lines_range): New class.
3750         (print_source_lines): New declaration.
3751
3752 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3753
3754         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3755
3756 2019-01-08  Tom Tromey  <tom@tromey.com>
3757             Simon Marchi  <simon.marchi@ericsson.com>
3758
3759         PR gdb/24060
3760         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3761         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3762         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3763         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3764         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3765         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3766
3767 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3768
3769         * source.c (select_source_symtab): Move header comment to
3770         declaration in source.h.
3771         (forget_cached_source_info_for_objfile): Likewise.
3772         (forget_cached_source_info): Likewise.
3773         (identify_source_line): Likewise.
3774         * source.h (identify_source_line): Move declaration from symtab.h
3775         and add comment from source.c
3776         (print_source_lines): Likewise.
3777         (forget_cached_source_info_for_objfile): Likewise.
3778         (forget_cached_source_info): Likewise.
3779         (select_source_symtab): Likewise.
3780         (enum print_source_lines_flag): Move definition from symtab.h.
3781         * symtab.h (identify_source_line): Move declaration to source.h.
3782         (print_source_lines): Likewise.
3783         (forget_cached_source_info_for_objfile): Likewise.
3784         (forget_cached_source_info): Likewise.
3785         (select_source_symtab): Likewise.
3786         (enum print_source_lines_flag): Move definition to source.h.
3787         * tui/tui-hooks.c: Add 'source.h' include.
3788
3789 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3790
3791         * source.c (print_source_lines_base): Handle requests to print
3792         reverse line number sequences, and guard against empty lines
3793         string.
3794
3795 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3796
3797         * source.c (print_source_lines_base): Fix skip of '\r' if next
3798         character is '\n'.
3799
3800 2019-01-06  Tom Tromey  <tom@tromey.com>
3801
3802         * c-exp.y (struct c_parse_state) <macro_original_text,
3803         expansion_obstack>: New member.
3804         (macro_original_text, expansion_obstack): Remove globals.
3805         (scan_macro_expansion, scanning_macro_expansion)
3806         (finished_macro_expansion): Update.
3807         (scan_macro_cleanup): Remove.
3808         (yylex, c_parse): Update.
3809
3810 2019-01-06  Tom Tromey  <tom@tromey.com>
3811
3812         * c-exp.y (struct c_parse_state) <strings>: New member.
3813         (operator_stoken): Update.
3814
3815 2019-01-06  Tom Tromey  <tom@tromey.com>
3816
3817         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3818         (union type_stack_elt) <typelist_val>: Now a pointer to
3819         std::vector.
3820         (type_stack_cleanup): Don't declare.
3821         (push_typelist): Update.
3822         * parse.c (pop_typelist): Return a std::vector.
3823         (push_typelist): Take a std::vector.
3824         (follow_types): Update.  Do not free args.
3825         (type_stack_cleanup): Remove.
3826         * c-exp.y (struct c_parse_state): New.
3827         (cpstate): New global.
3828         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3829         (nonempty_typelist): Update.
3830         (func_mod): Create a new vector.
3831         (c_parse): Create a c_parse_state.
3832         (check_parameter_typelist): Do not delete params.
3833         (function_method): Update.  Do not delete type_list.
3834
3835 2019-01-06  Tom Tromey  <tom@tromey.com>
3836
3837         PR gdb/28155:
3838         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3839         check_typedef.
3840         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3841         (print_return_value): Likewise.
3842
3843 2019-01-05  Tom Tromey  <tom@tromey.com>
3844
3845         * contrib/cleanup_check.py: Remove.
3846         * contrib/gcc-with-excheck: Remove.
3847         * contrib/exsummary.py: Remove.
3848         * contrib/excheck.py: Remove.
3849
3850 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3851
3852         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3853         NULL. Initialize tpprev to NULL instead of assigning it
3854         to NULL on the next statement.
3855         * windows-nat.c (windows_delete_thread): Remove check for
3856         main_thread_id before printing thread exit notifications.
3857         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3858         Remove thread ID check against main_thread_id.
3859         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3860         windows_delete_thread.
3861         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3862
3863 2019-01-04  Tom Tromey  <tom@tromey.com>
3864
3865         * compile/compile.c (_initialize_compile): Use upper case for
3866         metasyntactic variables.
3867         * symmisc.c (_initialize_symmisc): Use upper case for
3868         metasyntactic variables.
3869         * psymtab.c (_initialize_psymtab): Use upper case for
3870         metasyntactic variables.
3871         * demangle.c (demangle_command): Use upper case for metasyntactic
3872         variables.
3873         (_initialize_demangler): Likewise.
3874         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3875         variables.
3876
3877 2019-01-03  Tom Tromey  <tom@tromey.com>
3878
3879         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3880
3881 2019-01-03  Tom Tromey  <tom@tromey.com>
3882
3883         * python/py-symtab.c (salpy_str): Update.
3884         (struct salpy_sal_object) <symtab>: Now a PyObject.
3885         (salpy_dealloc): Update.
3886         (del_objfile_sal): Use gdbpy_ref.
3887
3888 2019-01-03  Tom Tromey  <tom@tromey.com>
3889
3890         * python/py-type.c (convert_field): Use new_reference.  Return
3891         gdbpy_ref.
3892         (make_fielditem): Return gdbpy_ref.
3893         (typy_fields): Update.
3894         (typy_getitem): Update.
3895         (field_name): Return gdbpy_ref.  Use new_reference.
3896         (typy_iterator_iternext): Update.
3897
3898 2019-01-03  Tom Tromey  <tom@tromey.com>
3899
3900         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3901
3902 2019-01-03  Tom Tromey  <tom@tromey.com>
3903
3904         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3905         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3906         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3907         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3908         (pspy_set_type_printers): Likewise.
3909         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3910         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3911         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3912         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3913         (objfpy_set_type_printers): Likewise.
3914
3915 2019-01-03  Tom Tromey  <tom@tromey.com>
3916
3917         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3918         (gdbpy_print_stack): Use gdbpy_err_fetch.
3919         * python/python-internal.h (class gdbpy_err_fetch): New class.
3920         (class gdbpy_enter) <m_error_type, m_error_value,
3921         m_error_traceback>: Remove.
3922         <m_error>: New member.
3923         (gdbpy_exception_to_string): Don't declare.
3924         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3925         * python/py-value.c (convert_value_from_python): Use
3926         gdbpy_err_fetch.
3927         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3928         gdbpy_exception_to_string.
3929         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3930         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3931         gdbpy_err_fetch.
3932
3933 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3934
3935         * linux-nat.c (delete_lwp_cleanup): Delete.
3936         (struct lwp_deleter): New struct.
3937         (lwp_info_up): New typedef.
3938         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3939         lwp_info_up.
3940
3941 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3942
3943         * linux-fork.c (class scoped_switch_fork_info): New class.
3944         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3945
3946 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3947
3948         * valops.c (find_overload_match): Remove use of null_cleanup, and
3949         calls to do_cleanups.
3950
3951 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3952
3953         * compile/compile-cplus-types.c
3954         (compile_cplus_instance::decl_name): Handle changes to
3955         cp_func_name.
3956         * cp-support.c (cp_func_name): Update header comment, update
3957         return type.
3958         * cp-support.h (cp_func_name): Update return type in declaration.
3959         * valops.c (find_overload_match): Move temp_func local to top
3960         level of function and change its type.  Use temp_func to hold and
3961         delete temporary string obtained from cp_func_name.
3962
3963 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3964
3965         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3966         gdb::char_vector, remove cleanup, and update uses of `msg`.
3967
3968 2019-01-03  Jim Wilson  <jimw@sifive.com>
3969
3970         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3971
3972 2019-01-02  Tom Tromey  <tom@tromey.com>
3973
3974         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3975         (tdesc_parse_xml): Remove cleanups.
3976         * target-descriptions.h (make_cleanup_free_target_description):
3977         Don't declare.
3978         (target_desc_deleter): New struct.
3979         (target_desc_up): New typedef.
3980         * target-descriptions.c (target_desc_deleter::operator()): Rename
3981         from free_target_description.
3982         (make_cleanup_free_target_description): Remove.
3983
3984 2019-01-02  Tom Tromey  <tom@tromey.com>
3985
3986         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3987         constructor, destructor.
3988         (linespec_parser): Remove typedef.
3989         (~linespec_parser): Rename from linespec_parser_delete.
3990         (linespec_lex_to_end, linespec_complete_label)
3991         (linespec_complete): Update.
3992         (decode_line_full): Remove cleanups.
3993         (decode_line_1): Update.
3994
3995 2019-01-02  Tom Tromey  <tom@tromey.com>
3996
3997         * python/python-internal.h (inferior_to_inferior_object): Change
3998         return type.
3999         * python/py-exitedevent.c (create_exited_event_object): Update.
4000         * python/py-inferior.c (inferior_to_inferior_object): Return
4001         gdbpy_ref.
4002         (python_new_inferior, python_inferior_deleted)
4003         (thread_to_thread_object, delete_thread_object)
4004         (build_inferior_list, gdbpy_selected_inferior): Update.
4005         * python/py-infthread.c (create_thread_object): Update.  Also fail
4006         if inferior_to_inferior_object fails.
4007
4008 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4009
4010         * inferior.h (class inferior) <displaced_step_state>: New field.
4011         * infrun.h (struct displaced_step_state): Move here from
4012         infrun.c.  Initialize fields, add constructor.
4013         <inf>: Remove field.
4014         <reset>: New method.
4015         * infrun.c (struct displaced_step_inferior_state): Move to
4016         infrun.h.
4017         (displaced_step_inferior_states): Remove.
4018         (get_displaced_stepping_state): Adust.
4019         (displaced_step_in_progress_any_inferior): Adjust.
4020         (displaced_step_in_progress_thread): Adjust.
4021         (displaced_step_in_progress): Adjust.
4022         (add_displaced_stepping_state): Remove.
4023         (get_displaced_step_closure_by_addr): Adjust.
4024         (remove_displaced_stepping_state): Remove.
4025         (infrun_inferior_exit): Call displaced_step_state.reset.
4026         (use_displaced_stepping): Don't check for NULL.
4027         (displaced_step_prepare_throw): Call
4028         get_displaced_stepping_state.
4029         (displaced_step_fixup): Don't check for NULL.
4030         (prepare_for_detach): Don't check for NULL.
4031
4032 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4033
4034         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4035          in case of call that did not complete.
4036
4037 2019-01-02  Andrey Utkin  <autkin@undo.io>
4038
4039         * symfile.c (find_separate_debug_file): Fix search of debug files for
4040         remote debuggee.
4041
4042 2019-01-02  Tom Tromey  <tom@tromey.com>
4043
4044         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4045         indentation.
4046         * python/py-frame.c (frapy_older): Remove cast.
4047         (frapy_newer): Likewise.
4048         * python/py-breakpoint.c (local_setattro): Remove cast.
4049         * python/py-arch.c (archpy_name): Remove local variable.
4050         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4051
4052 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4053
4054         * unittests/basic_string_view/element_access/char/empty.cc:
4055         Fix year range in copyright header.
4056
4057 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4058
4059         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4060         Delete.
4061         <operator==>: Update with for removed field.
4062         <hash>: Likewise.
4063         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4064         <isa_features>: ...this.
4065         <abi_features>: New field.
4066         (riscv_isa_flen): Update comment.
4067         (riscv_abi_xlen): New declaration.
4068         (riscv_abi_flen): New declaration.
4069         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4070         isa_features.
4071         (riscv_abi_xlen): New function.
4072         (riscv_isa_flen): Update to get answer from isa_features.
4073         (riscv_abi_flen): New function.
4074         (riscv_has_fp_abi): Update to get answer from abi_features.
4075         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4076         xlen and flen.
4077         (riscv_call_info) <xlen, flen>: Update comment.
4078         (riscv_call_arg_struct): Remove invalid assertions
4079         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4080         is removed.
4081         (riscv_gdbarch_init): Gather isa features and abi features
4082         separately, ensure both match on the gdbarch when reusing an old
4083         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4084         a target with 64-bit float hardware.
4085
4086 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4087
4088         * source.c (search_command_helper): Stop reverse search
4089         when line 1 has been searched.
4090
4091 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4092
4093         * record-full.c (record_full_base_target::close): Rewrite
4094         record_full_core_buf_list free logic.
4095
4096 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4097
4098         * break-catch-syscall.c (print_one_catch_syscall): xfree
4099         the last text.
4100
4101 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4102
4103         * top.c (print_gdb_version): Update Copyright year in version
4104         message.
4105
4106 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4107
4108         Update copyright year range in all GDB files.
4109
4110 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4111
4112         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4113
4114 For older changes see ChangeLog-2018.
4115 \f
4116 Local Variables:
4117 mode: change-log
4118 left-margin: 8
4119 fill-column: 74
4120 version-control: never
4121 coding: utf-8
4122 End:
4123