gdb/ChangeLog

   1 2019-03-15  Tom Tromey  <tom@tromey.com>
   2
   3         * symtab.h (struct minimal_symbol): Derive from
   4         general_symbol_info.
   5         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
   6         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
   7         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
   8         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
   9         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
  10         (MSYMBOL_SEARCH_NAME): Update.
  11         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
  12         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
  13         * minsyms.c (minimal_symbol_reader::record_full): Update.
  14
  15 2019-03-15  Tom Tromey  <tom@tromey.com>
  16
  17         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
  18
  19 2019-03-15  Tom Tromey  <tom@tromey.com>
  20
  21         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
  22         unique_xmalloc_ptr.
  23         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
  24         Update.
  25         * minsyms.c (lookup_minimal_symbol_by_pc_section)
  26         (build_minimal_symbol_hash_tables)
  27         (minimal_symbol_reader::install): Update.
  28
  29 2019-03-15  Tom Tromey  <tom@tromey.com>
  30
  31         * symtab.c (create_demangled_names_hash): Update.
  32         (symbol_set_names): Update.
  33         * objfiles.h (struct objfile_per_bfd_storage)
  34         <demangled_names_hash>: Now an htab_up.
  35         * objfiles.c (objfile_per_bfd_storage): Simplify.
  36
  37 2019-03-15  Tom Tromey  <tom@tromey.com>
  38
  39         * objfiles.h (struct objfile_per_bfd_storage): Declare
  40         destructor.
  41         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
  42         New.
  43         (get_objfile_bfd_data): Use new.  Don't initialize
  44         language_of_main.
  45         (free_objfile_per_bfd_storage): Remove.
  46         (objfile_bfd_data_free, objfile::~objfile): Use delete.
  47
  48 2019-03-15  Tom Tromey  <tom@tromey.com>
  49
  50         * symfile.c (reread_symbols): Update.
  51         * objfiles.c (objfile::objfile): Update.
  52         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
  53         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
  54         comment.
  55         (minimal_symbol_reader::install): Update.
  56         (terminate_minimal_symbol_table): Remove.
  57         * jit.c (jit_object_close_impl): Update.
  58
  59 2019-03-15  Tom Tromey  <tom@tromey.com>
  60
  61         * minsyms.c (minimal_symbol_reader::record_full): Remove some
  62         initializations.
  63
  64 2019-03-15  Tom Tromey  <tom@tromey.com>
  65
  66         * objfiles.h (struct objfile_per_bfd_storage)
  67         <demangled_hash_languages>: Now a bitset.
  68         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
  69         (lookup_minimal_symbol): Update.
  70
  71 2019-03-15  Tom Tromey  <tom@tromey.com>
  72
  73         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
  74         Don't return the symbol.
  75         * coffread.c (record_minimal_symbol): Use record_full.
  76
  77 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
  78
  79         The MS-Windows port of ncurses fails to switch to a color pair if
  80         one or both of the colors are the implicit default colors.  This
  81         change records the default colors when TUI is initialized, and
  82         then specifies them explicitly when a color pair uses the default
  83         colors.  This allows color styling in TUI mode on MS-Windows.
  84
  85         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
  86         ncurses_norm_attr.
  87         (tui_initialize_io) [__MINGW32__]: Record the default terminal
  88         colors in ncurses_norm_attr.
  89         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
  90         "none", replace it with the default color recorded in
  91         ncurses_norm_attr.
  92
  93 2019-03-14  Tom Tromey  <tromey@adacore.com>
  94
  95         * source-cache.h (class source_cache) <get_source_lines>: Return
  96         std::string.
  97         * source-cache.c (source_cache::extract_lines): Handle case where
  98         first_pos==npos.  Return std::string.
  99         (source_cache::get_source_lines): Update.
 100
 101 2019-03-14  Tom Tromey  <tromey@adacore.com>
 102
 103         * NEWS: Add item for "style sources" commands.
 104         * source-cache.c (source_cache::get_source_lines): Check
 105         source_styling.
 106         * cli/cli-style.c (source_styling): New global.
 107         (_initialize_cli_style): Add "style sources" commands.
 108         (show_style_sources): New function.
 109         * cli/cli-style.h (source_styling): Declare.
 110
 111 2019-03-14  Pedro Alves  <palves@redhat.com>
 112             Tom Tromey  <tromey@adacore.com>
 113
 114         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 115         * tui/tui-winsource.c (tui_refill_source_window): New function,
 116         from...
 117         (tui_horizontal_source_scroll): ... here.  Move some logic.
 118         * cli/cli-style.c (set_style_enabled): Notify new observable.
 119         * tui/tui-hooks.c (tui_redisplay_source): New function.
 120         (tui_attach_detach_observers): Attach or detach
 121         tui_redisplay_source.
 122         * observable.h (source_styling_changed): New observable.
 123         * observable.c: Define source_styling_changed observable.
 124
 125 2019-03-13  Tom Tromey  <tromey@adacore.com>
 126
 127         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 128         (i386_gnu_nat_target::store_registers): Update.
 129         * target-debug.h (target_debug_print_std_string): New macro.
 130         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 131         * windows-tdep.c (display_one_tib): Update.
 132         * tui/tui-stack.c (tui_make_status_line): Update.
 133         * top.c (print_inferior_quit_action): Update.
 134         * thread.c (thr_try_catch_cmd): Update.
 135         (add_thread_with_info): Update.
 136         (thread_target_id_str): Update.
 137         (thr_try_catch_cmd): Update.
 138         (thread_command): Update.
 139         (thread_find_command): Update.
 140         * record-btrace.c (record_btrace_target::info_record)
 141         (record_btrace_resume_thread, record_btrace_target::resume)
 142         (record_btrace_cancel_resume, record_btrace_step_thread)
 143         (record_btrace_target::wait, record_btrace_target::wait)
 144         (record_btrace_target::wait, record_btrace_target::stop): Update.
 145         * progspace.c (print_program_space): Update.
 146         * process-stratum-target.c
 147         (process_stratum_target::thread_address_space): Update.
 148         * linux-fork.c (linux_fork_mourn_inferior)
 149         (detach_checkpoint_command, info_checkpoints_command)
 150         (linux_fork_context): Update.
 151         (linux_fork_detach): Update.
 152         (class scoped_switch_fork_info): Update.
 153         (delete_checkpoint_command): Update.
 154         * infrun.c (follow_fork_inferior): Update.
 155         (follow_fork_inferior): Update.
 156         (proceed_after_vfork_done): Update.
 157         (handle_vfork_child_exec_or_exit): Update.
 158         (follow_exec): Update.
 159         (displaced_step_prepare_throw): Update.
 160         (displaced_step_restore): Update.
 161         (start_step_over): Update.
 162         (resume_1): Update.
 163         (clear_proceed_status_thread): Update.
 164         (proceed): Update.
 165         (print_target_wait_results): Update.
 166         (do_target_wait): Update.
 167         (context_switch): Update.
 168         (stop_all_threads): Update.
 169         (restart_threads): Update.
 170         (finish_step_over): Update.
 171         (handle_signal_stop): Update.
 172         (switch_back_to_stepped_thread): Update.
 173         (keep_going_pass_signal): Update.
 174         (print_exited_reason): Update.
 175         (normal_stop): Update.
 176         * inferior.c (inferior_pid_to_str): Change return type.
 177         (print_selected_inferior): Update.
 178         (add_inferior): Update.
 179         (detach_inferior): Update.
 180         * dummy-frame.c (fprint_dummy_frames): Update.
 181         * dcache.c (dcache_info_1): Update.
 182         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 183         (btrace_fetch, btrace_clear): Update.
 184         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 185         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 186         type.
 187         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 188         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 189         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 190         * gdbarch.c, gdbarch.h: Rebuild.
 191         * gdbarch.sh (core_pid_to_str): Change return type.
 192         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 193         return type.
 194         (windows_nat_target::pid_to_str): Change return type.
 195         (windows_delete_thread): Update.
 196         (windows_nat_target::attach): Update.
 197         (windows_nat_target::files_info): Update.
 198         * target-delegates.c: Rebuild.
 199         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 200         return type.
 201         (sol_thread_target::pid_to_str): Change return type.
 202         * remote.c (class remote_target) <pid_to_str>: Change return
 203         type.
 204         (remote_target::pid_to_str): Change return type.
 205         (extended_remote_target::attach, remote_target::remote_stop_ns)
 206         (remote_target::remote_notif_remove_queued_reply)
 207         (remote_target::push_stop_reply, remote_target::disable_btrace):
 208         Update.
 209         (extended_remote_target::attach): Update.
 210         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 211         type.
 212         (gdbsim_target::pid_to_str): Change return type.
 213         * ravenscar-thread.c (struct ravenscar_thread_target)
 214         <pid_to_str>: Change return type.
 215         (ravenscar_thread_target::pid_to_str): Change return type.
 216         * procfs.c (class procfs_target) <pid_to_str>: Change return
 217         type.
 218         (procfs_target::pid_to_str): Change return type.
 219         (procfs_target::attach): Update.
 220         (procfs_target::detach): Update.
 221         (procfs_target::fetch_registers): Update.
 222         (procfs_target::store_registers): Update.
 223         (procfs_target::wait): Update.
 224         (procfs_target::files_info): Update.
 225         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 226         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 227         return type.
 228         (nto_procfs_target::pid_to_str): Change return type.
 229         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 230         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 231         return type.
 232         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 233         (exit_lwp): Update.
 234         (attach_proc_task_lwp_callback, get_detach_signal)
 235         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 236         (linux_nat_target::resume, wait_lwp, stop_callback)
 237         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 238         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 239         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 240         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 241         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 242         type.
 243         (inf_ptrace_target::attach): Update.
 244         (inf_ptrace_target::files_info): Update.
 245         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 246         type.
 247         (go32_nat_target::pid_to_str): Change return type.
 248         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 249         (gnu_nat_target::wait): Update.
 250         (gnu_nat_target::wait): Update.
 251         (gnu_nat_target::resume): Update.
 252         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 253         (fbsd_nat_target::wait): Update.
 254         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 255         type.
 256         (darwin_nat_target::attach): Update.
 257         * corelow.c (class core_target) <pid_to_str>: Change return type.
 258         (core_target::pid_to_str): Change return type.
 259         * target.c (normal_pid_to_str): Change return type.
 260         (default_pid_to_str): Likewise.
 261         (target_pid_to_str): Change return type.
 262         (target_translate_tls_address): Update.
 263         (target_announce_detach): Update.
 264         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 265         return type.
 266         (bsd_uthread_target::pid_to_str): Change return type.
 267         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 268         type.
 269         (bsd_kvm_target::pid_to_str): Change return type.
 270         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 271         return type.
 272         (aix_thread_target::pid_to_str): Change return type.
 273         * target.h (struct target_ops) <pid_to_str>: Change return type.
 274         (target_pid_to_str, normal_pid_to_str): Likewise.
 275         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 276         type.
 277         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 278         type.
 279         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 280         return type.
 281         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 282         type.
 283         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 284         type.
 285         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 286         return type.
 287
 288 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 289
 290         * NEWS: Mention that the new default MI version is 3.  Mention
 291         changes to the output of commands and events that deal with
 292         multi-location breakpoints.
 293         * breakpoint.c: Include "mi/mi-out.h".
 294         (print_one_breakpoint): Change output syntax if using MI version
 295         >= 3.
 296         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 297         New.
 298         (mi_multi_location_breakpoint_output_fixed): New.
 299         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 300         (mi_cmd_fix_multi_location_breakpoint_output): New.
 301         (mi_multi_location_breakpoint_output_fixed): New.
 302         * mi/mi-cmds.c (mi_cmds): Register command
 303         -fix-multi-location-breakpoint-output.
 304         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 305         interpreter "mi".
 306
 307 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 308
 309         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 310         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 311         instantiate mi_ui_out based on interpreter name.
 312         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 313         * mi/mi-main.c (mi_load_progress): Likewise.
 314
 315 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 316
 317         * NEWS: Combine separate "New targets" sections for 8.3.
 318
 319 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 320
 321         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 322         (ppcfbsd_init_abi): Install gdbarch
 323         "fetch_tls_load_module_address" and "get_thread_local_address"
 324         methods.
 325
 326 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 327
 328         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 329         (riscv_fbsd_init_abi): Install gdbarch
 330         "fetch_tls_load_module_address" and "get_thread_local_address"
 331         methods.
 332
 333 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 334
 335         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 336         (i386fbsd_init_abi): Install gdbarch
 337         "fetch_tls_load_module_address" and "get_thread_local_address"
 338         methods.
 339
 340 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 341
 342         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 343         (amd64fbsd_init_abi): Install gdbarch
 344         "fetch_tls_load_module_address" and "get_thread_local_address"
 345         methods.
 346
 347 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 348
 349         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 350         (struct fbsd_pspace_data): New type.
 351         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 352         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 353         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 354         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 355         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 356
 357 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 358
 359         * gdbtypes.c (lookup_struct_elt): New function.
 360         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 361         * gdbtypes.h (struct struct_elt): New type.
 362         (lookup_struct_elt): New prototype.
 363
 364 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 365
 366         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 367         remove disabled code block.
 368
 369 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 370
 371         * gdbarch.sh (get_thread_local_address): New method.
 372         * gdbarch.h, gdbarch.c: Regenerate.
 373         * target.c (target_translate_tls_address): Use
 374         gdbarch_get_thread_local_address if present instead of
 375         target::get_thread_local_address.
 376
 377 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 378
 379         * target.h (target::get_thread_local_address): Update comment.
 380
 381 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 382
 383         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 384         objfile->separate_debug_objfile_backlink if not NULL.
 385
 386 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 387
 388         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 389         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 390         (amd64bsd_store_inferior_registers): Likewise.
 391         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 392         Enable segment base registers.
 393         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 394         PT_GETFSBASE and PT_GETGSBASE.
 395         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 396         PT_SETGSBASE.
 397         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 398         segment base registers.
 399         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 400
 401 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 402
 403         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 404         Update calls to i386_target_description to add 'segments'
 405         parameter.
 406         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 407         add segment base registers.
 408         * arch/i386.c (i386_create_target_description): Add 'segments'
 409         parameter to enable segment base registers.
 410         * arch/i386.h (i386_create_target_description): Likewise.
 411         * features/i386/32bit-segments.xml: New file.
 412         * features/i386/32bit-segments.c: Generate.
 413         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 414         call to i386_target_description to add 'segments' parameter.
 415         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 416         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 417         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 418         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 419         if feature is present.
 420         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 421         Add 'segments' parameter to call to i386_target_description.
 422         (i386_target_description): Add 'segments' parameter to enable
 423         segment base registers.
 424         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 425         to call to i386_target_description.
 426         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 427         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 428         Define I386_NUM_REGS.
 429         (i386_target_description): Add 'segments' parameter to enable
 430         segment base registers.
 431
 432 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 433
 434         PR/24325
 435         * source-cache.c: #undef open and close, to avoid unresolved
 436         externals during linking.
 437
 438 2019-03-12  Tom Tromey  <tromey@adacore.com>
 439
 440         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 441         const.  Add initializers.
 442         (_initialize_remote): Don't initialize ptid globals.
 443
 444 2019-03-12  Pedro Alves  <palves@redhat.com>
 445
 446         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 447
 448 2019-03-12  Pedro Alves  <palves@redhat.com>
 449
 450         * cp-name-parser.y (main): Remove unused 'len' variable.
 451
 452 2019-03-12  Tom Tromey  <tromey@adacore.com>
 453
 454         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 455         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 456
 457 2019-03-12  Tom Tromey  <tromey@adacore.com>
 458
 459         * linux-nat.c (iterate_over_lwps): Update.
 460         (stop_callback): Remove parameter.
 461         (stop_wait_callback, detach_callback, resume_set_callback)
 462         (select_singlestep_lwp_callback, set_ignore_sigint)
 463         (status_callback, resumed_callback, resume_clear_callback)
 464         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 465         data parameter.
 466         (linux_nat_target::detach, linux_nat_target::resume)
 467         (linux_stop_and_wait_all_lwps, select_event_lwp)
 468         (linux_nat_filter_event, linux_nat_wait_1)
 469         (linux_nat_target::kill, linux_nat_target::stop)
 470         (linux_nat_target::stop): Update.
 471         (linux_nat_resume_callback): Change type.
 472         (resume_stopped_resumed_lwps, count_events_callback)
 473         (select_event_lwp_callback): Likewise.
 474         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 475         * arm-linux-nat.c (struct update_registers_data): Remove.
 476         (update_registers_callback): Change type.
 477         (arm_linux_insert_hw_breakpoint1): Update.
 478         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 479         parameter.
 480         (x86_linux_dr_set_addr): Update.
 481         (x86_linux_dr_set_control): Update.
 482         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 483         (iterate_over_lwps): Use gdb::function_view.
 484         * nat/aarch64-linux-hw-point.c (struct
 485         aarch64_dr_update_callback_param): Remove.
 486         (debug_reg_change_callback): Change type.
 487         (aarch64_notify_debug_reg_change): Update.
 488         * s390-linux-nat.c (s390_refresh_per_info): Update.
 489
 490 2019-03-11  Tom Tromey  <tromey@adacore.com>
 491
 492         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 493         redundant assignment to "this_cu".
 494
 495 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 496
 497         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 498
 499 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 500
 501         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 502         from...
 503         (rank_one_type): ... this.
 504
 505 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 506
 507         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 508         from...
 509         (rank_one_type): ... this.
 510
 511 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 512
 513         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 514         from...
 515         (rank_one_type): ... this.
 516
 517 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 518
 519         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 520         from...
 521         (rank_one_type): ... this.
 522
 523 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 524
 525         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 526         from...
 527         (rank_one_type): ... this.
 528
 529 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 530
 531         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 532         from...
 533         (rank_one_type): ... this.
 534
 535 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 536
 537         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 538         from...
 539         (rank_one_type): ... this.
 540
 541 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 542
 543         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 544         from...
 545         (rank_one_type): ... this.
 546
 547 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 548
 549         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 550         from...
 551         (rank_one_type): ... this.
 552
 553 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 554
 555         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 556         from...
 557         (rank_one_type): ... this.
 558
 559 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 560
 561         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 562         from...
 563         (rank_one_type): ... this.
 564
 565 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 566
 567         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 568         from...
 569         (rank_one_type): ... this.
 570
 571 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 572
 573         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 574         inferior-events' shows the example events.
 575
 576 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 577
 578         Support styling on native MS-Windows console
 579
 580         PR/24315
 581         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 582         on MS-Windows if $TERM is not defined.
 583
 584         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 585
 586         * posix-hdep.c (gdb_console_fputs):
 587         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 588         functions.
 589         * ui-file.h (gdb_console_fputs): Add prototype.
 590
 591         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 592         back to fputs only if the former returns zero.
 593
 594 2019-03-07  Tom Tromey  <tom@tromey.com>
 595
 596         * symmisc.c (print_symbol_bcache_statistics): Update.
 597         (print_objfile_statistics): Update.
 598         * symfile.c (allocate_symtab): Update.
 599         * stabsread.c: Don't include bcache.h.
 600         * psymtab.h (struct psymbol_bcache): Don't declare.
 601         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 602         (psymbol_bcache_init, psymbol_bcache_free)
 603         (psymbol_bcache_get_bcache): Don't declare.
 604         * psymtab.c (struct psymbol_bcache): Remove.
 605         (psymtab_storage::psymtab_storage): Update.
 606         (psymtab_storage::~psymtab_storage): Update.
 607         (psymbol_bcache_init, psymbol_bcache_free)
 608         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 609         (add_psymbol_to_bcache): Update.
 610         (allocate_psymtab): Update.
 611         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 612         macro_cache>: No longer pointers.
 613         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 614         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 615         * macrotab.c (macro_bcache): Update.
 616         * macroexp.c: Don't include bcache.h.
 617         * gdbtypes.c (check_types_worklist): Update.
 618         (types_deeply_equal): Remove TRY/CATCH.  Update.
 619         * elfread.c (elf_symtab_read): Update.
 620         * dwarf2read.c: Don't include bcache.h.
 621         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 622         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 623         (print_bcache_statistics, bcache_memory_used): Don't declare.
 624         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 625         methods.  Rename all data members.
 626         * bcache.c (struct bcache): Move to bcache.h.
 627         (bcache::expand_hash_table): Rename from expand_hash_table.
 628         (bcache): Remove.
 629         (bcache::insert): Rename from bcache_full.
 630         (bcache::compare): Rename from bcache_compare.
 631         (bcache_xmalloc): Remove.
 632         (bcache::~bcache): Rename from bcache_xfree.
 633         (bcache::print_statistics): Rename from print_bcache_statistics.
 634         (bcache::memory_used): Rename from bcache_memory_used.
 635
 636 2019-03-07  Pedro Alves  <palves@redhat.com>
 637
 638         * infrun.c (normal_stop): Also check for
 639         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 640
 641 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 642
 643         * f-lang.c (value_from_host_double): Moved to...
 644         * value.c (value_from_host_double): ...here.
 645         * value.h (value_from_host_double): Declare.
 646         * guile/scm-math.c (vlscm_convert_typed_number): Use
 647         value_from_host_double.
 648         (vlscm_convert_number): Likewise.
 649         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 650         * python/py-value.c (convert_value_from_python): Likewise.
 651
 652 2019-03-06  Tom Tromey  <tom@tromey.com>
 653
 654         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 655
 656 2019-03-06  Tom Tromey  <tom@tromey.com>
 657
 658         * utils.h (free_current_contents): Don't declare.
 659         * utils.c (free_current_contents): Remove.
 660
 661 2019-03-06  Tom Tromey  <tom@tromey.com>
 662
 663         * top.c (quit_force): Update.
 664         * main.c (captured_command_loop): Update.
 665         * common/new-op.c (operator new): Update.
 666         * common/common-exceptions.c (struct catcher)
 667         <save_cleanup_chain>: Remove member.
 668         (exceptions_state_mc_init): Update.
 669         (exception_try_scope_entry): Return nullptr.
 670         (exception_try_scope_exit, exception_rethrow)
 671         (throw_exception_sjlj, throw_exception_cxx): Update.
 672         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 673         (all_cleanups, do_cleanups, discard_cleanups)
 674         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 675         (restore_cleanups, restore_final_cleanups): Don't declare.
 676         (do_final_cleanups): Remove parameter.
 677         * common/cleanups.c (cleanup_chain, make_cleanup)
 678         (make_cleanup_dtor, all_cleanups, do_cleanups)
 679         (discard_my_cleanups, discard_cleanups)
 680         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 681         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 682         (null_cleanup): Remove.
 683         (do_final_cleanups): Remove parameter.
 684
 685 2019-03-06  Tom Tromey  <tom@tromey.com>
 686
 687         * remote.c (remote_target::remote_parse_stop_reply): Use
 688         unique_xmalloc_ptr.
 689
 690 2019-03-06  Tom Tromey  <tom@tromey.com>
 691
 692         * stabsread.c (struct stabs_field_info): Rename from field_info.
 693         <list, fnlist>: Add initializers.
 694         <obstack>: New member.
 695         (read_member_functions, read_struct_fields, read_baseclasses):
 696         Allocate on obstack.  Don't use cleanups.
 697         (read_one_struct_field, read_member_functions, read_struct_fields)
 698         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 699         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 700         (read_struct_type): Update.
 701
 702 2019-03-06  Tom Tromey  <tom@tromey.com>
 703
 704         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 705         * common/filestuff.h (make_cleanup_close): Don't declare.
 706         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 707         Remove.
 708
 709 2019-03-06  Tom Tromey  <tom@tromey.com>
 710
 711         * solib-aix.c: Use make_scope_exit.
 712
 713 2019-03-06  Tom Tromey  <tom@tromey.com>
 714
 715         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 716         Use make_scope_exit.
 717
 718 2019-03-06  Tom Tromey  <tom@tromey.com>
 719
 720         * solib-svr4.c (disable_probes_interface): Remove parameter.
 721         (svr4_handle_solib_event): Use make_scope_exit.
 722
 723 2019-03-06  Tom Tromey  <tom@tromey.com>
 724
 725         * remote.c (struct stop_reply_deleter): Remove.
 726         (stop_reply_up): Update.
 727         (struct stop_reply): Derive from notif_event.  Don't typedef.
 728         <regcache>: Now a std::vector.
 729         (stop_reply_xfree): Remove.
 730         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 731         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 732         (remote_target::discard_pending_stop_replies): Use delete.
 733         (remote_target::remote_parse_stop_reply): Update.
 734         (remote_target::process_stop_reply): Update.
 735         * remote-notif.h (struct notif_event): Add virtual destructor.
 736         Remove "dtr" member.
 737         (struct notif_client) <alloc_event>: Return a unique_ptr.
 738         (notif_event_xfree): Don't declare.
 739         (notif_event_up): New typedef.
 740         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 741         (notif_event_xfree, do_notif_event_xfree): Remove.
 742         (remote_notif_state_xfree): Update.
 743
 744 2019-03-06  Tom Tromey  <tom@tromey.com>
 745
 746         * infrun.c (displaced_step_clear_cleanup): Now a
 747         forward_scope_exit type.
 748         (displaced_step_prepare_throw): Update.
 749         (displaced_step_fixup): Update.
 750
 751 2019-03-06  Tom Tromey  <tom@tromey.com>
 752
 753         * inferior.h (class inferior): Update comment.
 754         * gdbthread.h (class thread_info): Update comment.
 755
 756 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 757             Tom Tromey  <tom@tromey.com>
 758
 759         * stabsread.h (struct stab_section_list): Remove.
 760         (coffstab_build_psymtabs): Update.
 761         * dbxread.c (symbuf_sections): Now a std::vector.
 762         (sect_idx): New global.
 763         (fill_symbuf): Update.
 764         (coffstab_build_psymtabs): Change type of stabsects parameter.
 765         Update.
 766         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 767         std::vector.
 768         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 769         (coff_locate_sections): Update.
 770         (coff_symfile_read): Remove cleanups.  Update.
 771         (init_stringtab): Add storage parameter.
 772         (free_stringtab, free_stringtab_cleanup): Remove.
 773         (init_lineno): Add storage parameter.
 774         (free_linetab, free_linetab_cleanup): Remove.
 775
 776 2019-03-06  Pedro Alves  <palves@redhat.com>
 777
 778         * linux-fork.c (fork_info::clobber_regs): Delete.
 779         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 780         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 781         comment.  Adjust.
 782         (scoped_switch_fork_info::scoped_switch_fork_info)
 783         (checkpoint_command, linux_fork_context): Adjust
 784         fork_save_infrun_state calls.
 785
 786 2019-03-06  Pedro Alves  <palves@redhat.com>
 787
 788         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 789         (inf_has_multiple_threads): Return 'bool' and rewrite using
 790         inferior_info::threads().
 791
 792 2019-03-06  Pedro Alves  <palves@redhat.com>
 793
 794         * linux-fork.c: Include <list>.
 795         (fork_list): Now a std::list instance.
 796         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 797         (forks_exist_p, find_last_fork): Adjust.
 798         (new_fork): Delete.
 799         (one_fork_p): New.
 800         (add_fork): Adjust.
 801         (free_fork): Delete, folded into fork_info::~fork_info().
 802         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 803         Adjust.
 804         (init_fork_list): Delete.
 805         (linux_fork_killall, linux_fork_mourn_inferior)
 806         (linux_fork_detach, info_checkpoints_command): Adjust.
 807         (_initialize_linux_fork): No longer call init_fork_list.
 808
 809 2019-03-06  Pedro Alves  <palves@redhat.com>
 810
 811         * linux-fork.c (new_fork): New, split out of ...
 812         (add_fork): ... this.  Return void.  Move "first fork" special
 813         case from here, to ...
 814         (checkpoint_command): ... here.
 815         * linux-linux.h (add_fork): Return void.
 816
 817 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 818
 819         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 820
 821 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 822             Chris January  <chris.january@arm.com>
 823             David Lecomber  <david.lecomber@arm.com>
 824
 825         * f-exp.y: New token, UNOP_INTRINSIC.
 826         (exp): New pattern using UNOP_INTRINSIC token.
 827         (f77_keywords): Add 'abs' keyword.
 828         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 829         (value_from_host_double): New function.
 830         (evaluate_subexp_f): Support UNOP_ABS.
 831
 832 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 833
 834         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 835         types.
 836
 837 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 838
 839         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 840         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 841         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 842
 843 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 844
 845         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 846
 847 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 848             Chris January  <chris.january@arm.com>
 849
 850         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 851         * f-exp.y: Define 'KIND' token.
 852         (exp): New pattern for KIND expressions.
 853         (ptype): Handle types with a kind extension.
 854         (direct_abs_decl): Extend to spot kind extensions.
 855         (f77_keywords): Add 'kind' to the list.
 856         (push_kind_type): New function.
 857         (convert_to_kind_type): New function.
 858         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 859         * parse.c (operator_length_standard): Likewise.
 860         * parser-defs.h (enum type_pieces): Add tp_kind.
 861         * std-operator.def: Add UNOP_KIND.
 862
 863 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 864
 865         * f-exp.y (f_parse): Set yydebug.
 866
 867 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 868
 869         * f-lang.c (evaluate_subexp_f): New function.
 870         (exp_descriptor_f): New global.
 871         (f_language_defn): Use exp_descriptor_f instead of
 872         exp_descriptor_standard.
 873
 874 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 875
 876         * f-exp.y (struct token): Add comments.
 877         (dot_ops): Remove uppercase versions and the end marker.
 878         (f77_keywords): Likewise.
 879         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 880         entries in the dot_ops array are case insensitive, and use
 881         strncasecmp to compare strings.  Also some whitespace cleanup in
 882         this area.  Similar for the f77_keywords array, except entries in
 883         this list might be case sensitive.
 884
 885 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 886
 887         * f-exp.y (struct f77_boolean_val): Add comments.
 888         (boolean_values): Remove uppercase versions, and end marker.
 889         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 890         and use strncasecmp to achieve case insensitivity.  Additionally,
 891         perform whitespace cleanup around this code.
 892
 893 2019-03-06  Tom Tromey  <tromey@adacore.com>
 894
 895         * remote-sim.c (gdbsim_target_open): Use result of
 896         gdb_argv::release.
 897
 898 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 899         Dirk Schubert  <dirk.schubert@arm.com>
 900         Chris January  <chris.january@arm.com>
 901
 902         * eval.c (evaluate_subexp_standard): Call Fortran argument
 903         wrapping logic.
 904         * f-lang.c (struct value): A value which can be passed into a
 905         Fortran function call.
 906         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 907         where appropriate.
 908         (struct type): Value ready for a Fortran function call.
 909         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 910         is needed.
 911         * f-lang.h (fortran_argument_convert): Declaration.
 912         (fortran_preserve_arg_pointer): Declaration.
 913         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 914
 915 2019-03-05  Tom Tromey  <tromey@adacore.com>
 916
 917         * python/py-prettyprint.c (print_string_repr): Remove #if.
 918         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 919
 920 2019-03-05  Tom Tromey  <tromey@adacore.com>
 921
 922         * target.c (the_dummy_target): Move later.  Change type to
 923         "dummy_target".
 924         (initialize_targets): Don't initialize the_dummy_target.
 925
 926 2019-03-05  Tom Tromey  <tromey@adacore.com>
 927
 928         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 929         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 930
 931 2019-03-05  Tom Tromey  <tromey@adacore.com>
 932
 933         * windows-nat.c (windows_nat_target::attach)
 934         (windows_nat_target::detach): Don't call gdb_flush.
 935         * valprint.c (generic_val_print, val_print, val_print_string):
 936         Don't call gdb_flush.
 937         * utils.c (defaulted_query): Don't call gdb_flush.
 938         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 939         * target.c (target_announce_detach): Don't call gdb_flush.
 940         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 941         * remote.c (extended_remote_target::attach): Don't call
 942         gdb_flush.
 943         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 944         * printcmd.c (do_examine): Don't call gdb_flush.
 945         (info_display_command): Don't call gdb_flush.
 946         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 947         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 948         * memattr.c (info_mem_command): Don't call gdb_flush.
 949         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 950         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 951         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 952         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 953         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 954         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 955         (gnu_nat_target::detach): Don't call gdb_flush.
 956         * f-valprint.c (f_val_print): Don't call gdb_flush.
 957         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 958         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 959         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 960         gdb_flush.
 961         * c-valprint.c (c_val_print): Don't call gdb_flush.
 962         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 963
 964 2019-03-05  Tom Tromey  <tromey@adacore.com>
 965
 966         * varobj.c (update_dynamic_varobj_children): Update.
 967         (install_default_visualizer): Use reset, not release.
 968         * value.c (set_internalvar): Update.
 969         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 970         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 971         ATTRIBUTE_UNUSED_RESULT.
 972
 973 2019-03-05  Tom Tromey  <tromey@adacore.com>
 974
 975         * remote.c (class scoped_remote_fd) <release>: Add
 976         ATTRIBUTE_UNUSED_RESULT.
 977
 978 2019-03-05  Tom Tromey  <tromey@adacore.com>
 979
 980         * macroexp.c (struct macro_buffer) <release>: Add
 981         ATTRIBUTE_UNUSED_RESULT.
 982
 983 2019-03-05  Tom Tromey  <tromey@adacore.com>
 984
 985         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 986         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 987         ATTRIBUTE_UNUSED_RESULT.
 988
 989 2019-03-05  Tom Tromey  <tromey@adacore.com>
 990
 991         * common/scoped_fd.h (class scoped_fd) <release>: Add
 992         ATTRIBUTE_UNUSED_RESULT.
 993
 994 2019-03-05  Tom Tromey  <tromey@adacore.com>
 995
 996         * parser-defs.h (struct parser_state) <release>: Add
 997         ATTRIBUTE_UNUSED_RESULT.
 998
 999 2019-03-05  Tom Tromey  <tromey@adacore.com>
1000
1001         * utils.h (class gdb_argv) <release>: Add
1002         ATTRIBUTE_UNUSED_RESULT.
1003         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1004
1005 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1006
1007         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1008         for-loop range, to avoid compiler warnings.
1009
1010         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1011         avoid compiler warnings about unused variables.
1012
1013         * NEWS: Mention end of support for native debugging on MS-Windows
1014         before XP.
1015
1016         PR gdb/24292
1017         * common/netstuff.c:
1018         * gdbserver/gdbreplay.c
1019         * gdbserver/remote-utils.c:
1020         * ser-tcp.c:
1021         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1022         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1023         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1024         'getaddrinfo' and 'freeaddrinfo' were not available before
1025         Windows XP, and mingw.org's MinGW headers by default define
1026         _WIN32_WINNT to 0x500.
1027
1028 2019-03-01  Gary Benson <gbenson@redhat.com>
1029
1030         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1031
1032 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1033             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1034
1035         PR gdb/8527
1036         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1037         set_sigint_trap, clear_sigint_trap.
1038
1039 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1040
1041         * target.c (target_detach): Clear the regcache and the
1042         frame cache.
1043
1044 2019-02-27  Pedro Alves  <palves@redhat.com>
1045
1046         * utils.c (set_screen_size): When we cap the height/width sizes,
1047         tweak the corresponding command variable to show "unlimited":
1048
1049 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1050             Pedro Alves  <palves@redhat.com>
1051
1052         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1053         before calling rl_set_screen_size.
1054
1055 2019-02-27  Tom Tromey  <tromey@adacore.com>
1056
1057         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1058         define.
1059         * python/py-value.c: Remove Python 2.4 workaround.
1060         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1061         workaround.
1062         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1063         Python 2.4 workaround.
1064         * python/python-internal.h: Remove Python 2.4 comment.
1065         (Py_ssize_t): Don't define.
1066         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1067         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1068         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1069         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1070         * python/python.c (do_start_initialization): Remove Python 2.4
1071         workaround.
1072         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1073         (print_children): Remove Python 2.4 workaround.
1074         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1075         workaround.
1076         (CHARBUFFERPROC_NAME): Remove.
1077         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1078         Python 2.4 workaround.
1079
1080 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1081
1082         * NEWS: Note minimum Python version.
1083
1084 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1085
1086         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1087         code from these functions.  Remove corresponding ifdefs.  Use
1088         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1089         Remove gotos and target of gotos.
1090         (infpy_search_memory): Likewise.
1091
1092 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1093
1094         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1095         (hppa_gdbarch_init): Don't register deleted functions with
1096         gdbarch.
1097
1098 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1099
1100         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1101         (h8300_unwind_sp): Delete.
1102         (h8300_dummy_id): Delete.
1103         (h8300_gdbarch_init): Don't register deleted functions with
1104         gdbarch.
1105
1106 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1107
1108         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1109         (ft32_unwind_pc): Delete.
1110         (ft32_unwind_sp): Delete.
1111         (ft32_gdbarch_init): Don't register deleted functions with
1112         gdbarch.
1113
1114 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1115
1116         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1117         (frv_unwind_pc): Delete.
1118         (frv_unwind_sp): Delete.
1119         (frv_gdbarch_init): Don't register deleted functions with
1120         gdbarch.
1121
1122 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1123
1124         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1125         (riscv_unwind_pc): Delete.
1126         (riscv_unwind_sp): Delete.
1127         (riscv_gdbarch_init): Don't register deleted functions with
1128         gdbarch.
1129
1130 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1131
1132         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1133         (csky_unwind_pc): Delete.
1134         (csky_unwind_sp): Delete.
1135         (csky_gdbarch_init): Don't register deleted functions with
1136         gdbarch.
1137
1138 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1139
1140         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1141         (cris_unwind_pc): Delete.
1142         (cris_unwind_sp): Delete.
1143         (cris_gdbarch_init): Don't register deleted functions with
1144         gdbarch.
1145
1146 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1147
1148         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1149         (bfin_unwind_pc): Delete.
1150         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1151
1152 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1153
1154         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1155         (arm_unwind_pc): Delete.
1156         (arm_unwind_sp): Delete.
1157         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1158
1159 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1160
1161         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1162         (arc_unwind_pc): Delete.
1163         (arc_unwind_sp): Delete.
1164         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1165
1166 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1167
1168         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1169         (alpha_unwind_pc): Delete.
1170         (alpha_gdbarch_init): Don't register deleted functions with
1171         gdbarch.
1172
1173 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1174
1175         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1176         (aarch64_unwind_pc): Delete.
1177         (aarch64_unwind_sp): Delete.
1178         (aarch64_gdbarch_init): Don't register deleted functions with
1179         gdbarch.
1180
1181 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1182
1183         * gdbtypes.c (type_align): Don't consider static members when
1184         computing structure alignment.
1185
1186 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1187
1188         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1189         return 0 for other types.
1190         * arch-utils.c (default_type_align): Always return 0.
1191         * gdbarch.h: Regenerate.
1192         * gdbarch.sh (type_align): Extend comment.
1193         * gdbtypes.c (type_align): Add additional comments, always call
1194         gdbarch_type_align before applying the default rules.
1195         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1196         generic code will then apply a suitable default.
1197         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1198         types, return 0 for other types.
1199
1200 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1201
1202         * NEWS: Create a new section for the next release branch.
1203         Rename the section of the current branch, now that it has
1204         been cut.
1205
1206 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1207
1208         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1209         * version.in: Bump version to 8.3.50.DATE-git.
1210
1211 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1212
1213         * aix-thread.c (ptid_cmp): Remove unused variable.
1214         (get_signaled_thread): Likewise.
1215         (store_regs_user_thread): Likewise.
1216         (store_regs_kernel_thread): Likewise.
1217         (fetch_regs_kernel_thread): Remove shadowed variable.
1218
1219 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1220
1221         * features/riscv/32bit-cpu.xml: Add register numbers.
1222         * features/riscv/32bit-fpu.c: Regenerate.
1223         * features/riscv/32bit-fpu.xml: Add register numbers.
1224         * features/riscv/64bit-cpu.xml: Add register numbers.
1225         * features/riscv/64bit-fpu.c: Regenerate.
1226         * features/riscv/64bit-fpu.xml: Add register numbers.
1227
1228 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1229
1230         * NEWS: Mention two argument form of gdb.Value constructor.
1231         * python/py-value.c (convert_buffer_and_type_to_value): New
1232         function.
1233         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1234         Add support for handling an optional second argument.  Call
1235         convert_buffer_and_type_to_value as appropriate.
1236         * python/python-internal.h (Py_buffer_deleter): New struct.
1237         (Py_buffer_up): New typedef.
1238
1239 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1240
1241         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1242         instead of releasing ownership.
1243
1244 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1245
1246         * dwarf2read.c (open_and_init_dwp_file): Call
1247         elf_numsections instead of bfd_count_sections to initialize
1248         dwp_file->num_sections.
1249
1250 2019-02-25  Tom Tromey  <tromey@adacore.com>
1251
1252         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1253
1254 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1255
1256         * gcore.in: Add '--readnever' option when invoking GDB.
1257
1258 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1259
1260         * MAINTAINERS: Update my email address.
1261
1262 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1263
1264         * build-id.c (build_id_to_debug_bfd_1): New function.
1265         (build_id_to_debug_bfd): Look for separate debug file in
1266         sysroot.
1267
1268 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1269
1270         * gdbarch.sh: Update the copyright year range that is placed into
1271         generated files.
1272
1273 2019-02-22  Keith Seitz  <keiths@redhat.com>
1274
1275         PR symtab/23853
1276         * linespec.c (create_sals_line_offset): Search for the default
1277         symtab's filename instead of its fullname.
1278
1279 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1280
1281         * NEWS: Update style defaults.
1282
1283 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1284
1285         * main.c (captured_main_1): Disable styling in batch mode.
1286
1287 2019-02-20  Tom Tromey  <tom@tromey.com>
1288
1289         * symtab.c (symtab_symbol_info): Fix typos.
1290
1291 2019-02-20  Tom Tromey  <tromey@adacore.com>
1292
1293         * findcmd.c (_initialize_mem_search): Use upper case for
1294         metasyntactic variables.
1295
1296 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1297
1298         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1299         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1300
1301 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1302
1303         * top.h (source_file_name): Change to std::string.
1304         * top.c (source_file_name): Likewise.
1305         (command_line_input): Adjust.
1306         * cli/cli-script.c (script_from_file): Adjust.
1307
1308 2019-02-19  Tom Tromey  <tromey@adacore.com>
1309
1310         * ravenscar-thread.c
1311         (ravenscar_thread_target::update_thread_list): Don't call
1312         ada_build_task_list.
1313         * ada-lang.h (ada_build_task_list): Don't declare.
1314         * ada-tasks.c (struct ada_tasks_inferior_data)
1315         <task_list_valid_p>: Now bool.
1316         (read_known_tasks, ada_task_list_changed)
1317         (ada_tasks_invalidate_inferior_data): Update.
1318         (read_known_tasks_array): Return bool.
1319         (read_known_tasks_list): Likewise.
1320         (read_known_tasks): Return void.
1321         (ada_build_task_list): Now static.
1322
1323 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1324
1325         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1326         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1327
1328 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1329
1330         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1331         variant for ada_tasks_pspace_data_handle and
1332         ada_tasks_inferior_data_handle.
1333         (ada_tasks_pspace_data_cleanup): New function.
1334         (ada_tasks_inferior_data_cleanup): New function.
1335
1336 2019-02-17  Tom Tromey  <tom@tromey.com>
1337
1338         * macrotab.h (macro_source_fullname): Return a std::string.
1339         * macrotab.c (macro_include, check_for_redefinition)
1340         (macro_undef, macro_lookup_definition, foreach_macro)
1341         (foreach_macro_in_scope): Update.
1342         (macro_source_fullname): Return a std::string.
1343         * macrocmd.c (show_pp_source_pos): Update.
1344
1345 2019-02-17  Tom Tromey  <tom@tromey.com>
1346
1347         * macrocmd.c (show_pp_source_pos): Style the file names.
1348
1349 2019-02-17  Tom Tromey  <tom@tromey.com>
1350
1351         PR tui/24197:
1352         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1353
1354 2019-02-17  Tom Tromey  <tom@tromey.com>
1355
1356         * ada-lang.c (user_select_syms): Use filtered printing.
1357         * utils.c (wrap_style): New global.
1358         (desired_style): Remove.
1359         (emit_style_escape): Add stream parameter.
1360         (set_output_style, reset_terminal_style, prompt_for_continue):
1361         Update.
1362         (flush_wrap_buffer): Only flush gdb_stdout.
1363         (wrap_here): Set wrap_style.
1364         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1365         treat escape sequences as a character.  Change when wrap buffer is
1366         flushed.
1367         (fputs_styled): Do not set the output style when the default is
1368         requested.
1369         * ui-style.h (struct ui_file_style) <is_default>: New method.
1370         * source.c (print_source_lines_base): Emit escape sequences in one
1371         piece.
1372
1373 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1374
1375         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1376         integers and enumeration types.
1377
1378 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1379
1380         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1381         instead of lookup_symbol_in_language
1382         (do_exact_match): New function.
1383         (ada_get_symbol_name_matcher): Return do_exact_match when
1384         doing a verbatim match.
1385
1386 2019-02-15  Tom Tromey  <tromey@adacore.com>
1387
1388         * ravenscar-thread.c (ravenscar_thread_target::resume)
1389         (ravenscar_thread_target::wait): Special case wildcard requests.
1390
1391 2019-02-15  Tom Tromey  <tromey@adacore.com>
1392
1393         * ravenscar-thread.c (base_ptid): Remove.
1394         (struct ravenscar_thread_target) <close>: New method.
1395         <m_base_ptid>: New member.
1396         <update_inferior_ptid, active_task, task_is_currently_active,
1397         runtime_initialized>: Declare methods.
1398         <ravenscar_thread_target>: Add constructor.
1399         (ravenscar_thread_target::task_is_currently_active)
1400         (ravenscar_thread_target::update_inferior_ptid)
1401         (ravenscar_runtime_initialized): Rename.  Now methods.
1402         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1403         (ravenscar_thread_target::update_thread_list): Update.
1404         (ravenscar_thread_target::active_task): Now method.
1405         (ravenscar_thread_target::store_registers)
1406         (ravenscar_thread_target::prepare_to_store)
1407         (ravenscar_thread_target::prepare_to_store)
1408         (ravenscar_thread_target::mourn_inferior): Update.
1409         (ravenscar_inferior_created): Use "new" to create target.
1410         (ravenscar_thread_target::get_ada_task_ptid): Update.
1411         (_initialize_ravenscar): Don't initialize base_ptid.
1412         (ravenscar_ops): Remove global.
1413
1414 2019-02-15  Tom Tromey  <tromey@adacore.com>
1415
1416         * target.h (push_target): Declare new overload.
1417         * target.c (push_target): New overload, taking an rvalue reference.
1418         * remote.c (remote_target::open_1): Use push_target overload.
1419         * corelow.c (core_target_open): Use push_target overload.
1420
1421 2019-02-15  Tom Tromey  <tromey@adacore.com>
1422
1423         * ravenscar-thread.c (is_ravenscar_task)
1424         (ravenscar_task_is_currently_active): Return bool.
1425         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1426         (_initialize_ravenscar): Remove "(void)".
1427         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1428         Return bool.
1429
1430 2019-02-15  Tom Tromey  <tromey@adacore.com>
1431
1432         * ravenscar-thread.c (ravenscar_runtime_initializer)
1433         (has_ravenscar_runtime, get_running_thread_id)
1434         (ravenscar_thread_target::resume): Fix indentation.
1435
1436 2019-02-15  Tom Tromey  <tromey@adacore.com>
1437
1438         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1439         from ravenscar_arch_ops.
1440         (sparc_ravenscar_ops::fetch_registers)
1441         (sparc_ravenscar_ops::store_registers): Now methods.
1442         (sparc_ravenscar_prepare_to_store): Remove.
1443         (sparc_ravenscar_ops): Redefine.
1444         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1445         methods and destructor.  Remove members.
1446         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1447         (ravenscar_thread_target::store_registers)
1448         (ravenscar_thread_target::prepare_to_store): Update.
1449         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1450         Remove.
1451         (struct ppc_ravenscar_powerpc_ops): Derive from
1452         ravenscar_arch_ops.
1453         (ppc_ravenscar_powerpc_ops::fetch_registers)
1454         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1455         (ppc_ravenscar_powerpc_ops): Redefine.
1456         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1457         (ppc_ravenscar_e500_ops::fetch_registers)
1458         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1459         (ppc_ravenscar_e500_ops): Redefine.
1460         * aarch64-ravenscar-thread.c
1461         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1462         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1463         (aarch64_ravenscar_fetch_registers)
1464         (aarch64_ravenscar_store_registers): Now methods.
1465         (aarch64_ravenscar_ops): Redefine.
1466
1467 2019-02-15  Tom Tromey  <tromey@adacore.com>
1468
1469         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1470         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1471         (ravenscar_thread_target::stopped_by_watchpoint)
1472         (ravenscar_thread_target::stopped_data_address)
1473         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1474
1475 2019-02-15  Tom Tromey  <tromey@adacore.com>
1476
1477         * ravenscar-thread.c: Fix some typos.
1478
1479 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1480             Tom Tromey  <tromey@adacore.com>
1481
1482         * ada-lang.c (ada_exception_sal): Change addr_string to a
1483         std::string.
1484         (create_ada_exception_catchpoint): Update.
1485
1486 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1487             Tom Tromey  <tromey@adacore.com>
1488
1489         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1490         (bp_location_ops): Remove.
1491         (base_breakpoint_allocate_location): Update.
1492         (free_bp_location): Update.
1493         * ada-lang.c (class ada_catchpoint_location)
1494         <ada_catchpoint_location>: Remove ops parameter.
1495         (ada_catchpoint_location_dtor): Remove.
1496         (ada_catchpoint_location_ops): Remove.
1497         (allocate_location_exception): Update.
1498         * breakpoint.h (struct bp_location_ops): Remove.
1499         (class bp_location) <bp_location>: Remove bp_location_ops
1500         parameter.
1501         <~bp_location>: Add destructor.
1502         <ops>: Remove.
1503
1504 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1505             Pedro Alves  <palves@redhat.com>
1506
1507         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1508         'PATH_MAX'.
1509
1510 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1511             Samuel Thibault  <samuel.thibault@gnu.org>
1512             Thomas Schwinge  <thomas@codesourcery.com>
1513
1514         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1515         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1516
1517 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1518
1519         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1520         (check_empty): Use "const char *".
1521
1522         * gnu-nat.c (gnu_nat_target::detach): Instead of
1523         'detach_inferior (pid)' call
1524         'detach_inferior (find_inferior_pid (pid))'.
1525
1526         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1527         'nat/fork-inferior.o'.
1528         * gnu-nat.c: #include "nat/fork-inferior.h".
1529
1530         * gnu-nat.c (gnu_nat_target::detach): Instead of
1531         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1532         * gnu-nat.h: #include "inf-child.h".
1533         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1534         'i386_gnu_nat_target::fetch_registers'.
1535         (gnu_store_registers): Rename/move to
1536         'i386_gnu_nat_target::store_registers'.
1537
1538         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1539         * gnu-nat.h (mach_thread_info): New function.
1540         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1541
1542         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1543
1544 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1545
1546         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1547
1548 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1549
1550         * windows-nat.c (windows_add_thread): Add new parameter
1551         "main_thread_p" with default value set to false.  Update
1552         function documentation as well as all callers.
1553         (windows_delete_thread): Likewise.
1554         (fake_create_process): Update call to windows_add_thread.
1555         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1556         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1557         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1558         call to windows_delete_thread.
1559
1560 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1561
1562         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1563
1564 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1565
1566         * symfile.c (find_separate_debug_file): Use canonical path of
1567         sysroot with child_path instead of gdb_sysroot if it is valid.
1568
1569 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1570
1571         * symfile.c (find_separate_debug_file): Use child_path to
1572         determine if an object file is under a sysroot.
1573
1574 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1575
1576         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1577         unittests/child-path-selftests.c.
1578         * common/pathstuff.c (child_path): New function.
1579         * common/pathstuff.h (child_path): New prototype.
1580         * unittests/child-path-selftests.c: New file.
1581
1582 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1583
1584         * symfile.c (find_separate_debug_file): Look for separate debug
1585         files in debug directories under the sysroot.
1586
1587 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1588
1589         * symtab.h (struct minimal_symbol data_p): New const method.
1590         (struct minimal_symbol text_p): Likewise.
1591         * symtab.c (output_source_filename): Use file name style
1592         to print file name.
1593         (print_symbol_info): Likewise.
1594         (print_msymbol_info): Use address style to print addresses.
1595         Use function name style to print executable text symbols.
1596         (expand_symtab_containing_pc): Use data_p.
1597         (find_pc_sect_compunit_symtab): Likewise.
1598
1599 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1600
1601         * breakpoint.c (describe_other_breakpoints): Use address style
1602         to print addresses.
1603         (say_where): Likewise.
1604
1605 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1606
1607         * ada-typeprint.c (print_func_type): Print function name
1608         style to print function name.
1609         * c-typeprint.c (c_print_type_1): Likewise.
1610
1611 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1612
1613         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1614         for execve.
1615
1616 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1617
1618         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1619         type_stack.
1620
1621 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1622
1623         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1624         TYPE_CODE_REF types.
1625
1626 2019-02-08  Jim Wilson  <jimw@sifive.com>
1627
1628         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1629         (riscv_linux_fregset): New.
1630         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1631
1632 2019-02-07  Tom Tromey  <tom@tromey.com>
1633
1634         * thread.c (thread_cancel_execution_command): Update.
1635         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1636         methods.
1637         (struct thread_fsm_ops): Remove.
1638         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1639         (thread_fsm_should_stop, thread_fsm_return_value)
1640         (thread_fsm_set_finished, thread_fsm_finished_p)
1641         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1642         Don't declare.
1643         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1644         * infrun.c (clear_proceed_status_thread)
1645         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1646         (print_stop_event): Update.
1647         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1648         Add constructor.
1649         (step_command_fsm_ops): Remove.
1650         (new_step_command_fsm): Remove.
1651         (step_1): Update.
1652         (step_command_fsm::should_stop): Rename from
1653         step_command_fsm_should_stop.
1654         (step_command_fsm::clean_up): Rename from
1655         step_command_fsm_clean_up.
1656         (step_command_fsm::do_async_reply_reason): Rename from
1657         step_command_fsm_async_reply_reason.
1658         (struct until_next_fsm): Inherit from thread_fsm.  Add
1659         constructor.
1660         (until_next_fsm_ops): Remove.
1661         (new_until_next_fsm): Remove.
1662         (until_next_fsm::should_stop): Rename from
1663         until_next_fsm_should_stop.
1664         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1665         (until_next_fsm::do_async_reply_reason): Rename from
1666         until_next_fsm_async_reply_reason.
1667         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1668         constructor.  Change type of breakpoint.
1669         (finish_command_fsm_ops): Remove.
1670         (new_finish_command_fsm): Remove.
1671         (finish_command_fsm::should_stop): Rename from
1672         finish_command_fsm_should_stop.
1673         (finish_command_fsm::clean_up): Rename from
1674         finish_command_fsm_clean_up.
1675         (finish_command_fsm::return_value): Rename from
1676         finish_command_fsm_return_value.
1677         (finish_command_fsm::do_async_reply_reason): Rename from
1678         finish_command_fsm_async_reply_reason.
1679         (finish_command): Update.
1680         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1681         Add constructor.
1682         (call_thread_fsm_ops): Remove.
1683         (call_thread_fsm::call_thread_fsm): Rename from
1684         new_call_thread_fsm.
1685         (call_thread_fsm::should_stop): Rename from
1686         call_thread_fsm_should_stop.
1687         (call_thread_fsm::should_notify_stop): Rename from
1688         call_thread_fsm_should_notify_stop.
1689         (run_inferior_call, call_function_by_hand_dummy): Update.
1690         * cli/cli-interp.c (should_print_stop_to_console): Update.
1691         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1692         Add constructor.  Change type of location_breakpoint,
1693         caller_breakpoint.
1694         (until_break_fsm_ops): Remove.
1695         (new_until_break_fsm): Remove.
1696         (until_break_fsm::should_stop): Rename from
1697         until_break_fsm_should_stop.
1698         (until_break_fsm::clean_up): Rename from
1699         until_break_fsm_clean_up.
1700         (until_break_fsm::do_async_reply_reason): Rename from
1701         until_break_fsm_async_reply_reason.
1702         (until_break_command): Update.
1703         * thread-fsm.c: Remove.
1704         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1705
1706 2019-02-07  Tom Tromey  <tom@tromey.com>
1707
1708         * yy-remap.h: Add include guard.
1709         * xtensa-tdep.h: Add include guard.
1710         * xcoffread.h: Rename include guard.
1711         * varobj-iter.h: Add include guard.
1712         * tui/tui.h: Rename include guard.
1713         * tui/tui-winsource.h: Rename include guard.
1714         * tui/tui-wingeneral.h: Rename include guard.
1715         * tui/tui-windata.h: Rename include guard.
1716         * tui/tui-win.h: Rename include guard.
1717         * tui/tui-stack.h: Rename include guard.
1718         * tui/tui-source.h: Rename include guard.
1719         * tui/tui-regs.h: Rename include guard.
1720         * tui/tui-out.h: Rename include guard.
1721         * tui/tui-layout.h: Rename include guard.
1722         * tui/tui-io.h: Rename include guard.
1723         * tui/tui-hooks.h: Rename include guard.
1724         * tui/tui-file.h: Rename include guard.
1725         * tui/tui-disasm.h: Rename include guard.
1726         * tui/tui-data.h: Rename include guard.
1727         * tui/tui-command.h: Rename include guard.
1728         * tic6x-tdep.h: Add include guard.
1729         * target/waitstatus.h: Rename include guard.
1730         * target/wait.h: Rename include guard.
1731         * target/target.h: Rename include guard.
1732         * target/resume.h: Rename include guard.
1733         * target-float.h: Rename include guard.
1734         * stabsread.h: Add include guard.
1735         * rs6000-tdep.h: Add include guard.
1736         * riscv-fbsd-tdep.h: Add include guard.
1737         * regformats/regdef.h: Rename include guard.
1738         * record.h: Rename include guard.
1739         * python/python.h: Rename include guard.
1740         * python/python-internal.h: Rename include guard.
1741         * python/py-stopevent.h: Rename include guard.
1742         * python/py-ref.h: Rename include guard.
1743         * python/py-record.h: Rename include guard.
1744         * python/py-record-full.h: Rename include guard.
1745         * python/py-record-btrace.h: Rename include guard.
1746         * python/py-instruction.h: Rename include guard.
1747         * python/py-events.h: Rename include guard.
1748         * python/py-event.h: Rename include guard.
1749         * procfs.h: Add include guard.
1750         * proc-utils.h: Add include guard.
1751         * p-lang.h: Add include guard.
1752         * or1k-tdep.h: Rename include guard.
1753         * observable.h: Rename include guard.
1754         * nto-tdep.h: Rename include guard.
1755         * nat/x86-linux.h: Rename include guard.
1756         * nat/x86-linux-dregs.h: Rename include guard.
1757         * nat/x86-gcc-cpuid.h: Add include guard.
1758         * nat/x86-dregs.h: Rename include guard.
1759         * nat/x86-cpuid.h: Rename include guard.
1760         * nat/ppc-linux.h: Rename include guard.
1761         * nat/mips-linux-watch.h: Rename include guard.
1762         * nat/linux-waitpid.h: Rename include guard.
1763         * nat/linux-ptrace.h: Rename include guard.
1764         * nat/linux-procfs.h: Rename include guard.
1765         * nat/linux-osdata.h: Rename include guard.
1766         * nat/linux-nat.h: Rename include guard.
1767         * nat/linux-namespaces.h: Rename include guard.
1768         * nat/linux-btrace.h: Rename include guard.
1769         * nat/glibc_thread_db.h: Rename include guard.
1770         * nat/gdb_thread_db.h: Rename include guard.
1771         * nat/gdb_ptrace.h: Rename include guard.
1772         * nat/fork-inferior.h: Rename include guard.
1773         * nat/amd64-linux-siginfo.h: Rename include guard.
1774         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1775         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1776         * nat/aarch64-linux.h: Rename include guard.
1777         * nat/aarch64-linux-hw-point.h: Rename include guard.
1778         * mn10300-tdep.h: Add include guard.
1779         * mips-linux-tdep.h: Add include guard.
1780         * mi/mi-parse.h: Rename include guard.
1781         * mi/mi-out.h: Rename include guard.
1782         * mi/mi-main.h: Rename include guard.
1783         * mi/mi-interp.h: Rename include guard.
1784         * mi/mi-getopt.h: Rename include guard.
1785         * mi/mi-console.h: Rename include guard.
1786         * mi/mi-common.h: Rename include guard.
1787         * mi/mi-cmds.h: Rename include guard.
1788         * mi/mi-cmd-break.h: Rename include guard.
1789         * m2-lang.h: Add include guard.
1790         * location.h: Rename include guard.
1791         * linux-record.h: Rename include guard.
1792         * linux-nat.h: Add include guard.
1793         * linux-fork.h: Add include guard.
1794         * i386-darwin-tdep.h: Rename include guard.
1795         * hppa-linux-offsets.h: Add include guard.
1796         * guile/guile.h: Rename include guard.
1797         * guile/guile-internal.h: Rename include guard.
1798         * gnu-nat.h: Rename include guard.
1799         * gdb-stabs.h: Rename include guard.
1800         * frv-tdep.h: Add include guard.
1801         * f-lang.h: Add include guard.
1802         * event-loop.h: Add include guard.
1803         * darwin-nat.h: Rename include guard.
1804         * cp-abi.h: Rename include guard.
1805         * config/sparc/nm-sol2.h: Rename include guard.
1806         * config/nm-nto.h: Rename include guard.
1807         * config/nm-linux.h: Add include guard.
1808         * config/i386/nm-i386gnu.h: Rename include guard.
1809         * config/djgpp/nl_types.h: Rename include guard.
1810         * config/djgpp/langinfo.h: Rename include guard.
1811         * compile/gcc-cp-plugin.h: Add include guard.
1812         * compile/gcc-c-plugin.h: Add include guard.
1813         * compile/compile.h: Rename include guard.
1814         * compile/compile-object-run.h: Rename include guard.
1815         * compile/compile-object-load.h: Rename include guard.
1816         * compile/compile-internal.h: Rename include guard.
1817         * compile/compile-cplus.h: Rename include guard.
1818         * compile/compile-c.h: Rename include guard.
1819         * common/xml-utils.h: Rename include guard.
1820         * common/x86-xstate.h: Rename include guard.
1821         * common/version.h: Rename include guard.
1822         * common/vec.h: Rename include guard.
1823         * common/tdesc.h: Rename include guard.
1824         * common/selftest.h: Rename include guard.
1825         * common/scoped_restore.h: Rename include guard.
1826         * common/scoped_mmap.h: Rename include guard.
1827         * common/scoped_fd.h: Rename include guard.
1828         * common/safe-iterator.h: Rename include guard.
1829         * common/run-time-clock.h: Rename include guard.
1830         * common/refcounted-object.h: Rename include guard.
1831         * common/queue.h: Rename include guard.
1832         * common/ptid.h: Rename include guard.
1833         * common/print-utils.h: Rename include guard.
1834         * common/preprocessor.h: Rename include guard.
1835         * common/pathstuff.h: Rename include guard.
1836         * common/observable.h: Rename include guard.
1837         * common/netstuff.h: Rename include guard.
1838         * common/job-control.h: Rename include guard.
1839         * common/host-defs.h: Rename include guard.
1840         * common/gdb_wait.h: Rename include guard.
1841         * common/gdb_vecs.h: Rename include guard.
1842         * common/gdb_unlinker.h: Rename include guard.
1843         * common/gdb_unique_ptr.h: Rename include guard.
1844         * common/gdb_tilde_expand.h: Rename include guard.
1845         * common/gdb_sys_time.h: Rename include guard.
1846         * common/gdb_string_view.h: Rename include guard.
1847         * common/gdb_splay_tree.h: Rename include guard.
1848         * common/gdb_setjmp.h: Rename include guard.
1849         * common/gdb_ref_ptr.h: Rename include guard.
1850         * common/gdb_optional.h: Rename include guard.
1851         * common/gdb_locale.h: Rename include guard.
1852         * common/gdb_assert.h: Rename include guard.
1853         * common/filtered-iterator.h: Rename include guard.
1854         * common/filestuff.h: Rename include guard.
1855         * common/fileio.h: Rename include guard.
1856         * common/environ.h: Rename include guard.
1857         * common/common-utils.h: Rename include guard.
1858         * common/common-types.h: Rename include guard.
1859         * common/common-regcache.h: Rename include guard.
1860         * common/common-inferior.h: Rename include guard.
1861         * common/common-gdbthread.h: Rename include guard.
1862         * common/common-exceptions.h: Rename include guard.
1863         * common/common-defs.h: Rename include guard.
1864         * common/common-debug.h: Rename include guard.
1865         * common/cleanups.h: Rename include guard.
1866         * common/buffer.h: Rename include guard.
1867         * common/btrace-common.h: Rename include guard.
1868         * common/break-common.h: Rename include guard.
1869         * cli/cli-utils.h: Rename include guard.
1870         * cli/cli-style.h: Rename include guard.
1871         * cli/cli-setshow.h: Rename include guard.
1872         * cli/cli-script.h: Rename include guard.
1873         * cli/cli-interp.h: Rename include guard.
1874         * cli/cli-decode.h: Rename include guard.
1875         * cli/cli-cmds.h: Rename include guard.
1876         * charset-list.h: Add include guard.
1877         * buildsym-legacy.h: Rename include guard.
1878         * bfin-tdep.h: Add include guard.
1879         * ax.h: Rename include guard.
1880         * arm-linux-tdep.h: Add include guard.
1881         * arm-fbsd-tdep.h: Add include guard.
1882         * arch/xtensa.h: Rename include guard.
1883         * arch/tic6x.h: Add include guard.
1884         * arch/i386.h: Add include guard.
1885         * arch/arm.h: Rename include guard.
1886         * arch/arm-linux.h: Rename include guard.
1887         * arch/arm-get-next-pcs.h: Rename include guard.
1888         * arch/amd64.h: Add include guard.
1889         * arch/aarch64-insn.h: Rename include guard.
1890         * arch-utils.h: Rename include guard.
1891         * annotate.h: Add include guard.
1892         * amd64-darwin-tdep.h: Rename include guard.
1893         * aarch64-linux-tdep.h: Add include guard.
1894         * aarch64-fbsd-tdep.h: Add include guard.
1895         * aarch32-linux-nat.h: Add include guard.
1896
1897 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1898
1899         * macrotab.c (macro_define_internal): New function that
1900         factorizes macro_define_object_internal and macro_define_function
1901         code.
1902         (macro_define_object_internal): Use macro_define_internal.
1903         (macro_define_function): Likewise.
1904
1905 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1906
1907         * macrocmd.c (extract_identifier): Return
1908         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1909         callers.
1910
1911 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1912
1913         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1914
1915 2019-02-05  Tom Tromey  <tom@tromey.com>
1916
1917         * target.c (target_stack::unpush): Move assertion earlier.
1918
1919 2019-01-30  Tom Tromey  <tom@tromey.com>
1920
1921         PR python/23615:
1922         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1923         (gdbpy_parse_and_eval): Likewise.
1924         * python/python-internal.h (gdbpy_allow_threads): New class.
1925
1926 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1927
1928         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1929         (aarch64_fbsd_fpregmap): Move earlier.
1930         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1931         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1932         instead of individual calls to trad_frame_set_reg_addr.
1933         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1934         earlier.
1935         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1936         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1937         instead of individual calls to trad_frame_set_reg_addr.
1938
1939 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1940
1941         * CONTRIBUTE: Replace contribution list with wiki link.
1942
1943 2019-01-25  Tom Tromey  <tom@tromey.com>
1944
1945         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1946
1947 2019-01-25  Tom Tromey  <tom@tromey.com>
1948
1949         * xtensa-linux-nat.c: Fix common/ includes.
1950         * xml-support.h: Fix common/ includes.
1951         * xml-support.c: Fix common/ includes.
1952         * x86-linux-nat.c: Fix common/ includes.
1953         * windows-nat.c: Fix common/ includes.
1954         * varobj.h: Fix common/ includes.
1955         * varobj.c: Fix common/ includes.
1956         * value.c: Fix common/ includes.
1957         * valops.c: Fix common/ includes.
1958         * utils.c: Fix common/ includes.
1959         * unittests/xml-utils-selftests.c: Fix common/ includes.
1960         * unittests/utils-selftests.c: Fix common/ includes.
1961         * unittests/unpack-selftests.c: Fix common/ includes.
1962         * unittests/tracepoint-selftests.c: Fix common/ includes.
1963         * unittests/style-selftests.c: Fix common/ includes.
1964         * unittests/string_view-selftests.c: Fix common/ includes.
1965         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1966         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1967         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1968         * unittests/rsp-low-selftests.c: Fix common/ includes.
1969         * unittests/parse-connection-spec-selftests.c: Fix common/
1970         includes.
1971         * unittests/optional-selftests.c: Fix common/ includes.
1972         * unittests/offset-type-selftests.c: Fix common/ includes.
1973         * unittests/observable-selftests.c: Fix common/ includes.
1974         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1975         * unittests/memrange-selftests.c: Fix common/ includes.
1976         * unittests/memory-map-selftests.c: Fix common/ includes.
1977         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1978         * unittests/function-view-selftests.c: Fix common/ includes.
1979         * unittests/environ-selftests.c: Fix common/ includes.
1980         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1981         * unittests/common-utils-selftests.c: Fix common/ includes.
1982         * unittests/cli-utils-selftests.c: Fix common/ includes.
1983         * unittests/array-view-selftests.c: Fix common/ includes.
1984         * ui-file.c: Fix common/ includes.
1985         * tui/tui-io.c: Fix common/ includes.
1986         * tracepoint.h: Fix common/ includes.
1987         * tracepoint.c: Fix common/ includes.
1988         * tracefile-tfile.c: Fix common/ includes.
1989         * top.h: Fix common/ includes.
1990         * top.c: Fix common/ includes.
1991         * thread.c: Fix common/ includes.
1992         * target/waitstatus.h: Fix common/ includes.
1993         * target/waitstatus.c: Fix common/ includes.
1994         * target.h: Fix common/ includes.
1995         * target.c: Fix common/ includes.
1996         * target-memory.c: Fix common/ includes.
1997         * target-descriptions.c: Fix common/ includes.
1998         * symtab.h: Fix common/ includes.
1999         * symfile.c: Fix common/ includes.
2000         * stap-probe.c: Fix common/ includes.
2001         * spu-linux-nat.c: Fix common/ includes.
2002         * sparc-nat.c: Fix common/ includes.
2003         * source.c: Fix common/ includes.
2004         * solib.c: Fix common/ includes.
2005         * solib-target.c: Fix common/ includes.
2006         * ser-unix.c: Fix common/ includes.
2007         * ser-tcp.c: Fix common/ includes.
2008         * ser-pipe.c: Fix common/ includes.
2009         * ser-base.c: Fix common/ includes.
2010         * selftest-arch.c: Fix common/ includes.
2011         * s12z-tdep.c: Fix common/ includes.
2012         * rust-exp.y: Fix common/ includes.
2013         * rs6000-aix-tdep.c: Fix common/ includes.
2014         * riscv-tdep.c: Fix common/ includes.
2015         * remote.c: Fix common/ includes.
2016         * remote-notif.h: Fix common/ includes.
2017         * remote-fileio.h: Fix common/ includes.
2018         * remote-fileio.c: Fix common/ includes.
2019         * regcache.h: Fix common/ includes.
2020         * regcache.c: Fix common/ includes.
2021         * record-btrace.c: Fix common/ includes.
2022         * python/python.c: Fix common/ includes.
2023         * python/py-type.c: Fix common/ includes.
2024         * python/py-inferior.c: Fix common/ includes.
2025         * progspace.h: Fix common/ includes.
2026         * producer.c: Fix common/ includes.
2027         * procfs.c: Fix common/ includes.
2028         * proc-api.c: Fix common/ includes.
2029         * printcmd.c: Fix common/ includes.
2030         * ppc-linux-nat.c: Fix common/ includes.
2031         * parser-defs.h: Fix common/ includes.
2032         * osdata.c: Fix common/ includes.
2033         * obsd-nat.c: Fix common/ includes.
2034         * nat/x86-linux.c: Fix common/ includes.
2035         * nat/x86-linux-dregs.c: Fix common/ includes.
2036         * nat/x86-dregs.h: Fix common/ includes.
2037         * nat/x86-dregs.c: Fix common/ includes.
2038         * nat/ppc-linux.c: Fix common/ includes.
2039         * nat/mips-linux-watch.h: Fix common/ includes.
2040         * nat/mips-linux-watch.c: Fix common/ includes.
2041         * nat/linux-waitpid.c: Fix common/ includes.
2042         * nat/linux-ptrace.h: Fix common/ includes.
2043         * nat/linux-ptrace.c: Fix common/ includes.
2044         * nat/linux-procfs.c: Fix common/ includes.
2045         * nat/linux-personality.c: Fix common/ includes.
2046         * nat/linux-osdata.c: Fix common/ includes.
2047         * nat/linux-namespaces.c: Fix common/ includes.
2048         * nat/linux-btrace.h: Fix common/ includes.
2049         * nat/linux-btrace.c: Fix common/ includes.
2050         * nat/fork-inferior.c: Fix common/ includes.
2051         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2052         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2053         * nat/aarch64-linux.c: Fix common/ includes.
2054         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2055         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2056         * namespace.h: Fix common/ includes.
2057         * mips-linux-tdep.c: Fix common/ includes.
2058         * minsyms.c: Fix common/ includes.
2059         * mi/mi-parse.h: Fix common/ includes.
2060         * mi/mi-main.c: Fix common/ includes.
2061         * mi/mi-cmd-env.c: Fix common/ includes.
2062         * memrange.h: Fix common/ includes.
2063         * memattr.c: Fix common/ includes.
2064         * maint.h: Fix common/ includes.
2065         * maint.c: Fix common/ includes.
2066         * main.c: Fix common/ includes.
2067         * machoread.c: Fix common/ includes.
2068         * location.c: Fix common/ includes.
2069         * linux-thread-db.c: Fix common/ includes.
2070         * linux-nat.c: Fix common/ includes.
2071         * linux-fork.c: Fix common/ includes.
2072         * inline-frame.c: Fix common/ includes.
2073         * infrun.c: Fix common/ includes.
2074         * inflow.c: Fix common/ includes.
2075         * inferior.h: Fix common/ includes.
2076         * inferior.c: Fix common/ includes.
2077         * infcmd.c: Fix common/ includes.
2078         * inf-ptrace.c: Fix common/ includes.
2079         * inf-child.c: Fix common/ includes.
2080         * ia64-linux-nat.c: Fix common/ includes.
2081         * i387-tdep.c: Fix common/ includes.
2082         * i386-tdep.c: Fix common/ includes.
2083         * i386-linux-tdep.c: Fix common/ includes.
2084         * i386-linux-nat.c: Fix common/ includes.
2085         * i386-go32-tdep.c: Fix common/ includes.
2086         * i386-fbsd-tdep.c: Fix common/ includes.
2087         * i386-fbsd-nat.c: Fix common/ includes.
2088         * guile/scm-type.c: Fix common/ includes.
2089         * guile/guile.c: Fix common/ includes.
2090         * go32-nat.c: Fix common/ includes.
2091         * gnu-nat.c: Fix common/ includes.
2092         * gdbthread.h: Fix common/ includes.
2093         * gdbarch-selftests.c: Fix common/ includes.
2094         * gdb_usleep.c: Fix common/ includes.
2095         * gdb_select.h: Fix common/ includes.
2096         * gdb_bfd.c: Fix common/ includes.
2097         * gcore.c: Fix common/ includes.
2098         * fork-child.c: Fix common/ includes.
2099         * findvar.c: Fix common/ includes.
2100         * fbsd-nat.c: Fix common/ includes.
2101         * event-top.c: Fix common/ includes.
2102         * event-loop.c: Fix common/ includes.
2103         * dwarf2read.c: Fix common/ includes.
2104         * dwarf2loc.c: Fix common/ includes.
2105         * dwarf2-frame.c: Fix common/ includes.
2106         * dwarf-index-cache.c: Fix common/ includes.
2107         * dtrace-probe.c: Fix common/ includes.
2108         * disasm-selftests.c: Fix common/ includes.
2109         * defs.h: Fix common/ includes.
2110         * csky-tdep.c: Fix common/ includes.
2111         * cp-valprint.c: Fix common/ includes.
2112         * cp-support.h: Fix common/ includes.
2113         * cp-support.c: Fix common/ includes.
2114         * corelow.c: Fix common/ includes.
2115         * completer.h: Fix common/ includes.
2116         * completer.c: Fix common/ includes.
2117         * compile/compile.c: Fix common/ includes.
2118         * compile/compile-loc2c.c: Fix common/ includes.
2119         * compile/compile-cplus-types.c: Fix common/ includes.
2120         * compile/compile-cplus-symbols.c: Fix common/ includes.
2121         * command.h: Fix common/ includes.
2122         * cli/cli-dump.c: Fix common/ includes.
2123         * cli/cli-cmds.c: Fix common/ includes.
2124         * charset.c: Fix common/ includes.
2125         * build-id.c: Fix common/ includes.
2126         * btrace.h: Fix common/ includes.
2127         * btrace.c: Fix common/ includes.
2128         * breakpoint.h: Fix common/ includes.
2129         * breakpoint.c: Fix common/ includes.
2130         * ax.h:
2131         (enum agent_op): Fix common/ includes.
2132         * ax-general.c (struct aop_map): Fix common/ includes.
2133         * ax-gdb.c: Fix common/ includes.
2134         * auxv.c: Fix common/ includes.
2135         * auto-load.c: Fix common/ includes.
2136         * arm-tdep.c: Fix common/ includes.
2137         * arch/riscv.c: Fix common/ includes.
2138         * arch/ppc-linux-common.c: Fix common/ includes.
2139         * arch/i386.c: Fix common/ includes.
2140         * arch/arm.c: Fix common/ includes.
2141         * arch/arm-linux.c: Fix common/ includes.
2142         * arch/arm-get-next-pcs.c: Fix common/ includes.
2143         * arch/amd64.c: Fix common/ includes.
2144         * arch/aarch64.c: Fix common/ includes.
2145         * arch/aarch64-insn.c: Fix common/ includes.
2146         * arch-utils.c: Fix common/ includes.
2147         * amd64-windows-tdep.c: Fix common/ includes.
2148         * amd64-tdep.c: Fix common/ includes.
2149         * amd64-sol2-tdep.c: Fix common/ includes.
2150         * amd64-obsd-tdep.c: Fix common/ includes.
2151         * amd64-nbsd-tdep.c: Fix common/ includes.
2152         * amd64-linux-tdep.c: Fix common/ includes.
2153         * amd64-linux-nat.c: Fix common/ includes.
2154         * amd64-fbsd-tdep.c: Fix common/ includes.
2155         * amd64-fbsd-nat.c: Fix common/ includes.
2156         * amd64-dicos-tdep.c: Fix common/ includes.
2157         * amd64-darwin-tdep.c: Fix common/ includes.
2158         * agent.c: Fix common/ includes.
2159         * ada-lang.h: Fix common/ includes.
2160         * ada-lang.c: Fix common/ includes.
2161         * aarch64-tdep.c: Fix common/ includes.
2162
2163 2019-01-25  Tom Tromey  <tom@tromey.com>
2164
2165         * common/create-version.sh: Use common/version.h.
2166
2167 2019-01-24  Pedro Alves  <palves@redhat.com>
2168
2169         * infrun.c (signal_stop, signal_print, signal_program)
2170         (signal_catch, signal_pass): Now arrays instead of pointers.
2171         (update_signals_program_target, do_target_resume)
2172         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2173         * linux-nat.c (linux_nat_target::pass_signals)
2174         (linux_nat_target::create_inferior, linux_nat_target::attach):
2175         Adjust.
2176         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2177         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2178         * procfs.c (procfs_target::pass_signals): Adjust.
2179         * record-full.c (record_full_target::resume): Adjust.
2180         * remote.c (remote_target::pass_signals)
2181         (remote_target::program_signals): Adjust.
2182         * target-debug.h (target_debug_print_signals): Now takes a
2183         gdb::array_view as parameter.  Adjust.
2184         * target.h (target_ops) <pass_signals, program_signals>: Replace
2185         pointer and length parameters with gdb::array_view.
2186         (target_pass_signals, target_program_signals): Likewise.
2187         * target-delegates.c: Regenerate.
2188
2189 2019-01-24  Pedro Alves  <palves@redhat.com>
2190
2191         * common/forward-scope-exit.h
2192         (forward_scope_exit::forward_scope_exit): Pass arguments to
2193         m_bind_function directly, instead of creating a std::bind and
2194         copying that.
2195
2196 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2197
2198         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2199         for static members.
2200         (pass_in_v_vfp_candidate): Likewise.
2201
2202 2019-01-23  Tom Tromey  <tom@tromey.com>
2203             Pedro Alves  <palves@redhat.com>
2204
2205         * regcache.c (class regcache_invalidator): Remove.
2206         (regcache::raw_write): Use make_scope_exit.
2207
2208 2019-01-23  Tom Tromey  <tom@tromey.com>
2209
2210         * ui-out.h (class ui_out_emit_type): Update comment.
2211
2212 2019-01-23  Tom Tromey  <tom@tromey.com>
2213
2214         * infrun.c (fetch_inferior_event): Update comment.
2215
2216 2019-01-23  Tom Tromey  <tom@tromey.com>
2217             Pedro Alves  <palves@redhat.com>
2218
2219         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2220         parameter.
2221         (fetch_inferior_event): Use SCOPE_EXIT.
2222
2223
2224 2019-01-23  Tom Tromey  <tom@tromey.com>
2225             Pedro Alves  <palves@redhat.com>
2226
2227         * infrun.c (disable_thread_events): Delete.
2228         (stop_all_threads): Use SCOPE_EXIT.
2229
2230 2019-01-23  Tom Tromey  <tom@tromey.com>
2231             Pedro Alves  <palves@redhat.com>
2232
2233         * symfile.c: Include forward-scope-exit.h.
2234         (clear_symtab_users_cleanup): Replace forward declaration with
2235         a FORWARD_SCOPE_EXIT.
2236         (syms_from_objfile_1): Use the forward_scope_exit and
2237         gdb::optional instead of cleanup_function.
2238         (reread_symbols): Use the forward_scope_exit instead of
2239         cleanup_function.
2240         (clear_symtab_users_cleanup): Remove function.
2241
2242 2019-01-23  Tom Tromey  <tom@tromey.com>
2243             Pedro Alves  <palves@redhat.com>
2244
2245         * linux-nat.c: Include scope-exit.h.
2246         (cleanup_target_stop): Remove.
2247         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2248         SCOPE_EXIT.
2249
2250 2019-01-23  Tom Tromey  <tom@tromey.com>
2251             Pedro Alves  <palves@redhat.com>
2252
2253         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2254         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2255
2256 2019-01-23  Tom Tromey  <tom@tromey.com>
2257             Andrew Burgess  <andrew.burgess@embecosm.com>
2258             Pedro Alves  <palves@redhat.com>
2259
2260         * infrun.c (fetch_inferior_event): Use scope_exit.
2261         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2262         * top.c (execute_command): Use scope_exit.
2263         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2264         * utils.c (do_bpstat_clear_actions_cleanup)
2265         (make_bpstat_clear_actions_cleanup): Remove.
2266
2267 2019-01-23  Tom Tromey  <tom@tromey.com>
2268             Pedro Alves  <palves@redhat.com>
2269
2270         * infrun.c: Include "common/scope-exit.h"
2271         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2272         (wait_for_inferior): Use SCOPE_EXIT.
2273         (fetch_inferior_event): Use scope_exit.
2274
2275 2019-01-23  Tom Tromey  <tom@tromey.com>
2276             Pedro Alves  <palves@redhat.com>
2277
2278         * breakpoint.c (create_breakpoint): Remove cleanup.
2279
2280 2019-01-23  Tom Tromey  <tom@tromey.com>
2281             Andrew Burgess  <andrew.burgess@embecosm.com>
2282             Pedro Alves  <palves@redhat.com>
2283
2284 2019-01-23  Pedro Alves  <palves@redhat.com>
2285
2286         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2287
2288 2019-01-23  Pedro Alves  <palves@redhat.com>
2289             Andrew Burgess  <andrew.burgess@embecosm.com>
2290
2291         * gdbthread.h: Include "common/forward-scope-exit.h".
2292         (scoped_finish_thread_state): Redefine custom class in terms of
2293         forward_scope_exit.
2294
2295 2019-01-23  Pedro Alves  <palves@redhat.com>
2296             Andrew Burgess  <andrew.burgess@embecosm.com>
2297
2298         * common/forward-scope-exit.h: New file.
2299
2300 2019-01-23  Pedro Alves  <palves@redhat.com>
2301             Andrew Burgess  <andrew.burgess@embecosm.com>
2302             Tom Tromey  <tom@tromey.com>
2303
2304         * common/scope-exit.h: New file.
2305
2306 2019-01-23  Pedro Alves  <palves@redhat.com>
2307
2308         * common/preprocessor.h (ESC): Rename to ...
2309         (ESC_PARENS): ... this.
2310         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2311         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2312
2313 2019-01-23  Tom Tromey  <tom@tromey.com>
2314
2315         * language.h (class scoped_switch_to_sym_language_if_auto):
2316         Initialize m_lang in both cases.
2317
2318 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2319
2320         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2321         with XCNEW.
2322
2323 2019-01-22  Tom Tromey  <tom@tromey.com>
2324
2325         * corelow.c: Do not include sys/file.h.
2326
2327 2019-01-22  Tom Tromey  <tom@tromey.com>
2328
2329         * tui/tui-wingeneral.h: Include gdb_curses.h.
2330
2331 2019-01-22  Tom Tromey  <tom@tromey.com>
2332
2333         * source-cache.h (class source_cache) <get_source_lines,
2334         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2335
2336 2019-01-22  Tom Tromey  <tom@tromey.com>
2337
2338         * remote-fileio.h (struct remote_target): Declare.
2339
2340 2019-01-22  Tom Tromey  <tom@tromey.com>
2341
2342         * python/py-arch.c: Do not include py-ref.h.
2343         * python/py-bpevent.c: Do not include py-ref.h.
2344         * python/py-cmd.c: Do not include py-ref.h.
2345         * python/py-continueevent.c: Do not include py-ref.h.
2346         * python/py-event.h: Do not include py-ref.h.
2347         * python/py-evtregistry.c: Do not include py-ref.h.
2348         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2349         * python/py-frame.c: Do not include py-ref.h.
2350         * python/py-framefilter.c: Do not include py-ref.h.
2351         * python/py-function.c: Do not include py-ref.h.
2352         * python/py-infevents.c: Do not include py-ref.h.
2353         * python/py-linetable.c: Do not include py-ref.h.
2354         * python/py-objfile.c: Do not include py-ref.h.
2355         * python/py-param.c: Do not include py-ref.h.
2356         * python/py-prettyprint.c: Do not include py-ref.h.
2357         * python/py-progspace.c: Do not include py-ref.h.
2358         * python/py-symbol.c: Do not include py-ref.h.
2359         * python/py-symtab.c: Do not include py-ref.h.
2360         * python/py-type.c: Do not include py-ref.h.
2361         * python/py-unwind.c: Do not include py-ref.h.
2362         * python/py-utils.c: Do not include py-ref.h.
2363         * python/py-value.c: Do not include py-ref.h.
2364         * python/py-varobj.c: Do not include py-ref.h.
2365         * python/py-xmethods.c: Do not include py-ref.h.
2366         * python/python.c: Do not include py-ref.h.
2367         * varobj.c: Do not include py-ref.h.
2368
2369 2019-01-22  Tom Tromey  <tom@tromey.com>
2370
2371         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2372         keyword for bcache.
2373
2374 2019-01-22  Tom Tromey  <tom@tromey.com>
2375
2376         * compile/compile-cplus-types.c: Remove a comment by #include.
2377
2378 2019-01-22  Tom Tromey  <tom@tromey.com>
2379
2380         * compile/gcc-c-plugin.h: Include compile-internal.h.
2381
2382 2019-01-22  Tom Tromey  <tom@tromey.com>
2383
2384         * stabsread.c (EXTERN): Do not define.
2385         (symnum, next_symbol_text_func, processing_gcc_compilation)
2386         (within_function, global_sym_chain, global_stabs)
2387         (previous_stab_code, this_object_header_files)
2388         (n_this_object_header_files)
2389         (n_allocated_this_object_header_files): Define.
2390         * stabsread.h (EXTERN): Never define.  Use "extern".
2391
2392 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2393
2394         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2395         history_value.
2396
2397 2019-01-21  Tom Tromey  <tom@tromey.com>
2398
2399         * ui-out.c: Fix includes.
2400         * tui/tui-source.c: Fix includes.
2401         * target.c: Fix includes.
2402         * remote.c: Fix includes.
2403         * regcache.c: Fix includes.
2404         * python/py-block.c: Fix includes.
2405         * printcmd.c: Fix includes.
2406         * or1k-tdep.c: Fix includes.
2407         * mi/mi-main.c: Fix includes.
2408         * m32r-tdep.c: Fix includes.
2409         * csky-tdep.c: Fix includes.
2410         * compile/compile-cplus-types.c: Fix includes.
2411         * cli/cli-interp.c: Fix includes.
2412
2413 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2414
2415         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2416         for padding.
2417
2418 2019-01-16  Tom Tromey  <tom@tromey.com>
2419
2420         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2421         earlier.
2422         (struct objfile) <msymbols_range>: Move from top level.
2423         <msymbols>: New method.
2424         (class objfile_msymbols): Remove.
2425         * symtab.c (default_collect_symbol_completion_matches_break_on):
2426         Update.
2427         * symmisc.c (dump_msymbols): Update.
2428         * stabsread.c (scan_file_globals): Update.
2429         * objc-lang.c (info_selectors_command, info_classes_command)
2430         (find_methods): Update.
2431         * minsyms.c (find_solib_trampoline_target): Update.
2432         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2433         * coffread.c (coff_symfile_read): Update.
2434         * ada-lang.c (ada_lookup_simple_minsym)
2435         (ada_collect_symbol_completion_matches): Update.
2436
2437 2019-01-16  Tom Tromey  <tom@tromey.com>
2438
2439         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2440         type.  Remove no-argument constructor.
2441         <iterator::operator++>: Simplify.
2442         <begin>: Update.
2443         <end>: Use minimal_symbol_count.
2444
2445 2019-01-16  Tom Tromey  <tom@tromey.com>
2446
2447         * objfiles.h (struct objfile) <psymtabs>: New method.
2448         (class objfile_psymtabs): Remove.
2449         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2450         typedef.
2451         <range>: New method.
2452         (require_partial_symbols): Change return type.
2453         * psymtab.c (require_partial_symbols)
2454         (psym_expand_symtabs_matching): Update.
2455         * mdebugread.c (parse_partial_symbols): Update.
2456         * dbxread.c (dbx_end_psymtab): Update.
2457
2458 2019-01-15  Tom Tromey  <tom@tromey.com>
2459
2460         * symtab.c (lookup_objfile_from_block)
2461         (lookup_symbol_in_objfile_symtabs)
2462         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2463         (find_line_symtab, info_sources_command)
2464         (default_collect_symbol_completion_matches_break_on)
2465         (make_source_files_completion_list): Update.
2466         * symmisc.c (print_objfile_statistics, dump_objfile)
2467         (maintenance_print_symbols, maintenance_info_symtabs)
2468         (maintenance_check_symtabs, maintenance_info_line_tables):
2469         Update.
2470         * source.c (select_source_symtab)
2471         (forget_cached_source_info_for_objfile): Update.
2472         * objfiles.h (class objfile_compunits): Remove.
2473         (struct objfile) <compunits_range>: New typedef.
2474         (compunits): New method.
2475         * objfiles.c (objfile_relocate1): Update.
2476         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2477         * maint.c (count_symtabs_and_blocks): Update.
2478         * linespec.c (iterate_over_all_matching_symtabs): Update.
2479         * cp-support.c (add_symbol_overload_list_qualified): Update.
2480         * coffread.c (coff_symtab_read): Update.
2481         * ada-lang.c (add_nonlocal_symbols)
2482         (ada_collect_symbol_completion_matches)
2483         (ada_add_global_exceptions): Update.
2484
2485 2019-01-15  Tom Tromey  <tom@tromey.com>
2486
2487         * progspace.h (program_space) <objfiles_safe_range>: New
2488         typedef.
2489         <objfiles_safe>: New method.
2490         * objfiles.h (class all_objfiles_safe): Remove.
2491         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2492         * jit.c (jit_inferior_exit_hook): Update.
2493
2494 2019-01-17  Tom Tromey  <tom@tromey.com>
2495
2496         * progspace.h (program_space) <objfiles_range>: New typedef.
2497         <objfiles>: New method.
2498         <objfiles_head>: Rename from objfiles.
2499         (object_files): Update.
2500         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2501         * guile/scm-pretty-print.c
2502         (ppscm_find_pretty_printer_from_objfiles): Update.
2503         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2504         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2505         Update.
2506         * python/py-progspace.c (pspy_get_objfiles): Update.
2507         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2508         Update.
2509         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2510         (objfpy_lookup_objfile_by_build_id): Update.
2511         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2512         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2513         Update.
2514         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2515         (expand_symtab_containing_pc, lookup_objfile_from_block)
2516         (lookup_static_symbol, basic_lookup_transparent_type)
2517         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2518         (find_line_symtab, info_sources_command)
2519         (default_collect_symbol_completion_matches_break_on)
2520         (make_source_files_completion_list, find_main_name): Update.
2521         * symmisc.c (print_symbol_bcache_statistics)
2522         (print_objfile_statistics, maintenance_print_symbols)
2523         (maintenance_print_msymbols, maintenance_print_objfiles)
2524         (maintenance_info_symtabs, maintenance_check_symtabs)
2525         (maintenance_expand_symtabs, maintenance_info_line_tables):
2526         Update.
2527         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2528         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2529         (map_overlay_command, unmap_overlay_command)
2530         (simple_overlay_update, expand_symtabs_matching)
2531         (map_symbol_filenames): Update.
2532         * symfile-debug.c (set_debug_symfile): Update.
2533         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2534         Update.
2535         * source.c (select_source_symtab, forget_cached_source_info):
2536         Update.
2537         * solib.c (solib_read_symbols): Update.
2538         * solib-spu.c (append_ocl_sos): Update.
2539         * psymtab.c (maintenance_print_psymbols)
2540         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2541         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2542         * printcmd.c (info_symbol_command): Update.
2543         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2544         Update.
2545         * objfiles.h (class all_objfiles): Remove.
2546         * objfiles.c (have_partial_symbols, have_full_symbols)
2547         (have_minimal_symbols, qsort_cmp, update_section_map)
2548         (shared_objfile_contains_address_p)
2549         (default_iterate_over_objfiles_in_search_order): Update.
2550         * objc-lang.c (info_selectors_command, info_classes_command)
2551         (find_methods): Update.
2552         * minsyms.c (find_solib_trampoline_target): Update.
2553         * maint.c (maintenance_info_sections)
2554         (maintenance_translate_address, count_symtabs_and_blocks):
2555         Update.
2556         * main.c (captured_main_1): Update.
2557         * linux-thread-db.c (try_thread_db_load_from_pdir)
2558         (has_libpthread): Update.
2559         * linespec.c (iterate_over_all_matching_symtabs)
2560         (search_minsyms_for_name): Update.
2561         * jit.c (jit_find_objf_with_entry_addr): Update.
2562         * hppa-tdep.c (find_unwind_entry)
2563         (hppa_lookup_stub_minimal_symbol): Update.
2564         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2565         Update.
2566         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2567         (elf_gnu_ifunc_resolve_by_got): Update.
2568         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2569         * dwarf-index-write.c (save_gdb_index_command): Update.
2570         * cp-support.c (add_symbol_overload_list_qualified): Update.
2571         * breakpoint.c (create_overlay_event_breakpoint)
2572         (create_longjmp_master_breakpoint)
2573         (create_std_terminate_master_breakpoint)
2574         (create_exception_master_breakpoint): Update.
2575         * blockframe.c (find_pc_partial_function): Update.
2576         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2577         (ada_collect_symbol_completion_matches)
2578         (ada_add_global_exceptions): Update.
2579
2580 2019-01-17  Tom Tromey  <tom@tromey.com>
2581
2582         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2583         declare VEC.
2584         (solib_target_parse_libraries): Change return type.
2585         (library_list_start_segment, library_list_start_section)
2586         (library_list_end_library, library_list_start_library); Update.
2587         (solib_target_free_library_list): Remove.
2588         (solib_target_parse_libraries): Remove cleanup.  Change return
2589         type.
2590         (solib_target_current_sos): Update.
2591
2592 2019-01-17  Tom Tromey  <tromey@bapiya>
2593
2594         * valprint.c: Replace "the the" with "the".
2595         * symtab.c: Replace "the the" with "the".
2596         * solib.c: Replace "the the" with "the".
2597         * solib-dsbt.c: Replace "the the" with "the".
2598         * linespec.c: Replace "the the" with "the".
2599         * dwarf2loc.h: Replace "the the" with "the".
2600         * amd64-windows-tdep.c: Replace "the the" with "the".
2601         * aarch64-tdep.c: Replace "the the" with "the".
2602
2603 2019-01-16  Keith Seitz  <keiths@redhat.com>
2604
2605         PR gdb/23773
2606         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2607         <builder>: Rename to ..
2608         <m_builder>: ... this and make private.
2609         (dwarf2_cu::get_builder): New method.  Change all users of
2610         `builder' to use this method.
2611         (dwarf2_start_symtab): Move to ...
2612         (dwarf2_cu::start_symtab): ... here.  Update all callers
2613         (setup_type_unit_groups): Move to ...
2614         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2615         callers.
2616         (dwarf2_cu::reset_builder): New method.
2617         (process_full_compunit, process_full_type_unit): Use
2618         dwarf2_cu::reset_builder.
2619         (follow_die_offset): Record the ancestor CU if it is different
2620         from the followed DIE's CU.
2621         (follow_die_sig_1): Likewise.
2622
2623 2019-01-15  Tom Tromey  <tom@tromey.com>
2624
2625         * remote.c (class remote_state) <buf>: Now a char_vector.
2626         <buf_size>: Remove.
2627         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2628         parameter.
2629         (remote_target::getpkt_or_notif_sane_1)
2630         (remote_target::getpkt_sane)
2631         (remote_target::getpkt_or_notif_sane): Likewise.
2632         (class remote_target) <putpkt>: New overload.
2633         (remote_target::read_frame): Change type of "buf_p".  Remove
2634         sizeof_p parameter.
2635         (packet_ok): New overload.
2636         (packet_check_result): New overload.
2637         Update all uses.
2638
2639 2019-01-14  Tom Tromey  <tom@tromey.com>
2640
2641         * remote-notif.c (handle_notification, remote_notif_ack)
2642         (remote_notif_parse): Make "buf" const.
2643         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2644         const.
2645         (remote_notif_parse, remote_notif_ack, handle_notification):
2646         Likewise.
2647         * remote.c (remote_notif_stop_parse): Make "buf" const.
2648         (remote_target::remote_parse_stop_reply): Make "buf" const.
2649         (remote_notif_stop_ack): Make "buf" const.
2650
2651 2019-01-14  Tom Tromey  <tom@tromey.com>
2652
2653         * remote.c (remote_console_output): Make parameter const.
2654
2655 2019-01-14  Tom Tromey  <tom@tromey.com>
2656
2657         * target-debug.h (target_debug_print_signals): Constify.
2658         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2659         * procfs.c (procfs_target::pass_signals): Update.
2660         * linux-nat.c (linux_nat_target::pass_signals): Update.
2661         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2662         * target-delegates.c: Rebuild.
2663         * remote.c (remote_target::program_signals): Update.
2664         (remote_target::pass_signals): Update.
2665         * target.c (target_pass_signals): Constify argument.
2666         (target_program_signals): Likewise.
2667         * target.h (struct target_ops) <pass_signals, program_signals>:
2668         Constify argument.
2669         (target_pass_signals, target_program_signals): Constify argument.
2670
2671 2019-01-14  Tom Tromey  <tom@tromey.com>
2672
2673         PR tui/28819:
2674         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2675
2676 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2677
2678         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2679         field.
2680         * rs6000-tdep.c: Include reggroups.h.
2681         (IS_V_ALIAS_PSEUDOREG): Define.
2682         (rs6000_register_name): Return names for the "vX" aliases.
2683         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2684         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2685         aliases.  Call default_register_reggroup_p for all other
2686         pseudo-registers.
2687         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2688         New functions.
2689         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2690         Handle "vX" aliases.
2691         (v_alias_pseudo_register_collect): New function.
2692         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2693         (rs6000_gdbarch_init): Initialize "vX" aliases as
2694         pseudo-registers.  Restore registration of
2695         rs6000_pseudo_register_reggroup_p with
2696         set_tdesc_pseudo_register_reggroup_p.
2697
2698 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2699
2700         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2701         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2702         set_gdbarch_num_pseudo_regs.
2703
2704 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2705
2706         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2707         Remove arg prefixname, add do_set and do_show.
2708         Add member functions set_list and show_list.
2709         * cli/cli-style.c (class cli_style_option): Update accordingly.
2710         (style_set_list): Move to file scope.
2711         (style_show_list): Likewise.
2712         (set_style): Call help_list.
2713         (show_style): Call cmd_show_list.
2714         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2715         Update to use the new macro.
2716
2717 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2718
2719         * ada-lang.c (_initialize_ada_language): Expand the help text
2720         for the "catch exception" command.
2721
2722 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2723
2724         * symtab.c (matching_obj_sections): Initialize obj,
2725         declare it closer to its usage.
2726
2727 2019-01-10  Tom Tromey  <tom@tromey.com>
2728
2729         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2730         (basic_inf_threads_range): Remove.
2731         (inf_threads_range, inf_non_exited_threads_range)
2732         (safe_inf_threads_range): Use next_adapter.
2733
2734 2019-01-10  Keith Seitz  <keiths@redhat.com>
2735
2736         PR gdb/23712
2737         PR symtab/23010
2738         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2739         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2740
2741 2019-01-10  Keith Seitz  <keiths@redhat.com>
2742
2743         PR gdb/23712
2744         PR symtab/23010
2745         * dictionary.c (pending_to_vector): Remove.
2746         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2747         Remove _1 suffix, replacing functions of the same name.  Update
2748         all callers.
2749         (dict_create_hashed, dict_create_hashed_expandable)
2750         (dict_create_linear, dict_create_linear_expandable, dict_free)
2751         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2752         Make functions static.
2753
2754 2019-01-10  Keith Seitz  <keiths@redhat.com>
2755
2756         PR gdb/23712
2757         PR symtab/23010
2758         * dictionary.h (struct dictionary): Replace declaration with
2759         multidictionary.
2760         (dict_create_hashed, dict_create_hashed_expandable)
2761         (dict_create_linear, dict_create_linear_expandable)
2762         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2763         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2764         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2765         taking multidictionary argument.
2766         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2767         * block.h (struct block) <dict>: Change to multidictionary
2768         and rename `multidict'.
2769         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2770         symmisc.c: Update all dictionary references to multidictionary.
2771
2772 2019-01-10  Keith Seitz  <keiths@redhat.com>
2773
2774         PR gdb/23712
2775         PR symtab/23010
2776         * dictionary.c: Include unordered_map.
2777         (pending_to_vector): New function.
2778         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2779         Rewrite the non-"_1" functions to take vector instead
2780         of linked list.
2781         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2782         "new" _1 versions of the same name.
2783         (multidictionary): Define.
2784         (std::hash<enum language): New definition.
2785         (collate_pending_symbols_by_language, mdict_create_hashed)
2786         (mdict_create_hashed_expandable, mdict_create_linear)
2787         (mdict_create_linear_expandable, mdict_free)
2788         (find_language_dictionary, create_new_language_dictionary)
2789         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2790         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2791         (mdict_size, mdict_empty): New functions.
2792         * dictionary.h (mdict_iterator): Define.
2793
2794 2019-01-10  Pedro Alves  <palves@redhat.com>
2795
2796         * breakpoint.c (read_uploaded_action)
2797         (create_tracepoint_from_upload): Adjust to use
2798         gdb::unique_xmalloc_ptr.
2799         * ctf.c (ctf_write_uploaded_tp):
2800         (SET_ARRAY_FIELD): Use emplace_back.
2801         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2802         * tracefile-tfile.c (tfile_write_uploaded_tp):
2803         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2804         gdb::unique_xmalloc_ptr.
2805         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2806         at_string, cond_string, cmd_strings>: Replace char pointers
2807         with gdb::unique_xmalloc_ptr.
2808
2809 2019-01-10  Pedro Alves  <palves@redhat.com>
2810
2811         * solib-target.c (library_list_start_library): Don't xstrdup name.
2812
2813 2019-01-10  Pedro Alves  <palves@redhat.com>
2814
2815         * mdebugread.c (parse_partial_symbols): Use
2816         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2817
2818 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2819
2820         * linux-fork.c (scoped_switch_fork_info)
2821         <~scoped_switch_fork_info>: Fix incorrect variable name.
2822
2823 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2824
2825         * linux-fork.c (scoped_switch_fork_info)
2826         <scoped_switch_fork_info>: Make explicit.
2827         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2828
2829 2019-01-10  Tom Tromey  <tom@tromey.com>
2830
2831         * objfiles.h (objfile::reset_psymtabs): Update.
2832         * objfiles.c (objfile::objfile): Update.
2833         * psymtab.h (psymtab_storage::obstack): Update.
2834         (psymtab_storage::m_obstack): Use gdb::optional.
2835         (class psymtab_storage): Update comment.  Remove objfile
2836         parameter.
2837         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2838
2839 2019-01-10  Tom Tromey  <tom@tromey.com>
2840
2841         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2842         <free_psymtabs>: Now private.
2843         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2844         (allocate_psymtab): Use new method.
2845
2846 2019-01-10  Tom Tromey  <tom@tromey.com>
2847
2848         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2849         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2850         * mdebugread.c (parse_partial_symbols): Use
2851         allocate_dependencies.
2852         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2853         allocate_dependencies.
2854         (process_psymtab_comp_unit_reader)
2855         (build_type_psymtab_dependencies): Likewise.
2856         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2857
2858 2019-01-10  Tom Tromey  <tom@tromey.com>
2859
2860         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2861         PSYMBOL_SET_LANGUAGE.
2862         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2863
2864 2019-01-10  Tom Tromey  <tom@tromey.com>
2865
2866         * psymtab.h (psymtab_storage::obstack): New method.
2867         <m_obstack>: Rename from obstack; now private.
2868         * psymtab.c (psymtab_storage): Update.
2869         * dwarf2read.c (create_addrmap_from_index)
2870         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2871         Update.
2872
2873 2019-01-10  Tom Tromey  <tom@tromey.com>
2874
2875         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2876         * objfiles.h (objfile::reset_psymtabs): New method.
2877
2878 2019-01-10  Tom Tromey  <tom@tromey.com>
2879
2880         * symmisc.c (print_symbol_bcache_statistics): Update.
2881         (print_objfile_statistics): Update.
2882         * symfile.c (reread_symbols): Update.
2883         * psymtab.h (class psymtab_storage): New.
2884         * psymtab.c (psymtab_storage): New constructor.
2885         (~psymtab_storage): New destructor.
2886         (require_partial_symbols): Update.
2887         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2888         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2889         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2890         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2891         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2892         (start_psymtab_common, end_psymtab_common)
2893         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2894         (allocate_psymtab): Update.
2895         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2896         Update.
2897         (dump_psymtab_addrmap, maintenance_print_psymbols)
2898         (maintenance_check_psymtabs): Update.
2899         (class objfile_psymtabs): Move to objfiles.h.
2900         * psympriv.h (discard_psymtab): Now inline.
2901         (psymtab_discarder::psymtab_discarder): Update.
2902         (psymtab_discarder::~psymtab_discarder): Update.
2903         (ALL_OBJFILE_PSYMTABS): Rewrite.
2904         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2905         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2906         Remove fields.
2907         <partial_symtabs>: New field.
2908         (class objfile_psymtabs): Move from psymtab.h.  Update.
2909         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2910         psymbol_cache.
2911         (objfile::~objfile): Don't destroy psymbol_cache.
2912         * mdebugread.c (parse_partial_symbols): Update.
2913         * dwarf2read.c (create_addrmap_from_index)
2914         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2915         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2916         (add_partial_subprogram, dwarf2_ranges_read): Update.
2917         * dwarf-index-write.c (write_address_map)
2918         (write_one_signatured_type, recursively_write_psymbols)
2919         (class debug_names, class debug_names, write_psymtabs_to_index):
2920         Update.
2921
2922 2019-01-10  Tom Tromey  <tom@tromey.com>
2923
2924         * symtab.h (SYMBOL_SET_NAMES): Update.
2925         (symbol_set_names): Update.
2926         (MSYMBOL_SET_NAMES): Update.
2927         * symtab.c (symbol_set_names): Change argument to be an
2928         objfile_per_bfd_storage.
2929         * psymtab.c (add_psymbol_to_bcache): Update.
2930         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2931
2932 2019-01-10  Tom Tromey  <tom@tromey.com>
2933
2934         * symtab.c (create_demangled_names_hash): Change argument to be an
2935         objfile_per_bfd_storage.
2936         (symbol_set_names): Update.
2937
2938 2019-01-10  Tom Tromey  <tom@tromey.com>
2939
2940         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2941         init_psymbol_list.
2942         * psymtab.c (init_psymbol_list): Do nothing if already called.
2943         * psympriv.h (init_psymbol_list): Add comment.
2944         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2945         init_psymbol_list.
2946         * dbxread.c (dbx_symfile_read): Unconditionally call
2947         init_psymbol_list.
2948
2949 2019-01-10  Tom Tromey  <tom@tromey.com>
2950
2951         * xcoffread.c (scan_xcoff_symtab): Update.
2952         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2953         "where".
2954         * mdebugread.c (parse_partial_symbols)
2955         (handle_psymbol_enumerators): Update.
2956         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2957         * dbxread.c (read_dbx_symtab): Update.
2958         * psympriv.h (psymbol_placement): New enum.
2959         (add_psymbol_to_list): Update.
2960
2961 2019-01-10  Tom Tromey  <tom@tromey.com>
2962
2963         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2964         static_psymbols parameters.
2965         (scan_xcoff_symtab): Update.
2966         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2967         static_psymbols parameters.
2968         * psympriv.h (start_psymtab_common): Update.
2969         * mdebugread.c (parse_partial_symbols): Update.
2970         * dwarf2read.c (create_partial_symtab): Update.
2971         * dbxread.c (read_dbx_symtab): Update.
2972         (start_psymtab): Remove global_psymbols and static_psymbols
2973         parameters.
2974
2975 2019-01-10  Tom Tromey  <tom@tromey.com>
2976
2977         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2978         * psymtab.c (allocate_psymtab): Add comment.
2979         * psympriv.h (allocate_psymtab): Add comment.
2980         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2981         initializations.
2982         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2983
2984 2019-01-10  Tom Tromey  <tom@tromey.com>
2985
2986         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2987         Don't declare.
2988         * mipsread.c: Include mdebugread.h.
2989         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2990         Declare.
2991         * elfread.c: Include mdebugread.h.
2992
2993 2019-01-09  Tom Tromey  <tom@tromey.com>
2994
2995         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2996         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2997         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2998         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2999         (psym_lookup_symbol, psym_find_last_source_symtab)
3000         (psym_forget_cached_source_info, psym_print_stats)
3001         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3002         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3003         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3004         (psym_find_compunit_symtab_by_address)
3005         (maintenance_print_psymbols, maintenance_info_psymtabs)
3006         (maintenance_check_psymtabs): Use ranged for.
3007         * psymtab.h (class objfile_psymtabs): New.
3008         (require_partial_symbols): Return objfile_psymtabs.
3009         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3010
3011 2019-01-09  Tom Tromey  <tom@tromey.com>
3012
3013         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3014         (find_pc_mapped_section, list_overlays_command)
3015         (map_overlay_command, unmap_overlay_command)
3016         (simple_overlay_update): Use all_objfiles.
3017         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3018         * printcmd.c (info_symbol_command): Use all_objfiles.
3019         * objfiles.h (ALL_OBJSECTIONS): Remove.
3020         * maint.c (maintenance_translate_address): Use all_objfiles.
3021         * gcore.c (gcore_create_callback): Use all_objfiles.
3022         (objfile_find_memory_regions): Likewise.
3023
3024 2019-01-09  Tom Tromey  <tom@tromey.com>
3025
3026         * symtab.c (find_line_symtab, info_sources_command)
3027         (make_source_files_completion_list): Use objfile_compunits.
3028         * source.c (select_source_symtab): Use objfile_compunits.
3029         * objfiles.h (struct objfile): Update comment.
3030         (ALL_OBJFILES): Remove.
3031         (ALL_FILETABS): Remove.
3032         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3033         objfile_compunits.
3034
3035 2019-01-09  Tom Tromey  <tom@tromey.com>
3036
3037         * symmisc.c (print_objfile_statistics, dump_objfile)
3038         (maintenance_print_symbols): Use compunit_filetabs.
3039         * source.c (forget_cached_source_info_for_objfile): Use
3040         compunit_filetabs.
3041         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3042         (ALL_FILETABS): Use compunit_filetabs.
3043         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3044         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3045
3046 2019-01-09  Tom Tromey  <tom@tromey.com>
3047
3048         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3049         (compunit_filetabs): New.
3050         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3051         compunit_filetabs.
3052         (info_sources_command, make_source_files_completion_list): Remove
3053         declaration.
3054         * symmisc.c (print_objfile_statistics, dump_objfile)
3055         (maintenance_print_symbols): Remove declaration.
3056         (maintenance_info_symtabs): Use compunit_filetabs.
3057         (maintenance_info_line_tables): Likewise.
3058         * source.c (select_source_symtab): Change local variable name.
3059         (forget_cached_source_info_for_objfile): Remove declaration.
3060         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3061         * objfiles.c (objfile_relocate1): Remove declaration.
3062         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3063         declaration.
3064         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3065         * coffread.c (coff_symtab_read): Remove declaration.
3066         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3067         compunit_filetabs.
3068
3069 2019-01-09  Tom Tromey  <tom@tromey.com>
3070
3071         * symtab.c (lookup_objfile_from_block)
3072         (find_pc_sect_compunit_symtab, search_symbols)
3073         (default_collect_symbol_completion_matches_break_on): Use
3074         objfile_compunits.
3075         * objfiles.h (ALL_COMPUNITS): Remove.
3076         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3077         * cp-support.c (add_symbol_overload_list_qualified): Use
3078         objfile_compunits.
3079         * ada-lang.c (ada_collect_symbol_completion_matches)
3080         (ada_add_global_exceptions): Use objfile_compunits.
3081
3082 2019-01-09  Tom Tromey  <tom@tromey.com>
3083
3084         * source.c (select_source_symtab)
3085         (forget_cached_source_info_for_objfile): Remove declaration.
3086         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3087         declaration.
3088         * maint.c (count_symtabs_and_blocks): Remove declaration.
3089         * cp-support.c (add_symbol_overload_list_qualified): Remove
3090         declaration.
3091         * coffread.c (coff_symtab_read): Remove declaration.
3092         * symtab.c (lookup_symbol_in_objfile_symtabs)
3093         (basic_lookup_transparent_type_1): Use objfile_compunits.
3094         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3095         (info_sources_command, search_symbols)
3096         (default_collect_symbol_completion_matches_break_on)
3097         (make_source_files_completion_list): Remove declaration.
3098         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3099         (ada_collect_symbol_completion_matches)
3100         (ada_add_global_exceptions): Remove declaration.
3101         * linespec.c (iterate_over_all_matching_symtabs): Use
3102         objfile_compunits.
3103         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3104         (class objfile_compunits): New.
3105         (ALL_COMPUNITS): Use objfile_compunits.
3106         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3107         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3108         objfile_compunits.
3109         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3110
3111 2019-01-09  Tom Tromey  <tom@tromey.com>
3112
3113         * symtab.c (search_symbols)
3114         (default_collect_symbol_completion_matches_break_on): Use
3115         objfile_msymbols.
3116         * ada-lang.c (ada_lookup_simple_minsym)
3117         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3118         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3119         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3120         objfile_msymbols.
3121         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3122         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3123         * objc-lang.c (find_methods): Use objfile_msymbols.
3124         (info_selectors_command, info_classes_command): Likewise.
3125         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3126         * objfiles.h (class objfile_msymbols): New.
3127         (ALL_OBJFILE_MSYMBOLS): Remove.
3128         (ALL_MSYMBOLS): Remove.
3129
3130 2019-01-09  Tom Tromey  <tom@tromey.com>
3131
3132         * common/next-iterator.h (next_adapter): Add Iterator template
3133         parameter.
3134         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3135         (class all_objfiles_safe): New.
3136         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3137         * objfiles.c (put_objfile_before): Update comment.
3138         (add_separate_debug_objfile): Likewise.
3139         (free_all_objfiles): Use all_objfiles_safe.
3140         (objfile_purge_solibs): Likewise.
3141
3142 2019-01-09  Tom Tromey  <tom@tromey.com>
3143
3144         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3145         (expand_symtab_containing_pc, lookup_static_symbol)
3146         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3147         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3148         all_objfiles.
3149         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3150         * breakpoint.c (create_overlay_event_breakpoint)
3151         (create_longjmp_master_breakpoint)
3152         (create_std_terminate_master_breakpoint)
3153         (create_exception_master_breakpoint): Use all_objfiles.
3154         * linux-thread-db.c (try_thread_db_load_from_pdir)
3155         (has_libpthread): Use all_objfiles.
3156         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3157         * linespec.c (iterate_over_all_matching_symtabs)
3158         (search_minsyms_for_name): Use all_objfiles.
3159         * maint.c (maintenance_info_sections): Use all_objfiles.
3160         * main.c (captured_main_1): Use all_objfiles.
3161         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3162         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3163         * guile/scm-pretty-print.c
3164         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3165         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3166         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3167         (maintenance_print_msymbols): Use all_objfiles.
3168         * source.c (select_source_symtab): Use all_objfiles.
3169         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3170         * symfile.c (remove_symbol_file_command)
3171         (expand_symtabs_matching, map_symbol_filenames): Use
3172         all_objfiles.
3173         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3174         all_objfiles.
3175         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3176         * objc-lang.c (find_methods): Use all_objfiles.
3177         * objfiles.c (have_partial_symbols, have_full_symbols)
3178         (have_minimal_symbols, qsort_cmp)
3179         (default_iterate_over_objfiles_in_search_order): Use
3180         all_objfiles.
3181         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3182         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3183         (maintenance_check_psymtabs): Use all_objfiles.
3184         (ALL_PSYMTABS): Remove.
3185         * compile/compile-object-run.c (do_module_cleanup): Use
3186         all_objfiles.
3187         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3188         * cp-support.c (add_symbol_overload_list_qualified): Use
3189         all_objfiles.
3190         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3191         Use all_objfiles.
3192         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3193         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3194         all_objfiles.
3195         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3196         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3197         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3198         Uses all_objfiles.
3199         * solib.c (solib_read_symbols): Use all_objfiles
3200
3201 2019-01-09  Tom Tromey  <tom@tromey.com>
3202
3203         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3204         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3205         all_objfiles.
3206         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3207         * symmisc.c (print_symbol_bcache_statistics)
3208         (print_objfile_statistics, maintenance_print_objfiles)
3209         (maintenance_info_symtabs, maintenance_check_symtabs)
3210         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3211         all_objfiles.
3212         * source.c (forget_cached_source_info): Use all_objfiles.
3213         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3214         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3215         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3216         * objfiles.c (update_section_map): Use all_objfiles.
3217         (shared_objfile_contains_address_p): Likewise.
3218         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3219         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3220
3221 2019-01-09  Tom Tromey  <tom@tromey.com>
3222
3223         * common/next-iterator.h: New file.
3224         * objfiles.h (class all_objfiles): New.
3225         (struct objfile_iterator): New.
3226
3227 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3228
3229         * NEWS: Move the description of the changed "frame", "select-frame",
3230          and "info frame" commands to the Changed commands section.
3231
3232 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3233
3234         * gdbtypes.c (check_stub_method_group): Remove handling of old
3235         mangling schemes.
3236         * linespec.c (find_methods): Likewise.
3237         * stabsread.c (read_member_functions): Likewise.
3238         * valops.c (search_struct_method): Likewise.
3239         (value_struct_elt_for_reference): Likewise.
3240         * NEWS: Mention this change.
3241
3242 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3243
3244         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3245         print_source_lines.
3246         * source.c (print_source_lines_base): Update line number check.
3247         (print_source_lines): New function.
3248         (source_lines_range::source_lines_range): New function.
3249         * source.h (class source_lines_range): New class.
3250         (print_source_lines): New declaration.
3251
3252 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3253
3254         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3255
3256 2019-01-08  Tom Tromey  <tom@tromey.com>
3257             Simon Marchi  <simon.marchi@ericsson.com>
3258
3259         PR gdb/24060
3260         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3261         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3262         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3263         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3264         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3265         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3266
3267 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3268
3269         * source.c (select_source_symtab): Move header comment to
3270         declaration in source.h.
3271         (forget_cached_source_info_for_objfile): Likewise.
3272         (forget_cached_source_info): Likewise.
3273         (identify_source_line): Likewise.
3274         * source.h (identify_source_line): Move declaration from symtab.h
3275         and add comment from source.c
3276         (print_source_lines): Likewise.
3277         (forget_cached_source_info_for_objfile): Likewise.
3278         (forget_cached_source_info): Likewise.
3279         (select_source_symtab): Likewise.
3280         (enum print_source_lines_flag): Move definition from symtab.h.
3281         * symtab.h (identify_source_line): Move declaration to source.h.
3282         (print_source_lines): Likewise.
3283         (forget_cached_source_info_for_objfile): Likewise.
3284         (forget_cached_source_info): Likewise.
3285         (select_source_symtab): Likewise.
3286         (enum print_source_lines_flag): Move definition to source.h.
3287         * tui/tui-hooks.c: Add 'source.h' include.
3288
3289 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3290
3291         * source.c (print_source_lines_base): Handle requests to print
3292         reverse line number sequences, and guard against empty lines
3293         string.
3294
3295 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3296
3297         * source.c (print_source_lines_base): Fix skip of '\r' if next
3298         character is '\n'.
3299
3300 2019-01-06  Tom Tromey  <tom@tromey.com>
3301
3302         * c-exp.y (struct c_parse_state) <macro_original_text,
3303         expansion_obstack>: New member.
3304         (macro_original_text, expansion_obstack): Remove globals.
3305         (scan_macro_expansion, scanning_macro_expansion)
3306         (finished_macro_expansion): Update.
3307         (scan_macro_cleanup): Remove.
3308         (yylex, c_parse): Update.
3309
3310 2019-01-06  Tom Tromey  <tom@tromey.com>
3311
3312         * c-exp.y (struct c_parse_state) <strings>: New member.
3313         (operator_stoken): Update.
3314
3315 2019-01-06  Tom Tromey  <tom@tromey.com>
3316
3317         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3318         (union type_stack_elt) <typelist_val>: Now a pointer to
3319         std::vector.
3320         (type_stack_cleanup): Don't declare.
3321         (push_typelist): Update.
3322         * parse.c (pop_typelist): Return a std::vector.
3323         (push_typelist): Take a std::vector.
3324         (follow_types): Update.  Do not free args.
3325         (type_stack_cleanup): Remove.
3326         * c-exp.y (struct c_parse_state): New.
3327         (cpstate): New global.
3328         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3329         (nonempty_typelist): Update.
3330         (func_mod): Create a new vector.
3331         (c_parse): Create a c_parse_state.
3332         (check_parameter_typelist): Do not delete params.
3333         (function_method): Update.  Do not delete type_list.
3334
3335 2019-01-06  Tom Tromey  <tom@tromey.com>
3336
3337         PR gdb/28155:
3338         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3339         check_typedef.
3340         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3341         (print_return_value): Likewise.
3342
3343 2019-01-05  Tom Tromey  <tom@tromey.com>
3344
3345         * contrib/cleanup_check.py: Remove.
3346         * contrib/gcc-with-excheck: Remove.
3347         * contrib/exsummary.py: Remove.
3348         * contrib/excheck.py: Remove.
3349
3350 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3351
3352         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3353         NULL. Initialize tpprev to NULL instead of assigning it
3354         to NULL on the next statement.
3355         * windows-nat.c (windows_delete_thread): Remove check for
3356         main_thread_id before printing thread exit notifications.
3357         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3358         Remove thread ID check against main_thread_id.
3359         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3360         windows_delete_thread.
3361         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3362
3363 2019-01-04  Tom Tromey  <tom@tromey.com>
3364
3365         * compile/compile.c (_initialize_compile): Use upper case for
3366         metasyntactic variables.
3367         * symmisc.c (_initialize_symmisc): Use upper case for
3368         metasyntactic variables.
3369         * psymtab.c (_initialize_psymtab): Use upper case for
3370         metasyntactic variables.
3371         * demangle.c (demangle_command): Use upper case for metasyntactic
3372         variables.
3373         (_initialize_demangler): Likewise.
3374         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3375         variables.
3376
3377 2019-01-03  Tom Tromey  <tom@tromey.com>
3378
3379         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3380
3381 2019-01-03  Tom Tromey  <tom@tromey.com>
3382
3383         * python/py-symtab.c (salpy_str): Update.
3384         (struct salpy_sal_object) <symtab>: Now a PyObject.
3385         (salpy_dealloc): Update.
3386         (del_objfile_sal): Use gdbpy_ref.
3387
3388 2019-01-03  Tom Tromey  <tom@tromey.com>
3389
3390         * python/py-type.c (convert_field): Use new_reference.  Return
3391         gdbpy_ref.
3392         (make_fielditem): Return gdbpy_ref.
3393         (typy_fields): Update.
3394         (typy_getitem): Update.
3395         (field_name): Return gdbpy_ref.  Use new_reference.
3396         (typy_iterator_iternext): Update.
3397
3398 2019-01-03  Tom Tromey  <tom@tromey.com>
3399
3400         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3401
3402 2019-01-03  Tom Tromey  <tom@tromey.com>
3403
3404         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3405         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3406         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3407         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3408         (pspy_set_type_printers): Likewise.
3409         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3410         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3411         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3412         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3413         (objfpy_set_type_printers): Likewise.
3414
3415 2019-01-03  Tom Tromey  <tom@tromey.com>
3416
3417         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3418         (gdbpy_print_stack): Use gdbpy_err_fetch.
3419         * python/python-internal.h (class gdbpy_err_fetch): New class.
3420         (class gdbpy_enter) <m_error_type, m_error_value,
3421         m_error_traceback>: Remove.
3422         <m_error>: New member.
3423         (gdbpy_exception_to_string): Don't declare.
3424         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3425         * python/py-value.c (convert_value_from_python): Use
3426         gdbpy_err_fetch.
3427         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3428         gdbpy_exception_to_string.
3429         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3430         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3431         gdbpy_err_fetch.
3432
3433 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3434
3435         * linux-nat.c (delete_lwp_cleanup): Delete.
3436         (struct lwp_deleter): New struct.
3437         (lwp_info_up): New typedef.
3438         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3439         lwp_info_up.
3440
3441 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3442
3443         * linux-fork.c (class scoped_switch_fork_info): New class.
3444         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3445
3446 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3447
3448         * valops.c (find_overload_match): Remove use of null_cleanup, and
3449         calls to do_cleanups.
3450
3451 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3452
3453         * compile/compile-cplus-types.c
3454         (compile_cplus_instance::decl_name): Handle changes to
3455         cp_func_name.
3456         * cp-support.c (cp_func_name): Update header comment, update
3457         return type.
3458         * cp-support.h (cp_func_name): Update return type in declaration.
3459         * valops.c (find_overload_match): Move temp_func local to top
3460         level of function and change its type.  Use temp_func to hold and
3461         delete temporary string obtained from cp_func_name.
3462
3463 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3464
3465         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3466         gdb::char_vector, remove cleanup, and update uses of `msg`.
3467
3468 2019-01-03  Jim Wilson  <jimw@sifive.com>
3469
3470         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3471
3472 2019-01-02  Tom Tromey  <tom@tromey.com>
3473
3474         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3475         (tdesc_parse_xml): Remove cleanups.
3476         * target-descriptions.h (make_cleanup_free_target_description):
3477         Don't declare.
3478         (target_desc_deleter): New struct.
3479         (target_desc_up): New typedef.
3480         * target-descriptions.c (target_desc_deleter::operator()): Rename
3481         from free_target_description.
3482         (make_cleanup_free_target_description): Remove.
3483
3484 2019-01-02  Tom Tromey  <tom@tromey.com>
3485
3486         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3487         constructor, destructor.
3488         (linespec_parser): Remove typedef.
3489         (~linespec_parser): Rename from linespec_parser_delete.
3490         (linespec_lex_to_end, linespec_complete_label)
3491         (linespec_complete): Update.
3492         (decode_line_full): Remove cleanups.
3493         (decode_line_1): Update.
3494
3495 2019-01-02  Tom Tromey  <tom@tromey.com>
3496
3497         * python/python-internal.h (inferior_to_inferior_object): Change
3498         return type.
3499         * python/py-exitedevent.c (create_exited_event_object): Update.
3500         * python/py-inferior.c (inferior_to_inferior_object): Return
3501         gdbpy_ref.
3502         (python_new_inferior, python_inferior_deleted)
3503         (thread_to_thread_object, delete_thread_object)
3504         (build_inferior_list, gdbpy_selected_inferior): Update.
3505         * python/py-infthread.c (create_thread_object): Update.  Also fail
3506         if inferior_to_inferior_object fails.
3507
3508 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3509
3510         * inferior.h (class inferior) <displaced_step_state>: New field.
3511         * infrun.h (struct displaced_step_state): Move here from
3512         infrun.c.  Initialize fields, add constructor.
3513         <inf>: Remove field.
3514         <reset>: New method.
3515         * infrun.c (struct displaced_step_inferior_state): Move to
3516         infrun.h.
3517         (displaced_step_inferior_states): Remove.
3518         (get_displaced_stepping_state): Adust.
3519         (displaced_step_in_progress_any_inferior): Adjust.
3520         (displaced_step_in_progress_thread): Adjust.
3521         (displaced_step_in_progress): Adjust.
3522         (add_displaced_stepping_state): Remove.
3523         (get_displaced_step_closure_by_addr): Adjust.
3524         (remove_displaced_stepping_state): Remove.
3525         (infrun_inferior_exit): Call displaced_step_state.reset.
3526         (use_displaced_stepping): Don't check for NULL.
3527         (displaced_step_prepare_throw): Call
3528         get_displaced_stepping_state.
3529         (displaced_step_fixup): Don't check for NULL.
3530         (prepare_for_detach): Don't check for NULL.
3531
3532 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3533
3534         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3535          in case of call that did not complete.
3536
3537 2019-01-02  Andrey Utkin  <autkin@undo.io>
3538
3539         * symfile.c (find_separate_debug_file): Fix search of debug files for
3540         remote debuggee.
3541
3542 2019-01-02  Tom Tromey  <tom@tromey.com>
3543
3544         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3545         indentation.
3546         * python/py-frame.c (frapy_older): Remove cast.
3547         (frapy_newer): Likewise.
3548         * python/py-breakpoint.c (local_setattro): Remove cast.
3549         * python/py-arch.c (archpy_name): Remove local variable.
3550         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3551
3552 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3553
3554         * unittests/basic_string_view/element_access/char/empty.cc:
3555         Fix year range in copyright header.
3556
3557 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3558
3559         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3560         Delete.
3561         <operator==>: Update with for removed field.
3562         <hash>: Likewise.
3563         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3564         <isa_features>: ...this.
3565         <abi_features>: New field.
3566         (riscv_isa_flen): Update comment.
3567         (riscv_abi_xlen): New declaration.
3568         (riscv_abi_flen): New declaration.
3569         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3570         isa_features.
3571         (riscv_abi_xlen): New function.
3572         (riscv_isa_flen): Update to get answer from isa_features.
3573         (riscv_abi_flen): New function.
3574         (riscv_has_fp_abi): Update to get answer from abi_features.
3575         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3576         xlen and flen.
3577         (riscv_call_info) <xlen, flen>: Update comment.
3578         (riscv_call_arg_struct): Remove invalid assertions
3579         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3580         is removed.
3581         (riscv_gdbarch_init): Gather isa features and abi features
3582         separately, ensure both match on the gdbarch when reusing an old
3583         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3584         a target with 64-bit float hardware.
3585
3586 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3587
3588         * source.c (search_command_helper): Stop reverse search
3589         when line 1 has been searched.
3590
3591 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3592
3593         * record-full.c (record_full_base_target::close): Rewrite
3594         record_full_core_buf_list free logic.
3595
3596 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3597
3598         * break-catch-syscall.c (print_one_catch_syscall): xfree
3599         the last text.
3600
3601 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3602
3603         * top.c (print_gdb_version): Update Copyright year in version
3604         message.
3605
3606 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3607
3608         Update copyright year range in all GDB files.
3609
3610 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3611
3612         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3613
3614 For older changes see ChangeLog-2018.
3615 \f
3616 Local Variables:
3617 mode: change-log
3618 left-margin: 8
3619 fill-column: 74
3620 version-control: never
3621 coding: utf-8
3622 End:
3623