gdb/ChangeLog

   1 2019-08-15  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
   4         examine tui_win_list.
   5
   6 2019-08-15  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
   9         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
  10         tui_clear_source_content.
  11         (tui_clear_source_content): Remove.
  12         (tui_source_window_base::do_erase_source_content): Hoist call to
  13         content.clear().
  14         * tui/tui-stack.c (tui_show_frame_info): Don't call
  15         tui_clear_source_content.
  16
  17 2019-08-15  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-winsource.h (struct tui_source_window_base)
  20         <do_erase_source_content>: New method.
  21         <erase_source_content>: New method.
  22         (tui_erase_source_content): Don't declare.
  23         * tui/tui-winsource.c (tui_clear_source_content): Update.
  24         (tui_source_window_base::do_erase_source_content): Rename from
  25         tui_erase_source_content.
  26         (tui_source_window_base::show_source_content): Update.
  27         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  28         * tui/tui-source.h (struct tui_source_window)
  29         <erase_source_content>: New method.
  30         * tui/tui-disasm.h (struct tui_disasm_window)
  31         <erase_source_content>: New method.
  32
  33 2019-08-15  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
  36         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
  37         constructor.
  38         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
  39         * tui/tui-source.c (tui_set_source_content): Update.
  40         * tui/tui-disasm.c (tui_set_disassem_content): Update.
  41
  42 2019-08-15  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
  45         * tui/tui-winsource.c (tui_line_is_displayed): Move to
  46         tui-source.c.
  47         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
  48         Declare.
  49         * tui/tui-source.c (tui_source_window::line_is_displayed): New
  50         method.
  51         (tui_source_window::maybe_update): Update.
  52
  53 2019-08-15  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
  56         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
  57         tui-disasm.c.
  58         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
  59         Declare.
  60         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
  61         method.
  62         (tui_disasm_window::maybe_update): Update.
  63
  64 2019-08-15  Tom Tromey  <tom@tromey.com>
  65
  66         * tui/tui-winsource.h (struct tui_source_window_base)
  67         <maybe_update>: Declare.
  68         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
  69         method.
  70         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
  71         Declare.
  72         * tui/tui-source.c (tui_source_window::maybe_update): New method.
  73         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
  74         Declare.
  75         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
  76
  77 2019-08-15  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
  80
  81 2019-08-15  Tom Tromey  <tom@tromey.com>
  82
  83         * tui/tui-wingeneral.c: Include tui-stack.h.
  84         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
  85         (struct tui_locator_window): Move from tui-data.h.
  86         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
  87         (tui_initialize_static_data): Move from tui-data.c.
  88         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
  89         (struct tui_locator_window): Move to tui-stack.c.
  90         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
  91         (tui_initialize_static_data): Move to tui-stack.c.
  92
  93 2019-08-15  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-layout.c (show_source_disasm_command)
  96         (show_source_or_disasm_and_command): Use make_visible method, not
  97         tui_make_window.
  98         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
  99         Remove.
 100
 101 2019-08-15  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-wingeneral.h (tui_make_window): Update.
 104         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 105         parameter.
 106         (tui_gen_win_info::make_visible): Update.
 107         * tui/tui-regs.c (tui_data_window::display_registers_from):
 108         Update.
 109         * tui/tui-layout.c (show_source_disasm_command)
 110         (show_source_or_disasm_and_command): Update.
 111         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 112         (enum tui_box): Remove.
 113         (struct tui_win_info) <can_box>: New method.
 114         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 115         method.
 116
 117 2019-08-15  Tom de Vries  <tdevries@suse.de>
 118
 119         * linux-nat-trad.c: Include gdbarch.h.
 120
 121 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 122
 123         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 124         register sizes.
 125
 126 2019-08-14  Tom Tromey  <tromey@adacore.com>
 127
 128         * darwin-nat.c: Include gdbarch.h.
 129         * darwin-nat-info.c: Include gdbarch.h.
 130
 131 2019-08-13  Tom Tromey  <tom@tromey.com>
 132
 133         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 134         Remove.
 135         * tui/tui-data.c (tui_initialize_static_data): Update.
 136
 137 2019-08-13  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-winsource.h (struct tui_exec_info_window)
 140         <~tui_exec_info_window, maybe_allocate_content, get_content,
 141         m_content>: Remove.
 142         (struct tui_source_window_base) <set_exec_info_content,
 143         show_exec_info_content>: Don't declare.
 144         * tui/tui-winsource.c
 145         (tui_exec_info_window::maybe_allocate_content): Remove.
 146         (tui_source_window_base::update_exec_info): Rename from
 147         set_exec_info_content.
 148         (tui_source_window_base::show_exec_info_content)
 149         (tui_source_window_base::update_exec_info): Remove.
 150
 151 2019-08-13  Tom Tromey  <tom@tromey.com>
 152
 153         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 154         declare.
 155         * tui/tui-winsource.c (tui_update_source_window_as_is)
 156         (tui_update_source_windows_with_addr, tui_erase_source_content):
 157         Update.
 158         (tui_clear_exec_info_content): Remove.
 159
 160 2019-08-13  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 163         declare.
 164         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 165         call tui_erase_exec_info_content.
 166         (tui_clear_exec_info_content): Rename from
 167         tui_erase_exec_info_content.
 168         (tui_clear_exec_info_content): Delete.
 169
 170 2019-08-13  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-winsource.h (struct tui_source_window_base)
 173         <show_exec_info_content>: Declare.
 174         (tui_show_exec_info_content): Don't declare.
 175         * tui/tui-winsource.c
 176         (tui_source_window_base::show_exec_info_content): Rename from
 177         tui_show_exec_info_content.
 178         (tui_source_window_base::update_exec_info): Update.
 179
 180 2019-08-13  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 183         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 184         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 185         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 186         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 187         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 188         ... here.
 189
 190 2019-08-13  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-winsource.h (struct tui_source_window_base)
 193         <update_exec_info>: Declare.
 194         (tui_update_exec_info): Don't declare.
 195         * tui/tui-winsource.c (tui_update_source_window_as_is)
 196         (tui_source_window_base::refresh_all)
 197         (tui_update_all_breakpoint_info): Update.
 198         (tui_source_window_base::update_exec_info): Rename from
 199         tui_update_exec_info.
 200         * tui/tui-stack.c (tui_show_frame_info): Update.
 201
 202 2019-08-13  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-winsource.h (struct tui_source_window_base)
 205         <set_exec_info_content>: Declare.
 206         (tui_set_exec_info_content): Don't declare.
 207         * tui/tui-winsource.c
 208         (tui_source_window_base::set_exec_info_content): Rename from
 209         tui_set_exec_info_content.
 210         (tui_update_exec_info): Update.
 211
 212 2019-08-13  Tom Tromey  <tom@tromey.com>
 213
 214         * tui/tui-winsource.h (struct tui_source_window_base)
 215         <show_source_content>: Declare.
 216         (tui_show_source_content): Don't declare.
 217         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 218         (tui_source_window_base::show_source_content): Rename from
 219         tui_show_source_content.
 220         (tui_source_window_base::refresh_all): Update.
 221         * tui/tui-layout.c (show_source_disasm_command)
 222         (show_source_or_disasm_and_command): Update.
 223
 224 2019-08-13  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-winsource.c (tui_erase_source_content)
 227         (tui_show_source_content, tui_source_window_base::refresh_all):
 228         Update.
 229         * tui/tui-wingeneral.h
 230         (tui_check_and_display_highlight_if_needed): Don't declare.
 231         * tui/tui-wingeneral.c
 232         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 233         check_and_display_highlight_if_needed.
 234         * tui/tui-win.c (tui_rehighlight_all)
 235         (tui_win_info::make_visible_with_new_height): Update.
 236         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 237         (tui_data_window::erase_data_content)
 238         (tui_data_window::display_all_data): Update.
 239         * tui/tui-data.h (struct tui_win_info)
 240         <check_and_display_highlight_if_needed>: Declare.
 241
 242 2019-08-13  Tom Tromey  <tom@tromey.com>
 243
 244         * tui/tui-win.c (tui_resize_all): Call
 245         tui_delete_invisible_windows.
 246         * tui/tui-layout.c (show_layout): Call
 247         tui_delete_invisible_windows.
 248         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 249         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 250
 251 2019-08-13  Tom Tromey  <tom@tromey.com>
 252
 253         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 254         tui_add_win_to_layout.
 255
 256 2019-08-13  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 259         * tui/tui-layout.c (tui_default_win_height): Now static.
 260
 261 2019-08-13  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 264         single switch.
 265         (show_source_disasm_command, show_source_or_disasm_and_command):
 266         Don't check current layout.
 267
 268 2019-08-13  Tom Tromey  <tom@tromey.com>
 269
 270         * tui/tui-wingeneral.c (make_all_visible): Remove.
 271         (tui_make_all_invisible): Simplify.
 272         * tui/tui-layout.c (tui_make_all_invisible): Move from
 273         tui-wingeneral.c; simplify.
 274         (show_layout): Hoist call to tui_make_all_invisible.
 275         (show_data): Don't call tui_make_all_invisible.
 276
 277 2019-08-13  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 280         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 281
 282 2019-08-13  Tom Tromey  <tom@tromey.com>
 283
 284         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 285         tui-data.c.
 286         (show_source_disasm_command, show_data)
 287         (show_source_or_disasm_and_command): Don't use
 288         tui_set_current_layout_to.
 289         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 290         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 291         tui-layout.c.
 292         (tui_set_current_layout_to): Remove.
 293
 294 2019-08-13  Tom Tromey  <tom@tromey.com>
 295
 296         * tui/tui-layout.c (tui_set_layout): Update.
 297         * tui/tui-data.h (struct tui_layout_def): Remove.
 298         (tui_layout_def): Don't declare.
 299         * tui/tui-data.c (layout_def): Remove.
 300         (tui_layout_def): Remove.
 301
 302 2019-08-13  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-winsource.h (struct tui_source_window_base)
 305         <clear_detail>: No longer "override".
 306         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 307         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 308         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 309         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 310         Remove.
 311         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 312
 313 2019-08-13  Tom Tromey  <tromey@adacore.com>
 314
 315         * tracepoint.c: Don't include readline.h or history.h.
 316
 317 2019-08-12  Tom Tromey  <tom@tromey.com>
 318
 319         * configure: Rebuild.
 320         * configure.ac: Check for readline 7.
 321         * NEWS: Mention readline 7 requirement.
 322         * README: Update.
 323
 324 2019-08-12  Tom Tromey  <tom@tromey.com>
 325
 326         * mingw-hdep.c (gdb_select): Remove readline hack.
 327
 328 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 329
 330         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 331         when the function fails.
 332
 333 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 334
 335         * s390-tdep.c (s390_type_align): New function.
 336         (s390_gdbarch_init): Set it as type_align gdbarch method.
 337
 338 2019-08-09  Tom de Vries  <tdevries@suse.de>
 339
 340         PR gdb/24591
 341         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 342         pc_low with relocation offset.
 343
 344 2019-08-07  Tom Tromey  <tromey@adacore.com>
 345
 346         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 347         (print_frame_args): Update.
 348         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 349         Update.
 350         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 351         * frame.h (struct frame_arg): Add initializers.
 352         <error>: Now a unique_xmalloc_ptr.
 353
 354 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 355
 356         * NEWS: Expand the Pointer Authentication entry.
 357         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 358         (aarch64_frame_unmask_lr): ... to this.
 359         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 360         Call aarch64_frame_unmask_lr.
 361         * frame.c (struct frame_info): Add "masked" variable.
 362         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 363         (fprint_frame): Check for masked pc.
 364         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 365         declarations.
 366         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 367         * stack.c (print_frame): Check for masked pc.
 368
 369 2019-08-06  Tom Tromey  <tom@tromey.com>
 370
 371         * stabsread.c (patch_block_stabs, read_one_struct_field)
 372         (read_enum_type): Use obstack_strndup.
 373         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 374         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 375         * dwarf2read.c (guess_full_die_structure_name)
 376         (anonymous_struct_prefix): Use obstack_strndup.
 377         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 378         * c-exp.y (yylex): Use obstack_strndup.
 379         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 380         (write_var_or_type): Use obstack_strndup.
 381
 382 2019-08-06  Tom Tromey  <tom@tromey.com>
 383
 384         * symfile.c (reread_symbols): Use obstack_strdup.
 385         * stabsread.c (read_type): Use obstack_strdup.
 386         * gdb_obstack.h (obstack_strdup): New overload.
 387         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 388         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 389         (dwarf2_canonicalize_name): Use obstack_strdup.
 390         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 391         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 392         Use obstack_strdup.
 393
 394 2019-08-06  Tom Tromey  <tom@tromey.com>
 395
 396         * gdb_obstack.h (obstack_strdup): Define.
 397         * gdb_obstack.c (obstack_strdup): Don't define.
 398
 399 2019-08-06  Tom Tromey  <tom@tromey.com>
 400
 401         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 402         obstack_strdup.
 403         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 404         obstack_strdup.
 405         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 406         * stabsread.c (common_block_start): Use obstack_strdup.
 407         * objfiles.c (set_objfile_main_name, objfile): Use
 408         obstack_strdup.
 409         * namespace.c (add_using_directive): Use obstack_strdup.
 410         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 411         * jit.c (finalize_symtab): Use obstack_strdup.
 412         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 413         (guess_partial_die_structure_name, partial_die_info::fixup)
 414         (dwarf2_name): Use obstack_strdup.
 415         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 416         obstack_strdup.
 417         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 418         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 419         obstack_strdup.
 420         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 421
 422 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 423
 424         * unittests/help-doc-selftests.c: New file.
 425         * Makefile.in: Add the new file.
 426
 427 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 428
 429         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 430         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 431         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 432         the trailing '.' is not output, and the first character is uppercased.
 433         (print_help_for_command): Update call to print_doc_line.
 434         (print_doc_of_command): Likewise.
 435         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 436         * cli/cli-option.c (append_indented_doc): Do not append newline.
 437         (build_help_option): Append newline after first appended_indented_doc
 438         only if a second call is done.
 439         (build_help): Append 2 new lines before each option, except the first
 440         one.
 441         * compile/compile.c (_initialize_compile): Add new lines after
 442         %OPTIONS%, when not at the end of the help.
 443         Change help doc or code
 444         producing the help doc to respect the invariants.
 445         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 446         Also removed the new line after 'Options:', as all other commands
 447         do not put an empty line between 'Options:' and the first option.
 448         * printcmd.c (_initialize_printcmd): Likewise.
 449         * stack.c (_initialize_stack): Likewise.
 450         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 451         incorrectly telling COMMAND is optional.
 452         * ada-lang.c (_initialize_ada_language): Change help doc or code
 453         producing the help doc to respect the invariants.
 454         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 455         * breakpoint.c (_initialize_breakpoint): Likewise.
 456         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 457         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 458         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 459         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 460         _initialize_cli_style): Likewise.
 461         * corelow.c (core_target_info): Likewise.
 462         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 463         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 464         * filesystem.c (_initialize_filesystem): Likewise.
 465         * frame.c (_initialize_frame): Likewise.
 466         * gnu-nat.c (add_task_commands): Likewise.
 467         * infcall.c (_initialize_infcall): Likewise.
 468         * infcmd.c (_initialize_infcmd): Likewise.
 469         * interps.c (_initialize_interpreter): Likewise.
 470         * language.c (_initialize_language): Likewise.
 471         * linux-fork.c (_initialize_linux_fork): Likewise.
 472         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 473         * maint.c (_initialize_maint_cmds): Likewise.
 474         * memattr.c (_initialize_mem): Likewise.
 475         * printcmd.c (_initialize_printcmd): Likewise.
 476         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 477         _RegEx): Likewise.
 478         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 479         * record-btrace.c (_initialize_record_btrace): Likewise.
 480         * record-full.c (_initialize_record_full): Likewise.
 481         * record.c (_initialize_record): Likewise.
 482         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 483         * regcache.c (_initialize_regcache): Likewise.
 484         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 485         _initialize_remote): Likewise.
 486         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 487         * serial.c (_initialize_serial): Likewise.
 488         * skip.c (_initialize_step_skip): Likewise.
 489         * source.c (_initialize_source): Likewise.
 490         * stack.c (_initialize_stack): Likewise.
 491         * symfile.c (_initialize_symfile): Likewise.
 492         * symtab.c (_initialize_symtab): Likewise.
 493         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 494         * top.c (init_main): Likewise.
 495         * tracefile-tfile.c (tfile_target_info): Likewise.
 496         * tracepoint.c (_initialize_tracepoint): Likewise.
 497         * tui/tui-win.c (_initialize_tui_win): Likewise.
 498         * utils.c (add_internal_problem_command): Likewise.
 499         * valprint.c (value_print_option_defs): Likewise.
 500
 501 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 502
 503         PR build/24886
 504         * configure.ac: Drop enable-libmcheck support.
 505         * configure, config.in: Rebuild.
 506         * libmcheck.m4: Remove.
 507         * acinclude.m4: Don't include it.
 508         * Makefile.in: Don't distribute it.
 509         * top.c (print_gdb_configuration): Don't mention it.
 510
 511 2019-08-06  Tom Tromey  <tom@tromey.com>
 512
 513         * utils.c (set_output_style): Sometimes pass stream to
 514         emit_style_escape.
 515         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 516         * record-btrace.c (btrace_insn_history): Update.
 517         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 518         method.
 519         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 520         Update initializers.
 521         <m_uiout>: New field.
 522         <m_di>: Move lower.
 523         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 524         Remove "uiout" parameter.
 525         (dump_insns): Update.
 526         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 527         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 528
 529 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 530
 531         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 532         (error_in_psymtab_expansion): Likewise.
 533         (lookup_symbol_via_quick_fns): Likewise.
 534         (basic_lookup_transparent_type_quick): Likewise.
 535         (basic_lookup_transparent_type_1): Likewise.
 536
 537 2019-08-06  Tom Tromey  <tromey@adacore.com>
 538
 539         * source.c (last_source_error): Now bool.
 540         (print_source_lines_base): Make "noprint" bool.  Only open
 541         source file when last_source_visited changes.
 542
 543 2019-08-06  Tom Tromey  <tromey@adacore.com>
 544
 545         * annotate.c (annotate_source_line): Use g_source_cache.
 546         * source-cache.c (source_cache::get_plain_source_lines): Change
 547         parameters.  Populate m_offset_cache.
 548         (source_cache::ensure): New method.
 549         (source_cache::get_line_charpos): New method.
 550         (extract_lines): Move lower.  Change parameters.
 551         (source_cache::get_source_lines): Move lower.
 552         * source-cache.h (class source_cache): Update comment.
 553         <get_line_charpos>: New method.
 554         <get_source_lines>: Update comment.
 555         <clear>: Clear m_offset_cache.
 556         <get_plain_source_lines>: Change parameters.
 557         <ensure>: New method
 558         <m_offset_cache>: New member.
 559         * source.c (forget_cached_source_info_for_objfile): Update.
 560         (info_source_command): Use g_source_cache.
 561         (find_source_lines, open_source_file_with_line_charpos): Remove.
 562         (print_source_lines_base, search_command_helper): Use g_source_cache.
 563         * source.h (open_source_file_with_line_charpos): Don't declare.
 564         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 565         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 566         Use g_source_cache.
 567
 568 2019-08-06  Tom Tromey  <tromey@adacore.com>
 569
 570         * source-cache.c (source_cache::get_plain_source_lines):
 571         Remove "first_line" and "last_line" parameters.
 572         (source_cache::get_source_lines): Cache plain text.
 573         * source-cache.h (class source_cache)
 574         <get_plain_source_lines>: Update.
 575
 576 2019-08-06  Tom Tromey  <tromey@adacore.com>
 577
 578         * source-cache.c (extract_lines): No longer a method.
 579         Changed type of parameter.  Include final newline.
 580         (selftests::extract_lines_test): New function.
 581         (_initialize_source_cache): Likewise.
 582         * source-cache.h (class source_cache)
 583         <extract_lines>: Don't declare.
 584
 585 2019-08-06  Tom Tromey  <tromey@adacore.com>
 586
 587         * breakpoint.c (init_breakpoint_sal): Update.
 588         (breakpoint): Update.
 589         * breakpoint.h (struct breakpoint) <filter>: Now a
 590         unique_xmalloc_ptr.
 591
 592 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 593
 594         * NEWS: Mention dictionary access on blocks.
 595         * python/py-block.c (blpy_getitem): New function.
 596         (block_object_as_mapping): New struct.
 597         (block_object_type): Use new struct for tp_as_mapping field.
 598
 599 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 600
 601         * objfiles.h (objfile): Add a comment describing partial symbols.
 602
 603 2019-08-05  Tom Tromey  <tromey@adacore.com>
 604
 605         * compile/compile.c (_initialize_compile): Use _(), not N_().
 606         * thread.c (_initialize_thread): Use _(), not N_().
 607         * stack.c (_initialize_stack): Use _(), not N_().
 608         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 609
 610 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 611
 612         * dwarf2read.c (struct dw2_symtab_iterator):
 613         <want_specific_block>: Remove.
 614         <block_index>: Change type to gdb::optional.
 615         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 616         change type of BLOCK_INDEX parameter to gdb::optional.
 617         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 618         (dw2_lookup_symbol): Don't pass argument for
 619         WANT_SPECIFIC_BLOCK.
 620         (dw2_expand_symtabs_for_function): Don't pass argument for
 621         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 622         (class dw2_debug_names_iterator)
 623         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 624         parameter, change BLOCK_INDEX type to gdb::optional.
 625         <m_want_specific_block>: Remove.
 626         <m_block_index>: Change type to gdb::optional.
 627         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 628         gdb::optional.  Re-write in function of gdb::optional.
 629         (dw2_debug_names_lookup_symbol): Don't pass argument for
 630         WANT_SPECIFIC_BLOCK.
 631         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 632         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 633         BLOCK_INDEX.
 634
 635 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 636
 637         * NEWS: Mention changes to "info sources" command.
 638
 639 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 640
 641         * symtab.c (filename_partial_match_opts): New struct type.
 642         (struct output_source_filename_data): New members
 643         regexp, c_regexp, partial_match.
 644         (output_source_filename): Use new members to decide to print file.
 645         (info_sources_option_defs): New variable.
 646         (make_info_sources_options_def_group, print_info_sources_header,
 647         info_sources_command_completer):
 648         New functions.
 649         (info_sources_command): Read new optional arguments.
 650         (_initialize_symtab): Update info sources help.
 651
 652 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 653
 654         * ada-lang.c (exception_support_info_v0): Renamed from...
 655         (default_exception_support_info): ... this.  Create new
 656         definition for v1.
 657         (ada_has_this_exception_support): Look up catch_handlers_sym.
 658         (ada_exception_support_info_sniffer): Try v0 after default.
 659
 660 2019-08-01  Tom Tromey  <tromey@adacore.com>
 661
 662         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 663         gdbarch.h.
 664
 665 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 666
 667         * s12z-tdep.c: Fix include path for s12z-opc.h.
 668
 669 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 670
 671         * NEWS: Require GNU make 3.82.
 672
 673 2019-07-16  Tom Tromey  <tom@tromey.com>
 674
 675         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 676         declare.
 677
 678 2019-07-30  Tom Tromey  <tromey@adacore.com>
 679
 680         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 681
 682 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 683
 684         * printcmd.c (print_address_symbolic): Print negative offsets.
 685         (build_address_symbolic): Force signed arithmetic when computing
 686         offset.
 687
 688 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 689
 690         PR/24474: Add a function to lookup static variables.
 691         * NEWS: Mention this new function.
 692         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 693         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 694         * python/python.c (python_GdbMethods): Add new function.
 695
 696 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 697
 698         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 699         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 700         (objfpy_lookup_static_symbol): New function.
 701         (objfile_object_methods): Add new functions.
 702
 703 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 704
 705         * NEWS: Mention 'set|show print frame-info'.  Mention new
 706         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 707         backtrace argument.  Mention that python frame filtering code
 708         is now consistent with what 'backtrace' command prints.
 709
 710 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 711
 712         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 713         comments.
 714         (print_frame_info_auto, print_frame_info_source_line,
 715         print_frame_info_location, print_frame_info_source_and_location,
 716         print_frame_info_location_and_address, print_frame_info_short_location):
 717         New declarations.
 718         (struct frame_print_options): New member print_frame_info.
 719         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 720         * stack.h (get_user_print_what_frame_info): New declaration.
 721         (frame_show_address): New declaration.
 722         * stack.c (print_frame_arguments_choices): New value 'presence'.
 723         (print_frame_info_auto, print_frame_info_source_line,
 724         print_frame_info_location, print_frame_info_source_and_location,
 725         print_frame_info_location_and_address, print_frame_info_short_location,
 726         print_frame_info_choices, print_frame_info_print_what): New definitions.
 727         (print_frame_args): Only print dots for args if print frame-arguments
 728         is 'presence'.
 729         (frame_print_option_defs): New element for "frame-info".
 730         (get_user_print_what_frame_info): New function.
 731         (frame_show_address): Make non static.  Move comment to stack.h.
 732         (print_frame_info_to_print_what): New function.
 733         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 734         to decide what to print.
 735         (backtrace_command_1): Handle the new print_frame_arguments_presence
 736         value.
 737         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 738         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 739         (py_print_frame): In non-mi mode, use LOCATION as default for
 740         print_what, similarly to frame information printed directly by
 741         backtrace command. Handle frame-info user option in non MI mode.
 742
 743 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 744
 745         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 746         Add case for debugging 32-bit target on 64-bit host.  Revise
 747         comment.
 748
 749 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 750
 751         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 752         instead of find_function_entry_range_from_pc.
 753
 754 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 755
 756         * stack.c (find_frame_funname): Remove code which preferred
 757         minsym over symtab sym in "certain pathological cases".
 758
 759         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 760         parameter.  Change type of "do_demangle" to bool.
 761         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 762         Pass suitable "prefer_sym_over_minsym" flag to
 763         build_address_symbolic().  Don't output "+" for negative offsets.
 764         * printcmd.c (print_address_symbolic): Update invocation of
 765         build_address_symbolic to include a "prefer_sym_over_minsym"
 766         flag.
 767         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 768         Restrict cases in which use of minimal symbol is preferred to that
 769         of a found symbol.  Update comments.
 770
 771         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 772         for entry pc when entry pc is out of range for that FDE.
 773
 774 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 775
 776         PR gdb/24839:
 777         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 778         type.
 779
 780 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 781
 782         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 783         this function's Python signature.
 784
 785
 786 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 787
 788         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 789         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 790         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 791         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 792         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 793
 794
 795 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 796
 797         * h8300-tdep.c (h8300_register_name_common): New.
 798         h8300_register_name): Use h8300_register_name_common.
 799         (h8300s_register_name): Likewise.
 800         (h8300sx_register_name): Likewise.
 801         (h8300h_register_nam): New.
 802         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 803
 804
 805 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 806
 807         * arm-tdep.c (arm_skip_cmse_entry): New function.
 808         (arm_is_sgstubs_section): New function.
 809         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 810
 811 2019-07-22  Tom Tromey  <tom@tromey.com>
 812
 813         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 814         Don't self-assign.
 815
 816 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 817
 818         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 819         type_print.
 820
 821 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 822
 823         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 824         so that GDB doesn't match any msymbols when searching in the
 825         TYPES_DOMAIN.
 826         (print_symbol_info): Print using typedef_print or type_print based
 827         on the type of the symbol.  Add updated FIXME comment moved from...
 828         (_initialize_symtab): ... move and update FIXME comment to above.
 829
 830 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 831
 832         * NEWS: Mention adding -q option to "info types".
 833         * symtab.c (struct info_types_options): New struct.
 834         (info_types_options_defs): New variable.
 835         (make_info_types_options_def_group): New function.
 836         (info_types_command): Use gdb::option framework to parse options.
 837         (info_types_command_completer): New function.
 838         (_initialize_symtab): Extend the help text on "info types" and
 839         register command completer.
 840
 841 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 842
 843         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 844         (lookup_symbol_in_objfile): Change int to block_enum and add a
 845         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 846
 847 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 848
 849         * MAINTAINERS (Write After Approval): Add self.
 850
 851 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 852
 853         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 854         instruction to the dummy code region.
 855
 856 2019-07-19  Tom Tromey  <tromey@adacore.com>
 857
 858         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 859         (ARGSUSED, PARAMS, __func__): Remove rules.
 860
 861 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 862
 863         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 864         * features/arm/arm-with-iwmmxt.c: Remove.
 865         * features/arm/arm-with-iwmmxt.xml: Remove.
 866         * features/arm/arm-with-m-fpa-layout.c: Remove.
 867         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 868         * features/arm/arm-with-m-vfp-d16.c: Remove.
 869         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 870         * features/arm/arm-with-m.c: Remove.
 871         * features/arm/arm-with-m.xml: Remove.
 872         * features/arm/arm-with-neon.c: Remove.
 873         * features/arm/arm-with-neon.xml: Remove.
 874         * features/arm/arm-with-vfpv2.c: Remove.
 875         * features/arm/arm-with-vfpv2.xml: Remove.
 876         * features/arm/arm-with-vfpv3.c: Remove.
 877         * features/arm/arm-with-vfpv3.xml: Remove.
 878
 879 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 880
 881         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 882
 883 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 884
 885         * arch/aarch32.c (aarch32_create_target_description): Create
 886         target descriptions using features.
 887         * arch/arm.c (arm_create_target_description)
 888         (arm_create_mprofile_target_description): Likewise.
 889         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 890
 891 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 892
 893         * Makefile.in: Add new files.
 894         * aarch32-tdep.c: New file.
 895         * aarch32-tdep.h: New file.
 896         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 897         Call aarch32_read_description.
 898         * arch/aarch32.c: New file.
 899         * arch/aarch32.h: New file.
 900         * arch/arm.c (arm_create_target_description)
 901         (arm_create_mprofile_target_description): New function.
 902         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 903         (arm_create_target_description)
 904         (arm_create_mprofile_target_description): New declaration.
 905         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 906         read_description functions.
 907         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 908         Likewise.
 909         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 910         * arm-tdep.c (tdesc_arm_list): New variable.
 911         (arm_register_g_packet_guesses): Call create description functions.
 912         (arm_read_description) (arm_read_mprofile_description): New
 913         function.
 914         * arm-tdep.h (arm_read_description)
 915         (arm_read_mprofile_description): Add declaration.
 916         * configure.tgt: Add new files.
 917
 918 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 919
 920         * top.c (new_ui_command): Open specified terminal just once.
 921
 922 2019-07-18  Tom Tromey  <tromey@adacore.com>
 923
 924         * symtab.c (main_name): Constify return type.
 925         * symfile.c (set_initial_language): Update.
 926         * symtab.h (main_name): Constify return type.
 927
 928 2019-07-17  Tom Tromey  <tom@tromey.com>
 929
 930         * tui/tui-winsource.c (tui_update_source_window)
 931         (tui_update_source_window_as_is)
 932         (tui_update_source_windows_with_line): Remove return.
 933         * tui/tui-disasm.c (tui_show_disassem)
 934         (tui_show_disassem_and_update_source): Remove return.
 935         * tui/tui.c (tui_reset): Remove return.
 936         * tui/tui-wingeneral.c
 937         (tui_check_and_display_highlight_if_needed): Remove return.
 938
 939 2019-07-17  Tom Tromey  <tom@tromey.com>
 940
 941         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 942
 943 2019-07-17  Tom Tromey  <tom@tromey.com>
 944
 945         * tui/tui-winsource.h (struct tui_exec_info_window)
 946         (struct tui_source_window_base): Move from tui-data.h.
 947         * tui/tui-winsource.c: Move many method definitions from
 948         elsewhere.  Remove "structuring" comments.
 949         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 950         (tui_source_window_base::refresh_window): Move to
 951         tui-winsource.c.
 952         * tui/tui-win.c (tui_source_window_base::refresh_all)
 953         (tui_source_window_base::update_tab_width)
 954         (tui_source_window_base::set_new_height)
 955         (tui_source_window_base::do_make_visible_with_new_height): Move to
 956         tui-winsource.c.
 957         * tui/tui-source.h: Update.
 958         * tui/tui-source.c (tui_source_window_base::reset): Move to
 959         tui-winsource.c.
 960         * tui/tui-disasm.h: Update.
 961         * tui/tui-data.h (struct tui_exec_info_window): Move to
 962         tui-winsource.h.
 963         (struct tui_source_window_base): Likewise.
 964         * tui/tui-data.c (tui_source_window_base::clear_detail)
 965         (tui_source_window_base, ~tui_source_window_base): Move to
 966         tui-winsource.c.
 967
 968 2019-07-17  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-win.c (tui_resize_all)
 971         (tui_source_window_base::update_tab_width)
 972         (tui_adjust_win_heights): Update.
 973         (tui_win_info::make_invisible_and_set_new_height): Rename from
 974         make_invisible_and_set_new_height.
 975         * tui/tui-data.h (struct tui_win_info)
 976         <make_invisible_and_set_new_height>: New method.
 977
 978 2019-07-17  Tom Tromey  <tom@tromey.com>
 979
 980         * tui/tui.c: Update.
 981         * tui/tui-source.h (struct tui_source_window): Move from
 982         tui-data.h.
 983         * tui/tui-layout.c: Update.
 984         * tui/tui-disasm.c: Update.
 985         * tui/tui-data.h (struct tui_source_window): Move to
 986         tui-source.h.
 987
 988 2019-07-17  Tom Tromey  <tom@tromey.com>
 989
 990         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 991         tui-data.h.
 992         * tui/tui-data.h (struct tui_disasm_window): Move to
 993         tui-disasm.h.
 994
 995 2019-07-17  Tom Tromey  <tom@tromey.com>
 996
 997         * tui/tui-regs.h (struct tui_data_item_window): Move from
 998         tui-data.h.
 999         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1000         * tui/tui-data.h (struct tui_data_item_window): Move to
1001         tui-regs.h.
1002         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1003
1004 2019-07-17  Tom Tromey  <tom@tromey.com>
1005
1006         * tui/tui.c: Update.
1007         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1008         (tui_cmd_window::max_height): Move to tui-command.c.
1009         * tui/tui-layout.c: Update.
1010         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1011         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1012         tui-command.c.
1013         * tui/tui-command.h (struct tui_cmd_window): Move from
1014         tui-data.h.
1015         * tui/tui-command.c: Remove "structuring" comments.
1016         (tui_cmd_window::clear_detail)
1017         (tui_cmd_window::do_make_visible_with_new_height)
1018         (tui_cmd_window::max_height): Move from elsewhere.
1019
1020 2019-07-17  Tom Tromey  <tom@tromey.com>
1021
1022         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1023         Now static.
1024         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1025         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1026
1027 2019-07-17  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui.c: Update.
1030         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1031         tui-regs.c.
1032         * tui/tui-windata.h: Remove file.
1033         * tui/tui-windata.c: Remove file.
1034         * tui/tui-win.c (tui_data_window::set_new_height)
1035         (tui_data_window::do_make_visible_with_new_height): Move to
1036         tui-regs.c.
1037         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1038         * tui/tui-regs.c: Remove "structuring" comments.
1039         (tui_data_window::first_data_item_displayed)
1040         (tui_data_window::delete_data_content_windows)
1041         (tui_data_window::erase_data_content)
1042         (tui_data_window::display_all_data)
1043         (tui_data_window::refresh_all)
1044         (tui_data_window::do_scroll_vertical)
1045         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1046         (tui_data_window::do_make_visible_with_new_height)
1047         (tui_data_window::refresh_window): Move from elsewhere.
1048         (_initialize_tui_regs): Move to end of file.
1049         * tui/tui-layout.c: Update.
1050         * tui/tui-hooks.c: Update.
1051         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1052         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1053         tui-regs.c.
1054         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1055
1056 2019-07-17  Tom Tromey  <tom@tromey.com>
1057
1058         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1059         seen.
1060
1061 2019-07-17  Tom Tromey  <tom@tromey.com>
1062
1063         * tui/tui-win.c (tui_source_window_base::set_new_height)
1064         (tui_source_window_base::do_make_visible_with_new_height): Use
1065         m_has_locator field directly.
1066         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1067         method.
1068         (struct tui_source_window_base) <has_locator>: Likewise.
1069
1070 2019-07-17  Tom Tromey  <tom@tromey.com>
1071
1072         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1073         Don't declare.
1074         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1075         Remove.
1076         * tui/tui-win.c (tui_source_window_base::set_new_height)
1077         (tui_source_window_base::set_new_height)
1078         (make_invisible_and_set_new_height)
1079         (tui_source_window_base::do_make_visible_with_new_height)
1080         (tui_source_window_base::do_make_visible_with_new_height):
1081         Update.
1082         * tui/tui-layout.c (show_source_disasm_command, show_data)
1083         (show_source_or_disasm_and_command): Update.
1084         * tui/tui-layout.c (show_layout): Update.
1085
1086 2019-07-17  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-layout.c (make_data_window): Remove.
1089         (show_data): Unify creation and re-initialization cases.
1090
1091 2019-07-17  Tom Tromey  <tom@tromey.com>
1092
1093         * tui/tui-layout.c (make_source_window, make_disasm_window):
1094         Remove.
1095         (show_data): Unify creation and re-initialization cases.
1096
1097 2019-07-17  Tom Tromey  <tom@tromey.com>
1098
1099         * tui/tui-layout.c (make_command_window): Remove.
1100         (show_source_disasm_command, show_source_or_disasm_and_command):
1101         Unify creation and re-initialization cases.
1102
1103 2019-07-17  Tom Tromey  <tom@tromey.com>
1104
1105         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1106         creation and re-initialization cases.
1107
1108 2019-07-17  Tom Tromey  <tom@tromey.com>
1109
1110         * tui/tui-regs.c (tui_get_register): Return void.
1111
1112 2019-07-17  Tom Tromey  <tom@tromey.com>
1113
1114         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1115         Simplify.
1116
1117 2019-07-17  Tom Tromey  <tom@tromey.com>
1118
1119         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1120         resetting.
1121
1122 2019-07-17  Tom Tromey  <tom@tromey.com>
1123
1124         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1125         * tui/tui-regs.c (tui_reg_layout): New function.
1126         (tui_show_registers, tui_reg_command): Use it.
1127         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1128         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1129         parameters.
1130         (tui_layout_command): Remove.
1131
1132 2019-07-17  Tom Tromey  <tom@tromey.com>
1133
1134         * tui/tui-layout.h (tui/tui-layout): Return void.
1135         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1136
1137 2019-07-17  Tom Tromey  <tom@tromey.com>
1138
1139         * tui/tui-layout.c (show_source_disasm_command, show_data):
1140         Update.
1141         (reset_locator): Remove.
1142         (show_source_or_disasm_and_command): Update.
1143
1144 2019-07-17  Tom Tromey  <tom@tromey.com>
1145
1146         * tui/tui-source.c (tui_source_window_base::reset): Remove
1147         win_type parameter.
1148         * tui/tui-layout.c (make_command_window, make_source_window)
1149         (make_disasm_window, make_data_window)
1150         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1151         (reset_locator, show_source_or_disasm_and_command): Update.
1152         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1153         win_type parameter.
1154         (struct tui_source_window_base) <reset>: Likewise.
1155
1156 2019-07-17  Tom Tromey  <tom@tromey.com>
1157
1158         * tui/tui-layout.c (show_source_disasm_command): Use
1159         reset_locator.
1160         (reset_locator): New function.
1161         (init_and_make_win): Remove.
1162         (show_source_or_disasm_and_command): Use reset_locator.
1163
1164 2019-07-17  Tom Tromey  <tom@tromey.com>
1165
1166         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1167         condition.
1168         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1169         Remove condition.
1170         * tui/tui-source.c (tui_source_window_base::reset): New method.
1171         * tui/tui-layout.c (make_command_window): Don't call
1172         init_and_make_win.
1173         (make_source_window, make_disasm_window): Don't call
1174         make_source_or_disasm_window.
1175         (make_data_window): Don't call init_and_make_win.  Change calling
1176         convention.
1177         (show_source_disasm_command, show_data): Simplify.
1178         (make_source_or_disasm_window): Remove.
1179         (show_source_or_disasm_and_command): Simplify.
1180         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1181         (struct tui_source_window_base) <reset>: Likewise.
1182         <execution_info>: Remove initializer.
1183         * tui/tui-data.c (tui_source_window_base): Initialize
1184         execution_info.
1185
1186 2019-07-17  Tom Tromey  <tom@tromey.com>
1187
1188         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1189         variable.
1190
1191 2019-07-17  Tom Tromey  <tom@tromey.com>
1192
1193         * tui/tui.c (tui_rl_other_window): Update.
1194         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1195         superclass method first.  Always iterate over regs_content.
1196         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1197         method.
1198         * tui/tui-win.c (tui_set_focus_command): Update.
1199
1200 2019-07-17  Tom Tromey  <tom@tromey.com>
1201
1202         * tui/tui-win.c (tui_set_focus_command): Rename from
1203         tui_set_focus.  Call tui_enable.
1204         (tui_set_focus_command): Remove.
1205
1206 2019-07-17  Tom Tromey  <tom@tromey.com>
1207
1208         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1209         refresh_window.
1210         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1211         touchwin.
1212         (tui_data_window::refresh_window): Call refresh_window on data
1213         items.  Always call superclass refresh_window.
1214         (tui_win_info::refresh): Remove.
1215         (tui_source_window_base::refresh_window): Update.
1216         (tui_refresh_all): Update.
1217         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1218         refresh_window.
1219         (show_source_or_disasm_and_command): Likewise.
1220         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1221         (struct tui_source_window_base) <refresh>: Likewise.
1222
1223 2019-07-17  Tom Tromey  <tom@tromey.com>
1224
1225         * tui/tui-winsource.c (tui_clear_source_content)
1226         (tui_show_source_content): Update.
1227         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1228         whether content is empty.
1229         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1230         Remove.
1231
1232 2019-07-17  Tom Tromey  <tom@tromey.com>
1233
1234         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1235         window's contents.
1236         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1237         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1238
1239 2019-07-17  Tom Tromey  <tom@tromey.com>
1240
1241         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1242         (struct tui_data_item_window): Update.
1243
1244 2019-07-17  Tom Tromey  <tom@tromey.com>
1245
1246         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1247         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1248         defines.
1249
1250 2019-07-17  Tom Tromey  <tom@tromey.com>
1251
1252         * tui/tui-winsource.h (tui_erase_source_content)
1253         (tui_clear_source_content): Remove "display_prompt" parameter.
1254         * tui/tui-winsource.c (tui_update_source_window_as_is)
1255         (tui_update_source_windows_with_addr): Update.
1256         (tui_clear_source_content): Remove "display_prompt" parameter.
1257         (tui_erase_source_content): Likewise.  Simplify.
1258         (tui_show_source_content): Update.
1259         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1260         * tui/tui-stack.c (tui_show_frame_info): Update.
1261         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1262         Remove defines.
1263
1264 2019-07-17  Tom Tromey  <tom@tromey.com>
1265
1266         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1267         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1268         parameter.
1269         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1270         parameter.
1271
1272 2019-07-17  Tom Tromey  <tom@tromey.com>
1273
1274         * tui/tui-winsource.c (tui_clear_source_content)
1275         (tui_show_source_content, tui_show_exec_info_content)
1276         (tui_clear_exec_info_content): Update.
1277         * tui/tui-stack.c (tui_show_locator_content): Update.
1278         (tui_show_frame_info): Update.
1279         * tui/tui-source.h (tui_source_window): Don't declare.
1280         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1281         from tui_source_is_displayed.
1282         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1283         Remove field.
1284         (struct tui_source_window_base) <content_in_use>: New field.  Now
1285         bool.
1286         (struct tui_source_window) <showing_source_p>: New method.
1287         (TUI_SRC_WIN): Change cast.
1288         * tui/tui-data.c (tui_initialize_static_data): Update.
1289
1290 2019-07-17  Tom Tromey  <tom@tromey.com>
1291
1292         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1293         location_matches_p.
1294         * tui/tui-source.c (tui_source_window::location_matches_p): New
1295         method.
1296         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1297         method.
1298         * tui/tui-data.h (struct tui_source_window_base)
1299         <location_matches_p>: New method.
1300         (struct tui_source_window, struct tui_disasm_window)
1301         <location_matches_p>: Likewise.
1302
1303 2019-07-17  Tom Tromey  <tom@tromey.com>
1304
1305         * tui/tui-win.c (tui_set_win_height_command): Rename from
1306         tui_set_win_height.
1307         (tui_set_win_height_command): Remove.
1308
1309 2019-07-17  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui-source.c (tui_source_window): New constructor.  Add
1312         observer.
1313         (~tui_source_window): New destructor.
1314         (tui_source_window::style_changed): New method.
1315         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1316         (tui_attach_detach_observers): Update.
1317         * tui/tui-data.h (struct tui_source_window): Make constructor not
1318         inline.  Add destructor.
1319         (struct tui_source_window) <style_changed>: New method.
1320         <m_observable>: New member.
1321
1322 2019-07-17  Tom Tromey  <tom@tromey.com>
1323
1324         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1325         * tui/tui-win.c (tui_resize_all): Fix typo.
1326
1327 2019-07-17  Tom Tromey  <tom@tromey.com>
1328
1329         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1330         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1331         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1332         * tui/tui-win.c (window_name_completer): Use foreach.
1333         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1334         (update_tab_width): Likewise.
1335         * tui/tui-layout.c (show_layout): Update.
1336         * tui/tui-data.h (class tui_window_iterator): New.
1337         (struct all_tui_windows): New.
1338         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1339
1340 2019-07-17  Tom Tromey  <tom@tromey.com>
1341
1342         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1343         parameter.  Don't reference globals.
1344         (tui_reg_command): Update.
1345
1346 2019-07-17  Tom Tromey  <tom@tromey.com>
1347
1348         * tui/tui-regs.c (tui_show_registers): Simplify.
1349
1350 2019-07-17  Tom Tromey  <tom@tromey.com>
1351
1352         * tui/tui-regs.c (tui_show_registers): Update.
1353         (tui_show_register_group): Add win_info parameter.
1354
1355 2019-07-17  Tom Tromey  <tom@tromey.com>
1356
1357         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1358         Rename from tui_display_reg_element_at_line.
1359         (tui_data_window::display_registers_from_line): Update.
1360         * tui/tui-data.h (struct tui_data_window)
1361         <display_reg_element_at_line>: New method.
1362
1363 2019-07-17  Tom Tromey  <tom@tromey.com>
1364
1365         * tui/tui-regs.h (tui_display_registers_from)
1366         (tui_display_registers_from_line): Don't declare.
1367         * tui/tui-windata.c (tui_data_window::display_all_data)
1368         (tui_data_window::refresh_all)
1369         (tui_data_window::do_scroll_vertical): Update.
1370         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1371         from tui_display_registers_from.
1372         (tui_display_reg_element_at_line): Update.
1373         (tui_data_window::display_registers_from_line): Rename from
1374         tui_display_registers_from_line.
1375         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1376         display_registers_from_line>: New methods.
1377
1378 2019-07-17  Tom Tromey  <tom@tromey.com>
1379
1380         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1381         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1382         from tui_erase_data_content.
1383         (tui_data_window::display_all_data)
1384         (tui_data_window::refresh_all)
1385         (tui_data_window::do_scroll_vertical): Update.
1386         * tui/tui-regs.c (tui_show_registers): Update.
1387         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1388         New method.
1389
1390 2019-07-17  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1393         declare.
1394         * tui/tui-windata.c
1395         (tui_data_window::delete_data_content_windows): Rename from
1396         tui_delete_data_content_windows.
1397         (tui_data_window::display_all_data)
1398         (tui_data_window::do_scroll_vertical): Update.
1399         * tui/tui-data.h (struct tui_data_window)
1400         <delete_data_content_windows>: New method.
1401
1402 2019-07-17  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1405         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1406
1407 2019-07-17  Tom Tromey  <tom@tromey.com>
1408
1409         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1410         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1411         from tui_display_all_data.
1412         * tui/tui-win.c
1413         (tui_data_window::do_make_visible_with_new_height): Update.
1414         * tui/tui-regs.c (tui_show_registers): Update.
1415         * tui/tui-layout.c (tui_set_layout): Update.
1416         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1417         method.
1418
1419 2019-07-17  Tom Tromey  <tom@tromey.com>
1420
1421         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1422         * tui/tui-windata.c (tui_display_data_from): Remove.
1423         (tui_data_window::refresh_all): Update.
1424
1425 2019-07-17  Tom Tromey  <tom@tromey.com>
1426
1427         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1428         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1429         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1430         tui_display_registers_from_line.
1431         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1432         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1433         "force_display" parameter.
1434
1435 2019-07-17  Tom Tromey  <tom@tromey.com>
1436
1437         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1438         declare.
1439         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1440         Rename from tui_first_reg_element_no_inline.
1441         (tui_display_reg_element_at_line)
1442         (tui_display_registers_from_line): Update.
1443         * tui/tui-data.h (struct tui_data_window)
1444         <first_reg_element_no_inline>: New method.
1445
1446 2019-07-17  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-windata.c (tui_display_data_from)
1449         (tui_data_window::do_scroll_vertical): Update.
1450         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1451         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1452         Rename from tui_line_from_reg_element_no.
1453         (tui_display_registers_from_line): Update.
1454         * tui/tui-data.h (struct tui_data_window)
1455         <line_from_reg_element_no>: New method.
1456
1457 2019-07-17  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1460         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1461         tui_last_regs_line_no.
1462         (tui_display_reg_element_at_line)
1463         (tui_display_registers_from_line): Update.
1464         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1465         method.
1466
1467 2019-07-17  Tom Tromey  <tom@tromey.com>
1468
1469         PR tui/24722:
1470         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1471         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1472         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1473         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1474         (tui_update_breakpoint_info): Likewise.
1475         * tui/tui-hooks.c (tui_event_create_breakpoint)
1476         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1477         Update.
1478
1479 2019-07-17  Tom Tromey  <tom@tromey.com>
1480
1481         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1482
1483 2019-07-17  Tom Tromey  <tom@tromey.com>
1484
1485         * tui/tui-winsource.c (tui_update_source_window_as_is)
1486         (tui_update_source_windows_with_addr): Update.
1487         * tui/tui-source.h (tui_set_source_content)
1488         (tui_show_symtab_source): Add "win_info" parameter.
1489         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1490         parameter.
1491         (tui_show_symtab_source): Likewise.
1492
1493 2019-07-17  Tom Tromey  <tom@tromey.com>
1494
1495         * tui/tui-wingeneral.c
1496         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1497
1498 2019-07-17  Tom Tromey  <tom@tromey.com>
1499
1500         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1501         (struct tui_cmd_window) <can_scroll>: New method.
1502         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1503         method.
1504
1505 2019-07-17  Tom Tromey  <tromey@adacore.com>
1506
1507         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1508         do_field_signed>: Rename.  Change type of "value".
1509         * ui-out.c (ui_out::field_signed): Rename from field_int.
1510         Change type of "value".
1511         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1512         type of "value".
1513         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1514         do_field_int.  Change type of "value".
1515         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1516         do_field_int.  Change type of "value".
1517         * tracepoint.c (trace_status_mi, tfind_1)
1518         (print_one_static_tracepoint_marker): Update.
1519         * thread.c (print_thread_info_1, print_selected_thread_frame):
1520         Update.
1521         * stack.c (print_frame, print_frame_info): Update.
1522         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1523         Update.
1524         * source.c (print_source_lines_base): Update.
1525         * skip.c (info_skip_command): Update.
1526         * record-btrace.c (btrace_ui_out_decode_error)
1527         (btrace_call_history_src_line): Update.
1528         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1529         Update.
1530         * progspace.c (print_program_space): Update.
1531         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1532         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1533         do_field_int.  Change type of "value".
1534         * mi/mi-out.c (mi_ui_out::do_table_begin)
1535         (mi_ui_out::do_table_header): Update.
1536         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1537         type of "value".
1538         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1539         (mi_cmd_data_list_changed_registers, output_register)
1540         (mi_cmd_data_read_memory, mi_load_progress)
1541         (mi_cmd_trace_frame_collected): Update.
1542         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1543         Update.
1544         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1545         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1546         (mi_cmd_var_list_children, varobj_update_one): Update.
1547         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1548         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1549         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1550         * inferior.c (print_inferior): Update.
1551         * gdb_bfd.c (print_one_bfd): Update.
1552         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1553         Update.
1554         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1555         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1556         do_field_int.  Change type of "value".
1557         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1558         do_field_int.  Change type of "value".
1559         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1560         (print_one_breakpoint_location, print_it_catch_fork)
1561         (print_one_catch_fork, print_it_catch_vfork)
1562         (print_one_catch_vfork, print_it_catch_solib)
1563         (print_it_catch_exec, print_it_ranged_breakpoint)
1564         (print_mention_watchpoint, print_mention_masked_watchpoint)
1565         (bkpt_print_it, update_static_tracepoint): Update.
1566         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1567         * break-catch-syscall.c (print_it_catch_syscall): Update.
1568         * ada-tasks.c (print_ada_task_info): Update.
1569         * ada-lang.c (print_it_exception, print_mention_exception):
1570         Update.
1571
1572 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         PR breakpoints/24541
1575         * gdbarch.c: Regenerate.
1576         * gdbarch.h: Regenerate.
1577         * gdbarch.sh: Adjust return type and parameter types for
1578         'stap_adjust_register'.
1579         (i386_stap_adjust_register): Adjust signature and return new
1580         register name.
1581         * stap-probe.c (stap_parse_register_operand): Adjust use of
1582         'gdbarch_stap_adjust_register'.
1583
1584 2019-07-17  Tom Tromey  <tromey@adacore.com>
1585
1586         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1587         declare VEC.
1588         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1589         std::vector.
1590         (struct s390_process_info): Add initializers.
1591         (s390_add_process): Use new.
1592         (s390_linux_nat_target::low_forget_process): Use delete.
1593         (s390_linux_nat_target::low_new_fork)
1594         (s390_linux_nat_target::stopped_by_watchpoint)
1595         (s390_linux_nat_target::low_prepare_to_resume)
1596         (s390_linux_nat_target::insert_watchpoint)
1597         (s390_linux_nat_target::insert_hw_breakpoint)
1598         (s390_linux_nat_target::remove_watchpoint)
1599         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1600
1601 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1602
1603         * aarch64-fbsd-nat.c: Include regcache.h.
1604         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1605         argument.
1606         (aarch64_fbsd_nat_target::fetch_registers)
1607         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1608         variable.
1609         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1610
1611 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1612
1613         * fbsd-nat.c: Include gdbarch.h.
1614
1615 2019-07-15  Tom Tromey  <tromey@adacore.com>
1616
1617         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1618
1619 2019-07-15  Tom Tromey  <tromey@adacore.com>
1620
1621         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1622         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1623         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1624         * cli-out.c (cli_ui_out::do_field_int): New method.
1625         * ui-out.c (ui_out::field_unsigned): New method.
1626         * symfile.c (generic_load): Use field_unsigned.
1627         (print_transfer_performance): Likewise.
1628         * record-btrace.c (ui_out_field_uint): Remove.
1629         (btrace_call_history_insn_range, btrace_call_history): Use
1630         field_unsigned.
1631         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1632         field_unsigned.
1633         * ui-out.h (class ui_out) <field_unsigned>: New method.
1634         <do_field_unsigned>: Likewise.
1635
1636 2019-07-15  Tom Tromey  <tromey@adacore.com>
1637
1638         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1639         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1640         * target.c (flash_erase_command): Use field_string.
1641         * infrun.c (print_signal_received_reason): Use field_string.
1642         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1643         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1644         field_string.
1645         * ada-tasks.c (print_ada_task_info): Use field_string.
1646
1647 2019-07-15  Tom Tromey  <tromey@adacore.com>
1648
1649         * target.c (flash_erase_command): Use field_core_addr.
1650         * symfile.c (generic_load): Use field_core_addr.
1651         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1652         Use field_core_addr.
1653         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1654         field_core_addr.
1655
1656 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1657
1658         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1659         value if its desired type is smaller than a CORE_ADDR and signed.
1660
1661 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1662
1663         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1664         of changes to field names, and use new is_reference field to
1665         decide if a property is a reference or not.
1666         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1667         field.
1668         (struct dwarf2_property_baton): Update header comment, rename
1669         'referenced_type' to 'property_type' and update comments.
1670         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1671         default property type, store in property baton, update to take
1672         accound of renamed field.
1673         (read_func_scope): Update call to attr_to_dynamic_prop.
1674         (read_array_type): Likewise.
1675         (dwarf2_per_cu_addr_sized_int_type): New function.
1676         (read_subrange_index_type): Move type finding code to
1677         dwarf2_per_cu_addr_sized_int_type.
1678         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1679         (dwarf2_per_cu_addr_type): New function.
1680         (set_die_type): Update calls to attr_to_dynamic_prop.
1681
1682 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1683
1684         * dwarf2read.c (read_subrange_index_type): New function.
1685         (read_subrange_type): Move code into new function and call it.
1686         * gdbtypes.c (create_range_type): Add some asserts.
1687
1688 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1689
1690         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1691         update return statements.
1692         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1693         declaration, and update comment to match.
1694         * gdbtypes.c (resolve_dynamic_array): Update call to
1695         dwarf2_evaluate_property to match new return type.
1696
1697 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1698
1699         * valarith.c (value_subscripted_rvalue): Change lowerbound
1700         parameter type from int to LONGEST.
1701         * value.h (value_subscripted_rvalue): Likewise in declaration.
1702
1703 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1704
1705         * cli/cli-utils.c (info_print_command_completer): New function.
1706         * cli/cli-utils.h: Add 'completer.h' include, and forward
1707         declaration for 'struct cmd_list_element'.
1708         (info_print_command_completer): Declare.
1709         * stack.c (_initialize_stack): Add completer for 'info locals' and
1710         'info args'.
1711         * symtab.c (_initialize_symtab): Add completer for 'info
1712         variables' and 'info functions'.
1713         * NEWS: Mention completion for additional info commands.
1714
1715 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1716
1717         * cli/cli-utils.c (extract_info_print_args): Delete.
1718         (extract_arg_maybe_quoted): Delete.
1719         (info_print_options_defs): New variable.
1720         (make_info_print_options_def_group): New function.
1721         (extract_info_print_options): Define new function.
1722         * cli/cli-utils.h (extract_info_print_args): Delete.
1723         (struct info_print_options): New structure.
1724         (extract_info_print_options): Declare new function.
1725         * stack.c (info_locals_command): Update to use new
1726         extract_info_print_options, also add a header comment.
1727         (info_args_command): Likewise.
1728         * symtab.c (info_variables_command): Likewise.
1729         (info_functions_command): Likewise.
1730
1731 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1732
1733         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1734         to extract string arguments.
1735         * common/common-utils.c (extract_string_maybe_quoted): New function.
1736         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1737
1738 2019-07-11  Tom Tromey  <tromey@adacore.com>
1739
1740         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1741         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1742         * top.h (gdbinit): Don't declare.
1743         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1744         into...
1745         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1746         * top.c (gdb_init): Don't call init_cli_cmds.
1747         (gdbinit): Remove.
1748         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1749
1750 2019-07-11  Tom Tromey  <tromey@adacore.com>
1751
1752         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1753         after it has been moved.
1754
1755 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1756
1757         * valops.c (value_must_coerce_to_target): Change return type to
1758         bool.
1759         * value.h (value_must_coerce_to_target): Likewise.
1760
1761 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1762
1763         * breakpoint.c (is_hardware_watchpoint): Remove
1764         forward-declaration.
1765         (is_masked_watchpoint): Change return type to bool.
1766         (is_tracepoint): Likewise.
1767         (is_breakpoint): Likewise.
1768         (is_hardware_watchpoint): Likewise.
1769         (is_watchpoint): Likewise.
1770         (is_no_memory_software_watchpoint): Likewise.
1771         (is_catchpoint): Likewise.
1772         (breakpoint_1): Make FILTER parameter's return type bool.
1773         is_masked_watchpoint): Change return type to bool.
1774         (save_breakpoints): Make FILTER parameter's return type bool.
1775         * breakpoint.h (is_breakpoint): Change return type to bool.
1776         (is_watchpoint): Likewise.
1777         (is_catchpoint): Likewise.
1778         (is_tracepoint): Likewise.
1779
1780 2019-07-10  Tom Tromey  <tom@tromey.com>
1781
1782         * defs.h: Don't include gdbarch.h.
1783         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1784         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1785         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1786         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1787         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1788         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1789         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1790         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1791         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1792         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1793         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1794         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1795         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1796         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1797         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1798         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1799         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1800         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1801         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1802         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1803         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1804         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1805         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1806         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1807         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1808         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1809         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1810
1811 2019-07-10  Tom Tromey  <tromey@adacore.com>
1812
1813         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1814         * breakpoint.c (init_ada_exception_breakpoint): Register as
1815         bp_catchpoint.
1816         (print_one_breakpoint_location, print_one_breakpoint): Use
1817         is_ada_exception_catchpoint.
1818         * ada-lang.c (class ada_catchpoint_location): Pass
1819         bp_loc_software_breakpoint to bp_location constructor.
1820         (is_ada_exception_catchpoint): New function.
1821
1822 2019-07-10  Tom Tromey  <tromey@adacore.com>
1823
1824         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1825         VEC.
1826         (struct arm_exidx_entry): New method operator<.
1827         (struct arm_exidx_data) <section_maps>: Change type.
1828         (arm_exidx_data_free): Remove.
1829         (arm_exidx_data_key): Change type.  Move lower.
1830         (arm_exidx_new_objfile): Update.
1831         (arm_compare_exidx_entries): Remove.
1832         (arm_find_exidx_entry, _initialize_arm_tdep)
1833
1834 2019-07-10  Tom Tromey  <tromey@adacore.com>
1835
1836         * solib-spu.c (ocl_program_data_key): Change type.
1837         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1838         Update.
1839
1840 2019-07-10  Tom Tromey  <tromey@adacore.com>
1841
1842         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1843         (struct solib_aix_inferior_data) <library_list>: Change type.
1844         (solib_aix_inferior_data_handle): Change type.
1845         (get_solib_aix_inferior_data): Update.
1846         (solib_aix_free_library_list): Remove.
1847         (library_list_start_library): Update.
1848         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1849         return type.
1850         (solib_aix_get_library_list)
1851         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1852         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1853
1854 2019-07-10  Tom Tromey  <tromey@adacore.com>
1855
1856         * solib-dsbt.c (struct dsbt_info): Add initializers.
1857         (solib_dsbt_pspace_data): Change type.
1858         (dsbt_pspace_data_cleanup): Remove.
1859         (get_dsbt_info, _initialize_dsbt_solib): Update.
1860
1861 2019-07-10  Tom Tromey  <tromey@adacore.com>
1862
1863         * spu-tdep.c (spu_overlay_data): Change type.
1864         (spu_get_overlay_table, spu_overlay_new_objfile)
1865         (_initialize_spu_tdep): Update.
1866
1867 2019-07-10  Tom Tromey  <tromey@adacore.com>
1868
1869         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1870         destructor.
1871         (dbx_objfile_data_key): Change type and declare later.
1872         (DBX_SYMFILE_INFO): Rewrite.
1873         * dbxread.c (dbx_objfile_data_key): Change type.
1874         (dbx_symfile_init): Update.
1875         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1876         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1877         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1878
1879 2019-07-10  Tom Tromey  <tromey@adacore.com>
1880
1881         * jit.c (jit_program_space_key): Change type.  Move lower.
1882         (get_jit_program_space_data): Update.
1883         (jit_program_space_data_cleanup): Remove.
1884         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1885         Update.
1886         (struct jit_program_space_data): Add initializers.
1887
1888 2019-07-10  Tom Tromey  <tromey@adacore.com>
1889
1890         * solib-darwin.c (struct darwin_info): Add initializers.
1891         (solib_darwin_pspace_data): Change type.
1892         (darwin_pspace_data_cleanup): Remove.
1893         (get_darwin_info, _initialize_darwin_solib): Update.
1894
1895 2019-07-10  Tom Tromey  <tromey@adacore.com>
1896
1897         * remote-sim.c (struct sim_inferior_data): Add initializers,
1898         constructor, and destructor.
1899         (sim_inferior_data_key): Change type.  Move lower.
1900         (check_for_duplicate_sim_descriptor): Update.
1901         (get_sim_inferior_data): Use new.  Update.
1902         (~sim_inferior_data_cleanup): Rename from
1903         sim_inferior_data_cleanup.  Simplify.
1904         (gdbsim_close_inferior, simulator_command)
1905         (sim_command_completer, _initialize_remote_sim): Update.
1906         (next_pid, INITIAL_PID): Move earlier.
1907
1908 2019-07-10  Tom Tromey  <tromey@adacore.com>
1909
1910         * python/python-internal.h (create_thread_object): Return
1911         gdbpy_ref.
1912         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1913         * python/py-inferior.c (struct threadlist_entry): Add
1914         constructor.
1915         <thread_obj>: Now a gdbpy_ref.
1916         (thread_to_thread_object): Update.
1917         (add_thread_object): Use new.
1918         (delete_thread_object): Use delete.
1919         (infpy_threads): Update.
1920         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1921         GIL.
1922
1923 2019-07-10  Tom Tromey  <tromey@adacore.com>
1924
1925         * valops.c (value_cast): Specialize error message for Ada.
1926
1927 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1928
1929         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1930
1931 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1932
1933         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1934         bpstat_should_step): Return bool, adjust comments.
1935         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1936         bpstat_should_step): Likewise.
1937
1938 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1939
1940         * features/Makefile: Use feature target descriptions for Arm.
1941         * features/arm/arm-core.c: Generate new file.
1942         * features/arm/arm-fpa.c: Likewise.
1943         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1944         * features/arm/arm-m-profile.c: Likewise.
1945         * features/arm/arm-vfpv2.c: Likewise.
1946         * features/arm/arm-vfpv3.c: Likewise.
1947         * features/arm/xscale-iwmmxt.c: Likewise.
1948         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1949
1950 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1951
1952         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1953         ptrace earlier.
1954
1955 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1956
1957         * features/aarch64-pauth.c: Regenerate.
1958
1959 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1960
1961         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1962         bool.
1963         (bpstat_what): Use false instead of 0.
1964
1965 2019-07-09  Pedro Alves  <palves@redhat.com>
1966
1967         * break-catch-throw.c (is_exception_catchpoint): New.
1968         * breakpoint.c (print_one_breakpoint_location): New parameter
1969         'raw_loc'.  Handle it.  Use
1970         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1971         looking at the breakpoint's type.
1972         (print_one_breakpoint): If handling "maint info breakpoints", also
1973         print locations of exception catchpoints.
1974         * breakpoint.h (is_exception_catchpoint): Declare.
1975
1976 2019-07-09  Pedro Alves  <palves@redhat.com>
1977
1978         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1979         "addr" field.
1980         (allocate_location_exception_catchpoint): New.
1981         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1982         (initialize_throw_catchpoint_ops): Install
1983         allocate_location_exception_catchpoint as allocate_location
1984         method.
1985         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1986         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1987         bp_loc_other.
1988         (breakpoint_address_is_meaningful): Delete.
1989         (bl_address_is_meaningful): New.
1990         (breakpoint_locations_match): Adjust comment.
1991         (bp_location_from_bp_type): New, factored out of...
1992         (bp_location::bp_location(breakpoint *)): ... this.
1993         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1994         factored out of...
1995         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1996         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1997         breakpoint_address_is_meaningful.
1998         (bp_locations_compare): Adjust comment.
1999         (update_global_location_list): Use bl_address_is_meaningful
2000         instead of breakpoint_address_is_meaningful.
2001         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2002         explicit.
2003         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2004         * python/py-breakpoint.c (bppy_get_location): No longer check
2005         whether location is null.
2006
2007 2019-07-09  Pedro Alves  <palves@redhat.com>
2008
2009         PR c++/15468
2010         * breakpoint.c (print_one_breakpoint_location): Remove
2011         single-location assert.
2012
2013 2019-07-09  Tom Tromey  <tom@tromey.com>
2014
2015         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2016         * configure: Rebuild.
2017         * configure.ac: Change common to gdbsupport.
2018         * gdbsupport: Rename from common.
2019         * acinclude.m4: Change common to gdbsupport.
2020         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2021         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2022         gdbsupport.
2023         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2024         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2025         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2026         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2027         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2028         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2029         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2030         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2031         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2032         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2033         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2034         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2035         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2036         coff-pe-read.c, command.h, compile/compile-c-support.c,
2037         compile/compile-c.h, compile/compile-cplus-symbols.c,
2038         compile/compile-cplus-types.c, compile/compile-cplus.h,
2039         compile/compile-loc2c.c, compile/compile.c, completer.c,
2040         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2041         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2042         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2043         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2044         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2045         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2046         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2047         features/aarch64-core.c, features/aarch64-fpu.c,
2048         features/aarch64-pauth.c, features/aarch64-sve.c,
2049         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2050         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2051         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2052         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2053         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2054         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2055         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2056         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2057         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2058         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2059         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2060         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2061         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2062         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2063         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2064         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2065         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2066         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2067         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2068         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2069         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2070         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2071         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2072         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2073         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2074         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2075         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2076         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2077         minsyms.c, mips-linux-tdep.c, namespace.h,
2078         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2079         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2080         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2081         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2082         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2083         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2084         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2085         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2086         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2087         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2088         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2089         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2090         procfs.c, producer.c, progspace.h, psymtab.h,
2091         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2092         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2093         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2094         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2095         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2096         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2097         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2098         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2099         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2100         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2101         target-memory.c, target.c, target.h, target/waitstatus.c,
2102         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2103         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2104         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2105         unittests/array-view-selftests.c,
2106         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2107         unittests/common-utils-selftests.c,
2108         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2109         unittests/format_pieces-selftests.c,
2110         unittests/function-view-selftests.c,
2111         unittests/lookup_name_info-selftests.c,
2112         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2113         unittests/mkdir-recursive-selftests.c,
2114         unittests/observable-selftests.c,
2115         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2116         unittests/parse-connection-spec-selftests.c,
2117         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2118         unittests/scoped_fd-selftests.c,
2119         unittests/scoped_mmap-selftests.c,
2120         unittests/scoped_restore-selftests.c,
2121         unittests/string_view-selftests.c, unittests/style-selftests.c,
2122         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2123         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2124         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2125         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2126         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2127         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2128
2129 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2130
2131         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2132         bool value.
2133         (decode_digits_ordinary): Set explicit_line field in sal.
2134         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2135         symtab_and_line that was set on an explicit line number in
2136         assembler code.  Do always update the recorded symtab and line if
2137         we do skip the prologue.
2138
2139 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2140
2141         * breakpoint.c (set_breakpoint_location_function): Remove
2142         explicit_loc parameter.
2143         (momentary_breakpoint_from_master): Update call to
2144         set_breakpoint_location_function.
2145         (add_location_to_breakpoint): Likewise.
2146
2147 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2148
2149         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2150         required features based on default bfd type when no specific bfd
2151         is present.
2152
2153 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2154
2155         * NEWS: Mention that GDB printf and eval commands can now print
2156         C-style and Ada-style convenience var strings without
2157         calling the inferior.
2158         * printcmd.c (printf_c_string): Locally print GDB internal var
2159         instead of transiting via the inferior.
2160         (printf_wide_c_string): Likewise.
2161
2162 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2163
2164         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2165
2166 2019-07-04  Tom Tromey  <tom@tromey.com>
2167
2168         PR tui/24724:
2169         * tui/tui-winsource.c (tui_clear_source_content): Update.
2170         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2171         (tui_update_breakpoint_info): Update.
2172         (tui_set_exec_info_content): Update.
2173         * tui/tui-source.c (tui_set_source_content_nil): Update.
2174         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2175         has_break.
2176         * tui/tui-data.h (enum tui_bp_flag): New.
2177         (tui_bp_flags): New enum flags type.
2178         (struct tui_source_element) <break_mode>: Change type.  Rename
2179         from has_break.
2180         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2181         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2182         constants.
2183         * tui/tui-winsource.h: Fix comment.
2184
2185 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2186
2187         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2188         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2189         (store_fpregs_to_thread)
2190         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2191         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2192         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2193         (IWMMXT_REGS_SIZE): Add define.
2194         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2195         (fetch_vfp_regs, store_vfp_regs)
2196         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2197         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2198
2199 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2200
2201         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2202         defines.
2203         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2204         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2205         (ARM_INT_REGISTER_SIZE): ...to this.
2206         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2207         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2208         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2209         (arm_linux_collect_gregset, supply_nwfpe_register)
2210         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2211         defines.
2212         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2213         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2214         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2215         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2216         (arm_return_in_memory, arm_store_return_value)
2217         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2218         (arm_record_ld_st_multiple): Likewise.
2219         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2220         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2221
2222 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2223
2224         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2225         AARCH64_DISPLACED_MODIFIED_INSNS.
2226         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2227         (aarch64_displaced_step_copy_insn): Likewise.
2228         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2229         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2230         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2231         ARM_DISPLACED_MODIFIED_INSNS.
2232         * arm-tdep.c (arm_gdbarch_init): Likewise.
2233         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2234         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2235         (struct arm_displaced_step_closure): Use
2236         ARM_DISPLACED_MODIFIED_INSNS.
2237
2238 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2239
2240         * features/Makefile: Remove unused xml files.
2241         * features/aarch64.xml: Remove.
2242         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2243         * features/i386/amd64-avx-avx512.xml: Remove.
2244         * features/i386/amd64-avx-linux.xml: Remove.
2245         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2246         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2247         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2248         * features/i386/amd64-avx-mpx.xml: Remove.
2249         * features/i386/amd64-avx.xml: Remove.
2250         * features/i386/amd64-linux.xml: Remove.
2251         * features/i386/amd64-mpx-linux.xml: Remove.
2252         * features/i386/amd64-mpx.xml: Remove.
2253         * features/i386/amd64.xml: Remove.
2254         * features/i386/i386-avx-avx512-linux.xml: Remove.
2255         * features/i386/i386-avx-avx512.xml: Remove.
2256         * features/i386/i386-avx-linux.xml: Remove.
2257         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2258         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2259         * features/i386/i386-avx-mpx-linux.xml: Remove.
2260         * features/i386/i386-avx-mpx.xml: Remove.
2261         * features/i386/i386-avx.xml: Remove.
2262         * features/i386/i386-linux.xml: Remove.
2263         * features/i386/i386-mmx-linux.xml: Remove.
2264         * features/i386/i386-mmx.xml: Remove.
2265         * features/i386/i386-mpx-linux.xml: Remove.
2266         * features/i386/i386-mpx.xml: Remove.
2267         * features/i386/i386.xml: Remove.
2268         * features/i386/x32-avx-avx512-linux.xml: Remove.
2269         * features/i386/x32-avx-linux.xml: Remove.
2270         * features/i386/x32-linux.xml: Remove.
2271
2272 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2273
2274         * regformats/aarch64.dat: Remove.
2275         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2276         * regformats/i386/amd64-avx-linux.dat: Remove.
2277         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2278         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2279         * regformats/i386/amd64-linux.dat: Remove.
2280         * regformats/i386/amd64-mpx-linux.dat: Remove.
2281         * regformats/i386/amd64.dat: Remove.
2282         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2283         * regformats/i386/i386-avx-linux.dat: Remove.
2284         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2285         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2286         * regformats/i386/i386-linux.dat: Remove.
2287         * regformats/i386/i386-mmx-linux.dat: Remove.
2288         * regformats/i386/i386-mpx-linux.dat: Remove.
2289         * regformats/i386/i386.dat: Remove.
2290         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2291         * regformats/i386/x32-avx-linux.dat: Remove.
2292         * regformats/i386/x32-linux.dat: Remove.
2293
2294 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2295
2296         * aarch64-tdep.c: Remove xml self tests.
2297         * amd64-linux-tdep.c: Likewise.
2298         * amd64-tdep.c: Likewise.
2299         * i386-linux-tdep.c: Likewise.
2300         * i386-tdep.c: Likewise.
2301
2302 2019-07-03  Pedro Alves  <palves@redhat.com>
2303
2304         PR cli/24732
2305         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2306         (pipe_cmd_option_defs): New.
2307         (make_pipe_cmd_options_def_group): New.
2308         (pipe_command): Use gdb::option::process_options.
2309         (pipe_command_completer): New function.
2310         (_initialize_cli_cmds): Install completer for "pipe" command.
2311
2312 2019-07-03  Pedro Alves  <palves@redhat.com>
2313
2314         * cli/cli-option.c (union option_value) <string>: New field.
2315         (struct option_def_and_value): Add ctor, move ctor, dtor and
2316         use DISABLE_COPY_AND_ASSIGN.
2317         (option_def_and_value::clear_value): New.
2318         (parse_option, save_option_value_in_ctx, get_val_type_str)
2319         (add_setshow_cmds_for_options): Handle var_string.
2320         * cli-option.h (union option_def::var_address) <string>: New
2321         field.
2322         (struct string_option_def): New.
2323         * maint-test-options.c (struct test_options_opts): Add default
2324         ctor and use DISABLE_COPY_AND_ASSIGN.
2325         <string_opt>: New field.
2326         (test_options_opts::~test_options_opts): New.
2327         (test_options_opts::dump): Also dump "-string".
2328         (test_options_option_defs): Install "string.
2329
2330 2019-07-03  Pedro Alves  <palves@redhat.com>
2331
2332         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2333         option_value with a null enumeration.
2334         (complete_options): Save the option values in the context.
2335         (save_option_value_in_ctx): New, factored out from ...
2336         (process_options): ... here.
2337         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2338         of the function.
2339         * maint-test-options.c (test_options_opts::dump): New, factored
2340         out from ...
2341         (maintenance_test_options_command_mode): ... here.
2342         (maintenance_test_options_command_completion_result): Delete.
2343         (maintenance_test_options_command_completion_text): Update
2344         comment.
2345         (maintenance_show_test_options_completion_result): Change
2346         prototype.  Just print
2347         maintenance_test_options_command_completion_text.
2348         (save_completion_result): New.
2349         (maintenance_test_options_completer_mode): Pass options context to
2350         complete_options, and then save a dump.
2351         (_initialize_maint_test_options): Use add_cmd to install "maint
2352         show test-options-completion-result".
2353
2354 2019-07-03  Pedro Alves  <palves@redhat.com>
2355
2356         * NEWS (New commands): Mention "with" and "maint with".
2357         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2358         (with_command, with_command_completer): New.
2359         (pipe_command): Adjust to new repeat_previous
2360         interface.
2361         (_initialize_cli_cmds): Install the "with" command and its "w"
2362         alias.
2363         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2364         declarations.
2365         * cli/cli-setshow.c (parse_cli_var_uinteger)
2366         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2367         argument strings for all var_types.
2368         (get_setshow_command_value_string): New, factored out from ...
2369         (do_show_command): ... this.
2370         * cli/cli-setshow.h: Include <string>.
2371         (get_setshow_command_value_string): Declare.
2372         * command.h (repeat_previous): Now returns const char *.  Adjust
2373         comment.
2374         * maint.c: Include "cli/cli-cmds.h".
2375         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2376         (_initialize_maint_cmds): Register the "maintenance with" command.
2377         * top.c (repeat_previous): Move bits from pipe_command here:
2378         Return the saved command line, if any; error out if there's no
2379         command to relaunch.
2380
2381 2019-07-03  Pedro Alves  <palves@redhat.com>
2382
2383         * NEWS (New commands): Mention "maint set/show test-settings"
2384         instead of "maint test-settings".
2385         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2386         (maintenance_test_settings_set_list): Rename to ...
2387         (maintenance_set_test_settings_list): ... this.
2388         (maintenance_test_settings_show_list): Rename to  ...
2389         (maintenance_show_test_settings_list): ... this.
2390         (maintenance_test_settings_cmd): Delete.
2391         (maintenance_test_settings_set_cmd): ...
2392         (maintenance_set_test_settings_cmd): ... this.
2393         (maintenance_test_settings_show_cmd): ...
2394         (maintenance_show_test_settings_cmd): ... this.
2395         (maintenance_test_settings_show_value_cmd):
2396         (maintenance_show_test_settings_value_cmd): ... this.
2397         (_initialize_maint_test_settings): No longer install the "maint
2398         test-settings" prefix command.  Rename "maint test-settings set"
2399         to "maint set test-settings", and "maint test-settings show" to
2400         "maint show test-settings".  Adjust all subcommands.
2401
2402 2019-07-03  Pedro Alves  <palves@redhat.com>
2403
2404         * maint-test-settings.c: Fix file's intro comment.  Replace all
2405         references to "test-options" with references to "test-settings",
2406         in comments.
2407
2408 2019-07-03  Pedro Alves  <palves@redhat.com>
2409
2410         * maint-test-settings.c (maintenance_test_settings_xxx)
2411         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2412         New.
2413         (maintenance_test_settings_enums): Use them.
2414         (maintenance_test_settings_enum): Default to
2415         maintenance_test_settings_xxx.
2416         (_initialize_maint_test_settings): Initialize
2417         MAINTENANCE_TEST_SETTINGS_FILENAME.
2418
2419 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2420
2421         * breakpoint.h (remove_breakpoints_inf): Change return type to
2422         void, move function documentation here.
2423         * breakpoint.c (remove_breakpoints_inf): Change return type to
2424         void, move function documentation to header.
2425
2426 2019-07-02  Pedro Alves  <palves@redhat.com>
2427
2428         * NEWS (Completion improvements): Mention "info threads".
2429         * thread.c (struct info_threads_opts, info_threads_option_defs)
2430         (make_info_threads_options_def_group): New.
2431         (info_threads_command): Use gdb::option::process_options.
2432         (info_threads_command_completer): New.
2433         (_initialize_thread): Use gdb::option::build_help to build the
2434         help text for "info threads".
2435
2436 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2437
2438         * defs.h (generic_load): Move from here...
2439         * symfile.h (generic_load): ... to here.  Rename name parameter
2440         to args.
2441         * symfile.c (generic_load): Add comment.
2442
2443 2019-07-01  Tom Tromey  <tromey@adacore.com>
2444
2445         * dwarf2read.c
2446         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2447         declaration of without_params.  Fix formatting.
2448
2449 2019-07-01  Tom Tromey  <tromey@adacore.com>
2450
2451         * ada-exp.y (find_primitive_type): Update.
2452         * ada-lang.h (ada_lookup_symbol): Update.
2453         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2454         parameter.
2455         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2456
2457 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2458
2459         PR breakpoints/24541
2460         * gdbarch.c: Regenerate.
2461         * gdbarch.h: Regenerate.
2462         * gdbarch.sh: Add 'stap_adjust_register'.
2463         * i386-tdep.c: Include '<unordered_set>'.
2464         (i386_stap_adjust_register): New function.
2465         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2466         * stap-probe.c (stap_parse_register_operand): Call
2467         'gdbarch_stap_adjust_register'.
2468
2469 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2470
2471         PR python/24742
2472         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2473         * python/python.c (do_start_initialization): Use 'xmalloc'
2474         instead of 'PyMem_Malloc'.
2475
2476 2019-06-28  Tom Tromey  <tromey@adacore.com>
2477
2478         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2479         for Ada.
2480
2481 2019-06-27  Tom Tromey  <tromey@adacore.com>
2482
2483         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2484         objfile_key.
2485         (arm_find_mapping_symbol, arm_record_special_symbol)
2486         (_initialize_arm_tdep): Update.
2487         (arm_objfile_data_free): Remove.
2488
2489 2019-06-27  Tom Tromey  <tromey@adacore.com>
2490
2491         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2492         to cp_print_static_field.
2493
2494 2019-06-26  Tom Tromey  <tromey@adacore.com>
2495
2496         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2497         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2498         declare.
2499
2500 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2501
2502         * features/aarch64-core.c (create_feature_aarch64_core):
2503         Regenerate.
2504         * features/aarch64-core.xml: Add cpsr flags.
2505
2506 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2507
2508         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2509         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2510
2511 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2512
2513         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2514         field.
2515         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2516         use.
2517         (arm_record_special_symbol): Don't insert new symbol in sorted
2518         position, push it at the end.
2519
2520 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2521
2522         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2523         (arm_mapping_symbol_s): Remove.
2524         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2525         (arm_mapping_symbol_vec): New typedef.
2526         (struct arm_per_objfile): Add constructor.
2527         <section_maps>: Change type to
2528         std::unique_ptr<arm_mapping_symbol_vec[]>.
2529         (arm_compare_mapping_symbols): Remove.
2530         (arm_find_mapping_symbol): Adjust to section_maps type change.
2531         (arm_objfile_data_free): Call delete on arm_per_objfile.
2532         (arm_record_special_symbol): Adjust to section_maps type change.
2533         Allocate arm_per_objfile with new.
2534
2535 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2536
2537         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2538         with the command prefix.
2539
2540 2019-06-25  Tom Tromey  <tom@tromey.com>
2541
2542         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2543         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2544
2545 2019-06-25  Tom Tromey  <tom@tromey.com>
2546
2547         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2548         type.
2549         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2550         protected.
2551
2552 2019-06-25  Tom Tromey  <tom@tromey.com>
2553
2554         * tui/tui-winsource.c
2555         (tui_source_window_base::set_is_exec_point_at): Add check against
2556         LOA_ADDRESS.
2557
2558 2019-06-25  Tom Tromey  <tom@tromey.com>
2559
2560         * tui/tui-source.c (tui_set_source_content): Don't check before
2561         xfree.
2562         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2563
2564 2019-06-25  Tom Tromey  <tom@tromey.com>
2565
2566         * tui/tui-winsource.h (tui_update_source_window_as_is)
2567         (tui_alloc_source_buffer, tui_line_is_displayed)
2568         (tui_addr_is_displayed): Change type of win_info.
2569         * tui/tui-winsource.c (tui_update_source_window_as_is)
2570         (tui_clear_source_content, tui_show_source_line)
2571         (tui_show_source_content, tui_source_window_base::refill)
2572         (tui_source_window_base::set_is_exec_point_at)
2573         (tui_source_window_base::set_is_exec_point_at)
2574         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2575         (tui_alloc_source_buffer, tui_line_is_displayed)
2576         (tui_addr_is_displayed): Change type of win_info.  Update.
2577         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2578         (tui_source_window_base::do_make_visible_with_new_height):
2579         Update.
2580         * tui/tui-source.c (tui_set_source_content)
2581         (tui_set_source_content_nil)
2582         (tui_source_window::do_scroll_vertical): Update.
2583         * tui/tui-layout.c (show_layout): Update.
2584         * tui/tui-disasm.c (tui_set_disassem_content)
2585         (tui_disasm_window::do_scroll_vertical): Update.
2586         * tui/tui-data.h (tui_win_content): Remove.
2587         (struct tui_gen_win_info) <content, content_size>: Remove.
2588         (struct tui_source_element): Add initializers and destructor.
2589         (union tui_which_element, struct tui_win_element): Remove.
2590         (struct tui_source_window_base) <content>: New field.
2591         (struct tui_data_window): Remove destructor.
2592         (tui_alloc_content, tui_free_win_content)
2593         (tui_free_all_source_wins_content): Don't declare.
2594         * tui/tui-data.c (tui_initialize_static_data): Update.
2595         (init_content_element, tui_alloc_content): Remove.
2596         (~tui_gen_win_info): Update.
2597         (~tui_data_window, tui_free_all_source_wins_content)
2598         (tui_free_win_content, free_content, free_content_elements):
2599         Remove.
2600
2601 2019-06-25  Tom Tromey  <tom@tromey.com>
2602
2603         * tui/tui-winsource.h (tui_clear_source_content)
2604         (tui_erase_source_content, tui_show_source_content): Change type
2605         of win_info.
2606         * tui/tui-winsource.c (tui_clear_source_content)
2607         (tui_erase_source_content, tui_show_source_content): Change type
2608         of win_info.
2609         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2610         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2611         win_info.
2612         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2613         win_info.
2614         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2615
2616 2019-06-25  Tom Tromey  <tom@tromey.com>
2617
2618         * tui/tui-winsource.c (tui_clear_source_content)
2619         (tui_source_window_base::set_is_exec_point_at): Update.
2620         * tui/tui-source.c (tui_set_source_content_nil): Update.
2621         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2622         a bool.
2623         * tui/tui-data.c (init_content_element): Update.
2624
2625 2019-06-25  Tom Tromey  <tom@tromey.com>
2626
2627         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2628         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2629         * tui/tui-layout.c (init_and_make_win): Update.
2630         * tui/tui.h (enum tui_win_type): Update.
2631         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2632         tui_win_is_auxillary.
2633         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2634         tui_win_is_auxillary.
2635
2636 2019-06-25  Tom Tromey  <tom@tromey.com>
2637
2638         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2639         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2640         (tui_delete_data_content_windows, tui_display_all_data)
2641         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2642         Update.
2643         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2644         * tui/tui-regs.c (tui_last_regs_line_no)
2645         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2646         (tui_show_registers): Update.
2647         (tui_show_register_group): Return void.  Update.
2648         (tui_display_registers_from, tui_display_reg_element_at_line)
2649         (tui_display_registers_from_line, tui_check_register_values):
2650         Update.
2651         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2652         member.
2653         (struct tui_data_window) <regs_content>: Now a std::vector.
2654         <regs_content_count>: Remove.
2655         (tui_add_content_elements, tui_free_data_content): Don't declare.
2656         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2657         (init_content_element): Remove DATA_WIN case.  Add assert.
2658         (tui_add_content_elements): Remove.
2659         (tui_data_window): Update.
2660         (tui_free_data_content): Remove.
2661         (free_content_elements): Remove DATA_WIN case.
2662
2663 2019-06-25  Tom Tromey  <tom@tromey.com>
2664
2665         * tui/tui-data.c (tui_data_item_window): Update.
2666         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2667         * tui/tui-windata.c (tui_display_all_data)
2668         (tui_display_data_from_line): Update.
2669         (tui_check_data_values): Remove.
2670         * tui/tui-regs.c (tui_show_register_group)
2671         (tui_display_reg_element_at_line): Update.
2672         * tui/tui-hooks.c (tui_register_changed)
2673         (tui_refresh_frame_and_register_information): Call
2674         tui_check_register_values.
2675         * tui/tui-data.h (struct tui_data_window) <data_content,
2676         data_content_count, data_type>: Remove.
2677         (enum tui_data_type): Remove.
2678
2679         * tui/tui-data.c (tui_data_window::clear_detail)
2680         (~tui_data_window): Update.
2681
2682 2019-06-25  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2685         declare.
2686         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2687         Rename from tui_first_data_item_displayed.  Update.
2688         (tui_data_window::refresh_all)
2689         (tui_data_window::do_scroll_vertical): Update.
2690         * tui/tui-data.h (struct tui_data_window)
2691         <first_data_item_displayed>: Declare new method.
2692
2693 2019-06-25  Tom Tromey  <tom@tromey.com>
2694
2695         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2696         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2697         contents...
2698         (tui_initialize_static_data): ...here.
2699
2700 2019-06-25  Tom Tromey  <tom@tromey.com>
2701
2702         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2703         (tui_display_registers_from, tui_check_register_values): Update.
2704         (tui_display_register): Remove win_info parameter; update.
2705         (tui_get_register): Change type of parameters.
2706         * tui/tui-data.h (struct tui_data_element): Remove.
2707         (union tui_which_element) <data>: Remove.
2708         <data_window>: Change type.
2709         (struct tui_data_item_window): New.
2710         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2711         case.  Add assert.
2712         (~tui_data_item_window): New destructor.
2713         (free_content_elements): Remove DATA_ITEM_WIN case.
2714
2715 2019-06-25  Tom Tromey  <tom@tromey.com>
2716
2717         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2718         Remove.
2719
2720 2019-06-25  Tom Tromey  <tom@tromey.com>
2721
2722         * tui/tui-data.h (struct tui_command_element): Remove.
2723         (union tui_which_element) <command>: Remove.
2724         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2725         assert.
2726         (free_content_elements): Remove CMD_WIN case.
2727
2728 2019-06-25  Tom Tromey  <tom@tromey.com>
2729
2730         * tui/tui-layout.c (tui_set_layout): Update.
2731         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2732         * tui/tui-data.c (layout_def): Update.
2733
2734 2019-06-25  Tom Tromey  <tom@tromey.com>
2735
2736         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2737         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2738         (tui_source_window_base::set_new_height): Update.
2739         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2740         Update.
2741         (tui_set_locator_fullname, tui_set_locator_info)
2742         (tui_show_frame_info): Update.
2743         * tui/tui-source.c (tui_set_source_content)
2744         (tui_source_is_displayed): Update.
2745         * tui/tui-layout.c (show_source_disasm_command, show_data)
2746         (show_source_or_disasm_and_command): Update.
2747         * tui/tui-disasm.c (tui_set_disassem_content)
2748         (tui_get_begin_asm_address): Update.
2749         * tui/tui-data.h (struct tui_locator_element): Remove.
2750         (union tui_which_element) <locator>: Remove.
2751         (struct tui_locator_window): New.
2752         (tui_locator_win_info_ptr): Change return type.
2753         * tui/tui-data.c (_locator): Change type.
2754         (tui_locator_win_info_ptr): Change return type.
2755         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2756         (tui_alloc_content): Add assert.
2757
2758 2019-06-25  Tom Tromey  <tom@tromey.com>
2759
2760         * tui/tui-winsource.c
2761         (tui_exec_info_window::maybe_allocate_content): New method.
2762         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2763         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2764         (make_source_or_disasm_window): Add cast.
2765         * tui/tui-data.h (union tui_which_element) <simple_string>:
2766         Remove.
2767         (struct tui_source_info): New.
2768         (struct tui_source_window_base) <execution_info>: Change type.
2769         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2770         case, and add assert.
2771         (tui_alloc_content): Add assert.
2772
2773 2019-06-25  Tom Tromey  <tom@tromey.com>
2774
2775         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2776         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2777         * tui/tui-data.c (tui_alloc_win_info): Remove.
2778
2779 2019-06-25  Tom Tromey  <tom@tromey.com>
2780
2781         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2782         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2783         can_highlight.
2784
2785 2019-06-25  Tom Tromey  <tom@tromey.com>
2786
2787         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2788         make_visible_with_new_height method.
2789         (tui_win_info::make_visible_with_new_height): New method.
2790         (tui_source_window_base::do_make_visible_with_new_height)
2791         (tui_data_window::do_make_visible_with_new_height)
2792         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2793         (make_visible_with_new_height): Remove.
2794         (tui_resize_all, tui_adjust_win_heights): Use
2795         make_visible_with_new_height method.
2796         * tui/tui-data.h (struct tui_win_info)
2797         <do_make_visible_with_new_height, make_visible_with_new_height>:
2798         New methods.
2799         (struct tui_source_window_base, struct tui_data_window)
2800         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2801         methods.
2802
2803 2019-06-25  Tom Tromey  <tom@tromey.com>
2804
2805         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2806         method.
2807         (update_tab_width): Call update_tab_width method.
2808         * tui/tui-data.h (struct tui_win_info)
2809         (struct tui_source_window_base) <update_tab_width>: New methods.
2810
2811 2019-06-25  Tom Tromey  <tom@tromey.com>
2812
2813         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2814         parameter.
2815         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2816         parameter.
2817         (tui_gen_win_info::make_visible): Update.
2818         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2819         parameter.
2820         * tui/tui-data.h (enum tui_box): New enum.
2821         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2822
2823 2019-06-25  Tom Tromey  <tom@tromey.com>
2824
2825         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2826         init_and_make_win for EXEC_INFO_WIN.
2827         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2828         longer inline.
2829         (struct tui_win_info) <~tui_win_info>: Inline.
2830         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2831         Don't declare.
2832         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2833         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2834         Remove.
2835         (tui_initialize_static_data): Update.
2836         (~tui_gen_win_info): Handle more cleanup here.
2837         (~tui_source_window_base): Delete "execution_info".
2838         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2839
2840 2019-06-25  Tom Tromey  <tom@tromey.com>
2841
2842         * tui/tui-layout.c (make_command_window): Don't set
2843         can_highlight.
2844         (show_source_disasm_command): Call the reset method.
2845         (show_data): Don't set can_highlight.  Call the reset method.
2846         (tui_gen_win_info::reset): Rename from init_gen_win_info
2847         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2848         (show_source_or_disasm_and_command): Call the reset method.
2849         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2850         (struct tui_cmd_window): Set can_highlight.
2851
2852 2019-06-25  Tom Tromey  <tom@tromey.com>
2853
2854         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2855         from make_visible.
2856         (tui_make_visible, tui_make_invisible): Rewrite.
2857         (tui_win_info::make_visible): Remove.
2858         (tui_source_window_base::make_visible): Update.
2859         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2860         method.  Moved from...
2861         (struct tui_win_info) <make_visible>: ...here.
2862
2863 2019-06-25  Tom Tromey  <tom@tromey.com>
2864
2865         * tui/tui-winsource.c
2866         (tui_source_window_base::do_scroll_horizontal): Remove direction
2867         parameter.
2868         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2869         direction parameter.
2870         * tui/tui-win.c (tui_win_info::forward_scroll)
2871         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2872         (tui_win_info::right_scroll): Update.
2873         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2874         direction parameter.
2875         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2876         direction parameter.
2877         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2878         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2879         Remove direction parameter.
2880         (struct tui_source_window_base, struct tui_source_window)
2881         (struct tui_disasm_window, struct tui_data_window)
2882         (struct tui_cmd_window): Update.
2883
2884 2019-06-25  Tom Tromey  <tom@tromey.com>
2885
2886         * tui/tui-winsource.h (tui_set_exec_info_content)
2887         (tui_show_exec_info_content, tui_erase_exec_info_content)
2888         (tui_clear_exec_info_content, tui_update_exec_info): Change
2889         argument to tui_source_window_base.
2890         * tui/tui-winsource.c (tui_set_exec_info_content)
2891         (tui_show_exec_info_content, tui_erase_exec_info_content)
2892         (tui_clear_exec_info_content, tui_update_exec_info): Change
2893         argument to tui_source_window_base.
2894
2895 2019-06-25  Tom Tromey  <tom@tromey.com>
2896
2897         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2898         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2899
2900 2019-06-25  Tom Tromey  <tom@tromey.com>
2901
2902         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2903         check.
2904
2905 2019-06-25  Tom Tromey  <tom@tromey.com>
2906
2907         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2908         type to void.
2909         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2910         type to void.
2911         * tui/tui-source.c (tui_set_source_content): Update.
2912         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2913
2914 2019-06-25  Tom Tromey  <tom@tromey.com>
2915
2916         * tui/tui-win.c (window_name_completer, tui_set_focus)
2917         (tui_all_windows_info): Use name method.
2918         * tui/tui-data.h (struct tui_gen_win_info)
2919         (struct tui_source_window, struct tui_disasm_window)
2920         (struct tui_data_window, struct tui_cmd_window) <name>: New
2921         method.
2922         (tui_win_name): Don't declare.
2923         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2924         (tui_win_name): Remove.
2925
2926 2019-06-25  Tom Tromey  <tom@tromey.com>
2927
2928         * tui/tui-winsource.h (tui_update_source_window)
2929         (tui_update_source_window_as_is): Change parameter type.
2930         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2931         to be a tui_source_window_base.
2932         (tui_update_source_window_as_is): Likewise.
2933         * tui/tui-win.c (make_visible_with_new_height): Update.
2934
2935 2019-06-25  Tom Tromey  <tom@tromey.com>
2936
2937         * tui/tui-winsource.c (tui_erase_source_content)
2938         (tui_show_source_content, tui_show_exec_info_content)
2939         (tui_erase_exec_info_content): Use refresh_window method.
2940         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2941         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2942         from tui_refresh_win.
2943         (tui_data_window::refresh_window): New method.
2944         (tui_win_info::refresh, tui_source_window_base::refresh)
2945         (tui_refresh_all): Use refresh_window method.
2946         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2947         method.
2948         * tui/tui-regs.c (tui_display_register): Call refresh_window
2949         method.
2950         * tui/tui-layout.c (show_source_disasm_command)
2951         (show_source_or_disasm_and_command): Call refresh_window method.
2952         * tui/tui-data.h (struct tui_gen_win_info)
2953         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2954         New method.
2955
2956 2019-06-25  Tom Tromey  <tom@tromey.com>
2957
2958         * tui/tui.c (tui_rl_other_window, tui_enable)
2959         (tui_is_window_visible, tui_get_command_dimension): Update.
2960         * tui/tui-winsource.c (tui_update_source_window_as_is)
2961         (tui_clear_source_content, tui_erase_source_content)
2962         (tui_show_source_line, tui_source_window_base::refill)
2963         (tui_source_window_base::do_scroll_horizontal)
2964         (tui_source_window_base::set_is_exec_point_at)
2965         (tui_update_breakpoint_info, tui_set_exec_info_content)
2966         (tui_alloc_source_buffer, tui_line_is_displayed)
2967         (tui_addr_is_displayed): Update.
2968         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2969         (tui_check_and_display_highlight_if_needed)
2970         (tui_win_info::make_visible, tui_win_info::refresh)
2971         (tui_refresh_all): Update.
2972         * tui/tui-windata.c (tui_first_data_item_displayed)
2973         (tui_delete_data_content_windows, tui_erase_data_content)
2974         (tui_display_all_data, tui_data_window::refresh_all)
2975         (tui_check_data_values): Update.
2976         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2977         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2978         (tui_win_info::backward_scroll, tui_refresh_all_win)
2979         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2980         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2981         (tui_source_window_base::set_new_height)
2982         (tui_data_window::set_new_height)
2983         (make_invisible_and_set_new_height)
2984         (make_visible_with_new_height, new_height_ok)
2985         (parse_scrolling_args): Update.
2986         * tui/tui-stack.c (tui_show_frame_info): Update.
2987         * tui/tui-source.c (tui_set_source_content)
2988         (tui_set_source_content_nil, tui_source_is_displayed)
2989         (tui_source_window::do_scroll_vertical): Update.
2990         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2991         (tui_display_registers_from, tui_display_reg_element_at_line)
2992         (tui_check_register_values, tui_reg_command): Update.
2993         * tui/tui-layout.c (tui_default_win_height)
2994         (show_source_disasm_command, show_data, init_and_make_win)
2995         (show_source_or_disasm_and_command): Update.
2996         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2997         (tui_redisplay_readline, tui_mld_flush)
2998         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2999         (tui_getc): Update.
3000         * tui/tui-disasm.c (tui_set_disassem_content)
3001         (tui_disasm_window::do_scroll_vertical): Update.
3002         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3003         Now virtual.
3004         (struct tui_win_info): Derive from tui_gen_win_info.
3005         <~tui_win_info>: Mark as override.
3006         <generic>: Remove member.
3007         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3008         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3009         (~tui_data_window, ~tui_win_info)
3010         (tui_free_all_source_wins_content): Update.
3011         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3012
3013 2019-06-25  Tom Tromey  <tom@tromey.com>
3014
3015         * tui/tui-layout.c (init_and_make_win): Use new.
3016         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3017         destructor, initializers.
3018         (tui_alloc_generic_win_info): Don't declare.
3019         * tui/tui-data.c (_locator): Add argument to constructor.
3020         (source_win, disasm_win): New globals.
3021         (exec_info): Remove.
3022         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3023         Update.
3024         (tui_alloc_generic_win_info): Remove.
3025         (init_content_element): Use new.
3026         (tui_win_info::tui_win_info): Update.
3027         (free_content_elements) <case DATA_WIN>: Use delete.
3028
3029 2019-06-25  Tom Tromey  <tom@tromey.com>
3030
3031         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3032         * tui/tui-windata.c (tui_first_data_item_displayed)
3033         (tui_delete_data_content_windows): Update.
3034         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3035         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3036         (tui_display_registers_from, tui_check_register_values): Update.
3037         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3038         pointer.
3039         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3040         window.
3041         (tui_free_data_content): Update.
3042         (free_content_elements) <case DATA_WIN>: Free the window.
3043
3044 2019-06-25  Tom Tromey  <tom@tromey.com>
3045
3046         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3047         Update.
3048         * tui/tui-layout.c (make_command_window)
3049         (show_source_disasm_command, show_data, init_and_make_win)
3050         (show_source_or_disasm_and_command): Update.
3051         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3052         method.
3053         <can_highight, is_highlighted>: Now bool.
3054         (tui_set_win_highlight): Don't declare.
3055         * tui/tui-data.c (tui_set_win_highlight): Remove.
3056
3057 2019-06-25  Tom Tromey  <tom@tromey.com>
3058
3059         * tui/tui-wingeneral.c (make_visible): Remove check of window
3060         type.
3061
3062 2019-06-25  Tom Tromey  <tom@tromey.com>
3063
3064         * tui/tui-win.c (tui_win_info::max_height)
3065         (tui_cmd_window::max_height): New methods.
3066         (new_height_ok): Call max_height.
3067         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3068         <max_height>: New method.
3069
3070 2019-06-25  Tom Tromey  <tom@tromey.com>
3071
3072         * tui/tui-win.c (tui_source_window_base::set_new_height)
3073         (tui_data_window::set_new_height): New methods.
3074         (make_invisible_and_set_new_height): Call set_new_height method.
3075         * tui/tui-data.h (struct tui_win_info)
3076         (struct tui_source_window_base, struct tui_data_window)
3077         <set_new_height>: New method.
3078
3079 2019-06-25  Tom Tromey  <tom@tromey.com>
3080
3081         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3082         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3083         tui_refresh_data_win.
3084         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3085         method.
3086         (tui_refresh_all_win): Call the refresh_all method.
3087         (tui_set_focus): Likewise.
3088         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3089         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3090         Likewise.
3091
3092 2019-06-25  Tom Tromey  <tom@tromey.com>
3093
3094         * tui/tui-winsource.h (tui_refill_source_window)
3095         (tui_set_is_exec_point_at): Don't declare.
3096         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3097         (tui_source_window_base::refill): Rename from
3098         tui_refill_source_window.
3099         (tui_source_window_base::do_scroll_horizontal): Update.
3100         (tui_source_window_base::set_is_exec_point_at): Rename from
3101         tui_set_is_exec_point_at.
3102         (tui_update_all_breakpoint_info): Update.
3103         * tui/tui-stack.c (tui_show_frame_info): Update.
3104         * tui/tui-layout.c (show_data): Add cast.
3105         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3106         * tui/tui-data.h (struct tui_source_window_base) <refill,
3107         set_is_exec_point_at>: New methods.
3108         (tui_source_windows, tui_add_to_source_windows): Update types.
3109         (tui_add_to_source_windows): Remove redundant declaration.
3110         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3111         (tui_source_windows): Change return type.
3112         (tui_clear_source_windows_detail): Update.
3113         (tui_add_to_source_windows): Change type of parameter.
3114         (tui_free_all_source_wins_content): Update.
3115
3116 2019-06-25  Tom Tromey  <tom@tromey.com>
3117
3118         * tui/tui-wingeneral.c (tui_win_info::refresh)
3119         (tui_source_window_base::refresh): New methods.
3120         (tui_refresh_all): Call the refresh method.
3121         * tui/tui-data.h (struct tui_win_info)
3122         (struct tui_source_window_base) <refresh>: New method.
3123
3124 2019-06-25  Tom Tromey  <tom@tromey.com>
3125
3126         * tui/tui.h (tui_is_window_visible): Return bool.
3127         * tui/tui.c (tui_is_window_visible): Return bool.
3128         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3129         (tui_make_visible, tui_make_invisible)
3130         (tui_win_info::make_visible)
3131         (tui_source_window_base::make_visible, make_all_visible)
3132         (tui_make_all_visible, tui_make_all_invisible): Update.
3133         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3134         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3135         bool.
3136         (struct tui_win_info, struct tui_source_window_base)
3137         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3138         * tui/tui-data.c (tui_init_generic_part): Update.
3139
3140 2019-06-25  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3143         (tui_source_window_base::make_visible): New methods.
3144         (make_all_visible): Make method call.
3145         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3146         (struct tui_source_window_base, struct tui_cmd_window): Override
3147         make_visible.
3148         (tui_win_is_source_type): Don't declare.
3149         * tui/tui-data.c (tui_win_is_source_type): Remove.
3150
3151 2019-06-25  Tom Tromey  <tom@tromey.com>
3152
3153         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3154         NULL check.
3155
3156 2019-06-25  Tom Tromey  <tom@tromey.com>
3157
3158         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3159         Inline constructor.  Add initializers for members.
3160         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3161         constructors; now inline in class.
3162
3163 2019-06-25  Tom Tromey  <tom@tromey.com>
3164
3165         * tui/tui-regs.c (tui_show_registers): Update.
3166         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3167         bool.
3168         * tui/tui-data.c (tui_data_window::clear_detail)
3169         (tui_data_window): Update.
3170
3171 2019-06-25  Tom Tromey  <tom@tromey.com>
3172
3173         * tui/tui-windata.c (tui_display_all_data)
3174         (tui_display_data_from_line, tui_display_data_from)
3175         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3176         Update.
3177         * tui/tui-regs.c (tui_last_regs_line_no)
3178         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3179         (tui_show_registers, tui_show_register_group)
3180         (tui_display_registers_from, tui_display_reg_element_at_line)
3181         (tui_display_registers_from_line, tui_check_register_values)
3182         (tui_reg_next, tui_reg_prev): Update.
3183         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3184         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3185         tui_data_window.
3186         (struct tui_win_info) <detail>: Remove.  Add new fields from
3187         tui_data_info.
3188         (TUI_DATA_WIN): Add cast.
3189         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3190         (~tui_data_window): Simplify.
3191
3192 2019-06-25  Tom Tromey  <tom@tromey.com>
3193
3194         * tui/tui-layout.c (show_source_disasm_command)
3195         (show_source_or_disasm_and_command): Update.
3196         * tui/tui-io.c (update_cmdwin_start_line)
3197         (tui_redisplay_readline): Update.
3198         * tui/tui-data.h (struct tui_command_info): Remove.
3199         (struct tui_win_info) <detail>: Remove command_info member.
3200         (struct tui_data_window) <start_line>: New member, from
3201         tui_command_info.
3202         (TUI_CMD_WIN): Add casts.
3203
3204 2019-06-25  Tom Tromey  <tom@tromey.com>
3205
3206         * tui/tui-winsource.c (tui_update_source_window)
3207         (tui_refill_source_window)
3208         (tui_source_window_base::do_scroll_horizontal)
3209         (tui_update_breakpoint_info, tui_set_exec_info_content)
3210         (tui_show_exec_info_content, tui_erase_exec_info_content)
3211         (tui_clear_exec_info_content): Update.
3212         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3213         Update.
3214         * tui/tui-win.c (make_invisible_and_set_new_height)
3215         (make_visible_with_new_height): Update.
3216         * tui/tui-source.c (tui_set_source_content)
3217         (tui_show_symtab_source): Update.
3218         * tui/tui-layout.c (extract_display_start_addr)
3219         (show_source_disasm_command, show_data)
3220         (make_source_or_disasm_window)
3221         (show_source_or_disasm_and_command): Update.
3222         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3223         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3224         "gdbarch".
3225         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3226         to tui_source_window_base.
3227         (struct tui_win_info) <detail>: Remove source_info member.
3228         (struct tui_source_window_base) <has_locator>: Inline.
3229         Move contents from tui_source_info; rename has_locator member to
3230         m_has_locator.
3231         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3232         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3233         header file.
3234         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3235         Simplify.
3236         (tui_free_all_source_wins_content): Cast to
3237         tui_source_window_base.
3238
3239 2019-06-25  Tom Tromey  <tom@tromey.com>
3240
3241         * tui/tui-win.c (make_invisible_and_set_new_height)
3242         (make_visible_with_new_height): Call has_locator method.
3243         * tui/tui-layout.c (show_source_disasm_command, show_data)
3244         (show_source_or_disasm_and_command): Update for bool change.
3245         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3246         (tui_win_info) <has_locator>: New method.
3247         (struct tui_source_window_base) <has_locator>: New method.
3248         (tui_win_has_locator): Don't declare.
3249         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3250         from tui_win_has_locator.
3251         (tui_source_window_base): Use false, not FALSE.
3252
3253 2019-06-25  Tom Tromey  <tom@tromey.com>
3254
3255         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3256         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3257         clear_detail method directly.
3258         (tui_clear_win_detail): Remove.
3259
3260 2019-06-25  Tom Tromey  <tom@tromey.com>
3261
3262         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3263         "this", not TUI_DISASM_WIN.
3264
3265 2019-06-25  Tom Tromey  <tom@tromey.com>
3266
3267         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3268         declare.
3269         * tui/tui-winsource.c
3270         (tui_source_window_base::do_scroll_horizontal): Rename from
3271         tui_horizontal_source_scroll.
3272         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3273         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3274         from tui_vertical_data_scroll.
3275         * tui/tui-win.h (tui_scroll): Don't declare.
3276         * tui/tui-win.c (tui_win_info::forward_scroll)
3277         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3278         (tui_win_info::right_scroll): Rename and update.
3279         (tui_scroll_forward_command, tui_scroll_backward_command)
3280         (tui_scroll_left_command, tui_scroll_right_command): Update.
3281         (tui_scroll): Remove.
3282         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3283         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3284         from tui_vertical_source_scroll.
3285         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3286         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3287         from tui_vertical_disassem_scroll.
3288         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3289         do_scroll_horizontal>: New methods.
3290         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3291         Likewise.
3292         (struct tui_source_window_base): Add do_scroll_horizontal.
3293         (struct tui_source_window, struct tui_disasm_window): Add
3294         do_scroll_vertical.
3295         (struct tui_data_window, struct tui_cmd_window): Add
3296         do_scroll_horizontal and do_scroll_vertical.
3297         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3298
3299 2019-06-25  Tom Tromey  <tom@tromey.com>
3300
3301         * tui/tui-data.h (struct tui_source_window_base): New struct.
3302         (struct tui_source_window): Derive from tui_source_window_base.
3303         (struct tui_disasm_window): New struct.
3304         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3305         from tui_source_window::clear_detail.
3306         (tui_source_window_base): Rename from tui_source_window.
3307         (~tui_source_window_base): Rename from ~tui_source_window.
3308         (tui_alloc_win_info): Create a tui_disasm_window.
3309
3310 2019-06-25  Tom Tromey  <tom@tromey.com>
3311
3312         * tui/tui-data.h (struct tui_source_window)
3313         (struct tui_data_window): Declare destructors.
3314         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3315         destructors.
3316         (tui_win_info): Simplify.
3317
3318 2019-06-25  Tom Tromey  <tom@tromey.com>
3319
3320         * tui/tui-winsource.c (tui_display_main)
3321         (tui_update_source_windows_with_addr)
3322         (tui_update_all_breakpoint_info): Update.
3323         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3324         (new_height_ok, parse_scrolling_args): Update.
3325         * tui/tui-stack.c (tui_show_frame_info): Update.
3326         * tui/tui-data.h (struct tui_list): Remove.
3327         (tui_source_windows): Return a reference to a std::vector.
3328         * tui/tui-data.c (source_windows): Now a std::vector.
3329         (tui_source_windows): Change return type.
3330         (tui_clear_source_windows): Rewrite.
3331         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3332         (tui_free_all_source_wins_content): Rewrite.
3333
3334 2019-06-25  Tom Tromey  <tom@tromey.com>
3335
3336         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3337         (struct tui_data_window, struct tui_cmd_window): Declare
3338         clear_detail method.
3339         * tui/tui-data.c (tui_source_window::clear_detail)
3340         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3341         methods.
3342         (tui_clear_win_detail): Simplify.
3343
3344 2019-06-25  Tom Tromey  <tom@tromey.com>
3345
3346         * tui/tui-layout.c (make_source_window, make_disasm_window)
3347         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3348         Return the new window.
3349         (show_source_disasm_command, show_data)
3350         (show_source_or_disasm_and_command): Update.
3351
3352 2019-06-25  Tom Tromey  <tom@tromey.com>
3353
3354         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3355         parameter.  Return the new window.
3356         (show_source_disasm_command): Update and remove NULL check.
3357         (show_source_or_disasm_and_command): Update.
3358
3359 2019-06-25  Tom Tromey  <tom@tromey.com>
3360
3361         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3362
3363 2019-06-25  Tom Tromey  <tom@tromey.com>
3364
3365         * tui/tui-data.h (struct tui_win_info): Make constructor
3366         protected.  Make destructor virtual.  Add initializers.
3367         (tui_source_window, tui_data_window, tui_cmd_window): New
3368         classes.
3369         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3370         constructor.  Add "type" parameter.
3371         (tui_source_window, tui_data_window, tui_cmd_window): New
3372         constructors.
3373         (tui_alloc_win_info): Instantiate the appropriate subclass.
3374
3375 2019-06-25  Tom Tromey  <tom@tromey.com>
3376
3377         * tui/tui-win.c (tui_resize_all): Use delete.
3378         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3379         destructor.
3380         (tui_free_window): Don't declare.
3381         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3382         Update.
3383
3384 2019-06-25  Tom Tromey  <tom@tromey.com>
3385
3386         * tui/tui-data.h (struct tui_win_info): Add constructor.
3387         * tui/tui-data.c (tui_alloc_win_info): Use new.
3388         (tui_free_window): Use delete.
3389
3390 2019-06-22  Tom Tromey  <tom@tromey.com>
3391
3392         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3393         declare.
3394         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3395
3396 2019-06-22  Tom Tromey  <tom@tromey.com>
3397
3398         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3399         declare.
3400         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3401
3402 2019-06-22  Tom de Vries  <tdevries@suse.de>
3403
3404         * dwarf2read.c (create_addrmap_from_aranges)
3405         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3406         instead of '%zu'.
3407
3408 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3409
3410         * dwarf2read.h (dwarf2_section_info_def): Remove.
3411         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3412         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3413         std::vector<dwarf2_section_info>.
3414         (struct dwo_file) <~dwo_file>: Remove.
3415         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3416         types field.
3417         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3418         (dwarf2_read_debug_names): Likewise.
3419         (create_debug_types_hash_table): Change parameter type to
3420         array_view, adjust code accordingly.
3421         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3422         (partial_die_info::fixup): Likewise.
3423         (determine_prefix): Likewise.
3424         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3425
3426 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3427
3428         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3429         gdb_bfd_ref_ptr.
3430         <~dwo_file>: Remove call to gdb_bfd_unref.
3431         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3432         gdb_bfd_ref_ptr::get.
3433
3434 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3435
3436         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3437         type to htab_up.
3438         * dwarf2read.c (struct dwo_file): Initialize fields.
3439         <~dwo_file>: New.
3440         (free_dwo_file): Remove, move content to ~dwo_file.
3441         (struct dwo_file_deleter): Remove.
3442         (dwo_file_up>: Remove custom deleter.
3443         (free_dwo_files): Remove.
3444         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3445         dwo_files.
3446         (process_skeletonless_type_units): Call unique_ptr::get.
3447         (allocate_dwo_file_hash_table): Add deleter to created hash
3448         table.  Change return type to htab_up.
3449         (lookup_dwo_file_slot): Don't memset dwo_file, call
3450         unique_ptr::get.
3451         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3452         (create_dwo_unit_in_dwp_v2): Likewise.
3453         (open_and_init_dwo_file): Likewise.
3454         (free_dwo_file_from_slot): Remove.
3455
3456 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3457
3458         * dwarf2read.h (struct dwarf2_section_info) <readin,
3459         is_virtual>: Change type to bool.
3460         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3461         true instead of 1.
3462
3463 2019-06-19  Tom Tromey  <tom@tromey.com>
3464
3465         * tui/tui-data.h (tui_init_content_element): Don't declare.
3466
3467 2019-06-19  Tom Tromey  <tom@tromey.com>
3468
3469         * tui/tui-data.h (tui_init_win_info): Don't declare.
3470
3471 2019-06-19  Tom de Vries  <tdevries@suse.de>
3472
3473         * dwarf2read.h (abstract_to_concrete): Change type to
3474         std::unordered_map<sect_offset, std::vector<sect_offset>,
3475         gdb::hash_enum<sect_offset>>.
3476
3477 2019-06-19  Tom Tromey  <tromey@adacore.com>
3478
3479         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3480         EVAL_AVOID_SIDE_EFFECTS specially.
3481
3482 2019-06-19  Tom Tromey  <tromey@adacore.com>
3483
3484         * source-cache.c (highlighter): New global.
3485         (source_cache::get_source_lines): Create a highlighter on demand.
3486
3487 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3488
3489         * defs.h (deprecated_interactive_hook): Delete declaration.
3490         * interps.c (clear_interpreter_hooks): Remove use of
3491         deprecated_interactive_hook.
3492         * top.c (deprecated_interactive_hook): Delete definition.
3493         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3494
3495 2019-06-18  Tom de Vries  <tdevries@suse.de>
3496
3497         PR gdb/24515
3498         * dwarf2read.h (abstract_to_concrete): Change type from
3499         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3500         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3501         * dwarf2read.c (read_variable): Update.
3502         (dwarf2_fetch_die_loc_sect_off): Update.
3503
3504 2019-06-17  Tom de Vries  <tdevries@suse.de>
3505
3506         PR gdb/24617
3507         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3508         accessing parent[parent_len - 1].
3509
3510 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3511
3512         PR gdb/24364
3513         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3514         call dtrace_process_dof with NULL dof.
3515
3516 2019-06-16  Tom de Vries  <tdevries@suse.de>
3517
3518         PR gdb/24445
3519         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3520
3521 2019-06-16  Tom Tromey  <tom@tromey.com>
3522
3523         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3524         (make_all_visible): Use address of member.
3525
3526 2019-06-16  Tom Tromey  <tom@tromey.com>
3527
3528         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3529         (tui_free_window, free_content, free_content_elements): Remove
3530         unnecessary cast.
3531         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3532         cast.
3533         * tui/tui-regs.c (tui_show_register_group)
3534         (tui_display_registers_from, tui_display_reg_element_at_line):
3535         Remove unnecessary cast.
3536
3537 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3538
3539         * linux-nat.c (normal_mask): Delete.
3540         (_initialize_linux_nat): Don't initialise normal_mask.
3541
3542 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3543
3544         PR gdb/24445
3545         * dwarf-index-write.h (write_psymtabs_to_index): Add
3546         dwz_basename parameter.
3547         * dwarf-index-write.c (write_gdbindex): Move file writing to
3548         write_gdbindex_1.  Change return type void.
3549         (assert_file_size): Move up, remove filename parameter.
3550         (write_gdbindex_1): New function.
3551         (write_debug_names): Change return type to void, call
3552         assert_file_size.
3553         (struct index_wip_file): New struct.
3554         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3555         file logic to index_wip_file.  Write index for dwz file if
3556         needed.
3557         (save_gdb_index_command): Pass basename of dwz file, if present.
3558         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3559         build-id of dwz file, if present.
3560         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3561         (dwarf2_get_dwz_file): Likewise.
3562         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3563         (dwarf2_get_dwz_file): Likewise.
3564
3565 2019-06-16  Tom Tromey  <tom@tromey.com>
3566
3567         * coffread.c (process_coff_symbol): Use xstrdup.
3568         * value.c (create_internalvar): Use xstrdup.
3569
3570 2019-06-16  Tom Tromey  <tom@tromey.com>
3571
3572         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3573         * breakpoint.c (stopin_command, stopat_command)
3574         (until_break_command, decode_location_default): Remove unnecessary
3575         cast.
3576         * utils.c (subset_compare): Remove unnecessary cast.
3577         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3578         cast.
3579         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3580         cast.
3581         * infcmd.c (path_command): Remove unnecessary cast.
3582         * coffread.c (decode_type): Remove unnecessary cast.
3583         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3584         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3585         * tui/tui-stack.c (tui_show_locator_content)
3586         (tui_show_frame_info): Remove unnecessary cast.
3587         * tui/tui-win.c (tui_scroll_forward_command)
3588         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3589         (parse_scrolling_args): Remove unnecessary cast.
3590         * tui/tui-data.c (init_win_info, tui_del_window)
3591         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3592         (free_content_elements): Remove unnecessary cast.
3593         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3594         unnecessary cast.
3595         * tui/tui-source.c (tui_set_source_content)
3596         (tui_vertical_source_scroll): Remove unnecessary cast.
3597         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3598         cast.
3599         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3600         * tui/tui-regs.c (tui_display_registers_from)
3601         (tui_display_register): Remove unnecessary cast.
3602         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3603         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3604         (make_visible): Remove unnecessary cast.
3605         * tui/tui-winsource.c (tui_erase_source_content)
3606         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3607         unnecessary cast.
3608         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3609         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3610         * stabsread.c (read_type, read_array_type, read_range_type):
3611         Remove unnecessary cast.
3612         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3613         (parse_symbol, parse_type, upgrade_type, parse_external)
3614         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3615         unnecessary cast.
3616         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3617
3618 2019-06-16  Tom Tromey  <tom@tromey.com>
3619
3620         * tui/tui-data.c (tui_alloc_generic_win_info)
3621         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3622         checks.
3623
3624 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3625             Andrew Burgess  <andrew.burgess@embecosm.com>
3626
3627         * f-typeprint.c (f_print_type): Don't return early for not
3628         associated or not allocated types.
3629         (f_type_print_varspec_suffix): Add print_rank parameter and print
3630         ranks of array types in case they dangling.
3631         (f_type_print_base): Add print_rank parameter.
3632
3633 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3634
3635         * NEWS: Mention new MI commands.
3636         * break-catch-throw.c (enum exception_event_kind): Move to
3637         breakpoint.h.
3638         (print_mention_exception_catchpoint): Output text as a single
3639         message.
3640         (catch_exception_command_1): Rename to...
3641         (catch_exception_event): ...this, make non-static, update header
3642         command, and change some parameter types.
3643         (catch_catch_command): Update for changes to
3644         catch_exception_command_1.
3645         (catch_throw_command): Likewise.
3646         (catch_rethrow_command): Likewise.
3647         * breakpoint.c (enum exception_event_kind): Delete.
3648         * breakpoint.h (enum exception_event_kind): Moved here from
3649         break-catch-throw.c.
3650         (catch_exception_event): Declare.
3651         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3652         (mi_cmd_catch_throw): New function.
3653         (mi_cmd_catch_rethrow): New function.
3654         (mi_cmd_catch_catch): New function.
3655         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3656         'catch-catch' entries.
3657         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3658         (mi_cmd_catch_rethrow): Declare.
3659         (mi_cmd_catch_catch): Declare.
3660
3661 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3662
3663         * annotate.c (annotate_source_line): Change return type to void,
3664         update implementation to match.
3665         * annotate.h (annotate_source_line): Change return type to void,
3666         update header comment.
3667         * stack.c (print_frame_info): Don't change what frame information
3668         is printed based on whether annotations are on or not.
3669
3670 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3671
3672         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3673         (annotate_source): Make static.
3674         (annotate_source_line): Moved from source.c and renamed from
3675         identify_source_line.  Update the return type.
3676         * annotate.h (annotate_source): Delete declaration.
3677         (annotate_source_line): Declaration moved from source.h, and
3678         renamed from identify_source_line.  Return type updated.
3679         * source.c (identify_source_line): Moved to annotate.c and renamed
3680         to annotate_source_line.
3681         (info_line_command): Remove check of annotation_level.
3682         * source.h (identify_source_line): Move declaration to annotate.h
3683         and rename to annotate_source_line.
3684         * stack.c: Add 'annotate.h' include.
3685         (print_frame_info): Remove check of annotation_level before
3686         calling annotate_source_line.
3687
3688 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3689
3690         * source-cache.c (source_cache::get_plain_source_lines): Use
3691         open_source_file_with_line_charpos instead of just
3692         open_source_file, remove call to find_source_lines.
3693         (source_cache::get_source_lines): Likewise.
3694         * source.c (find_source_lines): Make static.
3695         (get_filename_and_charpos): Renamed into...
3696         (open_source_file_with_line_charpos): ..this along with changes to
3697         return a scoped_fd, and some other minor clean ups.
3698         (identify_source_line): Use open_source_file_with_line_charpos.
3699         (search_command_helper): Use open_source_file_with_line_charpos
3700         instead of just open_source_file, remove call to
3701         find_source_lines.
3702         * source.h (open_source_file_with_line_charpos): Declare new
3703         function.
3704         (find_source_lines): Delete declaration.
3705
3706 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3707
3708         * source.c (get_filename_and_charpos): Remove fullname
3709         parameter.
3710         (identify_source_line): Update call to get_filename_and_charpos.
3711
3712 2019-06-14  Tom Tromey  <tromey@adacore.com>
3713
3714         PR gdb/24502:
3715         * ui-style.h (skip_ansi_escape): Update comment.
3716         * ui-file.h (class no_terminal_escape_file): New class.
3717         * ui-file.c (no_terminal_escape_file::write)
3718         (no_terminal_escape_file::puts): New methods.
3719         * cli/cli-logging.c (handle_redirections): Use
3720         no_terminal_escape_file.
3721
3722 2019-06-14  Tom Tromey  <tromey@adacore.com>
3723
3724         * NEWS: Move convenience variable news above Python news.
3725
3726 2019-06-14  Tom Tromey  <tom@tromey.com>
3727
3728         * gnulib: Move directory to top-level.
3729         * configure.ac: Don't configure gnulib.
3730         * configure: Rebuild.
3731         * common/common-defs.h: Use new path to gnulib.
3732         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3733         (GNULIB_H): Remove.
3734         (INCGNU): Look in new gnulib location.
3735         (HFILES_NO_SRCDIR): Remove gnulib files.
3736         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3737         (generated_files): Remove GNULIB_H.
3738         ($(LIBGNU), all-lib): Remove targets.
3739         (distclean): Don't mention GNULIB_BUILDDIR.
3740         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3741
3742 2019-06-14  Tom Tromey  <tromey@adacore.com>
3743
3744         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3745         Warn if symbol file does not provide any symbols.
3746
3747 2019-06-14  Tom Tromey  <tromey@adacore.com>
3748
3749         * source.c (find_and_open_source): Respect basenames_may_differ.
3750
3751 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3752
3753         * annotate.c (annotate_breakpoints_invalid): Make use of
3754         scoped_restore_terminal_state.
3755         (annotate_frames_invalid): Likewise.
3756
3757 2019-06-14  Tom Tromey  <tromey@adacore.com>
3758
3759         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3760         allow assignment to an internalvar.
3761
3762 2019-06-14  Tom Tromey  <tromey@adacore.com>
3763
3764         * ada-lex.l: Allow "_" in attribute names.
3765
3766 2019-06-14  Tom Tromey  <tromey@adacore.com>
3767
3768         PR gdb/24653:
3769         * regcache.c (registers_changed): Don't call alloca.
3770         * top.c (execute_command): Don't call alloca.
3771
3772 2019-06-13  Pedro Alves  <palves@redhat.com>
3773
3774         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3775         'expression'.  When parsing an expression, error out if there's
3776         junk after "unlimited".
3777         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3778         (do_set_command): Adjust calls to is_unlimited_literal.
3779
3780 2019-06-13  Pedro Alves  <palves@redhat.com>
3781
3782         * compile/compile.c (make_compile_options_def_group): Add braces
3783         around array_view initializer.
3784         * thread.c (make_thread_apply_all_options_def_group)
3785         (make_thread_apply_all_options_def_group): Likewise.
3786
3787 2019-06-13  Pedro Alves  <palves@redhat.com>
3788
3789         * NEWS (New commands): Mention "maint test-options
3790         require-delimiter", "maint test-options unknown-is-error", "maint
3791         test-options unknown-is-operand" and "maint show
3792         test-options-completion-result".
3793         (New command options, command completion): New section.
3794         (Completion improvements): New section.
3795         Mention that you can abbreviate "unlimited".
3796
3797 2019-06-13  Pedro Alves  <palves@redhat.com>
3798
3799         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3800         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3801         * unittests/cli-utils-selftests.c (test_parse_flags)
3802         (test_parse_flags_qcs): Delete.
3803         (test_cli_utils): Don't call deleted functions.
3804
3805 2019-06-13  Pedro Alves  <palves@redhat.com>
3806
3807         * thread.c: Include "cli/cli-option.h".
3808         (tp_array_compar_ascending): Global.
3809         (tp_array_compar): Delete function.
3810         (tp_array_compar_ascending, tp_array_compar_descending): New
3811         functions.
3812         (ascending_option_def, qcs_flag_option_def)
3813         (thr_qcs_flags_option_defs)
3814         (make_thread_apply_all_options_def_group)
3815         (make_thread_apply_options_def_group): New.
3816         (thread_apply_all_command): Use gdb::option::process_options.
3817         (thread_apply_command_completer)
3818         (thread_apply_all_command_completer): New.
3819         (thread_apply_command): Use gdb::option::process_options.
3820         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3821         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3822         to generate help text of "thread apply".  Adjust "taas"'s help.
3823         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3824         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3825
3826 2019-06-13  Pedro Alves  <palves@redhat.com>
3827
3828         * thread.c (thread_apply_command): Check for invalid TID with
3829         isdigit instead of !isalpha.
3830
3831 2019-06-13  Pedro Alves  <palves@redhat.com>
3832
3833         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3834         (validate_flags_qcs): New.
3835         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3836         (validate_flags_qcs): Declare.
3837         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3838         (make_frame_apply_options_def_group): New.
3839         (frame_apply_command_count): Process options with
3840         gdb::option::process_options.
3841         (frame_apply_completer): New.
3842         (frame_apply_level_completer, frame_apply_all_completer)
3843         (frame_apply_completer): New.
3844         (_initialize_stack): Update help of "frame apply", "frame apply
3845         level", "frame apply all" and "faas" to mention supported options
3846         and install command completers.
3847         * stack.h (frame_apply_all_completer): Declare.
3848         * thread.c: Include "stack.h".
3849         (tfaas_command): Add "--".
3850         (_initialize_thread): Update help "tfaas" to mention supported
3851         options and install command completer.
3852
3853 2019-06-13  Pedro Alves  <palves@redhat.com>
3854
3855         * completer.c (complete_nested_command_line): New.
3856         (gdb_completion_word_break_characters_throw): Add assertion.
3857         * completer.h (complete_nested_command_line): Declare.
3858
3859 2019-06-13  Pedro Alves  <palves@redhat.com>
3860
3861         * stack.c (parse_backtrace_qualifiers): New.
3862         (backtrace_command): Use it.
3863         (backtrace_command_completer): Complete on qualifiers.
3864
3865 2019-06-13  Pedro Alves  <palves@redhat.com>
3866
3867         * frame.c: Include "cli/cli-option.h.
3868         (user_set_backtrace_options): New.
3869         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3870         Delete.
3871         (get_prev_frame): Adjust.
3872         (boolean_option_def, uinteger_option_def)
3873         (set_backtrace_option_defs): New.
3874         (_initialize_frame): Adjust and use
3875         gdb::option::add_setshow_cmds_for_options to install "set
3876         backtrace past-main" and "set backtrace past-entry".
3877         * frame.h: Include "cli/cli-option.h".
3878         (struct frame_print_options): Forward declare.
3879         (print_frame_arguments_all, print_frame_arguments_scalars)
3880         (print_frame_arguments_none): Declare.
3881         (print_entry_values): Delete declaration.
3882         (struct frame_print_options, user_frame_print_options): New.
3883         (struct set_backtrace_options): New.
3884         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3885         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3886         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3887         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3888         (list_args_or_locals): Add frame_print_options parameter.
3889         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3890         * python/py-framefilter.c (enumerate_args): Pass down
3891         USER_FRAME_PRINT_OPTIONS.
3892         * stack.c: Include "cli/cli-option.h".
3893         (print_frame_arguments_all, print_frame_arguments_scalars)
3894         (print_frame_arguments_none): Declare.
3895         (print_raw_frame_arguments, print_entry_values): Delete.
3896         (user_frame_print_options): New.
3897         (boolean_option_def, enum_option_def, frame_print_option_defs):
3898         New.
3899         (struct backtrace_cmd_options): New.
3900         (bt_flag_option_def): New.
3901         (backtrace_command_option_defs): New.
3902         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3903         (print_frame_arg, read_frame_arg, print_frame_args)
3904         (print_frame_info, print_frame): Add frame_print_options parameter
3905         and use it.
3906         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3907         (backtrace_command_1): Add frame_print_options and
3908         backtrace_cmd_options parameters and use them.
3909         (make_backtrace_options_def_group): New.
3910         (backtrace_command): Process command options with
3911         gdb::option::process_options.
3912         (backtrace_command_completer): New.
3913         (_initialize_stack): Extend "backtrace"'s help to mention
3914         supported options.  Install completer for "backtrace".
3915         Install some settings commands with add_setshow_cmds_for_options.
3916
3917 2019-06-13  Pedro Alves  <palves@redhat.com>
3918
3919         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3920         and that "set/show print raw frame-arguments" are now deprecated.
3921
3922         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3923         command.
3924         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3925         * stack.c (_initialize_stack): Install "set/show print
3926         raw-frame-arguments", and deprecate "set/show print raw
3927         frame-arguments".
3928         * valprint.c (_initialize_valprint): Deprecate "set/show print
3929         raw".
3930
3931 2019-06-13  Pedro Alves  <palves@redhat.com>
3932
3933         * compile/compile.c (struct compile_options): New.
3934         (compile_flag_option_def, compile_command_option_defs)
3935         (make_compile_options_def_group): New.
3936         (compile_file_command): Handle options with
3937         gdb::option::process_options.
3938         (compile_file_command_completer): New function.
3939         (compile_code_command): Handle options with
3940         gdb::option::process_options.
3941         (compile_code_command_completer): New function.
3942         (_initialize_compiler): Install completers for "compile code" and
3943         "compile file".  Mention available options in "compile code" and
3944         "compile code"'s help.
3945         * completer.c (advance_to_completion_word): New, factored out from
3946         ...
3947         (advance_to_expression_complete_word_point): ... this.
3948         (advance_to_filename_complete_word_point): New.
3949         * completer.h (advance_to_filename_complete_word_point): New
3950         declaration.
3951
3952 2019-06-13  Pedro Alves  <palves@redhat.com>
3953
3954         * compile/compile.c: Include "cli/cli-option.h".
3955         (compile_print_value): Scope data pointer is now a
3956         value_print_options pointer; adjust.
3957         (compile_print_command): Process options.  Scope data pointer is
3958         now a value_print_options pointer; adjust.
3959         (_initialize_compile): Update "compile print"'s help to include
3960         supported options.  Install a completer for "compile print".
3961         * cp-valprint.c (show_vtblprint, show_objectprint)
3962         (show_static_field_print): Delete.
3963         (_initialize_cp_valprint): Don't install "set print
3964         static-members", "set print vtbl", "set print object" here.
3965         * printcmd.c: Include "cli/cli-option.h" and
3966         "common/gdb_optional.h".
3967         (print_command_parse_format): Rework to fill in a
3968         value_print_options instead of a format_data.
3969         (print_value): Change parameter type from format_data pointer to
3970         value_print_options reference.  Adjust.
3971         (print_command_1): Process options.  Adjust to pass down a
3972         value_print_options.
3973         (print_command_completer): New.
3974         (_initialize_printcmd): Install print_command_completer as
3975         handle_brkchars completer for the "print" command.  Update
3976         "print"'s help to include supported options.
3977         * valprint.c: Include "cli/cli-option.h".
3978         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3979         here from cp-valprint.c.
3980         (boolean_option_def, uinteger_option_def)
3981         (value_print_option_defs, make_value_print_options_def_group):
3982         New.  Use gdb::option::add_setshow_cmds_for_options to install
3983         "set print elements", "set print null-stop", "set print repeats",
3984         "set print pretty", "set print union", "set print array", "set
3985         print address", "set print symbol", "set print array-indexes".
3986         * valprint.h: Include <string> and "cli/cli-option.h".
3987         (make_value_print_options_def_group): Declare.
3988         (print_value): Change parameter type from format_data pointer to
3989         value_print_options reference.
3990         (print_command_completer): Declare.
3991
3992 2019-06-13  Pedro Alves  <palves@redhat.com>
3993
3994         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3995         (COMMON_SFILES): Add maint-test-settings.c.
3996         * cli/cli-decode.c (boolean_enums): New global, factored out from
3997         ...
3998         (add_setshow_boolean_cmd): ... here.
3999         * cli/cli-decode.h (boolean_enums): Declare.
4000         * cli/cli-option.c: New file.
4001         * cli/cli-option.h: New file.
4002         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4003         factored out from ...
4004         (parse_cli_boolean_value(const char *)): ... this.
4005         (is_unlimited_literal): Change parameter type to pointer to
4006         pointer.  Adjust and advance ARG pointer.
4007         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4008         (parse_cli_var_enum): New, factored out from ...
4009         (do_set_command): ... this.  Adjust.
4010         * cli/cli-setshow.h (parse_cli_boolean_value)
4011         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4012         (parse_cli_var_enum): Declare.
4013         * cli/cli-utils.c: Include "cli/cli-option.h".
4014         (get_ulongest): New.
4015         * cli/cli-utils.h (get_ulongest): Declare.
4016         (check_for_argument): New overloads.
4017         * maint-test-options.c: New file.
4018
4019 2019-06-13  Pedro Alves  <palves@redhat.com>
4020
4021         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4022         parse a range if "-" is at the end of the string.
4023
4024 2019-06-13  Pedro Alves  <palves@redhat.com>
4025
4026         * cli/cli-setshow.c (parse_auto_binary_operation)
4027         (parse_cli_boolean_value): Don't allow "o".
4028
4029 2019-06-13  Pedro Alves  <palves@redhat.com>
4030
4031         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4032         * NEWS: Mention maint test-settings KIND.
4033         * maint-test-settings.c: New file.
4034
4035 2019-06-13  Pedro Alves  <palves@redhat.com>
4036
4037         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4038         completer.
4039         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4040         "set" completers.
4041
4042 2019-06-13  Pedro Alves  <palves@redhat.com>
4043
4044         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4045         after item.
4046
4047 2019-06-13  Pedro Alves  <palves@redhat.com>
4048
4049         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4050
4051 2019-06-13  Pedro Alves <palves@redhat.com>
4052
4053         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4054         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4055         call.
4056         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4057         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4058         calls.
4059         (check_for_argument): Skip spaces after argument.
4060
4061 2019-06-13  Pedro Alves  <palves@redhat.com>
4062
4063         * thread.c (thread_apply_command): Adjust TID parsing.
4064         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4065         detected before end of string.
4066         (tid_is_in_list): Error out if LIST is invalid.
4067
4068 2019-06-13  Pedro Alves  <palves@redhat.com>
4069
4070         * completer.c (complete_line_internal_1): Rewind completion word
4071         point.
4072         (completion_tracker::advance_custom_word_point_by): Change
4073         parameter type to int.
4074         * completer.h (completion_tracker::advance_custom_word_point_by):
4075         Likewise.
4076
4077 2019-06-13  Pedro Alves  <palves@redhat.com>
4078
4079         * completer.c (advance_to_completion_word): Handle delimiters.
4080
4081 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4082
4083         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4084
4085 2019-06-11  Tom Tromey  <tom@tromey.com>
4086
4087         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4088         (xmalloc_failed): Move to alloc.c.
4089         * alloc.c: New file.
4090         * Makefile.in (COMMON_SFILES): Add alloc.c.
4091
4092 2019-06-11  Tom Tromey  <tom@tromey.com>
4093
4094         * nat/linux-waitpid.c: Don't include server.h.
4095         (linux_debug): Remove.
4096         (my_waitpid): Update.
4097
4098 2019-06-11  Tom Tromey  <tromey@adacore.com>
4099
4100         * infcall.c (_initialize_infcall): Remove trailing newline from
4101         help.
4102         * user-regs.c (_initialize_user_regs): Remove trailing newline
4103         from help.
4104         * typeprint.c (_initialize_typeprint): Remove trailing newline
4105         from help.
4106         * reverse.c (_initialize_reverse): Remove trailing newlines from
4107         help.
4108         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4109         from help.
4110         * language.c (add_set_language_command): Remove trailing newline
4111         from help.
4112         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4113         help.
4114         * disasm.c (_initialize_disasm): Remove trailing newline from
4115         help.
4116         * top.c (init_main): Remove trailing newline from help.
4117         * interps.c (_initialize_interpreter): Remove trailing newline
4118         from help.
4119         * btrace.c (_initialize_btrace): Remove trailing newlines from
4120         help.
4121         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4122         from help.
4123         * python/python.c (_initialize_python): Remove trailing newline
4124         from help.
4125         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4126         help.
4127         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4128         from help.  Reformat some text.
4129         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4130         from help.
4131         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4132         newline from help.
4133
4134 2019-06-11  Tom Tromey  <tromey@adacore.com>
4135
4136         * darwin-nat.c (darwin_decode_exception_message)
4137         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4138
4139 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4140
4141         * valops.c (value_slice): Check for not allocated or not
4142         associated values.
4143
4144 2019-06-10  Tom de Vries  <tdevries@suse.de>
4145
4146         PR gdb/24618
4147         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4148         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4149         invalid.
4150
4151 2019-06-10  Tom de Vries  <tdevries@suse.de>
4152
4153         PR gdb/24611
4154         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4155         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4156
4157 2019-06-10  Tom de Vries  <tdevries@suse.de>
4158
4159         PR symtab/24545
4160         * symtab.c (struct demangled_name_entry): Add language field.
4161         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4162         static minimal symbol".  Set and use language field.
4163
4164 2019-06-10  Tom Tromey  <tromey@adacore.com>
4165
4166         * ada-lang.c (_initialize_ada_language): Update help text.
4167
4168 2019-06-10  Tom Tromey  <tromey@adacore.com>
4169
4170         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4171         with a newline.
4172         * guile/guile.c (handle_boot_error): Don't end warning with a
4173         newline.
4174         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4175         warning with a newline.
4176         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4177         newline.
4178         (s12z_frame_cache): Likewise.
4179         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4180         a newline.
4181         * solib-svr4.c (disable_probes_interface): Don't end warning with
4182         a newline.
4183         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4184         newline.
4185         * python/python.c (do_finish_initialization): Don't end warning
4186         with a newline.
4187
4188 2019-06-10  Tom Tromey  <tom@tromey.com>
4189
4190         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4191         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4192         gdbpy_enter.
4193
4194 2019-06-10  Tom Tromey  <tromey@adacore.com>
4195
4196         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4197         data.
4198         (elf_new_init): Don't call stabsread_new_init.
4199         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4200         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4201         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4202
4203 2019-06-10  Tom de Vries  <tdevries@suse.de>
4204
4205         PR symtab/16264
4206         PR symtab/24517
4207         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4208
4209 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4210
4211         * source.c (find_and_open_source): Also rewrite relative file
4212         names.
4213
4214 2019-04-26  Amos Bird  <amosbird@gmail.com>
4215
4216         * annotate.c (annotate_thread_exited): Add "thread-exited"
4217         annotation.
4218
4219 2019-06-06  Tom Tromey  <tromey@adacore.com>
4220
4221         * maint.h (class scoped_command_stats): Use
4222         DISABLE_COPY_AND_ASSIGN.
4223         <print_time>: New method.
4224         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4225         print_time.
4226         (scoped_command_stats::print_time): New method.
4227
4228 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4229
4230         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4231         instructions of lengths 6 or 8 bytes.
4232
4233 2019-06-04  Pedro Alves  <palves@redhat.com>
4234
4235         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4236
4237         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4238         * breakpoint.c (condition_completer): Likewise.
4239         * cli/cli-dump.c (scan_expression): Likewise.
4240         * common/filestuff.c (mkdir_recursive): Likewise.
4241         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4242         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4243         (gdb_abspath): Likewise.
4244         * compile/compile-cplus-types.c
4245         (compile_cplus_instance::decl_name): Likewise.
4246         * completer.c (complete_explicit_location):
4247         (signal_completer, reg_or_group_completer_1): Likewise.
4248         * cp-support.c (cp_remove_params_if_any): Likewise.
4249         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4250         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4251         * infcmd.c (strip_bg_char): Likewise.
4252         * linespec.c (copy_token_string): Likewise.
4253         * mi/mi-main.c (output_cores): Likewise.
4254         * psymtab.c (psymtab_search_name):
4255         * symfile.c (test_set_ext_lang_command): Likewise.
4256         * target.c (target_fileio_read_stralloc): Likewise.
4257         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4258         * value.c (complete_internalvar): Likewise.
4259
4260 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4261
4262         Add objfile property to gdb.Type.
4263         * NEWS: Mention Python API addition.
4264         * python/py-type.c (typy_get_objfile): New method.
4265
4266 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4267
4268         * NEWS: Mention the new set|show style [title|highlight].
4269         Mention changes to "show style", "help" and "apropos".
4270
4271 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4272
4273         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4274         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4275         instead of print_help_for_command.
4276         (print_doc_of_command): New function.
4277         (help_list): Add 'apropos -v word' suggestion.
4278         (print_help_for_command): Style the command name using title style.
4279         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4280         (_initialize_cli_cmds): Describe -v in apropos_command help.
4281
4282 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4283
4284         * cli/cli-style.h (cli_style_option): Add name in constructor,
4285         add m_name class member, add constructor with intensity,
4286         add name class function.
4287         (cli_style_option::add_setshow_commands): Remove name argument.
4288         (highlight_style, title_style): New styles.
4289         * cli/cli-style.c (do_show): New function that shows a style
4290         characteristic styling the style name with itself.
4291         (set_style_name): New function.
4292         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4293         Update all callers according to the changes in cli/cli-style.h.
4294         * utils.h (fputs_highlighted): New function.
4295         * utils.c (fputs_highlighted): Likewise.
4296
4297 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4298
4299         * NEWS: Mention new pipe command and new convenience variables.
4300
4301 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4302
4303         * cli/cli-cmds.c (pipe_command): New function.
4304         (_initialize_cli_cmds): Call add_com for pipe_command.
4305         Define | as an alias for pipe.
4306         (exit_status_set_internal_vars): New function.
4307         (shell_escape): Call exit_status_set_internal_vars.
4308         cli/cli-decode.c (find_command_name_length): Recognize | as
4309         a single character command.
4310
4311 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4312
4313         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4314         top.c (execute_command_to_ui_file): New function, mostly a copy
4315         of execute_command_to_string.
4316         (execute_command_to_string): Implement by calling
4317         execute_command_to_ui_file.
4318
4319 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4320
4321         * top.h (saved_command_line): Remove declaration.
4322         * top.c (previous_saved_command_line, previous_repeat_arguments):
4323         New variables.
4324         (saved_command_line): Make static, define together with other
4325         'repeat variables'.
4326         (dont_repeat): Clear repeat_arguments.
4327         (repeat_previous, get_saved_command_line, save_command_line):
4328         New functions.
4329         (gdb_init): Initialize saved_command_line
4330         and previous_saved_command_line.
4331         * main.c (captured_main_1): Remove saved_command_line initialization.
4332         * event-top.c (handle_line_of_input): Update to use
4333         the new 'repeat' related functions instead of direct access to
4334         saved_command_line.
4335         * command.h (repeat_previous, get_saved_command_line,
4336         save_command_line): New declarations.
4337         (dont_repeat): Add comment.
4338
4339 2019-05-30  Tom Tromey  <tromey@adacore.com>
4340
4341         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4342         Fix comment.
4343         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4344
4345 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4346
4347         PR cli/24587
4348         * completer.c (complete): Initialize variable word.
4349
4350 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4351
4352         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4353         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4354         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4355         'body' is NULL to the outter 'if', protecting the '!is_define'
4356         situation as well.
4357
4358 2019-05-29  Tom Tromey  <tromey@adacore.com>
4359
4360         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4361         (dwarf_unknown): New function.
4362         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4363         (dwarf_type_encoding_name): Use dwarf_unknown.
4364
4365 2019-05-29  Tom Tromey  <tromey@adacore.com>
4366
4367         PR c++/20020:
4368         * cp-valprint.c (cp_print_value_fields): Call
4369         cp_print_static_field inside "try".
4370
4371 2019-05-29  Tom Tromey  <tromey@adacore.com>
4372
4373         * inflow.c (struct terminal_info): Add default operator=.
4374         * configure: Rebuild.
4375         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4376         -Wdeprecated-copy-dtor, -Wredundant-move.
4377
4378 2019-05-29  Tom Tromey  <tromey@adacore.com>
4379
4380         * NEWS: Add entry.
4381         * infcmd.c (print_return_value_1): Handle finish_print
4382         option.
4383         (show_print_finish): New function.
4384         (_initialize_infcmd): Add "set/show print finish" commands.
4385         * valprint.c (user_print_options): Initialize new member.
4386         * valprint.h (struct value_print_options) <finish_print>: New
4387         member.
4388
4389 2019-05-28  Tom Tromey  <tromey@adacore.com>
4390
4391         * ada-lang.c (ada_remove_Xbn_suffix)
4392         (find_old_style_renaming_symbol)
4393         (parse_old_style_renaming): Remove.
4394         (ada_find_renaming_symbol): Don't call
4395         find_old_style_renaming_symbol.
4396         (ada_is_renaming_symbol): Rename from
4397         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4398         bool.  Now static.
4399         (ada_read_var_value): Update and simplify.
4400         * ada-exp.y (write_var_or_type): Remove old code.
4401
4402 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4403
4404         * event-top.c: Remove include comment.
4405         * inflow.c (class scoped_ignore_sigttou): Move from here...
4406         * inflow.h (class scoped_ignore_sigttou): ...to here.
4407         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4408         * top.c:  Remove include comment.
4409
4410 2019-05-27  Tom Tromey  <tom@tromey.com>
4411
4412         * NEWS: Fix typo.
4413
4414 2019-05-22  Tom Tromey  <tromey@adacore.com>
4415
4416         * target.c (target_follow_exec): Constify parameter.
4417         * target-delegates.c: Rebuild.
4418         * remote.c (remote_target::follow_exec): Constify parameter.
4419         * infrun.c (follow_exec): Constify parameter.
4420         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4421         (target_follow_exec): Likewise.
4422
4423 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4424
4425         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4426         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4427
4428 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4429
4430         * NEWS: Add debugredirect and testsuite sections.
4431
4432 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4433
4434         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4435         target descriptions using exclusively floating point register name
4436         aliases.
4437
4438 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4439
4440         PR gdb/18644:
4441         * f-lang.c (build_fortran_types): Handle the case where
4442         gdbarch_floatformat_for_type returns a nullptr.
4443
4444 2019-05-21  Tom de Vries  <tdevries@suse.de>
4445
4446         PR cli/24587
4447         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4448
4449 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4450
4451         PR gdb/18644:
4452         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4453         16-byte floats.
4454         * i386-tdep.c (i386_floatformat_for_type): Use
4455         floatformats_ia64_quad for the 16-byte floating point component
4456         within a fortran 32-byte complex number.
4457
4458 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4459
4460         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4461         delete default constructor.
4462         (find_partial_die): Update to return const struct.
4463         (partial_die_parent_scope): Move variable declaration into scope
4464         of its use and change its type to auto.
4465         (guess_partial_die_structure_name): Likewise.
4466         (partial_die_info::fixup): Likewise.
4467
4468 2019-05-17  Tom Tromey  <tromey@adacore.com>
4469
4470         * source.c (find_and_open_source): Remove cast.
4471
4472 2019-05-17  Tom Tromey  <tromey@adacore.com>
4473
4474         * annotate.c (annotate_source): Make "filename" const.
4475         * annotate.h (annotate_source): Use const.
4476
4477 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4478
4479         * disasm.c (set_disassembler_options): Send errors to stderr.
4480
4481 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4482
4483         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4484         (cli_interp_base::set_logging): Check debug_redirect.
4485         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4486         * cli/cli-logging.c (debug_redirect): Add static variable.
4487         (pop_output_files): Add default param.
4488         (handle_redirections): Print debug setting.
4489         (show_logging_command): Likewise.
4490         (_initialize_cli_logging): Add debugredirect command.
4491         * interps.c (current_interp_set_logging): Add debug_redirect
4492         parameter.
4493         * interps.h (set_logging): Add debug_redirect parameter.
4494         (current_interp_set_logging): Likewise.
4495         * mi/mi-common.h: Likewise.
4496         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4497
4498 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4499             Tom Tromey  <tromey@adacore.com>
4500
4501         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4502         directly.
4503         * cli/cli-interp.h (make_logging_output): Remove declaration.
4504         * cli/cli-logging.c (make_logging_output): Remove function.
4505         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4506         directly.
4507         * ui-file.c (tee_file::tee_file): Remove bools.
4508         (tee_file::~tee_file): Remove deletes.
4509         * ui-file.h (tee_file): Remove bools.
4510
4511 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4512
4513         * mi/mi-cmds.h (mi_cmd_complete): New function.
4514         * mi/mi-main.c (mi_cmd_complete): Likewise.
4515         * mi/mi-cmds.c: Define new MI command -complete.
4516         * NEWS: Mention new -complete command.
4517
4518 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4519
4520         * completer.h (complete): New function.
4521         * completer.c (complete): Likewise.
4522         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4523         function defined in completer.h.
4524
4525 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4526
4527         * MAINTAINERS (Write After Approval): Add myself.
4528
4529 2019-05-17  Tom de Vries  <tdevries@suse.de>
4530
4531         PR gdb/24094
4532         * dwarf2read.c (struct cu_partial_die_info): New struct.
4533         (find_partial_die): Return cu_partial_die_info.
4534         (partial_die_parent_scope, guess_partial_die_structure_name)
4535         (partial_die_info::fixup): Handle new return type of find_partial_die.
4536
4537 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4538
4539         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4540         "std::string", simplifying the algorithm.
4541
4542 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4543
4544         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4545         (stap_static_probe_ops::get_probes): Likewise.
4546
4547 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4548
4549         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4550         '-')" and "else if".
4551         (stap_parse_single_operand): Join checks for
4552         "gdbarch_stap_parse_special_token_p" and
4553         "gdbarch_stap_parse_special_token" in the same "if" statement.
4554         Invert check when verifying for operation on register
4555         displacement.
4556
4557 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4558
4559         * stap-probe.c (stap_get_opcode): Update comment.
4560         (stap_get_expected_argument_type): Likewise.
4561         (handle_stap_probe): Likewise.
4562
4563 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4564
4565         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4566         return type to 'bool'.  Adjust comment.  Use 'bool' when
4567         appropriate.
4568         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4569         * stap-probe.c (stap_parse_argument_1): Likewise.
4570         (stap_is_operator): Likewise.
4571         (stap_is_generic_prefix): Likewise.
4572         (stap_is_register_prefix): Likewise.
4573         (stap_is_register_indirection_prefix): Likewise.
4574         (stap_is_integer_prefix): Likewise.
4575         (stap_generic_check_suffix): Likewise.
4576         (stap_check_integer_suffix): Likewise.
4577         (stap_check_register_suffix): Likewise.
4578         (stap_check_register_indirection_suffix): Likewise.
4579         (stap_parse_register_operand): Likewise.
4580         (stap_parse_single_operand): Likewise.
4581         (stap_parse_argument_1): Likewise.
4582         (stap_probe::get_argument_count): Likewise.
4583         (stap_is_operator): Likewise.
4584
4585 2019-05-16  Tom Tromey  <tromey@adacore.com>
4586
4587         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4588         keyword to foreach.
4589
4590 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4591
4592         * linux-thread-db.c (try_thread_db_load_1): Change return type
4593         to bool.
4594         (try_thread_db_load): Likewise.
4595         (try_thread_db_load_from_pdir_1): Likewise.
4596         (try_thread_db_load_from_pdir): Likewise.
4597         (try_thread_db_load_from_sdir): Likewise.
4598         (try_thread_db_load_from_dir): Likewise.
4599         (thread_db_load_search): Likewise.
4600         (has_libpthread): Likewise.
4601         (thread_db_load): Likewise.
4602
4603 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4604
4605         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4606         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4607         NULL, and complain/return if that's the case.
4608
4609 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4610
4611         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4612         (advance, posn, abstract_read_memory): New functions.
4613         [struct mem_read_abstraction]: New struct.
4614         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4615
4616 2019-05-14  Tom Tromey  <tromey@adacore.com>
4617
4618         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4619         value is not lval_memory.
4620
4621 2019-05-14  Tom Tromey  <tromey@adacore.com>
4622
4623         * solib.c (info_sharedlibrary_command): Style the file name.
4624
4625 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4626
4627         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4628         (aarch64_vnv_type): Likewise.
4629         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4630         * common/tdesc.c: Likewise.
4631         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4632         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4633         * features/aarch64-fpu.xml: Add ieee half view.
4634         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4635         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4636         * gdbtypes.h (struct builtin_type): Likewise.
4637         (struct objfile_type): Likewise.
4638
4639 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4640
4641         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4642         typo.
4643         * location.h (string_to_event_location): Likewise.
4644
4645 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4646
4647         GDB 8.3 released.
4648
4649 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4650
4651         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4652         New variable declaration.
4653         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4654         New variable.
4655         (print_one_breakpoint): Use ui_out::test_flags and new global
4656         variable to compute use_fixed_output.
4657         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4658         Remove.
4659         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4660         (mi_multi_location_breakpoint_output_fixed): Remove.
4661         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4662         new variable.
4663         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4664         fix_multi_location_breakpoint_output flag if version >= 3.
4665         * ui-out.h (enum ui_out_flag)
4666         <fix_multi_location_breakpoint_output>: New enumerator.
4667
4668 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4669
4670         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4671
4672 2019-05-10  Tom Tromey  <tromey@adacore.com>
4673
4674         * ada-lang.c (catch_ada_completer): New function.
4675         (_initialize_ada_language): Use it.
4676
4677 2019-05-10  Tom Tromey  <tromey@adacore.com>
4678
4679         * thread.c (print_thread_info): Make "requested_threads" const.
4680         * gdbthread.h (print_thread_info): Make "requested_threads"
4681         const.
4682         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4683         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4684
4685 2019-05-08  Tom Tromey  <tom@tromey.com>
4686
4687         * gdbtypes.c (objfile_type_data): Change type.
4688         (objfile_type, _initialize_gdbtypes): Update.
4689
4690 2019-05-08  Tom Tromey  <tom@tromey.com>
4691
4692         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4693         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4694         (_initialize_dwarf2_frame): Update.
4695
4696 2019-05-08  Tom Tromey  <tom@tromey.com>
4697
4698         * objc-lang.c (objc_objfile_data): Change type.
4699         (find_methods): Update.
4700         (_initialize_objc_lang): Remove.
4701
4702 2019-05-08  Tom Tromey  <tom@tromey.com>
4703
4704         * stabsread.c (rs6000_builtin_type_data): Change type.
4705         (rs6000_builtin_type, _initialize_stabsread): Update.
4706
4707 2019-05-08  Tom Tromey  <tom@tromey.com>
4708
4709         * mips-tdep.c (mips_pdr_data): Remove.
4710         (_initialize_mips_tdep): Update.
4711
4712 2019-05-08  Tom Tromey  <tom@tromey.com>
4713
4714         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4715         (hppa_init_objfile_priv_data, read_unwind_info)
4716         (find_unwind_entry, _initialize_hppa_tdep): Update.
4717
4718 2019-05-08  Tom Tromey  <tom@tromey.com>
4719
4720         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4721         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4722         on obstack.
4723         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4724
4725 2019-05-08  Tom Tromey  <tom@tromey.com>
4726
4727         * mdebugread.c (basic_type_data): Change type.
4728         (basic_type, _initialize_mdebugread): Update.
4729
4730 2019-05-08  Tom Tromey  <tom@tromey.com>
4731
4732         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4733
4734 2019-05-08  Tom Tromey  <tom@tromey.com>
4735
4736         * nto-tdep.c (nto_inferior_data_reg): Change type.
4737         (nto_inferior_data): Update.
4738         (nto_inferior_data_cleanup, nto_new_inferior_data)
4739         (_initialize_nto_tdep): Remove.
4740         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4741
4742 2019-05-08  Tom Tromey  <tom@tromey.com>
4743
4744         * ada-lang.c (struct ada_inferior_data): Add initializers.
4745         (ada_inferior_data): Change type.
4746         (ada_inferior_data_cleanup): Remove.
4747         (get_ada_inferior_data, ada_inferior_exit)
4748         (struct ada_pspace_data): Add initializers, destructor.
4749         (ada_pspace_data_handle): Change type.
4750         (get_ada_pspace_data): Update.
4751         (ada_pspace_data_cleanup): Remove.
4752
4753 2019-05-08  Tom Tromey  <tom@tromey.com>
4754
4755         * coffread.c (struct coff_symfile_info): Add initializers.
4756         (coff_objfile_data_key): Move lower.  Change type.
4757         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4758         Update.
4759         (coff_free_info): Remove.
4760
4761 2019-05-08  Tom Tromey  <tom@tromey.com>
4762
4763         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4764         (fbsd_pspace_data_handle): Move lower.  Change type.
4765         (get_fbsd_pspace_data): Update.
4766         (fbsd_pspace_data_cleanup): Remove.
4767         (_initialize_fbsd_tdep): Update.
4768
4769 2019-05-08  Tom Tromey  <tom@tromey.com>
4770
4771         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4772         (get_ada_tasks_pspace_data): Update.
4773         (ada_tasks_pspace_data_cleanup): Remove.
4774         (_initialize_tasks): Update.
4775         (ada_tasks_inferior_data_handle): Change type.
4776         (get_ada_tasks_inferior_data): Update.
4777         (ada_tasks_inferior_data_cleanup): Remove.
4778         (struct ada_tasks_pspace_data): Add initializers.
4779
4780 2019-05-08  Tom Tromey  <tom@tromey.com>
4781
4782         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4783         * symfile-debug.c (debug_sym_get_probes): Change type.
4784         * stap-probe.c (handle_stap_probe):
4785         (stap_static_probe_ops::get_probes): Change type.
4786         * probe.h (class static_probe_ops) <get_probes>: Change type.
4787         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4788         (parse_probes_in_pspace): Update.
4789         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4790         Update.
4791         (any_static_probe_ops::get_probes): Change type.
4792         * elfread.c (elfread_data): New typedef.
4793         (probe_key): Change type.
4794         (elf_get_probes): Likewise.  Update.
4795         (probe_key_free): Remove.
4796         (_initialize_elfread): Update.
4797         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4798         Change type.
4799         (dtrace_process_dof_probe, dtrace_process_dof)
4800         (dtrace_static_probe_ops::get_probe): Change type.
4801
4802 2019-05-08  Tom Tromey  <tom@tromey.com>
4803
4804         * xcoffread.c (struct xcoff_symfile_info): Rename from
4805         coff_symfile_info.  Add initializers.
4806         (xcoff_objfile_data_key): Move lower.  Change type.
4807         (XCOFF_DATA): Rewrite.
4808         (xcoff_free_info): Remove.
4809         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4810         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4811         (xcoff_initial_scan): Update.
4812
4813 2019-05-08  Tom Tromey  <tom@tromey.com>
4814
4815         * solib-svr4.c (struct svr4_info): Add initializers and
4816         destructor.
4817         <probes_table>: Now an htab_up.
4818         (solib_svr4_pspace_data): Change type.
4819         (free_probes_table): Simplify.
4820         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4821         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4822         (probes_table_remove_objfile_probes, register_solib_event_probe)
4823         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4824         (_initialize_svr4_solib): Update.
4825
4826 2019-05-08  Tom Tromey  <tom@tromey.com>
4827
4828         * remote.c (remote_pspace_data): Change type.
4829         (remote_pspace_data_cleanup): Remove.
4830         (get_remote_exec_file, set_pspace_remote_exec_file)
4831         (_initialize_remote): Update.
4832
4833 2019-05-08  Tom Tromey  <tom@tromey.com>
4834
4835         * breakpoint.c (breakpoint_objfile_key): Change type.
4836         (get_breakpoint_objfile_data): Update.
4837         (free_breakpoint_objfile_data): Remove.
4838         (_initialize_breakpoint): Update.
4839
4840 2019-05-08  Tom Tromey  <tom@tromey.com>
4841
4842         * linux-tdep.c (struct linux_info): Add initializers.
4843         (linux_inferior_data): Move.  Change type.
4844         (invalidate_linux_cache_inf): Update.
4845         (linux_inferior_data_cleanup): Remove.
4846         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4847
4848 2019-05-08  Tom Tromey  <tom@tromey.com>
4849
4850         * auxv.c (auxv_inferior_data): Move.  Change type.
4851         (auxv_inferior_data_cleanup): Remove.
4852         (invalidate_auxv_cache_inf): Rewrite.
4853         (get_auxv_inferior_data, _initialize_auxv): Update.
4854
4855 2019-05-08  Tom Tromey  <tom@tromey.com>
4856
4857         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4858         (symfile_debug_objfile_data_key): Change type.
4859         (symfile_debug_installed, debug_qf_has_symbols)
4860         (debug_qf_find_last_source_symtab)
4861         (debug_qf_forget_cached_source_info)
4862         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4863         (debug_qf_print_stats, debug_qf_dump)
4864         (debug_qf_expand_symtabs_for_function)
4865         (debug_qf_expand_all_symtabs)
4866         (debug_qf_expand_symtabs_with_fullname)
4867         (debug_qf_map_matching_symbols)
4868         (debug_qf_expand_symtabs_matching)
4869         (debug_qf_find_pc_sect_compunit_symtab)
4870         (debug_qf_map_symbol_filenames)
4871         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4872         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4873         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4874         (debug_sym_read_linetable, debug_sym_relocate): Update.
4875         (symfile_debug_free_objfile): Remove.
4876         (install_symfile_debug_logging, _initialize_symfile_debug):
4877         Update.
4878
4879 2019-05-08  Tom Tromey  <tom@tromey.com>
4880
4881         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4882         allocate_on_obstack.
4883         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4884         (get_dwarf2_per_objfile): Update.
4885         (set_dwarf2_per_objfile): Remove.
4886         (dwarf2_has_info, dwarf2_get_section_info): Update.
4887         (dwarf2_free_objfile): Remove.
4888         (_initialize_dwarf2_read): Update.
4889
4890 2019-05-08  Tom Tromey  <tom@tromey.com>
4891
4892         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4893         initializers.
4894         <unsupported_script_warning_printed,
4895         script_not_found_warning_printed>: Now bool.
4896         (auto_load_pspace_data): Change type.
4897         (~auto_load_pspace_info): Rename from
4898         auto_load_pspace_data_cleanup.
4899         (get_auto_load_pspace_data, init_loaded_scripts_info)
4900         (clear_section_scripts, maybe_print_unsupported_script_warning)
4901         (maybe_print_script_not_found_warning, _initialize_auto_load):
4902         Update.
4903
4904 2019-05-08  Tom Tromey  <tom@tromey.com>
4905
4906         * objfiles.c (objfile_pspace_info): Add destructor and
4907         initializers.
4908         (objfiles_pspace_data): Change type.
4909         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4910         (get_objfile_pspace_data): Update.
4911         (objfiles_bfd_data): Change type.
4912         (get_objfile_bfd_data): Update.
4913         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4914
4915 2019-05-08  Tom Tromey  <tom@tromey.com>
4916
4917         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4918         Change type.
4919         (get_catch_syscall_inferior_data): Update.
4920         (catch_syscall_inferior_data_cleanup): Remove.
4921         (_initialize_break_catch_syscall): Update.
4922
4923 2019-05-08  Tom Tromey  <tom@tromey.com>
4924
4925         * inflow.c (struct terminal_info): Add destructor and
4926         initializers.
4927         (inflow_inferior_data): Change type.
4928         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4929         (get_inflow_inferior_data, inflow_inferior_exit)
4930         (swap_terminal_info, _initialize_inflow): Update.
4931
4932 2019-05-08  Tom Tromey  <tom@tromey.com>
4933
4934         * target-dcache.c (target_dcache_cleanup): Remove.
4935         (target_dcache_aspace_key): Change type.
4936         (target_dcache_init_p, target_dcache_invalidate)
4937         (target_dcache_get, target_dcache_get_or_init)
4938         (_initialize_target_dcache): Update.
4939         * dcache.h (struct dcache_deleter): New.
4940
4941 2019-05-08  Tom Tromey  <tom@tromey.com>
4942
4943         * symtab.c (struct symbol_cache): Add destructor and
4944         initializers.
4945         (symbol_cache_key): Move.  Change type.
4946         (make_symbol_cache, free_symbol_cache): Remove.
4947         (get_symbol_cache): Update.
4948         (symbol_cache_cleanup): Remove.
4949         (ALL_PSPACES, symbol_cache_flush)
4950         (maintenance_print_symbol_cache)
4951         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4952         Update.
4953
4954 2019-05-08  Tom Tromey  <tom@tromey.com>
4955
4956         * symtab.c (struct main_info): Add destructor and initializers.
4957         (main_progspace_key): Move.  Change type.
4958         (get_main_info): Update.
4959         (main_info_cleanup): Remove.
4960         (_initialize_symtab): Update.
4961
4962 2019-05-08  Tom Tromey  <tom@tromey.com>
4963
4964         * registry.h (DECLARE_REGISTRY): Define the _key class.
4965
4966 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4967
4968         * NEWS: Merge two 'New commands' sections.
4969
4970 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4971
4972         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4973         parameter and use Ada language definition instead.
4974         (ada_val_print_ptr): Remove unused language parameter.
4975         (ada_val_print_num): Remove language parameter and use Ada language
4976         definition instead.
4977         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4978         parameter.
4979         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4980         parameter and use Ada language definition instead.
4981         (ada_val_print_1): Update all ada_val_print_xxx calls.
4982         Remove language parameter.
4983         (ada_val_print): Update ada_val_print_1 call.
4984
4985 2019-05-08  Tom Tromey  <tromey@adacore.com>
4986
4987         * remote.c (remote_hw_watchpoint_limit)
4988         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4989         Now static.
4990
4991 2019-05-08  Tom Tromey  <tromey@adacore.com>
4992
4993         * maint.c (_initialize_maint_cmds): Move initialization code to
4994         remote.c.
4995         (watchdog, show_watchdog): Move to remote.c.
4996         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4997         "watchdog" static.
4998         (_initialize_remote): Move initialization code from maint.c.
4999         * defs.h (watchdog): Don't declare.
5000
5001 2019-05-08  Tom Tromey  <tromey@adacore.com>
5002
5003         * tui/tui-interp.c: Include main.h.
5004         * interps.c: Include main.h.
5005         * main.h (interpreter_p): Declare.
5006         * defs.h (interpreter_p): Don't declare.
5007
5008 2019-05-08  Tom Tromey  <tromey@adacore.com>
5009
5010         * dwarf2loc.c: Include dwarf2read.h.
5011         * defs.h (read_unsigned_leb128): Don't declare.
5012         * dwarf2read.h (read_unsigned_leb128): Declare.
5013
5014 2019-05-08  Tom Tromey  <tromey@adacore.com>
5015
5016         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5017         method.
5018
5019 2019-05-08  Tom Tromey  <tromey@adacore.com>
5020
5021         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5022         when no wrap column is set.
5023
5024 2019-05-08  Tom Tromey  <tromey@adacore.com>
5025
5026         * c-lang.c (c_get_string): Handle non-C-style arrays.
5027
5028 2019-05-08  Tom Tromey  <tromey@adacore.com>
5029
5030         * typeprint.c (print_offset_data::update): Print the bit offset,
5031         not the number of bits remaining.
5032
5033 2019-05-08  Tom Tromey  <tromey@adacore.com>
5034
5035         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5036         padding at end of comment.
5037
5038 2019-05-08  Tom Tromey  <tromey@adacore.com>
5039
5040         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5041         Compare main types.
5042
5043 2019-05-06  Tom Tromey  <tom@tromey.com>
5044
5045         * common/scoped_mmap.c: Include common-defs.h.
5046         * common/scoped_mmap.h: Don't include config.h.
5047
5048 2019-05-04  Tom Tromey  <tom@tromey.com>
5049
5050         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5051         (struct aarch64_call_info): Add initializers.
5052         <si>: Now a std::vector.
5053         (pass_on_stack, aarch64_push_dummy_call): Update.
5054
5055 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5056             Tom Tromey  <tom@tromey.com>
5057
5058         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5059         (ppc_threads): Now a std::vector.  Now static.
5060         (hwdebug_find_thread_points_by_tid)
5061         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5062         Update.
5063
5064 2019-05-04  Tom Tromey  <tom@tromey.com>
5065
5066         * arc-tdep.c (arc_tdesc_init): Return bool.
5067
5068 2019-05-04  Tom Tromey  <tom@tromey.com>
5069
5070         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5071         Use gdb_assert_not_reached.
5072
5073 2019-05-04  Tom Tromey  <tom@tromey.com>
5074
5075         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5076         "false".
5077
5078 2019-05-04  Tom Tromey  <tom@tromey.com>
5079
5080         * arc-tdep.c (arc_tdesc_init): Use bool.
5081
5082 2019-05-04  Tom Tromey  <tom@tromey.com>
5083
5084         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5085
5086 2019-05-04  Tom Tromey  <tom@tromey.com>
5087
5088         * cli/cli-cmds.c (valid_command_p): Return bool.
5089
5090 2019-05-04  Tom Tromey  <tom@tromey.com>
5091
5092         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5093         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5094
5095 2019-05-04  Raul Tambre  <raul@tambre.ee>
5096
5097         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5098         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5099         operator for comparison.
5100
5101 2019-05-04  Tom Tromey  <tom@tromey.com>
5102
5103         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5104         (lookup_partial_symbol, print_partial_symbols)
5105         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5106         (psymbol_compare): Update.
5107         (add_psymbol_to_bcache): Clear the entire psymbol.
5108         (maintenance_check_psymtabs): Update.
5109         * psympriv.h (struct partial_symbol): Don't derive from
5110         general_symbol_info.
5111         <obj_section, unrelocated_address, address,
5112         set_unrelocated_address>: Update.
5113         <ginfo>: New member.
5114         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5115         (debug_names::write_psymbols): Update.
5116
5117 2019-05-04  Tom de Vries  <tdevries@suse.de>
5118
5119         * contrib/cc-with-tweaks.sh: Support -n arg.
5120
5121 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5122
5123         * corelow.c (core_target::detach): Ensure frame cache and
5124         register caches are cleared.
5125         inferior.c (exit_inferior_1): Likewise.
5126
5127 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5128             Tom Tromey  <tom@tromey.com>
5129
5130         * dictionary.c (collate_pending_symbols_by_language): Remove
5131         "struct" from foreach.
5132         * symtab.c (lookup_global_symbol_from_objfile)
5133         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5134         foreach.
5135         * ser-tcp.c (net_open): Remove "struct" from foreach.
5136         * objfiles.c (objfile_relocate, objfile_rebase)
5137         (objfile_has_symbols): Remove "struct" from foreach.
5138         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5139         from foreach.
5140         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5141         foreach.
5142         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5143         "struct" from foreach.
5144         * ada-lang.c (create_excep_cond_exprs)
5145         (ada_exception_catchpoint_cond_string): Remove "struct" from
5146         foreach.
5147
5148 2019-05-03  Tom Tromey  <tromey@adacore.com>
5149
5150         * ada-exp.y (convert_char_literal): Check suffix of each
5151         enumerator.
5152
5153 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5154
5155         PR ada/21406:
5156         * ada-exp.y (yywrap): Don't define.
5157         * ada-lex.l (%option): Add noyywrap
5158         (yywrap): Remove.
5159
5160 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5161
5162         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5163         _WIN32_WINNT to the XP level, unless already defined to a higher
5164         level.
5165
5166         * unittests/parse-connection-spec-selftests.c:
5167         * ser-tcp.c:
5168         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5169         override.
5170
5171         * symfile.c (find_separate_debug_file): Remove colon from the
5172         drive spec of DOS/Windows file names of the target, so that the
5173         file name produced from DEBUGDIR and the target's directory will
5174         be valid on DOS/Windows systems.
5175
5176 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5177
5178         * rust-lang.c (val_print_struct): Handle printing structures
5179         containing strings.
5180
5181 2019-05-02  Tom Tromey  <tromey@adacore.com>
5182
5183         * valarith.c (_initialize_valarith): Remove.
5184
5185 2019-05-01  Tom Tromey  <tromey@adacore.com>
5186
5187         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5188         bitfields.
5189
5190 2019-05-01  Tom Tromey  <tromey@adacore.com>
5191
5192         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5193         for big-endian copies.
5194
5195 2019-04-30  Ali Tamur  <tamur@google.com>
5196         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5197         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5198         (read_3_bytes): New function.
5199
5200 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5201
5202         * windows-nat.c (main_thread_id): Delete.
5203         (handle_output_debug_string): Replace main_thread_id by
5204         current_event.dwThreadId.
5205         (fake_create_process): Likewise.
5206         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5207         Do not set main_thread_id.
5208         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5209         current_event.dwThreadId.
5210         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5211
5212 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5213
5214         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5215         Use current_event.dwThreadId instead of main_thread_id.
5216
5217 2019-04-30  Tom Tromey  <tromey@adacore.com>
5218
5219         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5220         (create_excep_cond_exprs): Iterate over program spaces.
5221         (ada_exception_catchpoint_cond_string): Examine all minimal
5222         symbols for exception types.
5223
5224 2019-04-30  Tom Tromey  <tromey@adacore.com>
5225
5226         PR c++/24470:
5227         * dwarf2read.c (process_structure_scope): Handle case where type
5228         has template parameters but no symbol was created.
5229
5230 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5231             Chris January  <chris.january@arm.com>
5232
5233         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5234         qualifier.
5235         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5236
5237 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5238
5239         * f-typeprint.c (f_print_type): Update rules for printing
5240         whitespace.
5241         (f_type_print_varspec_suffix): Likewise.
5242
5243 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5244             Chris January  <chris.january@arm.com>
5245
5246         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5247         function arguments.
5248
5249 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5250
5251         * f-lang.c (build_fortran_types): Change name of void type to
5252         lower case.
5253         * f-typeprint.c (f_type_print_base): Print the name of the void
5254         type, rather than a fixed string.
5255         * f-valprint.c (f_decorations): Use lower case void string.
5256
5257 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5258             Chris January  <chris.january@arm.com>
5259
5260         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5261         types for Fortran.
5262
5263 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5264             Chris January  <chris.january@arm.com>
5265             David Lecomber  <david.lecomber@arm.com>
5266
5267         * f-exp.y (BINOP_INTRINSIC): New token.
5268         (exp): New parser rule handling BINOP_INTRINSIC.
5269         (f77_keywords): Add new builtin procedures.
5270         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5271         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5272         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5273         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5274         (print_unop_subexp_f): New function.
5275         (print_binop_subexp_f): New function.
5276         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5277         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5278         (dump_subexp_body_f): Likewise.
5279         (operator_check_f): Likewise.
5280         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5281         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5282
5283 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5284
5285         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5286         UNOP_KIND.
5287         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5288         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5289         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5290         (operator_length_f): New fuction.
5291         (print_subexp_f): New function.
5292         (op_name_f): New function.
5293         (dump_subexp_body_f): New function.
5294         (operator_check_f): New function.
5295         (exp_descriptor_f): Replace standard expression handling functions
5296         with new functions.
5297         * gdb/fortran-operator.def: New file.
5298         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5299         * gdb/std-operator.def: Remove UNOP_KIND.
5300
5301 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5302
5303         * std-operator.def: Remove unbalanced, stray double quote
5304         character.
5305
5306 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5307             Chris January  <chris.january@arm.com>
5308             Daniel Everett  <daniel.everett@arm.com>
5309             Nick Forrington  <nick.forrington@arm.com>
5310             Richard Bunt  <richard.bunt@arm.com>
5311
5312         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5313         of depth when printing anonymous structs or unions.
5314         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5315         Don't print either the top-level value, or the children if the
5316         max-depth is exceeded.
5317         (ppscm_print_children): When printing the key of a map, allow one
5318         extra level of depth.
5319         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5320         print either the top-level value, or the children if the max-depth
5321         is exceeded.
5322         (print_children): When printing the key of a map, allow one extra
5323         level of depth.
5324         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5325         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5326         (user_print_options): Initialise max_depth field.
5327         (val_print_scalar_or_string_type_p): New function.
5328         (val_print): Check to see if the max depth has been reached.
5329         (val_print_check_max_depth): Define new function.
5330         (show_print_max_depth): New function.
5331         (_initialize_valprint): Add 'print max-depth' option.
5332         * valprint.h (struct value_print_options) <max_depth>: New field.
5333         (val_print_check_max_depth): Declare new function.
5334         * NEWS: Document new feature.
5335
5336 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5337
5338         * ada-lang.c (ada_language_defn): Initialise new field.
5339         * c-lang.c (c_is_string_type_p): New function.
5340         (c_language_defn): Initialise new field.
5341         (cplus_language_defn): Initialise new field.
5342         (asm_language_defn): Initialise new field.
5343         (minimal_language_defn): Initialise new field.
5344         * c-lang.h (c_is_string_type_p): Declare new function.
5345         * d-lang.c (d_language_defn): Initialise new field.
5346         * f-lang.c (f_is_string_type_p): New function.
5347         (f_language_defn): Initialise new field.
5348         * go-lang.c (go_is_string_type_p): New function.
5349         (go_language_defn): Initialise new field.
5350         * language.c (default_is_string_type_p): New function.
5351         (unknown_language_defn): Initialise new field.
5352         (auto_language_defn): Initialise new field.
5353         * language.h (struct language_defn) <la_is_string_type_p>: New
5354         member variable.
5355         (default_is_string_type_p): Declare new function.
5356         * m2-lang.c (m2_language_defn): Initialise new field.
5357         * objc-lang.c (objc_language_defn): Initialise new field.
5358         * opencl-lang.c (opencl_language_defn): Initialise new field.
5359         * p-lang.c (pascal_is_string_type_p): New function.
5360         (pascal_language_defn): Initialise new field.
5361         * rust-lang.c (rust_is_string_type_p): New function.
5362         (rust_language_defn): Initialise new field.
5363
5364 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5365
5366         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5367         New field.
5368         * ada-lang.c (ada_language_defn): Initialise new field.
5369         * c-lang.c (c_language_defn): Likewise.
5370         (cplus_language_defn): Likewise.
5371         (asm_language_defn): Likewise.
5372         (minimal_language_defn): Likewise.
5373         * d-lang.c (d_language_defn): Likewise.
5374         * f-lang.c (f_language_defn): Likewise.
5375         * go-lang.c (go_language_defn): Likewise.
5376         * language.c (unknown_language_defn): Likewise.
5377         (auto_language_defn): Likewise.
5378         * m2-lang.c (m2_language_defn): Likewise.
5379         * objc-lang.c (objc_language_defn): Likewise.
5380         * opencl-lang.c (opencl_language_defn): Likewise.
5381         * p-lang.c (pascal_language_defn): Likewise.
5382         * rust-lang.c (rust_language_defn): Likewise.
5383
5384 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5385
5386         * ada-lang.c (ada_is_character_type): Change return type to bool.
5387         (ada_is_string_type): Likewise.
5388         * ada-lang.h (ada_is_character_type): Update declaration
5389         (ada_is_string_type): Likewise.
5390
5391 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5392
5393         Support style in 'frame|thread apply'
5394
5395         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5396         * record.c (record_start, record_stop): Update callers of
5397         execute_command_to_string with false.
5398         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5399         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5400         methods.
5401         (class string_file): New constructor with term_out parameter.
5402         Override methods term_out and can_emit_style_escape.  New member
5403         term_out.
5404         (class stdio_file): Override can_emit_style_escape.
5405         (class tee_file): Override term_out and can_emit_style_escape.
5406         * utils.h (can_emit_style_escape): Remove.
5407         * utils.c (can_emit_style_escape): Likewise.
5408         Update all callers of can_emit_style_escape (SOMESTREAM) to
5409         SOMESTREAM->can_emit_style_escape.
5410         * source-cache.c (source_cache::get_source_lines): Likewise.
5411         * stack.c (frame_apply_command_count): Call execute_command_to_string
5412         passing the term_out characteristic of the current gdb_stdout.
5413         * thread.c (thr_try_catch_cmd): Likewise.
5414         * top.c (execute_command_to_string): pass term_out parameter
5415         to construct the string_file for the command output.
5416         * ui-file.c (term_cli_styling): New function (most code moved
5417         from utils.c can_emit_style_escape).
5418         (string_file::string_file, string_file::can_emit_style_escape,
5419         stdio_file::can_emit_style_escape, tee_file::term_out,
5420         tee_file::can_emit_style_escape): New functions.
5421
5422 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5423
5424         * NEWS: Mention the new set|show may-call-functions.
5425         * infcall.c (may_call_functions_p): New variable.
5426         (show_may_call_functions_p): New function.
5427         (call_function_by_hand_dummy): Throws an error if not
5428         may-call-functions.
5429         (_initialize_infcall): Call add_setshow_boolean_cmd for
5430         may-call-functions.
5431
5432 2019-04-25  Keith Seitz  <keiths@redhat.com>
5433
5434         PR c++/24367
5435         * cp-support.c (inspect_type): Don't attempt substitutions
5436         of symbol with the same name.
5437
5438 2019-04-25  Tom Tromey  <tromey@adacore.com>
5439
5440         PR gdb/24475:
5441         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5442         static.
5443
5444 2019-04-25  Tom Tromey  <tromey@adacore.com>
5445
5446         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5447         rvalue reference.
5448         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5449         (gdb_xml_parser::parse): Use std::move.
5450         * python/python-internal.h (gdbpy_convert_exception): Take a const
5451         reference.
5452         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5453         std::move.
5454         * python/py-utils.c (gdbpy_convert_exception): Take a const
5455         reference.
5456         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5457         Use std::move.
5458         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5459         Use std::move.
5460         * mi/mi-main.c (mi_print_exception): Take a const reference.
5461         * main.c (handle_command_errors): Take a const reference.
5462         * linespec.c (parse_linespec): Use std::move.
5463         * infcall.c (run_inferior_call): Use std::move.
5464         (call_function_by_hand_dummy): Use std::move.
5465         * exec.c (try_open_exec_file): Use std::move.
5466         * exceptions.h (exception_print, exception_fprintf)
5467         (exception_print_same): Update.
5468         * exceptions.c (print_exception, exception_print)
5469         (exception_fprintf, exception_print_same): Change parameters to
5470         const reference.
5471         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5472         * common/new-op.c: Use std::move.
5473         * common/common-exceptions.h (struct gdb_exception): Add move
5474         constructor.
5475         (struct gdb_exception_error, struct gdb_exception_quit, struct
5476         gdb_quit_bad_alloc): Change constructor to move constructor.
5477         (throw_exception): Change parameter to rvalue reference.
5478         * common/common-exceptions.c (throw_exception): Take rvalue
5479         reference.
5480         * cli/cli-interp.c (safe_execute_command): Use std::move.
5481         * breakpoint.c (insert_bp_location, location_to_sals): Use
5482         std::move.
5483
5484 2019-04-25  Tom Tromey  <tromey@adacore.com>
5485
5486         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5487         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5488         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5489         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5490         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5491         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5492         guile/scm-value.c: Use unpack.
5493         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5494         gdbscm_gdb_exception.
5495         (gdbscm_throw_gdb_exception): Likewise.
5496         (struct gdbscm_gdb_exception): New.
5497         (unpack): New function.
5498         (gdbscm_wrap): Use unpack.
5499
5500 2019-04-25  Tom Tromey  <tromey@adacore.com>
5501
5502         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5503         (gdb_rl_callback_handler): Use std::move.
5504         * common/common-exceptions.h (struct gdb_exception): Add move
5505         assignment operator.
5506         (throw_exception_sjlj): Change "exception" to const reference.
5507         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5508         (throw_exception_sjlj): Change "exception" to const reference.
5509
5510 2019-04-25  Tom Tromey  <tromey@adacore.com>
5511
5512         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5513         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5514         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5515         Update.
5516         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5517         Update.
5518         * mi/mi-interp.c (mi_interp::exec): Update.
5519         * linespec.c (parse_linespec): Update.
5520         * infcall.c (run_inferior_call): Update.
5521         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5522         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5523         (gdbscm_lookup_global_symbol): Update.
5524         * guile/scm-param.c (gdbscm_parameter_value): Update.
5525         * guile/scm-frame.c (gdbscm_frame_read_register)
5526         (gdbscm_frame_read_var): Update.
5527         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5528         * exec.c (try_open_exec_file): Update.
5529         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5530         (gdb_rl_callback_handler): Update.
5531         * common/common-exceptions.h (exception_none): Don't declare.
5532         * common/common-exceptions.c (exception_none): Don't define.
5533         (struct catcher) <exception>: Update.
5534         * cli/cli-interp.c (safe_execute_command): Update.
5535         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5536
5537 2019-04-25  Ali Tamur  <tamur@google.com>
5538
5539         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5540         (read_attribute_value): Likewise.
5541         (dwarf2_read_addr_index): Update comment.
5542         (read_str_index): Add DW_FORM_strx.
5543         (dwarf2_string_attr): Likewise.
5544         (dwarf2_const_value_attr): Likewise.
5545         (dump_die_shallow): Likewise.
5546         (dwarf2_fetch_constant_bytes): Likewise.
5547         (skip_form_bytes): Likewise.
5548         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5549
5550 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5551
5552         PR corefiles/11608
5553         PR corefiles/18187
5554         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5555         OFFSET.  Verify if current mapping contains an ELF header.
5556         (linux_find_memory_regions_full): Adjust call to
5557         dump_mapping_p.
5558
5559 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5560             Kang Li <kanglictf@gmail.com>
5561
5562         PR gdb/21600
5563
5564         * dwarf2-frame.c (read_initial_length): Be consistent about using
5565         unsigned representation of length.
5566         (decode_frame_entry_1): Likewise.  Check for wraparound of
5567         end pointer as well as buffer overflow.
5568
5569 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5570
5571         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5572         "vq".
5573
5574 2019-04-24  Tom Tromey  <tromey@adacore.com>
5575
5576         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5577
5578 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5579
5580         * s12z-tdep.c (s12z_unwind_pc): Delete.
5581         (s12z_unwind_sp): Delete.
5582         (s12z_gdbarch_init): Don't register deleted functions with
5583         gdbarch.
5584
5585 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5586
5587         * rl78-tdep.c (rl78_unwind_sp): Delete.
5588         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5589
5590 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5591
5592         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5593         (xstormy16_unwind_pc): Delete.
5594         (xstormy16_dummy_id): Delete.
5595         (xstormy16_gdbarch_init): Don't register deleted functions with
5596         gdbarch.
5597
5598 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5599
5600         * vax-tdep.c (vax_unwind_pc): Delete.
5601         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5602
5603 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5604
5605         * v850-tdep.c (v850_unwind_sp): Delete.
5606         (v850_unwind_pc): Delete.
5607         (v850_dummy_id): Delete.
5608         (v850_gdbarch_init): Don't register deleted functions with
5609         gdbarch.
5610
5611 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5612
5613         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5614         (tilegx_unwind_pc): Delete.
5615         (tilegx_unwind_dummy_id): Delete.
5616         (tilegx_gdbarch_init): Don't register deleted functions with
5617         gdbarch.
5618
5619 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5620
5621         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5622         (tic6x_dummy_id): Delete.
5623         (tic6x_gdbarch_init): Don't register deleted functions with
5624         gdbarch.
5625
5626 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5627
5628         * sparc-tdep.c (sparc_unwind_pc): Delete.
5629         (sparc32_gdbarch_init): Don't register deleted function with
5630         gdbarch.
5631
5632 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5633
5634         * sh-tdep.c (sh_unwind_sp): Delete.
5635         (sh_unwind_pc): Delete.
5636         (sh_dummy_id): Delete.
5637         (sh_gdbarch_init): Don't register deleted functions with
5638         gdbarch.
5639
5640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5641
5642         * score-tdep.c (score_unwind_sp): Delete.
5643         (score_unwind_pc): Delete.
5644         (score_dummy_id): Delete.
5645         (score_gdbarch_init): Don't register deleted functions with
5646         gdbarch.
5647
5648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5649
5650         * rx-tdep.c (rx_unwind_pc): Delete.
5651         (rx_unwind_sp): Delete.
5652         (rx_dummy_id): Delete.
5653         (rx_gdbarch_init): Don't register deleted functions with
5654         gdbarch.  Update comment.
5655
5656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5657
5658         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5659         (rs6000_dummy_id): Delete.
5660         (rs6000_gdbarch_init): Don't register deleted functions with
5661         gdbarch.
5662
5663 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5664
5665         * or1k-tdep.c (or1k_dummy_id): Delete.
5666         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5667
5668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5669
5670         * nios2-tdep.c (nios2_dummy_id): Delete.
5671         (nios2_unwind_sp): Delete.
5672         (nios2_gdbarch_init): Don't register deleted functions with
5673         gdbarch.
5674
5675 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5676
5677         * nds32-tdep.c (nds32_dummy_id): Delete.
5678         (nds32_unwind_pc): Delete.
5679         (nds32_unwind_sp): Delete.
5680         (nds32_gdbarch_init): Don't register deleted functions with
5681         gdbarch.
5682
5683 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5684
5685         * msp430-tdep.c (msp430_unwind_pc): Delete.
5686         (msp430_unwind_sp): Delete.
5687         (msp430_dummy_id): Delete.
5688         (msp430_gdbarch_init): Don't register deleted functions with
5689         gdbarch.
5690
5691 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5692
5693         * moxie-tdep.c (moxie_unwind_sp): Delete.
5694         (moxie_unwind_pc): Delete.
5695         (moxie_dummy_id): Delete.
5696         (moxie_gdbarch_init): Don't register deleted functions with
5697         gdbarch.
5698
5699 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5700
5701         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5702         (mn10300_unwind_pc): Delete.
5703         (mn10300_unwind_sp): Delete.
5704         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5705         mn10300_unwind_sp.
5706         (mn10300_frame_unwind_init): Don't register deleted functions with
5707         gdbarch.
5708
5709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5710
5711         * mep-tdep.c (mep_unwind_pc): Delete.
5712         (mep_unwind_sp): Delete.
5713         (mep_dummy_id): Delete.
5714         (mep_gdbarch_init): Don't register deleted functions with
5715         gdbarch.
5716
5717 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5718
5719         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5720         (m68hc11_unwind_sp): Delete.
5721         (m68hc11_gdbarch_init): Don't register deleted functions with
5722         gdbarch.
5723
5724 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5725
5726         * m32r-tdep.c (m32r_unwind_sp): Delete.
5727         (m32r_unwind_pc): Delete.
5728         (m32r_dummy_id): Delete.
5729         (m32r_gdbarch_init): Don't register deleted functions with
5730         gdbarch.
5731
5732 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5733
5734         * m32c-tdep.c (m32c_unwind_pc): Delete.
5735         (m32c_unwind_sp): Delete.
5736         (m32c_dummy_id): Delete.
5737         (m32c_gdbarch_init): Don't register deleted functions with
5738         gdbarch.
5739
5740 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5741
5742         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5743         (lm32_unwind_pc): Delete.
5744         (lm32_dummy_id): Delete.
5745         (lm32_gdbarch_init): Don't register deleted functions with
5746         gdbarch.
5747
5748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5749
5750         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5751         (iq2000_unwind_pc): Delete.
5752         (iq2000_dummy_id): Delete.
5753         (iq2000_gdbarch_init): Don't register deleted functions with
5754         gdbarch.
5755
5756 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5757
5758         * nds32-tdep.c (nds32_type_align): Delete.
5759         (nds32_push_dummy_call): Use type_align instead.
5760
5761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5762
5763         * arm-tdep.c (arm_type_align): Only handle vector override case.
5764         (arm_push_dummy_call): Use type_align.
5765         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5766
5767 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5768
5769         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5770         case.
5771         (pass_on_stack): Use type_align.
5772         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5773         function.
5774
5775 2019-04-23  Tom Tromey  <tromey@adacore.com>
5776
5777         * dwarf2read.c (line_header::file_name_at): Remove unused
5778         overload.
5779
5780 2019-04-23  Tom de Vries  <tdevries@suse.de>
5781
5782         PR gdb/24438
5783         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5784         invocation.
5785
5786
5787 2019-03-27  Ali Tamur  <tamur@google.com>
5788
5789         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5790         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5791         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5792         (dwarf_expr_context::get_addr_index): Likewise
5793         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5794         (symbol_needs_eval_context::get_addr_index): Likewise
5795         (disassemble_dwarf_expression): Add DW_OP_addrx
5796         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5797         (read_cutu_die_from_dwo): Update comment
5798         (skip_one_die): Add DW_FORM_addrx
5799         (read_attribute_value): Likewise
5800         (var_decode_location): Add DW_OP_addrx
5801         (dwarf2_const_value_attr): Add DW_FORM_addrx
5802         (dump_die_shallow): Likewise
5803         (dwarf2_fetch_constant_bytes): Likewise
5804         (decode_locdesc): Add DW_OP_addrx
5805         (skip_form_bytes): Add DW_FORM_addrx
5806
5807 2019-04-22  Ali Tamur  <tamur@google.com>
5808
5809         * MAINTAINERS (Write After Approval): Add self.
5810
5811 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5812
5813         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5814         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5815         (open_symbol_file_object): Likewise.
5816         (svr4_default_sos): Add info parameter.
5817         (svr4_read_so_list): Likewise.
5818         (svr4_current_sos_direct): Adjust functions calls to pass down
5819         info.
5820         (svr4_current_sos_1): Add info parameter.
5821         (svr4_current_sos): Call get_svr4_info, pass info down to
5822         svr4_current_sos_1.
5823         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5824         get_svr4_info.
5825         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5826         get_svr4_info.
5827         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5828         to get_svr4_info.
5829         (probes_table_remove_objfile_probes): Likewise.
5830         (register_solib_event_probe): Add info parameter.
5831         (solist_update_incremental): Pass info parameter down to
5832         svr4_read_so_list.
5833         (disable_probes_interface): Add info parameter.
5834         (svr4_handle_solib_event): Pass current_program_space to
5835         get_svr4_info.  Adjust disable_probes_interface cleanup.
5836         (svr4_create_probe_breakpoints): Add info parameter, pass it
5837         down to register_solib_event_probe.
5838         (svr4_create_solib_event_breakpoints): Add info parameter,
5839         pass it down to svr4_create_probe_breakpoints.
5840         (enable_break): Pass info down to
5841         svr4_create_solib_event_breakpoints.
5842         (svr4_solib_create_inferior_hook): Pass current_program_space to
5843         get_svr4_info.
5844         (svr4_clear_solib): Likewise.
5845
5846 2019-04-22  Pedro Alves  <palves@redhat.com>
5847
5848         * solib-svr4.c (svr4_free_objfile_observer): New.
5849         (probe_and_action::objfile): New field.
5850         (probes_table_htab_remove_objfile_probes)
5851         (probes_table_remove_objfile_probes): New functions.
5852         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5853         in the new probe_and_action.  Don't store the probe in 'lookup'.
5854         (svr4_create_probe_breakpoints): Pass objfile to
5855         register_solib_event_probe.
5856         (_initialize_svr4_solib): Register a free_objfile observer.
5857
5858 2019-04-19  Tom Tromey  <tom@tromey.com>
5859
5860         * common/queue.h: Remove.
5861
5862 2019-04-19  Tom Tromey  <tom@tromey.com>
5863
5864         * event-loop.c: Don't include "common/queue.h".
5865
5866 2019-04-19  Tom Tromey  <tom@tromey.com>
5867
5868         * remote.c (remote_target): Use delete.
5869         * remote-notif.h: Include <list>, not "common/queue.h".
5870         (notif_client_p): Remove typedef.
5871         (remote_notif_state): Add constructor, destructor, initializer.
5872         <notif_queue>: Now a std::list.
5873         (remote_notif_state_xfree): Don't declare.
5874         * remote-notif.c (remote_notif_process, handle_notification)
5875         (remote_notif_state_allocate): Update.
5876         (~remote_notif_state): Rename from remote_notif_state_xfree.
5877
5878 2019-04-19  Tom Tromey  <tom@tromey.com>
5879
5880         * symfile.c (reread_symbols): Update.
5881         * objfiles.c (objfile_register_static_link)
5882         (objfile_lookup_static_link): Update
5883         (~objfile) Don't delete static_links.
5884         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5885
5886 2019-04-19  Tom Tromey  <tom@tromey.com>
5887
5888         * type-stack.h (struct type_stack) <insert>: Constify string.
5889         * type-stack.c (type_stack::insert): Constify string.
5890         * gdbtypes.h (lookup_template_type): Update.
5891         (address_space_name_to_int): Update.
5892         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5893         const.
5894         (lookup_template_type): Make name const.
5895         * c-exp.y: Update rules.
5896         (lex_one_token, classify_name, classify_inner_name)
5897         (c_print_token): Update.
5898         * p-exp.y: Update rules.
5899         (yylex): Update.
5900         * f-exp.y: Update rules.
5901         (yylex): Update.
5902         * d-exp.y: Update rules.
5903         (lex_one_token, classify_name, classify_inner_name): Update.
5904         * parse.c (write_dollar_variable, copy_name): Return std::string.
5905         * parser-defs.h (copy_name): Change return type.
5906         * m2-exp.y: Update rules.
5907         (yylex): Update.
5908         * go-exp.y (lex_one_token): Update.
5909         Update rules.
5910         (classify_unsafe_function, classify_packaged_name)
5911         (classify_name, yylex): Update.
5912
5913 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5914
5915         * configure.ac: add --enable-source-highlight switch.
5916         * configure: Regenerate.
5917         * top.c (print_gdb_version): plumb --enable-source-highlight
5918         status to "show configuration".
5919
5920 2019-04-19  Tom Tromey  <tromey@adacore.com>
5921
5922         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5923         Check ADA_TYPE_P.
5924         (empty_record, ada_template_to_fixed_record_type_1)
5925         (template_to_static_fixed_type)
5926         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5927         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5928         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5929         macros.
5930
5931 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5932
5933         PR symtab/24423:
5934         * source.c (print_source_lines_base): Advance "iter" when a
5935         control character is seen.
5936
5937 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5938
5939         * inferior.h (struct infcall_suspend_state_deleter):
5940         Catch exception in destructor to avoid crash.
5941
5942 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5943
5944         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5945         close to the add_com "shell".
5946
5947 2019-04-18  Tom Tromey  <tromey@adacore.com>
5948
5949         * process-stratum-target.h (class process_stratum_target)
5950         <stratum>: Add "final".
5951
5952 2019-04-17  Tom Tromey  <tromey@adacore.com>
5953
5954         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5955         against nullptr before use.
5956
5957 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5958
5959         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5960
5961 2019-04-17  Jim Wilson  <jimw@sifive.com>
5962             Andrew Burgess  <andrew.burgess@embecosm.com>
5963
5964         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5965         code read might fail, assume 4-byte breakpoint in that case.
5966
5967 2019-04-15  Leszek Swirski  <leszeks@google.com>
5968
5969         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5970         rather than a hand-rolled POD check when checking for forced MEMORY
5971         classification.
5972
5973 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5974
5975         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5976         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5977         function.
5978         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5979         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5980         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5981         declaration.
5982
5983 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5984
5985         * aarch64-linux-nat.c
5986         (aarch64_linux_nat_target::thread_architecture): Add override.
5987         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5988         each VQ.
5989
5990 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5991
5992         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5993
5994 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5995
5996         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5997         target types of size 96-bits, add some additional comments, and
5998         check that the builtin type we found was the correct size.
5999
6000 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6001
6002         * utils.c (prompt_for_continue): Don't restore the styling at the
6003         end, as applied_style has the wrong value.  This fixes styling in
6004         long lists of file names that are interrupted by the "Continue?"
6005         prompt.
6006
6007 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6008
6009         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6010         * c-lang.c (c_language_defn): Likewise.
6011         (cplus_language_defn): Likewise.
6012         (asm_language_defn): Likewise.
6013         (minimal_language_defn): Likewise.
6014         * d-lang.c (d_language_defn): Likewise.
6015         * f-lang.c (f_language_defn): Likewise.
6016         * go-lang.c (go_language_defn): Likewise.
6017         * language.c (unknown_language_defn): Likewise.
6018         (auto_language_defn): Likewise.
6019         * language.h (struct language_defn): Remove la_magic field.
6020         (LANG_MAGIC): Delete.
6021         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6022         * objc-lang.c (objc_language_defn): Likewise.
6023         * opencl-lang.c (opencl_language_defn): Likewise.
6024         * p-lang.c (pascal_language_defn): Likewise.
6025         * rust-lang.c (rust_language_defn): Likewise.
6026
6027 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6028
6029         * riscv-tdep.c (riscv_type_align): New function.
6030         (riscv_type_alignment): Delete.
6031         (riscv_arg_location): Use 'type_align'.
6032         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6033
6034 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6035
6036         * gdbtypes.c (type_align): A struct with no non-static fields also
6037         has alignment of 1.
6038
6039 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6040
6041         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6042         component to 0.
6043         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6044         member.
6045         (riscv_struct_info::analyse): New implementation using new
6046         analyse_inner member function.
6047         (riscv_struct_info::field_offset): New member function.
6048         (riscv_struct_info::m_offsets): New member variable.
6049         (riscv_struct_info::analyse_inner): New private member function,
6050         takes the old implementation of riscv_struct_info::analyse but
6051         extended to track field offsets.
6052         (riscv_call_arg_struct): Update the struct folding special cases
6053         to handle cases where empty C++ structs, which are non-zero
6054         length, are found.
6055         (riscv_arg_location): Initialise the length of each location, a
6056         non-zero length now indicates the location is in use.
6057         (riscv_push_dummy_call): Allow for the first location having a
6058         non-zero offset when setting up arguments.
6059         (riscv_return_value): Likewise, but for return values.
6060
6061 2019-04-11  Tom Tromey  <tromey@adacore.com>
6062
6063         * utils.c (internal_vproblem): Make "msg" const.
6064
6065 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6066
6067         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6068         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6069         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6070         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6071
6072 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6073
6074         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6075         function.
6076         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6077         of amd64_collect_native_gregset.
6078         (amd64_linux_nat_target::store_registers): Likewise.
6079
6080 2019-04-10  Tom Tromey  <tom@tromey.com>
6081
6082         * symtab.c (lookup_global_symbol_from_objfile)
6083         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6084         * objfiles.h (class separate_debug_iterator): New.
6085         (class separate_debug_range): New.
6086         (struct objfile) <separate_debug_objfiles>: New method.
6087         (objfile_separate_debug_iterate): Don't declare.
6088         * objfiles.c (separate_debug_iterator::operator++): Rename from
6089         objfile_separate_debug_iterate.
6090         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6091         iterator.
6092         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6093         iterator.
6094
6095 2019-04-10  Tom Tromey  <tom@tromey.com>
6096
6097         * symfile.c (reread_symbols): Remove old comment.
6098         * objfiles.c (free_all_objfiles): Fix a typo.
6099
6100 2019-04-10  Tom Tromey  <tom@tromey.com>
6101
6102         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6103         * minsyms.c (lookup_minimal_symbol): Use foreach.
6104         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6105         (lookup_minimal_symbol_solib_trampoline): Likewise.
6106         * symfile.c (reread_symbols): Use foreach.
6107
6108 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6109             Tom Tromey  <tromey@adacore.com>
6110
6111         PR rust/24414:
6112         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6113         (rust_lex_int_test): Change "value" to be LONGEST.
6114         (rust_lex_tests): Add test for long integer literal.
6115
6116 2019-04-09  Tom Tromey  <tromey@adacore.com>
6117
6118         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6119         to bool.
6120         (extended_remote_target::attach): Update.
6121         (remote_target::remote_notice_new_inferior): Update.
6122         (remote_target::add_current_inferior_and_thread): Update.
6123         * inferior.c (exit_inferior_1): Use "false".
6124         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6125
6126 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6127
6128         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6129         the "start" command.
6130
6131 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6132
6133         * python/py-inferior.c (infpy_thread_from_thread_handle):
6134         Adjust comments to reflect renaming of thread_from_thread_handle
6135         to thread_from_handle.  Adjust keywords.  Fix type error message.
6136         (inferior_object_methods): Add thread_from_handle.  Retain
6137         thread_from_thread_handle, but mark it as deprecated.
6138
6139 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6140
6141         * gdbthread.h (find_thread_by_handle): Revise declaration.
6142         * thread.c (find_thread_by_handle): Likewise.  Adjust
6143         implementation too.
6144         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6145         support for buffer objects as handles.
6146
6147 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6148
6149         * python/py-infthread.c (thpy_thread_handle): New function.
6150         (thread_object_methods): Register thpy_thread_handle.
6151
6152 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6153
6154         * gdbthread.h (thread_to_thread_handle): Declare.
6155         * thread.c (gdbtypes.h): Include.
6156         (thread_to_thread_handle): New function.
6157
6158         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6159         (target_thread_info_to_thread_handle): Declare.
6160         * target.c (target_thread_info_to_thread_handle): New function.
6161         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6162         * target-delegates.c: Regenerate.
6163
6164         * linux-thread-db.c (class thread_db_target): Add method
6165         thread_info_to_thread_handle.
6166         (thread_db_target::thread_info_to_thread_handle): Define.
6167         * remote.c (class remote_target): Add new method
6168         thread_info_to_thread_handle.
6169         (remote_target::thread_info_to_thread_handle): Define.
6170
6171 2019-04-08  Pedro Alves  <palves@redhat.com>
6172
6173         * common/common-exceptions.c (throw_exception): Don't create
6174         named object to throw; throw directly.
6175         (throw_it): Likewise.  Don't initialize gdb_exception::message
6176         here, with new; pass FMT and AP to the ctor instead.
6177         * common/common-exceptions.h: Include <string>.
6178         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6179         const char *, va_list)): New ctor.  Use std::make_shared.
6180         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6181         errors)): Delete.
6182         (gdb_exception_error::gdb_exception_error(enum errors, const char
6183         *, va_list)): New.
6184         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6185         Add assertion.
6186         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6187         errors)): Delete.
6188         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6189         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6190         Add assertion.
6191
6192 2019-04-08  Tom Tromey  <tom@tromey.com>
6193
6194         * valops.c (value_rtti_indirect_type): Replace throw_exception
6195         with throw.
6196         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6197         with throw.
6198         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6199         throw.
6200         * target.c (target_translate_tls_address): Replace throw_exception
6201         with throw.
6202         * stack.c (frame_apply_command_count): Replace throw_exception
6203         with throw.
6204         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6205         throw.
6206         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6207         with throw.
6208         * rs6000-tdep.c (rs6000_frame_cache)
6209         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6210         * remote.c: Replace throw_exception with throw.
6211         * record-full.c (record_full_message, record_full_wait_1)
6212         (record_full_restore): Replace throw_exception with throw.
6213         * record-btrace.c:
6214         (get_thread_current_frame_id, record_btrace_start_replaying)
6215         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6216         (cmd_record_btrace_start): Replace throw_exception with throw.
6217         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6218         throw.
6219         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6220         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6221         * linespec.c:
6222         (find_linespec_symbols): Replace throw_exception with throw.
6223         * infrun.c (displaced_step_prepare, resume): Replace
6224         throw_exception with throw.
6225         * infcmd.c (post_create_inferior): Replace throw_exception with
6226         throw.
6227         * inf-loop.c (inferior_event_handler): Replace throw_exception
6228         with throw.
6229         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6230         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6231         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6232         (get_prev_frame_always, get_frame_pc_if_available)
6233         (get_frame_address_in_block_if_available, get_frame_language):
6234         Replace throw_exception with throw.
6235         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6236         throw_exception with throw.
6237         * eval.c (fetch_subexp_value, evaluate_var_value)
6238         (evaluate_funcall, evaluate_subexp_standard): Replace
6239         throw_exception with throw.
6240         * dwarf2loc.c (call_site_find_chain)
6241         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6242         Replace throw_exception with throw.
6243         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6244         with throw.
6245         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6246         throw.
6247         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6248         * completer.c (complete_line_internal): Replace throw_exception
6249         with throw.
6250         * compile/compile-object-run.c (compile_object_run): Replace
6251         throw_exception with throw.
6252         * cli/cli-script.c (process_next_line): Replace throw_exception
6253         with throw.
6254         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6255         (btrace_enable, btrace_maint_update_pt_packets): Replace
6256         throw_exception with throw.
6257         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6258         throw_exception with throw.
6259         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6260         throw_exception with throw.
6261         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6262         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6263         * aarch64-tdep.c (aarch64_make_prologue_cache)
6264         (aarch64_make_stub_cache): Replace throw_exception with throw.
6265
6266 2019-04-08  Tom Tromey  <tom@tromey.com>
6267
6268         * common/common-exceptions.c (throw_exception): Rename from
6269         throw_exception_cxx.  Remove old copy.  Make argument const.
6270         (throw_it): Create and throw exception objects directly.
6271         * common/common-exceptions.h (throw_exception): Make argument
6272         const.
6273         (struct gdb_exception_error): Add constructor.
6274         (struct gdb_exception_quit): Add constructor.
6275
6276 2019-04-08  Tom Tromey  <tom@tromey.com>
6277
6278         * common/common-exceptions.h (exception_rethrow): Don't declare.
6279         (TRY_SJLJ): Update comment.
6280         (TRY, CATCH, END_CATCH): Remove.
6281         * common/common-exceptions.c (exception_rethrow): Remove.
6282
6283 2019-04-08  Tom Tromey  <tom@tromey.com>
6284
6285         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6286         Remove.
6287         (gdb_exception_error): Rename from
6288         gdb_exception_RETURN_MASK_ERROR.
6289         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6290         (gdb_quit_bad_alloc): Update.
6291         * aarch64-tdep.c: Update.
6292         * ada-lang.c: Update.
6293         * ada-typeprint.c: Update.
6294         * ada-valprint.c: Update.
6295         * amd64-tdep.c: Update.
6296         * arch-utils.c: Update.
6297         * break-catch-throw.c: Update.
6298         * breakpoint.c: Update.
6299         * btrace.c: Update.
6300         * c-varobj.c: Update.
6301         * cli/cli-cmds.c: Update.
6302         * cli/cli-interp.c: Update.
6303         * cli/cli-script.c: Update.
6304         * common/common-exceptions.c: Update.
6305         * common/new-op.c: Update.
6306         * common/selftest.c: Update.
6307         * compile/compile-c-symbols.c: Update.
6308         * compile/compile-cplus-symbols.c: Update.
6309         * compile/compile-object-load.c: Update.
6310         * compile/compile-object-run.c: Update.
6311         * completer.c: Update.
6312         * corelow.c: Update.
6313         * cp-abi.c: Update.
6314         * cp-support.c: Update.
6315         * cp-valprint.c: Update.
6316         * darwin-nat.c: Update.
6317         * disasm-selftests.c: Update.
6318         * dtrace-probe.c: Update.
6319         * dwarf-index-cache.c: Update.
6320         * dwarf-index-write.c: Update.
6321         * dwarf2-frame-tailcall.c: Update.
6322         * dwarf2-frame.c: Update.
6323         * dwarf2loc.c: Update.
6324         * dwarf2read.c: Update.
6325         * eval.c: Update.
6326         * event-loop.c: Update.
6327         * event-top.c: Update.
6328         * exec.c: Update.
6329         * f-valprint.c: Update.
6330         * fbsd-tdep.c: Update.
6331         * frame-unwind.c: Update.
6332         * frame.c: Update.
6333         * gdbtypes.c: Update.
6334         * gnu-v3-abi.c: Update.
6335         * guile/guile-internal.h: Update.
6336         * guile/scm-block.c: Update.
6337         * guile/scm-breakpoint.c: Update.
6338         * guile/scm-cmd.c: Update.
6339         * guile/scm-disasm.c: Update.
6340         * guile/scm-frame.c: Update.
6341         * guile/scm-lazy-string.c: Update.
6342         * guile/scm-math.c: Update.
6343         * guile/scm-param.c: Update.
6344         * guile/scm-ports.c: Update.
6345         * guile/scm-pretty-print.c: Update.
6346         * guile/scm-symbol.c: Update.
6347         * guile/scm-symtab.c: Update.
6348         * guile/scm-type.c: Update.
6349         * guile/scm-value.c: Update.
6350         * i386-linux-tdep.c: Update.
6351         * i386-tdep.c: Update.
6352         * inf-loop.c: Update.
6353         * infcall.c: Update.
6354         * infcmd.c: Update.
6355         * infrun.c: Update.
6356         * jit.c: Update.
6357         * language.c: Update.
6358         * linespec.c: Update.
6359         * linux-fork.c: Update.
6360         * linux-nat.c: Update.
6361         * linux-tdep.c: Update.
6362         * linux-thread-db.c: Update.
6363         * main.c: Update.
6364         * mi/mi-cmd-break.c: Update.
6365         * mi/mi-cmd-stack.c: Update.
6366         * mi/mi-interp.c: Update.
6367         * mi/mi-main.c: Update.
6368         * objc-lang.c: Update.
6369         * p-valprint.c: Update.
6370         * parse.c: Update.
6371         * ppc-linux-tdep.c: Update.
6372         * printcmd.c: Update.
6373         * python/py-arch.c: Update.
6374         * python/py-breakpoint.c: Update.
6375         * python/py-cmd.c: Update.
6376         * python/py-finishbreakpoint.c: Update.
6377         * python/py-frame.c: Update.
6378         * python/py-framefilter.c: Update.
6379         * python/py-gdb-readline.c: Update.
6380         * python/py-inferior.c: Update.
6381         * python/py-infthread.c: Update.
6382         * python/py-lazy-string.c: Update.
6383         * python/py-linetable.c: Update.
6384         * python/py-objfile.c: Update.
6385         * python/py-param.c: Update.
6386         * python/py-prettyprint.c: Update.
6387         * python/py-progspace.c: Update.
6388         * python/py-record-btrace.c: Update.
6389         * python/py-record.c: Update.
6390         * python/py-symbol.c: Update.
6391         * python/py-type.c: Update.
6392         * python/py-unwind.c: Update.
6393         * python/py-utils.c: Update.
6394         * python/py-value.c: Update.
6395         * python/python.c: Update.
6396         * record-btrace.c: Update.
6397         * record-full.c: Update.
6398         * remote-fileio.c: Update.
6399         * remote.c: Update.
6400         * riscv-tdep.c: Update.
6401         * rs6000-aix-tdep.c: Update.
6402         * rs6000-tdep.c: Update.
6403         * rust-exp.y: Update.
6404         * rust-lang.c: Update.
6405         * s390-tdep.c: Update.
6406         * selftest-arch.c: Update.
6407         * solib-dsbt.c: Update.
6408         * solib-frv.c: Update.
6409         * solib-spu.c: Update.
6410         * solib-svr4.c: Update.
6411         * solib.c: Update.
6412         * sparc64-linux-tdep.c: Update.
6413         * stack.c: Update.
6414         * symfile-mem.c: Update.
6415         * symmisc.c: Update.
6416         * target.c: Update.
6417         * thread.c: Update.
6418         * top.c: Update.
6419         * tracefile-tfile.c: Update.
6420         * tui/tui.c: Update.
6421         * typeprint.c: Update.
6422         * unittests/cli-utils-selftests.c: Update.
6423         * unittests/parse-connection-spec-selftests.c: Update.
6424         * valops.c: Update.
6425         * valprint.c: Update.
6426         * value.c: Update.
6427         * varobj.c: Update.
6428         * windows-nat.c: Update.
6429         * x86-linux-nat.c: Update.
6430         * xml-support.c: Update.
6431
6432 2019-04-08  Tom Tromey  <tom@tromey.com>
6433
6434         * xml-support.c: Use C++ exception handling.
6435         * x86-linux-nat.c: Use C++ exception handling.
6436         * windows-nat.c: Use C++ exception handling.
6437         * varobj.c: Use C++ exception handling.
6438         * value.c: Use C++ exception handling.
6439         * valprint.c: Use C++ exception handling.
6440         * valops.c: Use C++ exception handling.
6441         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6442         handling.
6443         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6444         * typeprint.c: Use C++ exception handling.
6445         * tui/tui.c: Use C++ exception handling.
6446         * tracefile-tfile.c: Use C++ exception handling.
6447         * top.c: Use C++ exception handling.
6448         * thread.c: Use C++ exception handling.
6449         * target.c: Use C++ exception handling.
6450         * symmisc.c: Use C++ exception handling.
6451         * symfile-mem.c: Use C++ exception handling.
6452         * stack.c: Use C++ exception handling.
6453         * sparc64-linux-tdep.c: Use C++ exception handling.
6454         * solib.c: Use C++ exception handling.
6455         * solib-svr4.c: Use C++ exception handling.
6456         * solib-spu.c: Use C++ exception handling.
6457         * solib-frv.c: Use C++ exception handling.
6458         * solib-dsbt.c: Use C++ exception handling.
6459         * selftest-arch.c: Use C++ exception handling.
6460         * s390-tdep.c: Use C++ exception handling.
6461         * rust-lang.c: Use C++ exception handling.
6462         * rust-exp.y: Use C++ exception handling.
6463         * rs6000-tdep.c: Use C++ exception handling.
6464         * rs6000-aix-tdep.c: Use C++ exception handling.
6465         * riscv-tdep.c: Use C++ exception handling.
6466         * remote.c: Use C++ exception handling.
6467         * remote-fileio.c: Use C++ exception handling.
6468         * record-full.c: Use C++ exception handling.
6469         * record-btrace.c: Use C++ exception handling.
6470         * python/python.c: Use C++ exception handling.
6471         * python/py-value.c: Use C++ exception handling.
6472         * python/py-utils.c: Use C++ exception handling.
6473         * python/py-unwind.c: Use C++ exception handling.
6474         * python/py-type.c: Use C++ exception handling.
6475         * python/py-symbol.c: Use C++ exception handling.
6476         * python/py-record.c: Use C++ exception handling.
6477         * python/py-record-btrace.c: Use C++ exception handling.
6478         * python/py-progspace.c: Use C++ exception handling.
6479         * python/py-prettyprint.c: Use C++ exception handling.
6480         * python/py-param.c: Use C++ exception handling.
6481         * python/py-objfile.c: Use C++ exception handling.
6482         * python/py-linetable.c: Use C++ exception handling.
6483         * python/py-lazy-string.c: Use C++ exception handling.
6484         * python/py-infthread.c: Use C++ exception handling.
6485         * python/py-inferior.c: Use C++ exception handling.
6486         * python/py-gdb-readline.c: Use C++ exception handling.
6487         * python/py-framefilter.c: Use C++ exception handling.
6488         * python/py-frame.c: Use C++ exception handling.
6489         * python/py-finishbreakpoint.c: Use C++ exception handling.
6490         * python/py-cmd.c: Use C++ exception handling.
6491         * python/py-breakpoint.c: Use C++ exception handling.
6492         * python/py-arch.c: Use C++ exception handling.
6493         * printcmd.c: Use C++ exception handling.
6494         * ppc-linux-tdep.c: Use C++ exception handling.
6495         * parse.c: Use C++ exception handling.
6496         * p-valprint.c: Use C++ exception handling.
6497         * objc-lang.c: Use C++ exception handling.
6498         * mi/mi-main.c: Use C++ exception handling.
6499         * mi/mi-interp.c: Use C++ exception handling.
6500         * mi/mi-cmd-stack.c: Use C++ exception handling.
6501         * mi/mi-cmd-break.c: Use C++ exception handling.
6502         * main.c: Use C++ exception handling.
6503         * linux-thread-db.c: Use C++ exception handling.
6504         * linux-tdep.c: Use C++ exception handling.
6505         * linux-nat.c: Use C++ exception handling.
6506         * linux-fork.c: Use C++ exception handling.
6507         * linespec.c: Use C++ exception handling.
6508         * language.c: Use C++ exception handling.
6509         * jit.c: Use C++ exception handling.
6510         * infrun.c: Use C++ exception handling.
6511         * infcmd.c: Use C++ exception handling.
6512         * infcall.c: Use C++ exception handling.
6513         * inf-loop.c: Use C++ exception handling.
6514         * i386-tdep.c: Use C++ exception handling.
6515         * i386-linux-tdep.c: Use C++ exception handling.
6516         * guile/scm-value.c: Use C++ exception handling.
6517         * guile/scm-type.c: Use C++ exception handling.
6518         * guile/scm-symtab.c: Use C++ exception handling.
6519         * guile/scm-symbol.c: Use C++ exception handling.
6520         * guile/scm-pretty-print.c: Use C++ exception handling.
6521         * guile/scm-ports.c: Use C++ exception handling.
6522         * guile/scm-param.c: Use C++ exception handling.
6523         * guile/scm-math.c: Use C++ exception handling.
6524         * guile/scm-lazy-string.c: Use C++ exception handling.
6525         * guile/scm-frame.c: Use C++ exception handling.
6526         * guile/scm-disasm.c: Use C++ exception handling.
6527         * guile/scm-cmd.c: Use C++ exception handling.
6528         * guile/scm-breakpoint.c: Use C++ exception handling.
6529         * guile/scm-block.c: Use C++ exception handling.
6530         * guile/guile-internal.h: Use C++ exception handling.
6531         * gnu-v3-abi.c: Use C++ exception handling.
6532         * gdbtypes.c: Use C++ exception handling.
6533         * frame.c: Use C++ exception handling.
6534         * frame-unwind.c: Use C++ exception handling.
6535         * fbsd-tdep.c: Use C++ exception handling.
6536         * f-valprint.c: Use C++ exception handling.
6537         * exec.c: Use C++ exception handling.
6538         * event-top.c: Use C++ exception handling.
6539         * event-loop.c: Use C++ exception handling.
6540         * eval.c: Use C++ exception handling.
6541         * dwarf2read.c: Use C++ exception handling.
6542         * dwarf2loc.c: Use C++ exception handling.
6543         * dwarf2-frame.c: Use C++ exception handling.
6544         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6545         * dwarf-index-write.c: Use C++ exception handling.
6546         * dwarf-index-cache.c: Use C++ exception handling.
6547         * dtrace-probe.c: Use C++ exception handling.
6548         * disasm-selftests.c: Use C++ exception handling.
6549         * darwin-nat.c: Use C++ exception handling.
6550         * cp-valprint.c: Use C++ exception handling.
6551         * cp-support.c: Use C++ exception handling.
6552         * cp-abi.c: Use C++ exception handling.
6553         * corelow.c: Use C++ exception handling.
6554         * completer.c: Use C++ exception handling.
6555         * compile/compile-object-run.c: Use C++ exception handling.
6556         * compile/compile-object-load.c: Use C++ exception handling.
6557         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6558         * compile/compile-c-symbols.c: Use C++ exception handling.
6559         * common/selftest.c: Use C++ exception handling.
6560         * common/new-op.c: Use C++ exception handling.
6561         * cli/cli-script.c: Use C++ exception handling.
6562         * cli/cli-interp.c: Use C++ exception handling.
6563         * cli/cli-cmds.c: Use C++ exception handling.
6564         * c-varobj.c: Use C++ exception handling.
6565         * btrace.c: Use C++ exception handling.
6566         * breakpoint.c: Use C++ exception handling.
6567         * break-catch-throw.c: Use C++ exception handling.
6568         * arch-utils.c: Use C++ exception handling.
6569         * amd64-tdep.c: Use C++ exception handling.
6570         * ada-valprint.c: Use C++ exception handling.
6571         * ada-typeprint.c: Use C++ exception handling.
6572         * ada-lang.c: Use C++ exception handling.
6573         * aarch64-tdep.c: Use C++ exception handling.
6574
6575 2019-04-08  Tom Tromey  <tom@tromey.com>
6576
6577         * xml-support.c (gdb_xml_parser::parse): Update.
6578         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6579         * value.c (show_convenience): Update.
6580         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6581         (test_parse_flags_qcs): Update.
6582         * thread.c (thr_try_catch_cmd): Update.
6583         * target.c (target_translate_tls_address): Update.
6584         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6585         (info_frame_command_core, frame_apply_command_count): Update.
6586         * rust-exp.y (rust_lex_exception_test): Update.
6587         * riscv-tdep.c (riscv_print_one_register_info): Update.
6588         * remote.c (remote_target::enable_btrace): Update.
6589         * record-btrace.c (record_btrace_enable_warn): Update.
6590         * python/py-utils.c (gdbpy_convert_exception): Update.
6591         * printcmd.c (do_one_display, print_variable_and_value): Update.
6592         * mi/mi-main.c (mi_print_exception): Update.
6593         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6594         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6595         * linux-nat.c (linux_nat_target::attach): Update.
6596         * linux-fork.c (class scoped_switch_fork_info): Update.
6597         * infrun.c (displaced_step_prepare): Update.
6598         * infcall.c (call_function_by_hand_dummy): Update.
6599         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6600         * gnu-v3-abi.c (print_one_vtable): Update.
6601         * frame.c (get_prev_frame_always): Update.
6602         * f-valprint.c (info_common_command_for_block): Update.
6603         * exec.c (try_open_exec_file): Update.
6604         * exceptions.c (print_exception, exception_print)
6605         (exception_fprintf, exception_print_same): Update.
6606         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6607         * dwarf-index-cache.c (index_cache::store)
6608         (index_cache::lookup_gdb_index): Update.
6609         * darwin-nat.c (maybe_cache_shell): Update.
6610         * cp-valprint.c (cp_print_value_fields): Update.
6611         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6612         (gcc_cplus_symbol_address): Update.
6613         * compile/compile-c-symbols.c (gcc_convert_symbol)
6614         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6615         * common/selftest.c: Update.
6616         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6617         a std::string.
6618         (exception_try_scope_entry, exception_try_scope_exit): Don't
6619         declare.
6620         (struct exception_try_scope): Remove.
6621         (TRY): Don't use exception_try_scope.
6622         (struct gdb_exception): Add constructor, operator=.
6623         <what>: New method.
6624         (struct gdb_exception_RETURN_MASK_ALL)
6625         (struct gdb_exception_RETURN_MASK_ERROR)
6626         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6627         (struct gdb_quit_bad_alloc): Update.
6628         * common/common-exceptions.c (exception_none): Change
6629         initializer.
6630         (struct catcher) <state, exception>: Initialize inline.
6631         <prev>: Remove member.
6632         (current_catcher): Remove.
6633         (catchers): New global.
6634         (exceptions_state_mc_init): Simplify.
6635         (catcher_pop): Remove.
6636         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6637         (try_scope_depth, exception_try_scope_entry)
6638         (exception_try_scope_exit): Remove.
6639         (throw_exception_sjlj): Update.
6640         (exception_messages, exception_messages_size): Remove.
6641         (throw_it): Simplify.
6642         (gdb_exception_sliced_copy): Remove.
6643         (throw_exception_cxx): Update.
6644         * cli/cli-script.c (script_from_file): Update.
6645         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6646         Update.
6647         * ada-valprint.c (ada_val_print): Update.
6648         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6649         (create_excep_cond_exprs): Update.
6650
6651 2019-04-08  Tom Tromey  <tom@tromey.com>
6652
6653         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6654         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6655         (TRY, CATCH, END_CATCH): Remove some definitions.
6656         * common/common-exceptions.c: Don't use GDB_XCPT.
6657         (catcher_list_size): Remove.
6658         (throw_exception, throw_it): Simplify.
6659
6660 2019-04-05  Tom Tromey  <tom@tromey.com>
6661
6662         Revert the header-sorting patch.
6663         * ft32-tdep.c: Revert.
6664         * frv-tdep.c: Revert.
6665         * frv-linux-tdep.c: Revert.
6666         * frame.c: Revert.
6667         * frame-unwind.c: Revert.
6668         * frame-base.c: Revert.
6669         * fork-child.c: Revert.
6670         * findvar.c: Revert.
6671         * findcmd.c: Revert.
6672         * filesystem.c: Revert.
6673         * filename-seen-cache.h: Revert.
6674         * filename-seen-cache.c: Revert.
6675         * fbsd-tdep.c: Revert.
6676         * fbsd-nat.h: Revert.
6677         * fbsd-nat.c: Revert.
6678         * f-valprint.c: Revert.
6679         * f-typeprint.c: Revert.
6680         * f-lang.c: Revert.
6681         * extension.h: Revert.
6682         * extension.c: Revert.
6683         * extension-priv.h: Revert.
6684         * expprint.c: Revert.
6685         * exec.h: Revert.
6686         * exec.c: Revert.
6687         * exceptions.c: Revert.
6688         * event-top.c: Revert.
6689         * event-loop.c: Revert.
6690         * eval.c: Revert.
6691         * elfread.c: Revert.
6692         * dwarf2read.h: Revert.
6693         * dwarf2read.c: Revert.
6694         * dwarf2loc.c: Revert.
6695         * dwarf2expr.h: Revert.
6696         * dwarf2expr.c: Revert.
6697         * dwarf2-frame.c: Revert.
6698         * dwarf2-frame-tailcall.c: Revert.
6699         * dwarf-index-write.h: Revert.
6700         * dwarf-index-write.c: Revert.
6701         * dwarf-index-common.c: Revert.
6702         * dwarf-index-cache.h: Revert.
6703         * dwarf-index-cache.c: Revert.
6704         * dummy-frame.c: Revert.
6705         * dtrace-probe.c: Revert.
6706         * disasm.h: Revert.
6707         * disasm.c: Revert.
6708         * disasm-selftests.c: Revert.
6709         * dictionary.c: Revert.
6710         * dicos-tdep.c: Revert.
6711         * demangle.c: Revert.
6712         * dcache.h: Revert.
6713         * dcache.c: Revert.
6714         * darwin-nat.h: Revert.
6715         * darwin-nat.c: Revert.
6716         * darwin-nat-info.c: Revert.
6717         * d-valprint.c: Revert.
6718         * d-namespace.c: Revert.
6719         * d-lang.c: Revert.
6720         * ctf.c: Revert.
6721         * csky-tdep.c: Revert.
6722         * csky-linux-tdep.c: Revert.
6723         * cris-tdep.c: Revert.
6724         * cris-linux-tdep.c: Revert.
6725         * cp-valprint.c: Revert.
6726         * cp-support.c: Revert.
6727         * cp-namespace.c: Revert.
6728         * cp-abi.c: Revert.
6729         * corelow.c: Revert.
6730         * corefile.c: Revert.
6731         * continuations.c: Revert.
6732         * completer.h: Revert.
6733         * completer.c: Revert.
6734         * complaints.c: Revert.
6735         * coffread.c: Revert.
6736         * coff-pe-read.c: Revert.
6737         * cli-out.h: Revert.
6738         * cli-out.c: Revert.
6739         * charset.c: Revert.
6740         * c-varobj.c: Revert.
6741         * c-valprint.c: Revert.
6742         * c-typeprint.c: Revert.
6743         * c-lang.c: Revert.
6744         * buildsym.c: Revert.
6745         * buildsym-legacy.c: Revert.
6746         * build-id.h: Revert.
6747         * build-id.c: Revert.
6748         * btrace.c: Revert.
6749         * bsd-uthread.c: Revert.
6750         * breakpoint.h: Revert.
6751         * breakpoint.c: Revert.
6752         * break-catch-throw.c: Revert.
6753         * break-catch-syscall.c: Revert.
6754         * break-catch-sig.c: Revert.
6755         * blockframe.c: Revert.
6756         * block.c: Revert.
6757         * bfin-tdep.c: Revert.
6758         * bfin-linux-tdep.c: Revert.
6759         * bfd-target.c: Revert.
6760         * bcache.c: Revert.
6761         * ax-general.c: Revert.
6762         * ax-gdb.h: Revert.
6763         * ax-gdb.c: Revert.
6764         * avr-tdep.c: Revert.
6765         * auxv.c: Revert.
6766         * auto-load.c: Revert.
6767         * arm-wince-tdep.c: Revert.
6768         * arm-tdep.c: Revert.
6769         * arm-symbian-tdep.c: Revert.
6770         * arm-pikeos-tdep.c: Revert.
6771         * arm-obsd-tdep.c: Revert.
6772         * arm-nbsd-tdep.c: Revert.
6773         * arm-nbsd-nat.c: Revert.
6774         * arm-linux-tdep.c: Revert.
6775         * arm-linux-nat.c: Revert.
6776         * arm-fbsd-tdep.c: Revert.
6777         * arm-fbsd-nat.c: Revert.
6778         * arm-bsd-tdep.c: Revert.
6779         * arch-utils.c: Revert.
6780         * arc-tdep.c: Revert.
6781         * arc-newlib-tdep.c: Revert.
6782         * annotate.h: Revert.
6783         * annotate.c: Revert.
6784         * amd64-windows-tdep.c: Revert.
6785         * amd64-windows-nat.c: Revert.
6786         * amd64-tdep.c: Revert.
6787         * amd64-sol2-tdep.c: Revert.
6788         * amd64-obsd-tdep.c: Revert.
6789         * amd64-obsd-nat.c: Revert.
6790         * amd64-nbsd-tdep.c: Revert.
6791         * amd64-nbsd-nat.c: Revert.
6792         * amd64-nat.c: Revert.
6793         * amd64-linux-tdep.c: Revert.
6794         * amd64-linux-nat.c: Revert.
6795         * amd64-fbsd-tdep.c: Revert.
6796         * amd64-fbsd-nat.c: Revert.
6797         * amd64-dicos-tdep.c: Revert.
6798         * amd64-darwin-tdep.c: Revert.
6799         * amd64-bsd-nat.c: Revert.
6800         * alpha-tdep.c: Revert.
6801         * alpha-obsd-tdep.c: Revert.
6802         * alpha-nbsd-tdep.c: Revert.
6803         * alpha-mdebug-tdep.c: Revert.
6804         * alpha-linux-tdep.c: Revert.
6805         * alpha-linux-nat.c: Revert.
6806         * alpha-bsd-tdep.c: Revert.
6807         * alpha-bsd-nat.c: Revert.
6808         * aix-thread.c: Revert.
6809         * agent.c: Revert.
6810         * addrmap.c: Revert.
6811         * ada-varobj.c: Revert.
6812         * ada-valprint.c: Revert.
6813         * ada-typeprint.c: Revert.
6814         * ada-tasks.c: Revert.
6815         * ada-lang.c: Revert.
6816         * aarch64-tdep.c: Revert.
6817         * aarch64-ravenscar-thread.c: Revert.
6818         * aarch64-newlib-tdep.c: Revert.
6819         * aarch64-linux-tdep.c: Revert.
6820         * aarch64-linux-nat.c: Revert.
6821         * aarch64-fbsd-tdep.c: Revert.
6822         * aarch64-fbsd-nat.c: Revert.
6823         * aarch32-linux-nat.c: Revert.
6824
6825 2019-04-05  Tom Tromey  <tom@tromey.com>
6826
6827         * ft32-tdep.c: Sort headers.
6828         * frv-tdep.c: Sort headers.
6829         * frv-linux-tdep.c: Sort headers.
6830         * frame.c: Sort headers.
6831         * frame-unwind.c: Sort headers.
6832         * frame-base.c: Sort headers.
6833         * fork-child.c: Sort headers.
6834         * findvar.c: Sort headers.
6835         * findcmd.c: Sort headers.
6836         * filesystem.c: Sort headers.
6837         * filename-seen-cache.h: Sort headers.
6838         * filename-seen-cache.c: Sort headers.
6839         * fbsd-tdep.c: Sort headers.
6840         * fbsd-nat.h: Sort headers.
6841         * fbsd-nat.c: Sort headers.
6842         * f-valprint.c: Sort headers.
6843         * f-typeprint.c: Sort headers.
6844         * f-lang.c: Sort headers.
6845         * extension.h: Sort headers.
6846         * extension.c: Sort headers.
6847         * extension-priv.h: Sort headers.
6848         * expprint.c: Sort headers.
6849         * exec.h: Sort headers.
6850         * exec.c: Sort headers.
6851         * exceptions.c: Sort headers.
6852         * event-top.c: Sort headers.
6853         * event-loop.c: Sort headers.
6854         * eval.c: Sort headers.
6855         * elfread.c: Sort headers.
6856         * dwarf2read.h: Sort headers.
6857         * dwarf2read.c: Sort headers.
6858         * dwarf2loc.c: Sort headers.
6859         * dwarf2expr.h: Sort headers.
6860         * dwarf2expr.c: Sort headers.
6861         * dwarf2-frame.c: Sort headers.
6862         * dwarf2-frame-tailcall.c: Sort headers.
6863         * dwarf-index-write.h: Sort headers.
6864         * dwarf-index-write.c: Sort headers.
6865         * dwarf-index-common.c: Sort headers.
6866         * dwarf-index-cache.h: Sort headers.
6867         * dwarf-index-cache.c: Sort headers.
6868         * dummy-frame.c: Sort headers.
6869         * dtrace-probe.c: Sort headers.
6870         * disasm.h: Sort headers.
6871         * disasm.c: Sort headers.
6872         * disasm-selftests.c: Sort headers.
6873         * dictionary.c: Sort headers.
6874         * dicos-tdep.c: Sort headers.
6875         * demangle.c: Sort headers.
6876         * dcache.h: Sort headers.
6877         * dcache.c: Sort headers.
6878         * darwin-nat.h: Sort headers.
6879         * darwin-nat.c: Sort headers.
6880         * darwin-nat-info.c: Sort headers.
6881         * d-valprint.c: Sort headers.
6882         * d-namespace.c: Sort headers.
6883         * d-lang.c: Sort headers.
6884         * ctf.c: Sort headers.
6885         * csky-tdep.c: Sort headers.
6886         * csky-linux-tdep.c: Sort headers.
6887         * cris-tdep.c: Sort headers.
6888         * cris-linux-tdep.c: Sort headers.
6889         * cp-valprint.c: Sort headers.
6890         * cp-support.c: Sort headers.
6891         * cp-namespace.c: Sort headers.
6892         * cp-abi.c: Sort headers.
6893         * corelow.c: Sort headers.
6894         * corefile.c: Sort headers.
6895         * continuations.c: Sort headers.
6896         * completer.h: Sort headers.
6897         * completer.c: Sort headers.
6898         * complaints.c: Sort headers.
6899         * coffread.c: Sort headers.
6900         * coff-pe-read.c: Sort headers.
6901         * cli-out.h: Sort headers.
6902         * cli-out.c: Sort headers.
6903         * charset.c: Sort headers.
6904         * c-varobj.c: Sort headers.
6905         * c-valprint.c: Sort headers.
6906         * c-typeprint.c: Sort headers.
6907         * c-lang.c: Sort headers.
6908         * buildsym.c: Sort headers.
6909         * buildsym-legacy.c: Sort headers.
6910         * build-id.h: Sort headers.
6911         * build-id.c: Sort headers.
6912         * btrace.c: Sort headers.
6913         * bsd-uthread.c: Sort headers.
6914         * breakpoint.h: Sort headers.
6915         * breakpoint.c: Sort headers.
6916         * break-catch-throw.c: Sort headers.
6917         * break-catch-syscall.c: Sort headers.
6918         * break-catch-sig.c: Sort headers.
6919         * blockframe.c: Sort headers.
6920         * block.c: Sort headers.
6921         * bfin-tdep.c: Sort headers.
6922         * bfin-linux-tdep.c: Sort headers.
6923         * bfd-target.c: Sort headers.
6924         * bcache.c: Sort headers.
6925         * ax-general.c: Sort headers.
6926         * ax-gdb.h: Sort headers.
6927         * ax-gdb.c: Sort headers.
6928         * avr-tdep.c: Sort headers.
6929         * auxv.c: Sort headers.
6930         * auto-load.c: Sort headers.
6931         * arm-wince-tdep.c: Sort headers.
6932         * arm-tdep.c: Sort headers.
6933         * arm-symbian-tdep.c: Sort headers.
6934         * arm-pikeos-tdep.c: Sort headers.
6935         * arm-obsd-tdep.c: Sort headers.
6936         * arm-nbsd-tdep.c: Sort headers.
6937         * arm-nbsd-nat.c: Sort headers.
6938         * arm-linux-tdep.c: Sort headers.
6939         * arm-linux-nat.c: Sort headers.
6940         * arm-fbsd-tdep.c: Sort headers.
6941         * arm-fbsd-nat.c: Sort headers.
6942         * arm-bsd-tdep.c: Sort headers.
6943         * arch-utils.c: Sort headers.
6944         * arc-tdep.c: Sort headers.
6945         * arc-newlib-tdep.c: Sort headers.
6946         * annotate.h: Sort headers.
6947         * annotate.c: Sort headers.
6948         * amd64-windows-tdep.c: Sort headers.
6949         * amd64-windows-nat.c: Sort headers.
6950         * amd64-tdep.c: Sort headers.
6951         * amd64-sol2-tdep.c: Sort headers.
6952         * amd64-obsd-tdep.c: Sort headers.
6953         * amd64-obsd-nat.c: Sort headers.
6954         * amd64-nbsd-tdep.c: Sort headers.
6955         * amd64-nbsd-nat.c: Sort headers.
6956         * amd64-nat.c: Sort headers.
6957         * amd64-linux-tdep.c: Sort headers.
6958         * amd64-linux-nat.c: Sort headers.
6959         * amd64-fbsd-tdep.c: Sort headers.
6960         * amd64-fbsd-nat.c: Sort headers.
6961         * amd64-dicos-tdep.c: Sort headers.
6962         * amd64-darwin-tdep.c: Sort headers.
6963         * amd64-bsd-nat.c: Sort headers.
6964         * alpha-tdep.c: Sort headers.
6965         * alpha-obsd-tdep.c: Sort headers.
6966         * alpha-nbsd-tdep.c: Sort headers.
6967         * alpha-mdebug-tdep.c: Sort headers.
6968         * alpha-linux-tdep.c: Sort headers.
6969         * alpha-linux-nat.c: Sort headers.
6970         * alpha-bsd-tdep.c: Sort headers.
6971         * alpha-bsd-nat.c: Sort headers.
6972         * aix-thread.c: Sort headers.
6973         * agent.c: Sort headers.
6974         * addrmap.c: Sort headers.
6975         * ada-varobj.c: Sort headers.
6976         * ada-valprint.c: Sort headers.
6977         * ada-typeprint.c: Sort headers.
6978         * ada-tasks.c: Sort headers.
6979         * ada-lang.c: Sort headers.
6980         * aarch64-tdep.c: Sort headers.
6981         * aarch64-ravenscar-thread.c: Sort headers.
6982         * aarch64-newlib-tdep.c: Sort headers.
6983         * aarch64-linux-tdep.c: Sort headers.
6984         * aarch64-linux-nat.c: Sort headers.
6985         * aarch64-fbsd-tdep.c: Sort headers.
6986         * aarch64-fbsd-nat.c: Sort headers.
6987         * aarch32-linux-nat.c: Sort headers.
6988
6989 2019-04-04  Tom Tromey  <tom@tromey.com>
6990
6991         * varobj.c (varobj_create): Update.
6992         * rust-exp.y (struct rust_parser) <update_innermost_block,
6993         lookup_symbol>: New methods.
6994         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6995         Rename.
6996         (rust_parser::rust_lookup_type)
6997         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6998         * printcmd.c (display_command, do_one_display): Update.
6999         * parser-defs.h (struct parser_state) <parser_state>: Add
7000         "tracker" parameter.
7001         (block_tracker): New member.
7002         (class innermost_block_tracker) <innermost_block_tracker>: Add
7003         "types" parameter.
7004         <reset>: Remove method.
7005         (innermost_block): Don't declare.
7006         (null_post_parser): Update.
7007         * parse.c (innermost_block): Remove global.
7008         (write_dollar_variable): Update.
7009         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7010         Remove "tracker_types" parameter.
7011         (parse_expression): Add "tracker" parameter.
7012         (parse_expression_for_completion): Update.
7013         (null_post_parser): Add "tracker" parameter.
7014         * p-exp.y: Update rules.
7015         * m2-exp.y: Update rules.
7016         * language.h (struct language_defn) <la_post_parser>: Add
7017         "tracker" parameter.
7018         * go-exp.y: Update rules.
7019         * f-exp.y: Update rules.
7020         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7021         parameter.
7022         * d-exp.y: Update rules.
7023         * c-exp.y: Update rules.
7024         * breakpoint.c (set_breakpoint_condition): Create an
7025         innermost_block_tracker.
7026         (watch_command_1): Likewise.
7027         * ada-lang.c (resolve): Add "tracker" parameter.
7028         (resolve_subexp): Likewise.
7029         * ada-exp.y (write_var_from_sym): Update.
7030
7031 2019-04-04  Tom Tromey  <tom@tromey.com>
7032
7033         * type-stack.h: New file.
7034         * type-stack.c: New file.
7035         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7036         type-stack.h.
7037         (insert_into_type_stack, insert_type, push_type, push_type_int)
7038         (insert_type_address_space, pop_type, pop_type_int)
7039         (pop_typelist, pop_type_stack, append_type_stack)
7040         (push_type_stack, get_type_stack, push_typelist)
7041         (follow_type_instance_flags, follow_types): Don't declare.
7042         * parse.c (type_stack): Remove global.
7043         (parse_exp_in_context): Update.
7044         (insert_into_type_stack, insert_type, push_type, push_type_int)
7045         (insert_type_address_space, pop_type, pop_type_int)
7046         (pop_typelist, pop_type_stack, append_type_stack)
7047         (push_type_stack, get_type_stack, push_typelist)
7048         (follow_type_instance_flags, follow_types): Remove (moved to
7049         type-stack.c).
7050         * f-exp.y (type_stack): New global.
7051         Update rules.
7052         (push_kind_type, f_parse): Update.
7053         * d-exp.y (type_stack): New global.
7054         Update rules.
7055         (d_parse): Update.
7056         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7057         Update rules.
7058         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7059         (HFILES_NO_SRCDIR): Add type-stack.h.
7060
7061 2019-04-04  Tom Tromey  <tom@tromey.com>
7062
7063         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7064         (rust_parser::convert_ast_to_expression, rust_parse)
7065         (rust_lex_test_completion, rust_lex_tests): Update.
7066         * parser-defs.h (struct expr_completion_state): New.
7067         (struct parser_state) <parser_state>: Add completion parameter.
7068         <mark_struct_expression, mark_completion_tag>: New methods.
7069         <parse_completion, m_completion_state>: New members.
7070         (prefixify_expression, null_post_parser): Update.
7071         (mark_struct_expression, mark_completion_tag): Don't declare.
7072         * parse.c (parse_completion, expout_last_struct)
7073         (expout_tag_completion_type, expout_completion_name): Remove
7074         globals.
7075         (parser_state::mark_struct_expression)
7076         (parser_state::mark_completion_tag): Now methods.
7077         (prefixify_expression): Add last_struct parameter.
7078         (prefixify_subexp): Likewise.
7079         (parse_exp_1): Update.
7080         (parse_exp_in_context): Add cstate parameter.  Update.
7081         (parse_expression_for_completion): Create an
7082         expr_completion_state.
7083         (null_post_parser): Add "completion" parameter.
7084         * p-exp.y: Update rules.
7085         (yylex): Update.
7086         * language.h (struct language_defn) <la_post_parser>: Add
7087         "completing" parameter.
7088         * go-exp.y: Update rules.
7089         (lex_one_token): Update.
7090         * expression.h (parse_completion): Don't declare.
7091         * d-exp.y: Update rules.
7092         (lex_one_token): Update rules.
7093         * c-exp.y: Update rules.
7094         (lex_one_token): Update.
7095         * ada-lang.c (resolve): Add "parse_completion" parameter.
7096         (resolve_subexp): Likewise.
7097         (ada_resolve_function): Likewise.
7098
7099 2019-04-04  Tom Tromey  <tom@tromey.com>
7100
7101         * parser-defs.h (struct parser_state) <start_arglist,
7102         end_arglist>: New methods.
7103         <arglist_len, m_funcall_chain>: New members.
7104         (arglist_len, start_arglist, end_arglist): Don't declare.
7105         * parse.c (arglist_len, funcall_chain): Remove global.
7106         (start_arglist, end_arglist): Remove functions.
7107         (parse_exp_in_context): Update.
7108         * p-exp.y: Update rules.
7109         * m2-exp.y: Update rules.
7110         * go-exp.y: Update rules.
7111         * f-exp.y: Update rules.
7112         * d-exp.y: Update rules.
7113         * c-exp.y: Update rules.
7114
7115 2019-04-04  Tom Tromey  <tom@tromey.com>
7116
7117         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7118         lex_operator, push_back>: New methods.
7119         Update all rules.
7120         (rust_parser::lex_hex, lex_escape): Rename and update.
7121         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7122         (rust_parser::lex_operator): Rename and update.
7123         (rust_parser::lex_number, rustyylex, rustyyerror)
7124         (rust_lex_test_init, rust_lex_test_sequence)
7125         (rust_lex_test_push_back, rust_lex_tests): Update.
7126         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7127         parameter.
7128         <lexptr, prev_lexptr>: New members.
7129         (lexptr, prev_lexptr): Don't declare.
7130         * parse.c (lexptr, prev_lexptr): Remove globals.
7131         (parse_exp_in_context): Update.
7132         * p-exp.y (yylex, yyerror): Update.
7133         * m2-exp.y (parse_number, yylex, yyerror): Update.
7134         * go-exp.y (lex_one_token, yyerror): Update.
7135         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7136         * d-exp.y (lex_one_token, yyerror): Update.
7137         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7138         (lex_one_token, yyerror): Update.
7139         * ada-lex.l (YY_INPUT): Update.
7140         (rewind_to_char): Update.
7141         * ada-exp.y (yyerror): Update.
7142
7143 2019-04-04  Tom Tromey  <tom@tromey.com>
7144
7145         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7146         * parser-defs.h (struct parser_state) <parser_state>: Add new
7147         parameter.
7148         <comma_terminates>: New member.
7149         (comma_terminates): Don't declare global.
7150         * parse.c (comma_terminates): Remove global.
7151         (parse_exp_in_context): Update.
7152         * p-exp.y (yylex): Update.
7153         * m2-exp.y (yylex): Update.
7154         * go-exp.y (lex_one_token): Update.
7155         * f-exp.y (yylex): Update.
7156         * d-exp.y (lex_one_token): Update.
7157         * c-exp.y (lex_one_token): Update.
7158         * ada-lex.l: Update.
7159
7160 2019-04-04  Tom Tromey  <tom@tromey.com>
7161
7162         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7163         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7164         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7165         * parser-defs.h (paren_depth): Don't declare.
7166         * parse.c (paren_depth): Remove global.
7167         (parse_exp_in_context): Update.
7168         * p-exp.y (paren_depth): New global.
7169         (pascal_parse): Initialize it.
7170         * m2-exp.y (paren_depth): New global.
7171         (m2_parse): Initialize it.
7172         * go-exp.y (paren_depth): New global.
7173         (go_parse): Initialize it.
7174         * f-exp.y (paren_depth): New global.
7175         (f_parse): Initialize it.
7176         * d-exp.y (paren_depth): New global.
7177         (d_parse): Initialize it.
7178         * c-exp.y (paren_depth): New global.
7179         (c_parse): Initialize it.
7180         * ada-lex.l (paren_depth): New global.
7181         (lexer_init): Initialize it.
7182
7183 2019-04-04  Tom Tromey  <tom@tromey.com>
7184
7185         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7186         (rust_parser::convert_ast_to_type)
7187         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7188         * parser-defs.h (struct parser_state) <parser_state>: Add
7189         parameters.  Initialize new members.
7190         <expression_context_block, expression_context_pc>: New members.
7191         * parse.c (expression_context_block, expression_context_pc):
7192         Remove globals.
7193         (parse_exp_in_context): Update.
7194         * p-exp.y: Update all rules.
7195         (yylex): Update.
7196         * m2-exp.y: Update all rules.
7197         (yylex): Update.
7198         * go-exp.y (yylex): Update.
7199         * f-exp.y (yylex): Update.
7200         * d-exp.y: Update all rules.
7201         (yylex): Update.
7202         * c-exp.y: Update all rules.
7203         (lex_one_token, classify_name, yylex, c_parse): Update.
7204         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7205
7206 2019-04-04  Tom Tromey  <tom@tromey.com>
7207
7208         * gdbarch.h, gdbarch.c: Rebuild.
7209         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7210         * stap-probe.h:
7211         (struct stap_parse_info): Replace "parser_state" with
7212         "expr_builder".
7213         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7214         (parser_state): New class.
7215         * parse.c (expr_builder): Rename.
7216         (expr_builder::release): Rename.
7217         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7218         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7219         (write_exp_elt_longcst, write_exp_elt_floatcst)
7220         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7221         (write_exp_string_vector, write_exp_bitstring)
7222         (write_exp_msymbol, mark_struct_expression)
7223         (write_dollar_variable)
7224         (insert_type_address_space, increase_expout_size): Replace
7225         "parser_state" with "expr_builder".
7226         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7227         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7228         "parser_state" with "expr_builder".
7229
7230 2019-04-04  Tom Tromey  <tom@tromey.com>
7231
7232         * rust-exp.y: Replace "parse_language" with method call.
7233         * p-exp.y:
7234         (yylex): Replace "parse_language" with method call.
7235         * m2-exp.y:
7236         (yylex): Replace "parse_language" with method call.
7237         * go-exp.y (classify_name): Replace "parse_language" with method
7238         call.
7239         * f-exp.y (yylex): Replace "parse_language" with method call.
7240         * d-exp.y (lex_one_token): Replace "parse_language" with method
7241         call.
7242         * c-exp.y:
7243         (lex_one_token, classify_name, yylex): Replace "parse_language"
7244         with method call.
7245         * ada-exp.y (find_primitive_type, type_char)
7246         (type_system_address): Replace "parse_language" with method call.
7247
7248 2019-04-04  Tom Tromey  <tom@tromey.com>
7249
7250         * rust-exp.y: Replace "parse_gdbarch" with method call.
7251         * parse.c (write_dollar_variable, insert_type_address_space):
7252         Replace "parse_gdbarch" with method call.
7253         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7254         call.
7255         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7256         call.
7257         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7258         "parse_gdbarch" with method call.
7259         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7260         with method call.
7261         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7262         "parse_gdbarch" with method call.
7263         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7264         "parse_gdbarch" with method call.
7265         * c-exp.y (parse_type, parse_number, classify_name): Replace
7266         "parse_gdbarch" with method call.
7267         * ada-lex.l: Replace "parse_gdbarch" with method call.
7268         * ada-exp.y (parse_type, find_primitive_type, type_char)
7269         (type_system_address): Replace "parse_gdbarch" with method call.
7270
7271 2019-04-04  Tom Tromey  <tom@tromey.com>
7272
7273         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7274         * stap-probe.c (stap_parse_argument): Update.
7275         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7276         initial_size parameter.
7277         * rust-exp.y (rust_lex_tests): Update.
7278         * parse.c (parser_state): Update.
7279         (parse_exp_in_context): Update.
7280         * parser-defs.h (struct parser_state) <parser_state>: Remove
7281         "initial_size" parameter.
7282
7283 2019-04-04  Tom Tromey  <tom@tromey.com>
7284
7285         * parser-defs.h (increase_expout_size): Don't declare.
7286         * parse.c (increase_expout_size): Now static.
7287
7288 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7289
7290         * gnu-nat.c (gnu_nat_target::wait): Fix
7291         target_waitstatus_to_string call.
7292
7293 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7294
7295         * eval.c (evaluate_subexp_standard): Handle internal functions
7296         during Fortran function call handling.
7297
7298 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7299
7300         * NEWS: Mention new internal functions.
7301         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7302         (read_base_type): Use dwarf2_init_complex_target_type.
7303         * value.c (creal_internal_fn): New function.
7304         (cimag_internal_fn): New function.
7305         (_initialize_values): Register new internal functions.
7306
7307 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7308
7309         * infrun.c (stop_all_threads): If debug_infrun, always
7310         trace the wait status after wait_one, using
7311         target_waitstatus_to_string and target_pid_to_str.
7312         (handle_inferior_event): Replace various trace of
7313         wait status kind by a single trace.
7314         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7315         wait status kind image by target_waitstatus_to_string.
7316         * target/waitstatus.c (target_waitstatus_to_string): Fix
7317         obsolete comment.
7318
7319 2019-04-01  Tom Tromey  <tromey@adacore.com>
7320
7321         PR symtab/23331:
7322         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7323
7324 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7325             Pedro Alves  <palves@redhat.com>
7326
7327         * top.c (quit_force): Call 'finalize_values'.
7328         * value.c (finalize_values): New function.
7329         * value.h (finalize_values): Declare.
7330
7331 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7332
7333         * NEWS: Announce $_gdb_major and $_gdb_minor.
7334
7335         * top.c (init_gdb_version_vars): New function.
7336         (gdb_init): Call init_gdb_version_vars.
7337
7338 2019-03-29  Tom Tromey  <tromey@adacore.com>
7339
7340         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7341         help text.  Remove dead code.
7342
7343 2019-03-29  Keith Seitz  <keiths@redhat.com>
7344
7345         From Siddhesh Poyarekar:
7346         * f-lang.h (f77_get_upperbound): Return LONGEST.
7347         (f77_get_lowerbound): Likewise.
7348         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7349         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7350         print them.
7351         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7352         plongest to format print it.
7353         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7354         (f77_get_upperbound): Likewise.
7355         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7356         LOWER_BOUND to LONGEST.
7357         (f77_create_arrayprint_offset_tbl): Likewise.
7358
7359 2019-03-29  Keith Seitz  <keiths@redhat.com>
7360
7361         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7362         %s/pulongest for TYPE_LENGTH instead of %d in format
7363         strings.
7364         * ada-typerint.c (ada_print_type): Likewise.
7365         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7366         * compile/compile-c-support.c (generate_register_struct): Likewise.
7367         * gdbtypes.c (recursive_dump_type): Likewise.
7368         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7369         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7370         instead of %d in format strings.
7371         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7372         to std::min to ULONGEST.
7373         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7374         instead of %d in format strings.
7375         * tracepoint.c (info_scope_command): Likewise.
7376         * typeprint.c (print_offset_data::update)
7377         (print_offset_data::finish): Likewise.
7378         * xtensa-tdep.c (xtensa_store_return_value)
7379         (xtensa_push_dummy_call): Likewise.
7380
7381 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7382
7383         * windows-nat.c (display_selector): Fixed format specifications
7384         for 64-bit Cygwin.
7385
7386 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7387
7388         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7389
7390 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7391
7392         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7393         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7394         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7395         (nios2_linux_init_abi): Install it.
7396
7397 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7398
7399         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7400
7401 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7402
7403         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7404
7405 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7406             Tom Tromey  <tromey@adacore.com>
7407
7408         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7409
7410 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7411
7412         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7413         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7414         method to compute the bounds of range types. Also print "[evaluated]"
7415         if the bounds' values come from a dynamic evaluation.
7416
7417 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7418
7419         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7420         whitespace when pretty printing is on.
7421
7422 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7423
7424         * ppc-linux-nat.c: Add include.
7425
7426 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7427
7428         * NEWS: Mention AArch64 Pointer Authentication.
7429
7430 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7431
7432         * arm-linux-nat.c: Add include.
7433
7434 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7435
7436         * source-cache.c (source_cache::get_source_lines): Re-read
7437         fullname after calling open_source_file.
7438
7439 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7440
7441         * NEWS: Mention TLS support for FreeBSD.
7442
7443 2019-03-25  Tom Tromey  <tromey@adacore.com>
7444
7445         * minsyms.c (BUNCH_SIZE): Update comment.
7446         (~minimal_symbol_reader): Remove old comment.
7447         (compact_minimal_symbols): Update comment.
7448         (minimal_symbol_reader::install): Remove old comment.  Update
7449         other comments.
7450
7451 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7452
7453         * s390-linux-nat.c: Add include.
7454
7455 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7456
7457         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7458         Call linux_get_hwcap.
7459         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7460         Likewise.
7461         (aarch64_linux_get_hwcap): Remove function.
7462         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7463         declaration.
7464         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7465         linux_get_hwcap.
7466         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7467         * linux-tdep.c (linux_get_hwcap): Add function.
7468         (linux_get_hwcap2): Likewise.
7469         * linux-tdep.h (linux_get_hwcap): Add declaration.
7470         (linux_get_hwcap2): Likewise.
7471         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7472         (ppc_linux_get_hwcap2): Likewise.
7473         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7474         linux_get_hwcap.
7475         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7476         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7477         (ppc_linux_nat_target::read_description): Likewise.
7478         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7479         * s390-linux-nat.c: Likewise.
7480         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7481
7482 2019-03-24  Tom Tromey  <tom@tromey.com>
7483
7484         * ada-lang.c (standard_lookup): Simplify initialization.
7485         (ada_lookup_symbol_nonlocal): Simplify return.
7486         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7487         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7488         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7489         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7490         initialization.
7491         * solib.c (solib_global_lookup): Simplify.
7492         * symtab.c (null_block_symbol): Remove.
7493         (symbol_cache_lookup): Simplify returns.
7494         (lookup_language_this): Simplify returns.
7495         (lookup_symbol_aux): Simplify return.
7496         (lookup_local_symbol): Simplify returns.
7497         (lookup_global_symbol_from_objfile): Simplify return.
7498         (lookup_symbol_in_objfile_symtabs)
7499         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7500         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7501         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7502         * cp-namespace.c (cp_lookup_bare_symbol)
7503         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7504         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7505         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7506         (cp_lookup_symbol_via_imports): Simplify initialization.
7507         (find_symbol_in_baseclass): Likewise.
7508         * symtab.h (null_block_symbol): Remove.
7509         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7510         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7511         (d_lookup_symbol_module): Likewise.
7512         (find_symbol_in_baseclass): Simplify initialization.
7513
7514 2019-03-24  Tom Tromey  <tom@tromey.com>
7515
7516         * expression.h: Don't include symtab.h.
7517         (struct block): Forward declare.
7518
7519 2019-03-24  Tom Tromey  <tom@tromey.com>
7520
7521         * c-exp.y (typebase): Remove casts.
7522         * gdbtypes.c (lookup_unsigned_typename, )
7523         (lookup_signed_typename): Remove cast.
7524         * eval.c (parse_to_comma_and_eval): Remove cast.
7525         * parse.c (write_dollar_variable): Remove cast.
7526         * block.h (struct block) <superblock>: Now const.
7527         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7528         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7529         (map_block): Make "block" const.
7530         * symfile.h (struct quick_symbol_functions)
7531         <map_matching_symbols>: Constify block argument to "callback".
7532         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7533         const.
7534         (find_pc_sect_compunit_symtab): Make "b" const.
7535         (find_symbol_at_address): Likewise.
7536         (search_symbols): Likewise.
7537         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7538         (dw2_debug_names_lookup_symbol): Likewise.
7539         (dw2_map_matching_symbols): Update.
7540         * p-valprint.c (pascal_val_print): Remove "block".
7541         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7542         (aux_add_nonlocal_symbols): Make "block" const.
7543         (resolve_subexp): Remove cast.
7544         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7545         const.
7546         (iterate_over_file_blocks): Likewise.
7547         * f-exp.y (%union) <bval>: Remove.
7548         * coffread.c (patch_opaque_types): Make "b" const.
7549         * spu-tdep.c (spu_catch_start): Make "block" const.
7550         * c-valprint.c (print_unpacked_pointer): Remove "block".
7551         * symmisc.c (dump_symtab_1): Make "b" const.
7552         (block_depth): Make "block" const.
7553         * d-exp.y (%union) <bval>: Remove.
7554         * cp-support.h (cp_lookup_rtti_type): Update.
7555         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7556         * psymtab.c (psym_lookup_symbol): Make "block" const.
7557         (maintenance_check_psymtabs): Make "b" const.
7558         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7559         (enumerate_locals, enumerate_args): Update.
7560         * python/py-symtab.c (stpy_global_block): Make "block" const.
7561         (stpy_static_block): Likewise.
7562         * inline-frame.c (block_starting_point_at): Make "new_block"
7563         const.
7564         * block.c (find_block_in_blockvector): Make return type const.
7565         (blockvector_for_pc_sect): Make "b" const.
7566         (find_block_in_blockvector): Make "b" const.
7567
7568 2019-03-23  Tom Tromey  <tom@tromey.com>
7569
7570         * varobj.c (varobj_create): Update.
7571         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7572         * printcmd.c (display_command, do_one_display): Don't reset
7573         innermost_block.
7574         * parser-defs.h (enum innermost_block_tracker_type): Move to
7575         expression.h.
7576         (innermost_block): Update comment.
7577         * parse.c (parse_exp_1): Add tracker_types parameter.
7578         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7579         tracker_types parameter.  Reset innermost_block.
7580         (parse_exp_in_context): Remove.
7581         (parse_expression_for_completion): Update.
7582         * objfiles.c (~objfile): Don't reset expression_context_block or
7583         innermost_block.
7584         * expression.h (enum innermost_block_tracker_type): Move from
7585         parser-defs.h.
7586         (parse_exp_1): Add tracker_types parameter.
7587         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7588         reset innermost_block.
7589
7590 2019-03-23  Tom Tromey  <tom@tromey.com>
7591
7592         * objfiles.h: Include bcache.h.
7593
7594 2019-03-23  Tom Tromey  <tom@tromey.com>
7595
7596         * linespec.c (get_current_search_block): Use
7597         scoped_restore_current_language.
7598         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7599
7600 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7601             Jiong Wang  <jiong.wang@arm.com>
7602
7603         * aarch64-linux-tdep.c
7604         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7605         section.
7606         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7607
7608 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7609             Jiong Wang  <jiong.wang@arm.com>
7610
7611         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7612         instructions.
7613         (aarch64_analyze_prologue_test): Add PACIASP test.
7614         (aarch64_prologue_prev_register): Unmask PC value.
7615
7616 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7617             Jiong Wang  <jiong.wang@arm.com>
7618
7619         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7620         (aarch64_dwarf2_prev_register): Unmask PC value.
7621         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7622         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7623         DW_CFA_AARCH64_negate_ra_state.
7624         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7625
7626 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7627             Jiong Wang  <jiong.wang@arm.com>
7628
7629         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7630         registers.
7631         (aarch64_pseudo_register_name): Likewise.
7632         (aarch64_pseudo_register_type): Likewise.
7633         (aarch64_pseudo_register_reggroup_p): Likewise.
7634         (aarch64_gdbarch_init): Add pauth registers.
7635         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7636         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7637         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7638         (struct gdbarch_tdep): Add regnum for ra_state.
7639
7640 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7641             Jiong Wang  <jiong.wang@arm.com>
7642
7643         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7644
7645 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7646             Jiong Wang  <jiong.wang@arm.com>
7647
7648         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7649         function.
7650         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7651         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7652         (aarch64_gdbarch_init): Add puth registers.
7653         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7654         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7655         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7656
7657 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7658             Jiong Wang  <jiong.wang@arm.com>
7659
7660         * aarch64-linux-nat.c
7661         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7662         * aarch64-linux-tdep.c
7663         (aarch64_linux_core_read_description): Likewise.
7664         (aarch64_linux_get_hwcap): New function.
7665         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7666         (aarch64_linux_get_hwcap): New declaration.
7667
7668 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7669             Jiong Wang  <jiong.wang@arm.com>
7670
7671         * aarch64-linux-nat.c
7672         (aarch64_linux_nat_target::read_description): Add pauth param.
7673         * aarch64-linux-tdep.c
7674         (aarch64_linux_core_read_description): Likewise.
7675         * aarch64-tdep.c (struct target_desc): Add in pauth.
7676         (aarch64_read_description): Add pauth param.
7677         (aarch64_gdbarch_init): Likewise.
7678         * aarch64-tdep.h (aarch64_read_description): Likewise.
7679         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7680         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7681         * features/Makefile: Add new files.
7682         * features/aarch64-pauth.c: New file.
7683         * features/aarch64-pauth.xml: New file.
7684
7685 2019-03-20  Tom Tromey  <tromey@adacore.com>
7686
7687         * infrun.c (handle_inferior_event): Rename from
7688         handle_inferior_event_1.  Create a scoped_value_mark.
7689         (handle_inferior_event): Remove.
7690
7691 2019-03-19  Tom Tromey  <tromey@adacore.com>
7692
7693         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7694         * infrun.h (print_stop_event): Add "displays" parameter.
7695         * infrun.c (print_stop_event): Add "displays" parameter.
7696
7697 2019-03-19  Pedro Alves  <palves@redhat.com>
7698
7699         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7700         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7701         to -1.  Fix TABs vs spaces.
7702         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7703         * tui/tui-out.h (tui_ui_out) Add intro comments.
7704         <m_line, m_start_of_line>: In-class initialize, and add describing
7705         comment.
7706
7707 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7708
7709         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7710         variable names.
7711         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7712
7713 2019-03-18  Pedro Alves  <palves@redhat.com>
7714             Eli Zaretskii <eliz@gnu.org>
7715
7716         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7717         m_line and m_start_of_line.
7718
7719 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7720
7721         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7722         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7723         it returns a newline.  This fixes a regression in TU mode, whereby
7724         the next line is output on the same screen line as the user input.
7725
7726 2019-03-18  Tom Tromey  <tromey@adacore.com>
7727
7728         * minsyms.c (minimal_symbol_reader::install): Remove call to
7729         obstack_blank.
7730
7731 2019-03-18  Pedro Alves  <palves@redhat.com>
7732
7733         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7734         New globals.
7735         (apply_style): New, factored out from ...
7736         (apply_ansi_escape): ... this.  Handle reverse video mode.
7737         (tui_set_reverse_mode): New function.
7738         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7739         * tui/tui-winsource.c (tui_show_source_line): Use
7740         tui_set_reverse_mode instead of setting A_STANDOUT.
7741         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7742         New setter methods.
7743
7744 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7745
7746         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7747         Handle tabs.
7748
7749 2019-03-18  Tom Tromey  <tromey@adacore.com>
7750
7751         * ada-lang.c (empty_array): Add "high" parameter.
7752         (ada_evaluate_subexp): Update.
7753
7754 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7755
7756         * unittests/string_view-selftests.c: Define
7757         _initialize_string_view_selftests unconditionally.
7758
7759 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7760
7761         PR gdb/24350
7762         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7763
7764 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7765
7766         PR gdb/24351
7767         * windows-nat.c (display_selector): Fix format specifiers.
7768
7769 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7770
7771         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7772         tui_refill_source_window instead of tui_refresh_win, to update the
7773         current execution line.  This fixes redisplay of the current line
7774         when stepping through the code with "next" or "step".
7775
7776 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7777
7778         * source-cache.c (source_cache::get_source_lines): Call
7779         find_source_lines to initialize s->nlines.  This fixes vertical
7780         scrolling of TUI source window when the DOWN arrow is pressed.
7781
7782 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7783
7784         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7785         linux-thread-db.c (_initialize_thread_db): Likewise.
7786
7787 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7788
7789         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7790         wclrtoeol in tui_show_source_line".  This reverts changes made in
7791         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7792
7793 2019-03-15  Tom Tromey  <tom@tromey.com>
7794
7795         * symtab.h (struct minimal_symbol): Derive from
7796         general_symbol_info.
7797         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7798         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7799         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7800         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7801         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7802         (MSYMBOL_SEARCH_NAME): Update.
7803         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7804         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7805         * minsyms.c (minimal_symbol_reader::record_full): Update.
7806
7807 2019-03-15  Tom Tromey  <tom@tromey.com>
7808
7809         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7810
7811 2019-03-15  Tom Tromey  <tom@tromey.com>
7812
7813         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7814         unique_xmalloc_ptr.
7815         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7816         Update.
7817         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7818         (build_minimal_symbol_hash_tables)
7819         (minimal_symbol_reader::install): Update.
7820
7821 2019-03-15  Tom Tromey  <tom@tromey.com>
7822
7823         * symtab.c (create_demangled_names_hash): Update.
7824         (symbol_set_names): Update.
7825         * objfiles.h (struct objfile_per_bfd_storage)
7826         <demangled_names_hash>: Now an htab_up.
7827         * objfiles.c (objfile_per_bfd_storage): Simplify.
7828
7829 2019-03-15  Tom Tromey  <tom@tromey.com>
7830
7831         * objfiles.h (struct objfile_per_bfd_storage): Declare
7832         destructor.
7833         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7834         New.
7835         (get_objfile_bfd_data): Use new.  Don't initialize
7836         language_of_main.
7837         (free_objfile_per_bfd_storage): Remove.
7838         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7839
7840 2019-03-15  Tom Tromey  <tom@tromey.com>
7841
7842         * symfile.c (reread_symbols): Update.
7843         * objfiles.c (objfile::objfile): Update.
7844         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7845         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7846         comment.
7847         (minimal_symbol_reader::install): Update.
7848         (terminate_minimal_symbol_table): Remove.
7849         * jit.c (jit_object_close_impl): Update.
7850
7851 2019-03-15  Tom Tromey  <tom@tromey.com>
7852
7853         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7854         initializations.
7855
7856 2019-03-15  Tom Tromey  <tom@tromey.com>
7857
7858         * objfiles.h (struct objfile_per_bfd_storage)
7859         <demangled_hash_languages>: Now a bitset.
7860         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7861         (lookup_minimal_symbol): Update.
7862
7863 2019-03-15  Tom Tromey  <tom@tromey.com>
7864
7865         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7866         Don't return the symbol.
7867         * coffread.c (record_minimal_symbol): Use record_full.
7868
7869 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7870
7871         The MS-Windows port of ncurses fails to switch to a color pair if
7872         one or both of the colors are the implicit default colors.  This
7873         change records the default colors when TUI is initialized, and
7874         then specifies them explicitly when a color pair uses the default
7875         colors.  This allows color styling in TUI mode on MS-Windows.
7876
7877         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7878         ncurses_norm_attr.
7879         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7880         colors in ncurses_norm_attr.
7881         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7882         "none", replace it with the default color recorded in
7883         ncurses_norm_attr.
7884
7885 2019-03-14  Tom Tromey  <tromey@adacore.com>
7886
7887         * source-cache.h (class source_cache) <get_source_lines>: Return
7888         std::string.
7889         * source-cache.c (source_cache::extract_lines): Handle case where
7890         first_pos==npos.  Return std::string.
7891         (source_cache::get_source_lines): Update.
7892
7893 2019-03-14  Tom Tromey  <tromey@adacore.com>
7894
7895         * NEWS: Add item for "style sources" commands.
7896         * source-cache.c (source_cache::get_source_lines): Check
7897         source_styling.
7898         * cli/cli-style.c (source_styling): New global.
7899         (_initialize_cli_style): Add "style sources" commands.
7900         (show_style_sources): New function.
7901         * cli/cli-style.h (source_styling): Declare.
7902
7903 2019-03-14  Pedro Alves  <palves@redhat.com>
7904             Tom Tromey  <tromey@adacore.com>
7905
7906         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7907         * tui/tui-winsource.c (tui_refill_source_window): New function,
7908         from...
7909         (tui_horizontal_source_scroll): ... here.  Move some logic.
7910         * cli/cli-style.c (set_style_enabled): Notify new observable.
7911         * tui/tui-hooks.c (tui_redisplay_source): New function.
7912         (tui_attach_detach_observers): Attach or detach
7913         tui_redisplay_source.
7914         * observable.h (source_styling_changed): New observable.
7915         * observable.c: Define source_styling_changed observable.
7916
7917 2019-03-13  Tom Tromey  <tromey@adacore.com>
7918
7919         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7920         (i386_gnu_nat_target::store_registers): Update.
7921         * target-debug.h (target_debug_print_std_string): New macro.
7922         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7923         * windows-tdep.c (display_one_tib): Update.
7924         * tui/tui-stack.c (tui_make_status_line): Update.
7925         * top.c (print_inferior_quit_action): Update.
7926         * thread.c (thr_try_catch_cmd): Update.
7927         (add_thread_with_info): Update.
7928         (thread_target_id_str): Update.
7929         (thr_try_catch_cmd): Update.
7930         (thread_command): Update.
7931         (thread_find_command): Update.
7932         * record-btrace.c (record_btrace_target::info_record)
7933         (record_btrace_resume_thread, record_btrace_target::resume)
7934         (record_btrace_cancel_resume, record_btrace_step_thread)
7935         (record_btrace_target::wait, record_btrace_target::wait)
7936         (record_btrace_target::wait, record_btrace_target::stop): Update.
7937         * progspace.c (print_program_space): Update.
7938         * process-stratum-target.c
7939         (process_stratum_target::thread_address_space): Update.
7940         * linux-fork.c (linux_fork_mourn_inferior)
7941         (detach_checkpoint_command, info_checkpoints_command)
7942         (linux_fork_context): Update.
7943         (linux_fork_detach): Update.
7944         (class scoped_switch_fork_info): Update.
7945         (delete_checkpoint_command): Update.
7946         * infrun.c (follow_fork_inferior): Update.
7947         (follow_fork_inferior): Update.
7948         (proceed_after_vfork_done): Update.
7949         (handle_vfork_child_exec_or_exit): Update.
7950         (follow_exec): Update.
7951         (displaced_step_prepare_throw): Update.
7952         (displaced_step_restore): Update.
7953         (start_step_over): Update.
7954         (resume_1): Update.
7955         (clear_proceed_status_thread): Update.
7956         (proceed): Update.
7957         (print_target_wait_results): Update.
7958         (do_target_wait): Update.
7959         (context_switch): Update.
7960         (stop_all_threads): Update.
7961         (restart_threads): Update.
7962         (finish_step_over): Update.
7963         (handle_signal_stop): Update.
7964         (switch_back_to_stepped_thread): Update.
7965         (keep_going_pass_signal): Update.
7966         (print_exited_reason): Update.
7967         (normal_stop): Update.
7968         * inferior.c (inferior_pid_to_str): Change return type.
7969         (print_selected_inferior): Update.
7970         (add_inferior): Update.
7971         (detach_inferior): Update.
7972         * dummy-frame.c (fprint_dummy_frames): Update.
7973         * dcache.c (dcache_info_1): Update.
7974         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7975         (btrace_fetch, btrace_clear): Update.
7976         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7977         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7978         type.
7979         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7980         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7981         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7982         * gdbarch.c, gdbarch.h: Rebuild.
7983         * gdbarch.sh (core_pid_to_str): Change return type.
7984         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7985         return type.
7986         (windows_nat_target::pid_to_str): Change return type.
7987         (windows_delete_thread): Update.
7988         (windows_nat_target::attach): Update.
7989         (windows_nat_target::files_info): Update.
7990         * target-delegates.c: Rebuild.
7991         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7992         return type.
7993         (sol_thread_target::pid_to_str): Change return type.
7994         * remote.c (class remote_target) <pid_to_str>: Change return
7995         type.
7996         (remote_target::pid_to_str): Change return type.
7997         (extended_remote_target::attach, remote_target::remote_stop_ns)
7998         (remote_target::remote_notif_remove_queued_reply)
7999         (remote_target::push_stop_reply, remote_target::disable_btrace):
8000         Update.
8001         (extended_remote_target::attach): Update.
8002         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8003         type.
8004         (gdbsim_target::pid_to_str): Change return type.
8005         * ravenscar-thread.c (struct ravenscar_thread_target)
8006         <pid_to_str>: Change return type.
8007         (ravenscar_thread_target::pid_to_str): Change return type.
8008         * procfs.c (class procfs_target) <pid_to_str>: Change return
8009         type.
8010         (procfs_target::pid_to_str): Change return type.
8011         (procfs_target::attach): Update.
8012         (procfs_target::detach): Update.
8013         (procfs_target::fetch_registers): Update.
8014         (procfs_target::store_registers): Update.
8015         (procfs_target::wait): Update.
8016         (procfs_target::files_info): Update.
8017         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8018         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8019         return type.
8020         (nto_procfs_target::pid_to_str): Change return type.
8021         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8022         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8023         return type.
8024         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8025         (exit_lwp): Update.
8026         (attach_proc_task_lwp_callback, get_detach_signal)
8027         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8028         (linux_nat_target::resume, wait_lwp, stop_callback)
8029         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8030         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8031         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8032         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8033         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8034         type.
8035         (inf_ptrace_target::attach): Update.
8036         (inf_ptrace_target::files_info): Update.
8037         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8038         type.
8039         (go32_nat_target::pid_to_str): Change return type.
8040         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8041         (gnu_nat_target::wait): Update.
8042         (gnu_nat_target::wait): Update.
8043         (gnu_nat_target::resume): Update.
8044         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8045         (fbsd_nat_target::wait): Update.
8046         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8047         type.
8048         (darwin_nat_target::attach): Update.
8049         * corelow.c (class core_target) <pid_to_str>: Change return type.
8050         (core_target::pid_to_str): Change return type.
8051         * target.c (normal_pid_to_str): Change return type.
8052         (default_pid_to_str): Likewise.
8053         (target_pid_to_str): Change return type.
8054         (target_translate_tls_address): Update.
8055         (target_announce_detach): Update.
8056         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8057         return type.
8058         (bsd_uthread_target::pid_to_str): Change return type.
8059         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8060         type.
8061         (bsd_kvm_target::pid_to_str): Change return type.
8062         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8063         return type.
8064         (aix_thread_target::pid_to_str): Change return type.
8065         * target.h (struct target_ops) <pid_to_str>: Change return type.
8066         (target_pid_to_str, normal_pid_to_str): Likewise.
8067         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8068         type.
8069         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8070         type.
8071         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8072         return type.
8073         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8074         type.
8075         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8076         type.
8077         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8078         return type.
8079
8080 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8081
8082         * NEWS: Mention that the new default MI version is 3.  Mention
8083         changes to the output of commands and events that deal with
8084         multi-location breakpoints.
8085         * breakpoint.c: Include "mi/mi-out.h".
8086         (print_one_breakpoint): Change output syntax if using MI version
8087         >= 3.
8088         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8089         New.
8090         (mi_multi_location_breakpoint_output_fixed): New.
8091         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8092         (mi_cmd_fix_multi_location_breakpoint_output): New.
8093         (mi_multi_location_breakpoint_output_fixed): New.
8094         * mi/mi-cmds.c (mi_cmds): Register command
8095         -fix-multi-location-breakpoint-output.
8096         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8097         interpreter "mi".
8098
8099 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8100
8101         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8102         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8103         instantiate mi_ui_out based on interpreter name.
8104         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8105         * mi/mi-main.c (mi_load_progress): Likewise.
8106
8107 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8108
8109         * NEWS: Combine separate "New targets" sections for 8.3.
8110
8111 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8112
8113         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8114         (ppcfbsd_init_abi): Install gdbarch
8115         "fetch_tls_load_module_address" and "get_thread_local_address"
8116         methods.
8117
8118 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8119
8120         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8121         (riscv_fbsd_init_abi): Install gdbarch
8122         "fetch_tls_load_module_address" and "get_thread_local_address"
8123         methods.
8124
8125 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8126
8127         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8128         (i386fbsd_init_abi): Install gdbarch
8129         "fetch_tls_load_module_address" and "get_thread_local_address"
8130         methods.
8131
8132 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8133
8134         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8135         (amd64fbsd_init_abi): Install gdbarch
8136         "fetch_tls_load_module_address" and "get_thread_local_address"
8137         methods.
8138
8139 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8140
8141         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8142         (struct fbsd_pspace_data): New type.
8143         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8144         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8145         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8146         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8147         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8148
8149 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8150
8151         * gdbtypes.c (lookup_struct_elt): New function.
8152         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8153         * gdbtypes.h (struct struct_elt): New type.
8154         (lookup_struct_elt): New prototype.
8155
8156 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8157
8158         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8159         remove disabled code block.
8160
8161 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8162
8163         * gdbarch.sh (get_thread_local_address): New method.
8164         * gdbarch.h, gdbarch.c: Regenerate.
8165         * target.c (target_translate_tls_address): Use
8166         gdbarch_get_thread_local_address if present instead of
8167         target::get_thread_local_address.
8168
8169 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8170
8171         * target.h (target::get_thread_local_address): Update comment.
8172
8173 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8174
8175         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8176         objfile->separate_debug_objfile_backlink if not NULL.
8177
8178 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8179
8180         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8181         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8182         (amd64bsd_store_inferior_registers): Likewise.
8183         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8184         Enable segment base registers.
8185         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8186         PT_GETFSBASE and PT_GETGSBASE.
8187         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8188         PT_SETGSBASE.
8189         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8190         segment base registers.
8191         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8192
8193 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8194
8195         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8196         Update calls to i386_target_description to add 'segments'
8197         parameter.
8198         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8199         add segment base registers.
8200         * arch/i386.c (i386_create_target_description): Add 'segments'
8201         parameter to enable segment base registers.
8202         * arch/i386.h (i386_create_target_description): Likewise.
8203         * features/i386/32bit-segments.xml: New file.
8204         * features/i386/32bit-segments.c: Generate.
8205         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8206         call to i386_target_description to add 'segments' parameter.
8207         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8208         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8209         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8210         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8211         if feature is present.
8212         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8213         Add 'segments' parameter to call to i386_target_description.
8214         (i386_target_description): Add 'segments' parameter to enable
8215         segment base registers.
8216         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8217         to call to i386_target_description.
8218         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8219         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8220         Define I386_NUM_REGS.
8221         (i386_target_description): Add 'segments' parameter to enable
8222         segment base registers.
8223
8224 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8225
8226         PR/24325
8227         * source-cache.c: #undef open and close, to avoid unresolved
8228         externals during linking.
8229
8230 2019-03-12  Tom Tromey  <tromey@adacore.com>
8231
8232         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8233         const.  Add initializers.
8234         (_initialize_remote): Don't initialize ptid globals.
8235
8236 2019-03-12  Pedro Alves  <palves@redhat.com>
8237
8238         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8239
8240 2019-03-12  Pedro Alves  <palves@redhat.com>
8241
8242         * cp-name-parser.y (main): Remove unused 'len' variable.
8243
8244 2019-03-12  Tom Tromey  <tromey@adacore.com>
8245
8246         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8247         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8248
8249 2019-03-12  Tom Tromey  <tromey@adacore.com>
8250
8251         * linux-nat.c (iterate_over_lwps): Update.
8252         (stop_callback): Remove parameter.
8253         (stop_wait_callback, detach_callback, resume_set_callback)
8254         (select_singlestep_lwp_callback, set_ignore_sigint)
8255         (status_callback, resumed_callback, resume_clear_callback)
8256         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8257         data parameter.
8258         (linux_nat_target::detach, linux_nat_target::resume)
8259         (linux_stop_and_wait_all_lwps, select_event_lwp)
8260         (linux_nat_filter_event, linux_nat_wait_1)
8261         (linux_nat_target::kill, linux_nat_target::stop)
8262         (linux_nat_target::stop): Update.
8263         (linux_nat_resume_callback): Change type.
8264         (resume_stopped_resumed_lwps, count_events_callback)
8265         (select_event_lwp_callback): Likewise.
8266         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8267         * arm-linux-nat.c (struct update_registers_data): Remove.
8268         (update_registers_callback): Change type.
8269         (arm_linux_insert_hw_breakpoint1): Update.
8270         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8271         parameter.
8272         (x86_linux_dr_set_addr): Update.
8273         (x86_linux_dr_set_control): Update.
8274         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8275         (iterate_over_lwps): Use gdb::function_view.
8276         * nat/aarch64-linux-hw-point.c (struct
8277         aarch64_dr_update_callback_param): Remove.
8278         (debug_reg_change_callback): Change type.
8279         (aarch64_notify_debug_reg_change): Update.
8280         * s390-linux-nat.c (s390_refresh_per_info): Update.
8281
8282 2019-03-11  Tom Tromey  <tromey@adacore.com>
8283
8284         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8285         redundant assignment to "this_cu".
8286
8287 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8288
8289         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8290
8291 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8292
8293         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8294         from...
8295         (rank_one_type): ... this.
8296
8297 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8298
8299         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8300         from...
8301         (rank_one_type): ... this.
8302
8303 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8304
8305         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8306         from...
8307         (rank_one_type): ... this.
8308
8309 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8310
8311         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8312         from...
8313         (rank_one_type): ... this.
8314
8315 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8316
8317         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8318         from...
8319         (rank_one_type): ... this.
8320
8321 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8322
8323         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8324         from...
8325         (rank_one_type): ... this.
8326
8327 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8328
8329         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8330         from...
8331         (rank_one_type): ... this.
8332
8333 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8334
8335         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8336         from...
8337         (rank_one_type): ... this.
8338
8339 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8340
8341         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8342         from...
8343         (rank_one_type): ... this.
8344
8345 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8346
8347         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8348         from...
8349         (rank_one_type): ... this.
8350
8351 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8352
8353         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8354         from...
8355         (rank_one_type): ... this.
8356
8357 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8358
8359         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8360         from...
8361         (rank_one_type): ... this.
8362
8363 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8364
8365         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8366         inferior-events' shows the example events.
8367
8368 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8369
8370         Support styling on native MS-Windows console
8371
8372         PR/24315
8373         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8374         on MS-Windows if $TERM is not defined.
8375
8376         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8377
8378         * posix-hdep.c (gdb_console_fputs):
8379         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8380         functions.
8381         * ui-file.h (gdb_console_fputs): Add prototype.
8382
8383         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8384         back to fputs only if the former returns zero.
8385
8386 2019-03-07  Tom Tromey  <tom@tromey.com>
8387
8388         * symmisc.c (print_symbol_bcache_statistics): Update.
8389         (print_objfile_statistics): Update.
8390         * symfile.c (allocate_symtab): Update.
8391         * stabsread.c: Don't include bcache.h.
8392         * psymtab.h (struct psymbol_bcache): Don't declare.
8393         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8394         (psymbol_bcache_init, psymbol_bcache_free)
8395         (psymbol_bcache_get_bcache): Don't declare.
8396         * psymtab.c (struct psymbol_bcache): Remove.
8397         (psymtab_storage::psymtab_storage): Update.
8398         (psymtab_storage::~psymtab_storage): Update.
8399         (psymbol_bcache_init, psymbol_bcache_free)
8400         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8401         (add_psymbol_to_bcache): Update.
8402         (allocate_psymtab): Update.
8403         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8404         macro_cache>: No longer pointers.
8405         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8406         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8407         * macrotab.c (macro_bcache): Update.
8408         * macroexp.c: Don't include bcache.h.
8409         * gdbtypes.c (check_types_worklist): Update.
8410         (types_deeply_equal): Remove TRY/CATCH.  Update.
8411         * elfread.c (elf_symtab_read): Update.
8412         * dwarf2read.c: Don't include bcache.h.
8413         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8414         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8415         (print_bcache_statistics, bcache_memory_used): Don't declare.
8416         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8417         methods.  Rename all data members.
8418         * bcache.c (struct bcache): Move to bcache.h.
8419         (bcache::expand_hash_table): Rename from expand_hash_table.
8420         (bcache): Remove.
8421         (bcache::insert): Rename from bcache_full.
8422         (bcache::compare): Rename from bcache_compare.
8423         (bcache_xmalloc): Remove.
8424         (bcache::~bcache): Rename from bcache_xfree.
8425         (bcache::print_statistics): Rename from print_bcache_statistics.
8426         (bcache::memory_used): Rename from bcache_memory_used.
8427
8428 2019-03-07  Pedro Alves  <palves@redhat.com>
8429
8430         * infrun.c (normal_stop): Also check for
8431         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8432
8433 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8434
8435         * f-lang.c (value_from_host_double): Moved to...
8436         * value.c (value_from_host_double): ...here.
8437         * value.h (value_from_host_double): Declare.
8438         * guile/scm-math.c (vlscm_convert_typed_number): Use
8439         value_from_host_double.
8440         (vlscm_convert_number): Likewise.
8441         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8442         * python/py-value.c (convert_value_from_python): Likewise.
8443
8444 2019-03-06  Tom Tromey  <tom@tromey.com>
8445
8446         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8447
8448 2019-03-06  Tom Tromey  <tom@tromey.com>
8449
8450         * utils.h (free_current_contents): Don't declare.
8451         * utils.c (free_current_contents): Remove.
8452
8453 2019-03-06  Tom Tromey  <tom@tromey.com>
8454
8455         * top.c (quit_force): Update.
8456         * main.c (captured_command_loop): Update.
8457         * common/new-op.c (operator new): Update.
8458         * common/common-exceptions.c (struct catcher)
8459         <save_cleanup_chain>: Remove member.
8460         (exceptions_state_mc_init): Update.
8461         (exception_try_scope_entry): Return nullptr.
8462         (exception_try_scope_exit, exception_rethrow)
8463         (throw_exception_sjlj, throw_exception_cxx): Update.
8464         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8465         (all_cleanups, do_cleanups, discard_cleanups)
8466         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8467         (restore_cleanups, restore_final_cleanups): Don't declare.
8468         (do_final_cleanups): Remove parameter.
8469         * common/cleanups.c (cleanup_chain, make_cleanup)
8470         (make_cleanup_dtor, all_cleanups, do_cleanups)
8471         (discard_my_cleanups, discard_cleanups)
8472         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8473         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8474         (null_cleanup): Remove.
8475         (do_final_cleanups): Remove parameter.
8476
8477 2019-03-06  Tom Tromey  <tom@tromey.com>
8478
8479         * remote.c (remote_target::remote_parse_stop_reply): Use
8480         unique_xmalloc_ptr.
8481
8482 2019-03-06  Tom Tromey  <tom@tromey.com>
8483
8484         * stabsread.c (struct stabs_field_info): Rename from field_info.
8485         <list, fnlist>: Add initializers.
8486         <obstack>: New member.
8487         (read_member_functions, read_struct_fields, read_baseclasses):
8488         Allocate on obstack.  Don't use cleanups.
8489         (read_one_struct_field, read_member_functions, read_struct_fields)
8490         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8491         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8492         (read_struct_type): Update.
8493
8494 2019-03-06  Tom Tromey  <tom@tromey.com>
8495
8496         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8497         * common/filestuff.h (make_cleanup_close): Don't declare.
8498         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8499         Remove.
8500
8501 2019-03-06  Tom Tromey  <tom@tromey.com>
8502
8503         * solib-aix.c: Use make_scope_exit.
8504
8505 2019-03-06  Tom Tromey  <tom@tromey.com>
8506
8507         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8508         Use make_scope_exit.
8509
8510 2019-03-06  Tom Tromey  <tom@tromey.com>
8511
8512         * solib-svr4.c (disable_probes_interface): Remove parameter.
8513         (svr4_handle_solib_event): Use make_scope_exit.
8514
8515 2019-03-06  Tom Tromey  <tom@tromey.com>
8516
8517         * remote.c (struct stop_reply_deleter): Remove.
8518         (stop_reply_up): Update.
8519         (struct stop_reply): Derive from notif_event.  Don't typedef.
8520         <regcache>: Now a std::vector.
8521         (stop_reply_xfree): Remove.
8522         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8523         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8524         (remote_target::discard_pending_stop_replies): Use delete.
8525         (remote_target::remote_parse_stop_reply): Update.
8526         (remote_target::process_stop_reply): Update.
8527         * remote-notif.h (struct notif_event): Add virtual destructor.
8528         Remove "dtr" member.
8529         (struct notif_client) <alloc_event>: Return a unique_ptr.
8530         (notif_event_xfree): Don't declare.
8531         (notif_event_up): New typedef.
8532         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8533         (notif_event_xfree, do_notif_event_xfree): Remove.
8534         (remote_notif_state_xfree): Update.
8535
8536 2019-03-06  Tom Tromey  <tom@tromey.com>
8537
8538         * infrun.c (displaced_step_clear_cleanup): Now a
8539         forward_scope_exit type.
8540         (displaced_step_prepare_throw): Update.
8541         (displaced_step_fixup): Update.
8542
8543 2019-03-06  Tom Tromey  <tom@tromey.com>
8544
8545         * inferior.h (class inferior): Update comment.
8546         * gdbthread.h (class thread_info): Update comment.
8547
8548 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8549             Tom Tromey  <tom@tromey.com>
8550
8551         * stabsread.h (struct stab_section_list): Remove.
8552         (coffstab_build_psymtabs): Update.
8553         * dbxread.c (symbuf_sections): Now a std::vector.
8554         (sect_idx): New global.
8555         (fill_symbuf): Update.
8556         (coffstab_build_psymtabs): Change type of stabsects parameter.
8557         Update.
8558         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8559         std::vector.
8560         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8561         (coff_locate_sections): Update.
8562         (coff_symfile_read): Remove cleanups.  Update.
8563         (init_stringtab): Add storage parameter.
8564         (free_stringtab, free_stringtab_cleanup): Remove.
8565         (init_lineno): Add storage parameter.
8566         (free_linetab, free_linetab_cleanup): Remove.
8567
8568 2019-03-06  Pedro Alves  <palves@redhat.com>
8569
8570         * linux-fork.c (fork_info::clobber_regs): Delete.
8571         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8572         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8573         comment.  Adjust.
8574         (scoped_switch_fork_info::scoped_switch_fork_info)
8575         (checkpoint_command, linux_fork_context): Adjust
8576         fork_save_infrun_state calls.
8577
8578 2019-03-06  Pedro Alves  <palves@redhat.com>
8579
8580         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8581         (inf_has_multiple_threads): Return 'bool' and rewrite using
8582         inferior_info::threads().
8583
8584 2019-03-06  Pedro Alves  <palves@redhat.com>
8585
8586         * linux-fork.c: Include <list>.
8587         (fork_list): Now a std::list instance.
8588         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8589         (forks_exist_p, find_last_fork): Adjust.
8590         (new_fork): Delete.
8591         (one_fork_p): New.
8592         (add_fork): Adjust.
8593         (free_fork): Delete, folded into fork_info::~fork_info().
8594         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8595         Adjust.
8596         (init_fork_list): Delete.
8597         (linux_fork_killall, linux_fork_mourn_inferior)
8598         (linux_fork_detach, info_checkpoints_command): Adjust.
8599         (_initialize_linux_fork): No longer call init_fork_list.
8600
8601 2019-03-06  Pedro Alves  <palves@redhat.com>
8602
8603         * linux-fork.c (new_fork): New, split out of ...
8604         (add_fork): ... this.  Return void.  Move "first fork" special
8605         case from here, to ...
8606         (checkpoint_command): ... here.
8607         * linux-linux.h (add_fork): Return void.
8608
8609 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8610
8611         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8612
8613 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8614             Chris January  <chris.january@arm.com>
8615             David Lecomber  <david.lecomber@arm.com>
8616
8617         * f-exp.y: New token, UNOP_INTRINSIC.
8618         (exp): New pattern using UNOP_INTRINSIC token.
8619         (f77_keywords): Add 'abs' keyword.
8620         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8621         (value_from_host_double): New function.
8622         (evaluate_subexp_f): Support UNOP_ABS.
8623
8624 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8625
8626         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8627         types.
8628
8629 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8630
8631         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8632         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8633         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8634
8635 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8636
8637         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8638
8639 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8640             Chris January  <chris.january@arm.com>
8641
8642         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8643         * f-exp.y: Define 'KIND' token.
8644         (exp): New pattern for KIND expressions.
8645         (ptype): Handle types with a kind extension.
8646         (direct_abs_decl): Extend to spot kind extensions.
8647         (f77_keywords): Add 'kind' to the list.
8648         (push_kind_type): New function.
8649         (convert_to_kind_type): New function.
8650         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8651         * parse.c (operator_length_standard): Likewise.
8652         * parser-defs.h (enum type_pieces): Add tp_kind.
8653         * std-operator.def: Add UNOP_KIND.
8654
8655 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8656
8657         * f-exp.y (f_parse): Set yydebug.
8658
8659 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8660
8661         * f-lang.c (evaluate_subexp_f): New function.
8662         (exp_descriptor_f): New global.
8663         (f_language_defn): Use exp_descriptor_f instead of
8664         exp_descriptor_standard.
8665
8666 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8667
8668         * f-exp.y (struct token): Add comments.
8669         (dot_ops): Remove uppercase versions and the end marker.
8670         (f77_keywords): Likewise.
8671         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8672         entries in the dot_ops array are case insensitive, and use
8673         strncasecmp to compare strings.  Also some whitespace cleanup in
8674         this area.  Similar for the f77_keywords array, except entries in
8675         this list might be case sensitive.
8676
8677 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8678
8679         * f-exp.y (struct f77_boolean_val): Add comments.
8680         (boolean_values): Remove uppercase versions, and end marker.
8681         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8682         and use strncasecmp to achieve case insensitivity.  Additionally,
8683         perform whitespace cleanup around this code.
8684
8685 2019-03-06  Tom Tromey  <tromey@adacore.com>
8686
8687         * remote-sim.c (gdbsim_target_open): Use result of
8688         gdb_argv::release.
8689
8690 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8691         Dirk Schubert  <dirk.schubert@arm.com>
8692         Chris January  <chris.january@arm.com>
8693
8694         * eval.c (evaluate_subexp_standard): Call Fortran argument
8695         wrapping logic.
8696         * f-lang.c (struct value): A value which can be passed into a
8697         Fortran function call.
8698         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8699         where appropriate.
8700         (struct type): Value ready for a Fortran function call.
8701         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8702         is needed.
8703         * f-lang.h (fortran_argument_convert): Declaration.
8704         (fortran_preserve_arg_pointer): Declaration.
8705         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8706
8707 2019-03-05  Tom Tromey  <tromey@adacore.com>
8708
8709         * python/py-prettyprint.c (print_string_repr): Remove #if.
8710         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8711
8712 2019-03-05  Tom Tromey  <tromey@adacore.com>
8713
8714         * target.c (the_dummy_target): Move later.  Change type to
8715         "dummy_target".
8716         (initialize_targets): Don't initialize the_dummy_target.
8717
8718 2019-03-05  Tom Tromey  <tromey@adacore.com>
8719
8720         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8721         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8722
8723 2019-03-05  Tom Tromey  <tromey@adacore.com>
8724
8725         * windows-nat.c (windows_nat_target::attach)
8726         (windows_nat_target::detach): Don't call gdb_flush.
8727         * valprint.c (generic_val_print, val_print, val_print_string):
8728         Don't call gdb_flush.
8729         * utils.c (defaulted_query): Don't call gdb_flush.
8730         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8731         * target.c (target_announce_detach): Don't call gdb_flush.
8732         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8733         * remote.c (extended_remote_target::attach): Don't call
8734         gdb_flush.
8735         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8736         * printcmd.c (do_examine): Don't call gdb_flush.
8737         (info_display_command): Don't call gdb_flush.
8738         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8739         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8740         * memattr.c (info_mem_command): Don't call gdb_flush.
8741         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8742         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8743         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8744         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8745         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8746         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8747         (gnu_nat_target::detach): Don't call gdb_flush.
8748         * f-valprint.c (f_val_print): Don't call gdb_flush.
8749         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8750         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8751         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8752         gdb_flush.
8753         * c-valprint.c (c_val_print): Don't call gdb_flush.
8754         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8755
8756 2019-03-05  Tom Tromey  <tromey@adacore.com>
8757
8758         * varobj.c (update_dynamic_varobj_children): Update.
8759         (install_default_visualizer): Use reset, not release.
8760         * value.c (set_internalvar): Update.
8761         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8762         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8763         ATTRIBUTE_UNUSED_RESULT.
8764
8765 2019-03-05  Tom Tromey  <tromey@adacore.com>
8766
8767         * remote.c (class scoped_remote_fd) <release>: Add
8768         ATTRIBUTE_UNUSED_RESULT.
8769
8770 2019-03-05  Tom Tromey  <tromey@adacore.com>
8771
8772         * macroexp.c (struct macro_buffer) <release>: Add
8773         ATTRIBUTE_UNUSED_RESULT.
8774
8775 2019-03-05  Tom Tromey  <tromey@adacore.com>
8776
8777         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8778         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8779         ATTRIBUTE_UNUSED_RESULT.
8780
8781 2019-03-05  Tom Tromey  <tromey@adacore.com>
8782
8783         * common/scoped_fd.h (class scoped_fd) <release>: Add
8784         ATTRIBUTE_UNUSED_RESULT.
8785
8786 2019-03-05  Tom Tromey  <tromey@adacore.com>
8787
8788         * parser-defs.h (struct parser_state) <release>: Add
8789         ATTRIBUTE_UNUSED_RESULT.
8790
8791 2019-03-05  Tom Tromey  <tromey@adacore.com>
8792
8793         * utils.h (class gdb_argv) <release>: Add
8794         ATTRIBUTE_UNUSED_RESULT.
8795         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8796
8797 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8798
8799         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8800         for-loop range, to avoid compiler warnings.
8801
8802         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8803         avoid compiler warnings about unused variables.
8804
8805         * NEWS: Mention end of support for native debugging on MS-Windows
8806         before XP.
8807
8808         PR gdb/24292
8809         * common/netstuff.c:
8810         * gdbserver/gdbreplay.c
8811         * gdbserver/remote-utils.c:
8812         * ser-tcp.c:
8813         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8814         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8815         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8816         'getaddrinfo' and 'freeaddrinfo' were not available before
8817         Windows XP, and mingw.org's MinGW headers by default define
8818         _WIN32_WINNT to 0x500.
8819
8820 2019-03-01  Gary Benson <gbenson@redhat.com>
8821
8822         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8823
8824 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8825             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8826
8827         PR gdb/8527
8828         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8829         set_sigint_trap, clear_sigint_trap.
8830
8831 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8832
8833         * target.c (target_detach): Clear the regcache and the
8834         frame cache.
8835
8836 2019-02-27  Pedro Alves  <palves@redhat.com>
8837
8838         * utils.c (set_screen_size): When we cap the height/width sizes,
8839         tweak the corresponding command variable to show "unlimited":
8840
8841 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8842             Pedro Alves  <palves@redhat.com>
8843
8844         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8845         before calling rl_set_screen_size.
8846
8847 2019-02-27  Tom Tromey  <tromey@adacore.com>
8848
8849         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8850         define.
8851         * python/py-value.c: Remove Python 2.4 workaround.
8852         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8853         workaround.
8854         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8855         Python 2.4 workaround.
8856         * python/python-internal.h: Remove Python 2.4 comment.
8857         (Py_ssize_t): Don't define.
8858         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8859         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8860         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8861         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8862         * python/python.c (do_start_initialization): Remove Python 2.4
8863         workaround.
8864         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8865         (print_children): Remove Python 2.4 workaround.
8866         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8867         workaround.
8868         (CHARBUFFERPROC_NAME): Remove.
8869         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8870         Python 2.4 workaround.
8871
8872 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8873
8874         * NEWS: Note minimum Python version.
8875
8876 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8877
8878         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8879         code from these functions.  Remove corresponding ifdefs.  Use
8880         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8881         Remove gotos and target of gotos.
8882         (infpy_search_memory): Likewise.
8883
8884 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8885
8886         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8887         (hppa_gdbarch_init): Don't register deleted functions with
8888         gdbarch.
8889
8890 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8891
8892         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8893         (h8300_unwind_sp): Delete.
8894         (h8300_dummy_id): Delete.
8895         (h8300_gdbarch_init): Don't register deleted functions with
8896         gdbarch.
8897
8898 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8899
8900         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8901         (ft32_unwind_pc): Delete.
8902         (ft32_unwind_sp): Delete.
8903         (ft32_gdbarch_init): Don't register deleted functions with
8904         gdbarch.
8905
8906 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8907
8908         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8909         (frv_unwind_pc): Delete.
8910         (frv_unwind_sp): Delete.
8911         (frv_gdbarch_init): Don't register deleted functions with
8912         gdbarch.
8913
8914 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8915
8916         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8917         (riscv_unwind_pc): Delete.
8918         (riscv_unwind_sp): Delete.
8919         (riscv_gdbarch_init): Don't register deleted functions with
8920         gdbarch.
8921
8922 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8923
8924         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8925         (csky_unwind_pc): Delete.
8926         (csky_unwind_sp): Delete.
8927         (csky_gdbarch_init): Don't register deleted functions with
8928         gdbarch.
8929
8930 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8931
8932         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8933         (cris_unwind_pc): Delete.
8934         (cris_unwind_sp): Delete.
8935         (cris_gdbarch_init): Don't register deleted functions with
8936         gdbarch.
8937
8938 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8939
8940         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8941         (bfin_unwind_pc): Delete.
8942         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8943
8944 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8945
8946         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8947         (arm_unwind_pc): Delete.
8948         (arm_unwind_sp): Delete.
8949         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8950
8951 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8952
8953         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8954         (arc_unwind_pc): Delete.
8955         (arc_unwind_sp): Delete.
8956         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8957
8958 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8959
8960         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8961         (alpha_unwind_pc): Delete.
8962         (alpha_gdbarch_init): Don't register deleted functions with
8963         gdbarch.
8964
8965 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8966
8967         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8968         (aarch64_unwind_pc): Delete.
8969         (aarch64_unwind_sp): Delete.
8970         (aarch64_gdbarch_init): Don't register deleted functions with
8971         gdbarch.
8972
8973 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8974
8975         * gdbtypes.c (type_align): Don't consider static members when
8976         computing structure alignment.
8977
8978 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8979
8980         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8981         return 0 for other types.
8982         * arch-utils.c (default_type_align): Always return 0.
8983         * gdbarch.h: Regenerate.
8984         * gdbarch.sh (type_align): Extend comment.
8985         * gdbtypes.c (type_align): Add additional comments, always call
8986         gdbarch_type_align before applying the default rules.
8987         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8988         generic code will then apply a suitable default.
8989         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8990         types, return 0 for other types.
8991
8992 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8993
8994         * NEWS: Create a new section for the next release branch.
8995         Rename the section of the current branch, now that it has
8996         been cut.
8997
8998 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8999
9000         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9001         * version.in: Bump version to 8.3.50.DATE-git.
9002
9003 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9004
9005         * aix-thread.c (ptid_cmp): Remove unused variable.
9006         (get_signaled_thread): Likewise.
9007         (store_regs_user_thread): Likewise.
9008         (store_regs_kernel_thread): Likewise.
9009         (fetch_regs_kernel_thread): Remove shadowed variable.
9010
9011 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9012
9013         * features/riscv/32bit-cpu.xml: Add register numbers.
9014         * features/riscv/32bit-fpu.c: Regenerate.
9015         * features/riscv/32bit-fpu.xml: Add register numbers.
9016         * features/riscv/64bit-cpu.xml: Add register numbers.
9017         * features/riscv/64bit-fpu.c: Regenerate.
9018         * features/riscv/64bit-fpu.xml: Add register numbers.
9019
9020 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9021
9022         * NEWS: Mention two argument form of gdb.Value constructor.
9023         * python/py-value.c (convert_buffer_and_type_to_value): New
9024         function.
9025         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9026         Add support for handling an optional second argument.  Call
9027         convert_buffer_and_type_to_value as appropriate.
9028         * python/python-internal.h (Py_buffer_deleter): New struct.
9029         (Py_buffer_up): New typedef.
9030
9031 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9032
9033         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9034         instead of releasing ownership.
9035
9036 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9037
9038         * dwarf2read.c (open_and_init_dwp_file): Call
9039         elf_numsections instead of bfd_count_sections to initialize
9040         dwp_file->num_sections.
9041
9042 2019-02-25  Tom Tromey  <tromey@adacore.com>
9043
9044         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9045
9046 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9047
9048         * gcore.in: Add '--readnever' option when invoking GDB.
9049
9050 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9051
9052         * MAINTAINERS: Update my email address.
9053
9054 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9055
9056         * build-id.c (build_id_to_debug_bfd_1): New function.
9057         (build_id_to_debug_bfd): Look for separate debug file in
9058         sysroot.
9059
9060 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9061
9062         * gdbarch.sh: Update the copyright year range that is placed into
9063         generated files.
9064
9065 2019-02-22  Keith Seitz  <keiths@redhat.com>
9066
9067         PR symtab/23853
9068         * linespec.c (create_sals_line_offset): Search for the default
9069         symtab's filename instead of its fullname.
9070
9071 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9072
9073         * NEWS: Update style defaults.
9074
9075 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9076
9077         * main.c (captured_main_1): Disable styling in batch mode.
9078
9079 2019-02-20  Tom Tromey  <tom@tromey.com>
9080
9081         * symtab.c (symtab_symbol_info): Fix typos.
9082
9083 2019-02-20  Tom Tromey  <tromey@adacore.com>
9084
9085         * findcmd.c (_initialize_mem_search): Use upper case for
9086         metasyntactic variables.
9087
9088 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9089
9090         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9091         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9092
9093 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9094
9095         * top.h (source_file_name): Change to std::string.
9096         * top.c (source_file_name): Likewise.
9097         (command_line_input): Adjust.
9098         * cli/cli-script.c (script_from_file): Adjust.
9099
9100 2019-02-19  Tom Tromey  <tromey@adacore.com>
9101
9102         * ravenscar-thread.c
9103         (ravenscar_thread_target::update_thread_list): Don't call
9104         ada_build_task_list.
9105         * ada-lang.h (ada_build_task_list): Don't declare.
9106         * ada-tasks.c (struct ada_tasks_inferior_data)
9107         <task_list_valid_p>: Now bool.
9108         (read_known_tasks, ada_task_list_changed)
9109         (ada_tasks_invalidate_inferior_data): Update.
9110         (read_known_tasks_array): Return bool.
9111         (read_known_tasks_list): Likewise.
9112         (read_known_tasks): Return void.
9113         (ada_build_task_list): Now static.
9114
9115 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9116
9117         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9118         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9119
9120 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9121
9122         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9123         variant for ada_tasks_pspace_data_handle and
9124         ada_tasks_inferior_data_handle.
9125         (ada_tasks_pspace_data_cleanup): New function.
9126         (ada_tasks_inferior_data_cleanup): New function.
9127
9128 2019-02-17  Tom Tromey  <tom@tromey.com>
9129
9130         * macrotab.h (macro_source_fullname): Return a std::string.
9131         * macrotab.c (macro_include, check_for_redefinition)
9132         (macro_undef, macro_lookup_definition, foreach_macro)
9133         (foreach_macro_in_scope): Update.
9134         (macro_source_fullname): Return a std::string.
9135         * macrocmd.c (show_pp_source_pos): Update.
9136
9137 2019-02-17  Tom Tromey  <tom@tromey.com>
9138
9139         * macrocmd.c (show_pp_source_pos): Style the file names.
9140
9141 2019-02-17  Tom Tromey  <tom@tromey.com>
9142
9143         PR tui/24197:
9144         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9145
9146 2019-02-17  Tom Tromey  <tom@tromey.com>
9147
9148         * ada-lang.c (user_select_syms): Use filtered printing.
9149         * utils.c (wrap_style): New global.
9150         (desired_style): Remove.
9151         (emit_style_escape): Add stream parameter.
9152         (set_output_style, reset_terminal_style, prompt_for_continue):
9153         Update.
9154         (flush_wrap_buffer): Only flush gdb_stdout.
9155         (wrap_here): Set wrap_style.
9156         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9157         treat escape sequences as a character.  Change when wrap buffer is
9158         flushed.
9159         (fputs_styled): Do not set the output style when the default is
9160         requested.
9161         * ui-style.h (struct ui_file_style) <is_default>: New method.
9162         * source.c (print_source_lines_base): Emit escape sequences in one
9163         piece.
9164
9165 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9166
9167         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9168         integers and enumeration types.
9169
9170 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9171
9172         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9173         instead of lookup_symbol_in_language
9174         (do_exact_match): New function.
9175         (ada_get_symbol_name_matcher): Return do_exact_match when
9176         doing a verbatim match.
9177
9178 2019-02-15  Tom Tromey  <tromey@adacore.com>
9179
9180         * ravenscar-thread.c (ravenscar_thread_target::resume)
9181         (ravenscar_thread_target::wait): Special case wildcard requests.
9182
9183 2019-02-15  Tom Tromey  <tromey@adacore.com>
9184
9185         * ravenscar-thread.c (base_ptid): Remove.
9186         (struct ravenscar_thread_target) <close>: New method.
9187         <m_base_ptid>: New member.
9188         <update_inferior_ptid, active_task, task_is_currently_active,
9189         runtime_initialized>: Declare methods.
9190         <ravenscar_thread_target>: Add constructor.
9191         (ravenscar_thread_target::task_is_currently_active)
9192         (ravenscar_thread_target::update_inferior_ptid)
9193         (ravenscar_runtime_initialized): Rename.  Now methods.
9194         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9195         (ravenscar_thread_target::update_thread_list): Update.
9196         (ravenscar_thread_target::active_task): Now method.
9197         (ravenscar_thread_target::store_registers)
9198         (ravenscar_thread_target::prepare_to_store)
9199         (ravenscar_thread_target::prepare_to_store)
9200         (ravenscar_thread_target::mourn_inferior): Update.
9201         (ravenscar_inferior_created): Use "new" to create target.
9202         (ravenscar_thread_target::get_ada_task_ptid): Update.
9203         (_initialize_ravenscar): Don't initialize base_ptid.
9204         (ravenscar_ops): Remove global.
9205
9206 2019-02-15  Tom Tromey  <tromey@adacore.com>
9207
9208         * target.h (push_target): Declare new overload.
9209         * target.c (push_target): New overload, taking an rvalue reference.
9210         * remote.c (remote_target::open_1): Use push_target overload.
9211         * corelow.c (core_target_open): Use push_target overload.
9212
9213 2019-02-15  Tom Tromey  <tromey@adacore.com>
9214
9215         * ravenscar-thread.c (is_ravenscar_task)
9216         (ravenscar_task_is_currently_active): Return bool.
9217         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9218         (_initialize_ravenscar): Remove "(void)".
9219         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9220         Return bool.
9221
9222 2019-02-15  Tom Tromey  <tromey@adacore.com>
9223
9224         * ravenscar-thread.c (ravenscar_runtime_initializer)
9225         (has_ravenscar_runtime, get_running_thread_id)
9226         (ravenscar_thread_target::resume): Fix indentation.
9227
9228 2019-02-15  Tom Tromey  <tromey@adacore.com>
9229
9230         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9231         from ravenscar_arch_ops.
9232         (sparc_ravenscar_ops::fetch_registers)
9233         (sparc_ravenscar_ops::store_registers): Now methods.
9234         (sparc_ravenscar_prepare_to_store): Remove.
9235         (sparc_ravenscar_ops): Redefine.
9236         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9237         methods and destructor.  Remove members.
9238         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9239         (ravenscar_thread_target::store_registers)
9240         (ravenscar_thread_target::prepare_to_store): Update.
9241         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9242         Remove.
9243         (struct ppc_ravenscar_powerpc_ops): Derive from
9244         ravenscar_arch_ops.
9245         (ppc_ravenscar_powerpc_ops::fetch_registers)
9246         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9247         (ppc_ravenscar_powerpc_ops): Redefine.
9248         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9249         (ppc_ravenscar_e500_ops::fetch_registers)
9250         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9251         (ppc_ravenscar_e500_ops): Redefine.
9252         * aarch64-ravenscar-thread.c
9253         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9254         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9255         (aarch64_ravenscar_fetch_registers)
9256         (aarch64_ravenscar_store_registers): Now methods.
9257         (aarch64_ravenscar_ops): Redefine.
9258
9259 2019-02-15  Tom Tromey  <tromey@adacore.com>
9260
9261         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9262         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9263         (ravenscar_thread_target::stopped_by_watchpoint)
9264         (ravenscar_thread_target::stopped_data_address)
9265         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9266
9267 2019-02-15  Tom Tromey  <tromey@adacore.com>
9268
9269         * ravenscar-thread.c: Fix some typos.
9270
9271 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9272             Tom Tromey  <tromey@adacore.com>
9273
9274         * ada-lang.c (ada_exception_sal): Change addr_string to a
9275         std::string.
9276         (create_ada_exception_catchpoint): Update.
9277
9278 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9279             Tom Tromey  <tromey@adacore.com>
9280
9281         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9282         (bp_location_ops): Remove.
9283         (base_breakpoint_allocate_location): Update.
9284         (free_bp_location): Update.
9285         * ada-lang.c (class ada_catchpoint_location)
9286         <ada_catchpoint_location>: Remove ops parameter.
9287         (ada_catchpoint_location_dtor): Remove.
9288         (ada_catchpoint_location_ops): Remove.
9289         (allocate_location_exception): Update.
9290         * breakpoint.h (struct bp_location_ops): Remove.
9291         (class bp_location) <bp_location>: Remove bp_location_ops
9292         parameter.
9293         <~bp_location>: Add destructor.
9294         <ops>: Remove.
9295
9296 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9297             Pedro Alves  <palves@redhat.com>
9298
9299         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9300         'PATH_MAX'.
9301
9302 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9303             Samuel Thibault  <samuel.thibault@gnu.org>
9304             Thomas Schwinge  <thomas@codesourcery.com>
9305
9306         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9307         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9308
9309 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9310
9311         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9312         (check_empty): Use "const char *".
9313
9314         * gnu-nat.c (gnu_nat_target::detach): Instead of
9315         'detach_inferior (pid)' call
9316         'detach_inferior (find_inferior_pid (pid))'.
9317
9318         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9319         'nat/fork-inferior.o'.
9320         * gnu-nat.c: #include "nat/fork-inferior.h".
9321
9322         * gnu-nat.c (gnu_nat_target::detach): Instead of
9323         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9324         * gnu-nat.h: #include "inf-child.h".
9325         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9326         'i386_gnu_nat_target::fetch_registers'.
9327         (gnu_store_registers): Rename/move to
9328         'i386_gnu_nat_target::store_registers'.
9329
9330         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9331         * gnu-nat.h (mach_thread_info): New function.
9332         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9333
9334         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9335
9336 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9337
9338         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9339
9340 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9341
9342         * windows-nat.c (windows_add_thread): Add new parameter
9343         "main_thread_p" with default value set to false.  Update
9344         function documentation as well as all callers.
9345         (windows_delete_thread): Likewise.
9346         (fake_create_process): Update call to windows_add_thread.
9347         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9348         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9349         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9350         call to windows_delete_thread.
9351
9352 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9353
9354         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9355
9356 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9357
9358         * symfile.c (find_separate_debug_file): Use canonical path of
9359         sysroot with child_path instead of gdb_sysroot if it is valid.
9360
9361 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9362
9363         * symfile.c (find_separate_debug_file): Use child_path to
9364         determine if an object file is under a sysroot.
9365
9366 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9367
9368         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9369         unittests/child-path-selftests.c.
9370         * common/pathstuff.c (child_path): New function.
9371         * common/pathstuff.h (child_path): New prototype.
9372         * unittests/child-path-selftests.c: New file.
9373
9374 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9375
9376         * symfile.c (find_separate_debug_file): Look for separate debug
9377         files in debug directories under the sysroot.
9378
9379 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9380
9381         * symtab.h (struct minimal_symbol data_p): New const method.
9382         (struct minimal_symbol text_p): Likewise.
9383         * symtab.c (output_source_filename): Use file name style
9384         to print file name.
9385         (print_symbol_info): Likewise.
9386         (print_msymbol_info): Use address style to print addresses.
9387         Use function name style to print executable text symbols.
9388         (expand_symtab_containing_pc): Use data_p.
9389         (find_pc_sect_compunit_symtab): Likewise.
9390
9391 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9392
9393         * breakpoint.c (describe_other_breakpoints): Use address style
9394         to print addresses.
9395         (say_where): Likewise.
9396
9397 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9398
9399         * ada-typeprint.c (print_func_type): Print function name
9400         style to print function name.
9401         * c-typeprint.c (c_print_type_1): Likewise.
9402
9403 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9404
9405         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9406         for execve.
9407
9408 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9409
9410         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9411         type_stack.
9412
9413 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9414
9415         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9416         TYPE_CODE_REF types.
9417
9418 2019-02-08  Jim Wilson  <jimw@sifive.com>
9419
9420         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9421         (riscv_linux_fregset): New.
9422         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9423
9424 2019-02-07  Tom Tromey  <tom@tromey.com>
9425
9426         * thread.c (thread_cancel_execution_command): Update.
9427         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9428         methods.
9429         (struct thread_fsm_ops): Remove.
9430         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9431         (thread_fsm_should_stop, thread_fsm_return_value)
9432         (thread_fsm_set_finished, thread_fsm_finished_p)
9433         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9434         Don't declare.
9435         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9436         * infrun.c (clear_proceed_status_thread)
9437         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9438         (print_stop_event): Update.
9439         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9440         Add constructor.
9441         (step_command_fsm_ops): Remove.
9442         (new_step_command_fsm): Remove.
9443         (step_1): Update.
9444         (step_command_fsm::should_stop): Rename from
9445         step_command_fsm_should_stop.
9446         (step_command_fsm::clean_up): Rename from
9447         step_command_fsm_clean_up.
9448         (step_command_fsm::do_async_reply_reason): Rename from
9449         step_command_fsm_async_reply_reason.
9450         (struct until_next_fsm): Inherit from thread_fsm.  Add
9451         constructor.
9452         (until_next_fsm_ops): Remove.
9453         (new_until_next_fsm): Remove.
9454         (until_next_fsm::should_stop): Rename from
9455         until_next_fsm_should_stop.
9456         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9457         (until_next_fsm::do_async_reply_reason): Rename from
9458         until_next_fsm_async_reply_reason.
9459         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9460         constructor.  Change type of breakpoint.
9461         (finish_command_fsm_ops): Remove.
9462         (new_finish_command_fsm): Remove.
9463         (finish_command_fsm::should_stop): Rename from
9464         finish_command_fsm_should_stop.
9465         (finish_command_fsm::clean_up): Rename from
9466         finish_command_fsm_clean_up.
9467         (finish_command_fsm::return_value): Rename from
9468         finish_command_fsm_return_value.
9469         (finish_command_fsm::do_async_reply_reason): Rename from
9470         finish_command_fsm_async_reply_reason.
9471         (finish_command): Update.
9472         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9473         Add constructor.
9474         (call_thread_fsm_ops): Remove.
9475         (call_thread_fsm::call_thread_fsm): Rename from
9476         new_call_thread_fsm.
9477         (call_thread_fsm::should_stop): Rename from
9478         call_thread_fsm_should_stop.
9479         (call_thread_fsm::should_notify_stop): Rename from
9480         call_thread_fsm_should_notify_stop.
9481         (run_inferior_call, call_function_by_hand_dummy): Update.
9482         * cli/cli-interp.c (should_print_stop_to_console): Update.
9483         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9484         Add constructor.  Change type of location_breakpoint,
9485         caller_breakpoint.
9486         (until_break_fsm_ops): Remove.
9487         (new_until_break_fsm): Remove.
9488         (until_break_fsm::should_stop): Rename from
9489         until_break_fsm_should_stop.
9490         (until_break_fsm::clean_up): Rename from
9491         until_break_fsm_clean_up.
9492         (until_break_fsm::do_async_reply_reason): Rename from
9493         until_break_fsm_async_reply_reason.
9494         (until_break_command): Update.
9495         * thread-fsm.c: Remove.
9496         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9497
9498 2019-02-07  Tom Tromey  <tom@tromey.com>
9499
9500         * yy-remap.h: Add include guard.
9501         * xtensa-tdep.h: Add include guard.
9502         * xcoffread.h: Rename include guard.
9503         * varobj-iter.h: Add include guard.
9504         * tui/tui.h: Rename include guard.
9505         * tui/tui-winsource.h: Rename include guard.
9506         * tui/tui-wingeneral.h: Rename include guard.
9507         * tui/tui-windata.h: Rename include guard.
9508         * tui/tui-win.h: Rename include guard.
9509         * tui/tui-stack.h: Rename include guard.
9510         * tui/tui-source.h: Rename include guard.
9511         * tui/tui-regs.h: Rename include guard.
9512         * tui/tui-out.h: Rename include guard.
9513         * tui/tui-layout.h: Rename include guard.
9514         * tui/tui-io.h: Rename include guard.
9515         * tui/tui-hooks.h: Rename include guard.
9516         * tui/tui-file.h: Rename include guard.
9517         * tui/tui-disasm.h: Rename include guard.
9518         * tui/tui-data.h: Rename include guard.
9519         * tui/tui-command.h: Rename include guard.
9520         * tic6x-tdep.h: Add include guard.
9521         * target/waitstatus.h: Rename include guard.
9522         * target/wait.h: Rename include guard.
9523         * target/target.h: Rename include guard.
9524         * target/resume.h: Rename include guard.
9525         * target-float.h: Rename include guard.
9526         * stabsread.h: Add include guard.
9527         * rs6000-tdep.h: Add include guard.
9528         * riscv-fbsd-tdep.h: Add include guard.
9529         * regformats/regdef.h: Rename include guard.
9530         * record.h: Rename include guard.
9531         * python/python.h: Rename include guard.
9532         * python/python-internal.h: Rename include guard.
9533         * python/py-stopevent.h: Rename include guard.
9534         * python/py-ref.h: Rename include guard.
9535         * python/py-record.h: Rename include guard.
9536         * python/py-record-full.h: Rename include guard.
9537         * python/py-record-btrace.h: Rename include guard.
9538         * python/py-instruction.h: Rename include guard.
9539         * python/py-events.h: Rename include guard.
9540         * python/py-event.h: Rename include guard.
9541         * procfs.h: Add include guard.
9542         * proc-utils.h: Add include guard.
9543         * p-lang.h: Add include guard.
9544         * or1k-tdep.h: Rename include guard.
9545         * observable.h: Rename include guard.
9546         * nto-tdep.h: Rename include guard.
9547         * nat/x86-linux.h: Rename include guard.
9548         * nat/x86-linux-dregs.h: Rename include guard.
9549         * nat/x86-gcc-cpuid.h: Add include guard.
9550         * nat/x86-dregs.h: Rename include guard.
9551         * nat/x86-cpuid.h: Rename include guard.
9552         * nat/ppc-linux.h: Rename include guard.
9553         * nat/mips-linux-watch.h: Rename include guard.
9554         * nat/linux-waitpid.h: Rename include guard.
9555         * nat/linux-ptrace.h: Rename include guard.
9556         * nat/linux-procfs.h: Rename include guard.
9557         * nat/linux-osdata.h: Rename include guard.
9558         * nat/linux-nat.h: Rename include guard.
9559         * nat/linux-namespaces.h: Rename include guard.
9560         * nat/linux-btrace.h: Rename include guard.
9561         * nat/glibc_thread_db.h: Rename include guard.
9562         * nat/gdb_thread_db.h: Rename include guard.
9563         * nat/gdb_ptrace.h: Rename include guard.
9564         * nat/fork-inferior.h: Rename include guard.
9565         * nat/amd64-linux-siginfo.h: Rename include guard.
9566         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9567         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9568         * nat/aarch64-linux.h: Rename include guard.
9569         * nat/aarch64-linux-hw-point.h: Rename include guard.
9570         * mn10300-tdep.h: Add include guard.
9571         * mips-linux-tdep.h: Add include guard.
9572         * mi/mi-parse.h: Rename include guard.
9573         * mi/mi-out.h: Rename include guard.
9574         * mi/mi-main.h: Rename include guard.
9575         * mi/mi-interp.h: Rename include guard.
9576         * mi/mi-getopt.h: Rename include guard.
9577         * mi/mi-console.h: Rename include guard.
9578         * mi/mi-common.h: Rename include guard.
9579         * mi/mi-cmds.h: Rename include guard.
9580         * mi/mi-cmd-break.h: Rename include guard.
9581         * m2-lang.h: Add include guard.
9582         * location.h: Rename include guard.
9583         * linux-record.h: Rename include guard.
9584         * linux-nat.h: Add include guard.
9585         * linux-fork.h: Add include guard.
9586         * i386-darwin-tdep.h: Rename include guard.
9587         * hppa-linux-offsets.h: Add include guard.
9588         * guile/guile.h: Rename include guard.
9589         * guile/guile-internal.h: Rename include guard.
9590         * gnu-nat.h: Rename include guard.
9591         * gdb-stabs.h: Rename include guard.
9592         * frv-tdep.h: Add include guard.
9593         * f-lang.h: Add include guard.
9594         * event-loop.h: Add include guard.
9595         * darwin-nat.h: Rename include guard.
9596         * cp-abi.h: Rename include guard.
9597         * config/sparc/nm-sol2.h: Rename include guard.
9598         * config/nm-nto.h: Rename include guard.
9599         * config/nm-linux.h: Add include guard.
9600         * config/i386/nm-i386gnu.h: Rename include guard.
9601         * config/djgpp/nl_types.h: Rename include guard.
9602         * config/djgpp/langinfo.h: Rename include guard.
9603         * compile/gcc-cp-plugin.h: Add include guard.
9604         * compile/gcc-c-plugin.h: Add include guard.
9605         * compile/compile.h: Rename include guard.
9606         * compile/compile-object-run.h: Rename include guard.
9607         * compile/compile-object-load.h: Rename include guard.
9608         * compile/compile-internal.h: Rename include guard.
9609         * compile/compile-cplus.h: Rename include guard.
9610         * compile/compile-c.h: Rename include guard.
9611         * common/xml-utils.h: Rename include guard.
9612         * common/x86-xstate.h: Rename include guard.
9613         * common/version.h: Rename include guard.
9614         * common/vec.h: Rename include guard.
9615         * common/tdesc.h: Rename include guard.
9616         * common/selftest.h: Rename include guard.
9617         * common/scoped_restore.h: Rename include guard.
9618         * common/scoped_mmap.h: Rename include guard.
9619         * common/scoped_fd.h: Rename include guard.
9620         * common/safe-iterator.h: Rename include guard.
9621         * common/run-time-clock.h: Rename include guard.
9622         * common/refcounted-object.h: Rename include guard.
9623         * common/queue.h: Rename include guard.
9624         * common/ptid.h: Rename include guard.
9625         * common/print-utils.h: Rename include guard.
9626         * common/preprocessor.h: Rename include guard.
9627         * common/pathstuff.h: Rename include guard.
9628         * common/observable.h: Rename include guard.
9629         * common/netstuff.h: Rename include guard.
9630         * common/job-control.h: Rename include guard.
9631         * common/host-defs.h: Rename include guard.
9632         * common/gdb_wait.h: Rename include guard.
9633         * common/gdb_vecs.h: Rename include guard.
9634         * common/gdb_unlinker.h: Rename include guard.
9635         * common/gdb_unique_ptr.h: Rename include guard.
9636         * common/gdb_tilde_expand.h: Rename include guard.
9637         * common/gdb_sys_time.h: Rename include guard.
9638         * common/gdb_string_view.h: Rename include guard.
9639         * common/gdb_splay_tree.h: Rename include guard.
9640         * common/gdb_setjmp.h: Rename include guard.
9641         * common/gdb_ref_ptr.h: Rename include guard.
9642         * common/gdb_optional.h: Rename include guard.
9643         * common/gdb_locale.h: Rename include guard.
9644         * common/gdb_assert.h: Rename include guard.
9645         * common/filtered-iterator.h: Rename include guard.
9646         * common/filestuff.h: Rename include guard.
9647         * common/fileio.h: Rename include guard.
9648         * common/environ.h: Rename include guard.
9649         * common/common-utils.h: Rename include guard.
9650         * common/common-types.h: Rename include guard.
9651         * common/common-regcache.h: Rename include guard.
9652         * common/common-inferior.h: Rename include guard.
9653         * common/common-gdbthread.h: Rename include guard.
9654         * common/common-exceptions.h: Rename include guard.
9655         * common/common-defs.h: Rename include guard.
9656         * common/common-debug.h: Rename include guard.
9657         * common/cleanups.h: Rename include guard.
9658         * common/buffer.h: Rename include guard.
9659         * common/btrace-common.h: Rename include guard.
9660         * common/break-common.h: Rename include guard.
9661         * cli/cli-utils.h: Rename include guard.
9662         * cli/cli-style.h: Rename include guard.
9663         * cli/cli-setshow.h: Rename include guard.
9664         * cli/cli-script.h: Rename include guard.
9665         * cli/cli-interp.h: Rename include guard.
9666         * cli/cli-decode.h: Rename include guard.
9667         * cli/cli-cmds.h: Rename include guard.
9668         * charset-list.h: Add include guard.
9669         * buildsym-legacy.h: Rename include guard.
9670         * bfin-tdep.h: Add include guard.
9671         * ax.h: Rename include guard.
9672         * arm-linux-tdep.h: Add include guard.
9673         * arm-fbsd-tdep.h: Add include guard.
9674         * arch/xtensa.h: Rename include guard.
9675         * arch/tic6x.h: Add include guard.
9676         * arch/i386.h: Add include guard.
9677         * arch/arm.h: Rename include guard.
9678         * arch/arm-linux.h: Rename include guard.
9679         * arch/arm-get-next-pcs.h: Rename include guard.
9680         * arch/amd64.h: Add include guard.
9681         * arch/aarch64-insn.h: Rename include guard.
9682         * arch-utils.h: Rename include guard.
9683         * annotate.h: Add include guard.
9684         * amd64-darwin-tdep.h: Rename include guard.
9685         * aarch64-linux-tdep.h: Add include guard.
9686         * aarch64-fbsd-tdep.h: Add include guard.
9687         * aarch32-linux-nat.h: Add include guard.
9688
9689 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9690
9691         * macrotab.c (macro_define_internal): New function that
9692         factorizes macro_define_object_internal and macro_define_function
9693         code.
9694         (macro_define_object_internal): Use macro_define_internal.
9695         (macro_define_function): Likewise.
9696
9697 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9698
9699         * macrocmd.c (extract_identifier): Return
9700         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9701         callers.
9702
9703 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9704
9705         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9706
9707 2019-02-05  Tom Tromey  <tom@tromey.com>
9708
9709         * target.c (target_stack::unpush): Move assertion earlier.
9710
9711 2019-01-30  Tom Tromey  <tom@tromey.com>
9712
9713         PR python/23615:
9714         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9715         (gdbpy_parse_and_eval): Likewise.
9716         * python/python-internal.h (gdbpy_allow_threads): New class.
9717
9718 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9719
9720         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9721         (aarch64_fbsd_fpregmap): Move earlier.
9722         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9723         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9724         instead of individual calls to trad_frame_set_reg_addr.
9725         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9726         earlier.
9727         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9728         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9729         instead of individual calls to trad_frame_set_reg_addr.
9730
9731 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9732
9733         * CONTRIBUTE: Replace contribution list with wiki link.
9734
9735 2019-01-25  Tom Tromey  <tom@tromey.com>
9736
9737         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9738
9739 2019-01-25  Tom Tromey  <tom@tromey.com>
9740
9741         * xtensa-linux-nat.c: Fix common/ includes.
9742         * xml-support.h: Fix common/ includes.
9743         * xml-support.c: Fix common/ includes.
9744         * x86-linux-nat.c: Fix common/ includes.
9745         * windows-nat.c: Fix common/ includes.
9746         * varobj.h: Fix common/ includes.
9747         * varobj.c: Fix common/ includes.
9748         * value.c: Fix common/ includes.
9749         * valops.c: Fix common/ includes.
9750         * utils.c: Fix common/ includes.
9751         * unittests/xml-utils-selftests.c: Fix common/ includes.
9752         * unittests/utils-selftests.c: Fix common/ includes.
9753         * unittests/unpack-selftests.c: Fix common/ includes.
9754         * unittests/tracepoint-selftests.c: Fix common/ includes.
9755         * unittests/style-selftests.c: Fix common/ includes.
9756         * unittests/string_view-selftests.c: Fix common/ includes.
9757         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9758         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9759         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9760         * unittests/rsp-low-selftests.c: Fix common/ includes.
9761         * unittests/parse-connection-spec-selftests.c: Fix common/
9762         includes.
9763         * unittests/optional-selftests.c: Fix common/ includes.
9764         * unittests/offset-type-selftests.c: Fix common/ includes.
9765         * unittests/observable-selftests.c: Fix common/ includes.
9766         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9767         * unittests/memrange-selftests.c: Fix common/ includes.
9768         * unittests/memory-map-selftests.c: Fix common/ includes.
9769         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9770         * unittests/function-view-selftests.c: Fix common/ includes.
9771         * unittests/environ-selftests.c: Fix common/ includes.
9772         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9773         * unittests/common-utils-selftests.c: Fix common/ includes.
9774         * unittests/cli-utils-selftests.c: Fix common/ includes.
9775         * unittests/array-view-selftests.c: Fix common/ includes.
9776         * ui-file.c: Fix common/ includes.
9777         * tui/tui-io.c: Fix common/ includes.
9778         * tracepoint.h: Fix common/ includes.
9779         * tracepoint.c: Fix common/ includes.
9780         * tracefile-tfile.c: Fix common/ includes.
9781         * top.h: Fix common/ includes.
9782         * top.c: Fix common/ includes.
9783         * thread.c: Fix common/ includes.
9784         * target/waitstatus.h: Fix common/ includes.
9785         * target/waitstatus.c: Fix common/ includes.
9786         * target.h: Fix common/ includes.
9787         * target.c: Fix common/ includes.
9788         * target-memory.c: Fix common/ includes.
9789         * target-descriptions.c: Fix common/ includes.
9790         * symtab.h: Fix common/ includes.
9791         * symfile.c: Fix common/ includes.
9792         * stap-probe.c: Fix common/ includes.
9793         * spu-linux-nat.c: Fix common/ includes.
9794         * sparc-nat.c: Fix common/ includes.
9795         * source.c: Fix common/ includes.
9796         * solib.c: Fix common/ includes.
9797         * solib-target.c: Fix common/ includes.
9798         * ser-unix.c: Fix common/ includes.
9799         * ser-tcp.c: Fix common/ includes.
9800         * ser-pipe.c: Fix common/ includes.
9801         * ser-base.c: Fix common/ includes.
9802         * selftest-arch.c: Fix common/ includes.
9803         * s12z-tdep.c: Fix common/ includes.
9804         * rust-exp.y: Fix common/ includes.
9805         * rs6000-aix-tdep.c: Fix common/ includes.
9806         * riscv-tdep.c: Fix common/ includes.
9807         * remote.c: Fix common/ includes.
9808         * remote-notif.h: Fix common/ includes.
9809         * remote-fileio.h: Fix common/ includes.
9810         * remote-fileio.c: Fix common/ includes.
9811         * regcache.h: Fix common/ includes.
9812         * regcache.c: Fix common/ includes.
9813         * record-btrace.c: Fix common/ includes.
9814         * python/python.c: Fix common/ includes.
9815         * python/py-type.c: Fix common/ includes.
9816         * python/py-inferior.c: Fix common/ includes.
9817         * progspace.h: Fix common/ includes.
9818         * producer.c: Fix common/ includes.
9819         * procfs.c: Fix common/ includes.
9820         * proc-api.c: Fix common/ includes.
9821         * printcmd.c: Fix common/ includes.
9822         * ppc-linux-nat.c: Fix common/ includes.
9823         * parser-defs.h: Fix common/ includes.
9824         * osdata.c: Fix common/ includes.
9825         * obsd-nat.c: Fix common/ includes.
9826         * nat/x86-linux.c: Fix common/ includes.
9827         * nat/x86-linux-dregs.c: Fix common/ includes.
9828         * nat/x86-dregs.h: Fix common/ includes.
9829         * nat/x86-dregs.c: Fix common/ includes.
9830         * nat/ppc-linux.c: Fix common/ includes.
9831         * nat/mips-linux-watch.h: Fix common/ includes.
9832         * nat/mips-linux-watch.c: Fix common/ includes.
9833         * nat/linux-waitpid.c: Fix common/ includes.
9834         * nat/linux-ptrace.h: Fix common/ includes.
9835         * nat/linux-ptrace.c: Fix common/ includes.
9836         * nat/linux-procfs.c: Fix common/ includes.
9837         * nat/linux-personality.c: Fix common/ includes.
9838         * nat/linux-osdata.c: Fix common/ includes.
9839         * nat/linux-namespaces.c: Fix common/ includes.
9840         * nat/linux-btrace.h: Fix common/ includes.
9841         * nat/linux-btrace.c: Fix common/ includes.
9842         * nat/fork-inferior.c: Fix common/ includes.
9843         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9844         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9845         * nat/aarch64-linux.c: Fix common/ includes.
9846         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9847         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9848         * namespace.h: Fix common/ includes.
9849         * mips-linux-tdep.c: Fix common/ includes.
9850         * minsyms.c: Fix common/ includes.
9851         * mi/mi-parse.h: Fix common/ includes.
9852         * mi/mi-main.c: Fix common/ includes.
9853         * mi/mi-cmd-env.c: Fix common/ includes.
9854         * memrange.h: Fix common/ includes.
9855         * memattr.c: Fix common/ includes.
9856         * maint.h: Fix common/ includes.
9857         * maint.c: Fix common/ includes.
9858         * main.c: Fix common/ includes.
9859         * machoread.c: Fix common/ includes.
9860         * location.c: Fix common/ includes.
9861         * linux-thread-db.c: Fix common/ includes.
9862         * linux-nat.c: Fix common/ includes.
9863         * linux-fork.c: Fix common/ includes.
9864         * inline-frame.c: Fix common/ includes.
9865         * infrun.c: Fix common/ includes.
9866         * inflow.c: Fix common/ includes.
9867         * inferior.h: Fix common/ includes.
9868         * inferior.c: Fix common/ includes.
9869         * infcmd.c: Fix common/ includes.
9870         * inf-ptrace.c: Fix common/ includes.
9871         * inf-child.c: Fix common/ includes.
9872         * ia64-linux-nat.c: Fix common/ includes.
9873         * i387-tdep.c: Fix common/ includes.
9874         * i386-tdep.c: Fix common/ includes.
9875         * i386-linux-tdep.c: Fix common/ includes.
9876         * i386-linux-nat.c: Fix common/ includes.
9877         * i386-go32-tdep.c: Fix common/ includes.
9878         * i386-fbsd-tdep.c: Fix common/ includes.
9879         * i386-fbsd-nat.c: Fix common/ includes.
9880         * guile/scm-type.c: Fix common/ includes.
9881         * guile/guile.c: Fix common/ includes.
9882         * go32-nat.c: Fix common/ includes.
9883         * gnu-nat.c: Fix common/ includes.
9884         * gdbthread.h: Fix common/ includes.
9885         * gdbarch-selftests.c: Fix common/ includes.
9886         * gdb_usleep.c: Fix common/ includes.
9887         * gdb_select.h: Fix common/ includes.
9888         * gdb_bfd.c: Fix common/ includes.
9889         * gcore.c: Fix common/ includes.
9890         * fork-child.c: Fix common/ includes.
9891         * findvar.c: Fix common/ includes.
9892         * fbsd-nat.c: Fix common/ includes.
9893         * event-top.c: Fix common/ includes.
9894         * event-loop.c: Fix common/ includes.
9895         * dwarf2read.c: Fix common/ includes.
9896         * dwarf2loc.c: Fix common/ includes.
9897         * dwarf2-frame.c: Fix common/ includes.
9898         * dwarf-index-cache.c: Fix common/ includes.
9899         * dtrace-probe.c: Fix common/ includes.
9900         * disasm-selftests.c: Fix common/ includes.
9901         * defs.h: Fix common/ includes.
9902         * csky-tdep.c: Fix common/ includes.
9903         * cp-valprint.c: Fix common/ includes.
9904         * cp-support.h: Fix common/ includes.
9905         * cp-support.c: Fix common/ includes.
9906         * corelow.c: Fix common/ includes.
9907         * completer.h: Fix common/ includes.
9908         * completer.c: Fix common/ includes.
9909         * compile/compile.c: Fix common/ includes.
9910         * compile/compile-loc2c.c: Fix common/ includes.
9911         * compile/compile-cplus-types.c: Fix common/ includes.
9912         * compile/compile-cplus-symbols.c: Fix common/ includes.
9913         * command.h: Fix common/ includes.
9914         * cli/cli-dump.c: Fix common/ includes.
9915         * cli/cli-cmds.c: Fix common/ includes.
9916         * charset.c: Fix common/ includes.
9917         * build-id.c: Fix common/ includes.
9918         * btrace.h: Fix common/ includes.
9919         * btrace.c: Fix common/ includes.
9920         * breakpoint.h: Fix common/ includes.
9921         * breakpoint.c: Fix common/ includes.
9922         * ax.h:
9923         (enum agent_op): Fix common/ includes.
9924         * ax-general.c (struct aop_map): Fix common/ includes.
9925         * ax-gdb.c: Fix common/ includes.
9926         * auxv.c: Fix common/ includes.
9927         * auto-load.c: Fix common/ includes.
9928         * arm-tdep.c: Fix common/ includes.
9929         * arch/riscv.c: Fix common/ includes.
9930         * arch/ppc-linux-common.c: Fix common/ includes.
9931         * arch/i386.c: Fix common/ includes.
9932         * arch/arm.c: Fix common/ includes.
9933         * arch/arm-linux.c: Fix common/ includes.
9934         * arch/arm-get-next-pcs.c: Fix common/ includes.
9935         * arch/amd64.c: Fix common/ includes.
9936         * arch/aarch64.c: Fix common/ includes.
9937         * arch/aarch64-insn.c: Fix common/ includes.
9938         * arch-utils.c: Fix common/ includes.
9939         * amd64-windows-tdep.c: Fix common/ includes.
9940         * amd64-tdep.c: Fix common/ includes.
9941         * amd64-sol2-tdep.c: Fix common/ includes.
9942         * amd64-obsd-tdep.c: Fix common/ includes.
9943         * amd64-nbsd-tdep.c: Fix common/ includes.
9944         * amd64-linux-tdep.c: Fix common/ includes.
9945         * amd64-linux-nat.c: Fix common/ includes.
9946         * amd64-fbsd-tdep.c: Fix common/ includes.
9947         * amd64-fbsd-nat.c: Fix common/ includes.
9948         * amd64-dicos-tdep.c: Fix common/ includes.
9949         * amd64-darwin-tdep.c: Fix common/ includes.
9950         * agent.c: Fix common/ includes.
9951         * ada-lang.h: Fix common/ includes.
9952         * ada-lang.c: Fix common/ includes.
9953         * aarch64-tdep.c: Fix common/ includes.
9954
9955 2019-01-25  Tom Tromey  <tom@tromey.com>
9956
9957         * common/create-version.sh: Use common/version.h.
9958
9959 2019-01-24  Pedro Alves  <palves@redhat.com>
9960
9961         * infrun.c (signal_stop, signal_print, signal_program)
9962         (signal_catch, signal_pass): Now arrays instead of pointers.
9963         (update_signals_program_target, do_target_resume)
9964         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9965         * linux-nat.c (linux_nat_target::pass_signals)
9966         (linux_nat_target::create_inferior, linux_nat_target::attach):
9967         Adjust.
9968         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9969         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9970         * procfs.c (procfs_target::pass_signals): Adjust.
9971         * record-full.c (record_full_target::resume): Adjust.
9972         * remote.c (remote_target::pass_signals)
9973         (remote_target::program_signals): Adjust.
9974         * target-debug.h (target_debug_print_signals): Now takes a
9975         gdb::array_view as parameter.  Adjust.
9976         * target.h (target_ops) <pass_signals, program_signals>: Replace
9977         pointer and length parameters with gdb::array_view.
9978         (target_pass_signals, target_program_signals): Likewise.
9979         * target-delegates.c: Regenerate.
9980
9981 2019-01-24  Pedro Alves  <palves@redhat.com>
9982
9983         * common/forward-scope-exit.h
9984         (forward_scope_exit::forward_scope_exit): Pass arguments to
9985         m_bind_function directly, instead of creating a std::bind and
9986         copying that.
9987
9988 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9989
9990         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9991         for static members.
9992         (pass_in_v_vfp_candidate): Likewise.
9993
9994 2019-01-23  Tom Tromey  <tom@tromey.com>
9995             Pedro Alves  <palves@redhat.com>
9996
9997         * regcache.c (class regcache_invalidator): Remove.
9998         (regcache::raw_write): Use make_scope_exit.
9999
10000 2019-01-23  Tom Tromey  <tom@tromey.com>
10001
10002         * ui-out.h (class ui_out_emit_type): Update comment.
10003
10004 2019-01-23  Tom Tromey  <tom@tromey.com>
10005
10006         * infrun.c (fetch_inferior_event): Update comment.
10007
10008 2019-01-23  Tom Tromey  <tom@tromey.com>
10009             Pedro Alves  <palves@redhat.com>
10010
10011         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10012         parameter.
10013         (fetch_inferior_event): Use SCOPE_EXIT.
10014
10015
10016 2019-01-23  Tom Tromey  <tom@tromey.com>
10017             Pedro Alves  <palves@redhat.com>
10018
10019         * infrun.c (disable_thread_events): Delete.
10020         (stop_all_threads): Use SCOPE_EXIT.
10021
10022 2019-01-23  Tom Tromey  <tom@tromey.com>
10023             Pedro Alves  <palves@redhat.com>
10024
10025         * symfile.c: Include forward-scope-exit.h.
10026         (clear_symtab_users_cleanup): Replace forward declaration with
10027         a FORWARD_SCOPE_EXIT.
10028         (syms_from_objfile_1): Use the forward_scope_exit and
10029         gdb::optional instead of cleanup_function.
10030         (reread_symbols): Use the forward_scope_exit instead of
10031         cleanup_function.
10032         (clear_symtab_users_cleanup): Remove function.
10033
10034 2019-01-23  Tom Tromey  <tom@tromey.com>
10035             Pedro Alves  <palves@redhat.com>
10036
10037         * linux-nat.c: Include scope-exit.h.
10038         (cleanup_target_stop): Remove.
10039         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10040         SCOPE_EXIT.
10041
10042 2019-01-23  Tom Tromey  <tom@tromey.com>
10043             Pedro Alves  <palves@redhat.com>
10044
10045         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10046         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10047
10048 2019-01-23  Tom Tromey  <tom@tromey.com>
10049             Andrew Burgess  <andrew.burgess@embecosm.com>
10050             Pedro Alves  <palves@redhat.com>
10051
10052         * infrun.c (fetch_inferior_event): Use scope_exit.
10053         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10054         * top.c (execute_command): Use scope_exit.
10055         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10056         * utils.c (do_bpstat_clear_actions_cleanup)
10057         (make_bpstat_clear_actions_cleanup): Remove.
10058
10059 2019-01-23  Tom Tromey  <tom@tromey.com>
10060             Pedro Alves  <palves@redhat.com>
10061
10062         * infrun.c: Include "common/scope-exit.h"
10063         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10064         (wait_for_inferior): Use SCOPE_EXIT.
10065         (fetch_inferior_event): Use scope_exit.
10066
10067 2019-01-23  Tom Tromey  <tom@tromey.com>
10068             Pedro Alves  <palves@redhat.com>
10069
10070         * breakpoint.c (create_breakpoint): Remove cleanup.
10071
10072 2019-01-23  Tom Tromey  <tom@tromey.com>
10073             Andrew Burgess  <andrew.burgess@embecosm.com>
10074             Pedro Alves  <palves@redhat.com>
10075
10076 2019-01-23  Pedro Alves  <palves@redhat.com>
10077
10078         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10079
10080 2019-01-23  Pedro Alves  <palves@redhat.com>
10081             Andrew Burgess  <andrew.burgess@embecosm.com>
10082
10083         * gdbthread.h: Include "common/forward-scope-exit.h".
10084         (scoped_finish_thread_state): Redefine custom class in terms of
10085         forward_scope_exit.
10086
10087 2019-01-23  Pedro Alves  <palves@redhat.com>
10088             Andrew Burgess  <andrew.burgess@embecosm.com>
10089
10090         * common/forward-scope-exit.h: New file.
10091
10092 2019-01-23  Pedro Alves  <palves@redhat.com>
10093             Andrew Burgess  <andrew.burgess@embecosm.com>
10094             Tom Tromey  <tom@tromey.com>
10095
10096         * common/scope-exit.h: New file.
10097
10098 2019-01-23  Pedro Alves  <palves@redhat.com>
10099
10100         * common/preprocessor.h (ESC): Rename to ...
10101         (ESC_PARENS): ... this.
10102         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10103         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10104
10105 2019-01-23  Tom Tromey  <tom@tromey.com>
10106
10107         * language.h (class scoped_switch_to_sym_language_if_auto):
10108         Initialize m_lang in both cases.
10109
10110 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10111
10112         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10113         with XCNEW.
10114
10115 2019-01-22  Tom Tromey  <tom@tromey.com>
10116
10117         * corelow.c: Do not include sys/file.h.
10118
10119 2019-01-22  Tom Tromey  <tom@tromey.com>
10120
10121         * tui/tui-wingeneral.h: Include gdb_curses.h.
10122
10123 2019-01-22  Tom Tromey  <tom@tromey.com>
10124
10125         * source-cache.h (class source_cache) <get_source_lines,
10126         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10127
10128 2019-01-22  Tom Tromey  <tom@tromey.com>
10129
10130         * remote-fileio.h (struct remote_target): Declare.
10131
10132 2019-01-22  Tom Tromey  <tom@tromey.com>
10133
10134         * python/py-arch.c: Do not include py-ref.h.
10135         * python/py-bpevent.c: Do not include py-ref.h.
10136         * python/py-cmd.c: Do not include py-ref.h.
10137         * python/py-continueevent.c: Do not include py-ref.h.
10138         * python/py-event.h: Do not include py-ref.h.
10139         * python/py-evtregistry.c: Do not include py-ref.h.
10140         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10141         * python/py-frame.c: Do not include py-ref.h.
10142         * python/py-framefilter.c: Do not include py-ref.h.
10143         * python/py-function.c: Do not include py-ref.h.
10144         * python/py-infevents.c: Do not include py-ref.h.
10145         * python/py-linetable.c: Do not include py-ref.h.
10146         * python/py-objfile.c: Do not include py-ref.h.
10147         * python/py-param.c: Do not include py-ref.h.
10148         * python/py-prettyprint.c: Do not include py-ref.h.
10149         * python/py-progspace.c: Do not include py-ref.h.
10150         * python/py-symbol.c: Do not include py-ref.h.
10151         * python/py-symtab.c: Do not include py-ref.h.
10152         * python/py-type.c: Do not include py-ref.h.
10153         * python/py-unwind.c: Do not include py-ref.h.
10154         * python/py-utils.c: Do not include py-ref.h.
10155         * python/py-value.c: Do not include py-ref.h.
10156         * python/py-varobj.c: Do not include py-ref.h.
10157         * python/py-xmethods.c: Do not include py-ref.h.
10158         * python/python.c: Do not include py-ref.h.
10159         * varobj.c: Do not include py-ref.h.
10160
10161 2019-01-22  Tom Tromey  <tom@tromey.com>
10162
10163         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10164         keyword for bcache.
10165
10166 2019-01-22  Tom Tromey  <tom@tromey.com>
10167
10168         * compile/compile-cplus-types.c: Remove a comment by #include.
10169
10170 2019-01-22  Tom Tromey  <tom@tromey.com>
10171
10172         * compile/gcc-c-plugin.h: Include compile-internal.h.
10173
10174 2019-01-22  Tom Tromey  <tom@tromey.com>
10175
10176         * stabsread.c (EXTERN): Do not define.
10177         (symnum, next_symbol_text_func, processing_gcc_compilation)
10178         (within_function, global_sym_chain, global_stabs)
10179         (previous_stab_code, this_object_header_files)
10180         (n_this_object_header_files)
10181         (n_allocated_this_object_header_files): Define.
10182         * stabsread.h (EXTERN): Never define.  Use "extern".
10183
10184 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10185
10186         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10187         history_value.
10188
10189 2019-01-21  Tom Tromey  <tom@tromey.com>
10190
10191         * ui-out.c: Fix includes.
10192         * tui/tui-source.c: Fix includes.
10193         * target.c: Fix includes.
10194         * remote.c: Fix includes.
10195         * regcache.c: Fix includes.
10196         * python/py-block.c: Fix includes.
10197         * printcmd.c: Fix includes.
10198         * or1k-tdep.c: Fix includes.
10199         * mi/mi-main.c: Fix includes.
10200         * m32r-tdep.c: Fix includes.
10201         * csky-tdep.c: Fix includes.
10202         * compile/compile-cplus-types.c: Fix includes.
10203         * cli/cli-interp.c: Fix includes.
10204
10205 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10206
10207         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10208         for padding.
10209
10210 2019-01-16  Tom Tromey  <tom@tromey.com>
10211
10212         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10213         earlier.
10214         (struct objfile) <msymbols_range>: Move from top level.
10215         <msymbols>: New method.
10216         (class objfile_msymbols): Remove.
10217         * symtab.c (default_collect_symbol_completion_matches_break_on):
10218         Update.
10219         * symmisc.c (dump_msymbols): Update.
10220         * stabsread.c (scan_file_globals): Update.
10221         * objc-lang.c (info_selectors_command, info_classes_command)
10222         (find_methods): Update.
10223         * minsyms.c (find_solib_trampoline_target): Update.
10224         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10225         * coffread.c (coff_symfile_read): Update.
10226         * ada-lang.c (ada_lookup_simple_minsym)
10227         (ada_collect_symbol_completion_matches): Update.
10228
10229 2019-01-16  Tom Tromey  <tom@tromey.com>
10230
10231         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10232         type.  Remove no-argument constructor.
10233         <iterator::operator++>: Simplify.
10234         <begin>: Update.
10235         <end>: Use minimal_symbol_count.
10236
10237 2019-01-16  Tom Tromey  <tom@tromey.com>
10238
10239         * objfiles.h (struct objfile) <psymtabs>: New method.
10240         (class objfile_psymtabs): Remove.
10241         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10242         typedef.
10243         <range>: New method.
10244         (require_partial_symbols): Change return type.
10245         * psymtab.c (require_partial_symbols)
10246         (psym_expand_symtabs_matching): Update.
10247         * mdebugread.c (parse_partial_symbols): Update.
10248         * dbxread.c (dbx_end_psymtab): Update.
10249
10250 2019-01-15  Tom Tromey  <tom@tromey.com>
10251
10252         * symtab.c (lookup_objfile_from_block)
10253         (lookup_symbol_in_objfile_symtabs)
10254         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10255         (find_line_symtab, info_sources_command)
10256         (default_collect_symbol_completion_matches_break_on)
10257         (make_source_files_completion_list): Update.
10258         * symmisc.c (print_objfile_statistics, dump_objfile)
10259         (maintenance_print_symbols, maintenance_info_symtabs)
10260         (maintenance_check_symtabs, maintenance_info_line_tables):
10261         Update.
10262         * source.c (select_source_symtab)
10263         (forget_cached_source_info_for_objfile): Update.
10264         * objfiles.h (class objfile_compunits): Remove.
10265         (struct objfile) <compunits_range>: New typedef.
10266         (compunits): New method.
10267         * objfiles.c (objfile_relocate1): Update.
10268         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10269         * maint.c (count_symtabs_and_blocks): Update.
10270         * linespec.c (iterate_over_all_matching_symtabs): Update.
10271         * cp-support.c (add_symbol_overload_list_qualified): Update.
10272         * coffread.c (coff_symtab_read): Update.
10273         * ada-lang.c (add_nonlocal_symbols)
10274         (ada_collect_symbol_completion_matches)
10275         (ada_add_global_exceptions): Update.
10276
10277 2019-01-15  Tom Tromey  <tom@tromey.com>
10278
10279         * progspace.h (program_space) <objfiles_safe_range>: New
10280         typedef.
10281         <objfiles_safe>: New method.
10282         * objfiles.h (class all_objfiles_safe): Remove.
10283         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10284         * jit.c (jit_inferior_exit_hook): Update.
10285
10286 2019-01-17  Tom Tromey  <tom@tromey.com>
10287
10288         * progspace.h (program_space) <objfiles_range>: New typedef.
10289         <objfiles>: New method.
10290         <objfiles_head>: Rename from objfiles.
10291         (object_files): Update.
10292         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10293         * guile/scm-pretty-print.c
10294         (ppscm_find_pretty_printer_from_objfiles): Update.
10295         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10296         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10297         Update.
10298         * python/py-progspace.c (pspy_get_objfiles): Update.
10299         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10300         Update.
10301         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10302         (objfpy_lookup_objfile_by_build_id): Update.
10303         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10304         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10305         Update.
10306         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10307         (expand_symtab_containing_pc, lookup_objfile_from_block)
10308         (lookup_static_symbol, basic_lookup_transparent_type)
10309         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10310         (find_line_symtab, info_sources_command)
10311         (default_collect_symbol_completion_matches_break_on)
10312         (make_source_files_completion_list, find_main_name): Update.
10313         * symmisc.c (print_symbol_bcache_statistics)
10314         (print_objfile_statistics, maintenance_print_symbols)
10315         (maintenance_print_msymbols, maintenance_print_objfiles)
10316         (maintenance_info_symtabs, maintenance_check_symtabs)
10317         (maintenance_expand_symtabs, maintenance_info_line_tables):
10318         Update.
10319         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10320         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10321         (map_overlay_command, unmap_overlay_command)
10322         (simple_overlay_update, expand_symtabs_matching)
10323         (map_symbol_filenames): Update.
10324         * symfile-debug.c (set_debug_symfile): Update.
10325         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10326         Update.
10327         * source.c (select_source_symtab, forget_cached_source_info):
10328         Update.
10329         * solib.c (solib_read_symbols): Update.
10330         * solib-spu.c (append_ocl_sos): Update.
10331         * psymtab.c (maintenance_print_psymbols)
10332         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10333         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10334         * printcmd.c (info_symbol_command): Update.
10335         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10336         Update.
10337         * objfiles.h (class all_objfiles): Remove.
10338         * objfiles.c (have_partial_symbols, have_full_symbols)
10339         (have_minimal_symbols, qsort_cmp, update_section_map)
10340         (shared_objfile_contains_address_p)
10341         (default_iterate_over_objfiles_in_search_order): Update.
10342         * objc-lang.c (info_selectors_command, info_classes_command)
10343         (find_methods): Update.
10344         * minsyms.c (find_solib_trampoline_target): Update.
10345         * maint.c (maintenance_info_sections)
10346         (maintenance_translate_address, count_symtabs_and_blocks):
10347         Update.
10348         * main.c (captured_main_1): Update.
10349         * linux-thread-db.c (try_thread_db_load_from_pdir)
10350         (has_libpthread): Update.
10351         * linespec.c (iterate_over_all_matching_symtabs)
10352         (search_minsyms_for_name): Update.
10353         * jit.c (jit_find_objf_with_entry_addr): Update.
10354         * hppa-tdep.c (find_unwind_entry)
10355         (hppa_lookup_stub_minimal_symbol): Update.
10356         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10357         Update.
10358         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10359         (elf_gnu_ifunc_resolve_by_got): Update.
10360         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10361         * dwarf-index-write.c (save_gdb_index_command): Update.
10362         * cp-support.c (add_symbol_overload_list_qualified): Update.
10363         * breakpoint.c (create_overlay_event_breakpoint)
10364         (create_longjmp_master_breakpoint)
10365         (create_std_terminate_master_breakpoint)
10366         (create_exception_master_breakpoint): Update.
10367         * blockframe.c (find_pc_partial_function): Update.
10368         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10369         (ada_collect_symbol_completion_matches)
10370         (ada_add_global_exceptions): Update.
10371
10372 2019-01-17  Tom Tromey  <tom@tromey.com>
10373
10374         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10375         declare VEC.
10376         (solib_target_parse_libraries): Change return type.
10377         (library_list_start_segment, library_list_start_section)
10378         (library_list_end_library, library_list_start_library); Update.
10379         (solib_target_free_library_list): Remove.
10380         (solib_target_parse_libraries): Remove cleanup.  Change return
10381         type.
10382         (solib_target_current_sos): Update.
10383
10384 2019-01-17  Tom Tromey  <tromey@bapiya>
10385
10386         * valprint.c: Replace "the the" with "the".
10387         * symtab.c: Replace "the the" with "the".
10388         * solib.c: Replace "the the" with "the".
10389         * solib-dsbt.c: Replace "the the" with "the".
10390         * linespec.c: Replace "the the" with "the".
10391         * dwarf2loc.h: Replace "the the" with "the".
10392         * amd64-windows-tdep.c: Replace "the the" with "the".
10393         * aarch64-tdep.c: Replace "the the" with "the".
10394
10395 2019-01-16  Keith Seitz  <keiths@redhat.com>
10396
10397         PR gdb/23773
10398         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10399         <builder>: Rename to ..
10400         <m_builder>: ... this and make private.
10401         (dwarf2_cu::get_builder): New method.  Change all users of
10402         `builder' to use this method.
10403         (dwarf2_start_symtab): Move to ...
10404         (dwarf2_cu::start_symtab): ... here.  Update all callers
10405         (setup_type_unit_groups): Move to ...
10406         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10407         callers.
10408         (dwarf2_cu::reset_builder): New method.
10409         (process_full_compunit, process_full_type_unit): Use
10410         dwarf2_cu::reset_builder.
10411         (follow_die_offset): Record the ancestor CU if it is different
10412         from the followed DIE's CU.
10413         (follow_die_sig_1): Likewise.
10414
10415 2019-01-15  Tom Tromey  <tom@tromey.com>
10416
10417         * remote.c (class remote_state) <buf>: Now a char_vector.
10418         <buf_size>: Remove.
10419         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10420         parameter.
10421         (remote_target::getpkt_or_notif_sane_1)
10422         (remote_target::getpkt_sane)
10423         (remote_target::getpkt_or_notif_sane): Likewise.
10424         (class remote_target) <putpkt>: New overload.
10425         (remote_target::read_frame): Change type of "buf_p".  Remove
10426         sizeof_p parameter.
10427         (packet_ok): New overload.
10428         (packet_check_result): New overload.
10429         Update all uses.
10430
10431 2019-01-14  Tom Tromey  <tom@tromey.com>
10432
10433         * remote-notif.c (handle_notification, remote_notif_ack)
10434         (remote_notif_parse): Make "buf" const.
10435         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10436         const.
10437         (remote_notif_parse, remote_notif_ack, handle_notification):
10438         Likewise.
10439         * remote.c (remote_notif_stop_parse): Make "buf" const.
10440         (remote_target::remote_parse_stop_reply): Make "buf" const.
10441         (remote_notif_stop_ack): Make "buf" const.
10442
10443 2019-01-14  Tom Tromey  <tom@tromey.com>
10444
10445         * remote.c (remote_console_output): Make parameter const.
10446
10447 2019-01-14  Tom Tromey  <tom@tromey.com>
10448
10449         * target-debug.h (target_debug_print_signals): Constify.
10450         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10451         * procfs.c (procfs_target::pass_signals): Update.
10452         * linux-nat.c (linux_nat_target::pass_signals): Update.
10453         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10454         * target-delegates.c: Rebuild.
10455         * remote.c (remote_target::program_signals): Update.
10456         (remote_target::pass_signals): Update.
10457         * target.c (target_pass_signals): Constify argument.
10458         (target_program_signals): Likewise.
10459         * target.h (struct target_ops) <pass_signals, program_signals>:
10460         Constify argument.
10461         (target_pass_signals, target_program_signals): Constify argument.
10462
10463 2019-01-14  Tom Tromey  <tom@tromey.com>
10464
10465         PR tui/28819:
10466         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10467
10468 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10469
10470         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10471         field.
10472         * rs6000-tdep.c: Include reggroups.h.
10473         (IS_V_ALIAS_PSEUDOREG): Define.
10474         (rs6000_register_name): Return names for the "vX" aliases.
10475         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10476         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10477         aliases.  Call default_register_reggroup_p for all other
10478         pseudo-registers.
10479         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10480         New functions.
10481         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10482         Handle "vX" aliases.
10483         (v_alias_pseudo_register_collect): New function.
10484         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10485         (rs6000_gdbarch_init): Initialize "vX" aliases as
10486         pseudo-registers.  Restore registration of
10487         rs6000_pseudo_register_reggroup_p with
10488         set_tdesc_pseudo_register_reggroup_p.
10489
10490 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10491
10492         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10493         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10494         set_gdbarch_num_pseudo_regs.
10495
10496 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10497
10498         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10499         Remove arg prefixname, add do_set and do_show.
10500         Add member functions set_list and show_list.
10501         * cli/cli-style.c (class cli_style_option): Update accordingly.
10502         (style_set_list): Move to file scope.
10503         (style_show_list): Likewise.
10504         (set_style): Call help_list.
10505         (show_style): Call cmd_show_list.
10506         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10507         Update to use the new macro.
10508
10509 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10510
10511         * ada-lang.c (_initialize_ada_language): Expand the help text
10512         for the "catch exception" command.
10513
10514 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10515
10516         * symtab.c (matching_obj_sections): Initialize obj,
10517         declare it closer to its usage.
10518
10519 2019-01-10  Tom Tromey  <tom@tromey.com>
10520
10521         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10522         (basic_inf_threads_range): Remove.
10523         (inf_threads_range, inf_non_exited_threads_range)
10524         (safe_inf_threads_range): Use next_adapter.
10525
10526 2019-01-10  Keith Seitz  <keiths@redhat.com>
10527
10528         PR gdb/23712
10529         PR symtab/23010
10530         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10531         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10532
10533 2019-01-10  Keith Seitz  <keiths@redhat.com>
10534
10535         PR gdb/23712
10536         PR symtab/23010
10537         * dictionary.c (pending_to_vector): Remove.
10538         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10539         Remove _1 suffix, replacing functions of the same name.  Update
10540         all callers.
10541         (dict_create_hashed, dict_create_hashed_expandable)
10542         (dict_create_linear, dict_create_linear_expandable, dict_free)
10543         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10544         Make functions static.
10545
10546 2019-01-10  Keith Seitz  <keiths@redhat.com>
10547
10548         PR gdb/23712
10549         PR symtab/23010
10550         * dictionary.h (struct dictionary): Replace declaration with
10551         multidictionary.
10552         (dict_create_hashed, dict_create_hashed_expandable)
10553         (dict_create_linear, dict_create_linear_expandable)
10554         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10555         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10556         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10557         taking multidictionary argument.
10558         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10559         * block.h (struct block) <dict>: Change to multidictionary
10560         and rename `multidict'.
10561         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10562         symmisc.c: Update all dictionary references to multidictionary.
10563
10564 2019-01-10  Keith Seitz  <keiths@redhat.com>
10565
10566         PR gdb/23712
10567         PR symtab/23010
10568         * dictionary.c: Include unordered_map.
10569         (pending_to_vector): New function.
10570         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10571         Rewrite the non-"_1" functions to take vector instead
10572         of linked list.
10573         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10574         "new" _1 versions of the same name.
10575         (multidictionary): Define.
10576         (std::hash<enum language): New definition.
10577         (collate_pending_symbols_by_language, mdict_create_hashed)
10578         (mdict_create_hashed_expandable, mdict_create_linear)
10579         (mdict_create_linear_expandable, mdict_free)
10580         (find_language_dictionary, create_new_language_dictionary)
10581         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10582         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10583         (mdict_size, mdict_empty): New functions.
10584         * dictionary.h (mdict_iterator): Define.
10585
10586 2019-01-10  Pedro Alves  <palves@redhat.com>
10587
10588         * breakpoint.c (read_uploaded_action)
10589         (create_tracepoint_from_upload): Adjust to use
10590         gdb::unique_xmalloc_ptr.
10591         * ctf.c (ctf_write_uploaded_tp):
10592         (SET_ARRAY_FIELD): Use emplace_back.
10593         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10594         * tracefile-tfile.c (tfile_write_uploaded_tp):
10595         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10596         gdb::unique_xmalloc_ptr.
10597         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10598         at_string, cond_string, cmd_strings>: Replace char pointers
10599         with gdb::unique_xmalloc_ptr.
10600
10601 2019-01-10  Pedro Alves  <palves@redhat.com>
10602
10603         * solib-target.c (library_list_start_library): Don't xstrdup name.
10604
10605 2019-01-10  Pedro Alves  <palves@redhat.com>
10606
10607         * mdebugread.c (parse_partial_symbols): Use
10608         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10609
10610 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10611
10612         * linux-fork.c (scoped_switch_fork_info)
10613         <~scoped_switch_fork_info>: Fix incorrect variable name.
10614
10615 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10616
10617         * linux-fork.c (scoped_switch_fork_info)
10618         <scoped_switch_fork_info>: Make explicit.
10619         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10620
10621 2019-01-10  Tom Tromey  <tom@tromey.com>
10622
10623         * objfiles.h (objfile::reset_psymtabs): Update.
10624         * objfiles.c (objfile::objfile): Update.
10625         * psymtab.h (psymtab_storage::obstack): Update.
10626         (psymtab_storage::m_obstack): Use gdb::optional.
10627         (class psymtab_storage): Update comment.  Remove objfile
10628         parameter.
10629         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10630
10631 2019-01-10  Tom Tromey  <tom@tromey.com>
10632
10633         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10634         <free_psymtabs>: Now private.
10635         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10636         (allocate_psymtab): Use new method.
10637
10638 2019-01-10  Tom Tromey  <tom@tromey.com>
10639
10640         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10641         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10642         * mdebugread.c (parse_partial_symbols): Use
10643         allocate_dependencies.
10644         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10645         allocate_dependencies.
10646         (process_psymtab_comp_unit_reader)
10647         (build_type_psymtab_dependencies): Likewise.
10648         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10649
10650 2019-01-10  Tom Tromey  <tom@tromey.com>
10651
10652         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10653         PSYMBOL_SET_LANGUAGE.
10654         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10655
10656 2019-01-10  Tom Tromey  <tom@tromey.com>
10657
10658         * psymtab.h (psymtab_storage::obstack): New method.
10659         <m_obstack>: Rename from obstack; now private.
10660         * psymtab.c (psymtab_storage): Update.
10661         * dwarf2read.c (create_addrmap_from_index)
10662         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10663         Update.
10664
10665 2019-01-10  Tom Tromey  <tom@tromey.com>
10666
10667         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10668         * objfiles.h (objfile::reset_psymtabs): New method.
10669
10670 2019-01-10  Tom Tromey  <tom@tromey.com>
10671
10672         * symmisc.c (print_symbol_bcache_statistics): Update.
10673         (print_objfile_statistics): Update.
10674         * symfile.c (reread_symbols): Update.
10675         * psymtab.h (class psymtab_storage): New.
10676         * psymtab.c (psymtab_storage): New constructor.
10677         (~psymtab_storage): New destructor.
10678         (require_partial_symbols): Update.
10679         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10680         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10681         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10682         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10683         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10684         (start_psymtab_common, end_psymtab_common)
10685         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10686         (allocate_psymtab): Update.
10687         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10688         Update.
10689         (dump_psymtab_addrmap, maintenance_print_psymbols)
10690         (maintenance_check_psymtabs): Update.
10691         (class objfile_psymtabs): Move to objfiles.h.
10692         * psympriv.h (discard_psymtab): Now inline.
10693         (psymtab_discarder::psymtab_discarder): Update.
10694         (psymtab_discarder::~psymtab_discarder): Update.
10695         (ALL_OBJFILE_PSYMTABS): Rewrite.
10696         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10697         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10698         Remove fields.
10699         <partial_symtabs>: New field.
10700         (class objfile_psymtabs): Move from psymtab.h.  Update.
10701         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10702         psymbol_cache.
10703         (objfile::~objfile): Don't destroy psymbol_cache.
10704         * mdebugread.c (parse_partial_symbols): Update.
10705         * dwarf2read.c (create_addrmap_from_index)
10706         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10707         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10708         (add_partial_subprogram, dwarf2_ranges_read): Update.
10709         * dwarf-index-write.c (write_address_map)
10710         (write_one_signatured_type, recursively_write_psymbols)
10711         (class debug_names, class debug_names, write_psymtabs_to_index):
10712         Update.
10713
10714 2019-01-10  Tom Tromey  <tom@tromey.com>
10715
10716         * symtab.h (SYMBOL_SET_NAMES): Update.
10717         (symbol_set_names): Update.
10718         (MSYMBOL_SET_NAMES): Update.
10719         * symtab.c (symbol_set_names): Change argument to be an
10720         objfile_per_bfd_storage.
10721         * psymtab.c (add_psymbol_to_bcache): Update.
10722         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10723
10724 2019-01-10  Tom Tromey  <tom@tromey.com>
10725
10726         * symtab.c (create_demangled_names_hash): Change argument to be an
10727         objfile_per_bfd_storage.
10728         (symbol_set_names): Update.
10729
10730 2019-01-10  Tom Tromey  <tom@tromey.com>
10731
10732         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10733         init_psymbol_list.
10734         * psymtab.c (init_psymbol_list): Do nothing if already called.
10735         * psympriv.h (init_psymbol_list): Add comment.
10736         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10737         init_psymbol_list.
10738         * dbxread.c (dbx_symfile_read): Unconditionally call
10739         init_psymbol_list.
10740
10741 2019-01-10  Tom Tromey  <tom@tromey.com>
10742
10743         * xcoffread.c (scan_xcoff_symtab): Update.
10744         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10745         "where".
10746         * mdebugread.c (parse_partial_symbols)
10747         (handle_psymbol_enumerators): Update.
10748         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10749         * dbxread.c (read_dbx_symtab): Update.
10750         * psympriv.h (psymbol_placement): New enum.
10751         (add_psymbol_to_list): Update.
10752
10753 2019-01-10  Tom Tromey  <tom@tromey.com>
10754
10755         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10756         static_psymbols parameters.
10757         (scan_xcoff_symtab): Update.
10758         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10759         static_psymbols parameters.
10760         * psympriv.h (start_psymtab_common): Update.
10761         * mdebugread.c (parse_partial_symbols): Update.
10762         * dwarf2read.c (create_partial_symtab): Update.
10763         * dbxread.c (read_dbx_symtab): Update.
10764         (start_psymtab): Remove global_psymbols and static_psymbols
10765         parameters.
10766
10767 2019-01-10  Tom Tromey  <tom@tromey.com>
10768
10769         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10770         * psymtab.c (allocate_psymtab): Add comment.
10771         * psympriv.h (allocate_psymtab): Add comment.
10772         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10773         initializations.
10774         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10775
10776 2019-01-10  Tom Tromey  <tom@tromey.com>
10777
10778         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10779         Don't declare.
10780         * mipsread.c: Include mdebugread.h.
10781         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10782         Declare.
10783         * elfread.c: Include mdebugread.h.
10784
10785 2019-01-09  Tom Tromey  <tom@tromey.com>
10786
10787         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10788         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10789         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10790         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10791         (psym_lookup_symbol, psym_find_last_source_symtab)
10792         (psym_forget_cached_source_info, psym_print_stats)
10793         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10794         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10795         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10796         (psym_find_compunit_symtab_by_address)
10797         (maintenance_print_psymbols, maintenance_info_psymtabs)
10798         (maintenance_check_psymtabs): Use ranged for.
10799         * psymtab.h (class objfile_psymtabs): New.
10800         (require_partial_symbols): Return objfile_psymtabs.
10801         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10802
10803 2019-01-09  Tom Tromey  <tom@tromey.com>
10804
10805         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10806         (find_pc_mapped_section, list_overlays_command)
10807         (map_overlay_command, unmap_overlay_command)
10808         (simple_overlay_update): Use all_objfiles.
10809         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10810         * printcmd.c (info_symbol_command): Use all_objfiles.
10811         * objfiles.h (ALL_OBJSECTIONS): Remove.
10812         * maint.c (maintenance_translate_address): Use all_objfiles.
10813         * gcore.c (gcore_create_callback): Use all_objfiles.
10814         (objfile_find_memory_regions): Likewise.
10815
10816 2019-01-09  Tom Tromey  <tom@tromey.com>
10817
10818         * symtab.c (find_line_symtab, info_sources_command)
10819         (make_source_files_completion_list): Use objfile_compunits.
10820         * source.c (select_source_symtab): Use objfile_compunits.
10821         * objfiles.h (struct objfile): Update comment.
10822         (ALL_OBJFILES): Remove.
10823         (ALL_FILETABS): Remove.
10824         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10825         objfile_compunits.
10826
10827 2019-01-09  Tom Tromey  <tom@tromey.com>
10828
10829         * symmisc.c (print_objfile_statistics, dump_objfile)
10830         (maintenance_print_symbols): Use compunit_filetabs.
10831         * source.c (forget_cached_source_info_for_objfile): Use
10832         compunit_filetabs.
10833         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10834         (ALL_FILETABS): Use compunit_filetabs.
10835         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10836         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10837
10838 2019-01-09  Tom Tromey  <tom@tromey.com>
10839
10840         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10841         (compunit_filetabs): New.
10842         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10843         compunit_filetabs.
10844         (info_sources_command, make_source_files_completion_list): Remove
10845         declaration.
10846         * symmisc.c (print_objfile_statistics, dump_objfile)
10847         (maintenance_print_symbols): Remove declaration.
10848         (maintenance_info_symtabs): Use compunit_filetabs.
10849         (maintenance_info_line_tables): Likewise.
10850         * source.c (select_source_symtab): Change local variable name.
10851         (forget_cached_source_info_for_objfile): Remove declaration.
10852         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10853         * objfiles.c (objfile_relocate1): Remove declaration.
10854         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10855         declaration.
10856         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10857         * coffread.c (coff_symtab_read): Remove declaration.
10858         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10859         compunit_filetabs.
10860
10861 2019-01-09  Tom Tromey  <tom@tromey.com>
10862
10863         * symtab.c (lookup_objfile_from_block)
10864         (find_pc_sect_compunit_symtab, search_symbols)
10865         (default_collect_symbol_completion_matches_break_on): Use
10866         objfile_compunits.
10867         * objfiles.h (ALL_COMPUNITS): Remove.
10868         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10869         * cp-support.c (add_symbol_overload_list_qualified): Use
10870         objfile_compunits.
10871         * ada-lang.c (ada_collect_symbol_completion_matches)
10872         (ada_add_global_exceptions): Use objfile_compunits.
10873
10874 2019-01-09  Tom Tromey  <tom@tromey.com>
10875
10876         * source.c (select_source_symtab)
10877         (forget_cached_source_info_for_objfile): Remove declaration.
10878         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10879         declaration.
10880         * maint.c (count_symtabs_and_blocks): Remove declaration.
10881         * cp-support.c (add_symbol_overload_list_qualified): Remove
10882         declaration.
10883         * coffread.c (coff_symtab_read): Remove declaration.
10884         * symtab.c (lookup_symbol_in_objfile_symtabs)
10885         (basic_lookup_transparent_type_1): Use objfile_compunits.
10886         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10887         (info_sources_command, search_symbols)
10888         (default_collect_symbol_completion_matches_break_on)
10889         (make_source_files_completion_list): Remove declaration.
10890         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10891         (ada_collect_symbol_completion_matches)
10892         (ada_add_global_exceptions): Remove declaration.
10893         * linespec.c (iterate_over_all_matching_symtabs): Use
10894         objfile_compunits.
10895         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10896         (class objfile_compunits): New.
10897         (ALL_COMPUNITS): Use objfile_compunits.
10898         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10899         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10900         objfile_compunits.
10901         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10902
10903 2019-01-09  Tom Tromey  <tom@tromey.com>
10904
10905         * symtab.c (search_symbols)
10906         (default_collect_symbol_completion_matches_break_on): Use
10907         objfile_msymbols.
10908         * ada-lang.c (ada_lookup_simple_minsym)
10909         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10910         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10911         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10912         objfile_msymbols.
10913         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10914         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10915         * objc-lang.c (find_methods): Use objfile_msymbols.
10916         (info_selectors_command, info_classes_command): Likewise.
10917         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10918         * objfiles.h (class objfile_msymbols): New.
10919         (ALL_OBJFILE_MSYMBOLS): Remove.
10920         (ALL_MSYMBOLS): Remove.
10921
10922 2019-01-09  Tom Tromey  <tom@tromey.com>
10923
10924         * common/next-iterator.h (next_adapter): Add Iterator template
10925         parameter.
10926         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10927         (class all_objfiles_safe): New.
10928         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10929         * objfiles.c (put_objfile_before): Update comment.
10930         (add_separate_debug_objfile): Likewise.
10931         (free_all_objfiles): Use all_objfiles_safe.
10932         (objfile_purge_solibs): Likewise.
10933
10934 2019-01-09  Tom Tromey  <tom@tromey.com>
10935
10936         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10937         (expand_symtab_containing_pc, lookup_static_symbol)
10938         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10939         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10940         all_objfiles.
10941         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10942         * breakpoint.c (create_overlay_event_breakpoint)
10943         (create_longjmp_master_breakpoint)
10944         (create_std_terminate_master_breakpoint)
10945         (create_exception_master_breakpoint): Use all_objfiles.
10946         * linux-thread-db.c (try_thread_db_load_from_pdir)
10947         (has_libpthread): Use all_objfiles.
10948         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10949         * linespec.c (iterate_over_all_matching_symtabs)
10950         (search_minsyms_for_name): Use all_objfiles.
10951         * maint.c (maintenance_info_sections): Use all_objfiles.
10952         * main.c (captured_main_1): Use all_objfiles.
10953         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10954         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10955         * guile/scm-pretty-print.c
10956         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10957         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10958         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10959         (maintenance_print_msymbols): Use all_objfiles.
10960         * source.c (select_source_symtab): Use all_objfiles.
10961         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10962         * symfile.c (remove_symbol_file_command)
10963         (expand_symtabs_matching, map_symbol_filenames): Use
10964         all_objfiles.
10965         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10966         all_objfiles.
10967         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10968         * objc-lang.c (find_methods): Use all_objfiles.
10969         * objfiles.c (have_partial_symbols, have_full_symbols)
10970         (have_minimal_symbols, qsort_cmp)
10971         (default_iterate_over_objfiles_in_search_order): Use
10972         all_objfiles.
10973         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10974         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10975         (maintenance_check_psymtabs): Use all_objfiles.
10976         (ALL_PSYMTABS): Remove.
10977         * compile/compile-object-run.c (do_module_cleanup): Use
10978         all_objfiles.
10979         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10980         * cp-support.c (add_symbol_overload_list_qualified): Use
10981         all_objfiles.
10982         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10983         Use all_objfiles.
10984         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10985         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10986         all_objfiles.
10987         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10988         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10989         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10990         Uses all_objfiles.
10991         * solib.c (solib_read_symbols): Use all_objfiles
10992
10993 2019-01-09  Tom Tromey  <tom@tromey.com>
10994
10995         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10996         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10997         all_objfiles.
10998         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10999         * symmisc.c (print_symbol_bcache_statistics)
11000         (print_objfile_statistics, maintenance_print_objfiles)
11001         (maintenance_info_symtabs, maintenance_check_symtabs)
11002         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11003         all_objfiles.
11004         * source.c (forget_cached_source_info): Use all_objfiles.
11005         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11006         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11007         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11008         * objfiles.c (update_section_map): Use all_objfiles.
11009         (shared_objfile_contains_address_p): Likewise.
11010         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11011         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11012
11013 2019-01-09  Tom Tromey  <tom@tromey.com>
11014
11015         * common/next-iterator.h: New file.
11016         * objfiles.h (class all_objfiles): New.
11017         (struct objfile_iterator): New.
11018
11019 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11020
11021         * NEWS: Move the description of the changed "frame", "select-frame",
11022          and "info frame" commands to the Changed commands section.
11023
11024 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11025
11026         * gdbtypes.c (check_stub_method_group): Remove handling of old
11027         mangling schemes.
11028         * linespec.c (find_methods): Likewise.
11029         * stabsread.c (read_member_functions): Likewise.
11030         * valops.c (search_struct_method): Likewise.
11031         (value_struct_elt_for_reference): Likewise.
11032         * NEWS: Mention this change.
11033
11034 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11035
11036         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11037         print_source_lines.
11038         * source.c (print_source_lines_base): Update line number check.
11039         (print_source_lines): New function.
11040         (source_lines_range::source_lines_range): New function.
11041         * source.h (class source_lines_range): New class.
11042         (print_source_lines): New declaration.
11043
11044 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11045
11046         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11047
11048 2019-01-08  Tom Tromey  <tom@tromey.com>
11049             Simon Marchi  <simon.marchi@ericsson.com>
11050
11051         PR gdb/24060
11052         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11053         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11054         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11055         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11056         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11057         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11058
11059 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11060
11061         * source.c (select_source_symtab): Move header comment to
11062         declaration in source.h.
11063         (forget_cached_source_info_for_objfile): Likewise.
11064         (forget_cached_source_info): Likewise.
11065         (identify_source_line): Likewise.
11066         * source.h (identify_source_line): Move declaration from symtab.h
11067         and add comment from source.c
11068         (print_source_lines): Likewise.
11069         (forget_cached_source_info_for_objfile): Likewise.
11070         (forget_cached_source_info): Likewise.
11071         (select_source_symtab): Likewise.
11072         (enum print_source_lines_flag): Move definition from symtab.h.
11073         * symtab.h (identify_source_line): Move declaration to source.h.
11074         (print_source_lines): Likewise.
11075         (forget_cached_source_info_for_objfile): Likewise.
11076         (forget_cached_source_info): Likewise.
11077         (select_source_symtab): Likewise.
11078         (enum print_source_lines_flag): Move definition to source.h.
11079         * tui/tui-hooks.c: Add 'source.h' include.
11080
11081 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11082
11083         * source.c (print_source_lines_base): Handle requests to print
11084         reverse line number sequences, and guard against empty lines
11085         string.
11086
11087 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11088
11089         * source.c (print_source_lines_base): Fix skip of '\r' if next
11090         character is '\n'.
11091
11092 2019-01-06  Tom Tromey  <tom@tromey.com>
11093
11094         * c-exp.y (struct c_parse_state) <macro_original_text,
11095         expansion_obstack>: New member.
11096         (macro_original_text, expansion_obstack): Remove globals.
11097         (scan_macro_expansion, scanning_macro_expansion)
11098         (finished_macro_expansion): Update.
11099         (scan_macro_cleanup): Remove.
11100         (yylex, c_parse): Update.
11101
11102 2019-01-06  Tom Tromey  <tom@tromey.com>
11103
11104         * c-exp.y (struct c_parse_state) <strings>: New member.
11105         (operator_stoken): Update.
11106
11107 2019-01-06  Tom Tromey  <tom@tromey.com>
11108
11109         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11110         (union type_stack_elt) <typelist_val>: Now a pointer to
11111         std::vector.
11112         (type_stack_cleanup): Don't declare.
11113         (push_typelist): Update.
11114         * parse.c (pop_typelist): Return a std::vector.
11115         (push_typelist): Take a std::vector.
11116         (follow_types): Update.  Do not free args.
11117         (type_stack_cleanup): Remove.
11118         * c-exp.y (struct c_parse_state): New.
11119         (cpstate): New global.
11120         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11121         (nonempty_typelist): Update.
11122         (func_mod): Create a new vector.
11123         (c_parse): Create a c_parse_state.
11124         (check_parameter_typelist): Do not delete params.
11125         (function_method): Update.  Do not delete type_list.
11126
11127 2019-01-06  Tom Tromey  <tom@tromey.com>
11128
11129         PR gdb/28155:
11130         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11131         check_typedef.
11132         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11133         (print_return_value): Likewise.
11134
11135 2019-01-05  Tom Tromey  <tom@tromey.com>
11136
11137         * contrib/cleanup_check.py: Remove.
11138         * contrib/gcc-with-excheck: Remove.
11139         * contrib/exsummary.py: Remove.
11140         * contrib/excheck.py: Remove.
11141
11142 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11143
11144         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11145         NULL. Initialize tpprev to NULL instead of assigning it
11146         to NULL on the next statement.
11147         * windows-nat.c (windows_delete_thread): Remove check for
11148         main_thread_id before printing thread exit notifications.
11149         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11150         Remove thread ID check against main_thread_id.
11151         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11152         windows_delete_thread.
11153         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11154
11155 2019-01-04  Tom Tromey  <tom@tromey.com>
11156
11157         * compile/compile.c (_initialize_compile): Use upper case for
11158         metasyntactic variables.
11159         * symmisc.c (_initialize_symmisc): Use upper case for
11160         metasyntactic variables.
11161         * psymtab.c (_initialize_psymtab): Use upper case for
11162         metasyntactic variables.
11163         * demangle.c (demangle_command): Use upper case for metasyntactic
11164         variables.
11165         (_initialize_demangler): Likewise.
11166         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11167         variables.
11168
11169 2019-01-03  Tom Tromey  <tom@tromey.com>
11170
11171         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11172
11173 2019-01-03  Tom Tromey  <tom@tromey.com>
11174
11175         * python/py-symtab.c (salpy_str): Update.
11176         (struct salpy_sal_object) <symtab>: Now a PyObject.
11177         (salpy_dealloc): Update.
11178         (del_objfile_sal): Use gdbpy_ref.
11179
11180 2019-01-03  Tom Tromey  <tom@tromey.com>
11181
11182         * python/py-type.c (convert_field): Use new_reference.  Return
11183         gdbpy_ref.
11184         (make_fielditem): Return gdbpy_ref.
11185         (typy_fields): Update.
11186         (typy_getitem): Update.
11187         (field_name): Return gdbpy_ref.  Use new_reference.
11188         (typy_iterator_iternext): Update.
11189
11190 2019-01-03  Tom Tromey  <tom@tromey.com>
11191
11192         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11193
11194 2019-01-03  Tom Tromey  <tom@tromey.com>
11195
11196         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11197         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11198         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11199         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11200         (pspy_set_type_printers): Likewise.
11201         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11202         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11203         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11204         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11205         (objfpy_set_type_printers): Likewise.
11206
11207 2019-01-03  Tom Tromey  <tom@tromey.com>
11208
11209         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11210         (gdbpy_print_stack): Use gdbpy_err_fetch.
11211         * python/python-internal.h (class gdbpy_err_fetch): New class.
11212         (class gdbpy_enter) <m_error_type, m_error_value,
11213         m_error_traceback>: Remove.
11214         <m_error>: New member.
11215         (gdbpy_exception_to_string): Don't declare.
11216         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11217         * python/py-value.c (convert_value_from_python): Use
11218         gdbpy_err_fetch.
11219         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11220         gdbpy_exception_to_string.
11221         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11222         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11223         gdbpy_err_fetch.
11224
11225 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11226
11227         * linux-nat.c (delete_lwp_cleanup): Delete.
11228         (struct lwp_deleter): New struct.
11229         (lwp_info_up): New typedef.
11230         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11231         lwp_info_up.
11232
11233 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11234
11235         * linux-fork.c (class scoped_switch_fork_info): New class.
11236         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11237
11238 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11239
11240         * valops.c (find_overload_match): Remove use of null_cleanup, and
11241         calls to do_cleanups.
11242
11243 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11244
11245         * compile/compile-cplus-types.c
11246         (compile_cplus_instance::decl_name): Handle changes to
11247         cp_func_name.
11248         * cp-support.c (cp_func_name): Update header comment, update
11249         return type.
11250         * cp-support.h (cp_func_name): Update return type in declaration.
11251         * valops.c (find_overload_match): Move temp_func local to top
11252         level of function and change its type.  Use temp_func to hold and
11253         delete temporary string obtained from cp_func_name.
11254
11255 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11256
11257         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11258         gdb::char_vector, remove cleanup, and update uses of `msg`.
11259
11260 2019-01-03  Jim Wilson  <jimw@sifive.com>
11261
11262         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11263
11264 2019-01-02  Tom Tromey  <tom@tromey.com>
11265
11266         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11267         (tdesc_parse_xml): Remove cleanups.
11268         * target-descriptions.h (make_cleanup_free_target_description):
11269         Don't declare.
11270         (target_desc_deleter): New struct.
11271         (target_desc_up): New typedef.
11272         * target-descriptions.c (target_desc_deleter::operator()): Rename
11273         from free_target_description.
11274         (make_cleanup_free_target_description): Remove.
11275
11276 2019-01-02  Tom Tromey  <tom@tromey.com>
11277
11278         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11279         constructor, destructor.
11280         (linespec_parser): Remove typedef.
11281         (~linespec_parser): Rename from linespec_parser_delete.
11282         (linespec_lex_to_end, linespec_complete_label)
11283         (linespec_complete): Update.
11284         (decode_line_full): Remove cleanups.
11285         (decode_line_1): Update.
11286
11287 2019-01-02  Tom Tromey  <tom@tromey.com>
11288
11289         * python/python-internal.h (inferior_to_inferior_object): Change
11290         return type.
11291         * python/py-exitedevent.c (create_exited_event_object): Update.
11292         * python/py-inferior.c (inferior_to_inferior_object): Return
11293         gdbpy_ref.
11294         (python_new_inferior, python_inferior_deleted)
11295         (thread_to_thread_object, delete_thread_object)
11296         (build_inferior_list, gdbpy_selected_inferior): Update.
11297         * python/py-infthread.c (create_thread_object): Update.  Also fail
11298         if inferior_to_inferior_object fails.
11299
11300 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11301
11302         * inferior.h (class inferior) <displaced_step_state>: New field.
11303         * infrun.h (struct displaced_step_state): Move here from
11304         infrun.c.  Initialize fields, add constructor.
11305         <inf>: Remove field.
11306         <reset>: New method.
11307         * infrun.c (struct displaced_step_inferior_state): Move to
11308         infrun.h.
11309         (displaced_step_inferior_states): Remove.
11310         (get_displaced_stepping_state): Adust.
11311         (displaced_step_in_progress_any_inferior): Adjust.
11312         (displaced_step_in_progress_thread): Adjust.
11313         (displaced_step_in_progress): Adjust.
11314         (add_displaced_stepping_state): Remove.
11315         (get_displaced_step_closure_by_addr): Adjust.
11316         (remove_displaced_stepping_state): Remove.
11317         (infrun_inferior_exit): Call displaced_step_state.reset.
11318         (use_displaced_stepping): Don't check for NULL.
11319         (displaced_step_prepare_throw): Call
11320         get_displaced_stepping_state.
11321         (displaced_step_fixup): Don't check for NULL.
11322         (prepare_for_detach): Don't check for NULL.
11323
11324 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11325
11326         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11327          in case of call that did not complete.
11328
11329 2019-01-02  Andrey Utkin  <autkin@undo.io>
11330
11331         * symfile.c (find_separate_debug_file): Fix search of debug files for
11332         remote debuggee.
11333
11334 2019-01-02  Tom Tromey  <tom@tromey.com>
11335
11336         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11337         indentation.
11338         * python/py-frame.c (frapy_older): Remove cast.
11339         (frapy_newer): Likewise.
11340         * python/py-breakpoint.c (local_setattro): Remove cast.
11341         * python/py-arch.c (archpy_name): Remove local variable.
11342         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11343
11344 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11345
11346         * unittests/basic_string_view/element_access/char/empty.cc:
11347         Fix year range in copyright header.
11348
11349 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11350
11351         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11352         Delete.
11353         <operator==>: Update with for removed field.
11354         <hash>: Likewise.
11355         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11356         <isa_features>: ...this.
11357         <abi_features>: New field.
11358         (riscv_isa_flen): Update comment.
11359         (riscv_abi_xlen): New declaration.
11360         (riscv_abi_flen): New declaration.
11361         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11362         isa_features.
11363         (riscv_abi_xlen): New function.
11364         (riscv_isa_flen): Update to get answer from isa_features.
11365         (riscv_abi_flen): New function.
11366         (riscv_has_fp_abi): Update to get answer from abi_features.
11367         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11368         xlen and flen.
11369         (riscv_call_info) <xlen, flen>: Update comment.
11370         (riscv_call_arg_struct): Remove invalid assertions
11371         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11372         is removed.
11373         (riscv_gdbarch_init): Gather isa features and abi features
11374         separately, ensure both match on the gdbarch when reusing an old
11375         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11376         a target with 64-bit float hardware.
11377
11378 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11379
11380         * source.c (search_command_helper): Stop reverse search
11381         when line 1 has been searched.
11382
11383 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11384
11385         * record-full.c (record_full_base_target::close): Rewrite
11386         record_full_core_buf_list free logic.
11387
11388 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11389
11390         * break-catch-syscall.c (print_one_catch_syscall): xfree
11391         the last text.
11392
11393 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11394
11395         * top.c (print_gdb_version): Update Copyright year in version
11396         message.
11397
11398 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11399
11400         Update copyright year range in all GDB files.
11401
11402 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11403
11404         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11405
11406 For older changes see ChangeLog-2018.
11407 \f
11408 Local Variables:
11409 mode: change-log
11410 left-margin: 8
11411 fill-column: 74
11412 version-control: never
11413 coding: utf-8
11414 End:
11415