libctf/ChangeLog

   1 2020-02-01  Eli Zaretskii  <eliz@gnu.org>
   2
   3         PR binutils/25155:
   4         * ctf-create.c (EOVERFLOW): If not defined by system header,
   5         redirect to ERANGE as a poor man's substitute.
   6         * ctf-subr.c (ENOTSUP): If not defined, use ENOSYS instead.
   7
   8 2020-01-05  Joel Brobecker  <brobecker@adacore.com>
   9
  10         PR binutils/25155:
  11         * configure.ac: Add AC_CHECK_DECLS([asprintf]).
  12         * configure, config.h.in: Regenerate.
  13
  14 2020-01-05  Joel Brobecker  <brobecker@adacore.com>
  15
  16         * Makefile.in, aclocal.m4: Regenerate.
  17
  18 2019-10-16  Simon Marchi  <simon.marchi@polymtl.ca>
  19
  20         * swap.h (bswap_16, bswap_32, bswap_64): Make static.
  21
  22 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
  23
  24         * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
  25         * ctf-types.c (ctf_type_lname): Likewise.
  26
  27 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
  28
  29         * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
  30         ctf_import after the first for a given file.
  31
  32 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
  33
  34         * ctf-impl.h (ctf_str_append_noerr): Declare.
  35         * ctf-util.c (ctf_str_append_noerr): Define in terms of
  36         ctf_str_append.
  37         * ctf-dump.c (str_append): New, call it.
  38         (ctf_dump_format_type): Use str_append, not ctf_str_append.
  39         (ctf_dump_label): Likewise.
  40         (ctf_dump_objts): Likewise.
  41         (ctf_dump_funcs): Likewise.
  42         (ctf_dump_var): Likewise.
  43         (ctf_dump_member): Likewise.
  44         (ctf_dump_type): Likewise.
  45         (ctf_dump): Likewise.
  46
  47 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
  48
  49         * ctf-impl.h (ctf_alloc): Remove.
  50         (ctf_free): Likewise.
  51         (ctf_strdup): Likewise.
  52         * ctf-subr.c (ctf_alloc): Remove.
  53         (ctf_free): Likewise.
  54         * ctf-util.c (ctf_strdup): Remove.
  55
  56         * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
  57         ctf_free; strdup, not ctf_strdup.
  58         (ctf_dtd_delete): Likewise.
  59         (ctf_dvd_delete): Likewise.
  60         (ctf_add_generic): Likewise.
  61         (ctf_add_function): Likewise.
  62         (ctf_add_enumerator): Likewise.
  63         (ctf_add_member_offset): Likewise.
  64         (ctf_add_variable): Likewise.
  65         (membadd): Likewise.
  66         (ctf_compress_write): Likewise.
  67         (ctf_write_mem): Likewise.
  68         * ctf-decl.c (ctf_decl_push): Likewise.
  69         (ctf_decl_fini): Likewise.
  70         (ctf_decl_sprintf): Likewise.  Check for OOM.
  71         * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
  72         ctf_free; strdup, not ctf_strdup.
  73         (ctf_dump_free): Likewise.
  74         (ctf_dump): Likewise.
  75         * ctf-open.c (upgrade_types_v1): Likewise.
  76         (init_types): Likewise.
  77         (ctf_file_close): Likewise.
  78         (ctf_bufopen_internal): Likewise.  Check for OOM.
  79         (ctf_parent_name_set): Likewise: report the OOM to the caller.
  80         (ctf_cuname_set): Likewise.
  81         (ctf_import): Likewise.
  82         * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
  83         free, not ctf_free; strdup, not ctf_strdup.
  84         (ctf_str_free_atom): Likewise.
  85         (ctf_str_create_atoms): Likewise.
  86         (ctf_str_add_ref_internal): Likewise.
  87         (ctf_str_remove_ref): Likewise.
  88         (ctf_str_write_strtab): Likewise.
  89
  90 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
  91
  92         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
  93         work right for non-int/fps.
  94
  95 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
  96
  97         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
  98         null pointer.
  99
 100 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
 101
 102         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
 103         * ctf-open.c (ctf_file_close): Free it.
 104         * ctf-create.c (ctf_serialize): Adjust.
 105         (membcmp): When reporting a conflict due to an error, report the
 106         error.
 107         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
 108         (ctf_add_type_internal): ... this.  Hand back types we are already
 109         in the middle of adding immediately.  Hand back structs/unions with
 110         the same number of members immediately.  Do not walk the dynamic
 111         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
 112         forwards promoted to other types and the inverse case identically.
 113         Add structs to the mapping as soon as we intern them, before they
 114         gain any members.
 115
 116 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 117
 118         * ctf-impl.h (ctf_names_t): New.
 119         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
 120         (ctf_file_t) <ctf_structs>: Likewise.
 121         <ctf_unions>: Likewise.
 122         <ctf_enums>: Likewise.
 123         <ctf_names>: Likewise.
 124         <ctf_lookups>: Improve comment.
 125         <ctf_ptrtab_len>: New.
 126         <ctf_prov_strtab>: New.
 127         <ctf_str_prov_offset>: New.
 128         <ctf_dtbyname>: Remove, redundant to the names hashes.
 129         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
 130         (ctf_dtdef_t) <dtd_name>: Remove.
 131         <dtd_data>: Note that the ctt_name is now populated.
 132         (ctf_str_atom_t) <csa_offset>: This is now the strtab
 133         offset for internal strings too.
 134         <csa_external_offset>: New, the external strtab offset.
 135         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
 136         (ctf_name_table): New declaration.
 137         (ctf_lookup_by_rawname): Likewise.
 138         (ctf_lookup_by_rawhash): Likewise.
 139         (ctf_set_ctl_hashes): Likewise.
 140         (ctf_serialize): Likewise.
 141         (ctf_dtd_insert): Adjust.
 142         (ctf_simple_open_internal): Likewise.
 143         (ctf_bufopen_internal): Likewise.
 144         (ctf_list_empty_p): Likewise.
 145         (ctf_str_remove_ref): Likewise.
 146         (ctf_str_add): Returns uint32_t now.
 147         (ctf_str_add_ref): Likewise.
 148         (ctf_str_add_external): Now returns a boolean (int).
 149         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
 150         for strings in the appropriate range.
 151         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
 152         when adding the null string to the new strtab.
 153         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
 154         (ctf_str_add_ref_internal): Add make_provisional argument.  If
 155         make_provisional, populate the offset and fill in the
 156         ctf_prov_strtab accordingly.
 157         (ctf_str_add): Return the offset, not the string.
 158         (ctf_str_add_ref): Likewise.
 159         (ctf_str_add_external): Return a success integer.
 160         (ctf_str_remove_ref): New, remove a single ref.
 161         (ctf_str_count_strtab): Do not count the initial null string's
 162         length or the existence or length of any unreferenced internal
 163         atoms.
 164         (ctf_str_populate_sorttab): Skip atoms with no refs.
 165         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
 166         to the cts_len for the null string, since it is no longer done
 167         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
 168         Populate the csa_offset for both internal and external cases.
 169         Flush the ctf_prov_strtab afterwards, and reset the
 170         ctf_str_prov_offset.
 171         * ctf-create.c (ctf_grow_ptrtab): New.
 172         (ctf_create): Call it.  Initialize new fields rather than old
 173         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
 174         Set the ctl hashes and data model.
 175         (ctf_update): Rename to...
 176         (ctf_serialize): ... this.  Leave a compatibility function behind.
 177         Tell ctf_simple_open_internal that this is a writable dictionary.
 178         Pass the new fields along from the old dictionary.  Drop
 179         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
 180         Do not zero out the DTD's ctt_name.
 181         (ctf_prefixed_name): Rename to...
 182         (ctf_name_table): ... this.  No longer return a prefixed name: return
 183         the applicable name table instead.
 184         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
 185         kind we're adding.  Migrate away from dtd_name.
 186         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
 187         deleted ctt_name.
 188         (ctf_dtd_lookup_type_by_name): Remove.
 189         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
 190         No longer check ctf_dtnextid: check ctf_typemax instead.
 191         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
 192         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
 193         ctf_name_table and the right name table, and migrate away from
 194         dtd_name as in ctf_dtd_delete.
 195         (ctf_add_generic): Pass in the kind explicitly and pass it to
 196         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
 197         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
 198         Grow the ptrtab if needed.
 199         (ctf_add_encoded): Pass in the kind.
 200         (ctf_add_slice): Likewise.
 201         (ctf_add_array): Likewise.
 202         (ctf_add_function): Likewise.
 203         (ctf_add_typedef): Likewise.
 204         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
 205         ctt_name rather than dtd_name.
 206         (ctf_add_struct_sized): Pass in the kind.  Use
 207         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
 208         ctf_dtd_lookup_type_by_name.
 209         (ctf_add_union_sized): Likewise.
 210         (ctf_add_enum): Likewise.
 211         (ctf_add_enum_encoded): Likewise.
 212         (ctf_add_forward): Likewise.
 213         (ctf_add_type): Likewise.
 214         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
 215         being initialized until after the call.
 216         (ctf_write_mem): Likewise.
 217         (ctf_write): Likewise.
 218         * ctf-archive.c (arc_write_one_ctf): Likewise.
 219         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
 220         ctf_hash_lookup_type.
 221         (ctf_lookup_by_id): No longer check the readonly types if the
 222         dictionary is writable.
 223         * ctf-open.c (init_types): Assert that this dictionary is not
 224         writable.  Adjust to use the new name hashes, ctf_name_table,
 225         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
 226         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
 227         if set.  Drop out early when dictionary is writable.  Split the
 228         ctf_lookups initialization into...
 229         (ctf_set_cth_hashes): ... this new function.
 230         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
 231         (ctf_simple_open): Adjust accordingly.
 232         (ctf_bufopen): Likewise.
 233         (ctf_file_close): Destroy the appropriate name hashes.  No longer
 234         destroy ctf_dtbyname, which is gone.
 235         (ctf_getdatasect): Remove spurious "extern".
 236         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
 237         specified name table, given a kind.
 238         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
 239         (ctf_member_iter): Add support for iterating over the
 240         dynamic type list.
 241         (ctf_enum_iter): Likewise.
 242         (ctf_variable_iter): Likewise.
 243         (ctf_type_rvisit): Likewise.
 244         (ctf_member_info): Add support for types in the dynamic type list.
 245         (ctf_enum_name): Likewise.
 246         (ctf_enum_value): Likewise.
 247         (ctf_func_type_info): Likewise.
 248         (ctf_func_type_args): Likewise.
 249         * ctf-link.c (ctf_accumulate_archive_names): No longer call
 250         ctf_update.
 251         (ctf_link_write): Likewise.
 252         (ctf_link_intern_extern_string): Adjust for new
 253         ctf_str_add_external return value.
 254         (ctf_link_add_strtab): Likewise.
 255         * ctf-util.c (ctf_list_empty_p): New.
 256
 257 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
 258
 259         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
 260         type zero.
 261         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
 262         members and types.
 263         (ctf_add_variable): Likewise for variables pointing to them.
 264         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
 265         type link failure, but do warn for others.
 266         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
 267         errors to be ENOMEM.
 268         (ctf_dump_member): Likewise.
 269         (ctf_dump_type): Likewise.
 270         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
 271         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
 272         (ctf_dump_header): Likewise.
 273         (ctf_dump_label): likewise.
 274         (ctf_dump_objts): likewise.
 275         (ctf_dump_funcs): likewise.
 276         (ctf_dump_var): likewise.
 277         (ctf_dump_str): Likewise.
 278
 279 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 280
 281         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
 282         (LT_INIT): Likewise.
 283         (AM_INSTALL_LIBBFD): Likewise.
 284         (dlopen): Note why this is necessary in a comment.
 285         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
 286         opcodes/.
 287         (SHARED_LDFLAGS): Likewise.
 288         (BFD_LIBADD): Likewise, for libbfd.
 289         (BFD_DEPENDENCIES): Likewise.
 290         (VERSION_FLAGS): Initialize, using a version script if ld supports
 291         one, or libtool -export-symbols-regex otherwise.
 292         (AC_CONFIG_MACRO_DIR): Add ../BFD.
 293         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
 294         (INCDIR): New.
 295         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
 296         (noinst_LIBRARIES): Replace with...
 297         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
 298         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
 299         libctf-nobfd.la as well.
 300         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
 301         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
 302         (libctf_a_SOURCES): Rename to...
 303         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
 304         ctf-open-bfd.c.
 305         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
 306         with ctf-open-bfd.c added.
 307         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
 308         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
 309         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
 310         * Makefile.am [INSTALL_LIBCTF]: Use it.
 311         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
 312         libtool macros.
 313         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
 314         the unstable components).
 315         * Makefile.in: Regenerated.
 316         * config.h.in: Likewise.
 317         * configure: Likewise.
 318
 319 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 320
 321         * configure.ac (INSTALL_LIBCTF): New, controlled by
 322         --enable-install-libctf.
 323         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
 324         * Makefile.in: Regenerated.
 325         * configure: Regenerated.
 326
 327 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 328
 329         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
 330         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
 331
 332 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 333
 334         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
 335
 336 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 337
 338         * ctf-impl.h (includes): Include <sys/param.h> here.
 339
 340 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 341
 342         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
 343         (flip_objts): Likewise.
 344         (flip_vars): Likewise.
 345         (flip_types): Likewise.
 346
 347 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 348
 349         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
 350         freeing functions: if set, free the key and value if the slot
 351         already exists.  Always reassign the key.
 352         (ctf_dynhash_insert): Adjust call appropriately.
 353         (ctf_hash_insert_type): Likewise.
 354
 355 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
 356
 357         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
 358         type kind.  Allow forwards to unify with pre-existing structs/
 359         unions/enums.
 360
 361 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 362
 363         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
 364         <ctf_link_memb_name_changer>: Likewise.
 365         <ctf_link_memb_name_changer_arg>: Likewise.
 366         * ctf-create.c (ctf_update): Update accordingly.
 367         * ctf-open.c (ctf_file_close): Likewise.
 368         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
 369         (ctf_link_add_cu_mapping): New.
 370         (ctf_link_set_memb_name_changer): Likewise.
 371         (ctf_change_parent_name): New.
 372         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
 373         allocated by the caller's ctf_link_memb_name_changer.
 374         <ndynames>: Likewise.
 375         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
 376         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
 377         ctf_change_parent_name.  Free any resulting names.
 378
 379 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 380
 381         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
 382         (ctf_link_one_type): ... here, with parent-name setting added.
 383         (check_variable): New.
 384         (ctf_link_one_variable): Likewise.
 385         (ctf_link_one_input_archive_member): Call it.
 386         * ctf-error.c (_ctf_errlist): Updated with new errors.
 387
 388 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 389
 390         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
 391         (struct ctf_link_type_mapping_key): New.
 392         (ctf_hash_type_mapping_key): Likewise.
 393         (ctf_hash_eq_type_mapping_key): Likewise.
 394         (ctf_add_type_mapping): Likewise.
 395         (ctf_type_mapping): Likewise.
 396         (ctf_dynhash_empty): Likewise.
 397         * ctf-open.c (ctf_file_close): Update accordingly.
 398         * ctf-create.c (ctf_update): Likewise.
 399         (ctf_add_type): Populate the mapping.
 400         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
 401         (ctf_hash_eq_type_mapping_key): Check the key for equality.
 402         (ctf_dynhash_insert): Fix comment typo.
 403         (ctf_dynhash_empty): New.
 404         * ctf-link.c (ctf_add_type_mapping): New.
 405         (ctf_type_mapping): Likewise.
 406         (empty_link_type_mapping): New.
 407         (ctf_link_one_input_archive): Call it.
 408
 409 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 410
 411         * ctf-link.c: New file, linking of the string and type sections.
 412         * Makefile.am (libctf_a_SOURCES): Add it.
 413         * Makefile.in: Regenerate.
 414
 415         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
 416         ctf_link_outputs.
 417         * ctf-create.c (ctf_update): Update accordingly.
 418         * ctf-open.c (ctf_file_close): Likewise.
 419         * ctf-error.c (_ctf_errlist): Updated with new errors.
 420
 421 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 422
 423         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
 424
 425 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 426
 427         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
 428         ctf_type_iter.
 429         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
 430         (ctf_dump_format_type): Add non-root-type { } notation.
 431         Add root flag to prototype.
 432         (ctf_dump_label): Adjust accordingly.
 433         (ctf_dump_objts): Likewise.
 434         (ctf_dump_var): Likewise.
 435
 436 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 437
 438         * ctf-create.c (ctf_compress_write): Fix double-free.
 439
 440 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 441
 442         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
 443         of...
 444         (ctf_arc_write_fd): ... this new function.
 445         * ctf-create.c (ctf_write_mem): New.
 446
 447 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 448
 449         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
 450         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
 451         (ctf_str_add_ref): Name the last arg.
 452         (ctf_str_add_external) New.
 453         (ctf_str_add_strraw_explicit): Likewise.
 454         (ctf_simple_open_internal): Likewise.
 455         (ctf_bufopen_internal): Likewise.
 456
 457         * ctf-string.c (ctf_strraw_explicit): Split from...
 458         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
 459         (ctf_str_add_ref_internal): Return the atom, not the
 460         string.
 461         (ctf_str_add): Adjust accordingly.
 462         (ctf_str_add_ref): Likewise.  Move up in the file.
 463         (ctf_str_add_external): New: update the csa_offset.
 464         (ctf_str_count_strtab): Only account for strings with no csa_offset
 465         in the internal strtab length.
 466         (ctf_str_write_strtab): If the csa_offset is set, update the
 467         string's refs without writing the string out, and update the
 468         ctf_syn_ext_strtab.  Make OOM handling less ugly.
 469         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
 470         (ctf_update): Handle failure to populate the strtab.  Pass in the
 471         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
 472         Call ctf_simple_open_internal, not ctf_simple_open.
 473         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
 474         strings by hand.
 475         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
 476         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
 477         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
 478         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
 479         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
 480         (ctf_simple_open_internal): ... this new function, which calls
 481         ctf_bufopen_internal.
 482         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
 483         (ctf_bufopen_internal): ... this new function, which sets
 484         ctf_syn_ext_strtab.
 485
 486 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 487
 488         * ctf_types.c (ctf_type_iter_all): New.
 489
 490 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 491
 492         * ctf-open.c (init_symtab): Check for overflow against the right
 493         section.
 494         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
 495         (upgrade_types_v1): Note that these sections are not checked.
 496         (flip_header): Endian-swap the header fields.
 497         (flip_ctf): Endian-swap the sections.
 498         (flip_objts): Update comment.
 499         (ctf_bufopen): Check header offsets and alignment for validity.
 500
 501 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 502
 503         * ctf-open-bfd.c: Add <assert.h>.
 504         (ctf_bfdopen_ctfsect): Open string and symbol tables using
 505         techniques borrowed from bfd_elf_sym_name.
 506         (ctf_new_archive_internal): Improve comment.
 507         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
 508         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
 509         no symbol section, but not vice versa.
 510
 511 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
 512
 513         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
 514         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
 515         * ctf-dump.c (dump_header): New function, dump the CTF header.
 516         (ctf_dump): Call it.
 517         (ctf_dump_header_strfield): New function.
 518         (ctf_dump_header_sectfield): Likewise.
 519
 520 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
 521
 522         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
 523         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
 524         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
 525         ctf_base: do not assume that it is always sizeof (ctf_header_t).
 526         Print out ctf_cuname: only print out ctf_parname if set.
 527         (ctf_free_base): Removed, ctf_base is no longer freed: free
 528         ctf_dynbase instead.
 529         (ctf_set_version): Fix spacing.
 530         (upgrade_header): New, in-place header upgrading.
 531         (upgrade_types): Rename to...
 532         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
 533         longer track old and new headers separately.  No longer allow for
 534         header sizes explicitly: squeeze the headers out on upgrade (they
 535         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
 536         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
 537         (upgrade_types): New, also handle ctf_parmax updating.
 538         (flip_header): Flip ctf_cuname.
 539         (flip_types): Flip BUF explicitly rather than deriving BUF from
 540         BASE.
 541         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
 542         required alignment of objtoff and funcoff.  No longer store it in
 543         the ctf_buf unless that buf is derived unmodified from the input.
 544         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
 545         that duplicate fields in ctf_file: move allocation of ctf_file
 546         further up instead.  Call upgrade_header as needed.  Move
 547         version-specific ctf_parmax initialization into upgrade_types.  More
 548         concise error handling.
 549         (ctf_file_close): No longer test for null pointers before freeing.
 550         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
 551         ctf_free_base.
 552         (ctf_cuname): New.
 553         (ctf_cuname_set): New.
 554         * ctf-create.c (ctf_update): Populate ctf_cuname.
 555         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
 556         comment.
 557         (ctf_write): Likewise.
 558         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
 559         Fix the compression length: fp->ctf_size never counted the CTF
 560         header.  Simplify the compress call accordingly.
 561
 562 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
 563
 564         * ctf-endian.h: Don't assume htole64 and le64toh are always
 565         present if HAVE_ENDIAN_H; also check if htole64 is defined.
 566         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
 567         not bswap_identity_64.
 568
 569 2019-09-18  Alan Modra  <amodra@gmail.com>
 570
 571         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
 572
 573 2019-09-09  Phil Blundell  <pb@pbcl.net>
 574
 575         binutils 2.33 branch created.
 576
 577 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
 578
 579         * ctf-types.c (ctf_type_aname_raw): New.
 580         (ctf_func_type_info): Likewise.
 581         (ctf_func_type_args): Likewise.
 582         * ctf-error.c (_ctf_errlist): Fix description.
 583         * ctf-lookup.c: Fix file description.
 584
 585 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 586
 587         * ctf-create.c (ctf_create): Fix off-by-one error.
 588
 589 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 590
 591         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
 592         struct ctf_strs.
 593         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
 594         (struct ctf_str_atom): New, disambiguated single string.
 595         (struct ctf_str_atom_ref): New, points to some other location that
 596         references this string's offset.
 597         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
 598         Remove member ctf_dtvstrlen: we no longer track the total strlen
 599         as we add strings.
 600         (ctf_str_create_atoms): Declare new function in ctf-string.c.
 601         (ctf_str_free_atoms): Likewise.
 602         (ctf_str_add): Likewise.
 603         (ctf_str_add_ref): Likewise.
 604         (ctf_str_rollback): Likewise.
 605         (ctf_str_purge_refs): Likewise.
 606         (ctf_str_write_strtab): Likewise.
 607         (ctf_realloc): Declare new function in ctf-util.c.
 608
 609         * ctf-open.c (ctf_bufopen): Create the atoms table.
 610         (ctf_file_close): Destroy it.
 611         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
 612         special-case the position of the parname string.  Construct the
 613         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
 614         rest of each buffer element is constructed, not via open-coding:
 615         realloc the CTF buffer and append the strtab to it.  No longer
 616         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
 617         strtab construction.
 618         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
 619         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
 620         after buffer element construction instead.
 621         (ctf_copy_lmembers): Likewise.
 622         (ctf_copy_emembers): Likewise.
 623         (ctf_create): No longer maintain the ctf_dtvstrlen.
 624         (ctf_dtd_delete): Likewise.
 625         (ctf_dvd_delete): Likewise.
 626         (ctf_add_generic): Likewise.
 627         (ctf_add_enumerator): Likewise.
 628         (ctf_add_member_offset): Likewise.
 629         (ctf_add_variable): Likewise.
 630         (membadd): Likewise.
 631         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
 632         if there are active ctf_str_num_refs.
 633         (ctf_strraw): Move to ctf-string.c.
 634         (ctf_strptr): Likewise.
 635         * ctf-string.c: New file, strtab manipulation.
 636
 637         * Makefile.am (libctf_a_SOURCES): Add it.
 638         * Makefile.in: Regenerate.
 639
 640 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 641
 642         * ctf-impl.h (ctf_hash_iter_f): New.
 643         (ctf_dynhash_iter): New declaration.
 644         (ctf_dynhash_iter_remove): New declaration.
 645         * ctf-hash.c (ctf_dynhash_iter): Define.
 646         (ctf_dynhash_iter_remove): Likewise.
 647         (ctf_hashtab_traverse): New.
 648         (ctf_hashtab_traverse_remove): Likewise.
 649         (struct ctf_traverse_cb_arg): Likewise.
 650         (struct ctf_traverse_remove_cb_arg): Likewise.
 651
 652 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 653
 654         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
 655
 656 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 657
 658         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
 659         (ctf_dump_funcs): Likewise.
 660
 661 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 662
 663         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
 664         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
 665         little-endian CTF archive magic.  Do not check the CTF version:
 666         ctf_simple_open does that in endian-safe ways.  Do not dereference
 667         null pointers on open failure.
 668
 669 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 670
 671         * ctf-open.c (get_vbytes_common): Return the new slice size.
 672         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
 673         Remember to copy in the CTF data when opening an uncompressed
 674         foreign-endian CTF file.  Prune useless variable manipulation.
 675
 676 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 677
 678         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
 679         seen.
 680
 681 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 682
 683         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
 684         output.
 685
 686 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 687
 688         * ctf-subr.c (_PAGESIZE): Remove.
 689         (ctf_data_alloc): Likewise.
 690         (ctf_data_free): Likewise.
 691         (ctf_data_protect): Likewise.
 692         * ctf-impl.h: Remove declarations.
 693         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
 694         ctf_free, not ctf_data_free.
 695         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
 696         the buffer again on compression error.
 697         * ctf-open.c (ctf_set_base): No longer track the size: call
 698         ctf_free, not ctf_data_free.
 699         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
 700         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
 701
 702 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 703
 704         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
 705         ctf_dynhash_insert.
 706         (ctf_dvd_insert): Likewise.
 707         (ctf_add_generic): Likewise.
 708         (ctf_add_variable): Likewise.
 709         * ctf-impl.h: Adjust declarations.
 710
 711 2019-06-14  Alan Modra  <amodra@gmail.com>
 712
 713         * configure: Regenerate.
 714
 715 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 716
 717         * ctf-decls.h: Include <libiberty.h>.
 718         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
 719
 720 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 721
 722         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
 723         (ctf_dump_objts): Likewise.
 724         (ctf_dump_funcs): Likewise.
 725         (ctf_dump_member): Likewise.
 726         (ctf_dump_str): Likewise.
 727
 728 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 729
 730         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
 731         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
 732
 733 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
 734
 735         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
 736         (ctf_arc_open_by_offset): Likewise.
 737         * ctf-create.c (ctf_add_type): Likewise.
 738
 739 2019-06-04  Tom Tromey  <tromey@adacore.com>
 740
 741         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
 742         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
 743
 744 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
 745
 746         * configure.ac: Check for O_CLOEXEC.
 747         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
 748         * config.h.in: Regenerate.
 749         * configure: Likewise.
 750
 751 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
 752
 753         * qsort_r.c: Rename to...
 754         * ctf-qsort_r.c: ... this.
 755         (_quicksort): Define to ctf_qsort_r.
 756         * ctf-decls.h (qsort_r): Remove.
 757         (ctf_qsort_r): Add.
 758         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
 759         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
 760         * Makefile.am (libctf_a_LIBADD): Remove.
 761         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
 762         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
 763         * ctf-create.c (ctf_update): Likewise.
 764         * configure.ac: Check for BSD versus GNU qsort_r signature.
 765         * Makefile.in: Regenerate.
 766         * config.h.in: Likewise.
 767         * configure: Likewise.
 768
 769 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
 770
 771         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
 772
 773 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
 774
 775         * Makefile.am (ZLIB): New.
 776         (ZLIBINC): Likewise.
 777         (AM_CFLAGS): Use them.
 778         (libctf_a_LIBADD): New, for LIBOBJS.
 779         * configure.ac: Check for zlib, endian.h, and qsort_r.
 780         * ctf-endian.h: New, providing htole64 and le64toh.
 781         * swap.h: Code style fixes.
 782         (bswap_identity_64): New.
 783         * qsort_r.c: New, from gnulib (with one added #include).
 784         * ctf-decls.h: New, providing a conditional qsort_r declaration,
 785         and unconditional definitions of MIN and MAX.
 786         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
 787         (ctf_set_errno): Now returns unsigned long.
 788         * ctf-util.c (ctf_set_errno): Adjust here too.
 789         * ctf-archive.c: Use ctf-endian.h.
 790         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
 791         cts_flags and cts_offset.
 792         (ctf_arc_write): Drop debugging dependent on the size of off_t.
 793         * ctf-create.c: Provide a definition of roundup if not defined.
 794         (ctf_create): Drop cts_type, cts_flags and cts_offset.
 795         (ctf_add_reftype): Do not check if type IDs are below zero.
 796         (ctf_add_slice): Likewise.
 797         (ctf_add_typedef): Likewise.
 798         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
 799         when known error-free.  Drop CTF_ERR usage for functions returning
 800         int.
 801         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
 802         int.
 803         (ctf_add_variable): Likewise.
 804         (enumcmp): Likewise.
 805         (enumadd): Likewise.
 806         (membcmp): Likewise.
 807         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
 808         when known error-free.
 809         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
 810         returning int: use CTF_ERR for functions returning ctf_type_id.
 811         (ctf_dump_label): Likewise.
 812         (ctf_dump_objts): Likewise.
 813         * ctf-labels.c (ctf_label_topmost): Likewise.
 814         (ctf_label_iter): Likewise.
 815         (ctf_label_info): Likewise.
 816         * ctf-lookup.c (ctf_func_args): Likewise.
 817         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
 818         (ctf_bufopen): Likewise.  Use zlib types as needed.
 819         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
 820         returning int.
 821         (ctf_enum_iter): Likewise.
 822         (ctf_type_size): Likewise.
 823         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
 824         (ctf_type_kind_unsliced): Likewise.
 825         (ctf_type_kind): Likewise.
 826         (ctf_type_encoding): Likewise.
 827         (ctf_member_info): Likewise.
 828         (ctf_array_info): Likewise.
 829         (ctf_enum_value): Likewise.
 830         (ctf_type_rvisit): Likewise.
 831         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
 832         cts_offset.
 833         (ctf_simple_open): Likewise.
 834         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
 835         * Makefile.in: Regenerate.
 836         * aclocal.m4: Likewise.
 837         * config.h: Likewise.
 838         * configure: Likewise.
 839
 840 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 841
 842         * configure.in: Check for bfd_section_from_elf_index.
 843         * configure: Regenerate.
 844         * config.h.in [HAVE_BFD_ELF]: Likewise.
 845         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
 846         abfd is potentially unused now.
 847
 848 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 849
 850         * Makefile.am: New.
 851         * Makefile.in: Regenerated.
 852         * config.h.in: Likewise.
 853         * aclocal.m4: Likewise.
 854         * configure: Likewise.
 855
 856 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 857
 858         * ctf-dump.c: New.
 859
 860 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 861
 862         * ctf-labels.c: New.
 863
 864 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 865
 866         * ctf-impl.h (_libctf_version): New declaration.
 867         * ctf-subr.c (_libctf_version): Define it.
 868         (ctf_version): New.
 869
 870 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 871
 872         * ctf-create.c (enumcmp): New.
 873         (enumadd): Likewise.
 874         (membcmp): Likewise.
 875         (membadd): Likewise.
 876         (ctf_add_type): Likewise.
 877
 878 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 879
 880         * ctf-lookup.c (isqualifier): New.
 881         (ctf_lookup_by_name): Likewise.
 882         (struct ctf_lookup_var_key): Likewise.
 883         (ctf_lookup_var): Likewise.
 884         (ctf_lookup_variable): Likewise.
 885         (ctf_lookup_symbol_name): Likewise.
 886         (ctf_lookup_by_symbol): Likewise.
 887         (ctf_func_info): Likewise.
 888         (ctf_func_args): Likewise.
 889
 890 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 891
 892         * ctf-decl.c: New file.
 893         * ctf-types.c: Likewise.
 894         * ctf-impl.h: New declarations.
 895
 896 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 897
 898         * ctf-open-bfd.c: New file.
 899         * ctf-open.c (ctf_close): New.
 900         * ctf-impl.h: Include bfd.h.
 901         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
 902         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
 903         ctfi_bfd_close.
 904         (ctf_bfdopen_ctfsect): New declaration.
 905         (_CTF_SECTION): likewise.
 906
 907 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 908
 909         * ctf-archive.c: New.
 910         * ctf-impl.h (ctf_archive_internal): New type.
 911         (ctf_arc_open_internal): New declaration.
 912         (ctf_arc_bufopen): Likewise.
 913         (ctf_arc_close_internal): Likewise.
 914
 915 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 916
 917         * ctf-open.c: New file.
 918         * swap.h: Likewise.
 919
 920 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 921
 922         * ctf-create.c: New file.
 923         * ctf-lookup.c: New file.
 924
 925 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 926
 927         * ctf-impl.h: New definitions and declarations for type creation
 928         and lookup.
 929
 930 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 931
 932         * ctf-hash.c: New file.
 933         * ctf-impl.h: New declarations.
 934
 935 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 936
 937         * ctf-error.c: New file.
 938
 939 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 940
 941         * ctf-util.c: New file.
 942         * elf.h: Likewise.
 943         * ctf-impl.h: Include it, and add declarations.
 944
 945 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 946
 947         * ctf-impl.h: New file.
 948         * ctf-subr.c: New file.
 949
 950 \f
 951 Local Variables:
 952 mode: change-log
 953 left-margin: 8
 954 fill-column: 76
 955 version-control: never
 956 End: