1 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
3 * configure.ac: Add --enable-libctf-hash-debugging.
4 * aclocal.m4: Pull in enable.m4, for GCC_ENABLE.
5 * Makefile.in: Regenerated.
7 * config.h.in: Likewise.
8 * ctf-impl.h [ENABLE_LIBCTF_HASH_DEBUGGING]
9 (ctf_assert): Define to assert.
11 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
13 * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
15 * ctf-impl.h: Include it.
17 (ctf_sha1_add): Likewise.
18 (ctf_sha1_fini): Likewise.
19 * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
21 * Makefile.am: Add file.
22 * Makefile.in: Regenerate.
24 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
26 * libctf.ver (ctf_link_set_variable_filter): Add.
27 * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
28 <ctf_link_variable_filter_arg>: Likewise.
29 * ctf-create.c (ctf_serialize): Adjust.
30 * ctf-link.c (ctf_link_set_variable_filter): New, set it.
31 (ctf_link_one_variable): Call it if set.
33 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
35 * ctf-link.c (ctf_link_one_variable): Check the dst_type for
36 conflicts, not the source type.
38 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
40 * ctf-impl.h (ctf_file_t): Improve comments.
41 <ctf_link_cu_mapping>: Split into...
42 <ctf_link_in_cu_mapping>: ... this...
43 <ctf_link_out_cu_mapping>: ... and this.
44 * ctf-create.c (ctf_serialize): Adjust.
45 * ctf-open.c (ctf_file_close): Likewise.
46 * ctf-link.c (ctf_create_per_cu): Look things up in the
47 in_cu_mapping instead of the cu_mapping.
48 (ctf_link_add_cu_mapping): The deduplicating link will define
49 what happens if many FROMs share a TO.
50 (ctf_link_add_cu_mapping): Create in_cu_mapping and
51 out_cu_mapping. Do not create ctf_link_outputs here any more, or
52 create per-CU dicts here: they are already created when needed.
53 (ctf_link_one_variable): Log a debug message if we skip a
54 variable due to its type being concealed in a CU-mapped link.
55 (This is probably too common a case to make into a warning.)
56 (ctf_link): Create empty per-CU dicts if requested.
58 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
60 * ctf-link.c (ctf_link_write): Close the fd.
62 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
64 * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
65 * Makefile.in: Regenerated.
66 * ctf-impl.h (ctf_link_input_name): New.
67 (ctf_file_t) <ctf_link_flags>: New.
68 * ctf-create.c (ctf_serialize): Adjust accordingly.
69 * ctf-link.c: Define ctf_open as weak when PIC.
70 (ctf_arc_close_thunk): Remove unnecessary thunk.
71 (ctf_file_close_thunk): Likewise.
72 (ctf_link_input_name): New.
73 (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
74 (ctf_link_input_close): Adjust accordingly.
75 (ctf_link_add_ctf_internal): New, split from...
76 (ctf_link_add_ctf): ... here. Return error if lazy loading of
77 CTF is not possible. Change to just call...
78 (ctf_link_add): ... this new function.
79 (ctf_link_add_cu_mapping): Transition to ctf_err_warn. Drop the
81 (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
82 <in_file_name>: ... this.
84 <share_mode>: Likewise (migrated to ctf_link_flags).
85 <done_main_member>: Rename to...
86 <done_parent>: ... this.
87 <main_input_fp>: Rename to...
88 <in_fp_parent>: ... this.
90 (ctf_link_one_type): Adjuwt accordingly. Transition to
91 ctf_err_warn, removing a TODO.
92 (ctf_link_one_variable): Note a case too common to warn about.
93 Report in the debug stream if a cu-mapped link prevents addition
94 of a conflicting variable.
95 (ctf_link_one_input_archive_member): Adjust.
96 (ctf_link_lazy_open): New, open a CTF archive for linking when
98 (ctf_link_close_one_input_archive): New, close it again.
99 (ctf_link_one_input_archive): Adjust for lazy opening, member
100 renames, and ctf_err_warn transition. Move the
101 empty_link_type_mapping call to...
102 (ctf_link): ... here. Adjut for renamings and thunk removal.
103 Don't spuriously fail if some input contains no CTF data.
104 (ctf_link_write): ctf_err_warn transition.
105 * libctf.ver: Remove not-yet-stable comment.
107 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
109 * ctf-impl.h (ctf_strerror): Delete.
110 * ctf-subr.c (ctf_strerror): Likewise.
111 * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
114 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
116 * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
117 (ctf_import_unref): New.
118 * ctf-open.c (ctf_file_close) Drop the refcount all the way to
119 zero. Don't recurse back in if the refcount is already zero.
120 (ctf_import): Check ctf_parent_unreffed before deciding whether
121 to close a pre-existing parent. Set it to zero.
122 (ctf_import_unreffed): New, as above, setting
123 ctf_parent_unreffed to 1.
124 * ctf-create.c (ctf_serialize): Do not ctf_import into the new
125 child: use direct assignment, and set unreffed on the new and
127 * ctf-link.c (ctf_create_per_cu): Import the parent using
130 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
132 * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
133 (ctf_link_type_key): ... this, adjusting member prefixes to
135 (ctf_hash_type_mapping_key): Rename to...
136 (ctf_hash_type_key): ... this.
137 (ctf_hash_eq_type_mapping_key): Rename to...
138 (ctf_hash_eq_type_key): ... this.
139 * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
140 (ctf_hash_type_key): ... this, and adjust for member name
142 (ctf_hash_eq_type_mapping_key): Rename to...
143 (ctf_hash_eq_type_key): ... this, and adjust for member name
145 * ctf-link.c (ctf_add_type_mapping): Adjust. Note the lack of
146 need for out-of-memory checking in this code.
147 (ctf_type_mapping): Adjust.
149 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
151 configure.ac: Check for vasprintf.
152 configure: Regenerated.
153 config.h.in: Likewise.
155 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
157 * ctf-archive.c (ctf_arc_bufopen): Fix message.
159 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
161 * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
163 * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
164 if the input has no symtab, rather than dividing by
165 zero. Arrange to free it later via ctfi_free_ctfsect.
166 * ctf-archive.c (ctf_new_archive_internal): Do not
167 ctfi_free_strsect by default.
168 (ctf_arc_close): Possibly free it here.
170 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
172 * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
173 (ctf_dump_format_type): improve slice formatting. Always print
174 the type size, even of slices.
175 (ctf_dump_member): Print slices (-> bitfields) differently from
176 non-slices. Failure to format a type is not an OOM.
178 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
180 * ctf-dump.c (ctf_dump_format_type): Emit a warning.
181 (ctf_dump_label): Swallow errors from ctf_dump_format_type.
182 (ctf_dump_objts): Likewise.
183 (ctf_dump_var): Likewise.
184 (ctf_dump_type): Do not emit a duplicate message. Move to
185 ctf_err_warning, and swallow all errors.
187 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
189 * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
190 (ctf_decl_buf): Once it escapes, don't try to free it later.
192 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
194 * ctf-types.c (ctf_type_aname): Print arg types here...
195 * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
196 in the type name here.
198 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
200 * ctf-impl.h (ctf_assert): New.
201 (ctf_err_warning_t): Likewise.
202 (ctf_file_t) <ctf_errs_warnings>: Likewise.
203 (ctf_err_warn): New prototype.
204 (ctf_assert_fail_internal): Likewise.
205 * ctf-inlines.h (ctf_assert_internal): Likewise.
206 * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
207 * ctf-create.c (ctf_serialize): Copy it on serialization.
208 * ctf-subr.c (ctf_err_warn): New, add an error/warning.
209 (ctf_errwarning_next): New iterator, free and pass back
210 errors/warnings in succession.
211 * libctf.ver (ctf_errwarning_next): Add.
213 2020-07-22 Egeyar Bagcioglu <egeyar.bagcioglu@oracle.com>
215 * ctf-types.c (ctf_variable_iter): Fix error return.
217 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
219 * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
221 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
223 ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
225 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
227 * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
229 (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
230 ctf_dynhash_next_sorted.
231 <cu.ctn_h>: New, pointer to the dynhash under iteration.
232 <cu.ctn_s>: New, pointer to the dynset under iteration.
233 (ctf_hash_sort_f): Sorting function passed to...
234 (ctf_dynhash_next_sorted): ... this new function.
235 (ctf_dynhash_next): New.
236 (ctf_dynset_next): New.
237 * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
238 (ctf_dynhash_cnext): New.
239 (ctf_dynset_cnext): New.
240 * ctf-hash.c (ctf_dynhash_next_sorted): New.
241 (ctf_dynhash_next): New.
242 (ctf_dynset_next): New.
243 * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
245 (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
247 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
249 * ctf-impl.h (ctf_next): New.
250 (ctf_get_dict): New prototype.
251 * ctf-lookup.c (ctf_get_dict): New, split out of...
252 (ctf_lookup_by_id): ... here.
253 * ctf-util.c (ctf_next_create): New.
254 (ctf_next_destroy): New.
255 (ctf_next_copy): New.
256 * ctf-types.c (includes): Add <assert.h>.
257 (ctf_member_next): New.
258 (ctf_enum_next): New.
259 (ctf_type_iter): Document the lack of iteration over parent
261 (ctf_type_next): New.
262 (ctf_variable_next): New.
263 * ctf-archive.c (ctf_archive_next): New.
264 * libctf.ver: Add new public functions.
266 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
268 * libctf.ver (ctf_ref): New.
269 * ctf-open.c (ctf_ref): Implement it.
271 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
273 * ctf-inlines.h (ctf_forwardable_kind): New.
274 * ctf-create.c (ctf_add_forward): Use it.
276 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
278 * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
279 * ctf-inlines.h (ctf_get_ctt_size): ... to here.
281 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
283 * ctf-hash.c (ctf_dynset_eq_string): New.
284 (ctf_dynset_create): New.
285 (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
286 (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
287 (key_to_internal): New.
288 (internal_to_key): New.
289 (ctf_dynset_insert): New.
290 (ctf_dynset_remove): New.
291 (ctf_dynset_destroy): New.
292 (ctf_dynset_lookup): New.
293 (ctf_dynset_exists): New.
294 (ctf_dynset_lookup_any): New.
295 (ctf_hash_insert_type): Coding style.
296 (ctf_hash_define_type): Likewise.
297 * ctf-impl.h (ctf_dynset_t): New.
298 (ctf_dynset_eq_string): New.
299 (ctf_dynset_create): New.
300 (ctf_dynset_insert): New.
301 (ctf_dynset_remove): New.
302 (ctf_dynset_destroy): New.
303 (ctf_dynset_lookup): New.
304 (ctf_dynset_exists): New.
305 (ctf_dynset_lookup_any): New.
306 * ctf-inlines.h (ctf_dynset_cinsert): New.
308 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
310 * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
311 <value_free>: Likewise.
313 (ctf_dynhash_item_free): Indirect through the owner.
314 (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
315 allocate space for the key_free and value_free fields fields
317 (ctf_hashtab_insert): Likewise. Fix OOM errno value.
318 (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
319 value_free if they will exist. Set the slot's owner, but only
321 (ctf_dynhash_remove): Adjust.
323 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
325 * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
326 there is a key-freeing function and the key already exists.
328 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
330 * ctf-inlines.h: New file.
331 * ctf-impl.h: Include it.
332 (ctf_hash_iter_find_f): New typedef.
333 (ctf_dynhash_elements): New.
334 (ctf_dynhash_lookup_kv): New.
335 (ctf_dynhash_iter_find): New.
336 * ctf-hash.c (ctf_dynhash_lookup_kv): New.
337 (ctf_traverse_find_cb_arg_t): New.
338 (ctf_hashtab_traverse_find): New.
339 (ctf_dynhash_iter_find): New.
340 (ctf_dynhash_elements): New.
342 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
344 * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
346 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
348 * ctf-archive.c (ctf_archive_count): New.
349 * libctf.ver: New public function.
351 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
353 * ctf-types.c (ctf_member_count): New.
354 * libctf.ver: New public function.
356 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
358 * ctf-types.c (ctf_type_kind_forwarded): New.
360 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
362 * ctf-types.c (ctf_type_name_raw): New.
363 (ctf_type_aname_raw): Reimplement accordingly.
365 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
367 * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
369 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
371 * ctf-impl.h (struct ctf_archive_internal)
372 <ctfi_unmap_on_close>: New.
373 (ctf_new_archive_internal): Adjust.
374 * ctf-archive.c (ctf_new_archive_internal): Likewise.
375 Initialize ctfi_unmap_on_close. Adjust error path.
376 (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
377 (unmap_on_close is 0).
378 (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
379 * ctf-open-bfd.c (ctf_fdopen): Adjust.
381 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
383 * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
384 ints, floats or typedefs have no name. Fix comment typo.
386 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
388 * ctf-create.c (ctf_add_slice): Support slices of any kind that
389 resolves to an integral type.
390 * ctf-types.c (ctf_type_encoding): Resolve the type before
391 fishing its encoding out.
393 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
395 * ctf-create.c (ctf_create): Mark dirty.
397 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
399 * ctf-create.c (membcmp) Skip nameless members.
401 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
403 * ctf-create.c (ctf_add_member_offset): Support names of ""
404 as if they were the null pointer.
406 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
408 * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
411 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
413 * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
415 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
417 * ctf-create.c (ctf_serialize): Add cast.
418 (ctf_add_slice): Likewise.
420 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
422 * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
423 * ctf-create.c (ctf_add_function): Check for unimplemented type
424 and populate at the same time. Populate one-by-one, not via
426 (ctf_serialize): Remove unnecessary cast.
427 * ctf-types.c (ctf_func_type_info): Likewise.
428 (ctf_func_type_args): Likewise. Fix comment typo.
430 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
432 * ctf-create.c (ctf_add_reftype): Support refs to type zero.
433 (ctf_add_array): Support array contents of type zero.
434 (ctf_add_function): Support arguments and return types of
436 (ctf_add_typedef): Support typedefs to type zero.
437 (ctf_add_member_offset): Support members of type zero,
438 unless added at unspecified (naturally-aligned) offset.
440 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
442 * ctf-error.c: Include <stddef.h>, for offsetof.
443 (_ctf_errlist): Migrate to...
444 (_ctf_errlist_t): ... this.
445 (_ctf_erridx): New, indexes into _ctf_errlist_t.
447 (ctf_errmsg): Adjust accordingly.
448 * Makefile.am (BUILT_SOURCES): Note...
449 (ctf-error.h): ... this new rule.
450 * Makefile.in: Regenerate.
451 * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
452 * .gitignore: New, ignore ctf-error.h.
454 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
456 * ctf-impl.h: Fix typos in comments.
458 2020-07-22 Nick Clifton <nickc@redhat.com>
460 * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
461 same file descriptor.
463 2020-07-04 Nick Clifton <nickc@redhat.com>
465 Binutils 2.35 branch created.
467 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
469 * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
471 * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
472 * config.h.in: Regenerated.
473 * Makefile.in: Likewise.
474 * configure: Likewise.
476 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
478 * ctf-create.c: Include <unistd.h>.
479 * ctf-open-bfd.c: Likewise.
481 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
484 * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
485 * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
486 means this is declared.
487 (bswap_32): Likewise.
488 (bswap_64): Likewise.
489 (bswap_identity_64): Remove, unused.
490 * configure: Regenerated.
491 * config.h.in: Likewise.
493 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
496 * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
497 (_libctf_unlikely_): Likewise.
498 (_libctf_unused): Likewise.
499 (_libctf_malloc_): Likewise.
501 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
504 * ctf-archive.c (search_nametbl): No longer global: declare...
505 (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
506 (search_modent_by_name): Take and use ARG for the nametbl.
508 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
510 * ctf-impl.h (ctf_new_archive_internal): Declare.
511 (ctf_arc_bufopen): Remove.
512 (ctf_archive_internal) <ctfi_free_symsect>: New.
513 * ctf-archive.c (ctf_arc_close): Use it.
514 (ctf_arc_bufopen): Fuse into...
515 (ctf_new_archive_internal): ... this, moved across from...
516 * ctf-open-bfd.c: ... here.
517 (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
518 * libctf.ver: Add it.
520 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
522 * ctf-create.c (ctf_add_forward): Intern in the right namespace.
523 (ctf_dtd_delete): Remove correspondingly.
524 (ctf_rollback): Likewise.
526 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
528 * ctf-create.c (ctf_add_type_internal): Hand back existing types
531 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
533 * ctf-create.c (ctf_add_forward): Don't add forwards to
534 types that already exist.
536 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
538 * ctf-open.c (init_types): Only intern root-visible types.
539 * ctf-create.c (ctf_dtd_insert): Likewise.
540 (ctf_dtd_delete): Only remove root-visible types.
541 (ctf_rollback): Likewise.
542 (ctf_add_generic): Adjust.
543 (ctf_add_struct_sized): Adjust comment.
544 (ctf_add_union_sized): Likewise.
545 (ctf_add_enum): Likewise.
546 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
548 2020-03-11 John Baldwin <jhb@FreeBSD.org>
550 * swap.h (bswap_identity_64): Make static.
552 2020-01-18 Nick Clifton <nickc@redhat.com>
554 Binutils 2.34 branch created.
556 2020-01-05 Joel Brobecker <brobecker@adacore.com>
559 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
560 * configure, config.h.in: Regenerate.
562 2020-01-01 Alan Modra <amodra@gmail.com>
564 Update year range in copyright notice of all files.
566 2019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
568 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
570 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
572 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
573 * ctf-types.c (ctf_type_lname): Likewise.
575 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
577 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
578 ctf_import after the first for a given file.
580 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
582 * ctf-impl.h (ctf_str_append_noerr): Declare.
583 * ctf-util.c (ctf_str_append_noerr): Define in terms of
585 * ctf-dump.c (str_append): New, call it.
586 (ctf_dump_format_type): Use str_append, not ctf_str_append.
587 (ctf_dump_label): Likewise.
588 (ctf_dump_objts): Likewise.
589 (ctf_dump_funcs): Likewise.
590 (ctf_dump_var): Likewise.
591 (ctf_dump_member): Likewise.
592 (ctf_dump_type): Likewise.
593 (ctf_dump): Likewise.
595 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
597 * ctf-impl.h (ctf_alloc): Remove.
598 (ctf_free): Likewise.
599 (ctf_strdup): Likewise.
600 * ctf-subr.c (ctf_alloc): Remove.
601 (ctf_free): Likewise.
602 * ctf-util.c (ctf_strdup): Remove.
604 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
605 ctf_free; strdup, not ctf_strdup.
606 (ctf_dtd_delete): Likewise.
607 (ctf_dvd_delete): Likewise.
608 (ctf_add_generic): Likewise.
609 (ctf_add_function): Likewise.
610 (ctf_add_enumerator): Likewise.
611 (ctf_add_member_offset): Likewise.
612 (ctf_add_variable): Likewise.
614 (ctf_compress_write): Likewise.
615 (ctf_write_mem): Likewise.
616 * ctf-decl.c (ctf_decl_push): Likewise.
617 (ctf_decl_fini): Likewise.
618 (ctf_decl_sprintf): Likewise. Check for OOM.
619 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
620 ctf_free; strdup, not ctf_strdup.
621 (ctf_dump_free): Likewise.
622 (ctf_dump): Likewise.
623 * ctf-open.c (upgrade_types_v1): Likewise.
624 (init_types): Likewise.
625 (ctf_file_close): Likewise.
626 (ctf_bufopen_internal): Likewise. Check for OOM.
627 (ctf_parent_name_set): Likewise: report the OOM to the caller.
628 (ctf_cuname_set): Likewise.
629 (ctf_import): Likewise.
630 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
631 free, not ctf_free; strdup, not ctf_strdup.
632 (ctf_str_free_atom): Likewise.
633 (ctf_str_create_atoms): Likewise.
634 (ctf_str_add_ref_internal): Likewise.
635 (ctf_str_remove_ref): Likewise.
636 (ctf_str_write_strtab): Likewise.
638 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
640 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
641 work right for non-int/fps.
643 2019-08-08 Nick Alcock <nick.alcock@oracle.com>
645 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
648 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
650 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
651 * ctf-open.c (ctf_file_close): Free it.
652 * ctf-create.c (ctf_serialize): Adjust.
653 (membcmp): When reporting a conflict due to an error, report the
655 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
656 (ctf_add_type_internal): ... this. Hand back types we are already
657 in the middle of adding immediately. Hand back structs/unions with
658 the same number of members immediately. Do not walk the dynamic
659 list. Call ctf_add_type_internal, not ctf_add_type. Handle
660 forwards promoted to other types and the inverse case identically.
661 Add structs to the mapping as soon as we intern them, before they
664 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
666 * ctf-impl.h (ctf_names_t): New.
667 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
668 (ctf_file_t) <ctf_structs>: Likewise.
669 <ctf_unions>: Likewise.
670 <ctf_enums>: Likewise.
671 <ctf_names>: Likewise.
672 <ctf_lookups>: Improve comment.
673 <ctf_ptrtab_len>: New.
674 <ctf_prov_strtab>: New.
675 <ctf_str_prov_offset>: New.
676 <ctf_dtbyname>: Remove, redundant to the names hashes.
677 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
678 (ctf_dtdef_t) <dtd_name>: Remove.
679 <dtd_data>: Note that the ctt_name is now populated.
680 (ctf_str_atom_t) <csa_offset>: This is now the strtab
681 offset for internal strings too.
682 <csa_external_offset>: New, the external strtab offset.
683 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
684 (ctf_name_table): New declaration.
685 (ctf_lookup_by_rawname): Likewise.
686 (ctf_lookup_by_rawhash): Likewise.
687 (ctf_set_ctl_hashes): Likewise.
688 (ctf_serialize): Likewise.
689 (ctf_dtd_insert): Adjust.
690 (ctf_simple_open_internal): Likewise.
691 (ctf_bufopen_internal): Likewise.
692 (ctf_list_empty_p): Likewise.
693 (ctf_str_remove_ref): Likewise.
694 (ctf_str_add): Returns uint32_t now.
695 (ctf_str_add_ref): Likewise.
696 (ctf_str_add_external): Now returns a boolean (int).
697 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
698 for strings in the appropriate range.
699 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
700 when adding the null string to the new strtab.
701 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
702 (ctf_str_add_ref_internal): Add make_provisional argument. If
703 make_provisional, populate the offset and fill in the
704 ctf_prov_strtab accordingly.
705 (ctf_str_add): Return the offset, not the string.
706 (ctf_str_add_ref): Likewise.
707 (ctf_str_add_external): Return a success integer.
708 (ctf_str_remove_ref): New, remove a single ref.
709 (ctf_str_count_strtab): Do not count the initial null string's
710 length or the existence or length of any unreferenced internal
712 (ctf_str_populate_sorttab): Skip atoms with no refs.
713 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
714 to the cts_len for the null string, since it is no longer done
715 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
716 Populate the csa_offset for both internal and external cases.
717 Flush the ctf_prov_strtab afterwards, and reset the
719 * ctf-create.c (ctf_grow_ptrtab): New.
720 (ctf_create): Call it. Initialize new fields rather than old
721 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
722 Set the ctl hashes and data model.
723 (ctf_update): Rename to...
724 (ctf_serialize): ... this. Leave a compatibility function behind.
725 Tell ctf_simple_open_internal that this is a writable dictionary.
726 Pass the new fields along from the old dictionary. Drop
727 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
728 Do not zero out the DTD's ctt_name.
729 (ctf_prefixed_name): Rename to...
730 (ctf_name_table): ... this. No longer return a prefixed name: return
731 the applicable name table instead.
732 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
733 kind we're adding. Migrate away from dtd_name.
734 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
736 (ctf_dtd_lookup_type_by_name): Remove.
737 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
738 No longer check ctf_dtnextid: check ctf_typemax instead.
739 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
740 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
741 ctf_name_table and the right name table, and migrate away from
742 dtd_name as in ctf_dtd_delete.
743 (ctf_add_generic): Pass in the kind explicitly and pass it to
744 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
745 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
746 Grow the ptrtab if needed.
747 (ctf_add_encoded): Pass in the kind.
748 (ctf_add_slice): Likewise.
749 (ctf_add_array): Likewise.
750 (ctf_add_function): Likewise.
751 (ctf_add_typedef): Likewise.
752 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
753 ctt_name rather than dtd_name.
754 (ctf_add_struct_sized): Pass in the kind. Use
755 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
756 ctf_dtd_lookup_type_by_name.
757 (ctf_add_union_sized): Likewise.
758 (ctf_add_enum): Likewise.
759 (ctf_add_enum_encoded): Likewise.
760 (ctf_add_forward): Likewise.
761 (ctf_add_type): Likewise.
762 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
763 being initialized until after the call.
764 (ctf_write_mem): Likewise.
765 (ctf_write): Likewise.
766 * ctf-archive.c (arc_write_one_ctf): Likewise.
767 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
768 ctf_hash_lookup_type.
769 (ctf_lookup_by_id): No longer check the readonly types if the
770 dictionary is writable.
771 * ctf-open.c (init_types): Assert that this dictionary is not
772 writable. Adjust to use the new name hashes, ctf_name_table,
773 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
774 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
775 if set. Drop out early when dictionary is writable. Split the
776 ctf_lookups initialization into...
777 (ctf_set_cth_hashes): ... this new function.
778 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
779 (ctf_simple_open): Adjust accordingly.
780 (ctf_bufopen): Likewise.
781 (ctf_file_close): Destroy the appropriate name hashes. No longer
782 destroy ctf_dtbyname, which is gone.
783 (ctf_getdatasect): Remove spurious "extern".
784 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
785 specified name table, given a kind.
786 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
787 (ctf_member_iter): Add support for iterating over the
789 (ctf_enum_iter): Likewise.
790 (ctf_variable_iter): Likewise.
791 (ctf_type_rvisit): Likewise.
792 (ctf_member_info): Add support for types in the dynamic type list.
793 (ctf_enum_name): Likewise.
794 (ctf_enum_value): Likewise.
795 (ctf_func_type_info): Likewise.
796 (ctf_func_type_args): Likewise.
797 * ctf-link.c (ctf_accumulate_archive_names): No longer call
799 (ctf_link_write): Likewise.
800 (ctf_link_intern_extern_string): Adjust for new
801 ctf_str_add_external return value.
802 (ctf_link_add_strtab): Likewise.
803 * ctf-util.c (ctf_list_empty_p): New.
805 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
807 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
809 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
811 (ctf_add_variable): Likewise for variables pointing to them.
812 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
813 type link failure, but do warn for others.
814 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
816 (ctf_dump_member): Likewise.
817 (ctf_dump_type): Likewise.
818 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
819 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
820 (ctf_dump_header): Likewise.
821 (ctf_dump_label): likewise.
822 (ctf_dump_objts): likewise.
823 (ctf_dump_funcs): likewise.
824 (ctf_dump_var): likewise.
825 (ctf_dump_str): Likewise.
827 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
829 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
831 (AM_INSTALL_LIBBFD): Likewise.
832 (dlopen): Note why this is necessary in a comment.
833 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
835 (SHARED_LDFLAGS): Likewise.
836 (BFD_LIBADD): Likewise, for libbfd.
837 (BFD_DEPENDENCIES): Likewise.
838 (VERSION_FLAGS): Initialize, using a version script if ld supports
839 one, or libtool -export-symbols-regex otherwise.
840 (AC_CONFIG_MACRO_DIR): Add ../BFD.
841 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
843 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
844 (noinst_LIBRARIES): Replace with...
845 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
846 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
847 libctf-nobfd.la as well.
848 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
849 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
850 (libctf_a_SOURCES): Rename to...
851 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
853 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
854 with ctf-open-bfd.c added.
855 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
856 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
857 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
858 * Makefile.am [INSTALL_LIBCTF]: Use it.
859 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
861 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
862 the unstable components).
863 * Makefile.in: Regenerated.
864 * config.h.in: Likewise.
865 * configure: Likewise.
867 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
869 * configure.ac (INSTALL_LIBCTF): New, controlled by
870 --enable-install-libctf.
871 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
872 * Makefile.in: Regenerated.
873 * configure: Regenerated.
875 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
877 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
878 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
880 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
882 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
884 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
886 * ctf-impl.h (includes): Include <sys/param.h> here.
888 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
890 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
891 (flip_objts): Likewise.
892 (flip_vars): Likewise.
893 (flip_types): Likewise.
895 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
897 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
898 freeing functions: if set, free the key and value if the slot
899 already exists. Always reassign the key.
900 (ctf_dynhash_insert): Adjust call appropriately.
901 (ctf_hash_insert_type): Likewise.
903 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
905 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
906 type kind. Allow forwards to unify with pre-existing structs/
909 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
911 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
912 <ctf_link_memb_name_changer>: Likewise.
913 <ctf_link_memb_name_changer_arg>: Likewise.
914 * ctf-create.c (ctf_update): Update accordingly.
915 * ctf-open.c (ctf_file_close): Likewise.
916 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
917 (ctf_link_add_cu_mapping): New.
918 (ctf_link_set_memb_name_changer): Likewise.
919 (ctf_change_parent_name): New.
920 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
921 allocated by the caller's ctf_link_memb_name_changer.
922 <ndynames>: Likewise.
923 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
924 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
925 ctf_change_parent_name. Free any resulting names.
927 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
929 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
930 (ctf_link_one_type): ... here, with parent-name setting added.
931 (check_variable): New.
932 (ctf_link_one_variable): Likewise.
933 (ctf_link_one_input_archive_member): Call it.
934 * ctf-error.c (_ctf_errlist): Updated with new errors.
936 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
938 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
939 (struct ctf_link_type_mapping_key): New.
940 (ctf_hash_type_mapping_key): Likewise.
941 (ctf_hash_eq_type_mapping_key): Likewise.
942 (ctf_add_type_mapping): Likewise.
943 (ctf_type_mapping): Likewise.
944 (ctf_dynhash_empty): Likewise.
945 * ctf-open.c (ctf_file_close): Update accordingly.
946 * ctf-create.c (ctf_update): Likewise.
947 (ctf_add_type): Populate the mapping.
948 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
949 (ctf_hash_eq_type_mapping_key): Check the key for equality.
950 (ctf_dynhash_insert): Fix comment typo.
951 (ctf_dynhash_empty): New.
952 * ctf-link.c (ctf_add_type_mapping): New.
953 (ctf_type_mapping): Likewise.
954 (empty_link_type_mapping): New.
955 (ctf_link_one_input_archive): Call it.
957 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
959 * ctf-link.c: New file, linking of the string and type sections.
960 * Makefile.am (libctf_a_SOURCES): Add it.
961 * Makefile.in: Regenerate.
963 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
965 * ctf-create.c (ctf_update): Update accordingly.
966 * ctf-open.c (ctf_file_close): Likewise.
967 * ctf-error.c (_ctf_errlist): Updated with new errors.
969 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
971 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
973 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
975 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
977 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
978 (ctf_dump_format_type): Add non-root-type { } notation.
979 Add root flag to prototype.
980 (ctf_dump_label): Adjust accordingly.
981 (ctf_dump_objts): Likewise.
982 (ctf_dump_var): Likewise.
984 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
986 * ctf-create.c (ctf_compress_write): Fix double-free.
988 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
990 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
992 (ctf_arc_write_fd): ... this new function.
993 * ctf-create.c (ctf_write_mem): New.
995 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
997 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
998 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
999 (ctf_str_add_ref): Name the last arg.
1000 (ctf_str_add_external) New.
1001 (ctf_str_add_strraw_explicit): Likewise.
1002 (ctf_simple_open_internal): Likewise.
1003 (ctf_bufopen_internal): Likewise.
1005 * ctf-string.c (ctf_strraw_explicit): Split from...
1006 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
1007 (ctf_str_add_ref_internal): Return the atom, not the
1009 (ctf_str_add): Adjust accordingly.
1010 (ctf_str_add_ref): Likewise. Move up in the file.
1011 (ctf_str_add_external): New: update the csa_offset.
1012 (ctf_str_count_strtab): Only account for strings with no csa_offset
1013 in the internal strtab length.
1014 (ctf_str_write_strtab): If the csa_offset is set, update the
1015 string's refs without writing the string out, and update the
1016 ctf_syn_ext_strtab. Make OOM handling less ugly.
1017 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1018 (ctf_update): Handle failure to populate the strtab. Pass in the
1019 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
1020 Call ctf_simple_open_internal, not ctf_simple_open.
1021 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1023 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1024 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
1025 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1026 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1027 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1028 (ctf_simple_open_internal): ... this new function, which calls
1029 ctf_bufopen_internal.
1030 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1031 (ctf_bufopen_internal): ... this new function, which sets
1034 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1036 * ctf_types.c (ctf_type_iter_all): New.
1038 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1040 * ctf-open.c (init_symtab): Check for overflow against the right
1042 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1043 (upgrade_types_v1): Note that these sections are not checked.
1044 (flip_header): Endian-swap the header fields.
1045 (flip_ctf): Endian-swap the sections.
1046 (flip_objts): Update comment.
1047 (ctf_bufopen): Check header offsets and alignment for validity.
1049 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1051 * ctf-open-bfd.c: Add <assert.h>.
1052 (ctf_bfdopen_ctfsect): Open string and symbol tables using
1053 techniques borrowed from bfd_elf_sym_name.
1054 (ctf_new_archive_internal): Improve comment.
1055 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1056 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1057 no symbol section, but not vice versa.
1059 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
1061 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1062 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
1063 * ctf-dump.c (dump_header): New function, dump the CTF header.
1064 (ctf_dump): Call it.
1065 (ctf_dump_header_strfield): New function.
1066 (ctf_dump_header_sectfield): Likewise.
1068 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
1070 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1071 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1072 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1073 ctf_base: do not assume that it is always sizeof (ctf_header_t).
1074 Print out ctf_cuname: only print out ctf_parname if set.
1075 (ctf_free_base): Removed, ctf_base is no longer freed: free
1076 ctf_dynbase instead.
1077 (ctf_set_version): Fix spacing.
1078 (upgrade_header): New, in-place header upgrading.
1079 (upgrade_types): Rename to...
1080 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
1081 longer track old and new headers separately. No longer allow for
1082 header sizes explicitly: squeeze the headers out on upgrade (they
1083 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
1084 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
1085 (upgrade_types): New, also handle ctf_parmax updating.
1086 (flip_header): Flip ctf_cuname.
1087 (flip_types): Flip BUF explicitly rather than deriving BUF from
1089 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
1090 required alignment of objtoff and funcoff. No longer store it in
1091 the ctf_buf unless that buf is derived unmodified from the input.
1092 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1093 that duplicate fields in ctf_file: move allocation of ctf_file
1094 further up instead. Call upgrade_header as needed. Move
1095 version-specific ctf_parmax initialization into upgrade_types. More
1096 concise error handling.
1097 (ctf_file_close): No longer test for null pointers before freeing.
1098 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
1101 (ctf_cuname_set): New.
1102 * ctf-create.c (ctf_update): Populate ctf_cuname.
1103 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
1105 (ctf_write): Likewise.
1106 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1107 Fix the compression length: fp->ctf_size never counted the CTF
1108 header. Simplify the compress call accordingly.
1110 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
1112 * ctf-endian.h: Don't assume htole64 and le64toh are always
1113 present if HAVE_ENDIAN_H; also check if htole64 is defined.
1114 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1115 not bswap_identity_64.
1117 2019-09-18 Alan Modra <amodra@gmail.com>
1119 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1121 2019-09-09 Phil Blundell <pb@pbcl.net>
1123 binutils 2.33 branch created.
1125 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
1127 * ctf-types.c (ctf_type_aname_raw): New.
1128 (ctf_func_type_info): Likewise.
1129 (ctf_func_type_args): Likewise.
1130 * ctf-error.c (_ctf_errlist): Fix description.
1131 * ctf-lookup.c: Fix file description.
1133 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1135 * ctf-create.c (ctf_create): Fix off-by-one error.
1137 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1139 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1141 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1142 (struct ctf_str_atom): New, disambiguated single string.
1143 (struct ctf_str_atom_ref): New, points to some other location that
1144 references this string's offset.
1145 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1146 Remove member ctf_dtvstrlen: we no longer track the total strlen
1148 (ctf_str_create_atoms): Declare new function in ctf-string.c.
1149 (ctf_str_free_atoms): Likewise.
1150 (ctf_str_add): Likewise.
1151 (ctf_str_add_ref): Likewise.
1152 (ctf_str_rollback): Likewise.
1153 (ctf_str_purge_refs): Likewise.
1154 (ctf_str_write_strtab): Likewise.
1155 (ctf_realloc): Declare new function in ctf-util.c.
1157 * ctf-open.c (ctf_bufopen): Create the atoms table.
1158 (ctf_file_close): Destroy it.
1159 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
1160 special-case the position of the parname string. Construct the
1161 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1162 rest of each buffer element is constructed, not via open-coding:
1163 realloc the CTF buffer and append the strtab to it. No longer
1164 maintain ctf_dtvstrlen. Sort the variable entry table later, after
1165 strtab construction.
1166 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1167 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1168 after buffer element construction instead.
1169 (ctf_copy_lmembers): Likewise.
1170 (ctf_copy_emembers): Likewise.
1171 (ctf_create): No longer maintain the ctf_dtvstrlen.
1172 (ctf_dtd_delete): Likewise.
1173 (ctf_dvd_delete): Likewise.
1174 (ctf_add_generic): Likewise.
1175 (ctf_add_enumerator): Likewise.
1176 (ctf_add_member_offset): Likewise.
1177 (ctf_add_variable): Likewise.
1178 (membadd): Likewise.
1179 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1180 if there are active ctf_str_num_refs.
1181 (ctf_strraw): Move to ctf-string.c.
1182 (ctf_strptr): Likewise.
1183 * ctf-string.c: New file, strtab manipulation.
1185 * Makefile.am (libctf_a_SOURCES): Add it.
1186 * Makefile.in: Regenerate.
1188 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1190 * ctf-impl.h (ctf_hash_iter_f): New.
1191 (ctf_dynhash_iter): New declaration.
1192 (ctf_dynhash_iter_remove): New declaration.
1193 * ctf-hash.c (ctf_dynhash_iter): Define.
1194 (ctf_dynhash_iter_remove): Likewise.
1195 (ctf_hashtab_traverse): New.
1196 (ctf_hashtab_traverse_remove): Likewise.
1197 (struct ctf_traverse_cb_arg): Likewise.
1198 (struct ctf_traverse_remove_cb_arg): Likewise.
1200 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1202 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1204 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1206 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1207 (ctf_dump_funcs): Likewise.
1209 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1211 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1212 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1213 little-endian CTF archive magic. Do not check the CTF version:
1214 ctf_simple_open does that in endian-safe ways. Do not dereference
1215 null pointers on open failure.
1217 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1219 * ctf-open.c (get_vbytes_common): Return the new slice size.
1220 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1221 Remember to copy in the CTF data when opening an uncompressed
1222 foreign-endian CTF file. Prune useless variable manipulation.
1224 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1226 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1229 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1231 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1234 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1236 * ctf-subr.c (_PAGESIZE): Remove.
1237 (ctf_data_alloc): Likewise.
1238 (ctf_data_free): Likewise.
1239 (ctf_data_protect): Likewise.
1240 * ctf-impl.h: Remove declarations.
1241 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1242 ctf_free, not ctf_data_free.
1243 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
1244 the buffer again on compression error.
1245 * ctf-open.c (ctf_set_base): No longer track the size: call
1246 ctf_free, not ctf_data_free.
1247 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
1248 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
1250 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1252 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1254 (ctf_dvd_insert): Likewise.
1255 (ctf_add_generic): Likewise.
1256 (ctf_add_variable): Likewise.
1257 * ctf-impl.h: Adjust declarations.
1259 2019-06-14 Alan Modra <amodra@gmail.com>
1261 * configure: Regenerate.
1263 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1265 * ctf-decls.h: Include <libiberty.h>.
1266 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1268 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1270 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1271 (ctf_dump_objts): Likewise.
1272 (ctf_dump_funcs): Likewise.
1273 (ctf_dump_member): Likewise.
1274 (ctf_dump_str): Likewise.
1276 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1278 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1279 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1281 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
1283 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1284 (ctf_arc_open_by_offset): Likewise.
1285 * ctf-create.c (ctf_add_type): Likewise.
1287 2019-06-04 Tom Tromey <tromey@adacore.com>
1289 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1290 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1292 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1294 * configure.ac: Check for O_CLOEXEC.
1295 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1296 * config.h.in: Regenerate.
1297 * configure: Likewise.
1299 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1301 * qsort_r.c: Rename to...
1302 * ctf-qsort_r.c: ... this.
1303 (_quicksort): Define to ctf_qsort_r.
1304 * ctf-decls.h (qsort_r): Remove.
1306 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1307 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1308 * Makefile.am (libctf_a_LIBADD): Remove.
1309 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1310 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1311 * ctf-create.c (ctf_update): Likewise.
1312 * configure.ac: Check for BSD versus GNU qsort_r signature.
1313 * Makefile.in: Regenerate.
1314 * config.h.in: Likewise.
1315 * configure: Likewise.
1317 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
1319 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1321 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
1323 * Makefile.am (ZLIB): New.
1324 (ZLIBINC): Likewise.
1325 (AM_CFLAGS): Use them.
1326 (libctf_a_LIBADD): New, for LIBOBJS.
1327 * configure.ac: Check for zlib, endian.h, and qsort_r.
1328 * ctf-endian.h: New, providing htole64 and le64toh.
1329 * swap.h: Code style fixes.
1330 (bswap_identity_64): New.
1331 * qsort_r.c: New, from gnulib (with one added #include).
1332 * ctf-decls.h: New, providing a conditional qsort_r declaration,
1333 and unconditional definitions of MIN and MAX.
1334 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
1335 (ctf_set_errno): Now returns unsigned long.
1336 * ctf-util.c (ctf_set_errno): Adjust here too.
1337 * ctf-archive.c: Use ctf-endian.h.
1338 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
1339 cts_flags and cts_offset.
1340 (ctf_arc_write): Drop debugging dependent on the size of off_t.
1341 * ctf-create.c: Provide a definition of roundup if not defined.
1342 (ctf_create): Drop cts_type, cts_flags and cts_offset.
1343 (ctf_add_reftype): Do not check if type IDs are below zero.
1344 (ctf_add_slice): Likewise.
1345 (ctf_add_typedef): Likewise.
1346 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1347 when known error-free. Drop CTF_ERR usage for functions returning
1349 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1351 (ctf_add_variable): Likewise.
1352 (enumcmp): Likewise.
1353 (enumadd): Likewise.
1354 (membcmp): Likewise.
1355 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
1356 when known error-free.
1357 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1358 returning int: use CTF_ERR for functions returning ctf_type_id.
1359 (ctf_dump_label): Likewise.
1360 (ctf_dump_objts): Likewise.
1361 * ctf-labels.c (ctf_label_topmost): Likewise.
1362 (ctf_label_iter): Likewise.
1363 (ctf_label_info): Likewise.
1364 * ctf-lookup.c (ctf_func_args): Likewise.
1365 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1366 (ctf_bufopen): Likewise. Use zlib types as needed.
1367 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1369 (ctf_enum_iter): Likewise.
1370 (ctf_type_size): Likewise.
1371 (ctf_type_align): Likewise. Cast to size_t where appropriate.
1372 (ctf_type_kind_unsliced): Likewise.
1373 (ctf_type_kind): Likewise.
1374 (ctf_type_encoding): Likewise.
1375 (ctf_member_info): Likewise.
1376 (ctf_array_info): Likewise.
1377 (ctf_enum_value): Likewise.
1378 (ctf_type_rvisit): Likewise.
1379 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1381 (ctf_simple_open): Likewise.
1382 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
1383 * Makefile.in: Regenerate.
1384 * aclocal.m4: Likewise.
1385 * config.h: Likewise.
1386 * configure: Likewise.
1388 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1390 * configure.in: Check for bfd_section_from_elf_index.
1391 * configure: Regenerate.
1392 * config.h.in [HAVE_BFD_ELF]: Likewise.
1393 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1394 abfd is potentially unused now.
1396 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1399 * Makefile.in: Regenerated.
1400 * config.h.in: Likewise.
1401 * aclocal.m4: Likewise.
1402 * configure: Likewise.
1404 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1408 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1410 * ctf-labels.c: New.
1412 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1414 * ctf-impl.h (_libctf_version): New declaration.
1415 * ctf-subr.c (_libctf_version): Define it.
1418 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1420 * ctf-create.c (enumcmp): New.
1421 (enumadd): Likewise.
1422 (membcmp): Likewise.
1423 (membadd): Likewise.
1424 (ctf_add_type): Likewise.
1426 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1428 * ctf-lookup.c (isqualifier): New.
1429 (ctf_lookup_by_name): Likewise.
1430 (struct ctf_lookup_var_key): Likewise.
1431 (ctf_lookup_var): Likewise.
1432 (ctf_lookup_variable): Likewise.
1433 (ctf_lookup_symbol_name): Likewise.
1434 (ctf_lookup_by_symbol): Likewise.
1435 (ctf_func_info): Likewise.
1436 (ctf_func_args): Likewise.
1438 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1440 * ctf-decl.c: New file.
1441 * ctf-types.c: Likewise.
1442 * ctf-impl.h: New declarations.
1444 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1446 * ctf-open-bfd.c: New file.
1447 * ctf-open.c (ctf_close): New.
1448 * ctf-impl.h: Include bfd.h.
1449 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1450 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1452 (ctf_bfdopen_ctfsect): New declaration.
1453 (_CTF_SECTION): likewise.
1455 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1457 * ctf-archive.c: New.
1458 * ctf-impl.h (ctf_archive_internal): New type.
1459 (ctf_arc_open_internal): New declaration.
1460 (ctf_arc_bufopen): Likewise.
1461 (ctf_arc_close_internal): Likewise.
1463 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1465 * ctf-open.c: New file.
1468 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1470 * ctf-create.c: New file.
1471 * ctf-lookup.c: New file.
1473 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1475 * ctf-impl.h: New definitions and declarations for type creation
1478 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1480 * ctf-hash.c: New file.
1481 * ctf-impl.h: New declarations.
1483 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1485 * ctf-error.c: New file.
1487 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1489 * ctf-util.c: New file.
1491 * ctf-impl.h: Include it, and add declarations.
1493 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1495 * ctf-impl.h: New file.
1496 * ctf-subr.c: New file.
1503 version-control: never