libctf/ChangeLog

   1 2020-01-01  Alan Modra  <amodra@gmail.com>
   2
   3         Update year range in copyright notice of all files.
   4
   5 2019-10-16  Simon Marchi  <simon.marchi@polymtl.ca>
   6
   7         * swap.h (bswap_16, bswap_32, bswap_64): Make static.
   8
   9 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
  10
  11         * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
  12         * ctf-types.c (ctf_type_lname): Likewise.
  13
  14 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
  15
  16         * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
  17         ctf_import after the first for a given file.
  18
  19 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
  20
  21         * ctf-impl.h (ctf_str_append_noerr): Declare.
  22         * ctf-util.c (ctf_str_append_noerr): Define in terms of
  23         ctf_str_append.
  24         * ctf-dump.c (str_append): New, call it.
  25         (ctf_dump_format_type): Use str_append, not ctf_str_append.
  26         (ctf_dump_label): Likewise.
  27         (ctf_dump_objts): Likewise.
  28         (ctf_dump_funcs): Likewise.
  29         (ctf_dump_var): Likewise.
  30         (ctf_dump_member): Likewise.
  31         (ctf_dump_type): Likewise.
  32         (ctf_dump): Likewise.
  33
  34 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
  35
  36         * ctf-impl.h (ctf_alloc): Remove.
  37         (ctf_free): Likewise.
  38         (ctf_strdup): Likewise.
  39         * ctf-subr.c (ctf_alloc): Remove.
  40         (ctf_free): Likewise.
  41         * ctf-util.c (ctf_strdup): Remove.
  42
  43         * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
  44         ctf_free; strdup, not ctf_strdup.
  45         (ctf_dtd_delete): Likewise.
  46         (ctf_dvd_delete): Likewise.
  47         (ctf_add_generic): Likewise.
  48         (ctf_add_function): Likewise.
  49         (ctf_add_enumerator): Likewise.
  50         (ctf_add_member_offset): Likewise.
  51         (ctf_add_variable): Likewise.
  52         (membadd): Likewise.
  53         (ctf_compress_write): Likewise.
  54         (ctf_write_mem): Likewise.
  55         * ctf-decl.c (ctf_decl_push): Likewise.
  56         (ctf_decl_fini): Likewise.
  57         (ctf_decl_sprintf): Likewise.  Check for OOM.
  58         * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
  59         ctf_free; strdup, not ctf_strdup.
  60         (ctf_dump_free): Likewise.
  61         (ctf_dump): Likewise.
  62         * ctf-open.c (upgrade_types_v1): Likewise.
  63         (init_types): Likewise.
  64         (ctf_file_close): Likewise.
  65         (ctf_bufopen_internal): Likewise.  Check for OOM.
  66         (ctf_parent_name_set): Likewise: report the OOM to the caller.
  67         (ctf_cuname_set): Likewise.
  68         (ctf_import): Likewise.
  69         * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
  70         free, not ctf_free; strdup, not ctf_strdup.
  71         (ctf_str_free_atom): Likewise.
  72         (ctf_str_create_atoms): Likewise.
  73         (ctf_str_add_ref_internal): Likewise.
  74         (ctf_str_remove_ref): Likewise.
  75         (ctf_str_write_strtab): Likewise.
  76
  77 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
  78
  79         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
  80         work right for non-int/fps.
  81
  82 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
  83
  84         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
  85         null pointer.
  86
  87 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
  88
  89         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
  90         * ctf-open.c (ctf_file_close): Free it.
  91         * ctf-create.c (ctf_serialize): Adjust.
  92         (membcmp): When reporting a conflict due to an error, report the
  93         error.
  94         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
  95         (ctf_add_type_internal): ... this.  Hand back types we are already
  96         in the middle of adding immediately.  Hand back structs/unions with
  97         the same number of members immediately.  Do not walk the dynamic
  98         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
  99         forwards promoted to other types and the inverse case identically.
 100         Add structs to the mapping as soon as we intern them, before they
 101         gain any members.
 102
 103 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 104
 105         * ctf-impl.h (ctf_names_t): New.
 106         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
 107         (ctf_file_t) <ctf_structs>: Likewise.
 108         <ctf_unions>: Likewise.
 109         <ctf_enums>: Likewise.
 110         <ctf_names>: Likewise.
 111         <ctf_lookups>: Improve comment.
 112         <ctf_ptrtab_len>: New.
 113         <ctf_prov_strtab>: New.
 114         <ctf_str_prov_offset>: New.
 115         <ctf_dtbyname>: Remove, redundant to the names hashes.
 116         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
 117         (ctf_dtdef_t) <dtd_name>: Remove.
 118         <dtd_data>: Note that the ctt_name is now populated.
 119         (ctf_str_atom_t) <csa_offset>: This is now the strtab
 120         offset for internal strings too.
 121         <csa_external_offset>: New, the external strtab offset.
 122         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
 123         (ctf_name_table): New declaration.
 124         (ctf_lookup_by_rawname): Likewise.
 125         (ctf_lookup_by_rawhash): Likewise.
 126         (ctf_set_ctl_hashes): Likewise.
 127         (ctf_serialize): Likewise.
 128         (ctf_dtd_insert): Adjust.
 129         (ctf_simple_open_internal): Likewise.
 130         (ctf_bufopen_internal): Likewise.
 131         (ctf_list_empty_p): Likewise.
 132         (ctf_str_remove_ref): Likewise.
 133         (ctf_str_add): Returns uint32_t now.
 134         (ctf_str_add_ref): Likewise.
 135         (ctf_str_add_external): Now returns a boolean (int).
 136         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
 137         for strings in the appropriate range.
 138         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
 139         when adding the null string to the new strtab.
 140         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
 141         (ctf_str_add_ref_internal): Add make_provisional argument.  If
 142         make_provisional, populate the offset and fill in the
 143         ctf_prov_strtab accordingly.
 144         (ctf_str_add): Return the offset, not the string.
 145         (ctf_str_add_ref): Likewise.
 146         (ctf_str_add_external): Return a success integer.
 147         (ctf_str_remove_ref): New, remove a single ref.
 148         (ctf_str_count_strtab): Do not count the initial null string's
 149         length or the existence or length of any unreferenced internal
 150         atoms.
 151         (ctf_str_populate_sorttab): Skip atoms with no refs.
 152         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
 153         to the cts_len for the null string, since it is no longer done
 154         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
 155         Populate the csa_offset for both internal and external cases.
 156         Flush the ctf_prov_strtab afterwards, and reset the
 157         ctf_str_prov_offset.
 158         * ctf-create.c (ctf_grow_ptrtab): New.
 159         (ctf_create): Call it.  Initialize new fields rather than old
 160         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
 161         Set the ctl hashes and data model.
 162         (ctf_update): Rename to...
 163         (ctf_serialize): ... this.  Leave a compatibility function behind.
 164         Tell ctf_simple_open_internal that this is a writable dictionary.
 165         Pass the new fields along from the old dictionary.  Drop
 166         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
 167         Do not zero out the DTD's ctt_name.
 168         (ctf_prefixed_name): Rename to...
 169         (ctf_name_table): ... this.  No longer return a prefixed name: return
 170         the applicable name table instead.
 171         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
 172         kind we're adding.  Migrate away from dtd_name.
 173         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
 174         deleted ctt_name.
 175         (ctf_dtd_lookup_type_by_name): Remove.
 176         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
 177         No longer check ctf_dtnextid: check ctf_typemax instead.
 178         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
 179         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
 180         ctf_name_table and the right name table, and migrate away from
 181         dtd_name as in ctf_dtd_delete.
 182         (ctf_add_generic): Pass in the kind explicitly and pass it to
 183         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
 184         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
 185         Grow the ptrtab if needed.
 186         (ctf_add_encoded): Pass in the kind.
 187         (ctf_add_slice): Likewise.
 188         (ctf_add_array): Likewise.
 189         (ctf_add_function): Likewise.
 190         (ctf_add_typedef): Likewise.
 191         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
 192         ctt_name rather than dtd_name.
 193         (ctf_add_struct_sized): Pass in the kind.  Use
 194         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
 195         ctf_dtd_lookup_type_by_name.
 196         (ctf_add_union_sized): Likewise.
 197         (ctf_add_enum): Likewise.
 198         (ctf_add_enum_encoded): Likewise.
 199         (ctf_add_forward): Likewise.
 200         (ctf_add_type): Likewise.
 201         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
 202         being initialized until after the call.
 203         (ctf_write_mem): Likewise.
 204         (ctf_write): Likewise.
 205         * ctf-archive.c (arc_write_one_ctf): Likewise.
 206         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
 207         ctf_hash_lookup_type.
 208         (ctf_lookup_by_id): No longer check the readonly types if the
 209         dictionary is writable.
 210         * ctf-open.c (init_types): Assert that this dictionary is not
 211         writable.  Adjust to use the new name hashes, ctf_name_table,
 212         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
 213         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
 214         if set.  Drop out early when dictionary is writable.  Split the
 215         ctf_lookups initialization into...
 216         (ctf_set_cth_hashes): ... this new function.
 217         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
 218         (ctf_simple_open): Adjust accordingly.
 219         (ctf_bufopen): Likewise.
 220         (ctf_file_close): Destroy the appropriate name hashes.  No longer
 221         destroy ctf_dtbyname, which is gone.
 222         (ctf_getdatasect): Remove spurious "extern".
 223         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
 224         specified name table, given a kind.
 225         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
 226         (ctf_member_iter): Add support for iterating over the
 227         dynamic type list.
 228         (ctf_enum_iter): Likewise.
 229         (ctf_variable_iter): Likewise.
 230         (ctf_type_rvisit): Likewise.
 231         (ctf_member_info): Add support for types in the dynamic type list.
 232         (ctf_enum_name): Likewise.
 233         (ctf_enum_value): Likewise.
 234         (ctf_func_type_info): Likewise.
 235         (ctf_func_type_args): Likewise.
 236         * ctf-link.c (ctf_accumulate_archive_names): No longer call
 237         ctf_update.
 238         (ctf_link_write): Likewise.
 239         (ctf_link_intern_extern_string): Adjust for new
 240         ctf_str_add_external return value.
 241         (ctf_link_add_strtab): Likewise.
 242         * ctf-util.c (ctf_list_empty_p): New.
 243
 244 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
 245
 246         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
 247         type zero.
 248         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
 249         members and types.
 250         (ctf_add_variable): Likewise for variables pointing to them.
 251         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
 252         type link failure, but do warn for others.
 253         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
 254         errors to be ENOMEM.
 255         (ctf_dump_member): Likewise.
 256         (ctf_dump_type): Likewise.
 257         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
 258         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
 259         (ctf_dump_header): Likewise.
 260         (ctf_dump_label): likewise.
 261         (ctf_dump_objts): likewise.
 262         (ctf_dump_funcs): likewise.
 263         (ctf_dump_var): likewise.
 264         (ctf_dump_str): Likewise.
 265
 266 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 267
 268         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
 269         (LT_INIT): Likewise.
 270         (AM_INSTALL_LIBBFD): Likewise.
 271         (dlopen): Note why this is necessary in a comment.
 272         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
 273         opcodes/.
 274         (SHARED_LDFLAGS): Likewise.
 275         (BFD_LIBADD): Likewise, for libbfd.
 276         (BFD_DEPENDENCIES): Likewise.
 277         (VERSION_FLAGS): Initialize, using a version script if ld supports
 278         one, or libtool -export-symbols-regex otherwise.
 279         (AC_CONFIG_MACRO_DIR): Add ../BFD.
 280         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
 281         (INCDIR): New.
 282         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
 283         (noinst_LIBRARIES): Replace with...
 284         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
 285         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
 286         libctf-nobfd.la as well.
 287         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
 288         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
 289         (libctf_a_SOURCES): Rename to...
 290         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
 291         ctf-open-bfd.c.
 292         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
 293         with ctf-open-bfd.c added.
 294         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
 295         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
 296         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
 297         * Makefile.am [INSTALL_LIBCTF]: Use it.
 298         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
 299         libtool macros.
 300         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
 301         the unstable components).
 302         * Makefile.in: Regenerated.
 303         * config.h.in: Likewise.
 304         * configure: Likewise.
 305
 306 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 307
 308         * configure.ac (INSTALL_LIBCTF): New, controlled by
 309         --enable-install-libctf.
 310         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
 311         * Makefile.in: Regenerated.
 312         * configure: Regenerated.
 313
 314 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 315
 316         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
 317         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
 318
 319 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 320
 321         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
 322
 323 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 324
 325         * ctf-impl.h (includes): Include <sys/param.h> here.
 326
 327 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 328
 329         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
 330         (flip_objts): Likewise.
 331         (flip_vars): Likewise.
 332         (flip_types): Likewise.
 333
 334 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 335
 336         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
 337         freeing functions: if set, free the key and value if the slot
 338         already exists.  Always reassign the key.
 339         (ctf_dynhash_insert): Adjust call appropriately.
 340         (ctf_hash_insert_type): Likewise.
 341
 342 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
 343
 344         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
 345         type kind.  Allow forwards to unify with pre-existing structs/
 346         unions/enums.
 347
 348 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 349
 350         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
 351         <ctf_link_memb_name_changer>: Likewise.
 352         <ctf_link_memb_name_changer_arg>: Likewise.
 353         * ctf-create.c (ctf_update): Update accordingly.
 354         * ctf-open.c (ctf_file_close): Likewise.
 355         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
 356         (ctf_link_add_cu_mapping): New.
 357         (ctf_link_set_memb_name_changer): Likewise.
 358         (ctf_change_parent_name): New.
 359         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
 360         allocated by the caller's ctf_link_memb_name_changer.
 361         <ndynames>: Likewise.
 362         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
 363         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
 364         ctf_change_parent_name.  Free any resulting names.
 365
 366 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 367
 368         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
 369         (ctf_link_one_type): ... here, with parent-name setting added.
 370         (check_variable): New.
 371         (ctf_link_one_variable): Likewise.
 372         (ctf_link_one_input_archive_member): Call it.
 373         * ctf-error.c (_ctf_errlist): Updated with new errors.
 374
 375 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 376
 377         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
 378         (struct ctf_link_type_mapping_key): New.
 379         (ctf_hash_type_mapping_key): Likewise.
 380         (ctf_hash_eq_type_mapping_key): Likewise.
 381         (ctf_add_type_mapping): Likewise.
 382         (ctf_type_mapping): Likewise.
 383         (ctf_dynhash_empty): Likewise.
 384         * ctf-open.c (ctf_file_close): Update accordingly.
 385         * ctf-create.c (ctf_update): Likewise.
 386         (ctf_add_type): Populate the mapping.
 387         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
 388         (ctf_hash_eq_type_mapping_key): Check the key for equality.
 389         (ctf_dynhash_insert): Fix comment typo.
 390         (ctf_dynhash_empty): New.
 391         * ctf-link.c (ctf_add_type_mapping): New.
 392         (ctf_type_mapping): Likewise.
 393         (empty_link_type_mapping): New.
 394         (ctf_link_one_input_archive): Call it.
 395
 396 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 397
 398         * ctf-link.c: New file, linking of the string and type sections.
 399         * Makefile.am (libctf_a_SOURCES): Add it.
 400         * Makefile.in: Regenerate.
 401
 402         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
 403         ctf_link_outputs.
 404         * ctf-create.c (ctf_update): Update accordingly.
 405         * ctf-open.c (ctf_file_close): Likewise.
 406         * ctf-error.c (_ctf_errlist): Updated with new errors.
 407
 408 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 409
 410         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
 411
 412 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 413
 414         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
 415         ctf_type_iter.
 416         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
 417         (ctf_dump_format_type): Add non-root-type { } notation.
 418         Add root flag to prototype.
 419         (ctf_dump_label): Adjust accordingly.
 420         (ctf_dump_objts): Likewise.
 421         (ctf_dump_var): Likewise.
 422
 423 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 424
 425         * ctf-create.c (ctf_compress_write): Fix double-free.
 426
 427 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 428
 429         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
 430         of...
 431         (ctf_arc_write_fd): ... this new function.
 432         * ctf-create.c (ctf_write_mem): New.
 433
 434 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 435
 436         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
 437         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
 438         (ctf_str_add_ref): Name the last arg.
 439         (ctf_str_add_external) New.
 440         (ctf_str_add_strraw_explicit): Likewise.
 441         (ctf_simple_open_internal): Likewise.
 442         (ctf_bufopen_internal): Likewise.
 443
 444         * ctf-string.c (ctf_strraw_explicit): Split from...
 445         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
 446         (ctf_str_add_ref_internal): Return the atom, not the
 447         string.
 448         (ctf_str_add): Adjust accordingly.
 449         (ctf_str_add_ref): Likewise.  Move up in the file.
 450         (ctf_str_add_external): New: update the csa_offset.
 451         (ctf_str_count_strtab): Only account for strings with no csa_offset
 452         in the internal strtab length.
 453         (ctf_str_write_strtab): If the csa_offset is set, update the
 454         string's refs without writing the string out, and update the
 455         ctf_syn_ext_strtab.  Make OOM handling less ugly.
 456         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
 457         (ctf_update): Handle failure to populate the strtab.  Pass in the
 458         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
 459         Call ctf_simple_open_internal, not ctf_simple_open.
 460         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
 461         strings by hand.
 462         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
 463         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
 464         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
 465         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
 466         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
 467         (ctf_simple_open_internal): ... this new function, which calls
 468         ctf_bufopen_internal.
 469         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
 470         (ctf_bufopen_internal): ... this new function, which sets
 471         ctf_syn_ext_strtab.
 472
 473 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 474
 475         * ctf_types.c (ctf_type_iter_all): New.
 476
 477 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 478
 479         * ctf-open.c (init_symtab): Check for overflow against the right
 480         section.
 481         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
 482         (upgrade_types_v1): Note that these sections are not checked.
 483         (flip_header): Endian-swap the header fields.
 484         (flip_ctf): Endian-swap the sections.
 485         (flip_objts): Update comment.
 486         (ctf_bufopen): Check header offsets and alignment for validity.
 487
 488 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 489
 490         * ctf-open-bfd.c: Add <assert.h>.
 491         (ctf_bfdopen_ctfsect): Open string and symbol tables using
 492         techniques borrowed from bfd_elf_sym_name.
 493         (ctf_new_archive_internal): Improve comment.
 494         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
 495         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
 496         no symbol section, but not vice versa.
 497
 498 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
 499
 500         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
 501         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
 502         * ctf-dump.c (dump_header): New function, dump the CTF header.
 503         (ctf_dump): Call it.
 504         (ctf_dump_header_strfield): New function.
 505         (ctf_dump_header_sectfield): Likewise.
 506
 507 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
 508
 509         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
 510         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
 511         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
 512         ctf_base: do not assume that it is always sizeof (ctf_header_t).
 513         Print out ctf_cuname: only print out ctf_parname if set.
 514         (ctf_free_base): Removed, ctf_base is no longer freed: free
 515         ctf_dynbase instead.
 516         (ctf_set_version): Fix spacing.
 517         (upgrade_header): New, in-place header upgrading.
 518         (upgrade_types): Rename to...
 519         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
 520         longer track old and new headers separately.  No longer allow for
 521         header sizes explicitly: squeeze the headers out on upgrade (they
 522         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
 523         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
 524         (upgrade_types): New, also handle ctf_parmax updating.
 525         (flip_header): Flip ctf_cuname.
 526         (flip_types): Flip BUF explicitly rather than deriving BUF from
 527         BASE.
 528         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
 529         required alignment of objtoff and funcoff.  No longer store it in
 530         the ctf_buf unless that buf is derived unmodified from the input.
 531         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
 532         that duplicate fields in ctf_file: move allocation of ctf_file
 533         further up instead.  Call upgrade_header as needed.  Move
 534         version-specific ctf_parmax initialization into upgrade_types.  More
 535         concise error handling.
 536         (ctf_file_close): No longer test for null pointers before freeing.
 537         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
 538         ctf_free_base.
 539         (ctf_cuname): New.
 540         (ctf_cuname_set): New.
 541         * ctf-create.c (ctf_update): Populate ctf_cuname.
 542         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
 543         comment.
 544         (ctf_write): Likewise.
 545         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
 546         Fix the compression length: fp->ctf_size never counted the CTF
 547         header.  Simplify the compress call accordingly.
 548
 549 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
 550
 551         * ctf-endian.h: Don't assume htole64 and le64toh are always
 552         present if HAVE_ENDIAN_H; also check if htole64 is defined.
 553         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
 554         not bswap_identity_64.
 555
 556 2019-09-18  Alan Modra  <amodra@gmail.com>
 557
 558         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
 559
 560 2019-09-09  Phil Blundell  <pb@pbcl.net>
 561
 562         binutils 2.33 branch created.
 563
 564 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
 565
 566         * ctf-types.c (ctf_type_aname_raw): New.
 567         (ctf_func_type_info): Likewise.
 568         (ctf_func_type_args): Likewise.
 569         * ctf-error.c (_ctf_errlist): Fix description.
 570         * ctf-lookup.c: Fix file description.
 571
 572 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 573
 574         * ctf-create.c (ctf_create): Fix off-by-one error.
 575
 576 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 577
 578         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
 579         struct ctf_strs.
 580         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
 581         (struct ctf_str_atom): New, disambiguated single string.
 582         (struct ctf_str_atom_ref): New, points to some other location that
 583         references this string's offset.
 584         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
 585         Remove member ctf_dtvstrlen: we no longer track the total strlen
 586         as we add strings.
 587         (ctf_str_create_atoms): Declare new function in ctf-string.c.
 588         (ctf_str_free_atoms): Likewise.
 589         (ctf_str_add): Likewise.
 590         (ctf_str_add_ref): Likewise.
 591         (ctf_str_rollback): Likewise.
 592         (ctf_str_purge_refs): Likewise.
 593         (ctf_str_write_strtab): Likewise.
 594         (ctf_realloc): Declare new function in ctf-util.c.
 595
 596         * ctf-open.c (ctf_bufopen): Create the atoms table.
 597         (ctf_file_close): Destroy it.
 598         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
 599         special-case the position of the parname string.  Construct the
 600         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
 601         rest of each buffer element is constructed, not via open-coding:
 602         realloc the CTF buffer and append the strtab to it.  No longer
 603         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
 604         strtab construction.
 605         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
 606         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
 607         after buffer element construction instead.
 608         (ctf_copy_lmembers): Likewise.
 609         (ctf_copy_emembers): Likewise.
 610         (ctf_create): No longer maintain the ctf_dtvstrlen.
 611         (ctf_dtd_delete): Likewise.
 612         (ctf_dvd_delete): Likewise.
 613         (ctf_add_generic): Likewise.
 614         (ctf_add_enumerator): Likewise.
 615         (ctf_add_member_offset): Likewise.
 616         (ctf_add_variable): Likewise.
 617         (membadd): Likewise.
 618         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
 619         if there are active ctf_str_num_refs.
 620         (ctf_strraw): Move to ctf-string.c.
 621         (ctf_strptr): Likewise.
 622         * ctf-string.c: New file, strtab manipulation.
 623
 624         * Makefile.am (libctf_a_SOURCES): Add it.
 625         * Makefile.in: Regenerate.
 626
 627 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 628
 629         * ctf-impl.h (ctf_hash_iter_f): New.
 630         (ctf_dynhash_iter): New declaration.
 631         (ctf_dynhash_iter_remove): New declaration.
 632         * ctf-hash.c (ctf_dynhash_iter): Define.
 633         (ctf_dynhash_iter_remove): Likewise.
 634         (ctf_hashtab_traverse): New.
 635         (ctf_hashtab_traverse_remove): Likewise.
 636         (struct ctf_traverse_cb_arg): Likewise.
 637         (struct ctf_traverse_remove_cb_arg): Likewise.
 638
 639 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 640
 641         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
 642
 643 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 644
 645         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
 646         (ctf_dump_funcs): Likewise.
 647
 648 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 649
 650         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
 651         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
 652         little-endian CTF archive magic.  Do not check the CTF version:
 653         ctf_simple_open does that in endian-safe ways.  Do not dereference
 654         null pointers on open failure.
 655
 656 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 657
 658         * ctf-open.c (get_vbytes_common): Return the new slice size.
 659         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
 660         Remember to copy in the CTF data when opening an uncompressed
 661         foreign-endian CTF file.  Prune useless variable manipulation.
 662
 663 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 664
 665         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
 666         seen.
 667
 668 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 669
 670         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
 671         output.
 672
 673 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 674
 675         * ctf-subr.c (_PAGESIZE): Remove.
 676         (ctf_data_alloc): Likewise.
 677         (ctf_data_free): Likewise.
 678         (ctf_data_protect): Likewise.
 679         * ctf-impl.h: Remove declarations.
 680         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
 681         ctf_free, not ctf_data_free.
 682         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
 683         the buffer again on compression error.
 684         * ctf-open.c (ctf_set_base): No longer track the size: call
 685         ctf_free, not ctf_data_free.
 686         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
 687         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
 688
 689 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 690
 691         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
 692         ctf_dynhash_insert.
 693         (ctf_dvd_insert): Likewise.
 694         (ctf_add_generic): Likewise.
 695         (ctf_add_variable): Likewise.
 696         * ctf-impl.h: Adjust declarations.
 697
 698 2019-06-14  Alan Modra  <amodra@gmail.com>
 699
 700         * configure: Regenerate.
 701
 702 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 703
 704         * ctf-decls.h: Include <libiberty.h>.
 705         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
 706
 707 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 708
 709         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
 710         (ctf_dump_objts): Likewise.
 711         (ctf_dump_funcs): Likewise.
 712         (ctf_dump_member): Likewise.
 713         (ctf_dump_str): Likewise.
 714
 715 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 716
 717         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
 718         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
 719
 720 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
 721
 722         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
 723         (ctf_arc_open_by_offset): Likewise.
 724         * ctf-create.c (ctf_add_type): Likewise.
 725
 726 2019-06-04  Tom Tromey  <tromey@adacore.com>
 727
 728         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
 729         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
 730
 731 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
 732
 733         * configure.ac: Check for O_CLOEXEC.
 734         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
 735         * config.h.in: Regenerate.
 736         * configure: Likewise.
 737
 738 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
 739
 740         * qsort_r.c: Rename to...
 741         * ctf-qsort_r.c: ... this.
 742         (_quicksort): Define to ctf_qsort_r.
 743         * ctf-decls.h (qsort_r): Remove.
 744         (ctf_qsort_r): Add.
 745         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
 746         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
 747         * Makefile.am (libctf_a_LIBADD): Remove.
 748         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
 749         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
 750         * ctf-create.c (ctf_update): Likewise.
 751         * configure.ac: Check for BSD versus GNU qsort_r signature.
 752         * Makefile.in: Regenerate.
 753         * config.h.in: Likewise.
 754         * configure: Likewise.
 755
 756 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
 757
 758         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
 759
 760 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
 761
 762         * Makefile.am (ZLIB): New.
 763         (ZLIBINC): Likewise.
 764         (AM_CFLAGS): Use them.
 765         (libctf_a_LIBADD): New, for LIBOBJS.
 766         * configure.ac: Check for zlib, endian.h, and qsort_r.
 767         * ctf-endian.h: New, providing htole64 and le64toh.
 768         * swap.h: Code style fixes.
 769         (bswap_identity_64): New.
 770         * qsort_r.c: New, from gnulib (with one added #include).
 771         * ctf-decls.h: New, providing a conditional qsort_r declaration,
 772         and unconditional definitions of MIN and MAX.
 773         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
 774         (ctf_set_errno): Now returns unsigned long.
 775         * ctf-util.c (ctf_set_errno): Adjust here too.
 776         * ctf-archive.c: Use ctf-endian.h.
 777         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
 778         cts_flags and cts_offset.
 779         (ctf_arc_write): Drop debugging dependent on the size of off_t.
 780         * ctf-create.c: Provide a definition of roundup if not defined.
 781         (ctf_create): Drop cts_type, cts_flags and cts_offset.
 782         (ctf_add_reftype): Do not check if type IDs are below zero.
 783         (ctf_add_slice): Likewise.
 784         (ctf_add_typedef): Likewise.
 785         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
 786         when known error-free.  Drop CTF_ERR usage for functions returning
 787         int.
 788         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
 789         int.
 790         (ctf_add_variable): Likewise.
 791         (enumcmp): Likewise.
 792         (enumadd): Likewise.
 793         (membcmp): Likewise.
 794         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
 795         when known error-free.
 796         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
 797         returning int: use CTF_ERR for functions returning ctf_type_id.
 798         (ctf_dump_label): Likewise.
 799         (ctf_dump_objts): Likewise.
 800         * ctf-labels.c (ctf_label_topmost): Likewise.
 801         (ctf_label_iter): Likewise.
 802         (ctf_label_info): Likewise.
 803         * ctf-lookup.c (ctf_func_args): Likewise.
 804         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
 805         (ctf_bufopen): Likewise.  Use zlib types as needed.
 806         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
 807         returning int.
 808         (ctf_enum_iter): Likewise.
 809         (ctf_type_size): Likewise.
 810         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
 811         (ctf_type_kind_unsliced): Likewise.
 812         (ctf_type_kind): Likewise.
 813         (ctf_type_encoding): Likewise.
 814         (ctf_member_info): Likewise.
 815         (ctf_array_info): Likewise.
 816         (ctf_enum_value): Likewise.
 817         (ctf_type_rvisit): Likewise.
 818         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
 819         cts_offset.
 820         (ctf_simple_open): Likewise.
 821         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
 822         * Makefile.in: Regenerate.
 823         * aclocal.m4: Likewise.
 824         * config.h: Likewise.
 825         * configure: Likewise.
 826
 827 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 828
 829         * configure.in: Check for bfd_section_from_elf_index.
 830         * configure: Regenerate.
 831         * config.h.in [HAVE_BFD_ELF]: Likewise.
 832         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
 833         abfd is potentially unused now.
 834
 835 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 836
 837         * Makefile.am: New.
 838         * Makefile.in: Regenerated.
 839         * config.h.in: Likewise.
 840         * aclocal.m4: Likewise.
 841         * configure: Likewise.
 842
 843 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 844
 845         * ctf-dump.c: New.
 846
 847 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 848
 849         * ctf-labels.c: New.
 850
 851 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 852
 853         * ctf-impl.h (_libctf_version): New declaration.
 854         * ctf-subr.c (_libctf_version): Define it.
 855         (ctf_version): New.
 856
 857 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 858
 859         * ctf-create.c (enumcmp): New.
 860         (enumadd): Likewise.
 861         (membcmp): Likewise.
 862         (membadd): Likewise.
 863         (ctf_add_type): Likewise.
 864
 865 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 866
 867         * ctf-lookup.c (isqualifier): New.
 868         (ctf_lookup_by_name): Likewise.
 869         (struct ctf_lookup_var_key): Likewise.
 870         (ctf_lookup_var): Likewise.
 871         (ctf_lookup_variable): Likewise.
 872         (ctf_lookup_symbol_name): Likewise.
 873         (ctf_lookup_by_symbol): Likewise.
 874         (ctf_func_info): Likewise.
 875         (ctf_func_args): Likewise.
 876
 877 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 878
 879         * ctf-decl.c: New file.
 880         * ctf-types.c: Likewise.
 881         * ctf-impl.h: New declarations.
 882
 883 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 884
 885         * ctf-open-bfd.c: New file.
 886         * ctf-open.c (ctf_close): New.
 887         * ctf-impl.h: Include bfd.h.
 888         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
 889         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
 890         ctfi_bfd_close.
 891         (ctf_bfdopen_ctfsect): New declaration.
 892         (_CTF_SECTION): likewise.
 893
 894 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 895
 896         * ctf-archive.c: New.
 897         * ctf-impl.h (ctf_archive_internal): New type.
 898         (ctf_arc_open_internal): New declaration.
 899         (ctf_arc_bufopen): Likewise.
 900         (ctf_arc_close_internal): Likewise.
 901
 902 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 903
 904         * ctf-open.c: New file.
 905         * swap.h: Likewise.
 906
 907 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 908
 909         * ctf-create.c: New file.
 910         * ctf-lookup.c: New file.
 911
 912 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 913
 914         * ctf-impl.h: New definitions and declarations for type creation
 915         and lookup.
 916
 917 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 918
 919         * ctf-hash.c: New file.
 920         * ctf-impl.h: New declarations.
 921
 922 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 923
 924         * ctf-error.c: New file.
 925
 926 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 927
 928         * ctf-util.c: New file.
 929         * elf.h: Likewise.
 930         * ctf-impl.h: Include it, and add declarations.
 931
 932 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 933
 934         * ctf-impl.h: New file.
 935         * ctf-subr.c: New file.
 936
 937 \f
 938 Local Variables:
 939 mode: change-log
 940 left-margin: 8
 941 fill-column: 76
 942 version-control: never
 943 End: