libctf/ChangeLog

   1 2020-07-22  Egeyar Bagcioglu  <egeyar.bagcioglu@oracle.com>
   2
   3         * ctf-types.c (ctf_variable_iter): Fix error return.
   4
   5 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
   6
   7         * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
   8
   9 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  10
  11         ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
  12
  13 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  14
  15         * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
  16         sorting functions.
  17         (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
  18         ctf_dynhash_next_sorted.
  19         <cu.ctn_h>: New, pointer to the dynhash under iteration.
  20         <cu.ctn_s>: New, pointer to the dynset under iteration.
  21         (ctf_hash_sort_f): Sorting function passed to...
  22         (ctf_dynhash_next_sorted): ... this new function.
  23         (ctf_dynhash_next): New.
  24         (ctf_dynset_next): New.
  25         * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
  26         (ctf_dynhash_cnext): New.
  27         (ctf_dynset_cnext): New.
  28         * ctf-hash.c (ctf_dynhash_next_sorted): New.
  29         (ctf_dynhash_next): New.
  30         (ctf_dynset_next): New.
  31         * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
  32         needed.
  33         (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
  34
  35 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  36
  37         * ctf-impl.h (ctf_next): New.
  38         (ctf_get_dict): New prototype.
  39         * ctf-lookup.c (ctf_get_dict): New, split out of...
  40         (ctf_lookup_by_id): ... here.
  41         * ctf-util.c (ctf_next_create): New.
  42         (ctf_next_destroy): New.
  43         (ctf_next_copy): New.
  44         * ctf-types.c (includes): Add <assert.h>.
  45         (ctf_member_next): New.
  46         (ctf_enum_next): New.
  47         (ctf_type_iter): Document the lack of iteration over parent
  48         types.
  49         (ctf_type_next): New.
  50         (ctf_variable_next): New.
  51         * ctf-archive.c (ctf_archive_next): New.
  52         * libctf.ver: Add new public functions.
  53
  54 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  55
  56         * libctf.ver (ctf_ref): New.
  57         * ctf-open.c (ctf_ref): Implement it.
  58
  59 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  60
  61         * ctf-inlines.h (ctf_forwardable_kind): New.
  62         * ctf-create.c (ctf_add_forward): Use it.
  63
  64 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  65
  66         * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
  67         * ctf-inlines.h (ctf_get_ctt_size): ... to here.
  68
  69 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  70
  71         * ctf-hash.c (ctf_dynset_eq_string): New.
  72         (ctf_dynset_create): New.
  73         (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
  74         (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
  75         (key_to_internal): New.
  76         (internal_to_key): New.
  77         (ctf_dynset_insert): New.
  78         (ctf_dynset_remove): New.
  79         (ctf_dynset_destroy): New.
  80         (ctf_dynset_lookup): New.
  81         (ctf_dynset_exists): New.
  82         (ctf_dynset_lookup_any): New.
  83         (ctf_hash_insert_type): Coding style.
  84         (ctf_hash_define_type): Likewise.
  85         * ctf-impl.h (ctf_dynset_t): New.
  86         (ctf_dynset_eq_string): New.
  87         (ctf_dynset_create): New.
  88         (ctf_dynset_insert): New.
  89         (ctf_dynset_remove): New.
  90         (ctf_dynset_destroy): New.
  91         (ctf_dynset_lookup): New.
  92         (ctf_dynset_exists): New.
  93         (ctf_dynset_lookup_any): New.
  94         * ctf-inlines.h (ctf_dynset_cinsert): New.
  95
  96 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  97
  98         * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
  99         <value_free>: Likewise.
 100         <owner>: New.
 101         (ctf_dynhash_item_free): Indirect through the owner.
 102         (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
 103         allocate space for the key_free and value_free fields fields
 104         if necessary.
 105         (ctf_hashtab_insert): Likewise.  Fix OOM errno value.
 106         (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
 107         value_free if they will exist.  Set the slot's owner, but only
 108         if it exists.
 109         (ctf_dynhash_remove): Adjust.
 110
 111 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 112
 113         * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
 114         there is a key-freeing function and the key already exists.
 115
 116 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 117
 118         * ctf-inlines.h: New file.
 119         * ctf-impl.h: Include it.
 120         (ctf_hash_iter_find_f): New typedef.
 121         (ctf_dynhash_elements): New.
 122         (ctf_dynhash_lookup_kv): New.
 123         (ctf_dynhash_iter_find): New.
 124         * ctf-hash.c (ctf_dynhash_lookup_kv): New.
 125         (ctf_traverse_find_cb_arg_t): New.
 126         (ctf_hashtab_traverse_find): New.
 127         (ctf_dynhash_iter_find): New.
 128         (ctf_dynhash_elements): New.
 129
 130 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 131
 132         * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
 133
 134 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 135
 136         * ctf-archive.c (ctf_archive_count): New.
 137         * libctf.ver: New public function.
 138
 139 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 140
 141         * ctf-types.c (ctf_member_count): New.
 142         * libctf.ver: New public function.
 143
 144 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 145
 146         * ctf-types.c (ctf_type_kind_forwarded): New.
 147
 148 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 149
 150         * ctf-types.c (ctf_type_name_raw): New.
 151         (ctf_type_aname_raw): Reimplement accordingly.
 152
 153 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 154
 155         * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
 156
 157 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 158
 159         * ctf-impl.h (struct ctf_archive_internal)
 160         <ctfi_unmap_on_close>: New.
 161         (ctf_new_archive_internal): Adjust.
 162         * ctf-archive.c (ctf_new_archive_internal): Likewise.
 163         Initialize ctfi_unmap_on_close.  Adjust error path.
 164         (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
 165         (unmap_on_close is 0).
 166         (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
 167         * ctf-open-bfd.c (ctf_fdopen): Adjust.
 168
 169 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 170
 171         * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
 172         ints, floats or typedefs have no name.  Fix comment typo.
 173
 174 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 175
 176         * ctf-create.c (ctf_add_slice): Support slices of any kind that
 177         resolves to an integral type.
 178         * ctf-types.c (ctf_type_encoding): Resolve the type before
 179         fishing its encoding out.
 180
 181 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 182
 183         * ctf-create.c (ctf_create): Mark dirty.
 184
 185 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 186
 187         * ctf-create.c (membcmp)  Skip nameless members.
 188
 189 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 190
 191         * ctf-create.c (ctf_add_member_offset): Support names of ""
 192         as if they were the null pointer.
 193
 194 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 195
 196         * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
 197         special-casing.
 198
 199 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 200
 201         * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
 202
 203 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 204
 205         * ctf-create.c (ctf_serialize): Add cast.
 206         (ctf_add_slice): Likewise.
 207
 208 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 209
 210         * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
 211         * ctf-create.c (ctf_add_function): Check for unimplemented type
 212         and populate at the same time.  Populate one-by-one, not via
 213         memcpy.
 214         (ctf_serialize): Remove unnecessary cast.
 215         * ctf-types.c (ctf_func_type_info): Likewise.
 216         (ctf_func_type_args): Likewise.  Fix comment typo.
 217
 218 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 219
 220         * ctf-create.c (ctf_add_reftype): Support refs to type zero.
 221         (ctf_add_array): Support array contents of type zero.
 222         (ctf_add_function): Support arguments and return types of
 223         type zero.
 224         (ctf_add_typedef): Support typedefs to type zero.
 225         (ctf_add_member_offset): Support members of type zero,
 226         unless added at unspecified (naturally-aligned) offset.
 227
 228 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 229
 230         * ctf-error.c: Include <stddef.h>, for offsetof.
 231         (_ctf_errlist): Migrate to...
 232         (_ctf_errlist_t): ... this.
 233         (_ctf_erridx): New, indexes into _ctf_errlist_t.
 234         (_ctf_nerr): Remove.
 235         (ctf_errmsg): Adjust accordingly.
 236         * Makefile.am (BUILT_SOURCES): Note...
 237         (ctf-error.h): ... this new rule.
 238         * Makefile.in: Regenerate.
 239         * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
 240         * .gitignore: New, ignore ctf-error.h.
 241
 242 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 243
 244         * ctf-impl.h: Fix typos in comments.
 245
 246 2020-07-22  Nick Clifton  <nickc@redhat.com>
 247
 248         * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
 249         same file descriptor.
 250
 251 2020-07-04  Nick Clifton  <nickc@redhat.com>
 252
 253         Binutils 2.35 branch created.
 254
 255 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 256
 257         * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
 258         alphabetical order.
 259         * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
 260         * config.h.in: Regenerated.
 261         * Makefile.in: Likewise.
 262         * configure: Likewise.
 263
 264 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 265
 266         * ctf-create.c: Include <unistd.h>.
 267         * ctf-open-bfd.c: Likewise.
 268
 269 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 270
 271         PR libctf/25120
 272         * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
 273         * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
 274         means this is declared.
 275         (bswap_32): Likewise.
 276         (bswap_64): Likewise.
 277         (bswap_identity_64): Remove, unused.
 278         * configure: Regenerated.
 279         * config.h.in: Likewise.
 280
 281 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 282
 283         PR libctf/25120
 284         * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
 285         (_libctf_unlikely_): Likewise.
 286         (_libctf_unused): Likewise.
 287         (_libctf_malloc_): Likewise.
 288
 289 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 290
 291         PR libctf/25120
 292         * ctf-archive.c (search_nametbl): No longer global: declare...
 293         (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
 294         (search_modent_by_name): Take and use ARG for the nametbl.
 295
 296 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 297
 298         * ctf-impl.h (ctf_new_archive_internal): Declare.
 299         (ctf_arc_bufopen): Remove.
 300         (ctf_archive_internal) <ctfi_free_symsect>: New.
 301         * ctf-archive.c (ctf_arc_close): Use it.
 302         (ctf_arc_bufopen): Fuse into...
 303         (ctf_new_archive_internal): ... this, moved across from...
 304         * ctf-open-bfd.c: ... here.
 305         (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
 306         * libctf.ver: Add it.
 307
 308 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 309
 310         * ctf-create.c (ctf_add_forward): Intern in the right namespace.
 311         (ctf_dtd_delete): Remove correspondingly.
 312         (ctf_rollback): Likewise.
 313
 314 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 315
 316         * ctf-create.c (ctf_add_type_internal): Hand back existing types
 317         unchanged.
 318
 319 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 320
 321         * ctf-create.c (ctf_add_forward): Don't add forwards to
 322         types that already exist.
 323
 324 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 325
 326         * ctf-open.c (init_types): Only intern root-visible types.
 327         * ctf-create.c (ctf_dtd_insert): Likewise.
 328         (ctf_dtd_delete): Only remove root-visible types.
 329         (ctf_rollback): Likewise.
 330         (ctf_add_generic): Adjust.
 331         (ctf_add_struct_sized): Adjust comment.
 332         (ctf_add_union_sized): Likewise.
 333         (ctf_add_enum): Likewise.
 334         * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
 335
 336 2020-03-11  John Baldwin  <jhb@FreeBSD.org>
 337
 338         * swap.h (bswap_identity_64): Make static.
 339
 340 2020-01-18  Nick Clifton  <nickc@redhat.com>
 341
 342         Binutils 2.34 branch created.
 343
 344 2020-01-05  Joel Brobecker  <brobecker@adacore.com>
 345
 346         PR binutils/25155:
 347         * configure.ac: Add AC_CHECK_DECLS([asprintf]).
 348         * configure, config.h.in: Regenerate.
 349
 350 2020-01-01  Alan Modra  <amodra@gmail.com>
 351
 352         Update year range in copyright notice of all files.
 353
 354 2019-10-16  Simon Marchi  <simon.marchi@polymtl.ca>
 355
 356         * swap.h (bswap_16, bswap_32, bswap_64): Make static.
 357
 358 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 359
 360         * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
 361         * ctf-types.c (ctf_type_lname): Likewise.
 362
 363 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 364
 365         * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
 366         ctf_import after the first for a given file.
 367
 368 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 369
 370         * ctf-impl.h (ctf_str_append_noerr): Declare.
 371         * ctf-util.c (ctf_str_append_noerr): Define in terms of
 372         ctf_str_append.
 373         * ctf-dump.c (str_append): New, call it.
 374         (ctf_dump_format_type): Use str_append, not ctf_str_append.
 375         (ctf_dump_label): Likewise.
 376         (ctf_dump_objts): Likewise.
 377         (ctf_dump_funcs): Likewise.
 378         (ctf_dump_var): Likewise.
 379         (ctf_dump_member): Likewise.
 380         (ctf_dump_type): Likewise.
 381         (ctf_dump): Likewise.
 382
 383 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 384
 385         * ctf-impl.h (ctf_alloc): Remove.
 386         (ctf_free): Likewise.
 387         (ctf_strdup): Likewise.
 388         * ctf-subr.c (ctf_alloc): Remove.
 389         (ctf_free): Likewise.
 390         * ctf-util.c (ctf_strdup): Remove.
 391
 392         * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
 393         ctf_free; strdup, not ctf_strdup.
 394         (ctf_dtd_delete): Likewise.
 395         (ctf_dvd_delete): Likewise.
 396         (ctf_add_generic): Likewise.
 397         (ctf_add_function): Likewise.
 398         (ctf_add_enumerator): Likewise.
 399         (ctf_add_member_offset): Likewise.
 400         (ctf_add_variable): Likewise.
 401         (membadd): Likewise.
 402         (ctf_compress_write): Likewise.
 403         (ctf_write_mem): Likewise.
 404         * ctf-decl.c (ctf_decl_push): Likewise.
 405         (ctf_decl_fini): Likewise.
 406         (ctf_decl_sprintf): Likewise.  Check for OOM.
 407         * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
 408         ctf_free; strdup, not ctf_strdup.
 409         (ctf_dump_free): Likewise.
 410         (ctf_dump): Likewise.
 411         * ctf-open.c (upgrade_types_v1): Likewise.
 412         (init_types): Likewise.
 413         (ctf_file_close): Likewise.
 414         (ctf_bufopen_internal): Likewise.  Check for OOM.
 415         (ctf_parent_name_set): Likewise: report the OOM to the caller.
 416         (ctf_cuname_set): Likewise.
 417         (ctf_import): Likewise.
 418         * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
 419         free, not ctf_free; strdup, not ctf_strdup.
 420         (ctf_str_free_atom): Likewise.
 421         (ctf_str_create_atoms): Likewise.
 422         (ctf_str_add_ref_internal): Likewise.
 423         (ctf_str_remove_ref): Likewise.
 424         (ctf_str_write_strtab): Likewise.
 425
 426 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 427
 428         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
 429         work right for non-int/fps.
 430
 431 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
 432
 433         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
 434         null pointer.
 435
 436 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
 437
 438         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
 439         * ctf-open.c (ctf_file_close): Free it.
 440         * ctf-create.c (ctf_serialize): Adjust.
 441         (membcmp): When reporting a conflict due to an error, report the
 442         error.
 443         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
 444         (ctf_add_type_internal): ... this.  Hand back types we are already
 445         in the middle of adding immediately.  Hand back structs/unions with
 446         the same number of members immediately.  Do not walk the dynamic
 447         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
 448         forwards promoted to other types and the inverse case identically.
 449         Add structs to the mapping as soon as we intern them, before they
 450         gain any members.
 451
 452 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 453
 454         * ctf-impl.h (ctf_names_t): New.
 455         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
 456         (ctf_file_t) <ctf_structs>: Likewise.
 457         <ctf_unions>: Likewise.
 458         <ctf_enums>: Likewise.
 459         <ctf_names>: Likewise.
 460         <ctf_lookups>: Improve comment.
 461         <ctf_ptrtab_len>: New.
 462         <ctf_prov_strtab>: New.
 463         <ctf_str_prov_offset>: New.
 464         <ctf_dtbyname>: Remove, redundant to the names hashes.
 465         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
 466         (ctf_dtdef_t) <dtd_name>: Remove.
 467         <dtd_data>: Note that the ctt_name is now populated.
 468         (ctf_str_atom_t) <csa_offset>: This is now the strtab
 469         offset for internal strings too.
 470         <csa_external_offset>: New, the external strtab offset.
 471         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
 472         (ctf_name_table): New declaration.
 473         (ctf_lookup_by_rawname): Likewise.
 474         (ctf_lookup_by_rawhash): Likewise.
 475         (ctf_set_ctl_hashes): Likewise.
 476         (ctf_serialize): Likewise.
 477         (ctf_dtd_insert): Adjust.
 478         (ctf_simple_open_internal): Likewise.
 479         (ctf_bufopen_internal): Likewise.
 480         (ctf_list_empty_p): Likewise.
 481         (ctf_str_remove_ref): Likewise.
 482         (ctf_str_add): Returns uint32_t now.
 483         (ctf_str_add_ref): Likewise.
 484         (ctf_str_add_external): Now returns a boolean (int).
 485         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
 486         for strings in the appropriate range.
 487         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
 488         when adding the null string to the new strtab.
 489         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
 490         (ctf_str_add_ref_internal): Add make_provisional argument.  If
 491         make_provisional, populate the offset and fill in the
 492         ctf_prov_strtab accordingly.
 493         (ctf_str_add): Return the offset, not the string.
 494         (ctf_str_add_ref): Likewise.
 495         (ctf_str_add_external): Return a success integer.
 496         (ctf_str_remove_ref): New, remove a single ref.
 497         (ctf_str_count_strtab): Do not count the initial null string's
 498         length or the existence or length of any unreferenced internal
 499         atoms.
 500         (ctf_str_populate_sorttab): Skip atoms with no refs.
 501         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
 502         to the cts_len for the null string, since it is no longer done
 503         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
 504         Populate the csa_offset for both internal and external cases.
 505         Flush the ctf_prov_strtab afterwards, and reset the
 506         ctf_str_prov_offset.
 507         * ctf-create.c (ctf_grow_ptrtab): New.
 508         (ctf_create): Call it.  Initialize new fields rather than old
 509         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
 510         Set the ctl hashes and data model.
 511         (ctf_update): Rename to...
 512         (ctf_serialize): ... this.  Leave a compatibility function behind.
 513         Tell ctf_simple_open_internal that this is a writable dictionary.
 514         Pass the new fields along from the old dictionary.  Drop
 515         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
 516         Do not zero out the DTD's ctt_name.
 517         (ctf_prefixed_name): Rename to...
 518         (ctf_name_table): ... this.  No longer return a prefixed name: return
 519         the applicable name table instead.
 520         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
 521         kind we're adding.  Migrate away from dtd_name.
 522         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
 523         deleted ctt_name.
 524         (ctf_dtd_lookup_type_by_name): Remove.
 525         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
 526         No longer check ctf_dtnextid: check ctf_typemax instead.
 527         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
 528         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
 529         ctf_name_table and the right name table, and migrate away from
 530         dtd_name as in ctf_dtd_delete.
 531         (ctf_add_generic): Pass in the kind explicitly and pass it to
 532         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
 533         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
 534         Grow the ptrtab if needed.
 535         (ctf_add_encoded): Pass in the kind.
 536         (ctf_add_slice): Likewise.
 537         (ctf_add_array): Likewise.
 538         (ctf_add_function): Likewise.
 539         (ctf_add_typedef): Likewise.
 540         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
 541         ctt_name rather than dtd_name.
 542         (ctf_add_struct_sized): Pass in the kind.  Use
 543         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
 544         ctf_dtd_lookup_type_by_name.
 545         (ctf_add_union_sized): Likewise.
 546         (ctf_add_enum): Likewise.
 547         (ctf_add_enum_encoded): Likewise.
 548         (ctf_add_forward): Likewise.
 549         (ctf_add_type): Likewise.
 550         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
 551         being initialized until after the call.
 552         (ctf_write_mem): Likewise.
 553         (ctf_write): Likewise.
 554         * ctf-archive.c (arc_write_one_ctf): Likewise.
 555         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
 556         ctf_hash_lookup_type.
 557         (ctf_lookup_by_id): No longer check the readonly types if the
 558         dictionary is writable.
 559         * ctf-open.c (init_types): Assert that this dictionary is not
 560         writable.  Adjust to use the new name hashes, ctf_name_table,
 561         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
 562         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
 563         if set.  Drop out early when dictionary is writable.  Split the
 564         ctf_lookups initialization into...
 565         (ctf_set_cth_hashes): ... this new function.
 566         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
 567         (ctf_simple_open): Adjust accordingly.
 568         (ctf_bufopen): Likewise.
 569         (ctf_file_close): Destroy the appropriate name hashes.  No longer
 570         destroy ctf_dtbyname, which is gone.
 571         (ctf_getdatasect): Remove spurious "extern".
 572         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
 573         specified name table, given a kind.
 574         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
 575         (ctf_member_iter): Add support for iterating over the
 576         dynamic type list.
 577         (ctf_enum_iter): Likewise.
 578         (ctf_variable_iter): Likewise.
 579         (ctf_type_rvisit): Likewise.
 580         (ctf_member_info): Add support for types in the dynamic type list.
 581         (ctf_enum_name): Likewise.
 582         (ctf_enum_value): Likewise.
 583         (ctf_func_type_info): Likewise.
 584         (ctf_func_type_args): Likewise.
 585         * ctf-link.c (ctf_accumulate_archive_names): No longer call
 586         ctf_update.
 587         (ctf_link_write): Likewise.
 588         (ctf_link_intern_extern_string): Adjust for new
 589         ctf_str_add_external return value.
 590         (ctf_link_add_strtab): Likewise.
 591         * ctf-util.c (ctf_list_empty_p): New.
 592
 593 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
 594
 595         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
 596         type zero.
 597         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
 598         members and types.
 599         (ctf_add_variable): Likewise for variables pointing to them.
 600         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
 601         type link failure, but do warn for others.
 602         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
 603         errors to be ENOMEM.
 604         (ctf_dump_member): Likewise.
 605         (ctf_dump_type): Likewise.
 606         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
 607         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
 608         (ctf_dump_header): Likewise.
 609         (ctf_dump_label): likewise.
 610         (ctf_dump_objts): likewise.
 611         (ctf_dump_funcs): likewise.
 612         (ctf_dump_var): likewise.
 613         (ctf_dump_str): Likewise.
 614
 615 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 616
 617         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
 618         (LT_INIT): Likewise.
 619         (AM_INSTALL_LIBBFD): Likewise.
 620         (dlopen): Note why this is necessary in a comment.
 621         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
 622         opcodes/.
 623         (SHARED_LDFLAGS): Likewise.
 624         (BFD_LIBADD): Likewise, for libbfd.
 625         (BFD_DEPENDENCIES): Likewise.
 626         (VERSION_FLAGS): Initialize, using a version script if ld supports
 627         one, or libtool -export-symbols-regex otherwise.
 628         (AC_CONFIG_MACRO_DIR): Add ../BFD.
 629         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
 630         (INCDIR): New.
 631         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
 632         (noinst_LIBRARIES): Replace with...
 633         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
 634         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
 635         libctf-nobfd.la as well.
 636         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
 637         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
 638         (libctf_a_SOURCES): Rename to...
 639         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
 640         ctf-open-bfd.c.
 641         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
 642         with ctf-open-bfd.c added.
 643         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
 644         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
 645         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
 646         * Makefile.am [INSTALL_LIBCTF]: Use it.
 647         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
 648         libtool macros.
 649         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
 650         the unstable components).
 651         * Makefile.in: Regenerated.
 652         * config.h.in: Likewise.
 653         * configure: Likewise.
 654
 655 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 656
 657         * configure.ac (INSTALL_LIBCTF): New, controlled by
 658         --enable-install-libctf.
 659         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
 660         * Makefile.in: Regenerated.
 661         * configure: Regenerated.
 662
 663 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 664
 665         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
 666         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
 667
 668 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 669
 670         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
 671
 672 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 673
 674         * ctf-impl.h (includes): Include <sys/param.h> here.
 675
 676 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 677
 678         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
 679         (flip_objts): Likewise.
 680         (flip_vars): Likewise.
 681         (flip_types): Likewise.
 682
 683 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 684
 685         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
 686         freeing functions: if set, free the key and value if the slot
 687         already exists.  Always reassign the key.
 688         (ctf_dynhash_insert): Adjust call appropriately.
 689         (ctf_hash_insert_type): Likewise.
 690
 691 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
 692
 693         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
 694         type kind.  Allow forwards to unify with pre-existing structs/
 695         unions/enums.
 696
 697 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 698
 699         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
 700         <ctf_link_memb_name_changer>: Likewise.
 701         <ctf_link_memb_name_changer_arg>: Likewise.
 702         * ctf-create.c (ctf_update): Update accordingly.
 703         * ctf-open.c (ctf_file_close): Likewise.
 704         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
 705         (ctf_link_add_cu_mapping): New.
 706         (ctf_link_set_memb_name_changer): Likewise.
 707         (ctf_change_parent_name): New.
 708         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
 709         allocated by the caller's ctf_link_memb_name_changer.
 710         <ndynames>: Likewise.
 711         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
 712         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
 713         ctf_change_parent_name.  Free any resulting names.
 714
 715 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 716
 717         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
 718         (ctf_link_one_type): ... here, with parent-name setting added.
 719         (check_variable): New.
 720         (ctf_link_one_variable): Likewise.
 721         (ctf_link_one_input_archive_member): Call it.
 722         * ctf-error.c (_ctf_errlist): Updated with new errors.
 723
 724 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 725
 726         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
 727         (struct ctf_link_type_mapping_key): New.
 728         (ctf_hash_type_mapping_key): Likewise.
 729         (ctf_hash_eq_type_mapping_key): Likewise.
 730         (ctf_add_type_mapping): Likewise.
 731         (ctf_type_mapping): Likewise.
 732         (ctf_dynhash_empty): Likewise.
 733         * ctf-open.c (ctf_file_close): Update accordingly.
 734         * ctf-create.c (ctf_update): Likewise.
 735         (ctf_add_type): Populate the mapping.
 736         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
 737         (ctf_hash_eq_type_mapping_key): Check the key for equality.
 738         (ctf_dynhash_insert): Fix comment typo.
 739         (ctf_dynhash_empty): New.
 740         * ctf-link.c (ctf_add_type_mapping): New.
 741         (ctf_type_mapping): Likewise.
 742         (empty_link_type_mapping): New.
 743         (ctf_link_one_input_archive): Call it.
 744
 745 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 746
 747         * ctf-link.c: New file, linking of the string and type sections.
 748         * Makefile.am (libctf_a_SOURCES): Add it.
 749         * Makefile.in: Regenerate.
 750
 751         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
 752         ctf_link_outputs.
 753         * ctf-create.c (ctf_update): Update accordingly.
 754         * ctf-open.c (ctf_file_close): Likewise.
 755         * ctf-error.c (_ctf_errlist): Updated with new errors.
 756
 757 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 758
 759         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
 760
 761 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 762
 763         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
 764         ctf_type_iter.
 765         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
 766         (ctf_dump_format_type): Add non-root-type { } notation.
 767         Add root flag to prototype.
 768         (ctf_dump_label): Adjust accordingly.
 769         (ctf_dump_objts): Likewise.
 770         (ctf_dump_var): Likewise.
 771
 772 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 773
 774         * ctf-create.c (ctf_compress_write): Fix double-free.
 775
 776 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 777
 778         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
 779         of...
 780         (ctf_arc_write_fd): ... this new function.
 781         * ctf-create.c (ctf_write_mem): New.
 782
 783 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 784
 785         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
 786         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
 787         (ctf_str_add_ref): Name the last arg.
 788         (ctf_str_add_external) New.
 789         (ctf_str_add_strraw_explicit): Likewise.
 790         (ctf_simple_open_internal): Likewise.
 791         (ctf_bufopen_internal): Likewise.
 792
 793         * ctf-string.c (ctf_strraw_explicit): Split from...
 794         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
 795         (ctf_str_add_ref_internal): Return the atom, not the
 796         string.
 797         (ctf_str_add): Adjust accordingly.
 798         (ctf_str_add_ref): Likewise.  Move up in the file.
 799         (ctf_str_add_external): New: update the csa_offset.
 800         (ctf_str_count_strtab): Only account for strings with no csa_offset
 801         in the internal strtab length.
 802         (ctf_str_write_strtab): If the csa_offset is set, update the
 803         string's refs without writing the string out, and update the
 804         ctf_syn_ext_strtab.  Make OOM handling less ugly.
 805         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
 806         (ctf_update): Handle failure to populate the strtab.  Pass in the
 807         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
 808         Call ctf_simple_open_internal, not ctf_simple_open.
 809         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
 810         strings by hand.
 811         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
 812         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
 813         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
 814         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
 815         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
 816         (ctf_simple_open_internal): ... this new function, which calls
 817         ctf_bufopen_internal.
 818         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
 819         (ctf_bufopen_internal): ... this new function, which sets
 820         ctf_syn_ext_strtab.
 821
 822 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 823
 824         * ctf_types.c (ctf_type_iter_all): New.
 825
 826 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 827
 828         * ctf-open.c (init_symtab): Check for overflow against the right
 829         section.
 830         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
 831         (upgrade_types_v1): Note that these sections are not checked.
 832         (flip_header): Endian-swap the header fields.
 833         (flip_ctf): Endian-swap the sections.
 834         (flip_objts): Update comment.
 835         (ctf_bufopen): Check header offsets and alignment for validity.
 836
 837 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 838
 839         * ctf-open-bfd.c: Add <assert.h>.
 840         (ctf_bfdopen_ctfsect): Open string and symbol tables using
 841         techniques borrowed from bfd_elf_sym_name.
 842         (ctf_new_archive_internal): Improve comment.
 843         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
 844         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
 845         no symbol section, but not vice versa.
 846
 847 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
 848
 849         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
 850         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
 851         * ctf-dump.c (dump_header): New function, dump the CTF header.
 852         (ctf_dump): Call it.
 853         (ctf_dump_header_strfield): New function.
 854         (ctf_dump_header_sectfield): Likewise.
 855
 856 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
 857
 858         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
 859         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
 860         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
 861         ctf_base: do not assume that it is always sizeof (ctf_header_t).
 862         Print out ctf_cuname: only print out ctf_parname if set.
 863         (ctf_free_base): Removed, ctf_base is no longer freed: free
 864         ctf_dynbase instead.
 865         (ctf_set_version): Fix spacing.
 866         (upgrade_header): New, in-place header upgrading.
 867         (upgrade_types): Rename to...
 868         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
 869         longer track old and new headers separately.  No longer allow for
 870         header sizes explicitly: squeeze the headers out on upgrade (they
 871         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
 872         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
 873         (upgrade_types): New, also handle ctf_parmax updating.
 874         (flip_header): Flip ctf_cuname.
 875         (flip_types): Flip BUF explicitly rather than deriving BUF from
 876         BASE.
 877         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
 878         required alignment of objtoff and funcoff.  No longer store it in
 879         the ctf_buf unless that buf is derived unmodified from the input.
 880         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
 881         that duplicate fields in ctf_file: move allocation of ctf_file
 882         further up instead.  Call upgrade_header as needed.  Move
 883         version-specific ctf_parmax initialization into upgrade_types.  More
 884         concise error handling.
 885         (ctf_file_close): No longer test for null pointers before freeing.
 886         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
 887         ctf_free_base.
 888         (ctf_cuname): New.
 889         (ctf_cuname_set): New.
 890         * ctf-create.c (ctf_update): Populate ctf_cuname.
 891         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
 892         comment.
 893         (ctf_write): Likewise.
 894         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
 895         Fix the compression length: fp->ctf_size never counted the CTF
 896         header.  Simplify the compress call accordingly.
 897
 898 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
 899
 900         * ctf-endian.h: Don't assume htole64 and le64toh are always
 901         present if HAVE_ENDIAN_H; also check if htole64 is defined.
 902         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
 903         not bswap_identity_64.
 904
 905 2019-09-18  Alan Modra  <amodra@gmail.com>
 906
 907         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
 908
 909 2019-09-09  Phil Blundell  <pb@pbcl.net>
 910
 911         binutils 2.33 branch created.
 912
 913 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
 914
 915         * ctf-types.c (ctf_type_aname_raw): New.
 916         (ctf_func_type_info): Likewise.
 917         (ctf_func_type_args): Likewise.
 918         * ctf-error.c (_ctf_errlist): Fix description.
 919         * ctf-lookup.c: Fix file description.
 920
 921 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 922
 923         * ctf-create.c (ctf_create): Fix off-by-one error.
 924
 925 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 926
 927         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
 928         struct ctf_strs.
 929         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
 930         (struct ctf_str_atom): New, disambiguated single string.
 931         (struct ctf_str_atom_ref): New, points to some other location that
 932         references this string's offset.
 933         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
 934         Remove member ctf_dtvstrlen: we no longer track the total strlen
 935         as we add strings.
 936         (ctf_str_create_atoms): Declare new function in ctf-string.c.
 937         (ctf_str_free_atoms): Likewise.
 938         (ctf_str_add): Likewise.
 939         (ctf_str_add_ref): Likewise.
 940         (ctf_str_rollback): Likewise.
 941         (ctf_str_purge_refs): Likewise.
 942         (ctf_str_write_strtab): Likewise.
 943         (ctf_realloc): Declare new function in ctf-util.c.
 944
 945         * ctf-open.c (ctf_bufopen): Create the atoms table.
 946         (ctf_file_close): Destroy it.
 947         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
 948         special-case the position of the parname string.  Construct the
 949         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
 950         rest of each buffer element is constructed, not via open-coding:
 951         realloc the CTF buffer and append the strtab to it.  No longer
 952         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
 953         strtab construction.
 954         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
 955         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
 956         after buffer element construction instead.
 957         (ctf_copy_lmembers): Likewise.
 958         (ctf_copy_emembers): Likewise.
 959         (ctf_create): No longer maintain the ctf_dtvstrlen.
 960         (ctf_dtd_delete): Likewise.
 961         (ctf_dvd_delete): Likewise.
 962         (ctf_add_generic): Likewise.
 963         (ctf_add_enumerator): Likewise.
 964         (ctf_add_member_offset): Likewise.
 965         (ctf_add_variable): Likewise.
 966         (membadd): Likewise.
 967         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
 968         if there are active ctf_str_num_refs.
 969         (ctf_strraw): Move to ctf-string.c.
 970         (ctf_strptr): Likewise.
 971         * ctf-string.c: New file, strtab manipulation.
 972
 973         * Makefile.am (libctf_a_SOURCES): Add it.
 974         * Makefile.in: Regenerate.
 975
 976 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 977
 978         * ctf-impl.h (ctf_hash_iter_f): New.
 979         (ctf_dynhash_iter): New declaration.
 980         (ctf_dynhash_iter_remove): New declaration.
 981         * ctf-hash.c (ctf_dynhash_iter): Define.
 982         (ctf_dynhash_iter_remove): Likewise.
 983         (ctf_hashtab_traverse): New.
 984         (ctf_hashtab_traverse_remove): Likewise.
 985         (struct ctf_traverse_cb_arg): Likewise.
 986         (struct ctf_traverse_remove_cb_arg): Likewise.
 987
 988 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 989
 990         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
 991
 992 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 993
 994         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
 995         (ctf_dump_funcs): Likewise.
 996
 997 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 998
 999         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1000         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1001         little-endian CTF archive magic.  Do not check the CTF version:
1002         ctf_simple_open does that in endian-safe ways.  Do not dereference
1003         null pointers on open failure.
1004
1005 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1006
1007         * ctf-open.c (get_vbytes_common): Return the new slice size.
1008         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1009         Remember to copy in the CTF data when opening an uncompressed
1010         foreign-endian CTF file.  Prune useless variable manipulation.
1011
1012 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1013
1014         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1015         seen.
1016
1017 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1018
1019         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1020         output.
1021
1022 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1023
1024         * ctf-subr.c (_PAGESIZE): Remove.
1025         (ctf_data_alloc): Likewise.
1026         (ctf_data_free): Likewise.
1027         (ctf_data_protect): Likewise.
1028         * ctf-impl.h: Remove declarations.
1029         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1030         ctf_free, not ctf_data_free.
1031         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
1032         the buffer again on compression error.
1033         * ctf-open.c (ctf_set_base): No longer track the size: call
1034         ctf_free, not ctf_data_free.
1035         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
1036         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
1037
1038 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1039
1040         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1041         ctf_dynhash_insert.
1042         (ctf_dvd_insert): Likewise.
1043         (ctf_add_generic): Likewise.
1044         (ctf_add_variable): Likewise.
1045         * ctf-impl.h: Adjust declarations.
1046
1047 2019-06-14  Alan Modra  <amodra@gmail.com>
1048
1049         * configure: Regenerate.
1050
1051 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1052
1053         * ctf-decls.h: Include <libiberty.h>.
1054         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1055
1056 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1057
1058         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1059         (ctf_dump_objts): Likewise.
1060         (ctf_dump_funcs): Likewise.
1061         (ctf_dump_member): Likewise.
1062         (ctf_dump_str): Likewise.
1063
1064 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1065
1066         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1067         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1068
1069 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
1070
1071         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1072         (ctf_arc_open_by_offset): Likewise.
1073         * ctf-create.c (ctf_add_type): Likewise.
1074
1075 2019-06-04  Tom Tromey  <tromey@adacore.com>
1076
1077         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1078         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1079
1080 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1081
1082         * configure.ac: Check for O_CLOEXEC.
1083         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1084         * config.h.in: Regenerate.
1085         * configure: Likewise.
1086
1087 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1088
1089         * qsort_r.c: Rename to...
1090         * ctf-qsort_r.c: ... this.
1091         (_quicksort): Define to ctf_qsort_r.
1092         * ctf-decls.h (qsort_r): Remove.
1093         (ctf_qsort_r): Add.
1094         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1095         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1096         * Makefile.am (libctf_a_LIBADD): Remove.
1097         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1098         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1099         * ctf-create.c (ctf_update): Likewise.
1100         * configure.ac: Check for BSD versus GNU qsort_r signature.
1101         * Makefile.in: Regenerate.
1102         * config.h.in: Likewise.
1103         * configure: Likewise.
1104
1105 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
1106
1107         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1108
1109 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
1110
1111         * Makefile.am (ZLIB): New.
1112         (ZLIBINC): Likewise.
1113         (AM_CFLAGS): Use them.
1114         (libctf_a_LIBADD): New, for LIBOBJS.
1115         * configure.ac: Check for zlib, endian.h, and qsort_r.
1116         * ctf-endian.h: New, providing htole64 and le64toh.
1117         * swap.h: Code style fixes.
1118         (bswap_identity_64): New.
1119         * qsort_r.c: New, from gnulib (with one added #include).
1120         * ctf-decls.h: New, providing a conditional qsort_r declaration,
1121         and unconditional definitions of MIN and MAX.
1122         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
1123         (ctf_set_errno): Now returns unsigned long.
1124         * ctf-util.c (ctf_set_errno): Adjust here too.
1125         * ctf-archive.c: Use ctf-endian.h.
1126         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
1127         cts_flags and cts_offset.
1128         (ctf_arc_write): Drop debugging dependent on the size of off_t.
1129         * ctf-create.c: Provide a definition of roundup if not defined.
1130         (ctf_create): Drop cts_type, cts_flags and cts_offset.
1131         (ctf_add_reftype): Do not check if type IDs are below zero.
1132         (ctf_add_slice): Likewise.
1133         (ctf_add_typedef): Likewise.
1134         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1135         when known error-free.  Drop CTF_ERR usage for functions returning
1136         int.
1137         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1138         int.
1139         (ctf_add_variable): Likewise.
1140         (enumcmp): Likewise.
1141         (enumadd): Likewise.
1142         (membcmp): Likewise.
1143         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
1144         when known error-free.
1145         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1146         returning int: use CTF_ERR for functions returning ctf_type_id.
1147         (ctf_dump_label): Likewise.
1148         (ctf_dump_objts): Likewise.
1149         * ctf-labels.c (ctf_label_topmost): Likewise.
1150         (ctf_label_iter): Likewise.
1151         (ctf_label_info): Likewise.
1152         * ctf-lookup.c (ctf_func_args): Likewise.
1153         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1154         (ctf_bufopen): Likewise.  Use zlib types as needed.
1155         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1156         returning int.
1157         (ctf_enum_iter): Likewise.
1158         (ctf_type_size): Likewise.
1159         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
1160         (ctf_type_kind_unsliced): Likewise.
1161         (ctf_type_kind): Likewise.
1162         (ctf_type_encoding): Likewise.
1163         (ctf_member_info): Likewise.
1164         (ctf_array_info): Likewise.
1165         (ctf_enum_value): Likewise.
1166         (ctf_type_rvisit): Likewise.
1167         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1168         cts_offset.
1169         (ctf_simple_open): Likewise.
1170         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
1171         * Makefile.in: Regenerate.
1172         * aclocal.m4: Likewise.
1173         * config.h: Likewise.
1174         * configure: Likewise.
1175
1176 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1177
1178         * configure.in: Check for bfd_section_from_elf_index.
1179         * configure: Regenerate.
1180         * config.h.in [HAVE_BFD_ELF]: Likewise.
1181         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1182         abfd is potentially unused now.
1183
1184 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1185
1186         * Makefile.am: New.
1187         * Makefile.in: Regenerated.
1188         * config.h.in: Likewise.
1189         * aclocal.m4: Likewise.
1190         * configure: Likewise.
1191
1192 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1193
1194         * ctf-dump.c: New.
1195
1196 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1197
1198         * ctf-labels.c: New.
1199
1200 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1201
1202         * ctf-impl.h (_libctf_version): New declaration.
1203         * ctf-subr.c (_libctf_version): Define it.
1204         (ctf_version): New.
1205
1206 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1207
1208         * ctf-create.c (enumcmp): New.
1209         (enumadd): Likewise.
1210         (membcmp): Likewise.
1211         (membadd): Likewise.
1212         (ctf_add_type): Likewise.
1213
1214 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1215
1216         * ctf-lookup.c (isqualifier): New.
1217         (ctf_lookup_by_name): Likewise.
1218         (struct ctf_lookup_var_key): Likewise.
1219         (ctf_lookup_var): Likewise.
1220         (ctf_lookup_variable): Likewise.
1221         (ctf_lookup_symbol_name): Likewise.
1222         (ctf_lookup_by_symbol): Likewise.
1223         (ctf_func_info): Likewise.
1224         (ctf_func_args): Likewise.
1225
1226 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1227
1228         * ctf-decl.c: New file.
1229         * ctf-types.c: Likewise.
1230         * ctf-impl.h: New declarations.
1231
1232 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1233
1234         * ctf-open-bfd.c: New file.
1235         * ctf-open.c (ctf_close): New.
1236         * ctf-impl.h: Include bfd.h.
1237         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1238         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1239         ctfi_bfd_close.
1240         (ctf_bfdopen_ctfsect): New declaration.
1241         (_CTF_SECTION): likewise.
1242
1243 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1244
1245         * ctf-archive.c: New.
1246         * ctf-impl.h (ctf_archive_internal): New type.
1247         (ctf_arc_open_internal): New declaration.
1248         (ctf_arc_bufopen): Likewise.
1249         (ctf_arc_close_internal): Likewise.
1250
1251 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1252
1253         * ctf-open.c: New file.
1254         * swap.h: Likewise.
1255
1256 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1257
1258         * ctf-create.c: New file.
1259         * ctf-lookup.c: New file.
1260
1261 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1262
1263         * ctf-impl.h: New definitions and declarations for type creation
1264         and lookup.
1265
1266 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1267
1268         * ctf-hash.c: New file.
1269         * ctf-impl.h: New declarations.
1270
1271 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1272
1273         * ctf-error.c: New file.
1274
1275 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1276
1277         * ctf-util.c: New file.
1278         * elf.h: Likewise.
1279         * ctf-impl.h: Include it, and add declarations.
1280
1281 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1282
1283         * ctf-impl.h: New file.
1284         * ctf-subr.c: New file.
1285
1286 \f
1287 Local Variables:
1288 mode: change-log
1289 left-margin: 8
1290 fill-column: 76
1291 version-control: never
1292 End: