libctf/ChangeLog

   1 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
   2
   3         * ctf-link.c (ctf_link_write): Close the fd.
   4
   5 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
   6
   7         * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
   8         * Makefile.in: Regenerated.
   9         * ctf-impl.h (ctf_link_input_name): New.
  10         (ctf_file_t) <ctf_link_flags>: New.
  11         * ctf-create.c (ctf_serialize): Adjust accordingly.
  12         * ctf-link.c: Define ctf_open as weak when PIC.
  13         (ctf_arc_close_thunk): Remove unnecessary thunk.
  14         (ctf_file_close_thunk): Likewise.
  15         (ctf_link_input_name): New.
  16         (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
  17         (ctf_link_input_close): Adjust accordingly.
  18         (ctf_link_add_ctf_internal): New, split from...
  19         (ctf_link_add_ctf): ... here.  Return error if lazy loading of
  20         CTF is not possible.  Change to just call...
  21         (ctf_link_add): ... this new function.
  22         (ctf_link_add_cu_mapping): Transition to ctf_err_warn.  Drop the
  23         ctf_file_close_thunk.
  24         (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
  25         <in_file_name>: ... this.
  26         <arcname>: Drop.
  27         <share_mode>: Likewise (migrated to ctf_link_flags).
  28         <done_main_member>: Rename to...
  29         <done_parent>: ... this.
  30         <main_input_fp>: Rename to...
  31         <in_fp_parent>: ... this.
  32         <cu_mapped>: New.
  33         (ctf_link_one_type): Adjuwt accordingly.  Transition to
  34         ctf_err_warn, removing a TODO.
  35         (ctf_link_one_variable): Note a case too common to warn about.
  36         Report in the debug stream if a cu-mapped link prevents addition
  37         of a conflicting variable.
  38         (ctf_link_one_input_archive_member): Adjust.
  39         (ctf_link_lazy_open): New, open a CTF archive for linking when
  40         needed.
  41         (ctf_link_close_one_input_archive): New, close it again.
  42         (ctf_link_one_input_archive): Adjust for lazy opening, member
  43         renames, and ctf_err_warn transition.  Move the
  44         empty_link_type_mapping call to...
  45         (ctf_link): ... here.  Adjut for renamings and thunk removal.
  46         Don't spuriously fail if some input contains no CTF data.
  47         (ctf_link_write): ctf_err_warn transition.
  48         * libctf.ver: Remove not-yet-stable comment.
  49
  50 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  51
  52         * ctf-impl.h (ctf_strerror): Delete.
  53         * ctf-subr.c (ctf_strerror): Likewise.
  54         * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
  55         strerror directly.
  56
  57 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  58
  59         * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
  60         (ctf_import_unref): New.
  61         * ctf-open.c (ctf_file_close) Drop the refcount all the way to
  62         zero.  Don't recurse back in if the refcount is already zero.
  63         (ctf_import): Check ctf_parent_unreffed before deciding whether
  64         to close a pre-existing parent.  Set it to zero.
  65         (ctf_import_unreffed): New, as above, setting
  66         ctf_parent_unreffed to 1.
  67         * ctf-create.c (ctf_serialize): Do not ctf_import into the new
  68         child: use direct assignment, and set unreffed on the new and
  69         old children.
  70         * ctf-link.c (ctf_create_per_cu): Import the parent using
  71         ctf_import_unreffed.
  72
  73 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  74
  75         * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
  76         (ctf_link_type_key): ... this, adjusting member prefixes to
  77         match.
  78         (ctf_hash_type_mapping_key): Rename to...
  79         (ctf_hash_type_key): ... this.
  80         (ctf_hash_eq_type_mapping_key): Rename to...
  81         (ctf_hash_eq_type_key): ... this.
  82         * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
  83         (ctf_hash_type_key): ... this, and adjust for member name
  84         changes.
  85         (ctf_hash_eq_type_mapping_key): Rename to...
  86         (ctf_hash_eq_type_key): ... this, and adjust for member name
  87         changes.
  88         * ctf-link.c (ctf_add_type_mapping): Adjust.  Note the lack of
  89         need for out-of-memory checking in this code.
  90         (ctf_type_mapping): Adjust.
  91
  92 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  93
  94         configure.ac: Check for vasprintf.
  95         configure: Regenerated.
  96         config.h.in: Likewise.
  97
  98 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  99
 100         * ctf-archive.c (ctf_arc_bufopen): Fix message.
 101
 102 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 103
 104         * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
 105         New.
 106         * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
 107         if the input has no symtab, rather than dividing by
 108         zero. Arrange to free it later via ctfi_free_ctfsect.
 109         * ctf-archive.c (ctf_new_archive_internal): Do not
 110         ctfi_free_strsect by default.
 111         (ctf_arc_close): Possibly free it here.
 112
 113 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 114
 115         * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
 116         (ctf_dump_format_type): improve slice formatting.  Always print
 117         the type size, even of slices.
 118         (ctf_dump_member): Print slices (-> bitfields) differently from
 119         non-slices.  Failure to format a type is not an OOM.
 120
 121 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 122
 123         * ctf-dump.c (ctf_dump_format_type): Emit a warning.
 124         (ctf_dump_label): Swallow errors from ctf_dump_format_type.
 125         (ctf_dump_objts): Likewise.
 126         (ctf_dump_var): Likewise.
 127         (ctf_dump_type): Do not emit a duplicate message.  Move to
 128         ctf_err_warning, and swallow all errors.
 129
 130 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 131
 132         * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
 133         (ctf_decl_buf): Once it escapes, don't try to free it later.
 134
 135 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 136
 137         * ctf-types.c (ctf_type_aname): Print arg types here...
 138         * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
 139         in the type name here.
 140
 141 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 142
 143         * ctf-impl.h (ctf_assert): New.
 144         (ctf_err_warning_t): Likewise.
 145         (ctf_file_t) <ctf_errs_warnings>: Likewise.
 146         (ctf_err_warn): New prototype.
 147         (ctf_assert_fail_internal): Likewise.
 148         * ctf-inlines.h (ctf_assert_internal): Likewise.
 149         * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
 150         * ctf-create.c (ctf_serialize): Copy it on serialization.
 151         * ctf-subr.c (ctf_err_warn): New, add an error/warning.
 152         (ctf_errwarning_next): New iterator, free and pass back
 153         errors/warnings in succession.
 154         * libctf.ver (ctf_errwarning_next): Add.
 155
 156 2020-07-22  Egeyar Bagcioglu  <egeyar.bagcioglu@oracle.com>
 157
 158         * ctf-types.c (ctf_variable_iter): Fix error return.
 159
 160 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 161
 162         * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
 163
 164 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 165
 166         ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
 167
 168 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 169
 170         * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
 171         sorting functions.
 172         (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
 173         ctf_dynhash_next_sorted.
 174         <cu.ctn_h>: New, pointer to the dynhash under iteration.
 175         <cu.ctn_s>: New, pointer to the dynset under iteration.
 176         (ctf_hash_sort_f): Sorting function passed to...
 177         (ctf_dynhash_next_sorted): ... this new function.
 178         (ctf_dynhash_next): New.
 179         (ctf_dynset_next): New.
 180         * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
 181         (ctf_dynhash_cnext): New.
 182         (ctf_dynset_cnext): New.
 183         * ctf-hash.c (ctf_dynhash_next_sorted): New.
 184         (ctf_dynhash_next): New.
 185         (ctf_dynset_next): New.
 186         * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
 187         needed.
 188         (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
 189
 190 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 191
 192         * ctf-impl.h (ctf_next): New.
 193         (ctf_get_dict): New prototype.
 194         * ctf-lookup.c (ctf_get_dict): New, split out of...
 195         (ctf_lookup_by_id): ... here.
 196         * ctf-util.c (ctf_next_create): New.
 197         (ctf_next_destroy): New.
 198         (ctf_next_copy): New.
 199         * ctf-types.c (includes): Add <assert.h>.
 200         (ctf_member_next): New.
 201         (ctf_enum_next): New.
 202         (ctf_type_iter): Document the lack of iteration over parent
 203         types.
 204         (ctf_type_next): New.
 205         (ctf_variable_next): New.
 206         * ctf-archive.c (ctf_archive_next): New.
 207         * libctf.ver: Add new public functions.
 208
 209 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 210
 211         * libctf.ver (ctf_ref): New.
 212         * ctf-open.c (ctf_ref): Implement it.
 213
 214 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 215
 216         * ctf-inlines.h (ctf_forwardable_kind): New.
 217         * ctf-create.c (ctf_add_forward): Use it.
 218
 219 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 220
 221         * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
 222         * ctf-inlines.h (ctf_get_ctt_size): ... to here.
 223
 224 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 225
 226         * ctf-hash.c (ctf_dynset_eq_string): New.
 227         (ctf_dynset_create): New.
 228         (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
 229         (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
 230         (key_to_internal): New.
 231         (internal_to_key): New.
 232         (ctf_dynset_insert): New.
 233         (ctf_dynset_remove): New.
 234         (ctf_dynset_destroy): New.
 235         (ctf_dynset_lookup): New.
 236         (ctf_dynset_exists): New.
 237         (ctf_dynset_lookup_any): New.
 238         (ctf_hash_insert_type): Coding style.
 239         (ctf_hash_define_type): Likewise.
 240         * ctf-impl.h (ctf_dynset_t): New.
 241         (ctf_dynset_eq_string): New.
 242         (ctf_dynset_create): New.
 243         (ctf_dynset_insert): New.
 244         (ctf_dynset_remove): New.
 245         (ctf_dynset_destroy): New.
 246         (ctf_dynset_lookup): New.
 247         (ctf_dynset_exists): New.
 248         (ctf_dynset_lookup_any): New.
 249         * ctf-inlines.h (ctf_dynset_cinsert): New.
 250
 251 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 252
 253         * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
 254         <value_free>: Likewise.
 255         <owner>: New.
 256         (ctf_dynhash_item_free): Indirect through the owner.
 257         (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
 258         allocate space for the key_free and value_free fields fields
 259         if necessary.
 260         (ctf_hashtab_insert): Likewise.  Fix OOM errno value.
 261         (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
 262         value_free if they will exist.  Set the slot's owner, but only
 263         if it exists.
 264         (ctf_dynhash_remove): Adjust.
 265
 266 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 267
 268         * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
 269         there is a key-freeing function and the key already exists.
 270
 271 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 272
 273         * ctf-inlines.h: New file.
 274         * ctf-impl.h: Include it.
 275         (ctf_hash_iter_find_f): New typedef.
 276         (ctf_dynhash_elements): New.
 277         (ctf_dynhash_lookup_kv): New.
 278         (ctf_dynhash_iter_find): New.
 279         * ctf-hash.c (ctf_dynhash_lookup_kv): New.
 280         (ctf_traverse_find_cb_arg_t): New.
 281         (ctf_hashtab_traverse_find): New.
 282         (ctf_dynhash_iter_find): New.
 283         (ctf_dynhash_elements): New.
 284
 285 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 286
 287         * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
 288
 289 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 290
 291         * ctf-archive.c (ctf_archive_count): New.
 292         * libctf.ver: New public function.
 293
 294 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 295
 296         * ctf-types.c (ctf_member_count): New.
 297         * libctf.ver: New public function.
 298
 299 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 300
 301         * ctf-types.c (ctf_type_kind_forwarded): New.
 302
 303 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 304
 305         * ctf-types.c (ctf_type_name_raw): New.
 306         (ctf_type_aname_raw): Reimplement accordingly.
 307
 308 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 309
 310         * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
 311
 312 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 313
 314         * ctf-impl.h (struct ctf_archive_internal)
 315         <ctfi_unmap_on_close>: New.
 316         (ctf_new_archive_internal): Adjust.
 317         * ctf-archive.c (ctf_new_archive_internal): Likewise.
 318         Initialize ctfi_unmap_on_close.  Adjust error path.
 319         (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
 320         (unmap_on_close is 0).
 321         (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
 322         * ctf-open-bfd.c (ctf_fdopen): Adjust.
 323
 324 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 325
 326         * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
 327         ints, floats or typedefs have no name.  Fix comment typo.
 328
 329 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 330
 331         * ctf-create.c (ctf_add_slice): Support slices of any kind that
 332         resolves to an integral type.
 333         * ctf-types.c (ctf_type_encoding): Resolve the type before
 334         fishing its encoding out.
 335
 336 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 337
 338         * ctf-create.c (ctf_create): Mark dirty.
 339
 340 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 341
 342         * ctf-create.c (membcmp)  Skip nameless members.
 343
 344 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 345
 346         * ctf-create.c (ctf_add_member_offset): Support names of ""
 347         as if they were the null pointer.
 348
 349 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 350
 351         * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
 352         special-casing.
 353
 354 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 355
 356         * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
 357
 358 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 359
 360         * ctf-create.c (ctf_serialize): Add cast.
 361         (ctf_add_slice): Likewise.
 362
 363 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 364
 365         * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
 366         * ctf-create.c (ctf_add_function): Check for unimplemented type
 367         and populate at the same time.  Populate one-by-one, not via
 368         memcpy.
 369         (ctf_serialize): Remove unnecessary cast.
 370         * ctf-types.c (ctf_func_type_info): Likewise.
 371         (ctf_func_type_args): Likewise.  Fix comment typo.
 372
 373 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 374
 375         * ctf-create.c (ctf_add_reftype): Support refs to type zero.
 376         (ctf_add_array): Support array contents of type zero.
 377         (ctf_add_function): Support arguments and return types of
 378         type zero.
 379         (ctf_add_typedef): Support typedefs to type zero.
 380         (ctf_add_member_offset): Support members of type zero,
 381         unless added at unspecified (naturally-aligned) offset.
 382
 383 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 384
 385         * ctf-error.c: Include <stddef.h>, for offsetof.
 386         (_ctf_errlist): Migrate to...
 387         (_ctf_errlist_t): ... this.
 388         (_ctf_erridx): New, indexes into _ctf_errlist_t.
 389         (_ctf_nerr): Remove.
 390         (ctf_errmsg): Adjust accordingly.
 391         * Makefile.am (BUILT_SOURCES): Note...
 392         (ctf-error.h): ... this new rule.
 393         * Makefile.in: Regenerate.
 394         * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
 395         * .gitignore: New, ignore ctf-error.h.
 396
 397 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 398
 399         * ctf-impl.h: Fix typos in comments.
 400
 401 2020-07-22  Nick Clifton  <nickc@redhat.com>
 402
 403         * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
 404         same file descriptor.
 405
 406 2020-07-04  Nick Clifton  <nickc@redhat.com>
 407
 408         Binutils 2.35 branch created.
 409
 410 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 411
 412         * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
 413         alphabetical order.
 414         * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
 415         * config.h.in: Regenerated.
 416         * Makefile.in: Likewise.
 417         * configure: Likewise.
 418
 419 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 420
 421         * ctf-create.c: Include <unistd.h>.
 422         * ctf-open-bfd.c: Likewise.
 423
 424 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 425
 426         PR libctf/25120
 427         * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
 428         * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
 429         means this is declared.
 430         (bswap_32): Likewise.
 431         (bswap_64): Likewise.
 432         (bswap_identity_64): Remove, unused.
 433         * configure: Regenerated.
 434         * config.h.in: Likewise.
 435
 436 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 437
 438         PR libctf/25120
 439         * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
 440         (_libctf_unlikely_): Likewise.
 441         (_libctf_unused): Likewise.
 442         (_libctf_malloc_): Likewise.
 443
 444 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 445
 446         PR libctf/25120
 447         * ctf-archive.c (search_nametbl): No longer global: declare...
 448         (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
 449         (search_modent_by_name): Take and use ARG for the nametbl.
 450
 451 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 452
 453         * ctf-impl.h (ctf_new_archive_internal): Declare.
 454         (ctf_arc_bufopen): Remove.
 455         (ctf_archive_internal) <ctfi_free_symsect>: New.
 456         * ctf-archive.c (ctf_arc_close): Use it.
 457         (ctf_arc_bufopen): Fuse into...
 458         (ctf_new_archive_internal): ... this, moved across from...
 459         * ctf-open-bfd.c: ... here.
 460         (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
 461         * libctf.ver: Add it.
 462
 463 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 464
 465         * ctf-create.c (ctf_add_forward): Intern in the right namespace.
 466         (ctf_dtd_delete): Remove correspondingly.
 467         (ctf_rollback): Likewise.
 468
 469 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 470
 471         * ctf-create.c (ctf_add_type_internal): Hand back existing types
 472         unchanged.
 473
 474 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 475
 476         * ctf-create.c (ctf_add_forward): Don't add forwards to
 477         types that already exist.
 478
 479 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 480
 481         * ctf-open.c (init_types): Only intern root-visible types.
 482         * ctf-create.c (ctf_dtd_insert): Likewise.
 483         (ctf_dtd_delete): Only remove root-visible types.
 484         (ctf_rollback): Likewise.
 485         (ctf_add_generic): Adjust.
 486         (ctf_add_struct_sized): Adjust comment.
 487         (ctf_add_union_sized): Likewise.
 488         (ctf_add_enum): Likewise.
 489         * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
 490
 491 2020-03-11  John Baldwin  <jhb@FreeBSD.org>
 492
 493         * swap.h (bswap_identity_64): Make static.
 494
 495 2020-01-18  Nick Clifton  <nickc@redhat.com>
 496
 497         Binutils 2.34 branch created.
 498
 499 2020-01-05  Joel Brobecker  <brobecker@adacore.com>
 500
 501         PR binutils/25155:
 502         * configure.ac: Add AC_CHECK_DECLS([asprintf]).
 503         * configure, config.h.in: Regenerate.
 504
 505 2020-01-01  Alan Modra  <amodra@gmail.com>
 506
 507         Update year range in copyright notice of all files.
 508
 509 2019-10-16  Simon Marchi  <simon.marchi@polymtl.ca>
 510
 511         * swap.h (bswap_16, bswap_32, bswap_64): Make static.
 512
 513 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 514
 515         * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
 516         * ctf-types.c (ctf_type_lname): Likewise.
 517
 518 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 519
 520         * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
 521         ctf_import after the first for a given file.
 522
 523 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 524
 525         * ctf-impl.h (ctf_str_append_noerr): Declare.
 526         * ctf-util.c (ctf_str_append_noerr): Define in terms of
 527         ctf_str_append.
 528         * ctf-dump.c (str_append): New, call it.
 529         (ctf_dump_format_type): Use str_append, not ctf_str_append.
 530         (ctf_dump_label): Likewise.
 531         (ctf_dump_objts): Likewise.
 532         (ctf_dump_funcs): Likewise.
 533         (ctf_dump_var): Likewise.
 534         (ctf_dump_member): Likewise.
 535         (ctf_dump_type): Likewise.
 536         (ctf_dump): Likewise.
 537
 538 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 539
 540         * ctf-impl.h (ctf_alloc): Remove.
 541         (ctf_free): Likewise.
 542         (ctf_strdup): Likewise.
 543         * ctf-subr.c (ctf_alloc): Remove.
 544         (ctf_free): Likewise.
 545         * ctf-util.c (ctf_strdup): Remove.
 546
 547         * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
 548         ctf_free; strdup, not ctf_strdup.
 549         (ctf_dtd_delete): Likewise.
 550         (ctf_dvd_delete): Likewise.
 551         (ctf_add_generic): Likewise.
 552         (ctf_add_function): Likewise.
 553         (ctf_add_enumerator): Likewise.
 554         (ctf_add_member_offset): Likewise.
 555         (ctf_add_variable): Likewise.
 556         (membadd): Likewise.
 557         (ctf_compress_write): Likewise.
 558         (ctf_write_mem): Likewise.
 559         * ctf-decl.c (ctf_decl_push): Likewise.
 560         (ctf_decl_fini): Likewise.
 561         (ctf_decl_sprintf): Likewise.  Check for OOM.
 562         * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
 563         ctf_free; strdup, not ctf_strdup.
 564         (ctf_dump_free): Likewise.
 565         (ctf_dump): Likewise.
 566         * ctf-open.c (upgrade_types_v1): Likewise.
 567         (init_types): Likewise.
 568         (ctf_file_close): Likewise.
 569         (ctf_bufopen_internal): Likewise.  Check for OOM.
 570         (ctf_parent_name_set): Likewise: report the OOM to the caller.
 571         (ctf_cuname_set): Likewise.
 572         (ctf_import): Likewise.
 573         * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
 574         free, not ctf_free; strdup, not ctf_strdup.
 575         (ctf_str_free_atom): Likewise.
 576         (ctf_str_create_atoms): Likewise.
 577         (ctf_str_add_ref_internal): Likewise.
 578         (ctf_str_remove_ref): Likewise.
 579         (ctf_str_write_strtab): Likewise.
 580
 581 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 582
 583         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
 584         work right for non-int/fps.
 585
 586 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
 587
 588         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
 589         null pointer.
 590
 591 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
 592
 593         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
 594         * ctf-open.c (ctf_file_close): Free it.
 595         * ctf-create.c (ctf_serialize): Adjust.
 596         (membcmp): When reporting a conflict due to an error, report the
 597         error.
 598         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
 599         (ctf_add_type_internal): ... this.  Hand back types we are already
 600         in the middle of adding immediately.  Hand back structs/unions with
 601         the same number of members immediately.  Do not walk the dynamic
 602         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
 603         forwards promoted to other types and the inverse case identically.
 604         Add structs to the mapping as soon as we intern them, before they
 605         gain any members.
 606
 607 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 608
 609         * ctf-impl.h (ctf_names_t): New.
 610         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
 611         (ctf_file_t) <ctf_structs>: Likewise.
 612         <ctf_unions>: Likewise.
 613         <ctf_enums>: Likewise.
 614         <ctf_names>: Likewise.
 615         <ctf_lookups>: Improve comment.
 616         <ctf_ptrtab_len>: New.
 617         <ctf_prov_strtab>: New.
 618         <ctf_str_prov_offset>: New.
 619         <ctf_dtbyname>: Remove, redundant to the names hashes.
 620         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
 621         (ctf_dtdef_t) <dtd_name>: Remove.
 622         <dtd_data>: Note that the ctt_name is now populated.
 623         (ctf_str_atom_t) <csa_offset>: This is now the strtab
 624         offset for internal strings too.
 625         <csa_external_offset>: New, the external strtab offset.
 626         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
 627         (ctf_name_table): New declaration.
 628         (ctf_lookup_by_rawname): Likewise.
 629         (ctf_lookup_by_rawhash): Likewise.
 630         (ctf_set_ctl_hashes): Likewise.
 631         (ctf_serialize): Likewise.
 632         (ctf_dtd_insert): Adjust.
 633         (ctf_simple_open_internal): Likewise.
 634         (ctf_bufopen_internal): Likewise.
 635         (ctf_list_empty_p): Likewise.
 636         (ctf_str_remove_ref): Likewise.
 637         (ctf_str_add): Returns uint32_t now.
 638         (ctf_str_add_ref): Likewise.
 639         (ctf_str_add_external): Now returns a boolean (int).
 640         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
 641         for strings in the appropriate range.
 642         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
 643         when adding the null string to the new strtab.
 644         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
 645         (ctf_str_add_ref_internal): Add make_provisional argument.  If
 646         make_provisional, populate the offset and fill in the
 647         ctf_prov_strtab accordingly.
 648         (ctf_str_add): Return the offset, not the string.
 649         (ctf_str_add_ref): Likewise.
 650         (ctf_str_add_external): Return a success integer.
 651         (ctf_str_remove_ref): New, remove a single ref.
 652         (ctf_str_count_strtab): Do not count the initial null string's
 653         length or the existence or length of any unreferenced internal
 654         atoms.
 655         (ctf_str_populate_sorttab): Skip atoms with no refs.
 656         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
 657         to the cts_len for the null string, since it is no longer done
 658         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
 659         Populate the csa_offset for both internal and external cases.
 660         Flush the ctf_prov_strtab afterwards, and reset the
 661         ctf_str_prov_offset.
 662         * ctf-create.c (ctf_grow_ptrtab): New.
 663         (ctf_create): Call it.  Initialize new fields rather than old
 664         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
 665         Set the ctl hashes and data model.
 666         (ctf_update): Rename to...
 667         (ctf_serialize): ... this.  Leave a compatibility function behind.
 668         Tell ctf_simple_open_internal that this is a writable dictionary.
 669         Pass the new fields along from the old dictionary.  Drop
 670         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
 671         Do not zero out the DTD's ctt_name.
 672         (ctf_prefixed_name): Rename to...
 673         (ctf_name_table): ... this.  No longer return a prefixed name: return
 674         the applicable name table instead.
 675         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
 676         kind we're adding.  Migrate away from dtd_name.
 677         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
 678         deleted ctt_name.
 679         (ctf_dtd_lookup_type_by_name): Remove.
 680         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
 681         No longer check ctf_dtnextid: check ctf_typemax instead.
 682         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
 683         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
 684         ctf_name_table and the right name table, and migrate away from
 685         dtd_name as in ctf_dtd_delete.
 686         (ctf_add_generic): Pass in the kind explicitly and pass it to
 687         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
 688         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
 689         Grow the ptrtab if needed.
 690         (ctf_add_encoded): Pass in the kind.
 691         (ctf_add_slice): Likewise.
 692         (ctf_add_array): Likewise.
 693         (ctf_add_function): Likewise.
 694         (ctf_add_typedef): Likewise.
 695         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
 696         ctt_name rather than dtd_name.
 697         (ctf_add_struct_sized): Pass in the kind.  Use
 698         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
 699         ctf_dtd_lookup_type_by_name.
 700         (ctf_add_union_sized): Likewise.
 701         (ctf_add_enum): Likewise.
 702         (ctf_add_enum_encoded): Likewise.
 703         (ctf_add_forward): Likewise.
 704         (ctf_add_type): Likewise.
 705         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
 706         being initialized until after the call.
 707         (ctf_write_mem): Likewise.
 708         (ctf_write): Likewise.
 709         * ctf-archive.c (arc_write_one_ctf): Likewise.
 710         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
 711         ctf_hash_lookup_type.
 712         (ctf_lookup_by_id): No longer check the readonly types if the
 713         dictionary is writable.
 714         * ctf-open.c (init_types): Assert that this dictionary is not
 715         writable.  Adjust to use the new name hashes, ctf_name_table,
 716         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
 717         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
 718         if set.  Drop out early when dictionary is writable.  Split the
 719         ctf_lookups initialization into...
 720         (ctf_set_cth_hashes): ... this new function.
 721         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
 722         (ctf_simple_open): Adjust accordingly.
 723         (ctf_bufopen): Likewise.
 724         (ctf_file_close): Destroy the appropriate name hashes.  No longer
 725         destroy ctf_dtbyname, which is gone.
 726         (ctf_getdatasect): Remove spurious "extern".
 727         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
 728         specified name table, given a kind.
 729         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
 730         (ctf_member_iter): Add support for iterating over the
 731         dynamic type list.
 732         (ctf_enum_iter): Likewise.
 733         (ctf_variable_iter): Likewise.
 734         (ctf_type_rvisit): Likewise.
 735         (ctf_member_info): Add support for types in the dynamic type list.
 736         (ctf_enum_name): Likewise.
 737         (ctf_enum_value): Likewise.
 738         (ctf_func_type_info): Likewise.
 739         (ctf_func_type_args): Likewise.
 740         * ctf-link.c (ctf_accumulate_archive_names): No longer call
 741         ctf_update.
 742         (ctf_link_write): Likewise.
 743         (ctf_link_intern_extern_string): Adjust for new
 744         ctf_str_add_external return value.
 745         (ctf_link_add_strtab): Likewise.
 746         * ctf-util.c (ctf_list_empty_p): New.
 747
 748 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
 749
 750         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
 751         type zero.
 752         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
 753         members and types.
 754         (ctf_add_variable): Likewise for variables pointing to them.
 755         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
 756         type link failure, but do warn for others.
 757         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
 758         errors to be ENOMEM.
 759         (ctf_dump_member): Likewise.
 760         (ctf_dump_type): Likewise.
 761         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
 762         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
 763         (ctf_dump_header): Likewise.
 764         (ctf_dump_label): likewise.
 765         (ctf_dump_objts): likewise.
 766         (ctf_dump_funcs): likewise.
 767         (ctf_dump_var): likewise.
 768         (ctf_dump_str): Likewise.
 769
 770 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 771
 772         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
 773         (LT_INIT): Likewise.
 774         (AM_INSTALL_LIBBFD): Likewise.
 775         (dlopen): Note why this is necessary in a comment.
 776         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
 777         opcodes/.
 778         (SHARED_LDFLAGS): Likewise.
 779         (BFD_LIBADD): Likewise, for libbfd.
 780         (BFD_DEPENDENCIES): Likewise.
 781         (VERSION_FLAGS): Initialize, using a version script if ld supports
 782         one, or libtool -export-symbols-regex otherwise.
 783         (AC_CONFIG_MACRO_DIR): Add ../BFD.
 784         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
 785         (INCDIR): New.
 786         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
 787         (noinst_LIBRARIES): Replace with...
 788         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
 789         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
 790         libctf-nobfd.la as well.
 791         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
 792         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
 793         (libctf_a_SOURCES): Rename to...
 794         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
 795         ctf-open-bfd.c.
 796         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
 797         with ctf-open-bfd.c added.
 798         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
 799         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
 800         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
 801         * Makefile.am [INSTALL_LIBCTF]: Use it.
 802         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
 803         libtool macros.
 804         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
 805         the unstable components).
 806         * Makefile.in: Regenerated.
 807         * config.h.in: Likewise.
 808         * configure: Likewise.
 809
 810 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 811
 812         * configure.ac (INSTALL_LIBCTF): New, controlled by
 813         --enable-install-libctf.
 814         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
 815         * Makefile.in: Regenerated.
 816         * configure: Regenerated.
 817
 818 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 819
 820         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
 821         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
 822
 823 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 824
 825         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
 826
 827 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 828
 829         * ctf-impl.h (includes): Include <sys/param.h> here.
 830
 831 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 832
 833         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
 834         (flip_objts): Likewise.
 835         (flip_vars): Likewise.
 836         (flip_types): Likewise.
 837
 838 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 839
 840         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
 841         freeing functions: if set, free the key and value if the slot
 842         already exists.  Always reassign the key.
 843         (ctf_dynhash_insert): Adjust call appropriately.
 844         (ctf_hash_insert_type): Likewise.
 845
 846 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
 847
 848         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
 849         type kind.  Allow forwards to unify with pre-existing structs/
 850         unions/enums.
 851
 852 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 853
 854         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
 855         <ctf_link_memb_name_changer>: Likewise.
 856         <ctf_link_memb_name_changer_arg>: Likewise.
 857         * ctf-create.c (ctf_update): Update accordingly.
 858         * ctf-open.c (ctf_file_close): Likewise.
 859         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
 860         (ctf_link_add_cu_mapping): New.
 861         (ctf_link_set_memb_name_changer): Likewise.
 862         (ctf_change_parent_name): New.
 863         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
 864         allocated by the caller's ctf_link_memb_name_changer.
 865         <ndynames>: Likewise.
 866         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
 867         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
 868         ctf_change_parent_name.  Free any resulting names.
 869
 870 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 871
 872         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
 873         (ctf_link_one_type): ... here, with parent-name setting added.
 874         (check_variable): New.
 875         (ctf_link_one_variable): Likewise.
 876         (ctf_link_one_input_archive_member): Call it.
 877         * ctf-error.c (_ctf_errlist): Updated with new errors.
 878
 879 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 880
 881         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
 882         (struct ctf_link_type_mapping_key): New.
 883         (ctf_hash_type_mapping_key): Likewise.
 884         (ctf_hash_eq_type_mapping_key): Likewise.
 885         (ctf_add_type_mapping): Likewise.
 886         (ctf_type_mapping): Likewise.
 887         (ctf_dynhash_empty): Likewise.
 888         * ctf-open.c (ctf_file_close): Update accordingly.
 889         * ctf-create.c (ctf_update): Likewise.
 890         (ctf_add_type): Populate the mapping.
 891         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
 892         (ctf_hash_eq_type_mapping_key): Check the key for equality.
 893         (ctf_dynhash_insert): Fix comment typo.
 894         (ctf_dynhash_empty): New.
 895         * ctf-link.c (ctf_add_type_mapping): New.
 896         (ctf_type_mapping): Likewise.
 897         (empty_link_type_mapping): New.
 898         (ctf_link_one_input_archive): Call it.
 899
 900 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 901
 902         * ctf-link.c: New file, linking of the string and type sections.
 903         * Makefile.am (libctf_a_SOURCES): Add it.
 904         * Makefile.in: Regenerate.
 905
 906         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
 907         ctf_link_outputs.
 908         * ctf-create.c (ctf_update): Update accordingly.
 909         * ctf-open.c (ctf_file_close): Likewise.
 910         * ctf-error.c (_ctf_errlist): Updated with new errors.
 911
 912 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 913
 914         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
 915
 916 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 917
 918         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
 919         ctf_type_iter.
 920         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
 921         (ctf_dump_format_type): Add non-root-type { } notation.
 922         Add root flag to prototype.
 923         (ctf_dump_label): Adjust accordingly.
 924         (ctf_dump_objts): Likewise.
 925         (ctf_dump_var): Likewise.
 926
 927 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 928
 929         * ctf-create.c (ctf_compress_write): Fix double-free.
 930
 931 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 932
 933         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
 934         of...
 935         (ctf_arc_write_fd): ... this new function.
 936         * ctf-create.c (ctf_write_mem): New.
 937
 938 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 939
 940         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
 941         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
 942         (ctf_str_add_ref): Name the last arg.
 943         (ctf_str_add_external) New.
 944         (ctf_str_add_strraw_explicit): Likewise.
 945         (ctf_simple_open_internal): Likewise.
 946         (ctf_bufopen_internal): Likewise.
 947
 948         * ctf-string.c (ctf_strraw_explicit): Split from...
 949         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
 950         (ctf_str_add_ref_internal): Return the atom, not the
 951         string.
 952         (ctf_str_add): Adjust accordingly.
 953         (ctf_str_add_ref): Likewise.  Move up in the file.
 954         (ctf_str_add_external): New: update the csa_offset.
 955         (ctf_str_count_strtab): Only account for strings with no csa_offset
 956         in the internal strtab length.
 957         (ctf_str_write_strtab): If the csa_offset is set, update the
 958         string's refs without writing the string out, and update the
 959         ctf_syn_ext_strtab.  Make OOM handling less ugly.
 960         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
 961         (ctf_update): Handle failure to populate the strtab.  Pass in the
 962         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
 963         Call ctf_simple_open_internal, not ctf_simple_open.
 964         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
 965         strings by hand.
 966         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
 967         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
 968         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
 969         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
 970         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
 971         (ctf_simple_open_internal): ... this new function, which calls
 972         ctf_bufopen_internal.
 973         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
 974         (ctf_bufopen_internal): ... this new function, which sets
 975         ctf_syn_ext_strtab.
 976
 977 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 978
 979         * ctf_types.c (ctf_type_iter_all): New.
 980
 981 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 982
 983         * ctf-open.c (init_symtab): Check for overflow against the right
 984         section.
 985         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
 986         (upgrade_types_v1): Note that these sections are not checked.
 987         (flip_header): Endian-swap the header fields.
 988         (flip_ctf): Endian-swap the sections.
 989         (flip_objts): Update comment.
 990         (ctf_bufopen): Check header offsets and alignment for validity.
 991
 992 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 993
 994         * ctf-open-bfd.c: Add <assert.h>.
 995         (ctf_bfdopen_ctfsect): Open string and symbol tables using
 996         techniques borrowed from bfd_elf_sym_name.
 997         (ctf_new_archive_internal): Improve comment.
 998         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
 999         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1000         no symbol section, but not vice versa.
1001
1002 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
1003
1004         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1005         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
1006         * ctf-dump.c (dump_header): New function, dump the CTF header.
1007         (ctf_dump): Call it.
1008         (ctf_dump_header_strfield): New function.
1009         (ctf_dump_header_sectfield): Likewise.
1010
1011 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
1012
1013         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1014         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1015         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1016         ctf_base: do not assume that it is always sizeof (ctf_header_t).
1017         Print out ctf_cuname: only print out ctf_parname if set.
1018         (ctf_free_base): Removed, ctf_base is no longer freed: free
1019         ctf_dynbase instead.
1020         (ctf_set_version): Fix spacing.
1021         (upgrade_header): New, in-place header upgrading.
1022         (upgrade_types): Rename to...
1023         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
1024         longer track old and new headers separately.  No longer allow for
1025         header sizes explicitly: squeeze the headers out on upgrade (they
1026         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
1027         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
1028         (upgrade_types): New, also handle ctf_parmax updating.
1029         (flip_header): Flip ctf_cuname.
1030         (flip_types): Flip BUF explicitly rather than deriving BUF from
1031         BASE.
1032         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
1033         required alignment of objtoff and funcoff.  No longer store it in
1034         the ctf_buf unless that buf is derived unmodified from the input.
1035         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1036         that duplicate fields in ctf_file: move allocation of ctf_file
1037         further up instead.  Call upgrade_header as needed.  Move
1038         version-specific ctf_parmax initialization into upgrade_types.  More
1039         concise error handling.
1040         (ctf_file_close): No longer test for null pointers before freeing.
1041         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
1042         ctf_free_base.
1043         (ctf_cuname): New.
1044         (ctf_cuname_set): New.
1045         * ctf-create.c (ctf_update): Populate ctf_cuname.
1046         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
1047         comment.
1048         (ctf_write): Likewise.
1049         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1050         Fix the compression length: fp->ctf_size never counted the CTF
1051         header.  Simplify the compress call accordingly.
1052
1053 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
1054
1055         * ctf-endian.h: Don't assume htole64 and le64toh are always
1056         present if HAVE_ENDIAN_H; also check if htole64 is defined.
1057         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1058         not bswap_identity_64.
1059
1060 2019-09-18  Alan Modra  <amodra@gmail.com>
1061
1062         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1063
1064 2019-09-09  Phil Blundell  <pb@pbcl.net>
1065
1066         binutils 2.33 branch created.
1067
1068 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
1069
1070         * ctf-types.c (ctf_type_aname_raw): New.
1071         (ctf_func_type_info): Likewise.
1072         (ctf_func_type_args): Likewise.
1073         * ctf-error.c (_ctf_errlist): Fix description.
1074         * ctf-lookup.c: Fix file description.
1075
1076 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1077
1078         * ctf-create.c (ctf_create): Fix off-by-one error.
1079
1080 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1081
1082         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1083         struct ctf_strs.
1084         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1085         (struct ctf_str_atom): New, disambiguated single string.
1086         (struct ctf_str_atom_ref): New, points to some other location that
1087         references this string's offset.
1088         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1089         Remove member ctf_dtvstrlen: we no longer track the total strlen
1090         as we add strings.
1091         (ctf_str_create_atoms): Declare new function in ctf-string.c.
1092         (ctf_str_free_atoms): Likewise.
1093         (ctf_str_add): Likewise.
1094         (ctf_str_add_ref): Likewise.
1095         (ctf_str_rollback): Likewise.
1096         (ctf_str_purge_refs): Likewise.
1097         (ctf_str_write_strtab): Likewise.
1098         (ctf_realloc): Declare new function in ctf-util.c.
1099
1100         * ctf-open.c (ctf_bufopen): Create the atoms table.
1101         (ctf_file_close): Destroy it.
1102         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
1103         special-case the position of the parname string.  Construct the
1104         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1105         rest of each buffer element is constructed, not via open-coding:
1106         realloc the CTF buffer and append the strtab to it.  No longer
1107         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
1108         strtab construction.
1109         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1110         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1111         after buffer element construction instead.
1112         (ctf_copy_lmembers): Likewise.
1113         (ctf_copy_emembers): Likewise.
1114         (ctf_create): No longer maintain the ctf_dtvstrlen.
1115         (ctf_dtd_delete): Likewise.
1116         (ctf_dvd_delete): Likewise.
1117         (ctf_add_generic): Likewise.
1118         (ctf_add_enumerator): Likewise.
1119         (ctf_add_member_offset): Likewise.
1120         (ctf_add_variable): Likewise.
1121         (membadd): Likewise.
1122         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1123         if there are active ctf_str_num_refs.
1124         (ctf_strraw): Move to ctf-string.c.
1125         (ctf_strptr): Likewise.
1126         * ctf-string.c: New file, strtab manipulation.
1127
1128         * Makefile.am (libctf_a_SOURCES): Add it.
1129         * Makefile.in: Regenerate.
1130
1131 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1132
1133         * ctf-impl.h (ctf_hash_iter_f): New.
1134         (ctf_dynhash_iter): New declaration.
1135         (ctf_dynhash_iter_remove): New declaration.
1136         * ctf-hash.c (ctf_dynhash_iter): Define.
1137         (ctf_dynhash_iter_remove): Likewise.
1138         (ctf_hashtab_traverse): New.
1139         (ctf_hashtab_traverse_remove): Likewise.
1140         (struct ctf_traverse_cb_arg): Likewise.
1141         (struct ctf_traverse_remove_cb_arg): Likewise.
1142
1143 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1144
1145         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1146
1147 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1148
1149         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1150         (ctf_dump_funcs): Likewise.
1151
1152 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1153
1154         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1155         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1156         little-endian CTF archive magic.  Do not check the CTF version:
1157         ctf_simple_open does that in endian-safe ways.  Do not dereference
1158         null pointers on open failure.
1159
1160 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1161
1162         * ctf-open.c (get_vbytes_common): Return the new slice size.
1163         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1164         Remember to copy in the CTF data when opening an uncompressed
1165         foreign-endian CTF file.  Prune useless variable manipulation.
1166
1167 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1168
1169         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1170         seen.
1171
1172 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1173
1174         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1175         output.
1176
1177 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1178
1179         * ctf-subr.c (_PAGESIZE): Remove.
1180         (ctf_data_alloc): Likewise.
1181         (ctf_data_free): Likewise.
1182         (ctf_data_protect): Likewise.
1183         * ctf-impl.h: Remove declarations.
1184         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1185         ctf_free, not ctf_data_free.
1186         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
1187         the buffer again on compression error.
1188         * ctf-open.c (ctf_set_base): No longer track the size: call
1189         ctf_free, not ctf_data_free.
1190         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
1191         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
1192
1193 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1194
1195         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1196         ctf_dynhash_insert.
1197         (ctf_dvd_insert): Likewise.
1198         (ctf_add_generic): Likewise.
1199         (ctf_add_variable): Likewise.
1200         * ctf-impl.h: Adjust declarations.
1201
1202 2019-06-14  Alan Modra  <amodra@gmail.com>
1203
1204         * configure: Regenerate.
1205
1206 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1207
1208         * ctf-decls.h: Include <libiberty.h>.
1209         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1210
1211 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1212
1213         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1214         (ctf_dump_objts): Likewise.
1215         (ctf_dump_funcs): Likewise.
1216         (ctf_dump_member): Likewise.
1217         (ctf_dump_str): Likewise.
1218
1219 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1220
1221         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1222         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1223
1224 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
1225
1226         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1227         (ctf_arc_open_by_offset): Likewise.
1228         * ctf-create.c (ctf_add_type): Likewise.
1229
1230 2019-06-04  Tom Tromey  <tromey@adacore.com>
1231
1232         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1233         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1234
1235 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1236
1237         * configure.ac: Check for O_CLOEXEC.
1238         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1239         * config.h.in: Regenerate.
1240         * configure: Likewise.
1241
1242 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1243
1244         * qsort_r.c: Rename to...
1245         * ctf-qsort_r.c: ... this.
1246         (_quicksort): Define to ctf_qsort_r.
1247         * ctf-decls.h (qsort_r): Remove.
1248         (ctf_qsort_r): Add.
1249         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1250         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1251         * Makefile.am (libctf_a_LIBADD): Remove.
1252         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1253         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1254         * ctf-create.c (ctf_update): Likewise.
1255         * configure.ac: Check for BSD versus GNU qsort_r signature.
1256         * Makefile.in: Regenerate.
1257         * config.h.in: Likewise.
1258         * configure: Likewise.
1259
1260 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
1261
1262         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1263
1264 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
1265
1266         * Makefile.am (ZLIB): New.
1267         (ZLIBINC): Likewise.
1268         (AM_CFLAGS): Use them.
1269         (libctf_a_LIBADD): New, for LIBOBJS.
1270         * configure.ac: Check for zlib, endian.h, and qsort_r.
1271         * ctf-endian.h: New, providing htole64 and le64toh.
1272         * swap.h: Code style fixes.
1273         (bswap_identity_64): New.
1274         * qsort_r.c: New, from gnulib (with one added #include).
1275         * ctf-decls.h: New, providing a conditional qsort_r declaration,
1276         and unconditional definitions of MIN and MAX.
1277         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
1278         (ctf_set_errno): Now returns unsigned long.
1279         * ctf-util.c (ctf_set_errno): Adjust here too.
1280         * ctf-archive.c: Use ctf-endian.h.
1281         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
1282         cts_flags and cts_offset.
1283         (ctf_arc_write): Drop debugging dependent on the size of off_t.
1284         * ctf-create.c: Provide a definition of roundup if not defined.
1285         (ctf_create): Drop cts_type, cts_flags and cts_offset.
1286         (ctf_add_reftype): Do not check if type IDs are below zero.
1287         (ctf_add_slice): Likewise.
1288         (ctf_add_typedef): Likewise.
1289         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1290         when known error-free.  Drop CTF_ERR usage for functions returning
1291         int.
1292         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1293         int.
1294         (ctf_add_variable): Likewise.
1295         (enumcmp): Likewise.
1296         (enumadd): Likewise.
1297         (membcmp): Likewise.
1298         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
1299         when known error-free.
1300         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1301         returning int: use CTF_ERR for functions returning ctf_type_id.
1302         (ctf_dump_label): Likewise.
1303         (ctf_dump_objts): Likewise.
1304         * ctf-labels.c (ctf_label_topmost): Likewise.
1305         (ctf_label_iter): Likewise.
1306         (ctf_label_info): Likewise.
1307         * ctf-lookup.c (ctf_func_args): Likewise.
1308         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1309         (ctf_bufopen): Likewise.  Use zlib types as needed.
1310         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1311         returning int.
1312         (ctf_enum_iter): Likewise.
1313         (ctf_type_size): Likewise.
1314         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
1315         (ctf_type_kind_unsliced): Likewise.
1316         (ctf_type_kind): Likewise.
1317         (ctf_type_encoding): Likewise.
1318         (ctf_member_info): Likewise.
1319         (ctf_array_info): Likewise.
1320         (ctf_enum_value): Likewise.
1321         (ctf_type_rvisit): Likewise.
1322         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1323         cts_offset.
1324         (ctf_simple_open): Likewise.
1325         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
1326         * Makefile.in: Regenerate.
1327         * aclocal.m4: Likewise.
1328         * config.h: Likewise.
1329         * configure: Likewise.
1330
1331 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1332
1333         * configure.in: Check for bfd_section_from_elf_index.
1334         * configure: Regenerate.
1335         * config.h.in [HAVE_BFD_ELF]: Likewise.
1336         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1337         abfd is potentially unused now.
1338
1339 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1340
1341         * Makefile.am: New.
1342         * Makefile.in: Regenerated.
1343         * config.h.in: Likewise.
1344         * aclocal.m4: Likewise.
1345         * configure: Likewise.
1346
1347 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1348
1349         * ctf-dump.c: New.
1350
1351 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1352
1353         * ctf-labels.c: New.
1354
1355 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1356
1357         * ctf-impl.h (_libctf_version): New declaration.
1358         * ctf-subr.c (_libctf_version): Define it.
1359         (ctf_version): New.
1360
1361 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1362
1363         * ctf-create.c (enumcmp): New.
1364         (enumadd): Likewise.
1365         (membcmp): Likewise.
1366         (membadd): Likewise.
1367         (ctf_add_type): Likewise.
1368
1369 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1370
1371         * ctf-lookup.c (isqualifier): New.
1372         (ctf_lookup_by_name): Likewise.
1373         (struct ctf_lookup_var_key): Likewise.
1374         (ctf_lookup_var): Likewise.
1375         (ctf_lookup_variable): Likewise.
1376         (ctf_lookup_symbol_name): Likewise.
1377         (ctf_lookup_by_symbol): Likewise.
1378         (ctf_func_info): Likewise.
1379         (ctf_func_args): Likewise.
1380
1381 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1382
1383         * ctf-decl.c: New file.
1384         * ctf-types.c: Likewise.
1385         * ctf-impl.h: New declarations.
1386
1387 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1388
1389         * ctf-open-bfd.c: New file.
1390         * ctf-open.c (ctf_close): New.
1391         * ctf-impl.h: Include bfd.h.
1392         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1393         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1394         ctfi_bfd_close.
1395         (ctf_bfdopen_ctfsect): New declaration.
1396         (_CTF_SECTION): likewise.
1397
1398 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1399
1400         * ctf-archive.c: New.
1401         * ctf-impl.h (ctf_archive_internal): New type.
1402         (ctf_arc_open_internal): New declaration.
1403         (ctf_arc_bufopen): Likewise.
1404         (ctf_arc_close_internal): Likewise.
1405
1406 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1407
1408         * ctf-open.c: New file.
1409         * swap.h: Likewise.
1410
1411 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1412
1413         * ctf-create.c: New file.
1414         * ctf-lookup.c: New file.
1415
1416 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1417
1418         * ctf-impl.h: New definitions and declarations for type creation
1419         and lookup.
1420
1421 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1422
1423         * ctf-hash.c: New file.
1424         * ctf-impl.h: New declarations.
1425
1426 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1427
1428         * ctf-error.c: New file.
1429
1430 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1431
1432         * ctf-util.c: New file.
1433         * elf.h: Likewise.
1434         * ctf-impl.h: Include it, and add declarations.
1435
1436 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1437
1438         * ctf-impl.h: New file.
1439         * ctf-subr.c: New file.
1440
1441 \f
1442 Local Variables:
1443 mode: change-log
1444 left-margin: 8
1445 fill-column: 76
1446 version-control: never
1447 End: