]> git.ipfire.org Git - thirdparty/mdadm.git/blobdiff - Assemble.c
Fix memory leak
[thirdparty/mdadm.git] / Assemble.c
index ea54fc099d8f9cc060efb9dd1bdb3a298f97deba..4ded58ceef176206156986bc357ab45f3f1cd7ff 100644 (file)
@@ -138,7 +138,7 @@ int Assemble(struct supertype *st, char *mddev,
             char *backup_file, int invalid_backup,
             int readonly, int runstop,
             char *update, char *homehost, int require_homehost,
-            int verbose, int force)
+            int verbose, int force, int freeze_reshape)
 {
        /*
         * The task of Assemble is to find a collection of
@@ -330,11 +330,13 @@ int Assemble(struct supertype *st, char *mddev,
                                        fprintf(stderr, Name ": %s is a container, but we are looking for components\n",
                                                devname);
                                tmpdev->used = 2;
+#if !defined(MDASSEMBLE) || defined(MDASSEMBLE) && defined(MDASSEMBLE_AUTO)
                        } if (!tst && (tst = super_by_fd(dfd, NULL)) == NULL) {
                                if (report_missmatch)
                                        fprintf(stderr, Name ": not a recognisable container: %s\n",
                                                devname);
                                tmpdev->used = 2;
+#endif
                        } else if (!tst->ss->load_container
                                   || tst->ss->load_container(tst, dfd, NULL)) {
                                if (report_missmatch)
@@ -416,7 +418,6 @@ int Assemble(struct supertype *st, char *mddev,
                                        int uuid[4];
 
                                        content = &info;
-                                       memset(content, 0, sizeof(*content));
                                        tst->ss->getinfo_super(tst, content, NULL);
 
                                        if (!parse_uuid(ident->container, uuid) ||
@@ -438,13 +439,6 @@ int Assemble(struct supertype *st, char *mddev,
                             content;
                             content = content->next) {
 
-                               /* do not assemble arrays that might have bad blocks */
-                               if (content->array.state & (1<<MD_SB_BBM_ERRORS)) {
-                                       fprintf(stderr, Name ": BBM log found in metadata. "
-                                                               "Cannot activate array(s).\n");
-                                       tmpdev->used = 2;
-                                       goto loop;
-                               }
                                if (!ident_matches(ident, content, tst,
                                                   homehost, update,
                                                   report_missmatch ? devname : NULL))
@@ -454,6 +448,11 @@ int Assemble(struct supertype *st, char *mddev,
                                                fprintf(stderr, Name ": member %s in %s is already assembled\n",
                                                        content->text_version,
                                                        devname);
+                               } else if (content->array.state & (1<<MD_SB_BLOCK_VOLUME)) {
+                                       /* do not assemble arrays with unsupported configurations */
+                                       fprintf(stderr, Name ": Cannot activate member %s in %s.\n",
+                                               content->text_version,
+                                               devname);
                                } else
                                        break;
                        }
@@ -482,7 +481,6 @@ int Assemble(struct supertype *st, char *mddev,
                } else {
 
                        content = &info;
-                       memset(content, 0, sizeof(*content));
                        tst->ss->getinfo_super(tst, content, NULL);
 
                        if (!ident_matches(ident, content, tst,
@@ -595,10 +593,15 @@ int Assemble(struct supertype *st, char *mddev,
                                tmpdev->devname, strerror(errno));
                        tmpdev->used = 2;
                } else {
-                       struct dev_policy *pol = NULL;
-                       pol = devnum_policy(stb.st_rdev);
-                       if (domain_test(domains, pol, NULL))
-                               /* take this spare if domains match */
+                       struct dev_policy *pol = devnum_policy(stb.st_rdev);
+                       int dt = domain_test(domains, pol, NULL);
+                       if (inargv && dt != 0)
+                               /* take this spare as domains match
+                                * if there are any */
+                               tmpdev->used = 1;
+                       else if (!inargv && dt == 1)
+                               /* device wasn't explicitly listed, so need
+                                * explicit domain match - which we have */
                                tmpdev->used = 1;
                        else
                                /* if domains don't match mark as unused */
@@ -689,8 +692,12 @@ int Assemble(struct supertype *st, char *mddev,
 #ifndef MDASSEMBLE
        if (content != &info) {
                /* This is a member of a container.  Try starting the array. */
-               return assemble_container_content(st, mdfd, content, runstop,
-                                          chosen_name, verbose);
+               int err;
+               err = assemble_container_content(st, mdfd, content, runstop,
+                                                chosen_name, verbose,
+                                                backup_file, freeze_reshape);
+               close(mdfd);
+               return err;
        }
 #endif
        /* Ok, no bad inconsistancy, we can try updating etc */
@@ -1051,6 +1058,8 @@ int Assemble(struct supertype *st, char *mddev,
                        continue;
                if (!devices[j].uptodate)
                        continue;
+               if (devices[j].i.events < devices[most_recent].i.events)
+                       continue;
                chosen_drive = j;
                if ((fd=dev_open(devices[j].devname, O_RDONLY|O_EXCL))< 0) {
                        fprintf(stderr, Name ": Cannot open %s: %s\n",
@@ -1147,6 +1156,9 @@ int Assemble(struct supertype *st, char *mddev,
                        free(devices);
                        return 1;
                }
+               if (verbose >= 0)
+                       fprintf(stderr, Name ": Marking array %s as 'clean'\n",
+                               mddev);
                close(fd);
        }
 
@@ -1176,8 +1188,11 @@ int Assemble(struct supertype *st, char *mddev,
                                fdlist[i] = -1;
                }
                if (!err) {
-                       err = Grow_restart(st, content, fdlist, bestcnt,
-                                          backup_file, verbose > 0);
+                       if (st->ss->external && st->ss->recover_backup)
+                               err = st->ss->recover_backup(st, content);
+                       else
+                               err = Grow_restart(st, content, fdlist, bestcnt,
+                                                  backup_file, verbose > 0);
                        if (err && invalid_backup) {
                                if (verbose > 0)
                                        fprintf(stderr, Name ": continuing"
@@ -1304,6 +1319,7 @@ int Assemble(struct supertype *st, char *mddev,
                                                content->array.raid_disks);
                                fprintf(stderr, "\n");
                        }
+                       st->ss->free_super(st);
                        sysfs_uevent(content, "change");
                        wait_for(chosen_name, mdfd);
                        close(mdfd);
@@ -1325,9 +1341,14 @@ int Assemble(struct supertype *st, char *mddev,
                        int rv;
 #ifndef MDASSEMBLE
                        if (content->reshape_active &&
-                           content->delta_disks <= 0)
-                               rv = Grow_continue(mdfd, st, content, backup_file);
-                       else
+                           content->delta_disks <= 0) {
+                               rv = sysfs_set_str(content, NULL,
+                                                  "array_state", "readonly");
+                               if (rv == 0)
+                                       rv = Grow_continue(mdfd, st, content,
+                                                          backup_file,
+                                                          freeze_reshape);
+                       } else
 #endif
                                rv = ioctl(mdfd, RUN_ARRAY, NULL);
                        if (rv == 0) {
@@ -1354,6 +1375,7 @@ int Assemble(struct supertype *st, char *mddev,
                                                        sysfs_set_num(sra, NULL,
                                                                      "stripe_cache_size",
                                                                      (4 * content->array.chunk_size / 4096) + 1);
+                                               sysfs_free(sra);
                                        }
                                }
                                if (okcnt < (unsigned)content->array.raid_disks) {
@@ -1365,7 +1387,7 @@ int Assemble(struct supertype *st, char *mddev,
                                         * might allow them to be included, or
                                         * they will become spares.
                                         */
-                                       for (i = 0; i <= bestcnt; i++) {
+                                       for (i = 0; i < bestcnt; i++) {
                                                int j = best[i];
                                                if (j >= 0 && !devices[j].uptodate) {
                                                        if (!disk_action_allows(&devices[j].i, st->ss->name, act_re_add))
@@ -1492,42 +1514,77 @@ int Assemble(struct supertype *st, char *mddev,
 #ifndef MDASSEMBLE
 int assemble_container_content(struct supertype *st, int mdfd,
                               struct mdinfo *content, int runstop,
-                              char *chosen_name, int verbose)
+                              char *chosen_name, int verbose,
+                              char *backup_file, int freeze_reshape)
 {
        struct mdinfo *dev, *sra;
        int working = 0, preexist = 0;
+       int expansion = 0;
        struct map_ent *map = NULL;
+       int old_raid_disks;
 
        sysfs_init(content, mdfd, 0);
 
        sra = sysfs_read(mdfd, 0, GET_VERSION);
        if (sra == NULL || strcmp(sra->text_version, content->text_version) != 0)
-               if (sysfs_set_array(content, md_get_version(mdfd)) != 0) {
-                       close(mdfd);
+               if (sysfs_set_array(content, md_get_version(mdfd)) != 0)
                        return 1;
-               }
+
+       if (st->ss->external && content->recovery_blocked)
+               block_subarray(content);
+
        if (sra)
                sysfs_free(sra);
-
+       old_raid_disks = content->array.raid_disks - content->delta_disks;
        for (dev = content->devs; dev; dev = dev->next)
-               if (sysfs_add_disk(content, dev, 1) == 0)
-                       working++;
-               else if (errno == EEXIST)
+               if (sysfs_add_disk(content, dev, 1) == 0) {
+                       if (dev->disk.raid_disk >= old_raid_disks &&
+                           content->reshape_active)
+                               expansion++;
+                       else
+                               working++;
+               } else if (errno == EEXIST)
                        preexist++;
-       if (working == 0) {
-               close(mdfd);
+       if (working == 0)
                return 1;/* Nothing new, don't try to start */
-       }
-       
+
        map_update(&map, fd2devnum(mdfd),
                   content->text_version,
                   content->uuid, chosen_name);
 
        if (runstop > 0 ||
-                (working + preexist) >= content->array.working_disks) {
+                (working + preexist + expansion) >=
+                       content->array.working_disks) {
                int err;
+               int start_reshape;
+
+               /* There are two types of reshape: container wide or sub-array specific
+                * Check if metadata requests blocking container wide reshapes
+                */
+               start_reshape = (content->reshape_active &&
+                                !((content->reshape_active == CONTAINER_RESHAPE) &&
+                                  (content->array.state & (1<<MD_SB_BLOCK_CONTAINER_RESHAPE))));
+               if (start_reshape) {
+                       int spare = content->array.raid_disks + expansion;
+                       if (restore_backup(st, content,
+                                          working,
+                                          spare, backup_file, verbose) == 1)
+                               return 1;
+
+                       err = sysfs_set_str(content, NULL,
+                                           "array_state", "readonly");
+                       if (err)
+                               return 1;
 
-               switch(content->array.level) {
+                       if (st->ss->external) {
+                               if (!mdmon_running(st->container_dev))
+                                       start_mdmon(st->container_dev);
+                               ping_monitor_by_id(st->container_dev);
+                       }
+
+                       err = Grow_continue(mdfd, st, content, backup_file,
+                                           freeze_reshape);
+               } else switch(content->array.level) {
                case LEVEL_LINEAR:
                case LEVEL_MULTIPATH:
                case 0:
@@ -1541,7 +1598,7 @@ int assemble_container_content(struct supertype *st, int mdfd,
                        if (!err) {
                                if (!mdmon_running(st->container_dev))
                                        start_mdmon(st->container_dev);
-                               ping_monitor(devnum2devname(st->container_dev));
+                               ping_monitor_by_id(st->container_dev);
                        }
                        break;
                }
@@ -1558,12 +1615,14 @@ int assemble_container_content(struct supertype *st, int mdfd,
                                        chosen_name, working + preexist);
                        if (preexist)
                                fprintf(stderr, " (%d new)", working);
+                       if (expansion)
+                               fprintf(stderr, " ( + %d for expansion)",
+                                       expansion);
                        fprintf(stderr, "\n");
                }
                if (!err)
                        wait_for(chosen_name, mdfd);
-               close(mdfd);
-               return 0;
+               return err;
                /* FIXME should have an O_EXCL and wait for read-auto */
        } else {
                if (verbose >= 0)
@@ -1571,7 +1630,6 @@ int assemble_container_content(struct supertype *st, int mdfd,
                                ": %s assembled with %d devices but "
                                "not started\n",
                                chosen_name, working);
-               close(mdfd);
                return 1;
        }
 }