]> git.ipfire.org Git - thirdparty/mdadm.git/blobdiff - Create.c
Change name of 'c' variable in Detail
[thirdparty/mdadm.git] / Create.c
index 79564c544ca04d3fd6fac9b24ac0f279f51559bb..be572366699a3f1bd755d8beceedc465a7d7281b 100644 (file)
--- a/Create.c
+++ b/Create.c
@@ -42,22 +42,19 @@ static int default_layout(struct supertype *st, int level, int verbose)
                case 10:
                        layout = 0x102; /* near=2, far=1 */
                        if (verbose > 0)
-                               fprintf(stderr,
-                                       Name ": layout defaults to n2\n");
+                               pr_err("layout defaults to n2\n");
                        break;
                case 5:
                case 6:
                        layout = map_name(r5layout, "default");
                        if (verbose > 0)
-                               fprintf(stderr,
-                                       Name ": layout defaults to %s\n", map_num(r5layout, layout));
+                               pr_err("layout defaults to %s\n", map_num(r5layout, layout));
                        break;
                case LEVEL_FAULTY:
                        layout = map_name(faultylayout, "default");
 
                        if (verbose > 0)
-                               fprintf(stderr,
-                                       Name ": layout defaults to %s\n", map_num(faultylayout, layout));
+                               pr_err("layout defaults to %s\n", map_num(faultylayout, layout));
                        break;
                }
 
@@ -68,11 +65,11 @@ static int default_layout(struct supertype *st, int level, int verbose)
 int Create(struct supertype *st, char *mddev,
           int chunk, int level, int layout, unsigned long long size,
           int raiddisks, int sparedisks,
-          char *name, char *homehost, int *uuid,
+          char *name, int *uuid,
           int subdevs, struct mddev_dev *devlist,
-          int runstop, int verbose, int force, int assume_clean,
+          int assume_clean,
           char *bitmap_file, int bitmap_chunk, int write_behind,
-          int delay, int autof)
+          struct context *c)
 {
        /*
         * Create a new raid array.
@@ -126,28 +123,23 @@ int Create(struct supertype *st, char *mddev,
        if (level == UnSet && st && st->ss->default_geometry)
                st->ss->default_geometry(st, &level, NULL, NULL);
        if (level == UnSet) {
-               fprintf(stderr,
-                       Name ": a RAID level is needed to create an array.\n");
+               pr_err("a RAID level is needed to create an array.\n");
                return 1;
        }
        if (raiddisks < 4 && level == 6) {
-               fprintf(stderr,
-                       Name ": at least 4 raid-devices needed for level 6\n");
+               pr_err("at least 4 raid-devices needed for level 6\n");
                return 1;
        }
        if (raiddisks > 256 && level == 6) {
-               fprintf(stderr,
-                       Name ": no more than 256 raid-devices supported for level 6\n");
+               pr_err("no more than 256 raid-devices supported for level 6\n");
                return 1;
        }
        if (raiddisks < 2 && level >= 4) {
-               fprintf(stderr,
-                       Name ": at least 2 raid-devices needed for level 4 or 5\n");
+               pr_err("at least 2 raid-devices needed for level 4 or 5\n");
                return 1;
        }
        if (level <= 0 && sparedisks) {
-               fprintf(stderr,
-                       Name ": This level does not support spare devices\n");
+               pr_err("This level does not support spare devices\n");
                return 1;
        }
 
@@ -189,21 +181,20 @@ int Create(struct supertype *st, char *mddev,
                        close(fd);
        }
        if (st && st->ss->external && sparedisks) {
-               fprintf(stderr,
-                       Name ": This metadata type does not support "
-                       "spare disks at create time\n");
+               pr_err("This metadata type does not support "
+                      "spare disks at create time\n");
                return 1;
        }
        if (subdevs > raiddisks+sparedisks) {
-               fprintf(stderr, Name ": You have listed more devices (%d) than are in the array(%d)!\n", subdevs, raiddisks+sparedisks);
+               pr_err("You have listed more devices (%d) than are in the array(%d)!\n", subdevs, raiddisks+sparedisks);
                return 1;
        }
        if (!have_container && subdevs < raiddisks+sparedisks) {
-               fprintf(stderr, Name ": You haven't given enough devices (real or missing) to create this array\n");
+               pr_err("You haven't given enough devices (real or missing) to create this array\n");
                return 1;
        }
        if (bitmap_file && level <= 0) {
-               fprintf(stderr, Name ": bitmaps not meaningful with level %s\n",
+               pr_err("bitmaps not meaningful with level %s\n",
                        map_num(pers, level)?:"given");
                return 1;
        }
@@ -213,13 +204,13 @@ int Create(struct supertype *st, char *mddev,
 
        if (layout == UnSet) {
                do_default_layout = 1;
-               layout = default_layout(st, level, verbose);
+               layout = default_layout(st, level, c->verbose);
        }
 
        if (level == 10)
                /* check layout fits in array*/
                if ((layout&255) * ((layout>>8)&255) > raiddisks) {
-                       fprintf(stderr, Name ": that layout requires at least %d devices\n",
+                       pr_err("that layout requires at least %d devices\n",
                                (layout&255) * ((layout>>8)&255));
                        return 1;
                }
@@ -240,8 +231,8 @@ int Create(struct supertype *st, char *mddev,
                /* a chunksize of zero 0s perfectly valid (and preferred) since 2.6.16 */
                if (get_linux_version() < 2006016 && chunk == 0) {
                        chunk = 64;
-                       if (verbose > 0)
-                               fprintf(stderr, Name ": chunk size defaults to 64K\n");
+                       if (c->verbose > 0)
+                               pr_err("chunk size defaults to 64K\n");
                }
                break;
        case 1:
@@ -250,12 +241,12 @@ int Create(struct supertype *st, char *mddev,
        case LEVEL_CONTAINER:
                if (chunk) {
                        chunk = 0;
-                       if (verbose > 0)
-                               fprintf(stderr, Name ": chunk size ignored for this level\n");
+                       if (c->verbose > 0)
+                               pr_err("chunk size ignored for this level\n");
                }
                break;
        default:
-               fprintf(stderr, Name ": unknown level %d\n", level);
+               pr_err("unknown level %d\n", level);
                return 1;
        }
        
@@ -263,15 +254,15 @@ int Create(struct supertype *st, char *mddev,
                size &= ~(unsigned long long)(chunk - 1);
        newsize = size * 2;
        if (st && ! st->ss->validate_geometry(st, level, layout, raiddisks,
-                                             &chunk, size*2, NULL, &newsize, verbose>=0))
+                                             &chunk, size*2, NULL, &newsize, c->verbose>=0))
                return 1;
 
        if (chunk && chunk != UnSet) {
                newsize &= ~(unsigned long long)(chunk*2 - 1);
                if (do_default_chunk) {
                        /* default chunk was just set */
-                       if (verbose > 0)
-                               fprintf(stderr, Name ": chunk size "
+                       if (c->verbose > 0)
+                               pr_err("chunk size "
                                        "defaults to %dK\n", chunk);
                        size &= ~(unsigned long long)(chunk - 1);
                        do_default_chunk = 0;
@@ -280,8 +271,15 @@ int Create(struct supertype *st, char *mddev,
 
        if (size == 0) {
                size = newsize / 2;
-               if (size && verbose > 0)
-                       fprintf(stderr, Name ": setting size to %lluK\n",
+               if (level == 1)
+                       /* If this is ever reshaped to RAID5, we will
+                        * need a chunksize.  So round it off a bit
+                        * now just to be safe
+                        */
+                       size &= ~(64ULL-1);
+
+               if (size && c->verbose > 0)
+                       pr_err("setting size to %lluK\n",
                                (unsigned long long)size);
        }
 
@@ -304,14 +302,14 @@ int Create(struct supertype *st, char *mddev,
                }
                dfd = open(dname, O_RDONLY);
                if (dfd < 0) {
-                       fprintf(stderr, Name ": cannot open %s: %s\n",
+                       pr_err("cannot open %s: %s\n",
                                dname, strerror(errno));
                        exit(2);
                }
                if (fstat(dfd, &stb) != 0 ||
                    (stb.st_mode & S_IFMT) != S_IFBLK) {
                        close(dfd);
-                       fprintf(stderr, Name ": %s is not a block device\n",
+                       pr_err("%s is not a block device\n",
                                dname);
                        exit(2);
                }
@@ -335,11 +333,11 @@ int Create(struct supertype *st, char *mddev,
                                if (!st)
                                        continue;
                                if (do_default_layout)
-                                       layout = default_layout(st, level, verbose);
+                                       layout = default_layout(st, level, c->verbose);
                                switch (st->ss->validate_geometry(
                                                st, level, layout, raiddisks,
                                                &chunk, size*2, dname, &freesize,
-                                               verbose > 0)) {
+                                               c->verbose > 0)) {
                                case -1: /* Not valid, message printed, and not
                                          * worth checking any further */
                                        exit(2);
@@ -357,11 +355,11 @@ int Create(struct supertype *st, char *mddev,
                        if (!st) {
                                int dfd = open(dname, O_RDONLY|O_EXCL);
                                if (dfd < 0) {
-                                       fprintf(stderr, Name ": cannot open %s: %s\n",
+                                       pr_err("cannot open %s: %s\n",
                                                dname, strerror(errno));
                                        exit(2);
                                }
-                               fprintf(stderr, Name ": device %s not suitable "
+                               pr_err("device %s not suitable "
                                        "for any style of array\n",
                                        dname);
                                exit(2);
@@ -371,17 +369,16 @@ int Create(struct supertype *st, char *mddev,
                                did_default = 1;
                } else {
                        if (do_default_layout)
-                               layout = default_layout(st, level, verbose);
+                               layout = default_layout(st, level, 0);
                        if (!st->ss->validate_geometry(st, level, layout,
                                                       raiddisks,
                                                       &chunk, size*2, dname,
                                                       &freesize,
-                                                      verbose >= 0)) {
+                                                      c->verbose >= 0)) {
 
-                               fprintf(stderr,
-                                       Name ": %s is not suitable for "
-                                       "this array.\n",
-                                       dname);
+                               pr_err("%s is not suitable for "
+                                      "this array.\n",
+                                      dname);
                                fail = 1;
                                continue;
                        }
@@ -393,8 +390,8 @@ int Create(struct supertype *st, char *mddev,
                        freesize = freesize & ~(chunk-1);
                        if (do_default_chunk) {
                                /* default chunk was just set */
-                               if (verbose > 0)
-                                       fprintf(stderr, Name ": chunk size "
+                               if (c->verbose > 0)
+                                       pr_err("chunk size "
                                                "defaults to %dK\n", chunk);
                                size &= ~(unsigned long long)(chunk - 1);
                                do_default_chunk = 0;
@@ -402,7 +399,7 @@ int Create(struct supertype *st, char *mddev,
                }
 
                if (size && freesize < size) {
-                       fprintf(stderr, Name ": %s is smaller than given size."
+                       pr_err("%s is smaller than given size."
                                " %lluK < %lluK + metadata\n",
                                dname, freesize, size);
                        fail = 1;
@@ -416,10 +413,10 @@ int Create(struct supertype *st, char *mddev,
                        mindisc = dname;
                        minsize = freesize;
                }
-               if (runstop != 1 || verbose >= 0) {
+               if (c->runstop != 1 || c->verbose >= 0) {
                        int fd = open(dname, O_RDONLY);
                        if (fd <0 ) {
-                               fprintf(stderr, Name ": Cannot open %s: %s\n",
+                               pr_err("Cannot open %s: %s\n",
                                        dname, strerror(errno));
                                fail=1;
                                continue;
@@ -444,7 +441,7 @@ int Create(struct supertype *st, char *mddev,
                            level == 1 &&
                            (warn & 1024) == 0) {
                                warn |= 1024;
-                               fprintf(stderr, Name ": Note: this array has metadata at the start and\n"
+                               pr_err("Note: this array has metadata at the start and\n"
                                        "    may not be suitable as a boot device.  If you plan to\n"
                                        "    store '/boot' on this device please ensure that\n"
                                        "    your boot-loader understands md/v1.x metadata, or use\n"
@@ -454,7 +451,7 @@ int Create(struct supertype *st, char *mddev,
                }
        }
        if (raiddisks + sparedisks > st->max_devs) {
-               fprintf(stderr, Name ": Too many devices:"
+               pr_err("Too many devices:"
                        " %s metadata only supports %d\n",
                        st->ss->name, st->max_devs);
                return 1;
@@ -462,12 +459,12 @@ int Create(struct supertype *st, char *mddev,
        if (have_container)
                info.array.working_disks = raiddisks;
        if (fail) {
-               fprintf(stderr, Name ": create aborted\n");
+               pr_err("create aborted\n");
                return 1;
        }
        if (size == 0) {
                if (mindisc == NULL && !have_container) {
-                       fprintf(stderr, Name ": no size and no drives given - aborting create.\n");
+                       pr_err("no size and no drives given - aborting create.\n");
                        return 1;
                }
                if (level > 0 || level == LEVEL_MULTIPATH
@@ -478,38 +475,44 @@ int Create(struct supertype *st, char *mddev,
                                                       raiddisks,
                                                       &chunk, minsize*2,
                                                       NULL, NULL, 0)) {
-                               fprintf(stderr, Name ": devices too large for RAID level %d\n", level);
+                               pr_err("devices too large for RAID level %d\n", level);
                                return 1;
                        }
                        size = minsize;
-                       if (verbose > 0)
-                               fprintf(stderr, Name ": size set to %lluK\n", size);
+                       if (level == 1)
+                               /* If this is ever reshaped to RAID5, we will
+                                * need a chunksize.  So round it off a bit
+                                * now just to be safe
+                                */
+                               size &= ~(64ULL-1);
+                       if (c->verbose > 0)
+                               pr_err("size set to %lluK\n", size);
                }
        }
        if (!have_container && level > 0 && ((maxsize-size)*100 > maxsize)) {
-               if (runstop != 1 || verbose >= 0)
-                       fprintf(stderr, Name ": largest drive (%s) exceeds size (%lluK) by more than 1%%\n",
+               if (c->runstop != 1 || c->verbose >= 0)
+                       pr_err("largest drive (%s) exceeds size (%lluK) by more than 1%%\n",
                                maxdisc, size);
                warn = 1;
        }
 
        if (st->ss->detail_platform && st->ss->detail_platform(0, 1) != 0) {
-               if (runstop != 1 || verbose >= 0)
-                       fprintf(stderr, Name ": %s unable to enumerate platform support\n"
+               if (c->runstop != 1 || c->verbose >= 0)
+                       pr_err("%s unable to enumerate platform support\n"
                                "    array may not be compatible with hardware/firmware\n",
                                st->ss->name);
                warn = 1;
        }
 
        if (warn) {
-               if (runstop!= 1) {
+               if (c->runstop!= 1) {
                        if (!ask("Continue creating array? ")) {
-                               fprintf(stderr, Name ": create aborted.\n");
+                               pr_err("create aborted.\n");
                                return 1;
                        }
                } else {
-                       if (verbose > 0)
-                               fprintf(stderr, Name ": creation continuing despite oddities due to --run\n");
+                       if (c->verbose > 0)
+                               pr_err("creation continuing despite oddities due to --run\n");
                }
        }
 
@@ -518,7 +521,7 @@ int Create(struct supertype *st, char *mddev,
         * FIX: Can we do this for raid6 as well?
         */
        if (st->ss->external == 0 &&
-           assume_clean==0 && force == 0 && first_missing >= raiddisks) {
+           assume_clean==0 && c->force == 0 && first_missing >= raiddisks) {
                switch ( level ) {
                case 4:
                case 5:
@@ -534,7 +537,7 @@ int Create(struct supertype *st, char *mddev,
        /* For raid6, if creating with 1 missing drive, make a good drive
         * into a spare, else the create will fail
         */
-       if (assume_clean == 0 && force == 0 && first_missing < raiddisks &&
+       if (assume_clean == 0 && c->force == 0 && first_missing < raiddisks &&
            st->ss->external == 0 &&
            second_missing >= raiddisks && level == 6) {
                insert_point = raiddisks - 1;
@@ -546,30 +549,43 @@ int Create(struct supertype *st, char *mddev,
        }
 
        if (level <= 0 && first_missing < subdevs * 2) {
-               fprintf(stderr,
-                       Name ": This level does not support missing devices\n");
+               pr_err("This level does not support missing devices\n");
                return 1;
        }
 
        /* We need to create the device */
        map_lock(&map);
-       mdfd = create_mddev(mddev, name, autof, LOCAL, chosen_name);
-       if (mdfd < 0)
+       mdfd = create_mddev(mddev, name, c->autof, LOCAL, chosen_name);
+       if (mdfd < 0) {
+               map_unlock(&map);
+               return 1;
+       }
+       /* verify if chosen_name is not in use,
+        * it could be in conflict with already existing device
+        * e.g. container, array
+        */
+       if (strncmp(chosen_name, "/dev/md/", 8) == 0
+           && map_by_name(&map, chosen_name+8) != NULL) {
+               pr_err("Array name %s is in use already.\n",
+                       chosen_name);
+               close(mdfd);
+               map_unlock(&map);
                return 1;
+       }
        mddev = chosen_name;
 
        vers = md_get_version(mdfd);
        if (vers < 9000) {
-               fprintf(stderr, Name ": Create requires md driver version 0.90.0 or later\n");
-               goto abort;
+               pr_err("Create requires md driver version 0.90.0 or later\n");
+               goto abort_locked;
        } else {
                mdu_array_info_t inf;
                memset(&inf, 0, sizeof(inf));
                ioctl(mdfd, GET_ARRAY_INFO, &inf);
                if (inf.working_disks != 0) {
-                       fprintf(stderr, Name ": another array by this name"
+                       pr_err("another array by this name"
                                " is already running.\n");
-                       goto abort;
+                       goto abort_locked;
                }
        }
 
@@ -664,14 +680,14 @@ int Create(struct supertype *st, char *mddev,
                                name += 2;
                }
        }
-       if (!st->ss->init_super(st, &info.array, size, name, homehost, uuid))
-               goto abort;
+       if (!st->ss->init_super(st, &info.array, size, name, c->homehost, uuid))
+               goto abort_locked;
 
        total_slots = info.array.nr_disks;
        st->ss->getinfo_super(st, &info, NULL);
        sysfs_init(&info, mdfd, 0);
 
-       if (did_default && verbose >= 0) {
+       if (did_default && c->verbose >= 0) {
                if (is_subarray(info.text_version)) {
                        int dnum = devname2devnum(info.text_version+1);
                        char *path;
@@ -684,12 +700,12 @@ int Create(struct supertype *st, char *mddev,
 
                        mdi = sysfs_read(-1, dnum, GET_VERSION);
 
-                       fprintf(stderr, Name ": Creating array inside "
+                       pr_err("Creating array inside "
                                "%s container %s\n", 
                                mdi?mdi->text_version:"managed", path);
                        sysfs_free(mdi);
                } else
-                       fprintf(stderr, Name ": Defaulting to version"
+                       pr_err("Defaulting to version"
                                " %s metadata\n", info.text_version);
        }
 
@@ -700,25 +716,25 @@ int Create(struct supertype *st, char *mddev,
        if (bitmap_file && vers < 9003) {
                major_num = BITMAP_MAJOR_HOSTENDIAN;
 #ifdef __BIG_ENDIAN
-               fprintf(stderr, Name ": Warning - bitmaps created on this kernel are not portable\n"
+               pr_err("Warning - bitmaps created on this kernel are not portable\n"
                        "  between different architectured.  Consider upgrading the Linux kernel.\n");
 #endif
        }
 
        if (bitmap_file && strcmp(bitmap_file, "internal")==0) {
                if ((vers%100) < 2) {
-                       fprintf(stderr, Name ": internal bitmaps not supported by this kernel.\n");
+                       pr_err("internal bitmaps not supported by this kernel.\n");
                        goto abort;
                }
                if (!st->ss->add_internal_bitmap) {
-                       fprintf(stderr, Name ": internal bitmaps not supported with %s metadata\n",
+                       pr_err("internal bitmaps not supported with %s metadata\n",
                                st->ss->name);
                        goto abort;
                }
                if (!st->ss->add_internal_bitmap(st, &bitmap_chunk,
-                                                delay, write_behind,
+                                                c->delay, write_behind,
                                                 bitmapsize, 1, major_num)) {
-                       fprintf(stderr, Name ": Given bitmap chunk size not supported.\n");
+                       pr_err("Given bitmap chunk size not supported.\n");
                        goto abort;
                }
                bitmap_file = NULL;
@@ -744,13 +760,13 @@ int Create(struct supertype *st, char *mddev,
                 */
                container_fd = open_dev_excl(st->container_dev);
                if (container_fd < 0) {
-                       fprintf(stderr, Name ": Cannot get exclusive "
+                       pr_err("Cannot get exclusive "
                                "open on container - weird.\n");
                        goto abort;
                }
                if (mdmon_running(st->container_dev)) {
-                       if (verbose)
-                               fprintf(stderr, Name ": reusing mdmon "
+                       if (c->verbose)
+                               pr_err("reusing mdmon "
                                        "for %s.\n",
                                        devnum2devname(st->container_dev));
                        st->update_tail = &st->updates;
@@ -759,7 +775,7 @@ int Create(struct supertype *st, char *mddev,
        }
        rv = set_array_info(mdfd, st, &info);
        if (rv) {
-               fprintf(stderr, Name ": failed to set array info for %s: %s\n",
+               pr_err("failed to set array info for %s: %s\n",
                        mddev, strerror(errno));
                goto abort;
        }
@@ -768,26 +784,26 @@ int Create(struct supertype *st, char *mddev,
                int uuid[4];
 
                st->ss->uuid_from_super(st, uuid);
-               if (CreateBitmap(bitmap_file, force, (char*)uuid, bitmap_chunk,
-                                delay, write_behind,
+               if (CreateBitmap(bitmap_file, c->force, (char*)uuid, bitmap_chunk,
+                                c->delay, write_behind,
                                 bitmapsize,
                                 major_num)) {
                        goto abort;
                }
                bitmap_fd = open(bitmap_file, O_RDWR);
                if (bitmap_fd < 0) {
-                       fprintf(stderr, Name ": weird: %s cannot be openned\n",
+                       pr_err("weird: %s cannot be openned\n",
                                bitmap_file);
                        goto abort;
                }
                if (ioctl(mdfd, SET_BITMAP_FILE, bitmap_fd) < 0) {
-                       fprintf(stderr, Name ": Cannot set bitmap file for %s: %s\n",
+                       pr_err("Cannot set bitmap file for %s: %s\n",
                                mddev, strerror(errno));
                        goto abort;
                }
        }
 
-       infos = malloc(sizeof(*infos) * total_slots);
+       infos = xmalloc(sizeof(*infos) * total_slots);
 
        for (pass=1; pass <=2 ; pass++) {
                struct mddev_dev *moved_disk = NULL; /* the disk that was moved out of the insert point */
@@ -837,7 +853,7 @@ int Create(struct supertype *st, char *mddev,
                                                fd = open(dv->devname, O_RDWR|O_EXCL);
 
                                        if (fd < 0) {
-                                               fprintf(stderr, Name ": failed to open %s "
+                                               pr_err("failed to open %s "
                                                        "after earlier success - aborting\n",
                                                        dv->devname);
                                                goto abort;
@@ -856,8 +872,8 @@ int Create(struct supertype *st, char *mddev,
                                st->ss->getinfo_super(st, inf, NULL);
                                safe_mode_delay = inf->safe_mode_delay;
 
-                               if (have_container && verbose > 0)
-                                       fprintf(stderr, Name ": Using %s for device %d\n",
+                               if (have_container && c->verbose > 0)
+                                       pr_err("Using %s for device %d\n",
                                                map_dev(inf->disk.major,
                                                        inf->disk.minor,
                                                        0), dnum);
@@ -874,10 +890,9 @@ int Create(struct supertype *st, char *mddev,
                                rv = add_disk(mdfd, st, &info, inf);
 
                                if (rv) {
-                                       fprintf(stderr,
-                                               Name ": ADD_NEW_DISK for %s "
-                                               "failed: %s\n",
-                                               dv->devname, strerror(errno));
+                                       pr_err("ADD_NEW_DISK for %s "
+                                              "failed: %s\n",
+                                              dv->devname, strerror(errno));
                                        goto abort;
                                }
                                break;
@@ -906,16 +921,13 @@ int Create(struct supertype *st, char *mddev,
                        }
 
                        if (st->ss->write_init_super(st)) {
-                               fprintf(stderr,
-                                       Name ": Failed to write metadata to %s\n",
-                                       dv->devname);
                                st->ss->free_super(st);
-                               goto abort;
+                               goto abort_locked;
                        }
 
                        /* update parent container uuid */
                        if (me) {
-                               char *path = strdup(me->path);
+                               char *path = xstrdup(me->path);
 
                                st->ss->getinfo_super(st, &info_new, NULL);
                                map_update(&map, st->container_dev,
@@ -935,10 +947,10 @@ int Create(struct supertype *st, char *mddev,
                /* No need to start.  But we should signal udev to
                 * create links */
                sysfs_uevent(&info, "change");
-               if (verbose >= 0)
-                       fprintf(stderr, Name ": container %s prepared.\n", mddev);
+               if (c->verbose >= 0)
+                       pr_err("container %s prepared.\n", mddev);
                wait_for(chosen_name, mdfd);
-       } else if (runstop == 1 || subdevs >= raiddisks) {
+       } else if (c->runstop == 1 || subdevs >= raiddisks) {
                if (st->ss->external) {
                        int err;
                        switch(level) {
@@ -946,7 +958,9 @@ int Create(struct supertype *st, char *mddev,
                        case LEVEL_MULTIPATH:
                        case 0:
                                err = sysfs_set_str(&info, NULL, "array_state",
-                                                   "active");
+                                                   c->readonly
+                                                   ? "readonly"
+                                                   : "active");
                                need_mdmon = 0;
                                break;
                        default:
@@ -956,8 +970,18 @@ int Create(struct supertype *st, char *mddev,
                        }
                        sysfs_set_safemode(&info, safe_mode_delay);
                        if (err) {
-                               fprintf(stderr, Name ": failed to"
-                                       " activate array.\n");
+                               pr_err("failed to"
+                                      " activate array.\n");
+                               ioctl(mdfd, STOP_ARRAY, NULL);
+                               goto abort;
+                       }
+               } else if (c->readonly &&
+                          sysfs_attribute_available(
+                                  &info, NULL, "array_state")) {
+                       if (sysfs_set_str(&info, NULL,
+                                         "array_state", "readonly") < 0) {
+                               pr_err("Failed to start array: %s\n",
+                                      strerror(errno));
                                ioctl(mdfd, STOP_ARRAY, NULL);
                                goto abort;
                        }
@@ -965,18 +989,18 @@ int Create(struct supertype *st, char *mddev,
                        /* param is not actually used */
                        mdu_param_t param;
                        if (ioctl(mdfd, RUN_ARRAY, &param)) {
-                               fprintf(stderr, Name ": RUN_ARRAY failed: %s\n",
-                                       strerror(errno));
+                               pr_err("RUN_ARRAY failed: %s\n",
+                                      strerror(errno));
                                if (info.array.chunk_size & (info.array.chunk_size-1)) {
-                                       fprintf(stderr, "     : Problem may be that "
-                                               "chunk size is not a power of 2\n");
+                                       cont_err("Problem may be that "
+                                                "chunk size is not a power of 2\n");
                                }
                                ioctl(mdfd, STOP_ARRAY, NULL);
                                goto abort;
                        }
                }
-               if (verbose >= 0)
-                       fprintf(stderr, Name ": array %s started.\n", mddev);
+               if (c->verbose >= 0)
+                       pr_err("array %s started.\n", mddev);
                if (st->ss->external && st->container_dev != NoMdDev) {
                        if (need_mdmon)
                                start_mdmon(st->container_dev);
@@ -986,13 +1010,14 @@ int Create(struct supertype *st, char *mddev,
                }
                wait_for(chosen_name, mdfd);
        } else {
-               fprintf(stderr, Name ": not starting array - not enough devices.\n");
+               pr_err("not starting array - not enough devices.\n");
        }
        close(mdfd);
        return 0;
 
  abort:
        map_lock(&map);
+ abort_locked:
        map_remove(&map, fd2devnum(mdfd));
        map_unlock(&map);