]> git.ipfire.org Git - thirdparty/mdadm.git/blobdiff - Grow.c
Fix unterminated buffer after readlink() call
[thirdparty/mdadm.git] / Grow.c
diff --git a/Grow.c b/Grow.c
index 08fc258bae4a6a57b08ad5ca10ea521532a7680e..4f8b9d74ca0898607c9f996a1e67e0999179ee82 100644 (file)
--- a/Grow.c
+++ b/Grow.c
 #define offsetof(t,f) ((size_t)&(((t*)0)->f))
 #endif
 
+int restore_backup(struct supertype *st,
+                  struct mdinfo *content,
+                  int working_disks,
+                  int next_spare,
+                  char *backup_file,
+                  int verbose)
+{
+       int i;
+       int *fdlist;
+       struct mdinfo *dev;
+       int err;
+       int disk_count = next_spare + working_disks;
+
+       dprintf("Called restore_backup()\n");
+       fdlist = malloc(sizeof(int) * disk_count);
+       if (fdlist == NULL) {
+               fprintf(stderr,
+                       Name ": cannot allocate memory for disk list\n");
+               return 1;
+       }
+       for (i = 0; i < next_spare; i++)
+               fdlist[i] = -1;
+       for (dev = content->devs; dev; dev = dev->next) {
+               char buf[22];
+               int fd;
+               sprintf(buf, "%d:%d",
+                       dev->disk.major,
+                       dev->disk.minor);
+               fd = dev_open(buf, O_RDWR);
+
+               if (dev->disk.raid_disk >= 0)
+                       fdlist[dev->disk.raid_disk] = fd;
+               else
+                       fdlist[next_spare++] = fd;
+       }
+
+       if (st->ss->external && st->ss->recover_backup)
+               err = st->ss->recover_backup(st, content);
+       else
+               err = Grow_restart(st, content, fdlist, next_spare,
+                                  backup_file, verbose > 0);
+
+       while (next_spare > 0) {
+               next_spare--;
+               if (fdlist[next_spare] >= 0)
+                       close(fdlist[next_spare]);
+       }
+       free(fdlist);
+       if (err) {
+               fprintf(stderr, Name ": Failed to restore critical"
+                       " section for reshape - sorry.\n");
+               if (!backup_file)
+                       fprintf(stderr, Name ":  Possibly you need"
+                               " to specify a --backup-file\n");
+               return 1;
+       }
+
+       dprintf("restore_backup() returns status OK.\n");
+       return 0;
+}
+
 int Grow_Add_device(char *devname, int fd, char *newdev)
 {
        /* Add a device to an active array.
@@ -521,9 +582,15 @@ static int freeze(struct supertype *st)
        else {
                struct mdinfo *sra = sysfs_read(-1, st->devnum, GET_VERSION);
                int err;
+               char buf[20];
 
                if (!sra)
                        return -1;
+               /* Need to clear any 'read-auto' status */
+               if (sysfs_get_str(sra, NULL, "array_state", buf, 20) > 0 &&
+                   strncmp(buf, "read-auto", 9) == 0)
+                       sysfs_set_str(sra, NULL, "array_state", "clean");
+
                err = sysfs_freeze_array(sra);
                sysfs_free(sra);
                return err;
@@ -629,15 +696,19 @@ static int subarray_set_num(char *container, struct mdinfo *sra, char *name, int
        return rc;
 }
 
-int start_reshape(struct mdinfo *sra, int already_running)
+int start_reshape(struct mdinfo *sra, int already_running, int data_disks)
 {
        int err;
+       unsigned long long sync_max_to_set;
+
        sysfs_set_num(sra, NULL, "suspend_lo", 0x7FFFFFFFFFFFFFFFULL);
-       err = sysfs_set_num(sra, NULL, "suspend_hi", 0);
-       err = err ?: sysfs_set_num(sra, NULL, "suspend_lo", 0);
+       err = sysfs_set_num(sra, NULL, "suspend_hi", sra->reshape_progress);
+       err = err ?: sysfs_set_num(sra, NULL, "suspend_lo",
+                                  sra->reshape_progress);
+       sync_max_to_set = sra->reshape_progress / data_disks;
        if (!already_running)
-               sysfs_set_num(sra, NULL, "sync_min", 0);
-       err = err ?: sysfs_set_num(sra, NULL, "sync_max", 0);
+               sysfs_set_num(sra, NULL, "sync_min", sync_max_to_set);
+       err = err ?: sysfs_set_num(sra, NULL, "sync_max", sync_max_to_set);
        if (!already_running)
                err = err ?: sysfs_set_str(sra, NULL, "sync_action", "reshape");
 
@@ -893,6 +964,10 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
         * when assembling an array that is undergoing reshape.
         */
        int new_disks;
+       /* delta_parity records change in number of devices
+        * caused by level change
+        */
+       int delta_parity = 0;
 
        /* If a new level not explicitly given, we assume no-change */
        if (info->new_level == UnSet)
@@ -919,12 +994,18 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
                info->new_chunk = info->array.chunk_size;
 
        switch (info->array.level) {
+       default:
+               return "Cannot understand this RAID level";
        case 1:
                /* RAID1 can convert to RAID1 with different disks, or
                 * raid5 with 2 disks, or
                 * raid0 with 1 disk
                 */
                if (info->new_level == 0) {
+                       if (info->delta_disks != UnSet &&
+                           info->delta_disks != 0)
+                               return "Cannot change number of disks "
+                                       "with RAID1->RAID0 conversion";
                        re->level = 0;
                        re->before.data_disks = 1;
                        re->after.data_disks = 1;
@@ -944,9 +1025,17 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
                }
                if (info->array.raid_disks == 2 &&
                    info->new_level == 5) {
+
                        re->level = 5;
                        re->before.data_disks = 1;
-                       re->after.data_disks = 1;
+                       if (info->delta_disks != UnSet &&
+                           info->delta_disks != 0)
+                               re->after.data_disks = 1 + info->delta_disks;
+                       else
+                               re->after.data_disks = 1;
+                       if (re->after.data_disks < 1)
+                               return "Number of disks too small for RAID5";
+
                        re->before.layout = ALGORITHM_LEFT_SYMMETRIC;
                        info->array.chunk_size = 65536;
                        break;
@@ -970,10 +1059,10 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
                        return "RAID10 can only be changed to RAID0";
                new_disks = (info->array.raid_disks
                             / (info->array.layout & 0xff));
-               if (info->delta_disks == UnSet) {
+               if (info->delta_disks == UnSet)
                        info->delta_disks = (new_disks
                                             - info->array.raid_disks);
-               }
+
                if (info->delta_disks != new_disks - info->array.raid_disks)
                        return "New number of raid-devices impossible for RAID10";
                if (info->new_chunk &&
@@ -1032,16 +1121,19 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
                 * a raid4 style layout of the final level.
                 */
                switch (info->new_level) {
-               case 0:
                case 4:
+                       delta_parity = 1;
+               case 0:
                        re->level = 4;
                        re->before.layout = 0;
                        break;
                case 5:
+                       delta_parity = 1;
                        re->level = 5;
                        re->before.layout = ALGORITHM_PARITY_N;
                        break;
                case 6:
+                       delta_parity = 2;
                        re->level = 6;
                        re->before.layout = ALGORITHM_PARITY_N;
                        break;
@@ -1056,6 +1148,8 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
                info->array.layout = ALGORITHM_PARITY_N;
        case 5:
                switch (info->new_level) {
+               case 0:
+                       delta_parity = -1;
                case 4:
                        re->level = info->array.level;
                        re->before.data_disks = info->array.raid_disks - 1;
@@ -1067,6 +1161,7 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
                        re->before.layout = info->array.layout;
                        break;
                case 6:
+                       delta_parity = 1;
                        re->level = 6;
                        re->before.data_disks = info->array.raid_disks - 1;
                        switch (info->array.layout) {
@@ -1095,6 +1190,10 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
                case 1:
                        if (info->array.raid_disks != 2)
                                return "Can only convert a 2-device array to RAID1";
+                       if (info->delta_disks != UnSet &&
+                           info->delta_disks != 0)
+                               return "Cannot set raid_disk when "
+                                       "converting RAID5->RAID1";
                        re->level = 1;
                        break;
                default:
@@ -1105,6 +1204,7 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
                switch (info->new_level) {
                case 4:
                case 5:
+                       delta_parity = -1;
                case 6:
                        re->level = 6;
                        re->before.data_disks = info->array.raid_disks - 2;
@@ -1130,11 +1230,7 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
                 */
                if (re->level != 4 && re->level != 5)
                        return "Cannot covert to RAID0 from this level";
-               if (info->delta_disks == UnSet)
-                       re->after.data_disks = re->before.data_disks;
-               else
-                       re->after.data_disks =
-                               info->array.raid_disks + info->delta_disks;
+
                switch (re->level) {
                case 4:
                        re->after.layout = 0 ; break;
@@ -1147,11 +1243,7 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
                /* We can only get to RAID4 from RAID5 */
                if (re->level != 4 && re->level != 5)
                        return "Cannot convert to RAID4 from this level";
-               if (info->delta_disks == UnSet)
-                       re->after.data_disks = re->before.data_disks;
-               else
-                       re->after.data_disks =
-                               re->before.data_disks + info->delta_disks;
+
                switch (re->level) {
                case 4:
                        re->after.layout = 0 ; break;
@@ -1164,14 +1256,7 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
                /* We get to RAID5 for RAID5 or RAID6 */
                if (re->level != 5 && re->level != 6)
                        return "Cannot convert to RAID5 from this level";
-               if (info->delta_disks == UnSet)
-                       re->after.data_disks = re->before.data_disks;
-               else if (re->level == 5)
-                       re->after.data_disks =
-                               re->before.data_disks + info->delta_disks;
-               else
-                       re->after.data_disks =
-                               info->array.raid_disks + info->delta_disks - 1;
+
                switch (re->level) {
                case 5:
                        if (info->new_layout == UnSet)
@@ -1204,11 +1289,6 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
                /* We must already be at level 6 */
                if (re->level != 6)
                        return "Impossible level change";
-               if (info->delta_disks == UnSet)
-                       re->after.data_disks = re->before.data_disks;
-               else
-                       re->after.data_disks = (info->array.raid_disks +
-                                               info->delta_disks) - 2;
                if (info->new_layout == UnSet)
                        re->after.layout = info->array.layout;
                else
@@ -1217,6 +1297,12 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
        default:
                return "Impossible level change requested";
        }
+       if (info->delta_disks == UnSet)
+               info->delta_disks = delta_parity;
+
+       re->after.data_disks = (re->before.data_disks
+                               + info->delta_disks
+                               - delta_parity);
        switch (re->level) {
        case 6: re->parity = 2; break;
        case 4:
@@ -1247,7 +1333,7 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
 
        if (re->after.data_disks < re->before.data_disks &&
            get_linux_version() < 2006030)
-               return "reshape to fewer devices is not supported before 2.6.32 - sorry.";
+               return "reshape to fewer devices is not supported before 2.6.30 - sorry.";
 
        re->backup_blocks = compute_backup_blocks(
                info->new_chunk, info->array.chunk_size,
@@ -1260,19 +1346,21 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
 
 static int reshape_array(char *container, int fd, char *devname,
                         struct supertype *st, struct mdinfo *info,
-                        int force, char *backup_file, int quiet, int forked,
-                        int restart);
-static int reshape_container(char *container, int cfd, char *devname,
+                        int force, struct mddev_dev *devlist,
+                        char *backup_file, int quiet, int forked,
+                        int restart, int freeze_reshape);
+static int reshape_container(char *container, char *devname,
                             struct supertype *st, 
                             struct mdinfo *info,
                             int force,
                             char *backup_file,
-                            int quiet);
+                            int quiet, int restart, int freeze_reshape);
 
 int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
                 long long size,
                 int level, char *layout_str, int chunksize, int raid_disks,
-                int force)
+                struct mddev_dev *devlist,
+                int assume_clean, int force)
 {
        /* Make some changes in the shape of an array.
         * The kernel must support the change.
@@ -1302,6 +1390,9 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
        char container_buf[20];
        int cfd = -1;
 
+       struct mddev_dev *dv;
+       int added_disks;
+
        struct mdinfo info;
        struct mdinfo *sra;
 
@@ -1377,10 +1468,13 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
 
                if (mdmon_running(container_dev))
                        st->update_tail = &st->updates;
-       } 
+       }
 
+       added_disks = 0;
+       for (dv = devlist; dv; dv = dv->next)
+               added_disks++;
        if (raid_disks > array.raid_disks &&
-           array.spare_disks < (raid_disks - array.raid_disks) &&
+           array.spare_disks +added_disks < (raid_disks - array.raid_disks) &&
            !force) {
                fprintf(stderr,
                        Name ": Need %d spare%s to avoid degraded array,"
@@ -1388,7 +1482,7 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
                        "       Use --force to over-ride this check.\n",
                        raid_disks - array.raid_disks, 
                        raid_disks - array.raid_disks == 1 ? "" : "s", 
-                       array.spare_disks);
+                       array.spare_disks + added_disks);
                return 1;
        }
 
@@ -1416,7 +1510,12 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
 
        /* ========= set size =============== */
        if (size >= 0 && (size == 0 || size != array.size)) {
-               long long orig_size = array.size;
+               long long orig_size = get_component_size(fd)/2;
+               long long min_csize;
+               struct mdinfo *mdi;
+
+               if (orig_size == 0)
+                       orig_size = array.size;
 
                if (reshape_super(st, size, UnSet, UnSet, 0, 0, UnSet, NULL,
                                  devname, !quiet)) {
@@ -1424,6 +1523,45 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
                        goto release;
                }
                sync_metadata(st);
+
+               /* Update the size of each member device in case
+                * they have been resized.  This will never reduce
+                * below the current used-size.  The "size" attribute
+                * understands '0' to mean 'max'.
+                */
+               min_csize = 0;
+               for (mdi = sra->devs; mdi; mdi = mdi->next) {
+                       if (sysfs_set_num(sra, mdi, "size", size) < 0)
+                               break;
+                       if (array.not_persistent == 0 &&
+                           array.major_version == 0 &&
+                           get_linux_version() < 3001000) {
+                               /* Dangerous to allow size to exceed 2TB */
+                               unsigned long long csize;
+                               if (sysfs_get_ll(sra, mdi, "size", &csize) == 0) {
+                                       if (csize >= 2ULL*1024*1024*1024)
+                                               csize = 2ULL*1024*1024*1024;
+                                       if ((min_csize == 0 || (min_csize
+                                                               > (long long)csize)))
+                                               min_csize = csize;
+                               }
+                       }
+               }
+               if (min_csize && size > min_csize) {
+                       fprintf(stderr, Name ": Cannot safely make this array "
+                               "use more than 2TB per device on this kernel.\n");
+                       rv = 1;
+                       goto release;
+               }
+               if (min_csize && size == 0) {
+                       /* Don't let the kernel choose a size - it will get
+                        * it wrong
+                        */
+                       fprintf(stderr, Name ": Limited v0.90 array to "
+                               "2TB per device\n");
+                       size = min_csize;
+               }
+
                array.size = size;
                if (array.size != size) {
                        /* got truncated to 32bit, write to
@@ -1451,13 +1589,28 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
                        rv = 1;
                        goto release;
                }
+               if (assume_clean) {
+                       /* This will fail on kernels newer than 3.0 unless
+                        * a backport has been arranged.
+                        */
+                       if (sra == NULL ||
+                           sysfs_set_str(sra, NULL, "resync_start", "none") < 0)
+                               fprintf(stderr, Name ": --assume-clean not support with --grow on this kernel\n");
+               }
                ioctl(fd, GET_ARRAY_INFO, &array);
                size = get_component_size(fd)/2;
                if (size == 0)
                        size = array.size;
-               if (!quiet)
-                       fprintf(stderr, Name ": component size of %s has been set to %lluK\n",
-                               devname, size);
+               if (!quiet) {
+                       if (size == orig_size)
+                               fprintf(stderr, Name ": component size of %s "
+                                       "unchanged at %lluK\n",
+                                       devname, size);
+                       else
+                               fprintf(stderr, Name ": component size of %s "
+                                       "has been set to %lluK\n",
+                                       devname, size);
+               }
                changed = 1;
        } else if (array.level != LEVEL_CONTAINER) {
                size = get_component_size(fd)/2;
@@ -1465,6 +1618,18 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
                        size = array.size;
        }
 
+       /* See if there is anything else to do */
+       if ((level == UnSet || level == array.level) &&
+           (layout_str == NULL) &&
+           (chunksize == 0 || chunksize == array.chunk_size) &&
+           (raid_disks == 0 || raid_disks == array.raid_disks)) {
+               /* Nothing more to do */
+               if (!changed && !quiet)
+                       fprintf(stderr, Name ": %s: no change requested\n",
+                               devname);
+               goto release;
+       }
+
        /* ========= check for Raid10/Raid1 -> Raid0 conversion ===============
         * current implementation assumes that following conditions must be met:
         * - RAID10:
@@ -1487,13 +1652,17 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
                ping_monitor(container);
        }
 
+       memset(&info, 0, sizeof(info));
        info.array = array;
        sysfs_init(&info, fd, NoMdDev);
        strcpy(info.text_version, sra->text_version);
        info.component_size = size*2;
        info.new_level = level;
        info.new_chunk = chunksize * 1024;
-       if (raid_disks)
+       if (info.array.level == LEVEL_CONTAINER) {
+               info.delta_disks = UnSet;
+               info.array.raid_disks = raid_disks;
+       } else if (raid_disks)
                info.delta_disks = raid_disks - info.array.raid_disks;
        else
                info.delta_disks = UnSet;
@@ -1560,7 +1729,33 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
                }
        }
 
-       if (array.level == LEVEL_CONTAINER) {
+       if (array.level == LEVEL_FAULTY) {
+               if (level != UnSet && level != array.level) {
+                       fprintf(stderr, Name ": cannot change level of Faulty device\n");
+                       rv =1 ;
+               }
+               if (chunksize) {
+                       fprintf(stderr, Name ": cannot set chunksize of Faulty device\n");
+                       rv =1 ;
+               }
+               if (raid_disks && raid_disks != 1) {
+                       fprintf(stderr, Name ": cannot set raid_disks of Faulty device\n");
+                       rv =1 ;
+               }
+               if (layout_str) {
+                       if (ioctl(fd, GET_ARRAY_INFO, &array) != 0) {
+                               dprintf("Cannot get array information.\n");
+                               goto release;
+                       }
+                       array.layout = info.new_layout;
+                       if (ioctl(fd, SET_ARRAY_INFO, &array) != 0) {
+                               fprintf(stderr, Name ": failed to set new layout\n");
+                               rv = 1;
+                       } else if (!quiet)
+                               printf("layout for %s set to %d\n",
+                                      devname, array.layout);
+               }
+       } else if (array.level == LEVEL_CONTAINER) {
                /* This change is to be applied to every array in the
                 * container.  This is only needed when the metadata imposes
                 * restraints of the various arrays in the container.
@@ -1569,8 +1764,8 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
                 * number of devices (On-Line Capacity Expansion) must be
                 * performed at the level of the container
                 */
-               rv = reshape_container(container, fd, devname, st, &info,
-                                      force, backup_file, quiet);
+               rv = reshape_container(container, devname, st, &info,
+                                      force, backup_file, quiet, 0, 0);
                frozen = 0;
        } else {
                /* get spare devices from external metadata
@@ -1598,7 +1793,7 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
                }
                sync_metadata(st);
                rv = reshape_array(container, fd, devname, st, &info, force,
-                                  backup_file, quiet, 0, 0);
+                                  devlist, backup_file, quiet, 0, 0, 0);
                frozen = 0;
        }
 release:
@@ -1609,9 +1804,9 @@ release:
 
 static int reshape_array(char *container, int fd, char *devname,
                         struct supertype *st, struct mdinfo *info,
-                        int force,
+                        int force, struct mddev_dev *devlist,
                         char *backup_file, int quiet, int forked,
-                        int restart)
+                        int restart, int freeze_reshape)
 {
        struct reshape reshape;
        int spares_needed;
@@ -1622,6 +1817,9 @@ static int reshape_array(char *container, int fd, char *devname,
        struct mdu_array_info_s array;
        char *c;
 
+       struct mddev_dev *dv;
+       int added_disks;
+
        int *fdlist;
        unsigned long long *offsets;
        int d;
@@ -1633,13 +1831,41 @@ static int reshape_array(char *container, int fd, char *devname,
        int done;
        struct mdinfo *sra = NULL;
 
-       msg = analyse_change(info, &reshape);
+       /* when reshaping a RAID0, the component_size might be zero.
+        * So try to fix that up.
+        */
+       if (ioctl(fd, GET_ARRAY_INFO, &array) != 0) {
+               dprintf("Cannot get array information.\n");
+               goto release;
+       }
+       if (array.level == 0 && info->component_size == 0) {
+               get_dev_size(fd, NULL, &array_size);
+               info->component_size = array_size / array.raid_disks;
+       }
+
+       if (info->reshape_active) {
+               int new_level = info->new_level;
+               info->new_level = UnSet;
+               info->array.raid_disks -= info->delta_disks;
+               msg = analyse_change(info, &reshape);
+               info->new_level = new_level;
+               info->array.raid_disks += info->delta_disks;
+               if (!restart)
+                       /* Make sure the array isn't read-only */
+                       ioctl(fd, RESTART_ARRAY_RW, 0);
+       } else
+               msg = analyse_change(info, &reshape);
        if (msg) {
                fprintf(stderr, Name ": %s\n", msg);
                goto release;
        }
-       if (ioctl(fd, GET_ARRAY_INFO, &array) != 0) {
-               dprintf("Canot get array information.\n");
+       if (restart &&
+           (reshape.level != info->array.level ||
+            reshape.before.layout != info->array.layout ||
+            reshape.before.data_disks + reshape.parity
+            != info->array.raid_disks - info->delta_disks)) {
+               fprintf(stderr, Name ": reshape info is not in native format -"
+                       " cannot continue.\n");
                goto release;
        }
 
@@ -1655,24 +1881,42 @@ static int reshape_array(char *container, int fd, char *devname,
         * freeze_array and freeze_container.
         */
        sysfs_freeze_array(info);
+       /* Check we have enough spares to not be degraded */
+       added_disks = 0;
+       for (dv = devlist; dv ; dv=dv->next)
+               added_disks++;
        spares_needed = max(reshape.before.data_disks,
                            reshape.after.data_disks)
                + reshape.parity - array.raid_disks;
 
        if (!force &&
-           info->new_level > 1 &&
-           spares_needed > info->array.spare_disks) {
+           info->new_level > 1 && info->array.level > 1 &&
+           spares_needed > info->array.spare_disks + added_disks) {
                fprintf(stderr,
                        Name ": Need %d spare%s to avoid degraded array,"
                        " and only have %d.\n"
                        "       Use --force to over-ride this check.\n",
                        spares_needed,
                        spares_needed == 1 ? "" : "s", 
-                       info->array.spare_disks);
+                       info->array.spare_disks + added_disks);
+               goto release;
+       }
+       /* Check we have enough spares to not fail */
+       spares_needed = max(reshape.before.data_disks,
+                           reshape.after.data_disks)
+               - array.raid_disks;
+       if ((info->new_level > 1 || info->new_level == 0) &&
+           spares_needed > info->array.spare_disks +added_disks) {
+               fprintf(stderr,
+                       Name ": Need %d spare%s to create working array,"
+                       " and only have %d.\n",
+                       spares_needed,
+                       spares_needed == 1 ? "" : "s", 
+                       info->array.spare_disks + added_disks);
                goto release;
        }
 
-       if (reshape.level != info->array.level) {
+       if (reshape.level != array.level) {
                char *c = map_num(pers, reshape.level);
                int err;
                if (c == NULL)
@@ -1692,7 +1936,7 @@ static int reshape_array(char *container, int fd, char *devname,
                if (!quiet)
                        fprintf(stderr, Name ": level of %s changed to %s\n",
                                devname, c);    
-               orig_level = info->array.level;
+               orig_level = array.level;
                sysfs_freeze_array(info);
 
                if (reshape.level > 0 && st->ss->external) {
@@ -1700,6 +1944,9 @@ static int reshape_array(char *container, int fd, char *devname,
                        if (!mdmon_running(st->container_dev))
                                start_mdmon(st->container_dev);
                        ping_monitor(container);
+                       if (mdmon_running(st->container_dev) &&
+                           st->update_tail == NULL)
+                               st->update_tail = &st->updates;
                }
        }
        /* ->reshape_super might have chosen some spares from the
@@ -1715,6 +1962,15 @@ static int reshape_array(char *container, int fd, char *devname,
 
                if (info2) {
                        sysfs_init(info2, fd, st->devnum);
+                       /* When increasing number of devices, we need to set
+                        * new raid_disks before adding these, or they might
+                        * be rejected.
+                        */
+                       if (reshape.backup_blocks &&
+                           reshape.after.data_disks > reshape.before.data_disks)
+                               subarray_set_num(container, info2, "raid_disks",
+                                                reshape.after.data_disks +
+                                                reshape.parity);
                        for (d = info2->devs; d; d = d->next) {
                                if (d->disk.state == 0 &&
                                    d->disk.raid_disk >= 0) {
@@ -1727,6 +1983,13 @@ static int reshape_array(char *container, int fd, char *devname,
                        sysfs_free(info2);
                }
        }
+       /* We might have been given some devices to add to the
+        * array.  Now that the array has been changed to the right
+        * level and frozen, we can safely add them.
+        */
+       if (devlist)
+               Manage_subdevs(devname, fd, devlist, !quiet,
+                              0,NULL, 0);
 
        if (reshape.backup_blocks == 0) {
                /* No restriping needed, but we might need to impose
@@ -1734,7 +1997,7 @@ static int reshape_array(char *container, int fd, char *devname,
                 */
                /* read current array info */
                if (ioctl(fd, GET_ARRAY_INFO, &array) != 0) {
-                       dprintf("Canot get array information.\n");
+                       dprintf("Cannot get array information.\n");
                        goto release;
                }
                /* compare current array info with new values and if
@@ -1872,25 +2135,29 @@ started:
        if (d < 0) {
                goto release;
        }
-       if (backup_file == NULL) {
-               if (reshape.after.data_disks <= reshape.before.data_disks) {
-                       fprintf(stderr,
-                               Name ": %s: Cannot grow - need backup-file\n", 
-                               devname);
-                       goto release;
-               } else if (sra->array.spare_disks == 0) {
-                       fprintf(stderr, Name ": %s: Cannot grow - need a spare or "
-                               "backup-file to backup critical section\n",
-                               devname);
-                       goto release;
-               }
-       } else {
-               if (!reshape_open_backup_file(backup_file, fd, devname,
-                                             (signed)blocks,
-                                             fdlist+d, offsets+d, restart)) {
-                       goto release;
+       if ((st->ss->manage_reshape == NULL) ||
+           (st->ss->recover_backup == NULL)) {
+               if (backup_file == NULL) {
+                       if (reshape.after.data_disks <=
+                           reshape.before.data_disks) {
+                               fprintf(stderr, Name ": %s: Cannot grow - "
+                                       "need backup-file\n", devname);
+                               goto release;
+                       } else if (sra->array.spare_disks == 0) {
+                               fprintf(stderr, Name ": %s: Cannot grow - "
+                                       "need a spare or backup-file to backup "
+                                       "critical section\n", devname);
+                               goto release;
+                       }
+               } else {
+                       if (!reshape_open_backup_file(backup_file, fd, devname,
+                                                     (signed)blocks,
+                                                     fdlist+d, offsets+d,
+                                                     restart)) {
+                               goto release;
+                       }
+                       d++;
                }
-               d++;
        }
 
        /* lastly, check that the internal stripe cache is
@@ -1919,7 +2186,7 @@ started:
 
        sra->new_chunk = info->new_chunk;
 
-       if (info->reshape_active)
+       if (restart)
                sra->reshape_progress = info->reshape_progress;
        else {
                sra->reshape_progress = 0;
@@ -1935,7 +2202,7 @@ started:
                /* use SET_ARRAY_INFO but only if reshape hasn't started */
                ioctl(fd, GET_ARRAY_INFO, &array);
                array.raid_disks = reshape.after.data_disks + reshape.parity;
-               if (!info->reshape_active &&
+               if (!restart &&
                    ioctl(fd, SET_ARRAY_INFO, &array) != 0) {
                        int err = errno;
 
@@ -1951,17 +2218,9 @@ started:
 
                        goto release;
                }
-       } else if (info->reshape_active && !st->ss->external) {
-               /* We don't need to set anything here for internal
-                * metadata, and for kernels before 2.6.38 we can
-                * fail if we try.
-                */
-       } else {
+       } else if (!restart) {
                /* set them all just in case some old 'new_*' value
                 * persists from some earlier problem.
-                * We even set them when restarting in the middle.  They will
-                * already be set in that case so this will be a no-op,
-                * but it is hard to tell the difference.
                 */
                int err = 0;
                if (sysfs_set_num(sra, NULL, "chunk_size", info->new_chunk) < 0)
@@ -1986,14 +2245,26 @@ started:
                }
        }
 
-       err = start_reshape(sra, (info->reshape_active && !st->ss->external));
+       err = start_reshape(sra, restart,
+                           info->array.raid_disks - reshape.parity);
        if (err) {
-               fprintf(stderr, Name ": Cannot start reshape for %s\n",
+               fprintf(stderr, 
+                       Name ": Cannot %s reshape for %s\n",
+                       restart ? "continue" : "start",
                        devname);
                goto release;
        }
        if (restart)
                sysfs_set_str(sra, NULL, "array_state", "active");
+       if (freeze_reshape) {
+               free(fdlist);
+               free(offsets);
+               sysfs_free(sra);
+               fprintf(stderr, Name ": Reshape has to be continued from"
+                       " location %llu when root fileststem has been mounted\n",
+                       sra->reshape_progress);
+               return 1;
+       }
 
        /* Now we just need to kick off the reshape and watch, while
         * handling backups of the data...
@@ -2008,6 +2279,7 @@ started:
        default:
                return 0;
        case 0:
+               map_fork();
                break;
        }
 
@@ -2107,6 +2379,8 @@ started:
                                        ": %s: could not set level "
                                        "to %s\n", devname, c);
                }
+               if (info->new_level == 0)
+                       st->update_tail = NULL;
        }
 out:
        if (forked)
@@ -2125,19 +2399,21 @@ release:
        return 1;
 }
 
-int reshape_container(char *container, int cfd, char *devname,
+int reshape_container(char *container, char *devname,
                      struct supertype *st, 
                      struct mdinfo *info,
                      int force,
                      char *backup_file,
-                     int quiet)
+                     int quiet, int restart, int freeze_reshape)
 {
        struct mdinfo *cc = NULL;
+       int rv = restart;
 
        /* component_size is not meaningful for a container,
         * so pass '-1' meaning 'no change'
         */
-       if (reshape_super(st, -1, info->new_level,
+       if (!restart &&
+           reshape_super(st, -1, info->new_level,
                          info->new_layout, info->new_chunk,
                          info->array.raid_disks, info->delta_disks,
                          backup_file, devname, quiet)) {
@@ -2157,9 +2433,12 @@ int reshape_container(char *container, int cfd, char *devname,
                unfreeze(st);
                return 1;
        default: /* parent */
-               printf(Name ": multi-array reshape continues in background\n");
+               if (!freeze_reshape)
+                       printf(Name ": multi-array reshape continues"
+                              " in background\n");
                return 0;
        case 0: /* child */
+               map_fork();
                break;
        }
 
@@ -2170,9 +2449,12 @@ int reshape_container(char *container, int cfd, char *devname,
                 * reshape it.  reshape_array() will re-read the metadata
                 * so the next time through a different array should be
                 * ready for reshape.
+                * It is possible that the 'different' array will not
+                * be assembled yet.  In that case we simple exit.
+                * When it is assembled, the mdadm which assembles it
+                * will take over the reshape.
                 */
                struct mdinfo *content;
-               int rv;
                int fd;
                struct mdstat_ent *mdstat;
                char *adev;
@@ -2208,13 +2490,22 @@ int reshape_container(char *container, int cfd, char *devname,
                sysfs_init(content, fd, mdstat->devnum);
 
                rv = reshape_array(container, fd, adev, st,
-                                  content, force,
-                                  backup_file, quiet, 1, 0);
+                                  content, force, NULL,
+                                  backup_file, quiet, 1, restart,
+                                  freeze_reshape);
                close(fd);
+
+               if (freeze_reshape) {
+                       sysfs_free(cc);
+                       exit(0);
+               }
+
+               restart = 0;
                if (rv)
                        break;
        }
-       unfreeze(st);
+       if (!rv)
+               unfreeze(st);
        sysfs_free(cc);
        exit(0);
 }
@@ -2292,8 +2583,8 @@ int progress_reshape(struct mdinfo *info, struct reshape *reshape,
         *   1 if more data from backup_point - but only as far as suspend_point,
         *     should be backed up
         *   0 if things are progressing smoothly
-        *  -1 if the reshape is finished, either because it is all done,
-        *     or due to an error.
+        *  -1 if the reshape is finished because it is all done,
+        *  -2 if the reshape is finished due to an error.
         */
 
        int advancing = (reshape->after.data_disks
@@ -2476,10 +2767,9 @@ int progress_reshape(struct mdinfo *info, struct reshape *reshape,
        if (fd < 0)
                goto check_progress;
 
-       if (sysfs_fd_get_ll(fd, &completed) < 0) {
-               close(fd);
+       if (sysfs_fd_get_ll(fd, &completed) < 0)
                goto check_progress;
-       }
+
        while (completed < max_progress && completed < wait_point) {
                /* Check that sync_action is still 'reshape' to avoid
                 * waiting forever on a dead array
@@ -2504,10 +2794,8 @@ int progress_reshape(struct mdinfo *info, struct reshape *reshape,
                FD_ZERO(&rfds);
                FD_SET(fd, &rfds);
                select(fd+1, NULL, NULL, &rfds, NULL);
-               if (sysfs_fd_get_ll(fd, &completed) < 0) {
-                       close(fd);
+               if (sysfs_fd_get_ll(fd, &completed) < 0)
                        goto check_progress;
-               }
        }
        /* Some kernels reset 'sync_completed' to zero,
         * we need to have real point we are in md
@@ -2540,13 +2828,43 @@ check_progress:
        /* if we couldn't read a number from sync_completed, then
         * either the reshape did complete, or it aborted.
         * We can tell which by checking for 'none' in reshape_position.
+        * If it did abort, then it might immediately restart if it
+        * it was just a device failure that leaves us degraded but
+        * functioning.
         */
        strcpy(buf, "hi");
        if (sysfs_get_str(info, NULL, "reshape_position", buf, sizeof(buf)) < 0
-           || strncmp(buf, "none", 4) != 0)
-               return -2; /* abort */
-       else {
+           || strncmp(buf, "none", 4) != 0) {
+               /* The abort might only be temporary.  Wait up to 10
+                * seconds for fd to contain a valid number again.
+                */
+               struct timeval tv;
+               int rv = -2;
+               tv.tv_sec = 10;
+               tv.tv_usec = 0;
+               while (fd >= 0 && rv < 0 && tv.tv_sec > 0) {
+                       fd_set rfds;
+                       FD_ZERO(&rfds);
+                       FD_SET(fd, &rfds);
+                       if (select(fd+1, NULL, NULL, &rfds, &tv) != 1)
+                               break;
+                       switch (sysfs_fd_get_ll(fd, &completed)) {
+                       case 0:
+                               /* all good again */
+                               rv = 1;
+                               break;
+                       case -2: /* read error - abort */
+                               tv.tv_sec = 0;
+                               break;
+                       }
+               }
+               if (fd >= 0)
+                       close(fd);
+               return rv; /* abort */
+       } else {
                /* Maybe racing with array shutdown - check state */
+               if (fd >= 0)
+                       close(fd);
                if (sysfs_get_str(info, NULL, "array_state", buf, sizeof(buf)) < 0
                    || strncmp(buf, "inactive", 8) == 0
                    || strncmp(buf, "clear",5) == 0)
@@ -2828,6 +3146,7 @@ int child_monitor(int afd, struct mdinfo *sra, struct reshape *reshape,
        int chunk = sra->array.chunk_size;
        struct mdinfo *sd;
        unsigned long stripes;
+       int uuid[4];
 
        /* set up the backup-super-block.  This requires the
         * uuid from the array.
@@ -2845,7 +3164,7 @@ int child_monitor(int afd, struct mdinfo *sra, struct reshape *reshape,
                        continue;
                ok = st->ss->load_super(st, devfd, NULL);
                close(devfd);
-               if (ok >= 0)
+               if (ok == 0)
                        break;
        }
        if (!sd) {
@@ -2855,7 +3174,8 @@ int child_monitor(int afd, struct mdinfo *sra, struct reshape *reshape,
 
        memset(&bsb, 0, 512);
        memcpy(bsb.magic, "md_backup_data-1", 16);
-       st->ss->uuid_from_super(st, (int*)&bsb.set_uuid);
+       st->ss->uuid_from_super(st, uuid);
+       memcpy(bsb.set_uuid, uuid, 16);
        bsb.mtime = __cpu_to_le64(time(0));
        bsb.devstart2 = blocks;
 
@@ -2912,19 +3232,23 @@ int child_monitor(int afd, struct mdinfo *sra, struct reshape *reshape,
 
                /* Clear any backup region that is before 'here' */
                if (increasing) {
-                       if (reshape_completed >= (__le64_to_cpu(bsb.arraystart) +
+                       if (__le64_to_cpu(bsb.length) > 0 &&
+                           reshape_completed >= (__le64_to_cpu(bsb.arraystart) +
                                                  __le64_to_cpu(bsb.length)))
                                forget_backup(dests, destfd,
                                              destoffsets, 0);
-                       if (reshape_completed >= (__le64_to_cpu(bsb.arraystart2) +
+                       if (__le64_to_cpu(bsb.length2) > 0 &&
+                           reshape_completed >= (__le64_to_cpu(bsb.arraystart2) +
                                                  __le64_to_cpu(bsb.length2)))
                                forget_backup(dests, destfd,
                                              destoffsets, 1);
                } else {
-                       if (reshape_completed <= (__le64_to_cpu(bsb.arraystart)))
+                       if (__le64_to_cpu(bsb.length) > 0 &&
+                           reshape_completed <= (__le64_to_cpu(bsb.arraystart)))
                                forget_backup(dests, destfd,
                                              destoffsets, 0);
-                       if (reshape_completed <= (__le64_to_cpu(bsb.arraystart2)))
+                       if (__le64_to_cpu(bsb.length2) > 0 &&
+                           reshape_completed <= (__le64_to_cpu(bsb.arraystart2)))
                                forget_backup(dests, destfd,
                                              destoffsets, 1);
                }
@@ -2934,6 +3258,11 @@ int child_monitor(int afd, struct mdinfo *sra, struct reshape *reshape,
                                done = 1;
                        break;
                }
+               if (rv == 0 && increasing && !st->ss->external) {
+                       /* No longer need to monitor this reshape */
+                       done = 1;
+                       break;
+               }
 
                while (rv) {
                        unsigned long long offset;
@@ -3005,9 +3334,6 @@ int Grow_restart(struct supertype *st, struct mdinfo *info, int *fdlist, int cnt
        unsigned long long  nstripe, ostripe;
        int ndata, odata;
 
-       if (info->new_level != info->array.level)
-               return 1; /* Cannot handle level changes (they are instantaneous) */
-
        odata = info->array.raid_disks - info->delta_disks - 1;
        if (info->array.level == 6) odata--; /* number of data disks */
        ndata = info->array.raid_disks - 1;
@@ -3190,7 +3516,7 @@ int Grow_restart(struct supertype *st, struct mdinfo *info, int *fdlist, int cnt
                                    info->new_layout,
                                    fd, __le64_to_cpu(bsb.devstart)*512,
                                    __le64_to_cpu(bsb.arraystart)*512,
-                                   __le64_to_cpu(bsb.length)*512)) {
+                                   __le64_to_cpu(bsb.length)*512, NULL)) {
                        /* didn't succeed, so giveup */
                        if (verbose)
                                fprintf(stderr, Name ": Error restoring backup from %s\n",
@@ -3207,7 +3533,7 @@ int Grow_restart(struct supertype *st, struct mdinfo *info, int *fdlist, int cnt
                                    fd, __le64_to_cpu(bsb.devstart)*512 +
                                    __le64_to_cpu(bsb.devstart2)*512,
                                    __le64_to_cpu(bsb.arraystart2)*512,
-                                   __le64_to_cpu(bsb.length2)*512)) {
+                                   __le64_to_cpu(bsb.length2)*512, NULL)) {
                        /* didn't succeed, so giveup */
                        if (verbose)
                                fprintf(stderr, Name ": Error restoring second backup from %s\n",
@@ -3311,13 +3637,193 @@ int Grow_restart(struct supertype *st, struct mdinfo *info, int *fdlist, int cnt
        return 1;
 }
 
-int Grow_continue(int mdfd, struct supertype *st, struct mdinfo *info,
-                 char *backup_file)
+int Grow_continue_command(char *devname, int fd,
+                         char *backup_file, int verbose)
 {
-       int err = sysfs_set_str(info, NULL, "array_state", "readonly");
-       if (err)
-               return err;
-       return reshape_array(NULL, mdfd, "array", st, info, 1, backup_file, 0, 0, 1);
+       int ret_val = 0;
+       struct supertype *st = NULL;
+       struct mdinfo *content = NULL;
+       struct mdinfo array;
+       char *subarray = NULL;
+       struct mdinfo *cc = NULL;
+       struct mdstat_ent *mdstat = NULL;
+       char buf[40];
+       int cfd = -1;
+       int fd2 = -1;
+       char *ep;
+       unsigned long long position;
+
+       dprintf("Grow continue from command line called for %s\n",
+               devname);
+
+       st = super_by_fd(fd, &subarray);
+       if (!st || !st->ss) {
+               fprintf(stderr,
+                       Name ": Unable to determine metadata format for %s\n",
+                       devname);
+               return 1;
+       }
+       dprintf("Grow continue is run for ");
+       if (st->ss->external == 0) {
+               dprintf("native array (%s)\n", devname);
+               if (ioctl(fd, GET_ARRAY_INFO, &array) < 0) {
+                       fprintf(stderr, Name ": %s is not an active md array -"
+                               " aborting\n", devname);
+                       ret_val = 1;
+                       goto Grow_continue_command_exit;
+               }
+               content = &array;
+               sysfs_init(content, fd, st->devnum);
+       } else {
+               int container_dev;
+
+               if (subarray) {
+                       dprintf("subarray (%s)\n", subarray);
+                       container_dev = st->container_dev;
+                       cfd = open_dev_excl(st->container_dev);
+               } else {
+                       container_dev = st->devnum;
+                       close(fd);
+                       cfd = open_dev_excl(st->devnum);
+                       dprintf("container (%i)\n", container_dev);
+                       fd = cfd;
+               }
+               if (cfd < 0) {
+                       fprintf(stderr, Name ": Unable to open container "
+                               "for %s\n", devname);
+                       ret_val = 1;
+                       goto Grow_continue_command_exit;
+               }
+               fmt_devname(buf, container_dev);
+
+               /* find in container array under reshape
+                */
+               ret_val = st->ss->load_container(st, cfd, NULL);
+               if (ret_val) {
+                       fprintf(stderr,
+                               Name ": Cannot read superblock for %s\n",
+                               devname);
+                       ret_val = 1;
+                       goto Grow_continue_command_exit;
+               }
+
+               cc = st->ss->container_content(st, NULL);
+               for (content = cc; content ; content = content->next) {
+                       char *array;
+
+                       if (content->reshape_active == 0)
+                               continue;
+
+                       array = strchr(content->text_version+1, '/')+1;
+                       mdstat = mdstat_by_subdev(array, container_dev);
+                       if (!mdstat)
+                               continue;
+                       break;
+               }
+               if (!content) {
+                       fprintf(stderr,
+                               Name ": Unable to determine reshaped "
+                               "array for %s\n", devname);
+                       ret_val = 1;
+                       goto Grow_continue_command_exit;
+               }
+               fd2 = open_dev(mdstat->devnum);
+               if (fd2 < 0) {
+                       fprintf(stderr, Name ": cannot open (md%i)\n",
+                               mdstat->devnum);
+                       ret_val = 1;
+                       goto Grow_continue_command_exit;
+               }
+
+               sysfs_init(content, fd2, mdstat->devnum);
+
+               /* start mdmon in case it is not running
+                */
+               if (!mdmon_running(container_dev))
+                       start_mdmon(container_dev);
+               ping_monitor(buf);
+
+               if (mdmon_running(container_dev))
+                       st->update_tail = &st->updates;
+               else {
+                       fprintf(stderr, Name ":  No mdmon found. "
+                               "Grow cannot continue.\n");
+                       ret_val = 1;
+                       goto Grow_continue_command_exit;
+               }
+       }
+
+       /* verify that array under reshape is started from
+        * correct position
+        */
+       ret_val = sysfs_get_str(content, NULL, "sync_max", buf, 40);
+       if (ret_val <= 0) {
+               fprintf(stderr, Name
+                       ": cannot open verify reshape progress for %s (%i)\n",
+                       content->sys_name, ret_val);
+               ret_val = 1;
+               goto Grow_continue_command_exit;
+       }
+       dprintf(Name ": Read sync_max sysfs entry is: %s\n", buf);
+       position = strtoull(buf, &ep, 0);
+       if (ep == buf || (*ep != 0 && *ep != '\n' && *ep != ' ')) {
+               fprintf(stderr, Name ": Fatal error: array reshape was"
+                       " not properly frozen\n");
+               ret_val = 1;
+               goto Grow_continue_command_exit;
+       }
+       position *= get_data_disks(map_name(pers, mdstat->level),
+                                  content->new_layout,
+                                  content->array.raid_disks);
+       if (position != content->reshape_progress) {
+               fprintf(stderr, Name ": Fatal error: array reshape was"
+                       " not properly frozen.\n");
+               ret_val = 1;
+               goto Grow_continue_command_exit;
+       }
+
+       /* continue reshape
+        */
+       ret_val = Grow_continue(fd, st, content, backup_file, 0);
+
+Grow_continue_command_exit:
+       if (fd2 > -1)
+               close(fd2);
+       if (cfd > -1)
+               close(cfd);
+       st->ss->free_super(st);
+       free_mdstat(mdstat);
+       sysfs_free(cc);
+       free(subarray);
+
+       return ret_val;
 }
 
+int Grow_continue(int mdfd, struct supertype *st, struct mdinfo *info,
+                 char *backup_file, int freeze_reshape)
+{
+       int ret_val = 2;
+
+       if (!info->reshape_active)
+               return ret_val;
+
+       if (st->ss->external) {
+               char container[40];
+               int cfd = open_dev(st->container_dev);
+
+               if (cfd < 0)
+                       return 1;
 
+               fmt_devname(container, st->container_dev);
+               st->ss->load_container(st, cfd, container);
+               close(cfd);
+               ret_val = reshape_container(container, NULL,
+                                           st, info, 0, backup_file,
+                                           0, 1, freeze_reshape);
+       } else
+               ret_val = reshape_array(NULL, mdfd, "array", st, info, 1,
+                                       NULL, backup_file, 0, 0, 1,
+                                       freeze_reshape);
+
+       return ret_val;
+}