]> git.ipfire.org Git - thirdparty/e2fsprogs.git/blobdiff - debugfs/debugfs.c
Fix gcc -Wall warnings
[thirdparty/e2fsprogs.git] / debugfs / debugfs.c
index eaba9b86d372168511eb796c13991b372c9ac490..190c4b7b26fef7e94392b49496d8cd2f5052ea70 100644 (file)
@@ -20,9 +20,6 @@
 extern int optind;
 extern char *optarg;
 #endif
-#ifdef HAVE_OPTRESET
-extern int optreset;           /* defined by BSD, but not others */
-#endif
 #ifdef HAVE_ERRNO_H
 #include <errno.h>
 #endif
@@ -36,6 +33,8 @@ extern int optreset;          /* defined by BSD, but not others */
 #include "uuid/uuid.h"
 #include "e2p/e2p.h"
 
+#include <ext2fs/ext2_ext_attr.h>
+
 #include "../version.h"
 
 extern ss_request_table debug_cmds;
@@ -44,9 +43,11 @@ ext2_filsys  current_fs = NULL;
 ext2_ino_t     root, cwd;
 
 static void open_filesystem(char *device, int open_flags, blk_t superblock,
-                           blk_t blocksize, int catastrophic)
+                           blk_t blocksize, int catastrophic, 
+                           char *data_filename)
 {
        int     retval;
+       io_channel data_io = 0;
 
        if (superblock != 0 && blocksize == 0) {
                com_err(device, 0, "if you specify the superblock, you must also specify the block size");
@@ -54,6 +55,21 @@ static void open_filesystem(char *device, int open_flags, blk_t superblock,
                return;
        }
 
+       if (data_filename) {
+               if ((open_flags & EXT2_FLAG_IMAGE_FILE) == 0) {
+                       com_err(device, 0, 
+                               "The -d option is only valid when reading an e2image file");
+                       current_fs = NULL;
+                       return;
+               }
+               retval = unix_io_manager->open(data_filename, 0, &data_io);
+               if (retval) {
+                       com_err(data_filename, 0, "while opening data source");
+                       current_fs = NULL;
+                       return;
+               }
+       }
+
        if (catastrophic && (open_flags & EXT2_FLAG_RW)) {
                com_err(device, 0,
                        "opening read-only because of catastrophic mode");
@@ -82,6 +98,16 @@ static void open_filesystem(char *device, int open_flags, blk_t superblock,
                        goto errout;
                }
        }
+
+       if (data_io) {
+               retval = ext2fs_set_data_io(current_fs, data_io);
+               if (retval) {
+                       com_err(device, retval, 
+                               "while setting data source");
+                       goto errout;
+               }
+       }
+
        root = cwd = EXT2_ROOT_INO;
        return;
 
@@ -94,18 +120,15 @@ errout:
 
 void do_open_filesys(int argc, char **argv)
 {
-       const char *usage = "Usage: open [-s superblock] [-b blocksize] [-c] [-w] <device>";
        int     c, err;
        int     catastrophic = 0;
        blk_t   superblock = 0;
        blk_t   blocksize = 0;
-       int open_flags = 0;
+       int     open_flags = EXT2_FLAG_SOFTSUPP_FEATURES;
+       char    *data_filename = 0;
        
-       optind = 0;
-#ifdef HAVE_OPTRESET
-       optreset = 1;           /* Makes BSD getopt happy */
-#endif
-       while ((c = getopt (argc, argv, "iwfcb:s:")) != EOF) {
+       reset_getopt();
+       while ((c = getopt (argc, argv, "iwfecb:s:d:")) != EOF) {
                switch (c) {
                case 'i':
                        open_flags |= EXT2_FLAG_IMAGE_FILE;
@@ -116,9 +139,15 @@ void do_open_filesys(int argc, char **argv)
                case 'f':
                        open_flags |= EXT2_FLAG_FORCE;
                        break;
+               case 'e':
+                       open_flags |= EXT2_FLAG_EXCLUSIVE;
+                       break;
                case 'c':
                        catastrophic = 1;
                        break;
+               case 'd':
+                       data_filename = optarg;
+                       break;
                case 'b':
                        blocksize = parse_ulong(optarg, argv[0],
                                                "block size", &err);
@@ -132,25 +161,30 @@ void do_open_filesys(int argc, char **argv)
                                return;
                        break;
                default:
-                       com_err(argv[0], 0, usage);
-                       return;
+                       goto print_usage;
                }
        }
        if (optind != argc-1) {
-               com_err(argv[0], 0, usage);
-               return;
+               goto print_usage;
        }
        if (check_fs_not_open(argv[0]))
                return;
        open_filesystem(argv[optind], open_flags,
-                       superblock, blocksize, catastrophic);
+                       superblock, blocksize, catastrophic, 
+                       data_filename);
+       return;
+
+print_usage:
+       fprintf(stderr, "%s: Usage: open [-s superblock] [-b blocksize] "
+               "[-c] [-w] <device>\n", argv[0]);
 }
 
 void do_lcd(int argc, char **argv)
 {
-       if (common_args_process(argc, argv, 2, 2, "lcd",
-                               "<native dir>", 0))
+       if (argc != 2) {
+               com_err(argv[0], 0, "Usage: %s %s", argv[0], "<native dir>");
                return;
+       }
 
        if (chdir(argv[1]) == -1) {
                com_err(argv[0], errno,
@@ -167,16 +201,16 @@ static void close_filesystem(NOARGS)
        if (current_fs->flags & EXT2_FLAG_IB_DIRTY) {
                retval = ext2fs_write_inode_bitmap(current_fs);
                if (retval)
-                       com_err("ext2fs_write_inode_bitmap", retval, "");
+                       com_err("ext2fs_write_inode_bitmap", retval, 0);
        }
        if (current_fs->flags & EXT2_FLAG_BB_DIRTY) {
                retval = ext2fs_write_block_bitmap(current_fs);
                if (retval)
-                       com_err("ext2fs_write_block_bitmap", retval, "");
+                       com_err("ext2fs_write_block_bitmap", retval, 0);
        }
        retval = ext2fs_close(current_fs);
        if (retval)
-               com_err("ext2fs_close", retval, "");
+               com_err("ext2fs_close", retval, 0);
        current_fs = NULL;
        return;
 }
@@ -233,48 +267,59 @@ static void print_features(struct ext2_super_block * s, FILE *f)
        fputs("\n", f);
 }
 
+static void print_bg_opts(struct ext2_group_desc *gdp, int mask,
+                         const char *str, int *first, FILE *f)
+{
+       if (gdp->bg_flags & mask) {
+               if (*first) {
+                       fputs("           [", f);
+                       *first = 0;
+               } else
+                       fputs(", ", f);
+               fputs(str, f);
+       }
+}
+
 void do_show_super_stats(int argc, char *argv[])
 {
-       int     i;
+       dgrp_t  i;
        FILE    *out;
        struct ext2_group_desc *gdp;
        int     c, header_only = 0;
-       const char *usage = "Usage: show_super [-h]";
+       int     numdirs = 0, first;
 
-       optind = 0;
-#ifdef HAVE_OPTRESET
-       optreset = 1;           /* Makes BSD getopt happy */
-#endif
+       reset_getopt();
        while ((c = getopt (argc, argv, "h")) != EOF) {
                switch (c) {
                case 'h':
                        header_only++;
                        break;
                default:
-                       com_err(argv[0], 0, usage);
-                       return;
+                       goto print_usage;
                }
        }
        if (optind != argc) {
-               com_err(argv[0], 0, usage);
-               return;
+               goto print_usage;
        }
        if (check_fs_open(argv[0]))
                return;
        out = open_pager();
 
        list_super2(current_fs->super, out);
-
+       for (i=0; i < current_fs->group_desc_count; i++)
+               numdirs += current_fs->group_desc[i].bg_used_dirs_count;
+       fprintf(out, "Directories:              %d\n", numdirs);
+       
        if (header_only) {
                close_pager(out);
                return;
        }
        
        gdp = &current_fs->group_desc[0];
-       for (i = 0; i < current_fs->group_desc_count; i++, gdp++)
-               fprintf(out, " Group %2d: block bitmap at %d, "
-                       "inode bitmap at %d, "
-                       "inode table at %d\n"
+       for (i = 0; i < current_fs->group_desc_count; i++, gdp++) {
+               fprintf(out, " Group %2d: block bitmap at %u, "
+                       "inode bitmap at %u, "
+                       "inode table at %u\n"
                        "           %d free %s, "
                        "%d free %s, "
                        "%d used %s\n",
@@ -287,10 +332,22 @@ void do_show_super_stats(int argc, char *argv[])
                        gdp->bg_used_dirs_count,
                        gdp->bg_used_dirs_count != 1 ? "directories"
                                : "directory");
+               first = 1;
+               print_bg_opts(gdp, EXT2_BG_INODE_UNINIT, "Inode not init",
+                             &first, out);
+               print_bg_opts(gdp, EXT2_BG_BLOCK_UNINIT, "Block not init",
+                             &first, out);
+               if (!first)
+                       fputs("]\n", out);
+       }
        close_pager(out);
+       return;
+print_usage:
+       fprintf(stderr, "%s: Usage: show_super [-h]\n", argv[0]);
 }
 
-void do_dirty_filesys(int argc, char **argv)
+void do_dirty_filesys(int argc EXT2FS_ATTR((unused)), 
+                     char **argv EXT2FS_ATTR((unused)))
 {
        if (check_fs_open(argv[0]))
                return;
@@ -321,16 +378,20 @@ static void finish_range(struct list_blocks_struct *lb)
        else
                fprintf(lb->f, ", ");
        if (lb->first_block == lb->last_block)
-               fprintf(lb->f, "(%lld):%d", lb->first_bcnt, lb->first_block);
+               fprintf(lb->f, "(%lld):%u",
+                       (long long)lb->first_bcnt, lb->first_block);
        else
-               fprintf(lb->f, "(%lld-%lld):%d-%d", lb->first_bcnt,
-                       lb->last_bcnt, lb->first_block, lb->last_block);
+               fprintf(lb->f, "(%lld-%lld):%u-%u",
+                       (long long)lb->first_bcnt, (long long)lb->last_bcnt,
+                       lb->first_block, lb->last_block);
        lb->first_block = 0;
 }
 
-static int list_blocks_proc(ext2_filsys fs, blk_t *blocknr,
-                           e2_blkcnt_t blockcnt, blk_t ref_block,
-                           int ref_offset, void *private)
+static int list_blocks_proc(ext2_filsys fs EXT2FS_ATTR((unused)), 
+                           blk_t *blocknr, e2_blkcnt_t blockcnt, 
+                           blk_t ref_block EXT2FS_ATTR((unused)),
+                           int ref_offset EXT2FS_ATTR((unused)), 
+                           void *private)
 {
        struct list_blocks_struct *lb = (struct list_blocks_struct *) private;
 
@@ -363,14 +424,79 @@ static int list_blocks_proc(ext2_filsys fs, blk_t *blocknr,
        else
                fprintf(lb->f, ", ");
        if (blockcnt == -1)
-               fprintf(lb->f, "(IND):%d", *blocknr);
+               fprintf(lb->f, "(IND):%u", *blocknr);
        else if (blockcnt == -2)
-               fprintf(lb->f, "(DIND):%d", *blocknr);
+               fprintf(lb->f, "(DIND):%u", *blocknr);
        else if (blockcnt == -3)
-               fprintf(lb->f, "(TIND):%d", *blocknr);
+               fprintf(lb->f, "(TIND):%u", *blocknr);
        return 0;
 }
 
+static void dump_xattr_string(FILE *out, const char *str, int len)
+{
+       int printable = 1;
+       int i;
+       
+       /* check is string printable? */
+       for (i = 0; i < len; i++)
+               if (!isprint(str[i])) {
+                       printable = 0;
+                       break;
+               }
+
+       for (i = 0; i < len; i++)
+               if (printable)
+                       fprintf(out, "%c", (unsigned char)str[i]);
+               else
+                       fprintf(out, "%02x ", (unsigned char)str[i]);
+}
+
+static void internal_dump_inode_extra(FILE *out, 
+                                     const char *prefix EXT2FS_ATTR((unused)),
+                                     ext2_ino_t inode_num EXT2FS_ATTR((unused)), 
+                                     struct ext2_inode_large *inode)
+{
+       struct ext2_ext_attr_entry *entry;
+       __u32 *magic;
+       char *start, *end;
+       unsigned int storage_size;
+
+       fprintf(out, "Size of extra inode fields: %u\n", inode->i_extra_isize);
+       if (inode->i_extra_isize > EXT2_INODE_SIZE(current_fs->super) -
+                       EXT2_GOOD_OLD_INODE_SIZE) {
+               fprintf(stderr, "invalid inode->i_extra_isize (%u)\n",
+                               inode->i_extra_isize);
+               return;
+       }
+       storage_size = EXT2_INODE_SIZE(current_fs->super) -
+                       EXT2_GOOD_OLD_INODE_SIZE -
+                       inode->i_extra_isize;
+       magic = (__u32 *)((char *)inode + EXT2_GOOD_OLD_INODE_SIZE +
+                       inode->i_extra_isize);
+       if (*magic == EXT2_EXT_ATTR_MAGIC) {
+               fprintf(out, "Extended attributes stored in inode body: \n");
+               end = (char *) inode + EXT2_INODE_SIZE(current_fs->super);
+               start = (char *) magic + sizeof(__u32);
+               entry = (struct ext2_ext_attr_entry *) start;
+               while (!EXT2_EXT_IS_LAST_ENTRY(entry)) {
+                       struct ext2_ext_attr_entry *next =
+                               EXT2_EXT_ATTR_NEXT(entry);
+                       if (entry->e_value_size > storage_size ||
+                                       (char *) next >= end) {
+                               fprintf(out, "invalid EA entry in inode\n");
+                               return;
+                       }
+                       fprintf(out, "  ");
+                       dump_xattr_string(out, EXT2_EXT_ATTR_NAME(entry), 
+                                         entry->e_name_len);
+                       fprintf(out, " = \"");
+                       dump_xattr_string(out, start + entry->e_value_offs,
+                                               entry->e_value_size);
+                       fprintf(out, "\" (%u)\n", entry->e_value_size);
+                       entry = next;
+               }
+       }
+}
 
 static void dump_blocks(FILE *f, const char *prefix, ext2_ino_t inode)
 {
@@ -385,7 +511,7 @@ static void dump_blocks(FILE *f, const char *prefix, ext2_ino_t inode)
                             list_blocks_proc, (void *)&lb);
        finish_range(&lb);
        if (lb.total)
-               fprintf(f, "\n%sTOTAL: %lld\n", prefix, lb.total);
+               fprintf(f, "\n%sTOTAL: %lld\n", prefix, (long long)lb.total);
        fprintf(f,"\n");
 }
 
@@ -411,15 +537,15 @@ void internal_dump_inode(FILE *out, const char *prefix,
                prefix, 
                inode->i_mode & 0777, inode->i_flags, inode->i_generation);
        fprintf(out, "%sUser: %5d   Group: %5d   Size: ",
-               prefix, inode->i_uid, inode->i_gid);
+               prefix, inode_uid(*inode), inode_gid(*inode));
        if (LINUX_S_ISREG(inode->i_mode)) {
-               __u64 i_size = (inode->i_size |
-                               ((unsigned long long)inode->i_size_high << 32));
+               unsigned long long i_size = (inode->i_size |
+                                   ((unsigned long long)inode->i_size_high << 32));
 
-               fprintf(out, "%lld\n", i_size);
+               fprintf(out, "%llu\n", i_size);
        } else
                fprintf(out, "%d\n", inode->i_size);
-       if (current_fs->super->s_creator_os == EXT2_OS_HURD)
+       if (os == EXT2_OS_HURD)
                fprintf(out,
                        "%sFile ACL: %d    Directory ACL: %d Translator: %d\n",
                        prefix,
@@ -429,13 +555,16 @@ void internal_dump_inode(FILE *out, const char *prefix,
                fprintf(out, "%sFile ACL: %d    Directory ACL: %d\n",
                        prefix,
                        inode->i_file_acl, LINUX_S_ISDIR(inode->i_mode) ? inode->i_dir_acl : 0);
-       fprintf(out, "%sLinks: %d   Blockcount: %d\n", 
-               prefix, inode->i_links_count, inode->i_blocks);
+       if (os == EXT2_OS_LINUX) 
+               fprintf(out, "%sLinks: %d   Blockcount: %llu\n",
+                       prefix, inode->i_links_count, 
+                       (((unsigned long long) 
+                         inode->osd2.linux2.l_i_blocks_hi << 32)) + 
+                       inode->i_blocks);
+       else
+               fprintf(out, "%sLinks: %d   Blockcount: %u\n",
+                       prefix, inode->i_links_count, inode->i_blocks);
        switch (os) {
-           case EXT2_OS_LINUX:
-               frag = inode->osd2.linux2.l_i_frag;
-               fsize = inode->osd2.linux2.l_i_fsize;
-               break;
            case EXT2_OS_HURD:
                frag = inode->osd2.hurd2.h_i_frag;
                fsize = inode->osd2.hurd2.h_i_fsize;
@@ -458,34 +587,70 @@ void internal_dump_inode(FILE *out, const char *prefix,
        if (inode->i_dtime) 
          fprintf(out, "%sdtime: 0x%08x -- %s", prefix, inode->i_dtime,
                  time_to_string(inode->i_dtime));
-       if (LINUX_S_ISLNK(inode->i_mode) && inode->i_blocks == 0)
+       if (EXT2_INODE_SIZE(current_fs->super) > EXT2_GOOD_OLD_INODE_SIZE)
+               internal_dump_inode_extra(out, prefix, inode_num,
+                                         (struct ext2_inode_large *) inode);
+       if (LINUX_S_ISLNK(inode->i_mode) && ext2fs_inode_data_blocks(current_fs,inode) == 0)
                fprintf(out, "%sFast_link_dest: %.*s\n", prefix,
                        (int) inode->i_size, (char *)inode->i_block);
+       else if (LINUX_S_ISBLK(inode->i_mode) || LINUX_S_ISCHR(inode->i_mode)) {
+               int major, minor;
+               const char *devnote;
+
+               if (inode->i_block[0]) {
+                       major = (inode->i_block[0] >> 8) & 255;
+                       minor = inode->i_block[0] & 255;
+                       devnote = "";
+               } else {
+                       major = (inode->i_block[1] & 0xfff00) >> 8;
+                       minor = ((inode->i_block[1] & 0xff) | 
+                                ((inode->i_block[1] >> 12) & 0xfff00));
+                       devnote = "(New-style) ";
+               }
+               fprintf(out, "%sDevice major/minor number: %02d:%02d (hex %02x:%02x)\n", 
+                       devnote, major, minor, major, minor);
+       }
        else if (do_dump_blocks)
                dump_blocks(out, prefix, inode_num);
 }
 
-static void dump_inode(ext2_ino_t inode_num, struct ext2_inode inode)
+static void dump_inode(ext2_ino_t inode_num, struct ext2_inode *inode)
 {
        FILE    *out;
        
        out = open_pager();
-       internal_dump_inode(out, "", inode_num, &inode, 1);
+       internal_dump_inode(out, "", inode_num, inode, 1);
        close_pager(out);
 }
 
 void do_stat(int argc, char *argv[])
 {
        ext2_ino_t      inode;
-       struct ext2_inode inode_buf;
+       struct ext2_inode inode_buf;
 
-       if (common_inode_args_process(argc, argv, &inode, 0))
+       if (check_fs_open(argv[0]))
                return;
 
-       if (debugfs_read_inode(inode, &inode_buf, argv[0]))
+       inode_buf = (struct ext2_inode *)
+                       malloc(EXT2_INODE_SIZE(current_fs->super));
+       if (!inode_buf) {
+               fprintf(stderr, "do_stat: can't allocate buffer\n");
+               return;
+       }
+
+       if (common_inode_args_process(argc, argv, &inode, 0)) {
+               free(inode_buf);
+               return;
+       }
+
+       if (debugfs_read_inode_full(inode, inode_buf, argv[0],
+                                       EXT2_INODE_SIZE(current_fs->super))) {
+               free(inode_buf);
                return;
+       }
 
-       dump_inode(inode,inode_buf);
+       dump_inode(inode, inode_buf);
+       free(inode_buf);
        return;
 }
 
@@ -499,7 +664,7 @@ void do_chroot(int argc, char *argv[])
 
        retval = ext2fs_check_directory(current_fs, inode);
        if (retval)  {
-               com_err(argv[1], retval, "");
+               com_err(argv[1], retval, 0);
                return;
        }
        root = inode;
@@ -564,7 +729,7 @@ void do_testi(int argc, char *argv[])
 void do_freeb(int argc, char *argv[])
 {
        blk_t block;
-       int count = 1;
+       blk_t count = 1;
 
        if (common_block_args_process(argc, argv, &block, &count))
                return;
@@ -572,7 +737,7 @@ void do_freeb(int argc, char *argv[])
                return;
        while (count-- > 0) {
                if (!ext2fs_test_block_bitmap(current_fs->block_map,block))
-                       com_err(argv[0], 0, "Warning: block %d already clear",
+                       com_err(argv[0], 0, "Warning: block %u already clear",
                                block);
                ext2fs_unmark_block_bitmap(current_fs->block_map,block);
                block++;
@@ -583,7 +748,7 @@ void do_freeb(int argc, char *argv[])
 void do_setb(int argc, char *argv[])
 {
        blk_t block;
-       int count = 1;
+       blk_t count = 1;
 
        if (common_block_args_process(argc, argv, &block, &count))
                return;
@@ -591,7 +756,7 @@ void do_setb(int argc, char *argv[])
                return;
        while (count-- > 0) {
                if (ext2fs_test_block_bitmap(current_fs->block_map,block))
-                       com_err(argv[0], 0, "Warning: block %d already set",
+                       com_err(argv[0], 0, "Warning: block %u already set",
                                block);
                ext2fs_mark_block_bitmap(current_fs->block_map,block);
                block++;
@@ -602,15 +767,15 @@ void do_setb(int argc, char *argv[])
 void do_testb(int argc, char *argv[])
 {
        blk_t block;
-       int count = 1;
+       blk_t count = 1;
 
        if (common_block_args_process(argc, argv, &block, &count))
                return;
        while (count-- > 0) {
                if (ext2fs_test_block_bitmap(current_fs->block_map,block))
-                       printf("Block %d marked in use\n", block);
+                       printf("Block %u marked in use\n", block);
                else
-                       printf("Block %d not in use\n", block);
+                       printf("Block %u not in use\n", block);
                block++;
        }
 }
@@ -690,6 +855,7 @@ void do_modify_inode(int argc, char *argv[])
        const char      *hex_format = "0x%x";
        const char      *octal_format = "0%o";
        const char      *decimal_format = "%d";
+       const char      *unsignedlong_format = "%lu";
        
        if (common_inode_args_process(argc, argv, &inode_num, CHECK_FS_RW))
                return;
@@ -702,13 +868,16 @@ void do_modify_inode(int argc, char *argv[])
        modify_u16(argv[0], "Mode", octal_format, &inode.i_mode);
        modify_u16(argv[0], "User ID", decimal_format, &inode.i_uid);
        modify_u16(argv[0], "Group ID", decimal_format, &inode.i_gid);
-       modify_u32(argv[0], "Size", decimal_format, &inode.i_size);
+       modify_u32(argv[0], "Size", unsignedlong_format, &inode.i_size);
        modify_u32(argv[0], "Creation time", decimal_format, &inode.i_ctime);
        modify_u32(argv[0], "Modification time", decimal_format, &inode.i_mtime);
        modify_u32(argv[0], "Access time", decimal_format, &inode.i_atime);
        modify_u32(argv[0], "Deletion time", decimal_format, &inode.i_dtime);
        modify_u16(argv[0], "Link count", decimal_format, &inode.i_links_count);
-       modify_u32(argv[0], "Block count", decimal_format, &inode.i_blocks);
+       if (os == EXT2_OS_LINUX)
+               modify_u16(argv[0], "Block count high", unsignedlong_format, 
+                          &inode.osd2.linux2.l_i_blocks_hi);
+       modify_u32(argv[0], "Block count", unsignedlong_format, &inode.i_blocks);
        modify_u32(argv[0], "File flags", hex_format, &inode.i_flags);
        modify_u32(argv[0], "Generation", hex_format, &inode.i_generation);
 #if 0
@@ -720,16 +889,12 @@ void do_modify_inode(int argc, char *argv[])
        else
                modify_u32(argv[0], "High 32bits of size", decimal_format, &inode.i_size_high);
 
-       if (current_fs->super->s_creator_os == EXT2_OS_HURD)
+       if (os == EXT2_OS_HURD)
                modify_u32(argv[0], "Translator Block",
                            decimal_format, &inode.osd1.hurd1.h_i_translator);
        
        modify_u32(argv[0], "Fragment address", decimal_format, &inode.i_faddr);
        switch (os) {
-           case EXT2_OS_LINUX:
-               frag = &inode.osd2.linux2.l_i_frag;
-               fsize = &inode.osd2.linux2.l_i_fsize;
-               break;
            case EXT2_OS_HURD:
                frag = &inode.osd2.hurd2.h_i_frag;
                fsize = &inode.osd2.hurd2.h_i_fsize;
@@ -770,7 +935,7 @@ void do_change_working_dir(int argc, char *argv[])
 
        retval = ext2fs_check_directory(current_fs, inode);
        if (retval) {
-               com_err(argv[1], retval, "");
+               com_err(argv[1], retval, 0);
                return;
        }
        cwd = inode;
@@ -791,42 +956,80 @@ void do_print_working_directory(int argc, char *argv[])
                com_err(argv[0], retval,
                        "while trying to get pathname of cwd");
        }
-       printf("[pwd]   INODE: %6u  PATH: %s\n", cwd, pathname);
-       free(pathname);
+       printf("[pwd]   INODE: %6u  PATH: %s\n",
+              cwd, pathname ? pathname : "NULL");
+        if (pathname) {
+               free(pathname);
+               pathname = NULL;
+        }
        retval = ext2fs_get_pathname(current_fs, root, 0, &pathname);
        if (retval) {
                com_err(argv[0], retval,
                        "while trying to get pathname of root");
        }
-       printf("[root]  INODE: %6u  PATH: %s\n", root, pathname);
-       free(pathname);
+       printf("[root]  INODE: %6u  PATH: %s\n",
+              root, pathname ? pathname : "NULL");
+       if (pathname) {
+               free(pathname);
+               pathname = NULL;
+       }
        return;
 }
 
+/*
+ * Given a mode, return the ext2 file type
+ */
+static int ext2_file_type(unsigned int mode)
+{
+       if (LINUX_S_ISREG(mode))
+               return EXT2_FT_REG_FILE;
+
+       if (LINUX_S_ISDIR(mode))
+               return EXT2_FT_DIR;
+       
+       if (LINUX_S_ISCHR(mode))
+               return EXT2_FT_CHRDEV;
+       
+       if (LINUX_S_ISBLK(mode))
+               return EXT2_FT_BLKDEV;
+       
+       if (LINUX_S_ISLNK(mode))
+               return EXT2_FT_SYMLINK;
+
+       if (LINUX_S_ISFIFO(mode))
+               return EXT2_FT_FIFO;
+       
+       if (LINUX_S_ISSOCK(mode))
+               return EXT2_FT_SOCK;
+       
+       return 0;
+}
+
 static void make_link(char *sourcename, char *destname)
 {
-       ext2_ino_t      inode;
+       ext2_ino_t      ino;
+       struct ext2_inode inode;
        int             retval;
        ext2_ino_t      dir;
-       char            *dest, *cp, *basename;
+       char            *dest, *cp, *base_name;
 
        /*
         * Get the source inode
         */
-       inode = string_to_inode(sourcename);
-       if (!inode)
+       ino = string_to_inode(sourcename);
+       if (!ino)
                return;
-       basename = strrchr(sourcename, '/');
-       if (basename)
-               basename++;
+       base_name = strrchr(sourcename, '/');
+       if (base_name)
+               base_name++;
        else
-               basename = sourcename;
+               base_name = sourcename;
        /*
         * Figure out the destination.  First see if it exists and is
         * a directory.  
         */
        if (! (retval=ext2fs_namei(current_fs, root, cwd, destname, &dir)))
-               dest = basename;
+               dest = base_name;
        else {
                /*
                 * OK, it doesn't exist.  See if it is
@@ -844,10 +1047,14 @@ static void make_link(char *sourcename, char *destname)
                        dest = destname;
                }
        }
+
+       if (debugfs_read_inode(ino, &inode, sourcename))
+               return;
        
-       retval = ext2fs_link(current_fs, dir, dest, inode, 0);
+       retval = ext2fs_link(current_fs, dir, dest, ino, 
+                            ext2_file_type(inode.i_mode));
        if (retval)
-               com_err("make_link", retval, "");
+               com_err("make_link", retval, 0);
        return;
 }
 
@@ -862,7 +1069,8 @@ void do_link(int argc, char *argv[])
 }
 
 static int mark_blocks_proc(ext2_filsys fs, blk_t *blocknr,
-                           int blockcnt, void *private)
+                           int blockcnt EXT2FS_ATTR((unused)), 
+                           void *private EXT2FS_ATTR((unused)))
 {
        blk_t   block;
 
@@ -915,21 +1123,21 @@ static void unlink_file_by_name(char *filename)
 {
        int             retval;
        ext2_ino_t      dir;
-       char            *basename;
+       char            *base_name;
        
-       basename = strrchr(filename, '/');
-       if (basename) {
-               *basename++ = '\0';
+       base_name = strrchr(filename, '/');
+       if (base_name) {
+               *base_name++ = '\0';
                dir = string_to_inode(filename);
                if (!dir)
                        return;
        } else {
                dir = cwd;
-               basename = filename;
+               base_name = filename;
        }
-       retval = ext2fs_unlink(current_fs, dir, basename, 0, 0);
+       retval = ext2fs_unlink(current_fs, dir, base_name, 0, 0);
        if (retval)
-               com_err("unlink_file_by_name", retval, "");
+               com_err("unlink_file_by_name", retval, 0);
        return;
 }
 
@@ -981,10 +1189,10 @@ void do_find_free_block(int argc, char *argv[])
                retval = ext2fs_new_block(current_fs, free_blk + 1, 0,
                                          &free_blk);
                if (retval) {
-                       com_err("ext2fs_new_block", retval, "");
+                       com_err("ext2fs_new_block", retval, 0);
                        return;
                } else
-                       printf("%d ", free_blk);
+                       printf("%u ", free_blk);
        }
        printf("\n");
 }
@@ -1023,7 +1231,7 @@ void do_find_free_inode(int argc, char *argv[])
 
        retval = ext2fs_new_inode(current_fs, dir, mode, 0, &free_inode);
        if (retval)
-               com_err("ext2fs_new_inode", retval, "");
+               com_err("ext2fs_new_inode", retval, 0);
        else
                printf("Free inode found: %u\n", free_inode);
 }
@@ -1084,26 +1292,42 @@ void do_write(int argc, char *argv[])
 
        fd = open(argv[1], O_RDONLY);
        if (fd < 0) {
-               com_err(argv[1], errno, "");
+               com_err(argv[1], errno, 0);
                return;
        }
        if (fstat(fd, &statbuf) < 0) {
-               com_err(argv[1], errno, "");
+               com_err(argv[1], errno, 0);
+               close(fd);
+               return;
+       }
+
+       retval = ext2fs_namei(current_fs, root, cwd, argv[2], &newfile);
+       if (retval == 0) {
+               com_err(argv[0], 0, "The file '%s' already exists\n", argv[2]);
                close(fd);
                return;
        }
 
        retval = ext2fs_new_inode(current_fs, cwd, 010755, 0, &newfile);
        if (retval) {
-               com_err(argv[0], retval, "");
+               com_err(argv[0], retval, 0);
                close(fd);
                return;
        }
        printf("Allocated inode: %u\n", newfile);
        retval = ext2fs_link(current_fs, cwd, argv[2], newfile,
                             EXT2_FT_REG_FILE);
+       if (retval == EXT2_ET_DIR_NO_SPACE) {
+               retval = ext2fs_expand_dir(current_fs, cwd);
+               if (retval) {
+                       com_err(argv[0], retval, "while expanding directory");
+                       return;
+               }
+               retval = ext2fs_link(current_fs, cwd, argv[2], newfile,
+                                    EXT2_FT_REG_FILE);
+       }
        if (retval) {
-               com_err(argv[2], retval, "");
+               com_err(argv[2], retval, 0);
                close(fd);
                return;
        }
@@ -1111,29 +1335,30 @@ void do_write(int argc, char *argv[])
                com_err(argv[0], 0, "Warning: inode already set");
        ext2fs_inode_alloc_stats2(current_fs, newfile, +1, 0);
        memset(&inode, 0, sizeof(inode));
-       inode.i_mode = statbuf.st_mode;
-       inode.i_atime = inode.i_ctime = inode.i_mtime = time(NULL);
+       inode.i_mode = (statbuf.st_mode & ~LINUX_S_IFMT) | LINUX_S_IFREG;
+       inode.i_atime = inode.i_ctime = inode.i_mtime = 
+               current_fs->now ? current_fs->now : time(0);
        inode.i_links_count = 1;
        inode.i_size = statbuf.st_size;
-       if (debugfs_write_inode(newfile, &inode, argv[0])) {
+       if (debugfs_write_new_inode(newfile, &inode, argv[0])) {
                close(fd);
                return;
        }
        if (LINUX_S_ISREG(inode.i_mode)) {
                retval = copy_file(fd, newfile);
                if (retval)
-                       com_err("copy_file", retval, "");
+                       com_err("copy_file", retval, 0);
        }
        close(fd);
 }
 
 void do_mknod(int argc, char *argv[])
 {
-       unsigned long   mode, major, minor, nr;
+       unsigned long   mode, major, minor;
        ext2_ino_t      newfile;
        errcode_t       retval;
        struct ext2_inode inode;
-       int             filetype;
+       int             filetype, nr;
 
        if (check_fs_open(argv[0]))
                return;
@@ -1166,7 +1391,7 @@ void do_mknod(int argc, char *argv[])
        if (nr == 5) {
                major = strtoul(argv[3], argv+3, 0);
                minor = strtoul(argv[4], argv+4, 0);
-               if (major > 255 || minor > 255 || argv[3][0] || argv[4][0])
+               if (major > 65535 || minor > 65535 || argv[3][0] || argv[4][0])
                        nr = 0;
        }
        if (argc != nr)
@@ -1175,23 +1400,23 @@ void do_mknod(int argc, char *argv[])
                return;
        retval = ext2fs_new_inode(current_fs, cwd, 010755, 0, &newfile);
        if (retval) {
-               com_err(argv[0], retval, "");
+               com_err(argv[0], retval, 0);
                return;
        }
        printf("Allocated inode: %u\n", newfile);
        retval = ext2fs_link(current_fs, cwd, argv[1], newfile, filetype);
-       if (retval) {
-               if (retval == EXT2_ET_DIR_NO_SPACE) {
-                       retval = ext2fs_expand_dir(current_fs, cwd);
-                       if (!retval)
-                               retval = ext2fs_link(current_fs, cwd,
-                                                    argv[1], newfile,
-                                                    filetype);
-               }
+       if (retval == EXT2_ET_DIR_NO_SPACE) {
+               retval = ext2fs_expand_dir(current_fs, cwd);
                if (retval) {
-                       com_err(argv[1], retval, "");
+                       com_err(argv[0], retval, "while expanding directory");
                        return;
                }
+               retval = ext2fs_link(current_fs, cwd, argv[1], newfile,
+                                    filetype);
+       }
+       if (retval) {
+               com_err(argv[1], retval, 0);
+               return;
        }
         if (ext2fs_test_inode_bitmap(current_fs->inode_map,newfile))
                com_err(argv[0], 0, "Warning: inode already set");
@@ -1199,10 +1424,17 @@ void do_mknod(int argc, char *argv[])
        ext2fs_mark_ib_dirty(current_fs);
        memset(&inode, 0, sizeof(inode));
        inode.i_mode = mode;
-       inode.i_atime = inode.i_ctime = inode.i_mtime = time(NULL);
-       inode.i_block[0] = major*256+minor;
+       inode.i_atime = inode.i_ctime = inode.i_mtime = 
+               current_fs->now ? current_fs->now : time(0);
+       if ((major < 256) && (minor < 256)) {
+               inode.i_block[0] = major*256+minor;
+               inode.i_block[1] = 0;
+       } else {
+               inode.i_block[0] = 0;
+               inode.i_block[1] = (minor & 0xff) | (major << 8) | ((minor & ~0xff) << 12);
+       }
        inode.i_links_count = 1;
-       if (debugfs_write_inode(newfile, &inode, argv[0]))
+       if (debugfs_write_new_inode(newfile, &inode, argv[0]))
                return;
 }
 
@@ -1222,7 +1454,7 @@ void do_mkdir(int argc, char *argv[])
                *cp = 0;
                parent = string_to_inode(argv[1]);
                if (!parent) {
-                       com_err(argv[1], ENOENT, "");
+                       com_err(argv[1], ENOENT, 0);
                        return;
                }
                name = cp+1;
@@ -1231,17 +1463,26 @@ void do_mkdir(int argc, char *argv[])
                name = argv[1];
        }
 
-
+try_again:
        retval = ext2fs_mkdir(current_fs, parent, 0, name);
+       if (retval == EXT2_ET_DIR_NO_SPACE) {
+               retval = ext2fs_expand_dir(current_fs, parent);
+               if (retval) {
+                       com_err("argv[0]", retval, "while expanding directory");
+                       return;
+               }
+               goto try_again;
+       }
        if (retval) {
-               com_err("ext2fs_mkdir", retval, "");
+               com_err("ext2fs_mkdir", retval, 0);
                return;
        }
 
 }
 
 static int release_blocks_proc(ext2_filsys fs, blk_t *blocknr,
-                              int blockcnt, void *private)
+                              int blockcnt EXT2FS_ATTR((unused)), 
+                              void *private EXT2FS_ATTR((unused)))
 {
        blk_t   block;
 
@@ -1256,9 +1497,11 @@ static void kill_file_by_inode(ext2_ino_t inode)
 
        if (debugfs_read_inode(inode, &inode_buf, 0))
                return;
-       inode_buf.i_dtime = time(NULL);
+       inode_buf.i_dtime = current_fs->now ? current_fs->now : time(0);
        if (debugfs_write_inode(inode, &inode_buf, 0))
                return;
+       if (!ext2fs_inode_has_valid_blocks(&inode_buf))
+               return;
 
        ext2fs_block_iterate(current_fs, inode, 0, NULL,
                             release_blocks_proc, NULL);
@@ -1316,12 +1559,12 @@ struct rd_struct {
        int             empty;
 };
 
-static int rmdir_proc(ext2_ino_t dir,
-                     int       entry,
+static int rmdir_proc(ext2_ino_t dir EXT2FS_ATTR((unused)),
+                     int       entry EXT2FS_ATTR((unused)),
                      struct ext2_dir_entry *dirent,
-                     int       offset,
-                     int       blocksize,
-                     char      *buf,
+                     int       offset EXT2FS_ATTR((unused)),
+                     int       blocksize EXT2FS_ATTR((unused)),
+                     char      *buf EXT2FS_ATTR((unused)),
                      void      *private)
 {
        struct rd_struct *rds = (struct rd_struct *) private;
@@ -1395,7 +1638,8 @@ void do_rmdir(int argc, char *argv[])
        }
 }
 
-void do_show_debugfs_params(int argc, char *argv[])
+void do_show_debugfs_params(int argc EXT2FS_ATTR((unused)), 
+                           char *argv[] EXT2FS_ATTR((unused)))
 {
        FILE *out = stdout;
 
@@ -1416,7 +1660,7 @@ void do_expand_dir(int argc, char *argv[])
 
        retval = ext2fs_expand_dir(current_fs, inode);
        if (retval)
-               com_err("ext2fs_expand_dir", retval, "");
+               com_err("ext2fs_expand_dir", retval, 0);
        return;
 }
 
@@ -1452,17 +1696,69 @@ void do_bmap(int argc, char *argv[])
                return;
 
        ino = string_to_inode(argv[1]);
+       if (!ino)
+               return;
        blk = parse_ulong(argv[2], argv[0], "logical_block", &err);
 
        errcode = ext2fs_bmap(current_fs, ino, 0, 0, 0, blk, &pblk);
        if (errcode) {
                com_err("argv[0]", errcode,
-                       "while mapping logical block %d\n", blk);
+                       "while mapping logical block %u\n", blk);
                return;
        }
-       printf("%d\n", pblk);
+       printf("%u\n", pblk);
 }
 
+void do_imap(int argc, char *argv[])
+{
+       ext2_ino_t      ino;
+       unsigned long   group, block, block_nr, offset;
+
+       if (common_args_process(argc, argv, 2, 2, argv[0],
+                               "<file>", 0))
+               return;
+       ino = string_to_inode(argv[1]);
+       if (!ino)
+               return;
+
+       group = (ino - 1) / EXT2_INODES_PER_GROUP(current_fs->super);
+       offset = ((ino - 1) % EXT2_INODES_PER_GROUP(current_fs->super)) *
+               EXT2_INODE_SIZE(current_fs->super);
+       block = offset >> EXT2_BLOCK_SIZE_BITS(current_fs->super);
+       if (!current_fs->group_desc[(unsigned)group].bg_inode_table) {
+               com_err(argv[0], 0, "Inode table for group %lu is missing\n",
+                       group);
+               return;
+       }
+       block_nr = current_fs->group_desc[(unsigned)group].bg_inode_table + 
+               block;
+       offset &= (EXT2_BLOCK_SIZE(current_fs->super) - 1);
+
+       printf("Inode %d is part of block group %lu\n"
+              "\tlocated at block %lu, offset 0x%04lx\n", ino, group,
+              block_nr, offset);
+
+}
+
+void do_set_current_time(int argc, char *argv[])
+{
+       time_t now;
+
+       if (common_args_process(argc, argv, 2, 2, argv[0],
+                               "<time>", 0))
+               return;
+
+       now = string_to_time(argv[1]);
+       if (now == ((time_t) -1)) {
+               com_err(argv[0], 0, "Couldn't parse argument as a time: %s\n",
+                       argv[1]);
+               return;
+
+       } else {
+               printf("Setting current time to %s\n", time_to_string(now));
+               current_fs->now = now;
+       }
+}
 
 static int source_file(const char *cmd_file, int sci_idx)
 {
@@ -1508,19 +1804,20 @@ int main(int argc, char **argv)
        int             sci_idx;
        const char      *usage = "Usage: debugfs [-b blocksize] [-s superblock] [-f cmd_file] [-R request] [-V] [[-w] [-c] device]";
        int             c;
-       int             open_flags = 0;
+       int             open_flags = EXT2_FLAG_SOFTSUPP_FEATURES;
        char            *request = 0;
        int             exit_status = 0;
        char            *cmd_file = 0;
        blk_t           superblock = 0;
        blk_t           blocksize = 0;
        int             catastrophic = 0;
+       char            *data_filename = 0;
        
-       initialize_ext2_error_table();
+       add_error_table(&et_ext2_error_table);
        fprintf (stderr, "debugfs %s (%s)\n", E2FSPROGS_VERSION,
                 E2FSPROGS_DATE);
 
-       while ((c = getopt (argc, argv, "iwcR:f:b:s:V")) != EOF) {
+       while ((c = getopt (argc, argv, "iwcR:f:b:s:Vd:")) != EOF) {
                switch (c) {
                case 'R':
                        request = optarg;
@@ -1528,6 +1825,9 @@ int main(int argc, char **argv)
                case 'f':
                        cmd_file = optarg;
                        break;
+               case 'd':
+                       data_filename = optarg;
+                       break;
                case 'i':
                        open_flags |= EXT2_FLAG_IMAGE_FILE;
                        break;
@@ -1557,7 +1857,8 @@ int main(int argc, char **argv)
        }
        if (optind < argc)
                open_filesystem(argv[optind], open_flags,
-                               superblock, blocksize, catastrophic);
+                               superblock, blocksize, catastrophic,
+                               data_filename);
        
        sci_idx = ss_create_invocation("debugfs", "0.0", (char *) NULL,
                                       &debug_cmds, &retval);
@@ -1565,6 +1866,7 @@ int main(int argc, char **argv)
                ss_perror(sci_idx, retval, "creating invocation");
                exit(1);
        }
+       ss_get_readline(sci_idx);
 
        (void) ss_add_request_table (sci_idx, &ss_std_requests, 1, &retval);
        if (retval) {
@@ -1587,5 +1889,6 @@ int main(int argc, char **argv)
        if (current_fs)
                close_filesystem();
        
+       remove_error_table(&et_ext2_error_table);
        return exit_status;
 }