]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blobdiff - gdb/ChangeLog
gdb: Fix sizeof for dynamic types other than arrays
[thirdparty/binutils-gdb.git] / gdb / ChangeLog
index ccec301bc1a10708d03872992e3e4c202d9616a4..6d5b24c1e11fbba04514e462d5f3295a32a9c86b 100644 (file)
@@ -1,3 +1,532 @@
+2018-07-30  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       * eval.c (evaluate_subexp_for_sizeof): Check for array type before
+       checking array bounds are defined.
+
+2018-07-30  Tom Tromey  <tom@tromey.com>
+
+       * nat/linux-osdata.c (pid_pgid_entry::operator<): Fix
+       irreflexivity violation.
+
+2018-07-30  Tom Tromey  <tom@tromey.com>
+
+       * cli/cli-decode.c (lookup_cmd): Remove lint code.
+       * value.c (unpack_long): Remove lint code.
+       * valops.c (value_ind): Remove lint code.
+       * valarith.c (value_x_binop, value_x_unop, value_equal)
+       (value_pos): Remove lint code.
+
+2018-07-28  Tom de Vries  <tdevries@suse.de>
+
+       * eval.c (evaluate_subexp_for_sizeof): Interpret size of dynamic type
+       with undefined upper bound as <optimized out>.
+
+2018-07-27  Sergio Durigan Junior  <sergiodj@redhat.com>
+
+       * gcore.in: Rename variable "name" to "prefix".  Expand
+       "usage" text.
+
+2018-07-14  Jon Turney  <jon.turney@dronecode.org.uk>
+
+       * windows-nat.c (windows_nat_target::create_inferior): Update to
+       call close() in global namespace.
+
+2018-07-26  Tom Tromey  <tom@tromey.com>
+
+       * dwarf-index-write.c (add_address_entry): Don't add objfile
+       offsets.
+       * dbxread.c (find_stab_function): Rename from
+       find_stab_function_addr.  Return a bound_minimal_symbol.
+       (read_dbx_symtab): Use raw_text_low, raw_text_high.
+       Don't add objfile offsets.
+       (end_psymtab): Use raw_text_low, raw_text_high,
+       MSYMBOL_VALUE_RAW_ADDRESS.
+       (read_ofile_symtab): Update.
+       (process_one_symbol): Update.
+       * dwarf2read.c (create_addrmap_from_index): Don't add objfile
+       offsets.
+       (dw2_relocate): Remove.
+       (dw2_find_pc_sect_symtab): Bias PC by the text offset before
+       searching addrmap.
+       (dwarf2_gdb_index_functions, dwarf2_debug_names_functions):
+       Update.
+       (process_psymtab_comp_unit_reader, add_partial_symbol)
+       (add_partial_subprogram, dwarf2_ranges_read): Update.
+       (load_partial_dies): Update.
+       (add_address_entry): Don't add objfile offsets.
+       (dwarf2_build_include_psymtabs): Update.
+       (create_addrmap_from_aranges): Don't add objfile offsets.
+       (dw2_find_pc_sect_compunit_symtab): Update.
+       * mdebugread.c (parse_symbol): Don't add objfile offsets.
+       (parse_lines): Remove 'pst' parameter, replace with 'textlow'.
+       Update.
+       (parse_partial_symbols): Don't add objfile offsets.  Use
+       raw_text_low, raw_text_high.  Update.
+       (handle_psymbol_enumerators, psymtab_to_symtab_1): Update.
+       * objfiles.c (objfile_relocate1): Don't relocate psymtabs_addrmap
+       or call 'relocate' quick function.  Clear psymbol_map.
+       * psympriv.h (struct partial_symbol) <address>: Add section
+       offset.
+       <set_unrelocated_address>: Rename from set_address.
+       <raw_text_low, raw_text_high>: New methods.
+       <text_low, text_high>: Add objfile parameter.
+       (add_psymbol_to_bcache): Add 'section' parameter.  Call
+       set_unrelocated_address.
+       * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
+       (find_pc_psymbol): Update.
+       (fixup_psymbol_section, relocate_psymtabs): Remove.
+       (dump_psymtab, psym_functions): Update.
+       (add_psymbol_to_bcache, add_psymbol_to_list): Add 'section'
+       parameter.
+       (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
+       (start_psymtab_common): Update.
+       * symfile-debug.c (debug_qf_relocate): Remove.
+       (debug_sym_quick_functions): Update.
+       * symfile.h (struct quick_symbol_functions) <relocate>: Remove.
+       * xcoffread.c (scan_xcoff_symtab): Don't add objfile offsets.
+       Update.
+
+2018-07-26  Tom Tromey  <tromey@redhat.com>
+
+       * dbxread.c (end_psymtab): Use text_high_valid and
+       text_low_valid.
+       * mdebugread.c (parse_partial_symbols): Use text_low_valid.
+       (psymtab_to_symtab_1): Use text_high_valid and text_low_valid.
+       * psympriv.h (struct partial_symtab) <m_text_low, m_text_high>:
+       Update comment.
+       <text_low_valid, text_high_valid>: New fields.
+       <set_text_low, set_text_high>: Update.
+       * xcoffread.c (scan_xcoff_symtab): Use text_low_valid.
+
+2018-07-26  Tom Tromey  <tom@tromey.com>
+
+       * dbxread.c (read_dbx_symtab, end_psymtab, read_ofile_symtab):
+       Update.
+       * dwarf2read.c (dwarf2_create_include_psymtab): Don't initialize
+       textlow and texthigh fields.
+       (process_psymtab_comp_unit_reader, dwarf2_build_include_psymtabs):
+       Update.
+       * mdebugread.c (parse_lines, parse_partial_symbols)
+       (psymtab_to_symtab_1): Update.
+       * psympriv.h (struct partial_symtab) <m_text_low, m_text_high>:
+       Rename fields.  Update comment.  Now private.
+       <text_low, text_high, set_text_low, set_text_high>: New methods.
+       * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
+       (find_pc_sect_psymbol, relocate_psymtabs, dump_psymtab)
+       (start_psymtab_common, maintenance_info_psymtabs)
+       (maintenance_check_psymtabs): Update.
+       * xcoffread.c (xcoff_end_psymtab): Don't initialize textlow and
+       texthigh fields.
+       (scan_xcoff_symtab): Update.
+
+2018-07-26  Tom Tromey  <tromey@redhat.com>
+
+       * psympriv.h (struct partial_symbol) <unrelocated_address,
+       address, set_address>: New methods.
+       * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymbol)
+       (fixup_psymbol_section, relocate_psymtabs): Update.
+       (print_partial_symbols): Add 'objfile' parameter.  Update.
+       (dump_psymtab, add_psymbol_to_bcache, psym_fill_psymbol_map):
+       Update.
+
+2018-07-26  Tom Tromey  <tom@tromey.com>
+
+       * dwarf-index-write.c (write_psymbols, debug_names::insert)
+       (debug_names::write_psymbols): Update.
+       * psympriv.h (struct partial_symbol): Derive from
+       general_symbol_info.
+       <obj_section>: New method.
+       (PSYMBOL_DOMAIN, PSYMBOL_CLASS): Remove.n
+       * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
+       (find_pc_sect_psymbol, fixup_psymbol_section)
+       (match_partial_symbol, lookup_partial_symbol, relocate_psymtabs)
+       (print_partial_symbols, recursively_search_psymtabs)
+       (compare_psymbols, psymbol_hash, psymbol_compare)
+       (add_psymbol_to_bcache, maintenance_check_psymtabs)
+       (psymbol_name_matches, psym_fill_psymbol_map): Update.
+
+2018-07-26  Tom Tromey  <tromey@redhat.com>
+
+       * dbxread.c (end_psymtab): Remove dead code.
+
+2018-07-26  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       * dwarf2-frame-tailcall.c (tailcall_frame_sniffer): Exit early if
+       DWARF unwinders are disabled.
+       * dwarf2-frame.c: Add dwarf2read.h include.
+       (dwarf2_frame_sniffer): Exit early if DWARF unwinders are
+       disabled.
+       (dwarf2_frame_unwinders_enabled_p): Define.
+       (show_dwarf_unwinders_enabled_p): New function.
+       (_initialize_dwarf2_frame): Register switch to control DWARF
+       unwinder use.
+       * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Declare.
+       * dwarf2read.c (set_dwarf_cmdlist): Remove static keyword.
+       (show_dwarf_cmdlist): Remove static keyword.
+       * dwarf2read.h (set_dwarf_cmdlist): Declare.
+       (show_dwarf_cmdlist): Declare.
+       * NEWS: Document new feature.
+
+2018-07-26  Tom de Vries  <tdevries@suse.de>
+
+       PR breakpoints/23366
+       * infcmd.c (info_program_command): Handle ptid == minus_one_ptid.
+
+2018-07-26  Tom de Vries  <tdevries@suse.de>
+
+       * dwarf2read.c (read_subrange_type): Warn if DW_AT_upper_bound or
+       DW_AT_count can't be translated to a dynamic prop.
+
+2018-07-25  Tom de Vries  <tdevries@suse.de>
+
+       * dwarf2loc.c (dwarf2_locexpr_baton_eval): Wrap ctx.eval call in
+       try/catch.
+
+2018-07-25  Jan Vrany  <jan.vrany@fit.cvut.cz>
+
+       * breakpoint.c (enable_disable_bp_num_loc): Notify observers.
+
+2018-07-25  Joel Brobecker  <brobecker@adacore.com>
+
+       * MAINTAINERS (Global Maintainers): Add Tom Tromey.
+
+2018-07-24  Keith Seitz  <keiths@redhat.comt
+
+       PR symtab/23010
+       * dwarf2read.c (dw2_add_symbol_to_list): New function.
+       (fixup_go_packaging, new_symbol): Use dw2_add_symbol_to_list
+       instead of add_symbol_to_list.
+       (read_file_scope): Call prepare_one_comp_unit before reading
+       any other DIEs.
+
+2018-07-24  Simon Marchi  <simon.marchi@ericsson.com>
+
+       * common/scoped_mmap.h (class scoped_mmap): Fix indentation.
+
+2018-07-24  Tom Tromey  <tom@tromey.com>
+
+       * utils.c (malloc, realloc, free): Don't declare.
+       * configure, config.in: Rebuild.
+       * configure.ac: Don't check for declarations of free, malloc, or
+       realloc.
+
+2018-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
+
+       * aarch64-linux-nat.c
+       (aarch64_linux_nat_target::stopped_data_address): Remove unused
+       variable.
+       * arm-linux-nat.c (fetch_regs): Likewise.
+       (store_regs): Likewise.
+       (fetch_vfp_regs): Likewise.
+       (store_vfp_regs): Likewise.
+       (arm_linux_nat_target::insert_hw_breakpoint): Likewise.
+       (arm_linux_nat_target::remove_hw_breakpoint): Likewise.
+       (arm_linux_nat_target::insert_watchpoint): Likewise.
+       (arm_linux_nat_target::remove_watchpoint): Likewise.
+       * mips-linux-nat.c (mips_linux_nat_target::insert_watchpoint):
+       Likewise.
+       * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_get_sveregs):
+       Likewise.
+       * ppc-linux-nat.c (fetch_register): Likewise.
+       (fetch_all_gp_regs): Likewise.
+       (fetch_ppc_registers): Likewise.
+       (store_all_gp_regs): Likewise.
+       (store_ppc_registers): Likewise.
+       (hwdebug_insert_point): Likewise.
+       (can_use_watchpoint_cond_accel): Likewise.
+       * remote-sim.c (gdb_os_write_stdout): Likewise.
+
+2018-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
+           Tom Tromey  <tom@tromey.com>
+
+       * warning.m4 (AM_GDB_WARNINGS): Add -Wunused-variable and special
+       test for it.
+       * configure: Rebuild.
+
+2018-07-22  Tom Tromey  <tom@tromey.com>
+
+       * regformats/regdat.sh: Define xmltarget_${name} inside
+       #ifndef IN_PROCESS_AGENT.
+
+2018-07-22  Tom Tromey  <tom@tromey.com>
+
+       * value.c (value_fetch_lazy_bitfield): Remove unused variable.
+
+2018-07-22  Tom Tromey  <tom@tromey.com>
+
+       * symfile.c (reread_symbols): Notify iter, not objfile.
+
+2018-07-22  Tom Tromey  <tom@tromey.com>
+
+       * ravenscar-thread.c (ravenscar_thread_target::store_registers):
+       Use arch_ops.
+       (ravenscar_thread_target::prepare_to_store): Likewise.
+
+2018-07-22  Tom Tromey  <tom@tromey.com>
+
+       * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Remove
+       unused variable.  Call value_fetch_lazy when needed.
+       * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
+       Remove unused variable.  Call value_fetch_lazy when needed.
+
+2018-07-22  Tom Tromey  <tom@tromey.com>
+
+       * m32c-tdep.c (mark_dma): Return void.
+       (make_regs): Remove unused declarations.
+
+2018-07-22  Tom Tromey  <tom@tromey.com>
+
+       * guile/scm-cmd.c (gdbscm_dont_repeat): Call
+       cmdscm_get_valid_command_smob_arg_unsafe for effect.
+       * guile/scm-block.c (gdbscm_make_block_syms_iter): Call
+       bkscm_get_valid_block_smob_arg_unsafe for effect.
+
+2018-07-22  Tom Tromey  <tom@tromey.com>
+
+       * bfin-tdep.c (bfin_push_dummy_call): Use arg_type, not
+       value_type.
+
+2018-07-22  Tom Tromey  <tom@tromey.com>
+
+       * windows-nat.c (saved_context): Conditionally define.
+       * remote.c (remote_target::remote_btrace_maybe_reopen):
+       Conditionally declare "warned".
+       * inflow.c (sigquit_ours): Conditionally define.
+       (new_tty): Move "tty" declaration inside #if.
+       * guile/guile.c (guile_datadir): Conditionally define.
+       * charset.c (set_be_le_names): Move some declarations inside #if.
+       * btrace.c (parse_xml_btrace): Move "errcode" declaration inside
+       #if.
+       (parse_xml_btrace_conf): Likewise.
+
+2018-07-22  Tom Tromey  <tom@tromey.com>
+
+       * spu-tdep.c (spu_get_overlay_table): Remove unused variable.
+
+2018-07-22  Tom Tromey  <tom@tromey.com>
+
+       * guile/scm-value.c (gdbscm_value_call): Remove unused variables.
+       * guile/scm-math.c (vlscm_unop_gdbthrow, vlscm_binop_gdbthrow)
+       (vlscm_convert_typed_value_from_scheme): Remove unused variable.
+       * buildsym-legacy.c (get_macro_table): Remove unused variable.
+       * stack.c (frame_apply_level_command): Remove unused variable.
+       * tic6x-tdep.c (tic6x_push_dummy_call): Remove unused variable.
+       * sparc64-tdep.c (adi_examine_command): Remove unused variable.
+       * rs6000-lynx178-tdep.c (rs6000_lynx178_push_dummy_call): Remove
+       unused variable.
+       * nios2-tdep.c (nios2_push_dummy_call): Remove unused variable.
+       * mep-tdep.c (mep_push_dummy_call): Remove unused variable.
+       * ada-lang.c (ada_lookup_symbol_list_worker): Remove unused
+       variable.
+       * amd64-tdep.c (amd64_supply_xsave): Remove unused variable.
+       * arm-tdep.c (arm_record_data_proc_misc_ld_str): Remove unused
+       variable.
+       * breakpoint.c (check_no_tracepoint_commands, update_watchpoint):
+       Remove unused variable.
+       * cli/cli-script.c (recurse_read_control_structure): Remove unused
+       variable.
+       * common/tdesc.c (print_xml_feature::visit): Remove unused
+       variable.
+       * compile/compile-object-load.c (store_regs): Remove unused
+       variables.
+       * complaints.c (clear_complaints): Remove unused variable.
+       * corelow.c (core_target_open): Remove unused variable.
+       * fbsd-tdep.c (fbsd_core_info_proc_status): Remove unused
+       variable.
+       * guile/scm-frame.c (gdbscm_frame_read_var): Remove unused
+       variable.
+       * guile/scm-symtab.c (stscm_print_sal_smob): Remove unused
+       variable.
+       * guile/scm-type.c (gdbscm_field_baseclass_p): Remove unused
+       variable.
+       * guile/scm-utils.c (gdbscm_parse_function_args): Remove unused
+       variable.
+       * hppa-tdep.c (hppa_stub_frame_unwind_cache): Remove unused
+       variable.
+       * ia64-tdep.c (examine_prologue): Remove unused variable.
+       * infcall.c (run_inferior_call): Remove unused variable.
+       * inferior.c (exit_inferior): Remove unused variable.
+       * infrun.c (infrun_thread_ptid_changed): Remove unused variable.
+       * linespec.c (decode_line_2): Remove unused variable.
+       * linux-nat.c (super_close): Remove.
+       * linux-tdep.c (linux_info_proc): Remove unused variable.
+       * mi/mi-main.c (mi_execute_command): Remove unused variable.
+       * microblaze-linux-tdep.c (microblaze_linux_sigtramp_cache):
+       Remove unused variable.
+       * parse.c (find_minsym_type_and_address): Remove unused variable.
+       * printcmd.c (info_symbol_command, printf_floating): Remove unused
+       variable.
+       * python/py-breakpoint.c (bppy_set_commands): Remove unused
+       variable.
+       * python/py-unwind.c (unwind_infopy_dealloc): Remove unused
+       variables.
+       * record-btrace.c (record_btrace_target::store_registers): Remove
+       unused variable.
+       (cmd_show_record_btrace_cpu): Remove unused variable.
+       * riscv-tdep.c (riscv_register_reggroup_p)
+       (riscv_push_dummy_call, riscv_return_value): Remove unused
+       variable.
+       * rust-exp.y (literal): Remove unused variable.
+       * rust-lang.c (rust_evaluate_subexp) <OP_RUST_ARARAY>: Remove
+       unused variable.
+       <STRUCTOP_ANONYMOUS>: Likewise.
+       * s390-linux-tdep.c (s390_linux_init_abi_31)
+       (s390_linux_init_abi_64): Remove unused variable.
+       * ser-ming2.c (ser_windows_read_prim, pipe_select_thread)
+       (file_select_thread, net_windows_open, _initialize_ser_windows):
+       Remove unused variables.
+       * symtab.c (find_pc_sect_line): Remove unused variable.
+       * target-memory.c (compute_garbled_blocks): Remove unused
+       variable.
+       (target_write_memory_blocks): Remove unused variable.
+       * target.c (target_stack::unpush): Remove unused variables.
+       * tracepoint.c (start_tracing, all_tracepoint_actions)
+       (merge_uploaded_trace_state_variables)
+       (print_one_static_tracepoint_marker): Remove unused variable.
+       * unittests/basic_string_view/element_access/char/1.cc (test01):
+       Remove unused variable.
+       * windows-nat.c (windows_continue, windows_add_all_dlls)
+       (do_initial_windows_stuff, windows_nat_target::create_inferior):
+       Remove unused variables.
+
+2018-07-21  Simon Marchi  <simon.marchi@polymtl.ca>
+
+       * arm-tdep.c (arm_gdbarch_init): Declare attr_arch and
+       attr_profile in HAVE_ELF.
+       * rs6000-tdep.c (bfd_uses_spe_extensions): Declare vector_abi in
+       HAVE_ELF.
+
+2018-07-20  Simon Marchi  <simon.marchi@polymtl.ca>
+
+       * frame.c (frame_register_unwind): Change parameter name.
+       (frame_unwind_register): Likewise.
+       (frame_unwind_register_value): Likewise.
+       (frame_unwind_register_signed): Likewise.
+       (frame_unwind_register_unsigned): Likewise.
+       * frame.h (frame_register_unwind): Likewise.
+       (frame_unwind_register): Likewise.
+       (frame_unwind_register_value): Likewise.
+       (frame_unwind_register_signed): Likewise.
+       (frame_unwind_register_unsigned): Likewise.
+       (frame_unwind_arch): Likewise.
+
+2018-07-20  Maciej W. Rozycki  <macro@mips.com>
+
+       * MAINTAINERS: Update my e-mail address, downgrade to MIPS I-IV
+       ISA maintenance.
+
+2018-07-20  Maciej W. Rozycki  <macro@mips.com>
+
+       * mips-linux-nat.c (mips_linux_nat_target::read_description):
+       Call `get_ptrace_pid' rather than extracting the ptrace PID by
+       hand.
+
+2018-07-20  Keith Seitz  <keiths@redhat.com>
+
+       * buildsym.h (struct buildsym_compunit) <m_objfile, m_subfiles,
+       m_main_subfile, m_comp_dir, m_producer, m_debugformat,
+       m_compunit_symtab, m_language>: Add "m_" prefix.
+       Update all uses.
+       * buildsym.c: Update all uses.
+
+2018-07-20  Tom Tromey  <tom@tromey.com>
+
+       * buildsym-legacy.h (record_line): Don't use record_line_ftype.
+       * buildsym.h (record_line_ftype): Remove typedef.
+
+2018-07-20  Tom Tromey  <tom@tromey.com>
+
+       * buildsym-legacy.h (augment_type_symtab): Don't declare.
+       (end_expandable_symtab): Likewise.
+       (end_symtab_get_static_block): Likewise.
+       (end_symtab_from_static_block): Likewise.
+       * buildsym-legacy.c (augment_type_symtab): Remove.
+       (end_expandable_symtab): Remove.
+       (end_symtab_get_static_block): Remove.
+       (end_symtab_from_static_block): Remove.
+
+2018-07-20  Tom Tromey  <tom@tromey.com>
+
+       * dwarf2read.c: Include buildsym.h.
+       (struct dwarf2_cu) <builder>: New method.
+       (fixup_go_packaging): Update.
+       (process_full_comp_unit, process_full_type_unit): Update.  Don't
+       use scoped_free_pendings.
+       (using_directives): Add "cu" parameter, remove "language".
+       (read_import_statement, setup_type_unit_groups, )
+       (read_func_scope, read_lexical_block_scope)
+       (dwarf2_record_block_ranges, read_namespace): Update.
+       (lnp_state_machine::lnp_state_machine): Add cu parameter.
+       (lnp_state_machine::handle_end_sequence): Update.
+       (class lnp_state_machine) <m_cu>: New member.
+       <m_record_line_callback>: Remove.
+       <m_currently_recording_lines>: New member.
+       (lnp_state_machine::handle_set_file): Update.
+       (noop_record_line): Remove.
+       (dwarf_record_line_p): Add cu parameter.
+       (dwarf_record_line_1, dwarf_finish_line): Likewise.
+       (lnp_state_machine::record_line)
+       (lnp_state_machine::lnp_state_machine)
+       (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
+       (dwarf_decode_lines): Update.
+       (dwarf2_start_subfile): Add cu parameter.
+       (dwarf2_start_symtab, new_symbol): Update.
+       (macro_start_file, dwarf_decode_macro_bytes): Add cu parameter.
+       Remove dwarf2_per_objfile parameter.
+       (dwarf_decode_macros): Update.
+
+2018-07-20  Tom Tromey  <tom@tromey.com>
+
+       * stabsread.c (define_symbol): Update.
+       * buildsym-legacy.h (get_buildsym_compunit): Declare.
+       * dwarf2read.c (new_symbol): Update.
+       * cp-support.h (cp_scan_for_anonymous_namespaces): Update.
+       * cp-namespace.c: Include buildsym.h.
+       (cp_scan_for_anonymous_namespaces): Add "compunit" parameter.
+       * buildsym-legacy.c (get_buildsym_compunit): New function.
+
+2018-07-20  Tom Tromey  <tom@tromey.com>
+
+       * xcoffread.c: Include buildsym-legacy.h.
+       * windows-nat.c: Include buildsym-legacy.h.
+       * stabsread.c: Include buildsym-legacy.h.
+       * mdebugread.c: Include buildsym-legacy.h.
+       * buildsym-legacy.h: New file.
+       * buildsym-legacy.c: New file, from buildsym.c.
+       * go32-nat.c: Include buildsym-legacy.h.
+       * dwarf2read.c: Include buildsym-legacy.h.
+       * dbxread.c: Include buildsym-legacy.h.
+       * cp-namespace.c: Include buildsym-legacy.h.
+       * coffread.c: Include buildsym-legacy.h.
+       * buildsym.h: Move some contents to buildsym-legacy.h.
+       * buildsym.c: Include buildsym-legacy.h.  Move many functions to
+       buildsym-legacy.c.
+       * Makefile.in (HFILES_NO_SRCDIR): Add buildsym-legacy.h.
+
+2018-07-20  Tom Tromey  <tom@tromey.com>
+
+       * buildsym.h (struct buildsym_compunit): Move from buildsym.c.
+       * buildsym.c (struct buildsym_compunit): Move to buildsym.h.
+       (buildsym_compunit::buildsym_compunit)
+       (buildsym_compunit::~buildsym_compunit)
+       (buildsym_compunit::get_macro_table): Define.
+
+2018-07-20  Tom Tromey  <tom@tromey.com>
+
+       * buildsym.c (reset_symtab_globals): Remove.
+       (buildsym_compunit::end_symtab_from_static_block): Update.
+       (buildsym_compunit::augment_type_symtab): Update.
+       (end_symtab_from_static_block): Call free_buildsym_compunit.
+       (augment_type_symtab, end_symtab, end_expandable_symtab):
+       Likewise.
+
+2018-07-20  Tom Tromey  <tom@tromey.com>
+
+       * arch-utils.c: Do not include buildsym.h.
+       * mipsread.c: Do not include buildsym.h.
+       * machoread.c: Do not include buildsym.h.
+       * elfread.c: Do not include buildsym.h.
+
 2018-07-20  Tom Tromey  <tom@tromey.com>
 
        * buildsym.c (buildsym_compunit::buildsym_compunit): Do more