]> git.ipfire.org Git - thirdparty/mdadm.git/blobdiff - mapfile.c
mapfile - Fix off-by-one error in RebuildMap
[thirdparty/mdadm.git] / mapfile.c
index 89836cf1c6e57fb0d78bc43363fe7ed9bbf34940..112d3854c225181bafec17a619161d00b6f7ba54 100644 (file)
--- a/mapfile.c
+++ b/mapfile.c
@@ -2,7 +2,7 @@
  * mapfile - manage /var/run/mdadm.map. Part of:
  * mdadm - manage Linux "md" devices aka RAID arrays.
  *
- * Copyright (C) 2006 Neil Brown <neilb@suse.de>
+ * Copyright (C) 2006-2009 Neil Brown <neilb@suse.de>
  *
  *
  *    This program is free software; you can redistribute it and/or modify
  *  UUID       -  uuid of the array
  *  path       -  path where device created: /dev/md/home
  *
+ * The preferred location for the map file is /var/run/mdadm.map.
+ * However /var/run may not exist or be writable in early boot.  And if
+ * no-one has created /var/run/mdadm, we still want to survive.
+ * So possible locations are:
+ *   /var/run/mdadm/map  /var/run/mdadm.map  /dev/.mdadm.map
+ * the last, because udev requires a writable /dev very early.
+ * We read from the first one that exists and write to the first
+ * one that we can.
  */
+#include "mdadm.h"
 
+#define mapnames(base) { #base, #base ".new", #base ".lock"}
+char *mapname[3][3] = {
+       mapnames(/var/run/mdadm/map),
+       mapnames(/var/run/mdadm.map),
+       mapnames(/dev/.mdadm.map)
+};
 
-#include "mdadm.h"
+int mapmode[3] = { O_RDONLY, O_RDWR|O_CREAT, O_RDWR|O_CREAT | O_TRUNC };
+char *mapsmode[3] = { "r", "w", "w"};
 
+FILE *open_map(int modenum, int *choice)
+{
+       int i;
+       for (i = 0 ; i < 3 ; i++) {
+               int fd = open(mapname[i][modenum], mapmode[modenum], 0600);
+               if (fd >= 0) {
+                       *choice = i;
+                       return fdopen(fd, mapsmode[modenum]);
+               }
+       }
+       return NULL;
+}
 
 int map_write(struct map_ent *mel)
 {
        FILE *f;
        int err;
-       int subdir = 1;
+       int which;
+
+       f = open_map(1, &which);
 
-       f = fopen("/var/run/mdadm/map.new", "w");
-       if (!f) {
-               f = fopen("/var/run/mdadm.map.new", "w");
-               subdir = 0;
-       }
        if (!f)
                return 0;
        for (; mel; mel = mel->next) {
@@ -67,43 +92,31 @@ int map_write(struct map_ent *mel)
                fprintf(f, "%s ", mel->metadata);
                fprintf(f, "%08x:%08x:%08x:%08x ", mel->uuid[0],
                        mel->uuid[1], mel->uuid[2], mel->uuid[3]);
-               fprintf(f, "%s\n", mel->path);
+               fprintf(f, "%s\n", mel->path?:"");
        }
        fflush(f);
        err = ferror(f);
        fclose(f);
        if (err) {
-               if (subdir)
-                       unlink("/var/run/mdadm/map.new");
-               else
-                       unlink("/var/run/mdadm.map.new");
+               unlink(mapname[which][1]);
                return 0;
        }
-       if (subdir)
-               return rename("/var/run/mdadm/map.new",
-                             "/var/run/mdadm/map") == 0;
-       else
-               return rename("/var/run/mdadm.map.new",
-                             "/var/run/mdadm.map") == 0;
+       return rename(mapname[which][1],
+                     mapname[which][0]) == 0;
 }
 
 
-static int lfd = -1;
-static int lsubdir = 0;
+static FILE *lf = NULL;
+static int lwhich = 0;
 int map_lock(struct map_ent **melp)
 {
-       if (lfd < 0) {
-               lfd = open("/var/run/mdadm/map.lock", O_CREAT|O_RDWR, 0600);
-               if (lfd < 0) {
-                       lfd = open("/var/run/mdadm.map.lock", O_CREAT|O_RDWR, 0600);
-                       lsubdir = 0;
-               } else
-                       lsubdir = 1;
-               if (lfd < 0)
+       if (lf == NULL) {
+               lf = open_map(2, &lwhich);
+               if (lf == NULL)
                        return -1;
-               if (lockf(lfd, F_LOCK, 0) != 0) {
-                       close(lfd);
-                       lfd = -1;
+               if (lockf(fileno(lf), F_LOCK, 0) != 0) {
+                       fclose(lf);
+                       lf = NULL;
                        return -1;
                }
        }
@@ -115,13 +128,10 @@ int map_lock(struct map_ent **melp)
 
 void map_unlock(struct map_ent **melp)
 {
-       if (lfd >= 0)
-               close(lfd);
-       if (lsubdir)
-               unlink("/var/run/mdadm/map.lock");
-       else
-               unlink("/var/run/mdadm.map.lock");
-       lfd = -1;
+       if (lf)
+               fclose(lf);
+       unlink(mapname[lwhich][2]);
+       lf = NULL;
 }
 
 void map_add(struct map_ent **melp,
@@ -132,7 +142,7 @@ void map_add(struct map_ent **melp,
        me->devnum = devnum;
        strcpy(me->metadata, metadata);
        memcpy(me->uuid, uuid, 16);
-       me->path = strdup(path);
+       me->path = path ? strdup(path) : NULL;
        me->next = *melp;
        me->bad = 0;
        *melp = me;
@@ -146,19 +156,23 @@ void map_read(struct map_ent **melp)
        int devnum, uuid[4];
        char metadata[30];
        char nam[4];
+       int which;
 
        *melp = NULL;
 
-       f = fopen("/var/run/mdadm/map", "r");
-       if (!f)
-               f = fopen("/var/run/mdadm.map", "r");
+       f = open_map(0, &which);
+       if (!f) {
+               RebuildMap();
+               f = open_map(0, &which);
+       }
        if (!f)
                return;
 
        while (fgets(buf, sizeof(buf), f)) {
+               path[0] = 0;
                if (sscanf(buf, " %3[mdp]%d %s %x:%x:%x:%x %200s",
                           nam, &devnum, metadata, uuid, uuid+1,
-                          uuid+2, uuid+3, path) == 8) {
+                          uuid+2, uuid+3, path) >= 7) {
                        if (strncmp(nam, "md", 2) != 0)
                                continue;
                        if (nam[2] == 'p')
@@ -195,7 +209,7 @@ int map_update(struct map_ent **mpp, int devnum, char *metadata,
                        strcpy(mp->metadata, metadata);
                        memcpy(mp->uuid, uuid, 16);
                        free(mp->path);
-                       mp->path = strdup(path);
+                       mp->path = path ? strdup(path) : NULL;
                        break;
                }
        if (!mp)
@@ -267,6 +281,8 @@ struct map_ent *map_by_name(struct map_ent **map, char *name)
                map_read(map);
 
        for (mp = *map ; mp ; mp = mp->next) {
+               if (!mp->path)
+                       continue;
                if (strncmp(mp->path, "/dev/md/", 8) != 0)
                        continue;
                if (strcmp(mp->path+8, name) != 0)
@@ -279,3 +295,60 @@ struct map_ent *map_by_name(struct map_ent **map, char *name)
        }
        return NULL;
 }
+
+void RebuildMap(void)
+{
+       struct mdstat_ent *mdstat = mdstat_read(0, 0);
+       struct mdstat_ent *md;
+       struct map_ent *map = NULL;
+       int mdp = get_mdp_major();
+
+       for (md = mdstat ; md ; md = md->next) {
+               struct mdinfo *sra = sysfs_read(-1, md->devnum, GET_DEVS|SKIP_GONE_DEVS);
+               struct mdinfo *sd;
+
+               if (!sra)
+                       continue;
+
+               for (sd = sra->devs ; sd ; sd = sd->next) {
+                       char dn[30];
+                       int dfd;
+                       int ok;
+                       struct supertype *st;
+                       char *path;
+                       struct mdinfo info;
+
+                       sprintf(dn, "%d:%d", sd->disk.major, sd->disk.minor);
+                       dfd = dev_open(dn, O_RDONLY);
+                       if (dfd < 0)
+                               continue;
+                       st = guess_super(dfd);
+                       if ( st == NULL)
+                               ok = -1;
+                       else
+                               ok = st->ss->load_super(st, dfd, NULL);
+                       close(dfd);
+                       if (ok != 0)
+                               continue;
+                       st->ss->getinfo_super(st, &info);
+                       if (md->devnum >= 0)
+                               path = map_dev(MD_MAJOR, md->devnum, 0);
+                       else
+                               path = map_dev(mdp, (-1-md->devnum)<< 6, 0);
+                       map_add(&map, md->devnum,
+                               info.text_version,
+                               info.uuid, path);
+                       st->ss->free_super(st);
+                       break;
+               }
+               sysfs_free(sra);
+       }
+       map_write(map);
+       map_free(map);
+       for (md = mdstat ; md ; md = md->next) {
+               struct mdinfo *sra = sysfs_read(-1, md->devnum, GET_VERSION);
+               sysfs_uevent(sra, "change");
+               sysfs_free(sra);
+       }
+       free_mdstat(mdstat);
+}