]> git.ipfire.org Git - thirdparty/e2fsprogs.git/blobdiff - misc/tune2fs.c
Merge branch 'maint' into next
[thirdparty/e2fsprogs.git] / misc / tune2fs.c
index 7d6520e51d2bf985c82d698e441d8a239af4d726..601a6c85efb3e2d111d1673e5bc3ff369c235e5c 100644 (file)
@@ -26,7 +26,6 @@
  */
 
 #define _XOPEN_SOURCE 600 /* for inclusion of strptime() */
-#define _BSD_SOURCE /* for inclusion of strcasecmp() */
 #include "config.h"
 #include <fcntl.h>
 #include <grp.h>
@@ -41,6 +40,11 @@ extern int optind;
 #ifdef HAVE_STDLIB_H
 #include <stdlib.h>
 #endif
+#ifdef HAVE_STRINGS_H
+#include <strings.h>   /* for strcasecmp() */
+#else
+#define _BSD_SOURCE    /* for inclusion of strcasecmp() via <string.h> */
+#endif
 #include <string.h>
 #include <time.h>
 #include <unistd.h>
@@ -56,7 +60,7 @@ extern int optind;
 #include "jfs_user.h"
 #include "util.h"
 #include "blkid/blkid.h"
-#include "quota/mkquota.h"
+#include "quota/quotaio.h"
 
 #include "../version.h"
 #include "nls-enable.h"
@@ -95,6 +99,7 @@ static int rewrite_checksums;
 
 int journal_size, journal_flags;
 char *journal_device;
+static blk64_t journal_location = ~0LL;
 
 static struct list_head blk_move_list;
 
@@ -124,6 +129,9 @@ static void usage(void)
                  "\t[-r reserved_blocks_count] [-u user] [-C mount_count] "
                  "[-L volume_label]\n"
                  "\t[-M last_mounted_dir] [-O [^]feature[,...]]\n"
+#ifdef CONFIG_QUOTA
+                 "\t[-Q quota_options]\n"
+#endif
                  "\t[-E extended-option[,...]] [-T last_check_time] "
                  "[-U UUID]\n\t[ -I new_inode_size ] device\n"), program_name);
        exit(1);
@@ -210,7 +218,7 @@ static int remove_journal_device(ext2_filsys fs)
                             EXT2_FLAG_JOURNAL_DEV_OK, 0,
                             fs->blocksize, io_ptr, &jfs);
        if (retval) {
-               com_err(program_name, retval,
+               com_err(program_name, retval, "%s",
                        _("while trying to open external journal"));
                goto no_valid_journal;
        }
@@ -223,7 +231,7 @@ static int remove_journal_device(ext2_filsys fs)
 
        /* Get the journal superblock */
        if ((retval = io_channel_read_blk64(jfs->io, 1, -1024, buf))) {
-               com_err(program_name, retval,
+               com_err(program_name, retval, "%s",
                        _("while reading journal superblock"));
                goto no_valid_journal;
        }
@@ -307,14 +315,14 @@ static errcode_t remove_journal_inode(ext2_filsys fs)
 
        retval = ext2fs_read_inode(fs, ino,  &inode);
        if (retval) {
-               com_err(program_name, retval,
+               com_err(program_name, retval, "%s",
                        _("while reading journal inode"));
                return retval;
        }
        if (ino == EXT2_JOURNAL_INO) {
                retval = ext2fs_read_bitmaps(fs);
                if (retval) {
-                       com_err(program_name, retval,
+                       com_err(program_name, retval, "%s",
                                _("while reading bitmaps"));
                        return retval;
                }
@@ -322,7 +330,7 @@ static errcode_t remove_journal_inode(ext2_filsys fs)
                                               BLOCK_FLAG_READ_ONLY, NULL,
                                               release_blocks_proc, NULL);
                if (retval) {
-                       com_err(program_name, retval,
+                       com_err(program_name, retval, "%s",
                                _("while clearing journal inode"));
                        return retval;
                }
@@ -333,7 +341,7 @@ static errcode_t remove_journal_inode(ext2_filsys fs)
                inode.i_flags &= ~EXT2_IMMUTABLE_FL;
        retval = ext2fs_write_inode(fs, ino, &inode);
        if (retval) {
-               com_err(program_name, retval,
+               com_err(program_name, retval, "%s",
                        _("while writing journal inode"));
                return retval;
        }
@@ -366,7 +374,7 @@ static int check_fsck_needed(ext2_filsys fs)
                return 0;
        printf("\n%s\n", _(please_fsck));
        if (mount_flags & EXT2_MF_READONLY)
-               printf(_("(and reboot afterwards!)\n"));
+               printf("%s", _("(and reboot afterwards!)\n"));
        return 1;
 }
 
@@ -379,7 +387,7 @@ static void request_dir_fsck_afterwards(ext2_filsys fs)
        fs->super->s_state &= ~EXT2_VALID_FS;
        printf("\n%s\n", _(please_dir_fsck));
        if (mount_flags & EXT2_MF_READONLY)
-               printf(_("(and reboot afterwards!)\n"));
+               printf("%s", _("(and reboot afterwards!)\n"));
 }
 
 static void request_fsck_afterwards(ext2_filsys fs)
@@ -391,7 +399,7 @@ static void request_fsck_afterwards(ext2_filsys fs)
        fs->super->s_state &= ~EXT2_VALID_FS;
        printf("\n%s\n", _(please_fsck));
        if (mount_flags & EXT2_MF_READONLY)
-               printf(_("(and reboot afterwards!)\n"));
+               printf("%s", _("(and reboot afterwards!)\n"));
 }
 
 /* Rewrite extents */
@@ -515,7 +523,7 @@ static int rewrite_dir_block(ext2_filsys fs,
                ctx->errcode = ext2fs_get_rec_len(fs, last_de, &rec_len);
                if (ctx->errcode)
                        return BLOCK_ABORT;
-               name_size = last_de->name_len & 0xFF;
+               name_size = ext2fs_dirent_name_len(last_de);
 
                if (!EXT2_HAS_RO_COMPAT_FEATURE(fs->super,
                                EXT4_FEATURE_RO_COMPAT_METADATA_CSUM)) {
@@ -614,12 +622,13 @@ static errcode_t rewrite_directory(ext2_filsys fs, ext2_ino_t dir,
 static void rewrite_inodes(ext2_filsys fs)
 {
        int length = EXT2_INODE_SIZE(fs->super);
-       struct ext2_inode *inode;
+       struct ext2_inode *inode, *zero;
        char            *ea_buf;
        ext2_inode_scan scan;
        errcode_t       retval;
        ext2_ino_t      ino;
        blk64_t         file_acl_block;
+       int             inode_dirty;
 
        if (fs->super->s_creator_os != EXT2_OS_LINUX)
                return;
@@ -636,6 +645,12 @@ static void rewrite_inodes(ext2_filsys fs)
                exit(1);
        }
 
+       retval = ext2fs_get_memzero(length, &zero);
+       if (retval) {
+               com_err("set_csum", retval, "while allocating memory");
+               exit(1);
+       }
+
        retval = ext2fs_get_mem(fs->blocksize, &ea_buf);
        if (retval) {
                com_err("set_csum", retval, "while allocating memory");
@@ -650,11 +665,25 @@ static void rewrite_inodes(ext2_filsys fs)
                }
                if (!ino)
                        break;
+               if (ext2fs_test_inode_bitmap2(fs->inode_map, ino)) {
+                       inode_dirty = 1;
+               } else {
+                       if (memcmp(inode, zero, length) != 0) {
+                               memset(inode, 0, length);
+                               inode_dirty = 1;
+                       } else {
+                               inode_dirty = 0;
+                       }
+               }
 
-               retval = ext2fs_write_inode_full(fs, ino, inode, length);
-               if (retval) {
-                       com_err("set_csum", retval, "while writing inode");
-                       exit(1);
+               if (inode_dirty) {
+                       retval = ext2fs_write_inode_full(fs, ino, inode,
+                                                        length);
+                       if (retval) {
+                               com_err("set_csum", retval, "while writing "
+                                       "inode");
+                               exit(1);
+                       }
                }
 
                retval = rewrite_extents(fs, ino, inode);
@@ -664,7 +693,8 @@ static void rewrite_inodes(ext2_filsys fs)
                        exit(1);
                }
 
-               if (LINUX_S_ISDIR(inode->i_mode)) {
+               if (LINUX_S_ISDIR(inode->i_mode) &&
+                   ext2fs_inode_has_valid_blocks2(fs, inode)) {
                        retval = rewrite_directory(fs, ino, inode);
                        if (retval) {
                                com_err("rewrite_directory", retval,
@@ -691,6 +721,7 @@ static void rewrite_inodes(ext2_filsys fs)
                }
        } while (ino);
 
+       ext2fs_free_mem(&zero);
        ext2fs_free_mem(&inode);
        ext2fs_free_mem(&ea_buf);
        ext2fs_close_inode_scan(scan);
@@ -698,14 +729,20 @@ static void rewrite_inodes(ext2_filsys fs)
 
 static void rewrite_metadata_checksums(ext2_filsys fs)
 {
+       errcode_t retval;
        dgrp_t i;
 
        fs->flags |= EXT2_FLAG_IGNORE_CSUM_ERRORS;
        ext2fs_init_csum_seed(fs);
        for (i = 0; i < fs->group_desc_count; i++)
                ext2fs_group_desc_csum_set(fs, i);
+       retval = ext2fs_read_bitmaps(fs);
+       if (retval) {
+               com_err("rewrite_metadata_checksums", retval,
+                       "while reading bitmaps");
+               exit(1);
+       }
        rewrite_inodes(fs);
-       ext2fs_read_bitmaps(fs);
        ext2fs_mark_ib_dirty(fs);
        ext2fs_mark_bb_dirty(fs);
        ext2fs_mmp_update2(fs, 1);
@@ -733,33 +770,100 @@ static void enable_uninit_bg(ext2_filsys fs)
        fs->flags &= ~EXT2_FLAG_SUPER_ONLY;
 }
 
+static errcode_t zero_empty_inodes(ext2_filsys fs)
+{
+       int length = EXT2_INODE_SIZE(fs->super);
+       struct ext2_inode *inode;
+       ext2_inode_scan scan;
+       errcode_t       retval;
+       ext2_ino_t      ino;
+
+       retval = ext2fs_open_inode_scan(fs, 0, &scan);
+       if (retval)
+               goto out;
+
+       retval = ext2fs_get_mem(length, &inode);
+       if (retval)
+               goto out;
+
+       do {
+               retval = ext2fs_get_next_inode_full(scan, &ino, inode, length);
+               if (retval)
+                       goto out;
+               if (!ino)
+                       break;
+               if (!ext2fs_test_inode_bitmap2(fs->inode_map, ino)) {
+                       memset(inode, 0, length);
+                       retval = ext2fs_write_inode_full(fs, ino, inode,
+                                                        length);
+                       if (retval)
+                               goto out;
+               }
+       } while (1);
+
+out:
+       ext2fs_free_mem(&inode);
+       ext2fs_close_inode_scan(scan);
+       return retval;
+}
+
 static void disable_uninit_bg(ext2_filsys fs, __u32 csum_feature_flag)
 {
        struct ext2_group_desc *gd;
        dgrp_t i;
+       errcode_t retval;
+       blk64_t b, c, d;
+       int has_super;
 
        /* Load bitmaps to ensure that the uninit ones get written out */
        fs->super->s_feature_ro_compat |= csum_feature_flag;
-       ext2fs_read_bitmaps(fs);
+       retval = ext2fs_read_bitmaps(fs);
+       if (retval) {
+               com_err("disable_uninit_bg", retval,
+                       "while reading bitmaps");
+               return;
+       }
        ext2fs_mark_ib_dirty(fs);
        ext2fs_mark_bb_dirty(fs);
        fs->super->s_feature_ro_compat &= ~csum_feature_flag;
 
+       /* If we're only turning off uninit_bg, zero the inodes */
+       if (csum_feature_flag == EXT4_FEATURE_RO_COMPAT_GDT_CSUM) {
+               retval = zero_empty_inodes(fs);
+               if (retval) {
+                       com_err("disable_uninit_bg", retval,
+                               "while zeroing unused inodes");
+                       request_fsck_afterwards(fs);
+               }
+       }
+
+       /* The bbitmap is zeroed; we must mark group metadata blocks in use */
        for (i = 0; i < fs->group_desc_count; i++) {
-               gd = ext2fs_group_desc(fs, fs->group_desc, i);
-               if ((gd->bg_flags & EXT2_BG_INODE_ZEROED) == 0) {
-                       /*
-                        * XXX what we really should do is zap
-                        * uninitialized inode tables instead.
-                        */
+               b = ext2fs_block_bitmap_loc(fs, i);
+               ext2fs_mark_block_bitmap2(fs->block_map, b);
+               b = ext2fs_inode_bitmap_loc(fs, i);
+               ext2fs_mark_block_bitmap2(fs->block_map, b);
+
+               retval = ext2fs_super_and_bgd_loc2(fs, i, &b, &c, &d, NULL);
+               if (retval == 0 && b)
+                       ext2fs_mark_block_bitmap2(fs->block_map, b);
+               if (retval == 0 && c)
+                       ext2fs_mark_block_bitmap2(fs->block_map, c);
+               if (retval == 0 && d)
+                       ext2fs_mark_block_bitmap2(fs->block_map, d);
+               if (retval) {
+                       com_err("disable_uninit_bg", retval,
+                               "while initializing block bitmaps");
                        request_fsck_afterwards(fs);
-                       break;
                }
+
+               gd = ext2fs_group_desc(fs, fs->group_desc, i);
                gd->bg_itable_unused = 0;
                gd->bg_flags = 0;
                ext2fs_group_desc_csum_set(fs, i);
        }
        fs->flags &= ~EXT2_FLAG_SUPER_ONLY;
+       ext2fs_mark_super_dirty(fs);
 }
 
 /*
@@ -812,8 +916,9 @@ static int update_feature_set(ext2_filsys fs, char *features)
                                "read-only.\n"), stderr);
                        return 1;
                }
-               if (sb->s_feature_incompat &
-                   EXT3_FEATURE_INCOMPAT_RECOVER) {
+               if ((sb->s_feature_incompat &
+                   EXT3_FEATURE_INCOMPAT_RECOVER) &&
+                   f_flag < 2) {
                        fputs(_("The needs_recovery flag is set.  "
                                "Please run e2fsck before clearing\n"
                                "the has_journal flag.\n"), stderr);
@@ -828,6 +933,19 @@ static int update_feature_set(ext2_filsys fs, char *features)
                                return 1;
                }
        }
+
+       if (FEATURE_ON(E2P_FEATURE_RO_INCOMPAT,
+               EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER)) {
+               if (sb->s_feature_incompat &
+                       EXT2_FEATURE_INCOMPAT_META_BG) {
+                       fputs(_("Setting filesystem feature 'sparse_super' "
+                               "not supported\nfor filesystems with "
+                               "the meta_bg feature enabled.\n"),
+                               stderr);
+                       return 1;
+               }
+       }
+
        if (FEATURE_ON(E2P_FEATURE_INCOMPAT, EXT4_FEATURE_INCOMPAT_MMP)) {
                int error;
 
@@ -881,14 +999,14 @@ static int update_feature_set(ext2_filsys fs, char *features)
                                         "match. expected: %x, actual: %x\n"),
                                         EXT4_MMP_MAGIC, mmp_cmp->mmp_magic);
                        else
-                               com_err(program_name, error,
+                               com_err(program_name, error, "%s",
                                        _("while reading MMP block."));
                        goto mmp_error;
                }
 
                /* We need to force out the group descriptors as well */
                fs->flags &= ~EXT2_FLAG_SUPER_ONLY;
-               ext2fs_block_alloc_stats(fs, sb->s_mmp_block, -1);
+               ext2fs_block_alloc_stats2(fs, sb->s_mmp_block, -1);
 mmp_error:
                sb->s_mmp_block = 0;
                sb->s_mmp_update_interval = 0;
@@ -1066,7 +1184,9 @@ static int add_journal(ext2_filsys fs)
                goto err;
        }
        if (journal_device) {
-               check_plausibility(journal_device);
+               if (!check_plausibility(journal_device, CHECK_BLOCK_DEV,
+                                       NULL))
+                       proceed_question(-1);
                check_mount(journal_device, 0, _("journal"));
 #ifdef CONFIG_TESTIO_DEBUG
                if (getenv("TEST_IO_FLAGS") || getenv("TEST_IO_BLOCK")) {
@@ -1089,7 +1209,7 @@ static int add_journal(ext2_filsys fs)
                fflush(stdout);
 
                retval = ext2fs_add_journal_device(fs, jfs);
-               ext2fs_close(jfs);
+               ext2fs_close_free(&jfs);
                if (retval) {
                        com_err(program_name, retval,
                                _("while adding filesystem to journal on %s"),
@@ -1102,11 +1222,16 @@ static int add_journal(ext2_filsys fs)
                fflush(stdout);
                journal_blocks = figure_journal_size(journal_size, fs);
 
-               retval = ext2fs_add_journal_inode(fs, journal_blocks,
-                                                 journal_flags);
+               if (journal_location_string)
+                       journal_location =
+                               parse_num_blocks2(journal_location_string,
+                                                 fs->super->s_log_block_size);
+               retval = ext2fs_add_journal_inode2(fs, journal_blocks,
+                                                  journal_location,
+                                                  journal_flags);
                if (retval) {
                        fprintf(stderr, "\n");
-                       com_err(program_name, retval,
+                       com_err(program_name, retval, "%s",
                                _("\n\twhile trying to create journal file"));
                        return retval;
                } else
@@ -1162,10 +1287,6 @@ static void handle_quota_options(ext2_filsys fs)
        quota_release_context(&qctx);
 
        if ((usrquota == QOPT_ENABLE) || (grpquota == QOPT_ENABLE)) {
-               fprintf(stderr, _("\nWarning: the quota feature is still "
-                                 "under development\n"
-                                 "See https://ext4.wiki.kernel.org/"
-                                 "index.php/Quota for more information\n\n"));
                fs->super->s_feature_ro_compat |= EXT4_FEATURE_RO_COMPAT_QUOTA;
                ext2fs_mark_super_dirty(fs);
        } else if (!fs->super->s_usr_quota_inum &&
@@ -1177,6 +1298,7 @@ static void handle_quota_options(ext2_filsys fs)
        return;
 }
 
+#ifdef CONFIG_QUOTA
 static void parse_quota_opts(const char *opts)
 {
        char    *buf, *token, *next, *p;
@@ -1219,8 +1341,7 @@ static void parse_quota_opts(const char *opts)
        }
        free(buf);
 }
-
-
+#endif
 
 static void parse_e2label_options(int argc, char ** argv)
 {
@@ -1282,11 +1403,15 @@ static void parse_tune2fs_options(int argc, char **argv)
        char *tmp;
        struct group *gr;
        struct passwd *pw;
+       char optstring[100] = "c:e:fg:i:jlm:o:r:s:u:C:E:I:J:L:M:O:T:U:";
 
+#ifdef CONFIG_QUOTA
+       strcat(optstring, "Q:");
+#endif
        open_flag = 0;
 
        printf("tune2fs %s (%s)\n", E2FSPROGS_VERSION, E2FSPROGS_DATE);
-       while ((c = getopt(argc, argv, "c:e:fg:i:jlm:o:r:s:u:C:E:I:J:L:M:O:Q:T:U:")) != EOF)
+       while ((c = getopt(argc, argv, optstring)) != EOF)
                switch (c) {
                case 'c':
                        max_mount_count = strtol(optarg, &tmp, 0);
@@ -1333,7 +1458,7 @@ static void parse_tune2fs_options(int argc, char **argv)
                        open_flag |= EXT2_FLAG_RW;
                        break;
                case 'f': /* Force */
-                       f_flag = 1;
+                       f_flag++;
                        break;
                case 'g':
                        resgid = strtoul(optarg, &tmp, 0);
@@ -1424,7 +1549,7 @@ static void parse_tune2fs_options(int argc, char **argv)
                        break;
                case 'o':
                        if (mntopts_cmd) {
-                               com_err(program_name, 0,
+                               com_err(program_name, 0, "%s",
                                        _("-o may only be specified once"));
                                usage();
                        }
@@ -1433,18 +1558,20 @@ static void parse_tune2fs_options(int argc, char **argv)
                        break;
                case 'O':
                        if (features_cmd) {
-                               com_err(program_name, 0,
+                               com_err(program_name, 0, "%s",
                                        _("-O may only be specified once"));
                                usage();
                        }
                        features_cmd = optarg;
                        open_flag = EXT2_FLAG_RW;
                        break;
+#ifdef CONFIG_QUOTA
                case 'Q':
                        Q_flag = 1;
                        parse_quota_opts(optarg);
                        open_flag = EXT2_FLAG_RW;
                        break;
+#endif
                case 'r':
                        reserved_blocks = strtoul(optarg, &tmp, 0);
                        if (*tmp) {
@@ -1558,7 +1685,7 @@ static int parse_extended_opts(ext2_filsys fs, const char *opts)
        len = strlen(opts);
        buf = malloc(len+1);
        if (!buf) {
-               fprintf(stderr,
+               fprintf(stderr, "%s",
                        _("Couldn't allocate memory to parse options!\n"));
                return 1;
        }
@@ -1679,7 +1806,7 @@ static int parse_extended_opts(ext2_filsys fs, const char *opts)
                        r_usage++;
        }
        if (r_usage) {
-               fprintf(stderr, _("\nBad options specified.\n\n"
+               fprintf(stderr, "%s", _("\nBad options specified.\n\n"
                        "Extended options are separated by commas, "
                        "and may take an argument which\n"
                        "\tis set off by an equals ('=') sign.\n\n"
@@ -1752,10 +1879,10 @@ static int get_move_bitmaps(ext2_filsys fs, int new_ino_blks_per_grp,
        return 0;
 }
 
-static int ext2fs_is_meta_block(ext2_filsys fs, blk_t blk)
+static int ext2fs_is_meta_block(ext2_filsys fs, blk64_t blk)
 {
        dgrp_t group;
-       group = ext2fs_group_of_blk(fs, blk);
+       group = ext2fs_group_of_blk2(fs, blk);
        if (ext2fs_block_bitmap_loc(fs, group) == blk)
                return 1;
        if (ext2fs_inode_bitmap_loc(fs, group) == blk)
@@ -1763,11 +1890,11 @@ static int ext2fs_is_meta_block(ext2_filsys fs, blk_t blk)
        return 0;
 }
 
-static int ext2fs_is_block_in_group(ext2_filsys fs, dgrp_t group, blk_t blk)
+static int ext2fs_is_block_in_group(ext2_filsys fs, dgrp_t group, blk64_t blk)
 {
-       blk_t start_blk, end_blk;
+       blk64_t start_blk, end_blk;
        start_blk = fs->super->s_first_data_block +
-                       EXT2_BLOCKS_PER_GROUP(fs->super) * group;
+                       EXT2_GROUPS_TO_BLOCKS(fs->super, group);
        /*
         * We cannot get new block beyond end_blk for for the last block group
         * so we can check with EXT2_BLOCKS_PER_GROUP even for last block group
@@ -1805,7 +1932,7 @@ static int move_block(ext2_filsys fs, ext2fs_block_bitmap bmap)
                         * the respective fs metadata pointers. Otherwise
                         * fail
                         */
-                       group = ext2fs_group_of_blk(fs, blk);
+                       group = ext2fs_group_of_blk2(fs, blk);
                        goal = ext2fs_group_first_block2(fs, group);
                        meta_data = 1;
 
@@ -1966,7 +2093,7 @@ err_out:
 static int group_desc_scan_and_fix(ext2_filsys fs, ext2fs_block_bitmap bmap)
 {
        dgrp_t i;
-       blk_t blk, new_blk;
+       blk64_t blk, new_blk;
 
        for (i = 0; i < fs->group_desc_count; i++) {
                blk = ext2fs_block_bitmap_loc(fs, i);
@@ -2239,7 +2366,7 @@ static int tune2fs_setup_tdb(const char *name, io_manager *io_ptr)
        tmp_name = strdup(name);
        if (!tmp_name) {
        alloc_fn_fail:
-               com_err(program_name, ENOMEM, 
+               com_err(program_name, ENOMEM, "%s",
                        _("Couldn't allocate memory for tdb filename\n"));
                return ENOMEM;
        }
@@ -2258,15 +2385,12 @@ static int tune2fs_setup_tdb(const char *name, io_manager *io_ptr)
                goto alloc_fn_fail;
        sprintf(tdb_file, "%s/tune2fs-%s.e2undo", tdb_dir, dev_name);
 
-       if (!access(tdb_file, F_OK)) {
-               if (unlink(tdb_file) < 0) {
-                       retval = errno;
-                       com_err(program_name, retval,
-                               _("while trying to delete %s"),
-                               tdb_file);
-                       free(tdb_file);
-                       return retval;
-               }
+       if ((unlink(tdb_file) < 0) && (errno != ENOENT)) {
+               retval = errno;
+               com_err(program_name, retval,
+                       _("while trying to delete %s"), tdb_file);
+               free(tdb_file);
+               return retval;
        }
 
        set_undo_io_backing_manager(*io_ptr);
@@ -2344,7 +2468,7 @@ retry_open:
                                _("MMP block magic is bad. Try to fix it by "
                                  "running:\n'e2fsck -f %s'\n"), device_name);
                else if (retval != EXT2_ET_MMP_FAILED)
-                       fprintf(stderr,
+                       fprintf(stderr, "%s",
                             _("Couldn't find valid filesystem superblock.\n"));
 
                ext2fs_free(fs);
@@ -2365,8 +2489,8 @@ retry_open:
                        goto closefs;
                }
                if (new_inode_size < EXT2_INODE_SIZE(fs->super)) {
-                       fprintf(stderr, _("Shrinking the inode size is "
-                                         "not supported\n"));
+                       fprintf(stderr, "%s",
+                               _("Shrinking inode size is not supported\n"));
                        rc = 1;
                        goto closefs;
                }
@@ -2388,7 +2512,7 @@ retry_open:
                        goto closefs;
                }
                if (io_ptr != io_ptr_orig) {
-                       ext2fs_close(fs);
+                       ext2fs_close_free(&fs);
                        goto retry_open;
                }
        }
@@ -2437,7 +2561,7 @@ retry_open:
                printf(_("Setting reserved blocks gid to %lu\n"), resgid);
        }
        if (i_flag) {
-               if (interval >= (1ULL << 32)) {
+               if ((unsigned long long)interval >= (1ULL << 32)) {
                        com_err(program_name, 0,
                                _("interval between checks is too big (%lu)"),
                                interval);
@@ -2471,10 +2595,18 @@ retry_open:
        }
        if (s_flag == 1) {
                if (sb->s_feature_ro_compat &
-                   EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER)
+                   EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER) {
                        fputs(_("\nThe filesystem already has sparse "
                                "superblocks.\n"), stderr);
-               else {
+               } else if (sb->s_feature_incompat &
+                       EXT2_FEATURE_INCOMPAT_META_BG) {
+                       fputs(_("\nSetting the sparse superblock flag not "
+                               "supported\nfor filesystems with "
+                               "the meta_bg feature enabled.\n"),
+                               stderr);
+                       rc = 1;
+                       goto closefs;
+               } else {
                        sb->s_feature_ro_compat |=
                                EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER;
                        sb->s_state &= ~EXT2_VALID_FS;
@@ -2484,7 +2616,7 @@ retry_open:
                }
        }
        if (s_flag == 0) {
-               fputs(_("\nClearing the sparse superflag not supported.\n"),
+               fputs(_("\nClearing the sparse superblock flag not supported.\n"),
                      stderr);
                rc = 1;
                goto closefs;
@@ -2560,8 +2692,7 @@ retry_open:
                int set_csum = 0;
                dgrp_t i;
 
-               if (EXT2_HAS_RO_COMPAT_FEATURE(fs->super,
-                               EXT4_FEATURE_RO_COMPAT_METADATA_CSUM)) {
+               if (ext2fs_has_group_desc_csum(fs)) {
                        /*
                         * Changing the UUID requires rewriting all metadata,
                         * which can race with a mounted fs.  Don't allow that.
@@ -2572,12 +2703,9 @@ retry_open:
                                        "unmounted.\n"), stderr);
                                exit(1);
                        }
-
                        if (check_fsck_needed(fs))
                                exit(1);
-               }
 
-               if (ext2fs_has_group_desc_csum(fs)) {
                        /*
                         * Determine if the block group checksums are
                         * correct so we know whether or not to set
@@ -2597,7 +2725,8 @@ retry_open:
                } else if (strcasecmp(new_UUID, "random") == 0) {
                        uuid_generate(sb->s_uuid);
                } else if (uuid_parse(new_UUID, sb->s_uuid)) {
-                       com_err(program_name, 0, _("Invalid UUID format\n"));
+                       com_err(program_name, 0, "%s",
+                               _("Invalid UUID format\n"));
                        rc = 1;
                        goto closefs;
                }
@@ -2640,7 +2769,7 @@ retry_open:
                        printf(_("Setting inode size %lu\n"),
                                                        new_inode_size);
                } else {
-                       printf(_("Failed to change inode size\n"));
+                       printf("%s", _("Failed to change inode size\n"));
                        rc = 1;
                        goto closefs;
                }
@@ -2676,5 +2805,5 @@ closefs:
                exit(1);
        }
 
-       return (ext2fs_close(fs) ? 1 : 0);
+       return (ext2fs_close_free(&fs) ? 1 : 0);
 }