]> git.ipfire.org Git - thirdparty/util-linux.git/blobdiff - sys-utils/lscpu.c
Make the ways of using output stream consistent in usage()
[thirdparty/util-linux.git] / sys-utils / lscpu.c
index 32f989e381c39015120e62ef499095abad687191..278f2be5816ea20848b4382312c2d605203052e6 100644 (file)
@@ -39,6 +39,8 @@
 
 #include "closestream.h"
 #include "optutils.h"
+#include "c_strtod.h"
+#include "sysfs.h"
 
 #include "lscpu.h"
 
@@ -108,6 +110,7 @@ enum {
        COL_CPU_SCALMHZ,
        COL_CPU_MAXMHZ,
        COL_CPU_MINMHZ,
+       COL_CPU_MODELNAME,
 };
 
 enum {
@@ -154,7 +157,8 @@ static struct lscpu_coldesc coldescs_cpu[] =
        [COL_CPU_MHZ]          = { "MHZ", N_("shows the currently MHz of the CPU"), SCOLS_FL_RIGHT, 0, SCOLS_JSON_NUMBER },
        [COL_CPU_SCALMHZ]      = { "SCALMHZ%", N_("shows scaling percentage of the CPU frequency"), SCOLS_FL_RIGHT, SCOLS_JSON_NUMBER },
        [COL_CPU_MAXMHZ]       = { "MAXMHZ", N_("shows the maximum MHz of the CPU"), SCOLS_FL_RIGHT, 0, SCOLS_JSON_NUMBER },
-       [COL_CPU_MINMHZ]       = { "MINMHZ", N_("shows the minimum MHz of the CPU"), SCOLS_FL_RIGHT, 0, SCOLS_JSON_NUMBER }
+       [COL_CPU_MINMHZ]       = { "MINMHZ", N_("shows the minimum MHz of the CPU"), SCOLS_FL_RIGHT, 0, SCOLS_JSON_NUMBER },
+       [COL_CPU_MODELNAME]    = { "MODELNAME", N_("shows CPU model name"), 0, 0, SCOLS_JSON_STRING }
 };
 
 static struct lscpu_coldesc coldescs_cache[] =
@@ -167,12 +171,12 @@ static struct lscpu_coldesc coldescs_cache[] =
        [COL_CACHE_WAYS]       = { "WAYS", N_("ways of associativity"), SCOLS_FL_RIGHT, 0, SCOLS_JSON_NUMBER },
        [COL_CACHE_ALLOCPOL]   = { "ALLOC-POLICY", N_("allocation policy") },
        [COL_CACHE_WRITEPOL]   = { "WRITE-POLICY", N_("write policy") },
-       [COL_CACHE_PHYLINE]    = { "PHY-LINE", N_("number of physical cache line per cache t"), SCOLS_FL_RIGHT, 0, SCOLS_JSON_NUMBER },
+       [COL_CACHE_PHYLINE]    = { "PHY-LINE", N_("number of physical cache line per cache tag"), SCOLS_FL_RIGHT, 0, SCOLS_JSON_NUMBER },
        [COL_CACHE_SETS]       = { "SETS", N_("number of sets in the cache; set lines has the same cache index"), SCOLS_FL_RIGHT, 0, SCOLS_JSON_NUMBER },
        [COL_CACHE_COHERENCYSIZE] = { "COHERENCY-SIZE", N_("minimum amount of data in bytes transferred from memory to cache"), SCOLS_FL_RIGHT, 0, SCOLS_JSON_NUMBER }
 };
 
-static int is_term = 0;
+static int hierarchic = -1;
 
 UL_DEBUG_DEFINE_MASK(lscpu);
 UL_DEBUG_DEFINE_MASKNAMES(lscpu) = UL_DEBUG_EMPTY_MASKNAMES;
@@ -217,6 +221,15 @@ static void lscpu_context_init_paths(struct lscpu_cxt *cxt)
        DBG(MISC, ul_debugobj(cxt, "initialize paths"));
        ul_path_init_debug();
 
+       /* / */
+       cxt->rootfs = NULL;
+       if (cxt->prefix) {
+               cxt->rootfs = ul_new_path("/");
+               if (!cxt->rootfs)
+                       err(EXIT_FAILURE, _("failed to initialize rootfs handler"));
+               ul_path_set_prefix(cxt->rootfs, cxt->prefix);
+       }
+
        /* /sys/devices/system/cpu */
        cxt->syscpu = ul_new_path(_PATH_SYS_CPU);
        if (!cxt->syscpu)
@@ -249,6 +262,7 @@ static void lscpu_free_context(struct lscpu_cxt *cxt)
        DBG(MISC, ul_debugobj(cxt, " de-initialize paths"));
        ul_unref_path(cxt->syscpu);
        ul_unref_path(cxt->procfs);
+       ul_unref_path(cxt->rootfs);
 
        DBG(MISC, ul_debugobj(cxt, " freeing cpus"));
        for (i = 0; i < cxt->npossibles; i++) {
@@ -349,10 +363,10 @@ static char *get_cell_data(
                snprintf(buf, bufsz, "%d", cpu->logical_id);
                break;
        case COL_CPU_BOGOMIPS:
-               if (cpu->bogomips)
-                       xstrncpy(buf, cpu->bogomips, bufsz);
-               else if (cpu->type->bogomips)
-                       xstrncpy(buf, cpu->type->bogomips, bufsz);
+               if (!cpu->bogomips && !cpu->type->bogomips)
+                       break;
+               snprintf(buf, bufsz, "%.2f", (float) c_strtod(
+                               cpu->bogomips ? : cpu->type->bogomips, NULL));
                break;
        case COL_CPU_CORE:
                fill_id(cxt, cpu, core, buf, bufsz);
@@ -442,6 +456,10 @@ static char *get_cell_data(
                if (cpu->mhz_min_freq)
                        snprintf(buf, bufsz, "%.4f", cpu->mhz_min_freq);
                break;
+       case COL_CPU_MODELNAME:
+               if (cpu->type && cpu->type->modelname)
+                       xstrncpy(buf, cpu->type->modelname, bufsz);
+               break;
        }
        return buf;
 }
@@ -799,8 +817,8 @@ static struct libscols_line *
        struct libscols_line *ln;
        va_list args;
 
-       /* Don't print section lines without data on non-terminal output */
-       if (!is_term && fmt == NULL)
+       /* Don't print section lines without data */
+       if (!hierarchic && fmt == NULL)
                return NULL;
 
        ln = scols_table_new_line(tb, sec);
@@ -837,13 +855,15 @@ print_cpuset(struct lscpu_cxt *cxt,
             const char *key, cpu_set_t *set)
 {
        size_t setbuflen = 7 * cxt->maxcpus;
-       char setbuf[setbuflen], *p;
+       char *setbuf, *p;
 
        assert(set);
        assert(key);
        assert(tb);
        assert(cxt);
 
+       setbuf = xmalloc(setbuflen);
+
        if (cxt->hex) {
                p = cpumask_create(setbuf, setbuflen, set, cxt->setsize);
                add_summary_s(tb, sec, key, p);
@@ -851,6 +871,8 @@ print_cpuset(struct lscpu_cxt *cxt,
                p = cpulist_create(setbuf, setbuflen, set, cxt->setsize);
                add_summary_s(tb, sec, key, p);
        }
+
+       free(setbuf);
 }
 
 static void
@@ -918,7 +940,7 @@ print_summary_cputype(struct lscpu_cxt *cxt,
                add_summary_x(tb, sec, _("CPU min MHz:"), "%.4f", lsblk_cputype_get_minmhz(cxt, ct));
        }
        if (ct->bogomips)
-               add_summary_s(tb, sec, _("BogoMIPS:"), ct->bogomips);
+               add_summary_x(tb, sec, _("BogoMIPS:"), "%.2f",  (float) c_strtod(ct->bogomips, NULL));
 
        if (ct->dispatching >= 0)
                add_summary_s(tb, sec, _("Dispatching mode:"), _(disp_modes[ct->dispatching]));
@@ -942,7 +964,7 @@ static void print_summary(struct lscpu_cxt *cxt)
        char field[256];
        size_t i = 0;
        struct libscols_table *tb;
-       struct libscols_line *sec = NULL;
+       struct libscols_line *sec;
        int hdr_caches = 0;
 
        scols_init_debug(0);
@@ -955,7 +977,7 @@ static void print_summary(struct lscpu_cxt *cxt)
        if (cxt->json) {
                scols_table_enable_json(tb, 1);
                scols_table_set_name(tb, "lscpu");
-       } else if (is_term) {
+       } else if (hierarchic) {
                struct libscols_symbols *sy = scols_new_symbols();
 
                if (!sy)
@@ -967,16 +989,15 @@ static void print_summary(struct lscpu_cxt *cxt)
                scols_unref_symbols(sy);
        }
 
-       if (scols_table_new_column(tb, "field", 0, is_term ? SCOLS_FL_TREE : 0) == NULL ||
+       if (scols_table_new_column(tb, "field", 0, hierarchic ? SCOLS_FL_TREE : 0) == NULL ||
            scols_table_new_column(tb, "data", 0, SCOLS_FL_NOEXTREMES | SCOLS_FL_WRAP) == NULL)
                err(EXIT_FAILURE, _("failed to initialize output column"));
 
        ct = lscpu_cputype_get_default(cxt);
 
        /* Section: architecture */
-       if (cxt->arch)
-               sec = add_summary_s(tb, NULL, _("Architecture:"), cxt->arch->name);
-       if (cxt->arch && (cxt->arch->bit32 || cxt->arch->bit64)) {
+       sec = add_summary_s(tb, NULL, _("Architecture:"), cxt->arch->name);
+       if (cxt->arch->bit32 || cxt->arch->bit64) {
                char buf[32], *p = buf;
 
                if (cxt->arch->bit32) {
@@ -992,11 +1013,11 @@ static void print_summary(struct lscpu_cxt *cxt)
        }
        if (ct && ct->addrsz)
                add_summary_s(tb, sec, _("Address sizes:"), ct->addrsz);
-#if !defined(WORDS_BIGENDIAN)
-       add_summary_s(tb, sec, _("Byte Order:"), "Little Endian");
-#else
-       add_summary_s(tb, sec, _("Byte Order:"), "Big Endian");
-#endif
+
+       if (sysfs_get_byteorder(cxt->rootfs) == SYSFS_BYTEORDER_LITTLE)
+               add_summary_s(tb, sec, _("Byte Order:"), "Little Endian");
+       else
+               add_summary_s(tb, sec, _("Byte Order:"), "Big Endian");
 
        /* Section: CPU lists */
        sec = add_summary_n(tb, NULL, _("CPU(s):"), cxt->npresents);
@@ -1080,7 +1101,7 @@ static void print_summary(struct lscpu_cxt *cxt)
                                hdr_caches = 1;
                        }
 
-                       snprintf(field, sizeof(field), is_term ? _("%s:") : _("%s cache:"), name);
+                       snprintf(field, sizeof(field), hierarchic ? _("%s:") : _("%s cache:"), name);
                        if (cxt->bytes)
                                add_summary_sprint(tb, sec, field,
                                                P_("%" PRIu64 " (%d instance)",
@@ -1110,7 +1131,7 @@ static void print_summary(struct lscpu_cxt *cxt)
                        sec = add_summary_e(tb, NULL, _("Caches:"));
                        hdr_caches = 1;
                }
-               snprintf(field, sizeof(field), is_term ? _("%s:") : _("%s cache:"), ca->name);
+               snprintf(field, sizeof(field), hierarchic ? _("%s:") : _("%s cache:"), ca->name);
                if (cxt->bytes)
                        add_summary_x(tb, sec, field, "%" PRIu64, ca->size);
                else {
@@ -1141,7 +1162,7 @@ static void print_summary(struct lscpu_cxt *cxt)
                sec = add_summary_e(tb, NULL, _("Vulnerabilities:"));
 
                for (i = 0; i < cxt->nvuls; i++) {
-                       snprintf(field, sizeof(field), is_term ?
+                       snprintf(field, sizeof(field), hierarchic ?
                                        _("%s:") : _("Vulnerability %s:"), cxt->vuls[i].name);
                        add_summary_s(tb, sec, field, cxt->vuls[i].text);
                }
@@ -1174,9 +1195,10 @@ static void __attribute__((__noreturn__)) usage(void)
        fputs(_(" -s, --sysroot <dir>     use specified directory as system root\n"), out);
        fputs(_(" -x, --hex               print hexadecimal masks rather than lists of CPUs\n"), out);
        fputs(_(" -y, --physical          print physical instead of logical IDs\n"), out);
+       fputs(_("     --hierarchic[=when] use subsections in summary (auto, never, always)\n"), out);
        fputs(_("     --output-all        print all available columns for -e, -p or -C\n"), out);
        fputs(USAGE_SEPARATOR, out);
-       printf(USAGE_HELP_OPTIONS(25));
+       fprintf(out, USAGE_HELP_OPTIONS(25));
 
        fputs(_("\nAvailable output columns for -e or -p:\n"), out);
        for (i = 0; i < ARRAY_SIZE(coldescs_cpu); i++)
@@ -1186,7 +1208,7 @@ static void __attribute__((__noreturn__)) usage(void)
        for (i = 0; i < ARRAY_SIZE(coldescs_cache); i++)
                fprintf(out, " %13s  %s\n", coldescs_cache[i].name, _(coldescs_cache[i].help));
 
-       printf(USAGE_MAN_TAIL("lscpu(1)"));
+       fprintf(out, USAGE_MAN_TAIL("lscpu(1)"));
 
        exit(EXIT_SUCCESS);
 }
@@ -1201,6 +1223,7 @@ int main(int argc, char *argv[])
        size_t i, ncolumns = 0;
        enum {
                OPT_OUTPUT_ALL = CHAR_MAX + 1,
+               OPT_HIERARCHIC,
        };
        static const struct option longopts[] = {
                { "all",        no_argument,       NULL, 'a' },
@@ -1217,6 +1240,7 @@ int main(int argc, char *argv[])
                { "hex",        no_argument,       NULL, 'x' },
                { "version",    no_argument,       NULL, 'V' },
                { "output-all", no_argument,       NULL, OPT_OUTPUT_ALL },
+               { "hierarchic", optional_argument, NULL, OPT_HIERARCHIC },
                { NULL,         0, NULL, 0 }
        };
 
@@ -1287,7 +1311,19 @@ int main(int argc, char *argv[])
                case OPT_OUTPUT_ALL:
                        all = 1;
                        break;
-
+               case OPT_HIERARCHIC:
+                       if (optarg) {
+                               if (strcmp(optarg, "auto") == 0)
+                                       hierarchic = -1;
+                               else if (strcmp(optarg, "never") == 0)
+                                       hierarchic = 0;
+                               else if (strcmp(optarg, "always") == 0)
+                                       hierarchic = 1;
+                               else
+                                       errx(EXIT_FAILURE, _("unsupported --flat argument"));
+                       } else
+                               hierarchic = 1;
+                       break;
                case 'h':
                        usage();
                case 'V':
@@ -1325,7 +1361,6 @@ int main(int argc, char *argv[])
                cxt->show_offline = cxt->mode == LSCPU_OUTPUT_READABLE ? 1 : 0;
        }
 
-       is_term = isatty(STDOUT_FILENO);        /* global variable */
 
        lscpu_init_debug();
 
@@ -1344,6 +1379,9 @@ int main(int argc, char *argv[])
 
        cxt->virt = lscpu_read_virtualization(cxt);
 
+       if (hierarchic == -1)
+               hierarchic = isatty(STDOUT_FILENO);     /* default */
+
        switch(cxt->mode) {
        case LSCPU_OUTPUT_SUMMARY:
                print_summary(cxt);
@@ -1410,6 +1448,7 @@ int main(int argc, char *argv[])
                print_cpus_readable(cxt, columns, ncolumns);
                break;
        case LSCPU_OUTPUT_PARSABLE:
+               cxt->show_compatible = 1;
                if (!ncolumns) {
                        columns[ncolumns++] = COL_CPU_CPU;
                        columns[ncolumns++] = COL_CPU_CORE;
@@ -1419,12 +1458,14 @@ int main(int argc, char *argv[])
                                columns[ncolumns++] = COL_CPU_SOCKET;
                        columns[ncolumns++] = COL_CPU_NODE;
                        columns[ncolumns++] = COL_CPU_CACHE;
-                       cxt->show_compatible = 1;
                }
-               if (outarg && string_add_to_idarray(outarg, columns,
+               if (outarg) {
+                       if (string_add_to_idarray(outarg, columns,
                                        ARRAY_SIZE(columns),
                                        &ncolumns, cpu_column_name_to_id) < 0)
-                       return EXIT_FAILURE;
+                               return EXIT_FAILURE;
+                       cxt->show_compatible = 0;
+               }
 
                print_cpus_parsable(cxt, columns, ncolumns);
                break;