logger: fix incorrect warning message when both --file and a message are specified
Logger warns that when both --file and a message are given, the message is ignored.
It does the opposite. Fix the warning message to conform to the observed behavior.
Example:
echo "You will not see this file in the log" > file.txt
logger -f file.txt "You will see this message in the log"
Signed-off-by: Alexander Kappner <agk@godking.net>
Karel Zak [Tue, 12 Aug 2025 12:47:49 +0000 (14:47 +0200)]
swapon: (man page) add details about fstab configuration
The fstab(5) man page already describes some basic aspects of "swap,"
but it makes sense to be more specific in the swapon man page and
describe everything in one place, serving as a normative reference for
what is expected on Linux in fstab for swap.
Fixes: https://github.com/util-linux/util-linux/issues/3667 Signed-off-by: Karel Zak <kzak@redhat.com>
Add support for the auxiliary posix clocks introduced in Linux 6.17.
When auxiliary clocks are not supported, no output line is generated.
When an auxiliary clock is not enabled an output line without TIME
columns is generated.
chrt: (man,usage) put --pid first in synopses and examples, for clarity
When --pid is among the options, it is clearest when it is given as the
first option, because then it doesn't sit between the policy option and
the somewhat related priority value. It creates some kind of symmetry:
the --pid option first, then other things, and the actual PID last.
Let's use these simple functions to report what the last operation or
status detected by the library means to the filesystem. It will be
used by the fanotify monitor as well.
Karel Zak [Tue, 10 Jun 2025 11:51:23 +0000 (13:51 +0200)]
libmount: (monitor) optimize inotify utab watch
Don't repeat no-op inotify_add_watch() calls. This happens when we
monitor the /run[/mount] directory before the utab.event file exists.
The old version just tries to create a watch and ignores ENOENT
errors. It seems better to remember the path of the last created watch
and not repeat it.
Karel Zak [Tue, 27 May 2025 11:14:34 +0000 (13:14 +0200)]
libmount: (monitor) clean up internal names
In future changes, we need to process active monitor entries in entry
type-specific code to return data from events.
This requires a slight change in the function's logic, so it makes
sense to rename the function according to the new logic, meaning
changes --> active, verify --> process.
Karel Zak [Tue, 5 Aug 2025 11:22:10 +0000 (13:22 +0200)]
Merge branch 'PR/libmount-excl' of https://github.com/karelzak/util-linux-work
* 'PR/libmount-excl' of https://github.com/karelzak/util-linux-work:
mount: add --exclusive command line option
libmount: Add support for FSCONFIG_CMD_CREATE_EXCL
lib: add FSCONFIG_CMD_CREATE_EXCL
Karel Zak [Thu, 31 Jul 2025 10:31:36 +0000 (12:31 +0200)]
mount: add --exclusive command line option
The new option ensures that the kernel does not reuse existing
superblock.
The new option is available to non-root users as it does not affect
the superblock itself or any other aspects of the mount process. It
makes the current mounting more restrictive, so it makes sense to
allow it for non-root users.
curses is special in that it's able to find ncurses in a lot more locations that ncurses, which only looks at pkg-config and cmake. This is somewhat useful with exotic OSes like macOS.
chrt: Allow optional priority for non‑prio policies without --pid
This extends commit e7a2d62434c2
("chrt: Make priority optional for policies that don't use it")
so that priority arguments are optional even when --pid is not specified.
Before this patch:
$ chrt --other ls -lh
chrt: invalid priority argument: 'ls'
-> only "chrt --other 0 ls -lh" would work
After this patch:
$ chrt --other ls -lh
$ chrt --other 0 ls -lh
-> both now work
If an out‑of‑range priority is given, it reports an error:
$ chrt --other 1 ls -lh
unsupported priority value for the policy: 1 (see --max for valid range)
Changes in v2:
- Removed is_number() and used isdigit_string() (Karel Zak)
- used _() for translation (Karel Zak)
Fixes: e7a2d62434c2 ("chrt: Make priority optional for policies that don't use it") Signed-off-by: Madadi Vineeth Reddy <vineethr@linux.ibm.com>
tests/helpers/test_sigstate.c: explicitly reset SIGINT to default action after trapping
After upgrading bash to 5.3 to contain commit [1], if SIGINT was trapped in
asynchronous subshell, bash called set_signal_async_ignored to make sure
processes that are created by this asynchronous subshell to ignore SIGINT.
And it caused test case `kill/decode' failed, the signal INT was existed in
both of Blocked and Ignored
Seppo Takalo [Thu, 24 Jul 2025 11:38:59 +0000 (14:38 +0300)]
ldattach: Allow changing the MTU for GSM0710 framing
Traditionally ldattach have hard coded MTU of 127 bytes
which differs from defaults proposed in 3GPP TS 27.010
which is 31 bytes when basic framing is used.
Add '-m <value>' parameter that is only GSM0710 specific
and already handled by the kernel. Use same value for both
MTU and MRU.
Signed-off-by: Seppo Takalo <seppo.takalo@nordicsemi.no>
Karel Zak [Mon, 28 Jul 2025 09:51:43 +0000 (11:51 +0200)]
Merge branch 'PR/column-colors' of https://github.com/karelzak/util-linux-work
* 'PR/column-colors' of https://github.com/karelzak/util-linux-work:
column: add support for color scheme
libsmartcols: add function to set/get header colors
lib/strutils: add ul_optstr_get_value()
lib/color-names: Fix color name canonicalization
column: add --color[=<when>] to control colorization
column: add basic colors support
Karel Zak [Mon, 21 Jul 2025 06:16:25 +0000 (08:16 +0200)]
setpriv: Improve getgroups() Portability
setpriv(1) is Linux-only, and on Linux, getgroups() returns at least one group.
However, it's better to use more portable and generic code patterns and assume
that getgroups() can return zero.
Fixes: https://github.com/util-linux/util-linux/issues/3654 Reported-by: Alejandro Colomar <alx@kernel.org> Signed-off-by: Karel Zak <kzak@redhat.com>
column: call gettext() on an error message only when it gets printed
Just mark error messages for translation, with gettext_noop(), and pass
them untranslated to the subroutines. Then call gettext() on such a
message only when an error occurs and the message gets printed.
The ranges are constructed greedily; in general it is difficult to
construct a minimal list.
% ./taskset -c 0-63:3,0-63:4 ./taskset -pc 0
pid 3926213's current affinity list: 0,3,4-8:2,9-15:3,16-20:2,21-27:3,28-32:2,33-39:3,40-44:2,45
chrt: do not try to interpret any other option as a PID either
When doing, for example, `chrt --pid --max`, it would report:
chrt: invalid PID argument: '--max'
This mistakenly gave the impression that the PID argument has to follow
directly after the --pid option.
Avoid this by delaying the parsing of a PID until after all options have
been parsed. Temporarily set 'ctl->pid' to zero to indicate that a PID
needs to be read.
After this change, `chrt --pid --max` will simply report the minimum and
maximum valid priorities. And `chrt --pid -v`:
chrt: too few arguments
Also, add a missing call of gettext() for the other error message.
chrt: simplify the other check for too few arguments
Without option --pid, always at least two arguments are needed:
the <priority> value and a <command>. (The 'need_prio' variable
is relevant only for the --pid case.)
Jesse Rosenstock [Fri, 27 Jun 2025 07:47:35 +0000 (09:47 +0200)]
taskset: Accept 0 pid for current process
This is useful to print the current mask without using `$$`: `taskset -p 0`.
It is also helpful to test taskset: `taskset -c 1-4 taskset -p 0`.
This is not easy with `$$`.
sched_setaffinity(2)/sched_getaffinity(2) accept 0 for the calling
thread, so this seems consistent.
As an implementation detail, we replace 0 with getpid(), so the existing
pid != 0 <==> "will exec" logic continues to work unchanged.
A reasonable alternative would be to interpret just `taskset` (currently
an error) as printing the current mask. This seems less orthogonal,
and a better use may be found for plain `taskset` in the future.
bash-completion: fix function name of enosys completion
The function "_enosys_module" referenced by the completion setting on
the last line of "bash-completion/enosys" is not defined in the
current master. As reported in Ref. [1], this causes the following
error on an attempt at argument completion for the "enosys" command:
Also, the function "_waitpid_module" defined in
"bash-completion/enosys" overwrites another completion function of the
same name defined in "bash-completion/waitpid". This patch renames
the function in "bash-completion/enosys" to the correct one,
"_enosys_module".
Karel Zak [Tue, 1 Jul 2025 07:57:25 +0000 (09:57 +0200)]
Merge branch 'PR/Benno-27Jun' of https://github.com/karelzak/util-linux-work
* 'PR/Benno-27Jun' of https://github.com/karelzak/util-linux-work:
lsclocks: (man) remove stray backslash, and correct short form of --time
script: (man,usage) correct the markup of the synopsis
chrt: (man) mark "argument" as optional, and unabbreviate it in usage
chrt: (man) correct the short form of --ext, from -d to -e
Karel Zak [Tue, 1 Jul 2025 07:56:22 +0000 (09:56 +0200)]
Merge branch 'PR/strv-prefix' of https://github.com/karelzak/util-linux-work
* 'PR/strv-prefix' of https://github.com/karelzak/util-linux-work:
lib/strutils: add ul_ prefix to strrep() and strrem() functions
lib/strutils: add ul_ prefix to split() function
lib/strutils: add ul_ prefix to strappend() functions
lib/strutils: add ul_ prefix to strconcat() functions
lib/strutils: add ul_ prefix to startswith() and endswith()
lib/strv: use ul_ prefix for strv functions
Karel Zak [Mon, 30 Jun 2025 10:20:13 +0000 (12:20 +0200)]
more: temporarily ignore stdin when waiting for stderr
more waits for user commands on stderr, but at the same time, it
monitors sigalfd and stdin (for data and POLLHUP|POLLNVAL). We need to
temporarily ignore stdin if there is new data waiting for read()
(e.g., dmesg | more); otherwise, more_key_command() will end in a busy
loop.
Fixes: https://github.com/util-linux/util-linux/issues/3634 Signed-off-by: Karel Zak <kzak@redhat.com>
projects / thirdparty / util-linux.git / log
