1 From: Peter Zijlstra <a.p.zijlstra@chello.nl>
2 Subject: nfs: disable data cache revalidation for swapfiles
4 References: FATE#303834
7 http://lkml.org/lkml/2006/8/25/348
9 Disable NFS data cache revalidation on swap files since it doesn't really
10 make sense to have other clients change the file while you are using it.
12 Thereby we can stop setting PG_private on swap pages, since there ought to
13 be no further races with invalidate_inode_pages2() to deal with.
15 And since we cannot set PG_private we cannot use page->private (which is
16 already used by PG_swapcache pages anyway) to store the nfs_page. Thus
17 augment the new nfs_page_find_request logic.
19 Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
20 Acked-by: Neil Brown <neilb@suse.de>
21 Acked-by: Suresh Jayaraman <sjayaraman@suse.de>
24 fs/nfs/inode.c | 6 ++++
25 fs/nfs/write.c | 71 ++++++++++++++++++++++++++++++++++++++++++++++-----------
26 2 files changed, 64 insertions(+), 13 deletions(-)
30 @@ -824,6 +824,12 @@ int nfs_revalidate_mapping_nolock(struct
31 struct nfs_inode *nfsi = NFS_I(inode);
35 + * swapfiles are not supposed to be shared.
37 + if (IS_SWAPFILE(inode))
40 if ((nfsi->cache_validity & NFS_INO_REVAL_PAGECACHE)
41 || nfs_attribute_timeout(inode) || NFS_STALE(inode)) {
42 ret = __nfs_revalidate_inode(NFS_SERVER(inode), inode);
45 @@ -104,25 +104,62 @@ static void nfs_context_set_write_error(
46 set_bit(NFS_CONTEXT_ERROR_WRITE, &ctx->flags);
49 -static struct nfs_page *nfs_page_find_request_locked(struct page *page)
50 +static struct nfs_page *
51 +__nfs_page_find_request_locked(struct nfs_inode *nfsi, struct page *page, int get)
53 struct nfs_page *req = NULL;
55 - if (PagePrivate(page)) {
56 + if (PagePrivate(page))
57 req = (struct nfs_page *)page_private(page);
59 - kref_get(&req->wb_kref);
61 + else if (unlikely(PageSwapCache(page)))
62 + req = radix_tree_lookup(&nfsi->nfs_page_tree, page_file_index(page));
65 + kref_get(&req->wb_kref);
70 +static inline struct nfs_page *
71 +nfs_page_find_request_locked(struct nfs_inode *nfsi, struct page *page)
73 + return __nfs_page_find_request_locked(nfsi, page, 1);
76 +static int __nfs_page_has_request(struct page *page)
78 + struct inode *inode = page_file_mapping(page)->host;
79 + struct nfs_page *req = NULL;
81 + spin_lock(&inode->i_lock);
82 + req = __nfs_page_find_request_locked(NFS_I(inode), page, 0);
83 + spin_unlock(&inode->i_lock);
86 + * hole here plugged by the caller holding onto PG_locked
92 +static inline int nfs_page_has_request(struct page *page)
94 + if (PagePrivate(page))
97 + if (unlikely(PageSwapCache(page)))
98 + return __nfs_page_has_request(page);
103 static struct nfs_page *nfs_page_find_request(struct page *page)
105 struct inode *inode = page_file_mapping(page)->host;
106 struct nfs_page *req = NULL;
108 spin_lock(&inode->i_lock);
109 - req = nfs_page_find_request_locked(page);
110 + req = nfs_page_find_request_locked(NFS_I(inode), page);
111 spin_unlock(&inode->i_lock);
114 @@ -226,7 +263,7 @@ static int nfs_page_async_flush(struct n
116 spin_lock(&inode->i_lock);
118 - req = nfs_page_find_request_locked(page);
119 + req = nfs_page_find_request_locked(NFS_I(inode), page);
121 spin_unlock(&inode->i_lock);
123 @@ -349,8 +386,14 @@ static int nfs_inode_add_request(struct
124 if (nfs_have_delegation(inode, FMODE_WRITE))
127 - SetPagePrivate(req->wb_page);
128 - set_page_private(req->wb_page, (unsigned long)req);
130 + * Swap-space should not get truncated. Hence no need to plug the race
131 + * with invalidate/truncate.
133 + if (likely(!PageSwapCache(req->wb_page))) {
134 + SetPagePrivate(req->wb_page);
135 + set_page_private(req->wb_page, (unsigned long)req);
138 kref_get(&req->wb_kref);
139 radix_tree_tag_set(&nfsi->nfs_page_tree, req->wb_index,
140 @@ -372,8 +415,10 @@ static void nfs_inode_remove_request(str
141 BUG_ON (!NFS_WBACK_BUSY(req));
143 spin_lock(&inode->i_lock);
144 - set_page_private(req->wb_page, 0);
145 - ClearPagePrivate(req->wb_page);
146 + if (likely(!PageSwapCache(req->wb_page))) {
147 + set_page_private(req->wb_page, 0);
148 + ClearPagePrivate(req->wb_page);
150 radix_tree_delete(&nfsi->nfs_page_tree, req->wb_index);
153 @@ -577,7 +622,7 @@ static struct nfs_page *nfs_try_to_updat
154 spin_lock(&inode->i_lock);
157 - req = nfs_page_find_request_locked(page);
158 + req = nfs_page_find_request_locked(NFS_I(inode), page);
162 @@ -1488,7 +1533,7 @@ int nfs_wb_page_cancel(struct inode *ino
166 - if (!PagePrivate(page))
167 + if (!nfs_page_has_request(page))
169 ret = nfs_sync_mapping_wait(page_file_mapping(page), &wbc, FLUSH_INVALIDATE);