]> git.ipfire.org Git - ipfire-2.x.git/commitdiff
dns.cgi: Revert "dns.cgi: Fixes bug#12395 - German umlauts not correctly displayed...
authorAdolf Belka <adolf.belka@ipfire.org>
Mon, 11 Mar 2024 12:19:08 +0000 (13:19 +0100)
committerMichael Tremer <michael.tremer@ipfire.org>
Tue, 12 Mar 2024 09:30:50 +0000 (09:30 +0000)
- This reverts commit 7c6ff5ff12331a53f416080a44c8d6145e78bfac
- That commit removed the cleanhtml command which is not advised, based on feedback from
   Michael Tremer from other patch submissions as it creates a potential security problem.

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
html/cgi-bin/dns.cgi

index f3dd5c7a915e38bc6089129121ad51bef76e5427..0a34d3fd6c59e3c430a7b406dca4994adf966d98 100644 (file)
@@ -141,6 +141,8 @@ if (($cgiparams{'SERVERS'} eq $Lang::tr{'save'}) || ($cgiparams{'SERVERS'} eq $L
 
        # Go further if there was no error.
        if ( ! $errormessage) {
+               # Check if a remark has been entered.
+               $cgiparams{'REMARK'} = &Header::cleanhtml($cgiparams{'REMARK'});
 
                my %dns_servers = ();
                my $id;