]> git.ipfire.org Git - ipfire-2.x.git/commitdiff
dhcp.cgi: Fix incorrect { placement from patch 3724
authorAdolf Belka <adolf.belka@ipfire.org>
Tue, 16 Feb 2021 13:30:10 +0000 (14:30 +0100)
committerMichael Tremer <michael.tremer@ipfire.org>
Tue, 16 Feb 2021 15:02:33 +0000 (15:02 +0000)
- When patch 3724 was created for bug #10743 a curly bracket was placed in the wrong place
This results in the overlap of two if loops meaning that there will be no validity
check carried out on Default Lease Time if Deny Known Clients is not checked.
- This patch moves the { bracket to the right location.

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
html/cgi-bin/dhcp.cgi

index 2ebdde8187ea11ce136ead153ed5e2e1fceba5af..867614f2a7ccd26048f503b79f1c1acad4aa1ec0 100644 (file)
@@ -180,12 +180,12 @@ if ($dhcpsettings{'ACTION'} eq $Lang::tr{'save'}) {
                if (($dhcpsettings{"START_ADDR_${itf}"}) eq '' && ($dhcpsettings{"END_ADDR_${itf}"}) eq '') {
                        $errormessage = "DHCP on ${itf}: " . $Lang::tr{'dhcp valid range required when deny known clients checked'};
                        goto ERROR;
+               }
            }
 
            if (!($dhcpsettings{"DEFAULT_LEASE_TIME_${itf}"} =~ /^\d+$/)) {
                $errormessage = "DHCP on ${itf}: " . $Lang::tr{'invalid default lease time'} . $dhcpsettings{'DEFAULT_LEASE_TIME_${itf}'};
                goto ERROR;
-               }
            }
 
            if (!($dhcpsettings{"MAX_LEASE_TIME_${itf}"} =~ /^\d+$/)) {