]> git.ipfire.org Git - ipfire-2.x.git/commitdiff
firewall.cgi: Allow to creating input rules from Orange to another zone.
authorStefan Schantl <stefan.schantl@ipfire.org>
Fri, 16 Jul 2021 16:35:58 +0000 (18:35 +0200)
committerArne Fitzenreiter <arne_f@ipfire.org>
Sun, 5 Sep 2021 08:40:45 +0000 (08:40 +0000)
It was not able to create a firewall rule from the orange network to a
different network address of the firewall. ( For example: Orange -> IPFire's green address)

These rules always have been handled as FORWARD rules which is totaly
wrong.

Fixes #12265.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Tested-by: Peter Müller <peter.mueller@ipfire.org>
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>
Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
html/cgi-bin/firewall.cgi

index 0eace5f1130caa2b3354df55109537ac1e40726d..220030348026d7c0533bfcd784d1d7c7642aa555 100644 (file)
@@ -247,7 +247,7 @@ if ($fwdfwsettings{'ACTION'} eq 'saverule')
                $errormessage=$Lang::tr{'fwdfw err same'};
        }
        # INPUT part
-       if ($fwdfwsettings{'grp2'} eq 'ipfire' && $fwdfwsettings{$fwdfwsettings{'grp1'}} ne 'ORANGE'){
+       if ($fwdfwsettings{'grp2'} eq 'ipfire'{
                $fwdfwsettings{'config'}=$configinput;
                $fwdfwsettings{'chain'} = 'INPUTFW';
                $maxkey=&General::findhasharraykey(\%configinputfw);