]> git.ipfire.org Git - ipfire-2.x.git/commitdiff
Merge remote-tracking branch 'stevee/next' into next
authorMichael Tremer <michael.tremer@ipfire.org>
Fri, 23 Nov 2012 11:58:40 +0000 (12:58 +0100)
committerMichael Tremer <michael.tremer@ipfire.org>
Fri, 23 Nov 2012 11:58:40 +0000 (12:58 +0100)
1  2 
html/cgi-bin/ovpnmain.cgi

index ca43e7dd5df960e82346aef0bd4e533aa3a0d89f,d1b268649269b8c385c46318663a3b7c95a65050..9dd901138cf2c8ca51014cb59c9e0ea6425a6510
@@@ -321,6 -321,7 +321,6 @@@ sub disallowreserve
        return;
  }
  
 -
  sub writeserverconf {
      my %sovpnsettings = ();  
      my @temp = ();  
        { print CONF "$sovpnsettings{'DDEVICE'}-mtu 1500\n"; }
      elsif ($sovpnsettings{'FRAGMENT'} ne '' && $sovpnsettings{'DPROTOCOL'} ne 'tcp') 
        { print CONF "$sovpnsettings{'DDEVICE'}-mtu 1500\n"; }
-     elsif (($sovpnsettings{'PMTU_DISCOVERY'} ne 'off') || ($sovpnsettings{'PMTU_DISCOVERY'} ne ''))
+     elsif (($sovpnsettings{'PMTU_DISCOVERY'} eq 'yes') ||
+          ($sovpnsettings{'PMTU_DISCOVERY'} eq 'maybe') ||
+          ($sovpnsettings{'PMTU_DISCOVERY'} eq 'no' ))
        { print CONF "$sovpnsettings{'DDEVICE'}-mtu 1500\n"; } 
      else 
        { print CONF "$sovpnsettings{'DDEVICE'}-mtu $sovpnsettings{'DMTU'}\n"; }
        print CONF "fragment $sovpnsettings{'FRAGMENT'}\n";   
      }
  
-     if (($sovpnsettings{PMTU_DISCOVERY} ne 'off') || ($sovpnsettings{'PMTU_DISCOVERY'} ne '')) {
-       print CONF "mtu-disc $sovpnsettings{'PMTU_DISCOVERY'}\n";
+     # Check if a valid operating mode has been choosen and use it.
+     if (($sovpnsettings{'PMTU_DISCOVERY'} eq 'yes') ||
+       ($sovpnsettings{'PMTU_DISCOVERY'} eq 'maybe') ||
+       ($sovpnsettings{'PMTU_DISCOVERY'} eq 'no' )) {
+               print CONF "mtu-disc $sovpnsettings{'PMTU_DISCOVERY'}\n";
      }
  
      if ($sovpnsettings{KEEPALIVE_1} > 0 && $sovpnsettings{KEEPALIVE_2} > 0) { 
@@@ -494,36 -500,21 +499,36 @@@ sub addccdne
        my $checkup;
        my $ccdip;
        my $baseaddress;
 -      if(!&General::validhostname($ccdname)){
 +      
 +      
 +      #check name     
 +      if ($ccdname eq '') 
 +      {
 +              $errormessage=$errormessage.$Lang::tr{'ccd err name'}."<br>";
 +              return
 +      }
 +      
 +      if(!&General::validhostname($ccdname))
 +      {
                $errormessage=$Lang::tr{'ccd err invalidname'};
                return;
        }
 -      #check ip
 -      if (&General::validipandmask($ccdnet)){
 -                      $ccdnet=&General::iporsubtocidr($ccdnet);       
 -      }else{
 +              
 +      ($ccdip,$subcidr) = split (/\//,$ccdnet);
 +      $subcidr=&General::iporsubtocidr($subcidr);
 +      #check subnet
 +      if ($subcidr > 30)
 +      {
                $errormessage=$Lang::tr{'ccd err invalidnet'};
                return;
        }
 -      ($ccdip,$subcidr) = split (/\//,$ccdnet);
 -      if ($ccdname eq '') {
 -              $errormessage=$errormessage.$Lang::tr{'ccd err name'}."<br>";
 +      #check ip
 +      if (!&General::validipandmask($ccdnet)){
 +              $errormessage=$Lang::tr{'ccd err invalidnet'};
 +              return;
        }
 +      
 +      
        #check if we try to use same network as ovpn server
        if (&General::iporsubtocidr($ccdnet) eq &General::iporsubtocidr($ovpnsubnet)) {
                        $errormessage=$errormessage.$Lang::tr{'ccd err isovpnnet'}."<br>";
@@@ -865,7 -856,10 +870,10 @@@ if ($cgiparams{'ACTION'} eq $Lang::tr{'
        $vpnsettings{'MSSFIX'} = $cgiparams{'MSSFIX'};
      }
  
-     if ($cgiparams{'PMTU_DISCOVERY'} ne 'off') {
+     if (($cgiparams{'PMTU_DISCOVERY'} eq 'yes') ||
+         ($cgiparams{'PMTU_DISCOVERY'} eq 'maybe') ||
+         ($cgiparams{'PMTU_DISCOVERY'} eq 'no' )) {
        if (($cgiparams{'MSSFIX'} eq 'on') || ($cgiparams{'FRAGMENT'} ne '')) {
                $errormessage = $Lang::tr{'ovpn mtu-disc with mssfix or fragment'};
                goto ADV_ERROR;
@@@ -1018,7 -1012,11 +1026,11 @@@ unless(-d "${General::swroot}/ovpn/n2nc
    if ($cgiparams{'FRAGMENT'} ne '') {print SERVERCONF "fragment $cgiparams{'FRAGMENT'}\n";} 
    if ($cgiparams{'MSSFIX'} eq 'on') {print SERVERCONF "mssfix\n"; }; 
    }
-   if (($cgiparams{'PMTU_DISCOVERY'} ne 'off') || ($cgiparams{'PMTU_DISCOVERY'} ne '')) {
+   # Check if a valid operating mode has been choosen and use it.
+   if (($cgiparams{'PMTU_DISCOVERY'} eq 'yes') ||
+       ($cgiparams{'PMTU_DISCOVERY'} eq 'maybe') ||
+       ($cgiparams{'PMTU_DISCOVERY'} eq 'no' )) {
        if(($cgiparams{'MSSFIX'} ne 'on') || ($cgiparams{'FRAGMENT'} eq '')) {
                if($cgiparams{'MTU'} eq '1500') {
                        print SERVERCONF "mtu-disc $cgiparams{'PMTU_DISCOVERY'}\n";
@@@ -1103,13 -1101,18 +1115,18 @@@ unless(-d "${General::swroot}/ovpn/n2nc
    if ($cgiparams{'FRAGMENT'} ne '') {print CLIENTCONF "fragment $cgiparams{'FRAGMENT'}\n";}
    if ($cgiparams{'MSSFIX'} eq 'on') {print CLIENTCONF "mssfix\n"; }; 
    }
-    if (($cgiparams{'PMTU_DISCOVERY'} ne 'off') || ($cgiparams{'PMTU_DISCOVERY'} ne '')) {
+   # Check if a valid operating mode has been choosen and use it.
+   if (($cgiparams{'PMTU_DISCOVERY'} eq 'yes') ||
+       ($cgiparams{'PMTU_DISCOVERY'} eq 'maybe') ||
+       ($cgiparams{'PMTU_DISCOVERY'} eq 'no' )) {
          if(($cgiparams{'MSSFIX'} ne 'on') || ($cgiparams{'FRAGMENT'} eq '')) {
                if ($cgiparams{'MTU'} eq '1500') {
                        print CLIENTCONF "mtu-disc $cgiparams{'PMTU_DISCOVERY'}\n";
                }
          }
-   } 
+   }
+  
    print CLIENTCONF "ns-cert-type server\n";   
    print CLIENTCONF "# Auth. Client\n"; 
    print CLIENTCONF "tls-client\n"; 
@@@ -2037,7 -2040,9 +2054,9 @@@ if ($confighash{$cgiparams{'KEY'}}[3] e
     if ($confighash{$cgiparams{'KEY'}}[24] ne '') {print CLIENTCONF "fragment $confighash{$cgiparams{'KEY'}}[24]\n";}
     if ($confighash{$cgiparams{'KEY'}}[23] eq 'on') {print CLIENTCONF "mssfix\n";}
     }
-    if ($confighash{$cgiparams{'KEY'}}[38] ne 'off') {
+    if (($confighash{$cgiparams{'KEY'}}[38] eq 'yes') ||
+        ($confighash{$cgiparams{'KEY'}}[38] eq 'maybe') ||
+        ($confighash{$cgiparams{'KEY'}}[38] eq 'no' )) {
        if (($confighash{$cgiparams{'KEY'}}[23] ne 'on') || ($confighash{$cgiparams{'KEY'}}[24] eq '')) {
                if ($tunmtu eq '1500' ) {
                        print CLIENTCONF "mtu-disc $confighash{$cgiparams{'KEY'}}[38]\n";
@@@ -2110,7 -2115,9 +2129,9 @@@ els
        { print CLIENTCONF "$vpnsettings{'DDEVICE'}-mtu 1500\n"; }
      elsif ($vpnsettings{MSSFIX} eq 'on')
        { print CLIENTCONF "$vpnsettings{'DDEVICE'}-mtu 1500\n"; }
-     elsif (($vpnsettings{PMTU_DISCOVERY} ne 'off') || ($cgiparams{'PMTU_DISCOVERY'} ne ''))
+     elsif (($vpnsettings{'PMTU_DISCOVERY'} eq 'yes') ||
+            ($vpnsettings{'PMTU_DISCOVERY'} eq 'maybe') ||
+            ($vpnsettings{'PMTU_DISCOVERY'} eq 'no' )) 
        { print CLIENTCONF "$vpnsettings{'DDEVICE'}-mtu 1500\n"; }
      else
        { print CLIENTCONF "$vpnsettings{'DDEVICE'}-mtu $vpnsettings{'DMTU'}\r\n"; }
      if ($vpnsettings{FRAGMENT} ne '' && $vpnsettings{DPROTOCOL} ne 'tcp' ) {
        print CLIENTCONF "fragment $vpnsettings{'FRAGMENT'}\r\n";
      }
-     if (($vpnsettings{PMTU_DISCOVERY} ne 'off') || ($cgiparams{'PMTU_DISCOVERY'} ne '')) {
+     # Check if a valid operating mode has been choosen and use it.
+     if (($vpnsettings{'PMTU_DISCOVERY'} eq 'yes') ||
+         ($vpnsettings{'PMTU_DISCOVERY'} eq 'maybe') ||
+         ($vpnsettings{'PMTU_DISCOVERY'} eq 'no' )) {
        if(($vpnsettings{MSSFIX} ne 'on') || ($vpnsettings{FRAGMENT} eq '')) {
                print CLIENTCONF "mtu-disc $vpnsettings{'PMTU_DISCOVERY'}\n";
        }
                }
        }
        &General::writehasharray("${General::swroot}/ovpn/ccdroute2", \%ccdroute2hash);
 -      
 +      &writeserverconf;
        
        
  # CCD end 
@@@ -2500,21 -2511,7 +2525,21 @@@ if ( -e "/var/run/openvpn.pid")
  print"        <br><b><font color='#990000'>$Lang::tr{'attention'}:</b></font><br>
                $Lang::tr{'server restart'}<br><br>
                <hr>";
 -}
 +              print<<END
 +<table width='100%'>
 +<tr>
 +    <td>&nbsp;</td>
 +    <td allign='center'><input type='submit' name='ACTION' value='$Lang::tr{'save-adv-options'}' disabled='disabled' /></td>
 +    <td allign='center'><input type='submit' name='ACTION' value='$Lang::tr{'cancel-adv-options'}' /></td>
 +    <td>&nbsp;</td>    
 +</tr>
 +</table>    
 +</form>
 +END
 +;             
 +              
 +              
 +}else{
  
  print<<END
  <table width='100%'>
  </form>
  END
  ;                                
 -
 +}
      &Header::closebox();
  #    print "<div align='center'><a href='/cgi-bin/ovpnmain.cgi'>$Lang::tr{'back'}</a></div>";
      &Header::closebigbox();
@@@ -3246,7 -3243,7 +3271,7 @@@ if ($confighash{$cgiparams{'KEY'}}) 
                $cgiparams{'ENABLED'}                   = $confighash{$cgiparams{'KEY'}}[0];
                $cgiparams{'NAME'}                              = $confighash{$cgiparams{'KEY'}}[1];
                $cgiparams{'TYPE'}                              = $confighash{$cgiparams{'KEY'}}[3];
 -              $cgiparams{'AUTH'}                      = $confighash{$cgiparams{'KEY'}}[4];
 +              $cgiparams{'AUTH'}                              = $confighash{$cgiparams{'KEY'}}[4];
                $cgiparams{'PSK'}                               = $confighash{$cgiparams{'KEY'}}[5];
                $cgiparams{'SIDE'}                              = $confighash{$cgiparams{'KEY'}}[6];
                $cgiparams{'LOCAL_SUBNET'}              = $confighash{$cgiparams{'KEY'}}[8];
                $cgiparams{'REMOTE_SUBNET'}     = $confighash{$cgiparams{'KEY'}}[11];
                $cgiparams{'OVPN_MGMT'}                 = $confighash{$cgiparams{'KEY'}}[22];
                $cgiparams{'MSSFIX'}                    = $confighash{$cgiparams{'KEY'}}[23];
 -              $cgiparams{'FRAGMENT'}          = $confighash{$cgiparams{'KEY'}}[24];
 +              $cgiparams{'FRAGMENT'}                  = $confighash{$cgiparams{'KEY'}}[24];
                $cgiparams{'REMARK'}                    = $confighash{$cgiparams{'KEY'}}[25];
 -              $cgiparams{'INTERFACE'}         = $confighash{$cgiparams{'KEY'}}[26];
 +              $cgiparams{'INTERFACE'}                 = $confighash{$cgiparams{'KEY'}}[26];
                $cgiparams{'OVPN_SUBNET'}               = $confighash{$cgiparams{'KEY'}}[27];
                $cgiparams{'PROTOCOL'}                  = $confighash{$cgiparams{'KEY'}}[28];
 -              $cgiparams{'DEST_PORT'}         = $confighash{$cgiparams{'KEY'}}[29];
 +              $cgiparams{'DEST_PORT'}                 = $confighash{$cgiparams{'KEY'}}[29];
                $cgiparams{'COMPLZO'}                   = $confighash{$cgiparams{'KEY'}}[30];
                $cgiparams{'MTU'}                               = $confighash{$cgiparams{'KEY'}}[31];
 -              $cgiparams{'CHECK1'}            = $confighash{$cgiparams{'KEY'}}[32];
 +              $cgiparams{'CHECK1'}                    = $confighash{$cgiparams{'KEY'}}[32];
                my $name=$cgiparams{'CHECK1'}   ;
                $cgiparams{$name}                               = $confighash{$cgiparams{'KEY'}}[33];
                $cgiparams{'RG'}                                = $confighash{$cgiparams{'KEY'}}[34];
                $cgiparams{'CCD_DNS1'}                  = $confighash{$cgiparams{'KEY'}}[35];
                $cgiparams{'CCD_DNS2'}                  = $confighash{$cgiparams{'KEY'}}[36];
                $cgiparams{'CCD_WINS'}                  = $confighash{$cgiparams{'KEY'}}[37];
 -              $cgiparams{'PMTU_DISCOVERY'} = $confighash{$cgiparams{'KEY'}}[38];
 +              $cgiparams{'PMTU_DISCOVERY'}    = $confighash{$cgiparams{'KEY'}}[38];
        } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'save'}) {
        $cgiparams{'REMARK'} = &Header::cleanhtml($cgiparams{'REMARK'});
        
  #A.Marx CCD check iroute field and convert it to decimal
 -
 +if ($cgiparams{'TYPE'} eq 'host') {
        my @temp=();
        my %ccdroutehash=();
        my $keypoint=0;
                        chomp($val);
                        $val=~s/\s*$//g; 
                        my($ip,$cidr) = split(/\//,$val);
 +                      $ip=&General::getnetworkip($ip,&General::iporsubtocidr($cidr));
                        $cidr=&General::iporsubtodec($cidr);
                        
                        #check if iroute exists in ccdroute
                        }
                                                                                                                                        
                        #check for existing network IP's
 -                      if ((&General::IpInSubnet ($ip,$netsettings{GREEN_NETADDRESS},$netsettings{GREEN_NETMASK}) && $netsettings{GREEN_NETADDRESS} ne '0.0.0.0')|| 
 -                              (&General::IpInSubnet ($ip,$netsettings{RED_NETADDRESS},$netsettings{RED_NETMASK}) && $netsettings{RED_NETADDRESS} ne '0.0.0.0')||
 -                              (&General::IpInSubnet ($ip,$netsettings{BLUE_NETADDRESS},$netsettings{BLUE_NETMASK}) && $netsettings{BLUE_NETADDRESS} ne '0.0.0.0' && $netsettings{BLUE_NETADDRESS} gt '')||
 -                              (&General::IpInSubnet ($ip,$netsettings{ORANGE_NETADDRESS},$netsettings{ORANGE_NETMASK}) && $netsettings{ORANGE_NETADDRESS} ne '0.0.0.0' && $netsettings{ORANGE_NETADDRESS} gt '' )){
 -                              $errormessage="$ip USED FOR SYSTEM!";
 +                      if (&General::IpInSubnet ($ip,$netsettings{GREEN_NETADDRESS},$netsettings{GREEN_NETMASK}) && $netsettings{GREEN_NETADDRESS} ne '0.0.0.0')
 +                      {
 +                              $errormessage=$Lang::tr{'ccd err green'};
 +                              goto VPNCONF_ERROR;
 +                      }elsif(&General::IpInSubnet ($ip,$netsettings{RED_NETADDRESS},$netsettings{RED_NETMASK}) && $netsettings{RED_NETADDRESS} ne '0.0.0.0')
 +                      {
 +                              $errormessage=$Lang::tr{'ccd err red'};
 +                              goto VPNCONF_ERROR;
 +                      }elsif(&General::IpInSubnet ($ip,$netsettings{BLUE_NETADDRESS},$netsettings{BLUE_NETMASK}) && $netsettings{BLUE_NETADDRESS} ne '0.0.0.0' && $netsettings{BLUE_NETADDRESS} gt '')
 +                      {
 +                              $errormessage=$Lang::tr{'ccd err blue'};
 +                              goto VPNCONF_ERROR;
 +                      }elsif(&General::IpInSubnet ($ip,$netsettings{ORANGE_NETADDRESS},$netsettings{ORANGE_NETMASK}) && $netsettings{ORANGE_NETADDRESS} ne '0.0.0.0' && $netsettings{ORANGE_NETADDRESS} gt '' )
 +                      {
 +                              $errormessage=$Lang::tr{'ccd err orange'};
                                goto VPNCONF_ERROR;
                        }
 -                      
 -                      
 -                      
 +                                              
                        if (&General::validipandmask($val)){
                                $ccdroutehash{$keypoint}[$i] = $ip."/".$cidr;
                        }else{
        }
        undef @temp;
        #check route field and convert it to decimal
 -      
        my $val=0;
        my $i=1;
 -      
        &General::readhasharray("${General::swroot}/ovpn/ccdroute2", \%ccdroute2hash);
 -      if($cgiparams{'IFROUTE'} eq $Lang::tr{'ccd none'} || $cgiparams{'IFROUTE'} eq '') { 
 -                      undef $cgiparams{'IFROUTE'};
 -                      foreach my $key (keys %ccdroute2hash){
 -                              if ($ccdroute2hash{$key}[0] eq $cgiparams{'NAME'}) {
 -                                      delete $ccdroute2hash{$key};
 -                              }
 -                      }
 -                      &General::writehasharray("${General::swroot}/ovpn/ccdroute2", \%ccdroute2hash);
 -      }else{
 -              #find key to use
 -              foreach my $key (keys %ccdroute2hash) {
 -                      if ($ccdroute2hash{$key}[0] eq $cgiparams{'NAME'}) {
 -                              $keypoint=$key;
 -                              delete $ccdroute2hash{$key};
 -                      }else{
 -                              $keypoint = &General::findhasharraykey (\%ccdroute2hash);
 -                              &General::writehasharray("${General::swroot}/ovpn/ccdroute", \%ccdroutehash);
 -                              &writeserverconf;
 -                      }
 +      #find key to use
 +      foreach my $key (keys %ccdroute2hash) {
 +              if ($ccdroute2hash{$key}[0] eq $cgiparams{'NAME'}) {
 +                      $keypoint=$key;
 +                      delete $ccdroute2hash{$key};
 +              }else{
 +                      $keypoint = &General::findhasharraykey (\%ccdroute2hash);
 +                      &General::writehasharray("${General::swroot}/ovpn/ccdroute", \%ccdroutehash);
 +                      &writeserverconf;
                }
 -              $ccdroute2hash{$keypoint}[0]=$cgiparams{'NAME'};
 -              @temp = split(/\|/,$cgiparams{'IFROUTE'});
 -              my %ownnet=();
 -              &General::readhash("${General::swroot}/ethernet/settings", \%ownnet);
 -              foreach $val (@temp){
 -                      chomp($val);
 -                      $val=~s/\s*$//g; 
 -                      if ($val eq $Lang::tr{'green'})
 -                      {
 -                              $val=$ownnet{GREEN_NETADDRESS}."/".$ownnet{GREEN_NETMASK};
 -                      }
 -                      if ($val eq $Lang::tr{'blue'})
 -                      {
 -                              $val=$ownnet{BLUE_NETADDRESS}."/".$ownnet{BLUE_NETMASK};
 -                      }
 -                      if ($val eq $Lang::tr{'orange'})
 -                      {
 -                              $val=$ownnet{ORANGE_NETADDRESS}."/".$ownnet{ORANGE_NETMASK};
 -                      }
 -                      my ($ip,$cidr) = split (/\//, $val);
 +      }
 +      $ccdroute2hash{$keypoint}[0]=$cgiparams{'NAME'};
 +      if ($cgiparams{'IFROUTE'} eq ''){$cgiparams{'IFROUTE'} = $Lang::tr{'ccd none'};}
 +      @temp = split(/\|/,$cgiparams{'IFROUTE'});
 +      my %ownnet=();
 +      &General::readhash("${General::swroot}/ethernet/settings", \%ownnet);
 +      foreach $val (@temp){
 +              chomp($val);
 +              $val=~s/\s*$//g; 
 +              if ($val eq $Lang::tr{'green'})
 +              {
 +                      $val=$ownnet{GREEN_NETADDRESS}."/".$ownnet{GREEN_NETMASK};
 +              }
 +              if ($val eq $Lang::tr{'blue'})
 +              {
 +                      $val=$ownnet{BLUE_NETADDRESS}."/".$ownnet{BLUE_NETMASK};
 +              }
 +              if ($val eq $Lang::tr{'orange'})
 +              {
 +                      $val=$ownnet{ORANGE_NETADDRESS}."/".$ownnet{ORANGE_NETMASK};
 +              }
 +              my ($ip,$cidr) = split (/\//, $val);
 +              
 +              if ($val ne $Lang::tr{'ccd none'})
 +              {       
                        if (! &check_routes_push($val)){$errormessage=$errormessage."Route $val ".$Lang::tr{'ccd err routeovpn2'}." ($val)";goto VPNCONF_ERROR;}
                        if (! &check_ccdroute($val)){$errormessage=$errormessage."<br>Route $val ".$Lang::tr{'ccd err inuse'}." ($val)" ;goto VPNCONF_ERROR;}
                        if (! &check_ccdconf($val)){$errormessage=$errormessage."<br>Route $val ".$Lang::tr{'ccd err routeovpn'}." ($val)";goto VPNCONF_ERROR;}
                                $errormessage=$errormessage."Route ".$Lang::tr{'ccd invalid'}." ($val)";
                                goto VPNCONF_ERROR;
                        }
 -                      $i++;
 -              }       
 -              &General::writehasharray("${General::swroot}/ovpn/ccdroute2", \%ccdroute2hash);
 -      }
 +              }else{
 +                      $ccdroute2hash{$keypoint}[$i]='';
 +              }
 +              $i++;
 +      }       
 +      &General::writehasharray("${General::swroot}/ovpn/ccdroute2", \%ccdroute2hash);
 +
        #check dns1 ip
        if ($cgiparams{'CCD_DNS1'} ne '' &&  ! &General::validip($cgiparams{'CCD_DNS1'})) {
                        $errormessage=$errormessage."<br>".$Lang::tr{'invalid input for dhcp dns'}." 1";
                        $errormessage=$errormessage."<br>".$Lang::tr{'invalid input for dhcp wins'};
                        goto VPNCONF_ERROR;
        }
 -      
 +}
  
  #CCD End
 -      
 +
        
   if ($cgiparams{'TYPE'} !~ /^(host|net)$/) {
            $errormessage = $Lang::tr{'connection type is invalid'};
@@@ -3914,7 -3906,7 +3939,7 @@@ if ($cgiparams{'TYPE'} eq 'net') 
            $confighash{$key}[6]        = $cgiparams{'SIDE'};
            $confighash{$key}[11]       = $cgiparams{'REMOTE_SUBNET'};
        }
 -      $confighash{$key}[8]            = $cgiparams{'LOCAL_SUBNET'};
 +      $confighash{$key}[8]                    = $cgiparams{'LOCAL_SUBNET'};
        $confighash{$key}[10]           = $cgiparams{'REMOTE'};
    if ($cgiparams{'OVPN_MGMT'} eq '') {
        $confighash{$key}[22]           = $confighash{$key}[29];
        $confighash{$key}[35]           = $cgiparams{'CCD_DNS1'};
        $confighash{$key}[36]           = $cgiparams{'CCD_DNS2'};
        $confighash{$key}[37]           = $cgiparams{'CCD_WINS'};
 -      $confighash{$key}[38]           = $cgiparams{'PMTU_DISCOVERY'};
 +      $confighash{$key}[38]                   = $cgiparams{'PMTU_DISCOVERY'};
  
  
        &General::writehasharray("${General::swroot}/ovpn/ovpnconfig", \%confighash);
                                print CCDRWCONF "\n#Redirect Gateway: \n#All IP traffic is redirected through the vpn \n";
                                print CCDRWCONF "push redirect-gateway\n";
                        }
 +                      &General::readhasharray("${General::swroot}/ovpn/ccdroute", \%ccdroutehash);
                        if ($cgiparams{'IR'} ne ''){
                                print CCDRWCONF "\n#Client routes these Networks (behind Client)\n";
                                foreach my $key (keys %ccdroutehash){
                                        }
                                }
                        }
 +                      if ($cgiparams{'IFROUTE'} eq $Lang::tr{'ccd none'} ){$cgiparams{'IFROUTE'}='';}
                        if ($cgiparams{'IFROUTE'} ne ''){
                                print CCDRWCONF "\n#Client gets routes to these Networks (behind IPFIRE)\n";
                                foreach my $key (keys %ccdroute2hash){
                                                        if($ccdroute2hash{$key}[$i] eq $Lang::tr{'blue'}){
                                                                my %blue=();
                                                                &General::readhash("${General::swroot}/ethernet/settings", \%blue);
 -                                                              print CCDRWCONF "push \"route $blue{BLUE_ADDRESS}  $blue{BLUE_NETMASK}\n";
 +                                                              print CCDRWCONF "push \"route $blue{BLUE_ADDRESS} $blue{BLUE_NETMASK}\n";
                                                        }elsif($ccdroute2hash{$key}[$i] eq $Lang::tr{'orange'}){
                                                                my %orange=();
                                                                &General::readhash("${General::swroot}/ethernet/settings", \%orange);
        <tr><td colspan='4'><br></td></tr>
        <tr><td valign='top' rowspan='3'>$Lang::tr{'ccd iroute2'}</td><td align='left' valign='top' rowspan='3'><select name='IFROUTE' style="width: 205px"; size='6' multiple>
  END
 -
 +      
 +      my $set=0;
 +      my $selorange=0;
 +      my $selblue=0;
 +      my $selgreen=0;
 +      my $helpblue=0;
 +      my $helporange=0;
 +      my $other=0;
 +      my @temp=();
 +      
        our @current = ();
 -              open(FILE, "${General::swroot}/main/routing") ;
 -          @current = <FILE>;
 -          close (FILE);
 -              &General::readhasharray ("${General::swroot}/ovpn/ccdroute2", \%ccdroute2hash);
 -              my $set=0;
 -              my $selorange=0;
 -              my $selblue=0;
 -              my $helpblue=0;
 -              my $helporange=0;
 -              print"<option>$Lang::tr{'ccd none'}</option>";
 -              print"<option selected>$Lang::tr{'green'}</option>";
 -                              
 -              foreach my $line (@current) {
 -                      chomp($line);                           # remove newline
 -                      my @temp=split(/\,/,$line);
 -                      $temp[1] = '' unless defined $temp[1]; # not always populated
 -                      my ($a,$b) = split(/\//,$temp[1]);
 -                      $temp[1] = $a."/".&General::iporsubtocidr($b);
 -                      foreach my $key (keys %ccdroute2hash) {
 -                              if($ccdroute2hash{$key}[0] eq $cgiparams{'NAME'}){
 -                                      foreach my $i (1 .. $#{$ccdroute2hash{$key}}) {
 -                                                                                      
 -                                                      if($ccdroute2hash{$key}[$i] eq $a."/".&General::iporsubtodec($b)){
 -                                                              $set=1;
 -                                                      }
 -                                                      if (&haveBlueNet()){
 -                                                              if($netsettings{'BLUE_NETADDRESS'}."/".&General::iporsubtodec($netsettings{'BLUE_NETMASK'}) eq $ccdroute2hash{$key}[$i]) {
 -                                                              $selblue=1;
 -                                                              
 -                                                              }
 -                                                      }
 -                                                      if (&haveOrangeNet()){
 -                                                              if($netsettings{'ORANGE_NETADDRESS'}."/".&General::iporsubtodec($netsettings{'ORANGE_NETMASK'}) eq $ccdroute2hash{$key}[$i]) {
 -                                                                      $selorange=1;
 -                                                              }
 -                                                      }
 -                                              }
 +      open(FILE, "${General::swroot}/main/routing") ;
 +      @current = <FILE>;
 +      close (FILE);
 +      &General::readhasharray ("${General::swroot}/ovpn/ccdroute2", \%ccdroute2hash);         
 +      print"<option>$Lang::tr{'ccd none'}</option>";
 +      #check if static routes are defined for client
 +      foreach my $line (@current) {
 +              chomp($line);   
 +              $line=~s/\s*$//g;                       # remove newline
 +              @temp=split(/\,/,$line);
 +              $temp[1] = '' unless defined $temp[1]; # not always populated
 +              my ($a,$b) = split(/\//,$temp[1]);
 +              $temp[1] = $a."/".&General::iporsubtocidr($b);
 +              foreach my $key (keys %ccdroute2hash) {
 +                      if($ccdroute2hash{$key}[0] eq $cgiparams{'NAME'}){
 +                              foreach my $i (1 .. $#{$ccdroute2hash{$key}}) {
 +                                      if($ccdroute2hash{$key}[$i] eq $a."/".&General::iporsubtodec($b)){
 +                                              $set=1;
 +                                      }
 +                              }
 +                      }
 +              }
 +              if ($set == '1' && $#temp != -1){ print"<option selected>$temp[1]</option>";$set=0;}elsif($set == '0' && $#temp != -1){print"<option>$temp[1]</option>";}
 +      }       
 +      #check if green,blue,orange are defined for client
 +      foreach my $key (keys %ccdroute2hash) {
 +              if($ccdroute2hash{$key}[0] eq $cgiparams{'NAME'}){
 +                      $other=1;
 +                      foreach my $i (1 .. $#{$ccdroute2hash{$key}}) {
 +                              if ($ccdroute2hash{$key}[$i] eq $netsettings{'GREEN_NETADDRESS'}."/".&General::iporsubtodec($netsettings{'GREEN_NETMASK'})){
 +                                      $selgreen=1;
 +                              }
 +                              if (&haveBlueNet()){
 +                                      if( $ccdroute2hash{$key}[$i] eq $netsettings{'BLUE_NETADDRESS'}."/".&General::iporsubtodec($netsettings{'BLUE_NETMASK'})) {
 +                                              $selblue=1;
 +                                      }
 +                              }
 +                              if (&haveOrangeNet()){
 +                                      if( $ccdroute2hash{$key}[$i] eq $netsettings{'ORANGE_NETADDRESS'}."/".&General::iporsubtodec($netsettings{'ORANGE_NETMASK'}) ) {
 +                                              $selorange=1;
                                        }
                                }
 -                              if ($set == '1'){ print"<option selected>$temp[1]</option>";$set=0;}else{print"<option>$temp[1]</option>";}
 -                              if (&haveBlueNet() && $selblue == '1'){ print"<option selected>$Lang::tr{'blue'}</option>";$selblue=0;}elsif(&haveBlueNet() && $selblue == '0'){print"<option>$Lang::tr{'blue'}</option>";}
 -                              if (&haveOrangeNet() && $selorange == '1'){ print"<option selected>$Lang::tr{'orange'}</option>";$selorange=0;}elsif(&haveOrangeNet() && $selorange == '0'){print"<option>$Lang::tr{'orange'}</option>";}
                        }
 +              }
 +      }
 +      if (&haveBlueNet() && $selblue == '1'){ print"<option selected>$Lang::tr{'blue'}</option>";$selblue=0;}elsif(&haveBlueNet() && $selblue == '0'){print"<option>$Lang::tr{'blue'}</option>";}
 +      if (&haveOrangeNet() && $selorange == '1'){ print"<option selected>$Lang::tr{'orange'}</option>";$selorange=0;}elsif(&haveOrangeNet() && $selorange == '0'){print"<option>$Lang::tr{'orange'}</option>";}                       
 +      if ($selgreen == '1' || $other == '0'){ print"<option selected>$Lang::tr{'green'}</option>";$set=0;}else{print"<option>$Lang::tr{'green'}</option>";};
 +      
        print<<END
        </select></td><td valign='top'>DNS1:</td><td valign='top'><input type='TEXT' name='CCD_DNS1' value='$cgiparams{'CCD_DNS1'}' size='30' /></td></tr>
        <tr valign='top'><td>DNS2:</td><td><input type='TEXT' name='CCD_DNS2' value='$cgiparams{'CCD_DNS2'}' size='30' /></td></tr>