wsdd: Collect static command line arguments in an array

This is easier to handle than a large number of variables.

Signed-off-by: Daniel Weismüller <daniel.weismueller@ipfire.org>

diff --git a/src/initscripts/packages/wsdd b/src/initscripts/packages/wsdd
index 88fe85ae2ec08adf4f86dbbb8f4084b872f008df..b07fe3ace26197e3ddf918b5ad6fec18de936f75 100644 (file)
--- a/src/initscripts/packages/wsdd
+++ b/src/initscripts/packages/wsdd
@@ -29,18 +29,27 @@ mkdir -p /var/run/wsdd
 
 PIDFILE="/var/run/wsdd.pid"
 
+ARGS=(
+       # Launch as non-privileged user
+       "--user" "wsdd:wsdd"
+
+       # Launch in chroot
+       "--chroot" "/var/run/wsdd"
+
+       # Only use IPv4
+       "--ipv4only"
+)
+
 INTERFACES="--interface ${GREEN_DEV}"
 if [ -n "${BLUE_DEV}" ]; then
         INTERFACES="${INTERFACES} --interface ${BLUE_DEV}"
 fi
 WSDD_WORKGROUP="--workgroup $(/usr/bin/testparm -s --parameter-name workgroup 2>/dev/null)"
-WSDD_USER="--user wsdd:wsdd"
-WSDD_CHROOT="--chroot /var/run/wsdd"
 
 case "$1" in
        start)
                boot_mesg "Starting wsdd daemon..."
-               loadproc -b -p "${PIDFILE}" /usr/bin/wsdd --ipv4only ${WSDD_USER} ${INTERFACES} ${WSDD_WORKGROUP} ${WSDD_CHROOT}
+               loadproc -b -p "${PIDFILE}" /usr/bin/wsdd "${ARGS[@]}" ${INTERFACES} ${WSDD_WORKGROUP}
                ;;
 
        stop)