]> git.ipfire.org Git - ipfire-2.x.git/commitdiff
qos.cgi: Fix truncated status output
authorStefan Schantl <stefan.schantl@ipfire.org>
Fri, 30 Jul 2021 17:57:01 +0000 (19:57 +0200)
committerArne Fitzenreiter <arne_f@ipfire.org>
Sun, 5 Sep 2021 17:42:35 +0000 (17:42 +0000)
In the past only the fist line of the status output has been passed
to the cleanhtml() function and displayed. Now the whole output will be
converted to a string, cleaned and displyed on the WUI again.

Fixes #12666.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org>
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>
Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
html/cgi-bin/qos.cgi

index af41b8d2bdf6ab3d4477db54e3ffde2536d756b4..ab427879e915defd7c8bd44ea85595259bd11c7f 100644 (file)
@@ -534,7 +534,7 @@ elsif ($qossettings{'ACTION'} eq $Lang::tr{'status'} )
        if ($qossettings{'ENABLED'} eq 'on'){
                my $output = "";
                my @output = &General::system_output("/usr/local/bin/qosctrl", "status");
-               $output = &Header::cleanhtml(@output[0],"y");
+               $output = &Header::cleanhtml(join("", @output), "y");
                print "<pre>$output</pre>\n";
        } else { print "$Lang::tr{'QoS not enabled'}"; }
        &Header::closebox();