]> git.ipfire.org Git - ipfire-2.x.git/commitdiff
Pakfire: do not leak upstream proxy password in log messages
authorPeter Müller <peter.mueller@ipfire.org>
Sat, 11 Apr 2020 10:20:01 +0000 (12:20 +0200)
committerArne Fitzenreiter <arne_f@ipfire.org>
Thu, 30 Apr 2020 15:11:54 +0000 (15:11 +0000)
Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>
Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
src/pakfire/lib/functions.pl

index 17a420c33c1f2d8228241aed775195ca85758270..4d5c6219ab2c30bf24a28cb50b3b1b710b9881c2 100644 (file)
@@ -162,7 +162,7 @@ sub fetchfile {
                        logger("DOWNLOAD INFO: Upstream proxy: \"$proxysettings{'UPSTREAM_PROXY'}\"");
                        if ($proxysettings{'UPSTREAM_USER'}) {
                                $ua->proxy(["http", "https"], "http://$proxysettings{'UPSTREAM_USER'}:$proxysettings{'UPSTREAM_PASSWORD'}@"."$proxysettings{'UPSTREAM_PROXY'}/");
-                               logger("DOWNLOAD INFO: Logging in with: \"$proxysettings{'UPSTREAM_USER'}\" - \"$proxysettings{'UPSTREAM_PASSWORD'}\"");
+                               logger("DOWNLOAD INFO: Logging in with \"$proxysettings{'UPSTREAM_USER'}\" against \"$proxysettings{'UPSTREAM_PROXY'}\"");
                        } else {
                                $ua->proxy(["http", "https"], "http://$proxysettings{'UPSTREAM_PROXY'}/");
                        }