Core Update 168: Stop services before extracting files

https://lists.ipfire.org/pipermail/development/2022-May/013398.html

On a general note, we should do so for every Core Update, as it is more
sane to stop services before deleting or overwriting any files.

Reported-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Peter Müller <peter.mueller@ipfire.org>

diff --git a/config/rootfiles/core/168/update.sh b/config/rootfiles/core/168/update.sh
index fd475af3cb561bfe438e81e546c8071e0c08c0a6..1a45ad9cf23d3014ed0a2d6d4f783a014419addb 100644 (file)
--- a/config/rootfiles/core/168/update.sh
+++ b/config/rootfiles/core/168/update.sh
@@ -31,6 +31,12 @@ for (( i=1; i<=$core; i++ )); do
        rm -f /var/cache/pakfire/core-upgrade-*-$i.ipfire
 done
 
+# Stop services
+/etc/init.d/squid stop
+/usr/local/bin/openvpnctrl -k
+/usr/local/bin/openvpnctrl -kn2n
+/etc/init.d/suricata stop
+
 # Remove files
 rm -rvf \
        /lib/firmware/cxgb4/t4fw-1.26.4.0.bin \
@@ -67,12 +73,6 @@ rm -vf \
        /opt/pakfire/db/meta/meta-netbpm \
        /opt/pakfire/db/rootfiles/netbpm
 
-# Stop services
-/etc/init.d/squid stop
-/usr/local/bin/openvpnctrl -k
-/usr/local/bin/openvpnctrl -kn2n
-/etc/init.d/suricata stop
-
 # Extract files
 extract_files