Sometimes incorrect arguments are supplied but the reason is not obvious to
the user. Add some helpful messages.
Signed-off-by: Simon Glass <sjg@chromium.org>
+static void usage(const char *msg)
+ fprintf(stderr, "Error: %s\n", msg);
fprintf(stderr, "Usage: %s -l image\n"
" -l ==> list image header information\n",
params.cmdname);
fprintf(stderr, "Usage: %s -l image\n"
" -l ==> list image header information\n",
params.cmdname);
case 'A':
params.arch = genimg_get_arch_id(optarg);
if (params.arch < 0)
case 'A':
params.arch = genimg_get_arch_id(optarg);
if (params.arch < 0)
+ usage("Invalid architecture");
break;
case 'c':
params.comment = optarg;
break;
case 'c':
params.comment = optarg;
case 'C':
params.comp = genimg_get_comp_id(optarg);
if (params.comp < 0)
case 'C':
params.comp = genimg_get_comp_id(optarg);
if (params.comp < 0)
+ usage("Invalid compression type");
break;
case 'd':
params.datafile = optarg;
break;
case 'd':
params.datafile = optarg;
case 'O':
params.os = genimg_get_os_id(optarg);
if (params.os < 0)
case 'O':
params.os = genimg_get_os_id(optarg);
if (params.os < 0)
+ usage("Invalid operating system");
break;
case 'r':
params.require_keys = 1;
break;
case 'r':
params.require_keys = 1;
params.type = genimg_get_type_id(optarg);
if (params.type < 0) {
show_image_types();
params.type = genimg_get_type_id(optarg);
if (params.type < 0) {
show_image_types();
+ usage("Invalid image type");
params.xflag++;
break;
default:
params.xflag++;
break;
default:
+ usage("Invalid option");
+ usage("Missing output filename");
params.imagefile = argv[optind];
}
params.imagefile = argv[optind];
}
*/
if (tparams->check_params)
if (tparams->check_params (¶ms))
*/
if (tparams->check_params)
if (tparams->check_params (¶ms))
+ usage("Bad parameters for image type");
if (!params.eflag) {
params.ep = params.addr;
if (!params.eflag) {
params.ep = params.addr;