]> git.ipfire.org Git - people/ms/u-boot.git/commitdiff
net: phy: mv88e61xx: Fix uninitialized variable warning
authorTom Rini <trini@konsulko.com>
Tue, 9 May 2017 02:14:32 +0000 (22:14 -0400)
committerTom Rini <trini@konsulko.com>
Fri, 12 May 2017 12:37:30 +0000 (08:37 -0400)
The variable 'res' may be unused uninitialized if our call to
mv88e61xx_port_read (register read) fails and we goto the error
handling section.  In this case we set 'res' to -EIO to indicate why we
failed.

Cc: Joe Hershberger <joe.hershberger@ni.com>
Cc: Chris Packham <judge.packham@gmail.com>
Cc: Kevin Smith <kevin.smith@elecsyscorp.com>
Cc: Prafulla Wadaskar <prafulla@marvell.com>
Signed-off-by: Tom Rini <trini@konsulko.com>
drivers/net/phy/mv88e61xx.c

index a2fd1686fc3b8366aec9ddf7673fee4ee4b9f182..3d2f6b98ad0e3212f3a181bd15752446ba647819 100644 (file)
@@ -655,8 +655,10 @@ static int mv88e61xx_read_port_config(struct phy_device *phydev, u8 port)
                do {
                        val = mv88e61xx_port_read(phydev, port,
                                                  PORT_REG_STATUS);
-                       if (val < 0)
+                       if (val < 0) {
+                               res = -EIO;
                                goto unforce;
+                       }
                        if (val & PORT_REG_STATUS_LINK)
                                break;
                } while (--timeout);