]> git.ipfire.org Git - people/ms/u-boot.git/commitdiff
mmc: dw_mmc: Stop bounce buffer even in case of failure
authorMarek Vasut <marex@denx.de>
Mon, 27 Jul 2015 20:39:36 +0000 (22:39 +0200)
committerPantelis Antoniou <pantelis.antoniou@konsulko.com>
Tue, 11 Aug 2015 17:43:34 +0000 (20:43 +0300)
The driver didn't stop the bounce buffer in case a data transfer
failed. This would lead to memory leakage if the communication
between the CPU and the card is unreliable. Add the missing call
to stop the bounce buffer.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
Cc: Tom Rini <trini@konsulko.com>
drivers/mmc/dw_mmc.c

index 53a8aca84b615e9a8e5e185ac4ad28f6fc00a841..3fffa7116647618a1fa3c60b45bb11728941c95c 100644 (file)
@@ -215,6 +215,7 @@ static int dwmci_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
                        mask = dwmci_readl(host, DWMCI_RINTSTS);
                        if (mask & (DWMCI_DATA_ERR | DWMCI_DATA_TOUT)) {
                                printf("%s: DATA ERROR!\n", __func__);
+                               bounce_buffer_stop(&bbstate);
                                return -1;
                        }
                } while (!(mask & DWMCI_INTMSK_DTO));