]> git.ipfire.org Git - people/ms/u-boot.git/commitdiff
rockchip: dts: rk3399-puma: fix the modelling of BIOS_DISABLE
authorPhilipp Tomsich <philipp.tomsich@theobroma-systems.com>
Mon, 6 Nov 2017 22:02:51 +0000 (23:02 +0100)
committerPhilipp Tomsich <philipp.tomsich@theobroma-systems.com>
Tue, 7 Nov 2017 08:16:56 +0000 (09:16 +0100)
The fixed regulator for overriding BIOS_DISABLE had been modelling
backwards (i.e. the GPIO polarity and the enable-active-low/high
property had both been inverted), causing the 'regulator' command
to always print/expect 'disabled'/'enabled' backwards.

This fixes the mix-up and models it correctly:
 * the GPIO is low-active
 * the regulator should be enabled (enable-active-high) during
   boot-on initialisation

Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Tested-by: Klaus Goger <klaus.goger@theobroma-systems.com>
arch/arm/dts/rk3399-puma.dtsi

index 65ab3801391b50a238e196248db1eecbf0fbbf8b..c4da26956a4265b1411bd904898969d100f70671 100644 (file)
                compatible = "regulator-fixed";
                u-boot,dm-pre-reloc;
                regulator-name = "bios_enable";
-               enable-active-low;
-               gpio = <&gpio3 29 GPIO_ACTIVE_HIGH>;
+               enable-active-high;
+               gpio = <&gpio3 29 GPIO_ACTIVE_LOW>;
                regulator-always-on;
                regulator-boot-on;
                regulator-min-microvolt = <1800000>;